gdb/ChangeLog

   1 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
   2
   3         * NEWS: Mention that Cell/B.E. debugging support was removed.
   4         * MAINTAINERS: Remove spu target.
   5
   6         * config/djgpp/fnchange.lst: Remove entries for removed files.
   7
   8         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
   9         spu-multiarch.o, and spu-tdep.o.
  10         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
  11         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
  12         spu-multiarch.c, and spu-tdep.c.
  13         * spu-linux-nat.c: Remove file.
  14         * spu-multiarch.c: Remove file.
  15         * spu-tdep.c: Remove file.
  16         * spu-tdep.h: Remove file.
  17         * solib-spu.c: Remove file.
  18         * solib-spu.h: Remove file.
  19
  20         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
  21         * configure.nat (spu-linux): Remove.
  22         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
  23         solib-multiarch.o from gdb_target_obs.
  24         (spu*-*-*): Remove.
  25
  26         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
  27         feature flag.
  28         (ppc_linux_no_features): Update.
  29         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
  30         Cell/B.E. support.
  31         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
  32         (tdesc_powerpc_cell64l): Likewise.
  33         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
  34         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
  35         Cell/B.E. support.
  36         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
  37         Do not include "features/rs6000/powerpc-cell32l.c" or
  38         "features/rs6000/powerpc-cell64l.c".
  39         (ppc_linux_spu_section): Remove.
  40         (ppc_linux_core_read_description): Remove Cell/B.E. support.
  41         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
  42         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
  43         (ppc_linux_spe_context_lookup): Remove.
  44         (ppc_linux_spe_context_inferior_created): Remove.
  45         (ppc_linux_spe_context_solib_loaded): Remove.
  46         (ppc_linux_spe_context_solib_unloaded): Remove.
  47         (ppc_linux_spe_context): Remove.
  48         (struct ppu2spu_cache): Remove.
  49         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
  50         (struct ppu2spu_data): Remove.
  51         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
  52         ppu2spu_unwind): Remove.
  53         (ppc_linux_init_abi): Remove Cell/B.E. support.
  54         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
  55
  56         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
  57         (rs6000/powerpc-cell64l-expedite): Likewise
  58         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
  59         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
  60         rs6000/powerpc-cell64l.xml.
  61         * features/rs6000/powerpc-cell32l.xml: Remove.
  62         * features/rs6000/powerpc-cell64l.xml: Likewise.
  63         * features/rs6000/powerpc-cell32l.c: Remove generated file.
  64         * features/rs6000/powerpc-cell64l.c: Likewise.
  65         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
  66         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
  67         * regformats/reg-spu.dat: Remove.
  68
  69         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
  70         * corelow.c (struct spuid_list): Remove.
  71         (add_to_spuid_list): Remove.
  72         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
  73         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
  74         (remote_protocol_features): Remove associated entries.
  75         (_initialize_remote): No longer initialize them.
  76         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
  77         * linux-nat.c (SPUFS_MAGIC): Remove.
  78         (linux_proc_xfer_spu): Remove.
  79         (spu_enumerate_spu_ids): Remove.
  80         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
  81         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
  82         (linux_make_corefile_notes): No longer call it.
  83
  84         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
  85         (cooked_write_test): Likewise.
  86
  87 2019-09-20  Tom Tromey  <tom@tromey.com>
  88
  89         * NEWS: Mention case-sensitivity of TUI commands.
  90         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
  91         (tui_set_win_height_command, parse_scrolling_args): Likewise.
  92         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
  93
  94 2019-09-20  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-source.c (tui_source_window::set_contents): Use
  97         make_unique_xstrdup.
  98         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
  99         make_unique_xstrdup.
 100
 101 2019-09-20  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-data.c: Remove separator comments.
 104         * tui/tui-layout.c: Remove separator comments.
 105         * tui/tui-win.c: Remove separator comments.
 106         * tui/tui-wingeneral.c: Remove separator comments.
 107
 108 2019-09-20  Tom Tromey  <tom@tromey.com>
 109
 110         * tui/tui.h (strcat_to_buf): Don't declare.
 111         * tui/tui.c (strcat_to_buf): Remove.
 112
 113 2019-09-20  Tom Tromey  <tom@tromey.com>
 114
 115         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 116         from "fullname".
 117         * tui/tui-source.c (tui_source_window::set_contents)
 118         (tui_source_window::location_matches_p)
 119         (tui_source_window::maybe_update): Update.
 120
 121 2019-09-20  Tom Tromey  <tom@tromey.com>
 122
 123         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 124         Update.
 125         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 126         prefix.
 127         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 128         (tui_data_window::line_from_reg_element_no)
 129         (tui_data_window::first_reg_element_no_inline)
 130         (tui_data_window::show_registers)
 131         (tui_data_window::show_register_group)
 132         (tui_data_window::display_registers_from)
 133         (tui_data_window::display_registers_from_line)
 134         (tui_data_window::first_data_item_displayed)
 135         (tui_data_window::delete_data_content_windows)
 136         (tui_data_window::erase_data_content)
 137         (tui_data_window::do_scroll_vertical)
 138         (tui_data_window::refresh_window)
 139         (tui_data_window::check_register_values): Update.
 140
 141 2019-09-20  Tom Tromey  <tom@tromey.com>
 142
 143         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 144         (struct tui_locator_window) <full_name, proc_name>: Now
 145         std::string.
 146         * tui/tui-stack.c (tui_locator_window::make_status_line)
 147         (tui_locator_window::set_locator_fullname)
 148         (tui_locator_window::set_locator_info): Update.
 149         * tui/tui-source.c (tui_source_window::set_contents)
 150         (tui_source_window::showing_source_p): Update.
 151
 152 2019-09-20  Tom Tromey  <tom@tromey.com>
 153
 154         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 155         Don't call tui_locator_win_info_ptr.
 156
 157 2019-09-20  Tom Tromey  <tom@tromey.com>
 158
 159         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 160
 161 2019-09-20  Tom Tromey  <tom@tromey.com>
 162
 163         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 164         height for locator.
 165         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 166         * tui/tui-layout.c (show_source_disasm_command, show_data)
 167         (show_source_or_disasm_and_command): Use 1 as height for locator.
 168
 169 2019-09-20  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui.c (tui_enable): Update.
 172         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 173         Update.
 174         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 175         Update.
 176         * tui/tui-data.c (win_resized): Now bool.
 177         (tui_win_resized): Return bool.
 178         (tui_set_win_resized_to): Accept a bool.
 179
 180 2019-09-20  Tom Tromey  <tom@tromey.com>
 181
 182         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 183         Change type of "refresh_values_only".
 184         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 185         type of "refresh_values_only".
 186
 187 2019-09-20  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 190         std::string.
 191         (tui_disassemble): Add "pos" parameter.
 192         (tui_disasm_window::set_contents): Simplify.
 193
 194 2019-09-20  Tom Tromey  <tom@tromey.com>
 195
 196         * tui/tui-winsource.h (struct tui_source_window_base)
 197         <show_source_content>: Now private.
 198         * tui/tui-winsource.c
 199         (tui_source_window_base::show_source_content): Don't handle empty
 200         content case.
 201
 202 2019-09-20  Tom Tromey  <tom@tromey.com>
 203
 204         * tui/tui-layout.c (show_source_disasm_command)
 205         (show_source_or_disasm_and_command): Don't call
 206         show_source_content.
 207
 208 2019-09-20  Tom Tromey  <tom@tromey.com>
 209
 210         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 211         Declare.
 212         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 213         from tui_make_status_line.
 214         (tui_locator_window::rerender): Update.
 215
 216 2019-09-20  Tom Tromey  <tom@tromey.com>
 217
 218         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 219         (tui_locator_window::rerender): Update.
 220
 221 2019-09-20  Tom Tromey  <tom@tromey.com>
 222
 223         * tui/tui-winsource.h (struct tui_source_window_base)
 224         <~tui_source_window_base>: Don't declare.
 225         <fullname>: Remove.
 226         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 227         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 228         member.
 229         * tui/tui-source.c (tui_source_window::set_contents): Update.
 230         (tui_source_window::location_matches_p)
 231         (tui_source_window::maybe_update): Update.
 232
 233 2019-09-20  Tom Tromey  <tom@tromey.com>
 234
 235         * tui/tui-winsource.h (~tui_source_element): Remove.
 236         (tui_source_element): Update.
 237         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 238         * tui/tui-winsource.c (tui_show_source_line): Update.
 239         * tui/tui-source.c (tui_source_window::set_contents): Update.
 240         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 241
 242 2019-09-20  Tom Tromey  <tom@tromey.com>
 243
 244         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 245         declare.
 246         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 247         tui_clear_source_windows_detail.
 248         * tui/tui-winsource.h (struct tui_source_window_base)
 249         <clear_detail>: Don't declare.
 250         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 251         Remove.
 252         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 253
 254 2019-09-20  Tom Tromey  <tromey@adacore.com>
 255
 256         PR ada/24919:
 257         * block.c (contained_in): Fix final return value.
 258
 259 2019-09-20  Alan Modra  <amodra@gmail.com>
 260
 261         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 262         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 263         (read_indirect_string_from_dwz): Use bfd accessor.
 264         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 265         * machoread.c (macho_symfile_read_all_oso): Likewise.
 266         * solib.c (solib_bfd_open): Likewise.
 267
 268 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 269
 270         * eval.c: Move declaration of overload_resolution to...
 271         * value.h: ...here.
 272
 273 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 274
 275         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 276         * arm-linux-tdep.c: Likewise.
 277         * arm-nbsd-nat.c: Likewise.
 278         * arm-tdep.h: Declare arm_apcs_32.
 279         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 280
 281 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 282
 283         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 284         * dwarf2read.h: Declare dwarf_always_disassemble.
 285
 286 2019-09-19  Tom de Vries  <tdevries@suse.de>
 287
 288         PR gdb/25009
 289         * source-cache.c (source_cache::ensure): Catch exception thrown during
 290         construction of the highlighter.
 291
 292 2019-09-18  Alan Modra  <amodra@gmail.com>
 293
 294         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 295         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 296         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 297         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 298         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 299         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 300         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 301         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 302         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 303         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 304         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 305         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 306         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 307         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 308         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 309         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 310         * mi/mi-interp.c: Update throughout for bfd section macro and
 311         function changes.
 312         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 313         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 314
 315 2019-09-18  Tom Tromey  <tom@tromey.com>
 316
 317         * NEWS: Add entry.
 318         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 319         call rl_initialize.
 320         (tui_enable): Do not call rl_initialize.
 321
 322 2019-09-18  Christian Groessler  <chris@groessler.org>
 323
 324         * alpha-linux-nat.c: Include gdbarch.h.
 325
 326 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 327
 328         * ui-file.c: Include cli/cli-style.h.
 329         (term_cli_styling): Remove cli_styling declaration.
 330
 331 2019-09-18  Alan Modra  <amodra@gmail.com>
 332
 333         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 334         to bfd_asymbol_section.
 335
 336 2019-09-18  Alan Modra  <amodra@gmail.com>
 337
 338         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 339         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 340         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 341
 342 2019-09-18  Alan Modra  <amodra@gmail.com>
 343
 344         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 345         * spu-linux-nat.c (spu_bfd_open): Likewise.
 346
 347 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 348
 349         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 350         to bool to match definition in dwarf2read.c.
 351
 352 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 353
 354         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 355         (print_signatures): Likewise.
 356         (trust_pad_over_xvs): Likewise.
 357         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 358         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 359         * arm-linux-nat.c (arm_apcs_32): Likewise.
 360         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 361         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 362         * arm-tdep.c (arm_debug): Likewise.
 363         (arm_apcs_32): Likewise.
 364         * auto-load.c (debug_auto_load): Likewise.
 365         (auto_load_gdb_scripts): Likewise.
 366         (global_auto_load): Likewise.
 367         (auto_load_local_gdbinit): Likewise.
 368         (auto_load_local_gdbinit_loaded): Likewise.
 369         * auto-load.h (global_auto_load): Likewise.
 370         (auto_load_local_gdbinit): Likewise.
 371         (auto_load_local_gdbinit_loaded): Likewise.
 372         * breakpoint.c (disconnected_dprintf): Likewise.
 373         (breakpoint_proceeded): Likewise.
 374         (automatic_hardware_breakpoints): Likewise.
 375         (always_inserted_mode): Likewise.
 376         (target_exact_watchpoints): Likewise.
 377         (_initialize_breakpoint): Update.
 378         * breakpoint.h (target_exact_watchpoints): Change to bool.
 379         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 380         * cli/cli-cmds.c (trace_commands): Likewise.
 381         * cli/cli-cmds.h (trace_commands): Likewise.
 382         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 383         to bool*.
 384         * cli/cli-logging.c (logging_overwrite): Change to bool.
 385         (logging_redirect): Likewise.
 386         (debug_redirect): Likewise.
 387         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 388         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 389         to bool.
 390         <boolean_option_def>: Update.
 391         (struct flag_option_def): Change default type of Context to bool
 392         from int.
 393         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 394         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 395         (get_setshow_command_value_string): Likewise.
 396         * cli/cli-style.c (cli_styling): Change to bool.
 397         (source_styling): Likewise.
 398         * cli/cli-style.h (source_styling): Likewise.
 399         (cli_styling): Likewise.
 400         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 401         to bool.
 402         * command.h (var_types): Update comment.
 403         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 404         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 405         bool.
 406         (debug_compile_cplus_scopes): Likewise.
 407         * compile/compile-internal.h (compile_debug): Likewise.
 408         * compile/compile.c (compile_debug): Likewise.
 409         (struct compile_options) <raw>: Likewise.
 410         * cp-support.c (catch_demangler_crashes): Likewise.
 411         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 412         (usr_cmd_cris_dwarf2_cfi): Likewise.
 413         * csky-tdep.c (csky_debug): Likewise.
 414         * darwin-nat.c (enable_mach_exceptions): Likewise.
 415         * dcache.c (dcache_enabled_p): Likewise.
 416         * defs.h (info_verbose): Likewise.
 417         * demangle.c (demangle): Likewise.
 418         (asm_demangle): Likewise.
 419         * dwarf-index-cache.c (debug_index_cache): Likewise.
 420         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 421         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 422         * dwarf2read.c (check_physname): Likewise.
 423         (use_deprecated_index_sections): Likewise.
 424         (dwarf_always_disassemble): Likewise.
 425         * eval.c (overload_resolution): Likewise.
 426         * event-top.c (set_editing_cmd_var): Likewise.
 427         (exec_done_display_p): Likewise.
 428         * event-top.h (set_editing_cmd_var): Likewise.
 429         (exec_done_display_p): Likewise.
 430         * exec.c (write_files): Likewise.
 431         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 432         (debug_fbsd_nat): Likewise.
 433         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 434         Likewise.
 435         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 436         <backtrace_past_entry> Likewise.
 437         * gdb-demangle.h (demangle): Likewise.
 438         (asm_demangle): Likewise.
 439         * gdb_bfd.c (bfd_sharing): Likewise.
 440         * gdbcore.h (write_files): Likewise.
 441         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 442         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 443         * gdbthread.h (print_thread_events): Likewise.
 444         * gdbtypes.c (opaque_type_resolution): Likewise.
 445         (strict_type_checking): Likewise.
 446         * gnu-nat.c (gnu_debug_flag): Likewise.
 447         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 448         * guile/scm-param.c (pascm_variable): Add boolval.
 449         (add_setshow_generic): Update.
 450         (pascm_param_value): Update.
 451         (pascm_set_param_value_x): Update.
 452         * hppa-tdep.c (hppa_debug): Change to bool..
 453         * infcall.c (may_call_functions_p): Likewise.
 454         (coerce_float_to_double_p): Likewise.
 455         (unwind_on_signal_p): Likewise.
 456         (unwind_on_terminating_exception_p): Likewise.
 457         * infcmd.c (startup_with_shell): Likewise.
 458         * inferior.c (print_inferior_events): Likewise.
 459         * inferior.h (startup_with_shell): Likewise.
 460         (print_inferior_events): Likewise.
 461         * infrun.c (step_stop_if_no_debug): Likewise.
 462         (detach_fork): Likewise.
 463         (debug_displaced): Likewise.
 464         (disable_randomization): Likewise.
 465         (non_stop): Likewise.
 466         (non_stop_1): Likewise.
 467         (observer_mode): Likewise.
 468         (observer_mode_1): Likewise.
 469         (set_observer_mode): Update.
 470         (sched_multi): Change to bool.
 471         * infrun.h (debug_displaced): Likewise.
 472         (sched_multi): Likewise.
 473         (step_stop_if_no_debug): Likewise.
 474         (non_stop): Likewise.
 475         (disable_randomization): Likewise.
 476         * linux-tdep.c (use_coredump_filter): Likewise.
 477         (dump_excluded_mappings): Likewise.
 478         * linux-thread-db.c (auto_load_thread_db): Likewise.
 479         (check_thread_db_on_load): Likewise.
 480         * main.c (captured_main_1): Update.
 481         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 482         xx2_opt, boolean_opt>: Change to bool.
 483         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 484         * maint.c (maintenance_profile_p): Likewise.
 485         (per_command_time): Likewise.
 486         (per_command_space): Likewise.
 487         (per_command_symtab): Likewise.
 488         * memattr.c (inaccessible_by_default): Likewise.
 489         * mi/mi-main.c (mi_async): Likewise.
 490         (mi_async_1): Likewise.
 491         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 492         * nat/fork-inferior.h (startup_with_shell): Likewise.
 493         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 494         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 495         * nios2-tdep.c (nios2_debug): Likewise.
 496         * or1k-tdep.c (or1k_debug): Likewise.
 497         * parse.c (parser_debug): Likewise.
 498         * parser-defs.h (parser_debug): Likewise.
 499         * printcmd.c (print_symbol_filename): Likewise.
 500         * proc-api.c (procfs_trace): Likewise.
 501         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 502         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 503         (set_parameter_value): Update.
 504         (add_setshow_generic): Update.
 505         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 506         to bool*.
 507         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 508         int*.
 509         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 510         * record-btrace.c (record_btrace_target::store_registers): Update.
 511         * record-full.c (record_full_memory_query): Change to bool.
 512         (record_full_stop_at_limit): Likewise.
 513         * record-full.h (record_full_memory_query): Likewise.
 514         * remote-notif.c (notif_debug): Likewise.
 515         * remote-notif.h (notif_debug): Likewise.
 516         * remote.c (use_range_stepping): Likewise.
 517         (interrupt_on_connect): Likewise.
 518         (remote_break): Likewise.
 519         * ser-tcp.c (tcp_auto_retry): Likewise.
 520         * ser-unix.c (serial_hwflow): Likewise.
 521         * skip.c (debug_skip): Likewise.
 522         * solib-aix.c (solib_aix_debug): Likewise.
 523         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 524         (spu_auto_flush_cache_p): Likewise.
 525         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 526         Likewise.
 527         (struct info_print_options) <quiet>: Likewise.
 528         * symfile-debug.c (debug_symfile): Likewise.
 529         * symfile.c (auto_solib_add): Likewise.
 530         (separate_debug_file_debug): Likewise.
 531         * symfile.h (auto_solib_add): Likewise.
 532         (separate_debug_file_debug): Likewise.
 533         * symtab.c (basenames_may_differ): Likewise.
 534         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 535         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 536         (struct info_types_options) <quiet>: Likewise.
 537         * symtab.h (demangle): Likewise.
 538         (basenames_may_differ): Likewise.
 539         * target-dcache.c (stack_cache_enabled_1): Likewise.
 540         (code_cache_enabled_1): Likewise.
 541         * target.c (trust_readonly): Likewise.
 542         (may_write_registers): Likewise.
 543         (may_write_memory): Likewise.
 544         (may_insert_breakpoints): Likewise.
 545         (may_insert_tracepoints): Likewise.
 546         (may_insert_fast_tracepoints): Likewise.
 547         (may_stop): Likewise.
 548         (auto_connect_native_target): Likewise.
 549         (target_stop_and_wait): Update.
 550         (target_async_permitted): Change to bool.
 551         (target_async_permitted_1): Likewise.
 552         (may_write_registers_1): Likewise.
 553         (may_write_memory_1): Likewise.
 554         (may_insert_breakpoints_1): Likewise.
 555         (may_insert_tracepoints_1): Likewise.
 556         (may_insert_fast_tracepoints_1): Likewise.
 557         (may_stop_1): Likewise.
 558         * target.h (target_async_permitted): Likewise.
 559         (may_write_registers): Likewise.
 560         (may_write_memory): Likewise.
 561         (may_insert_breakpoints): Likewise.
 562         (may_insert_tracepoints): Likewise.
 563         (may_insert_fast_tracepoints): Likewise.
 564         (may_stop): Likewise.
 565         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 566         (make_thread_apply_all_options_def_group): Change argument from int*
 567         to bool*.
 568         (thread_apply_all_command): Update.
 569         (print_thread_events): Change to bool.
 570         * top.c (confirm): Likewise.
 571         (command_editing_p): Likewise.
 572         (history_expansion_p): Likewise.
 573         (write_history_p): Likewise.
 574         (info_verbose): Likewise.
 575         * top.h (confirm): Likewise.
 576         (history_expansion_p): Likewise.
 577         * tracepoint.c (disconnected_tracing): Likewise.
 578         (circular_trace_buffer): Likewise.
 579         * typeprint.c (print_methods): Likewise.
 580         (print_typedefs): Likewise.
 581         * utils.c (debug_timestamp): Likewise.
 582         (sevenbit_strings): Likewise.
 583         (pagination_enabled): Likewise.
 584         * utils.h (sevenbit_strings): Likewise.
 585         (pagination_enabled): Likewise.
 586         * valops.c (overload_resolution): Likewise.
 587         * valprint.h (struct value_print_options) <prettyformat_arrays,
 588         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 589         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 590         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 591         Likewise.
 592         * windows-nat.c (new_console): Likewise.
 593         (cygwin_exceptions): Likewise.
 594         (new_group): Likewise.
 595         (debug_exec): Likewise.
 596         (debug_events): Likewise.
 597         (debug_memory): Likewise.
 598         (debug_exceptions): Likewise.
 599         (useshell): Likewise.
 600         * windows-tdep.c (maint_display_all_tib): Likewise.
 601         * xml-support.c (debug_xml): Likewise.
 602
 603 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 604
 605         * source.c (prepare_path_for_appending): New function.
 606         (openp): Make use of new function.
 607         (find_and_open_source): Search for the compilation directory and
 608         source file as a relative path beneath the directory search path.
 609
 610 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 611
 612         * source-cache.c (source_cache::get_line_charpos): Catch
 613         exceptions and return false, this matches the behaviour documented
 614         in the header file.
 615
 616 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 617
 618         * ada-tasks.c (info_task): Remove quoting of the task's name.
 619
 620 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
 621
 622         * symfile.c (auto_solib_add): Replace comment with a reference
 623         to the header file.
 624
 625 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
 626
 627         * NEWS: Mention that gdb can now be compiled with Python 3
 628         on Windows.
 629
 630 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         * maint.c (maint_print_section_data::maint_print_section_data):
 633         Force use of 'float log10 (float)' by casting the argument to
 634         float.
 635
 636 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 637
 638         * maint.c: Add 'cmath' include.
 639         (struct maint_print_section_data): New structure.
 640         (print_section_index): New function.
 641         (print_bfd_section_info): Add header comment, small whitespace
 642         cleanup, and update to call new print_section_index function.
 643         (print_objfile_section_info): Likewise.
 644         (maint_obj_section_from_bfd_section): New function.
 645         (print_bfd_section_info_maybe_relocated): New function.
 646         (maintenance_info_sections): Add header comment, always use
 647         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
 648
 649 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 650
 651         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
 652         inner scope, add check that the objfile has psymtabs before
 653         checking psymtabs_addrmap.
 654         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
 655
 656 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 657
 658         * NEWS: Announce that Ada task names are now shown at more places,
 659         and between quotes (except in info task output).
 660         * gdb/ada-tasks.c (task_to_str): New function.
 661         (display_current_task_id): Call task_to_str.
 662         (task_command_1): Likewise.
 663         (print_ada_task_info): In non-mi mode, Properly align headers and data
 664         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
 665
 666 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 667
 668         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
 669         prstatus.pr_lwp.pr_info instead of making it up.
 670
 671 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 672
 673         * auto-load.c (auto_load_expand_dir_vars): Update.
 674         * defs.h (gdb_datadir): Change to std::string.
 675         (python_libdir): Likewise.
 676         (relocate_gdb_directory): Change return type to std::string.
 677         * guile/guile.c (gdbscm_data_directory): Update.
 678         (initialize_scheme_side): Update.
 679         * jit.c (jit_reader_dir): Change to std::string.
 680         (jit_reader_load_command): Update.
 681         * main.c (gdb_datadir): Change to std::string.
 682         (python_libdir): Likewise.
 683         (set_gdb_data_directory): Update.
 684         (relocate_path): Change to return std::string.
 685         (relocate_gdb_directory): Change to return std::string.
 686         (relocate_gdbinit_path_maybe_in_datadir): Update.
 687         (captured_main_1): Update.
 688         * python/python.c (do_start_initialization): Update.
 689         * top.c (show_gdb_datadir): Update.
 690         * xml-syscall.c (xml_init_syscalls_info): Update.
 691         (init_syscalls_info): Update.
 692
 693 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 694
 695         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
 696         out of get_init_files.
 697         (get_init_files): Update.
 698
 699 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 700
 701         * main.c (get_init_files): Change to use std::string.
 702         (captured_main_1): Update.
 703         (print_gdb_help): Update.
 704
 705 2019-09-11  Ali Tamur  <tamur@google.com>
 706
 707         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
 708         implementation.
 709
 710 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
 711
 712         * dbxread.c (read_dbx_symtab): Update.
 713         * dwarf2read.c (load_partial_dies): Update.
 714         * mdebugread.c (parse_partial_symbols): Update.
 715         (handle_psymbol_enumerators): Update.
 716         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
 717         * psymtab.c (add_psymbol_to_bcache): Likewise.
 718         (add_psymbol_to_list): Likewise.
 719         * symtab.c (symbol_set_names): Likewise.
 720         * symtab.h (symbol_set_names): Likewise.
 721         * xcoffread.c (scan_xcoff_symtab): Update.
 722
 723 2019-09-11  Tom Tromey  <tom@tromey.com>
 724
 725         * symfile-mem.c (symbol_file_add_from_memory): Use
 726         bfd_set_filename.
 727         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
 728         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
 729
 730 2019-09-10  Tom Tromey  <tromey@adacore.com>
 731
 732         * dwarf-index-write.c (write_psymbols): Extend error message.
 733         (debug_names::insert): Add Ada code.
 734         (debug_names::write_psymbols): Remove Ada check.
 735         (debug_names) <m_string_obstack>: New member.
 736         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
 737         (gdb_index_symbol_name_matcher::matches): Remove.
 738         (mapped_index_base::find_name_components_bounds): Add "lang"
 739         parameter.
 740         (mapped_index_base::build_name_components): Also split names
 741         according to Ada syntax.
 742         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
 743         type of "match_callback".
 744         (check_match, check_find_bounds_finds)
 745         (dw2_expand_symtabs_matching): Update.
 746         (dw2_debug_names_iterator): Add new constructor.
 747         (dw2_debug_names_map_matching_symbols): New function.
 748         (dw2_debug_names_expand_symtabs_matching): Update.
 749         (dwarf2_debug_names_functions): Use
 750         dw2_debug_names_map_matching_symbols.
 751
 752 2019-09-10  Tom Tromey  <tromey@adacore.com>
 753
 754         * dwarf2read.c (dw2_get_file_names_reader): Add the
 755         CU's file name to the results.
 756
 757 2019-09-10  Tom Tromey  <tromey@adacore.com>
 758
 759         * ada-lang.c (add_nonlocal_symbols): Combine calls to
 760         map_matching_symbols.  Update.
 761         * dwarf2read.c (dw2_map_matching_symbols): Update.
 762         * psymtab.c (match_partial_symbol): Change type; update.
 763         (psym_map_matching_symbols): Likewise.
 764         * symfile-debug.c (debug_qf_map_matching_symbols): Change
 765         type; update.
 766         * symfile.h (struct quick_symbol_functions)
 767         <map_matching_symbols>: Change "name" to be a lookup_name_info.
 768         Remove "match".
 769
 770 2019-09-10  Tom Tromey  <tromey@adacore.com>
 771
 772         * psymtab.c (map_block): Remove.
 773         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
 774         * symtab.c (iterate_over_symbols_terminated): New function.
 775         * symtab.c (iterate_over_symbols_terminated): Declare.
 776
 777 2019-09-10  Tom Tromey  <tromey@adacore.com>
 778
 779         * ada-lang.c (ada_iterate_over_symbols): Return bool.
 780         * language.h (struct language_defn) <la_iterate_over_symbols>:
 781         Return bool.
 782         * symtab.c (iterate_over_symbols): Return bool.
 783         * symtab.h (iterate_over_symbols): Return bool.
 784
 785 2019-09-10  Tom Tromey  <tromey@adacore.com>
 786
 787         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
 788         (add_nonlocal_symbols): Update.
 789         * dwarf2read.c (dw2_map_matching_symbols): Change type.
 790         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
 791         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
 792         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
 793         Change type of "callback".  Remove "data".
 794
 795
 796 2019-09-09  Ali Tamur  <tamur@google.com>
 797
 798         * dwarf2read.c (comp_unit_head): Update comment.
 799         (dwarf2_dwo_name): New function declaration.
 800         (dwarf_unit_type_name): New function declaration.
 801         (read_comp_unit_head): Add support for new compilation units,
 802         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
 803         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
 804         (currently named as "signature") in their header. Also clarify error
 805         messages.
 806         (lookup_dwo_id): New function. Returns the dwo id of the given
 807         compile unit.
 808         (lookup_dwo_unit): Use the new lookup_dwo_id function.
 809         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
 810         functions.
 811         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
 812         (dwarf2_dwo_name): Get the dwo name if present.
 813         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
 814         purposes.
 815
 816 2019-09-09  Tom Tromey  <tom@tromey.com>
 817
 818         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
 819
 820 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 821
 822         * python/python.c (do_start_initialization): Make progname_copy static,
 823         to avoid a leak report.
 824
 825 2019-09-08  Tom Tromey  <tom@tromey.com>
 826
 827         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
 828
 829 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
 830
 831         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
 832         Change type to gdb::optional<block_enum>.
 833         (dw2_symtab_iter_init): Change block_index parameter type
 834         to gdb::optional<block_enum>.
 835         (dw2_lookup_symbol): Change block_index parameter
 836         type to block_enum.c
 837         (dw2_debug_names_lookup_symbol): Likewise.
 838         * psymtab.c (psym_lookup_symbol): Likewise.
 839         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
 840         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
 841         Likewise.
 842
 843 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
 844
 845         * defs.h (relocate_gdb_directory): Change int to bool in
 846         signature and rename flag to relocatable.
 847         * main.c (relocate_path): Likewise.
 848         (relocate_gdb_directory): Likewise.
 849
 850 2019-09-06  Alan Modra  <amodra@gmail.com>
 851
 852         * coffread.c (coff_symfile_read): Constify filename variable.
 853         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
 854         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
 855         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
 856         * solib.c (reload_shared_libraries_1): Likewise.
 857         * symfile.c (reread_symbols): Likewise.
 858         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
 859         * solib-darwin.c (darwin_bfd_open): Likewise.
 860         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
 861
 862 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 863
 864         * psymtab.c (print_partial_symbols): Handle missing domain_enum
 865         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
 866
 867 2019-09-03  Tom Tromey  <tromey@adacore.com>
 868
 869         * ada-valprint.c (ada_val_print_num): Don't recurse for range
 870         types.
 871         (has_negatives): Unbias a range type bound.
 872         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
 873         * gdbtypes.c (operator==): Handle new field.
 874         (create_range_type): Add "bias" parameter.
 875         (create_static_range_type, resolve_dynamic_range): Update.
 876         * gdbtypes.h (struct range_bounds) <bias>: New member.
 877         (create_range_type): Add bias parameter.
 878         * printcmd.c (print_scalar_formatted): Unbias range types.
 879         * value.c (unpack_long): Unbias range types.
 880         (pack_long): Bias range types.
 881
 882 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 883
 884         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
 885         probe arguments.
 886
 887 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 888
 889         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
 890         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
 891         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
 892         (compile_probe_arg): Likewise.
 893         * probe.h (get_argument_count): Likewise.
 894         * solib-svr4.c (solib_event_probe_action): Likewise.
 895         * stap-probe.c (stap_probe::get_argument_count): Likewise.
 896
 897 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
 898
 899         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
 900         code to here...
 901         (svr4_create_solib_event_breakpoints): ...from here.
 902
 903 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
 904
 905         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
 906         suffix from warning message.
 907
 908 2019-08-30  Tom Tromey  <tom@tromey.com>
 909
 910         * tui/tui-winsource.h (struct tui_source_window_base)
 911         <refresh_all>: Don't declare.
 912         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
 913         Remove.
 914         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
 915         tui_show_locator_content.
 916         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
 917         declare.
 918         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
 919         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
 920         declare.
 921
 922 2019-08-30  Tom Tromey  <tom@tromey.com>
 923
 924         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
 925
 926 2019-08-30  Tom Tromey  <tom@tromey.com>
 927
 928         * tui/tui-stack.c (_initialize_tui_stack): Move later.
 929         Remove unnecessary forward declarations.
 930
 931 2019-08-30  Tom Tromey  <tom@tromey.com>
 932
 933         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
 934         rerender.
 935         (tui_update_locator_fullname, tui_show_frame_info): Don't call
 936         tui_show_locator_content.
 937
 938 2019-08-30  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
 941         (tui_locator_window::rerender): Rewrite using body of previous
 942         tui_show_locator_content.
 943
 944 2019-08-30  Tom Tromey  <tom@tromey.com>
 945
 946         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
 947         set_locator_fullname>: New methods.
 948         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 949         Rename from tui_set_locator_fullname.
 950         (tui_locator_window::set_locator_info): Rename from
 951         tui_set_locator_info.  Return bool.
 952         (tui_update_locator_fullname, tui_show_frame_info): Update.
 953
 954 2019-08-30  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
 957
 958 2019-08-30  Tom Tromey  <tom@tromey.com>
 959
 960         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
 961         call touchwin.
 962
 963 2019-08-30  Tom Tromey  <tom@tromey.com>
 964
 965         * tui/tui-wingeneral.c (box_win): Assume win_info and
 966         win_info->handle cannot be NULL.
 967
 968 2019-08-30  Tom Tromey  <tom@tromey.com>
 969
 970         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
 971         refresh_window>: Declare.
 972         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
 973         resize.
 974         (tui_data_item_window::rerender): Rename from
 975         tui_display_register.
 976         (tui_data_item_window::refresh_window): New method.
 977         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
 978         no-op.
 979
 980 2019-08-30  Tom Tromey  <tom@tromey.com>
 981
 982         * tui/tui-regs.h (struct tui_data_window) <regs_content,
 983         regs_column_count, current_group>: Move later.  Now private.
 984         <get_current_group>: New method.
 985         * tui/tui-regs.c (tui_reg_command): Update.
 986         * tui/tui-layout.c (tui_set_layout): Update.
 987
 988 2019-08-30  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
 991         (tui_data_window::rerender): Don't call
 992         check_and_display_highlight_if_needed.
 993         (tui_data_window::refresh_all): Remove call to
 994         erase_data_content.
 995
 996 2019-08-30  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 999         (tui_data_window::display_registers_from)
1000         (tui_data_window::display_reg_element_at_line)
1001         (tui_data_window::display_registers_from_line): Remove checks of
1002         "empty".
1003
1004 2019-08-30  Tom Tromey  <tom@tromey.com>
1005
1006         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1007         Don't declare.
1008         * tui/tui-regs.c (tui_data_window::show_registers): Call
1009         rerender.
1010         (tui_data_window::rerender): Rename from display_all_data.
1011         (tui_data_window::rerender): Remove old implementation.
1012
1013 2019-08-30  Tom Tromey  <tom@tromey.com>
1014
1015         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1016         text.
1017         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1018
1019 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1020             Sergio Durigan Junior  <sergiodj@redhat.com>
1021
1022         PR win32/24284
1023         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1024
1025 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1028         when searching for types.
1029
1030 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * f-lang.c (f_language_defn): Use f_print_typedef.
1033         * f-lang.h (f_print_typedef): Declare.
1034         * f-typeprint.c (f_print_typedef): Define.
1035
1036 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1037
1038         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1039
1040 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1041
1042         * cli/cli-utils.c (info_print_options_defs): Delete.
1043         (make_info_print_options_def_group): Delete.
1044         (extract_info_print_options): Delete.
1045         (info_print_command_completer): Delete.
1046         (info_print_args_help): Add extra parameter, and optionally
1047         include text about -n flag.
1048         * cli/cli-utils.h (struct info_print_options): Delete.
1049         (extract_info_print_options): Delete declaration.
1050         (info_print_command_completer): Delete declaration.
1051         (info_print_args_help): Add extra parameter, extend header
1052         comment.
1053         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1054         search_symbols.
1055         * stack.c (struct info_print_options): New type.
1056         (info_print_options_defs): New file scoped variable.
1057         (make_info_print_options_def_group): New static function.
1058         (info_print_command_completer): New static function.
1059         (info_locals_command): Update to use new local functions.
1060         (info_args_command): Likewise.
1061         (_initialize_stack): Add extra parameter to calls to
1062         info_print_args_help.
1063         * symtab.c (search_symbols): Add extra parameter, use this to
1064         possibly excluse non-debug symbols.
1065         (symtab_symbol_info): Add extra parameter, which is passed on to
1066         search_symbols.
1067         (struct info_print_options): New type.
1068         (info_print_options_defs): New file scoped variable.
1069         (make_info_print_options_def_group): New static function.
1070         (info_print_command_completer): New static function.
1071         (info_variables_command): Update to use local functions, and pass
1072         extra parameter through to symtab_symbol_info.
1073         (info_functions_command): Likewise.
1074         (info_types_command): Pass additional argument through to
1075         symtab_symbol_info.
1076         (rbreak_command): Pass extra argument to search_symbols.
1077         (_initialize_symtab): Add extra arguments for calls to
1078         info_print_args_help, and update help text for 'info variables',
1079         'whereis', and 'info functions' commands.
1080         * symtab.h (search_symbols): Add extra argument to declaration.
1081         * NEWS: Mention new flags.
1082
1083 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1084
1085         * symtab.c (lookup_static_symbol): Call the new function (and move
1086         it down to be next to lookup_global_symbol).
1087         (struct global_sym_lookup_data): Add block_enum member and rename to...
1088         (struct global_or_static_sym_lookup_data): ...this.
1089         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1090         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1091         (lookup_symbol_global_or_static_iterator_cb): ...this.
1092         (lookup_global_or_static_symbol): New function.
1093         (lookup_global_symbol): Call new function.
1094
1095 2019-08-26  Tom de Vries  <tdevries@suse.de>
1096
1097         PR c++/24852
1098         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1099         when pc_probe.prob == NULL.
1100
1101 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1102
1103         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1104         variable symbol_linkage to symbol_linkage_.
1105
1106 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1107
1108         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1109         represent whether the symbol is static, dynamic, or we don't
1110         know.
1111
1112 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1113
1114         * gdb/rx-tdep.c (rx_register_names): New.
1115         (rx_register_name): Delete.
1116         (rx_psw_type): Delete.
1117         (rx_fpsw_type): Delete.
1118         (rx_register_type): Delete.
1119         (rx_gdbarch_init): Convert target-descriptions.
1120         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1121         * gdb/features/Makefile: Add rx.xml.
1122         * gdb/features/rx.xml: New.
1123         * gdb/features/rx.c: Generated.
1124         * gdb/NEWS: Mention target description support.
1125
1126 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1127
1128         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1129         *slot_ptr.
1130
1131 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1132
1133         * configure.ac: Don't check for 'dlfcn.h' (moved to
1134         gdbsupport/common.m4).
1135         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1136         'gdbsupport/'.
1137         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1138         * compile/compile-c-support.c: Include
1139         'gdbsupport/gdb-dlfcn.h'.
1140         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1141         * gdb-dlfcn.c: Move to...
1142         * gdbsupport/gdb-dlfcn.c: ... here.
1143         * gdb-dlfcn.h: Move to...
1144         * gdbsupport/gdb-dlfcn.h: ... here.
1145
1146 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1147
1148         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1149         the offset field signed.
1150
1151 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1152
1153         * python/lib/gdb/__init__.py (_execute_file): New function.
1154         * python/python.c (python_run_simple_file): Call gdb._execute_file
1155         on Windows.
1156
1157 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1158
1159         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1160         all uses as this was never set to anything but a zero value.
1161
1162 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1163
1164         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1165
1166 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1167
1168         * tui/tui-data.h (tui_gen_win_info): Add an =default
1169         move constructor, required by some GCC versions.
1170
1171 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1172
1173         * go32-nat.c (go32_sysinfo): Add hygon_p.
1174
1175 2019-08-20  Tom Tromey  <tom@tromey.com>
1176
1177         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1178         line_from_reg_element_no, first_reg_element_no_inline,
1179         display_all_data, delete_data_content_windows,
1180         erase_data_content>: Now private.
1181
1182 2019-08-20  Tom Tromey  <tom@tromey.com>
1183
1184         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1185         (tui_unhighlight_win, tui_highlight_win)
1186         (tui_win_info::make_window): Update.
1187         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1188
1189 2019-08-20  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1192         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1193         (MAX_PID_WIDTH): Move to tui-stack.c.
1194         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1195         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1196         (MAX_PID_WIDTH): Move from tui-data.h.
1197
1198 2019-08-20  Tom Tromey  <tom@tromey.com>
1199
1200         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1201         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1202         (box_win): Update.
1203         (tui_gen_win_info::make_window): Rename from tui_make_window.
1204         (tui_win_info::make_window): New method.
1205         (tui_gen_win_info::make_visible): Update.
1206         * tui/tui-source.c (tui_source_window::set_contents): Update.
1207         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1208         (tui_data_window::display_registers_from): Update.
1209         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1210         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1211         Declare.
1212         <can_box>: Remove.
1213         <title>: Remove.
1214         (struct tui_win_info) <make_window>: Declare.
1215         <can_box>: Now virtual.
1216         <title>: New member.
1217         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1218         * tui/tui-command.c (tui_cmd_window::resize): Update.
1219
1220 2019-08-20  Tom Tromey  <tom@tromey.com>
1221
1222         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1223         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1224         (tui_data_window::check_register_values): Update.
1225
1226 2019-08-20  Tom Tromey  <tom@tromey.com>
1227
1228         * tui/tui-regs.h (struct tui_data_window): Use
1229         DISABLE_COPY_AND_ASSIGN.
1230         <regs_content>: Change type, removing unique_ptr.
1231         <tui_data_window>: Add move constructor.
1232         * tui/tui-regs.c (tui_data_window::show_registers)
1233         (tui_data_window::show_register_group)
1234         (tui_data_window::display_registers_from)
1235         (tui_data_window::display_registers_from)
1236         (tui_data_window::first_data_item_displayed)
1237         (tui_data_window::delete_data_content_windows)
1238         (tui_data_window::rerender, tui_data_window::refresh_window)
1239         (tui_data_window::check_register_values): Update.
1240
1241 2019-08-20  Tom Tromey  <tom@tromey.com>
1242
1243         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1244         show_register_group>: Declare.
1245         (tui_show_register_group): Don't declare.
1246         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1247         tui_show_registers.
1248         (tui_data_window::show_register_group): Rename from
1249         tui_show_register_group.
1250         (tui_data_window::check_register_values, tui_reg_command):
1251         Update.
1252         * tui/tui-layout.c (tui_set_layout): Update.
1253
1254 2019-08-20  Tom Tromey  <tom@tromey.com>
1255
1256         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1257         Declare.
1258         (tui_check_register_values): Don't declare.
1259         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1260         from tui_check_register_values.
1261         * tui/tui-hooks.c (tui_register_changed): Update.
1262
1263 2019-08-20  Tom Tromey  <tom@tromey.com>
1264
1265         * tui/tui-regs.c (tui_reg_layout): Move later.
1266         (tui_show_registers): Don't enable TUI mode or change layout.
1267
1268 2019-08-20  Tom Tromey  <tom@tromey.com>
1269
1270         * tui/tui-regs.h (struct tui_data_item_window)
1271         <~tui_data_item_window>: Remove.
1272         <content>: Now a unique_xmalloc_ptr.
1273         * tui/tui-regs.c (tui_register_format): Return a
1274         unique_xmalloc_ptr.
1275         (tui_get_register): Update.
1276         (~tui_data_item_window): Remove.
1277         (tui_data_window::display_registers_from, tui_display_register):
1278         Update.
1279         * tui/tui-io.h (tui_expand_tabs): Update.
1280         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1281         Remove "col" parameter.
1282
1283 2019-08-20  Tom Tromey  <tom@tromey.com>
1284
1285         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1286         field.
1287         * tui/tui-regs.c (~tui_data_item_window): Update.
1288
1289 2019-08-20  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1292         earlier.
1293
1294 2019-08-20  Tom Tromey  <tom@tromey.com>
1295
1296         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1297
1298 2019-08-20  Tom Tromey  <tom@tromey.com>
1299
1300         * tui/tui-source.h (struct tui_source_window): Update.
1301         * tui/tui-regs.c (tui_show_registers): Update.
1302         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1303         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1304         (NO_REGS_STRING): Remove defines.
1305
1306 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1307
1308         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1309         unnecessary thread walk if remote doesn't support the packet.
1310
1311 2019-08-19  Tom Tromey  <tromey@adacore.com>
1312
1313         * python/py-value.c (value_has_field): Fix indentation.
1314
1315 2019-08-19  Tom Tromey  <tromey@adacore.com>
1316
1317         * printcmd.c (do_one_display, info_display_command): Update.
1318         * block.h (contained_in): Return bool.  Add allow_nested
1319         parameter.
1320         * block.c (contained_in): Return bool.  Add allow_nested
1321         parameter.
1322
1323 2019-08-19  Tom Tromey  <tom@tromey.com>
1324
1325         * configure: Rebuild.
1326         * configure.ac: Disallow the combination of -static-libstdc++ and
1327         source highlight.
1328         * source-cache.c (get_language_name): Handle rust.
1329         (source_cache::get_source_lines): Ignore highlighting exceptions.
1330
1331 2019-08-16  Tom Tromey  <tom@tromey.com>
1332
1333         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1334         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1335         (struct tui_source_window_base) <make_visible, refresh_window,
1336         resize>: Remove methods.
1337         <execution_info>: Remove field.
1338         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1339         (tui_show_source_line, tui_source_window_base)
1340         (~tui_source_window_base): Update.
1341         (tui_source_window_base::resize)
1342         (tui_source_window_base::make_visible)
1343         (tui_source_window_base::refresh_window): Remove.
1344         (tui_source_window_base::update_exec_info): Update.
1345         * tui/tui-source.c (tui_source_window::set_contents): Update.
1346         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1347
1348 2019-08-16  Tom Tromey  <tom@tromey.com>
1349
1350         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1351         deprecated_query_hook.
1352
1353 2019-08-16  Tom Tromey  <tom@tromey.com>
1354
1355         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1356         (tui_update_source_windows_with_line): Update.
1357         * tui/tui-source.h (struct tui_source_window)
1358         <show_symtab_source>: Declare.
1359         (tui_show_symtab_source): Don't declare.
1360         * tui/tui-source.c (tui_show_symtab_source): Rename from
1361         tui_show_symtab_source.
1362
1363 2019-08-16  Tom Tromey  <tom@tromey.com>
1364
1365         * tui/tui-winsource.h (struct tui_source_window_base)
1366         <set_contents>: Declare.
1367         * tui/tui-winsource.c
1368         (tui_source_window_base::update_source_window_as_is): Update.
1369         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1370         Declare.
1371         (tui_set_source_content): Don't declare.
1372         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1373         tui_set_source_content.
1374         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1375         Declare.
1376         (tui_set_disassem_content): Don't declare.
1377         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1378         tui_set_disassem_content.
1379
1380 2019-08-16  Tom Tromey  <tom@tromey.com>
1381
1382         * tui/tui-winsource.h (struct tui_source_window_base)
1383         <update_breakpoint_info>: Declare.
1384         (tui_update_breakpoint_info): Don't declare.
1385         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1386         (tui_update_all_breakpoint_info): Update.
1387         (tui_source_window_base::update_breakpoint_info): Rename from
1388         tui_update_breakpoint_info.
1389         (tui_source_window_base::update_exec_info): Update.
1390
1391 2019-08-16  Tom Tromey  <tom@tromey.com>
1392
1393         * tui/tui-winsource.h (struct tui_source_window_base)
1394         <update_source_window>: Declare.
1395         (tui_update_source_window): Don't declare.
1396         * tui/tui-winsource.c
1397         (tui_source_window_base::update_source_window): Rename from
1398         tui_update_source_window.
1399         (tui_source_window_base::rerender): Update.
1400         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1401         * tui/tui-disasm.c (tui_show_disassem)
1402         (tui_show_disassem_and_update_source)
1403         (tui_disasm_window::maybe_update): Update.
1404
1405 2019-08-16  Tom Tromey  <tom@tromey.com>
1406
1407         * tui/tui-winsource.h (struct tui_source_window_base)
1408         <update_source_window_as_is>: Declare.
1409         (tui_update_source_window_as_is): Don't declare.
1410         * tui/tui-winsource.c (tui_update_source_window): Update
1411         (tui_source_window_base::update_source_window_as_is): Rename from
1412         tui_update_source_window_as_is.
1413         (tui_source_window_base::refill): Update.
1414         * tui/tui-source.c (tui_show_symtab_source): Update.
1415         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1416         Update.
1417
1418 2019-08-16  Tom Tromey  <tom@tromey.com>
1419
1420         * tui/tui-winsource.h (tui_update_source_window)
1421         (tui_update_source_window_as_is): Remove "noerror" parameter.
1422         * tui/tui-winsource.c (tui_update_source_window)
1423         (tui_update_source_window_as_is): Remove "noerror" parameter.
1424         (tui_update_source_windows_with_addr)
1425         (tui_update_source_windows_with_line)
1426         (tui_source_window_base::rerender)
1427         (tui_source_window_base::refill): Update.
1428         * tui/tui-source.h (tui_set_source_content)
1429         (tui_show_symtab_source): Remove "noerror" parameter.
1430         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1431         parameter.
1432         (tui_show_symtab_source): Likewise.
1433         (tui_source_window::maybe_update): Update.
1434         * tui/tui-disasm.c (tui_show_disassem)
1435         (tui_show_disassem_and_update_source)
1436         (tui_disasm_window::do_scroll_vertical)
1437         (tui_disasm_window::maybe_update): Update.
1438
1439 2019-08-16  Tom Tromey  <tom@tromey.com>
1440
1441         * tui/tui.c (tui_is_window_visible): Update.
1442         * tui/tui-wingeneral.c (tui_make_window)
1443         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1444         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1445         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1446         (tui_set_win_height_command, parse_scrolling_args): Update.
1447         * tui/tui-source.c (tui_source_window::style_changed): Update.
1448         * tui/tui-regs.c (tui_show_registers)
1449         (tui_data_window::first_data_item_displayed)
1450         (tui_data_window::delete_data_content_windows)
1451         (tui_check_register_values, tui_reg_command): Update.
1452         * tui/tui-disasm.c (tui_show_disassem): Update.
1453         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1454         method.
1455         <is_visible>: Remove field.
1456         * tui/tui-data.c (tui_next_win, tui_prev_win)
1457         (tui_delete_invisible_windows): Update.
1458
1459 2019-08-16  Tom Tromey  <tom@tromey.com>
1460
1461         * tui/tui-winsource.h (struct tui_source_window_base)
1462         <m_has_locator>: Remove.
1463         * tui/tui-layout.c (show_source_disasm_command, show_data)
1464         (show_source_or_disasm_and_command): Update.
1465
1466 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1467
1468         * NEWS (Other MI changes): New subsection.
1469         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1470         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1471         * arch-utils.c (default_get_pc_address_flags): New function.
1472         * arch-utils.h (default_get_pc_address_flags): New declaration.
1473         * gdbarch.sh: Add get_pc_address_flags.
1474         * gdbarch.c: Regenerate.
1475         * gdbarch.h: Likewise.
1476         * stack.c (print_pc): New function.
1477         (print_frame_info) (print_frame): Call print_pc.
1478
1479 2019-08-16  Tom de Vries  <tdevries@suse.de>
1480
1481         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1482         print_objfile_section_info.
1483
1484 2019-08-15  Tom Tromey  <tom@tromey.com>
1485
1486         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1487         calling update_cmdwin_start_line.
1488         * tui/tui-winsource.h (struct tui_source_window_base)
1489         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1490         <rerender>: Declare.
1491         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1492         Call rerender.
1493         (tui_source_window_base::set_new_height): Remove.
1494         (tui_source_window_base::rerender): Rename from
1495         do_make_visible_with_new_height.
1496         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1497         resize method.
1498         (tui_win_info::make_invisible_and_set_new_height)
1499         (tui_win_info::make_visible_with_new_height): Remove.
1500         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1501         Declare.
1502         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1503         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1504         do_make_visible_with_new_height>: Don't declare.
1505         <rerender>: Declare.
1506         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1507         set_new_height.
1508         (tui_data_window::do_make_visible_with_new_height): Remove.
1509         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1510         call tui_show_locator_content.
1511         (tui_gen_win_info::resize): Call rerender.
1512         (show_source_or_disasm_and_command): Don't call
1513         tui_show_locator_content.
1514         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1515         method.
1516         (struct tui_win_info) <rerender>: Declare.
1517         <set_new_height, make_invisible_and_set_new_height,
1518         make_visible_with_new_height>: Don't declare.
1519         * tui/tui-data.c (tui_win_list::rerender): New method.
1520         * tui/tui-command.h (struct tui_cmd_window)
1521         <do_make_visible_with_new_height>: Don't declare.
1522         * tui/tui-command.c
1523         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1524
1525 2019-08-15  Tom Tromey  <tromey@adacore.com>
1526
1527         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1528         * ada-lang.c (ada_enum_name): Likewise.
1529
1530 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1531
1532         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1533         leading underscore.
1534         (GdbOutputErrorFile): Likewise.
1535         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1536         accordingly.
1537         (execute_unwinders): Rename to have a leading underscore.
1538         (auto_load_packages): Likewise.
1539         (global scope): Adjust call to auto_load_packages accordingly.
1540         (GdbSetPythonDirectory): Likewise.
1541         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1542         instead of execute_unwinders.
1543
1544 2019-08-15  Tom Tromey  <tom@tromey.com>
1545
1546         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1547         (show_data): Don't change window visibility.
1548         (tui_gen_win_info::resize): Remove special case for command
1549         window.  Use wresize, when available.
1550         (show_source_or_disasm_and_command): Don't change window
1551         visibility.
1552         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1553         <make_visible>: New method.
1554         * tui/tui-command.c (tui_cmd_window::resize): New method.
1555
1556 2019-08-15  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1559         (struct tui_source_windows): New.
1560         * tui/tui-winsource.c (tui_display_main): Update.
1561         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1562         (new_height_ok, parse_scrolling_args): Update.
1563         * tui/tui-layout.c (show_layout, show_data): Update.
1564         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1565         (tui_add_to_source_windows): Don't declare.
1566         * tui/tui-data.c (source_windows, tui_source_windows)
1567         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1568
1569 2019-08-15  Tom Tromey  <tom@tromey.com>
1570
1571         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1572         Rename from reset.
1573         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1574         * tui/tui-layout.c (show_source_disasm_command, show_data):
1575         Update.
1576         (tui_gen_win_info::resize): Rename.
1577         (show_source_or_disasm_and_command): Update.
1578         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1579         reset.
1580
1581 2019-08-15  Tom Tromey  <tom@tromey.com>
1582
1583         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1584         * tui/tui-interp.c (tui_interp::init): Don't call
1585         tui_initialize_static_data.
1586         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1587
1588 2019-08-15  Tom Tromey  <tom@tromey.com>
1589
1590         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1591         examine tui_win_list.
1592
1593 2019-08-15  Tom Tromey  <tom@tromey.com>
1594
1595         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1596         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1597         tui_clear_source_content.
1598         (tui_clear_source_content): Remove.
1599         (tui_source_window_base::do_erase_source_content): Hoist call to
1600         content.clear().
1601         * tui/tui-stack.c (tui_show_frame_info): Don't call
1602         tui_clear_source_content.
1603
1604 2019-08-15  Tom Tromey  <tom@tromey.com>
1605
1606         * tui/tui-winsource.h (struct tui_source_window_base)
1607         <do_erase_source_content>: New method.
1608         <erase_source_content>: New method.
1609         (tui_erase_source_content): Don't declare.
1610         * tui/tui-winsource.c (tui_clear_source_content): Update.
1611         (tui_source_window_base::do_erase_source_content): Rename from
1612         tui_erase_source_content.
1613         (tui_source_window_base::show_source_content): Update.
1614         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1615         * tui/tui-source.h (struct tui_source_window)
1616         <erase_source_content>: New method.
1617         * tui/tui-disasm.h (struct tui_disasm_window)
1618         <erase_source_content>: New method.
1619
1620 2019-08-15  Tom Tromey  <tom@tromey.com>
1621
1622         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
1623         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
1624         constructor.
1625         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
1626         * tui/tui-source.c (tui_set_source_content): Update.
1627         * tui/tui-disasm.c (tui_set_disassem_content): Update.
1628
1629 2019-08-15  Tom Tromey  <tom@tromey.com>
1630
1631         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
1632         * tui/tui-winsource.c (tui_line_is_displayed): Move to
1633         tui-source.c.
1634         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
1635         Declare.
1636         * tui/tui-source.c (tui_source_window::line_is_displayed): New
1637         method.
1638         (tui_source_window::maybe_update): Update.
1639
1640 2019-08-15  Tom Tromey  <tom@tromey.com>
1641
1642         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
1643         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
1644         tui-disasm.c.
1645         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
1646         Declare.
1647         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
1648         method.
1649         (tui_disasm_window::maybe_update): Update.
1650
1651 2019-08-15  Tom Tromey  <tom@tromey.com>
1652
1653         * tui/tui-winsource.h (struct tui_source_window_base)
1654         <maybe_update>: Declare.
1655         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
1656         method.
1657         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
1658         Declare.
1659         * tui/tui-source.c (tui_source_window::maybe_update): New method.
1660         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
1661         Declare.
1662         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
1663
1664 2019-08-15  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
1667
1668 2019-08-15  Tom Tromey  <tom@tromey.com>
1669
1670         * tui/tui-wingeneral.c: Include tui-stack.h.
1671         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
1672         (struct tui_locator_window): Move from tui-data.h.
1673         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
1674         (tui_initialize_static_data): Move from tui-data.c.
1675         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
1676         (struct tui_locator_window): Move to tui-stack.c.
1677         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
1678         (tui_initialize_static_data): Move to tui-stack.c.
1679
1680 2019-08-15  Tom Tromey  <tom@tromey.com>
1681
1682         * tui/tui-layout.c (show_source_disasm_command)
1683         (show_source_or_disasm_and_command): Use make_visible method, not
1684         tui_make_window.
1685         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
1686         Remove.
1687
1688 2019-08-15  Tom Tromey  <tom@tromey.com>
1689
1690         * tui/tui-wingeneral.h (tui_make_window): Update.
1691         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
1692         parameter.
1693         (tui_gen_win_info::make_visible): Update.
1694         * tui/tui-regs.c (tui_data_window::display_registers_from):
1695         Update.
1696         * tui/tui-layout.c (show_source_disasm_command)
1697         (show_source_or_disasm_and_command): Update.
1698         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
1699         (enum tui_box): Remove.
1700         (struct tui_win_info) <can_box>: New method.
1701         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
1702         method.
1703
1704 2019-08-15  Tom de Vries  <tdevries@suse.de>
1705
1706         * linux-nat-trad.c: Include gdbarch.h.
1707
1708 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
1709
1710         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
1711         register sizes.
1712
1713 2019-08-14  Tom Tromey  <tromey@adacore.com>
1714
1715         * darwin-nat.c: Include gdbarch.h.
1716         * darwin-nat-info.c: Include gdbarch.h.
1717
1718 2019-08-13  Tom Tromey  <tom@tromey.com>
1719
1720         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
1721         Remove.
1722         * tui/tui-data.c (tui_initialize_static_data): Update.
1723
1724 2019-08-13  Tom Tromey  <tom@tromey.com>
1725
1726         * tui/tui-winsource.h (struct tui_exec_info_window)
1727         <~tui_exec_info_window, maybe_allocate_content, get_content,
1728         m_content>: Remove.
1729         (struct tui_source_window_base) <set_exec_info_content,
1730         show_exec_info_content>: Don't declare.
1731         * tui/tui-winsource.c
1732         (tui_exec_info_window::maybe_allocate_content): Remove.
1733         (tui_source_window_base::update_exec_info): Rename from
1734         set_exec_info_content.
1735         (tui_source_window_base::show_exec_info_content)
1736         (tui_source_window_base::update_exec_info): Remove.
1737
1738 2019-08-13  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
1741         declare.
1742         * tui/tui-winsource.c (tui_update_source_window_as_is)
1743         (tui_update_source_windows_with_addr, tui_erase_source_content):
1744         Update.
1745         (tui_clear_exec_info_content): Remove.
1746
1747 2019-08-13  Tom Tromey  <tom@tromey.com>
1748
1749         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
1750         declare.
1751         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
1752         call tui_erase_exec_info_content.
1753         (tui_clear_exec_info_content): Rename from
1754         tui_erase_exec_info_content.
1755         (tui_clear_exec_info_content): Delete.
1756
1757 2019-08-13  Tom Tromey  <tom@tromey.com>
1758
1759         * tui/tui-winsource.h (struct tui_source_window_base)
1760         <show_exec_info_content>: Declare.
1761         (tui_show_exec_info_content): Don't declare.
1762         * tui/tui-winsource.c
1763         (tui_source_window_base::show_exec_info_content): Rename from
1764         tui_show_exec_info_content.
1765         (tui_source_window_base::update_exec_info): Update.
1766
1767 2019-08-13  Tom Tromey  <tom@tromey.com>
1768
1769         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
1770         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
1771         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
1772         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
1773         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
1774         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
1775         ... here.
1776
1777 2019-08-13  Tom Tromey  <tom@tromey.com>
1778
1779         * tui/tui-winsource.h (struct tui_source_window_base)
1780         <update_exec_info>: Declare.
1781         (tui_update_exec_info): Don't declare.
1782         * tui/tui-winsource.c (tui_update_source_window_as_is)
1783         (tui_source_window_base::refresh_all)
1784         (tui_update_all_breakpoint_info): Update.
1785         (tui_source_window_base::update_exec_info): Rename from
1786         tui_update_exec_info.
1787         * tui/tui-stack.c (tui_show_frame_info): Update.
1788
1789 2019-08-13  Tom Tromey  <tom@tromey.com>
1790
1791         * tui/tui-winsource.h (struct tui_source_window_base)
1792         <set_exec_info_content>: Declare.
1793         (tui_set_exec_info_content): Don't declare.
1794         * tui/tui-winsource.c
1795         (tui_source_window_base::set_exec_info_content): Rename from
1796         tui_set_exec_info_content.
1797         (tui_update_exec_info): Update.
1798
1799 2019-08-13  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.h (struct tui_source_window_base)
1802         <show_source_content>: Declare.
1803         (tui_show_source_content): Don't declare.
1804         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
1805         (tui_source_window_base::show_source_content): Rename from
1806         tui_show_source_content.
1807         (tui_source_window_base::refresh_all): Update.
1808         * tui/tui-layout.c (show_source_disasm_command)
1809         (show_source_or_disasm_and_command): Update.
1810
1811 2019-08-13  Tom Tromey  <tom@tromey.com>
1812
1813         * tui/tui-winsource.c (tui_erase_source_content)
1814         (tui_show_source_content, tui_source_window_base::refresh_all):
1815         Update.
1816         * tui/tui-wingeneral.h
1817         (tui_check_and_display_highlight_if_needed): Don't declare.
1818         * tui/tui-wingeneral.c
1819         (tui_win_info::check_and_display_highlight_if_needed): Rename from
1820         check_and_display_highlight_if_needed.
1821         * tui/tui-win.c (tui_rehighlight_all)
1822         (tui_win_info::make_visible_with_new_height): Update.
1823         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1824         (tui_data_window::erase_data_content)
1825         (tui_data_window::display_all_data): Update.
1826         * tui/tui-data.h (struct tui_win_info)
1827         <check_and_display_highlight_if_needed>: Declare.
1828
1829 2019-08-13  Tom Tromey  <tom@tromey.com>
1830
1831         * tui/tui-win.c (tui_resize_all): Call
1832         tui_delete_invisible_windows.
1833         * tui/tui-layout.c (show_layout): Call
1834         tui_delete_invisible_windows.
1835         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
1836         * tui/tui-data.c (tui_delete_invisible_windows): New function.
1837
1838 2019-08-13  Tom Tromey  <tom@tromey.com>
1839
1840         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
1841         tui_add_win_to_layout.
1842
1843 2019-08-13  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui-layout.h (tui_default_win_height): Don't declare.
1846         * tui/tui-layout.c (tui_default_win_height): Now static.
1847
1848 2019-08-13  Tom Tromey  <tom@tromey.com>
1849
1850         * tui/tui-layout.c (show_layout): Unify all layout cases into a
1851         single switch.
1852         (show_source_disasm_command, show_source_or_disasm_and_command):
1853         Don't check current layout.
1854
1855 2019-08-13  Tom Tromey  <tom@tromey.com>
1856
1857         * tui/tui-wingeneral.c (make_all_visible): Remove.
1858         (tui_make_all_invisible): Simplify.
1859         * tui/tui-layout.c (tui_make_all_invisible): Move from
1860         tui-wingeneral.c; simplify.
1861         (show_layout): Hoist call to tui_make_all_invisible.
1862         (show_data): Don't call tui_make_all_invisible.
1863
1864 2019-08-13  Tom Tromey  <tom@tromey.com>
1865
1866         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
1867         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
1868
1869 2019-08-13  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
1872         tui-data.c.
1873         (show_source_disasm_command, show_data)
1874         (show_source_or_disasm_and_command): Don't use
1875         tui_set_current_layout_to.
1876         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
1877         * tui/tui-data.c (current_layout, tui_current_layout): Move to
1878         tui-layout.c.
1879         (tui_set_current_layout_to): Remove.
1880
1881 2019-08-13  Tom Tromey  <tom@tromey.com>
1882
1883         * tui/tui-layout.c (tui_set_layout): Update.
1884         * tui/tui-data.h (struct tui_layout_def): Remove.
1885         (tui_layout_def): Don't declare.
1886         * tui/tui-data.c (layout_def): Remove.
1887         (tui_layout_def): Remove.
1888
1889 2019-08-13  Tom Tromey  <tom@tromey.com>
1890
1891         * tui/tui-winsource.h (struct tui_source_window_base)
1892         <clear_detail>: No longer "override".
1893         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
1894         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
1895         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
1896         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
1897         Remove.
1898         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
1899
1900 2019-08-13  Tom Tromey  <tromey@adacore.com>
1901
1902         * tracepoint.c: Don't include readline.h or history.h.
1903
1904 2019-08-12  Tom Tromey  <tom@tromey.com>
1905
1906         * configure: Rebuild.
1907         * configure.ac: Check for readline 7.
1908         * NEWS: Mention readline 7 requirement.
1909         * README: Update.
1910
1911 2019-08-12  Tom Tromey  <tom@tromey.com>
1912
1913         * mingw-hdep.c (gdb_select): Remove readline hack.
1914
1915 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1916
1917         * blockframe.c (find_pc_partial_function): Set *block to nullptr
1918         when the function fails.
1919
1920 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
1921
1922         * s390-tdep.c (s390_type_align): New function.
1923         (s390_gdbarch_init): Set it as type_align gdbarch method.
1924
1925 2019-08-09  Tom de Vries  <tdevries@suse.de>
1926
1927         PR gdb/24591
1928         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
1929         pc_low with relocation offset.
1930
1931 2019-08-07  Tom Tromey  <tromey@adacore.com>
1932
1933         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
1934         (print_frame_args): Update.
1935         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
1936         Update.
1937         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1938         * frame.h (struct frame_arg): Add initializers.
1939         <error>: Now a unique_xmalloc_ptr.
1940
1941 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
1942
1943         * NEWS: Expand the Pointer Authentication entry.
1944         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
1945         (aarch64_frame_unmask_lr): ... to this.
1946         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
1947         Call aarch64_frame_unmask_lr.
1948         * frame.c (struct frame_info): Add "masked" variable.
1949         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
1950         (fprint_frame): Check for masked pc.
1951         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
1952         declarations.
1953         * python/py-framefilter.c (py_print_frame): Check for masked pc.
1954         * stack.c (print_frame): Check for masked pc.
1955
1956 2019-08-06  Tom Tromey  <tom@tromey.com>
1957
1958         * stabsread.c (patch_block_stabs, read_one_struct_field)
1959         (read_enum_type): Use obstack_strndup.
1960         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
1961         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
1962         * dwarf2read.c (guess_full_die_structure_name)
1963         (anonymous_struct_prefix): Use obstack_strndup.
1964         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
1965         * c-exp.y (yylex): Use obstack_strndup.
1966         * ada-exp.y (write_object_renaming, write_ambiguous_var)
1967         (write_var_or_type): Use obstack_strndup.
1968
1969 2019-08-06  Tom Tromey  <tom@tromey.com>
1970
1971         * symfile.c (reread_symbols): Use obstack_strdup.
1972         * stabsread.c (read_type): Use obstack_strdup.
1973         * gdb_obstack.h (obstack_strdup): New overload.
1974         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
1975         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
1976         (dwarf2_canonicalize_name): Use obstack_strdup.
1977         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
1978         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
1979         Use obstack_strdup.
1980
1981 2019-08-06  Tom Tromey  <tom@tromey.com>
1982
1983         * gdb_obstack.h (obstack_strdup): Define.
1984         * gdb_obstack.c (obstack_strdup): Don't define.
1985
1986 2019-08-06  Tom Tromey  <tom@tromey.com>
1987
1988         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
1989         obstack_strdup.
1990         * typeprint.c (typedef_hash_table::find_global_typedef): Use
1991         obstack_strdup.
1992         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
1993         * stabsread.c (common_block_start): Use obstack_strdup.
1994         * objfiles.c (set_objfile_main_name, objfile): Use
1995         obstack_strdup.
1996         * namespace.c (add_using_directive): Use obstack_strdup.
1997         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
1998         * jit.c (finalize_symtab): Use obstack_strdup.
1999         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2000         (guess_partial_die_structure_name, partial_die_info::fixup)
2001         (dwarf2_name): Use obstack_strdup.
2002         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2003         obstack_strdup.
2004         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2005         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2006         obstack_strdup.
2007         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2008
2009 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2010
2011         * unittests/help-doc-selftests.c: New file.
2012         * Makefile.in: Add the new file.
2013
2014 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2015
2016         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2017         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2018         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2019         the trailing '.' is not output, and the first character is uppercased.
2020         (print_help_for_command): Update call to print_doc_line.
2021         (print_doc_of_command): Likewise.
2022         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2023         * cli/cli-option.c (append_indented_doc): Do not append newline.
2024         (build_help_option): Append newline after first appended_indented_doc
2025         only if a second call is done.
2026         (build_help): Append 2 new lines before each option, except the first
2027         one.
2028         * compile/compile.c (_initialize_compile): Add new lines after
2029         %OPTIONS%, when not at the end of the help.
2030         Change help doc or code
2031         producing the help doc to respect the invariants.
2032         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2033         Also removed the new line after 'Options:', as all other commands
2034         do not put an empty line between 'Options:' and the first option.
2035         * printcmd.c (_initialize_printcmd): Likewise.
2036         * stack.c (_initialize_stack): Likewise.
2037         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2038         incorrectly telling COMMAND is optional.
2039         * ada-lang.c (_initialize_ada_language): Change help doc or code
2040         producing the help doc to respect the invariants.
2041         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2042         * breakpoint.c (_initialize_breakpoint): Likewise.
2043         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2044         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2045         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2046         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2047         _initialize_cli_style): Likewise.
2048         * corelow.c (core_target_info): Likewise.
2049         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2050         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2051         * filesystem.c (_initialize_filesystem): Likewise.
2052         * frame.c (_initialize_frame): Likewise.
2053         * gnu-nat.c (add_task_commands): Likewise.
2054         * infcall.c (_initialize_infcall): Likewise.
2055         * infcmd.c (_initialize_infcmd): Likewise.
2056         * interps.c (_initialize_interpreter): Likewise.
2057         * language.c (_initialize_language): Likewise.
2058         * linux-fork.c (_initialize_linux_fork): Likewise.
2059         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2060         * maint.c (_initialize_maint_cmds): Likewise.
2061         * memattr.c (_initialize_mem): Likewise.
2062         * printcmd.c (_initialize_printcmd): Likewise.
2063         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2064         _RegEx): Likewise.
2065         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2066         * record-btrace.c (_initialize_record_btrace): Likewise.
2067         * record-full.c (_initialize_record_full): Likewise.
2068         * record.c (_initialize_record): Likewise.
2069         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2070         * regcache.c (_initialize_regcache): Likewise.
2071         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2072         _initialize_remote): Likewise.
2073         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2074         * serial.c (_initialize_serial): Likewise.
2075         * skip.c (_initialize_step_skip): Likewise.
2076         * source.c (_initialize_source): Likewise.
2077         * stack.c (_initialize_stack): Likewise.
2078         * symfile.c (_initialize_symfile): Likewise.
2079         * symtab.c (_initialize_symtab): Likewise.
2080         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2081         * top.c (init_main): Likewise.
2082         * tracefile-tfile.c (tfile_target_info): Likewise.
2083         * tracepoint.c (_initialize_tracepoint): Likewise.
2084         * tui/tui-win.c (_initialize_tui_win): Likewise.
2085         * utils.c (add_internal_problem_command): Likewise.
2086         * valprint.c (value_print_option_defs): Likewise.
2087
2088 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2089
2090         PR build/24886
2091         * configure.ac: Drop enable-libmcheck support.
2092         * configure, config.in: Rebuild.
2093         * libmcheck.m4: Remove.
2094         * acinclude.m4: Don't include it.
2095         * Makefile.in: Don't distribute it.
2096         * top.c (print_gdb_configuration): Don't mention it.
2097
2098 2019-08-06  Tom Tromey  <tom@tromey.com>
2099
2100         * utils.c (set_output_style): Sometimes pass stream to
2101         emit_style_escape.
2102         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2103         * record-btrace.c (btrace_insn_history): Update.
2104         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2105         method.
2106         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2107         Update initializers.
2108         <m_uiout>: New field.
2109         <m_di>: Move lower.
2110         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2111         Remove "uiout" parameter.
2112         (dump_insns): Update.
2113         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2114         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2115
2116 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2117
2118         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2119         (error_in_psymtab_expansion): Likewise.
2120         (lookup_symbol_via_quick_fns): Likewise.
2121         (basic_lookup_transparent_type_quick): Likewise.
2122         (basic_lookup_transparent_type_1): Likewise.
2123
2124 2019-08-06  Tom Tromey  <tromey@adacore.com>
2125
2126         * source.c (last_source_error): Now bool.
2127         (print_source_lines_base): Make "noprint" bool.  Only open
2128         source file when last_source_visited changes.
2129
2130 2019-08-06  Tom Tromey  <tromey@adacore.com>
2131
2132         * annotate.c (annotate_source_line): Use g_source_cache.
2133         * source-cache.c (source_cache::get_plain_source_lines): Change
2134         parameters.  Populate m_offset_cache.
2135         (source_cache::ensure): New method.
2136         (source_cache::get_line_charpos): New method.
2137         (extract_lines): Move lower.  Change parameters.
2138         (source_cache::get_source_lines): Move lower.
2139         * source-cache.h (class source_cache): Update comment.
2140         <get_line_charpos>: New method.
2141         <get_source_lines>: Update comment.
2142         <clear>: Clear m_offset_cache.
2143         <get_plain_source_lines>: Change parameters.
2144         <ensure>: New method
2145         <m_offset_cache>: New member.
2146         * source.c (forget_cached_source_info_for_objfile): Update.
2147         (info_source_command): Use g_source_cache.
2148         (find_source_lines, open_source_file_with_line_charpos): Remove.
2149         (print_source_lines_base, search_command_helper): Use g_source_cache.
2150         * source.h (open_source_file_with_line_charpos): Don't declare.
2151         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2152         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2153         Use g_source_cache.
2154
2155 2019-08-06  Tom Tromey  <tromey@adacore.com>
2156
2157         * source-cache.c (source_cache::get_plain_source_lines):
2158         Remove "first_line" and "last_line" parameters.
2159         (source_cache::get_source_lines): Cache plain text.
2160         * source-cache.h (class source_cache)
2161         <get_plain_source_lines>: Update.
2162
2163 2019-08-06  Tom Tromey  <tromey@adacore.com>
2164
2165         * source-cache.c (extract_lines): No longer a method.
2166         Changed type of parameter.  Include final newline.
2167         (selftests::extract_lines_test): New function.
2168         (_initialize_source_cache): Likewise.
2169         * source-cache.h (class source_cache)
2170         <extract_lines>: Don't declare.
2171
2172 2019-08-06  Tom Tromey  <tromey@adacore.com>
2173
2174         * breakpoint.c (init_breakpoint_sal): Update.
2175         (breakpoint): Update.
2176         * breakpoint.h (struct breakpoint) <filter>: Now a
2177         unique_xmalloc_ptr.
2178
2179 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2180
2181         * NEWS: Mention dictionary access on blocks.
2182         * python/py-block.c (blpy_getitem): New function.
2183         (block_object_as_mapping): New struct.
2184         (block_object_type): Use new struct for tp_as_mapping field.
2185
2186 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2187
2188         * objfiles.h (objfile): Add a comment describing partial symbols.
2189
2190 2019-08-05  Tom Tromey  <tromey@adacore.com>
2191
2192         * compile/compile.c (_initialize_compile): Use _(), not N_().
2193         * thread.c (_initialize_thread): Use _(), not N_().
2194         * stack.c (_initialize_stack): Use _(), not N_().
2195         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2196
2197 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2198
2199         * dwarf2read.c (struct dw2_symtab_iterator):
2200         <want_specific_block>: Remove.
2201         <block_index>: Change type to gdb::optional.
2202         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2203         change type of BLOCK_INDEX parameter to gdb::optional.
2204         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2205         (dw2_lookup_symbol): Don't pass argument for
2206         WANT_SPECIFIC_BLOCK.
2207         (dw2_expand_symtabs_for_function): Don't pass argument for
2208         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2209         (class dw2_debug_names_iterator)
2210         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2211         parameter, change BLOCK_INDEX type to gdb::optional.
2212         <m_want_specific_block>: Remove.
2213         <m_block_index>: Change type to gdb::optional.
2214         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2215         gdb::optional.  Re-write in function of gdb::optional.
2216         (dw2_debug_names_lookup_symbol): Don't pass argument for
2217         WANT_SPECIFIC_BLOCK.
2218         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2219         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2220         BLOCK_INDEX.
2221
2222 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2223
2224         * NEWS: Mention changes to "info sources" command.
2225
2226 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2227
2228         * symtab.c (filename_partial_match_opts): New struct type.
2229         (struct output_source_filename_data): New members
2230         regexp, c_regexp, partial_match.
2231         (output_source_filename): Use new members to decide to print file.
2232         (info_sources_option_defs): New variable.
2233         (make_info_sources_options_def_group, print_info_sources_header,
2234         info_sources_command_completer):
2235         New functions.
2236         (info_sources_command): Read new optional arguments.
2237         (_initialize_symtab): Update info sources help.
2238
2239 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2240
2241         * ada-lang.c (exception_support_info_v0): Renamed from...
2242         (default_exception_support_info): ... this.  Create new
2243         definition for v1.
2244         (ada_has_this_exception_support): Look up catch_handlers_sym.
2245         (ada_exception_support_info_sniffer): Try v0 after default.
2246
2247 2019-08-01  Tom Tromey  <tromey@adacore.com>
2248
2249         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2250         gdbarch.h.
2251
2252 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2253
2254         * s12z-tdep.c: Fix include path for s12z-opc.h.
2255
2256 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2257
2258         * NEWS: Require GNU make 3.82.
2259
2260 2019-07-16  Tom Tromey  <tom@tromey.com>
2261
2262         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2263         declare.
2264
2265 2019-07-30  Tom Tromey  <tromey@adacore.com>
2266
2267         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2268
2269 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2270
2271         * printcmd.c (print_address_symbolic): Print negative offsets.
2272         (build_address_symbolic): Force signed arithmetic when computing
2273         offset.
2274
2275 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2276
2277         PR/24474: Add a function to lookup static variables.
2278         * NEWS: Mention this new function.
2279         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2280         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2281         * python/python.c (python_GdbMethods): Add new function.
2282
2283 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2284
2285         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2286         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2287         (objfpy_lookup_static_symbol): New function.
2288         (objfile_object_methods): Add new functions.
2289
2290 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2291
2292         * NEWS: Mention 'set|show print frame-info'.  Mention new
2293         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2294         backtrace argument.  Mention that python frame filtering code
2295         is now consistent with what 'backtrace' command prints.
2296
2297 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2298
2299         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2300         comments.
2301         (print_frame_info_auto, print_frame_info_source_line,
2302         print_frame_info_location, print_frame_info_source_and_location,
2303         print_frame_info_location_and_address, print_frame_info_short_location):
2304         New declarations.
2305         (struct frame_print_options): New member print_frame_info.
2306         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2307         * stack.h (get_user_print_what_frame_info): New declaration.
2308         (frame_show_address): New declaration.
2309         * stack.c (print_frame_arguments_choices): New value 'presence'.
2310         (print_frame_info_auto, print_frame_info_source_line,
2311         print_frame_info_location, print_frame_info_source_and_location,
2312         print_frame_info_location_and_address, print_frame_info_short_location,
2313         print_frame_info_choices, print_frame_info_print_what): New definitions.
2314         (print_frame_args): Only print dots for args if print frame-arguments
2315         is 'presence'.
2316         (frame_print_option_defs): New element for "frame-info".
2317         (get_user_print_what_frame_info): New function.
2318         (frame_show_address): Make non static.  Move comment to stack.h.
2319         (print_frame_info_to_print_what): New function.
2320         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2321         to decide what to print.
2322         (backtrace_command_1): Handle the new print_frame_arguments_presence
2323         value.
2324         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2325         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2326         (py_print_frame): In non-mi mode, use LOCATION as default for
2327         print_what, similarly to frame information printed directly by
2328         backtrace command. Handle frame-info user option in non MI mode.
2329
2330 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2331
2332         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2333         Add case for debugging 32-bit target on 64-bit host.  Revise
2334         comment.
2335
2336 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2337
2338         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2339         instead of find_function_entry_range_from_pc.
2340
2341 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2342
2343         * stack.c (find_frame_funname): Remove code which preferred
2344         minsym over symtab sym in "certain pathological cases".
2345
2346         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2347         parameter.  Change type of "do_demangle" to bool.
2348         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2349         Pass suitable "prefer_sym_over_minsym" flag to
2350         build_address_symbolic().  Don't output "+" for negative offsets.
2351         * printcmd.c (print_address_symbolic): Update invocation of
2352         build_address_symbolic to include a "prefer_sym_over_minsym"
2353         flag.
2354         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2355         Restrict cases in which use of minimal symbol is preferred to that
2356         of a found symbol.  Update comments.
2357
2358         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2359         for entry pc when entry pc is out of range for that FDE.
2360
2361 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2362
2363         PR gdb/24839:
2364         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2365         type.
2366
2367 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2368
2369         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2370         this function's Python signature.
2371
2372
2373 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2374
2375         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2376         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2377         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2378         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2379         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2380
2381
2382 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2383
2384         * h8300-tdep.c (h8300_register_name_common): New.
2385         h8300_register_name): Use h8300_register_name_common.
2386         (h8300s_register_name): Likewise.
2387         (h8300sx_register_name): Likewise.
2388         (h8300h_register_nam): New.
2389         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2390
2391
2392 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2393
2394         * arm-tdep.c (arm_skip_cmse_entry): New function.
2395         (arm_is_sgstubs_section): New function.
2396         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2397
2398 2019-07-22  Tom Tromey  <tom@tromey.com>
2399
2400         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2401         Don't self-assign.
2402
2403 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2404
2405         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2406         type_print.
2407
2408 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2409
2410         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2411         so that GDB doesn't match any msymbols when searching in the
2412         TYPES_DOMAIN.
2413         (print_symbol_info): Print using typedef_print or type_print based
2414         on the type of the symbol.  Add updated FIXME comment moved from...
2415         (_initialize_symtab): ... move and update FIXME comment to above.
2416
2417 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2418
2419         * NEWS: Mention adding -q option to "info types".
2420         * symtab.c (struct info_types_options): New struct.
2421         (info_types_options_defs): New variable.
2422         (make_info_types_options_def_group): New function.
2423         (info_types_command): Use gdb::option framework to parse options.
2424         (info_types_command_completer): New function.
2425         (_initialize_symtab): Extend the help text on "info types" and
2426         register command completer.
2427
2428 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2429
2430         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2431         (lookup_symbol_in_objfile): Change int to block_enum and add a
2432         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2433
2434 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2435
2436         * MAINTAINERS (Write After Approval): Add self.
2437
2438 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2439
2440         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2441         instruction to the dummy code region.
2442
2443 2019-07-19  Tom Tromey  <tromey@adacore.com>
2444
2445         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2446         (ARGSUSED, PARAMS, __func__): Remove rules.
2447
2448 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2449
2450         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2451         * features/arm/arm-with-iwmmxt.c: Remove.
2452         * features/arm/arm-with-iwmmxt.xml: Remove.
2453         * features/arm/arm-with-m-fpa-layout.c: Remove.
2454         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2455         * features/arm/arm-with-m-vfp-d16.c: Remove.
2456         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2457         * features/arm/arm-with-m.c: Remove.
2458         * features/arm/arm-with-m.xml: Remove.
2459         * features/arm/arm-with-neon.c: Remove.
2460         * features/arm/arm-with-neon.xml: Remove.
2461         * features/arm/arm-with-vfpv2.c: Remove.
2462         * features/arm/arm-with-vfpv2.xml: Remove.
2463         * features/arm/arm-with-vfpv3.c: Remove.
2464         * features/arm/arm-with-vfpv3.xml: Remove.
2465
2466 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2467
2468         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2469
2470 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2471
2472         * arch/aarch32.c (aarch32_create_target_description): Create
2473         target descriptions using features.
2474         * arch/arm.c (arm_create_target_description)
2475         (arm_create_mprofile_target_description): Likewise.
2476         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2477
2478 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2479
2480         * Makefile.in: Add new files.
2481         * aarch32-tdep.c: New file.
2482         * aarch32-tdep.h: New file.
2483         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2484         Call aarch32_read_description.
2485         * arch/aarch32.c: New file.
2486         * arch/aarch32.h: New file.
2487         * arch/arm.c (arm_create_target_description)
2488         (arm_create_mprofile_target_description): New function.
2489         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2490         (arm_create_target_description)
2491         (arm_create_mprofile_target_description): New declaration.
2492         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2493         read_description functions.
2494         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2495         Likewise.
2496         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2497         * arm-tdep.c (tdesc_arm_list): New variable.
2498         (arm_register_g_packet_guesses): Call create description functions.
2499         (arm_read_description) (arm_read_mprofile_description): New
2500         function.
2501         * arm-tdep.h (arm_read_description)
2502         (arm_read_mprofile_description): Add declaration.
2503         * configure.tgt: Add new files.
2504
2505 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2506
2507         * top.c (new_ui_command): Open specified terminal just once.
2508
2509 2019-07-18  Tom Tromey  <tromey@adacore.com>
2510
2511         * symtab.c (main_name): Constify return type.
2512         * symfile.c (set_initial_language): Update.
2513         * symtab.h (main_name): Constify return type.
2514
2515 2019-07-17  Tom Tromey  <tom@tromey.com>
2516
2517         * tui/tui-winsource.c (tui_update_source_window)
2518         (tui_update_source_window_as_is)
2519         (tui_update_source_windows_with_line): Remove return.
2520         * tui/tui-disasm.c (tui_show_disassem)
2521         (tui_show_disassem_and_update_source): Remove return.
2522         * tui/tui.c (tui_reset): Remove return.
2523         * tui/tui-wingeneral.c
2524         (tui_check_and_display_highlight_if_needed): Remove return.
2525
2526 2019-07-17  Tom Tromey  <tom@tromey.com>
2527
2528         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2529
2530 2019-07-17  Tom Tromey  <tom@tromey.com>
2531
2532         * tui/tui-winsource.h (struct tui_exec_info_window)
2533         (struct tui_source_window_base): Move from tui-data.h.
2534         * tui/tui-winsource.c: Move many method definitions from
2535         elsewhere.  Remove "structuring" comments.
2536         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2537         (tui_source_window_base::refresh_window): Move to
2538         tui-winsource.c.
2539         * tui/tui-win.c (tui_source_window_base::refresh_all)
2540         (tui_source_window_base::update_tab_width)
2541         (tui_source_window_base::set_new_height)
2542         (tui_source_window_base::do_make_visible_with_new_height): Move to
2543         tui-winsource.c.
2544         * tui/tui-source.h: Update.
2545         * tui/tui-source.c (tui_source_window_base::reset): Move to
2546         tui-winsource.c.
2547         * tui/tui-disasm.h: Update.
2548         * tui/tui-data.h (struct tui_exec_info_window): Move to
2549         tui-winsource.h.
2550         (struct tui_source_window_base): Likewise.
2551         * tui/tui-data.c (tui_source_window_base::clear_detail)
2552         (tui_source_window_base, ~tui_source_window_base): Move to
2553         tui-winsource.c.
2554
2555 2019-07-17  Tom Tromey  <tom@tromey.com>
2556
2557         * tui/tui-win.c (tui_resize_all)
2558         (tui_source_window_base::update_tab_width)
2559         (tui_adjust_win_heights): Update.
2560         (tui_win_info::make_invisible_and_set_new_height): Rename from
2561         make_invisible_and_set_new_height.
2562         * tui/tui-data.h (struct tui_win_info)
2563         <make_invisible_and_set_new_height>: New method.
2564
2565 2019-07-17  Tom Tromey  <tom@tromey.com>
2566
2567         * tui/tui.c: Update.
2568         * tui/tui-source.h (struct tui_source_window): Move from
2569         tui-data.h.
2570         * tui/tui-layout.c: Update.
2571         * tui/tui-disasm.c: Update.
2572         * tui/tui-data.h (struct tui_source_window): Move to
2573         tui-source.h.
2574
2575 2019-07-17  Tom Tromey  <tom@tromey.com>
2576
2577         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2578         tui-data.h.
2579         * tui/tui-data.h (struct tui_disasm_window): Move to
2580         tui-disasm.h.
2581
2582 2019-07-17  Tom Tromey  <tom@tromey.com>
2583
2584         * tui/tui-regs.h (struct tui_data_item_window): Move from
2585         tui-data.h.
2586         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2587         * tui/tui-data.h (struct tui_data_item_window): Move to
2588         tui-regs.h.
2589         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2590
2591 2019-07-17  Tom Tromey  <tom@tromey.com>
2592
2593         * tui/tui.c: Update.
2594         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2595         (tui_cmd_window::max_height): Move to tui-command.c.
2596         * tui/tui-layout.c: Update.
2597         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2598         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2599         tui-command.c.
2600         * tui/tui-command.h (struct tui_cmd_window): Move from
2601         tui-data.h.
2602         * tui/tui-command.c: Remove "structuring" comments.
2603         (tui_cmd_window::clear_detail)
2604         (tui_cmd_window::do_make_visible_with_new_height)
2605         (tui_cmd_window::max_height): Move from elsewhere.
2606
2607 2019-07-17  Tom Tromey  <tom@tromey.com>
2608
2609         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2610         Now static.
2611         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2612         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2613
2614 2019-07-17  Tom Tromey  <tom@tromey.com>
2615
2616         * tui/tui.c: Update.
2617         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2618         tui-regs.c.
2619         * tui/tui-windata.h: Remove file.
2620         * tui/tui-windata.c: Remove file.
2621         * tui/tui-win.c (tui_data_window::set_new_height)
2622         (tui_data_window::do_make_visible_with_new_height): Move to
2623         tui-regs.c.
2624         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
2625         * tui/tui-regs.c: Remove "structuring" comments.
2626         (tui_data_window::first_data_item_displayed)
2627         (tui_data_window::delete_data_content_windows)
2628         (tui_data_window::erase_data_content)
2629         (tui_data_window::display_all_data)
2630         (tui_data_window::refresh_all)
2631         (tui_data_window::do_scroll_vertical)
2632         (tui_data_window::clear_detail, tui_data_window::set_new_height)
2633         (tui_data_window::do_make_visible_with_new_height)
2634         (tui_data_window::refresh_window): Move from elsewhere.
2635         (_initialize_tui_regs): Move to end of file.
2636         * tui/tui-layout.c: Update.
2637         * tui/tui-hooks.c: Update.
2638         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
2639         * tui/tui-data.c (tui_data_window::clear_detail): Move to
2640         tui-regs.c.
2641         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
2642
2643 2019-07-17  Tom Tromey  <tom@tromey.com>
2644
2645         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
2646         seen.
2647
2648 2019-07-17  Tom Tromey  <tom@tromey.com>
2649
2650         * tui/tui-win.c (tui_source_window_base::set_new_height)
2651         (tui_source_window_base::do_make_visible_with_new_height): Use
2652         m_has_locator field directly.
2653         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
2654         method.
2655         (struct tui_source_window_base) <has_locator>: Likewise.
2656
2657 2019-07-17  Tom Tromey  <tom@tromey.com>
2658
2659         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
2660         Don't declare.
2661         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
2662         Remove.
2663         * tui/tui-win.c (tui_source_window_base::set_new_height)
2664         (tui_source_window_base::set_new_height)
2665         (make_invisible_and_set_new_height)
2666         (tui_source_window_base::do_make_visible_with_new_height)
2667         (tui_source_window_base::do_make_visible_with_new_height):
2668         Update.
2669         * tui/tui-layout.c (show_source_disasm_command, show_data)
2670         (show_source_or_disasm_and_command): Update.
2671         * tui/tui-layout.c (show_layout): Update.
2672
2673 2019-07-17  Tom Tromey  <tom@tromey.com>
2674
2675         * tui/tui-layout.c (make_data_window): Remove.
2676         (show_data): Unify creation and re-initialization cases.
2677
2678 2019-07-17  Tom Tromey  <tom@tromey.com>
2679
2680         * tui/tui-layout.c (make_source_window, make_disasm_window):
2681         Remove.
2682         (show_data): Unify creation and re-initialization cases.
2683
2684 2019-07-17  Tom Tromey  <tom@tromey.com>
2685
2686         * tui/tui-layout.c (make_command_window): Remove.
2687         (show_source_disasm_command, show_source_or_disasm_and_command):
2688         Unify creation and re-initialization cases.
2689
2690 2019-07-17  Tom Tromey  <tom@tromey.com>
2691
2692         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
2693         creation and re-initialization cases.
2694
2695 2019-07-17  Tom Tromey  <tom@tromey.com>
2696
2697         * tui/tui-regs.c (tui_get_register): Return void.
2698
2699 2019-07-17  Tom Tromey  <tom@tromey.com>
2700
2701         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
2702         Simplify.
2703
2704 2019-07-17  Tom Tromey  <tom@tromey.com>
2705
2706         * tui/tui-layout.c (show_source_disasm_command): Simplify window
2707         resetting.
2708
2709 2019-07-17  Tom Tromey  <tom@tromey.com>
2710
2711         * tui/tui.h (tui_set_layout_by_name): Don't declare.
2712         * tui/tui-regs.c (tui_reg_layout): New function.
2713         (tui_show_registers, tui_reg_command): Use it.
2714         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
2715         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
2716         parameters.
2717         (tui_layout_command): Remove.
2718
2719 2019-07-17  Tom Tromey  <tom@tromey.com>
2720
2721         * tui/tui-layout.h (tui/tui-layout): Return void.
2722         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
2723
2724 2019-07-17  Tom Tromey  <tom@tromey.com>
2725
2726         * tui/tui-layout.c (show_source_disasm_command, show_data):
2727         Update.
2728         (reset_locator): Remove.
2729         (show_source_or_disasm_and_command): Update.
2730
2731 2019-07-17  Tom Tromey  <tom@tromey.com>
2732
2733         * tui/tui-source.c (tui_source_window_base::reset): Remove
2734         win_type parameter.
2735         * tui/tui-layout.c (make_command_window, make_source_window)
2736         (make_disasm_window, make_data_window)
2737         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
2738         (reset_locator, show_source_or_disasm_and_command): Update.
2739         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
2740         win_type parameter.
2741         (struct tui_source_window_base) <reset>: Likewise.
2742
2743 2019-07-17  Tom Tromey  <tom@tromey.com>
2744
2745         * tui/tui-layout.c (show_source_disasm_command): Use
2746         reset_locator.
2747         (reset_locator): New function.
2748         (init_and_make_win): Remove.
2749         (show_source_or_disasm_and_command): Use reset_locator.
2750
2751 2019-07-17  Tom Tromey  <tom@tromey.com>
2752
2753         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
2754         condition.
2755         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
2756         Remove condition.
2757         * tui/tui-source.c (tui_source_window_base::reset): New method.
2758         * tui/tui-layout.c (make_command_window): Don't call
2759         init_and_make_win.
2760         (make_source_window, make_disasm_window): Don't call
2761         make_source_or_disasm_window.
2762         (make_data_window): Don't call init_and_make_win.  Change calling
2763         convention.
2764         (show_source_disasm_command, show_data): Simplify.
2765         (make_source_or_disasm_window): Remove.
2766         (show_source_or_disasm_and_command): Simplify.
2767         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
2768         (struct tui_source_window_base) <reset>: Likewise.
2769         <execution_info>: Remove initializer.
2770         * tui/tui-data.c (tui_source_window_base): Initialize
2771         execution_info.
2772
2773 2019-07-17  Tom Tromey  <tom@tromey.com>
2774
2775         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
2776         variable.
2777
2778 2019-07-17  Tom Tromey  <tom@tromey.com>
2779
2780         * tui/tui.c (tui_rl_other_window): Update.
2781         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
2782         superclass method first.  Always iterate over regs_content.
2783         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
2784         method.
2785         * tui/tui-win.c (tui_set_focus_command): Update.
2786
2787 2019-07-17  Tom Tromey  <tom@tromey.com>
2788
2789         * tui/tui-win.c (tui_set_focus_command): Rename from
2790         tui_set_focus.  Call tui_enable.
2791         (tui_set_focus_command): Remove.
2792
2793 2019-07-17  Tom Tromey  <tom@tromey.com>
2794
2795         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
2796         refresh_window.
2797         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
2798         touchwin.
2799         (tui_data_window::refresh_window): Call refresh_window on data
2800         items.  Always call superclass refresh_window.
2801         (tui_win_info::refresh): Remove.
2802         (tui_source_window_base::refresh_window): Update.
2803         (tui_refresh_all): Update.
2804         * tui/tui-layout.c (show_source_disasm_command): Remove call to
2805         refresh_window.
2806         (show_source_or_disasm_and_command): Likewise.
2807         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
2808         (struct tui_source_window_base) <refresh>: Likewise.
2809
2810 2019-07-17  Tom Tromey  <tom@tromey.com>
2811
2812         * tui/tui-winsource.c (tui_clear_source_content)
2813         (tui_show_source_content): Update.
2814         * tui/tui-source.c (tui_source_window::showing_source_p): Check
2815         whether content is empty.
2816         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
2817         Remove.
2818
2819 2019-07-17  Tom Tromey  <tom@tromey.com>
2820
2821         * tui/tui-winsource.c (tui_erase_source_content): Clear the
2822         window's contents.
2823         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
2824         * tui/tui-source.c (tui_set_source_content_nil): Remove.
2825
2826 2019-07-17  Tom Tromey  <tom@tromey.com>
2827
2828         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
2829         (struct tui_data_item_window): Update.
2830
2831 2019-07-17  Tom Tromey  <tom@tromey.com>
2832
2833         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
2834         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
2835         defines.
2836
2837 2019-07-17  Tom Tromey  <tom@tromey.com>
2838
2839         * tui/tui-winsource.h (tui_erase_source_content)
2840         (tui_clear_source_content): Remove "display_prompt" parameter.
2841         * tui/tui-winsource.c (tui_update_source_window_as_is)
2842         (tui_update_source_windows_with_addr): Update.
2843         (tui_clear_source_content): Remove "display_prompt" parameter.
2844         (tui_erase_source_content): Likewise.  Simplify.
2845         (tui_show_source_content): Update.
2846         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2847         * tui/tui-stack.c (tui_show_frame_info): Update.
2848         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
2849         Remove defines.
2850
2851 2019-07-17  Tom Tromey  <tom@tromey.com>
2852
2853         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2854         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
2855         parameter.
2856         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
2857         parameter.
2858
2859 2019-07-17  Tom Tromey  <tom@tromey.com>
2860
2861         * tui/tui-winsource.c (tui_clear_source_content)
2862         (tui_show_source_content, tui_show_exec_info_content)
2863         (tui_clear_exec_info_content): Update.
2864         * tui/tui-stack.c (tui_show_locator_content): Update.
2865         (tui_show_frame_info): Update.
2866         * tui/tui-source.h (tui_source_window): Don't declare.
2867         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
2868         from tui_source_is_displayed.
2869         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
2870         Remove field.
2871         (struct tui_source_window_base) <content_in_use>: New field.  Now
2872         bool.
2873         (struct tui_source_window) <showing_source_p>: New method.
2874         (TUI_SRC_WIN): Change cast.
2875         * tui/tui-data.c (tui_initialize_static_data): Update.
2876
2877 2019-07-17  Tom Tromey  <tom@tromey.com>
2878
2879         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
2880         location_matches_p.
2881         * tui/tui-source.c (tui_source_window::location_matches_p): New
2882         method.
2883         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
2884         method.
2885         * tui/tui-data.h (struct tui_source_window_base)
2886         <location_matches_p>: New method.
2887         (struct tui_source_window, struct tui_disasm_window)
2888         <location_matches_p>: Likewise.
2889
2890 2019-07-17  Tom Tromey  <tom@tromey.com>
2891
2892         * tui/tui-win.c (tui_set_win_height_command): Rename from
2893         tui_set_win_height.
2894         (tui_set_win_height_command): Remove.
2895
2896 2019-07-17  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-source.c (tui_source_window): New constructor.  Add
2899         observer.
2900         (~tui_source_window): New destructor.
2901         (tui_source_window::style_changed): New method.
2902         * tui/tui-hooks.c (tui_redisplay_source): Remove.
2903         (tui_attach_detach_observers): Update.
2904         * tui/tui-data.h (struct tui_source_window): Make constructor not
2905         inline.  Add destructor.
2906         (struct tui_source_window) <style_changed>: New method.
2907         <m_observable>: New member.
2908
2909 2019-07-17  Tom Tromey  <tom@tromey.com>
2910
2911         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
2912         * tui/tui-win.c (tui_resize_all): Fix typo.
2913
2914 2019-07-17  Tom Tromey  <tom@tromey.com>
2915
2916         * tui/tui-wingeneral.h (tui_refresh_all): Update.
2917         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
2918         (tui_refresh_all): Remove "list" parameter.  Use foreach.
2919         * tui/tui-win.c (window_name_completer): Use foreach.
2920         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
2921         (update_tab_width): Likewise.
2922         * tui/tui-layout.c (show_layout): Update.
2923         * tui/tui-data.h (class tui_window_iterator): New.
2924         (struct all_tui_windows): New.
2925         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
2926
2927 2019-07-17  Tom Tromey  <tom@tromey.com>
2928
2929         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
2930         parameter.  Don't reference globals.
2931         (tui_reg_command): Update.
2932
2933 2019-07-17  Tom Tromey  <tom@tromey.com>
2934
2935         * tui/tui-regs.c (tui_show_registers): Simplify.
2936
2937 2019-07-17  Tom Tromey  <tom@tromey.com>
2938
2939         * tui/tui-regs.c (tui_show_registers): Update.
2940         (tui_show_register_group): Add win_info parameter.
2941
2942 2019-07-17  Tom Tromey  <tom@tromey.com>
2943
2944         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
2945         Rename from tui_display_reg_element_at_line.
2946         (tui_data_window::display_registers_from_line): Update.
2947         * tui/tui-data.h (struct tui_data_window)
2948         <display_reg_element_at_line>: New method.
2949
2950 2019-07-17  Tom Tromey  <tom@tromey.com>
2951
2952         * tui/tui-regs.h (tui_display_registers_from)
2953         (tui_display_registers_from_line): Don't declare.
2954         * tui/tui-windata.c (tui_data_window::display_all_data)
2955         (tui_data_window::refresh_all)
2956         (tui_data_window::do_scroll_vertical): Update.
2957         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
2958         from tui_display_registers_from.
2959         (tui_display_reg_element_at_line): Update.
2960         (tui_data_window::display_registers_from_line): Rename from
2961         tui_display_registers_from_line.
2962         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
2963         display_registers_from_line>: New methods.
2964
2965 2019-07-17  Tom Tromey  <tom@tromey.com>
2966
2967         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
2968         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
2969         from tui_erase_data_content.
2970         (tui_data_window::display_all_data)
2971         (tui_data_window::refresh_all)
2972         (tui_data_window::do_scroll_vertical): Update.
2973         * tui/tui-regs.c (tui_show_registers): Update.
2974         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
2975         New method.
2976
2977 2019-07-17  Tom Tromey  <tom@tromey.com>
2978
2979         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
2980         declare.
2981         * tui/tui-windata.c
2982         (tui_data_window::delete_data_content_windows): Rename from
2983         tui_delete_data_content_windows.
2984         (tui_data_window::display_all_data)
2985         (tui_data_window::do_scroll_vertical): Update.
2986         * tui/tui-data.h (struct tui_data_window)
2987         <delete_data_content_windows>: New method.
2988
2989 2019-07-17  Tom Tromey  <tom@tromey.com>
2990
2991         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
2992         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
2993
2994 2019-07-17  Tom Tromey  <tom@tromey.com>
2995
2996         * tui/tui-windata.h (tui_display_all_data): Don't declare.
2997         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
2998         from tui_display_all_data.
2999         * tui/tui-win.c
3000         (tui_data_window::do_make_visible_with_new_height): Update.
3001         * tui/tui-regs.c (tui_show_registers): Update.
3002         * tui/tui-layout.c (tui_set_layout): Update.
3003         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3004         method.
3005
3006 2019-07-17  Tom Tromey  <tom@tromey.com>
3007
3008         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3009         * tui/tui-windata.c (tui_display_data_from): Remove.
3010         (tui_data_window::refresh_all): Update.
3011
3012 2019-07-17  Tom Tromey  <tom@tromey.com>
3013
3014         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3015         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3016         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3017         tui_display_registers_from_line.
3018         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3019         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3020         "force_display" parameter.
3021
3022 2019-07-17  Tom Tromey  <tom@tromey.com>
3023
3024         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3025         declare.
3026         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3027         Rename from tui_first_reg_element_no_inline.
3028         (tui_display_reg_element_at_line)
3029         (tui_display_registers_from_line): Update.
3030         * tui/tui-data.h (struct tui_data_window)
3031         <first_reg_element_no_inline>: New method.
3032
3033 2019-07-17  Tom Tromey  <tom@tromey.com>
3034
3035         * tui/tui-windata.c (tui_display_data_from)
3036         (tui_data_window::do_scroll_vertical): Update.
3037         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3038         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3039         Rename from tui_line_from_reg_element_no.
3040         (tui_display_registers_from_line): Update.
3041         * tui/tui-data.h (struct tui_data_window)
3042         <line_from_reg_element_no>: New method.
3043
3044 2019-07-17  Tom Tromey  <tom@tromey.com>
3045
3046         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3047         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3048         tui_last_regs_line_no.
3049         (tui_display_reg_element_at_line)
3050         (tui_display_registers_from_line): Update.
3051         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3052         method.
3053
3054 2019-07-17  Tom Tromey  <tom@tromey.com>
3055
3056         PR tui/24722:
3057         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3058         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3059         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3060         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3061         (tui_update_breakpoint_info): Likewise.
3062         * tui/tui-hooks.c (tui_event_create_breakpoint)
3063         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3064         Update.
3065
3066 2019-07-17  Tom Tromey  <tom@tromey.com>
3067
3068         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3069
3070 2019-07-17  Tom Tromey  <tom@tromey.com>
3071
3072         * tui/tui-winsource.c (tui_update_source_window_as_is)
3073         (tui_update_source_windows_with_addr): Update.
3074         * tui/tui-source.h (tui_set_source_content)
3075         (tui_show_symtab_source): Add "win_info" parameter.
3076         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3077         parameter.
3078         (tui_show_symtab_source): Likewise.
3079
3080 2019-07-17  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-wingeneral.c
3083         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3084
3085 2019-07-17  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3088         (struct tui_cmd_window) <can_scroll>: New method.
3089         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3090         method.
3091
3092 2019-07-17  Tom Tromey  <tromey@adacore.com>
3093
3094         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3095         do_field_signed>: Rename.  Change type of "value".
3096         * ui-out.c (ui_out::field_signed): Rename from field_int.
3097         Change type of "value".
3098         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3099         type of "value".
3100         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3101         do_field_int.  Change type of "value".
3102         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3103         do_field_int.  Change type of "value".
3104         * tracepoint.c (trace_status_mi, tfind_1)
3105         (print_one_static_tracepoint_marker): Update.
3106         * thread.c (print_thread_info_1, print_selected_thread_frame):
3107         Update.
3108         * stack.c (print_frame, print_frame_info): Update.
3109         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3110         Update.
3111         * source.c (print_source_lines_base): Update.
3112         * skip.c (info_skip_command): Update.
3113         * record-btrace.c (btrace_ui_out_decode_error)
3114         (btrace_call_history_src_line): Update.
3115         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3116         Update.
3117         * progspace.c (print_program_space): Update.
3118         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3119         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3120         do_field_int.  Change type of "value".
3121         * mi/mi-out.c (mi_ui_out::do_table_begin)
3122         (mi_ui_out::do_table_header): Update.
3123         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3124         type of "value".
3125         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3126         (mi_cmd_data_list_changed_registers, output_register)
3127         (mi_cmd_data_read_memory, mi_load_progress)
3128         (mi_cmd_trace_frame_collected): Update.
3129         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3130         Update.
3131         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3132         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3133         (mi_cmd_var_list_children, varobj_update_one): Update.
3134         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3135         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3136         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3137         * inferior.c (print_inferior): Update.
3138         * gdb_bfd.c (print_one_bfd): Update.
3139         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3140         Update.
3141         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3142         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3143         do_field_int.  Change type of "value".
3144         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3145         do_field_int.  Change type of "value".
3146         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3147         (print_one_breakpoint_location, print_it_catch_fork)
3148         (print_one_catch_fork, print_it_catch_vfork)
3149         (print_one_catch_vfork, print_it_catch_solib)
3150         (print_it_catch_exec, print_it_ranged_breakpoint)
3151         (print_mention_watchpoint, print_mention_masked_watchpoint)
3152         (bkpt_print_it, update_static_tracepoint): Update.
3153         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3154         * break-catch-syscall.c (print_it_catch_syscall): Update.
3155         * ada-tasks.c (print_ada_task_info): Update.
3156         * ada-lang.c (print_it_exception, print_mention_exception):
3157         Update.
3158
3159 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3160
3161         PR breakpoints/24541
3162         * gdbarch.c: Regenerate.
3163         * gdbarch.h: Regenerate.
3164         * gdbarch.sh: Adjust return type and parameter types for
3165         'stap_adjust_register'.
3166         (i386_stap_adjust_register): Adjust signature and return new
3167         register name.
3168         * stap-probe.c (stap_parse_register_operand): Adjust use of
3169         'gdbarch_stap_adjust_register'.
3170
3171 2019-07-17  Tom Tromey  <tromey@adacore.com>
3172
3173         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3174         declare VEC.
3175         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3176         std::vector.
3177         (struct s390_process_info): Add initializers.
3178         (s390_add_process): Use new.
3179         (s390_linux_nat_target::low_forget_process): Use delete.
3180         (s390_linux_nat_target::low_new_fork)
3181         (s390_linux_nat_target::stopped_by_watchpoint)
3182         (s390_linux_nat_target::low_prepare_to_resume)
3183         (s390_linux_nat_target::insert_watchpoint)
3184         (s390_linux_nat_target::insert_hw_breakpoint)
3185         (s390_linux_nat_target::remove_watchpoint)
3186         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3187
3188 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3189
3190         * aarch64-fbsd-nat.c: Include regcache.h.
3191         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3192         argument.
3193         (aarch64_fbsd_nat_target::fetch_registers)
3194         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3195         variable.
3196         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3197
3198 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3199
3200         * fbsd-nat.c: Include gdbarch.h.
3201
3202 2019-07-15  Tom Tromey  <tromey@adacore.com>
3203
3204         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3205
3206 2019-07-15  Tom Tromey  <tromey@adacore.com>
3207
3208         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3209         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3210         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3211         * cli-out.c (cli_ui_out::do_field_int): New method.
3212         * ui-out.c (ui_out::field_unsigned): New method.
3213         * symfile.c (generic_load): Use field_unsigned.
3214         (print_transfer_performance): Likewise.
3215         * record-btrace.c (ui_out_field_uint): Remove.
3216         (btrace_call_history_insn_range, btrace_call_history): Use
3217         field_unsigned.
3218         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3219         field_unsigned.
3220         * ui-out.h (class ui_out) <field_unsigned>: New method.
3221         <do_field_unsigned>: Likewise.
3222
3223 2019-07-15  Tom Tromey  <tromey@adacore.com>
3224
3225         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3226         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3227         * target.c (flash_erase_command): Use field_string.
3228         * infrun.c (print_signal_received_reason): Use field_string.
3229         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3230         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3231         field_string.
3232         * ada-tasks.c (print_ada_task_info): Use field_string.
3233
3234 2019-07-15  Tom Tromey  <tromey@adacore.com>
3235
3236         * target.c (flash_erase_command): Use field_core_addr.
3237         * symfile.c (generic_load): Use field_core_addr.
3238         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3239         Use field_core_addr.
3240         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3241         field_core_addr.
3242
3243 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3244
3245         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3246         value if its desired type is smaller than a CORE_ADDR and signed.
3247
3248 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3249
3250         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3251         of changes to field names, and use new is_reference field to
3252         decide if a property is a reference or not.
3253         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3254         field.
3255         (struct dwarf2_property_baton): Update header comment, rename
3256         'referenced_type' to 'property_type' and update comments.
3257         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3258         default property type, store in property baton, update to take
3259         accound of renamed field.
3260         (read_func_scope): Update call to attr_to_dynamic_prop.
3261         (read_array_type): Likewise.
3262         (dwarf2_per_cu_addr_sized_int_type): New function.
3263         (read_subrange_index_type): Move type finding code to
3264         dwarf2_per_cu_addr_sized_int_type.
3265         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3266         (dwarf2_per_cu_addr_type): New function.
3267         (set_die_type): Update calls to attr_to_dynamic_prop.
3268
3269 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3270
3271         * dwarf2read.c (read_subrange_index_type): New function.
3272         (read_subrange_type): Move code into new function and call it.
3273         * gdbtypes.c (create_range_type): Add some asserts.
3274
3275 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3276
3277         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3278         update return statements.
3279         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3280         declaration, and update comment to match.
3281         * gdbtypes.c (resolve_dynamic_array): Update call to
3282         dwarf2_evaluate_property to match new return type.
3283
3284 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * valarith.c (value_subscripted_rvalue): Change lowerbound
3287         parameter type from int to LONGEST.
3288         * value.h (value_subscripted_rvalue): Likewise in declaration.
3289
3290 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3291
3292         * cli/cli-utils.c (info_print_command_completer): New function.
3293         * cli/cli-utils.h: Add 'completer.h' include, and forward
3294         declaration for 'struct cmd_list_element'.
3295         (info_print_command_completer): Declare.
3296         * stack.c (_initialize_stack): Add completer for 'info locals' and
3297         'info args'.
3298         * symtab.c (_initialize_symtab): Add completer for 'info
3299         variables' and 'info functions'.
3300         * NEWS: Mention completion for additional info commands.
3301
3302 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3303
3304         * cli/cli-utils.c (extract_info_print_args): Delete.
3305         (extract_arg_maybe_quoted): Delete.
3306         (info_print_options_defs): New variable.
3307         (make_info_print_options_def_group): New function.
3308         (extract_info_print_options): Define new function.
3309         * cli/cli-utils.h (extract_info_print_args): Delete.
3310         (struct info_print_options): New structure.
3311         (extract_info_print_options): Declare new function.
3312         * stack.c (info_locals_command): Update to use new
3313         extract_info_print_options, also add a header comment.
3314         (info_args_command): Likewise.
3315         * symtab.c (info_variables_command): Likewise.
3316         (info_functions_command): Likewise.
3317
3318 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3319
3320         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3321         to extract string arguments.
3322         * common/common-utils.c (extract_string_maybe_quoted): New function.
3323         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3324
3325 2019-07-11  Tom Tromey  <tromey@adacore.com>
3326
3327         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3328         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3329         * top.h (gdbinit): Don't declare.
3330         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3331         into...
3332         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3333         * top.c (gdb_init): Don't call init_cli_cmds.
3334         (gdbinit): Remove.
3335         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3336
3337 2019-07-11  Tom Tromey  <tromey@adacore.com>
3338
3339         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3340         after it has been moved.
3341
3342 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3343
3344         * valops.c (value_must_coerce_to_target): Change return type to
3345         bool.
3346         * value.h (value_must_coerce_to_target): Likewise.
3347
3348 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3349
3350         * breakpoint.c (is_hardware_watchpoint): Remove
3351         forward-declaration.
3352         (is_masked_watchpoint): Change return type to bool.
3353         (is_tracepoint): Likewise.
3354         (is_breakpoint): Likewise.
3355         (is_hardware_watchpoint): Likewise.
3356         (is_watchpoint): Likewise.
3357         (is_no_memory_software_watchpoint): Likewise.
3358         (is_catchpoint): Likewise.
3359         (breakpoint_1): Make FILTER parameter's return type bool.
3360         is_masked_watchpoint): Change return type to bool.
3361         (save_breakpoints): Make FILTER parameter's return type bool.
3362         * breakpoint.h (is_breakpoint): Change return type to bool.
3363         (is_watchpoint): Likewise.
3364         (is_catchpoint): Likewise.
3365         (is_tracepoint): Likewise.
3366
3367 2019-07-10  Tom Tromey  <tom@tromey.com>
3368
3369         * defs.h: Don't include gdbarch.h.
3370         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3371         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3372         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3373         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3374         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3375         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3376         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3377         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3378         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3379         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3380         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3381         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3382         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3383         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3384         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3385         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3386         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3387         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3388         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3389         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3390         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3391         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3392         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3393         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3394         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3395         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3396         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3397
3398 2019-07-10  Tom Tromey  <tromey@adacore.com>
3399
3400         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3401         * breakpoint.c (init_ada_exception_breakpoint): Register as
3402         bp_catchpoint.
3403         (print_one_breakpoint_location, print_one_breakpoint): Use
3404         is_ada_exception_catchpoint.
3405         * ada-lang.c (class ada_catchpoint_location): Pass
3406         bp_loc_software_breakpoint to bp_location constructor.
3407         (is_ada_exception_catchpoint): New function.
3408
3409 2019-07-10  Tom Tromey  <tromey@adacore.com>
3410
3411         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3412         VEC.
3413         (struct arm_exidx_entry): New method operator<.
3414         (struct arm_exidx_data) <section_maps>: Change type.
3415         (arm_exidx_data_free): Remove.
3416         (arm_exidx_data_key): Change type.  Move lower.
3417         (arm_exidx_new_objfile): Update.
3418         (arm_compare_exidx_entries): Remove.
3419         (arm_find_exidx_entry, _initialize_arm_tdep)
3420
3421 2019-07-10  Tom Tromey  <tromey@adacore.com>
3422
3423         * solib-spu.c (ocl_program_data_key): Change type.
3424         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3425         Update.
3426
3427 2019-07-10  Tom Tromey  <tromey@adacore.com>
3428
3429         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3430         (struct solib_aix_inferior_data) <library_list>: Change type.
3431         (solib_aix_inferior_data_handle): Change type.
3432         (get_solib_aix_inferior_data): Update.
3433         (solib_aix_free_library_list): Remove.
3434         (library_list_start_library): Update.
3435         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3436         return type.
3437         (solib_aix_get_library_list)
3438         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3439         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3440
3441 2019-07-10  Tom Tromey  <tromey@adacore.com>
3442
3443         * solib-dsbt.c (struct dsbt_info): Add initializers.
3444         (solib_dsbt_pspace_data): Change type.
3445         (dsbt_pspace_data_cleanup): Remove.
3446         (get_dsbt_info, _initialize_dsbt_solib): Update.
3447
3448 2019-07-10  Tom Tromey  <tromey@adacore.com>
3449
3450         * spu-tdep.c (spu_overlay_data): Change type.
3451         (spu_get_overlay_table, spu_overlay_new_objfile)
3452         (_initialize_spu_tdep): Update.
3453
3454 2019-07-10  Tom Tromey  <tromey@adacore.com>
3455
3456         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3457         destructor.
3458         (dbx_objfile_data_key): Change type and declare later.
3459         (DBX_SYMFILE_INFO): Rewrite.
3460         * dbxread.c (dbx_objfile_data_key): Change type.
3461         (dbx_symfile_init): Update.
3462         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3463         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3464         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3465
3466 2019-07-10  Tom Tromey  <tromey@adacore.com>
3467
3468         * jit.c (jit_program_space_key): Change type.  Move lower.
3469         (get_jit_program_space_data): Update.
3470         (jit_program_space_data_cleanup): Remove.
3471         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3472         Update.
3473         (struct jit_program_space_data): Add initializers.
3474
3475 2019-07-10  Tom Tromey  <tromey@adacore.com>
3476
3477         * solib-darwin.c (struct darwin_info): Add initializers.
3478         (solib_darwin_pspace_data): Change type.
3479         (darwin_pspace_data_cleanup): Remove.
3480         (get_darwin_info, _initialize_darwin_solib): Update.
3481
3482 2019-07-10  Tom Tromey  <tromey@adacore.com>
3483
3484         * remote-sim.c (struct sim_inferior_data): Add initializers,
3485         constructor, and destructor.
3486         (sim_inferior_data_key): Change type.  Move lower.
3487         (check_for_duplicate_sim_descriptor): Update.
3488         (get_sim_inferior_data): Use new.  Update.
3489         (~sim_inferior_data_cleanup): Rename from
3490         sim_inferior_data_cleanup.  Simplify.
3491         (gdbsim_close_inferior, simulator_command)
3492         (sim_command_completer, _initialize_remote_sim): Update.
3493         (next_pid, INITIAL_PID): Move earlier.
3494
3495 2019-07-10  Tom Tromey  <tromey@adacore.com>
3496
3497         * python/python-internal.h (create_thread_object): Return
3498         gdbpy_ref.
3499         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3500         * python/py-inferior.c (struct threadlist_entry): Add
3501         constructor.
3502         <thread_obj>: Now a gdbpy_ref.
3503         (thread_to_thread_object): Update.
3504         (add_thread_object): Use new.
3505         (delete_thread_object): Use delete.
3506         (infpy_threads): Update.
3507         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3508         GIL.
3509
3510 2019-07-10  Tom Tromey  <tromey@adacore.com>
3511
3512         * valops.c (value_cast): Specialize error message for Ada.
3513
3514 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3515
3516         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3517
3518 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3519
3520         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3521         bpstat_should_step): Return bool, adjust comments.
3522         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3523         bpstat_should_step): Likewise.
3524
3525 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3526
3527         * features/Makefile: Use feature target descriptions for Arm.
3528         * features/arm/arm-core.c: Generate new file.
3529         * features/arm/arm-fpa.c: Likewise.
3530         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3531         * features/arm/arm-m-profile.c: Likewise.
3532         * features/arm/arm-vfpv2.c: Likewise.
3533         * features/arm/arm-vfpv3.c: Likewise.
3534         * features/arm/xscale-iwmmxt.c: Likewise.
3535         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3536
3537 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3538
3539         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3540         ptrace earlier.
3541
3542 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3543
3544         * features/aarch64-pauth.c: Regenerate.
3545
3546 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3547
3548         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3549         bool.
3550         (bpstat_what): Use false instead of 0.
3551
3552 2019-07-09  Pedro Alves  <palves@redhat.com>
3553
3554         * break-catch-throw.c (is_exception_catchpoint): New.
3555         * breakpoint.c (print_one_breakpoint_location): New parameter
3556         'raw_loc'.  Handle it.  Use
3557         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3558         looking at the breakpoint's type.
3559         (print_one_breakpoint): If handling "maint info breakpoints", also
3560         print locations of exception catchpoints.
3561         * breakpoint.h (is_exception_catchpoint): Declare.
3562
3563 2019-07-09  Pedro Alves  <palves@redhat.com>
3564
3565         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3566         "addr" field.
3567         (allocate_location_exception_catchpoint): New.
3568         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3569         (initialize_throw_catchpoint_ops): Install
3570         allocate_location_exception_catchpoint as allocate_location
3571         method.
3572         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3573         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3574         bp_loc_other.
3575         (breakpoint_address_is_meaningful): Delete.
3576         (bl_address_is_meaningful): New.
3577         (breakpoint_locations_match): Adjust comment.
3578         (bp_location_from_bp_type): New, factored out of...
3579         (bp_location::bp_location(breakpoint *)): ... this.
3580         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3581         factored out of...
3582         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3583         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3584         breakpoint_address_is_meaningful.
3585         (bp_locations_compare): Adjust comment.
3586         (update_global_location_list): Use bl_address_is_meaningful
3587         instead of breakpoint_address_is_meaningful.
3588         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3589         explicit.
3590         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3591         * python/py-breakpoint.c (bppy_get_location): No longer check
3592         whether location is null.
3593
3594 2019-07-09  Pedro Alves  <palves@redhat.com>
3595
3596         PR c++/15468
3597         * breakpoint.c (print_one_breakpoint_location): Remove
3598         single-location assert.
3599
3600 2019-07-09  Tom Tromey  <tom@tromey.com>
3601
3602         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3603         * configure: Rebuild.
3604         * configure.ac: Change common to gdbsupport.
3605         * gdbsupport: Rename from common.
3606         * acinclude.m4: Change common to gdbsupport.
3607         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3608         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3609         gdbsupport.
3610         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3611         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3612         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3613         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3614         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3615         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3616         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3617         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3618         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
3619         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
3620         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
3621         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
3622         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
3623         coff-pe-read.c, command.h, compile/compile-c-support.c,
3624         compile/compile-c.h, compile/compile-cplus-symbols.c,
3625         compile/compile-cplus-types.c, compile/compile-cplus.h,
3626         compile/compile-loc2c.c, compile/compile.c, completer.c,
3627         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
3628         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
3629         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
3630         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
3631         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
3632         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
3633         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
3634         features/aarch64-core.c, features/aarch64-fpu.c,
3635         features/aarch64-pauth.c, features/aarch64-sve.c,
3636         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
3637         features/i386/32bit-core.c, features/i386/32bit-linux.c,
3638         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
3639         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
3640         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
3641         features/i386/64bit-core.c, features/i386/64bit-linux.c,
3642         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
3643         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
3644         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
3645         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
3646         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
3647         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
3648         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
3649         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
3650         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
3651         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
3652         go32-nat.c, guile/guile.c, guile/scm-ports.c,
3653         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
3654         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
3655         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
3656         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
3657         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
3658         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
3659         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
3660         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
3661         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
3662         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
3663         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
3664         minsyms.c, mips-linux-tdep.c, namespace.h,
3665         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
3666         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
3667         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
3668         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
3669         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
3670         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
3671         nat/linux-waitpid.c, nat/mips-linux-watch.c,
3672         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
3673         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
3674         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
3675         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
3676         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
3677         procfs.c, producer.c, progspace.h, psymtab.h,
3678         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
3679         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
3680         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
3681         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
3682         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
3683         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
3684         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
3685         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
3686         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
3687         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
3688         target-memory.c, target.c, target.h, target/waitstatus.c,
3689         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
3690         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
3691         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
3692         unittests/array-view-selftests.c,
3693         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
3694         unittests/common-utils-selftests.c,
3695         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
3696         unittests/format_pieces-selftests.c,
3697         unittests/function-view-selftests.c,
3698         unittests/lookup_name_info-selftests.c,
3699         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
3700         unittests/mkdir-recursive-selftests.c,
3701         unittests/observable-selftests.c,
3702         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
3703         unittests/parse-connection-spec-selftests.c,
3704         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
3705         unittests/scoped_fd-selftests.c,
3706         unittests/scoped_mmap-selftests.c,
3707         unittests/scoped_restore-selftests.c,
3708         unittests/string_view-selftests.c, unittests/style-selftests.c,
3709         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
3710         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
3711         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
3712         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
3713         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
3714         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
3715
3716 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * linespec.c (decode_digits_list_mode): Set explicit_line to a
3719         bool value.
3720         (decode_digits_ordinary): Set explicit_line field in sal.
3721         * symtab.c (skip_prologue_sal): Don't skip prologue for a
3722         symtab_and_line that was set on an explicit line number in
3723         assembler code.  Do always update the recorded symtab and line if
3724         we do skip the prologue.
3725
3726 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * breakpoint.c (set_breakpoint_location_function): Remove
3729         explicit_loc parameter.
3730         (momentary_breakpoint_from_master): Update call to
3731         set_breakpoint_location_function.
3732         (add_location_to_breakpoint): Likewise.
3733
3734 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
3737         required features based on default bfd type when no specific bfd
3738         is present.
3739
3740 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3741
3742         * NEWS: Mention that GDB printf and eval commands can now print
3743         C-style and Ada-style convenience var strings without
3744         calling the inferior.
3745         * printcmd.c (printf_c_string): Locally print GDB internal var
3746         instead of transiting via the inferior.
3747         (printf_wide_c_string): Likewise.
3748
3749 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3750
3751         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
3752
3753 2019-07-04  Tom Tromey  <tom@tromey.com>
3754
3755         PR tui/24724:
3756         * tui/tui-winsource.c (tui_clear_source_content): Update.
3757         (tui_source_window_base::set_is_exec_point_at): Fix comment.
3758         (tui_update_breakpoint_info): Update.
3759         (tui_set_exec_info_content): Update.
3760         * tui/tui-source.c (tui_set_source_content_nil): Update.
3761         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
3762         has_break.
3763         * tui/tui-data.h (enum tui_bp_flag): New.
3764         (tui_bp_flags): New enum flags type.
3765         (struct tui_source_element) <break_mode>: Change type.  Rename
3766         from has_break.
3767         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
3768         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
3769         constants.
3770         * tui/tui-winsource.h: Fix comment.
3771
3772 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3773
3774         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
3775         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
3776         (store_fpregs_to_thread)
3777         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3778         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
3779         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
3780         (IWMMXT_REGS_SIZE): Add define.
3781         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
3782         (fetch_vfp_regs, store_vfp_regs)
3783         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
3784         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
3785
3786 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3787
3788         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
3789         defines.
3790         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
3791         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
3792         (ARM_INT_REGISTER_SIZE): ...to this.
3793         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
3794         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
3795         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
3796         (arm_linux_collect_gregset, supply_nwfpe_register)
3797         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
3798         defines.
3799         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
3800         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
3801         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
3802         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
3803         (arm_return_in_memory, arm_store_return_value)
3804         (arm_get_longjmp_target, arm_register_g_packet_guesses)
3805         (arm_record_ld_st_multiple): Likewise.
3806         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
3807         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
3808
3809 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3810
3811         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
3812         AARCH64_DISPLACED_MODIFIED_INSNS.
3813         * aarch64-tdep.c (struct aarch64_displaced_step_data)
3814         (aarch64_displaced_step_copy_insn): Likewise.
3815         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3816         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
3817         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
3818         ARM_DISPLACED_MODIFIED_INSNS.
3819         * arm-tdep.c (arm_gdbarch_init): Likewise.
3820         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
3821         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
3822         (struct arm_displaced_step_closure): Use
3823         ARM_DISPLACED_MODIFIED_INSNS.
3824
3825 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3826
3827         * features/Makefile: Remove unused xml files.
3828         * features/aarch64.xml: Remove.
3829         * features/i386/amd64-avx-avx512-linux.xml: Remove.
3830         * features/i386/amd64-avx-avx512.xml: Remove.
3831         * features/i386/amd64-avx-linux.xml: Remove.
3832         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
3833         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
3834         * features/i386/amd64-avx-mpx-linux.xml: Remove.
3835         * features/i386/amd64-avx-mpx.xml: Remove.
3836         * features/i386/amd64-avx.xml: Remove.
3837         * features/i386/amd64-linux.xml: Remove.
3838         * features/i386/amd64-mpx-linux.xml: Remove.
3839         * features/i386/amd64-mpx.xml: Remove.
3840         * features/i386/amd64.xml: Remove.
3841         * features/i386/i386-avx-avx512-linux.xml: Remove.
3842         * features/i386/i386-avx-avx512.xml: Remove.
3843         * features/i386/i386-avx-linux.xml: Remove.
3844         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
3845         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
3846         * features/i386/i386-avx-mpx-linux.xml: Remove.
3847         * features/i386/i386-avx-mpx.xml: Remove.
3848         * features/i386/i386-avx.xml: Remove.
3849         * features/i386/i386-linux.xml: Remove.
3850         * features/i386/i386-mmx-linux.xml: Remove.
3851         * features/i386/i386-mmx.xml: Remove.
3852         * features/i386/i386-mpx-linux.xml: Remove.
3853         * features/i386/i386-mpx.xml: Remove.
3854         * features/i386/i386.xml: Remove.
3855         * features/i386/x32-avx-avx512-linux.xml: Remove.
3856         * features/i386/x32-avx-linux.xml: Remove.
3857         * features/i386/x32-linux.xml: Remove.
3858
3859 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3860
3861         * regformats/aarch64.dat: Remove.
3862         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
3863         * regformats/i386/amd64-avx-linux.dat: Remove.
3864         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
3865         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
3866         * regformats/i386/amd64-linux.dat: Remove.
3867         * regformats/i386/amd64-mpx-linux.dat: Remove.
3868         * regformats/i386/amd64.dat: Remove.
3869         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
3870         * regformats/i386/i386-avx-linux.dat: Remove.
3871         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
3872         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
3873         * regformats/i386/i386-linux.dat: Remove.
3874         * regformats/i386/i386-mmx-linux.dat: Remove.
3875         * regformats/i386/i386-mpx-linux.dat: Remove.
3876         * regformats/i386/i386.dat: Remove.
3877         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
3878         * regformats/i386/x32-avx-linux.dat: Remove.
3879         * regformats/i386/x32-linux.dat: Remove.
3880
3881 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
3882
3883         * aarch64-tdep.c: Remove xml self tests.
3884         * amd64-linux-tdep.c: Likewise.
3885         * amd64-tdep.c: Likewise.
3886         * i386-linux-tdep.c: Likewise.
3887         * i386-tdep.c: Likewise.
3888
3889 2019-07-03  Pedro Alves  <palves@redhat.com>
3890
3891         PR cli/24732
3892         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
3893         (pipe_cmd_option_defs): New.
3894         (make_pipe_cmd_options_def_group): New.
3895         (pipe_command): Use gdb::option::process_options.
3896         (pipe_command_completer): New function.
3897         (_initialize_cli_cmds): Install completer for "pipe" command.
3898
3899 2019-07-03  Pedro Alves  <palves@redhat.com>
3900
3901         * cli/cli-option.c (union option_value) <string>: New field.
3902         (struct option_def_and_value): Add ctor, move ctor, dtor and
3903         use DISABLE_COPY_AND_ASSIGN.
3904         (option_def_and_value::clear_value): New.
3905         (parse_option, save_option_value_in_ctx, get_val_type_str)
3906         (add_setshow_cmds_for_options): Handle var_string.
3907         * cli-option.h (union option_def::var_address) <string>: New
3908         field.
3909         (struct string_option_def): New.
3910         * maint-test-options.c (struct test_options_opts): Add default
3911         ctor and use DISABLE_COPY_AND_ASSIGN.
3912         <string_opt>: New field.
3913         (test_options_opts::~test_options_opts): New.
3914         (test_options_opts::dump): Also dump "-string".
3915         (test_options_option_defs): Install "string.
3916
3917 2019-07-03  Pedro Alves  <palves@redhat.com>
3918
3919         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
3920         option_value with a null enumeration.
3921         (complete_options): Save the option values in the context.
3922         (save_option_value_in_ctx): New, factored out from ...
3923         (process_options): ... here.
3924         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
3925         of the function.
3926         * maint-test-options.c (test_options_opts::dump): New, factored
3927         out from ...
3928         (maintenance_test_options_command_mode): ... here.
3929         (maintenance_test_options_command_completion_result): Delete.
3930         (maintenance_test_options_command_completion_text): Update
3931         comment.
3932         (maintenance_show_test_options_completion_result): Change
3933         prototype.  Just print
3934         maintenance_test_options_command_completion_text.
3935         (save_completion_result): New.
3936         (maintenance_test_options_completer_mode): Pass options context to
3937         complete_options, and then save a dump.
3938         (_initialize_maint_test_options): Use add_cmd to install "maint
3939         show test-options-completion-result".
3940
3941 2019-07-03  Pedro Alves  <palves@redhat.com>
3942
3943         * NEWS (New commands): Mention "with" and "maint with".
3944         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
3945         (with_command, with_command_completer): New.
3946         (pipe_command): Adjust to new repeat_previous
3947         interface.
3948         (_initialize_cli_cmds): Install the "with" command and its "w"
3949         alias.
3950         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
3951         declarations.
3952         * cli/cli-setshow.c (parse_cli_var_uinteger)
3953         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
3954         argument strings for all var_types.
3955         (get_setshow_command_value_string): New, factored out from ...
3956         (do_show_command): ... this.
3957         * cli/cli-setshow.h: Include <string>.
3958         (get_setshow_command_value_string): Declare.
3959         * command.h (repeat_previous): Now returns const char *.  Adjust
3960         comment.
3961         * maint.c: Include "cli/cli-cmds.h".
3962         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
3963         (_initialize_maint_cmds): Register the "maintenance with" command.
3964         * top.c (repeat_previous): Move bits from pipe_command here:
3965         Return the saved command line, if any; error out if there's no
3966         command to relaunch.
3967
3968 2019-07-03  Pedro Alves  <palves@redhat.com>
3969
3970         * NEWS (New commands): Mention "maint set/show test-settings"
3971         instead of "maint test-settings".
3972         * maint-test-settings.c (maintenance_test_settings_list): Delete.
3973         (maintenance_test_settings_set_list): Rename to ...
3974         (maintenance_set_test_settings_list): ... this.
3975         (maintenance_test_settings_show_list): Rename to  ...
3976         (maintenance_show_test_settings_list): ... this.
3977         (maintenance_test_settings_cmd): Delete.
3978         (maintenance_test_settings_set_cmd): ...
3979         (maintenance_set_test_settings_cmd): ... this.
3980         (maintenance_test_settings_show_cmd): ...
3981         (maintenance_show_test_settings_cmd): ... this.
3982         (maintenance_test_settings_show_value_cmd):
3983         (maintenance_show_test_settings_value_cmd): ... this.
3984         (_initialize_maint_test_settings): No longer install the "maint
3985         test-settings" prefix command.  Rename "maint test-settings set"
3986         to "maint set test-settings", and "maint test-settings show" to
3987         "maint show test-settings".  Adjust all subcommands.
3988
3989 2019-07-03  Pedro Alves  <palves@redhat.com>
3990
3991         * maint-test-settings.c: Fix file's intro comment.  Replace all
3992         references to "test-options" with references to "test-settings",
3993         in comments.
3994
3995 2019-07-03  Pedro Alves  <palves@redhat.com>
3996
3997         * maint-test-settings.c (maintenance_test_settings_xxx)
3998         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
3999         New.
4000         (maintenance_test_settings_enums): Use them.
4001         (maintenance_test_settings_enum): Default to
4002         maintenance_test_settings_xxx.
4003         (_initialize_maint_test_settings): Initialize
4004         MAINTENANCE_TEST_SETTINGS_FILENAME.
4005
4006 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4007
4008         * breakpoint.h (remove_breakpoints_inf): Change return type to
4009         void, move function documentation here.
4010         * breakpoint.c (remove_breakpoints_inf): Change return type to
4011         void, move function documentation to header.
4012
4013 2019-07-02  Pedro Alves  <palves@redhat.com>
4014
4015         * NEWS (Completion improvements): Mention "info threads".
4016         * thread.c (struct info_threads_opts, info_threads_option_defs)
4017         (make_info_threads_options_def_group): New.
4018         (info_threads_command): Use gdb::option::process_options.
4019         (info_threads_command_completer): New.
4020         (_initialize_thread): Use gdb::option::build_help to build the
4021         help text for "info threads".
4022
4023 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4024
4025         * defs.h (generic_load): Move from here...
4026         * symfile.h (generic_load): ... to here.  Rename name parameter
4027         to args.
4028         * symfile.c (generic_load): Add comment.
4029
4030 2019-07-01  Tom Tromey  <tromey@adacore.com>
4031
4032         * dwarf2read.c
4033         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4034         declaration of without_params.  Fix formatting.
4035
4036 2019-07-01  Tom Tromey  <tromey@adacore.com>
4037
4038         * ada-exp.y (find_primitive_type): Update.
4039         * ada-lang.h (ada_lookup_symbol): Update.
4040         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4041         parameter.
4042         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4043
4044 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4045
4046         PR breakpoints/24541
4047         * gdbarch.c: Regenerate.
4048         * gdbarch.h: Regenerate.
4049         * gdbarch.sh: Add 'stap_adjust_register'.
4050         * i386-tdep.c: Include '<unordered_set>'.
4051         (i386_stap_adjust_register): New function.
4052         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4053         * stap-probe.c (stap_parse_register_operand): Call
4054         'gdbarch_stap_adjust_register'.
4055
4056 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4057
4058         PR python/24742
4059         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4060         * python/python.c (do_start_initialization): Use 'xmalloc'
4061         instead of 'PyMem_Malloc'.
4062
4063 2019-06-28  Tom Tromey  <tromey@adacore.com>
4064
4065         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4066         for Ada.
4067
4068 2019-06-27  Tom Tromey  <tromey@adacore.com>
4069
4070         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4071         objfile_key.
4072         (arm_find_mapping_symbol, arm_record_special_symbol)
4073         (_initialize_arm_tdep): Update.
4074         (arm_objfile_data_free): Remove.
4075
4076 2019-06-27  Tom Tromey  <tromey@adacore.com>
4077
4078         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4079         to cp_print_static_field.
4080
4081 2019-06-26  Tom Tromey  <tromey@adacore.com>
4082
4083         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4084         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4085         declare.
4086
4087 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4088
4089         * features/aarch64-core.c (create_feature_aarch64_core):
4090         Regenerate.
4091         * features/aarch64-core.xml: Add cpsr flags.
4092
4093 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4094
4095         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4096         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4097
4098 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4099
4100         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4101         field.
4102         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4103         use.
4104         (arm_record_special_symbol): Don't insert new symbol in sorted
4105         position, push it at the end.
4106
4107 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4108
4109         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4110         (arm_mapping_symbol_s): Remove.
4111         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4112         (arm_mapping_symbol_vec): New typedef.
4113         (struct arm_per_objfile): Add constructor.
4114         <section_maps>: Change type to
4115         std::unique_ptr<arm_mapping_symbol_vec[]>.
4116         (arm_compare_mapping_symbols): Remove.
4117         (arm_find_mapping_symbol): Adjust to section_maps type change.
4118         (arm_objfile_data_free): Call delete on arm_per_objfile.
4119         (arm_record_special_symbol): Adjust to section_maps type change.
4120         Allocate arm_per_objfile with new.
4121
4122 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4123
4124         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4125         with the command prefix.
4126
4127 2019-06-25  Tom Tromey  <tom@tromey.com>
4128
4129         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4130         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4131
4132 2019-06-25  Tom Tromey  <tom@tromey.com>
4133
4134         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4135         type.
4136         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4137         protected.
4138
4139 2019-06-25  Tom Tromey  <tom@tromey.com>
4140
4141         * tui/tui-winsource.c
4142         (tui_source_window_base::set_is_exec_point_at): Add check against
4143         LOA_ADDRESS.
4144
4145 2019-06-25  Tom Tromey  <tom@tromey.com>
4146
4147         * tui/tui-source.c (tui_set_source_content): Don't check before
4148         xfree.
4149         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4150
4151 2019-06-25  Tom Tromey  <tom@tromey.com>
4152
4153         * tui/tui-winsource.h (tui_update_source_window_as_is)
4154         (tui_alloc_source_buffer, tui_line_is_displayed)
4155         (tui_addr_is_displayed): Change type of win_info.
4156         * tui/tui-winsource.c (tui_update_source_window_as_is)
4157         (tui_clear_source_content, tui_show_source_line)
4158         (tui_show_source_content, tui_source_window_base::refill)
4159         (tui_source_window_base::set_is_exec_point_at)
4160         (tui_source_window_base::set_is_exec_point_at)
4161         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4162         (tui_alloc_source_buffer, tui_line_is_displayed)
4163         (tui_addr_is_displayed): Change type of win_info.  Update.
4164         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4165         (tui_source_window_base::do_make_visible_with_new_height):
4166         Update.
4167         * tui/tui-source.c (tui_set_source_content)
4168         (tui_set_source_content_nil)
4169         (tui_source_window::do_scroll_vertical): Update.
4170         * tui/tui-layout.c (show_layout): Update.
4171         * tui/tui-disasm.c (tui_set_disassem_content)
4172         (tui_disasm_window::do_scroll_vertical): Update.
4173         * tui/tui-data.h (tui_win_content): Remove.
4174         (struct tui_gen_win_info) <content, content_size>: Remove.
4175         (struct tui_source_element): Add initializers and destructor.
4176         (union tui_which_element, struct tui_win_element): Remove.
4177         (struct tui_source_window_base) <content>: New field.
4178         (struct tui_data_window): Remove destructor.
4179         (tui_alloc_content, tui_free_win_content)
4180         (tui_free_all_source_wins_content): Don't declare.
4181         * tui/tui-data.c (tui_initialize_static_data): Update.
4182         (init_content_element, tui_alloc_content): Remove.
4183         (~tui_gen_win_info): Update.
4184         (~tui_data_window, tui_free_all_source_wins_content)
4185         (tui_free_win_content, free_content, free_content_elements):
4186         Remove.
4187
4188 2019-06-25  Tom Tromey  <tom@tromey.com>
4189
4190         * tui/tui-winsource.h (tui_clear_source_content)
4191         (tui_erase_source_content, tui_show_source_content): Change type
4192         of win_info.
4193         * tui/tui-winsource.c (tui_clear_source_content)
4194         (tui_erase_source_content, tui_show_source_content): Change type
4195         of win_info.
4196         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4197         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4198         win_info.
4199         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4200         win_info.
4201         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4202
4203 2019-06-25  Tom Tromey  <tom@tromey.com>
4204
4205         * tui/tui-winsource.c (tui_clear_source_content)
4206         (tui_source_window_base::set_is_exec_point_at): Update.
4207         * tui/tui-source.c (tui_set_source_content_nil): Update.
4208         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4209         a bool.
4210         * tui/tui-data.c (init_content_element): Update.
4211
4212 2019-06-25  Tom Tromey  <tom@tromey.com>
4213
4214         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4215         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4216         * tui/tui-layout.c (init_and_make_win): Update.
4217         * tui/tui.h (enum tui_win_type): Update.
4218         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4219         tui_win_is_auxillary.
4220         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4221         tui_win_is_auxillary.
4222
4223 2019-06-25  Tom Tromey  <tom@tromey.com>
4224
4225         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4226         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4227         (tui_delete_data_content_windows, tui_display_all_data)
4228         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4229         Update.
4230         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4231         * tui/tui-regs.c (tui_last_regs_line_no)
4232         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4233         (tui_show_registers): Update.
4234         (tui_show_register_group): Return void.  Update.
4235         (tui_display_registers_from, tui_display_reg_element_at_line)
4236         (tui_display_registers_from_line, tui_check_register_values):
4237         Update.
4238         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4239         member.
4240         (struct tui_data_window) <regs_content>: Now a std::vector.
4241         <regs_content_count>: Remove.
4242         (tui_add_content_elements, tui_free_data_content): Don't declare.
4243         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4244         (init_content_element): Remove DATA_WIN case.  Add assert.
4245         (tui_add_content_elements): Remove.
4246         (tui_data_window): Update.
4247         (tui_free_data_content): Remove.
4248         (free_content_elements): Remove DATA_WIN case.
4249
4250 2019-06-25  Tom Tromey  <tom@tromey.com>
4251
4252         * tui/tui-data.c (tui_data_item_window): Update.
4253         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4254         * tui/tui-windata.c (tui_display_all_data)
4255         (tui_display_data_from_line): Update.
4256         (tui_check_data_values): Remove.
4257         * tui/tui-regs.c (tui_show_register_group)
4258         (tui_display_reg_element_at_line): Update.
4259         * tui/tui-hooks.c (tui_register_changed)
4260         (tui_refresh_frame_and_register_information): Call
4261         tui_check_register_values.
4262         * tui/tui-data.h (struct tui_data_window) <data_content,
4263         data_content_count, data_type>: Remove.
4264         (enum tui_data_type): Remove.
4265
4266         * tui/tui-data.c (tui_data_window::clear_detail)
4267         (~tui_data_window): Update.
4268
4269 2019-06-25  Tom Tromey  <tom@tromey.com>
4270
4271         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4272         declare.
4273         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4274         Rename from tui_first_data_item_displayed.  Update.
4275         (tui_data_window::refresh_all)
4276         (tui_data_window::do_scroll_vertical): Update.
4277         * tui/tui-data.h (struct tui_data_window)
4278         <first_data_item_displayed>: Declare new method.
4279
4280 2019-06-25  Tom Tromey  <tom@tromey.com>
4281
4282         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4283         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4284         contents...
4285         (tui_initialize_static_data): ...here.
4286
4287 2019-06-25  Tom Tromey  <tom@tromey.com>
4288
4289         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4290         (tui_display_registers_from, tui_check_register_values): Update.
4291         (tui_display_register): Remove win_info parameter; update.
4292         (tui_get_register): Change type of parameters.
4293         * tui/tui-data.h (struct tui_data_element): Remove.
4294         (union tui_which_element) <data>: Remove.
4295         <data_window>: Change type.
4296         (struct tui_data_item_window): New.
4297         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4298         case.  Add assert.
4299         (~tui_data_item_window): New destructor.
4300         (free_content_elements): Remove DATA_ITEM_WIN case.
4301
4302 2019-06-25  Tom Tromey  <tom@tromey.com>
4303
4304         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4305         Remove.
4306
4307 2019-06-25  Tom Tromey  <tom@tromey.com>
4308
4309         * tui/tui-data.h (struct tui_command_element): Remove.
4310         (union tui_which_element) <command>: Remove.
4311         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4312         assert.
4313         (free_content_elements): Remove CMD_WIN case.
4314
4315 2019-06-25  Tom Tromey  <tom@tromey.com>
4316
4317         * tui/tui-layout.c (tui_set_layout): Update.
4318         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4319         * tui/tui-data.c (layout_def): Update.
4320
4321 2019-06-25  Tom Tromey  <tom@tromey.com>
4322
4323         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4324         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4325         (tui_source_window_base::set_new_height): Update.
4326         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4327         Update.
4328         (tui_set_locator_fullname, tui_set_locator_info)
4329         (tui_show_frame_info): Update.
4330         * tui/tui-source.c (tui_set_source_content)
4331         (tui_source_is_displayed): Update.
4332         * tui/tui-layout.c (show_source_disasm_command, show_data)
4333         (show_source_or_disasm_and_command): Update.
4334         * tui/tui-disasm.c (tui_set_disassem_content)
4335         (tui_get_begin_asm_address): Update.
4336         * tui/tui-data.h (struct tui_locator_element): Remove.
4337         (union tui_which_element) <locator>: Remove.
4338         (struct tui_locator_window): New.
4339         (tui_locator_win_info_ptr): Change return type.
4340         * tui/tui-data.c (_locator): Change type.
4341         (tui_locator_win_info_ptr): Change return type.
4342         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4343         (tui_alloc_content): Add assert.
4344
4345 2019-06-25  Tom Tromey  <tom@tromey.com>
4346
4347         * tui/tui-winsource.c
4348         (tui_exec_info_window::maybe_allocate_content): New method.
4349         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4350         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4351         (make_source_or_disasm_window): Add cast.
4352         * tui/tui-data.h (union tui_which_element) <simple_string>:
4353         Remove.
4354         (struct tui_source_info): New.
4355         (struct tui_source_window_base) <execution_info>: Change type.
4356         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4357         case, and add assert.
4358         (tui_alloc_content): Add assert.
4359
4360 2019-06-25  Tom Tromey  <tom@tromey.com>
4361
4362         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4363         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4364         * tui/tui-data.c (tui_alloc_win_info): Remove.
4365
4366 2019-06-25  Tom Tromey  <tom@tromey.com>
4367
4368         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4369         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4370         can_highlight.
4371
4372 2019-06-25  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4375         make_visible_with_new_height method.
4376         (tui_win_info::make_visible_with_new_height): New method.
4377         (tui_source_window_base::do_make_visible_with_new_height)
4378         (tui_data_window::do_make_visible_with_new_height)
4379         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4380         (make_visible_with_new_height): Remove.
4381         (tui_resize_all, tui_adjust_win_heights): Use
4382         make_visible_with_new_height method.
4383         * tui/tui-data.h (struct tui_win_info)
4384         <do_make_visible_with_new_height, make_visible_with_new_height>:
4385         New methods.
4386         (struct tui_source_window_base, struct tui_data_window)
4387         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4388         methods.
4389
4390 2019-06-25  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4393         method.
4394         (update_tab_width): Call update_tab_width method.
4395         * tui/tui-data.h (struct tui_win_info)
4396         (struct tui_source_window_base) <update_tab_width>: New methods.
4397
4398 2019-06-25  Tom Tromey  <tom@tromey.com>
4399
4400         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4401         parameter.
4402         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4403         parameter.
4404         (tui_gen_win_info::make_visible): Update.
4405         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4406         parameter.
4407         * tui/tui-data.h (enum tui_box): New enum.
4408         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4409
4410 2019-06-25  Tom Tromey  <tom@tromey.com>
4411
4412         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4413         init_and_make_win for EXEC_INFO_WIN.
4414         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4415         longer inline.
4416         (struct tui_win_info) <~tui_win_info>: Inline.
4417         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4418         Don't declare.
4419         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4420         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4421         Remove.
4422         (tui_initialize_static_data): Update.
4423         (~tui_gen_win_info): Handle more cleanup here.
4424         (~tui_source_window_base): Delete "execution_info".
4425         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4426
4427 2019-06-25  Tom Tromey  <tom@tromey.com>
4428
4429         * tui/tui-layout.c (make_command_window): Don't set
4430         can_highlight.
4431         (show_source_disasm_command): Call the reset method.
4432         (show_data): Don't set can_highlight.  Call the reset method.
4433         (tui_gen_win_info::reset): Rename from init_gen_win_info
4434         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4435         (show_source_or_disasm_and_command): Call the reset method.
4436         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4437         (struct tui_cmd_window): Set can_highlight.
4438
4439 2019-06-25  Tom Tromey  <tom@tromey.com>
4440
4441         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4442         from make_visible.
4443         (tui_make_visible, tui_make_invisible): Rewrite.
4444         (tui_win_info::make_visible): Remove.
4445         (tui_source_window_base::make_visible): Update.
4446         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4447         method.  Moved from...
4448         (struct tui_win_info) <make_visible>: ...here.
4449
4450 2019-06-25  Tom Tromey  <tom@tromey.com>
4451
4452         * tui/tui-winsource.c
4453         (tui_source_window_base::do_scroll_horizontal): Remove direction
4454         parameter.
4455         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4456         direction parameter.
4457         * tui/tui-win.c (tui_win_info::forward_scroll)
4458         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4459         (tui_win_info::right_scroll): Update.
4460         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4461         direction parameter.
4462         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4463         direction parameter.
4464         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4465         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4466         Remove direction parameter.
4467         (struct tui_source_window_base, struct tui_source_window)
4468         (struct tui_disasm_window, struct tui_data_window)
4469         (struct tui_cmd_window): Update.
4470
4471 2019-06-25  Tom Tromey  <tom@tromey.com>
4472
4473         * tui/tui-winsource.h (tui_set_exec_info_content)
4474         (tui_show_exec_info_content, tui_erase_exec_info_content)
4475         (tui_clear_exec_info_content, tui_update_exec_info): Change
4476         argument to tui_source_window_base.
4477         * tui/tui-winsource.c (tui_set_exec_info_content)
4478         (tui_show_exec_info_content, tui_erase_exec_info_content)
4479         (tui_clear_exec_info_content, tui_update_exec_info): Change
4480         argument to tui_source_window_base.
4481
4482 2019-06-25  Tom Tromey  <tom@tromey.com>
4483
4484         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4485         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4486
4487 2019-06-25  Tom Tromey  <tom@tromey.com>
4488
4489         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4490         check.
4491
4492 2019-06-25  Tom Tromey  <tom@tromey.com>
4493
4494         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4495         type to void.
4496         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4497         type to void.
4498         * tui/tui-source.c (tui_set_source_content): Update.
4499         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4500
4501 2019-06-25  Tom Tromey  <tom@tromey.com>
4502
4503         * tui/tui-win.c (window_name_completer, tui_set_focus)
4504         (tui_all_windows_info): Use name method.
4505         * tui/tui-data.h (struct tui_gen_win_info)
4506         (struct tui_source_window, struct tui_disasm_window)
4507         (struct tui_data_window, struct tui_cmd_window) <name>: New
4508         method.
4509         (tui_win_name): Don't declare.
4510         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4511         (tui_win_name): Remove.
4512
4513 2019-06-25  Tom Tromey  <tom@tromey.com>
4514
4515         * tui/tui-winsource.h (tui_update_source_window)
4516         (tui_update_source_window_as_is): Change parameter type.
4517         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4518         to be a tui_source_window_base.
4519         (tui_update_source_window_as_is): Likewise.
4520         * tui/tui-win.c (make_visible_with_new_height): Update.
4521
4522 2019-06-25  Tom Tromey  <tom@tromey.com>
4523
4524         * tui/tui-winsource.c (tui_erase_source_content)
4525         (tui_show_source_content, tui_show_exec_info_content)
4526         (tui_erase_exec_info_content): Use refresh_window method.
4527         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4528         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4529         from tui_refresh_win.
4530         (tui_data_window::refresh_window): New method.
4531         (tui_win_info::refresh, tui_source_window_base::refresh)
4532         (tui_refresh_all): Use refresh_window method.
4533         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4534         method.
4535         * tui/tui-regs.c (tui_display_register): Call refresh_window
4536         method.
4537         * tui/tui-layout.c (show_source_disasm_command)
4538         (show_source_or_disasm_and_command): Call refresh_window method.
4539         * tui/tui-data.h (struct tui_gen_win_info)
4540         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4541         New method.
4542
4543 2019-06-25  Tom Tromey  <tom@tromey.com>
4544
4545         * tui/tui.c (tui_rl_other_window, tui_enable)
4546         (tui_is_window_visible, tui_get_command_dimension): Update.
4547         * tui/tui-winsource.c (tui_update_source_window_as_is)
4548         (tui_clear_source_content, tui_erase_source_content)
4549         (tui_show_source_line, tui_source_window_base::refill)
4550         (tui_source_window_base::do_scroll_horizontal)
4551         (tui_source_window_base::set_is_exec_point_at)
4552         (tui_update_breakpoint_info, tui_set_exec_info_content)
4553         (tui_alloc_source_buffer, tui_line_is_displayed)
4554         (tui_addr_is_displayed): Update.
4555         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4556         (tui_check_and_display_highlight_if_needed)
4557         (tui_win_info::make_visible, tui_win_info::refresh)
4558         (tui_refresh_all): Update.
4559         * tui/tui-windata.c (tui_first_data_item_displayed)
4560         (tui_delete_data_content_windows, tui_erase_data_content)
4561         (tui_display_all_data, tui_data_window::refresh_all)
4562         (tui_check_data_values): Update.
4563         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4564         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4565         (tui_win_info::backward_scroll, tui_refresh_all_win)
4566         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4567         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4568         (tui_source_window_base::set_new_height)
4569         (tui_data_window::set_new_height)
4570         (make_invisible_and_set_new_height)
4571         (make_visible_with_new_height, new_height_ok)
4572         (parse_scrolling_args): Update.
4573         * tui/tui-stack.c (tui_show_frame_info): Update.
4574         * tui/tui-source.c (tui_set_source_content)
4575         (tui_set_source_content_nil, tui_source_is_displayed)
4576         (tui_source_window::do_scroll_vertical): Update.
4577         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4578         (tui_display_registers_from, tui_display_reg_element_at_line)
4579         (tui_check_register_values, tui_reg_command): Update.
4580         * tui/tui-layout.c (tui_default_win_height)
4581         (show_source_disasm_command, show_data, init_and_make_win)
4582         (show_source_or_disasm_and_command): Update.
4583         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4584         (tui_redisplay_readline, tui_mld_flush)
4585         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4586         (tui_getc): Update.
4587         * tui/tui-disasm.c (tui_set_disassem_content)
4588         (tui_disasm_window::do_scroll_vertical): Update.
4589         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4590         Now virtual.
4591         (struct tui_win_info): Derive from tui_gen_win_info.
4592         <~tui_win_info>: Mark as override.
4593         <generic>: Remove member.
4594         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4595         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4596         (~tui_data_window, ~tui_win_info)
4597         (tui_free_all_source_wins_content): Update.
4598         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4599
4600 2019-06-25  Tom Tromey  <tom@tromey.com>
4601
4602         * tui/tui-layout.c (init_and_make_win): Use new.
4603         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4604         destructor, initializers.
4605         (tui_alloc_generic_win_info): Don't declare.
4606         * tui/tui-data.c (_locator): Add argument to constructor.
4607         (source_win, disasm_win): New globals.
4608         (exec_info): Remove.
4609         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4610         Update.
4611         (tui_alloc_generic_win_info): Remove.
4612         (init_content_element): Use new.
4613         (tui_win_info::tui_win_info): Update.
4614         (free_content_elements) <case DATA_WIN>: Use delete.
4615
4616 2019-06-25  Tom Tromey  <tom@tromey.com>
4617
4618         * tui/tui-wingeneral.c (tui_refresh_win): Update.
4619         * tui/tui-windata.c (tui_first_data_item_displayed)
4620         (tui_delete_data_content_windows): Update.
4621         * tui/tui-win.c (tui_data_window::set_new_height): Update.
4622         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4623         (tui_display_registers_from, tui_check_register_values): Update.
4624         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
4625         pointer.
4626         * tui/tui-data.c (init_content_element): Update.  Allocate the new
4627         window.
4628         (tui_free_data_content): Update.
4629         (free_content_elements) <case DATA_WIN>: Free the window.
4630
4631 2019-06-25  Tom Tromey  <tom@tromey.com>
4632
4633         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
4634         Update.
4635         * tui/tui-layout.c (make_command_window)
4636         (show_source_disasm_command, show_data, init_and_make_win)
4637         (show_source_or_disasm_and_command): Update.
4638         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
4639         method.
4640         <can_highight, is_highlighted>: Now bool.
4641         (tui_set_win_highlight): Don't declare.
4642         * tui/tui-data.c (tui_set_win_highlight): Remove.
4643
4644 2019-06-25  Tom Tromey  <tom@tromey.com>
4645
4646         * tui/tui-wingeneral.c (make_visible): Remove check of window
4647         type.
4648
4649 2019-06-25  Tom Tromey  <tom@tromey.com>
4650
4651         * tui/tui-win.c (tui_win_info::max_height)
4652         (tui_cmd_window::max_height): New methods.
4653         (new_height_ok): Call max_height.
4654         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
4655         <max_height>: New method.
4656
4657 2019-06-25  Tom Tromey  <tom@tromey.com>
4658
4659         * tui/tui-win.c (tui_source_window_base::set_new_height)
4660         (tui_data_window::set_new_height): New methods.
4661         (make_invisible_and_set_new_height): Call set_new_height method.
4662         * tui/tui-data.h (struct tui_win_info)
4663         (struct tui_source_window_base, struct tui_data_window)
4664         <set_new_height>: New method.
4665
4666 2019-06-25  Tom Tromey  <tom@tromey.com>
4667
4668         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
4669         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
4670         tui_refresh_data_win.
4671         * tui/tui-win.c (tui_source_window_base::refresh_all): New
4672         method.
4673         (tui_refresh_all_win): Call the refresh_all method.
4674         (tui_set_focus): Likewise.
4675         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
4676         (struct tui_source_window_base, struct tui_data_window) <refresh>:
4677         Likewise.
4678
4679 2019-06-25  Tom Tromey  <tom@tromey.com>
4680
4681         * tui/tui-winsource.h (tui_refill_source_window)
4682         (tui_set_is_exec_point_at): Don't declare.
4683         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4684         (tui_source_window_base::refill): Rename from
4685         tui_refill_source_window.
4686         (tui_source_window_base::do_scroll_horizontal): Update.
4687         (tui_source_window_base::set_is_exec_point_at): Rename from
4688         tui_set_is_exec_point_at.
4689         (tui_update_all_breakpoint_info): Update.
4690         * tui/tui-stack.c (tui_show_frame_info): Update.
4691         * tui/tui-layout.c (show_data): Add cast.
4692         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
4693         * tui/tui-data.h (struct tui_source_window_base) <refill,
4694         set_is_exec_point_at>: New methods.
4695         (tui_source_windows, tui_add_to_source_windows): Update types.
4696         (tui_add_to_source_windows): Remove redundant declaration.
4697         * tui/tui-data.c (source_windows): Store tui_source_window_base.
4698         (tui_source_windows): Change return type.
4699         (tui_clear_source_windows_detail): Update.
4700         (tui_add_to_source_windows): Change type of parameter.
4701         (tui_free_all_source_wins_content): Update.
4702
4703 2019-06-25  Tom Tromey  <tom@tromey.com>
4704
4705         * tui/tui-wingeneral.c (tui_win_info::refresh)
4706         (tui_source_window_base::refresh): New methods.
4707         (tui_refresh_all): Call the refresh method.
4708         * tui/tui-data.h (struct tui_win_info)
4709         (struct tui_source_window_base) <refresh>: New method.
4710
4711 2019-06-25  Tom Tromey  <tom@tromey.com>
4712
4713         * tui/tui.h (tui_is_window_visible): Return bool.
4714         * tui/tui.c (tui_is_window_visible): Return bool.
4715         * tui/tui-wingeneral.c (tui_make_window, make_visible)
4716         (tui_make_visible, tui_make_invisible)
4717         (tui_win_info::make_visible)
4718         (tui_source_window_base::make_visible, make_all_visible)
4719         (tui_make_all_visible, tui_make_all_invisible): Update.
4720         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
4721         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
4722         bool.
4723         (struct tui_win_info, struct tui_source_window_base)
4724         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
4725         * tui/tui-data.c (tui_init_generic_part): Update.
4726
4727 2019-06-25  Tom Tromey  <tom@tromey.com>
4728
4729         * tui/tui-wingeneral.c (tui_win_info::make_visible)
4730         (tui_source_window_base::make_visible): New methods.
4731         (make_all_visible): Make method call.
4732         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
4733         (struct tui_source_window_base, struct tui_cmd_window): Override
4734         make_visible.
4735         (tui_win_is_source_type): Don't declare.
4736         * tui/tui-data.c (tui_win_is_source_type): Remove.
4737
4738 2019-06-25  Tom Tromey  <tom@tromey.com>
4739
4740         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
4741         NULL check.
4742
4743 2019-06-25  Tom Tromey  <tom@tromey.com>
4744
4745         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
4746         Inline constructor.  Add initializers for members.
4747         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
4748         constructors; now inline in class.
4749
4750 2019-06-25  Tom Tromey  <tom@tromey.com>
4751
4752         * tui/tui-regs.c (tui_show_registers): Update.
4753         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
4754         bool.
4755         * tui/tui-data.c (tui_data_window::clear_detail)
4756         (tui_data_window): Update.
4757
4758 2019-06-25  Tom Tromey  <tom@tromey.com>
4759
4760         * tui/tui-windata.c (tui_display_all_data)
4761         (tui_display_data_from_line, tui_display_data_from)
4762         (tui_check_data_values, tui_data_window::do_scroll_vertical):
4763         Update.
4764         * tui/tui-regs.c (tui_last_regs_line_no)
4765         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4766         (tui_show_registers, tui_show_register_group)
4767         (tui_display_registers_from, tui_display_reg_element_at_line)
4768         (tui_display_registers_from_line, tui_check_register_values)
4769         (tui_reg_next, tui_reg_prev): Update.
4770         * tui/tui-layout.c (tui_set_layout, show_data): Update.
4771         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
4772         tui_data_window.
4773         (struct tui_win_info) <detail>: Remove.  Add new fields from
4774         tui_data_info.
4775         (TUI_DATA_WIN): Add cast.
4776         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
4777         (~tui_data_window): Simplify.
4778
4779 2019-06-25  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-layout.c (show_source_disasm_command)
4782         (show_source_or_disasm_and_command): Update.
4783         * tui/tui-io.c (update_cmdwin_start_line)
4784         (tui_redisplay_readline): Update.
4785         * tui/tui-data.h (struct tui_command_info): Remove.
4786         (struct tui_win_info) <detail>: Remove command_info member.
4787         (struct tui_data_window) <start_line>: New member, from
4788         tui_command_info.
4789         (TUI_CMD_WIN): Add casts.
4790
4791 2019-06-25  Tom Tromey  <tom@tromey.com>
4792
4793         * tui/tui-winsource.c (tui_update_source_window)
4794         (tui_refill_source_window)
4795         (tui_source_window_base::do_scroll_horizontal)
4796         (tui_update_breakpoint_info, tui_set_exec_info_content)
4797         (tui_show_exec_info_content, tui_erase_exec_info_content)
4798         (tui_clear_exec_info_content): Update.
4799         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
4800         Update.
4801         * tui/tui-win.c (make_invisible_and_set_new_height)
4802         (make_visible_with_new_height): Update.
4803         * tui/tui-source.c (tui_set_source_content)
4804         (tui_show_symtab_source): Update.
4805         * tui/tui-layout.c (extract_display_start_addr)
4806         (show_source_disasm_command, show_data)
4807         (make_source_or_disasm_window)
4808         (show_source_or_disasm_and_command): Update.
4809         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
4810         (tui_disasm_window::do_scroll_vertical): Remove shadowing
4811         "gdbarch".
4812         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
4813         to tui_source_window_base.
4814         (struct tui_win_info) <detail>: Remove source_info member.
4815         (struct tui_source_window_base) <has_locator>: Inline.
4816         Move contents from tui_source_info; rename has_locator member to
4817         m_has_locator.
4818         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
4819         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
4820         header file.
4821         (tui_source_window_base::clear_detail, ~tui_source_window_base):
4822         Simplify.
4823         (tui_free_all_source_wins_content): Cast to
4824         tui_source_window_base.
4825
4826 2019-06-25  Tom Tromey  <tom@tromey.com>
4827
4828         * tui/tui-win.c (make_invisible_and_set_new_height)
4829         (make_visible_with_new_height): Call has_locator method.
4830         * tui/tui-layout.c (show_source_disasm_command, show_data)
4831         (show_source_or_disasm_and_command): Update for bool change.
4832         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
4833         (tui_win_info) <has_locator>: New method.
4834         (struct tui_source_window_base) <has_locator>: New method.
4835         (tui_win_has_locator): Don't declare.
4836         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
4837         from tui_win_has_locator.
4838         (tui_source_window_base): Use false, not FALSE.
4839
4840 2019-06-25  Tom Tromey  <tom@tromey.com>
4841
4842         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
4843         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
4844         clear_detail method directly.
4845         (tui_clear_win_detail): Remove.
4846
4847 2019-06-25  Tom Tromey  <tom@tromey.com>
4848
4849         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
4850         "this", not TUI_DISASM_WIN.
4851
4852 2019-06-25  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
4855         declare.
4856         * tui/tui-winsource.c
4857         (tui_source_window_base::do_scroll_horizontal): Rename from
4858         tui_horizontal_source_scroll.
4859         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
4860         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
4861         from tui_vertical_data_scroll.
4862         * tui/tui-win.h (tui_scroll): Don't declare.
4863         * tui/tui-win.c (tui_win_info::forward_scroll)
4864         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4865         (tui_win_info::right_scroll): Rename and update.
4866         (tui_scroll_forward_command, tui_scroll_backward_command)
4867         (tui_scroll_left_command, tui_scroll_right_command): Update.
4868         (tui_scroll): Remove.
4869         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
4870         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
4871         from tui_vertical_source_scroll.
4872         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
4873         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
4874         from tui_vertical_disassem_scroll.
4875         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
4876         do_scroll_horizontal>: New methods.
4877         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
4878         Likewise.
4879         (struct tui_source_window_base): Add do_scroll_horizontal.
4880         (struct tui_source_window, struct tui_disasm_window): Add
4881         do_scroll_vertical.
4882         (struct tui_data_window, struct tui_cmd_window): Add
4883         do_scroll_horizontal and do_scroll_vertical.
4884         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
4885
4886 2019-06-25  Tom Tromey  <tom@tromey.com>
4887
4888         * tui/tui-data.h (struct tui_source_window_base): New struct.
4889         (struct tui_source_window): Derive from tui_source_window_base.
4890         (struct tui_disasm_window): New struct.
4891         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
4892         from tui_source_window::clear_detail.
4893         (tui_source_window_base): Rename from tui_source_window.
4894         (~tui_source_window_base): Rename from ~tui_source_window.
4895         (tui_alloc_win_info): Create a tui_disasm_window.
4896
4897 2019-06-25  Tom Tromey  <tom@tromey.com>
4898
4899         * tui/tui-data.h (struct tui_source_window)
4900         (struct tui_data_window): Declare destructors.
4901         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
4902         destructors.
4903         (tui_win_info): Simplify.
4904
4905 2019-06-25  Tom Tromey  <tom@tromey.com>
4906
4907         * tui/tui-winsource.c (tui_display_main)
4908         (tui_update_source_windows_with_addr)
4909         (tui_update_all_breakpoint_info): Update.
4910         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4911         (new_height_ok, parse_scrolling_args): Update.
4912         * tui/tui-stack.c (tui_show_frame_info): Update.
4913         * tui/tui-data.h (struct tui_list): Remove.
4914         (tui_source_windows): Return a reference to a std::vector.
4915         * tui/tui-data.c (source_windows): Now a std::vector.
4916         (tui_source_windows): Change return type.
4917         (tui_clear_source_windows): Rewrite.
4918         (tui_clear_source_windows_detail, tui_add_to_source_windows)
4919         (tui_free_all_source_wins_content): Rewrite.
4920
4921 2019-06-25  Tom Tromey  <tom@tromey.com>
4922
4923         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
4924         (struct tui_data_window, struct tui_cmd_window): Declare
4925         clear_detail method.
4926         * tui/tui-data.c (tui_source_window::clear_detail)
4927         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
4928         methods.
4929         (tui_clear_win_detail): Simplify.
4930
4931 2019-06-25  Tom Tromey  <tom@tromey.com>
4932
4933         * tui/tui-layout.c (make_source_window, make_disasm_window)
4934         (make_source_or_disasm_window): Remove win_info_ptr parameter.
4935         Return the new window.
4936         (show_source_disasm_command, show_data)
4937         (show_source_or_disasm_and_command): Update.
4938
4939 2019-06-25  Tom Tromey  <tom@tromey.com>
4940
4941         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
4942         parameter.  Return the new window.
4943         (show_source_disasm_command): Update and remove NULL check.
4944         (show_source_or_disasm_and_command): Update.
4945
4946 2019-06-25  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
4949
4950 2019-06-25  Tom Tromey  <tom@tromey.com>
4951
4952         * tui/tui-data.h (struct tui_win_info): Make constructor
4953         protected.  Make destructor virtual.  Add initializers.
4954         (tui_source_window, tui_data_window, tui_cmd_window): New
4955         classes.
4956         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
4957         constructor.  Add "type" parameter.
4958         (tui_source_window, tui_data_window, tui_cmd_window): New
4959         constructors.
4960         (tui_alloc_win_info): Instantiate the appropriate subclass.
4961
4962 2019-06-25  Tom Tromey  <tom@tromey.com>
4963
4964         * tui/tui-win.c (tui_resize_all): Use delete.
4965         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
4966         destructor.
4967         (tui_free_window): Don't declare.
4968         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
4969         Update.
4970
4971 2019-06-25  Tom Tromey  <tom@tromey.com>
4972
4973         * tui/tui-data.h (struct tui_win_info): Add constructor.
4974         * tui/tui-data.c (tui_alloc_win_info): Use new.
4975         (tui_free_window): Use delete.
4976
4977 2019-06-22  Tom Tromey  <tom@tromey.com>
4978
4979         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
4980         declare.
4981         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
4982
4983 2019-06-22  Tom Tromey  <tom@tromey.com>
4984
4985         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
4986         declare.
4987         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
4988
4989 2019-06-22  Tom de Vries  <tdevries@suse.de>
4990
4991         * dwarf2read.c (create_addrmap_from_aranges)
4992         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
4993         instead of '%zu'.
4994
4995 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
4996
4997         * dwarf2read.h (dwarf2_section_info_def): Remove.
4998         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
4999         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5000         std::vector<dwarf2_section_info>.
5001         (struct dwo_file) <~dwo_file>: Remove.
5002         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5003         types field.
5004         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5005         (dwarf2_read_debug_names): Likewise.
5006         (create_debug_types_hash_table): Change parameter type to
5007         array_view, adjust code accordingly.
5008         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5009         (partial_die_info::fixup): Likewise.
5010         (determine_prefix): Likewise.
5011         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5012
5013 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5014
5015         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5016         gdb_bfd_ref_ptr.
5017         <~dwo_file>: Remove call to gdb_bfd_unref.
5018         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5019         gdb_bfd_ref_ptr::get.
5020
5021 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5022
5023         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5024         type to htab_up.
5025         * dwarf2read.c (struct dwo_file): Initialize fields.
5026         <~dwo_file>: New.
5027         (free_dwo_file): Remove, move content to ~dwo_file.
5028         (struct dwo_file_deleter): Remove.
5029         (dwo_file_up>: Remove custom deleter.
5030         (free_dwo_files): Remove.
5031         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5032         dwo_files.
5033         (process_skeletonless_type_units): Call unique_ptr::get.
5034         (allocate_dwo_file_hash_table): Add deleter to created hash
5035         table.  Change return type to htab_up.
5036         (lookup_dwo_file_slot): Don't memset dwo_file, call
5037         unique_ptr::get.
5038         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5039         (create_dwo_unit_in_dwp_v2): Likewise.
5040         (open_and_init_dwo_file): Likewise.
5041         (free_dwo_file_from_slot): Remove.
5042
5043 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5044
5045         * dwarf2read.h (struct dwarf2_section_info) <readin,
5046         is_virtual>: Change type to bool.
5047         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5048         true instead of 1.
5049
5050 2019-06-19  Tom Tromey  <tom@tromey.com>
5051
5052         * tui/tui-data.h (tui_init_content_element): Don't declare.
5053
5054 2019-06-19  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-data.h (tui_init_win_info): Don't declare.
5057
5058 2019-06-19  Tom de Vries  <tdevries@suse.de>
5059
5060         * dwarf2read.h (abstract_to_concrete): Change type to
5061         std::unordered_map<sect_offset, std::vector<sect_offset>,
5062         gdb::hash_enum<sect_offset>>.
5063
5064 2019-06-19  Tom Tromey  <tromey@adacore.com>
5065
5066         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5067         EVAL_AVOID_SIDE_EFFECTS specially.
5068
5069 2019-06-19  Tom Tromey  <tromey@adacore.com>
5070
5071         * source-cache.c (highlighter): New global.
5072         (source_cache::get_source_lines): Create a highlighter on demand.
5073
5074 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * defs.h (deprecated_interactive_hook): Delete declaration.
5077         * interps.c (clear_interpreter_hooks): Remove use of
5078         deprecated_interactive_hook.
5079         * top.c (deprecated_interactive_hook): Delete definition.
5080         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5081
5082 2019-06-18  Tom de Vries  <tdevries@suse.de>
5083
5084         PR gdb/24515
5085         * dwarf2read.h (abstract_to_concrete): Change type from
5086         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5087         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5088         * dwarf2read.c (read_variable): Update.
5089         (dwarf2_fetch_die_loc_sect_off): Update.
5090
5091 2019-06-17  Tom de Vries  <tdevries@suse.de>
5092
5093         PR gdb/24617
5094         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5095         accessing parent[parent_len - 1].
5096
5097 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5098
5099         PR gdb/24364
5100         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5101         call dtrace_process_dof with NULL dof.
5102
5103 2019-06-16  Tom de Vries  <tdevries@suse.de>
5104
5105         PR gdb/24445
5106         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5107
5108 2019-06-16  Tom Tromey  <tom@tromey.com>
5109
5110         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5111         (make_all_visible): Use address of member.
5112
5113 2019-06-16  Tom Tromey  <tom@tromey.com>
5114
5115         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5116         (tui_free_window, free_content, free_content_elements): Remove
5117         unnecessary cast.
5118         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5119         cast.
5120         * tui/tui-regs.c (tui_show_register_group)
5121         (tui_display_registers_from, tui_display_reg_element_at_line):
5122         Remove unnecessary cast.
5123
5124 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5125
5126         * linux-nat.c (normal_mask): Delete.
5127         (_initialize_linux_nat): Don't initialise normal_mask.
5128
5129 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5130
5131         PR gdb/24445
5132         * dwarf-index-write.h (write_psymtabs_to_index): Add
5133         dwz_basename parameter.
5134         * dwarf-index-write.c (write_gdbindex): Move file writing to
5135         write_gdbindex_1.  Change return type void.
5136         (assert_file_size): Move up, remove filename parameter.
5137         (write_gdbindex_1): New function.
5138         (write_debug_names): Change return type to void, call
5139         assert_file_size.
5140         (struct index_wip_file): New struct.
5141         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5142         file logic to index_wip_file.  Write index for dwz file if
5143         needed.
5144         (save_gdb_index_command): Pass basename of dwz file, if present.
5145         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5146         build-id of dwz file, if present.
5147         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5148         (dwarf2_get_dwz_file): Likewise.
5149         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5150         (dwarf2_get_dwz_file): Likewise.
5151
5152 2019-06-16  Tom Tromey  <tom@tromey.com>
5153
5154         * coffread.c (process_coff_symbol): Use xstrdup.
5155         * value.c (create_internalvar): Use xstrdup.
5156
5157 2019-06-16  Tom Tromey  <tom@tromey.com>
5158
5159         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5160         * breakpoint.c (stopin_command, stopat_command)
5161         (until_break_command, decode_location_default): Remove unnecessary
5162         cast.
5163         * utils.c (subset_compare): Remove unnecessary cast.
5164         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5165         cast.
5166         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5167         cast.
5168         * infcmd.c (path_command): Remove unnecessary cast.
5169         * coffread.c (decode_type): Remove unnecessary cast.
5170         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5171         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5172         * tui/tui-stack.c (tui_show_locator_content)
5173         (tui_show_frame_info): Remove unnecessary cast.
5174         * tui/tui-win.c (tui_scroll_forward_command)
5175         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5176         (parse_scrolling_args): Remove unnecessary cast.
5177         * tui/tui-data.c (init_win_info, tui_del_window)
5178         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5179         (free_content_elements): Remove unnecessary cast.
5180         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5181         unnecessary cast.
5182         * tui/tui-source.c (tui_set_source_content)
5183         (tui_vertical_source_scroll): Remove unnecessary cast.
5184         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5185         cast.
5186         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5187         * tui/tui-regs.c (tui_display_registers_from)
5188         (tui_display_register): Remove unnecessary cast.
5189         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5190         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5191         (make_visible): Remove unnecessary cast.
5192         * tui/tui-winsource.c (tui_erase_source_content)
5193         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5194         unnecessary cast.
5195         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5196         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5197         * stabsread.c (read_type, read_array_type, read_range_type):
5198         Remove unnecessary cast.
5199         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5200         (parse_symbol, parse_type, upgrade_type, parse_external)
5201         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5202         unnecessary cast.
5203         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5204
5205 2019-06-16  Tom Tromey  <tom@tromey.com>
5206
5207         * tui/tui-data.c (tui_alloc_generic_win_info)
5208         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5209         checks.
5210
5211 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5212             Andrew Burgess  <andrew.burgess@embecosm.com>
5213
5214         * f-typeprint.c (f_print_type): Don't return early for not
5215         associated or not allocated types.
5216         (f_type_print_varspec_suffix): Add print_rank parameter and print
5217         ranks of array types in case they dangling.
5218         (f_type_print_base): Add print_rank parameter.
5219
5220 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5221
5222         * NEWS: Mention new MI commands.
5223         * break-catch-throw.c (enum exception_event_kind): Move to
5224         breakpoint.h.
5225         (print_mention_exception_catchpoint): Output text as a single
5226         message.
5227         (catch_exception_command_1): Rename to...
5228         (catch_exception_event): ...this, make non-static, update header
5229         command, and change some parameter types.
5230         (catch_catch_command): Update for changes to
5231         catch_exception_command_1.
5232         (catch_throw_command): Likewise.
5233         (catch_rethrow_command): Likewise.
5234         * breakpoint.c (enum exception_event_kind): Delete.
5235         * breakpoint.h (enum exception_event_kind): Moved here from
5236         break-catch-throw.c.
5237         (catch_exception_event): Declare.
5238         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5239         (mi_cmd_catch_throw): New function.
5240         (mi_cmd_catch_rethrow): New function.
5241         (mi_cmd_catch_catch): New function.
5242         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5243         'catch-catch' entries.
5244         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5245         (mi_cmd_catch_rethrow): Declare.
5246         (mi_cmd_catch_catch): Declare.
5247
5248 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5249
5250         * annotate.c (annotate_source_line): Change return type to void,
5251         update implementation to match.
5252         * annotate.h (annotate_source_line): Change return type to void,
5253         update header comment.
5254         * stack.c (print_frame_info): Don't change what frame information
5255         is printed based on whether annotations are on or not.
5256
5257 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5258
5259         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5260         (annotate_source): Make static.
5261         (annotate_source_line): Moved from source.c and renamed from
5262         identify_source_line.  Update the return type.
5263         * annotate.h (annotate_source): Delete declaration.
5264         (annotate_source_line): Declaration moved from source.h, and
5265         renamed from identify_source_line.  Return type updated.
5266         * source.c (identify_source_line): Moved to annotate.c and renamed
5267         to annotate_source_line.
5268         (info_line_command): Remove check of annotation_level.
5269         * source.h (identify_source_line): Move declaration to annotate.h
5270         and rename to annotate_source_line.
5271         * stack.c: Add 'annotate.h' include.
5272         (print_frame_info): Remove check of annotation_level before
5273         calling annotate_source_line.
5274
5275 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5276
5277         * source-cache.c (source_cache::get_plain_source_lines): Use
5278         open_source_file_with_line_charpos instead of just
5279         open_source_file, remove call to find_source_lines.
5280         (source_cache::get_source_lines): Likewise.
5281         * source.c (find_source_lines): Make static.
5282         (get_filename_and_charpos): Renamed into...
5283         (open_source_file_with_line_charpos): ..this along with changes to
5284         return a scoped_fd, and some other minor clean ups.
5285         (identify_source_line): Use open_source_file_with_line_charpos.
5286         (search_command_helper): Use open_source_file_with_line_charpos
5287         instead of just open_source_file, remove call to
5288         find_source_lines.
5289         * source.h (open_source_file_with_line_charpos): Declare new
5290         function.
5291         (find_source_lines): Delete declaration.
5292
5293 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5294
5295         * source.c (get_filename_and_charpos): Remove fullname
5296         parameter.
5297         (identify_source_line): Update call to get_filename_and_charpos.
5298
5299 2019-06-14  Tom Tromey  <tromey@adacore.com>
5300
5301         PR gdb/24502:
5302         * ui-style.h (skip_ansi_escape): Update comment.
5303         * ui-file.h (class no_terminal_escape_file): New class.
5304         * ui-file.c (no_terminal_escape_file::write)
5305         (no_terminal_escape_file::puts): New methods.
5306         * cli/cli-logging.c (handle_redirections): Use
5307         no_terminal_escape_file.
5308
5309 2019-06-14  Tom Tromey  <tromey@adacore.com>
5310
5311         * NEWS: Move convenience variable news above Python news.
5312
5313 2019-06-14  Tom Tromey  <tom@tromey.com>
5314
5315         * gnulib: Move directory to top-level.
5316         * configure.ac: Don't configure gnulib.
5317         * configure: Rebuild.
5318         * common/common-defs.h: Use new path to gnulib.
5319         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5320         (GNULIB_H): Remove.
5321         (INCGNU): Look in new gnulib location.
5322         (HFILES_NO_SRCDIR): Remove gnulib files.
5323         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5324         (generated_files): Remove GNULIB_H.
5325         ($(LIBGNU), all-lib): Remove targets.
5326         (distclean): Don't mention GNULIB_BUILDDIR.
5327         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5328
5329 2019-06-14  Tom Tromey  <tromey@adacore.com>
5330
5331         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5332         Warn if symbol file does not provide any symbols.
5333
5334 2019-06-14  Tom Tromey  <tromey@adacore.com>
5335
5336         * source.c (find_and_open_source): Respect basenames_may_differ.
5337
5338 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5339
5340         * annotate.c (annotate_breakpoints_invalid): Make use of
5341         scoped_restore_terminal_state.
5342         (annotate_frames_invalid): Likewise.
5343
5344 2019-06-14  Tom Tromey  <tromey@adacore.com>
5345
5346         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5347         allow assignment to an internalvar.
5348
5349 2019-06-14  Tom Tromey  <tromey@adacore.com>
5350
5351         * ada-lex.l: Allow "_" in attribute names.
5352
5353 2019-06-14  Tom Tromey  <tromey@adacore.com>
5354
5355         PR gdb/24653:
5356         * regcache.c (registers_changed): Don't call alloca.
5357         * top.c (execute_command): Don't call alloca.
5358
5359 2019-06-13  Pedro Alves  <palves@redhat.com>
5360
5361         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5362         'expression'.  When parsing an expression, error out if there's
5363         junk after "unlimited".
5364         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5365         (do_set_command): Adjust calls to is_unlimited_literal.
5366
5367 2019-06-13  Pedro Alves  <palves@redhat.com>
5368
5369         * compile/compile.c (make_compile_options_def_group): Add braces
5370         around array_view initializer.
5371         * thread.c (make_thread_apply_all_options_def_group)
5372         (make_thread_apply_all_options_def_group): Likewise.
5373
5374 2019-06-13  Pedro Alves  <palves@redhat.com>
5375
5376         * NEWS (New commands): Mention "maint test-options
5377         require-delimiter", "maint test-options unknown-is-error", "maint
5378         test-options unknown-is-operand" and "maint show
5379         test-options-completion-result".
5380         (New command options, command completion): New section.
5381         (Completion improvements): New section.
5382         Mention that you can abbreviate "unlimited".
5383
5384 2019-06-13  Pedro Alves  <palves@redhat.com>
5385
5386         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5387         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5388         * unittests/cli-utils-selftests.c (test_parse_flags)
5389         (test_parse_flags_qcs): Delete.
5390         (test_cli_utils): Don't call deleted functions.
5391
5392 2019-06-13  Pedro Alves  <palves@redhat.com>
5393
5394         * thread.c: Include "cli/cli-option.h".
5395         (tp_array_compar_ascending): Global.
5396         (tp_array_compar): Delete function.
5397         (tp_array_compar_ascending, tp_array_compar_descending): New
5398         functions.
5399         (ascending_option_def, qcs_flag_option_def)
5400         (thr_qcs_flags_option_defs)
5401         (make_thread_apply_all_options_def_group)
5402         (make_thread_apply_options_def_group): New.
5403         (thread_apply_all_command): Use gdb::option::process_options.
5404         (thread_apply_command_completer)
5405         (thread_apply_all_command_completer): New.
5406         (thread_apply_command): Use gdb::option::process_options.
5407         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5408         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5409         to generate help text of "thread apply".  Adjust "taas"'s help.
5410         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5411         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5412
5413 2019-06-13  Pedro Alves  <palves@redhat.com>
5414
5415         * thread.c (thread_apply_command): Check for invalid TID with
5416         isdigit instead of !isalpha.
5417
5418 2019-06-13  Pedro Alves  <palves@redhat.com>
5419
5420         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5421         (validate_flags_qcs): New.
5422         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5423         (validate_flags_qcs): Declare.
5424         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5425         (make_frame_apply_options_def_group): New.
5426         (frame_apply_command_count): Process options with
5427         gdb::option::process_options.
5428         (frame_apply_completer): New.
5429         (frame_apply_level_completer, frame_apply_all_completer)
5430         (frame_apply_completer): New.
5431         (_initialize_stack): Update help of "frame apply", "frame apply
5432         level", "frame apply all" and "faas" to mention supported options
5433         and install command completers.
5434         * stack.h (frame_apply_all_completer): Declare.
5435         * thread.c: Include "stack.h".
5436         (tfaas_command): Add "--".
5437         (_initialize_thread): Update help "tfaas" to mention supported
5438         options and install command completer.
5439
5440 2019-06-13  Pedro Alves  <palves@redhat.com>
5441
5442         * completer.c (complete_nested_command_line): New.
5443         (gdb_completion_word_break_characters_throw): Add assertion.
5444         * completer.h (complete_nested_command_line): Declare.
5445
5446 2019-06-13  Pedro Alves  <palves@redhat.com>
5447
5448         * stack.c (parse_backtrace_qualifiers): New.
5449         (backtrace_command): Use it.
5450         (backtrace_command_completer): Complete on qualifiers.
5451
5452 2019-06-13  Pedro Alves  <palves@redhat.com>
5453
5454         * frame.c: Include "cli/cli-option.h.
5455         (user_set_backtrace_options): New.
5456         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5457         Delete.
5458         (get_prev_frame): Adjust.
5459         (boolean_option_def, uinteger_option_def)
5460         (set_backtrace_option_defs): New.
5461         (_initialize_frame): Adjust and use
5462         gdb::option::add_setshow_cmds_for_options to install "set
5463         backtrace past-main" and "set backtrace past-entry".
5464         * frame.h: Include "cli/cli-option.h".
5465         (struct frame_print_options): Forward declare.
5466         (print_frame_arguments_all, print_frame_arguments_scalars)
5467         (print_frame_arguments_none): Declare.
5468         (print_entry_values): Delete declaration.
5469         (struct frame_print_options, user_frame_print_options): New.
5470         (struct set_backtrace_options): New.
5471         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5472         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5473         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5474         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5475         (list_args_or_locals): Add frame_print_options parameter.
5476         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5477         * python/py-framefilter.c (enumerate_args): Pass down
5478         USER_FRAME_PRINT_OPTIONS.
5479         * stack.c: Include "cli/cli-option.h".
5480         (print_frame_arguments_all, print_frame_arguments_scalars)
5481         (print_frame_arguments_none): Declare.
5482         (print_raw_frame_arguments, print_entry_values): Delete.
5483         (user_frame_print_options): New.
5484         (boolean_option_def, enum_option_def, frame_print_option_defs):
5485         New.
5486         (struct backtrace_cmd_options): New.
5487         (bt_flag_option_def): New.
5488         (backtrace_command_option_defs): New.
5489         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5490         (print_frame_arg, read_frame_arg, print_frame_args)
5491         (print_frame_info, print_frame): Add frame_print_options parameter
5492         and use it.
5493         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5494         (backtrace_command_1): Add frame_print_options and
5495         backtrace_cmd_options parameters and use them.
5496         (make_backtrace_options_def_group): New.
5497         (backtrace_command): Process command options with
5498         gdb::option::process_options.
5499         (backtrace_command_completer): New.
5500         (_initialize_stack): Extend "backtrace"'s help to mention
5501         supported options.  Install completer for "backtrace".
5502         Install some settings commands with add_setshow_cmds_for_options.
5503
5504 2019-06-13  Pedro Alves  <palves@redhat.com>
5505
5506         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5507         and that "set/show print raw frame-arguments" are now deprecated.
5508
5509         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5510         command.
5511         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5512         * stack.c (_initialize_stack): Install "set/show print
5513         raw-frame-arguments", and deprecate "set/show print raw
5514         frame-arguments".
5515         * valprint.c (_initialize_valprint): Deprecate "set/show print
5516         raw".
5517
5518 2019-06-13  Pedro Alves  <palves@redhat.com>
5519
5520         * compile/compile.c (struct compile_options): New.
5521         (compile_flag_option_def, compile_command_option_defs)
5522         (make_compile_options_def_group): New.
5523         (compile_file_command): Handle options with
5524         gdb::option::process_options.
5525         (compile_file_command_completer): New function.
5526         (compile_code_command): Handle options with
5527         gdb::option::process_options.
5528         (compile_code_command_completer): New function.
5529         (_initialize_compiler): Install completers for "compile code" and
5530         "compile file".  Mention available options in "compile code" and
5531         "compile code"'s help.
5532         * completer.c (advance_to_completion_word): New, factored out from
5533         ...
5534         (advance_to_expression_complete_word_point): ... this.
5535         (advance_to_filename_complete_word_point): New.
5536         * completer.h (advance_to_filename_complete_word_point): New
5537         declaration.
5538
5539 2019-06-13  Pedro Alves  <palves@redhat.com>
5540
5541         * compile/compile.c: Include "cli/cli-option.h".
5542         (compile_print_value): Scope data pointer is now a
5543         value_print_options pointer; adjust.
5544         (compile_print_command): Process options.  Scope data pointer is
5545         now a value_print_options pointer; adjust.
5546         (_initialize_compile): Update "compile print"'s help to include
5547         supported options.  Install a completer for "compile print".
5548         * cp-valprint.c (show_vtblprint, show_objectprint)
5549         (show_static_field_print): Delete.
5550         (_initialize_cp_valprint): Don't install "set print
5551         static-members", "set print vtbl", "set print object" here.
5552         * printcmd.c: Include "cli/cli-option.h" and
5553         "common/gdb_optional.h".
5554         (print_command_parse_format): Rework to fill in a
5555         value_print_options instead of a format_data.
5556         (print_value): Change parameter type from format_data pointer to
5557         value_print_options reference.  Adjust.
5558         (print_command_1): Process options.  Adjust to pass down a
5559         value_print_options.
5560         (print_command_completer): New.
5561         (_initialize_printcmd): Install print_command_completer as
5562         handle_brkchars completer for the "print" command.  Update
5563         "print"'s help to include supported options.
5564         * valprint.c: Include "cli/cli-option.h".
5565         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5566         here from cp-valprint.c.
5567         (boolean_option_def, uinteger_option_def)
5568         (value_print_option_defs, make_value_print_options_def_group):
5569         New.  Use gdb::option::add_setshow_cmds_for_options to install
5570         "set print elements", "set print null-stop", "set print repeats",
5571         "set print pretty", "set print union", "set print array", "set
5572         print address", "set print symbol", "set print array-indexes".
5573         * valprint.h: Include <string> and "cli/cli-option.h".
5574         (make_value_print_options_def_group): Declare.
5575         (print_value): Change parameter type from format_data pointer to
5576         value_print_options reference.
5577         (print_command_completer): Declare.
5578
5579 2019-06-13  Pedro Alves  <palves@redhat.com>
5580
5581         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5582         (COMMON_SFILES): Add maint-test-settings.c.
5583         * cli/cli-decode.c (boolean_enums): New global, factored out from
5584         ...
5585         (add_setshow_boolean_cmd): ... here.
5586         * cli/cli-decode.h (boolean_enums): Declare.
5587         * cli/cli-option.c: New file.
5588         * cli/cli-option.h: New file.
5589         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5590         factored out from ...
5591         (parse_cli_boolean_value(const char *)): ... this.
5592         (is_unlimited_literal): Change parameter type to pointer to
5593         pointer.  Adjust and advance ARG pointer.
5594         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5595         (parse_cli_var_enum): New, factored out from ...
5596         (do_set_command): ... this.  Adjust.
5597         * cli/cli-setshow.h (parse_cli_boolean_value)
5598         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5599         (parse_cli_var_enum): Declare.
5600         * cli/cli-utils.c: Include "cli/cli-option.h".
5601         (get_ulongest): New.
5602         * cli/cli-utils.h (get_ulongest): Declare.
5603         (check_for_argument): New overloads.
5604         * maint-test-options.c: New file.
5605
5606 2019-06-13  Pedro Alves  <palves@redhat.com>
5607
5608         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5609         parse a range if "-" is at the end of the string.
5610
5611 2019-06-13  Pedro Alves  <palves@redhat.com>
5612
5613         * cli/cli-setshow.c (parse_auto_binary_operation)
5614         (parse_cli_boolean_value): Don't allow "o".
5615
5616 2019-06-13  Pedro Alves  <palves@redhat.com>
5617
5618         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
5619         * NEWS: Mention maint test-settings KIND.
5620         * maint-test-settings.c: New file.
5621
5622 2019-06-13  Pedro Alves  <palves@redhat.com>
5623
5624         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
5625         completer.
5626         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
5627         "set" completers.
5628
5629 2019-06-13  Pedro Alves  <palves@redhat.com>
5630
5631         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
5632         after item.
5633
5634 2019-06-13  Pedro Alves  <palves@redhat.com>
5635
5636         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
5637
5638 2019-06-13  Pedro Alves <palves@redhat.com>
5639
5640         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
5641         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
5642         call.
5643         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
5644         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
5645         calls.
5646         (check_for_argument): Skip spaces after argument.
5647
5648 2019-06-13  Pedro Alves  <palves@redhat.com>
5649
5650         * thread.c (thread_apply_command): Adjust TID parsing.
5651         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
5652         detected before end of string.
5653         (tid_is_in_list): Error out if LIST is invalid.
5654
5655 2019-06-13  Pedro Alves  <palves@redhat.com>
5656
5657         * completer.c (complete_line_internal_1): Rewind completion word
5658         point.
5659         (completion_tracker::advance_custom_word_point_by): Change
5660         parameter type to int.
5661         * completer.h (completion_tracker::advance_custom_word_point_by):
5662         Likewise.
5663
5664 2019-06-13  Pedro Alves  <palves@redhat.com>
5665
5666         * completer.c (advance_to_completion_word): Handle delimiters.
5667
5668 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
5669
5670         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
5671
5672 2019-06-11  Tom Tromey  <tom@tromey.com>
5673
5674         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
5675         (xmalloc_failed): Move to alloc.c.
5676         * alloc.c: New file.
5677         * Makefile.in (COMMON_SFILES): Add alloc.c.
5678
5679 2019-06-11  Tom Tromey  <tom@tromey.com>
5680
5681         * nat/linux-waitpid.c: Don't include server.h.
5682         (linux_debug): Remove.
5683         (my_waitpid): Update.
5684
5685 2019-06-11  Tom Tromey  <tromey@adacore.com>
5686
5687         * infcall.c (_initialize_infcall): Remove trailing newline from
5688         help.
5689         * user-regs.c (_initialize_user_regs): Remove trailing newline
5690         from help.
5691         * typeprint.c (_initialize_typeprint): Remove trailing newline
5692         from help.
5693         * reverse.c (_initialize_reverse): Remove trailing newlines from
5694         help.
5695         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
5696         from help.
5697         * language.c (add_set_language_command): Remove trailing newline
5698         from help.
5699         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
5700         help.
5701         * disasm.c (_initialize_disasm): Remove trailing newline from
5702         help.
5703         * top.c (init_main): Remove trailing newline from help.
5704         * interps.c (_initialize_interpreter): Remove trailing newline
5705         from help.
5706         * btrace.c (_initialize_btrace): Remove trailing newlines from
5707         help.
5708         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
5709         from help.
5710         * python/python.c (_initialize_python): Remove trailing newline
5711         from help.
5712         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
5713         help.
5714         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
5715         from help.  Reformat some text.
5716         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
5717         from help.
5718         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
5719         newline from help.
5720
5721 2019-06-11  Tom Tromey  <tromey@adacore.com>
5722
5723         * darwin-nat.c (darwin_decode_exception_message)
5724         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
5725
5726 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
5727
5728         * valops.c (value_slice): Check for not allocated or not
5729         associated values.
5730
5731 2019-06-10  Tom de Vries  <tdevries@suse.de>
5732
5733         PR gdb/24618
5734         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
5735         sure an empty slot (defined by a 32-bit zero pair) is recognized as
5736         invalid.
5737
5738 2019-06-10  Tom de Vries  <tdevries@suse.de>
5739
5740         PR gdb/24611
5741         * linespec.c (linespec_lexer_lex_string): Remove incorrect
5742         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
5743
5744 2019-06-10  Tom de Vries  <tdevries@suse.de>
5745
5746         PR symtab/24545
5747         * symtab.c (struct demangled_name_entry): Add language field.
5748         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
5749         static minimal symbol".  Set and use language field.
5750
5751 2019-06-10  Tom Tromey  <tromey@adacore.com>
5752
5753         * ada-lang.c (_initialize_ada_language): Update help text.
5754
5755 2019-06-10  Tom Tromey  <tromey@adacore.com>
5756
5757         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
5758         with a newline.
5759         * guile/guile.c (handle_boot_error): Don't end warning with a
5760         newline.
5761         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
5762         warning with a newline.
5763         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
5764         newline.
5765         (s12z_frame_cache): Likewise.
5766         * dwarf-index-cache.c (index_cache::store): Don't end warning with
5767         a newline.
5768         * solib-svr4.c (disable_probes_interface): Don't end warning with
5769         a newline.
5770         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
5771         newline.
5772         * python/python.c (do_finish_initialization): Don't end warning
5773         with a newline.
5774
5775 2019-06-10  Tom Tromey  <tom@tromey.com>
5776
5777         * python/py-breakpoint.c (gdbpy_breakpoint_created)
5778         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
5779         gdbpy_enter.
5780
5781 2019-06-10  Tom Tromey  <tromey@adacore.com>
5782
5783         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
5784         data.
5785         (elf_new_init): Don't call stabsread_new_init.
5786         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
5787         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
5788         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
5789
5790 2019-06-10  Tom de Vries  <tdevries@suse.de>
5791
5792         PR symtab/16264
5793         PR symtab/24517
5794         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
5795
5796 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
5797
5798         * source.c (find_and_open_source): Also rewrite relative file
5799         names.
5800
5801 2019-04-26  Amos Bird  <amosbird@gmail.com>
5802
5803         * annotate.c (annotate_thread_exited): Add "thread-exited"
5804         annotation.
5805
5806 2019-06-06  Tom Tromey  <tromey@adacore.com>
5807
5808         * maint.h (class scoped_command_stats): Use
5809         DISABLE_COPY_AND_ASSIGN.
5810         <print_time>: New method.
5811         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
5812         print_time.
5813         (scoped_command_stats::print_time): New method.
5814
5815 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
5816
5817         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
5818         instructions of lengths 6 or 8 bytes.
5819
5820 2019-06-04  Pedro Alves  <palves@redhat.com>
5821
5822         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
5823
5824         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
5825         * breakpoint.c (condition_completer): Likewise.
5826         * cli/cli-dump.c (scan_expression): Likewise.
5827         * common/filestuff.c (mkdir_recursive): Likewise.
5828         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
5829         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
5830         (gdb_abspath): Likewise.
5831         * compile/compile-cplus-types.c
5832         (compile_cplus_instance::decl_name): Likewise.
5833         * completer.c (complete_explicit_location):
5834         (signal_completer, reg_or_group_completer_1): Likewise.
5835         * cp-support.c (cp_remove_params_if_any): Likewise.
5836         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
5837         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
5838         * infcmd.c (strip_bg_char): Likewise.
5839         * linespec.c (copy_token_string): Likewise.
5840         * mi/mi-main.c (output_cores): Likewise.
5841         * psymtab.c (psymtab_search_name):
5842         * symfile.c (test_set_ext_lang_command): Likewise.
5843         * target.c (target_fileio_read_stralloc): Likewise.
5844         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
5845         * value.c (complete_internalvar): Likewise.
5846
5847 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
5848
5849         Add objfile property to gdb.Type.
5850         * NEWS: Mention Python API addition.
5851         * python/py-type.c (typy_get_objfile): New method.
5852
5853 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5854
5855         * NEWS: Mention the new set|show style [title|highlight].
5856         Mention changes to "show style", "help" and "apropos".
5857
5858 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5859
5860         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
5861         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
5862         instead of print_help_for_command.
5863         (print_doc_of_command): New function.
5864         (help_list): Add 'apropos -v word' suggestion.
5865         (print_help_for_command): Style the command name using title style.
5866         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
5867         (_initialize_cli_cmds): Describe -v in apropos_command help.
5868
5869 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5870
5871         * cli/cli-style.h (cli_style_option): Add name in constructor,
5872         add m_name class member, add constructor with intensity,
5873         add name class function.
5874         (cli_style_option::add_setshow_commands): Remove name argument.
5875         (highlight_style, title_style): New styles.
5876         * cli/cli-style.c (do_show): New function that shows a style
5877         characteristic styling the style name with itself.
5878         (set_style_name): New function.
5879         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
5880         Update all callers according to the changes in cli/cli-style.h.
5881         * utils.h (fputs_highlighted): New function.
5882         * utils.c (fputs_highlighted): Likewise.
5883
5884 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5885
5886         * NEWS: Mention new pipe command and new convenience variables.
5887
5888 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5889
5890         * cli/cli-cmds.c (pipe_command): New function.
5891         (_initialize_cli_cmds): Call add_com for pipe_command.
5892         Define | as an alias for pipe.
5893         (exit_status_set_internal_vars): New function.
5894         (shell_escape): Call exit_status_set_internal_vars.
5895         cli/cli-decode.c (find_command_name_length): Recognize | as
5896         a single character command.
5897
5898 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5899
5900         * gdbcmd.h (execute_command_to_ui_file): New declaration.
5901         top.c (execute_command_to_ui_file): New function, mostly a copy
5902         of execute_command_to_string.
5903         (execute_command_to_string): Implement by calling
5904         execute_command_to_ui_file.
5905
5906 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5907
5908         * top.h (saved_command_line): Remove declaration.
5909         * top.c (previous_saved_command_line, previous_repeat_arguments):
5910         New variables.
5911         (saved_command_line): Make static, define together with other
5912         'repeat variables'.
5913         (dont_repeat): Clear repeat_arguments.
5914         (repeat_previous, get_saved_command_line, save_command_line):
5915         New functions.
5916         (gdb_init): Initialize saved_command_line
5917         and previous_saved_command_line.
5918         * main.c (captured_main_1): Remove saved_command_line initialization.
5919         * event-top.c (handle_line_of_input): Update to use
5920         the new 'repeat' related functions instead of direct access to
5921         saved_command_line.
5922         * command.h (repeat_previous, get_saved_command_line,
5923         save_command_line): New declarations.
5924         (dont_repeat): Add comment.
5925
5926 2019-05-30  Tom Tromey  <tromey@adacore.com>
5927
5928         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
5929         Fix comment.
5930         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
5931
5932 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
5933
5934         PR cli/24587
5935         * completer.c (complete): Initialize variable word.
5936
5937 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
5938
5939         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
5940         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
5941         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
5942         'body' is NULL to the outter 'if', protecting the '!is_define'
5943         situation as well.
5944
5945 2019-05-29  Tom Tromey  <tromey@adacore.com>
5946
5947         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
5948         (dwarf_unknown): New function.
5949         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
5950         (dwarf_type_encoding_name): Use dwarf_unknown.
5951
5952 2019-05-29  Tom Tromey  <tromey@adacore.com>
5953
5954         PR c++/20020:
5955         * cp-valprint.c (cp_print_value_fields): Call
5956         cp_print_static_field inside "try".
5957
5958 2019-05-29  Tom Tromey  <tromey@adacore.com>
5959
5960         * inflow.c (struct terminal_info): Add default operator=.
5961         * configure: Rebuild.
5962         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
5963         -Wdeprecated-copy-dtor, -Wredundant-move.
5964
5965 2019-05-29  Tom Tromey  <tromey@adacore.com>
5966
5967         * NEWS: Add entry.
5968         * infcmd.c (print_return_value_1): Handle finish_print
5969         option.
5970         (show_print_finish): New function.
5971         (_initialize_infcmd): Add "set/show print finish" commands.
5972         * valprint.c (user_print_options): Initialize new member.
5973         * valprint.h (struct value_print_options) <finish_print>: New
5974         member.
5975
5976 2019-05-28  Tom Tromey  <tromey@adacore.com>
5977
5978         * ada-lang.c (ada_remove_Xbn_suffix)
5979         (find_old_style_renaming_symbol)
5980         (parse_old_style_renaming): Remove.
5981         (ada_find_renaming_symbol): Don't call
5982         find_old_style_renaming_symbol.
5983         (ada_is_renaming_symbol): Rename from
5984         ada_find_renaming_symbol.  Remove "block" parameter.  Return
5985         bool.  Now static.
5986         (ada_read_var_value): Update and simplify.
5987         * ada-exp.y (write_var_or_type): Remove old code.
5988
5989 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
5990
5991         * event-top.c: Remove include comment.
5992         * inflow.c (class scoped_ignore_sigttou): Move from here...
5993         * inflow.h (class scoped_ignore_sigttou): ...to here.
5994         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
5995         * top.c:  Remove include comment.
5996
5997 2019-05-27  Tom Tromey  <tom@tromey.com>
5998
5999         * NEWS: Fix typo.
6000
6001 2019-05-22  Tom Tromey  <tromey@adacore.com>
6002
6003         * target.c (target_follow_exec): Constify parameter.
6004         * target-delegates.c: Rebuild.
6005         * remote.c (remote_target::follow_exec): Constify parameter.
6006         * infrun.c (follow_exec): Constify parameter.
6007         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6008         (target_follow_exec): Likewise.
6009
6010 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6011
6012         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6013         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6014
6015 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6016
6017         * NEWS: Add debugredirect and testsuite sections.
6018
6019 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6020
6021         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6022         target descriptions using exclusively floating point register name
6023         aliases.
6024
6025 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6026
6027         PR gdb/18644:
6028         * f-lang.c (build_fortran_types): Handle the case where
6029         gdbarch_floatformat_for_type returns a nullptr.
6030
6031 2019-05-21  Tom de Vries  <tdevries@suse.de>
6032
6033         PR cli/24587
6034         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6035
6036 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6037
6038         PR gdb/18644:
6039         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6040         16-byte floats.
6041         * i386-tdep.c (i386_floatformat_for_type): Use
6042         floatformats_ia64_quad for the 16-byte floating point component
6043         within a fortran 32-byte complex number.
6044
6045 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6046
6047         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6048         delete default constructor.
6049         (find_partial_die): Update to return const struct.
6050         (partial_die_parent_scope): Move variable declaration into scope
6051         of its use and change its type to auto.
6052         (guess_partial_die_structure_name): Likewise.
6053         (partial_die_info::fixup): Likewise.
6054
6055 2019-05-17  Tom Tromey  <tromey@adacore.com>
6056
6057         * source.c (find_and_open_source): Remove cast.
6058
6059 2019-05-17  Tom Tromey  <tromey@adacore.com>
6060
6061         * annotate.c (annotate_source): Make "filename" const.
6062         * annotate.h (annotate_source): Use const.
6063
6064 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6065
6066         * disasm.c (set_disassembler_options): Send errors to stderr.
6067
6068 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6069
6070         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6071         (cli_interp_base::set_logging): Check debug_redirect.
6072         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6073         * cli/cli-logging.c (debug_redirect): Add static variable.
6074         (pop_output_files): Add default param.
6075         (handle_redirections): Print debug setting.
6076         (show_logging_command): Likewise.
6077         (_initialize_cli_logging): Add debugredirect command.
6078         * interps.c (current_interp_set_logging): Add debug_redirect
6079         parameter.
6080         * interps.h (set_logging): Add debug_redirect parameter.
6081         (current_interp_set_logging): Likewise.
6082         * mi/mi-common.h: Likewise.
6083         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6084
6085 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6086             Tom Tromey  <tromey@adacore.com>
6087
6088         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6089         directly.
6090         * cli/cli-interp.h (make_logging_output): Remove declaration.
6091         * cli/cli-logging.c (make_logging_output): Remove function.
6092         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6093         directly.
6094         * ui-file.c (tee_file::tee_file): Remove bools.
6095         (tee_file::~tee_file): Remove deletes.
6096         * ui-file.h (tee_file): Remove bools.
6097
6098 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6099
6100         * mi/mi-cmds.h (mi_cmd_complete): New function.
6101         * mi/mi-main.c (mi_cmd_complete): Likewise.
6102         * mi/mi-cmds.c: Define new MI command -complete.
6103         * NEWS: Mention new -complete command.
6104
6105 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6106
6107         * completer.h (complete): New function.
6108         * completer.c (complete): Likewise.
6109         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6110         function defined in completer.h.
6111
6112 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6113
6114         * MAINTAINERS (Write After Approval): Add myself.
6115
6116 2019-05-17  Tom de Vries  <tdevries@suse.de>
6117
6118         PR gdb/24094
6119         * dwarf2read.c (struct cu_partial_die_info): New struct.
6120         (find_partial_die): Return cu_partial_die_info.
6121         (partial_die_parent_scope, guess_partial_die_structure_name)
6122         (partial_die_info::fixup): Handle new return type of find_partial_die.
6123
6124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6125
6126         PR breakpoints/24541
6127         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6128         "std::string", simplifying the algorithm.
6129
6130 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6131
6132         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6133         (stap_static_probe_ops::get_probes): Likewise.
6134
6135 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6136
6137         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6138         '-')" and "else if".
6139         (stap_parse_single_operand): Join checks for
6140         "gdbarch_stap_parse_special_token_p" and
6141         "gdbarch_stap_parse_special_token" in the same "if" statement.
6142         Invert check when verifying for operation on register
6143         displacement.
6144
6145 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6146
6147         * stap-probe.c (stap_get_opcode): Update comment.
6148         (stap_get_expected_argument_type): Likewise.
6149         (handle_stap_probe): Likewise.
6150
6151 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6152
6153         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6154         return type to 'bool'.  Adjust comment.  Use 'bool' when
6155         appropriate.
6156         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6157         * stap-probe.c (stap_parse_argument_1): Likewise.
6158         (stap_is_operator): Likewise.
6159         (stap_is_generic_prefix): Likewise.
6160         (stap_is_register_prefix): Likewise.
6161         (stap_is_register_indirection_prefix): Likewise.
6162         (stap_is_integer_prefix): Likewise.
6163         (stap_generic_check_suffix): Likewise.
6164         (stap_check_integer_suffix): Likewise.
6165         (stap_check_register_suffix): Likewise.
6166         (stap_check_register_indirection_suffix): Likewise.
6167         (stap_parse_register_operand): Likewise.
6168         (stap_parse_single_operand): Likewise.
6169         (stap_parse_argument_1): Likewise.
6170         (stap_probe::get_argument_count): Likewise.
6171         (stap_is_operator): Likewise.
6172
6173 2019-05-16  Tom Tromey  <tromey@adacore.com>
6174
6175         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6176         keyword to foreach.
6177
6178 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6179
6180         * linux-thread-db.c (try_thread_db_load_1): Change return type
6181         to bool.
6182         (try_thread_db_load): Likewise.
6183         (try_thread_db_load_from_pdir_1): Likewise.
6184         (try_thread_db_load_from_pdir): Likewise.
6185         (try_thread_db_load_from_sdir): Likewise.
6186         (try_thread_db_load_from_dir): Likewise.
6187         (thread_db_load_search): Likewise.
6188         (has_libpthread): Likewise.
6189         (thread_db_load): Likewise.
6190
6191 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6192
6193         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6194         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6195         NULL, and complain/return if that's the case.
6196
6197 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6198
6199         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6200         (advance, posn, abstract_read_memory): New functions.
6201         [struct mem_read_abstraction]: New struct.
6202         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6203
6204 2019-05-14  Tom Tromey  <tromey@adacore.com>
6205
6206         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6207         value is not lval_memory.
6208
6209 2019-05-14  Tom Tromey  <tromey@adacore.com>
6210
6211         * solib.c (info_sharedlibrary_command): Style the file name.
6212
6213 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6214
6215         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6216         (aarch64_vnv_type): Likewise.
6217         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6218         * common/tdesc.c: Likewise.
6219         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6220         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6221         * features/aarch64-fpu.xml: Add ieee half view.
6222         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6223         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6224         * gdbtypes.h (struct builtin_type): Likewise.
6225         (struct objfile_type): Likewise.
6226
6227 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6228
6229         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6230         typo.
6231         * location.h (string_to_event_location): Likewise.
6232
6233 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6234
6235         GDB 8.3 released.
6236
6237 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6238
6239         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6240         New variable declaration.
6241         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6242         New variable.
6243         (print_one_breakpoint): Use ui_out::test_flags and new global
6244         variable to compute use_fixed_output.
6245         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6246         Remove.
6247         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6248         (mi_multi_location_breakpoint_output_fixed): Remove.
6249         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6250         new variable.
6251         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6252         fix_multi_location_breakpoint_output flag if version >= 3.
6253         * ui-out.h (enum ui_out_flag)
6254         <fix_multi_location_breakpoint_output>: New enumerator.
6255
6256 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6257
6258         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6259
6260 2019-05-10  Tom Tromey  <tromey@adacore.com>
6261
6262         * ada-lang.c (catch_ada_completer): New function.
6263         (_initialize_ada_language): Use it.
6264
6265 2019-05-10  Tom Tromey  <tromey@adacore.com>
6266
6267         * thread.c (print_thread_info): Make "requested_threads" const.
6268         * gdbthread.h (print_thread_info): Make "requested_threads"
6269         const.
6270         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6271         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6272
6273 2019-05-08  Tom Tromey  <tom@tromey.com>
6274
6275         * gdbtypes.c (objfile_type_data): Change type.
6276         (objfile_type, _initialize_gdbtypes): Update.
6277
6278 2019-05-08  Tom Tromey  <tom@tromey.com>
6279
6280         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6281         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6282         (_initialize_dwarf2_frame): Update.
6283
6284 2019-05-08  Tom Tromey  <tom@tromey.com>
6285
6286         * objc-lang.c (objc_objfile_data): Change type.
6287         (find_methods): Update.
6288         (_initialize_objc_lang): Remove.
6289
6290 2019-05-08  Tom Tromey  <tom@tromey.com>
6291
6292         * stabsread.c (rs6000_builtin_type_data): Change type.
6293         (rs6000_builtin_type, _initialize_stabsread): Update.
6294
6295 2019-05-08  Tom Tromey  <tom@tromey.com>
6296
6297         * mips-tdep.c (mips_pdr_data): Remove.
6298         (_initialize_mips_tdep): Update.
6299
6300 2019-05-08  Tom Tromey  <tom@tromey.com>
6301
6302         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6303         (hppa_init_objfile_priv_data, read_unwind_info)
6304         (find_unwind_entry, _initialize_hppa_tdep): Update.
6305
6306 2019-05-08  Tom Tromey  <tom@tromey.com>
6307
6308         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6309         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6310         on obstack.
6311         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6312
6313 2019-05-08  Tom Tromey  <tom@tromey.com>
6314
6315         * mdebugread.c (basic_type_data): Change type.
6316         (basic_type, _initialize_mdebugread): Update.
6317
6318 2019-05-08  Tom Tromey  <tom@tromey.com>
6319
6320         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6321
6322 2019-05-08  Tom Tromey  <tom@tromey.com>
6323
6324         * nto-tdep.c (nto_inferior_data_reg): Change type.
6325         (nto_inferior_data): Update.
6326         (nto_inferior_data_cleanup, nto_new_inferior_data)
6327         (_initialize_nto_tdep): Remove.
6328         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6329
6330 2019-05-08  Tom Tromey  <tom@tromey.com>
6331
6332         * ada-lang.c (struct ada_inferior_data): Add initializers.
6333         (ada_inferior_data): Change type.
6334         (ada_inferior_data_cleanup): Remove.
6335         (get_ada_inferior_data, ada_inferior_exit)
6336         (struct ada_pspace_data): Add initializers, destructor.
6337         (ada_pspace_data_handle): Change type.
6338         (get_ada_pspace_data): Update.
6339         (ada_pspace_data_cleanup): Remove.
6340
6341 2019-05-08  Tom Tromey  <tom@tromey.com>
6342
6343         * coffread.c (struct coff_symfile_info): Add initializers.
6344         (coff_objfile_data_key): Move lower.  Change type.
6345         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6346         Update.
6347         (coff_free_info): Remove.
6348
6349 2019-05-08  Tom Tromey  <tom@tromey.com>
6350
6351         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6352         (fbsd_pspace_data_handle): Move lower.  Change type.
6353         (get_fbsd_pspace_data): Update.
6354         (fbsd_pspace_data_cleanup): Remove.
6355         (_initialize_fbsd_tdep): Update.
6356
6357 2019-05-08  Tom Tromey  <tom@tromey.com>
6358
6359         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6360         (get_ada_tasks_pspace_data): Update.
6361         (ada_tasks_pspace_data_cleanup): Remove.
6362         (_initialize_tasks): Update.
6363         (ada_tasks_inferior_data_handle): Change type.
6364         (get_ada_tasks_inferior_data): Update.
6365         (ada_tasks_inferior_data_cleanup): Remove.
6366         (struct ada_tasks_pspace_data): Add initializers.
6367
6368 2019-05-08  Tom Tromey  <tom@tromey.com>
6369
6370         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6371         * symfile-debug.c (debug_sym_get_probes): Change type.
6372         * stap-probe.c (handle_stap_probe):
6373         (stap_static_probe_ops::get_probes): Change type.
6374         * probe.h (class static_probe_ops) <get_probes>: Change type.
6375         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6376         (parse_probes_in_pspace): Update.
6377         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6378         Update.
6379         (any_static_probe_ops::get_probes): Change type.
6380         * elfread.c (elfread_data): New typedef.
6381         (probe_key): Change type.
6382         (elf_get_probes): Likewise.  Update.
6383         (probe_key_free): Remove.
6384         (_initialize_elfread): Update.
6385         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6386         Change type.
6387         (dtrace_process_dof_probe, dtrace_process_dof)
6388         (dtrace_static_probe_ops::get_probe): Change type.
6389
6390 2019-05-08  Tom Tromey  <tom@tromey.com>
6391
6392         * xcoffread.c (struct xcoff_symfile_info): Rename from
6393         coff_symfile_info.  Add initializers.
6394         (xcoff_objfile_data_key): Move lower.  Change type.
6395         (XCOFF_DATA): Rewrite.
6396         (xcoff_free_info): Remove.
6397         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6398         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6399         (xcoff_initial_scan): Update.
6400
6401 2019-05-08  Tom Tromey  <tom@tromey.com>
6402
6403         * solib-svr4.c (struct svr4_info): Add initializers and
6404         destructor.
6405         <probes_table>: Now an htab_up.
6406         (solib_svr4_pspace_data): Change type.
6407         (free_probes_table): Simplify.
6408         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6409         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6410         (probes_table_remove_objfile_probes, register_solib_event_probe)
6411         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6412         (_initialize_svr4_solib): Update.
6413
6414 2019-05-08  Tom Tromey  <tom@tromey.com>
6415
6416         * remote.c (remote_pspace_data): Change type.
6417         (remote_pspace_data_cleanup): Remove.
6418         (get_remote_exec_file, set_pspace_remote_exec_file)
6419         (_initialize_remote): Update.
6420
6421 2019-05-08  Tom Tromey  <tom@tromey.com>
6422
6423         * breakpoint.c (breakpoint_objfile_key): Change type.
6424         (get_breakpoint_objfile_data): Update.
6425         (free_breakpoint_objfile_data): Remove.
6426         (_initialize_breakpoint): Update.
6427
6428 2019-05-08  Tom Tromey  <tom@tromey.com>
6429
6430         * linux-tdep.c (struct linux_info): Add initializers.
6431         (linux_inferior_data): Move.  Change type.
6432         (invalidate_linux_cache_inf): Update.
6433         (linux_inferior_data_cleanup): Remove.
6434         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6435
6436 2019-05-08  Tom Tromey  <tom@tromey.com>
6437
6438         * auxv.c (auxv_inferior_data): Move.  Change type.
6439         (auxv_inferior_data_cleanup): Remove.
6440         (invalidate_auxv_cache_inf): Rewrite.
6441         (get_auxv_inferior_data, _initialize_auxv): Update.
6442
6443 2019-05-08  Tom Tromey  <tom@tromey.com>
6444
6445         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6446         (symfile_debug_objfile_data_key): Change type.
6447         (symfile_debug_installed, debug_qf_has_symbols)
6448         (debug_qf_find_last_source_symtab)
6449         (debug_qf_forget_cached_source_info)
6450         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6451         (debug_qf_print_stats, debug_qf_dump)
6452         (debug_qf_expand_symtabs_for_function)
6453         (debug_qf_expand_all_symtabs)
6454         (debug_qf_expand_symtabs_with_fullname)
6455         (debug_qf_map_matching_symbols)
6456         (debug_qf_expand_symtabs_matching)
6457         (debug_qf_find_pc_sect_compunit_symtab)
6458         (debug_qf_map_symbol_filenames)
6459         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6460         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6461         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6462         (debug_sym_read_linetable, debug_sym_relocate): Update.
6463         (symfile_debug_free_objfile): Remove.
6464         (install_symfile_debug_logging, _initialize_symfile_debug):
6465         Update.
6466
6467 2019-05-08  Tom Tromey  <tom@tromey.com>
6468
6469         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6470         allocate_on_obstack.
6471         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6472         (get_dwarf2_per_objfile): Update.
6473         (set_dwarf2_per_objfile): Remove.
6474         (dwarf2_has_info, dwarf2_get_section_info): Update.
6475         (dwarf2_free_objfile): Remove.
6476         (_initialize_dwarf2_read): Update.
6477
6478 2019-05-08  Tom Tromey  <tom@tromey.com>
6479
6480         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6481         initializers.
6482         <unsupported_script_warning_printed,
6483         script_not_found_warning_printed>: Now bool.
6484         (auto_load_pspace_data): Change type.
6485         (~auto_load_pspace_info): Rename from
6486         auto_load_pspace_data_cleanup.
6487         (get_auto_load_pspace_data, init_loaded_scripts_info)
6488         (clear_section_scripts, maybe_print_unsupported_script_warning)
6489         (maybe_print_script_not_found_warning, _initialize_auto_load):
6490         Update.
6491
6492 2019-05-08  Tom Tromey  <tom@tromey.com>
6493
6494         * objfiles.c (objfile_pspace_info): Add destructor and
6495         initializers.
6496         (objfiles_pspace_data): Change type.
6497         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6498         (get_objfile_pspace_data): Update.
6499         (objfiles_bfd_data): Change type.
6500         (get_objfile_bfd_data): Update.
6501         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6502
6503 2019-05-08  Tom Tromey  <tom@tromey.com>
6504
6505         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6506         Change type.
6507         (get_catch_syscall_inferior_data): Update.
6508         (catch_syscall_inferior_data_cleanup): Remove.
6509         (_initialize_break_catch_syscall): Update.
6510
6511 2019-05-08  Tom Tromey  <tom@tromey.com>
6512
6513         * inflow.c (struct terminal_info): Add destructor and
6514         initializers.
6515         (inflow_inferior_data): Change type.
6516         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6517         (get_inflow_inferior_data, inflow_inferior_exit)
6518         (swap_terminal_info, _initialize_inflow): Update.
6519
6520 2019-05-08  Tom Tromey  <tom@tromey.com>
6521
6522         * target-dcache.c (target_dcache_cleanup): Remove.
6523         (target_dcache_aspace_key): Change type.
6524         (target_dcache_init_p, target_dcache_invalidate)
6525         (target_dcache_get, target_dcache_get_or_init)
6526         (_initialize_target_dcache): Update.
6527         * dcache.h (struct dcache_deleter): New.
6528
6529 2019-05-08  Tom Tromey  <tom@tromey.com>
6530
6531         * symtab.c (struct symbol_cache): Add destructor and
6532         initializers.
6533         (symbol_cache_key): Move.  Change type.
6534         (make_symbol_cache, free_symbol_cache): Remove.
6535         (get_symbol_cache): Update.
6536         (symbol_cache_cleanup): Remove.
6537         (ALL_PSPACES, symbol_cache_flush)
6538         (maintenance_print_symbol_cache)
6539         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6540         Update.
6541
6542 2019-05-08  Tom Tromey  <tom@tromey.com>
6543
6544         * symtab.c (struct main_info): Add destructor and initializers.
6545         (main_progspace_key): Move.  Change type.
6546         (get_main_info): Update.
6547         (main_info_cleanup): Remove.
6548         (_initialize_symtab): Update.
6549
6550 2019-05-08  Tom Tromey  <tom@tromey.com>
6551
6552         * registry.h (DECLARE_REGISTRY): Define the _key class.
6553
6554 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6555
6556         * NEWS: Merge two 'New commands' sections.
6557
6558 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6559
6560         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6561         parameter and use Ada language definition instead.
6562         (ada_val_print_ptr): Remove unused language parameter.
6563         (ada_val_print_num): Remove language parameter and use Ada language
6564         definition instead.
6565         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6566         parameter.
6567         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6568         parameter and use Ada language definition instead.
6569         (ada_val_print_1): Update all ada_val_print_xxx calls.
6570         Remove language parameter.
6571         (ada_val_print): Update ada_val_print_1 call.
6572
6573 2019-05-08  Tom Tromey  <tromey@adacore.com>
6574
6575         * remote.c (remote_hw_watchpoint_limit)
6576         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6577         Now static.
6578
6579 2019-05-08  Tom Tromey  <tromey@adacore.com>
6580
6581         * maint.c (_initialize_maint_cmds): Move initialization code to
6582         remote.c.
6583         (watchdog, show_watchdog): Move to remote.c.
6584         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6585         "watchdog" static.
6586         (_initialize_remote): Move initialization code from maint.c.
6587         * defs.h (watchdog): Don't declare.
6588
6589 2019-05-08  Tom Tromey  <tromey@adacore.com>
6590
6591         * tui/tui-interp.c: Include main.h.
6592         * interps.c: Include main.h.
6593         * main.h (interpreter_p): Declare.
6594         * defs.h (interpreter_p): Don't declare.
6595
6596 2019-05-08  Tom Tromey  <tromey@adacore.com>
6597
6598         * dwarf2loc.c: Include dwarf2read.h.
6599         * defs.h (read_unsigned_leb128): Don't declare.
6600         * dwarf2read.h (read_unsigned_leb128): Declare.
6601
6602 2019-05-08  Tom Tromey  <tromey@adacore.com>
6603
6604         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6605         method.
6606
6607 2019-05-08  Tom Tromey  <tromey@adacore.com>
6608
6609         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6610         when no wrap column is set.
6611
6612 2019-05-08  Tom Tromey  <tromey@adacore.com>
6613
6614         * c-lang.c (c_get_string): Handle non-C-style arrays.
6615
6616 2019-05-08  Tom Tromey  <tromey@adacore.com>
6617
6618         * typeprint.c (print_offset_data::update): Print the bit offset,
6619         not the number of bits remaining.
6620
6621 2019-05-08  Tom Tromey  <tromey@adacore.com>
6622
6623         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
6624         padding at end of comment.
6625
6626 2019-05-08  Tom Tromey  <tromey@adacore.com>
6627
6628         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
6629         Compare main types.
6630
6631 2019-05-06  Tom Tromey  <tom@tromey.com>
6632
6633         * common/scoped_mmap.c: Include common-defs.h.
6634         * common/scoped_mmap.h: Don't include config.h.
6635
6636 2019-05-04  Tom Tromey  <tom@tromey.com>
6637
6638         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
6639         (struct aarch64_call_info): Add initializers.
6640         <si>: Now a std::vector.
6641         (pass_on_stack, aarch64_push_dummy_call): Update.
6642
6643 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
6644             Tom Tromey  <tom@tromey.com>
6645
6646         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
6647         (ppc_threads): Now a std::vector.  Now static.
6648         (hwdebug_find_thread_points_by_tid)
6649         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
6650         Update.
6651
6652 2019-05-04  Tom Tromey  <tom@tromey.com>
6653
6654         * arc-tdep.c (arc_tdesc_init): Return bool.
6655
6656 2019-05-04  Tom Tromey  <tom@tromey.com>
6657
6658         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
6659         Use gdb_assert_not_reached.
6660
6661 2019-05-04  Tom Tromey  <tom@tromey.com>
6662
6663         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
6664         "false".
6665
6666 2019-05-04  Tom Tromey  <tom@tromey.com>
6667
6668         * arc-tdep.c (arc_tdesc_init): Use bool.
6669
6670 2019-05-04  Tom Tromey  <tom@tromey.com>
6671
6672         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
6673
6674 2019-05-04  Tom Tromey  <tom@tromey.com>
6675
6676         * cli/cli-cmds.c (valid_command_p): Return bool.
6677
6678 2019-05-04  Tom Tromey  <tom@tromey.com>
6679
6680         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
6681         * command.h (valid_user_defined_cmd_name_p): Channge return type.
6682
6683 2019-05-04  Raul Tambre  <raul@tambre.ee>
6684
6685         * python/lib/gdb/prompt.py (_ExtendedPrompt)
6686         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
6687         operator for comparison.
6688
6689 2019-05-04  Tom Tromey  <tom@tromey.com>
6690
6691         * psymtab.c (psymbol_name_matches, match_partial_symbol)
6692         (lookup_partial_symbol, print_partial_symbols)
6693         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
6694         (psymbol_compare): Update.
6695         (add_psymbol_to_bcache): Clear the entire psymbol.
6696         (maintenance_check_psymtabs): Update.
6697         * psympriv.h (struct partial_symbol): Don't derive from
6698         general_symbol_info.
6699         <obj_section, unrelocated_address, address,
6700         set_unrelocated_address>: Update.
6701         <ginfo>: New member.
6702         * dwarf-index-write.c (write_psymbols, debug_names::insert)
6703         (debug_names::write_psymbols): Update.
6704
6705 2019-05-04  Tom de Vries  <tdevries@suse.de>
6706
6707         * contrib/cc-with-tweaks.sh: Support -n arg.
6708
6709 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6710
6711         * corelow.c (core_target::detach): Ensure frame cache and
6712         register caches are cleared.
6713         inferior.c (exit_inferior_1): Likewise.
6714
6715 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
6716             Tom Tromey  <tom@tromey.com>
6717
6718         * dictionary.c (collate_pending_symbols_by_language): Remove
6719         "struct" from foreach.
6720         * symtab.c (lookup_global_symbol_from_objfile)
6721         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
6722         foreach.
6723         * ser-tcp.c (net_open): Remove "struct" from foreach.
6724         * objfiles.c (objfile_relocate, objfile_rebase)
6725         (objfile_has_symbols): Remove "struct" from foreach.
6726         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
6727         from foreach.
6728         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
6729         foreach.
6730         * darwin-nat.c (thread_info_from_private_thread_info): Remove
6731         "struct" from foreach.
6732         * ada-lang.c (create_excep_cond_exprs)
6733         (ada_exception_catchpoint_cond_string): Remove "struct" from
6734         foreach.
6735
6736 2019-05-03  Tom Tromey  <tromey@adacore.com>
6737
6738         * ada-exp.y (convert_char_literal): Check suffix of each
6739         enumerator.
6740
6741 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
6742
6743         PR ada/21406:
6744         * ada-exp.y (yywrap): Don't define.
6745         * ada-lex.l (%option): Add noyywrap
6746         (yywrap): Remove.
6747
6748 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
6749
6750         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
6751         _WIN32_WINNT to the XP level, unless already defined to a higher
6752         level.
6753
6754         * unittests/parse-connection-spec-selftests.c:
6755         * ser-tcp.c:
6756         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
6757         override.
6758
6759         * symfile.c (find_separate_debug_file): Remove colon from the
6760         drive spec of DOS/Windows file names of the target, so that the
6761         file name produced from DEBUGDIR and the target's directory will
6762         be valid on DOS/Windows systems.
6763
6764 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
6765
6766         * rust-lang.c (val_print_struct): Handle printing structures
6767         containing strings.
6768
6769 2019-05-02  Tom Tromey  <tromey@adacore.com>
6770
6771         * valarith.c (_initialize_valarith): Remove.
6772
6773 2019-05-01  Tom Tromey  <tromey@adacore.com>
6774
6775         * ada-lang.c (ada_value_primitive_field): Treat more fields as
6776         bitfields.
6777
6778 2019-05-01  Tom Tromey  <tromey@adacore.com>
6779
6780         * ada-lang.c (ada_value_assign): Correctly compute starting offset
6781         for big-endian copies.
6782
6783 2019-04-30  Ali Tamur  <tamur@google.com>
6784         * gdb/dwarf2read.c (read_3_bytes): New declaration.
6785         (read_attribute_value): Added DW_FORM_strx1-4 cases.
6786         (read_3_bytes): New function.
6787
6788 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6789
6790         * windows-nat.c (main_thread_id): Delete.
6791         (handle_output_debug_string): Replace main_thread_id by
6792         current_event.dwThreadId.
6793         (fake_create_process): Likewise.
6794         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
6795         Do not set main_thread_id.
6796         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
6797         current_event.dwThreadId.
6798         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
6799
6800 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
6801
6802         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
6803         Use current_event.dwThreadId instead of main_thread_id.
6804
6805 2019-04-30  Tom Tromey  <tromey@adacore.com>
6806
6807         * ada-lang.c (ada_lookup_simple_minsyms): New function.
6808         (create_excep_cond_exprs): Iterate over program spaces.
6809         (ada_exception_catchpoint_cond_string): Examine all minimal
6810         symbols for exception types.
6811
6812 2019-04-30  Tom Tromey  <tromey@adacore.com>
6813
6814         PR c++/24470:
6815         * dwarf2read.c (process_structure_scope): Handle case where type
6816         has template parameters but no symbol was created.
6817
6818 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6819             Chris January  <chris.january@arm.com>
6820
6821         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
6822         qualifier.
6823         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
6824
6825 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6826
6827         * f-typeprint.c (f_print_type): Update rules for printing
6828         whitespace.
6829         (f_type_print_varspec_suffix): Likewise.
6830
6831 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6832             Chris January  <chris.january@arm.com>
6833
6834         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
6835         function arguments.
6836
6837 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6838
6839         * f-lang.c (build_fortran_types): Change name of void type to
6840         lower case.
6841         * f-typeprint.c (f_type_print_base): Print the name of the void
6842         type, rather than a fixed string.
6843         * f-valprint.c (f_decorations): Use lower case void string.
6844
6845 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6846             Chris January  <chris.january@arm.com>
6847
6848         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
6849         types for Fortran.
6850
6851 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6852             Chris January  <chris.january@arm.com>
6853             David Lecomber  <david.lecomber@arm.com>
6854
6855         * f-exp.y (BINOP_INTRINSIC): New token.
6856         (exp): New parser rule handling BINOP_INTRINSIC.
6857         (f77_keywords): Add new builtin procedures.
6858         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
6859         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6860         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
6861         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6862         (print_unop_subexp_f): New function.
6863         (print_binop_subexp_f): New function.
6864         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6865         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
6866         (dump_subexp_body_f): Likewise.
6867         (operator_check_f): Likewise.
6868         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
6869         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
6870
6871 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6872
6873         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
6874         UNOP_KIND.
6875         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
6876         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
6877         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
6878         (operator_length_f): New fuction.
6879         (print_subexp_f): New function.
6880         (op_name_f): New function.
6881         (dump_subexp_body_f): New function.
6882         (operator_check_f): New function.
6883         (exp_descriptor_f): Replace standard expression handling functions
6884         with new functions.
6885         * gdb/fortran-operator.def: New file.
6886         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
6887         * gdb/std-operator.def: Remove UNOP_KIND.
6888
6889 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
6890
6891         * std-operator.def: Remove unbalanced, stray double quote
6892         character.
6893
6894 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6895             Chris January  <chris.january@arm.com>
6896             Daniel Everett  <daniel.everett@arm.com>
6897             Nick Forrington  <nick.forrington@arm.com>
6898             Richard Bunt  <richard.bunt@arm.com>
6899
6900         * cp-valprint.c (cp_print_value_fields): Allow an additional level
6901         of depth when printing anonymous structs or unions.
6902         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
6903         Don't print either the top-level value, or the children if the
6904         max-depth is exceeded.
6905         (ppscm_print_children): When printing the key of a map, allow one
6906         extra level of depth.
6907         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
6908         print either the top-level value, or the children if the max-depth
6909         is exceeded.
6910         (print_children): When printing the key of a map, allow one extra
6911         level of depth.
6912         * python/py-value.c (valpy_format_string): Add max_depth keyword.
6913         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
6914         (user_print_options): Initialise max_depth field.
6915         (val_print_scalar_or_string_type_p): New function.
6916         (val_print): Check to see if the max depth has been reached.
6917         (val_print_check_max_depth): Define new function.
6918         (show_print_max_depth): New function.
6919         (_initialize_valprint): Add 'print max-depth' option.
6920         * valprint.h (struct value_print_options) <max_depth>: New field.
6921         (val_print_check_max_depth): Declare new function.
6922         * NEWS: Document new feature.
6923
6924 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6925
6926         * ada-lang.c (ada_language_defn): Initialise new field.
6927         * c-lang.c (c_is_string_type_p): New function.
6928         (c_language_defn): Initialise new field.
6929         (cplus_language_defn): Initialise new field.
6930         (asm_language_defn): Initialise new field.
6931         (minimal_language_defn): Initialise new field.
6932         * c-lang.h (c_is_string_type_p): Declare new function.
6933         * d-lang.c (d_language_defn): Initialise new field.
6934         * f-lang.c (f_is_string_type_p): New function.
6935         (f_language_defn): Initialise new field.
6936         * go-lang.c (go_is_string_type_p): New function.
6937         (go_language_defn): Initialise new field.
6938         * language.c (default_is_string_type_p): New function.
6939         (unknown_language_defn): Initialise new field.
6940         (auto_language_defn): Initialise new field.
6941         * language.h (struct language_defn) <la_is_string_type_p>: New
6942         member variable.
6943         (default_is_string_type_p): Declare new function.
6944         * m2-lang.c (m2_language_defn): Initialise new field.
6945         * objc-lang.c (objc_language_defn): Initialise new field.
6946         * opencl-lang.c (opencl_language_defn): Initialise new field.
6947         * p-lang.c (pascal_is_string_type_p): New function.
6948         (pascal_language_defn): Initialise new field.
6949         * rust-lang.c (rust_is_string_type_p): New function.
6950         (rust_language_defn): Initialise new field.
6951
6952 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6953
6954         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
6955         New field.
6956         * ada-lang.c (ada_language_defn): Initialise new field.
6957         * c-lang.c (c_language_defn): Likewise.
6958         (cplus_language_defn): Likewise.
6959         (asm_language_defn): Likewise.
6960         (minimal_language_defn): Likewise.
6961         * d-lang.c (d_language_defn): Likewise.
6962         * f-lang.c (f_language_defn): Likewise.
6963         * go-lang.c (go_language_defn): Likewise.
6964         * language.c (unknown_language_defn): Likewise.
6965         (auto_language_defn): Likewise.
6966         * m2-lang.c (m2_language_defn): Likewise.
6967         * objc-lang.c (objc_language_defn): Likewise.
6968         * opencl-lang.c (opencl_language_defn): Likewise.
6969         * p-lang.c (pascal_language_defn): Likewise.
6970         * rust-lang.c (rust_language_defn): Likewise.
6971
6972 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
6973
6974         * ada-lang.c (ada_is_character_type): Change return type to bool.
6975         (ada_is_string_type): Likewise.
6976         * ada-lang.h (ada_is_character_type): Update declaration
6977         (ada_is_string_type): Likewise.
6978
6979 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6980
6981         Support style in 'frame|thread apply'
6982
6983         * gdbcmd.h (execute_command_to_string): New term_out parameter.
6984         * record.c (record_start, record_stop): Update callers of
6985         execute_command_to_string with false.
6986         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
6987         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
6988         methods.
6989         (class string_file): New constructor with term_out parameter.
6990         Override methods term_out and can_emit_style_escape.  New member
6991         term_out.
6992         (class stdio_file): Override can_emit_style_escape.
6993         (class tee_file): Override term_out and can_emit_style_escape.
6994         * utils.h (can_emit_style_escape): Remove.
6995         * utils.c (can_emit_style_escape): Likewise.
6996         Update all callers of can_emit_style_escape (SOMESTREAM) to
6997         SOMESTREAM->can_emit_style_escape.
6998         * source-cache.c (source_cache::get_source_lines): Likewise.
6999         * stack.c (frame_apply_command_count): Call execute_command_to_string
7000         passing the term_out characteristic of the current gdb_stdout.
7001         * thread.c (thr_try_catch_cmd): Likewise.
7002         * top.c (execute_command_to_string): pass term_out parameter
7003         to construct the string_file for the command output.
7004         * ui-file.c (term_cli_styling): New function (most code moved
7005         from utils.c can_emit_style_escape).
7006         (string_file::string_file, string_file::can_emit_style_escape,
7007         stdio_file::can_emit_style_escape, tee_file::term_out,
7008         tee_file::can_emit_style_escape): New functions.
7009
7010 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7011
7012         * NEWS: Mention the new set|show may-call-functions.
7013         * infcall.c (may_call_functions_p): New variable.
7014         (show_may_call_functions_p): New function.
7015         (call_function_by_hand_dummy): Throws an error if not
7016         may-call-functions.
7017         (_initialize_infcall): Call add_setshow_boolean_cmd for
7018         may-call-functions.
7019
7020 2019-04-25  Keith Seitz  <keiths@redhat.com>
7021
7022         PR c++/24367
7023         * cp-support.c (inspect_type): Don't attempt substitutions
7024         of symbol with the same name.
7025
7026 2019-04-25  Tom Tromey  <tromey@adacore.com>
7027
7028         PR gdb/24475:
7029         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7030         static.
7031
7032 2019-04-25  Tom Tromey  <tromey@adacore.com>
7033
7034         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7035         rvalue reference.
7036         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7037         (gdb_xml_parser::parse): Use std::move.
7038         * python/python-internal.h (gdbpy_convert_exception): Take a const
7039         reference.
7040         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7041         std::move.
7042         * python/py-utils.c (gdbpy_convert_exception): Take a const
7043         reference.
7044         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7045         Use std::move.
7046         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7047         Use std::move.
7048         * mi/mi-main.c (mi_print_exception): Take a const reference.
7049         * main.c (handle_command_errors): Take a const reference.
7050         * linespec.c (parse_linespec): Use std::move.
7051         * infcall.c (run_inferior_call): Use std::move.
7052         (call_function_by_hand_dummy): Use std::move.
7053         * exec.c (try_open_exec_file): Use std::move.
7054         * exceptions.h (exception_print, exception_fprintf)
7055         (exception_print_same): Update.
7056         * exceptions.c (print_exception, exception_print)
7057         (exception_fprintf, exception_print_same): Change parameters to
7058         const reference.
7059         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7060         * common/new-op.c: Use std::move.
7061         * common/common-exceptions.h (struct gdb_exception): Add move
7062         constructor.
7063         (struct gdb_exception_error, struct gdb_exception_quit, struct
7064         gdb_quit_bad_alloc): Change constructor to move constructor.
7065         (throw_exception): Change parameter to rvalue reference.
7066         * common/common-exceptions.c (throw_exception): Take rvalue
7067         reference.
7068         * cli/cli-interp.c (safe_execute_command): Use std::move.
7069         * breakpoint.c (insert_bp_location, location_to_sals): Use
7070         std::move.
7071
7072 2019-04-25  Tom Tromey  <tromey@adacore.com>
7073
7074         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7075         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7076         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7077         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7078         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7079         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7080         guile/scm-value.c: Use unpack.
7081         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7082         gdbscm_gdb_exception.
7083         (gdbscm_throw_gdb_exception): Likewise.
7084         (struct gdbscm_gdb_exception): New.
7085         (unpack): New function.
7086         (gdbscm_wrap): Use unpack.
7087
7088 2019-04-25  Tom Tromey  <tromey@adacore.com>
7089
7090         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7091         (gdb_rl_callback_handler): Use std::move.
7092         * common/common-exceptions.h (struct gdb_exception): Add move
7093         assignment operator.
7094         (throw_exception_sjlj): Change "exception" to const reference.
7095         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7096         (throw_exception_sjlj): Change "exception" to const reference.
7097
7098 2019-04-25  Tom Tromey  <tromey@adacore.com>
7099
7100         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7101         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7102         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7103         Update.
7104         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7105         Update.
7106         * mi/mi-interp.c (mi_interp::exec): Update.
7107         * linespec.c (parse_linespec): Update.
7108         * infcall.c (run_inferior_call): Update.
7109         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7110         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7111         (gdbscm_lookup_global_symbol): Update.
7112         * guile/scm-param.c (gdbscm_parameter_value): Update.
7113         * guile/scm-frame.c (gdbscm_frame_read_register)
7114         (gdbscm_frame_read_var): Update.
7115         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7116         * exec.c (try_open_exec_file): Update.
7117         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7118         (gdb_rl_callback_handler): Update.
7119         * common/common-exceptions.h (exception_none): Don't declare.
7120         * common/common-exceptions.c (exception_none): Don't define.
7121         (struct catcher) <exception>: Update.
7122         * cli/cli-interp.c (safe_execute_command): Update.
7123         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7124
7125 2019-04-25  Ali Tamur  <tamur@google.com>
7126
7127         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7128         (read_attribute_value): Likewise.
7129         (dwarf2_read_addr_index): Update comment.
7130         (read_str_index): Add DW_FORM_strx.
7131         (dwarf2_string_attr): Likewise.
7132         (dwarf2_const_value_attr): Likewise.
7133         (dump_die_shallow): Likewise.
7134         (dwarf2_fetch_constant_bytes): Likewise.
7135         (skip_form_bytes): Likewise.
7136         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7137
7138 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7139
7140         PR corefiles/11608
7141         PR corefiles/18187
7142         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7143         OFFSET.  Verify if current mapping contains an ELF header.
7144         (linux_find_memory_regions_full): Adjust call to
7145         dump_mapping_p.
7146
7147 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7148             Kang Li <kanglictf@gmail.com>
7149
7150         PR gdb/21600
7151
7152         * dwarf2-frame.c (read_initial_length): Be consistent about using
7153         unsigned representation of length.
7154         (decode_frame_entry_1): Likewise.  Check for wraparound of
7155         end pointer as well as buffer overflow.
7156
7157 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7158
7159         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7160         "vq".
7161
7162 2019-04-24  Tom Tromey  <tromey@adacore.com>
7163
7164         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7165
7166 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7167
7168         * s12z-tdep.c (s12z_unwind_pc): Delete.
7169         (s12z_unwind_sp): Delete.
7170         (s12z_gdbarch_init): Don't register deleted functions with
7171         gdbarch.
7172
7173 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7174
7175         * rl78-tdep.c (rl78_unwind_sp): Delete.
7176         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7177
7178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7179
7180         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7181         (xstormy16_unwind_pc): Delete.
7182         (xstormy16_dummy_id): Delete.
7183         (xstormy16_gdbarch_init): Don't register deleted functions with
7184         gdbarch.
7185
7186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7187
7188         * vax-tdep.c (vax_unwind_pc): Delete.
7189         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7190
7191 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7192
7193         * v850-tdep.c (v850_unwind_sp): Delete.
7194         (v850_unwind_pc): Delete.
7195         (v850_dummy_id): Delete.
7196         (v850_gdbarch_init): Don't register deleted functions with
7197         gdbarch.
7198
7199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7200
7201         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7202         (tilegx_unwind_pc): Delete.
7203         (tilegx_unwind_dummy_id): Delete.
7204         (tilegx_gdbarch_init): Don't register deleted functions with
7205         gdbarch.
7206
7207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7208
7209         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7210         (tic6x_dummy_id): Delete.
7211         (tic6x_gdbarch_init): Don't register deleted functions with
7212         gdbarch.
7213
7214 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * sparc-tdep.c (sparc_unwind_pc): Delete.
7217         (sparc32_gdbarch_init): Don't register deleted function with
7218         gdbarch.
7219
7220 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7221
7222         * sh-tdep.c (sh_unwind_sp): Delete.
7223         (sh_unwind_pc): Delete.
7224         (sh_dummy_id): Delete.
7225         (sh_gdbarch_init): Don't register deleted functions with
7226         gdbarch.
7227
7228 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7229
7230         * score-tdep.c (score_unwind_sp): Delete.
7231         (score_unwind_pc): Delete.
7232         (score_dummy_id): Delete.
7233         (score_gdbarch_init): Don't register deleted functions with
7234         gdbarch.
7235
7236 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7237
7238         * rx-tdep.c (rx_unwind_pc): Delete.
7239         (rx_unwind_sp): Delete.
7240         (rx_dummy_id): Delete.
7241         (rx_gdbarch_init): Don't register deleted functions with
7242         gdbarch.  Update comment.
7243
7244 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7245
7246         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7247         (rs6000_dummy_id): Delete.
7248         (rs6000_gdbarch_init): Don't register deleted functions with
7249         gdbarch.
7250
7251 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * or1k-tdep.c (or1k_dummy_id): Delete.
7254         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7255
7256 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7257
7258         * nios2-tdep.c (nios2_dummy_id): Delete.
7259         (nios2_unwind_sp): Delete.
7260         (nios2_gdbarch_init): Don't register deleted functions with
7261         gdbarch.
7262
7263 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7264
7265         * nds32-tdep.c (nds32_dummy_id): Delete.
7266         (nds32_unwind_pc): Delete.
7267         (nds32_unwind_sp): Delete.
7268         (nds32_gdbarch_init): Don't register deleted functions with
7269         gdbarch.
7270
7271 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7272
7273         * msp430-tdep.c (msp430_unwind_pc): Delete.
7274         (msp430_unwind_sp): Delete.
7275         (msp430_dummy_id): Delete.
7276         (msp430_gdbarch_init): Don't register deleted functions with
7277         gdbarch.
7278
7279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7280
7281         * moxie-tdep.c (moxie_unwind_sp): Delete.
7282         (moxie_unwind_pc): Delete.
7283         (moxie_dummy_id): Delete.
7284         (moxie_gdbarch_init): Don't register deleted functions with
7285         gdbarch.
7286
7287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7288
7289         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7290         (mn10300_unwind_pc): Delete.
7291         (mn10300_unwind_sp): Delete.
7292         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7293         mn10300_unwind_sp.
7294         (mn10300_frame_unwind_init): Don't register deleted functions with
7295         gdbarch.
7296
7297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7298
7299         * mep-tdep.c (mep_unwind_pc): Delete.
7300         (mep_unwind_sp): Delete.
7301         (mep_dummy_id): Delete.
7302         (mep_gdbarch_init): Don't register deleted functions with
7303         gdbarch.
7304
7305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7308         (m68hc11_unwind_sp): Delete.
7309         (m68hc11_gdbarch_init): Don't register deleted functions with
7310         gdbarch.
7311
7312 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7313
7314         * m32r-tdep.c (m32r_unwind_sp): Delete.
7315         (m32r_unwind_pc): Delete.
7316         (m32r_dummy_id): Delete.
7317         (m32r_gdbarch_init): Don't register deleted functions with
7318         gdbarch.
7319
7320 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7321
7322         * m32c-tdep.c (m32c_unwind_pc): Delete.
7323         (m32c_unwind_sp): Delete.
7324         (m32c_dummy_id): Delete.
7325         (m32c_gdbarch_init): Don't register deleted functions with
7326         gdbarch.
7327
7328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7329
7330         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7331         (lm32_unwind_pc): Delete.
7332         (lm32_dummy_id): Delete.
7333         (lm32_gdbarch_init): Don't register deleted functions with
7334         gdbarch.
7335
7336 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7337
7338         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7339         (iq2000_unwind_pc): Delete.
7340         (iq2000_dummy_id): Delete.
7341         (iq2000_gdbarch_init): Don't register deleted functions with
7342         gdbarch.
7343
7344 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7345
7346         * nds32-tdep.c (nds32_type_align): Delete.
7347         (nds32_push_dummy_call): Use type_align instead.
7348
7349 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7350
7351         * arm-tdep.c (arm_type_align): Only handle vector override case.
7352         (arm_push_dummy_call): Use type_align.
7353         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7354
7355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7358         case.
7359         (pass_on_stack): Use type_align.
7360         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7361         function.
7362
7363 2019-04-23  Tom Tromey  <tromey@adacore.com>
7364
7365         * dwarf2read.c (line_header::file_name_at): Remove unused
7366         overload.
7367
7368 2019-04-23  Tom de Vries  <tdevries@suse.de>
7369
7370         PR gdb/24438
7371         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7372         invocation.
7373
7374
7375 2019-03-27  Ali Tamur  <tamur@google.com>
7376
7377         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7378         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7379         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7380         (dwarf_expr_context::get_addr_index): Likewise
7381         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7382         (symbol_needs_eval_context::get_addr_index): Likewise
7383         (disassemble_dwarf_expression): Add DW_OP_addrx
7384         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7385         (read_cutu_die_from_dwo): Update comment
7386         (skip_one_die): Add DW_FORM_addrx
7387         (read_attribute_value): Likewise
7388         (var_decode_location): Add DW_OP_addrx
7389         (dwarf2_const_value_attr): Add DW_FORM_addrx
7390         (dump_die_shallow): Likewise
7391         (dwarf2_fetch_constant_bytes): Likewise
7392         (decode_locdesc): Add DW_OP_addrx
7393         (skip_form_bytes): Add DW_FORM_addrx
7394
7395 2019-04-22  Ali Tamur  <tamur@google.com>
7396
7397         * MAINTAINERS (Write After Approval): Add self.
7398
7399 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7400
7401         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7402         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7403         (open_symbol_file_object): Likewise.
7404         (svr4_default_sos): Add info parameter.
7405         (svr4_read_so_list): Likewise.
7406         (svr4_current_sos_direct): Adjust functions calls to pass down
7407         info.
7408         (svr4_current_sos_1): Add info parameter.
7409         (svr4_current_sos): Call get_svr4_info, pass info down to
7410         svr4_current_sos_1.
7411         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7412         get_svr4_info.
7413         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7414         get_svr4_info.
7415         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7416         to get_svr4_info.
7417         (probes_table_remove_objfile_probes): Likewise.
7418         (register_solib_event_probe): Add info parameter.
7419         (solist_update_incremental): Pass info parameter down to
7420         svr4_read_so_list.
7421         (disable_probes_interface): Add info parameter.
7422         (svr4_handle_solib_event): Pass current_program_space to
7423         get_svr4_info.  Adjust disable_probes_interface cleanup.
7424         (svr4_create_probe_breakpoints): Add info parameter, pass it
7425         down to register_solib_event_probe.
7426         (svr4_create_solib_event_breakpoints): Add info parameter,
7427         pass it down to svr4_create_probe_breakpoints.
7428         (enable_break): Pass info down to
7429         svr4_create_solib_event_breakpoints.
7430         (svr4_solib_create_inferior_hook): Pass current_program_space to
7431         get_svr4_info.
7432         (svr4_clear_solib): Likewise.
7433
7434 2019-04-22  Pedro Alves  <palves@redhat.com>
7435
7436         * solib-svr4.c (svr4_free_objfile_observer): New.
7437         (probe_and_action::objfile): New field.
7438         (probes_table_htab_remove_objfile_probes)
7439         (probes_table_remove_objfile_probes): New functions.
7440         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7441         in the new probe_and_action.  Don't store the probe in 'lookup'.
7442         (svr4_create_probe_breakpoints): Pass objfile to
7443         register_solib_event_probe.
7444         (_initialize_svr4_solib): Register a free_objfile observer.
7445
7446 2019-04-19  Tom Tromey  <tom@tromey.com>
7447
7448         * common/queue.h: Remove.
7449
7450 2019-04-19  Tom Tromey  <tom@tromey.com>
7451
7452         * event-loop.c: Don't include "common/queue.h".
7453
7454 2019-04-19  Tom Tromey  <tom@tromey.com>
7455
7456         * remote.c (remote_target): Use delete.
7457         * remote-notif.h: Include <list>, not "common/queue.h".
7458         (notif_client_p): Remove typedef.
7459         (remote_notif_state): Add constructor, destructor, initializer.
7460         <notif_queue>: Now a std::list.
7461         (remote_notif_state_xfree): Don't declare.
7462         * remote-notif.c (remote_notif_process, handle_notification)
7463         (remote_notif_state_allocate): Update.
7464         (~remote_notif_state): Rename from remote_notif_state_xfree.
7465
7466 2019-04-19  Tom Tromey  <tom@tromey.com>
7467
7468         * symfile.c (reread_symbols): Update.
7469         * objfiles.c (objfile_register_static_link)
7470         (objfile_lookup_static_link): Update
7471         (~objfile) Don't delete static_links.
7472         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7473
7474 2019-04-19  Tom Tromey  <tom@tromey.com>
7475
7476         * type-stack.h (struct type_stack) <insert>: Constify string.
7477         * type-stack.c (type_stack::insert): Constify string.
7478         * gdbtypes.h (lookup_template_type): Update.
7479         (address_space_name_to_int): Update.
7480         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7481         const.
7482         (lookup_template_type): Make name const.
7483         * c-exp.y: Update rules.
7484         (lex_one_token, classify_name, classify_inner_name)
7485         (c_print_token): Update.
7486         * p-exp.y: Update rules.
7487         (yylex): Update.
7488         * f-exp.y: Update rules.
7489         (yylex): Update.
7490         * d-exp.y: Update rules.
7491         (lex_one_token, classify_name, classify_inner_name): Update.
7492         * parse.c (write_dollar_variable, copy_name): Return std::string.
7493         * parser-defs.h (copy_name): Change return type.
7494         * m2-exp.y: Update rules.
7495         (yylex): Update.
7496         * go-exp.y (lex_one_token): Update.
7497         Update rules.
7498         (classify_unsafe_function, classify_packaged_name)
7499         (classify_name, yylex): Update.
7500
7501 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7502
7503         * configure.ac: add --enable-source-highlight switch.
7504         * configure: Regenerate.
7505         * top.c (print_gdb_version): plumb --enable-source-highlight
7506         status to "show configuration".
7507
7508 2019-04-19  Tom Tromey  <tromey@adacore.com>
7509
7510         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7511         Check ADA_TYPE_P.
7512         (empty_record, ada_template_to_fixed_record_type_1)
7513         (template_to_static_fixed_type)
7514         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7515         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7516         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7517         macros.
7518
7519 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7520
7521         PR symtab/24423:
7522         * source.c (print_source_lines_base): Advance "iter" when a
7523         control character is seen.
7524
7525 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7526
7527         * inferior.h (struct infcall_suspend_state_deleter):
7528         Catch exception in destructor to avoid crash.
7529
7530 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7531
7532         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7533         close to the add_com "shell".
7534
7535 2019-04-18  Tom Tromey  <tromey@adacore.com>
7536
7537         * process-stratum-target.h (class process_stratum_target)
7538         <stratum>: Add "final".
7539
7540 2019-04-17  Tom Tromey  <tromey@adacore.com>
7541
7542         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7543         against nullptr before use.
7544
7545 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7546
7547         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7548
7549 2019-04-17  Jim Wilson  <jimw@sifive.com>
7550             Andrew Burgess  <andrew.burgess@embecosm.com>
7551
7552         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7553         code read might fail, assume 4-byte breakpoint in that case.
7554
7555 2019-04-15  Leszek Swirski  <leszeks@google.com>
7556
7557         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7558         rather than a hand-rolled POD check when checking for forced MEMORY
7559         classification.
7560
7561 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7562
7563         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7564         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7565         function.
7566         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7567         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7568         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7569         declaration.
7570
7571 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7572
7573         * aarch64-linux-nat.c
7574         (aarch64_linux_nat_target::thread_architecture): Add override.
7575         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7576         each VQ.
7577
7578 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7579
7580         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7581
7582 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7583
7584         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7585         target types of size 96-bits, add some additional comments, and
7586         check that the builtin type we found was the correct size.
7587
7588 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7589
7590         * utils.c (prompt_for_continue): Don't restore the styling at the
7591         end, as applied_style has the wrong value.  This fixes styling in
7592         long lists of file names that are interrupted by the "Continue?"
7593         prompt.
7594
7595 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7598         * c-lang.c (c_language_defn): Likewise.
7599         (cplus_language_defn): Likewise.
7600         (asm_language_defn): Likewise.
7601         (minimal_language_defn): Likewise.
7602         * d-lang.c (d_language_defn): Likewise.
7603         * f-lang.c (f_language_defn): Likewise.
7604         * go-lang.c (go_language_defn): Likewise.
7605         * language.c (unknown_language_defn): Likewise.
7606         (auto_language_defn): Likewise.
7607         * language.h (struct language_defn): Remove la_magic field.
7608         (LANG_MAGIC): Delete.
7609         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7610         * objc-lang.c (objc_language_defn): Likewise.
7611         * opencl-lang.c (opencl_language_defn): Likewise.
7612         * p-lang.c (pascal_language_defn): Likewise.
7613         * rust-lang.c (rust_language_defn): Likewise.
7614
7615 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7616
7617         * riscv-tdep.c (riscv_type_align): New function.
7618         (riscv_type_alignment): Delete.
7619         (riscv_arg_location): Use 'type_align'.
7620         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
7621
7622 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7623
7624         * gdbtypes.c (type_align): A struct with no non-static fields also
7625         has alignment of 1.
7626
7627 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7628
7629         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
7630         component to 0.
7631         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
7632         member.
7633         (riscv_struct_info::analyse): New implementation using new
7634         analyse_inner member function.
7635         (riscv_struct_info::field_offset): New member function.
7636         (riscv_struct_info::m_offsets): New member variable.
7637         (riscv_struct_info::analyse_inner): New private member function,
7638         takes the old implementation of riscv_struct_info::analyse but
7639         extended to track field offsets.
7640         (riscv_call_arg_struct): Update the struct folding special cases
7641         to handle cases where empty C++ structs, which are non-zero
7642         length, are found.
7643         (riscv_arg_location): Initialise the length of each location, a
7644         non-zero length now indicates the location is in use.
7645         (riscv_push_dummy_call): Allow for the first location having a
7646         non-zero offset when setting up arguments.
7647         (riscv_return_value): Likewise, but for return values.
7648
7649 2019-04-11  Tom Tromey  <tromey@adacore.com>
7650
7651         * utils.c (internal_vproblem): Make "msg" const.
7652
7653 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
7654
7655         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
7656         * trad-frame.c (trad_frame_reset_saved_regs): New function.
7657         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
7658         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
7659
7660 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
7661
7662         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
7663         function.
7664         (fill_gregset): Call amd64_linux_collect_native_gregset instead
7665         of amd64_collect_native_gregset.
7666         (amd64_linux_nat_target::store_registers): Likewise.
7667
7668 2019-04-10  Tom Tromey  <tom@tromey.com>
7669
7670         * symtab.c (lookup_global_symbol_from_objfile)
7671         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
7672         * objfiles.h (class separate_debug_iterator): New.
7673         (class separate_debug_range): New.
7674         (struct objfile) <separate_debug_objfiles>: New method.
7675         (objfile_separate_debug_iterate): Don't declare.
7676         * objfiles.c (separate_debug_iterator::operator++): Rename from
7677         objfile_separate_debug_iterate.
7678         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
7679         iterator.
7680         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
7681         iterator.
7682
7683 2019-04-10  Tom Tromey  <tom@tromey.com>
7684
7685         * symfile.c (reread_symbols): Remove old comment.
7686         * objfiles.c (free_all_objfiles): Fix a typo.
7687
7688 2019-04-10  Tom Tromey  <tom@tromey.com>
7689
7690         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
7691         * minsyms.c (lookup_minimal_symbol): Use foreach.
7692         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
7693         (lookup_minimal_symbol_solib_trampoline): Likewise.
7694         * symfile.c (reread_symbols): Use foreach.
7695
7696 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
7697             Tom Tromey  <tromey@adacore.com>
7698
7699         PR rust/24414:
7700         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
7701         (rust_lex_int_test): Change "value" to be LONGEST.
7702         (rust_lex_tests): Add test for long integer literal.
7703
7704 2019-04-09  Tom Tromey  <tromey@adacore.com>
7705
7706         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
7707         to bool.
7708         (extended_remote_target::attach): Update.
7709         (remote_target::remote_notice_new_inferior): Update.
7710         (remote_target::add_current_inferior_and_thread): Update.
7711         * inferior.c (exit_inferior_1): Use "false".
7712         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
7713
7714 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
7715
7716         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
7717         the "start" command.
7718
7719 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7720
7721         * python/py-inferior.c (infpy_thread_from_thread_handle):
7722         Adjust comments to reflect renaming of thread_from_thread_handle
7723         to thread_from_handle.  Adjust keywords.  Fix type error message.
7724         (inferior_object_methods): Add thread_from_handle.  Retain
7725         thread_from_thread_handle, but mark it as deprecated.
7726
7727 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7728
7729         * gdbthread.h (find_thread_by_handle): Revise declaration.
7730         * thread.c (find_thread_by_handle): Likewise.  Adjust
7731         implementation too.
7732         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
7733         support for buffer objects as handles.
7734
7735 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7736
7737         * python/py-infthread.c (thpy_thread_handle): New function.
7738         (thread_object_methods): Register thpy_thread_handle.
7739
7740 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
7741
7742         * gdbthread.h (thread_to_thread_handle): Declare.
7743         * thread.c (gdbtypes.h): Include.
7744         (thread_to_thread_handle): New function.
7745
7746         * target.h (struct target_ops): Add thread_info_to_thread_handle.
7747         (target_thread_info_to_thread_handle): Declare.
7748         * target.c (target_thread_info_to_thread_handle): New function.
7749         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
7750         * target-delegates.c: Regenerate.
7751
7752         * linux-thread-db.c (class thread_db_target): Add method
7753         thread_info_to_thread_handle.
7754         (thread_db_target::thread_info_to_thread_handle): Define.
7755         * remote.c (class remote_target): Add new method
7756         thread_info_to_thread_handle.
7757         (remote_target::thread_info_to_thread_handle): Define.
7758
7759 2019-04-08  Pedro Alves  <palves@redhat.com>
7760
7761         * common/common-exceptions.c (throw_exception): Don't create
7762         named object to throw; throw directly.
7763         (throw_it): Likewise.  Don't initialize gdb_exception::message
7764         here, with new; pass FMT and AP to the ctor instead.
7765         * common/common-exceptions.h: Include <string>.
7766         (gdb_exception::gdb_exception(enum return_reason, enum errors,
7767         const char *, va_list)): New ctor.  Use std::make_shared.
7768         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
7769         errors)): Delete.
7770         (gdb_exception_error::gdb_exception_error(enum errors, const char
7771         *, va_list)): New.
7772         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
7773         Add assertion.
7774         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
7775         errors)): Delete.
7776         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
7777         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
7778         Add assertion.
7779
7780 2019-04-08  Tom Tromey  <tom@tromey.com>
7781
7782         * valops.c (value_rtti_indirect_type): Replace throw_exception
7783         with throw.
7784         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
7785         with throw.
7786         * thread.c (thr_try_catch_cmd): Replace throw_exception with
7787         throw.
7788         * target.c (target_translate_tls_address): Replace throw_exception
7789         with throw.
7790         * stack.c (frame_apply_command_count): Replace throw_exception
7791         with throw.
7792         * solib-spu.c (append_ocl_sos): Replace throw_exception with
7793         throw.
7794         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
7795         with throw.
7796         * rs6000-tdep.c (rs6000_frame_cache)
7797         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
7798         * remote.c: Replace throw_exception with throw.
7799         * record-full.c (record_full_message, record_full_wait_1)
7800         (record_full_restore): Replace throw_exception with throw.
7801         * record-btrace.c:
7802         (get_thread_current_frame_id, record_btrace_start_replaying)
7803         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
7804         (cmd_record_btrace_start): Replace throw_exception with throw.
7805         * parse.c (parse_exp_in_context_1): Replace throw_exception with
7806         throw.
7807         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
7808         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
7809         * linespec.c:
7810         (find_linespec_symbols): Replace throw_exception with throw.
7811         * infrun.c (displaced_step_prepare, resume): Replace
7812         throw_exception with throw.
7813         * infcmd.c (post_create_inferior): Replace throw_exception with
7814         throw.
7815         * inf-loop.c (inferior_event_handler): Replace throw_exception
7816         with throw.
7817         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
7818         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
7819         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
7820         (get_prev_frame_always, get_frame_pc_if_available)
7821         (get_frame_address_in_block_if_available, get_frame_language):
7822         Replace throw_exception with throw.
7823         * frame-unwind.c (frame_unwind_try_unwinder): Replace
7824         throw_exception with throw.
7825         * eval.c (fetch_subexp_value, evaluate_var_value)
7826         (evaluate_funcall, evaluate_subexp_standard): Replace
7827         throw_exception with throw.
7828         * dwarf2loc.c (call_site_find_chain)
7829         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
7830         Replace throw_exception with throw.
7831         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
7832         with throw.
7833         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
7834         throw.
7835         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
7836         * completer.c (complete_line_internal): Replace throw_exception
7837         with throw.
7838         * compile/compile-object-run.c (compile_object_run): Replace
7839         throw_exception with throw.
7840         * cli/cli-script.c (process_next_line): Replace throw_exception
7841         with throw.
7842         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
7843         (btrace_enable, btrace_maint_update_pt_packets): Replace
7844         throw_exception with throw.
7845         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
7846         throw_exception with throw.
7847         * break-catch-throw.c (re_set_exception_catchpoint): Replace
7848         throw_exception with throw.
7849         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
7850         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
7851         * aarch64-tdep.c (aarch64_make_prologue_cache)
7852         (aarch64_make_stub_cache): Replace throw_exception with throw.
7853
7854 2019-04-08  Tom Tromey  <tom@tromey.com>
7855
7856         * common/common-exceptions.c (throw_exception): Rename from
7857         throw_exception_cxx.  Remove old copy.  Make argument const.
7858         (throw_it): Create and throw exception objects directly.
7859         * common/common-exceptions.h (throw_exception): Make argument
7860         const.
7861         (struct gdb_exception_error): Add constructor.
7862         (struct gdb_exception_quit): Add constructor.
7863
7864 2019-04-08  Tom Tromey  <tom@tromey.com>
7865
7866         * common/common-exceptions.h (exception_rethrow): Don't declare.
7867         (TRY_SJLJ): Update comment.
7868         (TRY, CATCH, END_CATCH): Remove.
7869         * common/common-exceptions.c (exception_rethrow): Remove.
7870
7871 2019-04-08  Tom Tromey  <tom@tromey.com>
7872
7873         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
7874         Remove.
7875         (gdb_exception_error): Rename from
7876         gdb_exception_RETURN_MASK_ERROR.
7877         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
7878         (gdb_quit_bad_alloc): Update.
7879         * aarch64-tdep.c: Update.
7880         * ada-lang.c: Update.
7881         * ada-typeprint.c: Update.
7882         * ada-valprint.c: Update.
7883         * amd64-tdep.c: Update.
7884         * arch-utils.c: Update.
7885         * break-catch-throw.c: Update.
7886         * breakpoint.c: Update.
7887         * btrace.c: Update.
7888         * c-varobj.c: Update.
7889         * cli/cli-cmds.c: Update.
7890         * cli/cli-interp.c: Update.
7891         * cli/cli-script.c: Update.
7892         * common/common-exceptions.c: Update.
7893         * common/new-op.c: Update.
7894         * common/selftest.c: Update.
7895         * compile/compile-c-symbols.c: Update.
7896         * compile/compile-cplus-symbols.c: Update.
7897         * compile/compile-object-load.c: Update.
7898         * compile/compile-object-run.c: Update.
7899         * completer.c: Update.
7900         * corelow.c: Update.
7901         * cp-abi.c: Update.
7902         * cp-support.c: Update.
7903         * cp-valprint.c: Update.
7904         * darwin-nat.c: Update.
7905         * disasm-selftests.c: Update.
7906         * dtrace-probe.c: Update.
7907         * dwarf-index-cache.c: Update.
7908         * dwarf-index-write.c: Update.
7909         * dwarf2-frame-tailcall.c: Update.
7910         * dwarf2-frame.c: Update.
7911         * dwarf2loc.c: Update.
7912         * dwarf2read.c: Update.
7913         * eval.c: Update.
7914         * event-loop.c: Update.
7915         * event-top.c: Update.
7916         * exec.c: Update.
7917         * f-valprint.c: Update.
7918         * fbsd-tdep.c: Update.
7919         * frame-unwind.c: Update.
7920         * frame.c: Update.
7921         * gdbtypes.c: Update.
7922         * gnu-v3-abi.c: Update.
7923         * guile/guile-internal.h: Update.
7924         * guile/scm-block.c: Update.
7925         * guile/scm-breakpoint.c: Update.
7926         * guile/scm-cmd.c: Update.
7927         * guile/scm-disasm.c: Update.
7928         * guile/scm-frame.c: Update.
7929         * guile/scm-lazy-string.c: Update.
7930         * guile/scm-math.c: Update.
7931         * guile/scm-param.c: Update.
7932         * guile/scm-ports.c: Update.
7933         * guile/scm-pretty-print.c: Update.
7934         * guile/scm-symbol.c: Update.
7935         * guile/scm-symtab.c: Update.
7936         * guile/scm-type.c: Update.
7937         * guile/scm-value.c: Update.
7938         * i386-linux-tdep.c: Update.
7939         * i386-tdep.c: Update.
7940         * inf-loop.c: Update.
7941         * infcall.c: Update.
7942         * infcmd.c: Update.
7943         * infrun.c: Update.
7944         * jit.c: Update.
7945         * language.c: Update.
7946         * linespec.c: Update.
7947         * linux-fork.c: Update.
7948         * linux-nat.c: Update.
7949         * linux-tdep.c: Update.
7950         * linux-thread-db.c: Update.
7951         * main.c: Update.
7952         * mi/mi-cmd-break.c: Update.
7953         * mi/mi-cmd-stack.c: Update.
7954         * mi/mi-interp.c: Update.
7955         * mi/mi-main.c: Update.
7956         * objc-lang.c: Update.
7957         * p-valprint.c: Update.
7958         * parse.c: Update.
7959         * ppc-linux-tdep.c: Update.
7960         * printcmd.c: Update.
7961         * python/py-arch.c: Update.
7962         * python/py-breakpoint.c: Update.
7963         * python/py-cmd.c: Update.
7964         * python/py-finishbreakpoint.c: Update.
7965         * python/py-frame.c: Update.
7966         * python/py-framefilter.c: Update.
7967         * python/py-gdb-readline.c: Update.
7968         * python/py-inferior.c: Update.
7969         * python/py-infthread.c: Update.
7970         * python/py-lazy-string.c: Update.
7971         * python/py-linetable.c: Update.
7972         * python/py-objfile.c: Update.
7973         * python/py-param.c: Update.
7974         * python/py-prettyprint.c: Update.
7975         * python/py-progspace.c: Update.
7976         * python/py-record-btrace.c: Update.
7977         * python/py-record.c: Update.
7978         * python/py-symbol.c: Update.
7979         * python/py-type.c: Update.
7980         * python/py-unwind.c: Update.
7981         * python/py-utils.c: Update.
7982         * python/py-value.c: Update.
7983         * python/python.c: Update.
7984         * record-btrace.c: Update.
7985         * record-full.c: Update.
7986         * remote-fileio.c: Update.
7987         * remote.c: Update.
7988         * riscv-tdep.c: Update.
7989         * rs6000-aix-tdep.c: Update.
7990         * rs6000-tdep.c: Update.
7991         * rust-exp.y: Update.
7992         * rust-lang.c: Update.
7993         * s390-tdep.c: Update.
7994         * selftest-arch.c: Update.
7995         * solib-dsbt.c: Update.
7996         * solib-frv.c: Update.
7997         * solib-spu.c: Update.
7998         * solib-svr4.c: Update.
7999         * solib.c: Update.
8000         * sparc64-linux-tdep.c: Update.
8001         * stack.c: Update.
8002         * symfile-mem.c: Update.
8003         * symmisc.c: Update.
8004         * target.c: Update.
8005         * thread.c: Update.
8006         * top.c: Update.
8007         * tracefile-tfile.c: Update.
8008         * tui/tui.c: Update.
8009         * typeprint.c: Update.
8010         * unittests/cli-utils-selftests.c: Update.
8011         * unittests/parse-connection-spec-selftests.c: Update.
8012         * valops.c: Update.
8013         * valprint.c: Update.
8014         * value.c: Update.
8015         * varobj.c: Update.
8016         * windows-nat.c: Update.
8017         * x86-linux-nat.c: Update.
8018         * xml-support.c: Update.
8019
8020 2019-04-08  Tom Tromey  <tom@tromey.com>
8021
8022         * xml-support.c: Use C++ exception handling.
8023         * x86-linux-nat.c: Use C++ exception handling.
8024         * windows-nat.c: Use C++ exception handling.
8025         * varobj.c: Use C++ exception handling.
8026         * value.c: Use C++ exception handling.
8027         * valprint.c: Use C++ exception handling.
8028         * valops.c: Use C++ exception handling.
8029         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8030         handling.
8031         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8032         * typeprint.c: Use C++ exception handling.
8033         * tui/tui.c: Use C++ exception handling.
8034         * tracefile-tfile.c: Use C++ exception handling.
8035         * top.c: Use C++ exception handling.
8036         * thread.c: Use C++ exception handling.
8037         * target.c: Use C++ exception handling.
8038         * symmisc.c: Use C++ exception handling.
8039         * symfile-mem.c: Use C++ exception handling.
8040         * stack.c: Use C++ exception handling.
8041         * sparc64-linux-tdep.c: Use C++ exception handling.
8042         * solib.c: Use C++ exception handling.
8043         * solib-svr4.c: Use C++ exception handling.
8044         * solib-spu.c: Use C++ exception handling.
8045         * solib-frv.c: Use C++ exception handling.
8046         * solib-dsbt.c: Use C++ exception handling.
8047         * selftest-arch.c: Use C++ exception handling.
8048         * s390-tdep.c: Use C++ exception handling.
8049         * rust-lang.c: Use C++ exception handling.
8050         * rust-exp.y: Use C++ exception handling.
8051         * rs6000-tdep.c: Use C++ exception handling.
8052         * rs6000-aix-tdep.c: Use C++ exception handling.
8053         * riscv-tdep.c: Use C++ exception handling.
8054         * remote.c: Use C++ exception handling.
8055         * remote-fileio.c: Use C++ exception handling.
8056         * record-full.c: Use C++ exception handling.
8057         * record-btrace.c: Use C++ exception handling.
8058         * python/python.c: Use C++ exception handling.
8059         * python/py-value.c: Use C++ exception handling.
8060         * python/py-utils.c: Use C++ exception handling.
8061         * python/py-unwind.c: Use C++ exception handling.
8062         * python/py-type.c: Use C++ exception handling.
8063         * python/py-symbol.c: Use C++ exception handling.
8064         * python/py-record.c: Use C++ exception handling.
8065         * python/py-record-btrace.c: Use C++ exception handling.
8066         * python/py-progspace.c: Use C++ exception handling.
8067         * python/py-prettyprint.c: Use C++ exception handling.
8068         * python/py-param.c: Use C++ exception handling.
8069         * python/py-objfile.c: Use C++ exception handling.
8070         * python/py-linetable.c: Use C++ exception handling.
8071         * python/py-lazy-string.c: Use C++ exception handling.
8072         * python/py-infthread.c: Use C++ exception handling.
8073         * python/py-inferior.c: Use C++ exception handling.
8074         * python/py-gdb-readline.c: Use C++ exception handling.
8075         * python/py-framefilter.c: Use C++ exception handling.
8076         * python/py-frame.c: Use C++ exception handling.
8077         * python/py-finishbreakpoint.c: Use C++ exception handling.
8078         * python/py-cmd.c: Use C++ exception handling.
8079         * python/py-breakpoint.c: Use C++ exception handling.
8080         * python/py-arch.c: Use C++ exception handling.
8081         * printcmd.c: Use C++ exception handling.
8082         * ppc-linux-tdep.c: Use C++ exception handling.
8083         * parse.c: Use C++ exception handling.
8084         * p-valprint.c: Use C++ exception handling.
8085         * objc-lang.c: Use C++ exception handling.
8086         * mi/mi-main.c: Use C++ exception handling.
8087         * mi/mi-interp.c: Use C++ exception handling.
8088         * mi/mi-cmd-stack.c: Use C++ exception handling.
8089         * mi/mi-cmd-break.c: Use C++ exception handling.
8090         * main.c: Use C++ exception handling.
8091         * linux-thread-db.c: Use C++ exception handling.
8092         * linux-tdep.c: Use C++ exception handling.
8093         * linux-nat.c: Use C++ exception handling.
8094         * linux-fork.c: Use C++ exception handling.
8095         * linespec.c: Use C++ exception handling.
8096         * language.c: Use C++ exception handling.
8097         * jit.c: Use C++ exception handling.
8098         * infrun.c: Use C++ exception handling.
8099         * infcmd.c: Use C++ exception handling.
8100         * infcall.c: Use C++ exception handling.
8101         * inf-loop.c: Use C++ exception handling.
8102         * i386-tdep.c: Use C++ exception handling.
8103         * i386-linux-tdep.c: Use C++ exception handling.
8104         * guile/scm-value.c: Use C++ exception handling.
8105         * guile/scm-type.c: Use C++ exception handling.
8106         * guile/scm-symtab.c: Use C++ exception handling.
8107         * guile/scm-symbol.c: Use C++ exception handling.
8108         * guile/scm-pretty-print.c: Use C++ exception handling.
8109         * guile/scm-ports.c: Use C++ exception handling.
8110         * guile/scm-param.c: Use C++ exception handling.
8111         * guile/scm-math.c: Use C++ exception handling.
8112         * guile/scm-lazy-string.c: Use C++ exception handling.
8113         * guile/scm-frame.c: Use C++ exception handling.
8114         * guile/scm-disasm.c: Use C++ exception handling.
8115         * guile/scm-cmd.c: Use C++ exception handling.
8116         * guile/scm-breakpoint.c: Use C++ exception handling.
8117         * guile/scm-block.c: Use C++ exception handling.
8118         * guile/guile-internal.h: Use C++ exception handling.
8119         * gnu-v3-abi.c: Use C++ exception handling.
8120         * gdbtypes.c: Use C++ exception handling.
8121         * frame.c: Use C++ exception handling.
8122         * frame-unwind.c: Use C++ exception handling.
8123         * fbsd-tdep.c: Use C++ exception handling.
8124         * f-valprint.c: Use C++ exception handling.
8125         * exec.c: Use C++ exception handling.
8126         * event-top.c: Use C++ exception handling.
8127         * event-loop.c: Use C++ exception handling.
8128         * eval.c: Use C++ exception handling.
8129         * dwarf2read.c: Use C++ exception handling.
8130         * dwarf2loc.c: Use C++ exception handling.
8131         * dwarf2-frame.c: Use C++ exception handling.
8132         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8133         * dwarf-index-write.c: Use C++ exception handling.
8134         * dwarf-index-cache.c: Use C++ exception handling.
8135         * dtrace-probe.c: Use C++ exception handling.
8136         * disasm-selftests.c: Use C++ exception handling.
8137         * darwin-nat.c: Use C++ exception handling.
8138         * cp-valprint.c: Use C++ exception handling.
8139         * cp-support.c: Use C++ exception handling.
8140         * cp-abi.c: Use C++ exception handling.
8141         * corelow.c: Use C++ exception handling.
8142         * completer.c: Use C++ exception handling.
8143         * compile/compile-object-run.c: Use C++ exception handling.
8144         * compile/compile-object-load.c: Use C++ exception handling.
8145         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8146         * compile/compile-c-symbols.c: Use C++ exception handling.
8147         * common/selftest.c: Use C++ exception handling.
8148         * common/new-op.c: Use C++ exception handling.
8149         * cli/cli-script.c: Use C++ exception handling.
8150         * cli/cli-interp.c: Use C++ exception handling.
8151         * cli/cli-cmds.c: Use C++ exception handling.
8152         * c-varobj.c: Use C++ exception handling.
8153         * btrace.c: Use C++ exception handling.
8154         * breakpoint.c: Use C++ exception handling.
8155         * break-catch-throw.c: Use C++ exception handling.
8156         * arch-utils.c: Use C++ exception handling.
8157         * amd64-tdep.c: Use C++ exception handling.
8158         * ada-valprint.c: Use C++ exception handling.
8159         * ada-typeprint.c: Use C++ exception handling.
8160         * ada-lang.c: Use C++ exception handling.
8161         * aarch64-tdep.c: Use C++ exception handling.
8162
8163 2019-04-08  Tom Tromey  <tom@tromey.com>
8164
8165         * xml-support.c (gdb_xml_parser::parse): Update.
8166         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8167         * value.c (show_convenience): Update.
8168         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8169         (test_parse_flags_qcs): Update.
8170         * thread.c (thr_try_catch_cmd): Update.
8171         * target.c (target_translate_tls_address): Update.
8172         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8173         (info_frame_command_core, frame_apply_command_count): Update.
8174         * rust-exp.y (rust_lex_exception_test): Update.
8175         * riscv-tdep.c (riscv_print_one_register_info): Update.
8176         * remote.c (remote_target::enable_btrace): Update.
8177         * record-btrace.c (record_btrace_enable_warn): Update.
8178         * python/py-utils.c (gdbpy_convert_exception): Update.
8179         * printcmd.c (do_one_display, print_variable_and_value): Update.
8180         * mi/mi-main.c (mi_print_exception): Update.
8181         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8182         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8183         * linux-nat.c (linux_nat_target::attach): Update.
8184         * linux-fork.c (class scoped_switch_fork_info): Update.
8185         * infrun.c (displaced_step_prepare): Update.
8186         * infcall.c (call_function_by_hand_dummy): Update.
8187         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8188         * gnu-v3-abi.c (print_one_vtable): Update.
8189         * frame.c (get_prev_frame_always): Update.
8190         * f-valprint.c (info_common_command_for_block): Update.
8191         * exec.c (try_open_exec_file): Update.
8192         * exceptions.c (print_exception, exception_print)
8193         (exception_fprintf, exception_print_same): Update.
8194         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8195         * dwarf-index-cache.c (index_cache::store)
8196         (index_cache::lookup_gdb_index): Update.
8197         * darwin-nat.c (maybe_cache_shell): Update.
8198         * cp-valprint.c (cp_print_value_fields): Update.
8199         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8200         (gcc_cplus_symbol_address): Update.
8201         * compile/compile-c-symbols.c (gcc_convert_symbol)
8202         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8203         * common/selftest.c: Update.
8204         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8205         a std::string.
8206         (exception_try_scope_entry, exception_try_scope_exit): Don't
8207         declare.
8208         (struct exception_try_scope): Remove.
8209         (TRY): Don't use exception_try_scope.
8210         (struct gdb_exception): Add constructor, operator=.
8211         <what>: New method.
8212         (struct gdb_exception_RETURN_MASK_ALL)
8213         (struct gdb_exception_RETURN_MASK_ERROR)
8214         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8215         (struct gdb_quit_bad_alloc): Update.
8216         * common/common-exceptions.c (exception_none): Change
8217         initializer.
8218         (struct catcher) <state, exception>: Initialize inline.
8219         <prev>: Remove member.
8220         (current_catcher): Remove.
8221         (catchers): New global.
8222         (exceptions_state_mc_init): Simplify.
8223         (catcher_pop): Remove.
8224         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8225         (try_scope_depth, exception_try_scope_entry)
8226         (exception_try_scope_exit): Remove.
8227         (throw_exception_sjlj): Update.
8228         (exception_messages, exception_messages_size): Remove.
8229         (throw_it): Simplify.
8230         (gdb_exception_sliced_copy): Remove.
8231         (throw_exception_cxx): Update.
8232         * cli/cli-script.c (script_from_file): Update.
8233         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8234         Update.
8235         * ada-valprint.c (ada_val_print): Update.
8236         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8237         (create_excep_cond_exprs): Update.
8238
8239 2019-04-08  Tom Tromey  <tom@tromey.com>
8240
8241         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8242         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8243         (TRY, CATCH, END_CATCH): Remove some definitions.
8244         * common/common-exceptions.c: Don't use GDB_XCPT.
8245         (catcher_list_size): Remove.
8246         (throw_exception, throw_it): Simplify.
8247
8248 2019-04-05  Tom Tromey  <tom@tromey.com>
8249
8250         Revert the header-sorting patch.
8251         * ft32-tdep.c: Revert.
8252         * frv-tdep.c: Revert.
8253         * frv-linux-tdep.c: Revert.
8254         * frame.c: Revert.
8255         * frame-unwind.c: Revert.
8256         * frame-base.c: Revert.
8257         * fork-child.c: Revert.
8258         * findvar.c: Revert.
8259         * findcmd.c: Revert.
8260         * filesystem.c: Revert.
8261         * filename-seen-cache.h: Revert.
8262         * filename-seen-cache.c: Revert.
8263         * fbsd-tdep.c: Revert.
8264         * fbsd-nat.h: Revert.
8265         * fbsd-nat.c: Revert.
8266         * f-valprint.c: Revert.
8267         * f-typeprint.c: Revert.
8268         * f-lang.c: Revert.
8269         * extension.h: Revert.
8270         * extension.c: Revert.
8271         * extension-priv.h: Revert.
8272         * expprint.c: Revert.
8273         * exec.h: Revert.
8274         * exec.c: Revert.
8275         * exceptions.c: Revert.
8276         * event-top.c: Revert.
8277         * event-loop.c: Revert.
8278         * eval.c: Revert.
8279         * elfread.c: Revert.
8280         * dwarf2read.h: Revert.
8281         * dwarf2read.c: Revert.
8282         * dwarf2loc.c: Revert.
8283         * dwarf2expr.h: Revert.
8284         * dwarf2expr.c: Revert.
8285         * dwarf2-frame.c: Revert.
8286         * dwarf2-frame-tailcall.c: Revert.
8287         * dwarf-index-write.h: Revert.
8288         * dwarf-index-write.c: Revert.
8289         * dwarf-index-common.c: Revert.
8290         * dwarf-index-cache.h: Revert.
8291         * dwarf-index-cache.c: Revert.
8292         * dummy-frame.c: Revert.
8293         * dtrace-probe.c: Revert.
8294         * disasm.h: Revert.
8295         * disasm.c: Revert.
8296         * disasm-selftests.c: Revert.
8297         * dictionary.c: Revert.
8298         * dicos-tdep.c: Revert.
8299         * demangle.c: Revert.
8300         * dcache.h: Revert.
8301         * dcache.c: Revert.
8302         * darwin-nat.h: Revert.
8303         * darwin-nat.c: Revert.
8304         * darwin-nat-info.c: Revert.
8305         * d-valprint.c: Revert.
8306         * d-namespace.c: Revert.
8307         * d-lang.c: Revert.
8308         * ctf.c: Revert.
8309         * csky-tdep.c: Revert.
8310         * csky-linux-tdep.c: Revert.
8311         * cris-tdep.c: Revert.
8312         * cris-linux-tdep.c: Revert.
8313         * cp-valprint.c: Revert.
8314         * cp-support.c: Revert.
8315         * cp-namespace.c: Revert.
8316         * cp-abi.c: Revert.
8317         * corelow.c: Revert.
8318         * corefile.c: Revert.
8319         * continuations.c: Revert.
8320         * completer.h: Revert.
8321         * completer.c: Revert.
8322         * complaints.c: Revert.
8323         * coffread.c: Revert.
8324         * coff-pe-read.c: Revert.
8325         * cli-out.h: Revert.
8326         * cli-out.c: Revert.
8327         * charset.c: Revert.
8328         * c-varobj.c: Revert.
8329         * c-valprint.c: Revert.
8330         * c-typeprint.c: Revert.
8331         * c-lang.c: Revert.
8332         * buildsym.c: Revert.
8333         * buildsym-legacy.c: Revert.
8334         * build-id.h: Revert.
8335         * build-id.c: Revert.
8336         * btrace.c: Revert.
8337         * bsd-uthread.c: Revert.
8338         * breakpoint.h: Revert.
8339         * breakpoint.c: Revert.
8340         * break-catch-throw.c: Revert.
8341         * break-catch-syscall.c: Revert.
8342         * break-catch-sig.c: Revert.
8343         * blockframe.c: Revert.
8344         * block.c: Revert.
8345         * bfin-tdep.c: Revert.
8346         * bfin-linux-tdep.c: Revert.
8347         * bfd-target.c: Revert.
8348         * bcache.c: Revert.
8349         * ax-general.c: Revert.
8350         * ax-gdb.h: Revert.
8351         * ax-gdb.c: Revert.
8352         * avr-tdep.c: Revert.
8353         * auxv.c: Revert.
8354         * auto-load.c: Revert.
8355         * arm-wince-tdep.c: Revert.
8356         * arm-tdep.c: Revert.
8357         * arm-symbian-tdep.c: Revert.
8358         * arm-pikeos-tdep.c: Revert.
8359         * arm-obsd-tdep.c: Revert.
8360         * arm-nbsd-tdep.c: Revert.
8361         * arm-nbsd-nat.c: Revert.
8362         * arm-linux-tdep.c: Revert.
8363         * arm-linux-nat.c: Revert.
8364         * arm-fbsd-tdep.c: Revert.
8365         * arm-fbsd-nat.c: Revert.
8366         * arm-bsd-tdep.c: Revert.
8367         * arch-utils.c: Revert.
8368         * arc-tdep.c: Revert.
8369         * arc-newlib-tdep.c: Revert.
8370         * annotate.h: Revert.
8371         * annotate.c: Revert.
8372         * amd64-windows-tdep.c: Revert.
8373         * amd64-windows-nat.c: Revert.
8374         * amd64-tdep.c: Revert.
8375         * amd64-sol2-tdep.c: Revert.
8376         * amd64-obsd-tdep.c: Revert.
8377         * amd64-obsd-nat.c: Revert.
8378         * amd64-nbsd-tdep.c: Revert.
8379         * amd64-nbsd-nat.c: Revert.
8380         * amd64-nat.c: Revert.
8381         * amd64-linux-tdep.c: Revert.
8382         * amd64-linux-nat.c: Revert.
8383         * amd64-fbsd-tdep.c: Revert.
8384         * amd64-fbsd-nat.c: Revert.
8385         * amd64-dicos-tdep.c: Revert.
8386         * amd64-darwin-tdep.c: Revert.
8387         * amd64-bsd-nat.c: Revert.
8388         * alpha-tdep.c: Revert.
8389         * alpha-obsd-tdep.c: Revert.
8390         * alpha-nbsd-tdep.c: Revert.
8391         * alpha-mdebug-tdep.c: Revert.
8392         * alpha-linux-tdep.c: Revert.
8393         * alpha-linux-nat.c: Revert.
8394         * alpha-bsd-tdep.c: Revert.
8395         * alpha-bsd-nat.c: Revert.
8396         * aix-thread.c: Revert.
8397         * agent.c: Revert.
8398         * addrmap.c: Revert.
8399         * ada-varobj.c: Revert.
8400         * ada-valprint.c: Revert.
8401         * ada-typeprint.c: Revert.
8402         * ada-tasks.c: Revert.
8403         * ada-lang.c: Revert.
8404         * aarch64-tdep.c: Revert.
8405         * aarch64-ravenscar-thread.c: Revert.
8406         * aarch64-newlib-tdep.c: Revert.
8407         * aarch64-linux-tdep.c: Revert.
8408         * aarch64-linux-nat.c: Revert.
8409         * aarch64-fbsd-tdep.c: Revert.
8410         * aarch64-fbsd-nat.c: Revert.
8411         * aarch32-linux-nat.c: Revert.
8412
8413 2019-04-05  Tom Tromey  <tom@tromey.com>
8414
8415         * ft32-tdep.c: Sort headers.
8416         * frv-tdep.c: Sort headers.
8417         * frv-linux-tdep.c: Sort headers.
8418         * frame.c: Sort headers.
8419         * frame-unwind.c: Sort headers.
8420         * frame-base.c: Sort headers.
8421         * fork-child.c: Sort headers.
8422         * findvar.c: Sort headers.
8423         * findcmd.c: Sort headers.
8424         * filesystem.c: Sort headers.
8425         * filename-seen-cache.h: Sort headers.
8426         * filename-seen-cache.c: Sort headers.
8427         * fbsd-tdep.c: Sort headers.
8428         * fbsd-nat.h: Sort headers.
8429         * fbsd-nat.c: Sort headers.
8430         * f-valprint.c: Sort headers.
8431         * f-typeprint.c: Sort headers.
8432         * f-lang.c: Sort headers.
8433         * extension.h: Sort headers.
8434         * extension.c: Sort headers.
8435         * extension-priv.h: Sort headers.
8436         * expprint.c: Sort headers.
8437         * exec.h: Sort headers.
8438         * exec.c: Sort headers.
8439         * exceptions.c: Sort headers.
8440         * event-top.c: Sort headers.
8441         * event-loop.c: Sort headers.
8442         * eval.c: Sort headers.
8443         * elfread.c: Sort headers.
8444         * dwarf2read.h: Sort headers.
8445         * dwarf2read.c: Sort headers.
8446         * dwarf2loc.c: Sort headers.
8447         * dwarf2expr.h: Sort headers.
8448         * dwarf2expr.c: Sort headers.
8449         * dwarf2-frame.c: Sort headers.
8450         * dwarf2-frame-tailcall.c: Sort headers.
8451         * dwarf-index-write.h: Sort headers.
8452         * dwarf-index-write.c: Sort headers.
8453         * dwarf-index-common.c: Sort headers.
8454         * dwarf-index-cache.h: Sort headers.
8455         * dwarf-index-cache.c: Sort headers.
8456         * dummy-frame.c: Sort headers.
8457         * dtrace-probe.c: Sort headers.
8458         * disasm.h: Sort headers.
8459         * disasm.c: Sort headers.
8460         * disasm-selftests.c: Sort headers.
8461         * dictionary.c: Sort headers.
8462         * dicos-tdep.c: Sort headers.
8463         * demangle.c: Sort headers.
8464         * dcache.h: Sort headers.
8465         * dcache.c: Sort headers.
8466         * darwin-nat.h: Sort headers.
8467         * darwin-nat.c: Sort headers.
8468         * darwin-nat-info.c: Sort headers.
8469         * d-valprint.c: Sort headers.
8470         * d-namespace.c: Sort headers.
8471         * d-lang.c: Sort headers.
8472         * ctf.c: Sort headers.
8473         * csky-tdep.c: Sort headers.
8474         * csky-linux-tdep.c: Sort headers.
8475         * cris-tdep.c: Sort headers.
8476         * cris-linux-tdep.c: Sort headers.
8477         * cp-valprint.c: Sort headers.
8478         * cp-support.c: Sort headers.
8479         * cp-namespace.c: Sort headers.
8480         * cp-abi.c: Sort headers.
8481         * corelow.c: Sort headers.
8482         * corefile.c: Sort headers.
8483         * continuations.c: Sort headers.
8484         * completer.h: Sort headers.
8485         * completer.c: Sort headers.
8486         * complaints.c: Sort headers.
8487         * coffread.c: Sort headers.
8488         * coff-pe-read.c: Sort headers.
8489         * cli-out.h: Sort headers.
8490         * cli-out.c: Sort headers.
8491         * charset.c: Sort headers.
8492         * c-varobj.c: Sort headers.
8493         * c-valprint.c: Sort headers.
8494         * c-typeprint.c: Sort headers.
8495         * c-lang.c: Sort headers.
8496         * buildsym.c: Sort headers.
8497         * buildsym-legacy.c: Sort headers.
8498         * build-id.h: Sort headers.
8499         * build-id.c: Sort headers.
8500         * btrace.c: Sort headers.
8501         * bsd-uthread.c: Sort headers.
8502         * breakpoint.h: Sort headers.
8503         * breakpoint.c: Sort headers.
8504         * break-catch-throw.c: Sort headers.
8505         * break-catch-syscall.c: Sort headers.
8506         * break-catch-sig.c: Sort headers.
8507         * blockframe.c: Sort headers.
8508         * block.c: Sort headers.
8509         * bfin-tdep.c: Sort headers.
8510         * bfin-linux-tdep.c: Sort headers.
8511         * bfd-target.c: Sort headers.
8512         * bcache.c: Sort headers.
8513         * ax-general.c: Sort headers.
8514         * ax-gdb.h: Sort headers.
8515         * ax-gdb.c: Sort headers.
8516         * avr-tdep.c: Sort headers.
8517         * auxv.c: Sort headers.
8518         * auto-load.c: Sort headers.
8519         * arm-wince-tdep.c: Sort headers.
8520         * arm-tdep.c: Sort headers.
8521         * arm-symbian-tdep.c: Sort headers.
8522         * arm-pikeos-tdep.c: Sort headers.
8523         * arm-obsd-tdep.c: Sort headers.
8524         * arm-nbsd-tdep.c: Sort headers.
8525         * arm-nbsd-nat.c: Sort headers.
8526         * arm-linux-tdep.c: Sort headers.
8527         * arm-linux-nat.c: Sort headers.
8528         * arm-fbsd-tdep.c: Sort headers.
8529         * arm-fbsd-nat.c: Sort headers.
8530         * arm-bsd-tdep.c: Sort headers.
8531         * arch-utils.c: Sort headers.
8532         * arc-tdep.c: Sort headers.
8533         * arc-newlib-tdep.c: Sort headers.
8534         * annotate.h: Sort headers.
8535         * annotate.c: Sort headers.
8536         * amd64-windows-tdep.c: Sort headers.
8537         * amd64-windows-nat.c: Sort headers.
8538         * amd64-tdep.c: Sort headers.
8539         * amd64-sol2-tdep.c: Sort headers.
8540         * amd64-obsd-tdep.c: Sort headers.
8541         * amd64-obsd-nat.c: Sort headers.
8542         * amd64-nbsd-tdep.c: Sort headers.
8543         * amd64-nbsd-nat.c: Sort headers.
8544         * amd64-nat.c: Sort headers.
8545         * amd64-linux-tdep.c: Sort headers.
8546         * amd64-linux-nat.c: Sort headers.
8547         * amd64-fbsd-tdep.c: Sort headers.
8548         * amd64-fbsd-nat.c: Sort headers.
8549         * amd64-dicos-tdep.c: Sort headers.
8550         * amd64-darwin-tdep.c: Sort headers.
8551         * amd64-bsd-nat.c: Sort headers.
8552         * alpha-tdep.c: Sort headers.
8553         * alpha-obsd-tdep.c: Sort headers.
8554         * alpha-nbsd-tdep.c: Sort headers.
8555         * alpha-mdebug-tdep.c: Sort headers.
8556         * alpha-linux-tdep.c: Sort headers.
8557         * alpha-linux-nat.c: Sort headers.
8558         * alpha-bsd-tdep.c: Sort headers.
8559         * alpha-bsd-nat.c: Sort headers.
8560         * aix-thread.c: Sort headers.
8561         * agent.c: Sort headers.
8562         * addrmap.c: Sort headers.
8563         * ada-varobj.c: Sort headers.
8564         * ada-valprint.c: Sort headers.
8565         * ada-typeprint.c: Sort headers.
8566         * ada-tasks.c: Sort headers.
8567         * ada-lang.c: Sort headers.
8568         * aarch64-tdep.c: Sort headers.
8569         * aarch64-ravenscar-thread.c: Sort headers.
8570         * aarch64-newlib-tdep.c: Sort headers.
8571         * aarch64-linux-tdep.c: Sort headers.
8572         * aarch64-linux-nat.c: Sort headers.
8573         * aarch64-fbsd-tdep.c: Sort headers.
8574         * aarch64-fbsd-nat.c: Sort headers.
8575         * aarch32-linux-nat.c: Sort headers.
8576
8577 2019-04-04  Tom Tromey  <tom@tromey.com>
8578
8579         * varobj.c (varobj_create): Update.
8580         * rust-exp.y (struct rust_parser) <update_innermost_block,
8581         lookup_symbol>: New methods.
8582         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8583         Rename.
8584         (rust_parser::rust_lookup_type)
8585         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8586         * printcmd.c (display_command, do_one_display): Update.
8587         * parser-defs.h (struct parser_state) <parser_state>: Add
8588         "tracker" parameter.
8589         (block_tracker): New member.
8590         (class innermost_block_tracker) <innermost_block_tracker>: Add
8591         "types" parameter.
8592         <reset>: Remove method.
8593         (innermost_block): Don't declare.
8594         (null_post_parser): Update.
8595         * parse.c (innermost_block): Remove global.
8596         (write_dollar_variable): Update.
8597         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8598         Remove "tracker_types" parameter.
8599         (parse_expression): Add "tracker" parameter.
8600         (parse_expression_for_completion): Update.
8601         (null_post_parser): Add "tracker" parameter.
8602         * p-exp.y: Update rules.
8603         * m2-exp.y: Update rules.
8604         * language.h (struct language_defn) <la_post_parser>: Add
8605         "tracker" parameter.
8606         * go-exp.y: Update rules.
8607         * f-exp.y: Update rules.
8608         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8609         parameter.
8610         * d-exp.y: Update rules.
8611         * c-exp.y: Update rules.
8612         * breakpoint.c (set_breakpoint_condition): Create an
8613         innermost_block_tracker.
8614         (watch_command_1): Likewise.
8615         * ada-lang.c (resolve): Add "tracker" parameter.
8616         (resolve_subexp): Likewise.
8617         * ada-exp.y (write_var_from_sym): Update.
8618
8619 2019-04-04  Tom Tromey  <tom@tromey.com>
8620
8621         * type-stack.h: New file.
8622         * type-stack.c: New file.
8623         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
8624         type-stack.h.
8625         (insert_into_type_stack, insert_type, push_type, push_type_int)
8626         (insert_type_address_space, pop_type, pop_type_int)
8627         (pop_typelist, pop_type_stack, append_type_stack)
8628         (push_type_stack, get_type_stack, push_typelist)
8629         (follow_type_instance_flags, follow_types): Don't declare.
8630         * parse.c (type_stack): Remove global.
8631         (parse_exp_in_context): Update.
8632         (insert_into_type_stack, insert_type, push_type, push_type_int)
8633         (insert_type_address_space, pop_type, pop_type_int)
8634         (pop_typelist, pop_type_stack, append_type_stack)
8635         (push_type_stack, get_type_stack, push_typelist)
8636         (follow_type_instance_flags, follow_types): Remove (moved to
8637         type-stack.c).
8638         * f-exp.y (type_stack): New global.
8639         Update rules.
8640         (push_kind_type, f_parse): Update.
8641         * d-exp.y (type_stack): New global.
8642         Update rules.
8643         (d_parse): Update.
8644         * c-exp.y (struct c_parse_state) <type_stack>: New member.
8645         Update rules.
8646         * Makefile.in (COMMON_SFILES): Add type-stack.c.
8647         (HFILES_NO_SRCDIR): Add type-stack.h.
8648
8649 2019-04-04  Tom Tromey  <tom@tromey.com>
8650
8651         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
8652         (rust_parser::convert_ast_to_expression, rust_parse)
8653         (rust_lex_test_completion, rust_lex_tests): Update.
8654         * parser-defs.h (struct expr_completion_state): New.
8655         (struct parser_state) <parser_state>: Add completion parameter.
8656         <mark_struct_expression, mark_completion_tag>: New methods.
8657         <parse_completion, m_completion_state>: New members.
8658         (prefixify_expression, null_post_parser): Update.
8659         (mark_struct_expression, mark_completion_tag): Don't declare.
8660         * parse.c (parse_completion, expout_last_struct)
8661         (expout_tag_completion_type, expout_completion_name): Remove
8662         globals.
8663         (parser_state::mark_struct_expression)
8664         (parser_state::mark_completion_tag): Now methods.
8665         (prefixify_expression): Add last_struct parameter.
8666         (prefixify_subexp): Likewise.
8667         (parse_exp_1): Update.
8668         (parse_exp_in_context): Add cstate parameter.  Update.
8669         (parse_expression_for_completion): Create an
8670         expr_completion_state.
8671         (null_post_parser): Add "completion" parameter.
8672         * p-exp.y: Update rules.
8673         (yylex): Update.
8674         * language.h (struct language_defn) <la_post_parser>: Add
8675         "completing" parameter.
8676         * go-exp.y: Update rules.
8677         (lex_one_token): Update.
8678         * expression.h (parse_completion): Don't declare.
8679         * d-exp.y: Update rules.
8680         (lex_one_token): Update rules.
8681         * c-exp.y: Update rules.
8682         (lex_one_token): Update.
8683         * ada-lang.c (resolve): Add "parse_completion" parameter.
8684         (resolve_subexp): Likewise.
8685         (ada_resolve_function): Likewise.
8686
8687 2019-04-04  Tom Tromey  <tom@tromey.com>
8688
8689         * parser-defs.h (struct parser_state) <start_arglist,
8690         end_arglist>: New methods.
8691         <arglist_len, m_funcall_chain>: New members.
8692         (arglist_len, start_arglist, end_arglist): Don't declare.
8693         * parse.c (arglist_len, funcall_chain): Remove global.
8694         (start_arglist, end_arglist): Remove functions.
8695         (parse_exp_in_context): Update.
8696         * p-exp.y: Update rules.
8697         * m2-exp.y: Update rules.
8698         * go-exp.y: Update rules.
8699         * f-exp.y: Update rules.
8700         * d-exp.y: Update rules.
8701         * c-exp.y: Update rules.
8702
8703 2019-04-04  Tom Tromey  <tom@tromey.com>
8704
8705         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
8706         lex_operator, push_back>: New methods.
8707         Update all rules.
8708         (rust_parser::lex_hex, lex_escape): Rename and update.
8709         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
8710         (rust_parser::lex_operator): Rename and update.
8711         (rust_parser::lex_number, rustyylex, rustyyerror)
8712         (rust_lex_test_init, rust_lex_test_sequence)
8713         (rust_lex_test_push_back, rust_lex_tests): Update.
8714         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
8715         parameter.
8716         <lexptr, prev_lexptr>: New members.
8717         (lexptr, prev_lexptr): Don't declare.
8718         * parse.c (lexptr, prev_lexptr): Remove globals.
8719         (parse_exp_in_context): Update.
8720         * p-exp.y (yylex, yyerror): Update.
8721         * m2-exp.y (parse_number, yylex, yyerror): Update.
8722         * go-exp.y (lex_one_token, yyerror): Update.
8723         * f-exp.y (match_string_literal, yylex, yyerror): Update.
8724         * d-exp.y (lex_one_token, yyerror): Update.
8725         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
8726         (lex_one_token, yyerror): Update.
8727         * ada-lex.l (YY_INPUT): Update.
8728         (rewind_to_char): Update.
8729         * ada-exp.y (yyerror): Update.
8730
8731 2019-04-04  Tom Tromey  <tom@tromey.com>
8732
8733         * rust-exp.y (rustyylex, rust_lex_tests): Update.
8734         * parser-defs.h (struct parser_state) <parser_state>: Add new
8735         parameter.
8736         <comma_terminates>: New member.
8737         (comma_terminates): Don't declare global.
8738         * parse.c (comma_terminates): Remove global.
8739         (parse_exp_in_context): Update.
8740         * p-exp.y (yylex): Update.
8741         * m2-exp.y (yylex): Update.
8742         * go-exp.y (lex_one_token): Update.
8743         * f-exp.y (yylex): Update.
8744         * d-exp.y (lex_one_token): Update.
8745         * c-exp.y (lex_one_token): Update.
8746         * ada-lex.l: Update.
8747
8748 2019-04-04  Tom Tromey  <tom@tromey.com>
8749
8750         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
8751         (rustyylex, rust_lex_test_init, rust_lex_test_one)
8752         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
8753         * parser-defs.h (paren_depth): Don't declare.
8754         * parse.c (paren_depth): Remove global.
8755         (parse_exp_in_context): Update.
8756         * p-exp.y (paren_depth): New global.
8757         (pascal_parse): Initialize it.
8758         * m2-exp.y (paren_depth): New global.
8759         (m2_parse): Initialize it.
8760         * go-exp.y (paren_depth): New global.
8761         (go_parse): Initialize it.
8762         * f-exp.y (paren_depth): New global.
8763         (f_parse): Initialize it.
8764         * d-exp.y (paren_depth): New global.
8765         (d_parse): Initialize it.
8766         * c-exp.y (paren_depth): New global.
8767         (c_parse): Initialize it.
8768         * ada-lex.l (paren_depth): New global.
8769         (lexer_init): Initialize it.
8770
8771 2019-04-04  Tom Tromey  <tom@tromey.com>
8772
8773         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
8774         (rust_parser::convert_ast_to_type)
8775         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8776         * parser-defs.h (struct parser_state) <parser_state>: Add
8777         parameters.  Initialize new members.
8778         <expression_context_block, expression_context_pc>: New members.
8779         * parse.c (expression_context_block, expression_context_pc):
8780         Remove globals.
8781         (parse_exp_in_context): Update.
8782         * p-exp.y: Update all rules.
8783         (yylex): Update.
8784         * m2-exp.y: Update all rules.
8785         (yylex): Update.
8786         * go-exp.y (yylex): Update.
8787         * f-exp.y (yylex): Update.
8788         * d-exp.y: Update all rules.
8789         (yylex): Update.
8790         * c-exp.y: Update all rules.
8791         (lex_one_token, classify_name, yylex, c_parse): Update.
8792         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
8793
8794 2019-04-04  Tom Tromey  <tom@tromey.com>
8795
8796         * gdbarch.h, gdbarch.c: Rebuild.
8797         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
8798         * stap-probe.h:
8799         (struct stap_parse_info): Replace "parser_state" with
8800         "expr_builder".
8801         * parser-defs.h (struct expr_builder): Rename from "parser_state".
8802         (parser_state): New class.
8803         * parse.c (expr_builder): Rename.
8804         (expr_builder::release): Rename.
8805         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
8806         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
8807         (write_exp_elt_longcst, write_exp_elt_floatcst)
8808         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
8809         (write_exp_string_vector, write_exp_bitstring)
8810         (write_exp_msymbol, mark_struct_expression)
8811         (write_dollar_variable)
8812         (insert_type_address_space, increase_expout_size): Replace
8813         "parser_state" with "expr_builder".
8814         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
8815         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
8816         "parser_state" with "expr_builder".
8817
8818 2019-04-04  Tom Tromey  <tom@tromey.com>
8819
8820         * rust-exp.y: Replace "parse_language" with method call.
8821         * p-exp.y:
8822         (yylex): Replace "parse_language" with method call.
8823         * m2-exp.y:
8824         (yylex): Replace "parse_language" with method call.
8825         * go-exp.y (classify_name): Replace "parse_language" with method
8826         call.
8827         * f-exp.y (yylex): Replace "parse_language" with method call.
8828         * d-exp.y (lex_one_token): Replace "parse_language" with method
8829         call.
8830         * c-exp.y:
8831         (lex_one_token, classify_name, yylex): Replace "parse_language"
8832         with method call.
8833         * ada-exp.y (find_primitive_type, type_char)
8834         (type_system_address): Replace "parse_language" with method call.
8835
8836 2019-04-04  Tom Tromey  <tom@tromey.com>
8837
8838         * rust-exp.y: Replace "parse_gdbarch" with method call.
8839         * parse.c (write_dollar_variable, insert_type_address_space):
8840         Replace "parse_gdbarch" with method call.
8841         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
8842         call.
8843         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
8844         call.
8845         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
8846         "parse_gdbarch" with method call.
8847         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
8848         with method call.
8849         * f-exp.y (parse_type, parse_f_type, yylex): Replace
8850         "parse_gdbarch" with method call.
8851         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
8852         "parse_gdbarch" with method call.
8853         * c-exp.y (parse_type, parse_number, classify_name): Replace
8854         "parse_gdbarch" with method call.
8855         * ada-lex.l: Replace "parse_gdbarch" with method call.
8856         * ada-exp.y (parse_type, find_primitive_type, type_char)
8857         (type_system_address): Replace "parse_gdbarch" with method call.
8858
8859 2019-04-04  Tom Tromey  <tom@tromey.com>
8860
8861         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
8862         * stap-probe.c (stap_parse_argument): Update.
8863         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
8864         initial_size parameter.
8865         * rust-exp.y (rust_lex_tests): Update.
8866         * parse.c (parser_state): Update.
8867         (parse_exp_in_context): Update.
8868         * parser-defs.h (struct parser_state) <parser_state>: Remove
8869         "initial_size" parameter.
8870
8871 2019-04-04  Tom Tromey  <tom@tromey.com>
8872
8873         * parser-defs.h (increase_expout_size): Don't declare.
8874         * parse.c (increase_expout_size): Now static.
8875
8876 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
8877
8878         * gnu-nat.c (gnu_nat_target::wait): Fix
8879         target_waitstatus_to_string call.
8880
8881 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8882
8883         * eval.c (evaluate_subexp_standard): Handle internal functions
8884         during Fortran function call handling.
8885
8886 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8887
8888         * NEWS: Mention new internal functions.
8889         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
8890         (read_base_type): Use dwarf2_init_complex_target_type.
8891         * value.c (creal_internal_fn): New function.
8892         (cimag_internal_fn): New function.
8893         (_initialize_values): Register new internal functions.
8894
8895 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8896
8897         * infrun.c (stop_all_threads): If debug_infrun, always
8898         trace the wait status after wait_one, using
8899         target_waitstatus_to_string and target_pid_to_str.
8900         (handle_inferior_event): Replace various trace of
8901         wait status kind by a single trace.
8902         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
8903         wait status kind image by target_waitstatus_to_string.
8904         * target/waitstatus.c (target_waitstatus_to_string): Fix
8905         obsolete comment.
8906
8907 2019-04-01  Tom Tromey  <tromey@adacore.com>
8908
8909         PR symtab/23331:
8910         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
8911
8912 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
8913             Pedro Alves  <palves@redhat.com>
8914
8915         * top.c (quit_force): Call 'finalize_values'.
8916         * value.c (finalize_values): New function.
8917         * value.h (finalize_values): Declare.
8918
8919 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
8920
8921         * NEWS: Announce $_gdb_major and $_gdb_minor.
8922
8923         * top.c (init_gdb_version_vars): New function.
8924         (gdb_init): Call init_gdb_version_vars.
8925
8926 2019-03-29  Tom Tromey  <tromey@adacore.com>
8927
8928         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
8929         help text.  Remove dead code.
8930
8931 2019-03-29  Keith Seitz  <keiths@redhat.com>
8932
8933         From Siddhesh Poyarekar:
8934         * f-lang.h (f77_get_upperbound): Return LONGEST.
8935         (f77_get_lowerbound): Likewise.
8936         * f-typeprint.c (f_type_print_varspec_suffix): Expand
8937         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
8938         print them.
8939         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
8940         plongest to format print it.
8941         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
8942         (f77_get_upperbound): Likewise.
8943         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
8944         LOWER_BOUND to LONGEST.
8945         (f77_create_arrayprint_offset_tbl): Likewise.
8946
8947 2019-03-29  Keith Seitz  <keiths@redhat.com>
8948
8949         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
8950         %s/pulongest for TYPE_LENGTH instead of %d in format
8951         strings.
8952         * ada-typerint.c (ada_print_type): Likewise.
8953         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
8954         * compile/compile-c-support.c (generate_register_struct): Likewise.
8955         * gdbtypes.c (recursive_dump_type): Likewise.
8956         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
8957         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
8958         instead of %d in format strings.
8959         * riscv-tdep.c (riscv_type_alignment): Cast second argument
8960         to std::min to ULONGEST.
8961         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
8962         instead of %d in format strings.
8963         * tracepoint.c (info_scope_command): Likewise.
8964         * typeprint.c (print_offset_data::update)
8965         (print_offset_data::finish): Likewise.
8966         * xtensa-tdep.c (xtensa_store_return_value)
8967         (xtensa_push_dummy_call): Likewise.
8968
8969 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
8970
8971         * windows-nat.c (display_selector): Fixed format specifications
8972         for 64-bit Cygwin.
8973
8974 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8975
8976         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
8977
8978 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
8979
8980         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
8981         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
8982         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
8983         (nios2_linux_init_abi): Install it.
8984
8985 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8986
8987         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
8988
8989 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
8990
8991         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
8992
8993 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8994             Tom Tromey  <tromey@adacore.com>
8995
8996         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
8997
8998 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
8999
9000         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9001         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9002         method to compute the bounds of range types. Also print "[evaluated]"
9003         if the bounds' values come from a dynamic evaluation.
9004
9005 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9006
9007         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9008         whitespace when pretty printing is on.
9009
9010 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9011
9012         * ppc-linux-nat.c: Add include.
9013
9014 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9015
9016         * NEWS: Mention AArch64 Pointer Authentication.
9017
9018 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9019
9020         * arm-linux-nat.c: Add include.
9021
9022 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9023
9024         * source-cache.c (source_cache::get_source_lines): Re-read
9025         fullname after calling open_source_file.
9026
9027 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9028
9029         * NEWS: Mention TLS support for FreeBSD.
9030
9031 2019-03-25  Tom Tromey  <tromey@adacore.com>
9032
9033         * minsyms.c (BUNCH_SIZE): Update comment.
9034         (~minimal_symbol_reader): Remove old comment.
9035         (compact_minimal_symbols): Update comment.
9036         (minimal_symbol_reader::install): Remove old comment.  Update
9037         other comments.
9038
9039 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9040
9041         * s390-linux-nat.c: Add include.
9042
9043 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9044
9045         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9046         Call linux_get_hwcap.
9047         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9048         Likewise.
9049         (aarch64_linux_get_hwcap): Remove function.
9050         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9051         declaration.
9052         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9053         linux_get_hwcap.
9054         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9055         * linux-tdep.c (linux_get_hwcap): Add function.
9056         (linux_get_hwcap2): Likewise.
9057         * linux-tdep.h (linux_get_hwcap): Add declaration.
9058         (linux_get_hwcap2): Likewise.
9059         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9060         (ppc_linux_get_hwcap2): Likewise.
9061         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9062         linux_get_hwcap.
9063         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9064         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9065         (ppc_linux_nat_target::read_description): Likewise.
9066         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9067         * s390-linux-nat.c: Likewise.
9068         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9069
9070 2019-03-24  Tom Tromey  <tom@tromey.com>
9071
9072         * ada-lang.c (standard_lookup): Simplify initialization.
9073         (ada_lookup_symbol_nonlocal): Simplify return.
9074         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9075         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9076         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9077         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9078         initialization.
9079         * solib.c (solib_global_lookup): Simplify.
9080         * symtab.c (null_block_symbol): Remove.
9081         (symbol_cache_lookup): Simplify returns.
9082         (lookup_language_this): Simplify returns.
9083         (lookup_symbol_aux): Simplify return.
9084         (lookup_local_symbol): Simplify returns.
9085         (lookup_global_symbol_from_objfile): Simplify return.
9086         (lookup_symbol_in_objfile_symtabs)
9087         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9088         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9089         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9090         * cp-namespace.c (cp_lookup_bare_symbol)
9091         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9092         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9093         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9094         (cp_lookup_symbol_via_imports): Simplify initialization.
9095         (find_symbol_in_baseclass): Likewise.
9096         * symtab.h (null_block_symbol): Remove.
9097         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9098         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9099         (d_lookup_symbol_module): Likewise.
9100         (find_symbol_in_baseclass): Simplify initialization.
9101
9102 2019-03-24  Tom Tromey  <tom@tromey.com>
9103
9104         * expression.h: Don't include symtab.h.
9105         (struct block): Forward declare.
9106
9107 2019-03-24  Tom Tromey  <tom@tromey.com>
9108
9109         * c-exp.y (typebase): Remove casts.
9110         * gdbtypes.c (lookup_unsigned_typename, )
9111         (lookup_signed_typename): Remove cast.
9112         * eval.c (parse_to_comma_and_eval): Remove cast.
9113         * parse.c (write_dollar_variable): Remove cast.
9114         * block.h (struct block) <superblock>: Now const.
9115         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9116         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9117         (map_block): Make "block" const.
9118         * symfile.h (struct quick_symbol_functions)
9119         <map_matching_symbols>: Constify block argument to "callback".
9120         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9121         const.
9122         (find_pc_sect_compunit_symtab): Make "b" const.
9123         (find_symbol_at_address): Likewise.
9124         (search_symbols): Likewise.
9125         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9126         (dw2_debug_names_lookup_symbol): Likewise.
9127         (dw2_map_matching_symbols): Update.
9128         * p-valprint.c (pascal_val_print): Remove "block".
9129         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9130         (aux_add_nonlocal_symbols): Make "block" const.
9131         (resolve_subexp): Remove cast.
9132         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9133         const.
9134         (iterate_over_file_blocks): Likewise.
9135         * f-exp.y (%union) <bval>: Remove.
9136         * coffread.c (patch_opaque_types): Make "b" const.
9137         * spu-tdep.c (spu_catch_start): Make "block" const.
9138         * c-valprint.c (print_unpacked_pointer): Remove "block".
9139         * symmisc.c (dump_symtab_1): Make "b" const.
9140         (block_depth): Make "block" const.
9141         * d-exp.y (%union) <bval>: Remove.
9142         * cp-support.h (cp_lookup_rtti_type): Update.
9143         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9144         * psymtab.c (psym_lookup_symbol): Make "block" const.
9145         (maintenance_check_psymtabs): Make "b" const.
9146         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9147         (enumerate_locals, enumerate_args): Update.
9148         * python/py-symtab.c (stpy_global_block): Make "block" const.
9149         (stpy_static_block): Likewise.
9150         * inline-frame.c (block_starting_point_at): Make "new_block"
9151         const.
9152         * block.c (find_block_in_blockvector): Make return type const.
9153         (blockvector_for_pc_sect): Make "b" const.
9154         (find_block_in_blockvector): Make "b" const.
9155
9156 2019-03-23  Tom Tromey  <tom@tromey.com>
9157
9158         * varobj.c (varobj_create): Update.
9159         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9160         * printcmd.c (display_command, do_one_display): Don't reset
9161         innermost_block.
9162         * parser-defs.h (enum innermost_block_tracker_type): Move to
9163         expression.h.
9164         (innermost_block): Update comment.
9165         * parse.c (parse_exp_1): Add tracker_types parameter.
9166         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9167         tracker_types parameter.  Reset innermost_block.
9168         (parse_exp_in_context): Remove.
9169         (parse_expression_for_completion): Update.
9170         * objfiles.c (~objfile): Don't reset expression_context_block or
9171         innermost_block.
9172         * expression.h (enum innermost_block_tracker_type): Move from
9173         parser-defs.h.
9174         (parse_exp_1): Add tracker_types parameter.
9175         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9176         reset innermost_block.
9177
9178 2019-03-23  Tom Tromey  <tom@tromey.com>
9179
9180         * objfiles.h: Include bcache.h.
9181
9182 2019-03-23  Tom Tromey  <tom@tromey.com>
9183
9184         * linespec.c (get_current_search_block): Use
9185         scoped_restore_current_language.
9186         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9187
9188 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9189             Jiong Wang  <jiong.wang@arm.com>
9190
9191         * aarch64-linux-tdep.c
9192         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9193         section.
9194         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9195
9196 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9197             Jiong Wang  <jiong.wang@arm.com>
9198
9199         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9200         instructions.
9201         (aarch64_analyze_prologue_test): Add PACIASP test.
9202         (aarch64_prologue_prev_register): Unmask PC value.
9203
9204 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9205             Jiong Wang  <jiong.wang@arm.com>
9206
9207         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9208         (aarch64_dwarf2_prev_register): Unmask PC value.
9209         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9210         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9211         DW_CFA_AARCH64_negate_ra_state.
9212         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9213
9214 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9215             Jiong Wang  <jiong.wang@arm.com>
9216
9217         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9218         registers.
9219         (aarch64_pseudo_register_name): Likewise.
9220         (aarch64_pseudo_register_type): Likewise.
9221         (aarch64_pseudo_register_reggroup_p): Likewise.
9222         (aarch64_gdbarch_init): Add pauth registers.
9223         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9224         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9225         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9226         (struct gdbarch_tdep): Add regnum for ra_state.
9227
9228 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9229             Jiong Wang  <jiong.wang@arm.com>
9230
9231         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9232
9233 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9234             Jiong Wang  <jiong.wang@arm.com>
9235
9236         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9237         function.
9238         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9239         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9240         (aarch64_gdbarch_init): Add puth registers.
9241         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9242         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9243         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9244
9245 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9246             Jiong Wang  <jiong.wang@arm.com>
9247
9248         * aarch64-linux-nat.c
9249         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9250         * aarch64-linux-tdep.c
9251         (aarch64_linux_core_read_description): Likewise.
9252         (aarch64_linux_get_hwcap): New function.
9253         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9254         (aarch64_linux_get_hwcap): New declaration.
9255
9256 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9257             Jiong Wang  <jiong.wang@arm.com>
9258
9259         * aarch64-linux-nat.c
9260         (aarch64_linux_nat_target::read_description): Add pauth param.
9261         * aarch64-linux-tdep.c
9262         (aarch64_linux_core_read_description): Likewise.
9263         * aarch64-tdep.c (struct target_desc): Add in pauth.
9264         (aarch64_read_description): Add pauth param.
9265         (aarch64_gdbarch_init): Likewise.
9266         * aarch64-tdep.h (aarch64_read_description): Likewise.
9267         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9268         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9269         * features/Makefile: Add new files.
9270         * features/aarch64-pauth.c: New file.
9271         * features/aarch64-pauth.xml: New file.
9272
9273 2019-03-20  Tom Tromey  <tromey@adacore.com>
9274
9275         * infrun.c (handle_inferior_event): Rename from
9276         handle_inferior_event_1.  Create a scoped_value_mark.
9277         (handle_inferior_event): Remove.
9278
9279 2019-03-19  Tom Tromey  <tromey@adacore.com>
9280
9281         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9282         * infrun.h (print_stop_event): Add "displays" parameter.
9283         * infrun.c (print_stop_event): Add "displays" parameter.
9284
9285 2019-03-19  Pedro Alves  <palves@redhat.com>
9286
9287         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9288         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9289         to -1.  Fix TABs vs spaces.
9290         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9291         * tui/tui-out.h (tui_ui_out) Add intro comments.
9292         <m_line, m_start_of_line>: In-class initialize, and add describing
9293         comment.
9294
9295 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9296
9297         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9298         variable names.
9299         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9300
9301 2019-03-18  Pedro Alves  <palves@redhat.com>
9302             Eli Zaretskii <eliz@gnu.org>
9303
9304         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9305         m_line and m_start_of_line.
9306
9307 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9308
9309         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9310         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9311         it returns a newline.  This fixes a regression in TU mode, whereby
9312         the next line is output on the same screen line as the user input.
9313
9314 2019-03-18  Tom Tromey  <tromey@adacore.com>
9315
9316         * minsyms.c (minimal_symbol_reader::install): Remove call to
9317         obstack_blank.
9318
9319 2019-03-18  Pedro Alves  <palves@redhat.com>
9320
9321         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9322         New globals.
9323         (apply_style): New, factored out from ...
9324         (apply_ansi_escape): ... this.  Handle reverse video mode.
9325         (tui_set_reverse_mode): New function.
9326         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9327         * tui/tui-winsource.c (tui_show_source_line): Use
9328         tui_set_reverse_mode instead of setting A_STANDOUT.
9329         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9330         New setter methods.
9331
9332 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9333
9334         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9335         Handle tabs.
9336
9337 2019-03-18  Tom Tromey  <tromey@adacore.com>
9338
9339         * ada-lang.c (empty_array): Add "high" parameter.
9340         (ada_evaluate_subexp): Update.
9341
9342 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9343
9344         * unittests/string_view-selftests.c: Define
9345         _initialize_string_view_selftests unconditionally.
9346
9347 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9348
9349         PR gdb/24350
9350         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9351
9352 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9353
9354         PR gdb/24351
9355         * windows-nat.c (display_selector): Fix format specifiers.
9356
9357 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9358
9359         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9360         tui_refill_source_window instead of tui_refresh_win, to update the
9361         current execution line.  This fixes redisplay of the current line
9362         when stepping through the code with "next" or "step".
9363
9364 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9365
9366         * source-cache.c (source_cache::get_source_lines): Call
9367         find_source_lines to initialize s->nlines.  This fixes vertical
9368         scrolling of TUI source window when the DOWN arrow is pressed.
9369
9370 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9371
9372         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9373         linux-thread-db.c (_initialize_thread_db): Likewise.
9374
9375 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9376
9377         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9378         wclrtoeol in tui_show_source_line".  This reverts changes made in
9379         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9380
9381 2019-03-15  Tom Tromey  <tom@tromey.com>
9382
9383         * symtab.h (struct minimal_symbol): Derive from
9384         general_symbol_info.
9385         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9386         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9387         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9388         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9389         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9390         (MSYMBOL_SEARCH_NAME): Update.
9391         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9392         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9393         * minsyms.c (minimal_symbol_reader::record_full): Update.
9394
9395 2019-03-15  Tom Tromey  <tom@tromey.com>
9396
9397         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9398
9399 2019-03-15  Tom Tromey  <tom@tromey.com>
9400
9401         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9402         unique_xmalloc_ptr.
9403         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9404         Update.
9405         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9406         (build_minimal_symbol_hash_tables)
9407         (minimal_symbol_reader::install): Update.
9408
9409 2019-03-15  Tom Tromey  <tom@tromey.com>
9410
9411         * symtab.c (create_demangled_names_hash): Update.
9412         (symbol_set_names): Update.
9413         * objfiles.h (struct objfile_per_bfd_storage)
9414         <demangled_names_hash>: Now an htab_up.
9415         * objfiles.c (objfile_per_bfd_storage): Simplify.
9416
9417 2019-03-15  Tom Tromey  <tom@tromey.com>
9418
9419         * objfiles.h (struct objfile_per_bfd_storage): Declare
9420         destructor.
9421         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9422         New.
9423         (get_objfile_bfd_data): Use new.  Don't initialize
9424         language_of_main.
9425         (free_objfile_per_bfd_storage): Remove.
9426         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9427
9428 2019-03-15  Tom Tromey  <tom@tromey.com>
9429
9430         * symfile.c (reread_symbols): Update.
9431         * objfiles.c (objfile::objfile): Update.
9432         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9433         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9434         comment.
9435         (minimal_symbol_reader::install): Update.
9436         (terminate_minimal_symbol_table): Remove.
9437         * jit.c (jit_object_close_impl): Update.
9438
9439 2019-03-15  Tom Tromey  <tom@tromey.com>
9440
9441         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9442         initializations.
9443
9444 2019-03-15  Tom Tromey  <tom@tromey.com>
9445
9446         * objfiles.h (struct objfile_per_bfd_storage)
9447         <demangled_hash_languages>: Now a bitset.
9448         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9449         (lookup_minimal_symbol): Update.
9450
9451 2019-03-15  Tom Tromey  <tom@tromey.com>
9452
9453         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9454         Don't return the symbol.
9455         * coffread.c (record_minimal_symbol): Use record_full.
9456
9457 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9458
9459         The MS-Windows port of ncurses fails to switch to a color pair if
9460         one or both of the colors are the implicit default colors.  This
9461         change records the default colors when TUI is initialized, and
9462         then specifies them explicitly when a color pair uses the default
9463         colors.  This allows color styling in TUI mode on MS-Windows.
9464
9465         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9466         ncurses_norm_attr.
9467         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9468         colors in ncurses_norm_attr.
9469         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9470         "none", replace it with the default color recorded in
9471         ncurses_norm_attr.
9472
9473 2019-03-14  Tom Tromey  <tromey@adacore.com>
9474
9475         * source-cache.h (class source_cache) <get_source_lines>: Return
9476         std::string.
9477         * source-cache.c (source_cache::extract_lines): Handle case where
9478         first_pos==npos.  Return std::string.
9479         (source_cache::get_source_lines): Update.
9480
9481 2019-03-14  Tom Tromey  <tromey@adacore.com>
9482
9483         * NEWS: Add item for "style sources" commands.
9484         * source-cache.c (source_cache::get_source_lines): Check
9485         source_styling.
9486         * cli/cli-style.c (source_styling): New global.
9487         (_initialize_cli_style): Add "style sources" commands.
9488         (show_style_sources): New function.
9489         * cli/cli-style.h (source_styling): Declare.
9490
9491 2019-03-14  Pedro Alves  <palves@redhat.com>
9492             Tom Tromey  <tromey@adacore.com>
9493
9494         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9495         * tui/tui-winsource.c (tui_refill_source_window): New function,
9496         from...
9497         (tui_horizontal_source_scroll): ... here.  Move some logic.
9498         * cli/cli-style.c (set_style_enabled): Notify new observable.
9499         * tui/tui-hooks.c (tui_redisplay_source): New function.
9500         (tui_attach_detach_observers): Attach or detach
9501         tui_redisplay_source.
9502         * observable.h (source_styling_changed): New observable.
9503         * observable.c: Define source_styling_changed observable.
9504
9505 2019-03-13  Tom Tromey  <tromey@adacore.com>
9506
9507         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9508         (i386_gnu_nat_target::store_registers): Update.
9509         * target-debug.h (target_debug_print_std_string): New macro.
9510         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9511         * windows-tdep.c (display_one_tib): Update.
9512         * tui/tui-stack.c (tui_make_status_line): Update.
9513         * top.c (print_inferior_quit_action): Update.
9514         * thread.c (thr_try_catch_cmd): Update.
9515         (add_thread_with_info): Update.
9516         (thread_target_id_str): Update.
9517         (thr_try_catch_cmd): Update.
9518         (thread_command): Update.
9519         (thread_find_command): Update.
9520         * record-btrace.c (record_btrace_target::info_record)
9521         (record_btrace_resume_thread, record_btrace_target::resume)
9522         (record_btrace_cancel_resume, record_btrace_step_thread)
9523         (record_btrace_target::wait, record_btrace_target::wait)
9524         (record_btrace_target::wait, record_btrace_target::stop): Update.
9525         * progspace.c (print_program_space): Update.
9526         * process-stratum-target.c
9527         (process_stratum_target::thread_address_space): Update.
9528         * linux-fork.c (linux_fork_mourn_inferior)
9529         (detach_checkpoint_command, info_checkpoints_command)
9530         (linux_fork_context): Update.
9531         (linux_fork_detach): Update.
9532         (class scoped_switch_fork_info): Update.
9533         (delete_checkpoint_command): Update.
9534         * infrun.c (follow_fork_inferior): Update.
9535         (follow_fork_inferior): Update.
9536         (proceed_after_vfork_done): Update.
9537         (handle_vfork_child_exec_or_exit): Update.
9538         (follow_exec): Update.
9539         (displaced_step_prepare_throw): Update.
9540         (displaced_step_restore): Update.
9541         (start_step_over): Update.
9542         (resume_1): Update.
9543         (clear_proceed_status_thread): Update.
9544         (proceed): Update.
9545         (print_target_wait_results): Update.
9546         (do_target_wait): Update.
9547         (context_switch): Update.
9548         (stop_all_threads): Update.
9549         (restart_threads): Update.
9550         (finish_step_over): Update.
9551         (handle_signal_stop): Update.
9552         (switch_back_to_stepped_thread): Update.
9553         (keep_going_pass_signal): Update.
9554         (print_exited_reason): Update.
9555         (normal_stop): Update.
9556         * inferior.c (inferior_pid_to_str): Change return type.
9557         (print_selected_inferior): Update.
9558         (add_inferior): Update.
9559         (detach_inferior): Update.
9560         * dummy-frame.c (fprint_dummy_frames): Update.
9561         * dcache.c (dcache_info_1): Update.
9562         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9563         (btrace_fetch, btrace_clear): Update.
9564         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9565         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9566         type.
9567         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9568         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9569         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9570         * gdbarch.c, gdbarch.h: Rebuild.
9571         * gdbarch.sh (core_pid_to_str): Change return type.
9572         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9573         return type.
9574         (windows_nat_target::pid_to_str): Change return type.
9575         (windows_delete_thread): Update.
9576         (windows_nat_target::attach): Update.
9577         (windows_nat_target::files_info): Update.
9578         * target-delegates.c: Rebuild.
9579         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9580         return type.
9581         (sol_thread_target::pid_to_str): Change return type.
9582         * remote.c (class remote_target) <pid_to_str>: Change return
9583         type.
9584         (remote_target::pid_to_str): Change return type.
9585         (extended_remote_target::attach, remote_target::remote_stop_ns)
9586         (remote_target::remote_notif_remove_queued_reply)
9587         (remote_target::push_stop_reply, remote_target::disable_btrace):
9588         Update.
9589         (extended_remote_target::attach): Update.
9590         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9591         type.
9592         (gdbsim_target::pid_to_str): Change return type.
9593         * ravenscar-thread.c (struct ravenscar_thread_target)
9594         <pid_to_str>: Change return type.
9595         (ravenscar_thread_target::pid_to_str): Change return type.
9596         * procfs.c (class procfs_target) <pid_to_str>: Change return
9597         type.
9598         (procfs_target::pid_to_str): Change return type.
9599         (procfs_target::attach): Update.
9600         (procfs_target::detach): Update.
9601         (procfs_target::fetch_registers): Update.
9602         (procfs_target::store_registers): Update.
9603         (procfs_target::wait): Update.
9604         (procfs_target::files_info): Update.
9605         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9606         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9607         return type.
9608         (nto_procfs_target::pid_to_str): Change return type.
9609         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9610         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9611         return type.
9612         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9613         (exit_lwp): Update.
9614         (attach_proc_task_lwp_callback, get_detach_signal)
9615         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9616         (linux_nat_target::resume, wait_lwp, stop_callback)
9617         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9618         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
9619         (linux_nat_wait_1, resume_stopped_resumed_lwps)
9620         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
9621         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
9622         type.
9623         (inf_ptrace_target::attach): Update.
9624         (inf_ptrace_target::files_info): Update.
9625         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
9626         type.
9627         (go32_nat_target::pid_to_str): Change return type.
9628         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
9629         (gnu_nat_target::wait): Update.
9630         (gnu_nat_target::wait): Update.
9631         (gnu_nat_target::resume): Update.
9632         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
9633         (fbsd_nat_target::wait): Update.
9634         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
9635         type.
9636         (darwin_nat_target::attach): Update.
9637         * corelow.c (class core_target) <pid_to_str>: Change return type.
9638         (core_target::pid_to_str): Change return type.
9639         * target.c (normal_pid_to_str): Change return type.
9640         (default_pid_to_str): Likewise.
9641         (target_pid_to_str): Change return type.
9642         (target_translate_tls_address): Update.
9643         (target_announce_detach): Update.
9644         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
9645         return type.
9646         (bsd_uthread_target::pid_to_str): Change return type.
9647         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
9648         type.
9649         (bsd_kvm_target::pid_to_str): Change return type.
9650         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
9651         return type.
9652         (aix_thread_target::pid_to_str): Change return type.
9653         * target.h (struct target_ops) <pid_to_str>: Change return type.
9654         (target_pid_to_str, normal_pid_to_str): Likewise.
9655         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
9656         type.
9657         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
9658         type.
9659         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
9660         return type.
9661         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
9662         type.
9663         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
9664         type.
9665         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
9666         return type.
9667
9668 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
9669
9670         * NEWS: Mention that the new default MI version is 3.  Mention
9671         changes to the output of commands and events that deal with
9672         multi-location breakpoints.
9673         * breakpoint.c: Include "mi/mi-out.h".
9674         (print_one_breakpoint): Change output syntax if using MI version
9675         >= 3.
9676         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
9677         New.
9678         (mi_multi_location_breakpoint_output_fixed): New.
9679         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
9680         (mi_cmd_fix_multi_location_breakpoint_output): New.
9681         (mi_multi_location_breakpoint_output_fixed): New.
9682         * mi/mi-cmds.c (mi_cmds): Register command
9683         -fix-multi-location-breakpoint-output.
9684         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
9685         interpreter "mi".
9686
9687 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
9688
9689         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
9690         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
9691         instantiate mi_ui_out based on interpreter name.
9692         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
9693         * mi/mi-main.c (mi_load_progress): Likewise.
9694
9695 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9696
9697         * NEWS: Combine separate "New targets" sections for 8.3.
9698
9699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9700
9701         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
9702         (ppcfbsd_init_abi): Install gdbarch
9703         "fetch_tls_load_module_address" and "get_thread_local_address"
9704         methods.
9705
9706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9707
9708         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
9709         (riscv_fbsd_init_abi): Install gdbarch
9710         "fetch_tls_load_module_address" and "get_thread_local_address"
9711         methods.
9712
9713 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9714
9715         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
9716         (i386fbsd_init_abi): Install gdbarch
9717         "fetch_tls_load_module_address" and "get_thread_local_address"
9718         methods.
9719
9720 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9721
9722         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
9723         (amd64fbsd_init_abi): Install gdbarch
9724         "fetch_tls_load_module_address" and "get_thread_local_address"
9725         methods.
9726
9727 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9728
9729         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
9730         (struct fbsd_pspace_data): New type.
9731         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
9732         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
9733         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
9734         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
9735         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
9736
9737 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9738
9739         * gdbtypes.c (lookup_struct_elt): New function.
9740         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
9741         * gdbtypes.h (struct struct_elt): New type.
9742         (lookup_struct_elt): New prototype.
9743
9744 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9745
9746         * gdbtypes.c (lookup_struct_elt_type): Update comment and
9747         remove disabled code block.
9748
9749 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9750
9751         * gdbarch.sh (get_thread_local_address): New method.
9752         * gdbarch.h, gdbarch.c: Regenerate.
9753         * target.c (target_translate_tls_address): Use
9754         gdbarch_get_thread_local_address if present instead of
9755         target::get_thread_local_address.
9756
9757 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9758
9759         * target.h (target::get_thread_local_address): Update comment.
9760
9761 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9762
9763         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
9764         objfile->separate_debug_objfile_backlink if not NULL.
9765
9766 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9767
9768         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
9769         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
9770         (amd64bsd_store_inferior_registers): Likewise.
9771         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9772         Enable segment base registers.
9773         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
9774         PT_GETFSBASE and PT_GETGSBASE.
9775         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
9776         PT_SETGSBASE.
9777         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
9778         segment base registers.
9779         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9780
9781 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
9782
9783         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
9784         Update calls to i386_target_description to add 'segments'
9785         parameter.
9786         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
9787         add segment base registers.
9788         * arch/i386.c (i386_create_target_description): Add 'segments'
9789         parameter to enable segment base registers.
9790         * arch/i386.h (i386_create_target_description): Likewise.
9791         * features/i386/32bit-segments.xml: New file.
9792         * features/i386/32bit-segments.c: Generate.
9793         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
9794         call to i386_target_description to add 'segments' parameter.
9795         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
9796         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
9797         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
9798         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
9799         if feature is present.
9800         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
9801         Add 'segments' parameter to call to i386_target_description.
9802         (i386_target_description): Add 'segments' parameter to enable
9803         segment base registers.
9804         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
9805         to call to i386_target_description.
9806         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
9807         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
9808         Define I386_NUM_REGS.
9809         (i386_target_description): Add 'segments' parameter to enable
9810         segment base registers.
9811
9812 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
9813
9814         PR/24325
9815         * source-cache.c: #undef open and close, to avoid unresolved
9816         externals during linking.
9817
9818 2019-03-12  Tom Tromey  <tromey@adacore.com>
9819
9820         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
9821         const.  Add initializers.
9822         (_initialize_remote): Don't initialize ptid globals.
9823
9824 2019-03-12  Pedro Alves  <palves@redhat.com>
9825
9826         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
9827
9828 2019-03-12  Pedro Alves  <palves@redhat.com>
9829
9830         * cp-name-parser.y (main): Remove unused 'len' variable.
9831
9832 2019-03-12  Tom Tromey  <tromey@adacore.com>
9833
9834         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
9835         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
9836
9837 2019-03-12  Tom Tromey  <tromey@adacore.com>
9838
9839         * linux-nat.c (iterate_over_lwps): Update.
9840         (stop_callback): Remove parameter.
9841         (stop_wait_callback, detach_callback, resume_set_callback)
9842         (select_singlestep_lwp_callback, set_ignore_sigint)
9843         (status_callback, resumed_callback, resume_clear_callback)
9844         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
9845         data parameter.
9846         (linux_nat_target::detach, linux_nat_target::resume)
9847         (linux_stop_and_wait_all_lwps, select_event_lwp)
9848         (linux_nat_filter_event, linux_nat_wait_1)
9849         (linux_nat_target::kill, linux_nat_target::stop)
9850         (linux_nat_target::stop): Update.
9851         (linux_nat_resume_callback): Change type.
9852         (resume_stopped_resumed_lwps, count_events_callback)
9853         (select_event_lwp_callback): Likewise.
9854         (linux_stop_lwp, linux_nat_stop_lwp): Update.
9855         * arm-linux-nat.c (struct update_registers_data): Remove.
9856         (update_registers_callback): Change type.
9857         (arm_linux_insert_hw_breakpoint1): Update.
9858         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
9859         parameter.
9860         (x86_linux_dr_set_addr): Update.
9861         (x86_linux_dr_set_control): Update.
9862         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
9863         (iterate_over_lwps): Use gdb::function_view.
9864         * nat/aarch64-linux-hw-point.c (struct
9865         aarch64_dr_update_callback_param): Remove.
9866         (debug_reg_change_callback): Change type.
9867         (aarch64_notify_debug_reg_change): Update.
9868         * s390-linux-nat.c (s390_refresh_per_info): Update.
9869
9870 2019-03-11  Tom Tromey  <tromey@adacore.com>
9871
9872         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
9873         redundant assignment to "this_cu".
9874
9875 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9876
9877         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
9878
9879 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9880
9881         * gdbtypes.c (rank_one_type_parm_set): New function extracted
9882         from...
9883         (rank_one_type): ... this.
9884
9885 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9886
9887         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
9888         from...
9889         (rank_one_type): ... this.
9890
9891 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9892
9893         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
9894         from...
9895         (rank_one_type): ... this.
9896
9897 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9898
9899         * gdbtypes.c (rank_one_type_parm_float): New function extracted
9900         from...
9901         (rank_one_type): ... this.
9902
9903 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9904
9905         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
9906         from...
9907         (rank_one_type): ... this.
9908
9909 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9910
9911         * gdbtypes.c (rank_one_type_parm_range): New function extracted
9912         from...
9913         (rank_one_type): ... this.
9914
9915 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9916
9917         * gdbtypes.c (rank_one_type_parm_char): New function extracted
9918         from...
9919         (rank_one_type): ... this.
9920
9921 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9922
9923         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
9924         from...
9925         (rank_one_type): ... this.
9926
9927 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9928
9929         * gdbtypes.c (rank_one_type_parm_int): New function extracted
9930         from...
9931         (rank_one_type): ... this.
9932
9933 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9934
9935         * gdbtypes.c (rank_one_type_parm_func): New function extracted
9936         from...
9937         (rank_one_type): ... this.
9938
9939 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9940
9941         * gdbtypes.c (rank_one_type_parm_array): New function extracted
9942         from...
9943         (rank_one_type): ... this.
9944
9945 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
9946
9947         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
9948         from...
9949         (rank_one_type): ... this.
9950
9951 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9952
9953         * inferior.c (initialize_inferiors): Ensure 'help set/show print
9954         inferior-events' shows the example events.
9955
9956 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
9957
9958         Support styling on native MS-Windows console
9959
9960         PR/24315
9961         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
9962         on MS-Windows if $TERM is not defined.
9963
9964         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
9965
9966         * posix-hdep.c (gdb_console_fputs):
9967         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
9968         functions.
9969         * ui-file.h (gdb_console_fputs): Add prototype.
9970
9971         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
9972         back to fputs only if the former returns zero.
9973
9974 2019-03-07  Tom Tromey  <tom@tromey.com>
9975
9976         * symmisc.c (print_symbol_bcache_statistics): Update.
9977         (print_objfile_statistics): Update.
9978         * symfile.c (allocate_symtab): Update.
9979         * stabsread.c: Don't include bcache.h.
9980         * psymtab.h (struct psymbol_bcache): Don't declare.
9981         (class psymtab_storage) <psymbol_cache>: Now a bcache.
9982         (psymbol_bcache_init, psymbol_bcache_free)
9983         (psymbol_bcache_get_bcache): Don't declare.
9984         * psymtab.c (struct psymbol_bcache): Remove.
9985         (psymtab_storage::psymtab_storage): Update.
9986         (psymtab_storage::~psymtab_storage): Update.
9987         (psymbol_bcache_init, psymbol_bcache_free)
9988         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
9989         (add_psymbol_to_bcache): Update.
9990         (allocate_psymtab): Update.
9991         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
9992         macro_cache>: No longer pointers.
9993         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
9994         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
9995         * macrotab.c (macro_bcache): Update.
9996         * macroexp.c: Don't include bcache.h.
9997         * gdbtypes.c (check_types_worklist): Update.
9998         (types_deeply_equal): Remove TRY/CATCH.  Update.
9999         * elfread.c (elf_symtab_read): Update.
10000         * dwarf2read.c: Don't include bcache.h.
10001         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10002         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10003         (print_bcache_statistics, bcache_memory_used): Don't declare.
10004         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10005         methods.  Rename all data members.
10006         * bcache.c (struct bcache): Move to bcache.h.
10007         (bcache::expand_hash_table): Rename from expand_hash_table.
10008         (bcache): Remove.
10009         (bcache::insert): Rename from bcache_full.
10010         (bcache::compare): Rename from bcache_compare.
10011         (bcache_xmalloc): Remove.
10012         (bcache::~bcache): Rename from bcache_xfree.
10013         (bcache::print_statistics): Rename from print_bcache_statistics.
10014         (bcache::memory_used): Rename from bcache_memory_used.
10015
10016 2019-03-07  Pedro Alves  <palves@redhat.com>
10017
10018         * infrun.c (normal_stop): Also check for
10019         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10020
10021 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10022
10023         * f-lang.c (value_from_host_double): Moved to...
10024         * value.c (value_from_host_double): ...here.
10025         * value.h (value_from_host_double): Declare.
10026         * guile/scm-math.c (vlscm_convert_typed_number): Use
10027         value_from_host_double.
10028         (vlscm_convert_number): Likewise.
10029         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10030         * python/py-value.c (convert_value_from_python): Likewise.
10031
10032 2019-03-06  Tom Tromey  <tom@tromey.com>
10033
10034         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10035
10036 2019-03-06  Tom Tromey  <tom@tromey.com>
10037
10038         * utils.h (free_current_contents): Don't declare.
10039         * utils.c (free_current_contents): Remove.
10040
10041 2019-03-06  Tom Tromey  <tom@tromey.com>
10042
10043         * top.c (quit_force): Update.
10044         * main.c (captured_command_loop): Update.
10045         * common/new-op.c (operator new): Update.
10046         * common/common-exceptions.c (struct catcher)
10047         <save_cleanup_chain>: Remove member.
10048         (exceptions_state_mc_init): Update.
10049         (exception_try_scope_entry): Return nullptr.
10050         (exception_try_scope_exit, exception_rethrow)
10051         (throw_exception_sjlj, throw_exception_cxx): Update.
10052         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10053         (all_cleanups, do_cleanups, discard_cleanups)
10054         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10055         (restore_cleanups, restore_final_cleanups): Don't declare.
10056         (do_final_cleanups): Remove parameter.
10057         * common/cleanups.c (cleanup_chain, make_cleanup)
10058         (make_cleanup_dtor, all_cleanups, do_cleanups)
10059         (discard_my_cleanups, discard_cleanups)
10060         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10061         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10062         (null_cleanup): Remove.
10063         (do_final_cleanups): Remove parameter.
10064
10065 2019-03-06  Tom Tromey  <tom@tromey.com>
10066
10067         * remote.c (remote_target::remote_parse_stop_reply): Use
10068         unique_xmalloc_ptr.
10069
10070 2019-03-06  Tom Tromey  <tom@tromey.com>
10071
10072         * stabsread.c (struct stabs_field_info): Rename from field_info.
10073         <list, fnlist>: Add initializers.
10074         <obstack>: New member.
10075         (read_member_functions, read_struct_fields, read_baseclasses):
10076         Allocate on obstack.  Don't use cleanups.
10077         (read_one_struct_field, read_member_functions, read_struct_fields)
10078         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10079         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10080         (read_struct_type): Update.
10081
10082 2019-03-06  Tom Tromey  <tom@tromey.com>
10083
10084         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10085         * common/filestuff.h (make_cleanup_close): Don't declare.
10086         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10087         Remove.
10088
10089 2019-03-06  Tom Tromey  <tom@tromey.com>
10090
10091         * solib-aix.c: Use make_scope_exit.
10092
10093 2019-03-06  Tom Tromey  <tom@tromey.com>
10094
10095         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10096         Use make_scope_exit.
10097
10098 2019-03-06  Tom Tromey  <tom@tromey.com>
10099
10100         * solib-svr4.c (disable_probes_interface): Remove parameter.
10101         (svr4_handle_solib_event): Use make_scope_exit.
10102
10103 2019-03-06  Tom Tromey  <tom@tromey.com>
10104
10105         * remote.c (struct stop_reply_deleter): Remove.
10106         (stop_reply_up): Update.
10107         (struct stop_reply): Derive from notif_event.  Don't typedef.
10108         <regcache>: Now a std::vector.
10109         (stop_reply_xfree): Remove.
10110         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10111         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10112         (remote_target::discard_pending_stop_replies): Use delete.
10113         (remote_target::remote_parse_stop_reply): Update.
10114         (remote_target::process_stop_reply): Update.
10115         * remote-notif.h (struct notif_event): Add virtual destructor.
10116         Remove "dtr" member.
10117         (struct notif_client) <alloc_event>: Return a unique_ptr.
10118         (notif_event_xfree): Don't declare.
10119         (notif_event_up): New typedef.
10120         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10121         (notif_event_xfree, do_notif_event_xfree): Remove.
10122         (remote_notif_state_xfree): Update.
10123
10124 2019-03-06  Tom Tromey  <tom@tromey.com>
10125
10126         * infrun.c (displaced_step_clear_cleanup): Now a
10127         forward_scope_exit type.
10128         (displaced_step_prepare_throw): Update.
10129         (displaced_step_fixup): Update.
10130
10131 2019-03-06  Tom Tromey  <tom@tromey.com>
10132
10133         * inferior.h (class inferior): Update comment.
10134         * gdbthread.h (class thread_info): Update comment.
10135
10136 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10137             Tom Tromey  <tom@tromey.com>
10138
10139         * stabsread.h (struct stab_section_list): Remove.
10140         (coffstab_build_psymtabs): Update.
10141         * dbxread.c (symbuf_sections): Now a std::vector.
10142         (sect_idx): New global.
10143         (fill_symbuf): Update.
10144         (coffstab_build_psymtabs): Change type of stabsects parameter.
10145         Update.
10146         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10147         std::vector.
10148         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10149         (coff_locate_sections): Update.
10150         (coff_symfile_read): Remove cleanups.  Update.
10151         (init_stringtab): Add storage parameter.
10152         (free_stringtab, free_stringtab_cleanup): Remove.
10153         (init_lineno): Add storage parameter.
10154         (free_linetab, free_linetab_cleanup): Remove.
10155
10156 2019-03-06  Pedro Alves  <palves@redhat.com>
10157
10158         * linux-fork.c (fork_info::clobber_regs): Delete.
10159         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10160         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10161         comment.  Adjust.
10162         (scoped_switch_fork_info::scoped_switch_fork_info)
10163         (checkpoint_command, linux_fork_context): Adjust
10164         fork_save_infrun_state calls.
10165
10166 2019-03-06  Pedro Alves  <palves@redhat.com>
10167
10168         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10169         (inf_has_multiple_threads): Return 'bool' and rewrite using
10170         inferior_info::threads().
10171
10172 2019-03-06  Pedro Alves  <palves@redhat.com>
10173
10174         * linux-fork.c: Include <list>.
10175         (fork_list): Now a std::list instance.
10176         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10177         (forks_exist_p, find_last_fork): Adjust.
10178         (new_fork): Delete.
10179         (one_fork_p): New.
10180         (add_fork): Adjust.
10181         (free_fork): Delete, folded into fork_info::~fork_info().
10182         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10183         Adjust.
10184         (init_fork_list): Delete.
10185         (linux_fork_killall, linux_fork_mourn_inferior)
10186         (linux_fork_detach, info_checkpoints_command): Adjust.
10187         (_initialize_linux_fork): No longer call init_fork_list.
10188
10189 2019-03-06  Pedro Alves  <palves@redhat.com>
10190
10191         * linux-fork.c (new_fork): New, split out of ...
10192         (add_fork): ... this.  Return void.  Move "first fork" special
10193         case from here, to ...
10194         (checkpoint_command): ... here.
10195         * linux-linux.h (add_fork): Return void.
10196
10197 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10198
10199         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10200
10201 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10202             Chris January  <chris.january@arm.com>
10203             David Lecomber  <david.lecomber@arm.com>
10204
10205         * f-exp.y: New token, UNOP_INTRINSIC.
10206         (exp): New pattern using UNOP_INTRINSIC token.
10207         (f77_keywords): Add 'abs' keyword.
10208         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10209         (value_from_host_double): New function.
10210         (evaluate_subexp_f): Support UNOP_ABS.
10211
10212 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10213
10214         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10215         types.
10216
10217 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10218
10219         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10220         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10221         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10222
10223 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10224
10225         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10226
10227 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10228             Chris January  <chris.january@arm.com>
10229
10230         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10231         * f-exp.y: Define 'KIND' token.
10232         (exp): New pattern for KIND expressions.
10233         (ptype): Handle types with a kind extension.
10234         (direct_abs_decl): Extend to spot kind extensions.
10235         (f77_keywords): Add 'kind' to the list.
10236         (push_kind_type): New function.
10237         (convert_to_kind_type): New function.
10238         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10239         * parse.c (operator_length_standard): Likewise.
10240         * parser-defs.h (enum type_pieces): Add tp_kind.
10241         * std-operator.def: Add UNOP_KIND.
10242
10243 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10244
10245         * f-exp.y (f_parse): Set yydebug.
10246
10247 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10248
10249         * f-lang.c (evaluate_subexp_f): New function.
10250         (exp_descriptor_f): New global.
10251         (f_language_defn): Use exp_descriptor_f instead of
10252         exp_descriptor_standard.
10253
10254 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10255
10256         * f-exp.y (struct token): Add comments.
10257         (dot_ops): Remove uppercase versions and the end marker.
10258         (f77_keywords): Likewise.
10259         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10260         entries in the dot_ops array are case insensitive, and use
10261         strncasecmp to compare strings.  Also some whitespace cleanup in
10262         this area.  Similar for the f77_keywords array, except entries in
10263         this list might be case sensitive.
10264
10265 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10266
10267         * f-exp.y (struct f77_boolean_val): Add comments.
10268         (boolean_values): Remove uppercase versions, and end marker.
10269         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10270         and use strncasecmp to achieve case insensitivity.  Additionally,
10271         perform whitespace cleanup around this code.
10272
10273 2019-03-06  Tom Tromey  <tromey@adacore.com>
10274
10275         * remote-sim.c (gdbsim_target_open): Use result of
10276         gdb_argv::release.
10277
10278 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10279         Dirk Schubert  <dirk.schubert@arm.com>
10280         Chris January  <chris.january@arm.com>
10281
10282         * eval.c (evaluate_subexp_standard): Call Fortran argument
10283         wrapping logic.
10284         * f-lang.c (struct value): A value which can be passed into a
10285         Fortran function call.
10286         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10287         where appropriate.
10288         (struct type): Value ready for a Fortran function call.
10289         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10290         is needed.
10291         * f-lang.h (fortran_argument_convert): Declaration.
10292         (fortran_preserve_arg_pointer): Declaration.
10293         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10294
10295 2019-03-05  Tom Tromey  <tromey@adacore.com>
10296
10297         * python/py-prettyprint.c (print_string_repr): Remove #if.
10298         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10299
10300 2019-03-05  Tom Tromey  <tromey@adacore.com>
10301
10302         * target.c (the_dummy_target): Move later.  Change type to
10303         "dummy_target".
10304         (initialize_targets): Don't initialize the_dummy_target.
10305
10306 2019-03-05  Tom Tromey  <tromey@adacore.com>
10307
10308         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10309         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10310
10311 2019-03-05  Tom Tromey  <tromey@adacore.com>
10312
10313         * windows-nat.c (windows_nat_target::attach)
10314         (windows_nat_target::detach): Don't call gdb_flush.
10315         * valprint.c (generic_val_print, val_print, val_print_string):
10316         Don't call gdb_flush.
10317         * utils.c (defaulted_query): Don't call gdb_flush.
10318         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10319         * target.c (target_announce_detach): Don't call gdb_flush.
10320         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10321         * remote.c (extended_remote_target::attach): Don't call
10322         gdb_flush.
10323         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10324         * printcmd.c (do_examine): Don't call gdb_flush.
10325         (info_display_command): Don't call gdb_flush.
10326         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10327         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10328         * memattr.c (info_mem_command): Don't call gdb_flush.
10329         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10330         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10331         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10332         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10333         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10334         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10335         (gnu_nat_target::detach): Don't call gdb_flush.
10336         * f-valprint.c (f_val_print): Don't call gdb_flush.
10337         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10338         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10339         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10340         gdb_flush.
10341         * c-valprint.c (c_val_print): Don't call gdb_flush.
10342         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10343
10344 2019-03-05  Tom Tromey  <tromey@adacore.com>
10345
10346         * varobj.c (update_dynamic_varobj_children): Update.
10347         (install_default_visualizer): Use reset, not release.
10348         * value.c (set_internalvar): Update.
10349         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10350         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10351         ATTRIBUTE_UNUSED_RESULT.
10352
10353 2019-03-05  Tom Tromey  <tromey@adacore.com>
10354
10355         * remote.c (class scoped_remote_fd) <release>: Add
10356         ATTRIBUTE_UNUSED_RESULT.
10357
10358 2019-03-05  Tom Tromey  <tromey@adacore.com>
10359
10360         * macroexp.c (struct macro_buffer) <release>: Add
10361         ATTRIBUTE_UNUSED_RESULT.
10362
10363 2019-03-05  Tom Tromey  <tromey@adacore.com>
10364
10365         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10366         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10367         ATTRIBUTE_UNUSED_RESULT.
10368
10369 2019-03-05  Tom Tromey  <tromey@adacore.com>
10370
10371         * common/scoped_fd.h (class scoped_fd) <release>: Add
10372         ATTRIBUTE_UNUSED_RESULT.
10373
10374 2019-03-05  Tom Tromey  <tromey@adacore.com>
10375
10376         * parser-defs.h (struct parser_state) <release>: Add
10377         ATTRIBUTE_UNUSED_RESULT.
10378
10379 2019-03-05  Tom Tromey  <tromey@adacore.com>
10380
10381         * utils.h (class gdb_argv) <release>: Add
10382         ATTRIBUTE_UNUSED_RESULT.
10383         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10384
10385 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10386
10387         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10388         for-loop range, to avoid compiler warnings.
10389
10390         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10391         avoid compiler warnings about unused variables.
10392
10393         * NEWS: Mention end of support for native debugging on MS-Windows
10394         before XP.
10395
10396         PR gdb/24292
10397         * common/netstuff.c:
10398         * gdbserver/gdbreplay.c
10399         * gdbserver/remote-utils.c:
10400         * ser-tcp.c:
10401         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10402         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10403         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10404         'getaddrinfo' and 'freeaddrinfo' were not available before
10405         Windows XP, and mingw.org's MinGW headers by default define
10406         _WIN32_WINNT to 0x500.
10407
10408 2019-03-01  Gary Benson <gbenson@redhat.com>
10409
10410         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10411
10412 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10413             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10414
10415         PR gdb/8527
10416         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10417         set_sigint_trap, clear_sigint_trap.
10418
10419 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10420
10421         * target.c (target_detach): Clear the regcache and the
10422         frame cache.
10423
10424 2019-02-27  Pedro Alves  <palves@redhat.com>
10425
10426         * utils.c (set_screen_size): When we cap the height/width sizes,
10427         tweak the corresponding command variable to show "unlimited":
10428
10429 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10430             Pedro Alves  <palves@redhat.com>
10431
10432         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10433         before calling rl_set_screen_size.
10434
10435 2019-02-27  Tom Tromey  <tromey@adacore.com>
10436
10437         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10438         define.
10439         * python/py-value.c: Remove Python 2.4 workaround.
10440         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10441         workaround.
10442         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10443         Python 2.4 workaround.
10444         * python/python-internal.h: Remove Python 2.4 comment.
10445         (Py_ssize_t): Don't define.
10446         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10447         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10448         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10449         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10450         * python/python.c (do_start_initialization): Remove Python 2.4
10451         workaround.
10452         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10453         (print_children): Remove Python 2.4 workaround.
10454         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10455         workaround.
10456         (CHARBUFFERPROC_NAME): Remove.
10457         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10458         Python 2.4 workaround.
10459
10460 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10461
10462         * NEWS: Note minimum Python version.
10463
10464 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10465
10466         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10467         code from these functions.  Remove corresponding ifdefs.  Use
10468         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10469         Remove gotos and target of gotos.
10470         (infpy_search_memory): Likewise.
10471
10472 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10473
10474         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10475         (hppa_gdbarch_init): Don't register deleted functions with
10476         gdbarch.
10477
10478 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10479
10480         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10481         (h8300_unwind_sp): Delete.
10482         (h8300_dummy_id): Delete.
10483         (h8300_gdbarch_init): Don't register deleted functions with
10484         gdbarch.
10485
10486 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10487
10488         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10489         (ft32_unwind_pc): Delete.
10490         (ft32_unwind_sp): Delete.
10491         (ft32_gdbarch_init): Don't register deleted functions with
10492         gdbarch.
10493
10494 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10495
10496         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10497         (frv_unwind_pc): Delete.
10498         (frv_unwind_sp): Delete.
10499         (frv_gdbarch_init): Don't register deleted functions with
10500         gdbarch.
10501
10502 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10503
10504         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10505         (riscv_unwind_pc): Delete.
10506         (riscv_unwind_sp): Delete.
10507         (riscv_gdbarch_init): Don't register deleted functions with
10508         gdbarch.
10509
10510 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10511
10512         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10513         (csky_unwind_pc): Delete.
10514         (csky_unwind_sp): Delete.
10515         (csky_gdbarch_init): Don't register deleted functions with
10516         gdbarch.
10517
10518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10519
10520         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10521         (cris_unwind_pc): Delete.
10522         (cris_unwind_sp): Delete.
10523         (cris_gdbarch_init): Don't register deleted functions with
10524         gdbarch.
10525
10526 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10527
10528         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10529         (bfin_unwind_pc): Delete.
10530         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10531
10532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10533
10534         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10535         (arm_unwind_pc): Delete.
10536         (arm_unwind_sp): Delete.
10537         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10538
10539 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10540
10541         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10542         (arc_unwind_pc): Delete.
10543         (arc_unwind_sp): Delete.
10544         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10545
10546 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10547
10548         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10549         (alpha_unwind_pc): Delete.
10550         (alpha_gdbarch_init): Don't register deleted functions with
10551         gdbarch.
10552
10553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10554
10555         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10556         (aarch64_unwind_pc): Delete.
10557         (aarch64_unwind_sp): Delete.
10558         (aarch64_gdbarch_init): Don't register deleted functions with
10559         gdbarch.
10560
10561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10562
10563         * gdbtypes.c (type_align): Don't consider static members when
10564         computing structure alignment.
10565
10566 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10567
10568         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10569         return 0 for other types.
10570         * arch-utils.c (default_type_align): Always return 0.
10571         * gdbarch.h: Regenerate.
10572         * gdbarch.sh (type_align): Extend comment.
10573         * gdbtypes.c (type_align): Add additional comments, always call
10574         gdbarch_type_align before applying the default rules.
10575         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10576         generic code will then apply a suitable default.
10577         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10578         types, return 0 for other types.
10579
10580 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10581
10582         * NEWS: Create a new section for the next release branch.
10583         Rename the section of the current branch, now that it has
10584         been cut.
10585
10586 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10587
10588         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10589         * version.in: Bump version to 8.3.50.DATE-git.
10590
10591 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10592
10593         * aix-thread.c (ptid_cmp): Remove unused variable.
10594         (get_signaled_thread): Likewise.
10595         (store_regs_user_thread): Likewise.
10596         (store_regs_kernel_thread): Likewise.
10597         (fetch_regs_kernel_thread): Remove shadowed variable.
10598
10599 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10600
10601         * features/riscv/32bit-cpu.xml: Add register numbers.
10602         * features/riscv/32bit-fpu.c: Regenerate.
10603         * features/riscv/32bit-fpu.xml: Add register numbers.
10604         * features/riscv/64bit-cpu.xml: Add register numbers.
10605         * features/riscv/64bit-fpu.c: Regenerate.
10606         * features/riscv/64bit-fpu.xml: Add register numbers.
10607
10608 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10609
10610         * NEWS: Mention two argument form of gdb.Value constructor.
10611         * python/py-value.c (convert_buffer_and_type_to_value): New
10612         function.
10613         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10614         Add support for handling an optional second argument.  Call
10615         convert_buffer_and_type_to_value as appropriate.
10616         * python/python-internal.h (Py_buffer_deleter): New struct.
10617         (Py_buffer_up): New typedef.
10618
10619 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
10620
10621         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
10622         instead of releasing ownership.
10623
10624 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
10625
10626         * dwarf2read.c (open_and_init_dwp_file): Call
10627         elf_numsections instead of bfd_count_sections to initialize
10628         dwp_file->num_sections.
10629
10630 2019-02-25  Tom Tromey  <tromey@adacore.com>
10631
10632         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
10633
10634 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
10635
10636         * gcore.in: Add '--readnever' option when invoking GDB.
10637
10638 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10639
10640         * MAINTAINERS: Update my email address.
10641
10642 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
10643
10644         * build-id.c (build_id_to_debug_bfd_1): New function.
10645         (build_id_to_debug_bfd): Look for separate debug file in
10646         sysroot.
10647
10648 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
10649
10650         * gdbarch.sh: Update the copyright year range that is placed into
10651         generated files.
10652
10653 2019-02-22  Keith Seitz  <keiths@redhat.com>
10654
10655         PR symtab/23853
10656         * linespec.c (create_sals_line_offset): Search for the default
10657         symtab's filename instead of its fullname.
10658
10659 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10660
10661         * NEWS: Update style defaults.
10662
10663 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
10664
10665         * main.c (captured_main_1): Disable styling in batch mode.
10666
10667 2019-02-20  Tom Tromey  <tom@tromey.com>
10668
10669         * symtab.c (symtab_symbol_info): Fix typos.
10670
10671 2019-02-20  Tom Tromey  <tromey@adacore.com>
10672
10673         * findcmd.c (_initialize_mem_search): Use upper case for
10674         metasyntactic variables.
10675
10676 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
10677
10678         * aarch64-tdep.c (aarch64_add_reggroups): New function.
10679         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
10680
10681 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
10682
10683         * top.h (source_file_name): Change to std::string.
10684         * top.c (source_file_name): Likewise.
10685         (command_line_input): Adjust.
10686         * cli/cli-script.c (script_from_file): Adjust.
10687
10688 2019-02-19  Tom Tromey  <tromey@adacore.com>
10689
10690         * ravenscar-thread.c
10691         (ravenscar_thread_target::update_thread_list): Don't call
10692         ada_build_task_list.
10693         * ada-lang.h (ada_build_task_list): Don't declare.
10694         * ada-tasks.c (struct ada_tasks_inferior_data)
10695         <task_list_valid_p>: Now bool.
10696         (read_known_tasks, ada_task_list_changed)
10697         (ada_tasks_invalidate_inferior_data): Update.
10698         (read_known_tasks_array): Return bool.
10699         (read_known_tasks_list): Likewise.
10700         (read_known_tasks): Return void.
10701         (ada_build_task_list): Now static.
10702
10703 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10704
10705         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
10706         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
10707
10708 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10709
10710         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
10711         variant for ada_tasks_pspace_data_handle and
10712         ada_tasks_inferior_data_handle.
10713         (ada_tasks_pspace_data_cleanup): New function.
10714         (ada_tasks_inferior_data_cleanup): New function.
10715
10716 2019-02-17  Tom Tromey  <tom@tromey.com>
10717
10718         * macrotab.h (macro_source_fullname): Return a std::string.
10719         * macrotab.c (macro_include, check_for_redefinition)
10720         (macro_undef, macro_lookup_definition, foreach_macro)
10721         (foreach_macro_in_scope): Update.
10722         (macro_source_fullname): Return a std::string.
10723         * macrocmd.c (show_pp_source_pos): Update.
10724
10725 2019-02-17  Tom Tromey  <tom@tromey.com>
10726
10727         * macrocmd.c (show_pp_source_pos): Style the file names.
10728
10729 2019-02-17  Tom Tromey  <tom@tromey.com>
10730
10731         PR tui/24197:
10732         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
10733
10734 2019-02-17  Tom Tromey  <tom@tromey.com>
10735
10736         * ada-lang.c (user_select_syms): Use filtered printing.
10737         * utils.c (wrap_style): New global.
10738         (desired_style): Remove.
10739         (emit_style_escape): Add stream parameter.
10740         (set_output_style, reset_terminal_style, prompt_for_continue):
10741         Update.
10742         (flush_wrap_buffer): Only flush gdb_stdout.
10743         (wrap_here): Set wrap_style.
10744         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
10745         treat escape sequences as a character.  Change when wrap buffer is
10746         flushed.
10747         (fputs_styled): Do not set the output style when the default is
10748         requested.
10749         * ui-style.h (struct ui_file_style) <is_default>: New method.
10750         * source.c (print_source_lines_base): Emit escape sequences in one
10751         piece.
10752
10753 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10754
10755         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
10756         integers and enumeration types.
10757
10758 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
10759
10760         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
10761         instead of lookup_symbol_in_language
10762         (do_exact_match): New function.
10763         (ada_get_symbol_name_matcher): Return do_exact_match when
10764         doing a verbatim match.
10765
10766 2019-02-15  Tom Tromey  <tromey@adacore.com>
10767
10768         * ravenscar-thread.c (ravenscar_thread_target::resume)
10769         (ravenscar_thread_target::wait): Special case wildcard requests.
10770
10771 2019-02-15  Tom Tromey  <tromey@adacore.com>
10772
10773         * ravenscar-thread.c (base_ptid): Remove.
10774         (struct ravenscar_thread_target) <close>: New method.
10775         <m_base_ptid>: New member.
10776         <update_inferior_ptid, active_task, task_is_currently_active,
10777         runtime_initialized>: Declare methods.
10778         <ravenscar_thread_target>: Add constructor.
10779         (ravenscar_thread_target::task_is_currently_active)
10780         (ravenscar_thread_target::update_inferior_ptid)
10781         (ravenscar_runtime_initialized): Rename.  Now methods.
10782         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
10783         (ravenscar_thread_target::update_thread_list): Update.
10784         (ravenscar_thread_target::active_task): Now method.
10785         (ravenscar_thread_target::store_registers)
10786         (ravenscar_thread_target::prepare_to_store)
10787         (ravenscar_thread_target::prepare_to_store)
10788         (ravenscar_thread_target::mourn_inferior): Update.
10789         (ravenscar_inferior_created): Use "new" to create target.
10790         (ravenscar_thread_target::get_ada_task_ptid): Update.
10791         (_initialize_ravenscar): Don't initialize base_ptid.
10792         (ravenscar_ops): Remove global.
10793
10794 2019-02-15  Tom Tromey  <tromey@adacore.com>
10795
10796         * target.h (push_target): Declare new overload.
10797         * target.c (push_target): New overload, taking an rvalue reference.
10798         * remote.c (remote_target::open_1): Use push_target overload.
10799         * corelow.c (core_target_open): Use push_target overload.
10800
10801 2019-02-15  Tom Tromey  <tromey@adacore.com>
10802
10803         * ravenscar-thread.c (is_ravenscar_task)
10804         (ravenscar_task_is_currently_active): Return bool.
10805         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
10806         (_initialize_ravenscar): Remove "(void)".
10807         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
10808         Return bool.
10809
10810 2019-02-15  Tom Tromey  <tromey@adacore.com>
10811
10812         * ravenscar-thread.c (ravenscar_runtime_initializer)
10813         (has_ravenscar_runtime, get_running_thread_id)
10814         (ravenscar_thread_target::resume): Fix indentation.
10815
10816 2019-02-15  Tom Tromey  <tromey@adacore.com>
10817
10818         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
10819         from ravenscar_arch_ops.
10820         (sparc_ravenscar_ops::fetch_registers)
10821         (sparc_ravenscar_ops::store_registers): Now methods.
10822         (sparc_ravenscar_prepare_to_store): Remove.
10823         (sparc_ravenscar_ops): Redefine.
10824         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
10825         methods and destructor.  Remove members.
10826         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
10827         (ravenscar_thread_target::store_registers)
10828         (ravenscar_thread_target::prepare_to_store): Update.
10829         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
10830         Remove.
10831         (struct ppc_ravenscar_powerpc_ops): Derive from
10832         ravenscar_arch_ops.
10833         (ppc_ravenscar_powerpc_ops::fetch_registers)
10834         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
10835         (ppc_ravenscar_powerpc_ops): Redefine.
10836         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
10837         (ppc_ravenscar_e500_ops::fetch_registers)
10838         (ppc_ravenscar_e500_ops::store_registers): Now methods.
10839         (ppc_ravenscar_e500_ops): Redefine.
10840         * aarch64-ravenscar-thread.c
10841         (aarch64_ravenscar_generic_prepare_to_store): Remove.
10842         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
10843         (aarch64_ravenscar_fetch_registers)
10844         (aarch64_ravenscar_store_registers): Now methods.
10845         (aarch64_ravenscar_ops): Redefine.
10846
10847 2019-02-15  Tom Tromey  <tromey@adacore.com>
10848
10849         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
10850         (ravenscar_thread_target::stopped_by_hw_breakpoint)
10851         (ravenscar_thread_target::stopped_by_watchpoint)
10852         (ravenscar_thread_target::stopped_data_address)
10853         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
10854
10855 2019-02-15  Tom Tromey  <tromey@adacore.com>
10856
10857         * ravenscar-thread.c: Fix some typos.
10858
10859 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10860             Tom Tromey  <tromey@adacore.com>
10861
10862         * ada-lang.c (ada_exception_sal): Change addr_string to a
10863         std::string.
10864         (create_ada_exception_catchpoint): Update.
10865
10866 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10867             Tom Tromey  <tromey@adacore.com>
10868
10869         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
10870         (bp_location_ops): Remove.
10871         (base_breakpoint_allocate_location): Update.
10872         (free_bp_location): Update.
10873         * ada-lang.c (class ada_catchpoint_location)
10874         <ada_catchpoint_location>: Remove ops parameter.
10875         (ada_catchpoint_location_dtor): Remove.
10876         (ada_catchpoint_location_ops): Remove.
10877         (allocate_location_exception): Update.
10878         * breakpoint.h (struct bp_location_ops): Remove.
10879         (class bp_location) <bp_location>: Remove bp_location_ops
10880         parameter.
10881         <~bp_location>: Add destructor.
10882         <ops>: Remove.
10883
10884 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10885             Pedro Alves  <palves@redhat.com>
10886
10887         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
10888         'PATH_MAX'.
10889
10890 2019-02-14  David Michael  <fedora.dm0@gmail.com>
10891             Samuel Thibault  <samuel.thibault@gnu.org>
10892             Thomas Schwinge  <thomas@codesourcery.com>
10893
10894         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
10895         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
10896
10897 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
10898
10899         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
10900         (check_empty): Use "const char *".
10901
10902         * gnu-nat.c (gnu_nat_target::detach): Instead of
10903         'detach_inferior (pid)' call
10904         'detach_inferior (find_inferior_pid (pid))'.
10905
10906         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
10907         'nat/fork-inferior.o'.
10908         * gnu-nat.c: #include "nat/fork-inferior.h".
10909
10910         * gnu-nat.c (gnu_nat_target::detach): Instead of
10911         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
10912         * gnu-nat.h: #include "inf-child.h".
10913         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
10914         'i386_gnu_nat_target::fetch_registers'.
10915         (gnu_store_registers): Rename/move to
10916         'i386_gnu_nat_target::store_registers'.
10917
10918         * config/i386/nm-i386gnu.h: Don't "#include" any files.
10919         * gnu-nat.h (mach_thread_info): New function.
10920         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
10921
10922         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
10923
10924 2019-02-14  Frederic Konrad  <konrad@adacore.com>
10925
10926         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
10927
10928 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
10929
10930         * windows-nat.c (windows_add_thread): Add new parameter
10931         "main_thread_p" with default value set to false.  Update
10932         function documentation as well as all callers.
10933         (windows_delete_thread): Likewise.
10934         (fake_create_process): Update call to windows_add_thread.
10935         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
10936         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
10937         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
10938         call to windows_delete_thread.
10939
10940 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
10941
10942         * MAINTAINERS: Add Andrew Burgess as global maintainer.
10943
10944 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10945
10946         * symfile.c (find_separate_debug_file): Use canonical path of
10947         sysroot with child_path instead of gdb_sysroot if it is valid.
10948
10949 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10950
10951         * symfile.c (find_separate_debug_file): Use child_path to
10952         determine if an object file is under a sysroot.
10953
10954 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10955
10956         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
10957         unittests/child-path-selftests.c.
10958         * common/pathstuff.c (child_path): New function.
10959         * common/pathstuff.h (child_path): New prototype.
10960         * unittests/child-path-selftests.c: New file.
10961
10962 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
10963
10964         * symfile.c (find_separate_debug_file): Look for separate debug
10965         files in debug directories under the sysroot.
10966
10967 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10968
10969         * symtab.h (struct minimal_symbol data_p): New const method.
10970         (struct minimal_symbol text_p): Likewise.
10971         * symtab.c (output_source_filename): Use file name style
10972         to print file name.
10973         (print_symbol_info): Likewise.
10974         (print_msymbol_info): Use address style to print addresses.
10975         Use function name style to print executable text symbols.
10976         (expand_symtab_containing_pc): Use data_p.
10977         (find_pc_sect_compunit_symtab): Likewise.
10978
10979 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10980
10981         * breakpoint.c (describe_other_breakpoints): Use address style
10982         to print addresses.
10983         (say_where): Likewise.
10984
10985 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10986
10987         * ada-typeprint.c (print_func_type): Print function name
10988         style to print function name.
10989         * c-typeprint.c (c_print_type_1): Likewise.
10990
10991 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
10992
10993         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
10994         for execve.
10995
10996 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10997
10998         * c-exp.y (direct_abs_decl): Use emplace_back to record the
10999         type_stack.
11000
11001 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11002
11003         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11004         TYPE_CODE_REF types.
11005
11006 2019-02-08  Jim Wilson  <jimw@sifive.com>
11007
11008         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11009         (riscv_linux_fregset): New.
11010         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11011
11012 2019-02-07  Tom Tromey  <tom@tromey.com>
11013
11014         * thread.c (thread_cancel_execution_command): Update.
11015         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11016         methods.
11017         (struct thread_fsm_ops): Remove.
11018         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11019         (thread_fsm_should_stop, thread_fsm_return_value)
11020         (thread_fsm_set_finished, thread_fsm_finished_p)
11021         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11022         Don't declare.
11023         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11024         * infrun.c (clear_proceed_status_thread)
11025         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11026         (print_stop_event): Update.
11027         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11028         Add constructor.
11029         (step_command_fsm_ops): Remove.
11030         (new_step_command_fsm): Remove.
11031         (step_1): Update.
11032         (step_command_fsm::should_stop): Rename from
11033         step_command_fsm_should_stop.
11034         (step_command_fsm::clean_up): Rename from
11035         step_command_fsm_clean_up.
11036         (step_command_fsm::do_async_reply_reason): Rename from
11037         step_command_fsm_async_reply_reason.
11038         (struct until_next_fsm): Inherit from thread_fsm.  Add
11039         constructor.
11040         (until_next_fsm_ops): Remove.
11041         (new_until_next_fsm): Remove.
11042         (until_next_fsm::should_stop): Rename from
11043         until_next_fsm_should_stop.
11044         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11045         (until_next_fsm::do_async_reply_reason): Rename from
11046         until_next_fsm_async_reply_reason.
11047         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11048         constructor.  Change type of breakpoint.
11049         (finish_command_fsm_ops): Remove.
11050         (new_finish_command_fsm): Remove.
11051         (finish_command_fsm::should_stop): Rename from
11052         finish_command_fsm_should_stop.
11053         (finish_command_fsm::clean_up): Rename from
11054         finish_command_fsm_clean_up.
11055         (finish_command_fsm::return_value): Rename from
11056         finish_command_fsm_return_value.
11057         (finish_command_fsm::do_async_reply_reason): Rename from
11058         finish_command_fsm_async_reply_reason.
11059         (finish_command): Update.
11060         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11061         Add constructor.
11062         (call_thread_fsm_ops): Remove.
11063         (call_thread_fsm::call_thread_fsm): Rename from
11064         new_call_thread_fsm.
11065         (call_thread_fsm::should_stop): Rename from
11066         call_thread_fsm_should_stop.
11067         (call_thread_fsm::should_notify_stop): Rename from
11068         call_thread_fsm_should_notify_stop.
11069         (run_inferior_call, call_function_by_hand_dummy): Update.
11070         * cli/cli-interp.c (should_print_stop_to_console): Update.
11071         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11072         Add constructor.  Change type of location_breakpoint,
11073         caller_breakpoint.
11074         (until_break_fsm_ops): Remove.
11075         (new_until_break_fsm): Remove.
11076         (until_break_fsm::should_stop): Rename from
11077         until_break_fsm_should_stop.
11078         (until_break_fsm::clean_up): Rename from
11079         until_break_fsm_clean_up.
11080         (until_break_fsm::do_async_reply_reason): Rename from
11081         until_break_fsm_async_reply_reason.
11082         (until_break_command): Update.
11083         * thread-fsm.c: Remove.
11084         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11085
11086 2019-02-07  Tom Tromey  <tom@tromey.com>
11087
11088         * yy-remap.h: Add include guard.
11089         * xtensa-tdep.h: Add include guard.
11090         * xcoffread.h: Rename include guard.
11091         * varobj-iter.h: Add include guard.
11092         * tui/tui.h: Rename include guard.
11093         * tui/tui-winsource.h: Rename include guard.
11094         * tui/tui-wingeneral.h: Rename include guard.
11095         * tui/tui-windata.h: Rename include guard.
11096         * tui/tui-win.h: Rename include guard.
11097         * tui/tui-stack.h: Rename include guard.
11098         * tui/tui-source.h: Rename include guard.
11099         * tui/tui-regs.h: Rename include guard.
11100         * tui/tui-out.h: Rename include guard.
11101         * tui/tui-layout.h: Rename include guard.
11102         * tui/tui-io.h: Rename include guard.
11103         * tui/tui-hooks.h: Rename include guard.
11104         * tui/tui-file.h: Rename include guard.
11105         * tui/tui-disasm.h: Rename include guard.
11106         * tui/tui-data.h: Rename include guard.
11107         * tui/tui-command.h: Rename include guard.
11108         * tic6x-tdep.h: Add include guard.
11109         * target/waitstatus.h: Rename include guard.
11110         * target/wait.h: Rename include guard.
11111         * target/target.h: Rename include guard.
11112         * target/resume.h: Rename include guard.
11113         * target-float.h: Rename include guard.
11114         * stabsread.h: Add include guard.
11115         * rs6000-tdep.h: Add include guard.
11116         * riscv-fbsd-tdep.h: Add include guard.
11117         * regformats/regdef.h: Rename include guard.
11118         * record.h: Rename include guard.
11119         * python/python.h: Rename include guard.
11120         * python/python-internal.h: Rename include guard.
11121         * python/py-stopevent.h: Rename include guard.
11122         * python/py-ref.h: Rename include guard.
11123         * python/py-record.h: Rename include guard.
11124         * python/py-record-full.h: Rename include guard.
11125         * python/py-record-btrace.h: Rename include guard.
11126         * python/py-instruction.h: Rename include guard.
11127         * python/py-events.h: Rename include guard.
11128         * python/py-event.h: Rename include guard.
11129         * procfs.h: Add include guard.
11130         * proc-utils.h: Add include guard.
11131         * p-lang.h: Add include guard.
11132         * or1k-tdep.h: Rename include guard.
11133         * observable.h: Rename include guard.
11134         * nto-tdep.h: Rename include guard.
11135         * nat/x86-linux.h: Rename include guard.
11136         * nat/x86-linux-dregs.h: Rename include guard.
11137         * nat/x86-gcc-cpuid.h: Add include guard.
11138         * nat/x86-dregs.h: Rename include guard.
11139         * nat/x86-cpuid.h: Rename include guard.
11140         * nat/ppc-linux.h: Rename include guard.
11141         * nat/mips-linux-watch.h: Rename include guard.
11142         * nat/linux-waitpid.h: Rename include guard.
11143         * nat/linux-ptrace.h: Rename include guard.
11144         * nat/linux-procfs.h: Rename include guard.
11145         * nat/linux-osdata.h: Rename include guard.
11146         * nat/linux-nat.h: Rename include guard.
11147         * nat/linux-namespaces.h: Rename include guard.
11148         * nat/linux-btrace.h: Rename include guard.
11149         * nat/glibc_thread_db.h: Rename include guard.
11150         * nat/gdb_thread_db.h: Rename include guard.
11151         * nat/gdb_ptrace.h: Rename include guard.
11152         * nat/fork-inferior.h: Rename include guard.
11153         * nat/amd64-linux-siginfo.h: Rename include guard.
11154         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11155         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11156         * nat/aarch64-linux.h: Rename include guard.
11157         * nat/aarch64-linux-hw-point.h: Rename include guard.
11158         * mn10300-tdep.h: Add include guard.
11159         * mips-linux-tdep.h: Add include guard.
11160         * mi/mi-parse.h: Rename include guard.
11161         * mi/mi-out.h: Rename include guard.
11162         * mi/mi-main.h: Rename include guard.
11163         * mi/mi-interp.h: Rename include guard.
11164         * mi/mi-getopt.h: Rename include guard.
11165         * mi/mi-console.h: Rename include guard.
11166         * mi/mi-common.h: Rename include guard.
11167         * mi/mi-cmds.h: Rename include guard.
11168         * mi/mi-cmd-break.h: Rename include guard.
11169         * m2-lang.h: Add include guard.
11170         * location.h: Rename include guard.
11171         * linux-record.h: Rename include guard.
11172         * linux-nat.h: Add include guard.
11173         * linux-fork.h: Add include guard.
11174         * i386-darwin-tdep.h: Rename include guard.
11175         * hppa-linux-offsets.h: Add include guard.
11176         * guile/guile.h: Rename include guard.
11177         * guile/guile-internal.h: Rename include guard.
11178         * gnu-nat.h: Rename include guard.
11179         * gdb-stabs.h: Rename include guard.
11180         * frv-tdep.h: Add include guard.
11181         * f-lang.h: Add include guard.
11182         * event-loop.h: Add include guard.
11183         * darwin-nat.h: Rename include guard.
11184         * cp-abi.h: Rename include guard.
11185         * config/sparc/nm-sol2.h: Rename include guard.
11186         * config/nm-nto.h: Rename include guard.
11187         * config/nm-linux.h: Add include guard.
11188         * config/i386/nm-i386gnu.h: Rename include guard.
11189         * config/djgpp/nl_types.h: Rename include guard.
11190         * config/djgpp/langinfo.h: Rename include guard.
11191         * compile/gcc-cp-plugin.h: Add include guard.
11192         * compile/gcc-c-plugin.h: Add include guard.
11193         * compile/compile.h: Rename include guard.
11194         * compile/compile-object-run.h: Rename include guard.
11195         * compile/compile-object-load.h: Rename include guard.
11196         * compile/compile-internal.h: Rename include guard.
11197         * compile/compile-cplus.h: Rename include guard.
11198         * compile/compile-c.h: Rename include guard.
11199         * common/xml-utils.h: Rename include guard.
11200         * common/x86-xstate.h: Rename include guard.
11201         * common/version.h: Rename include guard.
11202         * common/vec.h: Rename include guard.
11203         * common/tdesc.h: Rename include guard.
11204         * common/selftest.h: Rename include guard.
11205         * common/scoped_restore.h: Rename include guard.
11206         * common/scoped_mmap.h: Rename include guard.
11207         * common/scoped_fd.h: Rename include guard.
11208         * common/safe-iterator.h: Rename include guard.
11209         * common/run-time-clock.h: Rename include guard.
11210         * common/refcounted-object.h: Rename include guard.
11211         * common/queue.h: Rename include guard.
11212         * common/ptid.h: Rename include guard.
11213         * common/print-utils.h: Rename include guard.
11214         * common/preprocessor.h: Rename include guard.
11215         * common/pathstuff.h: Rename include guard.
11216         * common/observable.h: Rename include guard.
11217         * common/netstuff.h: Rename include guard.
11218         * common/job-control.h: Rename include guard.
11219         * common/host-defs.h: Rename include guard.
11220         * common/gdb_wait.h: Rename include guard.
11221         * common/gdb_vecs.h: Rename include guard.
11222         * common/gdb_unlinker.h: Rename include guard.
11223         * common/gdb_unique_ptr.h: Rename include guard.
11224         * common/gdb_tilde_expand.h: Rename include guard.
11225         * common/gdb_sys_time.h: Rename include guard.
11226         * common/gdb_string_view.h: Rename include guard.
11227         * common/gdb_splay_tree.h: Rename include guard.
11228         * common/gdb_setjmp.h: Rename include guard.
11229         * common/gdb_ref_ptr.h: Rename include guard.
11230         * common/gdb_optional.h: Rename include guard.
11231         * common/gdb_locale.h: Rename include guard.
11232         * common/gdb_assert.h: Rename include guard.
11233         * common/filtered-iterator.h: Rename include guard.
11234         * common/filestuff.h: Rename include guard.
11235         * common/fileio.h: Rename include guard.
11236         * common/environ.h: Rename include guard.
11237         * common/common-utils.h: Rename include guard.
11238         * common/common-types.h: Rename include guard.
11239         * common/common-regcache.h: Rename include guard.
11240         * common/common-inferior.h: Rename include guard.
11241         * common/common-gdbthread.h: Rename include guard.
11242         * common/common-exceptions.h: Rename include guard.
11243         * common/common-defs.h: Rename include guard.
11244         * common/common-debug.h: Rename include guard.
11245         * common/cleanups.h: Rename include guard.
11246         * common/buffer.h: Rename include guard.
11247         * common/btrace-common.h: Rename include guard.
11248         * common/break-common.h: Rename include guard.
11249         * cli/cli-utils.h: Rename include guard.
11250         * cli/cli-style.h: Rename include guard.
11251         * cli/cli-setshow.h: Rename include guard.
11252         * cli/cli-script.h: Rename include guard.
11253         * cli/cli-interp.h: Rename include guard.
11254         * cli/cli-decode.h: Rename include guard.
11255         * cli/cli-cmds.h: Rename include guard.
11256         * charset-list.h: Add include guard.
11257         * buildsym-legacy.h: Rename include guard.
11258         * bfin-tdep.h: Add include guard.
11259         * ax.h: Rename include guard.
11260         * arm-linux-tdep.h: Add include guard.
11261         * arm-fbsd-tdep.h: Add include guard.
11262         * arch/xtensa.h: Rename include guard.
11263         * arch/tic6x.h: Add include guard.
11264         * arch/i386.h: Add include guard.
11265         * arch/arm.h: Rename include guard.
11266         * arch/arm-linux.h: Rename include guard.
11267         * arch/arm-get-next-pcs.h: Rename include guard.
11268         * arch/amd64.h: Add include guard.
11269         * arch/aarch64-insn.h: Rename include guard.
11270         * arch-utils.h: Rename include guard.
11271         * annotate.h: Add include guard.
11272         * amd64-darwin-tdep.h: Rename include guard.
11273         * aarch64-linux-tdep.h: Add include guard.
11274         * aarch64-fbsd-tdep.h: Add include guard.
11275         * aarch32-linux-nat.h: Add include guard.
11276
11277 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11278
11279         * macrotab.c (macro_define_internal): New function that
11280         factorizes macro_define_object_internal and macro_define_function
11281         code.
11282         (macro_define_object_internal): Use macro_define_internal.
11283         (macro_define_function): Likewise.
11284
11285 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11286
11287         * macrocmd.c (extract_identifier): Return
11288         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11289         callers.
11290
11291 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11292
11293         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11294
11295 2019-02-05  Tom Tromey  <tom@tromey.com>
11296
11297         * target.c (target_stack::unpush): Move assertion earlier.
11298
11299 2019-01-30  Tom Tromey  <tom@tromey.com>
11300
11301         PR python/23615:
11302         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11303         (gdbpy_parse_and_eval): Likewise.
11304         * python/python-internal.h (gdbpy_allow_threads): New class.
11305
11306 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11307
11308         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11309         (aarch64_fbsd_fpregmap): Move earlier.
11310         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11311         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11312         instead of individual calls to trad_frame_set_reg_addr.
11313         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11314         earlier.
11315         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11316         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11317         instead of individual calls to trad_frame_set_reg_addr.
11318
11319 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11320
11321         * CONTRIBUTE: Replace contribution list with wiki link.
11322
11323 2019-01-25  Tom Tromey  <tom@tromey.com>
11324
11325         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11326
11327 2019-01-25  Tom Tromey  <tom@tromey.com>
11328
11329         * xtensa-linux-nat.c: Fix common/ includes.
11330         * xml-support.h: Fix common/ includes.
11331         * xml-support.c: Fix common/ includes.
11332         * x86-linux-nat.c: Fix common/ includes.
11333         * windows-nat.c: Fix common/ includes.
11334         * varobj.h: Fix common/ includes.
11335         * varobj.c: Fix common/ includes.
11336         * value.c: Fix common/ includes.
11337         * valops.c: Fix common/ includes.
11338         * utils.c: Fix common/ includes.
11339         * unittests/xml-utils-selftests.c: Fix common/ includes.
11340         * unittests/utils-selftests.c: Fix common/ includes.
11341         * unittests/unpack-selftests.c: Fix common/ includes.
11342         * unittests/tracepoint-selftests.c: Fix common/ includes.
11343         * unittests/style-selftests.c: Fix common/ includes.
11344         * unittests/string_view-selftests.c: Fix common/ includes.
11345         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11346         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11347         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11348         * unittests/rsp-low-selftests.c: Fix common/ includes.
11349         * unittests/parse-connection-spec-selftests.c: Fix common/
11350         includes.
11351         * unittests/optional-selftests.c: Fix common/ includes.
11352         * unittests/offset-type-selftests.c: Fix common/ includes.
11353         * unittests/observable-selftests.c: Fix common/ includes.
11354         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11355         * unittests/memrange-selftests.c: Fix common/ includes.
11356         * unittests/memory-map-selftests.c: Fix common/ includes.
11357         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11358         * unittests/function-view-selftests.c: Fix common/ includes.
11359         * unittests/environ-selftests.c: Fix common/ includes.
11360         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11361         * unittests/common-utils-selftests.c: Fix common/ includes.
11362         * unittests/cli-utils-selftests.c: Fix common/ includes.
11363         * unittests/array-view-selftests.c: Fix common/ includes.
11364         * ui-file.c: Fix common/ includes.
11365         * tui/tui-io.c: Fix common/ includes.
11366         * tracepoint.h: Fix common/ includes.
11367         * tracepoint.c: Fix common/ includes.
11368         * tracefile-tfile.c: Fix common/ includes.
11369         * top.h: Fix common/ includes.
11370         * top.c: Fix common/ includes.
11371         * thread.c: Fix common/ includes.
11372         * target/waitstatus.h: Fix common/ includes.
11373         * target/waitstatus.c: Fix common/ includes.
11374         * target.h: Fix common/ includes.
11375         * target.c: Fix common/ includes.
11376         * target-memory.c: Fix common/ includes.
11377         * target-descriptions.c: Fix common/ includes.
11378         * symtab.h: Fix common/ includes.
11379         * symfile.c: Fix common/ includes.
11380         * stap-probe.c: Fix common/ includes.
11381         * spu-linux-nat.c: Fix common/ includes.
11382         * sparc-nat.c: Fix common/ includes.
11383         * source.c: Fix common/ includes.
11384         * solib.c: Fix common/ includes.
11385         * solib-target.c: Fix common/ includes.
11386         * ser-unix.c: Fix common/ includes.
11387         * ser-tcp.c: Fix common/ includes.
11388         * ser-pipe.c: Fix common/ includes.
11389         * ser-base.c: Fix common/ includes.
11390         * selftest-arch.c: Fix common/ includes.
11391         * s12z-tdep.c: Fix common/ includes.
11392         * rust-exp.y: Fix common/ includes.
11393         * rs6000-aix-tdep.c: Fix common/ includes.
11394         * riscv-tdep.c: Fix common/ includes.
11395         * remote.c: Fix common/ includes.
11396         * remote-notif.h: Fix common/ includes.
11397         * remote-fileio.h: Fix common/ includes.
11398         * remote-fileio.c: Fix common/ includes.
11399         * regcache.h: Fix common/ includes.
11400         * regcache.c: Fix common/ includes.
11401         * record-btrace.c: Fix common/ includes.
11402         * python/python.c: Fix common/ includes.
11403         * python/py-type.c: Fix common/ includes.
11404         * python/py-inferior.c: Fix common/ includes.
11405         * progspace.h: Fix common/ includes.
11406         * producer.c: Fix common/ includes.
11407         * procfs.c: Fix common/ includes.
11408         * proc-api.c: Fix common/ includes.
11409         * printcmd.c: Fix common/ includes.
11410         * ppc-linux-nat.c: Fix common/ includes.
11411         * parser-defs.h: Fix common/ includes.
11412         * osdata.c: Fix common/ includes.
11413         * obsd-nat.c: Fix common/ includes.
11414         * nat/x86-linux.c: Fix common/ includes.
11415         * nat/x86-linux-dregs.c: Fix common/ includes.
11416         * nat/x86-dregs.h: Fix common/ includes.
11417         * nat/x86-dregs.c: Fix common/ includes.
11418         * nat/ppc-linux.c: Fix common/ includes.
11419         * nat/mips-linux-watch.h: Fix common/ includes.
11420         * nat/mips-linux-watch.c: Fix common/ includes.
11421         * nat/linux-waitpid.c: Fix common/ includes.
11422         * nat/linux-ptrace.h: Fix common/ includes.
11423         * nat/linux-ptrace.c: Fix common/ includes.
11424         * nat/linux-procfs.c: Fix common/ includes.
11425         * nat/linux-personality.c: Fix common/ includes.
11426         * nat/linux-osdata.c: Fix common/ includes.
11427         * nat/linux-namespaces.c: Fix common/ includes.
11428         * nat/linux-btrace.h: Fix common/ includes.
11429         * nat/linux-btrace.c: Fix common/ includes.
11430         * nat/fork-inferior.c: Fix common/ includes.
11431         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11432         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11433         * nat/aarch64-linux.c: Fix common/ includes.
11434         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11435         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11436         * namespace.h: Fix common/ includes.
11437         * mips-linux-tdep.c: Fix common/ includes.
11438         * minsyms.c: Fix common/ includes.
11439         * mi/mi-parse.h: Fix common/ includes.
11440         * mi/mi-main.c: Fix common/ includes.
11441         * mi/mi-cmd-env.c: Fix common/ includes.
11442         * memrange.h: Fix common/ includes.
11443         * memattr.c: Fix common/ includes.
11444         * maint.h: Fix common/ includes.
11445         * maint.c: Fix common/ includes.
11446         * main.c: Fix common/ includes.
11447         * machoread.c: Fix common/ includes.
11448         * location.c: Fix common/ includes.
11449         * linux-thread-db.c: Fix common/ includes.
11450         * linux-nat.c: Fix common/ includes.
11451         * linux-fork.c: Fix common/ includes.
11452         * inline-frame.c: Fix common/ includes.
11453         * infrun.c: Fix common/ includes.
11454         * inflow.c: Fix common/ includes.
11455         * inferior.h: Fix common/ includes.
11456         * inferior.c: Fix common/ includes.
11457         * infcmd.c: Fix common/ includes.
11458         * inf-ptrace.c: Fix common/ includes.
11459         * inf-child.c: Fix common/ includes.
11460         * ia64-linux-nat.c: Fix common/ includes.
11461         * i387-tdep.c: Fix common/ includes.
11462         * i386-tdep.c: Fix common/ includes.
11463         * i386-linux-tdep.c: Fix common/ includes.
11464         * i386-linux-nat.c: Fix common/ includes.
11465         * i386-go32-tdep.c: Fix common/ includes.
11466         * i386-fbsd-tdep.c: Fix common/ includes.
11467         * i386-fbsd-nat.c: Fix common/ includes.
11468         * guile/scm-type.c: Fix common/ includes.
11469         * guile/guile.c: Fix common/ includes.
11470         * go32-nat.c: Fix common/ includes.
11471         * gnu-nat.c: Fix common/ includes.
11472         * gdbthread.h: Fix common/ includes.
11473         * gdbarch-selftests.c: Fix common/ includes.
11474         * gdb_usleep.c: Fix common/ includes.
11475         * gdb_select.h: Fix common/ includes.
11476         * gdb_bfd.c: Fix common/ includes.
11477         * gcore.c: Fix common/ includes.
11478         * fork-child.c: Fix common/ includes.
11479         * findvar.c: Fix common/ includes.
11480         * fbsd-nat.c: Fix common/ includes.
11481         * event-top.c: Fix common/ includes.
11482         * event-loop.c: Fix common/ includes.
11483         * dwarf2read.c: Fix common/ includes.
11484         * dwarf2loc.c: Fix common/ includes.
11485         * dwarf2-frame.c: Fix common/ includes.
11486         * dwarf-index-cache.c: Fix common/ includes.
11487         * dtrace-probe.c: Fix common/ includes.
11488         * disasm-selftests.c: Fix common/ includes.
11489         * defs.h: Fix common/ includes.
11490         * csky-tdep.c: Fix common/ includes.
11491         * cp-valprint.c: Fix common/ includes.
11492         * cp-support.h: Fix common/ includes.
11493         * cp-support.c: Fix common/ includes.
11494         * corelow.c: Fix common/ includes.
11495         * completer.h: Fix common/ includes.
11496         * completer.c: Fix common/ includes.
11497         * compile/compile.c: Fix common/ includes.
11498         * compile/compile-loc2c.c: Fix common/ includes.
11499         * compile/compile-cplus-types.c: Fix common/ includes.
11500         * compile/compile-cplus-symbols.c: Fix common/ includes.
11501         * command.h: Fix common/ includes.
11502         * cli/cli-dump.c: Fix common/ includes.
11503         * cli/cli-cmds.c: Fix common/ includes.
11504         * charset.c: Fix common/ includes.
11505         * build-id.c: Fix common/ includes.
11506         * btrace.h: Fix common/ includes.
11507         * btrace.c: Fix common/ includes.
11508         * breakpoint.h: Fix common/ includes.
11509         * breakpoint.c: Fix common/ includes.
11510         * ax.h:
11511         (enum agent_op): Fix common/ includes.
11512         * ax-general.c (struct aop_map): Fix common/ includes.
11513         * ax-gdb.c: Fix common/ includes.
11514         * auxv.c: Fix common/ includes.
11515         * auto-load.c: Fix common/ includes.
11516         * arm-tdep.c: Fix common/ includes.
11517         * arch/riscv.c: Fix common/ includes.
11518         * arch/ppc-linux-common.c: Fix common/ includes.
11519         * arch/i386.c: Fix common/ includes.
11520         * arch/arm.c: Fix common/ includes.
11521         * arch/arm-linux.c: Fix common/ includes.
11522         * arch/arm-get-next-pcs.c: Fix common/ includes.
11523         * arch/amd64.c: Fix common/ includes.
11524         * arch/aarch64.c: Fix common/ includes.
11525         * arch/aarch64-insn.c: Fix common/ includes.
11526         * arch-utils.c: Fix common/ includes.
11527         * amd64-windows-tdep.c: Fix common/ includes.
11528         * amd64-tdep.c: Fix common/ includes.
11529         * amd64-sol2-tdep.c: Fix common/ includes.
11530         * amd64-obsd-tdep.c: Fix common/ includes.
11531         * amd64-nbsd-tdep.c: Fix common/ includes.
11532         * amd64-linux-tdep.c: Fix common/ includes.
11533         * amd64-linux-nat.c: Fix common/ includes.
11534         * amd64-fbsd-tdep.c: Fix common/ includes.
11535         * amd64-fbsd-nat.c: Fix common/ includes.
11536         * amd64-dicos-tdep.c: Fix common/ includes.
11537         * amd64-darwin-tdep.c: Fix common/ includes.
11538         * agent.c: Fix common/ includes.
11539         * ada-lang.h: Fix common/ includes.
11540         * ada-lang.c: Fix common/ includes.
11541         * aarch64-tdep.c: Fix common/ includes.
11542
11543 2019-01-25  Tom Tromey  <tom@tromey.com>
11544
11545         * common/create-version.sh: Use common/version.h.
11546
11547 2019-01-24  Pedro Alves  <palves@redhat.com>
11548
11549         * infrun.c (signal_stop, signal_print, signal_program)
11550         (signal_catch, signal_pass): Now arrays instead of pointers.
11551         (update_signals_program_target, do_target_resume)
11552         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11553         * linux-nat.c (linux_nat_target::pass_signals)
11554         (linux_nat_target::create_inferior, linux_nat_target::attach):
11555         Adjust.
11556         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11557         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11558         * procfs.c (procfs_target::pass_signals): Adjust.
11559         * record-full.c (record_full_target::resume): Adjust.
11560         * remote.c (remote_target::pass_signals)
11561         (remote_target::program_signals): Adjust.
11562         * target-debug.h (target_debug_print_signals): Now takes a
11563         gdb::array_view as parameter.  Adjust.
11564         * target.h (target_ops) <pass_signals, program_signals>: Replace
11565         pointer and length parameters with gdb::array_view.
11566         (target_pass_signals, target_program_signals): Likewise.
11567         * target-delegates.c: Regenerate.
11568
11569 2019-01-24  Pedro Alves  <palves@redhat.com>
11570
11571         * common/forward-scope-exit.h
11572         (forward_scope_exit::forward_scope_exit): Pass arguments to
11573         m_bind_function directly, instead of creating a std::bind and
11574         copying that.
11575
11576 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11577
11578         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11579         for static members.
11580         (pass_in_v_vfp_candidate): Likewise.
11581
11582 2019-01-23  Tom Tromey  <tom@tromey.com>
11583             Pedro Alves  <palves@redhat.com>
11584
11585         * regcache.c (class regcache_invalidator): Remove.
11586         (regcache::raw_write): Use make_scope_exit.
11587
11588 2019-01-23  Tom Tromey  <tom@tromey.com>
11589
11590         * ui-out.h (class ui_out_emit_type): Update comment.
11591
11592 2019-01-23  Tom Tromey  <tom@tromey.com>
11593
11594         * infrun.c (fetch_inferior_event): Update comment.
11595
11596 2019-01-23  Tom Tromey  <tom@tromey.com>
11597             Pedro Alves  <palves@redhat.com>
11598
11599         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11600         parameter.
11601         (fetch_inferior_event): Use SCOPE_EXIT.
11602
11603
11604 2019-01-23  Tom Tromey  <tom@tromey.com>
11605             Pedro Alves  <palves@redhat.com>
11606
11607         * infrun.c (disable_thread_events): Delete.
11608         (stop_all_threads): Use SCOPE_EXIT.
11609
11610 2019-01-23  Tom Tromey  <tom@tromey.com>
11611             Pedro Alves  <palves@redhat.com>
11612
11613         * symfile.c: Include forward-scope-exit.h.
11614         (clear_symtab_users_cleanup): Replace forward declaration with
11615         a FORWARD_SCOPE_EXIT.
11616         (syms_from_objfile_1): Use the forward_scope_exit and
11617         gdb::optional instead of cleanup_function.
11618         (reread_symbols): Use the forward_scope_exit instead of
11619         cleanup_function.
11620         (clear_symtab_users_cleanup): Remove function.
11621
11622 2019-01-23  Tom Tromey  <tom@tromey.com>
11623             Pedro Alves  <palves@redhat.com>
11624
11625         * linux-nat.c: Include scope-exit.h.
11626         (cleanup_target_stop): Remove.
11627         (linux_nat_target::static_tracepoint_markers_by_strid): Use
11628         SCOPE_EXIT.
11629
11630 2019-01-23  Tom Tromey  <tom@tromey.com>
11631             Pedro Alves  <palves@redhat.com>
11632
11633         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
11634         (call_function_by_hand_dummy): Use SCOPE_EXIT.
11635
11636 2019-01-23  Tom Tromey  <tom@tromey.com>
11637             Andrew Burgess  <andrew.burgess@embecosm.com>
11638             Pedro Alves  <palves@redhat.com>
11639
11640         * infrun.c (fetch_inferior_event): Use scope_exit.
11641         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
11642         * top.c (execute_command): Use scope_exit.
11643         * breakpoint.c (bpstat_do_actions): Use scope_exit.
11644         * utils.c (do_bpstat_clear_actions_cleanup)
11645         (make_bpstat_clear_actions_cleanup): Remove.
11646
11647 2019-01-23  Tom Tromey  <tom@tromey.com>
11648             Pedro Alves  <palves@redhat.com>
11649
11650         * infrun.c: Include "common/scope-exit.h"
11651         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
11652         (wait_for_inferior): Use SCOPE_EXIT.
11653         (fetch_inferior_event): Use scope_exit.
11654
11655 2019-01-23  Tom Tromey  <tom@tromey.com>
11656             Pedro Alves  <palves@redhat.com>
11657
11658         * breakpoint.c (create_breakpoint): Remove cleanup.
11659
11660 2019-01-23  Tom Tromey  <tom@tromey.com>
11661             Andrew Burgess  <andrew.burgess@embecosm.com>
11662             Pedro Alves  <palves@redhat.com>
11663
11664 2019-01-23  Pedro Alves  <palves@redhat.com>
11665
11666         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
11667
11668 2019-01-23  Pedro Alves  <palves@redhat.com>
11669             Andrew Burgess  <andrew.burgess@embecosm.com>
11670
11671         * gdbthread.h: Include "common/forward-scope-exit.h".
11672         (scoped_finish_thread_state): Redefine custom class in terms of
11673         forward_scope_exit.
11674
11675 2019-01-23  Pedro Alves  <palves@redhat.com>
11676             Andrew Burgess  <andrew.burgess@embecosm.com>
11677
11678         * common/forward-scope-exit.h: New file.
11679
11680 2019-01-23  Pedro Alves  <palves@redhat.com>
11681             Andrew Burgess  <andrew.burgess@embecosm.com>
11682             Tom Tromey  <tom@tromey.com>
11683
11684         * common/scope-exit.h: New file.
11685
11686 2019-01-23  Pedro Alves  <palves@redhat.com>
11687
11688         * common/preprocessor.h (ESC): Rename to ...
11689         (ESC_PARENS): ... this.
11690         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
11691         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
11692
11693 2019-01-23  Tom Tromey  <tom@tromey.com>
11694
11695         * language.h (class scoped_switch_to_sym_language_if_auto):
11696         Initialize m_lang in both cases.
11697
11698 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
11699
11700         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
11701         with XCNEW.
11702
11703 2019-01-22  Tom Tromey  <tom@tromey.com>
11704
11705         * corelow.c: Do not include sys/file.h.
11706
11707 2019-01-22  Tom Tromey  <tom@tromey.com>
11708
11709         * tui/tui-wingeneral.h: Include gdb_curses.h.
11710
11711 2019-01-22  Tom Tromey  <tom@tromey.com>
11712
11713         * source-cache.h (class source_cache) <get_source_lines,
11714         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
11715
11716 2019-01-22  Tom Tromey  <tom@tromey.com>
11717
11718         * remote-fileio.h (struct remote_target): Declare.
11719
11720 2019-01-22  Tom Tromey  <tom@tromey.com>
11721
11722         * python/py-arch.c: Do not include py-ref.h.
11723         * python/py-bpevent.c: Do not include py-ref.h.
11724         * python/py-cmd.c: Do not include py-ref.h.
11725         * python/py-continueevent.c: Do not include py-ref.h.
11726         * python/py-event.h: Do not include py-ref.h.
11727         * python/py-evtregistry.c: Do not include py-ref.h.
11728         * python/py-finishbreakpoint.c: Do not include py-ref.h.
11729         * python/py-frame.c: Do not include py-ref.h.
11730         * python/py-framefilter.c: Do not include py-ref.h.
11731         * python/py-function.c: Do not include py-ref.h.
11732         * python/py-infevents.c: Do not include py-ref.h.
11733         * python/py-linetable.c: Do not include py-ref.h.
11734         * python/py-objfile.c: Do not include py-ref.h.
11735         * python/py-param.c: Do not include py-ref.h.
11736         * python/py-prettyprint.c: Do not include py-ref.h.
11737         * python/py-progspace.c: Do not include py-ref.h.
11738         * python/py-symbol.c: Do not include py-ref.h.
11739         * python/py-symtab.c: Do not include py-ref.h.
11740         * python/py-type.c: Do not include py-ref.h.
11741         * python/py-unwind.c: Do not include py-ref.h.
11742         * python/py-utils.c: Do not include py-ref.h.
11743         * python/py-value.c: Do not include py-ref.h.
11744         * python/py-varobj.c: Do not include py-ref.h.
11745         * python/py-xmethods.c: Do not include py-ref.h.
11746         * python/python.c: Do not include py-ref.h.
11747         * varobj.c: Do not include py-ref.h.
11748
11749 2019-01-22  Tom Tromey  <tom@tromey.com>
11750
11751         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
11752         keyword for bcache.
11753
11754 2019-01-22  Tom Tromey  <tom@tromey.com>
11755
11756         * compile/compile-cplus-types.c: Remove a comment by #include.
11757
11758 2019-01-22  Tom Tromey  <tom@tromey.com>
11759
11760         * compile/gcc-c-plugin.h: Include compile-internal.h.
11761
11762 2019-01-22  Tom Tromey  <tom@tromey.com>
11763
11764         * stabsread.c (EXTERN): Do not define.
11765         (symnum, next_symbol_text_func, processing_gcc_compilation)
11766         (within_function, global_sym_chain, global_stabs)
11767         (previous_stab_code, this_object_header_files)
11768         (n_this_object_header_files)
11769         (n_allocated_this_object_header_files): Define.
11770         * stabsread.h (EXTERN): Never define.  Use "extern".
11771
11772 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11773
11774         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
11775         history_value.
11776
11777 2019-01-21  Tom Tromey  <tom@tromey.com>
11778
11779         * ui-out.c: Fix includes.
11780         * tui/tui-source.c: Fix includes.
11781         * target.c: Fix includes.
11782         * remote.c: Fix includes.
11783         * regcache.c: Fix includes.
11784         * python/py-block.c: Fix includes.
11785         * printcmd.c: Fix includes.
11786         * or1k-tdep.c: Fix includes.
11787         * mi/mi-main.c: Fix includes.
11788         * m32r-tdep.c: Fix includes.
11789         * csky-tdep.c: Fix includes.
11790         * compile/compile-cplus-types.c: Fix includes.
11791         * cli/cli-interp.c: Fix includes.
11792
11793 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
11794
11795         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11796         for padding.
11797
11798 2019-01-16  Tom Tromey  <tom@tromey.com>
11799
11800         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
11801         earlier.
11802         (struct objfile) <msymbols_range>: Move from top level.
11803         <msymbols>: New method.
11804         (class objfile_msymbols): Remove.
11805         * symtab.c (default_collect_symbol_completion_matches_break_on):
11806         Update.
11807         * symmisc.c (dump_msymbols): Update.
11808         * stabsread.c (scan_file_globals): Update.
11809         * objc-lang.c (info_selectors_command, info_classes_command)
11810         (find_methods): Update.
11811         * minsyms.c (find_solib_trampoline_target): Update.
11812         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
11813         * coffread.c (coff_symfile_read): Update.
11814         * ada-lang.c (ada_lookup_simple_minsym)
11815         (ada_collect_symbol_completion_matches): Update.
11816
11817 2019-01-16  Tom Tromey  <tom@tromey.com>
11818
11819         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
11820         type.  Remove no-argument constructor.
11821         <iterator::operator++>: Simplify.
11822         <begin>: Update.
11823         <end>: Use minimal_symbol_count.
11824
11825 2019-01-16  Tom Tromey  <tom@tromey.com>
11826
11827         * objfiles.h (struct objfile) <psymtabs>: New method.
11828         (class objfile_psymtabs): Remove.
11829         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
11830         typedef.
11831         <range>: New method.
11832         (require_partial_symbols): Change return type.
11833         * psymtab.c (require_partial_symbols)
11834         (psym_expand_symtabs_matching): Update.
11835         * mdebugread.c (parse_partial_symbols): Update.
11836         * dbxread.c (dbx_end_psymtab): Update.
11837
11838 2019-01-15  Tom Tromey  <tom@tromey.com>
11839
11840         * symtab.c (lookup_objfile_from_block)
11841         (lookup_symbol_in_objfile_symtabs)
11842         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
11843         (find_line_symtab, info_sources_command)
11844         (default_collect_symbol_completion_matches_break_on)
11845         (make_source_files_completion_list): Update.
11846         * symmisc.c (print_objfile_statistics, dump_objfile)
11847         (maintenance_print_symbols, maintenance_info_symtabs)
11848         (maintenance_check_symtabs, maintenance_info_line_tables):
11849         Update.
11850         * source.c (select_source_symtab)
11851         (forget_cached_source_info_for_objfile): Update.
11852         * objfiles.h (class objfile_compunits): Remove.
11853         (struct objfile) <compunits_range>: New typedef.
11854         (compunits): New method.
11855         * objfiles.c (objfile_relocate1): Update.
11856         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11857         * maint.c (count_symtabs_and_blocks): Update.
11858         * linespec.c (iterate_over_all_matching_symtabs): Update.
11859         * cp-support.c (add_symbol_overload_list_qualified): Update.
11860         * coffread.c (coff_symtab_read): Update.
11861         * ada-lang.c (add_nonlocal_symbols)
11862         (ada_collect_symbol_completion_matches)
11863         (ada_add_global_exceptions): Update.
11864
11865 2019-01-15  Tom Tromey  <tom@tromey.com>
11866
11867         * progspace.h (program_space) <objfiles_safe_range>: New
11868         typedef.
11869         <objfiles_safe>: New method.
11870         * objfiles.h (class all_objfiles_safe): Remove.
11871         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
11872         * jit.c (jit_inferior_exit_hook): Update.
11873
11874 2019-01-17  Tom Tromey  <tom@tromey.com>
11875
11876         * progspace.h (program_space) <objfiles_range>: New typedef.
11877         <objfiles>: New method.
11878         <objfiles_head>: Rename from objfiles.
11879         (object_files): Update.
11880         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
11881         * guile/scm-pretty-print.c
11882         (ppscm_find_pretty_printer_from_objfiles): Update.
11883         * guile/scm-objfile.c (gdbscm_objfiles): Update.
11884         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
11885         Update.
11886         * python/py-progspace.c (pspy_get_objfiles): Update.
11887         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
11888         Update.
11889         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
11890         (objfpy_lookup_objfile_by_build_id): Update.
11891         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
11892         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
11893         Update.
11894         * symtab.c (iterate_over_symtabs, matching_obj_sections)
11895         (expand_symtab_containing_pc, lookup_objfile_from_block)
11896         (lookup_static_symbol, basic_lookup_transparent_type)
11897         (find_pc_sect_compunit_symtab, find_symbol_at_address)
11898         (find_line_symtab, info_sources_command)
11899         (default_collect_symbol_completion_matches_break_on)
11900         (make_source_files_completion_list, find_main_name): Update.
11901         * symmisc.c (print_symbol_bcache_statistics)
11902         (print_objfile_statistics, maintenance_print_symbols)
11903         (maintenance_print_msymbols, maintenance_print_objfiles)
11904         (maintenance_info_symtabs, maintenance_check_symtabs)
11905         (maintenance_expand_symtabs, maintenance_info_line_tables):
11906         Update.
11907         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
11908         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
11909         (map_overlay_command, unmap_overlay_command)
11910         (simple_overlay_update, expand_symtabs_matching)
11911         (map_symbol_filenames): Update.
11912         * symfile-debug.c (set_debug_symfile): Update.
11913         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
11914         Update.
11915         * source.c (select_source_symtab, forget_cached_source_info):
11916         Update.
11917         * solib.c (solib_read_symbols): Update.
11918         * solib-spu.c (append_ocl_sos): Update.
11919         * psymtab.c (maintenance_print_psymbols)
11920         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
11921         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
11922         * printcmd.c (info_symbol_command): Update.
11923         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
11924         Update.
11925         * objfiles.h (class all_objfiles): Remove.
11926         * objfiles.c (have_partial_symbols, have_full_symbols)
11927         (have_minimal_symbols, qsort_cmp, update_section_map)
11928         (shared_objfile_contains_address_p)
11929         (default_iterate_over_objfiles_in_search_order): Update.
11930         * objc-lang.c (info_selectors_command, info_classes_command)
11931         (find_methods): Update.
11932         * minsyms.c (find_solib_trampoline_target): Update.
11933         * maint.c (maintenance_info_sections)
11934         (maintenance_translate_address, count_symtabs_and_blocks):
11935         Update.
11936         * main.c (captured_main_1): Update.
11937         * linux-thread-db.c (try_thread_db_load_from_pdir)
11938         (has_libpthread): Update.
11939         * linespec.c (iterate_over_all_matching_symtabs)
11940         (search_minsyms_for_name): Update.
11941         * jit.c (jit_find_objf_with_entry_addr): Update.
11942         * hppa-tdep.c (find_unwind_entry)
11943         (hppa_lookup_stub_minimal_symbol): Update.
11944         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
11945         Update.
11946         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
11947         (elf_gnu_ifunc_resolve_by_got): Update.
11948         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
11949         * dwarf-index-write.c (save_gdb_index_command): Update.
11950         * cp-support.c (add_symbol_overload_list_qualified): Update.
11951         * breakpoint.c (create_overlay_event_breakpoint)
11952         (create_longjmp_master_breakpoint)
11953         (create_std_terminate_master_breakpoint)
11954         (create_exception_master_breakpoint): Update.
11955         * blockframe.c (find_pc_partial_function): Update.
11956         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
11957         (ada_collect_symbol_completion_matches)
11958         (ada_add_global_exceptions): Update.
11959
11960 2019-01-17  Tom Tromey  <tom@tromey.com>
11961
11962         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
11963         declare VEC.
11964         (solib_target_parse_libraries): Change return type.
11965         (library_list_start_segment, library_list_start_section)
11966         (library_list_end_library, library_list_start_library); Update.
11967         (solib_target_free_library_list): Remove.
11968         (solib_target_parse_libraries): Remove cleanup.  Change return
11969         type.
11970         (solib_target_current_sos): Update.
11971
11972 2019-01-17  Tom Tromey  <tromey@bapiya>
11973
11974         * valprint.c: Replace "the the" with "the".
11975         * symtab.c: Replace "the the" with "the".
11976         * solib.c: Replace "the the" with "the".
11977         * solib-dsbt.c: Replace "the the" with "the".
11978         * linespec.c: Replace "the the" with "the".
11979         * dwarf2loc.h: Replace "the the" with "the".
11980         * amd64-windows-tdep.c: Replace "the the" with "the".
11981         * aarch64-tdep.c: Replace "the the" with "the".
11982
11983 2019-01-16  Keith Seitz  <keiths@redhat.com>
11984
11985         PR gdb/23773
11986         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
11987         <builder>: Rename to ..
11988         <m_builder>: ... this and make private.
11989         (dwarf2_cu::get_builder): New method.  Change all users of
11990         `builder' to use this method.
11991         (dwarf2_start_symtab): Move to ...
11992         (dwarf2_cu::start_symtab): ... here.  Update all callers
11993         (setup_type_unit_groups): Move to ...
11994         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
11995         callers.
11996         (dwarf2_cu::reset_builder): New method.
11997         (process_full_compunit, process_full_type_unit): Use
11998         dwarf2_cu::reset_builder.
11999         (follow_die_offset): Record the ancestor CU if it is different
12000         from the followed DIE's CU.
12001         (follow_die_sig_1): Likewise.
12002
12003 2019-01-15  Tom Tromey  <tom@tromey.com>
12004
12005         * remote.c (class remote_state) <buf>: Now a char_vector.
12006         <buf_size>: Remove.
12007         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12008         parameter.
12009         (remote_target::getpkt_or_notif_sane_1)
12010         (remote_target::getpkt_sane)
12011         (remote_target::getpkt_or_notif_sane): Likewise.
12012         (class remote_target) <putpkt>: New overload.
12013         (remote_target::read_frame): Change type of "buf_p".  Remove
12014         sizeof_p parameter.
12015         (packet_ok): New overload.
12016         (packet_check_result): New overload.
12017         Update all uses.
12018
12019 2019-01-14  Tom Tromey  <tom@tromey.com>
12020
12021         * remote-notif.c (handle_notification, remote_notif_ack)
12022         (remote_notif_parse): Make "buf" const.
12023         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12024         const.
12025         (remote_notif_parse, remote_notif_ack, handle_notification):
12026         Likewise.
12027         * remote.c (remote_notif_stop_parse): Make "buf" const.
12028         (remote_target::remote_parse_stop_reply): Make "buf" const.
12029         (remote_notif_stop_ack): Make "buf" const.
12030
12031 2019-01-14  Tom Tromey  <tom@tromey.com>
12032
12033         * remote.c (remote_console_output): Make parameter const.
12034
12035 2019-01-14  Tom Tromey  <tom@tromey.com>
12036
12037         * target-debug.h (target_debug_print_signals): Constify.
12038         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12039         * procfs.c (procfs_target::pass_signals): Update.
12040         * linux-nat.c (linux_nat_target::pass_signals): Update.
12041         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12042         * target-delegates.c: Rebuild.
12043         * remote.c (remote_target::program_signals): Update.
12044         (remote_target::pass_signals): Update.
12045         * target.c (target_pass_signals): Constify argument.
12046         (target_program_signals): Likewise.
12047         * target.h (struct target_ops) <pass_signals, program_signals>:
12048         Constify argument.
12049         (target_pass_signals, target_program_signals): Constify argument.
12050
12051 2019-01-14  Tom Tromey  <tom@tromey.com>
12052
12053         PR tui/28819:
12054         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12055
12056 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12057
12058         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12059         field.
12060         * rs6000-tdep.c: Include reggroups.h.
12061         (IS_V_ALIAS_PSEUDOREG): Define.
12062         (rs6000_register_name): Return names for the "vX" aliases.
12063         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12064         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12065         aliases.  Call default_register_reggroup_p for all other
12066         pseudo-registers.
12067         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12068         New functions.
12069         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12070         Handle "vX" aliases.
12071         (v_alias_pseudo_register_collect): New function.
12072         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12073         (rs6000_gdbarch_init): Initialize "vX" aliases as
12074         pseudo-registers.  Restore registration of
12075         rs6000_pseudo_register_reggroup_p with
12076         set_tdesc_pseudo_register_reggroup_p.
12077
12078 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12079
12080         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12081         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12082         set_gdbarch_num_pseudo_regs.
12083
12084 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12085
12086         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12087         Remove arg prefixname, add do_set and do_show.
12088         Add member functions set_list and show_list.
12089         * cli/cli-style.c (class cli_style_option): Update accordingly.
12090         (style_set_list): Move to file scope.
12091         (style_show_list): Likewise.
12092         (set_style): Call help_list.
12093         (show_style): Call cmd_show_list.
12094         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12095         Update to use the new macro.
12096
12097 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12098
12099         * ada-lang.c (_initialize_ada_language): Expand the help text
12100         for the "catch exception" command.
12101
12102 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12103
12104         * symtab.c (matching_obj_sections): Initialize obj,
12105         declare it closer to its usage.
12106
12107 2019-01-10  Tom Tromey  <tom@tromey.com>
12108
12109         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12110         (basic_inf_threads_range): Remove.
12111         (inf_threads_range, inf_non_exited_threads_range)
12112         (safe_inf_threads_range): Use next_adapter.
12113
12114 2019-01-10  Keith Seitz  <keiths@redhat.com>
12115
12116         PR gdb/23712
12117         PR symtab/23010
12118         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12119         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12120
12121 2019-01-10  Keith Seitz  <keiths@redhat.com>
12122
12123         PR gdb/23712
12124         PR symtab/23010
12125         * dictionary.c (pending_to_vector): Remove.
12126         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12127         Remove _1 suffix, replacing functions of the same name.  Update
12128         all callers.
12129         (dict_create_hashed, dict_create_hashed_expandable)
12130         (dict_create_linear, dict_create_linear_expandable, dict_free)
12131         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12132         Make functions static.
12133
12134 2019-01-10  Keith Seitz  <keiths@redhat.com>
12135
12136         PR gdb/23712
12137         PR symtab/23010
12138         * dictionary.h (struct dictionary): Replace declaration with
12139         multidictionary.
12140         (dict_create_hashed, dict_create_hashed_expandable)
12141         (dict_create_linear, dict_create_linear_expandable)
12142         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12143         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12144         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12145         taking multidictionary argument.
12146         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12147         * block.h (struct block) <dict>: Change to multidictionary
12148         and rename `multidict'.
12149         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12150         symmisc.c: Update all dictionary references to multidictionary.
12151
12152 2019-01-10  Keith Seitz  <keiths@redhat.com>
12153
12154         PR gdb/23712
12155         PR symtab/23010
12156         * dictionary.c: Include unordered_map.
12157         (pending_to_vector): New function.
12158         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12159         Rewrite the non-"_1" functions to take vector instead
12160         of linked list.
12161         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12162         "new" _1 versions of the same name.
12163         (multidictionary): Define.
12164         (std::hash<enum language): New definition.
12165         (collate_pending_symbols_by_language, mdict_create_hashed)
12166         (mdict_create_hashed_expandable, mdict_create_linear)
12167         (mdict_create_linear_expandable, mdict_free)
12168         (find_language_dictionary, create_new_language_dictionary)
12169         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12170         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12171         (mdict_size, mdict_empty): New functions.
12172         * dictionary.h (mdict_iterator): Define.
12173
12174 2019-01-10  Pedro Alves  <palves@redhat.com>
12175
12176         * breakpoint.c (read_uploaded_action)
12177         (create_tracepoint_from_upload): Adjust to use
12178         gdb::unique_xmalloc_ptr.
12179         * ctf.c (ctf_write_uploaded_tp):
12180         (SET_ARRAY_FIELD): Use emplace_back.
12181         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12182         * tracefile-tfile.c (tfile_write_uploaded_tp):
12183         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12184         gdb::unique_xmalloc_ptr.
12185         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12186         at_string, cond_string, cmd_strings>: Replace char pointers
12187         with gdb::unique_xmalloc_ptr.
12188
12189 2019-01-10  Pedro Alves  <palves@redhat.com>
12190
12191         * solib-target.c (library_list_start_library): Don't xstrdup name.
12192
12193 2019-01-10  Pedro Alves  <palves@redhat.com>
12194
12195         * mdebugread.c (parse_partial_symbols): Use
12196         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12197
12198 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12199
12200         * linux-fork.c (scoped_switch_fork_info)
12201         <~scoped_switch_fork_info>: Fix incorrect variable name.
12202
12203 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12204
12205         * linux-fork.c (scoped_switch_fork_info)
12206         <scoped_switch_fork_info>: Make explicit.
12207         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12208
12209 2019-01-10  Tom Tromey  <tom@tromey.com>
12210
12211         * objfiles.h (objfile::reset_psymtabs): Update.
12212         * objfiles.c (objfile::objfile): Update.
12213         * psymtab.h (psymtab_storage::obstack): Update.
12214         (psymtab_storage::m_obstack): Use gdb::optional.
12215         (class psymtab_storage): Update comment.  Remove objfile
12216         parameter.
12217         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12218
12219 2019-01-10  Tom Tromey  <tom@tromey.com>
12220
12221         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12222         <free_psymtabs>: Now private.
12223         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12224         (allocate_psymtab): Use new method.
12225
12226 2019-01-10  Tom Tromey  <tom@tromey.com>
12227
12228         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12229         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12230         * mdebugread.c (parse_partial_symbols): Use
12231         allocate_dependencies.
12232         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12233         allocate_dependencies.
12234         (process_psymtab_comp_unit_reader)
12235         (build_type_psymtab_dependencies): Likewise.
12236         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12237
12238 2019-01-10  Tom Tromey  <tom@tromey.com>
12239
12240         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12241         PSYMBOL_SET_LANGUAGE.
12242         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12243
12244 2019-01-10  Tom Tromey  <tom@tromey.com>
12245
12246         * psymtab.h (psymtab_storage::obstack): New method.
12247         <m_obstack>: Rename from obstack; now private.
12248         * psymtab.c (psymtab_storage): Update.
12249         * dwarf2read.c (create_addrmap_from_index)
12250         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12251         Update.
12252
12253 2019-01-10  Tom Tromey  <tom@tromey.com>
12254
12255         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12256         * objfiles.h (objfile::reset_psymtabs): New method.
12257
12258 2019-01-10  Tom Tromey  <tom@tromey.com>
12259
12260         * symmisc.c (print_symbol_bcache_statistics): Update.
12261         (print_objfile_statistics): Update.
12262         * symfile.c (reread_symbols): Update.
12263         * psymtab.h (class psymtab_storage): New.
12264         * psymtab.c (psymtab_storage): New constructor.
12265         (~psymtab_storage): New destructor.
12266         (require_partial_symbols): Update.
12267         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12268         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12269         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12270         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12271         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12272         (start_psymtab_common, end_psymtab_common)
12273         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12274         (allocate_psymtab): Update.
12275         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12276         Update.
12277         (dump_psymtab_addrmap, maintenance_print_psymbols)
12278         (maintenance_check_psymtabs): Update.
12279         (class objfile_psymtabs): Move to objfiles.h.
12280         * psympriv.h (discard_psymtab): Now inline.
12281         (psymtab_discarder::psymtab_discarder): Update.
12282         (psymtab_discarder::~psymtab_discarder): Update.
12283         (ALL_OBJFILE_PSYMTABS): Rewrite.
12284         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12285         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12286         Remove fields.
12287         <partial_symtabs>: New field.
12288         (class objfile_psymtabs): Move from psymtab.h.  Update.
12289         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12290         psymbol_cache.
12291         (objfile::~objfile): Don't destroy psymbol_cache.
12292         * mdebugread.c (parse_partial_symbols): Update.
12293         * dwarf2read.c (create_addrmap_from_index)
12294         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12295         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12296         (add_partial_subprogram, dwarf2_ranges_read): Update.
12297         * dwarf-index-write.c (write_address_map)
12298         (write_one_signatured_type, recursively_write_psymbols)
12299         (class debug_names, class debug_names, write_psymtabs_to_index):
12300         Update.
12301
12302 2019-01-10  Tom Tromey  <tom@tromey.com>
12303
12304         * symtab.h (SYMBOL_SET_NAMES): Update.
12305         (symbol_set_names): Update.
12306         (MSYMBOL_SET_NAMES): Update.
12307         * symtab.c (symbol_set_names): Change argument to be an
12308         objfile_per_bfd_storage.
12309         * psymtab.c (add_psymbol_to_bcache): Update.
12310         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12311
12312 2019-01-10  Tom Tromey  <tom@tromey.com>
12313
12314         * symtab.c (create_demangled_names_hash): Change argument to be an
12315         objfile_per_bfd_storage.
12316         (symbol_set_names): Update.
12317
12318 2019-01-10  Tom Tromey  <tom@tromey.com>
12319
12320         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12321         init_psymbol_list.
12322         * psymtab.c (init_psymbol_list): Do nothing if already called.
12323         * psympriv.h (init_psymbol_list): Add comment.
12324         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12325         init_psymbol_list.
12326         * dbxread.c (dbx_symfile_read): Unconditionally call
12327         init_psymbol_list.
12328
12329 2019-01-10  Tom Tromey  <tom@tromey.com>
12330
12331         * xcoffread.c (scan_xcoff_symtab): Update.
12332         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12333         "where".
12334         * mdebugread.c (parse_partial_symbols)
12335         (handle_psymbol_enumerators): Update.
12336         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12337         * dbxread.c (read_dbx_symtab): Update.
12338         * psympriv.h (psymbol_placement): New enum.
12339         (add_psymbol_to_list): Update.
12340
12341 2019-01-10  Tom Tromey  <tom@tromey.com>
12342
12343         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12344         static_psymbols parameters.
12345         (scan_xcoff_symtab): Update.
12346         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12347         static_psymbols parameters.
12348         * psympriv.h (start_psymtab_common): Update.
12349         * mdebugread.c (parse_partial_symbols): Update.
12350         * dwarf2read.c (create_partial_symtab): Update.
12351         * dbxread.c (read_dbx_symtab): Update.
12352         (start_psymtab): Remove global_psymbols and static_psymbols
12353         parameters.
12354
12355 2019-01-10  Tom Tromey  <tom@tromey.com>
12356
12357         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12358         * psymtab.c (allocate_psymtab): Add comment.
12359         * psympriv.h (allocate_psymtab): Add comment.
12360         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12361         initializations.
12362         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12363
12364 2019-01-10  Tom Tromey  <tom@tromey.com>
12365
12366         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12367         Don't declare.
12368         * mipsread.c: Include mdebugread.h.
12369         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12370         Declare.
12371         * elfread.c: Include mdebugread.h.
12372
12373 2019-01-09  Tom Tromey  <tom@tromey.com>
12374
12375         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12376         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12377         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12378         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12379         (psym_lookup_symbol, psym_find_last_source_symtab)
12380         (psym_forget_cached_source_info, psym_print_stats)
12381         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12382         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12383         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12384         (psym_find_compunit_symtab_by_address)
12385         (maintenance_print_psymbols, maintenance_info_psymtabs)
12386         (maintenance_check_psymtabs): Use ranged for.
12387         * psymtab.h (class objfile_psymtabs): New.
12388         (require_partial_symbols): Return objfile_psymtabs.
12389         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12390
12391 2019-01-09  Tom Tromey  <tom@tromey.com>
12392
12393         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12394         (find_pc_mapped_section, list_overlays_command)
12395         (map_overlay_command, unmap_overlay_command)
12396         (simple_overlay_update): Use all_objfiles.
12397         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12398         * printcmd.c (info_symbol_command): Use all_objfiles.
12399         * objfiles.h (ALL_OBJSECTIONS): Remove.
12400         * maint.c (maintenance_translate_address): Use all_objfiles.
12401         * gcore.c (gcore_create_callback): Use all_objfiles.
12402         (objfile_find_memory_regions): Likewise.
12403
12404 2019-01-09  Tom Tromey  <tom@tromey.com>
12405
12406         * symtab.c (find_line_symtab, info_sources_command)
12407         (make_source_files_completion_list): Use objfile_compunits.
12408         * source.c (select_source_symtab): Use objfile_compunits.
12409         * objfiles.h (struct objfile): Update comment.
12410         (ALL_OBJFILES): Remove.
12411         (ALL_FILETABS): Remove.
12412         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12413         objfile_compunits.
12414
12415 2019-01-09  Tom Tromey  <tom@tromey.com>
12416
12417         * symmisc.c (print_objfile_statistics, dump_objfile)
12418         (maintenance_print_symbols): Use compunit_filetabs.
12419         * source.c (forget_cached_source_info_for_objfile): Use
12420         compunit_filetabs.
12421         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12422         (ALL_FILETABS): Use compunit_filetabs.
12423         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12424         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12425
12426 2019-01-09  Tom Tromey  <tom@tromey.com>
12427
12428         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12429         (compunit_filetabs): New.
12430         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12431         compunit_filetabs.
12432         (info_sources_command, make_source_files_completion_list): Remove
12433         declaration.
12434         * symmisc.c (print_objfile_statistics, dump_objfile)
12435         (maintenance_print_symbols): Remove declaration.
12436         (maintenance_info_symtabs): Use compunit_filetabs.
12437         (maintenance_info_line_tables): Likewise.
12438         * source.c (select_source_symtab): Change local variable name.
12439         (forget_cached_source_info_for_objfile): Remove declaration.
12440         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12441         * objfiles.c (objfile_relocate1): Remove declaration.
12442         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12443         declaration.
12444         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12445         * coffread.c (coff_symtab_read): Remove declaration.
12446         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12447         compunit_filetabs.
12448
12449 2019-01-09  Tom Tromey  <tom@tromey.com>
12450
12451         * symtab.c (lookup_objfile_from_block)
12452         (find_pc_sect_compunit_symtab, search_symbols)
12453         (default_collect_symbol_completion_matches_break_on): Use
12454         objfile_compunits.
12455         * objfiles.h (ALL_COMPUNITS): Remove.
12456         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12457         * cp-support.c (add_symbol_overload_list_qualified): Use
12458         objfile_compunits.
12459         * ada-lang.c (ada_collect_symbol_completion_matches)
12460         (ada_add_global_exceptions): Use objfile_compunits.
12461
12462 2019-01-09  Tom Tromey  <tom@tromey.com>
12463
12464         * source.c (select_source_symtab)
12465         (forget_cached_source_info_for_objfile): Remove declaration.
12466         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12467         declaration.
12468         * maint.c (count_symtabs_and_blocks): Remove declaration.
12469         * cp-support.c (add_symbol_overload_list_qualified): Remove
12470         declaration.
12471         * coffread.c (coff_symtab_read): Remove declaration.
12472         * symtab.c (lookup_symbol_in_objfile_symtabs)
12473         (basic_lookup_transparent_type_1): Use objfile_compunits.
12474         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12475         (info_sources_command, search_symbols)
12476         (default_collect_symbol_completion_matches_break_on)
12477         (make_source_files_completion_list): Remove declaration.
12478         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12479         (ada_collect_symbol_completion_matches)
12480         (ada_add_global_exceptions): Remove declaration.
12481         * linespec.c (iterate_over_all_matching_symtabs): Use
12482         objfile_compunits.
12483         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12484         (class objfile_compunits): New.
12485         (ALL_COMPUNITS): Use objfile_compunits.
12486         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12487         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12488         objfile_compunits.
12489         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12490
12491 2019-01-09  Tom Tromey  <tom@tromey.com>
12492
12493         * symtab.c (search_symbols)
12494         (default_collect_symbol_completion_matches_break_on): Use
12495         objfile_msymbols.
12496         * ada-lang.c (ada_lookup_simple_minsym)
12497         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12498         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12499         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12500         objfile_msymbols.
12501         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12502         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12503         * objc-lang.c (find_methods): Use objfile_msymbols.
12504         (info_selectors_command, info_classes_command): Likewise.
12505         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12506         * objfiles.h (class objfile_msymbols): New.
12507         (ALL_OBJFILE_MSYMBOLS): Remove.
12508         (ALL_MSYMBOLS): Remove.
12509
12510 2019-01-09  Tom Tromey  <tom@tromey.com>
12511
12512         * common/next-iterator.h (next_adapter): Add Iterator template
12513         parameter.
12514         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12515         (class all_objfiles_safe): New.
12516         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12517         * objfiles.c (put_objfile_before): Update comment.
12518         (add_separate_debug_objfile): Likewise.
12519         (free_all_objfiles): Use all_objfiles_safe.
12520         (objfile_purge_solibs): Likewise.
12521
12522 2019-01-09  Tom Tromey  <tom@tromey.com>
12523
12524         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12525         (expand_symtab_containing_pc, lookup_static_symbol)
12526         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12527         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12528         all_objfiles.
12529         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12530         * breakpoint.c (create_overlay_event_breakpoint)
12531         (create_longjmp_master_breakpoint)
12532         (create_std_terminate_master_breakpoint)
12533         (create_exception_master_breakpoint): Use all_objfiles.
12534         * linux-thread-db.c (try_thread_db_load_from_pdir)
12535         (has_libpthread): Use all_objfiles.
12536         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12537         * linespec.c (iterate_over_all_matching_symtabs)
12538         (search_minsyms_for_name): Use all_objfiles.
12539         * maint.c (maintenance_info_sections): Use all_objfiles.
12540         * main.c (captured_main_1): Use all_objfiles.
12541         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12542         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12543         * guile/scm-pretty-print.c
12544         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12545         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12546         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12547         (maintenance_print_msymbols): Use all_objfiles.
12548         * source.c (select_source_symtab): Use all_objfiles.
12549         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12550         * symfile.c (remove_symbol_file_command)
12551         (expand_symtabs_matching, map_symbol_filenames): Use
12552         all_objfiles.
12553         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12554         all_objfiles.
12555         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12556         * objc-lang.c (find_methods): Use all_objfiles.
12557         * objfiles.c (have_partial_symbols, have_full_symbols)
12558         (have_minimal_symbols, qsort_cmp)
12559         (default_iterate_over_objfiles_in_search_order): Use
12560         all_objfiles.
12561         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12562         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12563         (maintenance_check_psymtabs): Use all_objfiles.
12564         (ALL_PSYMTABS): Remove.
12565         * compile/compile-object-run.c (do_module_cleanup): Use
12566         all_objfiles.
12567         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12568         * cp-support.c (add_symbol_overload_list_qualified): Use
12569         all_objfiles.
12570         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12571         Use all_objfiles.
12572         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12573         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12574         all_objfiles.
12575         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12576         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12577         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12578         Uses all_objfiles.
12579         * solib.c (solib_read_symbols): Use all_objfiles
12580
12581 2019-01-09  Tom Tromey  <tom@tromey.com>
12582
12583         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12584         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12585         all_objfiles.
12586         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12587         * symmisc.c (print_symbol_bcache_statistics)
12588         (print_objfile_statistics, maintenance_print_objfiles)
12589         (maintenance_info_symtabs, maintenance_check_symtabs)
12590         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12591         all_objfiles.
12592         * source.c (forget_cached_source_info): Use all_objfiles.
12593         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12594         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12595         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12596         * objfiles.c (update_section_map): Use all_objfiles.
12597         (shared_objfile_contains_address_p): Likewise.
12598         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12599         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12600
12601 2019-01-09  Tom Tromey  <tom@tromey.com>
12602
12603         * common/next-iterator.h: New file.
12604         * objfiles.h (class all_objfiles): New.
12605         (struct objfile_iterator): New.
12606
12607 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12608
12609         * NEWS: Move the description of the changed "frame", "select-frame",
12610          and "info frame" commands to the Changed commands section.
12611
12612 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12613
12614         * gdbtypes.c (check_stub_method_group): Remove handling of old
12615         mangling schemes.
12616         * linespec.c (find_methods): Likewise.
12617         * stabsread.c (read_member_functions): Likewise.
12618         * valops.c (search_struct_method): Likewise.
12619         (value_struct_elt_for_reference): Likewise.
12620         * NEWS: Mention this change.
12621
12622 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
12623
12624         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
12625         print_source_lines.
12626         * source.c (print_source_lines_base): Update line number check.
12627         (print_source_lines): New function.
12628         (source_lines_range::source_lines_range): New function.
12629         * source.h (class source_lines_range): New class.
12630         (print_source_lines): New declaration.
12631
12632 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12633
12634         * linespec.c (linespec_state_destructor): Free self->canonical_names.
12635
12636 2019-01-08  Tom Tromey  <tom@tromey.com>
12637             Simon Marchi  <simon.marchi@ericsson.com>
12638
12639         PR gdb/24060
12640         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
12641         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
12642         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12643         * f-exp.y (DOLLAR_VARIABLE): Likewise.
12644         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
12645         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
12646
12647 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12648
12649         * source.c (select_source_symtab): Move header comment to
12650         declaration in source.h.
12651         (forget_cached_source_info_for_objfile): Likewise.
12652         (forget_cached_source_info): Likewise.
12653         (identify_source_line): Likewise.
12654         * source.h (identify_source_line): Move declaration from symtab.h
12655         and add comment from source.c
12656         (print_source_lines): Likewise.
12657         (forget_cached_source_info_for_objfile): Likewise.
12658         (forget_cached_source_info): Likewise.
12659         (select_source_symtab): Likewise.
12660         (enum print_source_lines_flag): Move definition from symtab.h.
12661         * symtab.h (identify_source_line): Move declaration to source.h.
12662         (print_source_lines): Likewise.
12663         (forget_cached_source_info_for_objfile): Likewise.
12664         (forget_cached_source_info): Likewise.
12665         (select_source_symtab): Likewise.
12666         (enum print_source_lines_flag): Move definition to source.h.
12667         * tui/tui-hooks.c: Add 'source.h' include.
12668
12669 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12670
12671         * source.c (print_source_lines_base): Handle requests to print
12672         reverse line number sequences, and guard against empty lines
12673         string.
12674
12675 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
12676
12677         * source.c (print_source_lines_base): Fix skip of '\r' if next
12678         character is '\n'.
12679
12680 2019-01-06  Tom Tromey  <tom@tromey.com>
12681
12682         * c-exp.y (struct c_parse_state) <macro_original_text,
12683         expansion_obstack>: New member.
12684         (macro_original_text, expansion_obstack): Remove globals.
12685         (scan_macro_expansion, scanning_macro_expansion)
12686         (finished_macro_expansion): Update.
12687         (scan_macro_cleanup): Remove.
12688         (yylex, c_parse): Update.
12689
12690 2019-01-06  Tom Tromey  <tom@tromey.com>
12691
12692         * c-exp.y (struct c_parse_state) <strings>: New member.
12693         (operator_stoken): Update.
12694
12695 2019-01-06  Tom Tromey  <tom@tromey.com>
12696
12697         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
12698         (union type_stack_elt) <typelist_val>: Now a pointer to
12699         std::vector.
12700         (type_stack_cleanup): Don't declare.
12701         (push_typelist): Update.
12702         * parse.c (pop_typelist): Return a std::vector.
12703         (push_typelist): Take a std::vector.
12704         (follow_types): Update.  Do not free args.
12705         (type_stack_cleanup): Remove.
12706         * c-exp.y (struct c_parse_state): New.
12707         (cpstate): New global.
12708         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
12709         (nonempty_typelist): Update.
12710         (func_mod): Create a new vector.
12711         (c_parse): Create a c_parse_state.
12712         (check_parameter_typelist): Do not delete params.
12713         (function_method): Update.  Do not delete type_list.
12714
12715 2019-01-06  Tom Tromey  <tom@tromey.com>
12716
12717         PR gdb/28155:
12718         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
12719         check_typedef.
12720         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
12721         (print_return_value): Likewise.
12722
12723 2019-01-05  Tom Tromey  <tom@tromey.com>
12724
12725         * contrib/cleanup_check.py: Remove.
12726         * contrib/gcc-with-excheck: Remove.
12727         * contrib/exsummary.py: Remove.
12728         * contrib/excheck.py: Remove.
12729
12730 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
12731
12732         * thread.c (delete_thread_1): Add gdb_assert that THR is not
12733         NULL. Initialize tpprev to NULL instead of assigning it
12734         to NULL on the next statement.
12735         * windows-nat.c (windows_delete_thread): Remove check for
12736         main_thread_id before printing thread exit notifications.
12737         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
12738         Remove thread ID check against main_thread_id.
12739         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
12740         windows_delete_thread.
12741         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
12742
12743 2019-01-04  Tom Tromey  <tom@tromey.com>
12744
12745         * compile/compile.c (_initialize_compile): Use upper case for
12746         metasyntactic variables.
12747         * symmisc.c (_initialize_symmisc): Use upper case for
12748         metasyntactic variables.
12749         * psymtab.c (_initialize_psymtab): Use upper case for
12750         metasyntactic variables.
12751         * demangle.c (demangle_command): Use upper case for metasyntactic
12752         variables.
12753         (_initialize_demangler): Likewise.
12754         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
12755         variables.
12756
12757 2019-01-03  Tom Tromey  <tom@tromey.com>
12758
12759         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
12760
12761 2019-01-03  Tom Tromey  <tom@tromey.com>
12762
12763         * python/py-symtab.c (salpy_str): Update.
12764         (struct salpy_sal_object) <symtab>: Now a PyObject.
12765         (salpy_dealloc): Update.
12766         (del_objfile_sal): Use gdbpy_ref.
12767
12768 2019-01-03  Tom Tromey  <tom@tromey.com>
12769
12770         * python/py-type.c (convert_field): Use new_reference.  Return
12771         gdbpy_ref.
12772         (make_fielditem): Return gdbpy_ref.
12773         (typy_fields): Update.
12774         (typy_getitem): Update.
12775         (field_name): Return gdbpy_ref.  Use new_reference.
12776         (typy_iterator_iternext): Update.
12777
12778 2019-01-03  Tom Tromey  <tom@tromey.com>
12779
12780         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
12781
12782 2019-01-03  Tom Tromey  <tom@tromey.com>
12783
12784         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
12785         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
12786         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
12787         (pspy_set_frame_filters, pspy_set_frame_unwinders)
12788         (pspy_set_type_printers): Likewise.
12789         * python/py-function.c (fnpy_init): Use gdbpy_ref.
12790         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
12791         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
12792         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
12793         (objfpy_set_type_printers): Likewise.
12794
12795 2019-01-03  Tom Tromey  <tom@tromey.com>
12796
12797         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
12798         (gdbpy_print_stack): Use gdbpy_err_fetch.
12799         * python/python-internal.h (class gdbpy_err_fetch): New class.
12800         (class gdbpy_enter) <m_error_type, m_error_value,
12801         m_error_traceback>: Remove.
12802         <m_error>: New member.
12803         (gdbpy_exception_to_string): Don't declare.
12804         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
12805         * python/py-value.c (convert_value_from_python): Use
12806         gdbpy_err_fetch.
12807         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
12808         gdbpy_exception_to_string.
12809         (gdbpy_handle_exception): Use gdbpy_err_fetch.
12810         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
12811         gdbpy_err_fetch.
12812
12813 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12814
12815         * linux-nat.c (delete_lwp_cleanup): Delete.
12816         (struct lwp_deleter): New struct.
12817         (lwp_info_up): New typedef.
12818         (linux_nat_target::follow_fork): Delete cleanup, and make use of
12819         lwp_info_up.
12820
12821 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12822
12823         * linux-fork.c (class scoped_switch_fork_info): New class.
12824         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
12825
12826 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12827
12828         * valops.c (find_overload_match): Remove use of null_cleanup, and
12829         calls to do_cleanups.
12830
12831 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12832
12833         * compile/compile-cplus-types.c
12834         (compile_cplus_instance::decl_name): Handle changes to
12835         cp_func_name.
12836         * cp-support.c (cp_func_name): Update header comment, update
12837         return type.
12838         * cp-support.h (cp_func_name): Update return type in declaration.
12839         * valops.c (find_overload_match): Move temp_func local to top
12840         level of function and change its type.  Use temp_func to hold and
12841         delete temporary string obtained from cp_func_name.
12842
12843 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
12844
12845         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
12846         gdb::char_vector, remove cleanup, and update uses of `msg`.
12847
12848 2019-01-03  Jim Wilson  <jimw@sifive.com>
12849
12850         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
12851
12852 2019-01-02  Tom Tromey  <tom@tromey.com>
12853
12854         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
12855         (tdesc_parse_xml): Remove cleanups.
12856         * target-descriptions.h (make_cleanup_free_target_description):
12857         Don't declare.
12858         (target_desc_deleter): New struct.
12859         (target_desc_up): New typedef.
12860         * target-descriptions.c (target_desc_deleter::operator()): Rename
12861         from free_target_description.
12862         (make_cleanup_free_target_description): Remove.
12863
12864 2019-01-02  Tom Tromey  <tom@tromey.com>
12865
12866         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
12867         constructor, destructor.
12868         (linespec_parser): Remove typedef.
12869         (~linespec_parser): Rename from linespec_parser_delete.
12870         (linespec_lex_to_end, linespec_complete_label)
12871         (linespec_complete): Update.
12872         (decode_line_full): Remove cleanups.
12873         (decode_line_1): Update.
12874
12875 2019-01-02  Tom Tromey  <tom@tromey.com>
12876
12877         * python/python-internal.h (inferior_to_inferior_object): Change
12878         return type.
12879         * python/py-exitedevent.c (create_exited_event_object): Update.
12880         * python/py-inferior.c (inferior_to_inferior_object): Return
12881         gdbpy_ref.
12882         (python_new_inferior, python_inferior_deleted)
12883         (thread_to_thread_object, delete_thread_object)
12884         (build_inferior_list, gdbpy_selected_inferior): Update.
12885         * python/py-infthread.c (create_thread_object): Update.  Also fail
12886         if inferior_to_inferior_object fails.
12887
12888 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
12889
12890         * inferior.h (class inferior) <displaced_step_state>: New field.
12891         * infrun.h (struct displaced_step_state): Move here from
12892         infrun.c.  Initialize fields, add constructor.
12893         <inf>: Remove field.
12894         <reset>: New method.
12895         * infrun.c (struct displaced_step_inferior_state): Move to
12896         infrun.h.
12897         (displaced_step_inferior_states): Remove.
12898         (get_displaced_stepping_state): Adust.
12899         (displaced_step_in_progress_any_inferior): Adjust.
12900         (displaced_step_in_progress_thread): Adjust.
12901         (displaced_step_in_progress): Adjust.
12902         (add_displaced_stepping_state): Remove.
12903         (get_displaced_step_closure_by_addr): Adjust.
12904         (remove_displaced_stepping_state): Remove.
12905         (infrun_inferior_exit): Call displaced_step_state.reset.
12906         (use_displaced_stepping): Don't check for NULL.
12907         (displaced_step_prepare_throw): Call
12908         get_displaced_stepping_state.
12909         (displaced_step_fixup): Don't check for NULL.
12910         (prepare_for_detach): Don't check for NULL.
12911
12912 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12913
12914         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
12915          in case of call that did not complete.
12916
12917 2019-01-02  Andrey Utkin  <autkin@undo.io>
12918
12919         * symfile.c (find_separate_debug_file): Fix search of debug files for
12920         remote debuggee.
12921
12922 2019-01-02  Tom Tromey  <tom@tromey.com>
12923
12924         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
12925         indentation.
12926         * python/py-frame.c (frapy_older): Remove cast.
12927         (frapy_newer): Likewise.
12928         * python/py-breakpoint.c (local_setattro): Remove cast.
12929         * python/py-arch.c (archpy_name): Remove local variable.
12930         * python/py-type.c (gdbpy_lookup_type): Remove cast.
12931
12932 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
12933
12934         * unittests/basic_string_view/element_access/char/empty.cc:
12935         Fix year range in copyright header.
12936
12937 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
12938
12939         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
12940         Delete.
12941         <operator==>: Update with for removed field.
12942         <hash>: Likewise.
12943         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
12944         <isa_features>: ...this.
12945         <abi_features>: New field.
12946         (riscv_isa_flen): Update comment.
12947         (riscv_abi_xlen): New declaration.
12948         (riscv_abi_flen): New declaration.
12949         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
12950         isa_features.
12951         (riscv_abi_xlen): New function.
12952         (riscv_isa_flen): Update to get answer from isa_features.
12953         (riscv_abi_flen): New function.
12954         (riscv_has_fp_abi): Update to get answer from abi_features.
12955         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
12956         xlen and flen.
12957         (riscv_call_info) <xlen, flen>: Update comment.
12958         (riscv_call_arg_struct): Remove invalid assertions
12959         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
12960         is removed.
12961         (riscv_gdbarch_init): Gather isa features and abi features
12962         separately, ensure both match on the gdbarch when reusing an old
12963         gdbarch.  Relax an error check to allow 32-bit abi float to run on
12964         a target with 64-bit float hardware.
12965
12966 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12967
12968         * source.c (search_command_helper): Stop reverse search
12969         when line 1 has been searched.
12970
12971 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12972
12973         * record-full.c (record_full_base_target::close): Rewrite
12974         record_full_core_buf_list free logic.
12975
12976 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12977
12978         * break-catch-syscall.c (print_one_catch_syscall): xfree
12979         the last text.
12980
12981 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12982
12983         * top.c (print_gdb_version): Update Copyright year in version
12984         message.
12985
12986 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
12987
12988         Update copyright year range in all GDB files.
12989
12990 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
12991
12992         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
12993
12994 For older changes see ChangeLog-2018.
12995 \f
12996 Local Variables:
12997 mode: change-log
12998 left-margin: 8
12999 fill-column: 74
13000 version-control: never
13001 coding: utf-8
13002 End:
13003