gdb/ChangeLog

   1 2020-07-06  Tom de Vries  <tdevries@suse.de>
   2
   3         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Handle
   4         End-Of-Sequence in lte_is_less_than.
   5         * symtab.c (find_pc_sect_line): Revert change from commit 3d92a3e313
   6         "gdb: Don't reorder line table entries too much when sorting".
   7
   8 2020-07-06  Tom de Vries  <tdevries@suse.de>
   9
  10         PR tui/26205
  11         * tui/tui-win.c (tui_partial_win_by_name): Don't test for NULL name.
  12
  13 2020-07-05  Tom de Vries  <tdevries@suse.de>
  14
  15         PR build/26187
  16         * inferior.h (struct infcall_suspend_state_deleter): If available, use
  17         std::uncaught_exceptions instead of deprecated
  18         std::uncaught_exception.
  19
  20 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  21
  22         * macroexp.h (macro_stringify): Return
  23         gdb::unique_xmalloc_ptr<char>.
  24         * macroexp.c (macro_stringify): Likewise.
  25         * macrotab.c (fixup_definition): Update.
  26
  27 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  28
  29         * c-exp.y (scan_macro_expansion): Don't free `expansion`.
  30         (lex_one_token): Update.
  31         * macroexp.c (struct macro_buffer) <release>: Return
  32         gdb::unique_xmalloc_ptr<char>.
  33         (macro_stringify): Update.
  34         (macro_expand): Update.
  35         (macro_expand_next): Return gdb::unique_xmalloc_ptr<char>.
  36         * macroexp.h (macro_expand_next): Likewise.
  37
  38 2020-07-02  Simon Marchi  <simon.marchi@efficios.com>
  39
  40         * macroexp.h (macro_lookup_ftype): Remove.
  41         (macro_expand, macro_expand_once, macro_expand_next): Remove
  42         lookup function parameters, add scope parameter.
  43         * macroexp.c (scan, substitute_args, expand, maybe_expand,
  44         macro_expand, macro_expand_once, macro_expand_next): Likewise.
  45         * macroscope.h (standard_macro_lookup): Change parameter type
  46         to macro_scope.
  47         * macroscope.c (standard_macro_lookup): Likewise.
  48         * c-exp.y (lex_one_token): Update.
  49         * macrocmd.c (macro_expand_command): Likewise.
  50         (macro_expand_once_command): Likewise.
  51
  52 2020-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  53
  54         * inf-loop.c (inferior_event_handler): Remove client_data param.
  55         * inf-loop.h (inferior_event_handler): Likewise.
  56         * infcmd.c (step_1): Adjust.
  57         * infrun.c (proceed): Adjust.
  58         (fetch_inferior_event): Remove client_data param.
  59         (infrun_async_inferior_event_handler): Adjust.
  60         * infrun.h (fetch_inferior_event): Remove `void *` param.
  61         * linux-nat.c (handle_target_event): Adjust.
  62         * record-btrace.c (record_btrace_handle_async_inferior_event):
  63         Adjust.
  64         * record-full.c (record_full_async_inferior_event_handler):
  65         Adjust.
  66         * remote.c (remote_async_inferior_event_handler): Adjust.
  67
  68 2020-07-01  Tom Tromey  <tom@tromey.com>
  69
  70         * tui/tui-data.h (struct tui_win_info) <name>: Now pure virtual.
  71         * tui/tui-stack.h (struct tui_locator_window) <name>: New method.
  72
  73 2020-07-01  Tom Tromey  <tom@tromey.com>
  74
  75         * tui/tui-wingeneral.c (tui_win_info::refresh_window): Move from
  76         tui_gen_win_info.
  77         (tui_win_info::make_window): Merge with
  78         tui_gen_win_info::make_window.
  79         (tui_win_info::make_visible): Move from tui_gen_win_info.
  80         * tui/tui-win.c (tui_win_info::max_width): Move from
  81         tui_gen_win_info.
  82         * tui/tui-layout.h (class tui_layout_window) <m_window>: Change
  83         type.
  84         <window_factory>: Likewise.
  85         * tui/tui-layout.c (tui_win_info::resize): Move from
  86         tui_gen_win_info.
  87         (make_standard_window): Change return type.
  88         (get_locator_window, tui_get_window_by_name): Likewise.
  89         (tui_layout_window::apply): Remove a cast.
  90         * tui/tui-data.h (MIN_WIN_HEIGHT): Move earlier.
  91         (struct tui_win_info): Merge with tui_gen_win_info.
  92         (struct tui_gen_win_info): Remove.
  93
  94 2020-07-01  Tom Tromey  <tom@tromey.com>
  95
  96         * tui/tui-stack.h (struct tui_locator_window): Derive from
  97         tui_win_info.
  98         <do_scroll_horizontal, do_scroll_vertical>: New methods.
  99         <can_box>: New method.
 100
 101 2020-07-01  Tom Tromey  <tom@tromey.com>
 102
 103         * tui/tui-stack.h (struct tui_locator_window): Remove body.
 104
 105 2020-07-01  Tom Tromey  <tom@tromey.com>
 106
 107         * tui/tui-regs.c (tui_data_window::display_registers_from)
 108         (tui_data_window::display_registers_from)
 109         (tui_data_window::first_data_item_displayed)
 110         (tui_data_window::delete_data_content_windows): Update.
 111         (tui_data_window::refresh_window, tui_data_window::no_refresh):
 112         Remove.
 113         (tui_data_window::check_register_values): Update.
 114         (tui_data_item_window::rerender): Add parameters.  Update.
 115         (tui_data_item_window::refresh_window): Remove.
 116         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: No longer
 117         virtual.
 118         * tui/tui-regs.h (struct tui_data_item_window): Don't derive from
 119         tui_gen_win_info.
 120         <refresh_window, max_height, min_height>: Remove.
 121         <rerender>: Add parameters.
 122         <x, y, visible>: New members.
 123         (struct tui_data_window) <refresh_window, no_refresh>: Remove.
 124         <m_item_width>: New member.
 125
 126 2020-07-01  Tom Tromey  <tom@tromey.com>
 127
 128         * tui/tui-regs.c (tui_data_window::show_register_group)
 129         (tui_data_window::check_register_values): Update.
 130         * tui/tui-regs.h (struct tui_data_item_window) <regno>: Rename
 131         from item_no.
 132
 133 2020-07-01  Tom Tromey  <tom@tromey.com>
 134
 135         * tui/tui-regs.c (tui_data_window::show_register_group): Remove
 136         useless "if".
 137
 138 2020-07-01  Tom Tromey  <tom@tromey.com>
 139
 140         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
 141         * tui/tui-regs.h (struct tui_data_item_window) <name>: Remove.
 142
 143 2020-07-01  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-stack.c (SINGLE_KEY): Move from tui-data.h
 146         * tui/tui-winsource.h (enum tui_line_or_address_kind)
 147         (struct tui_line_or_address): Move from tui-data.h.
 148         * tui/tui-win.c (DEFAULT_TAB_LEN): Move from tui-data.h.
 149         * tui/tui-data.h (DEFAULT_TAB_LEN): Move to tui-win.c.
 150         (tui_cmd_window, tui_source_window_base, tui_source_window)
 151         (tui_disasm_window): Don't declare.
 152         (enum tui_line_or_address_kind, struct tui_line_or_address): Move
 153         to tui-winsource.h.
 154         (SINGLE_KEY): Move to tui-stack.c.
 155
 156 2020-07-01  Tom Tromey  <tom@tromey.com>
 157
 158         * tui/tui-regs.h (struct tui_data_item_window) <content>: Now a
 159         std::string.
 160         * tui/tui-regs.c (class tab_expansion_file): New.
 161         (tab_expansion_file::write): New method.
 162         (tui_register_format): Change return type.  Use
 163         tab_expansion_file.
 164         (tui_get_register, tui_data_window::display_registers_from)
 165         (tui_data_item_window::rerender): Update.
 166         * tui/tui-io.h (tui_expand_tabs): Don't declare.
 167         * tui/tui-io.c (tui_expand_tabs): Remove.
 168
 169 2020-07-01  Tom Tromey  <tom@tromey.com>
 170
 171         * tui/tui-regs.c (tui_reggroup_completer): Use complete_on_enum.
 172
 173 2020-07-01  Fangrui Song  <maskray@google.com>
 174
 175         * dwarf2/read.c (lnp_state_machine::check_line_address): Test -1.
 176
 177 2020-07-01  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
 178
 179         * dwarf2/read.c (set_die_type): Removed conditions to restrict
 180         forms for DW_AT_associated and DW_AT_allocated attributes,
 181         which is already checked in function attr_to_dynamic_prop.
 182
 183 2020-06-30  Tom Tromey  <tromey@adacore.com>
 184
 185         * dwarf2/read.c (quirk_rust_enum): Correctly call
 186         alloc_rust_variant for default-less enum.
 187
 188 2020-06-30  Tom Tromey  <tromey@adacore.com>
 189
 190         PR build/26183:
 191         * ada-lang.c (ada_lookup_name_info::ada_lookup_name_info): Use
 192         gdb::to_string.
 193
 194 2020-06-29  Simon Marchi  <simon.marchi@efficios.com>
 195
 196         * gdbarch.sh (displaced_step_copy_insn): Update doc.
 197         * gdbarch.h: Re-generate.
 198
 199 2020-06-28  Tom Tromey  <tom@tromey.com>
 200
 201         * command.h (cmd_types): Remove.
 202         (cmd_type): Don't declare.
 203         * cli/cli-decode.h (enum cmd_types): Uncomment.  No longer a
 204         typedef.
 205         * cli/cli-cmds.c (setting_cmd): Use cmd->type directly.
 206         * cli/cli-decode.c (cmd_type): Remove.
 207
 208 2020-06-27  Pedro Alves  <palves@redhat.com>
 209
 210         * fork-child.c (prefork_hook): Adjust.
 211         * infcmd.c (set_inferior_io_terminal, get_inferior_io_terminal):
 212         Delete.
 213         (set_inferior_tty_command, show_inferior_tty_command): Adjust.
 214         * inferior.c (inferior::set_tty, inferior::tty): New methods.
 215         * inferior.h (set_inferior_io_terminal, get_inferior_io_terminal):
 216         Remove declarations.
 217         (struct inferior) <set_tty, tty>: New methods.
 218         (struct inferior) <terminal>: Rename to ...
 219         (struct inferior) <m_terminal>: ... this and make private.
 220         * main.c (captured_main_1): Adjust.
 221         * mi/mi-cmd-env.c (mi_cmd_inferior_tty_set): Adjust.
 222         (mi_cmd_inferior_tty_show): Adjust.
 223         * nto-procfs.c (nto_procfs_target::create_inferior): Adjust.
 224         * windows-nat.c (windows_nat_target::create_inferior): Adjust.
 225
 226 2020-06-26  Nick Alcock  <nick.alcock@oracle.com>
 227
 228         * configure.ac: Add --enable-libctf: handle --disable-static
 229         properly.
 230         * acinclude.m4: sinclude ../config/enable.m4.
 231         * Makefile.in (aclocal_m4_deps): Adjust accordingly.
 232         (LIBCTF): Substitute in.
 233         (CTF_DEPS): New, likewise.
 234         (CLIBS): libctf needs symbols from libbfd: move earlier.
 235         (CDEPS): Use CTF_DEPS, not LIBCTF, now LIBCTF can include rpath
 236         flags.
 237         * ctfread.c: Surround in ENABLE_LIBCTF.
 238         (elfctf_build_psymtabs) [!ENABLE_LIBCTF]: New stub.
 239         * configure: Regenerate.
 240         * config.in: Likewise.
 241
 242 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
 243
 244         * infcmd.c (set_inferior_io_terminal): Use make_unique_xstrdup.
 245
 246 2020-06-25  Simon Marchi  <simon.marchi@efficios.com>
 247
 248         * inferior.h (struct inferior) <terminal>: Change type to
 249         gdb::unique_xmalloc_ptr<char>.
 250         * inferior.c (inferior::~inferior): Don't free inf->terminal.
 251         * infcmd.c (set_inferior_io_terminal): Don't free terminal
 252         field, adjust to unique pointer.
 253         (get_inferior_io_terminal): Adjust to unique pointer.
 254
 255 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * riscv-tdep.c (riscv_print_registers_info): Loop over all
 258         registers, not just the known core set of registers.
 259
 260 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 261
 262         * riscv-tdep.c (riscv_register_name): Return NULL for duplicate
 263         fflags, frm, and fcsr registers.
 264         (riscv_register_reggroup_p): Remove unknown CSRs from save and
 265         restore groups.
 266         (riscv_tdesc_unknown_reg): New function.
 267         (riscv_gdbarch_init): Pass riscv_tdesc_unknown_reg to
 268         tdesc_use_registers.
 269         * riscv-tdep.h (struct gdbarch_tdep): Add
 270         unknown_csrs_first_regnum, unknown_csrs_count,
 271         duplicate_fflags_regnum, duplicate_frm_regnum, and
 272         duplicate_fcsr_regnum fields.
 273
 274 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 275
 276         * target-descriptions.c (tdesc_use_registers): Add new parameter a
 277         callback, use the callback (when not null) to help number unknown
 278         registers.
 279         * target-descriptions.h (tdesc_unknown_register_ftype): New typedef.
 280         (tdesc_use_registers): Add extra parameter to declaration.
 281
 282 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 283
 284         * riscv-tdep.c (value_of_riscv_user_reg): Moved to here from later
 285         in the file.
 286         (class riscv_pending_register_alias): Likewise.
 287         (riscv_register_feature::register_info): Change 'required_p' field
 288         to 'required', and change its type.  Add 'check' member function.
 289         (riscv_register_feature::register_info::check): Define new member
 290         function.
 291         (riscv_xreg_feature): Change initialisation of 'required' field.
 292         (riscv_freg_feature): Likewise.
 293         (riscv_virtual_feature): Likewise.
 294         (riscv_csr_feature): Likewise.
 295         (riscv_check_tdesc_feature): Take extra parameter, the csr
 296         tdesc_feature, rewrite the function to use the new
 297         riscv_register_feature::register_info::check function.
 298         (riscv_gdbarch_init): Pass the csr tdesc_feature where needed.
 299
 300 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 301
 302         * features/Makefile: Remove all references to the deleted files
 303         below.
 304         * features/riscv/32bit-csr.c: Deleted.
 305         * features/riscv/32bit-csr.xml: Deleted.
 306         * features/riscv/64bit-csr.c: Deleted.
 307         * features/riscv/64bit-csr.xml: Deleted.
 308         * features/riscv/rebuild-csr-xml.sh: Deleted.
 309
 310 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 311
 312         * riscv-tdep.c (struct riscv_register_feature::register_info): Fix
 313         whitespace error for declaration of names member variable.
 314         (struct riscv_register_feature): Add new prefer_first_name member
 315         variable, and fix whitespace error in declaration of registers.
 316         (riscv_xreg_feature): Initialize prefer_first_name field.
 317         (riscv_freg_feature): Likewise.
 318         (riscv_virtual_feature): Likewise.
 319         (riscv_csr_feature): Likewise.
 320         (riscv_register_name): Expand on comments.  Remove register name
 321         modifications for CSR and virtual registers.
 322
 323 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 324
 325         * riscv-tdep.c (struct riscv_register_feature): Fix whitespace
 326         errors.
 327
 328 2020-06-25  Andrew Burgess  <andrew.burgess@embecosm.com>
 329
 330         * riscv-tdep.c (riscv_create_csr_aliases): Handle csr aliases from
 331         riscv-opc.h.
 332         (class riscv_pending_register_alias): New class.
 333         (riscv_check_tdesc_feature): Take vector of pending aliases and
 334         populate it as appropriate.
 335         (riscv_setup_register_aliases): Delete.
 336         (riscv_gdbarch_init): Create vector of pending aliases and pass it
 337         to riscv_check_tdesc_feature in all cases.  Use the vector to
 338         create the register aliases.
 339
 340 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 341
 342         * sol2-tdep.c (sol2_static_transform_name): Remove.
 343         (sol2_init_abi): Don't register it.
 344         * gdbarch.sh (static_transform_name): Remove.
 345         * gdbarch.c, gdbarch.h: Regenerate.
 346
 347         * dbxread.c (read_dbx_symtab) <'S'>: Remove call to
 348         gdbarch_static_transform_name.
 349         * mdebugread.c (parse_partial_symbols) <'S'>: Likewise.
 350         * stabsread.c (define_symbol) <'X'>: Remove.
 351         (define_symbol) <'S'>: Remove gdbarch_static_transform_name
 352         handling.
 353         <'V'>: Likewise.
 354         * xcoffread.c (scan_xcoff_symtab): Remove gdbarch.
 355         <'S'>: Remove call to gdbarch_static_transform_name.
 356
 357 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 358
 359         * procfs.c (procfs_pre_trace): New function.
 360         (procfs_target::create_inferior): Pass it to fork_inferior.
 361
 362 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 363
 364         * configure.tgt <sparc-*-linux*> (gdb_target_obs): Remove
 365         sparc-sol2-tdep.o, sol2-tdep.o, sparc64-sol2-tdep.o.
 366         <sparc64-*-linux*> (gdb_target_obs): Remove sparc64-sol2-tdep.o,
 367         sol2-tdep.o, sparc-sol2-tdep.o.
 368         * sparc-sol2-tdep.c (sparc32_sol2_init_abi): Make static.
 369         * sparc-tdep.h (sparc32_sol2_init_abi): Remove.
 370         * sparc64-sol2-tdep.c (sparc64_sol2_init_abi): Make static.
 371         * sparc64-tdep.h (sparc64_sol2_init_abi): Remove.
 372
 373 2020-06-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 374
 375         * amd64-sol2-tdep.c (amd64_sol2_sigtramp_p): Remove.
 376         (amd64_sol2_init_abi): Use sol2_sigtramp_p.
 377         Call sol2_init_abi.
 378         Remove calls to set_gdbarch_skip_solib_resolver,
 379         set_gdbarch_core_pid_to_str.
 380         * i386-sol2-tdep.c (i386_sol2_sigtramp_p): Remove.
 381         (i386_sol2_static_transform_name): Remove.
 382         (i386_sol2_init_abi): Call sol2_init_abi.
 383         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 384         set_gdbarch_static_transform_name,
 385         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 386         Use sol2_sigtramp_p.
 387         * sol2-tdep.c (sol2_pc_in_sigtramp): New function.
 388         (sol2_sigtramp_p): New function.
 389         (sol2_static_transform_name): New function.
 390         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Make static.
 391         (sol2_init_abi): New function.
 392         * sol2-tdep.h (sol2_sigtramp_p, sol2_init_abi): Declare.
 393         (sol2_skip_solib_resolver, sol2_core_pid_to_str): Remove.
 394         * sparc-sol2-tdep.c (sparc_sol2_pc_in_sigtramp): Remove.
 395         (sparc32_sol2_sigtramp_frame_sniffer): Just call sol2_sigtramp_p.
 396         (sparc_sol2_static_transform_name): Remove.
 397         (sparc32_sol2_init_abi): Call sol2_init_abi.
 398         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 399         set_gdbarch_static_transform_name,
 400         set_gdbarch_skip_solib_resolver,
 401         set_gdbarch_core_pid_to_str.
 402         * sparc-tdep.h (sparc_sol2_pc_in_sigtramp)
 403         (sparc_sol2_static_transform_name): Remove
 404         * sparc64-sol2-tdep.c (sparc64_sol2_sigtramp_frame_sniffer): Just
 405         call sol2_sigtramp_p.
 406         (sparc64_sol2_init_abi): Call sol2_init_abi.
 407         Remove calls to set_gdbarch_sofun_address_maybe_missing,
 408         set_gdbarch_static_transform_name,
 409         set_gdbarch_skip_solib_resolver, set_gdbarch_core_pid_to_str.
 410
 411 2020-06-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 412
 413         * symfile-add-flags.h: New flag SYMFILE_ALWAYS_CONFIRM.
 414         * exec.c (validate_exec_file): If from_tty, set both
 415         SYMFILE_VERBOSE (== from_tty) and SYMFILE_ALWAYS_CONFIRM.
 416         * symfile.c (symbol_file_add_with_addrs): if always_confirm
 417         and from_tty, unconditionally ask a confirmation.
 418
 419 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 420
 421         * target-descriptions.c (tdesc_architecture_name): Protect against
 422         NULL pointer dereference.
 423         (maint_print_xml_tdesc_cmd): New function.
 424         (_initialize_target_descriptions): Register new 'maint print
 425         xml-tdesc' command and give it the filename completer.
 426         * NEWS: Mention new 'maint print xml-tdesc' command.
 427
 428 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 429
 430         * target-descriptions.c (class tdesc_compatible_info): New class.
 431         (struct target_desc): Change type of compatible vector.
 432         (tdesc_compatible_p): Update for change in type of
 433         target_desc::compatible.
 434         (tdesc_compatible_info_list): New function.
 435         (tdesc_compatible_info_arch_name): New function.
 436         (tdesc_add_compatible): Update for change in type of
 437         target_desc::compatible.
 438         (print_c_tdesc::visit_pre): Likewise.
 439
 440 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 441
 442         * target-descriptions.c (print_c_tdesc::print_c_tdesc): Change
 443         whitespace to underscore.
 444         (maint_print_c_tdesc_cmd): Use fake filename for target
 445         descriptions that came from the target.
 446         (_initialize_target_descriptions): Add filename command completion
 447         for 'maint print c-tdesc'.
 448
 449 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 450
 451         * dwarf2/loc.c (decode_debug_loclists_addresses): Add empty
 452         lines.
 453
 454 2020-06-23  Simon Marchi  <simon.marchi@efficios.com>
 455
 456         * dwarf2/loc.c (decode_debug_loc_dwo_addresses): Add empty
 457         lines.
 458         (dwarf2_find_location_expression): Likewise.
 459         (call_site_parameter_matches): Likewise.
 460         (dwarf2_compile_expr_to_ax): Likewise.
 461         (disassemble_dwarf_expression): Likewise.
 462         (loclist_describe_location): Likewise.
 463
 464 2020-06-23  Pedro Alves  <palves@redhat.com>
 465
 466         * gdbarch-selftests.c: Don't include inferior.h, gdbthread.h or
 467         progspace-and-thread.h.  Include scoped-mock-context.h instead.
 468         (register_to_value_test): Use scoped_mock_context.
 469         * regcache.c: Include "scoped-mock-context.h".
 470         (cooked_read_test): Don't error out if a target is already pushed.
 471         Use scoped_mock_context.  Adjust.
 472         * scoped-mock-context.h: New file.
 473
 474 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 475
 476         * ada-lang.c (ada_language_data): Delete la_is_string_type_p
 477         initializer.
 478         (ada_language::is_string_type_p): New member function.
 479         * c-lang.c (c_language_data): Delete la_is_string_type_p
 480         initializer.
 481         (cplus_language_data): Likewise.
 482         (asm_language_data): Likewise.
 483         (minimal_language_data): Likewise.
 484         * d-lang.c (d_language_data): Likewise.
 485         * f-lang.c (f_is_string_type_p): Delete function, implementation
 486         moved to f_language::is_string_type_p.
 487         (f_language_data): Delete la_is_string_type_p initializer.
 488         (f_language::is_string_type_p): New member function,
 489         implementation from f_is_string_type_p.
 490         * go-lang.c (go_is_string_type_p): Delete function, implementation
 491         moved to go_language::is_string_type_p.
 492         (go_language_data): Delete la_is_string_type_p initializer.
 493         (go_language::is_string_type_p): New member function,
 494         implementation from go_is_string_type_p.
 495         * language.c (language_defn::is_string_type_p): Define new member
 496         function.
 497         (default_is_string_type_p): Make static, add comment copied from
 498         header file.
 499         (unknown_language_data): Delete la_is_string_type_p initializer.
 500         (unknown_language::is_string_type_p): New member function.
 501         (auto_language_data): Delete la_is_string_type_p initializer.
 502         (auto_language::is_string_type_p): New member function.
 503         * language.h (language_data): Delete la_is_string_type_p field.
 504         (language_defn::is_string_type_p): Declare new function.
 505         (default_is_string_type_p): Delete desclaration, move comment to
 506         definition.
 507         * m2-lang.c (m2_is_string_type_p): Delete function, implementation
 508         moved to m2_language::is_string_type_p.
 509         (m2_language_data): Delete la_is_string_type_p initializer.
 510         (m2_language::is_string_type_p): New member function,
 511         implementation from m2_is_string_type_p.
 512         * objc-lang.c (objc_language_data): Delete la_is_string_type_p
 513         initializer.
 514         * opencl-lang.c (opencl_language_data): Likewise.
 515         * p-lang.c (pascal_is_string_type_p): Delete function,
 516         implementation moved to pascal_language::is_string_type_p.
 517         (pascal_language_data): Delete la_is_string_type_p initializer.
 518         (pascal_language::is_string_type_p): New member function,
 519         implementation from pascal_is_string_type_p.
 520         * rust-lang.c (rust_is_string_type_p): Delete function,
 521         implementation moved to rust_language::is_string_type_p.
 522         (rust_language_data): Delete la_is_string_type_p initializer.
 523         (rust_language::is_string_type_p): New member function,
 524         implementation from rust_is_string_type_p.
 525         * valprint.c (val_print_scalar_or_string_type_p): Update call to
 526         is_string_type_p.
 527
 528 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 529
 530         * ada-lang.c (ada_language_data): Delete la_print_typedef
 531         initializer.
 532         (ada_language::print_typedef): New member function.
 533         * c-lang.c (c_language_data): Delete la_print_typedef initializer.
 534         (cplus_language_data): Likewise.
 535         (asm_language_data): Likewise.
 536         (minimal_language_data): Likewise.
 537         * d-lang.c (d_language_data): Likewise.
 538         * f-lang.c (f_language_data): Likewise.
 539         (f_language::print_typedef): New member function.
 540         * go-lang.c (go_language_data): Delete la_print_typedef
 541         initializer.
 542         * language.c (language_defn::print_typedef): Define member
 543         function.
 544         (unknown_language_data): Delete la_print_typedef initializer.
 545         (unknown_language::print_typedef): New member function.
 546         (auto_language_data): Delete la_print_typedef initializer.
 547         (auto_language::print_typedef): New member function.
 548         * language.h (language_data): Delete la_print_typedef field.
 549         (language_defn::print_typedef): Declare new member function.
 550         (LA_PRINT_TYPEDEF): Update call to print_typedef.
 551         (default_print_typedef): Delete declaration.
 552         * m2-lang.c (m2_language_data): Delete la_print_typedef
 553         initializer.
 554         (m2_language::print_typedef): New member function.
 555         * objc-lang.c (objc_language_data): Delete la_print_typedef
 556         initializer.
 557         * opencl-lang.c (opencl_language_data): Likewise.
 558         * p-lang.c (pascal_language_data): Likewise.
 559         (pascal_language::print_typedef): New member function.
 560         * rust-lang.c (rust_print_typedef): Delete function,
 561         implementation moved to rust_language::print_typedef.
 562         (rust_language): Delete la_print_typedef initializer.
 563         (rust_language::print_typedef): New member function,
 564         implementation from rust_print_typedef.
 565         * typeprint.c (default_print_typedef): Delete.
 566
 567 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 568
 569         * ada-lang.c (ada_language_data): Delete la_printstr initializer.
 570         (ada_language::printstr): New member function.
 571         * c-lang.c (c_language_data): Delete la_printstr initializer.
 572         (cplus_language_data): Likewise.
 573         (asm_language_data): Likewise.
 574         (minimal_language_data): Likewise.
 575         * d-lang.c (d_language_data): Likewise.
 576         * f-lang.c (f_printstr): Rename to f_language::printstr.
 577         (f_language_data): Delete la_printstr initializer.
 578         (f_language::printstr): New member function, implementation from
 579         f_printstr.
 580         * go-lang.c (go_language_data): Delete la_printstr initializer.
 581         * language.c (language_defn::printstr): Define new member
 582         function.
 583         (unk_lang_printstr): Delete.
 584         (unknown_language_data): Delete la_printstr initializer.
 585         (unknown_language::printstr): New member function.
 586         (auto_language_data): Delete la_printstr initializer.
 587         (auto_language::printstr): New member function.
 588         * language.h (language_data): Delete la_printstr field.
 589         (language_defn::printstr): Declare new member function.
 590         (LA_PRINT_STRING): Update call to printstr.
 591         * m2-lang.c (m2_printstr): Rename to m2_language::printstr.
 592         (m2_language_data): Delete la_printstr initializer.
 593         (m2_language::printstr): New member function, implementation from
 594         m2_printstr.
 595         * objc-lang.c (objc_language_data): Delete la_printstr
 596         initializer.
 597         * opencl-lang.c (opencl_language_data): Likewise.
 598         * p-lang.c (pascal_printstr): Rename to pascal_language::printstr.
 599         (pascal_language_data): Delete la_printstr initializer.
 600         (pascal_language::printstr): New member function, implementation
 601         from pascal_printstr.
 602         * p-lang.h (pascal_printstr): Delete declaration.
 603         * rust-lang.c (rust_printstr): Update header comment.
 604         (rust_language_data): Delete la_printstr initializer.
 605         (rust_language::printstr): New member function.
 606
 607 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 608
 609         * ada-lang.c (ada_language_data): Delete la_printchar initializer.
 610         (ada_language::printchar): New member function.
 611         * c-lang.c (c_language_data): Delete la_printchar initializer.
 612         (cplus_language_data): Likewise.
 613         (asm_language_data): Likewise.
 614         (minimal_language_data): Likewise.
 615         * d-lang.c (d_language_data): Likewise.
 616         * f-lang.c (f_printchar): Rename to f_language::printchar.
 617         (f_language_data): Delete la_printchar initializer.
 618         (f_language::printchar): New member function, implementation from
 619         f_printchar.
 620         * go-lang.c (go_language_data): Delete la_printchar initializer.
 621         * language.c (unk_lang_printchar): Delete.
 622         (language_defn::printchar): Define new member function.
 623         (unknown_language_data): Delete la_printchar initializer.
 624         (unknown_language::printchar): New member function.
 625         (auto_language_data): Delete la_printchar initializer.
 626         (auto_language::printchar): New member function.
 627         * language.h (language_data): Delete la_printchar field.
 628         (language_defn::printchar): Declare new member function.
 629         (LA_PRINT_CHAR): Update call to printchar.
 630         * m2-lang.c (m2_language_data): Delete la_printchar initializer.
 631         (m2_language::printchar): New member function.
 632         * objc-lang.c (objc_language_data): Delete la_printchar
 633         initializer.
 634         * opencl-lang.c (opencl_language_data): Likewise.
 635         * p-lang.c (pascal_language_data): Delete la_printchar
 636         initializer.
 637         (pascal_language::printchar): New member function.
 638         * rust-lang.c (rust_printchar): Rename to
 639         rust_language::printchar.
 640         (rust_language_data): Delete la_printchar initializer.
 641         (rust_language::printchar): New member function, implementation
 642         from rust_printchar.
 643
 644 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 645
 646         * ada-lang.c (emit_char): Renamed to ada_language::emitchar.
 647         (ada_language_data): Delete la_emitchar initializer.
 648         (ada_language::emitchar): New member function, implementation from
 649         emit_char.
 650         * c-lang.c (c_language_data): Delete la_emitchar initializer.
 651         (cplus_language_data): Likewise.
 652         (asm_language_data): Likewise.
 653         (minimal_language_data): Likewise.
 654         * d-lang.c (d_language_data): Likewise.
 655         * f-lang.c (f_emit_char): Rename to f_language::emitchar.
 656         (f_language_data): Delete la_emitchar initializer.
 657         (f_language::emitchar): New member function, implementation from
 658         f_emit_char.
 659         * go-lang.c (go_language_data): Delete la_emitchar initializer.
 660         * language.c (unk_lang_emit_char): Delete.
 661         (language_defn::emitchar): New member function definition.
 662         (unknown_language_data): Delete la_emitchar initializer.
 663         (unknown_language::emitchar): New member function.
 664         (auto_language_data): Delete la_emitchar initializer.
 665         (auto_language::emitchar): New member function.
 666         * language.h (language_data): Delete la_emitchar field.
 667         (language_defn::emitchar): New member field declaration.
 668         (LA_EMIT_CHAR): Update call to emitchar.
 669         * m2-lang.c (m2_emit_char): Rename to m2_language::emitchar.
 670         (m2_language_data): Delete la_emitchar initializer.
 671         (m2_language::emitchar): New member function, implementation from
 672         m2_emit_char.
 673         * objc-lang.c (objc_language_data): Delete la_emitchar
 674         initializer.
 675         * opencl-lang.c (opencl_language_data): Likewise.
 676         * p-lang.c (pascal_emit_char): Rename to pascal_language::emitchar.
 677         (pascal_language_data): Delete la_emitchar initializer.
 678         (pascal_language::emitchar): New member function, implementation
 679         from pascal_emit_char.
 680         * rust-lang.c (rust_emitchar): Rename to rust_language::emitchar.
 681         (rust_language_data): Delete la_emitchar initializer.
 682         (rust_language::emitchar): New member function, implementation
 683         from rust_emitchar.
 684
 685 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 686
 687         * ada-lang.c (resolve): Rename to ada_language::post_parser.
 688         (ada_language_data): Delete la_post_parser initializer.
 689         (ada_language::post_parser): New member function.
 690         * c-lang.c (c_language_data): Delete la_post_parser initializer.
 691         (cplus_language_data): Likewise.
 692         (asm_language_data): Likewise.
 693         (minimal_language_data): Likewise.
 694         * d-lang.c (d_language_data): Likewise.
 695         * f-lang.c (f_language_data): Likewise.
 696         * go-lang.c (go_language_data): Likewise.
 697         * language.c (unknown_language_data): Likewise.
 698         (auto_language_data): Likewise.
 699         * language.h (language_data): Delete la_post_parser field.
 700         (language_defn::post_parser): New member function.
 701         * m2-lang.c (m2_language_data): Delete la_post_parser initializer.
 702         * objc-lang.c (objc_language_data): Likewise.
 703         * opencl-lang.c (opencl_language_data): Likewise.
 704         * p-lang.c (pascal_language_data): Likewise.
 705         * parse.c (parse_exp_in_context): Update call to post_parser.
 706         (null_post_parser): Delete definition.
 707         * parser-defs.h (null_post_parser): Delete declaration.
 708         * rust-lang.c (rust_language_data): Delete la_post_parser
 709         initializer.
 710
 711 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 712
 713         * ada-lang.c (parse): Rename to ada_language::parser.
 714         (ada_language_data): Delete la_parser initializer.
 715         (ada_language::parser): New member function, implementation from
 716         parse.
 717         * c-lang.c (c_language_data): Delete la_parser initializer.
 718         (cplus_language_data): Likewise.
 719         (asm_language_data): Likewise.
 720         (minimal_language_data): Likewise.
 721         * d-lang.c (d_language_data): Likewise.
 722         (d_language::parser): New member function.
 723         * f-lang.c (f_language_data): Delete la_parser initializer.
 724         (f_language::parser): New member function.
 725         * go-lang.c (go_language_data): Delete la_parser initializer.
 726         (go_language::parser): New member function.
 727         * language.c (unk_lang_parser): Delete.
 728         (language_defn::parser): Define new member function.
 729         (unknown_language_data): Delete la_parser initializer.
 730         (unknown_language::parser): New member function.
 731         (auto_language_data): Delete la_parser initializer.
 732         (auto_language::parser): New member function.
 733         * language.h (language_data): Delete la_parser field.
 734         (language_defn::parser): Declare new member function.
 735         * m2-lang.c (m2_language_data): Delete la_parser initializer.
 736         (m2_language::parser): New member function.
 737         * objc-lang.c (objc_language_data): Delete la_parser initializer.
 738         * opencl-lang.c (opencl_language_data): Likewise.
 739         * p-lang.c (pascal_language_data): Likewise.
 740         (pascal_language::parser): New member function.
 741         * parse.c (parse_exp_in_context): Update call to parser.
 742         * rust-lang.c (rust_language_data): Delete la_parser initializer.
 743         (rust_language::parser): New member function.
 744
 745 2020-06-23  Andrew Burgess  <andrew.burgess@embecosm.com>
 746
 747         * top.c (print_gdb_configuration): Print --with-python-libdir
 748         configuration value.
 749
 750 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 751
 752         * NEWS: Mention change to the alias command.
 753
 754 2020-06-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 755
 756         * cli/cli-cmds.c (lookup_cmd_for_default_args)
 757         (alias_command_completer)
 758         (make_alias_options_def_group): New functions.
 759         (alias_opts, alias_option_defs): New struct and array.
 760         (alias_usage_error): Update usage.
 761         (alias_command): Handles optional DEFAULT-ARGS... arguments.
 762         Use option framework.
 763         (_initialize_cli_cmds): Update alias command help.
 764         Update aliases command help.
 765         (show_user):
 766         Add NULL for new default_args lookup_cmd argument.
 767         (valid_command_p): Rename to validate_aliased_command.
 768         Add NULL for new default_args lookup_cmd argument.  Verify that the
 769         aliased_command has no default args.
 770         * cli/cli-decode.c (help_cmd): Show aliases definitions.
 771         (lookup_cmd_1, lookup_cmd): New argument default_args.
 772         (add_alias_cmd):
 773         Add NULL for new default_args lookup_cmd argument.
 774         (print_help_for_command): Show default args under the layout
 775          alias some_alias = some_aliased_cmd some_alias_default_arg.
 776         * cli/cli-decode.h (struct cmd_list_element): New member default_args.
 777         xfree default_args in destructor.
 778         * cli/cli-script.c (process_next_line, do_define_command):
 779         Add NULL for new default_args lookup_cmd argument.
 780         * command.h: Declare new default_args argument in lookup_cmd
 781         and lookup_cmd_1.
 782         * completer.c (complete_line_internal_1):
 783         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 784         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
 785         * guile/scm-param.c (add_setshow_generic, pascm_parameter_defined_p):
 786         Likewise.
 787         * infcmd.c (_initialize_infcmd): Likewise.
 788         * python/py-auto-load.c (gdbpy_initialize_auto_load): Likewise.
 789         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
 790         * python/py-param.c (add_setshow_generic): Likewise.
 791         * remote.c (_initialize_remote): Likewise.
 792         * top.c (execute_command): Prepend default_args if command has some.
 793         (set_verbose):
 794         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 795         * tracepoint.c (validate_actionline, encode_actions_1):
 796         Add NULL for new default_args lookup_cmd or lookup_cmd_1 argument.
 797
 798 2020-06-22  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 799
 800         * jit.c (jit_read_descriptor): Use bool as the return type.
 801         (jit_breakpoint_re_set_internal): Use bool as the return type.
 802         Invert the return value logic; return true if the jit breakpoint
 803         has been successfully initialized.
 804         (jit_inferior_init): Update the call to
 805         jit_breakpoint_re_set_internal.
 806
 807 2020-06-22  Pedro Alves  <palves@redhat.com>
 808
 809         PR gdb/25939
 810         * procfs.c (procfs_target::wait): Don't reference inferior_ptid.
 811         Use the current inferior instead.  Don't return
 812         TARGET_WAITKIND_SPURIOUS/inferior_ptid -- instead continue and
 813         wait again.
 814         * sol-thread.c (sol_thread_target::wait): Don't reference
 815         inferior_ptid.
 816         (ps_lgetregs, ps_lsetregs, ps_lgetfpregs, ps_lsetfpregs)
 817         (sol_update_thread_list_callback): Use the current inferior's pid
 818         instead of inferior_ptid.
 819
 820 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 821
 822         * procfs.c: Cleanup many comments.
 823
 824         (READ_WATCHFLAG, WRITE_WATCHFLAG, EXEC_WATCHFLAG)
 825         (AFTER_WATCHFLAG): Replace by value.
 826
 827         (MAIN_PROC_NAME_FORMAT): Inline ...
 828         (create_procinfo): ... here.
 829
 830         (procfs_debug_inferior): Remove SYS_exec handling.
 831         (syscall_is_exec): Likewise.
 832         (procfs_set_exec_trap): Likewise.
 833
 834         (syscall_is_lwp_exit): Inline in callers.
 835         (syscall_is_exit): Likewise.
 836         (syscall_is_exec): Likewise.
 837         (syscall_is_lwp_create): Likewise.
 838
 839         (invalidate_cache): Remove #if 0 code.
 840
 841         (make_signal_thread_runnable):  Remove.
 842         (procfs_target::resume): Remove #if 0 code.
 843
 844 2020-06-21  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
 845
 846         PR gdb/25939
 847         * procfs.c (procfs_target::procfs_init_inferior): Move push_target
 848         call ...
 849         (procfs_target::create_inferior): ... here.
 850
 851 2020-06-21  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 852
 853         * exec.c (validate_exec_file): Ensure the build-id is up to
 854         date by calling reopen_exec_file (that checks file timestamp
 855         to decide to re-read the file).
 856
 857 2020-06-18  Pedro Alves  <palves@redhat.com>
 858
 859         PR gdb/25412
 860         * gdbthread.h (delete_thread, delete_thread_silent)
 861         (find_thread_ptid): Update comments.
 862         * thread.c (current_thread_): New global.
 863         (is_current_thread): Move higher, and reimplement.
 864         (inferior_thread): Reimplement.
 865         (set_thread_exited): Use bool.  Add assertions.
 866         (add_thread_silent): Simplify thread-reuse handling by always
 867         calling delete_thread.
 868         (delete_thread): Remove intro comment.
 869         (find_thread_ptid): Skip exited threads.
 870         (switch_to_thread_no_regs): Write to current_thread_.
 871         (switch_to_no_thread): Check CURRENT_THREAD_ instead of
 872         INFERIOR_PTID.  Clear current_thread_.
 873
 874 2020-06-18  Pedro Alves  <palves@redhat.com>
 875
 876         * aix-thread.c (pd_update): Use switch_to_thread.
 877
 878 2020-06-18  Pedro Alves  <palves@redhat.com>
 879
 880         * ravenscar-thread.c (ravenscar_thread_target): Update.
 881         (ravenscar_thread_target::update_inferior_ptid): Rename to ...
 882         (ravenscar_thread_target::add_active_thread): ... this.  Don't
 883         set m_base_ptid here.  Update to avoid referencing inferior_ptid.
 884         (ravenscar_thread_target::wait): Don't write to inferior_ptid.
 885
 886 2020-06-18  Pedro Alves  <palves@redhat.com>
 887
 888         * nat/windows-nat.c (current_windows_thread): Remove.
 889         * nat/windows-nat.h (current_windows_thread): Remove.
 890         * windows-nat.c (windows_nat_target::stopped_by_sw_breakpoint):
 891         Adjust.
 892         (display_selectors): Adjust to fetch the current
 893         windows_thread_info based on inferior_ptid.
 894         (fake_create_process): No longer write to current_windows_thread.
 895         (windows_nat_target::get_windows_debug_event):
 896         Don't set inferior_ptid or current_windows_thread.
 897         (windows_nat_target::wait): Adjust to not rely on
 898         current_windows_thread.
 899         (do_initial_windows_stuff): Now a method of windows_nat_target.
 900         Switch to the last_ptid thread.
 901         (windows_nat_target::attach): Adjust.
 902         (windows_nat_target::detach): Use switch_to_no_thread instead of
 903         writing to inferior_ptid directly.
 904         (windows_nat_target::create_inferior): Adjust.
 905
 906 2020-06-18  Pedro Alves  <palves@redhat.com>
 907
 908         * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid.
 909
 910 2020-06-18  Pedro Alves  <palves@redhat.com>
 911
 912         * go32-nat.c (go32_nat_target::create_inferior): Switch to thread
 913         after creating it, instead of writing to inferior_ptid.  Don't
 914         write to inferior_ptid.
 915
 916 2020-06-18  Pedro Alves  <palves@redhat.com>
 917
 918         * fork-child.c (postfork_hook): Don't write to inferior_ptid.
 919
 920 2020-06-18  Pedro Alves  <palves@redhat.com>
 921
 922         * bsd-kvm.c (bsd_kvm_target_open): Switch to thread after adding
 923         it, instead of writing to inferior_ptid.
 924
 925 2020-06-18  Pedro Alves  <palves@redhat.com>
 926
 927         * btrace.c (btrace_fetch): Use switch_to_thread instead of writing
 928         to inferior_ptid.
 929
 930 2020-06-18  Pedro Alves  <palves@redhat.com>
 931
 932         * bsd-kvm.c (bsd_kvm_target::close): Use switch_to_no_thread
 933         instead of writing to inferior_ptid directly.
 934
 935 2020-06-18  Pedro Alves  <palves@redhat.com>
 936
 937         * corelow.c (core_target::close): Use switch_to_no_thread instead
 938         of writing to inferior_ptid directly.
 939         (add_to_thread_list, core_target_open): Use switch_to_thread
 940         instead of writing to inferior_ptid directly.
 941
 942 2020-06-18  Pedro Alves  <palves@redhat.com>
 943
 944         * darwin-nat.c (darwin_nat_target::decode_message): Don't write to
 945         inferior_ptid.
 946         (darwin_nat_target::stop_inferior, darwin_nat_target::kill): Avoid
 947         inferior_ptid.
 948         (darwin_attach_pid): Use switch_to_no_thread instead of writing to
 949         inferior_ptid directly.
 950         (darwin_nat_target::init_thread_list): Switch to thread, instead
 951         of writing to inferior_ptid.
 952         (darwin_nat_target::attach): Don't write to inferior_ptid.
 953         (darwin_nat_target::get_ada_task_ptid): Avoid inferior_ptid.
 954
 955 2020-06-18  Pedro Alves  <palves@redhat.com>
 956
 957         * gnu-nat.c (gnu_nat_target::create_inferior): Switch to the added
 958         thread.
 959         (gnu_nat_target::attach): Don't write to inferior_ptid directly.
 960         Instead use switch_to_thread.
 961         (gnu_nat_target::detach): Use switch_to_no_thread
 962         instead of writing to inferior_ptid directly.  Used passed-in
 963         inferior instead of looking up the inferior by pid.
 964
 965 2020-06-18  Pedro Alves  <palves@redhat.com>
 966
 967         * go32-nat.c (go32_nat_target::create_inferior): Don't write to
 968         inferior_ptid.
 969
 970 2020-06-18  Pedro Alves  <palves@redhat.com>
 971
 972         * nto-procfs.c (nto_procfs_target::update_thread_list): Avoid
 973         inferior_ptid.
 974         (nto_procfs_target::attach): Avoid inferior_ptid.  Switch to
 975         thread.
 976         (nto_procfs_target::detach): Avoid referencing
 977         inferior_ptid.  Use switch_to_no_thread instead of writing to
 978         inferior_ptid directly.
 979         (nto_procfs_target::mourn_inferior): Use switch_to_no_thread
 980         instead of writing to inferior_ptid directly.
 981         (nto_procfs_target::create_inferior): Avoid inferior_ptid.  Switch
 982         to thread.
 983
 984 2020-06-18  Pedro Alves  <palves@redhat.com>
 985
 986         * remote-sim.c (gdbsim_target::create_inferior): Switch to thread
 987         after creating it, instead of writing to inferior_ptid.
 988         (gdbsim_target_open): Use switch_to_no_thread instead of writing
 989         to inferior_ptid directly.
 990         (gdbsim_target::wait): Don't write to inferior_ptid.
 991
 992 2020-06-18  Pedro Alves  <palves@redhat.com>
 993
 994         * remote.c (remote_target::remote_notice_new_inferior): Use
 995         switch_to_thread instead of writing to inferior_ptid directly.
 996         (remote_target::add_current_inferior_and_thread): Use
 997         switch_to_no_thread instead of writing to inferior_ptid directly.
 998         (extended_remote_target::attach): Use switch_to_inferior_no_thread
 999         and switch_to_thread instead of using set_current_inferior or
1000         writing to inferior_ptid directly.
1001
1002 2020-06-18  Pedro Alves  <palves@redhat.com>
1003
1004         * tracectf.c (ctf_target_open): Switch to added thread instead of
1005         writing to inferior_ptid directly.
1006         (ctf_target::close): Use switch_to_no_thread instead of writing to
1007         inferior_ptid directly.
1008
1009 2020-06-18  Pedro Alves  <palves@redhat.com>
1010
1011         * tracefile-tfile.c (tfile_target_open): Don't write to
1012         inferior_ptid directly, instead switch to added thread.
1013         (tfile_target::close): Use switch_to_no_thread instead of writing
1014         to inferior_ptid directly.
1015
1016 2020-06-18  Pedro Alves  <palves@redhat.com>
1017
1018         * procfs.c (procfs_target::attach): Don't write to inferior_ptid.
1019         (procfs_target::detach): Use switch_to_no_thread
1020         instead of writing to inferior_ptid directly.
1021         (do_attach): Change return type to void.  Switch to the added
1022         thread.
1023         (procfs_target::create_inferior): Switch to the added thread.
1024         (procfs_do_thread_registers): Don't write to inferior_ptid.
1025
1026 2020-06-18  Pedro Alves  <palves@redhat.com>
1027
1028         * infrun.c (generic_mourn_inferior): Use switch_to_thread instead
1029         of writing to inferior_ptid.
1030         (scoped_restore_exited_inferior): Delete.
1031         (handle_vfork_child_exec_or_exit): Simplify using
1032         scoped_restore_current_pspace_and_thread.  Use switch_to_thread
1033         instead of writing to inferior_ptid.
1034         (THREAD_STOPPED_BY): Delete.
1035         (thread_stopped_by_watchpoint, thread_stopped_by_sw_breakpoint)
1036         (thread_stopped_by_hw_breakpoint): Delete.
1037         (save_waitstatus): Use
1038         scoped_restore_current_thread+switch_to_thread, and call
1039         target_stopped_by_watchpoint instead of
1040         thread_stopped_by_watchpoint, target_stopped_by_sw_breakpoint
1041         instead of thread_stopped_by_sw_breakpoint, and
1042         target_stopped_by_hw_breakpoint instead of
1043         thread_stopped_by_hw_breakpoint.
1044         (handle_inferior_event)
1045         <TARGET_WAITKIND_EXITED/TARGET_WAITKIND_SIGNALLED>: Don't write to
1046         inferior_ptid directly, nor
1047         set_current_inferior/set_current_program_space.  Use
1048         switch_to_thread / switch_to_inferior_no_thread instead.
1049
1050 2020-06-18  Pedro Alves  <palves@redhat.com>
1051
1052         * target.c (generic_mourn_inferior): Use switch_to_no_thread
1053         instead of writing to inferior_ptid.
1054
1055 2020-06-18  Pedro Alves  <palves@redhat.com>
1056
1057         * inf-ptrace.c (inf_ptrace_target::create_inferior): Switch to the
1058         added thread.
1059         (inf_ptrace_target::attach): Don't write to inferior_ptid.  Switch
1060         to the added thread.
1061         (inf_ptrace_target::detach_success): Use switch_to_no_thread
1062         instead of writing to inferior_ptid.
1063
1064 2020-06-18  Pedro Alves  <palves@redhat.com>
1065
1066         * gdbarch-selftests.c: Include "progspace-and-thread.h".
1067         (register_to_value_test): Mock a program_space too.  Heap-allocate
1068         the address space.  Don't write to inferior_ptid.  Use
1069         switch_to_thread instead.
1070
1071 2020-06-18  Pedro Alves  <palves@redhat.com>
1072
1073         * linux-tdep.c (find_signalled_thread(thread_info *,void *)):
1074         Delete.
1075         (find_signalled_thread()): New, factored out from
1076         linux_make_corefile_notes and adjusted to handle exited threads.
1077         (linux_make_corefile_notes): Adjust to use the new
1078         find_signalled_thread.
1079
1080 2020-06-18  Pedro Alves  <palves@redhat.com>
1081
1082         * linux-tdep.c (btrace_fetch): Save/restore current thread instead
1083         of saving/restoring inferior_ptid.
1084
1085 2020-06-17  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-win.h (tui_scroll_forward, tui_scroll_backward)
1088         (tui_scroll_left, tui_scroll_right, struct tui_win_info): Don't
1089         declare.
1090         * tui/tui-data.h (MIN_CMD_WIN_HEIGHT): Remove.
1091
1092 2020-06-15  Simon Marchi  <simon.marchi@efficios.com>
1093
1094         * dwarf2/read.c (dwarf2_initialize_objfile): Check for presence
1095         of partial symtabs.
1096
1097 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1098
1099         * regformats/reg-arm.dat: Remove.
1100         * regformats/reg-bfin.dat: Remove.
1101         * regformats/reg-cris.dat: Remove.
1102         * regformats/reg-crisv32.dat: Remove.
1103         * regformats/reg-m32r.dat: Remove.
1104         * regformats/reg-tilegx.dat: Remove.
1105         * regformats/reg-tilegx32.dat: Remove.
1106
1107 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1108
1109         * features/Makefile (WHICH): Remove arm files.
1110         * regformats/arm/arm-with-iwmmxt.dat: Remove.
1111         * regformats/arm/arm-with-neon.dat: Remove.
1112         * regformats/arm/arm-with-vfpv2.dat: Remove.
1113         * regformats/arm/arm-with-vfpv3.dat: Remove.
1114
1115 2020-06-17  Simon Marchi  <simon.marchi@efficios.com>
1116
1117         * features/Makefile (XMLTOC): Remove rx.xml.
1118
1119 2020-06-17  Pedro Alves  <palves@redhat.com>
1120
1121         * gdbthread.h (thread_control_state) <trap_expected> Update
1122         comments.
1123
1124 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1125
1126         * ada-lang.c (ada_lookup_symbol_nonlocal): Rename to
1127         ada_language::lookup_symbol_nonlocal.
1128         (ada_language_data): Delete la_lookup_symbol_nonlocal initializer.
1129         (ada_language::lookup_symbol_nonlocal): New member function,
1130         implementation from ada_lookup_symbol_nonlocal.
1131         * c-lang.c (c_language_data): Delete la_lookup_symbol_nonlocal
1132         initializer.
1133         (cplus_language_data): Delete la_lookup_symbol_nonlocal
1134         initializer.
1135         (cplus_language::lookup_symbol_nonlocal): New member function.
1136         (asm_language_data): Delete la_lookup_symbol_nonlocal initializer.
1137         (minimal_language_data) Likewise.
1138         * cp-namespace.c (cp_lookup_nested_symbol): Update comment.
1139         * d-lang.c (d_language_data): Delete la_lookup_symbol_nonlocal
1140         initializer.
1141         (d_language::lookup_symbol_nonlocal): New member function.
1142         * f-lang.c (f_language_data): Delete la_lookup_symbol_nonlocal
1143         initializer.
1144         (f_language::lookup_symbol_nonlocal): New member function.
1145         * go-lang.c (go_language_data): Delete la_lookup_symbol_nonlocal
1146         initializer.
1147         * language.c (unknown_language_data): Likewise.
1148         (auto_language_data): Likewise.
1149         * language.h (language_data): Delete la_lookup_symbol_nonlocal
1150         field.
1151         (language_defn::lookup_symbol_nonlocal): New member function.
1152         * m2-lang.c (m2_language_data): Delete la_lookup_symbol_nonlocal
1153         initializer.
1154         * objc-lang.c (objc_language_data): Likewise.
1155         * opencl-lang.c (opencl_language_data): Likewise.
1156         * p-lang.c (pascal_language_data): Likewise.
1157         * rust-lang.c (rust_lookup_symbol_nonlocal): Rename to
1158         rust_language::lookup_symbol_nonlocal.
1159         (rust_language_data): Delete la_lookup_symbol_nonlocal
1160         initializer.
1161         (rust_language::lookup_symbol_nonlocal): New member function,
1162         implementation from rust_lookup_symbol_nonlocal.
1163         * symtab.c (lookup_symbol_aux): Update call to
1164         lookup_symbol_nonlocal.
1165         (basic_lookup_symbol_nonlocal): Rename to...
1166         (language_defn::lookup_symbol_nonlocal): ...this, and update
1167         header comment.  Remove language_defn parameter, and replace with
1168         uses of `this'.
1169         * symtab.h (basic_lookup_symbol_nonlocal): Delete declaration.
1170
1171 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1172
1173         * ada-lang.c (ada_language_data): Delete la_value_print_inner
1174         initializer.
1175         (ada_language::value_print_inner): New member function.
1176         * c-lang.c (c_language_data): Delete la_value_print_inner
1177         initializer.
1178         (cplus_language_data): Likewise.
1179         (asm_language_data): Likewise.
1180         (minimal_language_data): Likewise.
1181         * d-lang.c (d_language_data): Likewise.
1182         (d_language::value_print_inner): New member function.
1183         * f-lang.c (f_language_data): Delete la_value_print_inner
1184         initializer.
1185         (f_language::value_print_inner): New member function.
1186         * f-lang.h (f_value_print_innner): Rename to...
1187         (f_value_print_inner): ...this (note spelling of 'inner').
1188         * f-valprint.c (f_value_print_innner): Rename to...
1189         (f_value_print_inner): ...this (note spelling of 'inner').
1190         * go-lang.c (go_language_data): Delete la_value_print_inner
1191         initializer.
1192         (go_language::value_print_inner): New member function.
1193         * language.c (language_defn::value_print_inner): Define new member
1194         function.
1195         (unk_lang_value_print_inner): Delete.
1196         (unknown_language_data): Delete la_value_print_inner initializer.
1197         (unknown_language::value_print_inner): New member function.
1198         (auto_language_data): Delete la_value_print_inner initializer.
1199         (auto_language::value_print_inner): New member function.
1200         * language.h (language_data): Delete la_value_print_inner field.
1201         (language_defn::value_print_inner): Delcare new member function.
1202         * m2-lang.c (m2_language_data): Delete la_value_print_inner
1203         initializer.
1204         (m2_language::value_print_inner): New member function.
1205         * objc-lang.c (objc_language_data): Delete la_value_print_inner
1206         initializer.
1207         * opencl-lang.c (opencl_language_data): Likewise.
1208         * p-lang.c (pascal_language_data): Likewise.
1209         (pascal_language::value_print_inner): New member function.
1210         * rust-lang.c (rust_language_data): Delete la_value_print_inner
1211         initializer.
1212         (rust_language::value_print_inner): New member function.
1213         * valprint.c (do_val_print): Update call to value_print_inner.
1214
1215 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1216
1217         * ada-lang.c (ada_language_data): Delete la_value_print
1218         initializer.
1219         (ada_language::value_print): New member function.
1220         * c-lang.c (c_language_data): Delete la_value_print initializer.
1221         (cplus_language_data): Likewise.
1222         (asm_language_data): Likewise.
1223         (minimal_language_data): Likewise.
1224         * d-lang.c (d_language_data): Likewise.
1225         * f-lang.c (f_language_data): Likewise.
1226         * go-lang.c (go_language_data): Likewise.
1227         * language.c (unk_lang_value_print): Delete.
1228         (language_defn::value_print): Define new member function.
1229         (unknown_language_data): Delete la_value_print initializer.
1230         (unknown_language::value_print): New member function.
1231         (auto_language_data): Delete la_value_print initializer.
1232         (auto_language::value_print): New member function.
1233         * language.h (language_data): Delete la_value_print field.
1234         (language_defn::value_print): Declare new member function.
1235         (LA_VALUE_PRINT): Update call to value_print.
1236         * m2-lang.c (m2_language_data): Delete la_value_print initializer.
1237         * objc-lang.c (objc_language_data): Likewise.
1238         * opencl-lang.c (opencl_language_data): Likewise.
1239         * p-lang.c (pascal_language_data): Likewise.
1240         (pascal_language::value_print): New member function.
1241         * rust-lang.c (rust_language_data): Delete la_value_print
1242         initializer.
1243
1244 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1245
1246         * ada-lang.c (ada_watch_location_expression): Rename to
1247         ada_language::watch_location_expression.
1248         (ada_language_data): Delete la_watch_location_expression
1249         initializer.
1250         (ada_language::watch_location_expression): New member function,
1251         implementation from ada_watch_location_expression.
1252         * breakpoint.c (watch_command_1): Update call to
1253         watch_location_expression.
1254         * c-lang.c (c_watch_location_expression): Rename to
1255         language_defn::watch_location_expression.
1256         (c_language_data): Delete la_watch_location_expression
1257         initializer.
1258         (cplus_language_data): Likewise.
1259         (asm_language_data): Likewise.
1260         (minimal_language_data): Likewise.
1261         * c-lang.h (c_watch_location_expression): Delete declaration.
1262         * d-lang.c (d_language_data): Delete la_watch_location_expression
1263         initializer.
1264         * f-lang.c (f_language_data): Likewise.
1265         * go-lang.c (go_language_data): Likewise.
1266         * language.c (language_defn::watch_location_expression): Member
1267         function implementation from c_watch_location_expression.
1268         (unknown_language_data): Delete la_watch_location_expression
1269         initializer.
1270         (auto_language_data): Likewise.
1271         * language.h (language_data): Delete la_watch_location_expression
1272         field.
1273         (language_defn::watch_location_expression): Declare new member
1274         function.
1275         * m2-lang.c (m2_language_data): Delete
1276         la_watch_location_expression initializer.
1277         * objc-lang.c (objc_language_data): Likewise.
1278         * opencl-lang.c (opencl_language_data): Likewise.
1279         * p-lang.c (pascal_language_data): Likewise.
1280         * rust-lang.c (rust_watch_location_expression): Rename to
1281         rust_language::watch_location_expression.
1282         (rust_language_data): Delete la_watch_location_expression
1283         initializer.
1284         (rust_language::watch_location_expression): New member function,
1285         implementation from rust_watch_location_expression.
1286
1287 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1288
1289         * ada-lang.c (ada_collect_symbol_completion_matches): Rename to
1290         ada_language::collect_symbol_completion_matches.
1291         (ada_language_data): Delete la_collect_symbol_completion_matches
1292         initializer.
1293         (ada_language::collect_symbol_completion_matches): New member
1294         function, implementation from
1295         ada_collect_symbol_completion_matches.
1296         * c-lang.c (c_language_data): Delete
1297         la_collect_symbol_completion_matches initializer.
1298         (cplus_language_data): Likewise.
1299         (asm_language_data): Likewise.
1300         (minimal_language_data): Likewise.
1301         * d-lang.c (d_language_data): Likewise.
1302         * f-lang.c (f_collect_symbol_completion_matches): Rename to
1303         f_language::collect_symbol_completion_matches.
1304         (f_language_data): Delete la_collect_symbol_completion_matches
1305         initializer.
1306         (f_language::collect_symbol_completion_matches) New member
1307         function, implementation from f_collect_symbol_completion_matches.
1308         * go-lang.c (go_language_data): Delete
1309         la_collect_symbol_completion_matches initializer.
1310         * language.c (unknown_language_data): Likewise.
1311         (auto_language_data): Likewise.
1312         * language.h (language_data): Delete
1313         la_collect_symbol_completion_matches field.
1314         (language_defn::collect_symbol_completion_matches): New member
1315         function.
1316         * m2-lang.c (m2_language_data): Delete
1317         la_collect_symbol_completion_matches initializer.
1318         * objc-lang.c (objc_language_data): Likewise.
1319         * opencl-lang.c (opencl_language_data): Likewise.
1320         * p-lang.c (pascal_language_data): Likewise.
1321         * rust-lang.c (rust_language_data): Likewise.
1322         * symtab.c (default_collect_symbol_completion_matches): Delete.
1323         (collect_symbol_completion_matches): Update call to
1324         collect_symbol_completion_matches.
1325         (collect_symbol_completion_matches_type): Likewise.
1326         * symtab.h (default_collect_symbol_completion_matches): Delete
1327         declaration.
1328
1329 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * ada-lang.c (ada_get_gdb_completer_word_break_characters): Delete.
1332         (ada_language_data): Delete la_word_break_characters initializer.
1333         (ada_language::word_break_characters): New member function.
1334         * c-lang.c (c_language_data): Delete la_word_break_characters
1335         initializer.
1336         (cplus_language_data): Likewise.
1337         (asm_language_data): Likewise.
1338         (minimal_language_data): Likewise.
1339         * completer.c: Update global comment.
1340         (advance_to_expression_complete_word_point): Update call to
1341         word_break_characters.
1342         (complete_files_symbols): Likewise.
1343         (complete_line_internal_1): Likewise.
1344         (default_completer_handle_brkchars): Likewise.
1345         (skip_quoted_chars): Likewise.
1346         * d-lang.c (d_language_data): Delete la_word_break_characters
1347         initializer.
1348         * f-lang.c (f_word_break_characters): Delete.
1349         (f_language_data): Delete la_word_break_characters initializer.
1350         (f_language::word_break_characters): New member function.
1351         * go-lang.c (go_language_data): Delete la_word_break_characters
1352         initializer.
1353         * language.c (unknown_language_data): Likewise.
1354         (auto_language_data): Likewise.
1355         * language.h (default_word_break_characters): Move declaration to
1356         earlier in the file.
1357         (language_data): Delete la_word_break_characters field.
1358         (language_defn::word_break_characters): New member function.
1359         * m2-lang.c (m2_language_data): Delete la_word_break_characters
1360         initializer.
1361         * objc-lang.c (objc_language_data): Likewise.
1362         * opencl-lang.c (opencl_language_data): Likewise.
1363         * p-lang.c (pascal_language_data): Likewise.
1364         * rust-lang.c (rust_language_data): Likewise.
1365
1366 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1367
1368         * ada-lang.c (ada_get_symbol_name_matcher): Update header comment.
1369         (ada_language_data): Delete la_get_symbol_name_matcher
1370         initializer.
1371         (language_defn::get_symbol_name_matcher_inner): New member
1372         function.
1373         * c-lang.c (c_language_data): Delete la_get_symbol_name_matcher
1374         initializer.
1375         (cplus_language_data): Likewise.
1376         (cplus_language::get_symbol_name_matcher_inner): New member
1377         function.
1378         (asm_language_data): Delete la_get_symbol_name_matcher initializer.
1379         (minimal_language_data): Likewise.
1380         * cp-support.h (cp_get_symbol_name_matcher): Update header comment.
1381         * d-lang.c (d_language_data): Delete la_get_symbol_name_matcher
1382         initializer.
1383         * dictionary.c (iter_match_first_hashed): Update call to
1384         get_symbol_name_matcher.
1385         (iter_match_next_hashed): Likewise.
1386         (iter_match_next_linear): Likewise.
1387         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Likewise.
1388         * f-lang.c (f_language_data): Delete la_get_symbol_name_matcher
1389         initializer.
1390         (f_language::get_symbol_name_matcher_inner): New member function.
1391         * go-lang.c (go_language_data): Delete la_get_symbol_name_matcher
1392         initializer.
1393         * language.c (default_symbol_name_matcher): Update header comment,
1394         make static.
1395         (language_defn::get_symbol_name_matcher): New definition.
1396         (language_defn::get_symbol_name_matcher_inner): Likewise.
1397         (get_symbol_name_matcher): Delete.
1398         (unknown_language_data): Delete la_get_symbol_name_matcher
1399         initializer.
1400         (auto_language_data): Likewise.
1401         * language.h (language_data): Delete la_get_symbol_name_matcher
1402         field.
1403         (language_defn::get_symbol_name_matcher): New member function.
1404         (language_defn::get_symbol_name_matcher_inner): Likewise.
1405         (default_symbol_name_matcher): Delete declaration.
1406         * linespec.c (find_methods): Update call to
1407         get_symbol_name_matcher.
1408         * m2-lang.c (m2_language_data): Delete la_get_symbol_name_matcher
1409         initializer.
1410         * minsyms.c (lookup_minimal_symbol): Update call to
1411         get_symbol_name_matcher.
1412         (iterate_over_minimal_symbols): Likewise.
1413         * objc-lang.c (objc_language_data): Delete
1414         la_get_symbol_name_matcher initializer.
1415         * opencl-lang.c (opencl_language_data): Likewise.
1416         * p-lang.c (pascal_language_data): Likewise.
1417         * psymtab.c (psymbol_name_matches): Update call to
1418         get_symbol_name_matcher.
1419         * rust-lang.c (rust_language_data): Delete
1420         la_get_symbol_name_matcher initializer.
1421         * symtab.c (symbol_matches_search_name): Update call to
1422         get_symbol_name_matcher.
1423         (compare_symbol_name): Likewise.
1424
1425 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1426
1427         * ada-lang.c (ada_language_data): Delete la_compute_program
1428         initializer.
1429         * c-lang.c (c_language_data): Likewise.
1430         (c_language::compute_program): New member function.
1431         (cplus_language_data): Delete la_compute_program initializer.
1432         (cplus_language::compute_program): New member function.
1433         (asm_language_data): Delete la_compute_program initializer.
1434         (minimal_language_data): Likewise.
1435         * c-lang.h (c_compute_program): Update comment.
1436         (cplus_compute_program): Likewise.
1437         * compile/compile-c-support.c (c_compute_program): Likewise.
1438         (cplus_compute_program): Likewise.
1439         * compile/compile.c (compile_to_object): Update call to
1440         la_compute_program.
1441         * d-lang.c (d_language_data): Delete la_compute_program
1442         initializer.
1443         * f-lang.c (f_language_data): Likewise.
1444         * go-lang.c (go_language_data): Likewise.
1445         * language.c (unknown_language_data): Likewise.
1446         (auto_language_data): Likewise.
1447         * language.h (language_data): Delete la_compute_program field.
1448         (language_defn::compute_program): New member function.
1449         * m2-lang.c (m2_language_data): Delete la_compute_program
1450         initializer.
1451         * objc-lang.c (objc_language_data): Likewise.
1452         * opencl-lang.c (opencl_language_data): Likewise.
1453         * p-lang.c (pascal_language_data): Likewise.
1454         * rust-lang.c (rust_language_data): Likewise.
1455
1456 2020-06-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1457
1458         * ada-lang.c (ada_language_data) Delete
1459         la_class_name_from_physname initializer.
1460         * c-lang.c (c_language_data): Likewise.
1461         (cplus_language_data): Likewise.
1462         (cplus_language::class_name_from_physname): New member function.
1463         (asm_language_data): Delete la_class_name_from_physname
1464         initializer.
1465         (minimal_language_data): Likewise.
1466         * d-lang.c (d_language_data): Likewise.
1467         * dwarf2/read.c (guess_partial_die_structure_name): Update to call
1468         method on language_defn class.
1469         (guess_full_die_structure_name): Likewise.
1470         * f-lang.c (f_language_data): Delete la_class_name_from_physname
1471         initializer.
1472         * go-lang.c (go_language_data): Likewise.
1473         * language.c (language_class_name_from_physname): Delete.
1474         (unk_lang_class_name): Delete.
1475         (unknown_language_data): Delete la_class_name_from_physname
1476         initializer.
1477         (auto_language_data): Likewise.
1478         * language.h (language_data): Delete la_class_name_from_physname
1479         field.
1480         (language_defn::class_name_from_physname): New function.
1481         (language_class_name_from_physname): Delete declaration.
1482         * m2-lang.c (m2_language_data): Delete la_class_name_from_physname
1483         initializer.
1484         * objc-lang.c (objc_language_data): Likewise.
1485         * opencl-lang.c (opencl_language_data): Likewise.
1486         * p-lang.c (pascal_language_data): Likewise.
1487         * rust-lang.c (rust_language_data): Likewise.
1488
1489 2020-06-16  Tom Tromey  <tom@tromey.com>
1490
1491         * tui/tui-data.h (STATUS_NAME): New macro.
1492         * tui/tui-layout.c (tui_remove_some_windows)
1493         (initialize_known_windows, tui_register_window)
1494         (tui_layout_split::remove_windows, initialize_layouts)
1495         (tui_new_layout_command): Don't use hard-coded window names.
1496
1497 2020-06-16  Tom Tromey  <tom@tromey.com>
1498
1499         PR tui/25348:
1500         * tui/tui.c (tui_ensure_readline_initialized): Rename from
1501         tui_initialize_readline.  Only run once.  Call rl_initialize.
1502         * tui/tui.h (tui_ensure_readline_initialized): Rename from
1503         tui_initialize_readline.
1504         * tui/tui-io.c (tui_setup_io): Call
1505         tui_ensure_readline_initialized.
1506         * tui/tui-interp.c (tui_interp::init): Update.
1507
1508 2020-06-16  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-layout.c (tui_layout_split::remove_windows): Fix logic.
1511         Also preserve the status window.
1512
1513 2020-06-16  Tom Tromey  <tom@tromey.com>
1514
1515         * python/py-tui.c (tui_py_window::~tui_py_window): Handle case
1516         where m_window==nullptr.
1517
1518 2020-06-15  Tom Tromey  <tromey@adacore.com>
1519
1520         * windows-nat.c (windows_nat::handle_output_debug_string):
1521         Update.
1522         (windows_nat::handle_ms_vc_exception): Update.
1523         * target.h (target_read_string): Change API.
1524         * target.c (target_read_string): Change API.
1525         * solib-svr4.c (open_symbol_file_object, svr4_read_so_list):
1526         Update.
1527         * solib-frv.c (frv_current_sos): Update.
1528         * solib-dsbt.c (dsbt_current_sos): Update.
1529         * solib-darwin.c (darwin_current_sos): Update.
1530         * linux-thread-db.c (inferior_has_bug): Update.
1531         * expprint.c (print_subexp_standard): Update.
1532         * ada-lang.c (ada_main_name, ada_tag_name_from_tsd)
1533         (ada_exception_message_1): Update.
1534
1535 2020-06-15  Tom Tromey  <tromey@adacore.com>
1536
1537         * linux-tdep.c (dump_mapping_p): Use target_read_memory.
1538
1539 2020-06-15  Tom Tromey  <tromey@adacore.com>
1540
1541         * valprint.c (read_string): Update comment.
1542         * target.c (MIN): Remove.
1543         (target_read_string): Rewrite.
1544
1545 2020-06-15  Tom Tromey  <tromey@adacore.com>
1546
1547         * corefile.c (read_memory_string): Remove.
1548         * ada-valprint.c (ada_value_print_ptr): Update.
1549         * ada-lang.h (ada_tag_name): Change return type.
1550         * ada-lang.c (type_from_tag): Update.
1551         (ada_tag_name_from_tsd): Change return type.  Use
1552         target_read_string.
1553         (ada_tag_name): Likewise.
1554         * gdbcore.h (read_memory_string): Don't declare.
1555
1556 2020-06-14  Hannes Domani  <ssbssa@yahoo.de>
1557
1558         * symtab.c (rbreak_command): Ignore Windows drive colon.
1559
1560 2020-06-12  Simon Marchi  <simon.marchi@efficios.com>
1561
1562         * NEWS: Mention removed GDBserver host support.
1563
1564 2020-06-12  Nelson Chu  <nelson.chu@sifive.com>
1565
1566         * features/riscv/rebuild-csr-xml.sh: Updated.
1567
1568 2020-06-11  Tom Tromey  <tom@tromey.com>
1569
1570         PR gdb/18318:
1571         * c-exp.y (lex_one_token): Handle 'p' like 'e'.
1572
1573 2020-06-09  Jonny Grant  <jg@jguk.org>
1574 2020-06-09  Simon Marchi  <simon.marchi@polymtl.ca>
1575
1576         * main.c (captured_main_1): Don't print new line after help.
1577         (print_gdb_help): add mailing list and IRC channel information
1578         to --help.  Add new lines between items in the footer.  Remove
1579         quotes around bug url.
1580
1581 2020-06-11  Keith Seitz  <keiths@redhat.com>
1582
1583         PR gdb/21356
1584         * gdbtypes.c (resolve_dynamic_union, resolve_dynamic_struct):
1585         Resolve typedefs for type length calculations.
1586
1587 2020-06-10  Tom de Vries  <tdevries@suse.de>
1588
1589         PR ada/24713
1590         * dwarf2/index-write.c (struct mapped_symtab): Add m_string_obstack.
1591         (write_psymbols): Enable .gdb_index for ada.
1592         * dwarf2/read.c: Remove comment stating .gdb_index is unsupported for
1593         ada.
1594
1595 2020-06-10  Tom de Vries  <tdevries@suse.de>
1596
1597         * dwarf2/read.c (dw2_symtab_iter_init_common): Factor out of ...
1598         (dw2_symtab_iter_init): ... here.  Add variant with "offset_type
1599         namei" instead of "const char *name" argument.
1600         (dw2_map_matching_symbols): Use "offset_type namei" variant of
1601         dw2_symtab_iter_init.
1602
1603 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1604
1605         * gdbtypes.h (TYPE_FIELD_TYPE): Remove.  Change all call sites
1606         to use type::field and field::type instead.
1607
1608 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1609
1610         * gdbtypes.h (FIELD_TYPE): Remove.  Change all call sites
1611         to use field::type instead.
1612
1613 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1614
1615         * gdbtypes.h (struct field) <type, set_type>: New methods.
1616         Rename `type` field to...
1617         <m_type>: ... this.  Change references throughout to use type or
1618         set_type methods.
1619         (FIELD_TYPE): Use field::type.  Change call sites that modify
1620         the field's type to use field::set_type instead.
1621
1622 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1623
1624         * gdbtypes.h (TYPE_INDEX_TYPE): Remove.  Change all call sites
1625         to use type::index_type instead.
1626
1627 2020-06-08  Simon Marchi  <simon.marchi@efficios.com>
1628
1629         * gdbtypes.h (struct type) <index_type, set_index_type>: New
1630         methods.
1631         (TYPE_INDEX_TYPE): Use type::index_type.
1632         * gdbtypes.c (create_array_type_with_stride): Likewise.
1633
1634 2020-06-07  Tom Tromey  <tom@tromey.com>
1635
1636         * valprint.c (generic_val_print_float): Remove "embedded_offset"
1637         parameter.
1638         (generic_value_print): Update.
1639
1640 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1641
1642         Revert commit 982a38f60b0.
1643         * python/py-tui.c (gdbpy_tui_set_title): Restore use of get.
1644
1645 2020-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1646
1647         * python/py-tui.c (gdbpy_tui_set_title): Use release, not get, to
1648         avoid use after free.
1649
1650 2020-06-05  Tom de Vries  <tdevries@suse.de>
1651
1652         * NEWS: Fix typos.
1653
1654 2020-06-04  Simon Marchi  <simon.marchi@efficios.com>
1655
1656         * dwarf2/read.c (dwarf2_read_gdb_index): Save partial_symtabs in
1657         the per_bfd object.
1658         (dwarf2_read_debug_names): Likewise.
1659         (dwarf2_initialize_objfile): Use partial_symtabs from per_bfd
1660         object when re-using a per_bfd object with an index.
1661
1662 2020-06-03  Tom de Vries  <tdevries@suse.de>
1663
1664         PR symtab/26046
1665         * dwarf2/read.c (scan_partial_symbols): Recurse into DW_TAG_subprogram
1666         children for C++.
1667         (load_partial_dies): Don't skip DW_TAG_inlined_subroutine child of
1668         DW_TAG_subprogram.
1669
1670 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1671
1672         * ada-lang.c (ada_language_data): Delete skip_trampoline
1673         initializer.
1674         * c-lang.c (c_language_data): Likewise.
1675         (cplus_language_data): Likewise.
1676         (cplus_language::skip_trampoline): New member function.
1677         (asm_language_data): Delete skip_trampoline initializer.
1678         (minimal_language_data): Likewise.
1679         * d-lang.c (d_language_data): Likewise.
1680         * f-lang.c (f_language_data): Likewise.
1681         * go-lang.c (go_language_data): Likewise.
1682         * language.c (unk_lang_trampoline): Delete function.
1683         (skip_language_trampoline): Update.
1684         (unknown_language_data): Delete skip_trampoline initializer.
1685         (auto_language_data): Likewise.
1686         * language.h (language_data): Delete skip_trampoline field.
1687         (language_defn::skip_trampoline): New function.
1688         * m2-lang.c (m2_language_data): Delete skip_trampoline
1689         initializer.
1690         * objc-lang.c (objc_skip_trampoline): Delete function, move
1691         implementation to objc_language::skip_trampoline.
1692         (objc_language_data): Delete skip_trampoline initializer.
1693         (objc_language::skip_trampoline): New member function with
1694         implementation from objc_skip_trampoline.
1695         * opencl-lang.c (opencl_language_data): Delete skip_trampoline
1696         initializer.
1697         * p-lang.c (pascal_language_data): Likewise.
1698         * rust-lang.c (rust_language_data): Likewise.
1699
1700 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1701
1702         * ada-lang.c (ada_language_data): Delete la_demangle initializer.
1703         (ada_language::demangle): New member function.
1704         * c-lang.c (c_language_data): Delete la_demangle initializer.
1705         (cplus_language_data): Delete la_demangle initializer.
1706         (cplus_language::demangle): New member function.
1707         (asm_language_data): Delete la_demangle initializer.
1708         (minimal_language_data): Delete la_demangle initializer.
1709         * d-lang.c (d_language_data): Delete la_demangle initializer.
1710         (d_language::demangle): New member function.
1711         * f-lang.c (f_language_data): Delete la_demangle initializer.
1712         (f_language::demangle): New member function.
1713         * go-lang.c (go_language_data): Delete la_demangle initializer.
1714         (go_language::demangle): New member function.
1715         * language.c (language_demangle): Update.
1716         (unk_lang_demangle): Delete.
1717         (unknown_language_data): Delete la_demangle initializer.
1718         (unknown_language::demangle): New member function.
1719         (auto_language_data): Delete la_demangle initializer.
1720         (auto_language::demangle): New member function.
1721         * language.h (language_data): Delete la_demangle field.
1722         (language_defn::demangle): New function.
1723         * m2-lang.c (m2_language_data): Delete la_demangle initializer.
1724         * objc-lang.c (objc_language_data): Delete la_demangle
1725         initializer.
1726         (objc_language::demangle): New member function.
1727         * opencl-lang.c (opencl_language_data): Delete la_demangle
1728         initializer.
1729         * p-lang.c (pascal_language_data): Likewise.
1730         * rust-lang.c (rust_language_data): Likewise.
1731         (rust_language::demangle): New member function.
1732
1733 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1734
1735         * ada-lang.c (ada_language_data): Delete la_print_type
1736         initializer.
1737         (ada_language::print_type): New member function.
1738         * c-lang.c (c_language_data): Delete la_print_type initializer.
1739         (c_language::print_type): New member function.
1740         (cplus_language_data): Delete la_print_type initializer.
1741         (cplus_language::print_type): New member function.
1742         (asm_language_data): Delete la_print_type initializer.
1743         (asm_language::print_type): New member function.
1744         (minimal_language_data): Delete la_print_type initializer.
1745         (minimal_language::print_type): New member function.
1746         * d-lang.c (d_language_data): Delete la_print_type initializer.
1747         (d_language::print_type): New member function.
1748         * f-lang.c (f_language_data): Delete la_print_type initializer.
1749         (f_language::print_type): New member function.
1750         * go-lang.c (go_language_data): Delete la_print_type initializer.
1751         (go_language::print_type): New member function.
1752         * language.c (unk_lang_print_type): Delete.
1753         (unknown_language_data): Delete la_print_type initializer.
1754         (unknown_language::print_type): New member function.
1755         (auto_language_data): Delete la_print_type initializer.
1756         (auto_language::print_type): New member function.
1757         * language.h (language_data): Delete la_print_type field.
1758         (language_defn::print_type): New function.
1759         (LA_PRINT_TYPE): Update.
1760         * m2-lang.c (m2_language_data): Delete la_print_type initializer.
1761         (m2_language::print_type): New member function.
1762         * objc-lang.c (objc_language_data): Delete la_print_type
1763         initializer.
1764         (objc_language::print_type): New member function.
1765         * opencl-lang.c (opencl_print_type): Delete, implementation moved
1766         to opencl_language::print_type.
1767         (opencl_language_data): Delete la_print_type initializer.
1768         (opencl_language::print_type): New member function, implementation
1769         from opencl_print_type.
1770         * p-lang.c (pascal_language_data): Delete la_print_type
1771         initializer.
1772         (pascal_language::print_type): New member function.
1773         * rust-lang.c (rust_print_type): Delete, implementation moved to
1774         rust_language::print_type.
1775         (rust_language_data): Delete la_print_type initializer.
1776         (rust_language::print_type): New member function, implementation
1777         from rust_print_type.
1778
1779 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1780
1781         * ada-lang.c (ada_sniff_from_mangled_name): Delete function,
1782         implementation moves to...
1783         (ada_language::sniff_from_mangled_name): ...here.  Update return
1784         type.
1785         (ada_language_data): Delete la_sniff_from_mangled_name
1786         initializer.
1787         * c-lang.c (c_language_data): Likewise.
1788         (cplus_language_data): Likewise.
1789         (cplus_language::sniff_from_mangled_name): New member function,
1790         implementation taken from gdb_sniff_from_mangled_name.
1791         (asm_language_data): Delete la_sniff_from_mangled_name
1792         initializer.
1793         (minimal_language_data): Likewise.
1794         * cp-support.c (gdb_sniff_from_mangled_name): Delete,
1795         implementation moves to cplus_language::sniff_from_mangled_name.
1796         * cp-support.h (gdb_sniff_from_mangled_name): Delete declaration.
1797         * d-lang.c (d_sniff_from_mangled_name): Delete, implementation
1798         moves to...
1799         (d_language::sniff_from_mangled_name): ...here.
1800         (d_language_data): Delete la_sniff_from_mangled_name initializer.
1801         * f-lang.c (f_language_data): Likewise.
1802         * go-lang.c (go_sniff_from_mangled_name): Delete, implementation
1803         moves to...
1804         (go_language::sniff_from_mangled_name): ...here.
1805         (go_language_data): Delete la_sniff_from_mangled_name initializer.
1806         * language.c (language_sniff_from_mangled_name): Delete.
1807         (unknown_language_data): Delete la_sniff_from_mangled_name
1808         initializer.
1809         (auto_language_data): Likewise.
1810         * language.h (language_data): Delete la_sniff_from_mangled_name
1811         field.
1812         (language_defn::sniff_from_mangled_name): New function.
1813         (language_sniff_from_mangled_name): Delete declaration.
1814         * m2-lang.c (m2_language_data): Delete la_sniff_from_mangled_name
1815         field.
1816         * objc-lang.c (objc_sniff_from_mangled_name): Delete,
1817         implementation moves to...
1818         (objc_language::sniff_from_mangled_name): ...here.
1819         (objc_language_data): Delete la_sniff_from_mangled_name initializer.
1820         * opencl-lang.c (opencl_language_data): Likewise.
1821         * p-lang.c (pascal_language_data): Likewise.
1822         * rust-lang.c (rust_sniff_from_mangled_name): Delete,
1823         implementation moves to...
1824         (rust_language::sniff_from_mangled_name): ...here.
1825         (rust_language_data): Delete la_sniff_from_mangled_name
1826         initializer.
1827         * symtab.c (symbol_find_demangled_name): Call
1828         sniff_from_mangled_name member function.
1829
1830 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1831
1832         * ada-lang.c (ada_language_data): Delete la_search_name_hash
1833         initializer.
1834         * c-lang.c (c_language_data): Likewise.
1835         (cplus_language_data): Likewise.
1836         (cplus_language::search_name_hash): New member function.
1837         (asm_language_data): Delete la_search_name_hash initializer.
1838         (minimal_language_data): Likewise.
1839         * d-lang.c (d_language_data): Likewise.
1840         * dictionary.c (default_search_name_hash): Rename to...
1841         (language_defn::search_name_hash): ...this.
1842         * f-lang.c (f_language_data): Likewise.
1843         (f_language::search_name_hash): New member function.
1844         * go-lang.c (go_language_data): Delete la_search_name_hash
1845         initializer.
1846         * language.c (unknown_language_data): Likewise.
1847         (auto_language_data): Likewise.
1848         * language.h (struct language_data): Delete la_search_name_hash
1849         field.
1850         (language_defn::search_name_hash): Declare new member function.
1851         (default_search_name_hash): Delete declaration.
1852         * m2-lang.c (m2_language_data): Delete la_search_name_hash
1853         initializer.
1854         * objc-lang.c (objc_language_data): Likewise.
1855         * opencl-lang.c (opencl_language_data): Likewise.
1856         * p-lang.c (pascal_language_data): Likewise.
1857         * rust-lang.c (rust_language_data): Likewise.
1858         * symtab.c (search_name_hash): Update call.
1859
1860 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1861
1862         * ada-lang.c (ada_language_data): Delete la_get_compile_instance
1863         initializer.
1864         * c-lang.c (class compile_instance): Declare.
1865         (c_language_data): Delete la_get_compile_instance initializer.
1866         (c_language::get_compile_instance): New member function.
1867         (cplus_language_data): Delete la_get_compile_instance initializer.
1868         (cplus_language::get_compile_instance): New member function.
1869         (asm_language_data): Delete la_get_compile_instance initializer.
1870         (minimal_language_data): Likewise.
1871         * c-lang.h (c_get_compile_context): Update comment.
1872         (cplus_get_compile_context): Update comment.
1873         * compile/compile.c (compile_to_object): Update calls, don't rely
1874         on function pointer being NULL.
1875         * d-lang.c (d_language_data): Delete la_get_compile_instance
1876         initializer.
1877         * f-lang.c (f_language_data): Likewise.
1878         * go-lang.c (go_language_data): Likewise.
1879         * language.c (unknown_language_data): Likewise.
1880         (auto_language_data): Likewise.
1881         * language.h (language_data): Delete la_get_compile_instance field.
1882         (language_defn::get_compile_instance): New member function.
1883         * m2-lang.c (m2_language_data): Delete la_get_compile_instance
1884         initializer.
1885         * objc-lang.c (objc_language_data): Likewise.
1886         * opencl-lang.c (opencl_language_data): Likewise.
1887         * p-lang.c (pascal_language_data): Likewise.
1888         * rust-lang.c (rust_language_data): Likewise.
1889
1890 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * ada-lang.c (ada_add_all_symbols): Update comment.
1893         (ada_iterate_over_symbols): Delete, move implementation to...
1894         (ada_language::iterate_over_symbols): ...here, a new member
1895         function, rewrite to use range based for loop.
1896         (ada_language_data): Delete la_iterate_over_symbols initializer.
1897         * c-lang.c (c_language_data): Likewise.
1898         (cplus_language_data): Likewise.
1899         (asm_language_data): Likewise.
1900         (minimal_language_data): Likewise.
1901         * d-lang.c (d_language_data): Likewise.
1902         * f-lang.c (f_language_data): Likewise.
1903         * go-lang.c (go_language_data): Likewise.
1904         * language.c (unknown_language_data): Likewise.
1905         (auto_language_data): Likewise.
1906         * language.h (language_data): Delete la_iterate_over_symbols field.
1907         (language_defn::iterate_over_symbols): New member function.
1908         (LA_ITERATE_OVER_SYMBOLS): Update.
1909         * linespec.c (iterate_over_all_matching_symtabs): Update.
1910         * m2-lang.c (m2_language_data): Delete la_iterate_over_symbols
1911         initializer.
1912         * objc-lang.c (objc_language_data): Likewise.
1913         * opencl-lang.c (opencl_language_data): Likewise.
1914         * p-lang.c (pascal_language_data): Likewise.
1915         * rust-lang.c (rust_language_data): Likewise.
1916
1917 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1918
1919         * ada-lang.c (ada_language_data): Delete
1920         la_lookup_transparent_type initializer.
1921         * c-lang.c (c_language_data): Likewise.
1922         (cplus_language_data): Likewise.
1923         (cplus_language::lookup_transparent_type): New member function.
1924         (asm_language_data): Delete la_lookup_transparent_type
1925         initializer.
1926         (minimal_language_data): Likewise.
1927         * d-lang.c (d_language_data): Likewise.
1928         * f-lang.c (f_language_data): Likewise.
1929         * go-lang.c (go_language_data): Likewise.
1930         * language.c (unknown_language_data): Likewise.
1931         (auto_language_data): Likewise.
1932         * language.h (struct language_data): Delete
1933         la_lookup_transparent_type field.
1934         (language_defn::lookup_transparent_type): New member function.
1935         * m2-lang.c (m2_language_data): Delete la_lookup_transparent_type
1936         initializer.
1937         * objc-lang.c (objc_language_data): Likewise.
1938         * opencl-lang.c (opencl_language_data): Likewise.
1939         * p-lang.c (pascal_language_data): Likewise.
1940         * rust-lang.c (rust_language_data): Likewise.
1941         * symtab.c (symbol_matches_domain): Update call.
1942
1943 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1944
1945         * ada-lang.c (ada_language_arch_info): Delete function, move
1946         implementation to...
1947         (ada_language::language_arch_info): ...here, a new member
1948         function.
1949         (ada_language_data): Delete la_language_arch_info.
1950         * c-lang.c (c_language_data): Likewise.
1951         (c_language::language_arch_info): New member function.
1952         (cplus_language_arch_info): Delete function, move
1953         implementation to...
1954         (cplus_language::language_arch_info): ...here, a new member
1955         function.
1956         (cplus_language_data): Delete la_language_arch_info.
1957         (asm_language_data): Likewise.
1958         (asm_language::language_arch_info): New member function.
1959         (minimal_language_data): Delete la_language_arch_info.
1960         (minimal_language::language_arch_info): New member function.
1961         * d-lang.c (d_language_arch_info): Delete function, move
1962         implementation to...
1963         (d_language::language_arch_info): ...here, a new member
1964         function.
1965         (d_language_data): Delete la_language_arch_info.
1966         * f-lang.c (f_language_arch_info): Delete function, move
1967         implementation to...
1968         (f_language::language_arch_info): ...here, a new member
1969         function.
1970         (f_language_data): Delete la_language_arch_info.
1971         * go-lang.c (go_language_arch_info): Delete function, move
1972         implementation to...
1973         (go_language::language_arch_info): ...here, a new member
1974         function.
1975         (go_language_data): Delete la_language_arch_info.
1976         * language.c (unknown_language_data): Likewise.
1977         (unknown_language::language_arch_info): New member function.
1978         (auto_language_data): Delete la_language_arch_info.
1979         (auto_language::language_arch_info): New member function.
1980         (language_gdbarch_post_init): Update call to
1981         la_language_arch_info.
1982         * language.h (language_data): Delete la_language_arch_info
1983         function pointer.
1984         (language_defn::language_arch_info): New function.
1985         * m2-lang.c (m2_language_arch_info): Delete function, move
1986         implementation to...
1987         (m2_language::language_arch_info): ...here, a new member
1988         function.
1989         (m2_language_data): Delete la_language_arch_info.
1990         * objc-lang.c (objc_language_arch_info): Delete function, move
1991         implementation to...
1992         (objc_language::language_arch_info): ...here, a new member
1993         function.
1994         (objc_language_data): Delete la_language_arch_info.
1995         * opencl-lang.c (opencl_language_arch_info): Delete function, move
1996         implementation to...
1997         (opencl_language::language_arch_info): ...here, a new member
1998         function.
1999         (opencl_language_data): Delete la_language_arch_info.
2000         * p-lang.c (pascal_language_arch_info): Delete function, move
2001         implementation to...
2002         (pascal_language::language_arch_info): ...here, a new member
2003         function.
2004         (pascal_language_data): Delete la_language_arch_info.
2005         * rust-lang.c (rust_language_arch_info): Delete function, move
2006         implementation to...
2007         (rust_language::language_arch_info): ...here, a new member
2008         function.
2009         (rust_language_data): Delete la_language_arch_info.
2010
2011 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2012
2013         * ada-lang.c (ada_language_data): Delete la_pass_by_reference
2014         initializer.
2015         * c-lang.c (c_language_data): Likewise.
2016         (cplus_language_data): Likewise.
2017         (cplus_language::pass_by_reference_info): New method.
2018         (asm_language_data): Delete la_pass_by_reference initializer.
2019         (minimal_language_data): Likewise.
2020         * cp-abi.c (cp_pass_by_reference): Remove use of
2021         default_pass_by_reference.
2022         * d-lang.c (d_language_data): Likewise.
2023         * f-lang.c (f_language_data): Likewise.
2024         * gnu-v3-abi.c (gnuv3_pass_by_reference): Remove use of
2025         default_pass_by_reference.
2026         * go-lang.c (go_language_data): Likewise.
2027         * language.c (language_pass_by_reference): Update.
2028         (default_pass_by_reference): Delete.
2029         (unknown_language_data): Delete la_pass_by_reference
2030         initializer.
2031         (auto_language_data): Likewise.
2032         * language.h (struct language_data): Delete la_pass_by_reference
2033         field.
2034         (language_defn::pass_by_reference_info): New member function.
2035         (default_pass_by_reference): Delete declaration.
2036         * m2-lang.c (m2_language_data): Delete la_pass_by_reference
2037         initializer.
2038         * objc-lang.c (objc_language_data): Likewise.
2039         * opencl-lang.c (opencl_language_data): Likewise.
2040         * p-lang.c (pascal_language_data): Likewise.
2041         * rust-lang.c (rust_language_data): Likewise.
2042
2043 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2044
2045         * ada-lang.c (ada_read_var_value): Delete function, move
2046         implementation to...
2047         (ada_language::read_var_value): ...here.
2048         (ada_language_data): Delete la_read_var_value initializer.
2049         * c-lang.c (c_language_data): Likewise.
2050         (cplus_language_data): Likewise.
2051         (minimal_language_data): Likewise.
2052         * d-lang.c (d_language_data): Likewise.
2053         * f-lang.c (f_language_data): Likewise.
2054         * findvar.c (default_read_var_value): Rename to...
2055         (language_defn::read_var_value): ...this.
2056         * findvar.c (read_var_value): Update header comment, and change to
2057         call member function instead of function pointer.
2058         * go-lang.c (go_language_data): Likewise.
2059         * language.c (unknown_language_data): Delete la_read_var_value
2060         initializer.
2061         (auto_language_data): Likewise.
2062         * language.h (struct language_data): Delete la_read_var_value
2063         field.
2064         (language_defn::read_var_value): New member function.
2065         (default_read_var_value): Delete declaration.
2066         * m2-lang.c (m2_language_data): Delete la_read_var_value
2067         initializer.
2068         * objc-lang.c (objc_language_data): Likewise.
2069         * opencl-lang.c (opencl_language_data): Likewise.
2070         * p-lang.c (pascal_language_data): Likewise.
2071         * rust-lang.c (rust_language_data): Likewise.
2072         * value.h (default_read_var_value): Delete declaration.
2073
2074 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2075
2076         * ada-lang.c (ada_print_array_index): Delete function, move
2077         implementation to...
2078         (ada_language::print_array_index): ...here.
2079         (ada_language_data): Delete la_print_array_index initializer.
2080         * c-lang.c (c_language_data): Likewise.
2081         (cplus_language_data): Likewise.
2082         (minimal_language_data): Likewise.
2083         * d-lang.c (d_language_data): Likewise.
2084         * f-lang.c (f_language_data): Likewise.
2085         * go-lang.c (go_language_data): Likewise.
2086         * language.c (default_print_array_index): Delete function, move
2087         implementation to...
2088         (language_defn::print_array_index): ...here.
2089         (unknown_language_data): Delete la_print_array_index initializer.
2090         (auto_language_data): Likewise.
2091         * language.h (struct language_data): Delete la_print_array_index
2092         field.
2093         (language_defn::print_array_index): New member function.
2094         (LA_PRINT_ARRAY_INDEX): Update.
2095         (default_print_array_index): Delete declaration.
2096         * m2-lang.c (m2_language_data): Delete la_print_array_index
2097         initializer.
2098         * objc-lang.c (objc_language_data): Likewise.
2099         * opencl-lang.c (opencl_language_data): Likewise.
2100         * p-lang.c (pascal_language_data): Likewise.
2101         * rust-lang.c (rust_language_data): Likewise.
2102
2103 2020-06-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2104
2105         * gdb/ada-lang.c (ada_language_defn): Convert to...
2106         (ada_language_data): ...this.
2107         (class ada_language): New class.
2108         (ada_language_defn): New static global.
2109         * gdb/c-lang.c (c_language_defn): Convert to...
2110         (c_language_data): ...this.
2111         (class c_language): New class.
2112         (c_language_defn): New static global.
2113         (cplus_language_defn): Convert to...
2114         (cplus_language_data): ...this.
2115         (class cplus_language): New class.
2116         (cplus_language_defn): New static global.
2117         (asm_language_defn): Convert to...
2118         (asm_language_data): ...this.
2119         (class asm_language): New class.
2120         (asm_language_defn): New static global.
2121         (minimal_language_defn): Convert to...
2122         (minimal_language_data): ...this.
2123         (class minimal_language): New class.
2124         (minimal_language_defn): New static global.
2125         * gdb/d-lang.c (d_language_defn): Convert to...
2126         (d_language_data): ...this.
2127         (class d_language): New class.
2128         (d_language_defn): New static global.
2129         * gdb/f-lang.c (f_language_defn): Convert to...
2130         (f_language_data): ...this.
2131         (class f_language): New class.
2132         (f_language_defn): New static global.
2133         * gdb/go-lang.c (go_language_defn): Convert to...
2134         (go_language_data): ...this.
2135         (class go_language): New class.
2136         (go_language_defn): New static global.
2137         * gdb/language.c (unknown_language_defn): Remove declaration.
2138         (current_language): Initialize to nullptr, real initialization is
2139         moved to _initialize_language.
2140         (languages): Delete global.
2141         (language_defn::languages): Define.
2142         (set_language_command): Use language_defn::languages.
2143         (set_language): Likewise.
2144         (range_error): Likewise.
2145         (language_enum): Likewise.
2146         (language_def): Likewise.
2147         (add_set_language_command): Use language_def::languages for the
2148         language list, and language_def to lookup language pointers.
2149         (skip_language_trampoline): Use language_defn::languages.
2150         (unknown_language_defn): Convert to...
2151         (unknown_language_data): ...this.
2152         (class unknown_language): New class.
2153         (unknown_language_defn): New static global.
2154         (auto_language_defn): Convert to...
2155         (auto_language_data): ...this.
2156         (class auto_language): New class.
2157         (auto_language_defn): New static global.
2158         (language_gdbarch_post_init): Use language_defn::languages.
2159         (_initialize_language): Initialize current_language.
2160         * gdb/language.h (struct language_defn): Rename to...
2161         (struct language_data): ...this.
2162         (struct language_defn): New.
2163         (auto_language_defn): Delete.
2164         (unknown_language_defn): Delete.
2165         (minimal_language_defn): Delete.
2166         (ada_language_defn): Delete.
2167         (asm_language_defn): Delete.
2168         (c_language_defn): Delete.
2169         (cplus_language_defn): Delete.
2170         (d_language_defn): Delete.
2171         (f_language_defn): Delete.
2172         (go_language_defn): Delete.
2173         (m2_language_defn): Delete.
2174         (objc_language_defn): Delete.
2175         (opencl_language_defn): Delete.
2176         (pascal_language_defn): Delete.
2177         (rust_language_defn): Delete.
2178         * gdb/m2-lang.c (m2_language_defn): Convert to...
2179         (m2_language_data): ...this.
2180         (class m2_language): New class.
2181         (m2_language_defn): New static global.
2182         * gdb/objc-lang.c (objc_language_defn): Convert to...
2183         (objc_language_data): ...this.
2184         (class objc_language): New class.
2185         (objc_language_defn): New static global.
2186         * gdb/opencl-lang.c (opencl_language_defn): Convert to...
2187         (opencl_language_data): ...this.
2188         (class opencl_language): New class.
2189         (opencl_language_defn): New static global.
2190         * gdb/p-lang.c (pascal_language_defn): Convert to...
2191         (pascal_language_data): ...this.
2192         (class pascal_language): New class.
2193         (pascal_language_defn): New static global.
2194         * gdb/rust-exp.y (rust_lex_tests): Use language_def to find
2195         language pointer, update comment format.
2196         * gdb/rust-lang.c (rust_language_defn): Convert to...
2197         (rust_language_data): ...this.
2198         (class rust_language): New class.
2199         (rust_language_defn): New static global.
2200
2201 2020-06-01  Andrew Burgess  <andrew.burgess@embecosm.com>
2202
2203         * dwarf2/read.c (class lnp_state_machine) <m_last_address>: New
2204         member variable.
2205         <m_stmt_at_address>: New member variable.
2206         (lnp_state_machine::record_line): Don't record some lines, update
2207         tracking of is_stmt at the same address.
2208         (lnp_state_machine::lnp_state_machine): Initialise new member
2209         variables.
2210
2211 2020-06-01  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2212
2213         * config/i386/i386gnu.mn [%_S.o %_U.o] (COMPILE.post): Add
2214         "-include gnu-nat-mig.h".
2215         * gnu-nat-mig.h: New file.
2216         * gnu-nat.c: Include "gnu-nat-mig.h".
2217         (exc_server, msg_reply_server, notify_server,
2218         process_reply_server): Remove declarations.
2219
2220 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2221
2222         * gnu-nat.h (inf_validate_procs, inf_suspend, inf_set_traced,
2223         steal_exc_port, proc_get_state, inf_clear_wait, inf_cleanup,
2224         inf_startup, inf_update_suspends, inf_set_pid, inf_steal_exc_ports,
2225         inf_validate_procinfo, inf_validate_task_sc, inf_restore_exc_ports,
2226         inf_set_threads_resume_sc, inf_set_threads_resume_sc_for_signal_thread,
2227         inf_resume, inf_set_step_thread, inf_detach, inf_attach, inf_signal,
2228         inf_continue, make_proc, proc_abort, _proc_free, proc_update_sc,
2229         proc_get_exception_port, proc_set_exception_port, _proc_get_exc_port,
2230         proc_steal_exc_port, proc_restore_exc_port, proc_trace): Move functions
2231         to gnu_nat_target class.
2232         * gnu-nat.c: Likewise.
2233         (inf_update_procs, S_proc_wait_reply, set_task_pause_cmd,
2234         set_task_exc_port_cmd, set_signals_cmd, set_thread_pause_cmd,
2235         set_thread_exc_port_cmd): Call inf_validate_procs through gnu_target
2236         object.
2237         (gnu_nat_target::create_inferior, gnu_nat_target::detach): Pass `this'
2238         instead of `gnu_target'.
2239
2240 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2241
2242         * i386-gnu-tdep.c: Include "gdbcore.h"
2243         (gnu_sigtramp_code, i386_gnu_sc_reg_offset): New arrays.
2244         (GNU_SIGTRAMP_LEN, GNU_SIGTRAMP_TAIL,
2245         I386_GNU_SIGCONTEXT_THREAD_STATE_OFFSET): New macros
2246         (i386_gnu_sigtramp_start, i386_gnu_sigtramp_p,
2247         i386_gnu_sigcontext_addr): New functions
2248         (i386gnu_init_abi): Register i386_gnu_sigtramp_p,
2249         i386_gnu_sigcontext_addr, and i386_gnu_sc_reg_offset in the gdbarch
2250         tdep.
2251
2252 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2253
2254         * gnu-nat.c (gnu_nat_target::create_inferior): Move push_target call
2255         before fork_inferior call. Avoid calling it if target_is_pushed returns
2256         true.
2257
2258 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2259
2260         * gnu-nat.h (gnu_target): New variable declaration.
2261         * i386-gnu-nat.c (_initialize_i386gnu_nat): Initialize
2262         gnu_target.
2263         * gnu-nat.c (gnu_target): New variable.
2264         (inf_validate_procs): Pass gnu_target to thread_change_ptid,
2265         add_thread_silent, and add_thread calls.
2266         (gnu_nat_target::create_inferior): Pass gnu_target to
2267         add_thread_silent, thread_change_ptid call.
2268         (gnu_nat_target::detach): Pass gnu_target to detach_inferior
2269         call.
2270
2271 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2272
2273         * gnu-nat.c (gnu_xfer_auxv): Remove unused `res' variable.
2274         (gnu_nat_target::find_memory_regions): Remove unused
2275         `old_address' variable.
2276
2277 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2278
2279         * gnu-nat.c: Include "gdbarch.h".
2280
2281 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2282
2283         * reply_mig_hack.awk (Error return): Cast function through
2284         void *, to bypass compiler function call check.
2285
2286 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2287
2288         * config/i386/i386gnu.mn (%_reply_S.c): Add dependency on
2289         $(srcdir)/reply_mig_hack.awk.
2290
2291 2020-05-30  Samuel Thibault  <samuel.thibault@ens-lyon.org>
2292
2293         * gnu-nat.h (gnu_debug_flag): Set type to bool.
2294
2295 2020-05-30  Jonny Grant  <jg@jguk.org>
2296
2297         * configure.ac (ACX_BUGURL): change bug URL to https.
2298
2299 2020-05-30  Pedro Alves  <palves@redhat.com>
2300
2301         * cp-support.c (replace_typedefs_template): New.
2302         (replace_typedefs_qualified_name): Handle
2303         DEMANGLE_COMPONENT_TEMPLATE.
2304
2305 2020-05-29  Simon Marchi  <simon.marchi@efficios.com>
2306
2307         * dwarf2/comp-unit.c, dwarf2/comp-unit.h, dwarf2/index-cache.c,
2308         dwarf2/index-cache.h, dwarf2/index-write.c,
2309         dwarf2/index-write.h, dwarf2/line-header.c,
2310         dwarf2/line-header.h, dwarf2/macro.c, dwarf2/macro.h,
2311         dwarf2/read.c, dwarf2/read.h: Rename struct dwarf2_per_objfile
2312         variables and fields from `dwarf2_per_objfile` to just
2313         `per_objfile` throughout.
2314
2315 2020-05-28  Simon Marchi  <simon.marchi@polymtl.ca>
2316
2317         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2318         <push_dwarf_reg_entry_value>: Add comment.
2319
2320 2020-05-28  Kevin Buettner  <kevinb@redhat.com>
2321             Keith Seitz  <keiths@redhat.com>
2322
2323         * python/python.c (do_start_initialization): Call PyEval_SaveThread
2324         instead of PyEval_ReleaseLock.
2325         (class gdbpy_gil): Move to earlier in file.
2326         (finalize_python): Set gdb_python_initialized.
2327         (gdbpy_check_quit_flag): Acquire GIL via gdbpy_gil.  Return early
2328         when not initialized.
2329
2330 2020-05-28  Simon Marchi  <simon.marchi@efficios.com>
2331
2332         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2333         <push_dwarf_reg_entry_value>: Remove assert.  Override
2334         per_objfile with caller_per_objfile.
2335
2336 2020-05-28  Tom de Vries  <tdevries@suse.de>
2337
2338         * dwarf2/read.c (dw2_symtab_iter_next, dw2_expand_marked_cus): Limit
2339         PR gold/15646 workaround to symbol kind "type".
2340
2341 2020-05-27  Tom Tromey  <tromey@adacore.com>
2342
2343         * dwarf2/read.c (load_partial_dies): Use add_partial_symbol.
2344
2345 2020-05-27  Tom Tromey  <tromey@adacore.com>
2346
2347         * dwarf2/abbrev.h (struct abbrev_table) <lookup_abbrev>: Inline.
2348         Use htab_find_with_hash.
2349         <add_abbrev>: Remove "abbrev_number" parameter.
2350         * dwarf2/abbrev.c (abbrev_table::add_abbrev): Remove
2351         "abbrev_number" parameter.  Use htab_find_slot_with_hash.
2352         (hash_abbrev): Add comment.
2353         (abbrev_table::lookup_abbrev): Move to header file.
2354         (abbrev_table::read): Update.
2355
2356 2020-05-27  Tom Tromey  <tromey@adacore.com>
2357
2358         * dwarf2/read.c (struct partial_die_info) <name>: Declare new
2359         method.
2360         <canonical_name>: New member.
2361         <raw_name>: Rename from "name".
2362         (partial_die_info): Initialize canonical_name.
2363         (scan_partial_symbols): Check raw_name.
2364         (partial_die_parent_scope, partial_die_full_name)
2365         (add_partial_symbol, add_partial_subprogram)
2366         (add_partial_enumeration, load_partial_dies): Use "name" method.
2367         (partial_die_info::name): New method.
2368         (partial_die_info::read, guess_partial_die_structure_name)
2369         (partial_die_info::fixup): Update.
2370
2371 2020-05-27  Tom Tromey  <tromey@adacore.com>
2372
2373         * dwarf2/attribute.h (struct attribute) <form_is_ref>: Inline.
2374         <get_ref_die_offset>: Inline.
2375         <get_ref_die_offset_complaint>: New method.
2376         * dwarf2/attribute.c (attribute::form_is_ref): Move to header.
2377         (attribute::get_ref_die_offset_complaint): Rename from
2378         get_ref_die_offset.  Just issue complaint.
2379
2380 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2381
2382         * cli/cli-cmds.c (shell_escape): Move exit_status_set_internal_vars.
2383
2384 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2385
2386         * exec.c (exec_file_attach): Use errno value of first openp failure.
2387
2388 2020-05-27  Hannes Domani  <ssbssa@yahoo.de>
2389
2390         * nat/windows-nat.c (windows_thread_info::~windows_thread_info):
2391         Don't close thread handle.
2392
2393 2020-05-27  Tom Tromey  <tom@tromey.com>
2394             Simon Marchi  <simon.marchi@efficios.com>
2395
2396         * objfiles.h (struct objfile) <partial_symtabs>: Now a
2397         shared_ptr.
2398         * dwarf2/read.h (struct dwarf2_per_objfile) <partial_symtabs>: New
2399         member.
2400         * dwarf2/read.c (dwarf2_per_bfd_bfd_data_key,
2401         dwarf2_per_bfd_objfile_data_key>: New globals.
2402         (dwarf2_has_info): Use shared dwarf2_per_bfd if possible.
2403         (dwarf2_get_section_info): Use get_dwarf2_per_objfile.
2404         (dwarf2_initialize_objfile): Consider cases where per_bfd can be
2405         shared.
2406         (dwarf2_build_psymtabs): Set objfile::partial_symtabs and
2407         short-circuit when sharing.
2408         (dwarf2_build_psymtabs): Set dwarf2_per_objfile::partial_symtabs.
2409         (dwarf2_psymtab::expand_psymtab): Use free_cached_comp_units.
2410
2411 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2412
2413         * dwarf2/read.h (struct dwarf2_per_bfd) <line_header_hash>: Move
2414         to...
2415         (struct dwarf2_per_objfile) <line_header_hash>: ... here.
2416         * dwarf2/read.c (handle_DW_AT_stmt_list): Update.
2417
2418 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2419
2420         * dwarf2/read.c (struct mapped_index_base) <symbol_name_at,
2421         build_name_components, find_name_components_bounds>:
2422         Add per_objfile parameter.
2423         (struct mapped_index) <symbol_name_at>: Likewise.
2424         (struct mapped_debug_names): Remove constructor.
2425         <dwarf2_per_objfile>: Remove field.
2426         <namei_to_name, symbol_name_at>: Add per_objfile parameter.
2427         (mapped_index_base::find_name_components_bounds,
2428         mapped_index_base::build_name_components,
2429         dw2_expand_symtabs_matching_symbol): Likewise.
2430         (class mock_mapped_index) <symbol_name_at>: Likewise.
2431         (check_match): Likewise.
2432         (check_find_bounds_finds): Likewise.
2433         (test_mapped_index_find_name_component_bounds): Update.
2434         (CHECK_MATCH): Update.
2435         (dw2_expand_symtabs_matching): Update.
2436         (class dw2_debug_names_iterator) <dw2_debug_names_iterator>: Add
2437         per_objfile parameter.
2438         <find_vec_in_debug_names>: Likewise.
2439         <m_per_objfile>: New field.
2440         (mapped_debug_names::namei_to_name): Add dwarf2_per_objfile
2441         parameter.
2442         (dw2_debug_names_iterator::find_vec_in_debug_names): Likewise.
2443         (dw2_debug_names_iterator::next): Update.
2444         (dw2_debug_names_lookup_symbol): Update.
2445         (dw2_debug_names_expand_symtabs_for_function): Update.
2446         (dw2_debug_names_map_matching_symbols): Update.
2447         (dw2_debug_names_expand_symtabs_matching): Update.
2448         (dwarf2_read_debug_names): Update.
2449
2450 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2451
2452         * dwarf2/read.h (struct dwarf2_cu): Forward-declare.
2453         (struct dwarf2_per_bfd) <free_cached_comp_units>: Remove,
2454         move to dwarf2_per_objfile.
2455         <read_in_chain>: Remove.
2456         (struct dwarf2_per_objfile) <get_cu, set_cu, remove_cu,
2457         remove_all_cus, age_comp_units>: New methods.
2458         <m_dwarf2_cus>: New member.
2459         (struct dwarf2_per_cu_data) <cu>: Remove.
2460         * dwarf2/read.c (struct dwarf2_cu) <read_in_chain>: Remove.
2461         (age_cached_comp_units, free_one_cached_comp_unit): Remove,
2462         moved to methods of dwarf2_per_objfile.
2463         (dwarf2_clear_marks): Remove.
2464         (dwarf2_queue_item::~dwarf2_queue_item): Update.
2465         (dwarf2_per_bfd::~dwarf2_per_bfd): Don't free dwarf2_cus.
2466         (dwarf2_per_bfd::free_cached_comp_units): Remove.
2467         (dwarf2_per_objfile::remove_all_cus): New.
2468         (class free_cached_comp_units) <~free_cached_comp_units>:
2469         Update.
2470         (load_cu): Update.
2471         (dw2_do_instantiate_symtab): Adjust.
2472         (fill_in_sig_entry_from_dwo_entry): Adjust.
2473         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2474         (cutu_reader::cutu_reader): Likewise.
2475         (cutu_reader::keep): Use dwarf2_per_objfile::set_cu.
2476         (cutu_reader::cutu_reader): Use dwarf2_per_objfile::get_cu.
2477         (process_psymtab_comp_unit): Use dwarf2_per_objfile::remove_cu
2478         and dwarf2_per_objfile::age_comp_units.
2479         (load_partial_comp_unit): Update.
2480         (maybe_queue_comp_unit): Use dwarf2_per_objfile::get_cu.
2481         (process_queue): Likewise.
2482         (find_partial_die): Use dwarf2_per_objfile::get_cu instead of cu
2483         backlink.
2484         (dwarf2_read_addr_index): Likewise.
2485         (follow_die_offset): Likewise.
2486         (dwarf2_fetch_die_loc_sect_off): Likewise.
2487         (dwarf2_fetch_constant_bytes): Likewise.
2488         (dwarf2_fetch_die_type_sect_off): Likewise.
2489         (follow_die_sig_1): Likewise.
2490         (load_full_type_unit): Likewise.
2491         (read_signatured_type): Likewise.
2492         (dwarf2_cu::dwarf2_cu): Don't set cu field.
2493         (dwarf2_cu::~dwarf2_cu): Remove.
2494         (dwarf2_per_objfile::get_cu): New.
2495         (dwarf2_per_objfile::set_cu): New.
2496         (age_cached_comp_units): Rename to...
2497         (dwarf2_per_objfile::age_comp_units): ... this.  Adjust
2498         to std::unordered_map.
2499         (free_one_cached_comp_unit): Rename to...
2500         (dwarf2_per_objfile::remove_cu): ... this.  Adjust
2501         to std::unordered_map.
2502         (dwarf2_per_objfile::~dwarf2_per_objfile): New.
2503         (dwarf2_mark_helper): Use dwarf2_per_objfile::get_cu, expect
2504         a dwarf2_per_objfile in data.
2505         (dwarf2_mark): Pass dwarf2_per_objfile in data to htab_traverse.
2506         (dwarf2_clear_marks): Remove.
2507
2508 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2509
2510         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Replace
2511         `int use_existing_cu` parameter with `dwarf2_cu *existing_cu`.
2512         (init_tu_and_read_dwo_dies): Likewise.
2513         (cutu_reader::init_tu_and_read_dwo_dies): Likewise.
2514         (cutu_reader::cutu_reader): Likewise.
2515         (load_partial_comp_unit): Likewise.
2516         (process_psymtab_comp_unit): Update.
2517         (build_type_psymtabs_1): Update.
2518         (process_skeletonless_type_unit): Update.
2519         (load_full_comp_unit): Update.
2520         (find_partial_die): Update.
2521         (dwarf2_read_addr_index): Update.
2522         (read_signatured_type): Update.
2523
2524 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2525
2526         * dwarf2/read.h (struct dwarf2_per_cu_data) <m_header,
2527         m_header_read_in>: New fields.
2528         <get_header>: New method.
2529         * dwarf2/read.c (per_cu_header_read_in): Remove.
2530         (dwarf2_per_cu_data::get_header): New.
2531         (dwarf2_per_cu_data::addr_size): Update.
2532         (dwarf2_per_cu_data::offset_size): Update.
2533         (dwarf2_per_cu_data::ref_addr_size): Update.
2534
2535 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2536
2537         * dwarf2/read.c (load_cu): Return dwarf2_cu.
2538         (dw2_do_instantiate_symtab): Update.
2539         (queue_and_load_all_dwo_tus): Change parameter from
2540         dwarf2_per_cu_data to dwarf2_cu.
2541         (dwarf2_fetch_die_loc_sect_off): Update.
2542         (dwarf2_fetch_constant_bytes): Update.
2543         (dwarf2_fetch_die_type_sect_off): Update.
2544
2545 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2546
2547         * dwarf2/read.c (process_full_comp_unit,
2548         process_full_type_unit): Remove per_cu, per_objfile paramters.
2549         Add dwarf2_cu parameter.
2550         (process_queue): Update.
2551
2552 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2553
2554         * dwarf2/read.c (create_cu_from_index_list): Replace
2555         dwarf2_per_objfile parameter with dwarf2_per_bfd.
2556         (create_cus_from_index_list): Likewise.
2557         (create_cus_from_index): Likewise.
2558         (create_signatured_type_table_from_index): Likewise.
2559         (create_cus_from_debug_names_list): Likewise.
2560         (create_cus_from_debug_names): Likewise.
2561         (dwarf2_read_gdb_index): Update.
2562         (dwarf2_read_debug_names): Update.
2563
2564 2020-05-27  Tom Tromey  <tom@tromey.com>
2565             Simon Marchi  <simon.marchi@efficios.com>
2566
2567         * dwarf2/read.h (struct dwarf2_per_objfile)
2568         <get_type_for_signatured_type, set_type_for_signatured_type>:
2569         New methods.
2570         <m_type_map>: New member.
2571         (struct signatured_type) <type>: Remove.
2572         * dwarf2/read.c
2573         (dwarf2_per_objfile::get_type_for_signatured_type,
2574         dwarf2_per_objfile::set_type_for_signatured_type): New.
2575         (get_signatured_type): Use new methods.
2576
2577 2020-05-27  Tom Tromey  <tom@tromey.com>
2578             Simon Marchi  <simon.marchi@efficios.com>
2579
2580         * dwarf2/read.h (struct type_unit_group_unshareable): New.
2581         (struct dwarf2_per_objfile) <type_units>: New member.
2582         <get_type_unit_group_unshareable>: New method.
2583         * dwarf2/read.c (struct type_unit_group) <compunit_symtab,
2584         num_symtabs, symtabs>: Remove; move to
2585         type_unit_group_unshareable.
2586         (dwarf2_per_objfile::get_type_unit_group_unshareable): New.
2587         (process_full_type_unit, dwarf2_cu::setup_type_unit_groups)
2588         (dwarf2_cu::setup_type_unit_groups): Use type_unit_group_unshareable.
2589
2590 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2591
2592         * dwarf2/read.h (struct dwarf2_per_cu_data):
2593         <dwarf2_per_objfile>: Remove.
2594         * dwarf2/read.c (create_cu_from_index_list): Don't assign
2595         dwarf2_per_objfile.
2596         (create_signatured_type_table_from_index): Likewise.
2597         (create_signatured_type_table_from_debug_names): Likewise.
2598         (create_debug_type_hash_table): Likewise.
2599         (fill_in_sig_entry_from_dwo_entry): Likewise.
2600         (create_type_unit_group): Likewise.
2601         (read_comp_units_from_section): Likewise.
2602         (create_cus_hash_table): Likewise.
2603
2604 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2605
2606         * dwarf2/read.c (process_psymtab_comp_unit): Remove reference to
2607         dwarf2_per_cu_data::dwarf2_per_objfile.
2608         (compute_compunit_symtab_includes): Likewise.
2609         (dwarf2_cu::start_symtab): Likewise.
2610
2611 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2612
2613         * dwarf2/read.h (dwarf2_get_die_type): Add dwarf2_per_objfile
2614         parameter.
2615         * dwarf2/read.c (get_die_type_at_offset): Likewise.
2616         (read_namespace_alias): Update.
2617         (lookup_die_type): Update.
2618         (dwarf2_get_die_type): Add dwarf2_per_objfile parameter.
2619         * dwarf2/loc.c (class dwarf_evaluate_loc_desc) <get_base_type>:
2620         Update.
2621         (disassemble_dwarf_expression): Update.
2622
2623 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2624
2625         * dwarf2/read.h (struct dwarf2_queue_item): Add
2626         dwarf2_per_objfile parameter, assign new parameter.
2627         <per_objfile>: New field.
2628         * dwarf2/read.c (free_one_cached_comp_unit): Add
2629         dwarf2_per_objfile parameter.
2630         (queue_comp_unit): Likewise.
2631         (dw2_do_instantiate_symtab): Update.
2632         (process_psymtab_comp_unit): Update.
2633         (maybe_queue_comp_unit): Add dwarf2_per_objfile parameter.
2634         (process_imported_unit_die): Update.
2635         (queue_and_load_dwo_tu): Update.
2636         (follow_die_offset): Update.
2637         (follow_die_sig_1): Update.
2638
2639 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2640
2641         * dwarf2/read.h (struct dwarf2_per_cu_data) <objfile>: Remove.
2642         * dwarf2/read.c (dwarf2_compute_name): Pass per_objfile down.
2643         (read_call_site_scope): Assign per_objfile.
2644         (dwarf2_per_cu_data::objfile): Remove.
2645         * gdbtypes.h (struct call_site) <per_objfile>: New member.
2646         * dwarf2/loc.h (dwarf2_evaluate_loc_desc): Add
2647         dwarf2_per_objfile parameter.
2648         * dwarf2/loc.c (dwarf2_evaluate_loc_desc_full): Add
2649         dwarf2_per_objfile parameter.
2650         (dwarf_expr_reg_to_entry_parameter): Add output
2651         dwarf2_per_objfile parameter.
2652         (locexpr_get_frame_base): Update.
2653         (class dwarf_evaluate_loc_desc) <get_tls_address>: Update.
2654         <push_dwarf_reg_entry_value>: Update.
2655         <call_site_to_target_addr>: Update.
2656         (dwarf_entry_parameter_to_value): Add dwarf2_per_objfile
2657         parameter.
2658         (value_of_dwarf_reg_entry): Update.
2659         (rw_pieced_value): Update.
2660         (indirect_synthetic_pointer): Update.
2661         (dwarf2_evaluate_property): Update.
2662         (dwarf2_loc_desc_get_symbol_read_needs): Add dwarf2_per_objfile
2663         parameter.
2664         (locexpr_read_variable): Update.
2665         (locexpr_get_symbol_read_needs): Update.
2666         (loclist_read_variable): Update.
2667
2668 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2669
2670         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
2671         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2672         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2673         parameter.
2674         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
2675         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
2676         dwarf2_fetch_die_type_sect_off): Add dwarf2_per_objfile
2677         parameter.
2678         * dwarf2/loc.c (indirect_synthetic_pointer, per_cu_dwarf_call,
2679         sect_variable_value): Add dwarf2_per_objfile parameter.
2680         (class dwarf_evaluate_loc_desc) <dwarf_call,
2681         dwarf_variable_value>: Update.
2682         (fetch_const_value_from_synthetic_pointer): Add
2683         dwarf2_per_objfile parameter.
2684         (fetch_const_value_from_synthetic_pointer): Update.
2685         (coerced_pieced_ref): Update.
2686         (class symbol_needs_eval_context) <dwarf_call,
2687         dwarf_variable_value>: Update.
2688         (dwarf2_compile_expr_to_ax): Update.
2689
2690 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2691
2692         * dwarf2/loc.c (allocate_piece_closure): Add dwarf2_per_objfile
2693         parameter.
2694         (dwarf2_evaluate_loc_desc_full): Update.
2695
2696 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2697
2698         * dwarf2/read.h (dwarf2_read_addr_index): Add dwarf2_per_objfile
2699         parameter.
2700         * dwarf2/read.c (dwarf2_read_addr_index): Likewise.
2701         * dwarf2/loc.c (decode_debug_loclists_addresses): Add
2702         dwarf2_per_objfile parameter.
2703         (decode_debug_loc_dwo_addresses): Likewise.
2704         (dwarf2_find_location_expression): Update.
2705         (class dwarf_evaluate_loc_desc) <get_addr_index>: Update.
2706         (locexpr_describe_location_piece): Add dwarf2_per_objfile
2707         parameter.
2708         (disassemble_dwarf_expression): Add dwarf2_per_objfile
2709         parameter.
2710         (locexpr_describe_location_1): Likewise.
2711         (locexpr_describe_location): Update.
2712
2713 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2714
2715         * dwarf2/read.h (struct dwarf2_per_cu_data) <text_offset>:
2716         Remove.
2717         * dwarf2/read.c (dwarf2_per_cu_data::text_offset): Remove.
2718         * dwarf2/loc.c (dwarf2_find_location_expression): Update.
2719         (dwarf2_compile_property_to_c): Update.
2720         (dwarf2_compile_expr_to_ax): Add dwarf2_per_objfile parameter,
2721         use text offset from objfile.
2722         (locexpr_tracepoint_var_ref): Update.
2723         (locexpr_generate_c_location): Update.
2724         (loclist_describe_location): Update.
2725         (loclist_tracepoint_var_ref): Update.
2726         * dwarf2/compile.h (compile_dwarf_bounds_to_c): Add
2727         dwarf2_per_objfile parameter.
2728         * dwarf2/loc2c.c (do_compile_dwarf_expr_to_c): Likewise,
2729         use text offset from objfile.
2730         (compile_dwarf_expr_to_c): Add dwarf2_per_objfile parameter.
2731
2732 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2733
2734         * dwarf2/expr.h (struct dwarf_expr_context)
2735         <dwarf_expr_context>: Add dwarf2_per_objfile parameter.
2736         <offset>: Remove.
2737         <per_objfile>: New member.
2738         * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): Add
2739         dwarf2_per_objfile parameter.  Don't set offset, set
2740         per_objfile.
2741         (dwarf_expr_context::execute_stack_op): Use offset from objfile.
2742         * dwarf2/frame.c (dwarf2_frame_find_fde): Return (by parameter)
2743         a dwarf2_per_objfile object instead of an offset.
2744         (class dwarf_expr_executor) <dwarf_expr_executor>: Add
2745         constructor.
2746         (execute_stack_op): Add dwarf2_per_objfile parameter, pass it
2747         to dwarf2_expr_executor constructor.  Don't set offset.
2748         (dwarf2_fetch_cfa_info): Update.
2749         (struct dwarf2_frame_cache) <text_offset>: Remove.
2750         <per_objfile>: New field.
2751         (dwarf2_frame_cache): Update.
2752         (dwarf2_frame_prev_register): Update.
2753         * dwarf2/loc.c (class dwarf_evaluate_loc_desc)
2754         <dwarf_evaluate_loc_desc>: Add constructor.
2755         (dwarf2_evaluate_loc_desc_full): Update.
2756         (dwarf2_locexpr_baton_eval): Update.
2757         (class symbol_needs_eval_context) <symbol_needs_eval_context>:
2758         Add constructor.
2759         (dwarf2_loc_desc_get_symbol_read_needs): Update.
2760
2761 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2762
2763         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_type,
2764         addr_sized_int_type>: Move to dwarf2_cu.
2765         <int_type>: Move to dwarf2_per_objfile.
2766         (struct dwarf2_per_objfile) <int_type>: Move here.
2767         * dwarf2/read.c (struct dwarf2_cu) <addr_type,
2768         addr_sized_int_type>: Move here.
2769         (read_func_scope): Update.
2770         (read_array_type): Update.
2771         (read_tag_string_type): Update.
2772         (attr_to_dynamic_prop): Update.
2773         (dwarf2_per_cu_data::int_type): Rename to...
2774         (dwarf2_per_objfile::int_type): ... this.
2775         (dwarf2_per_cu_data::addr_sized_int_type): Rename to...
2776         (dwarf2_cu::addr_sized_int_type): ... this.
2777         (read_subrange_type): Update.
2778         (dwarf2_per_cu_data::addr_type): Rename to...
2779         (dwarf2_cu::addr_type): ... this.
2780         (set_die_type): Update.
2781
2782 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2783
2784         * dwarf2/read.c (queue_and_load_all_dwo_tus): Access per_objfile
2785         data through per_cu->cu.
2786
2787 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2788
2789         * dwarf2/read.c (lookup_dwo_comp_unit): Change
2790         dwarf2_per_cu_data parameter fo dwarf2_cu.
2791         (lookup_dwo_type_unit): Likewise.
2792         (read_cutu_die_from_dwo): Likewise.
2793         (lookup_dwo_unit): Likewise.
2794         (open_and_init_dwo_file): Likewise.
2795         (lookup_dwo_cutu): Likewise.
2796         (lookup_dwo_comp_unit): Likewise.
2797         (lookup_dwo_type_unit): Likewise.
2798         (cutu_reader::init_tu_and_read_dwo_dies): Update.
2799         (cutu_reader::cutu_reader): Update.
2800
2801 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2802
2803         * dwarf2/read.c (process_full_comp_unit): Add dwarf2_per_objfile
2804         parameter.
2805         (process_full_type_unit): Likewise.
2806         (process_queue): Update.
2807
2808 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2809
2810         * dwarf2/read.c (recursively_compute_inclusions): Add
2811         dwarf2_per_objfile parameter.
2812         (compute_compunit_symtab_includes): Likewise.
2813         (process_cu_includes): Update.
2814
2815 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2816
2817         * dwarf2/read.c (create_partial_symtab): Add dwarf2_per_objfile
2818         parameter.
2819         (create_type_unit_group): Update.
2820         (process_psymtab_comp_unit_reader): Update.
2821         (build_type_psymtabs_reader): Update.
2822
2823 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2824
2825         * dwarf2/read.c (cutu_reader::keep): Access dwarf2_per_objfile
2826         object through m_this_cu->cu.
2827
2828 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2829
2830         * dwarf2/read.c (queue_and_load_dwo_tu): Expect a dwarf2_cu as
2831         the info parameter.
2832         (queue_and_load_all_dwo_tus): Pass per_cu->cu.
2833
2834 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2835
2836         * dwarf2/read.c (class cutu_reader) <cutu_reader>: Add
2837         per_objfile parameter.
2838         (load_full_type_unit): Add per_objfile parameter.
2839         (read_signatured_type): Likewise.
2840         (load_full_comp_unit): Likewise.
2841         (load_cu): Likewise.
2842         (dw2_do_instantiate_symtab): Likewise.
2843         (dw2_get_file_names): Likewise.
2844         (dw2_map_symtabs_matching_filename): Update.
2845         (dw_expand_symtabs_matching_file_matcher): Update.
2846         (dw2_map_symbol_filenames): Update.
2847         (process_psymtab_comp_unit): Add per_objfile parameter.
2848         (build_type_psymtabs_1): Update.
2849         (process_skeletonless_type_unit): Update.
2850         (dwarf2_build_psymtabs_hard): Update.
2851         (load_partial_comp_unit): Add per_objfile parameter.
2852         (scan_partial_symbols): Update.
2853         (load_full_comp_unit): Add per_objfile parameter.
2854         (process_imported_unit_die): Update.
2855         (create_cus_hash_table): Update.
2856         (find_partial_die): Update.
2857         (dwarf2_read_addr_index): Update.
2858         (follow_die_offset): Update.
2859         (dwarf2_fetch_die_loc_sect_off): Update.
2860         (dwarf2_fetch_constant_bytes): Update.
2861         (dwarf2_fetch_die_type_sect_off): Update.
2862         (follow_die_sig_1): Update.
2863         (load_full_type_unit): Add per_objfile parameter.
2864         (read_signatured_type): Likewise.
2865
2866 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2867
2868         * dwarf2/read.c (lookup_dwo_unit): Use bfd_get_filename instead
2869         of objfile_name.
2870
2871 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2872
2873         * dwarf2/read.h (struct dwarf2_per_bfd) <obfd>: New member.
2874         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2875         * dwarf2/read.c (dwarf2_per_bfd::dwarf2_per_bfd): Assign obfd
2876         field.
2877         (dwarf2_get_dwz_file): Replace parameter with dwarf2_per_bfd.
2878         (create_cus_from_index): Update.
2879         (dwarf2_read_gdb_index): Update.
2880         (create_cus_from_debug_names): Update.
2881         (dwarf2_read_debug_names): Update.
2882         (get_abbrev_section_for_cu): Update.
2883         (create_all_comp_units): Update.
2884         (read_attribute_value): Update.
2885         (get_debug_line_section): Update.
2886         * dwarf2/index-cache.c (index_cache::store): Update.
2887         * dwarf2/index-write.c (save_gdb_index_command): Update.
2888         * dwarf2/macro.c (dwarf_decode_macro_bytes): Update.
2889
2890 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2891
2892         * dwarf2/read.h (struct dwarf2_per_cu_data) <per_bfd>: New
2893         member.
2894         * dwarf2/read.c (dwarf2_per_bfd::allocate_per_cu): Initialize
2895         dwarf2_per_cu_data::per_bfd.
2896         (dwarf2_per_bfd::allocate_signatured_type): Likewise.
2897         (create_type_unit_group): Likewise.
2898         (queue_comp_unit): Remove reference to
2899         per_cu->dwarf2_per_objfile.
2900         (maybe_queue_comp_unit): Likewise.
2901         (fill_in_sig_entry_from_dwo_entry): Assign new field.
2902         (create_cus_hash_table): Assign new field.
2903
2904 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2905
2906         * dwarf2/read.c: Replace
2907         dwarf2_cu->per_cu->dwarf2_per_objfile references with
2908         dwarf2_cu->per_objfile throughout.
2909
2910 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2911
2912         * dwarf2/read.c (dw2_do_instantiate_symtab): Add per_objfile
2913         parameter, don't use per_cu->dwarf2_per_objfile.
2914         (dw2_instantiate_symtab): Likewise.
2915         (dw2_find_last_source_symtab): Update.
2916         (dw2_map_expand_apply): Update.
2917         (dw2_lookup_symbol): Update.
2918         (dw2_expand_symtabs_for_function): Update.
2919         (dw2_expand_all_symtabs): Update.
2920         (dw2_expand_symtabs_with_fullname): Update.
2921         (dw2_expand_symtabs_matching_one): Add per_objfile parameter,
2922         don't use per_cu->dwarf2_per_objfile.
2923         (dw2_expand_marked_cus): Update.
2924         (dw2_find_pc_sect_compunit_symtab): Update.
2925         (dw2_debug_names_lookup_symbol): Update.
2926         (dw2_debug_names_expand_symtabs_for_function): Update.
2927         (dw2_debug_names_map_matching_symbols): Update.
2928         (dwarf2_psymtab::expand_psymtab): Update.
2929
2930 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2931
2932         * dwarf2/read.c (struct dwarf2_cu) <dwarf2_cu>: Add parameter.
2933         <per_objfile>: New member.
2934         (class cutu_reader) <init_tu_and_read_dwo_dies>: Add parameter.
2935         (cutu_reader::init_tu_and_read_dwo_dies): Add parameter, update
2936         call to dwarf2_cu.
2937         (cutu_reader::cutu_reader): Update.
2938         (dwarf2_cu::dwarf2_cu): Add parameter, initialize per_objfile.
2939
2940 2020-05-27  Simon Marchi  <simon.marchi@efficios.com>
2941
2942         * dwarf2/read.h (struct dwarf2_per_bfd) <die_type_hash>: Move to
2943         struct dwarf2_per_objfile.
2944         (struct dwarf2_per_objfile) <die_type_hash>: Move from struct
2945         dwarf2_per_bfd.
2946         * dwarf2/read.c (set_die_type): Update.
2947         (get_die_type_at_offset): Update.
2948
2949 2020-05-27  Tom Tromey  <tom@tromey.com>
2950             Simon Marchi  <simon.marchi@efficios.com>
2951
2952         * dwarf2/read.h (struct dwarf2_per_bfd) <num_psymtabs>: New
2953         method.
2954         (struct dwarf2_per_objfile) <resize_symtabs, symtab_set_p,
2955         get_symtab, set_symtab>: New methods.
2956         <m_symtabs>: New field.
2957         (struct dwarf2_psymtab): Derive from partial_symtab.
2958         <readin_p, get_compunit_symtab>: Declare methods.
2959         * dwarf2/read.c (dwarf2_per_objfile::symtab_set_p,
2960         dwarf2_per_objfile::get_symtab, dwarf2_per_objfile::set_symtab):
2961         New methods.
2962         (struct dwarf2_per_cu_quick_data) <compunit_symtab>: Remove.
2963         (dw2_do_instantiate_symtab, dw2_instantiate_symtab)
2964         (dw2_map_expand_apply, dw2_map_symtabs_matching_filename)
2965         (dw2_symtab_iter_next, dw2_print_stats)
2966         (dw2_expand_symtabs_with_fullname)
2967         (dw2_expand_symtabs_matching_one)
2968         (dw_expand_symtabs_matching_file_matcher)
2969         (dw2_find_pc_sect_compunit_symtab, dw2_map_symbol_filenames)
2970         (dw2_debug_names_iterator::next)
2971         (dw2_debug_names_map_matching_symbols)
2972         (fill_in_sig_entry_from_dwo_entry, dwarf2_psymtab::read_symtab)
2973         (process_queue, dwarf2_psymtab::expand_psymtab): Update.
2974         (dwarf2_psymtab::readin_p, dwarf2_psymtab::get_compunit_symtab):
2975         New methods.
2976         (get_compunit_symtab, process_full_comp_unit)
2977         (process_full_type_unit): Update.
2978         (dwarf2_build_psymtabs, dwarf2_initialize_objfile, add_type_unit): Call
2979
2980 2020-05-27  Simon Marchi  <simon.marchi@polymtl.ca>
2981
2982         * dwarf2/read.h (dwarf2_per_objfile): Rename to dwarf2_per_bfd,
2983         then introduce a new dwarf2_per_objfile type.
2984         <read_line_string>: Move to the new dwarf2_per_objfile type.
2985         <objfile>: Likewise.
2986         (dwarf2_per_bfd): Rename dwarf2_per_objfile to this.
2987         * dwarf2/read.c: Replace references to dwarf2_per_objfile with
2988         dwarf2_per_objfile->per_bfd.
2989         (dwarf2_per_objfile::dwarf2_per_objfile): Rename to...
2990         (dwarf2_per_bfd::dwarf2_per_bfd): ... this.
2991         (dwarf2_per_objfile::free_cached_comp_units): Rename to...
2992         (dwarf2_per_bfd::free_cached_comp_units): ... this.
2993         (dwarf2_has_info): Allocate dwarf2_per_bfd.
2994         (dwarf2_per_objfile::locate_sections): Rename to...
2995         (dwarf2_per_bfd::locate_sections): ... this.
2996         (dwarf2_per_objfile::get_cutu): Rename to...
2997         (dwarf2_per_bfd::get_cutu): ... this.
2998         (dwarf2_per_objfile::get_cu): Rename to...
2999         (dwarf2_per_bfd::get_cu): ... this.
3000         (dwarf2_per_objfile::get_tu): Rename to...
3001         (dwarf2_per_bfd::get_tu): ... this.
3002         (dwarf2_per_objfile::allocate_per_cu): Rename to...
3003         (dwarf2_per_bfd::allocate_per_cu): ... this.
3004         (dwarf2_per_objfile::allocate_signatured_type): Rename to...
3005         (dwarf2_per_bfd::allocate_signatured_type): ... this.
3006         (get_gdb_index_contents_ftype): Change parameter from
3007         dwarf2_per_objfile to dwarf2_per_bfd.
3008         * dwarf2/macro.c, dwarf2/index-write.c: Replace references to
3009         dwarf2_per_objfile with dwarf2_per_objfile->per_bfd.
3010
3011 2020-05-27  Tom Tromey  <tom@tromey.com>
3012             Simon Marchi  <simon.marchi@efficios.com>
3013
3014         * dwarf2/loc.c (struct piece_closure) <per_objfile>: New member.
3015         (allocate_piece_closure): Set "per_objfile" member.
3016         (dwarf2_find_location_expression, dwarf2_locexpr_baton_eval)
3017         (locexpr_describe_location, loclist_describe_location): Use new
3018         member.
3019         * dwarf2/read.c (read_call_site_scope)
3020         (mark_common_block_symbol_computed, attr_to_dynamic_prop)
3021         (dwarf2_const_value_attr, dwarf2_fetch_die_loc_sect_off)
3022         (fill_in_loclist_baton, dwarf2_symbol_mark_computed,
3023         handle_data_member_location): Set per_objfile member.
3024         * dwarf2/loc.h (struct dwarf2_locexpr_baton) <per_objfile>: New
3025         member.
3026         (struct dwarf2_loclist_baton) <per_objfile>: New member.
3027
3028 2020-05-27  Tom Tromey  <tom@tromey.com>
3029
3030         * dwarf2/read.h (struct dwarf2_per_objfile) <allocate_per_cu,
3031         allocate_signatured_type>: Declare new methods.
3032         <m_num_psymtabs>: New member.
3033         (struct dwarf2_per_cu_data) <index>: New member.
3034         * dwarf2/read.c (dwarf2_per_objfile::allocate_per_cu)
3035         (dwarf2_per_objfile::allocate_signatured_type): New methods.
3036         (create_cu_from_index_list): Use allocate_per_cu.
3037         (create_signatured_type_table_from_index)
3038         (create_signatured_type_table_from_debug_names)
3039         (create_debug_type_hash_table, add_type_unit)
3040         (read_comp_units_from_section): Use allocate_signatured_type.
3041
3042 2020-05-27  Tom Tromey  <tom@tromey.com>
3043
3044         * psymtab.c (partial_map_expand_apply)
3045         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
3046         (psym_lookup_global_symbol_language)
3047         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
3048         (psym_print_stats, psym_expand_symtabs_for_function)
3049         (psym_map_symbol_filenames, psym_map_matching_symbols)
3050         (psym_expand_symtabs_matching)
3051         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
3052         (maintenance_check_psymtabs): Update.
3053         * psympriv.h (struct partial_symtab) <readin_p,
3054         get_compunit_symtab>: Add objfile parameter.
3055         (struct standard_psymtab) <readin_p, get_compunit_symtab>:
3056         Likewise.
3057         * dwarf2/read.c (struct dwarf2_include_psymtab) <readin_p,
3058         get_compunit_symtab>: Likewise.
3059         (dwarf2_psymtab::expand_psymtab): Pass objfile argument.
3060
3061 2020-05-27  Tom Tromey  <tom@tromey.com>
3062
3063         * dwarf2/read.h (struct dwarf2_per_objfile) <obstack>: New
3064         member.
3065         * dwarf2/read.c (delete_file_name_entry): Fix comment.
3066         (create_cu_from_index_list)
3067         (create_signatured_type_table_from_index)
3068         (create_signatured_type_table_from_debug_names)
3069         (dw2_get_file_names_reader, dwarf2_initialize_objfile)
3070         (dwarf2_create_include_psymtab)
3071         (create_debug_type_hash_table, add_type_unit)
3072         (create_type_unit_group, read_comp_units_from_section)
3073         (dwarf2_compute_name, create_cus_hash_table)
3074         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
3075         (create_dwo_unit_in_dwp_v2, open_and_init_dwp_file): Use new
3076         obstack.
3077         (dw2_get_real_path): Likewise.  Change argument to
3078         dwarf2_per_objfile.
3079
3080 2020-05-27  Luis Machado  <luis.machado@linaro.org>
3081
3082         PR tdep/26000
3083         * arm-tdep.c (thumb_analyze_prologue): Fix instruction matching
3084         for ldrd (immediate).
3085
3086 2020-05-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3087
3088         * command.h: Add comment giving the name of class_tui.
3089         * cli/cli-cmds.c (_initialize_cli_cmds): If TUI defined,
3090         create the fake command for the help for class_tui.
3091
3092 2020-05-26  Tom Tromey  <tromey@adacore.com>
3093
3094         * ada-lang.c (ada_print_array_index): Change type.  Call val_atr.
3095         (ada_value_ptr_subscript): Don't call pos_atr on the lower bound.
3096         (val_atr): New function.
3097         (value_val_atr): Use it.
3098         * ada-valprint.c (print_optional_low_bound): Change low bound
3099         handling for enums.
3100         (val_print_packed_array_elements): Don't call discrete_position.
3101         * gdbtypes.c (get_discrete_bounds) <TYPE_CODE_RANGE>: Call
3102         discrete_position for enum types.
3103         * language.c (default_print_array_index): Change type.
3104         * language.h (struct language_defn) <la_print_array_index>: Add
3105         index_type parameter, change type of index_value.
3106         (LA_PRINT_ARRAY_INDEX): Add index_type parameter.
3107         (default_print_array_index): Update.
3108         * valprint.c (maybe_print_array_index): Don't call
3109         value_from_longest.  Update.
3110         (value_print_array_elements): Don't call discrete_position.
3111
3112 2020-05-26  Tom Tromey  <tromey@adacore.com>
3113
3114         * ada-lang.c (value_val_atr): Handle TYPE_CODE_RANGE.
3115         * gdbtypes.c (discrete_position): Handle TYPE_CODE_RANGE.
3116
3117 2020-05-25  Cristiano De Alti  <cristiano_dealti@hotmail.com>
3118
3119         PR gdb/13519
3120         * avr-tdep.c (avr_integer_to_address): Return data or code
3121         address accordingly to the second 'type' argument of the
3122         function.
3123
3124 2020-05-25  Michael Weghorn  <m.weghorn@posteo.de>
3125
3126         * infcmd.c, inferior.h: (construct_inferior_arguments):
3127         Moved function from here to gdbsupport/common-inferior.{h,cc}
3128
3129 2020-05-23  Tom Tromey  <tom@tromey.com>
3130
3131         Revert commit eca1f90c:
3132         * NEWS: Remove entry for completion styling.
3133         * completer.c (_rl_completion_prefix_display_length): Move
3134         declaration later.
3135         (gdb_fnprint): Revert.
3136         (gdb_display_match_list_1): Likewise.
3137         * cli/cli-style.c (completion_prefix_style)
3138         (completion_difference_style, completion_suffix_style): Remove.
3139         (_initialize_cli_style): Revert.
3140         * cli/cli-style.h (completion_prefix_style)
3141         (completion_difference_style, completion_suffix_style): Don't
3142         declare.
3143
3144 2020-05-24  Pedro Alves  <palves@redhat.com>
3145
3146         * symtab.c (completion_list_add_name): Return boolean indication
3147         of whether the symbol matched.
3148         (completion_list_add_symbol): Don't try to remove C++ aliases if
3149         the symbol didn't match in the first place.
3150         * symtab.h (completion_list_add_name): Return bool.
3151
3152 2020-05-23  Simon Marchi  <simon.marchi@polymtl.ca>
3153
3154         * gdbtypes.h (TYPE_FIELD): Remove.  Replace all uses with
3155         type::field.
3156
3157 2020-05-23  Joel Brobecker  <brobecker@adacore.com>
3158
3159         GDB 9.2 released.
3160
3161 2020-05-23  Tom Tromey  <tom@tromey.com>
3162
3163         * NEWS: Add entry for completion styling.
3164         * completer.c (_rl_completion_prefix_display_length): Move
3165         declaration earlier.
3166         (gdb_fnprint): Use completion_style.
3167         (gdb_display_match_list_1): Likewise.
3168         * cli/cli-style.c (completion_prefix_style)
3169         (completion_difference_style, completion_suffix_style): New
3170         globals.
3171         (_initialize_cli_style): Register new globals.
3172         * cli/cli-style.h (completion_prefix_style)
3173         (completion_difference_style, completion_suffix_style): Declare.
3174
3175 2020-05-23  Pedro Alves  <palves@redhat.com>
3176
3177         * utils.c: Include "gdbsupport/gdb-safe-ctype.h".
3178         (parse_escape): Use ISDIGIT instead of isdigit.
3179         (puts_debug): Use gdb_isprint instead of isprint.
3180         (fprintf_symbol_filtered): Use ISALNUM instead of isalnum.
3181         (cp_skip_operator_token, skip_ws, strncmp_iw_with_mode): Use
3182         ISSPACE instead of isspace.
3183         (strncmp_iw_with_mode): Use TOLOWER instead of tolower and ISSPACE
3184         instead of isspace.
3185         (strcmp_iw_ordered): Use ISSPACE instead of isspace.
3186         (string_to_core_addr): Use TOLOWER instead of tolower, ISXDIGIT
3187         instead of isxdigit and ISDIGIT instead of isdigit.
3188
3189 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3190
3191         * gdbtypes.h (struct type) <field>: New method.
3192         (TYPE_FIELDS): Remove, replace all uses with either type::fields
3193         or type::field.
3194
3195 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3196
3197         * gdbtypes.h (struct type) <fields, set_fields>: New methods.
3198         (TYPE_FIELDS): Use type::fields.  Change all call sites that
3199         modify the propery to use type::set_fields instead.
3200
3201 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3202
3203         * gdbtypes.h (TYPE_NFIELDS): Remove.  Change all cal sites to use
3204         type::num_fields instead.
3205
3206 2020-05-22  Simon Marchi  <simon.marchi@efficios.com>
3207
3208         * gdbtypes.h (struct type) <num_fields, set_num_fields>: New
3209         methods.
3210         (TYPE_NFIELDS): Use type::num_fields.  Change all call sites
3211         that modify the number of fields to use type::set_num_fields
3212         instead.
3213
3214 2020-05-22  Tom Tromey  <tromey@adacore.com>
3215
3216         * compile/compile-object-load.h (munmap_list_free): Don't
3217         declare.
3218
3219 2020-05-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3220
3221         * annotate.c (annotate_source_line): Update return type, add call
3222         to update current symtab and line.
3223         * annotate.h (annotate_source_line): Update return type, and
3224         extend header comment.
3225         * source.c (info_line_command): Check annotation_level before
3226         calling annotate_source_line.
3227         * stack.c (print_frame_info): If calling annotate_source_line
3228         returns true, then don't print any other source line information.
3229
3230 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3231
3232         * lm32-tdep.c (lm32_register_reggroup_p): Fix condition.
3233
3234 2020-05-21  Simon Marchi  <simon.marchi@efficios.com>
3235
3236         * coffread.c (patch_type): Remove NULL check before xfree.
3237         * corefile.c (set_gnutarget): Likewise.
3238         * cp-abi.c (set_cp_abi_as_auto_default): Likewise.
3239         * exec.c (build_section_table): Likewise.
3240         * remote.c (remote_target::pass_signals): Likewise.
3241         * utils.c (n_spaces): Likewise.
3242         * cli/cli-script.c (document_command): Likewise.
3243         * i386-windows-tdep.c (core_process_module_section): Likewise.
3244         * linux-fork.c (struct fork_info) <~fork_info>: Likewise.
3245
3246 2020-05-20  Simon Marchi  <simon.marchi@efficios.com>
3247
3248         * symfile.c (reread_symbols): Clear objfile's section_offsets
3249         vector and section indices, re-compute them by calling
3250         sym_offsets.
3251
3252 2020-05-20  Tom Tromey  <tromey@adacore.com>
3253
3254         * ada-lang.c (bound_name, MAX_ADA_DIMENS): Remove.
3255         (desc_one_bound, desc_index_type): Compute field name.
3256
3257 2020-05-20  Tom de Vries  <tdevries@suse.de>
3258
3259         PR symtab/25833
3260         * dwarf2/read.c (dw2_map_matching_symbols): Handle .gdb_index.
3261
3262 2020-05-20  Alan Modra  <amodra@gmail.com>
3263
3264         PR 25993
3265         * solib-darwin.c (darwin_bfd_open): Don't strdup pathname for
3266         bfd_set_filename.
3267         * solib-aix.c (solib_aix_bfd_open): Use std::string for name
3268         passed to bfd_set_filename.
3269         * symfile-mem.c (add_vsyscall_page): Likewise for string
3270         passed to symbol_file_add_from_memory.
3271         (symbol_file_add_from_memory): Make name param a const char* and
3272         don't strdup.
3273
3274 2020-05-20  Alan Modra  <amodra@gmail.com>
3275
3276         * coff-pe-read.c (read_pe_exported_syms): Use bfd_get_filename
3277         rather than accessing bfd->filename directly.
3278         * dtrace-probe.c (dtrace_static_probe_ops::get_probes): Likewise,
3279         and use bfd_section_name.
3280         * dwarf2/frame.c (decode_frame_entry): Likewise.
3281         * exec.c (exec_set_section_address): Likewise.
3282         * solib-aix.c (solib_aix_bfd_open): Likewise.
3283         * stap-probe.c (get_stap_base_address): Likewise.
3284         * symfile.c (reread_symbols): Likewise.
3285
3286 2020-05-19  Tom Tromey  <tromey@adacore.com>
3287
3288         * sparc64-tdep.c (adi_tag_fd): Update call to target_fileio_open.
3289
3290 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3291
3292         * dwarf2/read.c (quirk_rust_enum): Allocate enough fields.
3293
3294 2020-05-19  Pedro Alves  <palves@redhat.com>
3295
3296         * NEWS (set exec-file-mismatch): Adjust entry.
3297         * exec.c: Include "build-id.h".
3298         (validate_exec_file): Try to match build IDs instead of filenames.
3299         * gdb_bfd.c (struct gdb_bfd_open_closure): New.
3300         (gdb_bfd_iovec_fileio_open): Adjust to use gdb_bfd_open_closure
3301         and pass down 'warn_if_slow'.
3302         (gdb_bfd_open): Add 'warn_if_slow' parameter.  Use
3303         gdb_bfd_open_closure to pass it down.
3304         * gdb_bfd.h (gdb_bfd_open): Add 'warn_if_slow' parameter.
3305
3306 2020-05-19  Pedro Alves  <palves@redhat.com>
3307
3308         * gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
3309         * target.c (target_fileio_open_1): Rename to target_fileio_open
3310         and make extern.  Use bool.
3311         (target_fileio_open, target_fileio_open_warn_if_slow): Delete.
3312         (target_fileio_read_alloc_1): Adjust.
3313         * target.h (target_fileio_open): Add 'warn_if_slow' parameter.
3314         (target_fileio_open_warn_if_slow): Delete declaration.
3315
3316 2020-05-19  Pedro Alves  <palves@redhat.com>
3317
3318         * gdb_bfd.h: (gdb_bfd_open): Default to 'fd' parameter to -1.
3319         Adjust all callers.
3320
3321 2020-05-19  Yoshinori Sato  <ysato@users.sourceforge.jp>
3322
3323         * h8300-tdep.c (h8300_is_argument_spill): Change how we check
3324         whether disp is negative.
3325
3326 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3327
3328         * symfile.h (struct symfile_segment_data)
3329         <~symfile_segment_data>: Remove.
3330         <segment_info>: Change to std::vector.
3331         * symfile.c (default_symfile_segments): Update.
3332         * elfread.c (elf_symfile_segments): Update.
3333
3334 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3335
3336         * symfile.h (struct symfile_segment_data) <struct segment>: New.
3337         <segments>: New.
3338         <segment_bases, segment_sizes>: Remove.
3339         * symfile.c (default_symfile_segments): Update.
3340         * elfread.c (elf_symfile_segments): Update.
3341         * remote.c (remote_target::get_offsets): Update.
3342         * solib-target.c (solib_target_relocate_section_addresses):
3343         Update.
3344
3345 2020-05-19  Simon Marchi  <simon.marchi@efficios.com>
3346
3347         * symfile.h (struct symfile_segment_data): Initialize fields.
3348         <~symfile_segment_data>: Add.
3349         (symfile_segment_data_up): New.
3350         (struct sym_fns) <sym_segments>: Return a
3351         symfile_segment_data_up.
3352         (default_symfile_segments): Return a symfile_segment_data_up.
3353         (free_symfile_segment_data): Remove.
3354         (get_symfile_segment_data): Return a symfile_segment_data_up.
3355         * symfile.c (default_symfile_segments): Likewise.
3356         (get_symfile_segment_data): Likewise.
3357         (free_symfile_segment_data): Remove.
3358         (symfile_find_segment_sections): Update.
3359         * elfread.c (elf_symfile_segments): Return a
3360         symfile_segment_data_up.
3361         * remote.c (remote_target::get_offsets): Update.
3362         * solib-target.c (solib_target_relocate_section_addresses):
3363         Update.
3364         * symfile-debug.c (debug_sym_segments): Return a
3365         symfile_segment_data_up.
3366
3367 2020-05-18  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3368
3369         PR build/25981
3370         * i386-sol2-nat.c [PR_MODEL_NATIVE != PR_MODEL_LP64] (regmap):
3371         Hardcode register numbers.
3372
3373         PR build/25981
3374         * procfs.c [(__i386__ || __x86_64__) && sun] (proc_get_LDT_entry,
3375         procfs_find_LDT_entry): Remove.
3376         * procfs.h [(__i386__ || __x86_64__) && sun] (struct ssd,
3377         procfs_find_LDT_entry): Remove.
3378         * sol-thread.c [(__i386__ || __x86_64__) && sun] (ps_lgetLDT):
3379         Remove.
3380
3381 2020-05-17  Pedro Alves  <palves@redhat.com>
3382             Andrew Burgess  <andrew.burgess@embecosm.com>
3383             Keno Fischer  <keno@juliacomputing.com>
3384
3385         PR gdb/25741
3386         * breakpoint.c (build_target_condition_list): Update comments.
3387         (build_target_command_list): Update comments and skip matching
3388         locations.
3389         (insert_bp_location): Move "set breakpoint auto-hw on" handling to
3390         a separate function.  Simplify "set breakpoint auto-hw off"
3391         handling.
3392         (insert_breakpoints): Update comment.
3393         (tracepoint_locations_match): New parameter.  For breakpoints,
3394         compare location types too, if the caller wants to.
3395         (handle_automatic_hardware_breakpoints): New functions.
3396         (bp_location_is_less_than): Also sort by location type and
3397         hardware breakpoint length.
3398         (update_global_location_list): Handle "set breakpoint auto-hw on"
3399         here.
3400         (update_breakpoint_locations): Ask breakpoint_locations_match to
3401         ignore location types.
3402
3403 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3404
3405         * gdbtypes.h (TYPE_NAME): Remove.  Change all cal sites to use
3406         type::name instead.
3407
3408 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3409
3410         * gdbtypes.h (struct type) <name, set_name>: New methods.
3411         (TYPE_CODE): Use type::name.  Change all call sites used to set
3412         the name to use type::set_name instead.
3413
3414 2020-05-16  Tom Tromey  <tom@tromey.com>
3415
3416         * top.c (quit_force): Update.
3417         * infrun.c (handle_no_resumed): Update.
3418         * top.h (all_uis): New function.
3419         (ALL_UIS): Remove.
3420
3421 2020-05-16  Simon Marchi  <simon.marchi@efficios.com>
3422
3423         * mips-linux-tdep.c (mips_linux_in_dynsym_stub): Fix condition.
3424
3425 2020-05-16  Pedro Alves  <palves@redhat.com>
3426
3427         * ia64-linux-nat.c
3428         (ia64_linux_nat_target) <enable_watchpoints_in_psr(ptid_t)>:
3429         Declare method.
3430         (enable_watchpoints_in_psr): Now a method of ia64_linux_nat_target.
3431
3432 2020-05-15  Simon Marchi  <simon.marchi@efficios.com>
3433
3434         * sparc64-tdep.c (adi_stat_t): Remove typedef (leaving struct).
3435         (sparc64_adi_info): Likewise.
3436
3437 2020-05-15  Tom Tromey  <tom@tromey.com>
3438
3439         * symtab.c (lookup_language_this, lookup_symbol_aux): Use
3440         block_objfile.
3441         (lookup_objfile_from_block): Remove.
3442         (lookup_symbol_in_block, lookup_symbol_in_static_block)
3443         (lookup_global_symbol): Use block_objfile.
3444         * symtab.h (lookup_objfile_from_block): Don't declare.
3445         * printcmd.c (clear_dangling_display_expressions): Use
3446         block_objfile.
3447         * parse.c (operator_check_standard): Use block_objfile.
3448
3449 2020-05-15  Tom Tromey  <tom@tromey.com>
3450
3451         * language.c (language_alloc_type_symbol): Set
3452         SYMBOL_SECTION.
3453         * symtab.c (initialize_objfile_symbol): Remove.
3454         (allocate_symbol): Remove.
3455         (allocate_template_symbol): Remove.
3456         * dwarf2/read.c (fixup_go_packaging): Use "new".
3457         (new_symbol): Use "new".
3458         (read_variable): Don't call initialize_objfile_symbol.  Use
3459         "new".
3460         (read_func_scope): Use "new".
3461         * xcoffread.c (process_xcoff_symbol): Don't call
3462         initialize_objfile_symbol.
3463         (SYMBOL_DUP): Remove.
3464         * coffread.c (process_coff_symbol, coff_read_enum_type): Use
3465         "new".
3466         * symtab.h (allocate_symbol, initialize_objfile_symbol)
3467         (allocate_template_symbol): Don't declare.
3468         (struct symbol): Add copy constructor.  Change defaults.
3469         * jit.c (finalize_symtab): Use "new".
3470         * ctfread.c (ctf_add_enum_member_cb, new_symbol, ctf_add_var_cb):
3471         Use "new".
3472         * stabsread.c (patch_block_stabs, define_symbol, read_enum_type)
3473         (common_block_end): Use "new".
3474         * mdebugread.c (parse_symbol): Use "new".
3475         (new_symbol): Likewise.
3476
3477 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3478
3479         * NEWS: Mention changes to help and apropos.
3480
3481 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3482
3483         * command.h (enum command_class): Improve comments, document
3484         that class_alias is for user-defined aliases, give the class
3485         name for each class, remove unused class_xdb.
3486         * cli/cli-decode.c (add_com_alias): Document THECLASS intended usage.
3487         * breakpoint.c (_initialize_breakpoint): Replace class_alias
3488         by a precise class.
3489         * infcmd.c (_initialize_infcmd): Likewise.
3490         * reverse.c (_initialize_reverse): Likewise.
3491         * stack.c (_initialize_stack): Likewise.
3492         * symfile.c (_initialize_symfile): Likewise.
3493         * tracepoint.c (_initialize_tracepoint): Likewise.
3494
3495 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3496
3497         * cli/cli-decode.c (apropos_cmd): Produce output for aliases
3498         when their aliased command is traversed.
3499         (help_cmd): Add fput_command_names_styled call to
3500         output command name and aliases when command has an alias.
3501
3502 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3503
3504         * cli/cli-decode.h (help_cmd_list): Remove declaration.
3505         * cli/cli-decode.c (help_cmd_list): Declare as static,
3506         remove prefix argument, use bool for recurse arg, rework to show the aliases of
3507         a command together with the command.
3508         (fput_command_name_styled, fput_command_names_styled): New functions.
3509         (print_help_for_command): Remove prefix arg, use bool for recurse arg, use
3510         fput_command_name_styled.
3511         (help_list, help_all): Update callers to remove prefix arg and use bool recurse.
3512         * cli/cli-cmds.c (_initialize_cli_cmds): Update alias_command doc.
3513
3514 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3515
3516         * cli/cli-setshow.h (cmd_show_list): Remove prefix argument.
3517         * cli/cli-decode.c (do_show_prefix_cmd): Likewise.
3518         * command.h (cmd_show_list): Likewise.
3519         * dwarf2/index-cache.c (show_index_cache_command): Likewise.
3520         * cli/cli-setshow.c (cmd_show_list): Use the prefix to produce the output.  Skip aliases.
3521
3522 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3523
3524         * unittests/command-def-selftests.c (traverse_command_structure):
3525         Verify all commands of a list have the same prefix command and
3526         that only the top cmdlist commands have a null prefix.
3527
3528 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3529
3530         * cli/cli-decode.c (lookup_cmd_for_prefix): Return the aliased command
3531         as prefix, not one of its aliases.
3532         (set_cmd_prefix): Remove.
3533         (do_add_cmd): Centralize the setting of the prefix of a command, when
3534         command is defined after its full chain of prefix commands.
3535         (add_alias_cmd): Remove call to set_cmd_prefix, as do_add_cmd does it.
3536         (add_setshow_cmd_full): Likewise.
3537         (update_prefix_field_of_prefixed_commands): New function.
3538         (add_prefix_cmd): Replace non working call to set_cmd_prefix by
3539         update_prefix_field_of_prefixed_commands.
3540         * gdb/remote-fileio.c (initialize_remote_fileio): Use the real
3541         addresses of remote_set_cmdlist and remote_show_cmdlist given
3542         as argument, not the address of an argument.
3543         * gdb/remote-fileio.h (initialize_remote_fileio): Likewise.
3544         * gdb/remote.c (_initialize_remote): Likewise.
3545
3546 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3547
3548         * cli/cli-cmds.c (alias_command): Check for an existing alias
3549         using lookup_cmd_composition, as valid_command_p is too strict
3550         and forbids aliases that are the prefix of an existing alias
3551         or command.
3552         * cli/cli-decode.c (lookup_cmd_composition): Ensure a prefix
3553         command is properly recognised as a valid command.
3554
3555 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3556
3557         * unittests/help-doc-selftests.c: Rename to
3558         unittests/command-def-selftests.c
3559         * unittests/command-def-selftests.c (help_doc_tests): Update some
3560         comments.
3561         (command_structure_tests, traverse_command_structure): New namespace
3562         and function.
3563         (command_structure_invariants_tests): New function.
3564         (_initialize_command_def_selftests) Renamed from
3565         _initialize_help_doc_selftests, register command_structure_invariants
3566         selftest.
3567
3568 2020-05-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3569
3570         * cli/cli-cmds.c (_initialize_cli_cmds): Define 'info set' as
3571         an alias of 'show'.
3572
3573 2020-05-15  Joel Brobecker  <brobecker@adacore.com>
3574
3575         * ada-lang.h: (ada_is_gnat_encoded_fixed_point_type): Renames
3576         ada_is_fixed_point_type.  Update all callers.
3577         (gnat_encoded_fixed_point_delta): Renames ada_delta.  Update
3578         all callers.
3579         * ada-lang.c (gnat_encoded_fixed_type_info): Renames fixed_type_info.
3580         Update all callers.
3581         * ada-typeprint.c (print_gnat_encoded_fixed_point_type): Renames
3582         print_fixed_point_type.  Update all callers.
3583         * ada-valprint.c (ada_value_print_num): Replace call to
3584         ada_is_fixed_point_type by ada_is_gnat_encoded_fixed_point_type.
3585
3586 2020-05-14  Kevin Buettner  <kevinb@redhat.com>
3587
3588         * nat/linux-btrace.c (btrace_this_cpu): Add check for AMD
3589         processors.
3590         (cpu_supports_bts): Add CV_AMD case.
3591
3592 2020-05-14  Laurent Morichetti  <Laurent.Morichetti@amd.com>
3593             Simon Marchi  <simon.marchi@efficios.com>
3594
3595         * infrun.c (stop_all_threads): Collect multiple wait events at
3596         each pass.
3597
3598 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3599
3600         * gdbtypes.h (TYPE_CODE): Remove.  Change all call sites to use
3601         type::code instead.
3602
3603 2020-05-14  Simon Marchi  <simon.marchi@efficios.com>
3604
3605         * gdbtypes.h (struct type) <code, set_code>: New methods.
3606         (TYPE_CODE): Use type::code.  Change all call sites used to set
3607         the code to use type::set_code instead.
3608
3609 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3610             Tom de Vries  <tdevries@suse.de>
3611             Pedro Alves  <palves@redhat.com>
3612
3613         PR threads/25478
3614         * infrun.c (stop_all_threads): Do NOT ignore
3615         TARGET_WAITKIND_NO_RESUMED, TARGET_WAITKIND_THREAD_EXITED,
3616         TARGET_WAITKIND_EXITED, TARGET_WAITKIND_SIGNALLED wait statuses
3617         received.
3618         (handle_no_resumed): Remove code handling a live inferior with no
3619         threads.
3620         * remote.c (has_single_non_exited_thread): New.
3621         (remote_target::update_thread_list): Do not delete a thread if is
3622         the last thread of the process.
3623         * thread.c (thread_select): Call delete_exited_threads instead of
3624         prune_threads.
3625
3626 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3627
3628         * infrun.c (stop_all_threads): Enable/disable thread events of all
3629         targets.  Move a debug message denoting the end of the function
3630         into the SCOPED_EXIT block.
3631
3632 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3633
3634         * process-stratum-target.h: Include <set>.
3635         (all_non_exited_process_targets, switch_to_target_no_thread): New
3636         function declarations.
3637         * process-stratum-target.c (all_non_exited_process_targets)
3638         (switch_to_target_no_thread): New function implementations.
3639
3640 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3641
3642         * infrun.c (handle_inferior_event): Extract out a piece of code
3643         into...
3644         (mark_non_executing_threads): ...this new function.
3645
3646 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3647
3648         * infrun.c (resume_1): Move a 'regcache_read_pc' call down to first
3649         use.
3650
3651 2020-05-14  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3652
3653         * regcache.c (regcache_read_pc_protected): New function
3654         implementation that returns 0 if the PC cannot read via
3655         'regcache_read_pc'.
3656         * infrun.c (proceed): Call 'regcache_read_pc_protected'
3657         instead of 'regcache_read_pc'.
3658         (keep_going_pass_signal): Ditto.
3659
3660 2020-05-13  Tom Tromey  <tromey@adacore.com>
3661
3662         * ada-lang.c (align_value): Remove.
3663         (ada_template_to_fixed_record_type_1): Use align_up.
3664
3665 2020-05-13  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3666
3667         * async-event.c: Update the copyright year.
3668         * async-event.h: Update the copyright year.
3669
3670 2020-05-12  Simon Marchi  <simon.marchi@efficios.com>
3671
3672         * objfiles.h (is_addr_in_objfile,
3673         shared_objfile_contains_address_p): Return bool.
3674         * objfile.c (is_addr_in_objfile,
3675         shared_objfile_contains_address_p): Return bool.
3676
3677 2020-05-11  Tom Tromey  <tromey@adacore.com>
3678
3679         * cli/cli-cmds.c (info_command): Restore.
3680         (_initialize_cli_cmds): Use add_prefix_command for "info".
3681         * gdb-gdb.gdb.in: Restore breakpoint on info_command.
3682
3683 2020-05-11  Tom Tromey  <tromey@adacore.com>
3684
3685         * ada-lang.c (ada_value_primitive_field): Now public.
3686         * ada-lang.h (ada_value_primitive_field): Declare.
3687         * ada-valprint.c (print_field_values): Use
3688         ada_value_primitive_field for wrapper fields.
3689
3690 2020-05-11  Tom de Vries  <tdevries@suse.de>
3691
3692         * dwarf2/index-write.c (debug_names::psymbol_tag): Handle
3693         MODULE_DOMAIN.
3694
3695 2020-05-11  Tom de Vries  <tdevries@suse.de>
3696
3697         PR symtab/25941
3698         * dwarf2/read.c (create_cus_from_debug_names_list): Initialize CUs
3699         with length 0, if not gdb-produced.
3700         (cutu_reader::cutu_reader): Set CU length to actual length if 0.
3701
3702 2020-05-09  Tom de Vries  <tdevries@suse.de>
3703
3704         PR gdb/25955
3705         * break-catch-throw.c (check_status_exception_catchpoint): Fix name
3706         calculation.
3707
3708 2020-05-09  Tom Tromey  <tom@tromey.com>
3709
3710         * top.c (server_command): Now bool.
3711         * top.h (server_command): Now bool.
3712
3713 2020-05-08  Tom Tromey  <tromey@adacore.com>
3714
3715         * dwarf2/read.c (read_lexical_block_scope): Don't process a DIE
3716         already being processed.
3717
3718 2020-05-08  Tom Tromey  <tom@tromey.com>
3719
3720         * printcmd.c (struct display) <next>: Remove.
3721         <display>: New constructor.
3722         <exp_string>: Now a std::string.
3723         <enabled_p>: Now a bool.
3724         (display_number): Move definition earlier.
3725         (displays): Rename from display_chain.  Now a std::vector.
3726         (ALL_DISPLAYS, ALL_DISPLAYS_SAFE): Remove.
3727         (display_command): Update.
3728         (do_one_display, disable_display)
3729         (enable_disable_display_command, do_enable_disable_display):
3730         Update.
3731         (free_display): Remove.
3732         (clear_displays): Rewrite.
3733         (delete_display): Update.
3734         (map_display_numbers): Use function_view.  Remove "data"
3735         parameter.  Update.
3736         (do_delete_display): Remove.
3737         (undisplay_command): Update.
3738         (do_one_display, do_displays, disable_display)
3739         (info_display_command): Update.
3740         (do_enable_disable_display): Remove.
3741         (enable_disable_display_command)
3742         (clear_dangling_display_expressions): Update.
3743
3744 2020-05-08  Tom Tromey  <tom@tromey.com>
3745
3746         * symtab.c (set_symbol_cache_size)
3747         (maintenance_print_symbol_cache, maintenance_flush_symbol_cache)
3748         (maintenance_print_symbol_cache_statistics): Update.
3749         * symmisc.c (print_symbol_bcache_statistics)
3750         (print_objfile_statistics, maintenance_print_objfiles)
3751         (maintenance_info_symtabs, maintenance_check_symtabs)
3752         (maintenance_expand_symtabs, maintenance_info_line_tables):
3753         Update.
3754         * symfile-debug.c (set_debug_symfile): Update.
3755         * source.c (forget_cached_source_info): Update.
3756         * python/python.c (gdbpy_progspaces): Update.
3757         * psymtab.c (maintenance_info_psymtabs): Update.
3758         * probe.c (parse_probes): Update.
3759         * linespec.c (iterate_over_all_matching_symtabs)
3760         (collect_symtabs_from_filename, search_minsyms_for_name): Update.
3761         * guile/scm-progspace.c (gdbscm_progspaces): Update.
3762         * exec.c (exec_target::close): Update.
3763         * ada-tasks.c (ada_tasks_new_objfile_observer): Update.
3764         * breakpoint.c (print_one_breakpoint_location)
3765         (create_longjmp_master_breakpoint)
3766         (create_std_terminate_master_breakpoint): Update.
3767         * progspace.c (program_spaces): Now a std::vector.
3768         (maybe_new_address_space): Update.
3769         (add_program_space): Remove.
3770         (program_space::program_space): Update.
3771         (remove_program_space): Update.
3772         (number_of_program_spaces): Remove.
3773         (print_program_space, update_address_spaces): Update.
3774         * progspace.h (program_spaces): Change type.
3775         (ALL_PSPACES): Remove.
3776         (number_of_program_spaces): Don't declare.
3777         (struct program_space) <next>: Remove.
3778
3779 2020-05-08  Tom Tromey  <tom@tromey.com>
3780
3781         * mi/mi-cmd-file.c (mi_cmd_file_list_shared_libraries): Update.
3782         * solib-svr4.c (svr4_fetch_objfile_link_map): Update.
3783         (enable_break): Update.
3784         * solib-frv.c (frv_fdpic_find_global_pointer): Update.
3785         (frv_fdpic_find_canonical_descriptor): Update.
3786         (frv_fetch_objfile_link_map): Update.
3787         * progspace.c (program_space::free_all_objfiles): Update.
3788         (program_space::solibs): New method.
3789         * progspace.h (struct program_space) <solibs>: New method.
3790         * solist.h (master_so_list): Don't declare.
3791         (ALL_SO_LIBS): Remove.
3792         * solib.h (so_list_head): Remove.
3793         (update_solib_list): Update comment.
3794         * solib.c (master_so_list): Remove.
3795         (solib_used, update_solib_list, solib_add)
3796         (info_sharedlibrary_command, clear_solib)
3797         (reload_shared_libraries_1, remove_user_added_objfile): Update.
3798
3799 2020-05-08  Tom Tromey  <tom@tromey.com>
3800
3801         * extension.c (extension_languages): Now a std::array.
3802         (ALL_EXTENSION_LANGUAGES): Remove.
3803         (get_ext_lang_defn, get_ext_lang_of_file)
3804         (eval_ext_lang_from_control_command): Update.
3805         (finish_ext_lang_initialization)
3806         (auto_load_ext_lang_scripts_for_objfile)
3807         (ext_lang_type_printers::ext_lang_type_printers)
3808         (apply_ext_lang_type_printers)
3809         (ext_lang_type_printers::~ext_lang_type_printers)
3810         (apply_ext_lang_val_pretty_printer, apply_ext_lang_frame_filter)
3811         (preserve_ext_lang_values, get_breakpoint_cond_ext_lang)
3812         (breakpoint_ext_lang_cond_says_stop, check_quit_flag)
3813         (get_matching_xmethod_workers, ext_lang_colorize)
3814         (ext_lang_before_prompt): Update.
3815         (ALL_ENABLED_EXTENSION_LANGUAGES): Remove.
3816
3817 2020-05-08  Tom Tromey  <tom@tromey.com>
3818
3819         * symtab.h (class demangle_result_storage) <set_malloc_ptr>: New
3820         overload.
3821         <swap_string, m_string>: Remove.
3822         * symtab.c (demangle_for_lookup, completion_list_add_symbol):
3823         Update.
3824         * stabsread.c (define_symbol, read_type): Update.
3825         * linespec.c (find_linespec_symbols): Update.
3826         * gnu-v3-abi.c (gnuv3_get_typeid): Update.
3827         * dwarf2/read.c (dwarf2_canonicalize_name): Update.
3828         * dbxread.c (read_dbx_symtab): Update.
3829         * cp-support.h (cp_canonicalize_string_full)
3830         (cp_canonicalize_string, cp_canonicalize_string_no_typedefs):
3831         Return unique_xmalloc_ptr.
3832         * cp-support.c (inspect_type): Update.
3833         (cp_canonicalize_string_full): Return unique_xmalloc_ptr.
3834         (cp_canonicalize_string_no_typedefs, cp_canonicalize_string):
3835         Likewise.
3836         * c-typeprint.c (print_name_maybe_canonical): Update.
3837         * break-catch-throw.c (check_status_exception_catchpoint):
3838         Update.
3839
3840 2020-05-08  Tom de Vries  <tdevries@suse.de>
3841
3842         * infrun.c (follow_fork): Copy current_line and current_symtab to
3843         child thread.
3844
3845 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3846
3847         * async-event.c (struct async_signal_handler, struct
3848         async_event_handler): Reformat, remove typedef.
3849
3850 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3851
3852         * gdbtypes.h (TYPE_DYN_PROP_LIST): Remove.  Update all users
3853         access thistype->main_type->dyn_prop_list directly.
3854
3855 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3856
3857         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
3858         (remove_dyn_prop): Remove.  Update all users to use
3859         type::remove_dyn_prop.
3860         * gdbtypes.c (remove_dyn_prop): Rename to...
3861         (type::remove_dyn_prop): ... this.
3862
3863 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
3864
3865         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
3866         (add_dyn_prop): Remove.  Update all users to use
3867         type::add_dyn_prop.
3868         * gdbtypes.c (add_dyn_prop): Rename to...
3869         (type::add_dyn_prop): ... this.
3870
3871 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
3872
3873         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
3874         (get_dyn_prop): Remove.  Update all users to use
3875         type::dyn_prop.
3876         * gdbtypes.c (get_dyn_prop): Rename to...
3877         (type::dyn_prop): ... this.
3878
3879 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3880
3881         * gdbtypes.h (struct main_type) <flag_static>: Remove.
3882
3883 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
3884
3885         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
3886         instruction, skip it if it's there.
3887
3888 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
3889
3890         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
3891
3892 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
3893
3894         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
3895         * gdbtypes.c (recursive_dump_type): Remove use of
3896         TYPE_INCOMPLETE.
3897
3898 2020-05-03  Tom Tromey  <tom@tromey.com>
3899
3900         * breakpoint.c (catch_command, tcatch_command): Remove.
3901         (_initialize_breakpoint): Use add_basic_prefix_cmd,
3902         add_show_prefix_cmd.
3903         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
3904         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
3905         Remove.
3906         (add_internal_problem_command): Use add_basic_prefix_cmd,
3907         add_show_prefix_cmd.
3908         * mips-tdep.c (set_mipsfpu_command): Remove.
3909         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
3910         * dwarf2/index-cache.c (set_index_cache_command): Remove.
3911         (_initialize_index_cache): Use add_basic_prefix_cmd.
3912         * memattr.c (dummy_cmd): Remove.
3913         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
3914         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
3915         (_initialize_tui_win): Use add_basic_prefix_cmd,
3916         add_show_prefix_cmd.
3917         * cli/cli-logging.c (set_logging_command): Remove.
3918         (_initialize_cli_logging): Use add_basic_prefix_cmd,
3919         add_show_prefix_cmd.
3920         (show_logging_command): Remove.
3921         * target.c (target_command): Remove.
3922         (add_target): Use add_basic_prefix_cmd.
3923
3924 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
3925
3926         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
3927
3928 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3929
3930         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
3931         info_command.
3932
3933 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
3934
3935         * nbsd-nat.c (nbsd_enable_proc_events)
3936         (nbsd_nat_target::post_startup_inferior): Add.
3937         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
3938         (nbsd_nat_target::update_thread_list): Rewrite.
3939         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
3940         "PTRACE_LWP_CREATE".
3941         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
3942
3943 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3944
3945         * stack.c (_initialize_stack): Remove duplicated creation
3946         of "frame" command and "f" alias.
3947
3948 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3949
3950         PR gdb/18706
3951         * gdbtypes.c (check_typedef): Calculate size of array of
3952         stubbed type.
3953
3954 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
3955
3956         PR gdb/15559
3957         * i386-tdep.c (i386_push_dummy_call): Call
3958         i386_thiscall_push_dummy_call.
3959         (i386_thiscall_push_dummy_call): New function.
3960         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
3961         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
3962         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
3963
3964 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3965
3966         * gdbarch.sh (do_read): Add shellcheck disable directive for
3967         warning SC2162.
3968
3969 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3970
3971         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
3972         "referenced but not assigned" warning.
3973
3974 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3975
3976         * gdbarch.sh: Remove code that sets fallbackdefault.
3977
3978 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3979
3980         * gdbarch.sh: Use shell operators && and || instead of
3981         -a and -o.
3982
3983 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3984
3985         * gdbarch.sh: Use $(...) instead of `...`.
3986
3987 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3988
3989         * gdbarch.sh: Use double quotes around variables.
3990
3991 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
3992
3993         * gdbarch.sh: Use %s with printf, instead of variables in the
3994         format string.
3995
3996 2020-04-29  Tom Tromey  <tromey@adacore.com>
3997
3998         PR ada/25875:
3999         * dwarf2/read.c (update_enumeration_type_from_children): Compute
4000         type fields here.
4001         (read_enumeration_type): Call
4002         update_enumeration_type_from_children later.  Update comments.
4003         (process_enumeration_scope): Don't create type fields.
4004
4005 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
4006
4007         * nbsd-tdep.c: Include "xml-syscall.h".
4008         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
4009
4010 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
4011
4012         * nbsd-nat.c: Include "sys/wait.h".
4013         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
4014         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
4015         (nbsd_nat_target::remove_exec_catchpoint)
4016         (nbsd_nat_target::set_syscall_catchpoint): Add.
4017         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
4018         (nbsd_nat_target::insert_exec_catchpoint)
4019         (nbsd_nat_target::remove_exec_catchpoint)
4020         (nbsd_nat_target::set_syscall_catchpoint): Add.
4021         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
4022         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
4023         `nbsd_get_syscall_number'.
4024
4025 2020-04-29  Tom Tromey  <tom@tromey.com>
4026
4027         * stack.c (print_block_frame_labels): Remove.
4028
4029 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
4030
4031         PR gdb/17320
4032         * ada-valprint.c (val_print_packed_array_elements): Move array
4033         end bracket to new line.
4034         (ada_val_print_string): Remove extra spaces before first array
4035         element.
4036         * c-valprint.c (c_value_print_array): Likewise.
4037         * m2-valprint.c (m2_print_array_contents): Likewise.
4038         (m2_value_print_inner): Likewise.
4039         * p-valprint.c (pascal_value_print_inner): Likewise.
4040         * valprint.c (generic_val_print_array): Likewise.
4041         (value_print_array_elements): Move first array element and array
4042         end bracket to new line.
4043
4044 2020-04-29  Tom de Vries  <tdevries@suse.de>
4045
4046         PR symtab/25889
4047         * linespec.c (find_method): Fix ix calculation.
4048
4049 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
4050
4051         * syscalls/update-netbsd.sh: New file.
4052         * syscalls/netbsd.xml: Regenerate.
4053         * data-directory/Makefile.in: Register `netbsd.xml' in
4054         `SYSCALLS_FILES'.
4055
4056 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
4057
4058         * syscalls/update-freebsd.sh: Add double quotes.
4059
4060 2020-04-28  Tom Tromey  <tom@tromey.com>
4061
4062         * NEWS: Update.
4063         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
4064         (cmdpy_init): Allow class_tui.
4065
4066 2020-04-28 Mark Williams <mark@myosotissp.com>
4067
4068         PR gdb/24480
4069         * dwarf2read.c: Add missing assingments to list_in_scope when
4070         start_symtab was already called.
4071
4072 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
4073
4074         PR gdb/25881
4075         * dwarf2/read.c (offset_map_type): Use
4076         gdb:hash_enum<sect_offset> as hash function.
4077
4078 2020-04-28  Tom de Vries  <tdevries@suse.de>
4079
4080         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
4081         with DW_AT_signature.
4082
4083 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
4084
4085         * configure.ac: Remove check for fs_base/gs_base in
4086         user_regs_struct.
4087         * configure: Re-generate.
4088         * config.in: Re-generate.
4089         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
4090         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
4091         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
4092
4093 2020-04-27  Luis Machado  <luis.machado@linaro.org>
4094
4095         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
4096         problematic inline frame unwinding situation.
4097         * frame.c (frame_id_computed_p): New function.
4098         * frame.h (frame_id_computed_p): New prototype.
4099
4100 2020-04-26  Tom Tromey  <tom@tromey.com>
4101
4102         * command.h (enum command_class) <class_pseudo>: Remove.
4103
4104 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4105
4106         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
4107         and whitespace.
4108
4109 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
4110
4111         * inf-ptrace.c (inf_ptrace_target::wait): Remove
4112         `PT_GET_PROCESS_STATE' block.
4113
4114 2020-04-24  Tom Tromey  <tom@tromey.com>
4115
4116         * symtab.h (symbol_get_demangled_name): Don't declare.
4117         * symtab.c (symbol_get_demangled_name): Remove.
4118         (general_symbol_info::natural_name)
4119         (general_symbol_info::demangled_name): Update.
4120
4121 2020-04-24  Tom Tromey  <tom@tromey.com>
4122
4123         PR rust/25025:
4124         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
4125
4126 2020-04-24  Tom Tromey  <tom@tromey.com>
4127
4128         PR symtab/12707:
4129         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
4130         exists.
4131         (new_symbol): Likewise.
4132         * compile/compile-object-load.c (get_out_value_type): Use
4133         symbol_matches_search_name.
4134
4135 2020-04-24  Tom Tromey  <tom@tromey.com>
4136
4137         * dwarf2/read.c (add_partial_symbol): Do not call
4138         compute_and_set_names.
4139
4140 2020-04-24  Tom Tromey  <tom@tromey.com>
4141
4142         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
4143         overload.
4144
4145 2020-04-24  Tom Tromey  <tom@tromey.com>
4146
4147         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
4148         (add_psymbol_to_list): New overload.  Make old overload call new
4149         one.
4150         * psympriv.h (add_psymbol_to_list): New overload.
4151
4152 2020-04-24  Tom Tromey  <tom@tromey.com>
4153
4154         * dwarf2/read.c (partial_die_info::read) <case
4155         DW_AT_linkage_name>: Use value_as_string.
4156         (dwarf2_string_attr): Use value_as_string.
4157         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
4158         method.
4159         * dwarf2/attribute.c (attribute::value_as_string): New method.
4160
4161 2020-04-24  Tom Tromey  <tom@tromey.com>
4162
4163         * symtab.c (general_symbol_info::natural_name)
4164         (general_symbol_info::demangled_name): Check for language_rust.
4165
4166 2020-04-24  Tom Tromey  <tom@tromey.com>
4167
4168         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
4169         (dwarf2_physname): ... from here.
4170         (partial_die_info::read): Add Rust "{" hack.
4171
4172 2020-04-24  Tom Tromey  <tom@tromey.com>
4173
4174         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
4175         method.
4176         (symbol_set_demangled_name): Don't declare.
4177         * symtab.c (general_symbol_info::set_demangled_name): Rename from
4178         symbol_set_demangled_name.
4179         (general_symbol_info::set_language)
4180         (general_symbol_info::compute_and_set_names): Update.
4181         * minsyms.c (minimal_symbol_reader::install): Update.
4182         * dwarf2/read.c (new_symbol): Update.
4183
4184 2020-04-24  Tom Tromey  <tromey@adacore.com>
4185
4186         PR python/23662:
4187         * python/py-type.c (convert_field): Handle
4188         FIELD_LOC_KIND_DWARF_BLOCK.
4189         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
4190         (typy_get_dynamic): Nw function.
4191         (type_object_getset): Add "dynamic".
4192         * NEWS: Add entry.
4193
4194 2020-04-24  Tom Tromey  <tromey@adacore.com>
4195
4196         * ada-typeprint.c (print_choices, print_variant_part)
4197         (print_record_field_types_dynamic): New functions.
4198         (print_record_field_types): Use print_record_field_types_dynamic.
4199
4200 2020-04-24  Tom Tromey  <tromey@adacore.com>
4201
4202         * dwarf2/read.c (handle_data_member_location): New overload.
4203         (dwarf2_add_field): Use it.
4204         (decode_locdesc): Add "computed" parameter.  Update comment.
4205         * gdbtypes.c (is_dynamic_type_internal): Also look for
4206         FIELD_LOC_KIND_DWARF_BLOCK.
4207         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
4208         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
4209         virtual base classes.
4210         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
4211         FIELD_LOC_KIND_DWARF_BLOCK.
4212
4213 2020-04-24  Tom Tromey  <tromey@adacore.com>
4214
4215         * dwarf2/read.c (read_structure_type): Handle dynamic length.
4216         * gdbtypes.c (is_dynamic_type_internal): Check
4217         TYPE_HAS_DYNAMIC_LENGTH.
4218         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
4219         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
4220         New macros.
4221         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
4222         constant.
4223
4224 2020-04-24  Tom Tromey  <tromey@adacore.com>
4225
4226         * dwarf2/read.c (struct variant_field): Rewrite.
4227         (struct variant_part_builder): New.
4228         (struct nextfield): Remove "variant" field.  Add "offset".
4229         (struct field_info): Add "current_variant_part" and
4230         "variant_parts".
4231         (alloc_discriminant_info): Remove.
4232         (alloc_rust_variant): New function.
4233         (quirk_rust_enum): Update.
4234         (dwarf2_add_field): Set "offset" member.  Don't handle
4235         DW_TAG_variant_part.
4236         (offset_map_type): New typedef.
4237         (convert_variant_range, create_one_variant)
4238         (create_one_variant_part, create_variant_parts)
4239         (add_variant_property): New functions.
4240         (dwarf2_attach_fields_to_type): Call add_variant_property.
4241         (read_structure_type): Don't handle DW_TAG_variant_part.
4242         (handle_variant_part, handle_variant): New functions.
4243         (handle_struct_member_die): Use them.
4244         (process_structure_scope): Don't handle variant parts.
4245         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
4246         (struct discriminant_info): Remove.
4247         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
4248         (struct main_type) <flag_discriminated_union>: Remove.
4249         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
4250         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
4251         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
4252         Update.
4253         * valops.c (value_union_variant): Remove.
4254         * value.h (value_union_variant): Don't declare.
4255
4256 2020-04-24  Tom Tromey  <tromey@adacore.com>
4257
4258         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
4259         (ada_value_primitive_packed_val): Update.
4260         * ada-valprint.c (ada_value_print_1): Update.
4261         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
4262         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
4263         just an address.  Use evaluate_for_locexpr_baton.
4264         (dwarf2_evaluate_property): Update.
4265         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
4266         array_view.
4267         * findvar.c (default_read_var_value): Update.
4268         * gdbtypes.c (compute_variant_fields_inner)
4269         (resolve_dynamic_type_internal): Update.
4270         (resolve_dynamic_type): Change type of valaddr parameter.
4271         * gdbtypes.h (resolve_dynamic_type): Update.
4272         * valarith.c (value_subscripted_rvalue): Update.
4273         * value.c (value_from_contents_and_address): Update.
4274
4275 2020-04-24  Tom Tromey  <tromey@adacore.com>
4276
4277         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
4278         "push_initial_value" parameter.
4279         (dwarf2_evaluate_property): Likewise.
4280         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
4281
4282 2020-04-24  Tom Tromey  <tromey@adacore.com>
4283
4284         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
4285         (variant::matches, compute_variant_fields_recurse)
4286         (compute_variant_fields_inner, compute_variant_fields): New
4287         functions.
4288         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
4289         Use resolved_type after type is made.
4290         (operator==): Add new cases.
4291         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
4292         (struct discriminant_range, struct variant, struct variant_part):
4293         New.
4294         (union dynamic_prop_data) <variant_parts, original_type>: New
4295         members.
4296         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
4297         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
4298         constants.
4299         * value.c (unpack_bits_as_long): Now public.
4300         * value.h (unpack_bits_as_long): Declare.
4301
4302 2020-04-24  Tom Tromey  <tromey@adacore.com>
4303
4304         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
4305         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
4306
4307 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
4308
4309         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
4310
4311 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
4312
4313         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
4314         (remove_fork_catchpoint, post_startup_inferior)
4315         (post_attach): Move...
4316         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
4317         (remove_fork_catchpoint, post_startup_inferior)
4318         (post_attach): ...here.
4319         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
4320         (remove_fork_catchpoint, post_startup_inferior)
4321         (post_attach): Move...
4322         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
4323         (remove_fork_catchpoint, post_startup_inferior)
4324         (post_attach): ...here.
4325
4326 2020-04-24  Tom Tromey  <tromey@adacore.com>
4327
4328         * nat/windows-nat.h (struct windows_thread_info)
4329         <pc_adjusted>: New member.
4330         * windows-nat.c (windows_fetch_one_register): Check
4331         pc_adjusted.
4332         (windows_nat_target::get_windows_debug_event)
4333         (windows_nat_target::wait): Set pc_adjusted.
4334
4335 2020-04-24  Tom de Vries  <tdevries@suse.de>
4336
4337         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
4338         Run gdb-add-index inside temp dir.
4339
4340 2020-04-23  Tom Tromey  <tromey@adacore.com>
4341
4342         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
4343         in loop.
4344
4345 2020-04-23  Luis Machado  <luis.machado@linaro.org>
4346
4347         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
4348         get_frame_register instead of gdbarch_unwind_pc.
4349
4350 2020-04-23  Tom de Vries  <tdevries@suse.de>
4351
4352         * symtab.c (lookup_global_symbol): Prefer def over decl.
4353
4354 2020-04-23  Tom de Vries  <tdevries@suse.de>
4355
4356         PR symtab/25807
4357         * block.c (best_symbol, better_symbol): Promote to external.
4358         * block.h (best_symbol, better_symbol): Declare.
4359         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
4360         decl.
4361
4362 2020-04-23  Tom Tromey  <tromey@adacore.com>
4363
4364         PR ada/25837:
4365         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
4366         "const char *", not a "const std::string &".
4367         <name_and_matcher::operator==>: Update.
4368         * unittests/lookup_name_info-selftests.c: Change type of
4369         "result".
4370
4371 2020-04-23  Tom Tromey  <tom@tromey.com>
4372
4373         * inferior.h (iterate_over_inferiors): Don't declare.
4374         * inferior.c (iterate_over_inferiors): Remove.
4375         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
4376         Remove.
4377         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
4378         use iterate_over_inferiors.
4379         (darwin_resume_inferior_it)
4380         (struct resume_inferior_threads_param)
4381         (darwin_resume_inferior_threads_it): Remove.
4382         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
4383
4384 2020-04-23  Tom de Vries  <tdevries@suse.de>
4385
4386         * blockframe.c (find_pc_partial_function): Use
4387         find_pc_sect_compunit_symtab rather than
4388         objfile->sf->qf->find_pc_sect_compunit_symtab.
4389
4390 2020-04-22  Tom de Vries  <tdevries@suse.de>
4391
4392         PR symtab/25764
4393         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
4394         in psymtabs.
4395
4396 2020-04-22  Tom de Vries  <tdevries@suse.de>
4397
4398         PR symtab/25801
4399         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
4400         symtabs.
4401
4402 2020-04-22  Tom de Vries  <tdevries@suse.de>
4403
4404         PR symtab/25700
4405         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
4406         CU if already created.
4407
4408 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
4409
4410         * infrun.c (displaced_step_fixup): Switch to the event_thread
4411         before calling displaced_step_restore, not after.
4412
4413 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4414
4415         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
4416         its inferior is not recorded by us.
4417         (record_btrace_target_open): Replace call to
4418         all_non_exited_threads () with call to current_inferior
4419         ()->non_exited_threads ().
4420         (record_btrace_target::stop_recording): Likewise.
4421         (record_btrace_target::close): Likewise.
4422         (record_btrace_target::wait): Likewise.
4423         (record_btrace_target::record_stop_replaying): Likewise.
4424
4425 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4426
4427         * btrace.c (btrace_enable): Throw an error on double enables and
4428         when enabling recording fails.
4429         (btrace_disable): Throw an error if the thread is not recorded.
4430
4431 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
4432
4433         * record-btrace.c (record_btrace_target::fetch_registers): Forward
4434         request if we do not have a thread_info.
4435
4436 2020-04-21  Tom de Vries  <tdevries@suse.de>
4437
4438         PR gdb/25471
4439         * thread.c
4440         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
4441         exception in get_frame_id.
4442
4443 2020-04-20  Tom Tromey  <tromey@adacore.com>
4444
4445         * python/python.c (struct gdbpy_event): Mark move constructor as
4446         noexcept.
4447         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
4448         constructor as noexcept.
4449         * completer.h (struct completion_result): Mark move constructor as
4450         noexcept.
4451         * completer.c (completion_result::completion_result): Use
4452         initialization style.  Don't call reset_match_list.
4453
4454 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
4455
4456         * MAINTAINERS (Write After Approval): Add myself.
4457
4458 2020-04-18  Tom Tromey  <tom@tromey.com>
4459
4460         * windows-tdep.c (init_w32_command_list)
4461         (w32_prefix_command_valid): Restore.
4462         (_initialize_windows_tdep): Call init_w32_command_list.
4463
4464 2020-04-18  Tom Tromey  <tom@tromey.com>
4465
4466         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
4467         * value.c (value_fn_field): Update.
4468         * valops.c (find_function_in_inferior)
4469         (value_allocate_space_in_inferior): Update.
4470         * tui/tui-winsource.c (tui_update_source_windows_with_line):
4471         Update.
4472         * tui/tui-source.c (tui_source_window::set_contents): Update.
4473         * symtab.c (lookup_global_or_static_symbol)
4474         (find_function_start_sal_1, skip_prologue_sal)
4475         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
4476         * symmisc.c (dump_msymbols, dump_symtab_1)
4477         (maintenance_print_one_line_table): Update.
4478         * symfile.c (init_entry_point_info, section_is_mapped)
4479         (list_overlays_command, simple_read_overlay_table)
4480         (simple_overlay_update_1): Update.
4481         * stap-probe.c (handle_stap_probe): Update.
4482         * stabsread.c (dbx_init_float_type, define_symbol)
4483         (read_one_struct_field, read_enum_type, read_range_type): Update.
4484         * source.c (info_line_command): Update.
4485         * python/python.c (gdbpy_source_objfile_script)
4486         (gdbpy_execute_objfile_script): Update.
4487         * python/py-type.c (save_objfile_types): Update.
4488         * python/py-objfile.c (py_free_objfile): Update.
4489         * python/py-inferior.c (python_new_objfile): Update.
4490         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
4491         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
4492         (maintenance_check_psymtabs): Update.
4493         * printcmd.c (info_address_command): Update.
4494         * objfiles.h (struct objfile) <arch>: New method, from
4495         get_objfile_arch.
4496         (get_objfile_arch): Don't declare.
4497         * objfiles.c (get_objfile_arch): Remove.
4498         (filter_overlapping_sections): Update.
4499         * minsyms.c (msymbol_is_function): Update.
4500         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
4501         (output_nondebug_symbol): Update.
4502         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
4503         (mdebug_expand_psymtab): Update.
4504         * machoread.c (macho_add_oso_symfile): Update.
4505         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
4506         Update.
4507         * linux-fork.c (checkpoint_command): Update.
4508         * linespec.c (convert_linespec_to_sals): Update.
4509         * jit.c (finalize_symtab): Update.
4510         * infrun.c (insert_exception_resume_from_probe): Update.
4511         * ia64-tdep.c (ia64_find_unwind_table): Update.
4512         * hppa-tdep.c (internalize_unwinds): Update.
4513         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
4514         Update.
4515         * gcore.c (call_target_sbrk): Update.
4516         * elfread.c (record_minimal_symbol, elf_symtab_read)
4517         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
4518         (elf_gnu_ifunc_resolve_by_got): Update.
4519         * dwarf2/read.c (create_addrmap_from_index)
4520         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
4521         (read_debug_names_from_section)
4522         (process_psymtab_comp_unit_reader, add_partial_symbol)
4523         (add_partial_subprogram, process_full_comp_unit)
4524         (read_file_scope, read_func_scope, read_lexical_block_scope)
4525         (read_call_site_scope, dwarf2_ranges_read)
4526         (dwarf2_record_block_ranges, dwarf2_add_field)
4527         (mark_common_block_symbol_computed, read_tag_pointer_type)
4528         (read_tag_string_type, dwarf2_init_float_type)
4529         (dwarf2_init_complex_target_type, read_base_type)
4530         (partial_die_info::read, partial_die_info::read)
4531         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
4532         (dwarf2_fetch_die_loc_sect_off): Update.
4533         * dwarf2/loc.c (dwarf2_find_location_expression)
4534         (class dwarf_evaluate_loc_desc, rw_pieced_value)
4535         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
4536         (dwarf2_loc_desc_get_symbol_read_needs)
4537         (locexpr_describe_location_piece, locexpr_describe_location_1)
4538         (loclist_describe_location): Update.
4539         * dwarf2/index-write.c (write_debug_names): Update.
4540         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
4541         * dtrace-probe.c (dtrace_process_dof): Update.
4542         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
4543         (process_one_symbol): Update.
4544         * ctfread.c (ctf_init_float_type, read_base_type): Update.
4545         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
4546         (coff_read_enum_type): Update.
4547         * cli/cli-cmds.c (edit_command, list_command): Update.
4548         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
4549         * breakpoint.c (create_overlay_event_breakpoint)
4550         (create_longjmp_master_breakpoint)
4551         (create_std_terminate_master_breakpoint)
4552         (create_exception_master_breakpoint, get_sal_arch): Update.
4553         * block.c (block_gdbarch): Update.
4554         * annotate.c (annotate_source_line): Update.
4555
4556 2020-04-17  Tom Tromey  <tromey@adacore.com>
4557
4558         * auto-load.c (show_auto_load_cmd): Remove.
4559         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
4560         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
4561         (maintenance_print_arc_command): Remove.
4562         * tui/tui-win.c (tui_command): Remove.
4563         (tui_get_cmd_list): Use add_basic_prefix_cmd.
4564         * tui/tui-layout.c (tui_layout_command): Remove.
4565         (_initialize_tui_layout): Use add_basic_prefix_cmd.
4566         * python/python.c (user_set_python, user_show_python): Remove.
4567         (_initialize_python): Use add_basic_prefix_cmd,
4568         add_show_prefix_cmd.
4569         * guile/guile.c (set_guile_command, show_guile_command): Remove.
4570         (install_gdb_commands): Use add_basic_prefix_cmd,
4571         add_show_prefix_cmd.
4572         (info_guile_command): Remove.
4573         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
4574         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
4575         add_show_prefix_cmd.
4576         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
4577         Remove do_set and do_show parameters.
4578         * cli/cli-style.c (set_style, show_style): Remove.
4579         (_initialize_cli_style): Use add_basic_prefix_cmd,
4580         add_show_prefix_cmd.
4581         (cli_style_option::add_setshow_commands): Remove do_set and
4582         do_show parameters.
4583         (cli_style_option::add_setshow_commands): Use
4584         add_basic_prefix_cmd, add_show_prefix_cmd.
4585         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
4586         (set_style_name): Remove.
4587         * cli/cli-dump.c (dump_command, append_command): Remove.
4588         (srec_dump_command, ihex_dump_command, verilog_dump_command)
4589         (tekhex_dump_command, binary_dump_command)
4590         (binary_append_command): Remove.
4591         (_initialize_cli_dump): Use add_basic_prefix_cmd.
4592         * windows-tdep.c (w32_prefix_command_valid): Remove global.
4593         (init_w32_command_list): Remove; move into ...
4594         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
4595         * valprint.c (set_print, show_print, set_print_raw)
4596         (show_print_raw): Remove.
4597         (_initialize_valprint): Use add_basic_prefix_cmd,
4598         add_show_prefix_cmd.
4599         * typeprint.c (set_print_type, show_print_type): Remove.
4600         (_initialize_typeprint): Use add_basic_prefix_cmd,
4601         add_show_prefix_cmd.
4602         * record.c (set_record_command, show_record_command): Remove.
4603         (_initialize_record): Use add_basic_prefix_cmd,
4604         add_show_prefix_cmd.
4605         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
4606         add_show_prefix_cmd.
4607         (info_command, show_command, set_debug, show_debug): Remove.
4608         * top.h (set_history, show_history): Don't declare.
4609         * top.c (set_history, show_history): Remove.
4610         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
4611         (unset_tdesc_cmd): Remove.
4612         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
4613         add_show_prefix_cmd.
4614         * symtab.c (info_module_command): Remove.
4615         (_initialize_symtab): Use add_basic_prefix_cmd.
4616         * symfile.c (overlay_command): Remove.
4617         (_initialize_symfile): Use add_basic_prefix_cmd.
4618         * sparc64-tdep.c (info_adi_command): Remove.
4619         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
4620         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
4621         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
4622         add_show_prefix_cmd.
4623         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
4624         (_initialize_serial): Use add_basic_prefix_cmd,
4625         add_show_prefix_cmd.
4626         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
4627         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
4628         add_show_prefix_cmd.
4629         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
4630         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
4631         add_show_prefix_cmd.
4632         * riscv-tdep.c (show_riscv_command, set_riscv_command)
4633         (show_debug_riscv_command, set_debug_riscv_command): Remove.
4634         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
4635         add_show_prefix_cmd.
4636         * remote.c (remote_command, set_remote_cmd): Remove.
4637         (_initialize_remote): Use add_basic_prefix_cmd.
4638         * record-full.c (set_record_full_command)
4639         (show_record_full_command): Remove.
4640         (_initialize_record_full): Use add_basic_prefix_cmd,
4641         add_show_prefix_cmd.
4642         * record-btrace.c (cmd_set_record_btrace)
4643         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
4644         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
4645         (cmd_show_record_btrace_pt): Remove.
4646         (_initialize_record_btrace): Use add_basic_prefix_cmd,
4647         add_show_prefix_cmd.
4648         * ravenscar-thread.c (set_ravenscar_command)
4649         (show_ravenscar_command): Remove.
4650         (_initialize_ravenscar): Use add_basic_prefix_cmd,
4651         add_show_prefix_cmd.
4652         * mips-tdep.c (show_mips_command, set_mips_command)
4653         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
4654         add_show_prefix_cmd.
4655         * maint.c (maintenance_command, maintenance_info_command)
4656         (maintenance_check_command, maintenance_print_command)
4657         (maintenance_set_cmd, maintenance_show_cmd): Remove.
4658         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
4659         add_show_prefix_cmd.
4660         (show_per_command_cmd): Remove.
4661         * maint-test-settings.c (maintenance_set_test_settings_cmd):
4662         Remove.
4663         (maintenance_show_test_settings_cmd): Remove.
4664         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
4665         add_show_prefix_cmd.
4666         * maint-test-options.c (maintenance_test_options_command):
4667         Remove.
4668         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
4669         * macrocmd.c (macro_command): Remove
4670         (_initialize_macrocmd): Use add_basic_prefix_cmd.
4671         * language.c (set_check, show_check): Remove.
4672         (_initialize_language): Use add_basic_prefix_cmd,
4673         add_show_prefix_cmd.
4674         * infcmd.c (unset_command): Remove.
4675         (_initialize_infcmd): Use add_basic_prefix_cmd.
4676         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
4677         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
4678         add_show_prefix_cmd.
4679         * go32-nat.c (go32_info_dos_command): Remove.
4680         (_initialize_go32_nat): Use add_basic_prefix_cmd.
4681         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
4682         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
4683         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
4684         (_initialize_frame): Use add_basic_prefix_cmd,
4685         add_show_prefix_cmd.
4686         * dcache.c (set_dcache_command, show_dcache_command): Remove.
4687         (_initialize_dcache): Use add_basic_prefix_cmd,
4688         add_show_prefix_cmd.
4689         * cp-support.c (maint_cplus_command): Remove.
4690         (_initialize_cp_support): Use add_basic_prefix_cmd.
4691         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
4692         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
4693         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
4694         add_basic_prefix_cmd, add_show_prefix_cmd.
4695         * breakpoint.c (save_command): Remove.
4696         (_initialize_breakpoint): Use add_basic_prefix_cmd.
4697         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
4698         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
4699         add_show_prefix_cmd.
4700         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
4701         (set_ada_command, show_ada_command): Remove.
4702         (_initialize_ada_language): Use add_basic_prefix_cmd,
4703         add_show_prefix_cmd.
4704         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
4705
4706 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
4707
4708         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
4709         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
4710
4711 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4712
4713         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
4714         warning messages.
4715
4716 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
4717
4718         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
4719         import table is not at beginning of .idata section.
4720
4721 2020-04-16  Pedro Alves  <palves@redhat.com>
4722
4723         * inferior.c (delete_inferior): Use delete operator directly
4724         instead of delete_program_space.
4725         * progspace.c (add_program_space): New, factored out from
4726         program_space::program_space.
4727         (remove_program_space): New, factored out from
4728         delete_program_space.
4729         (program_space::program_space): Remove intro comment.  Rewrite.
4730         (program_space::~program_space): Remove intro comment.  Call
4731         remove_program_space.
4732         (delete_program_space): Delete.
4733         * progspace.h (program_space::program_space): Make explicit.  Move
4734         intro comment here, adjusted.
4735         (program_space::~program_space): Move intro comment here,
4736         adjusted.
4737         (delete_program_space): Remove.
4738
4739 2020-04-16  Tom Tromey  <tromey@adacore.com>
4740
4741         * windows-nat.c (windows_nat::handle_access_violation): New
4742         function.
4743         * nat/windows-nat.h (handle_access_violation): Declare.
4744         * nat/windows-nat.c (handle_exception): Move Cygwin code to
4745         windows-nat.c.  Call handle_access_violation.
4746
4747 2020-04-16  Tom de Vries  <tdevries@suse.de>
4748
4749         PR symtab/25791
4750         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
4751         CUs without psymtab.
4752
4753 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
4754
4755         * python/python.c (do_start_initialization): Don't call
4756         PyEval_InitThreads for Python 3.9 and beyond.
4757
4758 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
4759
4760         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
4761         thread functions.
4762         (obsd_nat_target::wait): Likewise.
4763
4764 2020-04-15  Tom Tromey  <tromey@adacore.com>
4765
4766         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
4767         (DEBUG_EXCEPT): Use debug_printf.
4768
4769 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
4770
4771         * completer.c (class completion_tracker::completion_hash_entry)
4772         <hash_name>: New member function.
4773         (completion_tracker::discard_completions): New callback to hash a
4774         completion_hash_entry, pass this to htab_create_alloc.
4775
4776 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
4777
4778         * windows-nat.c (windows_make_so): Warn rather than stopping with
4779         an error if realpath() fails.
4780
4781 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
4782
4783         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
4784         (nbsd_nat_target::info_proc): Add do_status.
4785
4786 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
4787             Tom de Vries  <tdevries@suse.de>
4788
4789         PR symtab/25718
4790         * psympriv.h (struct partial_symtab::read_symtab)
4791         (struct partial_symtab::expand_psymtab)
4792         (struct partial_symtab::read_dependencies): Update comments.
4793         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
4794         read_symtab for includer.
4795         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
4796         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
4797         (struct dwarf2_include_psymtab::m_readin): Remove.
4798         (struct dwarf2_include_psymtab::includer): New member function.
4799         (dwarf2_psymtab::expand_psymtab): Assert !readin.
4800
4801 2020-04-14  Tom de Vries  <tdevries@suse.de>
4802
4803         PR symtab/25720
4804         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
4805         with NULL symbol_matcher and lookup_name.
4806         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
4807         and lookup_name.
4808         * dwarf2/read.c (dw2_expand_symtabs_matching)
4809         (dw2_debug_names_expand_symtabs_matching): Same.
4810         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
4811         Make lookup_name a pointer.  Update comment.
4812         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
4813         lookup_name being a pointer.
4814         * symfile.c (expand_symtabs_matching): Same.
4815         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
4816         * linespec.c (iterate_over_all_matching_symtabs): Same.
4817
4818 2020-04-13  Tom Tromey  <tom@tromey.com>
4819
4820         * run-on-main-thread.c: Update include.
4821         * unittests/main-thread-selftests.c: Update include.
4822         * tui/tui-win.c: Update include.
4823         * tui/tui-io.c: Update include.
4824         * tui/tui-interp.c: Update include.
4825         * tui/tui-hooks.c: Update include.
4826         * top.h: Update include.
4827         * top.c: Update include.
4828         * ser-base.c: Update include.
4829         * remote.c: Update include.
4830         * remote-notif.c: Update include.
4831         * remote-fileio.c: Update include.
4832         * record-full.c: Update include.
4833         * record-btrace.c: Update include.
4834         * python/python.c: Update include.
4835         * posix-hdep.c: Update include.
4836         * mingw-hdep.c: Update include.
4837         * mi/mi-main.c: Update include.
4838         * mi/mi-interp.c: Update include.
4839         * main.c: Update include.
4840         * linux-nat.c: Update include.
4841         * interps.c: Update include.
4842         * infrun.c: Update include.
4843         * inf-loop.c: Update include.
4844         * event-top.c: Update include.
4845         * event-loop.c: Move to ../gdbsupport/.
4846         * event-loop.h: Move to ../gdbsupport/.
4847         * async-event.h: Update include.
4848         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
4849
4850 2020-04-13  Tom Tromey  <tom@tromey.com>
4851
4852         * tui/tui-win.c: Include async-event.h.
4853         * remote.c: Include async-event.h.
4854         * remote-notif.c: Include async-event.h.
4855         * record-full.c: Include async-event.h.
4856         * record-btrace.c: Include async-event.h.
4857         * infrun.c: Include async-event.h.
4858         * event-top.c: Include async-event.h.
4859         * event-loop.h: Move some declarations to async-event.h.
4860         * event-loop.c: Don't include ser-event.h or top.h.  Move some
4861         code to async-event.c.
4862         * async-event.h: New file.
4863         * async-event.c: New file.
4864         * Makefile.in (COMMON_SFILES): Add async-event.c.
4865         (HFILES_NO_SRCDIR): Add async-event.h.
4866
4867 2020-04-13  Tom Tromey  <tom@tromey.com>
4868
4869         * utils.c (flush_streams): New function.
4870         * event-loop.c (gdb_wait_for_event): Call flush_streams.
4871
4872 2020-04-13  Tom Tromey  <tom@tromey.com>
4873
4874         * event-loop.c (handle_file_event): Use warning, not
4875         printf_unfiltered.
4876
4877 2020-04-13  Tom Tromey  <tom@tromey.com>
4878
4879         * event-loop.c: Include <chrono>.
4880
4881 2020-04-13  Tom Tromey  <tom@tromey.com>
4882
4883         * gdb_select.h: Move to ../gdbsupport/.
4884         * event-loop.c: Update include path.
4885         * top.c: Update include path.
4886         * ser-base.c: Update include path.
4887         * ui-file.c: Update include path.
4888         * ser-tcp.c: Update include path.
4889         * guile/scm-ports.c: Update include path.
4890         * posix-hdep.c: Update include path.
4891         * ser-unix.c: Update include path.
4892         * gdb_usleep.c: Update include path.
4893         * mingw-hdep.c: Update include path.
4894         * inflow.c: Update include path.
4895         * infrun.c: Update include path.
4896         * event-top.c: Update include path.
4897
4898 2020-04-13  Tom Tromey  <tom@tromey.com>
4899
4900         * configure: Rebuild.
4901         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
4902
4903 2020-04-13  Tom Tromey  <tom@tromey.com>
4904
4905         * event-loop.h (start_event_loop): Don't declare.
4906         * event-loop.c (start_event_loop): Move...
4907         * main.c (start_event_loop): ...here.  Now static.
4908
4909 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
4910
4911         * MAINTAINERS: Update my email address.
4912
4913 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4914
4915         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
4916         IP_ALL.
4917
4918 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4919
4920         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
4921         (nbsd_nat_target::info_proc): Add do_cmdline.
4922
4923 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4924
4925         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
4926         (nbsd_nat_target::info_proc): Add do_cwd.
4927
4928 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
4929
4930         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
4931
4932 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
4933
4934         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
4935         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
4936         (nbsd_nat_target::info_proc): New functions.
4937         * nbsd-nat.c (kinfo_get_vmmap): New function.
4938         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
4939         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
4940         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
4941         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
4942         functions.
4943         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
4944         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
4945         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
4946         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
4947         (KINFO_VME_FLAG_GROWS_DOWN): New.
4948
4949 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
4950
4951         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
4952         bit shift.
4953
4954 2020-04-10  Tom Tromey  <tromey@adacore.com>
4955
4956         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
4957
4958 2020-04-10  Tom Tromey  <tromey@adacore.com>
4959
4960         * symtab.c (get_symbol_address, get_msymbol_address): Skip
4961         separate debug files.
4962
4963 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
4964
4965         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4966         Move to...
4967         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
4968         ... here.
4969         * windows-nat.c (windows_nat_target::get_windows_debug_event):
4970         Check for STATUS_WX86_BREAKPOINT.
4971         (windows_nat_target::wait): Same.
4972
4973 2020-04-10  Tom de Vries  <tdevries@suse.de>
4974
4975         PR cli/25808
4976         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
4977
4978 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
4979
4980         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
4981         (Write After Approval): Remove Tom de Vries.
4982
4983 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4984
4985         revert partially:
4986         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
4987
4988         * buildsym.c (record_line): Fix undefined behavior and preserve
4989         lines at eof.
4990
4991 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
4992
4993         * auxv.h (svr4_auxv_parse): New.
4994         * auxv.c (default_auxv_parse): Split into default_auxv_parse
4995         and generic_auxv_parse.
4996         (svr4_auxv_parse): Add.
4997         * obsd-tdep.c: Include "auxv.h".
4998         (obsd_auxv_parse): Remove.
4999         (obsd_init_abi): Remove comment.
5000         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
5001         from `obsd_auxv_parse' to `svr4_auxv_parse'.
5002         * nbsd-tdep.c: Include "auxv.h".
5003         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
5004
5005 2020-04-08  Tom Tromey  <tromey@adacore.com>
5006
5007         * nat/windows-nat.h (last_wait_event): Don't declare.
5008         (wait_for_debug_event): Update comment.
5009         * nat/windows-nat.c (last_wait_event): Now static.
5010
5011 2020-04-08  Tom Tromey  <tromey@adacore.com>
5012
5013         * windows-nat.c (wait_for_debug_event): Move to
5014         nat/windows-nat.c.
5015         * nat/windows-nat.h (wait_for_debug_event): Declare.
5016         * nat/windows-nat.c (wait_for_debug_event): Move from
5017         windows-nat.c.  No longer static.
5018
5019 2020-04-08  Tom Tromey  <tromey@adacore.com>
5020
5021         * windows-nat.c (get_windows_debug_event): Use
5022         fetch_pending_stop.
5023         * nat/windows-nat.h (fetch_pending_stop): Declare.
5024         * nat/windows-nat.c (fetch_pending_stop): New function.
5025
5026 2020-04-08  Tom Tromey  <tromey@adacore.com>
5027
5028         * windows-nat.c (windows_continue): Use matching_pending_stop and
5029         continue_last_debug_event.
5030         * nat/windows-nat.h (matching_pending_stop)
5031         (continue_last_debug_event): Declare.
5032         * nat/windows-nat.c (DEBUG_EVENTS): New define.
5033         (matching_pending_stop, continue_last_debug_event): New
5034         functions.
5035
5036 2020-04-08  Tom Tromey  <tromey@adacore.com>
5037
5038         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
5039         (handle_exception_result): Move to nat/windows-nat.h.
5040         (DEBUG_EXCEPTION_SIMPLE): Remove.
5041         (windows_nat::handle_ms_vc_exception): New function.
5042         (handle_exception): Move to nat/windows-nat.c.
5043         (get_windows_debug_event): Update.
5044         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
5045         nat/windows-nat.c.
5046         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
5047         (handle_exception_result): Move from windows-nat.c.
5048         (handle_exception): Declare.
5049         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
5050         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
5051         windows-nat.c.
5052
5053 2020-04-08  Tom Tromey  <tromey@adacore.com>
5054
5055         * windows-nat.c (exception_count, event_count): Remove.
5056         (handle_exception, get_windows_debug_event)
5057         (do_initial_windows_stuff): Update.
5058
5059 2020-04-08  Tom Tromey  <tromey@adacore.com>
5060
5061         * windows-nat.c (windows_nat::handle_load_dll)
5062         (windows_nat::handle_unload_dll): Rename.  No longer static.
5063         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
5064         Declare.
5065
5066 2020-04-08  Tom Tromey  <tromey@adacore.com>
5067
5068         * complaints.h (stop_whining): Declare at top-level.
5069         (complaint): Don't declare stop_whining.
5070
5071 2020-04-08  Tom Tromey  <tromey@adacore.com>
5072
5073         * windows-nat.c (windows_nat::handle_output_debug_string):
5074         Rename.  No longer static.
5075         * nat/windows-nat.h (handle_output_debug_string): Declare.
5076
5077 2020-04-08  Tom Tromey  <tromey@adacore.com>
5078
5079         * windows-nat.c (current_process_handle, current_process_id)
5080         (main_thread_id, last_sig, current_event, last_wait_event)
5081         (current_windows_thread, desired_stop_thread_id, pending_stops)
5082         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
5083         (display_selectors, fake_create_process)
5084         (get_windows_debug_event): Update.
5085         * nat/windows-nat.h (current_process_handle, current_process_id)
5086         (main_thread_id, last_sig, current_event, last_wait_event)
5087         (current_windows_thread, desired_stop_thread_id, pending_stops)
5088         (struct pending_stop, siginfo_er): Move from windows-nat.c.
5089         * nat/windows-nat.c (current_process_handle, current_process_id)
5090         (main_thread_id, last_sig, current_event, last_wait_event)
5091         (current_windows_thread, desired_stop_thread_id, pending_stops)
5092         (siginfo_er): New globals.  Move from windows-nat.c.
5093
5094 2020-04-08  Tom Tromey  <tromey@adacore.com>
5095
5096         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
5097         (handle_load_dll): Update.
5098         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
5099
5100 2020-04-08  Tom Tromey  <tromey@adacore.com>
5101
5102         * windows-nat.c (enum thread_disposition_type): Move to
5103         nat/windows-nat.h.
5104         (windows_nat::thread_rec): Rename from thread_rec.  No longer
5105         static.
5106         (windows_add_thread, windows_nat_target::fetch_registers)
5107         (windows_nat_target::store_registers, handle_exception)
5108         (windows_nat_target::resume, get_windows_debug_event)
5109         (windows_nat_target::get_tib_address)
5110         (windows_nat_target::thread_name)
5111         (windows_nat_target::thread_alive): Update.
5112         * nat/windows-nat.h (enum thread_disposition_type): Move from
5113         windows-nat.c.
5114         (thread_rec): Declare.
5115
5116 2020-04-08  Tom Tromey  <tromey@adacore.com>
5117
5118         * windows-nat.c: Add "using namespace".
5119         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
5120         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
5121
5122 2020-04-08  Tom Tromey  <tromey@adacore.com>
5123
5124         * nat/windows-nat.h (struct windows_thread_info): Declare
5125         destructor.
5126         * nat/windows-nat.c (~windows_thread_info): New.
5127
5128 2020-04-08  Tom Tromey  <tromey@adacore.com>
5129
5130         PR gdb/22992
5131         * windows-nat.c (current_event): Update comment.
5132         (last_wait_event, desired_stop_thread_id): New globals.
5133         (struct pending_stop): New.
5134         (pending_stops): New global.
5135         (windows_nat_target) <stopped_by_sw_breakpoint>
5136         <supports_stopped_by_sw_breakpoint>: New methods.
5137         (windows_fetch_one_register): Add assertions.  Adjust PC.
5138         (windows_continue): Handle pending stops.  Suspend other threads
5139         when stepping.  Use last_wait_event
5140         (wait_for_debug_event): New function.
5141         (get_windows_debug_event): Use wait_for_debug_event.  Handle
5142         pending stops.  Queue spurious stops.
5143         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
5144         (windows_nat_target::kill): Use wait_for_debug_event.
5145         * nat/windows-nat.h (struct windows_thread_info)
5146         <stopped_at_software_breakpoint>: New field.
5147         * nat/windows-nat.c (windows_thread_info::resume): Clear
5148         stopped_at_software_breakpoint.
5149
5150 2020-04-08  Tom Tromey  <tromey@adacore.com>
5151
5152         * windows-nat.c (enum thread_disposition_type): New.
5153         (thread_rec): Replace "get_context" parameter with "disposition";
5154         change type.
5155         (windows_add_thread, windows_nat_target::fetch_registers)
5156         (windows_nat_target::store_registers, handle_exception)
5157         (windows_nat_target::resume, get_windows_debug_event)
5158         (windows_nat_target::get_tib_address)
5159         (windows_nat_target::thread_name)
5160         (windows_nat_target::thread_alive): Update.
5161
5162 2020-04-08  Tom Tromey  <tromey@adacore.com>
5163
5164         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
5165         (windows_continue): Use windows_continue::resume.
5166         * nat/windows-nat.h (struct windows_thread_info) <suspend,
5167         resume>: Declare new methods.
5168         * nat/windows-nat.c: New file.
5169         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
5170
5171 2020-04-08  Tom Tromey  <tromey@adacore.com>
5172
5173         * windows-nat.c (windows_add_thread, windows_delete_thread)
5174         (windows_nat_target::fetch_registers)
5175         (windows_nat_target::store_registers, fake_create_process)
5176         (windows_nat_target::resume, windows_nat_target::resume)
5177         (get_windows_debug_event, windows_nat_target::wait)
5178         (windows_nat_target::pid_to_str)
5179         (windows_nat_target::get_tib_address)
5180         (windows_nat_target::get_ada_task_ptid)
5181         (windows_nat_target::thread_name)
5182         (windows_nat_target::thread_alive): Use lwp, not tid.
5183
5184 2020-04-08  Tom Tromey  <tromey@adacore.com>
5185
5186         * windows-nat.c (handle_exception)
5187         (windows_nat_target::thread_name): Update.
5188         * nat/windows-nat.h (windows_thread_info): Remove destructor.
5189         <name>: Now unique_xmalloc_ptr.
5190
5191 2020-04-08  Tom Tromey  <tromey@adacore.com>
5192
5193         * windows-nat.c (thread_rec)
5194         (windows_nat_target::fetch_registers): Update.
5195         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
5196         Update comment.
5197         <debug_registers_changed, reload_context>: Now bool.
5198
5199 2020-04-08  Tom Tromey  <tromey@adacore.com>
5200
5201         * windows-nat.c (windows_add_thread): Use new.
5202         (windows_init_thread_list, windows_delete_thread): Use delete.
5203         (get_windows_debug_event): Update.
5204         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
5205         destructor, and initializers.
5206
5207 2020-04-08  Tom Tromey  <tromey@adacore.com>
5208
5209         * windows-nat.c (struct windows_thread_info): Remove.
5210         * nat/windows-nat.h: New file.
5211
5212 2020-04-08  Tom Tromey  <tromey@adacore.com>
5213
5214         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
5215         (thread_rec, windows_add_thread, windows_delete_thread)
5216         (windows_continue): Update.
5217
5218 2020-04-08  Tom Tromey  <tromey@adacore.com>
5219
5220         * windows-nat.c (struct windows_thread_info): Remove typedef.
5221         (thread_head): Remove.
5222         (thread_list): New global.
5223         (thread_rec, windows_add_thread, windows_init_thread_list)
5224         (windows_delete_thread, windows_continue): Update.
5225
5226 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5227
5228         * windows-tdep.h (windows_init_abi): Add comment.
5229         (cygwin_init_abi): New declaration.
5230         * windows-tdep.c: Split signal enumeration in two, one for
5231         Windows and one for Cygwin.
5232         (windows_gdb_signal_to_target): Only deal with signal of the
5233         Windows OS ABI.
5234         (cygwin_gdb_signal_to_target): New function.
5235         (windows_init_abi): Rename to windows_init_abi_common, don't set
5236         gdb_signal_to_target gdbarch method.  Add new new function with
5237         this name.
5238         (cygwin_init_abi): New function.
5239         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
5240         comment.  Don't call windows_init_abi.
5241         (amd64_windows_init_abi): Add comment, call windows_init_abi.
5242         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
5243         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
5244         i386_windows_init_abi_common, don't call windows_init_abi.  Add
5245         a new function of this name.
5246         (i386_cygwin_init_abi): New function.
5247         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
5248         OS ABI Cygwin.
5249
5250 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
5251
5252         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
5253         parameter.c.
5254         (dwarf2_read_gdb_index): Update.
5255
5256 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
5257
5258         * nbsd-tdep.c: Include "objfiles.h".
5259         (nbsd_skip_solib_resolver): New.
5260         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
5261
5262 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5263
5264         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
5265         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
5266         with DW_LLE_base_addressx are being emitted in DWARFv5.
5267         Add the newly added kind DW_LOC_OFFSET_PAIR also.
5268         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
5269         unsigned integer.
5270
5271 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5272
5273         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
5274         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
5275         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
5276         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
5277         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
5278         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
5279         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
5280
5281
5282 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
5283
5284         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
5285         (read_loclist_index): New function definition.
5286         (lookup_loclist_base): New function definition.
5287         (read_loclist_header): New function definition.
5288         (dwarf2_cu): Add loclist_base and loclist_header field.
5289         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
5290         (read_full_die_1): Read the value of DW_AT_loclists_base.
5291         (read_attribute_reprocess): Handle DW_FORM_loclistx.
5292         (read_attribute_value): Handle DW_FORM_loclistx.
5293         (skip_one_die): Handle DW_FORM_loclistx.
5294         (loclist_header): New structure declaration.
5295         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
5296
5297 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
5298
5299         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
5300         constructor.  Remove `addr` parameter from other constructor and
5301         add `per_cu` parameter.
5302         * dwarf2/read.c (create_partial_symtab): Update.
5303
5304 2020-04-07  Tom de Vries  <tdevries@suse.de>
5305
5306         PR symtab/25796
5307         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
5308         (partial_die_info::fixup): Inherit has_const_value.
5309
5310 2020-04-07  Tom de Vries  <tdevries@suse.de>
5311
5312         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
5313         symbols without address.
5314
5315 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5316
5317         * nbsd-nat.h (struct thread_info): Add forward declaration.
5318         (nbsd_nat_target::thread_alive): Add.
5319         (nbsd_nat_target::thread_name): Likewise.
5320         (nbsd_nat_target::update_thread_list): Likewise.
5321         (update_thread_list::post_attach): Likewise.
5322         (post_attach::pid_to_str): Likewise.
5323         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
5324         (nbsd_thread_lister): Add.
5325         (nbsd_nat_target::thread_alive): Likewise.
5326         (nbsd_nat_target::thread_name): Likewise.
5327         (nbsd_add_threads): Likewise.
5328         (update_thread_list::post_attach): Likewise.
5329         (nbsd_nat_target::update_thread_list): Likewise.
5330         (post_attach::pid_to_str): Likewise.
5331
5332 2020-04-06  Tom Tromey  <tromey@adacore.com>
5333
5334         * ada-valprint.c (print_variant_part): Extract the variant field.
5335         (print_field_values): Use the field as the outer value when
5336         recursing.
5337
5338 2020-04-06  Tom Tromey  <tromey@adacore.com>
5339
5340         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
5341         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
5342         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
5343         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
5344         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
5345
5346 2020-04-06  Tom Tromey  <tromey@adacore.com>
5347
5348         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
5349         TYPE_CODE_ERROR.
5350
5351 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
5352
5353         * nbsd-tdep.c: Include "gdbarch.h".
5354         Define enum with NetBSD signal numbers.
5355         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
5356         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
5357         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
5358         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
5359         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
5360         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
5361         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
5362         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
5363         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
5364         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
5365         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
5366         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
5367
5368 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
5369
5370         PR gdb/25325
5371         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
5372
5373 2020-04-03  Tom Tromey  <tromey@adacore.com>
5374
5375         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
5376         Read constant block.
5377
5378 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5379
5380         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
5381         (gdb_bfd_get_full_section_contents): New declaration.
5382         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
5383         * windows-tdep.c (is_linked_with_cygwin_dll): Use
5384         gdb_bfd_get_full_section_contents.
5385
5386 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
5387
5388         * exec.c (build_section_table): Replace internal_error with
5389         gdb_assert.
5390         (section_table_xfer_memory_partial): Likewise.
5391         * mdebugread.c (parse_partial_symbols): Likewise.
5392         * psymtab.c (lookup_partial_symbol): Likewise.
5393         * utils.c (wrap_here): Likewise.
5394
5395 2020-04-02  Tom Tromey  <tromey@adacore.com>
5396
5397         * f-lang.c (build_fortran_types): Use arch_type to initialize
5398         builtin_complex_s32 in the TYPE_CODE_ERROR case.
5399
5400 2020-04-02  Tom Tromey  <tromey@adacore.com>
5401
5402         * dwarf2/read.c (partial_die_info::read): Do not create a vector
5403         of attributes.
5404
5405 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
5406             Bernd Edlinger <bernd.edlinger@hotmail.de>
5407             Tom Tromey  <tromey@adacore.com>
5408
5409         * buildsym.c (buildsym_compunit::record_line): Remove
5410         deduplication code.
5411
5412 2020-04-02  Tom de Vries  <tdevries@suse.de>
5413
5414         PR ada/24671
5415         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
5416
5417 2020-04-02  Tom de Vries  <tdevries@suse.de>
5418
5419         * dwarf2/read.c (dwarf2_gdb_index_functions,
5420         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
5421         NULL.
5422         * psymtab.c (psym_lookup_global_symbol_language): New function.
5423         (psym_functions): Init psym_lookup_global_symbol_language with
5424         psym_lookup_global_symbol_language.
5425         * symfile-debug.c (debug_sym_quick_functions): Init
5426         lookup_global_symbol_language with NULL.
5427         * symfile.c (set_initial_language): Remove fixme comment.
5428         * symfile.h (struct quick_symbol_functions): Add
5429         lookup_global_symbol_language.
5430         * symtab.c (find_quick_global_symbol_language): New function.
5431         (find_main_name): Use find_quick_global_symbol_language.
5432
5433 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
5434
5435         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
5436
5437 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5438
5439         * buildsym.c (record_line): Fix undefined behavior and preserve
5440         lines at eof.
5441
5442 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5443
5444         * buildsym.c (record_line): Fix the resizing condition.
5445
5446 2020-04-01  Tom Tromey  <tom@tromey.com>
5447
5448         * value.h (value_literal_complex): Add comment.
5449         * valops.c (value_literal_complex): Refer to value.h.
5450
5451 2020-04-01  Tom Tromey  <tom@tromey.com>
5452
5453         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
5454         (scalar_type): New rule, from typebase.
5455         (typebase): Use scalar_type.  Recognize complex types.
5456         (field_name): Handle FLOAT_KEYWORD.
5457         (ident_tokens): Add _Complex and __complex__.
5458
5459 2020-04-01  Tom Tromey  <tom@tromey.com>
5460
5461         PR exp/25299:
5462         * valarith.c (promotion_type, complex_binop): New functions.
5463         (scalar_binop): Handle complex numbers.  Use promotion_type.
5464         (value_pos, value_neg, value_complement): Handle complex numbers.
5465
5466 2020-04-01  Tom Tromey  <tom@tromey.com>
5467
5468         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
5469         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
5470         (parse_number): Handle complex numbers.
5471
5472 2020-04-01  Tom Tromey  <tom@tromey.com>
5473
5474         * c-valprint.c (c_decorations): Change complex suffix to "i".
5475
5476 2020-04-01  Tom Tromey  <tom@tromey.com>
5477
5478         * valprint.c (generic_value_print_complex): Use accessors.
5479         * value.h (value_real_part, value_imaginary_part): Declare.
5480         * valops.c (value_real_part, value_imaginary_part): New
5481         functions.
5482         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
5483
5484 2020-04-01  Tom Tromey  <tom@tromey.com>
5485
5486         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
5487         (read_range_type): Update.
5488         * mdebugread.c (basic_type): Update.
5489         * go-lang.c (build_go_types): Use init_complex_type.
5490         * gdbtypes.h (struct main_type) <complex_type>: New member.
5491         (init_complex_type): Update.
5492         (arch_complex_type): Don't declare.
5493         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
5494         Make name if none given.  Use alloc_type_copy.  Look for cached
5495         complex type.
5496         (arch_complex_type): Remove.
5497         (gdbtypes_post_init): Use init_complex_type.
5498         * f-lang.c (build_fortran_types): Use init_complex_type.
5499         * dwarf2/read.c (read_base_type): Update.
5500         * d-lang.c (build_d_types): Use init_complex_type.
5501         * ctfread.c (read_base_type): Update.
5502
5503 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5504
5505         * infrun.c (stop_all_threads): Update assertion, plus when
5506         stopping threads, take into account that we might be trying
5507         to stop an all-stop target.
5508         (stop_waiting): Call 'stop_all_threads' if there exists a
5509         non-stop target.
5510
5511 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5512
5513         * target.h (exists_non_stop_target): New function declaration.
5514         * target.c (exists_non_stop_target): New function.
5515
5516 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
5517
5518         PR gdb/24789
5519         * eval.c (is_integral_or_integral_reference): New function.
5520         (evaluate_subexp_standard): Allow integer references in
5521         pointer arithmetic.
5522
5523 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
5524
5525         * remote.c (remote_target::remote_parse_stop_reply): Remove the
5526         check for no ptid in the stop reply when the target is non-stop.
5527
5528 2020-04-01  Tom Tromey  <tromey@adacore.com>
5529
5530         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
5531         "name" parameter to rvalue reference.  Initialize m_name_holder.
5532         <lookup_name_info>: New overloads.
5533         <name>: Return gdb::string_view.
5534         <c_str>: New method.
5535         <make_ignore_params>: Update.
5536         <search_name_hash>: Update.
5537         <language_lookup_name>: Return const char *.
5538         <m_name>: Change type.
5539         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
5540         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
5541         (lookup_name_info::match_any): Update.
5542         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
5543         Update.
5544         * minsyms.c (linkage_name_str): Update.
5545         * language.c (default_symbol_name_matcher): Update.
5546         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
5547         Update.
5548         * ada-lang.c (ada_fold_name): Change parameter to string_view.
5549         (ada_lookup_name_info::ada_lookup_name_info): Update.
5550         (literal_symbol_name_matcher): Update.
5551
5552 2020-04-01  Tom Tromey  <tromey@adacore.com>
5553
5554         * psymtab.c (psymtab_search_name): Remove function.
5555         (psym_lookup_symbol): Create search name and lookup name here.
5556         (lookup_partial_symbol): Remove "name" parameter; add
5557         lookup_name.
5558         (psym_expand_symtabs_for_function): Update.
5559
5560 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
5561
5562         PR tui/25597:
5563         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
5564
5565 2020-03-31  Tom Tromey  <tromey@adacore.com>
5566
5567         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
5568         memcpy.
5569
5570 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
5571
5572         * features/riscv/32bit-csr.xml: Regenerated.
5573         * features/riscv/64bit-csr.xml: Regenerated.
5574
5575 2020-03-30  Tom Tromey  <tromey@adacore.com>
5576
5577         * ada-valprint.c (print_variant_part): Update.
5578         * ada-lang.h (ada_which_variant_applies): Update.
5579         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
5580         outer_valaddr parameters; replace with "outer" value parameter.
5581         (to_fixed_variant_branch_type): Update.
5582
5583 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5584
5585         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
5586         <list>.  Remove inclusion of observable.h.
5587         (PPC_DEBUG_CURRENT_VERSION): Move up define.
5588         (struct arch_lwp_info): New struct.
5589         (class ppc_linux_dreg_interface): New class.
5590         (struct ppc_linux_process_info): New struct.
5591         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
5592         <low_new_clone, low_forget_process, low_prepare_to_resume>
5593         <copy_thread_dreg_state, mark_thread_stale>
5594         <mark_debug_registers_changed, register_hw_breakpoint>
5595         <clear_hw_breakpoint, register_wp, clear_wp>
5596         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
5597         <num_memory_accesses, get_trigger_type>
5598         <create_watchpoint_request, hwdebug_point_cmp>
5599         <init_arch_lwp_info, get_arch_lwp_info>
5600         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
5601         methods.
5602         <struct ptid_hash>: New inner struct.
5603         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
5604         members.
5605         (saved_dabr_value, hwdebug_info, max_slots_number)
5606         (struct hw_break_tuple, struct thread_points, ppc_threads)
5607         (have_ptrace_hwdebug_interface)
5608         (hwdebug_find_thread_points_by_tid)
5609         (hwdebug_insert_point, hwdebug_remove_point): Remove.
5610         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
5611         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
5612         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
5613         use m_dreg_interface.
5614         (hwdebug_point_cmp): Change to...
5615         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
5616         reference arguments instead of pointers.
5617         (ppc_linux_nat_target::ranged_break_num_registers): Use
5618         m_dreg_interface.
5619         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
5620         m_dreg_interface.  Call register_hw_breakpoint.
5621         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
5622         m_dreg_interface.  Call clear_hw_breakpoint.
5623         (get_trigger_type): Change to...
5624         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
5625         comment.
5626         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
5627         use m_dreg_interface.  Call register_hw_breakpoint.
5628         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
5629         use m_dreg_interface.  Call clear_hw_breakpoint.
5630         (can_use_watchpoint_cond_accel): Change to...
5631         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
5632         method.  Update comment, use m_dreg_interface and
5633         m_process_info.
5634         (calculate_dvc): Change to...
5635         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
5636         m_dreg_interface.
5637         (num_memory_accesses): Change to...
5638         (ppc_linux_nat_target::num_memory_accesses): ...this method.
5639         (check_condition): Change to...
5640         (ppc_linux_nat_target::check_condition): ...this method.
5641         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
5642         comment, use m_dreg_interface.
5643         (create_watchpoint_request): Change to...
5644         (ppc_linux_nat_target::create_watchpoint_request): ...this
5645         method.  Use m_dreg_interface.
5646         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
5647         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
5648         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
5649         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
5650         (ppc_linux_nat_target::low_forget_process)
5651         (ppc_linux_nat_target::low_new_fork)
5652         (ppc_linux_nat_target::low_new_clone)
5653         (ppc_linux_nat_target::low_delete_thread)
5654         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
5655         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
5656         only call mark_thread_stale.
5657         (ppc_linux_thread_exit): Remove.
5658         (ppc_linux_nat_target::stopped_data_address): Change to...
5659         (ppc_linux_nat_target::low_stopped_data_address): This. Add
5660         comment, use m_dreg_interface and m_thread_hw_breakpoints.
5661         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
5662         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
5663         comment.  Call low_stopped_data_address.
5664         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
5665         m_dreg_interface.
5666         (ppc_linux_nat_target::masked_watch_num_registers): Use
5667         m_dreg_interface.
5668         (ppc_linux_nat_target::copy_thread_dreg_state)
5669         (ppc_linux_nat_target::mark_thread_stale)
5670         (ppc_linux_nat_target::mark_debug_registers_changed)
5671         (ppc_linux_nat_target::register_hw_breakpoint)
5672         (ppc_linux_nat_target::clear_hw_breakpoint)
5673         (ppc_linux_nat_target::register_wp)
5674         (ppc_linux_nat_target::clear_wp)
5675         (ppc_linux_nat_target::init_arch_lwp_info)
5676         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
5677         (_initialize_ppc_linux_nat): Remove observer callback.
5678
5679 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5680
5681         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
5682         (ppc_linux_nat_target::auxv_parse)
5683         (ppc_linux_nat_target::read_description)
5684         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
5685         Move up.
5686
5687 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
5688
5689         * linux-nat.h (low_new_clone): New method.
5690         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
5691
5692 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5693
5694         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
5695         (dbx_expand_psymtab): ... this.
5696         (start_psymtab): Update.
5697         * mdebugread.c (psymtab_to_symtab_1): Rename to...
5698         (mdebug_expand_psymtab): ... this.
5699         (parse_partial_symbols): Update.
5700         (new_psymtab): Update.
5701         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
5702         (xcoff_expand_psymtab): ... this.
5703         (xcoff_start_psymtab): Update.
5704
5705 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5706
5707         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
5708         <expand_dependencies>: ... this.
5709         * psymtab.c (partial_symtab::read_dependencies): Rename to...
5710         (partial_symtab::expand_dependencies): ... this.
5711         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
5712         Update.
5713         (dwarf2_psymtab::expand_psymtab): Update.
5714         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5715         * mdebugread.c (psymtab_to_symtab_1): Update.
5716         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5717
5718 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
5719
5720         * psympriv.h (discard_psymtab): Remove.
5721         * dbxread.c (dbx_end_psymtab): Update.
5722         * xcoffread.c (xcoff_end_psymtab): Update.
5723
5724 2020-03-28  Tom Tromey  <tom@tromey.com>
5725
5726         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
5727         comment.
5728
5729 2020-03-28  Tom Tromey  <tom@tromey.com>
5730
5731         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
5732
5733 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
5734
5735         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5736
5737 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
5738
5739         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
5740
5741 2020-03-26  Tom Tromey  <tom@tromey.com>
5742
5743         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
5744         (mark_common_block_symbol_computed, read_tag_string_type)
5745         (attr_to_dynamic_prop, read_subrange_type): Update.
5746         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
5747         to be methods on struct attribute.
5748         (skip_one_die, process_imported_unit_die, read_namespace_alias)
5749         (read_call_site_scope, partial_die_info::read)
5750         (partial_die_info::read, lookup_die_type, follow_die_ref):
5751         Update.
5752         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
5753         from dwarf2_get_ref_die_offset.
5754         (attribute::constant_value): New method, from
5755         dwarf2_get_attr_constant_value.
5756         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
5757         Declare method.
5758         <constant_value>: New method.
5759
5760 2020-03-26  Tom Tromey  <tom@tromey.com>
5761
5762         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
5763         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
5764         (dwarf_type_encoding_name): Move to stringify.c.
5765         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
5766         * dwarf2/stringify.c: New file.
5767         * dwarf2/stringify.h: New file.
5768
5769 2020-03-26  Tom Tromey  <tom@tromey.com>
5770
5771         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
5772         Rewrite.
5773
5774 2020-03-26  Tom Tromey  <tom@tromey.com>
5775
5776         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
5777         methods.
5778         * dwarf2/read.c (lookup_addr_base): Move to die.h.
5779         (lookup_ranges_base): Likewise.
5780         (read_cutu_die_from_dwo, read_full_die_1): Update.
5781
5782 2020-03-26  Tom Tromey  <tom@tromey.com>
5783
5784         * dwarf2/read.c (read_import_statement, read_file_scope)
5785         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
5786         (read_lexical_block_scope, read_call_site_scope)
5787         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
5788         (handle_struct_member_die, process_structure_scope)
5789         (update_enumeration_type_from_children)
5790         (process_enumeration_scope, read_array_type, read_common_block)
5791         (read_namespace, read_module, read_subroutine_type): Update.
5792         (sibling_die): Remove.
5793
5794 2020-03-26  Tom Tromey  <tom@tromey.com>
5795
5796         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
5797         (build_type_psymtabs_reader, read_structure_type)
5798         (read_enumeration_type, read_full_die_1): Update.
5799         (dwarf2_attr_no_follow): Move to die.h.
5800         * dwarf2/die.h (struct die_info) <attr>: New method.
5801
5802 2020-03-26  Tom Tromey  <tom@tromey.com>
5803
5804         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
5805         <base_address>: Now an optional.
5806         (dwarf2_find_base_address, dwarf2_rnglists_process)
5807         (dwarf2_ranges_process, fill_in_loclist_baton)
5808         (dwarf2_symbol_mark_computed): Update.
5809
5810 2020-03-26  Tom Tromey  <tom@tromey.com>
5811
5812         * dwarf2/read.c (struct die_info): Move to die.h.
5813         * dwarf2/die.h: New file.
5814
5815 2020-03-26  Tom Tromey  <tom@tromey.com>
5816
5817         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
5818         * dwarf2/read.c
5819         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5820         Move to line-header.c.
5821         (read_checked_initial_length_and_offset, read_formatted_entries):
5822         Likewise.
5823         (dwarf_decode_line_header): Split into two.
5824         * dwarf2/line-header.c
5825         (dwarf2_statement_list_fits_in_line_number_section_complaint):
5826         Move from read.c.
5827         (read_checked_initial_length_and_offset, read_formatted_entries):
5828         Likewise.
5829         (dwarf_decode_line_header): New function, split from read.c.
5830
5831 2020-03-26  Tom Tromey  <tom@tromey.com>
5832
5833         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
5834         Declare method.
5835         * dwarf2/read.c (read_attribute_value): Update.
5836         (dwarf2_per_objfile::read_line_string): Rename from
5837         read_indirect_line_string.
5838         (read_formatted_entries): Update.
5839
5840 2020-03-26  Tom Tromey  <tom@tromey.com>
5841
5842         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
5843         variable.
5844
5845 2020-03-26  Tom Tromey  <tom@tromey.com>
5846
5847         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
5848         const.
5849         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
5850         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
5851         parameter const.
5852
5853 2020-03-26  Tom Tromey  <tom@tromey.com>
5854
5855         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
5856         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
5857         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
5858         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
5859
5860 2020-03-26  Tom Tromey  <tom@tromey.com>
5861
5862         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
5863         file_names_size, file_full_name, file_file_name>: Use const.
5864         <file_name_at, file_names>: Add const overload.
5865         * dwarf2/line-header.c (line_header::file_file_name)
5866         (line_header::file_full_name): Update.
5867
5868 2020-03-26  Tom Tromey  <tom@tromey.com>
5869
5870         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
5871         (macro_start_file, consume_improper_spaces)
5872         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
5873         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
5874         (dwarf_decode_macros): Move to macro.c.
5875         * dwarf2/macro.c: New file.
5876         * dwarf2/macro.h: New file.
5877         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
5878
5879 2020-03-26  Tom Tromey  <tom@tromey.com>
5880
5881         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
5882         method.
5883         * dwarf2/section.c: New method.  From
5884         read_indirect_string_at_offset_from.
5885         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
5886         (read_indirect_string_at_offset_from): Move to section.c.
5887         (read_indirect_string_at_offset): Rewrite.
5888         (read_indirect_line_string_at_offset): Remove.
5889         (read_indirect_string, read_indirect_line_string)
5890         (dwarf_decode_macro_bytes): Update.
5891
5892 2020-03-26  Tom Tromey  <tom@tromey.com>
5893
5894         * dwarf2/section.h (struct dwarf2_section_info)
5895         <overload_complaint>: Declare.
5896         (dwarf2_section_buffer_overflow_complaint): Don't declare.
5897         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
5898         Rename from dwarf2_section_buffer_overflow_complaint.
5899         * dwarf2/read.c (skip_one_die, partial_die_info::read)
5900         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
5901
5902 2020-03-26  Tom Tromey  <tom@tromey.com>
5903
5904         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
5905         Declare.
5906         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
5907         Move from read.c.
5908         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
5909         to section.c.
5910
5911 2020-03-26  Tom Tromey  <tom@tromey.com>
5912
5913         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
5914
5915 2020-03-26  Tom Tromey  <tom@tromey.com>
5916
5917         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
5918         "builder".
5919         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
5920         parameter.
5921         (dwarf_decode_macros): Update.
5922
5923 2020-03-26  Tom Tromey  <tom@tromey.com>
5924
5925         * dwarf2/read.c (read_attribute_value): Update.
5926         (read_indirect_string_from_dwz): Move to dwz.c; change into
5927         method.
5928         (dwarf_decode_macro_bytes): Update.
5929         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
5930         * dwarf2/dwz.c: New file.
5931         * Makefile.in (COMMON_SFILES): Add dwz.c.
5932
5933 2020-03-26  Tom Tromey  <tom@tromey.com>
5934
5935         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
5936         * dwarf2/read.c: Add include.
5937         * dwarf2/index-write.c: Add include.
5938         * dwarf2/index-cache.c: Add include.
5939         * dwarf2/dwz.h: New file.
5940
5941 2020-03-25  Tom Tromey  <tom@tromey.com>
5942
5943         * compile/compile-object-load.c (get_out_value_type): Mention
5944         correct symbol name in error message.
5945
5946 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
5947
5948         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
5949
5950 2020-03-25  Tom de Vries  <tdevries@suse.de>
5951
5952         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
5953         * symmisc.c (dump_symtab_1): Print user and includes fields.
5954         (maintenance_info_symtabs): Same.
5955
5956 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
5957
5958         PR gdb/25534
5959         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
5960         (riscv_regcache_cooked_write): New function.
5961         (riscv_push_dummy_call): Use new function.
5962         (riscv_return_value): Likewise.
5963
5964 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
5965
5966         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
5967         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
5968         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
5969         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
5970         * infrun.c (follow_fork): Likewise.
5971         (follow_fork_inferior): Likewise.
5972         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
5973         * linux-nat.h (class linux_nat_target): Likewise.
5974         * remote.c (class remote_target) <follow_fork>: Likewise.
5975         (remote_target::follow_fork): Likewise.
5976         * target-delegates.c: Re-generate.
5977         * target.c (default_follow_fork): Likewise.
5978         (target_follow_fork): Likewise.
5979         * target.h (struct target_ops) <follow_fork>: Likewise.
5980         (target_follow_fork): Likewise.
5981
5982 2020-03-24  Tom de Vries  <tdevries@suse.de>
5983
5984         * psymtab.c (maintenance_info_psymtabs): Print user field.
5985
5986 2020-03-20  Tom Tromey  <tromey@adacore.com>
5987
5988         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
5989         const.
5990         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
5991         const.
5992
5993 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
5994
5995         * ptrace.m4: Don't check for ptrace declaration.
5996         * config.in: Re-generate.
5997         * configure: Re-generate.
5998         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
5999         not defined.
6000
6001 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6002
6003         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
6004         `PTRACE_TYPE_RET'.
6005         * i386-bsd-nat.c (gdb_ptrace): Likewise.
6006         * sparc-nat.c (gdb_ptrace): Likewise.
6007         * x86-bsd-nat.c (gdb_ptrace): Likewise.
6008
6009 2020-03-20  Tom Tromey  <tromey@adacore.com>
6010
6011         * c-exp.y (lex_one_token): Fix assert.
6012
6013 2020-03-20  Tom Tromey  <tromey@adacore.com>
6014
6015         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
6016         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
6017         strncpy call.
6018
6019 2020-03-20  Tom Tromey  <tromey@adacore.com>
6020
6021         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
6022
6023 2020-03-20  Tom Tromey  <tromey@adacore.com>
6024
6025         * ada-valprint.c (print_variant_part): Remove parameters; switch
6026         to value-based API.
6027         (print_field_values): Likewise.
6028         (ada_val_print_struct_union): Likewise.
6029         (ada_value_print_1): Update.
6030
6031 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6032
6033         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
6034         nbsd_nat_target instead of inf_ptrace_target.
6035         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6036         nbsd_nat_target.
6037
6038 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6039
6040         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
6041         it to the ptrace call.
6042         * (store_registers): Likewise.
6043
6044 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
6045
6046         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
6047         it to the ptrace call.
6048         * (store_registers): Likewise.
6049
6050 2020-03-19  Luis Machado  <luis.machado@linaro.org>
6051
6052         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
6053         valid, fetch vg value from ptrace.
6054
6055 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
6056         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
6057         * inf-ptrace.c: Likewise.
6058         * (gdb_ptrace): Add.
6059         * (inf_ptrace_target::resume): Update.
6060         * (inf_ptrace_target::xfer_partial): Likewise.
6061         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
6062         * (inf_ptrace_peek_poke): Update.
6063
6064 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
6065
6066         * x86-bsd-nat.c (gdb_ptrace): New.
6067         * (x86bsd_dr_set): Add new argument `ptid'.
6068         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
6069         x86bsd_dr_set_addr): Update.
6070
6071 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * remote.c (remote_target::process_stop_reply): Handle events for
6074         all threads differently.
6075
6076 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6077
6078         * completer.c (completion_tracker::remove_completion): Define new
6079         function.
6080         * completer.h (completion_tracker::remove_completion): Declare new
6081         function.
6082         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
6083         when adding a C++ function symbol.
6084
6085 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6086
6087         * completer.c (completion_tracker::completion_hash_entry): Define
6088         new class.
6089         (advance_to_filename_complete_word_point): Call
6090         recompute_lowest_common_denominator.
6091         (completion_tracker::completion_tracker): Call discard_completions
6092         to setup the hash table.
6093         (completion_tracker::discard_completions): Allow for being called
6094         from the constructor, pass new equal function, and element deleter
6095         when constructing the hash table.  Initialise new class member
6096         variables.
6097         (completion_tracker::maybe_add_completion): Remove use of
6098         m_entries_vec, and store more information into m_entries_hash.
6099         (completion_tracker::recompute_lcd_visitor): New function, most
6100         content taken from...
6101         (completion_tracker::recompute_lowest_common_denominator):
6102         ...here, this now just visits each item in the hash calling the
6103         above visitor.
6104         (completion_tracker::build_completion_result): Remove use of
6105         m_entries_vec, call recompute_lowest_common_denominator.
6106         * completer.h (completion_tracker::have_completions): Remove use
6107         of m_entries_vec.
6108         (completion_tracker::completion_hash_entry): Declare new class.
6109         (completion_tracker::recompute_lowest_common_denominator): Change
6110         function signature.
6111         (completion_tracker::recompute_lcd_visitor): Declare new function.
6112         (completion_tracker::m_entries_vec): Delete.
6113         (completion_tracker::m_entries_hash): Initialize to NULL.
6114         (completion_tracker::m_lowest_common_denominator_valid): New
6115         member variable.
6116         (completion_tracker::m_lowest_common_denominator_max_length): New
6117         member variable.
6118
6119 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6120
6121         * regformats/regdef.h: Put reg in gdb namespace.
6122
6123 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6124
6125         * i386-bsd-nat.c (gdb_ptrace): New.
6126         * (i386bsd_fetch_inferior_registers,
6127         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6128         * (i386bsd_fetch_inferior_registers,
6129         i386bsd_store_inferior_registers) Use gdb_ptrace.
6130
6131 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6132
6133         * amd64-bsd-nat.c (gdb_ptrace): New.
6134         * (amd64bsd_fetch_inferior_registers,
6135         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
6136         * (amd64bsd_fetch_inferior_registers,
6137         amd64bsd_store_inferior_registers) Use gdb_ptrace.
6138
6139 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6140
6141         * user-regs.c (user_reg::read): Rename to...
6142         (user_reg::xread): ...this.
6143         * (append_user_reg): Rename argument `read' to `xread'.
6144         * (user_reg_add_builtin): Likewise.
6145         * (user_reg_add): Likewise.
6146         * (value_of_user_reg): Likewise.
6147
6148 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6149
6150         * sparc-nat.c (gdb_ptrace): New.
6151         * sparc-nat.c (sparc_fetch_inferior_registers)
6152         (sparc_store_inferior_registers) Remove obsolete comment.
6153         * sparc-nat.c (sparc_fetch_inferior_registers)
6154         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
6155         * sparc-nat.c (sparc_fetch_inferior_registers)
6156         (sparc_store_inferior_registers) Use gdb_ptrace.
6157
6158 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6159
6160         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
6161         it to the ptrace call.
6162         * sh-nbsd-nat.c (store_registers): Likewise.
6163
6164 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6165
6166         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
6167         nbsd_nat_target instead of inf_ptrace_target.
6168         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6169         nbsd_nat_target.
6170
6171 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6172
6173         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
6174
6175 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
6176
6177         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
6178         <sys/sysctl.h>.
6179         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
6180
6181 2020-03-17  Tom de Vries  <tdevries@suse.de>
6182
6183         PR gdb/23710
6184         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
6185         fields.
6186         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
6187         fields.
6188         (process_imported_unit_die): Skip import of c++ CUs.
6189
6190 2020-03-16  Tom Tromey  <tom@tromey.com>
6191
6192         * p-valprint.c (pascal_object_print_value): Initialize
6193         base_value.
6194
6195 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
6196             Shahab Vahedi  <shahab@synopsys.com>
6197
6198         * Makefile.in: Add arch/arc.o
6199         * configure.tgt: Likewise.
6200         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
6201         (_initialize_arc_tdep): Don't initialize old target descriptions.
6202         (arc_read_description): New function to cache target descriptions.
6203         * arc-tdep.h (arc_read_description): Add proto type.
6204         * arch/arc.c: New file.
6205         * arch/arc.h: Likewise.
6206         * features/Makefile: Replace old target descriptions with new.
6207         * features/arc-arcompact.c: Remove.
6208         * features/arc-arcompact.xml: Likewise.
6209         * features/arc-v2.c: Likewise
6210         * features/arc-v2.xml: Likewise
6211         * features/arc/aux-arcompact.xml: New file.
6212         * features/arc/aux-v2.xml: Likewise.
6213         * features/arc/core-arcompact.xml: Likewise.
6214         * features/arc/core-v2.xml: Likewise.
6215         * features/arc/aux-arcompact.c: Generate.
6216         * features/arc/aux-v2.c: Likewise.
6217         * features/arc/core-arcompact.c: Likewise.
6218         * features/arc/core-v2.c: Likewise.
6219         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
6220
6221 2020-03-16  Tom Tromey  <tromey@adacore.com>
6222
6223         PR gdb/25663:
6224         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
6225         putting value into bcache.
6226
6227 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6228
6229         PR gdb/21500
6230         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
6231         to...
6232         (amd64_windows_init_abi_common): ... this.  Don't set size of
6233         long type.
6234         (amd64_windows_init_abi): New function.
6235         (amd64_cygwin_init_abi): New function.
6236         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
6237         the Cygwin OS ABI.
6238         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
6239         comment.
6240
6241 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6242
6243         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
6244         * windows-tdep.c (CYGWIN_DLL_NAME): New.
6245         (pe_import_directory_entry): New struct type.
6246         (is_linked_with_cygwin_dll): New function.
6247         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
6248         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
6249         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
6250
6251 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6252
6253         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
6254         i386_cygwin_core_osabi_sniffer.
6255
6256 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6257
6258         * i386-cygwin-tdep.c: Rename to...
6259         * i386-windows-tdep.c: ... this.
6260         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
6261         i386-windows-tdep.c.
6262         * configure.tgt: Likewise.
6263
6264 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6265
6266         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
6267         * osabi.c (gdb_osabi_names): Add "Windows".
6268         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
6269         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
6270         (i386_cygwin_core_osabi_sniffer): New function, extracted from
6271         i386_cygwin_osabi_sniffer.
6272         (_initialize_i386_cygwin_tdep): Register OS ABI
6273         GDB_OSABI_WINDOWS for i386.
6274         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
6275         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
6276         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
6277         for x86-64.
6278         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
6279         when the target matches '*-*-mingw*'.
6280
6281 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6282
6283         * defs.h (enum gdb_osabi): Move to...
6284         * osabi.h (enum gdb_osabi): ... here.
6285         * gdbarch.sh: Include osabi.h in gdbarch.h.
6286         * gdbarch.h: Re-generate.
6287
6288 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
6289
6290         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
6291         function.
6292         (_initialize_amd64_windows_tdep): Register osabi sniffer.
6293
6294 2020-03-14  Tom Tromey  <tom@tromey.com>
6295
6296         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
6297         for C++.
6298         (c_type_print_modifier): Likewise.  Add "language" parameter.
6299         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
6300         (c_type_print_base_1): Update.
6301         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
6302         constants.
6303         * type-stack.c (type_stack::insert): Handle tp_atomic and
6304         tp_restrict.
6305         (type_stack::follow_type_instance_flags): Likewise.
6306         (type_stack::follow_types): Likewise.  Merge type-following code.
6307         * c-exp.y (RESTRICT, ATOMIC): New tokens.
6308         (space_identifier, cv_with_space_id)
6309         (const_or_volatile_or_space_identifier_noopt)
6310         (const_or_volatile_or_space_identifier): Remove.
6311         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
6312         rules.
6313         (ptr_operator, typebase): Update.
6314         (enum token_flag) <FLAG_C>: New constant.
6315         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
6316         "_Atomic".
6317         (lex_one_token): Handle FLAG_C.
6318
6319 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6320
6321         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
6322         it to the ptrace call.
6323         * m68k-bsd-nat.c (store_registers): Likewise.
6324
6325 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6326
6327         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
6328         gdb_byte *.
6329         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
6330         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
6331         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
6332
6333 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6334
6335         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
6336         nbsd_nat_target instead of inf_ptrace_target.
6337         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6338         nbsd_nat_target.
6339
6340 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6341
6342         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
6343         register_t.
6344
6345 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6346
6347         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
6348         it to the ptrace call.
6349         * alpha-bsd-nat.c (store_registers): Likewise.
6350
6351 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6352
6353         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
6354         includes.
6355         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
6356         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
6357         fill_fpregset): Likewise.
6358
6359 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6360
6361         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
6362         nbsd_nat_target instead of inf_ptrace_target.
6363         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6364         nbsd_nat_target.
6365
6366 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6367
6368         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
6369         register_t.
6370
6371 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6372
6373         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
6374         it to the ptrace call.
6375         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
6376         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
6377         * arm-nbsd-nat.c (store_register): Likewise.
6378         * arm-nbsd-nat.c (store_regs): Likewise.
6379         * arm-nbsd-nat.c (store_fp_register): Likewise.
6380         * arm-nbsd-nat.c (store_fp_regs): Likewise.
6381
6382 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6383
6384         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
6385         nbsd_nat_target instead of inf_ptrace_target.
6386         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
6387         nbsd_nat_target.
6388
6389 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6390
6391         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
6392         it to the ptrace call.
6393         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
6394
6395 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6396
6397         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
6398         it to the ptrace call.
6399         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
6400
6401 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6402
6403         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
6404         gdb_byte *.
6405         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
6406
6407 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6408
6409         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
6410         instead of inf_ptrace_target.
6411         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
6412         nbsd_nat_target.
6413
6414 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6415
6416         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6417         register_t.
6418
6419 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6420
6421         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
6422         register_t.
6423
6424 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
6425
6426         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
6427         register_t.
6428
6429 2020-03-13  Tom Tromey  <tom@tromey.com>
6430
6431         * value.h (val_print): Don't declare.
6432         * valprint.h (val_print_array_elements)
6433         (val_print_scalar_formatted, generic_val_print): Don't declare.
6434         * valprint.c (generic_val_print_array): Take a struct value.
6435         (generic_val_print_ptr, generic_val_print_memberptr)
6436         (generic_val_print_bool, generic_val_print_int)
6437         (generic_val_print_char, generic_val_print_complex)
6438         (generic_val_print): Remove.
6439         (generic_value_print): Update.
6440         (do_val_print): Remove unused parameters.  Don't call
6441         la_val_print.
6442         (val_print): Remove.
6443         (common_val_print): Update.  Don't call value_check_printable.
6444         (val_print_scalar_formatted, val_print_array_elements): Remove.
6445         * rust-lang.c (rust_val_print): Remove.
6446         (rust_language_defn): Update.
6447         * p-valprint.c (pascal_val_print): Remove.
6448         (pascal_value_print_inner): Update.
6449         (pascal_object_print_val_fields, pascal_object_print_val):
6450         Remove.
6451         (pascal_object_print_static_field): Update.
6452         * p-lang.h (pascal_val_print): Don't declare.
6453         * p-lang.c (pascal_language_defn): Update.
6454         * opencl-lang.c (opencl_language_defn): Update.
6455         * objc-lang.c (objc_language_defn): Update.
6456         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
6457         * m2-lang.h (m2_val_print): Don't declare.
6458         * m2-lang.c (m2_language_defn): Update.
6459         * language.h (struct language_defn) <la_val_print>: Remove.
6460         * language.c (unk_lang_value_print_inner): Rename.  Change
6461         argument types.
6462         (unknown_language_defn, auto_language_defn): Update.
6463         * go-valprint.c (go_val_print): Remove.
6464         * go-lang.h (go_val_print): Don't declare.
6465         * go-lang.c (go_language_defn): Update.
6466         * f-valprint.c (f_val_print): Remove.
6467         * f-lang.h (f_value_print): Don't declare.
6468         * f-lang.c (f_language_defn): Update.
6469         * d-valprint.c (d_val_print): Remove.
6470         * d-lang.h (d_value_print): Don't declare.
6471         * d-lang.c (d_language_defn): Update.
6472         * cp-valprint.c (cp_print_value_fields)
6473         (cp_print_value_fields_rtti, cp_print_value): Remove.
6474         (cp_print_static_field): Update.
6475         * c-valprint.c (c_val_print_array, c_val_print_ptr)
6476         (c_val_print_struct, c_val_print_union, c_val_print_int)
6477         (c_val_print_memberptr, c_val_print): Remove.
6478         * c-lang.h (c_val_print_array, cp_print_value_fields)
6479         (cp_print_value_fields_rtti): Don't declare.
6480         * c-lang.c (c_language_defn, cplus_language_defn)
6481         (asm_language_defn, minimal_language_defn): Update.
6482         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
6483         (ada_val_print_enum): Take a struct value.
6484         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
6485         (ada_val_print): Remove.
6486         (ada_value_print_1): Update.
6487         (printable_val_type): Remove.
6488         * ada-lang.h (ada_val_print): Don't declare.
6489         * ada-lang.c (ada_language_defn): Update.
6490
6491 2020-03-13  Tom Tromey  <tom@tromey.com>
6492
6493         * valprint.c (do_val_print): Update.
6494         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
6495         a struct value.
6496         (value_to_value_object_no_release): Declare.
6497         * python/py-value.c (value_to_value_object_no_release): New
6498         function.
6499         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
6500         struct value.
6501         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
6502         function.
6503         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
6504         a struct value.
6505         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
6506         Declare.
6507         (gdbscm_apply_val_pretty_printer): Take a struct value.
6508         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
6509         value.
6510         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
6511         value.
6512         * extension-priv.h (struct extension_language_ops)
6513         <apply_val_pretty_printer>: Take a struct value.
6514         * cp-valprint.c (cp_print_value): Create a struct value.
6515         (cp_print_value): Update.
6516
6517 2020-03-13  Tom Tromey  <tom@tromey.com>
6518
6519         * ada-valprint.c (print_field_values): Call common_val_print.
6520
6521 2020-03-13  Tom Tromey  <tom@tromey.com>
6522
6523         * ada-valprint.c (val_print_packed_array_elements): Remove
6524         bitoffset and val parameters.  Call common_val_print.
6525         (ada_val_print_string): Remove offset, address, and original_value
6526         parameters.
6527         (ada_val_print_array): Update.
6528         (ada_value_print_array): New function.
6529         (ada_value_print_1): Call it.
6530
6531 2020-03-13  Tom Tromey  <tom@tromey.com>
6532
6533         * ada-valprint.c (ada_value_print): Use common_val_print.
6534
6535 2020-03-13  Tom Tromey  <tom@tromey.com>
6536
6537         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
6538
6539 2020-03-13  Tom Tromey  <tom@tromey.com>
6540
6541         * ada-valprint.c (ada_value_print_num): New function.
6542         (ada_value_print_1): Use it.
6543
6544 2020-03-13  Tom Tromey  <tom@tromey.com>
6545
6546         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
6547
6548 2020-03-13  Tom Tromey  <tom@tromey.com>
6549
6550         * ada-valprint.c (ada_value_print_ptr): New function.
6551         (ada_value_print_1): Use it.
6552
6553 2020-03-13  Tom Tromey  <tom@tromey.com>
6554
6555         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
6556         call common_val_print.
6557         (ada_val_print_1): Update.
6558         (ada_value_print_1): New function.
6559         (ada_value_print_inner): Rewrite.
6560
6561 2020-03-13  Tom Tromey  <tom@tromey.com>
6562
6563         * cp-valprint.c (cp_print_value_fields): Update.
6564         (cp_print_value): New function.
6565
6566 2020-03-13  Tom Tromey  <tom@tromey.com>
6567
6568         * m2-valprint.c (m2_value_print_inner): Use
6569         cp_print_value_fields.
6570         * cp-valprint.c (cp_print_value_fields): New function.
6571         * c-valprint.c (c_value_print_struct): New function.
6572         (c_value_print_inner): Use c_value_print_struct.
6573         * c-lang.h (cp_print_value_fields): Declare.
6574
6575 2020-03-13  Tom Tromey  <tom@tromey.com>
6576
6577         * c-valprint.c (c_value_print_array): New function.
6578         (c_value_print_inner): Use it.
6579
6580 2020-03-13  Tom Tromey  <tom@tromey.com>
6581
6582         * c-valprint.c (c_value_print_memberptr): New function.
6583         (c_value_print_inner): Use it.
6584
6585 2020-03-13  Tom Tromey  <tom@tromey.com>
6586
6587         * c-valprint.c (c_value_print_int): New function.
6588         (c_value_print_inner): Use it.
6589
6590 2020-03-13  Tom Tromey  <tom@tromey.com>
6591
6592         * c-valprint.c (c_value_print_ptr): New function.
6593         (c_value_print_inner): Use it.
6594
6595 2020-03-13  Tom Tromey  <tom@tromey.com>
6596
6597         * c-valprint.c (c_value_print_inner): Rewrite.
6598
6599 2020-03-13  Tom Tromey  <tom@tromey.com>
6600
6601         * valprint.c (generic_value_print_complex): New function.
6602         (generic_value_print): Use it.
6603
6604 2020-03-13  Tom Tromey  <tom@tromey.com>
6605
6606         * valprint.c (generic_val_print_float): Don't call
6607         val_print_scalar_formatted.
6608         (generic_val_print, generic_value_print): Update.
6609
6610 2020-03-13  Tom Tromey  <tom@tromey.com>
6611
6612         * valprint.c (generic_value_print_char): New function
6613         (generic_value_print): Use it.
6614
6615 2020-03-13  Tom Tromey  <tom@tromey.com>
6616
6617         * valprint.c (generic_value_print_int): New function.
6618         (generic_value_print): Use it.
6619
6620 2020-03-13  Tom Tromey  <tom@tromey.com>
6621
6622         * valprint.c (generic_value_print_bool): New function.
6623         (generic_value_print): Use it.
6624
6625 2020-03-13  Tom Tromey  <tom@tromey.com>
6626
6627         * valprint.c (generic_val_print_func): Simplify.
6628         (generic_val_print, generic_value_print): Update.
6629
6630 2020-03-13  Tom Tromey  <tom@tromey.com>
6631
6632         * valprint.c (generic_val_print_flags): Remove.
6633         (generic_val_print, generic_value_print): Update.
6634         (val_print_type_code_flags): Add original_value parameter.
6635
6636 2020-03-13  Tom Tromey  <tom@tromey.com>
6637
6638         * valprint.c (generic_val_print): Update.
6639         (generic_value_print): Update.
6640         * valprint.c (generic_val_print_enum): Don't call
6641         val_print_scalar_formatted.
6642
6643 2020-03-13  Tom Tromey  <tom@tromey.com>
6644
6645         * valprint.c (generic_value_print): Call generic_value_print_ptr.
6646         * valprint.c (generic_value_print_ptr): New function.
6647
6648 2020-03-13  Tom Tromey  <tom@tromey.com>
6649
6650         * valprint.c (generic_value_print): Rewrite.
6651
6652 2020-03-13  Tom Tromey  <tom@tromey.com>
6653
6654         * p-valprint.c (pascal_object_print_value_fields)
6655         (pascal_object_print_value): New functions.
6656
6657 2020-03-13  Tom Tromey  <tom@tromey.com>
6658
6659         * p-valprint.c (pascal_value_print_inner): Rewrite.
6660
6661 2020-03-13  Tom Tromey  <tom@tromey.com>
6662
6663         * f-valprint.c (f_value_print_innner): Rewrite.
6664
6665 2020-03-13  Tom Tromey  <tom@tromey.com>
6666
6667         * m2-valprint.c (m2_print_unbounded_array): New overload.
6668         (m2_print_unbounded_array): Update.
6669         (m2_print_array_contents): Take a struct value.
6670         (m2_value_print_inner): Rewrite.
6671
6672 2020-03-13  Tom Tromey  <tom@tromey.com>
6673
6674         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
6675         (d_value_print_inner): New function.
6676         * d-lang.h (d_value_print_inner): Declare.
6677         * d-lang.c (d_language_defn): Use d_value_print_inner.
6678
6679 2020-03-13  Tom Tromey  <tom@tromey.com>
6680
6681         * go-valprint.c (go_value_print_inner): New function.
6682         * go-lang.h (go_value_print_inner): Declare.
6683         * go-lang.c (go_language_defn): Use go_value_print_inner.
6684
6685 2020-03-13  Tom Tromey  <tom@tromey.com>
6686
6687         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
6688         API.
6689         (rust_val_print): Rewrite.
6690         (rust_value_print_inner): New function, from rust_val_print.
6691         (rust_language_defn): Use rust_value_print_inner.
6692
6693 2020-03-13  Tom Tromey  <tom@tromey.com>
6694
6695         * ada-valprint.c (ada_value_print_inner): New function.
6696         * ada-lang.h (ada_value_print_inner): Declare.
6697         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
6698
6699 2020-03-13  Tom Tromey  <tom@tromey.com>
6700
6701         * f-valprint.c (f_value_print_innner): New function.
6702         * f-lang.h (f_value_print_innner): Declare.
6703         * f-lang.c (f_language_defn): Use f_value_print_innner.
6704
6705 2020-03-13  Tom Tromey  <tom@tromey.com>
6706
6707         * p-valprint.c (pascal_value_print_inner): New function.
6708         * p-lang.h (pascal_value_print_inner): Declare.
6709         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
6710
6711 2020-03-13  Tom Tromey  <tom@tromey.com>
6712
6713         * m2-valprint.c (m2_value_print_inner): New function.
6714         * m2-lang.h (m2_value_print_inner): Declare.
6715         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
6716
6717 2020-03-13  Tom Tromey  <tom@tromey.com>
6718
6719         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
6720         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
6721         * c-valprint.c (c_value_print_inner): New function.
6722         * c-lang.h (c_value_print_inner): Declare.
6723         * c-lang.c (c_language_defn, cplus_language_defn)
6724         (asm_language_defn, minimal_language_defn): Use
6725         c_value_print_inner.
6726
6727 2020-03-13  Tom Tromey  <tom@tromey.com>
6728
6729         * p-valprint.c (pascal_object_print_value_fields): Now static.
6730         * p-lang.h (pascal_object_print_value_fields): Don't declare.
6731
6732 2020-03-13  Tom Tromey  <tom@tromey.com>
6733
6734         * c-valprint.c (c_val_print_array): Simplify.
6735
6736 2020-03-13  Tom Tromey  <tom@tromey.com>
6737
6738         * valprint.c (value_print_array_elements): New function.
6739         * valprint.h (value_print_array_elements): Declare.
6740
6741 2020-03-13  Tom Tromey  <tom@tromey.com>
6742
6743         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
6744         * mips-tdep.c (mips_print_register): Use
6745         value_print_scalar_formatted.
6746
6747 2020-03-13  Tom Tromey  <tom@tromey.com>
6748
6749         * valprint.h (value_print_scalar_formatted): Declare.
6750         * valprint.c (value_print_scalar_formatted): New function.
6751
6752 2020-03-13  Tom Tromey  <tom@tromey.com>
6753
6754         * valprint.h (generic_value_print): Declare.
6755         * valprint.c (generic_value_print): New function.
6756
6757 2020-03-13  Tom Tromey  <tom@tromey.com>
6758
6759         * valprint.c (do_val_print): Call la_value_print_inner, if
6760         available.
6761         * rust-lang.c (rust_language_defn): Update.
6762         * p-lang.c (pascal_language_defn): Update.
6763         * opencl-lang.c (opencl_language_defn): Update.
6764         * objc-lang.c (objc_language_defn): Update.
6765         * m2-lang.c (m2_language_defn): Update.
6766         * language.h (struct language_defn) <la_value_print_inner>: New
6767         member.
6768         * language.c (unknown_language_defn, auto_language_defn): Update.
6769         * go-lang.c (go_language_defn): Update.
6770         * f-lang.c (f_language_defn): Update.
6771         * d-lang.c (d_language_defn): Update.
6772         * c-lang.c (c_language_defn, cplus_language_defn)
6773         (asm_language_defn, minimal_language_defn): Update.
6774         * ada-lang.c (ada_language_defn): Update.
6775
6776 2020-03-13  Tom Tromey  <tom@tromey.com>
6777
6778         * c-valprint.c (c_value_print): Use common_val_print.
6779
6780 2020-03-13  Tom Tromey  <tom@tromey.com>
6781
6782         * cp-valprint.c (cp_print_static_field): Use common_val_print.
6783
6784 2020-03-13  Tom Tromey  <tom@tromey.com>
6785
6786         * f-valprint.c (f77_print_array_1, f_val_print): Use
6787         common_val_print.
6788
6789 2020-03-13  Tom Tromey  <tom@tromey.com>
6790
6791         * riscv-tdep.c (riscv_print_one_register_info): Use
6792         common_val_print.
6793
6794 2020-03-13  Tom Tromey  <tom@tromey.com>
6795
6796         * mi/mi-main.c (output_register): Use common_val_print.
6797
6798 2020-03-13  Tom Tromey  <tom@tromey.com>
6799
6800         * infcmd.c (default_print_one_register_info): Use
6801         common_val_print.
6802
6803 2020-03-13  Tom Tromey  <tom@tromey.com>
6804
6805         * valprint.h (common_val_print_checked): Declare.
6806         * valprint.c (common_val_print_checked): New function.
6807         * stack.c (print_frame_arg): Use common_val_print_checked.
6808
6809 2020-03-13  Tom Tromey  <tom@tromey.com>
6810
6811         * valprint.c (do_val_print): New function, from val_print.
6812         (val_print): Use do_val_print.
6813         (common_val_print): Use do_val_print.
6814
6815 2020-03-13  Tom Tromey  <tom@tromey.com>
6816
6817         * valprint.c (value_print): Use scoped_value_mark.
6818
6819 2020-03-13  Tom de Vries  <tdevries@suse.de>
6820
6821         PR symtab/25646
6822         * psymtab.c (partial_symtab::partial_symtab): Don't set
6823         globals_offset and statics_offset.  Push element onto
6824         current_global_psymbols and current_static_psymbols stacks.
6825         (concat): New function.
6826         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
6827         element from current_global_psymbols and current_static_psymbols
6828         stacks.  Concat popped elements to global_psymbols and
6829         static_symbols.
6830         (add_psymbol_to_list): Use current_global_psymbols and
6831         current_static_psymbols stacks.
6832         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
6833         current_static_psymbols fields.
6834
6835 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6836
6837         * corelow.c (sniff_core_bfd): Remove.
6838         (class core_target) <m_core_vec>: Remove.
6839         (core_target::core_target): Update.
6840         (core_file_fns): Remove.
6841         (deprecated_add_core_fns): Remove.
6842         (default_core_sniffer): Remove.
6843         (sniff_core_bfd): Remove.
6844         (default_check_format): Remove.
6845         (gdb_check_format): Remove.
6846         (core_target_open): Update.
6847         (core_target::get_core_register_section): Update.
6848         (get_core_registers_cb): Update.
6849         (core_target::fetch_registers): Update.
6850         * gdbcore.h (struct core_fns): Remove.
6851         (deprecated_add_core_fns): Remove.
6852         (default_core_sniffer): Remove.
6853         (default_check_format): Remove.
6854
6855 2020-03-12  Tom Tromey  <tom@tromey.com>
6856
6857         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
6858         CORE_ADDR.
6859         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
6860
6861 2020-03-12  Tom Tromey  <tom@tromey.com>
6862
6863         * remote.c (remote_target::download_tracepoint)
6864         (remote_target::enable_tracepoint)
6865         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
6866         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
6867         sprintf_vma.
6868
6869 2020-03-12  Tom Tromey  <tom@tromey.com>
6870
6871         * symfile-mem.c: Update CORE_ADDR size assert.
6872
6873 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6874
6875         * selftest.m4: Move to gdbsupport/.
6876         * acinclude.m4: Update path to selftest.m4.
6877
6878 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6879
6880         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
6881         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
6882         gdbarch-selfselftests.c and selftest-arch.c.
6883         (SUBDIR_UNITTESTS_OBS): Rename to...
6884         (SELFTESTS_OBS): ... this.
6885         (COMMON_SFILES): Remove disasm-selftests.c and
6886         gdbarch-selftests.c.
6887         * configure.ac: Don't add selftest-arch.{c,o} to
6888         CONFIG_{SRCS,OBS}.
6889         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
6890         preprocessor conditions.
6891
6892 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6893
6894         * configure.ac: Don't source bfd/development.sh.
6895         * selftest.m4: Modify comment.
6896         * configure: Re-generate.
6897
6898 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
6899
6900         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
6901         not "true" or "false".
6902         * configure: Re-generate.
6903
6904 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
6905
6906         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
6907         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
6908         renamed to arm_nbsd_supply_gregset.
6909         (fetch_register): Update to call arm_nbsd_supply_gregset.
6910         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
6911         (arm_netbsd_nat_target::fetch_registers): Update.
6912         (fetch_elfcore_registers): Removed.
6913         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
6914         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
6915         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
6916         not require NetBSD system headers.
6917         (arm_nbsd_regset): New struct.
6918         (arm_nbsd_iterate_over_regset_sections): New function.
6919         (arm_netbsd_init_abi_common): Updated to call
6920         set_gdbarch_iterate_over_regset_sections.
6921         * arm-nbsd-tdep.h: New file.
6922
6923 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
6924
6925         * symtab.c (find_pc_sect_line): Add check which prevents infinite
6926         recursion.
6927
6928 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
6929
6930         * configure: Re-generate.
6931
6932 2020-03-11  Tom Tromey  <tromey@adacore.com>
6933
6934         * ada-typeprint.c (print_choices): Fix comment.
6935
6936 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
6937
6938         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
6939         previous item in the list, when the list has no items.
6940
6941 2020-03-11  Tom de Vries  <tdevries@suse.de>
6942
6943         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
6944         PROP_LOCLIST handling code.
6945
6946 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6947
6948         * buildsym-legacy.c (record_line): Pass extra parameter to
6949         record_line.
6950         * buildsym.c (buildsym_compunit::record_line): Take an extra
6951         parameter, reduce duplication in the line table, and record the
6952         is_stmt flag in the line table.
6953         * buildsym.h (buildsym_compunit::record_line): Add extra
6954         parameter.
6955         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
6956         non-statement lines.
6957         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
6958         this to the symtab builder.
6959         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
6960         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
6961         through to dwarf_record_line_1.
6962         * infrun.c (process_event_stop_test): When stepping, don't stop at
6963         a non-statement instruction, and only refresh the step info when
6964         we land in the middle of a line's range.  Also add an extra
6965         comment.
6966         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
6967         field.
6968         * record-btrace.c (btrace_find_line_range): Only record lines
6969         marked as is-statement.
6970         * stack.c (frame_show_address): Show the frame address if we are
6971         in a non-statement sal.
6972         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
6973         (maintenance_print_one_line_table): Print a header for the is_stmt
6974         column, and include is_stmt information in the output.
6975         * symtab.c (find_pc_sect_line): Find lines marked as statements in
6976         preference to non-statements.
6977         (find_pcs_for_symtab_line): Prefer is-statement entries.
6978         (find_line_common): Likewise.
6979         * symtab.h (struct linetable_entry): Add is_stmt field.
6980         (struct symtab_and_line): Likewise.
6981         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
6982         arranging the line table.
6983
6984 2020-03-07  Tom de Vries  <tdevries@suse.de>
6985
6986         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
6987         DIE.
6988
6989 2020-03-07  Tom Tromey  <tom@tromey.com>
6990
6991         * valops.c (value_literal_complex): Remove obsolete comment.
6992         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
6993         comment.
6994
6995 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
6996
6997         * infrun.h: Forward-declare thread_info.
6998         (set_step_info): Add thread_info parameter, add doc.
6999         * infrun.c (set_step_info): Add thread_info parameter, move doc
7000         to header.
7001         * infrun.c (process_event_stop_test): Pass thread to
7002         set_step_info call.
7003         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
7004         set_step_info.
7005         (prepare_one_step): Add thread_info parameter, pass it to
7006         set_step_frame and prepare_one_step (recursive) call.
7007         (step_1): Pass thread to prepare_one_step call.
7008         (step_command_fsm::should_stop): Pass thread to
7009         prepare_one_step.
7010         (until_next_fsm): Pass thread to set_step_frame call.
7011         (finish_command): Pass thread to set_step_info call.
7012
7013 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
7014
7015         * windows-tdep.c (windows_solib_create_inferior_hook):
7016         Check if inferior is running.
7017
7018 2020-03-06  Tom de Vries  <tdevries@suse.de>
7019
7020         * NEWS: Fix "the the".
7021         * ctfread.c: Same.
7022
7023 2020-03-06  Tom de Vries  <tdevries@suse.de>
7024
7025         * psymtab.c (psymtab_to_symtab): Don't print "done.".
7026
7027 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
7028
7029         * .dir-locals.el: Add a comment referencing the other copies of
7030         this file.
7031
7032 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
7033
7034         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
7035         psargs.
7036
7037 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
7038
7039         * .gitattributes: New file.
7040
7041 2020-03-04  Tom Tromey  <tom@tromey.com>
7042
7043         * symmisc.c (print_symbol_bcache_statistics)
7044         (print_objfile_statistics): Update.
7045         * symfile.c (allocate_symtab): Use intern.
7046         * psymtab.c (partial_symtab::partial_symtab): Use intern.
7047         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
7048         macro_cache>: Remove.
7049         <string_cache>: New member.
7050         (struct objfile) <intern>: New methods.
7051         * elfread.c (elf_symtab_read): Use intern.
7052         * dwarf2/read.c (fixup_go_packaging): Intern package name.
7053         (dwarf2_compute_name, dwarf2_physname)
7054         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
7055         names.
7056         (guess_partial_die_structure_name): Update.
7057         (partial_die_info::fixup): Intern name.
7058         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
7059         name.
7060         (dwarf2_name): Intern name.  Update.
7061         * buildsym.c (buildsym_compunit::get_macro_table): Use
7062         string_cache.
7063
7064 2020-03-04  Tom Tromey  <tom@tromey.com>
7065
7066         * jit.c (bfd_open_from_target_memory): Make "target" const.
7067         * corefile.c (gnutarget): Now const.
7068         * gdbcore.h (gnutarget): Now const.
7069
7070 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
7071
7072         * NEWS: Mention support for WOW64 processes.
7073         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
7074         (amd64_windows_segment_register_p): Remove static.
7075         (_initialize_amd64_windows_nat): Update.
7076         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
7077         * i386-windows-nat.c (context_offset): Update.
7078         (i386_mappings): Rename and remove static.
7079         (i386_windows_segment_register_p): Remove static.
7080         (_initialize_i386_windows_nat): Update.
7081         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
7082         (STATUS_WX86_SINGLE_STEP): New macro.
7083         (EnumProcessModulesEx): New macro.
7084         (Wow64SuspendThread): New macro.
7085         (Wow64GetThreadContext): New macro.
7086         (Wow64SetThreadContext): New macro.
7087         (Wow64GetThreadSelectorEntry): New macro.
7088         (windows_set_context_register_offsets): Add static.
7089         (windows_set_segment_register_p): Likewise.
7090         (windows_add_thread): Adapt for WOW64 processes.
7091         (windows_fetch_one_register): Likewise.
7092         (windows_nat_target::fetch_registers): Likewise.
7093         (windows_store_one_register): Likewise.
7094         (display_selector): Likewise.
7095         (display_selectors): Likewise.
7096         (handle_exception): Likewise.
7097         (windows_continue): Likewise.
7098         (windows_nat_target::resume): Likewise.
7099         (windows_add_all_dlls): Likewise.
7100         (do_initial_windows_stuff): Likewise.
7101         (windows_nat_target::attach): Likewise.
7102         (windows_get_exec_module_filename): Likewise.
7103         (windows_nat_target::create_inferior): Likewise.
7104         (windows_xfer_siginfo): Likewise.
7105         (_initialize_loadable): Initialize Wow64SuspendThread,
7106         Wow64GetThreadContext, Wow64SetThreadContext,
7107         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
7108         * windows-nat.h (windows_set_context_register_offsets):
7109         Remove declaration.
7110         (windows_set_segment_register_p): Likewise.
7111         (i386_windows_segment_register_p): Add declaration.
7112         (amd64_windows_segment_register_p): Likewise.
7113
7114 2020-03-04  Luis Machado  <luis.machado@linaro.org>
7115
7116         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
7117         in "info registers" for AArch64/ARM.
7118
7119         The change caused "info registers" to not print GPR's.
7120
7121         gdb/ChangeLog:
7122
7123         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
7124
7125         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
7126         when reg->group is empty and reggroup is not.
7127
7128 2020-03-03  Tom Tromey  <tromey@adacore.com>
7129
7130         * dwarf2/frame.c (struct dwarf2_frame_cache)
7131         <checked_tailcall_bottom, entry_cfa_sp_offset,
7132         entry_cfa_sp_offset_p>: Remove members.
7133         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
7134         (dwarf2_frame_prev_register): Don't call
7135         dwarf2_tailcall_sniffer_first.
7136         (dwarf2_append_unwinders): Don't append tailcall unwinder.
7137         * frame-unwind.c (add_unwinder): New fuction.
7138         (frame_unwind_init): Use it.  Add tailcall unwinder.
7139
7140 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7141             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7142
7143         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
7144         value should be printed as true.
7145
7146 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
7147
7148         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
7149         (windows_init_abi): Set and use windows_so_ops.
7150
7151 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
7152
7153         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
7154         when verifying if dealing with a convenience variable.
7155
7156 2020-03-03  Luis Machado  <luis.machado@linaro.org>
7157
7158         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
7159
7160 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
7161
7162         * infrun.c (gdbarch_supports_displaced_stepping): New.
7163         (use_displaced_stepping): Break up conditions in smaller pieces.
7164         Use gdbarch_supports_displaced_stepping.
7165         (displaced_step_prepare_throw): Use
7166         gdbarch_supports_displaced_stepping.
7167
7168 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7169
7170         * NEWS: Mention new behaviour of the history filename.
7171         * top.c (write_history_p): Add comment.
7172         (show_write_history_p): Add header comment, give a different
7173         message when history writing is on, but the history filename is
7174         empty.
7175         (history_filename): Add comment.
7176         (history_filename_empty): New function.
7177         (show_history_filename): Add header comment, give a different
7178         message when the filename is empty.
7179         (init_history): Compare history_filename against nullptr, and only
7180         read history if the filename is not empty.
7181         (set_history_filename): Add header comment, and only make
7182         non-empty filenames absolute.
7183         (init_main): Make the filename argument to 'set history filename'
7184         optional.
7185
7186 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
7187
7188         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
7189         (arm_supply_vfpregset): ...this, and update to use VFP registers.
7190         (fetch_fp_register): Update.
7191         (fetch_fp_regs): Update.
7192         (store_fp_register): Update.
7193         (store_fp_regs): Update.
7194         (arm_netbsd_nat_target::read_description): New function.
7195         (fetch_elfcore_registers): Update.
7196
7197 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7198
7199         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
7200         general_thread if the stop reply is missing a thread-id.
7201         (remote_target::process_stop_reply): Use the first non-exited
7202         thread if the target didn't pass a thread-id.
7203         * infrun.c (do_target_wait): Move call to
7204         switch_to_inferior_no_thread to ....
7205         (do_target_wait_1): ... here.
7206
7207 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
7208
7209         * debuginfod-support.c: Include defs.h first.
7210
7211 2020-02-28  Tom de Vries  <tdevries@suse.de>
7212
7213         * symfile.c (set_initial_language): Use default language for lookup.
7214
7215 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
7216
7217         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
7218         reader variable, pass `this` to read_cutu_die_from_dwo.
7219
7220 2020-02-27  Aaron Merey  <amerey@redhat.com>
7221
7222         * source.c (open_source_file): Check for nullptr when computing
7223         srcpath.
7224
7225 2020-02-27  Tom Tromey  <tromey@adacore.com>
7226
7227         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
7228         member.
7229         (dwarf2_add_field): Don't update nfields.
7230         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
7231
7232 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
7233
7234         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
7235         abs.
7236
7237 2020-02-26  Tom Tromey  <tom@tromey.com>
7238
7239         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
7240         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
7241         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
7242         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
7243         per_cu_data.
7244
7245 2020-02-26  Tom Tromey  <tom@tromey.com>
7246
7247         * dwarf2/index-write.c (psym_index_map): Change type.
7248         (add_address_entry_worker, write_one_signatured_type)
7249         (recursively_count_psymbols, recursively_write_psymbols)
7250         (class debug_names, psyms_seen_size, write_gdbindex)
7251         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
7252
7253 2020-02-26  Aaron Merey  <amerey@redhat.com>
7254
7255         * Makefile.in: Handle optional debuginfod support.
7256         * NEWS: Update.
7257         * README: Add --with-debuginfod summary.
7258         * config.in: Regenerate.
7259         * configure: Regenerate.
7260         * configure.ac: Handle optional debuginfod support.
7261         * debuginfod-support.c: debuginfod helper functions.
7262         * debuginfod-support.h: Ditto.
7263         * doc/gdb.texinfo: Add --with-debuginfod to configure options
7264         summary.
7265         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
7266         when a dwz file cannot be found.
7267         * elfread.c (elf_symfile_read): Query debuginfod servers when a
7268         debuginfo file cannot be found.
7269         * source.c (open_source_file): Query debuginfod servers when a
7270         source file cannot be found.
7271         * top.c (print_gdb_configuration): Include
7272         --{with,without}-debuginfod in the output.
7273
7274 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
7275
7276         * thread.c (thr_try_catch_cmd): Print thread name.
7277
7278 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
7279
7280         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
7281         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7282         dwarf2_fetch_die_type_sect_off): Move to...
7283         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
7284         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7285         dwarf2_fetch_die_type_sect_off): ... here.
7286         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
7287         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
7288         dwarf2_fetch_die_type_sect_off): Move doc to header file.
7289
7290 2020-02-26  Tom de Vries  <tdevries@suse.de>
7291
7292         PR gdb/25603
7293         * symfile.c (set_initial_language): Exit-early if
7294         language_mode == language_mode_manual.
7295
7296 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7297
7298         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
7299         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
7300         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
7301
7302 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
7303
7304         * gdbtypes.c (create_array_type_with_stride): Handle negative
7305         array strides.
7306         * valarith.c (value_subscripted_rvalue): Likewise.
7307
7308 2020-02-25  Luis Machado  <luis.machado@linaro.org>
7309
7310         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
7311
7312 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
7313
7314         * loc.h (dwarf2_get_die_type): Move to...
7315         * read.h (dwarf2_get_die_type): ... here.
7316         * read.c (dwarf2_get_die_type): Move doc to header.
7317
7318 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
7319
7320         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
7321         'gnulib/Makefile.in' to the list.
7322
7323 2020-02-24  Tom Tromey  <tom@tromey.com>
7324
7325         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
7326         Remove.
7327         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
7328         XOBNEWVEC.
7329
7330 2020-02-24  Tom Tromey  <tom@tromey.com>
7331
7332         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
7333         New method.
7334         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
7335         (dw2_do_instantiate_symtab, dw2_get_file_names)
7336         (build_type_psymtab_dependencies, load_full_type_unit): Update.
7337
7338 2020-02-24  Tom Tromey  <tom@tromey.com>
7339
7340         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
7341         make_scoped_restore.
7342         (dwarf2_psymtab::read_symtab): Don't clear
7343         reading_partial_symbols.
7344
7345 2020-02-24  Tom de Vries  <tdevries@suse.de>
7346
7347         PR gdb/25592
7348         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
7349
7350 2020-02-24  Tom de Vries  <tdevries@suse.de>
7351
7352         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
7353         commands layout next/prev/regs.
7354
7355 2020-02-22  Tom Tromey  <tom@tromey.com>
7356
7357         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
7358         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
7359
7360 2020-02-22  Tom Tromey  <tom@tromey.com>
7361
7362         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
7363
7364 2020-02-22  Tom Tromey  <tom@tromey.com>
7365
7366         * tui/tui-win.c (_initialize_tui_win): Add usage text.
7367         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
7368         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
7369         * tui/tui.c (_initialize_tui): Add usage text.
7370
7371 2020-02-22  Tom Tromey  <tom@tromey.com>
7372
7373         * tui/tui-win.c (tui_set_focus_command)
7374         (tui_set_win_height_command): Use error_no_arg.
7375         (_initialize_tui_win): Update help text.
7376         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
7377
7378 2020-02-22  Tom Tromey  <tom@tromey.com>
7379
7380         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
7381         * tui/tui-disasm.h (struct tui_disasm_window)
7382         <display_start_addr>: Declare.
7383         * tui/tui-source.h (struct tui_source_window)
7384         <display_start_addr>: Declare.
7385         * tui/tui-winsource.h (struct tui_source_window_base)
7386         <show_source_line, display_start_addr>: New methods.
7387         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
7388         Rename and move to protected section.
7389         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
7390         (tui_source_window_base::do_erase_source_content): Update.
7391         (tui_source_window_base::show_source_line): Now a method.
7392         (tui_source_window_base::show_source_content)
7393         (tui_source_window_base::tui_source_window_base)
7394         (tui_source_window_base::rerender)
7395         (tui_source_window_base::refill)
7396         (tui_source_window_base::do_scroll_horizontal)
7397         (tui_source_window_base::set_is_exec_point_at)
7398         (tui_source_window_base::update_breakpoint_info)
7399         (tui_source_window_base::update_exec_info): Update.
7400         * tui/tui-source.c (tui_source_window::set_contents)
7401         (tui_source_window::showing_source_p)
7402         (tui_source_window::do_scroll_vertical)
7403         (tui_source_window::location_matches_p)
7404         (tui_source_window::line_is_displayed): Update.
7405         (tui_source_window::display_start_addr): New method.
7406         * tui/tui-disasm.c (tui_disasm_window::set_contents)
7407         (tui_disasm_window::do_scroll_vertical)
7408         (tui_disasm_window::location_matches_p): Update.
7409         (tui_disasm_window::display_start_addr): New method.
7410
7411 2020-02-22  Tom Tromey  <tom@tromey.com>
7412
7413         * NEWS: Add entry for gdb.register_window_type.
7414         * tui/tui-layout.h (window_factory): New typedef.
7415         (tui_register_window): Declare.
7416         * tui/tui-layout.c (saved_tui_windows): New global.
7417         (tui_apply_current_layout): Use it.
7418         (tui_register_window): New function.
7419         * python/python.c (do_start_initialization): Call
7420         gdbpy_initialize_tui.
7421         (python_GdbMethods): Add "register_window_type" function.
7422         * python/python-internal.h (gdbpy_register_tui_window)
7423         (gdbpy_initialize_tui): Declare.
7424         * python/py-tui.c: New file.
7425         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
7426
7427 2020-02-22  Tom Tromey  <tom@tromey.com>
7428
7429         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
7430
7431 2020-02-22  Tom Tromey  <tom@tromey.com>
7432
7433         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
7434         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
7435         * tui/tui-data.c (tui_set_win_with_focus): Remove.
7436         (tui_set_win_focus_to): Move from tui-win.c.
7437
7438 2020-02-22  Tom Tromey  <tom@tromey.com>
7439
7440         * tui/tui-layout.c (make_standard_window, get_locator_window): New
7441         functions.
7442         (known_window_types): New global.
7443         (tui_get_window_by_name): Reimplement.
7444         (initialize_known_windows): New function.
7445         (validate_window_name): Rewrite.
7446         (_initialize_tui_layout): Call initialize_known_windows.
7447
7448 2020-02-22  Tom Tromey  <tom@tromey.com>
7449
7450         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
7451         Remove constants.
7452         * tui/tui-winsource.h (struct tui_source_window_base)
7453         <tui_source_window_base>: Remove parameter.
7454         * tui/tui-winsource.c
7455         (tui_source_window_base::tui_source_window_base): Remove
7456         parameter.
7457         (tui_source_window_base::refill): Update.
7458         * tui/tui-stack.h (struct tui_locator_window)
7459         <tui_locator_window>: Update.
7460         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
7461         Default the constructor.
7462         * tui/tui-regs.h (struct tui_data_item_window)
7463         <tui_data_item_window>: Default the constructor.
7464         (struct tui_data_window) <tui_data_window>: Likewise.
7465         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
7466         Default the constructor.
7467         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
7468         Default the constructor.
7469         <type>: Remove.
7470         (struct tui_win_info) <tui_win_info>: Default the constructor.
7471         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
7472         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
7473         Default the constructor.
7474
7475 2020-02-22  Tom Tromey  <tom@tromey.com>
7476
7477         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
7478         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
7479         * tui/tui-win.c (tui_resize_all): Don't call
7480         tui_delete_invisible_windows.
7481         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
7482         done.
7483         (tui_set_layout): Update.
7484         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
7485         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
7486         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
7487
7488 2020-02-22  Tom Tromey  <tom@tromey.com>
7489
7490         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
7491         correctly.
7492
7493 2020-02-22  Tom Tromey  <tom@tromey.com>
7494
7495         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
7496
7497 2020-02-22  Tom Tromey  <tom@tromey.com>
7498
7499         * tui/tui-winsource.h (struct tui_source_window_iterator)
7500         <inner_iterator>: New etytypedef.
7501         <tui_source_window_iterator>: Take "end" parameter.
7502         <tui_source_window_iterator>: Take iterator.
7503         <operator*, advance>: Update.
7504         <m_iter>: Change type.
7505         <m_end>: New field.
7506         (struct tui_source_windows) <begin, end>: Update.
7507         * tui/tui-layout.c (tui_windows): New global.
7508         (tui_apply_current_layout): Clear tui_windows.
7509         (tui_layout_window::apply): Update tui_windows.
7510         * tui/tui-data.h (tui_windows): Declare.
7511         (all_tui_windows): Now inline function.
7512         (class tui_window_iterator, struct all_tui_windows): Remove.
7513
7514 2020-02-22  Tom Tromey  <tom@tromey.com>
7515
7516         PR tui/17850:
7517         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
7518         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
7519         "height" argument.
7520         (class tui_layout_window) <get_sizes>: Likewise.
7521         (class tui_layout_split) <tui_layout_split>: Add "vertical"
7522         argument.
7523         <get_sizes>: Add "height" argument.
7524         <m_vertical>: New field.
7525         * tui/tui-layout.c (tui_layout_split::clone): Update.
7526         (tui_layout_split::get_sizes): Add "height" argument.
7527         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
7528         (tui_new_layout_command): Parse "-horizontal".
7529         (_initialize_tui_layout): Update help string.
7530         (tui_layout_split::specification): Add "-horizontal" when needed.
7531         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
7532         argument.
7533         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
7534         New methods.
7535
7536 2020-02-22  Tom Tromey  <tom@tromey.com>
7537
7538         * tui/tui-layout.h (enum tui_adjust_result): New.
7539         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
7540         (class tui_layout_window) <adjust_size>: Return
7541         tui_adjust_result.  Rewrite.
7542         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
7543         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
7544
7545 2020-02-22  Tom Tromey  <tom@tromey.com>
7546
7547         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
7548         parameter and return types.
7549         (class tui_layout_base) <specification>: Add "depth".
7550         (class tui_layout_window) <specification>: Add "depth".
7551         (class tui_layout_split) <specification>: Add "depth".
7552         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
7553         and return types.
7554         (tui_new_layout_command): Parse sub-layouts.
7555         (_initialize_tui_layout): Update help string.
7556         (tui_layout_window::specification): Add "depth".
7557         (add_layout_command): Update.
7558
7559 2020-02-22  Tom Tromey  <tom@tromey.com>
7560
7561         * NEWS: Add "tui new-layout" item.
7562         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
7563         Add new-layout command to help text.
7564         (validate_window_name): New function.
7565         (tui_new_layout_command): New function.
7566         (_initialize_tui_layout): Register "new-layout".
7567         (tui_layout_window::specification): New method.
7568         (tui_layout_window::specification): New method.
7569         * tui/tui-layout.h (class tui_layout_base) <specification>: New
7570         method.
7571         (class tui_layout_window) <specification>: New method.
7572         (class tui_layout_split) <specification>: New method.
7573
7574 2020-02-22  Tom Tromey  <tom@tromey.com>
7575
7576         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
7577         * tui/tui-win.c (window_name_completer): Update comment.
7578         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
7579         Declare method.
7580         (class tui_layout_window) <replace_window>: Likewise.
7581         (class tui_layout_split) <replace_window>: Likewise.
7582         (tui_set_layout): Don't declare.
7583         (tui_set_initial_layout): Declare function.
7584         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
7585         (asm_regs_layout): New globals.
7586         (tui_current_layout, show_layout): Remove.
7587         (tui_set_layout, tui_add_win_to_layout): Rewrite.
7588         (find_layout, tui_apply_layout): New function.
7589         (layout_completer): Remove.
7590         (tui_next_layout): Reimplement.
7591         (tui_next_layout_command): New function.
7592         (tui_set_initial_layout, tui_prev_layout_command): New functions.
7593         (tui_regs_layout): Reimplement.
7594         (tui_regs_layout_command): New function.
7595         (extract_display_start_addr): Rewrite.
7596         (next_layout, prev_layout): Remove.
7597         (tui_layout_window::replace_window): New method.
7598         (tui_layout_split::replace_window): New method.
7599         (destroy_layout): New function.
7600         (layout_list): New global.
7601         (add_layout_command): New function.
7602         (initialize_layouts): Update.
7603         (tui_layout_command): New function.
7604         (_initialize_tui_layout): Install "layout" commands.
7605         * tui/tui-data.h (enum tui_layout_type): Remove.
7606         (tui_current_layout): Don't declare.
7607
7608 2020-02-22  Tom Tromey  <tom@tromey.com>
7609
7610         * tui/tui-regs.c (tui_reg_layout): Remove.
7611         (tui_reg_command): Use tui_regs_layout.
7612         * tui/tui-layout.h (tui_reg_command): Declare.
7613         * tui/tui-layout.c (tui_reg_command): New function.
7614
7615 2020-02-22  Tom Tromey  <tom@tromey.com>
7616
7617         * tui/tui.c (tui_rl_delete_other_windows): Call
7618         tui_remove_some_windows.
7619         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
7620         Declare method.
7621         (class tui_layout_window) <remove_windows>: New method.
7622         (class tui_layout_split) <remove_windows>: Declare.
7623         (tui_remove_some_windows): Declare.
7624         * tui/tui-layout.c (tui_remove_some_windows): New function.
7625         (tui_layout_split::remove_windows): New method.
7626
7627 2020-02-22  Tom Tromey  <tom@tromey.com>
7628
7629         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
7630         * tui/tui-layout.h (tui_next_layout): Declare.
7631         * tui/tui-layout.c (tui_next_layout): New function.
7632
7633 2020-02-22  Tom Tromey  <tom@tromey.com>
7634
7635         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
7636         correct coordinates.
7637
7638 2020-02-22  Tom Tromey  <tom@tromey.com>
7639
7640         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
7641         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
7642         DATA_WIN case.
7643
7644 2020-02-22  Tom Tromey  <tom@tromey.com>
7645
7646         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
7647         TUI_DISASM_WIN, not tui_win_list.
7648
7649 2020-02-22  Tom Tromey  <tom@tromey.com>
7650
7651         * valprint.c (generic_val_print_enum_1)
7652         (val_print_type_code_flags): Style member names.
7653         * rust-lang.c (val_print_struct, rust_print_enum)
7654         (rust_print_struct_def, rust_internal_print_type): Style member
7655         names.
7656         * p-valprint.c (pascal_object_print_value_fields): Style member
7657         names.  Only call fprintf_symbol_filtered for static members.
7658         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
7659         * f-valprint.c (f_val_print): Style member names.
7660         * f-typeprint.c (f_type_print_base): Style member names.
7661         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
7662         call fprintf_symbol_filtered for static members.
7663         (cp_print_class_member): Style member names.
7664         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
7665         member names.
7666         * ada-valprint.c (ada_print_scalar): Style enum names.
7667         (ada_val_print_enum): Likewise.
7668         * ada-typeprint.c (print_enum_type): Style enum names.
7669
7670 2020-02-21  Tom Tromey  <tom@tromey.com>
7671
7672         * psympriv.h (struct partial_symtab): Update comment.
7673
7674 2020-02-21  Tom Tromey  <tromey@adacore.com>
7675
7676         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
7677         type is CORE_ADDR.
7678
7679 2020-02-21  Tom de Vries  <tdevries@suse.de>
7680
7681         PR gdb/25534
7682         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
7683         if dependencies[i]->user != NULL.
7684
7685 2020-02-21  Ali Tamur  <tamur@google.com>
7686
7687         * dwarf2/read.c (dwarf2_name): Add null check.
7688
7689 2020-02-20  Tom Tromey  <tom@tromey.com>
7690
7691         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
7692         ">=", in binary search.
7693         (dwarf2_find_containing_comp_unit): New overload.
7694         (run_test): New self-test.
7695         (_initialize_dwarf2_read): Register new test.
7696
7697 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
7698
7699         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
7700         * riscv-tdep.h: Likewise.
7701         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
7702         rv32-only CSR.
7703         * features/riscv/64bit-csr.xml: Regenerated.
7704
7705 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
7706             Tom Tromey  <tom@tromey.com>
7707
7708         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
7709         of 'fputc_unfiltered'.
7710         (putchar_unfiltered): Call 'fputc_unfiltered'.
7711         (fputc_unfiltered): Call 'fputs_unfiltered'.
7712
7713 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
7714
7715         * config.in: Regenerate.
7716         * configure: Regenerate.
7717         * configure.ac: Add --with-python-libdir option.
7718         * main.c: Use WITH_PYTHON_LIBDIR.
7719
7720 2020-02-19  Tom Tromey  <tom@tromey.com>
7721
7722         * symtab.c (general_symbol_info::compute_and_set_names): Use
7723         obstack_strndup.  Simplify call to symbol_set_demangled_name.
7724
7725 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
7726
7727         * dwarf2/read.c (allocate_signatured_type_table,
7728         allocate_dwo_unit_table, allocate_type_unit_groups_table,
7729         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
7730         Remove objfile parameter, update all callers.
7731
7732 2020-02-19  Doug Evans  <dje@google.com>
7733
7734         PR rust/25535
7735         * rust-lang.c (rust_print_enum): Apply embedded_offset to
7736         rust_enum_variant calculation.
7737
7738 2020-02-19  Tom Tromey  <tromey@adacore.com>
7739
7740         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
7741
7742 2020-02-19  Tom Tromey  <tromey@adacore.com>
7743
7744         * ada-lang.c (cache_symbol): Use obstack_strdup.
7745
7746 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7747
7748         * configure: Regenerate.
7749
7750 2020-02-19  Tom Tromey  <tromey@adacore.com>
7751
7752         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
7753         NULL check.
7754
7755 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
7756
7757         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
7758
7759 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
7760
7761         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
7762         if GDBSERVER is not defined.
7763         (riscv_tdesc_cache): Likewise, also store const target_desc.
7764         (STATIC_IN_GDB): Define.
7765         (riscv_create_target_description): Update declaration with
7766         STATIC_IN_GDB.
7767         (riscv_lookup_target_description): New function, only define if
7768         GDBSERVER is not defined.
7769         * arch/riscv.h (riscv_create_target_description): Declare only
7770         when GDBSERVER is defined.
7771         (riscv_lookup_target_description): New declaration when GDBSERVER
7772         is not defined.
7773         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
7774         (riscv_linux_read_features): ...this, and return
7775         riscv_gdbarch_features instead of target_desc.
7776         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
7777         (riscv_linux_read_description): Rename to...
7778         (riscv_linux_read_features): ...this.
7779         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
7780         Update to use riscv_gdbarch_features and
7781         riscv_lookup_target_description.
7782         * riscv-tdep.c (riscv_find_default_target_description): Use
7783         riscv_lookup_target_description instead of
7784         riscv_create_target_description.
7785
7786 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7787
7788         * valprint.c (generic_val_print_enum_1): When printing a flag
7789         enum with value 0 and there is no enumerator with value 0, print
7790         just "0" instead of "(unknown: 0x0)".
7791
7792 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7793
7794         * valprint.c (generic_val_print_enum_1): Print unknown part of
7795         flag enum in hex.
7796
7797 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7798
7799         * dwarf2/read.c (update_enumeration_type_from_children): Allow
7800         flag enums to contain duplicate enumerators.
7801         * valprint.c (generic_val_print_enum_1): Update comment.
7802
7803 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7804
7805         * dwarf2/read.c: Include "count-one-bits.h".
7806         (update_enumeration_type_from_children): If an enumerator has
7807         multiple bits set, don't treat the enumeration as a "flag enum".
7808         * valprint.c (generic_val_print_enum_1): Assert that enumerators
7809         of flag enums have 0 or 1 bit set.
7810
7811 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
7812
7813         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
7814         conversion.
7815         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7816         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7817         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7818         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7819         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7820
7821 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
7822
7823         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
7824
7825 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7826
7827         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
7828         displaced_step_closure_up.
7829         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7830         (struct displaced_step_closure_up):
7831         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7832         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7833         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
7834         Likewise.
7835         * gdbarch.sh (displaced_step_copy_insn): Likewise.
7836         * gdbarch.c, gdbarch.h: Re-generate.
7837         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
7838         displaced_step_closure_up.
7839         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7840         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7841         * infrun.h (displaced_step_closure_up): New type alias.
7842         (struct displaced_step_inferior_state) <step_closure>: Change
7843         type to displaced_step_closure_up.
7844         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
7845         displaced_step_closure_up.
7846         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7847
7848 2020-02-14  Tom Tromey  <tom@tromey.com>
7849
7850         * minidebug.c (gnu_debug_key): New global.
7851         (find_separate_debug_file_in_section): Use it.
7852
7853 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7854
7855         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
7856         std::unique_ptr.
7857         * gdbarch.c: Re-generate.
7858         * gdbarch.h: Re-generate.
7859         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
7860         change.
7861         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
7862         type to std::unique_ptr.
7863         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
7864         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
7865         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
7866         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
7867         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
7868         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
7869         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
7870         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
7871         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
7872
7873 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7874
7875         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
7876         std::unique_ptr.
7877         (displaced_step_clear): Rename to...
7878         (displaced_step_reset): ... this.  Just call displaced->reset ().
7879         (displaced_step_clear_cleanup): Rename to...
7880         (displaced_step_reset_cleanup): ... this.
7881         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
7882         (displaced_step_fixup): Likewise.
7883         (resume_1): Likewise.
7884         (handle_inferior_event): Restore child's memory before calling
7885         displaced_step_fixup on the parent.
7886         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
7887         to std::unique_ptr.
7888         <step_closure>: Change type to std::unique_ptr.
7889
7890 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
7891
7892         * arm-tdep.c: Include count-one-bits.h.
7893         (cleanup_block_store_pc): Use count_one_bits.
7894         (cleanup_block_load_pc): Use count_one_bits.
7895         (arm_copy_block_xfer): Use count_one_bits.
7896         (thumb2_copy_block_xfer): Use count_one_bits.
7897         (thumb_copy_pop_pc_16bit): Use count_one_bits.
7898         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
7899         (thumb_get_next_pcs_raw): Use count_one_bits.
7900         (arm_get_next_pcs_raw): Use count_one_bits_l.
7901         * arch/arm.c (bitcount): Remove.
7902         * arch/arm.h (bitcount): Remove.
7903
7904 2020-02-14  Tom Tromey  <tromey@adacore.com>
7905
7906         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
7907         Update.
7908         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
7909         * dwarf2/loc.c (call_site_find_chain_1): Return
7910         unique_xmalloc_ptr.
7911         (call_site_find_chain): Likewise.
7912
7913 2020-02-14  Richard Biener  <rguenther@suse.de>
7914
7915         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
7916         on expression with division operators.
7917
7918 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
7919
7920         * MAINTAINERS (Write After Approval): Adding myself.
7921
7922 2020-02-12  Tom Tromey  <tom@tromey.com>
7923
7924         * event-loop.c (event_data, gdb_event, event_handler_func):
7925         Remove.
7926
7927 2020-02-12  Tom Tromey  <tom@tromey.com>
7928
7929         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
7930         (dwarf2_frame_objfile_data): Add comment.
7931         (find_comp_unit, set_comp_unit): New functions.
7932         (dwarf2_frame_find_fde): Use find_comp_unit.
7933         (dwarf2_build_frame_info): Use set_comp_unit.
7934
7935 2020-02-12  Tom Tromey  <tom@tromey.com>
7936
7937         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
7938         (comp_unit): Don't initialize objfile.
7939         (execute_cfa_program): Add text_offset parameter.
7940         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
7941         (dwarf2_frame_cache): Update.
7942         (dwarf2_build_frame_info): Don't set "objfile" member.
7943
7944 2020-02-12  Tom Tromey  <tom@tromey.com>
7945
7946         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
7947         (decode_frame_entry): Likewise.
7948         (dwarf2_build_frame_info): Update.
7949
7950 2020-02-12  Tom Tromey  <tom@tromey.com>
7951
7952         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
7953         (decode_frame_entry_1): Use the comp_unit obstack.
7954
7955 2020-02-12  Tom Tromey  <tom@tromey.com>
7956
7957         * dwarf2/frame.c (struct comp_unit): Add initializers and
7958         constructor.
7959         (dwarf2_frame_objfile_data): Store a comp_unit.
7960         (dwarf2_frame_find_fde): Update.
7961         (dwarf2_build_frame_info): Use "new".
7962
7963 2020-02-12  Tom Tromey  <tom@tromey.com>
7964
7965         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
7966         (dwarf2_fde_table): Typedef for std::vector.
7967         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
7968         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
7969         (decode_frame_entry): Update.
7970         (dwarf2_build_frame_info): Use "new".
7971
7972 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7973
7974         * arm-tdep.c (arm_gdbarch_init): Update.
7975         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
7976         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
7977         have_neon, is_m>: Change to bool.
7978
7979 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
7980
7981         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
7982
7983 2020-02-12  Tom Tromey  <tom@tromey.com>
7984
7985         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
7986
7987 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
7988
7989         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
7990         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
7991
7992 2020-02-11  Tom Tromey  <tom@tromey.com>
7993
7994         * psymtab.h: Update comment.
7995
7996 2020-02-11  Tom Tromey  <tom@tromey.com>
7997
7998         * gdb_obstack.h (struct auto_obstack): Use
7999         DISABLE_COPY_AND_ASSIGN.
8000
8001 2020-02-11  Tom Tromey  <tom@tromey.com>
8002
8003         * dwarf2/frame.h (struct objfile): Don't forward declare.
8004
8005 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8006
8007         * cris-tdep.c (cris_supply_gregset): Change signature to match
8008         what struct regset expects.
8009         (cris_regset): New struct.
8010         (fetch_core_registers): Remove.
8011         (cris_iterate_over_regset_sections): New function.
8012         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
8013         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
8014
8015 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8016
8017         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
8018         registers.
8019
8020 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
8021
8022         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
8023
8024 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8025
8026         * configure: Re-generate.
8027
8028 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8029
8030         * configure: Re-generate.
8031
8032 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
8033
8034         * acinclude: Update warning.m4 path.
8035         * warning.m4: Move to gdbsupport.
8036
8037 2020-02-11  Tom Tromey  <tromey@adacore.com>
8038
8039         * remote.c (remote_console_output): Update.
8040         * printcmd.c (printf_command): Update.
8041         * event-loop.c (gdb_wait_for_event): Update.
8042         * linux-nat.c (sigchld_handler): Update.
8043         * remote-sim.c (gdb_os_write_stdout): Update.
8044         (gdb_os_flush_stdout): Update.
8045         (gdb_os_flush_stderr): Update.
8046         (gdb_os_write_stderr): Update.
8047         * exceptions.c (print_exception): Update.
8048         * remote-fileio.c (remote_fileio_func_read): Update.
8049         (remote_fileio_func_write): Update.
8050         * tui/tui.c (tui_enable): Update.
8051         * tui/tui-interp.c (tui_interp::init): Update.
8052         * utils.c (init_page_info): Update.
8053         (putchar_unfiltered, fputc_unfiltered): Update.
8054         (gdb_flush): Update.
8055         (emit_style_escape): Update.
8056         (flush_wrap_buffer, fputs_maybe_filtered): Update.
8057         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
8058         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
8059         (stderr_file::write): Update.
8060         (stderr_file::puts): Update.
8061         * ui-file.h (ui_file_isatty, ui_file_write)
8062         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
8063         (ui_file_puts): Don't declare.
8064
8065 2020-02-10  Tom de Vries  <tdevries@suse.de>
8066
8067         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
8068         sentinel to char *.
8069
8070 2020-02-09  Tom de Vries  <tdevries@suse.de>
8071
8072         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
8073         filename if it matches "<artificial>".
8074
8075 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
8076
8077         * windows-tdep.c (struct enum_value_name): New struct.
8078         (create_enum): New function.
8079         (windows_get_siginfo_type): Create and use enum types.
8080
8081 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
8082
8083         * NEWS: Mention $_siginfo support for Windows.
8084         * windows-nat.c (handle_exception): Set siginfo_er.
8085         (windows_nat_target::mourn_inferior): Reset siginfo_er.
8086         (windows_xfer_siginfo): New function.
8087         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
8088         * windows-tdep.c (struct windows_gdbarch_data): New struct.
8089         (init_windows_gdbarch_data): New function.
8090         (get_windows_gdbarch_data): New function.
8091         (windows_get_siginfo_type): New function.
8092         (windows_init_abi): Register windows_get_siginfo_type.
8093         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
8094
8095 2020-02-08  Tom Tromey  <tom@tromey.com>
8096
8097         * dwarf2/read.c (class cutu_reader) <cutu_reader,
8098         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
8099         <keep>: Declare method.
8100         <m_keep>: Remove member.
8101         <~cutu_reader>: Remove.
8102         (cutu_reader::init_tu_and_read_dwo_dies): Update.
8103         (cutu_reader::cutu_reader): Update.
8104         (cutu_reader::keep): Rename from ~cutu_reader.
8105         (process_psymtab_comp_unit, build_type_psymtabs_1)
8106         (process_skeletonless_type_unit, load_partial_comp_unit)
8107         (load_full_comp_unit, dwarf2_read_addr_index)
8108         (read_signatured_type): Update.
8109
8110 2020-02-08  Tom Tromey  <tom@tromey.com>
8111
8112         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
8113         "want_partial_unit" parameter.
8114         (process_psymtab_comp_unit): Change want_partial_unit to bool.
8115         Inline check for DW_TAG_partial_unit.
8116         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
8117
8118 2020-02-08  Tom Tromey  <tom@tromey.com>
8119
8120         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
8121         read.c.
8122         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
8123         read.c.
8124
8125 2020-02-08  Tom Tromey  <tom@tromey.com>
8126
8127         * dwarf2/read.c (read_address): Move to comp-unit.c.
8128         (dwarf2_rnglists_process, dwarf2_ranges_process)
8129         (read_attribute_value, dwarf_decode_lines_1)
8130         (var_decode_location, decode_locdesc): Update.
8131         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
8132         read.c.  Remove "cu" parameter.
8133         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
8134         method.
8135
8136 2020-02-08  Tom Tromey  <tom@tromey.com>
8137
8138         * dwarf2/read.c (read_attribute_value, read_indirect_string)
8139         (read_indirect_line_string): Update.
8140         * dwarf2/comp-unit.c (read_offset): Remove.
8141         (read_comp_unit_head): Update.
8142         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
8143         method.
8144         (read_offset): Don't declare.
8145
8146 2020-02-08  Tom Tromey  <tom@tromey.com>
8147
8148         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
8149         * dwarf2/read.c (struct comp_unit_head): Move to
8150         dwarf2/comp-unit.h.
8151         (enum class rcuh_kind): Move to comp-unit.h.
8152         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
8153         (read_comp_unit_head, error_check_comp_unit_head)
8154         (read_and_check_comp_unit_head): Move to comp-unit.c.
8155         (read_offset, dwarf_unit_type_name): Likewise.
8156         (create_debug_type_hash_table, read_cutu_die_from_dwo)
8157         (cutu_reader::cutu_reader, read_call_site_scope)
8158         (find_partial_die, follow_die_offset): Update.
8159         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
8160
8161 2020-02-08  Tom Tromey  <tom@tromey.com>
8162
8163         * dwarf2/read.c (read_offset_1): Move to leb.c.
8164         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
8165         (dwarf_decode_macro_bytes): Update.
8166         * dwarf2/leb.c (read_offset): Rename; move from read.c.
8167         * dwarf2/leb.h (read_offset): Declare.
8168
8169 2020-02-08  Tom Tromey  <tom@tromey.com>
8170
8171         * dwarf2/read.c (dwarf2_section_size): Remove.
8172         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
8173         Update.
8174         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
8175
8176 2020-02-08  Tom Tromey  <tom@tromey.com>
8177
8178         * dwarf2/read.c (read_initial_length): Move to leb.c.
8179         * dwarf2/leb.h (read_initial_length): Declare.
8180         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
8181         handle_nonstd parameter.
8182         * dwarf2/frame.c (read_initial_length): Remove.
8183         (decode_frame_entry_1): Update.
8184
8185 2020-02-08  Tom Tromey  <tom@tromey.com>
8186
8187         * dwarf2/loc.c (dwarf2_find_location_expression)
8188         (dwarf_evaluate_loc_desc::get_tls_address)
8189         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
8190         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
8191         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
8192         (dwarf2_compile_property_to_c)
8193         (dwarf2_loc_desc_get_symbol_read_needs)
8194         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
8195         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
8196         (loclist_describe_location, loclist_tracepoint_var_ref)
8197         (loclist_generate_c_location): Update.
8198         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
8199         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
8200         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
8201         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
8202         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
8203         (dwarf2_per_cu_data::addr_size)
8204         (dwarf2_per_cu_data::ref_addr_size)
8205         (dwarf2_per_cu_data::text_offset)
8206         (dwarf2_per_cu_data::addr_type): Now methods.
8207         (per_cu_header_read_in): Make per_cu "const".
8208         (dwarf2_version): Remove.
8209         (dwarf2_per_cu_data::int_type): Now a method.
8210         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
8211         (set_die_type, read_array_type, read_subrange_index_type)
8212         (read_tag_string_type, read_subrange_type): Update.
8213         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
8214         offset_size, ref_addr_size, text_offset, addr_type, version,
8215         objfile, int_type, addr_sized_int_type>: Declare methods.
8216
8217 2020-02-08  Tom Tromey  <tom@tromey.com>
8218
8219         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
8220         Move earlier.
8221
8222 2020-02-08  Tom Tromey  <tom@tromey.com>
8223
8224         * dwarf2/read.h (dwarf_line_debug): Declare.
8225         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
8226         * dwarf2/read.c: Move line_header code to new files.
8227         (dwarf_line_debug): No longer static.
8228         * dwarf2/line-header.c: New file.
8229         * dwarf2/line-header.h: New file.
8230
8231 2020-02-08  Tom Tromey  <tom@tromey.com>
8232
8233         * dwarf2/read.c (struct line_header) <file_full_name,
8234         file_file_name>: Return unique_xmalloc_ptr.
8235         (line_header::file_file_name): Update.
8236         (line_header::file_full_name): Update.
8237         (dw2_get_file_names_reader): Update.
8238         (macro_start_file): Update.
8239
8240 2020-02-08  Tom Tromey  <tom@tromey.com>
8241
8242         * dwarf2/read.c (struct line_header) <file_full_name,
8243         file_file_name>: Declare methods.
8244         (dw2_get_file_names_reader): Update.
8245         (file_file_name): Now a method.
8246         (file_full_name): Likewise.
8247         (macro_start_file): Update.
8248
8249 2020-02-08  Tom Tromey  <tom@tromey.com>
8250
8251         * dwarf2/read.c (dwarf_always_disassemble)
8252         (show_dwarf_always_disassemble): Move to loc.c.
8253         (_initialize_dwarf2_read): Move "always-disassemble" registration
8254         to loc.c.
8255         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
8256         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
8257         static.
8258         (show_dwarf_always_disassemble): Move from read.c.
8259         (_initialize_dwarf2loc): Move always-disassemble from read.c.
8260
8261 2020-02-08  Tom Tromey  <tom@tromey.com>
8262
8263         * dwarf2/read.c (~dwarf2_per_objfile): Update.
8264         (create_quick_file_names_table): Return htab_up.
8265         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
8266         Update.
8267         * dwarf2/read.h (struct dwarf2_per_objfile)
8268         <quick_file_names_table>: Now htab_up.
8269
8270 2020-02-08  Tom Tromey  <tom@tromey.com>
8271
8272         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
8273
8274 2020-02-08  Tom Tromey  <tom@tromey.com>
8275
8276         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
8277         Rewrite.
8278         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
8279         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
8280         (abbrev_table::abbrev_table): No longer inline.
8281         (ABBREV_HASH_SIZE): Remove.
8282         (abbrev_table::m_abbrevs): Now an htab_up.
8283
8284 2020-02-08  Tom Tromey  <tom@tromey.com>
8285
8286         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
8287         (cutu_reader): Update.
8288         (build_type_psymtabs_1): Update.
8289         * dwarf2/abbrev.c (abbrev_table::read): Rename.
8290         (abbrev_table::alloc_abbrev): Update.
8291         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
8292         (abbrev_table::read): New static method, renamed from
8293         abbrev_table_read_table.
8294         (abbrev_table::alloc_abbrev)
8295         (abbrev_table::add_abbrev): Now private.
8296         (abbrev_table::abbrev_table): Now private.
8297         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
8298
8299 2020-02-08  Tom Tromey  <tom@tromey.com>
8300
8301         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
8302         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
8303         htab_up.
8304
8305 2020-02-08  Tom Tromey  <tom@tromey.com>
8306
8307         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
8308         htab_up.
8309         (lookup_dwo_unit_in_dwp): Update.
8310         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
8311         on obstack.
8312
8313 2020-02-08  Tom Tromey  <tom@tromey.com>
8314
8315         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
8316         obstack.
8317
8318 2020-02-08  Tom Tromey  <tom@tromey.com>
8319
8320         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
8321         line_header_hash.
8322         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
8323         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
8324         Change type to htab_up.
8325
8326 2020-02-08  Tom Tromey  <tom@tromey.com>
8327
8328         * dwarf2/read.c (allocate_type_unit_groups_table): Return
8329         htab_up.  Don't allocate on obstack.
8330         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
8331         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
8332         Change type to htab_up.
8333
8334 2020-02-08  Tom Tromey  <tom@tromey.com>
8335
8336         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
8337         Change type to htab_up.
8338         * dwarf2/read.c (create_signatured_type_table_from_index)
8339         (create_signatured_type_table_from_debug_names)
8340         (create_all_type_units, add_type_unit)
8341         (lookup_dwo_signatured_type, lookup_signatured_type)
8342         (process_skeletonless_type_unit): Update.
8343         (create_debug_type_hash_table, create_debug_types_hash_table):
8344         Change type of types_htab.
8345         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
8346         htab_up.  Don't allocate on obstack.
8347         (create_cus_hash_table): Change type of cus_htab parameter.
8348         (struct dwo_file) <cus, tus>: Now htab_up.
8349         (lookup_dwo_signatured_type, lookup_dwo_cutu)
8350         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
8351         (queue_and_load_all_dwo_tus): Update.
8352         * dwarf2/index-write.c (write_gdbindex): Update.
8353         (write_debug_names): Update.
8354
8355 2020-02-08  Tom Tromey  <tom@tromey.com>
8356
8357         * dwarf2/read.h (struct dwarf2_queue_item): Move from
8358         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
8359         destructor.
8360         (struct dwarf2_per_objfile) <queue>: New member.
8361         * dwarf2/read.c (struct dwarf2_queue_item): Move to
8362         dwarf2/read.h.
8363         (dwarf2_queue, dwarf2_queue_tail): Remove.
8364         (class dwarf2_queue_guard): Add parameter to constructor.  Use
8365         DISABLE_COPY_AND_ASSIGN.
8366         <m_per_objfile>: New member.
8367         <~dwarf2_queue_guard>: Rewrite.
8368         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
8369         Update.
8370         (~dwarf2_queue_item): New.
8371
8372 2020-02-08  Tom Tromey  <tom@tromey.com>
8373
8374         * dwarf2/read.c (struct die_info) <has_children>: New member.
8375         (dw2_get_file_names_reader): Remove has_children.
8376         (dw2_get_file_names): Update.
8377         (read_cutu_die_from_dwo): Remove has_children.
8378         (cutu_reader::init_tu_and_read_dwo_dies)
8379         (cutu_reader::cutu_reader): Update.
8380         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
8381         Remove has_children.
8382         (build_type_psymtabs_1, process_skeletonless_type_unit)
8383         (load_partial_comp_unit, load_full_comp_unit): Update.
8384         (create_dwo_cu_reader): Remove has_children.
8385         (create_cus_hash_table, read_die_and_children): Update.
8386         (read_full_die_1,read_full_die): Remove has_children.
8387         (read_signatured_type): Update.
8388         (class cutu_reader) <has_children>: Remove.
8389
8390 2020-02-08  Tom Tromey  <tom@tromey.com>
8391
8392         * dwarf2/expr.c: Rename from dwarf2expr.c.
8393         * dwarf2/expr.h: Rename from dwarf2expr.h.
8394         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
8395         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
8396         * dwarf2/frame.c: Rename from dwarf2-frame.c.
8397         * dwarf2/frame.h: Rename from dwarf2-frame.h.
8398         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
8399         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
8400         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
8401         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
8402         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
8403         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
8404         * dwarf2/loc.c: Rename from dwarf2loc.c.
8405         * dwarf2/loc.h: Rename from dwarf2loc.h.
8406         * dwarf2/read.c: Rename from dwarf2read.c.
8407         * dwarf2/read.h: Rename from dwarf2read.h.
8408         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
8409         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
8410         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
8411         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
8412         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
8413         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
8414         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
8415         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
8416         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
8417         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
8418         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
8419         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
8420         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
8421         Update.
8422         * Makefile.in (COMMON_SFILES): Update.
8423         (HFILES_NO_SRCDIR): Update.
8424
8425 2020-02-08  Tom Tromey  <tom@tromey.com>
8426
8427         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
8428         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
8429
8430 2020-02-08  Tom Tromey  <tom@tromey.com>
8431
8432         * dwarf2read.h (struct die_info): Don't declare.
8433
8434 2020-02-08  Tom Tromey  <tom@tromey.com>
8435
8436         * dwarf2read.h (die_info_ptr): Remove typedef.
8437
8438 2020-02-08  Tom Tromey  <tom@tromey.com>
8439
8440         * dwarf2read.c (read_call_site_scope)
8441         (handle_data_member_location, dwarf2_add_member_fn)
8442         (mark_common_block_symbol_computed, read_common_block)
8443         (attr_to_dynamic_prop, partial_die_info::read)
8444         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
8445         (dwarf2_symbol_mark_computed, set_die_type): Update.
8446         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
8447         method.
8448         (attr_form_is_block): Don't declare.
8449         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
8450
8451 2020-02-08  Tom Tromey  <tom@tromey.com>
8452
8453         * dwarf2read.c (dwarf2_find_base_address, )
8454         (read_call_site_scope, rust_containing_type)
8455         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
8456         (handle_data_member_location, dwarf2_add_member_fn)
8457         (get_alignment, read_structure_type, process_structure_scope)
8458         (mark_common_block_symbol_computed, read_common_block)
8459         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
8460         (partial_die_info::read, read_attribute_value, new_symbol)
8461         (lookup_die_type, dwarf2_get_ref_die_offset)
8462         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
8463         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
8464         (dwarf2_symbol_mark_computed): Update.
8465         * dwarf2/attribute.h (struct attribute) <value_as_address,
8466         form_is_section_offset, form_is_constant, form_is_ref>: Declare
8467         methods.
8468         (value_as_address, attr_form_is_section_offset)
8469         (attr_form_is_constant, attr_form_is_ref): Don't declare.
8470         * dwarf2/attribute.c (attribute::value_as_address)
8471         (attribute::form_is_section_offset, attribute::form_is_constant)
8472         (attribute::form_is_ref): Now methods.
8473
8474 2020-02-08  Tom Tromey  <tom@tromey.com>
8475
8476         * dwarf2read.c (struct attribute, DW_STRING)
8477         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
8478         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
8479         (attr_form_is_block, attr_form_is_section_offset)
8480         (attr_form_is_constant, attr_form_is_ref): Move.
8481         * dwarf2/attribute.h: New file.
8482         * dwarf2/attribute.c: New file, from dwarf2read.c.
8483         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
8484
8485 2020-02-08  Tom Tromey  <tom@tromey.com>
8486
8487         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
8488         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
8489         Move.
8490         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
8491         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
8492         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
8493         abbrev.c.
8494         * dwarf2/abbrev.h: New file.
8495         * dwarf2/abbrev.c: New file, from dwarf2read.c.
8496         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
8497
8498 2020-02-08  Tom Tromey  <tom@tromey.com>
8499
8500         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
8501         (dwarf2_section_size, dwarf2_get_section_info)
8502         (create_signatured_type_table_from_debug_names)
8503         (create_addrmap_from_aranges, read_debug_names_from_section)
8504         (get_gdb_index_contents_from_section, read_comp_unit_head)
8505         (error_check_comp_unit_head, read_abbrev_offset)
8506         (create_debug_type_hash_table, init_cu_die_reader)
8507         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
8508         (read_comp_units_from_section, create_cus_hash_table)
8509         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
8510         (create_dwp_v2_section, dwarf2_rnglists_process)
8511         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
8512         (abbrev_table_read_table, read_indirect_string_at_offset_from)
8513         (read_indirect_string_from_dwz, read_addr_index_1)
8514         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
8515         (dwarf_decode_macro_bytes, dwarf_decode_macros)
8516         (fill_in_loclist_baton): Update.
8517         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
8518         get_containing_section, get_bfd_owner, get_bfd_section,
8519         get_file_name, get_id, get_flags, empty, read>: Declare methods.
8520         (dwarf2_read_section, get_section_name, get_section_file_name)
8521         (get_containing_section, get_section_bfd_owner)
8522         (get_section_bfd_section, get_section_name, get_section_file_name)
8523         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
8524         declare.
8525         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
8526         (dwarf2_section_info::get_bfd_owner)
8527         (dwarf2_section_info::get_bfd_section)
8528         (dwarf2_section_info::get_name)
8529         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
8530         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
8531         (dwarf2_section_info::read): Now methods.
8532         * dwarf-index-write.c (class debug_names): Update.
8533
8534 2020-02-08  Tom Tromey  <tom@tromey.com>
8535
8536         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
8537         Move to dwarf2/section.h.
8538         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
8539         (get_section_bfd_section, get_section_name)
8540         (get_section_file_name, get_section_id, get_section_flags)
8541         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
8542         dwarf2/section.c.
8543         * dwarf2/section.h: New file.
8544         * dwarf2/section.c: New file, from dwarf2read.c.
8545         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
8546
8547 2020-02-08  Tom Tromey  <tom@tromey.com>
8548
8549         * dwarf2read.h (read_unsigned_leb128): Don't declare.
8550         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
8551         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
8552         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
8553         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
8554         * dwarf2/leb.h: New file, from dwarf2read.c.
8555         * dwarf2/leb.c: New file, from dwarf2read.c.
8556         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
8557         Remove.
8558         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
8559         (COMMON_SFILES): Add dwarf2/leb.c.
8560
8561 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
8562
8563         GDB 9.1 released.
8564
8565 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8566
8567         PR gdb/25190:
8568         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
8569         * gdb/remote.c (remote_console_output): Update.
8570         * gdb/ui-file.c (fputs_unfiltered): Rename to...
8571         (ui_file_puts): ...this.
8572         * gdb/ui-file.h (ui_file_puts): Add declaration.
8573         * gdb/utils.c (emit_style_escape): Update.
8574         (flush_wrap_buffer): Update.
8575         (fputs_maybe_filtered): Update.
8576         (fputs_unfiltered): Add function.
8577
8578 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
8579
8580         * gdb/event-loop.c (gdb_wait_for_event): Update.
8581         * gdb/printcmd.c (printf_command): Update.
8582         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
8583         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
8584         (gdb_os_flush_stderr): Update.
8585         * gdb/remote.c (remote_console_output): Update.
8586         * gdb/ui-file.c (gdb_flush): Rename to...
8587         (ui_file_flush): ...this.
8588         (stderr_file::write): Update.
8589         (stderr_file::puts): Update.
8590         * gdb/ui-file.h (gdb_flush): Rename to...
8591         (ui_file_flush): ...this.
8592         * gdb/utils.c (gdb_flush): Add function.
8593         * gdb/utils.h (gdb_flush): Add declaration.
8594
8595 2020-02-07  Tom Tromey  <tromey@adacore.com>
8596
8597         PR breakpoints/24915:
8598         * source.c (find_and_open_source): Do not check basenames_may_differ.
8599
8600 2020-02-07  Tom Tromey  <tom@tromey.com>
8601
8602         * README: Update gdbserver documentation.
8603         * gdbserver: Move to top level.
8604         * configure.tgt (build_gdbserver): Remove.
8605         * configure.ac: Remove --enable-gdbserver.
8606         * configure: Rebuild.
8607         * Makefile.in (distclean): Don't mention gdbserver.
8608
8609 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8610
8611         * source-cache.c (source_cache::ensure): Surround
8612         get_plain_source_lines with a try/catch.
8613         (source_cache::get_line_charpos): Get rid of try/catch
8614         and only check for the return value of "ensure".
8615         * tui/tui-source.c (tui_source_window::set_contents):
8616         Simplify "nlines" calculation.
8617
8618 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
8619
8620         * MAINTAINERS (Write After Approval): Add myself.
8621
8622 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8623
8624         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
8625         function call.
8626
8627 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
8628
8629         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
8630
8631 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
8632
8633         * nat/riscv-linux-tdesc.h: New file.
8634         * nat/riscv-linux-tdesc.c: New file, taking code from...
8635         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
8636         ... here.
8637         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
8638         NATDEPFILES.
8639
8640 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
8641
8642         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
8643         we don't set the fake simulator ptid to the null_ptid.
8644
8645 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
8646
8647         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
8648         * gdbthread.h (class thread_info) <resumed>: Likewise.
8649         * infrun.c (resume_1): Likewise.
8650         (proceed): Likewise.
8651         (infrun_thread_stop_requested): Likewise.
8652         (stop_all_threads): Likewise.
8653         (handle_inferior_event): Likewise.
8654         (restart_threads): Likewise.
8655         (finish_step_over): Likewise.
8656         (keep_going_stepped_thread): Likewise.
8657         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
8658         (linux_handle_extended_wait): Likewise.
8659         * record-btrace.c (get_thread_current_frame_id): Likewise.
8660         * record-full.c (record_full_wait_1): Likewise.
8661         * remote.c (remote_target::process_initial_stop_replies): Likewise.
8662         * target.c (target_resume): Likewise.
8663         * thread.c (set_running_thread): Likewise.
8664
8665 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
8666
8667         * f-valprint.c (f77_print_array_1): Changed datatype of index
8668         variable to LONGEST from int to enable it to contain bound
8669         values correctly.
8670
8671 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
8672
8673         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
8674         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
8675         offsets according to FLEN determined.
8676         (riscv_linux_nat_target::read_description): Determine FLEN
8677         dynamically.
8678         (riscv_linux_nat_target::fetch_registers): Size regset buffer
8679         according to FLEN determined.
8680         (riscv_linux_nat_target::store_registers): Likewise.
8681
8682 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
8683
8684         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
8685         when reg->group is empty and reggroup is not.
8686
8687 2020-01-31  Tom Tromey  <tromey@adacore.com>
8688
8689         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
8690         Call beneath target's mourn_inferior after unpushing.
8691
8692 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8693
8694         PR tui/9765
8695         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
8696         have enough lines to fill the screen, still return the lowest
8697         address we found.
8698
8699 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
8700
8701         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
8702         '-', '<', and '>' commands.
8703
8704 2020-01-29  Pedro Alves  <palves@redhat.com>
8705             Sergio Durigan Junior  <sergiodj@redhat.com>
8706
8707         * infcmd.c (construct_inferior_arguments): Assert that
8708         'argc' is greater than 0.
8709
8710 2020-01-29  Luis Machado  <luis.machado@linaro.org>
8711
8712         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
8713         (BRK_INSN_MASK): Define to 0xd4200000.
8714         (aarch64_program_breakpoint_here_p): New function.
8715         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
8716         * arch-utils.c (default_program_breakpoint_here_p): Moved from
8717         breakpoint.c.
8718         * arch-utils.h (default_program_breakpoint_here_p): Moved from
8719         breakpoint.h
8720         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
8721         call gdbarch_program_breakpoint_here_p.
8722         (program_breakpoint_here): Moved to arch-utils.c, renamed to
8723         default_program_breakpoint_here_p, changed return type to bool and
8724         simplified.
8725         * breakpoint.h (program_breakpoint_here): Moved prototype to
8726         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
8727         return type to bool.
8728         * gdbarch.c: Regenerate.
8729         * gdbarch.h: Regenerate.
8730         * gdbarch.sh (program_breakpoint_here_p): New method.
8731         * infrun.c (handle_signal_stop): Call
8732         gdbarch_program_breakpoint_here_p.
8733
8734 2020-01-26  Tom Tromey  <tom@tromey.com>
8735
8736         * ctfread.c (struct ctf_fp_info): Reindent.
8737         (_initialize_ctfread): Remove.
8738
8739 2020-01-26  Tom Tromey  <tom@tromey.com>
8740
8741         * psymtab.c (partial_map_expand_apply)
8742         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
8743         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
8744         (psym_print_stats, psym_expand_symtabs_for_function)
8745         (psym_map_symbol_filenames, psym_map_matching_symbols)
8746         (psym_expand_symtabs_matching)
8747         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
8748         (maintenance_check_psymtabs): Use new methods.
8749         * psympriv.h (struct partial_symtab) <readin_p,
8750         get_compunit_symtab>: New methods.
8751         <readin, compunit_symtab>: Remove members.
8752         (struct standard_psymtab): New.
8753         (struct legacy_psymtab): Derive from standard_psymtab.
8754         * dwarf2read.h (struct dwarf2_psymtab): Derive from
8755         standard_psymtab.
8756         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
8757
8758 2020-01-26  Tom Tromey  <tom@tromey.com>
8759
8760         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
8761         read_dependencies.  Add assert.
8762         * psymtab.c (partial_symtab::read_dependencies): New method.
8763         * psympriv.h (struct partial_symtab) <read_dependencies>: New
8764         method.
8765         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
8766         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
8767         read_dependencies.
8768         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
8769         Add assert.
8770
8771 2020-01-26  Tom Tromey  <tom@tromey.com>
8772
8773         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
8774         Call expand_psymtab.
8775         (xcoff_read_symtab): Call expand_psymtab.
8776         (xcoff_start_psymtab, xcoff_end_psymtab): Set
8777         legacy_expand_psymtab.
8778         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
8779         method.
8780         (struct legacy_psymtab) <expand_psymtab>: Implement.
8781         <legacy_expand_psymtab>: New member.
8782         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
8783         (parse_partial_symbols): Set legacy_expand_psymtab.
8784         (psymtab_to_symtab_1): Change argument order.  Call
8785         expand_psymtab.
8786         (new_psymtab): Set legacy_expand_psymtab.
8787         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
8788         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
8789         expand_psymtab.
8790         (dwarf2_psymtab::expand_psymtab): Rename from
8791         psymtab_to_symtab_1.  Call expand_psymtab.
8792         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
8793         (dbx_end_psymtab): Likewise.
8794         (dbx_psymtab_to_symtab_1): Change argument order. Call
8795         expand_psymtab.
8796         (dbx_read_symtab): Call expand_psymtab.
8797         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
8798         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
8799         (ctf_psymtab::read_symtab): Call expand_psymtab.
8800
8801 2020-01-26  Tom Tromey  <tom@tromey.com>
8802
8803         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
8804         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
8805         messages.
8806         * mdebugread.c (mdebug_read_symtab): Remove prints.
8807         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
8808         assert.
8809         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
8810
8811 2020-01-26  Tom Tromey  <tom@tromey.com>
8812
8813         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
8814         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
8815         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
8816         legacy_symtab.
8817         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
8818         * psymtab.c (psymtab_to_symtab): Call method.
8819         (dump_psymtab): Update.
8820         * psympriv.h (struct partial_symtab): Add virtual destructor.
8821         <read_symtab>: New method.
8822         (struct legacy_symtab): New.
8823         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
8824         (struct pst_map) <pst>: Now a legacy_psymtab.
8825         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
8826         (new_psymtab): Use legacy_psymtab.
8827         * dwarf2read.h (struct dwarf2_psymtab): New.
8828         (struct dwarf2_per_cu_data) <psymtab>: Use it.
8829         * dwarf2read.c (dwarf2_create_include_psymtab)
8830         (dwarf2_build_include_psymtabs, create_type_unit_group)
8831         (create_partial_symtab, process_psymtab_comp_unit_reader)
8832         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
8833         (set_partial_user): Use dwarf2_psymtab.
8834         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
8835         (psymtab_to_symtab_1, process_full_comp_unit)
8836         (process_full_type_unit, dwarf2_ranges_read)
8837         (dwarf2_get_pc_bounds, psymtab_include_file_name)
8838         (dwarf_decode_lines): Use dwarf2_psymtab.
8839         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
8840         (add_address_entry_worker, write_one_signatured_type)
8841         (recursively_count_psymbols, recursively_write_psymbols)
8842         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
8843         (write_debug_names): Likewise.
8844         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
8845         <pst>: Now a legacy_psymtab.
8846         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
8847         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
8848         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
8849         * ctfread.c (struct ctf_psymtab): New.
8850         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
8851         ctf_psymtab.
8852         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
8853         (create_partial_symtab): Return a ctf_psymtab.
8854         (scan_partial_symbols): Update.
8855
8856 2020-01-26  Tom Tromey  <tom@tromey.com>
8857
8858         * xcoffread.c (xcoff_start_psymtab): Use new.
8859         * psymtab.c (partial_symtab::partial_symtab): New constructor,
8860         renamed from start_psymtab_common.
8861         * psympriv.h (struct partial_symtab): Add new constructor.
8862         (start_psymtab_common): Don't declare.
8863         * mdebugread.c (parse_partial_symbols): Use new.
8864         * dwarf2read.c (create_partial_symtab): Use new.
8865         * dbxread.c (start_psymtab): Use new.
8866         * ctfread.c (create_partial_symtab): Use new.
8867
8868 2020-01-26  Tom Tromey  <tom@tromey.com>
8869
8870         * xcoffread.c (xcoff_end_psymtab): Use new.
8871         * psymtab.c (start_psymtab_common): Use new.
8872         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
8873         Update.
8874         * psympriv.h (struct partial_symtab): Add parameters to
8875         constructor.  Don't inline.
8876         (allocate_psymtab): Don't declare.
8877         * mdebugread.c (new_psymtab): Use new.
8878         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
8879         * dbxread.c (dbx_end_psymtab): Use new.
8880
8881 2020-01-26  Tom Tromey  <tom@tromey.com>
8882
8883         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
8884         allocate_psymtab.  Update documentation.
8885         * psymtab.c (psymtab_storage::install_psymtab): Rename from
8886         allocate_psymtab.  Do not use new.
8887         (allocate_psymtab): Use new.  Update.
8888
8889 2020-01-26  Tom Tromey  <tom@tromey.com>
8890
8891         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
8892         * psymtab.c (psym_print_stats): Update.
8893         * psympriv.h (struct partial_symtab) <readin,
8894         psymtabs_addrmap_supported, anonymous>: Now bool.
8895         * mdebugread.c (psymtab_to_symtab_1): Update.
8896         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
8897         (build_type_psymtabs_reader, psymtab_to_symtab_1)
8898         (process_full_comp_unit, process_full_type_unit): Update.
8899         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
8900         * ctfread.c (psymtab_to_symtab): Update.
8901
8902 2020-01-26  Tom Tromey  <tom@tromey.com>
8903
8904         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
8905         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
8906         * psymtab.c (psymtab_storage): Delete psymtabs.
8907         (psymtab_storage::allocate_psymtab): Use new.
8908         (psymtab_storage::discard_psymtab): Use delete.
8909         * psympriv.h (struct partial_symtab): Add constructor and
8910         initializers.
8911
8912 2020-01-26  Tom Tromey  <tom@tromey.com>
8913
8914         * machoread.c: Do not include psympriv.h.
8915
8916 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8917
8918         * NEWS: Mention the new option and the set/show commands.
8919
8920 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8921
8922         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
8923         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
8924         (validate_exec_file): New variables, enums, functions.
8925         (exec_file_locate_attach, print_section_info): Style the filenames.
8926         (_initialize_exec): Install show_exec_file_mismatch_command and
8927          set_exec_file_mismatch_command.
8928         * gdbcore.h (validate_exec_file): Declare.
8929         * infcmd.c (attach_command): Call validate_exec_file.
8930         * remote.c ( remote_target::remote_add_inferior): Likewise.
8931
8932 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * frame.c (find_frame_sal): Move call to get_next_frame into more
8935         inner scope.
8936         * inline-frame.c (inilne_state) <inline_state>: Update argument
8937         types.
8938         (inilne_state) <skipped_symbol>: Rename to...
8939         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
8940         (skip_inline_frames): Build vector of skipped symbols and use this
8941         to reate the inline_state.
8942         (inline_skipped_symbol): Add a comment and some assertions, fetch
8943         skipped symbol from the list.
8944
8945 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8946
8947         * buildsym.c (lte_is_less_than): Delete.
8948         (buildsym_compunit::end_symtab_with_blockvector): Create local
8949         lambda function to sort line table entries, and use
8950         std::stable_sort instead of std::sort.
8951         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
8952         markers when looking for a previous line.
8953
8954 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
8955
8956         * dwarf2read.c (lnp_state_machine::record_line): Include
8957         end_sequence parameter in debug print out.  Record the line if we
8958         are at an end_sequence marker even if it's not the start of a
8959         statement.
8960         * symmisc.c (maintenance_print_one_line_table): Print end of
8961         sequence markers with 'END' not '0'.
8962
8963 2020-01-24  Pedro Alves  <palves@redhat.com>
8964
8965         PR gdb/25410
8966         * thread.c (scoped_restore_current_thread::restore): Use
8967         switch_to_inferior_no_thread.
8968         * exec.c: Include "progspace-and-thread.h".
8969         (add_target_sections, remove_target_sections):
8970         scoped_restore_current_pspace_and_thread instead of
8971         scoped_restore_current_thread.
8972         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
8973         and aspace to the inferior before calling clone_program_space.
8974         Remove stale comment.
8975
8976 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8977
8978         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
8979         (arm_netbsd_nat_target::fetch_registers): ...this.
8980         (arm_nbsd_nat_target::store_registers): Rename to...
8981         (arm_netbsd_nat_target::store_registers): ...this.
8982
8983 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8984
8985         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
8986         register_t.
8987
8988 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
8989
8990         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
8991         Update comment.
8992         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
8993         Likewise.
8994         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
8995         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
8996         the correct replacement (iterate_over_regset_sections).
8997         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
8998         Update comment.
8999
9000 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
9001
9002         PR gdb/23718
9003         * gdb/python/python.c (execute_gdb_command): Call
9004         async_enable_stdin in catch block.
9005
9006 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9007
9008         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
9009         SWITCH_THRU_ALL_UIS.
9010
9011 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
9012
9013         PR tui/9765
9014         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
9015         comment, add extra parameter, and update to store previous symbol
9016         when appropriate.
9017         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
9018         add extra parameter.
9019         * tui/tui-disasm.c (tui_disassemble): Update header comment,
9020         remove unneeded parameter, add try/catch around gdb_print_insn,
9021         rewrite to add items to asm_lines vector.
9022         (tui_find_backward_disassembly_start_address): New function.
9023         (tui_find_disassembly_address): Updated throughout.
9024         (tui_disasm_window::set_contents): Update for changes to
9025         tui_disassemble.
9026         (tui_disasm_window::do_scroll_vertical): No need to adjust the
9027         number of lines to scroll.
9028
9029 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
9030
9031         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
9032         (SECT_OFF_DATA): Likewise.
9033         (SECT_OFF_RODATA): Likewise.
9034         (SECT_OFF_TEXT): Likewise.
9035         (SECT_OFF_BSS): Likewise.
9036         (struct objfile) <text_section_offset, data_section_offset>: New
9037         methods.
9038         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
9039         objfile::text_section_offset.
9040         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
9041         * coffread.c (coff_symtab_read): Likewise.
9042         (enter_linenos): Likewise.
9043         (process_coff_symbol): Likewise.
9044         * ctfread.c (get_objfile_text_range): Likewise.
9045         * dtrace-probe.c (dtrace_probe::get_relocated_address):
9046         Use objfile::data_section_offset.
9047         * dwarf2-frame.c (execute_cfa_program): Use
9048         objfile::text_section_offset.
9049         (dwarf2_frame_find_fde): Likewise.
9050         * dwarf2read.c (create_addrmap_from_index): Likewise.
9051         (create_addrmap_from_aranges): Likewise.
9052         (dw2_find_pc_sect_compunit_symtab): Likewise.
9053         (process_psymtab_comp_unit_reader): Likewise.
9054         (add_partial_symbol): Likewise.
9055         (add_partial_subprogram): Likewise.
9056         (process_full_comp_unit): Likewise.
9057         (read_file_scope): Likewise.
9058         (read_func_scope): Likewise.
9059         (read_lexical_block_scope): Likewise.
9060         (read_call_site_scope): Likewise.
9061         (dwarf2_rnglists_process): Likewise.
9062         (dwarf2_ranges_process): Likewise.
9063         (dwarf2_ranges_read): Likewise.
9064         (dwarf_decode_lines_1): Likewise.
9065         (new_symbol): Likewise.
9066         (dwarf2_fetch_die_loc_sect_off): Likewise.
9067         (dwarf2_per_cu_text_offset): Likewise.
9068         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
9069         * hppa-tdep.c (read_unwind_info): Likewise.
9070         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
9071         * psympriv.h (struct partial_symtab): Likewise.
9072         * psymtab.c (find_pc_sect_psymtab): Likewise.
9073         * solib-svr4.c (enable_break): Likewise.
9074         * stap-probe.c (relocate_address): Use
9075         objfile::data_section_offset.
9076         * xcoffread.c (enter_line_range): Use
9077         objfile::text_section_offset.
9078         (read_xcoff_symtab): Likewise.
9079
9080 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
9081
9082         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
9083         declaration to narrower scopes.
9084
9085 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
9086
9087         * darwin-nat.h (struct darwin_exception_msg, enum
9088         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
9089         Move up.
9090         (class darwin_nat_target) <wait_1, check_new_threads,
9091         decode_exception_message, decode_message, stop_inferior,
9092         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
9093         * darwin-nat.c (darwin_check_new_threads): Rename to...
9094         (darwin_nat_target::check_new_threads): ... this.
9095         (darwin_suspend_inferior_it): Remove.
9096         (darwin_decode_exception_message): Rename to...
9097         (darwin_nat_target::decode_exception_message): ... this.
9098         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
9099         (darwin_decode_message): Rename to...
9100         (darwin_nat_target::decode_message): ... this.
9101         (cancel_breakpoint): Rename to...
9102         (darwin_nat_target::cancel_breakpoint): ... this.
9103         (darwin_wait): Rename to...
9104         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
9105         instead of iterate_over_inferiors.
9106         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
9107         (darwin_stop_inferior): Rename to...
9108         (darwin_nat_target::stop_inferior): ... this.
9109         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
9110         (darwin_init_thread_list): Rename to...
9111         (darwin_nat_target::init_thread_list): ... this.
9112         (darwin_ptrace_him): Rename to...
9113         (darwin_nat_target::ptrace_him): ... this.
9114         (darwin_nat_target::create_inferior): Pass lambda function to
9115         fork_inferior.
9116         (darwin_nat_target::detach): Call stop_inferior instead of
9117         darwin_stop_inferior.
9118         * fork-inferior.h (fork_inferior): Change init_trace_fun
9119         parameter to gdb::function_view.
9120         * fork-inferior.c (fork_inferior): Likewise.
9121
9122 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
9123
9124         * i386-cygwin-tdep.c (core_process_module_section): Update.
9125         * windows-nat.c (struct lm_info_windows): Add text_offset.
9126         (windows_xfer_shared_libraries): Update.
9127         * windows-tdep.c (windows_xfer_shared_library):
9128         Add text_offset_cached argument.
9129         * windows-tdep.h (windows_xfer_shared_library): Update.
9130
9131 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9132
9133         * gdbarch.sh: Add declaration for _initialize_gdbarch.
9134
9135 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9136
9137         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
9138         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
9139         replace with range-based for.
9140         (gdbsim_interrupt_inferior): Remove.
9141         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
9142         with a range-based for.  Inline code from
9143         gdbsim_interrupt_inferior.
9144
9145 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
9146
9147         * infrun.c (proceed): Fix indentation.
9148
9149 2020-01-21  Tom Tromey  <tromey@adacore.com>
9150
9151         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
9152         * python/python.c (python_extension_ops): Update.
9153         (gdbpy_colorize): New function.
9154         * python/lib/gdb/__init__.py (colorize): New function.
9155         * extension.h (ext_lang_colorize): Declare.
9156         * extension.c (ext_lang_colorize): New function.
9157         * extension-priv.h (struct extension_language_ops) <colorize>: New
9158         member.
9159         * cli/cli-style.c (_initialize_cli_style): Update help text.
9160
9161 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9162
9163         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
9164         <cond>: Change type to bool.
9165         (aarch64_displaced_step_b_cond): Update cond to use bool type.
9166         (aarch64_displaced_step_cb): Likewise.
9167         (aarch64_displaced_step_tb): Likewise.
9168
9169 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9170
9171         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
9172         output.
9173
9174 2020-01-21  Luis Machado  <luis.machado@linaro.org>
9175
9176         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
9177         <pc_adjust>: Adjust the documentation.
9178         (aarch64_displaced_step_fixup): Check if PC really moved before
9179         adjusting it.
9180
9181 2020-01-19  Tom Tromey  <tom@tromey.com>
9182
9183         * disasm.c (~gdb_disassembler): New destructor.
9184         (gdb_buffered_insn_length): Call disassemble_free_target.
9185         * disasm.h (class gdb_disassembler): Declare destructor.  Use
9186         DISABLE_COPY_AND_ASSIGN.
9187
9188 2020-01-19  Tom Tromey  <tom@tromey.com>
9189
9190         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
9191         (die_reader_func_ftype): Remove.
9192         (cutu_reader): New class.
9193         (dw2_get_file_names_reader): Remove "data" parameter.
9194         (dw2_get_file_names): Use cutu_reader.
9195         (create_debug_type_hash_table): Update.
9196         (read_cutu_die_from_dwo): Update comment.
9197         (lookup_dwo_unit): Add dwo_name parameter.
9198         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
9199         die_reader_func_ftype and data parameters.
9200         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
9201         Remove die_reader_func_ftype and data parameters.
9202         (~cutu_reader): New; from init_cutu_and_read_dies.
9203         (cutu_reader::cutu_reader): Rename from
9204         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
9205         and data parameters.
9206         (init_cutu_and_read_dies_simple): Remove.
9207         (struct process_psymtab_comp_unit_data): Remove.
9208         (process_psymtab_comp_unit_reader): Remove data parameter; add
9209         want_partial_unit and pretend_language parameters.
9210         (process_psymtab_comp_unit): Use cutu_reader.
9211         (build_type_psymtabs_reader): Remove data parameter.
9212         (build_type_psymtabs_1): Use cutu_reader.
9213         (process_skeletonless_type_unit): Likewise.
9214         (load_partial_comp_unit_reader): Remove.
9215         (load_partial_comp_unit): Use cutu_reader.
9216         (load_full_comp_unit_reader): Remove.
9217         (load_full_comp_unit): Use cutu_reader.
9218         (struct create_dwo_cu_data): Remove.
9219         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
9220         dwo_unit parameters.
9221         (create_cus_hash_table): Use cutu_reader.
9222         (struct dwarf2_read_addr_index_data): Remove.
9223         (dwarf2_read_addr_index_reader): Remove.
9224         (dwarf2_read_addr_index): Use cutu_reader.
9225         (read_signatured_type_reader): Remove.
9226         (read_signatured_type): Use cutu_reader.
9227
9228 2020-01-19  Tom Tromey  <tom@tromey.com>
9229
9230         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
9231         * tui/tui-wingeneral.h (class tui_suppress_output): New.
9232         (tui_wrefresh): Declare.
9233         * tui/tui-wingeneral.c (suppress_output): New global.
9234         (tui_suppress_output, ~tui_suppress_output): New constructor and
9235         destructor.
9236         (tui_wrefresh): New function.
9237         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
9238         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
9239         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
9240         method.
9241         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
9242         tui_wrefresh.
9243         (tui_data_window::no_refresh): New method.
9244         (tui_data_item_window::refresh_window): Call tui_wrefresh.
9245         (tui_reg_command): Use tui_suppress_output
9246         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
9247         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
9248         method.
9249         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
9250
9251 2020-01-19  Tom Tromey  <tom@tromey.com>
9252
9253         * tui/tui-winsource.c (tui_update_source_windows_with_line):
9254         Handle case where symtab is null.
9255
9256 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
9257
9258         * linux-fork.c (one_fork_p): Simplify.
9259
9260 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9261
9262         * top.c (struct qt_args): Remove.
9263         (kill_or_detach): Change return type to void, replace `void *`
9264         parameter with a proper one.
9265         (print_inferior_quit_action):  Likewise.
9266         (quit_confirm): Use range-based for loop to iterate over inferiors.
9267         (quit_force): Likewise.
9268
9269 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9270
9271         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
9272         `void *` parameter with proper parameters.
9273         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
9274         (print_one_inferior): Change return type to void, replace `void *`
9275         parameter with proper parameters.
9276         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
9277         inferiors.
9278         (get_other_inferior): Remove.
9279         (mi_cmd_remove_inferior): Use range-based loop to iterate over
9280         inferiors.
9281
9282 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9283
9284         * mi/mi-interp.c (report_initial_inferior): Remove.
9285         (mi_interp::init): Use range-based for to iterate over inferiors.
9286
9287 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
9288
9289         * python/py-inferior.c (build_inferior_list): Remove.
9290         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
9291
9292 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
9293
9294         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
9295         (btrace_stitch_trace): Likewise.
9296         * charset.c (intermediate_encoding): Likewise (vaild).
9297         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
9298         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
9299         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
9300
9301 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
9302
9303         * windows-tdep.c (windows_get_tlb_type):
9304         Add rtl_user_process_parameters type.
9305
9306 2020-01-16  Pedro Alves  <palves@redhat.com>
9307             Norbert Lange  <nolange79@gmail.com>
9308
9309         PR build/24805
9310         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
9311         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
9312         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
9313         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
9314         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
9315         (ps_plog): Redeclare exported functions with default visibility.
9316
9317 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
9318
9319         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
9320         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
9321
9322 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
9323
9324         * infcmd.c (post_create_inferior): Use get_thread_regcache
9325         instead of get_current_regcache.
9326
9327 2020-01-14  Tom Tromey  <tom@tromey.com>
9328
9329         PR symtab/12535:
9330         * python/python.c (gdbpy_decode_line): Treat empty string the same
9331         as no argument.
9332
9333 2020-01-14  Tom Tromey  <tom@tromey.com>
9334
9335         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
9336
9337 2020-01-14  Tom Tromey  <tom@tromey.com>
9338
9339         * nat/linux-btrace.c: Don't include <config.h>.
9340         * nat/linux-ptrace.c: Don't include <config.h>.
9341         * nat/x86-linux-dregs.c: Don't include <config.h>.
9342
9343 2020-01-14  Tom Tromey  <tom@tromey.com>
9344
9345         * configure: Rebuild.
9346         * configure.ac: Move many checks to ../gdbsupport/common.m4.
9347
9348 2020-01-14  Tom Tromey  <tom@tromey.com>
9349
9350         * nat/x86-linux-dregs.c: Include configh.h.
9351         * nat/linux-ptrace.c: Include configh.h.
9352         * nat/linux-btrace.c: Include configh.h.
9353         * defs.h: Include config.h, bfd.h.
9354         * configure.ac: Don't source common.host.
9355         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
9356         * configure: Rebuild.
9357         * acinclude.m4: Update path.
9358         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
9359         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
9360         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
9361         (CLIBS): Add LIBSUPPORT.
9362         (CDEPS): Likewise.
9363         (COMMON_SFILES): Remove gdbsupport files.
9364         (HFILES_NO_SRCDIR): Likewise.
9365         (stamp-version): Update path to create-version.sh.
9366         (ALLDEPFILES): Remove gdbsupport files.
9367
9368 2020-01-14  Tom Tromey  <tom@tromey.com>
9369
9370         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
9371         USE_WIN32API when needed.
9372         * configure.ac (USE_WIN32API): Don't define.
9373         (WIN32LIBS): Use WIN32APILIBS.
9374         * configure: Rebuild.
9375
9376 2020-01-14  Tom Tromey  <tom@tromey.com>
9377
9378         * configure: Rebuild.
9379         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
9380
9381 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
9382
9383         * skip.c (skip_function_command): Make skip w/o arguments use the
9384         name of the inlined function if pc is inside any inlined function.
9385
9386 2020-01-14  Luis Machado  <luis.machado@linaro.org>
9387
9388         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
9389         * infrun.c (resume_1): Likewise.
9390         (handle_inferior_event): Remove stale comment.
9391         * linux-nat.c (linux_nat_target::resume): Update comments.
9392         (save_stop_reason): Likewise.
9393         (linux_nat_filter_event): Likewise.
9394         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
9395
9396 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9397
9398         * elfread.c (record_minimal_symbol): Set section index to 0 for
9399         non-allocatable sections.
9400
9401
9402 2020-01-13  Ali Tamur <tamur@google.com>
9403
9404         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
9405         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
9406         to gdb::optional.  Update comments.
9407         (dwo_file): Update comments.
9408         (read_attribute): Update API to take an additional out parameter,
9409         need_reprocess.  This is used to mark attributes that need other
9410         attributes (e.g. str_offsets_base) for correct computation which may not
9411         have been read yet.
9412         (read_attribute_reprocess): New function declaration.
9413         (read_addr_index): Likewise.
9414         (read_dwo_str_index): Likewise.
9415         (read_stub_str_index): Likewise.
9416         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
9417         (lookup_addr_base): New function definition.
9418         (lookup_ranges_base): Likewise.
9419         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
9420         lookup_ranges_base.
9421         (init_cutu_and_read_dies): Update comments.
9422         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
9423         unit.  This is used to inherit parent's str_offsets_base and addr_base.
9424         Update comments.
9425         (init_cutu_and_read_dies_simple): Reflect API changes.
9426         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
9427         (create_cus_hash_table): Change API to take parent compile unit.
9428         Reflect API changes.
9429         (open_and_init_dwo_file): Reflect API changes.
9430         (dwarf2_get_pc_bounds): Update comments.
9431         (dwarf2_record_block_ranges): Likewise.
9432         (read_full_die_1): Change implementation to reprocess attributes that
9433         need str_offsets_base and addr_base.
9434         (partial_die_info::read): Likewise.
9435         (read_attribute_reprocess): New function definition.
9436         (read_attribute_value): Change API to take an additional out parameter,
9437         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
9438         when a non-dwo compile unit has index based attributes.
9439         (read_attribute): Reflect API changes.
9440         (read_addr_index_1): Reflect API changes.  Update comments.
9441         (dwarf2_read_addr_index_data): Reflect API changes.
9442         (dwarf2_read_addr_index): Likewise.
9443         (read_str_index): Change API and implementation.  This becomes a helper
9444         to be used by the new string index related methods.  Update error
9445         message and comments.
9446         (read_dwo_str_index): New function definition.
9447         (read_stub_str_index): Likewise.
9448         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
9449         * symfile.h (dwarf2_debug_sections): Likewise.
9450         * xcoffread.c (dwarf2_debug_sections): Likewise.
9451
9452 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9453
9454         * gdbcore.h (struct core_fns) <core_read_registers>: Change
9455         core_reg_sect type to gdb_byte *.
9456         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
9457         * cris-tdep.c (fetch_core_registers): Likewise.
9458         * corelow.c (core_target::get_core_register_section): Change
9459         type of `contents` to gdb::byte_vector.
9460
9461 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
9462
9463         * tui/tui-wingeneral.c (box_win): Position the title in the center
9464         of the border.
9465
9466 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9467
9468         * corelow.c (core_target::get_core_register_section): Use
9469           std::vector instead of alloca.
9470
9471 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9472
9473         * warning.m4: Add -Wmissing-declarations to build_warnings.
9474         * configure: Re-generate.
9475
9476 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9477
9478         * python/python.c (init__gdb_module): Add declaration.
9479
9480 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
9481
9482         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
9483         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
9484         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
9485         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
9486         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
9487         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
9488         * ada-exp.y (_initialize_ada_exp): Add declaration.
9489         * ada-lang.c (_initialize_ada_language): Add declaration.
9490         * ada-tasks.c (_initialize_tasks): Add declaration.
9491         * agent.c (_initialize_agent): Add declaration.
9492         * aix-thread.c (_initialize_aix_thread): Add declaration.
9493         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
9494         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
9495         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
9496         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
9497         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
9498         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
9499         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
9500         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
9501         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
9502         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
9503         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
9504         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
9505         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
9506         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
9507         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
9508         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
9509         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
9510         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
9511         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
9512         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
9513         * annotate.c (_initialize_annotate): Add declaration.
9514         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
9515         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
9516         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
9517         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
9518         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
9519         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
9520         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
9521         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
9522         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
9523         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
9524         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
9525         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
9526         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
9527         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
9528         * auto-load.c (_initialize_auto_load): Add declaration.
9529         * auxv.c (_initialize_auxv): Add declaration.
9530         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
9531         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
9532         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
9533         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
9534         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
9535         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
9536         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
9537         * breakpoint.c (_initialize_breakpoint): Add declaration.
9538         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
9539         * btrace.c (_initialize_btrace): Add declaration.
9540         * charset.c (_initialize_charset): Add declaration.
9541         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
9542         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
9543         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
9544         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
9545         * cli/cli-script.c (_initialize_cli_script): Add declaration.
9546         * cli/cli-style.c (_initialize_cli_style): Add declaration.
9547         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
9548         * coffread.c (_initialize_coffread): Add declaration.
9549         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
9550         * compile/compile.c (_initialize_compile): Add declaration.
9551         * complaints.c (_initialize_complaints): Add declaration.
9552         * completer.c (_initialize_completer): Add declaration.
9553         * copying.c (_initialize_copying): Add declaration.
9554         * corefile.c (_initialize_core): Add declaration.
9555         * corelow.c (_initialize_corelow): Add declaration.
9556         * cp-abi.c (_initialize_cp_abi): Add declaration.
9557         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
9558         * cp-support.c (_initialize_cp_support): Add declaration.
9559         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
9560         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
9561         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
9562         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
9563         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
9564         * ctfread.c (_initialize_ctfread): Add declaration.
9565         * d-lang.c (_initialize_d_language): Add declaration.
9566         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
9567         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
9568         * dbxread.c (_initialize_dbxread): Add declaration.
9569         * dcache.c (_initialize_dcache): Add declaration.
9570         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
9571         * disasm.c (_initialize_disasm): Add declaration.
9572         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
9573         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
9574         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
9575         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
9576         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
9577         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
9578         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
9579         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
9580         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
9581         * elfread.c (_initialize_elfread): Add declaration.
9582         * exec.c (_initialize_exec): Add declaration.
9583         * extension.c (_initialize_extension): Add declaration.
9584         * f-lang.c (_initialize_f_language): Add declaration.
9585         * f-valprint.c (_initialize_f_valprint): Add declaration.
9586         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
9587         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
9588         * filesystem.c (_initialize_filesystem): Add declaration.
9589         * findcmd.c (_initialize_mem_search): Add declaration.
9590         * findvar.c (_initialize_findvar): Add declaration.
9591         * fork-child.c (_initialize_fork_child): Add declaration.
9592         * frame-base.c (_initialize_frame_base): Add declaration.
9593         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
9594         * frame.c (_initialize_frame): Add declaration.
9595         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
9596         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
9597         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
9598         * gcore.c (_initialize_gcore): Add declaration.
9599         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
9600         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
9601         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
9602         * gdbarch.c (_initialize_gdbarch): Add declaration.
9603         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
9604         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
9605         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
9606         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
9607         * go-lang.c (_initialize_go_language): Add declaration.
9608         * go32-nat.c (_initialize_go32_nat): Add declaration.
9609         * guile/guile.c (_initialize_guile): Add declaration.
9610         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
9611         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
9612         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
9613         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
9614         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
9615         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
9616         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
9617         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
9618         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
9619         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
9620         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
9621         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
9622         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
9623         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
9624         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
9625         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
9626         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
9627         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
9628         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
9629         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
9630         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
9631         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
9632         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
9633         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
9634         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
9635         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
9636         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
9637         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
9638         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
9639         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
9640         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
9641         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
9642         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
9643         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
9644         * infcall.c (_initialize_infcall): Add declaration.
9645         * infcmd.c (_initialize_infcmd): Add declaration.
9646         * inflow.c (_initialize_inflow): Add declaration.
9647         * infrun.c (_initialize_infrun): Add declaration.
9648         * interps.c (_initialize_interpreter): Add declaration.
9649         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
9650         * jit.c (_initialize_jit): Add declaration.
9651         * language.c (_initialize_language): Add declaration.
9652         * linux-fork.c (_initialize_linux_fork): Add declaration.
9653         * linux-nat.c (_initialize_linux_nat): Add declaration.
9654         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
9655         * linux-thread-db.c (_initialize_thread_db): Add declaration.
9656         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
9657         * m2-lang.c (_initialize_m2_language): Add declaration.
9658         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
9659         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
9660         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
9661         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
9662         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
9663         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
9664         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
9665         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
9666         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
9667         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
9668         * machoread.c (_initialize_machoread): Add declaration.
9669         * macrocmd.c (_initialize_macrocmd): Add declaration.
9670         * macroscope.c (_initialize_macroscope): Add declaration.
9671         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
9672         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
9673         * maint.c (_initialize_maint_cmds): Add declaration.
9674         * mdebugread.c (_initialize_mdebugread): Add declaration.
9675         * memattr.c (_initialize_mem): Add declaration.
9676         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
9677         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
9678         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
9679         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
9680         * mi/mi-main.c (_initialize_mi_main): Add declaration.
9681         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
9682         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
9683         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
9684         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
9685         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
9686         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
9687         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
9688         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
9689         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
9690         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
9691         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
9692         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
9693         * mipsread.c (_initialize_mipsread): Add declaration.
9694         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
9695         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
9696         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
9697         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
9698         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
9699         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
9700         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
9701         * nto-procfs.c (_initialize_procfs): Add declaration.
9702         * objc-lang.c (_initialize_objc_language): Add declaration.
9703         * observable.c (_initialize_observer): Add declaration.
9704         * opencl-lang.c (_initialize_opencl_language): Add declaration.
9705         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
9706         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
9707         * osabi.c (_initialize_gdb_osabi): Add declaration.
9708         * osdata.c (_initialize_osdata): Add declaration.
9709         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
9710         * parse.c (_initialize_parse): Add declaration.
9711         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
9712         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
9713         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
9714         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
9715         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
9716         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
9717         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
9718         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
9719         * printcmd.c (_initialize_printcmd): Add declaration.
9720         * probe.c (_initialize_probe): Add declaration.
9721         * proc-api.c (_initialize_proc_api): Add declaration.
9722         * proc-events.c (_initialize_proc_events): Add declaration.
9723         * proc-service.c (_initialize_proc_service): Add declaration.
9724         * procfs.c (_initialize_procfs): Add declaration.
9725         * producer.c (_initialize_producer): Add declaration.
9726         * psymtab.c (_initialize_psymtab): Add declaration.
9727         * python/python.c (_initialize_python): Add declaration.
9728         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
9729         * record-btrace.c (_initialize_record_btrace): Add declaration.
9730         * record-full.c (_initialize_record_full): Add declaration.
9731         * record.c (_initialize_record): Add declaration.
9732         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
9733         * regcache.c (_initialize_regcache): Add declaration.
9734         * reggroups.c (_initialize_reggroup): Add declaration.
9735         * remote-notif.c (_initialize_notif): Add declaration.
9736         * remote-sim.c (_initialize_remote_sim): Add declaration.
9737         * remote.c (_initialize_remote): Add declaration.
9738         * reverse.c (_initialize_reverse): Add declaration.
9739         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
9740         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
9741         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
9742         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
9743         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
9744         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
9745         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
9746         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
9747         Add declaration.
9748         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
9749         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
9750         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
9751         * rust-exp.y (_initialize_rust_exp): Add declaration.
9752         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
9753         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
9754         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
9755         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
9756         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
9757         * score-tdep.c (_initialize_score_tdep): Add declaration.
9758         * ser-go32.c (_initialize_ser_dos): Add declaration.
9759         * ser-mingw.c (_initialize_ser_windows): Add declaration.
9760         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
9761         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
9762         * ser-uds.c (_initialize_ser_socket): Add declaration.
9763         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
9764         * serial.c (_initialize_serial): Add declaration.
9765         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
9766         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
9767         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
9768         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
9769         * skip.c (_initialize_step_skip): Add declaration.
9770         * sol-thread.c (_initialize_sol_thread): Add declaration.
9771         * solib-aix.c (_initialize_solib_aix): Add declaration.
9772         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
9773         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
9774         * solib-frv.c (_initialize_frv_solib): Add declaration.
9775         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
9776         * solib-target.c (_initialize_solib_target): Add declaration.
9777         * solib.c (_initialize_solib): Add declaration.
9778         * source-cache.c (_initialize_source_cache): Add declaration.
9779         * source.c (_initialize_source): Add declaration.
9780         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
9781         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
9782         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
9783         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
9784         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
9785         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
9786         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
9787         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
9788         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
9789         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
9790         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
9791         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
9792         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
9793         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
9794         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
9795         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
9796         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
9797         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
9798         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
9799         * stabsread.c (_initialize_stabsread): Add declaration.
9800         * stack.c (_initialize_stack): Add declaration.
9801         * stap-probe.c (_initialize_stap_probe): Add declaration.
9802         * std-regs.c (_initialize_frame_reg): Add declaration.
9803         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
9804         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
9805         * symfile.c (_initialize_symfile): Add declaration.
9806         * symmisc.c (_initialize_symmisc): Add declaration.
9807         * symtab.c (_initialize_symtab): Add declaration.
9808         * target.c (_initialize_target): Add declaration.
9809         * target-connection.c (_initialize_target_connection): Add
9810         declaration.
9811         * target-dcache.c (_initialize_target_dcache): Add declaration.
9812         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
9813         * thread.c (_initialize_thread): Add declaration.
9814         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
9815         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
9816         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
9817         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
9818         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
9819         * tracectf.c (_initialize_ctf): Add declaration.
9820         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
9821         * tracefile.c (_initialize_tracefile): Add declaration.
9822         * tracepoint.c (_initialize_tracepoint): Add declaration.
9823         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
9824         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
9825         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
9826         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
9827         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
9828         * tui/tui-win.c (_initialize_tui_win): Add declaration.
9829         * tui/tui.c (_initialize_tui): Add declaration.
9830         * typeprint.c (_initialize_typeprint): Add declaration.
9831         * ui-style.c (_initialize_ui_style): Add declaration.
9832         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
9833         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
9834         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
9835         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
9836         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
9837         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
9838         * unittests/filtered_iterator-selftests.c
9839         (_initialize_filtered_iterator_selftests): Add declaration.
9840         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
9841         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
9842         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
9843         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
9844         * unittests/main-thread-selftests.c
9845         (_initialize_main_thread_selftests): Add declaration.
9846         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
9847         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
9848         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
9849         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
9850         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
9851         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
9852         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
9853         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
9854         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
9855         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
9856         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
9857         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
9858         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
9859         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
9860         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
9861         declaration.
9862         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
9863         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
9864         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
9865         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
9866         * user-regs.c (_initialize_user_regs): Add declaration.
9867         * utils.c (_initialize_utils): Add declaration.
9868         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
9869         * valops.c (_initialize_valops): Add declaration.
9870         * valprint.c (_initialize_valprint): Add declaration.
9871         * value.c (_initialize_values): Add declaration.
9872         * varobj.c (_initialize_varobj): Add declaration.
9873         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
9874         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
9875         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
9876         * windows-nat.c (_initialize_windows_nat): Add declaration.
9877         (_initialize_check_for_gdb_ini): Add declaration.
9878         (_initialize_loadable): Add declaration.
9879         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
9880         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
9881         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
9882         * xcoffread.c (_initialize_xcoffread): Add declaration.
9883         * xml-support.c (_initialize_xml_support): Add declaration.
9884         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
9885         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
9886         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
9887         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
9888
9889 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9890
9891         * regformats/regdat.sh: Generate declaration for init function.
9892
9893 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
9894
9895         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
9896         up.
9897         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
9898         close_one_inferior>: New methods.
9899         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
9900         pass down target to find_inferior_pid.
9901         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
9902         Pass down target to find_inferior_ptid.
9903         (gdbsim_target::create_inferior): Pass down target to
9904         add_thread_silent.
9905         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
9906         target down to find_inferior_ptid and switch_to_thread.
9907         (gdbsim_target::close): Update to call close_one_inferior.
9908         (struct resume_data): Remove.
9909         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
9910         directly, rather than through a void pointer.
9911         (gdbsim_target::resume): Update to call resume_one_inferior.
9912
9913 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
9914
9915         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
9916
9917 2020-01-12  Pedro Alves  <palves@redhat.com>
9918
9919         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
9920         directly for the current inferior instead of
9921         discard_all_inferiors.
9922         (discard_all_inferiors): Delete.
9923
9924 2020-01-11  Tom Tromey  <tom@tromey.com>
9925
9926         * tui/tui-wingeneral.c (box_win): Check cli_styling.
9927         * tui/tui-winsource.c (tui_source_window_base::refill): Use
9928         deprecated_safe_get_selected_frame.
9929
9930 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
9931
9932         * inferior.c (print_inferior): Switch inferior before printing it.
9933
9934 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
9935             Pedro Alves  <palves@redhat.com>
9936
9937         * progspace-and-thread.c (switch_to_program_space_and_thread):
9938         Assert there's an inferior for PSPACE.  Use
9939         switch_to_inferior_no_thread to switch the inferior too.
9940         * progspace.c (program_space::~program_space): Call
9941         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
9942         (program_space::free_all_objfiles): Don't call clear_symtab_users
9943         here.
9944         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
9945
9946 2020-01-10  Pedro Alves  <palves@redhat.com>
9947
9948         * NEWS: Mention multi-target debugging, "info connections", and
9949         "add-inferior -no-connection".
9950
9951 2020-01-10  Pedro Alves  <palves@redhat.com>
9952
9953         * infrun.c: Include "target-connection.h".
9954         (check_multi_target_resumption): New.
9955         (proceed): Call it.
9956         * target-connection.c (make_target_connection_string): Make
9957         extern.
9958         * target-connection.h (make_target_connection_string): Declare.
9959
9960 2020-01-10  Pedro Alves  <palves@redhat.com>
9961
9962         * Makefile.in (COMMON_SFILES): Add target-connection.c.
9963         * inferior.c (uiout_field_connection): New function.
9964         (print_inferior): Add new "connection-id" column.
9965         (add_inferior_command): Show connection number/string of added
9966         inferior.
9967         * process-stratum-target.h
9968         (process_stratum_target::connection_string): New virtual method.
9969         (process_stratum_target::connection_number): New field.
9970         * remote.c (remote_target::connection_string): New override.
9971         * target-connection.c: New file.
9972         * target-connection.h: New file.
9973         * target.c (decref_target): Remove process_stratum targets from
9974         the connection list.
9975         (target_stack::push): Add process_stratum targets to the
9976         connection list.
9977
9978 2020-01-10  Pedro Alves  <palves@redhat.com>
9979
9980         Revert:
9981         2016-04-12  Pedro Alves  <palves@redhat.com>
9982         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
9983         Remove references to name.
9984         * serial.h (struct serial) <name>: Delete.
9985
9986 2020-01-10  Pedro Alves  <palves@redhat.com>
9987
9988         * gdbarch-selftests.c (register_to_value_test): Remove "target
9989         already pushed" check.
9990
9991 2020-01-10  Pedro Alves  <palves@redhat.com>
9992             John Baldwin  <jhb@FreeBSD.org>
9993
9994         * aarch64-linux-nat.c
9995         (aarch64_linux_nat_target::thread_architecture): Adjust.
9996         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
9997         (task_command_1): Likewise.
9998         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
9999         (aix_thread_target::wait, aix_thread_target::fetch_registers)
10000         (aix_thread_target::store_registers)
10001         (aix_thread_target::thread_alive): Adjust.
10002         * amd64-fbsd-tdep.c: Include "inferior.h".
10003         (amd64fbsd_get_thread_local_address): Pass down target.
10004         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
10005         thread's gdbarch instead of target_gdbarch.
10006         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
10007         get_last_target_status.
10008         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
10009         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
10010         inferiors.
10011         (update_inserted_breakpoint_locations): Skip if inferiors with no
10012         execution.
10013         (update_global_location_list): When handling moribund locations,
10014         find representative inferior for location's pspace, and use thread
10015         count of its process_stratum target.
10016         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
10017         * bsd-uthread.c (bsd_uthread_target::wait): Use
10018         as_process_stratum_target and adjust thread_change_ptid and
10019         add_thread calls.
10020         (bsd_uthread_target::update_thread_list): Use
10021         as_process_stratum_target and adjust find_thread_ptid,
10022         thread_change_ptid and add_thread calls.
10023         * btrace.c (maint_btrace_packet_history_cmd): Adjust
10024         find_thread_ptid call.
10025         * corelow.c (add_to_thread_list): Adjust add_thread call.
10026         (core_target_open): Adjust add_thread_silent and thread_count
10027         calls.
10028         (core_target::pid_to_str): Adjust find_inferior_ptid call.
10029         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
10030         * event-top.c (async_disconnect): Pop targets from all inferiors.
10031         * exec.c (add_target_sections): Push exec target on all inferiors
10032         sharing the program space.
10033         (remove_target_sections): Remove the exec target from all
10034         inferiors sharing the program space.
10035         (exec_on_vfork): New.
10036         * exec.h (exec_on_vfork): Declare.
10037         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
10038         Pass it down.
10039         (fbsd_nat_target::update_thread_list): Adjust.
10040         (fbsd_nat_target::resume): Adjust.
10041         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
10042         down.
10043         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
10044         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
10045         get_thread_arch_regcache call.
10046         * fork-child.c (gdb_startup_inferior): Pass target down to
10047         startup_inferior and set_executing.
10048         * gdbthread.h (struct process_stratum_target): Forward declare.
10049         (add_thread, add_thread_silent, add_thread_with_info)
10050         (in_thread_list): Add process_stratum_target parameter.
10051         (find_thread_ptid(inferior*, ptid_t)): New overload.
10052         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
10053         parameter.
10054         (all_threads()): Delete overload.
10055         (all_threads, all_non_exited_threads): Add process_stratum_target
10056         parameter.
10057         (all_threads_safe): Use brace initialization.
10058         (thread_count): Add process_stratum_target parameter.
10059         (set_resumed, set_running, set_stop_requested, set_executing)
10060         (threads_are_executing, finish_thread_state): Add
10061         process_stratum_target parameter.
10062         (switch_to_thread): Use is_current_thread.
10063         * i386-fbsd-tdep.c: Include "inferior.h".
10064         (i386fbsd_get_thread_local_address): Pass down target.
10065         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
10066         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
10067         have_inferiors check.
10068         * inf-ptrace.c (inf_ptrace_target::create_inferior)
10069         (inf_ptrace_target::attach): Adjust.
10070         * infcall.c (run_inferior_call): Adjust.
10071         * infcmd.c (run_command_1): Pass target to
10072         scoped_finish_thread_state.
10073         (proceed_thread_callback): Skip inferiors with no execution.
10074         (continue_command): Rename 'all_threads' local to avoid hiding
10075         'all_threads' function.  Adjust get_last_target_status call.
10076         (prepare_one_step): Adjust set_running call.
10077         (signal_command): Use user_visible_resume_target.  Compare thread
10078         pointers instead of inferior_ptid.
10079         (info_program_command): Adjust to pass down target.
10080         (attach_command): Mark target's 'thread_executing' flag.
10081         (stop_current_target_threads_ns): New, factored out from ...
10082         (interrupt_target_1): ... this.  Switch inferior before making
10083         target calls.
10084         * inferior-iter.h
10085         (struct all_inferiors_iterator, struct all_inferiors_range)
10086         (struct all_inferiors_safe_range)
10087         (struct all_non_exited_inferiors_range): Filter on
10088         process_stratum_target too.  Remove explicit.
10089         * inferior.c (inferior::inferior): Push dummy target on target
10090         stack.
10091         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
10092         Add process_stratum_target parameter, and pass it down.
10093         (have_live_inferiors): Adjust.
10094         (switch_to_inferior_and_push_target): New.
10095         (add_inferior_command, clone_inferior_command): Handle
10096         "-no-connection" parameter.  Use
10097         switch_to_inferior_and_push_target.
10098         (_initialize_inferior): Mention "-no-connection" option in
10099         the help of "add-inferior" and "clone-inferior" commands.
10100         * inferior.h: Include "process-stratum-target.h".
10101         (interrupt_target_1): Use bool.
10102         (struct inferior) <push_target, unpush_target, target_is_pushed,
10103         find_target_beneath, top_target, process_target, target_at,
10104         m_stack>: New.
10105         (discard_all_inferiors): Delete.
10106         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
10107         (all_inferiors, all_non_exited_inferiors): Add
10108         process_stratum_target parameter.
10109         * infrun.c: Include "gdb_select.h" and <unordered_map>.
10110         (target_last_proc_target): New global.
10111         (follow_fork_inferior): Push target on new inferior.  Pass target
10112         to add_thread_silent.  Call exec_on_vfork.  Handle target's
10113         reference count.
10114         (follow_fork): Adjust get_last_target_status call.  Also consider
10115         target.
10116         (follow_exec): Push target on new inferior.
10117         (struct execution_control_state) <target>: New field.
10118         (user_visible_resume_target): New.
10119         (do_target_resume): Call target_async.
10120         (resume_1): Set target's threads_executing flag.  Consider resume
10121         target.
10122         (commit_resume_all_targets): New.
10123         (proceed): Also consider resume target.  Skip threads of inferiors
10124         with no execution.  Commit resumtion in all targets.
10125         (start_remote): Pass current inferior to wait_for_inferior.
10126         (infrun_thread_stop_requested): Consider target as well.  Pass
10127         thread_info pointer to clear_inline_frame_state instead of ptid.
10128         (infrun_thread_thread_exit): Consider target as well.
10129         (random_pending_event_thread): New inferior parameter.  Use it.
10130         (do_target_wait): Rename to ...
10131         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
10132         down.
10133         (threads_are_resumed_pending_p, do_target_wait): New.
10134         (prepare_for_detach): Adjust calls.
10135         (wait_for_inferior): New inferior parameter.  Handle it.  Use
10136         do_target_wait_1 instead of do_target_wait.
10137         (fetch_inferior_event): Adjust.  Switch to representative
10138         inferior.  Pass target down.
10139         (set_last_target_status): Add process_stratum_target parameter.
10140         Save target in global.
10141         (get_last_target_status): Add process_stratum_target parameter and
10142         handle it.
10143         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
10144         (context_switch): Check inferior_ptid == null_ptid before calling
10145         inferior_thread().
10146         (get_inferior_stop_soon): Pass down target.
10147         (wait_one): Rename to ...
10148         (poll_one_curr_target): ... this.
10149         (struct wait_one_event): New.
10150         (wait_one): New.
10151         (stop_all_threads): Adjust.
10152         (handle_no_resumed, handle_inferior_event): Adjust to consider the
10153         event's target.
10154         (switch_back_to_stepped_thread): Also consider target.
10155         (print_stop_event): Update.
10156         (normal_stop): Update.  Also consider the resume target.
10157         * infrun.h (wait_for_inferior): Remove declaration.
10158         (user_visible_resume_target): New declaration.
10159         (get_last_target_status, set_last_target_status): New
10160         process_stratum_target parameter.
10161         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
10162         process_stratum_target parameter, and use it.
10163         (clear_inline_frame_state (thread_info*)): New.
10164         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
10165         process_stratum_target parameter.
10166         (clear_inline_frame_state (thread_info*)): Declare.
10167         * linux-fork.c (delete_checkpoint_command): Pass target down to
10168         find_thread_ptid.
10169         (checkpoint_command): Adjust.
10170         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
10171         instead of just tweaking inferior_ptid.
10172         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
10173         (exit_lwp): Pass target down to find_thread_ptid.
10174         (attach_proc_task_lwp_callback): Pass target down to
10175         add_thread/set_running/set_executing.
10176         (linux_nat_target::attach): Pass target down to
10177         thread_change_ptid.
10178         (get_detach_signal): Pass target down to find_thread_ptid.
10179         Consider last target status's target.
10180         (linux_resume_one_lwp_throw, resume_lwp)
10181         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
10182         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
10183         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
10184         (linux_nat_target::async_wait_fd): New.
10185         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
10186         target down.
10187         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
10188         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
10189         * linux-thread-db.c (struct thread_db_info::process_target): New
10190         field.
10191         (add_thread_db_info): Save target.
10192         (get_thread_db_info): New process_stratum_target parameter.  Also
10193         match target.
10194         (delete_thread_db_info): New process_stratum_target parameter.
10195         Also match target.
10196         (thread_from_lwp): Adjust to pass down target.
10197         (thread_db_notice_clone): Pass down target.
10198         (check_thread_db_callback): Pass down target.
10199         (try_thread_db_load_1): Always push the thread_db target.
10200         (try_thread_db_load, record_thread): Pass target down.
10201         (thread_db_target::detach): Pass target down.  Always unpush the
10202         thread_db target.
10203         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
10204         target down.  Always unpush the thread_db target.
10205         (find_new_threads_callback, thread_db_find_new_threads_2)
10206         (thread_db_target::update_thread_list): Pass target down.
10207         (thread_db_target::pid_to_str): Pass current inferior down.
10208         (thread_db_target::get_thread_local_address): Pass target down.
10209         (thread_db_target::resume, maintenance_check_libthread_db): Pass
10210         target down.
10211         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
10212         * procfs.c (procfs_target::procfs_init_inferior): Declare.
10213         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
10214         (procfs_init_inferior): Rename to ...
10215         (procfs_target::procfs_init_inferior): ... this and adjust.
10216         (procfs_target::create_inferior, procfs_notice_thread)
10217         (procfs_do_thread_registers): Adjust.
10218         * ppc-fbsd-tdep.c: Include "inferior.h".
10219         (ppcfbsd_get_thread_local_address): Pass down target.
10220         * proc-service.c (ps_xfer_memory): Switch current inferior and
10221         program space as well.
10222         (get_ps_regcache): Pass target down.
10223         * process-stratum-target.c
10224         (process_stratum_target::thread_address_space)
10225         (process_stratum_target::thread_architecture): Pass target down.
10226         * process-stratum-target.h
10227         (process_stratum_target::threads_executing): New field.
10228         (as_process_stratum_target): New.
10229         * ravenscar-thread.c
10230         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
10231         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
10232         down.
10233         * record-btrace.c (record_btrace_target::info_record): Adjust.
10234         (record_btrace_target::record_method)
10235         (record_btrace_target::record_is_replaying)
10236         (record_btrace_target::fetch_registers)
10237         (get_thread_current_frame_id, record_btrace_target::resume)
10238         (record_btrace_target::wait, record_btrace_target::stop): Pass
10239         target down.
10240         * record-full.c (record_full_wait_1): Switch to event thread.
10241         Pass target down.
10242         * regcache.c (regcache::regcache)
10243         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
10244         process_stratum_target parameter and handle it.
10245         (current_thread_target): New global.
10246         (get_thread_regcache): Add process_stratum_target parameter and
10247         handle it.  Switch inferior before calling target method.
10248         (get_thread_regcache): Pass target down.
10249         (get_thread_regcache_for_ptid): Pass target down.
10250         (registers_changed_ptid): Add process_stratum_target parameter and
10251         handle it.
10252         (registers_changed_thread, registers_changed): Pass target down.
10253         (test_get_thread_arch_aspace_regcache): New.
10254         (current_regcache_test): Define a couple local test_target_ops
10255         instances and use them for testing.
10256         (readwrite_regcache): Pass process_stratum_target parameter.
10257         (cooked_read_test, cooked_write_test): Pass mock_target down.
10258         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
10259         (get_thread_arch_aspace_regcache): Add process_stratum_target
10260         parameter.
10261         (regcache::target): New method.
10262         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
10263         (regcache::registers_changed_ptid): Add process_stratum_target
10264         parameter.
10265         (regcache::m_target): New field.
10266         (registers_changed_ptid): Add process_stratum_target parameter.
10267         * remote.c (remote_state::supports_vCont_probed): New field.
10268         (remote_target::async_wait_fd): New method.
10269         (remote_unpush_and_throw): Add remote_target parameter.
10270         (get_current_remote_target): Adjust.
10271         (remote_target::remote_add_inferior): Push target.
10272         (remote_target::remote_add_thread)
10273         (remote_target::remote_notice_new_inferior)
10274         (get_remote_thread_info): Pass target down.
10275         (remote_target::update_thread_list): Skip threads of inferiors
10276         bound to other targets.  (remote_target::close): Don't discard
10277         inferiors.  (remote_target::add_current_inferior_and_thread)
10278         (remote_target::process_initial_stop_replies)
10279         (remote_target::start_remote)
10280         (remote_target::remote_serial_quit_handler): Pass down target.
10281         (remote_target::remote_unpush_target): New remote_target
10282         parameter.  Unpush the target from all inferiors.
10283         (remote_target::remote_unpush_and_throw): New remote_target
10284         parameter.  Pass it down.
10285         (remote_target::open_1): Check whether the current inferior has
10286         execution instead of checking whether any inferior is live.  Pass
10287         target down.
10288         (remote_target::remote_detach_1): Pass down target.  Use
10289         remote_unpush_target.
10290         (extended_remote_target::attach): Pass down target.
10291         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
10292         (remote_target::append_resumption): Pass down target.
10293         (remote_target::append_pending_thread_resumptions)
10294         (remote_target::remote_resume_with_hc, remote_target::resume)
10295         (remote_target::commit_resume): Pass down target.
10296         (remote_target::remote_stop_ns): Check supports_vCont_probed.
10297         (remote_target::interrupt_query)
10298         (remote_target::remove_new_fork_children)
10299         (remote_target::check_pending_events_prevent_wildcard_vcont)
10300         (remote_target::remote_parse_stop_reply)
10301         (remote_target::process_stop_reply): Pass down target.
10302         (first_remote_resumed_thread): New remote_target parameter.  Pass
10303         it down.
10304         (remote_target::wait_as): Pass down target.
10305         (unpush_and_perror): New remote_target parameter.  Pass it down.
10306         (remote_target::readchar, remote_target::remote_serial_write)
10307         (remote_target::getpkt_or_notif_sane_1)
10308         (remote_target::kill_new_fork_children, remote_target::kill): Pass
10309         down target.
10310         (remote_target::mourn_inferior): Pass down target.  Use
10311         remote_unpush_target.
10312         (remote_target::core_of_thread)
10313         (remote_target::remote_btrace_maybe_reopen): Pass down target.
10314         (remote_target::pid_to_exec_file)
10315         (remote_target::thread_handle_to_thread_info): Pass down target.
10316         (remote_target::async_wait_fd): New.
10317         * riscv-fbsd-tdep.c: Include "inferior.h".
10318         (riscv_fbsd_get_thread_local_address): Pass down target.
10319         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
10320         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
10321         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
10322         Adjust.
10323         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
10324         * solib-svr4.c (enable_break): Pass down target.
10325         * spu-multiarch.c (parse_spufs_run): Pass down target.
10326         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
10327         * target-delegates.c: Regenerate.
10328         * target.c (g_target_stack): Delete.
10329         (current_top_target): Return the current inferior's top target.
10330         (target_has_execution_1): Refer to the passed-in inferior's top
10331         target.
10332         (target_supports_terminal_ours): Check whether the initial
10333         inferior was already created.
10334         (decref_target): New.
10335         (target_stack::push): Incref/decref the target.
10336         (push_target, push_target, unpush_target): Adjust.
10337         (target_stack::unpush): Defref target.
10338         (target_is_pushed): Return bool.  Adjust to refer to the current
10339         inferior's target stack.
10340         (dispose_inferior): Delete, and inline parts ...
10341         (target_preopen): ... here.  Only dispose of the current inferior.
10342         (target_detach): Hold strong target reference while detaching.
10343         Pass target down.
10344         (target_thread_name): Add assertion.
10345         (target_resume): Pass down target.
10346         (target_ops::beneath, find_target_at): Adjust to refer to the
10347         current inferior's target stack.
10348         (get_dummy_target): New.
10349         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
10350         has a thread running.
10351         (initialize_targets): Rename to ...
10352         (_initialize_target): ... this.
10353         * target.h: Include "gdbsupport/refcounted-object.h".
10354         (struct target_ops): Inherit refcounted_object.
10355         (target_ops::shortname, target_ops::longname): Make const.
10356         (target_ops::async_wait_fd): New method.
10357         (decref_target): Declare.
10358         (struct target_ops_ref_policy): New.
10359         (target_ops_ref): New typedef.
10360         (get_dummy_target): Declare function.
10361         (target_is_pushed): Return bool.
10362         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
10363         (all_matching_threads_iterator::all_matching_threads_iterator):
10364         Handle filter target.
10365         * thread-iter.h (struct all_matching_threads_iterator, struct
10366         all_matching_threads_range, class all_non_exited_threads_range):
10367         Filter by target too.  Remove explicit.
10368         * thread.c (threads_executing): Delete.
10369         (inferior_thread): Pass down current inferior.
10370         (clear_thread_inferior_resources): Pass down thread pointer
10371         instead of ptid_t.
10372         (add_thread_silent, add_thread_with_info, add_thread): Add
10373         process_stratum_target parameter.  Use it for thread and inferior
10374         searches.
10375         (is_current_thread): New.
10376         (thread_info::deletable): Use it.
10377         (find_thread_ptid, thread_count, in_thread_list)
10378         (thread_change_ptid, set_resumed, set_running): New
10379         process_stratum_target parameter.  Pass it down.
10380         (set_executing): New process_stratum_target parameter.  Pass it
10381         down.  Adjust reference to 'threads_executing'.
10382         (threads_are_executing): New process_stratum_target parameter.
10383         Adjust reference to 'threads_executing'.
10384         (set_stop_requested, finish_thread_state): New
10385         process_stratum_target parameter.  Pass it down.
10386         (switch_to_thread): Also match inferior.
10387         (switch_to_thread): New process_stratum_target parameter.  Pass it
10388         down.
10389         (update_threads_executing): Reimplement.
10390         * top.c (quit_force): Pop targets from all inferior.
10391         (gdb_init): Don't call initialize_targets.
10392         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
10393         Declare.
10394         (windows_add_thread, windows_delete_thread): Adjust.
10395         (get_windows_debug_event): Rename to ...
10396         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
10397         * tracefile-tfile.c (tfile_target_open): Pass down target.
10398         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
10399         Forward declare.
10400         (switch_to_thread): Add process_stratum_target parameter.
10401         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
10402         parameter.  Use it.
10403         (mi_on_resume): Pass target down.
10404         * nat/fork-inferior.c (startup_inferior): Add
10405         process_stratum_target parameter.  Pass it down.
10406         * nat/fork-inferior.h (startup_inferior): Add
10407         process_stratum_target parameter.
10408         * python/py-threadevent.c (py_get_event_thread): Pass target down.
10409
10410 2020-01-10  Pedro Alves  <palves@redhat.com>
10411
10412         * remote.c (remote_target::start_remote): Don't set inferior_ptid
10413         directly.  Instead find the first thread in the thread list and
10414         use switch_to_thread.
10415
10416 2020-01-10  Pedro Alves  <palves@redhat.com>
10417
10418         * remote.c (remote_target::remote_add_inferior): Don't bind a
10419         process to the current inferior if the current inferior is already
10420         bound to a process.
10421
10422 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
10423             Pedro Alves  <palves@redhat.com>
10424
10425         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
10426         If no process is specified, return null_ptid instead of
10427         inferior_ptid.
10428         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
10429         TARGET_WAITKIND_SIGNALLED with no pid.
10430
10431 2020-01-10  Pedro Alves  <palves@redhat.com>
10432
10433         * remote.c (first_remote_resumed_thread): New.
10434         (remote_target::wait_as): Use it as default event_ptid instead of
10435         inferior_ptid.
10436
10437 2020-01-10  Pedro Alves  <palves@redhat.com>
10438
10439         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
10440
10441 2020-01-10  Pedro Alves  <palves@redhat.com>
10442
10443         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
10444         not -1.
10445
10446 2020-01-10  Pedro Alves  <palves@redhat.com>
10447
10448         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
10449         ptid to get_last_target_status.
10450         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
10451         ptid to get_last_target_status.
10452         * infcmd.c (continue_command): Don't pass a target_waitstatus to
10453         get_last_target_status.
10454         (info_program_command): Don't pass a target_waitstatus to
10455         get_last_target_status.
10456         * infrun.c (init_wait_for_inferior): Use
10457         nullify_last_target_wait_ptid.
10458         (get_last_target_status): Handle nullptr arguments.
10459         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
10460         (print_stop_event): Don't pass a ptid to get_last_target_status.
10461         (normal_stop): Don't pass a ptid to get_last_target_status.
10462         * infrun.h (get_last_target_status, set_last_target_status): Move
10463         comments here and update.
10464         (nullify_last_target_wait_ptid): Declare.
10465         * linux-fork.c (fork_load_infrun_state): Remove local extern
10466         declaration of nullify_last_target_wait_ptid.
10467         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
10468         to get_last_target_status.
10469
10470 2020-01-10  Pedro Alves  <palves@redhat.com>
10471
10472         * gdbthread.h (scoped_restore_current_thread)
10473         <dont_restore, restore, m_dont_restore>: Declare.
10474         * thread.c (thread_alive): Add assertion.  Return bool.
10475         (switch_to_thread_if_alive): New.
10476         (prune_threads): Switch inferior/thread.
10477         (print_thread_info_1): Switch thread before calling target methods.
10478         (scoped_restore_current_thread::restore): New, factored out from
10479         ...
10480         (scoped_restore_current_thread::~scoped_restore_current_thread):
10481         ... this.
10482         (scoped_restore_current_thread::scoped_restore_current_thread):
10483         Add assertion.
10484         (thread_apply_all_command, thread_select): Use
10485         switch_to_thread_if_alive.
10486         * infrun.c (proceed, restart_threads, handle_signal_stop)
10487         (switch_back_to_stepped_thread): Switch current thread before
10488         calling target methods.
10489
10490 2020-01-10  Pedro Alves <palves@redhat.com>
10491
10492         * inferior.c (switch_to_inferior_no_thread): New function,
10493         factored out from ...
10494         (inferior_command): ... here.
10495         * inferior.h (switch_to_inferior_no_thread): Declare.
10496         * mi/mi-main.c (run_one_inferior): Use
10497         switch_to_inferior_no_thread.
10498
10499 2020-01-10  Pedro Alves  <palves@redhat.com>
10500
10501         * infcmd.c (kill_command): Remove dead code.
10502
10503 2020-01-10  Pedro Alves  <palves@redhat.com>
10504
10505         * remote.c (remote_target::mourn_inferior): No longer check
10506         whether the target is running.
10507
10508 2020-01-10  Pedro Alves  <palves@redhat.com>
10509
10510         * corelow.c (core_target::has_execution): Change parameter type to
10511         inferior pointer.
10512         * inferior.c (number_of_live_inferiors): Use
10513         inferior::has_execution instead of target_has_execution_1.
10514         * inferior.h (inferior::has_execution): New.
10515         * linux-thread-db.c (thread_db_target::update_thread_list): Use
10516         inferior::has_execution instead of target_has_execution_1.
10517         * process-stratum-target.c
10518         (process_stratum_target::has_execution): Change parameter type to
10519         inferior pointer.  Check the inferior's PID instead of
10520         inferior_ptid.
10521         * process-stratum-target.h
10522         (process_stratum_target::has_execution): Change parameter type to
10523         inferior pointer.
10524         * record-full.c (record_full_core_target::has_execution): Change
10525         parameter type to inferior pointer.
10526         * target.c (target_has_execution_1): Change parameter type to
10527         inferior pointer.
10528         (target_has_execution_current): Adjust.
10529         * target.h (target_ops::has_execution): Change parameter type to
10530         inferior pointer.
10531         (target_has_execution_1): Change parameter type to inferior
10532         pointer.  Change return type to bool.
10533         * tracefile.h (tracefile_target::has_execution): Change parameter
10534         type to inferior pointer.
10535
10536 2020-01-10  Pedro Alves  <palves@redhat.com>
10537
10538         * exceptions.c (print_flush): Remove current_top_target() check.
10539
10540 2020-01-10  Pedro Alves  <palves@redhat.com>
10541
10542         * remote.c (show_remote_exec_file): Show the current inferior's
10543         exec-file instead of the command variable's value.
10544
10545 2020-01-10  Pedro Alves  <palves@redhat.com>
10546
10547         * record-full.c (record_full_resume_ptid): New global.
10548         (record_full_target::resume): Set it.
10549         (record_full_wait_1): Use record_full_resume_ptid instead of
10550         inferior_ptid.
10551
10552 2020-01-10  Pedro Alves  <palves@redhat.com>
10553
10554         * gdbthread.h (scoped_restore_current_thread)
10555         <dont_restore, restore, m_dont_restore>: Declare.
10556         * thread.c (thread_alive): Add assertion.  Return bool.
10557         (switch_to_thread_if_alive): New.
10558         (prune_threads): Switch inferior/thread.
10559         (print_thread_info_1): Switch thread before calling target methods.
10560         (scoped_restore_current_thread::restore): New, factored out from
10561         ...
10562         (scoped_restore_current_thread::~scoped_restore_current_thread):
10563         ... this.
10564         (scoped_restore_current_thread::scoped_restore_current_thread):
10565         Add assertion.
10566         (thread_apply_all_command, thread_select): Use
10567         switch_to_thread_if_alive.
10568
10569 2020-01-10  George Barrett  <bob@bob131.so>
10570
10571         * stap-probe.c (stap_modify_semaphore): Don't check for null
10572         semaphores.
10573         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
10574         for null semaphores.
10575
10576 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10577
10578         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
10579         all source windows, and maintain horizontal scroll status while
10580         doing so.
10581
10582 2020-01-09  Tom Tromey  <tom@tromey.com>
10583
10584         PR tui/18932:
10585         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
10586         update_source_window, not print_source_lines.
10587
10588 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
10589
10590         * tui/tui.c (tui_enable): Register tui hooks after calling
10591         tui_display_main.
10592
10593 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10594
10595         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
10596
10597 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
10598
10599         * thread.c (print_thread_info_1): Fix indentation.
10600
10601 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
10602
10603         * symtab.c (general_symbol_info::compute_and_set_names): Move the
10604         unique_xmalloc_ptr outside the if to always free the demangled name.
10605
10606 2020-01-08  Tom Tromey  <tromey@adacore.com>
10607
10608         * xcoffread.c (enter_line_range, read_xcoff_symtab)
10609         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
10610         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
10611         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
10612         Remove.
10613         (section_offsets): New typedef.
10614         * symtab.c (fixup_section, get_msymbol_address): Update.
10615         * symmisc.c (dump_msymbols): Update.
10616         * symfile.h (relative_addr_info_to_section_offsets)
10617         (symfile_map_offsets_to_segments): Update.
10618         * symfile.c (build_section_addr_info_from_objfile)
10619         (init_objfile_sect_indices): Update.
10620         (struct place_section_arg): Change type of "offsets".
10621         (place_section): Update.
10622         (relative_addr_info_to_section_offsets): Change type of
10623         "section_offsets".  Remove "num_sections" parameter.
10624         (default_symfile_offsets, syms_from_objfile_1)
10625         (set_objfile_default_section_offset): Update.
10626         (reread_symbols): No need to preserve section offsets by hand.
10627         (symfile_map_offsets_to_segments): Change type of "offsets".
10628         * stap-probe.c (relocate_address): Update.
10629         * stabsread.h (process_one_symbol): Update.
10630         * solib-target.c (struct lm_info_target) <offsets>: Change type.
10631         (solib_target_relocate_section_addresses): Update.
10632         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
10633         Update.
10634         * solib-frv.c (frv_relocate_main_executable): Update.
10635         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
10636         * solib-aix.c (solib_aix_get_section_offsets): Change return
10637         type.
10638         (solib_aix_solib_create_inferior_hook): Update.
10639         * remote.c (remote_target::get_offsets): Update.
10640         * psymtab.c (find_pc_sect_psymtab): Update.
10641         * psympriv.h (struct partial_symbol) <address, text_low,
10642         text_high>: Update.
10643         * objfiles.h (obj_section_offset): Update.
10644         (struct objfile) <section_offsets>: Change type.
10645         <num_sections>: Remove.
10646         (objfile_relocate): Update.
10647         * objfiles.c (entry_point_address_query): Update
10648         (relocate_one_symbol): Change type of "section_offsets".
10649         (objfile_relocate1, objfile_relocate1): Change type of
10650         "new_offsets".
10651         (objfile_rebase1): Update.
10652         * mipsread.c (mipscoff_symfile_read): Update.
10653         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
10654         parameter.
10655         * mdebugread.c (parse_symbol): Change type of "section_offsets".
10656         (parse_external, psymtab_to_symtab_1): Update.
10657         * machoread.c (macho_symfile_offsets): Update.
10658         * ia64-tdep.c (ia64_find_unwind_table): Update.
10659         * hppa-tdep.c (read_unwind_info): Update.
10660         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
10661         * dwarf2read.c (create_addrmap_from_index)
10662         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
10663         (process_psymtab_comp_unit_reader, add_partial_symbol)
10664         (add_partial_subprogram, process_full_comp_unit)
10665         (read_file_scope, read_func_scope, read_lexical_block_scope)
10666         (read_call_site_scope, dwarf2_rnglists_process)
10667         (dwarf2_ranges_process, dwarf2_ranges_read)
10668         (dwarf_decode_lines_1, var_decode_location, new_symbol)
10669         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
10670         Update.
10671         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
10672         Update.
10673         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
10674         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
10675         (process_one_symbol): Change type of "section_offsets".
10676         * ctfread.c (get_objfile_text_range): Update.
10677         * coffread.c (coff_symtab_read, enter_linenos)
10678         (process_coff_symbol): Update.
10679         * coff-pe-read.c (add_pe_forwarded_sym): Update.
10680         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
10681
10682 2020-01-08  Tom Tromey  <tromey@adacore.com>
10683
10684         * dwarf2read.c (parse_macro_definition): Use std::string.
10685         (parse_macro_definition): Likewise.
10686
10687 2020-01-08  Tom Tromey  <tromey@adacore.com>
10688
10689         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
10690         (ATTR_ALLOC_CHUNK): Remove.
10691
10692 2020-01-08  Tom Tromey  <tromey@adacore.com>
10693
10694         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
10695
10696 2020-01-08  Tom Tromey  <tromey@adacore.com>
10697
10698         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
10699         (dwarf2_compute_name, open_dwo_file): Likewise.
10700         (process_enumeration_scope): Use std::vector.
10701         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
10702         (partial_die_info::fixup, dwarf2_start_subfile)
10703         (guess_full_die_structure_name, dwarf2_name): Likewise.
10704         (determine_prefix): Update.
10705         (guess_full_die_structure_name): Make return type const.
10706         (partial_die_full_name): Return unique_xmalloc_ptr.
10707         (DW_FIELD_ALLOC_CHUNK): Remove.
10708
10709 2020-01-07  Tom Tromey  <tromey@adacore.com>
10710
10711         PR build/24937:
10712         * stap-probe.c (class stap_static_probe_ops): Add constructor.
10713
10714 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10715
10716         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
10717
10718 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10719
10720         * stack.c (print_frame_info): Move disassemble_next_line code
10721         inside source_print block.
10722
10723 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10724
10725         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
10726         gdb/signals.h, as we are now using native signal symbols.
10727
10728 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10729
10730         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
10731         overflow by an early check of content vs threshold.
10732         * tui/tui-source.c (tui_source_window::line_is_displayed):
10733         Likewise.
10734
10735 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10736
10737         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
10738
10739 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
10740
10741         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
10742         export table if no section contains it's RVA.
10743
10744 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10745
10746         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
10747
10748 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
10749
10750         * source.c (print_source_lines_base): Set last_line_listed.
10751
10752 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
10753
10754         * tui/tui-disasm.c: Remove trailing spaces.
10755
10756 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
10757             Pedro Alves  <palves@redhat.com>
10758
10759         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
10760         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
10761         (windows_gdb_signal_to_target): New function, uses the above
10762         enumeration to convert GDB internal signal codes to equivalent
10763         Windows codes.
10764         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
10765         * windows-nat.c: Include "gdb_wait.h".
10766         (get_windows_debug_event): Extract the fatal exception from the
10767         exit status and convert to the equivalent Posix signal number.
10768         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
10769         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
10770         * gdbsupport/gdb_wait.c: New file, implements
10771         windows_status_to_termsig.
10772         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
10773         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
10774
10775 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10776
10777         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
10778         show_layout.
10779
10780 2020-01-05  Luis Machado  <luis.machado@linaro.org>
10781
10782         * aarch64-linux-nat.c
10783         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
10784         and bfd_mach_aarch64.
10785
10786 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10787
10788         * ui-file.c (stdio_file::can_emit_style_escape)
10789         (tee_file::can_emit_style_escape): Ensure style is used also on
10790         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
10791         to gdb_stdout.
10792         * main.c (set_gdb_data_directory): Use file style to output the
10793         warning that the given pathname is not a directory.
10794         * top.c (show_history_filename, gdb_safe_append_history)
10795         (show_gdb_datadir): Use file style.
10796
10797 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10798
10799         * solib-target.c (struct lm_info_target):
10800         Change offsets to be a unique_xmalloc_ptr.
10801         (solib_target_relocate_section_addresses): Update.
10802
10803 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
10804
10805         * windows-nat.c (windows_clear_solib): Free so_list linked list.
10806
10807 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
10808
10809         * MAINTAINERS (Write After Approval): Add myself.
10810
10811 2020-01-02  Luis Machado  <luis.machado@linaro.org>
10812
10813         * proc-service.c (get_ps_regcache): Remove reference to obsolete
10814         Cell BE architecture.
10815         * target.h (struct target_ops) <thread_architecture>: Likewise.
10816
10817 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10818
10819         * Makefile.in: Use INSTALL_PROGRAM_ENV.
10820
10821 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
10822
10823         * MAINTAINERS (Write After Approval): Add myself.
10824
10825 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10826
10827         * gdbarch.sh: Update copyright year range of generated files.
10828
10829 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10830
10831         Update copyright year range in all GDB files.
10832
10833 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10834
10835         * copyright.py: Convert to Python 3.
10836
10837 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10838
10839         * copyright.py: Adapt after move of gnulib directory from gdb
10840         directory to toplevel directory.
10841
10842 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10843
10844         * copyright.py (main): Exit if run from the wrong directory.
10845
10846 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10847
10848         * top.c (print_gdb_version): Change copyright year to 2020.
10849
10850 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
10851
10852         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
10853
10854 For older changes see ChangeLog-2019.
10855 \f
10856 Local Variables:
10857 mode: change-log
10858 left-margin: 8
10859 fill-column: 74
10860 version-control: never
10861 coding: utf-8
10862 End: