gdb/ChangeLog

   1 2019-07-03  Pedro Alves  <palves@redhat.com>
   2
   3         PR cli/24732
   4         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
   5         (pipe_cmd_option_defs): New.
   6         (make_pipe_cmd_options_def_group): New.
   7         (pipe_command): Use gdb::option::process_options.
   8         (pipe_command_completer): New function.
   9         (_initialize_cli_cmds): Install completer for "pipe" command.
  10
  11 2019-07-03  Pedro Alves  <palves@redhat.com>
  12
  13         * cli/cli-option.c (union option_value) <string>: New field.
  14         (struct option_def_and_value): Add ctor, move ctor, dtor and
  15         use DISABLE_COPY_AND_ASSIGN.
  16         (option_def_and_value::clear_value): New.
  17         (parse_option, save_option_value_in_ctx, get_val_type_str)
  18         (add_setshow_cmds_for_options): Handle var_string.
  19         * cli-option.h (union option_def::var_address) <string>: New
  20         field.
  21         (struct string_option_def): New.
  22         * maint-test-options.c (struct test_options_opts): Add default
  23         ctor and use DISABLE_COPY_AND_ASSIGN.
  24         <string_opt>: New field.
  25         (test_options_opts::~test_options_opts): New.
  26         (test_options_opts::dump): Also dump "-string".
  27         (test_options_option_defs): Install "string.
  28
  29 2019-07-03  Pedro Alves  <palves@redhat.com>
  30
  31         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
  32         option_value with a null enumeration.
  33         (complete_options): Save the option values in the context.
  34         (save_option_value_in_ctx): New, factored out from ...
  35         (process_options): ... here.
  36         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
  37         of the function.
  38         * maint-test-options.c (test_options_opts::dump): New, factored
  39         out from ...
  40         (maintenance_test_options_command_mode): ... here.
  41         (maintenance_test_options_command_completion_result): Delete.
  42         (maintenance_test_options_command_completion_text): Update
  43         comment.
  44         (maintenance_show_test_options_completion_result): Change
  45         prototype.  Just print
  46         maintenance_test_options_command_completion_text.
  47         (save_completion_result): New.
  48         (maintenance_test_options_completer_mode): Pass options context to
  49         complete_options, and then save a dump.
  50         (_initialize_maint_test_options): Use add_cmd to install "maint
  51         show test-options-completion-result".
  52
  53 2019-07-03  Pedro Alves  <palves@redhat.com>
  54
  55         * NEWS (New commands): Mention "with" and "maint with".
  56         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
  57         (with_command, with_command_completer): New.
  58         (pipe_command): Adjust to new repeat_previous
  59         interface.
  60         (_initialize_cli_cmds): Install the "with" command and its "w"
  61         alias.
  62         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
  63         declarations.
  64         * cli/cli-setshow.c (parse_cli_var_uinteger)
  65         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
  66         argument strings for all var_types.
  67         (get_setshow_command_value_string): New, factored out from ...
  68         (do_show_command): ... this.
  69         * cli/cli-setshow.h: Include <string>.
  70         (get_setshow_command_value_string): Declare.
  71         * command.h (repeat_previous): Now returns const char *.  Adjust
  72         comment.
  73         * maint.c: Include "cli/cli-cmds.h".
  74         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
  75         (_initialize_maint_cmds): Register the "maintenance with" command.
  76         * top.c (repeat_previous): Move bits from pipe_command here:
  77         Return the saved command line, if any; error out if there's no
  78         command to relaunch.
  79
  80 2019-07-03  Pedro Alves  <palves@redhat.com>
  81
  82         * NEWS (New commands): Mention "maint set/show test-settings"
  83         instead of "maint test-settings".
  84         * maint-test-settings.c (maintenance_test_settings_list): Delete.
  85         (maintenance_test_settings_set_list): Rename to ...
  86         (maintenance_set_test_settings_list): ... this.
  87         (maintenance_test_settings_show_list): Rename to  ...
  88         (maintenance_show_test_settings_list): ... this.
  89         (maintenance_test_settings_cmd): Delete.
  90         (maintenance_test_settings_set_cmd): ...
  91         (maintenance_set_test_settings_cmd): ... this.
  92         (maintenance_test_settings_show_cmd): ...
  93         (maintenance_show_test_settings_cmd): ... this.
  94         (maintenance_test_settings_show_value_cmd):
  95         (maintenance_show_test_settings_value_cmd): ... this.
  96         (_initialize_maint_test_settings): No longer install the "maint
  97         test-settings" prefix command.  Rename "maint test-settings set"
  98         to "maint set test-settings", and "maint test-settings show" to
  99         "maint show test-settings".  Adjust all subcommands.
 100
 101 2019-07-03  Pedro Alves  <palves@redhat.com>
 102
 103         * maint-test-settings.c: Fix file's intro comment.  Replace all
 104         references to "test-options" with references to "test-settings",
 105         in comments.
 106
 107 2019-07-03  Pedro Alves  <palves@redhat.com>
 108
 109         * maint-test-settings.c (maintenance_test_settings_xxx)
 110         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 111         New.
 112         (maintenance_test_settings_enums): Use them.
 113         (maintenance_test_settings_enum): Default to
 114         maintenance_test_settings_xxx.
 115         (_initialize_maint_test_settings): Initialize
 116         MAINTENANCE_TEST_SETTINGS_FILENAME.
 117
 118 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 119
 120         * breakpoint.h (remove_breakpoints_inf): Change return type to
 121         void, move function documentation here.
 122         * breakpoint.c (remove_breakpoints_inf): Change return type to
 123         void, move function documentation to header.
 124
 125 2019-07-02  Pedro Alves  <palves@redhat.com>
 126
 127         * NEWS (Completion improvements): Mention "info threads".
 128         * thread.c (struct info_threads_opts, info_threads_option_defs)
 129         (make_info_threads_options_def_group): New.
 130         (info_threads_command): Use gdb::option::process_options.
 131         (info_threads_command_completer): New.
 132         (_initialize_thread): Use gdb::option::build_help to build the
 133         help text for "info threads".
 134
 135 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 136
 137         * defs.h (generic_load): Move from here...
 138         * symfile.h (generic_load): ... to here.  Rename name parameter
 139         to args.
 140         * symfile.c (generic_load): Add comment.
 141
 142 2019-07-01  Tom Tromey  <tromey@adacore.com>
 143
 144         * dwarf2read.c
 145         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 146         declaration of without_params.  Fix formatting.
 147
 148 2019-07-01  Tom Tromey  <tromey@adacore.com>
 149
 150         * ada-exp.y (find_primitive_type): Update.
 151         * ada-lang.h (ada_lookup_symbol): Update.
 152         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 153         parameter.
 154         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 155
 156 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 157
 158         PR breakpoints/24541
 159         * gdbarch.c: Regenerate.
 160         * gdbarch.h: Regenerate.
 161         * gdbarch.sh: Add 'stap_adjust_register'.
 162         * i386-tdep.c: Include '<unordered_set>'.
 163         (i386_stap_adjust_register): New function.
 164         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 165         * stap-probe.c (stap_parse_register_operand): Call
 166         'gdbarch_stap_adjust_register'.
 167
 168 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 169
 170         PR python/24742
 171         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 172         * python/python.c (do_start_initialization): Use 'xmalloc'
 173         instead of 'PyMem_Malloc'.
 174
 175 2019-06-28  Tom Tromey  <tromey@adacore.com>
 176
 177         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 178         for Ada.
 179
 180 2019-06-27  Tom Tromey  <tromey@adacore.com>
 181
 182         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 183         objfile_key.
 184         (arm_find_mapping_symbol, arm_record_special_symbol)
 185         (_initialize_arm_tdep): Update.
 186         (arm_objfile_data_free): Remove.
 187
 188 2019-06-27  Tom Tromey  <tromey@adacore.com>
 189
 190         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 191         to cp_print_static_field.
 192
 193 2019-06-26  Tom Tromey  <tromey@adacore.com>
 194
 195         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 196         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 197         declare.
 198
 199 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 200
 201         * features/aarch64-core.c (create_feature_aarch64_core):
 202         Regenerate.
 203         * features/aarch64-core.xml: Add cpsr flags.
 204
 205 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 206
 207         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 208         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 209
 210 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 211
 212         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 213         field.
 214         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 215         use.
 216         (arm_record_special_symbol): Don't insert new symbol in sorted
 217         position, push it at the end.
 218
 219 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 220
 221         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 222         (arm_mapping_symbol_s): Remove.
 223         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 224         (arm_mapping_symbol_vec): New typedef.
 225         (struct arm_per_objfile): Add constructor.
 226         <section_maps>: Change type to
 227         std::unique_ptr<arm_mapping_symbol_vec[]>.
 228         (arm_compare_mapping_symbols): Remove.
 229         (arm_find_mapping_symbol): Adjust to section_maps type change.
 230         (arm_objfile_data_free): Call delete on arm_per_objfile.
 231         (arm_record_special_symbol): Adjust to section_maps type change.
 232         Allocate arm_per_objfile with new.
 233
 234 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 235
 236         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 237         with the command prefix.
 238
 239 2019-06-25  Tom Tromey  <tom@tromey.com>
 240
 241         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 242         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 243
 244 2019-06-25  Tom Tromey  <tom@tromey.com>
 245
 246         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 247         type.
 248         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 249         protected.
 250
 251 2019-06-25  Tom Tromey  <tom@tromey.com>
 252
 253         * tui/tui-winsource.c
 254         (tui_source_window_base::set_is_exec_point_at): Add check against
 255         LOA_ADDRESS.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-source.c (tui_set_source_content): Don't check before
 260         xfree.
 261         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 262
 263 2019-06-25  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.h (tui_update_source_window_as_is)
 266         (tui_alloc_source_buffer, tui_line_is_displayed)
 267         (tui_addr_is_displayed): Change type of win_info.
 268         * tui/tui-winsource.c (tui_update_source_window_as_is)
 269         (tui_clear_source_content, tui_show_source_line)
 270         (tui_show_source_content, tui_source_window_base::refill)
 271         (tui_source_window_base::set_is_exec_point_at)
 272         (tui_source_window_base::set_is_exec_point_at)
 273         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 274         (tui_alloc_source_buffer, tui_line_is_displayed)
 275         (tui_addr_is_displayed): Change type of win_info.  Update.
 276         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 277         (tui_source_window_base::do_make_visible_with_new_height):
 278         Update.
 279         * tui/tui-source.c (tui_set_source_content)
 280         (tui_set_source_content_nil)
 281         (tui_source_window::do_scroll_vertical): Update.
 282         * tui/tui-layout.c (show_layout): Update.
 283         * tui/tui-disasm.c (tui_set_disassem_content)
 284         (tui_disasm_window::do_scroll_vertical): Update.
 285         * tui/tui-data.h (tui_win_content): Remove.
 286         (struct tui_gen_win_info) <content, content_size>: Remove.
 287         (struct tui_source_element): Add initializers and destructor.
 288         (union tui_which_element, struct tui_win_element): Remove.
 289         (struct tui_source_window_base) <content>: New field.
 290         (struct tui_data_window): Remove destructor.
 291         (tui_alloc_content, tui_free_win_content)
 292         (tui_free_all_source_wins_content): Don't declare.
 293         * tui/tui-data.c (tui_initialize_static_data): Update.
 294         (init_content_element, tui_alloc_content): Remove.
 295         (~tui_gen_win_info): Update.
 296         (~tui_data_window, tui_free_all_source_wins_content)
 297         (tui_free_win_content, free_content, free_content_elements):
 298         Remove.
 299
 300 2019-06-25  Tom Tromey  <tom@tromey.com>
 301
 302         * tui/tui-winsource.h (tui_clear_source_content)
 303         (tui_erase_source_content, tui_show_source_content): Change type
 304         of win_info.
 305         * tui/tui-winsource.c (tui_clear_source_content)
 306         (tui_erase_source_content, tui_show_source_content): Change type
 307         of win_info.
 308         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 309         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 310         win_info.
 311         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 312         win_info.
 313         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 314
 315 2019-06-25  Tom Tromey  <tom@tromey.com>
 316
 317         * tui/tui-winsource.c (tui_clear_source_content)
 318         (tui_source_window_base::set_is_exec_point_at): Update.
 319         * tui/tui-source.c (tui_set_source_content_nil): Update.
 320         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 321         a bool.
 322         * tui/tui-data.c (init_content_element): Update.
 323
 324 2019-06-25  Tom Tromey  <tom@tromey.com>
 325
 326         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 327         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 328         * tui/tui-layout.c (init_and_make_win): Update.
 329         * tui/tui.h (enum tui_win_type): Update.
 330         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 331         tui_win_is_auxillary.
 332         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 333         tui_win_is_auxillary.
 334
 335 2019-06-25  Tom Tromey  <tom@tromey.com>
 336
 337         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 338         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 339         (tui_delete_data_content_windows, tui_display_all_data)
 340         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 341         Update.
 342         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 343         * tui/tui-regs.c (tui_last_regs_line_no)
 344         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 345         (tui_show_registers): Update.
 346         (tui_show_register_group): Return void.  Update.
 347         (tui_display_registers_from, tui_display_reg_element_at_line)
 348         (tui_display_registers_from_line, tui_check_register_values):
 349         Update.
 350         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 351         member.
 352         (struct tui_data_window) <regs_content>: Now a std::vector.
 353         <regs_content_count>: Remove.
 354         (tui_add_content_elements, tui_free_data_content): Don't declare.
 355         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 356         (init_content_element): Remove DATA_WIN case.  Add assert.
 357         (tui_add_content_elements): Remove.
 358         (tui_data_window): Update.
 359         (tui_free_data_content): Remove.
 360         (free_content_elements): Remove DATA_WIN case.
 361
 362 2019-06-25  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui-data.c (tui_data_item_window): Update.
 365         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 366         * tui/tui-windata.c (tui_display_all_data)
 367         (tui_display_data_from_line): Update.
 368         (tui_check_data_values): Remove.
 369         * tui/tui-regs.c (tui_show_register_group)
 370         (tui_display_reg_element_at_line): Update.
 371         * tui/tui-hooks.c (tui_register_changed)
 372         (tui_refresh_frame_and_register_information): Call
 373         tui_check_register_values.
 374         * tui/tui-data.h (struct tui_data_window) <data_content,
 375         data_content_count, data_type>: Remove.
 376         (enum tui_data_type): Remove.
 377
 378         * tui/tui-data.c (tui_data_window::clear_detail)
 379         (~tui_data_window): Update.
 380
 381 2019-06-25  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 384         declare.
 385         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 386         Rename from tui_first_data_item_displayed.  Update.
 387         (tui_data_window::refresh_all)
 388         (tui_data_window::do_scroll_vertical): Update.
 389         * tui/tui-data.h (struct tui_data_window)
 390         <first_data_item_displayed>: Declare new method.
 391
 392 2019-06-25  Tom Tromey  <tom@tromey.com>
 393
 394         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 395         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 396         contents...
 397         (tui_initialize_static_data): ...here.
 398
 399 2019-06-25  Tom Tromey  <tom@tromey.com>
 400
 401         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 402         (tui_display_registers_from, tui_check_register_values): Update.
 403         (tui_display_register): Remove win_info parameter; update.
 404         (tui_get_register): Change type of parameters.
 405         * tui/tui-data.h (struct tui_data_element): Remove.
 406         (union tui_which_element) <data>: Remove.
 407         <data_window>: Change type.
 408         (struct tui_data_item_window): New.
 409         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 410         case.  Add assert.
 411         (~tui_data_item_window): New destructor.
 412         (free_content_elements): Remove DATA_ITEM_WIN case.
 413
 414 2019-06-25  Tom Tromey  <tom@tromey.com>
 415
 416         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 417         Remove.
 418
 419 2019-06-25  Tom Tromey  <tom@tromey.com>
 420
 421         * tui/tui-data.h (struct tui_command_element): Remove.
 422         (union tui_which_element) <command>: Remove.
 423         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 424         assert.
 425         (free_content_elements): Remove CMD_WIN case.
 426
 427 2019-06-25  Tom Tromey  <tom@tromey.com>
 428
 429         * tui/tui-layout.c (tui_set_layout): Update.
 430         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 431         * tui/tui-data.c (layout_def): Update.
 432
 433 2019-06-25  Tom Tromey  <tom@tromey.com>
 434
 435         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 436         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 437         (tui_source_window_base::set_new_height): Update.
 438         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 439         Update.
 440         (tui_set_locator_fullname, tui_set_locator_info)
 441         (tui_show_frame_info): Update.
 442         * tui/tui-source.c (tui_set_source_content)
 443         (tui_source_is_displayed): Update.
 444         * tui/tui-layout.c (show_source_disasm_command, show_data)
 445         (show_source_or_disasm_and_command): Update.
 446         * tui/tui-disasm.c (tui_set_disassem_content)
 447         (tui_get_begin_asm_address): Update.
 448         * tui/tui-data.h (struct tui_locator_element): Remove.
 449         (union tui_which_element) <locator>: Remove.
 450         (struct tui_locator_window): New.
 451         (tui_locator_win_info_ptr): Change return type.
 452         * tui/tui-data.c (_locator): Change type.
 453         (tui_locator_win_info_ptr): Change return type.
 454         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 455         (tui_alloc_content): Add assert.
 456
 457 2019-06-25  Tom Tromey  <tom@tromey.com>
 458
 459         * tui/tui-winsource.c
 460         (tui_exec_info_window::maybe_allocate_content): New method.
 461         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 462         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 463         (make_source_or_disasm_window): Add cast.
 464         * tui/tui-data.h (union tui_which_element) <simple_string>:
 465         Remove.
 466         (struct tui_source_info): New.
 467         (struct tui_source_window_base) <execution_info>: Change type.
 468         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 469         case, and add assert.
 470         (tui_alloc_content): Add assert.
 471
 472 2019-06-25  Tom Tromey  <tom@tromey.com>
 473
 474         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 475         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 476         * tui/tui-data.c (tui_alloc_win_info): Remove.
 477
 478 2019-06-25  Tom Tromey  <tom@tromey.com>
 479
 480         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 481         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 482         can_highlight.
 483
 484 2019-06-25  Tom Tromey  <tom@tromey.com>
 485
 486         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 487         make_visible_with_new_height method.
 488         (tui_win_info::make_visible_with_new_height): New method.
 489         (tui_source_window_base::do_make_visible_with_new_height)
 490         (tui_data_window::do_make_visible_with_new_height)
 491         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 492         (make_visible_with_new_height): Remove.
 493         (tui_resize_all, tui_adjust_win_heights): Use
 494         make_visible_with_new_height method.
 495         * tui/tui-data.h (struct tui_win_info)
 496         <do_make_visible_with_new_height, make_visible_with_new_height>:
 497         New methods.
 498         (struct tui_source_window_base, struct tui_data_window)
 499         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 500         methods.
 501
 502 2019-06-25  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 505         method.
 506         (update_tab_width): Call update_tab_width method.
 507         * tui/tui-data.h (struct tui_win_info)
 508         (struct tui_source_window_base) <update_tab_width>: New methods.
 509
 510 2019-06-25  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 513         parameter.
 514         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 515         parameter.
 516         (tui_gen_win_info::make_visible): Update.
 517         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 518         parameter.
 519         * tui/tui-data.h (enum tui_box): New enum.
 520         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 521
 522 2019-06-25  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 525         init_and_make_win for EXEC_INFO_WIN.
 526         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 527         longer inline.
 528         (struct tui_win_info) <~tui_win_info>: Inline.
 529         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 530         Don't declare.
 531         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 532         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 533         Remove.
 534         (tui_initialize_static_data): Update.
 535         (~tui_gen_win_info): Handle more cleanup here.
 536         (~tui_source_window_base): Delete "execution_info".
 537         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 538
 539 2019-06-25  Tom Tromey  <tom@tromey.com>
 540
 541         * tui/tui-layout.c (make_command_window): Don't set
 542         can_highlight.
 543         (show_source_disasm_command): Call the reset method.
 544         (show_data): Don't set can_highlight.  Call the reset method.
 545         (tui_gen_win_info::reset): Rename from init_gen_win_info
 546         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 547         (show_source_or_disasm_and_command): Call the reset method.
 548         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 549         (struct tui_cmd_window): Set can_highlight.
 550
 551 2019-06-25  Tom Tromey  <tom@tromey.com>
 552
 553         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 554         from make_visible.
 555         (tui_make_visible, tui_make_invisible): Rewrite.
 556         (tui_win_info::make_visible): Remove.
 557         (tui_source_window_base::make_visible): Update.
 558         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 559         method.  Moved from...
 560         (struct tui_win_info) <make_visible>: ...here.
 561
 562 2019-06-25  Tom Tromey  <tom@tromey.com>
 563
 564         * tui/tui-winsource.c
 565         (tui_source_window_base::do_scroll_horizontal): Remove direction
 566         parameter.
 567         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 568         direction parameter.
 569         * tui/tui-win.c (tui_win_info::forward_scroll)
 570         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 571         (tui_win_info::right_scroll): Update.
 572         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 573         direction parameter.
 574         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 575         direction parameter.
 576         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 577         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 578         Remove direction parameter.
 579         (struct tui_source_window_base, struct tui_source_window)
 580         (struct tui_disasm_window, struct tui_data_window)
 581         (struct tui_cmd_window): Update.
 582
 583 2019-06-25  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-winsource.h (tui_set_exec_info_content)
 586         (tui_show_exec_info_content, tui_erase_exec_info_content)
 587         (tui_clear_exec_info_content, tui_update_exec_info): Change
 588         argument to tui_source_window_base.
 589         * tui/tui-winsource.c (tui_set_exec_info_content)
 590         (tui_show_exec_info_content, tui_erase_exec_info_content)
 591         (tui_clear_exec_info_content, tui_update_exec_info): Change
 592         argument to tui_source_window_base.
 593
 594 2019-06-25  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 597         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 598
 599 2019-06-25  Tom Tromey  <tom@tromey.com>
 600
 601         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 602         check.
 603
 604 2019-06-25  Tom Tromey  <tom@tromey.com>
 605
 606         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 607         type to void.
 608         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 609         type to void.
 610         * tui/tui-source.c (tui_set_source_content): Update.
 611         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 612
 613 2019-06-25  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-win.c (window_name_completer, tui_set_focus)
 616         (tui_all_windows_info): Use name method.
 617         * tui/tui-data.h (struct tui_gen_win_info)
 618         (struct tui_source_window, struct tui_disasm_window)
 619         (struct tui_data_window, struct tui_cmd_window) <name>: New
 620         method.
 621         (tui_win_name): Don't declare.
 622         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 623         (tui_win_name): Remove.
 624
 625 2019-06-25  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-winsource.h (tui_update_source_window)
 628         (tui_update_source_window_as_is): Change parameter type.
 629         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 630         to be a tui_source_window_base.
 631         (tui_update_source_window_as_is): Likewise.
 632         * tui/tui-win.c (make_visible_with_new_height): Update.
 633
 634 2019-06-25  Tom Tromey  <tom@tromey.com>
 635
 636         * tui/tui-winsource.c (tui_erase_source_content)
 637         (tui_show_source_content, tui_show_exec_info_content)
 638         (tui_erase_exec_info_content): Use refresh_window method.
 639         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 640         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 641         from tui_refresh_win.
 642         (tui_data_window::refresh_window): New method.
 643         (tui_win_info::refresh, tui_source_window_base::refresh)
 644         (tui_refresh_all): Use refresh_window method.
 645         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 646         method.
 647         * tui/tui-regs.c (tui_display_register): Call refresh_window
 648         method.
 649         * tui/tui-layout.c (show_source_disasm_command)
 650         (show_source_or_disasm_and_command): Call refresh_window method.
 651         * tui/tui-data.h (struct tui_gen_win_info)
 652         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 653         New method.
 654
 655 2019-06-25  Tom Tromey  <tom@tromey.com>
 656
 657         * tui/tui.c (tui_rl_other_window, tui_enable)
 658         (tui_is_window_visible, tui_get_command_dimension): Update.
 659         * tui/tui-winsource.c (tui_update_source_window_as_is)
 660         (tui_clear_source_content, tui_erase_source_content)
 661         (tui_show_source_line, tui_source_window_base::refill)
 662         (tui_source_window_base::do_scroll_horizontal)
 663         (tui_source_window_base::set_is_exec_point_at)
 664         (tui_update_breakpoint_info, tui_set_exec_info_content)
 665         (tui_alloc_source_buffer, tui_line_is_displayed)
 666         (tui_addr_is_displayed): Update.
 667         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 668         (tui_check_and_display_highlight_if_needed)
 669         (tui_win_info::make_visible, tui_win_info::refresh)
 670         (tui_refresh_all): Update.
 671         * tui/tui-windata.c (tui_first_data_item_displayed)
 672         (tui_delete_data_content_windows, tui_erase_data_content)
 673         (tui_display_all_data, tui_data_window::refresh_all)
 674         (tui_check_data_values): Update.
 675         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 676         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 677         (tui_win_info::backward_scroll, tui_refresh_all_win)
 678         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 679         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 680         (tui_source_window_base::set_new_height)
 681         (tui_data_window::set_new_height)
 682         (make_invisible_and_set_new_height)
 683         (make_visible_with_new_height, new_height_ok)
 684         (parse_scrolling_args): Update.
 685         * tui/tui-stack.c (tui_show_frame_info): Update.
 686         * tui/tui-source.c (tui_set_source_content)
 687         (tui_set_source_content_nil, tui_source_is_displayed)
 688         (tui_source_window::do_scroll_vertical): Update.
 689         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 690         (tui_display_registers_from, tui_display_reg_element_at_line)
 691         (tui_check_register_values, tui_reg_command): Update.
 692         * tui/tui-layout.c (tui_default_win_height)
 693         (show_source_disasm_command, show_data, init_and_make_win)
 694         (show_source_or_disasm_and_command): Update.
 695         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 696         (tui_redisplay_readline, tui_mld_flush)
 697         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 698         (tui_getc): Update.
 699         * tui/tui-disasm.c (tui_set_disassem_content)
 700         (tui_disasm_window::do_scroll_vertical): Update.
 701         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 702         Now virtual.
 703         (struct tui_win_info): Derive from tui_gen_win_info.
 704         <~tui_win_info>: Mark as override.
 705         <generic>: Remove member.
 706         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 707         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 708         (~tui_data_window, ~tui_win_info)
 709         (tui_free_all_source_wins_content): Update.
 710         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 711
 712 2019-06-25  Tom Tromey  <tom@tromey.com>
 713
 714         * tui/tui-layout.c (init_and_make_win): Use new.
 715         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 716         destructor, initializers.
 717         (tui_alloc_generic_win_info): Don't declare.
 718         * tui/tui-data.c (_locator): Add argument to constructor.
 719         (source_win, disasm_win): New globals.
 720         (exec_info): Remove.
 721         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 722         Update.
 723         (tui_alloc_generic_win_info): Remove.
 724         (init_content_element): Use new.
 725         (tui_win_info::tui_win_info): Update.
 726         (free_content_elements) <case DATA_WIN>: Use delete.
 727
 728 2019-06-25  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 731         * tui/tui-windata.c (tui_first_data_item_displayed)
 732         (tui_delete_data_content_windows): Update.
 733         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 734         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 735         (tui_display_registers_from, tui_check_register_values): Update.
 736         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 737         pointer.
 738         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 739         window.
 740         (tui_free_data_content): Update.
 741         (free_content_elements) <case DATA_WIN>: Free the window.
 742
 743 2019-06-25  Tom Tromey  <tom@tromey.com>
 744
 745         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 746         Update.
 747         * tui/tui-layout.c (make_command_window)
 748         (show_source_disasm_command, show_data, init_and_make_win)
 749         (show_source_or_disasm_and_command): Update.
 750         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 751         method.
 752         <can_highight, is_highlighted>: Now bool.
 753         (tui_set_win_highlight): Don't declare.
 754         * tui/tui-data.c (tui_set_win_highlight): Remove.
 755
 756 2019-06-25  Tom Tromey  <tom@tromey.com>
 757
 758         * tui/tui-wingeneral.c (make_visible): Remove check of window
 759         type.
 760
 761 2019-06-25  Tom Tromey  <tom@tromey.com>
 762
 763         * tui/tui-win.c (tui_win_info::max_height)
 764         (tui_cmd_window::max_height): New methods.
 765         (new_height_ok): Call max_height.
 766         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 767         <max_height>: New method.
 768
 769 2019-06-25  Tom Tromey  <tom@tromey.com>
 770
 771         * tui/tui-win.c (tui_source_window_base::set_new_height)
 772         (tui_data_window::set_new_height): New methods.
 773         (make_invisible_and_set_new_height): Call set_new_height method.
 774         * tui/tui-data.h (struct tui_win_info)
 775         (struct tui_source_window_base, struct tui_data_window)
 776         <set_new_height>: New method.
 777
 778 2019-06-25  Tom Tromey  <tom@tromey.com>
 779
 780         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 781         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 782         tui_refresh_data_win.
 783         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 784         method.
 785         (tui_refresh_all_win): Call the refresh_all method.
 786         (tui_set_focus): Likewise.
 787         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 788         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 789         Likewise.
 790
 791 2019-06-25  Tom Tromey  <tom@tromey.com>
 792
 793         * tui/tui-winsource.h (tui_refill_source_window)
 794         (tui_set_is_exec_point_at): Don't declare.
 795         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 796         (tui_source_window_base::refill): Rename from
 797         tui_refill_source_window.
 798         (tui_source_window_base::do_scroll_horizontal): Update.
 799         (tui_source_window_base::set_is_exec_point_at): Rename from
 800         tui_set_is_exec_point_at.
 801         (tui_update_all_breakpoint_info): Update.
 802         * tui/tui-stack.c (tui_show_frame_info): Update.
 803         * tui/tui-layout.c (show_data): Add cast.
 804         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 805         * tui/tui-data.h (struct tui_source_window_base) <refill,
 806         set_is_exec_point_at>: New methods.
 807         (tui_source_windows, tui_add_to_source_windows): Update types.
 808         (tui_add_to_source_windows): Remove redundant declaration.
 809         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 810         (tui_source_windows): Change return type.
 811         (tui_clear_source_windows_detail): Update.
 812         (tui_add_to_source_windows): Change type of parameter.
 813         (tui_free_all_source_wins_content): Update.
 814
 815 2019-06-25  Tom Tromey  <tom@tromey.com>
 816
 817         * tui/tui-wingeneral.c (tui_win_info::refresh)
 818         (tui_source_window_base::refresh): New methods.
 819         (tui_refresh_all): Call the refresh method.
 820         * tui/tui-data.h (struct tui_win_info)
 821         (struct tui_source_window_base) <refresh>: New method.
 822
 823 2019-06-25  Tom Tromey  <tom@tromey.com>
 824
 825         * tui/tui.h (tui_is_window_visible): Return bool.
 826         * tui/tui.c (tui_is_window_visible): Return bool.
 827         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 828         (tui_make_visible, tui_make_invisible)
 829         (tui_win_info::make_visible)
 830         (tui_source_window_base::make_visible, make_all_visible)
 831         (tui_make_all_visible, tui_make_all_invisible): Update.
 832         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 833         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 834         bool.
 835         (struct tui_win_info, struct tui_source_window_base)
 836         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 837         * tui/tui-data.c (tui_init_generic_part): Update.
 838
 839 2019-06-25  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 842         (tui_source_window_base::make_visible): New methods.
 843         (make_all_visible): Make method call.
 844         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 845         (struct tui_source_window_base, struct tui_cmd_window): Override
 846         make_visible.
 847         (tui_win_is_source_type): Don't declare.
 848         * tui/tui-data.c (tui_win_is_source_type): Remove.
 849
 850 2019-06-25  Tom Tromey  <tom@tromey.com>
 851
 852         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 853         NULL check.
 854
 855 2019-06-25  Tom Tromey  <tom@tromey.com>
 856
 857         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 858         Inline constructor.  Add initializers for members.
 859         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 860         constructors; now inline in class.
 861
 862 2019-06-25  Tom Tromey  <tom@tromey.com>
 863
 864         * tui/tui-regs.c (tui_show_registers): Update.
 865         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 866         bool.
 867         * tui/tui-data.c (tui_data_window::clear_detail)
 868         (tui_data_window): Update.
 869
 870 2019-06-25  Tom Tromey  <tom@tromey.com>
 871
 872         * tui/tui-windata.c (tui_display_all_data)
 873         (tui_display_data_from_line, tui_display_data_from)
 874         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 875         Update.
 876         * tui/tui-regs.c (tui_last_regs_line_no)
 877         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 878         (tui_show_registers, tui_show_register_group)
 879         (tui_display_registers_from, tui_display_reg_element_at_line)
 880         (tui_display_registers_from_line, tui_check_register_values)
 881         (tui_reg_next, tui_reg_prev): Update.
 882         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 883         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 884         tui_data_window.
 885         (struct tui_win_info) <detail>: Remove.  Add new fields from
 886         tui_data_info.
 887         (TUI_DATA_WIN): Add cast.
 888         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 889         (~tui_data_window): Simplify.
 890
 891 2019-06-25  Tom Tromey  <tom@tromey.com>
 892
 893         * tui/tui-layout.c (show_source_disasm_command)
 894         (show_source_or_disasm_and_command): Update.
 895         * tui/tui-io.c (update_cmdwin_start_line)
 896         (tui_redisplay_readline): Update.
 897         * tui/tui-data.h (struct tui_command_info): Remove.
 898         (struct tui_win_info) <detail>: Remove command_info member.
 899         (struct tui_data_window) <start_line>: New member, from
 900         tui_command_info.
 901         (TUI_CMD_WIN): Add casts.
 902
 903 2019-06-25  Tom Tromey  <tom@tromey.com>
 904
 905         * tui/tui-winsource.c (tui_update_source_window)
 906         (tui_refill_source_window)
 907         (tui_source_window_base::do_scroll_horizontal)
 908         (tui_update_breakpoint_info, tui_set_exec_info_content)
 909         (tui_show_exec_info_content, tui_erase_exec_info_content)
 910         (tui_clear_exec_info_content): Update.
 911         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 912         Update.
 913         * tui/tui-win.c (make_invisible_and_set_new_height)
 914         (make_visible_with_new_height): Update.
 915         * tui/tui-source.c (tui_set_source_content)
 916         (tui_show_symtab_source): Update.
 917         * tui/tui-layout.c (extract_display_start_addr)
 918         (show_source_disasm_command, show_data)
 919         (make_source_or_disasm_window)
 920         (show_source_or_disasm_and_command): Update.
 921         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 922         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 923         "gdbarch".
 924         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 925         to tui_source_window_base.
 926         (struct tui_win_info) <detail>: Remove source_info member.
 927         (struct tui_source_window_base) <has_locator>: Inline.
 928         Move contents from tui_source_info; rename has_locator member to
 929         m_has_locator.
 930         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 931         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 932         header file.
 933         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 934         Simplify.
 935         (tui_free_all_source_wins_content): Cast to
 936         tui_source_window_base.
 937
 938 2019-06-25  Tom Tromey  <tom@tromey.com>
 939
 940         * tui/tui-win.c (make_invisible_and_set_new_height)
 941         (make_visible_with_new_height): Call has_locator method.
 942         * tui/tui-layout.c (show_source_disasm_command, show_data)
 943         (show_source_or_disasm_and_command): Update for bool change.
 944         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 945         (tui_win_info) <has_locator>: New method.
 946         (struct tui_source_window_base) <has_locator>: New method.
 947         (tui_win_has_locator): Don't declare.
 948         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 949         from tui_win_has_locator.
 950         (tui_source_window_base): Use false, not FALSE.
 951
 952 2019-06-25  Tom Tromey  <tom@tromey.com>
 953
 954         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 955         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 956         clear_detail method directly.
 957         (tui_clear_win_detail): Remove.
 958
 959 2019-06-25  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 962         "this", not TUI_DISASM_WIN.
 963
 964 2019-06-25  Tom Tromey  <tom@tromey.com>
 965
 966         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 967         declare.
 968         * tui/tui-winsource.c
 969         (tui_source_window_base::do_scroll_horizontal): Rename from
 970         tui_horizontal_source_scroll.
 971         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 972         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 973         from tui_vertical_data_scroll.
 974         * tui/tui-win.h (tui_scroll): Don't declare.
 975         * tui/tui-win.c (tui_win_info::forward_scroll)
 976         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 977         (tui_win_info::right_scroll): Rename and update.
 978         (tui_scroll_forward_command, tui_scroll_backward_command)
 979         (tui_scroll_left_command, tui_scroll_right_command): Update.
 980         (tui_scroll): Remove.
 981         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 982         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 983         from tui_vertical_source_scroll.
 984         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 985         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 986         from tui_vertical_disassem_scroll.
 987         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 988         do_scroll_horizontal>: New methods.
 989         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 990         Likewise.
 991         (struct tui_source_window_base): Add do_scroll_horizontal.
 992         (struct tui_source_window, struct tui_disasm_window): Add
 993         do_scroll_vertical.
 994         (struct tui_data_window, struct tui_cmd_window): Add
 995         do_scroll_horizontal and do_scroll_vertical.
 996         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 997
 998 2019-06-25  Tom Tromey  <tom@tromey.com>
 999
1000         * tui/tui-data.h (struct tui_source_window_base): New struct.
1001         (struct tui_source_window): Derive from tui_source_window_base.
1002         (struct tui_disasm_window): New struct.
1003         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
1004         from tui_source_window::clear_detail.
1005         (tui_source_window_base): Rename from tui_source_window.
1006         (~tui_source_window_base): Rename from ~tui_source_window.
1007         (tui_alloc_win_info): Create a tui_disasm_window.
1008
1009 2019-06-25  Tom Tromey  <tom@tromey.com>
1010
1011         * tui/tui-data.h (struct tui_source_window)
1012         (struct tui_data_window): Declare destructors.
1013         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1014         destructors.
1015         (tui_win_info): Simplify.
1016
1017 2019-06-25  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-winsource.c (tui_display_main)
1020         (tui_update_source_windows_with_addr)
1021         (tui_update_all_breakpoint_info): Update.
1022         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1023         (new_height_ok, parse_scrolling_args): Update.
1024         * tui/tui-stack.c (tui_show_frame_info): Update.
1025         * tui/tui-data.h (struct tui_list): Remove.
1026         (tui_source_windows): Return a reference to a std::vector.
1027         * tui/tui-data.c (source_windows): Now a std::vector.
1028         (tui_source_windows): Change return type.
1029         (tui_clear_source_windows): Rewrite.
1030         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1031         (tui_free_all_source_wins_content): Rewrite.
1032
1033 2019-06-25  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1036         (struct tui_data_window, struct tui_cmd_window): Declare
1037         clear_detail method.
1038         * tui/tui-data.c (tui_source_window::clear_detail)
1039         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1040         methods.
1041         (tui_clear_win_detail): Simplify.
1042
1043 2019-06-25  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-layout.c (make_source_window, make_disasm_window)
1046         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1047         Return the new window.
1048         (show_source_disasm_command, show_data)
1049         (show_source_or_disasm_and_command): Update.
1050
1051 2019-06-25  Tom Tromey  <tom@tromey.com>
1052
1053         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1054         parameter.  Return the new window.
1055         (show_source_disasm_command): Update and remove NULL check.
1056         (show_source_or_disasm_and_command): Update.
1057
1058 2019-06-25  Tom Tromey  <tom@tromey.com>
1059
1060         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1061
1062 2019-06-25  Tom Tromey  <tom@tromey.com>
1063
1064         * tui/tui-data.h (struct tui_win_info): Make constructor
1065         protected.  Make destructor virtual.  Add initializers.
1066         (tui_source_window, tui_data_window, tui_cmd_window): New
1067         classes.
1068         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1069         constructor.  Add "type" parameter.
1070         (tui_source_window, tui_data_window, tui_cmd_window): New
1071         constructors.
1072         (tui_alloc_win_info): Instantiate the appropriate subclass.
1073
1074 2019-06-25  Tom Tromey  <tom@tromey.com>
1075
1076         * tui/tui-win.c (tui_resize_all): Use delete.
1077         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1078         destructor.
1079         (tui_free_window): Don't declare.
1080         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1081         Update.
1082
1083 2019-06-25  Tom Tromey  <tom@tromey.com>
1084
1085         * tui/tui-data.h (struct tui_win_info): Add constructor.
1086         * tui/tui-data.c (tui_alloc_win_info): Use new.
1087         (tui_free_window): Use delete.
1088
1089 2019-06-22  Tom Tromey  <tom@tromey.com>
1090
1091         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1092         declare.
1093         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1094
1095 2019-06-22  Tom Tromey  <tom@tromey.com>
1096
1097         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1098         declare.
1099         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1100
1101 2019-06-22  Tom de Vries  <tdevries@suse.de>
1102
1103         * dwarf2read.c (create_addrmap_from_aranges)
1104         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1105         instead of '%zu'.
1106
1107 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1108
1109         * dwarf2read.h (dwarf2_section_info_def): Remove.
1110         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1111         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1112         std::vector<dwarf2_section_info>.
1113         (struct dwo_file) <~dwo_file>: Remove.
1114         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1115         types field.
1116         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1117         (dwarf2_read_debug_names): Likewise.
1118         (create_debug_types_hash_table): Change parameter type to
1119         array_view, adjust code accordingly.
1120         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1121         (partial_die_info::fixup): Likewise.
1122         (determine_prefix): Likewise.
1123         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1124
1125 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1126
1127         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1128         gdb_bfd_ref_ptr.
1129         <~dwo_file>: Remove call to gdb_bfd_unref.
1130         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1131         gdb_bfd_ref_ptr::get.
1132
1133 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1134
1135         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1136         type to htab_up.
1137         * dwarf2read.c (struct dwo_file): Initialize fields.
1138         <~dwo_file>: New.
1139         (free_dwo_file): Remove, move content to ~dwo_file.
1140         (struct dwo_file_deleter): Remove.
1141         (dwo_file_up>: Remove custom deleter.
1142         (free_dwo_files): Remove.
1143         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1144         dwo_files.
1145         (process_skeletonless_type_units): Call unique_ptr::get.
1146         (allocate_dwo_file_hash_table): Add deleter to created hash
1147         table.  Change return type to htab_up.
1148         (lookup_dwo_file_slot): Don't memset dwo_file, call
1149         unique_ptr::get.
1150         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1151         (create_dwo_unit_in_dwp_v2): Likewise.
1152         (open_and_init_dwo_file): Likewise.
1153         (free_dwo_file_from_slot): Remove.
1154
1155 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1156
1157         * dwarf2read.h (struct dwarf2_section_info) <readin,
1158         is_virtual>: Change type to bool.
1159         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1160         true instead of 1.
1161
1162 2019-06-19  Tom Tromey  <tom@tromey.com>
1163
1164         * tui/tui-data.h (tui_init_content_element): Don't declare.
1165
1166 2019-06-19  Tom Tromey  <tom@tromey.com>
1167
1168         * tui/tui-data.h (tui_init_win_info): Don't declare.
1169
1170 2019-06-19  Tom de Vries  <tdevries@suse.de>
1171
1172         * dwarf2read.h (abstract_to_concrete): Change type to
1173         std::unordered_map<sect_offset, std::vector<sect_offset>,
1174         gdb::hash_enum<sect_offset>>.
1175
1176 2019-06-19  Tom Tromey  <tromey@adacore.com>
1177
1178         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1179         EVAL_AVOID_SIDE_EFFECTS specially.
1180
1181 2019-06-19  Tom Tromey  <tromey@adacore.com>
1182
1183         * source-cache.c (highlighter): New global.
1184         (source_cache::get_source_lines): Create a highlighter on demand.
1185
1186 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1187
1188         * defs.h (deprecated_interactive_hook): Delete declaration.
1189         * interps.c (clear_interpreter_hooks): Remove use of
1190         deprecated_interactive_hook.
1191         * top.c (deprecated_interactive_hook): Delete definition.
1192         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1193
1194 2019-06-18  Tom de Vries  <tdevries@suse.de>
1195
1196         PR gdb/24515
1197         * dwarf2read.h (abstract_to_concrete): Change type from
1198         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1199         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1200         * dwarf2read.c (read_variable): Update.
1201         (dwarf2_fetch_die_loc_sect_off): Update.
1202
1203 2019-06-17  Tom de Vries  <tdevries@suse.de>
1204
1205         PR gdb/24617
1206         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1207         accessing parent[parent_len - 1].
1208
1209 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1210
1211         PR gdb/24364
1212         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1213         call dtrace_process_dof with NULL dof.
1214
1215 2019-06-16  Tom de Vries  <tdevries@suse.de>
1216
1217         PR gdb/24445
1218         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1219
1220 2019-06-16  Tom Tromey  <tom@tromey.com>
1221
1222         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1223         (make_all_visible): Use address of member.
1224
1225 2019-06-16  Tom Tromey  <tom@tromey.com>
1226
1227         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1228         (tui_free_window, free_content, free_content_elements): Remove
1229         unnecessary cast.
1230         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1231         cast.
1232         * tui/tui-regs.c (tui_show_register_group)
1233         (tui_display_registers_from, tui_display_reg_element_at_line):
1234         Remove unnecessary cast.
1235
1236 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1237
1238         * linux-nat.c (normal_mask): Delete.
1239         (_initialize_linux_nat): Don't initialise normal_mask.
1240
1241 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1242
1243         PR gdb/24445
1244         * dwarf-index-write.h (write_psymtabs_to_index): Add
1245         dwz_basename parameter.
1246         * dwarf-index-write.c (write_gdbindex): Move file writing to
1247         write_gdbindex_1.  Change return type void.
1248         (assert_file_size): Move up, remove filename parameter.
1249         (write_gdbindex_1): New function.
1250         (write_debug_names): Change return type to void, call
1251         assert_file_size.
1252         (struct index_wip_file): New struct.
1253         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1254         file logic to index_wip_file.  Write index for dwz file if
1255         needed.
1256         (save_gdb_index_command): Pass basename of dwz file, if present.
1257         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1258         build-id of dwz file, if present.
1259         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1260         (dwarf2_get_dwz_file): Likewise.
1261         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1262         (dwarf2_get_dwz_file): Likewise.
1263
1264 2019-06-16  Tom Tromey  <tom@tromey.com>
1265
1266         * coffread.c (process_coff_symbol): Use xstrdup.
1267         * value.c (create_internalvar): Use xstrdup.
1268
1269 2019-06-16  Tom Tromey  <tom@tromey.com>
1270
1271         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1272         * breakpoint.c (stopin_command, stopat_command)
1273         (until_break_command, decode_location_default): Remove unnecessary
1274         cast.
1275         * utils.c (subset_compare): Remove unnecessary cast.
1276         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1277         cast.
1278         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1279         cast.
1280         * infcmd.c (path_command): Remove unnecessary cast.
1281         * coffread.c (decode_type): Remove unnecessary cast.
1282         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1283         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1284         * tui/tui-stack.c (tui_show_locator_content)
1285         (tui_show_frame_info): Remove unnecessary cast.
1286         * tui/tui-win.c (tui_scroll_forward_command)
1287         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1288         (parse_scrolling_args): Remove unnecessary cast.
1289         * tui/tui-data.c (init_win_info, tui_del_window)
1290         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1291         (free_content_elements): Remove unnecessary cast.
1292         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1293         unnecessary cast.
1294         * tui/tui-source.c (tui_set_source_content)
1295         (tui_vertical_source_scroll): Remove unnecessary cast.
1296         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1297         cast.
1298         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1299         * tui/tui-regs.c (tui_display_registers_from)
1300         (tui_display_register): Remove unnecessary cast.
1301         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1302         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1303         (make_visible): Remove unnecessary cast.
1304         * tui/tui-winsource.c (tui_erase_source_content)
1305         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1306         unnecessary cast.
1307         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1308         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1309         * stabsread.c (read_type, read_array_type, read_range_type):
1310         Remove unnecessary cast.
1311         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1312         (parse_symbol, parse_type, upgrade_type, parse_external)
1313         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1314         unnecessary cast.
1315         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1316
1317 2019-06-16  Tom Tromey  <tom@tromey.com>
1318
1319         * tui/tui-data.c (tui_alloc_generic_win_info)
1320         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1321         checks.
1322
1323 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1324             Andrew Burgess  <andrew.burgess@embecosm.com>
1325
1326         * f-typeprint.c (f_print_type): Don't return early for not
1327         associated or not allocated types.
1328         (f_type_print_varspec_suffix): Add print_rank parameter and print
1329         ranks of array types in case they dangling.
1330         (f_type_print_base): Add print_rank parameter.
1331
1332 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1333
1334         * NEWS: Mention new MI commands.
1335         * break-catch-throw.c (enum exception_event_kind): Move to
1336         breakpoint.h.
1337         (print_mention_exception_catchpoint): Output text as a single
1338         message.
1339         (catch_exception_command_1): Rename to...
1340         (catch_exception_event): ...this, make non-static, update header
1341         command, and change some parameter types.
1342         (catch_catch_command): Update for changes to
1343         catch_exception_command_1.
1344         (catch_throw_command): Likewise.
1345         (catch_rethrow_command): Likewise.
1346         * breakpoint.c (enum exception_event_kind): Delete.
1347         * breakpoint.h (enum exception_event_kind): Moved here from
1348         break-catch-throw.c.
1349         (catch_exception_event): Declare.
1350         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1351         (mi_cmd_catch_throw): New function.
1352         (mi_cmd_catch_rethrow): New function.
1353         (mi_cmd_catch_catch): New function.
1354         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1355         'catch-catch' entries.
1356         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1357         (mi_cmd_catch_rethrow): Declare.
1358         (mi_cmd_catch_catch): Declare.
1359
1360 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1361
1362         * annotate.c (annotate_source_line): Change return type to void,
1363         update implementation to match.
1364         * annotate.h (annotate_source_line): Change return type to void,
1365         update header comment.
1366         * stack.c (print_frame_info): Don't change what frame information
1367         is printed based on whether annotations are on or not.
1368
1369 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1370
1371         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1372         (annotate_source): Make static.
1373         (annotate_source_line): Moved from source.c and renamed from
1374         identify_source_line.  Update the return type.
1375         * annotate.h (annotate_source): Delete declaration.
1376         (annotate_source_line): Declaration moved from source.h, and
1377         renamed from identify_source_line.  Return type updated.
1378         * source.c (identify_source_line): Moved to annotate.c and renamed
1379         to annotate_source_line.
1380         (info_line_command): Remove check of annotation_level.
1381         * source.h (identify_source_line): Move declaration to annotate.h
1382         and rename to annotate_source_line.
1383         * stack.c: Add 'annotate.h' include.
1384         (print_frame_info): Remove check of annotation_level before
1385         calling annotate_source_line.
1386
1387 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1388
1389         * source-cache.c (source_cache::get_plain_source_lines): Use
1390         open_source_file_with_line_charpos instead of just
1391         open_source_file, remove call to find_source_lines.
1392         (source_cache::get_source_lines): Likewise.
1393         * source.c (find_source_lines): Make static.
1394         (get_filename_and_charpos): Renamed into...
1395         (open_source_file_with_line_charpos): ..this along with changes to
1396         return a scoped_fd, and some other minor clean ups.
1397         (identify_source_line): Use open_source_file_with_line_charpos.
1398         (search_command_helper): Use open_source_file_with_line_charpos
1399         instead of just open_source_file, remove call to
1400         find_source_lines.
1401         * source.h (open_source_file_with_line_charpos): Declare new
1402         function.
1403         (find_source_lines): Delete declaration.
1404
1405 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1406
1407         * source.c (get_filename_and_charpos): Remove fullname
1408         parameter.
1409         (identify_source_line): Update call to get_filename_and_charpos.
1410
1411 2019-06-14  Tom Tromey  <tromey@adacore.com>
1412
1413         PR gdb/24502:
1414         * ui-style.h (skip_ansi_escape): Update comment.
1415         * ui-file.h (class no_terminal_escape_file): New class.
1416         * ui-file.c (no_terminal_escape_file::write)
1417         (no_terminal_escape_file::puts): New methods.
1418         * cli/cli-logging.c (handle_redirections): Use
1419         no_terminal_escape_file.
1420
1421 2019-06-14  Tom Tromey  <tromey@adacore.com>
1422
1423         * NEWS: Move convenience variable news above Python news.
1424
1425 2019-06-14  Tom Tromey  <tom@tromey.com>
1426
1427         * gnulib: Move directory to top-level.
1428         * configure.ac: Don't configure gnulib.
1429         * configure: Rebuild.
1430         * common/common-defs.h: Use new path to gnulib.
1431         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1432         (GNULIB_H): Remove.
1433         (INCGNU): Look in new gnulib location.
1434         (HFILES_NO_SRCDIR): Remove gnulib files.
1435         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1436         (generated_files): Remove GNULIB_H.
1437         ($(LIBGNU), all-lib): Remove targets.
1438         (distclean): Don't mention GNULIB_BUILDDIR.
1439         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1440
1441 2019-06-14  Tom Tromey  <tromey@adacore.com>
1442
1443         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1444         Warn if symbol file does not provide any symbols.
1445
1446 2019-06-14  Tom Tromey  <tromey@adacore.com>
1447
1448         * source.c (find_and_open_source): Respect basenames_may_differ.
1449
1450 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1451
1452         * annotate.c (annotate_breakpoints_invalid): Make use of
1453         scoped_restore_terminal_state.
1454         (annotate_frames_invalid): Likewise.
1455
1456 2019-06-14  Tom Tromey  <tromey@adacore.com>
1457
1458         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1459         allow assignment to an internalvar.
1460
1461 2019-06-14  Tom Tromey  <tromey@adacore.com>
1462
1463         * ada-lex.l: Allow "_" in attribute names.
1464
1465 2019-06-14  Tom Tromey  <tromey@adacore.com>
1466
1467         PR gdb/24653:
1468         * regcache.c (registers_changed): Don't call alloca.
1469         * top.c (execute_command): Don't call alloca.
1470
1471 2019-06-13  Pedro Alves  <palves@redhat.com>
1472
1473         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1474         'expression'.  When parsing an expression, error out if there's
1475         junk after "unlimited".
1476         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1477         (do_set_command): Adjust calls to is_unlimited_literal.
1478
1479 2019-06-13  Pedro Alves  <palves@redhat.com>
1480
1481         * compile/compile.c (make_compile_options_def_group): Add braces
1482         around array_view initializer.
1483         * thread.c (make_thread_apply_all_options_def_group)
1484         (make_thread_apply_all_options_def_group): Likewise.
1485
1486 2019-06-13  Pedro Alves  <palves@redhat.com>
1487
1488         * NEWS (New commands): Mention "maint test-options
1489         require-delimiter", "maint test-options unknown-is-error", "maint
1490         test-options unknown-is-operand" and "maint show
1491         test-options-completion-result".
1492         (New command options, command completion): New section.
1493         (Completion improvements): New section.
1494         Mention that you can abbreviate "unlimited".
1495
1496 2019-06-13  Pedro Alves  <palves@redhat.com>
1497
1498         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1499         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1500         * unittests/cli-utils-selftests.c (test_parse_flags)
1501         (test_parse_flags_qcs): Delete.
1502         (test_cli_utils): Don't call deleted functions.
1503
1504 2019-06-13  Pedro Alves  <palves@redhat.com>
1505
1506         * thread.c: Include "cli/cli-option.h".
1507         (tp_array_compar_ascending): Global.
1508         (tp_array_compar): Delete function.
1509         (tp_array_compar_ascending, tp_array_compar_descending): New
1510         functions.
1511         (ascending_option_def, qcs_flag_option_def)
1512         (thr_qcs_flags_option_defs)
1513         (make_thread_apply_all_options_def_group)
1514         (make_thread_apply_options_def_group): New.
1515         (thread_apply_all_command): Use gdb::option::process_options.
1516         (thread_apply_command_completer)
1517         (thread_apply_all_command_completer): New.
1518         (thread_apply_command): Use gdb::option::process_options.
1519         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1520         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1521         to generate help text of "thread apply".  Adjust "taas"'s help.
1522         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1523         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1524
1525 2019-06-13  Pedro Alves  <palves@redhat.com>
1526
1527         * thread.c (thread_apply_command): Check for invalid TID with
1528         isdigit instead of !isalpha.
1529
1530 2019-06-13  Pedro Alves  <palves@redhat.com>
1531
1532         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1533         (validate_flags_qcs): New.
1534         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1535         (validate_flags_qcs): Declare.
1536         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1537         (make_frame_apply_options_def_group): New.
1538         (frame_apply_command_count): Process options with
1539         gdb::option::process_options.
1540         (frame_apply_completer): New.
1541         (frame_apply_level_completer, frame_apply_all_completer)
1542         (frame_apply_completer): New.
1543         (_initialize_stack): Update help of "frame apply", "frame apply
1544         level", "frame apply all" and "faas" to mention supported options
1545         and install command completers.
1546         * stack.h (frame_apply_all_completer): Declare.
1547         * thread.c: Include "stack.h".
1548         (tfaas_command): Add "--".
1549         (_initialize_thread): Update help "tfaas" to mention supported
1550         options and install command completer.
1551
1552 2019-06-13  Pedro Alves  <palves@redhat.com>
1553
1554         * completer.c (complete_nested_command_line): New.
1555         (gdb_completion_word_break_characters_throw): Add assertion.
1556         * completer.h (complete_nested_command_line): Declare.
1557
1558 2019-06-13  Pedro Alves  <palves@redhat.com>
1559
1560         * stack.c (parse_backtrace_qualifiers): New.
1561         (backtrace_command): Use it.
1562         (backtrace_command_completer): Complete on qualifiers.
1563
1564 2019-06-13  Pedro Alves  <palves@redhat.com>
1565
1566         * frame.c: Include "cli/cli-option.h.
1567         (user_set_backtrace_options): New.
1568         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1569         Delete.
1570         (get_prev_frame): Adjust.
1571         (boolean_option_def, uinteger_option_def)
1572         (set_backtrace_option_defs): New.
1573         (_initialize_frame): Adjust and use
1574         gdb::option::add_setshow_cmds_for_options to install "set
1575         backtrace past-main" and "set backtrace past-entry".
1576         * frame.h: Include "cli/cli-option.h".
1577         (struct frame_print_options): Forward declare.
1578         (print_frame_arguments_all, print_frame_arguments_scalars)
1579         (print_frame_arguments_none): Declare.
1580         (print_entry_values): Delete declaration.
1581         (struct frame_print_options, user_frame_print_options): New.
1582         (struct set_backtrace_options): New.
1583         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1584         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1585         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1586         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1587         (list_args_or_locals): Add frame_print_options parameter.
1588         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1589         * python/py-framefilter.c (enumerate_args): Pass down
1590         USER_FRAME_PRINT_OPTIONS.
1591         * stack.c: Include "cli/cli-option.h".
1592         (print_frame_arguments_all, print_frame_arguments_scalars)
1593         (print_frame_arguments_none): Declare.
1594         (print_raw_frame_arguments, print_entry_values): Delete.
1595         (user_frame_print_options): New.
1596         (boolean_option_def, enum_option_def, frame_print_option_defs):
1597         New.
1598         (struct backtrace_cmd_options): New.
1599         (bt_flag_option_def): New.
1600         (backtrace_command_option_defs): New.
1601         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1602         (print_frame_arg, read_frame_arg, print_frame_args)
1603         (print_frame_info, print_frame): Add frame_print_options parameter
1604         and use it.
1605         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1606         (backtrace_command_1): Add frame_print_options and
1607         backtrace_cmd_options parameters and use them.
1608         (make_backtrace_options_def_group): New.
1609         (backtrace_command): Process command options with
1610         gdb::option::process_options.
1611         (backtrace_command_completer): New.
1612         (_initialize_stack): Extend "backtrace"'s help to mention
1613         supported options.  Install completer for "backtrace".
1614         Install some settings commands with add_setshow_cmds_for_options.
1615
1616 2019-06-13  Pedro Alves  <palves@redhat.com>
1617
1618         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1619         and that "set/show print raw frame-arguments" are now deprecated.
1620
1621         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1622         command.
1623         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1624         * stack.c (_initialize_stack): Install "set/show print
1625         raw-frame-arguments", and deprecate "set/show print raw
1626         frame-arguments".
1627         * valprint.c (_initialize_valprint): Deprecate "set/show print
1628         raw".
1629
1630 2019-06-13  Pedro Alves  <palves@redhat.com>
1631
1632         * compile/compile.c (struct compile_options): New.
1633         (compile_flag_option_def, compile_command_option_defs)
1634         (make_compile_options_def_group): New.
1635         (compile_file_command): Handle options with
1636         gdb::option::process_options.
1637         (compile_file_command_completer): New function.
1638         (compile_code_command): Handle options with
1639         gdb::option::process_options.
1640         (compile_code_command_completer): New function.
1641         (_initialize_compiler): Install completers for "compile code" and
1642         "compile file".  Mention available options in "compile code" and
1643         "compile code"'s help.
1644         * completer.c (advance_to_completion_word): New, factored out from
1645         ...
1646         (advance_to_expression_complete_word_point): ... this.
1647         (advance_to_filename_complete_word_point): New.
1648         * completer.h (advance_to_filename_complete_word_point): New
1649         declaration.
1650
1651 2019-06-13  Pedro Alves  <palves@redhat.com>
1652
1653         * compile/compile.c: Include "cli/cli-option.h".
1654         (compile_print_value): Scope data pointer is now a
1655         value_print_options pointer; adjust.
1656         (compile_print_command): Process options.  Scope data pointer is
1657         now a value_print_options pointer; adjust.
1658         (_initialize_compile): Update "compile print"'s help to include
1659         supported options.  Install a completer for "compile print".
1660         * cp-valprint.c (show_vtblprint, show_objectprint)
1661         (show_static_field_print): Delete.
1662         (_initialize_cp_valprint): Don't install "set print
1663         static-members", "set print vtbl", "set print object" here.
1664         * printcmd.c: Include "cli/cli-option.h" and
1665         "common/gdb_optional.h".
1666         (print_command_parse_format): Rework to fill in a
1667         value_print_options instead of a format_data.
1668         (print_value): Change parameter type from format_data pointer to
1669         value_print_options reference.  Adjust.
1670         (print_command_1): Process options.  Adjust to pass down a
1671         value_print_options.
1672         (print_command_completer): New.
1673         (_initialize_printcmd): Install print_command_completer as
1674         handle_brkchars completer for the "print" command.  Update
1675         "print"'s help to include supported options.
1676         * valprint.c: Include "cli/cli-option.h".
1677         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1678         here from cp-valprint.c.
1679         (boolean_option_def, uinteger_option_def)
1680         (value_print_option_defs, make_value_print_options_def_group):
1681         New.  Use gdb::option::add_setshow_cmds_for_options to install
1682         "set print elements", "set print null-stop", "set print repeats",
1683         "set print pretty", "set print union", "set print array", "set
1684         print address", "set print symbol", "set print array-indexes".
1685         * valprint.h: Include <string> and "cli/cli-option.h".
1686         (make_value_print_options_def_group): Declare.
1687         (print_value): Change parameter type from format_data pointer to
1688         value_print_options reference.
1689         (print_command_completer): Declare.
1690
1691 2019-06-13  Pedro Alves  <palves@redhat.com>
1692
1693         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1694         (COMMON_SFILES): Add maint-test-settings.c.
1695         * cli/cli-decode.c (boolean_enums): New global, factored out from
1696         ...
1697         (add_setshow_boolean_cmd): ... here.
1698         * cli/cli-decode.h (boolean_enums): Declare.
1699         * cli/cli-option.c: New file.
1700         * cli/cli-option.h: New file.
1701         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1702         factored out from ...
1703         (parse_cli_boolean_value(const char *)): ... this.
1704         (is_unlimited_literal): Change parameter type to pointer to
1705         pointer.  Adjust and advance ARG pointer.
1706         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1707         (parse_cli_var_enum): New, factored out from ...
1708         (do_set_command): ... this.  Adjust.
1709         * cli/cli-setshow.h (parse_cli_boolean_value)
1710         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1711         (parse_cli_var_enum): Declare.
1712         * cli/cli-utils.c: Include "cli/cli-option.h".
1713         (get_ulongest): New.
1714         * cli/cli-utils.h (get_ulongest): Declare.
1715         (check_for_argument): New overloads.
1716         * maint-test-options.c: New file.
1717
1718 2019-06-13  Pedro Alves  <palves@redhat.com>
1719
1720         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1721         parse a range if "-" is at the end of the string.
1722
1723 2019-06-13  Pedro Alves  <palves@redhat.com>
1724
1725         * cli/cli-setshow.c (parse_auto_binary_operation)
1726         (parse_cli_boolean_value): Don't allow "o".
1727
1728 2019-06-13  Pedro Alves  <palves@redhat.com>
1729
1730         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1731         * NEWS: Mention maint test-settings KIND.
1732         * maint-test-settings.c: New file.
1733
1734 2019-06-13  Pedro Alves  <palves@redhat.com>
1735
1736         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1737         completer.
1738         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1739         "set" completers.
1740
1741 2019-06-13  Pedro Alves  <palves@redhat.com>
1742
1743         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1744         after item.
1745
1746 2019-06-13  Pedro Alves  <palves@redhat.com>
1747
1748         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1749
1750 2019-06-13  Pedro Alves <palves@redhat.com>
1751
1752         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1753         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1754         call.
1755         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1756         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1757         calls.
1758         (check_for_argument): Skip spaces after argument.
1759
1760 2019-06-13  Pedro Alves  <palves@redhat.com>
1761
1762         * thread.c (thread_apply_command): Adjust TID parsing.
1763         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1764         detected before end of string.
1765         (tid_is_in_list): Error out if LIST is invalid.
1766
1767 2019-06-13  Pedro Alves  <palves@redhat.com>
1768
1769         * completer.c (complete_line_internal_1): Rewind completion word
1770         point.
1771         (completion_tracker::advance_custom_word_point_by): Change
1772         parameter type to int.
1773         * completer.h (completion_tracker::advance_custom_word_point_by):
1774         Likewise.
1775
1776 2019-06-13  Pedro Alves  <palves@redhat.com>
1777
1778         * completer.c (advance_to_completion_word): Handle delimiters.
1779
1780 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1781
1782         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1783
1784 2019-06-11  Tom Tromey  <tom@tromey.com>
1785
1786         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1787         (xmalloc_failed): Move to alloc.c.
1788         * alloc.c: New file.
1789         * Makefile.in (COMMON_SFILES): Add alloc.c.
1790
1791 2019-06-11  Tom Tromey  <tom@tromey.com>
1792
1793         * nat/linux-waitpid.c: Don't include server.h.
1794         (linux_debug): Remove.
1795         (my_waitpid): Update.
1796
1797 2019-06-11  Tom Tromey  <tromey@adacore.com>
1798
1799         * infcall.c (_initialize_infcall): Remove trailing newline from
1800         help.
1801         * user-regs.c (_initialize_user_regs): Remove trailing newline
1802         from help.
1803         * typeprint.c (_initialize_typeprint): Remove trailing newline
1804         from help.
1805         * reverse.c (_initialize_reverse): Remove trailing newlines from
1806         help.
1807         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1808         from help.
1809         * language.c (add_set_language_command): Remove trailing newline
1810         from help.
1811         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1812         help.
1813         * disasm.c (_initialize_disasm): Remove trailing newline from
1814         help.
1815         * top.c (init_main): Remove trailing newline from help.
1816         * interps.c (_initialize_interpreter): Remove trailing newline
1817         from help.
1818         * btrace.c (_initialize_btrace): Remove trailing newlines from
1819         help.
1820         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1821         from help.
1822         * python/python.c (_initialize_python): Remove trailing newline
1823         from help.
1824         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1825         help.
1826         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1827         from help.  Reformat some text.
1828         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1829         from help.
1830         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1831         newline from help.
1832
1833 2019-06-11  Tom Tromey  <tromey@adacore.com>
1834
1835         * darwin-nat.c (darwin_decode_exception_message)
1836         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1837
1838 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * valops.c (value_slice): Check for not allocated or not
1841         associated values.
1842
1843 2019-06-10  Tom de Vries  <tdevries@suse.de>
1844
1845         PR gdb/24618
1846         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1847         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1848         invalid.
1849
1850 2019-06-10  Tom de Vries  <tdevries@suse.de>
1851
1852         PR gdb/24611
1853         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1854         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1855
1856 2019-06-10  Tom de Vries  <tdevries@suse.de>
1857
1858         PR symtab/24545
1859         * symtab.c (struct demangled_name_entry): Add language field.
1860         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1861         static minimal symbol".  Set and use language field.
1862
1863 2019-06-10  Tom Tromey  <tromey@adacore.com>
1864
1865         * ada-lang.c (_initialize_ada_language): Update help text.
1866
1867 2019-06-10  Tom Tromey  <tromey@adacore.com>
1868
1869         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1870         with a newline.
1871         * guile/guile.c (handle_boot_error): Don't end warning with a
1872         newline.
1873         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1874         warning with a newline.
1875         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1876         newline.
1877         (s12z_frame_cache): Likewise.
1878         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1879         a newline.
1880         * solib-svr4.c (disable_probes_interface): Don't end warning with
1881         a newline.
1882         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1883         newline.
1884         * python/python.c (do_finish_initialization): Don't end warning
1885         with a newline.
1886
1887 2019-06-10  Tom Tromey  <tom@tromey.com>
1888
1889         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1890         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1891         gdbpy_enter.
1892
1893 2019-06-10  Tom Tromey  <tromey@adacore.com>
1894
1895         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1896         data.
1897         (elf_new_init): Don't call stabsread_new_init.
1898         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1899         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1900         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1901
1902 2019-06-10  Tom de Vries  <tdevries@suse.de>
1903
1904         PR symtab/16264
1905         PR symtab/24517
1906         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1907
1908 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1909
1910         * source.c (find_and_open_source): Also rewrite relative file
1911         names.
1912
1913 2019-04-26  Amos Bird  <amosbird@gmail.com>
1914
1915         * annotate.c (annotate_thread_exited): Add "thread-exited"
1916         annotation.
1917
1918 2019-06-06  Tom Tromey  <tromey@adacore.com>
1919
1920         * maint.h (class scoped_command_stats): Use
1921         DISABLE_COPY_AND_ASSIGN.
1922         <print_time>: New method.
1923         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1924         print_time.
1925         (scoped_command_stats::print_time): New method.
1926
1927 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1928
1929         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1930         instructions of lengths 6 or 8 bytes.
1931
1932 2019-06-04  Pedro Alves  <palves@redhat.com>
1933
1934         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1935
1936         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1937         * breakpoint.c (condition_completer): Likewise.
1938         * cli/cli-dump.c (scan_expression): Likewise.
1939         * common/filestuff.c (mkdir_recursive): Likewise.
1940         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1941         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1942         (gdb_abspath): Likewise.
1943         * compile/compile-cplus-types.c
1944         (compile_cplus_instance::decl_name): Likewise.
1945         * completer.c (complete_explicit_location):
1946         (signal_completer, reg_or_group_completer_1): Likewise.
1947         * cp-support.c (cp_remove_params_if_any): Likewise.
1948         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1949         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1950         * infcmd.c (strip_bg_char): Likewise.
1951         * linespec.c (copy_token_string): Likewise.
1952         * mi/mi-main.c (output_cores): Likewise.
1953         * psymtab.c (psymtab_search_name):
1954         * symfile.c (test_set_ext_lang_command): Likewise.
1955         * target.c (target_fileio_read_stralloc): Likewise.
1956         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1957         * value.c (complete_internalvar): Likewise.
1958
1959 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1960
1961         Add objfile property to gdb.Type.
1962         * NEWS: Mention Python API addition.
1963         * python/py-type.c (typy_get_objfile): New method.
1964
1965 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1966
1967         * NEWS: Mention the new set|show style [title|highlight].
1968         Mention changes to "show style", "help" and "apropos".
1969
1970 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1971
1972         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1973         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1974         instead of print_help_for_command.
1975         (print_doc_of_command): New function.
1976         (help_list): Add 'apropos -v word' suggestion.
1977         (print_help_for_command): Style the command name using title style.
1978         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1979         (_initialize_cli_cmds): Describe -v in apropos_command help.
1980
1981 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1982
1983         * cli/cli-style.h (cli_style_option): Add name in constructor,
1984         add m_name class member, add constructor with intensity,
1985         add name class function.
1986         (cli_style_option::add_setshow_commands): Remove name argument.
1987         (highlight_style, title_style): New styles.
1988         * cli/cli-style.c (do_show): New function that shows a style
1989         characteristic styling the style name with itself.
1990         (set_style_name): New function.
1991         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1992         Update all callers according to the changes in cli/cli-style.h.
1993         * utils.h (fputs_highlighted): New function.
1994         * utils.c (fputs_highlighted): Likewise.
1995
1996 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1997
1998         * NEWS: Mention new pipe command and new convenience variables.
1999
2000 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2001
2002         * cli/cli-cmds.c (pipe_command): New function.
2003         (_initialize_cli_cmds): Call add_com for pipe_command.
2004         Define | as an alias for pipe.
2005         (exit_status_set_internal_vars): New function.
2006         (shell_escape): Call exit_status_set_internal_vars.
2007         cli/cli-decode.c (find_command_name_length): Recognize | as
2008         a single character command.
2009
2010 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2011
2012         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2013         top.c (execute_command_to_ui_file): New function, mostly a copy
2014         of execute_command_to_string.
2015         (execute_command_to_string): Implement by calling
2016         execute_command_to_ui_file.
2017
2018 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2019
2020         * top.h (saved_command_line): Remove declaration.
2021         * top.c (previous_saved_command_line, previous_repeat_arguments):
2022         New variables.
2023         (saved_command_line): Make static, define together with other
2024         'repeat variables'.
2025         (dont_repeat): Clear repeat_arguments.
2026         (repeat_previous, get_saved_command_line, save_command_line):
2027         New functions.
2028         (gdb_init): Initialize saved_command_line
2029         and previous_saved_command_line.
2030         * main.c (captured_main_1): Remove saved_command_line initialization.
2031         * event-top.c (handle_line_of_input): Update to use
2032         the new 'repeat' related functions instead of direct access to
2033         saved_command_line.
2034         * command.h (repeat_previous, get_saved_command_line,
2035         save_command_line): New declarations.
2036         (dont_repeat): Add comment.
2037
2038 2019-05-30  Tom Tromey  <tromey@adacore.com>
2039
2040         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2041         Fix comment.
2042         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2043
2044 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2045
2046         PR cli/24587
2047         * completer.c (complete): Initialize variable word.
2048
2049 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2050
2051         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2052         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2053         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2054         'body' is NULL to the outter 'if', protecting the '!is_define'
2055         situation as well.
2056
2057 2019-05-29  Tom Tromey  <tromey@adacore.com>
2058
2059         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2060         (dwarf_unknown): New function.
2061         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2062         (dwarf_type_encoding_name): Use dwarf_unknown.
2063
2064 2019-05-29  Tom Tromey  <tromey@adacore.com>
2065
2066         PR c++/20020:
2067         * cp-valprint.c (cp_print_value_fields): Call
2068         cp_print_static_field inside "try".
2069
2070 2019-05-29  Tom Tromey  <tromey@adacore.com>
2071
2072         * inflow.c (struct terminal_info): Add default operator=.
2073         * configure: Rebuild.
2074         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2075         -Wdeprecated-copy-dtor, -Wredundant-move.
2076
2077 2019-05-29  Tom Tromey  <tromey@adacore.com>
2078
2079         * NEWS: Add entry.
2080         * infcmd.c (print_return_value_1): Handle finish_print
2081         option.
2082         (show_print_finish): New function.
2083         (_initialize_infcmd): Add "set/show print finish" commands.
2084         * valprint.c (user_print_options): Initialize new member.
2085         * valprint.h (struct value_print_options) <finish_print>: New
2086         member.
2087
2088 2019-05-28  Tom Tromey  <tromey@adacore.com>
2089
2090         * ada-lang.c (ada_remove_Xbn_suffix)
2091         (find_old_style_renaming_symbol)
2092         (parse_old_style_renaming): Remove.
2093         (ada_find_renaming_symbol): Don't call
2094         find_old_style_renaming_symbol.
2095         (ada_is_renaming_symbol): Rename from
2096         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2097         bool.  Now static.
2098         (ada_read_var_value): Update and simplify.
2099         * ada-exp.y (write_var_or_type): Remove old code.
2100
2101 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2102
2103         * event-top.c: Remove include comment.
2104         * inflow.c (class scoped_ignore_sigttou): Move from here...
2105         * inflow.h (class scoped_ignore_sigttou): ...to here.
2106         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2107         * top.c:  Remove include comment.
2108
2109 2019-05-27  Tom Tromey  <tom@tromey.com>
2110
2111         * NEWS: Fix typo.
2112
2113 2019-05-22  Tom Tromey  <tromey@adacore.com>
2114
2115         * target.c (target_follow_exec): Constify parameter.
2116         * target-delegates.c: Rebuild.
2117         * remote.c (remote_target::follow_exec): Constify parameter.
2118         * infrun.c (follow_exec): Constify parameter.
2119         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2120         (target_follow_exec): Likewise.
2121
2122 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2123
2124         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2125         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2126
2127 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2128
2129         * NEWS: Add debugredirect and testsuite sections.
2130
2131 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2132
2133         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2134         target descriptions using exclusively floating point register name
2135         aliases.
2136
2137 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2138
2139         PR gdb/18644:
2140         * f-lang.c (build_fortran_types): Handle the case where
2141         gdbarch_floatformat_for_type returns a nullptr.
2142
2143 2019-05-21  Tom de Vries  <tdevries@suse.de>
2144
2145         PR cli/24587
2146         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2147
2148 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2149
2150         PR gdb/18644:
2151         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2152         16-byte floats.
2153         * i386-tdep.c (i386_floatformat_for_type): Use
2154         floatformats_ia64_quad for the 16-byte floating point component
2155         within a fortran 32-byte complex number.
2156
2157 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2160         delete default constructor.
2161         (find_partial_die): Update to return const struct.
2162         (partial_die_parent_scope): Move variable declaration into scope
2163         of its use and change its type to auto.
2164         (guess_partial_die_structure_name): Likewise.
2165         (partial_die_info::fixup): Likewise.
2166
2167 2019-05-17  Tom Tromey  <tromey@adacore.com>
2168
2169         * source.c (find_and_open_source): Remove cast.
2170
2171 2019-05-17  Tom Tromey  <tromey@adacore.com>
2172
2173         * annotate.c (annotate_source): Make "filename" const.
2174         * annotate.h (annotate_source): Use const.
2175
2176 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2177
2178         * disasm.c (set_disassembler_options): Send errors to stderr.
2179
2180 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2181
2182         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2183         (cli_interp_base::set_logging): Check debug_redirect.
2184         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2185         * cli/cli-logging.c (debug_redirect): Add static variable.
2186         (pop_output_files): Add default param.
2187         (handle_redirections): Print debug setting.
2188         (show_logging_command): Likewise.
2189         (_initialize_cli_logging): Add debugredirect command.
2190         * interps.c (current_interp_set_logging): Add debug_redirect
2191         parameter.
2192         * interps.h (set_logging): Add debug_redirect parameter.
2193         (current_interp_set_logging): Likewise.
2194         * mi/mi-common.h: Likewise.
2195         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2196
2197 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2198             Tom Tromey  <tromey@adacore.com>
2199
2200         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2201         directly.
2202         * cli/cli-interp.h (make_logging_output): Remove declaration.
2203         * cli/cli-logging.c (make_logging_output): Remove function.
2204         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2205         directly.
2206         * ui-file.c (tee_file::tee_file): Remove bools.
2207         (tee_file::~tee_file): Remove deletes.
2208         * ui-file.h (tee_file): Remove bools.
2209
2210 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2211
2212         * mi/mi-cmds.h (mi_cmd_complete): New function.
2213         * mi/mi-main.c (mi_cmd_complete): Likewise.
2214         * mi/mi-cmds.c: Define new MI command -complete.
2215         * NEWS: Mention new -complete command.
2216
2217 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2218
2219         * completer.h (complete): New function.
2220         * completer.c (complete): Likewise.
2221         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2222         function defined in completer.h.
2223
2224 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2225
2226         * MAINTAINERS (Write After Approval): Add myself.
2227
2228 2019-05-17  Tom de Vries  <tdevries@suse.de>
2229
2230         PR gdb/24094
2231         * dwarf2read.c (struct cu_partial_die_info): New struct.
2232         (find_partial_die): Return cu_partial_die_info.
2233         (partial_die_parent_scope, guess_partial_die_structure_name)
2234         (partial_die_info::fixup): Handle new return type of find_partial_die.
2235
2236 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2237
2238         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2239         "std::string", simplifying the algorithm.
2240
2241 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2242
2243         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2244         (stap_static_probe_ops::get_probes): Likewise.
2245
2246 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2247
2248         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2249         '-')" and "else if".
2250         (stap_parse_single_operand): Join checks for
2251         "gdbarch_stap_parse_special_token_p" and
2252         "gdbarch_stap_parse_special_token" in the same "if" statement.
2253         Invert check when verifying for operation on register
2254         displacement.
2255
2256 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2257
2258         * stap-probe.c (stap_get_opcode): Update comment.
2259         (stap_get_expected_argument_type): Likewise.
2260         (handle_stap_probe): Likewise.
2261
2262 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2263
2264         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2265         return type to 'bool'.  Adjust comment.  Use 'bool' when
2266         appropriate.
2267         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2268         * stap-probe.c (stap_parse_argument_1): Likewise.
2269         (stap_is_operator): Likewise.
2270         (stap_is_generic_prefix): Likewise.
2271         (stap_is_register_prefix): Likewise.
2272         (stap_is_register_indirection_prefix): Likewise.
2273         (stap_is_integer_prefix): Likewise.
2274         (stap_generic_check_suffix): Likewise.
2275         (stap_check_integer_suffix): Likewise.
2276         (stap_check_register_suffix): Likewise.
2277         (stap_check_register_indirection_suffix): Likewise.
2278         (stap_parse_register_operand): Likewise.
2279         (stap_parse_single_operand): Likewise.
2280         (stap_parse_argument_1): Likewise.
2281         (stap_probe::get_argument_count): Likewise.
2282         (stap_is_operator): Likewise.
2283
2284 2019-05-16  Tom Tromey  <tromey@adacore.com>
2285
2286         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2287         keyword to foreach.
2288
2289 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2290
2291         * linux-thread-db.c (try_thread_db_load_1): Change return type
2292         to bool.
2293         (try_thread_db_load): Likewise.
2294         (try_thread_db_load_from_pdir_1): Likewise.
2295         (try_thread_db_load_from_pdir): Likewise.
2296         (try_thread_db_load_from_sdir): Likewise.
2297         (try_thread_db_load_from_dir): Likewise.
2298         (thread_db_load_search): Likewise.
2299         (has_libpthread): Likewise.
2300         (thread_db_load): Likewise.
2301
2302 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2303
2304         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2305         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2306         NULL, and complain/return if that's the case.
2307
2308 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2309
2310         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2311         (advance, posn, abstract_read_memory): New functions.
2312         [struct mem_read_abstraction]: New struct.
2313         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2314
2315 2019-05-14  Tom Tromey  <tromey@adacore.com>
2316
2317         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2318         value is not lval_memory.
2319
2320 2019-05-14  Tom Tromey  <tromey@adacore.com>
2321
2322         * solib.c (info_sharedlibrary_command): Style the file name.
2323
2324 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2325
2326         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2327         (aarch64_vnv_type): Likewise.
2328         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2329         * common/tdesc.c: Likewise.
2330         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2331         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2332         * features/aarch64-fpu.xml: Add ieee half view.
2333         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2334         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2335         * gdbtypes.h (struct builtin_type): Likewise.
2336         (struct objfile_type): Likewise.
2337
2338 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2339
2340         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2341         typo.
2342         * location.h (string_to_event_location): Likewise.
2343
2344 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2345
2346         GDB 8.3 released.
2347
2348 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2349
2350         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2351         New variable declaration.
2352         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2353         New variable.
2354         (print_one_breakpoint): Use ui_out::test_flags and new global
2355         variable to compute use_fixed_output.
2356         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2357         Remove.
2358         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2359         (mi_multi_location_breakpoint_output_fixed): Remove.
2360         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2361         new variable.
2362         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2363         fix_multi_location_breakpoint_output flag if version >= 3.
2364         * ui-out.h (enum ui_out_flag)
2365         <fix_multi_location_breakpoint_output>: New enumerator.
2366
2367 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2368
2369         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2370
2371 2019-05-10  Tom Tromey  <tromey@adacore.com>
2372
2373         * ada-lang.c (catch_ada_completer): New function.
2374         (_initialize_ada_language): Use it.
2375
2376 2019-05-10  Tom Tromey  <tromey@adacore.com>
2377
2378         * thread.c (print_thread_info): Make "requested_threads" const.
2379         * gdbthread.h (print_thread_info): Make "requested_threads"
2380         const.
2381         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2382         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2383
2384 2019-05-08  Tom Tromey  <tom@tromey.com>
2385
2386         * gdbtypes.c (objfile_type_data): Change type.
2387         (objfile_type, _initialize_gdbtypes): Update.
2388
2389 2019-05-08  Tom Tromey  <tom@tromey.com>
2390
2391         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2392         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2393         (_initialize_dwarf2_frame): Update.
2394
2395 2019-05-08  Tom Tromey  <tom@tromey.com>
2396
2397         * objc-lang.c (objc_objfile_data): Change type.
2398         (find_methods): Update.
2399         (_initialize_objc_lang): Remove.
2400
2401 2019-05-08  Tom Tromey  <tom@tromey.com>
2402
2403         * stabsread.c (rs6000_builtin_type_data): Change type.
2404         (rs6000_builtin_type, _initialize_stabsread): Update.
2405
2406 2019-05-08  Tom Tromey  <tom@tromey.com>
2407
2408         * mips-tdep.c (mips_pdr_data): Remove.
2409         (_initialize_mips_tdep): Update.
2410
2411 2019-05-08  Tom Tromey  <tom@tromey.com>
2412
2413         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2414         (hppa_init_objfile_priv_data, read_unwind_info)
2415         (find_unwind_entry, _initialize_hppa_tdep): Update.
2416
2417 2019-05-08  Tom Tromey  <tom@tromey.com>
2418
2419         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2420         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2421         on obstack.
2422         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2423
2424 2019-05-08  Tom Tromey  <tom@tromey.com>
2425
2426         * mdebugread.c (basic_type_data): Change type.
2427         (basic_type, _initialize_mdebugread): Update.
2428
2429 2019-05-08  Tom Tromey  <tom@tromey.com>
2430
2431         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2432
2433 2019-05-08  Tom Tromey  <tom@tromey.com>
2434
2435         * nto-tdep.c (nto_inferior_data_reg): Change type.
2436         (nto_inferior_data): Update.
2437         (nto_inferior_data_cleanup, nto_new_inferior_data)
2438         (_initialize_nto_tdep): Remove.
2439         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2440
2441 2019-05-08  Tom Tromey  <tom@tromey.com>
2442
2443         * ada-lang.c (struct ada_inferior_data): Add initializers.
2444         (ada_inferior_data): Change type.
2445         (ada_inferior_data_cleanup): Remove.
2446         (get_ada_inferior_data, ada_inferior_exit)
2447         (struct ada_pspace_data): Add initializers, destructor.
2448         (ada_pspace_data_handle): Change type.
2449         (get_ada_pspace_data): Update.
2450         (ada_pspace_data_cleanup): Remove.
2451
2452 2019-05-08  Tom Tromey  <tom@tromey.com>
2453
2454         * coffread.c (struct coff_symfile_info): Add initializers.
2455         (coff_objfile_data_key): Move lower.  Change type.
2456         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2457         Update.
2458         (coff_free_info): Remove.
2459
2460 2019-05-08  Tom Tromey  <tom@tromey.com>
2461
2462         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2463         (fbsd_pspace_data_handle): Move lower.  Change type.
2464         (get_fbsd_pspace_data): Update.
2465         (fbsd_pspace_data_cleanup): Remove.
2466         (_initialize_fbsd_tdep): Update.
2467
2468 2019-05-08  Tom Tromey  <tom@tromey.com>
2469
2470         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2471         (get_ada_tasks_pspace_data): Update.
2472         (ada_tasks_pspace_data_cleanup): Remove.
2473         (_initialize_tasks): Update.
2474         (ada_tasks_inferior_data_handle): Change type.
2475         (get_ada_tasks_inferior_data): Update.
2476         (ada_tasks_inferior_data_cleanup): Remove.
2477         (struct ada_tasks_pspace_data): Add initializers.
2478
2479 2019-05-08  Tom Tromey  <tom@tromey.com>
2480
2481         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2482         * symfile-debug.c (debug_sym_get_probes): Change type.
2483         * stap-probe.c (handle_stap_probe):
2484         (stap_static_probe_ops::get_probes): Change type.
2485         * probe.h (class static_probe_ops) <get_probes>: Change type.
2486         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2487         (parse_probes_in_pspace): Update.
2488         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2489         Update.
2490         (any_static_probe_ops::get_probes): Change type.
2491         * elfread.c (elfread_data): New typedef.
2492         (probe_key): Change type.
2493         (elf_get_probes): Likewise.  Update.
2494         (probe_key_free): Remove.
2495         (_initialize_elfread): Update.
2496         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2497         Change type.
2498         (dtrace_process_dof_probe, dtrace_process_dof)
2499         (dtrace_static_probe_ops::get_probe): Change type.
2500
2501 2019-05-08  Tom Tromey  <tom@tromey.com>
2502
2503         * xcoffread.c (struct xcoff_symfile_info): Rename from
2504         coff_symfile_info.  Add initializers.
2505         (xcoff_objfile_data_key): Move lower.  Change type.
2506         (XCOFF_DATA): Rewrite.
2507         (xcoff_free_info): Remove.
2508         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2509         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2510         (xcoff_initial_scan): Update.
2511
2512 2019-05-08  Tom Tromey  <tom@tromey.com>
2513
2514         * solib-svr4.c (struct svr4_info): Add initializers and
2515         destructor.
2516         <probes_table>: Now an htab_up.
2517         (solib_svr4_pspace_data): Change type.
2518         (free_probes_table): Simplify.
2519         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2520         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2521         (probes_table_remove_objfile_probes, register_solib_event_probe)
2522         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2523         (_initialize_svr4_solib): Update.
2524
2525 2019-05-08  Tom Tromey  <tom@tromey.com>
2526
2527         * remote.c (remote_pspace_data): Change type.
2528         (remote_pspace_data_cleanup): Remove.
2529         (get_remote_exec_file, set_pspace_remote_exec_file)
2530         (_initialize_remote): Update.
2531
2532 2019-05-08  Tom Tromey  <tom@tromey.com>
2533
2534         * breakpoint.c (breakpoint_objfile_key): Change type.
2535         (get_breakpoint_objfile_data): Update.
2536         (free_breakpoint_objfile_data): Remove.
2537         (_initialize_breakpoint): Update.
2538
2539 2019-05-08  Tom Tromey  <tom@tromey.com>
2540
2541         * linux-tdep.c (struct linux_info): Add initializers.
2542         (linux_inferior_data): Move.  Change type.
2543         (invalidate_linux_cache_inf): Update.
2544         (linux_inferior_data_cleanup): Remove.
2545         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2546
2547 2019-05-08  Tom Tromey  <tom@tromey.com>
2548
2549         * auxv.c (auxv_inferior_data): Move.  Change type.
2550         (auxv_inferior_data_cleanup): Remove.
2551         (invalidate_auxv_cache_inf): Rewrite.
2552         (get_auxv_inferior_data, _initialize_auxv): Update.
2553
2554 2019-05-08  Tom Tromey  <tom@tromey.com>
2555
2556         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2557         (symfile_debug_objfile_data_key): Change type.
2558         (symfile_debug_installed, debug_qf_has_symbols)
2559         (debug_qf_find_last_source_symtab)
2560         (debug_qf_forget_cached_source_info)
2561         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2562         (debug_qf_print_stats, debug_qf_dump)
2563         (debug_qf_expand_symtabs_for_function)
2564         (debug_qf_expand_all_symtabs)
2565         (debug_qf_expand_symtabs_with_fullname)
2566         (debug_qf_map_matching_symbols)
2567         (debug_qf_expand_symtabs_matching)
2568         (debug_qf_find_pc_sect_compunit_symtab)
2569         (debug_qf_map_symbol_filenames)
2570         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2571         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2572         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2573         (debug_sym_read_linetable, debug_sym_relocate): Update.
2574         (symfile_debug_free_objfile): Remove.
2575         (install_symfile_debug_logging, _initialize_symfile_debug):
2576         Update.
2577
2578 2019-05-08  Tom Tromey  <tom@tromey.com>
2579
2580         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2581         allocate_on_obstack.
2582         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2583         (get_dwarf2_per_objfile): Update.
2584         (set_dwarf2_per_objfile): Remove.
2585         (dwarf2_has_info, dwarf2_get_section_info): Update.
2586         (dwarf2_free_objfile): Remove.
2587         (_initialize_dwarf2_read): Update.
2588
2589 2019-05-08  Tom Tromey  <tom@tromey.com>
2590
2591         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2592         initializers.
2593         <unsupported_script_warning_printed,
2594         script_not_found_warning_printed>: Now bool.
2595         (auto_load_pspace_data): Change type.
2596         (~auto_load_pspace_info): Rename from
2597         auto_load_pspace_data_cleanup.
2598         (get_auto_load_pspace_data, init_loaded_scripts_info)
2599         (clear_section_scripts, maybe_print_unsupported_script_warning)
2600         (maybe_print_script_not_found_warning, _initialize_auto_load):
2601         Update.
2602
2603 2019-05-08  Tom Tromey  <tom@tromey.com>
2604
2605         * objfiles.c (objfile_pspace_info): Add destructor and
2606         initializers.
2607         (objfiles_pspace_data): Change type.
2608         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2609         (get_objfile_pspace_data): Update.
2610         (objfiles_bfd_data): Change type.
2611         (get_objfile_bfd_data): Update.
2612         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2613
2614 2019-05-08  Tom Tromey  <tom@tromey.com>
2615
2616         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2617         Change type.
2618         (get_catch_syscall_inferior_data): Update.
2619         (catch_syscall_inferior_data_cleanup): Remove.
2620         (_initialize_break_catch_syscall): Update.
2621
2622 2019-05-08  Tom Tromey  <tom@tromey.com>
2623
2624         * inflow.c (struct terminal_info): Add destructor and
2625         initializers.
2626         (inflow_inferior_data): Change type.
2627         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2628         (get_inflow_inferior_data, inflow_inferior_exit)
2629         (swap_terminal_info, _initialize_inflow): Update.
2630
2631 2019-05-08  Tom Tromey  <tom@tromey.com>
2632
2633         * target-dcache.c (target_dcache_cleanup): Remove.
2634         (target_dcache_aspace_key): Change type.
2635         (target_dcache_init_p, target_dcache_invalidate)
2636         (target_dcache_get, target_dcache_get_or_init)
2637         (_initialize_target_dcache): Update.
2638         * dcache.h (struct dcache_deleter): New.
2639
2640 2019-05-08  Tom Tromey  <tom@tromey.com>
2641
2642         * symtab.c (struct symbol_cache): Add destructor and
2643         initializers.
2644         (symbol_cache_key): Move.  Change type.
2645         (make_symbol_cache, free_symbol_cache): Remove.
2646         (get_symbol_cache): Update.
2647         (symbol_cache_cleanup): Remove.
2648         (ALL_PSPACES, symbol_cache_flush)
2649         (maintenance_print_symbol_cache)
2650         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2651         Update.
2652
2653 2019-05-08  Tom Tromey  <tom@tromey.com>
2654
2655         * symtab.c (struct main_info): Add destructor and initializers.
2656         (main_progspace_key): Move.  Change type.
2657         (get_main_info): Update.
2658         (main_info_cleanup): Remove.
2659         (_initialize_symtab): Update.
2660
2661 2019-05-08  Tom Tromey  <tom@tromey.com>
2662
2663         * registry.h (DECLARE_REGISTRY): Define the _key class.
2664
2665 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2666
2667         * NEWS: Merge two 'New commands' sections.
2668
2669 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2670
2671         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2672         parameter and use Ada language definition instead.
2673         (ada_val_print_ptr): Remove unused language parameter.
2674         (ada_val_print_num): Remove language parameter and use Ada language
2675         definition instead.
2676         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2677         parameter.
2678         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2679         parameter and use Ada language definition instead.
2680         (ada_val_print_1): Update all ada_val_print_xxx calls.
2681         Remove language parameter.
2682         (ada_val_print): Update ada_val_print_1 call.
2683
2684 2019-05-08  Tom Tromey  <tromey@adacore.com>
2685
2686         * remote.c (remote_hw_watchpoint_limit)
2687         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2688         Now static.
2689
2690 2019-05-08  Tom Tromey  <tromey@adacore.com>
2691
2692         * maint.c (_initialize_maint_cmds): Move initialization code to
2693         remote.c.
2694         (watchdog, show_watchdog): Move to remote.c.
2695         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2696         "watchdog" static.
2697         (_initialize_remote): Move initialization code from maint.c.
2698         * defs.h (watchdog): Don't declare.
2699
2700 2019-05-08  Tom Tromey  <tromey@adacore.com>
2701
2702         * tui/tui-interp.c: Include main.h.
2703         * interps.c: Include main.h.
2704         * main.h (interpreter_p): Declare.
2705         * defs.h (interpreter_p): Don't declare.
2706
2707 2019-05-08  Tom Tromey  <tromey@adacore.com>
2708
2709         * dwarf2loc.c: Include dwarf2read.h.
2710         * defs.h (read_unsigned_leb128): Don't declare.
2711         * dwarf2read.h (read_unsigned_leb128): Declare.
2712
2713 2019-05-08  Tom Tromey  <tromey@adacore.com>
2714
2715         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2716         method.
2717
2718 2019-05-08  Tom Tromey  <tromey@adacore.com>
2719
2720         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2721         when no wrap column is set.
2722
2723 2019-05-08  Tom Tromey  <tromey@adacore.com>
2724
2725         * c-lang.c (c_get_string): Handle non-C-style arrays.
2726
2727 2019-05-08  Tom Tromey  <tromey@adacore.com>
2728
2729         * typeprint.c (print_offset_data::update): Print the bit offset,
2730         not the number of bits remaining.
2731
2732 2019-05-08  Tom Tromey  <tromey@adacore.com>
2733
2734         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2735         padding at end of comment.
2736
2737 2019-05-08  Tom Tromey  <tromey@adacore.com>
2738
2739         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2740         Compare main types.
2741
2742 2019-05-06  Tom Tromey  <tom@tromey.com>
2743
2744         * common/scoped_mmap.c: Include common-defs.h.
2745         * common/scoped_mmap.h: Don't include config.h.
2746
2747 2019-05-04  Tom Tromey  <tom@tromey.com>
2748
2749         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2750         (struct aarch64_call_info): Add initializers.
2751         <si>: Now a std::vector.
2752         (pass_on_stack, aarch64_push_dummy_call): Update.
2753
2754 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2755             Tom Tromey  <tom@tromey.com>
2756
2757         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2758         (ppc_threads): Now a std::vector.  Now static.
2759         (hwdebug_find_thread_points_by_tid)
2760         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2761         Update.
2762
2763 2019-05-04  Tom Tromey  <tom@tromey.com>
2764
2765         * arc-tdep.c (arc_tdesc_init): Return bool.
2766
2767 2019-05-04  Tom Tromey  <tom@tromey.com>
2768
2769         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2770         Use gdb_assert_not_reached.
2771
2772 2019-05-04  Tom Tromey  <tom@tromey.com>
2773
2774         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2775         "false".
2776
2777 2019-05-04  Tom Tromey  <tom@tromey.com>
2778
2779         * arc-tdep.c (arc_tdesc_init): Use bool.
2780
2781 2019-05-04  Tom Tromey  <tom@tromey.com>
2782
2783         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2784
2785 2019-05-04  Tom Tromey  <tom@tromey.com>
2786
2787         * cli/cli-cmds.c (valid_command_p): Return bool.
2788
2789 2019-05-04  Tom Tromey  <tom@tromey.com>
2790
2791         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2792         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2793
2794 2019-05-04  Raul Tambre  <raul@tambre.ee>
2795
2796         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2797         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2798         operator for comparison.
2799
2800 2019-05-04  Tom Tromey  <tom@tromey.com>
2801
2802         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2803         (lookup_partial_symbol, print_partial_symbols)
2804         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2805         (psymbol_compare): Update.
2806         (add_psymbol_to_bcache): Clear the entire psymbol.
2807         (maintenance_check_psymtabs): Update.
2808         * psympriv.h (struct partial_symbol): Don't derive from
2809         general_symbol_info.
2810         <obj_section, unrelocated_address, address,
2811         set_unrelocated_address>: Update.
2812         <ginfo>: New member.
2813         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2814         (debug_names::write_psymbols): Update.
2815
2816 2019-05-04  Tom de Vries  <tdevries@suse.de>
2817
2818         * contrib/cc-with-tweaks.sh: Support -n arg.
2819
2820 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2821
2822         * corelow.c (core_target::detach): Ensure frame cache and
2823         register caches are cleared.
2824         inferior.c (exit_inferior_1): Likewise.
2825
2826 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2827             Tom Tromey  <tom@tromey.com>
2828
2829         * dictionary.c (collate_pending_symbols_by_language): Remove
2830         "struct" from foreach.
2831         * symtab.c (lookup_global_symbol_from_objfile)
2832         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2833         foreach.
2834         * ser-tcp.c (net_open): Remove "struct" from foreach.
2835         * objfiles.c (objfile_relocate, objfile_rebase)
2836         (objfile_has_symbols): Remove "struct" from foreach.
2837         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2838         from foreach.
2839         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2840         foreach.
2841         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2842         "struct" from foreach.
2843         * ada-lang.c (create_excep_cond_exprs)
2844         (ada_exception_catchpoint_cond_string): Remove "struct" from
2845         foreach.
2846
2847 2019-05-03  Tom Tromey  <tromey@adacore.com>
2848
2849         * ada-exp.y (convert_char_literal): Check suffix of each
2850         enumerator.
2851
2852 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2853
2854         PR ada/21406:
2855         * ada-exp.y (yywrap): Don't define.
2856         * ada-lex.l (%option): Add noyywrap
2857         (yywrap): Remove.
2858
2859 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2860
2861         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2862         _WIN32_WINNT to the XP level, unless already defined to a higher
2863         level.
2864
2865         * unittests/parse-connection-spec-selftests.c:
2866         * ser-tcp.c:
2867         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2868         override.
2869
2870         * symfile.c (find_separate_debug_file): Remove colon from the
2871         drive spec of DOS/Windows file names of the target, so that the
2872         file name produced from DEBUGDIR and the target's directory will
2873         be valid on DOS/Windows systems.
2874
2875 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2876
2877         * rust-lang.c (val_print_struct): Handle printing structures
2878         containing strings.
2879
2880 2019-05-02  Tom Tromey  <tromey@adacore.com>
2881
2882         * valarith.c (_initialize_valarith): Remove.
2883
2884 2019-05-01  Tom Tromey  <tromey@adacore.com>
2885
2886         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2887         bitfields.
2888
2889 2019-05-01  Tom Tromey  <tromey@adacore.com>
2890
2891         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2892         for big-endian copies.
2893
2894 2019-04-30  Ali Tamur  <tamur@google.com>
2895         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2896         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2897         (read_3_bytes): New function.
2898
2899 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2900
2901         * windows-nat.c (main_thread_id): Delete.
2902         (handle_output_debug_string): Replace main_thread_id by
2903         current_event.dwThreadId.
2904         (fake_create_process): Likewise.
2905         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2906         Do not set main_thread_id.
2907         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2908         current_event.dwThreadId.
2909         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2910
2911 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2912
2913         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2914         Use current_event.dwThreadId instead of main_thread_id.
2915
2916 2019-04-30  Tom Tromey  <tromey@adacore.com>
2917
2918         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2919         (create_excep_cond_exprs): Iterate over program spaces.
2920         (ada_exception_catchpoint_cond_string): Examine all minimal
2921         symbols for exception types.
2922
2923 2019-04-30  Tom Tromey  <tromey@adacore.com>
2924
2925         PR c++/24470:
2926         * dwarf2read.c (process_structure_scope): Handle case where type
2927         has template parameters but no symbol was created.
2928
2929 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2930             Chris January  <chris.january@arm.com>
2931
2932         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2933         qualifier.
2934         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2935
2936 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2937
2938         * f-typeprint.c (f_print_type): Update rules for printing
2939         whitespace.
2940         (f_type_print_varspec_suffix): Likewise.
2941
2942 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2943             Chris January  <chris.january@arm.com>
2944
2945         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2946         function arguments.
2947
2948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2949
2950         * f-lang.c (build_fortran_types): Change name of void type to
2951         lower case.
2952         * f-typeprint.c (f_type_print_base): Print the name of the void
2953         type, rather than a fixed string.
2954         * f-valprint.c (f_decorations): Use lower case void string.
2955
2956 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2957             Chris January  <chris.january@arm.com>
2958
2959         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2960         types for Fortran.
2961
2962 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2963             Chris January  <chris.january@arm.com>
2964             David Lecomber  <david.lecomber@arm.com>
2965
2966         * f-exp.y (BINOP_INTRINSIC): New token.
2967         (exp): New parser rule handling BINOP_INTRINSIC.
2968         (f77_keywords): Add new builtin procedures.
2969         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2970         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2971         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2972         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2973         (print_unop_subexp_f): New function.
2974         (print_binop_subexp_f): New function.
2975         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2976         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2977         (dump_subexp_body_f): Likewise.
2978         (operator_check_f): Likewise.
2979         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2980         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2981
2982 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2983
2984         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2985         UNOP_KIND.
2986         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2987         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2988         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2989         (operator_length_f): New fuction.
2990         (print_subexp_f): New function.
2991         (op_name_f): New function.
2992         (dump_subexp_body_f): New function.
2993         (operator_check_f): New function.
2994         (exp_descriptor_f): Replace standard expression handling functions
2995         with new functions.
2996         * gdb/fortran-operator.def: New file.
2997         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2998         * gdb/std-operator.def: Remove UNOP_KIND.
2999
3000 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
3001
3002         * std-operator.def: Remove unbalanced, stray double quote
3003         character.
3004
3005 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3006             Chris January  <chris.january@arm.com>
3007             Daniel Everett  <daniel.everett@arm.com>
3008             Nick Forrington  <nick.forrington@arm.com>
3009             Richard Bunt  <richard.bunt@arm.com>
3010
3011         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3012         of depth when printing anonymous structs or unions.
3013         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3014         Don't print either the top-level value, or the children if the
3015         max-depth is exceeded.
3016         (ppscm_print_children): When printing the key of a map, allow one
3017         extra level of depth.
3018         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3019         print either the top-level value, or the children if the max-depth
3020         is exceeded.
3021         (print_children): When printing the key of a map, allow one extra
3022         level of depth.
3023         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3024         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3025         (user_print_options): Initialise max_depth field.
3026         (val_print_scalar_or_string_type_p): New function.
3027         (val_print): Check to see if the max depth has been reached.
3028         (val_print_check_max_depth): Define new function.
3029         (show_print_max_depth): New function.
3030         (_initialize_valprint): Add 'print max-depth' option.
3031         * valprint.h (struct value_print_options) <max_depth>: New field.
3032         (val_print_check_max_depth): Declare new function.
3033         * NEWS: Document new feature.
3034
3035 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3036
3037         * ada-lang.c (ada_language_defn): Initialise new field.
3038         * c-lang.c (c_is_string_type_p): New function.
3039         (c_language_defn): Initialise new field.
3040         (cplus_language_defn): Initialise new field.
3041         (asm_language_defn): Initialise new field.
3042         (minimal_language_defn): Initialise new field.
3043         * c-lang.h (c_is_string_type_p): Declare new function.
3044         * d-lang.c (d_language_defn): Initialise new field.
3045         * f-lang.c (f_is_string_type_p): New function.
3046         (f_language_defn): Initialise new field.
3047         * go-lang.c (go_is_string_type_p): New function.
3048         (go_language_defn): Initialise new field.
3049         * language.c (default_is_string_type_p): New function.
3050         (unknown_language_defn): Initialise new field.
3051         (auto_language_defn): Initialise new field.
3052         * language.h (struct language_defn) <la_is_string_type_p>: New
3053         member variable.
3054         (default_is_string_type_p): Declare new function.
3055         * m2-lang.c (m2_language_defn): Initialise new field.
3056         * objc-lang.c (objc_language_defn): Initialise new field.
3057         * opencl-lang.c (opencl_language_defn): Initialise new field.
3058         * p-lang.c (pascal_is_string_type_p): New function.
3059         (pascal_language_defn): Initialise new field.
3060         * rust-lang.c (rust_is_string_type_p): New function.
3061         (rust_language_defn): Initialise new field.
3062
3063 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3064
3065         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3066         New field.
3067         * ada-lang.c (ada_language_defn): Initialise new field.
3068         * c-lang.c (c_language_defn): Likewise.
3069         (cplus_language_defn): Likewise.
3070         (asm_language_defn): Likewise.
3071         (minimal_language_defn): Likewise.
3072         * d-lang.c (d_language_defn): Likewise.
3073         * f-lang.c (f_language_defn): Likewise.
3074         * go-lang.c (go_language_defn): Likewise.
3075         * language.c (unknown_language_defn): Likewise.
3076         (auto_language_defn): Likewise.
3077         * m2-lang.c (m2_language_defn): Likewise.
3078         * objc-lang.c (objc_language_defn): Likewise.
3079         * opencl-lang.c (opencl_language_defn): Likewise.
3080         * p-lang.c (pascal_language_defn): Likewise.
3081         * rust-lang.c (rust_language_defn): Likewise.
3082
3083 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3084
3085         * ada-lang.c (ada_is_character_type): Change return type to bool.
3086         (ada_is_string_type): Likewise.
3087         * ada-lang.h (ada_is_character_type): Update declaration
3088         (ada_is_string_type): Likewise.
3089
3090 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3091
3092         Support style in 'frame|thread apply'
3093
3094         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3095         * record.c (record_start, record_stop): Update callers of
3096         execute_command_to_string with false.
3097         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3098         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3099         methods.
3100         (class string_file): New constructor with term_out parameter.
3101         Override methods term_out and can_emit_style_escape.  New member
3102         term_out.
3103         (class stdio_file): Override can_emit_style_escape.
3104         (class tee_file): Override term_out and can_emit_style_escape.
3105         * utils.h (can_emit_style_escape): Remove.
3106         * utils.c (can_emit_style_escape): Likewise.
3107         Update all callers of can_emit_style_escape (SOMESTREAM) to
3108         SOMESTREAM->can_emit_style_escape.
3109         * source-cache.c (source_cache::get_source_lines): Likewise.
3110         * stack.c (frame_apply_command_count): Call execute_command_to_string
3111         passing the term_out characteristic of the current gdb_stdout.
3112         * thread.c (thr_try_catch_cmd): Likewise.
3113         * top.c (execute_command_to_string): pass term_out parameter
3114         to construct the string_file for the command output.
3115         * ui-file.c (term_cli_styling): New function (most code moved
3116         from utils.c can_emit_style_escape).
3117         (string_file::string_file, string_file::can_emit_style_escape,
3118         stdio_file::can_emit_style_escape, tee_file::term_out,
3119         tee_file::can_emit_style_escape): New functions.
3120
3121 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3122
3123         * NEWS: Mention the new set|show may-call-functions.
3124         * infcall.c (may_call_functions_p): New variable.
3125         (show_may_call_functions_p): New function.
3126         (call_function_by_hand_dummy): Throws an error if not
3127         may-call-functions.
3128         (_initialize_infcall): Call add_setshow_boolean_cmd for
3129         may-call-functions.
3130
3131 2019-04-25  Keith Seitz  <keiths@redhat.com>
3132
3133         PR c++/24367
3134         * cp-support.c (inspect_type): Don't attempt substitutions
3135         of symbol with the same name.
3136
3137 2019-04-25  Tom Tromey  <tromey@adacore.com>
3138
3139         PR gdb/24475:
3140         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3141         static.
3142
3143 2019-04-25  Tom Tromey  <tromey@adacore.com>
3144
3145         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3146         rvalue reference.
3147         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3148         (gdb_xml_parser::parse): Use std::move.
3149         * python/python-internal.h (gdbpy_convert_exception): Take a const
3150         reference.
3151         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3152         std::move.
3153         * python/py-utils.c (gdbpy_convert_exception): Take a const
3154         reference.
3155         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3156         Use std::move.
3157         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3158         Use std::move.
3159         * mi/mi-main.c (mi_print_exception): Take a const reference.
3160         * main.c (handle_command_errors): Take a const reference.
3161         * linespec.c (parse_linespec): Use std::move.
3162         * infcall.c (run_inferior_call): Use std::move.
3163         (call_function_by_hand_dummy): Use std::move.
3164         * exec.c (try_open_exec_file): Use std::move.
3165         * exceptions.h (exception_print, exception_fprintf)
3166         (exception_print_same): Update.
3167         * exceptions.c (print_exception, exception_print)
3168         (exception_fprintf, exception_print_same): Change parameters to
3169         const reference.
3170         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3171         * common/new-op.c: Use std::move.
3172         * common/common-exceptions.h (struct gdb_exception): Add move
3173         constructor.
3174         (struct gdb_exception_error, struct gdb_exception_quit, struct
3175         gdb_quit_bad_alloc): Change constructor to move constructor.
3176         (throw_exception): Change parameter to rvalue reference.
3177         * common/common-exceptions.c (throw_exception): Take rvalue
3178         reference.
3179         * cli/cli-interp.c (safe_execute_command): Use std::move.
3180         * breakpoint.c (insert_bp_location, location_to_sals): Use
3181         std::move.
3182
3183 2019-04-25  Tom Tromey  <tromey@adacore.com>
3184
3185         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3186         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3187         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3188         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3189         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3190         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3191         guile/scm-value.c: Use unpack.
3192         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3193         gdbscm_gdb_exception.
3194         (gdbscm_throw_gdb_exception): Likewise.
3195         (struct gdbscm_gdb_exception): New.
3196         (unpack): New function.
3197         (gdbscm_wrap): Use unpack.
3198
3199 2019-04-25  Tom Tromey  <tromey@adacore.com>
3200
3201         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3202         (gdb_rl_callback_handler): Use std::move.
3203         * common/common-exceptions.h (struct gdb_exception): Add move
3204         assignment operator.
3205         (throw_exception_sjlj): Change "exception" to const reference.
3206         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3207         (throw_exception_sjlj): Change "exception" to const reference.
3208
3209 2019-04-25  Tom Tromey  <tromey@adacore.com>
3210
3211         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3212         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3213         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3214         Update.
3215         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3216         Update.
3217         * mi/mi-interp.c (mi_interp::exec): Update.
3218         * linespec.c (parse_linespec): Update.
3219         * infcall.c (run_inferior_call): Update.
3220         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3221         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3222         (gdbscm_lookup_global_symbol): Update.
3223         * guile/scm-param.c (gdbscm_parameter_value): Update.
3224         * guile/scm-frame.c (gdbscm_frame_read_register)
3225         (gdbscm_frame_read_var): Update.
3226         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3227         * exec.c (try_open_exec_file): Update.
3228         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3229         (gdb_rl_callback_handler): Update.
3230         * common/common-exceptions.h (exception_none): Don't declare.
3231         * common/common-exceptions.c (exception_none): Don't define.
3232         (struct catcher) <exception>: Update.
3233         * cli/cli-interp.c (safe_execute_command): Update.
3234         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3235
3236 2019-04-25  Ali Tamur  <tamur@google.com>
3237
3238         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3239         (read_attribute_value): Likewise.
3240         (dwarf2_read_addr_index): Update comment.
3241         (read_str_index): Add DW_FORM_strx.
3242         (dwarf2_string_attr): Likewise.
3243         (dwarf2_const_value_attr): Likewise.
3244         (dump_die_shallow): Likewise.
3245         (dwarf2_fetch_constant_bytes): Likewise.
3246         (skip_form_bytes): Likewise.
3247         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3248
3249 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3250
3251         PR corefiles/11608
3252         PR corefiles/18187
3253         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3254         OFFSET.  Verify if current mapping contains an ELF header.
3255         (linux_find_memory_regions_full): Adjust call to
3256         dump_mapping_p.
3257
3258 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3259             Kang Li <kanglictf@gmail.com>
3260
3261         PR gdb/21600
3262
3263         * dwarf2-frame.c (read_initial_length): Be consistent about using
3264         unsigned representation of length.
3265         (decode_frame_entry_1): Likewise.  Check for wraparound of
3266         end pointer as well as buffer overflow.
3267
3268 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3269
3270         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3271         "vq".
3272
3273 2019-04-24  Tom Tromey  <tromey@adacore.com>
3274
3275         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3276
3277 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3278
3279         * s12z-tdep.c (s12z_unwind_pc): Delete.
3280         (s12z_unwind_sp): Delete.
3281         (s12z_gdbarch_init): Don't register deleted functions with
3282         gdbarch.
3283
3284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * rl78-tdep.c (rl78_unwind_sp): Delete.
3287         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3288
3289 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3290
3291         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3292         (xstormy16_unwind_pc): Delete.
3293         (xstormy16_dummy_id): Delete.
3294         (xstormy16_gdbarch_init): Don't register deleted functions with
3295         gdbarch.
3296
3297 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3298
3299         * vax-tdep.c (vax_unwind_pc): Delete.
3300         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3301
3302 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3303
3304         * v850-tdep.c (v850_unwind_sp): Delete.
3305         (v850_unwind_pc): Delete.
3306         (v850_dummy_id): Delete.
3307         (v850_gdbarch_init): Don't register deleted functions with
3308         gdbarch.
3309
3310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3311
3312         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3313         (tilegx_unwind_pc): Delete.
3314         (tilegx_unwind_dummy_id): Delete.
3315         (tilegx_gdbarch_init): Don't register deleted functions with
3316         gdbarch.
3317
3318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3319
3320         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3321         (tic6x_dummy_id): Delete.
3322         (tic6x_gdbarch_init): Don't register deleted functions with
3323         gdbarch.
3324
3325 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3326
3327         * sparc-tdep.c (sparc_unwind_pc): Delete.
3328         (sparc32_gdbarch_init): Don't register deleted function with
3329         gdbarch.
3330
3331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3332
3333         * sh-tdep.c (sh_unwind_sp): Delete.
3334         (sh_unwind_pc): Delete.
3335         (sh_dummy_id): Delete.
3336         (sh_gdbarch_init): Don't register deleted functions with
3337         gdbarch.
3338
3339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3340
3341         * score-tdep.c (score_unwind_sp): Delete.
3342         (score_unwind_pc): Delete.
3343         (score_dummy_id): Delete.
3344         (score_gdbarch_init): Don't register deleted functions with
3345         gdbarch.
3346
3347 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3348
3349         * rx-tdep.c (rx_unwind_pc): Delete.
3350         (rx_unwind_sp): Delete.
3351         (rx_dummy_id): Delete.
3352         (rx_gdbarch_init): Don't register deleted functions with
3353         gdbarch.  Update comment.
3354
3355 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3356
3357         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3358         (rs6000_dummy_id): Delete.
3359         (rs6000_gdbarch_init): Don't register deleted functions with
3360         gdbarch.
3361
3362 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3363
3364         * or1k-tdep.c (or1k_dummy_id): Delete.
3365         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3366
3367 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3368
3369         * nios2-tdep.c (nios2_dummy_id): Delete.
3370         (nios2_unwind_sp): Delete.
3371         (nios2_gdbarch_init): Don't register deleted functions with
3372         gdbarch.
3373
3374 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3375
3376         * nds32-tdep.c (nds32_dummy_id): Delete.
3377         (nds32_unwind_pc): Delete.
3378         (nds32_unwind_sp): Delete.
3379         (nds32_gdbarch_init): Don't register deleted functions with
3380         gdbarch.
3381
3382 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3383
3384         * msp430-tdep.c (msp430_unwind_pc): Delete.
3385         (msp430_unwind_sp): Delete.
3386         (msp430_dummy_id): Delete.
3387         (msp430_gdbarch_init): Don't register deleted functions with
3388         gdbarch.
3389
3390 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3391
3392         * moxie-tdep.c (moxie_unwind_sp): Delete.
3393         (moxie_unwind_pc): Delete.
3394         (moxie_dummy_id): Delete.
3395         (moxie_gdbarch_init): Don't register deleted functions with
3396         gdbarch.
3397
3398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3401         (mn10300_unwind_pc): Delete.
3402         (mn10300_unwind_sp): Delete.
3403         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3404         mn10300_unwind_sp.
3405         (mn10300_frame_unwind_init): Don't register deleted functions with
3406         gdbarch.
3407
3408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3409
3410         * mep-tdep.c (mep_unwind_pc): Delete.
3411         (mep_unwind_sp): Delete.
3412         (mep_dummy_id): Delete.
3413         (mep_gdbarch_init): Don't register deleted functions with
3414         gdbarch.
3415
3416 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3417
3418         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3419         (m68hc11_unwind_sp): Delete.
3420         (m68hc11_gdbarch_init): Don't register deleted functions with
3421         gdbarch.
3422
3423 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3424
3425         * m32r-tdep.c (m32r_unwind_sp): Delete.
3426         (m32r_unwind_pc): Delete.
3427         (m32r_dummy_id): Delete.
3428         (m32r_gdbarch_init): Don't register deleted functions with
3429         gdbarch.
3430
3431 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3432
3433         * m32c-tdep.c (m32c_unwind_pc): Delete.
3434         (m32c_unwind_sp): Delete.
3435         (m32c_dummy_id): Delete.
3436         (m32c_gdbarch_init): Don't register deleted functions with
3437         gdbarch.
3438
3439 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3440
3441         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3442         (lm32_unwind_pc): Delete.
3443         (lm32_dummy_id): Delete.
3444         (lm32_gdbarch_init): Don't register deleted functions with
3445         gdbarch.
3446
3447 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3448
3449         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3450         (iq2000_unwind_pc): Delete.
3451         (iq2000_dummy_id): Delete.
3452         (iq2000_gdbarch_init): Don't register deleted functions with
3453         gdbarch.
3454
3455 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3456
3457         * nds32-tdep.c (nds32_type_align): Delete.
3458         (nds32_push_dummy_call): Use type_align instead.
3459
3460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3461
3462         * arm-tdep.c (arm_type_align): Only handle vector override case.
3463         (arm_push_dummy_call): Use type_align.
3464         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3465
3466 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3467
3468         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3469         case.
3470         (pass_on_stack): Use type_align.
3471         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3472         function.
3473
3474 2019-04-23  Tom Tromey  <tromey@adacore.com>
3475
3476         * dwarf2read.c (line_header::file_name_at): Remove unused
3477         overload.
3478
3479 2019-04-23  Tom de Vries  <tdevries@suse.de>
3480
3481         PR gdb/24438
3482         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3483         invocation.
3484
3485
3486 2019-03-27  Ali Tamur  <tamur@google.com>
3487
3488         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3489         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3490         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3491         (dwarf_expr_context::get_addr_index): Likewise
3492         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3493         (symbol_needs_eval_context::get_addr_index): Likewise
3494         (disassemble_dwarf_expression): Add DW_OP_addrx
3495         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3496         (read_cutu_die_from_dwo): Update comment
3497         (skip_one_die): Add DW_FORM_addrx
3498         (read_attribute_value): Likewise
3499         (var_decode_location): Add DW_OP_addrx
3500         (dwarf2_const_value_attr): Add DW_FORM_addrx
3501         (dump_die_shallow): Likewise
3502         (dwarf2_fetch_constant_bytes): Likewise
3503         (decode_locdesc): Add DW_OP_addrx
3504         (skip_form_bytes): Add DW_FORM_addrx
3505
3506 2019-04-22  Ali Tamur  <tamur@google.com>
3507
3508         * MAINTAINERS (Write After Approval): Add self.
3509
3510 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3511
3512         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3513         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3514         (open_symbol_file_object): Likewise.
3515         (svr4_default_sos): Add info parameter.
3516         (svr4_read_so_list): Likewise.
3517         (svr4_current_sos_direct): Adjust functions calls to pass down
3518         info.
3519         (svr4_current_sos_1): Add info parameter.
3520         (svr4_current_sos): Call get_svr4_info, pass info down to
3521         svr4_current_sos_1.
3522         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3523         get_svr4_info.
3524         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3525         get_svr4_info.
3526         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3527         to get_svr4_info.
3528         (probes_table_remove_objfile_probes): Likewise.
3529         (register_solib_event_probe): Add info parameter.
3530         (solist_update_incremental): Pass info parameter down to
3531         svr4_read_so_list.
3532         (disable_probes_interface): Add info parameter.
3533         (svr4_handle_solib_event): Pass current_program_space to
3534         get_svr4_info.  Adjust disable_probes_interface cleanup.
3535         (svr4_create_probe_breakpoints): Add info parameter, pass it
3536         down to register_solib_event_probe.
3537         (svr4_create_solib_event_breakpoints): Add info parameter,
3538         pass it down to svr4_create_probe_breakpoints.
3539         (enable_break): Pass info down to
3540         svr4_create_solib_event_breakpoints.
3541         (svr4_solib_create_inferior_hook): Pass current_program_space to
3542         get_svr4_info.
3543         (svr4_clear_solib): Likewise.
3544
3545 2019-04-22  Pedro Alves  <palves@redhat.com>
3546
3547         * solib-svr4.c (svr4_free_objfile_observer): New.
3548         (probe_and_action::objfile): New field.
3549         (probes_table_htab_remove_objfile_probes)
3550         (probes_table_remove_objfile_probes): New functions.
3551         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3552         in the new probe_and_action.  Don't store the probe in 'lookup'.
3553         (svr4_create_probe_breakpoints): Pass objfile to
3554         register_solib_event_probe.
3555         (_initialize_svr4_solib): Register a free_objfile observer.
3556
3557 2019-04-19  Tom Tromey  <tom@tromey.com>
3558
3559         * common/queue.h: Remove.
3560
3561 2019-04-19  Tom Tromey  <tom@tromey.com>
3562
3563         * event-loop.c: Don't include "common/queue.h".
3564
3565 2019-04-19  Tom Tromey  <tom@tromey.com>
3566
3567         * remote.c (remote_target): Use delete.
3568         * remote-notif.h: Include <list>, not "common/queue.h".
3569         (notif_client_p): Remove typedef.
3570         (remote_notif_state): Add constructor, destructor, initializer.
3571         <notif_queue>: Now a std::list.
3572         (remote_notif_state_xfree): Don't declare.
3573         * remote-notif.c (remote_notif_process, handle_notification)
3574         (remote_notif_state_allocate): Update.
3575         (~remote_notif_state): Rename from remote_notif_state_xfree.
3576
3577 2019-04-19  Tom Tromey  <tom@tromey.com>
3578
3579         * symfile.c (reread_symbols): Update.
3580         * objfiles.c (objfile_register_static_link)
3581         (objfile_lookup_static_link): Update
3582         (~objfile) Don't delete static_links.
3583         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3584
3585 2019-04-19  Tom Tromey  <tom@tromey.com>
3586
3587         * type-stack.h (struct type_stack) <insert>: Constify string.
3588         * type-stack.c (type_stack::insert): Constify string.
3589         * gdbtypes.h (lookup_template_type): Update.
3590         (address_space_name_to_int): Update.
3591         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3592         const.
3593         (lookup_template_type): Make name const.
3594         * c-exp.y: Update rules.
3595         (lex_one_token, classify_name, classify_inner_name)
3596         (c_print_token): Update.
3597         * p-exp.y: Update rules.
3598         (yylex): Update.
3599         * f-exp.y: Update rules.
3600         (yylex): Update.
3601         * d-exp.y: Update rules.
3602         (lex_one_token, classify_name, classify_inner_name): Update.
3603         * parse.c (write_dollar_variable, copy_name): Return std::string.
3604         * parser-defs.h (copy_name): Change return type.
3605         * m2-exp.y: Update rules.
3606         (yylex): Update.
3607         * go-exp.y (lex_one_token): Update.
3608         Update rules.
3609         (classify_unsafe_function, classify_packaged_name)
3610         (classify_name, yylex): Update.
3611
3612 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3613
3614         * configure.ac: add --enable-source-highlight switch.
3615         * configure: Regenerate.
3616         * top.c (print_gdb_version): plumb --enable-source-highlight
3617         status to "show configuration".
3618
3619 2019-04-19  Tom Tromey  <tromey@adacore.com>
3620
3621         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3622         Check ADA_TYPE_P.
3623         (empty_record, ada_template_to_fixed_record_type_1)
3624         (template_to_static_fixed_type)
3625         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3626         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3627         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3628         macros.
3629
3630 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3631
3632         PR symtab/24423:
3633         * source.c (print_source_lines_base): Advance "iter" when a
3634         control character is seen.
3635
3636 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3637
3638         * inferior.h (struct infcall_suspend_state_deleter):
3639         Catch exception in destructor to avoid crash.
3640
3641 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3642
3643         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3644         close to the add_com "shell".
3645
3646 2019-04-18  Tom Tromey  <tromey@adacore.com>
3647
3648         * process-stratum-target.h (class process_stratum_target)
3649         <stratum>: Add "final".
3650
3651 2019-04-17  Tom Tromey  <tromey@adacore.com>
3652
3653         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3654         against nullptr before use.
3655
3656 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3657
3658         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3659
3660 2019-04-17  Jim Wilson  <jimw@sifive.com>
3661             Andrew Burgess  <andrew.burgess@embecosm.com>
3662
3663         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3664         code read might fail, assume 4-byte breakpoint in that case.
3665
3666 2019-04-15  Leszek Swirski  <leszeks@google.com>
3667
3668         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3669         rather than a hand-rolled POD check when checking for forced MEMORY
3670         classification.
3671
3672 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3675         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3676         function.
3677         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3678         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3679         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3680         declaration.
3681
3682 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3683
3684         * aarch64-linux-nat.c
3685         (aarch64_linux_nat_target::thread_architecture): Add override.
3686         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3687         each VQ.
3688
3689 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3690
3691         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3692
3693 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3694
3695         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3696         target types of size 96-bits, add some additional comments, and
3697         check that the builtin type we found was the correct size.
3698
3699 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3700
3701         * utils.c (prompt_for_continue): Don't restore the styling at the
3702         end, as applied_style has the wrong value.  This fixes styling in
3703         long lists of file names that are interrupted by the "Continue?"
3704         prompt.
3705
3706 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3707
3708         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3709         * c-lang.c (c_language_defn): Likewise.
3710         (cplus_language_defn): Likewise.
3711         (asm_language_defn): Likewise.
3712         (minimal_language_defn): Likewise.
3713         * d-lang.c (d_language_defn): Likewise.
3714         * f-lang.c (f_language_defn): Likewise.
3715         * go-lang.c (go_language_defn): Likewise.
3716         * language.c (unknown_language_defn): Likewise.
3717         (auto_language_defn): Likewise.
3718         * language.h (struct language_defn): Remove la_magic field.
3719         (LANG_MAGIC): Delete.
3720         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3721         * objc-lang.c (objc_language_defn): Likewise.
3722         * opencl-lang.c (opencl_language_defn): Likewise.
3723         * p-lang.c (pascal_language_defn): Likewise.
3724         * rust-lang.c (rust_language_defn): Likewise.
3725
3726 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3727
3728         * riscv-tdep.c (riscv_type_align): New function.
3729         (riscv_type_alignment): Delete.
3730         (riscv_arg_location): Use 'type_align'.
3731         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3732
3733 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3734
3735         * gdbtypes.c (type_align): A struct with no non-static fields also
3736         has alignment of 1.
3737
3738 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3739
3740         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3741         component to 0.
3742         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3743         member.
3744         (riscv_struct_info::analyse): New implementation using new
3745         analyse_inner member function.
3746         (riscv_struct_info::field_offset): New member function.
3747         (riscv_struct_info::m_offsets): New member variable.
3748         (riscv_struct_info::analyse_inner): New private member function,
3749         takes the old implementation of riscv_struct_info::analyse but
3750         extended to track field offsets.
3751         (riscv_call_arg_struct): Update the struct folding special cases
3752         to handle cases where empty C++ structs, which are non-zero
3753         length, are found.
3754         (riscv_arg_location): Initialise the length of each location, a
3755         non-zero length now indicates the location is in use.
3756         (riscv_push_dummy_call): Allow for the first location having a
3757         non-zero offset when setting up arguments.
3758         (riscv_return_value): Likewise, but for return values.
3759
3760 2019-04-11  Tom Tromey  <tromey@adacore.com>
3761
3762         * utils.c (internal_vproblem): Make "msg" const.
3763
3764 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3765
3766         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3767         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3768         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3769         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3770
3771 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3772
3773         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3774         function.
3775         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3776         of amd64_collect_native_gregset.
3777         (amd64_linux_nat_target::store_registers): Likewise.
3778
3779 2019-04-10  Tom Tromey  <tom@tromey.com>
3780
3781         * symtab.c (lookup_global_symbol_from_objfile)
3782         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3783         * objfiles.h (class separate_debug_iterator): New.
3784         (class separate_debug_range): New.
3785         (struct objfile) <separate_debug_objfiles>: New method.
3786         (objfile_separate_debug_iterate): Don't declare.
3787         * objfiles.c (separate_debug_iterator::operator++): Rename from
3788         objfile_separate_debug_iterate.
3789         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3790         iterator.
3791         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3792         iterator.
3793
3794 2019-04-10  Tom Tromey  <tom@tromey.com>
3795
3796         * symfile.c (reread_symbols): Remove old comment.
3797         * objfiles.c (free_all_objfiles): Fix a typo.
3798
3799 2019-04-10  Tom Tromey  <tom@tromey.com>
3800
3801         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3802         * minsyms.c (lookup_minimal_symbol): Use foreach.
3803         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3804         (lookup_minimal_symbol_solib_trampoline): Likewise.
3805         * symfile.c (reread_symbols): Use foreach.
3806
3807 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3808             Tom Tromey  <tromey@adacore.com>
3809
3810         PR rust/24414:
3811         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3812         (rust_lex_int_test): Change "value" to be LONGEST.
3813         (rust_lex_tests): Add test for long integer literal.
3814
3815 2019-04-09  Tom Tromey  <tromey@adacore.com>
3816
3817         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3818         to bool.
3819         (extended_remote_target::attach): Update.
3820         (remote_target::remote_notice_new_inferior): Update.
3821         (remote_target::add_current_inferior_and_thread): Update.
3822         * inferior.c (exit_inferior_1): Use "false".
3823         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3824
3825 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3826
3827         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3828         the "start" command.
3829
3830 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3831
3832         * python/py-inferior.c (infpy_thread_from_thread_handle):
3833         Adjust comments to reflect renaming of thread_from_thread_handle
3834         to thread_from_handle.  Adjust keywords.  Fix type error message.
3835         (inferior_object_methods): Add thread_from_handle.  Retain
3836         thread_from_thread_handle, but mark it as deprecated.
3837
3838 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3839
3840         * gdbthread.h (find_thread_by_handle): Revise declaration.
3841         * thread.c (find_thread_by_handle): Likewise.  Adjust
3842         implementation too.
3843         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3844         support for buffer objects as handles.
3845
3846 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3847
3848         * python/py-infthread.c (thpy_thread_handle): New function.
3849         (thread_object_methods): Register thpy_thread_handle.
3850
3851 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3852
3853         * gdbthread.h (thread_to_thread_handle): Declare.
3854         * thread.c (gdbtypes.h): Include.
3855         (thread_to_thread_handle): New function.
3856
3857         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3858         (target_thread_info_to_thread_handle): Declare.
3859         * target.c (target_thread_info_to_thread_handle): New function.
3860         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3861         * target-delegates.c: Regenerate.
3862
3863         * linux-thread-db.c (class thread_db_target): Add method
3864         thread_info_to_thread_handle.
3865         (thread_db_target::thread_info_to_thread_handle): Define.
3866         * remote.c (class remote_target): Add new method
3867         thread_info_to_thread_handle.
3868         (remote_target::thread_info_to_thread_handle): Define.
3869
3870 2019-04-08  Pedro Alves  <palves@redhat.com>
3871
3872         * common/common-exceptions.c (throw_exception): Don't create
3873         named object to throw; throw directly.
3874         (throw_it): Likewise.  Don't initialize gdb_exception::message
3875         here, with new; pass FMT and AP to the ctor instead.
3876         * common/common-exceptions.h: Include <string>.
3877         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3878         const char *, va_list)): New ctor.  Use std::make_shared.
3879         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3880         errors)): Delete.
3881         (gdb_exception_error::gdb_exception_error(enum errors, const char
3882         *, va_list)): New.
3883         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3884         Add assertion.
3885         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3886         errors)): Delete.
3887         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3888         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3889         Add assertion.
3890
3891 2019-04-08  Tom Tromey  <tom@tromey.com>
3892
3893         * valops.c (value_rtti_indirect_type): Replace throw_exception
3894         with throw.
3895         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3896         with throw.
3897         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3898         throw.
3899         * target.c (target_translate_tls_address): Replace throw_exception
3900         with throw.
3901         * stack.c (frame_apply_command_count): Replace throw_exception
3902         with throw.
3903         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3904         throw.
3905         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3906         with throw.
3907         * rs6000-tdep.c (rs6000_frame_cache)
3908         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3909         * remote.c: Replace throw_exception with throw.
3910         * record-full.c (record_full_message, record_full_wait_1)
3911         (record_full_restore): Replace throw_exception with throw.
3912         * record-btrace.c:
3913         (get_thread_current_frame_id, record_btrace_start_replaying)
3914         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3915         (cmd_record_btrace_start): Replace throw_exception with throw.
3916         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3917         throw.
3918         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3919         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3920         * linespec.c:
3921         (find_linespec_symbols): Replace throw_exception with throw.
3922         * infrun.c (displaced_step_prepare, resume): Replace
3923         throw_exception with throw.
3924         * infcmd.c (post_create_inferior): Replace throw_exception with
3925         throw.
3926         * inf-loop.c (inferior_event_handler): Replace throw_exception
3927         with throw.
3928         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3929         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3930         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3931         (get_prev_frame_always, get_frame_pc_if_available)
3932         (get_frame_address_in_block_if_available, get_frame_language):
3933         Replace throw_exception with throw.
3934         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3935         throw_exception with throw.
3936         * eval.c (fetch_subexp_value, evaluate_var_value)
3937         (evaluate_funcall, evaluate_subexp_standard): Replace
3938         throw_exception with throw.
3939         * dwarf2loc.c (call_site_find_chain)
3940         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3941         Replace throw_exception with throw.
3942         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3943         with throw.
3944         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3945         throw.
3946         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3947         * completer.c (complete_line_internal): Replace throw_exception
3948         with throw.
3949         * compile/compile-object-run.c (compile_object_run): Replace
3950         throw_exception with throw.
3951         * cli/cli-script.c (process_next_line): Replace throw_exception
3952         with throw.
3953         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3954         (btrace_enable, btrace_maint_update_pt_packets): Replace
3955         throw_exception with throw.
3956         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3957         throw_exception with throw.
3958         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3959         throw_exception with throw.
3960         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3961         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3962         * aarch64-tdep.c (aarch64_make_prologue_cache)
3963         (aarch64_make_stub_cache): Replace throw_exception with throw.
3964
3965 2019-04-08  Tom Tromey  <tom@tromey.com>
3966
3967         * common/common-exceptions.c (throw_exception): Rename from
3968         throw_exception_cxx.  Remove old copy.  Make argument const.
3969         (throw_it): Create and throw exception objects directly.
3970         * common/common-exceptions.h (throw_exception): Make argument
3971         const.
3972         (struct gdb_exception_error): Add constructor.
3973         (struct gdb_exception_quit): Add constructor.
3974
3975 2019-04-08  Tom Tromey  <tom@tromey.com>
3976
3977         * common/common-exceptions.h (exception_rethrow): Don't declare.
3978         (TRY_SJLJ): Update comment.
3979         (TRY, CATCH, END_CATCH): Remove.
3980         * common/common-exceptions.c (exception_rethrow): Remove.
3981
3982 2019-04-08  Tom Tromey  <tom@tromey.com>
3983
3984         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3985         Remove.
3986         (gdb_exception_error): Rename from
3987         gdb_exception_RETURN_MASK_ERROR.
3988         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3989         (gdb_quit_bad_alloc): Update.
3990         * aarch64-tdep.c: Update.
3991         * ada-lang.c: Update.
3992         * ada-typeprint.c: Update.
3993         * ada-valprint.c: Update.
3994         * amd64-tdep.c: Update.
3995         * arch-utils.c: Update.
3996         * break-catch-throw.c: Update.
3997         * breakpoint.c: Update.
3998         * btrace.c: Update.
3999         * c-varobj.c: Update.
4000         * cli/cli-cmds.c: Update.
4001         * cli/cli-interp.c: Update.
4002         * cli/cli-script.c: Update.
4003         * common/common-exceptions.c: Update.
4004         * common/new-op.c: Update.
4005         * common/selftest.c: Update.
4006         * compile/compile-c-symbols.c: Update.
4007         * compile/compile-cplus-symbols.c: Update.
4008         * compile/compile-object-load.c: Update.
4009         * compile/compile-object-run.c: Update.
4010         * completer.c: Update.
4011         * corelow.c: Update.
4012         * cp-abi.c: Update.
4013         * cp-support.c: Update.
4014         * cp-valprint.c: Update.
4015         * darwin-nat.c: Update.
4016         * disasm-selftests.c: Update.
4017         * dtrace-probe.c: Update.
4018         * dwarf-index-cache.c: Update.
4019         * dwarf-index-write.c: Update.
4020         * dwarf2-frame-tailcall.c: Update.
4021         * dwarf2-frame.c: Update.
4022         * dwarf2loc.c: Update.
4023         * dwarf2read.c: Update.
4024         * eval.c: Update.
4025         * event-loop.c: Update.
4026         * event-top.c: Update.
4027         * exec.c: Update.
4028         * f-valprint.c: Update.
4029         * fbsd-tdep.c: Update.
4030         * frame-unwind.c: Update.
4031         * frame.c: Update.
4032         * gdbtypes.c: Update.
4033         * gnu-v3-abi.c: Update.
4034         * guile/guile-internal.h: Update.
4035         * guile/scm-block.c: Update.
4036         * guile/scm-breakpoint.c: Update.
4037         * guile/scm-cmd.c: Update.
4038         * guile/scm-disasm.c: Update.
4039         * guile/scm-frame.c: Update.
4040         * guile/scm-lazy-string.c: Update.
4041         * guile/scm-math.c: Update.
4042         * guile/scm-param.c: Update.
4043         * guile/scm-ports.c: Update.
4044         * guile/scm-pretty-print.c: Update.
4045         * guile/scm-symbol.c: Update.
4046         * guile/scm-symtab.c: Update.
4047         * guile/scm-type.c: Update.
4048         * guile/scm-value.c: Update.
4049         * i386-linux-tdep.c: Update.
4050         * i386-tdep.c: Update.
4051         * inf-loop.c: Update.
4052         * infcall.c: Update.
4053         * infcmd.c: Update.
4054         * infrun.c: Update.
4055         * jit.c: Update.
4056         * language.c: Update.
4057         * linespec.c: Update.
4058         * linux-fork.c: Update.
4059         * linux-nat.c: Update.
4060         * linux-tdep.c: Update.
4061         * linux-thread-db.c: Update.
4062         * main.c: Update.
4063         * mi/mi-cmd-break.c: Update.
4064         * mi/mi-cmd-stack.c: Update.
4065         * mi/mi-interp.c: Update.
4066         * mi/mi-main.c: Update.
4067         * objc-lang.c: Update.
4068         * p-valprint.c: Update.
4069         * parse.c: Update.
4070         * ppc-linux-tdep.c: Update.
4071         * printcmd.c: Update.
4072         * python/py-arch.c: Update.
4073         * python/py-breakpoint.c: Update.
4074         * python/py-cmd.c: Update.
4075         * python/py-finishbreakpoint.c: Update.
4076         * python/py-frame.c: Update.
4077         * python/py-framefilter.c: Update.
4078         * python/py-gdb-readline.c: Update.
4079         * python/py-inferior.c: Update.
4080         * python/py-infthread.c: Update.
4081         * python/py-lazy-string.c: Update.
4082         * python/py-linetable.c: Update.
4083         * python/py-objfile.c: Update.
4084         * python/py-param.c: Update.
4085         * python/py-prettyprint.c: Update.
4086         * python/py-progspace.c: Update.
4087         * python/py-record-btrace.c: Update.
4088         * python/py-record.c: Update.
4089         * python/py-symbol.c: Update.
4090         * python/py-type.c: Update.
4091         * python/py-unwind.c: Update.
4092         * python/py-utils.c: Update.
4093         * python/py-value.c: Update.
4094         * python/python.c: Update.
4095         * record-btrace.c: Update.
4096         * record-full.c: Update.
4097         * remote-fileio.c: Update.
4098         * remote.c: Update.
4099         * riscv-tdep.c: Update.
4100         * rs6000-aix-tdep.c: Update.
4101         * rs6000-tdep.c: Update.
4102         * rust-exp.y: Update.
4103         * rust-lang.c: Update.
4104         * s390-tdep.c: Update.
4105         * selftest-arch.c: Update.
4106         * solib-dsbt.c: Update.
4107         * solib-frv.c: Update.
4108         * solib-spu.c: Update.
4109         * solib-svr4.c: Update.
4110         * solib.c: Update.
4111         * sparc64-linux-tdep.c: Update.
4112         * stack.c: Update.
4113         * symfile-mem.c: Update.
4114         * symmisc.c: Update.
4115         * target.c: Update.
4116         * thread.c: Update.
4117         * top.c: Update.
4118         * tracefile-tfile.c: Update.
4119         * tui/tui.c: Update.
4120         * typeprint.c: Update.
4121         * unittests/cli-utils-selftests.c: Update.
4122         * unittests/parse-connection-spec-selftests.c: Update.
4123         * valops.c: Update.
4124         * valprint.c: Update.
4125         * value.c: Update.
4126         * varobj.c: Update.
4127         * windows-nat.c: Update.
4128         * x86-linux-nat.c: Update.
4129         * xml-support.c: Update.
4130
4131 2019-04-08  Tom Tromey  <tom@tromey.com>
4132
4133         * xml-support.c: Use C++ exception handling.
4134         * x86-linux-nat.c: Use C++ exception handling.
4135         * windows-nat.c: Use C++ exception handling.
4136         * varobj.c: Use C++ exception handling.
4137         * value.c: Use C++ exception handling.
4138         * valprint.c: Use C++ exception handling.
4139         * valops.c: Use C++ exception handling.
4140         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4141         handling.
4142         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4143         * typeprint.c: Use C++ exception handling.
4144         * tui/tui.c: Use C++ exception handling.
4145         * tracefile-tfile.c: Use C++ exception handling.
4146         * top.c: Use C++ exception handling.
4147         * thread.c: Use C++ exception handling.
4148         * target.c: Use C++ exception handling.
4149         * symmisc.c: Use C++ exception handling.
4150         * symfile-mem.c: Use C++ exception handling.
4151         * stack.c: Use C++ exception handling.
4152         * sparc64-linux-tdep.c: Use C++ exception handling.
4153         * solib.c: Use C++ exception handling.
4154         * solib-svr4.c: Use C++ exception handling.
4155         * solib-spu.c: Use C++ exception handling.
4156         * solib-frv.c: Use C++ exception handling.
4157         * solib-dsbt.c: Use C++ exception handling.
4158         * selftest-arch.c: Use C++ exception handling.
4159         * s390-tdep.c: Use C++ exception handling.
4160         * rust-lang.c: Use C++ exception handling.
4161         * rust-exp.y: Use C++ exception handling.
4162         * rs6000-tdep.c: Use C++ exception handling.
4163         * rs6000-aix-tdep.c: Use C++ exception handling.
4164         * riscv-tdep.c: Use C++ exception handling.
4165         * remote.c: Use C++ exception handling.
4166         * remote-fileio.c: Use C++ exception handling.
4167         * record-full.c: Use C++ exception handling.
4168         * record-btrace.c: Use C++ exception handling.
4169         * python/python.c: Use C++ exception handling.
4170         * python/py-value.c: Use C++ exception handling.
4171         * python/py-utils.c: Use C++ exception handling.
4172         * python/py-unwind.c: Use C++ exception handling.
4173         * python/py-type.c: Use C++ exception handling.
4174         * python/py-symbol.c: Use C++ exception handling.
4175         * python/py-record.c: Use C++ exception handling.
4176         * python/py-record-btrace.c: Use C++ exception handling.
4177         * python/py-progspace.c: Use C++ exception handling.
4178         * python/py-prettyprint.c: Use C++ exception handling.
4179         * python/py-param.c: Use C++ exception handling.
4180         * python/py-objfile.c: Use C++ exception handling.
4181         * python/py-linetable.c: Use C++ exception handling.
4182         * python/py-lazy-string.c: Use C++ exception handling.
4183         * python/py-infthread.c: Use C++ exception handling.
4184         * python/py-inferior.c: Use C++ exception handling.
4185         * python/py-gdb-readline.c: Use C++ exception handling.
4186         * python/py-framefilter.c: Use C++ exception handling.
4187         * python/py-frame.c: Use C++ exception handling.
4188         * python/py-finishbreakpoint.c: Use C++ exception handling.
4189         * python/py-cmd.c: Use C++ exception handling.
4190         * python/py-breakpoint.c: Use C++ exception handling.
4191         * python/py-arch.c: Use C++ exception handling.
4192         * printcmd.c: Use C++ exception handling.
4193         * ppc-linux-tdep.c: Use C++ exception handling.
4194         * parse.c: Use C++ exception handling.
4195         * p-valprint.c: Use C++ exception handling.
4196         * objc-lang.c: Use C++ exception handling.
4197         * mi/mi-main.c: Use C++ exception handling.
4198         * mi/mi-interp.c: Use C++ exception handling.
4199         * mi/mi-cmd-stack.c: Use C++ exception handling.
4200         * mi/mi-cmd-break.c: Use C++ exception handling.
4201         * main.c: Use C++ exception handling.
4202         * linux-thread-db.c: Use C++ exception handling.
4203         * linux-tdep.c: Use C++ exception handling.
4204         * linux-nat.c: Use C++ exception handling.
4205         * linux-fork.c: Use C++ exception handling.
4206         * linespec.c: Use C++ exception handling.
4207         * language.c: Use C++ exception handling.
4208         * jit.c: Use C++ exception handling.
4209         * infrun.c: Use C++ exception handling.
4210         * infcmd.c: Use C++ exception handling.
4211         * infcall.c: Use C++ exception handling.
4212         * inf-loop.c: Use C++ exception handling.
4213         * i386-tdep.c: Use C++ exception handling.
4214         * i386-linux-tdep.c: Use C++ exception handling.
4215         * guile/scm-value.c: Use C++ exception handling.
4216         * guile/scm-type.c: Use C++ exception handling.
4217         * guile/scm-symtab.c: Use C++ exception handling.
4218         * guile/scm-symbol.c: Use C++ exception handling.
4219         * guile/scm-pretty-print.c: Use C++ exception handling.
4220         * guile/scm-ports.c: Use C++ exception handling.
4221         * guile/scm-param.c: Use C++ exception handling.
4222         * guile/scm-math.c: Use C++ exception handling.
4223         * guile/scm-lazy-string.c: Use C++ exception handling.
4224         * guile/scm-frame.c: Use C++ exception handling.
4225         * guile/scm-disasm.c: Use C++ exception handling.
4226         * guile/scm-cmd.c: Use C++ exception handling.
4227         * guile/scm-breakpoint.c: Use C++ exception handling.
4228         * guile/scm-block.c: Use C++ exception handling.
4229         * guile/guile-internal.h: Use C++ exception handling.
4230         * gnu-v3-abi.c: Use C++ exception handling.
4231         * gdbtypes.c: Use C++ exception handling.
4232         * frame.c: Use C++ exception handling.
4233         * frame-unwind.c: Use C++ exception handling.
4234         * fbsd-tdep.c: Use C++ exception handling.
4235         * f-valprint.c: Use C++ exception handling.
4236         * exec.c: Use C++ exception handling.
4237         * event-top.c: Use C++ exception handling.
4238         * event-loop.c: Use C++ exception handling.
4239         * eval.c: Use C++ exception handling.
4240         * dwarf2read.c: Use C++ exception handling.
4241         * dwarf2loc.c: Use C++ exception handling.
4242         * dwarf2-frame.c: Use C++ exception handling.
4243         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4244         * dwarf-index-write.c: Use C++ exception handling.
4245         * dwarf-index-cache.c: Use C++ exception handling.
4246         * dtrace-probe.c: Use C++ exception handling.
4247         * disasm-selftests.c: Use C++ exception handling.
4248         * darwin-nat.c: Use C++ exception handling.
4249         * cp-valprint.c: Use C++ exception handling.
4250         * cp-support.c: Use C++ exception handling.
4251         * cp-abi.c: Use C++ exception handling.
4252         * corelow.c: Use C++ exception handling.
4253         * completer.c: Use C++ exception handling.
4254         * compile/compile-object-run.c: Use C++ exception handling.
4255         * compile/compile-object-load.c: Use C++ exception handling.
4256         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4257         * compile/compile-c-symbols.c: Use C++ exception handling.
4258         * common/selftest.c: Use C++ exception handling.
4259         * common/new-op.c: Use C++ exception handling.
4260         * cli/cli-script.c: Use C++ exception handling.
4261         * cli/cli-interp.c: Use C++ exception handling.
4262         * cli/cli-cmds.c: Use C++ exception handling.
4263         * c-varobj.c: Use C++ exception handling.
4264         * btrace.c: Use C++ exception handling.
4265         * breakpoint.c: Use C++ exception handling.
4266         * break-catch-throw.c: Use C++ exception handling.
4267         * arch-utils.c: Use C++ exception handling.
4268         * amd64-tdep.c: Use C++ exception handling.
4269         * ada-valprint.c: Use C++ exception handling.
4270         * ada-typeprint.c: Use C++ exception handling.
4271         * ada-lang.c: Use C++ exception handling.
4272         * aarch64-tdep.c: Use C++ exception handling.
4273
4274 2019-04-08  Tom Tromey  <tom@tromey.com>
4275
4276         * xml-support.c (gdb_xml_parser::parse): Update.
4277         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4278         * value.c (show_convenience): Update.
4279         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4280         (test_parse_flags_qcs): Update.
4281         * thread.c (thr_try_catch_cmd): Update.
4282         * target.c (target_translate_tls_address): Update.
4283         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4284         (info_frame_command_core, frame_apply_command_count): Update.
4285         * rust-exp.y (rust_lex_exception_test): Update.
4286         * riscv-tdep.c (riscv_print_one_register_info): Update.
4287         * remote.c (remote_target::enable_btrace): Update.
4288         * record-btrace.c (record_btrace_enable_warn): Update.
4289         * python/py-utils.c (gdbpy_convert_exception): Update.
4290         * printcmd.c (do_one_display, print_variable_and_value): Update.
4291         * mi/mi-main.c (mi_print_exception): Update.
4292         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4293         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4294         * linux-nat.c (linux_nat_target::attach): Update.
4295         * linux-fork.c (class scoped_switch_fork_info): Update.
4296         * infrun.c (displaced_step_prepare): Update.
4297         * infcall.c (call_function_by_hand_dummy): Update.
4298         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4299         * gnu-v3-abi.c (print_one_vtable): Update.
4300         * frame.c (get_prev_frame_always): Update.
4301         * f-valprint.c (info_common_command_for_block): Update.
4302         * exec.c (try_open_exec_file): Update.
4303         * exceptions.c (print_exception, exception_print)
4304         (exception_fprintf, exception_print_same): Update.
4305         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4306         * dwarf-index-cache.c (index_cache::store)
4307         (index_cache::lookup_gdb_index): Update.
4308         * darwin-nat.c (maybe_cache_shell): Update.
4309         * cp-valprint.c (cp_print_value_fields): Update.
4310         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4311         (gcc_cplus_symbol_address): Update.
4312         * compile/compile-c-symbols.c (gcc_convert_symbol)
4313         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4314         * common/selftest.c: Update.
4315         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4316         a std::string.
4317         (exception_try_scope_entry, exception_try_scope_exit): Don't
4318         declare.
4319         (struct exception_try_scope): Remove.
4320         (TRY): Don't use exception_try_scope.
4321         (struct gdb_exception): Add constructor, operator=.
4322         <what>: New method.
4323         (struct gdb_exception_RETURN_MASK_ALL)
4324         (struct gdb_exception_RETURN_MASK_ERROR)
4325         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4326         (struct gdb_quit_bad_alloc): Update.
4327         * common/common-exceptions.c (exception_none): Change
4328         initializer.
4329         (struct catcher) <state, exception>: Initialize inline.
4330         <prev>: Remove member.
4331         (current_catcher): Remove.
4332         (catchers): New global.
4333         (exceptions_state_mc_init): Simplify.
4334         (catcher_pop): Remove.
4335         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4336         (try_scope_depth, exception_try_scope_entry)
4337         (exception_try_scope_exit): Remove.
4338         (throw_exception_sjlj): Update.
4339         (exception_messages, exception_messages_size): Remove.
4340         (throw_it): Simplify.
4341         (gdb_exception_sliced_copy): Remove.
4342         (throw_exception_cxx): Update.
4343         * cli/cli-script.c (script_from_file): Update.
4344         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4345         Update.
4346         * ada-valprint.c (ada_val_print): Update.
4347         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4348         (create_excep_cond_exprs): Update.
4349
4350 2019-04-08  Tom Tromey  <tom@tromey.com>
4351
4352         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4353         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4354         (TRY, CATCH, END_CATCH): Remove some definitions.
4355         * common/common-exceptions.c: Don't use GDB_XCPT.
4356         (catcher_list_size): Remove.
4357         (throw_exception, throw_it): Simplify.
4358
4359 2019-04-05  Tom Tromey  <tom@tromey.com>
4360
4361         Revert the header-sorting patch.
4362         * ft32-tdep.c: Revert.
4363         * frv-tdep.c: Revert.
4364         * frv-linux-tdep.c: Revert.
4365         * frame.c: Revert.
4366         * frame-unwind.c: Revert.
4367         * frame-base.c: Revert.
4368         * fork-child.c: Revert.
4369         * findvar.c: Revert.
4370         * findcmd.c: Revert.
4371         * filesystem.c: Revert.
4372         * filename-seen-cache.h: Revert.
4373         * filename-seen-cache.c: Revert.
4374         * fbsd-tdep.c: Revert.
4375         * fbsd-nat.h: Revert.
4376         * fbsd-nat.c: Revert.
4377         * f-valprint.c: Revert.
4378         * f-typeprint.c: Revert.
4379         * f-lang.c: Revert.
4380         * extension.h: Revert.
4381         * extension.c: Revert.
4382         * extension-priv.h: Revert.
4383         * expprint.c: Revert.
4384         * exec.h: Revert.
4385         * exec.c: Revert.
4386         * exceptions.c: Revert.
4387         * event-top.c: Revert.
4388         * event-loop.c: Revert.
4389         * eval.c: Revert.
4390         * elfread.c: Revert.
4391         * dwarf2read.h: Revert.
4392         * dwarf2read.c: Revert.
4393         * dwarf2loc.c: Revert.
4394         * dwarf2expr.h: Revert.
4395         * dwarf2expr.c: Revert.
4396         * dwarf2-frame.c: Revert.
4397         * dwarf2-frame-tailcall.c: Revert.
4398         * dwarf-index-write.h: Revert.
4399         * dwarf-index-write.c: Revert.
4400         * dwarf-index-common.c: Revert.
4401         * dwarf-index-cache.h: Revert.
4402         * dwarf-index-cache.c: Revert.
4403         * dummy-frame.c: Revert.
4404         * dtrace-probe.c: Revert.
4405         * disasm.h: Revert.
4406         * disasm.c: Revert.
4407         * disasm-selftests.c: Revert.
4408         * dictionary.c: Revert.
4409         * dicos-tdep.c: Revert.
4410         * demangle.c: Revert.
4411         * dcache.h: Revert.
4412         * dcache.c: Revert.
4413         * darwin-nat.h: Revert.
4414         * darwin-nat.c: Revert.
4415         * darwin-nat-info.c: Revert.
4416         * d-valprint.c: Revert.
4417         * d-namespace.c: Revert.
4418         * d-lang.c: Revert.
4419         * ctf.c: Revert.
4420         * csky-tdep.c: Revert.
4421         * csky-linux-tdep.c: Revert.
4422         * cris-tdep.c: Revert.
4423         * cris-linux-tdep.c: Revert.
4424         * cp-valprint.c: Revert.
4425         * cp-support.c: Revert.
4426         * cp-namespace.c: Revert.
4427         * cp-abi.c: Revert.
4428         * corelow.c: Revert.
4429         * corefile.c: Revert.
4430         * continuations.c: Revert.
4431         * completer.h: Revert.
4432         * completer.c: Revert.
4433         * complaints.c: Revert.
4434         * coffread.c: Revert.
4435         * coff-pe-read.c: Revert.
4436         * cli-out.h: Revert.
4437         * cli-out.c: Revert.
4438         * charset.c: Revert.
4439         * c-varobj.c: Revert.
4440         * c-valprint.c: Revert.
4441         * c-typeprint.c: Revert.
4442         * c-lang.c: Revert.
4443         * buildsym.c: Revert.
4444         * buildsym-legacy.c: Revert.
4445         * build-id.h: Revert.
4446         * build-id.c: Revert.
4447         * btrace.c: Revert.
4448         * bsd-uthread.c: Revert.
4449         * breakpoint.h: Revert.
4450         * breakpoint.c: Revert.
4451         * break-catch-throw.c: Revert.
4452         * break-catch-syscall.c: Revert.
4453         * break-catch-sig.c: Revert.
4454         * blockframe.c: Revert.
4455         * block.c: Revert.
4456         * bfin-tdep.c: Revert.
4457         * bfin-linux-tdep.c: Revert.
4458         * bfd-target.c: Revert.
4459         * bcache.c: Revert.
4460         * ax-general.c: Revert.
4461         * ax-gdb.h: Revert.
4462         * ax-gdb.c: Revert.
4463         * avr-tdep.c: Revert.
4464         * auxv.c: Revert.
4465         * auto-load.c: Revert.
4466         * arm-wince-tdep.c: Revert.
4467         * arm-tdep.c: Revert.
4468         * arm-symbian-tdep.c: Revert.
4469         * arm-pikeos-tdep.c: Revert.
4470         * arm-obsd-tdep.c: Revert.
4471         * arm-nbsd-tdep.c: Revert.
4472         * arm-nbsd-nat.c: Revert.
4473         * arm-linux-tdep.c: Revert.
4474         * arm-linux-nat.c: Revert.
4475         * arm-fbsd-tdep.c: Revert.
4476         * arm-fbsd-nat.c: Revert.
4477         * arm-bsd-tdep.c: Revert.
4478         * arch-utils.c: Revert.
4479         * arc-tdep.c: Revert.
4480         * arc-newlib-tdep.c: Revert.
4481         * annotate.h: Revert.
4482         * annotate.c: Revert.
4483         * amd64-windows-tdep.c: Revert.
4484         * amd64-windows-nat.c: Revert.
4485         * amd64-tdep.c: Revert.
4486         * amd64-sol2-tdep.c: Revert.
4487         * amd64-obsd-tdep.c: Revert.
4488         * amd64-obsd-nat.c: Revert.
4489         * amd64-nbsd-tdep.c: Revert.
4490         * amd64-nbsd-nat.c: Revert.
4491         * amd64-nat.c: Revert.
4492         * amd64-linux-tdep.c: Revert.
4493         * amd64-linux-nat.c: Revert.
4494         * amd64-fbsd-tdep.c: Revert.
4495         * amd64-fbsd-nat.c: Revert.
4496         * amd64-dicos-tdep.c: Revert.
4497         * amd64-darwin-tdep.c: Revert.
4498         * amd64-bsd-nat.c: Revert.
4499         * alpha-tdep.c: Revert.
4500         * alpha-obsd-tdep.c: Revert.
4501         * alpha-nbsd-tdep.c: Revert.
4502         * alpha-mdebug-tdep.c: Revert.
4503         * alpha-linux-tdep.c: Revert.
4504         * alpha-linux-nat.c: Revert.
4505         * alpha-bsd-tdep.c: Revert.
4506         * alpha-bsd-nat.c: Revert.
4507         * aix-thread.c: Revert.
4508         * agent.c: Revert.
4509         * addrmap.c: Revert.
4510         * ada-varobj.c: Revert.
4511         * ada-valprint.c: Revert.
4512         * ada-typeprint.c: Revert.
4513         * ada-tasks.c: Revert.
4514         * ada-lang.c: Revert.
4515         * aarch64-tdep.c: Revert.
4516         * aarch64-ravenscar-thread.c: Revert.
4517         * aarch64-newlib-tdep.c: Revert.
4518         * aarch64-linux-tdep.c: Revert.
4519         * aarch64-linux-nat.c: Revert.
4520         * aarch64-fbsd-tdep.c: Revert.
4521         * aarch64-fbsd-nat.c: Revert.
4522         * aarch32-linux-nat.c: Revert.
4523
4524 2019-04-05  Tom Tromey  <tom@tromey.com>
4525
4526         * ft32-tdep.c: Sort headers.
4527         * frv-tdep.c: Sort headers.
4528         * frv-linux-tdep.c: Sort headers.
4529         * frame.c: Sort headers.
4530         * frame-unwind.c: Sort headers.
4531         * frame-base.c: Sort headers.
4532         * fork-child.c: Sort headers.
4533         * findvar.c: Sort headers.
4534         * findcmd.c: Sort headers.
4535         * filesystem.c: Sort headers.
4536         * filename-seen-cache.h: Sort headers.
4537         * filename-seen-cache.c: Sort headers.
4538         * fbsd-tdep.c: Sort headers.
4539         * fbsd-nat.h: Sort headers.
4540         * fbsd-nat.c: Sort headers.
4541         * f-valprint.c: Sort headers.
4542         * f-typeprint.c: Sort headers.
4543         * f-lang.c: Sort headers.
4544         * extension.h: Sort headers.
4545         * extension.c: Sort headers.
4546         * extension-priv.h: Sort headers.
4547         * expprint.c: Sort headers.
4548         * exec.h: Sort headers.
4549         * exec.c: Sort headers.
4550         * exceptions.c: Sort headers.
4551         * event-top.c: Sort headers.
4552         * event-loop.c: Sort headers.
4553         * eval.c: Sort headers.
4554         * elfread.c: Sort headers.
4555         * dwarf2read.h: Sort headers.
4556         * dwarf2read.c: Sort headers.
4557         * dwarf2loc.c: Sort headers.
4558         * dwarf2expr.h: Sort headers.
4559         * dwarf2expr.c: Sort headers.
4560         * dwarf2-frame.c: Sort headers.
4561         * dwarf2-frame-tailcall.c: Sort headers.
4562         * dwarf-index-write.h: Sort headers.
4563         * dwarf-index-write.c: Sort headers.
4564         * dwarf-index-common.c: Sort headers.
4565         * dwarf-index-cache.h: Sort headers.
4566         * dwarf-index-cache.c: Sort headers.
4567         * dummy-frame.c: Sort headers.
4568         * dtrace-probe.c: Sort headers.
4569         * disasm.h: Sort headers.
4570         * disasm.c: Sort headers.
4571         * disasm-selftests.c: Sort headers.
4572         * dictionary.c: Sort headers.
4573         * dicos-tdep.c: Sort headers.
4574         * demangle.c: Sort headers.
4575         * dcache.h: Sort headers.
4576         * dcache.c: Sort headers.
4577         * darwin-nat.h: Sort headers.
4578         * darwin-nat.c: Sort headers.
4579         * darwin-nat-info.c: Sort headers.
4580         * d-valprint.c: Sort headers.
4581         * d-namespace.c: Sort headers.
4582         * d-lang.c: Sort headers.
4583         * ctf.c: Sort headers.
4584         * csky-tdep.c: Sort headers.
4585         * csky-linux-tdep.c: Sort headers.
4586         * cris-tdep.c: Sort headers.
4587         * cris-linux-tdep.c: Sort headers.
4588         * cp-valprint.c: Sort headers.
4589         * cp-support.c: Sort headers.
4590         * cp-namespace.c: Sort headers.
4591         * cp-abi.c: Sort headers.
4592         * corelow.c: Sort headers.
4593         * corefile.c: Sort headers.
4594         * continuations.c: Sort headers.
4595         * completer.h: Sort headers.
4596         * completer.c: Sort headers.
4597         * complaints.c: Sort headers.
4598         * coffread.c: Sort headers.
4599         * coff-pe-read.c: Sort headers.
4600         * cli-out.h: Sort headers.
4601         * cli-out.c: Sort headers.
4602         * charset.c: Sort headers.
4603         * c-varobj.c: Sort headers.
4604         * c-valprint.c: Sort headers.
4605         * c-typeprint.c: Sort headers.
4606         * c-lang.c: Sort headers.
4607         * buildsym.c: Sort headers.
4608         * buildsym-legacy.c: Sort headers.
4609         * build-id.h: Sort headers.
4610         * build-id.c: Sort headers.
4611         * btrace.c: Sort headers.
4612         * bsd-uthread.c: Sort headers.
4613         * breakpoint.h: Sort headers.
4614         * breakpoint.c: Sort headers.
4615         * break-catch-throw.c: Sort headers.
4616         * break-catch-syscall.c: Sort headers.
4617         * break-catch-sig.c: Sort headers.
4618         * blockframe.c: Sort headers.
4619         * block.c: Sort headers.
4620         * bfin-tdep.c: Sort headers.
4621         * bfin-linux-tdep.c: Sort headers.
4622         * bfd-target.c: Sort headers.
4623         * bcache.c: Sort headers.
4624         * ax-general.c: Sort headers.
4625         * ax-gdb.h: Sort headers.
4626         * ax-gdb.c: Sort headers.
4627         * avr-tdep.c: Sort headers.
4628         * auxv.c: Sort headers.
4629         * auto-load.c: Sort headers.
4630         * arm-wince-tdep.c: Sort headers.
4631         * arm-tdep.c: Sort headers.
4632         * arm-symbian-tdep.c: Sort headers.
4633         * arm-pikeos-tdep.c: Sort headers.
4634         * arm-obsd-tdep.c: Sort headers.
4635         * arm-nbsd-tdep.c: Sort headers.
4636         * arm-nbsd-nat.c: Sort headers.
4637         * arm-linux-tdep.c: Sort headers.
4638         * arm-linux-nat.c: Sort headers.
4639         * arm-fbsd-tdep.c: Sort headers.
4640         * arm-fbsd-nat.c: Sort headers.
4641         * arm-bsd-tdep.c: Sort headers.
4642         * arch-utils.c: Sort headers.
4643         * arc-tdep.c: Sort headers.
4644         * arc-newlib-tdep.c: Sort headers.
4645         * annotate.h: Sort headers.
4646         * annotate.c: Sort headers.
4647         * amd64-windows-tdep.c: Sort headers.
4648         * amd64-windows-nat.c: Sort headers.
4649         * amd64-tdep.c: Sort headers.
4650         * amd64-sol2-tdep.c: Sort headers.
4651         * amd64-obsd-tdep.c: Sort headers.
4652         * amd64-obsd-nat.c: Sort headers.
4653         * amd64-nbsd-tdep.c: Sort headers.
4654         * amd64-nbsd-nat.c: Sort headers.
4655         * amd64-nat.c: Sort headers.
4656         * amd64-linux-tdep.c: Sort headers.
4657         * amd64-linux-nat.c: Sort headers.
4658         * amd64-fbsd-tdep.c: Sort headers.
4659         * amd64-fbsd-nat.c: Sort headers.
4660         * amd64-dicos-tdep.c: Sort headers.
4661         * amd64-darwin-tdep.c: Sort headers.
4662         * amd64-bsd-nat.c: Sort headers.
4663         * alpha-tdep.c: Sort headers.
4664         * alpha-obsd-tdep.c: Sort headers.
4665         * alpha-nbsd-tdep.c: Sort headers.
4666         * alpha-mdebug-tdep.c: Sort headers.
4667         * alpha-linux-tdep.c: Sort headers.
4668         * alpha-linux-nat.c: Sort headers.
4669         * alpha-bsd-tdep.c: Sort headers.
4670         * alpha-bsd-nat.c: Sort headers.
4671         * aix-thread.c: Sort headers.
4672         * agent.c: Sort headers.
4673         * addrmap.c: Sort headers.
4674         * ada-varobj.c: Sort headers.
4675         * ada-valprint.c: Sort headers.
4676         * ada-typeprint.c: Sort headers.
4677         * ada-tasks.c: Sort headers.
4678         * ada-lang.c: Sort headers.
4679         * aarch64-tdep.c: Sort headers.
4680         * aarch64-ravenscar-thread.c: Sort headers.
4681         * aarch64-newlib-tdep.c: Sort headers.
4682         * aarch64-linux-tdep.c: Sort headers.
4683         * aarch64-linux-nat.c: Sort headers.
4684         * aarch64-fbsd-tdep.c: Sort headers.
4685         * aarch64-fbsd-nat.c: Sort headers.
4686         * aarch32-linux-nat.c: Sort headers.
4687
4688 2019-04-04  Tom Tromey  <tom@tromey.com>
4689
4690         * varobj.c (varobj_create): Update.
4691         * rust-exp.y (struct rust_parser) <update_innermost_block,
4692         lookup_symbol>: New methods.
4693         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4694         Rename.
4695         (rust_parser::rust_lookup_type)
4696         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4697         * printcmd.c (display_command, do_one_display): Update.
4698         * parser-defs.h (struct parser_state) <parser_state>: Add
4699         "tracker" parameter.
4700         (block_tracker): New member.
4701         (class innermost_block_tracker) <innermost_block_tracker>: Add
4702         "types" parameter.
4703         <reset>: Remove method.
4704         (innermost_block): Don't declare.
4705         (null_post_parser): Update.
4706         * parse.c (innermost_block): Remove global.
4707         (write_dollar_variable): Update.
4708         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4709         Remove "tracker_types" parameter.
4710         (parse_expression): Add "tracker" parameter.
4711         (parse_expression_for_completion): Update.
4712         (null_post_parser): Add "tracker" parameter.
4713         * p-exp.y: Update rules.
4714         * m2-exp.y: Update rules.
4715         * language.h (struct language_defn) <la_post_parser>: Add
4716         "tracker" parameter.
4717         * go-exp.y: Update rules.
4718         * f-exp.y: Update rules.
4719         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4720         parameter.
4721         * d-exp.y: Update rules.
4722         * c-exp.y: Update rules.
4723         * breakpoint.c (set_breakpoint_condition): Create an
4724         innermost_block_tracker.
4725         (watch_command_1): Likewise.
4726         * ada-lang.c (resolve): Add "tracker" parameter.
4727         (resolve_subexp): Likewise.
4728         * ada-exp.y (write_var_from_sym): Update.
4729
4730 2019-04-04  Tom Tromey  <tom@tromey.com>
4731
4732         * type-stack.h: New file.
4733         * type-stack.c: New file.
4734         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4735         type-stack.h.
4736         (insert_into_type_stack, insert_type, push_type, push_type_int)
4737         (insert_type_address_space, pop_type, pop_type_int)
4738         (pop_typelist, pop_type_stack, append_type_stack)
4739         (push_type_stack, get_type_stack, push_typelist)
4740         (follow_type_instance_flags, follow_types): Don't declare.
4741         * parse.c (type_stack): Remove global.
4742         (parse_exp_in_context): Update.
4743         (insert_into_type_stack, insert_type, push_type, push_type_int)
4744         (insert_type_address_space, pop_type, pop_type_int)
4745         (pop_typelist, pop_type_stack, append_type_stack)
4746         (push_type_stack, get_type_stack, push_typelist)
4747         (follow_type_instance_flags, follow_types): Remove (moved to
4748         type-stack.c).
4749         * f-exp.y (type_stack): New global.
4750         Update rules.
4751         (push_kind_type, f_parse): Update.
4752         * d-exp.y (type_stack): New global.
4753         Update rules.
4754         (d_parse): Update.
4755         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4756         Update rules.
4757         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4758         (HFILES_NO_SRCDIR): Add type-stack.h.
4759
4760 2019-04-04  Tom Tromey  <tom@tromey.com>
4761
4762         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4763         (rust_parser::convert_ast_to_expression, rust_parse)
4764         (rust_lex_test_completion, rust_lex_tests): Update.
4765         * parser-defs.h (struct expr_completion_state): New.
4766         (struct parser_state) <parser_state>: Add completion parameter.
4767         <mark_struct_expression, mark_completion_tag>: New methods.
4768         <parse_completion, m_completion_state>: New members.
4769         (prefixify_expression, null_post_parser): Update.
4770         (mark_struct_expression, mark_completion_tag): Don't declare.
4771         * parse.c (parse_completion, expout_last_struct)
4772         (expout_tag_completion_type, expout_completion_name): Remove
4773         globals.
4774         (parser_state::mark_struct_expression)
4775         (parser_state::mark_completion_tag): Now methods.
4776         (prefixify_expression): Add last_struct parameter.
4777         (prefixify_subexp): Likewise.
4778         (parse_exp_1): Update.
4779         (parse_exp_in_context): Add cstate parameter.  Update.
4780         (parse_expression_for_completion): Create an
4781         expr_completion_state.
4782         (null_post_parser): Add "completion" parameter.
4783         * p-exp.y: Update rules.
4784         (yylex): Update.
4785         * language.h (struct language_defn) <la_post_parser>: Add
4786         "completing" parameter.
4787         * go-exp.y: Update rules.
4788         (lex_one_token): Update.
4789         * expression.h (parse_completion): Don't declare.
4790         * d-exp.y: Update rules.
4791         (lex_one_token): Update rules.
4792         * c-exp.y: Update rules.
4793         (lex_one_token): Update.
4794         * ada-lang.c (resolve): Add "parse_completion" parameter.
4795         (resolve_subexp): Likewise.
4796         (ada_resolve_function): Likewise.
4797
4798 2019-04-04  Tom Tromey  <tom@tromey.com>
4799
4800         * parser-defs.h (struct parser_state) <start_arglist,
4801         end_arglist>: New methods.
4802         <arglist_len, m_funcall_chain>: New members.
4803         (arglist_len, start_arglist, end_arglist): Don't declare.
4804         * parse.c (arglist_len, funcall_chain): Remove global.
4805         (start_arglist, end_arglist): Remove functions.
4806         (parse_exp_in_context): Update.
4807         * p-exp.y: Update rules.
4808         * m2-exp.y: Update rules.
4809         * go-exp.y: Update rules.
4810         * f-exp.y: Update rules.
4811         * d-exp.y: Update rules.
4812         * c-exp.y: Update rules.
4813
4814 2019-04-04  Tom Tromey  <tom@tromey.com>
4815
4816         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4817         lex_operator, push_back>: New methods.
4818         Update all rules.
4819         (rust_parser::lex_hex, lex_escape): Rename and update.
4820         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4821         (rust_parser::lex_operator): Rename and update.
4822         (rust_parser::lex_number, rustyylex, rustyyerror)
4823         (rust_lex_test_init, rust_lex_test_sequence)
4824         (rust_lex_test_push_back, rust_lex_tests): Update.
4825         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4826         parameter.
4827         <lexptr, prev_lexptr>: New members.
4828         (lexptr, prev_lexptr): Don't declare.
4829         * parse.c (lexptr, prev_lexptr): Remove globals.
4830         (parse_exp_in_context): Update.
4831         * p-exp.y (yylex, yyerror): Update.
4832         * m2-exp.y (parse_number, yylex, yyerror): Update.
4833         * go-exp.y (lex_one_token, yyerror): Update.
4834         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4835         * d-exp.y (lex_one_token, yyerror): Update.
4836         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4837         (lex_one_token, yyerror): Update.
4838         * ada-lex.l (YY_INPUT): Update.
4839         (rewind_to_char): Update.
4840         * ada-exp.y (yyerror): Update.
4841
4842 2019-04-04  Tom Tromey  <tom@tromey.com>
4843
4844         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4845         * parser-defs.h (struct parser_state) <parser_state>: Add new
4846         parameter.
4847         <comma_terminates>: New member.
4848         (comma_terminates): Don't declare global.
4849         * parse.c (comma_terminates): Remove global.
4850         (parse_exp_in_context): Update.
4851         * p-exp.y (yylex): Update.
4852         * m2-exp.y (yylex): Update.
4853         * go-exp.y (lex_one_token): Update.
4854         * f-exp.y (yylex): Update.
4855         * d-exp.y (lex_one_token): Update.
4856         * c-exp.y (lex_one_token): Update.
4857         * ada-lex.l: Update.
4858
4859 2019-04-04  Tom Tromey  <tom@tromey.com>
4860
4861         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4862         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4863         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4864         * parser-defs.h (paren_depth): Don't declare.
4865         * parse.c (paren_depth): Remove global.
4866         (parse_exp_in_context): Update.
4867         * p-exp.y (paren_depth): New global.
4868         (pascal_parse): Initialize it.
4869         * m2-exp.y (paren_depth): New global.
4870         (m2_parse): Initialize it.
4871         * go-exp.y (paren_depth): New global.
4872         (go_parse): Initialize it.
4873         * f-exp.y (paren_depth): New global.
4874         (f_parse): Initialize it.
4875         * d-exp.y (paren_depth): New global.
4876         (d_parse): Initialize it.
4877         * c-exp.y (paren_depth): New global.
4878         (c_parse): Initialize it.
4879         * ada-lex.l (paren_depth): New global.
4880         (lexer_init): Initialize it.
4881
4882 2019-04-04  Tom Tromey  <tom@tromey.com>
4883
4884         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4885         (rust_parser::convert_ast_to_type)
4886         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4887         * parser-defs.h (struct parser_state) <parser_state>: Add
4888         parameters.  Initialize new members.
4889         <expression_context_block, expression_context_pc>: New members.
4890         * parse.c (expression_context_block, expression_context_pc):
4891         Remove globals.
4892         (parse_exp_in_context): Update.
4893         * p-exp.y: Update all rules.
4894         (yylex): Update.
4895         * m2-exp.y: Update all rules.
4896         (yylex): Update.
4897         * go-exp.y (yylex): Update.
4898         * f-exp.y (yylex): Update.
4899         * d-exp.y: Update all rules.
4900         (yylex): Update.
4901         * c-exp.y: Update all rules.
4902         (lex_one_token, classify_name, yylex, c_parse): Update.
4903         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4904
4905 2019-04-04  Tom Tromey  <tom@tromey.com>
4906
4907         * gdbarch.h, gdbarch.c: Rebuild.
4908         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4909         * stap-probe.h:
4910         (struct stap_parse_info): Replace "parser_state" with
4911         "expr_builder".
4912         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4913         (parser_state): New class.
4914         * parse.c (expr_builder): Rename.
4915         (expr_builder::release): Rename.
4916         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4917         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4918         (write_exp_elt_longcst, write_exp_elt_floatcst)
4919         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4920         (write_exp_string_vector, write_exp_bitstring)
4921         (write_exp_msymbol, mark_struct_expression)
4922         (write_dollar_variable)
4923         (insert_type_address_space, increase_expout_size): Replace
4924         "parser_state" with "expr_builder".
4925         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4926         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4927         "parser_state" with "expr_builder".
4928
4929 2019-04-04  Tom Tromey  <tom@tromey.com>
4930
4931         * rust-exp.y: Replace "parse_language" with method call.
4932         * p-exp.y:
4933         (yylex): Replace "parse_language" with method call.
4934         * m2-exp.y:
4935         (yylex): Replace "parse_language" with method call.
4936         * go-exp.y (classify_name): Replace "parse_language" with method
4937         call.
4938         * f-exp.y (yylex): Replace "parse_language" with method call.
4939         * d-exp.y (lex_one_token): Replace "parse_language" with method
4940         call.
4941         * c-exp.y:
4942         (lex_one_token, classify_name, yylex): Replace "parse_language"
4943         with method call.
4944         * ada-exp.y (find_primitive_type, type_char)
4945         (type_system_address): Replace "parse_language" with method call.
4946
4947 2019-04-04  Tom Tromey  <tom@tromey.com>
4948
4949         * rust-exp.y: Replace "parse_gdbarch" with method call.
4950         * parse.c (write_dollar_variable, insert_type_address_space):
4951         Replace "parse_gdbarch" with method call.
4952         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4953         call.
4954         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4955         call.
4956         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4957         "parse_gdbarch" with method call.
4958         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4959         with method call.
4960         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4961         "parse_gdbarch" with method call.
4962         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4963         "parse_gdbarch" with method call.
4964         * c-exp.y (parse_type, parse_number, classify_name): Replace
4965         "parse_gdbarch" with method call.
4966         * ada-lex.l: Replace "parse_gdbarch" with method call.
4967         * ada-exp.y (parse_type, find_primitive_type, type_char)
4968         (type_system_address): Replace "parse_gdbarch" with method call.
4969
4970 2019-04-04  Tom Tromey  <tom@tromey.com>
4971
4972         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4973         * stap-probe.c (stap_parse_argument): Update.
4974         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4975         initial_size parameter.
4976         * rust-exp.y (rust_lex_tests): Update.
4977         * parse.c (parser_state): Update.
4978         (parse_exp_in_context): Update.
4979         * parser-defs.h (struct parser_state) <parser_state>: Remove
4980         "initial_size" parameter.
4981
4982 2019-04-04  Tom Tromey  <tom@tromey.com>
4983
4984         * parser-defs.h (increase_expout_size): Don't declare.
4985         * parse.c (increase_expout_size): Now static.
4986
4987 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4988
4989         * gnu-nat.c (gnu_nat_target::wait): Fix
4990         target_waitstatus_to_string call.
4991
4992 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * eval.c (evaluate_subexp_standard): Handle internal functions
4995         during Fortran function call handling.
4996
4997 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4998
4999         * NEWS: Mention new internal functions.
5000         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
5001         (read_base_type): Use dwarf2_init_complex_target_type.
5002         * value.c (creal_internal_fn): New function.
5003         (cimag_internal_fn): New function.
5004         (_initialize_values): Register new internal functions.
5005
5006 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5007
5008         * infrun.c (stop_all_threads): If debug_infrun, always
5009         trace the wait status after wait_one, using
5010         target_waitstatus_to_string and target_pid_to_str.
5011         (handle_inferior_event): Replace various trace of
5012         wait status kind by a single trace.
5013         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5014         wait status kind image by target_waitstatus_to_string.
5015         * target/waitstatus.c (target_waitstatus_to_string): Fix
5016         obsolete comment.
5017
5018 2019-04-01  Tom Tromey  <tromey@adacore.com>
5019
5020         PR symtab/23331:
5021         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5022
5023 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5024             Pedro Alves  <palves@redhat.com>
5025
5026         * top.c (quit_force): Call 'finalize_values'.
5027         * value.c (finalize_values): New function.
5028         * value.h (finalize_values): Declare.
5029
5030 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5031
5032         * NEWS: Announce $_gdb_major and $_gdb_minor.
5033
5034         * top.c (init_gdb_version_vars): New function.
5035         (gdb_init): Call init_gdb_version_vars.
5036
5037 2019-03-29  Tom Tromey  <tromey@adacore.com>
5038
5039         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5040         help text.  Remove dead code.
5041
5042 2019-03-29  Keith Seitz  <keiths@redhat.com>
5043
5044         From Siddhesh Poyarekar:
5045         * f-lang.h (f77_get_upperbound): Return LONGEST.
5046         (f77_get_lowerbound): Likewise.
5047         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5048         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5049         print them.
5050         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5051         plongest to format print it.
5052         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5053         (f77_get_upperbound): Likewise.
5054         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5055         LOWER_BOUND to LONGEST.
5056         (f77_create_arrayprint_offset_tbl): Likewise.
5057
5058 2019-03-29  Keith Seitz  <keiths@redhat.com>
5059
5060         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5061         %s/pulongest for TYPE_LENGTH instead of %d in format
5062         strings.
5063         * ada-typerint.c (ada_print_type): Likewise.
5064         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5065         * compile/compile-c-support.c (generate_register_struct): Likewise.
5066         * gdbtypes.c (recursive_dump_type): Likewise.
5067         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5068         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5069         instead of %d in format strings.
5070         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5071         to std::min to ULONGEST.
5072         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5073         instead of %d in format strings.
5074         * tracepoint.c (info_scope_command): Likewise.
5075         * typeprint.c (print_offset_data::update)
5076         (print_offset_data::finish): Likewise.
5077         * xtensa-tdep.c (xtensa_store_return_value)
5078         (xtensa_push_dummy_call): Likewise.
5079
5080 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5081
5082         * windows-nat.c (display_selector): Fixed format specifications
5083         for 64-bit Cygwin.
5084
5085 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5086
5087         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5088
5089 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5090
5091         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5092         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5093         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5094         (nios2_linux_init_abi): Install it.
5095
5096 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5097
5098         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5099
5100 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5101
5102         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5103
5104 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5105             Tom Tromey  <tromey@adacore.com>
5106
5107         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5108
5109 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5110
5111         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5112         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5113         method to compute the bounds of range types. Also print "[evaluated]"
5114         if the bounds' values come from a dynamic evaluation.
5115
5116 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5117
5118         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5119         whitespace when pretty printing is on.
5120
5121 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5122
5123         * ppc-linux-nat.c: Add include.
5124
5125 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5126
5127         * NEWS: Mention AArch64 Pointer Authentication.
5128
5129 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5130
5131         * arm-linux-nat.c: Add include.
5132
5133 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5134
5135         * source-cache.c (source_cache::get_source_lines): Re-read
5136         fullname after calling open_source_file.
5137
5138 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5139
5140         * NEWS: Mention TLS support for FreeBSD.
5141
5142 2019-03-25  Tom Tromey  <tromey@adacore.com>
5143
5144         * minsyms.c (BUNCH_SIZE): Update comment.
5145         (~minimal_symbol_reader): Remove old comment.
5146         (compact_minimal_symbols): Update comment.
5147         (minimal_symbol_reader::install): Remove old comment.  Update
5148         other comments.
5149
5150 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5151
5152         * s390-linux-nat.c: Add include.
5153
5154 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5155
5156         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5157         Call linux_get_hwcap.
5158         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5159         Likewise.
5160         (aarch64_linux_get_hwcap): Remove function.
5161         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5162         declaration.
5163         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5164         linux_get_hwcap.
5165         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5166         * linux-tdep.c (linux_get_hwcap): Add function.
5167         (linux_get_hwcap2): Likewise.
5168         * linux-tdep.h (linux_get_hwcap): Add declaration.
5169         (linux_get_hwcap2): Likewise.
5170         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5171         (ppc_linux_get_hwcap2): Likewise.
5172         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5173         linux_get_hwcap.
5174         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5175         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5176         (ppc_linux_nat_target::read_description): Likewise.
5177         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5178         * s390-linux-nat.c: Likewise.
5179         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5180
5181 2019-03-24  Tom Tromey  <tom@tromey.com>
5182
5183         * ada-lang.c (standard_lookup): Simplify initialization.
5184         (ada_lookup_symbol_nonlocal): Simplify return.
5185         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5186         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5187         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5188         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5189         initialization.
5190         * solib.c (solib_global_lookup): Simplify.
5191         * symtab.c (null_block_symbol): Remove.
5192         (symbol_cache_lookup): Simplify returns.
5193         (lookup_language_this): Simplify returns.
5194         (lookup_symbol_aux): Simplify return.
5195         (lookup_local_symbol): Simplify returns.
5196         (lookup_global_symbol_from_objfile): Simplify return.
5197         (lookup_symbol_in_objfile_symtabs)
5198         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5199         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5200         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5201         * cp-namespace.c (cp_lookup_bare_symbol)
5202         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5203         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5204         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5205         (cp_lookup_symbol_via_imports): Simplify initialization.
5206         (find_symbol_in_baseclass): Likewise.
5207         * symtab.h (null_block_symbol): Remove.
5208         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5209         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5210         (d_lookup_symbol_module): Likewise.
5211         (find_symbol_in_baseclass): Simplify initialization.
5212
5213 2019-03-24  Tom Tromey  <tom@tromey.com>
5214
5215         * expression.h: Don't include symtab.h.
5216         (struct block): Forward declare.
5217
5218 2019-03-24  Tom Tromey  <tom@tromey.com>
5219
5220         * c-exp.y (typebase): Remove casts.
5221         * gdbtypes.c (lookup_unsigned_typename, )
5222         (lookup_signed_typename): Remove cast.
5223         * eval.c (parse_to_comma_and_eval): Remove cast.
5224         * parse.c (write_dollar_variable): Remove cast.
5225         * block.h (struct block) <superblock>: Now const.
5226         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5227         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5228         (map_block): Make "block" const.
5229         * symfile.h (struct quick_symbol_functions)
5230         <map_matching_symbols>: Constify block argument to "callback".
5231         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5232         const.
5233         (find_pc_sect_compunit_symtab): Make "b" const.
5234         (find_symbol_at_address): Likewise.
5235         (search_symbols): Likewise.
5236         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5237         (dw2_debug_names_lookup_symbol): Likewise.
5238         (dw2_map_matching_symbols): Update.
5239         * p-valprint.c (pascal_val_print): Remove "block".
5240         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5241         (aux_add_nonlocal_symbols): Make "block" const.
5242         (resolve_subexp): Remove cast.
5243         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5244         const.
5245         (iterate_over_file_blocks): Likewise.
5246         * f-exp.y (%union) <bval>: Remove.
5247         * coffread.c (patch_opaque_types): Make "b" const.
5248         * spu-tdep.c (spu_catch_start): Make "block" const.
5249         * c-valprint.c (print_unpacked_pointer): Remove "block".
5250         * symmisc.c (dump_symtab_1): Make "b" const.
5251         (block_depth): Make "block" const.
5252         * d-exp.y (%union) <bval>: Remove.
5253         * cp-support.h (cp_lookup_rtti_type): Update.
5254         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5255         * psymtab.c (psym_lookup_symbol): Make "block" const.
5256         (maintenance_check_psymtabs): Make "b" const.
5257         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5258         (enumerate_locals, enumerate_args): Update.
5259         * python/py-symtab.c (stpy_global_block): Make "block" const.
5260         (stpy_static_block): Likewise.
5261         * inline-frame.c (block_starting_point_at): Make "new_block"
5262         const.
5263         * block.c (find_block_in_blockvector): Make return type const.
5264         (blockvector_for_pc_sect): Make "b" const.
5265         (find_block_in_blockvector): Make "b" const.
5266
5267 2019-03-23  Tom Tromey  <tom@tromey.com>
5268
5269         * varobj.c (varobj_create): Update.
5270         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5271         * printcmd.c (display_command, do_one_display): Don't reset
5272         innermost_block.
5273         * parser-defs.h (enum innermost_block_tracker_type): Move to
5274         expression.h.
5275         (innermost_block): Update comment.
5276         * parse.c (parse_exp_1): Add tracker_types parameter.
5277         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5278         tracker_types parameter.  Reset innermost_block.
5279         (parse_exp_in_context): Remove.
5280         (parse_expression_for_completion): Update.
5281         * objfiles.c (~objfile): Don't reset expression_context_block or
5282         innermost_block.
5283         * expression.h (enum innermost_block_tracker_type): Move from
5284         parser-defs.h.
5285         (parse_exp_1): Add tracker_types parameter.
5286         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5287         reset innermost_block.
5288
5289 2019-03-23  Tom Tromey  <tom@tromey.com>
5290
5291         * objfiles.h: Include bcache.h.
5292
5293 2019-03-23  Tom Tromey  <tom@tromey.com>
5294
5295         * linespec.c (get_current_search_block): Use
5296         scoped_restore_current_language.
5297         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5298
5299 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5300             Jiong Wang  <jiong.wang@arm.com>
5301
5302         * aarch64-linux-tdep.c
5303         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5304         section.
5305         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5306
5307 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5308             Jiong Wang  <jiong.wang@arm.com>
5309
5310         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5311         instructions.
5312         (aarch64_analyze_prologue_test): Add PACIASP test.
5313         (aarch64_prologue_prev_register): Unmask PC value.
5314
5315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5316             Jiong Wang  <jiong.wang@arm.com>
5317
5318         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5319         (aarch64_dwarf2_prev_register): Unmask PC value.
5320         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5321         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5322         DW_CFA_AARCH64_negate_ra_state.
5323         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5324
5325 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5326             Jiong Wang  <jiong.wang@arm.com>
5327
5328         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5329         registers.
5330         (aarch64_pseudo_register_name): Likewise.
5331         (aarch64_pseudo_register_type): Likewise.
5332         (aarch64_pseudo_register_reggroup_p): Likewise.
5333         (aarch64_gdbarch_init): Add pauth registers.
5334         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5335         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5336         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5337         (struct gdbarch_tdep): Add regnum for ra_state.
5338
5339 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5340             Jiong Wang  <jiong.wang@arm.com>
5341
5342         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5343
5344 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5345             Jiong Wang  <jiong.wang@arm.com>
5346
5347         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5348         function.
5349         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5350         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5351         (aarch64_gdbarch_init): Add puth registers.
5352         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5353         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5354         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5355
5356 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5357             Jiong Wang  <jiong.wang@arm.com>
5358
5359         * aarch64-linux-nat.c
5360         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5361         * aarch64-linux-tdep.c
5362         (aarch64_linux_core_read_description): Likewise.
5363         (aarch64_linux_get_hwcap): New function.
5364         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5365         (aarch64_linux_get_hwcap): New declaration.
5366
5367 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5368             Jiong Wang  <jiong.wang@arm.com>
5369
5370         * aarch64-linux-nat.c
5371         (aarch64_linux_nat_target::read_description): Add pauth param.
5372         * aarch64-linux-tdep.c
5373         (aarch64_linux_core_read_description): Likewise.
5374         * aarch64-tdep.c (struct target_desc): Add in pauth.
5375         (aarch64_read_description): Add pauth param.
5376         (aarch64_gdbarch_init): Likewise.
5377         * aarch64-tdep.h (aarch64_read_description): Likewise.
5378         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5379         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5380         * features/Makefile: Add new files.
5381         * features/aarch64-pauth.c: New file.
5382         * features/aarch64-pauth.xml: New file.
5383
5384 2019-03-20  Tom Tromey  <tromey@adacore.com>
5385
5386         * infrun.c (handle_inferior_event): Rename from
5387         handle_inferior_event_1.  Create a scoped_value_mark.
5388         (handle_inferior_event): Remove.
5389
5390 2019-03-19  Tom Tromey  <tromey@adacore.com>
5391
5392         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5393         * infrun.h (print_stop_event): Add "displays" parameter.
5394         * infrun.c (print_stop_event): Add "displays" parameter.
5395
5396 2019-03-19  Pedro Alves  <palves@redhat.com>
5397
5398         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5399         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5400         to -1.  Fix TABs vs spaces.
5401         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5402         * tui/tui-out.h (tui_ui_out) Add intro comments.
5403         <m_line, m_start_of_line>: In-class initialize, and add describing
5404         comment.
5405
5406 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5407
5408         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5409         variable names.
5410         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5411
5412 2019-03-18  Pedro Alves  <palves@redhat.com>
5413             Eli Zaretskii <eliz@gnu.org>
5414
5415         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5416         m_line and m_start_of_line.
5417
5418 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5419
5420         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5421         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5422         it returns a newline.  This fixes a regression in TU mode, whereby
5423         the next line is output on the same screen line as the user input.
5424
5425 2019-03-18  Tom Tromey  <tromey@adacore.com>
5426
5427         * minsyms.c (minimal_symbol_reader::install): Remove call to
5428         obstack_blank.
5429
5430 2019-03-18  Pedro Alves  <palves@redhat.com>
5431
5432         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5433         New globals.
5434         (apply_style): New, factored out from ...
5435         (apply_ansi_escape): ... this.  Handle reverse video mode.
5436         (tui_set_reverse_mode): New function.
5437         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5438         * tui/tui-winsource.c (tui_show_source_line): Use
5439         tui_set_reverse_mode instead of setting A_STANDOUT.
5440         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5441         New setter methods.
5442
5443 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5444
5445         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5446         Handle tabs.
5447
5448 2019-03-18  Tom Tromey  <tromey@adacore.com>
5449
5450         * ada-lang.c (empty_array): Add "high" parameter.
5451         (ada_evaluate_subexp): Update.
5452
5453 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5454
5455         * unittests/string_view-selftests.c: Define
5456         _initialize_string_view_selftests unconditionally.
5457
5458 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5459
5460         PR gdb/24350
5461         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5462
5463 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5464
5465         PR gdb/24351
5466         * windows-nat.c (display_selector): Fix format specifiers.
5467
5468 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5469
5470         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5471         tui_refill_source_window instead of tui_refresh_win, to update the
5472         current execution line.  This fixes redisplay of the current line
5473         when stepping through the code with "next" or "step".
5474
5475 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5476
5477         * source-cache.c (source_cache::get_source_lines): Call
5478         find_source_lines to initialize s->nlines.  This fixes vertical
5479         scrolling of TUI source window when the DOWN arrow is pressed.
5480
5481 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5482
5483         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5484         linux-thread-db.c (_initialize_thread_db): Likewise.
5485
5486 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5487
5488         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5489         wclrtoeol in tui_show_source_line".  This reverts changes made in
5490         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5491
5492 2019-03-15  Tom Tromey  <tom@tromey.com>
5493
5494         * symtab.h (struct minimal_symbol): Derive from
5495         general_symbol_info.
5496         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5497         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5498         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5499         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5500         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5501         (MSYMBOL_SEARCH_NAME): Update.
5502         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5503         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5504         * minsyms.c (minimal_symbol_reader::record_full): Update.
5505
5506 2019-03-15  Tom Tromey  <tom@tromey.com>
5507
5508         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5509
5510 2019-03-15  Tom Tromey  <tom@tromey.com>
5511
5512         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5513         unique_xmalloc_ptr.
5514         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5515         Update.
5516         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5517         (build_minimal_symbol_hash_tables)
5518         (minimal_symbol_reader::install): Update.
5519
5520 2019-03-15  Tom Tromey  <tom@tromey.com>
5521
5522         * symtab.c (create_demangled_names_hash): Update.
5523         (symbol_set_names): Update.
5524         * objfiles.h (struct objfile_per_bfd_storage)
5525         <demangled_names_hash>: Now an htab_up.
5526         * objfiles.c (objfile_per_bfd_storage): Simplify.
5527
5528 2019-03-15  Tom Tromey  <tom@tromey.com>
5529
5530         * objfiles.h (struct objfile_per_bfd_storage): Declare
5531         destructor.
5532         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5533         New.
5534         (get_objfile_bfd_data): Use new.  Don't initialize
5535         language_of_main.
5536         (free_objfile_per_bfd_storage): Remove.
5537         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5538
5539 2019-03-15  Tom Tromey  <tom@tromey.com>
5540
5541         * symfile.c (reread_symbols): Update.
5542         * objfiles.c (objfile::objfile): Update.
5543         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5544         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5545         comment.
5546         (minimal_symbol_reader::install): Update.
5547         (terminate_minimal_symbol_table): Remove.
5548         * jit.c (jit_object_close_impl): Update.
5549
5550 2019-03-15  Tom Tromey  <tom@tromey.com>
5551
5552         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5553         initializations.
5554
5555 2019-03-15  Tom Tromey  <tom@tromey.com>
5556
5557         * objfiles.h (struct objfile_per_bfd_storage)
5558         <demangled_hash_languages>: Now a bitset.
5559         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5560         (lookup_minimal_symbol): Update.
5561
5562 2019-03-15  Tom Tromey  <tom@tromey.com>
5563
5564         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5565         Don't return the symbol.
5566         * coffread.c (record_minimal_symbol): Use record_full.
5567
5568 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5569
5570         The MS-Windows port of ncurses fails to switch to a color pair if
5571         one or both of the colors are the implicit default colors.  This
5572         change records the default colors when TUI is initialized, and
5573         then specifies them explicitly when a color pair uses the default
5574         colors.  This allows color styling in TUI mode on MS-Windows.
5575
5576         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5577         ncurses_norm_attr.
5578         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5579         colors in ncurses_norm_attr.
5580         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5581         "none", replace it with the default color recorded in
5582         ncurses_norm_attr.
5583
5584 2019-03-14  Tom Tromey  <tromey@adacore.com>
5585
5586         * source-cache.h (class source_cache) <get_source_lines>: Return
5587         std::string.
5588         * source-cache.c (source_cache::extract_lines): Handle case where
5589         first_pos==npos.  Return std::string.
5590         (source_cache::get_source_lines): Update.
5591
5592 2019-03-14  Tom Tromey  <tromey@adacore.com>
5593
5594         * NEWS: Add item for "style sources" commands.
5595         * source-cache.c (source_cache::get_source_lines): Check
5596         source_styling.
5597         * cli/cli-style.c (source_styling): New global.
5598         (_initialize_cli_style): Add "style sources" commands.
5599         (show_style_sources): New function.
5600         * cli/cli-style.h (source_styling): Declare.
5601
5602 2019-03-14  Pedro Alves  <palves@redhat.com>
5603             Tom Tromey  <tromey@adacore.com>
5604
5605         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5606         * tui/tui-winsource.c (tui_refill_source_window): New function,
5607         from...
5608         (tui_horizontal_source_scroll): ... here.  Move some logic.
5609         * cli/cli-style.c (set_style_enabled): Notify new observable.
5610         * tui/tui-hooks.c (tui_redisplay_source): New function.
5611         (tui_attach_detach_observers): Attach or detach
5612         tui_redisplay_source.
5613         * observable.h (source_styling_changed): New observable.
5614         * observable.c: Define source_styling_changed observable.
5615
5616 2019-03-13  Tom Tromey  <tromey@adacore.com>
5617
5618         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5619         (i386_gnu_nat_target::store_registers): Update.
5620         * target-debug.h (target_debug_print_std_string): New macro.
5621         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5622         * windows-tdep.c (display_one_tib): Update.
5623         * tui/tui-stack.c (tui_make_status_line): Update.
5624         * top.c (print_inferior_quit_action): Update.
5625         * thread.c (thr_try_catch_cmd): Update.
5626         (add_thread_with_info): Update.
5627         (thread_target_id_str): Update.
5628         (thr_try_catch_cmd): Update.
5629         (thread_command): Update.
5630         (thread_find_command): Update.
5631         * record-btrace.c (record_btrace_target::info_record)
5632         (record_btrace_resume_thread, record_btrace_target::resume)
5633         (record_btrace_cancel_resume, record_btrace_step_thread)
5634         (record_btrace_target::wait, record_btrace_target::wait)
5635         (record_btrace_target::wait, record_btrace_target::stop): Update.
5636         * progspace.c (print_program_space): Update.
5637         * process-stratum-target.c
5638         (process_stratum_target::thread_address_space): Update.
5639         * linux-fork.c (linux_fork_mourn_inferior)
5640         (detach_checkpoint_command, info_checkpoints_command)
5641         (linux_fork_context): Update.
5642         (linux_fork_detach): Update.
5643         (class scoped_switch_fork_info): Update.
5644         (delete_checkpoint_command): Update.
5645         * infrun.c (follow_fork_inferior): Update.
5646         (follow_fork_inferior): Update.
5647         (proceed_after_vfork_done): Update.
5648         (handle_vfork_child_exec_or_exit): Update.
5649         (follow_exec): Update.
5650         (displaced_step_prepare_throw): Update.
5651         (displaced_step_restore): Update.
5652         (start_step_over): Update.
5653         (resume_1): Update.
5654         (clear_proceed_status_thread): Update.
5655         (proceed): Update.
5656         (print_target_wait_results): Update.
5657         (do_target_wait): Update.
5658         (context_switch): Update.
5659         (stop_all_threads): Update.
5660         (restart_threads): Update.
5661         (finish_step_over): Update.
5662         (handle_signal_stop): Update.
5663         (switch_back_to_stepped_thread): Update.
5664         (keep_going_pass_signal): Update.
5665         (print_exited_reason): Update.
5666         (normal_stop): Update.
5667         * inferior.c (inferior_pid_to_str): Change return type.
5668         (print_selected_inferior): Update.
5669         (add_inferior): Update.
5670         (detach_inferior): Update.
5671         * dummy-frame.c (fprint_dummy_frames): Update.
5672         * dcache.c (dcache_info_1): Update.
5673         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5674         (btrace_fetch, btrace_clear): Update.
5675         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5676         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5677         type.
5678         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5679         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5680         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5681         * gdbarch.c, gdbarch.h: Rebuild.
5682         * gdbarch.sh (core_pid_to_str): Change return type.
5683         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5684         return type.
5685         (windows_nat_target::pid_to_str): Change return type.
5686         (windows_delete_thread): Update.
5687         (windows_nat_target::attach): Update.
5688         (windows_nat_target::files_info): Update.
5689         * target-delegates.c: Rebuild.
5690         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5691         return type.
5692         (sol_thread_target::pid_to_str): Change return type.
5693         * remote.c (class remote_target) <pid_to_str>: Change return
5694         type.
5695         (remote_target::pid_to_str): Change return type.
5696         (extended_remote_target::attach, remote_target::remote_stop_ns)
5697         (remote_target::remote_notif_remove_queued_reply)
5698         (remote_target::push_stop_reply, remote_target::disable_btrace):
5699         Update.
5700         (extended_remote_target::attach): Update.
5701         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5702         type.
5703         (gdbsim_target::pid_to_str): Change return type.
5704         * ravenscar-thread.c (struct ravenscar_thread_target)
5705         <pid_to_str>: Change return type.
5706         (ravenscar_thread_target::pid_to_str): Change return type.
5707         * procfs.c (class procfs_target) <pid_to_str>: Change return
5708         type.
5709         (procfs_target::pid_to_str): Change return type.
5710         (procfs_target::attach): Update.
5711         (procfs_target::detach): Update.
5712         (procfs_target::fetch_registers): Update.
5713         (procfs_target::store_registers): Update.
5714         (procfs_target::wait): Update.
5715         (procfs_target::files_info): Update.
5716         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5717         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5718         return type.
5719         (nto_procfs_target::pid_to_str): Change return type.
5720         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5721         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5722         return type.
5723         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5724         (exit_lwp): Update.
5725         (attach_proc_task_lwp_callback, get_detach_signal)
5726         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5727         (linux_nat_target::resume, wait_lwp, stop_callback)
5728         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5729         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5730         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5731         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5732         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5733         type.
5734         (inf_ptrace_target::attach): Update.
5735         (inf_ptrace_target::files_info): Update.
5736         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5737         type.
5738         (go32_nat_target::pid_to_str): Change return type.
5739         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5740         (gnu_nat_target::wait): Update.
5741         (gnu_nat_target::wait): Update.
5742         (gnu_nat_target::resume): Update.
5743         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5744         (fbsd_nat_target::wait): Update.
5745         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5746         type.
5747         (darwin_nat_target::attach): Update.
5748         * corelow.c (class core_target) <pid_to_str>: Change return type.
5749         (core_target::pid_to_str): Change return type.
5750         * target.c (normal_pid_to_str): Change return type.
5751         (default_pid_to_str): Likewise.
5752         (target_pid_to_str): Change return type.
5753         (target_translate_tls_address): Update.
5754         (target_announce_detach): Update.
5755         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5756         return type.
5757         (bsd_uthread_target::pid_to_str): Change return type.
5758         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5759         type.
5760         (bsd_kvm_target::pid_to_str): Change return type.
5761         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5762         return type.
5763         (aix_thread_target::pid_to_str): Change return type.
5764         * target.h (struct target_ops) <pid_to_str>: Change return type.
5765         (target_pid_to_str, normal_pid_to_str): Likewise.
5766         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5767         type.
5768         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5769         type.
5770         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5771         return type.
5772         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5773         type.
5774         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5775         type.
5776         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5777         return type.
5778
5779 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5780
5781         * NEWS: Mention that the new default MI version is 3.  Mention
5782         changes to the output of commands and events that deal with
5783         multi-location breakpoints.
5784         * breakpoint.c: Include "mi/mi-out.h".
5785         (print_one_breakpoint): Change output syntax if using MI version
5786         >= 3.
5787         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5788         New.
5789         (mi_multi_location_breakpoint_output_fixed): New.
5790         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5791         (mi_cmd_fix_multi_location_breakpoint_output): New.
5792         (mi_multi_location_breakpoint_output_fixed): New.
5793         * mi/mi-cmds.c (mi_cmds): Register command
5794         -fix-multi-location-breakpoint-output.
5795         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5796         interpreter "mi".
5797
5798 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5799
5800         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5801         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5802         instantiate mi_ui_out based on interpreter name.
5803         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5804         * mi/mi-main.c (mi_load_progress): Likewise.
5805
5806 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5807
5808         * NEWS: Combine separate "New targets" sections for 8.3.
5809
5810 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5811
5812         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5813         (ppcfbsd_init_abi): Install gdbarch
5814         "fetch_tls_load_module_address" and "get_thread_local_address"
5815         methods.
5816
5817 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5818
5819         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5820         (riscv_fbsd_init_abi): Install gdbarch
5821         "fetch_tls_load_module_address" and "get_thread_local_address"
5822         methods.
5823
5824 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5825
5826         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5827         (i386fbsd_init_abi): Install gdbarch
5828         "fetch_tls_load_module_address" and "get_thread_local_address"
5829         methods.
5830
5831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5832
5833         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5834         (amd64fbsd_init_abi): Install gdbarch
5835         "fetch_tls_load_module_address" and "get_thread_local_address"
5836         methods.
5837
5838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5839
5840         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5841         (struct fbsd_pspace_data): New type.
5842         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5843         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5844         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5845         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5846         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5847
5848 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5849
5850         * gdbtypes.c (lookup_struct_elt): New function.
5851         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5852         * gdbtypes.h (struct struct_elt): New type.
5853         (lookup_struct_elt): New prototype.
5854
5855 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5856
5857         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5858         remove disabled code block.
5859
5860 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5861
5862         * gdbarch.sh (get_thread_local_address): New method.
5863         * gdbarch.h, gdbarch.c: Regenerate.
5864         * target.c (target_translate_tls_address): Use
5865         gdbarch_get_thread_local_address if present instead of
5866         target::get_thread_local_address.
5867
5868 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5869
5870         * target.h (target::get_thread_local_address): Update comment.
5871
5872 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5873
5874         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5875         objfile->separate_debug_objfile_backlink if not NULL.
5876
5877 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5878
5879         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5880         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5881         (amd64bsd_store_inferior_registers): Likewise.
5882         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5883         Enable segment base registers.
5884         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5885         PT_GETFSBASE and PT_GETGSBASE.
5886         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5887         PT_SETGSBASE.
5888         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5889         segment base registers.
5890         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5891
5892 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5893
5894         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5895         Update calls to i386_target_description to add 'segments'
5896         parameter.
5897         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5898         add segment base registers.
5899         * arch/i386.c (i386_create_target_description): Add 'segments'
5900         parameter to enable segment base registers.
5901         * arch/i386.h (i386_create_target_description): Likewise.
5902         * features/i386/32bit-segments.xml: New file.
5903         * features/i386/32bit-segments.c: Generate.
5904         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5905         call to i386_target_description to add 'segments' parameter.
5906         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5907         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5908         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5909         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5910         if feature is present.
5911         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5912         Add 'segments' parameter to call to i386_target_description.
5913         (i386_target_description): Add 'segments' parameter to enable
5914         segment base registers.
5915         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5916         to call to i386_target_description.
5917         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5918         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5919         Define I386_NUM_REGS.
5920         (i386_target_description): Add 'segments' parameter to enable
5921         segment base registers.
5922
5923 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5924
5925         PR/24325
5926         * source-cache.c: #undef open and close, to avoid unresolved
5927         externals during linking.
5928
5929 2019-03-12  Tom Tromey  <tromey@adacore.com>
5930
5931         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5932         const.  Add initializers.
5933         (_initialize_remote): Don't initialize ptid globals.
5934
5935 2019-03-12  Pedro Alves  <palves@redhat.com>
5936
5937         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5938
5939 2019-03-12  Pedro Alves  <palves@redhat.com>
5940
5941         * cp-name-parser.y (main): Remove unused 'len' variable.
5942
5943 2019-03-12  Tom Tromey  <tromey@adacore.com>
5944
5945         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5946         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5947
5948 2019-03-12  Tom Tromey  <tromey@adacore.com>
5949
5950         * linux-nat.c (iterate_over_lwps): Update.
5951         (stop_callback): Remove parameter.
5952         (stop_wait_callback, detach_callback, resume_set_callback)
5953         (select_singlestep_lwp_callback, set_ignore_sigint)
5954         (status_callback, resumed_callback, resume_clear_callback)
5955         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5956         data parameter.
5957         (linux_nat_target::detach, linux_nat_target::resume)
5958         (linux_stop_and_wait_all_lwps, select_event_lwp)
5959         (linux_nat_filter_event, linux_nat_wait_1)
5960         (linux_nat_target::kill, linux_nat_target::stop)
5961         (linux_nat_target::stop): Update.
5962         (linux_nat_resume_callback): Change type.
5963         (resume_stopped_resumed_lwps, count_events_callback)
5964         (select_event_lwp_callback): Likewise.
5965         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5966         * arm-linux-nat.c (struct update_registers_data): Remove.
5967         (update_registers_callback): Change type.
5968         (arm_linux_insert_hw_breakpoint1): Update.
5969         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5970         parameter.
5971         (x86_linux_dr_set_addr): Update.
5972         (x86_linux_dr_set_control): Update.
5973         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5974         (iterate_over_lwps): Use gdb::function_view.
5975         * nat/aarch64-linux-hw-point.c (struct
5976         aarch64_dr_update_callback_param): Remove.
5977         (debug_reg_change_callback): Change type.
5978         (aarch64_notify_debug_reg_change): Update.
5979         * s390-linux-nat.c (s390_refresh_per_info): Update.
5980
5981 2019-03-11  Tom Tromey  <tromey@adacore.com>
5982
5983         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5984         redundant assignment to "this_cu".
5985
5986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5987
5988         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5989
5990 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5991
5992         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5993         from...
5994         (rank_one_type): ... this.
5995
5996 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5997
5998         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5999         from...
6000         (rank_one_type): ... this.
6001
6002 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6003
6004         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
6005         from...
6006         (rank_one_type): ... this.
6007
6008 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6009
6010         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6011         from...
6012         (rank_one_type): ... this.
6013
6014 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6015
6016         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6017         from...
6018         (rank_one_type): ... this.
6019
6020 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6021
6022         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6023         from...
6024         (rank_one_type): ... this.
6025
6026 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6027
6028         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6029         from...
6030         (rank_one_type): ... this.
6031
6032 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6033
6034         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6035         from...
6036         (rank_one_type): ... this.
6037
6038 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6039
6040         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6041         from...
6042         (rank_one_type): ... this.
6043
6044 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6045
6046         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6047         from...
6048         (rank_one_type): ... this.
6049
6050 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6051
6052         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6053         from...
6054         (rank_one_type): ... this.
6055
6056 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6057
6058         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6059         from...
6060         (rank_one_type): ... this.
6061
6062 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6063
6064         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6065         inferior-events' shows the example events.
6066
6067 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6068
6069         Support styling on native MS-Windows console
6070
6071         PR/24315
6072         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6073         on MS-Windows if $TERM is not defined.
6074
6075         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6076
6077         * posix-hdep.c (gdb_console_fputs):
6078         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6079         functions.
6080         * ui-file.h (gdb_console_fputs): Add prototype.
6081
6082         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6083         back to fputs only if the former returns zero.
6084
6085 2019-03-07  Tom Tromey  <tom@tromey.com>
6086
6087         * symmisc.c (print_symbol_bcache_statistics): Update.
6088         (print_objfile_statistics): Update.
6089         * symfile.c (allocate_symtab): Update.
6090         * stabsread.c: Don't include bcache.h.
6091         * psymtab.h (struct psymbol_bcache): Don't declare.
6092         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6093         (psymbol_bcache_init, psymbol_bcache_free)
6094         (psymbol_bcache_get_bcache): Don't declare.
6095         * psymtab.c (struct psymbol_bcache): Remove.
6096         (psymtab_storage::psymtab_storage): Update.
6097         (psymtab_storage::~psymtab_storage): Update.
6098         (psymbol_bcache_init, psymbol_bcache_free)
6099         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6100         (add_psymbol_to_bcache): Update.
6101         (allocate_psymtab): Update.
6102         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6103         macro_cache>: No longer pointers.
6104         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6105         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6106         * macrotab.c (macro_bcache): Update.
6107         * macroexp.c: Don't include bcache.h.
6108         * gdbtypes.c (check_types_worklist): Update.
6109         (types_deeply_equal): Remove TRY/CATCH.  Update.
6110         * elfread.c (elf_symtab_read): Update.
6111         * dwarf2read.c: Don't include bcache.h.
6112         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6113         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6114         (print_bcache_statistics, bcache_memory_used): Don't declare.
6115         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6116         methods.  Rename all data members.
6117         * bcache.c (struct bcache): Move to bcache.h.
6118         (bcache::expand_hash_table): Rename from expand_hash_table.
6119         (bcache): Remove.
6120         (bcache::insert): Rename from bcache_full.
6121         (bcache::compare): Rename from bcache_compare.
6122         (bcache_xmalloc): Remove.
6123         (bcache::~bcache): Rename from bcache_xfree.
6124         (bcache::print_statistics): Rename from print_bcache_statistics.
6125         (bcache::memory_used): Rename from bcache_memory_used.
6126
6127 2019-03-07  Pedro Alves  <palves@redhat.com>
6128
6129         * infrun.c (normal_stop): Also check for
6130         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6131
6132 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6133
6134         * f-lang.c (value_from_host_double): Moved to...
6135         * value.c (value_from_host_double): ...here.
6136         * value.h (value_from_host_double): Declare.
6137         * guile/scm-math.c (vlscm_convert_typed_number): Use
6138         value_from_host_double.
6139         (vlscm_convert_number): Likewise.
6140         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6141         * python/py-value.c (convert_value_from_python): Likewise.
6142
6143 2019-03-06  Tom Tromey  <tom@tromey.com>
6144
6145         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6146
6147 2019-03-06  Tom Tromey  <tom@tromey.com>
6148
6149         * utils.h (free_current_contents): Don't declare.
6150         * utils.c (free_current_contents): Remove.
6151
6152 2019-03-06  Tom Tromey  <tom@tromey.com>
6153
6154         * top.c (quit_force): Update.
6155         * main.c (captured_command_loop): Update.
6156         * common/new-op.c (operator new): Update.
6157         * common/common-exceptions.c (struct catcher)
6158         <save_cleanup_chain>: Remove member.
6159         (exceptions_state_mc_init): Update.
6160         (exception_try_scope_entry): Return nullptr.
6161         (exception_try_scope_exit, exception_rethrow)
6162         (throw_exception_sjlj, throw_exception_cxx): Update.
6163         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6164         (all_cleanups, do_cleanups, discard_cleanups)
6165         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6166         (restore_cleanups, restore_final_cleanups): Don't declare.
6167         (do_final_cleanups): Remove parameter.
6168         * common/cleanups.c (cleanup_chain, make_cleanup)
6169         (make_cleanup_dtor, all_cleanups, do_cleanups)
6170         (discard_my_cleanups, discard_cleanups)
6171         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6172         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6173         (null_cleanup): Remove.
6174         (do_final_cleanups): Remove parameter.
6175
6176 2019-03-06  Tom Tromey  <tom@tromey.com>
6177
6178         * remote.c (remote_target::remote_parse_stop_reply): Use
6179         unique_xmalloc_ptr.
6180
6181 2019-03-06  Tom Tromey  <tom@tromey.com>
6182
6183         * stabsread.c (struct stabs_field_info): Rename from field_info.
6184         <list, fnlist>: Add initializers.
6185         <obstack>: New member.
6186         (read_member_functions, read_struct_fields, read_baseclasses):
6187         Allocate on obstack.  Don't use cleanups.
6188         (read_one_struct_field, read_member_functions, read_struct_fields)
6189         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6190         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6191         (read_struct_type): Update.
6192
6193 2019-03-06  Tom Tromey  <tom@tromey.com>
6194
6195         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6196         * common/filestuff.h (make_cleanup_close): Don't declare.
6197         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6198         Remove.
6199
6200 2019-03-06  Tom Tromey  <tom@tromey.com>
6201
6202         * solib-aix.c: Use make_scope_exit.
6203
6204 2019-03-06  Tom Tromey  <tom@tromey.com>
6205
6206         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6207         Use make_scope_exit.
6208
6209 2019-03-06  Tom Tromey  <tom@tromey.com>
6210
6211         * solib-svr4.c (disable_probes_interface): Remove parameter.
6212         (svr4_handle_solib_event): Use make_scope_exit.
6213
6214 2019-03-06  Tom Tromey  <tom@tromey.com>
6215
6216         * remote.c (struct stop_reply_deleter): Remove.
6217         (stop_reply_up): Update.
6218         (struct stop_reply): Derive from notif_event.  Don't typedef.
6219         <regcache>: Now a std::vector.
6220         (stop_reply_xfree): Remove.
6221         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6222         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6223         (remote_target::discard_pending_stop_replies): Use delete.
6224         (remote_target::remote_parse_stop_reply): Update.
6225         (remote_target::process_stop_reply): Update.
6226         * remote-notif.h (struct notif_event): Add virtual destructor.
6227         Remove "dtr" member.
6228         (struct notif_client) <alloc_event>: Return a unique_ptr.
6229         (notif_event_xfree): Don't declare.
6230         (notif_event_up): New typedef.
6231         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6232         (notif_event_xfree, do_notif_event_xfree): Remove.
6233         (remote_notif_state_xfree): Update.
6234
6235 2019-03-06  Tom Tromey  <tom@tromey.com>
6236
6237         * infrun.c (displaced_step_clear_cleanup): Now a
6238         forward_scope_exit type.
6239         (displaced_step_prepare_throw): Update.
6240         (displaced_step_fixup): Update.
6241
6242 2019-03-06  Tom Tromey  <tom@tromey.com>
6243
6244         * inferior.h (class inferior): Update comment.
6245         * gdbthread.h (class thread_info): Update comment.
6246
6247 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6248             Tom Tromey  <tom@tromey.com>
6249
6250         * stabsread.h (struct stab_section_list): Remove.
6251         (coffstab_build_psymtabs): Update.
6252         * dbxread.c (symbuf_sections): Now a std::vector.
6253         (sect_idx): New global.
6254         (fill_symbuf): Update.
6255         (coffstab_build_psymtabs): Change type of stabsects parameter.
6256         Update.
6257         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6258         std::vector.
6259         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6260         (coff_locate_sections): Update.
6261         (coff_symfile_read): Remove cleanups.  Update.
6262         (init_stringtab): Add storage parameter.
6263         (free_stringtab, free_stringtab_cleanup): Remove.
6264         (init_lineno): Add storage parameter.
6265         (free_linetab, free_linetab_cleanup): Remove.
6266
6267 2019-03-06  Pedro Alves  <palves@redhat.com>
6268
6269         * linux-fork.c (fork_info::clobber_regs): Delete.
6270         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6271         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6272         comment.  Adjust.
6273         (scoped_switch_fork_info::scoped_switch_fork_info)
6274         (checkpoint_command, linux_fork_context): Adjust
6275         fork_save_infrun_state calls.
6276
6277 2019-03-06  Pedro Alves  <palves@redhat.com>
6278
6279         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6280         (inf_has_multiple_threads): Return 'bool' and rewrite using
6281         inferior_info::threads().
6282
6283 2019-03-06  Pedro Alves  <palves@redhat.com>
6284
6285         * linux-fork.c: Include <list>.
6286         (fork_list): Now a std::list instance.
6287         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6288         (forks_exist_p, find_last_fork): Adjust.
6289         (new_fork): Delete.
6290         (one_fork_p): New.
6291         (add_fork): Adjust.
6292         (free_fork): Delete, folded into fork_info::~fork_info().
6293         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6294         Adjust.
6295         (init_fork_list): Delete.
6296         (linux_fork_killall, linux_fork_mourn_inferior)
6297         (linux_fork_detach, info_checkpoints_command): Adjust.
6298         (_initialize_linux_fork): No longer call init_fork_list.
6299
6300 2019-03-06  Pedro Alves  <palves@redhat.com>
6301
6302         * linux-fork.c (new_fork): New, split out of ...
6303         (add_fork): ... this.  Return void.  Move "first fork" special
6304         case from here, to ...
6305         (checkpoint_command): ... here.
6306         * linux-linux.h (add_fork): Return void.
6307
6308 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6309
6310         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6311
6312 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6313             Chris January  <chris.january@arm.com>
6314             David Lecomber  <david.lecomber@arm.com>
6315
6316         * f-exp.y: New token, UNOP_INTRINSIC.
6317         (exp): New pattern using UNOP_INTRINSIC token.
6318         (f77_keywords): Add 'abs' keyword.
6319         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6320         (value_from_host_double): New function.
6321         (evaluate_subexp_f): Support UNOP_ABS.
6322
6323 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6324
6325         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6326         types.
6327
6328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6329
6330         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6331         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6332         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6333
6334 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6335
6336         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6337
6338 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6339             Chris January  <chris.january@arm.com>
6340
6341         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6342         * f-exp.y: Define 'KIND' token.
6343         (exp): New pattern for KIND expressions.
6344         (ptype): Handle types with a kind extension.
6345         (direct_abs_decl): Extend to spot kind extensions.
6346         (f77_keywords): Add 'kind' to the list.
6347         (push_kind_type): New function.
6348         (convert_to_kind_type): New function.
6349         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6350         * parse.c (operator_length_standard): Likewise.
6351         * parser-defs.h (enum type_pieces): Add tp_kind.
6352         * std-operator.def: Add UNOP_KIND.
6353
6354 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6355
6356         * f-exp.y (f_parse): Set yydebug.
6357
6358 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6359
6360         * f-lang.c (evaluate_subexp_f): New function.
6361         (exp_descriptor_f): New global.
6362         (f_language_defn): Use exp_descriptor_f instead of
6363         exp_descriptor_standard.
6364
6365 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6366
6367         * f-exp.y (struct token): Add comments.
6368         (dot_ops): Remove uppercase versions and the end marker.
6369         (f77_keywords): Likewise.
6370         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6371         entries in the dot_ops array are case insensitive, and use
6372         strncasecmp to compare strings.  Also some whitespace cleanup in
6373         this area.  Similar for the f77_keywords array, except entries in
6374         this list might be case sensitive.
6375
6376 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6377
6378         * f-exp.y (struct f77_boolean_val): Add comments.
6379         (boolean_values): Remove uppercase versions, and end marker.
6380         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6381         and use strncasecmp to achieve case insensitivity.  Additionally,
6382         perform whitespace cleanup around this code.
6383
6384 2019-03-06  Tom Tromey  <tromey@adacore.com>
6385
6386         * remote-sim.c (gdbsim_target_open): Use result of
6387         gdb_argv::release.
6388
6389 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6390         Dirk Schubert  <dirk.schubert@arm.com>
6391         Chris January  <chris.january@arm.com>
6392
6393         * eval.c (evaluate_subexp_standard): Call Fortran argument
6394         wrapping logic.
6395         * f-lang.c (struct value): A value which can be passed into a
6396         Fortran function call.
6397         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6398         where appropriate.
6399         (struct type): Value ready for a Fortran function call.
6400         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6401         is needed.
6402         * f-lang.h (fortran_argument_convert): Declaration.
6403         (fortran_preserve_arg_pointer): Declaration.
6404         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6405
6406 2019-03-05  Tom Tromey  <tromey@adacore.com>
6407
6408         * python/py-prettyprint.c (print_string_repr): Remove #if.
6409         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6410
6411 2019-03-05  Tom Tromey  <tromey@adacore.com>
6412
6413         * target.c (the_dummy_target): Move later.  Change type to
6414         "dummy_target".
6415         (initialize_targets): Don't initialize the_dummy_target.
6416
6417 2019-03-05  Tom Tromey  <tromey@adacore.com>
6418
6419         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6420         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6421
6422 2019-03-05  Tom Tromey  <tromey@adacore.com>
6423
6424         * windows-nat.c (windows_nat_target::attach)
6425         (windows_nat_target::detach): Don't call gdb_flush.
6426         * valprint.c (generic_val_print, val_print, val_print_string):
6427         Don't call gdb_flush.
6428         * utils.c (defaulted_query): Don't call gdb_flush.
6429         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6430         * target.c (target_announce_detach): Don't call gdb_flush.
6431         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6432         * remote.c (extended_remote_target::attach): Don't call
6433         gdb_flush.
6434         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6435         * printcmd.c (do_examine): Don't call gdb_flush.
6436         (info_display_command): Don't call gdb_flush.
6437         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6438         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6439         * memattr.c (info_mem_command): Don't call gdb_flush.
6440         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6441         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6442         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6443         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6444         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6445         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6446         (gnu_nat_target::detach): Don't call gdb_flush.
6447         * f-valprint.c (f_val_print): Don't call gdb_flush.
6448         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6449         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6450         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6451         gdb_flush.
6452         * c-valprint.c (c_val_print): Don't call gdb_flush.
6453         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6454
6455 2019-03-05  Tom Tromey  <tromey@adacore.com>
6456
6457         * varobj.c (update_dynamic_varobj_children): Update.
6458         (install_default_visualizer): Use reset, not release.
6459         * value.c (set_internalvar): Update.
6460         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6461         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6462         ATTRIBUTE_UNUSED_RESULT.
6463
6464 2019-03-05  Tom Tromey  <tromey@adacore.com>
6465
6466         * remote.c (class scoped_remote_fd) <release>: Add
6467         ATTRIBUTE_UNUSED_RESULT.
6468
6469 2019-03-05  Tom Tromey  <tromey@adacore.com>
6470
6471         * macroexp.c (struct macro_buffer) <release>: Add
6472         ATTRIBUTE_UNUSED_RESULT.
6473
6474 2019-03-05  Tom Tromey  <tromey@adacore.com>
6475
6476         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6477         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6478         ATTRIBUTE_UNUSED_RESULT.
6479
6480 2019-03-05  Tom Tromey  <tromey@adacore.com>
6481
6482         * common/scoped_fd.h (class scoped_fd) <release>: Add
6483         ATTRIBUTE_UNUSED_RESULT.
6484
6485 2019-03-05  Tom Tromey  <tromey@adacore.com>
6486
6487         * parser-defs.h (struct parser_state) <release>: Add
6488         ATTRIBUTE_UNUSED_RESULT.
6489
6490 2019-03-05  Tom Tromey  <tromey@adacore.com>
6491
6492         * utils.h (class gdb_argv) <release>: Add
6493         ATTRIBUTE_UNUSED_RESULT.
6494         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6495
6496 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6497
6498         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6499         for-loop range, to avoid compiler warnings.
6500
6501         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6502         avoid compiler warnings about unused variables.
6503
6504         * NEWS: Mention end of support for native debugging on MS-Windows
6505         before XP.
6506
6507         PR gdb/24292
6508         * common/netstuff.c:
6509         * gdbserver/gdbreplay.c
6510         * gdbserver/remote-utils.c:
6511         * ser-tcp.c:
6512         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6513         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6514         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6515         'getaddrinfo' and 'freeaddrinfo' were not available before
6516         Windows XP, and mingw.org's MinGW headers by default define
6517         _WIN32_WINNT to 0x500.
6518
6519 2019-03-01  Gary Benson <gbenson@redhat.com>
6520
6521         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6522
6523 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6524             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6525
6526         PR gdb/8527
6527         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6528         set_sigint_trap, clear_sigint_trap.
6529
6530 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6531
6532         * target.c (target_detach): Clear the regcache and the
6533         frame cache.
6534
6535 2019-02-27  Pedro Alves  <palves@redhat.com>
6536
6537         * utils.c (set_screen_size): When we cap the height/width sizes,
6538         tweak the corresponding command variable to show "unlimited":
6539
6540 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6541             Pedro Alves  <palves@redhat.com>
6542
6543         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6544         before calling rl_set_screen_size.
6545
6546 2019-02-27  Tom Tromey  <tromey@adacore.com>
6547
6548         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6549         define.
6550         * python/py-value.c: Remove Python 2.4 workaround.
6551         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6552         workaround.
6553         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6554         Python 2.4 workaround.
6555         * python/python-internal.h: Remove Python 2.4 comment.
6556         (Py_ssize_t): Don't define.
6557         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6558         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6559         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6560         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6561         * python/python.c (do_start_initialization): Remove Python 2.4
6562         workaround.
6563         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6564         (print_children): Remove Python 2.4 workaround.
6565         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6566         workaround.
6567         (CHARBUFFERPROC_NAME): Remove.
6568         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6569         Python 2.4 workaround.
6570
6571 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6572
6573         * NEWS: Note minimum Python version.
6574
6575 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6576
6577         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6578         code from these functions.  Remove corresponding ifdefs.  Use
6579         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6580         Remove gotos and target of gotos.
6581         (infpy_search_memory): Likewise.
6582
6583 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6584
6585         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6586         (hppa_gdbarch_init): Don't register deleted functions with
6587         gdbarch.
6588
6589 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6590
6591         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6592         (h8300_unwind_sp): Delete.
6593         (h8300_dummy_id): Delete.
6594         (h8300_gdbarch_init): Don't register deleted functions with
6595         gdbarch.
6596
6597 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6598
6599         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6600         (ft32_unwind_pc): Delete.
6601         (ft32_unwind_sp): Delete.
6602         (ft32_gdbarch_init): Don't register deleted functions with
6603         gdbarch.
6604
6605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6606
6607         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6608         (frv_unwind_pc): Delete.
6609         (frv_unwind_sp): Delete.
6610         (frv_gdbarch_init): Don't register deleted functions with
6611         gdbarch.
6612
6613 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6614
6615         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6616         (riscv_unwind_pc): Delete.
6617         (riscv_unwind_sp): Delete.
6618         (riscv_gdbarch_init): Don't register deleted functions with
6619         gdbarch.
6620
6621 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6622
6623         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6624         (csky_unwind_pc): Delete.
6625         (csky_unwind_sp): Delete.
6626         (csky_gdbarch_init): Don't register deleted functions with
6627         gdbarch.
6628
6629 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6630
6631         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6632         (cris_unwind_pc): Delete.
6633         (cris_unwind_sp): Delete.
6634         (cris_gdbarch_init): Don't register deleted functions with
6635         gdbarch.
6636
6637 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6638
6639         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6640         (bfin_unwind_pc): Delete.
6641         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6642
6643 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6644
6645         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6646         (arm_unwind_pc): Delete.
6647         (arm_unwind_sp): Delete.
6648         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6649
6650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6651
6652         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6653         (arc_unwind_pc): Delete.
6654         (arc_unwind_sp): Delete.
6655         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6656
6657 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6658
6659         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6660         (alpha_unwind_pc): Delete.
6661         (alpha_gdbarch_init): Don't register deleted functions with
6662         gdbarch.
6663
6664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6665
6666         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6667         (aarch64_unwind_pc): Delete.
6668         (aarch64_unwind_sp): Delete.
6669         (aarch64_gdbarch_init): Don't register deleted functions with
6670         gdbarch.
6671
6672 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6673
6674         * gdbtypes.c (type_align): Don't consider static members when
6675         computing structure alignment.
6676
6677 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6678
6679         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6680         return 0 for other types.
6681         * arch-utils.c (default_type_align): Always return 0.
6682         * gdbarch.h: Regenerate.
6683         * gdbarch.sh (type_align): Extend comment.
6684         * gdbtypes.c (type_align): Add additional comments, always call
6685         gdbarch_type_align before applying the default rules.
6686         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6687         generic code will then apply a suitable default.
6688         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6689         types, return 0 for other types.
6690
6691 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6692
6693         * NEWS: Create a new section for the next release branch.
6694         Rename the section of the current branch, now that it has
6695         been cut.
6696
6697 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6698
6699         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6700         * version.in: Bump version to 8.3.50.DATE-git.
6701
6702 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6703
6704         * aix-thread.c (ptid_cmp): Remove unused variable.
6705         (get_signaled_thread): Likewise.
6706         (store_regs_user_thread): Likewise.
6707         (store_regs_kernel_thread): Likewise.
6708         (fetch_regs_kernel_thread): Remove shadowed variable.
6709
6710 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6711
6712         * features/riscv/32bit-cpu.xml: Add register numbers.
6713         * features/riscv/32bit-fpu.c: Regenerate.
6714         * features/riscv/32bit-fpu.xml: Add register numbers.
6715         * features/riscv/64bit-cpu.xml: Add register numbers.
6716         * features/riscv/64bit-fpu.c: Regenerate.
6717         * features/riscv/64bit-fpu.xml: Add register numbers.
6718
6719 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6720
6721         * NEWS: Mention two argument form of gdb.Value constructor.
6722         * python/py-value.c (convert_buffer_and_type_to_value): New
6723         function.
6724         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6725         Add support for handling an optional second argument.  Call
6726         convert_buffer_and_type_to_value as appropriate.
6727         * python/python-internal.h (Py_buffer_deleter): New struct.
6728         (Py_buffer_up): New typedef.
6729
6730 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6731
6732         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6733         instead of releasing ownership.
6734
6735 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6736
6737         * dwarf2read.c (open_and_init_dwp_file): Call
6738         elf_numsections instead of bfd_count_sections to initialize
6739         dwp_file->num_sections.
6740
6741 2019-02-25  Tom Tromey  <tromey@adacore.com>
6742
6743         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6744
6745 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6746
6747         * gcore.in: Add '--readnever' option when invoking GDB.
6748
6749 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6750
6751         * MAINTAINERS: Update my email address.
6752
6753 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6754
6755         * build-id.c (build_id_to_debug_bfd_1): New function.
6756         (build_id_to_debug_bfd): Look for separate debug file in
6757         sysroot.
6758
6759 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6760
6761         * gdbarch.sh: Update the copyright year range that is placed into
6762         generated files.
6763
6764 2019-02-22  Keith Seitz  <keiths@redhat.com>
6765
6766         PR symtab/23853
6767         * linespec.c (create_sals_line_offset): Search for the default
6768         symtab's filename instead of its fullname.
6769
6770 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6771
6772         * NEWS: Update style defaults.
6773
6774 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6775
6776         * main.c (captured_main_1): Disable styling in batch mode.
6777
6778 2019-02-20  Tom Tromey  <tom@tromey.com>
6779
6780         * symtab.c (symtab_symbol_info): Fix typos.
6781
6782 2019-02-20  Tom Tromey  <tromey@adacore.com>
6783
6784         * findcmd.c (_initialize_mem_search): Use upper case for
6785         metasyntactic variables.
6786
6787 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6788
6789         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6790         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6791
6792 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6793
6794         * top.h (source_file_name): Change to std::string.
6795         * top.c (source_file_name): Likewise.
6796         (command_line_input): Adjust.
6797         * cli/cli-script.c (script_from_file): Adjust.
6798
6799 2019-02-19  Tom Tromey  <tromey@adacore.com>
6800
6801         * ravenscar-thread.c
6802         (ravenscar_thread_target::update_thread_list): Don't call
6803         ada_build_task_list.
6804         * ada-lang.h (ada_build_task_list): Don't declare.
6805         * ada-tasks.c (struct ada_tasks_inferior_data)
6806         <task_list_valid_p>: Now bool.
6807         (read_known_tasks, ada_task_list_changed)
6808         (ada_tasks_invalidate_inferior_data): Update.
6809         (read_known_tasks_array): Return bool.
6810         (read_known_tasks_list): Likewise.
6811         (read_known_tasks): Return void.
6812         (ada_build_task_list): Now static.
6813
6814 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6815
6816         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6817         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6818
6819 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6820
6821         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6822         variant for ada_tasks_pspace_data_handle and
6823         ada_tasks_inferior_data_handle.
6824         (ada_tasks_pspace_data_cleanup): New function.
6825         (ada_tasks_inferior_data_cleanup): New function.
6826
6827 2019-02-17  Tom Tromey  <tom@tromey.com>
6828
6829         * macrotab.h (macro_source_fullname): Return a std::string.
6830         * macrotab.c (macro_include, check_for_redefinition)
6831         (macro_undef, macro_lookup_definition, foreach_macro)
6832         (foreach_macro_in_scope): Update.
6833         (macro_source_fullname): Return a std::string.
6834         * macrocmd.c (show_pp_source_pos): Update.
6835
6836 2019-02-17  Tom Tromey  <tom@tromey.com>
6837
6838         * macrocmd.c (show_pp_source_pos): Style the file names.
6839
6840 2019-02-17  Tom Tromey  <tom@tromey.com>
6841
6842         PR tui/24197:
6843         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6844
6845 2019-02-17  Tom Tromey  <tom@tromey.com>
6846
6847         * ada-lang.c (user_select_syms): Use filtered printing.
6848         * utils.c (wrap_style): New global.
6849         (desired_style): Remove.
6850         (emit_style_escape): Add stream parameter.
6851         (set_output_style, reset_terminal_style, prompt_for_continue):
6852         Update.
6853         (flush_wrap_buffer): Only flush gdb_stdout.
6854         (wrap_here): Set wrap_style.
6855         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6856         treat escape sequences as a character.  Change when wrap buffer is
6857         flushed.
6858         (fputs_styled): Do not set the output style when the default is
6859         requested.
6860         * ui-style.h (struct ui_file_style) <is_default>: New method.
6861         * source.c (print_source_lines_base): Emit escape sequences in one
6862         piece.
6863
6864 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6865
6866         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6867         integers and enumeration types.
6868
6869 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6870
6871         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6872         instead of lookup_symbol_in_language
6873         (do_exact_match): New function.
6874         (ada_get_symbol_name_matcher): Return do_exact_match when
6875         doing a verbatim match.
6876
6877 2019-02-15  Tom Tromey  <tromey@adacore.com>
6878
6879         * ravenscar-thread.c (ravenscar_thread_target::resume)
6880         (ravenscar_thread_target::wait): Special case wildcard requests.
6881
6882 2019-02-15  Tom Tromey  <tromey@adacore.com>
6883
6884         * ravenscar-thread.c (base_ptid): Remove.
6885         (struct ravenscar_thread_target) <close>: New method.
6886         <m_base_ptid>: New member.
6887         <update_inferior_ptid, active_task, task_is_currently_active,
6888         runtime_initialized>: Declare methods.
6889         <ravenscar_thread_target>: Add constructor.
6890         (ravenscar_thread_target::task_is_currently_active)
6891         (ravenscar_thread_target::update_inferior_ptid)
6892         (ravenscar_runtime_initialized): Rename.  Now methods.
6893         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6894         (ravenscar_thread_target::update_thread_list): Update.
6895         (ravenscar_thread_target::active_task): Now method.
6896         (ravenscar_thread_target::store_registers)
6897         (ravenscar_thread_target::prepare_to_store)
6898         (ravenscar_thread_target::prepare_to_store)
6899         (ravenscar_thread_target::mourn_inferior): Update.
6900         (ravenscar_inferior_created): Use "new" to create target.
6901         (ravenscar_thread_target::get_ada_task_ptid): Update.
6902         (_initialize_ravenscar): Don't initialize base_ptid.
6903         (ravenscar_ops): Remove global.
6904
6905 2019-02-15  Tom Tromey  <tromey@adacore.com>
6906
6907         * target.h (push_target): Declare new overload.
6908         * target.c (push_target): New overload, taking an rvalue reference.
6909         * remote.c (remote_target::open_1): Use push_target overload.
6910         * corelow.c (core_target_open): Use push_target overload.
6911
6912 2019-02-15  Tom Tromey  <tromey@adacore.com>
6913
6914         * ravenscar-thread.c (is_ravenscar_task)
6915         (ravenscar_task_is_currently_active): Return bool.
6916         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6917         (_initialize_ravenscar): Remove "(void)".
6918         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6919         Return bool.
6920
6921 2019-02-15  Tom Tromey  <tromey@adacore.com>
6922
6923         * ravenscar-thread.c (ravenscar_runtime_initializer)
6924         (has_ravenscar_runtime, get_running_thread_id)
6925         (ravenscar_thread_target::resume): Fix indentation.
6926
6927 2019-02-15  Tom Tromey  <tromey@adacore.com>
6928
6929         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6930         from ravenscar_arch_ops.
6931         (sparc_ravenscar_ops::fetch_registers)
6932         (sparc_ravenscar_ops::store_registers): Now methods.
6933         (sparc_ravenscar_prepare_to_store): Remove.
6934         (sparc_ravenscar_ops): Redefine.
6935         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6936         methods and destructor.  Remove members.
6937         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6938         (ravenscar_thread_target::store_registers)
6939         (ravenscar_thread_target::prepare_to_store): Update.
6940         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6941         Remove.
6942         (struct ppc_ravenscar_powerpc_ops): Derive from
6943         ravenscar_arch_ops.
6944         (ppc_ravenscar_powerpc_ops::fetch_registers)
6945         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6946         (ppc_ravenscar_powerpc_ops): Redefine.
6947         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6948         (ppc_ravenscar_e500_ops::fetch_registers)
6949         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6950         (ppc_ravenscar_e500_ops): Redefine.
6951         * aarch64-ravenscar-thread.c
6952         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6953         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6954         (aarch64_ravenscar_fetch_registers)
6955         (aarch64_ravenscar_store_registers): Now methods.
6956         (aarch64_ravenscar_ops): Redefine.
6957
6958 2019-02-15  Tom Tromey  <tromey@adacore.com>
6959
6960         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6961         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6962         (ravenscar_thread_target::stopped_by_watchpoint)
6963         (ravenscar_thread_target::stopped_data_address)
6964         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6965
6966 2019-02-15  Tom Tromey  <tromey@adacore.com>
6967
6968         * ravenscar-thread.c: Fix some typos.
6969
6970 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6971             Tom Tromey  <tromey@adacore.com>
6972
6973         * ada-lang.c (ada_exception_sal): Change addr_string to a
6974         std::string.
6975         (create_ada_exception_catchpoint): Update.
6976
6977 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6978             Tom Tromey  <tromey@adacore.com>
6979
6980         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6981         (bp_location_ops): Remove.
6982         (base_breakpoint_allocate_location): Update.
6983         (free_bp_location): Update.
6984         * ada-lang.c (class ada_catchpoint_location)
6985         <ada_catchpoint_location>: Remove ops parameter.
6986         (ada_catchpoint_location_dtor): Remove.
6987         (ada_catchpoint_location_ops): Remove.
6988         (allocate_location_exception): Update.
6989         * breakpoint.h (struct bp_location_ops): Remove.
6990         (class bp_location) <bp_location>: Remove bp_location_ops
6991         parameter.
6992         <~bp_location>: Add destructor.
6993         <ops>: Remove.
6994
6995 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6996             Pedro Alves  <palves@redhat.com>
6997
6998         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6999         'PATH_MAX'.
7000
7001 2019-02-14  David Michael  <fedora.dm0@gmail.com>
7002             Samuel Thibault  <samuel.thibault@gnu.org>
7003             Thomas Schwinge  <thomas@codesourcery.com>
7004
7005         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
7006         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
7007
7008 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
7009
7010         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7011         (check_empty): Use "const char *".
7012
7013         * gnu-nat.c (gnu_nat_target::detach): Instead of
7014         'detach_inferior (pid)' call
7015         'detach_inferior (find_inferior_pid (pid))'.
7016
7017         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7018         'nat/fork-inferior.o'.
7019         * gnu-nat.c: #include "nat/fork-inferior.h".
7020
7021         * gnu-nat.c (gnu_nat_target::detach): Instead of
7022         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7023         * gnu-nat.h: #include "inf-child.h".
7024         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7025         'i386_gnu_nat_target::fetch_registers'.
7026         (gnu_store_registers): Rename/move to
7027         'i386_gnu_nat_target::store_registers'.
7028
7029         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7030         * gnu-nat.h (mach_thread_info): New function.
7031         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7032
7033         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7034
7035 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7036
7037         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7038
7039 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7040
7041         * windows-nat.c (windows_add_thread): Add new parameter
7042         "main_thread_p" with default value set to false.  Update
7043         function documentation as well as all callers.
7044         (windows_delete_thread): Likewise.
7045         (fake_create_process): Update call to windows_add_thread.
7046         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7047         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7048         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7049         call to windows_delete_thread.
7050
7051 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7052
7053         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7054
7055 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7056
7057         * symfile.c (find_separate_debug_file): Use canonical path of
7058         sysroot with child_path instead of gdb_sysroot if it is valid.
7059
7060 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7061
7062         * symfile.c (find_separate_debug_file): Use child_path to
7063         determine if an object file is under a sysroot.
7064
7065 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7066
7067         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7068         unittests/child-path-selftests.c.
7069         * common/pathstuff.c (child_path): New function.
7070         * common/pathstuff.h (child_path): New prototype.
7071         * unittests/child-path-selftests.c: New file.
7072
7073 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7074
7075         * symfile.c (find_separate_debug_file): Look for separate debug
7076         files in debug directories under the sysroot.
7077
7078 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7079
7080         * symtab.h (struct minimal_symbol data_p): New const method.
7081         (struct minimal_symbol text_p): Likewise.
7082         * symtab.c (output_source_filename): Use file name style
7083         to print file name.
7084         (print_symbol_info): Likewise.
7085         (print_msymbol_info): Use address style to print addresses.
7086         Use function name style to print executable text symbols.
7087         (expand_symtab_containing_pc): Use data_p.
7088         (find_pc_sect_compunit_symtab): Likewise.
7089
7090 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7091
7092         * breakpoint.c (describe_other_breakpoints): Use address style
7093         to print addresses.
7094         (say_where): Likewise.
7095
7096 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7097
7098         * ada-typeprint.c (print_func_type): Print function name
7099         style to print function name.
7100         * c-typeprint.c (c_print_type_1): Likewise.
7101
7102 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7103
7104         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7105         for execve.
7106
7107 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7108
7109         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7110         type_stack.
7111
7112 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7113
7114         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7115         TYPE_CODE_REF types.
7116
7117 2019-02-08  Jim Wilson  <jimw@sifive.com>
7118
7119         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7120         (riscv_linux_fregset): New.
7121         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7122
7123 2019-02-07  Tom Tromey  <tom@tromey.com>
7124
7125         * thread.c (thread_cancel_execution_command): Update.
7126         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7127         methods.
7128         (struct thread_fsm_ops): Remove.
7129         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7130         (thread_fsm_should_stop, thread_fsm_return_value)
7131         (thread_fsm_set_finished, thread_fsm_finished_p)
7132         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7133         Don't declare.
7134         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7135         * infrun.c (clear_proceed_status_thread)
7136         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7137         (print_stop_event): Update.
7138         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7139         Add constructor.
7140         (step_command_fsm_ops): Remove.
7141         (new_step_command_fsm): Remove.
7142         (step_1): Update.
7143         (step_command_fsm::should_stop): Rename from
7144         step_command_fsm_should_stop.
7145         (step_command_fsm::clean_up): Rename from
7146         step_command_fsm_clean_up.
7147         (step_command_fsm::do_async_reply_reason): Rename from
7148         step_command_fsm_async_reply_reason.
7149         (struct until_next_fsm): Inherit from thread_fsm.  Add
7150         constructor.
7151         (until_next_fsm_ops): Remove.
7152         (new_until_next_fsm): Remove.
7153         (until_next_fsm::should_stop): Rename from
7154         until_next_fsm_should_stop.
7155         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7156         (until_next_fsm::do_async_reply_reason): Rename from
7157         until_next_fsm_async_reply_reason.
7158         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7159         constructor.  Change type of breakpoint.
7160         (finish_command_fsm_ops): Remove.
7161         (new_finish_command_fsm): Remove.
7162         (finish_command_fsm::should_stop): Rename from
7163         finish_command_fsm_should_stop.
7164         (finish_command_fsm::clean_up): Rename from
7165         finish_command_fsm_clean_up.
7166         (finish_command_fsm::return_value): Rename from
7167         finish_command_fsm_return_value.
7168         (finish_command_fsm::do_async_reply_reason): Rename from
7169         finish_command_fsm_async_reply_reason.
7170         (finish_command): Update.
7171         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7172         Add constructor.
7173         (call_thread_fsm_ops): Remove.
7174         (call_thread_fsm::call_thread_fsm): Rename from
7175         new_call_thread_fsm.
7176         (call_thread_fsm::should_stop): Rename from
7177         call_thread_fsm_should_stop.
7178         (call_thread_fsm::should_notify_stop): Rename from
7179         call_thread_fsm_should_notify_stop.
7180         (run_inferior_call, call_function_by_hand_dummy): Update.
7181         * cli/cli-interp.c (should_print_stop_to_console): Update.
7182         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7183         Add constructor.  Change type of location_breakpoint,
7184         caller_breakpoint.
7185         (until_break_fsm_ops): Remove.
7186         (new_until_break_fsm): Remove.
7187         (until_break_fsm::should_stop): Rename from
7188         until_break_fsm_should_stop.
7189         (until_break_fsm::clean_up): Rename from
7190         until_break_fsm_clean_up.
7191         (until_break_fsm::do_async_reply_reason): Rename from
7192         until_break_fsm_async_reply_reason.
7193         (until_break_command): Update.
7194         * thread-fsm.c: Remove.
7195         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7196
7197 2019-02-07  Tom Tromey  <tom@tromey.com>
7198
7199         * yy-remap.h: Add include guard.
7200         * xtensa-tdep.h: Add include guard.
7201         * xcoffread.h: Rename include guard.
7202         * varobj-iter.h: Add include guard.
7203         * tui/tui.h: Rename include guard.
7204         * tui/tui-winsource.h: Rename include guard.
7205         * tui/tui-wingeneral.h: Rename include guard.
7206         * tui/tui-windata.h: Rename include guard.
7207         * tui/tui-win.h: Rename include guard.
7208         * tui/tui-stack.h: Rename include guard.
7209         * tui/tui-source.h: Rename include guard.
7210         * tui/tui-regs.h: Rename include guard.
7211         * tui/tui-out.h: Rename include guard.
7212         * tui/tui-layout.h: Rename include guard.
7213         * tui/tui-io.h: Rename include guard.
7214         * tui/tui-hooks.h: Rename include guard.
7215         * tui/tui-file.h: Rename include guard.
7216         * tui/tui-disasm.h: Rename include guard.
7217         * tui/tui-data.h: Rename include guard.
7218         * tui/tui-command.h: Rename include guard.
7219         * tic6x-tdep.h: Add include guard.
7220         * target/waitstatus.h: Rename include guard.
7221         * target/wait.h: Rename include guard.
7222         * target/target.h: Rename include guard.
7223         * target/resume.h: Rename include guard.
7224         * target-float.h: Rename include guard.
7225         * stabsread.h: Add include guard.
7226         * rs6000-tdep.h: Add include guard.
7227         * riscv-fbsd-tdep.h: Add include guard.
7228         * regformats/regdef.h: Rename include guard.
7229         * record.h: Rename include guard.
7230         * python/python.h: Rename include guard.
7231         * python/python-internal.h: Rename include guard.
7232         * python/py-stopevent.h: Rename include guard.
7233         * python/py-ref.h: Rename include guard.
7234         * python/py-record.h: Rename include guard.
7235         * python/py-record-full.h: Rename include guard.
7236         * python/py-record-btrace.h: Rename include guard.
7237         * python/py-instruction.h: Rename include guard.
7238         * python/py-events.h: Rename include guard.
7239         * python/py-event.h: Rename include guard.
7240         * procfs.h: Add include guard.
7241         * proc-utils.h: Add include guard.
7242         * p-lang.h: Add include guard.
7243         * or1k-tdep.h: Rename include guard.
7244         * observable.h: Rename include guard.
7245         * nto-tdep.h: Rename include guard.
7246         * nat/x86-linux.h: Rename include guard.
7247         * nat/x86-linux-dregs.h: Rename include guard.
7248         * nat/x86-gcc-cpuid.h: Add include guard.
7249         * nat/x86-dregs.h: Rename include guard.
7250         * nat/x86-cpuid.h: Rename include guard.
7251         * nat/ppc-linux.h: Rename include guard.
7252         * nat/mips-linux-watch.h: Rename include guard.
7253         * nat/linux-waitpid.h: Rename include guard.
7254         * nat/linux-ptrace.h: Rename include guard.
7255         * nat/linux-procfs.h: Rename include guard.
7256         * nat/linux-osdata.h: Rename include guard.
7257         * nat/linux-nat.h: Rename include guard.
7258         * nat/linux-namespaces.h: Rename include guard.
7259         * nat/linux-btrace.h: Rename include guard.
7260         * nat/glibc_thread_db.h: Rename include guard.
7261         * nat/gdb_thread_db.h: Rename include guard.
7262         * nat/gdb_ptrace.h: Rename include guard.
7263         * nat/fork-inferior.h: Rename include guard.
7264         * nat/amd64-linux-siginfo.h: Rename include guard.
7265         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7266         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7267         * nat/aarch64-linux.h: Rename include guard.
7268         * nat/aarch64-linux-hw-point.h: Rename include guard.
7269         * mn10300-tdep.h: Add include guard.
7270         * mips-linux-tdep.h: Add include guard.
7271         * mi/mi-parse.h: Rename include guard.
7272         * mi/mi-out.h: Rename include guard.
7273         * mi/mi-main.h: Rename include guard.
7274         * mi/mi-interp.h: Rename include guard.
7275         * mi/mi-getopt.h: Rename include guard.
7276         * mi/mi-console.h: Rename include guard.
7277         * mi/mi-common.h: Rename include guard.
7278         * mi/mi-cmds.h: Rename include guard.
7279         * mi/mi-cmd-break.h: Rename include guard.
7280         * m2-lang.h: Add include guard.
7281         * location.h: Rename include guard.
7282         * linux-record.h: Rename include guard.
7283         * linux-nat.h: Add include guard.
7284         * linux-fork.h: Add include guard.
7285         * i386-darwin-tdep.h: Rename include guard.
7286         * hppa-linux-offsets.h: Add include guard.
7287         * guile/guile.h: Rename include guard.
7288         * guile/guile-internal.h: Rename include guard.
7289         * gnu-nat.h: Rename include guard.
7290         * gdb-stabs.h: Rename include guard.
7291         * frv-tdep.h: Add include guard.
7292         * f-lang.h: Add include guard.
7293         * event-loop.h: Add include guard.
7294         * darwin-nat.h: Rename include guard.
7295         * cp-abi.h: Rename include guard.
7296         * config/sparc/nm-sol2.h: Rename include guard.
7297         * config/nm-nto.h: Rename include guard.
7298         * config/nm-linux.h: Add include guard.
7299         * config/i386/nm-i386gnu.h: Rename include guard.
7300         * config/djgpp/nl_types.h: Rename include guard.
7301         * config/djgpp/langinfo.h: Rename include guard.
7302         * compile/gcc-cp-plugin.h: Add include guard.
7303         * compile/gcc-c-plugin.h: Add include guard.
7304         * compile/compile.h: Rename include guard.
7305         * compile/compile-object-run.h: Rename include guard.
7306         * compile/compile-object-load.h: Rename include guard.
7307         * compile/compile-internal.h: Rename include guard.
7308         * compile/compile-cplus.h: Rename include guard.
7309         * compile/compile-c.h: Rename include guard.
7310         * common/xml-utils.h: Rename include guard.
7311         * common/x86-xstate.h: Rename include guard.
7312         * common/version.h: Rename include guard.
7313         * common/vec.h: Rename include guard.
7314         * common/tdesc.h: Rename include guard.
7315         * common/selftest.h: Rename include guard.
7316         * common/scoped_restore.h: Rename include guard.
7317         * common/scoped_mmap.h: Rename include guard.
7318         * common/scoped_fd.h: Rename include guard.
7319         * common/safe-iterator.h: Rename include guard.
7320         * common/run-time-clock.h: Rename include guard.
7321         * common/refcounted-object.h: Rename include guard.
7322         * common/queue.h: Rename include guard.
7323         * common/ptid.h: Rename include guard.
7324         * common/print-utils.h: Rename include guard.
7325         * common/preprocessor.h: Rename include guard.
7326         * common/pathstuff.h: Rename include guard.
7327         * common/observable.h: Rename include guard.
7328         * common/netstuff.h: Rename include guard.
7329         * common/job-control.h: Rename include guard.
7330         * common/host-defs.h: Rename include guard.
7331         * common/gdb_wait.h: Rename include guard.
7332         * common/gdb_vecs.h: Rename include guard.
7333         * common/gdb_unlinker.h: Rename include guard.
7334         * common/gdb_unique_ptr.h: Rename include guard.
7335         * common/gdb_tilde_expand.h: Rename include guard.
7336         * common/gdb_sys_time.h: Rename include guard.
7337         * common/gdb_string_view.h: Rename include guard.
7338         * common/gdb_splay_tree.h: Rename include guard.
7339         * common/gdb_setjmp.h: Rename include guard.
7340         * common/gdb_ref_ptr.h: Rename include guard.
7341         * common/gdb_optional.h: Rename include guard.
7342         * common/gdb_locale.h: Rename include guard.
7343         * common/gdb_assert.h: Rename include guard.
7344         * common/filtered-iterator.h: Rename include guard.
7345         * common/filestuff.h: Rename include guard.
7346         * common/fileio.h: Rename include guard.
7347         * common/environ.h: Rename include guard.
7348         * common/common-utils.h: Rename include guard.
7349         * common/common-types.h: Rename include guard.
7350         * common/common-regcache.h: Rename include guard.
7351         * common/common-inferior.h: Rename include guard.
7352         * common/common-gdbthread.h: Rename include guard.
7353         * common/common-exceptions.h: Rename include guard.
7354         * common/common-defs.h: Rename include guard.
7355         * common/common-debug.h: Rename include guard.
7356         * common/cleanups.h: Rename include guard.
7357         * common/buffer.h: Rename include guard.
7358         * common/btrace-common.h: Rename include guard.
7359         * common/break-common.h: Rename include guard.
7360         * cli/cli-utils.h: Rename include guard.
7361         * cli/cli-style.h: Rename include guard.
7362         * cli/cli-setshow.h: Rename include guard.
7363         * cli/cli-script.h: Rename include guard.
7364         * cli/cli-interp.h: Rename include guard.
7365         * cli/cli-decode.h: Rename include guard.
7366         * cli/cli-cmds.h: Rename include guard.
7367         * charset-list.h: Add include guard.
7368         * buildsym-legacy.h: Rename include guard.
7369         * bfin-tdep.h: Add include guard.
7370         * ax.h: Rename include guard.
7371         * arm-linux-tdep.h: Add include guard.
7372         * arm-fbsd-tdep.h: Add include guard.
7373         * arch/xtensa.h: Rename include guard.
7374         * arch/tic6x.h: Add include guard.
7375         * arch/i386.h: Add include guard.
7376         * arch/arm.h: Rename include guard.
7377         * arch/arm-linux.h: Rename include guard.
7378         * arch/arm-get-next-pcs.h: Rename include guard.
7379         * arch/amd64.h: Add include guard.
7380         * arch/aarch64-insn.h: Rename include guard.
7381         * arch-utils.h: Rename include guard.
7382         * annotate.h: Add include guard.
7383         * amd64-darwin-tdep.h: Rename include guard.
7384         * aarch64-linux-tdep.h: Add include guard.
7385         * aarch64-fbsd-tdep.h: Add include guard.
7386         * aarch32-linux-nat.h: Add include guard.
7387
7388 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7389
7390         * macrotab.c (macro_define_internal): New function that
7391         factorizes macro_define_object_internal and macro_define_function
7392         code.
7393         (macro_define_object_internal): Use macro_define_internal.
7394         (macro_define_function): Likewise.
7395
7396 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7397
7398         * macrocmd.c (extract_identifier): Return
7399         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7400         callers.
7401
7402 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7403
7404         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7405
7406 2019-02-05  Tom Tromey  <tom@tromey.com>
7407
7408         * target.c (target_stack::unpush): Move assertion earlier.
7409
7410 2019-01-30  Tom Tromey  <tom@tromey.com>
7411
7412         PR python/23615:
7413         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7414         (gdbpy_parse_and_eval): Likewise.
7415         * python/python-internal.h (gdbpy_allow_threads): New class.
7416
7417 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7418
7419         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7420         (aarch64_fbsd_fpregmap): Move earlier.
7421         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7422         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7423         instead of individual calls to trad_frame_set_reg_addr.
7424         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7425         earlier.
7426         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7427         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7428         instead of individual calls to trad_frame_set_reg_addr.
7429
7430 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7431
7432         * CONTRIBUTE: Replace contribution list with wiki link.
7433
7434 2019-01-25  Tom Tromey  <tom@tromey.com>
7435
7436         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7437
7438 2019-01-25  Tom Tromey  <tom@tromey.com>
7439
7440         * xtensa-linux-nat.c: Fix common/ includes.
7441         * xml-support.h: Fix common/ includes.
7442         * xml-support.c: Fix common/ includes.
7443         * x86-linux-nat.c: Fix common/ includes.
7444         * windows-nat.c: Fix common/ includes.
7445         * varobj.h: Fix common/ includes.
7446         * varobj.c: Fix common/ includes.
7447         * value.c: Fix common/ includes.
7448         * valops.c: Fix common/ includes.
7449         * utils.c: Fix common/ includes.
7450         * unittests/xml-utils-selftests.c: Fix common/ includes.
7451         * unittests/utils-selftests.c: Fix common/ includes.
7452         * unittests/unpack-selftests.c: Fix common/ includes.
7453         * unittests/tracepoint-selftests.c: Fix common/ includes.
7454         * unittests/style-selftests.c: Fix common/ includes.
7455         * unittests/string_view-selftests.c: Fix common/ includes.
7456         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7457         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7458         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7459         * unittests/rsp-low-selftests.c: Fix common/ includes.
7460         * unittests/parse-connection-spec-selftests.c: Fix common/
7461         includes.
7462         * unittests/optional-selftests.c: Fix common/ includes.
7463         * unittests/offset-type-selftests.c: Fix common/ includes.
7464         * unittests/observable-selftests.c: Fix common/ includes.
7465         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7466         * unittests/memrange-selftests.c: Fix common/ includes.
7467         * unittests/memory-map-selftests.c: Fix common/ includes.
7468         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7469         * unittests/function-view-selftests.c: Fix common/ includes.
7470         * unittests/environ-selftests.c: Fix common/ includes.
7471         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7472         * unittests/common-utils-selftests.c: Fix common/ includes.
7473         * unittests/cli-utils-selftests.c: Fix common/ includes.
7474         * unittests/array-view-selftests.c: Fix common/ includes.
7475         * ui-file.c: Fix common/ includes.
7476         * tui/tui-io.c: Fix common/ includes.
7477         * tracepoint.h: Fix common/ includes.
7478         * tracepoint.c: Fix common/ includes.
7479         * tracefile-tfile.c: Fix common/ includes.
7480         * top.h: Fix common/ includes.
7481         * top.c: Fix common/ includes.
7482         * thread.c: Fix common/ includes.
7483         * target/waitstatus.h: Fix common/ includes.
7484         * target/waitstatus.c: Fix common/ includes.
7485         * target.h: Fix common/ includes.
7486         * target.c: Fix common/ includes.
7487         * target-memory.c: Fix common/ includes.
7488         * target-descriptions.c: Fix common/ includes.
7489         * symtab.h: Fix common/ includes.
7490         * symfile.c: Fix common/ includes.
7491         * stap-probe.c: Fix common/ includes.
7492         * spu-linux-nat.c: Fix common/ includes.
7493         * sparc-nat.c: Fix common/ includes.
7494         * source.c: Fix common/ includes.
7495         * solib.c: Fix common/ includes.
7496         * solib-target.c: Fix common/ includes.
7497         * ser-unix.c: Fix common/ includes.
7498         * ser-tcp.c: Fix common/ includes.
7499         * ser-pipe.c: Fix common/ includes.
7500         * ser-base.c: Fix common/ includes.
7501         * selftest-arch.c: Fix common/ includes.
7502         * s12z-tdep.c: Fix common/ includes.
7503         * rust-exp.y: Fix common/ includes.
7504         * rs6000-aix-tdep.c: Fix common/ includes.
7505         * riscv-tdep.c: Fix common/ includes.
7506         * remote.c: Fix common/ includes.
7507         * remote-notif.h: Fix common/ includes.
7508         * remote-fileio.h: Fix common/ includes.
7509         * remote-fileio.c: Fix common/ includes.
7510         * regcache.h: Fix common/ includes.
7511         * regcache.c: Fix common/ includes.
7512         * record-btrace.c: Fix common/ includes.
7513         * python/python.c: Fix common/ includes.
7514         * python/py-type.c: Fix common/ includes.
7515         * python/py-inferior.c: Fix common/ includes.
7516         * progspace.h: Fix common/ includes.
7517         * producer.c: Fix common/ includes.
7518         * procfs.c: Fix common/ includes.
7519         * proc-api.c: Fix common/ includes.
7520         * printcmd.c: Fix common/ includes.
7521         * ppc-linux-nat.c: Fix common/ includes.
7522         * parser-defs.h: Fix common/ includes.
7523         * osdata.c: Fix common/ includes.
7524         * obsd-nat.c: Fix common/ includes.
7525         * nat/x86-linux.c: Fix common/ includes.
7526         * nat/x86-linux-dregs.c: Fix common/ includes.
7527         * nat/x86-dregs.h: Fix common/ includes.
7528         * nat/x86-dregs.c: Fix common/ includes.
7529         * nat/ppc-linux.c: Fix common/ includes.
7530         * nat/mips-linux-watch.h: Fix common/ includes.
7531         * nat/mips-linux-watch.c: Fix common/ includes.
7532         * nat/linux-waitpid.c: Fix common/ includes.
7533         * nat/linux-ptrace.h: Fix common/ includes.
7534         * nat/linux-ptrace.c: Fix common/ includes.
7535         * nat/linux-procfs.c: Fix common/ includes.
7536         * nat/linux-personality.c: Fix common/ includes.
7537         * nat/linux-osdata.c: Fix common/ includes.
7538         * nat/linux-namespaces.c: Fix common/ includes.
7539         * nat/linux-btrace.h: Fix common/ includes.
7540         * nat/linux-btrace.c: Fix common/ includes.
7541         * nat/fork-inferior.c: Fix common/ includes.
7542         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7543         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7544         * nat/aarch64-linux.c: Fix common/ includes.
7545         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7546         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7547         * namespace.h: Fix common/ includes.
7548         * mips-linux-tdep.c: Fix common/ includes.
7549         * minsyms.c: Fix common/ includes.
7550         * mi/mi-parse.h: Fix common/ includes.
7551         * mi/mi-main.c: Fix common/ includes.
7552         * mi/mi-cmd-env.c: Fix common/ includes.
7553         * memrange.h: Fix common/ includes.
7554         * memattr.c: Fix common/ includes.
7555         * maint.h: Fix common/ includes.
7556         * maint.c: Fix common/ includes.
7557         * main.c: Fix common/ includes.
7558         * machoread.c: Fix common/ includes.
7559         * location.c: Fix common/ includes.
7560         * linux-thread-db.c: Fix common/ includes.
7561         * linux-nat.c: Fix common/ includes.
7562         * linux-fork.c: Fix common/ includes.
7563         * inline-frame.c: Fix common/ includes.
7564         * infrun.c: Fix common/ includes.
7565         * inflow.c: Fix common/ includes.
7566         * inferior.h: Fix common/ includes.
7567         * inferior.c: Fix common/ includes.
7568         * infcmd.c: Fix common/ includes.
7569         * inf-ptrace.c: Fix common/ includes.
7570         * inf-child.c: Fix common/ includes.
7571         * ia64-linux-nat.c: Fix common/ includes.
7572         * i387-tdep.c: Fix common/ includes.
7573         * i386-tdep.c: Fix common/ includes.
7574         * i386-linux-tdep.c: Fix common/ includes.
7575         * i386-linux-nat.c: Fix common/ includes.
7576         * i386-go32-tdep.c: Fix common/ includes.
7577         * i386-fbsd-tdep.c: Fix common/ includes.
7578         * i386-fbsd-nat.c: Fix common/ includes.
7579         * guile/scm-type.c: Fix common/ includes.
7580         * guile/guile.c: Fix common/ includes.
7581         * go32-nat.c: Fix common/ includes.
7582         * gnu-nat.c: Fix common/ includes.
7583         * gdbthread.h: Fix common/ includes.
7584         * gdbarch-selftests.c: Fix common/ includes.
7585         * gdb_usleep.c: Fix common/ includes.
7586         * gdb_select.h: Fix common/ includes.
7587         * gdb_bfd.c: Fix common/ includes.
7588         * gcore.c: Fix common/ includes.
7589         * fork-child.c: Fix common/ includes.
7590         * findvar.c: Fix common/ includes.
7591         * fbsd-nat.c: Fix common/ includes.
7592         * event-top.c: Fix common/ includes.
7593         * event-loop.c: Fix common/ includes.
7594         * dwarf2read.c: Fix common/ includes.
7595         * dwarf2loc.c: Fix common/ includes.
7596         * dwarf2-frame.c: Fix common/ includes.
7597         * dwarf-index-cache.c: Fix common/ includes.
7598         * dtrace-probe.c: Fix common/ includes.
7599         * disasm-selftests.c: Fix common/ includes.
7600         * defs.h: Fix common/ includes.
7601         * csky-tdep.c: Fix common/ includes.
7602         * cp-valprint.c: Fix common/ includes.
7603         * cp-support.h: Fix common/ includes.
7604         * cp-support.c: Fix common/ includes.
7605         * corelow.c: Fix common/ includes.
7606         * completer.h: Fix common/ includes.
7607         * completer.c: Fix common/ includes.
7608         * compile/compile.c: Fix common/ includes.
7609         * compile/compile-loc2c.c: Fix common/ includes.
7610         * compile/compile-cplus-types.c: Fix common/ includes.
7611         * compile/compile-cplus-symbols.c: Fix common/ includes.
7612         * command.h: Fix common/ includes.
7613         * cli/cli-dump.c: Fix common/ includes.
7614         * cli/cli-cmds.c: Fix common/ includes.
7615         * charset.c: Fix common/ includes.
7616         * build-id.c: Fix common/ includes.
7617         * btrace.h: Fix common/ includes.
7618         * btrace.c: Fix common/ includes.
7619         * breakpoint.h: Fix common/ includes.
7620         * breakpoint.c: Fix common/ includes.
7621         * ax.h:
7622         (enum agent_op): Fix common/ includes.
7623         * ax-general.c (struct aop_map): Fix common/ includes.
7624         * ax-gdb.c: Fix common/ includes.
7625         * auxv.c: Fix common/ includes.
7626         * auto-load.c: Fix common/ includes.
7627         * arm-tdep.c: Fix common/ includes.
7628         * arch/riscv.c: Fix common/ includes.
7629         * arch/ppc-linux-common.c: Fix common/ includes.
7630         * arch/i386.c: Fix common/ includes.
7631         * arch/arm.c: Fix common/ includes.
7632         * arch/arm-linux.c: Fix common/ includes.
7633         * arch/arm-get-next-pcs.c: Fix common/ includes.
7634         * arch/amd64.c: Fix common/ includes.
7635         * arch/aarch64.c: Fix common/ includes.
7636         * arch/aarch64-insn.c: Fix common/ includes.
7637         * arch-utils.c: Fix common/ includes.
7638         * amd64-windows-tdep.c: Fix common/ includes.
7639         * amd64-tdep.c: Fix common/ includes.
7640         * amd64-sol2-tdep.c: Fix common/ includes.
7641         * amd64-obsd-tdep.c: Fix common/ includes.
7642         * amd64-nbsd-tdep.c: Fix common/ includes.
7643         * amd64-linux-tdep.c: Fix common/ includes.
7644         * amd64-linux-nat.c: Fix common/ includes.
7645         * amd64-fbsd-tdep.c: Fix common/ includes.
7646         * amd64-fbsd-nat.c: Fix common/ includes.
7647         * amd64-dicos-tdep.c: Fix common/ includes.
7648         * amd64-darwin-tdep.c: Fix common/ includes.
7649         * agent.c: Fix common/ includes.
7650         * ada-lang.h: Fix common/ includes.
7651         * ada-lang.c: Fix common/ includes.
7652         * aarch64-tdep.c: Fix common/ includes.
7653
7654 2019-01-25  Tom Tromey  <tom@tromey.com>
7655
7656         * common/create-version.sh: Use common/version.h.
7657
7658 2019-01-24  Pedro Alves  <palves@redhat.com>
7659
7660         * infrun.c (signal_stop, signal_print, signal_program)
7661         (signal_catch, signal_pass): Now arrays instead of pointers.
7662         (update_signals_program_target, do_target_resume)
7663         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7664         * linux-nat.c (linux_nat_target::pass_signals)
7665         (linux_nat_target::create_inferior, linux_nat_target::attach):
7666         Adjust.
7667         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7668         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7669         * procfs.c (procfs_target::pass_signals): Adjust.
7670         * record-full.c (record_full_target::resume): Adjust.
7671         * remote.c (remote_target::pass_signals)
7672         (remote_target::program_signals): Adjust.
7673         * target-debug.h (target_debug_print_signals): Now takes a
7674         gdb::array_view as parameter.  Adjust.
7675         * target.h (target_ops) <pass_signals, program_signals>: Replace
7676         pointer and length parameters with gdb::array_view.
7677         (target_pass_signals, target_program_signals): Likewise.
7678         * target-delegates.c: Regenerate.
7679
7680 2019-01-24  Pedro Alves  <palves@redhat.com>
7681
7682         * common/forward-scope-exit.h
7683         (forward_scope_exit::forward_scope_exit): Pass arguments to
7684         m_bind_function directly, instead of creating a std::bind and
7685         copying that.
7686
7687 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7688
7689         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7690         for static members.
7691         (pass_in_v_vfp_candidate): Likewise.
7692
7693 2019-01-23  Tom Tromey  <tom@tromey.com>
7694             Pedro Alves  <palves@redhat.com>
7695
7696         * regcache.c (class regcache_invalidator): Remove.
7697         (regcache::raw_write): Use make_scope_exit.
7698
7699 2019-01-23  Tom Tromey  <tom@tromey.com>
7700
7701         * ui-out.h (class ui_out_emit_type): Update comment.
7702
7703 2019-01-23  Tom Tromey  <tom@tromey.com>
7704
7705         * infrun.c (fetch_inferior_event): Update comment.
7706
7707 2019-01-23  Tom Tromey  <tom@tromey.com>
7708             Pedro Alves  <palves@redhat.com>
7709
7710         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7711         parameter.
7712         (fetch_inferior_event): Use SCOPE_EXIT.
7713
7714
7715 2019-01-23  Tom Tromey  <tom@tromey.com>
7716             Pedro Alves  <palves@redhat.com>
7717
7718         * infrun.c (disable_thread_events): Delete.
7719         (stop_all_threads): Use SCOPE_EXIT.
7720
7721 2019-01-23  Tom Tromey  <tom@tromey.com>
7722             Pedro Alves  <palves@redhat.com>
7723
7724         * symfile.c: Include forward-scope-exit.h.
7725         (clear_symtab_users_cleanup): Replace forward declaration with
7726         a FORWARD_SCOPE_EXIT.
7727         (syms_from_objfile_1): Use the forward_scope_exit and
7728         gdb::optional instead of cleanup_function.
7729         (reread_symbols): Use the forward_scope_exit instead of
7730         cleanup_function.
7731         (clear_symtab_users_cleanup): Remove function.
7732
7733 2019-01-23  Tom Tromey  <tom@tromey.com>
7734             Pedro Alves  <palves@redhat.com>
7735
7736         * linux-nat.c: Include scope-exit.h.
7737         (cleanup_target_stop): Remove.
7738         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7739         SCOPE_EXIT.
7740
7741 2019-01-23  Tom Tromey  <tom@tromey.com>
7742             Pedro Alves  <palves@redhat.com>
7743
7744         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7745         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7746
7747 2019-01-23  Tom Tromey  <tom@tromey.com>
7748             Andrew Burgess  <andrew.burgess@embecosm.com>
7749             Pedro Alves  <palves@redhat.com>
7750
7751         * infrun.c (fetch_inferior_event): Use scope_exit.
7752         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7753         * top.c (execute_command): Use scope_exit.
7754         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7755         * utils.c (do_bpstat_clear_actions_cleanup)
7756         (make_bpstat_clear_actions_cleanup): Remove.
7757
7758 2019-01-23  Tom Tromey  <tom@tromey.com>
7759             Pedro Alves  <palves@redhat.com>
7760
7761         * infrun.c: Include "common/scope-exit.h"
7762         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7763         (wait_for_inferior): Use SCOPE_EXIT.
7764         (fetch_inferior_event): Use scope_exit.
7765
7766 2019-01-23  Tom Tromey  <tom@tromey.com>
7767             Pedro Alves  <palves@redhat.com>
7768
7769         * breakpoint.c (create_breakpoint): Remove cleanup.
7770
7771 2019-01-23  Tom Tromey  <tom@tromey.com>
7772             Andrew Burgess  <andrew.burgess@embecosm.com>
7773             Pedro Alves  <palves@redhat.com>
7774
7775 2019-01-23  Pedro Alves  <palves@redhat.com>
7776
7777         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7778
7779 2019-01-23  Pedro Alves  <palves@redhat.com>
7780             Andrew Burgess  <andrew.burgess@embecosm.com>
7781
7782         * gdbthread.h: Include "common/forward-scope-exit.h".
7783         (scoped_finish_thread_state): Redefine custom class in terms of
7784         forward_scope_exit.
7785
7786 2019-01-23  Pedro Alves  <palves@redhat.com>
7787             Andrew Burgess  <andrew.burgess@embecosm.com>
7788
7789         * common/forward-scope-exit.h: New file.
7790
7791 2019-01-23  Pedro Alves  <palves@redhat.com>
7792             Andrew Burgess  <andrew.burgess@embecosm.com>
7793             Tom Tromey  <tom@tromey.com>
7794
7795         * common/scope-exit.h: New file.
7796
7797 2019-01-23  Pedro Alves  <palves@redhat.com>
7798
7799         * common/preprocessor.h (ESC): Rename to ...
7800         (ESC_PARENS): ... this.
7801         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7802         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7803
7804 2019-01-23  Tom Tromey  <tom@tromey.com>
7805
7806         * language.h (class scoped_switch_to_sym_language_if_auto):
7807         Initialize m_lang in both cases.
7808
7809 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7810
7811         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7812         with XCNEW.
7813
7814 2019-01-22  Tom Tromey  <tom@tromey.com>
7815
7816         * corelow.c: Do not include sys/file.h.
7817
7818 2019-01-22  Tom Tromey  <tom@tromey.com>
7819
7820         * tui/tui-wingeneral.h: Include gdb_curses.h.
7821
7822 2019-01-22  Tom Tromey  <tom@tromey.com>
7823
7824         * source-cache.h (class source_cache) <get_source_lines,
7825         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7826
7827 2019-01-22  Tom Tromey  <tom@tromey.com>
7828
7829         * remote-fileio.h (struct remote_target): Declare.
7830
7831 2019-01-22  Tom Tromey  <tom@tromey.com>
7832
7833         * python/py-arch.c: Do not include py-ref.h.
7834         * python/py-bpevent.c: Do not include py-ref.h.
7835         * python/py-cmd.c: Do not include py-ref.h.
7836         * python/py-continueevent.c: Do not include py-ref.h.
7837         * python/py-event.h: Do not include py-ref.h.
7838         * python/py-evtregistry.c: Do not include py-ref.h.
7839         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7840         * python/py-frame.c: Do not include py-ref.h.
7841         * python/py-framefilter.c: Do not include py-ref.h.
7842         * python/py-function.c: Do not include py-ref.h.
7843         * python/py-infevents.c: Do not include py-ref.h.
7844         * python/py-linetable.c: Do not include py-ref.h.
7845         * python/py-objfile.c: Do not include py-ref.h.
7846         * python/py-param.c: Do not include py-ref.h.
7847         * python/py-prettyprint.c: Do not include py-ref.h.
7848         * python/py-progspace.c: Do not include py-ref.h.
7849         * python/py-symbol.c: Do not include py-ref.h.
7850         * python/py-symtab.c: Do not include py-ref.h.
7851         * python/py-type.c: Do not include py-ref.h.
7852         * python/py-unwind.c: Do not include py-ref.h.
7853         * python/py-utils.c: Do not include py-ref.h.
7854         * python/py-value.c: Do not include py-ref.h.
7855         * python/py-varobj.c: Do not include py-ref.h.
7856         * python/py-xmethods.c: Do not include py-ref.h.
7857         * python/python.c: Do not include py-ref.h.
7858         * varobj.c: Do not include py-ref.h.
7859
7860 2019-01-22  Tom Tromey  <tom@tromey.com>
7861
7862         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7863         keyword for bcache.
7864
7865 2019-01-22  Tom Tromey  <tom@tromey.com>
7866
7867         * compile/compile-cplus-types.c: Remove a comment by #include.
7868
7869 2019-01-22  Tom Tromey  <tom@tromey.com>
7870
7871         * compile/gcc-c-plugin.h: Include compile-internal.h.
7872
7873 2019-01-22  Tom Tromey  <tom@tromey.com>
7874
7875         * stabsread.c (EXTERN): Do not define.
7876         (symnum, next_symbol_text_func, processing_gcc_compilation)
7877         (within_function, global_sym_chain, global_stabs)
7878         (previous_stab_code, this_object_header_files)
7879         (n_this_object_header_files)
7880         (n_allocated_this_object_header_files): Define.
7881         * stabsread.h (EXTERN): Never define.  Use "extern".
7882
7883 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7884
7885         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7886         history_value.
7887
7888 2019-01-21  Tom Tromey  <tom@tromey.com>
7889
7890         * ui-out.c: Fix includes.
7891         * tui/tui-source.c: Fix includes.
7892         * target.c: Fix includes.
7893         * remote.c: Fix includes.
7894         * regcache.c: Fix includes.
7895         * python/py-block.c: Fix includes.
7896         * printcmd.c: Fix includes.
7897         * or1k-tdep.c: Fix includes.
7898         * mi/mi-main.c: Fix includes.
7899         * m32r-tdep.c: Fix includes.
7900         * csky-tdep.c: Fix includes.
7901         * compile/compile-cplus-types.c: Fix includes.
7902         * cli/cli-interp.c: Fix includes.
7903
7904 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7905
7906         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7907         for padding.
7908
7909 2019-01-16  Tom Tromey  <tom@tromey.com>
7910
7911         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7912         earlier.
7913         (struct objfile) <msymbols_range>: Move from top level.
7914         <msymbols>: New method.
7915         (class objfile_msymbols): Remove.
7916         * symtab.c (default_collect_symbol_completion_matches_break_on):
7917         Update.
7918         * symmisc.c (dump_msymbols): Update.
7919         * stabsread.c (scan_file_globals): Update.
7920         * objc-lang.c (info_selectors_command, info_classes_command)
7921         (find_methods): Update.
7922         * minsyms.c (find_solib_trampoline_target): Update.
7923         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7924         * coffread.c (coff_symfile_read): Update.
7925         * ada-lang.c (ada_lookup_simple_minsym)
7926         (ada_collect_symbol_completion_matches): Update.
7927
7928 2019-01-16  Tom Tromey  <tom@tromey.com>
7929
7930         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7931         type.  Remove no-argument constructor.
7932         <iterator::operator++>: Simplify.
7933         <begin>: Update.
7934         <end>: Use minimal_symbol_count.
7935
7936 2019-01-16  Tom Tromey  <tom@tromey.com>
7937
7938         * objfiles.h (struct objfile) <psymtabs>: New method.
7939         (class objfile_psymtabs): Remove.
7940         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7941         typedef.
7942         <range>: New method.
7943         (require_partial_symbols): Change return type.
7944         * psymtab.c (require_partial_symbols)
7945         (psym_expand_symtabs_matching): Update.
7946         * mdebugread.c (parse_partial_symbols): Update.
7947         * dbxread.c (dbx_end_psymtab): Update.
7948
7949 2019-01-15  Tom Tromey  <tom@tromey.com>
7950
7951         * symtab.c (lookup_objfile_from_block)
7952         (lookup_symbol_in_objfile_symtabs)
7953         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7954         (find_line_symtab, info_sources_command)
7955         (default_collect_symbol_completion_matches_break_on)
7956         (make_source_files_completion_list): Update.
7957         * symmisc.c (print_objfile_statistics, dump_objfile)
7958         (maintenance_print_symbols, maintenance_info_symtabs)
7959         (maintenance_check_symtabs, maintenance_info_line_tables):
7960         Update.
7961         * source.c (select_source_symtab)
7962         (forget_cached_source_info_for_objfile): Update.
7963         * objfiles.h (class objfile_compunits): Remove.
7964         (struct objfile) <compunits_range>: New typedef.
7965         (compunits): New method.
7966         * objfiles.c (objfile_relocate1): Update.
7967         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7968         * maint.c (count_symtabs_and_blocks): Update.
7969         * linespec.c (iterate_over_all_matching_symtabs): Update.
7970         * cp-support.c (add_symbol_overload_list_qualified): Update.
7971         * coffread.c (coff_symtab_read): Update.
7972         * ada-lang.c (add_nonlocal_symbols)
7973         (ada_collect_symbol_completion_matches)
7974         (ada_add_global_exceptions): Update.
7975
7976 2019-01-15  Tom Tromey  <tom@tromey.com>
7977
7978         * progspace.h (program_space) <objfiles_safe_range>: New
7979         typedef.
7980         <objfiles_safe>: New method.
7981         * objfiles.h (class all_objfiles_safe): Remove.
7982         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7983         * jit.c (jit_inferior_exit_hook): Update.
7984
7985 2019-01-17  Tom Tromey  <tom@tromey.com>
7986
7987         * progspace.h (program_space) <objfiles_range>: New typedef.
7988         <objfiles>: New method.
7989         <objfiles_head>: Rename from objfiles.
7990         (object_files): Update.
7991         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7992         * guile/scm-pretty-print.c
7993         (ppscm_find_pretty_printer_from_objfiles): Update.
7994         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7995         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7996         Update.
7997         * python/py-progspace.c (pspy_get_objfiles): Update.
7998         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7999         Update.
8000         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8001         (objfpy_lookup_objfile_by_build_id): Update.
8002         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
8003         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8004         Update.
8005         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8006         (expand_symtab_containing_pc, lookup_objfile_from_block)
8007         (lookup_static_symbol, basic_lookup_transparent_type)
8008         (find_pc_sect_compunit_symtab, find_symbol_at_address)
8009         (find_line_symtab, info_sources_command)
8010         (default_collect_symbol_completion_matches_break_on)
8011         (make_source_files_completion_list, find_main_name): Update.
8012         * symmisc.c (print_symbol_bcache_statistics)
8013         (print_objfile_statistics, maintenance_print_symbols)
8014         (maintenance_print_msymbols, maintenance_print_objfiles)
8015         (maintenance_info_symtabs, maintenance_check_symtabs)
8016         (maintenance_expand_symtabs, maintenance_info_line_tables):
8017         Update.
8018         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8019         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8020         (map_overlay_command, unmap_overlay_command)
8021         (simple_overlay_update, expand_symtabs_matching)
8022         (map_symbol_filenames): Update.
8023         * symfile-debug.c (set_debug_symfile): Update.
8024         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8025         Update.
8026         * source.c (select_source_symtab, forget_cached_source_info):
8027         Update.
8028         * solib.c (solib_read_symbols): Update.
8029         * solib-spu.c (append_ocl_sos): Update.
8030         * psymtab.c (maintenance_print_psymbols)
8031         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8032         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8033         * printcmd.c (info_symbol_command): Update.
8034         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8035         Update.
8036         * objfiles.h (class all_objfiles): Remove.
8037         * objfiles.c (have_partial_symbols, have_full_symbols)
8038         (have_minimal_symbols, qsort_cmp, update_section_map)
8039         (shared_objfile_contains_address_p)
8040         (default_iterate_over_objfiles_in_search_order): Update.
8041         * objc-lang.c (info_selectors_command, info_classes_command)
8042         (find_methods): Update.
8043         * minsyms.c (find_solib_trampoline_target): Update.
8044         * maint.c (maintenance_info_sections)
8045         (maintenance_translate_address, count_symtabs_and_blocks):
8046         Update.
8047         * main.c (captured_main_1): Update.
8048         * linux-thread-db.c (try_thread_db_load_from_pdir)
8049         (has_libpthread): Update.
8050         * linespec.c (iterate_over_all_matching_symtabs)
8051         (search_minsyms_for_name): Update.
8052         * jit.c (jit_find_objf_with_entry_addr): Update.
8053         * hppa-tdep.c (find_unwind_entry)
8054         (hppa_lookup_stub_minimal_symbol): Update.
8055         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8056         Update.
8057         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8058         (elf_gnu_ifunc_resolve_by_got): Update.
8059         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8060         * dwarf-index-write.c (save_gdb_index_command): Update.
8061         * cp-support.c (add_symbol_overload_list_qualified): Update.
8062         * breakpoint.c (create_overlay_event_breakpoint)
8063         (create_longjmp_master_breakpoint)
8064         (create_std_terminate_master_breakpoint)
8065         (create_exception_master_breakpoint): Update.
8066         * blockframe.c (find_pc_partial_function): Update.
8067         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8068         (ada_collect_symbol_completion_matches)
8069         (ada_add_global_exceptions): Update.
8070
8071 2019-01-17  Tom Tromey  <tom@tromey.com>
8072
8073         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8074         declare VEC.
8075         (solib_target_parse_libraries): Change return type.
8076         (library_list_start_segment, library_list_start_section)
8077         (library_list_end_library, library_list_start_library); Update.
8078         (solib_target_free_library_list): Remove.
8079         (solib_target_parse_libraries): Remove cleanup.  Change return
8080         type.
8081         (solib_target_current_sos): Update.
8082
8083 2019-01-17  Tom Tromey  <tromey@bapiya>
8084
8085         * valprint.c: Replace "the the" with "the".
8086         * symtab.c: Replace "the the" with "the".
8087         * solib.c: Replace "the the" with "the".
8088         * solib-dsbt.c: Replace "the the" with "the".
8089         * linespec.c: Replace "the the" with "the".
8090         * dwarf2loc.h: Replace "the the" with "the".
8091         * amd64-windows-tdep.c: Replace "the the" with "the".
8092         * aarch64-tdep.c: Replace "the the" with "the".
8093
8094 2019-01-16  Keith Seitz  <keiths@redhat.com>
8095
8096         PR gdb/23773
8097         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8098         <builder>: Rename to ..
8099         <m_builder>: ... this and make private.
8100         (dwarf2_cu::get_builder): New method.  Change all users of
8101         `builder' to use this method.
8102         (dwarf2_start_symtab): Move to ...
8103         (dwarf2_cu::start_symtab): ... here.  Update all callers
8104         (setup_type_unit_groups): Move to ...
8105         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8106         callers.
8107         (dwarf2_cu::reset_builder): New method.
8108         (process_full_compunit, process_full_type_unit): Use
8109         dwarf2_cu::reset_builder.
8110         (follow_die_offset): Record the ancestor CU if it is different
8111         from the followed DIE's CU.
8112         (follow_die_sig_1): Likewise.
8113
8114 2019-01-15  Tom Tromey  <tom@tromey.com>
8115
8116         * remote.c (class remote_state) <buf>: Now a char_vector.
8117         <buf_size>: Remove.
8118         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8119         parameter.
8120         (remote_target::getpkt_or_notif_sane_1)
8121         (remote_target::getpkt_sane)
8122         (remote_target::getpkt_or_notif_sane): Likewise.
8123         (class remote_target) <putpkt>: New overload.
8124         (remote_target::read_frame): Change type of "buf_p".  Remove
8125         sizeof_p parameter.
8126         (packet_ok): New overload.
8127         (packet_check_result): New overload.
8128         Update all uses.
8129
8130 2019-01-14  Tom Tromey  <tom@tromey.com>
8131
8132         * remote-notif.c (handle_notification, remote_notif_ack)
8133         (remote_notif_parse): Make "buf" const.
8134         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8135         const.
8136         (remote_notif_parse, remote_notif_ack, handle_notification):
8137         Likewise.
8138         * remote.c (remote_notif_stop_parse): Make "buf" const.
8139         (remote_target::remote_parse_stop_reply): Make "buf" const.
8140         (remote_notif_stop_ack): Make "buf" const.
8141
8142 2019-01-14  Tom Tromey  <tom@tromey.com>
8143
8144         * remote.c (remote_console_output): Make parameter const.
8145
8146 2019-01-14  Tom Tromey  <tom@tromey.com>
8147
8148         * target-debug.h (target_debug_print_signals): Constify.
8149         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8150         * procfs.c (procfs_target::pass_signals): Update.
8151         * linux-nat.c (linux_nat_target::pass_signals): Update.
8152         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8153         * target-delegates.c: Rebuild.
8154         * remote.c (remote_target::program_signals): Update.
8155         (remote_target::pass_signals): Update.
8156         * target.c (target_pass_signals): Constify argument.
8157         (target_program_signals): Likewise.
8158         * target.h (struct target_ops) <pass_signals, program_signals>:
8159         Constify argument.
8160         (target_pass_signals, target_program_signals): Constify argument.
8161
8162 2019-01-14  Tom Tromey  <tom@tromey.com>
8163
8164         PR tui/28819:
8165         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8166
8167 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8168
8169         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8170         field.
8171         * rs6000-tdep.c: Include reggroups.h.
8172         (IS_V_ALIAS_PSEUDOREG): Define.
8173         (rs6000_register_name): Return names for the "vX" aliases.
8174         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8175         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8176         aliases.  Call default_register_reggroup_p for all other
8177         pseudo-registers.
8178         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8179         New functions.
8180         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8181         Handle "vX" aliases.
8182         (v_alias_pseudo_register_collect): New function.
8183         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8184         (rs6000_gdbarch_init): Initialize "vX" aliases as
8185         pseudo-registers.  Restore registration of
8186         rs6000_pseudo_register_reggroup_p with
8187         set_tdesc_pseudo_register_reggroup_p.
8188
8189 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8190
8191         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8192         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8193         set_gdbarch_num_pseudo_regs.
8194
8195 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8196
8197         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8198         Remove arg prefixname, add do_set and do_show.
8199         Add member functions set_list and show_list.
8200         * cli/cli-style.c (class cli_style_option): Update accordingly.
8201         (style_set_list): Move to file scope.
8202         (style_show_list): Likewise.
8203         (set_style): Call help_list.
8204         (show_style): Call cmd_show_list.
8205         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8206         Update to use the new macro.
8207
8208 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8209
8210         * ada-lang.c (_initialize_ada_language): Expand the help text
8211         for the "catch exception" command.
8212
8213 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8214
8215         * symtab.c (matching_obj_sections): Initialize obj,
8216         declare it closer to its usage.
8217
8218 2019-01-10  Tom Tromey  <tom@tromey.com>
8219
8220         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8221         (basic_inf_threads_range): Remove.
8222         (inf_threads_range, inf_non_exited_threads_range)
8223         (safe_inf_threads_range): Use next_adapter.
8224
8225 2019-01-10  Keith Seitz  <keiths@redhat.com>
8226
8227         PR gdb/23712
8228         PR symtab/23010
8229         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8230         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8231
8232 2019-01-10  Keith Seitz  <keiths@redhat.com>
8233
8234         PR gdb/23712
8235         PR symtab/23010
8236         * dictionary.c (pending_to_vector): Remove.
8237         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8238         Remove _1 suffix, replacing functions of the same name.  Update
8239         all callers.
8240         (dict_create_hashed, dict_create_hashed_expandable)
8241         (dict_create_linear, dict_create_linear_expandable, dict_free)
8242         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8243         Make functions static.
8244
8245 2019-01-10  Keith Seitz  <keiths@redhat.com>
8246
8247         PR gdb/23712
8248         PR symtab/23010
8249         * dictionary.h (struct dictionary): Replace declaration with
8250         multidictionary.
8251         (dict_create_hashed, dict_create_hashed_expandable)
8252         (dict_create_linear, dict_create_linear_expandable)
8253         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8254         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8255         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8256         taking multidictionary argument.
8257         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8258         * block.h (struct block) <dict>: Change to multidictionary
8259         and rename `multidict'.
8260         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8261         symmisc.c: Update all dictionary references to multidictionary.
8262
8263 2019-01-10  Keith Seitz  <keiths@redhat.com>
8264
8265         PR gdb/23712
8266         PR symtab/23010
8267         * dictionary.c: Include unordered_map.
8268         (pending_to_vector): New function.
8269         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8270         Rewrite the non-"_1" functions to take vector instead
8271         of linked list.
8272         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8273         "new" _1 versions of the same name.
8274         (multidictionary): Define.
8275         (std::hash<enum language): New definition.
8276         (collate_pending_symbols_by_language, mdict_create_hashed)
8277         (mdict_create_hashed_expandable, mdict_create_linear)
8278         (mdict_create_linear_expandable, mdict_free)
8279         (find_language_dictionary, create_new_language_dictionary)
8280         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8281         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8282         (mdict_size, mdict_empty): New functions.
8283         * dictionary.h (mdict_iterator): Define.
8284
8285 2019-01-10  Pedro Alves  <palves@redhat.com>
8286
8287         * breakpoint.c (read_uploaded_action)
8288         (create_tracepoint_from_upload): Adjust to use
8289         gdb::unique_xmalloc_ptr.
8290         * ctf.c (ctf_write_uploaded_tp):
8291         (SET_ARRAY_FIELD): Use emplace_back.
8292         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8293         * tracefile-tfile.c (tfile_write_uploaded_tp):
8294         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8295         gdb::unique_xmalloc_ptr.
8296         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8297         at_string, cond_string, cmd_strings>: Replace char pointers
8298         with gdb::unique_xmalloc_ptr.
8299
8300 2019-01-10  Pedro Alves  <palves@redhat.com>
8301
8302         * solib-target.c (library_list_start_library): Don't xstrdup name.
8303
8304 2019-01-10  Pedro Alves  <palves@redhat.com>
8305
8306         * mdebugread.c (parse_partial_symbols): Use
8307         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8308
8309 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8310
8311         * linux-fork.c (scoped_switch_fork_info)
8312         <~scoped_switch_fork_info>: Fix incorrect variable name.
8313
8314 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8315
8316         * linux-fork.c (scoped_switch_fork_info)
8317         <scoped_switch_fork_info>: Make explicit.
8318         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8319
8320 2019-01-10  Tom Tromey  <tom@tromey.com>
8321
8322         * objfiles.h (objfile::reset_psymtabs): Update.
8323         * objfiles.c (objfile::objfile): Update.
8324         * psymtab.h (psymtab_storage::obstack): Update.
8325         (psymtab_storage::m_obstack): Use gdb::optional.
8326         (class psymtab_storage): Update comment.  Remove objfile
8327         parameter.
8328         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8329
8330 2019-01-10  Tom Tromey  <tom@tromey.com>
8331
8332         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8333         <free_psymtabs>: Now private.
8334         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8335         (allocate_psymtab): Use new method.
8336
8337 2019-01-10  Tom Tromey  <tom@tromey.com>
8338
8339         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8340         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8341         * mdebugread.c (parse_partial_symbols): Use
8342         allocate_dependencies.
8343         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8344         allocate_dependencies.
8345         (process_psymtab_comp_unit_reader)
8346         (build_type_psymtab_dependencies): Likewise.
8347         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8348
8349 2019-01-10  Tom Tromey  <tom@tromey.com>
8350
8351         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8352         PSYMBOL_SET_LANGUAGE.
8353         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8354
8355 2019-01-10  Tom Tromey  <tom@tromey.com>
8356
8357         * psymtab.h (psymtab_storage::obstack): New method.
8358         <m_obstack>: Rename from obstack; now private.
8359         * psymtab.c (psymtab_storage): Update.
8360         * dwarf2read.c (create_addrmap_from_index)
8361         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8362         Update.
8363
8364 2019-01-10  Tom Tromey  <tom@tromey.com>
8365
8366         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8367         * objfiles.h (objfile::reset_psymtabs): New method.
8368
8369 2019-01-10  Tom Tromey  <tom@tromey.com>
8370
8371         * symmisc.c (print_symbol_bcache_statistics): Update.
8372         (print_objfile_statistics): Update.
8373         * symfile.c (reread_symbols): Update.
8374         * psymtab.h (class psymtab_storage): New.
8375         * psymtab.c (psymtab_storage): New constructor.
8376         (~psymtab_storage): New destructor.
8377         (require_partial_symbols): Update.
8378         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8379         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8380         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8381         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8382         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8383         (start_psymtab_common, end_psymtab_common)
8384         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8385         (allocate_psymtab): Update.
8386         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8387         Update.
8388         (dump_psymtab_addrmap, maintenance_print_psymbols)
8389         (maintenance_check_psymtabs): Update.
8390         (class objfile_psymtabs): Move to objfiles.h.
8391         * psympriv.h (discard_psymtab): Now inline.
8392         (psymtab_discarder::psymtab_discarder): Update.
8393         (psymtab_discarder::~psymtab_discarder): Update.
8394         (ALL_OBJFILE_PSYMTABS): Rewrite.
8395         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8396         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8397         Remove fields.
8398         <partial_symtabs>: New field.
8399         (class objfile_psymtabs): Move from psymtab.h.  Update.
8400         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8401         psymbol_cache.
8402         (objfile::~objfile): Don't destroy psymbol_cache.
8403         * mdebugread.c (parse_partial_symbols): Update.
8404         * dwarf2read.c (create_addrmap_from_index)
8405         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8406         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8407         (add_partial_subprogram, dwarf2_ranges_read): Update.
8408         * dwarf-index-write.c (write_address_map)
8409         (write_one_signatured_type, recursively_write_psymbols)
8410         (class debug_names, class debug_names, write_psymtabs_to_index):
8411         Update.
8412
8413 2019-01-10  Tom Tromey  <tom@tromey.com>
8414
8415         * symtab.h (SYMBOL_SET_NAMES): Update.
8416         (symbol_set_names): Update.
8417         (MSYMBOL_SET_NAMES): Update.
8418         * symtab.c (symbol_set_names): Change argument to be an
8419         objfile_per_bfd_storage.
8420         * psymtab.c (add_psymbol_to_bcache): Update.
8421         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8422
8423 2019-01-10  Tom Tromey  <tom@tromey.com>
8424
8425         * symtab.c (create_demangled_names_hash): Change argument to be an
8426         objfile_per_bfd_storage.
8427         (symbol_set_names): Update.
8428
8429 2019-01-10  Tom Tromey  <tom@tromey.com>
8430
8431         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8432         init_psymbol_list.
8433         * psymtab.c (init_psymbol_list): Do nothing if already called.
8434         * psympriv.h (init_psymbol_list): Add comment.
8435         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8436         init_psymbol_list.
8437         * dbxread.c (dbx_symfile_read): Unconditionally call
8438         init_psymbol_list.
8439
8440 2019-01-10  Tom Tromey  <tom@tromey.com>
8441
8442         * xcoffread.c (scan_xcoff_symtab): Update.
8443         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8444         "where".
8445         * mdebugread.c (parse_partial_symbols)
8446         (handle_psymbol_enumerators): Update.
8447         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8448         * dbxread.c (read_dbx_symtab): Update.
8449         * psympriv.h (psymbol_placement): New enum.
8450         (add_psymbol_to_list): Update.
8451
8452 2019-01-10  Tom Tromey  <tom@tromey.com>
8453
8454         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8455         static_psymbols parameters.
8456         (scan_xcoff_symtab): Update.
8457         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8458         static_psymbols parameters.
8459         * psympriv.h (start_psymtab_common): Update.
8460         * mdebugread.c (parse_partial_symbols): Update.
8461         * dwarf2read.c (create_partial_symtab): Update.
8462         * dbxread.c (read_dbx_symtab): Update.
8463         (start_psymtab): Remove global_psymbols and static_psymbols
8464         parameters.
8465
8466 2019-01-10  Tom Tromey  <tom@tromey.com>
8467
8468         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8469         * psymtab.c (allocate_psymtab): Add comment.
8470         * psympriv.h (allocate_psymtab): Add comment.
8471         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8472         initializations.
8473         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8474
8475 2019-01-10  Tom Tromey  <tom@tromey.com>
8476
8477         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8478         Don't declare.
8479         * mipsread.c: Include mdebugread.h.
8480         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8481         Declare.
8482         * elfread.c: Include mdebugread.h.
8483
8484 2019-01-09  Tom Tromey  <tom@tromey.com>
8485
8486         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8487         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8488         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8489         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8490         (psym_lookup_symbol, psym_find_last_source_symtab)
8491         (psym_forget_cached_source_info, psym_print_stats)
8492         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8493         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8494         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8495         (psym_find_compunit_symtab_by_address)
8496         (maintenance_print_psymbols, maintenance_info_psymtabs)
8497         (maintenance_check_psymtabs): Use ranged for.
8498         * psymtab.h (class objfile_psymtabs): New.
8499         (require_partial_symbols): Return objfile_psymtabs.
8500         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8501
8502 2019-01-09  Tom Tromey  <tom@tromey.com>
8503
8504         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8505         (find_pc_mapped_section, list_overlays_command)
8506         (map_overlay_command, unmap_overlay_command)
8507         (simple_overlay_update): Use all_objfiles.
8508         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8509         * printcmd.c (info_symbol_command): Use all_objfiles.
8510         * objfiles.h (ALL_OBJSECTIONS): Remove.
8511         * maint.c (maintenance_translate_address): Use all_objfiles.
8512         * gcore.c (gcore_create_callback): Use all_objfiles.
8513         (objfile_find_memory_regions): Likewise.
8514
8515 2019-01-09  Tom Tromey  <tom@tromey.com>
8516
8517         * symtab.c (find_line_symtab, info_sources_command)
8518         (make_source_files_completion_list): Use objfile_compunits.
8519         * source.c (select_source_symtab): Use objfile_compunits.
8520         * objfiles.h (struct objfile): Update comment.
8521         (ALL_OBJFILES): Remove.
8522         (ALL_FILETABS): Remove.
8523         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8524         objfile_compunits.
8525
8526 2019-01-09  Tom Tromey  <tom@tromey.com>
8527
8528         * symmisc.c (print_objfile_statistics, dump_objfile)
8529         (maintenance_print_symbols): Use compunit_filetabs.
8530         * source.c (forget_cached_source_info_for_objfile): Use
8531         compunit_filetabs.
8532         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8533         (ALL_FILETABS): Use compunit_filetabs.
8534         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8535         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8536
8537 2019-01-09  Tom Tromey  <tom@tromey.com>
8538
8539         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8540         (compunit_filetabs): New.
8541         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8542         compunit_filetabs.
8543         (info_sources_command, make_source_files_completion_list): Remove
8544         declaration.
8545         * symmisc.c (print_objfile_statistics, dump_objfile)
8546         (maintenance_print_symbols): Remove declaration.
8547         (maintenance_info_symtabs): Use compunit_filetabs.
8548         (maintenance_info_line_tables): Likewise.
8549         * source.c (select_source_symtab): Change local variable name.
8550         (forget_cached_source_info_for_objfile): Remove declaration.
8551         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8552         * objfiles.c (objfile_relocate1): Remove declaration.
8553         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8554         declaration.
8555         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8556         * coffread.c (coff_symtab_read): Remove declaration.
8557         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8558         compunit_filetabs.
8559
8560 2019-01-09  Tom Tromey  <tom@tromey.com>
8561
8562         * symtab.c (lookup_objfile_from_block)
8563         (find_pc_sect_compunit_symtab, search_symbols)
8564         (default_collect_symbol_completion_matches_break_on): Use
8565         objfile_compunits.
8566         * objfiles.h (ALL_COMPUNITS): Remove.
8567         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8568         * cp-support.c (add_symbol_overload_list_qualified): Use
8569         objfile_compunits.
8570         * ada-lang.c (ada_collect_symbol_completion_matches)
8571         (ada_add_global_exceptions): Use objfile_compunits.
8572
8573 2019-01-09  Tom Tromey  <tom@tromey.com>
8574
8575         * source.c (select_source_symtab)
8576         (forget_cached_source_info_for_objfile): Remove declaration.
8577         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8578         declaration.
8579         * maint.c (count_symtabs_and_blocks): Remove declaration.
8580         * cp-support.c (add_symbol_overload_list_qualified): Remove
8581         declaration.
8582         * coffread.c (coff_symtab_read): Remove declaration.
8583         * symtab.c (lookup_symbol_in_objfile_symtabs)
8584         (basic_lookup_transparent_type_1): Use objfile_compunits.
8585         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8586         (info_sources_command, search_symbols)
8587         (default_collect_symbol_completion_matches_break_on)
8588         (make_source_files_completion_list): Remove declaration.
8589         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8590         (ada_collect_symbol_completion_matches)
8591         (ada_add_global_exceptions): Remove declaration.
8592         * linespec.c (iterate_over_all_matching_symtabs): Use
8593         objfile_compunits.
8594         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8595         (class objfile_compunits): New.
8596         (ALL_COMPUNITS): Use objfile_compunits.
8597         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8598         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8599         objfile_compunits.
8600         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8601
8602 2019-01-09  Tom Tromey  <tom@tromey.com>
8603
8604         * symtab.c (search_symbols)
8605         (default_collect_symbol_completion_matches_break_on): Use
8606         objfile_msymbols.
8607         * ada-lang.c (ada_lookup_simple_minsym)
8608         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8609         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8610         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8611         objfile_msymbols.
8612         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8613         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8614         * objc-lang.c (find_methods): Use objfile_msymbols.
8615         (info_selectors_command, info_classes_command): Likewise.
8616         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8617         * objfiles.h (class objfile_msymbols): New.
8618         (ALL_OBJFILE_MSYMBOLS): Remove.
8619         (ALL_MSYMBOLS): Remove.
8620
8621 2019-01-09  Tom Tromey  <tom@tromey.com>
8622
8623         * common/next-iterator.h (next_adapter): Add Iterator template
8624         parameter.
8625         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8626         (class all_objfiles_safe): New.
8627         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8628         * objfiles.c (put_objfile_before): Update comment.
8629         (add_separate_debug_objfile): Likewise.
8630         (free_all_objfiles): Use all_objfiles_safe.
8631         (objfile_purge_solibs): Likewise.
8632
8633 2019-01-09  Tom Tromey  <tom@tromey.com>
8634
8635         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8636         (expand_symtab_containing_pc, lookup_static_symbol)
8637         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8638         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8639         all_objfiles.
8640         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8641         * breakpoint.c (create_overlay_event_breakpoint)
8642         (create_longjmp_master_breakpoint)
8643         (create_std_terminate_master_breakpoint)
8644         (create_exception_master_breakpoint): Use all_objfiles.
8645         * linux-thread-db.c (try_thread_db_load_from_pdir)
8646         (has_libpthread): Use all_objfiles.
8647         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8648         * linespec.c (iterate_over_all_matching_symtabs)
8649         (search_minsyms_for_name): Use all_objfiles.
8650         * maint.c (maintenance_info_sections): Use all_objfiles.
8651         * main.c (captured_main_1): Use all_objfiles.
8652         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8653         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8654         * guile/scm-pretty-print.c
8655         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8656         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8657         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8658         (maintenance_print_msymbols): Use all_objfiles.
8659         * source.c (select_source_symtab): Use all_objfiles.
8660         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8661         * symfile.c (remove_symbol_file_command)
8662         (expand_symtabs_matching, map_symbol_filenames): Use
8663         all_objfiles.
8664         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8665         all_objfiles.
8666         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8667         * objc-lang.c (find_methods): Use all_objfiles.
8668         * objfiles.c (have_partial_symbols, have_full_symbols)
8669         (have_minimal_symbols, qsort_cmp)
8670         (default_iterate_over_objfiles_in_search_order): Use
8671         all_objfiles.
8672         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8673         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8674         (maintenance_check_psymtabs): Use all_objfiles.
8675         (ALL_PSYMTABS): Remove.
8676         * compile/compile-object-run.c (do_module_cleanup): Use
8677         all_objfiles.
8678         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8679         * cp-support.c (add_symbol_overload_list_qualified): Use
8680         all_objfiles.
8681         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8682         Use all_objfiles.
8683         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8684         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8685         all_objfiles.
8686         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8687         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8688         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8689         Uses all_objfiles.
8690         * solib.c (solib_read_symbols): Use all_objfiles
8691
8692 2019-01-09  Tom Tromey  <tom@tromey.com>
8693
8694         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8695         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8696         all_objfiles.
8697         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8698         * symmisc.c (print_symbol_bcache_statistics)
8699         (print_objfile_statistics, maintenance_print_objfiles)
8700         (maintenance_info_symtabs, maintenance_check_symtabs)
8701         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8702         all_objfiles.
8703         * source.c (forget_cached_source_info): Use all_objfiles.
8704         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8705         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8706         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8707         * objfiles.c (update_section_map): Use all_objfiles.
8708         (shared_objfile_contains_address_p): Likewise.
8709         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8710         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8711
8712 2019-01-09  Tom Tromey  <tom@tromey.com>
8713
8714         * common/next-iterator.h: New file.
8715         * objfiles.h (class all_objfiles): New.
8716         (struct objfile_iterator): New.
8717
8718 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8719
8720         * NEWS: Move the description of the changed "frame", "select-frame",
8721          and "info frame" commands to the Changed commands section.
8722
8723 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8724
8725         * gdbtypes.c (check_stub_method_group): Remove handling of old
8726         mangling schemes.
8727         * linespec.c (find_methods): Likewise.
8728         * stabsread.c (read_member_functions): Likewise.
8729         * valops.c (search_struct_method): Likewise.
8730         (value_struct_elt_for_reference): Likewise.
8731         * NEWS: Mention this change.
8732
8733 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8734
8735         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8736         print_source_lines.
8737         * source.c (print_source_lines_base): Update line number check.
8738         (print_source_lines): New function.
8739         (source_lines_range::source_lines_range): New function.
8740         * source.h (class source_lines_range): New class.
8741         (print_source_lines): New declaration.
8742
8743 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8744
8745         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8746
8747 2019-01-08  Tom Tromey  <tom@tromey.com>
8748             Simon Marchi  <simon.marchi@ericsson.com>
8749
8750         PR gdb/24060
8751         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8752         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8753         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8754         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8755         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8756         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8757
8758 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8759
8760         * source.c (select_source_symtab): Move header comment to
8761         declaration in source.h.
8762         (forget_cached_source_info_for_objfile): Likewise.
8763         (forget_cached_source_info): Likewise.
8764         (identify_source_line): Likewise.
8765         * source.h (identify_source_line): Move declaration from symtab.h
8766         and add comment from source.c
8767         (print_source_lines): Likewise.
8768         (forget_cached_source_info_for_objfile): Likewise.
8769         (forget_cached_source_info): Likewise.
8770         (select_source_symtab): Likewise.
8771         (enum print_source_lines_flag): Move definition from symtab.h.
8772         * symtab.h (identify_source_line): Move declaration to source.h.
8773         (print_source_lines): Likewise.
8774         (forget_cached_source_info_for_objfile): Likewise.
8775         (forget_cached_source_info): Likewise.
8776         (select_source_symtab): Likewise.
8777         (enum print_source_lines_flag): Move definition to source.h.
8778         * tui/tui-hooks.c: Add 'source.h' include.
8779
8780 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8781
8782         * source.c (print_source_lines_base): Handle requests to print
8783         reverse line number sequences, and guard against empty lines
8784         string.
8785
8786 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8787
8788         * source.c (print_source_lines_base): Fix skip of '\r' if next
8789         character is '\n'.
8790
8791 2019-01-06  Tom Tromey  <tom@tromey.com>
8792
8793         * c-exp.y (struct c_parse_state) <macro_original_text,
8794         expansion_obstack>: New member.
8795         (macro_original_text, expansion_obstack): Remove globals.
8796         (scan_macro_expansion, scanning_macro_expansion)
8797         (finished_macro_expansion): Update.
8798         (scan_macro_cleanup): Remove.
8799         (yylex, c_parse): Update.
8800
8801 2019-01-06  Tom Tromey  <tom@tromey.com>
8802
8803         * c-exp.y (struct c_parse_state) <strings>: New member.
8804         (operator_stoken): Update.
8805
8806 2019-01-06  Tom Tromey  <tom@tromey.com>
8807
8808         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8809         (union type_stack_elt) <typelist_val>: Now a pointer to
8810         std::vector.
8811         (type_stack_cleanup): Don't declare.
8812         (push_typelist): Update.
8813         * parse.c (pop_typelist): Return a std::vector.
8814         (push_typelist): Take a std::vector.
8815         (follow_types): Update.  Do not free args.
8816         (type_stack_cleanup): Remove.
8817         * c-exp.y (struct c_parse_state): New.
8818         (cpstate): New global.
8819         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8820         (nonempty_typelist): Update.
8821         (func_mod): Create a new vector.
8822         (c_parse): Create a c_parse_state.
8823         (check_parameter_typelist): Do not delete params.
8824         (function_method): Update.  Do not delete type_list.
8825
8826 2019-01-06  Tom Tromey  <tom@tromey.com>
8827
8828         PR gdb/28155:
8829         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8830         check_typedef.
8831         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8832         (print_return_value): Likewise.
8833
8834 2019-01-05  Tom Tromey  <tom@tromey.com>
8835
8836         * contrib/cleanup_check.py: Remove.
8837         * contrib/gcc-with-excheck: Remove.
8838         * contrib/exsummary.py: Remove.
8839         * contrib/excheck.py: Remove.
8840
8841 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8842
8843         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8844         NULL. Initialize tpprev to NULL instead of assigning it
8845         to NULL on the next statement.
8846         * windows-nat.c (windows_delete_thread): Remove check for
8847         main_thread_id before printing thread exit notifications.
8848         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8849         Remove thread ID check against main_thread_id.
8850         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8851         windows_delete_thread.
8852         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8853
8854 2019-01-04  Tom Tromey  <tom@tromey.com>
8855
8856         * compile/compile.c (_initialize_compile): Use upper case for
8857         metasyntactic variables.
8858         * symmisc.c (_initialize_symmisc): Use upper case for
8859         metasyntactic variables.
8860         * psymtab.c (_initialize_psymtab): Use upper case for
8861         metasyntactic variables.
8862         * demangle.c (demangle_command): Use upper case for metasyntactic
8863         variables.
8864         (_initialize_demangler): Likewise.
8865         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8866         variables.
8867
8868 2019-01-03  Tom Tromey  <tom@tromey.com>
8869
8870         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8871
8872 2019-01-03  Tom Tromey  <tom@tromey.com>
8873
8874         * python/py-symtab.c (salpy_str): Update.
8875         (struct salpy_sal_object) <symtab>: Now a PyObject.
8876         (salpy_dealloc): Update.
8877         (del_objfile_sal): Use gdbpy_ref.
8878
8879 2019-01-03  Tom Tromey  <tom@tromey.com>
8880
8881         * python/py-type.c (convert_field): Use new_reference.  Return
8882         gdbpy_ref.
8883         (make_fielditem): Return gdbpy_ref.
8884         (typy_fields): Update.
8885         (typy_getitem): Update.
8886         (field_name): Return gdbpy_ref.  Use new_reference.
8887         (typy_iterator_iternext): Update.
8888
8889 2019-01-03  Tom Tromey  <tom@tromey.com>
8890
8891         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8892
8893 2019-01-03  Tom Tromey  <tom@tromey.com>
8894
8895         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8896         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8897         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8898         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8899         (pspy_set_type_printers): Likewise.
8900         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8901         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8902         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8903         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8904         (objfpy_set_type_printers): Likewise.
8905
8906 2019-01-03  Tom Tromey  <tom@tromey.com>
8907
8908         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8909         (gdbpy_print_stack): Use gdbpy_err_fetch.
8910         * python/python-internal.h (class gdbpy_err_fetch): New class.
8911         (class gdbpy_enter) <m_error_type, m_error_value,
8912         m_error_traceback>: Remove.
8913         <m_error>: New member.
8914         (gdbpy_exception_to_string): Don't declare.
8915         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8916         * python/py-value.c (convert_value_from_python): Use
8917         gdbpy_err_fetch.
8918         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8919         gdbpy_exception_to_string.
8920         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8921         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8922         gdbpy_err_fetch.
8923
8924 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8925
8926         * linux-nat.c (delete_lwp_cleanup): Delete.
8927         (struct lwp_deleter): New struct.
8928         (lwp_info_up): New typedef.
8929         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8930         lwp_info_up.
8931
8932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * linux-fork.c (class scoped_switch_fork_info): New class.
8935         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8936
8937 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8938
8939         * valops.c (find_overload_match): Remove use of null_cleanup, and
8940         calls to do_cleanups.
8941
8942 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8943
8944         * compile/compile-cplus-types.c
8945         (compile_cplus_instance::decl_name): Handle changes to
8946         cp_func_name.
8947         * cp-support.c (cp_func_name): Update header comment, update
8948         return type.
8949         * cp-support.h (cp_func_name): Update return type in declaration.
8950         * valops.c (find_overload_match): Move temp_func local to top
8951         level of function and change its type.  Use temp_func to hold and
8952         delete temporary string obtained from cp_func_name.
8953
8954 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8955
8956         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8957         gdb::char_vector, remove cleanup, and update uses of `msg`.
8958
8959 2019-01-03  Jim Wilson  <jimw@sifive.com>
8960
8961         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8962
8963 2019-01-02  Tom Tromey  <tom@tromey.com>
8964
8965         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8966         (tdesc_parse_xml): Remove cleanups.
8967         * target-descriptions.h (make_cleanup_free_target_description):
8968         Don't declare.
8969         (target_desc_deleter): New struct.
8970         (target_desc_up): New typedef.
8971         * target-descriptions.c (target_desc_deleter::operator()): Rename
8972         from free_target_description.
8973         (make_cleanup_free_target_description): Remove.
8974
8975 2019-01-02  Tom Tromey  <tom@tromey.com>
8976
8977         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8978         constructor, destructor.
8979         (linespec_parser): Remove typedef.
8980         (~linespec_parser): Rename from linespec_parser_delete.
8981         (linespec_lex_to_end, linespec_complete_label)
8982         (linespec_complete): Update.
8983         (decode_line_full): Remove cleanups.
8984         (decode_line_1): Update.
8985
8986 2019-01-02  Tom Tromey  <tom@tromey.com>
8987
8988         * python/python-internal.h (inferior_to_inferior_object): Change
8989         return type.
8990         * python/py-exitedevent.c (create_exited_event_object): Update.
8991         * python/py-inferior.c (inferior_to_inferior_object): Return
8992         gdbpy_ref.
8993         (python_new_inferior, python_inferior_deleted)
8994         (thread_to_thread_object, delete_thread_object)
8995         (build_inferior_list, gdbpy_selected_inferior): Update.
8996         * python/py-infthread.c (create_thread_object): Update.  Also fail
8997         if inferior_to_inferior_object fails.
8998
8999 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
9000
9001         * inferior.h (class inferior) <displaced_step_state>: New field.
9002         * infrun.h (struct displaced_step_state): Move here from
9003         infrun.c.  Initialize fields, add constructor.
9004         <inf>: Remove field.
9005         <reset>: New method.
9006         * infrun.c (struct displaced_step_inferior_state): Move to
9007         infrun.h.
9008         (displaced_step_inferior_states): Remove.
9009         (get_displaced_stepping_state): Adust.
9010         (displaced_step_in_progress_any_inferior): Adjust.
9011         (displaced_step_in_progress_thread): Adjust.
9012         (displaced_step_in_progress): Adjust.
9013         (add_displaced_stepping_state): Remove.
9014         (get_displaced_step_closure_by_addr): Adjust.
9015         (remove_displaced_stepping_state): Remove.
9016         (infrun_inferior_exit): Call displaced_step_state.reset.
9017         (use_displaced_stepping): Don't check for NULL.
9018         (displaced_step_prepare_throw): Call
9019         get_displaced_stepping_state.
9020         (displaced_step_fixup): Don't check for NULL.
9021         (prepare_for_detach): Don't check for NULL.
9022
9023 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9024
9025         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9026          in case of call that did not complete.
9027
9028 2019-01-02  Andrey Utkin  <autkin@undo.io>
9029
9030         * symfile.c (find_separate_debug_file): Fix search of debug files for
9031         remote debuggee.
9032
9033 2019-01-02  Tom Tromey  <tom@tromey.com>
9034
9035         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9036         indentation.
9037         * python/py-frame.c (frapy_older): Remove cast.
9038         (frapy_newer): Likewise.
9039         * python/py-breakpoint.c (local_setattro): Remove cast.
9040         * python/py-arch.c (archpy_name): Remove local variable.
9041         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9042
9043 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9044
9045         * unittests/basic_string_view/element_access/char/empty.cc:
9046         Fix year range in copyright header.
9047
9048 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9049
9050         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9051         Delete.
9052         <operator==>: Update with for removed field.
9053         <hash>: Likewise.
9054         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9055         <isa_features>: ...this.
9056         <abi_features>: New field.
9057         (riscv_isa_flen): Update comment.
9058         (riscv_abi_xlen): New declaration.
9059         (riscv_abi_flen): New declaration.
9060         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9061         isa_features.
9062         (riscv_abi_xlen): New function.
9063         (riscv_isa_flen): Update to get answer from isa_features.
9064         (riscv_abi_flen): New function.
9065         (riscv_has_fp_abi): Update to get answer from abi_features.
9066         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9067         xlen and flen.
9068         (riscv_call_info) <xlen, flen>: Update comment.
9069         (riscv_call_arg_struct): Remove invalid assertions
9070         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9071         is removed.
9072         (riscv_gdbarch_init): Gather isa features and abi features
9073         separately, ensure both match on the gdbarch when reusing an old
9074         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9075         a target with 64-bit float hardware.
9076
9077 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9078
9079         * source.c (search_command_helper): Stop reverse search
9080         when line 1 has been searched.
9081
9082 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9083
9084         * record-full.c (record_full_base_target::close): Rewrite
9085         record_full_core_buf_list free logic.
9086
9087 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9088
9089         * break-catch-syscall.c (print_one_catch_syscall): xfree
9090         the last text.
9091
9092 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9093
9094         * top.c (print_gdb_version): Update Copyright year in version
9095         message.
9096
9097 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9098
9099         Update copyright year range in all GDB files.
9100
9101 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9102
9103         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9104
9105 For older changes see ChangeLog-2018.
9106 \f
9107 Local Variables:
9108 mode: change-log
9109 left-margin: 8
9110 fill-column: 74
9111 version-control: never
9112 coding: utf-8
9113 End:
9114