gdb/ChangeLog

   1 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
   4         make accesses into the vector constant references.
   5         (btrace_add_pc): Update for std::vector.
   6         (btrace_stitch_bts): Likewise.
   7         (parse_xml_btrace_block): Likewise.
   8         (btrace_maint_update_packets): Likewise.
   9         (btrace_maint_print_packets): Likewise.
  10         (maint_info_btrace_cmd): Likewise.
  11         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
  12         std::vector.
  13         (btrace_data::empty): Likewise.
  14         (btrace_data_append): Likewise.
  15         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
  16         (typedef btrace_block_s): Delete.
  17         (struct btrace_block): Add constructor.
  18         (struct btrace_data_bts) <blocks>: Change to std::vector.
  19         * nat/linux-btrace.c (perf_event_read_bts): Update for
  20         std::vector.
  21         (linux_read_bts): Likewise.
  22
  23 2019-10-01  Tom Tromey  <tom@tromey.com>
  24
  25         * cli/cli-logging.c (show_logging_filename): Use styled_string.
  26
  27 2019-10-01  Tom Tromey  <tom@tromey.com>
  28
  29         * stack.c (print_frame, info_frame_command_core): Use
  30         styled_string.
  31         * linux-thread-db.c (try_thread_db_load_1)
  32         (try_thread_db_load_from_pdir_1): Use styled_string.
  33         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
  34         (auto_load_section_scripts, info_auto_load_local_gdbinit)
  35         (maybe_print_unsupported_script_warning)
  36         (maybe_print_script_not_found_warning): Use styled_string.
  37         * ada-lang.c (user_select_syms): Use styled_string.
  38
  39 2019-10-01  Tom Tromey  <tom@tromey.com>
  40
  41         * p-lang.c (pascal_printstr): Use metadata style.
  42         * value.c (show_convenience): Use metadata style.
  43         * valprint.c (valprint_check_validity, val_print_optimized_out)
  44         (val_print_not_saved, val_print_unavailable)
  45         (val_print_invalid_address, generic_val_print, val_print)
  46         (value_check_printable, val_print_array_elements): Use metadata
  47         style.
  48         * ui-out.h (class ui_out) <field_fmt>: New overload.
  49         <do_field_fmt>: Add style parameter.
  50         * ui-out.c (ui_out::field_fmt): New overload.
  51         * typeprint.c (type_print_unknown_return_type)
  52         (val_print_not_allocated, val_print_not_associated): Use metadata
  53         style.
  54         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
  55         parameter.
  56         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
  57         * tracepoint.c (tvariables_info_1): Use metadata style.
  58         * stack.c (print_frame_arg, print_frame_info, print_frame)
  59         (info_frame_command_core): Use metadata style.
  60         * skip.c (info_skip_command): Use metadata style.
  61         * rust-lang.c (rust_print_enum): Use metadata style.
  62         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
  63         metadata style.
  64         * python/py-framefilter.c (py_print_single_arg): Use metadata
  65         style.
  66         * printcmd.c (do_one_display, print_variable_and_value): Use
  67         metadata style.
  68         * p-valprint.c (pascal_val_print)
  69         (pascal_object_print_value_fields): Use metadata style.
  70         * p-typeprint.c (pascal_type_print_base): Use metadata style.
  71         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
  72         parameter.
  73         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
  74         * m2-valprint.c (m2_print_long_set): Use metadata style.
  75         * m2-typeprint.c (m2_print_type): Use metadata style.
  76         * infcmd.c (print_return_value_1): Use metadata style.
  77         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
  78         * f-valprint.c (info_common_command_for_block): Use metadata
  79         style.
  80         * f-typeprint.c (f_type_print_base): Use metadata style.
  81         * expprint.c (print_subexp_standard): Use metadata style.
  82         * cp-valprint.c (cp_print_value_fields): Use metadata style.
  83         * cli/cli-style.h (class cli_style_option): Add constructor.
  84         (metadata_style): Declare.
  85         * cli/cli-style.c (metadata_style): New global.
  86         (_initialize_cli_style): Register metadata style.
  87         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
  88         parameter.
  89         * cli-out.c (cli_ui_out::do_field_fmt): Update.
  90         * c-typeprint.c (c_type_print_base_struct_union)
  91         (c_type_print_base_1): Use metadata style.
  92         * breakpoint.c (watchpoint_value_print)
  93         (print_one_breakpoint_location): Use metadata style.
  94         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
  95         style.
  96         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
  97         style.
  98         * ada-valprint.c (val_print_packed_array_elements, printstr)
  99         (print_field_values, ada_val_print_ref, ada_val_print): Use
 100         metadata style.
 101         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 102         style.
 103         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 104         style.
 105         * ada-lang.c (user_select_syms): Use metadata style.
 106
 107 2019-10-01  Tom Tromey  <tom@tromey.com>
 108
 109         * cli/cli-cmds.c (pwd_command): Style output.
 110
 111 2019-10-01  Pedro Alves  <palves@redhat.com>
 112             Tom Tromey  <tom@tromey.com>
 113
 114         * symtab.c (print_symbol_info): Use %ps.
 115         (print_msymbol_info): Use %ps.
 116         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 117         * printcmd.c (print_variable_and_value): Use %ps.
 118         * macrocmd.c (show_pp_source_pos): Use %ps.
 119         * infrun.c (print_exited_reason): Use ui_out::message.
 120         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 121         (describe_other_breakpoints): Use ui_out::message and new
 122         formats.
 123         (say_where): Use new formats.
 124         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 125         and new formats.
 126
 127 2019-10-01  Pedro Alves  <palves@redhat.com>
 128             Tom Tromey  <tom@tromey.com>
 129
 130         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 131         (test_gdb_formats): New function.
 132         (run_tests): Call it.
 133         (test_format_specifier): Update.
 134         * utils.h (fputs_filtered): Update comment.
 135         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 136         (fputs_styled_unfiltered): Declare.
 137         * utils.c (fputs_styled_unfiltered): New function.
 138         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 139         (vfprintf_filtered): Update.
 140         (vfprintf_unfiltered, vprintf_filtered): Update.
 141         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 142         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 143         disallow_ui_out_field>: New constants.
 144         (enum class field_kind): New.
 145         (struct base_field_s, struct signed_field_s): New.
 146         (signed_field): New function.
 147         (struct string_field_s): New.
 148         (string_field): New function.
 149         (struct styled_string_s): New.
 150         (styled_string): New function.
 151         (class ui_out) <message>: Add comment.
 152         <vmessage, call_do_message>: New methods.
 153         <do_message>: Add style parameter.
 154         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 155         methods.
 156         (ui_out::message): Rewrite.
 157         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 158         parameter.
 159         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 160         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 161         gdb_extensions parameter.
 162         (class format_piece): Add parameter to constructor.
 163         (n_int_args): New field.
 164         * gdbsupport/format.c (format_pieces::format_pieces): Add
 165         gdb_extensions parameter.  Handle '*'.
 166         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 167         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 168         vfprintf_styled_no_gdbfmt.
 169         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 170         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 171         unfiltered output.
 172         * ui-style.h (struct ui_file_style) <ptr>: New method.
 173
 174 2019-10-01  Tom Tromey  <tom@tromey.com>
 175
 176         * unittests/format_pieces-selftests.c: Update.  Add final format.
 177         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 178         empty literal pieces.
 179
 180 2019-10-01  Tom Tromey  <tom@tromey.com>
 181
 182         * ui-out.h (enum class ui_out_style_kind): Remove.
 183         (class ui_out) <field_string, field_stsream, do_field_string>:
 184         Change type of "style".
 185         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 186         (ui_out::field_string): Update.
 187         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 188         of "style".
 189         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 190         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 191         * stack.c (print_frame_arg, print_frame_info, print_frame):
 192         Update.
 193         * source.c (print_source_lines_base): Update.
 194         * solib.c (info_sharedlibrary_command): Update.
 195         * skip.c (info_skip_command): Update.
 196         * record-btrace.c (btrace_call_history_src_line)
 197         (btrace_call_history): Update.
 198         * python/py-framefilter.c (py_print_frame): Update.
 199         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 200         "style".
 201         * mi/mi-out.c (mi_ui_out::do_table_header)
 202         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 203         (mi_ui_out::do_field_string): Update.
 204         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 205         Update.
 206         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 207         "style".
 208         * cli-out.c (cli_ui_out::do_table_header)
 209         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 210         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 211         (cli_ui_out::do_field_fmt): Update.
 212         * breakpoint.c (print_breakpoint_location): Update.
 213         (update_static_tracepoint): Update.
 214
 215 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 216
 217         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 218         conversion of gdb_datadir.
 219         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 220         remove not needed c_str ().
 221
 222 2019-09-30  Ali Tamur <tamur@google.com>
 223
 224         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 225         (dwarf2_string_attr): Likewise.
 226
 227 2019-09-30  Ali Tamur <tamur@google.com>
 228
 229         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 230         (process_full_type_unit): Likewise.
 231         (dump_die_shallow): Likewise.
 232         (cu_debug_loc_section): Likewise.
 233
 234 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 235
 236         * minsyms.c (compare_minimal_symbols): Rename to...
 237         (minimal_symbol_is_less_than): ...this, and adjust to STL
 238         conventions (return bool, take arguments as references)
 239         (minimal_symbol_reader::install): Call std::sort instead
 240         of qsort.
 241
 242 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 243
 244         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 245         hash and why.
 246         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 247         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 248
 249 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 250
 251         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 252         * psympriv.h (add_psymbol_to_list): Move comment here and update
 253         it.
 254
 255 2019-09-29  Tom de Vries  <tdevries@suse.de>
 256
 257         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 258         Use $tmpdir/$(basename "$output_file").dwz instead of
 259         "${output_file}.dwz".
 260
 261 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 262
 263         PR gdb/25045
 264         * hppa-linux-nat.c: Include gdbarch.h.
 265
 266 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 267
 268         * blockframe.c (find_pc_partial_function): Change return type to bool.
 269         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 270         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 271         (stub_gnu_ifunc_resolve_name): Likewise.
 272         * symtab.c (compare_filenames_for_search): Likewise.
 273         (compare_glob_filenames_for_search): Likewise.
 274         (matching_obj_sections): Likewise.
 275         (symbol_matches_domain): Likewise.
 276         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 277         (find_line_pc): Change return type to bool.
 278         (find_line_pc_range): Likewise.
 279         (producer_is_realview): Likewise.
 280         * symtab.h (symbol_matches_domain): Likewise.
 281         (find_pc_partial_function): Likewise.
 282         (find_pc_line_pc_range): Likewise.
 283         (in_gnu_ifunc_stub): Likewise.
 284         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 285         (find_line_pc): Likewise.
 286         (find_line_pc_range): Likewise.
 287         (matching_obj_sections): Likewise.
 288         (find_line_symtab): Change out parameter to bool.
 289         (producer_is_realview): Change return type to bool.
 290         (compare_filenames_for_search): Likewise.
 291         (compare_glob_filenames_for_search): Likewise.
 292
 293 2019-09-26  Tom Tromey  <tom@tromey.com>
 294
 295         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 296         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 297         * gdb_usleep.h: Remove.
 298         * gdb_usleep.c: Remove.
 299         * utils.c: Don't include gdb_usleep.h.
 300
 301 2019-09-26  Tom Tromey  <tromey@adacore.com>
 302
 303         * python/py-type.c (type_to_type_object): Call check_typedef
 304         for stub types.
 305
 306 2019-09-26  Tom Tromey  <tom@tromey.com>
 307
 308         * utils.h (initialize_utils): Don't declare.
 309         * top.c (gdb_init): Don't call initialize_utils.
 310         * utils.c (initialize_utils): Remove.  Move contents...
 311         (_initialize_utils): ... here.
 312
 313 2019-09-25  Tom Tromey  <tom@tromey.com>
 314
 315         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 316         * utils.h (make_hex_string): Don't declare.
 317         * utils.c (make_hex_string): Remove.
 318
 319 2019-09-24  Tom de Vries  <tdevries@suse.de>
 320
 321         PR gdb/23815
 322         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 323         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 324
 325 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 326
 327         * NEWS: Mention new simulator port for PRU.
 328
 329 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 330
 331         * ada-exp.y (write_object_remaining): Update.
 332         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 333         and eliminate the static buffer.
 334         (ada_decode_symbol): Update.
 335         (ada_la_decode): Update.
 336         (ada_sniff_from_mangled_name): Update.
 337         (is_valid_name_for_wild_match): Update.
 338         (ada_lookup_name_info::matches): Update and simplify.
 339         (name_matches_regex): Update.
 340         (ada_add_global_exceptions): Update.
 341         * ada-lang.h (ada_decode): Update signature.
 342         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 343         * dwarf-index-write.c (debug_names::insert): Update.
 344
 345 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 346
 347         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 348         formatting.
 349
 350 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 351
 352         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 353         Change "nonzero" to "true" in documentation.
 354
 355 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 356
 357         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 358         (_initialize_darwin_solib): Don't set
 359         darwin_so_ops.lookup_lib_global_symbol.
 360         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 361         set_gdbarch_iterate_over_objfiles_in_search_order.
 362         (elf_lookup_lib_symbol): Rename to...
 363         (svr4_iterate_over_objfiles_in_search_order): this, and update
 364         to iterate semantics.
 365         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 366         * solib.c (solib_global_lookup): Remove.
 367         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 368         (solib_global_lookup): Remove.
 369         * symtab.c (lookup_global_or_static_symbol): Remove call to
 370         solib_global_lookup.
 371
 372 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 373
 374         * NEWS: Move entries about default MI version now being
 375         version 3, and about the GDB/MI fix for multi-location
 376         breakpoints to the "since GDB 8.3" section.
 377
 378 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 379
 380         GDB 8.3.1 released.
 381
 382 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 383
 384         * NEWS: Mention that Cell/B.E. debugging support was removed.
 385         * MAINTAINERS: Remove spu target.
 386
 387         * config/djgpp/fnchange.lst: Remove entries for removed files.
 388
 389         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 390         spu-multiarch.o, and spu-tdep.o.
 391         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 392         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 393         spu-multiarch.c, and spu-tdep.c.
 394         * spu-linux-nat.c: Remove file.
 395         * spu-multiarch.c: Remove file.
 396         * spu-tdep.c: Remove file.
 397         * spu-tdep.h: Remove file.
 398         * solib-spu.c: Remove file.
 399         * solib-spu.h: Remove file.
 400
 401         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 402         * configure.nat (spu-linux): Remove.
 403         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 404         solib-multiarch.o from gdb_target_obs.
 405         (spu*-*-*): Remove.
 406
 407         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 408         feature flag.
 409         (ppc_linux_no_features): Update.
 410         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 411         Cell/B.E. support.
 412         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 413         (tdesc_powerpc_cell64l): Likewise.
 414         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 415         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 416         Cell/B.E. support.
 417         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 418         Do not include "features/rs6000/powerpc-cell32l.c" or
 419         "features/rs6000/powerpc-cell64l.c".
 420         (ppc_linux_spu_section): Remove.
 421         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 422         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 423         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 424         (ppc_linux_spe_context_lookup): Remove.
 425         (ppc_linux_spe_context_inferior_created): Remove.
 426         (ppc_linux_spe_context_solib_loaded): Remove.
 427         (ppc_linux_spe_context_solib_unloaded): Remove.
 428         (ppc_linux_spe_context): Remove.
 429         (struct ppu2spu_cache): Remove.
 430         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 431         (struct ppu2spu_data): Remove.
 432         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 433         ppu2spu_unwind): Remove.
 434         (ppc_linux_init_abi): Remove Cell/B.E. support.
 435         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 436
 437         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 438         (rs6000/powerpc-cell64l-expedite): Likewise
 439         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 440         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 441         rs6000/powerpc-cell64l.xml.
 442         * features/rs6000/powerpc-cell32l.xml: Remove.
 443         * features/rs6000/powerpc-cell64l.xml: Likewise.
 444         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 445         * features/rs6000/powerpc-cell64l.c: Likewise.
 446         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 447         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 448         * regformats/reg-spu.dat: Remove.
 449
 450         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 451         * corelow.c (struct spuid_list): Remove.
 452         (add_to_spuid_list): Remove.
 453         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 454         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 455         (remote_protocol_features): Remove associated entries.
 456         (_initialize_remote): No longer initialize them.
 457         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 458         * linux-nat.c (SPUFS_MAGIC): Remove.
 459         (linux_proc_xfer_spu): Remove.
 460         (spu_enumerate_spu_ids): Remove.
 461         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 462         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 463         (linux_make_corefile_notes): No longer call it.
 464
 465         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 466         (cooked_write_test): Likewise.
 467
 468 2019-09-20  Tom Tromey  <tom@tromey.com>
 469
 470         * NEWS: Mention case-sensitivity of TUI commands.
 471         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 472         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 473         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 474
 475 2019-09-20  Tom Tromey  <tom@tromey.com>
 476
 477         * tui/tui-source.c (tui_source_window::set_contents): Use
 478         make_unique_xstrdup.
 479         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 480         make_unique_xstrdup.
 481
 482 2019-09-20  Tom Tromey  <tom@tromey.com>
 483
 484         * tui/tui-data.c: Remove separator comments.
 485         * tui/tui-layout.c: Remove separator comments.
 486         * tui/tui-win.c: Remove separator comments.
 487         * tui/tui-wingeneral.c: Remove separator comments.
 488
 489 2019-09-20  Tom Tromey  <tom@tromey.com>
 490
 491         * tui/tui.h (strcat_to_buf): Don't declare.
 492         * tui/tui.c (strcat_to_buf): Remove.
 493
 494 2019-09-20  Tom Tromey  <tom@tromey.com>
 495
 496         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 497         from "fullname".
 498         * tui/tui-source.c (tui_source_window::set_contents)
 499         (tui_source_window::location_matches_p)
 500         (tui_source_window::maybe_update): Update.
 501
 502 2019-09-20  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 505         Update.
 506         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 507         prefix.
 508         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 509         (tui_data_window::line_from_reg_element_no)
 510         (tui_data_window::first_reg_element_no_inline)
 511         (tui_data_window::show_registers)
 512         (tui_data_window::show_register_group)
 513         (tui_data_window::display_registers_from)
 514         (tui_data_window::display_registers_from_line)
 515         (tui_data_window::first_data_item_displayed)
 516         (tui_data_window::delete_data_content_windows)
 517         (tui_data_window::erase_data_content)
 518         (tui_data_window::do_scroll_vertical)
 519         (tui_data_window::refresh_window)
 520         (tui_data_window::check_register_values): Update.
 521
 522 2019-09-20  Tom Tromey  <tom@tromey.com>
 523
 524         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 525         (struct tui_locator_window) <full_name, proc_name>: Now
 526         std::string.
 527         * tui/tui-stack.c (tui_locator_window::make_status_line)
 528         (tui_locator_window::set_locator_fullname)
 529         (tui_locator_window::set_locator_info): Update.
 530         * tui/tui-source.c (tui_source_window::set_contents)
 531         (tui_source_window::showing_source_p): Update.
 532
 533 2019-09-20  Tom Tromey  <tom@tromey.com>
 534
 535         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 536         Don't call tui_locator_win_info_ptr.
 537
 538 2019-09-20  Tom Tromey  <tom@tromey.com>
 539
 540         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 541
 542 2019-09-20  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 545         height for locator.
 546         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 547         * tui/tui-layout.c (show_source_disasm_command, show_data)
 548         (show_source_or_disasm_and_command): Use 1 as height for locator.
 549
 550 2019-09-20  Tom Tromey  <tom@tromey.com>
 551
 552         * tui/tui.c (tui_enable): Update.
 553         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 554         Update.
 555         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 556         Update.
 557         * tui/tui-data.c (win_resized): Now bool.
 558         (tui_win_resized): Return bool.
 559         (tui_set_win_resized_to): Accept a bool.
 560
 561 2019-09-20  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 564         Change type of "refresh_values_only".
 565         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 566         type of "refresh_values_only".
 567
 568 2019-09-20  Tom Tromey  <tom@tromey.com>
 569
 570         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 571         std::string.
 572         (tui_disassemble): Add "pos" parameter.
 573         (tui_disasm_window::set_contents): Simplify.
 574
 575 2019-09-20  Tom Tromey  <tom@tromey.com>
 576
 577         * tui/tui-winsource.h (struct tui_source_window_base)
 578         <show_source_content>: Now private.
 579         * tui/tui-winsource.c
 580         (tui_source_window_base::show_source_content): Don't handle empty
 581         content case.
 582
 583 2019-09-20  Tom Tromey  <tom@tromey.com>
 584
 585         * tui/tui-layout.c (show_source_disasm_command)
 586         (show_source_or_disasm_and_command): Don't call
 587         show_source_content.
 588
 589 2019-09-20  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 592         Declare.
 593         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 594         from tui_make_status_line.
 595         (tui_locator_window::rerender): Update.
 596
 597 2019-09-20  Tom Tromey  <tom@tromey.com>
 598
 599         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 600         (tui_locator_window::rerender): Update.
 601
 602 2019-09-20  Tom Tromey  <tom@tromey.com>
 603
 604         * tui/tui-winsource.h (struct tui_source_window_base)
 605         <~tui_source_window_base>: Don't declare.
 606         <fullname>: Remove.
 607         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 608         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 609         member.
 610         * tui/tui-source.c (tui_source_window::set_contents): Update.
 611         (tui_source_window::location_matches_p)
 612         (tui_source_window::maybe_update): Update.
 613
 614 2019-09-20  Tom Tromey  <tom@tromey.com>
 615
 616         * tui/tui-winsource.h (~tui_source_element): Remove.
 617         (tui_source_element): Update.
 618         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 619         * tui/tui-winsource.c (tui_show_source_line): Update.
 620         * tui/tui-source.c (tui_source_window::set_contents): Update.
 621         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 622
 623 2019-09-20  Tom Tromey  <tom@tromey.com>
 624
 625         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 626         declare.
 627         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 628         tui_clear_source_windows_detail.
 629         * tui/tui-winsource.h (struct tui_source_window_base)
 630         <clear_detail>: Don't declare.
 631         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 632         Remove.
 633         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 634
 635 2019-09-20  Tom Tromey  <tromey@adacore.com>
 636
 637         PR ada/24919:
 638         * block.c (contained_in): Fix final return value.
 639
 640 2019-09-20  Alan Modra  <amodra@gmail.com>
 641
 642         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 643         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 644         (read_indirect_string_from_dwz): Use bfd accessor.
 645         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 646         * machoread.c (macho_symfile_read_all_oso): Likewise.
 647         * solib.c (solib_bfd_open): Likewise.
 648
 649 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 650
 651         * eval.c: Move declaration of overload_resolution to...
 652         * value.h: ...here.
 653
 654 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 655
 656         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 657         * arm-linux-tdep.c: Likewise.
 658         * arm-nbsd-nat.c: Likewise.
 659         * arm-tdep.h: Declare arm_apcs_32.
 660         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 661
 662 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 663
 664         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 665         * dwarf2read.h: Declare dwarf_always_disassemble.
 666
 667 2019-09-19  Tom de Vries  <tdevries@suse.de>
 668
 669         PR gdb/25009
 670         * source-cache.c (source_cache::ensure): Catch exception thrown during
 671         construction of the highlighter.
 672
 673 2019-09-18  Alan Modra  <amodra@gmail.com>
 674
 675         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 676         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 677         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 678         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 679         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 680         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 681         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 682         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 683         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 684         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 685         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 686         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 687         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 688         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 689         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 690         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 691         * mi/mi-interp.c: Update throughout for bfd section macro and
 692         function changes.
 693         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 694         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 695
 696 2019-09-18  Tom Tromey  <tom@tromey.com>
 697
 698         * NEWS: Add entry.
 699         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 700         call rl_initialize.
 701         (tui_enable): Do not call rl_initialize.
 702
 703 2019-09-18  Christian Groessler  <chris@groessler.org>
 704
 705         * alpha-linux-nat.c: Include gdbarch.h.
 706
 707 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 708
 709         * ui-file.c: Include cli/cli-style.h.
 710         (term_cli_styling): Remove cli_styling declaration.
 711
 712 2019-09-18  Alan Modra  <amodra@gmail.com>
 713
 714         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 715         to bfd_asymbol_section.
 716
 717 2019-09-18  Alan Modra  <amodra@gmail.com>
 718
 719         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 720         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 721         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 722
 723 2019-09-18  Alan Modra  <amodra@gmail.com>
 724
 725         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 726         * spu-linux-nat.c (spu_bfd_open): Likewise.
 727
 728 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 729
 730         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 731         to bool to match definition in dwarf2read.c.
 732
 733 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 734
 735         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 736         (print_signatures): Likewise.
 737         (trust_pad_over_xvs): Likewise.
 738         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 739         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 740         * arm-linux-nat.c (arm_apcs_32): Likewise.
 741         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 742         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 743         * arm-tdep.c (arm_debug): Likewise.
 744         (arm_apcs_32): Likewise.
 745         * auto-load.c (debug_auto_load): Likewise.
 746         (auto_load_gdb_scripts): Likewise.
 747         (global_auto_load): Likewise.
 748         (auto_load_local_gdbinit): Likewise.
 749         (auto_load_local_gdbinit_loaded): Likewise.
 750         * auto-load.h (global_auto_load): Likewise.
 751         (auto_load_local_gdbinit): Likewise.
 752         (auto_load_local_gdbinit_loaded): Likewise.
 753         * breakpoint.c (disconnected_dprintf): Likewise.
 754         (breakpoint_proceeded): Likewise.
 755         (automatic_hardware_breakpoints): Likewise.
 756         (always_inserted_mode): Likewise.
 757         (target_exact_watchpoints): Likewise.
 758         (_initialize_breakpoint): Update.
 759         * breakpoint.h (target_exact_watchpoints): Change to bool.
 760         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 761         * cli/cli-cmds.c (trace_commands): Likewise.
 762         * cli/cli-cmds.h (trace_commands): Likewise.
 763         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 764         to bool*.
 765         * cli/cli-logging.c (logging_overwrite): Change to bool.
 766         (logging_redirect): Likewise.
 767         (debug_redirect): Likewise.
 768         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 769         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 770         to bool.
 771         <boolean_option_def>: Update.
 772         (struct flag_option_def): Change default type of Context to bool
 773         from int.
 774         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 775         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 776         (get_setshow_command_value_string): Likewise.
 777         * cli/cli-style.c (cli_styling): Change to bool.
 778         (source_styling): Likewise.
 779         * cli/cli-style.h (source_styling): Likewise.
 780         (cli_styling): Likewise.
 781         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 782         to bool.
 783         * command.h (var_types): Update comment.
 784         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 785         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 786         bool.
 787         (debug_compile_cplus_scopes): Likewise.
 788         * compile/compile-internal.h (compile_debug): Likewise.
 789         * compile/compile.c (compile_debug): Likewise.
 790         (struct compile_options) <raw>: Likewise.
 791         * cp-support.c (catch_demangler_crashes): Likewise.
 792         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 793         (usr_cmd_cris_dwarf2_cfi): Likewise.
 794         * csky-tdep.c (csky_debug): Likewise.
 795         * darwin-nat.c (enable_mach_exceptions): Likewise.
 796         * dcache.c (dcache_enabled_p): Likewise.
 797         * defs.h (info_verbose): Likewise.
 798         * demangle.c (demangle): Likewise.
 799         (asm_demangle): Likewise.
 800         * dwarf-index-cache.c (debug_index_cache): Likewise.
 801         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 802         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 803         * dwarf2read.c (check_physname): Likewise.
 804         (use_deprecated_index_sections): Likewise.
 805         (dwarf_always_disassemble): Likewise.
 806         * eval.c (overload_resolution): Likewise.
 807         * event-top.c (set_editing_cmd_var): Likewise.
 808         (exec_done_display_p): Likewise.
 809         * event-top.h (set_editing_cmd_var): Likewise.
 810         (exec_done_display_p): Likewise.
 811         * exec.c (write_files): Likewise.
 812         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 813         (debug_fbsd_nat): Likewise.
 814         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 815         Likewise.
 816         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 817         <backtrace_past_entry> Likewise.
 818         * gdb-demangle.h (demangle): Likewise.
 819         (asm_demangle): Likewise.
 820         * gdb_bfd.c (bfd_sharing): Likewise.
 821         * gdbcore.h (write_files): Likewise.
 822         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 823         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 824         * gdbthread.h (print_thread_events): Likewise.
 825         * gdbtypes.c (opaque_type_resolution): Likewise.
 826         (strict_type_checking): Likewise.
 827         * gnu-nat.c (gnu_debug_flag): Likewise.
 828         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 829         * guile/scm-param.c (pascm_variable): Add boolval.
 830         (add_setshow_generic): Update.
 831         (pascm_param_value): Update.
 832         (pascm_set_param_value_x): Update.
 833         * hppa-tdep.c (hppa_debug): Change to bool..
 834         * infcall.c (may_call_functions_p): Likewise.
 835         (coerce_float_to_double_p): Likewise.
 836         (unwind_on_signal_p): Likewise.
 837         (unwind_on_terminating_exception_p): Likewise.
 838         * infcmd.c (startup_with_shell): Likewise.
 839         * inferior.c (print_inferior_events): Likewise.
 840         * inferior.h (startup_with_shell): Likewise.
 841         (print_inferior_events): Likewise.
 842         * infrun.c (step_stop_if_no_debug): Likewise.
 843         (detach_fork): Likewise.
 844         (debug_displaced): Likewise.
 845         (disable_randomization): Likewise.
 846         (non_stop): Likewise.
 847         (non_stop_1): Likewise.
 848         (observer_mode): Likewise.
 849         (observer_mode_1): Likewise.
 850         (set_observer_mode): Update.
 851         (sched_multi): Change to bool.
 852         * infrun.h (debug_displaced): Likewise.
 853         (sched_multi): Likewise.
 854         (step_stop_if_no_debug): Likewise.
 855         (non_stop): Likewise.
 856         (disable_randomization): Likewise.
 857         * linux-tdep.c (use_coredump_filter): Likewise.
 858         (dump_excluded_mappings): Likewise.
 859         * linux-thread-db.c (auto_load_thread_db): Likewise.
 860         (check_thread_db_on_load): Likewise.
 861         * main.c (captured_main_1): Update.
 862         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 863         xx2_opt, boolean_opt>: Change to bool.
 864         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 865         * maint.c (maintenance_profile_p): Likewise.
 866         (per_command_time): Likewise.
 867         (per_command_space): Likewise.
 868         (per_command_symtab): Likewise.
 869         * memattr.c (inaccessible_by_default): Likewise.
 870         * mi/mi-main.c (mi_async): Likewise.
 871         (mi_async_1): Likewise.
 872         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
 873         * nat/fork-inferior.h (startup_with_shell): Likewise.
 874         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
 875         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
 876         * nios2-tdep.c (nios2_debug): Likewise.
 877         * or1k-tdep.c (or1k_debug): Likewise.
 878         * parse.c (parser_debug): Likewise.
 879         * parser-defs.h (parser_debug): Likewise.
 880         * printcmd.c (print_symbol_filename): Likewise.
 881         * proc-api.c (procfs_trace): Likewise.
 882         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
 883         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
 884         (set_parameter_value): Update.
 885         (add_setshow_generic): Update.
 886         * python/py-value.c (copy_py_bool_obj): Change argument from int*
 887         to bool*.
 888         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
 889         int*.
 890         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
 891         * record-btrace.c (record_btrace_target::store_registers): Update.
 892         * record-full.c (record_full_memory_query): Change to bool.
 893         (record_full_stop_at_limit): Likewise.
 894         * record-full.h (record_full_memory_query): Likewise.
 895         * remote-notif.c (notif_debug): Likewise.
 896         * remote-notif.h (notif_debug): Likewise.
 897         * remote.c (use_range_stepping): Likewise.
 898         (interrupt_on_connect): Likewise.
 899         (remote_break): Likewise.
 900         * ser-tcp.c (tcp_auto_retry): Likewise.
 901         * ser-unix.c (serial_hwflow): Likewise.
 902         * skip.c (debug_skip): Likewise.
 903         * solib-aix.c (solib_aix_debug): Likewise.
 904         * spu-tdep.c (spu_stop_on_load_p): Likewise.
 905         (spu_auto_flush_cache_p): Likewise.
 906         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
 907         Likewise.
 908         (struct info_print_options) <quiet>: Likewise.
 909         * symfile-debug.c (debug_symfile): Likewise.
 910         * symfile.c (auto_solib_add): Likewise.
 911         (separate_debug_file_debug): Likewise.
 912         * symfile.h (auto_solib_add): Likewise.
 913         (separate_debug_file_debug): Likewise.
 914         * symtab.c (basenames_may_differ): Likewise.
 915         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
 916         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
 917         (struct info_types_options) <quiet>: Likewise.
 918         * symtab.h (demangle): Likewise.
 919         (basenames_may_differ): Likewise.
 920         * target-dcache.c (stack_cache_enabled_1): Likewise.
 921         (code_cache_enabled_1): Likewise.
 922         * target.c (trust_readonly): Likewise.
 923         (may_write_registers): Likewise.
 924         (may_write_memory): Likewise.
 925         (may_insert_breakpoints): Likewise.
 926         (may_insert_tracepoints): Likewise.
 927         (may_insert_fast_tracepoints): Likewise.
 928         (may_stop): Likewise.
 929         (auto_connect_native_target): Likewise.
 930         (target_stop_and_wait): Update.
 931         (target_async_permitted): Change to bool.
 932         (target_async_permitted_1): Likewise.
 933         (may_write_registers_1): Likewise.
 934         (may_write_memory_1): Likewise.
 935         (may_insert_breakpoints_1): Likewise.
 936         (may_insert_tracepoints_1): Likewise.
 937         (may_insert_fast_tracepoints_1): Likewise.
 938         (may_stop_1): Likewise.
 939         * target.h (target_async_permitted): Likewise.
 940         (may_write_registers): Likewise.
 941         (may_write_memory): Likewise.
 942         (may_insert_breakpoints): Likewise.
 943         (may_insert_tracepoints): Likewise.
 944         (may_insert_fast_tracepoints): Likewise.
 945         (may_stop): Likewise.
 946         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
 947         (make_thread_apply_all_options_def_group): Change argument from int*
 948         to bool*.
 949         (thread_apply_all_command): Update.
 950         (print_thread_events): Change to bool.
 951         * top.c (confirm): Likewise.
 952         (command_editing_p): Likewise.
 953         (history_expansion_p): Likewise.
 954         (write_history_p): Likewise.
 955         (info_verbose): Likewise.
 956         * top.h (confirm): Likewise.
 957         (history_expansion_p): Likewise.
 958         * tracepoint.c (disconnected_tracing): Likewise.
 959         (circular_trace_buffer): Likewise.
 960         * typeprint.c (print_methods): Likewise.
 961         (print_typedefs): Likewise.
 962         * utils.c (debug_timestamp): Likewise.
 963         (sevenbit_strings): Likewise.
 964         (pagination_enabled): Likewise.
 965         * utils.h (sevenbit_strings): Likewise.
 966         (pagination_enabled): Likewise.
 967         * valops.c (overload_resolution): Likewise.
 968         * valprint.h (struct value_print_options) <prettyformat_arrays,
 969         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
 970         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
 971         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
 972         Likewise.
 973         * windows-nat.c (new_console): Likewise.
 974         (cygwin_exceptions): Likewise.
 975         (new_group): Likewise.
 976         (debug_exec): Likewise.
 977         (debug_events): Likewise.
 978         (debug_memory): Likewise.
 979         (debug_exceptions): Likewise.
 980         (useshell): Likewise.
 981         * windows-tdep.c (maint_display_all_tib): Likewise.
 982         * xml-support.c (debug_xml): Likewise.
 983
 984 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
 985
 986         * source.c (prepare_path_for_appending): New function.
 987         (openp): Make use of new function.
 988         (find_and_open_source): Search for the compilation directory and
 989         source file as a relative path beneath the directory search path.
 990
 991 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
 992
 993         * source-cache.c (source_cache::get_line_charpos): Catch
 994         exceptions and return false, this matches the behaviour documented
 995         in the header file.
 996
 997 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
 998
 999         * ada-tasks.c (info_task): Remove quoting of the task's name.
1000
1001 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1002
1003         * symfile.c (auto_solib_add): Replace comment with a reference
1004         to the header file.
1005
1006 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1007
1008         * NEWS: Mention that gdb can now be compiled with Python 3
1009         on Windows.
1010
1011 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1012
1013         * maint.c (maint_print_section_data::maint_print_section_data):
1014         Force use of 'float log10 (float)' by casting the argument to
1015         float.
1016
1017 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * maint.c: Add 'cmath' include.
1020         (struct maint_print_section_data): New structure.
1021         (print_section_index): New function.
1022         (print_bfd_section_info): Add header comment, small whitespace
1023         cleanup, and update to call new print_section_index function.
1024         (print_objfile_section_info): Likewise.
1025         (maint_obj_section_from_bfd_section): New function.
1026         (print_bfd_section_info_maybe_relocated): New function.
1027         (maintenance_info_sections): Add header comment, always use
1028         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1029
1030 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1031
1032         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1033         inner scope, add check that the objfile has psymtabs before
1034         checking psymtabs_addrmap.
1035         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1036
1037 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1038
1039         * NEWS: Announce that Ada task names are now shown at more places,
1040         and between quotes (except in info task output).
1041         * gdb/ada-tasks.c (task_to_str): New function.
1042         (display_current_task_id): Call task_to_str.
1043         (task_command_1): Likewise.
1044         (print_ada_task_info): In non-mi mode, Properly align headers and data
1045         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1046
1047 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1048
1049         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1050         prstatus.pr_lwp.pr_info instead of making it up.
1051
1052 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1053
1054         * auto-load.c (auto_load_expand_dir_vars): Update.
1055         * defs.h (gdb_datadir): Change to std::string.
1056         (python_libdir): Likewise.
1057         (relocate_gdb_directory): Change return type to std::string.
1058         * guile/guile.c (gdbscm_data_directory): Update.
1059         (initialize_scheme_side): Update.
1060         * jit.c (jit_reader_dir): Change to std::string.
1061         (jit_reader_load_command): Update.
1062         * main.c (gdb_datadir): Change to std::string.
1063         (python_libdir): Likewise.
1064         (set_gdb_data_directory): Update.
1065         (relocate_path): Change to return std::string.
1066         (relocate_gdb_directory): Change to return std::string.
1067         (relocate_gdbinit_path_maybe_in_datadir): Update.
1068         (captured_main_1): Update.
1069         * python/python.c (do_start_initialization): Update.
1070         * top.c (show_gdb_datadir): Update.
1071         * xml-syscall.c (xml_init_syscalls_info): Update.
1072         (init_syscalls_info): Update.
1073
1074 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1075
1076         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1077         out of get_init_files.
1078         (get_init_files): Update.
1079
1080 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1081
1082         * main.c (get_init_files): Change to use std::string.
1083         (captured_main_1): Update.
1084         (print_gdb_help): Update.
1085
1086 2019-09-11  Ali Tamur  <tamur@google.com>
1087
1088         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1089         implementation.
1090
1091 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1092
1093         * dbxread.c (read_dbx_symtab): Update.
1094         * dwarf2read.c (load_partial_dies): Update.
1095         * mdebugread.c (parse_partial_symbols): Update.
1096         (handle_psymbol_enumerators): Update.
1097         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1098         * psymtab.c (add_psymbol_to_bcache): Likewise.
1099         (add_psymbol_to_list): Likewise.
1100         * symtab.c (symbol_set_names): Likewise.
1101         * symtab.h (symbol_set_names): Likewise.
1102         * xcoffread.c (scan_xcoff_symtab): Update.
1103
1104 2019-09-11  Tom Tromey  <tom@tromey.com>
1105
1106         * symfile-mem.c (symbol_file_add_from_memory): Use
1107         bfd_set_filename.
1108         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1109         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1110
1111 2019-09-10  Tom Tromey  <tromey@adacore.com>
1112
1113         * dwarf-index-write.c (write_psymbols): Extend error message.
1114         (debug_names::insert): Add Ada code.
1115         (debug_names::write_psymbols): Remove Ada check.
1116         (debug_names) <m_string_obstack>: New member.
1117         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1118         (gdb_index_symbol_name_matcher::matches): Remove.
1119         (mapped_index_base::find_name_components_bounds): Add "lang"
1120         parameter.
1121         (mapped_index_base::build_name_components): Also split names
1122         according to Ada syntax.
1123         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1124         type of "match_callback".
1125         (check_match, check_find_bounds_finds)
1126         (dw2_expand_symtabs_matching): Update.
1127         (dw2_debug_names_iterator): Add new constructor.
1128         (dw2_debug_names_map_matching_symbols): New function.
1129         (dw2_debug_names_expand_symtabs_matching): Update.
1130         (dwarf2_debug_names_functions): Use
1131         dw2_debug_names_map_matching_symbols.
1132
1133 2019-09-10  Tom Tromey  <tromey@adacore.com>
1134
1135         * dwarf2read.c (dw2_get_file_names_reader): Add the
1136         CU's file name to the results.
1137
1138 2019-09-10  Tom Tromey  <tromey@adacore.com>
1139
1140         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1141         map_matching_symbols.  Update.
1142         * dwarf2read.c (dw2_map_matching_symbols): Update.
1143         * psymtab.c (match_partial_symbol): Change type; update.
1144         (psym_map_matching_symbols): Likewise.
1145         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1146         type; update.
1147         * symfile.h (struct quick_symbol_functions)
1148         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1149         Remove "match".
1150
1151 2019-09-10  Tom Tromey  <tromey@adacore.com>
1152
1153         * psymtab.c (map_block): Remove.
1154         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1155         * symtab.c (iterate_over_symbols_terminated): New function.
1156         * symtab.c (iterate_over_symbols_terminated): Declare.
1157
1158 2019-09-10  Tom Tromey  <tromey@adacore.com>
1159
1160         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1161         * language.h (struct language_defn) <la_iterate_over_symbols>:
1162         Return bool.
1163         * symtab.c (iterate_over_symbols): Return bool.
1164         * symtab.h (iterate_over_symbols): Return bool.
1165
1166 2019-09-10  Tom Tromey  <tromey@adacore.com>
1167
1168         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1169         (add_nonlocal_symbols): Update.
1170         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1171         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1172         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1173         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1174         Change type of "callback".  Remove "data".
1175
1176
1177 2019-09-09  Ali Tamur  <tamur@google.com>
1178
1179         * dwarf2read.c (comp_unit_head): Update comment.
1180         (dwarf2_dwo_name): New function declaration.
1181         (dwarf_unit_type_name): New function declaration.
1182         (read_comp_unit_head): Add support for new compilation units,
1183         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1184         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1185         (currently named as "signature") in their header. Also clarify error
1186         messages.
1187         (lookup_dwo_id): New function. Returns the dwo id of the given
1188         compile unit.
1189         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1190         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1191         functions.
1192         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1193         (dwarf2_dwo_name): Get the dwo name if present.
1194         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1195         purposes.
1196
1197 2019-09-09  Tom Tromey  <tom@tromey.com>
1198
1199         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1200
1201 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1202
1203         * python/python.c (do_start_initialization): Make progname_copy static,
1204         to avoid a leak report.
1205
1206 2019-09-08  Tom Tromey  <tom@tromey.com>
1207
1208         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1209
1210 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1211
1212         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1213         Change type to gdb::optional<block_enum>.
1214         (dw2_symtab_iter_init): Change block_index parameter type
1215         to gdb::optional<block_enum>.
1216         (dw2_lookup_symbol): Change block_index parameter
1217         type to block_enum.c
1218         (dw2_debug_names_lookup_symbol): Likewise.
1219         * psymtab.c (psym_lookup_symbol): Likewise.
1220         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1221         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1222         Likewise.
1223
1224 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1225
1226         * defs.h (relocate_gdb_directory): Change int to bool in
1227         signature and rename flag to relocatable.
1228         * main.c (relocate_path): Likewise.
1229         (relocate_gdb_directory): Likewise.
1230
1231 2019-09-06  Alan Modra  <amodra@gmail.com>
1232
1233         * coffread.c (coff_symfile_read): Constify filename variable.
1234         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1235         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1236         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1237         * solib.c (reload_shared_libraries_1): Likewise.
1238         * symfile.c (reread_symbols): Likewise.
1239         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1240         * solib-darwin.c (darwin_bfd_open): Likewise.
1241         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1242
1243 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1244
1245         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1246         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1247
1248 2019-09-03  Tom Tromey  <tromey@adacore.com>
1249
1250         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1251         types.
1252         (has_negatives): Unbias a range type bound.
1253         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1254         * gdbtypes.c (operator==): Handle new field.
1255         (create_range_type): Add "bias" parameter.
1256         (create_static_range_type, resolve_dynamic_range): Update.
1257         * gdbtypes.h (struct range_bounds) <bias>: New member.
1258         (create_range_type): Add bias parameter.
1259         * printcmd.c (print_scalar_formatted): Unbias range types.
1260         * value.c (unpack_long): Unbias range types.
1261         (pack_long): Bias range types.
1262
1263 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1264
1265         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1266         probe arguments.
1267
1268 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1269
1270         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1271         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1272         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1273         (compile_probe_arg): Likewise.
1274         * probe.h (get_argument_count): Likewise.
1275         * solib-svr4.c (solib_event_probe_action): Likewise.
1276         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1277
1278 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1279
1280         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1281         code to here...
1282         (svr4_create_solib_event_breakpoints): ...from here.
1283
1284 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1285
1286         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1287         suffix from warning message.
1288
1289 2019-08-30  Tom Tromey  <tom@tromey.com>
1290
1291         * tui/tui-winsource.h (struct tui_source_window_base)
1292         <refresh_all>: Don't declare.
1293         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1294         Remove.
1295         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1296         tui_show_locator_content.
1297         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1298         declare.
1299         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1300         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1301         declare.
1302
1303 2019-08-30  Tom Tromey  <tom@tromey.com>
1304
1305         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1306
1307 2019-08-30  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1310         Remove unnecessary forward declarations.
1311
1312 2019-08-30  Tom Tromey  <tom@tromey.com>
1313
1314         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1315         rerender.
1316         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1317         tui_show_locator_content.
1318
1319 2019-08-30  Tom Tromey  <tom@tromey.com>
1320
1321         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1322         (tui_locator_window::rerender): Rewrite using body of previous
1323         tui_show_locator_content.
1324
1325 2019-08-30  Tom Tromey  <tom@tromey.com>
1326
1327         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1328         set_locator_fullname>: New methods.
1329         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1330         Rename from tui_set_locator_fullname.
1331         (tui_locator_window::set_locator_info): Rename from
1332         tui_set_locator_info.  Return bool.
1333         (tui_update_locator_fullname, tui_show_frame_info): Update.
1334
1335 2019-08-30  Tom Tromey  <tom@tromey.com>
1336
1337         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1338
1339 2019-08-30  Tom Tromey  <tom@tromey.com>
1340
1341         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1342         call touchwin.
1343
1344 2019-08-30  Tom Tromey  <tom@tromey.com>
1345
1346         * tui/tui-wingeneral.c (box_win): Assume win_info and
1347         win_info->handle cannot be NULL.
1348
1349 2019-08-30  Tom Tromey  <tom@tromey.com>
1350
1351         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1352         refresh_window>: Declare.
1353         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1354         resize.
1355         (tui_data_item_window::rerender): Rename from
1356         tui_display_register.
1357         (tui_data_item_window::refresh_window): New method.
1358         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1359         no-op.
1360
1361 2019-08-30  Tom Tromey  <tom@tromey.com>
1362
1363         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1364         regs_column_count, current_group>: Move later.  Now private.
1365         <get_current_group>: New method.
1366         * tui/tui-regs.c (tui_reg_command): Update.
1367         * tui/tui-layout.c (tui_set_layout): Update.
1368
1369 2019-08-30  Tom Tromey  <tom@tromey.com>
1370
1371         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1372         (tui_data_window::rerender): Don't call
1373         check_and_display_highlight_if_needed.
1374         (tui_data_window::refresh_all): Remove call to
1375         erase_data_content.
1376
1377 2019-08-30  Tom Tromey  <tom@tromey.com>
1378
1379         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1380         (tui_data_window::display_registers_from)
1381         (tui_data_window::display_reg_element_at_line)
1382         (tui_data_window::display_registers_from_line): Remove checks of
1383         "empty".
1384
1385 2019-08-30  Tom Tromey  <tom@tromey.com>
1386
1387         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1388         Don't declare.
1389         * tui/tui-regs.c (tui_data_window::show_registers): Call
1390         rerender.
1391         (tui_data_window::rerender): Rename from display_all_data.
1392         (tui_data_window::rerender): Remove old implementation.
1393
1394 2019-08-30  Tom Tromey  <tom@tromey.com>
1395
1396         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1397         text.
1398         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1399
1400 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1401             Sergio Durigan Junior  <sergiodj@redhat.com>
1402
1403         PR win32/24284
1404         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1405
1406 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1407
1408         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1409         when searching for types.
1410
1411 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1412
1413         * f-lang.c (f_language_defn): Use f_print_typedef.
1414         * f-lang.h (f_print_typedef): Declare.
1415         * f-typeprint.c (f_print_typedef): Define.
1416
1417 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1418
1419         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1420
1421 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1422
1423         * cli/cli-utils.c (info_print_options_defs): Delete.
1424         (make_info_print_options_def_group): Delete.
1425         (extract_info_print_options): Delete.
1426         (info_print_command_completer): Delete.
1427         (info_print_args_help): Add extra parameter, and optionally
1428         include text about -n flag.
1429         * cli/cli-utils.h (struct info_print_options): Delete.
1430         (extract_info_print_options): Delete declaration.
1431         (info_print_command_completer): Delete declaration.
1432         (info_print_args_help): Add extra parameter, extend header
1433         comment.
1434         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1435         search_symbols.
1436         * stack.c (struct info_print_options): New type.
1437         (info_print_options_defs): New file scoped variable.
1438         (make_info_print_options_def_group): New static function.
1439         (info_print_command_completer): New static function.
1440         (info_locals_command): Update to use new local functions.
1441         (info_args_command): Likewise.
1442         (_initialize_stack): Add extra parameter to calls to
1443         info_print_args_help.
1444         * symtab.c (search_symbols): Add extra parameter, use this to
1445         possibly excluse non-debug symbols.
1446         (symtab_symbol_info): Add extra parameter, which is passed on to
1447         search_symbols.
1448         (struct info_print_options): New type.
1449         (info_print_options_defs): New file scoped variable.
1450         (make_info_print_options_def_group): New static function.
1451         (info_print_command_completer): New static function.
1452         (info_variables_command): Update to use local functions, and pass
1453         extra parameter through to symtab_symbol_info.
1454         (info_functions_command): Likewise.
1455         (info_types_command): Pass additional argument through to
1456         symtab_symbol_info.
1457         (rbreak_command): Pass extra argument to search_symbols.
1458         (_initialize_symtab): Add extra arguments for calls to
1459         info_print_args_help, and update help text for 'info variables',
1460         'whereis', and 'info functions' commands.
1461         * symtab.h (search_symbols): Add extra argument to declaration.
1462         * NEWS: Mention new flags.
1463
1464 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1465
1466         * symtab.c (lookup_static_symbol): Call the new function (and move
1467         it down to be next to lookup_global_symbol).
1468         (struct global_sym_lookup_data): Add block_enum member and rename to...
1469         (struct global_or_static_sym_lookup_data): ...this.
1470         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1471         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1472         (lookup_symbol_global_or_static_iterator_cb): ...this.
1473         (lookup_global_or_static_symbol): New function.
1474         (lookup_global_symbol): Call new function.
1475
1476 2019-08-26  Tom de Vries  <tdevries@suse.de>
1477
1478         PR c++/24852
1479         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1480         when pc_probe.prob == NULL.
1481
1482 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1483
1484         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1485         variable symbol_linkage to symbol_linkage_.
1486
1487 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1488
1489         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1490         represent whether the symbol is static, dynamic, or we don't
1491         know.
1492
1493 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1494
1495         * gdb/rx-tdep.c (rx_register_names): New.
1496         (rx_register_name): Delete.
1497         (rx_psw_type): Delete.
1498         (rx_fpsw_type): Delete.
1499         (rx_register_type): Delete.
1500         (rx_gdbarch_init): Convert target-descriptions.
1501         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1502         * gdb/features/Makefile: Add rx.xml.
1503         * gdb/features/rx.xml: New.
1504         * gdb/features/rx.c: Generated.
1505         * gdb/NEWS: Mention target description support.
1506
1507 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1508
1509         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1510         *slot_ptr.
1511
1512 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1513
1514         * configure.ac: Don't check for 'dlfcn.h' (moved to
1515         gdbsupport/common.m4).
1516         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1517         'gdbsupport/'.
1518         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1519         * compile/compile-c-support.c: Include
1520         'gdbsupport/gdb-dlfcn.h'.
1521         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1522         * gdb-dlfcn.c: Move to...
1523         * gdbsupport/gdb-dlfcn.c: ... here.
1524         * gdb-dlfcn.h: Move to...
1525         * gdbsupport/gdb-dlfcn.h: ... here.
1526
1527 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1528
1529         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1530         the offset field signed.
1531
1532 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1533
1534         * python/lib/gdb/__init__.py (_execute_file): New function.
1535         * python/python.c (python_run_simple_file): Call gdb._execute_file
1536         on Windows.
1537
1538 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1539
1540         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1541         all uses as this was never set to anything but a zero value.
1542
1543 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1544
1545         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1546
1547 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1548
1549         * tui/tui-data.h (tui_gen_win_info): Add an =default
1550         move constructor, required by some GCC versions.
1551
1552 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1553
1554         * go32-nat.c (go32_sysinfo): Add hygon_p.
1555
1556 2019-08-20  Tom Tromey  <tom@tromey.com>
1557
1558         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1559         line_from_reg_element_no, first_reg_element_no_inline,
1560         display_all_data, delete_data_content_windows,
1561         erase_data_content>: Now private.
1562
1563 2019-08-20  Tom Tromey  <tom@tromey.com>
1564
1565         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1566         (tui_unhighlight_win, tui_highlight_win)
1567         (tui_win_info::make_window): Update.
1568         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1569
1570 2019-08-20  Tom Tromey  <tom@tromey.com>
1571
1572         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1573         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1574         (MAX_PID_WIDTH): Move to tui-stack.c.
1575         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1576         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1577         (MAX_PID_WIDTH): Move from tui-data.h.
1578
1579 2019-08-20  Tom Tromey  <tom@tromey.com>
1580
1581         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1582         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1583         (box_win): Update.
1584         (tui_gen_win_info::make_window): Rename from tui_make_window.
1585         (tui_win_info::make_window): New method.
1586         (tui_gen_win_info::make_visible): Update.
1587         * tui/tui-source.c (tui_source_window::set_contents): Update.
1588         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1589         (tui_data_window::display_registers_from): Update.
1590         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1591         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1592         Declare.
1593         <can_box>: Remove.
1594         <title>: Remove.
1595         (struct tui_win_info) <make_window>: Declare.
1596         <can_box>: Now virtual.
1597         <title>: New member.
1598         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1599         * tui/tui-command.c (tui_cmd_window::resize): Update.
1600
1601 2019-08-20  Tom Tromey  <tom@tromey.com>
1602
1603         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1604         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1605         (tui_data_window::check_register_values): Update.
1606
1607 2019-08-20  Tom Tromey  <tom@tromey.com>
1608
1609         * tui/tui-regs.h (struct tui_data_window): Use
1610         DISABLE_COPY_AND_ASSIGN.
1611         <regs_content>: Change type, removing unique_ptr.
1612         <tui_data_window>: Add move constructor.
1613         * tui/tui-regs.c (tui_data_window::show_registers)
1614         (tui_data_window::show_register_group)
1615         (tui_data_window::display_registers_from)
1616         (tui_data_window::display_registers_from)
1617         (tui_data_window::first_data_item_displayed)
1618         (tui_data_window::delete_data_content_windows)
1619         (tui_data_window::rerender, tui_data_window::refresh_window)
1620         (tui_data_window::check_register_values): Update.
1621
1622 2019-08-20  Tom Tromey  <tom@tromey.com>
1623
1624         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1625         show_register_group>: Declare.
1626         (tui_show_register_group): Don't declare.
1627         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1628         tui_show_registers.
1629         (tui_data_window::show_register_group): Rename from
1630         tui_show_register_group.
1631         (tui_data_window::check_register_values, tui_reg_command):
1632         Update.
1633         * tui/tui-layout.c (tui_set_layout): Update.
1634
1635 2019-08-20  Tom Tromey  <tom@tromey.com>
1636
1637         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1638         Declare.
1639         (tui_check_register_values): Don't declare.
1640         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1641         from tui_check_register_values.
1642         * tui/tui-hooks.c (tui_register_changed): Update.
1643
1644 2019-08-20  Tom Tromey  <tom@tromey.com>
1645
1646         * tui/tui-regs.c (tui_reg_layout): Move later.
1647         (tui_show_registers): Don't enable TUI mode or change layout.
1648
1649 2019-08-20  Tom Tromey  <tom@tromey.com>
1650
1651         * tui/tui-regs.h (struct tui_data_item_window)
1652         <~tui_data_item_window>: Remove.
1653         <content>: Now a unique_xmalloc_ptr.
1654         * tui/tui-regs.c (tui_register_format): Return a
1655         unique_xmalloc_ptr.
1656         (tui_get_register): Update.
1657         (~tui_data_item_window): Remove.
1658         (tui_data_window::display_registers_from, tui_display_register):
1659         Update.
1660         * tui/tui-io.h (tui_expand_tabs): Update.
1661         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1662         Remove "col" parameter.
1663
1664 2019-08-20  Tom Tromey  <tom@tromey.com>
1665
1666         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1667         field.
1668         * tui/tui-regs.c (~tui_data_item_window): Update.
1669
1670 2019-08-20  Tom Tromey  <tom@tromey.com>
1671
1672         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1673         earlier.
1674
1675 2019-08-20  Tom Tromey  <tom@tromey.com>
1676
1677         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1678
1679 2019-08-20  Tom Tromey  <tom@tromey.com>
1680
1681         * tui/tui-source.h (struct tui_source_window): Update.
1682         * tui/tui-regs.c (tui_show_registers): Update.
1683         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1684         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1685         (NO_REGS_STRING): Remove defines.
1686
1687 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1688
1689         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1690         unnecessary thread walk if remote doesn't support the packet.
1691
1692 2019-08-19  Tom Tromey  <tromey@adacore.com>
1693
1694         * python/py-value.c (value_has_field): Fix indentation.
1695
1696 2019-08-19  Tom Tromey  <tromey@adacore.com>
1697
1698         * printcmd.c (do_one_display, info_display_command): Update.
1699         * block.h (contained_in): Return bool.  Add allow_nested
1700         parameter.
1701         * block.c (contained_in): Return bool.  Add allow_nested
1702         parameter.
1703
1704 2019-08-19  Tom Tromey  <tom@tromey.com>
1705
1706         * configure: Rebuild.
1707         * configure.ac: Disallow the combination of -static-libstdc++ and
1708         source highlight.
1709         * source-cache.c (get_language_name): Handle rust.
1710         (source_cache::get_source_lines): Ignore highlighting exceptions.
1711
1712 2019-08-16  Tom Tromey  <tom@tromey.com>
1713
1714         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1715         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1716         (struct tui_source_window_base) <make_visible, refresh_window,
1717         resize>: Remove methods.
1718         <execution_info>: Remove field.
1719         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1720         (tui_show_source_line, tui_source_window_base)
1721         (~tui_source_window_base): Update.
1722         (tui_source_window_base::resize)
1723         (tui_source_window_base::make_visible)
1724         (tui_source_window_base::refresh_window): Remove.
1725         (tui_source_window_base::update_exec_info): Update.
1726         * tui/tui-source.c (tui_source_window::set_contents): Update.
1727         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1728
1729 2019-08-16  Tom Tromey  <tom@tromey.com>
1730
1731         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1732         deprecated_query_hook.
1733
1734 2019-08-16  Tom Tromey  <tom@tromey.com>
1735
1736         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1737         (tui_update_source_windows_with_line): Update.
1738         * tui/tui-source.h (struct tui_source_window)
1739         <show_symtab_source>: Declare.
1740         (tui_show_symtab_source): Don't declare.
1741         * tui/tui-source.c (tui_show_symtab_source): Rename from
1742         tui_show_symtab_source.
1743
1744 2019-08-16  Tom Tromey  <tom@tromey.com>
1745
1746         * tui/tui-winsource.h (struct tui_source_window_base)
1747         <set_contents>: Declare.
1748         * tui/tui-winsource.c
1749         (tui_source_window_base::update_source_window_as_is): Update.
1750         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1751         Declare.
1752         (tui_set_source_content): Don't declare.
1753         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1754         tui_set_source_content.
1755         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1756         Declare.
1757         (tui_set_disassem_content): Don't declare.
1758         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1759         tui_set_disassem_content.
1760
1761 2019-08-16  Tom Tromey  <tom@tromey.com>
1762
1763         * tui/tui-winsource.h (struct tui_source_window_base)
1764         <update_breakpoint_info>: Declare.
1765         (tui_update_breakpoint_info): Don't declare.
1766         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1767         (tui_update_all_breakpoint_info): Update.
1768         (tui_source_window_base::update_breakpoint_info): Rename from
1769         tui_update_breakpoint_info.
1770         (tui_source_window_base::update_exec_info): Update.
1771
1772 2019-08-16  Tom Tromey  <tom@tromey.com>
1773
1774         * tui/tui-winsource.h (struct tui_source_window_base)
1775         <update_source_window>: Declare.
1776         (tui_update_source_window): Don't declare.
1777         * tui/tui-winsource.c
1778         (tui_source_window_base::update_source_window): Rename from
1779         tui_update_source_window.
1780         (tui_source_window_base::rerender): Update.
1781         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1782         * tui/tui-disasm.c (tui_show_disassem)
1783         (tui_show_disassem_and_update_source)
1784         (tui_disasm_window::maybe_update): Update.
1785
1786 2019-08-16  Tom Tromey  <tom@tromey.com>
1787
1788         * tui/tui-winsource.h (struct tui_source_window_base)
1789         <update_source_window_as_is>: Declare.
1790         (tui_update_source_window_as_is): Don't declare.
1791         * tui/tui-winsource.c (tui_update_source_window): Update
1792         (tui_source_window_base::update_source_window_as_is): Rename from
1793         tui_update_source_window_as_is.
1794         (tui_source_window_base::refill): Update.
1795         * tui/tui-source.c (tui_show_symtab_source): Update.
1796         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1797         Update.
1798
1799 2019-08-16  Tom Tromey  <tom@tromey.com>
1800
1801         * tui/tui-winsource.h (tui_update_source_window)
1802         (tui_update_source_window_as_is): Remove "noerror" parameter.
1803         * tui/tui-winsource.c (tui_update_source_window)
1804         (tui_update_source_window_as_is): Remove "noerror" parameter.
1805         (tui_update_source_windows_with_addr)
1806         (tui_update_source_windows_with_line)
1807         (tui_source_window_base::rerender)
1808         (tui_source_window_base::refill): Update.
1809         * tui/tui-source.h (tui_set_source_content)
1810         (tui_show_symtab_source): Remove "noerror" parameter.
1811         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1812         parameter.
1813         (tui_show_symtab_source): Likewise.
1814         (tui_source_window::maybe_update): Update.
1815         * tui/tui-disasm.c (tui_show_disassem)
1816         (tui_show_disassem_and_update_source)
1817         (tui_disasm_window::do_scroll_vertical)
1818         (tui_disasm_window::maybe_update): Update.
1819
1820 2019-08-16  Tom Tromey  <tom@tromey.com>
1821
1822         * tui/tui.c (tui_is_window_visible): Update.
1823         * tui/tui-wingeneral.c (tui_make_window)
1824         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1825         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1826         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1827         (tui_set_win_height_command, parse_scrolling_args): Update.
1828         * tui/tui-source.c (tui_source_window::style_changed): Update.
1829         * tui/tui-regs.c (tui_show_registers)
1830         (tui_data_window::first_data_item_displayed)
1831         (tui_data_window::delete_data_content_windows)
1832         (tui_check_register_values, tui_reg_command): Update.
1833         * tui/tui-disasm.c (tui_show_disassem): Update.
1834         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1835         method.
1836         <is_visible>: Remove field.
1837         * tui/tui-data.c (tui_next_win, tui_prev_win)
1838         (tui_delete_invisible_windows): Update.
1839
1840 2019-08-16  Tom Tromey  <tom@tromey.com>
1841
1842         * tui/tui-winsource.h (struct tui_source_window_base)
1843         <m_has_locator>: Remove.
1844         * tui/tui-layout.c (show_source_disasm_command, show_data)
1845         (show_source_or_disasm_and_command): Update.
1846
1847 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1848
1849         * NEWS (Other MI changes): New subsection.
1850         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1851         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1852         * arch-utils.c (default_get_pc_address_flags): New function.
1853         * arch-utils.h (default_get_pc_address_flags): New declaration.
1854         * gdbarch.sh: Add get_pc_address_flags.
1855         * gdbarch.c: Regenerate.
1856         * gdbarch.h: Likewise.
1857         * stack.c (print_pc): New function.
1858         (print_frame_info) (print_frame): Call print_pc.
1859
1860 2019-08-16  Tom de Vries  <tdevries@suse.de>
1861
1862         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1863         print_objfile_section_info.
1864
1865 2019-08-15  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1868         calling update_cmdwin_start_line.
1869         * tui/tui-winsource.h (struct tui_source_window_base)
1870         <do_make_visible_with_new_height, set_new_height>: Don't declare.
1871         <rerender>: Declare.
1872         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
1873         Call rerender.
1874         (tui_source_window_base::set_new_height): Remove.
1875         (tui_source_window_base::rerender): Rename from
1876         do_make_visible_with_new_height.
1877         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
1878         resize method.
1879         (tui_win_info::make_invisible_and_set_new_height)
1880         (tui_win_info::make_visible_with_new_height): Remove.
1881         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
1882         Declare.
1883         * tui/tui-stack.c (tui_locator_window::rerender): New method.
1884         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
1885         do_make_visible_with_new_height>: Don't declare.
1886         <rerender>: Declare.
1887         * tui/tui-regs.c (tui_data_window::rerender): Rename from
1888         set_new_height.
1889         (tui_data_window::do_make_visible_with_new_height): Remove.
1890         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
1891         call tui_show_locator_content.
1892         (tui_gen_win_info::resize): Call rerender.
1893         (show_source_or_disasm_and_command): Don't call
1894         tui_show_locator_content.
1895         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
1896         method.
1897         (struct tui_win_info) <rerender>: Declare.
1898         <set_new_height, make_invisible_and_set_new_height,
1899         make_visible_with_new_height>: Don't declare.
1900         * tui/tui-data.c (tui_win_list::rerender): New method.
1901         * tui/tui-command.h (struct tui_cmd_window)
1902         <do_make_visible_with_new_height>: Don't declare.
1903         * tui/tui-command.c
1904         (tui_cmd_window::do_make_visible_with_new_height): Remove.
1905
1906 2019-08-15  Tom Tromey  <tromey@adacore.com>
1907
1908         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
1909         * ada-lang.c (ada_enum_name): Likewise.
1910
1911 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
1912
1913         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
1914         leading underscore.
1915         (GdbOutputErrorFile): Likewise.
1916         (global scope): Adjust constructor calls to GdbOutput{,Error}File
1917         accordingly.
1918         (execute_unwinders): Rename to have a leading underscore.
1919         (auto_load_packages): Likewise.
1920         (global scope): Adjust call to auto_load_packages accordingly.
1921         (GdbSetPythonDirectory): Likewise.
1922         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
1923         instead of execute_unwinders.
1924
1925 2019-08-15  Tom Tromey  <tom@tromey.com>
1926
1927         * tui/tui-layout.c (show_layout, show_source_disasm_command)
1928         (show_data): Don't change window visibility.
1929         (tui_gen_win_info::resize): Remove special case for command
1930         window.  Use wresize, when available.
1931         (show_source_or_disasm_and_command): Don't change window
1932         visibility.
1933         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
1934         <make_visible>: New method.
1935         * tui/tui-command.c (tui_cmd_window::resize): New method.
1936
1937 2019-08-15  Tom Tromey  <tom@tromey.com>
1938
1939         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
1940         (struct tui_source_windows): New.
1941         * tui/tui-winsource.c (tui_display_main): Update.
1942         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1943         (new_height_ok, parse_scrolling_args): Update.
1944         * tui/tui-layout.c (show_layout, show_data): Update.
1945         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
1946         (tui_add_to_source_windows): Don't declare.
1947         * tui/tui-data.c (source_windows, tui_source_windows)
1948         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
1949
1950 2019-08-15  Tom Tromey  <tom@tromey.com>
1951
1952         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
1953         Rename from reset.
1954         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
1955         * tui/tui-layout.c (show_source_disasm_command, show_data):
1956         Update.
1957         (tui_gen_win_info::resize): Rename.
1958         (show_source_or_disasm_and_command): Update.
1959         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
1960         reset.
1961
1962 2019-08-15  Tom Tromey  <tom@tromey.com>
1963
1964         * tui/tui-stack.c (tui_initialize_static_data): Remove.
1965         * tui/tui-interp.c (tui_interp::init): Don't call
1966         tui_initialize_static_data.
1967         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
1968
1969 2019-08-15  Tom Tromey  <tom@tromey.com>
1970
1971         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
1972         examine tui_win_list.
1973
1974 2019-08-15  Tom Tromey  <tom@tromey.com>
1975
1976         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
1977         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
1978         tui_clear_source_content.
1979         (tui_clear_source_content): Remove.
1980         (tui_source_window_base::do_erase_source_content): Hoist call to
1981         content.clear().
1982         * tui/tui-stack.c (tui_show_frame_info): Don't call
1983         tui_clear_source_content.
1984
1985 2019-08-15  Tom Tromey  <tom@tromey.com>
1986
1987         * tui/tui-winsource.h (struct tui_source_window_base)
1988         <do_erase_source_content>: New method.
1989         <erase_source_content>: New method.
1990         (tui_erase_source_content): Don't declare.
1991         * tui/tui-winsource.c (tui_clear_source_content): Update.
1992         (tui_source_window_base::do_erase_source_content): Rename from
1993         tui_erase_source_content.
1994         (tui_source_window_base::show_source_content): Update.
1995         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
1996         * tui/tui-source.h (struct tui_source_window)
1997         <erase_source_content>: New method.
1998         * tui/tui-disasm.h (struct tui_disasm_window)
1999         <erase_source_content>: New method.
2000
2001 2019-08-15  Tom Tromey  <tom@tromey.com>
2002
2003         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2004         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2005         constructor.
2006         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2007         * tui/tui-source.c (tui_set_source_content): Update.
2008         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2009
2010 2019-08-15  Tom Tromey  <tom@tromey.com>
2011
2012         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2013         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2014         tui-source.c.
2015         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2016         Declare.
2017         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2018         method.
2019         (tui_source_window::maybe_update): Update.
2020
2021 2019-08-15  Tom Tromey  <tom@tromey.com>
2022
2023         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2024         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2025         tui-disasm.c.
2026         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2027         Declare.
2028         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2029         method.
2030         (tui_disasm_window::maybe_update): Update.
2031
2032 2019-08-15  Tom Tromey  <tom@tromey.com>
2033
2034         * tui/tui-winsource.h (struct tui_source_window_base)
2035         <maybe_update>: Declare.
2036         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2037         method.
2038         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2039         Declare.
2040         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2041         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2042         Declare.
2043         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2044
2045 2019-08-15  Tom Tromey  <tom@tromey.com>
2046
2047         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2048
2049 2019-08-15  Tom Tromey  <tom@tromey.com>
2050
2051         * tui/tui-wingeneral.c: Include tui-stack.h.
2052         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2053         (struct tui_locator_window): Move from tui-data.h.
2054         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2055         (tui_initialize_static_data): Move from tui-data.c.
2056         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2057         (struct tui_locator_window): Move to tui-stack.c.
2058         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2059         (tui_initialize_static_data): Move to tui-stack.c.
2060
2061 2019-08-15  Tom Tromey  <tom@tromey.com>
2062
2063         * tui/tui-layout.c (show_source_disasm_command)
2064         (show_source_or_disasm_and_command): Use make_visible method, not
2065         tui_make_window.
2066         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2067         Remove.
2068
2069 2019-08-15  Tom Tromey  <tom@tromey.com>
2070
2071         * tui/tui-wingeneral.h (tui_make_window): Update.
2072         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2073         parameter.
2074         (tui_gen_win_info::make_visible): Update.
2075         * tui/tui-regs.c (tui_data_window::display_registers_from):
2076         Update.
2077         * tui/tui-layout.c (show_source_disasm_command)
2078         (show_source_or_disasm_and_command): Update.
2079         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2080         (enum tui_box): Remove.
2081         (struct tui_win_info) <can_box>: New method.
2082         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2083         method.
2084
2085 2019-08-15  Tom de Vries  <tdevries@suse.de>
2086
2087         * linux-nat-trad.c: Include gdbarch.h.
2088
2089 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2090
2091         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2092         register sizes.
2093
2094 2019-08-14  Tom Tromey  <tromey@adacore.com>
2095
2096         * darwin-nat.c: Include gdbarch.h.
2097         * darwin-nat-info.c: Include gdbarch.h.
2098
2099 2019-08-13  Tom Tromey  <tom@tromey.com>
2100
2101         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2102         Remove.
2103         * tui/tui-data.c (tui_initialize_static_data): Update.
2104
2105 2019-08-13  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-winsource.h (struct tui_exec_info_window)
2108         <~tui_exec_info_window, maybe_allocate_content, get_content,
2109         m_content>: Remove.
2110         (struct tui_source_window_base) <set_exec_info_content,
2111         show_exec_info_content>: Don't declare.
2112         * tui/tui-winsource.c
2113         (tui_exec_info_window::maybe_allocate_content): Remove.
2114         (tui_source_window_base::update_exec_info): Rename from
2115         set_exec_info_content.
2116         (tui_source_window_base::show_exec_info_content)
2117         (tui_source_window_base::update_exec_info): Remove.
2118
2119 2019-08-13  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2122         declare.
2123         * tui/tui-winsource.c (tui_update_source_window_as_is)
2124         (tui_update_source_windows_with_addr, tui_erase_source_content):
2125         Update.
2126         (tui_clear_exec_info_content): Remove.
2127
2128 2019-08-13  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2131         declare.
2132         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2133         call tui_erase_exec_info_content.
2134         (tui_clear_exec_info_content): Rename from
2135         tui_erase_exec_info_content.
2136         (tui_clear_exec_info_content): Delete.
2137
2138 2019-08-13  Tom Tromey  <tom@tromey.com>
2139
2140         * tui/tui-winsource.h (struct tui_source_window_base)
2141         <show_exec_info_content>: Declare.
2142         (tui_show_exec_info_content): Don't declare.
2143         * tui/tui-winsource.c
2144         (tui_source_window_base::show_exec_info_content): Rename from
2145         tui_show_exec_info_content.
2146         (tui_source_window_base::update_exec_info): Update.
2147
2148 2019-08-13  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2151         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2152         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2153         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2154         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2155         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2156         ... here.
2157
2158 2019-08-13  Tom Tromey  <tom@tromey.com>
2159
2160         * tui/tui-winsource.h (struct tui_source_window_base)
2161         <update_exec_info>: Declare.
2162         (tui_update_exec_info): Don't declare.
2163         * tui/tui-winsource.c (tui_update_source_window_as_is)
2164         (tui_source_window_base::refresh_all)
2165         (tui_update_all_breakpoint_info): Update.
2166         (tui_source_window_base::update_exec_info): Rename from
2167         tui_update_exec_info.
2168         * tui/tui-stack.c (tui_show_frame_info): Update.
2169
2170 2019-08-13  Tom Tromey  <tom@tromey.com>
2171
2172         * tui/tui-winsource.h (struct tui_source_window_base)
2173         <set_exec_info_content>: Declare.
2174         (tui_set_exec_info_content): Don't declare.
2175         * tui/tui-winsource.c
2176         (tui_source_window_base::set_exec_info_content): Rename from
2177         tui_set_exec_info_content.
2178         (tui_update_exec_info): Update.
2179
2180 2019-08-13  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-winsource.h (struct tui_source_window_base)
2183         <show_source_content>: Declare.
2184         (tui_show_source_content): Don't declare.
2185         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2186         (tui_source_window_base::show_source_content): Rename from
2187         tui_show_source_content.
2188         (tui_source_window_base::refresh_all): Update.
2189         * tui/tui-layout.c (show_source_disasm_command)
2190         (show_source_or_disasm_and_command): Update.
2191
2192 2019-08-13  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-winsource.c (tui_erase_source_content)
2195         (tui_show_source_content, tui_source_window_base::refresh_all):
2196         Update.
2197         * tui/tui-wingeneral.h
2198         (tui_check_and_display_highlight_if_needed): Don't declare.
2199         * tui/tui-wingeneral.c
2200         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2201         check_and_display_highlight_if_needed.
2202         * tui/tui-win.c (tui_rehighlight_all)
2203         (tui_win_info::make_visible_with_new_height): Update.
2204         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2205         (tui_data_window::erase_data_content)
2206         (tui_data_window::display_all_data): Update.
2207         * tui/tui-data.h (struct tui_win_info)
2208         <check_and_display_highlight_if_needed>: Declare.
2209
2210 2019-08-13  Tom Tromey  <tom@tromey.com>
2211
2212         * tui/tui-win.c (tui_resize_all): Call
2213         tui_delete_invisible_windows.
2214         * tui/tui-layout.c (show_layout): Call
2215         tui_delete_invisible_windows.
2216         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2217         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2218
2219 2019-08-13  Tom Tromey  <tom@tromey.com>
2220
2221         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2222         tui_add_win_to_layout.
2223
2224 2019-08-13  Tom Tromey  <tom@tromey.com>
2225
2226         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2227         * tui/tui-layout.c (tui_default_win_height): Now static.
2228
2229 2019-08-13  Tom Tromey  <tom@tromey.com>
2230
2231         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2232         single switch.
2233         (show_source_disasm_command, show_source_or_disasm_and_command):
2234         Don't check current layout.
2235
2236 2019-08-13  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-wingeneral.c (make_all_visible): Remove.
2239         (tui_make_all_invisible): Simplify.
2240         * tui/tui-layout.c (tui_make_all_invisible): Move from
2241         tui-wingeneral.c; simplify.
2242         (show_layout): Hoist call to tui_make_all_invisible.
2243         (show_data): Don't call tui_make_all_invisible.
2244
2245 2019-08-13  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2248         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2249
2250 2019-08-13  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2253         tui-data.c.
2254         (show_source_disasm_command, show_data)
2255         (show_source_or_disasm_and_command): Don't use
2256         tui_set_current_layout_to.
2257         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2258         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2259         tui-layout.c.
2260         (tui_set_current_layout_to): Remove.
2261
2262 2019-08-13  Tom Tromey  <tom@tromey.com>
2263
2264         * tui/tui-layout.c (tui_set_layout): Update.
2265         * tui/tui-data.h (struct tui_layout_def): Remove.
2266         (tui_layout_def): Don't declare.
2267         * tui/tui-data.c (layout_def): Remove.
2268         (tui_layout_def): Remove.
2269
2270 2019-08-13  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-winsource.h (struct tui_source_window_base)
2273         <clear_detail>: No longer "override".
2274         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2275         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2276         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2277         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2278         Remove.
2279         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2280
2281 2019-08-13  Tom Tromey  <tromey@adacore.com>
2282
2283         * tracepoint.c: Don't include readline.h or history.h.
2284
2285 2019-08-12  Tom Tromey  <tom@tromey.com>
2286
2287         * configure: Rebuild.
2288         * configure.ac: Check for readline 7.
2289         * NEWS: Mention readline 7 requirement.
2290         * README: Update.
2291
2292 2019-08-12  Tom Tromey  <tom@tromey.com>
2293
2294         * mingw-hdep.c (gdb_select): Remove readline hack.
2295
2296 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2297
2298         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2299         when the function fails.
2300
2301 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2302
2303         * s390-tdep.c (s390_type_align): New function.
2304         (s390_gdbarch_init): Set it as type_align gdbarch method.
2305
2306 2019-08-09  Tom de Vries  <tdevries@suse.de>
2307
2308         PR gdb/24591
2309         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2310         pc_low with relocation offset.
2311
2312 2019-08-07  Tom Tromey  <tromey@adacore.com>
2313
2314         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2315         (print_frame_args): Update.
2316         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2317         Update.
2318         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2319         * frame.h (struct frame_arg): Add initializers.
2320         <error>: Now a unique_xmalloc_ptr.
2321
2322 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2323
2324         * NEWS: Expand the Pointer Authentication entry.
2325         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2326         (aarch64_frame_unmask_lr): ... to this.
2327         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2328         Call aarch64_frame_unmask_lr.
2329         * frame.c (struct frame_info): Add "masked" variable.
2330         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2331         (fprint_frame): Check for masked pc.
2332         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2333         declarations.
2334         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2335         * stack.c (print_frame): Check for masked pc.
2336
2337 2019-08-06  Tom Tromey  <tom@tromey.com>
2338
2339         * stabsread.c (patch_block_stabs, read_one_struct_field)
2340         (read_enum_type): Use obstack_strndup.
2341         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2342         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2343         * dwarf2read.c (guess_full_die_structure_name)
2344         (anonymous_struct_prefix): Use obstack_strndup.
2345         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2346         * c-exp.y (yylex): Use obstack_strndup.
2347         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2348         (write_var_or_type): Use obstack_strndup.
2349
2350 2019-08-06  Tom Tromey  <tom@tromey.com>
2351
2352         * symfile.c (reread_symbols): Use obstack_strdup.
2353         * stabsread.c (read_type): Use obstack_strdup.
2354         * gdb_obstack.h (obstack_strdup): New overload.
2355         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2356         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2357         (dwarf2_canonicalize_name): Use obstack_strdup.
2358         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2359         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2360         Use obstack_strdup.
2361
2362 2019-08-06  Tom Tromey  <tom@tromey.com>
2363
2364         * gdb_obstack.h (obstack_strdup): Define.
2365         * gdb_obstack.c (obstack_strdup): Don't define.
2366
2367 2019-08-06  Tom Tromey  <tom@tromey.com>
2368
2369         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2370         obstack_strdup.
2371         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2372         obstack_strdup.
2373         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2374         * stabsread.c (common_block_start): Use obstack_strdup.
2375         * objfiles.c (set_objfile_main_name, objfile): Use
2376         obstack_strdup.
2377         * namespace.c (add_using_directive): Use obstack_strdup.
2378         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2379         * jit.c (finalize_symtab): Use obstack_strdup.
2380         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2381         (guess_partial_die_structure_name, partial_die_info::fixup)
2382         (dwarf2_name): Use obstack_strdup.
2383         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2384         obstack_strdup.
2385         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2386         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2387         obstack_strdup.
2388         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2389
2390 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2391
2392         * unittests/help-doc-selftests.c: New file.
2393         * Makefile.in: Add the new file.
2394
2395 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2396
2397         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2398         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2399         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2400         the trailing '.' is not output, and the first character is uppercased.
2401         (print_help_for_command): Update call to print_doc_line.
2402         (print_doc_of_command): Likewise.
2403         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2404         * cli/cli-option.c (append_indented_doc): Do not append newline.
2405         (build_help_option): Append newline after first appended_indented_doc
2406         only if a second call is done.
2407         (build_help): Append 2 new lines before each option, except the first
2408         one.
2409         * compile/compile.c (_initialize_compile): Add new lines after
2410         %OPTIONS%, when not at the end of the help.
2411         Change help doc or code
2412         producing the help doc to respect the invariants.
2413         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2414         Also removed the new line after 'Options:', as all other commands
2415         do not put an empty line between 'Options:' and the first option.
2416         * printcmd.c (_initialize_printcmd): Likewise.
2417         * stack.c (_initialize_stack): Likewise.
2418         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2419         incorrectly telling COMMAND is optional.
2420         * ada-lang.c (_initialize_ada_language): Change help doc or code
2421         producing the help doc to respect the invariants.
2422         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2423         * breakpoint.c (_initialize_breakpoint): Likewise.
2424         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2425         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2426         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2427         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2428         _initialize_cli_style): Likewise.
2429         * corelow.c (core_target_info): Likewise.
2430         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2431         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2432         * filesystem.c (_initialize_filesystem): Likewise.
2433         * frame.c (_initialize_frame): Likewise.
2434         * gnu-nat.c (add_task_commands): Likewise.
2435         * infcall.c (_initialize_infcall): Likewise.
2436         * infcmd.c (_initialize_infcmd): Likewise.
2437         * interps.c (_initialize_interpreter): Likewise.
2438         * language.c (_initialize_language): Likewise.
2439         * linux-fork.c (_initialize_linux_fork): Likewise.
2440         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2441         * maint.c (_initialize_maint_cmds): Likewise.
2442         * memattr.c (_initialize_mem): Likewise.
2443         * printcmd.c (_initialize_printcmd): Likewise.
2444         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2445         _RegEx): Likewise.
2446         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2447         * record-btrace.c (_initialize_record_btrace): Likewise.
2448         * record-full.c (_initialize_record_full): Likewise.
2449         * record.c (_initialize_record): Likewise.
2450         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2451         * regcache.c (_initialize_regcache): Likewise.
2452         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2453         _initialize_remote): Likewise.
2454         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2455         * serial.c (_initialize_serial): Likewise.
2456         * skip.c (_initialize_step_skip): Likewise.
2457         * source.c (_initialize_source): Likewise.
2458         * stack.c (_initialize_stack): Likewise.
2459         * symfile.c (_initialize_symfile): Likewise.
2460         * symtab.c (_initialize_symtab): Likewise.
2461         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2462         * top.c (init_main): Likewise.
2463         * tracefile-tfile.c (tfile_target_info): Likewise.
2464         * tracepoint.c (_initialize_tracepoint): Likewise.
2465         * tui/tui-win.c (_initialize_tui_win): Likewise.
2466         * utils.c (add_internal_problem_command): Likewise.
2467         * valprint.c (value_print_option_defs): Likewise.
2468
2469 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2470
2471         PR build/24886
2472         * configure.ac: Drop enable-libmcheck support.
2473         * configure, config.in: Rebuild.
2474         * libmcheck.m4: Remove.
2475         * acinclude.m4: Don't include it.
2476         * Makefile.in: Don't distribute it.
2477         * top.c (print_gdb_configuration): Don't mention it.
2478
2479 2019-08-06  Tom Tromey  <tom@tromey.com>
2480
2481         * utils.c (set_output_style): Sometimes pass stream to
2482         emit_style_escape.
2483         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2484         * record-btrace.c (btrace_insn_history): Update.
2485         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2486         method.
2487         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2488         Update initializers.
2489         <m_uiout>: New field.
2490         <m_di>: Move lower.
2491         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2492         Remove "uiout" parameter.
2493         (dump_insns): Update.
2494         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2495         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2496
2497 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2498
2499         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2500         (error_in_psymtab_expansion): Likewise.
2501         (lookup_symbol_via_quick_fns): Likewise.
2502         (basic_lookup_transparent_type_quick): Likewise.
2503         (basic_lookup_transparent_type_1): Likewise.
2504
2505 2019-08-06  Tom Tromey  <tromey@adacore.com>
2506
2507         * source.c (last_source_error): Now bool.
2508         (print_source_lines_base): Make "noprint" bool.  Only open
2509         source file when last_source_visited changes.
2510
2511 2019-08-06  Tom Tromey  <tromey@adacore.com>
2512
2513         * annotate.c (annotate_source_line): Use g_source_cache.
2514         * source-cache.c (source_cache::get_plain_source_lines): Change
2515         parameters.  Populate m_offset_cache.
2516         (source_cache::ensure): New method.
2517         (source_cache::get_line_charpos): New method.
2518         (extract_lines): Move lower.  Change parameters.
2519         (source_cache::get_source_lines): Move lower.
2520         * source-cache.h (class source_cache): Update comment.
2521         <get_line_charpos>: New method.
2522         <get_source_lines>: Update comment.
2523         <clear>: Clear m_offset_cache.
2524         <get_plain_source_lines>: Change parameters.
2525         <ensure>: New method
2526         <m_offset_cache>: New member.
2527         * source.c (forget_cached_source_info_for_objfile): Update.
2528         (info_source_command): Use g_source_cache.
2529         (find_source_lines, open_source_file_with_line_charpos): Remove.
2530         (print_source_lines_base, search_command_helper): Use g_source_cache.
2531         * source.h (open_source_file_with_line_charpos): Don't declare.
2532         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2533         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2534         Use g_source_cache.
2535
2536 2019-08-06  Tom Tromey  <tromey@adacore.com>
2537
2538         * source-cache.c (source_cache::get_plain_source_lines):
2539         Remove "first_line" and "last_line" parameters.
2540         (source_cache::get_source_lines): Cache plain text.
2541         * source-cache.h (class source_cache)
2542         <get_plain_source_lines>: Update.
2543
2544 2019-08-06  Tom Tromey  <tromey@adacore.com>
2545
2546         * source-cache.c (extract_lines): No longer a method.
2547         Changed type of parameter.  Include final newline.
2548         (selftests::extract_lines_test): New function.
2549         (_initialize_source_cache): Likewise.
2550         * source-cache.h (class source_cache)
2551         <extract_lines>: Don't declare.
2552
2553 2019-08-06  Tom Tromey  <tromey@adacore.com>
2554
2555         * breakpoint.c (init_breakpoint_sal): Update.
2556         (breakpoint): Update.
2557         * breakpoint.h (struct breakpoint) <filter>: Now a
2558         unique_xmalloc_ptr.
2559
2560 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2561
2562         * NEWS: Mention dictionary access on blocks.
2563         * python/py-block.c (blpy_getitem): New function.
2564         (block_object_as_mapping): New struct.
2565         (block_object_type): Use new struct for tp_as_mapping field.
2566
2567 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2568
2569         * objfiles.h (objfile): Add a comment describing partial symbols.
2570
2571 2019-08-05  Tom Tromey  <tromey@adacore.com>
2572
2573         * compile/compile.c (_initialize_compile): Use _(), not N_().
2574         * thread.c (_initialize_thread): Use _(), not N_().
2575         * stack.c (_initialize_stack): Use _(), not N_().
2576         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2577
2578 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2579
2580         * dwarf2read.c (struct dw2_symtab_iterator):
2581         <want_specific_block>: Remove.
2582         <block_index>: Change type to gdb::optional.
2583         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2584         change type of BLOCK_INDEX parameter to gdb::optional.
2585         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2586         (dw2_lookup_symbol): Don't pass argument for
2587         WANT_SPECIFIC_BLOCK.
2588         (dw2_expand_symtabs_for_function): Don't pass argument for
2589         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2590         (class dw2_debug_names_iterator)
2591         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2592         parameter, change BLOCK_INDEX type to gdb::optional.
2593         <m_want_specific_block>: Remove.
2594         <m_block_index>: Change type to gdb::optional.
2595         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2596         gdb::optional.  Re-write in function of gdb::optional.
2597         (dw2_debug_names_lookup_symbol): Don't pass argument for
2598         WANT_SPECIFIC_BLOCK.
2599         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2600         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2601         BLOCK_INDEX.
2602
2603 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2604
2605         * NEWS: Mention changes to "info sources" command.
2606
2607 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2608
2609         * symtab.c (filename_partial_match_opts): New struct type.
2610         (struct output_source_filename_data): New members
2611         regexp, c_regexp, partial_match.
2612         (output_source_filename): Use new members to decide to print file.
2613         (info_sources_option_defs): New variable.
2614         (make_info_sources_options_def_group, print_info_sources_header,
2615         info_sources_command_completer):
2616         New functions.
2617         (info_sources_command): Read new optional arguments.
2618         (_initialize_symtab): Update info sources help.
2619
2620 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2621
2622         * ada-lang.c (exception_support_info_v0): Renamed from...
2623         (default_exception_support_info): ... this.  Create new
2624         definition for v1.
2625         (ada_has_this_exception_support): Look up catch_handlers_sym.
2626         (ada_exception_support_info_sniffer): Try v0 after default.
2627
2628 2019-08-01  Tom Tromey  <tromey@adacore.com>
2629
2630         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2631         gdbarch.h.
2632
2633 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2634
2635         * s12z-tdep.c: Fix include path for s12z-opc.h.
2636
2637 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2638
2639         * NEWS: Require GNU make 3.82.
2640
2641 2019-07-16  Tom Tromey  <tom@tromey.com>
2642
2643         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2644         declare.
2645
2646 2019-07-30  Tom Tromey  <tromey@adacore.com>
2647
2648         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2649
2650 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2651
2652         * printcmd.c (print_address_symbolic): Print negative offsets.
2653         (build_address_symbolic): Force signed arithmetic when computing
2654         offset.
2655
2656 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2657
2658         PR/24474: Add a function to lookup static variables.
2659         * NEWS: Mention this new function.
2660         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2661         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2662         * python/python.c (python_GdbMethods): Add new function.
2663
2664 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2665
2666         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2667         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2668         (objfpy_lookup_static_symbol): New function.
2669         (objfile_object_methods): Add new functions.
2670
2671 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2672
2673         * NEWS: Mention 'set|show print frame-info'.  Mention new
2674         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2675         backtrace argument.  Mention that python frame filtering code
2676         is now consistent with what 'backtrace' command prints.
2677
2678 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2679
2680         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2681         comments.
2682         (print_frame_info_auto, print_frame_info_source_line,
2683         print_frame_info_location, print_frame_info_source_and_location,
2684         print_frame_info_location_and_address, print_frame_info_short_location):
2685         New declarations.
2686         (struct frame_print_options): New member print_frame_info.
2687         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2688         * stack.h (get_user_print_what_frame_info): New declaration.
2689         (frame_show_address): New declaration.
2690         * stack.c (print_frame_arguments_choices): New value 'presence'.
2691         (print_frame_info_auto, print_frame_info_source_line,
2692         print_frame_info_location, print_frame_info_source_and_location,
2693         print_frame_info_location_and_address, print_frame_info_short_location,
2694         print_frame_info_choices, print_frame_info_print_what): New definitions.
2695         (print_frame_args): Only print dots for args if print frame-arguments
2696         is 'presence'.
2697         (frame_print_option_defs): New element for "frame-info".
2698         (get_user_print_what_frame_info): New function.
2699         (frame_show_address): Make non static.  Move comment to stack.h.
2700         (print_frame_info_to_print_what): New function.
2701         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2702         to decide what to print.
2703         (backtrace_command_1): Handle the new print_frame_arguments_presence
2704         value.
2705         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2706         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2707         (py_print_frame): In non-mi mode, use LOCATION as default for
2708         print_what, similarly to frame information printed directly by
2709         backtrace command. Handle frame-info user option in non MI mode.
2710
2711 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2712
2713         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2714         Add case for debugging 32-bit target on 64-bit host.  Revise
2715         comment.
2716
2717 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2718
2719         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2720         instead of find_function_entry_range_from_pc.
2721
2722 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2723
2724         * stack.c (find_frame_funname): Remove code which preferred
2725         minsym over symtab sym in "certain pathological cases".
2726
2727         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2728         parameter.  Change type of "do_demangle" to bool.
2729         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2730         Pass suitable "prefer_sym_over_minsym" flag to
2731         build_address_symbolic().  Don't output "+" for negative offsets.
2732         * printcmd.c (print_address_symbolic): Update invocation of
2733         build_address_symbolic to include a "prefer_sym_over_minsym"
2734         flag.
2735         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2736         Restrict cases in which use of minimal symbol is preferred to that
2737         of a found symbol.  Update comments.
2738
2739         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2740         for entry pc when entry pc is out of range for that FDE.
2741
2742 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2743
2744         PR gdb/24839:
2745         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2746         type.
2747
2748 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2749
2750         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2751         this function's Python signature.
2752
2753
2754 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2755
2756         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2757         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2758         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2759         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2760         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2761
2762
2763 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2764
2765         * h8300-tdep.c (h8300_register_name_common): New.
2766         h8300_register_name): Use h8300_register_name_common.
2767         (h8300s_register_name): Likewise.
2768         (h8300sx_register_name): Likewise.
2769         (h8300h_register_nam): New.
2770         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2771
2772
2773 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2774
2775         * arm-tdep.c (arm_skip_cmse_entry): New function.
2776         (arm_is_sgstubs_section): New function.
2777         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2778
2779 2019-07-22  Tom Tromey  <tom@tromey.com>
2780
2781         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2782         Don't self-assign.
2783
2784 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2785
2786         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2787         type_print.
2788
2789 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2792         so that GDB doesn't match any msymbols when searching in the
2793         TYPES_DOMAIN.
2794         (print_symbol_info): Print using typedef_print or type_print based
2795         on the type of the symbol.  Add updated FIXME comment moved from...
2796         (_initialize_symtab): ... move and update FIXME comment to above.
2797
2798 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2799
2800         * NEWS: Mention adding -q option to "info types".
2801         * symtab.c (struct info_types_options): New struct.
2802         (info_types_options_defs): New variable.
2803         (make_info_types_options_def_group): New function.
2804         (info_types_command): Use gdb::option framework to parse options.
2805         (info_types_command_completer): New function.
2806         (_initialize_symtab): Extend the help text on "info types" and
2807         register command completer.
2808
2809 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2810
2811         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2812         (lookup_symbol_in_objfile): Change int to block_enum and add a
2813         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2814
2815 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2816
2817         * MAINTAINERS (Write After Approval): Add self.
2818
2819 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2820
2821         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2822         instruction to the dummy code region.
2823
2824 2019-07-19  Tom Tromey  <tromey@adacore.com>
2825
2826         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2827         (ARGSUSED, PARAMS, __func__): Remove rules.
2828
2829 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2830
2831         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2832         * features/arm/arm-with-iwmmxt.c: Remove.
2833         * features/arm/arm-with-iwmmxt.xml: Remove.
2834         * features/arm/arm-with-m-fpa-layout.c: Remove.
2835         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2836         * features/arm/arm-with-m-vfp-d16.c: Remove.
2837         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2838         * features/arm/arm-with-m.c: Remove.
2839         * features/arm/arm-with-m.xml: Remove.
2840         * features/arm/arm-with-neon.c: Remove.
2841         * features/arm/arm-with-neon.xml: Remove.
2842         * features/arm/arm-with-vfpv2.c: Remove.
2843         * features/arm/arm-with-vfpv2.xml: Remove.
2844         * features/arm/arm-with-vfpv3.c: Remove.
2845         * features/arm/arm-with-vfpv3.xml: Remove.
2846
2847 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2848
2849         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2850
2851 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2852
2853         * arch/aarch32.c (aarch32_create_target_description): Create
2854         target descriptions using features.
2855         * arch/arm.c (arm_create_target_description)
2856         (arm_create_mprofile_target_description): Likewise.
2857         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2858
2859 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2860
2861         * Makefile.in: Add new files.
2862         * aarch32-tdep.c: New file.
2863         * aarch32-tdep.h: New file.
2864         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2865         Call aarch32_read_description.
2866         * arch/aarch32.c: New file.
2867         * arch/aarch32.h: New file.
2868         * arch/arm.c (arm_create_target_description)
2869         (arm_create_mprofile_target_description): New function.
2870         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
2871         (arm_create_target_description)
2872         (arm_create_mprofile_target_description): New declaration.
2873         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
2874         read_description functions.
2875         * arm-linux-nat.c (arm_linux_nat_target::read_description):
2876         Likewise.
2877         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
2878         * arm-tdep.c (tdesc_arm_list): New variable.
2879         (arm_register_g_packet_guesses): Call create description functions.
2880         (arm_read_description) (arm_read_mprofile_description): New
2881         function.
2882         * arm-tdep.h (arm_read_description)
2883         (arm_read_mprofile_description): Add declaration.
2884         * configure.tgt: Add new files.
2885
2886 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
2887
2888         * top.c (new_ui_command): Open specified terminal just once.
2889
2890 2019-07-18  Tom Tromey  <tromey@adacore.com>
2891
2892         * symtab.c (main_name): Constify return type.
2893         * symfile.c (set_initial_language): Update.
2894         * symtab.h (main_name): Constify return type.
2895
2896 2019-07-17  Tom Tromey  <tom@tromey.com>
2897
2898         * tui/tui-winsource.c (tui_update_source_window)
2899         (tui_update_source_window_as_is)
2900         (tui_update_source_windows_with_line): Remove return.
2901         * tui/tui-disasm.c (tui_show_disassem)
2902         (tui_show_disassem_and_update_source): Remove return.
2903         * tui/tui.c (tui_reset): Remove return.
2904         * tui/tui-wingeneral.c
2905         (tui_check_and_display_highlight_if_needed): Remove return.
2906
2907 2019-07-17  Tom Tromey  <tom@tromey.com>
2908
2909         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
2910
2911 2019-07-17  Tom Tromey  <tom@tromey.com>
2912
2913         * tui/tui-winsource.h (struct tui_exec_info_window)
2914         (struct tui_source_window_base): Move from tui-data.h.
2915         * tui/tui-winsource.c: Move many method definitions from
2916         elsewhere.  Remove "structuring" comments.
2917         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
2918         (tui_source_window_base::refresh_window): Move to
2919         tui-winsource.c.
2920         * tui/tui-win.c (tui_source_window_base::refresh_all)
2921         (tui_source_window_base::update_tab_width)
2922         (tui_source_window_base::set_new_height)
2923         (tui_source_window_base::do_make_visible_with_new_height): Move to
2924         tui-winsource.c.
2925         * tui/tui-source.h: Update.
2926         * tui/tui-source.c (tui_source_window_base::reset): Move to
2927         tui-winsource.c.
2928         * tui/tui-disasm.h: Update.
2929         * tui/tui-data.h (struct tui_exec_info_window): Move to
2930         tui-winsource.h.
2931         (struct tui_source_window_base): Likewise.
2932         * tui/tui-data.c (tui_source_window_base::clear_detail)
2933         (tui_source_window_base, ~tui_source_window_base): Move to
2934         tui-winsource.c.
2935
2936 2019-07-17  Tom Tromey  <tom@tromey.com>
2937
2938         * tui/tui-win.c (tui_resize_all)
2939         (tui_source_window_base::update_tab_width)
2940         (tui_adjust_win_heights): Update.
2941         (tui_win_info::make_invisible_and_set_new_height): Rename from
2942         make_invisible_and_set_new_height.
2943         * tui/tui-data.h (struct tui_win_info)
2944         <make_invisible_and_set_new_height>: New method.
2945
2946 2019-07-17  Tom Tromey  <tom@tromey.com>
2947
2948         * tui/tui.c: Update.
2949         * tui/tui-source.h (struct tui_source_window): Move from
2950         tui-data.h.
2951         * tui/tui-layout.c: Update.
2952         * tui/tui-disasm.c: Update.
2953         * tui/tui-data.h (struct tui_source_window): Move to
2954         tui-source.h.
2955
2956 2019-07-17  Tom Tromey  <tom@tromey.com>
2957
2958         * tui/tui-disasm.h (struct tui_disasm_window): Move from
2959         tui-data.h.
2960         * tui/tui-data.h (struct tui_disasm_window): Move to
2961         tui-disasm.h.
2962
2963 2019-07-17  Tom Tromey  <tom@tromey.com>
2964
2965         * tui/tui-regs.h (struct tui_data_item_window): Move from
2966         tui-data.h.
2967         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
2968         * tui/tui-data.h (struct tui_data_item_window): Move to
2969         tui-regs.h.
2970         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
2971
2972 2019-07-17  Tom Tromey  <tom@tromey.com>
2973
2974         * tui/tui.c: Update.
2975         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
2976         (tui_cmd_window::max_height): Move to tui-command.c.
2977         * tui/tui-layout.c: Update.
2978         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
2979         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
2980         tui-command.c.
2981         * tui/tui-command.h (struct tui_cmd_window): Move from
2982         tui-data.h.
2983         * tui/tui-command.c: Remove "structuring" comments.
2984         (tui_cmd_window::clear_detail)
2985         (tui_cmd_window::do_make_visible_with_new_height)
2986         (tui_cmd_window::max_height): Move from elsewhere.
2987
2988 2019-07-17  Tom Tromey  <tom@tromey.com>
2989
2990         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
2991         Now static.
2992         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
2993         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
2994
2995 2019-07-17  Tom Tromey  <tom@tromey.com>
2996
2997         * tui/tui.c: Update.
2998         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
2999         tui-regs.c.
3000         * tui/tui-windata.h: Remove file.
3001         * tui/tui-windata.c: Remove file.
3002         * tui/tui-win.c (tui_data_window::set_new_height)
3003         (tui_data_window::do_make_visible_with_new_height): Move to
3004         tui-regs.c.
3005         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3006         * tui/tui-regs.c: Remove "structuring" comments.
3007         (tui_data_window::first_data_item_displayed)
3008         (tui_data_window::delete_data_content_windows)
3009         (tui_data_window::erase_data_content)
3010         (tui_data_window::display_all_data)
3011         (tui_data_window::refresh_all)
3012         (tui_data_window::do_scroll_vertical)
3013         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3014         (tui_data_window::do_make_visible_with_new_height)
3015         (tui_data_window::refresh_window): Move from elsewhere.
3016         (_initialize_tui_regs): Move to end of file.
3017         * tui/tui-layout.c: Update.
3018         * tui/tui-hooks.c: Update.
3019         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3020         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3021         tui-regs.c.
3022         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3023
3024 2019-07-17  Tom Tromey  <tom@tromey.com>
3025
3026         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3027         seen.
3028
3029 2019-07-17  Tom Tromey  <tom@tromey.com>
3030
3031         * tui/tui-win.c (tui_source_window_base::set_new_height)
3032         (tui_source_window_base::do_make_visible_with_new_height): Use
3033         m_has_locator field directly.
3034         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3035         method.
3036         (struct tui_source_window_base) <has_locator>: Likewise.
3037
3038 2019-07-17  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3041         Don't declare.
3042         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3043         Remove.
3044         * tui/tui-win.c (tui_source_window_base::set_new_height)
3045         (tui_source_window_base::set_new_height)
3046         (make_invisible_and_set_new_height)
3047         (tui_source_window_base::do_make_visible_with_new_height)
3048         (tui_source_window_base::do_make_visible_with_new_height):
3049         Update.
3050         * tui/tui-layout.c (show_source_disasm_command, show_data)
3051         (show_source_or_disasm_and_command): Update.
3052         * tui/tui-layout.c (show_layout): Update.
3053
3054 2019-07-17  Tom Tromey  <tom@tromey.com>
3055
3056         * tui/tui-layout.c (make_data_window): Remove.
3057         (show_data): Unify creation and re-initialization cases.
3058
3059 2019-07-17  Tom Tromey  <tom@tromey.com>
3060
3061         * tui/tui-layout.c (make_source_window, make_disasm_window):
3062         Remove.
3063         (show_data): Unify creation and re-initialization cases.
3064
3065 2019-07-17  Tom Tromey  <tom@tromey.com>
3066
3067         * tui/tui-layout.c (make_command_window): Remove.
3068         (show_source_disasm_command, show_source_or_disasm_and_command):
3069         Unify creation and re-initialization cases.
3070
3071 2019-07-17  Tom Tromey  <tom@tromey.com>
3072
3073         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3074         creation and re-initialization cases.
3075
3076 2019-07-17  Tom Tromey  <tom@tromey.com>
3077
3078         * tui/tui-regs.c (tui_get_register): Return void.
3079
3080 2019-07-17  Tom Tromey  <tom@tromey.com>
3081
3082         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3083         Simplify.
3084
3085 2019-07-17  Tom Tromey  <tom@tromey.com>
3086
3087         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3088         resetting.
3089
3090 2019-07-17  Tom Tromey  <tom@tromey.com>
3091
3092         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3093         * tui/tui-regs.c (tui_reg_layout): New function.
3094         (tui_show_registers, tui_reg_command): Use it.
3095         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3096         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3097         parameters.
3098         (tui_layout_command): Remove.
3099
3100 2019-07-17  Tom Tromey  <tom@tromey.com>
3101
3102         * tui/tui-layout.h (tui/tui-layout): Return void.
3103         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3104
3105 2019-07-17  Tom Tromey  <tom@tromey.com>
3106
3107         * tui/tui-layout.c (show_source_disasm_command, show_data):
3108         Update.
3109         (reset_locator): Remove.
3110         (show_source_or_disasm_and_command): Update.
3111
3112 2019-07-17  Tom Tromey  <tom@tromey.com>
3113
3114         * tui/tui-source.c (tui_source_window_base::reset): Remove
3115         win_type parameter.
3116         * tui/tui-layout.c (make_command_window, make_source_window)
3117         (make_disasm_window, make_data_window)
3118         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3119         (reset_locator, show_source_or_disasm_and_command): Update.
3120         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3121         win_type parameter.
3122         (struct tui_source_window_base) <reset>: Likewise.
3123
3124 2019-07-17  Tom Tromey  <tom@tromey.com>
3125
3126         * tui/tui-layout.c (show_source_disasm_command): Use
3127         reset_locator.
3128         (reset_locator): New function.
3129         (init_and_make_win): Remove.
3130         (show_source_or_disasm_and_command): Use reset_locator.
3131
3132 2019-07-17  Tom Tromey  <tom@tromey.com>
3133
3134         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3135         condition.
3136         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3137         Remove condition.
3138         * tui/tui-source.c (tui_source_window_base::reset): New method.
3139         * tui/tui-layout.c (make_command_window): Don't call
3140         init_and_make_win.
3141         (make_source_window, make_disasm_window): Don't call
3142         make_source_or_disasm_window.
3143         (make_data_window): Don't call init_and_make_win.  Change calling
3144         convention.
3145         (show_source_disasm_command, show_data): Simplify.
3146         (make_source_or_disasm_window): Remove.
3147         (show_source_or_disasm_and_command): Simplify.
3148         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3149         (struct tui_source_window_base) <reset>: Likewise.
3150         <execution_info>: Remove initializer.
3151         * tui/tui-data.c (tui_source_window_base): Initialize
3152         execution_info.
3153
3154 2019-07-17  Tom Tromey  <tom@tromey.com>
3155
3156         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3157         variable.
3158
3159 2019-07-17  Tom Tromey  <tom@tromey.com>
3160
3161         * tui/tui.c (tui_rl_other_window): Update.
3162         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3163         superclass method first.  Always iterate over regs_content.
3164         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3165         method.
3166         * tui/tui-win.c (tui_set_focus_command): Update.
3167
3168 2019-07-17  Tom Tromey  <tom@tromey.com>
3169
3170         * tui/tui-win.c (tui_set_focus_command): Rename from
3171         tui_set_focus.  Call tui_enable.
3172         (tui_set_focus_command): Remove.
3173
3174 2019-07-17  Tom Tromey  <tom@tromey.com>
3175
3176         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3177         refresh_window.
3178         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3179         touchwin.
3180         (tui_data_window::refresh_window): Call refresh_window on data
3181         items.  Always call superclass refresh_window.
3182         (tui_win_info::refresh): Remove.
3183         (tui_source_window_base::refresh_window): Update.
3184         (tui_refresh_all): Update.
3185         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3186         refresh_window.
3187         (show_source_or_disasm_and_command): Likewise.
3188         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3189         (struct tui_source_window_base) <refresh>: Likewise.
3190
3191 2019-07-17  Tom Tromey  <tom@tromey.com>
3192
3193         * tui/tui-winsource.c (tui_clear_source_content)
3194         (tui_show_source_content): Update.
3195         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3196         whether content is empty.
3197         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3198         Remove.
3199
3200 2019-07-17  Tom Tromey  <tom@tromey.com>
3201
3202         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3203         window's contents.
3204         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3205         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3206
3207 2019-07-17  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3210         (struct tui_data_item_window): Update.
3211
3212 2019-07-17  Tom Tromey  <tom@tromey.com>
3213
3214         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3215         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3216         defines.
3217
3218 2019-07-17  Tom Tromey  <tom@tromey.com>
3219
3220         * tui/tui-winsource.h (tui_erase_source_content)
3221         (tui_clear_source_content): Remove "display_prompt" parameter.
3222         * tui/tui-winsource.c (tui_update_source_window_as_is)
3223         (tui_update_source_windows_with_addr): Update.
3224         (tui_clear_source_content): Remove "display_prompt" parameter.
3225         (tui_erase_source_content): Likewise.  Simplify.
3226         (tui_show_source_content): Update.
3227         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3228         * tui/tui-stack.c (tui_show_frame_info): Update.
3229         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3230         Remove defines.
3231
3232 2019-07-17  Tom Tromey  <tom@tromey.com>
3233
3234         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3235         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3236         parameter.
3237         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3238         parameter.
3239
3240 2019-07-17  Tom Tromey  <tom@tromey.com>
3241
3242         * tui/tui-winsource.c (tui_clear_source_content)
3243         (tui_show_source_content, tui_show_exec_info_content)
3244         (tui_clear_exec_info_content): Update.
3245         * tui/tui-stack.c (tui_show_locator_content): Update.
3246         (tui_show_frame_info): Update.
3247         * tui/tui-source.h (tui_source_window): Don't declare.
3248         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3249         from tui_source_is_displayed.
3250         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3251         Remove field.
3252         (struct tui_source_window_base) <content_in_use>: New field.  Now
3253         bool.
3254         (struct tui_source_window) <showing_source_p>: New method.
3255         (TUI_SRC_WIN): Change cast.
3256         * tui/tui-data.c (tui_initialize_static_data): Update.
3257
3258 2019-07-17  Tom Tromey  <tom@tromey.com>
3259
3260         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3261         location_matches_p.
3262         * tui/tui-source.c (tui_source_window::location_matches_p): New
3263         method.
3264         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3265         method.
3266         * tui/tui-data.h (struct tui_source_window_base)
3267         <location_matches_p>: New method.
3268         (struct tui_source_window, struct tui_disasm_window)
3269         <location_matches_p>: Likewise.
3270
3271 2019-07-17  Tom Tromey  <tom@tromey.com>
3272
3273         * tui/tui-win.c (tui_set_win_height_command): Rename from
3274         tui_set_win_height.
3275         (tui_set_win_height_command): Remove.
3276
3277 2019-07-17  Tom Tromey  <tom@tromey.com>
3278
3279         * tui/tui-source.c (tui_source_window): New constructor.  Add
3280         observer.
3281         (~tui_source_window): New destructor.
3282         (tui_source_window::style_changed): New method.
3283         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3284         (tui_attach_detach_observers): Update.
3285         * tui/tui-data.h (struct tui_source_window): Make constructor not
3286         inline.  Add destructor.
3287         (struct tui_source_window) <style_changed>: New method.
3288         <m_observable>: New member.
3289
3290 2019-07-17  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3293         * tui/tui-win.c (tui_resize_all): Fix typo.
3294
3295 2019-07-17  Tom Tromey  <tom@tromey.com>
3296
3297         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3298         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3299         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3300         * tui/tui-win.c (window_name_completer): Use foreach.
3301         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3302         (update_tab_width): Likewise.
3303         * tui/tui-layout.c (show_layout): Update.
3304         * tui/tui-data.h (class tui_window_iterator): New.
3305         (struct all_tui_windows): New.
3306         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3307
3308 2019-07-17  Tom Tromey  <tom@tromey.com>
3309
3310         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3311         parameter.  Don't reference globals.
3312         (tui_reg_command): Update.
3313
3314 2019-07-17  Tom Tromey  <tom@tromey.com>
3315
3316         * tui/tui-regs.c (tui_show_registers): Simplify.
3317
3318 2019-07-17  Tom Tromey  <tom@tromey.com>
3319
3320         * tui/tui-regs.c (tui_show_registers): Update.
3321         (tui_show_register_group): Add win_info parameter.
3322
3323 2019-07-17  Tom Tromey  <tom@tromey.com>
3324
3325         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3326         Rename from tui_display_reg_element_at_line.
3327         (tui_data_window::display_registers_from_line): Update.
3328         * tui/tui-data.h (struct tui_data_window)
3329         <display_reg_element_at_line>: New method.
3330
3331 2019-07-17  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-regs.h (tui_display_registers_from)
3334         (tui_display_registers_from_line): Don't declare.
3335         * tui/tui-windata.c (tui_data_window::display_all_data)
3336         (tui_data_window::refresh_all)
3337         (tui_data_window::do_scroll_vertical): Update.
3338         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3339         from tui_display_registers_from.
3340         (tui_display_reg_element_at_line): Update.
3341         (tui_data_window::display_registers_from_line): Rename from
3342         tui_display_registers_from_line.
3343         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3344         display_registers_from_line>: New methods.
3345
3346 2019-07-17  Tom Tromey  <tom@tromey.com>
3347
3348         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3349         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3350         from tui_erase_data_content.
3351         (tui_data_window::display_all_data)
3352         (tui_data_window::refresh_all)
3353         (tui_data_window::do_scroll_vertical): Update.
3354         * tui/tui-regs.c (tui_show_registers): Update.
3355         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3356         New method.
3357
3358 2019-07-17  Tom Tromey  <tom@tromey.com>
3359
3360         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3361         declare.
3362         * tui/tui-windata.c
3363         (tui_data_window::delete_data_content_windows): Rename from
3364         tui_delete_data_content_windows.
3365         (tui_data_window::display_all_data)
3366         (tui_data_window::do_scroll_vertical): Update.
3367         * tui/tui-data.h (struct tui_data_window)
3368         <delete_data_content_windows>: New method.
3369
3370 2019-07-17  Tom Tromey  <tom@tromey.com>
3371
3372         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3373         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3374
3375 2019-07-17  Tom Tromey  <tom@tromey.com>
3376
3377         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3378         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3379         from tui_display_all_data.
3380         * tui/tui-win.c
3381         (tui_data_window::do_make_visible_with_new_height): Update.
3382         * tui/tui-regs.c (tui_show_registers): Update.
3383         * tui/tui-layout.c (tui_set_layout): Update.
3384         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3385         method.
3386
3387 2019-07-17  Tom Tromey  <tom@tromey.com>
3388
3389         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3390         * tui/tui-windata.c (tui_display_data_from): Remove.
3391         (tui_data_window::refresh_all): Update.
3392
3393 2019-07-17  Tom Tromey  <tom@tromey.com>
3394
3395         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3396         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3397         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3398         tui_display_registers_from_line.
3399         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3400         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3401         "force_display" parameter.
3402
3403 2019-07-17  Tom Tromey  <tom@tromey.com>
3404
3405         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3406         declare.
3407         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3408         Rename from tui_first_reg_element_no_inline.
3409         (tui_display_reg_element_at_line)
3410         (tui_display_registers_from_line): Update.
3411         * tui/tui-data.h (struct tui_data_window)
3412         <first_reg_element_no_inline>: New method.
3413
3414 2019-07-17  Tom Tromey  <tom@tromey.com>
3415
3416         * tui/tui-windata.c (tui_display_data_from)
3417         (tui_data_window::do_scroll_vertical): Update.
3418         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3419         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3420         Rename from tui_line_from_reg_element_no.
3421         (tui_display_registers_from_line): Update.
3422         * tui/tui-data.h (struct tui_data_window)
3423         <line_from_reg_element_no>: New method.
3424
3425 2019-07-17  Tom Tromey  <tom@tromey.com>
3426
3427         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3428         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3429         tui_last_regs_line_no.
3430         (tui_display_reg_element_at_line)
3431         (tui_display_registers_from_line): Update.
3432         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3433         method.
3434
3435 2019-07-17  Tom Tromey  <tom@tromey.com>
3436
3437         PR tui/24722:
3438         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3439         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3440         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3441         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3442         (tui_update_breakpoint_info): Likewise.
3443         * tui/tui-hooks.c (tui_event_create_breakpoint)
3444         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3445         Update.
3446
3447 2019-07-17  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3450
3451 2019-07-17  Tom Tromey  <tom@tromey.com>
3452
3453         * tui/tui-winsource.c (tui_update_source_window_as_is)
3454         (tui_update_source_windows_with_addr): Update.
3455         * tui/tui-source.h (tui_set_source_content)
3456         (tui_show_symtab_source): Add "win_info" parameter.
3457         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3458         parameter.
3459         (tui_show_symtab_source): Likewise.
3460
3461 2019-07-17  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-wingeneral.c
3464         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3465
3466 2019-07-17  Tom Tromey  <tom@tromey.com>
3467
3468         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3469         (struct tui_cmd_window) <can_scroll>: New method.
3470         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3471         method.
3472
3473 2019-07-17  Tom Tromey  <tromey@adacore.com>
3474
3475         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3476         do_field_signed>: Rename.  Change type of "value".
3477         * ui-out.c (ui_out::field_signed): Rename from field_int.
3478         Change type of "value".
3479         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3480         type of "value".
3481         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3482         do_field_int.  Change type of "value".
3483         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3484         do_field_int.  Change type of "value".
3485         * tracepoint.c (trace_status_mi, tfind_1)
3486         (print_one_static_tracepoint_marker): Update.
3487         * thread.c (print_thread_info_1, print_selected_thread_frame):
3488         Update.
3489         * stack.c (print_frame, print_frame_info): Update.
3490         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3491         Update.
3492         * source.c (print_source_lines_base): Update.
3493         * skip.c (info_skip_command): Update.
3494         * record-btrace.c (btrace_ui_out_decode_error)
3495         (btrace_call_history_src_line): Update.
3496         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3497         Update.
3498         * progspace.c (print_program_space): Update.
3499         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3500         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3501         do_field_int.  Change type of "value".
3502         * mi/mi-out.c (mi_ui_out::do_table_begin)
3503         (mi_ui_out::do_table_header): Update.
3504         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3505         type of "value".
3506         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3507         (mi_cmd_data_list_changed_registers, output_register)
3508         (mi_cmd_data_read_memory, mi_load_progress)
3509         (mi_cmd_trace_frame_collected): Update.
3510         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3511         Update.
3512         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3513         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3514         (mi_cmd_var_list_children, varobj_update_one): Update.
3515         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3516         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3517         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3518         * inferior.c (print_inferior): Update.
3519         * gdb_bfd.c (print_one_bfd): Update.
3520         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3521         Update.
3522         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3523         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3524         do_field_int.  Change type of "value".
3525         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3526         do_field_int.  Change type of "value".
3527         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3528         (print_one_breakpoint_location, print_it_catch_fork)
3529         (print_one_catch_fork, print_it_catch_vfork)
3530         (print_one_catch_vfork, print_it_catch_solib)
3531         (print_it_catch_exec, print_it_ranged_breakpoint)
3532         (print_mention_watchpoint, print_mention_masked_watchpoint)
3533         (bkpt_print_it, update_static_tracepoint): Update.
3534         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3535         * break-catch-syscall.c (print_it_catch_syscall): Update.
3536         * ada-tasks.c (print_ada_task_info): Update.
3537         * ada-lang.c (print_it_exception, print_mention_exception):
3538         Update.
3539
3540 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3541
3542         PR breakpoints/24541
3543         * gdbarch.c: Regenerate.
3544         * gdbarch.h: Regenerate.
3545         * gdbarch.sh: Adjust return type and parameter types for
3546         'stap_adjust_register'.
3547         (i386_stap_adjust_register): Adjust signature and return new
3548         register name.
3549         * stap-probe.c (stap_parse_register_operand): Adjust use of
3550         'gdbarch_stap_adjust_register'.
3551
3552 2019-07-17  Tom Tromey  <tromey@adacore.com>
3553
3554         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3555         declare VEC.
3556         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3557         std::vector.
3558         (struct s390_process_info): Add initializers.
3559         (s390_add_process): Use new.
3560         (s390_linux_nat_target::low_forget_process): Use delete.
3561         (s390_linux_nat_target::low_new_fork)
3562         (s390_linux_nat_target::stopped_by_watchpoint)
3563         (s390_linux_nat_target::low_prepare_to_resume)
3564         (s390_linux_nat_target::insert_watchpoint)
3565         (s390_linux_nat_target::insert_hw_breakpoint)
3566         (s390_linux_nat_target::remove_watchpoint)
3567         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3568
3569 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3570
3571         * aarch64-fbsd-nat.c: Include regcache.h.
3572         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3573         argument.
3574         (aarch64_fbsd_nat_target::fetch_registers)
3575         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3576         variable.
3577         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3578
3579 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3580
3581         * fbsd-nat.c: Include gdbarch.h.
3582
3583 2019-07-15  Tom Tromey  <tromey@adacore.com>
3584
3585         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3586
3587 2019-07-15  Tom Tromey  <tromey@adacore.com>
3588
3589         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3590         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3591         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3592         * cli-out.c (cli_ui_out::do_field_int): New method.
3593         * ui-out.c (ui_out::field_unsigned): New method.
3594         * symfile.c (generic_load): Use field_unsigned.
3595         (print_transfer_performance): Likewise.
3596         * record-btrace.c (ui_out_field_uint): Remove.
3597         (btrace_call_history_insn_range, btrace_call_history): Use
3598         field_unsigned.
3599         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3600         field_unsigned.
3601         * ui-out.h (class ui_out) <field_unsigned>: New method.
3602         <do_field_unsigned>: Likewise.
3603
3604 2019-07-15  Tom Tromey  <tromey@adacore.com>
3605
3606         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3607         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3608         * target.c (flash_erase_command): Use field_string.
3609         * infrun.c (print_signal_received_reason): Use field_string.
3610         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3611         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3612         field_string.
3613         * ada-tasks.c (print_ada_task_info): Use field_string.
3614
3615 2019-07-15  Tom Tromey  <tromey@adacore.com>
3616
3617         * target.c (flash_erase_command): Use field_core_addr.
3618         * symfile.c (generic_load): Use field_core_addr.
3619         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3620         Use field_core_addr.
3621         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3622         field_core_addr.
3623
3624 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3625
3626         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3627         value if its desired type is smaller than a CORE_ADDR and signed.
3628
3629 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3630
3631         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3632         of changes to field names, and use new is_reference field to
3633         decide if a property is a reference or not.
3634         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3635         field.
3636         (struct dwarf2_property_baton): Update header comment, rename
3637         'referenced_type' to 'property_type' and update comments.
3638         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3639         default property type, store in property baton, update to take
3640         accound of renamed field.
3641         (read_func_scope): Update call to attr_to_dynamic_prop.
3642         (read_array_type): Likewise.
3643         (dwarf2_per_cu_addr_sized_int_type): New function.
3644         (read_subrange_index_type): Move type finding code to
3645         dwarf2_per_cu_addr_sized_int_type.
3646         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3647         (dwarf2_per_cu_addr_type): New function.
3648         (set_die_type): Update calls to attr_to_dynamic_prop.
3649
3650 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3651
3652         * dwarf2read.c (read_subrange_index_type): New function.
3653         (read_subrange_type): Move code into new function and call it.
3654         * gdbtypes.c (create_range_type): Add some asserts.
3655
3656 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3657
3658         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3659         update return statements.
3660         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3661         declaration, and update comment to match.
3662         * gdbtypes.c (resolve_dynamic_array): Update call to
3663         dwarf2_evaluate_property to match new return type.
3664
3665 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3666
3667         * valarith.c (value_subscripted_rvalue): Change lowerbound
3668         parameter type from int to LONGEST.
3669         * value.h (value_subscripted_rvalue): Likewise in declaration.
3670
3671 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         * cli/cli-utils.c (info_print_command_completer): New function.
3674         * cli/cli-utils.h: Add 'completer.h' include, and forward
3675         declaration for 'struct cmd_list_element'.
3676         (info_print_command_completer): Declare.
3677         * stack.c (_initialize_stack): Add completer for 'info locals' and
3678         'info args'.
3679         * symtab.c (_initialize_symtab): Add completer for 'info
3680         variables' and 'info functions'.
3681         * NEWS: Mention completion for additional info commands.
3682
3683 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * cli/cli-utils.c (extract_info_print_args): Delete.
3686         (extract_arg_maybe_quoted): Delete.
3687         (info_print_options_defs): New variable.
3688         (make_info_print_options_def_group): New function.
3689         (extract_info_print_options): Define new function.
3690         * cli/cli-utils.h (extract_info_print_args): Delete.
3691         (struct info_print_options): New structure.
3692         (extract_info_print_options): Declare new function.
3693         * stack.c (info_locals_command): Update to use new
3694         extract_info_print_options, also add a header comment.
3695         (info_args_command): Likewise.
3696         * symtab.c (info_variables_command): Likewise.
3697         (info_functions_command): Likewise.
3698
3699 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3700
3701         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3702         to extract string arguments.
3703         * common/common-utils.c (extract_string_maybe_quoted): New function.
3704         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3705
3706 2019-07-11  Tom Tromey  <tromey@adacore.com>
3707
3708         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3709         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3710         * top.h (gdbinit): Don't declare.
3711         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3712         into...
3713         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3714         * top.c (gdb_init): Don't call init_cli_cmds.
3715         (gdbinit): Remove.
3716         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3717
3718 2019-07-11  Tom Tromey  <tromey@adacore.com>
3719
3720         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3721         after it has been moved.
3722
3723 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3724
3725         * valops.c (value_must_coerce_to_target): Change return type to
3726         bool.
3727         * value.h (value_must_coerce_to_target): Likewise.
3728
3729 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3730
3731         * breakpoint.c (is_hardware_watchpoint): Remove
3732         forward-declaration.
3733         (is_masked_watchpoint): Change return type to bool.
3734         (is_tracepoint): Likewise.
3735         (is_breakpoint): Likewise.
3736         (is_hardware_watchpoint): Likewise.
3737         (is_watchpoint): Likewise.
3738         (is_no_memory_software_watchpoint): Likewise.
3739         (is_catchpoint): Likewise.
3740         (breakpoint_1): Make FILTER parameter's return type bool.
3741         is_masked_watchpoint): Change return type to bool.
3742         (save_breakpoints): Make FILTER parameter's return type bool.
3743         * breakpoint.h (is_breakpoint): Change return type to bool.
3744         (is_watchpoint): Likewise.
3745         (is_catchpoint): Likewise.
3746         (is_tracepoint): Likewise.
3747
3748 2019-07-10  Tom Tromey  <tom@tromey.com>
3749
3750         * defs.h: Don't include gdbarch.h.
3751         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3752         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3753         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3754         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3755         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3756         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3757         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3758         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3759         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3760         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3761         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3762         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3763         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3764         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3765         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3766         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3767         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3768         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3769         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3770         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3771         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3772         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3773         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3774         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3775         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3776         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3777         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3778
3779 2019-07-10  Tom Tromey  <tromey@adacore.com>
3780
3781         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3782         * breakpoint.c (init_ada_exception_breakpoint): Register as
3783         bp_catchpoint.
3784         (print_one_breakpoint_location, print_one_breakpoint): Use
3785         is_ada_exception_catchpoint.
3786         * ada-lang.c (class ada_catchpoint_location): Pass
3787         bp_loc_software_breakpoint to bp_location constructor.
3788         (is_ada_exception_catchpoint): New function.
3789
3790 2019-07-10  Tom Tromey  <tromey@adacore.com>
3791
3792         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3793         VEC.
3794         (struct arm_exidx_entry): New method operator<.
3795         (struct arm_exidx_data) <section_maps>: Change type.
3796         (arm_exidx_data_free): Remove.
3797         (arm_exidx_data_key): Change type.  Move lower.
3798         (arm_exidx_new_objfile): Update.
3799         (arm_compare_exidx_entries): Remove.
3800         (arm_find_exidx_entry, _initialize_arm_tdep)
3801
3802 2019-07-10  Tom Tromey  <tromey@adacore.com>
3803
3804         * solib-spu.c (ocl_program_data_key): Change type.
3805         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3806         Update.
3807
3808 2019-07-10  Tom Tromey  <tromey@adacore.com>
3809
3810         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3811         (struct solib_aix_inferior_data) <library_list>: Change type.
3812         (solib_aix_inferior_data_handle): Change type.
3813         (get_solib_aix_inferior_data): Update.
3814         (solib_aix_free_library_list): Remove.
3815         (library_list_start_library): Update.
3816         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3817         return type.
3818         (solib_aix_get_library_list)
3819         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3820         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3821
3822 2019-07-10  Tom Tromey  <tromey@adacore.com>
3823
3824         * solib-dsbt.c (struct dsbt_info): Add initializers.
3825         (solib_dsbt_pspace_data): Change type.
3826         (dsbt_pspace_data_cleanup): Remove.
3827         (get_dsbt_info, _initialize_dsbt_solib): Update.
3828
3829 2019-07-10  Tom Tromey  <tromey@adacore.com>
3830
3831         * spu-tdep.c (spu_overlay_data): Change type.
3832         (spu_get_overlay_table, spu_overlay_new_objfile)
3833         (_initialize_spu_tdep): Update.
3834
3835 2019-07-10  Tom Tromey  <tromey@adacore.com>
3836
3837         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3838         destructor.
3839         (dbx_objfile_data_key): Change type and declare later.
3840         (DBX_SYMFILE_INFO): Rewrite.
3841         * dbxread.c (dbx_objfile_data_key): Change type.
3842         (dbx_symfile_init): Update.
3843         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3844         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3845         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3846
3847 2019-07-10  Tom Tromey  <tromey@adacore.com>
3848
3849         * jit.c (jit_program_space_key): Change type.  Move lower.
3850         (get_jit_program_space_data): Update.
3851         (jit_program_space_data_cleanup): Remove.
3852         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3853         Update.
3854         (struct jit_program_space_data): Add initializers.
3855
3856 2019-07-10  Tom Tromey  <tromey@adacore.com>
3857
3858         * solib-darwin.c (struct darwin_info): Add initializers.
3859         (solib_darwin_pspace_data): Change type.
3860         (darwin_pspace_data_cleanup): Remove.
3861         (get_darwin_info, _initialize_darwin_solib): Update.
3862
3863 2019-07-10  Tom Tromey  <tromey@adacore.com>
3864
3865         * remote-sim.c (struct sim_inferior_data): Add initializers,
3866         constructor, and destructor.
3867         (sim_inferior_data_key): Change type.  Move lower.
3868         (check_for_duplicate_sim_descriptor): Update.
3869         (get_sim_inferior_data): Use new.  Update.
3870         (~sim_inferior_data_cleanup): Rename from
3871         sim_inferior_data_cleanup.  Simplify.
3872         (gdbsim_close_inferior, simulator_command)
3873         (sim_command_completer, _initialize_remote_sim): Update.
3874         (next_pid, INITIAL_PID): Move earlier.
3875
3876 2019-07-10  Tom Tromey  <tromey@adacore.com>
3877
3878         * python/python-internal.h (create_thread_object): Return
3879         gdbpy_ref.
3880         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
3881         * python/py-inferior.c (struct threadlist_entry): Add
3882         constructor.
3883         <thread_obj>: Now a gdbpy_ref.
3884         (thread_to_thread_object): Update.
3885         (add_thread_object): Use new.
3886         (delete_thread_object): Use delete.
3887         (infpy_threads): Update.
3888         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
3889         GIL.
3890
3891 2019-07-10  Tom Tromey  <tromey@adacore.com>
3892
3893         * valops.c (value_cast): Specialize error message for Ada.
3894
3895 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3896
3897         * breakpoint.c (breakpoint_1): Update doc and parameter names.
3898
3899 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3900
3901         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
3902         bpstat_should_step): Return bool, adjust comments.
3903         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
3904         bpstat_should_step): Likewise.
3905
3906 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3907
3908         * features/Makefile: Use feature target descriptions for Arm.
3909         * features/arm/arm-core.c: Generate new file.
3910         * features/arm/arm-fpa.c: Likewise.
3911         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
3912         * features/arm/arm-m-profile.c: Likewise.
3913         * features/arm/arm-vfpv2.c: Likewise.
3914         * features/arm/arm-vfpv3.c: Likewise.
3915         * features/arm/xscale-iwmmxt.c: Likewise.
3916         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
3917
3918 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3919
3920         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
3921         ptrace earlier.
3922
3923 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
3924
3925         * features/aarch64-pauth.c: Regenerate.
3926
3927 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
3928
3929         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
3930         bool.
3931         (bpstat_what): Use false instead of 0.
3932
3933 2019-07-09  Pedro Alves  <palves@redhat.com>
3934
3935         * break-catch-throw.c (is_exception_catchpoint): New.
3936         * breakpoint.c (print_one_breakpoint_location): New parameter
3937         'raw_loc'.  Handle it.  Use
3938         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
3939         looking at the breakpoint's type.
3940         (print_one_breakpoint): If handling "maint info breakpoints", also
3941         print locations of exception catchpoints.
3942         * breakpoint.h (is_exception_catchpoint): Declare.
3943
3944 2019-07-09  Pedro Alves  <palves@redhat.com>
3945
3946         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
3947         "addr" field.
3948         (allocate_location_exception_catchpoint): New.
3949         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
3950         (initialize_throw_catchpoint_ops): Install
3951         allocate_location_exception_catchpoint as allocate_location
3952         method.
3953         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
3954         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
3955         bp_loc_other.
3956         (breakpoint_address_is_meaningful): Delete.
3957         (bl_address_is_meaningful): New.
3958         (breakpoint_locations_match): Adjust comment.
3959         (bp_location_from_bp_type): New, factored out of...
3960         (bp_location::bp_location(breakpoint *)): ... this.
3961         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
3962         factored out of...
3963         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
3964         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
3965         breakpoint_address_is_meaningful.
3966         (bp_locations_compare): Adjust comment.
3967         (update_global_location_list): Use bl_address_is_meaningful
3968         instead of breakpoint_address_is_meaningful.
3969         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
3970         explicit.
3971         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
3972         * python/py-breakpoint.c (bppy_get_location): No longer check
3973         whether location is null.
3974
3975 2019-07-09  Pedro Alves  <palves@redhat.com>
3976
3977         PR c++/15468
3978         * breakpoint.c (print_one_breakpoint_location): Remove
3979         single-location assert.
3980
3981 2019-07-09  Tom Tromey  <tom@tromey.com>
3982
3983         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
3984         * configure: Rebuild.
3985         * configure.ac: Change common to gdbsupport.
3986         * gdbsupport: Rename from common.
3987         * acinclude.m4: Change common to gdbsupport.
3988         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
3989         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
3990         gdbsupport.
3991         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
3992         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
3993         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
3994         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
3995         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
3996         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
3997         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
3998         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
3999         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4000         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4001         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4002         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4003         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4004         coff-pe-read.c, command.h, compile/compile-c-support.c,
4005         compile/compile-c.h, compile/compile-cplus-symbols.c,
4006         compile/compile-cplus-types.c, compile/compile-cplus.h,
4007         compile/compile-loc2c.c, compile/compile.c, completer.c,
4008         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4009         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4010         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4011         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4012         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4013         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4014         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4015         features/aarch64-core.c, features/aarch64-fpu.c,
4016         features/aarch64-pauth.c, features/aarch64-sve.c,
4017         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4018         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4019         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4020         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4021         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4022         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4023         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4024         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4025         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4026         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4027         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4028         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4029         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4030         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4031         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4032         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4033         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4034         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4035         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4036         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4037         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4038         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4039         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4040         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4041         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4042         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4043         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4044         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4045         minsyms.c, mips-linux-tdep.c, namespace.h,
4046         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4047         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4048         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4049         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4050         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4051         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4052         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4053         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4054         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4055         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4056         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4057         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4058         procfs.c, producer.c, progspace.h, psymtab.h,
4059         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4060         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4061         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4062         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4063         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4064         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4065         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4066         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4067         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4068         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4069         target-memory.c, target.c, target.h, target/waitstatus.c,
4070         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4071         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4072         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4073         unittests/array-view-selftests.c,
4074         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4075         unittests/common-utils-selftests.c,
4076         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4077         unittests/format_pieces-selftests.c,
4078         unittests/function-view-selftests.c,
4079         unittests/lookup_name_info-selftests.c,
4080         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4081         unittests/mkdir-recursive-selftests.c,
4082         unittests/observable-selftests.c,
4083         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4084         unittests/parse-connection-spec-selftests.c,
4085         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4086         unittests/scoped_fd-selftests.c,
4087         unittests/scoped_mmap-selftests.c,
4088         unittests/scoped_restore-selftests.c,
4089         unittests/string_view-selftests.c, unittests/style-selftests.c,
4090         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4091         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4092         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4093         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4094         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4095         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4096
4097 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4098
4099         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4100         bool value.
4101         (decode_digits_ordinary): Set explicit_line field in sal.
4102         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4103         symtab_and_line that was set on an explicit line number in
4104         assembler code.  Do always update the recorded symtab and line if
4105         we do skip the prologue.
4106
4107 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4108
4109         * breakpoint.c (set_breakpoint_location_function): Remove
4110         explicit_loc parameter.
4111         (momentary_breakpoint_from_master): Update call to
4112         set_breakpoint_location_function.
4113         (add_location_to_breakpoint): Likewise.
4114
4115 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4116
4117         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4118         required features based on default bfd type when no specific bfd
4119         is present.
4120
4121 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4122
4123         * NEWS: Mention that GDB printf and eval commands can now print
4124         C-style and Ada-style convenience var strings without
4125         calling the inferior.
4126         * printcmd.c (printf_c_string): Locally print GDB internal var
4127         instead of transiting via the inferior.
4128         (printf_wide_c_string): Likewise.
4129
4130 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4131
4132         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4133
4134 2019-07-04  Tom Tromey  <tom@tromey.com>
4135
4136         PR tui/24724:
4137         * tui/tui-winsource.c (tui_clear_source_content): Update.
4138         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4139         (tui_update_breakpoint_info): Update.
4140         (tui_set_exec_info_content): Update.
4141         * tui/tui-source.c (tui_set_source_content_nil): Update.
4142         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4143         has_break.
4144         * tui/tui-data.h (enum tui_bp_flag): New.
4145         (tui_bp_flags): New enum flags type.
4146         (struct tui_source_element) <break_mode>: Change type.  Rename
4147         from has_break.
4148         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4149         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4150         constants.
4151         * tui/tui-winsource.h: Fix comment.
4152
4153 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4154
4155         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4156         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4157         (store_fpregs_to_thread)
4158         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4159         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4160         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4161         (IWMMXT_REGS_SIZE): Add define.
4162         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4163         (fetch_vfp_regs, store_vfp_regs)
4164         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4165         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4166
4167 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4168
4169         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4170         defines.
4171         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4172         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4173         (ARM_INT_REGISTER_SIZE): ...to this.
4174         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4175         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4176         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4177         (arm_linux_collect_gregset, supply_nwfpe_register)
4178         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4179         defines.
4180         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4181         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4182         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4183         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4184         (arm_return_in_memory, arm_store_return_value)
4185         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4186         (arm_record_ld_st_multiple): Likewise.
4187         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4188         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4189
4190 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4191
4192         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4193         AARCH64_DISPLACED_MODIFIED_INSNS.
4194         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4195         (aarch64_displaced_step_copy_insn): Likewise.
4196         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4197         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4198         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4199         ARM_DISPLACED_MODIFIED_INSNS.
4200         * arm-tdep.c (arm_gdbarch_init): Likewise.
4201         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4202         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4203         (struct arm_displaced_step_closure): Use
4204         ARM_DISPLACED_MODIFIED_INSNS.
4205
4206 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4207
4208         * features/Makefile: Remove unused xml files.
4209         * features/aarch64.xml: Remove.
4210         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4211         * features/i386/amd64-avx-avx512.xml: Remove.
4212         * features/i386/amd64-avx-linux.xml: Remove.
4213         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4214         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4215         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4216         * features/i386/amd64-avx-mpx.xml: Remove.
4217         * features/i386/amd64-avx.xml: Remove.
4218         * features/i386/amd64-linux.xml: Remove.
4219         * features/i386/amd64-mpx-linux.xml: Remove.
4220         * features/i386/amd64-mpx.xml: Remove.
4221         * features/i386/amd64.xml: Remove.
4222         * features/i386/i386-avx-avx512-linux.xml: Remove.
4223         * features/i386/i386-avx-avx512.xml: Remove.
4224         * features/i386/i386-avx-linux.xml: Remove.
4225         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4226         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4227         * features/i386/i386-avx-mpx-linux.xml: Remove.
4228         * features/i386/i386-avx-mpx.xml: Remove.
4229         * features/i386/i386-avx.xml: Remove.
4230         * features/i386/i386-linux.xml: Remove.
4231         * features/i386/i386-mmx-linux.xml: Remove.
4232         * features/i386/i386-mmx.xml: Remove.
4233         * features/i386/i386-mpx-linux.xml: Remove.
4234         * features/i386/i386-mpx.xml: Remove.
4235         * features/i386/i386.xml: Remove.
4236         * features/i386/x32-avx-avx512-linux.xml: Remove.
4237         * features/i386/x32-avx-linux.xml: Remove.
4238         * features/i386/x32-linux.xml: Remove.
4239
4240 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4241
4242         * regformats/aarch64.dat: Remove.
4243         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4244         * regformats/i386/amd64-avx-linux.dat: Remove.
4245         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4246         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4247         * regformats/i386/amd64-linux.dat: Remove.
4248         * regformats/i386/amd64-mpx-linux.dat: Remove.
4249         * regformats/i386/amd64.dat: Remove.
4250         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4251         * regformats/i386/i386-avx-linux.dat: Remove.
4252         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4253         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4254         * regformats/i386/i386-linux.dat: Remove.
4255         * regformats/i386/i386-mmx-linux.dat: Remove.
4256         * regformats/i386/i386-mpx-linux.dat: Remove.
4257         * regformats/i386/i386.dat: Remove.
4258         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4259         * regformats/i386/x32-avx-linux.dat: Remove.
4260         * regformats/i386/x32-linux.dat: Remove.
4261
4262 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4263
4264         * aarch64-tdep.c: Remove xml self tests.
4265         * amd64-linux-tdep.c: Likewise.
4266         * amd64-tdep.c: Likewise.
4267         * i386-linux-tdep.c: Likewise.
4268         * i386-tdep.c: Likewise.
4269
4270 2019-07-03  Pedro Alves  <palves@redhat.com>
4271
4272         PR cli/24732
4273         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4274         (pipe_cmd_option_defs): New.
4275         (make_pipe_cmd_options_def_group): New.
4276         (pipe_command): Use gdb::option::process_options.
4277         (pipe_command_completer): New function.
4278         (_initialize_cli_cmds): Install completer for "pipe" command.
4279
4280 2019-07-03  Pedro Alves  <palves@redhat.com>
4281
4282         * cli/cli-option.c (union option_value) <string>: New field.
4283         (struct option_def_and_value): Add ctor, move ctor, dtor and
4284         use DISABLE_COPY_AND_ASSIGN.
4285         (option_def_and_value::clear_value): New.
4286         (parse_option, save_option_value_in_ctx, get_val_type_str)
4287         (add_setshow_cmds_for_options): Handle var_string.
4288         * cli-option.h (union option_def::var_address) <string>: New
4289         field.
4290         (struct string_option_def): New.
4291         * maint-test-options.c (struct test_options_opts): Add default
4292         ctor and use DISABLE_COPY_AND_ASSIGN.
4293         <string_opt>: New field.
4294         (test_options_opts::~test_options_opts): New.
4295         (test_options_opts::dump): Also dump "-string".
4296         (test_options_option_defs): Install "string.
4297
4298 2019-07-03  Pedro Alves  <palves@redhat.com>
4299
4300         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4301         option_value with a null enumeration.
4302         (complete_options): Save the option values in the context.
4303         (save_option_value_in_ctx): New, factored out from ...
4304         (process_options): ... here.
4305         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4306         of the function.
4307         * maint-test-options.c (test_options_opts::dump): New, factored
4308         out from ...
4309         (maintenance_test_options_command_mode): ... here.
4310         (maintenance_test_options_command_completion_result): Delete.
4311         (maintenance_test_options_command_completion_text): Update
4312         comment.
4313         (maintenance_show_test_options_completion_result): Change
4314         prototype.  Just print
4315         maintenance_test_options_command_completion_text.
4316         (save_completion_result): New.
4317         (maintenance_test_options_completer_mode): Pass options context to
4318         complete_options, and then save a dump.
4319         (_initialize_maint_test_options): Use add_cmd to install "maint
4320         show test-options-completion-result".
4321
4322 2019-07-03  Pedro Alves  <palves@redhat.com>
4323
4324         * NEWS (New commands): Mention "with" and "maint with".
4325         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4326         (with_command, with_command_completer): New.
4327         (pipe_command): Adjust to new repeat_previous
4328         interface.
4329         (_initialize_cli_cmds): Install the "with" command and its "w"
4330         alias.
4331         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4332         declarations.
4333         * cli/cli-setshow.c (parse_cli_var_uinteger)
4334         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4335         argument strings for all var_types.
4336         (get_setshow_command_value_string): New, factored out from ...
4337         (do_show_command): ... this.
4338         * cli/cli-setshow.h: Include <string>.
4339         (get_setshow_command_value_string): Declare.
4340         * command.h (repeat_previous): Now returns const char *.  Adjust
4341         comment.
4342         * maint.c: Include "cli/cli-cmds.h".
4343         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4344         (_initialize_maint_cmds): Register the "maintenance with" command.
4345         * top.c (repeat_previous): Move bits from pipe_command here:
4346         Return the saved command line, if any; error out if there's no
4347         command to relaunch.
4348
4349 2019-07-03  Pedro Alves  <palves@redhat.com>
4350
4351         * NEWS (New commands): Mention "maint set/show test-settings"
4352         instead of "maint test-settings".
4353         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4354         (maintenance_test_settings_set_list): Rename to ...
4355         (maintenance_set_test_settings_list): ... this.
4356         (maintenance_test_settings_show_list): Rename to  ...
4357         (maintenance_show_test_settings_list): ... this.
4358         (maintenance_test_settings_cmd): Delete.
4359         (maintenance_test_settings_set_cmd): ...
4360         (maintenance_set_test_settings_cmd): ... this.
4361         (maintenance_test_settings_show_cmd): ...
4362         (maintenance_show_test_settings_cmd): ... this.
4363         (maintenance_test_settings_show_value_cmd):
4364         (maintenance_show_test_settings_value_cmd): ... this.
4365         (_initialize_maint_test_settings): No longer install the "maint
4366         test-settings" prefix command.  Rename "maint test-settings set"
4367         to "maint set test-settings", and "maint test-settings show" to
4368         "maint show test-settings".  Adjust all subcommands.
4369
4370 2019-07-03  Pedro Alves  <palves@redhat.com>
4371
4372         * maint-test-settings.c: Fix file's intro comment.  Replace all
4373         references to "test-options" with references to "test-settings",
4374         in comments.
4375
4376 2019-07-03  Pedro Alves  <palves@redhat.com>
4377
4378         * maint-test-settings.c (maintenance_test_settings_xxx)
4379         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4380         New.
4381         (maintenance_test_settings_enums): Use them.
4382         (maintenance_test_settings_enum): Default to
4383         maintenance_test_settings_xxx.
4384         (_initialize_maint_test_settings): Initialize
4385         MAINTENANCE_TEST_SETTINGS_FILENAME.
4386
4387 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4388
4389         * breakpoint.h (remove_breakpoints_inf): Change return type to
4390         void, move function documentation here.
4391         * breakpoint.c (remove_breakpoints_inf): Change return type to
4392         void, move function documentation to header.
4393
4394 2019-07-02  Pedro Alves  <palves@redhat.com>
4395
4396         * NEWS (Completion improvements): Mention "info threads".
4397         * thread.c (struct info_threads_opts, info_threads_option_defs)
4398         (make_info_threads_options_def_group): New.
4399         (info_threads_command): Use gdb::option::process_options.
4400         (info_threads_command_completer): New.
4401         (_initialize_thread): Use gdb::option::build_help to build the
4402         help text for "info threads".
4403
4404 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4405
4406         * defs.h (generic_load): Move from here...
4407         * symfile.h (generic_load): ... to here.  Rename name parameter
4408         to args.
4409         * symfile.c (generic_load): Add comment.
4410
4411 2019-07-01  Tom Tromey  <tromey@adacore.com>
4412
4413         * dwarf2read.c
4414         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4415         declaration of without_params.  Fix formatting.
4416
4417 2019-07-01  Tom Tromey  <tromey@adacore.com>
4418
4419         * ada-exp.y (find_primitive_type): Update.
4420         * ada-lang.h (ada_lookup_symbol): Update.
4421         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4422         parameter.
4423         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4424
4425 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4426
4427         PR breakpoints/24541
4428         * gdbarch.c: Regenerate.
4429         * gdbarch.h: Regenerate.
4430         * gdbarch.sh: Add 'stap_adjust_register'.
4431         * i386-tdep.c: Include '<unordered_set>'.
4432         (i386_stap_adjust_register): New function.
4433         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4434         * stap-probe.c (stap_parse_register_operand): Call
4435         'gdbarch_stap_adjust_register'.
4436
4437 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4438
4439         PR python/24742
4440         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4441         * python/python.c (do_start_initialization): Use 'xmalloc'
4442         instead of 'PyMem_Malloc'.
4443
4444 2019-06-28  Tom Tromey  <tromey@adacore.com>
4445
4446         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4447         for Ada.
4448
4449 2019-06-27  Tom Tromey  <tromey@adacore.com>
4450
4451         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4452         objfile_key.
4453         (arm_find_mapping_symbol, arm_record_special_symbol)
4454         (_initialize_arm_tdep): Update.
4455         (arm_objfile_data_free): Remove.
4456
4457 2019-06-27  Tom Tromey  <tromey@adacore.com>
4458
4459         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4460         to cp_print_static_field.
4461
4462 2019-06-26  Tom Tromey  <tromey@adacore.com>
4463
4464         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4465         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4466         declare.
4467
4468 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4469
4470         * features/aarch64-core.c (create_feature_aarch64_core):
4471         Regenerate.
4472         * features/aarch64-core.xml: Add cpsr flags.
4473
4474 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4475
4476         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4477         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4478
4479 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4480
4481         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4482         field.
4483         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4484         use.
4485         (arm_record_special_symbol): Don't insert new symbol in sorted
4486         position, push it at the end.
4487
4488 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4489
4490         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4491         (arm_mapping_symbol_s): Remove.
4492         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4493         (arm_mapping_symbol_vec): New typedef.
4494         (struct arm_per_objfile): Add constructor.
4495         <section_maps>: Change type to
4496         std::unique_ptr<arm_mapping_symbol_vec[]>.
4497         (arm_compare_mapping_symbols): Remove.
4498         (arm_find_mapping_symbol): Adjust to section_maps type change.
4499         (arm_objfile_data_free): Call delete on arm_per_objfile.
4500         (arm_record_special_symbol): Adjust to section_maps type change.
4501         Allocate arm_per_objfile with new.
4502
4503 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4504
4505         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4506         with the command prefix.
4507
4508 2019-06-25  Tom Tromey  <tom@tromey.com>
4509
4510         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4511         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4512
4513 2019-06-25  Tom Tromey  <tom@tromey.com>
4514
4515         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4516         type.
4517         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4518         protected.
4519
4520 2019-06-25  Tom Tromey  <tom@tromey.com>
4521
4522         * tui/tui-winsource.c
4523         (tui_source_window_base::set_is_exec_point_at): Add check against
4524         LOA_ADDRESS.
4525
4526 2019-06-25  Tom Tromey  <tom@tromey.com>
4527
4528         * tui/tui-source.c (tui_set_source_content): Don't check before
4529         xfree.
4530         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4531
4532 2019-06-25  Tom Tromey  <tom@tromey.com>
4533
4534         * tui/tui-winsource.h (tui_update_source_window_as_is)
4535         (tui_alloc_source_buffer, tui_line_is_displayed)
4536         (tui_addr_is_displayed): Change type of win_info.
4537         * tui/tui-winsource.c (tui_update_source_window_as_is)
4538         (tui_clear_source_content, tui_show_source_line)
4539         (tui_show_source_content, tui_source_window_base::refill)
4540         (tui_source_window_base::set_is_exec_point_at)
4541         (tui_source_window_base::set_is_exec_point_at)
4542         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4543         (tui_alloc_source_buffer, tui_line_is_displayed)
4544         (tui_addr_is_displayed): Change type of win_info.  Update.
4545         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4546         (tui_source_window_base::do_make_visible_with_new_height):
4547         Update.
4548         * tui/tui-source.c (tui_set_source_content)
4549         (tui_set_source_content_nil)
4550         (tui_source_window::do_scroll_vertical): Update.
4551         * tui/tui-layout.c (show_layout): Update.
4552         * tui/tui-disasm.c (tui_set_disassem_content)
4553         (tui_disasm_window::do_scroll_vertical): Update.
4554         * tui/tui-data.h (tui_win_content): Remove.
4555         (struct tui_gen_win_info) <content, content_size>: Remove.
4556         (struct tui_source_element): Add initializers and destructor.
4557         (union tui_which_element, struct tui_win_element): Remove.
4558         (struct tui_source_window_base) <content>: New field.
4559         (struct tui_data_window): Remove destructor.
4560         (tui_alloc_content, tui_free_win_content)
4561         (tui_free_all_source_wins_content): Don't declare.
4562         * tui/tui-data.c (tui_initialize_static_data): Update.
4563         (init_content_element, tui_alloc_content): Remove.
4564         (~tui_gen_win_info): Update.
4565         (~tui_data_window, tui_free_all_source_wins_content)
4566         (tui_free_win_content, free_content, free_content_elements):
4567         Remove.
4568
4569 2019-06-25  Tom Tromey  <tom@tromey.com>
4570
4571         * tui/tui-winsource.h (tui_clear_source_content)
4572         (tui_erase_source_content, tui_show_source_content): Change type
4573         of win_info.
4574         * tui/tui-winsource.c (tui_clear_source_content)
4575         (tui_erase_source_content, tui_show_source_content): Change type
4576         of win_info.
4577         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4578         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4579         win_info.
4580         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4581         win_info.
4582         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4583
4584 2019-06-25  Tom Tromey  <tom@tromey.com>
4585
4586         * tui/tui-winsource.c (tui_clear_source_content)
4587         (tui_source_window_base::set_is_exec_point_at): Update.
4588         * tui/tui-source.c (tui_set_source_content_nil): Update.
4589         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4590         a bool.
4591         * tui/tui-data.c (init_content_element): Update.
4592
4593 2019-06-25  Tom Tromey  <tom@tromey.com>
4594
4595         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4596         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4597         * tui/tui-layout.c (init_and_make_win): Update.
4598         * tui/tui.h (enum tui_win_type): Update.
4599         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4600         tui_win_is_auxillary.
4601         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4602         tui_win_is_auxillary.
4603
4604 2019-06-25  Tom Tromey  <tom@tromey.com>
4605
4606         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4607         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4608         (tui_delete_data_content_windows, tui_display_all_data)
4609         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4610         Update.
4611         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4612         * tui/tui-regs.c (tui_last_regs_line_no)
4613         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4614         (tui_show_registers): Update.
4615         (tui_show_register_group): Return void.  Update.
4616         (tui_display_registers_from, tui_display_reg_element_at_line)
4617         (tui_display_registers_from_line, tui_check_register_values):
4618         Update.
4619         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4620         member.
4621         (struct tui_data_window) <regs_content>: Now a std::vector.
4622         <regs_content_count>: Remove.
4623         (tui_add_content_elements, tui_free_data_content): Don't declare.
4624         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4625         (init_content_element): Remove DATA_WIN case.  Add assert.
4626         (tui_add_content_elements): Remove.
4627         (tui_data_window): Update.
4628         (tui_free_data_content): Remove.
4629         (free_content_elements): Remove DATA_WIN case.
4630
4631 2019-06-25  Tom Tromey  <tom@tromey.com>
4632
4633         * tui/tui-data.c (tui_data_item_window): Update.
4634         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4635         * tui/tui-windata.c (tui_display_all_data)
4636         (tui_display_data_from_line): Update.
4637         (tui_check_data_values): Remove.
4638         * tui/tui-regs.c (tui_show_register_group)
4639         (tui_display_reg_element_at_line): Update.
4640         * tui/tui-hooks.c (tui_register_changed)
4641         (tui_refresh_frame_and_register_information): Call
4642         tui_check_register_values.
4643         * tui/tui-data.h (struct tui_data_window) <data_content,
4644         data_content_count, data_type>: Remove.
4645         (enum tui_data_type): Remove.
4646
4647         * tui/tui-data.c (tui_data_window::clear_detail)
4648         (~tui_data_window): Update.
4649
4650 2019-06-25  Tom Tromey  <tom@tromey.com>
4651
4652         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4653         declare.
4654         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4655         Rename from tui_first_data_item_displayed.  Update.
4656         (tui_data_window::refresh_all)
4657         (tui_data_window::do_scroll_vertical): Update.
4658         * tui/tui-data.h (struct tui_data_window)
4659         <first_data_item_displayed>: Declare new method.
4660
4661 2019-06-25  Tom Tromey  <tom@tromey.com>
4662
4663         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4664         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4665         contents...
4666         (tui_initialize_static_data): ...here.
4667
4668 2019-06-25  Tom Tromey  <tom@tromey.com>
4669
4670         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4671         (tui_display_registers_from, tui_check_register_values): Update.
4672         (tui_display_register): Remove win_info parameter; update.
4673         (tui_get_register): Change type of parameters.
4674         * tui/tui-data.h (struct tui_data_element): Remove.
4675         (union tui_which_element) <data>: Remove.
4676         <data_window>: Change type.
4677         (struct tui_data_item_window): New.
4678         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4679         case.  Add assert.
4680         (~tui_data_item_window): New destructor.
4681         (free_content_elements): Remove DATA_ITEM_WIN case.
4682
4683 2019-06-25  Tom Tromey  <tom@tromey.com>
4684
4685         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4686         Remove.
4687
4688 2019-06-25  Tom Tromey  <tom@tromey.com>
4689
4690         * tui/tui-data.h (struct tui_command_element): Remove.
4691         (union tui_which_element) <command>: Remove.
4692         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4693         assert.
4694         (free_content_elements): Remove CMD_WIN case.
4695
4696 2019-06-25  Tom Tromey  <tom@tromey.com>
4697
4698         * tui/tui-layout.c (tui_set_layout): Update.
4699         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4700         * tui/tui-data.c (layout_def): Update.
4701
4702 2019-06-25  Tom Tromey  <tom@tromey.com>
4703
4704         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4705         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4706         (tui_source_window_base::set_new_height): Update.
4707         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4708         Update.
4709         (tui_set_locator_fullname, tui_set_locator_info)
4710         (tui_show_frame_info): Update.
4711         * tui/tui-source.c (tui_set_source_content)
4712         (tui_source_is_displayed): Update.
4713         * tui/tui-layout.c (show_source_disasm_command, show_data)
4714         (show_source_or_disasm_and_command): Update.
4715         * tui/tui-disasm.c (tui_set_disassem_content)
4716         (tui_get_begin_asm_address): Update.
4717         * tui/tui-data.h (struct tui_locator_element): Remove.
4718         (union tui_which_element) <locator>: Remove.
4719         (struct tui_locator_window): New.
4720         (tui_locator_win_info_ptr): Change return type.
4721         * tui/tui-data.c (_locator): Change type.
4722         (tui_locator_win_info_ptr): Change return type.
4723         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4724         (tui_alloc_content): Add assert.
4725
4726 2019-06-25  Tom Tromey  <tom@tromey.com>
4727
4728         * tui/tui-winsource.c
4729         (tui_exec_info_window::maybe_allocate_content): New method.
4730         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4731         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4732         (make_source_or_disasm_window): Add cast.
4733         * tui/tui-data.h (union tui_which_element) <simple_string>:
4734         Remove.
4735         (struct tui_source_info): New.
4736         (struct tui_source_window_base) <execution_info>: Change type.
4737         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4738         case, and add assert.
4739         (tui_alloc_content): Add assert.
4740
4741 2019-06-25  Tom Tromey  <tom@tromey.com>
4742
4743         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4744         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4745         * tui/tui-data.c (tui_alloc_win_info): Remove.
4746
4747 2019-06-25  Tom Tromey  <tom@tromey.com>
4748
4749         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4750         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4751         can_highlight.
4752
4753 2019-06-25  Tom Tromey  <tom@tromey.com>
4754
4755         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4756         make_visible_with_new_height method.
4757         (tui_win_info::make_visible_with_new_height): New method.
4758         (tui_source_window_base::do_make_visible_with_new_height)
4759         (tui_data_window::do_make_visible_with_new_height)
4760         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4761         (make_visible_with_new_height): Remove.
4762         (tui_resize_all, tui_adjust_win_heights): Use
4763         make_visible_with_new_height method.
4764         * tui/tui-data.h (struct tui_win_info)
4765         <do_make_visible_with_new_height, make_visible_with_new_height>:
4766         New methods.
4767         (struct tui_source_window_base, struct tui_data_window)
4768         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4769         methods.
4770
4771 2019-06-25  Tom Tromey  <tom@tromey.com>
4772
4773         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4774         method.
4775         (update_tab_width): Call update_tab_width method.
4776         * tui/tui-data.h (struct tui_win_info)
4777         (struct tui_source_window_base) <update_tab_width>: New methods.
4778
4779 2019-06-25  Tom Tromey  <tom@tromey.com>
4780
4781         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4782         parameter.
4783         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4784         parameter.
4785         (tui_gen_win_info::make_visible): Update.
4786         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4787         parameter.
4788         * tui/tui-data.h (enum tui_box): New enum.
4789         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4790
4791 2019-06-25  Tom Tromey  <tom@tromey.com>
4792
4793         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4794         init_and_make_win for EXEC_INFO_WIN.
4795         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4796         longer inline.
4797         (struct tui_win_info) <~tui_win_info>: Inline.
4798         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4799         Don't declare.
4800         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4801         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4802         Remove.
4803         (tui_initialize_static_data): Update.
4804         (~tui_gen_win_info): Handle more cleanup here.
4805         (~tui_source_window_base): Delete "execution_info".
4806         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4807
4808 2019-06-25  Tom Tromey  <tom@tromey.com>
4809
4810         * tui/tui-layout.c (make_command_window): Don't set
4811         can_highlight.
4812         (show_source_disasm_command): Call the reset method.
4813         (show_data): Don't set can_highlight.  Call the reset method.
4814         (tui_gen_win_info::reset): Rename from init_gen_win_info
4815         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4816         (show_source_or_disasm_and_command): Call the reset method.
4817         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4818         (struct tui_cmd_window): Set can_highlight.
4819
4820 2019-06-25  Tom Tromey  <tom@tromey.com>
4821
4822         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4823         from make_visible.
4824         (tui_make_visible, tui_make_invisible): Rewrite.
4825         (tui_win_info::make_visible): Remove.
4826         (tui_source_window_base::make_visible): Update.
4827         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4828         method.  Moved from...
4829         (struct tui_win_info) <make_visible>: ...here.
4830
4831 2019-06-25  Tom Tromey  <tom@tromey.com>
4832
4833         * tui/tui-winsource.c
4834         (tui_source_window_base::do_scroll_horizontal): Remove direction
4835         parameter.
4836         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4837         direction parameter.
4838         * tui/tui-win.c (tui_win_info::forward_scroll)
4839         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4840         (tui_win_info::right_scroll): Update.
4841         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4842         direction parameter.
4843         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4844         direction parameter.
4845         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4846         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4847         Remove direction parameter.
4848         (struct tui_source_window_base, struct tui_source_window)
4849         (struct tui_disasm_window, struct tui_data_window)
4850         (struct tui_cmd_window): Update.
4851
4852 2019-06-25  Tom Tromey  <tom@tromey.com>
4853
4854         * tui/tui-winsource.h (tui_set_exec_info_content)
4855         (tui_show_exec_info_content, tui_erase_exec_info_content)
4856         (tui_clear_exec_info_content, tui_update_exec_info): Change
4857         argument to tui_source_window_base.
4858         * tui/tui-winsource.c (tui_set_exec_info_content)
4859         (tui_show_exec_info_content, tui_erase_exec_info_content)
4860         (tui_clear_exec_info_content, tui_update_exec_info): Change
4861         argument to tui_source_window_base.
4862
4863 2019-06-25  Tom Tromey  <tom@tromey.com>
4864
4865         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4866         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4867
4868 2019-06-25  Tom Tromey  <tom@tromey.com>
4869
4870         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
4871         check.
4872
4873 2019-06-25  Tom Tromey  <tom@tromey.com>
4874
4875         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
4876         type to void.
4877         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
4878         type to void.
4879         * tui/tui-source.c (tui_set_source_content): Update.
4880         * tui/tui-disasm.c (tui_set_disassem_content): Update.
4881
4882 2019-06-25  Tom Tromey  <tom@tromey.com>
4883
4884         * tui/tui-win.c (window_name_completer, tui_set_focus)
4885         (tui_all_windows_info): Use name method.
4886         * tui/tui-data.h (struct tui_gen_win_info)
4887         (struct tui_source_window, struct tui_disasm_window)
4888         (struct tui_data_window, struct tui_cmd_window) <name>: New
4889         method.
4890         (tui_win_name): Don't declare.
4891         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
4892         (tui_win_name): Remove.
4893
4894 2019-06-25  Tom Tromey  <tom@tromey.com>
4895
4896         * tui/tui-winsource.h (tui_update_source_window)
4897         (tui_update_source_window_as_is): Change parameter type.
4898         * tui/tui-winsource.c (tui_update_source_window): Change win_info
4899         to be a tui_source_window_base.
4900         (tui_update_source_window_as_is): Likewise.
4901         * tui/tui-win.c (make_visible_with_new_height): Update.
4902
4903 2019-06-25  Tom Tromey  <tom@tromey.com>
4904
4905         * tui/tui-winsource.c (tui_erase_source_content)
4906         (tui_show_source_content, tui_show_exec_info_content)
4907         (tui_erase_exec_info_content): Use refresh_window method.
4908         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
4909         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
4910         from tui_refresh_win.
4911         (tui_data_window::refresh_window): New method.
4912         (tui_win_info::refresh, tui_source_window_base::refresh)
4913         (tui_refresh_all): Use refresh_window method.
4914         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
4915         method.
4916         * tui/tui-regs.c (tui_display_register): Call refresh_window
4917         method.
4918         * tui/tui-layout.c (show_source_disasm_command)
4919         (show_source_or_disasm_and_command): Call refresh_window method.
4920         * tui/tui-data.h (struct tui_gen_win_info)
4921         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
4922         New method.
4923
4924 2019-06-25  Tom Tromey  <tom@tromey.com>
4925
4926         * tui/tui.c (tui_rl_other_window, tui_enable)
4927         (tui_is_window_visible, tui_get_command_dimension): Update.
4928         * tui/tui-winsource.c (tui_update_source_window_as_is)
4929         (tui_clear_source_content, tui_erase_source_content)
4930         (tui_show_source_line, tui_source_window_base::refill)
4931         (tui_source_window_base::do_scroll_horizontal)
4932         (tui_source_window_base::set_is_exec_point_at)
4933         (tui_update_breakpoint_info, tui_set_exec_info_content)
4934         (tui_alloc_source_buffer, tui_line_is_displayed)
4935         (tui_addr_is_displayed): Update.
4936         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
4937         (tui_check_and_display_highlight_if_needed)
4938         (tui_win_info::make_visible, tui_win_info::refresh)
4939         (tui_refresh_all): Update.
4940         * tui/tui-windata.c (tui_first_data_item_displayed)
4941         (tui_delete_data_content_windows, tui_erase_data_content)
4942         (tui_display_all_data, tui_data_window::refresh_all)
4943         (tui_check_data_values): Update.
4944         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
4945         (tui_set_win_focus_to, tui_win_info::forward_scroll)
4946         (tui_win_info::backward_scroll, tui_refresh_all_win)
4947         (tui_resize_all, tui_set_focus, tui_all_windows_info)
4948         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
4949         (tui_source_window_base::set_new_height)
4950         (tui_data_window::set_new_height)
4951         (make_invisible_and_set_new_height)
4952         (make_visible_with_new_height, new_height_ok)
4953         (parse_scrolling_args): Update.
4954         * tui/tui-stack.c (tui_show_frame_info): Update.
4955         * tui/tui-source.c (tui_set_source_content)
4956         (tui_set_source_content_nil, tui_source_is_displayed)
4957         (tui_source_window::do_scroll_vertical): Update.
4958         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4959         (tui_display_registers_from, tui_display_reg_element_at_line)
4960         (tui_check_register_values, tui_reg_command): Update.
4961         * tui/tui-layout.c (tui_default_win_height)
4962         (show_source_disasm_command, show_data, init_and_make_win)
4963         (show_source_or_disasm_and_command): Update.
4964         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
4965         (tui_redisplay_readline, tui_mld_flush)
4966         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
4967         (tui_getc): Update.
4968         * tui/tui-disasm.c (tui_set_disassem_content)
4969         (tui_disasm_window::do_scroll_vertical): Update.
4970         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
4971         Now virtual.
4972         (struct tui_win_info): Derive from tui_gen_win_info.
4973         <~tui_win_info>: Mark as override.
4974         <generic>: Remove member.
4975         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
4976         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
4977         (~tui_data_window, ~tui_win_info)
4978         (tui_free_all_source_wins_content): Update.
4979         * tui/tui-command.c (tui_refresh_cmd_win): Update.
4980
4981 2019-06-25  Tom Tromey  <tom@tromey.com>
4982
4983         * tui/tui-layout.c (init_and_make_win): Use new.
4984         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
4985         destructor, initializers.
4986         (tui_alloc_generic_win_info): Don't declare.
4987         * tui/tui-data.c (_locator): Add argument to constructor.
4988         (source_win, disasm_win): New globals.
4989         (exec_info): Remove.
4990         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4991         Update.
4992         (tui_alloc_generic_win_info): Remove.
4993         (init_content_element): Use new.
4994         (tui_win_info::tui_win_info): Update.
4995         (free_content_elements) <case DATA_WIN>: Use delete.
4996
4997 2019-06-25  Tom Tromey  <tom@tromey.com>
4998
4999         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5000         * tui/tui-windata.c (tui_first_data_item_displayed)
5001         (tui_delete_data_content_windows): Update.
5002         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5003         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5004         (tui_display_registers_from, tui_check_register_values): Update.
5005         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5006         pointer.
5007         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5008         window.
5009         (tui_free_data_content): Update.
5010         (free_content_elements) <case DATA_WIN>: Free the window.
5011
5012 2019-06-25  Tom Tromey  <tom@tromey.com>
5013
5014         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5015         Update.
5016         * tui/tui-layout.c (make_command_window)
5017         (show_source_disasm_command, show_data, init_and_make_win)
5018         (show_source_or_disasm_and_command): Update.
5019         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5020         method.
5021         <can_highight, is_highlighted>: Now bool.
5022         (tui_set_win_highlight): Don't declare.
5023         * tui/tui-data.c (tui_set_win_highlight): Remove.
5024
5025 2019-06-25  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-wingeneral.c (make_visible): Remove check of window
5028         type.
5029
5030 2019-06-25  Tom Tromey  <tom@tromey.com>
5031
5032         * tui/tui-win.c (tui_win_info::max_height)
5033         (tui_cmd_window::max_height): New methods.
5034         (new_height_ok): Call max_height.
5035         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5036         <max_height>: New method.
5037
5038 2019-06-25  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-win.c (tui_source_window_base::set_new_height)
5041         (tui_data_window::set_new_height): New methods.
5042         (make_invisible_and_set_new_height): Call set_new_height method.
5043         * tui/tui-data.h (struct tui_win_info)
5044         (struct tui_source_window_base, struct tui_data_window)
5045         <set_new_height>: New method.
5046
5047 2019-06-25  Tom Tromey  <tom@tromey.com>
5048
5049         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5050         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5051         tui_refresh_data_win.
5052         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5053         method.
5054         (tui_refresh_all_win): Call the refresh_all method.
5055         (tui_set_focus): Likewise.
5056         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5057         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5058         Likewise.
5059
5060 2019-06-25  Tom Tromey  <tom@tromey.com>
5061
5062         * tui/tui-winsource.h (tui_refill_source_window)
5063         (tui_set_is_exec_point_at): Don't declare.
5064         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5065         (tui_source_window_base::refill): Rename from
5066         tui_refill_source_window.
5067         (tui_source_window_base::do_scroll_horizontal): Update.
5068         (tui_source_window_base::set_is_exec_point_at): Rename from
5069         tui_set_is_exec_point_at.
5070         (tui_update_all_breakpoint_info): Update.
5071         * tui/tui-stack.c (tui_show_frame_info): Update.
5072         * tui/tui-layout.c (show_data): Add cast.
5073         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5074         * tui/tui-data.h (struct tui_source_window_base) <refill,
5075         set_is_exec_point_at>: New methods.
5076         (tui_source_windows, tui_add_to_source_windows): Update types.
5077         (tui_add_to_source_windows): Remove redundant declaration.
5078         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5079         (tui_source_windows): Change return type.
5080         (tui_clear_source_windows_detail): Update.
5081         (tui_add_to_source_windows): Change type of parameter.
5082         (tui_free_all_source_wins_content): Update.
5083
5084 2019-06-25  Tom Tromey  <tom@tromey.com>
5085
5086         * tui/tui-wingeneral.c (tui_win_info::refresh)
5087         (tui_source_window_base::refresh): New methods.
5088         (tui_refresh_all): Call the refresh method.
5089         * tui/tui-data.h (struct tui_win_info)
5090         (struct tui_source_window_base) <refresh>: New method.
5091
5092 2019-06-25  Tom Tromey  <tom@tromey.com>
5093
5094         * tui/tui.h (tui_is_window_visible): Return bool.
5095         * tui/tui.c (tui_is_window_visible): Return bool.
5096         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5097         (tui_make_visible, tui_make_invisible)
5098         (tui_win_info::make_visible)
5099         (tui_source_window_base::make_visible, make_all_visible)
5100         (tui_make_all_visible, tui_make_all_invisible): Update.
5101         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5102         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5103         bool.
5104         (struct tui_win_info, struct tui_source_window_base)
5105         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5106         * tui/tui-data.c (tui_init_generic_part): Update.
5107
5108 2019-06-25  Tom Tromey  <tom@tromey.com>
5109
5110         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5111         (tui_source_window_base::make_visible): New methods.
5112         (make_all_visible): Make method call.
5113         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5114         (struct tui_source_window_base, struct tui_cmd_window): Override
5115         make_visible.
5116         (tui_win_is_source_type): Don't declare.
5117         * tui/tui-data.c (tui_win_is_source_type): Remove.
5118
5119 2019-06-25  Tom Tromey  <tom@tromey.com>
5120
5121         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5122         NULL check.
5123
5124 2019-06-25  Tom Tromey  <tom@tromey.com>
5125
5126         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5127         Inline constructor.  Add initializers for members.
5128         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5129         constructors; now inline in class.
5130
5131 2019-06-25  Tom Tromey  <tom@tromey.com>
5132
5133         * tui/tui-regs.c (tui_show_registers): Update.
5134         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5135         bool.
5136         * tui/tui-data.c (tui_data_window::clear_detail)
5137         (tui_data_window): Update.
5138
5139 2019-06-25  Tom Tromey  <tom@tromey.com>
5140
5141         * tui/tui-windata.c (tui_display_all_data)
5142         (tui_display_data_from_line, tui_display_data_from)
5143         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5144         Update.
5145         * tui/tui-regs.c (tui_last_regs_line_no)
5146         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5147         (tui_show_registers, tui_show_register_group)
5148         (tui_display_registers_from, tui_display_reg_element_at_line)
5149         (tui_display_registers_from_line, tui_check_register_values)
5150         (tui_reg_next, tui_reg_prev): Update.
5151         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5152         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5153         tui_data_window.
5154         (struct tui_win_info) <detail>: Remove.  Add new fields from
5155         tui_data_info.
5156         (TUI_DATA_WIN): Add cast.
5157         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5158         (~tui_data_window): Simplify.
5159
5160 2019-06-25  Tom Tromey  <tom@tromey.com>
5161
5162         * tui/tui-layout.c (show_source_disasm_command)
5163         (show_source_or_disasm_and_command): Update.
5164         * tui/tui-io.c (update_cmdwin_start_line)
5165         (tui_redisplay_readline): Update.
5166         * tui/tui-data.h (struct tui_command_info): Remove.
5167         (struct tui_win_info) <detail>: Remove command_info member.
5168         (struct tui_data_window) <start_line>: New member, from
5169         tui_command_info.
5170         (TUI_CMD_WIN): Add casts.
5171
5172 2019-06-25  Tom Tromey  <tom@tromey.com>
5173
5174         * tui/tui-winsource.c (tui_update_source_window)
5175         (tui_refill_source_window)
5176         (tui_source_window_base::do_scroll_horizontal)
5177         (tui_update_breakpoint_info, tui_set_exec_info_content)
5178         (tui_show_exec_info_content, tui_erase_exec_info_content)
5179         (tui_clear_exec_info_content): Update.
5180         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5181         Update.
5182         * tui/tui-win.c (make_invisible_and_set_new_height)
5183         (make_visible_with_new_height): Update.
5184         * tui/tui-source.c (tui_set_source_content)
5185         (tui_show_symtab_source): Update.
5186         * tui/tui-layout.c (extract_display_start_addr)
5187         (show_source_disasm_command, show_data)
5188         (make_source_or_disasm_window)
5189         (show_source_or_disasm_and_command): Update.
5190         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5191         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5192         "gdbarch".
5193         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5194         to tui_source_window_base.
5195         (struct tui_win_info) <detail>: Remove source_info member.
5196         (struct tui_source_window_base) <has_locator>: Inline.
5197         Move contents from tui_source_info; rename has_locator member to
5198         m_has_locator.
5199         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5200         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5201         header file.
5202         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5203         Simplify.
5204         (tui_free_all_source_wins_content): Cast to
5205         tui_source_window_base.
5206
5207 2019-06-25  Tom Tromey  <tom@tromey.com>
5208
5209         * tui/tui-win.c (make_invisible_and_set_new_height)
5210         (make_visible_with_new_height): Call has_locator method.
5211         * tui/tui-layout.c (show_source_disasm_command, show_data)
5212         (show_source_or_disasm_and_command): Update for bool change.
5213         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5214         (tui_win_info) <has_locator>: New method.
5215         (struct tui_source_window_base) <has_locator>: New method.
5216         (tui_win_has_locator): Don't declare.
5217         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5218         from tui_win_has_locator.
5219         (tui_source_window_base): Use false, not FALSE.
5220
5221 2019-06-25  Tom Tromey  <tom@tromey.com>
5222
5223         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5224         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5225         clear_detail method directly.
5226         (tui_clear_win_detail): Remove.
5227
5228 2019-06-25  Tom Tromey  <tom@tromey.com>
5229
5230         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5231         "this", not TUI_DISASM_WIN.
5232
5233 2019-06-25  Tom Tromey  <tom@tromey.com>
5234
5235         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5236         declare.
5237         * tui/tui-winsource.c
5238         (tui_source_window_base::do_scroll_horizontal): Rename from
5239         tui_horizontal_source_scroll.
5240         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5241         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5242         from tui_vertical_data_scroll.
5243         * tui/tui-win.h (tui_scroll): Don't declare.
5244         * tui/tui-win.c (tui_win_info::forward_scroll)
5245         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5246         (tui_win_info::right_scroll): Rename and update.
5247         (tui_scroll_forward_command, tui_scroll_backward_command)
5248         (tui_scroll_left_command, tui_scroll_right_command): Update.
5249         (tui_scroll): Remove.
5250         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5251         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5252         from tui_vertical_source_scroll.
5253         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5254         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5255         from tui_vertical_disassem_scroll.
5256         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5257         do_scroll_horizontal>: New methods.
5258         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5259         Likewise.
5260         (struct tui_source_window_base): Add do_scroll_horizontal.
5261         (struct tui_source_window, struct tui_disasm_window): Add
5262         do_scroll_vertical.
5263         (struct tui_data_window, struct tui_cmd_window): Add
5264         do_scroll_horizontal and do_scroll_vertical.
5265         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5266
5267 2019-06-25  Tom Tromey  <tom@tromey.com>
5268
5269         * tui/tui-data.h (struct tui_source_window_base): New struct.
5270         (struct tui_source_window): Derive from tui_source_window_base.
5271         (struct tui_disasm_window): New struct.
5272         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5273         from tui_source_window::clear_detail.
5274         (tui_source_window_base): Rename from tui_source_window.
5275         (~tui_source_window_base): Rename from ~tui_source_window.
5276         (tui_alloc_win_info): Create a tui_disasm_window.
5277
5278 2019-06-25  Tom Tromey  <tom@tromey.com>
5279
5280         * tui/tui-data.h (struct tui_source_window)
5281         (struct tui_data_window): Declare destructors.
5282         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5283         destructors.
5284         (tui_win_info): Simplify.
5285
5286 2019-06-25  Tom Tromey  <tom@tromey.com>
5287
5288         * tui/tui-winsource.c (tui_display_main)
5289         (tui_update_source_windows_with_addr)
5290         (tui_update_all_breakpoint_info): Update.
5291         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5292         (new_height_ok, parse_scrolling_args): Update.
5293         * tui/tui-stack.c (tui_show_frame_info): Update.
5294         * tui/tui-data.h (struct tui_list): Remove.
5295         (tui_source_windows): Return a reference to a std::vector.
5296         * tui/tui-data.c (source_windows): Now a std::vector.
5297         (tui_source_windows): Change return type.
5298         (tui_clear_source_windows): Rewrite.
5299         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5300         (tui_free_all_source_wins_content): Rewrite.
5301
5302 2019-06-25  Tom Tromey  <tom@tromey.com>
5303
5304         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5305         (struct tui_data_window, struct tui_cmd_window): Declare
5306         clear_detail method.
5307         * tui/tui-data.c (tui_source_window::clear_detail)
5308         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5309         methods.
5310         (tui_clear_win_detail): Simplify.
5311
5312 2019-06-25  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-layout.c (make_source_window, make_disasm_window)
5315         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5316         Return the new window.
5317         (show_source_disasm_command, show_data)
5318         (show_source_or_disasm_and_command): Update.
5319
5320 2019-06-25  Tom Tromey  <tom@tromey.com>
5321
5322         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5323         parameter.  Return the new window.
5324         (show_source_disasm_command): Update and remove NULL check.
5325         (show_source_or_disasm_and_command): Update.
5326
5327 2019-06-25  Tom Tromey  <tom@tromey.com>
5328
5329         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5330
5331 2019-06-25  Tom Tromey  <tom@tromey.com>
5332
5333         * tui/tui-data.h (struct tui_win_info): Make constructor
5334         protected.  Make destructor virtual.  Add initializers.
5335         (tui_source_window, tui_data_window, tui_cmd_window): New
5336         classes.
5337         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5338         constructor.  Add "type" parameter.
5339         (tui_source_window, tui_data_window, tui_cmd_window): New
5340         constructors.
5341         (tui_alloc_win_info): Instantiate the appropriate subclass.
5342
5343 2019-06-25  Tom Tromey  <tom@tromey.com>
5344
5345         * tui/tui-win.c (tui_resize_all): Use delete.
5346         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5347         destructor.
5348         (tui_free_window): Don't declare.
5349         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5350         Update.
5351
5352 2019-06-25  Tom Tromey  <tom@tromey.com>
5353
5354         * tui/tui-data.h (struct tui_win_info): Add constructor.
5355         * tui/tui-data.c (tui_alloc_win_info): Use new.
5356         (tui_free_window): Use delete.
5357
5358 2019-06-22  Tom Tromey  <tom@tromey.com>
5359
5360         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5361         declare.
5362         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5363
5364 2019-06-22  Tom Tromey  <tom@tromey.com>
5365
5366         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5367         declare.
5368         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5369
5370 2019-06-22  Tom de Vries  <tdevries@suse.de>
5371
5372         * dwarf2read.c (create_addrmap_from_aranges)
5373         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5374         instead of '%zu'.
5375
5376 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5377
5378         * dwarf2read.h (dwarf2_section_info_def): Remove.
5379         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5380         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5381         std::vector<dwarf2_section_info>.
5382         (struct dwo_file) <~dwo_file>: Remove.
5383         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5384         types field.
5385         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5386         (dwarf2_read_debug_names): Likewise.
5387         (create_debug_types_hash_table): Change parameter type to
5388         array_view, adjust code accordingly.
5389         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5390         (partial_die_info::fixup): Likewise.
5391         (determine_prefix): Likewise.
5392         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5393
5394 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5395
5396         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5397         gdb_bfd_ref_ptr.
5398         <~dwo_file>: Remove call to gdb_bfd_unref.
5399         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5400         gdb_bfd_ref_ptr::get.
5401
5402 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5403
5404         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5405         type to htab_up.
5406         * dwarf2read.c (struct dwo_file): Initialize fields.
5407         <~dwo_file>: New.
5408         (free_dwo_file): Remove, move content to ~dwo_file.
5409         (struct dwo_file_deleter): Remove.
5410         (dwo_file_up>: Remove custom deleter.
5411         (free_dwo_files): Remove.
5412         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5413         dwo_files.
5414         (process_skeletonless_type_units): Call unique_ptr::get.
5415         (allocate_dwo_file_hash_table): Add deleter to created hash
5416         table.  Change return type to htab_up.
5417         (lookup_dwo_file_slot): Don't memset dwo_file, call
5418         unique_ptr::get.
5419         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5420         (create_dwo_unit_in_dwp_v2): Likewise.
5421         (open_and_init_dwo_file): Likewise.
5422         (free_dwo_file_from_slot): Remove.
5423
5424 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5425
5426         * dwarf2read.h (struct dwarf2_section_info) <readin,
5427         is_virtual>: Change type to bool.
5428         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5429         true instead of 1.
5430
5431 2019-06-19  Tom Tromey  <tom@tromey.com>
5432
5433         * tui/tui-data.h (tui_init_content_element): Don't declare.
5434
5435 2019-06-19  Tom Tromey  <tom@tromey.com>
5436
5437         * tui/tui-data.h (tui_init_win_info): Don't declare.
5438
5439 2019-06-19  Tom de Vries  <tdevries@suse.de>
5440
5441         * dwarf2read.h (abstract_to_concrete): Change type to
5442         std::unordered_map<sect_offset, std::vector<sect_offset>,
5443         gdb::hash_enum<sect_offset>>.
5444
5445 2019-06-19  Tom Tromey  <tromey@adacore.com>
5446
5447         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5448         EVAL_AVOID_SIDE_EFFECTS specially.
5449
5450 2019-06-19  Tom Tromey  <tromey@adacore.com>
5451
5452         * source-cache.c (highlighter): New global.
5453         (source_cache::get_source_lines): Create a highlighter on demand.
5454
5455 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5456
5457         * defs.h (deprecated_interactive_hook): Delete declaration.
5458         * interps.c (clear_interpreter_hooks): Remove use of
5459         deprecated_interactive_hook.
5460         * top.c (deprecated_interactive_hook): Delete definition.
5461         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5462
5463 2019-06-18  Tom de Vries  <tdevries@suse.de>
5464
5465         PR gdb/24515
5466         * dwarf2read.h (abstract_to_concrete): Change type from
5467         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5468         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5469         * dwarf2read.c (read_variable): Update.
5470         (dwarf2_fetch_die_loc_sect_off): Update.
5471
5472 2019-06-17  Tom de Vries  <tdevries@suse.de>
5473
5474         PR gdb/24617
5475         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5476         accessing parent[parent_len - 1].
5477
5478 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5479
5480         PR gdb/24364
5481         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5482         call dtrace_process_dof with NULL dof.
5483
5484 2019-06-16  Tom de Vries  <tdevries@suse.de>
5485
5486         PR gdb/24445
5487         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5488
5489 2019-06-16  Tom Tromey  <tom@tromey.com>
5490
5491         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5492         (make_all_visible): Use address of member.
5493
5494 2019-06-16  Tom Tromey  <tom@tromey.com>
5495
5496         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5497         (tui_free_window, free_content, free_content_elements): Remove
5498         unnecessary cast.
5499         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5500         cast.
5501         * tui/tui-regs.c (tui_show_register_group)
5502         (tui_display_registers_from, tui_display_reg_element_at_line):
5503         Remove unnecessary cast.
5504
5505 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * linux-nat.c (normal_mask): Delete.
5508         (_initialize_linux_nat): Don't initialise normal_mask.
5509
5510 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5511
5512         PR gdb/24445
5513         * dwarf-index-write.h (write_psymtabs_to_index): Add
5514         dwz_basename parameter.
5515         * dwarf-index-write.c (write_gdbindex): Move file writing to
5516         write_gdbindex_1.  Change return type void.
5517         (assert_file_size): Move up, remove filename parameter.
5518         (write_gdbindex_1): New function.
5519         (write_debug_names): Change return type to void, call
5520         assert_file_size.
5521         (struct index_wip_file): New struct.
5522         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5523         file logic to index_wip_file.  Write index for dwz file if
5524         needed.
5525         (save_gdb_index_command): Pass basename of dwz file, if present.
5526         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5527         build-id of dwz file, if present.
5528         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5529         (dwarf2_get_dwz_file): Likewise.
5530         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5531         (dwarf2_get_dwz_file): Likewise.
5532
5533 2019-06-16  Tom Tromey  <tom@tromey.com>
5534
5535         * coffread.c (process_coff_symbol): Use xstrdup.
5536         * value.c (create_internalvar): Use xstrdup.
5537
5538 2019-06-16  Tom Tromey  <tom@tromey.com>
5539
5540         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5541         * breakpoint.c (stopin_command, stopat_command)
5542         (until_break_command, decode_location_default): Remove unnecessary
5543         cast.
5544         * utils.c (subset_compare): Remove unnecessary cast.
5545         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5546         cast.
5547         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5548         cast.
5549         * infcmd.c (path_command): Remove unnecessary cast.
5550         * coffread.c (decode_type): Remove unnecessary cast.
5551         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5552         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5553         * tui/tui-stack.c (tui_show_locator_content)
5554         (tui_show_frame_info): Remove unnecessary cast.
5555         * tui/tui-win.c (tui_scroll_forward_command)
5556         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5557         (parse_scrolling_args): Remove unnecessary cast.
5558         * tui/tui-data.c (init_win_info, tui_del_window)
5559         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5560         (free_content_elements): Remove unnecessary cast.
5561         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5562         unnecessary cast.
5563         * tui/tui-source.c (tui_set_source_content)
5564         (tui_vertical_source_scroll): Remove unnecessary cast.
5565         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5566         cast.
5567         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5568         * tui/tui-regs.c (tui_display_registers_from)
5569         (tui_display_register): Remove unnecessary cast.
5570         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5571         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5572         (make_visible): Remove unnecessary cast.
5573         * tui/tui-winsource.c (tui_erase_source_content)
5574         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5575         unnecessary cast.
5576         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5577         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5578         * stabsread.c (read_type, read_array_type, read_range_type):
5579         Remove unnecessary cast.
5580         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5581         (parse_symbol, parse_type, upgrade_type, parse_external)
5582         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5583         unnecessary cast.
5584         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5585
5586 2019-06-16  Tom Tromey  <tom@tromey.com>
5587
5588         * tui/tui-data.c (tui_alloc_generic_win_info)
5589         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5590         checks.
5591
5592 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5593             Andrew Burgess  <andrew.burgess@embecosm.com>
5594
5595         * f-typeprint.c (f_print_type): Don't return early for not
5596         associated or not allocated types.
5597         (f_type_print_varspec_suffix): Add print_rank parameter and print
5598         ranks of array types in case they dangling.
5599         (f_type_print_base): Add print_rank parameter.
5600
5601 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5602
5603         * NEWS: Mention new MI commands.
5604         * break-catch-throw.c (enum exception_event_kind): Move to
5605         breakpoint.h.
5606         (print_mention_exception_catchpoint): Output text as a single
5607         message.
5608         (catch_exception_command_1): Rename to...
5609         (catch_exception_event): ...this, make non-static, update header
5610         command, and change some parameter types.
5611         (catch_catch_command): Update for changes to
5612         catch_exception_command_1.
5613         (catch_throw_command): Likewise.
5614         (catch_rethrow_command): Likewise.
5615         * breakpoint.c (enum exception_event_kind): Delete.
5616         * breakpoint.h (enum exception_event_kind): Moved here from
5617         break-catch-throw.c.
5618         (catch_exception_event): Declare.
5619         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5620         (mi_cmd_catch_throw): New function.
5621         (mi_cmd_catch_rethrow): New function.
5622         (mi_cmd_catch_catch): New function.
5623         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5624         'catch-catch' entries.
5625         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5626         (mi_cmd_catch_rethrow): Declare.
5627         (mi_cmd_catch_catch): Declare.
5628
5629 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5630
5631         * annotate.c (annotate_source_line): Change return type to void,
5632         update implementation to match.
5633         * annotate.h (annotate_source_line): Change return type to void,
5634         update header comment.
5635         * stack.c (print_frame_info): Don't change what frame information
5636         is printed based on whether annotations are on or not.
5637
5638 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5639
5640         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5641         (annotate_source): Make static.
5642         (annotate_source_line): Moved from source.c and renamed from
5643         identify_source_line.  Update the return type.
5644         * annotate.h (annotate_source): Delete declaration.
5645         (annotate_source_line): Declaration moved from source.h, and
5646         renamed from identify_source_line.  Return type updated.
5647         * source.c (identify_source_line): Moved to annotate.c and renamed
5648         to annotate_source_line.
5649         (info_line_command): Remove check of annotation_level.
5650         * source.h (identify_source_line): Move declaration to annotate.h
5651         and rename to annotate_source_line.
5652         * stack.c: Add 'annotate.h' include.
5653         (print_frame_info): Remove check of annotation_level before
5654         calling annotate_source_line.
5655
5656 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5657
5658         * source-cache.c (source_cache::get_plain_source_lines): Use
5659         open_source_file_with_line_charpos instead of just
5660         open_source_file, remove call to find_source_lines.
5661         (source_cache::get_source_lines): Likewise.
5662         * source.c (find_source_lines): Make static.
5663         (get_filename_and_charpos): Renamed into...
5664         (open_source_file_with_line_charpos): ..this along with changes to
5665         return a scoped_fd, and some other minor clean ups.
5666         (identify_source_line): Use open_source_file_with_line_charpos.
5667         (search_command_helper): Use open_source_file_with_line_charpos
5668         instead of just open_source_file, remove call to
5669         find_source_lines.
5670         * source.h (open_source_file_with_line_charpos): Declare new
5671         function.
5672         (find_source_lines): Delete declaration.
5673
5674 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5675
5676         * source.c (get_filename_and_charpos): Remove fullname
5677         parameter.
5678         (identify_source_line): Update call to get_filename_and_charpos.
5679
5680 2019-06-14  Tom Tromey  <tromey@adacore.com>
5681
5682         PR gdb/24502:
5683         * ui-style.h (skip_ansi_escape): Update comment.
5684         * ui-file.h (class no_terminal_escape_file): New class.
5685         * ui-file.c (no_terminal_escape_file::write)
5686         (no_terminal_escape_file::puts): New methods.
5687         * cli/cli-logging.c (handle_redirections): Use
5688         no_terminal_escape_file.
5689
5690 2019-06-14  Tom Tromey  <tromey@adacore.com>
5691
5692         * NEWS: Move convenience variable news above Python news.
5693
5694 2019-06-14  Tom Tromey  <tom@tromey.com>
5695
5696         * gnulib: Move directory to top-level.
5697         * configure.ac: Don't configure gnulib.
5698         * configure: Rebuild.
5699         * common/common-defs.h: Use new path to gnulib.
5700         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5701         (GNULIB_H): Remove.
5702         (INCGNU): Look in new gnulib location.
5703         (HFILES_NO_SRCDIR): Remove gnulib files.
5704         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5705         (generated_files): Remove GNULIB_H.
5706         ($(LIBGNU), all-lib): Remove targets.
5707         (distclean): Don't mention GNULIB_BUILDDIR.
5708         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5709
5710 2019-06-14  Tom Tromey  <tromey@adacore.com>
5711
5712         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5713         Warn if symbol file does not provide any symbols.
5714
5715 2019-06-14  Tom Tromey  <tromey@adacore.com>
5716
5717         * source.c (find_and_open_source): Respect basenames_may_differ.
5718
5719 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5720
5721         * annotate.c (annotate_breakpoints_invalid): Make use of
5722         scoped_restore_terminal_state.
5723         (annotate_frames_invalid): Likewise.
5724
5725 2019-06-14  Tom Tromey  <tromey@adacore.com>
5726
5727         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5728         allow assignment to an internalvar.
5729
5730 2019-06-14  Tom Tromey  <tromey@adacore.com>
5731
5732         * ada-lex.l: Allow "_" in attribute names.
5733
5734 2019-06-14  Tom Tromey  <tromey@adacore.com>
5735
5736         PR gdb/24653:
5737         * regcache.c (registers_changed): Don't call alloca.
5738         * top.c (execute_command): Don't call alloca.
5739
5740 2019-06-13  Pedro Alves  <palves@redhat.com>
5741
5742         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5743         'expression'.  When parsing an expression, error out if there's
5744         junk after "unlimited".
5745         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5746         (do_set_command): Adjust calls to is_unlimited_literal.
5747
5748 2019-06-13  Pedro Alves  <palves@redhat.com>
5749
5750         * compile/compile.c (make_compile_options_def_group): Add braces
5751         around array_view initializer.
5752         * thread.c (make_thread_apply_all_options_def_group)
5753         (make_thread_apply_all_options_def_group): Likewise.
5754
5755 2019-06-13  Pedro Alves  <palves@redhat.com>
5756
5757         * NEWS (New commands): Mention "maint test-options
5758         require-delimiter", "maint test-options unknown-is-error", "maint
5759         test-options unknown-is-operand" and "maint show
5760         test-options-completion-result".
5761         (New command options, command completion): New section.
5762         (Completion improvements): New section.
5763         Mention that you can abbreviate "unlimited".
5764
5765 2019-06-13  Pedro Alves  <palves@redhat.com>
5766
5767         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5768         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5769         * unittests/cli-utils-selftests.c (test_parse_flags)
5770         (test_parse_flags_qcs): Delete.
5771         (test_cli_utils): Don't call deleted functions.
5772
5773 2019-06-13  Pedro Alves  <palves@redhat.com>
5774
5775         * thread.c: Include "cli/cli-option.h".
5776         (tp_array_compar_ascending): Global.
5777         (tp_array_compar): Delete function.
5778         (tp_array_compar_ascending, tp_array_compar_descending): New
5779         functions.
5780         (ascending_option_def, qcs_flag_option_def)
5781         (thr_qcs_flags_option_defs)
5782         (make_thread_apply_all_options_def_group)
5783         (make_thread_apply_options_def_group): New.
5784         (thread_apply_all_command): Use gdb::option::process_options.
5785         (thread_apply_command_completer)
5786         (thread_apply_all_command_completer): New.
5787         (thread_apply_command): Use gdb::option::process_options.
5788         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5789         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5790         to generate help text of "thread apply".  Adjust "taas"'s help.
5791         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5792         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5793
5794 2019-06-13  Pedro Alves  <palves@redhat.com>
5795
5796         * thread.c (thread_apply_command): Check for invalid TID with
5797         isdigit instead of !isalpha.
5798
5799 2019-06-13  Pedro Alves  <palves@redhat.com>
5800
5801         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5802         (validate_flags_qcs): New.
5803         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5804         (validate_flags_qcs): Declare.
5805         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5806         (make_frame_apply_options_def_group): New.
5807         (frame_apply_command_count): Process options with
5808         gdb::option::process_options.
5809         (frame_apply_completer): New.
5810         (frame_apply_level_completer, frame_apply_all_completer)
5811         (frame_apply_completer): New.
5812         (_initialize_stack): Update help of "frame apply", "frame apply
5813         level", "frame apply all" and "faas" to mention supported options
5814         and install command completers.
5815         * stack.h (frame_apply_all_completer): Declare.
5816         * thread.c: Include "stack.h".
5817         (tfaas_command): Add "--".
5818         (_initialize_thread): Update help "tfaas" to mention supported
5819         options and install command completer.
5820
5821 2019-06-13  Pedro Alves  <palves@redhat.com>
5822
5823         * completer.c (complete_nested_command_line): New.
5824         (gdb_completion_word_break_characters_throw): Add assertion.
5825         * completer.h (complete_nested_command_line): Declare.
5826
5827 2019-06-13  Pedro Alves  <palves@redhat.com>
5828
5829         * stack.c (parse_backtrace_qualifiers): New.
5830         (backtrace_command): Use it.
5831         (backtrace_command_completer): Complete on qualifiers.
5832
5833 2019-06-13  Pedro Alves  <palves@redhat.com>
5834
5835         * frame.c: Include "cli/cli-option.h.
5836         (user_set_backtrace_options): New.
5837         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5838         Delete.
5839         (get_prev_frame): Adjust.
5840         (boolean_option_def, uinteger_option_def)
5841         (set_backtrace_option_defs): New.
5842         (_initialize_frame): Adjust and use
5843         gdb::option::add_setshow_cmds_for_options to install "set
5844         backtrace past-main" and "set backtrace past-entry".
5845         * frame.h: Include "cli/cli-option.h".
5846         (struct frame_print_options): Forward declare.
5847         (print_frame_arguments_all, print_frame_arguments_scalars)
5848         (print_frame_arguments_none): Declare.
5849         (print_entry_values): Delete declaration.
5850         (struct frame_print_options, user_frame_print_options): New.
5851         (struct set_backtrace_options): New.
5852         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5853         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5854         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5855         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5856         (list_args_or_locals): Add frame_print_options parameter.
5857         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5858         * python/py-framefilter.c (enumerate_args): Pass down
5859         USER_FRAME_PRINT_OPTIONS.
5860         * stack.c: Include "cli/cli-option.h".
5861         (print_frame_arguments_all, print_frame_arguments_scalars)
5862         (print_frame_arguments_none): Declare.
5863         (print_raw_frame_arguments, print_entry_values): Delete.
5864         (user_frame_print_options): New.
5865         (boolean_option_def, enum_option_def, frame_print_option_defs):
5866         New.
5867         (struct backtrace_cmd_options): New.
5868         (bt_flag_option_def): New.
5869         (backtrace_command_option_defs): New.
5870         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5871         (print_frame_arg, read_frame_arg, print_frame_args)
5872         (print_frame_info, print_frame): Add frame_print_options parameter
5873         and use it.
5874         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
5875         (backtrace_command_1): Add frame_print_options and
5876         backtrace_cmd_options parameters and use them.
5877         (make_backtrace_options_def_group): New.
5878         (backtrace_command): Process command options with
5879         gdb::option::process_options.
5880         (backtrace_command_completer): New.
5881         (_initialize_stack): Extend "backtrace"'s help to mention
5882         supported options.  Install completer for "backtrace".
5883         Install some settings commands with add_setshow_cmds_for_options.
5884
5885 2019-06-13  Pedro Alves  <palves@redhat.com>
5886
5887         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
5888         and that "set/show print raw frame-arguments" are now deprecated.
5889
5890         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
5891         command.
5892         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
5893         * stack.c (_initialize_stack): Install "set/show print
5894         raw-frame-arguments", and deprecate "set/show print raw
5895         frame-arguments".
5896         * valprint.c (_initialize_valprint): Deprecate "set/show print
5897         raw".
5898
5899 2019-06-13  Pedro Alves  <palves@redhat.com>
5900
5901         * compile/compile.c (struct compile_options): New.
5902         (compile_flag_option_def, compile_command_option_defs)
5903         (make_compile_options_def_group): New.
5904         (compile_file_command): Handle options with
5905         gdb::option::process_options.
5906         (compile_file_command_completer): New function.
5907         (compile_code_command): Handle options with
5908         gdb::option::process_options.
5909         (compile_code_command_completer): New function.
5910         (_initialize_compiler): Install completers for "compile code" and
5911         "compile file".  Mention available options in "compile code" and
5912         "compile code"'s help.
5913         * completer.c (advance_to_completion_word): New, factored out from
5914         ...
5915         (advance_to_expression_complete_word_point): ... this.
5916         (advance_to_filename_complete_word_point): New.
5917         * completer.h (advance_to_filename_complete_word_point): New
5918         declaration.
5919
5920 2019-06-13  Pedro Alves  <palves@redhat.com>
5921
5922         * compile/compile.c: Include "cli/cli-option.h".
5923         (compile_print_value): Scope data pointer is now a
5924         value_print_options pointer; adjust.
5925         (compile_print_command): Process options.  Scope data pointer is
5926         now a value_print_options pointer; adjust.
5927         (_initialize_compile): Update "compile print"'s help to include
5928         supported options.  Install a completer for "compile print".
5929         * cp-valprint.c (show_vtblprint, show_objectprint)
5930         (show_static_field_print): Delete.
5931         (_initialize_cp_valprint): Don't install "set print
5932         static-members", "set print vtbl", "set print object" here.
5933         * printcmd.c: Include "cli/cli-option.h" and
5934         "common/gdb_optional.h".
5935         (print_command_parse_format): Rework to fill in a
5936         value_print_options instead of a format_data.
5937         (print_value): Change parameter type from format_data pointer to
5938         value_print_options reference.  Adjust.
5939         (print_command_1): Process options.  Adjust to pass down a
5940         value_print_options.
5941         (print_command_completer): New.
5942         (_initialize_printcmd): Install print_command_completer as
5943         handle_brkchars completer for the "print" command.  Update
5944         "print"'s help to include supported options.
5945         * valprint.c: Include "cli/cli-option.h".
5946         (show_vtblprint, show_objectprint, show_static_field_print): Moved
5947         here from cp-valprint.c.
5948         (boolean_option_def, uinteger_option_def)
5949         (value_print_option_defs, make_value_print_options_def_group):
5950         New.  Use gdb::option::add_setshow_cmds_for_options to install
5951         "set print elements", "set print null-stop", "set print repeats",
5952         "set print pretty", "set print union", "set print array", "set
5953         print address", "set print symbol", "set print array-indexes".
5954         * valprint.h: Include <string> and "cli/cli-option.h".
5955         (make_value_print_options_def_group): Declare.
5956         (print_value): Change parameter type from format_data pointer to
5957         value_print_options reference.
5958         (print_command_completer): Declare.
5959
5960 2019-06-13  Pedro Alves  <palves@redhat.com>
5961
5962         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
5963         (COMMON_SFILES): Add maint-test-settings.c.
5964         * cli/cli-decode.c (boolean_enums): New global, factored out from
5965         ...
5966         (add_setshow_boolean_cmd): ... here.
5967         * cli/cli-decode.h (boolean_enums): Declare.
5968         * cli/cli-option.c: New file.
5969         * cli/cli-option.h: New file.
5970         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
5971         factored out from ...
5972         (parse_cli_boolean_value(const char *)): ... this.
5973         (is_unlimited_literal): Change parameter type to pointer to
5974         pointer.  Adjust and advance ARG pointer.
5975         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5976         (parse_cli_var_enum): New, factored out from ...
5977         (do_set_command): ... this.  Adjust.
5978         * cli/cli-setshow.h (parse_cli_boolean_value)
5979         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5980         (parse_cli_var_enum): Declare.
5981         * cli/cli-utils.c: Include "cli/cli-option.h".
5982         (get_ulongest): New.
5983         * cli/cli-utils.h (get_ulongest): Declare.
5984         (check_for_argument): New overloads.
5985         * maint-test-options.c: New file.
5986
5987 2019-06-13  Pedro Alves  <palves@redhat.com>
5988
5989         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
5990         parse a range if "-" is at the end of the string.
5991
5992 2019-06-13  Pedro Alves  <palves@redhat.com>
5993
5994         * cli/cli-setshow.c (parse_auto_binary_operation)
5995         (parse_cli_boolean_value): Don't allow "o".
5996
5997 2019-06-13  Pedro Alves  <palves@redhat.com>
5998
5999         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6000         * NEWS: Mention maint test-settings KIND.
6001         * maint-test-settings.c: New file.
6002
6003 2019-06-13  Pedro Alves  <palves@redhat.com>
6004
6005         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6006         completer.
6007         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6008         "set" completers.
6009
6010 2019-06-13  Pedro Alves  <palves@redhat.com>
6011
6012         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6013         after item.
6014
6015 2019-06-13  Pedro Alves  <palves@redhat.com>
6016
6017         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6018
6019 2019-06-13  Pedro Alves <palves@redhat.com>
6020
6021         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6022         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6023         call.
6024         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6025         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6026         calls.
6027         (check_for_argument): Skip spaces after argument.
6028
6029 2019-06-13  Pedro Alves  <palves@redhat.com>
6030
6031         * thread.c (thread_apply_command): Adjust TID parsing.
6032         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6033         detected before end of string.
6034         (tid_is_in_list): Error out if LIST is invalid.
6035
6036 2019-06-13  Pedro Alves  <palves@redhat.com>
6037
6038         * completer.c (complete_line_internal_1): Rewind completion word
6039         point.
6040         (completion_tracker::advance_custom_word_point_by): Change
6041         parameter type to int.
6042         * completer.h (completion_tracker::advance_custom_word_point_by):
6043         Likewise.
6044
6045 2019-06-13  Pedro Alves  <palves@redhat.com>
6046
6047         * completer.c (advance_to_completion_word): Handle delimiters.
6048
6049 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6050
6051         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6052
6053 2019-06-11  Tom Tromey  <tom@tromey.com>
6054
6055         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6056         (xmalloc_failed): Move to alloc.c.
6057         * alloc.c: New file.
6058         * Makefile.in (COMMON_SFILES): Add alloc.c.
6059
6060 2019-06-11  Tom Tromey  <tom@tromey.com>
6061
6062         * nat/linux-waitpid.c: Don't include server.h.
6063         (linux_debug): Remove.
6064         (my_waitpid): Update.
6065
6066 2019-06-11  Tom Tromey  <tromey@adacore.com>
6067
6068         * infcall.c (_initialize_infcall): Remove trailing newline from
6069         help.
6070         * user-regs.c (_initialize_user_regs): Remove trailing newline
6071         from help.
6072         * typeprint.c (_initialize_typeprint): Remove trailing newline
6073         from help.
6074         * reverse.c (_initialize_reverse): Remove trailing newlines from
6075         help.
6076         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6077         from help.
6078         * language.c (add_set_language_command): Remove trailing newline
6079         from help.
6080         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6081         help.
6082         * disasm.c (_initialize_disasm): Remove trailing newline from
6083         help.
6084         * top.c (init_main): Remove trailing newline from help.
6085         * interps.c (_initialize_interpreter): Remove trailing newline
6086         from help.
6087         * btrace.c (_initialize_btrace): Remove trailing newlines from
6088         help.
6089         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6090         from help.
6091         * python/python.c (_initialize_python): Remove trailing newline
6092         from help.
6093         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6094         help.
6095         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6096         from help.  Reformat some text.
6097         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6098         from help.
6099         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6100         newline from help.
6101
6102 2019-06-11  Tom Tromey  <tromey@adacore.com>
6103
6104         * darwin-nat.c (darwin_decode_exception_message)
6105         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6106
6107 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6108
6109         * valops.c (value_slice): Check for not allocated or not
6110         associated values.
6111
6112 2019-06-10  Tom de Vries  <tdevries@suse.de>
6113
6114         PR gdb/24618
6115         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6116         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6117         invalid.
6118
6119 2019-06-10  Tom de Vries  <tdevries@suse.de>
6120
6121         PR gdb/24611
6122         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6123         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6124
6125 2019-06-10  Tom de Vries  <tdevries@suse.de>
6126
6127         PR symtab/24545
6128         * symtab.c (struct demangled_name_entry): Add language field.
6129         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6130         static minimal symbol".  Set and use language field.
6131
6132 2019-06-10  Tom Tromey  <tromey@adacore.com>
6133
6134         * ada-lang.c (_initialize_ada_language): Update help text.
6135
6136 2019-06-10  Tom Tromey  <tromey@adacore.com>
6137
6138         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6139         with a newline.
6140         * guile/guile.c (handle_boot_error): Don't end warning with a
6141         newline.
6142         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6143         warning with a newline.
6144         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6145         newline.
6146         (s12z_frame_cache): Likewise.
6147         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6148         a newline.
6149         * solib-svr4.c (disable_probes_interface): Don't end warning with
6150         a newline.
6151         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6152         newline.
6153         * python/python.c (do_finish_initialization): Don't end warning
6154         with a newline.
6155
6156 2019-06-10  Tom Tromey  <tom@tromey.com>
6157
6158         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6159         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6160         gdbpy_enter.
6161
6162 2019-06-10  Tom Tromey  <tromey@adacore.com>
6163
6164         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6165         data.
6166         (elf_new_init): Don't call stabsread_new_init.
6167         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6168         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6169         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6170
6171 2019-06-10  Tom de Vries  <tdevries@suse.de>
6172
6173         PR symtab/16264
6174         PR symtab/24517
6175         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6176
6177 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6178
6179         * source.c (find_and_open_source): Also rewrite relative file
6180         names.
6181
6182 2019-04-26  Amos Bird  <amosbird@gmail.com>
6183
6184         * annotate.c (annotate_thread_exited): Add "thread-exited"
6185         annotation.
6186
6187 2019-06-06  Tom Tromey  <tromey@adacore.com>
6188
6189         * maint.h (class scoped_command_stats): Use
6190         DISABLE_COPY_AND_ASSIGN.
6191         <print_time>: New method.
6192         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6193         print_time.
6194         (scoped_command_stats::print_time): New method.
6195
6196 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6197
6198         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6199         instructions of lengths 6 or 8 bytes.
6200
6201 2019-06-04  Pedro Alves  <palves@redhat.com>
6202
6203         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6204
6205         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6206         * breakpoint.c (condition_completer): Likewise.
6207         * cli/cli-dump.c (scan_expression): Likewise.
6208         * common/filestuff.c (mkdir_recursive): Likewise.
6209         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6210         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6211         (gdb_abspath): Likewise.
6212         * compile/compile-cplus-types.c
6213         (compile_cplus_instance::decl_name): Likewise.
6214         * completer.c (complete_explicit_location):
6215         (signal_completer, reg_or_group_completer_1): Likewise.
6216         * cp-support.c (cp_remove_params_if_any): Likewise.
6217         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6218         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6219         * infcmd.c (strip_bg_char): Likewise.
6220         * linespec.c (copy_token_string): Likewise.
6221         * mi/mi-main.c (output_cores): Likewise.
6222         * psymtab.c (psymtab_search_name):
6223         * symfile.c (test_set_ext_lang_command): Likewise.
6224         * target.c (target_fileio_read_stralloc): Likewise.
6225         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6226         * value.c (complete_internalvar): Likewise.
6227
6228 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6229
6230         Add objfile property to gdb.Type.
6231         * NEWS: Mention Python API addition.
6232         * python/py-type.c (typy_get_objfile): New method.
6233
6234 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6235
6236         * NEWS: Mention the new set|show style [title|highlight].
6237         Mention changes to "show style", "help" and "apropos".
6238
6239 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6240
6241         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6242         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6243         instead of print_help_for_command.
6244         (print_doc_of_command): New function.
6245         (help_list): Add 'apropos -v word' suggestion.
6246         (print_help_for_command): Style the command name using title style.
6247         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6248         (_initialize_cli_cmds): Describe -v in apropos_command help.
6249
6250 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6251
6252         * cli/cli-style.h (cli_style_option): Add name in constructor,
6253         add m_name class member, add constructor with intensity,
6254         add name class function.
6255         (cli_style_option::add_setshow_commands): Remove name argument.
6256         (highlight_style, title_style): New styles.
6257         * cli/cli-style.c (do_show): New function that shows a style
6258         characteristic styling the style name with itself.
6259         (set_style_name): New function.
6260         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6261         Update all callers according to the changes in cli/cli-style.h.
6262         * utils.h (fputs_highlighted): New function.
6263         * utils.c (fputs_highlighted): Likewise.
6264
6265 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6266
6267         * NEWS: Mention new pipe command and new convenience variables.
6268
6269 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6270
6271         * cli/cli-cmds.c (pipe_command): New function.
6272         (_initialize_cli_cmds): Call add_com for pipe_command.
6273         Define | as an alias for pipe.
6274         (exit_status_set_internal_vars): New function.
6275         (shell_escape): Call exit_status_set_internal_vars.
6276         cli/cli-decode.c (find_command_name_length): Recognize | as
6277         a single character command.
6278
6279 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6280
6281         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6282         top.c (execute_command_to_ui_file): New function, mostly a copy
6283         of execute_command_to_string.
6284         (execute_command_to_string): Implement by calling
6285         execute_command_to_ui_file.
6286
6287 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6288
6289         * top.h (saved_command_line): Remove declaration.
6290         * top.c (previous_saved_command_line, previous_repeat_arguments):
6291         New variables.
6292         (saved_command_line): Make static, define together with other
6293         'repeat variables'.
6294         (dont_repeat): Clear repeat_arguments.
6295         (repeat_previous, get_saved_command_line, save_command_line):
6296         New functions.
6297         (gdb_init): Initialize saved_command_line
6298         and previous_saved_command_line.
6299         * main.c (captured_main_1): Remove saved_command_line initialization.
6300         * event-top.c (handle_line_of_input): Update to use
6301         the new 'repeat' related functions instead of direct access to
6302         saved_command_line.
6303         * command.h (repeat_previous, get_saved_command_line,
6304         save_command_line): New declarations.
6305         (dont_repeat): Add comment.
6306
6307 2019-05-30  Tom Tromey  <tromey@adacore.com>
6308
6309         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6310         Fix comment.
6311         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6312
6313 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6314
6315         PR cli/24587
6316         * completer.c (complete): Initialize variable word.
6317
6318 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6319
6320         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6321         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6322         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6323         'body' is NULL to the outter 'if', protecting the '!is_define'
6324         situation as well.
6325
6326 2019-05-29  Tom Tromey  <tromey@adacore.com>
6327
6328         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6329         (dwarf_unknown): New function.
6330         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6331         (dwarf_type_encoding_name): Use dwarf_unknown.
6332
6333 2019-05-29  Tom Tromey  <tromey@adacore.com>
6334
6335         PR c++/20020:
6336         * cp-valprint.c (cp_print_value_fields): Call
6337         cp_print_static_field inside "try".
6338
6339 2019-05-29  Tom Tromey  <tromey@adacore.com>
6340
6341         * inflow.c (struct terminal_info): Add default operator=.
6342         * configure: Rebuild.
6343         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6344         -Wdeprecated-copy-dtor, -Wredundant-move.
6345
6346 2019-05-29  Tom Tromey  <tromey@adacore.com>
6347
6348         * NEWS: Add entry.
6349         * infcmd.c (print_return_value_1): Handle finish_print
6350         option.
6351         (show_print_finish): New function.
6352         (_initialize_infcmd): Add "set/show print finish" commands.
6353         * valprint.c (user_print_options): Initialize new member.
6354         * valprint.h (struct value_print_options) <finish_print>: New
6355         member.
6356
6357 2019-05-28  Tom Tromey  <tromey@adacore.com>
6358
6359         * ada-lang.c (ada_remove_Xbn_suffix)
6360         (find_old_style_renaming_symbol)
6361         (parse_old_style_renaming): Remove.
6362         (ada_find_renaming_symbol): Don't call
6363         find_old_style_renaming_symbol.
6364         (ada_is_renaming_symbol): Rename from
6365         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6366         bool.  Now static.
6367         (ada_read_var_value): Update and simplify.
6368         * ada-exp.y (write_var_or_type): Remove old code.
6369
6370 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6371
6372         * event-top.c: Remove include comment.
6373         * inflow.c (class scoped_ignore_sigttou): Move from here...
6374         * inflow.h (class scoped_ignore_sigttou): ...to here.
6375         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6376         * top.c:  Remove include comment.
6377
6378 2019-05-27  Tom Tromey  <tom@tromey.com>
6379
6380         * NEWS: Fix typo.
6381
6382 2019-05-22  Tom Tromey  <tromey@adacore.com>
6383
6384         * target.c (target_follow_exec): Constify parameter.
6385         * target-delegates.c: Rebuild.
6386         * remote.c (remote_target::follow_exec): Constify parameter.
6387         * infrun.c (follow_exec): Constify parameter.
6388         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6389         (target_follow_exec): Likewise.
6390
6391 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6392
6393         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6394         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6395
6396 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6397
6398         * NEWS: Add debugredirect and testsuite sections.
6399
6400 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6401
6402         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6403         target descriptions using exclusively floating point register name
6404         aliases.
6405
6406 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6407
6408         PR gdb/18644:
6409         * f-lang.c (build_fortran_types): Handle the case where
6410         gdbarch_floatformat_for_type returns a nullptr.
6411
6412 2019-05-21  Tom de Vries  <tdevries@suse.de>
6413
6414         PR cli/24587
6415         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6416
6417 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6418
6419         PR gdb/18644:
6420         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6421         16-byte floats.
6422         * i386-tdep.c (i386_floatformat_for_type): Use
6423         floatformats_ia64_quad for the 16-byte floating point component
6424         within a fortran 32-byte complex number.
6425
6426 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6427
6428         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6429         delete default constructor.
6430         (find_partial_die): Update to return const struct.
6431         (partial_die_parent_scope): Move variable declaration into scope
6432         of its use and change its type to auto.
6433         (guess_partial_die_structure_name): Likewise.
6434         (partial_die_info::fixup): Likewise.
6435
6436 2019-05-17  Tom Tromey  <tromey@adacore.com>
6437
6438         * source.c (find_and_open_source): Remove cast.
6439
6440 2019-05-17  Tom Tromey  <tromey@adacore.com>
6441
6442         * annotate.c (annotate_source): Make "filename" const.
6443         * annotate.h (annotate_source): Use const.
6444
6445 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6446
6447         * disasm.c (set_disassembler_options): Send errors to stderr.
6448
6449 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6450
6451         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6452         (cli_interp_base::set_logging): Check debug_redirect.
6453         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6454         * cli/cli-logging.c (debug_redirect): Add static variable.
6455         (pop_output_files): Add default param.
6456         (handle_redirections): Print debug setting.
6457         (show_logging_command): Likewise.
6458         (_initialize_cli_logging): Add debugredirect command.
6459         * interps.c (current_interp_set_logging): Add debug_redirect
6460         parameter.
6461         * interps.h (set_logging): Add debug_redirect parameter.
6462         (current_interp_set_logging): Likewise.
6463         * mi/mi-common.h: Likewise.
6464         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6465
6466 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6467             Tom Tromey  <tromey@adacore.com>
6468
6469         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6470         directly.
6471         * cli/cli-interp.h (make_logging_output): Remove declaration.
6472         * cli/cli-logging.c (make_logging_output): Remove function.
6473         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6474         directly.
6475         * ui-file.c (tee_file::tee_file): Remove bools.
6476         (tee_file::~tee_file): Remove deletes.
6477         * ui-file.h (tee_file): Remove bools.
6478
6479 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6480
6481         * mi/mi-cmds.h (mi_cmd_complete): New function.
6482         * mi/mi-main.c (mi_cmd_complete): Likewise.
6483         * mi/mi-cmds.c: Define new MI command -complete.
6484         * NEWS: Mention new -complete command.
6485
6486 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6487
6488         * completer.h (complete): New function.
6489         * completer.c (complete): Likewise.
6490         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6491         function defined in completer.h.
6492
6493 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6494
6495         * MAINTAINERS (Write After Approval): Add myself.
6496
6497 2019-05-17  Tom de Vries  <tdevries@suse.de>
6498
6499         PR gdb/24094
6500         * dwarf2read.c (struct cu_partial_die_info): New struct.
6501         (find_partial_die): Return cu_partial_die_info.
6502         (partial_die_parent_scope, guess_partial_die_structure_name)
6503         (partial_die_info::fixup): Handle new return type of find_partial_die.
6504
6505 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6506
6507         PR breakpoints/24541
6508         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6509         "std::string", simplifying the algorithm.
6510
6511 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6512
6513         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6514         (stap_static_probe_ops::get_probes): Likewise.
6515
6516 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6517
6518         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6519         '-')" and "else if".
6520         (stap_parse_single_operand): Join checks for
6521         "gdbarch_stap_parse_special_token_p" and
6522         "gdbarch_stap_parse_special_token" in the same "if" statement.
6523         Invert check when verifying for operation on register
6524         displacement.
6525
6526 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6527
6528         * stap-probe.c (stap_get_opcode): Update comment.
6529         (stap_get_expected_argument_type): Likewise.
6530         (handle_stap_probe): Likewise.
6531
6532 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6533
6534         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6535         return type to 'bool'.  Adjust comment.  Use 'bool' when
6536         appropriate.
6537         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6538         * stap-probe.c (stap_parse_argument_1): Likewise.
6539         (stap_is_operator): Likewise.
6540         (stap_is_generic_prefix): Likewise.
6541         (stap_is_register_prefix): Likewise.
6542         (stap_is_register_indirection_prefix): Likewise.
6543         (stap_is_integer_prefix): Likewise.
6544         (stap_generic_check_suffix): Likewise.
6545         (stap_check_integer_suffix): Likewise.
6546         (stap_check_register_suffix): Likewise.
6547         (stap_check_register_indirection_suffix): Likewise.
6548         (stap_parse_register_operand): Likewise.
6549         (stap_parse_single_operand): Likewise.
6550         (stap_parse_argument_1): Likewise.
6551         (stap_probe::get_argument_count): Likewise.
6552         (stap_is_operator): Likewise.
6553
6554 2019-05-16  Tom Tromey  <tromey@adacore.com>
6555
6556         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6557         keyword to foreach.
6558
6559 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6560
6561         * linux-thread-db.c (try_thread_db_load_1): Change return type
6562         to bool.
6563         (try_thread_db_load): Likewise.
6564         (try_thread_db_load_from_pdir_1): Likewise.
6565         (try_thread_db_load_from_pdir): Likewise.
6566         (try_thread_db_load_from_sdir): Likewise.
6567         (try_thread_db_load_from_dir): Likewise.
6568         (thread_db_load_search): Likewise.
6569         (has_libpthread): Likewise.
6570         (thread_db_load): Likewise.
6571
6572 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6573
6574         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6575         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6576         NULL, and complain/return if that's the case.
6577
6578 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6579
6580         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6581         (advance, posn, abstract_read_memory): New functions.
6582         [struct mem_read_abstraction]: New struct.
6583         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6584
6585 2019-05-14  Tom Tromey  <tromey@adacore.com>
6586
6587         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6588         value is not lval_memory.
6589
6590 2019-05-14  Tom Tromey  <tromey@adacore.com>
6591
6592         * solib.c (info_sharedlibrary_command): Style the file name.
6593
6594 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6595
6596         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6597         (aarch64_vnv_type): Likewise.
6598         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6599         * common/tdesc.c: Likewise.
6600         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6601         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6602         * features/aarch64-fpu.xml: Add ieee half view.
6603         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6604         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6605         * gdbtypes.h (struct builtin_type): Likewise.
6606         (struct objfile_type): Likewise.
6607
6608 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6609
6610         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6611         typo.
6612         * location.h (string_to_event_location): Likewise.
6613
6614 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6615
6616         GDB 8.3 released.
6617
6618 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6619
6620         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6621         New variable declaration.
6622         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6623         New variable.
6624         (print_one_breakpoint): Use ui_out::test_flags and new global
6625         variable to compute use_fixed_output.
6626         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6627         Remove.
6628         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6629         (mi_multi_location_breakpoint_output_fixed): Remove.
6630         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6631         new variable.
6632         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6633         fix_multi_location_breakpoint_output flag if version >= 3.
6634         * ui-out.h (enum ui_out_flag)
6635         <fix_multi_location_breakpoint_output>: New enumerator.
6636
6637 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6638
6639         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6640
6641 2019-05-10  Tom Tromey  <tromey@adacore.com>
6642
6643         * ada-lang.c (catch_ada_completer): New function.
6644         (_initialize_ada_language): Use it.
6645
6646 2019-05-10  Tom Tromey  <tromey@adacore.com>
6647
6648         * thread.c (print_thread_info): Make "requested_threads" const.
6649         * gdbthread.h (print_thread_info): Make "requested_threads"
6650         const.
6651         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6652         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6653
6654 2019-05-08  Tom Tromey  <tom@tromey.com>
6655
6656         * gdbtypes.c (objfile_type_data): Change type.
6657         (objfile_type, _initialize_gdbtypes): Update.
6658
6659 2019-05-08  Tom Tromey  <tom@tromey.com>
6660
6661         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6662         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6663         (_initialize_dwarf2_frame): Update.
6664
6665 2019-05-08  Tom Tromey  <tom@tromey.com>
6666
6667         * objc-lang.c (objc_objfile_data): Change type.
6668         (find_methods): Update.
6669         (_initialize_objc_lang): Remove.
6670
6671 2019-05-08  Tom Tromey  <tom@tromey.com>
6672
6673         * stabsread.c (rs6000_builtin_type_data): Change type.
6674         (rs6000_builtin_type, _initialize_stabsread): Update.
6675
6676 2019-05-08  Tom Tromey  <tom@tromey.com>
6677
6678         * mips-tdep.c (mips_pdr_data): Remove.
6679         (_initialize_mips_tdep): Update.
6680
6681 2019-05-08  Tom Tromey  <tom@tromey.com>
6682
6683         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6684         (hppa_init_objfile_priv_data, read_unwind_info)
6685         (find_unwind_entry, _initialize_hppa_tdep): Update.
6686
6687 2019-05-08  Tom Tromey  <tom@tromey.com>
6688
6689         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6690         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6691         on obstack.
6692         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6693
6694 2019-05-08  Tom Tromey  <tom@tromey.com>
6695
6696         * mdebugread.c (basic_type_data): Change type.
6697         (basic_type, _initialize_mdebugread): Update.
6698
6699 2019-05-08  Tom Tromey  <tom@tromey.com>
6700
6701         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6702
6703 2019-05-08  Tom Tromey  <tom@tromey.com>
6704
6705         * nto-tdep.c (nto_inferior_data_reg): Change type.
6706         (nto_inferior_data): Update.
6707         (nto_inferior_data_cleanup, nto_new_inferior_data)
6708         (_initialize_nto_tdep): Remove.
6709         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6710
6711 2019-05-08  Tom Tromey  <tom@tromey.com>
6712
6713         * ada-lang.c (struct ada_inferior_data): Add initializers.
6714         (ada_inferior_data): Change type.
6715         (ada_inferior_data_cleanup): Remove.
6716         (get_ada_inferior_data, ada_inferior_exit)
6717         (struct ada_pspace_data): Add initializers, destructor.
6718         (ada_pspace_data_handle): Change type.
6719         (get_ada_pspace_data): Update.
6720         (ada_pspace_data_cleanup): Remove.
6721
6722 2019-05-08  Tom Tromey  <tom@tromey.com>
6723
6724         * coffread.c (struct coff_symfile_info): Add initializers.
6725         (coff_objfile_data_key): Move lower.  Change type.
6726         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6727         Update.
6728         (coff_free_info): Remove.
6729
6730 2019-05-08  Tom Tromey  <tom@tromey.com>
6731
6732         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6733         (fbsd_pspace_data_handle): Move lower.  Change type.
6734         (get_fbsd_pspace_data): Update.
6735         (fbsd_pspace_data_cleanup): Remove.
6736         (_initialize_fbsd_tdep): Update.
6737
6738 2019-05-08  Tom Tromey  <tom@tromey.com>
6739
6740         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6741         (get_ada_tasks_pspace_data): Update.
6742         (ada_tasks_pspace_data_cleanup): Remove.
6743         (_initialize_tasks): Update.
6744         (ada_tasks_inferior_data_handle): Change type.
6745         (get_ada_tasks_inferior_data): Update.
6746         (ada_tasks_inferior_data_cleanup): Remove.
6747         (struct ada_tasks_pspace_data): Add initializers.
6748
6749 2019-05-08  Tom Tromey  <tom@tromey.com>
6750
6751         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6752         * symfile-debug.c (debug_sym_get_probes): Change type.
6753         * stap-probe.c (handle_stap_probe):
6754         (stap_static_probe_ops::get_probes): Change type.
6755         * probe.h (class static_probe_ops) <get_probes>: Change type.
6756         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6757         (parse_probes_in_pspace): Update.
6758         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6759         Update.
6760         (any_static_probe_ops::get_probes): Change type.
6761         * elfread.c (elfread_data): New typedef.
6762         (probe_key): Change type.
6763         (elf_get_probes): Likewise.  Update.
6764         (probe_key_free): Remove.
6765         (_initialize_elfread): Update.
6766         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6767         Change type.
6768         (dtrace_process_dof_probe, dtrace_process_dof)
6769         (dtrace_static_probe_ops::get_probe): Change type.
6770
6771 2019-05-08  Tom Tromey  <tom@tromey.com>
6772
6773         * xcoffread.c (struct xcoff_symfile_info): Rename from
6774         coff_symfile_info.  Add initializers.
6775         (xcoff_objfile_data_key): Move lower.  Change type.
6776         (XCOFF_DATA): Rewrite.
6777         (xcoff_free_info): Remove.
6778         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6779         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6780         (xcoff_initial_scan): Update.
6781
6782 2019-05-08  Tom Tromey  <tom@tromey.com>
6783
6784         * solib-svr4.c (struct svr4_info): Add initializers and
6785         destructor.
6786         <probes_table>: Now an htab_up.
6787         (solib_svr4_pspace_data): Change type.
6788         (free_probes_table): Simplify.
6789         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6790         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6791         (probes_table_remove_objfile_probes, register_solib_event_probe)
6792         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6793         (_initialize_svr4_solib): Update.
6794
6795 2019-05-08  Tom Tromey  <tom@tromey.com>
6796
6797         * remote.c (remote_pspace_data): Change type.
6798         (remote_pspace_data_cleanup): Remove.
6799         (get_remote_exec_file, set_pspace_remote_exec_file)
6800         (_initialize_remote): Update.
6801
6802 2019-05-08  Tom Tromey  <tom@tromey.com>
6803
6804         * breakpoint.c (breakpoint_objfile_key): Change type.
6805         (get_breakpoint_objfile_data): Update.
6806         (free_breakpoint_objfile_data): Remove.
6807         (_initialize_breakpoint): Update.
6808
6809 2019-05-08  Tom Tromey  <tom@tromey.com>
6810
6811         * linux-tdep.c (struct linux_info): Add initializers.
6812         (linux_inferior_data): Move.  Change type.
6813         (invalidate_linux_cache_inf): Update.
6814         (linux_inferior_data_cleanup): Remove.
6815         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6816
6817 2019-05-08  Tom Tromey  <tom@tromey.com>
6818
6819         * auxv.c (auxv_inferior_data): Move.  Change type.
6820         (auxv_inferior_data_cleanup): Remove.
6821         (invalidate_auxv_cache_inf): Rewrite.
6822         (get_auxv_inferior_data, _initialize_auxv): Update.
6823
6824 2019-05-08  Tom Tromey  <tom@tromey.com>
6825
6826         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6827         (symfile_debug_objfile_data_key): Change type.
6828         (symfile_debug_installed, debug_qf_has_symbols)
6829         (debug_qf_find_last_source_symtab)
6830         (debug_qf_forget_cached_source_info)
6831         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6832         (debug_qf_print_stats, debug_qf_dump)
6833         (debug_qf_expand_symtabs_for_function)
6834         (debug_qf_expand_all_symtabs)
6835         (debug_qf_expand_symtabs_with_fullname)
6836         (debug_qf_map_matching_symbols)
6837         (debug_qf_expand_symtabs_matching)
6838         (debug_qf_find_pc_sect_compunit_symtab)
6839         (debug_qf_map_symbol_filenames)
6840         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6841         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6842         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6843         (debug_sym_read_linetable, debug_sym_relocate): Update.
6844         (symfile_debug_free_objfile): Remove.
6845         (install_symfile_debug_logging, _initialize_symfile_debug):
6846         Update.
6847
6848 2019-05-08  Tom Tromey  <tom@tromey.com>
6849
6850         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6851         allocate_on_obstack.
6852         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6853         (get_dwarf2_per_objfile): Update.
6854         (set_dwarf2_per_objfile): Remove.
6855         (dwarf2_has_info, dwarf2_get_section_info): Update.
6856         (dwarf2_free_objfile): Remove.
6857         (_initialize_dwarf2_read): Update.
6858
6859 2019-05-08  Tom Tromey  <tom@tromey.com>
6860
6861         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6862         initializers.
6863         <unsupported_script_warning_printed,
6864         script_not_found_warning_printed>: Now bool.
6865         (auto_load_pspace_data): Change type.
6866         (~auto_load_pspace_info): Rename from
6867         auto_load_pspace_data_cleanup.
6868         (get_auto_load_pspace_data, init_loaded_scripts_info)
6869         (clear_section_scripts, maybe_print_unsupported_script_warning)
6870         (maybe_print_script_not_found_warning, _initialize_auto_load):
6871         Update.
6872
6873 2019-05-08  Tom Tromey  <tom@tromey.com>
6874
6875         * objfiles.c (objfile_pspace_info): Add destructor and
6876         initializers.
6877         (objfiles_pspace_data): Change type.
6878         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
6879         (get_objfile_pspace_data): Update.
6880         (objfiles_bfd_data): Change type.
6881         (get_objfile_bfd_data): Update.
6882         (objfile_bfd_data_free, _initialize_objfiles): Remove.
6883
6884 2019-05-08  Tom Tromey  <tom@tromey.com>
6885
6886         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
6887         Change type.
6888         (get_catch_syscall_inferior_data): Update.
6889         (catch_syscall_inferior_data_cleanup): Remove.
6890         (_initialize_break_catch_syscall): Update.
6891
6892 2019-05-08  Tom Tromey  <tom@tromey.com>
6893
6894         * inflow.c (struct terminal_info): Add destructor and
6895         initializers.
6896         (inflow_inferior_data): Change type.
6897         (~terminal_info): Rename from inflow_inferior_data_cleanup.
6898         (get_inflow_inferior_data, inflow_inferior_exit)
6899         (swap_terminal_info, _initialize_inflow): Update.
6900
6901 2019-05-08  Tom Tromey  <tom@tromey.com>
6902
6903         * target-dcache.c (target_dcache_cleanup): Remove.
6904         (target_dcache_aspace_key): Change type.
6905         (target_dcache_init_p, target_dcache_invalidate)
6906         (target_dcache_get, target_dcache_get_or_init)
6907         (_initialize_target_dcache): Update.
6908         * dcache.h (struct dcache_deleter): New.
6909
6910 2019-05-08  Tom Tromey  <tom@tromey.com>
6911
6912         * symtab.c (struct symbol_cache): Add destructor and
6913         initializers.
6914         (symbol_cache_key): Move.  Change type.
6915         (make_symbol_cache, free_symbol_cache): Remove.
6916         (get_symbol_cache): Update.
6917         (symbol_cache_cleanup): Remove.
6918         (ALL_PSPACES, symbol_cache_flush)
6919         (maintenance_print_symbol_cache)
6920         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
6921         Update.
6922
6923 2019-05-08  Tom Tromey  <tom@tromey.com>
6924
6925         * symtab.c (struct main_info): Add destructor and initializers.
6926         (main_progspace_key): Move.  Change type.
6927         (get_main_info): Update.
6928         (main_info_cleanup): Remove.
6929         (_initialize_symtab): Update.
6930
6931 2019-05-08  Tom Tromey  <tom@tromey.com>
6932
6933         * registry.h (DECLARE_REGISTRY): Define the _key class.
6934
6935 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
6936
6937         * NEWS: Merge two 'New commands' sections.
6938
6939 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
6940
6941         * ada-valprint.c (ada_val_print_gnat_array): Remove language
6942         parameter and use Ada language definition instead.
6943         (ada_val_print_ptr): Remove unused language parameter.
6944         (ada_val_print_num): Remove language parameter and use Ada language
6945         definition instead.
6946         (ada_val_print_enum, ada_val_print_flt): Remove unused language
6947         parameter.
6948         (ada_val_print_struct_union, ada_val_print_ref): Remove language
6949         parameter and use Ada language definition instead.
6950         (ada_val_print_1): Update all ada_val_print_xxx calls.
6951         Remove language parameter.
6952         (ada_val_print): Update ada_val_print_1 call.
6953
6954 2019-05-08  Tom Tromey  <tromey@adacore.com>
6955
6956         * remote.c (remote_hw_watchpoint_limit)
6957         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
6958         Now static.
6959
6960 2019-05-08  Tom Tromey  <tromey@adacore.com>
6961
6962         * maint.c (_initialize_maint_cmds): Move initialization code to
6963         remote.c.
6964         (watchdog, show_watchdog): Move to remote.c.
6965         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
6966         "watchdog" static.
6967         (_initialize_remote): Move initialization code from maint.c.
6968         * defs.h (watchdog): Don't declare.
6969
6970 2019-05-08  Tom Tromey  <tromey@adacore.com>
6971
6972         * tui/tui-interp.c: Include main.h.
6973         * interps.c: Include main.h.
6974         * main.h (interpreter_p): Declare.
6975         * defs.h (interpreter_p): Don't declare.
6976
6977 2019-05-08  Tom Tromey  <tromey@adacore.com>
6978
6979         * dwarf2loc.c: Include dwarf2read.h.
6980         * defs.h (read_unsigned_leb128): Don't declare.
6981         * dwarf2read.h (read_unsigned_leb128): Declare.
6982
6983 2019-05-08  Tom Tromey  <tromey@adacore.com>
6984
6985         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
6986         method.
6987
6988 2019-05-08  Tom Tromey  <tromey@adacore.com>
6989
6990         * utils.c (fputs_maybe_filtered): Reset style after paging, even
6991         when no wrap column is set.
6992
6993 2019-05-08  Tom Tromey  <tromey@adacore.com>
6994
6995         * c-lang.c (c_get_string): Handle non-C-style arrays.
6996
6997 2019-05-08  Tom Tromey  <tromey@adacore.com>
6998
6999         * typeprint.c (print_offset_data::update): Print the bit offset,
7000         not the number of bits remaining.
7001
7002 2019-05-08  Tom Tromey  <tromey@adacore.com>
7003
7004         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7005         padding at end of comment.
7006
7007 2019-05-08  Tom Tromey  <tromey@adacore.com>
7008
7009         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7010         Compare main types.
7011
7012 2019-05-06  Tom Tromey  <tom@tromey.com>
7013
7014         * common/scoped_mmap.c: Include common-defs.h.
7015         * common/scoped_mmap.h: Don't include config.h.
7016
7017 2019-05-04  Tom Tromey  <tom@tromey.com>
7018
7019         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7020         (struct aarch64_call_info): Add initializers.
7021         <si>: Now a std::vector.
7022         (pass_on_stack, aarch64_push_dummy_call): Update.
7023
7024 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7025             Tom Tromey  <tom@tromey.com>
7026
7027         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7028         (ppc_threads): Now a std::vector.  Now static.
7029         (hwdebug_find_thread_points_by_tid)
7030         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7031         Update.
7032
7033 2019-05-04  Tom Tromey  <tom@tromey.com>
7034
7035         * arc-tdep.c (arc_tdesc_init): Return bool.
7036
7037 2019-05-04  Tom Tromey  <tom@tromey.com>
7038
7039         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7040         Use gdb_assert_not_reached.
7041
7042 2019-05-04  Tom Tromey  <tom@tromey.com>
7043
7044         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7045         "false".
7046
7047 2019-05-04  Tom Tromey  <tom@tromey.com>
7048
7049         * arc-tdep.c (arc_tdesc_init): Use bool.
7050
7051 2019-05-04  Tom Tromey  <tom@tromey.com>
7052
7053         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7054
7055 2019-05-04  Tom Tromey  <tom@tromey.com>
7056
7057         * cli/cli-cmds.c (valid_command_p): Return bool.
7058
7059 2019-05-04  Tom Tromey  <tom@tromey.com>
7060
7061         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7062         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7063
7064 2019-05-04  Raul Tambre  <raul@tambre.ee>
7065
7066         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7067         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7068         operator for comparison.
7069
7070 2019-05-04  Tom Tromey  <tom@tromey.com>
7071
7072         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7073         (lookup_partial_symbol, print_partial_symbols)
7074         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7075         (psymbol_compare): Update.
7076         (add_psymbol_to_bcache): Clear the entire psymbol.
7077         (maintenance_check_psymtabs): Update.
7078         * psympriv.h (struct partial_symbol): Don't derive from
7079         general_symbol_info.
7080         <obj_section, unrelocated_address, address,
7081         set_unrelocated_address>: Update.
7082         <ginfo>: New member.
7083         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7084         (debug_names::write_psymbols): Update.
7085
7086 2019-05-04  Tom de Vries  <tdevries@suse.de>
7087
7088         * contrib/cc-with-tweaks.sh: Support -n arg.
7089
7090 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7091
7092         * corelow.c (core_target::detach): Ensure frame cache and
7093         register caches are cleared.
7094         inferior.c (exit_inferior_1): Likewise.
7095
7096 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7097             Tom Tromey  <tom@tromey.com>
7098
7099         * dictionary.c (collate_pending_symbols_by_language): Remove
7100         "struct" from foreach.
7101         * symtab.c (lookup_global_symbol_from_objfile)
7102         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7103         foreach.
7104         * ser-tcp.c (net_open): Remove "struct" from foreach.
7105         * objfiles.c (objfile_relocate, objfile_rebase)
7106         (objfile_has_symbols): Remove "struct" from foreach.
7107         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7108         from foreach.
7109         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7110         foreach.
7111         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7112         "struct" from foreach.
7113         * ada-lang.c (create_excep_cond_exprs)
7114         (ada_exception_catchpoint_cond_string): Remove "struct" from
7115         foreach.
7116
7117 2019-05-03  Tom Tromey  <tromey@adacore.com>
7118
7119         * ada-exp.y (convert_char_literal): Check suffix of each
7120         enumerator.
7121
7122 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7123
7124         PR ada/21406:
7125         * ada-exp.y (yywrap): Don't define.
7126         * ada-lex.l (%option): Add noyywrap
7127         (yywrap): Remove.
7128
7129 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7130
7131         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7132         _WIN32_WINNT to the XP level, unless already defined to a higher
7133         level.
7134
7135         * unittests/parse-connection-spec-selftests.c:
7136         * ser-tcp.c:
7137         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7138         override.
7139
7140         * symfile.c (find_separate_debug_file): Remove colon from the
7141         drive spec of DOS/Windows file names of the target, so that the
7142         file name produced from DEBUGDIR and the target's directory will
7143         be valid on DOS/Windows systems.
7144
7145 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7146
7147         * rust-lang.c (val_print_struct): Handle printing structures
7148         containing strings.
7149
7150 2019-05-02  Tom Tromey  <tromey@adacore.com>
7151
7152         * valarith.c (_initialize_valarith): Remove.
7153
7154 2019-05-01  Tom Tromey  <tromey@adacore.com>
7155
7156         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7157         bitfields.
7158
7159 2019-05-01  Tom Tromey  <tromey@adacore.com>
7160
7161         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7162         for big-endian copies.
7163
7164 2019-04-30  Ali Tamur  <tamur@google.com>
7165         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7166         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7167         (read_3_bytes): New function.
7168
7169 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7170
7171         * windows-nat.c (main_thread_id): Delete.
7172         (handle_output_debug_string): Replace main_thread_id by
7173         current_event.dwThreadId.
7174         (fake_create_process): Likewise.
7175         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7176         Do not set main_thread_id.
7177         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7178         current_event.dwThreadId.
7179         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7180
7181 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7182
7183         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7184         Use current_event.dwThreadId instead of main_thread_id.
7185
7186 2019-04-30  Tom Tromey  <tromey@adacore.com>
7187
7188         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7189         (create_excep_cond_exprs): Iterate over program spaces.
7190         (ada_exception_catchpoint_cond_string): Examine all minimal
7191         symbols for exception types.
7192
7193 2019-04-30  Tom Tromey  <tromey@adacore.com>
7194
7195         PR c++/24470:
7196         * dwarf2read.c (process_structure_scope): Handle case where type
7197         has template parameters but no symbol was created.
7198
7199 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7200             Chris January  <chris.january@arm.com>
7201
7202         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7203         qualifier.
7204         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7205
7206 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7207
7208         * f-typeprint.c (f_print_type): Update rules for printing
7209         whitespace.
7210         (f_type_print_varspec_suffix): Likewise.
7211
7212 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7213             Chris January  <chris.january@arm.com>
7214
7215         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7216         function arguments.
7217
7218 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7219
7220         * f-lang.c (build_fortran_types): Change name of void type to
7221         lower case.
7222         * f-typeprint.c (f_type_print_base): Print the name of the void
7223         type, rather than a fixed string.
7224         * f-valprint.c (f_decorations): Use lower case void string.
7225
7226 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7227             Chris January  <chris.january@arm.com>
7228
7229         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7230         types for Fortran.
7231
7232 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7233             Chris January  <chris.january@arm.com>
7234             David Lecomber  <david.lecomber@arm.com>
7235
7236         * f-exp.y (BINOP_INTRINSIC): New token.
7237         (exp): New parser rule handling BINOP_INTRINSIC.
7238         (f77_keywords): Add new builtin procedures.
7239         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7240         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7241         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7242         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7243         (print_unop_subexp_f): New function.
7244         (print_binop_subexp_f): New function.
7245         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7246         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7247         (dump_subexp_body_f): Likewise.
7248         (operator_check_f): Likewise.
7249         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7250         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7251
7252 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7253
7254         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7255         UNOP_KIND.
7256         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7257         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7258         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7259         (operator_length_f): New fuction.
7260         (print_subexp_f): New function.
7261         (op_name_f): New function.
7262         (dump_subexp_body_f): New function.
7263         (operator_check_f): New function.
7264         (exp_descriptor_f): Replace standard expression handling functions
7265         with new functions.
7266         * gdb/fortran-operator.def: New file.
7267         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7268         * gdb/std-operator.def: Remove UNOP_KIND.
7269
7270 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7271
7272         * std-operator.def: Remove unbalanced, stray double quote
7273         character.
7274
7275 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7276             Chris January  <chris.january@arm.com>
7277             Daniel Everett  <daniel.everett@arm.com>
7278             Nick Forrington  <nick.forrington@arm.com>
7279             Richard Bunt  <richard.bunt@arm.com>
7280
7281         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7282         of depth when printing anonymous structs or unions.
7283         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7284         Don't print either the top-level value, or the children if the
7285         max-depth is exceeded.
7286         (ppscm_print_children): When printing the key of a map, allow one
7287         extra level of depth.
7288         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7289         print either the top-level value, or the children if the max-depth
7290         is exceeded.
7291         (print_children): When printing the key of a map, allow one extra
7292         level of depth.
7293         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7294         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7295         (user_print_options): Initialise max_depth field.
7296         (val_print_scalar_or_string_type_p): New function.
7297         (val_print): Check to see if the max depth has been reached.
7298         (val_print_check_max_depth): Define new function.
7299         (show_print_max_depth): New function.
7300         (_initialize_valprint): Add 'print max-depth' option.
7301         * valprint.h (struct value_print_options) <max_depth>: New field.
7302         (val_print_check_max_depth): Declare new function.
7303         * NEWS: Document new feature.
7304
7305 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7306
7307         * ada-lang.c (ada_language_defn): Initialise new field.
7308         * c-lang.c (c_is_string_type_p): New function.
7309         (c_language_defn): Initialise new field.
7310         (cplus_language_defn): Initialise new field.
7311         (asm_language_defn): Initialise new field.
7312         (minimal_language_defn): Initialise new field.
7313         * c-lang.h (c_is_string_type_p): Declare new function.
7314         * d-lang.c (d_language_defn): Initialise new field.
7315         * f-lang.c (f_is_string_type_p): New function.
7316         (f_language_defn): Initialise new field.
7317         * go-lang.c (go_is_string_type_p): New function.
7318         (go_language_defn): Initialise new field.
7319         * language.c (default_is_string_type_p): New function.
7320         (unknown_language_defn): Initialise new field.
7321         (auto_language_defn): Initialise new field.
7322         * language.h (struct language_defn) <la_is_string_type_p>: New
7323         member variable.
7324         (default_is_string_type_p): Declare new function.
7325         * m2-lang.c (m2_language_defn): Initialise new field.
7326         * objc-lang.c (objc_language_defn): Initialise new field.
7327         * opencl-lang.c (opencl_language_defn): Initialise new field.
7328         * p-lang.c (pascal_is_string_type_p): New function.
7329         (pascal_language_defn): Initialise new field.
7330         * rust-lang.c (rust_is_string_type_p): New function.
7331         (rust_language_defn): Initialise new field.
7332
7333 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7334
7335         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7336         New field.
7337         * ada-lang.c (ada_language_defn): Initialise new field.
7338         * c-lang.c (c_language_defn): Likewise.
7339         (cplus_language_defn): Likewise.
7340         (asm_language_defn): Likewise.
7341         (minimal_language_defn): Likewise.
7342         * d-lang.c (d_language_defn): Likewise.
7343         * f-lang.c (f_language_defn): Likewise.
7344         * go-lang.c (go_language_defn): Likewise.
7345         * language.c (unknown_language_defn): Likewise.
7346         (auto_language_defn): Likewise.
7347         * m2-lang.c (m2_language_defn): Likewise.
7348         * objc-lang.c (objc_language_defn): Likewise.
7349         * opencl-lang.c (opencl_language_defn): Likewise.
7350         * p-lang.c (pascal_language_defn): Likewise.
7351         * rust-lang.c (rust_language_defn): Likewise.
7352
7353 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7354
7355         * ada-lang.c (ada_is_character_type): Change return type to bool.
7356         (ada_is_string_type): Likewise.
7357         * ada-lang.h (ada_is_character_type): Update declaration
7358         (ada_is_string_type): Likewise.
7359
7360 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7361
7362         Support style in 'frame|thread apply'
7363
7364         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7365         * record.c (record_start, record_stop): Update callers of
7366         execute_command_to_string with false.
7367         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7368         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7369         methods.
7370         (class string_file): New constructor with term_out parameter.
7371         Override methods term_out and can_emit_style_escape.  New member
7372         term_out.
7373         (class stdio_file): Override can_emit_style_escape.
7374         (class tee_file): Override term_out and can_emit_style_escape.
7375         * utils.h (can_emit_style_escape): Remove.
7376         * utils.c (can_emit_style_escape): Likewise.
7377         Update all callers of can_emit_style_escape (SOMESTREAM) to
7378         SOMESTREAM->can_emit_style_escape.
7379         * source-cache.c (source_cache::get_source_lines): Likewise.
7380         * stack.c (frame_apply_command_count): Call execute_command_to_string
7381         passing the term_out characteristic of the current gdb_stdout.
7382         * thread.c (thr_try_catch_cmd): Likewise.
7383         * top.c (execute_command_to_string): pass term_out parameter
7384         to construct the string_file for the command output.
7385         * ui-file.c (term_cli_styling): New function (most code moved
7386         from utils.c can_emit_style_escape).
7387         (string_file::string_file, string_file::can_emit_style_escape,
7388         stdio_file::can_emit_style_escape, tee_file::term_out,
7389         tee_file::can_emit_style_escape): New functions.
7390
7391 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7392
7393         * NEWS: Mention the new set|show may-call-functions.
7394         * infcall.c (may_call_functions_p): New variable.
7395         (show_may_call_functions_p): New function.
7396         (call_function_by_hand_dummy): Throws an error if not
7397         may-call-functions.
7398         (_initialize_infcall): Call add_setshow_boolean_cmd for
7399         may-call-functions.
7400
7401 2019-04-25  Keith Seitz  <keiths@redhat.com>
7402
7403         PR c++/24367
7404         * cp-support.c (inspect_type): Don't attempt substitutions
7405         of symbol with the same name.
7406
7407 2019-04-25  Tom Tromey  <tromey@adacore.com>
7408
7409         PR gdb/24475:
7410         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7411         static.
7412
7413 2019-04-25  Tom Tromey  <tromey@adacore.com>
7414
7415         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7416         rvalue reference.
7417         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7418         (gdb_xml_parser::parse): Use std::move.
7419         * python/python-internal.h (gdbpy_convert_exception): Take a const
7420         reference.
7421         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7422         std::move.
7423         * python/py-utils.c (gdbpy_convert_exception): Take a const
7424         reference.
7425         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7426         Use std::move.
7427         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7428         Use std::move.
7429         * mi/mi-main.c (mi_print_exception): Take a const reference.
7430         * main.c (handle_command_errors): Take a const reference.
7431         * linespec.c (parse_linespec): Use std::move.
7432         * infcall.c (run_inferior_call): Use std::move.
7433         (call_function_by_hand_dummy): Use std::move.
7434         * exec.c (try_open_exec_file): Use std::move.
7435         * exceptions.h (exception_print, exception_fprintf)
7436         (exception_print_same): Update.
7437         * exceptions.c (print_exception, exception_print)
7438         (exception_fprintf, exception_print_same): Change parameters to
7439         const reference.
7440         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7441         * common/new-op.c: Use std::move.
7442         * common/common-exceptions.h (struct gdb_exception): Add move
7443         constructor.
7444         (struct gdb_exception_error, struct gdb_exception_quit, struct
7445         gdb_quit_bad_alloc): Change constructor to move constructor.
7446         (throw_exception): Change parameter to rvalue reference.
7447         * common/common-exceptions.c (throw_exception): Take rvalue
7448         reference.
7449         * cli/cli-interp.c (safe_execute_command): Use std::move.
7450         * breakpoint.c (insert_bp_location, location_to_sals): Use
7451         std::move.
7452
7453 2019-04-25  Tom Tromey  <tromey@adacore.com>
7454
7455         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7456         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7457         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7458         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7459         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7460         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7461         guile/scm-value.c: Use unpack.
7462         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7463         gdbscm_gdb_exception.
7464         (gdbscm_throw_gdb_exception): Likewise.
7465         (struct gdbscm_gdb_exception): New.
7466         (unpack): New function.
7467         (gdbscm_wrap): Use unpack.
7468
7469 2019-04-25  Tom Tromey  <tromey@adacore.com>
7470
7471         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7472         (gdb_rl_callback_handler): Use std::move.
7473         * common/common-exceptions.h (struct gdb_exception): Add move
7474         assignment operator.
7475         (throw_exception_sjlj): Change "exception" to const reference.
7476         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7477         (throw_exception_sjlj): Change "exception" to const reference.
7478
7479 2019-04-25  Tom Tromey  <tromey@adacore.com>
7480
7481         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7482         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7483         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7484         Update.
7485         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7486         Update.
7487         * mi/mi-interp.c (mi_interp::exec): Update.
7488         * linespec.c (parse_linespec): Update.
7489         * infcall.c (run_inferior_call): Update.
7490         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7491         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7492         (gdbscm_lookup_global_symbol): Update.
7493         * guile/scm-param.c (gdbscm_parameter_value): Update.
7494         * guile/scm-frame.c (gdbscm_frame_read_register)
7495         (gdbscm_frame_read_var): Update.
7496         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7497         * exec.c (try_open_exec_file): Update.
7498         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7499         (gdb_rl_callback_handler): Update.
7500         * common/common-exceptions.h (exception_none): Don't declare.
7501         * common/common-exceptions.c (exception_none): Don't define.
7502         (struct catcher) <exception>: Update.
7503         * cli/cli-interp.c (safe_execute_command): Update.
7504         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7505
7506 2019-04-25  Ali Tamur  <tamur@google.com>
7507
7508         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7509         (read_attribute_value): Likewise.
7510         (dwarf2_read_addr_index): Update comment.
7511         (read_str_index): Add DW_FORM_strx.
7512         (dwarf2_string_attr): Likewise.
7513         (dwarf2_const_value_attr): Likewise.
7514         (dump_die_shallow): Likewise.
7515         (dwarf2_fetch_constant_bytes): Likewise.
7516         (skip_form_bytes): Likewise.
7517         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7518
7519 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7520
7521         PR corefiles/11608
7522         PR corefiles/18187
7523         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7524         OFFSET.  Verify if current mapping contains an ELF header.
7525         (linux_find_memory_regions_full): Adjust call to
7526         dump_mapping_p.
7527
7528 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7529             Kang Li <kanglictf@gmail.com>
7530
7531         PR gdb/21600
7532
7533         * dwarf2-frame.c (read_initial_length): Be consistent about using
7534         unsigned representation of length.
7535         (decode_frame_entry_1): Likewise.  Check for wraparound of
7536         end pointer as well as buffer overflow.
7537
7538 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7539
7540         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7541         "vq".
7542
7543 2019-04-24  Tom Tromey  <tromey@adacore.com>
7544
7545         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7546
7547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7548
7549         * s12z-tdep.c (s12z_unwind_pc): Delete.
7550         (s12z_unwind_sp): Delete.
7551         (s12z_gdbarch_init): Don't register deleted functions with
7552         gdbarch.
7553
7554 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7555
7556         * rl78-tdep.c (rl78_unwind_sp): Delete.
7557         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7558
7559 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7560
7561         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7562         (xstormy16_unwind_pc): Delete.
7563         (xstormy16_dummy_id): Delete.
7564         (xstormy16_gdbarch_init): Don't register deleted functions with
7565         gdbarch.
7566
7567 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7568
7569         * vax-tdep.c (vax_unwind_pc): Delete.
7570         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7571
7572 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7573
7574         * v850-tdep.c (v850_unwind_sp): Delete.
7575         (v850_unwind_pc): Delete.
7576         (v850_dummy_id): Delete.
7577         (v850_gdbarch_init): Don't register deleted functions with
7578         gdbarch.
7579
7580 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7581
7582         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7583         (tilegx_unwind_pc): Delete.
7584         (tilegx_unwind_dummy_id): Delete.
7585         (tilegx_gdbarch_init): Don't register deleted functions with
7586         gdbarch.
7587
7588 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7589
7590         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7591         (tic6x_dummy_id): Delete.
7592         (tic6x_gdbarch_init): Don't register deleted functions with
7593         gdbarch.
7594
7595 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7596
7597         * sparc-tdep.c (sparc_unwind_pc): Delete.
7598         (sparc32_gdbarch_init): Don't register deleted function with
7599         gdbarch.
7600
7601 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         * sh-tdep.c (sh_unwind_sp): Delete.
7604         (sh_unwind_pc): Delete.
7605         (sh_dummy_id): Delete.
7606         (sh_gdbarch_init): Don't register deleted functions with
7607         gdbarch.
7608
7609 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7610
7611         * score-tdep.c (score_unwind_sp): Delete.
7612         (score_unwind_pc): Delete.
7613         (score_dummy_id): Delete.
7614         (score_gdbarch_init): Don't register deleted functions with
7615         gdbarch.
7616
7617 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7618
7619         * rx-tdep.c (rx_unwind_pc): Delete.
7620         (rx_unwind_sp): Delete.
7621         (rx_dummy_id): Delete.
7622         (rx_gdbarch_init): Don't register deleted functions with
7623         gdbarch.  Update comment.
7624
7625 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7626
7627         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7628         (rs6000_dummy_id): Delete.
7629         (rs6000_gdbarch_init): Don't register deleted functions with
7630         gdbarch.
7631
7632 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7633
7634         * or1k-tdep.c (or1k_dummy_id): Delete.
7635         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7636
7637 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7638
7639         * nios2-tdep.c (nios2_dummy_id): Delete.
7640         (nios2_unwind_sp): Delete.
7641         (nios2_gdbarch_init): Don't register deleted functions with
7642         gdbarch.
7643
7644 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7645
7646         * nds32-tdep.c (nds32_dummy_id): Delete.
7647         (nds32_unwind_pc): Delete.
7648         (nds32_unwind_sp): Delete.
7649         (nds32_gdbarch_init): Don't register deleted functions with
7650         gdbarch.
7651
7652 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7653
7654         * msp430-tdep.c (msp430_unwind_pc): Delete.
7655         (msp430_unwind_sp): Delete.
7656         (msp430_dummy_id): Delete.
7657         (msp430_gdbarch_init): Don't register deleted functions with
7658         gdbarch.
7659
7660 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7661
7662         * moxie-tdep.c (moxie_unwind_sp): Delete.
7663         (moxie_unwind_pc): Delete.
7664         (moxie_dummy_id): Delete.
7665         (moxie_gdbarch_init): Don't register deleted functions with
7666         gdbarch.
7667
7668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7669
7670         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7671         (mn10300_unwind_pc): Delete.
7672         (mn10300_unwind_sp): Delete.
7673         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7674         mn10300_unwind_sp.
7675         (mn10300_frame_unwind_init): Don't register deleted functions with
7676         gdbarch.
7677
7678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7679
7680         * mep-tdep.c (mep_unwind_pc): Delete.
7681         (mep_unwind_sp): Delete.
7682         (mep_dummy_id): Delete.
7683         (mep_gdbarch_init): Don't register deleted functions with
7684         gdbarch.
7685
7686 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7687
7688         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7689         (m68hc11_unwind_sp): Delete.
7690         (m68hc11_gdbarch_init): Don't register deleted functions with
7691         gdbarch.
7692
7693 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7694
7695         * m32r-tdep.c (m32r_unwind_sp): Delete.
7696         (m32r_unwind_pc): Delete.
7697         (m32r_dummy_id): Delete.
7698         (m32r_gdbarch_init): Don't register deleted functions with
7699         gdbarch.
7700
7701 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7702
7703         * m32c-tdep.c (m32c_unwind_pc): Delete.
7704         (m32c_unwind_sp): Delete.
7705         (m32c_dummy_id): Delete.
7706         (m32c_gdbarch_init): Don't register deleted functions with
7707         gdbarch.
7708
7709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7710
7711         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7712         (lm32_unwind_pc): Delete.
7713         (lm32_dummy_id): Delete.
7714         (lm32_gdbarch_init): Don't register deleted functions with
7715         gdbarch.
7716
7717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7718
7719         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7720         (iq2000_unwind_pc): Delete.
7721         (iq2000_dummy_id): Delete.
7722         (iq2000_gdbarch_init): Don't register deleted functions with
7723         gdbarch.
7724
7725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7726
7727         * nds32-tdep.c (nds32_type_align): Delete.
7728         (nds32_push_dummy_call): Use type_align instead.
7729
7730 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7731
7732         * arm-tdep.c (arm_type_align): Only handle vector override case.
7733         (arm_push_dummy_call): Use type_align.
7734         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7735
7736 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7737
7738         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7739         case.
7740         (pass_on_stack): Use type_align.
7741         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7742         function.
7743
7744 2019-04-23  Tom Tromey  <tromey@adacore.com>
7745
7746         * dwarf2read.c (line_header::file_name_at): Remove unused
7747         overload.
7748
7749 2019-04-23  Tom de Vries  <tdevries@suse.de>
7750
7751         PR gdb/24438
7752         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7753         invocation.
7754
7755
7756 2019-03-27  Ali Tamur  <tamur@google.com>
7757
7758         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7759         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7760         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7761         (dwarf_expr_context::get_addr_index): Likewise
7762         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7763         (symbol_needs_eval_context::get_addr_index): Likewise
7764         (disassemble_dwarf_expression): Add DW_OP_addrx
7765         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7766         (read_cutu_die_from_dwo): Update comment
7767         (skip_one_die): Add DW_FORM_addrx
7768         (read_attribute_value): Likewise
7769         (var_decode_location): Add DW_OP_addrx
7770         (dwarf2_const_value_attr): Add DW_FORM_addrx
7771         (dump_die_shallow): Likewise
7772         (dwarf2_fetch_constant_bytes): Likewise
7773         (decode_locdesc): Add DW_OP_addrx
7774         (skip_form_bytes): Add DW_FORM_addrx
7775
7776 2019-04-22  Ali Tamur  <tamur@google.com>
7777
7778         * MAINTAINERS (Write After Approval): Add self.
7779
7780 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7781
7782         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7783         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7784         (open_symbol_file_object): Likewise.
7785         (svr4_default_sos): Add info parameter.
7786         (svr4_read_so_list): Likewise.
7787         (svr4_current_sos_direct): Adjust functions calls to pass down
7788         info.
7789         (svr4_current_sos_1): Add info parameter.
7790         (svr4_current_sos): Call get_svr4_info, pass info down to
7791         svr4_current_sos_1.
7792         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7793         get_svr4_info.
7794         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7795         get_svr4_info.
7796         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7797         to get_svr4_info.
7798         (probes_table_remove_objfile_probes): Likewise.
7799         (register_solib_event_probe): Add info parameter.
7800         (solist_update_incremental): Pass info parameter down to
7801         svr4_read_so_list.
7802         (disable_probes_interface): Add info parameter.
7803         (svr4_handle_solib_event): Pass current_program_space to
7804         get_svr4_info.  Adjust disable_probes_interface cleanup.
7805         (svr4_create_probe_breakpoints): Add info parameter, pass it
7806         down to register_solib_event_probe.
7807         (svr4_create_solib_event_breakpoints): Add info parameter,
7808         pass it down to svr4_create_probe_breakpoints.
7809         (enable_break): Pass info down to
7810         svr4_create_solib_event_breakpoints.
7811         (svr4_solib_create_inferior_hook): Pass current_program_space to
7812         get_svr4_info.
7813         (svr4_clear_solib): Likewise.
7814
7815 2019-04-22  Pedro Alves  <palves@redhat.com>
7816
7817         * solib-svr4.c (svr4_free_objfile_observer): New.
7818         (probe_and_action::objfile): New field.
7819         (probes_table_htab_remove_objfile_probes)
7820         (probes_table_remove_objfile_probes): New functions.
7821         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7822         in the new probe_and_action.  Don't store the probe in 'lookup'.
7823         (svr4_create_probe_breakpoints): Pass objfile to
7824         register_solib_event_probe.
7825         (_initialize_svr4_solib): Register a free_objfile observer.
7826
7827 2019-04-19  Tom Tromey  <tom@tromey.com>
7828
7829         * common/queue.h: Remove.
7830
7831 2019-04-19  Tom Tromey  <tom@tromey.com>
7832
7833         * event-loop.c: Don't include "common/queue.h".
7834
7835 2019-04-19  Tom Tromey  <tom@tromey.com>
7836
7837         * remote.c (remote_target): Use delete.
7838         * remote-notif.h: Include <list>, not "common/queue.h".
7839         (notif_client_p): Remove typedef.
7840         (remote_notif_state): Add constructor, destructor, initializer.
7841         <notif_queue>: Now a std::list.
7842         (remote_notif_state_xfree): Don't declare.
7843         * remote-notif.c (remote_notif_process, handle_notification)
7844         (remote_notif_state_allocate): Update.
7845         (~remote_notif_state): Rename from remote_notif_state_xfree.
7846
7847 2019-04-19  Tom Tromey  <tom@tromey.com>
7848
7849         * symfile.c (reread_symbols): Update.
7850         * objfiles.c (objfile_register_static_link)
7851         (objfile_lookup_static_link): Update
7852         (~objfile) Don't delete static_links.
7853         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7854
7855 2019-04-19  Tom Tromey  <tom@tromey.com>
7856
7857         * type-stack.h (struct type_stack) <insert>: Constify string.
7858         * type-stack.c (type_stack::insert): Constify string.
7859         * gdbtypes.h (lookup_template_type): Update.
7860         (address_space_name_to_int): Update.
7861         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7862         const.
7863         (lookup_template_type): Make name const.
7864         * c-exp.y: Update rules.
7865         (lex_one_token, classify_name, classify_inner_name)
7866         (c_print_token): Update.
7867         * p-exp.y: Update rules.
7868         (yylex): Update.
7869         * f-exp.y: Update rules.
7870         (yylex): Update.
7871         * d-exp.y: Update rules.
7872         (lex_one_token, classify_name, classify_inner_name): Update.
7873         * parse.c (write_dollar_variable, copy_name): Return std::string.
7874         * parser-defs.h (copy_name): Change return type.
7875         * m2-exp.y: Update rules.
7876         (yylex): Update.
7877         * go-exp.y (lex_one_token): Update.
7878         Update rules.
7879         (classify_unsafe_function, classify_packaged_name)
7880         (classify_name, yylex): Update.
7881
7882 2019-04-19  Sergei Trofimovich <siarheit@google.com>
7883
7884         * configure.ac: add --enable-source-highlight switch.
7885         * configure: Regenerate.
7886         * top.c (print_gdb_version): plumb --enable-source-highlight
7887         status to "show configuration".
7888
7889 2019-04-19  Tom Tromey  <tromey@adacore.com>
7890
7891         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
7892         Check ADA_TYPE_P.
7893         (empty_record, ada_template_to_fixed_record_type_1)
7894         (template_to_static_fixed_type)
7895         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
7896         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
7897         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
7898         macros.
7899
7900 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
7901
7902         PR symtab/24423:
7903         * source.c (print_source_lines_base): Advance "iter" when a
7904         control character is seen.
7905
7906 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7907
7908         * inferior.h (struct infcall_suspend_state_deleter):
7909         Catch exception in destructor to avoid crash.
7910
7911 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7912
7913         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
7914         close to the add_com "shell".
7915
7916 2019-04-18  Tom Tromey  <tromey@adacore.com>
7917
7918         * process-stratum-target.h (class process_stratum_target)
7919         <stratum>: Add "final".
7920
7921 2019-04-17  Tom Tromey  <tromey@adacore.com>
7922
7923         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
7924         against nullptr before use.
7925
7926 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
7927
7928         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
7929
7930 2019-04-17  Jim Wilson  <jimw@sifive.com>
7931             Andrew Burgess  <andrew.burgess@embecosm.com>
7932
7933         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
7934         code read might fail, assume 4-byte breakpoint in that case.
7935
7936 2019-04-15  Leszek Swirski  <leszeks@google.com>
7937
7938         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
7939         rather than a hand-rolled POD check when checking for forced MEMORY
7940         classification.
7941
7942 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7943
7944         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
7945         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
7946         function.
7947         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
7948         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
7949         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
7950         declaration.
7951
7952 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7953
7954         * aarch64-linux-nat.c
7955         (aarch64_linux_nat_target::thread_architecture): Add override.
7956         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
7957         each VQ.
7958
7959 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
7960
7961         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
7962
7963 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
7964
7965         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
7966         target types of size 96-bits, add some additional comments, and
7967         check that the builtin type we found was the correct size.
7968
7969 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
7970
7971         * utils.c (prompt_for_continue): Don't restore the styling at the
7972         end, as applied_style has the wrong value.  This fixes styling in
7973         long lists of file names that are interrupted by the "Continue?"
7974         prompt.
7975
7976 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7977
7978         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
7979         * c-lang.c (c_language_defn): Likewise.
7980         (cplus_language_defn): Likewise.
7981         (asm_language_defn): Likewise.
7982         (minimal_language_defn): Likewise.
7983         * d-lang.c (d_language_defn): Likewise.
7984         * f-lang.c (f_language_defn): Likewise.
7985         * go-lang.c (go_language_defn): Likewise.
7986         * language.c (unknown_language_defn): Likewise.
7987         (auto_language_defn): Likewise.
7988         * language.h (struct language_defn): Remove la_magic field.
7989         (LANG_MAGIC): Delete.
7990         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
7991         * objc-lang.c (objc_language_defn): Likewise.
7992         * opencl-lang.c (opencl_language_defn): Likewise.
7993         * p-lang.c (pascal_language_defn): Likewise.
7994         * rust-lang.c (rust_language_defn): Likewise.
7995
7996 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7997
7998         * riscv-tdep.c (riscv_type_align): New function.
7999         (riscv_type_alignment): Delete.
8000         (riscv_arg_location): Use 'type_align'.
8001         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8002
8003 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8004
8005         * gdbtypes.c (type_align): A struct with no non-static fields also
8006         has alignment of 1.
8007
8008 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8009
8010         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8011         component to 0.
8012         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8013         member.
8014         (riscv_struct_info::analyse): New implementation using new
8015         analyse_inner member function.
8016         (riscv_struct_info::field_offset): New member function.
8017         (riscv_struct_info::m_offsets): New member variable.
8018         (riscv_struct_info::analyse_inner): New private member function,
8019         takes the old implementation of riscv_struct_info::analyse but
8020         extended to track field offsets.
8021         (riscv_call_arg_struct): Update the struct folding special cases
8022         to handle cases where empty C++ structs, which are non-zero
8023         length, are found.
8024         (riscv_arg_location): Initialise the length of each location, a
8025         non-zero length now indicates the location is in use.
8026         (riscv_push_dummy_call): Allow for the first location having a
8027         non-zero offset when setting up arguments.
8028         (riscv_return_value): Likewise, but for return values.
8029
8030 2019-04-11  Tom Tromey  <tromey@adacore.com>
8031
8032         * utils.c (internal_vproblem): Make "msg" const.
8033
8034 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8035
8036         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8037         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8038         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8039         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8040
8041 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8042
8043         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8044         function.
8045         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8046         of amd64_collect_native_gregset.
8047         (amd64_linux_nat_target::store_registers): Likewise.
8048
8049 2019-04-10  Tom Tromey  <tom@tromey.com>
8050
8051         * symtab.c (lookup_global_symbol_from_objfile)
8052         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8053         * objfiles.h (class separate_debug_iterator): New.
8054         (class separate_debug_range): New.
8055         (struct objfile) <separate_debug_objfiles>: New method.
8056         (objfile_separate_debug_iterate): Don't declare.
8057         * objfiles.c (separate_debug_iterator::operator++): Rename from
8058         objfile_separate_debug_iterate.
8059         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8060         iterator.
8061         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8062         iterator.
8063
8064 2019-04-10  Tom Tromey  <tom@tromey.com>
8065
8066         * symfile.c (reread_symbols): Remove old comment.
8067         * objfiles.c (free_all_objfiles): Fix a typo.
8068
8069 2019-04-10  Tom Tromey  <tom@tromey.com>
8070
8071         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8072         * minsyms.c (lookup_minimal_symbol): Use foreach.
8073         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8074         (lookup_minimal_symbol_solib_trampoline): Likewise.
8075         * symfile.c (reread_symbols): Use foreach.
8076
8077 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8078             Tom Tromey  <tromey@adacore.com>
8079
8080         PR rust/24414:
8081         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8082         (rust_lex_int_test): Change "value" to be LONGEST.
8083         (rust_lex_tests): Add test for long integer literal.
8084
8085 2019-04-09  Tom Tromey  <tromey@adacore.com>
8086
8087         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8088         to bool.
8089         (extended_remote_target::attach): Update.
8090         (remote_target::remote_notice_new_inferior): Update.
8091         (remote_target::add_current_inferior_and_thread): Update.
8092         * inferior.c (exit_inferior_1): Use "false".
8093         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8094
8095 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8096
8097         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8098         the "start" command.
8099
8100 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8101
8102         * python/py-inferior.c (infpy_thread_from_thread_handle):
8103         Adjust comments to reflect renaming of thread_from_thread_handle
8104         to thread_from_handle.  Adjust keywords.  Fix type error message.
8105         (inferior_object_methods): Add thread_from_handle.  Retain
8106         thread_from_thread_handle, but mark it as deprecated.
8107
8108 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8109
8110         * gdbthread.h (find_thread_by_handle): Revise declaration.
8111         * thread.c (find_thread_by_handle): Likewise.  Adjust
8112         implementation too.
8113         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8114         support for buffer objects as handles.
8115
8116 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8117
8118         * python/py-infthread.c (thpy_thread_handle): New function.
8119         (thread_object_methods): Register thpy_thread_handle.
8120
8121 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8122
8123         * gdbthread.h (thread_to_thread_handle): Declare.
8124         * thread.c (gdbtypes.h): Include.
8125         (thread_to_thread_handle): New function.
8126
8127         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8128         (target_thread_info_to_thread_handle): Declare.
8129         * target.c (target_thread_info_to_thread_handle): New function.
8130         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8131         * target-delegates.c: Regenerate.
8132
8133         * linux-thread-db.c (class thread_db_target): Add method
8134         thread_info_to_thread_handle.
8135         (thread_db_target::thread_info_to_thread_handle): Define.
8136         * remote.c (class remote_target): Add new method
8137         thread_info_to_thread_handle.
8138         (remote_target::thread_info_to_thread_handle): Define.
8139
8140 2019-04-08  Pedro Alves  <palves@redhat.com>
8141
8142         * common/common-exceptions.c (throw_exception): Don't create
8143         named object to throw; throw directly.
8144         (throw_it): Likewise.  Don't initialize gdb_exception::message
8145         here, with new; pass FMT and AP to the ctor instead.
8146         * common/common-exceptions.h: Include <string>.
8147         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8148         const char *, va_list)): New ctor.  Use std::make_shared.
8149         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8150         errors)): Delete.
8151         (gdb_exception_error::gdb_exception_error(enum errors, const char
8152         *, va_list)): New.
8153         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8154         Add assertion.
8155         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8156         errors)): Delete.
8157         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8158         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8159         Add assertion.
8160
8161 2019-04-08  Tom Tromey  <tom@tromey.com>
8162
8163         * valops.c (value_rtti_indirect_type): Replace throw_exception
8164         with throw.
8165         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8166         with throw.
8167         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8168         throw.
8169         * target.c (target_translate_tls_address): Replace throw_exception
8170         with throw.
8171         * stack.c (frame_apply_command_count): Replace throw_exception
8172         with throw.
8173         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8174         throw.
8175         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8176         with throw.
8177         * rs6000-tdep.c (rs6000_frame_cache)
8178         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8179         * remote.c: Replace throw_exception with throw.
8180         * record-full.c (record_full_message, record_full_wait_1)
8181         (record_full_restore): Replace throw_exception with throw.
8182         * record-btrace.c:
8183         (get_thread_current_frame_id, record_btrace_start_replaying)
8184         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8185         (cmd_record_btrace_start): Replace throw_exception with throw.
8186         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8187         throw.
8188         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8189         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8190         * linespec.c:
8191         (find_linespec_symbols): Replace throw_exception with throw.
8192         * infrun.c (displaced_step_prepare, resume): Replace
8193         throw_exception with throw.
8194         * infcmd.c (post_create_inferior): Replace throw_exception with
8195         throw.
8196         * inf-loop.c (inferior_event_handler): Replace throw_exception
8197         with throw.
8198         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8199         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8200         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8201         (get_prev_frame_always, get_frame_pc_if_available)
8202         (get_frame_address_in_block_if_available, get_frame_language):
8203         Replace throw_exception with throw.
8204         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8205         throw_exception with throw.
8206         * eval.c (fetch_subexp_value, evaluate_var_value)
8207         (evaluate_funcall, evaluate_subexp_standard): Replace
8208         throw_exception with throw.
8209         * dwarf2loc.c (call_site_find_chain)
8210         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8211         Replace throw_exception with throw.
8212         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8213         with throw.
8214         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8215         throw.
8216         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8217         * completer.c (complete_line_internal): Replace throw_exception
8218         with throw.
8219         * compile/compile-object-run.c (compile_object_run): Replace
8220         throw_exception with throw.
8221         * cli/cli-script.c (process_next_line): Replace throw_exception
8222         with throw.
8223         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8224         (btrace_enable, btrace_maint_update_pt_packets): Replace
8225         throw_exception with throw.
8226         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8227         throw_exception with throw.
8228         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8229         throw_exception with throw.
8230         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8231         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8232         * aarch64-tdep.c (aarch64_make_prologue_cache)
8233         (aarch64_make_stub_cache): Replace throw_exception with throw.
8234
8235 2019-04-08  Tom Tromey  <tom@tromey.com>
8236
8237         * common/common-exceptions.c (throw_exception): Rename from
8238         throw_exception_cxx.  Remove old copy.  Make argument const.
8239         (throw_it): Create and throw exception objects directly.
8240         * common/common-exceptions.h (throw_exception): Make argument
8241         const.
8242         (struct gdb_exception_error): Add constructor.
8243         (struct gdb_exception_quit): Add constructor.
8244
8245 2019-04-08  Tom Tromey  <tom@tromey.com>
8246
8247         * common/common-exceptions.h (exception_rethrow): Don't declare.
8248         (TRY_SJLJ): Update comment.
8249         (TRY, CATCH, END_CATCH): Remove.
8250         * common/common-exceptions.c (exception_rethrow): Remove.
8251
8252 2019-04-08  Tom Tromey  <tom@tromey.com>
8253
8254         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8255         Remove.
8256         (gdb_exception_error): Rename from
8257         gdb_exception_RETURN_MASK_ERROR.
8258         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8259         (gdb_quit_bad_alloc): Update.
8260         * aarch64-tdep.c: Update.
8261         * ada-lang.c: Update.
8262         * ada-typeprint.c: Update.
8263         * ada-valprint.c: Update.
8264         * amd64-tdep.c: Update.
8265         * arch-utils.c: Update.
8266         * break-catch-throw.c: Update.
8267         * breakpoint.c: Update.
8268         * btrace.c: Update.
8269         * c-varobj.c: Update.
8270         * cli/cli-cmds.c: Update.
8271         * cli/cli-interp.c: Update.
8272         * cli/cli-script.c: Update.
8273         * common/common-exceptions.c: Update.
8274         * common/new-op.c: Update.
8275         * common/selftest.c: Update.
8276         * compile/compile-c-symbols.c: Update.
8277         * compile/compile-cplus-symbols.c: Update.
8278         * compile/compile-object-load.c: Update.
8279         * compile/compile-object-run.c: Update.
8280         * completer.c: Update.
8281         * corelow.c: Update.
8282         * cp-abi.c: Update.
8283         * cp-support.c: Update.
8284         * cp-valprint.c: Update.
8285         * darwin-nat.c: Update.
8286         * disasm-selftests.c: Update.
8287         * dtrace-probe.c: Update.
8288         * dwarf-index-cache.c: Update.
8289         * dwarf-index-write.c: Update.
8290         * dwarf2-frame-tailcall.c: Update.
8291         * dwarf2-frame.c: Update.
8292         * dwarf2loc.c: Update.
8293         * dwarf2read.c: Update.
8294         * eval.c: Update.
8295         * event-loop.c: Update.
8296         * event-top.c: Update.
8297         * exec.c: Update.
8298         * f-valprint.c: Update.
8299         * fbsd-tdep.c: Update.
8300         * frame-unwind.c: Update.
8301         * frame.c: Update.
8302         * gdbtypes.c: Update.
8303         * gnu-v3-abi.c: Update.
8304         * guile/guile-internal.h: Update.
8305         * guile/scm-block.c: Update.
8306         * guile/scm-breakpoint.c: Update.
8307         * guile/scm-cmd.c: Update.
8308         * guile/scm-disasm.c: Update.
8309         * guile/scm-frame.c: Update.
8310         * guile/scm-lazy-string.c: Update.
8311         * guile/scm-math.c: Update.
8312         * guile/scm-param.c: Update.
8313         * guile/scm-ports.c: Update.
8314         * guile/scm-pretty-print.c: Update.
8315         * guile/scm-symbol.c: Update.
8316         * guile/scm-symtab.c: Update.
8317         * guile/scm-type.c: Update.
8318         * guile/scm-value.c: Update.
8319         * i386-linux-tdep.c: Update.
8320         * i386-tdep.c: Update.
8321         * inf-loop.c: Update.
8322         * infcall.c: Update.
8323         * infcmd.c: Update.
8324         * infrun.c: Update.
8325         * jit.c: Update.
8326         * language.c: Update.
8327         * linespec.c: Update.
8328         * linux-fork.c: Update.
8329         * linux-nat.c: Update.
8330         * linux-tdep.c: Update.
8331         * linux-thread-db.c: Update.
8332         * main.c: Update.
8333         * mi/mi-cmd-break.c: Update.
8334         * mi/mi-cmd-stack.c: Update.
8335         * mi/mi-interp.c: Update.
8336         * mi/mi-main.c: Update.
8337         * objc-lang.c: Update.
8338         * p-valprint.c: Update.
8339         * parse.c: Update.
8340         * ppc-linux-tdep.c: Update.
8341         * printcmd.c: Update.
8342         * python/py-arch.c: Update.
8343         * python/py-breakpoint.c: Update.
8344         * python/py-cmd.c: Update.
8345         * python/py-finishbreakpoint.c: Update.
8346         * python/py-frame.c: Update.
8347         * python/py-framefilter.c: Update.
8348         * python/py-gdb-readline.c: Update.
8349         * python/py-inferior.c: Update.
8350         * python/py-infthread.c: Update.
8351         * python/py-lazy-string.c: Update.
8352         * python/py-linetable.c: Update.
8353         * python/py-objfile.c: Update.
8354         * python/py-param.c: Update.
8355         * python/py-prettyprint.c: Update.
8356         * python/py-progspace.c: Update.
8357         * python/py-record-btrace.c: Update.
8358         * python/py-record.c: Update.
8359         * python/py-symbol.c: Update.
8360         * python/py-type.c: Update.
8361         * python/py-unwind.c: Update.
8362         * python/py-utils.c: Update.
8363         * python/py-value.c: Update.
8364         * python/python.c: Update.
8365         * record-btrace.c: Update.
8366         * record-full.c: Update.
8367         * remote-fileio.c: Update.
8368         * remote.c: Update.
8369         * riscv-tdep.c: Update.
8370         * rs6000-aix-tdep.c: Update.
8371         * rs6000-tdep.c: Update.
8372         * rust-exp.y: Update.
8373         * rust-lang.c: Update.
8374         * s390-tdep.c: Update.
8375         * selftest-arch.c: Update.
8376         * solib-dsbt.c: Update.
8377         * solib-frv.c: Update.
8378         * solib-spu.c: Update.
8379         * solib-svr4.c: Update.
8380         * solib.c: Update.
8381         * sparc64-linux-tdep.c: Update.
8382         * stack.c: Update.
8383         * symfile-mem.c: Update.
8384         * symmisc.c: Update.
8385         * target.c: Update.
8386         * thread.c: Update.
8387         * top.c: Update.
8388         * tracefile-tfile.c: Update.
8389         * tui/tui.c: Update.
8390         * typeprint.c: Update.
8391         * unittests/cli-utils-selftests.c: Update.
8392         * unittests/parse-connection-spec-selftests.c: Update.
8393         * valops.c: Update.
8394         * valprint.c: Update.
8395         * value.c: Update.
8396         * varobj.c: Update.
8397         * windows-nat.c: Update.
8398         * x86-linux-nat.c: Update.
8399         * xml-support.c: Update.
8400
8401 2019-04-08  Tom Tromey  <tom@tromey.com>
8402
8403         * xml-support.c: Use C++ exception handling.
8404         * x86-linux-nat.c: Use C++ exception handling.
8405         * windows-nat.c: Use C++ exception handling.
8406         * varobj.c: Use C++ exception handling.
8407         * value.c: Use C++ exception handling.
8408         * valprint.c: Use C++ exception handling.
8409         * valops.c: Use C++ exception handling.
8410         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8411         handling.
8412         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8413         * typeprint.c: Use C++ exception handling.
8414         * tui/tui.c: Use C++ exception handling.
8415         * tracefile-tfile.c: Use C++ exception handling.
8416         * top.c: Use C++ exception handling.
8417         * thread.c: Use C++ exception handling.
8418         * target.c: Use C++ exception handling.
8419         * symmisc.c: Use C++ exception handling.
8420         * symfile-mem.c: Use C++ exception handling.
8421         * stack.c: Use C++ exception handling.
8422         * sparc64-linux-tdep.c: Use C++ exception handling.
8423         * solib.c: Use C++ exception handling.
8424         * solib-svr4.c: Use C++ exception handling.
8425         * solib-spu.c: Use C++ exception handling.
8426         * solib-frv.c: Use C++ exception handling.
8427         * solib-dsbt.c: Use C++ exception handling.
8428         * selftest-arch.c: Use C++ exception handling.
8429         * s390-tdep.c: Use C++ exception handling.
8430         * rust-lang.c: Use C++ exception handling.
8431         * rust-exp.y: Use C++ exception handling.
8432         * rs6000-tdep.c: Use C++ exception handling.
8433         * rs6000-aix-tdep.c: Use C++ exception handling.
8434         * riscv-tdep.c: Use C++ exception handling.
8435         * remote.c: Use C++ exception handling.
8436         * remote-fileio.c: Use C++ exception handling.
8437         * record-full.c: Use C++ exception handling.
8438         * record-btrace.c: Use C++ exception handling.
8439         * python/python.c: Use C++ exception handling.
8440         * python/py-value.c: Use C++ exception handling.
8441         * python/py-utils.c: Use C++ exception handling.
8442         * python/py-unwind.c: Use C++ exception handling.
8443         * python/py-type.c: Use C++ exception handling.
8444         * python/py-symbol.c: Use C++ exception handling.
8445         * python/py-record.c: Use C++ exception handling.
8446         * python/py-record-btrace.c: Use C++ exception handling.
8447         * python/py-progspace.c: Use C++ exception handling.
8448         * python/py-prettyprint.c: Use C++ exception handling.
8449         * python/py-param.c: Use C++ exception handling.
8450         * python/py-objfile.c: Use C++ exception handling.
8451         * python/py-linetable.c: Use C++ exception handling.
8452         * python/py-lazy-string.c: Use C++ exception handling.
8453         * python/py-infthread.c: Use C++ exception handling.
8454         * python/py-inferior.c: Use C++ exception handling.
8455         * python/py-gdb-readline.c: Use C++ exception handling.
8456         * python/py-framefilter.c: Use C++ exception handling.
8457         * python/py-frame.c: Use C++ exception handling.
8458         * python/py-finishbreakpoint.c: Use C++ exception handling.
8459         * python/py-cmd.c: Use C++ exception handling.
8460         * python/py-breakpoint.c: Use C++ exception handling.
8461         * python/py-arch.c: Use C++ exception handling.
8462         * printcmd.c: Use C++ exception handling.
8463         * ppc-linux-tdep.c: Use C++ exception handling.
8464         * parse.c: Use C++ exception handling.
8465         * p-valprint.c: Use C++ exception handling.
8466         * objc-lang.c: Use C++ exception handling.
8467         * mi/mi-main.c: Use C++ exception handling.
8468         * mi/mi-interp.c: Use C++ exception handling.
8469         * mi/mi-cmd-stack.c: Use C++ exception handling.
8470         * mi/mi-cmd-break.c: Use C++ exception handling.
8471         * main.c: Use C++ exception handling.
8472         * linux-thread-db.c: Use C++ exception handling.
8473         * linux-tdep.c: Use C++ exception handling.
8474         * linux-nat.c: Use C++ exception handling.
8475         * linux-fork.c: Use C++ exception handling.
8476         * linespec.c: Use C++ exception handling.
8477         * language.c: Use C++ exception handling.
8478         * jit.c: Use C++ exception handling.
8479         * infrun.c: Use C++ exception handling.
8480         * infcmd.c: Use C++ exception handling.
8481         * infcall.c: Use C++ exception handling.
8482         * inf-loop.c: Use C++ exception handling.
8483         * i386-tdep.c: Use C++ exception handling.
8484         * i386-linux-tdep.c: Use C++ exception handling.
8485         * guile/scm-value.c: Use C++ exception handling.
8486         * guile/scm-type.c: Use C++ exception handling.
8487         * guile/scm-symtab.c: Use C++ exception handling.
8488         * guile/scm-symbol.c: Use C++ exception handling.
8489         * guile/scm-pretty-print.c: Use C++ exception handling.
8490         * guile/scm-ports.c: Use C++ exception handling.
8491         * guile/scm-param.c: Use C++ exception handling.
8492         * guile/scm-math.c: Use C++ exception handling.
8493         * guile/scm-lazy-string.c: Use C++ exception handling.
8494         * guile/scm-frame.c: Use C++ exception handling.
8495         * guile/scm-disasm.c: Use C++ exception handling.
8496         * guile/scm-cmd.c: Use C++ exception handling.
8497         * guile/scm-breakpoint.c: Use C++ exception handling.
8498         * guile/scm-block.c: Use C++ exception handling.
8499         * guile/guile-internal.h: Use C++ exception handling.
8500         * gnu-v3-abi.c: Use C++ exception handling.
8501         * gdbtypes.c: Use C++ exception handling.
8502         * frame.c: Use C++ exception handling.
8503         * frame-unwind.c: Use C++ exception handling.
8504         * fbsd-tdep.c: Use C++ exception handling.
8505         * f-valprint.c: Use C++ exception handling.
8506         * exec.c: Use C++ exception handling.
8507         * event-top.c: Use C++ exception handling.
8508         * event-loop.c: Use C++ exception handling.
8509         * eval.c: Use C++ exception handling.
8510         * dwarf2read.c: Use C++ exception handling.
8511         * dwarf2loc.c: Use C++ exception handling.
8512         * dwarf2-frame.c: Use C++ exception handling.
8513         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8514         * dwarf-index-write.c: Use C++ exception handling.
8515         * dwarf-index-cache.c: Use C++ exception handling.
8516         * dtrace-probe.c: Use C++ exception handling.
8517         * disasm-selftests.c: Use C++ exception handling.
8518         * darwin-nat.c: Use C++ exception handling.
8519         * cp-valprint.c: Use C++ exception handling.
8520         * cp-support.c: Use C++ exception handling.
8521         * cp-abi.c: Use C++ exception handling.
8522         * corelow.c: Use C++ exception handling.
8523         * completer.c: Use C++ exception handling.
8524         * compile/compile-object-run.c: Use C++ exception handling.
8525         * compile/compile-object-load.c: Use C++ exception handling.
8526         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8527         * compile/compile-c-symbols.c: Use C++ exception handling.
8528         * common/selftest.c: Use C++ exception handling.
8529         * common/new-op.c: Use C++ exception handling.
8530         * cli/cli-script.c: Use C++ exception handling.
8531         * cli/cli-interp.c: Use C++ exception handling.
8532         * cli/cli-cmds.c: Use C++ exception handling.
8533         * c-varobj.c: Use C++ exception handling.
8534         * btrace.c: Use C++ exception handling.
8535         * breakpoint.c: Use C++ exception handling.
8536         * break-catch-throw.c: Use C++ exception handling.
8537         * arch-utils.c: Use C++ exception handling.
8538         * amd64-tdep.c: Use C++ exception handling.
8539         * ada-valprint.c: Use C++ exception handling.
8540         * ada-typeprint.c: Use C++ exception handling.
8541         * ada-lang.c: Use C++ exception handling.
8542         * aarch64-tdep.c: Use C++ exception handling.
8543
8544 2019-04-08  Tom Tromey  <tom@tromey.com>
8545
8546         * xml-support.c (gdb_xml_parser::parse): Update.
8547         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8548         * value.c (show_convenience): Update.
8549         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8550         (test_parse_flags_qcs): Update.
8551         * thread.c (thr_try_catch_cmd): Update.
8552         * target.c (target_translate_tls_address): Update.
8553         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8554         (info_frame_command_core, frame_apply_command_count): Update.
8555         * rust-exp.y (rust_lex_exception_test): Update.
8556         * riscv-tdep.c (riscv_print_one_register_info): Update.
8557         * remote.c (remote_target::enable_btrace): Update.
8558         * record-btrace.c (record_btrace_enable_warn): Update.
8559         * python/py-utils.c (gdbpy_convert_exception): Update.
8560         * printcmd.c (do_one_display, print_variable_and_value): Update.
8561         * mi/mi-main.c (mi_print_exception): Update.
8562         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8563         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8564         * linux-nat.c (linux_nat_target::attach): Update.
8565         * linux-fork.c (class scoped_switch_fork_info): Update.
8566         * infrun.c (displaced_step_prepare): Update.
8567         * infcall.c (call_function_by_hand_dummy): Update.
8568         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8569         * gnu-v3-abi.c (print_one_vtable): Update.
8570         * frame.c (get_prev_frame_always): Update.
8571         * f-valprint.c (info_common_command_for_block): Update.
8572         * exec.c (try_open_exec_file): Update.
8573         * exceptions.c (print_exception, exception_print)
8574         (exception_fprintf, exception_print_same): Update.
8575         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8576         * dwarf-index-cache.c (index_cache::store)
8577         (index_cache::lookup_gdb_index): Update.
8578         * darwin-nat.c (maybe_cache_shell): Update.
8579         * cp-valprint.c (cp_print_value_fields): Update.
8580         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8581         (gcc_cplus_symbol_address): Update.
8582         * compile/compile-c-symbols.c (gcc_convert_symbol)
8583         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8584         * common/selftest.c: Update.
8585         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8586         a std::string.
8587         (exception_try_scope_entry, exception_try_scope_exit): Don't
8588         declare.
8589         (struct exception_try_scope): Remove.
8590         (TRY): Don't use exception_try_scope.
8591         (struct gdb_exception): Add constructor, operator=.
8592         <what>: New method.
8593         (struct gdb_exception_RETURN_MASK_ALL)
8594         (struct gdb_exception_RETURN_MASK_ERROR)
8595         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8596         (struct gdb_quit_bad_alloc): Update.
8597         * common/common-exceptions.c (exception_none): Change
8598         initializer.
8599         (struct catcher) <state, exception>: Initialize inline.
8600         <prev>: Remove member.
8601         (current_catcher): Remove.
8602         (catchers): New global.
8603         (exceptions_state_mc_init): Simplify.
8604         (catcher_pop): Remove.
8605         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8606         (try_scope_depth, exception_try_scope_entry)
8607         (exception_try_scope_exit): Remove.
8608         (throw_exception_sjlj): Update.
8609         (exception_messages, exception_messages_size): Remove.
8610         (throw_it): Simplify.
8611         (gdb_exception_sliced_copy): Remove.
8612         (throw_exception_cxx): Update.
8613         * cli/cli-script.c (script_from_file): Update.
8614         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8615         Update.
8616         * ada-valprint.c (ada_val_print): Update.
8617         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8618         (create_excep_cond_exprs): Update.
8619
8620 2019-04-08  Tom Tromey  <tom@tromey.com>
8621
8622         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8623         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8624         (TRY, CATCH, END_CATCH): Remove some definitions.
8625         * common/common-exceptions.c: Don't use GDB_XCPT.
8626         (catcher_list_size): Remove.
8627         (throw_exception, throw_it): Simplify.
8628
8629 2019-04-05  Tom Tromey  <tom@tromey.com>
8630
8631         Revert the header-sorting patch.
8632         * ft32-tdep.c: Revert.
8633         * frv-tdep.c: Revert.
8634         * frv-linux-tdep.c: Revert.
8635         * frame.c: Revert.
8636         * frame-unwind.c: Revert.
8637         * frame-base.c: Revert.
8638         * fork-child.c: Revert.
8639         * findvar.c: Revert.
8640         * findcmd.c: Revert.
8641         * filesystem.c: Revert.
8642         * filename-seen-cache.h: Revert.
8643         * filename-seen-cache.c: Revert.
8644         * fbsd-tdep.c: Revert.
8645         * fbsd-nat.h: Revert.
8646         * fbsd-nat.c: Revert.
8647         * f-valprint.c: Revert.
8648         * f-typeprint.c: Revert.
8649         * f-lang.c: Revert.
8650         * extension.h: Revert.
8651         * extension.c: Revert.
8652         * extension-priv.h: Revert.
8653         * expprint.c: Revert.
8654         * exec.h: Revert.
8655         * exec.c: Revert.
8656         * exceptions.c: Revert.
8657         * event-top.c: Revert.
8658         * event-loop.c: Revert.
8659         * eval.c: Revert.
8660         * elfread.c: Revert.
8661         * dwarf2read.h: Revert.
8662         * dwarf2read.c: Revert.
8663         * dwarf2loc.c: Revert.
8664         * dwarf2expr.h: Revert.
8665         * dwarf2expr.c: Revert.
8666         * dwarf2-frame.c: Revert.
8667         * dwarf2-frame-tailcall.c: Revert.
8668         * dwarf-index-write.h: Revert.
8669         * dwarf-index-write.c: Revert.
8670         * dwarf-index-common.c: Revert.
8671         * dwarf-index-cache.h: Revert.
8672         * dwarf-index-cache.c: Revert.
8673         * dummy-frame.c: Revert.
8674         * dtrace-probe.c: Revert.
8675         * disasm.h: Revert.
8676         * disasm.c: Revert.
8677         * disasm-selftests.c: Revert.
8678         * dictionary.c: Revert.
8679         * dicos-tdep.c: Revert.
8680         * demangle.c: Revert.
8681         * dcache.h: Revert.
8682         * dcache.c: Revert.
8683         * darwin-nat.h: Revert.
8684         * darwin-nat.c: Revert.
8685         * darwin-nat-info.c: Revert.
8686         * d-valprint.c: Revert.
8687         * d-namespace.c: Revert.
8688         * d-lang.c: Revert.
8689         * ctf.c: Revert.
8690         * csky-tdep.c: Revert.
8691         * csky-linux-tdep.c: Revert.
8692         * cris-tdep.c: Revert.
8693         * cris-linux-tdep.c: Revert.
8694         * cp-valprint.c: Revert.
8695         * cp-support.c: Revert.
8696         * cp-namespace.c: Revert.
8697         * cp-abi.c: Revert.
8698         * corelow.c: Revert.
8699         * corefile.c: Revert.
8700         * continuations.c: Revert.
8701         * completer.h: Revert.
8702         * completer.c: Revert.
8703         * complaints.c: Revert.
8704         * coffread.c: Revert.
8705         * coff-pe-read.c: Revert.
8706         * cli-out.h: Revert.
8707         * cli-out.c: Revert.
8708         * charset.c: Revert.
8709         * c-varobj.c: Revert.
8710         * c-valprint.c: Revert.
8711         * c-typeprint.c: Revert.
8712         * c-lang.c: Revert.
8713         * buildsym.c: Revert.
8714         * buildsym-legacy.c: Revert.
8715         * build-id.h: Revert.
8716         * build-id.c: Revert.
8717         * btrace.c: Revert.
8718         * bsd-uthread.c: Revert.
8719         * breakpoint.h: Revert.
8720         * breakpoint.c: Revert.
8721         * break-catch-throw.c: Revert.
8722         * break-catch-syscall.c: Revert.
8723         * break-catch-sig.c: Revert.
8724         * blockframe.c: Revert.
8725         * block.c: Revert.
8726         * bfin-tdep.c: Revert.
8727         * bfin-linux-tdep.c: Revert.
8728         * bfd-target.c: Revert.
8729         * bcache.c: Revert.
8730         * ax-general.c: Revert.
8731         * ax-gdb.h: Revert.
8732         * ax-gdb.c: Revert.
8733         * avr-tdep.c: Revert.
8734         * auxv.c: Revert.
8735         * auto-load.c: Revert.
8736         * arm-wince-tdep.c: Revert.
8737         * arm-tdep.c: Revert.
8738         * arm-symbian-tdep.c: Revert.
8739         * arm-pikeos-tdep.c: Revert.
8740         * arm-obsd-tdep.c: Revert.
8741         * arm-nbsd-tdep.c: Revert.
8742         * arm-nbsd-nat.c: Revert.
8743         * arm-linux-tdep.c: Revert.
8744         * arm-linux-nat.c: Revert.
8745         * arm-fbsd-tdep.c: Revert.
8746         * arm-fbsd-nat.c: Revert.
8747         * arm-bsd-tdep.c: Revert.
8748         * arch-utils.c: Revert.
8749         * arc-tdep.c: Revert.
8750         * arc-newlib-tdep.c: Revert.
8751         * annotate.h: Revert.
8752         * annotate.c: Revert.
8753         * amd64-windows-tdep.c: Revert.
8754         * amd64-windows-nat.c: Revert.
8755         * amd64-tdep.c: Revert.
8756         * amd64-sol2-tdep.c: Revert.
8757         * amd64-obsd-tdep.c: Revert.
8758         * amd64-obsd-nat.c: Revert.
8759         * amd64-nbsd-tdep.c: Revert.
8760         * amd64-nbsd-nat.c: Revert.
8761         * amd64-nat.c: Revert.
8762         * amd64-linux-tdep.c: Revert.
8763         * amd64-linux-nat.c: Revert.
8764         * amd64-fbsd-tdep.c: Revert.
8765         * amd64-fbsd-nat.c: Revert.
8766         * amd64-dicos-tdep.c: Revert.
8767         * amd64-darwin-tdep.c: Revert.
8768         * amd64-bsd-nat.c: Revert.
8769         * alpha-tdep.c: Revert.
8770         * alpha-obsd-tdep.c: Revert.
8771         * alpha-nbsd-tdep.c: Revert.
8772         * alpha-mdebug-tdep.c: Revert.
8773         * alpha-linux-tdep.c: Revert.
8774         * alpha-linux-nat.c: Revert.
8775         * alpha-bsd-tdep.c: Revert.
8776         * alpha-bsd-nat.c: Revert.
8777         * aix-thread.c: Revert.
8778         * agent.c: Revert.
8779         * addrmap.c: Revert.
8780         * ada-varobj.c: Revert.
8781         * ada-valprint.c: Revert.
8782         * ada-typeprint.c: Revert.
8783         * ada-tasks.c: Revert.
8784         * ada-lang.c: Revert.
8785         * aarch64-tdep.c: Revert.
8786         * aarch64-ravenscar-thread.c: Revert.
8787         * aarch64-newlib-tdep.c: Revert.
8788         * aarch64-linux-tdep.c: Revert.
8789         * aarch64-linux-nat.c: Revert.
8790         * aarch64-fbsd-tdep.c: Revert.
8791         * aarch64-fbsd-nat.c: Revert.
8792         * aarch32-linux-nat.c: Revert.
8793
8794 2019-04-05  Tom Tromey  <tom@tromey.com>
8795
8796         * ft32-tdep.c: Sort headers.
8797         * frv-tdep.c: Sort headers.
8798         * frv-linux-tdep.c: Sort headers.
8799         * frame.c: Sort headers.
8800         * frame-unwind.c: Sort headers.
8801         * frame-base.c: Sort headers.
8802         * fork-child.c: Sort headers.
8803         * findvar.c: Sort headers.
8804         * findcmd.c: Sort headers.
8805         * filesystem.c: Sort headers.
8806         * filename-seen-cache.h: Sort headers.
8807         * filename-seen-cache.c: Sort headers.
8808         * fbsd-tdep.c: Sort headers.
8809         * fbsd-nat.h: Sort headers.
8810         * fbsd-nat.c: Sort headers.
8811         * f-valprint.c: Sort headers.
8812         * f-typeprint.c: Sort headers.
8813         * f-lang.c: Sort headers.
8814         * extension.h: Sort headers.
8815         * extension.c: Sort headers.
8816         * extension-priv.h: Sort headers.
8817         * expprint.c: Sort headers.
8818         * exec.h: Sort headers.
8819         * exec.c: Sort headers.
8820         * exceptions.c: Sort headers.
8821         * event-top.c: Sort headers.
8822         * event-loop.c: Sort headers.
8823         * eval.c: Sort headers.
8824         * elfread.c: Sort headers.
8825         * dwarf2read.h: Sort headers.
8826         * dwarf2read.c: Sort headers.
8827         * dwarf2loc.c: Sort headers.
8828         * dwarf2expr.h: Sort headers.
8829         * dwarf2expr.c: Sort headers.
8830         * dwarf2-frame.c: Sort headers.
8831         * dwarf2-frame-tailcall.c: Sort headers.
8832         * dwarf-index-write.h: Sort headers.
8833         * dwarf-index-write.c: Sort headers.
8834         * dwarf-index-common.c: Sort headers.
8835         * dwarf-index-cache.h: Sort headers.
8836         * dwarf-index-cache.c: Sort headers.
8837         * dummy-frame.c: Sort headers.
8838         * dtrace-probe.c: Sort headers.
8839         * disasm.h: Sort headers.
8840         * disasm.c: Sort headers.
8841         * disasm-selftests.c: Sort headers.
8842         * dictionary.c: Sort headers.
8843         * dicos-tdep.c: Sort headers.
8844         * demangle.c: Sort headers.
8845         * dcache.h: Sort headers.
8846         * dcache.c: Sort headers.
8847         * darwin-nat.h: Sort headers.
8848         * darwin-nat.c: Sort headers.
8849         * darwin-nat-info.c: Sort headers.
8850         * d-valprint.c: Sort headers.
8851         * d-namespace.c: Sort headers.
8852         * d-lang.c: Sort headers.
8853         * ctf.c: Sort headers.
8854         * csky-tdep.c: Sort headers.
8855         * csky-linux-tdep.c: Sort headers.
8856         * cris-tdep.c: Sort headers.
8857         * cris-linux-tdep.c: Sort headers.
8858         * cp-valprint.c: Sort headers.
8859         * cp-support.c: Sort headers.
8860         * cp-namespace.c: Sort headers.
8861         * cp-abi.c: Sort headers.
8862         * corelow.c: Sort headers.
8863         * corefile.c: Sort headers.
8864         * continuations.c: Sort headers.
8865         * completer.h: Sort headers.
8866         * completer.c: Sort headers.
8867         * complaints.c: Sort headers.
8868         * coffread.c: Sort headers.
8869         * coff-pe-read.c: Sort headers.
8870         * cli-out.h: Sort headers.
8871         * cli-out.c: Sort headers.
8872         * charset.c: Sort headers.
8873         * c-varobj.c: Sort headers.
8874         * c-valprint.c: Sort headers.
8875         * c-typeprint.c: Sort headers.
8876         * c-lang.c: Sort headers.
8877         * buildsym.c: Sort headers.
8878         * buildsym-legacy.c: Sort headers.
8879         * build-id.h: Sort headers.
8880         * build-id.c: Sort headers.
8881         * btrace.c: Sort headers.
8882         * bsd-uthread.c: Sort headers.
8883         * breakpoint.h: Sort headers.
8884         * breakpoint.c: Sort headers.
8885         * break-catch-throw.c: Sort headers.
8886         * break-catch-syscall.c: Sort headers.
8887         * break-catch-sig.c: Sort headers.
8888         * blockframe.c: Sort headers.
8889         * block.c: Sort headers.
8890         * bfin-tdep.c: Sort headers.
8891         * bfin-linux-tdep.c: Sort headers.
8892         * bfd-target.c: Sort headers.
8893         * bcache.c: Sort headers.
8894         * ax-general.c: Sort headers.
8895         * ax-gdb.h: Sort headers.
8896         * ax-gdb.c: Sort headers.
8897         * avr-tdep.c: Sort headers.
8898         * auxv.c: Sort headers.
8899         * auto-load.c: Sort headers.
8900         * arm-wince-tdep.c: Sort headers.
8901         * arm-tdep.c: Sort headers.
8902         * arm-symbian-tdep.c: Sort headers.
8903         * arm-pikeos-tdep.c: Sort headers.
8904         * arm-obsd-tdep.c: Sort headers.
8905         * arm-nbsd-tdep.c: Sort headers.
8906         * arm-nbsd-nat.c: Sort headers.
8907         * arm-linux-tdep.c: Sort headers.
8908         * arm-linux-nat.c: Sort headers.
8909         * arm-fbsd-tdep.c: Sort headers.
8910         * arm-fbsd-nat.c: Sort headers.
8911         * arm-bsd-tdep.c: Sort headers.
8912         * arch-utils.c: Sort headers.
8913         * arc-tdep.c: Sort headers.
8914         * arc-newlib-tdep.c: Sort headers.
8915         * annotate.h: Sort headers.
8916         * annotate.c: Sort headers.
8917         * amd64-windows-tdep.c: Sort headers.
8918         * amd64-windows-nat.c: Sort headers.
8919         * amd64-tdep.c: Sort headers.
8920         * amd64-sol2-tdep.c: Sort headers.
8921         * amd64-obsd-tdep.c: Sort headers.
8922         * amd64-obsd-nat.c: Sort headers.
8923         * amd64-nbsd-tdep.c: Sort headers.
8924         * amd64-nbsd-nat.c: Sort headers.
8925         * amd64-nat.c: Sort headers.
8926         * amd64-linux-tdep.c: Sort headers.
8927         * amd64-linux-nat.c: Sort headers.
8928         * amd64-fbsd-tdep.c: Sort headers.
8929         * amd64-fbsd-nat.c: Sort headers.
8930         * amd64-dicos-tdep.c: Sort headers.
8931         * amd64-darwin-tdep.c: Sort headers.
8932         * amd64-bsd-nat.c: Sort headers.
8933         * alpha-tdep.c: Sort headers.
8934         * alpha-obsd-tdep.c: Sort headers.
8935         * alpha-nbsd-tdep.c: Sort headers.
8936         * alpha-mdebug-tdep.c: Sort headers.
8937         * alpha-linux-tdep.c: Sort headers.
8938         * alpha-linux-nat.c: Sort headers.
8939         * alpha-bsd-tdep.c: Sort headers.
8940         * alpha-bsd-nat.c: Sort headers.
8941         * aix-thread.c: Sort headers.
8942         * agent.c: Sort headers.
8943         * addrmap.c: Sort headers.
8944         * ada-varobj.c: Sort headers.
8945         * ada-valprint.c: Sort headers.
8946         * ada-typeprint.c: Sort headers.
8947         * ada-tasks.c: Sort headers.
8948         * ada-lang.c: Sort headers.
8949         * aarch64-tdep.c: Sort headers.
8950         * aarch64-ravenscar-thread.c: Sort headers.
8951         * aarch64-newlib-tdep.c: Sort headers.
8952         * aarch64-linux-tdep.c: Sort headers.
8953         * aarch64-linux-nat.c: Sort headers.
8954         * aarch64-fbsd-tdep.c: Sort headers.
8955         * aarch64-fbsd-nat.c: Sort headers.
8956         * aarch32-linux-nat.c: Sort headers.
8957
8958 2019-04-04  Tom Tromey  <tom@tromey.com>
8959
8960         * varobj.c (varobj_create): Update.
8961         * rust-exp.y (struct rust_parser) <update_innermost_block,
8962         lookup_symbol>: New methods.
8963         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
8964         Rename.
8965         (rust_parser::rust_lookup_type)
8966         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
8967         * printcmd.c (display_command, do_one_display): Update.
8968         * parser-defs.h (struct parser_state) <parser_state>: Add
8969         "tracker" parameter.
8970         (block_tracker): New member.
8971         (class innermost_block_tracker) <innermost_block_tracker>: Add
8972         "types" parameter.
8973         <reset>: Remove method.
8974         (innermost_block): Don't declare.
8975         (null_post_parser): Update.
8976         * parse.c (innermost_block): Remove global.
8977         (write_dollar_variable): Update.
8978         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
8979         Remove "tracker_types" parameter.
8980         (parse_expression): Add "tracker" parameter.
8981         (parse_expression_for_completion): Update.
8982         (null_post_parser): Add "tracker" parameter.
8983         * p-exp.y: Update rules.
8984         * m2-exp.y: Update rules.
8985         * language.h (struct language_defn) <la_post_parser>: Add
8986         "tracker" parameter.
8987         * go-exp.y: Update rules.
8988         * f-exp.y: Update rules.
8989         * expression.h (parse_expression, parse_exp_1): Add "tracker"
8990         parameter.
8991         * d-exp.y: Update rules.
8992         * c-exp.y: Update rules.
8993         * breakpoint.c (set_breakpoint_condition): Create an
8994         innermost_block_tracker.
8995         (watch_command_1): Likewise.
8996         * ada-lang.c (resolve): Add "tracker" parameter.
8997         (resolve_subexp): Likewise.
8998         * ada-exp.y (write_var_from_sym): Update.
8999
9000 2019-04-04  Tom Tromey  <tom@tromey.com>
9001
9002         * type-stack.h: New file.
9003         * type-stack.c: New file.
9004         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9005         type-stack.h.
9006         (insert_into_type_stack, insert_type, push_type, push_type_int)
9007         (insert_type_address_space, pop_type, pop_type_int)
9008         (pop_typelist, pop_type_stack, append_type_stack)
9009         (push_type_stack, get_type_stack, push_typelist)
9010         (follow_type_instance_flags, follow_types): Don't declare.
9011         * parse.c (type_stack): Remove global.
9012         (parse_exp_in_context): Update.
9013         (insert_into_type_stack, insert_type, push_type, push_type_int)
9014         (insert_type_address_space, pop_type, pop_type_int)
9015         (pop_typelist, pop_type_stack, append_type_stack)
9016         (push_type_stack, get_type_stack, push_typelist)
9017         (follow_type_instance_flags, follow_types): Remove (moved to
9018         type-stack.c).
9019         * f-exp.y (type_stack): New global.
9020         Update rules.
9021         (push_kind_type, f_parse): Update.
9022         * d-exp.y (type_stack): New global.
9023         Update rules.
9024         (d_parse): Update.
9025         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9026         Update rules.
9027         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9028         (HFILES_NO_SRCDIR): Add type-stack.h.
9029
9030 2019-04-04  Tom Tromey  <tom@tromey.com>
9031
9032         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9033         (rust_parser::convert_ast_to_expression, rust_parse)
9034         (rust_lex_test_completion, rust_lex_tests): Update.
9035         * parser-defs.h (struct expr_completion_state): New.
9036         (struct parser_state) <parser_state>: Add completion parameter.
9037         <mark_struct_expression, mark_completion_tag>: New methods.
9038         <parse_completion, m_completion_state>: New members.
9039         (prefixify_expression, null_post_parser): Update.
9040         (mark_struct_expression, mark_completion_tag): Don't declare.
9041         * parse.c (parse_completion, expout_last_struct)
9042         (expout_tag_completion_type, expout_completion_name): Remove
9043         globals.
9044         (parser_state::mark_struct_expression)
9045         (parser_state::mark_completion_tag): Now methods.
9046         (prefixify_expression): Add last_struct parameter.
9047         (prefixify_subexp): Likewise.
9048         (parse_exp_1): Update.
9049         (parse_exp_in_context): Add cstate parameter.  Update.
9050         (parse_expression_for_completion): Create an
9051         expr_completion_state.
9052         (null_post_parser): Add "completion" parameter.
9053         * p-exp.y: Update rules.
9054         (yylex): Update.
9055         * language.h (struct language_defn) <la_post_parser>: Add
9056         "completing" parameter.
9057         * go-exp.y: Update rules.
9058         (lex_one_token): Update.
9059         * expression.h (parse_completion): Don't declare.
9060         * d-exp.y: Update rules.
9061         (lex_one_token): Update rules.
9062         * c-exp.y: Update rules.
9063         (lex_one_token): Update.
9064         * ada-lang.c (resolve): Add "parse_completion" parameter.
9065         (resolve_subexp): Likewise.
9066         (ada_resolve_function): Likewise.
9067
9068 2019-04-04  Tom Tromey  <tom@tromey.com>
9069
9070         * parser-defs.h (struct parser_state) <start_arglist,
9071         end_arglist>: New methods.
9072         <arglist_len, m_funcall_chain>: New members.
9073         (arglist_len, start_arglist, end_arglist): Don't declare.
9074         * parse.c (arglist_len, funcall_chain): Remove global.
9075         (start_arglist, end_arglist): Remove functions.
9076         (parse_exp_in_context): Update.
9077         * p-exp.y: Update rules.
9078         * m2-exp.y: Update rules.
9079         * go-exp.y: Update rules.
9080         * f-exp.y: Update rules.
9081         * d-exp.y: Update rules.
9082         * c-exp.y: Update rules.
9083
9084 2019-04-04  Tom Tromey  <tom@tromey.com>
9085
9086         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9087         lex_operator, push_back>: New methods.
9088         Update all rules.
9089         (rust_parser::lex_hex, lex_escape): Rename and update.
9090         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9091         (rust_parser::lex_operator): Rename and update.
9092         (rust_parser::lex_number, rustyylex, rustyyerror)
9093         (rust_lex_test_init, rust_lex_test_sequence)
9094         (rust_lex_test_push_back, rust_lex_tests): Update.
9095         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9096         parameter.
9097         <lexptr, prev_lexptr>: New members.
9098         (lexptr, prev_lexptr): Don't declare.
9099         * parse.c (lexptr, prev_lexptr): Remove globals.
9100         (parse_exp_in_context): Update.
9101         * p-exp.y (yylex, yyerror): Update.
9102         * m2-exp.y (parse_number, yylex, yyerror): Update.
9103         * go-exp.y (lex_one_token, yyerror): Update.
9104         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9105         * d-exp.y (lex_one_token, yyerror): Update.
9106         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9107         (lex_one_token, yyerror): Update.
9108         * ada-lex.l (YY_INPUT): Update.
9109         (rewind_to_char): Update.
9110         * ada-exp.y (yyerror): Update.
9111
9112 2019-04-04  Tom Tromey  <tom@tromey.com>
9113
9114         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9115         * parser-defs.h (struct parser_state) <parser_state>: Add new
9116         parameter.
9117         <comma_terminates>: New member.
9118         (comma_terminates): Don't declare global.
9119         * parse.c (comma_terminates): Remove global.
9120         (parse_exp_in_context): Update.
9121         * p-exp.y (yylex): Update.
9122         * m2-exp.y (yylex): Update.
9123         * go-exp.y (lex_one_token): Update.
9124         * f-exp.y (yylex): Update.
9125         * d-exp.y (lex_one_token): Update.
9126         * c-exp.y (lex_one_token): Update.
9127         * ada-lex.l: Update.
9128
9129 2019-04-04  Tom Tromey  <tom@tromey.com>
9130
9131         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9132         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9133         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9134         * parser-defs.h (paren_depth): Don't declare.
9135         * parse.c (paren_depth): Remove global.
9136         (parse_exp_in_context): Update.
9137         * p-exp.y (paren_depth): New global.
9138         (pascal_parse): Initialize it.
9139         * m2-exp.y (paren_depth): New global.
9140         (m2_parse): Initialize it.
9141         * go-exp.y (paren_depth): New global.
9142         (go_parse): Initialize it.
9143         * f-exp.y (paren_depth): New global.
9144         (f_parse): Initialize it.
9145         * d-exp.y (paren_depth): New global.
9146         (d_parse): Initialize it.
9147         * c-exp.y (paren_depth): New global.
9148         (c_parse): Initialize it.
9149         * ada-lex.l (paren_depth): New global.
9150         (lexer_init): Initialize it.
9151
9152 2019-04-04  Tom Tromey  <tom@tromey.com>
9153
9154         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9155         (rust_parser::convert_ast_to_type)
9156         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9157         * parser-defs.h (struct parser_state) <parser_state>: Add
9158         parameters.  Initialize new members.
9159         <expression_context_block, expression_context_pc>: New members.
9160         * parse.c (expression_context_block, expression_context_pc):
9161         Remove globals.
9162         (parse_exp_in_context): Update.
9163         * p-exp.y: Update all rules.
9164         (yylex): Update.
9165         * m2-exp.y: Update all rules.
9166         (yylex): Update.
9167         * go-exp.y (yylex): Update.
9168         * f-exp.y (yylex): Update.
9169         * d-exp.y: Update all rules.
9170         (yylex): Update.
9171         * c-exp.y: Update all rules.
9172         (lex_one_token, classify_name, yylex, c_parse): Update.
9173         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9174
9175 2019-04-04  Tom Tromey  <tom@tromey.com>
9176
9177         * gdbarch.h, gdbarch.c: Rebuild.
9178         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9179         * stap-probe.h:
9180         (struct stap_parse_info): Replace "parser_state" with
9181         "expr_builder".
9182         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9183         (parser_state): New class.
9184         * parse.c (expr_builder): Rename.
9185         (expr_builder::release): Rename.
9186         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9187         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9188         (write_exp_elt_longcst, write_exp_elt_floatcst)
9189         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9190         (write_exp_string_vector, write_exp_bitstring)
9191         (write_exp_msymbol, mark_struct_expression)
9192         (write_dollar_variable)
9193         (insert_type_address_space, increase_expout_size): Replace
9194         "parser_state" with "expr_builder".
9195         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9196         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9197         "parser_state" with "expr_builder".
9198
9199 2019-04-04  Tom Tromey  <tom@tromey.com>
9200
9201         * rust-exp.y: Replace "parse_language" with method call.
9202         * p-exp.y:
9203         (yylex): Replace "parse_language" with method call.
9204         * m2-exp.y:
9205         (yylex): Replace "parse_language" with method call.
9206         * go-exp.y (classify_name): Replace "parse_language" with method
9207         call.
9208         * f-exp.y (yylex): Replace "parse_language" with method call.
9209         * d-exp.y (lex_one_token): Replace "parse_language" with method
9210         call.
9211         * c-exp.y:
9212         (lex_one_token, classify_name, yylex): Replace "parse_language"
9213         with method call.
9214         * ada-exp.y (find_primitive_type, type_char)
9215         (type_system_address): Replace "parse_language" with method call.
9216
9217 2019-04-04  Tom Tromey  <tom@tromey.com>
9218
9219         * rust-exp.y: Replace "parse_gdbarch" with method call.
9220         * parse.c (write_dollar_variable, insert_type_address_space):
9221         Replace "parse_gdbarch" with method call.
9222         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9223         call.
9224         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9225         call.
9226         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9227         "parse_gdbarch" with method call.
9228         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9229         with method call.
9230         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9231         "parse_gdbarch" with method call.
9232         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9233         "parse_gdbarch" with method call.
9234         * c-exp.y (parse_type, parse_number, classify_name): Replace
9235         "parse_gdbarch" with method call.
9236         * ada-lex.l: Replace "parse_gdbarch" with method call.
9237         * ada-exp.y (parse_type, find_primitive_type, type_char)
9238         (type_system_address): Replace "parse_gdbarch" with method call.
9239
9240 2019-04-04  Tom Tromey  <tom@tromey.com>
9241
9242         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9243         * stap-probe.c (stap_parse_argument): Update.
9244         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9245         initial_size parameter.
9246         * rust-exp.y (rust_lex_tests): Update.
9247         * parse.c (parser_state): Update.
9248         (parse_exp_in_context): Update.
9249         * parser-defs.h (struct parser_state) <parser_state>: Remove
9250         "initial_size" parameter.
9251
9252 2019-04-04  Tom Tromey  <tom@tromey.com>
9253
9254         * parser-defs.h (increase_expout_size): Don't declare.
9255         * parse.c (increase_expout_size): Now static.
9256
9257 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9258
9259         * gnu-nat.c (gnu_nat_target::wait): Fix
9260         target_waitstatus_to_string call.
9261
9262 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9263
9264         * eval.c (evaluate_subexp_standard): Handle internal functions
9265         during Fortran function call handling.
9266
9267 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9268
9269         * NEWS: Mention new internal functions.
9270         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9271         (read_base_type): Use dwarf2_init_complex_target_type.
9272         * value.c (creal_internal_fn): New function.
9273         (cimag_internal_fn): New function.
9274         (_initialize_values): Register new internal functions.
9275
9276 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9277
9278         * infrun.c (stop_all_threads): If debug_infrun, always
9279         trace the wait status after wait_one, using
9280         target_waitstatus_to_string and target_pid_to_str.
9281         (handle_inferior_event): Replace various trace of
9282         wait status kind by a single trace.
9283         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9284         wait status kind image by target_waitstatus_to_string.
9285         * target/waitstatus.c (target_waitstatus_to_string): Fix
9286         obsolete comment.
9287
9288 2019-04-01  Tom Tromey  <tromey@adacore.com>
9289
9290         PR symtab/23331:
9291         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9292
9293 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9294             Pedro Alves  <palves@redhat.com>
9295
9296         * top.c (quit_force): Call 'finalize_values'.
9297         * value.c (finalize_values): New function.
9298         * value.h (finalize_values): Declare.
9299
9300 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9301
9302         * NEWS: Announce $_gdb_major and $_gdb_minor.
9303
9304         * top.c (init_gdb_version_vars): New function.
9305         (gdb_init): Call init_gdb_version_vars.
9306
9307 2019-03-29  Tom Tromey  <tromey@adacore.com>
9308
9309         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9310         help text.  Remove dead code.
9311
9312 2019-03-29  Keith Seitz  <keiths@redhat.com>
9313
9314         From Siddhesh Poyarekar:
9315         * f-lang.h (f77_get_upperbound): Return LONGEST.
9316         (f77_get_lowerbound): Likewise.
9317         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9318         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9319         print them.
9320         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9321         plongest to format print it.
9322         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9323         (f77_get_upperbound): Likewise.
9324         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9325         LOWER_BOUND to LONGEST.
9326         (f77_create_arrayprint_offset_tbl): Likewise.
9327
9328 2019-03-29  Keith Seitz  <keiths@redhat.com>
9329
9330         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9331         %s/pulongest for TYPE_LENGTH instead of %d in format
9332         strings.
9333         * ada-typerint.c (ada_print_type): Likewise.
9334         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9335         * compile/compile-c-support.c (generate_register_struct): Likewise.
9336         * gdbtypes.c (recursive_dump_type): Likewise.
9337         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9338         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9339         instead of %d in format strings.
9340         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9341         to std::min to ULONGEST.
9342         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9343         instead of %d in format strings.
9344         * tracepoint.c (info_scope_command): Likewise.
9345         * typeprint.c (print_offset_data::update)
9346         (print_offset_data::finish): Likewise.
9347         * xtensa-tdep.c (xtensa_store_return_value)
9348         (xtensa_push_dummy_call): Likewise.
9349
9350 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9351
9352         * windows-nat.c (display_selector): Fixed format specifications
9353         for 64-bit Cygwin.
9354
9355 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9356
9357         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9358
9359 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9360
9361         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9362         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9363         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9364         (nios2_linux_init_abi): Install it.
9365
9366 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9367
9368         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9369
9370 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9371
9372         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9373
9374 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9375             Tom Tromey  <tromey@adacore.com>
9376
9377         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9378
9379 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9380
9381         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9382         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9383         method to compute the bounds of range types. Also print "[evaluated]"
9384         if the bounds' values come from a dynamic evaluation.
9385
9386 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9387
9388         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9389         whitespace when pretty printing is on.
9390
9391 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9392
9393         * ppc-linux-nat.c: Add include.
9394
9395 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9396
9397         * NEWS: Mention AArch64 Pointer Authentication.
9398
9399 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9400
9401         * arm-linux-nat.c: Add include.
9402
9403 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9404
9405         * source-cache.c (source_cache::get_source_lines): Re-read
9406         fullname after calling open_source_file.
9407
9408 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9409
9410         * NEWS: Mention TLS support for FreeBSD.
9411
9412 2019-03-25  Tom Tromey  <tromey@adacore.com>
9413
9414         * minsyms.c (BUNCH_SIZE): Update comment.
9415         (~minimal_symbol_reader): Remove old comment.
9416         (compact_minimal_symbols): Update comment.
9417         (minimal_symbol_reader::install): Remove old comment.  Update
9418         other comments.
9419
9420 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9421
9422         * s390-linux-nat.c: Add include.
9423
9424 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9425
9426         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9427         Call linux_get_hwcap.
9428         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9429         Likewise.
9430         (aarch64_linux_get_hwcap): Remove function.
9431         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9432         declaration.
9433         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9434         linux_get_hwcap.
9435         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9436         * linux-tdep.c (linux_get_hwcap): Add function.
9437         (linux_get_hwcap2): Likewise.
9438         * linux-tdep.h (linux_get_hwcap): Add declaration.
9439         (linux_get_hwcap2): Likewise.
9440         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9441         (ppc_linux_get_hwcap2): Likewise.
9442         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9443         linux_get_hwcap.
9444         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9445         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9446         (ppc_linux_nat_target::read_description): Likewise.
9447         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9448         * s390-linux-nat.c: Likewise.
9449         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9450
9451 2019-03-24  Tom Tromey  <tom@tromey.com>
9452
9453         * ada-lang.c (standard_lookup): Simplify initialization.
9454         (ada_lookup_symbol_nonlocal): Simplify return.
9455         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9456         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9457         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9458         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9459         initialization.
9460         * solib.c (solib_global_lookup): Simplify.
9461         * symtab.c (null_block_symbol): Remove.
9462         (symbol_cache_lookup): Simplify returns.
9463         (lookup_language_this): Simplify returns.
9464         (lookup_symbol_aux): Simplify return.
9465         (lookup_local_symbol): Simplify returns.
9466         (lookup_global_symbol_from_objfile): Simplify return.
9467         (lookup_symbol_in_objfile_symtabs)
9468         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9469         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9470         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9471         * cp-namespace.c (cp_lookup_bare_symbol)
9472         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9473         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9474         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9475         (cp_lookup_symbol_via_imports): Simplify initialization.
9476         (find_symbol_in_baseclass): Likewise.
9477         * symtab.h (null_block_symbol): Remove.
9478         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9479         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9480         (d_lookup_symbol_module): Likewise.
9481         (find_symbol_in_baseclass): Simplify initialization.
9482
9483 2019-03-24  Tom Tromey  <tom@tromey.com>
9484
9485         * expression.h: Don't include symtab.h.
9486         (struct block): Forward declare.
9487
9488 2019-03-24  Tom Tromey  <tom@tromey.com>
9489
9490         * c-exp.y (typebase): Remove casts.
9491         * gdbtypes.c (lookup_unsigned_typename, )
9492         (lookup_signed_typename): Remove cast.
9493         * eval.c (parse_to_comma_and_eval): Remove cast.
9494         * parse.c (write_dollar_variable): Remove cast.
9495         * block.h (struct block) <superblock>: Now const.
9496         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9497         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9498         (map_block): Make "block" const.
9499         * symfile.h (struct quick_symbol_functions)
9500         <map_matching_symbols>: Constify block argument to "callback".
9501         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9502         const.
9503         (find_pc_sect_compunit_symtab): Make "b" const.
9504         (find_symbol_at_address): Likewise.
9505         (search_symbols): Likewise.
9506         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9507         (dw2_debug_names_lookup_symbol): Likewise.
9508         (dw2_map_matching_symbols): Update.
9509         * p-valprint.c (pascal_val_print): Remove "block".
9510         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9511         (aux_add_nonlocal_symbols): Make "block" const.
9512         (resolve_subexp): Remove cast.
9513         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9514         const.
9515         (iterate_over_file_blocks): Likewise.
9516         * f-exp.y (%union) <bval>: Remove.
9517         * coffread.c (patch_opaque_types): Make "b" const.
9518         * spu-tdep.c (spu_catch_start): Make "block" const.
9519         * c-valprint.c (print_unpacked_pointer): Remove "block".
9520         * symmisc.c (dump_symtab_1): Make "b" const.
9521         (block_depth): Make "block" const.
9522         * d-exp.y (%union) <bval>: Remove.
9523         * cp-support.h (cp_lookup_rtti_type): Update.
9524         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9525         * psymtab.c (psym_lookup_symbol): Make "block" const.
9526         (maintenance_check_psymtabs): Make "b" const.
9527         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9528         (enumerate_locals, enumerate_args): Update.
9529         * python/py-symtab.c (stpy_global_block): Make "block" const.
9530         (stpy_static_block): Likewise.
9531         * inline-frame.c (block_starting_point_at): Make "new_block"
9532         const.
9533         * block.c (find_block_in_blockvector): Make return type const.
9534         (blockvector_for_pc_sect): Make "b" const.
9535         (find_block_in_blockvector): Make "b" const.
9536
9537 2019-03-23  Tom Tromey  <tom@tromey.com>
9538
9539         * varobj.c (varobj_create): Update.
9540         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9541         * printcmd.c (display_command, do_one_display): Don't reset
9542         innermost_block.
9543         * parser-defs.h (enum innermost_block_tracker_type): Move to
9544         expression.h.
9545         (innermost_block): Update comment.
9546         * parse.c (parse_exp_1): Add tracker_types parameter.
9547         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9548         tracker_types parameter.  Reset innermost_block.
9549         (parse_exp_in_context): Remove.
9550         (parse_expression_for_completion): Update.
9551         * objfiles.c (~objfile): Don't reset expression_context_block or
9552         innermost_block.
9553         * expression.h (enum innermost_block_tracker_type): Move from
9554         parser-defs.h.
9555         (parse_exp_1): Add tracker_types parameter.
9556         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9557         reset innermost_block.
9558
9559 2019-03-23  Tom Tromey  <tom@tromey.com>
9560
9561         * objfiles.h: Include bcache.h.
9562
9563 2019-03-23  Tom Tromey  <tom@tromey.com>
9564
9565         * linespec.c (get_current_search_block): Use
9566         scoped_restore_current_language.
9567         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9568
9569 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9570             Jiong Wang  <jiong.wang@arm.com>
9571
9572         * aarch64-linux-tdep.c
9573         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9574         section.
9575         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9576
9577 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9578             Jiong Wang  <jiong.wang@arm.com>
9579
9580         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9581         instructions.
9582         (aarch64_analyze_prologue_test): Add PACIASP test.
9583         (aarch64_prologue_prev_register): Unmask PC value.
9584
9585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9586             Jiong Wang  <jiong.wang@arm.com>
9587
9588         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9589         (aarch64_dwarf2_prev_register): Unmask PC value.
9590         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9591         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9592         DW_CFA_AARCH64_negate_ra_state.
9593         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9594
9595 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9596             Jiong Wang  <jiong.wang@arm.com>
9597
9598         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9599         registers.
9600         (aarch64_pseudo_register_name): Likewise.
9601         (aarch64_pseudo_register_type): Likewise.
9602         (aarch64_pseudo_register_reggroup_p): Likewise.
9603         (aarch64_gdbarch_init): Add pauth registers.
9604         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9605         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9606         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9607         (struct gdbarch_tdep): Add regnum for ra_state.
9608
9609 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9610             Jiong Wang  <jiong.wang@arm.com>
9611
9612         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9613
9614 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9615             Jiong Wang  <jiong.wang@arm.com>
9616
9617         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9618         function.
9619         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9620         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9621         (aarch64_gdbarch_init): Add puth registers.
9622         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9623         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9624         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9625
9626 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9627             Jiong Wang  <jiong.wang@arm.com>
9628
9629         * aarch64-linux-nat.c
9630         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9631         * aarch64-linux-tdep.c
9632         (aarch64_linux_core_read_description): Likewise.
9633         (aarch64_linux_get_hwcap): New function.
9634         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9635         (aarch64_linux_get_hwcap): New declaration.
9636
9637 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9638             Jiong Wang  <jiong.wang@arm.com>
9639
9640         * aarch64-linux-nat.c
9641         (aarch64_linux_nat_target::read_description): Add pauth param.
9642         * aarch64-linux-tdep.c
9643         (aarch64_linux_core_read_description): Likewise.
9644         * aarch64-tdep.c (struct target_desc): Add in pauth.
9645         (aarch64_read_description): Add pauth param.
9646         (aarch64_gdbarch_init): Likewise.
9647         * aarch64-tdep.h (aarch64_read_description): Likewise.
9648         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9649         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9650         * features/Makefile: Add new files.
9651         * features/aarch64-pauth.c: New file.
9652         * features/aarch64-pauth.xml: New file.
9653
9654 2019-03-20  Tom Tromey  <tromey@adacore.com>
9655
9656         * infrun.c (handle_inferior_event): Rename from
9657         handle_inferior_event_1.  Create a scoped_value_mark.
9658         (handle_inferior_event): Remove.
9659
9660 2019-03-19  Tom Tromey  <tromey@adacore.com>
9661
9662         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9663         * infrun.h (print_stop_event): Add "displays" parameter.
9664         * infrun.c (print_stop_event): Add "displays" parameter.
9665
9666 2019-03-19  Pedro Alves  <palves@redhat.com>
9667
9668         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9669         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9670         to -1.  Fix TABs vs spaces.
9671         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9672         * tui/tui-out.h (tui_ui_out) Add intro comments.
9673         <m_line, m_start_of_line>: In-class initialize, and add describing
9674         comment.
9675
9676 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9677
9678         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9679         variable names.
9680         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9681
9682 2019-03-18  Pedro Alves  <palves@redhat.com>
9683             Eli Zaretskii <eliz@gnu.org>
9684
9685         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9686         m_line and m_start_of_line.
9687
9688 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9689
9690         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9691         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9692         it returns a newline.  This fixes a regression in TU mode, whereby
9693         the next line is output on the same screen line as the user input.
9694
9695 2019-03-18  Tom Tromey  <tromey@adacore.com>
9696
9697         * minsyms.c (minimal_symbol_reader::install): Remove call to
9698         obstack_blank.
9699
9700 2019-03-18  Pedro Alves  <palves@redhat.com>
9701
9702         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9703         New globals.
9704         (apply_style): New, factored out from ...
9705         (apply_ansi_escape): ... this.  Handle reverse video mode.
9706         (tui_set_reverse_mode): New function.
9707         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9708         * tui/tui-winsource.c (tui_show_source_line): Use
9709         tui_set_reverse_mode instead of setting A_STANDOUT.
9710         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9711         New setter methods.
9712
9713 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9714
9715         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9716         Handle tabs.
9717
9718 2019-03-18  Tom Tromey  <tromey@adacore.com>
9719
9720         * ada-lang.c (empty_array): Add "high" parameter.
9721         (ada_evaluate_subexp): Update.
9722
9723 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9724
9725         * unittests/string_view-selftests.c: Define
9726         _initialize_string_view_selftests unconditionally.
9727
9728 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9729
9730         PR gdb/24350
9731         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9732
9733 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9734
9735         PR gdb/24351
9736         * windows-nat.c (display_selector): Fix format specifiers.
9737
9738 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9739
9740         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9741         tui_refill_source_window instead of tui_refresh_win, to update the
9742         current execution line.  This fixes redisplay of the current line
9743         when stepping through the code with "next" or "step".
9744
9745 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9746
9747         * source-cache.c (source_cache::get_source_lines): Call
9748         find_source_lines to initialize s->nlines.  This fixes vertical
9749         scrolling of TUI source window when the DOWN arrow is pressed.
9750
9751 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9752
9753         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9754         linux-thread-db.c (_initialize_thread_db): Likewise.
9755
9756 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9757
9758         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9759         wclrtoeol in tui_show_source_line".  This reverts changes made in
9760         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9761
9762 2019-03-15  Tom Tromey  <tom@tromey.com>
9763
9764         * symtab.h (struct minimal_symbol): Derive from
9765         general_symbol_info.
9766         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9767         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9768         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9769         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9770         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9771         (MSYMBOL_SEARCH_NAME): Update.
9772         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9773         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9774         * minsyms.c (minimal_symbol_reader::record_full): Update.
9775
9776 2019-03-15  Tom Tromey  <tom@tromey.com>
9777
9778         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9779
9780 2019-03-15  Tom Tromey  <tom@tromey.com>
9781
9782         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9783         unique_xmalloc_ptr.
9784         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9785         Update.
9786         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9787         (build_minimal_symbol_hash_tables)
9788         (minimal_symbol_reader::install): Update.
9789
9790 2019-03-15  Tom Tromey  <tom@tromey.com>
9791
9792         * symtab.c (create_demangled_names_hash): Update.
9793         (symbol_set_names): Update.
9794         * objfiles.h (struct objfile_per_bfd_storage)
9795         <demangled_names_hash>: Now an htab_up.
9796         * objfiles.c (objfile_per_bfd_storage): Simplify.
9797
9798 2019-03-15  Tom Tromey  <tom@tromey.com>
9799
9800         * objfiles.h (struct objfile_per_bfd_storage): Declare
9801         destructor.
9802         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9803         New.
9804         (get_objfile_bfd_data): Use new.  Don't initialize
9805         language_of_main.
9806         (free_objfile_per_bfd_storage): Remove.
9807         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9808
9809 2019-03-15  Tom Tromey  <tom@tromey.com>
9810
9811         * symfile.c (reread_symbols): Update.
9812         * objfiles.c (objfile::objfile): Update.
9813         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9814         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9815         comment.
9816         (minimal_symbol_reader::install): Update.
9817         (terminate_minimal_symbol_table): Remove.
9818         * jit.c (jit_object_close_impl): Update.
9819
9820 2019-03-15  Tom Tromey  <tom@tromey.com>
9821
9822         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9823         initializations.
9824
9825 2019-03-15  Tom Tromey  <tom@tromey.com>
9826
9827         * objfiles.h (struct objfile_per_bfd_storage)
9828         <demangled_hash_languages>: Now a bitset.
9829         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9830         (lookup_minimal_symbol): Update.
9831
9832 2019-03-15  Tom Tromey  <tom@tromey.com>
9833
9834         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9835         Don't return the symbol.
9836         * coffread.c (record_minimal_symbol): Use record_full.
9837
9838 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9839
9840         The MS-Windows port of ncurses fails to switch to a color pair if
9841         one or both of the colors are the implicit default colors.  This
9842         change records the default colors when TUI is initialized, and
9843         then specifies them explicitly when a color pair uses the default
9844         colors.  This allows color styling in TUI mode on MS-Windows.
9845
9846         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9847         ncurses_norm_attr.
9848         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9849         colors in ncurses_norm_attr.
9850         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9851         "none", replace it with the default color recorded in
9852         ncurses_norm_attr.
9853
9854 2019-03-14  Tom Tromey  <tromey@adacore.com>
9855
9856         * source-cache.h (class source_cache) <get_source_lines>: Return
9857         std::string.
9858         * source-cache.c (source_cache::extract_lines): Handle case where
9859         first_pos==npos.  Return std::string.
9860         (source_cache::get_source_lines): Update.
9861
9862 2019-03-14  Tom Tromey  <tromey@adacore.com>
9863
9864         * NEWS: Add item for "style sources" commands.
9865         * source-cache.c (source_cache::get_source_lines): Check
9866         source_styling.
9867         * cli/cli-style.c (source_styling): New global.
9868         (_initialize_cli_style): Add "style sources" commands.
9869         (show_style_sources): New function.
9870         * cli/cli-style.h (source_styling): Declare.
9871
9872 2019-03-14  Pedro Alves  <palves@redhat.com>
9873             Tom Tromey  <tromey@adacore.com>
9874
9875         * tui/tui-winsource.h (tui_refill_source_window): Declare.
9876         * tui/tui-winsource.c (tui_refill_source_window): New function,
9877         from...
9878         (tui_horizontal_source_scroll): ... here.  Move some logic.
9879         * cli/cli-style.c (set_style_enabled): Notify new observable.
9880         * tui/tui-hooks.c (tui_redisplay_source): New function.
9881         (tui_attach_detach_observers): Attach or detach
9882         tui_redisplay_source.
9883         * observable.h (source_styling_changed): New observable.
9884         * observable.c: Define source_styling_changed observable.
9885
9886 2019-03-13  Tom Tromey  <tromey@adacore.com>
9887
9888         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
9889         (i386_gnu_nat_target::store_registers): Update.
9890         * target-debug.h (target_debug_print_std_string): New macro.
9891         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9892         * windows-tdep.c (display_one_tib): Update.
9893         * tui/tui-stack.c (tui_make_status_line): Update.
9894         * top.c (print_inferior_quit_action): Update.
9895         * thread.c (thr_try_catch_cmd): Update.
9896         (add_thread_with_info): Update.
9897         (thread_target_id_str): Update.
9898         (thr_try_catch_cmd): Update.
9899         (thread_command): Update.
9900         (thread_find_command): Update.
9901         * record-btrace.c (record_btrace_target::info_record)
9902         (record_btrace_resume_thread, record_btrace_target::resume)
9903         (record_btrace_cancel_resume, record_btrace_step_thread)
9904         (record_btrace_target::wait, record_btrace_target::wait)
9905         (record_btrace_target::wait, record_btrace_target::stop): Update.
9906         * progspace.c (print_program_space): Update.
9907         * process-stratum-target.c
9908         (process_stratum_target::thread_address_space): Update.
9909         * linux-fork.c (linux_fork_mourn_inferior)
9910         (detach_checkpoint_command, info_checkpoints_command)
9911         (linux_fork_context): Update.
9912         (linux_fork_detach): Update.
9913         (class scoped_switch_fork_info): Update.
9914         (delete_checkpoint_command): Update.
9915         * infrun.c (follow_fork_inferior): Update.
9916         (follow_fork_inferior): Update.
9917         (proceed_after_vfork_done): Update.
9918         (handle_vfork_child_exec_or_exit): Update.
9919         (follow_exec): Update.
9920         (displaced_step_prepare_throw): Update.
9921         (displaced_step_restore): Update.
9922         (start_step_over): Update.
9923         (resume_1): Update.
9924         (clear_proceed_status_thread): Update.
9925         (proceed): Update.
9926         (print_target_wait_results): Update.
9927         (do_target_wait): Update.
9928         (context_switch): Update.
9929         (stop_all_threads): Update.
9930         (restart_threads): Update.
9931         (finish_step_over): Update.
9932         (handle_signal_stop): Update.
9933         (switch_back_to_stepped_thread): Update.
9934         (keep_going_pass_signal): Update.
9935         (print_exited_reason): Update.
9936         (normal_stop): Update.
9937         * inferior.c (inferior_pid_to_str): Change return type.
9938         (print_selected_inferior): Update.
9939         (add_inferior): Update.
9940         (detach_inferior): Update.
9941         * dummy-frame.c (fprint_dummy_frames): Update.
9942         * dcache.c (dcache_info_1): Update.
9943         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
9944         (btrace_fetch, btrace_clear): Update.
9945         * linux-tdep.c (linux_core_pid_to_str): Change return type.
9946         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
9947         type.
9948         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
9949         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
9950         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
9951         * gdbarch.c, gdbarch.h: Rebuild.
9952         * gdbarch.sh (core_pid_to_str): Change return type.
9953         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
9954         return type.
9955         (windows_nat_target::pid_to_str): Change return type.
9956         (windows_delete_thread): Update.
9957         (windows_nat_target::attach): Update.
9958         (windows_nat_target::files_info): Update.
9959         * target-delegates.c: Rebuild.
9960         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
9961         return type.
9962         (sol_thread_target::pid_to_str): Change return type.
9963         * remote.c (class remote_target) <pid_to_str>: Change return
9964         type.
9965         (remote_target::pid_to_str): Change return type.
9966         (extended_remote_target::attach, remote_target::remote_stop_ns)
9967         (remote_target::remote_notif_remove_queued_reply)
9968         (remote_target::push_stop_reply, remote_target::disable_btrace):
9969         Update.
9970         (extended_remote_target::attach): Update.
9971         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
9972         type.
9973         (gdbsim_target::pid_to_str): Change return type.
9974         * ravenscar-thread.c (struct ravenscar_thread_target)
9975         <pid_to_str>: Change return type.
9976         (ravenscar_thread_target::pid_to_str): Change return type.
9977         * procfs.c (class procfs_target) <pid_to_str>: Change return
9978         type.
9979         (procfs_target::pid_to_str): Change return type.
9980         (procfs_target::attach): Update.
9981         (procfs_target::detach): Update.
9982         (procfs_target::fetch_registers): Update.
9983         (procfs_target::store_registers): Update.
9984         (procfs_target::wait): Update.
9985         (procfs_target::files_info): Update.
9986         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
9987         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
9988         return type.
9989         (nto_procfs_target::pid_to_str): Change return type.
9990         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
9991         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
9992         return type.
9993         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
9994         (exit_lwp): Update.
9995         (attach_proc_task_lwp_callback, get_detach_signal)
9996         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
9997         (linux_nat_target::resume, wait_lwp, stop_callback)
9998         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
9999         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10000         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10001         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10002         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10003         type.
10004         (inf_ptrace_target::attach): Update.
10005         (inf_ptrace_target::files_info): Update.
10006         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10007         type.
10008         (go32_nat_target::pid_to_str): Change return type.
10009         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10010         (gnu_nat_target::wait): Update.
10011         (gnu_nat_target::wait): Update.
10012         (gnu_nat_target::resume): Update.
10013         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10014         (fbsd_nat_target::wait): Update.
10015         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10016         type.
10017         (darwin_nat_target::attach): Update.
10018         * corelow.c (class core_target) <pid_to_str>: Change return type.
10019         (core_target::pid_to_str): Change return type.
10020         * target.c (normal_pid_to_str): Change return type.
10021         (default_pid_to_str): Likewise.
10022         (target_pid_to_str): Change return type.
10023         (target_translate_tls_address): Update.
10024         (target_announce_detach): Update.
10025         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10026         return type.
10027         (bsd_uthread_target::pid_to_str): Change return type.
10028         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10029         type.
10030         (bsd_kvm_target::pid_to_str): Change return type.
10031         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10032         return type.
10033         (aix_thread_target::pid_to_str): Change return type.
10034         * target.h (struct target_ops) <pid_to_str>: Change return type.
10035         (target_pid_to_str, normal_pid_to_str): Likewise.
10036         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10037         type.
10038         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10039         type.
10040         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10041         return type.
10042         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10043         type.
10044         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10045         type.
10046         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10047         return type.
10048
10049 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10050
10051         * NEWS: Mention that the new default MI version is 3.  Mention
10052         changes to the output of commands and events that deal with
10053         multi-location breakpoints.
10054         * breakpoint.c: Include "mi/mi-out.h".
10055         (print_one_breakpoint): Change output syntax if using MI version
10056         >= 3.
10057         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10058         New.
10059         (mi_multi_location_breakpoint_output_fixed): New.
10060         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10061         (mi_cmd_fix_multi_location_breakpoint_output): New.
10062         (mi_multi_location_breakpoint_output_fixed): New.
10063         * mi/mi-cmds.c (mi_cmds): Register command
10064         -fix-multi-location-breakpoint-output.
10065         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10066         interpreter "mi".
10067
10068 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10069
10070         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10071         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10072         instantiate mi_ui_out based on interpreter name.
10073         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10074         * mi/mi-main.c (mi_load_progress): Likewise.
10075
10076 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10077
10078         * NEWS: Combine separate "New targets" sections for 8.3.
10079
10080 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10081
10082         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10083         (ppcfbsd_init_abi): Install gdbarch
10084         "fetch_tls_load_module_address" and "get_thread_local_address"
10085         methods.
10086
10087 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10088
10089         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10090         (riscv_fbsd_init_abi): Install gdbarch
10091         "fetch_tls_load_module_address" and "get_thread_local_address"
10092         methods.
10093
10094 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10095
10096         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10097         (i386fbsd_init_abi): Install gdbarch
10098         "fetch_tls_load_module_address" and "get_thread_local_address"
10099         methods.
10100
10101 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10102
10103         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10104         (amd64fbsd_init_abi): Install gdbarch
10105         "fetch_tls_load_module_address" and "get_thread_local_address"
10106         methods.
10107
10108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10109
10110         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10111         (struct fbsd_pspace_data): New type.
10112         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10113         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10114         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10115         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10116         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10117
10118 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10119
10120         * gdbtypes.c (lookup_struct_elt): New function.
10121         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10122         * gdbtypes.h (struct struct_elt): New type.
10123         (lookup_struct_elt): New prototype.
10124
10125 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10126
10127         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10128         remove disabled code block.
10129
10130 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10131
10132         * gdbarch.sh (get_thread_local_address): New method.
10133         * gdbarch.h, gdbarch.c: Regenerate.
10134         * target.c (target_translate_tls_address): Use
10135         gdbarch_get_thread_local_address if present instead of
10136         target::get_thread_local_address.
10137
10138 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10139
10140         * target.h (target::get_thread_local_address): Update comment.
10141
10142 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10143
10144         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10145         objfile->separate_debug_objfile_backlink if not NULL.
10146
10147 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10148
10149         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10150         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10151         (amd64bsd_store_inferior_registers): Likewise.
10152         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10153         Enable segment base registers.
10154         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10155         PT_GETFSBASE and PT_GETGSBASE.
10156         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10157         PT_SETGSBASE.
10158         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10159         segment base registers.
10160         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10161
10162 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10163
10164         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10165         Update calls to i386_target_description to add 'segments'
10166         parameter.
10167         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10168         add segment base registers.
10169         * arch/i386.c (i386_create_target_description): Add 'segments'
10170         parameter to enable segment base registers.
10171         * arch/i386.h (i386_create_target_description): Likewise.
10172         * features/i386/32bit-segments.xml: New file.
10173         * features/i386/32bit-segments.c: Generate.
10174         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10175         call to i386_target_description to add 'segments' parameter.
10176         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10177         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10178         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10179         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10180         if feature is present.
10181         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10182         Add 'segments' parameter to call to i386_target_description.
10183         (i386_target_description): Add 'segments' parameter to enable
10184         segment base registers.
10185         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10186         to call to i386_target_description.
10187         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10188         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10189         Define I386_NUM_REGS.
10190         (i386_target_description): Add 'segments' parameter to enable
10191         segment base registers.
10192
10193 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10194
10195         PR/24325
10196         * source-cache.c: #undef open and close, to avoid unresolved
10197         externals during linking.
10198
10199 2019-03-12  Tom Tromey  <tromey@adacore.com>
10200
10201         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10202         const.  Add initializers.
10203         (_initialize_remote): Don't initialize ptid globals.
10204
10205 2019-03-12  Pedro Alves  <palves@redhat.com>
10206
10207         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10208
10209 2019-03-12  Pedro Alves  <palves@redhat.com>
10210
10211         * cp-name-parser.y (main): Remove unused 'len' variable.
10212
10213 2019-03-12  Tom Tromey  <tromey@adacore.com>
10214
10215         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10216         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10217
10218 2019-03-12  Tom Tromey  <tromey@adacore.com>
10219
10220         * linux-nat.c (iterate_over_lwps): Update.
10221         (stop_callback): Remove parameter.
10222         (stop_wait_callback, detach_callback, resume_set_callback)
10223         (select_singlestep_lwp_callback, set_ignore_sigint)
10224         (status_callback, resumed_callback, resume_clear_callback)
10225         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10226         data parameter.
10227         (linux_nat_target::detach, linux_nat_target::resume)
10228         (linux_stop_and_wait_all_lwps, select_event_lwp)
10229         (linux_nat_filter_event, linux_nat_wait_1)
10230         (linux_nat_target::kill, linux_nat_target::stop)
10231         (linux_nat_target::stop): Update.
10232         (linux_nat_resume_callback): Change type.
10233         (resume_stopped_resumed_lwps, count_events_callback)
10234         (select_event_lwp_callback): Likewise.
10235         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10236         * arm-linux-nat.c (struct update_registers_data): Remove.
10237         (update_registers_callback): Change type.
10238         (arm_linux_insert_hw_breakpoint1): Update.
10239         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10240         parameter.
10241         (x86_linux_dr_set_addr): Update.
10242         (x86_linux_dr_set_control): Update.
10243         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10244         (iterate_over_lwps): Use gdb::function_view.
10245         * nat/aarch64-linux-hw-point.c (struct
10246         aarch64_dr_update_callback_param): Remove.
10247         (debug_reg_change_callback): Change type.
10248         (aarch64_notify_debug_reg_change): Update.
10249         * s390-linux-nat.c (s390_refresh_per_info): Update.
10250
10251 2019-03-11  Tom Tromey  <tromey@adacore.com>
10252
10253         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10254         redundant assignment to "this_cu".
10255
10256 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10257
10258         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10259
10260 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10261
10262         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10263         from...
10264         (rank_one_type): ... this.
10265
10266 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10267
10268         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10269         from...
10270         (rank_one_type): ... this.
10271
10272 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10273
10274         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10275         from...
10276         (rank_one_type): ... this.
10277
10278 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10279
10280         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10281         from...
10282         (rank_one_type): ... this.
10283
10284 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10285
10286         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10287         from...
10288         (rank_one_type): ... this.
10289
10290 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10291
10292         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10293         from...
10294         (rank_one_type): ... this.
10295
10296 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10297
10298         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10299         from...
10300         (rank_one_type): ... this.
10301
10302 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10303
10304         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10305         from...
10306         (rank_one_type): ... this.
10307
10308 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10309
10310         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10311         from...
10312         (rank_one_type): ... this.
10313
10314 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10315
10316         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10317         from...
10318         (rank_one_type): ... this.
10319
10320 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10321
10322         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10323         from...
10324         (rank_one_type): ... this.
10325
10326 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10327
10328         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10329         from...
10330         (rank_one_type): ... this.
10331
10332 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10333
10334         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10335         inferior-events' shows the example events.
10336
10337 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10338
10339         Support styling on native MS-Windows console
10340
10341         PR/24315
10342         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10343         on MS-Windows if $TERM is not defined.
10344
10345         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10346
10347         * posix-hdep.c (gdb_console_fputs):
10348         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10349         functions.
10350         * ui-file.h (gdb_console_fputs): Add prototype.
10351
10352         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10353         back to fputs only if the former returns zero.
10354
10355 2019-03-07  Tom Tromey  <tom@tromey.com>
10356
10357         * symmisc.c (print_symbol_bcache_statistics): Update.
10358         (print_objfile_statistics): Update.
10359         * symfile.c (allocate_symtab): Update.
10360         * stabsread.c: Don't include bcache.h.
10361         * psymtab.h (struct psymbol_bcache): Don't declare.
10362         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10363         (psymbol_bcache_init, psymbol_bcache_free)
10364         (psymbol_bcache_get_bcache): Don't declare.
10365         * psymtab.c (struct psymbol_bcache): Remove.
10366         (psymtab_storage::psymtab_storage): Update.
10367         (psymtab_storage::~psymtab_storage): Update.
10368         (psymbol_bcache_init, psymbol_bcache_free)
10369         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10370         (add_psymbol_to_bcache): Update.
10371         (allocate_psymtab): Update.
10372         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10373         macro_cache>: No longer pointers.
10374         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10375         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10376         * macrotab.c (macro_bcache): Update.
10377         * macroexp.c: Don't include bcache.h.
10378         * gdbtypes.c (check_types_worklist): Update.
10379         (types_deeply_equal): Remove TRY/CATCH.  Update.
10380         * elfread.c (elf_symtab_read): Update.
10381         * dwarf2read.c: Don't include bcache.h.
10382         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10383         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10384         (print_bcache_statistics, bcache_memory_used): Don't declare.
10385         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10386         methods.  Rename all data members.
10387         * bcache.c (struct bcache): Move to bcache.h.
10388         (bcache::expand_hash_table): Rename from expand_hash_table.
10389         (bcache): Remove.
10390         (bcache::insert): Rename from bcache_full.
10391         (bcache::compare): Rename from bcache_compare.
10392         (bcache_xmalloc): Remove.
10393         (bcache::~bcache): Rename from bcache_xfree.
10394         (bcache::print_statistics): Rename from print_bcache_statistics.
10395         (bcache::memory_used): Rename from bcache_memory_used.
10396
10397 2019-03-07  Pedro Alves  <palves@redhat.com>
10398
10399         * infrun.c (normal_stop): Also check for
10400         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10401
10402 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10403
10404         * f-lang.c (value_from_host_double): Moved to...
10405         * value.c (value_from_host_double): ...here.
10406         * value.h (value_from_host_double): Declare.
10407         * guile/scm-math.c (vlscm_convert_typed_number): Use
10408         value_from_host_double.
10409         (vlscm_convert_number): Likewise.
10410         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10411         * python/py-value.c (convert_value_from_python): Likewise.
10412
10413 2019-03-06  Tom Tromey  <tom@tromey.com>
10414
10415         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10416
10417 2019-03-06  Tom Tromey  <tom@tromey.com>
10418
10419         * utils.h (free_current_contents): Don't declare.
10420         * utils.c (free_current_contents): Remove.
10421
10422 2019-03-06  Tom Tromey  <tom@tromey.com>
10423
10424         * top.c (quit_force): Update.
10425         * main.c (captured_command_loop): Update.
10426         * common/new-op.c (operator new): Update.
10427         * common/common-exceptions.c (struct catcher)
10428         <save_cleanup_chain>: Remove member.
10429         (exceptions_state_mc_init): Update.
10430         (exception_try_scope_entry): Return nullptr.
10431         (exception_try_scope_exit, exception_rethrow)
10432         (throw_exception_sjlj, throw_exception_cxx): Update.
10433         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10434         (all_cleanups, do_cleanups, discard_cleanups)
10435         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10436         (restore_cleanups, restore_final_cleanups): Don't declare.
10437         (do_final_cleanups): Remove parameter.
10438         * common/cleanups.c (cleanup_chain, make_cleanup)
10439         (make_cleanup_dtor, all_cleanups, do_cleanups)
10440         (discard_my_cleanups, discard_cleanups)
10441         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10442         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10443         (null_cleanup): Remove.
10444         (do_final_cleanups): Remove parameter.
10445
10446 2019-03-06  Tom Tromey  <tom@tromey.com>
10447
10448         * remote.c (remote_target::remote_parse_stop_reply): Use
10449         unique_xmalloc_ptr.
10450
10451 2019-03-06  Tom Tromey  <tom@tromey.com>
10452
10453         * stabsread.c (struct stabs_field_info): Rename from field_info.
10454         <list, fnlist>: Add initializers.
10455         <obstack>: New member.
10456         (read_member_functions, read_struct_fields, read_baseclasses):
10457         Allocate on obstack.  Don't use cleanups.
10458         (read_one_struct_field, read_member_functions, read_struct_fields)
10459         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10460         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10461         (read_struct_type): Update.
10462
10463 2019-03-06  Tom Tromey  <tom@tromey.com>
10464
10465         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10466         * common/filestuff.h (make_cleanup_close): Don't declare.
10467         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10468         Remove.
10469
10470 2019-03-06  Tom Tromey  <tom@tromey.com>
10471
10472         * solib-aix.c: Use make_scope_exit.
10473
10474 2019-03-06  Tom Tromey  <tom@tromey.com>
10475
10476         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10477         Use make_scope_exit.
10478
10479 2019-03-06  Tom Tromey  <tom@tromey.com>
10480
10481         * solib-svr4.c (disable_probes_interface): Remove parameter.
10482         (svr4_handle_solib_event): Use make_scope_exit.
10483
10484 2019-03-06  Tom Tromey  <tom@tromey.com>
10485
10486         * remote.c (struct stop_reply_deleter): Remove.
10487         (stop_reply_up): Update.
10488         (struct stop_reply): Derive from notif_event.  Don't typedef.
10489         <regcache>: Now a std::vector.
10490         (stop_reply_xfree): Remove.
10491         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10492         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10493         (remote_target::discard_pending_stop_replies): Use delete.
10494         (remote_target::remote_parse_stop_reply): Update.
10495         (remote_target::process_stop_reply): Update.
10496         * remote-notif.h (struct notif_event): Add virtual destructor.
10497         Remove "dtr" member.
10498         (struct notif_client) <alloc_event>: Return a unique_ptr.
10499         (notif_event_xfree): Don't declare.
10500         (notif_event_up): New typedef.
10501         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10502         (notif_event_xfree, do_notif_event_xfree): Remove.
10503         (remote_notif_state_xfree): Update.
10504
10505 2019-03-06  Tom Tromey  <tom@tromey.com>
10506
10507         * infrun.c (displaced_step_clear_cleanup): Now a
10508         forward_scope_exit type.
10509         (displaced_step_prepare_throw): Update.
10510         (displaced_step_fixup): Update.
10511
10512 2019-03-06  Tom Tromey  <tom@tromey.com>
10513
10514         * inferior.h (class inferior): Update comment.
10515         * gdbthread.h (class thread_info): Update comment.
10516
10517 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10518             Tom Tromey  <tom@tromey.com>
10519
10520         * stabsread.h (struct stab_section_list): Remove.
10521         (coffstab_build_psymtabs): Update.
10522         * dbxread.c (symbuf_sections): Now a std::vector.
10523         (sect_idx): New global.
10524         (fill_symbuf): Update.
10525         (coffstab_build_psymtabs): Change type of stabsects parameter.
10526         Update.
10527         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10528         std::vector.
10529         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10530         (coff_locate_sections): Update.
10531         (coff_symfile_read): Remove cleanups.  Update.
10532         (init_stringtab): Add storage parameter.
10533         (free_stringtab, free_stringtab_cleanup): Remove.
10534         (init_lineno): Add storage parameter.
10535         (free_linetab, free_linetab_cleanup): Remove.
10536
10537 2019-03-06  Pedro Alves  <palves@redhat.com>
10538
10539         * linux-fork.c (fork_info::clobber_regs): Delete.
10540         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10541         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10542         comment.  Adjust.
10543         (scoped_switch_fork_info::scoped_switch_fork_info)
10544         (checkpoint_command, linux_fork_context): Adjust
10545         fork_save_infrun_state calls.
10546
10547 2019-03-06  Pedro Alves  <palves@redhat.com>
10548
10549         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10550         (inf_has_multiple_threads): Return 'bool' and rewrite using
10551         inferior_info::threads().
10552
10553 2019-03-06  Pedro Alves  <palves@redhat.com>
10554
10555         * linux-fork.c: Include <list>.
10556         (fork_list): Now a std::list instance.
10557         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10558         (forks_exist_p, find_last_fork): Adjust.
10559         (new_fork): Delete.
10560         (one_fork_p): New.
10561         (add_fork): Adjust.
10562         (free_fork): Delete, folded into fork_info::~fork_info().
10563         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10564         Adjust.
10565         (init_fork_list): Delete.
10566         (linux_fork_killall, linux_fork_mourn_inferior)
10567         (linux_fork_detach, info_checkpoints_command): Adjust.
10568         (_initialize_linux_fork): No longer call init_fork_list.
10569
10570 2019-03-06  Pedro Alves  <palves@redhat.com>
10571
10572         * linux-fork.c (new_fork): New, split out of ...
10573         (add_fork): ... this.  Return void.  Move "first fork" special
10574         case from here, to ...
10575         (checkpoint_command): ... here.
10576         * linux-linux.h (add_fork): Return void.
10577
10578 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10579
10580         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10581
10582 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10583             Chris January  <chris.january@arm.com>
10584             David Lecomber  <david.lecomber@arm.com>
10585
10586         * f-exp.y: New token, UNOP_INTRINSIC.
10587         (exp): New pattern using UNOP_INTRINSIC token.
10588         (f77_keywords): Add 'abs' keyword.
10589         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10590         (value_from_host_double): New function.
10591         (evaluate_subexp_f): Support UNOP_ABS.
10592
10593 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10594
10595         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10596         types.
10597
10598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10599
10600         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10601         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10602         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10603
10604 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10605
10606         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10607
10608 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10609             Chris January  <chris.january@arm.com>
10610
10611         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10612         * f-exp.y: Define 'KIND' token.
10613         (exp): New pattern for KIND expressions.
10614         (ptype): Handle types with a kind extension.
10615         (direct_abs_decl): Extend to spot kind extensions.
10616         (f77_keywords): Add 'kind' to the list.
10617         (push_kind_type): New function.
10618         (convert_to_kind_type): New function.
10619         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10620         * parse.c (operator_length_standard): Likewise.
10621         * parser-defs.h (enum type_pieces): Add tp_kind.
10622         * std-operator.def: Add UNOP_KIND.
10623
10624 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10625
10626         * f-exp.y (f_parse): Set yydebug.
10627
10628 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10629
10630         * f-lang.c (evaluate_subexp_f): New function.
10631         (exp_descriptor_f): New global.
10632         (f_language_defn): Use exp_descriptor_f instead of
10633         exp_descriptor_standard.
10634
10635 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10636
10637         * f-exp.y (struct token): Add comments.
10638         (dot_ops): Remove uppercase versions and the end marker.
10639         (f77_keywords): Likewise.
10640         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10641         entries in the dot_ops array are case insensitive, and use
10642         strncasecmp to compare strings.  Also some whitespace cleanup in
10643         this area.  Similar for the f77_keywords array, except entries in
10644         this list might be case sensitive.
10645
10646 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10647
10648         * f-exp.y (struct f77_boolean_val): Add comments.
10649         (boolean_values): Remove uppercase versions, and end marker.
10650         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10651         and use strncasecmp to achieve case insensitivity.  Additionally,
10652         perform whitespace cleanup around this code.
10653
10654 2019-03-06  Tom Tromey  <tromey@adacore.com>
10655
10656         * remote-sim.c (gdbsim_target_open): Use result of
10657         gdb_argv::release.
10658
10659 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10660         Dirk Schubert  <dirk.schubert@arm.com>
10661         Chris January  <chris.january@arm.com>
10662
10663         * eval.c (evaluate_subexp_standard): Call Fortran argument
10664         wrapping logic.
10665         * f-lang.c (struct value): A value which can be passed into a
10666         Fortran function call.
10667         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10668         where appropriate.
10669         (struct type): Value ready for a Fortran function call.
10670         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10671         is needed.
10672         * f-lang.h (fortran_argument_convert): Declaration.
10673         (fortran_preserve_arg_pointer): Declaration.
10674         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10675
10676 2019-03-05  Tom Tromey  <tromey@adacore.com>
10677
10678         * python/py-prettyprint.c (print_string_repr): Remove #if.
10679         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10680
10681 2019-03-05  Tom Tromey  <tromey@adacore.com>
10682
10683         * target.c (the_dummy_target): Move later.  Change type to
10684         "dummy_target".
10685         (initialize_targets): Don't initialize the_dummy_target.
10686
10687 2019-03-05  Tom Tromey  <tromey@adacore.com>
10688
10689         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10690         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10691
10692 2019-03-05  Tom Tromey  <tromey@adacore.com>
10693
10694         * windows-nat.c (windows_nat_target::attach)
10695         (windows_nat_target::detach): Don't call gdb_flush.
10696         * valprint.c (generic_val_print, val_print, val_print_string):
10697         Don't call gdb_flush.
10698         * utils.c (defaulted_query): Don't call gdb_flush.
10699         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10700         * target.c (target_announce_detach): Don't call gdb_flush.
10701         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10702         * remote.c (extended_remote_target::attach): Don't call
10703         gdb_flush.
10704         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10705         * printcmd.c (do_examine): Don't call gdb_flush.
10706         (info_display_command): Don't call gdb_flush.
10707         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10708         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10709         * memattr.c (info_mem_command): Don't call gdb_flush.
10710         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10711         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10712         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10713         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10714         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10715         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10716         (gnu_nat_target::detach): Don't call gdb_flush.
10717         * f-valprint.c (f_val_print): Don't call gdb_flush.
10718         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10719         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10720         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10721         gdb_flush.
10722         * c-valprint.c (c_val_print): Don't call gdb_flush.
10723         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10724
10725 2019-03-05  Tom Tromey  <tromey@adacore.com>
10726
10727         * varobj.c (update_dynamic_varobj_children): Update.
10728         (install_default_visualizer): Use reset, not release.
10729         * value.c (set_internalvar): Update.
10730         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10731         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10732         ATTRIBUTE_UNUSED_RESULT.
10733
10734 2019-03-05  Tom Tromey  <tromey@adacore.com>
10735
10736         * remote.c (class scoped_remote_fd) <release>: Add
10737         ATTRIBUTE_UNUSED_RESULT.
10738
10739 2019-03-05  Tom Tromey  <tromey@adacore.com>
10740
10741         * macroexp.c (struct macro_buffer) <release>: Add
10742         ATTRIBUTE_UNUSED_RESULT.
10743
10744 2019-03-05  Tom Tromey  <tromey@adacore.com>
10745
10746         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10747         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10748         ATTRIBUTE_UNUSED_RESULT.
10749
10750 2019-03-05  Tom Tromey  <tromey@adacore.com>
10751
10752         * common/scoped_fd.h (class scoped_fd) <release>: Add
10753         ATTRIBUTE_UNUSED_RESULT.
10754
10755 2019-03-05  Tom Tromey  <tromey@adacore.com>
10756
10757         * parser-defs.h (struct parser_state) <release>: Add
10758         ATTRIBUTE_UNUSED_RESULT.
10759
10760 2019-03-05  Tom Tromey  <tromey@adacore.com>
10761
10762         * utils.h (class gdb_argv) <release>: Add
10763         ATTRIBUTE_UNUSED_RESULT.
10764         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10765
10766 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10767
10768         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10769         for-loop range, to avoid compiler warnings.
10770
10771         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10772         avoid compiler warnings about unused variables.
10773
10774         * NEWS: Mention end of support for native debugging on MS-Windows
10775         before XP.
10776
10777         PR gdb/24292
10778         * common/netstuff.c:
10779         * gdbserver/gdbreplay.c
10780         * gdbserver/remote-utils.c:
10781         * ser-tcp.c:
10782         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10783         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10784         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10785         'getaddrinfo' and 'freeaddrinfo' were not available before
10786         Windows XP, and mingw.org's MinGW headers by default define
10787         _WIN32_WINNT to 0x500.
10788
10789 2019-03-01  Gary Benson <gbenson@redhat.com>
10790
10791         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10792
10793 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10794             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10795
10796         PR gdb/8527
10797         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10798         set_sigint_trap, clear_sigint_trap.
10799
10800 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10801
10802         * target.c (target_detach): Clear the regcache and the
10803         frame cache.
10804
10805 2019-02-27  Pedro Alves  <palves@redhat.com>
10806
10807         * utils.c (set_screen_size): When we cap the height/width sizes,
10808         tweak the corresponding command variable to show "unlimited":
10809
10810 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10811             Pedro Alves  <palves@redhat.com>
10812
10813         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10814         before calling rl_set_screen_size.
10815
10816 2019-02-27  Tom Tromey  <tromey@adacore.com>
10817
10818         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10819         define.
10820         * python/py-value.c: Remove Python 2.4 workaround.
10821         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10822         workaround.
10823         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10824         Python 2.4 workaround.
10825         * python/python-internal.h: Remove Python 2.4 comment.
10826         (Py_ssize_t): Don't define.
10827         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10828         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10829         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10830         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10831         * python/python.c (do_start_initialization): Remove Python 2.4
10832         workaround.
10833         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10834         (print_children): Remove Python 2.4 workaround.
10835         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10836         workaround.
10837         (CHARBUFFERPROC_NAME): Remove.
10838         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10839         Python 2.4 workaround.
10840
10841 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10842
10843         * NEWS: Note minimum Python version.
10844
10845 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10846
10847         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10848         code from these functions.  Remove corresponding ifdefs.  Use
10849         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10850         Remove gotos and target of gotos.
10851         (infpy_search_memory): Likewise.
10852
10853 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10854
10855         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10856         (hppa_gdbarch_init): Don't register deleted functions with
10857         gdbarch.
10858
10859 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10860
10861         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10862         (h8300_unwind_sp): Delete.
10863         (h8300_dummy_id): Delete.
10864         (h8300_gdbarch_init): Don't register deleted functions with
10865         gdbarch.
10866
10867 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10868
10869         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
10870         (ft32_unwind_pc): Delete.
10871         (ft32_unwind_sp): Delete.
10872         (ft32_gdbarch_init): Don't register deleted functions with
10873         gdbarch.
10874
10875 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10876
10877         * gdb/frv-tdep.c (frv_dummy_id): Delete.
10878         (frv_unwind_pc): Delete.
10879         (frv_unwind_sp): Delete.
10880         (frv_gdbarch_init): Don't register deleted functions with
10881         gdbarch.
10882
10883 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10884
10885         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
10886         (riscv_unwind_pc): Delete.
10887         (riscv_unwind_sp): Delete.
10888         (riscv_gdbarch_init): Don't register deleted functions with
10889         gdbarch.
10890
10891 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10892
10893         * gdb/csky-tdep.c (csky_dummy_id): Delete.
10894         (csky_unwind_pc): Delete.
10895         (csky_unwind_sp): Delete.
10896         (csky_gdbarch_init): Don't register deleted functions with
10897         gdbarch.
10898
10899 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10900
10901         * gdb/cris-tdep.c (cris_dummy_id): Delete.
10902         (cris_unwind_pc): Delete.
10903         (cris_unwind_sp): Delete.
10904         (cris_gdbarch_init): Don't register deleted functions with
10905         gdbarch.
10906
10907 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10908
10909         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
10910         (bfin_unwind_pc): Delete.
10911         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
10912
10913 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10914
10915         * gdb/arm-tdep.c (arm_dummy_id): Delete.
10916         (arm_unwind_pc): Delete.
10917         (arm_unwind_sp): Delete.
10918         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
10919
10920 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10921
10922         * gdb/arc-tdep.c (arc_dummy_id): Delete.
10923         (arc_unwind_pc): Delete.
10924         (arc_unwind_sp): Delete.
10925         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
10926
10927 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10928
10929         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
10930         (alpha_unwind_pc): Delete.
10931         (alpha_gdbarch_init): Don't register deleted functions with
10932         gdbarch.
10933
10934 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10935
10936         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
10937         (aarch64_unwind_pc): Delete.
10938         (aarch64_unwind_sp): Delete.
10939         (aarch64_gdbarch_init): Don't register deleted functions with
10940         gdbarch.
10941
10942 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10943
10944         * gdbtypes.c (type_align): Don't consider static members when
10945         computing structure alignment.
10946
10947 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10948
10949         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
10950         return 0 for other types.
10951         * arch-utils.c (default_type_align): Always return 0.
10952         * gdbarch.h: Regenerate.
10953         * gdbarch.sh (type_align): Extend comment.
10954         * gdbtypes.c (type_align): Add additional comments, always call
10955         gdbarch_type_align before applying the default rules.
10956         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
10957         generic code will then apply a suitable default.
10958         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
10959         types, return 0 for other types.
10960
10961 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10962
10963         * NEWS: Create a new section for the next release branch.
10964         Rename the section of the current branch, now that it has
10965         been cut.
10966
10967 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
10968
10969         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
10970         * version.in: Bump version to 8.3.50.DATE-git.
10971
10972 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
10973
10974         * aix-thread.c (ptid_cmp): Remove unused variable.
10975         (get_signaled_thread): Likewise.
10976         (store_regs_user_thread): Likewise.
10977         (store_regs_kernel_thread): Likewise.
10978         (fetch_regs_kernel_thread): Remove shadowed variable.
10979
10980 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
10981
10982         * features/riscv/32bit-cpu.xml: Add register numbers.
10983         * features/riscv/32bit-fpu.c: Regenerate.
10984         * features/riscv/32bit-fpu.xml: Add register numbers.
10985         * features/riscv/64bit-cpu.xml: Add register numbers.
10986         * features/riscv/64bit-fpu.c: Regenerate.
10987         * features/riscv/64bit-fpu.xml: Add register numbers.
10988
10989 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
10990
10991         * NEWS: Mention two argument form of gdb.Value constructor.
10992         * python/py-value.c (convert_buffer_and_type_to_value): New
10993         function.
10994         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
10995         Add support for handling an optional second argument.  Call
10996         convert_buffer_and_type_to_value as appropriate.
10997         * python/python-internal.h (Py_buffer_deleter): New struct.
10998         (Py_buffer_up): New typedef.
10999
11000 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11001
11002         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11003         instead of releasing ownership.
11004
11005 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11006
11007         * dwarf2read.c (open_and_init_dwp_file): Call
11008         elf_numsections instead of bfd_count_sections to initialize
11009         dwp_file->num_sections.
11010
11011 2019-02-25  Tom Tromey  <tromey@adacore.com>
11012
11013         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11014
11015 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11016
11017         * gcore.in: Add '--readnever' option when invoking GDB.
11018
11019 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11020
11021         * MAINTAINERS: Update my email address.
11022
11023 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11024
11025         * build-id.c (build_id_to_debug_bfd_1): New function.
11026         (build_id_to_debug_bfd): Look for separate debug file in
11027         sysroot.
11028
11029 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11030
11031         * gdbarch.sh: Update the copyright year range that is placed into
11032         generated files.
11033
11034 2019-02-22  Keith Seitz  <keiths@redhat.com>
11035
11036         PR symtab/23853
11037         * linespec.c (create_sals_line_offset): Search for the default
11038         symtab's filename instead of its fullname.
11039
11040 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11041
11042         * NEWS: Update style defaults.
11043
11044 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11045
11046         * main.c (captured_main_1): Disable styling in batch mode.
11047
11048 2019-02-20  Tom Tromey  <tom@tromey.com>
11049
11050         * symtab.c (symtab_symbol_info): Fix typos.
11051
11052 2019-02-20  Tom Tromey  <tromey@adacore.com>
11053
11054         * findcmd.c (_initialize_mem_search): Use upper case for
11055         metasyntactic variables.
11056
11057 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11058
11059         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11060         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11061
11062 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11063
11064         * top.h (source_file_name): Change to std::string.
11065         * top.c (source_file_name): Likewise.
11066         (command_line_input): Adjust.
11067         * cli/cli-script.c (script_from_file): Adjust.
11068
11069 2019-02-19  Tom Tromey  <tromey@adacore.com>
11070
11071         * ravenscar-thread.c
11072         (ravenscar_thread_target::update_thread_list): Don't call
11073         ada_build_task_list.
11074         * ada-lang.h (ada_build_task_list): Don't declare.
11075         * ada-tasks.c (struct ada_tasks_inferior_data)
11076         <task_list_valid_p>: Now bool.
11077         (read_known_tasks, ada_task_list_changed)
11078         (ada_tasks_invalidate_inferior_data): Update.
11079         (read_known_tasks_array): Return bool.
11080         (read_known_tasks_list): Likewise.
11081         (read_known_tasks): Return void.
11082         (ada_build_task_list): Now static.
11083
11084 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11085
11086         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11087         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11088
11089 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11090
11091         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11092         variant for ada_tasks_pspace_data_handle and
11093         ada_tasks_inferior_data_handle.
11094         (ada_tasks_pspace_data_cleanup): New function.
11095         (ada_tasks_inferior_data_cleanup): New function.
11096
11097 2019-02-17  Tom Tromey  <tom@tromey.com>
11098
11099         * macrotab.h (macro_source_fullname): Return a std::string.
11100         * macrotab.c (macro_include, check_for_redefinition)
11101         (macro_undef, macro_lookup_definition, foreach_macro)
11102         (foreach_macro_in_scope): Update.
11103         (macro_source_fullname): Return a std::string.
11104         * macrocmd.c (show_pp_source_pos): Update.
11105
11106 2019-02-17  Tom Tromey  <tom@tromey.com>
11107
11108         * macrocmd.c (show_pp_source_pos): Style the file names.
11109
11110 2019-02-17  Tom Tromey  <tom@tromey.com>
11111
11112         PR tui/24197:
11113         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11114
11115 2019-02-17  Tom Tromey  <tom@tromey.com>
11116
11117         * ada-lang.c (user_select_syms): Use filtered printing.
11118         * utils.c (wrap_style): New global.
11119         (desired_style): Remove.
11120         (emit_style_escape): Add stream parameter.
11121         (set_output_style, reset_terminal_style, prompt_for_continue):
11122         Update.
11123         (flush_wrap_buffer): Only flush gdb_stdout.
11124         (wrap_here): Set wrap_style.
11125         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11126         treat escape sequences as a character.  Change when wrap buffer is
11127         flushed.
11128         (fputs_styled): Do not set the output style when the default is
11129         requested.
11130         * ui-style.h (struct ui_file_style) <is_default>: New method.
11131         * source.c (print_source_lines_base): Emit escape sequences in one
11132         piece.
11133
11134 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11135
11136         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11137         integers and enumeration types.
11138
11139 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11140
11141         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11142         instead of lookup_symbol_in_language
11143         (do_exact_match): New function.
11144         (ada_get_symbol_name_matcher): Return do_exact_match when
11145         doing a verbatim match.
11146
11147 2019-02-15  Tom Tromey  <tromey@adacore.com>
11148
11149         * ravenscar-thread.c (ravenscar_thread_target::resume)
11150         (ravenscar_thread_target::wait): Special case wildcard requests.
11151
11152 2019-02-15  Tom Tromey  <tromey@adacore.com>
11153
11154         * ravenscar-thread.c (base_ptid): Remove.
11155         (struct ravenscar_thread_target) <close>: New method.
11156         <m_base_ptid>: New member.
11157         <update_inferior_ptid, active_task, task_is_currently_active,
11158         runtime_initialized>: Declare methods.
11159         <ravenscar_thread_target>: Add constructor.
11160         (ravenscar_thread_target::task_is_currently_active)
11161         (ravenscar_thread_target::update_inferior_ptid)
11162         (ravenscar_runtime_initialized): Rename.  Now methods.
11163         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11164         (ravenscar_thread_target::update_thread_list): Update.
11165         (ravenscar_thread_target::active_task): Now method.
11166         (ravenscar_thread_target::store_registers)
11167         (ravenscar_thread_target::prepare_to_store)
11168         (ravenscar_thread_target::prepare_to_store)
11169         (ravenscar_thread_target::mourn_inferior): Update.
11170         (ravenscar_inferior_created): Use "new" to create target.
11171         (ravenscar_thread_target::get_ada_task_ptid): Update.
11172         (_initialize_ravenscar): Don't initialize base_ptid.
11173         (ravenscar_ops): Remove global.
11174
11175 2019-02-15  Tom Tromey  <tromey@adacore.com>
11176
11177         * target.h (push_target): Declare new overload.
11178         * target.c (push_target): New overload, taking an rvalue reference.
11179         * remote.c (remote_target::open_1): Use push_target overload.
11180         * corelow.c (core_target_open): Use push_target overload.
11181
11182 2019-02-15  Tom Tromey  <tromey@adacore.com>
11183
11184         * ravenscar-thread.c (is_ravenscar_task)
11185         (ravenscar_task_is_currently_active): Return bool.
11186         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11187         (_initialize_ravenscar): Remove "(void)".
11188         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11189         Return bool.
11190
11191 2019-02-15  Tom Tromey  <tromey@adacore.com>
11192
11193         * ravenscar-thread.c (ravenscar_runtime_initializer)
11194         (has_ravenscar_runtime, get_running_thread_id)
11195         (ravenscar_thread_target::resume): Fix indentation.
11196
11197 2019-02-15  Tom Tromey  <tromey@adacore.com>
11198
11199         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11200         from ravenscar_arch_ops.
11201         (sparc_ravenscar_ops::fetch_registers)
11202         (sparc_ravenscar_ops::store_registers): Now methods.
11203         (sparc_ravenscar_prepare_to_store): Remove.
11204         (sparc_ravenscar_ops): Redefine.
11205         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11206         methods and destructor.  Remove members.
11207         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11208         (ravenscar_thread_target::store_registers)
11209         (ravenscar_thread_target::prepare_to_store): Update.
11210         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11211         Remove.
11212         (struct ppc_ravenscar_powerpc_ops): Derive from
11213         ravenscar_arch_ops.
11214         (ppc_ravenscar_powerpc_ops::fetch_registers)
11215         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11216         (ppc_ravenscar_powerpc_ops): Redefine.
11217         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11218         (ppc_ravenscar_e500_ops::fetch_registers)
11219         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11220         (ppc_ravenscar_e500_ops): Redefine.
11221         * aarch64-ravenscar-thread.c
11222         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11223         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11224         (aarch64_ravenscar_fetch_registers)
11225         (aarch64_ravenscar_store_registers): Now methods.
11226         (aarch64_ravenscar_ops): Redefine.
11227
11228 2019-02-15  Tom Tromey  <tromey@adacore.com>
11229
11230         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11231         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11232         (ravenscar_thread_target::stopped_by_watchpoint)
11233         (ravenscar_thread_target::stopped_data_address)
11234         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11235
11236 2019-02-15  Tom Tromey  <tromey@adacore.com>
11237
11238         * ravenscar-thread.c: Fix some typos.
11239
11240 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11241             Tom Tromey  <tromey@adacore.com>
11242
11243         * ada-lang.c (ada_exception_sal): Change addr_string to a
11244         std::string.
11245         (create_ada_exception_catchpoint): Update.
11246
11247 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11248             Tom Tromey  <tromey@adacore.com>
11249
11250         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11251         (bp_location_ops): Remove.
11252         (base_breakpoint_allocate_location): Update.
11253         (free_bp_location): Update.
11254         * ada-lang.c (class ada_catchpoint_location)
11255         <ada_catchpoint_location>: Remove ops parameter.
11256         (ada_catchpoint_location_dtor): Remove.
11257         (ada_catchpoint_location_ops): Remove.
11258         (allocate_location_exception): Update.
11259         * breakpoint.h (struct bp_location_ops): Remove.
11260         (class bp_location) <bp_location>: Remove bp_location_ops
11261         parameter.
11262         <~bp_location>: Add destructor.
11263         <ops>: Remove.
11264
11265 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11266             Pedro Alves  <palves@redhat.com>
11267
11268         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11269         'PATH_MAX'.
11270
11271 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11272             Samuel Thibault  <samuel.thibault@gnu.org>
11273             Thomas Schwinge  <thomas@codesourcery.com>
11274
11275         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11276         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11277
11278 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11279
11280         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11281         (check_empty): Use "const char *".
11282
11283         * gnu-nat.c (gnu_nat_target::detach): Instead of
11284         'detach_inferior (pid)' call
11285         'detach_inferior (find_inferior_pid (pid))'.
11286
11287         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11288         'nat/fork-inferior.o'.
11289         * gnu-nat.c: #include "nat/fork-inferior.h".
11290
11291         * gnu-nat.c (gnu_nat_target::detach): Instead of
11292         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11293         * gnu-nat.h: #include "inf-child.h".
11294         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11295         'i386_gnu_nat_target::fetch_registers'.
11296         (gnu_store_registers): Rename/move to
11297         'i386_gnu_nat_target::store_registers'.
11298
11299         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11300         * gnu-nat.h (mach_thread_info): New function.
11301         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11302
11303         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11304
11305 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11306
11307         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11308
11309 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11310
11311         * windows-nat.c (windows_add_thread): Add new parameter
11312         "main_thread_p" with default value set to false.  Update
11313         function documentation as well as all callers.
11314         (windows_delete_thread): Likewise.
11315         (fake_create_process): Update call to windows_add_thread.
11316         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11317         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11318         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11319         call to windows_delete_thread.
11320
11321 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11322
11323         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11324
11325 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11326
11327         * symfile.c (find_separate_debug_file): Use canonical path of
11328         sysroot with child_path instead of gdb_sysroot if it is valid.
11329
11330 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11331
11332         * symfile.c (find_separate_debug_file): Use child_path to
11333         determine if an object file is under a sysroot.
11334
11335 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11336
11337         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11338         unittests/child-path-selftests.c.
11339         * common/pathstuff.c (child_path): New function.
11340         * common/pathstuff.h (child_path): New prototype.
11341         * unittests/child-path-selftests.c: New file.
11342
11343 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11344
11345         * symfile.c (find_separate_debug_file): Look for separate debug
11346         files in debug directories under the sysroot.
11347
11348 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11349
11350         * symtab.h (struct minimal_symbol data_p): New const method.
11351         (struct minimal_symbol text_p): Likewise.
11352         * symtab.c (output_source_filename): Use file name style
11353         to print file name.
11354         (print_symbol_info): Likewise.
11355         (print_msymbol_info): Use address style to print addresses.
11356         Use function name style to print executable text symbols.
11357         (expand_symtab_containing_pc): Use data_p.
11358         (find_pc_sect_compunit_symtab): Likewise.
11359
11360 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11361
11362         * breakpoint.c (describe_other_breakpoints): Use address style
11363         to print addresses.
11364         (say_where): Likewise.
11365
11366 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11367
11368         * ada-typeprint.c (print_func_type): Print function name
11369         style to print function name.
11370         * c-typeprint.c (c_print_type_1): Likewise.
11371
11372 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11373
11374         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11375         for execve.
11376
11377 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11378
11379         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11380         type_stack.
11381
11382 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11383
11384         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11385         TYPE_CODE_REF types.
11386
11387 2019-02-08  Jim Wilson  <jimw@sifive.com>
11388
11389         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11390         (riscv_linux_fregset): New.
11391         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11392
11393 2019-02-07  Tom Tromey  <tom@tromey.com>
11394
11395         * thread.c (thread_cancel_execution_command): Update.
11396         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11397         methods.
11398         (struct thread_fsm_ops): Remove.
11399         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11400         (thread_fsm_should_stop, thread_fsm_return_value)
11401         (thread_fsm_set_finished, thread_fsm_finished_p)
11402         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11403         Don't declare.
11404         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11405         * infrun.c (clear_proceed_status_thread)
11406         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11407         (print_stop_event): Update.
11408         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11409         Add constructor.
11410         (step_command_fsm_ops): Remove.
11411         (new_step_command_fsm): Remove.
11412         (step_1): Update.
11413         (step_command_fsm::should_stop): Rename from
11414         step_command_fsm_should_stop.
11415         (step_command_fsm::clean_up): Rename from
11416         step_command_fsm_clean_up.
11417         (step_command_fsm::do_async_reply_reason): Rename from
11418         step_command_fsm_async_reply_reason.
11419         (struct until_next_fsm): Inherit from thread_fsm.  Add
11420         constructor.
11421         (until_next_fsm_ops): Remove.
11422         (new_until_next_fsm): Remove.
11423         (until_next_fsm::should_stop): Rename from
11424         until_next_fsm_should_stop.
11425         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11426         (until_next_fsm::do_async_reply_reason): Rename from
11427         until_next_fsm_async_reply_reason.
11428         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11429         constructor.  Change type of breakpoint.
11430         (finish_command_fsm_ops): Remove.
11431         (new_finish_command_fsm): Remove.
11432         (finish_command_fsm::should_stop): Rename from
11433         finish_command_fsm_should_stop.
11434         (finish_command_fsm::clean_up): Rename from
11435         finish_command_fsm_clean_up.
11436         (finish_command_fsm::return_value): Rename from
11437         finish_command_fsm_return_value.
11438         (finish_command_fsm::do_async_reply_reason): Rename from
11439         finish_command_fsm_async_reply_reason.
11440         (finish_command): Update.
11441         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11442         Add constructor.
11443         (call_thread_fsm_ops): Remove.
11444         (call_thread_fsm::call_thread_fsm): Rename from
11445         new_call_thread_fsm.
11446         (call_thread_fsm::should_stop): Rename from
11447         call_thread_fsm_should_stop.
11448         (call_thread_fsm::should_notify_stop): Rename from
11449         call_thread_fsm_should_notify_stop.
11450         (run_inferior_call, call_function_by_hand_dummy): Update.
11451         * cli/cli-interp.c (should_print_stop_to_console): Update.
11452         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11453         Add constructor.  Change type of location_breakpoint,
11454         caller_breakpoint.
11455         (until_break_fsm_ops): Remove.
11456         (new_until_break_fsm): Remove.
11457         (until_break_fsm::should_stop): Rename from
11458         until_break_fsm_should_stop.
11459         (until_break_fsm::clean_up): Rename from
11460         until_break_fsm_clean_up.
11461         (until_break_fsm::do_async_reply_reason): Rename from
11462         until_break_fsm_async_reply_reason.
11463         (until_break_command): Update.
11464         * thread-fsm.c: Remove.
11465         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11466
11467 2019-02-07  Tom Tromey  <tom@tromey.com>
11468
11469         * yy-remap.h: Add include guard.
11470         * xtensa-tdep.h: Add include guard.
11471         * xcoffread.h: Rename include guard.
11472         * varobj-iter.h: Add include guard.
11473         * tui/tui.h: Rename include guard.
11474         * tui/tui-winsource.h: Rename include guard.
11475         * tui/tui-wingeneral.h: Rename include guard.
11476         * tui/tui-windata.h: Rename include guard.
11477         * tui/tui-win.h: Rename include guard.
11478         * tui/tui-stack.h: Rename include guard.
11479         * tui/tui-source.h: Rename include guard.
11480         * tui/tui-regs.h: Rename include guard.
11481         * tui/tui-out.h: Rename include guard.
11482         * tui/tui-layout.h: Rename include guard.
11483         * tui/tui-io.h: Rename include guard.
11484         * tui/tui-hooks.h: Rename include guard.
11485         * tui/tui-file.h: Rename include guard.
11486         * tui/tui-disasm.h: Rename include guard.
11487         * tui/tui-data.h: Rename include guard.
11488         * tui/tui-command.h: Rename include guard.
11489         * tic6x-tdep.h: Add include guard.
11490         * target/waitstatus.h: Rename include guard.
11491         * target/wait.h: Rename include guard.
11492         * target/target.h: Rename include guard.
11493         * target/resume.h: Rename include guard.
11494         * target-float.h: Rename include guard.
11495         * stabsread.h: Add include guard.
11496         * rs6000-tdep.h: Add include guard.
11497         * riscv-fbsd-tdep.h: Add include guard.
11498         * regformats/regdef.h: Rename include guard.
11499         * record.h: Rename include guard.
11500         * python/python.h: Rename include guard.
11501         * python/python-internal.h: Rename include guard.
11502         * python/py-stopevent.h: Rename include guard.
11503         * python/py-ref.h: Rename include guard.
11504         * python/py-record.h: Rename include guard.
11505         * python/py-record-full.h: Rename include guard.
11506         * python/py-record-btrace.h: Rename include guard.
11507         * python/py-instruction.h: Rename include guard.
11508         * python/py-events.h: Rename include guard.
11509         * python/py-event.h: Rename include guard.
11510         * procfs.h: Add include guard.
11511         * proc-utils.h: Add include guard.
11512         * p-lang.h: Add include guard.
11513         * or1k-tdep.h: Rename include guard.
11514         * observable.h: Rename include guard.
11515         * nto-tdep.h: Rename include guard.
11516         * nat/x86-linux.h: Rename include guard.
11517         * nat/x86-linux-dregs.h: Rename include guard.
11518         * nat/x86-gcc-cpuid.h: Add include guard.
11519         * nat/x86-dregs.h: Rename include guard.
11520         * nat/x86-cpuid.h: Rename include guard.
11521         * nat/ppc-linux.h: Rename include guard.
11522         * nat/mips-linux-watch.h: Rename include guard.
11523         * nat/linux-waitpid.h: Rename include guard.
11524         * nat/linux-ptrace.h: Rename include guard.
11525         * nat/linux-procfs.h: Rename include guard.
11526         * nat/linux-osdata.h: Rename include guard.
11527         * nat/linux-nat.h: Rename include guard.
11528         * nat/linux-namespaces.h: Rename include guard.
11529         * nat/linux-btrace.h: Rename include guard.
11530         * nat/glibc_thread_db.h: Rename include guard.
11531         * nat/gdb_thread_db.h: Rename include guard.
11532         * nat/gdb_ptrace.h: Rename include guard.
11533         * nat/fork-inferior.h: Rename include guard.
11534         * nat/amd64-linux-siginfo.h: Rename include guard.
11535         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11536         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11537         * nat/aarch64-linux.h: Rename include guard.
11538         * nat/aarch64-linux-hw-point.h: Rename include guard.
11539         * mn10300-tdep.h: Add include guard.
11540         * mips-linux-tdep.h: Add include guard.
11541         * mi/mi-parse.h: Rename include guard.
11542         * mi/mi-out.h: Rename include guard.
11543         * mi/mi-main.h: Rename include guard.
11544         * mi/mi-interp.h: Rename include guard.
11545         * mi/mi-getopt.h: Rename include guard.
11546         * mi/mi-console.h: Rename include guard.
11547         * mi/mi-common.h: Rename include guard.
11548         * mi/mi-cmds.h: Rename include guard.
11549         * mi/mi-cmd-break.h: Rename include guard.
11550         * m2-lang.h: Add include guard.
11551         * location.h: Rename include guard.
11552         * linux-record.h: Rename include guard.
11553         * linux-nat.h: Add include guard.
11554         * linux-fork.h: Add include guard.
11555         * i386-darwin-tdep.h: Rename include guard.
11556         * hppa-linux-offsets.h: Add include guard.
11557         * guile/guile.h: Rename include guard.
11558         * guile/guile-internal.h: Rename include guard.
11559         * gnu-nat.h: Rename include guard.
11560         * gdb-stabs.h: Rename include guard.
11561         * frv-tdep.h: Add include guard.
11562         * f-lang.h: Add include guard.
11563         * event-loop.h: Add include guard.
11564         * darwin-nat.h: Rename include guard.
11565         * cp-abi.h: Rename include guard.
11566         * config/sparc/nm-sol2.h: Rename include guard.
11567         * config/nm-nto.h: Rename include guard.
11568         * config/nm-linux.h: Add include guard.
11569         * config/i386/nm-i386gnu.h: Rename include guard.
11570         * config/djgpp/nl_types.h: Rename include guard.
11571         * config/djgpp/langinfo.h: Rename include guard.
11572         * compile/gcc-cp-plugin.h: Add include guard.
11573         * compile/gcc-c-plugin.h: Add include guard.
11574         * compile/compile.h: Rename include guard.
11575         * compile/compile-object-run.h: Rename include guard.
11576         * compile/compile-object-load.h: Rename include guard.
11577         * compile/compile-internal.h: Rename include guard.
11578         * compile/compile-cplus.h: Rename include guard.
11579         * compile/compile-c.h: Rename include guard.
11580         * common/xml-utils.h: Rename include guard.
11581         * common/x86-xstate.h: Rename include guard.
11582         * common/version.h: Rename include guard.
11583         * common/vec.h: Rename include guard.
11584         * common/tdesc.h: Rename include guard.
11585         * common/selftest.h: Rename include guard.
11586         * common/scoped_restore.h: Rename include guard.
11587         * common/scoped_mmap.h: Rename include guard.
11588         * common/scoped_fd.h: Rename include guard.
11589         * common/safe-iterator.h: Rename include guard.
11590         * common/run-time-clock.h: Rename include guard.
11591         * common/refcounted-object.h: Rename include guard.
11592         * common/queue.h: Rename include guard.
11593         * common/ptid.h: Rename include guard.
11594         * common/print-utils.h: Rename include guard.
11595         * common/preprocessor.h: Rename include guard.
11596         * common/pathstuff.h: Rename include guard.
11597         * common/observable.h: Rename include guard.
11598         * common/netstuff.h: Rename include guard.
11599         * common/job-control.h: Rename include guard.
11600         * common/host-defs.h: Rename include guard.
11601         * common/gdb_wait.h: Rename include guard.
11602         * common/gdb_vecs.h: Rename include guard.
11603         * common/gdb_unlinker.h: Rename include guard.
11604         * common/gdb_unique_ptr.h: Rename include guard.
11605         * common/gdb_tilde_expand.h: Rename include guard.
11606         * common/gdb_sys_time.h: Rename include guard.
11607         * common/gdb_string_view.h: Rename include guard.
11608         * common/gdb_splay_tree.h: Rename include guard.
11609         * common/gdb_setjmp.h: Rename include guard.
11610         * common/gdb_ref_ptr.h: Rename include guard.
11611         * common/gdb_optional.h: Rename include guard.
11612         * common/gdb_locale.h: Rename include guard.
11613         * common/gdb_assert.h: Rename include guard.
11614         * common/filtered-iterator.h: Rename include guard.
11615         * common/filestuff.h: Rename include guard.
11616         * common/fileio.h: Rename include guard.
11617         * common/environ.h: Rename include guard.
11618         * common/common-utils.h: Rename include guard.
11619         * common/common-types.h: Rename include guard.
11620         * common/common-regcache.h: Rename include guard.
11621         * common/common-inferior.h: Rename include guard.
11622         * common/common-gdbthread.h: Rename include guard.
11623         * common/common-exceptions.h: Rename include guard.
11624         * common/common-defs.h: Rename include guard.
11625         * common/common-debug.h: Rename include guard.
11626         * common/cleanups.h: Rename include guard.
11627         * common/buffer.h: Rename include guard.
11628         * common/btrace-common.h: Rename include guard.
11629         * common/break-common.h: Rename include guard.
11630         * cli/cli-utils.h: Rename include guard.
11631         * cli/cli-style.h: Rename include guard.
11632         * cli/cli-setshow.h: Rename include guard.
11633         * cli/cli-script.h: Rename include guard.
11634         * cli/cli-interp.h: Rename include guard.
11635         * cli/cli-decode.h: Rename include guard.
11636         * cli/cli-cmds.h: Rename include guard.
11637         * charset-list.h: Add include guard.
11638         * buildsym-legacy.h: Rename include guard.
11639         * bfin-tdep.h: Add include guard.
11640         * ax.h: Rename include guard.
11641         * arm-linux-tdep.h: Add include guard.
11642         * arm-fbsd-tdep.h: Add include guard.
11643         * arch/xtensa.h: Rename include guard.
11644         * arch/tic6x.h: Add include guard.
11645         * arch/i386.h: Add include guard.
11646         * arch/arm.h: Rename include guard.
11647         * arch/arm-linux.h: Rename include guard.
11648         * arch/arm-get-next-pcs.h: Rename include guard.
11649         * arch/amd64.h: Add include guard.
11650         * arch/aarch64-insn.h: Rename include guard.
11651         * arch-utils.h: Rename include guard.
11652         * annotate.h: Add include guard.
11653         * amd64-darwin-tdep.h: Rename include guard.
11654         * aarch64-linux-tdep.h: Add include guard.
11655         * aarch64-fbsd-tdep.h: Add include guard.
11656         * aarch32-linux-nat.h: Add include guard.
11657
11658 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11659
11660         * macrotab.c (macro_define_internal): New function that
11661         factorizes macro_define_object_internal and macro_define_function
11662         code.
11663         (macro_define_object_internal): Use macro_define_internal.
11664         (macro_define_function): Likewise.
11665
11666 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11667
11668         * macrocmd.c (extract_identifier): Return
11669         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11670         callers.
11671
11672 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11673
11674         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11675
11676 2019-02-05  Tom Tromey  <tom@tromey.com>
11677
11678         * target.c (target_stack::unpush): Move assertion earlier.
11679
11680 2019-01-30  Tom Tromey  <tom@tromey.com>
11681
11682         PR python/23615:
11683         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11684         (gdbpy_parse_and_eval): Likewise.
11685         * python/python-internal.h (gdbpy_allow_threads): New class.
11686
11687 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11688
11689         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11690         (aarch64_fbsd_fpregmap): Move earlier.
11691         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11692         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11693         instead of individual calls to trad_frame_set_reg_addr.
11694         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11695         earlier.
11696         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11697         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11698         instead of individual calls to trad_frame_set_reg_addr.
11699
11700 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11701
11702         * CONTRIBUTE: Replace contribution list with wiki link.
11703
11704 2019-01-25  Tom Tromey  <tom@tromey.com>
11705
11706         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11707
11708 2019-01-25  Tom Tromey  <tom@tromey.com>
11709
11710         * xtensa-linux-nat.c: Fix common/ includes.
11711         * xml-support.h: Fix common/ includes.
11712         * xml-support.c: Fix common/ includes.
11713         * x86-linux-nat.c: Fix common/ includes.
11714         * windows-nat.c: Fix common/ includes.
11715         * varobj.h: Fix common/ includes.
11716         * varobj.c: Fix common/ includes.
11717         * value.c: Fix common/ includes.
11718         * valops.c: Fix common/ includes.
11719         * utils.c: Fix common/ includes.
11720         * unittests/xml-utils-selftests.c: Fix common/ includes.
11721         * unittests/utils-selftests.c: Fix common/ includes.
11722         * unittests/unpack-selftests.c: Fix common/ includes.
11723         * unittests/tracepoint-selftests.c: Fix common/ includes.
11724         * unittests/style-selftests.c: Fix common/ includes.
11725         * unittests/string_view-selftests.c: Fix common/ includes.
11726         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11727         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11728         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11729         * unittests/rsp-low-selftests.c: Fix common/ includes.
11730         * unittests/parse-connection-spec-selftests.c: Fix common/
11731         includes.
11732         * unittests/optional-selftests.c: Fix common/ includes.
11733         * unittests/offset-type-selftests.c: Fix common/ includes.
11734         * unittests/observable-selftests.c: Fix common/ includes.
11735         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11736         * unittests/memrange-selftests.c: Fix common/ includes.
11737         * unittests/memory-map-selftests.c: Fix common/ includes.
11738         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11739         * unittests/function-view-selftests.c: Fix common/ includes.
11740         * unittests/environ-selftests.c: Fix common/ includes.
11741         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11742         * unittests/common-utils-selftests.c: Fix common/ includes.
11743         * unittests/cli-utils-selftests.c: Fix common/ includes.
11744         * unittests/array-view-selftests.c: Fix common/ includes.
11745         * ui-file.c: Fix common/ includes.
11746         * tui/tui-io.c: Fix common/ includes.
11747         * tracepoint.h: Fix common/ includes.
11748         * tracepoint.c: Fix common/ includes.
11749         * tracefile-tfile.c: Fix common/ includes.
11750         * top.h: Fix common/ includes.
11751         * top.c: Fix common/ includes.
11752         * thread.c: Fix common/ includes.
11753         * target/waitstatus.h: Fix common/ includes.
11754         * target/waitstatus.c: Fix common/ includes.
11755         * target.h: Fix common/ includes.
11756         * target.c: Fix common/ includes.
11757         * target-memory.c: Fix common/ includes.
11758         * target-descriptions.c: Fix common/ includes.
11759         * symtab.h: Fix common/ includes.
11760         * symfile.c: Fix common/ includes.
11761         * stap-probe.c: Fix common/ includes.
11762         * spu-linux-nat.c: Fix common/ includes.
11763         * sparc-nat.c: Fix common/ includes.
11764         * source.c: Fix common/ includes.
11765         * solib.c: Fix common/ includes.
11766         * solib-target.c: Fix common/ includes.
11767         * ser-unix.c: Fix common/ includes.
11768         * ser-tcp.c: Fix common/ includes.
11769         * ser-pipe.c: Fix common/ includes.
11770         * ser-base.c: Fix common/ includes.
11771         * selftest-arch.c: Fix common/ includes.
11772         * s12z-tdep.c: Fix common/ includes.
11773         * rust-exp.y: Fix common/ includes.
11774         * rs6000-aix-tdep.c: Fix common/ includes.
11775         * riscv-tdep.c: Fix common/ includes.
11776         * remote.c: Fix common/ includes.
11777         * remote-notif.h: Fix common/ includes.
11778         * remote-fileio.h: Fix common/ includes.
11779         * remote-fileio.c: Fix common/ includes.
11780         * regcache.h: Fix common/ includes.
11781         * regcache.c: Fix common/ includes.
11782         * record-btrace.c: Fix common/ includes.
11783         * python/python.c: Fix common/ includes.
11784         * python/py-type.c: Fix common/ includes.
11785         * python/py-inferior.c: Fix common/ includes.
11786         * progspace.h: Fix common/ includes.
11787         * producer.c: Fix common/ includes.
11788         * procfs.c: Fix common/ includes.
11789         * proc-api.c: Fix common/ includes.
11790         * printcmd.c: Fix common/ includes.
11791         * ppc-linux-nat.c: Fix common/ includes.
11792         * parser-defs.h: Fix common/ includes.
11793         * osdata.c: Fix common/ includes.
11794         * obsd-nat.c: Fix common/ includes.
11795         * nat/x86-linux.c: Fix common/ includes.
11796         * nat/x86-linux-dregs.c: Fix common/ includes.
11797         * nat/x86-dregs.h: Fix common/ includes.
11798         * nat/x86-dregs.c: Fix common/ includes.
11799         * nat/ppc-linux.c: Fix common/ includes.
11800         * nat/mips-linux-watch.h: Fix common/ includes.
11801         * nat/mips-linux-watch.c: Fix common/ includes.
11802         * nat/linux-waitpid.c: Fix common/ includes.
11803         * nat/linux-ptrace.h: Fix common/ includes.
11804         * nat/linux-ptrace.c: Fix common/ includes.
11805         * nat/linux-procfs.c: Fix common/ includes.
11806         * nat/linux-personality.c: Fix common/ includes.
11807         * nat/linux-osdata.c: Fix common/ includes.
11808         * nat/linux-namespaces.c: Fix common/ includes.
11809         * nat/linux-btrace.h: Fix common/ includes.
11810         * nat/linux-btrace.c: Fix common/ includes.
11811         * nat/fork-inferior.c: Fix common/ includes.
11812         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11813         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11814         * nat/aarch64-linux.c: Fix common/ includes.
11815         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11816         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11817         * namespace.h: Fix common/ includes.
11818         * mips-linux-tdep.c: Fix common/ includes.
11819         * minsyms.c: Fix common/ includes.
11820         * mi/mi-parse.h: Fix common/ includes.
11821         * mi/mi-main.c: Fix common/ includes.
11822         * mi/mi-cmd-env.c: Fix common/ includes.
11823         * memrange.h: Fix common/ includes.
11824         * memattr.c: Fix common/ includes.
11825         * maint.h: Fix common/ includes.
11826         * maint.c: Fix common/ includes.
11827         * main.c: Fix common/ includes.
11828         * machoread.c: Fix common/ includes.
11829         * location.c: Fix common/ includes.
11830         * linux-thread-db.c: Fix common/ includes.
11831         * linux-nat.c: Fix common/ includes.
11832         * linux-fork.c: Fix common/ includes.
11833         * inline-frame.c: Fix common/ includes.
11834         * infrun.c: Fix common/ includes.
11835         * inflow.c: Fix common/ includes.
11836         * inferior.h: Fix common/ includes.
11837         * inferior.c: Fix common/ includes.
11838         * infcmd.c: Fix common/ includes.
11839         * inf-ptrace.c: Fix common/ includes.
11840         * inf-child.c: Fix common/ includes.
11841         * ia64-linux-nat.c: Fix common/ includes.
11842         * i387-tdep.c: Fix common/ includes.
11843         * i386-tdep.c: Fix common/ includes.
11844         * i386-linux-tdep.c: Fix common/ includes.
11845         * i386-linux-nat.c: Fix common/ includes.
11846         * i386-go32-tdep.c: Fix common/ includes.
11847         * i386-fbsd-tdep.c: Fix common/ includes.
11848         * i386-fbsd-nat.c: Fix common/ includes.
11849         * guile/scm-type.c: Fix common/ includes.
11850         * guile/guile.c: Fix common/ includes.
11851         * go32-nat.c: Fix common/ includes.
11852         * gnu-nat.c: Fix common/ includes.
11853         * gdbthread.h: Fix common/ includes.
11854         * gdbarch-selftests.c: Fix common/ includes.
11855         * gdb_usleep.c: Fix common/ includes.
11856         * gdb_select.h: Fix common/ includes.
11857         * gdb_bfd.c: Fix common/ includes.
11858         * gcore.c: Fix common/ includes.
11859         * fork-child.c: Fix common/ includes.
11860         * findvar.c: Fix common/ includes.
11861         * fbsd-nat.c: Fix common/ includes.
11862         * event-top.c: Fix common/ includes.
11863         * event-loop.c: Fix common/ includes.
11864         * dwarf2read.c: Fix common/ includes.
11865         * dwarf2loc.c: Fix common/ includes.
11866         * dwarf2-frame.c: Fix common/ includes.
11867         * dwarf-index-cache.c: Fix common/ includes.
11868         * dtrace-probe.c: Fix common/ includes.
11869         * disasm-selftests.c: Fix common/ includes.
11870         * defs.h: Fix common/ includes.
11871         * csky-tdep.c: Fix common/ includes.
11872         * cp-valprint.c: Fix common/ includes.
11873         * cp-support.h: Fix common/ includes.
11874         * cp-support.c: Fix common/ includes.
11875         * corelow.c: Fix common/ includes.
11876         * completer.h: Fix common/ includes.
11877         * completer.c: Fix common/ includes.
11878         * compile/compile.c: Fix common/ includes.
11879         * compile/compile-loc2c.c: Fix common/ includes.
11880         * compile/compile-cplus-types.c: Fix common/ includes.
11881         * compile/compile-cplus-symbols.c: Fix common/ includes.
11882         * command.h: Fix common/ includes.
11883         * cli/cli-dump.c: Fix common/ includes.
11884         * cli/cli-cmds.c: Fix common/ includes.
11885         * charset.c: Fix common/ includes.
11886         * build-id.c: Fix common/ includes.
11887         * btrace.h: Fix common/ includes.
11888         * btrace.c: Fix common/ includes.
11889         * breakpoint.h: Fix common/ includes.
11890         * breakpoint.c: Fix common/ includes.
11891         * ax.h:
11892         (enum agent_op): Fix common/ includes.
11893         * ax-general.c (struct aop_map): Fix common/ includes.
11894         * ax-gdb.c: Fix common/ includes.
11895         * auxv.c: Fix common/ includes.
11896         * auto-load.c: Fix common/ includes.
11897         * arm-tdep.c: Fix common/ includes.
11898         * arch/riscv.c: Fix common/ includes.
11899         * arch/ppc-linux-common.c: Fix common/ includes.
11900         * arch/i386.c: Fix common/ includes.
11901         * arch/arm.c: Fix common/ includes.
11902         * arch/arm-linux.c: Fix common/ includes.
11903         * arch/arm-get-next-pcs.c: Fix common/ includes.
11904         * arch/amd64.c: Fix common/ includes.
11905         * arch/aarch64.c: Fix common/ includes.
11906         * arch/aarch64-insn.c: Fix common/ includes.
11907         * arch-utils.c: Fix common/ includes.
11908         * amd64-windows-tdep.c: Fix common/ includes.
11909         * amd64-tdep.c: Fix common/ includes.
11910         * amd64-sol2-tdep.c: Fix common/ includes.
11911         * amd64-obsd-tdep.c: Fix common/ includes.
11912         * amd64-nbsd-tdep.c: Fix common/ includes.
11913         * amd64-linux-tdep.c: Fix common/ includes.
11914         * amd64-linux-nat.c: Fix common/ includes.
11915         * amd64-fbsd-tdep.c: Fix common/ includes.
11916         * amd64-fbsd-nat.c: Fix common/ includes.
11917         * amd64-dicos-tdep.c: Fix common/ includes.
11918         * amd64-darwin-tdep.c: Fix common/ includes.
11919         * agent.c: Fix common/ includes.
11920         * ada-lang.h: Fix common/ includes.
11921         * ada-lang.c: Fix common/ includes.
11922         * aarch64-tdep.c: Fix common/ includes.
11923
11924 2019-01-25  Tom Tromey  <tom@tromey.com>
11925
11926         * common/create-version.sh: Use common/version.h.
11927
11928 2019-01-24  Pedro Alves  <palves@redhat.com>
11929
11930         * infrun.c (signal_stop, signal_print, signal_program)
11931         (signal_catch, signal_pass): Now arrays instead of pointers.
11932         (update_signals_program_target, do_target_resume)
11933         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
11934         * linux-nat.c (linux_nat_target::pass_signals)
11935         (linux_nat_target::create_inferior, linux_nat_target::attach):
11936         Adjust.
11937         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
11938         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
11939         * procfs.c (procfs_target::pass_signals): Adjust.
11940         * record-full.c (record_full_target::resume): Adjust.
11941         * remote.c (remote_target::pass_signals)
11942         (remote_target::program_signals): Adjust.
11943         * target-debug.h (target_debug_print_signals): Now takes a
11944         gdb::array_view as parameter.  Adjust.
11945         * target.h (target_ops) <pass_signals, program_signals>: Replace
11946         pointer and length parameters with gdb::array_view.
11947         (target_pass_signals, target_program_signals): Likewise.
11948         * target-delegates.c: Regenerate.
11949
11950 2019-01-24  Pedro Alves  <palves@redhat.com>
11951
11952         * common/forward-scope-exit.h
11953         (forward_scope_exit::forward_scope_exit): Pass arguments to
11954         m_bind_function directly, instead of creating a std::bind and
11955         copying that.
11956
11957 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
11958
11959         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
11960         for static members.
11961         (pass_in_v_vfp_candidate): Likewise.
11962
11963 2019-01-23  Tom Tromey  <tom@tromey.com>
11964             Pedro Alves  <palves@redhat.com>
11965
11966         * regcache.c (class regcache_invalidator): Remove.
11967         (regcache::raw_write): Use make_scope_exit.
11968
11969 2019-01-23  Tom Tromey  <tom@tromey.com>
11970
11971         * ui-out.h (class ui_out_emit_type): Update comment.
11972
11973 2019-01-23  Tom Tromey  <tom@tromey.com>
11974
11975         * infrun.c (fetch_inferior_event): Update comment.
11976
11977 2019-01-23  Tom Tromey  <tom@tromey.com>
11978             Pedro Alves  <palves@redhat.com>
11979
11980         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
11981         parameter.
11982         (fetch_inferior_event): Use SCOPE_EXIT.
11983
11984
11985 2019-01-23  Tom Tromey  <tom@tromey.com>
11986             Pedro Alves  <palves@redhat.com>
11987
11988         * infrun.c (disable_thread_events): Delete.
11989         (stop_all_threads): Use SCOPE_EXIT.
11990
11991 2019-01-23  Tom Tromey  <tom@tromey.com>
11992             Pedro Alves  <palves@redhat.com>
11993
11994         * symfile.c: Include forward-scope-exit.h.
11995         (clear_symtab_users_cleanup): Replace forward declaration with
11996         a FORWARD_SCOPE_EXIT.
11997         (syms_from_objfile_1): Use the forward_scope_exit and
11998         gdb::optional instead of cleanup_function.
11999         (reread_symbols): Use the forward_scope_exit instead of
12000         cleanup_function.
12001         (clear_symtab_users_cleanup): Remove function.
12002
12003 2019-01-23  Tom Tromey  <tom@tromey.com>
12004             Pedro Alves  <palves@redhat.com>
12005
12006         * linux-nat.c: Include scope-exit.h.
12007         (cleanup_target_stop): Remove.
12008         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12009         SCOPE_EXIT.
12010
12011 2019-01-23  Tom Tromey  <tom@tromey.com>
12012             Pedro Alves  <palves@redhat.com>
12013
12014         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12015         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12016
12017 2019-01-23  Tom Tromey  <tom@tromey.com>
12018             Andrew Burgess  <andrew.burgess@embecosm.com>
12019             Pedro Alves  <palves@redhat.com>
12020
12021         * infrun.c (fetch_inferior_event): Use scope_exit.
12022         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12023         * top.c (execute_command): Use scope_exit.
12024         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12025         * utils.c (do_bpstat_clear_actions_cleanup)
12026         (make_bpstat_clear_actions_cleanup): Remove.
12027
12028 2019-01-23  Tom Tromey  <tom@tromey.com>
12029             Pedro Alves  <palves@redhat.com>
12030
12031         * infrun.c: Include "common/scope-exit.h"
12032         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12033         (wait_for_inferior): Use SCOPE_EXIT.
12034         (fetch_inferior_event): Use scope_exit.
12035
12036 2019-01-23  Tom Tromey  <tom@tromey.com>
12037             Pedro Alves  <palves@redhat.com>
12038
12039         * breakpoint.c (create_breakpoint): Remove cleanup.
12040
12041 2019-01-23  Tom Tromey  <tom@tromey.com>
12042             Andrew Burgess  <andrew.burgess@embecosm.com>
12043             Pedro Alves  <palves@redhat.com>
12044
12045 2019-01-23  Pedro Alves  <palves@redhat.com>
12046
12047         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12048
12049 2019-01-23  Pedro Alves  <palves@redhat.com>
12050             Andrew Burgess  <andrew.burgess@embecosm.com>
12051
12052         * gdbthread.h: Include "common/forward-scope-exit.h".
12053         (scoped_finish_thread_state): Redefine custom class in terms of
12054         forward_scope_exit.
12055
12056 2019-01-23  Pedro Alves  <palves@redhat.com>
12057             Andrew Burgess  <andrew.burgess@embecosm.com>
12058
12059         * common/forward-scope-exit.h: New file.
12060
12061 2019-01-23  Pedro Alves  <palves@redhat.com>
12062             Andrew Burgess  <andrew.burgess@embecosm.com>
12063             Tom Tromey  <tom@tromey.com>
12064
12065         * common/scope-exit.h: New file.
12066
12067 2019-01-23  Pedro Alves  <palves@redhat.com>
12068
12069         * common/preprocessor.h (ESC): Rename to ...
12070         (ESC_PARENS): ... this.
12071         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12072         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12073
12074 2019-01-23  Tom Tromey  <tom@tromey.com>
12075
12076         * language.h (class scoped_switch_to_sym_language_if_auto):
12077         Initialize m_lang in both cases.
12078
12079 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12080
12081         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12082         with XCNEW.
12083
12084 2019-01-22  Tom Tromey  <tom@tromey.com>
12085
12086         * corelow.c: Do not include sys/file.h.
12087
12088 2019-01-22  Tom Tromey  <tom@tromey.com>
12089
12090         * tui/tui-wingeneral.h: Include gdb_curses.h.
12091
12092 2019-01-22  Tom Tromey  <tom@tromey.com>
12093
12094         * source-cache.h (class source_cache) <get_source_lines,
12095         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12096
12097 2019-01-22  Tom Tromey  <tom@tromey.com>
12098
12099         * remote-fileio.h (struct remote_target): Declare.
12100
12101 2019-01-22  Tom Tromey  <tom@tromey.com>
12102
12103         * python/py-arch.c: Do not include py-ref.h.
12104         * python/py-bpevent.c: Do not include py-ref.h.
12105         * python/py-cmd.c: Do not include py-ref.h.
12106         * python/py-continueevent.c: Do not include py-ref.h.
12107         * python/py-event.h: Do not include py-ref.h.
12108         * python/py-evtregistry.c: Do not include py-ref.h.
12109         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12110         * python/py-frame.c: Do not include py-ref.h.
12111         * python/py-framefilter.c: Do not include py-ref.h.
12112         * python/py-function.c: Do not include py-ref.h.
12113         * python/py-infevents.c: Do not include py-ref.h.
12114         * python/py-linetable.c: Do not include py-ref.h.
12115         * python/py-objfile.c: Do not include py-ref.h.
12116         * python/py-param.c: Do not include py-ref.h.
12117         * python/py-prettyprint.c: Do not include py-ref.h.
12118         * python/py-progspace.c: Do not include py-ref.h.
12119         * python/py-symbol.c: Do not include py-ref.h.
12120         * python/py-symtab.c: Do not include py-ref.h.
12121         * python/py-type.c: Do not include py-ref.h.
12122         * python/py-unwind.c: Do not include py-ref.h.
12123         * python/py-utils.c: Do not include py-ref.h.
12124         * python/py-value.c: Do not include py-ref.h.
12125         * python/py-varobj.c: Do not include py-ref.h.
12126         * python/py-xmethods.c: Do not include py-ref.h.
12127         * python/python.c: Do not include py-ref.h.
12128         * varobj.c: Do not include py-ref.h.
12129
12130 2019-01-22  Tom Tromey  <tom@tromey.com>
12131
12132         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12133         keyword for bcache.
12134
12135 2019-01-22  Tom Tromey  <tom@tromey.com>
12136
12137         * compile/compile-cplus-types.c: Remove a comment by #include.
12138
12139 2019-01-22  Tom Tromey  <tom@tromey.com>
12140
12141         * compile/gcc-c-plugin.h: Include compile-internal.h.
12142
12143 2019-01-22  Tom Tromey  <tom@tromey.com>
12144
12145         * stabsread.c (EXTERN): Do not define.
12146         (symnum, next_symbol_text_func, processing_gcc_compilation)
12147         (within_function, global_sym_chain, global_stabs)
12148         (previous_stab_code, this_object_header_files)
12149         (n_this_object_header_files)
12150         (n_allocated_this_object_header_files): Define.
12151         * stabsread.h (EXTERN): Never define.  Use "extern".
12152
12153 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12154
12155         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12156         history_value.
12157
12158 2019-01-21  Tom Tromey  <tom@tromey.com>
12159
12160         * ui-out.c: Fix includes.
12161         * tui/tui-source.c: Fix includes.
12162         * target.c: Fix includes.
12163         * remote.c: Fix includes.
12164         * regcache.c: Fix includes.
12165         * python/py-block.c: Fix includes.
12166         * printcmd.c: Fix includes.
12167         * or1k-tdep.c: Fix includes.
12168         * mi/mi-main.c: Fix includes.
12169         * m32r-tdep.c: Fix includes.
12170         * csky-tdep.c: Fix includes.
12171         * compile/compile-cplus-types.c: Fix includes.
12172         * cli/cli-interp.c: Fix includes.
12173
12174 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12175
12176         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12177         for padding.
12178
12179 2019-01-16  Tom Tromey  <tom@tromey.com>
12180
12181         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12182         earlier.
12183         (struct objfile) <msymbols_range>: Move from top level.
12184         <msymbols>: New method.
12185         (class objfile_msymbols): Remove.
12186         * symtab.c (default_collect_symbol_completion_matches_break_on):
12187         Update.
12188         * symmisc.c (dump_msymbols): Update.
12189         * stabsread.c (scan_file_globals): Update.
12190         * objc-lang.c (info_selectors_command, info_classes_command)
12191         (find_methods): Update.
12192         * minsyms.c (find_solib_trampoline_target): Update.
12193         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12194         * coffread.c (coff_symfile_read): Update.
12195         * ada-lang.c (ada_lookup_simple_minsym)
12196         (ada_collect_symbol_completion_matches): Update.
12197
12198 2019-01-16  Tom Tromey  <tom@tromey.com>
12199
12200         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12201         type.  Remove no-argument constructor.
12202         <iterator::operator++>: Simplify.
12203         <begin>: Update.
12204         <end>: Use minimal_symbol_count.
12205
12206 2019-01-16  Tom Tromey  <tom@tromey.com>
12207
12208         * objfiles.h (struct objfile) <psymtabs>: New method.
12209         (class objfile_psymtabs): Remove.
12210         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12211         typedef.
12212         <range>: New method.
12213         (require_partial_symbols): Change return type.
12214         * psymtab.c (require_partial_symbols)
12215         (psym_expand_symtabs_matching): Update.
12216         * mdebugread.c (parse_partial_symbols): Update.
12217         * dbxread.c (dbx_end_psymtab): Update.
12218
12219 2019-01-15  Tom Tromey  <tom@tromey.com>
12220
12221         * symtab.c (lookup_objfile_from_block)
12222         (lookup_symbol_in_objfile_symtabs)
12223         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12224         (find_line_symtab, info_sources_command)
12225         (default_collect_symbol_completion_matches_break_on)
12226         (make_source_files_completion_list): Update.
12227         * symmisc.c (print_objfile_statistics, dump_objfile)
12228         (maintenance_print_symbols, maintenance_info_symtabs)
12229         (maintenance_check_symtabs, maintenance_info_line_tables):
12230         Update.
12231         * source.c (select_source_symtab)
12232         (forget_cached_source_info_for_objfile): Update.
12233         * objfiles.h (class objfile_compunits): Remove.
12234         (struct objfile) <compunits_range>: New typedef.
12235         (compunits): New method.
12236         * objfiles.c (objfile_relocate1): Update.
12237         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12238         * maint.c (count_symtabs_and_blocks): Update.
12239         * linespec.c (iterate_over_all_matching_symtabs): Update.
12240         * cp-support.c (add_symbol_overload_list_qualified): Update.
12241         * coffread.c (coff_symtab_read): Update.
12242         * ada-lang.c (add_nonlocal_symbols)
12243         (ada_collect_symbol_completion_matches)
12244         (ada_add_global_exceptions): Update.
12245
12246 2019-01-15  Tom Tromey  <tom@tromey.com>
12247
12248         * progspace.h (program_space) <objfiles_safe_range>: New
12249         typedef.
12250         <objfiles_safe>: New method.
12251         * objfiles.h (class all_objfiles_safe): Remove.
12252         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12253         * jit.c (jit_inferior_exit_hook): Update.
12254
12255 2019-01-17  Tom Tromey  <tom@tromey.com>
12256
12257         * progspace.h (program_space) <objfiles_range>: New typedef.
12258         <objfiles>: New method.
12259         <objfiles_head>: Rename from objfiles.
12260         (object_files): Update.
12261         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12262         * guile/scm-pretty-print.c
12263         (ppscm_find_pretty_printer_from_objfiles): Update.
12264         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12265         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12266         Update.
12267         * python/py-progspace.c (pspy_get_objfiles): Update.
12268         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12269         Update.
12270         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12271         (objfpy_lookup_objfile_by_build_id): Update.
12272         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12273         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12274         Update.
12275         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12276         (expand_symtab_containing_pc, lookup_objfile_from_block)
12277         (lookup_static_symbol, basic_lookup_transparent_type)
12278         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12279         (find_line_symtab, info_sources_command)
12280         (default_collect_symbol_completion_matches_break_on)
12281         (make_source_files_completion_list, find_main_name): Update.
12282         * symmisc.c (print_symbol_bcache_statistics)
12283         (print_objfile_statistics, maintenance_print_symbols)
12284         (maintenance_print_msymbols, maintenance_print_objfiles)
12285         (maintenance_info_symtabs, maintenance_check_symtabs)
12286         (maintenance_expand_symtabs, maintenance_info_line_tables):
12287         Update.
12288         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12289         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12290         (map_overlay_command, unmap_overlay_command)
12291         (simple_overlay_update, expand_symtabs_matching)
12292         (map_symbol_filenames): Update.
12293         * symfile-debug.c (set_debug_symfile): Update.
12294         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12295         Update.
12296         * source.c (select_source_symtab, forget_cached_source_info):
12297         Update.
12298         * solib.c (solib_read_symbols): Update.
12299         * solib-spu.c (append_ocl_sos): Update.
12300         * psymtab.c (maintenance_print_psymbols)
12301         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12302         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12303         * printcmd.c (info_symbol_command): Update.
12304         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12305         Update.
12306         * objfiles.h (class all_objfiles): Remove.
12307         * objfiles.c (have_partial_symbols, have_full_symbols)
12308         (have_minimal_symbols, qsort_cmp, update_section_map)
12309         (shared_objfile_contains_address_p)
12310         (default_iterate_over_objfiles_in_search_order): Update.
12311         * objc-lang.c (info_selectors_command, info_classes_command)
12312         (find_methods): Update.
12313         * minsyms.c (find_solib_trampoline_target): Update.
12314         * maint.c (maintenance_info_sections)
12315         (maintenance_translate_address, count_symtabs_and_blocks):
12316         Update.
12317         * main.c (captured_main_1): Update.
12318         * linux-thread-db.c (try_thread_db_load_from_pdir)
12319         (has_libpthread): Update.
12320         * linespec.c (iterate_over_all_matching_symtabs)
12321         (search_minsyms_for_name): Update.
12322         * jit.c (jit_find_objf_with_entry_addr): Update.
12323         * hppa-tdep.c (find_unwind_entry)
12324         (hppa_lookup_stub_minimal_symbol): Update.
12325         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12326         Update.
12327         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12328         (elf_gnu_ifunc_resolve_by_got): Update.
12329         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12330         * dwarf-index-write.c (save_gdb_index_command): Update.
12331         * cp-support.c (add_symbol_overload_list_qualified): Update.
12332         * breakpoint.c (create_overlay_event_breakpoint)
12333         (create_longjmp_master_breakpoint)
12334         (create_std_terminate_master_breakpoint)
12335         (create_exception_master_breakpoint): Update.
12336         * blockframe.c (find_pc_partial_function): Update.
12337         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12338         (ada_collect_symbol_completion_matches)
12339         (ada_add_global_exceptions): Update.
12340
12341 2019-01-17  Tom Tromey  <tom@tromey.com>
12342
12343         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12344         declare VEC.
12345         (solib_target_parse_libraries): Change return type.
12346         (library_list_start_segment, library_list_start_section)
12347         (library_list_end_library, library_list_start_library); Update.
12348         (solib_target_free_library_list): Remove.
12349         (solib_target_parse_libraries): Remove cleanup.  Change return
12350         type.
12351         (solib_target_current_sos): Update.
12352
12353 2019-01-17  Tom Tromey  <tromey@bapiya>
12354
12355         * valprint.c: Replace "the the" with "the".
12356         * symtab.c: Replace "the the" with "the".
12357         * solib.c: Replace "the the" with "the".
12358         * solib-dsbt.c: Replace "the the" with "the".
12359         * linespec.c: Replace "the the" with "the".
12360         * dwarf2loc.h: Replace "the the" with "the".
12361         * amd64-windows-tdep.c: Replace "the the" with "the".
12362         * aarch64-tdep.c: Replace "the the" with "the".
12363
12364 2019-01-16  Keith Seitz  <keiths@redhat.com>
12365
12366         PR gdb/23773
12367         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12368         <builder>: Rename to ..
12369         <m_builder>: ... this and make private.
12370         (dwarf2_cu::get_builder): New method.  Change all users of
12371         `builder' to use this method.
12372         (dwarf2_start_symtab): Move to ...
12373         (dwarf2_cu::start_symtab): ... here.  Update all callers
12374         (setup_type_unit_groups): Move to ...
12375         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12376         callers.
12377         (dwarf2_cu::reset_builder): New method.
12378         (process_full_compunit, process_full_type_unit): Use
12379         dwarf2_cu::reset_builder.
12380         (follow_die_offset): Record the ancestor CU if it is different
12381         from the followed DIE's CU.
12382         (follow_die_sig_1): Likewise.
12383
12384 2019-01-15  Tom Tromey  <tom@tromey.com>
12385
12386         * remote.c (class remote_state) <buf>: Now a char_vector.
12387         <buf_size>: Remove.
12388         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12389         parameter.
12390         (remote_target::getpkt_or_notif_sane_1)
12391         (remote_target::getpkt_sane)
12392         (remote_target::getpkt_or_notif_sane): Likewise.
12393         (class remote_target) <putpkt>: New overload.
12394         (remote_target::read_frame): Change type of "buf_p".  Remove
12395         sizeof_p parameter.
12396         (packet_ok): New overload.
12397         (packet_check_result): New overload.
12398         Update all uses.
12399
12400 2019-01-14  Tom Tromey  <tom@tromey.com>
12401
12402         * remote-notif.c (handle_notification, remote_notif_ack)
12403         (remote_notif_parse): Make "buf" const.
12404         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12405         const.
12406         (remote_notif_parse, remote_notif_ack, handle_notification):
12407         Likewise.
12408         * remote.c (remote_notif_stop_parse): Make "buf" const.
12409         (remote_target::remote_parse_stop_reply): Make "buf" const.
12410         (remote_notif_stop_ack): Make "buf" const.
12411
12412 2019-01-14  Tom Tromey  <tom@tromey.com>
12413
12414         * remote.c (remote_console_output): Make parameter const.
12415
12416 2019-01-14  Tom Tromey  <tom@tromey.com>
12417
12418         * target-debug.h (target_debug_print_signals): Constify.
12419         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12420         * procfs.c (procfs_target::pass_signals): Update.
12421         * linux-nat.c (linux_nat_target::pass_signals): Update.
12422         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12423         * target-delegates.c: Rebuild.
12424         * remote.c (remote_target::program_signals): Update.
12425         (remote_target::pass_signals): Update.
12426         * target.c (target_pass_signals): Constify argument.
12427         (target_program_signals): Likewise.
12428         * target.h (struct target_ops) <pass_signals, program_signals>:
12429         Constify argument.
12430         (target_pass_signals, target_program_signals): Constify argument.
12431
12432 2019-01-14  Tom Tromey  <tom@tromey.com>
12433
12434         PR tui/28819:
12435         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12436
12437 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12438
12439         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12440         field.
12441         * rs6000-tdep.c: Include reggroups.h.
12442         (IS_V_ALIAS_PSEUDOREG): Define.
12443         (rs6000_register_name): Return names for the "vX" aliases.
12444         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12445         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12446         aliases.  Call default_register_reggroup_p for all other
12447         pseudo-registers.
12448         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12449         New functions.
12450         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12451         Handle "vX" aliases.
12452         (v_alias_pseudo_register_collect): New function.
12453         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12454         (rs6000_gdbarch_init): Initialize "vX" aliases as
12455         pseudo-registers.  Restore registration of
12456         rs6000_pseudo_register_reggroup_p with
12457         set_tdesc_pseudo_register_reggroup_p.
12458
12459 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12460
12461         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12462         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12463         set_gdbarch_num_pseudo_regs.
12464
12465 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12466
12467         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12468         Remove arg prefixname, add do_set and do_show.
12469         Add member functions set_list and show_list.
12470         * cli/cli-style.c (class cli_style_option): Update accordingly.
12471         (style_set_list): Move to file scope.
12472         (style_show_list): Likewise.
12473         (set_style): Call help_list.
12474         (show_style): Call cmd_show_list.
12475         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12476         Update to use the new macro.
12477
12478 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12479
12480         * ada-lang.c (_initialize_ada_language): Expand the help text
12481         for the "catch exception" command.
12482
12483 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12484
12485         * symtab.c (matching_obj_sections): Initialize obj,
12486         declare it closer to its usage.
12487
12488 2019-01-10  Tom Tromey  <tom@tromey.com>
12489
12490         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12491         (basic_inf_threads_range): Remove.
12492         (inf_threads_range, inf_non_exited_threads_range)
12493         (safe_inf_threads_range): Use next_adapter.
12494
12495 2019-01-10  Keith Seitz  <keiths@redhat.com>
12496
12497         PR gdb/23712
12498         PR symtab/23010
12499         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12500         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12501
12502 2019-01-10  Keith Seitz  <keiths@redhat.com>
12503
12504         PR gdb/23712
12505         PR symtab/23010
12506         * dictionary.c (pending_to_vector): Remove.
12507         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12508         Remove _1 suffix, replacing functions of the same name.  Update
12509         all callers.
12510         (dict_create_hashed, dict_create_hashed_expandable)
12511         (dict_create_linear, dict_create_linear_expandable, dict_free)
12512         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12513         Make functions static.
12514
12515 2019-01-10  Keith Seitz  <keiths@redhat.com>
12516
12517         PR gdb/23712
12518         PR symtab/23010
12519         * dictionary.h (struct dictionary): Replace declaration with
12520         multidictionary.
12521         (dict_create_hashed, dict_create_hashed_expandable)
12522         (dict_create_linear, dict_create_linear_expandable)
12523         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12524         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12525         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12526         taking multidictionary argument.
12527         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12528         * block.h (struct block) <dict>: Change to multidictionary
12529         and rename `multidict'.
12530         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12531         symmisc.c: Update all dictionary references to multidictionary.
12532
12533 2019-01-10  Keith Seitz  <keiths@redhat.com>
12534
12535         PR gdb/23712
12536         PR symtab/23010
12537         * dictionary.c: Include unordered_map.
12538         (pending_to_vector): New function.
12539         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12540         Rewrite the non-"_1" functions to take vector instead
12541         of linked list.
12542         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12543         "new" _1 versions of the same name.
12544         (multidictionary): Define.
12545         (std::hash<enum language): New definition.
12546         (collate_pending_symbols_by_language, mdict_create_hashed)
12547         (mdict_create_hashed_expandable, mdict_create_linear)
12548         (mdict_create_linear_expandable, mdict_free)
12549         (find_language_dictionary, create_new_language_dictionary)
12550         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12551         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12552         (mdict_size, mdict_empty): New functions.
12553         * dictionary.h (mdict_iterator): Define.
12554
12555 2019-01-10  Pedro Alves  <palves@redhat.com>
12556
12557         * breakpoint.c (read_uploaded_action)
12558         (create_tracepoint_from_upload): Adjust to use
12559         gdb::unique_xmalloc_ptr.
12560         * ctf.c (ctf_write_uploaded_tp):
12561         (SET_ARRAY_FIELD): Use emplace_back.
12562         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12563         * tracefile-tfile.c (tfile_write_uploaded_tp):
12564         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12565         gdb::unique_xmalloc_ptr.
12566         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12567         at_string, cond_string, cmd_strings>: Replace char pointers
12568         with gdb::unique_xmalloc_ptr.
12569
12570 2019-01-10  Pedro Alves  <palves@redhat.com>
12571
12572         * solib-target.c (library_list_start_library): Don't xstrdup name.
12573
12574 2019-01-10  Pedro Alves  <palves@redhat.com>
12575
12576         * mdebugread.c (parse_partial_symbols): Use
12577         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12578
12579 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12580
12581         * linux-fork.c (scoped_switch_fork_info)
12582         <~scoped_switch_fork_info>: Fix incorrect variable name.
12583
12584 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12585
12586         * linux-fork.c (scoped_switch_fork_info)
12587         <scoped_switch_fork_info>: Make explicit.
12588         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12589
12590 2019-01-10  Tom Tromey  <tom@tromey.com>
12591
12592         * objfiles.h (objfile::reset_psymtabs): Update.
12593         * objfiles.c (objfile::objfile): Update.
12594         * psymtab.h (psymtab_storage::obstack): Update.
12595         (psymtab_storage::m_obstack): Use gdb::optional.
12596         (class psymtab_storage): Update comment.  Remove objfile
12597         parameter.
12598         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12599
12600 2019-01-10  Tom Tromey  <tom@tromey.com>
12601
12602         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12603         <free_psymtabs>: Now private.
12604         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12605         (allocate_psymtab): Use new method.
12606
12607 2019-01-10  Tom Tromey  <tom@tromey.com>
12608
12609         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12610         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12611         * mdebugread.c (parse_partial_symbols): Use
12612         allocate_dependencies.
12613         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12614         allocate_dependencies.
12615         (process_psymtab_comp_unit_reader)
12616         (build_type_psymtab_dependencies): Likewise.
12617         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12618
12619 2019-01-10  Tom Tromey  <tom@tromey.com>
12620
12621         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12622         PSYMBOL_SET_LANGUAGE.
12623         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12624
12625 2019-01-10  Tom Tromey  <tom@tromey.com>
12626
12627         * psymtab.h (psymtab_storage::obstack): New method.
12628         <m_obstack>: Rename from obstack; now private.
12629         * psymtab.c (psymtab_storage): Update.
12630         * dwarf2read.c (create_addrmap_from_index)
12631         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12632         Update.
12633
12634 2019-01-10  Tom Tromey  <tom@tromey.com>
12635
12636         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12637         * objfiles.h (objfile::reset_psymtabs): New method.
12638
12639 2019-01-10  Tom Tromey  <tom@tromey.com>
12640
12641         * symmisc.c (print_symbol_bcache_statistics): Update.
12642         (print_objfile_statistics): Update.
12643         * symfile.c (reread_symbols): Update.
12644         * psymtab.h (class psymtab_storage): New.
12645         * psymtab.c (psymtab_storage): New constructor.
12646         (~psymtab_storage): New destructor.
12647         (require_partial_symbols): Update.
12648         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12649         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12650         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12651         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12652         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12653         (start_psymtab_common, end_psymtab_common)
12654         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12655         (allocate_psymtab): Update.
12656         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12657         Update.
12658         (dump_psymtab_addrmap, maintenance_print_psymbols)
12659         (maintenance_check_psymtabs): Update.
12660         (class objfile_psymtabs): Move to objfiles.h.
12661         * psympriv.h (discard_psymtab): Now inline.
12662         (psymtab_discarder::psymtab_discarder): Update.
12663         (psymtab_discarder::~psymtab_discarder): Update.
12664         (ALL_OBJFILE_PSYMTABS): Rewrite.
12665         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12666         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12667         Remove fields.
12668         <partial_symtabs>: New field.
12669         (class objfile_psymtabs): Move from psymtab.h.  Update.
12670         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12671         psymbol_cache.
12672         (objfile::~objfile): Don't destroy psymbol_cache.
12673         * mdebugread.c (parse_partial_symbols): Update.
12674         * dwarf2read.c (create_addrmap_from_index)
12675         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12676         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12677         (add_partial_subprogram, dwarf2_ranges_read): Update.
12678         * dwarf-index-write.c (write_address_map)
12679         (write_one_signatured_type, recursively_write_psymbols)
12680         (class debug_names, class debug_names, write_psymtabs_to_index):
12681         Update.
12682
12683 2019-01-10  Tom Tromey  <tom@tromey.com>
12684
12685         * symtab.h (SYMBOL_SET_NAMES): Update.
12686         (symbol_set_names): Update.
12687         (MSYMBOL_SET_NAMES): Update.
12688         * symtab.c (symbol_set_names): Change argument to be an
12689         objfile_per_bfd_storage.
12690         * psymtab.c (add_psymbol_to_bcache): Update.
12691         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12692
12693 2019-01-10  Tom Tromey  <tom@tromey.com>
12694
12695         * symtab.c (create_demangled_names_hash): Change argument to be an
12696         objfile_per_bfd_storage.
12697         (symbol_set_names): Update.
12698
12699 2019-01-10  Tom Tromey  <tom@tromey.com>
12700
12701         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12702         init_psymbol_list.
12703         * psymtab.c (init_psymbol_list): Do nothing if already called.
12704         * psympriv.h (init_psymbol_list): Add comment.
12705         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12706         init_psymbol_list.
12707         * dbxread.c (dbx_symfile_read): Unconditionally call
12708         init_psymbol_list.
12709
12710 2019-01-10  Tom Tromey  <tom@tromey.com>
12711
12712         * xcoffread.c (scan_xcoff_symtab): Update.
12713         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12714         "where".
12715         * mdebugread.c (parse_partial_symbols)
12716         (handle_psymbol_enumerators): Update.
12717         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12718         * dbxread.c (read_dbx_symtab): Update.
12719         * psympriv.h (psymbol_placement): New enum.
12720         (add_psymbol_to_list): Update.
12721
12722 2019-01-10  Tom Tromey  <tom@tromey.com>
12723
12724         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12725         static_psymbols parameters.
12726         (scan_xcoff_symtab): Update.
12727         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12728         static_psymbols parameters.
12729         * psympriv.h (start_psymtab_common): Update.
12730         * mdebugread.c (parse_partial_symbols): Update.
12731         * dwarf2read.c (create_partial_symtab): Update.
12732         * dbxread.c (read_dbx_symtab): Update.
12733         (start_psymtab): Remove global_psymbols and static_psymbols
12734         parameters.
12735
12736 2019-01-10  Tom Tromey  <tom@tromey.com>
12737
12738         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12739         * psymtab.c (allocate_psymtab): Add comment.
12740         * psympriv.h (allocate_psymtab): Add comment.
12741         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12742         initializations.
12743         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12744
12745 2019-01-10  Tom Tromey  <tom@tromey.com>
12746
12747         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12748         Don't declare.
12749         * mipsread.c: Include mdebugread.h.
12750         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12751         Declare.
12752         * elfread.c: Include mdebugread.h.
12753
12754 2019-01-09  Tom Tromey  <tom@tromey.com>
12755
12756         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12757         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12758         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12759         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12760         (psym_lookup_symbol, psym_find_last_source_symtab)
12761         (psym_forget_cached_source_info, psym_print_stats)
12762         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12763         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12764         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12765         (psym_find_compunit_symtab_by_address)
12766         (maintenance_print_psymbols, maintenance_info_psymtabs)
12767         (maintenance_check_psymtabs): Use ranged for.
12768         * psymtab.h (class objfile_psymtabs): New.
12769         (require_partial_symbols): Return objfile_psymtabs.
12770         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12771
12772 2019-01-09  Tom Tromey  <tom@tromey.com>
12773
12774         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12775         (find_pc_mapped_section, list_overlays_command)
12776         (map_overlay_command, unmap_overlay_command)
12777         (simple_overlay_update): Use all_objfiles.
12778         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12779         * printcmd.c (info_symbol_command): Use all_objfiles.
12780         * objfiles.h (ALL_OBJSECTIONS): Remove.
12781         * maint.c (maintenance_translate_address): Use all_objfiles.
12782         * gcore.c (gcore_create_callback): Use all_objfiles.
12783         (objfile_find_memory_regions): Likewise.
12784
12785 2019-01-09  Tom Tromey  <tom@tromey.com>
12786
12787         * symtab.c (find_line_symtab, info_sources_command)
12788         (make_source_files_completion_list): Use objfile_compunits.
12789         * source.c (select_source_symtab): Use objfile_compunits.
12790         * objfiles.h (struct objfile): Update comment.
12791         (ALL_OBJFILES): Remove.
12792         (ALL_FILETABS): Remove.
12793         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12794         objfile_compunits.
12795
12796 2019-01-09  Tom Tromey  <tom@tromey.com>
12797
12798         * symmisc.c (print_objfile_statistics, dump_objfile)
12799         (maintenance_print_symbols): Use compunit_filetabs.
12800         * source.c (forget_cached_source_info_for_objfile): Use
12801         compunit_filetabs.
12802         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12803         (ALL_FILETABS): Use compunit_filetabs.
12804         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12805         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12806
12807 2019-01-09  Tom Tromey  <tom@tromey.com>
12808
12809         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12810         (compunit_filetabs): New.
12811         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12812         compunit_filetabs.
12813         (info_sources_command, make_source_files_completion_list): Remove
12814         declaration.
12815         * symmisc.c (print_objfile_statistics, dump_objfile)
12816         (maintenance_print_symbols): Remove declaration.
12817         (maintenance_info_symtabs): Use compunit_filetabs.
12818         (maintenance_info_line_tables): Likewise.
12819         * source.c (select_source_symtab): Change local variable name.
12820         (forget_cached_source_info_for_objfile): Remove declaration.
12821         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12822         * objfiles.c (objfile_relocate1): Remove declaration.
12823         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12824         declaration.
12825         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12826         * coffread.c (coff_symtab_read): Remove declaration.
12827         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12828         compunit_filetabs.
12829
12830 2019-01-09  Tom Tromey  <tom@tromey.com>
12831
12832         * symtab.c (lookup_objfile_from_block)
12833         (find_pc_sect_compunit_symtab, search_symbols)
12834         (default_collect_symbol_completion_matches_break_on): Use
12835         objfile_compunits.
12836         * objfiles.h (ALL_COMPUNITS): Remove.
12837         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12838         * cp-support.c (add_symbol_overload_list_qualified): Use
12839         objfile_compunits.
12840         * ada-lang.c (ada_collect_symbol_completion_matches)
12841         (ada_add_global_exceptions): Use objfile_compunits.
12842
12843 2019-01-09  Tom Tromey  <tom@tromey.com>
12844
12845         * source.c (select_source_symtab)
12846         (forget_cached_source_info_for_objfile): Remove declaration.
12847         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12848         declaration.
12849         * maint.c (count_symtabs_and_blocks): Remove declaration.
12850         * cp-support.c (add_symbol_overload_list_qualified): Remove
12851         declaration.
12852         * coffread.c (coff_symtab_read): Remove declaration.
12853         * symtab.c (lookup_symbol_in_objfile_symtabs)
12854         (basic_lookup_transparent_type_1): Use objfile_compunits.
12855         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12856         (info_sources_command, search_symbols)
12857         (default_collect_symbol_completion_matches_break_on)
12858         (make_source_files_completion_list): Remove declaration.
12859         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12860         (ada_collect_symbol_completion_matches)
12861         (ada_add_global_exceptions): Remove declaration.
12862         * linespec.c (iterate_over_all_matching_symtabs): Use
12863         objfile_compunits.
12864         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12865         (class objfile_compunits): New.
12866         (ALL_COMPUNITS): Use objfile_compunits.
12867         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12868         (maintenance_check_symtabs, maintenance_info_line_tables): Use
12869         objfile_compunits.
12870         * objfiles.c (objfile_relocate1): Use objfile_compunits.
12871
12872 2019-01-09  Tom Tromey  <tom@tromey.com>
12873
12874         * symtab.c (search_symbols)
12875         (default_collect_symbol_completion_matches_break_on): Use
12876         objfile_msymbols.
12877         * ada-lang.c (ada_lookup_simple_minsym)
12878         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
12879         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
12880         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
12881         objfile_msymbols.
12882         * coffread.c (coff_symfile_read): Use objfile_msymbols.
12883         * symmisc.c (dump_msymbols): Use objfile_msymbols.
12884         * objc-lang.c (find_methods): Use objfile_msymbols.
12885         (info_selectors_command, info_classes_command): Likewise.
12886         * stabsread.c (scan_file_globals): Use objfile_msymbols.
12887         * objfiles.h (class objfile_msymbols): New.
12888         (ALL_OBJFILE_MSYMBOLS): Remove.
12889         (ALL_MSYMBOLS): Remove.
12890
12891 2019-01-09  Tom Tromey  <tom@tromey.com>
12892
12893         * common/next-iterator.h (next_adapter): Add Iterator template
12894         parameter.
12895         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
12896         (class all_objfiles_safe): New.
12897         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
12898         * objfiles.c (put_objfile_before): Update comment.
12899         (add_separate_debug_objfile): Likewise.
12900         (free_all_objfiles): Use all_objfiles_safe.
12901         (objfile_purge_solibs): Likewise.
12902
12903 2019-01-09  Tom Tromey  <tom@tromey.com>
12904
12905         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12906         (expand_symtab_containing_pc, lookup_static_symbol)
12907         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
12908         (find_symbol_at_address, find_line_symtab, find_main_name): Use
12909         all_objfiles.
12910         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
12911         * breakpoint.c (create_overlay_event_breakpoint)
12912         (create_longjmp_master_breakpoint)
12913         (create_std_terminate_master_breakpoint)
12914         (create_exception_master_breakpoint): Use all_objfiles.
12915         * linux-thread-db.c (try_thread_db_load_from_pdir)
12916         (has_libpthread): Use all_objfiles.
12917         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
12918         * linespec.c (iterate_over_all_matching_symtabs)
12919         (search_minsyms_for_name): Use all_objfiles.
12920         * maint.c (maintenance_info_sections): Use all_objfiles.
12921         * main.c (captured_main_1): Use all_objfiles.
12922         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
12923         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
12924         * guile/scm-pretty-print.c
12925         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
12926         * solib-spu.c (append_ocl_sos): Use all_objfiles.
12927         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
12928         (maintenance_print_msymbols): Use all_objfiles.
12929         * source.c (select_source_symtab): Use all_objfiles.
12930         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
12931         * symfile.c (remove_symbol_file_command)
12932         (expand_symtabs_matching, map_symbol_filenames): Use
12933         all_objfiles.
12934         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
12935         all_objfiles.
12936         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
12937         * objc-lang.c (find_methods): Use all_objfiles.
12938         * objfiles.c (have_partial_symbols, have_full_symbols)
12939         (have_minimal_symbols, qsort_cmp)
12940         (default_iterate_over_objfiles_in_search_order): Use
12941         all_objfiles.
12942         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
12943         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
12944         (maintenance_check_psymtabs): Use all_objfiles.
12945         (ALL_PSYMTABS): Remove.
12946         * compile/compile-object-run.c (do_module_cleanup): Use
12947         all_objfiles.
12948         * blockframe.c (find_pc_partial_function): Use all_objfiles.
12949         * cp-support.c (add_symbol_overload_list_qualified): Use
12950         all_objfiles.
12951         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12952         Use all_objfiles.
12953         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
12954         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
12955         all_objfiles.
12956         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12957         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
12958         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12959         Uses all_objfiles.
12960         * solib.c (solib_read_symbols): Use all_objfiles
12961
12962 2019-01-09  Tom Tromey  <tom@tromey.com>
12963
12964         * probe.c (parse_probes_in_pspace): Use all_objfiles.
12965         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
12966         all_objfiles.
12967         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
12968         * symmisc.c (print_symbol_bcache_statistics)
12969         (print_objfile_statistics, maintenance_print_objfiles)
12970         (maintenance_info_symtabs, maintenance_check_symtabs)
12971         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
12972         all_objfiles.
12973         * source.c (forget_cached_source_info): Use all_objfiles.
12974         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
12975         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12976         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
12977         * objfiles.c (update_section_map): Use all_objfiles.
12978         (shared_objfile_contains_address_p): Likewise.
12979         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
12980         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
12981
12982 2019-01-09  Tom Tromey  <tom@tromey.com>
12983
12984         * common/next-iterator.h: New file.
12985         * objfiles.h (class all_objfiles): New.
12986         (struct objfile_iterator): New.
12987
12988 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12989
12990         * NEWS: Move the description of the changed "frame", "select-frame",
12991          and "info frame" commands to the Changed commands section.
12992
12993 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
12994
12995         * gdbtypes.c (check_stub_method_group): Remove handling of old
12996         mangling schemes.
12997         * linespec.c (find_methods): Likewise.
12998         * stabsread.c (read_member_functions): Likewise.
12999         * valops.c (search_struct_method): Likewise.
13000         (value_struct_elt_for_reference): Likewise.
13001         * NEWS: Mention this change.
13002
13003 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13004
13005         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13006         print_source_lines.
13007         * source.c (print_source_lines_base): Update line number check.
13008         (print_source_lines): New function.
13009         (source_lines_range::source_lines_range): New function.
13010         * source.h (class source_lines_range): New class.
13011         (print_source_lines): New declaration.
13012
13013 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13014
13015         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13016
13017 2019-01-08  Tom Tromey  <tom@tromey.com>
13018             Simon Marchi  <simon.marchi@ericsson.com>
13019
13020         PR gdb/24060
13021         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13022         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13023         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13024         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13025         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13026         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13027
13028 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13029
13030         * source.c (select_source_symtab): Move header comment to
13031         declaration in source.h.
13032         (forget_cached_source_info_for_objfile): Likewise.
13033         (forget_cached_source_info): Likewise.
13034         (identify_source_line): Likewise.
13035         * source.h (identify_source_line): Move declaration from symtab.h
13036         and add comment from source.c
13037         (print_source_lines): Likewise.
13038         (forget_cached_source_info_for_objfile): Likewise.
13039         (forget_cached_source_info): Likewise.
13040         (select_source_symtab): Likewise.
13041         (enum print_source_lines_flag): Move definition from symtab.h.
13042         * symtab.h (identify_source_line): Move declaration to source.h.
13043         (print_source_lines): Likewise.
13044         (forget_cached_source_info_for_objfile): Likewise.
13045         (forget_cached_source_info): Likewise.
13046         (select_source_symtab): Likewise.
13047         (enum print_source_lines_flag): Move definition to source.h.
13048         * tui/tui-hooks.c: Add 'source.h' include.
13049
13050 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13051
13052         * source.c (print_source_lines_base): Handle requests to print
13053         reverse line number sequences, and guard against empty lines
13054         string.
13055
13056 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13057
13058         * source.c (print_source_lines_base): Fix skip of '\r' if next
13059         character is '\n'.
13060
13061 2019-01-06  Tom Tromey  <tom@tromey.com>
13062
13063         * c-exp.y (struct c_parse_state) <macro_original_text,
13064         expansion_obstack>: New member.
13065         (macro_original_text, expansion_obstack): Remove globals.
13066         (scan_macro_expansion, scanning_macro_expansion)
13067         (finished_macro_expansion): Update.
13068         (scan_macro_cleanup): Remove.
13069         (yylex, c_parse): Update.
13070
13071 2019-01-06  Tom Tromey  <tom@tromey.com>
13072
13073         * c-exp.y (struct c_parse_state) <strings>: New member.
13074         (operator_stoken): Update.
13075
13076 2019-01-06  Tom Tromey  <tom@tromey.com>
13077
13078         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13079         (union type_stack_elt) <typelist_val>: Now a pointer to
13080         std::vector.
13081         (type_stack_cleanup): Don't declare.
13082         (push_typelist): Update.
13083         * parse.c (pop_typelist): Return a std::vector.
13084         (push_typelist): Take a std::vector.
13085         (follow_types): Update.  Do not free args.
13086         (type_stack_cleanup): Remove.
13087         * c-exp.y (struct c_parse_state): New.
13088         (cpstate): New global.
13089         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13090         (nonempty_typelist): Update.
13091         (func_mod): Create a new vector.
13092         (c_parse): Create a c_parse_state.
13093         (check_parameter_typelist): Do not delete params.
13094         (function_method): Update.  Do not delete type_list.
13095
13096 2019-01-06  Tom Tromey  <tom@tromey.com>
13097
13098         PR gdb/28155:
13099         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13100         check_typedef.
13101         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13102         (print_return_value): Likewise.
13103
13104 2019-01-05  Tom Tromey  <tom@tromey.com>
13105
13106         * contrib/cleanup_check.py: Remove.
13107         * contrib/gcc-with-excheck: Remove.
13108         * contrib/exsummary.py: Remove.
13109         * contrib/excheck.py: Remove.
13110
13111 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13112
13113         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13114         NULL. Initialize tpprev to NULL instead of assigning it
13115         to NULL on the next statement.
13116         * windows-nat.c (windows_delete_thread): Remove check for
13117         main_thread_id before printing thread exit notifications.
13118         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13119         Remove thread ID check against main_thread_id.
13120         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13121         windows_delete_thread.
13122         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13123
13124 2019-01-04  Tom Tromey  <tom@tromey.com>
13125
13126         * compile/compile.c (_initialize_compile): Use upper case for
13127         metasyntactic variables.
13128         * symmisc.c (_initialize_symmisc): Use upper case for
13129         metasyntactic variables.
13130         * psymtab.c (_initialize_psymtab): Use upper case for
13131         metasyntactic variables.
13132         * demangle.c (demangle_command): Use upper case for metasyntactic
13133         variables.
13134         (_initialize_demangler): Likewise.
13135         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13136         variables.
13137
13138 2019-01-03  Tom Tromey  <tom@tromey.com>
13139
13140         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13141
13142 2019-01-03  Tom Tromey  <tom@tromey.com>
13143
13144         * python/py-symtab.c (salpy_str): Update.
13145         (struct salpy_sal_object) <symtab>: Now a PyObject.
13146         (salpy_dealloc): Update.
13147         (del_objfile_sal): Use gdbpy_ref.
13148
13149 2019-01-03  Tom Tromey  <tom@tromey.com>
13150
13151         * python/py-type.c (convert_field): Use new_reference.  Return
13152         gdbpy_ref.
13153         (make_fielditem): Return gdbpy_ref.
13154         (typy_fields): Update.
13155         (typy_getitem): Update.
13156         (field_name): Return gdbpy_ref.  Use new_reference.
13157         (typy_iterator_iternext): Update.
13158
13159 2019-01-03  Tom Tromey  <tom@tromey.com>
13160
13161         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13162
13163 2019-01-03  Tom Tromey  <tom@tromey.com>
13164
13165         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13166         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13167         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13168         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13169         (pspy_set_type_printers): Likewise.
13170         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13171         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13172         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13173         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13174         (objfpy_set_type_printers): Likewise.
13175
13176 2019-01-03  Tom Tromey  <tom@tromey.com>
13177
13178         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13179         (gdbpy_print_stack): Use gdbpy_err_fetch.
13180         * python/python-internal.h (class gdbpy_err_fetch): New class.
13181         (class gdbpy_enter) <m_error_type, m_error_value,
13182         m_error_traceback>: Remove.
13183         <m_error>: New member.
13184         (gdbpy_exception_to_string): Don't declare.
13185         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13186         * python/py-value.c (convert_value_from_python): Use
13187         gdbpy_err_fetch.
13188         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13189         gdbpy_exception_to_string.
13190         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13191         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13192         gdbpy_err_fetch.
13193
13194 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13195
13196         * linux-nat.c (delete_lwp_cleanup): Delete.
13197         (struct lwp_deleter): New struct.
13198         (lwp_info_up): New typedef.
13199         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13200         lwp_info_up.
13201
13202 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13203
13204         * linux-fork.c (class scoped_switch_fork_info): New class.
13205         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13206
13207 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13208
13209         * valops.c (find_overload_match): Remove use of null_cleanup, and
13210         calls to do_cleanups.
13211
13212 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13213
13214         * compile/compile-cplus-types.c
13215         (compile_cplus_instance::decl_name): Handle changes to
13216         cp_func_name.
13217         * cp-support.c (cp_func_name): Update header comment, update
13218         return type.
13219         * cp-support.h (cp_func_name): Update return type in declaration.
13220         * valops.c (find_overload_match): Move temp_func local to top
13221         level of function and change its type.  Use temp_func to hold and
13222         delete temporary string obtained from cp_func_name.
13223
13224 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13225
13226         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13227         gdb::char_vector, remove cleanup, and update uses of `msg`.
13228
13229 2019-01-03  Jim Wilson  <jimw@sifive.com>
13230
13231         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13232
13233 2019-01-02  Tom Tromey  <tom@tromey.com>
13234
13235         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13236         (tdesc_parse_xml): Remove cleanups.
13237         * target-descriptions.h (make_cleanup_free_target_description):
13238         Don't declare.
13239         (target_desc_deleter): New struct.
13240         (target_desc_up): New typedef.
13241         * target-descriptions.c (target_desc_deleter::operator()): Rename
13242         from free_target_description.
13243         (make_cleanup_free_target_description): Remove.
13244
13245 2019-01-02  Tom Tromey  <tom@tromey.com>
13246
13247         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13248         constructor, destructor.
13249         (linespec_parser): Remove typedef.
13250         (~linespec_parser): Rename from linespec_parser_delete.
13251         (linespec_lex_to_end, linespec_complete_label)
13252         (linespec_complete): Update.
13253         (decode_line_full): Remove cleanups.
13254         (decode_line_1): Update.
13255
13256 2019-01-02  Tom Tromey  <tom@tromey.com>
13257
13258         * python/python-internal.h (inferior_to_inferior_object): Change
13259         return type.
13260         * python/py-exitedevent.c (create_exited_event_object): Update.
13261         * python/py-inferior.c (inferior_to_inferior_object): Return
13262         gdbpy_ref.
13263         (python_new_inferior, python_inferior_deleted)
13264         (thread_to_thread_object, delete_thread_object)
13265         (build_inferior_list, gdbpy_selected_inferior): Update.
13266         * python/py-infthread.c (create_thread_object): Update.  Also fail
13267         if inferior_to_inferior_object fails.
13268
13269 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13270
13271         * inferior.h (class inferior) <displaced_step_state>: New field.
13272         * infrun.h (struct displaced_step_state): Move here from
13273         infrun.c.  Initialize fields, add constructor.
13274         <inf>: Remove field.
13275         <reset>: New method.
13276         * infrun.c (struct displaced_step_inferior_state): Move to
13277         infrun.h.
13278         (displaced_step_inferior_states): Remove.
13279         (get_displaced_stepping_state): Adust.
13280         (displaced_step_in_progress_any_inferior): Adjust.
13281         (displaced_step_in_progress_thread): Adjust.
13282         (displaced_step_in_progress): Adjust.
13283         (add_displaced_stepping_state): Remove.
13284         (get_displaced_step_closure_by_addr): Adjust.
13285         (remove_displaced_stepping_state): Remove.
13286         (infrun_inferior_exit): Call displaced_step_state.reset.
13287         (use_displaced_stepping): Don't check for NULL.
13288         (displaced_step_prepare_throw): Call
13289         get_displaced_stepping_state.
13290         (displaced_step_fixup): Don't check for NULL.
13291         (prepare_for_detach): Don't check for NULL.
13292
13293 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13294
13295         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13296          in case of call that did not complete.
13297
13298 2019-01-02  Andrey Utkin  <autkin@undo.io>
13299
13300         * symfile.c (find_separate_debug_file): Fix search of debug files for
13301         remote debuggee.
13302
13303 2019-01-02  Tom Tromey  <tom@tromey.com>
13304
13305         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13306         indentation.
13307         * python/py-frame.c (frapy_older): Remove cast.
13308         (frapy_newer): Likewise.
13309         * python/py-breakpoint.c (local_setattro): Remove cast.
13310         * python/py-arch.c (archpy_name): Remove local variable.
13311         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13312
13313 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13314
13315         * unittests/basic_string_view/element_access/char/empty.cc:
13316         Fix year range in copyright header.
13317
13318 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13319
13320         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13321         Delete.
13322         <operator==>: Update with for removed field.
13323         <hash>: Likewise.
13324         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13325         <isa_features>: ...this.
13326         <abi_features>: New field.
13327         (riscv_isa_flen): Update comment.
13328         (riscv_abi_xlen): New declaration.
13329         (riscv_abi_flen): New declaration.
13330         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13331         isa_features.
13332         (riscv_abi_xlen): New function.
13333         (riscv_isa_flen): Update to get answer from isa_features.
13334         (riscv_abi_flen): New function.
13335         (riscv_has_fp_abi): Update to get answer from abi_features.
13336         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13337         xlen and flen.
13338         (riscv_call_info) <xlen, flen>: Update comment.
13339         (riscv_call_arg_struct): Remove invalid assertions
13340         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13341         is removed.
13342         (riscv_gdbarch_init): Gather isa features and abi features
13343         separately, ensure both match on the gdbarch when reusing an old
13344         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13345         a target with 64-bit float hardware.
13346
13347 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13348
13349         * source.c (search_command_helper): Stop reverse search
13350         when line 1 has been searched.
13351
13352 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13353
13354         * record-full.c (record_full_base_target::close): Rewrite
13355         record_full_core_buf_list free logic.
13356
13357 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13358
13359         * break-catch-syscall.c (print_one_catch_syscall): xfree
13360         the last text.
13361
13362 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13363
13364         * top.c (print_gdb_version): Update Copyright year in version
13365         message.
13366
13367 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13368
13369         Update copyright year range in all GDB files.
13370
13371 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13372
13373         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13374
13375 For older changes see ChangeLog-2018.
13376 \f
13377 Local Variables:
13378 mode: change-log
13379 left-margin: 8
13380 fill-column: 74
13381 version-control: never
13382 coding: utf-8
13383 End:
13384