gdb/ChangeLog

   1 2019-07-03  Pedro Alves  <palves@redhat.com>
   2
   3         * NEWS (New commands): Mention "with" and "maint with".
   4         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
   5         (with_command, with_command_completer): New.
   6         (pipe_command): Adjust to new repeat_previous
   7         interface.
   8         (_initialize_cli_cmds): Install the "with" command and its "w"
   9         alias.
  10         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
  11         declarations.
  12         * cli/cli-setshow.c (parse_cli_var_uinteger)
  13         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
  14         argument strings for all var_types.
  15         (get_setshow_command_value_string): New, factored out from ...
  16         (do_show_command): ... this.
  17         * cli/cli-setshow.h: Include <string>.
  18         (get_setshow_command_value_string): Declare.
  19         * command.h (repeat_previous): Now returns const char *.  Adjust
  20         comment.
  21         * maint.c: Include "cli/cli-cmds.h".
  22         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
  23         (_initialize_maint_cmds): Register the "maintenance with" command.
  24         * top.c (repeat_previous): Move bits from pipe_command here:
  25         Return the saved command line, if any; error out if there's no
  26         command to relaunch.
  27
  28 2019-07-03  Pedro Alves  <palves@redhat.com>
  29
  30         * NEWS (New commands): Mention "maint set/show test-settings"
  31         instead of "maint test-settings".
  32         * maint-test-settings.c (maintenance_test_settings_list): Delete.
  33         (maintenance_test_settings_set_list): Rename to ...
  34         (maintenance_set_test_settings_list): ... this.
  35         (maintenance_test_settings_show_list): Rename to  ...
  36         (maintenance_show_test_settings_list): ... this.
  37         (maintenance_test_settings_cmd): Delete.
  38         (maintenance_test_settings_set_cmd): ...
  39         (maintenance_set_test_settings_cmd): ... this.
  40         (maintenance_test_settings_show_cmd): ...
  41         (maintenance_show_test_settings_cmd): ... this.
  42         (maintenance_test_settings_show_value_cmd):
  43         (maintenance_show_test_settings_value_cmd): ... this.
  44         (_initialize_maint_test_settings): No longer install the "maint
  45         test-settings" prefix command.  Rename "maint test-settings set"
  46         to "maint set test-settings", and "maint test-settings show" to
  47         "maint show test-settings".  Adjust all subcommands.
  48
  49 2019-07-03  Pedro Alves  <palves@redhat.com>
  50
  51         * maint-test-settings.c: Fix file's intro comment.  Replace all
  52         references to "test-options" with references to "test-settings",
  53         in comments.
  54
  55 2019-07-03  Pedro Alves  <palves@redhat.com>
  56
  57         * maint-test-settings.c (maintenance_test_settings_xxx)
  58         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
  59         New.
  60         (maintenance_test_settings_enums): Use them.
  61         (maintenance_test_settings_enum): Default to
  62         maintenance_test_settings_xxx.
  63         (_initialize_maint_test_settings): Initialize
  64         MAINTENANCE_TEST_SETTINGS_FILENAME.
  65
  66 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  67
  68         * breakpoint.h (remove_breakpoints_inf): Change return type to
  69         void, move function documentation here.
  70         * breakpoint.c (remove_breakpoints_inf): Change return type to
  71         void, move function documentation to header.
  72
  73 2019-07-02  Pedro Alves  <palves@redhat.com>
  74
  75         * NEWS (Completion improvements): Mention "info threads".
  76         * thread.c (struct info_threads_opts, info_threads_option_defs)
  77         (make_info_threads_options_def_group): New.
  78         (info_threads_command): Use gdb::option::process_options.
  79         (info_threads_command_completer): New.
  80         (_initialize_thread): Use gdb::option::build_help to build the
  81         help text for "info threads".
  82
  83 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
  84
  85         * defs.h (generic_load): Move from here...
  86         * symfile.h (generic_load): ... to here.  Rename name parameter
  87         to args.
  88         * symfile.c (generic_load): Add comment.
  89
  90 2019-07-01  Tom Tromey  <tromey@adacore.com>
  91
  92         * dwarf2read.c
  93         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
  94         declaration of without_params.  Fix formatting.
  95
  96 2019-07-01  Tom Tromey  <tromey@adacore.com>
  97
  98         * ada-exp.y (find_primitive_type): Update.
  99         * ada-lang.h (ada_lookup_symbol): Update.
 100         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 101         parameter.
 102         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 103
 104 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 105
 106         PR breakpoints/24541
 107         * gdbarch.c: Regenerate.
 108         * gdbarch.h: Regenerate.
 109         * gdbarch.sh: Add 'stap_adjust_register'.
 110         * i386-tdep.c: Include '<unordered_set>'.
 111         (i386_stap_adjust_register): New function.
 112         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 113         * stap-probe.c (stap_parse_register_operand): Call
 114         'gdbarch_stap_adjust_register'.
 115
 116 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 117
 118         PR python/24742
 119         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 120         * python/python.c (do_start_initialization): Use 'xmalloc'
 121         instead of 'PyMem_Malloc'.
 122
 123 2019-06-28  Tom Tromey  <tromey@adacore.com>
 124
 125         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 126         for Ada.
 127
 128 2019-06-27  Tom Tromey  <tromey@adacore.com>
 129
 130         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 131         objfile_key.
 132         (arm_find_mapping_symbol, arm_record_special_symbol)
 133         (_initialize_arm_tdep): Update.
 134         (arm_objfile_data_free): Remove.
 135
 136 2019-06-27  Tom Tromey  <tromey@adacore.com>
 137
 138         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 139         to cp_print_static_field.
 140
 141 2019-06-26  Tom Tromey  <tromey@adacore.com>
 142
 143         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 144         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 145         declare.
 146
 147 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 148
 149         * features/aarch64-core.c (create_feature_aarch64_core):
 150         Regenerate.
 151         * features/aarch64-core.xml: Add cpsr flags.
 152
 153 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 154
 155         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 156         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 157
 158 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 159
 160         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 161         field.
 162         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 163         use.
 164         (arm_record_special_symbol): Don't insert new symbol in sorted
 165         position, push it at the end.
 166
 167 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 168
 169         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 170         (arm_mapping_symbol_s): Remove.
 171         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 172         (arm_mapping_symbol_vec): New typedef.
 173         (struct arm_per_objfile): Add constructor.
 174         <section_maps>: Change type to
 175         std::unique_ptr<arm_mapping_symbol_vec[]>.
 176         (arm_compare_mapping_symbols): Remove.
 177         (arm_find_mapping_symbol): Adjust to section_maps type change.
 178         (arm_objfile_data_free): Call delete on arm_per_objfile.
 179         (arm_record_special_symbol): Adjust to section_maps type change.
 180         Allocate arm_per_objfile with new.
 181
 182 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 183
 184         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 185         with the command prefix.
 186
 187 2019-06-25  Tom Tromey  <tom@tromey.com>
 188
 189         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 190         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 191
 192 2019-06-25  Tom Tromey  <tom@tromey.com>
 193
 194         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 195         type.
 196         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 197         protected.
 198
 199 2019-06-25  Tom Tromey  <tom@tromey.com>
 200
 201         * tui/tui-winsource.c
 202         (tui_source_window_base::set_is_exec_point_at): Add check against
 203         LOA_ADDRESS.
 204
 205 2019-06-25  Tom Tromey  <tom@tromey.com>
 206
 207         * tui/tui-source.c (tui_set_source_content): Don't check before
 208         xfree.
 209         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 210
 211 2019-06-25  Tom Tromey  <tom@tromey.com>
 212
 213         * tui/tui-winsource.h (tui_update_source_window_as_is)
 214         (tui_alloc_source_buffer, tui_line_is_displayed)
 215         (tui_addr_is_displayed): Change type of win_info.
 216         * tui/tui-winsource.c (tui_update_source_window_as_is)
 217         (tui_clear_source_content, tui_show_source_line)
 218         (tui_show_source_content, tui_source_window_base::refill)
 219         (tui_source_window_base::set_is_exec_point_at)
 220         (tui_source_window_base::set_is_exec_point_at)
 221         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 222         (tui_alloc_source_buffer, tui_line_is_displayed)
 223         (tui_addr_is_displayed): Change type of win_info.  Update.
 224         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 225         (tui_source_window_base::do_make_visible_with_new_height):
 226         Update.
 227         * tui/tui-source.c (tui_set_source_content)
 228         (tui_set_source_content_nil)
 229         (tui_source_window::do_scroll_vertical): Update.
 230         * tui/tui-layout.c (show_layout): Update.
 231         * tui/tui-disasm.c (tui_set_disassem_content)
 232         (tui_disasm_window::do_scroll_vertical): Update.
 233         * tui/tui-data.h (tui_win_content): Remove.
 234         (struct tui_gen_win_info) <content, content_size>: Remove.
 235         (struct tui_source_element): Add initializers and destructor.
 236         (union tui_which_element, struct tui_win_element): Remove.
 237         (struct tui_source_window_base) <content>: New field.
 238         (struct tui_data_window): Remove destructor.
 239         (tui_alloc_content, tui_free_win_content)
 240         (tui_free_all_source_wins_content): Don't declare.
 241         * tui/tui-data.c (tui_initialize_static_data): Update.
 242         (init_content_element, tui_alloc_content): Remove.
 243         (~tui_gen_win_info): Update.
 244         (~tui_data_window, tui_free_all_source_wins_content)
 245         (tui_free_win_content, free_content, free_content_elements):
 246         Remove.
 247
 248 2019-06-25  Tom Tromey  <tom@tromey.com>
 249
 250         * tui/tui-winsource.h (tui_clear_source_content)
 251         (tui_erase_source_content, tui_show_source_content): Change type
 252         of win_info.
 253         * tui/tui-winsource.c (tui_clear_source_content)
 254         (tui_erase_source_content, tui_show_source_content): Change type
 255         of win_info.
 256         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 257         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 258         win_info.
 259         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 260         win_info.
 261         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 262
 263 2019-06-25  Tom Tromey  <tom@tromey.com>
 264
 265         * tui/tui-winsource.c (tui_clear_source_content)
 266         (tui_source_window_base::set_is_exec_point_at): Update.
 267         * tui/tui-source.c (tui_set_source_content_nil): Update.
 268         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 269         a bool.
 270         * tui/tui-data.c (init_content_element): Update.
 271
 272 2019-06-25  Tom Tromey  <tom@tromey.com>
 273
 274         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 275         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 276         * tui/tui-layout.c (init_and_make_win): Update.
 277         * tui/tui.h (enum tui_win_type): Update.
 278         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 279         tui_win_is_auxillary.
 280         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 281         tui_win_is_auxillary.
 282
 283 2019-06-25  Tom Tromey  <tom@tromey.com>
 284
 285         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 286         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 287         (tui_delete_data_content_windows, tui_display_all_data)
 288         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 289         Update.
 290         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 291         * tui/tui-regs.c (tui_last_regs_line_no)
 292         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 293         (tui_show_registers): Update.
 294         (tui_show_register_group): Return void.  Update.
 295         (tui_display_registers_from, tui_display_reg_element_at_line)
 296         (tui_display_registers_from_line, tui_check_register_values):
 297         Update.
 298         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 299         member.
 300         (struct tui_data_window) <regs_content>: Now a std::vector.
 301         <regs_content_count>: Remove.
 302         (tui_add_content_elements, tui_free_data_content): Don't declare.
 303         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 304         (init_content_element): Remove DATA_WIN case.  Add assert.
 305         (tui_add_content_elements): Remove.
 306         (tui_data_window): Update.
 307         (tui_free_data_content): Remove.
 308         (free_content_elements): Remove DATA_WIN case.
 309
 310 2019-06-25  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-data.c (tui_data_item_window): Update.
 313         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 314         * tui/tui-windata.c (tui_display_all_data)
 315         (tui_display_data_from_line): Update.
 316         (tui_check_data_values): Remove.
 317         * tui/tui-regs.c (tui_show_register_group)
 318         (tui_display_reg_element_at_line): Update.
 319         * tui/tui-hooks.c (tui_register_changed)
 320         (tui_refresh_frame_and_register_information): Call
 321         tui_check_register_values.
 322         * tui/tui-data.h (struct tui_data_window) <data_content,
 323         data_content_count, data_type>: Remove.
 324         (enum tui_data_type): Remove.
 325
 326         * tui/tui-data.c (tui_data_window::clear_detail)
 327         (~tui_data_window): Update.
 328
 329 2019-06-25  Tom Tromey  <tom@tromey.com>
 330
 331         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 332         declare.
 333         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 334         Rename from tui_first_data_item_displayed.  Update.
 335         (tui_data_window::refresh_all)
 336         (tui_data_window::do_scroll_vertical): Update.
 337         * tui/tui-data.h (struct tui_data_window)
 338         <first_data_item_displayed>: Declare new method.
 339
 340 2019-06-25  Tom Tromey  <tom@tromey.com>
 341
 342         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 343         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 344         contents...
 345         (tui_initialize_static_data): ...here.
 346
 347 2019-06-25  Tom Tromey  <tom@tromey.com>
 348
 349         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 350         (tui_display_registers_from, tui_check_register_values): Update.
 351         (tui_display_register): Remove win_info parameter; update.
 352         (tui_get_register): Change type of parameters.
 353         * tui/tui-data.h (struct tui_data_element): Remove.
 354         (union tui_which_element) <data>: Remove.
 355         <data_window>: Change type.
 356         (struct tui_data_item_window): New.
 357         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 358         case.  Add assert.
 359         (~tui_data_item_window): New destructor.
 360         (free_content_elements): Remove DATA_ITEM_WIN case.
 361
 362 2019-06-25  Tom Tromey  <tom@tromey.com>
 363
 364         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 365         Remove.
 366
 367 2019-06-25  Tom Tromey  <tom@tromey.com>
 368
 369         * tui/tui-data.h (struct tui_command_element): Remove.
 370         (union tui_which_element) <command>: Remove.
 371         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 372         assert.
 373         (free_content_elements): Remove CMD_WIN case.
 374
 375 2019-06-25  Tom Tromey  <tom@tromey.com>
 376
 377         * tui/tui-layout.c (tui_set_layout): Update.
 378         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 379         * tui/tui-data.c (layout_def): Update.
 380
 381 2019-06-25  Tom Tromey  <tom@tromey.com>
 382
 383         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 384         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 385         (tui_source_window_base::set_new_height): Update.
 386         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 387         Update.
 388         (tui_set_locator_fullname, tui_set_locator_info)
 389         (tui_show_frame_info): Update.
 390         * tui/tui-source.c (tui_set_source_content)
 391         (tui_source_is_displayed): Update.
 392         * tui/tui-layout.c (show_source_disasm_command, show_data)
 393         (show_source_or_disasm_and_command): Update.
 394         * tui/tui-disasm.c (tui_set_disassem_content)
 395         (tui_get_begin_asm_address): Update.
 396         * tui/tui-data.h (struct tui_locator_element): Remove.
 397         (union tui_which_element) <locator>: Remove.
 398         (struct tui_locator_window): New.
 399         (tui_locator_win_info_ptr): Change return type.
 400         * tui/tui-data.c (_locator): Change type.
 401         (tui_locator_win_info_ptr): Change return type.
 402         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 403         (tui_alloc_content): Add assert.
 404
 405 2019-06-25  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-winsource.c
 408         (tui_exec_info_window::maybe_allocate_content): New method.
 409         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 410         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 411         (make_source_or_disasm_window): Add cast.
 412         * tui/tui-data.h (union tui_which_element) <simple_string>:
 413         Remove.
 414         (struct tui_source_info): New.
 415         (struct tui_source_window_base) <execution_info>: Change type.
 416         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 417         case, and add assert.
 418         (tui_alloc_content): Add assert.
 419
 420 2019-06-25  Tom Tromey  <tom@tromey.com>
 421
 422         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 423         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 424         * tui/tui-data.c (tui_alloc_win_info): Remove.
 425
 426 2019-06-25  Tom Tromey  <tom@tromey.com>
 427
 428         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 429         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 430         can_highlight.
 431
 432 2019-06-25  Tom Tromey  <tom@tromey.com>
 433
 434         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 435         make_visible_with_new_height method.
 436         (tui_win_info::make_visible_with_new_height): New method.
 437         (tui_source_window_base::do_make_visible_with_new_height)
 438         (tui_data_window::do_make_visible_with_new_height)
 439         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 440         (make_visible_with_new_height): Remove.
 441         (tui_resize_all, tui_adjust_win_heights): Use
 442         make_visible_with_new_height method.
 443         * tui/tui-data.h (struct tui_win_info)
 444         <do_make_visible_with_new_height, make_visible_with_new_height>:
 445         New methods.
 446         (struct tui_source_window_base, struct tui_data_window)
 447         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 448         methods.
 449
 450 2019-06-25  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 453         method.
 454         (update_tab_width): Call update_tab_width method.
 455         * tui/tui-data.h (struct tui_win_info)
 456         (struct tui_source_window_base) <update_tab_width>: New methods.
 457
 458 2019-06-25  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 461         parameter.
 462         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 463         parameter.
 464         (tui_gen_win_info::make_visible): Update.
 465         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 466         parameter.
 467         * tui/tui-data.h (enum tui_box): New enum.
 468         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 469
 470 2019-06-25  Tom Tromey  <tom@tromey.com>
 471
 472         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 473         init_and_make_win for EXEC_INFO_WIN.
 474         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 475         longer inline.
 476         (struct tui_win_info) <~tui_win_info>: Inline.
 477         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 478         Don't declare.
 479         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 480         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 481         Remove.
 482         (tui_initialize_static_data): Update.
 483         (~tui_gen_win_info): Handle more cleanup here.
 484         (~tui_source_window_base): Delete "execution_info".
 485         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 486
 487 2019-06-25  Tom Tromey  <tom@tromey.com>
 488
 489         * tui/tui-layout.c (make_command_window): Don't set
 490         can_highlight.
 491         (show_source_disasm_command): Call the reset method.
 492         (show_data): Don't set can_highlight.  Call the reset method.
 493         (tui_gen_win_info::reset): Rename from init_gen_win_info
 494         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 495         (show_source_or_disasm_and_command): Call the reset method.
 496         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 497         (struct tui_cmd_window): Set can_highlight.
 498
 499 2019-06-25  Tom Tromey  <tom@tromey.com>
 500
 501         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 502         from make_visible.
 503         (tui_make_visible, tui_make_invisible): Rewrite.
 504         (tui_win_info::make_visible): Remove.
 505         (tui_source_window_base::make_visible): Update.
 506         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 507         method.  Moved from...
 508         (struct tui_win_info) <make_visible>: ...here.
 509
 510 2019-06-25  Tom Tromey  <tom@tromey.com>
 511
 512         * tui/tui-winsource.c
 513         (tui_source_window_base::do_scroll_horizontal): Remove direction
 514         parameter.
 515         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 516         direction parameter.
 517         * tui/tui-win.c (tui_win_info::forward_scroll)
 518         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 519         (tui_win_info::right_scroll): Update.
 520         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 521         direction parameter.
 522         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 523         direction parameter.
 524         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 525         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 526         Remove direction parameter.
 527         (struct tui_source_window_base, struct tui_source_window)
 528         (struct tui_disasm_window, struct tui_data_window)
 529         (struct tui_cmd_window): Update.
 530
 531 2019-06-25  Tom Tromey  <tom@tromey.com>
 532
 533         * tui/tui-winsource.h (tui_set_exec_info_content)
 534         (tui_show_exec_info_content, tui_erase_exec_info_content)
 535         (tui_clear_exec_info_content, tui_update_exec_info): Change
 536         argument to tui_source_window_base.
 537         * tui/tui-winsource.c (tui_set_exec_info_content)
 538         (tui_show_exec_info_content, tui_erase_exec_info_content)
 539         (tui_clear_exec_info_content, tui_update_exec_info): Change
 540         argument to tui_source_window_base.
 541
 542 2019-06-25  Tom Tromey  <tom@tromey.com>
 543
 544         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 545         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 546
 547 2019-06-25  Tom Tromey  <tom@tromey.com>
 548
 549         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 550         check.
 551
 552 2019-06-25  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 555         type to void.
 556         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 557         type to void.
 558         * tui/tui-source.c (tui_set_source_content): Update.
 559         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 560
 561 2019-06-25  Tom Tromey  <tom@tromey.com>
 562
 563         * tui/tui-win.c (window_name_completer, tui_set_focus)
 564         (tui_all_windows_info): Use name method.
 565         * tui/tui-data.h (struct tui_gen_win_info)
 566         (struct tui_source_window, struct tui_disasm_window)
 567         (struct tui_data_window, struct tui_cmd_window) <name>: New
 568         method.
 569         (tui_win_name): Don't declare.
 570         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 571         (tui_win_name): Remove.
 572
 573 2019-06-25  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.h (tui_update_source_window)
 576         (tui_update_source_window_as_is): Change parameter type.
 577         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 578         to be a tui_source_window_base.
 579         (tui_update_source_window_as_is): Likewise.
 580         * tui/tui-win.c (make_visible_with_new_height): Update.
 581
 582 2019-06-25  Tom Tromey  <tom@tromey.com>
 583
 584         * tui/tui-winsource.c (tui_erase_source_content)
 585         (tui_show_source_content, tui_show_exec_info_content)
 586         (tui_erase_exec_info_content): Use refresh_window method.
 587         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 588         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 589         from tui_refresh_win.
 590         (tui_data_window::refresh_window): New method.
 591         (tui_win_info::refresh, tui_source_window_base::refresh)
 592         (tui_refresh_all): Use refresh_window method.
 593         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 594         method.
 595         * tui/tui-regs.c (tui_display_register): Call refresh_window
 596         method.
 597         * tui/tui-layout.c (show_source_disasm_command)
 598         (show_source_or_disasm_and_command): Call refresh_window method.
 599         * tui/tui-data.h (struct tui_gen_win_info)
 600         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 601         New method.
 602
 603 2019-06-25  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui.c (tui_rl_other_window, tui_enable)
 606         (tui_is_window_visible, tui_get_command_dimension): Update.
 607         * tui/tui-winsource.c (tui_update_source_window_as_is)
 608         (tui_clear_source_content, tui_erase_source_content)
 609         (tui_show_source_line, tui_source_window_base::refill)
 610         (tui_source_window_base::do_scroll_horizontal)
 611         (tui_source_window_base::set_is_exec_point_at)
 612         (tui_update_breakpoint_info, tui_set_exec_info_content)
 613         (tui_alloc_source_buffer, tui_line_is_displayed)
 614         (tui_addr_is_displayed): Update.
 615         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 616         (tui_check_and_display_highlight_if_needed)
 617         (tui_win_info::make_visible, tui_win_info::refresh)
 618         (tui_refresh_all): Update.
 619         * tui/tui-windata.c (tui_first_data_item_displayed)
 620         (tui_delete_data_content_windows, tui_erase_data_content)
 621         (tui_display_all_data, tui_data_window::refresh_all)
 622         (tui_check_data_values): Update.
 623         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 624         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 625         (tui_win_info::backward_scroll, tui_refresh_all_win)
 626         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 627         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 628         (tui_source_window_base::set_new_height)
 629         (tui_data_window::set_new_height)
 630         (make_invisible_and_set_new_height)
 631         (make_visible_with_new_height, new_height_ok)
 632         (parse_scrolling_args): Update.
 633         * tui/tui-stack.c (tui_show_frame_info): Update.
 634         * tui/tui-source.c (tui_set_source_content)
 635         (tui_set_source_content_nil, tui_source_is_displayed)
 636         (tui_source_window::do_scroll_vertical): Update.
 637         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 638         (tui_display_registers_from, tui_display_reg_element_at_line)
 639         (tui_check_register_values, tui_reg_command): Update.
 640         * tui/tui-layout.c (tui_default_win_height)
 641         (show_source_disasm_command, show_data, init_and_make_win)
 642         (show_source_or_disasm_and_command): Update.
 643         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 644         (tui_redisplay_readline, tui_mld_flush)
 645         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 646         (tui_getc): Update.
 647         * tui/tui-disasm.c (tui_set_disassem_content)
 648         (tui_disasm_window::do_scroll_vertical): Update.
 649         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 650         Now virtual.
 651         (struct tui_win_info): Derive from tui_gen_win_info.
 652         <~tui_win_info>: Mark as override.
 653         <generic>: Remove member.
 654         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 655         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 656         (~tui_data_window, ~tui_win_info)
 657         (tui_free_all_source_wins_content): Update.
 658         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 659
 660 2019-06-25  Tom Tromey  <tom@tromey.com>
 661
 662         * tui/tui-layout.c (init_and_make_win): Use new.
 663         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 664         destructor, initializers.
 665         (tui_alloc_generic_win_info): Don't declare.
 666         * tui/tui-data.c (_locator): Add argument to constructor.
 667         (source_win, disasm_win): New globals.
 668         (exec_info): Remove.
 669         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 670         Update.
 671         (tui_alloc_generic_win_info): Remove.
 672         (init_content_element): Use new.
 673         (tui_win_info::tui_win_info): Update.
 674         (free_content_elements) <case DATA_WIN>: Use delete.
 675
 676 2019-06-25  Tom Tromey  <tom@tromey.com>
 677
 678         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 679         * tui/tui-windata.c (tui_first_data_item_displayed)
 680         (tui_delete_data_content_windows): Update.
 681         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 682         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 683         (tui_display_registers_from, tui_check_register_values): Update.
 684         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 685         pointer.
 686         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 687         window.
 688         (tui_free_data_content): Update.
 689         (free_content_elements) <case DATA_WIN>: Free the window.
 690
 691 2019-06-25  Tom Tromey  <tom@tromey.com>
 692
 693         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 694         Update.
 695         * tui/tui-layout.c (make_command_window)
 696         (show_source_disasm_command, show_data, init_and_make_win)
 697         (show_source_or_disasm_and_command): Update.
 698         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 699         method.
 700         <can_highight, is_highlighted>: Now bool.
 701         (tui_set_win_highlight): Don't declare.
 702         * tui/tui-data.c (tui_set_win_highlight): Remove.
 703
 704 2019-06-25  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-wingeneral.c (make_visible): Remove check of window
 707         type.
 708
 709 2019-06-25  Tom Tromey  <tom@tromey.com>
 710
 711         * tui/tui-win.c (tui_win_info::max_height)
 712         (tui_cmd_window::max_height): New methods.
 713         (new_height_ok): Call max_height.
 714         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 715         <max_height>: New method.
 716
 717 2019-06-25  Tom Tromey  <tom@tromey.com>
 718
 719         * tui/tui-win.c (tui_source_window_base::set_new_height)
 720         (tui_data_window::set_new_height): New methods.
 721         (make_invisible_and_set_new_height): Call set_new_height method.
 722         * tui/tui-data.h (struct tui_win_info)
 723         (struct tui_source_window_base, struct tui_data_window)
 724         <set_new_height>: New method.
 725
 726 2019-06-25  Tom Tromey  <tom@tromey.com>
 727
 728         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 729         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 730         tui_refresh_data_win.
 731         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 732         method.
 733         (tui_refresh_all_win): Call the refresh_all method.
 734         (tui_set_focus): Likewise.
 735         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 736         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 737         Likewise.
 738
 739 2019-06-25  Tom Tromey  <tom@tromey.com>
 740
 741         * tui/tui-winsource.h (tui_refill_source_window)
 742         (tui_set_is_exec_point_at): Don't declare.
 743         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 744         (tui_source_window_base::refill): Rename from
 745         tui_refill_source_window.
 746         (tui_source_window_base::do_scroll_horizontal): Update.
 747         (tui_source_window_base::set_is_exec_point_at): Rename from
 748         tui_set_is_exec_point_at.
 749         (tui_update_all_breakpoint_info): Update.
 750         * tui/tui-stack.c (tui_show_frame_info): Update.
 751         * tui/tui-layout.c (show_data): Add cast.
 752         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 753         * tui/tui-data.h (struct tui_source_window_base) <refill,
 754         set_is_exec_point_at>: New methods.
 755         (tui_source_windows, tui_add_to_source_windows): Update types.
 756         (tui_add_to_source_windows): Remove redundant declaration.
 757         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 758         (tui_source_windows): Change return type.
 759         (tui_clear_source_windows_detail): Update.
 760         (tui_add_to_source_windows): Change type of parameter.
 761         (tui_free_all_source_wins_content): Update.
 762
 763 2019-06-25  Tom Tromey  <tom@tromey.com>
 764
 765         * tui/tui-wingeneral.c (tui_win_info::refresh)
 766         (tui_source_window_base::refresh): New methods.
 767         (tui_refresh_all): Call the refresh method.
 768         * tui/tui-data.h (struct tui_win_info)
 769         (struct tui_source_window_base) <refresh>: New method.
 770
 771 2019-06-25  Tom Tromey  <tom@tromey.com>
 772
 773         * tui/tui.h (tui_is_window_visible): Return bool.
 774         * tui/tui.c (tui_is_window_visible): Return bool.
 775         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 776         (tui_make_visible, tui_make_invisible)
 777         (tui_win_info::make_visible)
 778         (tui_source_window_base::make_visible, make_all_visible)
 779         (tui_make_all_visible, tui_make_all_invisible): Update.
 780         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 781         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 782         bool.
 783         (struct tui_win_info, struct tui_source_window_base)
 784         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 785         * tui/tui-data.c (tui_init_generic_part): Update.
 786
 787 2019-06-25  Tom Tromey  <tom@tromey.com>
 788
 789         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 790         (tui_source_window_base::make_visible): New methods.
 791         (make_all_visible): Make method call.
 792         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 793         (struct tui_source_window_base, struct tui_cmd_window): Override
 794         make_visible.
 795         (tui_win_is_source_type): Don't declare.
 796         * tui/tui-data.c (tui_win_is_source_type): Remove.
 797
 798 2019-06-25  Tom Tromey  <tom@tromey.com>
 799
 800         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 801         NULL check.
 802
 803 2019-06-25  Tom Tromey  <tom@tromey.com>
 804
 805         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 806         Inline constructor.  Add initializers for members.
 807         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 808         constructors; now inline in class.
 809
 810 2019-06-25  Tom Tromey  <tom@tromey.com>
 811
 812         * tui/tui-regs.c (tui_show_registers): Update.
 813         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 814         bool.
 815         * tui/tui-data.c (tui_data_window::clear_detail)
 816         (tui_data_window): Update.
 817
 818 2019-06-25  Tom Tromey  <tom@tromey.com>
 819
 820         * tui/tui-windata.c (tui_display_all_data)
 821         (tui_display_data_from_line, tui_display_data_from)
 822         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 823         Update.
 824         * tui/tui-regs.c (tui_last_regs_line_no)
 825         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 826         (tui_show_registers, tui_show_register_group)
 827         (tui_display_registers_from, tui_display_reg_element_at_line)
 828         (tui_display_registers_from_line, tui_check_register_values)
 829         (tui_reg_next, tui_reg_prev): Update.
 830         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 831         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 832         tui_data_window.
 833         (struct tui_win_info) <detail>: Remove.  Add new fields from
 834         tui_data_info.
 835         (TUI_DATA_WIN): Add cast.
 836         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 837         (~tui_data_window): Simplify.
 838
 839 2019-06-25  Tom Tromey  <tom@tromey.com>
 840
 841         * tui/tui-layout.c (show_source_disasm_command)
 842         (show_source_or_disasm_and_command): Update.
 843         * tui/tui-io.c (update_cmdwin_start_line)
 844         (tui_redisplay_readline): Update.
 845         * tui/tui-data.h (struct tui_command_info): Remove.
 846         (struct tui_win_info) <detail>: Remove command_info member.
 847         (struct tui_data_window) <start_line>: New member, from
 848         tui_command_info.
 849         (TUI_CMD_WIN): Add casts.
 850
 851 2019-06-25  Tom Tromey  <tom@tromey.com>
 852
 853         * tui/tui-winsource.c (tui_update_source_window)
 854         (tui_refill_source_window)
 855         (tui_source_window_base::do_scroll_horizontal)
 856         (tui_update_breakpoint_info, tui_set_exec_info_content)
 857         (tui_show_exec_info_content, tui_erase_exec_info_content)
 858         (tui_clear_exec_info_content): Update.
 859         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 860         Update.
 861         * tui/tui-win.c (make_invisible_and_set_new_height)
 862         (make_visible_with_new_height): Update.
 863         * tui/tui-source.c (tui_set_source_content)
 864         (tui_show_symtab_source): Update.
 865         * tui/tui-layout.c (extract_display_start_addr)
 866         (show_source_disasm_command, show_data)
 867         (make_source_or_disasm_window)
 868         (show_source_or_disasm_and_command): Update.
 869         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 870         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 871         "gdbarch".
 872         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 873         to tui_source_window_base.
 874         (struct tui_win_info) <detail>: Remove source_info member.
 875         (struct tui_source_window_base) <has_locator>: Inline.
 876         Move contents from tui_source_info; rename has_locator member to
 877         m_has_locator.
 878         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 879         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 880         header file.
 881         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 882         Simplify.
 883         (tui_free_all_source_wins_content): Cast to
 884         tui_source_window_base.
 885
 886 2019-06-25  Tom Tromey  <tom@tromey.com>
 887
 888         * tui/tui-win.c (make_invisible_and_set_new_height)
 889         (make_visible_with_new_height): Call has_locator method.
 890         * tui/tui-layout.c (show_source_disasm_command, show_data)
 891         (show_source_or_disasm_and_command): Update for bool change.
 892         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 893         (tui_win_info) <has_locator>: New method.
 894         (struct tui_source_window_base) <has_locator>: New method.
 895         (tui_win_has_locator): Don't declare.
 896         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 897         from tui_win_has_locator.
 898         (tui_source_window_base): Use false, not FALSE.
 899
 900 2019-06-25  Tom Tromey  <tom@tromey.com>
 901
 902         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 903         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 904         clear_detail method directly.
 905         (tui_clear_win_detail): Remove.
 906
 907 2019-06-25  Tom Tromey  <tom@tromey.com>
 908
 909         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 910         "this", not TUI_DISASM_WIN.
 911
 912 2019-06-25  Tom Tromey  <tom@tromey.com>
 913
 914         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 915         declare.
 916         * tui/tui-winsource.c
 917         (tui_source_window_base::do_scroll_horizontal): Rename from
 918         tui_horizontal_source_scroll.
 919         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 920         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 921         from tui_vertical_data_scroll.
 922         * tui/tui-win.h (tui_scroll): Don't declare.
 923         * tui/tui-win.c (tui_win_info::forward_scroll)
 924         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 925         (tui_win_info::right_scroll): Rename and update.
 926         (tui_scroll_forward_command, tui_scroll_backward_command)
 927         (tui_scroll_left_command, tui_scroll_right_command): Update.
 928         (tui_scroll): Remove.
 929         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 930         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 931         from tui_vertical_source_scroll.
 932         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 933         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 934         from tui_vertical_disassem_scroll.
 935         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 936         do_scroll_horizontal>: New methods.
 937         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 938         Likewise.
 939         (struct tui_source_window_base): Add do_scroll_horizontal.
 940         (struct tui_source_window, struct tui_disasm_window): Add
 941         do_scroll_vertical.
 942         (struct tui_data_window, struct tui_cmd_window): Add
 943         do_scroll_horizontal and do_scroll_vertical.
 944         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 945
 946 2019-06-25  Tom Tromey  <tom@tromey.com>
 947
 948         * tui/tui-data.h (struct tui_source_window_base): New struct.
 949         (struct tui_source_window): Derive from tui_source_window_base.
 950         (struct tui_disasm_window): New struct.
 951         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 952         from tui_source_window::clear_detail.
 953         (tui_source_window_base): Rename from tui_source_window.
 954         (~tui_source_window_base): Rename from ~tui_source_window.
 955         (tui_alloc_win_info): Create a tui_disasm_window.
 956
 957 2019-06-25  Tom Tromey  <tom@tromey.com>
 958
 959         * tui/tui-data.h (struct tui_source_window)
 960         (struct tui_data_window): Declare destructors.
 961         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 962         destructors.
 963         (tui_win_info): Simplify.
 964
 965 2019-06-25  Tom Tromey  <tom@tromey.com>
 966
 967         * tui/tui-winsource.c (tui_display_main)
 968         (tui_update_source_windows_with_addr)
 969         (tui_update_all_breakpoint_info): Update.
 970         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 971         (new_height_ok, parse_scrolling_args): Update.
 972         * tui/tui-stack.c (tui_show_frame_info): Update.
 973         * tui/tui-data.h (struct tui_list): Remove.
 974         (tui_source_windows): Return a reference to a std::vector.
 975         * tui/tui-data.c (source_windows): Now a std::vector.
 976         (tui_source_windows): Change return type.
 977         (tui_clear_source_windows): Rewrite.
 978         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 979         (tui_free_all_source_wins_content): Rewrite.
 980
 981 2019-06-25  Tom Tromey  <tom@tromey.com>
 982
 983         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 984         (struct tui_data_window, struct tui_cmd_window): Declare
 985         clear_detail method.
 986         * tui/tui-data.c (tui_source_window::clear_detail)
 987         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 988         methods.
 989         (tui_clear_win_detail): Simplify.
 990
 991 2019-06-25  Tom Tromey  <tom@tromey.com>
 992
 993         * tui/tui-layout.c (make_source_window, make_disasm_window)
 994         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 995         Return the new window.
 996         (show_source_disasm_command, show_data)
 997         (show_source_or_disasm_and_command): Update.
 998
 999 2019-06-25  Tom Tromey  <tom@tromey.com>
1000
1001         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1002         parameter.  Return the new window.
1003         (show_source_disasm_command): Update and remove NULL check.
1004         (show_source_or_disasm_and_command): Update.
1005
1006 2019-06-25  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1009
1010 2019-06-25  Tom Tromey  <tom@tromey.com>
1011
1012         * tui/tui-data.h (struct tui_win_info): Make constructor
1013         protected.  Make destructor virtual.  Add initializers.
1014         (tui_source_window, tui_data_window, tui_cmd_window): New
1015         classes.
1016         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1017         constructor.  Add "type" parameter.
1018         (tui_source_window, tui_data_window, tui_cmd_window): New
1019         constructors.
1020         (tui_alloc_win_info): Instantiate the appropriate subclass.
1021
1022 2019-06-25  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-win.c (tui_resize_all): Use delete.
1025         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1026         destructor.
1027         (tui_free_window): Don't declare.
1028         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1029         Update.
1030
1031 2019-06-25  Tom Tromey  <tom@tromey.com>
1032
1033         * tui/tui-data.h (struct tui_win_info): Add constructor.
1034         * tui/tui-data.c (tui_alloc_win_info): Use new.
1035         (tui_free_window): Use delete.
1036
1037 2019-06-22  Tom Tromey  <tom@tromey.com>
1038
1039         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1040         declare.
1041         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1042
1043 2019-06-22  Tom Tromey  <tom@tromey.com>
1044
1045         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1046         declare.
1047         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1048
1049 2019-06-22  Tom de Vries  <tdevries@suse.de>
1050
1051         * dwarf2read.c (create_addrmap_from_aranges)
1052         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1053         instead of '%zu'.
1054
1055 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1056
1057         * dwarf2read.h (dwarf2_section_info_def): Remove.
1058         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1059         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1060         std::vector<dwarf2_section_info>.
1061         (struct dwo_file) <~dwo_file>: Remove.
1062         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1063         types field.
1064         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1065         (dwarf2_read_debug_names): Likewise.
1066         (create_debug_types_hash_table): Change parameter type to
1067         array_view, adjust code accordingly.
1068         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1069         (partial_die_info::fixup): Likewise.
1070         (determine_prefix): Likewise.
1071         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1072
1073 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1074
1075         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1076         gdb_bfd_ref_ptr.
1077         <~dwo_file>: Remove call to gdb_bfd_unref.
1078         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1079         gdb_bfd_ref_ptr::get.
1080
1081 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1082
1083         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1084         type to htab_up.
1085         * dwarf2read.c (struct dwo_file): Initialize fields.
1086         <~dwo_file>: New.
1087         (free_dwo_file): Remove, move content to ~dwo_file.
1088         (struct dwo_file_deleter): Remove.
1089         (dwo_file_up>: Remove custom deleter.
1090         (free_dwo_files): Remove.
1091         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1092         dwo_files.
1093         (process_skeletonless_type_units): Call unique_ptr::get.
1094         (allocate_dwo_file_hash_table): Add deleter to created hash
1095         table.  Change return type to htab_up.
1096         (lookup_dwo_file_slot): Don't memset dwo_file, call
1097         unique_ptr::get.
1098         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1099         (create_dwo_unit_in_dwp_v2): Likewise.
1100         (open_and_init_dwo_file): Likewise.
1101         (free_dwo_file_from_slot): Remove.
1102
1103 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1104
1105         * dwarf2read.h (struct dwarf2_section_info) <readin,
1106         is_virtual>: Change type to bool.
1107         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1108         true instead of 1.
1109
1110 2019-06-19  Tom Tromey  <tom@tromey.com>
1111
1112         * tui/tui-data.h (tui_init_content_element): Don't declare.
1113
1114 2019-06-19  Tom Tromey  <tom@tromey.com>
1115
1116         * tui/tui-data.h (tui_init_win_info): Don't declare.
1117
1118 2019-06-19  Tom de Vries  <tdevries@suse.de>
1119
1120         * dwarf2read.h (abstract_to_concrete): Change type to
1121         std::unordered_map<sect_offset, std::vector<sect_offset>,
1122         gdb::hash_enum<sect_offset>>.
1123
1124 2019-06-19  Tom Tromey  <tromey@adacore.com>
1125
1126         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1127         EVAL_AVOID_SIDE_EFFECTS specially.
1128
1129 2019-06-19  Tom Tromey  <tromey@adacore.com>
1130
1131         * source-cache.c (highlighter): New global.
1132         (source_cache::get_source_lines): Create a highlighter on demand.
1133
1134 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1135
1136         * defs.h (deprecated_interactive_hook): Delete declaration.
1137         * interps.c (clear_interpreter_hooks): Remove use of
1138         deprecated_interactive_hook.
1139         * top.c (deprecated_interactive_hook): Delete definition.
1140         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1141
1142 2019-06-18  Tom de Vries  <tdevries@suse.de>
1143
1144         PR gdb/24515
1145         * dwarf2read.h (abstract_to_concrete): Change type from
1146         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1147         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1148         * dwarf2read.c (read_variable): Update.
1149         (dwarf2_fetch_die_loc_sect_off): Update.
1150
1151 2019-06-17  Tom de Vries  <tdevries@suse.de>
1152
1153         PR gdb/24617
1154         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1155         accessing parent[parent_len - 1].
1156
1157 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1158
1159         PR gdb/24364
1160         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1161         call dtrace_process_dof with NULL dof.
1162
1163 2019-06-16  Tom de Vries  <tdevries@suse.de>
1164
1165         PR gdb/24445
1166         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1167
1168 2019-06-16  Tom Tromey  <tom@tromey.com>
1169
1170         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1171         (make_all_visible): Use address of member.
1172
1173 2019-06-16  Tom Tromey  <tom@tromey.com>
1174
1175         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1176         (tui_free_window, free_content, free_content_elements): Remove
1177         unnecessary cast.
1178         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1179         cast.
1180         * tui/tui-regs.c (tui_show_register_group)
1181         (tui_display_registers_from, tui_display_reg_element_at_line):
1182         Remove unnecessary cast.
1183
1184 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1185
1186         * linux-nat.c (normal_mask): Delete.
1187         (_initialize_linux_nat): Don't initialise normal_mask.
1188
1189 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1190
1191         PR gdb/24445
1192         * dwarf-index-write.h (write_psymtabs_to_index): Add
1193         dwz_basename parameter.
1194         * dwarf-index-write.c (write_gdbindex): Move file writing to
1195         write_gdbindex_1.  Change return type void.
1196         (assert_file_size): Move up, remove filename parameter.
1197         (write_gdbindex_1): New function.
1198         (write_debug_names): Change return type to void, call
1199         assert_file_size.
1200         (struct index_wip_file): New struct.
1201         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1202         file logic to index_wip_file.  Write index for dwz file if
1203         needed.
1204         (save_gdb_index_command): Pass basename of dwz file, if present.
1205         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1206         build-id of dwz file, if present.
1207         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1208         (dwarf2_get_dwz_file): Likewise.
1209         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1210         (dwarf2_get_dwz_file): Likewise.
1211
1212 2019-06-16  Tom Tromey  <tom@tromey.com>
1213
1214         * coffread.c (process_coff_symbol): Use xstrdup.
1215         * value.c (create_internalvar): Use xstrdup.
1216
1217 2019-06-16  Tom Tromey  <tom@tromey.com>
1218
1219         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1220         * breakpoint.c (stopin_command, stopat_command)
1221         (until_break_command, decode_location_default): Remove unnecessary
1222         cast.
1223         * utils.c (subset_compare): Remove unnecessary cast.
1224         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1225         cast.
1226         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1227         cast.
1228         * infcmd.c (path_command): Remove unnecessary cast.
1229         * coffread.c (decode_type): Remove unnecessary cast.
1230         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1231         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1232         * tui/tui-stack.c (tui_show_locator_content)
1233         (tui_show_frame_info): Remove unnecessary cast.
1234         * tui/tui-win.c (tui_scroll_forward_command)
1235         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1236         (parse_scrolling_args): Remove unnecessary cast.
1237         * tui/tui-data.c (init_win_info, tui_del_window)
1238         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1239         (free_content_elements): Remove unnecessary cast.
1240         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1241         unnecessary cast.
1242         * tui/tui-source.c (tui_set_source_content)
1243         (tui_vertical_source_scroll): Remove unnecessary cast.
1244         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1245         cast.
1246         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1247         * tui/tui-regs.c (tui_display_registers_from)
1248         (tui_display_register): Remove unnecessary cast.
1249         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1250         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1251         (make_visible): Remove unnecessary cast.
1252         * tui/tui-winsource.c (tui_erase_source_content)
1253         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1254         unnecessary cast.
1255         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1256         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1257         * stabsread.c (read_type, read_array_type, read_range_type):
1258         Remove unnecessary cast.
1259         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1260         (parse_symbol, parse_type, upgrade_type, parse_external)
1261         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1262         unnecessary cast.
1263         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1264
1265 2019-06-16  Tom Tromey  <tom@tromey.com>
1266
1267         * tui/tui-data.c (tui_alloc_generic_win_info)
1268         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1269         checks.
1270
1271 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1272             Andrew Burgess  <andrew.burgess@embecosm.com>
1273
1274         * f-typeprint.c (f_print_type): Don't return early for not
1275         associated or not allocated types.
1276         (f_type_print_varspec_suffix): Add print_rank parameter and print
1277         ranks of array types in case they dangling.
1278         (f_type_print_base): Add print_rank parameter.
1279
1280 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1281
1282         * NEWS: Mention new MI commands.
1283         * break-catch-throw.c (enum exception_event_kind): Move to
1284         breakpoint.h.
1285         (print_mention_exception_catchpoint): Output text as a single
1286         message.
1287         (catch_exception_command_1): Rename to...
1288         (catch_exception_event): ...this, make non-static, update header
1289         command, and change some parameter types.
1290         (catch_catch_command): Update for changes to
1291         catch_exception_command_1.
1292         (catch_throw_command): Likewise.
1293         (catch_rethrow_command): Likewise.
1294         * breakpoint.c (enum exception_event_kind): Delete.
1295         * breakpoint.h (enum exception_event_kind): Moved here from
1296         break-catch-throw.c.
1297         (catch_exception_event): Declare.
1298         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1299         (mi_cmd_catch_throw): New function.
1300         (mi_cmd_catch_rethrow): New function.
1301         (mi_cmd_catch_catch): New function.
1302         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1303         'catch-catch' entries.
1304         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1305         (mi_cmd_catch_rethrow): Declare.
1306         (mi_cmd_catch_catch): Declare.
1307
1308 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1309
1310         * annotate.c (annotate_source_line): Change return type to void,
1311         update implementation to match.
1312         * annotate.h (annotate_source_line): Change return type to void,
1313         update header comment.
1314         * stack.c (print_frame_info): Don't change what frame information
1315         is printed based on whether annotations are on or not.
1316
1317 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1318
1319         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1320         (annotate_source): Make static.
1321         (annotate_source_line): Moved from source.c and renamed from
1322         identify_source_line.  Update the return type.
1323         * annotate.h (annotate_source): Delete declaration.
1324         (annotate_source_line): Declaration moved from source.h, and
1325         renamed from identify_source_line.  Return type updated.
1326         * source.c (identify_source_line): Moved to annotate.c and renamed
1327         to annotate_source_line.
1328         (info_line_command): Remove check of annotation_level.
1329         * source.h (identify_source_line): Move declaration to annotate.h
1330         and rename to annotate_source_line.
1331         * stack.c: Add 'annotate.h' include.
1332         (print_frame_info): Remove check of annotation_level before
1333         calling annotate_source_line.
1334
1335 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1336
1337         * source-cache.c (source_cache::get_plain_source_lines): Use
1338         open_source_file_with_line_charpos instead of just
1339         open_source_file, remove call to find_source_lines.
1340         (source_cache::get_source_lines): Likewise.
1341         * source.c (find_source_lines): Make static.
1342         (get_filename_and_charpos): Renamed into...
1343         (open_source_file_with_line_charpos): ..this along with changes to
1344         return a scoped_fd, and some other minor clean ups.
1345         (identify_source_line): Use open_source_file_with_line_charpos.
1346         (search_command_helper): Use open_source_file_with_line_charpos
1347         instead of just open_source_file, remove call to
1348         find_source_lines.
1349         * source.h (open_source_file_with_line_charpos): Declare new
1350         function.
1351         (find_source_lines): Delete declaration.
1352
1353 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1354
1355         * source.c (get_filename_and_charpos): Remove fullname
1356         parameter.
1357         (identify_source_line): Update call to get_filename_and_charpos.
1358
1359 2019-06-14  Tom Tromey  <tromey@adacore.com>
1360
1361         PR gdb/24502:
1362         * ui-style.h (skip_ansi_escape): Update comment.
1363         * ui-file.h (class no_terminal_escape_file): New class.
1364         * ui-file.c (no_terminal_escape_file::write)
1365         (no_terminal_escape_file::puts): New methods.
1366         * cli/cli-logging.c (handle_redirections): Use
1367         no_terminal_escape_file.
1368
1369 2019-06-14  Tom Tromey  <tromey@adacore.com>
1370
1371         * NEWS: Move convenience variable news above Python news.
1372
1373 2019-06-14  Tom Tromey  <tom@tromey.com>
1374
1375         * gnulib: Move directory to top-level.
1376         * configure.ac: Don't configure gnulib.
1377         * configure: Rebuild.
1378         * common/common-defs.h: Use new path to gnulib.
1379         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1380         (GNULIB_H): Remove.
1381         (INCGNU): Look in new gnulib location.
1382         (HFILES_NO_SRCDIR): Remove gnulib files.
1383         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1384         (generated_files): Remove GNULIB_H.
1385         ($(LIBGNU), all-lib): Remove targets.
1386         (distclean): Don't mention GNULIB_BUILDDIR.
1387         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1388
1389 2019-06-14  Tom Tromey  <tromey@adacore.com>
1390
1391         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1392         Warn if symbol file does not provide any symbols.
1393
1394 2019-06-14  Tom Tromey  <tromey@adacore.com>
1395
1396         * source.c (find_and_open_source): Respect basenames_may_differ.
1397
1398 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1399
1400         * annotate.c (annotate_breakpoints_invalid): Make use of
1401         scoped_restore_terminal_state.
1402         (annotate_frames_invalid): Likewise.
1403
1404 2019-06-14  Tom Tromey  <tromey@adacore.com>
1405
1406         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1407         allow assignment to an internalvar.
1408
1409 2019-06-14  Tom Tromey  <tromey@adacore.com>
1410
1411         * ada-lex.l: Allow "_" in attribute names.
1412
1413 2019-06-14  Tom Tromey  <tromey@adacore.com>
1414
1415         PR gdb/24653:
1416         * regcache.c (registers_changed): Don't call alloca.
1417         * top.c (execute_command): Don't call alloca.
1418
1419 2019-06-13  Pedro Alves  <palves@redhat.com>
1420
1421         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1422         'expression'.  When parsing an expression, error out if there's
1423         junk after "unlimited".
1424         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1425         (do_set_command): Adjust calls to is_unlimited_literal.
1426
1427 2019-06-13  Pedro Alves  <palves@redhat.com>
1428
1429         * compile/compile.c (make_compile_options_def_group): Add braces
1430         around array_view initializer.
1431         * thread.c (make_thread_apply_all_options_def_group)
1432         (make_thread_apply_all_options_def_group): Likewise.
1433
1434 2019-06-13  Pedro Alves  <palves@redhat.com>
1435
1436         * NEWS (New commands): Mention "maint test-options
1437         require-delimiter", "maint test-options unknown-is-error", "maint
1438         test-options unknown-is-operand" and "maint show
1439         test-options-completion-result".
1440         (New command options, command completion): New section.
1441         (Completion improvements): New section.
1442         Mention that you can abbreviate "unlimited".
1443
1444 2019-06-13  Pedro Alves  <palves@redhat.com>
1445
1446         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1447         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1448         * unittests/cli-utils-selftests.c (test_parse_flags)
1449         (test_parse_flags_qcs): Delete.
1450         (test_cli_utils): Don't call deleted functions.
1451
1452 2019-06-13  Pedro Alves  <palves@redhat.com>
1453
1454         * thread.c: Include "cli/cli-option.h".
1455         (tp_array_compar_ascending): Global.
1456         (tp_array_compar): Delete function.
1457         (tp_array_compar_ascending, tp_array_compar_descending): New
1458         functions.
1459         (ascending_option_def, qcs_flag_option_def)
1460         (thr_qcs_flags_option_defs)
1461         (make_thread_apply_all_options_def_group)
1462         (make_thread_apply_options_def_group): New.
1463         (thread_apply_all_command): Use gdb::option::process_options.
1464         (thread_apply_command_completer)
1465         (thread_apply_all_command_completer): New.
1466         (thread_apply_command): Use gdb::option::process_options.
1467         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1468         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1469         to generate help text of "thread apply".  Adjust "taas"'s help.
1470         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1471         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1472
1473 2019-06-13  Pedro Alves  <palves@redhat.com>
1474
1475         * thread.c (thread_apply_command): Check for invalid TID with
1476         isdigit instead of !isalpha.
1477
1478 2019-06-13  Pedro Alves  <palves@redhat.com>
1479
1480         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1481         (validate_flags_qcs): New.
1482         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1483         (validate_flags_qcs): Declare.
1484         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1485         (make_frame_apply_options_def_group): New.
1486         (frame_apply_command_count): Process options with
1487         gdb::option::process_options.
1488         (frame_apply_completer): New.
1489         (frame_apply_level_completer, frame_apply_all_completer)
1490         (frame_apply_completer): New.
1491         (_initialize_stack): Update help of "frame apply", "frame apply
1492         level", "frame apply all" and "faas" to mention supported options
1493         and install command completers.
1494         * stack.h (frame_apply_all_completer): Declare.
1495         * thread.c: Include "stack.h".
1496         (tfaas_command): Add "--".
1497         (_initialize_thread): Update help "tfaas" to mention supported
1498         options and install command completer.
1499
1500 2019-06-13  Pedro Alves  <palves@redhat.com>
1501
1502         * completer.c (complete_nested_command_line): New.
1503         (gdb_completion_word_break_characters_throw): Add assertion.
1504         * completer.h (complete_nested_command_line): Declare.
1505
1506 2019-06-13  Pedro Alves  <palves@redhat.com>
1507
1508         * stack.c (parse_backtrace_qualifiers): New.
1509         (backtrace_command): Use it.
1510         (backtrace_command_completer): Complete on qualifiers.
1511
1512 2019-06-13  Pedro Alves  <palves@redhat.com>
1513
1514         * frame.c: Include "cli/cli-option.h.
1515         (user_set_backtrace_options): New.
1516         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1517         Delete.
1518         (get_prev_frame): Adjust.
1519         (boolean_option_def, uinteger_option_def)
1520         (set_backtrace_option_defs): New.
1521         (_initialize_frame): Adjust and use
1522         gdb::option::add_setshow_cmds_for_options to install "set
1523         backtrace past-main" and "set backtrace past-entry".
1524         * frame.h: Include "cli/cli-option.h".
1525         (struct frame_print_options): Forward declare.
1526         (print_frame_arguments_all, print_frame_arguments_scalars)
1527         (print_frame_arguments_none): Declare.
1528         (print_entry_values): Delete declaration.
1529         (struct frame_print_options, user_frame_print_options): New.
1530         (struct set_backtrace_options): New.
1531         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1532         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1533         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1534         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1535         (list_args_or_locals): Add frame_print_options parameter.
1536         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1537         * python/py-framefilter.c (enumerate_args): Pass down
1538         USER_FRAME_PRINT_OPTIONS.
1539         * stack.c: Include "cli/cli-option.h".
1540         (print_frame_arguments_all, print_frame_arguments_scalars)
1541         (print_frame_arguments_none): Declare.
1542         (print_raw_frame_arguments, print_entry_values): Delete.
1543         (user_frame_print_options): New.
1544         (boolean_option_def, enum_option_def, frame_print_option_defs):
1545         New.
1546         (struct backtrace_cmd_options): New.
1547         (bt_flag_option_def): New.
1548         (backtrace_command_option_defs): New.
1549         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1550         (print_frame_arg, read_frame_arg, print_frame_args)
1551         (print_frame_info, print_frame): Add frame_print_options parameter
1552         and use it.
1553         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1554         (backtrace_command_1): Add frame_print_options and
1555         backtrace_cmd_options parameters and use them.
1556         (make_backtrace_options_def_group): New.
1557         (backtrace_command): Process command options with
1558         gdb::option::process_options.
1559         (backtrace_command_completer): New.
1560         (_initialize_stack): Extend "backtrace"'s help to mention
1561         supported options.  Install completer for "backtrace".
1562         Install some settings commands with add_setshow_cmds_for_options.
1563
1564 2019-06-13  Pedro Alves  <palves@redhat.com>
1565
1566         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1567         and that "set/show print raw frame-arguments" are now deprecated.
1568
1569         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1570         command.
1571         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1572         * stack.c (_initialize_stack): Install "set/show print
1573         raw-frame-arguments", and deprecate "set/show print raw
1574         frame-arguments".
1575         * valprint.c (_initialize_valprint): Deprecate "set/show print
1576         raw".
1577
1578 2019-06-13  Pedro Alves  <palves@redhat.com>
1579
1580         * compile/compile.c (struct compile_options): New.
1581         (compile_flag_option_def, compile_command_option_defs)
1582         (make_compile_options_def_group): New.
1583         (compile_file_command): Handle options with
1584         gdb::option::process_options.
1585         (compile_file_command_completer): New function.
1586         (compile_code_command): Handle options with
1587         gdb::option::process_options.
1588         (compile_code_command_completer): New function.
1589         (_initialize_compiler): Install completers for "compile code" and
1590         "compile file".  Mention available options in "compile code" and
1591         "compile code"'s help.
1592         * completer.c (advance_to_completion_word): New, factored out from
1593         ...
1594         (advance_to_expression_complete_word_point): ... this.
1595         (advance_to_filename_complete_word_point): New.
1596         * completer.h (advance_to_filename_complete_word_point): New
1597         declaration.
1598
1599 2019-06-13  Pedro Alves  <palves@redhat.com>
1600
1601         * compile/compile.c: Include "cli/cli-option.h".
1602         (compile_print_value): Scope data pointer is now a
1603         value_print_options pointer; adjust.
1604         (compile_print_command): Process options.  Scope data pointer is
1605         now a value_print_options pointer; adjust.
1606         (_initialize_compile): Update "compile print"'s help to include
1607         supported options.  Install a completer for "compile print".
1608         * cp-valprint.c (show_vtblprint, show_objectprint)
1609         (show_static_field_print): Delete.
1610         (_initialize_cp_valprint): Don't install "set print
1611         static-members", "set print vtbl", "set print object" here.
1612         * printcmd.c: Include "cli/cli-option.h" and
1613         "common/gdb_optional.h".
1614         (print_command_parse_format): Rework to fill in a
1615         value_print_options instead of a format_data.
1616         (print_value): Change parameter type from format_data pointer to
1617         value_print_options reference.  Adjust.
1618         (print_command_1): Process options.  Adjust to pass down a
1619         value_print_options.
1620         (print_command_completer): New.
1621         (_initialize_printcmd): Install print_command_completer as
1622         handle_brkchars completer for the "print" command.  Update
1623         "print"'s help to include supported options.
1624         * valprint.c: Include "cli/cli-option.h".
1625         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1626         here from cp-valprint.c.
1627         (boolean_option_def, uinteger_option_def)
1628         (value_print_option_defs, make_value_print_options_def_group):
1629         New.  Use gdb::option::add_setshow_cmds_for_options to install
1630         "set print elements", "set print null-stop", "set print repeats",
1631         "set print pretty", "set print union", "set print array", "set
1632         print address", "set print symbol", "set print array-indexes".
1633         * valprint.h: Include <string> and "cli/cli-option.h".
1634         (make_value_print_options_def_group): Declare.
1635         (print_value): Change parameter type from format_data pointer to
1636         value_print_options reference.
1637         (print_command_completer): Declare.
1638
1639 2019-06-13  Pedro Alves  <palves@redhat.com>
1640
1641         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1642         (COMMON_SFILES): Add maint-test-settings.c.
1643         * cli/cli-decode.c (boolean_enums): New global, factored out from
1644         ...
1645         (add_setshow_boolean_cmd): ... here.
1646         * cli/cli-decode.h (boolean_enums): Declare.
1647         * cli/cli-option.c: New file.
1648         * cli/cli-option.h: New file.
1649         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1650         factored out from ...
1651         (parse_cli_boolean_value(const char *)): ... this.
1652         (is_unlimited_literal): Change parameter type to pointer to
1653         pointer.  Adjust and advance ARG pointer.
1654         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1655         (parse_cli_var_enum): New, factored out from ...
1656         (do_set_command): ... this.  Adjust.
1657         * cli/cli-setshow.h (parse_cli_boolean_value)
1658         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1659         (parse_cli_var_enum): Declare.
1660         * cli/cli-utils.c: Include "cli/cli-option.h".
1661         (get_ulongest): New.
1662         * cli/cli-utils.h (get_ulongest): Declare.
1663         (check_for_argument): New overloads.
1664         * maint-test-options.c: New file.
1665
1666 2019-06-13  Pedro Alves  <palves@redhat.com>
1667
1668         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1669         parse a range if "-" is at the end of the string.
1670
1671 2019-06-13  Pedro Alves  <palves@redhat.com>
1672
1673         * cli/cli-setshow.c (parse_auto_binary_operation)
1674         (parse_cli_boolean_value): Don't allow "o".
1675
1676 2019-06-13  Pedro Alves  <palves@redhat.com>
1677
1678         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1679         * NEWS: Mention maint test-settings KIND.
1680         * maint-test-settings.c: New file.
1681
1682 2019-06-13  Pedro Alves  <palves@redhat.com>
1683
1684         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1685         completer.
1686         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1687         "set" completers.
1688
1689 2019-06-13  Pedro Alves  <palves@redhat.com>
1690
1691         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1692         after item.
1693
1694 2019-06-13  Pedro Alves  <palves@redhat.com>
1695
1696         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1697
1698 2019-06-13  Pedro Alves <palves@redhat.com>
1699
1700         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1701         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1702         call.
1703         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1704         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1705         calls.
1706         (check_for_argument): Skip spaces after argument.
1707
1708 2019-06-13  Pedro Alves  <palves@redhat.com>
1709
1710         * thread.c (thread_apply_command): Adjust TID parsing.
1711         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1712         detected before end of string.
1713         (tid_is_in_list): Error out if LIST is invalid.
1714
1715 2019-06-13  Pedro Alves  <palves@redhat.com>
1716
1717         * completer.c (complete_line_internal_1): Rewind completion word
1718         point.
1719         (completion_tracker::advance_custom_word_point_by): Change
1720         parameter type to int.
1721         * completer.h (completion_tracker::advance_custom_word_point_by):
1722         Likewise.
1723
1724 2019-06-13  Pedro Alves  <palves@redhat.com>
1725
1726         * completer.c (advance_to_completion_word): Handle delimiters.
1727
1728 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1729
1730         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1731
1732 2019-06-11  Tom Tromey  <tom@tromey.com>
1733
1734         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1735         (xmalloc_failed): Move to alloc.c.
1736         * alloc.c: New file.
1737         * Makefile.in (COMMON_SFILES): Add alloc.c.
1738
1739 2019-06-11  Tom Tromey  <tom@tromey.com>
1740
1741         * nat/linux-waitpid.c: Don't include server.h.
1742         (linux_debug): Remove.
1743         (my_waitpid): Update.
1744
1745 2019-06-11  Tom Tromey  <tromey@adacore.com>
1746
1747         * infcall.c (_initialize_infcall): Remove trailing newline from
1748         help.
1749         * user-regs.c (_initialize_user_regs): Remove trailing newline
1750         from help.
1751         * typeprint.c (_initialize_typeprint): Remove trailing newline
1752         from help.
1753         * reverse.c (_initialize_reverse): Remove trailing newlines from
1754         help.
1755         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1756         from help.
1757         * language.c (add_set_language_command): Remove trailing newline
1758         from help.
1759         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1760         help.
1761         * disasm.c (_initialize_disasm): Remove trailing newline from
1762         help.
1763         * top.c (init_main): Remove trailing newline from help.
1764         * interps.c (_initialize_interpreter): Remove trailing newline
1765         from help.
1766         * btrace.c (_initialize_btrace): Remove trailing newlines from
1767         help.
1768         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1769         from help.
1770         * python/python.c (_initialize_python): Remove trailing newline
1771         from help.
1772         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1773         help.
1774         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1775         from help.  Reformat some text.
1776         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1777         from help.
1778         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1779         newline from help.
1780
1781 2019-06-11  Tom Tromey  <tromey@adacore.com>
1782
1783         * darwin-nat.c (darwin_decode_exception_message)
1784         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1785
1786 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1787
1788         * valops.c (value_slice): Check for not allocated or not
1789         associated values.
1790
1791 2019-06-10  Tom de Vries  <tdevries@suse.de>
1792
1793         PR gdb/24618
1794         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1795         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1796         invalid.
1797
1798 2019-06-10  Tom de Vries  <tdevries@suse.de>
1799
1800         PR gdb/24611
1801         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1802         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1803
1804 2019-06-10  Tom de Vries  <tdevries@suse.de>
1805
1806         PR symtab/24545
1807         * symtab.c (struct demangled_name_entry): Add language field.
1808         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1809         static minimal symbol".  Set and use language field.
1810
1811 2019-06-10  Tom Tromey  <tromey@adacore.com>
1812
1813         * ada-lang.c (_initialize_ada_language): Update help text.
1814
1815 2019-06-10  Tom Tromey  <tromey@adacore.com>
1816
1817         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1818         with a newline.
1819         * guile/guile.c (handle_boot_error): Don't end warning with a
1820         newline.
1821         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1822         warning with a newline.
1823         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1824         newline.
1825         (s12z_frame_cache): Likewise.
1826         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1827         a newline.
1828         * solib-svr4.c (disable_probes_interface): Don't end warning with
1829         a newline.
1830         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1831         newline.
1832         * python/python.c (do_finish_initialization): Don't end warning
1833         with a newline.
1834
1835 2019-06-10  Tom Tromey  <tom@tromey.com>
1836
1837         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1838         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1839         gdbpy_enter.
1840
1841 2019-06-10  Tom Tromey  <tromey@adacore.com>
1842
1843         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1844         data.
1845         (elf_new_init): Don't call stabsread_new_init.
1846         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1847         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1848         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1849
1850 2019-06-10  Tom de Vries  <tdevries@suse.de>
1851
1852         PR symtab/16264
1853         PR symtab/24517
1854         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1855
1856 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1857
1858         * source.c (find_and_open_source): Also rewrite relative file
1859         names.
1860
1861 2019-04-26  Amos Bird  <amosbird@gmail.com>
1862
1863         * annotate.c (annotate_thread_exited): Add "thread-exited"
1864         annotation.
1865
1866 2019-06-06  Tom Tromey  <tromey@adacore.com>
1867
1868         * maint.h (class scoped_command_stats): Use
1869         DISABLE_COPY_AND_ASSIGN.
1870         <print_time>: New method.
1871         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1872         print_time.
1873         (scoped_command_stats::print_time): New method.
1874
1875 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1876
1877         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1878         instructions of lengths 6 or 8 bytes.
1879
1880 2019-06-04  Pedro Alves  <palves@redhat.com>
1881
1882         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1883
1884         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1885         * breakpoint.c (condition_completer): Likewise.
1886         * cli/cli-dump.c (scan_expression): Likewise.
1887         * common/filestuff.c (mkdir_recursive): Likewise.
1888         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1889         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1890         (gdb_abspath): Likewise.
1891         * compile/compile-cplus-types.c
1892         (compile_cplus_instance::decl_name): Likewise.
1893         * completer.c (complete_explicit_location):
1894         (signal_completer, reg_or_group_completer_1): Likewise.
1895         * cp-support.c (cp_remove_params_if_any): Likewise.
1896         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1897         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1898         * infcmd.c (strip_bg_char): Likewise.
1899         * linespec.c (copy_token_string): Likewise.
1900         * mi/mi-main.c (output_cores): Likewise.
1901         * psymtab.c (psymtab_search_name):
1902         * symfile.c (test_set_ext_lang_command): Likewise.
1903         * target.c (target_fileio_read_stralloc): Likewise.
1904         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1905         * value.c (complete_internalvar): Likewise.
1906
1907 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1908
1909         Add objfile property to gdb.Type.
1910         * NEWS: Mention Python API addition.
1911         * python/py-type.c (typy_get_objfile): New method.
1912
1913 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1914
1915         * NEWS: Mention the new set|show style [title|highlight].
1916         Mention changes to "show style", "help" and "apropos".
1917
1918 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1919
1920         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1921         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1922         instead of print_help_for_command.
1923         (print_doc_of_command): New function.
1924         (help_list): Add 'apropos -v word' suggestion.
1925         (print_help_for_command): Style the command name using title style.
1926         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1927         (_initialize_cli_cmds): Describe -v in apropos_command help.
1928
1929 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1930
1931         * cli/cli-style.h (cli_style_option): Add name in constructor,
1932         add m_name class member, add constructor with intensity,
1933         add name class function.
1934         (cli_style_option::add_setshow_commands): Remove name argument.
1935         (highlight_style, title_style): New styles.
1936         * cli/cli-style.c (do_show): New function that shows a style
1937         characteristic styling the style name with itself.
1938         (set_style_name): New function.
1939         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1940         Update all callers according to the changes in cli/cli-style.h.
1941         * utils.h (fputs_highlighted): New function.
1942         * utils.c (fputs_highlighted): Likewise.
1943
1944 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1945
1946         * NEWS: Mention new pipe command and new convenience variables.
1947
1948 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1949
1950         * cli/cli-cmds.c (pipe_command): New function.
1951         (_initialize_cli_cmds): Call add_com for pipe_command.
1952         Define | as an alias for pipe.
1953         (exit_status_set_internal_vars): New function.
1954         (shell_escape): Call exit_status_set_internal_vars.
1955         cli/cli-decode.c (find_command_name_length): Recognize | as
1956         a single character command.
1957
1958 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1959
1960         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1961         top.c (execute_command_to_ui_file): New function, mostly a copy
1962         of execute_command_to_string.
1963         (execute_command_to_string): Implement by calling
1964         execute_command_to_ui_file.
1965
1966 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1967
1968         * top.h (saved_command_line): Remove declaration.
1969         * top.c (previous_saved_command_line, previous_repeat_arguments):
1970         New variables.
1971         (saved_command_line): Make static, define together with other
1972         'repeat variables'.
1973         (dont_repeat): Clear repeat_arguments.
1974         (repeat_previous, get_saved_command_line, save_command_line):
1975         New functions.
1976         (gdb_init): Initialize saved_command_line
1977         and previous_saved_command_line.
1978         * main.c (captured_main_1): Remove saved_command_line initialization.
1979         * event-top.c (handle_line_of_input): Update to use
1980         the new 'repeat' related functions instead of direct access to
1981         saved_command_line.
1982         * command.h (repeat_previous, get_saved_command_line,
1983         save_command_line): New declarations.
1984         (dont_repeat): Add comment.
1985
1986 2019-05-30  Tom Tromey  <tromey@adacore.com>
1987
1988         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1989         Fix comment.
1990         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1991
1992 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1993
1994         PR cli/24587
1995         * completer.c (complete): Initialize variable word.
1996
1997 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1998
1999         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2000         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2001         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2002         'body' is NULL to the outter 'if', protecting the '!is_define'
2003         situation as well.
2004
2005 2019-05-29  Tom Tromey  <tromey@adacore.com>
2006
2007         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2008         (dwarf_unknown): New function.
2009         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2010         (dwarf_type_encoding_name): Use dwarf_unknown.
2011
2012 2019-05-29  Tom Tromey  <tromey@adacore.com>
2013
2014         PR c++/20020:
2015         * cp-valprint.c (cp_print_value_fields): Call
2016         cp_print_static_field inside "try".
2017
2018 2019-05-29  Tom Tromey  <tromey@adacore.com>
2019
2020         * inflow.c (struct terminal_info): Add default operator=.
2021         * configure: Rebuild.
2022         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2023         -Wdeprecated-copy-dtor, -Wredundant-move.
2024
2025 2019-05-29  Tom Tromey  <tromey@adacore.com>
2026
2027         * NEWS: Add entry.
2028         * infcmd.c (print_return_value_1): Handle finish_print
2029         option.
2030         (show_print_finish): New function.
2031         (_initialize_infcmd): Add "set/show print finish" commands.
2032         * valprint.c (user_print_options): Initialize new member.
2033         * valprint.h (struct value_print_options) <finish_print>: New
2034         member.
2035
2036 2019-05-28  Tom Tromey  <tromey@adacore.com>
2037
2038         * ada-lang.c (ada_remove_Xbn_suffix)
2039         (find_old_style_renaming_symbol)
2040         (parse_old_style_renaming): Remove.
2041         (ada_find_renaming_symbol): Don't call
2042         find_old_style_renaming_symbol.
2043         (ada_is_renaming_symbol): Rename from
2044         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2045         bool.  Now static.
2046         (ada_read_var_value): Update and simplify.
2047         * ada-exp.y (write_var_or_type): Remove old code.
2048
2049 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2050
2051         * event-top.c: Remove include comment.
2052         * inflow.c (class scoped_ignore_sigttou): Move from here...
2053         * inflow.h (class scoped_ignore_sigttou): ...to here.
2054         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2055         * top.c:  Remove include comment.
2056
2057 2019-05-27  Tom Tromey  <tom@tromey.com>
2058
2059         * NEWS: Fix typo.
2060
2061 2019-05-22  Tom Tromey  <tromey@adacore.com>
2062
2063         * target.c (target_follow_exec): Constify parameter.
2064         * target-delegates.c: Rebuild.
2065         * remote.c (remote_target::follow_exec): Constify parameter.
2066         * infrun.c (follow_exec): Constify parameter.
2067         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2068         (target_follow_exec): Likewise.
2069
2070 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2071
2072         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2073         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2074
2075 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2076
2077         * NEWS: Add debugredirect and testsuite sections.
2078
2079 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2080
2081         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2082         target descriptions using exclusively floating point register name
2083         aliases.
2084
2085 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2086
2087         PR gdb/18644:
2088         * f-lang.c (build_fortran_types): Handle the case where
2089         gdbarch_floatformat_for_type returns a nullptr.
2090
2091 2019-05-21  Tom de Vries  <tdevries@suse.de>
2092
2093         PR cli/24587
2094         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2095
2096 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2097
2098         PR gdb/18644:
2099         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2100         16-byte floats.
2101         * i386-tdep.c (i386_floatformat_for_type): Use
2102         floatformats_ia64_quad for the 16-byte floating point component
2103         within a fortran 32-byte complex number.
2104
2105 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2106
2107         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2108         delete default constructor.
2109         (find_partial_die): Update to return const struct.
2110         (partial_die_parent_scope): Move variable declaration into scope
2111         of its use and change its type to auto.
2112         (guess_partial_die_structure_name): Likewise.
2113         (partial_die_info::fixup): Likewise.
2114
2115 2019-05-17  Tom Tromey  <tromey@adacore.com>
2116
2117         * source.c (find_and_open_source): Remove cast.
2118
2119 2019-05-17  Tom Tromey  <tromey@adacore.com>
2120
2121         * annotate.c (annotate_source): Make "filename" const.
2122         * annotate.h (annotate_source): Use const.
2123
2124 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2125
2126         * disasm.c (set_disassembler_options): Send errors to stderr.
2127
2128 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2129
2130         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2131         (cli_interp_base::set_logging): Check debug_redirect.
2132         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2133         * cli/cli-logging.c (debug_redirect): Add static variable.
2134         (pop_output_files): Add default param.
2135         (handle_redirections): Print debug setting.
2136         (show_logging_command): Likewise.
2137         (_initialize_cli_logging): Add debugredirect command.
2138         * interps.c (current_interp_set_logging): Add debug_redirect
2139         parameter.
2140         * interps.h (set_logging): Add debug_redirect parameter.
2141         (current_interp_set_logging): Likewise.
2142         * mi/mi-common.h: Likewise.
2143         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2144
2145 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2146             Tom Tromey  <tromey@adacore.com>
2147
2148         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2149         directly.
2150         * cli/cli-interp.h (make_logging_output): Remove declaration.
2151         * cli/cli-logging.c (make_logging_output): Remove function.
2152         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2153         directly.
2154         * ui-file.c (tee_file::tee_file): Remove bools.
2155         (tee_file::~tee_file): Remove deletes.
2156         * ui-file.h (tee_file): Remove bools.
2157
2158 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2159
2160         * mi/mi-cmds.h (mi_cmd_complete): New function.
2161         * mi/mi-main.c (mi_cmd_complete): Likewise.
2162         * mi/mi-cmds.c: Define new MI command -complete.
2163         * NEWS: Mention new -complete command.
2164
2165 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2166
2167         * completer.h (complete): New function.
2168         * completer.c (complete): Likewise.
2169         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2170         function defined in completer.h.
2171
2172 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2173
2174         * MAINTAINERS (Write After Approval): Add myself.
2175
2176 2019-05-17  Tom de Vries  <tdevries@suse.de>
2177
2178         PR gdb/24094
2179         * dwarf2read.c (struct cu_partial_die_info): New struct.
2180         (find_partial_die): Return cu_partial_die_info.
2181         (partial_die_parent_scope, guess_partial_die_structure_name)
2182         (partial_die_info::fixup): Handle new return type of find_partial_die.
2183
2184 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2185
2186         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2187         "std::string", simplifying the algorithm.
2188
2189 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2190
2191         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2192         (stap_static_probe_ops::get_probes): Likewise.
2193
2194 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2195
2196         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2197         '-')" and "else if".
2198         (stap_parse_single_operand): Join checks for
2199         "gdbarch_stap_parse_special_token_p" and
2200         "gdbarch_stap_parse_special_token" in the same "if" statement.
2201         Invert check when verifying for operation on register
2202         displacement.
2203
2204 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2205
2206         * stap-probe.c (stap_get_opcode): Update comment.
2207         (stap_get_expected_argument_type): Likewise.
2208         (handle_stap_probe): Likewise.
2209
2210 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2211
2212         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2213         return type to 'bool'.  Adjust comment.  Use 'bool' when
2214         appropriate.
2215         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2216         * stap-probe.c (stap_parse_argument_1): Likewise.
2217         (stap_is_operator): Likewise.
2218         (stap_is_generic_prefix): Likewise.
2219         (stap_is_register_prefix): Likewise.
2220         (stap_is_register_indirection_prefix): Likewise.
2221         (stap_is_integer_prefix): Likewise.
2222         (stap_generic_check_suffix): Likewise.
2223         (stap_check_integer_suffix): Likewise.
2224         (stap_check_register_suffix): Likewise.
2225         (stap_check_register_indirection_suffix): Likewise.
2226         (stap_parse_register_operand): Likewise.
2227         (stap_parse_single_operand): Likewise.
2228         (stap_parse_argument_1): Likewise.
2229         (stap_probe::get_argument_count): Likewise.
2230         (stap_is_operator): Likewise.
2231
2232 2019-05-16  Tom Tromey  <tromey@adacore.com>
2233
2234         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2235         keyword to foreach.
2236
2237 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2238
2239         * linux-thread-db.c (try_thread_db_load_1): Change return type
2240         to bool.
2241         (try_thread_db_load): Likewise.
2242         (try_thread_db_load_from_pdir_1): Likewise.
2243         (try_thread_db_load_from_pdir): Likewise.
2244         (try_thread_db_load_from_sdir): Likewise.
2245         (try_thread_db_load_from_dir): Likewise.
2246         (thread_db_load_search): Likewise.
2247         (has_libpthread): Likewise.
2248         (thread_db_load): Likewise.
2249
2250 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2251
2252         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2253         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2254         NULL, and complain/return if that's the case.
2255
2256 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2257
2258         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2259         (advance, posn, abstract_read_memory): New functions.
2260         [struct mem_read_abstraction]: New struct.
2261         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2262
2263 2019-05-14  Tom Tromey  <tromey@adacore.com>
2264
2265         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2266         value is not lval_memory.
2267
2268 2019-05-14  Tom Tromey  <tromey@adacore.com>
2269
2270         * solib.c (info_sharedlibrary_command): Style the file name.
2271
2272 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2273
2274         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2275         (aarch64_vnv_type): Likewise.
2276         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2277         * common/tdesc.c: Likewise.
2278         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2279         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2280         * features/aarch64-fpu.xml: Add ieee half view.
2281         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2282         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2283         * gdbtypes.h (struct builtin_type): Likewise.
2284         (struct objfile_type): Likewise.
2285
2286 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2287
2288         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2289         typo.
2290         * location.h (string_to_event_location): Likewise.
2291
2292 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2293
2294         GDB 8.3 released.
2295
2296 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2297
2298         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2299         New variable declaration.
2300         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2301         New variable.
2302         (print_one_breakpoint): Use ui_out::test_flags and new global
2303         variable to compute use_fixed_output.
2304         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2305         Remove.
2306         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2307         (mi_multi_location_breakpoint_output_fixed): Remove.
2308         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2309         new variable.
2310         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2311         fix_multi_location_breakpoint_output flag if version >= 3.
2312         * ui-out.h (enum ui_out_flag)
2313         <fix_multi_location_breakpoint_output>: New enumerator.
2314
2315 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2316
2317         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2318
2319 2019-05-10  Tom Tromey  <tromey@adacore.com>
2320
2321         * ada-lang.c (catch_ada_completer): New function.
2322         (_initialize_ada_language): Use it.
2323
2324 2019-05-10  Tom Tromey  <tromey@adacore.com>
2325
2326         * thread.c (print_thread_info): Make "requested_threads" const.
2327         * gdbthread.h (print_thread_info): Make "requested_threads"
2328         const.
2329         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2330         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2331
2332 2019-05-08  Tom Tromey  <tom@tromey.com>
2333
2334         * gdbtypes.c (objfile_type_data): Change type.
2335         (objfile_type, _initialize_gdbtypes): Update.
2336
2337 2019-05-08  Tom Tromey  <tom@tromey.com>
2338
2339         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2340         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2341         (_initialize_dwarf2_frame): Update.
2342
2343 2019-05-08  Tom Tromey  <tom@tromey.com>
2344
2345         * objc-lang.c (objc_objfile_data): Change type.
2346         (find_methods): Update.
2347         (_initialize_objc_lang): Remove.
2348
2349 2019-05-08  Tom Tromey  <tom@tromey.com>
2350
2351         * stabsread.c (rs6000_builtin_type_data): Change type.
2352         (rs6000_builtin_type, _initialize_stabsread): Update.
2353
2354 2019-05-08  Tom Tromey  <tom@tromey.com>
2355
2356         * mips-tdep.c (mips_pdr_data): Remove.
2357         (_initialize_mips_tdep): Update.
2358
2359 2019-05-08  Tom Tromey  <tom@tromey.com>
2360
2361         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2362         (hppa_init_objfile_priv_data, read_unwind_info)
2363         (find_unwind_entry, _initialize_hppa_tdep): Update.
2364
2365 2019-05-08  Tom Tromey  <tom@tromey.com>
2366
2367         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2368         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2369         on obstack.
2370         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2371
2372 2019-05-08  Tom Tromey  <tom@tromey.com>
2373
2374         * mdebugread.c (basic_type_data): Change type.
2375         (basic_type, _initialize_mdebugread): Update.
2376
2377 2019-05-08  Tom Tromey  <tom@tromey.com>
2378
2379         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2380
2381 2019-05-08  Tom Tromey  <tom@tromey.com>
2382
2383         * nto-tdep.c (nto_inferior_data_reg): Change type.
2384         (nto_inferior_data): Update.
2385         (nto_inferior_data_cleanup, nto_new_inferior_data)
2386         (_initialize_nto_tdep): Remove.
2387         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2388
2389 2019-05-08  Tom Tromey  <tom@tromey.com>
2390
2391         * ada-lang.c (struct ada_inferior_data): Add initializers.
2392         (ada_inferior_data): Change type.
2393         (ada_inferior_data_cleanup): Remove.
2394         (get_ada_inferior_data, ada_inferior_exit)
2395         (struct ada_pspace_data): Add initializers, destructor.
2396         (ada_pspace_data_handle): Change type.
2397         (get_ada_pspace_data): Update.
2398         (ada_pspace_data_cleanup): Remove.
2399
2400 2019-05-08  Tom Tromey  <tom@tromey.com>
2401
2402         * coffread.c (struct coff_symfile_info): Add initializers.
2403         (coff_objfile_data_key): Move lower.  Change type.
2404         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2405         Update.
2406         (coff_free_info): Remove.
2407
2408 2019-05-08  Tom Tromey  <tom@tromey.com>
2409
2410         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2411         (fbsd_pspace_data_handle): Move lower.  Change type.
2412         (get_fbsd_pspace_data): Update.
2413         (fbsd_pspace_data_cleanup): Remove.
2414         (_initialize_fbsd_tdep): Update.
2415
2416 2019-05-08  Tom Tromey  <tom@tromey.com>
2417
2418         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2419         (get_ada_tasks_pspace_data): Update.
2420         (ada_tasks_pspace_data_cleanup): Remove.
2421         (_initialize_tasks): Update.
2422         (ada_tasks_inferior_data_handle): Change type.
2423         (get_ada_tasks_inferior_data): Update.
2424         (ada_tasks_inferior_data_cleanup): Remove.
2425         (struct ada_tasks_pspace_data): Add initializers.
2426
2427 2019-05-08  Tom Tromey  <tom@tromey.com>
2428
2429         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2430         * symfile-debug.c (debug_sym_get_probes): Change type.
2431         * stap-probe.c (handle_stap_probe):
2432         (stap_static_probe_ops::get_probes): Change type.
2433         * probe.h (class static_probe_ops) <get_probes>: Change type.
2434         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2435         (parse_probes_in_pspace): Update.
2436         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2437         Update.
2438         (any_static_probe_ops::get_probes): Change type.
2439         * elfread.c (elfread_data): New typedef.
2440         (probe_key): Change type.
2441         (elf_get_probes): Likewise.  Update.
2442         (probe_key_free): Remove.
2443         (_initialize_elfread): Update.
2444         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2445         Change type.
2446         (dtrace_process_dof_probe, dtrace_process_dof)
2447         (dtrace_static_probe_ops::get_probe): Change type.
2448
2449 2019-05-08  Tom Tromey  <tom@tromey.com>
2450
2451         * xcoffread.c (struct xcoff_symfile_info): Rename from
2452         coff_symfile_info.  Add initializers.
2453         (xcoff_objfile_data_key): Move lower.  Change type.
2454         (XCOFF_DATA): Rewrite.
2455         (xcoff_free_info): Remove.
2456         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2457         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2458         (xcoff_initial_scan): Update.
2459
2460 2019-05-08  Tom Tromey  <tom@tromey.com>
2461
2462         * solib-svr4.c (struct svr4_info): Add initializers and
2463         destructor.
2464         <probes_table>: Now an htab_up.
2465         (solib_svr4_pspace_data): Change type.
2466         (free_probes_table): Simplify.
2467         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2468         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2469         (probes_table_remove_objfile_probes, register_solib_event_probe)
2470         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2471         (_initialize_svr4_solib): Update.
2472
2473 2019-05-08  Tom Tromey  <tom@tromey.com>
2474
2475         * remote.c (remote_pspace_data): Change type.
2476         (remote_pspace_data_cleanup): Remove.
2477         (get_remote_exec_file, set_pspace_remote_exec_file)
2478         (_initialize_remote): Update.
2479
2480 2019-05-08  Tom Tromey  <tom@tromey.com>
2481
2482         * breakpoint.c (breakpoint_objfile_key): Change type.
2483         (get_breakpoint_objfile_data): Update.
2484         (free_breakpoint_objfile_data): Remove.
2485         (_initialize_breakpoint): Update.
2486
2487 2019-05-08  Tom Tromey  <tom@tromey.com>
2488
2489         * linux-tdep.c (struct linux_info): Add initializers.
2490         (linux_inferior_data): Move.  Change type.
2491         (invalidate_linux_cache_inf): Update.
2492         (linux_inferior_data_cleanup): Remove.
2493         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2494
2495 2019-05-08  Tom Tromey  <tom@tromey.com>
2496
2497         * auxv.c (auxv_inferior_data): Move.  Change type.
2498         (auxv_inferior_data_cleanup): Remove.
2499         (invalidate_auxv_cache_inf): Rewrite.
2500         (get_auxv_inferior_data, _initialize_auxv): Update.
2501
2502 2019-05-08  Tom Tromey  <tom@tromey.com>
2503
2504         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2505         (symfile_debug_objfile_data_key): Change type.
2506         (symfile_debug_installed, debug_qf_has_symbols)
2507         (debug_qf_find_last_source_symtab)
2508         (debug_qf_forget_cached_source_info)
2509         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2510         (debug_qf_print_stats, debug_qf_dump)
2511         (debug_qf_expand_symtabs_for_function)
2512         (debug_qf_expand_all_symtabs)
2513         (debug_qf_expand_symtabs_with_fullname)
2514         (debug_qf_map_matching_symbols)
2515         (debug_qf_expand_symtabs_matching)
2516         (debug_qf_find_pc_sect_compunit_symtab)
2517         (debug_qf_map_symbol_filenames)
2518         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2519         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2520         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2521         (debug_sym_read_linetable, debug_sym_relocate): Update.
2522         (symfile_debug_free_objfile): Remove.
2523         (install_symfile_debug_logging, _initialize_symfile_debug):
2524         Update.
2525
2526 2019-05-08  Tom Tromey  <tom@tromey.com>
2527
2528         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2529         allocate_on_obstack.
2530         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2531         (get_dwarf2_per_objfile): Update.
2532         (set_dwarf2_per_objfile): Remove.
2533         (dwarf2_has_info, dwarf2_get_section_info): Update.
2534         (dwarf2_free_objfile): Remove.
2535         (_initialize_dwarf2_read): Update.
2536
2537 2019-05-08  Tom Tromey  <tom@tromey.com>
2538
2539         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2540         initializers.
2541         <unsupported_script_warning_printed,
2542         script_not_found_warning_printed>: Now bool.
2543         (auto_load_pspace_data): Change type.
2544         (~auto_load_pspace_info): Rename from
2545         auto_load_pspace_data_cleanup.
2546         (get_auto_load_pspace_data, init_loaded_scripts_info)
2547         (clear_section_scripts, maybe_print_unsupported_script_warning)
2548         (maybe_print_script_not_found_warning, _initialize_auto_load):
2549         Update.
2550
2551 2019-05-08  Tom Tromey  <tom@tromey.com>
2552
2553         * objfiles.c (objfile_pspace_info): Add destructor and
2554         initializers.
2555         (objfiles_pspace_data): Change type.
2556         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2557         (get_objfile_pspace_data): Update.
2558         (objfiles_bfd_data): Change type.
2559         (get_objfile_bfd_data): Update.
2560         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2561
2562 2019-05-08  Tom Tromey  <tom@tromey.com>
2563
2564         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2565         Change type.
2566         (get_catch_syscall_inferior_data): Update.
2567         (catch_syscall_inferior_data_cleanup): Remove.
2568         (_initialize_break_catch_syscall): Update.
2569
2570 2019-05-08  Tom Tromey  <tom@tromey.com>
2571
2572         * inflow.c (struct terminal_info): Add destructor and
2573         initializers.
2574         (inflow_inferior_data): Change type.
2575         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2576         (get_inflow_inferior_data, inflow_inferior_exit)
2577         (swap_terminal_info, _initialize_inflow): Update.
2578
2579 2019-05-08  Tom Tromey  <tom@tromey.com>
2580
2581         * target-dcache.c (target_dcache_cleanup): Remove.
2582         (target_dcache_aspace_key): Change type.
2583         (target_dcache_init_p, target_dcache_invalidate)
2584         (target_dcache_get, target_dcache_get_or_init)
2585         (_initialize_target_dcache): Update.
2586         * dcache.h (struct dcache_deleter): New.
2587
2588 2019-05-08  Tom Tromey  <tom@tromey.com>
2589
2590         * symtab.c (struct symbol_cache): Add destructor and
2591         initializers.
2592         (symbol_cache_key): Move.  Change type.
2593         (make_symbol_cache, free_symbol_cache): Remove.
2594         (get_symbol_cache): Update.
2595         (symbol_cache_cleanup): Remove.
2596         (ALL_PSPACES, symbol_cache_flush)
2597         (maintenance_print_symbol_cache)
2598         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2599         Update.
2600
2601 2019-05-08  Tom Tromey  <tom@tromey.com>
2602
2603         * symtab.c (struct main_info): Add destructor and initializers.
2604         (main_progspace_key): Move.  Change type.
2605         (get_main_info): Update.
2606         (main_info_cleanup): Remove.
2607         (_initialize_symtab): Update.
2608
2609 2019-05-08  Tom Tromey  <tom@tromey.com>
2610
2611         * registry.h (DECLARE_REGISTRY): Define the _key class.
2612
2613 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2614
2615         * NEWS: Merge two 'New commands' sections.
2616
2617 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2618
2619         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2620         parameter and use Ada language definition instead.
2621         (ada_val_print_ptr): Remove unused language parameter.
2622         (ada_val_print_num): Remove language parameter and use Ada language
2623         definition instead.
2624         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2625         parameter.
2626         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2627         parameter and use Ada language definition instead.
2628         (ada_val_print_1): Update all ada_val_print_xxx calls.
2629         Remove language parameter.
2630         (ada_val_print): Update ada_val_print_1 call.
2631
2632 2019-05-08  Tom Tromey  <tromey@adacore.com>
2633
2634         * remote.c (remote_hw_watchpoint_limit)
2635         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2636         Now static.
2637
2638 2019-05-08  Tom Tromey  <tromey@adacore.com>
2639
2640         * maint.c (_initialize_maint_cmds): Move initialization code to
2641         remote.c.
2642         (watchdog, show_watchdog): Move to remote.c.
2643         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2644         "watchdog" static.
2645         (_initialize_remote): Move initialization code from maint.c.
2646         * defs.h (watchdog): Don't declare.
2647
2648 2019-05-08  Tom Tromey  <tromey@adacore.com>
2649
2650         * tui/tui-interp.c: Include main.h.
2651         * interps.c: Include main.h.
2652         * main.h (interpreter_p): Declare.
2653         * defs.h (interpreter_p): Don't declare.
2654
2655 2019-05-08  Tom Tromey  <tromey@adacore.com>
2656
2657         * dwarf2loc.c: Include dwarf2read.h.
2658         * defs.h (read_unsigned_leb128): Don't declare.
2659         * dwarf2read.h (read_unsigned_leb128): Declare.
2660
2661 2019-05-08  Tom Tromey  <tromey@adacore.com>
2662
2663         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2664         method.
2665
2666 2019-05-08  Tom Tromey  <tromey@adacore.com>
2667
2668         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2669         when no wrap column is set.
2670
2671 2019-05-08  Tom Tromey  <tromey@adacore.com>
2672
2673         * c-lang.c (c_get_string): Handle non-C-style arrays.
2674
2675 2019-05-08  Tom Tromey  <tromey@adacore.com>
2676
2677         * typeprint.c (print_offset_data::update): Print the bit offset,
2678         not the number of bits remaining.
2679
2680 2019-05-08  Tom Tromey  <tromey@adacore.com>
2681
2682         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2683         padding at end of comment.
2684
2685 2019-05-08  Tom Tromey  <tromey@adacore.com>
2686
2687         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2688         Compare main types.
2689
2690 2019-05-06  Tom Tromey  <tom@tromey.com>
2691
2692         * common/scoped_mmap.c: Include common-defs.h.
2693         * common/scoped_mmap.h: Don't include config.h.
2694
2695 2019-05-04  Tom Tromey  <tom@tromey.com>
2696
2697         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2698         (struct aarch64_call_info): Add initializers.
2699         <si>: Now a std::vector.
2700         (pass_on_stack, aarch64_push_dummy_call): Update.
2701
2702 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2703             Tom Tromey  <tom@tromey.com>
2704
2705         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2706         (ppc_threads): Now a std::vector.  Now static.
2707         (hwdebug_find_thread_points_by_tid)
2708         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2709         Update.
2710
2711 2019-05-04  Tom Tromey  <tom@tromey.com>
2712
2713         * arc-tdep.c (arc_tdesc_init): Return bool.
2714
2715 2019-05-04  Tom Tromey  <tom@tromey.com>
2716
2717         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2718         Use gdb_assert_not_reached.
2719
2720 2019-05-04  Tom Tromey  <tom@tromey.com>
2721
2722         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2723         "false".
2724
2725 2019-05-04  Tom Tromey  <tom@tromey.com>
2726
2727         * arc-tdep.c (arc_tdesc_init): Use bool.
2728
2729 2019-05-04  Tom Tromey  <tom@tromey.com>
2730
2731         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2732
2733 2019-05-04  Tom Tromey  <tom@tromey.com>
2734
2735         * cli/cli-cmds.c (valid_command_p): Return bool.
2736
2737 2019-05-04  Tom Tromey  <tom@tromey.com>
2738
2739         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2740         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2741
2742 2019-05-04  Raul Tambre  <raul@tambre.ee>
2743
2744         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2745         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2746         operator for comparison.
2747
2748 2019-05-04  Tom Tromey  <tom@tromey.com>
2749
2750         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2751         (lookup_partial_symbol, print_partial_symbols)
2752         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2753         (psymbol_compare): Update.
2754         (add_psymbol_to_bcache): Clear the entire psymbol.
2755         (maintenance_check_psymtabs): Update.
2756         * psympriv.h (struct partial_symbol): Don't derive from
2757         general_symbol_info.
2758         <obj_section, unrelocated_address, address,
2759         set_unrelocated_address>: Update.
2760         <ginfo>: New member.
2761         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2762         (debug_names::write_psymbols): Update.
2763
2764 2019-05-04  Tom de Vries  <tdevries@suse.de>
2765
2766         * contrib/cc-with-tweaks.sh: Support -n arg.
2767
2768 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2769
2770         * corelow.c (core_target::detach): Ensure frame cache and
2771         register caches are cleared.
2772         inferior.c (exit_inferior_1): Likewise.
2773
2774 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2775             Tom Tromey  <tom@tromey.com>
2776
2777         * dictionary.c (collate_pending_symbols_by_language): Remove
2778         "struct" from foreach.
2779         * symtab.c (lookup_global_symbol_from_objfile)
2780         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2781         foreach.
2782         * ser-tcp.c (net_open): Remove "struct" from foreach.
2783         * objfiles.c (objfile_relocate, objfile_rebase)
2784         (objfile_has_symbols): Remove "struct" from foreach.
2785         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2786         from foreach.
2787         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2788         foreach.
2789         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2790         "struct" from foreach.
2791         * ada-lang.c (create_excep_cond_exprs)
2792         (ada_exception_catchpoint_cond_string): Remove "struct" from
2793         foreach.
2794
2795 2019-05-03  Tom Tromey  <tromey@adacore.com>
2796
2797         * ada-exp.y (convert_char_literal): Check suffix of each
2798         enumerator.
2799
2800 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2801
2802         PR ada/21406:
2803         * ada-exp.y (yywrap): Don't define.
2804         * ada-lex.l (%option): Add noyywrap
2805         (yywrap): Remove.
2806
2807 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2808
2809         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2810         _WIN32_WINNT to the XP level, unless already defined to a higher
2811         level.
2812
2813         * unittests/parse-connection-spec-selftests.c:
2814         * ser-tcp.c:
2815         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2816         override.
2817
2818         * symfile.c (find_separate_debug_file): Remove colon from the
2819         drive spec of DOS/Windows file names of the target, so that the
2820         file name produced from DEBUGDIR and the target's directory will
2821         be valid on DOS/Windows systems.
2822
2823 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * rust-lang.c (val_print_struct): Handle printing structures
2826         containing strings.
2827
2828 2019-05-02  Tom Tromey  <tromey@adacore.com>
2829
2830         * valarith.c (_initialize_valarith): Remove.
2831
2832 2019-05-01  Tom Tromey  <tromey@adacore.com>
2833
2834         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2835         bitfields.
2836
2837 2019-05-01  Tom Tromey  <tromey@adacore.com>
2838
2839         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2840         for big-endian copies.
2841
2842 2019-04-30  Ali Tamur  <tamur@google.com>
2843         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2844         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2845         (read_3_bytes): New function.
2846
2847 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2848
2849         * windows-nat.c (main_thread_id): Delete.
2850         (handle_output_debug_string): Replace main_thread_id by
2851         current_event.dwThreadId.
2852         (fake_create_process): Likewise.
2853         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2854         Do not set main_thread_id.
2855         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2856         current_event.dwThreadId.
2857         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2858
2859 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2860
2861         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2862         Use current_event.dwThreadId instead of main_thread_id.
2863
2864 2019-04-30  Tom Tromey  <tromey@adacore.com>
2865
2866         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2867         (create_excep_cond_exprs): Iterate over program spaces.
2868         (ada_exception_catchpoint_cond_string): Examine all minimal
2869         symbols for exception types.
2870
2871 2019-04-30  Tom Tromey  <tromey@adacore.com>
2872
2873         PR c++/24470:
2874         * dwarf2read.c (process_structure_scope): Handle case where type
2875         has template parameters but no symbol was created.
2876
2877 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2878             Chris January  <chris.january@arm.com>
2879
2880         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2881         qualifier.
2882         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2883
2884 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2885
2886         * f-typeprint.c (f_print_type): Update rules for printing
2887         whitespace.
2888         (f_type_print_varspec_suffix): Likewise.
2889
2890 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2891             Chris January  <chris.january@arm.com>
2892
2893         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2894         function arguments.
2895
2896 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2897
2898         * f-lang.c (build_fortran_types): Change name of void type to
2899         lower case.
2900         * f-typeprint.c (f_type_print_base): Print the name of the void
2901         type, rather than a fixed string.
2902         * f-valprint.c (f_decorations): Use lower case void string.
2903
2904 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2905             Chris January  <chris.january@arm.com>
2906
2907         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2908         types for Fortran.
2909
2910 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2911             Chris January  <chris.january@arm.com>
2912             David Lecomber  <david.lecomber@arm.com>
2913
2914         * f-exp.y (BINOP_INTRINSIC): New token.
2915         (exp): New parser rule handling BINOP_INTRINSIC.
2916         (f77_keywords): Add new builtin procedures.
2917         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2918         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2919         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2920         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2921         (print_unop_subexp_f): New function.
2922         (print_binop_subexp_f): New function.
2923         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2924         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2925         (dump_subexp_body_f): Likewise.
2926         (operator_check_f): Likewise.
2927         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2928         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2929
2930 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2931
2932         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2933         UNOP_KIND.
2934         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2935         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2936         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2937         (operator_length_f): New fuction.
2938         (print_subexp_f): New function.
2939         (op_name_f): New function.
2940         (dump_subexp_body_f): New function.
2941         (operator_check_f): New function.
2942         (exp_descriptor_f): Replace standard expression handling functions
2943         with new functions.
2944         * gdb/fortran-operator.def: New file.
2945         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2946         * gdb/std-operator.def: Remove UNOP_KIND.
2947
2948 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2949
2950         * std-operator.def: Remove unbalanced, stray double quote
2951         character.
2952
2953 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2954             Chris January  <chris.january@arm.com>
2955             Daniel Everett  <daniel.everett@arm.com>
2956             Nick Forrington  <nick.forrington@arm.com>
2957             Richard Bunt  <richard.bunt@arm.com>
2958
2959         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2960         of depth when printing anonymous structs or unions.
2961         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2962         Don't print either the top-level value, or the children if the
2963         max-depth is exceeded.
2964         (ppscm_print_children): When printing the key of a map, allow one
2965         extra level of depth.
2966         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2967         print either the top-level value, or the children if the max-depth
2968         is exceeded.
2969         (print_children): When printing the key of a map, allow one extra
2970         level of depth.
2971         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2972         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2973         (user_print_options): Initialise max_depth field.
2974         (val_print_scalar_or_string_type_p): New function.
2975         (val_print): Check to see if the max depth has been reached.
2976         (val_print_check_max_depth): Define new function.
2977         (show_print_max_depth): New function.
2978         (_initialize_valprint): Add 'print max-depth' option.
2979         * valprint.h (struct value_print_options) <max_depth>: New field.
2980         (val_print_check_max_depth): Declare new function.
2981         * NEWS: Document new feature.
2982
2983 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2984
2985         * ada-lang.c (ada_language_defn): Initialise new field.
2986         * c-lang.c (c_is_string_type_p): New function.
2987         (c_language_defn): Initialise new field.
2988         (cplus_language_defn): Initialise new field.
2989         (asm_language_defn): Initialise new field.
2990         (minimal_language_defn): Initialise new field.
2991         * c-lang.h (c_is_string_type_p): Declare new function.
2992         * d-lang.c (d_language_defn): Initialise new field.
2993         * f-lang.c (f_is_string_type_p): New function.
2994         (f_language_defn): Initialise new field.
2995         * go-lang.c (go_is_string_type_p): New function.
2996         (go_language_defn): Initialise new field.
2997         * language.c (default_is_string_type_p): New function.
2998         (unknown_language_defn): Initialise new field.
2999         (auto_language_defn): Initialise new field.
3000         * language.h (struct language_defn) <la_is_string_type_p>: New
3001         member variable.
3002         (default_is_string_type_p): Declare new function.
3003         * m2-lang.c (m2_language_defn): Initialise new field.
3004         * objc-lang.c (objc_language_defn): Initialise new field.
3005         * opencl-lang.c (opencl_language_defn): Initialise new field.
3006         * p-lang.c (pascal_is_string_type_p): New function.
3007         (pascal_language_defn): Initialise new field.
3008         * rust-lang.c (rust_is_string_type_p): New function.
3009         (rust_language_defn): Initialise new field.
3010
3011 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3012
3013         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3014         New field.
3015         * ada-lang.c (ada_language_defn): Initialise new field.
3016         * c-lang.c (c_language_defn): Likewise.
3017         (cplus_language_defn): Likewise.
3018         (asm_language_defn): Likewise.
3019         (minimal_language_defn): Likewise.
3020         * d-lang.c (d_language_defn): Likewise.
3021         * f-lang.c (f_language_defn): Likewise.
3022         * go-lang.c (go_language_defn): Likewise.
3023         * language.c (unknown_language_defn): Likewise.
3024         (auto_language_defn): Likewise.
3025         * m2-lang.c (m2_language_defn): Likewise.
3026         * objc-lang.c (objc_language_defn): Likewise.
3027         * opencl-lang.c (opencl_language_defn): Likewise.
3028         * p-lang.c (pascal_language_defn): Likewise.
3029         * rust-lang.c (rust_language_defn): Likewise.
3030
3031 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3032
3033         * ada-lang.c (ada_is_character_type): Change return type to bool.
3034         (ada_is_string_type): Likewise.
3035         * ada-lang.h (ada_is_character_type): Update declaration
3036         (ada_is_string_type): Likewise.
3037
3038 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3039
3040         Support style in 'frame|thread apply'
3041
3042         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3043         * record.c (record_start, record_stop): Update callers of
3044         execute_command_to_string with false.
3045         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3046         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3047         methods.
3048         (class string_file): New constructor with term_out parameter.
3049         Override methods term_out and can_emit_style_escape.  New member
3050         term_out.
3051         (class stdio_file): Override can_emit_style_escape.
3052         (class tee_file): Override term_out and can_emit_style_escape.
3053         * utils.h (can_emit_style_escape): Remove.
3054         * utils.c (can_emit_style_escape): Likewise.
3055         Update all callers of can_emit_style_escape (SOMESTREAM) to
3056         SOMESTREAM->can_emit_style_escape.
3057         * source-cache.c (source_cache::get_source_lines): Likewise.
3058         * stack.c (frame_apply_command_count): Call execute_command_to_string
3059         passing the term_out characteristic of the current gdb_stdout.
3060         * thread.c (thr_try_catch_cmd): Likewise.
3061         * top.c (execute_command_to_string): pass term_out parameter
3062         to construct the string_file for the command output.
3063         * ui-file.c (term_cli_styling): New function (most code moved
3064         from utils.c can_emit_style_escape).
3065         (string_file::string_file, string_file::can_emit_style_escape,
3066         stdio_file::can_emit_style_escape, tee_file::term_out,
3067         tee_file::can_emit_style_escape): New functions.
3068
3069 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3070
3071         * NEWS: Mention the new set|show may-call-functions.
3072         * infcall.c (may_call_functions_p): New variable.
3073         (show_may_call_functions_p): New function.
3074         (call_function_by_hand_dummy): Throws an error if not
3075         may-call-functions.
3076         (_initialize_infcall): Call add_setshow_boolean_cmd for
3077         may-call-functions.
3078
3079 2019-04-25  Keith Seitz  <keiths@redhat.com>
3080
3081         PR c++/24367
3082         * cp-support.c (inspect_type): Don't attempt substitutions
3083         of symbol with the same name.
3084
3085 2019-04-25  Tom Tromey  <tromey@adacore.com>
3086
3087         PR gdb/24475:
3088         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3089         static.
3090
3091 2019-04-25  Tom Tromey  <tromey@adacore.com>
3092
3093         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3094         rvalue reference.
3095         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3096         (gdb_xml_parser::parse): Use std::move.
3097         * python/python-internal.h (gdbpy_convert_exception): Take a const
3098         reference.
3099         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3100         std::move.
3101         * python/py-utils.c (gdbpy_convert_exception): Take a const
3102         reference.
3103         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3104         Use std::move.
3105         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3106         Use std::move.
3107         * mi/mi-main.c (mi_print_exception): Take a const reference.
3108         * main.c (handle_command_errors): Take a const reference.
3109         * linespec.c (parse_linespec): Use std::move.
3110         * infcall.c (run_inferior_call): Use std::move.
3111         (call_function_by_hand_dummy): Use std::move.
3112         * exec.c (try_open_exec_file): Use std::move.
3113         * exceptions.h (exception_print, exception_fprintf)
3114         (exception_print_same): Update.
3115         * exceptions.c (print_exception, exception_print)
3116         (exception_fprintf, exception_print_same): Change parameters to
3117         const reference.
3118         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3119         * common/new-op.c: Use std::move.
3120         * common/common-exceptions.h (struct gdb_exception): Add move
3121         constructor.
3122         (struct gdb_exception_error, struct gdb_exception_quit, struct
3123         gdb_quit_bad_alloc): Change constructor to move constructor.
3124         (throw_exception): Change parameter to rvalue reference.
3125         * common/common-exceptions.c (throw_exception): Take rvalue
3126         reference.
3127         * cli/cli-interp.c (safe_execute_command): Use std::move.
3128         * breakpoint.c (insert_bp_location, location_to_sals): Use
3129         std::move.
3130
3131 2019-04-25  Tom Tromey  <tromey@adacore.com>
3132
3133         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3134         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3135         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3136         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3137         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3138         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3139         guile/scm-value.c: Use unpack.
3140         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3141         gdbscm_gdb_exception.
3142         (gdbscm_throw_gdb_exception): Likewise.
3143         (struct gdbscm_gdb_exception): New.
3144         (unpack): New function.
3145         (gdbscm_wrap): Use unpack.
3146
3147 2019-04-25  Tom Tromey  <tromey@adacore.com>
3148
3149         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3150         (gdb_rl_callback_handler): Use std::move.
3151         * common/common-exceptions.h (struct gdb_exception): Add move
3152         assignment operator.
3153         (throw_exception_sjlj): Change "exception" to const reference.
3154         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3155         (throw_exception_sjlj): Change "exception" to const reference.
3156
3157 2019-04-25  Tom Tromey  <tromey@adacore.com>
3158
3159         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3160         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3161         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3162         Update.
3163         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3164         Update.
3165         * mi/mi-interp.c (mi_interp::exec): Update.
3166         * linespec.c (parse_linespec): Update.
3167         * infcall.c (run_inferior_call): Update.
3168         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3169         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3170         (gdbscm_lookup_global_symbol): Update.
3171         * guile/scm-param.c (gdbscm_parameter_value): Update.
3172         * guile/scm-frame.c (gdbscm_frame_read_register)
3173         (gdbscm_frame_read_var): Update.
3174         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3175         * exec.c (try_open_exec_file): Update.
3176         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3177         (gdb_rl_callback_handler): Update.
3178         * common/common-exceptions.h (exception_none): Don't declare.
3179         * common/common-exceptions.c (exception_none): Don't define.
3180         (struct catcher) <exception>: Update.
3181         * cli/cli-interp.c (safe_execute_command): Update.
3182         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3183
3184 2019-04-25  Ali Tamur  <tamur@google.com>
3185
3186         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3187         (read_attribute_value): Likewise.
3188         (dwarf2_read_addr_index): Update comment.
3189         (read_str_index): Add DW_FORM_strx.
3190         (dwarf2_string_attr): Likewise.
3191         (dwarf2_const_value_attr): Likewise.
3192         (dump_die_shallow): Likewise.
3193         (dwarf2_fetch_constant_bytes): Likewise.
3194         (skip_form_bytes): Likewise.
3195         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3196
3197 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3198
3199         PR corefiles/11608
3200         PR corefiles/18187
3201         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3202         OFFSET.  Verify if current mapping contains an ELF header.
3203         (linux_find_memory_regions_full): Adjust call to
3204         dump_mapping_p.
3205
3206 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3207             Kang Li <kanglictf@gmail.com>
3208
3209         PR gdb/21600
3210
3211         * dwarf2-frame.c (read_initial_length): Be consistent about using
3212         unsigned representation of length.
3213         (decode_frame_entry_1): Likewise.  Check for wraparound of
3214         end pointer as well as buffer overflow.
3215
3216 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3217
3218         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3219         "vq".
3220
3221 2019-04-24  Tom Tromey  <tromey@adacore.com>
3222
3223         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3224
3225 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * s12z-tdep.c (s12z_unwind_pc): Delete.
3228         (s12z_unwind_sp): Delete.
3229         (s12z_gdbarch_init): Don't register deleted functions with
3230         gdbarch.
3231
3232 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3233
3234         * rl78-tdep.c (rl78_unwind_sp): Delete.
3235         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3236
3237 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3238
3239         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3240         (xstormy16_unwind_pc): Delete.
3241         (xstormy16_dummy_id): Delete.
3242         (xstormy16_gdbarch_init): Don't register deleted functions with
3243         gdbarch.
3244
3245 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3246
3247         * vax-tdep.c (vax_unwind_pc): Delete.
3248         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3249
3250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3251
3252         * v850-tdep.c (v850_unwind_sp): Delete.
3253         (v850_unwind_pc): Delete.
3254         (v850_dummy_id): Delete.
3255         (v850_gdbarch_init): Don't register deleted functions with
3256         gdbarch.
3257
3258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3259
3260         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3261         (tilegx_unwind_pc): Delete.
3262         (tilegx_unwind_dummy_id): Delete.
3263         (tilegx_gdbarch_init): Don't register deleted functions with
3264         gdbarch.
3265
3266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3267
3268         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3269         (tic6x_dummy_id): Delete.
3270         (tic6x_gdbarch_init): Don't register deleted functions with
3271         gdbarch.
3272
3273 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * sparc-tdep.c (sparc_unwind_pc): Delete.
3276         (sparc32_gdbarch_init): Don't register deleted function with
3277         gdbarch.
3278
3279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3280
3281         * sh-tdep.c (sh_unwind_sp): Delete.
3282         (sh_unwind_pc): Delete.
3283         (sh_dummy_id): Delete.
3284         (sh_gdbarch_init): Don't register deleted functions with
3285         gdbarch.
3286
3287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3288
3289         * score-tdep.c (score_unwind_sp): Delete.
3290         (score_unwind_pc): Delete.
3291         (score_dummy_id): Delete.
3292         (score_gdbarch_init): Don't register deleted functions with
3293         gdbarch.
3294
3295 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3296
3297         * rx-tdep.c (rx_unwind_pc): Delete.
3298         (rx_unwind_sp): Delete.
3299         (rx_dummy_id): Delete.
3300         (rx_gdbarch_init): Don't register deleted functions with
3301         gdbarch.  Update comment.
3302
3303 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3304
3305         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3306         (rs6000_dummy_id): Delete.
3307         (rs6000_gdbarch_init): Don't register deleted functions with
3308         gdbarch.
3309
3310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3311
3312         * or1k-tdep.c (or1k_dummy_id): Delete.
3313         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3314
3315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * nios2-tdep.c (nios2_dummy_id): Delete.
3318         (nios2_unwind_sp): Delete.
3319         (nios2_gdbarch_init): Don't register deleted functions with
3320         gdbarch.
3321
3322 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3323
3324         * nds32-tdep.c (nds32_dummy_id): Delete.
3325         (nds32_unwind_pc): Delete.
3326         (nds32_unwind_sp): Delete.
3327         (nds32_gdbarch_init): Don't register deleted functions with
3328         gdbarch.
3329
3330 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3331
3332         * msp430-tdep.c (msp430_unwind_pc): Delete.
3333         (msp430_unwind_sp): Delete.
3334         (msp430_dummy_id): Delete.
3335         (msp430_gdbarch_init): Don't register deleted functions with
3336         gdbarch.
3337
3338 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3339
3340         * moxie-tdep.c (moxie_unwind_sp): Delete.
3341         (moxie_unwind_pc): Delete.
3342         (moxie_dummy_id): Delete.
3343         (moxie_gdbarch_init): Don't register deleted functions with
3344         gdbarch.
3345
3346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3347
3348         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3349         (mn10300_unwind_pc): Delete.
3350         (mn10300_unwind_sp): Delete.
3351         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3352         mn10300_unwind_sp.
3353         (mn10300_frame_unwind_init): Don't register deleted functions with
3354         gdbarch.
3355
3356 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3357
3358         * mep-tdep.c (mep_unwind_pc): Delete.
3359         (mep_unwind_sp): Delete.
3360         (mep_dummy_id): Delete.
3361         (mep_gdbarch_init): Don't register deleted functions with
3362         gdbarch.
3363
3364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3365
3366         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3367         (m68hc11_unwind_sp): Delete.
3368         (m68hc11_gdbarch_init): Don't register deleted functions with
3369         gdbarch.
3370
3371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3372
3373         * m32r-tdep.c (m32r_unwind_sp): Delete.
3374         (m32r_unwind_pc): Delete.
3375         (m32r_dummy_id): Delete.
3376         (m32r_gdbarch_init): Don't register deleted functions with
3377         gdbarch.
3378
3379 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3380
3381         * m32c-tdep.c (m32c_unwind_pc): Delete.
3382         (m32c_unwind_sp): Delete.
3383         (m32c_dummy_id): Delete.
3384         (m32c_gdbarch_init): Don't register deleted functions with
3385         gdbarch.
3386
3387 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3388
3389         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3390         (lm32_unwind_pc): Delete.
3391         (lm32_dummy_id): Delete.
3392         (lm32_gdbarch_init): Don't register deleted functions with
3393         gdbarch.
3394
3395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3396
3397         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3398         (iq2000_unwind_pc): Delete.
3399         (iq2000_dummy_id): Delete.
3400         (iq2000_gdbarch_init): Don't register deleted functions with
3401         gdbarch.
3402
3403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3404
3405         * nds32-tdep.c (nds32_type_align): Delete.
3406         (nds32_push_dummy_call): Use type_align instead.
3407
3408 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3409
3410         * arm-tdep.c (arm_type_align): Only handle vector override case.
3411         (arm_push_dummy_call): Use type_align.
3412         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3413
3414 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3415
3416         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3417         case.
3418         (pass_on_stack): Use type_align.
3419         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3420         function.
3421
3422 2019-04-23  Tom Tromey  <tromey@adacore.com>
3423
3424         * dwarf2read.c (line_header::file_name_at): Remove unused
3425         overload.
3426
3427 2019-04-23  Tom de Vries  <tdevries@suse.de>
3428
3429         PR gdb/24438
3430         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3431         invocation.
3432
3433
3434 2019-03-27  Ali Tamur  <tamur@google.com>
3435
3436         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3437         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3438         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3439         (dwarf_expr_context::get_addr_index): Likewise
3440         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3441         (symbol_needs_eval_context::get_addr_index): Likewise
3442         (disassemble_dwarf_expression): Add DW_OP_addrx
3443         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3444         (read_cutu_die_from_dwo): Update comment
3445         (skip_one_die): Add DW_FORM_addrx
3446         (read_attribute_value): Likewise
3447         (var_decode_location): Add DW_OP_addrx
3448         (dwarf2_const_value_attr): Add DW_FORM_addrx
3449         (dump_die_shallow): Likewise
3450         (dwarf2_fetch_constant_bytes): Likewise
3451         (decode_locdesc): Add DW_OP_addrx
3452         (skip_form_bytes): Add DW_FORM_addrx
3453
3454 2019-04-22  Ali Tamur  <tamur@google.com>
3455
3456         * MAINTAINERS (Write After Approval): Add self.
3457
3458 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3459
3460         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3461         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3462         (open_symbol_file_object): Likewise.
3463         (svr4_default_sos): Add info parameter.
3464         (svr4_read_so_list): Likewise.
3465         (svr4_current_sos_direct): Adjust functions calls to pass down
3466         info.
3467         (svr4_current_sos_1): Add info parameter.
3468         (svr4_current_sos): Call get_svr4_info, pass info down to
3469         svr4_current_sos_1.
3470         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3471         get_svr4_info.
3472         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3473         get_svr4_info.
3474         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3475         to get_svr4_info.
3476         (probes_table_remove_objfile_probes): Likewise.
3477         (register_solib_event_probe): Add info parameter.
3478         (solist_update_incremental): Pass info parameter down to
3479         svr4_read_so_list.
3480         (disable_probes_interface): Add info parameter.
3481         (svr4_handle_solib_event): Pass current_program_space to
3482         get_svr4_info.  Adjust disable_probes_interface cleanup.
3483         (svr4_create_probe_breakpoints): Add info parameter, pass it
3484         down to register_solib_event_probe.
3485         (svr4_create_solib_event_breakpoints): Add info parameter,
3486         pass it down to svr4_create_probe_breakpoints.
3487         (enable_break): Pass info down to
3488         svr4_create_solib_event_breakpoints.
3489         (svr4_solib_create_inferior_hook): Pass current_program_space to
3490         get_svr4_info.
3491         (svr4_clear_solib): Likewise.
3492
3493 2019-04-22  Pedro Alves  <palves@redhat.com>
3494
3495         * solib-svr4.c (svr4_free_objfile_observer): New.
3496         (probe_and_action::objfile): New field.
3497         (probes_table_htab_remove_objfile_probes)
3498         (probes_table_remove_objfile_probes): New functions.
3499         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3500         in the new probe_and_action.  Don't store the probe in 'lookup'.
3501         (svr4_create_probe_breakpoints): Pass objfile to
3502         register_solib_event_probe.
3503         (_initialize_svr4_solib): Register a free_objfile observer.
3504
3505 2019-04-19  Tom Tromey  <tom@tromey.com>
3506
3507         * common/queue.h: Remove.
3508
3509 2019-04-19  Tom Tromey  <tom@tromey.com>
3510
3511         * event-loop.c: Don't include "common/queue.h".
3512
3513 2019-04-19  Tom Tromey  <tom@tromey.com>
3514
3515         * remote.c (remote_target): Use delete.
3516         * remote-notif.h: Include <list>, not "common/queue.h".
3517         (notif_client_p): Remove typedef.
3518         (remote_notif_state): Add constructor, destructor, initializer.
3519         <notif_queue>: Now a std::list.
3520         (remote_notif_state_xfree): Don't declare.
3521         * remote-notif.c (remote_notif_process, handle_notification)
3522         (remote_notif_state_allocate): Update.
3523         (~remote_notif_state): Rename from remote_notif_state_xfree.
3524
3525 2019-04-19  Tom Tromey  <tom@tromey.com>
3526
3527         * symfile.c (reread_symbols): Update.
3528         * objfiles.c (objfile_register_static_link)
3529         (objfile_lookup_static_link): Update
3530         (~objfile) Don't delete static_links.
3531         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3532
3533 2019-04-19  Tom Tromey  <tom@tromey.com>
3534
3535         * type-stack.h (struct type_stack) <insert>: Constify string.
3536         * type-stack.c (type_stack::insert): Constify string.
3537         * gdbtypes.h (lookup_template_type): Update.
3538         (address_space_name_to_int): Update.
3539         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3540         const.
3541         (lookup_template_type): Make name const.
3542         * c-exp.y: Update rules.
3543         (lex_one_token, classify_name, classify_inner_name)
3544         (c_print_token): Update.
3545         * p-exp.y: Update rules.
3546         (yylex): Update.
3547         * f-exp.y: Update rules.
3548         (yylex): Update.
3549         * d-exp.y: Update rules.
3550         (lex_one_token, classify_name, classify_inner_name): Update.
3551         * parse.c (write_dollar_variable, copy_name): Return std::string.
3552         * parser-defs.h (copy_name): Change return type.
3553         * m2-exp.y: Update rules.
3554         (yylex): Update.
3555         * go-exp.y (lex_one_token): Update.
3556         Update rules.
3557         (classify_unsafe_function, classify_packaged_name)
3558         (classify_name, yylex): Update.
3559
3560 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3561
3562         * configure.ac: add --enable-source-highlight switch.
3563         * configure: Regenerate.
3564         * top.c (print_gdb_version): plumb --enable-source-highlight
3565         status to "show configuration".
3566
3567 2019-04-19  Tom Tromey  <tromey@adacore.com>
3568
3569         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3570         Check ADA_TYPE_P.
3571         (empty_record, ada_template_to_fixed_record_type_1)
3572         (template_to_static_fixed_type)
3573         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3574         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3575         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3576         macros.
3577
3578 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3579
3580         PR symtab/24423:
3581         * source.c (print_source_lines_base): Advance "iter" when a
3582         control character is seen.
3583
3584 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3585
3586         * inferior.h (struct infcall_suspend_state_deleter):
3587         Catch exception in destructor to avoid crash.
3588
3589 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3590
3591         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3592         close to the add_com "shell".
3593
3594 2019-04-18  Tom Tromey  <tromey@adacore.com>
3595
3596         * process-stratum-target.h (class process_stratum_target)
3597         <stratum>: Add "final".
3598
3599 2019-04-17  Tom Tromey  <tromey@adacore.com>
3600
3601         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3602         against nullptr before use.
3603
3604 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3605
3606         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3607
3608 2019-04-17  Jim Wilson  <jimw@sifive.com>
3609             Andrew Burgess  <andrew.burgess@embecosm.com>
3610
3611         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3612         code read might fail, assume 4-byte breakpoint in that case.
3613
3614 2019-04-15  Leszek Swirski  <leszeks@google.com>
3615
3616         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3617         rather than a hand-rolled POD check when checking for forced MEMORY
3618         classification.
3619
3620 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3621
3622         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3623         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3624         function.
3625         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3626         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3627         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3628         declaration.
3629
3630 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3631
3632         * aarch64-linux-nat.c
3633         (aarch64_linux_nat_target::thread_architecture): Add override.
3634         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3635         each VQ.
3636
3637 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3638
3639         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3640
3641 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3642
3643         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3644         target types of size 96-bits, add some additional comments, and
3645         check that the builtin type we found was the correct size.
3646
3647 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3648
3649         * utils.c (prompt_for_continue): Don't restore the styling at the
3650         end, as applied_style has the wrong value.  This fixes styling in
3651         long lists of file names that are interrupted by the "Continue?"
3652         prompt.
3653
3654 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3655
3656         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3657         * c-lang.c (c_language_defn): Likewise.
3658         (cplus_language_defn): Likewise.
3659         (asm_language_defn): Likewise.
3660         (minimal_language_defn): Likewise.
3661         * d-lang.c (d_language_defn): Likewise.
3662         * f-lang.c (f_language_defn): Likewise.
3663         * go-lang.c (go_language_defn): Likewise.
3664         * language.c (unknown_language_defn): Likewise.
3665         (auto_language_defn): Likewise.
3666         * language.h (struct language_defn): Remove la_magic field.
3667         (LANG_MAGIC): Delete.
3668         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3669         * objc-lang.c (objc_language_defn): Likewise.
3670         * opencl-lang.c (opencl_language_defn): Likewise.
3671         * p-lang.c (pascal_language_defn): Likewise.
3672         * rust-lang.c (rust_language_defn): Likewise.
3673
3674 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3675
3676         * riscv-tdep.c (riscv_type_align): New function.
3677         (riscv_type_alignment): Delete.
3678         (riscv_arg_location): Use 'type_align'.
3679         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3680
3681 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3682
3683         * gdbtypes.c (type_align): A struct with no non-static fields also
3684         has alignment of 1.
3685
3686 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3687
3688         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3689         component to 0.
3690         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3691         member.
3692         (riscv_struct_info::analyse): New implementation using new
3693         analyse_inner member function.
3694         (riscv_struct_info::field_offset): New member function.
3695         (riscv_struct_info::m_offsets): New member variable.
3696         (riscv_struct_info::analyse_inner): New private member function,
3697         takes the old implementation of riscv_struct_info::analyse but
3698         extended to track field offsets.
3699         (riscv_call_arg_struct): Update the struct folding special cases
3700         to handle cases where empty C++ structs, which are non-zero
3701         length, are found.
3702         (riscv_arg_location): Initialise the length of each location, a
3703         non-zero length now indicates the location is in use.
3704         (riscv_push_dummy_call): Allow for the first location having a
3705         non-zero offset when setting up arguments.
3706         (riscv_return_value): Likewise, but for return values.
3707
3708 2019-04-11  Tom Tromey  <tromey@adacore.com>
3709
3710         * utils.c (internal_vproblem): Make "msg" const.
3711
3712 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3713
3714         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3715         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3716         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3717         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3718
3719 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3720
3721         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3722         function.
3723         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3724         of amd64_collect_native_gregset.
3725         (amd64_linux_nat_target::store_registers): Likewise.
3726
3727 2019-04-10  Tom Tromey  <tom@tromey.com>
3728
3729         * symtab.c (lookup_global_symbol_from_objfile)
3730         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3731         * objfiles.h (class separate_debug_iterator): New.
3732         (class separate_debug_range): New.
3733         (struct objfile) <separate_debug_objfiles>: New method.
3734         (objfile_separate_debug_iterate): Don't declare.
3735         * objfiles.c (separate_debug_iterator::operator++): Rename from
3736         objfile_separate_debug_iterate.
3737         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3738         iterator.
3739         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3740         iterator.
3741
3742 2019-04-10  Tom Tromey  <tom@tromey.com>
3743
3744         * symfile.c (reread_symbols): Remove old comment.
3745         * objfiles.c (free_all_objfiles): Fix a typo.
3746
3747 2019-04-10  Tom Tromey  <tom@tromey.com>
3748
3749         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3750         * minsyms.c (lookup_minimal_symbol): Use foreach.
3751         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3752         (lookup_minimal_symbol_solib_trampoline): Likewise.
3753         * symfile.c (reread_symbols): Use foreach.
3754
3755 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3756             Tom Tromey  <tromey@adacore.com>
3757
3758         PR rust/24414:
3759         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3760         (rust_lex_int_test): Change "value" to be LONGEST.
3761         (rust_lex_tests): Add test for long integer literal.
3762
3763 2019-04-09  Tom Tromey  <tromey@adacore.com>
3764
3765         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3766         to bool.
3767         (extended_remote_target::attach): Update.
3768         (remote_target::remote_notice_new_inferior): Update.
3769         (remote_target::add_current_inferior_and_thread): Update.
3770         * inferior.c (exit_inferior_1): Use "false".
3771         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3772
3773 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3774
3775         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3776         the "start" command.
3777
3778 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3779
3780         * python/py-inferior.c (infpy_thread_from_thread_handle):
3781         Adjust comments to reflect renaming of thread_from_thread_handle
3782         to thread_from_handle.  Adjust keywords.  Fix type error message.
3783         (inferior_object_methods): Add thread_from_handle.  Retain
3784         thread_from_thread_handle, but mark it as deprecated.
3785
3786 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3787
3788         * gdbthread.h (find_thread_by_handle): Revise declaration.
3789         * thread.c (find_thread_by_handle): Likewise.  Adjust
3790         implementation too.
3791         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3792         support for buffer objects as handles.
3793
3794 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3795
3796         * python/py-infthread.c (thpy_thread_handle): New function.
3797         (thread_object_methods): Register thpy_thread_handle.
3798
3799 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3800
3801         * gdbthread.h (thread_to_thread_handle): Declare.
3802         * thread.c (gdbtypes.h): Include.
3803         (thread_to_thread_handle): New function.
3804
3805         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3806         (target_thread_info_to_thread_handle): Declare.
3807         * target.c (target_thread_info_to_thread_handle): New function.
3808         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3809         * target-delegates.c: Regenerate.
3810
3811         * linux-thread-db.c (class thread_db_target): Add method
3812         thread_info_to_thread_handle.
3813         (thread_db_target::thread_info_to_thread_handle): Define.
3814         * remote.c (class remote_target): Add new method
3815         thread_info_to_thread_handle.
3816         (remote_target::thread_info_to_thread_handle): Define.
3817
3818 2019-04-08  Pedro Alves  <palves@redhat.com>
3819
3820         * common/common-exceptions.c (throw_exception): Don't create
3821         named object to throw; throw directly.
3822         (throw_it): Likewise.  Don't initialize gdb_exception::message
3823         here, with new; pass FMT and AP to the ctor instead.
3824         * common/common-exceptions.h: Include <string>.
3825         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3826         const char *, va_list)): New ctor.  Use std::make_shared.
3827         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3828         errors)): Delete.
3829         (gdb_exception_error::gdb_exception_error(enum errors, const char
3830         *, va_list)): New.
3831         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3832         Add assertion.
3833         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3834         errors)): Delete.
3835         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3836         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3837         Add assertion.
3838
3839 2019-04-08  Tom Tromey  <tom@tromey.com>
3840
3841         * valops.c (value_rtti_indirect_type): Replace throw_exception
3842         with throw.
3843         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3844         with throw.
3845         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3846         throw.
3847         * target.c (target_translate_tls_address): Replace throw_exception
3848         with throw.
3849         * stack.c (frame_apply_command_count): Replace throw_exception
3850         with throw.
3851         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3852         throw.
3853         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3854         with throw.
3855         * rs6000-tdep.c (rs6000_frame_cache)
3856         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3857         * remote.c: Replace throw_exception with throw.
3858         * record-full.c (record_full_message, record_full_wait_1)
3859         (record_full_restore): Replace throw_exception with throw.
3860         * record-btrace.c:
3861         (get_thread_current_frame_id, record_btrace_start_replaying)
3862         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3863         (cmd_record_btrace_start): Replace throw_exception with throw.
3864         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3865         throw.
3866         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3867         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3868         * linespec.c:
3869         (find_linespec_symbols): Replace throw_exception with throw.
3870         * infrun.c (displaced_step_prepare, resume): Replace
3871         throw_exception with throw.
3872         * infcmd.c (post_create_inferior): Replace throw_exception with
3873         throw.
3874         * inf-loop.c (inferior_event_handler): Replace throw_exception
3875         with throw.
3876         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3877         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3878         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3879         (get_prev_frame_always, get_frame_pc_if_available)
3880         (get_frame_address_in_block_if_available, get_frame_language):
3881         Replace throw_exception with throw.
3882         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3883         throw_exception with throw.
3884         * eval.c (fetch_subexp_value, evaluate_var_value)
3885         (evaluate_funcall, evaluate_subexp_standard): Replace
3886         throw_exception with throw.
3887         * dwarf2loc.c (call_site_find_chain)
3888         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3889         Replace throw_exception with throw.
3890         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3891         with throw.
3892         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3893         throw.
3894         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3895         * completer.c (complete_line_internal): Replace throw_exception
3896         with throw.
3897         * compile/compile-object-run.c (compile_object_run): Replace
3898         throw_exception with throw.
3899         * cli/cli-script.c (process_next_line): Replace throw_exception
3900         with throw.
3901         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3902         (btrace_enable, btrace_maint_update_pt_packets): Replace
3903         throw_exception with throw.
3904         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3905         throw_exception with throw.
3906         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3907         throw_exception with throw.
3908         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3909         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3910         * aarch64-tdep.c (aarch64_make_prologue_cache)
3911         (aarch64_make_stub_cache): Replace throw_exception with throw.
3912
3913 2019-04-08  Tom Tromey  <tom@tromey.com>
3914
3915         * common/common-exceptions.c (throw_exception): Rename from
3916         throw_exception_cxx.  Remove old copy.  Make argument const.
3917         (throw_it): Create and throw exception objects directly.
3918         * common/common-exceptions.h (throw_exception): Make argument
3919         const.
3920         (struct gdb_exception_error): Add constructor.
3921         (struct gdb_exception_quit): Add constructor.
3922
3923 2019-04-08  Tom Tromey  <tom@tromey.com>
3924
3925         * common/common-exceptions.h (exception_rethrow): Don't declare.
3926         (TRY_SJLJ): Update comment.
3927         (TRY, CATCH, END_CATCH): Remove.
3928         * common/common-exceptions.c (exception_rethrow): Remove.
3929
3930 2019-04-08  Tom Tromey  <tom@tromey.com>
3931
3932         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3933         Remove.
3934         (gdb_exception_error): Rename from
3935         gdb_exception_RETURN_MASK_ERROR.
3936         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3937         (gdb_quit_bad_alloc): Update.
3938         * aarch64-tdep.c: Update.
3939         * ada-lang.c: Update.
3940         * ada-typeprint.c: Update.
3941         * ada-valprint.c: Update.
3942         * amd64-tdep.c: Update.
3943         * arch-utils.c: Update.
3944         * break-catch-throw.c: Update.
3945         * breakpoint.c: Update.
3946         * btrace.c: Update.
3947         * c-varobj.c: Update.
3948         * cli/cli-cmds.c: Update.
3949         * cli/cli-interp.c: Update.
3950         * cli/cli-script.c: Update.
3951         * common/common-exceptions.c: Update.
3952         * common/new-op.c: Update.
3953         * common/selftest.c: Update.
3954         * compile/compile-c-symbols.c: Update.
3955         * compile/compile-cplus-symbols.c: Update.
3956         * compile/compile-object-load.c: Update.
3957         * compile/compile-object-run.c: Update.
3958         * completer.c: Update.
3959         * corelow.c: Update.
3960         * cp-abi.c: Update.
3961         * cp-support.c: Update.
3962         * cp-valprint.c: Update.
3963         * darwin-nat.c: Update.
3964         * disasm-selftests.c: Update.
3965         * dtrace-probe.c: Update.
3966         * dwarf-index-cache.c: Update.
3967         * dwarf-index-write.c: Update.
3968         * dwarf2-frame-tailcall.c: Update.
3969         * dwarf2-frame.c: Update.
3970         * dwarf2loc.c: Update.
3971         * dwarf2read.c: Update.
3972         * eval.c: Update.
3973         * event-loop.c: Update.
3974         * event-top.c: Update.
3975         * exec.c: Update.
3976         * f-valprint.c: Update.
3977         * fbsd-tdep.c: Update.
3978         * frame-unwind.c: Update.
3979         * frame.c: Update.
3980         * gdbtypes.c: Update.
3981         * gnu-v3-abi.c: Update.
3982         * guile/guile-internal.h: Update.
3983         * guile/scm-block.c: Update.
3984         * guile/scm-breakpoint.c: Update.
3985         * guile/scm-cmd.c: Update.
3986         * guile/scm-disasm.c: Update.
3987         * guile/scm-frame.c: Update.
3988         * guile/scm-lazy-string.c: Update.
3989         * guile/scm-math.c: Update.
3990         * guile/scm-param.c: Update.
3991         * guile/scm-ports.c: Update.
3992         * guile/scm-pretty-print.c: Update.
3993         * guile/scm-symbol.c: Update.
3994         * guile/scm-symtab.c: Update.
3995         * guile/scm-type.c: Update.
3996         * guile/scm-value.c: Update.
3997         * i386-linux-tdep.c: Update.
3998         * i386-tdep.c: Update.
3999         * inf-loop.c: Update.
4000         * infcall.c: Update.
4001         * infcmd.c: Update.
4002         * infrun.c: Update.
4003         * jit.c: Update.
4004         * language.c: Update.
4005         * linespec.c: Update.
4006         * linux-fork.c: Update.
4007         * linux-nat.c: Update.
4008         * linux-tdep.c: Update.
4009         * linux-thread-db.c: Update.
4010         * main.c: Update.
4011         * mi/mi-cmd-break.c: Update.
4012         * mi/mi-cmd-stack.c: Update.
4013         * mi/mi-interp.c: Update.
4014         * mi/mi-main.c: Update.
4015         * objc-lang.c: Update.
4016         * p-valprint.c: Update.
4017         * parse.c: Update.
4018         * ppc-linux-tdep.c: Update.
4019         * printcmd.c: Update.
4020         * python/py-arch.c: Update.
4021         * python/py-breakpoint.c: Update.
4022         * python/py-cmd.c: Update.
4023         * python/py-finishbreakpoint.c: Update.
4024         * python/py-frame.c: Update.
4025         * python/py-framefilter.c: Update.
4026         * python/py-gdb-readline.c: Update.
4027         * python/py-inferior.c: Update.
4028         * python/py-infthread.c: Update.
4029         * python/py-lazy-string.c: Update.
4030         * python/py-linetable.c: Update.
4031         * python/py-objfile.c: Update.
4032         * python/py-param.c: Update.
4033         * python/py-prettyprint.c: Update.
4034         * python/py-progspace.c: Update.
4035         * python/py-record-btrace.c: Update.
4036         * python/py-record.c: Update.
4037         * python/py-symbol.c: Update.
4038         * python/py-type.c: Update.
4039         * python/py-unwind.c: Update.
4040         * python/py-utils.c: Update.
4041         * python/py-value.c: Update.
4042         * python/python.c: Update.
4043         * record-btrace.c: Update.
4044         * record-full.c: Update.
4045         * remote-fileio.c: Update.
4046         * remote.c: Update.
4047         * riscv-tdep.c: Update.
4048         * rs6000-aix-tdep.c: Update.
4049         * rs6000-tdep.c: Update.
4050         * rust-exp.y: Update.
4051         * rust-lang.c: Update.
4052         * s390-tdep.c: Update.
4053         * selftest-arch.c: Update.
4054         * solib-dsbt.c: Update.
4055         * solib-frv.c: Update.
4056         * solib-spu.c: Update.
4057         * solib-svr4.c: Update.
4058         * solib.c: Update.
4059         * sparc64-linux-tdep.c: Update.
4060         * stack.c: Update.
4061         * symfile-mem.c: Update.
4062         * symmisc.c: Update.
4063         * target.c: Update.
4064         * thread.c: Update.
4065         * top.c: Update.
4066         * tracefile-tfile.c: Update.
4067         * tui/tui.c: Update.
4068         * typeprint.c: Update.
4069         * unittests/cli-utils-selftests.c: Update.
4070         * unittests/parse-connection-spec-selftests.c: Update.
4071         * valops.c: Update.
4072         * valprint.c: Update.
4073         * value.c: Update.
4074         * varobj.c: Update.
4075         * windows-nat.c: Update.
4076         * x86-linux-nat.c: Update.
4077         * xml-support.c: Update.
4078
4079 2019-04-08  Tom Tromey  <tom@tromey.com>
4080
4081         * xml-support.c: Use C++ exception handling.
4082         * x86-linux-nat.c: Use C++ exception handling.
4083         * windows-nat.c: Use C++ exception handling.
4084         * varobj.c: Use C++ exception handling.
4085         * value.c: Use C++ exception handling.
4086         * valprint.c: Use C++ exception handling.
4087         * valops.c: Use C++ exception handling.
4088         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4089         handling.
4090         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4091         * typeprint.c: Use C++ exception handling.
4092         * tui/tui.c: Use C++ exception handling.
4093         * tracefile-tfile.c: Use C++ exception handling.
4094         * top.c: Use C++ exception handling.
4095         * thread.c: Use C++ exception handling.
4096         * target.c: Use C++ exception handling.
4097         * symmisc.c: Use C++ exception handling.
4098         * symfile-mem.c: Use C++ exception handling.
4099         * stack.c: Use C++ exception handling.
4100         * sparc64-linux-tdep.c: Use C++ exception handling.
4101         * solib.c: Use C++ exception handling.
4102         * solib-svr4.c: Use C++ exception handling.
4103         * solib-spu.c: Use C++ exception handling.
4104         * solib-frv.c: Use C++ exception handling.
4105         * solib-dsbt.c: Use C++ exception handling.
4106         * selftest-arch.c: Use C++ exception handling.
4107         * s390-tdep.c: Use C++ exception handling.
4108         * rust-lang.c: Use C++ exception handling.
4109         * rust-exp.y: Use C++ exception handling.
4110         * rs6000-tdep.c: Use C++ exception handling.
4111         * rs6000-aix-tdep.c: Use C++ exception handling.
4112         * riscv-tdep.c: Use C++ exception handling.
4113         * remote.c: Use C++ exception handling.
4114         * remote-fileio.c: Use C++ exception handling.
4115         * record-full.c: Use C++ exception handling.
4116         * record-btrace.c: Use C++ exception handling.
4117         * python/python.c: Use C++ exception handling.
4118         * python/py-value.c: Use C++ exception handling.
4119         * python/py-utils.c: Use C++ exception handling.
4120         * python/py-unwind.c: Use C++ exception handling.
4121         * python/py-type.c: Use C++ exception handling.
4122         * python/py-symbol.c: Use C++ exception handling.
4123         * python/py-record.c: Use C++ exception handling.
4124         * python/py-record-btrace.c: Use C++ exception handling.
4125         * python/py-progspace.c: Use C++ exception handling.
4126         * python/py-prettyprint.c: Use C++ exception handling.
4127         * python/py-param.c: Use C++ exception handling.
4128         * python/py-objfile.c: Use C++ exception handling.
4129         * python/py-linetable.c: Use C++ exception handling.
4130         * python/py-lazy-string.c: Use C++ exception handling.
4131         * python/py-infthread.c: Use C++ exception handling.
4132         * python/py-inferior.c: Use C++ exception handling.
4133         * python/py-gdb-readline.c: Use C++ exception handling.
4134         * python/py-framefilter.c: Use C++ exception handling.
4135         * python/py-frame.c: Use C++ exception handling.
4136         * python/py-finishbreakpoint.c: Use C++ exception handling.
4137         * python/py-cmd.c: Use C++ exception handling.
4138         * python/py-breakpoint.c: Use C++ exception handling.
4139         * python/py-arch.c: Use C++ exception handling.
4140         * printcmd.c: Use C++ exception handling.
4141         * ppc-linux-tdep.c: Use C++ exception handling.
4142         * parse.c: Use C++ exception handling.
4143         * p-valprint.c: Use C++ exception handling.
4144         * objc-lang.c: Use C++ exception handling.
4145         * mi/mi-main.c: Use C++ exception handling.
4146         * mi/mi-interp.c: Use C++ exception handling.
4147         * mi/mi-cmd-stack.c: Use C++ exception handling.
4148         * mi/mi-cmd-break.c: Use C++ exception handling.
4149         * main.c: Use C++ exception handling.
4150         * linux-thread-db.c: Use C++ exception handling.
4151         * linux-tdep.c: Use C++ exception handling.
4152         * linux-nat.c: Use C++ exception handling.
4153         * linux-fork.c: Use C++ exception handling.
4154         * linespec.c: Use C++ exception handling.
4155         * language.c: Use C++ exception handling.
4156         * jit.c: Use C++ exception handling.
4157         * infrun.c: Use C++ exception handling.
4158         * infcmd.c: Use C++ exception handling.
4159         * infcall.c: Use C++ exception handling.
4160         * inf-loop.c: Use C++ exception handling.
4161         * i386-tdep.c: Use C++ exception handling.
4162         * i386-linux-tdep.c: Use C++ exception handling.
4163         * guile/scm-value.c: Use C++ exception handling.
4164         * guile/scm-type.c: Use C++ exception handling.
4165         * guile/scm-symtab.c: Use C++ exception handling.
4166         * guile/scm-symbol.c: Use C++ exception handling.
4167         * guile/scm-pretty-print.c: Use C++ exception handling.
4168         * guile/scm-ports.c: Use C++ exception handling.
4169         * guile/scm-param.c: Use C++ exception handling.
4170         * guile/scm-math.c: Use C++ exception handling.
4171         * guile/scm-lazy-string.c: Use C++ exception handling.
4172         * guile/scm-frame.c: Use C++ exception handling.
4173         * guile/scm-disasm.c: Use C++ exception handling.
4174         * guile/scm-cmd.c: Use C++ exception handling.
4175         * guile/scm-breakpoint.c: Use C++ exception handling.
4176         * guile/scm-block.c: Use C++ exception handling.
4177         * guile/guile-internal.h: Use C++ exception handling.
4178         * gnu-v3-abi.c: Use C++ exception handling.
4179         * gdbtypes.c: Use C++ exception handling.
4180         * frame.c: Use C++ exception handling.
4181         * frame-unwind.c: Use C++ exception handling.
4182         * fbsd-tdep.c: Use C++ exception handling.
4183         * f-valprint.c: Use C++ exception handling.
4184         * exec.c: Use C++ exception handling.
4185         * event-top.c: Use C++ exception handling.
4186         * event-loop.c: Use C++ exception handling.
4187         * eval.c: Use C++ exception handling.
4188         * dwarf2read.c: Use C++ exception handling.
4189         * dwarf2loc.c: Use C++ exception handling.
4190         * dwarf2-frame.c: Use C++ exception handling.
4191         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4192         * dwarf-index-write.c: Use C++ exception handling.
4193         * dwarf-index-cache.c: Use C++ exception handling.
4194         * dtrace-probe.c: Use C++ exception handling.
4195         * disasm-selftests.c: Use C++ exception handling.
4196         * darwin-nat.c: Use C++ exception handling.
4197         * cp-valprint.c: Use C++ exception handling.
4198         * cp-support.c: Use C++ exception handling.
4199         * cp-abi.c: Use C++ exception handling.
4200         * corelow.c: Use C++ exception handling.
4201         * completer.c: Use C++ exception handling.
4202         * compile/compile-object-run.c: Use C++ exception handling.
4203         * compile/compile-object-load.c: Use C++ exception handling.
4204         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4205         * compile/compile-c-symbols.c: Use C++ exception handling.
4206         * common/selftest.c: Use C++ exception handling.
4207         * common/new-op.c: Use C++ exception handling.
4208         * cli/cli-script.c: Use C++ exception handling.
4209         * cli/cli-interp.c: Use C++ exception handling.
4210         * cli/cli-cmds.c: Use C++ exception handling.
4211         * c-varobj.c: Use C++ exception handling.
4212         * btrace.c: Use C++ exception handling.
4213         * breakpoint.c: Use C++ exception handling.
4214         * break-catch-throw.c: Use C++ exception handling.
4215         * arch-utils.c: Use C++ exception handling.
4216         * amd64-tdep.c: Use C++ exception handling.
4217         * ada-valprint.c: Use C++ exception handling.
4218         * ada-typeprint.c: Use C++ exception handling.
4219         * ada-lang.c: Use C++ exception handling.
4220         * aarch64-tdep.c: Use C++ exception handling.
4221
4222 2019-04-08  Tom Tromey  <tom@tromey.com>
4223
4224         * xml-support.c (gdb_xml_parser::parse): Update.
4225         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4226         * value.c (show_convenience): Update.
4227         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4228         (test_parse_flags_qcs): Update.
4229         * thread.c (thr_try_catch_cmd): Update.
4230         * target.c (target_translate_tls_address): Update.
4231         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4232         (info_frame_command_core, frame_apply_command_count): Update.
4233         * rust-exp.y (rust_lex_exception_test): Update.
4234         * riscv-tdep.c (riscv_print_one_register_info): Update.
4235         * remote.c (remote_target::enable_btrace): Update.
4236         * record-btrace.c (record_btrace_enable_warn): Update.
4237         * python/py-utils.c (gdbpy_convert_exception): Update.
4238         * printcmd.c (do_one_display, print_variable_and_value): Update.
4239         * mi/mi-main.c (mi_print_exception): Update.
4240         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4241         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4242         * linux-nat.c (linux_nat_target::attach): Update.
4243         * linux-fork.c (class scoped_switch_fork_info): Update.
4244         * infrun.c (displaced_step_prepare): Update.
4245         * infcall.c (call_function_by_hand_dummy): Update.
4246         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4247         * gnu-v3-abi.c (print_one_vtable): Update.
4248         * frame.c (get_prev_frame_always): Update.
4249         * f-valprint.c (info_common_command_for_block): Update.
4250         * exec.c (try_open_exec_file): Update.
4251         * exceptions.c (print_exception, exception_print)
4252         (exception_fprintf, exception_print_same): Update.
4253         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4254         * dwarf-index-cache.c (index_cache::store)
4255         (index_cache::lookup_gdb_index): Update.
4256         * darwin-nat.c (maybe_cache_shell): Update.
4257         * cp-valprint.c (cp_print_value_fields): Update.
4258         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4259         (gcc_cplus_symbol_address): Update.
4260         * compile/compile-c-symbols.c (gcc_convert_symbol)
4261         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4262         * common/selftest.c: Update.
4263         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4264         a std::string.
4265         (exception_try_scope_entry, exception_try_scope_exit): Don't
4266         declare.
4267         (struct exception_try_scope): Remove.
4268         (TRY): Don't use exception_try_scope.
4269         (struct gdb_exception): Add constructor, operator=.
4270         <what>: New method.
4271         (struct gdb_exception_RETURN_MASK_ALL)
4272         (struct gdb_exception_RETURN_MASK_ERROR)
4273         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4274         (struct gdb_quit_bad_alloc): Update.
4275         * common/common-exceptions.c (exception_none): Change
4276         initializer.
4277         (struct catcher) <state, exception>: Initialize inline.
4278         <prev>: Remove member.
4279         (current_catcher): Remove.
4280         (catchers): New global.
4281         (exceptions_state_mc_init): Simplify.
4282         (catcher_pop): Remove.
4283         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4284         (try_scope_depth, exception_try_scope_entry)
4285         (exception_try_scope_exit): Remove.
4286         (throw_exception_sjlj): Update.
4287         (exception_messages, exception_messages_size): Remove.
4288         (throw_it): Simplify.
4289         (gdb_exception_sliced_copy): Remove.
4290         (throw_exception_cxx): Update.
4291         * cli/cli-script.c (script_from_file): Update.
4292         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4293         Update.
4294         * ada-valprint.c (ada_val_print): Update.
4295         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4296         (create_excep_cond_exprs): Update.
4297
4298 2019-04-08  Tom Tromey  <tom@tromey.com>
4299
4300         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4301         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4302         (TRY, CATCH, END_CATCH): Remove some definitions.
4303         * common/common-exceptions.c: Don't use GDB_XCPT.
4304         (catcher_list_size): Remove.
4305         (throw_exception, throw_it): Simplify.
4306
4307 2019-04-05  Tom Tromey  <tom@tromey.com>
4308
4309         Revert the header-sorting patch.
4310         * ft32-tdep.c: Revert.
4311         * frv-tdep.c: Revert.
4312         * frv-linux-tdep.c: Revert.
4313         * frame.c: Revert.
4314         * frame-unwind.c: Revert.
4315         * frame-base.c: Revert.
4316         * fork-child.c: Revert.
4317         * findvar.c: Revert.
4318         * findcmd.c: Revert.
4319         * filesystem.c: Revert.
4320         * filename-seen-cache.h: Revert.
4321         * filename-seen-cache.c: Revert.
4322         * fbsd-tdep.c: Revert.
4323         * fbsd-nat.h: Revert.
4324         * fbsd-nat.c: Revert.
4325         * f-valprint.c: Revert.
4326         * f-typeprint.c: Revert.
4327         * f-lang.c: Revert.
4328         * extension.h: Revert.
4329         * extension.c: Revert.
4330         * extension-priv.h: Revert.
4331         * expprint.c: Revert.
4332         * exec.h: Revert.
4333         * exec.c: Revert.
4334         * exceptions.c: Revert.
4335         * event-top.c: Revert.
4336         * event-loop.c: Revert.
4337         * eval.c: Revert.
4338         * elfread.c: Revert.
4339         * dwarf2read.h: Revert.
4340         * dwarf2read.c: Revert.
4341         * dwarf2loc.c: Revert.
4342         * dwarf2expr.h: Revert.
4343         * dwarf2expr.c: Revert.
4344         * dwarf2-frame.c: Revert.
4345         * dwarf2-frame-tailcall.c: Revert.
4346         * dwarf-index-write.h: Revert.
4347         * dwarf-index-write.c: Revert.
4348         * dwarf-index-common.c: Revert.
4349         * dwarf-index-cache.h: Revert.
4350         * dwarf-index-cache.c: Revert.
4351         * dummy-frame.c: Revert.
4352         * dtrace-probe.c: Revert.
4353         * disasm.h: Revert.
4354         * disasm.c: Revert.
4355         * disasm-selftests.c: Revert.
4356         * dictionary.c: Revert.
4357         * dicos-tdep.c: Revert.
4358         * demangle.c: Revert.
4359         * dcache.h: Revert.
4360         * dcache.c: Revert.
4361         * darwin-nat.h: Revert.
4362         * darwin-nat.c: Revert.
4363         * darwin-nat-info.c: Revert.
4364         * d-valprint.c: Revert.
4365         * d-namespace.c: Revert.
4366         * d-lang.c: Revert.
4367         * ctf.c: Revert.
4368         * csky-tdep.c: Revert.
4369         * csky-linux-tdep.c: Revert.
4370         * cris-tdep.c: Revert.
4371         * cris-linux-tdep.c: Revert.
4372         * cp-valprint.c: Revert.
4373         * cp-support.c: Revert.
4374         * cp-namespace.c: Revert.
4375         * cp-abi.c: Revert.
4376         * corelow.c: Revert.
4377         * corefile.c: Revert.
4378         * continuations.c: Revert.
4379         * completer.h: Revert.
4380         * completer.c: Revert.
4381         * complaints.c: Revert.
4382         * coffread.c: Revert.
4383         * coff-pe-read.c: Revert.
4384         * cli-out.h: Revert.
4385         * cli-out.c: Revert.
4386         * charset.c: Revert.
4387         * c-varobj.c: Revert.
4388         * c-valprint.c: Revert.
4389         * c-typeprint.c: Revert.
4390         * c-lang.c: Revert.
4391         * buildsym.c: Revert.
4392         * buildsym-legacy.c: Revert.
4393         * build-id.h: Revert.
4394         * build-id.c: Revert.
4395         * btrace.c: Revert.
4396         * bsd-uthread.c: Revert.
4397         * breakpoint.h: Revert.
4398         * breakpoint.c: Revert.
4399         * break-catch-throw.c: Revert.
4400         * break-catch-syscall.c: Revert.
4401         * break-catch-sig.c: Revert.
4402         * blockframe.c: Revert.
4403         * block.c: Revert.
4404         * bfin-tdep.c: Revert.
4405         * bfin-linux-tdep.c: Revert.
4406         * bfd-target.c: Revert.
4407         * bcache.c: Revert.
4408         * ax-general.c: Revert.
4409         * ax-gdb.h: Revert.
4410         * ax-gdb.c: Revert.
4411         * avr-tdep.c: Revert.
4412         * auxv.c: Revert.
4413         * auto-load.c: Revert.
4414         * arm-wince-tdep.c: Revert.
4415         * arm-tdep.c: Revert.
4416         * arm-symbian-tdep.c: Revert.
4417         * arm-pikeos-tdep.c: Revert.
4418         * arm-obsd-tdep.c: Revert.
4419         * arm-nbsd-tdep.c: Revert.
4420         * arm-nbsd-nat.c: Revert.
4421         * arm-linux-tdep.c: Revert.
4422         * arm-linux-nat.c: Revert.
4423         * arm-fbsd-tdep.c: Revert.
4424         * arm-fbsd-nat.c: Revert.
4425         * arm-bsd-tdep.c: Revert.
4426         * arch-utils.c: Revert.
4427         * arc-tdep.c: Revert.
4428         * arc-newlib-tdep.c: Revert.
4429         * annotate.h: Revert.
4430         * annotate.c: Revert.
4431         * amd64-windows-tdep.c: Revert.
4432         * amd64-windows-nat.c: Revert.
4433         * amd64-tdep.c: Revert.
4434         * amd64-sol2-tdep.c: Revert.
4435         * amd64-obsd-tdep.c: Revert.
4436         * amd64-obsd-nat.c: Revert.
4437         * amd64-nbsd-tdep.c: Revert.
4438         * amd64-nbsd-nat.c: Revert.
4439         * amd64-nat.c: Revert.
4440         * amd64-linux-tdep.c: Revert.
4441         * amd64-linux-nat.c: Revert.
4442         * amd64-fbsd-tdep.c: Revert.
4443         * amd64-fbsd-nat.c: Revert.
4444         * amd64-dicos-tdep.c: Revert.
4445         * amd64-darwin-tdep.c: Revert.
4446         * amd64-bsd-nat.c: Revert.
4447         * alpha-tdep.c: Revert.
4448         * alpha-obsd-tdep.c: Revert.
4449         * alpha-nbsd-tdep.c: Revert.
4450         * alpha-mdebug-tdep.c: Revert.
4451         * alpha-linux-tdep.c: Revert.
4452         * alpha-linux-nat.c: Revert.
4453         * alpha-bsd-tdep.c: Revert.
4454         * alpha-bsd-nat.c: Revert.
4455         * aix-thread.c: Revert.
4456         * agent.c: Revert.
4457         * addrmap.c: Revert.
4458         * ada-varobj.c: Revert.
4459         * ada-valprint.c: Revert.
4460         * ada-typeprint.c: Revert.
4461         * ada-tasks.c: Revert.
4462         * ada-lang.c: Revert.
4463         * aarch64-tdep.c: Revert.
4464         * aarch64-ravenscar-thread.c: Revert.
4465         * aarch64-newlib-tdep.c: Revert.
4466         * aarch64-linux-tdep.c: Revert.
4467         * aarch64-linux-nat.c: Revert.
4468         * aarch64-fbsd-tdep.c: Revert.
4469         * aarch64-fbsd-nat.c: Revert.
4470         * aarch32-linux-nat.c: Revert.
4471
4472 2019-04-05  Tom Tromey  <tom@tromey.com>
4473
4474         * ft32-tdep.c: Sort headers.
4475         * frv-tdep.c: Sort headers.
4476         * frv-linux-tdep.c: Sort headers.
4477         * frame.c: Sort headers.
4478         * frame-unwind.c: Sort headers.
4479         * frame-base.c: Sort headers.
4480         * fork-child.c: Sort headers.
4481         * findvar.c: Sort headers.
4482         * findcmd.c: Sort headers.
4483         * filesystem.c: Sort headers.
4484         * filename-seen-cache.h: Sort headers.
4485         * filename-seen-cache.c: Sort headers.
4486         * fbsd-tdep.c: Sort headers.
4487         * fbsd-nat.h: Sort headers.
4488         * fbsd-nat.c: Sort headers.
4489         * f-valprint.c: Sort headers.
4490         * f-typeprint.c: Sort headers.
4491         * f-lang.c: Sort headers.
4492         * extension.h: Sort headers.
4493         * extension.c: Sort headers.
4494         * extension-priv.h: Sort headers.
4495         * expprint.c: Sort headers.
4496         * exec.h: Sort headers.
4497         * exec.c: Sort headers.
4498         * exceptions.c: Sort headers.
4499         * event-top.c: Sort headers.
4500         * event-loop.c: Sort headers.
4501         * eval.c: Sort headers.
4502         * elfread.c: Sort headers.
4503         * dwarf2read.h: Sort headers.
4504         * dwarf2read.c: Sort headers.
4505         * dwarf2loc.c: Sort headers.
4506         * dwarf2expr.h: Sort headers.
4507         * dwarf2expr.c: Sort headers.
4508         * dwarf2-frame.c: Sort headers.
4509         * dwarf2-frame-tailcall.c: Sort headers.
4510         * dwarf-index-write.h: Sort headers.
4511         * dwarf-index-write.c: Sort headers.
4512         * dwarf-index-common.c: Sort headers.
4513         * dwarf-index-cache.h: Sort headers.
4514         * dwarf-index-cache.c: Sort headers.
4515         * dummy-frame.c: Sort headers.
4516         * dtrace-probe.c: Sort headers.
4517         * disasm.h: Sort headers.
4518         * disasm.c: Sort headers.
4519         * disasm-selftests.c: Sort headers.
4520         * dictionary.c: Sort headers.
4521         * dicos-tdep.c: Sort headers.
4522         * demangle.c: Sort headers.
4523         * dcache.h: Sort headers.
4524         * dcache.c: Sort headers.
4525         * darwin-nat.h: Sort headers.
4526         * darwin-nat.c: Sort headers.
4527         * darwin-nat-info.c: Sort headers.
4528         * d-valprint.c: Sort headers.
4529         * d-namespace.c: Sort headers.
4530         * d-lang.c: Sort headers.
4531         * ctf.c: Sort headers.
4532         * csky-tdep.c: Sort headers.
4533         * csky-linux-tdep.c: Sort headers.
4534         * cris-tdep.c: Sort headers.
4535         * cris-linux-tdep.c: Sort headers.
4536         * cp-valprint.c: Sort headers.
4537         * cp-support.c: Sort headers.
4538         * cp-namespace.c: Sort headers.
4539         * cp-abi.c: Sort headers.
4540         * corelow.c: Sort headers.
4541         * corefile.c: Sort headers.
4542         * continuations.c: Sort headers.
4543         * completer.h: Sort headers.
4544         * completer.c: Sort headers.
4545         * complaints.c: Sort headers.
4546         * coffread.c: Sort headers.
4547         * coff-pe-read.c: Sort headers.
4548         * cli-out.h: Sort headers.
4549         * cli-out.c: Sort headers.
4550         * charset.c: Sort headers.
4551         * c-varobj.c: Sort headers.
4552         * c-valprint.c: Sort headers.
4553         * c-typeprint.c: Sort headers.
4554         * c-lang.c: Sort headers.
4555         * buildsym.c: Sort headers.
4556         * buildsym-legacy.c: Sort headers.
4557         * build-id.h: Sort headers.
4558         * build-id.c: Sort headers.
4559         * btrace.c: Sort headers.
4560         * bsd-uthread.c: Sort headers.
4561         * breakpoint.h: Sort headers.
4562         * breakpoint.c: Sort headers.
4563         * break-catch-throw.c: Sort headers.
4564         * break-catch-syscall.c: Sort headers.
4565         * break-catch-sig.c: Sort headers.
4566         * blockframe.c: Sort headers.
4567         * block.c: Sort headers.
4568         * bfin-tdep.c: Sort headers.
4569         * bfin-linux-tdep.c: Sort headers.
4570         * bfd-target.c: Sort headers.
4571         * bcache.c: Sort headers.
4572         * ax-general.c: Sort headers.
4573         * ax-gdb.h: Sort headers.
4574         * ax-gdb.c: Sort headers.
4575         * avr-tdep.c: Sort headers.
4576         * auxv.c: Sort headers.
4577         * auto-load.c: Sort headers.
4578         * arm-wince-tdep.c: Sort headers.
4579         * arm-tdep.c: Sort headers.
4580         * arm-symbian-tdep.c: Sort headers.
4581         * arm-pikeos-tdep.c: Sort headers.
4582         * arm-obsd-tdep.c: Sort headers.
4583         * arm-nbsd-tdep.c: Sort headers.
4584         * arm-nbsd-nat.c: Sort headers.
4585         * arm-linux-tdep.c: Sort headers.
4586         * arm-linux-nat.c: Sort headers.
4587         * arm-fbsd-tdep.c: Sort headers.
4588         * arm-fbsd-nat.c: Sort headers.
4589         * arm-bsd-tdep.c: Sort headers.
4590         * arch-utils.c: Sort headers.
4591         * arc-tdep.c: Sort headers.
4592         * arc-newlib-tdep.c: Sort headers.
4593         * annotate.h: Sort headers.
4594         * annotate.c: Sort headers.
4595         * amd64-windows-tdep.c: Sort headers.
4596         * amd64-windows-nat.c: Sort headers.
4597         * amd64-tdep.c: Sort headers.
4598         * amd64-sol2-tdep.c: Sort headers.
4599         * amd64-obsd-tdep.c: Sort headers.
4600         * amd64-obsd-nat.c: Sort headers.
4601         * amd64-nbsd-tdep.c: Sort headers.
4602         * amd64-nbsd-nat.c: Sort headers.
4603         * amd64-nat.c: Sort headers.
4604         * amd64-linux-tdep.c: Sort headers.
4605         * amd64-linux-nat.c: Sort headers.
4606         * amd64-fbsd-tdep.c: Sort headers.
4607         * amd64-fbsd-nat.c: Sort headers.
4608         * amd64-dicos-tdep.c: Sort headers.
4609         * amd64-darwin-tdep.c: Sort headers.
4610         * amd64-bsd-nat.c: Sort headers.
4611         * alpha-tdep.c: Sort headers.
4612         * alpha-obsd-tdep.c: Sort headers.
4613         * alpha-nbsd-tdep.c: Sort headers.
4614         * alpha-mdebug-tdep.c: Sort headers.
4615         * alpha-linux-tdep.c: Sort headers.
4616         * alpha-linux-nat.c: Sort headers.
4617         * alpha-bsd-tdep.c: Sort headers.
4618         * alpha-bsd-nat.c: Sort headers.
4619         * aix-thread.c: Sort headers.
4620         * agent.c: Sort headers.
4621         * addrmap.c: Sort headers.
4622         * ada-varobj.c: Sort headers.
4623         * ada-valprint.c: Sort headers.
4624         * ada-typeprint.c: Sort headers.
4625         * ada-tasks.c: Sort headers.
4626         * ada-lang.c: Sort headers.
4627         * aarch64-tdep.c: Sort headers.
4628         * aarch64-ravenscar-thread.c: Sort headers.
4629         * aarch64-newlib-tdep.c: Sort headers.
4630         * aarch64-linux-tdep.c: Sort headers.
4631         * aarch64-linux-nat.c: Sort headers.
4632         * aarch64-fbsd-tdep.c: Sort headers.
4633         * aarch64-fbsd-nat.c: Sort headers.
4634         * aarch32-linux-nat.c: Sort headers.
4635
4636 2019-04-04  Tom Tromey  <tom@tromey.com>
4637
4638         * varobj.c (varobj_create): Update.
4639         * rust-exp.y (struct rust_parser) <update_innermost_block,
4640         lookup_symbol>: New methods.
4641         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4642         Rename.
4643         (rust_parser::rust_lookup_type)
4644         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4645         * printcmd.c (display_command, do_one_display): Update.
4646         * parser-defs.h (struct parser_state) <parser_state>: Add
4647         "tracker" parameter.
4648         (block_tracker): New member.
4649         (class innermost_block_tracker) <innermost_block_tracker>: Add
4650         "types" parameter.
4651         <reset>: Remove method.
4652         (innermost_block): Don't declare.
4653         (null_post_parser): Update.
4654         * parse.c (innermost_block): Remove global.
4655         (write_dollar_variable): Update.
4656         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4657         Remove "tracker_types" parameter.
4658         (parse_expression): Add "tracker" parameter.
4659         (parse_expression_for_completion): Update.
4660         (null_post_parser): Add "tracker" parameter.
4661         * p-exp.y: Update rules.
4662         * m2-exp.y: Update rules.
4663         * language.h (struct language_defn) <la_post_parser>: Add
4664         "tracker" parameter.
4665         * go-exp.y: Update rules.
4666         * f-exp.y: Update rules.
4667         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4668         parameter.
4669         * d-exp.y: Update rules.
4670         * c-exp.y: Update rules.
4671         * breakpoint.c (set_breakpoint_condition): Create an
4672         innermost_block_tracker.
4673         (watch_command_1): Likewise.
4674         * ada-lang.c (resolve): Add "tracker" parameter.
4675         (resolve_subexp): Likewise.
4676         * ada-exp.y (write_var_from_sym): Update.
4677
4678 2019-04-04  Tom Tromey  <tom@tromey.com>
4679
4680         * type-stack.h: New file.
4681         * type-stack.c: New file.
4682         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4683         type-stack.h.
4684         (insert_into_type_stack, insert_type, push_type, push_type_int)
4685         (insert_type_address_space, pop_type, pop_type_int)
4686         (pop_typelist, pop_type_stack, append_type_stack)
4687         (push_type_stack, get_type_stack, push_typelist)
4688         (follow_type_instance_flags, follow_types): Don't declare.
4689         * parse.c (type_stack): Remove global.
4690         (parse_exp_in_context): Update.
4691         (insert_into_type_stack, insert_type, push_type, push_type_int)
4692         (insert_type_address_space, pop_type, pop_type_int)
4693         (pop_typelist, pop_type_stack, append_type_stack)
4694         (push_type_stack, get_type_stack, push_typelist)
4695         (follow_type_instance_flags, follow_types): Remove (moved to
4696         type-stack.c).
4697         * f-exp.y (type_stack): New global.
4698         Update rules.
4699         (push_kind_type, f_parse): Update.
4700         * d-exp.y (type_stack): New global.
4701         Update rules.
4702         (d_parse): Update.
4703         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4704         Update rules.
4705         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4706         (HFILES_NO_SRCDIR): Add type-stack.h.
4707
4708 2019-04-04  Tom Tromey  <tom@tromey.com>
4709
4710         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4711         (rust_parser::convert_ast_to_expression, rust_parse)
4712         (rust_lex_test_completion, rust_lex_tests): Update.
4713         * parser-defs.h (struct expr_completion_state): New.
4714         (struct parser_state) <parser_state>: Add completion parameter.
4715         <mark_struct_expression, mark_completion_tag>: New methods.
4716         <parse_completion, m_completion_state>: New members.
4717         (prefixify_expression, null_post_parser): Update.
4718         (mark_struct_expression, mark_completion_tag): Don't declare.
4719         * parse.c (parse_completion, expout_last_struct)
4720         (expout_tag_completion_type, expout_completion_name): Remove
4721         globals.
4722         (parser_state::mark_struct_expression)
4723         (parser_state::mark_completion_tag): Now methods.
4724         (prefixify_expression): Add last_struct parameter.
4725         (prefixify_subexp): Likewise.
4726         (parse_exp_1): Update.
4727         (parse_exp_in_context): Add cstate parameter.  Update.
4728         (parse_expression_for_completion): Create an
4729         expr_completion_state.
4730         (null_post_parser): Add "completion" parameter.
4731         * p-exp.y: Update rules.
4732         (yylex): Update.
4733         * language.h (struct language_defn) <la_post_parser>: Add
4734         "completing" parameter.
4735         * go-exp.y: Update rules.
4736         (lex_one_token): Update.
4737         * expression.h (parse_completion): Don't declare.
4738         * d-exp.y: Update rules.
4739         (lex_one_token): Update rules.
4740         * c-exp.y: Update rules.
4741         (lex_one_token): Update.
4742         * ada-lang.c (resolve): Add "parse_completion" parameter.
4743         (resolve_subexp): Likewise.
4744         (ada_resolve_function): Likewise.
4745
4746 2019-04-04  Tom Tromey  <tom@tromey.com>
4747
4748         * parser-defs.h (struct parser_state) <start_arglist,
4749         end_arglist>: New methods.
4750         <arglist_len, m_funcall_chain>: New members.
4751         (arglist_len, start_arglist, end_arglist): Don't declare.
4752         * parse.c (arglist_len, funcall_chain): Remove global.
4753         (start_arglist, end_arglist): Remove functions.
4754         (parse_exp_in_context): Update.
4755         * p-exp.y: Update rules.
4756         * m2-exp.y: Update rules.
4757         * go-exp.y: Update rules.
4758         * f-exp.y: Update rules.
4759         * d-exp.y: Update rules.
4760         * c-exp.y: Update rules.
4761
4762 2019-04-04  Tom Tromey  <tom@tromey.com>
4763
4764         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4765         lex_operator, push_back>: New methods.
4766         Update all rules.
4767         (rust_parser::lex_hex, lex_escape): Rename and update.
4768         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4769         (rust_parser::lex_operator): Rename and update.
4770         (rust_parser::lex_number, rustyylex, rustyyerror)
4771         (rust_lex_test_init, rust_lex_test_sequence)
4772         (rust_lex_test_push_back, rust_lex_tests): Update.
4773         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4774         parameter.
4775         <lexptr, prev_lexptr>: New members.
4776         (lexptr, prev_lexptr): Don't declare.
4777         * parse.c (lexptr, prev_lexptr): Remove globals.
4778         (parse_exp_in_context): Update.
4779         * p-exp.y (yylex, yyerror): Update.
4780         * m2-exp.y (parse_number, yylex, yyerror): Update.
4781         * go-exp.y (lex_one_token, yyerror): Update.
4782         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4783         * d-exp.y (lex_one_token, yyerror): Update.
4784         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4785         (lex_one_token, yyerror): Update.
4786         * ada-lex.l (YY_INPUT): Update.
4787         (rewind_to_char): Update.
4788         * ada-exp.y (yyerror): Update.
4789
4790 2019-04-04  Tom Tromey  <tom@tromey.com>
4791
4792         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4793         * parser-defs.h (struct parser_state) <parser_state>: Add new
4794         parameter.
4795         <comma_terminates>: New member.
4796         (comma_terminates): Don't declare global.
4797         * parse.c (comma_terminates): Remove global.
4798         (parse_exp_in_context): Update.
4799         * p-exp.y (yylex): Update.
4800         * m2-exp.y (yylex): Update.
4801         * go-exp.y (lex_one_token): Update.
4802         * f-exp.y (yylex): Update.
4803         * d-exp.y (lex_one_token): Update.
4804         * c-exp.y (lex_one_token): Update.
4805         * ada-lex.l: Update.
4806
4807 2019-04-04  Tom Tromey  <tom@tromey.com>
4808
4809         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4810         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4811         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4812         * parser-defs.h (paren_depth): Don't declare.
4813         * parse.c (paren_depth): Remove global.
4814         (parse_exp_in_context): Update.
4815         * p-exp.y (paren_depth): New global.
4816         (pascal_parse): Initialize it.
4817         * m2-exp.y (paren_depth): New global.
4818         (m2_parse): Initialize it.
4819         * go-exp.y (paren_depth): New global.
4820         (go_parse): Initialize it.
4821         * f-exp.y (paren_depth): New global.
4822         (f_parse): Initialize it.
4823         * d-exp.y (paren_depth): New global.
4824         (d_parse): Initialize it.
4825         * c-exp.y (paren_depth): New global.
4826         (c_parse): Initialize it.
4827         * ada-lex.l (paren_depth): New global.
4828         (lexer_init): Initialize it.
4829
4830 2019-04-04  Tom Tromey  <tom@tromey.com>
4831
4832         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4833         (rust_parser::convert_ast_to_type)
4834         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4835         * parser-defs.h (struct parser_state) <parser_state>: Add
4836         parameters.  Initialize new members.
4837         <expression_context_block, expression_context_pc>: New members.
4838         * parse.c (expression_context_block, expression_context_pc):
4839         Remove globals.
4840         (parse_exp_in_context): Update.
4841         * p-exp.y: Update all rules.
4842         (yylex): Update.
4843         * m2-exp.y: Update all rules.
4844         (yylex): Update.
4845         * go-exp.y (yylex): Update.
4846         * f-exp.y (yylex): Update.
4847         * d-exp.y: Update all rules.
4848         (yylex): Update.
4849         * c-exp.y: Update all rules.
4850         (lex_one_token, classify_name, yylex, c_parse): Update.
4851         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4852
4853 2019-04-04  Tom Tromey  <tom@tromey.com>
4854
4855         * gdbarch.h, gdbarch.c: Rebuild.
4856         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4857         * stap-probe.h:
4858         (struct stap_parse_info): Replace "parser_state" with
4859         "expr_builder".
4860         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4861         (parser_state): New class.
4862         * parse.c (expr_builder): Rename.
4863         (expr_builder::release): Rename.
4864         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4865         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4866         (write_exp_elt_longcst, write_exp_elt_floatcst)
4867         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4868         (write_exp_string_vector, write_exp_bitstring)
4869         (write_exp_msymbol, mark_struct_expression)
4870         (write_dollar_variable)
4871         (insert_type_address_space, increase_expout_size): Replace
4872         "parser_state" with "expr_builder".
4873         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4874         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4875         "parser_state" with "expr_builder".
4876
4877 2019-04-04  Tom Tromey  <tom@tromey.com>
4878
4879         * rust-exp.y: Replace "parse_language" with method call.
4880         * p-exp.y:
4881         (yylex): Replace "parse_language" with method call.
4882         * m2-exp.y:
4883         (yylex): Replace "parse_language" with method call.
4884         * go-exp.y (classify_name): Replace "parse_language" with method
4885         call.
4886         * f-exp.y (yylex): Replace "parse_language" with method call.
4887         * d-exp.y (lex_one_token): Replace "parse_language" with method
4888         call.
4889         * c-exp.y:
4890         (lex_one_token, classify_name, yylex): Replace "parse_language"
4891         with method call.
4892         * ada-exp.y (find_primitive_type, type_char)
4893         (type_system_address): Replace "parse_language" with method call.
4894
4895 2019-04-04  Tom Tromey  <tom@tromey.com>
4896
4897         * rust-exp.y: Replace "parse_gdbarch" with method call.
4898         * parse.c (write_dollar_variable, insert_type_address_space):
4899         Replace "parse_gdbarch" with method call.
4900         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4901         call.
4902         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4903         call.
4904         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4905         "parse_gdbarch" with method call.
4906         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4907         with method call.
4908         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4909         "parse_gdbarch" with method call.
4910         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4911         "parse_gdbarch" with method call.
4912         * c-exp.y (parse_type, parse_number, classify_name): Replace
4913         "parse_gdbarch" with method call.
4914         * ada-lex.l: Replace "parse_gdbarch" with method call.
4915         * ada-exp.y (parse_type, find_primitive_type, type_char)
4916         (type_system_address): Replace "parse_gdbarch" with method call.
4917
4918 2019-04-04  Tom Tromey  <tom@tromey.com>
4919
4920         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4921         * stap-probe.c (stap_parse_argument): Update.
4922         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4923         initial_size parameter.
4924         * rust-exp.y (rust_lex_tests): Update.
4925         * parse.c (parser_state): Update.
4926         (parse_exp_in_context): Update.
4927         * parser-defs.h (struct parser_state) <parser_state>: Remove
4928         "initial_size" parameter.
4929
4930 2019-04-04  Tom Tromey  <tom@tromey.com>
4931
4932         * parser-defs.h (increase_expout_size): Don't declare.
4933         * parse.c (increase_expout_size): Now static.
4934
4935 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4936
4937         * gnu-nat.c (gnu_nat_target::wait): Fix
4938         target_waitstatus_to_string call.
4939
4940 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4941
4942         * eval.c (evaluate_subexp_standard): Handle internal functions
4943         during Fortran function call handling.
4944
4945 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4946
4947         * NEWS: Mention new internal functions.
4948         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4949         (read_base_type): Use dwarf2_init_complex_target_type.
4950         * value.c (creal_internal_fn): New function.
4951         (cimag_internal_fn): New function.
4952         (_initialize_values): Register new internal functions.
4953
4954 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4955
4956         * infrun.c (stop_all_threads): If debug_infrun, always
4957         trace the wait status after wait_one, using
4958         target_waitstatus_to_string and target_pid_to_str.
4959         (handle_inferior_event): Replace various trace of
4960         wait status kind by a single trace.
4961         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4962         wait status kind image by target_waitstatus_to_string.
4963         * target/waitstatus.c (target_waitstatus_to_string): Fix
4964         obsolete comment.
4965
4966 2019-04-01  Tom Tromey  <tromey@adacore.com>
4967
4968         PR symtab/23331:
4969         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4970
4971 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4972             Pedro Alves  <palves@redhat.com>
4973
4974         * top.c (quit_force): Call 'finalize_values'.
4975         * value.c (finalize_values): New function.
4976         * value.h (finalize_values): Declare.
4977
4978 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4979
4980         * NEWS: Announce $_gdb_major and $_gdb_minor.
4981
4982         * top.c (init_gdb_version_vars): New function.
4983         (gdb_init): Call init_gdb_version_vars.
4984
4985 2019-03-29  Tom Tromey  <tromey@adacore.com>
4986
4987         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4988         help text.  Remove dead code.
4989
4990 2019-03-29  Keith Seitz  <keiths@redhat.com>
4991
4992         From Siddhesh Poyarekar:
4993         * f-lang.h (f77_get_upperbound): Return LONGEST.
4994         (f77_get_lowerbound): Likewise.
4995         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4996         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4997         print them.
4998         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4999         plongest to format print it.
5000         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5001         (f77_get_upperbound): Likewise.
5002         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5003         LOWER_BOUND to LONGEST.
5004         (f77_create_arrayprint_offset_tbl): Likewise.
5005
5006 2019-03-29  Keith Seitz  <keiths@redhat.com>
5007
5008         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5009         %s/pulongest for TYPE_LENGTH instead of %d in format
5010         strings.
5011         * ada-typerint.c (ada_print_type): Likewise.
5012         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5013         * compile/compile-c-support.c (generate_register_struct): Likewise.
5014         * gdbtypes.c (recursive_dump_type): Likewise.
5015         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5016         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5017         instead of %d in format strings.
5018         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5019         to std::min to ULONGEST.
5020         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5021         instead of %d in format strings.
5022         * tracepoint.c (info_scope_command): Likewise.
5023         * typeprint.c (print_offset_data::update)
5024         (print_offset_data::finish): Likewise.
5025         * xtensa-tdep.c (xtensa_store_return_value)
5026         (xtensa_push_dummy_call): Likewise.
5027
5028 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5029
5030         * windows-nat.c (display_selector): Fixed format specifications
5031         for 64-bit Cygwin.
5032
5033 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5034
5035         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5036
5037 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5038
5039         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5040         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5041         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5042         (nios2_linux_init_abi): Install it.
5043
5044 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5045
5046         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5047
5048 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5049
5050         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5051
5052 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5053             Tom Tromey  <tromey@adacore.com>
5054
5055         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5056
5057 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5058
5059         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5060         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5061         method to compute the bounds of range types. Also print "[evaluated]"
5062         if the bounds' values come from a dynamic evaluation.
5063
5064 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5065
5066         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5067         whitespace when pretty printing is on.
5068
5069 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5070
5071         * ppc-linux-nat.c: Add include.
5072
5073 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5074
5075         * NEWS: Mention AArch64 Pointer Authentication.
5076
5077 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5078
5079         * arm-linux-nat.c: Add include.
5080
5081 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5082
5083         * source-cache.c (source_cache::get_source_lines): Re-read
5084         fullname after calling open_source_file.
5085
5086 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5087
5088         * NEWS: Mention TLS support for FreeBSD.
5089
5090 2019-03-25  Tom Tromey  <tromey@adacore.com>
5091
5092         * minsyms.c (BUNCH_SIZE): Update comment.
5093         (~minimal_symbol_reader): Remove old comment.
5094         (compact_minimal_symbols): Update comment.
5095         (minimal_symbol_reader::install): Remove old comment.  Update
5096         other comments.
5097
5098 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5099
5100         * s390-linux-nat.c: Add include.
5101
5102 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5103
5104         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5105         Call linux_get_hwcap.
5106         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5107         Likewise.
5108         (aarch64_linux_get_hwcap): Remove function.
5109         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5110         declaration.
5111         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5112         linux_get_hwcap.
5113         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5114         * linux-tdep.c (linux_get_hwcap): Add function.
5115         (linux_get_hwcap2): Likewise.
5116         * linux-tdep.h (linux_get_hwcap): Add declaration.
5117         (linux_get_hwcap2): Likewise.
5118         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5119         (ppc_linux_get_hwcap2): Likewise.
5120         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5121         linux_get_hwcap.
5122         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5123         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5124         (ppc_linux_nat_target::read_description): Likewise.
5125         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5126         * s390-linux-nat.c: Likewise.
5127         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5128
5129 2019-03-24  Tom Tromey  <tom@tromey.com>
5130
5131         * ada-lang.c (standard_lookup): Simplify initialization.
5132         (ada_lookup_symbol_nonlocal): Simplify return.
5133         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5134         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5135         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5136         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5137         initialization.
5138         * solib.c (solib_global_lookup): Simplify.
5139         * symtab.c (null_block_symbol): Remove.
5140         (symbol_cache_lookup): Simplify returns.
5141         (lookup_language_this): Simplify returns.
5142         (lookup_symbol_aux): Simplify return.
5143         (lookup_local_symbol): Simplify returns.
5144         (lookup_global_symbol_from_objfile): Simplify return.
5145         (lookup_symbol_in_objfile_symtabs)
5146         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5147         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5148         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5149         * cp-namespace.c (cp_lookup_bare_symbol)
5150         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5151         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5152         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5153         (cp_lookup_symbol_via_imports): Simplify initialization.
5154         (find_symbol_in_baseclass): Likewise.
5155         * symtab.h (null_block_symbol): Remove.
5156         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5157         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5158         (d_lookup_symbol_module): Likewise.
5159         (find_symbol_in_baseclass): Simplify initialization.
5160
5161 2019-03-24  Tom Tromey  <tom@tromey.com>
5162
5163         * expression.h: Don't include symtab.h.
5164         (struct block): Forward declare.
5165
5166 2019-03-24  Tom Tromey  <tom@tromey.com>
5167
5168         * c-exp.y (typebase): Remove casts.
5169         * gdbtypes.c (lookup_unsigned_typename, )
5170         (lookup_signed_typename): Remove cast.
5171         * eval.c (parse_to_comma_and_eval): Remove cast.
5172         * parse.c (write_dollar_variable): Remove cast.
5173         * block.h (struct block) <superblock>: Now const.
5174         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5175         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5176         (map_block): Make "block" const.
5177         * symfile.h (struct quick_symbol_functions)
5178         <map_matching_symbols>: Constify block argument to "callback".
5179         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5180         const.
5181         (find_pc_sect_compunit_symtab): Make "b" const.
5182         (find_symbol_at_address): Likewise.
5183         (search_symbols): Likewise.
5184         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5185         (dw2_debug_names_lookup_symbol): Likewise.
5186         (dw2_map_matching_symbols): Update.
5187         * p-valprint.c (pascal_val_print): Remove "block".
5188         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5189         (aux_add_nonlocal_symbols): Make "block" const.
5190         (resolve_subexp): Remove cast.
5191         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5192         const.
5193         (iterate_over_file_blocks): Likewise.
5194         * f-exp.y (%union) <bval>: Remove.
5195         * coffread.c (patch_opaque_types): Make "b" const.
5196         * spu-tdep.c (spu_catch_start): Make "block" const.
5197         * c-valprint.c (print_unpacked_pointer): Remove "block".
5198         * symmisc.c (dump_symtab_1): Make "b" const.
5199         (block_depth): Make "block" const.
5200         * d-exp.y (%union) <bval>: Remove.
5201         * cp-support.h (cp_lookup_rtti_type): Update.
5202         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5203         * psymtab.c (psym_lookup_symbol): Make "block" const.
5204         (maintenance_check_psymtabs): Make "b" const.
5205         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5206         (enumerate_locals, enumerate_args): Update.
5207         * python/py-symtab.c (stpy_global_block): Make "block" const.
5208         (stpy_static_block): Likewise.
5209         * inline-frame.c (block_starting_point_at): Make "new_block"
5210         const.
5211         * block.c (find_block_in_blockvector): Make return type const.
5212         (blockvector_for_pc_sect): Make "b" const.
5213         (find_block_in_blockvector): Make "b" const.
5214
5215 2019-03-23  Tom Tromey  <tom@tromey.com>
5216
5217         * varobj.c (varobj_create): Update.
5218         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5219         * printcmd.c (display_command, do_one_display): Don't reset
5220         innermost_block.
5221         * parser-defs.h (enum innermost_block_tracker_type): Move to
5222         expression.h.
5223         (innermost_block): Update comment.
5224         * parse.c (parse_exp_1): Add tracker_types parameter.
5225         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5226         tracker_types parameter.  Reset innermost_block.
5227         (parse_exp_in_context): Remove.
5228         (parse_expression_for_completion): Update.
5229         * objfiles.c (~objfile): Don't reset expression_context_block or
5230         innermost_block.
5231         * expression.h (enum innermost_block_tracker_type): Move from
5232         parser-defs.h.
5233         (parse_exp_1): Add tracker_types parameter.
5234         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5235         reset innermost_block.
5236
5237 2019-03-23  Tom Tromey  <tom@tromey.com>
5238
5239         * objfiles.h: Include bcache.h.
5240
5241 2019-03-23  Tom Tromey  <tom@tromey.com>
5242
5243         * linespec.c (get_current_search_block): Use
5244         scoped_restore_current_language.
5245         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5246
5247 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5248             Jiong Wang  <jiong.wang@arm.com>
5249
5250         * aarch64-linux-tdep.c
5251         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5252         section.
5253         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5254
5255 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5256             Jiong Wang  <jiong.wang@arm.com>
5257
5258         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5259         instructions.
5260         (aarch64_analyze_prologue_test): Add PACIASP test.
5261         (aarch64_prologue_prev_register): Unmask PC value.
5262
5263 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5264             Jiong Wang  <jiong.wang@arm.com>
5265
5266         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5267         (aarch64_dwarf2_prev_register): Unmask PC value.
5268         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5269         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5270         DW_CFA_AARCH64_negate_ra_state.
5271         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5272
5273 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5274             Jiong Wang  <jiong.wang@arm.com>
5275
5276         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5277         registers.
5278         (aarch64_pseudo_register_name): Likewise.
5279         (aarch64_pseudo_register_type): Likewise.
5280         (aarch64_pseudo_register_reggroup_p): Likewise.
5281         (aarch64_gdbarch_init): Add pauth registers.
5282         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5283         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5284         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5285         (struct gdbarch_tdep): Add regnum for ra_state.
5286
5287 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5288             Jiong Wang  <jiong.wang@arm.com>
5289
5290         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5291
5292 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5293             Jiong Wang  <jiong.wang@arm.com>
5294
5295         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5296         function.
5297         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5298         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5299         (aarch64_gdbarch_init): Add puth registers.
5300         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5301         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5302         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5303
5304 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5305             Jiong Wang  <jiong.wang@arm.com>
5306
5307         * aarch64-linux-nat.c
5308         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5309         * aarch64-linux-tdep.c
5310         (aarch64_linux_core_read_description): Likewise.
5311         (aarch64_linux_get_hwcap): New function.
5312         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5313         (aarch64_linux_get_hwcap): New declaration.
5314
5315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5316             Jiong Wang  <jiong.wang@arm.com>
5317
5318         * aarch64-linux-nat.c
5319         (aarch64_linux_nat_target::read_description): Add pauth param.
5320         * aarch64-linux-tdep.c
5321         (aarch64_linux_core_read_description): Likewise.
5322         * aarch64-tdep.c (struct target_desc): Add in pauth.
5323         (aarch64_read_description): Add pauth param.
5324         (aarch64_gdbarch_init): Likewise.
5325         * aarch64-tdep.h (aarch64_read_description): Likewise.
5326         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5327         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5328         * features/Makefile: Add new files.
5329         * features/aarch64-pauth.c: New file.
5330         * features/aarch64-pauth.xml: New file.
5331
5332 2019-03-20  Tom Tromey  <tromey@adacore.com>
5333
5334         * infrun.c (handle_inferior_event): Rename from
5335         handle_inferior_event_1.  Create a scoped_value_mark.
5336         (handle_inferior_event): Remove.
5337
5338 2019-03-19  Tom Tromey  <tromey@adacore.com>
5339
5340         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5341         * infrun.h (print_stop_event): Add "displays" parameter.
5342         * infrun.c (print_stop_event): Add "displays" parameter.
5343
5344 2019-03-19  Pedro Alves  <palves@redhat.com>
5345
5346         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5347         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5348         to -1.  Fix TABs vs spaces.
5349         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5350         * tui/tui-out.h (tui_ui_out) Add intro comments.
5351         <m_line, m_start_of_line>: In-class initialize, and add describing
5352         comment.
5353
5354 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5355
5356         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5357         variable names.
5358         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5359
5360 2019-03-18  Pedro Alves  <palves@redhat.com>
5361             Eli Zaretskii <eliz@gnu.org>
5362
5363         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5364         m_line and m_start_of_line.
5365
5366 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5367
5368         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5369         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5370         it returns a newline.  This fixes a regression in TU mode, whereby
5371         the next line is output on the same screen line as the user input.
5372
5373 2019-03-18  Tom Tromey  <tromey@adacore.com>
5374
5375         * minsyms.c (minimal_symbol_reader::install): Remove call to
5376         obstack_blank.
5377
5378 2019-03-18  Pedro Alves  <palves@redhat.com>
5379
5380         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5381         New globals.
5382         (apply_style): New, factored out from ...
5383         (apply_ansi_escape): ... this.  Handle reverse video mode.
5384         (tui_set_reverse_mode): New function.
5385         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5386         * tui/tui-winsource.c (tui_show_source_line): Use
5387         tui_set_reverse_mode instead of setting A_STANDOUT.
5388         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5389         New setter methods.
5390
5391 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5392
5393         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5394         Handle tabs.
5395
5396 2019-03-18  Tom Tromey  <tromey@adacore.com>
5397
5398         * ada-lang.c (empty_array): Add "high" parameter.
5399         (ada_evaluate_subexp): Update.
5400
5401 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5402
5403         * unittests/string_view-selftests.c: Define
5404         _initialize_string_view_selftests unconditionally.
5405
5406 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5407
5408         PR gdb/24350
5409         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5410
5411 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5412
5413         PR gdb/24351
5414         * windows-nat.c (display_selector): Fix format specifiers.
5415
5416 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5417
5418         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5419         tui_refill_source_window instead of tui_refresh_win, to update the
5420         current execution line.  This fixes redisplay of the current line
5421         when stepping through the code with "next" or "step".
5422
5423 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5424
5425         * source-cache.c (source_cache::get_source_lines): Call
5426         find_source_lines to initialize s->nlines.  This fixes vertical
5427         scrolling of TUI source window when the DOWN arrow is pressed.
5428
5429 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5430
5431         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5432         linux-thread-db.c (_initialize_thread_db): Likewise.
5433
5434 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5435
5436         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5437         wclrtoeol in tui_show_source_line".  This reverts changes made in
5438         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5439
5440 2019-03-15  Tom Tromey  <tom@tromey.com>
5441
5442         * symtab.h (struct minimal_symbol): Derive from
5443         general_symbol_info.
5444         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5445         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5446         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5447         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5448         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5449         (MSYMBOL_SEARCH_NAME): Update.
5450         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5451         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5452         * minsyms.c (minimal_symbol_reader::record_full): Update.
5453
5454 2019-03-15  Tom Tromey  <tom@tromey.com>
5455
5456         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5457
5458 2019-03-15  Tom Tromey  <tom@tromey.com>
5459
5460         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5461         unique_xmalloc_ptr.
5462         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5463         Update.
5464         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5465         (build_minimal_symbol_hash_tables)
5466         (minimal_symbol_reader::install): Update.
5467
5468 2019-03-15  Tom Tromey  <tom@tromey.com>
5469
5470         * symtab.c (create_demangled_names_hash): Update.
5471         (symbol_set_names): Update.
5472         * objfiles.h (struct objfile_per_bfd_storage)
5473         <demangled_names_hash>: Now an htab_up.
5474         * objfiles.c (objfile_per_bfd_storage): Simplify.
5475
5476 2019-03-15  Tom Tromey  <tom@tromey.com>
5477
5478         * objfiles.h (struct objfile_per_bfd_storage): Declare
5479         destructor.
5480         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5481         New.
5482         (get_objfile_bfd_data): Use new.  Don't initialize
5483         language_of_main.
5484         (free_objfile_per_bfd_storage): Remove.
5485         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5486
5487 2019-03-15  Tom Tromey  <tom@tromey.com>
5488
5489         * symfile.c (reread_symbols): Update.
5490         * objfiles.c (objfile::objfile): Update.
5491         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5492         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5493         comment.
5494         (minimal_symbol_reader::install): Update.
5495         (terminate_minimal_symbol_table): Remove.
5496         * jit.c (jit_object_close_impl): Update.
5497
5498 2019-03-15  Tom Tromey  <tom@tromey.com>
5499
5500         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5501         initializations.
5502
5503 2019-03-15  Tom Tromey  <tom@tromey.com>
5504
5505         * objfiles.h (struct objfile_per_bfd_storage)
5506         <demangled_hash_languages>: Now a bitset.
5507         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5508         (lookup_minimal_symbol): Update.
5509
5510 2019-03-15  Tom Tromey  <tom@tromey.com>
5511
5512         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5513         Don't return the symbol.
5514         * coffread.c (record_minimal_symbol): Use record_full.
5515
5516 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5517
5518         The MS-Windows port of ncurses fails to switch to a color pair if
5519         one or both of the colors are the implicit default colors.  This
5520         change records the default colors when TUI is initialized, and
5521         then specifies them explicitly when a color pair uses the default
5522         colors.  This allows color styling in TUI mode on MS-Windows.
5523
5524         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5525         ncurses_norm_attr.
5526         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5527         colors in ncurses_norm_attr.
5528         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5529         "none", replace it with the default color recorded in
5530         ncurses_norm_attr.
5531
5532 2019-03-14  Tom Tromey  <tromey@adacore.com>
5533
5534         * source-cache.h (class source_cache) <get_source_lines>: Return
5535         std::string.
5536         * source-cache.c (source_cache::extract_lines): Handle case where
5537         first_pos==npos.  Return std::string.
5538         (source_cache::get_source_lines): Update.
5539
5540 2019-03-14  Tom Tromey  <tromey@adacore.com>
5541
5542         * NEWS: Add item for "style sources" commands.
5543         * source-cache.c (source_cache::get_source_lines): Check
5544         source_styling.
5545         * cli/cli-style.c (source_styling): New global.
5546         (_initialize_cli_style): Add "style sources" commands.
5547         (show_style_sources): New function.
5548         * cli/cli-style.h (source_styling): Declare.
5549
5550 2019-03-14  Pedro Alves  <palves@redhat.com>
5551             Tom Tromey  <tromey@adacore.com>
5552
5553         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5554         * tui/tui-winsource.c (tui_refill_source_window): New function,
5555         from...
5556         (tui_horizontal_source_scroll): ... here.  Move some logic.
5557         * cli/cli-style.c (set_style_enabled): Notify new observable.
5558         * tui/tui-hooks.c (tui_redisplay_source): New function.
5559         (tui_attach_detach_observers): Attach or detach
5560         tui_redisplay_source.
5561         * observable.h (source_styling_changed): New observable.
5562         * observable.c: Define source_styling_changed observable.
5563
5564 2019-03-13  Tom Tromey  <tromey@adacore.com>
5565
5566         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5567         (i386_gnu_nat_target::store_registers): Update.
5568         * target-debug.h (target_debug_print_std_string): New macro.
5569         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5570         * windows-tdep.c (display_one_tib): Update.
5571         * tui/tui-stack.c (tui_make_status_line): Update.
5572         * top.c (print_inferior_quit_action): Update.
5573         * thread.c (thr_try_catch_cmd): Update.
5574         (add_thread_with_info): Update.
5575         (thread_target_id_str): Update.
5576         (thr_try_catch_cmd): Update.
5577         (thread_command): Update.
5578         (thread_find_command): Update.
5579         * record-btrace.c (record_btrace_target::info_record)
5580         (record_btrace_resume_thread, record_btrace_target::resume)
5581         (record_btrace_cancel_resume, record_btrace_step_thread)
5582         (record_btrace_target::wait, record_btrace_target::wait)
5583         (record_btrace_target::wait, record_btrace_target::stop): Update.
5584         * progspace.c (print_program_space): Update.
5585         * process-stratum-target.c
5586         (process_stratum_target::thread_address_space): Update.
5587         * linux-fork.c (linux_fork_mourn_inferior)
5588         (detach_checkpoint_command, info_checkpoints_command)
5589         (linux_fork_context): Update.
5590         (linux_fork_detach): Update.
5591         (class scoped_switch_fork_info): Update.
5592         (delete_checkpoint_command): Update.
5593         * infrun.c (follow_fork_inferior): Update.
5594         (follow_fork_inferior): Update.
5595         (proceed_after_vfork_done): Update.
5596         (handle_vfork_child_exec_or_exit): Update.
5597         (follow_exec): Update.
5598         (displaced_step_prepare_throw): Update.
5599         (displaced_step_restore): Update.
5600         (start_step_over): Update.
5601         (resume_1): Update.
5602         (clear_proceed_status_thread): Update.
5603         (proceed): Update.
5604         (print_target_wait_results): Update.
5605         (do_target_wait): Update.
5606         (context_switch): Update.
5607         (stop_all_threads): Update.
5608         (restart_threads): Update.
5609         (finish_step_over): Update.
5610         (handle_signal_stop): Update.
5611         (switch_back_to_stepped_thread): Update.
5612         (keep_going_pass_signal): Update.
5613         (print_exited_reason): Update.
5614         (normal_stop): Update.
5615         * inferior.c (inferior_pid_to_str): Change return type.
5616         (print_selected_inferior): Update.
5617         (add_inferior): Update.
5618         (detach_inferior): Update.
5619         * dummy-frame.c (fprint_dummy_frames): Update.
5620         * dcache.c (dcache_info_1): Update.
5621         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5622         (btrace_fetch, btrace_clear): Update.
5623         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5624         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5625         type.
5626         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5627         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5628         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5629         * gdbarch.c, gdbarch.h: Rebuild.
5630         * gdbarch.sh (core_pid_to_str): Change return type.
5631         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5632         return type.
5633         (windows_nat_target::pid_to_str): Change return type.
5634         (windows_delete_thread): Update.
5635         (windows_nat_target::attach): Update.
5636         (windows_nat_target::files_info): Update.
5637         * target-delegates.c: Rebuild.
5638         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5639         return type.
5640         (sol_thread_target::pid_to_str): Change return type.
5641         * remote.c (class remote_target) <pid_to_str>: Change return
5642         type.
5643         (remote_target::pid_to_str): Change return type.
5644         (extended_remote_target::attach, remote_target::remote_stop_ns)
5645         (remote_target::remote_notif_remove_queued_reply)
5646         (remote_target::push_stop_reply, remote_target::disable_btrace):
5647         Update.
5648         (extended_remote_target::attach): Update.
5649         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5650         type.
5651         (gdbsim_target::pid_to_str): Change return type.
5652         * ravenscar-thread.c (struct ravenscar_thread_target)
5653         <pid_to_str>: Change return type.
5654         (ravenscar_thread_target::pid_to_str): Change return type.
5655         * procfs.c (class procfs_target) <pid_to_str>: Change return
5656         type.
5657         (procfs_target::pid_to_str): Change return type.
5658         (procfs_target::attach): Update.
5659         (procfs_target::detach): Update.
5660         (procfs_target::fetch_registers): Update.
5661         (procfs_target::store_registers): Update.
5662         (procfs_target::wait): Update.
5663         (procfs_target::files_info): Update.
5664         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5665         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5666         return type.
5667         (nto_procfs_target::pid_to_str): Change return type.
5668         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5669         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5670         return type.
5671         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5672         (exit_lwp): Update.
5673         (attach_proc_task_lwp_callback, get_detach_signal)
5674         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5675         (linux_nat_target::resume, wait_lwp, stop_callback)
5676         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5677         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5678         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5679         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5680         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5681         type.
5682         (inf_ptrace_target::attach): Update.
5683         (inf_ptrace_target::files_info): Update.
5684         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5685         type.
5686         (go32_nat_target::pid_to_str): Change return type.
5687         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5688         (gnu_nat_target::wait): Update.
5689         (gnu_nat_target::wait): Update.
5690         (gnu_nat_target::resume): Update.
5691         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5692         (fbsd_nat_target::wait): Update.
5693         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5694         type.
5695         (darwin_nat_target::attach): Update.
5696         * corelow.c (class core_target) <pid_to_str>: Change return type.
5697         (core_target::pid_to_str): Change return type.
5698         * target.c (normal_pid_to_str): Change return type.
5699         (default_pid_to_str): Likewise.
5700         (target_pid_to_str): Change return type.
5701         (target_translate_tls_address): Update.
5702         (target_announce_detach): Update.
5703         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5704         return type.
5705         (bsd_uthread_target::pid_to_str): Change return type.
5706         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5707         type.
5708         (bsd_kvm_target::pid_to_str): Change return type.
5709         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5710         return type.
5711         (aix_thread_target::pid_to_str): Change return type.
5712         * target.h (struct target_ops) <pid_to_str>: Change return type.
5713         (target_pid_to_str, normal_pid_to_str): Likewise.
5714         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5715         type.
5716         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5717         type.
5718         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5719         return type.
5720         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5721         type.
5722         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5723         type.
5724         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5725         return type.
5726
5727 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5728
5729         * NEWS: Mention that the new default MI version is 3.  Mention
5730         changes to the output of commands and events that deal with
5731         multi-location breakpoints.
5732         * breakpoint.c: Include "mi/mi-out.h".
5733         (print_one_breakpoint): Change output syntax if using MI version
5734         >= 3.
5735         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5736         New.
5737         (mi_multi_location_breakpoint_output_fixed): New.
5738         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5739         (mi_cmd_fix_multi_location_breakpoint_output): New.
5740         (mi_multi_location_breakpoint_output_fixed): New.
5741         * mi/mi-cmds.c (mi_cmds): Register command
5742         -fix-multi-location-breakpoint-output.
5743         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5744         interpreter "mi".
5745
5746 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5747
5748         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5749         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5750         instantiate mi_ui_out based on interpreter name.
5751         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5752         * mi/mi-main.c (mi_load_progress): Likewise.
5753
5754 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5755
5756         * NEWS: Combine separate "New targets" sections for 8.3.
5757
5758 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5759
5760         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5761         (ppcfbsd_init_abi): Install gdbarch
5762         "fetch_tls_load_module_address" and "get_thread_local_address"
5763         methods.
5764
5765 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5766
5767         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5768         (riscv_fbsd_init_abi): Install gdbarch
5769         "fetch_tls_load_module_address" and "get_thread_local_address"
5770         methods.
5771
5772 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5773
5774         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5775         (i386fbsd_init_abi): Install gdbarch
5776         "fetch_tls_load_module_address" and "get_thread_local_address"
5777         methods.
5778
5779 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5780
5781         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5782         (amd64fbsd_init_abi): Install gdbarch
5783         "fetch_tls_load_module_address" and "get_thread_local_address"
5784         methods.
5785
5786 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5787
5788         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5789         (struct fbsd_pspace_data): New type.
5790         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5791         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5792         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5793         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5794         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5795
5796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5797
5798         * gdbtypes.c (lookup_struct_elt): New function.
5799         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5800         * gdbtypes.h (struct struct_elt): New type.
5801         (lookup_struct_elt): New prototype.
5802
5803 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5804
5805         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5806         remove disabled code block.
5807
5808 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5809
5810         * gdbarch.sh (get_thread_local_address): New method.
5811         * gdbarch.h, gdbarch.c: Regenerate.
5812         * target.c (target_translate_tls_address): Use
5813         gdbarch_get_thread_local_address if present instead of
5814         target::get_thread_local_address.
5815
5816 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5817
5818         * target.h (target::get_thread_local_address): Update comment.
5819
5820 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5821
5822         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5823         objfile->separate_debug_objfile_backlink if not NULL.
5824
5825 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5826
5827         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5828         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5829         (amd64bsd_store_inferior_registers): Likewise.
5830         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5831         Enable segment base registers.
5832         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5833         PT_GETFSBASE and PT_GETGSBASE.
5834         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5835         PT_SETGSBASE.
5836         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5837         segment base registers.
5838         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5839
5840 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5841
5842         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5843         Update calls to i386_target_description to add 'segments'
5844         parameter.
5845         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5846         add segment base registers.
5847         * arch/i386.c (i386_create_target_description): Add 'segments'
5848         parameter to enable segment base registers.
5849         * arch/i386.h (i386_create_target_description): Likewise.
5850         * features/i386/32bit-segments.xml: New file.
5851         * features/i386/32bit-segments.c: Generate.
5852         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5853         call to i386_target_description to add 'segments' parameter.
5854         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5855         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5856         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5857         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5858         if feature is present.
5859         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5860         Add 'segments' parameter to call to i386_target_description.
5861         (i386_target_description): Add 'segments' parameter to enable
5862         segment base registers.
5863         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5864         to call to i386_target_description.
5865         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5866         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5867         Define I386_NUM_REGS.
5868         (i386_target_description): Add 'segments' parameter to enable
5869         segment base registers.
5870
5871 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5872
5873         PR/24325
5874         * source-cache.c: #undef open and close, to avoid unresolved
5875         externals during linking.
5876
5877 2019-03-12  Tom Tromey  <tromey@adacore.com>
5878
5879         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5880         const.  Add initializers.
5881         (_initialize_remote): Don't initialize ptid globals.
5882
5883 2019-03-12  Pedro Alves  <palves@redhat.com>
5884
5885         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5886
5887 2019-03-12  Pedro Alves  <palves@redhat.com>
5888
5889         * cp-name-parser.y (main): Remove unused 'len' variable.
5890
5891 2019-03-12  Tom Tromey  <tromey@adacore.com>
5892
5893         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5894         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5895
5896 2019-03-12  Tom Tromey  <tromey@adacore.com>
5897
5898         * linux-nat.c (iterate_over_lwps): Update.
5899         (stop_callback): Remove parameter.
5900         (stop_wait_callback, detach_callback, resume_set_callback)
5901         (select_singlestep_lwp_callback, set_ignore_sigint)
5902         (status_callback, resumed_callback, resume_clear_callback)
5903         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5904         data parameter.
5905         (linux_nat_target::detach, linux_nat_target::resume)
5906         (linux_stop_and_wait_all_lwps, select_event_lwp)
5907         (linux_nat_filter_event, linux_nat_wait_1)
5908         (linux_nat_target::kill, linux_nat_target::stop)
5909         (linux_nat_target::stop): Update.
5910         (linux_nat_resume_callback): Change type.
5911         (resume_stopped_resumed_lwps, count_events_callback)
5912         (select_event_lwp_callback): Likewise.
5913         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5914         * arm-linux-nat.c (struct update_registers_data): Remove.
5915         (update_registers_callback): Change type.
5916         (arm_linux_insert_hw_breakpoint1): Update.
5917         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5918         parameter.
5919         (x86_linux_dr_set_addr): Update.
5920         (x86_linux_dr_set_control): Update.
5921         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5922         (iterate_over_lwps): Use gdb::function_view.
5923         * nat/aarch64-linux-hw-point.c (struct
5924         aarch64_dr_update_callback_param): Remove.
5925         (debug_reg_change_callback): Change type.
5926         (aarch64_notify_debug_reg_change): Update.
5927         * s390-linux-nat.c (s390_refresh_per_info): Update.
5928
5929 2019-03-11  Tom Tromey  <tromey@adacore.com>
5930
5931         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5932         redundant assignment to "this_cu".
5933
5934 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5935
5936         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5937
5938 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5939
5940         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5941         from...
5942         (rank_one_type): ... this.
5943
5944 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5945
5946         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5947         from...
5948         (rank_one_type): ... this.
5949
5950 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5951
5952         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5953         from...
5954         (rank_one_type): ... this.
5955
5956 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5957
5958         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5959         from...
5960         (rank_one_type): ... this.
5961
5962 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5963
5964         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5965         from...
5966         (rank_one_type): ... this.
5967
5968 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5969
5970         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5971         from...
5972         (rank_one_type): ... this.
5973
5974 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5975
5976         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5977         from...
5978         (rank_one_type): ... this.
5979
5980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5981
5982         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5983         from...
5984         (rank_one_type): ... this.
5985
5986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5987
5988         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5989         from...
5990         (rank_one_type): ... this.
5991
5992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5993
5994         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5995         from...
5996         (rank_one_type): ... this.
5997
5998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5999
6000         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6001         from...
6002         (rank_one_type): ... this.
6003
6004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6005
6006         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6007         from...
6008         (rank_one_type): ... this.
6009
6010 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6011
6012         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6013         inferior-events' shows the example events.
6014
6015 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6016
6017         Support styling on native MS-Windows console
6018
6019         PR/24315
6020         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6021         on MS-Windows if $TERM is not defined.
6022
6023         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6024
6025         * posix-hdep.c (gdb_console_fputs):
6026         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6027         functions.
6028         * ui-file.h (gdb_console_fputs): Add prototype.
6029
6030         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6031         back to fputs only if the former returns zero.
6032
6033 2019-03-07  Tom Tromey  <tom@tromey.com>
6034
6035         * symmisc.c (print_symbol_bcache_statistics): Update.
6036         (print_objfile_statistics): Update.
6037         * symfile.c (allocate_symtab): Update.
6038         * stabsread.c: Don't include bcache.h.
6039         * psymtab.h (struct psymbol_bcache): Don't declare.
6040         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6041         (psymbol_bcache_init, psymbol_bcache_free)
6042         (psymbol_bcache_get_bcache): Don't declare.
6043         * psymtab.c (struct psymbol_bcache): Remove.
6044         (psymtab_storage::psymtab_storage): Update.
6045         (psymtab_storage::~psymtab_storage): Update.
6046         (psymbol_bcache_init, psymbol_bcache_free)
6047         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6048         (add_psymbol_to_bcache): Update.
6049         (allocate_psymtab): Update.
6050         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6051         macro_cache>: No longer pointers.
6052         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6053         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6054         * macrotab.c (macro_bcache): Update.
6055         * macroexp.c: Don't include bcache.h.
6056         * gdbtypes.c (check_types_worklist): Update.
6057         (types_deeply_equal): Remove TRY/CATCH.  Update.
6058         * elfread.c (elf_symtab_read): Update.
6059         * dwarf2read.c: Don't include bcache.h.
6060         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6061         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6062         (print_bcache_statistics, bcache_memory_used): Don't declare.
6063         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6064         methods.  Rename all data members.
6065         * bcache.c (struct bcache): Move to bcache.h.
6066         (bcache::expand_hash_table): Rename from expand_hash_table.
6067         (bcache): Remove.
6068         (bcache::insert): Rename from bcache_full.
6069         (bcache::compare): Rename from bcache_compare.
6070         (bcache_xmalloc): Remove.
6071         (bcache::~bcache): Rename from bcache_xfree.
6072         (bcache::print_statistics): Rename from print_bcache_statistics.
6073         (bcache::memory_used): Rename from bcache_memory_used.
6074
6075 2019-03-07  Pedro Alves  <palves@redhat.com>
6076
6077         * infrun.c (normal_stop): Also check for
6078         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6079
6080 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6081
6082         * f-lang.c (value_from_host_double): Moved to...
6083         * value.c (value_from_host_double): ...here.
6084         * value.h (value_from_host_double): Declare.
6085         * guile/scm-math.c (vlscm_convert_typed_number): Use
6086         value_from_host_double.
6087         (vlscm_convert_number): Likewise.
6088         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6089         * python/py-value.c (convert_value_from_python): Likewise.
6090
6091 2019-03-06  Tom Tromey  <tom@tromey.com>
6092
6093         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6094
6095 2019-03-06  Tom Tromey  <tom@tromey.com>
6096
6097         * utils.h (free_current_contents): Don't declare.
6098         * utils.c (free_current_contents): Remove.
6099
6100 2019-03-06  Tom Tromey  <tom@tromey.com>
6101
6102         * top.c (quit_force): Update.
6103         * main.c (captured_command_loop): Update.
6104         * common/new-op.c (operator new): Update.
6105         * common/common-exceptions.c (struct catcher)
6106         <save_cleanup_chain>: Remove member.
6107         (exceptions_state_mc_init): Update.
6108         (exception_try_scope_entry): Return nullptr.
6109         (exception_try_scope_exit, exception_rethrow)
6110         (throw_exception_sjlj, throw_exception_cxx): Update.
6111         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6112         (all_cleanups, do_cleanups, discard_cleanups)
6113         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6114         (restore_cleanups, restore_final_cleanups): Don't declare.
6115         (do_final_cleanups): Remove parameter.
6116         * common/cleanups.c (cleanup_chain, make_cleanup)
6117         (make_cleanup_dtor, all_cleanups, do_cleanups)
6118         (discard_my_cleanups, discard_cleanups)
6119         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6120         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6121         (null_cleanup): Remove.
6122         (do_final_cleanups): Remove parameter.
6123
6124 2019-03-06  Tom Tromey  <tom@tromey.com>
6125
6126         * remote.c (remote_target::remote_parse_stop_reply): Use
6127         unique_xmalloc_ptr.
6128
6129 2019-03-06  Tom Tromey  <tom@tromey.com>
6130
6131         * stabsread.c (struct stabs_field_info): Rename from field_info.
6132         <list, fnlist>: Add initializers.
6133         <obstack>: New member.
6134         (read_member_functions, read_struct_fields, read_baseclasses):
6135         Allocate on obstack.  Don't use cleanups.
6136         (read_one_struct_field, read_member_functions, read_struct_fields)
6137         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6138         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6139         (read_struct_type): Update.
6140
6141 2019-03-06  Tom Tromey  <tom@tromey.com>
6142
6143         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6144         * common/filestuff.h (make_cleanup_close): Don't declare.
6145         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6146         Remove.
6147
6148 2019-03-06  Tom Tromey  <tom@tromey.com>
6149
6150         * solib-aix.c: Use make_scope_exit.
6151
6152 2019-03-06  Tom Tromey  <tom@tromey.com>
6153
6154         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6155         Use make_scope_exit.
6156
6157 2019-03-06  Tom Tromey  <tom@tromey.com>
6158
6159         * solib-svr4.c (disable_probes_interface): Remove parameter.
6160         (svr4_handle_solib_event): Use make_scope_exit.
6161
6162 2019-03-06  Tom Tromey  <tom@tromey.com>
6163
6164         * remote.c (struct stop_reply_deleter): Remove.
6165         (stop_reply_up): Update.
6166         (struct stop_reply): Derive from notif_event.  Don't typedef.
6167         <regcache>: Now a std::vector.
6168         (stop_reply_xfree): Remove.
6169         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6170         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6171         (remote_target::discard_pending_stop_replies): Use delete.
6172         (remote_target::remote_parse_stop_reply): Update.
6173         (remote_target::process_stop_reply): Update.
6174         * remote-notif.h (struct notif_event): Add virtual destructor.
6175         Remove "dtr" member.
6176         (struct notif_client) <alloc_event>: Return a unique_ptr.
6177         (notif_event_xfree): Don't declare.
6178         (notif_event_up): New typedef.
6179         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6180         (notif_event_xfree, do_notif_event_xfree): Remove.
6181         (remote_notif_state_xfree): Update.
6182
6183 2019-03-06  Tom Tromey  <tom@tromey.com>
6184
6185         * infrun.c (displaced_step_clear_cleanup): Now a
6186         forward_scope_exit type.
6187         (displaced_step_prepare_throw): Update.
6188         (displaced_step_fixup): Update.
6189
6190 2019-03-06  Tom Tromey  <tom@tromey.com>
6191
6192         * inferior.h (class inferior): Update comment.
6193         * gdbthread.h (class thread_info): Update comment.
6194
6195 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6196             Tom Tromey  <tom@tromey.com>
6197
6198         * stabsread.h (struct stab_section_list): Remove.
6199         (coffstab_build_psymtabs): Update.
6200         * dbxread.c (symbuf_sections): Now a std::vector.
6201         (sect_idx): New global.
6202         (fill_symbuf): Update.
6203         (coffstab_build_psymtabs): Change type of stabsects parameter.
6204         Update.
6205         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6206         std::vector.
6207         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6208         (coff_locate_sections): Update.
6209         (coff_symfile_read): Remove cleanups.  Update.
6210         (init_stringtab): Add storage parameter.
6211         (free_stringtab, free_stringtab_cleanup): Remove.
6212         (init_lineno): Add storage parameter.
6213         (free_linetab, free_linetab_cleanup): Remove.
6214
6215 2019-03-06  Pedro Alves  <palves@redhat.com>
6216
6217         * linux-fork.c (fork_info::clobber_regs): Delete.
6218         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6219         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6220         comment.  Adjust.
6221         (scoped_switch_fork_info::scoped_switch_fork_info)
6222         (checkpoint_command, linux_fork_context): Adjust
6223         fork_save_infrun_state calls.
6224
6225 2019-03-06  Pedro Alves  <palves@redhat.com>
6226
6227         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6228         (inf_has_multiple_threads): Return 'bool' and rewrite using
6229         inferior_info::threads().
6230
6231 2019-03-06  Pedro Alves  <palves@redhat.com>
6232
6233         * linux-fork.c: Include <list>.
6234         (fork_list): Now a std::list instance.
6235         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6236         (forks_exist_p, find_last_fork): Adjust.
6237         (new_fork): Delete.
6238         (one_fork_p): New.
6239         (add_fork): Adjust.
6240         (free_fork): Delete, folded into fork_info::~fork_info().
6241         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6242         Adjust.
6243         (init_fork_list): Delete.
6244         (linux_fork_killall, linux_fork_mourn_inferior)
6245         (linux_fork_detach, info_checkpoints_command): Adjust.
6246         (_initialize_linux_fork): No longer call init_fork_list.
6247
6248 2019-03-06  Pedro Alves  <palves@redhat.com>
6249
6250         * linux-fork.c (new_fork): New, split out of ...
6251         (add_fork): ... this.  Return void.  Move "first fork" special
6252         case from here, to ...
6253         (checkpoint_command): ... here.
6254         * linux-linux.h (add_fork): Return void.
6255
6256 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6257
6258         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6259
6260 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6261             Chris January  <chris.january@arm.com>
6262             David Lecomber  <david.lecomber@arm.com>
6263
6264         * f-exp.y: New token, UNOP_INTRINSIC.
6265         (exp): New pattern using UNOP_INTRINSIC token.
6266         (f77_keywords): Add 'abs' keyword.
6267         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6268         (value_from_host_double): New function.
6269         (evaluate_subexp_f): Support UNOP_ABS.
6270
6271 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6272
6273         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6274         types.
6275
6276 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6277
6278         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6279         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6280         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6281
6282 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6283
6284         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6285
6286 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6287             Chris January  <chris.january@arm.com>
6288
6289         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6290         * f-exp.y: Define 'KIND' token.
6291         (exp): New pattern for KIND expressions.
6292         (ptype): Handle types with a kind extension.
6293         (direct_abs_decl): Extend to spot kind extensions.
6294         (f77_keywords): Add 'kind' to the list.
6295         (push_kind_type): New function.
6296         (convert_to_kind_type): New function.
6297         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6298         * parse.c (operator_length_standard): Likewise.
6299         * parser-defs.h (enum type_pieces): Add tp_kind.
6300         * std-operator.def: Add UNOP_KIND.
6301
6302 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6303
6304         * f-exp.y (f_parse): Set yydebug.
6305
6306 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6307
6308         * f-lang.c (evaluate_subexp_f): New function.
6309         (exp_descriptor_f): New global.
6310         (f_language_defn): Use exp_descriptor_f instead of
6311         exp_descriptor_standard.
6312
6313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6314
6315         * f-exp.y (struct token): Add comments.
6316         (dot_ops): Remove uppercase versions and the end marker.
6317         (f77_keywords): Likewise.
6318         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6319         entries in the dot_ops array are case insensitive, and use
6320         strncasecmp to compare strings.  Also some whitespace cleanup in
6321         this area.  Similar for the f77_keywords array, except entries in
6322         this list might be case sensitive.
6323
6324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * f-exp.y (struct f77_boolean_val): Add comments.
6327         (boolean_values): Remove uppercase versions, and end marker.
6328         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6329         and use strncasecmp to achieve case insensitivity.  Additionally,
6330         perform whitespace cleanup around this code.
6331
6332 2019-03-06  Tom Tromey  <tromey@adacore.com>
6333
6334         * remote-sim.c (gdbsim_target_open): Use result of
6335         gdb_argv::release.
6336
6337 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6338         Dirk Schubert  <dirk.schubert@arm.com>
6339         Chris January  <chris.january@arm.com>
6340
6341         * eval.c (evaluate_subexp_standard): Call Fortran argument
6342         wrapping logic.
6343         * f-lang.c (struct value): A value which can be passed into a
6344         Fortran function call.
6345         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6346         where appropriate.
6347         (struct type): Value ready for a Fortran function call.
6348         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6349         is needed.
6350         * f-lang.h (fortran_argument_convert): Declaration.
6351         (fortran_preserve_arg_pointer): Declaration.
6352         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6353
6354 2019-03-05  Tom Tromey  <tromey@adacore.com>
6355
6356         * python/py-prettyprint.c (print_string_repr): Remove #if.
6357         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6358
6359 2019-03-05  Tom Tromey  <tromey@adacore.com>
6360
6361         * target.c (the_dummy_target): Move later.  Change type to
6362         "dummy_target".
6363         (initialize_targets): Don't initialize the_dummy_target.
6364
6365 2019-03-05  Tom Tromey  <tromey@adacore.com>
6366
6367         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6368         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6369
6370 2019-03-05  Tom Tromey  <tromey@adacore.com>
6371
6372         * windows-nat.c (windows_nat_target::attach)
6373         (windows_nat_target::detach): Don't call gdb_flush.
6374         * valprint.c (generic_val_print, val_print, val_print_string):
6375         Don't call gdb_flush.
6376         * utils.c (defaulted_query): Don't call gdb_flush.
6377         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6378         * target.c (target_announce_detach): Don't call gdb_flush.
6379         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6380         * remote.c (extended_remote_target::attach): Don't call
6381         gdb_flush.
6382         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6383         * printcmd.c (do_examine): Don't call gdb_flush.
6384         (info_display_command): Don't call gdb_flush.
6385         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6386         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6387         * memattr.c (info_mem_command): Don't call gdb_flush.
6388         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6389         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6390         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6391         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6392         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6393         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6394         (gnu_nat_target::detach): Don't call gdb_flush.
6395         * f-valprint.c (f_val_print): Don't call gdb_flush.
6396         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6397         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6398         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6399         gdb_flush.
6400         * c-valprint.c (c_val_print): Don't call gdb_flush.
6401         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6402
6403 2019-03-05  Tom Tromey  <tromey@adacore.com>
6404
6405         * varobj.c (update_dynamic_varobj_children): Update.
6406         (install_default_visualizer): Use reset, not release.
6407         * value.c (set_internalvar): Update.
6408         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6409         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6410         ATTRIBUTE_UNUSED_RESULT.
6411
6412 2019-03-05  Tom Tromey  <tromey@adacore.com>
6413
6414         * remote.c (class scoped_remote_fd) <release>: Add
6415         ATTRIBUTE_UNUSED_RESULT.
6416
6417 2019-03-05  Tom Tromey  <tromey@adacore.com>
6418
6419         * macroexp.c (struct macro_buffer) <release>: Add
6420         ATTRIBUTE_UNUSED_RESULT.
6421
6422 2019-03-05  Tom Tromey  <tromey@adacore.com>
6423
6424         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6425         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6426         ATTRIBUTE_UNUSED_RESULT.
6427
6428 2019-03-05  Tom Tromey  <tromey@adacore.com>
6429
6430         * common/scoped_fd.h (class scoped_fd) <release>: Add
6431         ATTRIBUTE_UNUSED_RESULT.
6432
6433 2019-03-05  Tom Tromey  <tromey@adacore.com>
6434
6435         * parser-defs.h (struct parser_state) <release>: Add
6436         ATTRIBUTE_UNUSED_RESULT.
6437
6438 2019-03-05  Tom Tromey  <tromey@adacore.com>
6439
6440         * utils.h (class gdb_argv) <release>: Add
6441         ATTRIBUTE_UNUSED_RESULT.
6442         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6443
6444 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6445
6446         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6447         for-loop range, to avoid compiler warnings.
6448
6449         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6450         avoid compiler warnings about unused variables.
6451
6452         * NEWS: Mention end of support for native debugging on MS-Windows
6453         before XP.
6454
6455         PR gdb/24292
6456         * common/netstuff.c:
6457         * gdbserver/gdbreplay.c
6458         * gdbserver/remote-utils.c:
6459         * ser-tcp.c:
6460         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6461         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6462         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6463         'getaddrinfo' and 'freeaddrinfo' were not available before
6464         Windows XP, and mingw.org's MinGW headers by default define
6465         _WIN32_WINNT to 0x500.
6466
6467 2019-03-01  Gary Benson <gbenson@redhat.com>
6468
6469         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6470
6471 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6472             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6473
6474         PR gdb/8527
6475         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6476         set_sigint_trap, clear_sigint_trap.
6477
6478 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6479
6480         * target.c (target_detach): Clear the regcache and the
6481         frame cache.
6482
6483 2019-02-27  Pedro Alves  <palves@redhat.com>
6484
6485         * utils.c (set_screen_size): When we cap the height/width sizes,
6486         tweak the corresponding command variable to show "unlimited":
6487
6488 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6489             Pedro Alves  <palves@redhat.com>
6490
6491         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6492         before calling rl_set_screen_size.
6493
6494 2019-02-27  Tom Tromey  <tromey@adacore.com>
6495
6496         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6497         define.
6498         * python/py-value.c: Remove Python 2.4 workaround.
6499         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6500         workaround.
6501         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6502         Python 2.4 workaround.
6503         * python/python-internal.h: Remove Python 2.4 comment.
6504         (Py_ssize_t): Don't define.
6505         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6506         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6507         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6508         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6509         * python/python.c (do_start_initialization): Remove Python 2.4
6510         workaround.
6511         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6512         (print_children): Remove Python 2.4 workaround.
6513         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6514         workaround.
6515         (CHARBUFFERPROC_NAME): Remove.
6516         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6517         Python 2.4 workaround.
6518
6519 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6520
6521         * NEWS: Note minimum Python version.
6522
6523 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6524
6525         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6526         code from these functions.  Remove corresponding ifdefs.  Use
6527         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6528         Remove gotos and target of gotos.
6529         (infpy_search_memory): Likewise.
6530
6531 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6532
6533         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6534         (hppa_gdbarch_init): Don't register deleted functions with
6535         gdbarch.
6536
6537 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6540         (h8300_unwind_sp): Delete.
6541         (h8300_dummy_id): Delete.
6542         (h8300_gdbarch_init): Don't register deleted functions with
6543         gdbarch.
6544
6545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6546
6547         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6548         (ft32_unwind_pc): Delete.
6549         (ft32_unwind_sp): Delete.
6550         (ft32_gdbarch_init): Don't register deleted functions with
6551         gdbarch.
6552
6553 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6554
6555         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6556         (frv_unwind_pc): Delete.
6557         (frv_unwind_sp): Delete.
6558         (frv_gdbarch_init): Don't register deleted functions with
6559         gdbarch.
6560
6561 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6562
6563         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6564         (riscv_unwind_pc): Delete.
6565         (riscv_unwind_sp): Delete.
6566         (riscv_gdbarch_init): Don't register deleted functions with
6567         gdbarch.
6568
6569 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6570
6571         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6572         (csky_unwind_pc): Delete.
6573         (csky_unwind_sp): Delete.
6574         (csky_gdbarch_init): Don't register deleted functions with
6575         gdbarch.
6576
6577 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6578
6579         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6580         (cris_unwind_pc): Delete.
6581         (cris_unwind_sp): Delete.
6582         (cris_gdbarch_init): Don't register deleted functions with
6583         gdbarch.
6584
6585 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6586
6587         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6588         (bfin_unwind_pc): Delete.
6589         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6590
6591 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6592
6593         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6594         (arm_unwind_pc): Delete.
6595         (arm_unwind_sp): Delete.
6596         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6597
6598 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6599
6600         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6601         (arc_unwind_pc): Delete.
6602         (arc_unwind_sp): Delete.
6603         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6604
6605 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6606
6607         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6608         (alpha_unwind_pc): Delete.
6609         (alpha_gdbarch_init): Don't register deleted functions with
6610         gdbarch.
6611
6612 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6613
6614         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6615         (aarch64_unwind_pc): Delete.
6616         (aarch64_unwind_sp): Delete.
6617         (aarch64_gdbarch_init): Don't register deleted functions with
6618         gdbarch.
6619
6620 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6621
6622         * gdbtypes.c (type_align): Don't consider static members when
6623         computing structure alignment.
6624
6625 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6626
6627         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6628         return 0 for other types.
6629         * arch-utils.c (default_type_align): Always return 0.
6630         * gdbarch.h: Regenerate.
6631         * gdbarch.sh (type_align): Extend comment.
6632         * gdbtypes.c (type_align): Add additional comments, always call
6633         gdbarch_type_align before applying the default rules.
6634         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6635         generic code will then apply a suitable default.
6636         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6637         types, return 0 for other types.
6638
6639 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6640
6641         * NEWS: Create a new section for the next release branch.
6642         Rename the section of the current branch, now that it has
6643         been cut.
6644
6645 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6646
6647         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6648         * version.in: Bump version to 8.3.50.DATE-git.
6649
6650 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6651
6652         * aix-thread.c (ptid_cmp): Remove unused variable.
6653         (get_signaled_thread): Likewise.
6654         (store_regs_user_thread): Likewise.
6655         (store_regs_kernel_thread): Likewise.
6656         (fetch_regs_kernel_thread): Remove shadowed variable.
6657
6658 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6659
6660         * features/riscv/32bit-cpu.xml: Add register numbers.
6661         * features/riscv/32bit-fpu.c: Regenerate.
6662         * features/riscv/32bit-fpu.xml: Add register numbers.
6663         * features/riscv/64bit-cpu.xml: Add register numbers.
6664         * features/riscv/64bit-fpu.c: Regenerate.
6665         * features/riscv/64bit-fpu.xml: Add register numbers.
6666
6667 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6668
6669         * NEWS: Mention two argument form of gdb.Value constructor.
6670         * python/py-value.c (convert_buffer_and_type_to_value): New
6671         function.
6672         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6673         Add support for handling an optional second argument.  Call
6674         convert_buffer_and_type_to_value as appropriate.
6675         * python/python-internal.h (Py_buffer_deleter): New struct.
6676         (Py_buffer_up): New typedef.
6677
6678 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6679
6680         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6681         instead of releasing ownership.
6682
6683 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6684
6685         * dwarf2read.c (open_and_init_dwp_file): Call
6686         elf_numsections instead of bfd_count_sections to initialize
6687         dwp_file->num_sections.
6688
6689 2019-02-25  Tom Tromey  <tromey@adacore.com>
6690
6691         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6692
6693 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6694
6695         * gcore.in: Add '--readnever' option when invoking GDB.
6696
6697 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6698
6699         * MAINTAINERS: Update my email address.
6700
6701 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6702
6703         * build-id.c (build_id_to_debug_bfd_1): New function.
6704         (build_id_to_debug_bfd): Look for separate debug file in
6705         sysroot.
6706
6707 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6708
6709         * gdbarch.sh: Update the copyright year range that is placed into
6710         generated files.
6711
6712 2019-02-22  Keith Seitz  <keiths@redhat.com>
6713
6714         PR symtab/23853
6715         * linespec.c (create_sals_line_offset): Search for the default
6716         symtab's filename instead of its fullname.
6717
6718 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6719
6720         * NEWS: Update style defaults.
6721
6722 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6723
6724         * main.c (captured_main_1): Disable styling in batch mode.
6725
6726 2019-02-20  Tom Tromey  <tom@tromey.com>
6727
6728         * symtab.c (symtab_symbol_info): Fix typos.
6729
6730 2019-02-20  Tom Tromey  <tromey@adacore.com>
6731
6732         * findcmd.c (_initialize_mem_search): Use upper case for
6733         metasyntactic variables.
6734
6735 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6736
6737         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6738         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6739
6740 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6741
6742         * top.h (source_file_name): Change to std::string.
6743         * top.c (source_file_name): Likewise.
6744         (command_line_input): Adjust.
6745         * cli/cli-script.c (script_from_file): Adjust.
6746
6747 2019-02-19  Tom Tromey  <tromey@adacore.com>
6748
6749         * ravenscar-thread.c
6750         (ravenscar_thread_target::update_thread_list): Don't call
6751         ada_build_task_list.
6752         * ada-lang.h (ada_build_task_list): Don't declare.
6753         * ada-tasks.c (struct ada_tasks_inferior_data)
6754         <task_list_valid_p>: Now bool.
6755         (read_known_tasks, ada_task_list_changed)
6756         (ada_tasks_invalidate_inferior_data): Update.
6757         (read_known_tasks_array): Return bool.
6758         (read_known_tasks_list): Likewise.
6759         (read_known_tasks): Return void.
6760         (ada_build_task_list): Now static.
6761
6762 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6763
6764         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6765         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6766
6767 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6768
6769         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6770         variant for ada_tasks_pspace_data_handle and
6771         ada_tasks_inferior_data_handle.
6772         (ada_tasks_pspace_data_cleanup): New function.
6773         (ada_tasks_inferior_data_cleanup): New function.
6774
6775 2019-02-17  Tom Tromey  <tom@tromey.com>
6776
6777         * macrotab.h (macro_source_fullname): Return a std::string.
6778         * macrotab.c (macro_include, check_for_redefinition)
6779         (macro_undef, macro_lookup_definition, foreach_macro)
6780         (foreach_macro_in_scope): Update.
6781         (macro_source_fullname): Return a std::string.
6782         * macrocmd.c (show_pp_source_pos): Update.
6783
6784 2019-02-17  Tom Tromey  <tom@tromey.com>
6785
6786         * macrocmd.c (show_pp_source_pos): Style the file names.
6787
6788 2019-02-17  Tom Tromey  <tom@tromey.com>
6789
6790         PR tui/24197:
6791         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6792
6793 2019-02-17  Tom Tromey  <tom@tromey.com>
6794
6795         * ada-lang.c (user_select_syms): Use filtered printing.
6796         * utils.c (wrap_style): New global.
6797         (desired_style): Remove.
6798         (emit_style_escape): Add stream parameter.
6799         (set_output_style, reset_terminal_style, prompt_for_continue):
6800         Update.
6801         (flush_wrap_buffer): Only flush gdb_stdout.
6802         (wrap_here): Set wrap_style.
6803         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6804         treat escape sequences as a character.  Change when wrap buffer is
6805         flushed.
6806         (fputs_styled): Do not set the output style when the default is
6807         requested.
6808         * ui-style.h (struct ui_file_style) <is_default>: New method.
6809         * source.c (print_source_lines_base): Emit escape sequences in one
6810         piece.
6811
6812 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6813
6814         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6815         integers and enumeration types.
6816
6817 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6818
6819         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6820         instead of lookup_symbol_in_language
6821         (do_exact_match): New function.
6822         (ada_get_symbol_name_matcher): Return do_exact_match when
6823         doing a verbatim match.
6824
6825 2019-02-15  Tom Tromey  <tromey@adacore.com>
6826
6827         * ravenscar-thread.c (ravenscar_thread_target::resume)
6828         (ravenscar_thread_target::wait): Special case wildcard requests.
6829
6830 2019-02-15  Tom Tromey  <tromey@adacore.com>
6831
6832         * ravenscar-thread.c (base_ptid): Remove.
6833         (struct ravenscar_thread_target) <close>: New method.
6834         <m_base_ptid>: New member.
6835         <update_inferior_ptid, active_task, task_is_currently_active,
6836         runtime_initialized>: Declare methods.
6837         <ravenscar_thread_target>: Add constructor.
6838         (ravenscar_thread_target::task_is_currently_active)
6839         (ravenscar_thread_target::update_inferior_ptid)
6840         (ravenscar_runtime_initialized): Rename.  Now methods.
6841         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6842         (ravenscar_thread_target::update_thread_list): Update.
6843         (ravenscar_thread_target::active_task): Now method.
6844         (ravenscar_thread_target::store_registers)
6845         (ravenscar_thread_target::prepare_to_store)
6846         (ravenscar_thread_target::prepare_to_store)
6847         (ravenscar_thread_target::mourn_inferior): Update.
6848         (ravenscar_inferior_created): Use "new" to create target.
6849         (ravenscar_thread_target::get_ada_task_ptid): Update.
6850         (_initialize_ravenscar): Don't initialize base_ptid.
6851         (ravenscar_ops): Remove global.
6852
6853 2019-02-15  Tom Tromey  <tromey@adacore.com>
6854
6855         * target.h (push_target): Declare new overload.
6856         * target.c (push_target): New overload, taking an rvalue reference.
6857         * remote.c (remote_target::open_1): Use push_target overload.
6858         * corelow.c (core_target_open): Use push_target overload.
6859
6860 2019-02-15  Tom Tromey  <tromey@adacore.com>
6861
6862         * ravenscar-thread.c (is_ravenscar_task)
6863         (ravenscar_task_is_currently_active): Return bool.
6864         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6865         (_initialize_ravenscar): Remove "(void)".
6866         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6867         Return bool.
6868
6869 2019-02-15  Tom Tromey  <tromey@adacore.com>
6870
6871         * ravenscar-thread.c (ravenscar_runtime_initializer)
6872         (has_ravenscar_runtime, get_running_thread_id)
6873         (ravenscar_thread_target::resume): Fix indentation.
6874
6875 2019-02-15  Tom Tromey  <tromey@adacore.com>
6876
6877         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6878         from ravenscar_arch_ops.
6879         (sparc_ravenscar_ops::fetch_registers)
6880         (sparc_ravenscar_ops::store_registers): Now methods.
6881         (sparc_ravenscar_prepare_to_store): Remove.
6882         (sparc_ravenscar_ops): Redefine.
6883         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6884         methods and destructor.  Remove members.
6885         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6886         (ravenscar_thread_target::store_registers)
6887         (ravenscar_thread_target::prepare_to_store): Update.
6888         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6889         Remove.
6890         (struct ppc_ravenscar_powerpc_ops): Derive from
6891         ravenscar_arch_ops.
6892         (ppc_ravenscar_powerpc_ops::fetch_registers)
6893         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6894         (ppc_ravenscar_powerpc_ops): Redefine.
6895         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6896         (ppc_ravenscar_e500_ops::fetch_registers)
6897         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6898         (ppc_ravenscar_e500_ops): Redefine.
6899         * aarch64-ravenscar-thread.c
6900         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6901         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6902         (aarch64_ravenscar_fetch_registers)
6903         (aarch64_ravenscar_store_registers): Now methods.
6904         (aarch64_ravenscar_ops): Redefine.
6905
6906 2019-02-15  Tom Tromey  <tromey@adacore.com>
6907
6908         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6909         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6910         (ravenscar_thread_target::stopped_by_watchpoint)
6911         (ravenscar_thread_target::stopped_data_address)
6912         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6913
6914 2019-02-15  Tom Tromey  <tromey@adacore.com>
6915
6916         * ravenscar-thread.c: Fix some typos.
6917
6918 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6919             Tom Tromey  <tromey@adacore.com>
6920
6921         * ada-lang.c (ada_exception_sal): Change addr_string to a
6922         std::string.
6923         (create_ada_exception_catchpoint): Update.
6924
6925 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6926             Tom Tromey  <tromey@adacore.com>
6927
6928         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6929         (bp_location_ops): Remove.
6930         (base_breakpoint_allocate_location): Update.
6931         (free_bp_location): Update.
6932         * ada-lang.c (class ada_catchpoint_location)
6933         <ada_catchpoint_location>: Remove ops parameter.
6934         (ada_catchpoint_location_dtor): Remove.
6935         (ada_catchpoint_location_ops): Remove.
6936         (allocate_location_exception): Update.
6937         * breakpoint.h (struct bp_location_ops): Remove.
6938         (class bp_location) <bp_location>: Remove bp_location_ops
6939         parameter.
6940         <~bp_location>: Add destructor.
6941         <ops>: Remove.
6942
6943 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6944             Pedro Alves  <palves@redhat.com>
6945
6946         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6947         'PATH_MAX'.
6948
6949 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6950             Samuel Thibault  <samuel.thibault@gnu.org>
6951             Thomas Schwinge  <thomas@codesourcery.com>
6952
6953         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6954         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6955
6956 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6957
6958         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6959         (check_empty): Use "const char *".
6960
6961         * gnu-nat.c (gnu_nat_target::detach): Instead of
6962         'detach_inferior (pid)' call
6963         'detach_inferior (find_inferior_pid (pid))'.
6964
6965         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6966         'nat/fork-inferior.o'.
6967         * gnu-nat.c: #include "nat/fork-inferior.h".
6968
6969         * gnu-nat.c (gnu_nat_target::detach): Instead of
6970         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6971         * gnu-nat.h: #include "inf-child.h".
6972         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6973         'i386_gnu_nat_target::fetch_registers'.
6974         (gnu_store_registers): Rename/move to
6975         'i386_gnu_nat_target::store_registers'.
6976
6977         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6978         * gnu-nat.h (mach_thread_info): New function.
6979         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6980
6981         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6982
6983 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6984
6985         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6986
6987 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6988
6989         * windows-nat.c (windows_add_thread): Add new parameter
6990         "main_thread_p" with default value set to false.  Update
6991         function documentation as well as all callers.
6992         (windows_delete_thread): Likewise.
6993         (fake_create_process): Update call to windows_add_thread.
6994         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6995         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6996         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6997         call to windows_delete_thread.
6998
6999 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7000
7001         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7002
7003 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7004
7005         * symfile.c (find_separate_debug_file): Use canonical path of
7006         sysroot with child_path instead of gdb_sysroot if it is valid.
7007
7008 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7009
7010         * symfile.c (find_separate_debug_file): Use child_path to
7011         determine if an object file is under a sysroot.
7012
7013 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7014
7015         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7016         unittests/child-path-selftests.c.
7017         * common/pathstuff.c (child_path): New function.
7018         * common/pathstuff.h (child_path): New prototype.
7019         * unittests/child-path-selftests.c: New file.
7020
7021 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7022
7023         * symfile.c (find_separate_debug_file): Look for separate debug
7024         files in debug directories under the sysroot.
7025
7026 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7027
7028         * symtab.h (struct minimal_symbol data_p): New const method.
7029         (struct minimal_symbol text_p): Likewise.
7030         * symtab.c (output_source_filename): Use file name style
7031         to print file name.
7032         (print_symbol_info): Likewise.
7033         (print_msymbol_info): Use address style to print addresses.
7034         Use function name style to print executable text symbols.
7035         (expand_symtab_containing_pc): Use data_p.
7036         (find_pc_sect_compunit_symtab): Likewise.
7037
7038 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7039
7040         * breakpoint.c (describe_other_breakpoints): Use address style
7041         to print addresses.
7042         (say_where): Likewise.
7043
7044 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7045
7046         * ada-typeprint.c (print_func_type): Print function name
7047         style to print function name.
7048         * c-typeprint.c (c_print_type_1): Likewise.
7049
7050 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7051
7052         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7053         for execve.
7054
7055 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7056
7057         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7058         type_stack.
7059
7060 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7061
7062         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7063         TYPE_CODE_REF types.
7064
7065 2019-02-08  Jim Wilson  <jimw@sifive.com>
7066
7067         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7068         (riscv_linux_fregset): New.
7069         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7070
7071 2019-02-07  Tom Tromey  <tom@tromey.com>
7072
7073         * thread.c (thread_cancel_execution_command): Update.
7074         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7075         methods.
7076         (struct thread_fsm_ops): Remove.
7077         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7078         (thread_fsm_should_stop, thread_fsm_return_value)
7079         (thread_fsm_set_finished, thread_fsm_finished_p)
7080         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7081         Don't declare.
7082         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7083         * infrun.c (clear_proceed_status_thread)
7084         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7085         (print_stop_event): Update.
7086         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7087         Add constructor.
7088         (step_command_fsm_ops): Remove.
7089         (new_step_command_fsm): Remove.
7090         (step_1): Update.
7091         (step_command_fsm::should_stop): Rename from
7092         step_command_fsm_should_stop.
7093         (step_command_fsm::clean_up): Rename from
7094         step_command_fsm_clean_up.
7095         (step_command_fsm::do_async_reply_reason): Rename from
7096         step_command_fsm_async_reply_reason.
7097         (struct until_next_fsm): Inherit from thread_fsm.  Add
7098         constructor.
7099         (until_next_fsm_ops): Remove.
7100         (new_until_next_fsm): Remove.
7101         (until_next_fsm::should_stop): Rename from
7102         until_next_fsm_should_stop.
7103         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7104         (until_next_fsm::do_async_reply_reason): Rename from
7105         until_next_fsm_async_reply_reason.
7106         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7107         constructor.  Change type of breakpoint.
7108         (finish_command_fsm_ops): Remove.
7109         (new_finish_command_fsm): Remove.
7110         (finish_command_fsm::should_stop): Rename from
7111         finish_command_fsm_should_stop.
7112         (finish_command_fsm::clean_up): Rename from
7113         finish_command_fsm_clean_up.
7114         (finish_command_fsm::return_value): Rename from
7115         finish_command_fsm_return_value.
7116         (finish_command_fsm::do_async_reply_reason): Rename from
7117         finish_command_fsm_async_reply_reason.
7118         (finish_command): Update.
7119         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7120         Add constructor.
7121         (call_thread_fsm_ops): Remove.
7122         (call_thread_fsm::call_thread_fsm): Rename from
7123         new_call_thread_fsm.
7124         (call_thread_fsm::should_stop): Rename from
7125         call_thread_fsm_should_stop.
7126         (call_thread_fsm::should_notify_stop): Rename from
7127         call_thread_fsm_should_notify_stop.
7128         (run_inferior_call, call_function_by_hand_dummy): Update.
7129         * cli/cli-interp.c (should_print_stop_to_console): Update.
7130         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7131         Add constructor.  Change type of location_breakpoint,
7132         caller_breakpoint.
7133         (until_break_fsm_ops): Remove.
7134         (new_until_break_fsm): Remove.
7135         (until_break_fsm::should_stop): Rename from
7136         until_break_fsm_should_stop.
7137         (until_break_fsm::clean_up): Rename from
7138         until_break_fsm_clean_up.
7139         (until_break_fsm::do_async_reply_reason): Rename from
7140         until_break_fsm_async_reply_reason.
7141         (until_break_command): Update.
7142         * thread-fsm.c: Remove.
7143         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7144
7145 2019-02-07  Tom Tromey  <tom@tromey.com>
7146
7147         * yy-remap.h: Add include guard.
7148         * xtensa-tdep.h: Add include guard.
7149         * xcoffread.h: Rename include guard.
7150         * varobj-iter.h: Add include guard.
7151         * tui/tui.h: Rename include guard.
7152         * tui/tui-winsource.h: Rename include guard.
7153         * tui/tui-wingeneral.h: Rename include guard.
7154         * tui/tui-windata.h: Rename include guard.
7155         * tui/tui-win.h: Rename include guard.
7156         * tui/tui-stack.h: Rename include guard.
7157         * tui/tui-source.h: Rename include guard.
7158         * tui/tui-regs.h: Rename include guard.
7159         * tui/tui-out.h: Rename include guard.
7160         * tui/tui-layout.h: Rename include guard.
7161         * tui/tui-io.h: Rename include guard.
7162         * tui/tui-hooks.h: Rename include guard.
7163         * tui/tui-file.h: Rename include guard.
7164         * tui/tui-disasm.h: Rename include guard.
7165         * tui/tui-data.h: Rename include guard.
7166         * tui/tui-command.h: Rename include guard.
7167         * tic6x-tdep.h: Add include guard.
7168         * target/waitstatus.h: Rename include guard.
7169         * target/wait.h: Rename include guard.
7170         * target/target.h: Rename include guard.
7171         * target/resume.h: Rename include guard.
7172         * target-float.h: Rename include guard.
7173         * stabsread.h: Add include guard.
7174         * rs6000-tdep.h: Add include guard.
7175         * riscv-fbsd-tdep.h: Add include guard.
7176         * regformats/regdef.h: Rename include guard.
7177         * record.h: Rename include guard.
7178         * python/python.h: Rename include guard.
7179         * python/python-internal.h: Rename include guard.
7180         * python/py-stopevent.h: Rename include guard.
7181         * python/py-ref.h: Rename include guard.
7182         * python/py-record.h: Rename include guard.
7183         * python/py-record-full.h: Rename include guard.
7184         * python/py-record-btrace.h: Rename include guard.
7185         * python/py-instruction.h: Rename include guard.
7186         * python/py-events.h: Rename include guard.
7187         * python/py-event.h: Rename include guard.
7188         * procfs.h: Add include guard.
7189         * proc-utils.h: Add include guard.
7190         * p-lang.h: Add include guard.
7191         * or1k-tdep.h: Rename include guard.
7192         * observable.h: Rename include guard.
7193         * nto-tdep.h: Rename include guard.
7194         * nat/x86-linux.h: Rename include guard.
7195         * nat/x86-linux-dregs.h: Rename include guard.
7196         * nat/x86-gcc-cpuid.h: Add include guard.
7197         * nat/x86-dregs.h: Rename include guard.
7198         * nat/x86-cpuid.h: Rename include guard.
7199         * nat/ppc-linux.h: Rename include guard.
7200         * nat/mips-linux-watch.h: Rename include guard.
7201         * nat/linux-waitpid.h: Rename include guard.
7202         * nat/linux-ptrace.h: Rename include guard.
7203         * nat/linux-procfs.h: Rename include guard.
7204         * nat/linux-osdata.h: Rename include guard.
7205         * nat/linux-nat.h: Rename include guard.
7206         * nat/linux-namespaces.h: Rename include guard.
7207         * nat/linux-btrace.h: Rename include guard.
7208         * nat/glibc_thread_db.h: Rename include guard.
7209         * nat/gdb_thread_db.h: Rename include guard.
7210         * nat/gdb_ptrace.h: Rename include guard.
7211         * nat/fork-inferior.h: Rename include guard.
7212         * nat/amd64-linux-siginfo.h: Rename include guard.
7213         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7214         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7215         * nat/aarch64-linux.h: Rename include guard.
7216         * nat/aarch64-linux-hw-point.h: Rename include guard.
7217         * mn10300-tdep.h: Add include guard.
7218         * mips-linux-tdep.h: Add include guard.
7219         * mi/mi-parse.h: Rename include guard.
7220         * mi/mi-out.h: Rename include guard.
7221         * mi/mi-main.h: Rename include guard.
7222         * mi/mi-interp.h: Rename include guard.
7223         * mi/mi-getopt.h: Rename include guard.
7224         * mi/mi-console.h: Rename include guard.
7225         * mi/mi-common.h: Rename include guard.
7226         * mi/mi-cmds.h: Rename include guard.
7227         * mi/mi-cmd-break.h: Rename include guard.
7228         * m2-lang.h: Add include guard.
7229         * location.h: Rename include guard.
7230         * linux-record.h: Rename include guard.
7231         * linux-nat.h: Add include guard.
7232         * linux-fork.h: Add include guard.
7233         * i386-darwin-tdep.h: Rename include guard.
7234         * hppa-linux-offsets.h: Add include guard.
7235         * guile/guile.h: Rename include guard.
7236         * guile/guile-internal.h: Rename include guard.
7237         * gnu-nat.h: Rename include guard.
7238         * gdb-stabs.h: Rename include guard.
7239         * frv-tdep.h: Add include guard.
7240         * f-lang.h: Add include guard.
7241         * event-loop.h: Add include guard.
7242         * darwin-nat.h: Rename include guard.
7243         * cp-abi.h: Rename include guard.
7244         * config/sparc/nm-sol2.h: Rename include guard.
7245         * config/nm-nto.h: Rename include guard.
7246         * config/nm-linux.h: Add include guard.
7247         * config/i386/nm-i386gnu.h: Rename include guard.
7248         * config/djgpp/nl_types.h: Rename include guard.
7249         * config/djgpp/langinfo.h: Rename include guard.
7250         * compile/gcc-cp-plugin.h: Add include guard.
7251         * compile/gcc-c-plugin.h: Add include guard.
7252         * compile/compile.h: Rename include guard.
7253         * compile/compile-object-run.h: Rename include guard.
7254         * compile/compile-object-load.h: Rename include guard.
7255         * compile/compile-internal.h: Rename include guard.
7256         * compile/compile-cplus.h: Rename include guard.
7257         * compile/compile-c.h: Rename include guard.
7258         * common/xml-utils.h: Rename include guard.
7259         * common/x86-xstate.h: Rename include guard.
7260         * common/version.h: Rename include guard.
7261         * common/vec.h: Rename include guard.
7262         * common/tdesc.h: Rename include guard.
7263         * common/selftest.h: Rename include guard.
7264         * common/scoped_restore.h: Rename include guard.
7265         * common/scoped_mmap.h: Rename include guard.
7266         * common/scoped_fd.h: Rename include guard.
7267         * common/safe-iterator.h: Rename include guard.
7268         * common/run-time-clock.h: Rename include guard.
7269         * common/refcounted-object.h: Rename include guard.
7270         * common/queue.h: Rename include guard.
7271         * common/ptid.h: Rename include guard.
7272         * common/print-utils.h: Rename include guard.
7273         * common/preprocessor.h: Rename include guard.
7274         * common/pathstuff.h: Rename include guard.
7275         * common/observable.h: Rename include guard.
7276         * common/netstuff.h: Rename include guard.
7277         * common/job-control.h: Rename include guard.
7278         * common/host-defs.h: Rename include guard.
7279         * common/gdb_wait.h: Rename include guard.
7280         * common/gdb_vecs.h: Rename include guard.
7281         * common/gdb_unlinker.h: Rename include guard.
7282         * common/gdb_unique_ptr.h: Rename include guard.
7283         * common/gdb_tilde_expand.h: Rename include guard.
7284         * common/gdb_sys_time.h: Rename include guard.
7285         * common/gdb_string_view.h: Rename include guard.
7286         * common/gdb_splay_tree.h: Rename include guard.
7287         * common/gdb_setjmp.h: Rename include guard.
7288         * common/gdb_ref_ptr.h: Rename include guard.
7289         * common/gdb_optional.h: Rename include guard.
7290         * common/gdb_locale.h: Rename include guard.
7291         * common/gdb_assert.h: Rename include guard.
7292         * common/filtered-iterator.h: Rename include guard.
7293         * common/filestuff.h: Rename include guard.
7294         * common/fileio.h: Rename include guard.
7295         * common/environ.h: Rename include guard.
7296         * common/common-utils.h: Rename include guard.
7297         * common/common-types.h: Rename include guard.
7298         * common/common-regcache.h: Rename include guard.
7299         * common/common-inferior.h: Rename include guard.
7300         * common/common-gdbthread.h: Rename include guard.
7301         * common/common-exceptions.h: Rename include guard.
7302         * common/common-defs.h: Rename include guard.
7303         * common/common-debug.h: Rename include guard.
7304         * common/cleanups.h: Rename include guard.
7305         * common/buffer.h: Rename include guard.
7306         * common/btrace-common.h: Rename include guard.
7307         * common/break-common.h: Rename include guard.
7308         * cli/cli-utils.h: Rename include guard.
7309         * cli/cli-style.h: Rename include guard.
7310         * cli/cli-setshow.h: Rename include guard.
7311         * cli/cli-script.h: Rename include guard.
7312         * cli/cli-interp.h: Rename include guard.
7313         * cli/cli-decode.h: Rename include guard.
7314         * cli/cli-cmds.h: Rename include guard.
7315         * charset-list.h: Add include guard.
7316         * buildsym-legacy.h: Rename include guard.
7317         * bfin-tdep.h: Add include guard.
7318         * ax.h: Rename include guard.
7319         * arm-linux-tdep.h: Add include guard.
7320         * arm-fbsd-tdep.h: Add include guard.
7321         * arch/xtensa.h: Rename include guard.
7322         * arch/tic6x.h: Add include guard.
7323         * arch/i386.h: Add include guard.
7324         * arch/arm.h: Rename include guard.
7325         * arch/arm-linux.h: Rename include guard.
7326         * arch/arm-get-next-pcs.h: Rename include guard.
7327         * arch/amd64.h: Add include guard.
7328         * arch/aarch64-insn.h: Rename include guard.
7329         * arch-utils.h: Rename include guard.
7330         * annotate.h: Add include guard.
7331         * amd64-darwin-tdep.h: Rename include guard.
7332         * aarch64-linux-tdep.h: Add include guard.
7333         * aarch64-fbsd-tdep.h: Add include guard.
7334         * aarch32-linux-nat.h: Add include guard.
7335
7336 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7337
7338         * macrotab.c (macro_define_internal): New function that
7339         factorizes macro_define_object_internal and macro_define_function
7340         code.
7341         (macro_define_object_internal): Use macro_define_internal.
7342         (macro_define_function): Likewise.
7343
7344 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7345
7346         * macrocmd.c (extract_identifier): Return
7347         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7348         callers.
7349
7350 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7351
7352         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7353
7354 2019-02-05  Tom Tromey  <tom@tromey.com>
7355
7356         * target.c (target_stack::unpush): Move assertion earlier.
7357
7358 2019-01-30  Tom Tromey  <tom@tromey.com>
7359
7360         PR python/23615:
7361         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7362         (gdbpy_parse_and_eval): Likewise.
7363         * python/python-internal.h (gdbpy_allow_threads): New class.
7364
7365 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7366
7367         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7368         (aarch64_fbsd_fpregmap): Move earlier.
7369         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7370         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7371         instead of individual calls to trad_frame_set_reg_addr.
7372         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7373         earlier.
7374         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7375         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7376         instead of individual calls to trad_frame_set_reg_addr.
7377
7378 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7379
7380         * CONTRIBUTE: Replace contribution list with wiki link.
7381
7382 2019-01-25  Tom Tromey  <tom@tromey.com>
7383
7384         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7385
7386 2019-01-25  Tom Tromey  <tom@tromey.com>
7387
7388         * xtensa-linux-nat.c: Fix common/ includes.
7389         * xml-support.h: Fix common/ includes.
7390         * xml-support.c: Fix common/ includes.
7391         * x86-linux-nat.c: Fix common/ includes.
7392         * windows-nat.c: Fix common/ includes.
7393         * varobj.h: Fix common/ includes.
7394         * varobj.c: Fix common/ includes.
7395         * value.c: Fix common/ includes.
7396         * valops.c: Fix common/ includes.
7397         * utils.c: Fix common/ includes.
7398         * unittests/xml-utils-selftests.c: Fix common/ includes.
7399         * unittests/utils-selftests.c: Fix common/ includes.
7400         * unittests/unpack-selftests.c: Fix common/ includes.
7401         * unittests/tracepoint-selftests.c: Fix common/ includes.
7402         * unittests/style-selftests.c: Fix common/ includes.
7403         * unittests/string_view-selftests.c: Fix common/ includes.
7404         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7405         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7406         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7407         * unittests/rsp-low-selftests.c: Fix common/ includes.
7408         * unittests/parse-connection-spec-selftests.c: Fix common/
7409         includes.
7410         * unittests/optional-selftests.c: Fix common/ includes.
7411         * unittests/offset-type-selftests.c: Fix common/ includes.
7412         * unittests/observable-selftests.c: Fix common/ includes.
7413         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7414         * unittests/memrange-selftests.c: Fix common/ includes.
7415         * unittests/memory-map-selftests.c: Fix common/ includes.
7416         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7417         * unittests/function-view-selftests.c: Fix common/ includes.
7418         * unittests/environ-selftests.c: Fix common/ includes.
7419         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7420         * unittests/common-utils-selftests.c: Fix common/ includes.
7421         * unittests/cli-utils-selftests.c: Fix common/ includes.
7422         * unittests/array-view-selftests.c: Fix common/ includes.
7423         * ui-file.c: Fix common/ includes.
7424         * tui/tui-io.c: Fix common/ includes.
7425         * tracepoint.h: Fix common/ includes.
7426         * tracepoint.c: Fix common/ includes.
7427         * tracefile-tfile.c: Fix common/ includes.
7428         * top.h: Fix common/ includes.
7429         * top.c: Fix common/ includes.
7430         * thread.c: Fix common/ includes.
7431         * target/waitstatus.h: Fix common/ includes.
7432         * target/waitstatus.c: Fix common/ includes.
7433         * target.h: Fix common/ includes.
7434         * target.c: Fix common/ includes.
7435         * target-memory.c: Fix common/ includes.
7436         * target-descriptions.c: Fix common/ includes.
7437         * symtab.h: Fix common/ includes.
7438         * symfile.c: Fix common/ includes.
7439         * stap-probe.c: Fix common/ includes.
7440         * spu-linux-nat.c: Fix common/ includes.
7441         * sparc-nat.c: Fix common/ includes.
7442         * source.c: Fix common/ includes.
7443         * solib.c: Fix common/ includes.
7444         * solib-target.c: Fix common/ includes.
7445         * ser-unix.c: Fix common/ includes.
7446         * ser-tcp.c: Fix common/ includes.
7447         * ser-pipe.c: Fix common/ includes.
7448         * ser-base.c: Fix common/ includes.
7449         * selftest-arch.c: Fix common/ includes.
7450         * s12z-tdep.c: Fix common/ includes.
7451         * rust-exp.y: Fix common/ includes.
7452         * rs6000-aix-tdep.c: Fix common/ includes.
7453         * riscv-tdep.c: Fix common/ includes.
7454         * remote.c: Fix common/ includes.
7455         * remote-notif.h: Fix common/ includes.
7456         * remote-fileio.h: Fix common/ includes.
7457         * remote-fileio.c: Fix common/ includes.
7458         * regcache.h: Fix common/ includes.
7459         * regcache.c: Fix common/ includes.
7460         * record-btrace.c: Fix common/ includes.
7461         * python/python.c: Fix common/ includes.
7462         * python/py-type.c: Fix common/ includes.
7463         * python/py-inferior.c: Fix common/ includes.
7464         * progspace.h: Fix common/ includes.
7465         * producer.c: Fix common/ includes.
7466         * procfs.c: Fix common/ includes.
7467         * proc-api.c: Fix common/ includes.
7468         * printcmd.c: Fix common/ includes.
7469         * ppc-linux-nat.c: Fix common/ includes.
7470         * parser-defs.h: Fix common/ includes.
7471         * osdata.c: Fix common/ includes.
7472         * obsd-nat.c: Fix common/ includes.
7473         * nat/x86-linux.c: Fix common/ includes.
7474         * nat/x86-linux-dregs.c: Fix common/ includes.
7475         * nat/x86-dregs.h: Fix common/ includes.
7476         * nat/x86-dregs.c: Fix common/ includes.
7477         * nat/ppc-linux.c: Fix common/ includes.
7478         * nat/mips-linux-watch.h: Fix common/ includes.
7479         * nat/mips-linux-watch.c: Fix common/ includes.
7480         * nat/linux-waitpid.c: Fix common/ includes.
7481         * nat/linux-ptrace.h: Fix common/ includes.
7482         * nat/linux-ptrace.c: Fix common/ includes.
7483         * nat/linux-procfs.c: Fix common/ includes.
7484         * nat/linux-personality.c: Fix common/ includes.
7485         * nat/linux-osdata.c: Fix common/ includes.
7486         * nat/linux-namespaces.c: Fix common/ includes.
7487         * nat/linux-btrace.h: Fix common/ includes.
7488         * nat/linux-btrace.c: Fix common/ includes.
7489         * nat/fork-inferior.c: Fix common/ includes.
7490         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7491         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7492         * nat/aarch64-linux.c: Fix common/ includes.
7493         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7494         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7495         * namespace.h: Fix common/ includes.
7496         * mips-linux-tdep.c: Fix common/ includes.
7497         * minsyms.c: Fix common/ includes.
7498         * mi/mi-parse.h: Fix common/ includes.
7499         * mi/mi-main.c: Fix common/ includes.
7500         * mi/mi-cmd-env.c: Fix common/ includes.
7501         * memrange.h: Fix common/ includes.
7502         * memattr.c: Fix common/ includes.
7503         * maint.h: Fix common/ includes.
7504         * maint.c: Fix common/ includes.
7505         * main.c: Fix common/ includes.
7506         * machoread.c: Fix common/ includes.
7507         * location.c: Fix common/ includes.
7508         * linux-thread-db.c: Fix common/ includes.
7509         * linux-nat.c: Fix common/ includes.
7510         * linux-fork.c: Fix common/ includes.
7511         * inline-frame.c: Fix common/ includes.
7512         * infrun.c: Fix common/ includes.
7513         * inflow.c: Fix common/ includes.
7514         * inferior.h: Fix common/ includes.
7515         * inferior.c: Fix common/ includes.
7516         * infcmd.c: Fix common/ includes.
7517         * inf-ptrace.c: Fix common/ includes.
7518         * inf-child.c: Fix common/ includes.
7519         * ia64-linux-nat.c: Fix common/ includes.
7520         * i387-tdep.c: Fix common/ includes.
7521         * i386-tdep.c: Fix common/ includes.
7522         * i386-linux-tdep.c: Fix common/ includes.
7523         * i386-linux-nat.c: Fix common/ includes.
7524         * i386-go32-tdep.c: Fix common/ includes.
7525         * i386-fbsd-tdep.c: Fix common/ includes.
7526         * i386-fbsd-nat.c: Fix common/ includes.
7527         * guile/scm-type.c: Fix common/ includes.
7528         * guile/guile.c: Fix common/ includes.
7529         * go32-nat.c: Fix common/ includes.
7530         * gnu-nat.c: Fix common/ includes.
7531         * gdbthread.h: Fix common/ includes.
7532         * gdbarch-selftests.c: Fix common/ includes.
7533         * gdb_usleep.c: Fix common/ includes.
7534         * gdb_select.h: Fix common/ includes.
7535         * gdb_bfd.c: Fix common/ includes.
7536         * gcore.c: Fix common/ includes.
7537         * fork-child.c: Fix common/ includes.
7538         * findvar.c: Fix common/ includes.
7539         * fbsd-nat.c: Fix common/ includes.
7540         * event-top.c: Fix common/ includes.
7541         * event-loop.c: Fix common/ includes.
7542         * dwarf2read.c: Fix common/ includes.
7543         * dwarf2loc.c: Fix common/ includes.
7544         * dwarf2-frame.c: Fix common/ includes.
7545         * dwarf-index-cache.c: Fix common/ includes.
7546         * dtrace-probe.c: Fix common/ includes.
7547         * disasm-selftests.c: Fix common/ includes.
7548         * defs.h: Fix common/ includes.
7549         * csky-tdep.c: Fix common/ includes.
7550         * cp-valprint.c: Fix common/ includes.
7551         * cp-support.h: Fix common/ includes.
7552         * cp-support.c: Fix common/ includes.
7553         * corelow.c: Fix common/ includes.
7554         * completer.h: Fix common/ includes.
7555         * completer.c: Fix common/ includes.
7556         * compile/compile.c: Fix common/ includes.
7557         * compile/compile-loc2c.c: Fix common/ includes.
7558         * compile/compile-cplus-types.c: Fix common/ includes.
7559         * compile/compile-cplus-symbols.c: Fix common/ includes.
7560         * command.h: Fix common/ includes.
7561         * cli/cli-dump.c: Fix common/ includes.
7562         * cli/cli-cmds.c: Fix common/ includes.
7563         * charset.c: Fix common/ includes.
7564         * build-id.c: Fix common/ includes.
7565         * btrace.h: Fix common/ includes.
7566         * btrace.c: Fix common/ includes.
7567         * breakpoint.h: Fix common/ includes.
7568         * breakpoint.c: Fix common/ includes.
7569         * ax.h:
7570         (enum agent_op): Fix common/ includes.
7571         * ax-general.c (struct aop_map): Fix common/ includes.
7572         * ax-gdb.c: Fix common/ includes.
7573         * auxv.c: Fix common/ includes.
7574         * auto-load.c: Fix common/ includes.
7575         * arm-tdep.c: Fix common/ includes.
7576         * arch/riscv.c: Fix common/ includes.
7577         * arch/ppc-linux-common.c: Fix common/ includes.
7578         * arch/i386.c: Fix common/ includes.
7579         * arch/arm.c: Fix common/ includes.
7580         * arch/arm-linux.c: Fix common/ includes.
7581         * arch/arm-get-next-pcs.c: Fix common/ includes.
7582         * arch/amd64.c: Fix common/ includes.
7583         * arch/aarch64.c: Fix common/ includes.
7584         * arch/aarch64-insn.c: Fix common/ includes.
7585         * arch-utils.c: Fix common/ includes.
7586         * amd64-windows-tdep.c: Fix common/ includes.
7587         * amd64-tdep.c: Fix common/ includes.
7588         * amd64-sol2-tdep.c: Fix common/ includes.
7589         * amd64-obsd-tdep.c: Fix common/ includes.
7590         * amd64-nbsd-tdep.c: Fix common/ includes.
7591         * amd64-linux-tdep.c: Fix common/ includes.
7592         * amd64-linux-nat.c: Fix common/ includes.
7593         * amd64-fbsd-tdep.c: Fix common/ includes.
7594         * amd64-fbsd-nat.c: Fix common/ includes.
7595         * amd64-dicos-tdep.c: Fix common/ includes.
7596         * amd64-darwin-tdep.c: Fix common/ includes.
7597         * agent.c: Fix common/ includes.
7598         * ada-lang.h: Fix common/ includes.
7599         * ada-lang.c: Fix common/ includes.
7600         * aarch64-tdep.c: Fix common/ includes.
7601
7602 2019-01-25  Tom Tromey  <tom@tromey.com>
7603
7604         * common/create-version.sh: Use common/version.h.
7605
7606 2019-01-24  Pedro Alves  <palves@redhat.com>
7607
7608         * infrun.c (signal_stop, signal_print, signal_program)
7609         (signal_catch, signal_pass): Now arrays instead of pointers.
7610         (update_signals_program_target, do_target_resume)
7611         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7612         * linux-nat.c (linux_nat_target::pass_signals)
7613         (linux_nat_target::create_inferior, linux_nat_target::attach):
7614         Adjust.
7615         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7616         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7617         * procfs.c (procfs_target::pass_signals): Adjust.
7618         * record-full.c (record_full_target::resume): Adjust.
7619         * remote.c (remote_target::pass_signals)
7620         (remote_target::program_signals): Adjust.
7621         * target-debug.h (target_debug_print_signals): Now takes a
7622         gdb::array_view as parameter.  Adjust.
7623         * target.h (target_ops) <pass_signals, program_signals>: Replace
7624         pointer and length parameters with gdb::array_view.
7625         (target_pass_signals, target_program_signals): Likewise.
7626         * target-delegates.c: Regenerate.
7627
7628 2019-01-24  Pedro Alves  <palves@redhat.com>
7629
7630         * common/forward-scope-exit.h
7631         (forward_scope_exit::forward_scope_exit): Pass arguments to
7632         m_bind_function directly, instead of creating a std::bind and
7633         copying that.
7634
7635 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7636
7637         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7638         for static members.
7639         (pass_in_v_vfp_candidate): Likewise.
7640
7641 2019-01-23  Tom Tromey  <tom@tromey.com>
7642             Pedro Alves  <palves@redhat.com>
7643
7644         * regcache.c (class regcache_invalidator): Remove.
7645         (regcache::raw_write): Use make_scope_exit.
7646
7647 2019-01-23  Tom Tromey  <tom@tromey.com>
7648
7649         * ui-out.h (class ui_out_emit_type): Update comment.
7650
7651 2019-01-23  Tom Tromey  <tom@tromey.com>
7652
7653         * infrun.c (fetch_inferior_event): Update comment.
7654
7655 2019-01-23  Tom Tromey  <tom@tromey.com>
7656             Pedro Alves  <palves@redhat.com>
7657
7658         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7659         parameter.
7660         (fetch_inferior_event): Use SCOPE_EXIT.
7661
7662
7663 2019-01-23  Tom Tromey  <tom@tromey.com>
7664             Pedro Alves  <palves@redhat.com>
7665
7666         * infrun.c (disable_thread_events): Delete.
7667         (stop_all_threads): Use SCOPE_EXIT.
7668
7669 2019-01-23  Tom Tromey  <tom@tromey.com>
7670             Pedro Alves  <palves@redhat.com>
7671
7672         * symfile.c: Include forward-scope-exit.h.
7673         (clear_symtab_users_cleanup): Replace forward declaration with
7674         a FORWARD_SCOPE_EXIT.
7675         (syms_from_objfile_1): Use the forward_scope_exit and
7676         gdb::optional instead of cleanup_function.
7677         (reread_symbols): Use the forward_scope_exit instead of
7678         cleanup_function.
7679         (clear_symtab_users_cleanup): Remove function.
7680
7681 2019-01-23  Tom Tromey  <tom@tromey.com>
7682             Pedro Alves  <palves@redhat.com>
7683
7684         * linux-nat.c: Include scope-exit.h.
7685         (cleanup_target_stop): Remove.
7686         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7687         SCOPE_EXIT.
7688
7689 2019-01-23  Tom Tromey  <tom@tromey.com>
7690             Pedro Alves  <palves@redhat.com>
7691
7692         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7693         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7694
7695 2019-01-23  Tom Tromey  <tom@tromey.com>
7696             Andrew Burgess  <andrew.burgess@embecosm.com>
7697             Pedro Alves  <palves@redhat.com>
7698
7699         * infrun.c (fetch_inferior_event): Use scope_exit.
7700         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7701         * top.c (execute_command): Use scope_exit.
7702         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7703         * utils.c (do_bpstat_clear_actions_cleanup)
7704         (make_bpstat_clear_actions_cleanup): Remove.
7705
7706 2019-01-23  Tom Tromey  <tom@tromey.com>
7707             Pedro Alves  <palves@redhat.com>
7708
7709         * infrun.c: Include "common/scope-exit.h"
7710         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7711         (wait_for_inferior): Use SCOPE_EXIT.
7712         (fetch_inferior_event): Use scope_exit.
7713
7714 2019-01-23  Tom Tromey  <tom@tromey.com>
7715             Pedro Alves  <palves@redhat.com>
7716
7717         * breakpoint.c (create_breakpoint): Remove cleanup.
7718
7719 2019-01-23  Tom Tromey  <tom@tromey.com>
7720             Andrew Burgess  <andrew.burgess@embecosm.com>
7721             Pedro Alves  <palves@redhat.com>
7722
7723 2019-01-23  Pedro Alves  <palves@redhat.com>
7724
7725         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7726
7727 2019-01-23  Pedro Alves  <palves@redhat.com>
7728             Andrew Burgess  <andrew.burgess@embecosm.com>
7729
7730         * gdbthread.h: Include "common/forward-scope-exit.h".
7731         (scoped_finish_thread_state): Redefine custom class in terms of
7732         forward_scope_exit.
7733
7734 2019-01-23  Pedro Alves  <palves@redhat.com>
7735             Andrew Burgess  <andrew.burgess@embecosm.com>
7736
7737         * common/forward-scope-exit.h: New file.
7738
7739 2019-01-23  Pedro Alves  <palves@redhat.com>
7740             Andrew Burgess  <andrew.burgess@embecosm.com>
7741             Tom Tromey  <tom@tromey.com>
7742
7743         * common/scope-exit.h: New file.
7744
7745 2019-01-23  Pedro Alves  <palves@redhat.com>
7746
7747         * common/preprocessor.h (ESC): Rename to ...
7748         (ESC_PARENS): ... this.
7749         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7750         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7751
7752 2019-01-23  Tom Tromey  <tom@tromey.com>
7753
7754         * language.h (class scoped_switch_to_sym_language_if_auto):
7755         Initialize m_lang in both cases.
7756
7757 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7758
7759         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7760         with XCNEW.
7761
7762 2019-01-22  Tom Tromey  <tom@tromey.com>
7763
7764         * corelow.c: Do not include sys/file.h.
7765
7766 2019-01-22  Tom Tromey  <tom@tromey.com>
7767
7768         * tui/tui-wingeneral.h: Include gdb_curses.h.
7769
7770 2019-01-22  Tom Tromey  <tom@tromey.com>
7771
7772         * source-cache.h (class source_cache) <get_source_lines,
7773         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7774
7775 2019-01-22  Tom Tromey  <tom@tromey.com>
7776
7777         * remote-fileio.h (struct remote_target): Declare.
7778
7779 2019-01-22  Tom Tromey  <tom@tromey.com>
7780
7781         * python/py-arch.c: Do not include py-ref.h.
7782         * python/py-bpevent.c: Do not include py-ref.h.
7783         * python/py-cmd.c: Do not include py-ref.h.
7784         * python/py-continueevent.c: Do not include py-ref.h.
7785         * python/py-event.h: Do not include py-ref.h.
7786         * python/py-evtregistry.c: Do not include py-ref.h.
7787         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7788         * python/py-frame.c: Do not include py-ref.h.
7789         * python/py-framefilter.c: Do not include py-ref.h.
7790         * python/py-function.c: Do not include py-ref.h.
7791         * python/py-infevents.c: Do not include py-ref.h.
7792         * python/py-linetable.c: Do not include py-ref.h.
7793         * python/py-objfile.c: Do not include py-ref.h.
7794         * python/py-param.c: Do not include py-ref.h.
7795         * python/py-prettyprint.c: Do not include py-ref.h.
7796         * python/py-progspace.c: Do not include py-ref.h.
7797         * python/py-symbol.c: Do not include py-ref.h.
7798         * python/py-symtab.c: Do not include py-ref.h.
7799         * python/py-type.c: Do not include py-ref.h.
7800         * python/py-unwind.c: Do not include py-ref.h.
7801         * python/py-utils.c: Do not include py-ref.h.
7802         * python/py-value.c: Do not include py-ref.h.
7803         * python/py-varobj.c: Do not include py-ref.h.
7804         * python/py-xmethods.c: Do not include py-ref.h.
7805         * python/python.c: Do not include py-ref.h.
7806         * varobj.c: Do not include py-ref.h.
7807
7808 2019-01-22  Tom Tromey  <tom@tromey.com>
7809
7810         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7811         keyword for bcache.
7812
7813 2019-01-22  Tom Tromey  <tom@tromey.com>
7814
7815         * compile/compile-cplus-types.c: Remove a comment by #include.
7816
7817 2019-01-22  Tom Tromey  <tom@tromey.com>
7818
7819         * compile/gcc-c-plugin.h: Include compile-internal.h.
7820
7821 2019-01-22  Tom Tromey  <tom@tromey.com>
7822
7823         * stabsread.c (EXTERN): Do not define.
7824         (symnum, next_symbol_text_func, processing_gcc_compilation)
7825         (within_function, global_sym_chain, global_stabs)
7826         (previous_stab_code, this_object_header_files)
7827         (n_this_object_header_files)
7828         (n_allocated_this_object_header_files): Define.
7829         * stabsread.h (EXTERN): Never define.  Use "extern".
7830
7831 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7832
7833         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7834         history_value.
7835
7836 2019-01-21  Tom Tromey  <tom@tromey.com>
7837
7838         * ui-out.c: Fix includes.
7839         * tui/tui-source.c: Fix includes.
7840         * target.c: Fix includes.
7841         * remote.c: Fix includes.
7842         * regcache.c: Fix includes.
7843         * python/py-block.c: Fix includes.
7844         * printcmd.c: Fix includes.
7845         * or1k-tdep.c: Fix includes.
7846         * mi/mi-main.c: Fix includes.
7847         * m32r-tdep.c: Fix includes.
7848         * csky-tdep.c: Fix includes.
7849         * compile/compile-cplus-types.c: Fix includes.
7850         * cli/cli-interp.c: Fix includes.
7851
7852 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7853
7854         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7855         for padding.
7856
7857 2019-01-16  Tom Tromey  <tom@tromey.com>
7858
7859         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7860         earlier.
7861         (struct objfile) <msymbols_range>: Move from top level.
7862         <msymbols>: New method.
7863         (class objfile_msymbols): Remove.
7864         * symtab.c (default_collect_symbol_completion_matches_break_on):
7865         Update.
7866         * symmisc.c (dump_msymbols): Update.
7867         * stabsread.c (scan_file_globals): Update.
7868         * objc-lang.c (info_selectors_command, info_classes_command)
7869         (find_methods): Update.
7870         * minsyms.c (find_solib_trampoline_target): Update.
7871         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7872         * coffread.c (coff_symfile_read): Update.
7873         * ada-lang.c (ada_lookup_simple_minsym)
7874         (ada_collect_symbol_completion_matches): Update.
7875
7876 2019-01-16  Tom Tromey  <tom@tromey.com>
7877
7878         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7879         type.  Remove no-argument constructor.
7880         <iterator::operator++>: Simplify.
7881         <begin>: Update.
7882         <end>: Use minimal_symbol_count.
7883
7884 2019-01-16  Tom Tromey  <tom@tromey.com>
7885
7886         * objfiles.h (struct objfile) <psymtabs>: New method.
7887         (class objfile_psymtabs): Remove.
7888         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7889         typedef.
7890         <range>: New method.
7891         (require_partial_symbols): Change return type.
7892         * psymtab.c (require_partial_symbols)
7893         (psym_expand_symtabs_matching): Update.
7894         * mdebugread.c (parse_partial_symbols): Update.
7895         * dbxread.c (dbx_end_psymtab): Update.
7896
7897 2019-01-15  Tom Tromey  <tom@tromey.com>
7898
7899         * symtab.c (lookup_objfile_from_block)
7900         (lookup_symbol_in_objfile_symtabs)
7901         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7902         (find_line_symtab, info_sources_command)
7903         (default_collect_symbol_completion_matches_break_on)
7904         (make_source_files_completion_list): Update.
7905         * symmisc.c (print_objfile_statistics, dump_objfile)
7906         (maintenance_print_symbols, maintenance_info_symtabs)
7907         (maintenance_check_symtabs, maintenance_info_line_tables):
7908         Update.
7909         * source.c (select_source_symtab)
7910         (forget_cached_source_info_for_objfile): Update.
7911         * objfiles.h (class objfile_compunits): Remove.
7912         (struct objfile) <compunits_range>: New typedef.
7913         (compunits): New method.
7914         * objfiles.c (objfile_relocate1): Update.
7915         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7916         * maint.c (count_symtabs_and_blocks): Update.
7917         * linespec.c (iterate_over_all_matching_symtabs): Update.
7918         * cp-support.c (add_symbol_overload_list_qualified): Update.
7919         * coffread.c (coff_symtab_read): Update.
7920         * ada-lang.c (add_nonlocal_symbols)
7921         (ada_collect_symbol_completion_matches)
7922         (ada_add_global_exceptions): Update.
7923
7924 2019-01-15  Tom Tromey  <tom@tromey.com>
7925
7926         * progspace.h (program_space) <objfiles_safe_range>: New
7927         typedef.
7928         <objfiles_safe>: New method.
7929         * objfiles.h (class all_objfiles_safe): Remove.
7930         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7931         * jit.c (jit_inferior_exit_hook): Update.
7932
7933 2019-01-17  Tom Tromey  <tom@tromey.com>
7934
7935         * progspace.h (program_space) <objfiles_range>: New typedef.
7936         <objfiles>: New method.
7937         <objfiles_head>: Rename from objfiles.
7938         (object_files): Update.
7939         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7940         * guile/scm-pretty-print.c
7941         (ppscm_find_pretty_printer_from_objfiles): Update.
7942         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7943         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7944         Update.
7945         * python/py-progspace.c (pspy_get_objfiles): Update.
7946         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7947         Update.
7948         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7949         (objfpy_lookup_objfile_by_build_id): Update.
7950         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7951         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7952         Update.
7953         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7954         (expand_symtab_containing_pc, lookup_objfile_from_block)
7955         (lookup_static_symbol, basic_lookup_transparent_type)
7956         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7957         (find_line_symtab, info_sources_command)
7958         (default_collect_symbol_completion_matches_break_on)
7959         (make_source_files_completion_list, find_main_name): Update.
7960         * symmisc.c (print_symbol_bcache_statistics)
7961         (print_objfile_statistics, maintenance_print_symbols)
7962         (maintenance_print_msymbols, maintenance_print_objfiles)
7963         (maintenance_info_symtabs, maintenance_check_symtabs)
7964         (maintenance_expand_symtabs, maintenance_info_line_tables):
7965         Update.
7966         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7967         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7968         (map_overlay_command, unmap_overlay_command)
7969         (simple_overlay_update, expand_symtabs_matching)
7970         (map_symbol_filenames): Update.
7971         * symfile-debug.c (set_debug_symfile): Update.
7972         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7973         Update.
7974         * source.c (select_source_symtab, forget_cached_source_info):
7975         Update.
7976         * solib.c (solib_read_symbols): Update.
7977         * solib-spu.c (append_ocl_sos): Update.
7978         * psymtab.c (maintenance_print_psymbols)
7979         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7980         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7981         * printcmd.c (info_symbol_command): Update.
7982         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7983         Update.
7984         * objfiles.h (class all_objfiles): Remove.
7985         * objfiles.c (have_partial_symbols, have_full_symbols)
7986         (have_minimal_symbols, qsort_cmp, update_section_map)
7987         (shared_objfile_contains_address_p)
7988         (default_iterate_over_objfiles_in_search_order): Update.
7989         * objc-lang.c (info_selectors_command, info_classes_command)
7990         (find_methods): Update.
7991         * minsyms.c (find_solib_trampoline_target): Update.
7992         * maint.c (maintenance_info_sections)
7993         (maintenance_translate_address, count_symtabs_and_blocks):
7994         Update.
7995         * main.c (captured_main_1): Update.
7996         * linux-thread-db.c (try_thread_db_load_from_pdir)
7997         (has_libpthread): Update.
7998         * linespec.c (iterate_over_all_matching_symtabs)
7999         (search_minsyms_for_name): Update.
8000         * jit.c (jit_find_objf_with_entry_addr): Update.
8001         * hppa-tdep.c (find_unwind_entry)
8002         (hppa_lookup_stub_minimal_symbol): Update.
8003         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8004         Update.
8005         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8006         (elf_gnu_ifunc_resolve_by_got): Update.
8007         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8008         * dwarf-index-write.c (save_gdb_index_command): Update.
8009         * cp-support.c (add_symbol_overload_list_qualified): Update.
8010         * breakpoint.c (create_overlay_event_breakpoint)
8011         (create_longjmp_master_breakpoint)
8012         (create_std_terminate_master_breakpoint)
8013         (create_exception_master_breakpoint): Update.
8014         * blockframe.c (find_pc_partial_function): Update.
8015         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8016         (ada_collect_symbol_completion_matches)
8017         (ada_add_global_exceptions): Update.
8018
8019 2019-01-17  Tom Tromey  <tom@tromey.com>
8020
8021         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8022         declare VEC.
8023         (solib_target_parse_libraries): Change return type.
8024         (library_list_start_segment, library_list_start_section)
8025         (library_list_end_library, library_list_start_library); Update.
8026         (solib_target_free_library_list): Remove.
8027         (solib_target_parse_libraries): Remove cleanup.  Change return
8028         type.
8029         (solib_target_current_sos): Update.
8030
8031 2019-01-17  Tom Tromey  <tromey@bapiya>
8032
8033         * valprint.c: Replace "the the" with "the".
8034         * symtab.c: Replace "the the" with "the".
8035         * solib.c: Replace "the the" with "the".
8036         * solib-dsbt.c: Replace "the the" with "the".
8037         * linespec.c: Replace "the the" with "the".
8038         * dwarf2loc.h: Replace "the the" with "the".
8039         * amd64-windows-tdep.c: Replace "the the" with "the".
8040         * aarch64-tdep.c: Replace "the the" with "the".
8041
8042 2019-01-16  Keith Seitz  <keiths@redhat.com>
8043
8044         PR gdb/23773
8045         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8046         <builder>: Rename to ..
8047         <m_builder>: ... this and make private.
8048         (dwarf2_cu::get_builder): New method.  Change all users of
8049         `builder' to use this method.
8050         (dwarf2_start_symtab): Move to ...
8051         (dwarf2_cu::start_symtab): ... here.  Update all callers
8052         (setup_type_unit_groups): Move to ...
8053         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8054         callers.
8055         (dwarf2_cu::reset_builder): New method.
8056         (process_full_compunit, process_full_type_unit): Use
8057         dwarf2_cu::reset_builder.
8058         (follow_die_offset): Record the ancestor CU if it is different
8059         from the followed DIE's CU.
8060         (follow_die_sig_1): Likewise.
8061
8062 2019-01-15  Tom Tromey  <tom@tromey.com>
8063
8064         * remote.c (class remote_state) <buf>: Now a char_vector.
8065         <buf_size>: Remove.
8066         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8067         parameter.
8068         (remote_target::getpkt_or_notif_sane_1)
8069         (remote_target::getpkt_sane)
8070         (remote_target::getpkt_or_notif_sane): Likewise.
8071         (class remote_target) <putpkt>: New overload.
8072         (remote_target::read_frame): Change type of "buf_p".  Remove
8073         sizeof_p parameter.
8074         (packet_ok): New overload.
8075         (packet_check_result): New overload.
8076         Update all uses.
8077
8078 2019-01-14  Tom Tromey  <tom@tromey.com>
8079
8080         * remote-notif.c (handle_notification, remote_notif_ack)
8081         (remote_notif_parse): Make "buf" const.
8082         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8083         const.
8084         (remote_notif_parse, remote_notif_ack, handle_notification):
8085         Likewise.
8086         * remote.c (remote_notif_stop_parse): Make "buf" const.
8087         (remote_target::remote_parse_stop_reply): Make "buf" const.
8088         (remote_notif_stop_ack): Make "buf" const.
8089
8090 2019-01-14  Tom Tromey  <tom@tromey.com>
8091
8092         * remote.c (remote_console_output): Make parameter const.
8093
8094 2019-01-14  Tom Tromey  <tom@tromey.com>
8095
8096         * target-debug.h (target_debug_print_signals): Constify.
8097         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8098         * procfs.c (procfs_target::pass_signals): Update.
8099         * linux-nat.c (linux_nat_target::pass_signals): Update.
8100         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8101         * target-delegates.c: Rebuild.
8102         * remote.c (remote_target::program_signals): Update.
8103         (remote_target::pass_signals): Update.
8104         * target.c (target_pass_signals): Constify argument.
8105         (target_program_signals): Likewise.
8106         * target.h (struct target_ops) <pass_signals, program_signals>:
8107         Constify argument.
8108         (target_pass_signals, target_program_signals): Constify argument.
8109
8110 2019-01-14  Tom Tromey  <tom@tromey.com>
8111
8112         PR tui/28819:
8113         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8114
8115 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8116
8117         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8118         field.
8119         * rs6000-tdep.c: Include reggroups.h.
8120         (IS_V_ALIAS_PSEUDOREG): Define.
8121         (rs6000_register_name): Return names for the "vX" aliases.
8122         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8123         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8124         aliases.  Call default_register_reggroup_p for all other
8125         pseudo-registers.
8126         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8127         New functions.
8128         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8129         Handle "vX" aliases.
8130         (v_alias_pseudo_register_collect): New function.
8131         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8132         (rs6000_gdbarch_init): Initialize "vX" aliases as
8133         pseudo-registers.  Restore registration of
8134         rs6000_pseudo_register_reggroup_p with
8135         set_tdesc_pseudo_register_reggroup_p.
8136
8137 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8138
8139         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8140         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8141         set_gdbarch_num_pseudo_regs.
8142
8143 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8144
8145         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8146         Remove arg prefixname, add do_set and do_show.
8147         Add member functions set_list and show_list.
8148         * cli/cli-style.c (class cli_style_option): Update accordingly.
8149         (style_set_list): Move to file scope.
8150         (style_show_list): Likewise.
8151         (set_style): Call help_list.
8152         (show_style): Call cmd_show_list.
8153         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8154         Update to use the new macro.
8155
8156 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8157
8158         * ada-lang.c (_initialize_ada_language): Expand the help text
8159         for the "catch exception" command.
8160
8161 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8162
8163         * symtab.c (matching_obj_sections): Initialize obj,
8164         declare it closer to its usage.
8165
8166 2019-01-10  Tom Tromey  <tom@tromey.com>
8167
8168         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8169         (basic_inf_threads_range): Remove.
8170         (inf_threads_range, inf_non_exited_threads_range)
8171         (safe_inf_threads_range): Use next_adapter.
8172
8173 2019-01-10  Keith Seitz  <keiths@redhat.com>
8174
8175         PR gdb/23712
8176         PR symtab/23010
8177         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8178         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8179
8180 2019-01-10  Keith Seitz  <keiths@redhat.com>
8181
8182         PR gdb/23712
8183         PR symtab/23010
8184         * dictionary.c (pending_to_vector): Remove.
8185         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8186         Remove _1 suffix, replacing functions of the same name.  Update
8187         all callers.
8188         (dict_create_hashed, dict_create_hashed_expandable)
8189         (dict_create_linear, dict_create_linear_expandable, dict_free)
8190         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8191         Make functions static.
8192
8193 2019-01-10  Keith Seitz  <keiths@redhat.com>
8194
8195         PR gdb/23712
8196         PR symtab/23010
8197         * dictionary.h (struct dictionary): Replace declaration with
8198         multidictionary.
8199         (dict_create_hashed, dict_create_hashed_expandable)
8200         (dict_create_linear, dict_create_linear_expandable)
8201         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8202         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8203         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8204         taking multidictionary argument.
8205         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8206         * block.h (struct block) <dict>: Change to multidictionary
8207         and rename `multidict'.
8208         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8209         symmisc.c: Update all dictionary references to multidictionary.
8210
8211 2019-01-10  Keith Seitz  <keiths@redhat.com>
8212
8213         PR gdb/23712
8214         PR symtab/23010
8215         * dictionary.c: Include unordered_map.
8216         (pending_to_vector): New function.
8217         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8218         Rewrite the non-"_1" functions to take vector instead
8219         of linked list.
8220         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8221         "new" _1 versions of the same name.
8222         (multidictionary): Define.
8223         (std::hash<enum language): New definition.
8224         (collate_pending_symbols_by_language, mdict_create_hashed)
8225         (mdict_create_hashed_expandable, mdict_create_linear)
8226         (mdict_create_linear_expandable, mdict_free)
8227         (find_language_dictionary, create_new_language_dictionary)
8228         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8229         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8230         (mdict_size, mdict_empty): New functions.
8231         * dictionary.h (mdict_iterator): Define.
8232
8233 2019-01-10  Pedro Alves  <palves@redhat.com>
8234
8235         * breakpoint.c (read_uploaded_action)
8236         (create_tracepoint_from_upload): Adjust to use
8237         gdb::unique_xmalloc_ptr.
8238         * ctf.c (ctf_write_uploaded_tp):
8239         (SET_ARRAY_FIELD): Use emplace_back.
8240         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8241         * tracefile-tfile.c (tfile_write_uploaded_tp):
8242         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8243         gdb::unique_xmalloc_ptr.
8244         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8245         at_string, cond_string, cmd_strings>: Replace char pointers
8246         with gdb::unique_xmalloc_ptr.
8247
8248 2019-01-10  Pedro Alves  <palves@redhat.com>
8249
8250         * solib-target.c (library_list_start_library): Don't xstrdup name.
8251
8252 2019-01-10  Pedro Alves  <palves@redhat.com>
8253
8254         * mdebugread.c (parse_partial_symbols): Use
8255         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8256
8257 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8258
8259         * linux-fork.c (scoped_switch_fork_info)
8260         <~scoped_switch_fork_info>: Fix incorrect variable name.
8261
8262 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8263
8264         * linux-fork.c (scoped_switch_fork_info)
8265         <scoped_switch_fork_info>: Make explicit.
8266         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8267
8268 2019-01-10  Tom Tromey  <tom@tromey.com>
8269
8270         * objfiles.h (objfile::reset_psymtabs): Update.
8271         * objfiles.c (objfile::objfile): Update.
8272         * psymtab.h (psymtab_storage::obstack): Update.
8273         (psymtab_storage::m_obstack): Use gdb::optional.
8274         (class psymtab_storage): Update comment.  Remove objfile
8275         parameter.
8276         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8277
8278 2019-01-10  Tom Tromey  <tom@tromey.com>
8279
8280         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8281         <free_psymtabs>: Now private.
8282         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8283         (allocate_psymtab): Use new method.
8284
8285 2019-01-10  Tom Tromey  <tom@tromey.com>
8286
8287         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8288         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8289         * mdebugread.c (parse_partial_symbols): Use
8290         allocate_dependencies.
8291         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8292         allocate_dependencies.
8293         (process_psymtab_comp_unit_reader)
8294         (build_type_psymtab_dependencies): Likewise.
8295         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8296
8297 2019-01-10  Tom Tromey  <tom@tromey.com>
8298
8299         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8300         PSYMBOL_SET_LANGUAGE.
8301         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8302
8303 2019-01-10  Tom Tromey  <tom@tromey.com>
8304
8305         * psymtab.h (psymtab_storage::obstack): New method.
8306         <m_obstack>: Rename from obstack; now private.
8307         * psymtab.c (psymtab_storage): Update.
8308         * dwarf2read.c (create_addrmap_from_index)
8309         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8310         Update.
8311
8312 2019-01-10  Tom Tromey  <tom@tromey.com>
8313
8314         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8315         * objfiles.h (objfile::reset_psymtabs): New method.
8316
8317 2019-01-10  Tom Tromey  <tom@tromey.com>
8318
8319         * symmisc.c (print_symbol_bcache_statistics): Update.
8320         (print_objfile_statistics): Update.
8321         * symfile.c (reread_symbols): Update.
8322         * psymtab.h (class psymtab_storage): New.
8323         * psymtab.c (psymtab_storage): New constructor.
8324         (~psymtab_storage): New destructor.
8325         (require_partial_symbols): Update.
8326         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8327         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8328         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8329         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8330         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8331         (start_psymtab_common, end_psymtab_common)
8332         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8333         (allocate_psymtab): Update.
8334         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8335         Update.
8336         (dump_psymtab_addrmap, maintenance_print_psymbols)
8337         (maintenance_check_psymtabs): Update.
8338         (class objfile_psymtabs): Move to objfiles.h.
8339         * psympriv.h (discard_psymtab): Now inline.
8340         (psymtab_discarder::psymtab_discarder): Update.
8341         (psymtab_discarder::~psymtab_discarder): Update.
8342         (ALL_OBJFILE_PSYMTABS): Rewrite.
8343         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8344         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8345         Remove fields.
8346         <partial_symtabs>: New field.
8347         (class objfile_psymtabs): Move from psymtab.h.  Update.
8348         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8349         psymbol_cache.
8350         (objfile::~objfile): Don't destroy psymbol_cache.
8351         * mdebugread.c (parse_partial_symbols): Update.
8352         * dwarf2read.c (create_addrmap_from_index)
8353         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8354         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8355         (add_partial_subprogram, dwarf2_ranges_read): Update.
8356         * dwarf-index-write.c (write_address_map)
8357         (write_one_signatured_type, recursively_write_psymbols)
8358         (class debug_names, class debug_names, write_psymtabs_to_index):
8359         Update.
8360
8361 2019-01-10  Tom Tromey  <tom@tromey.com>
8362
8363         * symtab.h (SYMBOL_SET_NAMES): Update.
8364         (symbol_set_names): Update.
8365         (MSYMBOL_SET_NAMES): Update.
8366         * symtab.c (symbol_set_names): Change argument to be an
8367         objfile_per_bfd_storage.
8368         * psymtab.c (add_psymbol_to_bcache): Update.
8369         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8370
8371 2019-01-10  Tom Tromey  <tom@tromey.com>
8372
8373         * symtab.c (create_demangled_names_hash): Change argument to be an
8374         objfile_per_bfd_storage.
8375         (symbol_set_names): Update.
8376
8377 2019-01-10  Tom Tromey  <tom@tromey.com>
8378
8379         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8380         init_psymbol_list.
8381         * psymtab.c (init_psymbol_list): Do nothing if already called.
8382         * psympriv.h (init_psymbol_list): Add comment.
8383         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8384         init_psymbol_list.
8385         * dbxread.c (dbx_symfile_read): Unconditionally call
8386         init_psymbol_list.
8387
8388 2019-01-10  Tom Tromey  <tom@tromey.com>
8389
8390         * xcoffread.c (scan_xcoff_symtab): Update.
8391         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8392         "where".
8393         * mdebugread.c (parse_partial_symbols)
8394         (handle_psymbol_enumerators): Update.
8395         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8396         * dbxread.c (read_dbx_symtab): Update.
8397         * psympriv.h (psymbol_placement): New enum.
8398         (add_psymbol_to_list): Update.
8399
8400 2019-01-10  Tom Tromey  <tom@tromey.com>
8401
8402         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8403         static_psymbols parameters.
8404         (scan_xcoff_symtab): Update.
8405         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8406         static_psymbols parameters.
8407         * psympriv.h (start_psymtab_common): Update.
8408         * mdebugread.c (parse_partial_symbols): Update.
8409         * dwarf2read.c (create_partial_symtab): Update.
8410         * dbxread.c (read_dbx_symtab): Update.
8411         (start_psymtab): Remove global_psymbols and static_psymbols
8412         parameters.
8413
8414 2019-01-10  Tom Tromey  <tom@tromey.com>
8415
8416         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8417         * psymtab.c (allocate_psymtab): Add comment.
8418         * psympriv.h (allocate_psymtab): Add comment.
8419         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8420         initializations.
8421         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8422
8423 2019-01-10  Tom Tromey  <tom@tromey.com>
8424
8425         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8426         Don't declare.
8427         * mipsread.c: Include mdebugread.h.
8428         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8429         Declare.
8430         * elfread.c: Include mdebugread.h.
8431
8432 2019-01-09  Tom Tromey  <tom@tromey.com>
8433
8434         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8435         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8436         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8437         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8438         (psym_lookup_symbol, psym_find_last_source_symtab)
8439         (psym_forget_cached_source_info, psym_print_stats)
8440         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8441         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8442         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8443         (psym_find_compunit_symtab_by_address)
8444         (maintenance_print_psymbols, maintenance_info_psymtabs)
8445         (maintenance_check_psymtabs): Use ranged for.
8446         * psymtab.h (class objfile_psymtabs): New.
8447         (require_partial_symbols): Return objfile_psymtabs.
8448         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8449
8450 2019-01-09  Tom Tromey  <tom@tromey.com>
8451
8452         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8453         (find_pc_mapped_section, list_overlays_command)
8454         (map_overlay_command, unmap_overlay_command)
8455         (simple_overlay_update): Use all_objfiles.
8456         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8457         * printcmd.c (info_symbol_command): Use all_objfiles.
8458         * objfiles.h (ALL_OBJSECTIONS): Remove.
8459         * maint.c (maintenance_translate_address): Use all_objfiles.
8460         * gcore.c (gcore_create_callback): Use all_objfiles.
8461         (objfile_find_memory_regions): Likewise.
8462
8463 2019-01-09  Tom Tromey  <tom@tromey.com>
8464
8465         * symtab.c (find_line_symtab, info_sources_command)
8466         (make_source_files_completion_list): Use objfile_compunits.
8467         * source.c (select_source_symtab): Use objfile_compunits.
8468         * objfiles.h (struct objfile): Update comment.
8469         (ALL_OBJFILES): Remove.
8470         (ALL_FILETABS): Remove.
8471         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8472         objfile_compunits.
8473
8474 2019-01-09  Tom Tromey  <tom@tromey.com>
8475
8476         * symmisc.c (print_objfile_statistics, dump_objfile)
8477         (maintenance_print_symbols): Use compunit_filetabs.
8478         * source.c (forget_cached_source_info_for_objfile): Use
8479         compunit_filetabs.
8480         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8481         (ALL_FILETABS): Use compunit_filetabs.
8482         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8483         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8484
8485 2019-01-09  Tom Tromey  <tom@tromey.com>
8486
8487         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8488         (compunit_filetabs): New.
8489         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8490         compunit_filetabs.
8491         (info_sources_command, make_source_files_completion_list): Remove
8492         declaration.
8493         * symmisc.c (print_objfile_statistics, dump_objfile)
8494         (maintenance_print_symbols): Remove declaration.
8495         (maintenance_info_symtabs): Use compunit_filetabs.
8496         (maintenance_info_line_tables): Likewise.
8497         * source.c (select_source_symtab): Change local variable name.
8498         (forget_cached_source_info_for_objfile): Remove declaration.
8499         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8500         * objfiles.c (objfile_relocate1): Remove declaration.
8501         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8502         declaration.
8503         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8504         * coffread.c (coff_symtab_read): Remove declaration.
8505         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8506         compunit_filetabs.
8507
8508 2019-01-09  Tom Tromey  <tom@tromey.com>
8509
8510         * symtab.c (lookup_objfile_from_block)
8511         (find_pc_sect_compunit_symtab, search_symbols)
8512         (default_collect_symbol_completion_matches_break_on): Use
8513         objfile_compunits.
8514         * objfiles.h (ALL_COMPUNITS): Remove.
8515         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8516         * cp-support.c (add_symbol_overload_list_qualified): Use
8517         objfile_compunits.
8518         * ada-lang.c (ada_collect_symbol_completion_matches)
8519         (ada_add_global_exceptions): Use objfile_compunits.
8520
8521 2019-01-09  Tom Tromey  <tom@tromey.com>
8522
8523         * source.c (select_source_symtab)
8524         (forget_cached_source_info_for_objfile): Remove declaration.
8525         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8526         declaration.
8527         * maint.c (count_symtabs_and_blocks): Remove declaration.
8528         * cp-support.c (add_symbol_overload_list_qualified): Remove
8529         declaration.
8530         * coffread.c (coff_symtab_read): Remove declaration.
8531         * symtab.c (lookup_symbol_in_objfile_symtabs)
8532         (basic_lookup_transparent_type_1): Use objfile_compunits.
8533         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8534         (info_sources_command, search_symbols)
8535         (default_collect_symbol_completion_matches_break_on)
8536         (make_source_files_completion_list): Remove declaration.
8537         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8538         (ada_collect_symbol_completion_matches)
8539         (ada_add_global_exceptions): Remove declaration.
8540         * linespec.c (iterate_over_all_matching_symtabs): Use
8541         objfile_compunits.
8542         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8543         (class objfile_compunits): New.
8544         (ALL_COMPUNITS): Use objfile_compunits.
8545         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8546         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8547         objfile_compunits.
8548         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8549
8550 2019-01-09  Tom Tromey  <tom@tromey.com>
8551
8552         * symtab.c (search_symbols)
8553         (default_collect_symbol_completion_matches_break_on): Use
8554         objfile_msymbols.
8555         * ada-lang.c (ada_lookup_simple_minsym)
8556         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8557         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8558         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8559         objfile_msymbols.
8560         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8561         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8562         * objc-lang.c (find_methods): Use objfile_msymbols.
8563         (info_selectors_command, info_classes_command): Likewise.
8564         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8565         * objfiles.h (class objfile_msymbols): New.
8566         (ALL_OBJFILE_MSYMBOLS): Remove.
8567         (ALL_MSYMBOLS): Remove.
8568
8569 2019-01-09  Tom Tromey  <tom@tromey.com>
8570
8571         * common/next-iterator.h (next_adapter): Add Iterator template
8572         parameter.
8573         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8574         (class all_objfiles_safe): New.
8575         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8576         * objfiles.c (put_objfile_before): Update comment.
8577         (add_separate_debug_objfile): Likewise.
8578         (free_all_objfiles): Use all_objfiles_safe.
8579         (objfile_purge_solibs): Likewise.
8580
8581 2019-01-09  Tom Tromey  <tom@tromey.com>
8582
8583         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8584         (expand_symtab_containing_pc, lookup_static_symbol)
8585         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8586         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8587         all_objfiles.
8588         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8589         * breakpoint.c (create_overlay_event_breakpoint)
8590         (create_longjmp_master_breakpoint)
8591         (create_std_terminate_master_breakpoint)
8592         (create_exception_master_breakpoint): Use all_objfiles.
8593         * linux-thread-db.c (try_thread_db_load_from_pdir)
8594         (has_libpthread): Use all_objfiles.
8595         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8596         * linespec.c (iterate_over_all_matching_symtabs)
8597         (search_minsyms_for_name): Use all_objfiles.
8598         * maint.c (maintenance_info_sections): Use all_objfiles.
8599         * main.c (captured_main_1): Use all_objfiles.
8600         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8601         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8602         * guile/scm-pretty-print.c
8603         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8604         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8605         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8606         (maintenance_print_msymbols): Use all_objfiles.
8607         * source.c (select_source_symtab): Use all_objfiles.
8608         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8609         * symfile.c (remove_symbol_file_command)
8610         (expand_symtabs_matching, map_symbol_filenames): Use
8611         all_objfiles.
8612         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8613         all_objfiles.
8614         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8615         * objc-lang.c (find_methods): Use all_objfiles.
8616         * objfiles.c (have_partial_symbols, have_full_symbols)
8617         (have_minimal_symbols, qsort_cmp)
8618         (default_iterate_over_objfiles_in_search_order): Use
8619         all_objfiles.
8620         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8621         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8622         (maintenance_check_psymtabs): Use all_objfiles.
8623         (ALL_PSYMTABS): Remove.
8624         * compile/compile-object-run.c (do_module_cleanup): Use
8625         all_objfiles.
8626         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8627         * cp-support.c (add_symbol_overload_list_qualified): Use
8628         all_objfiles.
8629         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8630         Use all_objfiles.
8631         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8632         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8633         all_objfiles.
8634         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8635         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8636         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8637         Uses all_objfiles.
8638         * solib.c (solib_read_symbols): Use all_objfiles
8639
8640 2019-01-09  Tom Tromey  <tom@tromey.com>
8641
8642         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8643         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8644         all_objfiles.
8645         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8646         * symmisc.c (print_symbol_bcache_statistics)
8647         (print_objfile_statistics, maintenance_print_objfiles)
8648         (maintenance_info_symtabs, maintenance_check_symtabs)
8649         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8650         all_objfiles.
8651         * source.c (forget_cached_source_info): Use all_objfiles.
8652         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8653         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8654         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8655         * objfiles.c (update_section_map): Use all_objfiles.
8656         (shared_objfile_contains_address_p): Likewise.
8657         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8658         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8659
8660 2019-01-09  Tom Tromey  <tom@tromey.com>
8661
8662         * common/next-iterator.h: New file.
8663         * objfiles.h (class all_objfiles): New.
8664         (struct objfile_iterator): New.
8665
8666 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8667
8668         * NEWS: Move the description of the changed "frame", "select-frame",
8669          and "info frame" commands to the Changed commands section.
8670
8671 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8672
8673         * gdbtypes.c (check_stub_method_group): Remove handling of old
8674         mangling schemes.
8675         * linespec.c (find_methods): Likewise.
8676         * stabsread.c (read_member_functions): Likewise.
8677         * valops.c (search_struct_method): Likewise.
8678         (value_struct_elt_for_reference): Likewise.
8679         * NEWS: Mention this change.
8680
8681 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8682
8683         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8684         print_source_lines.
8685         * source.c (print_source_lines_base): Update line number check.
8686         (print_source_lines): New function.
8687         (source_lines_range::source_lines_range): New function.
8688         * source.h (class source_lines_range): New class.
8689         (print_source_lines): New declaration.
8690
8691 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8692
8693         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8694
8695 2019-01-08  Tom Tromey  <tom@tromey.com>
8696             Simon Marchi  <simon.marchi@ericsson.com>
8697
8698         PR gdb/24060
8699         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8700         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8701         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8702         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8703         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8704         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8705
8706 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8707
8708         * source.c (select_source_symtab): Move header comment to
8709         declaration in source.h.
8710         (forget_cached_source_info_for_objfile): Likewise.
8711         (forget_cached_source_info): Likewise.
8712         (identify_source_line): Likewise.
8713         * source.h (identify_source_line): Move declaration from symtab.h
8714         and add comment from source.c
8715         (print_source_lines): Likewise.
8716         (forget_cached_source_info_for_objfile): Likewise.
8717         (forget_cached_source_info): Likewise.
8718         (select_source_symtab): Likewise.
8719         (enum print_source_lines_flag): Move definition from symtab.h.
8720         * symtab.h (identify_source_line): Move declaration to source.h.
8721         (print_source_lines): Likewise.
8722         (forget_cached_source_info_for_objfile): Likewise.
8723         (forget_cached_source_info): Likewise.
8724         (select_source_symtab): Likewise.
8725         (enum print_source_lines_flag): Move definition to source.h.
8726         * tui/tui-hooks.c: Add 'source.h' include.
8727
8728 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8729
8730         * source.c (print_source_lines_base): Handle requests to print
8731         reverse line number sequences, and guard against empty lines
8732         string.
8733
8734 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8735
8736         * source.c (print_source_lines_base): Fix skip of '\r' if next
8737         character is '\n'.
8738
8739 2019-01-06  Tom Tromey  <tom@tromey.com>
8740
8741         * c-exp.y (struct c_parse_state) <macro_original_text,
8742         expansion_obstack>: New member.
8743         (macro_original_text, expansion_obstack): Remove globals.
8744         (scan_macro_expansion, scanning_macro_expansion)
8745         (finished_macro_expansion): Update.
8746         (scan_macro_cleanup): Remove.
8747         (yylex, c_parse): Update.
8748
8749 2019-01-06  Tom Tromey  <tom@tromey.com>
8750
8751         * c-exp.y (struct c_parse_state) <strings>: New member.
8752         (operator_stoken): Update.
8753
8754 2019-01-06  Tom Tromey  <tom@tromey.com>
8755
8756         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8757         (union type_stack_elt) <typelist_val>: Now a pointer to
8758         std::vector.
8759         (type_stack_cleanup): Don't declare.
8760         (push_typelist): Update.
8761         * parse.c (pop_typelist): Return a std::vector.
8762         (push_typelist): Take a std::vector.
8763         (follow_types): Update.  Do not free args.
8764         (type_stack_cleanup): Remove.
8765         * c-exp.y (struct c_parse_state): New.
8766         (cpstate): New global.
8767         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8768         (nonempty_typelist): Update.
8769         (func_mod): Create a new vector.
8770         (c_parse): Create a c_parse_state.
8771         (check_parameter_typelist): Do not delete params.
8772         (function_method): Update.  Do not delete type_list.
8773
8774 2019-01-06  Tom Tromey  <tom@tromey.com>
8775
8776         PR gdb/28155:
8777         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8778         check_typedef.
8779         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8780         (print_return_value): Likewise.
8781
8782 2019-01-05  Tom Tromey  <tom@tromey.com>
8783
8784         * contrib/cleanup_check.py: Remove.
8785         * contrib/gcc-with-excheck: Remove.
8786         * contrib/exsummary.py: Remove.
8787         * contrib/excheck.py: Remove.
8788
8789 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8790
8791         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8792         NULL. Initialize tpprev to NULL instead of assigning it
8793         to NULL on the next statement.
8794         * windows-nat.c (windows_delete_thread): Remove check for
8795         main_thread_id before printing thread exit notifications.
8796         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8797         Remove thread ID check against main_thread_id.
8798         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8799         windows_delete_thread.
8800         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8801
8802 2019-01-04  Tom Tromey  <tom@tromey.com>
8803
8804         * compile/compile.c (_initialize_compile): Use upper case for
8805         metasyntactic variables.
8806         * symmisc.c (_initialize_symmisc): Use upper case for
8807         metasyntactic variables.
8808         * psymtab.c (_initialize_psymtab): Use upper case for
8809         metasyntactic variables.
8810         * demangle.c (demangle_command): Use upper case for metasyntactic
8811         variables.
8812         (_initialize_demangler): Likewise.
8813         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8814         variables.
8815
8816 2019-01-03  Tom Tromey  <tom@tromey.com>
8817
8818         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8819
8820 2019-01-03  Tom Tromey  <tom@tromey.com>
8821
8822         * python/py-symtab.c (salpy_str): Update.
8823         (struct salpy_sal_object) <symtab>: Now a PyObject.
8824         (salpy_dealloc): Update.
8825         (del_objfile_sal): Use gdbpy_ref.
8826
8827 2019-01-03  Tom Tromey  <tom@tromey.com>
8828
8829         * python/py-type.c (convert_field): Use new_reference.  Return
8830         gdbpy_ref.
8831         (make_fielditem): Return gdbpy_ref.
8832         (typy_fields): Update.
8833         (typy_getitem): Update.
8834         (field_name): Return gdbpy_ref.  Use new_reference.
8835         (typy_iterator_iternext): Update.
8836
8837 2019-01-03  Tom Tromey  <tom@tromey.com>
8838
8839         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8840
8841 2019-01-03  Tom Tromey  <tom@tromey.com>
8842
8843         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8844         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8845         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8846         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8847         (pspy_set_type_printers): Likewise.
8848         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8849         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8850         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8851         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8852         (objfpy_set_type_printers): Likewise.
8853
8854 2019-01-03  Tom Tromey  <tom@tromey.com>
8855
8856         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8857         (gdbpy_print_stack): Use gdbpy_err_fetch.
8858         * python/python-internal.h (class gdbpy_err_fetch): New class.
8859         (class gdbpy_enter) <m_error_type, m_error_value,
8860         m_error_traceback>: Remove.
8861         <m_error>: New member.
8862         (gdbpy_exception_to_string): Don't declare.
8863         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8864         * python/py-value.c (convert_value_from_python): Use
8865         gdbpy_err_fetch.
8866         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8867         gdbpy_exception_to_string.
8868         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8869         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8870         gdbpy_err_fetch.
8871
8872 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8873
8874         * linux-nat.c (delete_lwp_cleanup): Delete.
8875         (struct lwp_deleter): New struct.
8876         (lwp_info_up): New typedef.
8877         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8878         lwp_info_up.
8879
8880 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8881
8882         * linux-fork.c (class scoped_switch_fork_info): New class.
8883         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8884
8885 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8886
8887         * valops.c (find_overload_match): Remove use of null_cleanup, and
8888         calls to do_cleanups.
8889
8890 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8891
8892         * compile/compile-cplus-types.c
8893         (compile_cplus_instance::decl_name): Handle changes to
8894         cp_func_name.
8895         * cp-support.c (cp_func_name): Update header comment, update
8896         return type.
8897         * cp-support.h (cp_func_name): Update return type in declaration.
8898         * valops.c (find_overload_match): Move temp_func local to top
8899         level of function and change its type.  Use temp_func to hold and
8900         delete temporary string obtained from cp_func_name.
8901
8902 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8903
8904         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8905         gdb::char_vector, remove cleanup, and update uses of `msg`.
8906
8907 2019-01-03  Jim Wilson  <jimw@sifive.com>
8908
8909         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8910
8911 2019-01-02  Tom Tromey  <tom@tromey.com>
8912
8913         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8914         (tdesc_parse_xml): Remove cleanups.
8915         * target-descriptions.h (make_cleanup_free_target_description):
8916         Don't declare.
8917         (target_desc_deleter): New struct.
8918         (target_desc_up): New typedef.
8919         * target-descriptions.c (target_desc_deleter::operator()): Rename
8920         from free_target_description.
8921         (make_cleanup_free_target_description): Remove.
8922
8923 2019-01-02  Tom Tromey  <tom@tromey.com>
8924
8925         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8926         constructor, destructor.
8927         (linespec_parser): Remove typedef.
8928         (~linespec_parser): Rename from linespec_parser_delete.
8929         (linespec_lex_to_end, linespec_complete_label)
8930         (linespec_complete): Update.
8931         (decode_line_full): Remove cleanups.
8932         (decode_line_1): Update.
8933
8934 2019-01-02  Tom Tromey  <tom@tromey.com>
8935
8936         * python/python-internal.h (inferior_to_inferior_object): Change
8937         return type.
8938         * python/py-exitedevent.c (create_exited_event_object): Update.
8939         * python/py-inferior.c (inferior_to_inferior_object): Return
8940         gdbpy_ref.
8941         (python_new_inferior, python_inferior_deleted)
8942         (thread_to_thread_object, delete_thread_object)
8943         (build_inferior_list, gdbpy_selected_inferior): Update.
8944         * python/py-infthread.c (create_thread_object): Update.  Also fail
8945         if inferior_to_inferior_object fails.
8946
8947 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8948
8949         * inferior.h (class inferior) <displaced_step_state>: New field.
8950         * infrun.h (struct displaced_step_state): Move here from
8951         infrun.c.  Initialize fields, add constructor.
8952         <inf>: Remove field.
8953         <reset>: New method.
8954         * infrun.c (struct displaced_step_inferior_state): Move to
8955         infrun.h.
8956         (displaced_step_inferior_states): Remove.
8957         (get_displaced_stepping_state): Adust.
8958         (displaced_step_in_progress_any_inferior): Adjust.
8959         (displaced_step_in_progress_thread): Adjust.
8960         (displaced_step_in_progress): Adjust.
8961         (add_displaced_stepping_state): Remove.
8962         (get_displaced_step_closure_by_addr): Adjust.
8963         (remove_displaced_stepping_state): Remove.
8964         (infrun_inferior_exit): Call displaced_step_state.reset.
8965         (use_displaced_stepping): Don't check for NULL.
8966         (displaced_step_prepare_throw): Call
8967         get_displaced_stepping_state.
8968         (displaced_step_fixup): Don't check for NULL.
8969         (prepare_for_detach): Don't check for NULL.
8970
8971 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8972
8973         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8974          in case of call that did not complete.
8975
8976 2019-01-02  Andrey Utkin  <autkin@undo.io>
8977
8978         * symfile.c (find_separate_debug_file): Fix search of debug files for
8979         remote debuggee.
8980
8981 2019-01-02  Tom Tromey  <tom@tromey.com>
8982
8983         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8984         indentation.
8985         * python/py-frame.c (frapy_older): Remove cast.
8986         (frapy_newer): Likewise.
8987         * python/py-breakpoint.c (local_setattro): Remove cast.
8988         * python/py-arch.c (archpy_name): Remove local variable.
8989         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8990
8991 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8992
8993         * unittests/basic_string_view/element_access/char/empty.cc:
8994         Fix year range in copyright header.
8995
8996 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8997
8998         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8999         Delete.
9000         <operator==>: Update with for removed field.
9001         <hash>: Likewise.
9002         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9003         <isa_features>: ...this.
9004         <abi_features>: New field.
9005         (riscv_isa_flen): Update comment.
9006         (riscv_abi_xlen): New declaration.
9007         (riscv_abi_flen): New declaration.
9008         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9009         isa_features.
9010         (riscv_abi_xlen): New function.
9011         (riscv_isa_flen): Update to get answer from isa_features.
9012         (riscv_abi_flen): New function.
9013         (riscv_has_fp_abi): Update to get answer from abi_features.
9014         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9015         xlen and flen.
9016         (riscv_call_info) <xlen, flen>: Update comment.
9017         (riscv_call_arg_struct): Remove invalid assertions
9018         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9019         is removed.
9020         (riscv_gdbarch_init): Gather isa features and abi features
9021         separately, ensure both match on the gdbarch when reusing an old
9022         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9023         a target with 64-bit float hardware.
9024
9025 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9026
9027         * source.c (search_command_helper): Stop reverse search
9028         when line 1 has been searched.
9029
9030 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9031
9032         * record-full.c (record_full_base_target::close): Rewrite
9033         record_full_core_buf_list free logic.
9034
9035 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9036
9037         * break-catch-syscall.c (print_one_catch_syscall): xfree
9038         the last text.
9039
9040 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9041
9042         * top.c (print_gdb_version): Update Copyright year in version
9043         message.
9044
9045 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9046
9047         Update copyright year range in all GDB files.
9048
9049 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9050
9051         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9052
9053 For older changes see ChangeLog-2018.
9054 \f
9055 Local Variables:
9056 mode: change-log
9057 left-margin: 8
9058 fill-column: 74
9059 version-control: never
9060 coding: utf-8
9061 End:
9062