gdb/ChangeLog

   1 2019-07-03  Pedro Alves  <palves@redhat.com>
   2
   3         * cli/cli-option.c (union option_value) <string>: New field.
   4         (struct option_def_and_value): Add ctor, move ctor, dtor and
   5         use DISABLE_COPY_AND_ASSIGN.
   6         (option_def_and_value::clear_value): New.
   7         (parse_option, save_option_value_in_ctx, get_val_type_str)
   8         (add_setshow_cmds_for_options): Handle var_string.
   9         * cli-option.h (union option_def::var_address) <string>: New
  10         field.
  11         (struct string_option_def): New.
  12         * maint-test-options.c (struct test_options_opts): Add default
  13         ctor and use DISABLE_COPY_AND_ASSIGN.
  14         <string_opt>: New field.
  15         (test_options_opts::~test_options_opts): New.
  16         (test_options_opts::dump): Also dump "-string".
  17         (test_options_option_defs): Install "string.
  18
  19 2019-07-03  Pedro Alves  <palves@redhat.com>
  20
  21         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
  22         option_value with a null enumeration.
  23         (complete_options): Save the option values in the context.
  24         (save_option_value_in_ctx): New, factored out from ...
  25         (process_options): ... here.
  26         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
  27         of the function.
  28         * maint-test-options.c (test_options_opts::dump): New, factored
  29         out from ...
  30         (maintenance_test_options_command_mode): ... here.
  31         (maintenance_test_options_command_completion_result): Delete.
  32         (maintenance_test_options_command_completion_text): Update
  33         comment.
  34         (maintenance_show_test_options_completion_result): Change
  35         prototype.  Just print
  36         maintenance_test_options_command_completion_text.
  37         (save_completion_result): New.
  38         (maintenance_test_options_completer_mode): Pass options context to
  39         complete_options, and then save a dump.
  40         (_initialize_maint_test_options): Use add_cmd to install "maint
  41         show test-options-completion-result".
  42
  43 2019-07-03  Pedro Alves  <palves@redhat.com>
  44
  45         * NEWS (New commands): Mention "with" and "maint with".
  46         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
  47         (with_command, with_command_completer): New.
  48         (pipe_command): Adjust to new repeat_previous
  49         interface.
  50         (_initialize_cli_cmds): Install the "with" command and its "w"
  51         alias.
  52         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
  53         declarations.
  54         * cli/cli-setshow.c (parse_cli_var_uinteger)
  55         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
  56         argument strings for all var_types.
  57         (get_setshow_command_value_string): New, factored out from ...
  58         (do_show_command): ... this.
  59         * cli/cli-setshow.h: Include <string>.
  60         (get_setshow_command_value_string): Declare.
  61         * command.h (repeat_previous): Now returns const char *.  Adjust
  62         comment.
  63         * maint.c: Include "cli/cli-cmds.h".
  64         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
  65         (_initialize_maint_cmds): Register the "maintenance with" command.
  66         * top.c (repeat_previous): Move bits from pipe_command here:
  67         Return the saved command line, if any; error out if there's no
  68         command to relaunch.
  69
  70 2019-07-03  Pedro Alves  <palves@redhat.com>
  71
  72         * NEWS (New commands): Mention "maint set/show test-settings"
  73         instead of "maint test-settings".
  74         * maint-test-settings.c (maintenance_test_settings_list): Delete.
  75         (maintenance_test_settings_set_list): Rename to ...
  76         (maintenance_set_test_settings_list): ... this.
  77         (maintenance_test_settings_show_list): Rename to  ...
  78         (maintenance_show_test_settings_list): ... this.
  79         (maintenance_test_settings_cmd): Delete.
  80         (maintenance_test_settings_set_cmd): ...
  81         (maintenance_set_test_settings_cmd): ... this.
  82         (maintenance_test_settings_show_cmd): ...
  83         (maintenance_show_test_settings_cmd): ... this.
  84         (maintenance_test_settings_show_value_cmd):
  85         (maintenance_show_test_settings_value_cmd): ... this.
  86         (_initialize_maint_test_settings): No longer install the "maint
  87         test-settings" prefix command.  Rename "maint test-settings set"
  88         to "maint set test-settings", and "maint test-settings show" to
  89         "maint show test-settings".  Adjust all subcommands.
  90
  91 2019-07-03  Pedro Alves  <palves@redhat.com>
  92
  93         * maint-test-settings.c: Fix file's intro comment.  Replace all
  94         references to "test-options" with references to "test-settings",
  95         in comments.
  96
  97 2019-07-03  Pedro Alves  <palves@redhat.com>
  98
  99         * maint-test-settings.c (maintenance_test_settings_xxx)
 100         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
 101         New.
 102         (maintenance_test_settings_enums): Use them.
 103         (maintenance_test_settings_enum): Default to
 104         maintenance_test_settings_xxx.
 105         (_initialize_maint_test_settings): Initialize
 106         MAINTENANCE_TEST_SETTINGS_FILENAME.
 107
 108 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 109
 110         * breakpoint.h (remove_breakpoints_inf): Change return type to
 111         void, move function documentation here.
 112         * breakpoint.c (remove_breakpoints_inf): Change return type to
 113         void, move function documentation to header.
 114
 115 2019-07-02  Pedro Alves  <palves@redhat.com>
 116
 117         * NEWS (Completion improvements): Mention "info threads".
 118         * thread.c (struct info_threads_opts, info_threads_option_defs)
 119         (make_info_threads_options_def_group): New.
 120         (info_threads_command): Use gdb::option::process_options.
 121         (info_threads_command_completer): New.
 122         (_initialize_thread): Use gdb::option::build_help to build the
 123         help text for "info threads".
 124
 125 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
 126
 127         * defs.h (generic_load): Move from here...
 128         * symfile.h (generic_load): ... to here.  Rename name parameter
 129         to args.
 130         * symfile.c (generic_load): Add comment.
 131
 132 2019-07-01  Tom Tromey  <tromey@adacore.com>
 133
 134         * dwarf2read.c
 135         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
 136         declaration of without_params.  Fix formatting.
 137
 138 2019-07-01  Tom Tromey  <tromey@adacore.com>
 139
 140         * ada-exp.y (find_primitive_type): Update.
 141         * ada-lang.h (ada_lookup_symbol): Update.
 142         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
 143         parameter.
 144         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
 145
 146 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 147
 148         PR breakpoints/24541
 149         * gdbarch.c: Regenerate.
 150         * gdbarch.h: Regenerate.
 151         * gdbarch.sh: Add 'stap_adjust_register'.
 152         * i386-tdep.c: Include '<unordered_set>'.
 153         (i386_stap_adjust_register): New function.
 154         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
 155         * stap-probe.c (stap_parse_register_operand): Call
 156         'gdbarch_stap_adjust_register'.
 157
 158 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
 159
 160         PR python/24742
 161         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
 162         * python/python.c (do_start_initialization): Use 'xmalloc'
 163         instead of 'PyMem_Malloc'.
 164
 165 2019-06-28  Tom Tromey  <tromey@adacore.com>
 166
 167         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
 168         for Ada.
 169
 170 2019-06-27  Tom Tromey  <tromey@adacore.com>
 171
 172         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
 173         objfile_key.
 174         (arm_find_mapping_symbol, arm_record_special_symbol)
 175         (_initialize_arm_tdep): Update.
 176         (arm_objfile_data_free): Remove.
 177
 178 2019-06-27  Tom Tromey  <tromey@adacore.com>
 179
 180         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
 181         to cp_print_static_field.
 182
 183 2019-06-26  Tom Tromey  <tromey@adacore.com>
 184
 185         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
 186         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
 187         declare.
 188
 189 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 190
 191         * features/aarch64-core.c (create_feature_aarch64_core):
 192         Regenerate.
 193         * features/aarch64-core.xml: Add cpsr flags.
 194
 195 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
 196
 197         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
 198         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
 199
 200 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 201
 202         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
 203         field.
 204         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
 205         use.
 206         (arm_record_special_symbol): Don't insert new symbol in sorted
 207         position, push it at the end.
 208
 209 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
 210
 211         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
 212         (arm_mapping_symbol_s): Remove.
 213         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
 214         (arm_mapping_symbol_vec): New typedef.
 215         (struct arm_per_objfile): Add constructor.
 216         <section_maps>: Change type to
 217         std::unique_ptr<arm_mapping_symbol_vec[]>.
 218         (arm_compare_mapping_symbols): Remove.
 219         (arm_find_mapping_symbol): Adjust to section_maps type change.
 220         (arm_objfile_data_free): Call delete on arm_per_objfile.
 221         (arm_record_special_symbol): Adjust to section_maps type change.
 222         Allocate arm_per_objfile with new.
 223
 224 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 225
 226         * cli/cli-cmds.c (alias_command): Compare the alias prefix
 227         with the command prefix.
 228
 229 2019-06-25  Tom Tromey  <tom@tromey.com>
 230
 231         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
 232         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
 233
 234 2019-06-25  Tom Tromey  <tom@tromey.com>
 235
 236         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
 237         type.
 238         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
 239         protected.
 240
 241 2019-06-25  Tom Tromey  <tom@tromey.com>
 242
 243         * tui/tui-winsource.c
 244         (tui_source_window_base::set_is_exec_point_at): Add check against
 245         LOA_ADDRESS.
 246
 247 2019-06-25  Tom Tromey  <tom@tromey.com>
 248
 249         * tui/tui-source.c (tui_set_source_content): Don't check before
 250         xfree.
 251         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
 252
 253 2019-06-25  Tom Tromey  <tom@tromey.com>
 254
 255         * tui/tui-winsource.h (tui_update_source_window_as_is)
 256         (tui_alloc_source_buffer, tui_line_is_displayed)
 257         (tui_addr_is_displayed): Change type of win_info.
 258         * tui/tui-winsource.c (tui_update_source_window_as_is)
 259         (tui_clear_source_content, tui_show_source_line)
 260         (tui_show_source_content, tui_source_window_base::refill)
 261         (tui_source_window_base::set_is_exec_point_at)
 262         (tui_source_window_base::set_is_exec_point_at)
 263         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
 264         (tui_alloc_source_buffer, tui_line_is_displayed)
 265         (tui_addr_is_displayed): Change type of win_info.  Update.
 266         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 267         (tui_source_window_base::do_make_visible_with_new_height):
 268         Update.
 269         * tui/tui-source.c (tui_set_source_content)
 270         (tui_set_source_content_nil)
 271         (tui_source_window::do_scroll_vertical): Update.
 272         * tui/tui-layout.c (show_layout): Update.
 273         * tui/tui-disasm.c (tui_set_disassem_content)
 274         (tui_disasm_window::do_scroll_vertical): Update.
 275         * tui/tui-data.h (tui_win_content): Remove.
 276         (struct tui_gen_win_info) <content, content_size>: Remove.
 277         (struct tui_source_element): Add initializers and destructor.
 278         (union tui_which_element, struct tui_win_element): Remove.
 279         (struct tui_source_window_base) <content>: New field.
 280         (struct tui_data_window): Remove destructor.
 281         (tui_alloc_content, tui_free_win_content)
 282         (tui_free_all_source_wins_content): Don't declare.
 283         * tui/tui-data.c (tui_initialize_static_data): Update.
 284         (init_content_element, tui_alloc_content): Remove.
 285         (~tui_gen_win_info): Update.
 286         (~tui_data_window, tui_free_all_source_wins_content)
 287         (tui_free_win_content, free_content, free_content_elements):
 288         Remove.
 289
 290 2019-06-25  Tom Tromey  <tom@tromey.com>
 291
 292         * tui/tui-winsource.h (tui_clear_source_content)
 293         (tui_erase_source_content, tui_show_source_content): Change type
 294         of win_info.
 295         * tui/tui-winsource.c (tui_clear_source_content)
 296         (tui_erase_source_content, tui_show_source_content): Change type
 297         of win_info.
 298         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
 299         * tui/tui-source.h (tui_set_source_content_nil): Change type of
 300         win_info.
 301         * tui/tui-source.c (tui_set_source_content_nil): Change type of
 302         win_info.
 303         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
 304
 305 2019-06-25  Tom Tromey  <tom@tromey.com>
 306
 307         * tui/tui-winsource.c (tui_clear_source_content)
 308         (tui_source_window_base::set_is_exec_point_at): Update.
 309         * tui/tui-source.c (tui_set_source_content_nil): Update.
 310         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
 311         a bool.
 312         * tui/tui-data.c (init_content_element): Update.
 313
 314 2019-06-25  Tom Tromey  <tom@tromey.com>
 315
 316         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
 317         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
 318         * tui/tui-layout.c (init_and_make_win): Update.
 319         * tui/tui.h (enum tui_win_type): Update.
 320         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
 321         tui_win_is_auxillary.
 322         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
 323         tui_win_is_auxillary.
 324
 325 2019-06-25  Tom Tromey  <tom@tromey.com>
 326
 327         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
 328         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
 329         (tui_delete_data_content_windows, tui_display_all_data)
 330         (tui_data_window::do_scroll_vertical, tui_display_data_from):
 331         Update.
 332         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
 333         * tui/tui-regs.c (tui_last_regs_line_no)
 334         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 335         (tui_show_registers): Update.
 336         (tui_show_register_group): Return void.  Update.
 337         (tui_display_registers_from, tui_display_reg_element_at_line)
 338         (tui_display_registers_from_line, tui_check_register_values):
 339         Update.
 340         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
 341         member.
 342         (struct tui_data_window) <regs_content>: Now a std::vector.
 343         <regs_content_count>: Remove.
 344         (tui_add_content_elements, tui_free_data_content): Don't declare.
 345         * tui/tui-data.c (tui_data_window::clear_detail): Update.
 346         (init_content_element): Remove DATA_WIN case.  Add assert.
 347         (tui_add_content_elements): Remove.
 348         (tui_data_window): Update.
 349         (tui_free_data_content): Remove.
 350         (free_content_elements): Remove DATA_WIN case.
 351
 352 2019-06-25  Tom Tromey  <tom@tromey.com>
 353
 354         * tui/tui-data.c (tui_data_item_window): Update.
 355         * tui/tui-windata.h (tui_check_data_values): Don't declare.
 356         * tui/tui-windata.c (tui_display_all_data)
 357         (tui_display_data_from_line): Update.
 358         (tui_check_data_values): Remove.
 359         * tui/tui-regs.c (tui_show_register_group)
 360         (tui_display_reg_element_at_line): Update.
 361         * tui/tui-hooks.c (tui_register_changed)
 362         (tui_refresh_frame_and_register_information): Call
 363         tui_check_register_values.
 364         * tui/tui-data.h (struct tui_data_window) <data_content,
 365         data_content_count, data_type>: Remove.
 366         (enum tui_data_type): Remove.
 367
 368         * tui/tui-data.c (tui_data_window::clear_detail)
 369         (~tui_data_window): Update.
 370
 371 2019-06-25  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
 374         declare.
 375         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
 376         Rename from tui_first_data_item_displayed.  Update.
 377         (tui_data_window::refresh_all)
 378         (tui_data_window::do_scroll_vertical): Update.
 379         * tui/tui-data.h (struct tui_data_window)
 380         <first_data_item_displayed>: Declare new method.
 381
 382 2019-06-25  Tom Tromey  <tom@tromey.com>
 383
 384         * tui/tui-data.h (tui_init_generic_part): Don't declare.
 385         * tui/tui-data.c (tui_init_generic_part): Remove, moving
 386         contents...
 387         (tui_initialize_static_data): ...here.
 388
 389 2019-06-25  Tom Tromey  <tom@tromey.com>
 390
 391         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 392         (tui_display_registers_from, tui_check_register_values): Update.
 393         (tui_display_register): Remove win_info parameter; update.
 394         (tui_get_register): Change type of parameters.
 395         * tui/tui-data.h (struct tui_data_element): Remove.
 396         (union tui_which_element) <data>: Remove.
 397         <data_window>: Change type.
 398         (struct tui_data_item_window): New.
 399         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
 400         case.  Add assert.
 401         (~tui_data_item_window): New destructor.
 402         (free_content_elements): Remove DATA_ITEM_WIN case.
 403
 404 2019-06-25  Tom Tromey  <tom@tromey.com>
 405
 406         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
 407         Remove.
 408
 409 2019-06-25  Tom Tromey  <tom@tromey.com>
 410
 411         * tui/tui-data.h (struct tui_command_element): Remove.
 412         (union tui_which_element) <command>: Remove.
 413         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
 414         assert.
 415         (free_content_elements): Remove CMD_WIN case.
 416
 417 2019-06-25  Tom Tromey  <tom@tromey.com>
 418
 419         * tui/tui-layout.c (tui_set_layout): Update.
 420         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
 421         * tui/tui-data.c (layout_def): Update.
 422
 423 2019-06-25  Tom Tromey  <tom@tromey.com>
 424
 425         * tui/tui-wingeneral.c (tui_refresh_all): Update.
 426         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 427         (tui_source_window_base::set_new_height): Update.
 428         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
 429         Update.
 430         (tui_set_locator_fullname, tui_set_locator_info)
 431         (tui_show_frame_info): Update.
 432         * tui/tui-source.c (tui_set_source_content)
 433         (tui_source_is_displayed): Update.
 434         * tui/tui-layout.c (show_source_disasm_command, show_data)
 435         (show_source_or_disasm_and_command): Update.
 436         * tui/tui-disasm.c (tui_set_disassem_content)
 437         (tui_get_begin_asm_address): Update.
 438         * tui/tui-data.h (struct tui_locator_element): Remove.
 439         (union tui_which_element) <locator>: Remove.
 440         (struct tui_locator_window): New.
 441         (tui_locator_win_info_ptr): Change return type.
 442         * tui/tui-data.c (_locator): Change type.
 443         (tui_locator_win_info_ptr): Change return type.
 444         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
 445         (tui_alloc_content): Add assert.
 446
 447 2019-06-25  Tom Tromey  <tom@tromey.com>
 448
 449         * tui/tui-winsource.c
 450         (tui_exec_info_window::maybe_allocate_content): New method.
 451         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
 452         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
 453         (make_source_or_disasm_window): Add cast.
 454         * tui/tui-data.h (union tui_which_element) <simple_string>:
 455         Remove.
 456         (struct tui_source_info): New.
 457         (struct tui_source_window_base) <execution_info>: Change type.
 458         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
 459         case, and add assert.
 460         (tui_alloc_content): Add assert.
 461
 462 2019-06-25  Tom Tromey  <tom@tromey.com>
 463
 464         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
 465         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
 466         * tui/tui-data.c (tui_alloc_win_info): Remove.
 467
 468 2019-06-25  Tom Tromey  <tom@tromey.com>
 469
 470         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
 471         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
 472         can_highlight.
 473
 474 2019-06-25  Tom Tromey  <tom@tromey.com>
 475
 476         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
 477         make_visible_with_new_height method.
 478         (tui_win_info::make_visible_with_new_height): New method.
 479         (tui_source_window_base::do_make_visible_with_new_height)
 480         (tui_data_window::do_make_visible_with_new_height)
 481         (tui_cmd_window::do_make_visible_with_new_height): New methods.
 482         (make_visible_with_new_height): Remove.
 483         (tui_resize_all, tui_adjust_win_heights): Use
 484         make_visible_with_new_height method.
 485         * tui/tui-data.h (struct tui_win_info)
 486         <do_make_visible_with_new_height, make_visible_with_new_height>:
 487         New methods.
 488         (struct tui_source_window_base, struct tui_data_window)
 489         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
 490         methods.
 491
 492 2019-06-25  Tom Tromey  <tom@tromey.com>
 493
 494         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
 495         method.
 496         (update_tab_width): Call update_tab_width method.
 497         * tui/tui-data.h (struct tui_win_info)
 498         (struct tui_source_window_base) <update_tab_width>: New methods.
 499
 500 2019-06-25  Tom Tromey  <tom@tromey.com>
 501
 502         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
 503         parameter.
 504         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
 505         parameter.
 506         (tui_gen_win_info::make_visible): Update.
 507         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
 508         parameter.
 509         * tui/tui-data.h (enum tui_box): New enum.
 510         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
 511
 512 2019-06-25  Tom Tromey  <tom@tromey.com>
 513
 514         * tui/tui-layout.c (make_source_or_disasm_window): Always use
 515         init_and_make_win for EXEC_INFO_WIN.
 516         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
 517         longer inline.
 518         (struct tui_win_info) <~tui_win_info>: Inline.
 519         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 520         Don't declare.
 521         * tui/tui-data.c (source_win, disasm_win): Remove globals.
 522         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 523         Remove.
 524         (tui_initialize_static_data): Update.
 525         (~tui_gen_win_info): Handle more cleanup here.
 526         (~tui_source_window_base): Delete "execution_info".
 527         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
 528
 529 2019-06-25  Tom Tromey  <tom@tromey.com>
 530
 531         * tui/tui-layout.c (make_command_window): Don't set
 532         can_highlight.
 533         (show_source_disasm_command): Call the reset method.
 534         (show_data): Don't set can_highlight.  Call the reset method.
 535         (tui_gen_win_info::reset): Rename from init_gen_win_info
 536         (init_and_make_win): Simplify.  Return tui_gen_win_info.
 537         (show_source_or_disasm_and_command): Call the reset method.
 538         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
 539         (struct tui_cmd_window): Set can_highlight.
 540
 541 2019-06-25  Tom Tromey  <tom@tromey.com>
 542
 543         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
 544         from make_visible.
 545         (tui_make_visible, tui_make_invisible): Rewrite.
 546         (tui_win_info::make_visible): Remove.
 547         (tui_source_window_base::make_visible): Update.
 548         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
 549         method.  Moved from...
 550         (struct tui_win_info) <make_visible>: ...here.
 551
 552 2019-06-25  Tom Tromey  <tom@tromey.com>
 553
 554         * tui/tui-winsource.c
 555         (tui_source_window_base::do_scroll_horizontal): Remove direction
 556         parameter.
 557         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
 558         direction parameter.
 559         * tui/tui-win.c (tui_win_info::forward_scroll)
 560         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 561         (tui_win_info::right_scroll): Update.
 562         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
 563         direction parameter.
 564         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
 565         direction parameter.
 566         * tui/tui-data.h (enum tui_scroll_direction): Remove.
 567         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
 568         Remove direction parameter.
 569         (struct tui_source_window_base, struct tui_source_window)
 570         (struct tui_disasm_window, struct tui_data_window)
 571         (struct tui_cmd_window): Update.
 572
 573 2019-06-25  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-winsource.h (tui_set_exec_info_content)
 576         (tui_show_exec_info_content, tui_erase_exec_info_content)
 577         (tui_clear_exec_info_content, tui_update_exec_info): Change
 578         argument to tui_source_window_base.
 579         * tui/tui-winsource.c (tui_set_exec_info_content)
 580         (tui_show_exec_info_content, tui_erase_exec_info_content)
 581         (tui_clear_exec_info_content, tui_update_exec_info): Change
 582         argument to tui_source_window_base.
 583
 584 2019-06-25  Tom Tromey  <tom@tromey.com>
 585
 586         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
 587         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
 588
 589 2019-06-25  Tom Tromey  <tom@tromey.com>
 590
 591         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
 592         check.
 593
 594 2019-06-25  Tom Tromey  <tom@tromey.com>
 595
 596         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
 597         type to void.
 598         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
 599         type to void.
 600         * tui/tui-source.c (tui_set_source_content): Update.
 601         * tui/tui-disasm.c (tui_set_disassem_content): Update.
 602
 603 2019-06-25  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-win.c (window_name_completer, tui_set_focus)
 606         (tui_all_windows_info): Use name method.
 607         * tui/tui-data.h (struct tui_gen_win_info)
 608         (struct tui_source_window, struct tui_disasm_window)
 609         (struct tui_data_window, struct tui_cmd_window) <name>: New
 610         method.
 611         (tui_win_name): Don't declare.
 612         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
 613         (tui_win_name): Remove.
 614
 615 2019-06-25  Tom Tromey  <tom@tromey.com>
 616
 617         * tui/tui-winsource.h (tui_update_source_window)
 618         (tui_update_source_window_as_is): Change parameter type.
 619         * tui/tui-winsource.c (tui_update_source_window): Change win_info
 620         to be a tui_source_window_base.
 621         (tui_update_source_window_as_is): Likewise.
 622         * tui/tui-win.c (make_visible_with_new_height): Update.
 623
 624 2019-06-25  Tom Tromey  <tom@tromey.com>
 625
 626         * tui/tui-winsource.c (tui_erase_source_content)
 627         (tui_show_source_content, tui_show_exec_info_content)
 628         (tui_erase_exec_info_content): Use refresh_window method.
 629         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
 630         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
 631         from tui_refresh_win.
 632         (tui_data_window::refresh_window): New method.
 633         (tui_win_info::refresh, tui_source_window_base::refresh)
 634         (tui_refresh_all): Use refresh_window method.
 635         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
 636         method.
 637         * tui/tui-regs.c (tui_display_register): Call refresh_window
 638         method.
 639         * tui/tui-layout.c (show_source_disasm_command)
 640         (show_source_or_disasm_and_command): Call refresh_window method.
 641         * tui/tui-data.h (struct tui_gen_win_info)
 642         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
 643         New method.
 644
 645 2019-06-25  Tom Tromey  <tom@tromey.com>
 646
 647         * tui/tui.c (tui_rl_other_window, tui_enable)
 648         (tui_is_window_visible, tui_get_command_dimension): Update.
 649         * tui/tui-winsource.c (tui_update_source_window_as_is)
 650         (tui_clear_source_content, tui_erase_source_content)
 651         (tui_show_source_line, tui_source_window_base::refill)
 652         (tui_source_window_base::do_scroll_horizontal)
 653         (tui_source_window_base::set_is_exec_point_at)
 654         (tui_update_breakpoint_info, tui_set_exec_info_content)
 655         (tui_alloc_source_buffer, tui_line_is_displayed)
 656         (tui_addr_is_displayed): Update.
 657         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 658         (tui_check_and_display_highlight_if_needed)
 659         (tui_win_info::make_visible, tui_win_info::refresh)
 660         (tui_refresh_all): Update.
 661         * tui/tui-windata.c (tui_first_data_item_displayed)
 662         (tui_delete_data_content_windows, tui_erase_data_content)
 663         (tui_display_all_data, tui_data_window::refresh_all)
 664         (tui_check_data_values): Update.
 665         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
 666         (tui_set_win_focus_to, tui_win_info::forward_scroll)
 667         (tui_win_info::backward_scroll, tui_refresh_all_win)
 668         (tui_resize_all, tui_set_focus, tui_all_windows_info)
 669         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
 670         (tui_source_window_base::set_new_height)
 671         (tui_data_window::set_new_height)
 672         (make_invisible_and_set_new_height)
 673         (make_visible_with_new_height, new_height_ok)
 674         (parse_scrolling_args): Update.
 675         * tui/tui-stack.c (tui_show_frame_info): Update.
 676         * tui/tui-source.c (tui_set_source_content)
 677         (tui_set_source_content_nil, tui_source_is_displayed)
 678         (tui_source_window::do_scroll_vertical): Update.
 679         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 680         (tui_display_registers_from, tui_display_reg_element_at_line)
 681         (tui_check_register_values, tui_reg_command): Update.
 682         * tui/tui-layout.c (tui_default_win_height)
 683         (show_source_disasm_command, show_data, init_and_make_win)
 684         (show_source_or_disasm_and_command): Update.
 685         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 686         (tui_redisplay_readline, tui_mld_flush)
 687         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 688         (tui_getc): Update.
 689         * tui/tui-disasm.c (tui_set_disassem_content)
 690         (tui_disasm_window::do_scroll_vertical): Update.
 691         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 692         Now virtual.
 693         (struct tui_win_info): Derive from tui_gen_win_info.
 694         <~tui_win_info>: Mark as override.
 695         <generic>: Remove member.
 696         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 697         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 698         (~tui_data_window, ~tui_win_info)
 699         (tui_free_all_source_wins_content): Update.
 700         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 701
 702 2019-06-25  Tom Tromey  <tom@tromey.com>
 703
 704         * tui/tui-layout.c (init_and_make_win): Use new.
 705         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 706         destructor, initializers.
 707         (tui_alloc_generic_win_info): Don't declare.
 708         * tui/tui-data.c (_locator): Add argument to constructor.
 709         (source_win, disasm_win): New globals.
 710         (exec_info): Remove.
 711         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 712         Update.
 713         (tui_alloc_generic_win_info): Remove.
 714         (init_content_element): Use new.
 715         (tui_win_info::tui_win_info): Update.
 716         (free_content_elements) <case DATA_WIN>: Use delete.
 717
 718 2019-06-25  Tom Tromey  <tom@tromey.com>
 719
 720         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 721         * tui/tui-windata.c (tui_first_data_item_displayed)
 722         (tui_delete_data_content_windows): Update.
 723         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 724         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 725         (tui_display_registers_from, tui_check_register_values): Update.
 726         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 727         pointer.
 728         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 729         window.
 730         (tui_free_data_content): Update.
 731         (free_content_elements) <case DATA_WIN>: Free the window.
 732
 733 2019-06-25  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 736         Update.
 737         * tui/tui-layout.c (make_command_window)
 738         (show_source_disasm_command, show_data, init_and_make_win)
 739         (show_source_or_disasm_and_command): Update.
 740         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 741         method.
 742         <can_highight, is_highlighted>: Now bool.
 743         (tui_set_win_highlight): Don't declare.
 744         * tui/tui-data.c (tui_set_win_highlight): Remove.
 745
 746 2019-06-25  Tom Tromey  <tom@tromey.com>
 747
 748         * tui/tui-wingeneral.c (make_visible): Remove check of window
 749         type.
 750
 751 2019-06-25  Tom Tromey  <tom@tromey.com>
 752
 753         * tui/tui-win.c (tui_win_info::max_height)
 754         (tui_cmd_window::max_height): New methods.
 755         (new_height_ok): Call max_height.
 756         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 757         <max_height>: New method.
 758
 759 2019-06-25  Tom Tromey  <tom@tromey.com>
 760
 761         * tui/tui-win.c (tui_source_window_base::set_new_height)
 762         (tui_data_window::set_new_height): New methods.
 763         (make_invisible_and_set_new_height): Call set_new_height method.
 764         * tui/tui-data.h (struct tui_win_info)
 765         (struct tui_source_window_base, struct tui_data_window)
 766         <set_new_height>: New method.
 767
 768 2019-06-25  Tom Tromey  <tom@tromey.com>
 769
 770         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 771         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 772         tui_refresh_data_win.
 773         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 774         method.
 775         (tui_refresh_all_win): Call the refresh_all method.
 776         (tui_set_focus): Likewise.
 777         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 778         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 779         Likewise.
 780
 781 2019-06-25  Tom Tromey  <tom@tromey.com>
 782
 783         * tui/tui-winsource.h (tui_refill_source_window)
 784         (tui_set_is_exec_point_at): Don't declare.
 785         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 786         (tui_source_window_base::refill): Rename from
 787         tui_refill_source_window.
 788         (tui_source_window_base::do_scroll_horizontal): Update.
 789         (tui_source_window_base::set_is_exec_point_at): Rename from
 790         tui_set_is_exec_point_at.
 791         (tui_update_all_breakpoint_info): Update.
 792         * tui/tui-stack.c (tui_show_frame_info): Update.
 793         * tui/tui-layout.c (show_data): Add cast.
 794         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 795         * tui/tui-data.h (struct tui_source_window_base) <refill,
 796         set_is_exec_point_at>: New methods.
 797         (tui_source_windows, tui_add_to_source_windows): Update types.
 798         (tui_add_to_source_windows): Remove redundant declaration.
 799         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 800         (tui_source_windows): Change return type.
 801         (tui_clear_source_windows_detail): Update.
 802         (tui_add_to_source_windows): Change type of parameter.
 803         (tui_free_all_source_wins_content): Update.
 804
 805 2019-06-25  Tom Tromey  <tom@tromey.com>
 806
 807         * tui/tui-wingeneral.c (tui_win_info::refresh)
 808         (tui_source_window_base::refresh): New methods.
 809         (tui_refresh_all): Call the refresh method.
 810         * tui/tui-data.h (struct tui_win_info)
 811         (struct tui_source_window_base) <refresh>: New method.
 812
 813 2019-06-25  Tom Tromey  <tom@tromey.com>
 814
 815         * tui/tui.h (tui_is_window_visible): Return bool.
 816         * tui/tui.c (tui_is_window_visible): Return bool.
 817         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 818         (tui_make_visible, tui_make_invisible)
 819         (tui_win_info::make_visible)
 820         (tui_source_window_base::make_visible, make_all_visible)
 821         (tui_make_all_visible, tui_make_all_invisible): Update.
 822         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 823         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 824         bool.
 825         (struct tui_win_info, struct tui_source_window_base)
 826         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 827         * tui/tui-data.c (tui_init_generic_part): Update.
 828
 829 2019-06-25  Tom Tromey  <tom@tromey.com>
 830
 831         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 832         (tui_source_window_base::make_visible): New methods.
 833         (make_all_visible): Make method call.
 834         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 835         (struct tui_source_window_base, struct tui_cmd_window): Override
 836         make_visible.
 837         (tui_win_is_source_type): Don't declare.
 838         * tui/tui-data.c (tui_win_is_source_type): Remove.
 839
 840 2019-06-25  Tom Tromey  <tom@tromey.com>
 841
 842         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 843         NULL check.
 844
 845 2019-06-25  Tom Tromey  <tom@tromey.com>
 846
 847         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 848         Inline constructor.  Add initializers for members.
 849         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 850         constructors; now inline in class.
 851
 852 2019-06-25  Tom Tromey  <tom@tromey.com>
 853
 854         * tui/tui-regs.c (tui_show_registers): Update.
 855         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 856         bool.
 857         * tui/tui-data.c (tui_data_window::clear_detail)
 858         (tui_data_window): Update.
 859
 860 2019-06-25  Tom Tromey  <tom@tromey.com>
 861
 862         * tui/tui-windata.c (tui_display_all_data)
 863         (tui_display_data_from_line, tui_display_data_from)
 864         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 865         Update.
 866         * tui/tui-regs.c (tui_last_regs_line_no)
 867         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 868         (tui_show_registers, tui_show_register_group)
 869         (tui_display_registers_from, tui_display_reg_element_at_line)
 870         (tui_display_registers_from_line, tui_check_register_values)
 871         (tui_reg_next, tui_reg_prev): Update.
 872         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 873         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 874         tui_data_window.
 875         (struct tui_win_info) <detail>: Remove.  Add new fields from
 876         tui_data_info.
 877         (TUI_DATA_WIN): Add cast.
 878         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 879         (~tui_data_window): Simplify.
 880
 881 2019-06-25  Tom Tromey  <tom@tromey.com>
 882
 883         * tui/tui-layout.c (show_source_disasm_command)
 884         (show_source_or_disasm_and_command): Update.
 885         * tui/tui-io.c (update_cmdwin_start_line)
 886         (tui_redisplay_readline): Update.
 887         * tui/tui-data.h (struct tui_command_info): Remove.
 888         (struct tui_win_info) <detail>: Remove command_info member.
 889         (struct tui_data_window) <start_line>: New member, from
 890         tui_command_info.
 891         (TUI_CMD_WIN): Add casts.
 892
 893 2019-06-25  Tom Tromey  <tom@tromey.com>
 894
 895         * tui/tui-winsource.c (tui_update_source_window)
 896         (tui_refill_source_window)
 897         (tui_source_window_base::do_scroll_horizontal)
 898         (tui_update_breakpoint_info, tui_set_exec_info_content)
 899         (tui_show_exec_info_content, tui_erase_exec_info_content)
 900         (tui_clear_exec_info_content): Update.
 901         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 902         Update.
 903         * tui/tui-win.c (make_invisible_and_set_new_height)
 904         (make_visible_with_new_height): Update.
 905         * tui/tui-source.c (tui_set_source_content)
 906         (tui_show_symtab_source): Update.
 907         * tui/tui-layout.c (extract_display_start_addr)
 908         (show_source_disasm_command, show_data)
 909         (make_source_or_disasm_window)
 910         (show_source_or_disasm_and_command): Update.
 911         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 912         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 913         "gdbarch".
 914         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 915         to tui_source_window_base.
 916         (struct tui_win_info) <detail>: Remove source_info member.
 917         (struct tui_source_window_base) <has_locator>: Inline.
 918         Move contents from tui_source_info; rename has_locator member to
 919         m_has_locator.
 920         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 921         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 922         header file.
 923         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 924         Simplify.
 925         (tui_free_all_source_wins_content): Cast to
 926         tui_source_window_base.
 927
 928 2019-06-25  Tom Tromey  <tom@tromey.com>
 929
 930         * tui/tui-win.c (make_invisible_and_set_new_height)
 931         (make_visible_with_new_height): Call has_locator method.
 932         * tui/tui-layout.c (show_source_disasm_command, show_data)
 933         (show_source_or_disasm_and_command): Update for bool change.
 934         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 935         (tui_win_info) <has_locator>: New method.
 936         (struct tui_source_window_base) <has_locator>: New method.
 937         (tui_win_has_locator): Don't declare.
 938         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 939         from tui_win_has_locator.
 940         (tui_source_window_base): Use false, not FALSE.
 941
 942 2019-06-25  Tom Tromey  <tom@tromey.com>
 943
 944         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 945         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 946         clear_detail method directly.
 947         (tui_clear_win_detail): Remove.
 948
 949 2019-06-25  Tom Tromey  <tom@tromey.com>
 950
 951         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 952         "this", not TUI_DISASM_WIN.
 953
 954 2019-06-25  Tom Tromey  <tom@tromey.com>
 955
 956         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 957         declare.
 958         * tui/tui-winsource.c
 959         (tui_source_window_base::do_scroll_horizontal): Rename from
 960         tui_horizontal_source_scroll.
 961         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 962         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 963         from tui_vertical_data_scroll.
 964         * tui/tui-win.h (tui_scroll): Don't declare.
 965         * tui/tui-win.c (tui_win_info::forward_scroll)
 966         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 967         (tui_win_info::right_scroll): Rename and update.
 968         (tui_scroll_forward_command, tui_scroll_backward_command)
 969         (tui_scroll_left_command, tui_scroll_right_command): Update.
 970         (tui_scroll): Remove.
 971         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 972         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 973         from tui_vertical_source_scroll.
 974         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 975         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 976         from tui_vertical_disassem_scroll.
 977         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 978         do_scroll_horizontal>: New methods.
 979         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 980         Likewise.
 981         (struct tui_source_window_base): Add do_scroll_horizontal.
 982         (struct tui_source_window, struct tui_disasm_window): Add
 983         do_scroll_vertical.
 984         (struct tui_data_window, struct tui_cmd_window): Add
 985         do_scroll_horizontal and do_scroll_vertical.
 986         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 987
 988 2019-06-25  Tom Tromey  <tom@tromey.com>
 989
 990         * tui/tui-data.h (struct tui_source_window_base): New struct.
 991         (struct tui_source_window): Derive from tui_source_window_base.
 992         (struct tui_disasm_window): New struct.
 993         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 994         from tui_source_window::clear_detail.
 995         (tui_source_window_base): Rename from tui_source_window.
 996         (~tui_source_window_base): Rename from ~tui_source_window.
 997         (tui_alloc_win_info): Create a tui_disasm_window.
 998
 999 2019-06-25  Tom Tromey  <tom@tromey.com>
1000
1001         * tui/tui-data.h (struct tui_source_window)
1002         (struct tui_data_window): Declare destructors.
1003         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
1004         destructors.
1005         (tui_win_info): Simplify.
1006
1007 2019-06-25  Tom Tromey  <tom@tromey.com>
1008
1009         * tui/tui-winsource.c (tui_display_main)
1010         (tui_update_source_windows_with_addr)
1011         (tui_update_all_breakpoint_info): Update.
1012         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
1013         (new_height_ok, parse_scrolling_args): Update.
1014         * tui/tui-stack.c (tui_show_frame_info): Update.
1015         * tui/tui-data.h (struct tui_list): Remove.
1016         (tui_source_windows): Return a reference to a std::vector.
1017         * tui/tui-data.c (source_windows): Now a std::vector.
1018         (tui_source_windows): Change return type.
1019         (tui_clear_source_windows): Rewrite.
1020         (tui_clear_source_windows_detail, tui_add_to_source_windows)
1021         (tui_free_all_source_wins_content): Rewrite.
1022
1023 2019-06-25  Tom Tromey  <tom@tromey.com>
1024
1025         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
1026         (struct tui_data_window, struct tui_cmd_window): Declare
1027         clear_detail method.
1028         * tui/tui-data.c (tui_source_window::clear_detail)
1029         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
1030         methods.
1031         (tui_clear_win_detail): Simplify.
1032
1033 2019-06-25  Tom Tromey  <tom@tromey.com>
1034
1035         * tui/tui-layout.c (make_source_window, make_disasm_window)
1036         (make_source_or_disasm_window): Remove win_info_ptr parameter.
1037         Return the new window.
1038         (show_source_disasm_command, show_data)
1039         (show_source_or_disasm_and_command): Update.
1040
1041 2019-06-25  Tom Tromey  <tom@tromey.com>
1042
1043         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
1044         parameter.  Return the new window.
1045         (show_source_disasm_command): Update and remove NULL check.
1046         (show_source_or_disasm_and_command): Update.
1047
1048 2019-06-25  Tom Tromey  <tom@tromey.com>
1049
1050         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
1051
1052 2019-06-25  Tom Tromey  <tom@tromey.com>
1053
1054         * tui/tui-data.h (struct tui_win_info): Make constructor
1055         protected.  Make destructor virtual.  Add initializers.
1056         (tui_source_window, tui_data_window, tui_cmd_window): New
1057         classes.
1058         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
1059         constructor.  Add "type" parameter.
1060         (tui_source_window, tui_data_window, tui_cmd_window): New
1061         constructors.
1062         (tui_alloc_win_info): Instantiate the appropriate subclass.
1063
1064 2019-06-25  Tom Tromey  <tom@tromey.com>
1065
1066         * tui/tui-win.c (tui_resize_all): Use delete.
1067         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
1068         destructor.
1069         (tui_free_window): Don't declare.
1070         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
1071         Update.
1072
1073 2019-06-25  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-data.h (struct tui_win_info): Add constructor.
1076         * tui/tui-data.c (tui_alloc_win_info): Use new.
1077         (tui_free_window): Use delete.
1078
1079 2019-06-22  Tom Tromey  <tom@tromey.com>
1080
1081         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
1082         declare.
1083         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
1084
1085 2019-06-22  Tom Tromey  <tom@tromey.com>
1086
1087         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
1088         declare.
1089         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
1090
1091 2019-06-22  Tom de Vries  <tdevries@suse.de>
1092
1093         * dwarf2read.c (create_addrmap_from_aranges)
1094         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
1095         instead of '%zu'.
1096
1097 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
1098
1099         * dwarf2read.h (dwarf2_section_info_def): Remove.
1100         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
1101         * dwarf2read.c (struct dwo_sections) <types>: Change type to
1102         std::vector<dwarf2_section_info>.
1103         (struct dwo_file) <~dwo_file>: Remove.
1104         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
1105         types field.
1106         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
1107         (dwarf2_read_debug_names): Likewise.
1108         (create_debug_types_hash_table): Change parameter type to
1109         array_view, adjust code accordingly.
1110         (dwarf2_locate_dwo_sections): Adjust to std::vector.
1111         (partial_die_info::fixup): Likewise.
1112         (determine_prefix): Likewise.
1113         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
1114
1115 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1116
1117         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
1118         gdb_bfd_ref_ptr.
1119         <~dwo_file>: Remove call to gdb_bfd_unref.
1120         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
1121         gdb_bfd_ref_ptr::get.
1122
1123 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1124
1125         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
1126         type to htab_up.
1127         * dwarf2read.c (struct dwo_file): Initialize fields.
1128         <~dwo_file>: New.
1129         (free_dwo_file): Remove, move content to ~dwo_file.
1130         (struct dwo_file_deleter): Remove.
1131         (dwo_file_up>: Remove custom deleter.
1132         (free_dwo_files): Remove.
1133         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
1134         dwo_files.
1135         (process_skeletonless_type_units): Call unique_ptr::get.
1136         (allocate_dwo_file_hash_table): Add deleter to created hash
1137         table.  Change return type to htab_up.
1138         (lookup_dwo_file_slot): Don't memset dwo_file, call
1139         unique_ptr::get.
1140         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
1141         (create_dwo_unit_in_dwp_v2): Likewise.
1142         (open_and_init_dwo_file): Likewise.
1143         (free_dwo_file_from_slot): Remove.
1144
1145 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
1146
1147         * dwarf2read.h (struct dwarf2_section_info) <readin,
1148         is_virtual>: Change type to bool.
1149         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
1150         true instead of 1.
1151
1152 2019-06-19  Tom Tromey  <tom@tromey.com>
1153
1154         * tui/tui-data.h (tui_init_content_element): Don't declare.
1155
1156 2019-06-19  Tom Tromey  <tom@tromey.com>
1157
1158         * tui/tui-data.h (tui_init_win_info): Don't declare.
1159
1160 2019-06-19  Tom de Vries  <tdevries@suse.de>
1161
1162         * dwarf2read.h (abstract_to_concrete): Change type to
1163         std::unordered_map<sect_offset, std::vector<sect_offset>,
1164         gdb::hash_enum<sect_offset>>.
1165
1166 2019-06-19  Tom Tromey  <tromey@adacore.com>
1167
1168         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
1169         EVAL_AVOID_SIDE_EFFECTS specially.
1170
1171 2019-06-19  Tom Tromey  <tromey@adacore.com>
1172
1173         * source-cache.c (highlighter): New global.
1174         (source_cache::get_source_lines): Create a highlighter on demand.
1175
1176 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1177
1178         * defs.h (deprecated_interactive_hook): Delete declaration.
1179         * interps.c (clear_interpreter_hooks): Remove use of
1180         deprecated_interactive_hook.
1181         * top.c (deprecated_interactive_hook): Delete definition.
1182         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
1183
1184 2019-06-18  Tom de Vries  <tdevries@suse.de>
1185
1186         PR gdb/24515
1187         * dwarf2read.h (abstract_to_concrete): Change type from
1188         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
1189         std::unordered_map<sect_offset, std::vector<sect_offset>>.
1190         * dwarf2read.c (read_variable): Update.
1191         (dwarf2_fetch_die_loc_sect_off): Update.
1192
1193 2019-06-17  Tom de Vries  <tdevries@suse.de>
1194
1195         PR gdb/24617
1196         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
1197         accessing parent[parent_len - 1].
1198
1199 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
1200
1201         PR gdb/24364
1202         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
1203         call dtrace_process_dof with NULL dof.
1204
1205 2019-06-16  Tom de Vries  <tdevries@suse.de>
1206
1207         PR gdb/24445
1208         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
1209
1210 2019-06-16  Tom Tromey  <tom@tromey.com>
1211
1212         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
1213         (make_all_visible): Use address of member.
1214
1215 2019-06-16  Tom Tromey  <tom@tromey.com>
1216
1217         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
1218         (tui_free_window, free_content, free_content_elements): Remove
1219         unnecessary cast.
1220         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
1221         cast.
1222         * tui/tui-regs.c (tui_show_register_group)
1223         (tui_display_registers_from, tui_display_reg_element_at_line):
1224         Remove unnecessary cast.
1225
1226 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
1227
1228         * linux-nat.c (normal_mask): Delete.
1229         (_initialize_linux_nat): Don't initialise normal_mask.
1230
1231 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
1232
1233         PR gdb/24445
1234         * dwarf-index-write.h (write_psymtabs_to_index): Add
1235         dwz_basename parameter.
1236         * dwarf-index-write.c (write_gdbindex): Move file writing to
1237         write_gdbindex_1.  Change return type void.
1238         (assert_file_size): Move up, remove filename parameter.
1239         (write_gdbindex_1): New function.
1240         (write_debug_names): Change return type to void, call
1241         assert_file_size.
1242         (struct index_wip_file): New struct.
1243         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
1244         file logic to index_wip_file.  Write index for dwz file if
1245         needed.
1246         (save_gdb_index_command): Pass basename of dwz file, if present.
1247         * dwarf-index-cache.c (index_cache::store): Obtain and pass
1248         build-id of dwz file, if present.
1249         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
1250         (dwarf2_get_dwz_file): Likewise.
1251         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
1252         (dwarf2_get_dwz_file): Likewise.
1253
1254 2019-06-16  Tom Tromey  <tom@tromey.com>
1255
1256         * coffread.c (process_coff_symbol): Use xstrdup.
1257         * value.c (create_internalvar): Use xstrdup.
1258
1259 2019-06-16  Tom Tromey  <tom@tromey.com>
1260
1261         * valops.c (value_cast, value_slice): Remove unnecessary cast.
1262         * breakpoint.c (stopin_command, stopat_command)
1263         (until_break_command, decode_location_default): Remove unnecessary
1264         cast.
1265         * utils.c (subset_compare): Remove unnecessary cast.
1266         * ada-lang.c (ada_update_initial_language): Remove unnecessary
1267         cast.
1268         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
1269         cast.
1270         * infcmd.c (path_command): Remove unnecessary cast.
1271         * coffread.c (decode_type): Remove unnecessary cast.
1272         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
1273         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
1274         * tui/tui-stack.c (tui_show_locator_content)
1275         (tui_show_frame_info): Remove unnecessary cast.
1276         * tui/tui-win.c (tui_scroll_forward_command)
1277         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
1278         (parse_scrolling_args): Remove unnecessary cast.
1279         * tui/tui-data.c (init_win_info, tui_del_window)
1280         (tui_free_window, tui_del_data_windows, tui_free_data_content)
1281         (free_content_elements): Remove unnecessary cast.
1282         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
1283         unnecessary cast.
1284         * tui/tui-source.c (tui_set_source_content)
1285         (tui_vertical_source_scroll): Remove unnecessary cast.
1286         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
1287         cast.
1288         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
1289         * tui/tui-regs.c (tui_display_registers_from)
1290         (tui_display_register): Remove unnecessary cast.
1291         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
1292         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
1293         (make_visible): Remove unnecessary cast.
1294         * tui/tui-winsource.c (tui_erase_source_content)
1295         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
1296         unnecessary cast.
1297         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
1298         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
1299         * stabsread.c (read_type, read_array_type, read_range_type):
1300         Remove unnecessary cast.
1301         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
1302         (parse_symbol, parse_type, upgrade_type, parse_external)
1303         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
1304         unnecessary cast.
1305         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
1306
1307 2019-06-16  Tom Tromey  <tom@tromey.com>
1308
1309         * tui/tui-data.c (tui_alloc_generic_win_info)
1310         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
1311         checks.
1312
1313 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
1314             Andrew Burgess  <andrew.burgess@embecosm.com>
1315
1316         * f-typeprint.c (f_print_type): Don't return early for not
1317         associated or not allocated types.
1318         (f_type_print_varspec_suffix): Add print_rank parameter and print
1319         ranks of array types in case they dangling.
1320         (f_type_print_base): Add print_rank parameter.
1321
1322 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1323
1324         * NEWS: Mention new MI commands.
1325         * break-catch-throw.c (enum exception_event_kind): Move to
1326         breakpoint.h.
1327         (print_mention_exception_catchpoint): Output text as a single
1328         message.
1329         (catch_exception_command_1): Rename to...
1330         (catch_exception_event): ...this, make non-static, update header
1331         command, and change some parameter types.
1332         (catch_catch_command): Update for changes to
1333         catch_exception_command_1.
1334         (catch_throw_command): Likewise.
1335         (catch_rethrow_command): Likewise.
1336         * breakpoint.c (enum exception_event_kind): Delete.
1337         * breakpoint.h (enum exception_event_kind): Moved here from
1338         break-catch-throw.c.
1339         (catch_exception_event): Declare.
1340         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
1341         (mi_cmd_catch_throw): New function.
1342         (mi_cmd_catch_rethrow): New function.
1343         (mi_cmd_catch_catch): New function.
1344         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
1345         'catch-catch' entries.
1346         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
1347         (mi_cmd_catch_rethrow): Declare.
1348         (mi_cmd_catch_catch): Declare.
1349
1350 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1351
1352         * annotate.c (annotate_source_line): Change return type to void,
1353         update implementation to match.
1354         * annotate.h (annotate_source_line): Change return type to void,
1355         update header comment.
1356         * stack.c (print_frame_info): Don't change what frame information
1357         is printed based on whether annotations are on or not.
1358
1359 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1360
1361         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
1362         (annotate_source): Make static.
1363         (annotate_source_line): Moved from source.c and renamed from
1364         identify_source_line.  Update the return type.
1365         * annotate.h (annotate_source): Delete declaration.
1366         (annotate_source_line): Declaration moved from source.h, and
1367         renamed from identify_source_line.  Return type updated.
1368         * source.c (identify_source_line): Moved to annotate.c and renamed
1369         to annotate_source_line.
1370         (info_line_command): Remove check of annotation_level.
1371         * source.h (identify_source_line): Move declaration to annotate.h
1372         and rename to annotate_source_line.
1373         * stack.c: Add 'annotate.h' include.
1374         (print_frame_info): Remove check of annotation_level before
1375         calling annotate_source_line.
1376
1377 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1378
1379         * source-cache.c (source_cache::get_plain_source_lines): Use
1380         open_source_file_with_line_charpos instead of just
1381         open_source_file, remove call to find_source_lines.
1382         (source_cache::get_source_lines): Likewise.
1383         * source.c (find_source_lines): Make static.
1384         (get_filename_and_charpos): Renamed into...
1385         (open_source_file_with_line_charpos): ..this along with changes to
1386         return a scoped_fd, and some other minor clean ups.
1387         (identify_source_line): Use open_source_file_with_line_charpos.
1388         (search_command_helper): Use open_source_file_with_line_charpos
1389         instead of just open_source_file, remove call to
1390         find_source_lines.
1391         * source.h (open_source_file_with_line_charpos): Declare new
1392         function.
1393         (find_source_lines): Delete declaration.
1394
1395 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
1396
1397         * source.c (get_filename_and_charpos): Remove fullname
1398         parameter.
1399         (identify_source_line): Update call to get_filename_and_charpos.
1400
1401 2019-06-14  Tom Tromey  <tromey@adacore.com>
1402
1403         PR gdb/24502:
1404         * ui-style.h (skip_ansi_escape): Update comment.
1405         * ui-file.h (class no_terminal_escape_file): New class.
1406         * ui-file.c (no_terminal_escape_file::write)
1407         (no_terminal_escape_file::puts): New methods.
1408         * cli/cli-logging.c (handle_redirections): Use
1409         no_terminal_escape_file.
1410
1411 2019-06-14  Tom Tromey  <tromey@adacore.com>
1412
1413         * NEWS: Move convenience variable news above Python news.
1414
1415 2019-06-14  Tom Tromey  <tom@tromey.com>
1416
1417         * gnulib: Move directory to top-level.
1418         * configure.ac: Don't configure gnulib.
1419         * configure: Rebuild.
1420         * common/common-defs.h: Use new path to gnulib.
1421         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
1422         (GNULIB_H): Remove.
1423         (INCGNU): Look in new gnulib location.
1424         (HFILES_NO_SRCDIR): Remove gnulib files.
1425         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
1426         (generated_files): Remove GNULIB_H.
1427         ($(LIBGNU), all-lib): Remove targets.
1428         (distclean): Don't mention GNULIB_BUILDDIR.
1429         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
1430
1431 2019-06-14  Tom Tromey  <tromey@adacore.com>
1432
1433         * symfile.c (add_symbol_file_command): Remove obsolete comment.
1434         Warn if symbol file does not provide any symbols.
1435
1436 2019-06-14  Tom Tromey  <tromey@adacore.com>
1437
1438         * source.c (find_and_open_source): Respect basenames_may_differ.
1439
1440 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
1441
1442         * annotate.c (annotate_breakpoints_invalid): Make use of
1443         scoped_restore_terminal_state.
1444         (annotate_frames_invalid): Likewise.
1445
1446 2019-06-14  Tom Tromey  <tromey@adacore.com>
1447
1448         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
1449         allow assignment to an internalvar.
1450
1451 2019-06-14  Tom Tromey  <tromey@adacore.com>
1452
1453         * ada-lex.l: Allow "_" in attribute names.
1454
1455 2019-06-14  Tom Tromey  <tromey@adacore.com>
1456
1457         PR gdb/24653:
1458         * regcache.c (registers_changed): Don't call alloca.
1459         * top.c (execute_command): Don't call alloca.
1460
1461 2019-06-13  Pedro Alves  <palves@redhat.com>
1462
1463         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
1464         'expression'.  When parsing an expression, error out if there's
1465         junk after "unlimited".
1466         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1467         (do_set_command): Adjust calls to is_unlimited_literal.
1468
1469 2019-06-13  Pedro Alves  <palves@redhat.com>
1470
1471         * compile/compile.c (make_compile_options_def_group): Add braces
1472         around array_view initializer.
1473         * thread.c (make_thread_apply_all_options_def_group)
1474         (make_thread_apply_all_options_def_group): Likewise.
1475
1476 2019-06-13  Pedro Alves  <palves@redhat.com>
1477
1478         * NEWS (New commands): Mention "maint test-options
1479         require-delimiter", "maint test-options unknown-is-error", "maint
1480         test-options unknown-is-operand" and "maint show
1481         test-options-completion-result".
1482         (New command options, command completion): New section.
1483         (Completion improvements): New section.
1484         Mention that you can abbreviate "unlimited".
1485
1486 2019-06-13  Pedro Alves  <palves@redhat.com>
1487
1488         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
1489         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
1490         * unittests/cli-utils-selftests.c (test_parse_flags)
1491         (test_parse_flags_qcs): Delete.
1492         (test_cli_utils): Don't call deleted functions.
1493
1494 2019-06-13  Pedro Alves  <palves@redhat.com>
1495
1496         * thread.c: Include "cli/cli-option.h".
1497         (tp_array_compar_ascending): Global.
1498         (tp_array_compar): Delete function.
1499         (tp_array_compar_ascending, tp_array_compar_descending): New
1500         functions.
1501         (ascending_option_def, qcs_flag_option_def)
1502         (thr_qcs_flags_option_defs)
1503         (make_thread_apply_all_options_def_group)
1504         (make_thread_apply_options_def_group): New.
1505         (thread_apply_all_command): Use gdb::option::process_options.
1506         (thread_apply_command_completer)
1507         (thread_apply_all_command_completer): New.
1508         (thread_apply_command): Use gdb::option::process_options.
1509         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
1510         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
1511         to generate help text of "thread apply".  Adjust "taas"'s help.
1512         * tid-parse.c (tid_range_parser::in_thread_range): New method.
1513         * tid-parse.h (tid_range_parser::in_thread_range): New method.
1514
1515 2019-06-13  Pedro Alves  <palves@redhat.com>
1516
1517         * thread.c (thread_apply_command): Check for invalid TID with
1518         isdigit instead of !isalpha.
1519
1520 2019-06-13  Pedro Alves  <palves@redhat.com>
1521
1522         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
1523         (validate_flags_qcs): New.
1524         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
1525         (validate_flags_qcs): Declare.
1526         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
1527         (make_frame_apply_options_def_group): New.
1528         (frame_apply_command_count): Process options with
1529         gdb::option::process_options.
1530         (frame_apply_completer): New.
1531         (frame_apply_level_completer, frame_apply_all_completer)
1532         (frame_apply_completer): New.
1533         (_initialize_stack): Update help of "frame apply", "frame apply
1534         level", "frame apply all" and "faas" to mention supported options
1535         and install command completers.
1536         * stack.h (frame_apply_all_completer): Declare.
1537         * thread.c: Include "stack.h".
1538         (tfaas_command): Add "--".
1539         (_initialize_thread): Update help "tfaas" to mention supported
1540         options and install command completer.
1541
1542 2019-06-13  Pedro Alves  <palves@redhat.com>
1543
1544         * completer.c (complete_nested_command_line): New.
1545         (gdb_completion_word_break_characters_throw): Add assertion.
1546         * completer.h (complete_nested_command_line): Declare.
1547
1548 2019-06-13  Pedro Alves  <palves@redhat.com>
1549
1550         * stack.c (parse_backtrace_qualifiers): New.
1551         (backtrace_command): Use it.
1552         (backtrace_command_completer): Complete on qualifiers.
1553
1554 2019-06-13  Pedro Alves  <palves@redhat.com>
1555
1556         * frame.c: Include "cli/cli-option.h.
1557         (user_set_backtrace_options): New.
1558         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
1559         Delete.
1560         (get_prev_frame): Adjust.
1561         (boolean_option_def, uinteger_option_def)
1562         (set_backtrace_option_defs): New.
1563         (_initialize_frame): Adjust and use
1564         gdb::option::add_setshow_cmds_for_options to install "set
1565         backtrace past-main" and "set backtrace past-entry".
1566         * frame.h: Include "cli/cli-option.h".
1567         (struct frame_print_options): Forward declare.
1568         (print_frame_arguments_all, print_frame_arguments_scalars)
1569         (print_frame_arguments_none): Declare.
1570         (print_entry_values): Delete declaration.
1571         (struct frame_print_options, user_frame_print_options): New.
1572         (struct set_backtrace_options): New.
1573         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
1574         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
1575         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
1576         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
1577         (list_args_or_locals): Add frame_print_options parameter.
1578         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1579         * python/py-framefilter.c (enumerate_args): Pass down
1580         USER_FRAME_PRINT_OPTIONS.
1581         * stack.c: Include "cli/cli-option.h".
1582         (print_frame_arguments_all, print_frame_arguments_scalars)
1583         (print_frame_arguments_none): Declare.
1584         (print_raw_frame_arguments, print_entry_values): Delete.
1585         (user_frame_print_options): New.
1586         (boolean_option_def, enum_option_def, frame_print_option_defs):
1587         New.
1588         (struct backtrace_cmd_options): New.
1589         (bt_flag_option_def): New.
1590         (backtrace_command_option_defs): New.
1591         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1592         (print_frame_arg, read_frame_arg, print_frame_args)
1593         (print_frame_info, print_frame): Add frame_print_options parameter
1594         and use it.
1595         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1596         (backtrace_command_1): Add frame_print_options and
1597         backtrace_cmd_options parameters and use them.
1598         (make_backtrace_options_def_group): New.
1599         (backtrace_command): Process command options with
1600         gdb::option::process_options.
1601         (backtrace_command_completer): New.
1602         (_initialize_stack): Extend "backtrace"'s help to mention
1603         supported options.  Install completer for "backtrace".
1604         Install some settings commands with add_setshow_cmds_for_options.
1605
1606 2019-06-13  Pedro Alves  <palves@redhat.com>
1607
1608         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1609         and that "set/show print raw frame-arguments" are now deprecated.
1610
1611         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1612         command.
1613         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1614         * stack.c (_initialize_stack): Install "set/show print
1615         raw-frame-arguments", and deprecate "set/show print raw
1616         frame-arguments".
1617         * valprint.c (_initialize_valprint): Deprecate "set/show print
1618         raw".
1619
1620 2019-06-13  Pedro Alves  <palves@redhat.com>
1621
1622         * compile/compile.c (struct compile_options): New.
1623         (compile_flag_option_def, compile_command_option_defs)
1624         (make_compile_options_def_group): New.
1625         (compile_file_command): Handle options with
1626         gdb::option::process_options.
1627         (compile_file_command_completer): New function.
1628         (compile_code_command): Handle options with
1629         gdb::option::process_options.
1630         (compile_code_command_completer): New function.
1631         (_initialize_compiler): Install completers for "compile code" and
1632         "compile file".  Mention available options in "compile code" and
1633         "compile code"'s help.
1634         * completer.c (advance_to_completion_word): New, factored out from
1635         ...
1636         (advance_to_expression_complete_word_point): ... this.
1637         (advance_to_filename_complete_word_point): New.
1638         * completer.h (advance_to_filename_complete_word_point): New
1639         declaration.
1640
1641 2019-06-13  Pedro Alves  <palves@redhat.com>
1642
1643         * compile/compile.c: Include "cli/cli-option.h".
1644         (compile_print_value): Scope data pointer is now a
1645         value_print_options pointer; adjust.
1646         (compile_print_command): Process options.  Scope data pointer is
1647         now a value_print_options pointer; adjust.
1648         (_initialize_compile): Update "compile print"'s help to include
1649         supported options.  Install a completer for "compile print".
1650         * cp-valprint.c (show_vtblprint, show_objectprint)
1651         (show_static_field_print): Delete.
1652         (_initialize_cp_valprint): Don't install "set print
1653         static-members", "set print vtbl", "set print object" here.
1654         * printcmd.c: Include "cli/cli-option.h" and
1655         "common/gdb_optional.h".
1656         (print_command_parse_format): Rework to fill in a
1657         value_print_options instead of a format_data.
1658         (print_value): Change parameter type from format_data pointer to
1659         value_print_options reference.  Adjust.
1660         (print_command_1): Process options.  Adjust to pass down a
1661         value_print_options.
1662         (print_command_completer): New.
1663         (_initialize_printcmd): Install print_command_completer as
1664         handle_brkchars completer for the "print" command.  Update
1665         "print"'s help to include supported options.
1666         * valprint.c: Include "cli/cli-option.h".
1667         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1668         here from cp-valprint.c.
1669         (boolean_option_def, uinteger_option_def)
1670         (value_print_option_defs, make_value_print_options_def_group):
1671         New.  Use gdb::option::add_setshow_cmds_for_options to install
1672         "set print elements", "set print null-stop", "set print repeats",
1673         "set print pretty", "set print union", "set print array", "set
1674         print address", "set print symbol", "set print array-indexes".
1675         * valprint.h: Include <string> and "cli/cli-option.h".
1676         (make_value_print_options_def_group): Declare.
1677         (print_value): Change parameter type from format_data pointer to
1678         value_print_options reference.
1679         (print_command_completer): Declare.
1680
1681 2019-06-13  Pedro Alves  <palves@redhat.com>
1682
1683         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1684         (COMMON_SFILES): Add maint-test-settings.c.
1685         * cli/cli-decode.c (boolean_enums): New global, factored out from
1686         ...
1687         (add_setshow_boolean_cmd): ... here.
1688         * cli/cli-decode.h (boolean_enums): Declare.
1689         * cli/cli-option.c: New file.
1690         * cli/cli-option.h: New file.
1691         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1692         factored out from ...
1693         (parse_cli_boolean_value(const char *)): ... this.
1694         (is_unlimited_literal): Change parameter type to pointer to
1695         pointer.  Adjust and advance ARG pointer.
1696         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1697         (parse_cli_var_enum): New, factored out from ...
1698         (do_set_command): ... this.  Adjust.
1699         * cli/cli-setshow.h (parse_cli_boolean_value)
1700         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1701         (parse_cli_var_enum): Declare.
1702         * cli/cli-utils.c: Include "cli/cli-option.h".
1703         (get_ulongest): New.
1704         * cli/cli-utils.h (get_ulongest): Declare.
1705         (check_for_argument): New overloads.
1706         * maint-test-options.c: New file.
1707
1708 2019-06-13  Pedro Alves  <palves@redhat.com>
1709
1710         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1711         parse a range if "-" is at the end of the string.
1712
1713 2019-06-13  Pedro Alves  <palves@redhat.com>
1714
1715         * cli/cli-setshow.c (parse_auto_binary_operation)
1716         (parse_cli_boolean_value): Don't allow "o".
1717
1718 2019-06-13  Pedro Alves  <palves@redhat.com>
1719
1720         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1721         * NEWS: Mention maint test-settings KIND.
1722         * maint-test-settings.c: New file.
1723
1724 2019-06-13  Pedro Alves  <palves@redhat.com>
1725
1726         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1727         completer.
1728         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1729         "set" completers.
1730
1731 2019-06-13  Pedro Alves  <palves@redhat.com>
1732
1733         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1734         after item.
1735
1736 2019-06-13  Pedro Alves  <palves@redhat.com>
1737
1738         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1739
1740 2019-06-13  Pedro Alves <palves@redhat.com>
1741
1742         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1743         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1744         call.
1745         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1746         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1747         calls.
1748         (check_for_argument): Skip spaces after argument.
1749
1750 2019-06-13  Pedro Alves  <palves@redhat.com>
1751
1752         * thread.c (thread_apply_command): Adjust TID parsing.
1753         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1754         detected before end of string.
1755         (tid_is_in_list): Error out if LIST is invalid.
1756
1757 2019-06-13  Pedro Alves  <palves@redhat.com>
1758
1759         * completer.c (complete_line_internal_1): Rewind completion word
1760         point.
1761         (completion_tracker::advance_custom_word_point_by): Change
1762         parameter type to int.
1763         * completer.h (completion_tracker::advance_custom_word_point_by):
1764         Likewise.
1765
1766 2019-06-13  Pedro Alves  <palves@redhat.com>
1767
1768         * completer.c (advance_to_completion_word): Handle delimiters.
1769
1770 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1771
1772         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1773
1774 2019-06-11  Tom Tromey  <tom@tromey.com>
1775
1776         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1777         (xmalloc_failed): Move to alloc.c.
1778         * alloc.c: New file.
1779         * Makefile.in (COMMON_SFILES): Add alloc.c.
1780
1781 2019-06-11  Tom Tromey  <tom@tromey.com>
1782
1783         * nat/linux-waitpid.c: Don't include server.h.
1784         (linux_debug): Remove.
1785         (my_waitpid): Update.
1786
1787 2019-06-11  Tom Tromey  <tromey@adacore.com>
1788
1789         * infcall.c (_initialize_infcall): Remove trailing newline from
1790         help.
1791         * user-regs.c (_initialize_user_regs): Remove trailing newline
1792         from help.
1793         * typeprint.c (_initialize_typeprint): Remove trailing newline
1794         from help.
1795         * reverse.c (_initialize_reverse): Remove trailing newlines from
1796         help.
1797         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1798         from help.
1799         * language.c (add_set_language_command): Remove trailing newline
1800         from help.
1801         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1802         help.
1803         * disasm.c (_initialize_disasm): Remove trailing newline from
1804         help.
1805         * top.c (init_main): Remove trailing newline from help.
1806         * interps.c (_initialize_interpreter): Remove trailing newline
1807         from help.
1808         * btrace.c (_initialize_btrace): Remove trailing newlines from
1809         help.
1810         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1811         from help.
1812         * python/python.c (_initialize_python): Remove trailing newline
1813         from help.
1814         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1815         help.
1816         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1817         from help.  Reformat some text.
1818         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1819         from help.
1820         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1821         newline from help.
1822
1823 2019-06-11  Tom Tromey  <tromey@adacore.com>
1824
1825         * darwin-nat.c (darwin_decode_exception_message)
1826         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1827
1828 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1829
1830         * valops.c (value_slice): Check for not allocated or not
1831         associated values.
1832
1833 2019-06-10  Tom de Vries  <tdevries@suse.de>
1834
1835         PR gdb/24618
1836         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1837         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1838         invalid.
1839
1840 2019-06-10  Tom de Vries  <tdevries@suse.de>
1841
1842         PR gdb/24611
1843         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1844         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1845
1846 2019-06-10  Tom de Vries  <tdevries@suse.de>
1847
1848         PR symtab/24545
1849         * symtab.c (struct demangled_name_entry): Add language field.
1850         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1851         static minimal symbol".  Set and use language field.
1852
1853 2019-06-10  Tom Tromey  <tromey@adacore.com>
1854
1855         * ada-lang.c (_initialize_ada_language): Update help text.
1856
1857 2019-06-10  Tom Tromey  <tromey@adacore.com>
1858
1859         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1860         with a newline.
1861         * guile/guile.c (handle_boot_error): Don't end warning with a
1862         newline.
1863         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1864         warning with a newline.
1865         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1866         newline.
1867         (s12z_frame_cache): Likewise.
1868         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1869         a newline.
1870         * solib-svr4.c (disable_probes_interface): Don't end warning with
1871         a newline.
1872         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1873         newline.
1874         * python/python.c (do_finish_initialization): Don't end warning
1875         with a newline.
1876
1877 2019-06-10  Tom Tromey  <tom@tromey.com>
1878
1879         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1880         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1881         gdbpy_enter.
1882
1883 2019-06-10  Tom Tromey  <tromey@adacore.com>
1884
1885         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1886         data.
1887         (elf_new_init): Don't call stabsread_new_init.
1888         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1889         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1890         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1891
1892 2019-06-10  Tom de Vries  <tdevries@suse.de>
1893
1894         PR symtab/16264
1895         PR symtab/24517
1896         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1897
1898 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1899
1900         * source.c (find_and_open_source): Also rewrite relative file
1901         names.
1902
1903 2019-04-26  Amos Bird  <amosbird@gmail.com>
1904
1905         * annotate.c (annotate_thread_exited): Add "thread-exited"
1906         annotation.
1907
1908 2019-06-06  Tom Tromey  <tromey@adacore.com>
1909
1910         * maint.h (class scoped_command_stats): Use
1911         DISABLE_COPY_AND_ASSIGN.
1912         <print_time>: New method.
1913         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1914         print_time.
1915         (scoped_command_stats::print_time): New method.
1916
1917 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1918
1919         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1920         instructions of lengths 6 or 8 bytes.
1921
1922 2019-06-04  Pedro Alves  <palves@redhat.com>
1923
1924         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1925
1926         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1927         * breakpoint.c (condition_completer): Likewise.
1928         * cli/cli-dump.c (scan_expression): Likewise.
1929         * common/filestuff.c (mkdir_recursive): Likewise.
1930         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1931         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1932         (gdb_abspath): Likewise.
1933         * compile/compile-cplus-types.c
1934         (compile_cplus_instance::decl_name): Likewise.
1935         * completer.c (complete_explicit_location):
1936         (signal_completer, reg_or_group_completer_1): Likewise.
1937         * cp-support.c (cp_remove_params_if_any): Likewise.
1938         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1939         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1940         * infcmd.c (strip_bg_char): Likewise.
1941         * linespec.c (copy_token_string): Likewise.
1942         * mi/mi-main.c (output_cores): Likewise.
1943         * psymtab.c (psymtab_search_name):
1944         * symfile.c (test_set_ext_lang_command): Likewise.
1945         * target.c (target_fileio_read_stralloc): Likewise.
1946         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1947         * value.c (complete_internalvar): Likewise.
1948
1949 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1950
1951         Add objfile property to gdb.Type.
1952         * NEWS: Mention Python API addition.
1953         * python/py-type.c (typy_get_objfile): New method.
1954
1955 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1956
1957         * NEWS: Mention the new set|show style [title|highlight].
1958         Mention changes to "show style", "help" and "apropos".
1959
1960 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1961
1962         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1963         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1964         instead of print_help_for_command.
1965         (print_doc_of_command): New function.
1966         (help_list): Add 'apropos -v word' suggestion.
1967         (print_help_for_command): Style the command name using title style.
1968         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1969         (_initialize_cli_cmds): Describe -v in apropos_command help.
1970
1971 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1972
1973         * cli/cli-style.h (cli_style_option): Add name in constructor,
1974         add m_name class member, add constructor with intensity,
1975         add name class function.
1976         (cli_style_option::add_setshow_commands): Remove name argument.
1977         (highlight_style, title_style): New styles.
1978         * cli/cli-style.c (do_show): New function that shows a style
1979         characteristic styling the style name with itself.
1980         (set_style_name): New function.
1981         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1982         Update all callers according to the changes in cli/cli-style.h.
1983         * utils.h (fputs_highlighted): New function.
1984         * utils.c (fputs_highlighted): Likewise.
1985
1986 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1987
1988         * NEWS: Mention new pipe command and new convenience variables.
1989
1990 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1991
1992         * cli/cli-cmds.c (pipe_command): New function.
1993         (_initialize_cli_cmds): Call add_com for pipe_command.
1994         Define | as an alias for pipe.
1995         (exit_status_set_internal_vars): New function.
1996         (shell_escape): Call exit_status_set_internal_vars.
1997         cli/cli-decode.c (find_command_name_length): Recognize | as
1998         a single character command.
1999
2000 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2001
2002         * gdbcmd.h (execute_command_to_ui_file): New declaration.
2003         top.c (execute_command_to_ui_file): New function, mostly a copy
2004         of execute_command_to_string.
2005         (execute_command_to_string): Implement by calling
2006         execute_command_to_ui_file.
2007
2008 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2009
2010         * top.h (saved_command_line): Remove declaration.
2011         * top.c (previous_saved_command_line, previous_repeat_arguments):
2012         New variables.
2013         (saved_command_line): Make static, define together with other
2014         'repeat variables'.
2015         (dont_repeat): Clear repeat_arguments.
2016         (repeat_previous, get_saved_command_line, save_command_line):
2017         New functions.
2018         (gdb_init): Initialize saved_command_line
2019         and previous_saved_command_line.
2020         * main.c (captured_main_1): Remove saved_command_line initialization.
2021         * event-top.c (handle_line_of_input): Update to use
2022         the new 'repeat' related functions instead of direct access to
2023         saved_command_line.
2024         * command.h (repeat_previous, get_saved_command_line,
2025         save_command_line): New declarations.
2026         (dont_repeat): Add comment.
2027
2028 2019-05-30  Tom Tromey  <tromey@adacore.com>
2029
2030         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
2031         Fix comment.
2032         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
2033
2034 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
2035
2036         PR cli/24587
2037         * completer.c (complete): Initialize variable word.
2038
2039 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
2040
2041         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2042         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
2043         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
2044         'body' is NULL to the outter 'if', protecting the '!is_define'
2045         situation as well.
2046
2047 2019-05-29  Tom Tromey  <tromey@adacore.com>
2048
2049         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
2050         (dwarf_unknown): New function.
2051         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
2052         (dwarf_type_encoding_name): Use dwarf_unknown.
2053
2054 2019-05-29  Tom Tromey  <tromey@adacore.com>
2055
2056         PR c++/20020:
2057         * cp-valprint.c (cp_print_value_fields): Call
2058         cp_print_static_field inside "try".
2059
2060 2019-05-29  Tom Tromey  <tromey@adacore.com>
2061
2062         * inflow.c (struct terminal_info): Add default operator=.
2063         * configure: Rebuild.
2064         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
2065         -Wdeprecated-copy-dtor, -Wredundant-move.
2066
2067 2019-05-29  Tom Tromey  <tromey@adacore.com>
2068
2069         * NEWS: Add entry.
2070         * infcmd.c (print_return_value_1): Handle finish_print
2071         option.
2072         (show_print_finish): New function.
2073         (_initialize_infcmd): Add "set/show print finish" commands.
2074         * valprint.c (user_print_options): Initialize new member.
2075         * valprint.h (struct value_print_options) <finish_print>: New
2076         member.
2077
2078 2019-05-28  Tom Tromey  <tromey@adacore.com>
2079
2080         * ada-lang.c (ada_remove_Xbn_suffix)
2081         (find_old_style_renaming_symbol)
2082         (parse_old_style_renaming): Remove.
2083         (ada_find_renaming_symbol): Don't call
2084         find_old_style_renaming_symbol.
2085         (ada_is_renaming_symbol): Rename from
2086         ada_find_renaming_symbol.  Remove "block" parameter.  Return
2087         bool.  Now static.
2088         (ada_read_var_value): Update and simplify.
2089         * ada-exp.y (write_var_or_type): Remove old code.
2090
2091 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
2092
2093         * event-top.c: Remove include comment.
2094         * inflow.c (class scoped_ignore_sigttou): Move from here...
2095         * inflow.h (class scoped_ignore_sigttou): ...to here.
2096         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
2097         * top.c:  Remove include comment.
2098
2099 2019-05-27  Tom Tromey  <tom@tromey.com>
2100
2101         * NEWS: Fix typo.
2102
2103 2019-05-22  Tom Tromey  <tromey@adacore.com>
2104
2105         * target.c (target_follow_exec): Constify parameter.
2106         * target-delegates.c: Rebuild.
2107         * remote.c (remote_target::follow_exec): Constify parameter.
2108         * infrun.c (follow_exec): Constify parameter.
2109         * target.h (struct target_ops) <follow_exec>: Constify parameter.
2110         (target_follow_exec): Likewise.
2111
2112 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2113
2114         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
2115         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
2116
2117 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
2118
2119         * NEWS: Add debugredirect and testsuite sections.
2120
2121 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
2122
2123         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
2124         target descriptions using exclusively floating point register name
2125         aliases.
2126
2127 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2128
2129         PR gdb/18644:
2130         * f-lang.c (build_fortran_types): Handle the case where
2131         gdbarch_floatformat_for_type returns a nullptr.
2132
2133 2019-05-21  Tom de Vries  <tdevries@suse.de>
2134
2135         PR cli/24587
2136         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
2137
2138 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2139
2140         PR gdb/18644:
2141         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
2142         16-byte floats.
2143         * i386-tdep.c (i386_floatformat_for_type): Use
2144         floatformats_ia64_quad for the 16-byte floating point component
2145         within a fortran 32-byte complex number.
2146
2147 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
2148
2149         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
2150         delete default constructor.
2151         (find_partial_die): Update to return const struct.
2152         (partial_die_parent_scope): Move variable declaration into scope
2153         of its use and change its type to auto.
2154         (guess_partial_die_structure_name): Likewise.
2155         (partial_die_info::fixup): Likewise.
2156
2157 2019-05-17  Tom Tromey  <tromey@adacore.com>
2158
2159         * source.c (find_and_open_source): Remove cast.
2160
2161 2019-05-17  Tom Tromey  <tromey@adacore.com>
2162
2163         * annotate.c (annotate_source): Make "filename" const.
2164         * annotate.h (annotate_source): Use const.
2165
2166 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2167
2168         * disasm.c (set_disassembler_options): Send errors to stderr.
2169
2170 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2171
2172         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
2173         (cli_interp_base::set_logging): Check debug_redirect.
2174         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
2175         * cli/cli-logging.c (debug_redirect): Add static variable.
2176         (pop_output_files): Add default param.
2177         (handle_redirections): Print debug setting.
2178         (show_logging_command): Likewise.
2179         (_initialize_cli_logging): Add debugredirect command.
2180         * interps.c (current_interp_set_logging): Add debug_redirect
2181         parameter.
2182         * interps.h (set_logging): Add debug_redirect parameter.
2183         (current_interp_set_logging): Likewise.
2184         * mi/mi-common.h: Likewise.
2185         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
2186
2187 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
2188             Tom Tromey  <tromey@adacore.com>
2189
2190         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
2191         directly.
2192         * cli/cli-interp.h (make_logging_output): Remove declaration.
2193         * cli/cli-logging.c (make_logging_output): Remove function.
2194         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
2195         directly.
2196         * ui-file.c (tee_file::tee_file): Remove bools.
2197         (tee_file::~tee_file): Remove deletes.
2198         * ui-file.h (tee_file): Remove bools.
2199
2200 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
2201
2202         * mi/mi-cmds.h (mi_cmd_complete): New function.
2203         * mi/mi-main.c (mi_cmd_complete): Likewise.
2204         * mi/mi-cmds.c: Define new MI command -complete.
2205         * NEWS: Mention new -complete command.
2206
2207 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
2208
2209         * completer.h (complete): New function.
2210         * completer.c (complete): Likewise.
2211         * cli/cli-cmds.c: (complete_command): Update to use new complete()
2212         function defined in completer.h.
2213
2214 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
2215
2216         * MAINTAINERS (Write After Approval): Add myself.
2217
2218 2019-05-17  Tom de Vries  <tdevries@suse.de>
2219
2220         PR gdb/24094
2221         * dwarf2read.c (struct cu_partial_die_info): New struct.
2222         (find_partial_die): Return cu_partial_die_info.
2223         (partial_die_parent_scope, guess_partial_die_structure_name)
2224         (partial_die_info::fixup): Handle new return type of find_partial_die.
2225
2226 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2227
2228         * stap-probe.c (stap_parse_register_operand): Make "regname" an
2229         "std::string", simplifying the algorithm.
2230
2231 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2232
2233         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
2234         (stap_static_probe_ops::get_probes): Likewise.
2235
2236 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2237
2238         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
2239         '-')" and "else if".
2240         (stap_parse_single_operand): Join checks for
2241         "gdbarch_stap_parse_special_token_p" and
2242         "gdbarch_stap_parse_special_token" in the same "if" statement.
2243         Invert check when verifying for operation on register
2244         displacement.
2245
2246 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2247
2248         * stap-probe.c (stap_get_opcode): Update comment.
2249         (stap_get_expected_argument_type): Likewise.
2250         (handle_stap_probe): Likewise.
2251
2252 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
2253
2254         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
2255         return type to 'bool'.  Adjust comment.  Use 'bool' when
2256         appropriate.
2257         (i386_stap_parse_special_token_three_arg_disp): Likewise.
2258         * stap-probe.c (stap_parse_argument_1): Likewise.
2259         (stap_is_operator): Likewise.
2260         (stap_is_generic_prefix): Likewise.
2261         (stap_is_register_prefix): Likewise.
2262         (stap_is_register_indirection_prefix): Likewise.
2263         (stap_is_integer_prefix): Likewise.
2264         (stap_generic_check_suffix): Likewise.
2265         (stap_check_integer_suffix): Likewise.
2266         (stap_check_register_suffix): Likewise.
2267         (stap_check_register_indirection_suffix): Likewise.
2268         (stap_parse_register_operand): Likewise.
2269         (stap_parse_single_operand): Likewise.
2270         (stap_parse_argument_1): Likewise.
2271         (stap_probe::get_argument_count): Likewise.
2272         (stap_is_operator): Likewise.
2273
2274 2019-05-16  Tom Tromey  <tromey@adacore.com>
2275
2276         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
2277         keyword to foreach.
2278
2279 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
2280
2281         * linux-thread-db.c (try_thread_db_load_1): Change return type
2282         to bool.
2283         (try_thread_db_load): Likewise.
2284         (try_thread_db_load_from_pdir_1): Likewise.
2285         (try_thread_db_load_from_pdir): Likewise.
2286         (try_thread_db_load_from_sdir): Likewise.
2287         (try_thread_db_load_from_dir): Likewise.
2288         (thread_db_load_search): Likewise.
2289         (has_libpthread): Likewise.
2290         (thread_db_load): Likewise.
2291
2292 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
2293
2294         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
2295         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
2296         NULL, and complain/return if that's the case.
2297
2298 2019-05-15  John Darrington <john@darrington.wattle.id.au>
2299
2300         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
2301         (advance, posn, abstract_read_memory): New functions.
2302         [struct mem_read_abstraction]: New struct.
2303         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
2304
2305 2019-05-14  Tom Tromey  <tromey@adacore.com>
2306
2307         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
2308         value is not lval_memory.
2309
2310 2019-05-14  Tom Tromey  <tromey@adacore.com>
2311
2312         * solib.c (info_sharedlibrary_command): Style the file name.
2313
2314 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
2315
2316         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
2317         (aarch64_vnv_type): Likewise.
2318         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
2319         * common/tdesc.c: Likewise.
2320         * common/tdesc.h (enum tdesc_type_kind): Likewise.
2321         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
2322         * features/aarch64-fpu.xml: Add ieee half view.
2323         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
2324         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
2325         * gdbtypes.h (struct builtin_type): Likewise.
2326         (struct objfile_type): Likewise.
2327
2328 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
2329
2330         * language.c (language_sniff_from_mangled_name): Fix "langauge"
2331         typo.
2332         * location.h (string_to_event_location): Likewise.
2333
2334 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
2335
2336         GDB 8.3 released.
2337
2338 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2339
2340         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
2341         New variable declaration.
2342         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
2343         New variable.
2344         (print_one_breakpoint): Use ui_out::test_flags and new global
2345         variable to compute use_fixed_output.
2346         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
2347         Remove.
2348         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
2349         (mi_multi_location_breakpoint_output_fixed): Remove.
2350         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
2351         new variable.
2352         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
2353         fix_multi_location_breakpoint_output flag if version >= 3.
2354         * ui-out.h (enum ui_out_flag)
2355         <fix_multi_location_breakpoint_output>: New enumerator.
2356
2357 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
2358
2359         * contrib/cc-with-tweaks.sh: Validate dwz's work.
2360
2361 2019-05-10  Tom Tromey  <tromey@adacore.com>
2362
2363         * ada-lang.c (catch_ada_completer): New function.
2364         (_initialize_ada_language): Use it.
2365
2366 2019-05-10  Tom Tromey  <tromey@adacore.com>
2367
2368         * thread.c (print_thread_info): Make "requested_threads" const.
2369         * gdbthread.h (print_thread_info): Make "requested_threads"
2370         const.
2371         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
2372         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
2373
2374 2019-05-08  Tom Tromey  <tom@tromey.com>
2375
2376         * gdbtypes.c (objfile_type_data): Change type.
2377         (objfile_type, _initialize_gdbtypes): Update.
2378
2379 2019-05-08  Tom Tromey  <tom@tromey.com>
2380
2381         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
2382         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
2383         (_initialize_dwarf2_frame): Update.
2384
2385 2019-05-08  Tom Tromey  <tom@tromey.com>
2386
2387         * objc-lang.c (objc_objfile_data): Change type.
2388         (find_methods): Update.
2389         (_initialize_objc_lang): Remove.
2390
2391 2019-05-08  Tom Tromey  <tom@tromey.com>
2392
2393         * stabsread.c (rs6000_builtin_type_data): Change type.
2394         (rs6000_builtin_type, _initialize_stabsread): Update.
2395
2396 2019-05-08  Tom Tromey  <tom@tromey.com>
2397
2398         * mips-tdep.c (mips_pdr_data): Remove.
2399         (_initialize_mips_tdep): Update.
2400
2401 2019-05-08  Tom Tromey  <tom@tromey.com>
2402
2403         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
2404         (hppa_init_objfile_priv_data, read_unwind_info)
2405         (find_unwind_entry, _initialize_hppa_tdep): Update.
2406
2407 2019-05-08  Tom Tromey  <tom@tromey.com>
2408
2409         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
2410         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
2411         on obstack.
2412         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
2413
2414 2019-05-08  Tom Tromey  <tom@tromey.com>
2415
2416         * mdebugread.c (basic_type_data): Change type.
2417         (basic_type, _initialize_mdebugread): Update.
2418
2419 2019-05-08  Tom Tromey  <tom@tromey.com>
2420
2421         * common/gdb_unique_ptr.h (struct noop_deleter): New.
2422
2423 2019-05-08  Tom Tromey  <tom@tromey.com>
2424
2425         * nto-tdep.c (nto_inferior_data_reg): Change type.
2426         (nto_inferior_data): Update.
2427         (nto_inferior_data_cleanup, nto_new_inferior_data)
2428         (_initialize_nto_tdep): Remove.
2429         * nto-tdep.h (struct nto_inferior_data): Add initializers.
2430
2431 2019-05-08  Tom Tromey  <tom@tromey.com>
2432
2433         * ada-lang.c (struct ada_inferior_data): Add initializers.
2434         (ada_inferior_data): Change type.
2435         (ada_inferior_data_cleanup): Remove.
2436         (get_ada_inferior_data, ada_inferior_exit)
2437         (struct ada_pspace_data): Add initializers, destructor.
2438         (ada_pspace_data_handle): Change type.
2439         (get_ada_pspace_data): Update.
2440         (ada_pspace_data_cleanup): Remove.
2441
2442 2019-05-08  Tom Tromey  <tom@tromey.com>
2443
2444         * coffread.c (struct coff_symfile_info): Add initializers.
2445         (coff_objfile_data_key): Move lower.  Change type.
2446         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
2447         Update.
2448         (coff_free_info): Remove.
2449
2450 2019-05-08  Tom Tromey  <tom@tromey.com>
2451
2452         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
2453         (fbsd_pspace_data_handle): Move lower.  Change type.
2454         (get_fbsd_pspace_data): Update.
2455         (fbsd_pspace_data_cleanup): Remove.
2456         (_initialize_fbsd_tdep): Update.
2457
2458 2019-05-08  Tom Tromey  <tom@tromey.com>
2459
2460         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
2461         (get_ada_tasks_pspace_data): Update.
2462         (ada_tasks_pspace_data_cleanup): Remove.
2463         (_initialize_tasks): Update.
2464         (ada_tasks_inferior_data_handle): Change type.
2465         (get_ada_tasks_inferior_data): Update.
2466         (ada_tasks_inferior_data_cleanup): Remove.
2467         (struct ada_tasks_pspace_data): Add initializers.
2468
2469 2019-05-08  Tom Tromey  <tom@tromey.com>
2470
2471         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
2472         * symfile-debug.c (debug_sym_get_probes): Change type.
2473         * stap-probe.c (handle_stap_probe):
2474         (stap_static_probe_ops::get_probes): Change type.
2475         * probe.h (class static_probe_ops) <get_probes>: Change type.
2476         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
2477         (parse_probes_in_pspace): Update.
2478         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
2479         Update.
2480         (any_static_probe_ops::get_probes): Change type.
2481         * elfread.c (elfread_data): New typedef.
2482         (probe_key): Change type.
2483         (elf_get_probes): Likewise.  Update.
2484         (probe_key_free): Remove.
2485         (_initialize_elfread): Update.
2486         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
2487         Change type.
2488         (dtrace_process_dof_probe, dtrace_process_dof)
2489         (dtrace_static_probe_ops::get_probe): Change type.
2490
2491 2019-05-08  Tom Tromey  <tom@tromey.com>
2492
2493         * xcoffread.c (struct xcoff_symfile_info): Rename from
2494         coff_symfile_info.  Add initializers.
2495         (xcoff_objfile_data_key): Move lower.  Change type.
2496         (XCOFF_DATA): Rewrite.
2497         (xcoff_free_info): Remove.
2498         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
2499         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
2500         (xcoff_initial_scan): Update.
2501
2502 2019-05-08  Tom Tromey  <tom@tromey.com>
2503
2504         * solib-svr4.c (struct svr4_info): Add initializers and
2505         destructor.
2506         <probes_table>: Now an htab_up.
2507         (solib_svr4_pspace_data): Change type.
2508         (free_probes_table): Simplify.
2509         (~svr4_info): Rename from svr4_pspace_data_cleanup.
2510         (get_svr4_info, probes_table_htab_remove_objfile_probes)
2511         (probes_table_remove_objfile_probes, register_solib_event_probe)
2512         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
2513         (_initialize_svr4_solib): Update.
2514
2515 2019-05-08  Tom Tromey  <tom@tromey.com>
2516
2517         * remote.c (remote_pspace_data): Change type.
2518         (remote_pspace_data_cleanup): Remove.
2519         (get_remote_exec_file, set_pspace_remote_exec_file)
2520         (_initialize_remote): Update.
2521
2522 2019-05-08  Tom Tromey  <tom@tromey.com>
2523
2524         * breakpoint.c (breakpoint_objfile_key): Change type.
2525         (get_breakpoint_objfile_data): Update.
2526         (free_breakpoint_objfile_data): Remove.
2527         (_initialize_breakpoint): Update.
2528
2529 2019-05-08  Tom Tromey  <tom@tromey.com>
2530
2531         * linux-tdep.c (struct linux_info): Add initializers.
2532         (linux_inferior_data): Move.  Change type.
2533         (invalidate_linux_cache_inf): Update.
2534         (linux_inferior_data_cleanup): Remove.
2535         (get_linux_inferior_data, _initialize_linux_tdep): Update.
2536
2537 2019-05-08  Tom Tromey  <tom@tromey.com>
2538
2539         * auxv.c (auxv_inferior_data): Move.  Change type.
2540         (auxv_inferior_data_cleanup): Remove.
2541         (invalidate_auxv_cache_inf): Rewrite.
2542         (get_auxv_inferior_data, _initialize_auxv): Update.
2543
2544 2019-05-08  Tom Tromey  <tom@tromey.com>
2545
2546         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
2547         (symfile_debug_objfile_data_key): Change type.
2548         (symfile_debug_installed, debug_qf_has_symbols)
2549         (debug_qf_find_last_source_symtab)
2550         (debug_qf_forget_cached_source_info)
2551         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
2552         (debug_qf_print_stats, debug_qf_dump)
2553         (debug_qf_expand_symtabs_for_function)
2554         (debug_qf_expand_all_symtabs)
2555         (debug_qf_expand_symtabs_with_fullname)
2556         (debug_qf_map_matching_symbols)
2557         (debug_qf_expand_symtabs_matching)
2558         (debug_qf_find_pc_sect_compunit_symtab)
2559         (debug_qf_map_symbol_filenames)
2560         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
2561         (debug_sym_new_init, debug_sym_init, debug_sym_read)
2562         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
2563         (debug_sym_read_linetable, debug_sym_relocate): Update.
2564         (symfile_debug_free_objfile): Remove.
2565         (install_symfile_debug_logging, _initialize_symfile_debug):
2566         Update.
2567
2568 2019-05-08  Tom Tromey  <tom@tromey.com>
2569
2570         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
2571         allocate_on_obstack.
2572         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
2573         (get_dwarf2_per_objfile): Update.
2574         (set_dwarf2_per_objfile): Remove.
2575         (dwarf2_has_info, dwarf2_get_section_info): Update.
2576         (dwarf2_free_objfile): Remove.
2577         (_initialize_dwarf2_read): Update.
2578
2579 2019-05-08  Tom Tromey  <tom@tromey.com>
2580
2581         * auto-load.c (struct auto_load_pspace_info): Add destructor and
2582         initializers.
2583         <unsupported_script_warning_printed,
2584         script_not_found_warning_printed>: Now bool.
2585         (auto_load_pspace_data): Change type.
2586         (~auto_load_pspace_info): Rename from
2587         auto_load_pspace_data_cleanup.
2588         (get_auto_load_pspace_data, init_loaded_scripts_info)
2589         (clear_section_scripts, maybe_print_unsupported_script_warning)
2590         (maybe_print_script_not_found_warning, _initialize_auto_load):
2591         Update.
2592
2593 2019-05-08  Tom Tromey  <tom@tromey.com>
2594
2595         * objfiles.c (objfile_pspace_info): Add destructor and
2596         initializers.
2597         (objfiles_pspace_data): Change type.
2598         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2599         (get_objfile_pspace_data): Update.
2600         (objfiles_bfd_data): Change type.
2601         (get_objfile_bfd_data): Update.
2602         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2603
2604 2019-05-08  Tom Tromey  <tom@tromey.com>
2605
2606         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2607         Change type.
2608         (get_catch_syscall_inferior_data): Update.
2609         (catch_syscall_inferior_data_cleanup): Remove.
2610         (_initialize_break_catch_syscall): Update.
2611
2612 2019-05-08  Tom Tromey  <tom@tromey.com>
2613
2614         * inflow.c (struct terminal_info): Add destructor and
2615         initializers.
2616         (inflow_inferior_data): Change type.
2617         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2618         (get_inflow_inferior_data, inflow_inferior_exit)
2619         (swap_terminal_info, _initialize_inflow): Update.
2620
2621 2019-05-08  Tom Tromey  <tom@tromey.com>
2622
2623         * target-dcache.c (target_dcache_cleanup): Remove.
2624         (target_dcache_aspace_key): Change type.
2625         (target_dcache_init_p, target_dcache_invalidate)
2626         (target_dcache_get, target_dcache_get_or_init)
2627         (_initialize_target_dcache): Update.
2628         * dcache.h (struct dcache_deleter): New.
2629
2630 2019-05-08  Tom Tromey  <tom@tromey.com>
2631
2632         * symtab.c (struct symbol_cache): Add destructor and
2633         initializers.
2634         (symbol_cache_key): Move.  Change type.
2635         (make_symbol_cache, free_symbol_cache): Remove.
2636         (get_symbol_cache): Update.
2637         (symbol_cache_cleanup): Remove.
2638         (ALL_PSPACES, symbol_cache_flush)
2639         (maintenance_print_symbol_cache)
2640         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2641         Update.
2642
2643 2019-05-08  Tom Tromey  <tom@tromey.com>
2644
2645         * symtab.c (struct main_info): Add destructor and initializers.
2646         (main_progspace_key): Move.  Change type.
2647         (get_main_info): Update.
2648         (main_info_cleanup): Remove.
2649         (_initialize_symtab): Update.
2650
2651 2019-05-08  Tom Tromey  <tom@tromey.com>
2652
2653         * registry.h (DECLARE_REGISTRY): Define the _key class.
2654
2655 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2656
2657         * NEWS: Merge two 'New commands' sections.
2658
2659 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2660
2661         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2662         parameter and use Ada language definition instead.
2663         (ada_val_print_ptr): Remove unused language parameter.
2664         (ada_val_print_num): Remove language parameter and use Ada language
2665         definition instead.
2666         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2667         parameter.
2668         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2669         parameter and use Ada language definition instead.
2670         (ada_val_print_1): Update all ada_val_print_xxx calls.
2671         Remove language parameter.
2672         (ada_val_print): Update ada_val_print_1 call.
2673
2674 2019-05-08  Tom Tromey  <tromey@adacore.com>
2675
2676         * remote.c (remote_hw_watchpoint_limit)
2677         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2678         Now static.
2679
2680 2019-05-08  Tom Tromey  <tromey@adacore.com>
2681
2682         * maint.c (_initialize_maint_cmds): Move initialization code to
2683         remote.c.
2684         (watchdog, show_watchdog): Move to remote.c.
2685         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2686         "watchdog" static.
2687         (_initialize_remote): Move initialization code from maint.c.
2688         * defs.h (watchdog): Don't declare.
2689
2690 2019-05-08  Tom Tromey  <tromey@adacore.com>
2691
2692         * tui/tui-interp.c: Include main.h.
2693         * interps.c: Include main.h.
2694         * main.h (interpreter_p): Declare.
2695         * defs.h (interpreter_p): Don't declare.
2696
2697 2019-05-08  Tom Tromey  <tromey@adacore.com>
2698
2699         * dwarf2loc.c: Include dwarf2read.h.
2700         * defs.h (read_unsigned_leb128): Don't declare.
2701         * dwarf2read.h (read_unsigned_leb128): Declare.
2702
2703 2019-05-08  Tom Tromey  <tromey@adacore.com>
2704
2705         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2706         method.
2707
2708 2019-05-08  Tom Tromey  <tromey@adacore.com>
2709
2710         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2711         when no wrap column is set.
2712
2713 2019-05-08  Tom Tromey  <tromey@adacore.com>
2714
2715         * c-lang.c (c_get_string): Handle non-C-style arrays.
2716
2717 2019-05-08  Tom Tromey  <tromey@adacore.com>
2718
2719         * typeprint.c (print_offset_data::update): Print the bit offset,
2720         not the number of bits remaining.
2721
2722 2019-05-08  Tom Tromey  <tromey@adacore.com>
2723
2724         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2725         padding at end of comment.
2726
2727 2019-05-08  Tom Tromey  <tromey@adacore.com>
2728
2729         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2730         Compare main types.
2731
2732 2019-05-06  Tom Tromey  <tom@tromey.com>
2733
2734         * common/scoped_mmap.c: Include common-defs.h.
2735         * common/scoped_mmap.h: Don't include config.h.
2736
2737 2019-05-04  Tom Tromey  <tom@tromey.com>
2738
2739         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2740         (struct aarch64_call_info): Add initializers.
2741         <si>: Now a std::vector.
2742         (pass_on_stack, aarch64_push_dummy_call): Update.
2743
2744 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2745             Tom Tromey  <tom@tromey.com>
2746
2747         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2748         (ppc_threads): Now a std::vector.  Now static.
2749         (hwdebug_find_thread_points_by_tid)
2750         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2751         Update.
2752
2753 2019-05-04  Tom Tromey  <tom@tromey.com>
2754
2755         * arc-tdep.c (arc_tdesc_init): Return bool.
2756
2757 2019-05-04  Tom Tromey  <tom@tromey.com>
2758
2759         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2760         Use gdb_assert_not_reached.
2761
2762 2019-05-04  Tom Tromey  <tom@tromey.com>
2763
2764         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2765         "false".
2766
2767 2019-05-04  Tom Tromey  <tom@tromey.com>
2768
2769         * arc-tdep.c (arc_tdesc_init): Use bool.
2770
2771 2019-05-04  Tom Tromey  <tom@tromey.com>
2772
2773         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2774
2775 2019-05-04  Tom Tromey  <tom@tromey.com>
2776
2777         * cli/cli-cmds.c (valid_command_p): Return bool.
2778
2779 2019-05-04  Tom Tromey  <tom@tromey.com>
2780
2781         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2782         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2783
2784 2019-05-04  Raul Tambre  <raul@tambre.ee>
2785
2786         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2787         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2788         operator for comparison.
2789
2790 2019-05-04  Tom Tromey  <tom@tromey.com>
2791
2792         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2793         (lookup_partial_symbol, print_partial_symbols)
2794         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2795         (psymbol_compare): Update.
2796         (add_psymbol_to_bcache): Clear the entire psymbol.
2797         (maintenance_check_psymtabs): Update.
2798         * psympriv.h (struct partial_symbol): Don't derive from
2799         general_symbol_info.
2800         <obj_section, unrelocated_address, address,
2801         set_unrelocated_address>: Update.
2802         <ginfo>: New member.
2803         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2804         (debug_names::write_psymbols): Update.
2805
2806 2019-05-04  Tom de Vries  <tdevries@suse.de>
2807
2808         * contrib/cc-with-tweaks.sh: Support -n arg.
2809
2810 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2811
2812         * corelow.c (core_target::detach): Ensure frame cache and
2813         register caches are cleared.
2814         inferior.c (exit_inferior_1): Likewise.
2815
2816 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2817             Tom Tromey  <tom@tromey.com>
2818
2819         * dictionary.c (collate_pending_symbols_by_language): Remove
2820         "struct" from foreach.
2821         * symtab.c (lookup_global_symbol_from_objfile)
2822         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2823         foreach.
2824         * ser-tcp.c (net_open): Remove "struct" from foreach.
2825         * objfiles.c (objfile_relocate, objfile_rebase)
2826         (objfile_has_symbols): Remove "struct" from foreach.
2827         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2828         from foreach.
2829         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2830         foreach.
2831         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2832         "struct" from foreach.
2833         * ada-lang.c (create_excep_cond_exprs)
2834         (ada_exception_catchpoint_cond_string): Remove "struct" from
2835         foreach.
2836
2837 2019-05-03  Tom Tromey  <tromey@adacore.com>
2838
2839         * ada-exp.y (convert_char_literal): Check suffix of each
2840         enumerator.
2841
2842 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2843
2844         PR ada/21406:
2845         * ada-exp.y (yywrap): Don't define.
2846         * ada-lex.l (%option): Add noyywrap
2847         (yywrap): Remove.
2848
2849 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2850
2851         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2852         _WIN32_WINNT to the XP level, unless already defined to a higher
2853         level.
2854
2855         * unittests/parse-connection-spec-selftests.c:
2856         * ser-tcp.c:
2857         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2858         override.
2859
2860         * symfile.c (find_separate_debug_file): Remove colon from the
2861         drive spec of DOS/Windows file names of the target, so that the
2862         file name produced from DEBUGDIR and the target's directory will
2863         be valid on DOS/Windows systems.
2864
2865 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2866
2867         * rust-lang.c (val_print_struct): Handle printing structures
2868         containing strings.
2869
2870 2019-05-02  Tom Tromey  <tromey@adacore.com>
2871
2872         * valarith.c (_initialize_valarith): Remove.
2873
2874 2019-05-01  Tom Tromey  <tromey@adacore.com>
2875
2876         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2877         bitfields.
2878
2879 2019-05-01  Tom Tromey  <tromey@adacore.com>
2880
2881         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2882         for big-endian copies.
2883
2884 2019-04-30  Ali Tamur  <tamur@google.com>
2885         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2886         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2887         (read_3_bytes): New function.
2888
2889 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2890
2891         * windows-nat.c (main_thread_id): Delete.
2892         (handle_output_debug_string): Replace main_thread_id by
2893         current_event.dwThreadId.
2894         (fake_create_process): Likewise.
2895         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2896         Do not set main_thread_id.
2897         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2898         current_event.dwThreadId.
2899         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2900
2901 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2902
2903         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2904         Use current_event.dwThreadId instead of main_thread_id.
2905
2906 2019-04-30  Tom Tromey  <tromey@adacore.com>
2907
2908         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2909         (create_excep_cond_exprs): Iterate over program spaces.
2910         (ada_exception_catchpoint_cond_string): Examine all minimal
2911         symbols for exception types.
2912
2913 2019-04-30  Tom Tromey  <tromey@adacore.com>
2914
2915         PR c++/24470:
2916         * dwarf2read.c (process_structure_scope): Handle case where type
2917         has template parameters but no symbol was created.
2918
2919 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2920             Chris January  <chris.january@arm.com>
2921
2922         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2923         qualifier.
2924         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2925
2926 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2927
2928         * f-typeprint.c (f_print_type): Update rules for printing
2929         whitespace.
2930         (f_type_print_varspec_suffix): Likewise.
2931
2932 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2933             Chris January  <chris.january@arm.com>
2934
2935         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2936         function arguments.
2937
2938 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2939
2940         * f-lang.c (build_fortran_types): Change name of void type to
2941         lower case.
2942         * f-typeprint.c (f_type_print_base): Print the name of the void
2943         type, rather than a fixed string.
2944         * f-valprint.c (f_decorations): Use lower case void string.
2945
2946 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2947             Chris January  <chris.january@arm.com>
2948
2949         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2950         types for Fortran.
2951
2952 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2953             Chris January  <chris.january@arm.com>
2954             David Lecomber  <david.lecomber@arm.com>
2955
2956         * f-exp.y (BINOP_INTRINSIC): New token.
2957         (exp): New parser rule handling BINOP_INTRINSIC.
2958         (f77_keywords): Add new builtin procedures.
2959         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2960         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2961         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2962         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2963         (print_unop_subexp_f): New function.
2964         (print_binop_subexp_f): New function.
2965         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2966         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2967         (dump_subexp_body_f): Likewise.
2968         (operator_check_f): Likewise.
2969         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2970         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2971
2972 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2973
2974         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2975         UNOP_KIND.
2976         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2977         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2978         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2979         (operator_length_f): New fuction.
2980         (print_subexp_f): New function.
2981         (op_name_f): New function.
2982         (dump_subexp_body_f): New function.
2983         (operator_check_f): New function.
2984         (exp_descriptor_f): Replace standard expression handling functions
2985         with new functions.
2986         * gdb/fortran-operator.def: New file.
2987         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2988         * gdb/std-operator.def: Remove UNOP_KIND.
2989
2990 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2991
2992         * std-operator.def: Remove unbalanced, stray double quote
2993         character.
2994
2995 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2996             Chris January  <chris.january@arm.com>
2997             Daniel Everett  <daniel.everett@arm.com>
2998             Nick Forrington  <nick.forrington@arm.com>
2999             Richard Bunt  <richard.bunt@arm.com>
3000
3001         * cp-valprint.c (cp_print_value_fields): Allow an additional level
3002         of depth when printing anonymous structs or unions.
3003         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
3004         Don't print either the top-level value, or the children if the
3005         max-depth is exceeded.
3006         (ppscm_print_children): When printing the key of a map, allow one
3007         extra level of depth.
3008         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
3009         print either the top-level value, or the children if the max-depth
3010         is exceeded.
3011         (print_children): When printing the key of a map, allow one extra
3012         level of depth.
3013         * python/py-value.c (valpy_format_string): Add max_depth keyword.
3014         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
3015         (user_print_options): Initialise max_depth field.
3016         (val_print_scalar_or_string_type_p): New function.
3017         (val_print): Check to see if the max depth has been reached.
3018         (val_print_check_max_depth): Define new function.
3019         (show_print_max_depth): New function.
3020         (_initialize_valprint): Add 'print max-depth' option.
3021         * valprint.h (struct value_print_options) <max_depth>: New field.
3022         (val_print_check_max_depth): Declare new function.
3023         * NEWS: Document new feature.
3024
3025 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3026
3027         * ada-lang.c (ada_language_defn): Initialise new field.
3028         * c-lang.c (c_is_string_type_p): New function.
3029         (c_language_defn): Initialise new field.
3030         (cplus_language_defn): Initialise new field.
3031         (asm_language_defn): Initialise new field.
3032         (minimal_language_defn): Initialise new field.
3033         * c-lang.h (c_is_string_type_p): Declare new function.
3034         * d-lang.c (d_language_defn): Initialise new field.
3035         * f-lang.c (f_is_string_type_p): New function.
3036         (f_language_defn): Initialise new field.
3037         * go-lang.c (go_is_string_type_p): New function.
3038         (go_language_defn): Initialise new field.
3039         * language.c (default_is_string_type_p): New function.
3040         (unknown_language_defn): Initialise new field.
3041         (auto_language_defn): Initialise new field.
3042         * language.h (struct language_defn) <la_is_string_type_p>: New
3043         member variable.
3044         (default_is_string_type_p): Declare new function.
3045         * m2-lang.c (m2_language_defn): Initialise new field.
3046         * objc-lang.c (objc_language_defn): Initialise new field.
3047         * opencl-lang.c (opencl_language_defn): Initialise new field.
3048         * p-lang.c (pascal_is_string_type_p): New function.
3049         (pascal_language_defn): Initialise new field.
3050         * rust-lang.c (rust_is_string_type_p): New function.
3051         (rust_language_defn): Initialise new field.
3052
3053 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3054
3055         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
3056         New field.
3057         * ada-lang.c (ada_language_defn): Initialise new field.
3058         * c-lang.c (c_language_defn): Likewise.
3059         (cplus_language_defn): Likewise.
3060         (asm_language_defn): Likewise.
3061         (minimal_language_defn): Likewise.
3062         * d-lang.c (d_language_defn): Likewise.
3063         * f-lang.c (f_language_defn): Likewise.
3064         * go-lang.c (go_language_defn): Likewise.
3065         * language.c (unknown_language_defn): Likewise.
3066         (auto_language_defn): Likewise.
3067         * m2-lang.c (m2_language_defn): Likewise.
3068         * objc-lang.c (objc_language_defn): Likewise.
3069         * opencl-lang.c (opencl_language_defn): Likewise.
3070         * p-lang.c (pascal_language_defn): Likewise.
3071         * rust-lang.c (rust_language_defn): Likewise.
3072
3073 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
3074
3075         * ada-lang.c (ada_is_character_type): Change return type to bool.
3076         (ada_is_string_type): Likewise.
3077         * ada-lang.h (ada_is_character_type): Update declaration
3078         (ada_is_string_type): Likewise.
3079
3080 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3081
3082         Support style in 'frame|thread apply'
3083
3084         * gdbcmd.h (execute_command_to_string): New term_out parameter.
3085         * record.c (record_start, record_stop): Update callers of
3086         execute_command_to_string with false.
3087         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
3088         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
3089         methods.
3090         (class string_file): New constructor with term_out parameter.
3091         Override methods term_out and can_emit_style_escape.  New member
3092         term_out.
3093         (class stdio_file): Override can_emit_style_escape.
3094         (class tee_file): Override term_out and can_emit_style_escape.
3095         * utils.h (can_emit_style_escape): Remove.
3096         * utils.c (can_emit_style_escape): Likewise.
3097         Update all callers of can_emit_style_escape (SOMESTREAM) to
3098         SOMESTREAM->can_emit_style_escape.
3099         * source-cache.c (source_cache::get_source_lines): Likewise.
3100         * stack.c (frame_apply_command_count): Call execute_command_to_string
3101         passing the term_out characteristic of the current gdb_stdout.
3102         * thread.c (thr_try_catch_cmd): Likewise.
3103         * top.c (execute_command_to_string): pass term_out parameter
3104         to construct the string_file for the command output.
3105         * ui-file.c (term_cli_styling): New function (most code moved
3106         from utils.c can_emit_style_escape).
3107         (string_file::string_file, string_file::can_emit_style_escape,
3108         stdio_file::can_emit_style_escape, tee_file::term_out,
3109         tee_file::can_emit_style_escape): New functions.
3110
3111 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3112
3113         * NEWS: Mention the new set|show may-call-functions.
3114         * infcall.c (may_call_functions_p): New variable.
3115         (show_may_call_functions_p): New function.
3116         (call_function_by_hand_dummy): Throws an error if not
3117         may-call-functions.
3118         (_initialize_infcall): Call add_setshow_boolean_cmd for
3119         may-call-functions.
3120
3121 2019-04-25  Keith Seitz  <keiths@redhat.com>
3122
3123         PR c++/24367
3124         * cp-support.c (inspect_type): Don't attempt substitutions
3125         of symbol with the same name.
3126
3127 2019-04-25  Tom Tromey  <tromey@adacore.com>
3128
3129         PR gdb/24475:
3130         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
3131         static.
3132
3133 2019-04-25  Tom Tromey  <tromey@adacore.com>
3134
3135         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
3136         rvalue reference.
3137         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
3138         (gdb_xml_parser::parse): Use std::move.
3139         * python/python-internal.h (gdbpy_convert_exception): Take a const
3140         reference.
3141         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
3142         std::move.
3143         * python/py-utils.c (gdbpy_convert_exception): Take a const
3144         reference.
3145         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3146         Use std::move.
3147         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3148         Use std::move.
3149         * mi/mi-main.c (mi_print_exception): Take a const reference.
3150         * main.c (handle_command_errors): Take a const reference.
3151         * linespec.c (parse_linespec): Use std::move.
3152         * infcall.c (run_inferior_call): Use std::move.
3153         (call_function_by_hand_dummy): Use std::move.
3154         * exec.c (try_open_exec_file): Use std::move.
3155         * exceptions.h (exception_print, exception_fprintf)
3156         (exception_print_same): Update.
3157         * exceptions.c (print_exception, exception_print)
3158         (exception_fprintf, exception_print_same): Change parameters to
3159         const reference.
3160         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
3161         * common/new-op.c: Use std::move.
3162         * common/common-exceptions.h (struct gdb_exception): Add move
3163         constructor.
3164         (struct gdb_exception_error, struct gdb_exception_quit, struct
3165         gdb_quit_bad_alloc): Change constructor to move constructor.
3166         (throw_exception): Change parameter to rvalue reference.
3167         * common/common-exceptions.c (throw_exception): Take rvalue
3168         reference.
3169         * cli/cli-interp.c (safe_execute_command): Use std::move.
3170         * breakpoint.c (insert_bp_location, location_to_sals): Use
3171         std::move.
3172
3173 2019-04-25  Tom Tromey  <tromey@adacore.com>
3174
3175         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
3176         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
3177         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
3178         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
3179         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
3180         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
3181         guile/scm-value.c: Use unpack.
3182         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
3183         gdbscm_gdb_exception.
3184         (gdbscm_throw_gdb_exception): Likewise.
3185         (struct gdbscm_gdb_exception): New.
3186         (unpack): New function.
3187         (gdbscm_wrap): Use unpack.
3188
3189 2019-04-25  Tom Tromey  <tromey@adacore.com>
3190
3191         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3192         (gdb_rl_callback_handler): Use std::move.
3193         * common/common-exceptions.h (struct gdb_exception): Add move
3194         assignment operator.
3195         (throw_exception_sjlj): Change "exception" to const reference.
3196         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
3197         (throw_exception_sjlj): Change "exception" to const reference.
3198
3199 2019-04-25  Tom Tromey  <tromey@adacore.com>
3200
3201         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
3202         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
3203         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
3204         Update.
3205         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
3206         Update.
3207         * mi/mi-interp.c (mi_interp::exec): Update.
3208         * linespec.c (parse_linespec): Update.
3209         * infcall.c (run_inferior_call): Update.
3210         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
3211         * guile/scm-symbol.c (gdbscm_lookup_symbol)
3212         (gdbscm_lookup_global_symbol): Update.
3213         * guile/scm-param.c (gdbscm_parameter_value): Update.
3214         * guile/scm-frame.c (gdbscm_frame_read_register)
3215         (gdbscm_frame_read_var): Update.
3216         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
3217         * exec.c (try_open_exec_file): Update.
3218         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
3219         (gdb_rl_callback_handler): Update.
3220         * common/common-exceptions.h (exception_none): Don't declare.
3221         * common/common-exceptions.c (exception_none): Don't define.
3222         (struct catcher) <exception>: Update.
3223         * cli/cli-interp.c (safe_execute_command): Update.
3224         * breakpoint.c (insert_bp_location, location_to_sals): Update.
3225
3226 2019-04-25  Ali Tamur  <tamur@google.com>
3227
3228         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
3229         (read_attribute_value): Likewise.
3230         (dwarf2_read_addr_index): Update comment.
3231         (read_str_index): Add DW_FORM_strx.
3232         (dwarf2_string_attr): Likewise.
3233         (dwarf2_const_value_attr): Likewise.
3234         (dump_die_shallow): Likewise.
3235         (dwarf2_fetch_constant_bytes): Likewise.
3236         (skip_form_bytes): Likewise.
3237         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
3238
3239 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
3240
3241         PR corefiles/11608
3242         PR corefiles/18187
3243         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
3244         OFFSET.  Verify if current mapping contains an ELF header.
3245         (linux_find_memory_regions_full): Adjust call to
3246         dump_mapping_p.
3247
3248 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
3249             Kang Li <kanglictf@gmail.com>
3250
3251         PR gdb/21600
3252
3253         * dwarf2-frame.c (read_initial_length): Be consistent about using
3254         unsigned representation of length.
3255         (decode_frame_entry_1): Likewise.  Check for wraparound of
3256         end pointer as well as buffer overflow.
3257
3258 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
3259
3260         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
3261         "vq".
3262
3263 2019-04-24  Tom Tromey  <tromey@adacore.com>
3264
3265         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
3266
3267 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3268
3269         * s12z-tdep.c (s12z_unwind_pc): Delete.
3270         (s12z_unwind_sp): Delete.
3271         (s12z_gdbarch_init): Don't register deleted functions with
3272         gdbarch.
3273
3274 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3275
3276         * rl78-tdep.c (rl78_unwind_sp): Delete.
3277         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
3278
3279 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3280
3281         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
3282         (xstormy16_unwind_pc): Delete.
3283         (xstormy16_dummy_id): Delete.
3284         (xstormy16_gdbarch_init): Don't register deleted functions with
3285         gdbarch.
3286
3287 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3288
3289         * vax-tdep.c (vax_unwind_pc): Delete.
3290         (vax_gdbarch_init): Don't register deleted function with gdbarch.
3291
3292 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3293
3294         * v850-tdep.c (v850_unwind_sp): Delete.
3295         (v850_unwind_pc): Delete.
3296         (v850_dummy_id): Delete.
3297         (v850_gdbarch_init): Don't register deleted functions with
3298         gdbarch.
3299
3300 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3301
3302         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
3303         (tilegx_unwind_pc): Delete.
3304         (tilegx_unwind_dummy_id): Delete.
3305         (tilegx_gdbarch_init): Don't register deleted functions with
3306         gdbarch.
3307
3308 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3309
3310         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
3311         (tic6x_dummy_id): Delete.
3312         (tic6x_gdbarch_init): Don't register deleted functions with
3313         gdbarch.
3314
3315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3316
3317         * sparc-tdep.c (sparc_unwind_pc): Delete.
3318         (sparc32_gdbarch_init): Don't register deleted function with
3319         gdbarch.
3320
3321 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3322
3323         * sh-tdep.c (sh_unwind_sp): Delete.
3324         (sh_unwind_pc): Delete.
3325         (sh_dummy_id): Delete.
3326         (sh_gdbarch_init): Don't register deleted functions with
3327         gdbarch.
3328
3329 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3330
3331         * score-tdep.c (score_unwind_sp): Delete.
3332         (score_unwind_pc): Delete.
3333         (score_dummy_id): Delete.
3334         (score_gdbarch_init): Don't register deleted functions with
3335         gdbarch.
3336
3337 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * rx-tdep.c (rx_unwind_pc): Delete.
3340         (rx_unwind_sp): Delete.
3341         (rx_dummy_id): Delete.
3342         (rx_gdbarch_init): Don't register deleted functions with
3343         gdbarch.  Update comment.
3344
3345 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3346
3347         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
3348         (rs6000_dummy_id): Delete.
3349         (rs6000_gdbarch_init): Don't register deleted functions with
3350         gdbarch.
3351
3352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3353
3354         * or1k-tdep.c (or1k_dummy_id): Delete.
3355         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
3356
3357 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3358
3359         * nios2-tdep.c (nios2_dummy_id): Delete.
3360         (nios2_unwind_sp): Delete.
3361         (nios2_gdbarch_init): Don't register deleted functions with
3362         gdbarch.
3363
3364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3365
3366         * nds32-tdep.c (nds32_dummy_id): Delete.
3367         (nds32_unwind_pc): Delete.
3368         (nds32_unwind_sp): Delete.
3369         (nds32_gdbarch_init): Don't register deleted functions with
3370         gdbarch.
3371
3372 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3373
3374         * msp430-tdep.c (msp430_unwind_pc): Delete.
3375         (msp430_unwind_sp): Delete.
3376         (msp430_dummy_id): Delete.
3377         (msp430_gdbarch_init): Don't register deleted functions with
3378         gdbarch.
3379
3380 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3381
3382         * moxie-tdep.c (moxie_unwind_sp): Delete.
3383         (moxie_unwind_pc): Delete.
3384         (moxie_dummy_id): Delete.
3385         (moxie_gdbarch_init): Don't register deleted functions with
3386         gdbarch.
3387
3388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3389
3390         * mn10300-tdep.c (mn10300_dummy_id): Delete.
3391         (mn10300_unwind_pc): Delete.
3392         (mn10300_unwind_sp): Delete.
3393         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
3394         mn10300_unwind_sp.
3395         (mn10300_frame_unwind_init): Don't register deleted functions with
3396         gdbarch.
3397
3398 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3399
3400         * mep-tdep.c (mep_unwind_pc): Delete.
3401         (mep_unwind_sp): Delete.
3402         (mep_dummy_id): Delete.
3403         (mep_gdbarch_init): Don't register deleted functions with
3404         gdbarch.
3405
3406 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3407
3408         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
3409         (m68hc11_unwind_sp): Delete.
3410         (m68hc11_gdbarch_init): Don't register deleted functions with
3411         gdbarch.
3412
3413 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3414
3415         * m32r-tdep.c (m32r_unwind_sp): Delete.
3416         (m32r_unwind_pc): Delete.
3417         (m32r_dummy_id): Delete.
3418         (m32r_gdbarch_init): Don't register deleted functions with
3419         gdbarch.
3420
3421 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3422
3423         * m32c-tdep.c (m32c_unwind_pc): Delete.
3424         (m32c_unwind_sp): Delete.
3425         (m32c_dummy_id): Delete.
3426         (m32c_gdbarch_init): Don't register deleted functions with
3427         gdbarch.
3428
3429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3430
3431         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
3432         (lm32_unwind_pc): Delete.
3433         (lm32_dummy_id): Delete.
3434         (lm32_gdbarch_init): Don't register deleted functions with
3435         gdbarch.
3436
3437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3438
3439         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
3440         (iq2000_unwind_pc): Delete.
3441         (iq2000_dummy_id): Delete.
3442         (iq2000_gdbarch_init): Don't register deleted functions with
3443         gdbarch.
3444
3445 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3446
3447         * nds32-tdep.c (nds32_type_align): Delete.
3448         (nds32_push_dummy_call): Use type_align instead.
3449
3450 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3451
3452         * arm-tdep.c (arm_type_align): Only handle vector override case.
3453         (arm_push_dummy_call): Use type_align.
3454         (arm_gdbarch_init): Register arm_type_align gdbarch function.
3455
3456 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
3457
3458         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
3459         case.
3460         (pass_on_stack): Use type_align.
3461         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
3462         function.
3463
3464 2019-04-23  Tom Tromey  <tromey@adacore.com>
3465
3466         * dwarf2read.c (line_header::file_name_at): Remove unused
3467         overload.
3468
3469 2019-04-23  Tom de Vries  <tdevries@suse.de>
3470
3471         PR gdb/24438
3472         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
3473         invocation.
3474
3475
3476 2019-03-27  Ali Tamur  <tamur@google.com>
3477
3478         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
3479         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
3480         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
3481         (dwarf_expr_context::get_addr_index): Likewise
3482         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
3483         (symbol_needs_eval_context::get_addr_index): Likewise
3484         (disassemble_dwarf_expression): Add DW_OP_addrx
3485         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
3486         (read_cutu_die_from_dwo): Update comment
3487         (skip_one_die): Add DW_FORM_addrx
3488         (read_attribute_value): Likewise
3489         (var_decode_location): Add DW_OP_addrx
3490         (dwarf2_const_value_attr): Add DW_FORM_addrx
3491         (dump_die_shallow): Likewise
3492         (dwarf2_fetch_constant_bytes): Likewise
3493         (decode_locdesc): Add DW_OP_addrx
3494         (skip_form_bytes): Add DW_FORM_addrx
3495
3496 2019-04-22  Ali Tamur  <tamur@google.com>
3497
3498         * MAINTAINERS (Write After Approval): Add self.
3499
3500 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
3501
3502         * solib-svr4.c (get_svr4_info): Add pspace parameter.
3503         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
3504         (open_symbol_file_object): Likewise.
3505         (svr4_default_sos): Add info parameter.
3506         (svr4_read_so_list): Likewise.
3507         (svr4_current_sos_direct): Adjust functions calls to pass down
3508         info.
3509         (svr4_current_sos_1): Add info parameter.
3510         (svr4_current_sos): Call get_svr4_info, pass info down to
3511         svr4_current_sos_1.
3512         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
3513         get_svr4_info.
3514         (svr4_in_dynsym_resolve_code): Pass current_program_space to
3515         get_svr4_info.
3516         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
3517         to get_svr4_info.
3518         (probes_table_remove_objfile_probes): Likewise.
3519         (register_solib_event_probe): Add info parameter.
3520         (solist_update_incremental): Pass info parameter down to
3521         svr4_read_so_list.
3522         (disable_probes_interface): Add info parameter.
3523         (svr4_handle_solib_event): Pass current_program_space to
3524         get_svr4_info.  Adjust disable_probes_interface cleanup.
3525         (svr4_create_probe_breakpoints): Add info parameter, pass it
3526         down to register_solib_event_probe.
3527         (svr4_create_solib_event_breakpoints): Add info parameter,
3528         pass it down to svr4_create_probe_breakpoints.
3529         (enable_break): Pass info down to
3530         svr4_create_solib_event_breakpoints.
3531         (svr4_solib_create_inferior_hook): Pass current_program_space to
3532         get_svr4_info.
3533         (svr4_clear_solib): Likewise.
3534
3535 2019-04-22  Pedro Alves  <palves@redhat.com>
3536
3537         * solib-svr4.c (svr4_free_objfile_observer): New.
3538         (probe_and_action::objfile): New field.
3539         (probes_table_htab_remove_objfile_probes)
3540         (probes_table_remove_objfile_probes): New functions.
3541         (register_solib_event_probe): Add 'objfile' parameter.  Store it
3542         in the new probe_and_action.  Don't store the probe in 'lookup'.
3543         (svr4_create_probe_breakpoints): Pass objfile to
3544         register_solib_event_probe.
3545         (_initialize_svr4_solib): Register a free_objfile observer.
3546
3547 2019-04-19  Tom Tromey  <tom@tromey.com>
3548
3549         * common/queue.h: Remove.
3550
3551 2019-04-19  Tom Tromey  <tom@tromey.com>
3552
3553         * event-loop.c: Don't include "common/queue.h".
3554
3555 2019-04-19  Tom Tromey  <tom@tromey.com>
3556
3557         * remote.c (remote_target): Use delete.
3558         * remote-notif.h: Include <list>, not "common/queue.h".
3559         (notif_client_p): Remove typedef.
3560         (remote_notif_state): Add constructor, destructor, initializer.
3561         <notif_queue>: Now a std::list.
3562         (remote_notif_state_xfree): Don't declare.
3563         * remote-notif.c (remote_notif_process, handle_notification)
3564         (remote_notif_state_allocate): Update.
3565         (~remote_notif_state): Rename from remote_notif_state_xfree.
3566
3567 2019-04-19  Tom Tromey  <tom@tromey.com>
3568
3569         * symfile.c (reread_symbols): Update.
3570         * objfiles.c (objfile_register_static_link)
3571         (objfile_lookup_static_link): Update
3572         (~objfile) Don't delete static_links.
3573         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
3574
3575 2019-04-19  Tom Tromey  <tom@tromey.com>
3576
3577         * type-stack.h (struct type_stack) <insert>: Constify string.
3578         * type-stack.c (type_stack::insert): Constify string.
3579         * gdbtypes.h (lookup_template_type): Update.
3580         (address_space_name_to_int): Update.
3581         * gdbtypes.c (address_space_name_to_int): Make space_identifier
3582         const.
3583         (lookup_template_type): Make name const.
3584         * c-exp.y: Update rules.
3585         (lex_one_token, classify_name, classify_inner_name)
3586         (c_print_token): Update.
3587         * p-exp.y: Update rules.
3588         (yylex): Update.
3589         * f-exp.y: Update rules.
3590         (yylex): Update.
3591         * d-exp.y: Update rules.
3592         (lex_one_token, classify_name, classify_inner_name): Update.
3593         * parse.c (write_dollar_variable, copy_name): Return std::string.
3594         * parser-defs.h (copy_name): Change return type.
3595         * m2-exp.y: Update rules.
3596         (yylex): Update.
3597         * go-exp.y (lex_one_token): Update.
3598         Update rules.
3599         (classify_unsafe_function, classify_packaged_name)
3600         (classify_name, yylex): Update.
3601
3602 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3603
3604         * configure.ac: add --enable-source-highlight switch.
3605         * configure: Regenerate.
3606         * top.c (print_gdb_version): plumb --enable-source-highlight
3607         status to "show configuration".
3608
3609 2019-04-19  Tom Tromey  <tromey@adacore.com>
3610
3611         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3612         Check ADA_TYPE_P.
3613         (empty_record, ada_template_to_fixed_record_type_1)
3614         (template_to_static_fixed_type)
3615         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3616         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3617         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3618         macros.
3619
3620 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3621
3622         PR symtab/24423:
3623         * source.c (print_source_lines_base): Advance "iter" when a
3624         control character is seen.
3625
3626 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3627
3628         * inferior.h (struct infcall_suspend_state_deleter):
3629         Catch exception in destructor to avoid crash.
3630
3631 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3632
3633         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3634         close to the add_com "shell".
3635
3636 2019-04-18  Tom Tromey  <tromey@adacore.com>
3637
3638         * process-stratum-target.h (class process_stratum_target)
3639         <stratum>: Add "final".
3640
3641 2019-04-17  Tom Tromey  <tromey@adacore.com>
3642
3643         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3644         against nullptr before use.
3645
3646 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3647
3648         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3649
3650 2019-04-17  Jim Wilson  <jimw@sifive.com>
3651             Andrew Burgess  <andrew.burgess@embecosm.com>
3652
3653         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3654         code read might fail, assume 4-byte breakpoint in that case.
3655
3656 2019-04-15  Leszek Swirski  <leszeks@google.com>
3657
3658         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3659         rather than a hand-rolled POD check when checking for forced MEMORY
3660         classification.
3661
3662 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3663
3664         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3665         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3666         function.
3667         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3668         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3669         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3670         declaration.
3671
3672 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3673
3674         * aarch64-linux-nat.c
3675         (aarch64_linux_nat_target::thread_architecture): Add override.
3676         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3677         each VQ.
3678
3679 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3680
3681         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3682
3683 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3684
3685         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3686         target types of size 96-bits, add some additional comments, and
3687         check that the builtin type we found was the correct size.
3688
3689 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3690
3691         * utils.c (prompt_for_continue): Don't restore the styling at the
3692         end, as applied_style has the wrong value.  This fixes styling in
3693         long lists of file names that are interrupted by the "Continue?"
3694         prompt.
3695
3696 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3697
3698         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3699         * c-lang.c (c_language_defn): Likewise.
3700         (cplus_language_defn): Likewise.
3701         (asm_language_defn): Likewise.
3702         (minimal_language_defn): Likewise.
3703         * d-lang.c (d_language_defn): Likewise.
3704         * f-lang.c (f_language_defn): Likewise.
3705         * go-lang.c (go_language_defn): Likewise.
3706         * language.c (unknown_language_defn): Likewise.
3707         (auto_language_defn): Likewise.
3708         * language.h (struct language_defn): Remove la_magic field.
3709         (LANG_MAGIC): Delete.
3710         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3711         * objc-lang.c (objc_language_defn): Likewise.
3712         * opencl-lang.c (opencl_language_defn): Likewise.
3713         * p-lang.c (pascal_language_defn): Likewise.
3714         * rust-lang.c (rust_language_defn): Likewise.
3715
3716 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3717
3718         * riscv-tdep.c (riscv_type_align): New function.
3719         (riscv_type_alignment): Delete.
3720         (riscv_arg_location): Use 'type_align'.
3721         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3722
3723 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3724
3725         * gdbtypes.c (type_align): A struct with no non-static fields also
3726         has alignment of 1.
3727
3728 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3729
3730         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3731         component to 0.
3732         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3733         member.
3734         (riscv_struct_info::analyse): New implementation using new
3735         analyse_inner member function.
3736         (riscv_struct_info::field_offset): New member function.
3737         (riscv_struct_info::m_offsets): New member variable.
3738         (riscv_struct_info::analyse_inner): New private member function,
3739         takes the old implementation of riscv_struct_info::analyse but
3740         extended to track field offsets.
3741         (riscv_call_arg_struct): Update the struct folding special cases
3742         to handle cases where empty C++ structs, which are non-zero
3743         length, are found.
3744         (riscv_arg_location): Initialise the length of each location, a
3745         non-zero length now indicates the location is in use.
3746         (riscv_push_dummy_call): Allow for the first location having a
3747         non-zero offset when setting up arguments.
3748         (riscv_return_value): Likewise, but for return values.
3749
3750 2019-04-11  Tom Tromey  <tromey@adacore.com>
3751
3752         * utils.c (internal_vproblem): Make "msg" const.
3753
3754 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3755
3756         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3757         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3758         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3759         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3760
3761 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3762
3763         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3764         function.
3765         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3766         of amd64_collect_native_gregset.
3767         (amd64_linux_nat_target::store_registers): Likewise.
3768
3769 2019-04-10  Tom Tromey  <tom@tromey.com>
3770
3771         * symtab.c (lookup_global_symbol_from_objfile)
3772         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3773         * objfiles.h (class separate_debug_iterator): New.
3774         (class separate_debug_range): New.
3775         (struct objfile) <separate_debug_objfiles>: New method.
3776         (objfile_separate_debug_iterate): Don't declare.
3777         * objfiles.c (separate_debug_iterator::operator++): Rename from
3778         objfile_separate_debug_iterate.
3779         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3780         iterator.
3781         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3782         iterator.
3783
3784 2019-04-10  Tom Tromey  <tom@tromey.com>
3785
3786         * symfile.c (reread_symbols): Remove old comment.
3787         * objfiles.c (free_all_objfiles): Fix a typo.
3788
3789 2019-04-10  Tom Tromey  <tom@tromey.com>
3790
3791         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3792         * minsyms.c (lookup_minimal_symbol): Use foreach.
3793         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3794         (lookup_minimal_symbol_solib_trampoline): Likewise.
3795         * symfile.c (reread_symbols): Use foreach.
3796
3797 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3798             Tom Tromey  <tromey@adacore.com>
3799
3800         PR rust/24414:
3801         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3802         (rust_lex_int_test): Change "value" to be LONGEST.
3803         (rust_lex_tests): Add test for long integer literal.
3804
3805 2019-04-09  Tom Tromey  <tromey@adacore.com>
3806
3807         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3808         to bool.
3809         (extended_remote_target::attach): Update.
3810         (remote_target::remote_notice_new_inferior): Update.
3811         (remote_target::add_current_inferior_and_thread): Update.
3812         * inferior.c (exit_inferior_1): Use "false".
3813         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3814
3815 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3816
3817         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3818         the "start" command.
3819
3820 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3821
3822         * python/py-inferior.c (infpy_thread_from_thread_handle):
3823         Adjust comments to reflect renaming of thread_from_thread_handle
3824         to thread_from_handle.  Adjust keywords.  Fix type error message.
3825         (inferior_object_methods): Add thread_from_handle.  Retain
3826         thread_from_thread_handle, but mark it as deprecated.
3827
3828 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3829
3830         * gdbthread.h (find_thread_by_handle): Revise declaration.
3831         * thread.c (find_thread_by_handle): Likewise.  Adjust
3832         implementation too.
3833         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3834         support for buffer objects as handles.
3835
3836 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3837
3838         * python/py-infthread.c (thpy_thread_handle): New function.
3839         (thread_object_methods): Register thpy_thread_handle.
3840
3841 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3842
3843         * gdbthread.h (thread_to_thread_handle): Declare.
3844         * thread.c (gdbtypes.h): Include.
3845         (thread_to_thread_handle): New function.
3846
3847         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3848         (target_thread_info_to_thread_handle): Declare.
3849         * target.c (target_thread_info_to_thread_handle): New function.
3850         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3851         * target-delegates.c: Regenerate.
3852
3853         * linux-thread-db.c (class thread_db_target): Add method
3854         thread_info_to_thread_handle.
3855         (thread_db_target::thread_info_to_thread_handle): Define.
3856         * remote.c (class remote_target): Add new method
3857         thread_info_to_thread_handle.
3858         (remote_target::thread_info_to_thread_handle): Define.
3859
3860 2019-04-08  Pedro Alves  <palves@redhat.com>
3861
3862         * common/common-exceptions.c (throw_exception): Don't create
3863         named object to throw; throw directly.
3864         (throw_it): Likewise.  Don't initialize gdb_exception::message
3865         here, with new; pass FMT and AP to the ctor instead.
3866         * common/common-exceptions.h: Include <string>.
3867         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3868         const char *, va_list)): New ctor.  Use std::make_shared.
3869         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3870         errors)): Delete.
3871         (gdb_exception_error::gdb_exception_error(enum errors, const char
3872         *, va_list)): New.
3873         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3874         Add assertion.
3875         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3876         errors)): Delete.
3877         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3878         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3879         Add assertion.
3880
3881 2019-04-08  Tom Tromey  <tom@tromey.com>
3882
3883         * valops.c (value_rtti_indirect_type): Replace throw_exception
3884         with throw.
3885         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3886         with throw.
3887         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3888         throw.
3889         * target.c (target_translate_tls_address): Replace throw_exception
3890         with throw.
3891         * stack.c (frame_apply_command_count): Replace throw_exception
3892         with throw.
3893         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3894         throw.
3895         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3896         with throw.
3897         * rs6000-tdep.c (rs6000_frame_cache)
3898         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3899         * remote.c: Replace throw_exception with throw.
3900         * record-full.c (record_full_message, record_full_wait_1)
3901         (record_full_restore): Replace throw_exception with throw.
3902         * record-btrace.c:
3903         (get_thread_current_frame_id, record_btrace_start_replaying)
3904         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3905         (cmd_record_btrace_start): Replace throw_exception with throw.
3906         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3907         throw.
3908         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3909         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3910         * linespec.c:
3911         (find_linespec_symbols): Replace throw_exception with throw.
3912         * infrun.c (displaced_step_prepare, resume): Replace
3913         throw_exception with throw.
3914         * infcmd.c (post_create_inferior): Replace throw_exception with
3915         throw.
3916         * inf-loop.c (inferior_event_handler): Replace throw_exception
3917         with throw.
3918         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3919         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3920         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3921         (get_prev_frame_always, get_frame_pc_if_available)
3922         (get_frame_address_in_block_if_available, get_frame_language):
3923         Replace throw_exception with throw.
3924         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3925         throw_exception with throw.
3926         * eval.c (fetch_subexp_value, evaluate_var_value)
3927         (evaluate_funcall, evaluate_subexp_standard): Replace
3928         throw_exception with throw.
3929         * dwarf2loc.c (call_site_find_chain)
3930         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3931         Replace throw_exception with throw.
3932         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3933         with throw.
3934         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3935         throw.
3936         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3937         * completer.c (complete_line_internal): Replace throw_exception
3938         with throw.
3939         * compile/compile-object-run.c (compile_object_run): Replace
3940         throw_exception with throw.
3941         * cli/cli-script.c (process_next_line): Replace throw_exception
3942         with throw.
3943         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3944         (btrace_enable, btrace_maint_update_pt_packets): Replace
3945         throw_exception with throw.
3946         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3947         throw_exception with throw.
3948         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3949         throw_exception with throw.
3950         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3951         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3952         * aarch64-tdep.c (aarch64_make_prologue_cache)
3953         (aarch64_make_stub_cache): Replace throw_exception with throw.
3954
3955 2019-04-08  Tom Tromey  <tom@tromey.com>
3956
3957         * common/common-exceptions.c (throw_exception): Rename from
3958         throw_exception_cxx.  Remove old copy.  Make argument const.
3959         (throw_it): Create and throw exception objects directly.
3960         * common/common-exceptions.h (throw_exception): Make argument
3961         const.
3962         (struct gdb_exception_error): Add constructor.
3963         (struct gdb_exception_quit): Add constructor.
3964
3965 2019-04-08  Tom Tromey  <tom@tromey.com>
3966
3967         * common/common-exceptions.h (exception_rethrow): Don't declare.
3968         (TRY_SJLJ): Update comment.
3969         (TRY, CATCH, END_CATCH): Remove.
3970         * common/common-exceptions.c (exception_rethrow): Remove.
3971
3972 2019-04-08  Tom Tromey  <tom@tromey.com>
3973
3974         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3975         Remove.
3976         (gdb_exception_error): Rename from
3977         gdb_exception_RETURN_MASK_ERROR.
3978         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3979         (gdb_quit_bad_alloc): Update.
3980         * aarch64-tdep.c: Update.
3981         * ada-lang.c: Update.
3982         * ada-typeprint.c: Update.
3983         * ada-valprint.c: Update.
3984         * amd64-tdep.c: Update.
3985         * arch-utils.c: Update.
3986         * break-catch-throw.c: Update.
3987         * breakpoint.c: Update.
3988         * btrace.c: Update.
3989         * c-varobj.c: Update.
3990         * cli/cli-cmds.c: Update.
3991         * cli/cli-interp.c: Update.
3992         * cli/cli-script.c: Update.
3993         * common/common-exceptions.c: Update.
3994         * common/new-op.c: Update.
3995         * common/selftest.c: Update.
3996         * compile/compile-c-symbols.c: Update.
3997         * compile/compile-cplus-symbols.c: Update.
3998         * compile/compile-object-load.c: Update.
3999         * compile/compile-object-run.c: Update.
4000         * completer.c: Update.
4001         * corelow.c: Update.
4002         * cp-abi.c: Update.
4003         * cp-support.c: Update.
4004         * cp-valprint.c: Update.
4005         * darwin-nat.c: Update.
4006         * disasm-selftests.c: Update.
4007         * dtrace-probe.c: Update.
4008         * dwarf-index-cache.c: Update.
4009         * dwarf-index-write.c: Update.
4010         * dwarf2-frame-tailcall.c: Update.
4011         * dwarf2-frame.c: Update.
4012         * dwarf2loc.c: Update.
4013         * dwarf2read.c: Update.
4014         * eval.c: Update.
4015         * event-loop.c: Update.
4016         * event-top.c: Update.
4017         * exec.c: Update.
4018         * f-valprint.c: Update.
4019         * fbsd-tdep.c: Update.
4020         * frame-unwind.c: Update.
4021         * frame.c: Update.
4022         * gdbtypes.c: Update.
4023         * gnu-v3-abi.c: Update.
4024         * guile/guile-internal.h: Update.
4025         * guile/scm-block.c: Update.
4026         * guile/scm-breakpoint.c: Update.
4027         * guile/scm-cmd.c: Update.
4028         * guile/scm-disasm.c: Update.
4029         * guile/scm-frame.c: Update.
4030         * guile/scm-lazy-string.c: Update.
4031         * guile/scm-math.c: Update.
4032         * guile/scm-param.c: Update.
4033         * guile/scm-ports.c: Update.
4034         * guile/scm-pretty-print.c: Update.
4035         * guile/scm-symbol.c: Update.
4036         * guile/scm-symtab.c: Update.
4037         * guile/scm-type.c: Update.
4038         * guile/scm-value.c: Update.
4039         * i386-linux-tdep.c: Update.
4040         * i386-tdep.c: Update.
4041         * inf-loop.c: Update.
4042         * infcall.c: Update.
4043         * infcmd.c: Update.
4044         * infrun.c: Update.
4045         * jit.c: Update.
4046         * language.c: Update.
4047         * linespec.c: Update.
4048         * linux-fork.c: Update.
4049         * linux-nat.c: Update.
4050         * linux-tdep.c: Update.
4051         * linux-thread-db.c: Update.
4052         * main.c: Update.
4053         * mi/mi-cmd-break.c: Update.
4054         * mi/mi-cmd-stack.c: Update.
4055         * mi/mi-interp.c: Update.
4056         * mi/mi-main.c: Update.
4057         * objc-lang.c: Update.
4058         * p-valprint.c: Update.
4059         * parse.c: Update.
4060         * ppc-linux-tdep.c: Update.
4061         * printcmd.c: Update.
4062         * python/py-arch.c: Update.
4063         * python/py-breakpoint.c: Update.
4064         * python/py-cmd.c: Update.
4065         * python/py-finishbreakpoint.c: Update.
4066         * python/py-frame.c: Update.
4067         * python/py-framefilter.c: Update.
4068         * python/py-gdb-readline.c: Update.
4069         * python/py-inferior.c: Update.
4070         * python/py-infthread.c: Update.
4071         * python/py-lazy-string.c: Update.
4072         * python/py-linetable.c: Update.
4073         * python/py-objfile.c: Update.
4074         * python/py-param.c: Update.
4075         * python/py-prettyprint.c: Update.
4076         * python/py-progspace.c: Update.
4077         * python/py-record-btrace.c: Update.
4078         * python/py-record.c: Update.
4079         * python/py-symbol.c: Update.
4080         * python/py-type.c: Update.
4081         * python/py-unwind.c: Update.
4082         * python/py-utils.c: Update.
4083         * python/py-value.c: Update.
4084         * python/python.c: Update.
4085         * record-btrace.c: Update.
4086         * record-full.c: Update.
4087         * remote-fileio.c: Update.
4088         * remote.c: Update.
4089         * riscv-tdep.c: Update.
4090         * rs6000-aix-tdep.c: Update.
4091         * rs6000-tdep.c: Update.
4092         * rust-exp.y: Update.
4093         * rust-lang.c: Update.
4094         * s390-tdep.c: Update.
4095         * selftest-arch.c: Update.
4096         * solib-dsbt.c: Update.
4097         * solib-frv.c: Update.
4098         * solib-spu.c: Update.
4099         * solib-svr4.c: Update.
4100         * solib.c: Update.
4101         * sparc64-linux-tdep.c: Update.
4102         * stack.c: Update.
4103         * symfile-mem.c: Update.
4104         * symmisc.c: Update.
4105         * target.c: Update.
4106         * thread.c: Update.
4107         * top.c: Update.
4108         * tracefile-tfile.c: Update.
4109         * tui/tui.c: Update.
4110         * typeprint.c: Update.
4111         * unittests/cli-utils-selftests.c: Update.
4112         * unittests/parse-connection-spec-selftests.c: Update.
4113         * valops.c: Update.
4114         * valprint.c: Update.
4115         * value.c: Update.
4116         * varobj.c: Update.
4117         * windows-nat.c: Update.
4118         * x86-linux-nat.c: Update.
4119         * xml-support.c: Update.
4120
4121 2019-04-08  Tom Tromey  <tom@tromey.com>
4122
4123         * xml-support.c: Use C++ exception handling.
4124         * x86-linux-nat.c: Use C++ exception handling.
4125         * windows-nat.c: Use C++ exception handling.
4126         * varobj.c: Use C++ exception handling.
4127         * value.c: Use C++ exception handling.
4128         * valprint.c: Use C++ exception handling.
4129         * valops.c: Use C++ exception handling.
4130         * unittests/parse-connection-spec-selftests.c: Use C++ exception
4131         handling.
4132         * unittests/cli-utils-selftests.c: Use C++ exception handling.
4133         * typeprint.c: Use C++ exception handling.
4134         * tui/tui.c: Use C++ exception handling.
4135         * tracefile-tfile.c: Use C++ exception handling.
4136         * top.c: Use C++ exception handling.
4137         * thread.c: Use C++ exception handling.
4138         * target.c: Use C++ exception handling.
4139         * symmisc.c: Use C++ exception handling.
4140         * symfile-mem.c: Use C++ exception handling.
4141         * stack.c: Use C++ exception handling.
4142         * sparc64-linux-tdep.c: Use C++ exception handling.
4143         * solib.c: Use C++ exception handling.
4144         * solib-svr4.c: Use C++ exception handling.
4145         * solib-spu.c: Use C++ exception handling.
4146         * solib-frv.c: Use C++ exception handling.
4147         * solib-dsbt.c: Use C++ exception handling.
4148         * selftest-arch.c: Use C++ exception handling.
4149         * s390-tdep.c: Use C++ exception handling.
4150         * rust-lang.c: Use C++ exception handling.
4151         * rust-exp.y: Use C++ exception handling.
4152         * rs6000-tdep.c: Use C++ exception handling.
4153         * rs6000-aix-tdep.c: Use C++ exception handling.
4154         * riscv-tdep.c: Use C++ exception handling.
4155         * remote.c: Use C++ exception handling.
4156         * remote-fileio.c: Use C++ exception handling.
4157         * record-full.c: Use C++ exception handling.
4158         * record-btrace.c: Use C++ exception handling.
4159         * python/python.c: Use C++ exception handling.
4160         * python/py-value.c: Use C++ exception handling.
4161         * python/py-utils.c: Use C++ exception handling.
4162         * python/py-unwind.c: Use C++ exception handling.
4163         * python/py-type.c: Use C++ exception handling.
4164         * python/py-symbol.c: Use C++ exception handling.
4165         * python/py-record.c: Use C++ exception handling.
4166         * python/py-record-btrace.c: Use C++ exception handling.
4167         * python/py-progspace.c: Use C++ exception handling.
4168         * python/py-prettyprint.c: Use C++ exception handling.
4169         * python/py-param.c: Use C++ exception handling.
4170         * python/py-objfile.c: Use C++ exception handling.
4171         * python/py-linetable.c: Use C++ exception handling.
4172         * python/py-lazy-string.c: Use C++ exception handling.
4173         * python/py-infthread.c: Use C++ exception handling.
4174         * python/py-inferior.c: Use C++ exception handling.
4175         * python/py-gdb-readline.c: Use C++ exception handling.
4176         * python/py-framefilter.c: Use C++ exception handling.
4177         * python/py-frame.c: Use C++ exception handling.
4178         * python/py-finishbreakpoint.c: Use C++ exception handling.
4179         * python/py-cmd.c: Use C++ exception handling.
4180         * python/py-breakpoint.c: Use C++ exception handling.
4181         * python/py-arch.c: Use C++ exception handling.
4182         * printcmd.c: Use C++ exception handling.
4183         * ppc-linux-tdep.c: Use C++ exception handling.
4184         * parse.c: Use C++ exception handling.
4185         * p-valprint.c: Use C++ exception handling.
4186         * objc-lang.c: Use C++ exception handling.
4187         * mi/mi-main.c: Use C++ exception handling.
4188         * mi/mi-interp.c: Use C++ exception handling.
4189         * mi/mi-cmd-stack.c: Use C++ exception handling.
4190         * mi/mi-cmd-break.c: Use C++ exception handling.
4191         * main.c: Use C++ exception handling.
4192         * linux-thread-db.c: Use C++ exception handling.
4193         * linux-tdep.c: Use C++ exception handling.
4194         * linux-nat.c: Use C++ exception handling.
4195         * linux-fork.c: Use C++ exception handling.
4196         * linespec.c: Use C++ exception handling.
4197         * language.c: Use C++ exception handling.
4198         * jit.c: Use C++ exception handling.
4199         * infrun.c: Use C++ exception handling.
4200         * infcmd.c: Use C++ exception handling.
4201         * infcall.c: Use C++ exception handling.
4202         * inf-loop.c: Use C++ exception handling.
4203         * i386-tdep.c: Use C++ exception handling.
4204         * i386-linux-tdep.c: Use C++ exception handling.
4205         * guile/scm-value.c: Use C++ exception handling.
4206         * guile/scm-type.c: Use C++ exception handling.
4207         * guile/scm-symtab.c: Use C++ exception handling.
4208         * guile/scm-symbol.c: Use C++ exception handling.
4209         * guile/scm-pretty-print.c: Use C++ exception handling.
4210         * guile/scm-ports.c: Use C++ exception handling.
4211         * guile/scm-param.c: Use C++ exception handling.
4212         * guile/scm-math.c: Use C++ exception handling.
4213         * guile/scm-lazy-string.c: Use C++ exception handling.
4214         * guile/scm-frame.c: Use C++ exception handling.
4215         * guile/scm-disasm.c: Use C++ exception handling.
4216         * guile/scm-cmd.c: Use C++ exception handling.
4217         * guile/scm-breakpoint.c: Use C++ exception handling.
4218         * guile/scm-block.c: Use C++ exception handling.
4219         * guile/guile-internal.h: Use C++ exception handling.
4220         * gnu-v3-abi.c: Use C++ exception handling.
4221         * gdbtypes.c: Use C++ exception handling.
4222         * frame.c: Use C++ exception handling.
4223         * frame-unwind.c: Use C++ exception handling.
4224         * fbsd-tdep.c: Use C++ exception handling.
4225         * f-valprint.c: Use C++ exception handling.
4226         * exec.c: Use C++ exception handling.
4227         * event-top.c: Use C++ exception handling.
4228         * event-loop.c: Use C++ exception handling.
4229         * eval.c: Use C++ exception handling.
4230         * dwarf2read.c: Use C++ exception handling.
4231         * dwarf2loc.c: Use C++ exception handling.
4232         * dwarf2-frame.c: Use C++ exception handling.
4233         * dwarf2-frame-tailcall.c: Use C++ exception handling.
4234         * dwarf-index-write.c: Use C++ exception handling.
4235         * dwarf-index-cache.c: Use C++ exception handling.
4236         * dtrace-probe.c: Use C++ exception handling.
4237         * disasm-selftests.c: Use C++ exception handling.
4238         * darwin-nat.c: Use C++ exception handling.
4239         * cp-valprint.c: Use C++ exception handling.
4240         * cp-support.c: Use C++ exception handling.
4241         * cp-abi.c: Use C++ exception handling.
4242         * corelow.c: Use C++ exception handling.
4243         * completer.c: Use C++ exception handling.
4244         * compile/compile-object-run.c: Use C++ exception handling.
4245         * compile/compile-object-load.c: Use C++ exception handling.
4246         * compile/compile-cplus-symbols.c: Use C++ exception handling.
4247         * compile/compile-c-symbols.c: Use C++ exception handling.
4248         * common/selftest.c: Use C++ exception handling.
4249         * common/new-op.c: Use C++ exception handling.
4250         * cli/cli-script.c: Use C++ exception handling.
4251         * cli/cli-interp.c: Use C++ exception handling.
4252         * cli/cli-cmds.c: Use C++ exception handling.
4253         * c-varobj.c: Use C++ exception handling.
4254         * btrace.c: Use C++ exception handling.
4255         * breakpoint.c: Use C++ exception handling.
4256         * break-catch-throw.c: Use C++ exception handling.
4257         * arch-utils.c: Use C++ exception handling.
4258         * amd64-tdep.c: Use C++ exception handling.
4259         * ada-valprint.c: Use C++ exception handling.
4260         * ada-typeprint.c: Use C++ exception handling.
4261         * ada-lang.c: Use C++ exception handling.
4262         * aarch64-tdep.c: Use C++ exception handling.
4263
4264 2019-04-08  Tom Tromey  <tom@tromey.com>
4265
4266         * xml-support.c (gdb_xml_parser::parse): Update.
4267         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4268         * value.c (show_convenience): Update.
4269         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
4270         (test_parse_flags_qcs): Update.
4271         * thread.c (thr_try_catch_cmd): Update.
4272         * target.c (target_translate_tls_address): Update.
4273         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
4274         (info_frame_command_core, frame_apply_command_count): Update.
4275         * rust-exp.y (rust_lex_exception_test): Update.
4276         * riscv-tdep.c (riscv_print_one_register_info): Update.
4277         * remote.c (remote_target::enable_btrace): Update.
4278         * record-btrace.c (record_btrace_enable_warn): Update.
4279         * python/py-utils.c (gdbpy_convert_exception): Update.
4280         * printcmd.c (do_one_display, print_variable_and_value): Update.
4281         * mi/mi-main.c (mi_print_exception): Update.
4282         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
4283         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
4284         * linux-nat.c (linux_nat_target::attach): Update.
4285         * linux-fork.c (class scoped_switch_fork_info): Update.
4286         * infrun.c (displaced_step_prepare): Update.
4287         * infcall.c (call_function_by_hand_dummy): Update.
4288         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
4289         * gnu-v3-abi.c (print_one_vtable): Update.
4290         * frame.c (get_prev_frame_always): Update.
4291         * f-valprint.c (info_common_command_for_block): Update.
4292         * exec.c (try_open_exec_file): Update.
4293         * exceptions.c (print_exception, exception_print)
4294         (exception_fprintf, exception_print_same): Update.
4295         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
4296         * dwarf-index-cache.c (index_cache::store)
4297         (index_cache::lookup_gdb_index): Update.
4298         * darwin-nat.c (maybe_cache_shell): Update.
4299         * cp-valprint.c (cp_print_value_fields): Update.
4300         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
4301         (gcc_cplus_symbol_address): Update.
4302         * compile/compile-c-symbols.c (gcc_convert_symbol)
4303         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
4304         * common/selftest.c: Update.
4305         * common/common-exceptions.h (struct gdb_exception) <message>: Now
4306         a std::string.
4307         (exception_try_scope_entry, exception_try_scope_exit): Don't
4308         declare.
4309         (struct exception_try_scope): Remove.
4310         (TRY): Don't use exception_try_scope.
4311         (struct gdb_exception): Add constructor, operator=.
4312         <what>: New method.
4313         (struct gdb_exception_RETURN_MASK_ALL)
4314         (struct gdb_exception_RETURN_MASK_ERROR)
4315         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
4316         (struct gdb_quit_bad_alloc): Update.
4317         * common/common-exceptions.c (exception_none): Change
4318         initializer.
4319         (struct catcher) <state, exception>: Initialize inline.
4320         <prev>: Remove member.
4321         (current_catcher): Remove.
4322         (catchers): New global.
4323         (exceptions_state_mc_init): Simplify.
4324         (catcher_pop): Remove.
4325         (exceptions_state_mc, exceptions_state_mc_catch): Update.
4326         (try_scope_depth, exception_try_scope_entry)
4327         (exception_try_scope_exit): Remove.
4328         (throw_exception_sjlj): Update.
4329         (exception_messages, exception_messages_size): Remove.
4330         (throw_it): Simplify.
4331         (gdb_exception_sliced_copy): Remove.
4332         (throw_exception_cxx): Update.
4333         * cli/cli-script.c (script_from_file): Update.
4334         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
4335         Update.
4336         * ada-valprint.c (ada_val_print): Update.
4337         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
4338         (create_excep_cond_exprs): Update.
4339
4340 2019-04-08  Tom Tromey  <tom@tromey.com>
4341
4342         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
4343         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
4344         (TRY, CATCH, END_CATCH): Remove some definitions.
4345         * common/common-exceptions.c: Don't use GDB_XCPT.
4346         (catcher_list_size): Remove.
4347         (throw_exception, throw_it): Simplify.
4348
4349 2019-04-05  Tom Tromey  <tom@tromey.com>
4350
4351         Revert the header-sorting patch.
4352         * ft32-tdep.c: Revert.
4353         * frv-tdep.c: Revert.
4354         * frv-linux-tdep.c: Revert.
4355         * frame.c: Revert.
4356         * frame-unwind.c: Revert.
4357         * frame-base.c: Revert.
4358         * fork-child.c: Revert.
4359         * findvar.c: Revert.
4360         * findcmd.c: Revert.
4361         * filesystem.c: Revert.
4362         * filename-seen-cache.h: Revert.
4363         * filename-seen-cache.c: Revert.
4364         * fbsd-tdep.c: Revert.
4365         * fbsd-nat.h: Revert.
4366         * fbsd-nat.c: Revert.
4367         * f-valprint.c: Revert.
4368         * f-typeprint.c: Revert.
4369         * f-lang.c: Revert.
4370         * extension.h: Revert.
4371         * extension.c: Revert.
4372         * extension-priv.h: Revert.
4373         * expprint.c: Revert.
4374         * exec.h: Revert.
4375         * exec.c: Revert.
4376         * exceptions.c: Revert.
4377         * event-top.c: Revert.
4378         * event-loop.c: Revert.
4379         * eval.c: Revert.
4380         * elfread.c: Revert.
4381         * dwarf2read.h: Revert.
4382         * dwarf2read.c: Revert.
4383         * dwarf2loc.c: Revert.
4384         * dwarf2expr.h: Revert.
4385         * dwarf2expr.c: Revert.
4386         * dwarf2-frame.c: Revert.
4387         * dwarf2-frame-tailcall.c: Revert.
4388         * dwarf-index-write.h: Revert.
4389         * dwarf-index-write.c: Revert.
4390         * dwarf-index-common.c: Revert.
4391         * dwarf-index-cache.h: Revert.
4392         * dwarf-index-cache.c: Revert.
4393         * dummy-frame.c: Revert.
4394         * dtrace-probe.c: Revert.
4395         * disasm.h: Revert.
4396         * disasm.c: Revert.
4397         * disasm-selftests.c: Revert.
4398         * dictionary.c: Revert.
4399         * dicos-tdep.c: Revert.
4400         * demangle.c: Revert.
4401         * dcache.h: Revert.
4402         * dcache.c: Revert.
4403         * darwin-nat.h: Revert.
4404         * darwin-nat.c: Revert.
4405         * darwin-nat-info.c: Revert.
4406         * d-valprint.c: Revert.
4407         * d-namespace.c: Revert.
4408         * d-lang.c: Revert.
4409         * ctf.c: Revert.
4410         * csky-tdep.c: Revert.
4411         * csky-linux-tdep.c: Revert.
4412         * cris-tdep.c: Revert.
4413         * cris-linux-tdep.c: Revert.
4414         * cp-valprint.c: Revert.
4415         * cp-support.c: Revert.
4416         * cp-namespace.c: Revert.
4417         * cp-abi.c: Revert.
4418         * corelow.c: Revert.
4419         * corefile.c: Revert.
4420         * continuations.c: Revert.
4421         * completer.h: Revert.
4422         * completer.c: Revert.
4423         * complaints.c: Revert.
4424         * coffread.c: Revert.
4425         * coff-pe-read.c: Revert.
4426         * cli-out.h: Revert.
4427         * cli-out.c: Revert.
4428         * charset.c: Revert.
4429         * c-varobj.c: Revert.
4430         * c-valprint.c: Revert.
4431         * c-typeprint.c: Revert.
4432         * c-lang.c: Revert.
4433         * buildsym.c: Revert.
4434         * buildsym-legacy.c: Revert.
4435         * build-id.h: Revert.
4436         * build-id.c: Revert.
4437         * btrace.c: Revert.
4438         * bsd-uthread.c: Revert.
4439         * breakpoint.h: Revert.
4440         * breakpoint.c: Revert.
4441         * break-catch-throw.c: Revert.
4442         * break-catch-syscall.c: Revert.
4443         * break-catch-sig.c: Revert.
4444         * blockframe.c: Revert.
4445         * block.c: Revert.
4446         * bfin-tdep.c: Revert.
4447         * bfin-linux-tdep.c: Revert.
4448         * bfd-target.c: Revert.
4449         * bcache.c: Revert.
4450         * ax-general.c: Revert.
4451         * ax-gdb.h: Revert.
4452         * ax-gdb.c: Revert.
4453         * avr-tdep.c: Revert.
4454         * auxv.c: Revert.
4455         * auto-load.c: Revert.
4456         * arm-wince-tdep.c: Revert.
4457         * arm-tdep.c: Revert.
4458         * arm-symbian-tdep.c: Revert.
4459         * arm-pikeos-tdep.c: Revert.
4460         * arm-obsd-tdep.c: Revert.
4461         * arm-nbsd-tdep.c: Revert.
4462         * arm-nbsd-nat.c: Revert.
4463         * arm-linux-tdep.c: Revert.
4464         * arm-linux-nat.c: Revert.
4465         * arm-fbsd-tdep.c: Revert.
4466         * arm-fbsd-nat.c: Revert.
4467         * arm-bsd-tdep.c: Revert.
4468         * arch-utils.c: Revert.
4469         * arc-tdep.c: Revert.
4470         * arc-newlib-tdep.c: Revert.
4471         * annotate.h: Revert.
4472         * annotate.c: Revert.
4473         * amd64-windows-tdep.c: Revert.
4474         * amd64-windows-nat.c: Revert.
4475         * amd64-tdep.c: Revert.
4476         * amd64-sol2-tdep.c: Revert.
4477         * amd64-obsd-tdep.c: Revert.
4478         * amd64-obsd-nat.c: Revert.
4479         * amd64-nbsd-tdep.c: Revert.
4480         * amd64-nbsd-nat.c: Revert.
4481         * amd64-nat.c: Revert.
4482         * amd64-linux-tdep.c: Revert.
4483         * amd64-linux-nat.c: Revert.
4484         * amd64-fbsd-tdep.c: Revert.
4485         * amd64-fbsd-nat.c: Revert.
4486         * amd64-dicos-tdep.c: Revert.
4487         * amd64-darwin-tdep.c: Revert.
4488         * amd64-bsd-nat.c: Revert.
4489         * alpha-tdep.c: Revert.
4490         * alpha-obsd-tdep.c: Revert.
4491         * alpha-nbsd-tdep.c: Revert.
4492         * alpha-mdebug-tdep.c: Revert.
4493         * alpha-linux-tdep.c: Revert.
4494         * alpha-linux-nat.c: Revert.
4495         * alpha-bsd-tdep.c: Revert.
4496         * alpha-bsd-nat.c: Revert.
4497         * aix-thread.c: Revert.
4498         * agent.c: Revert.
4499         * addrmap.c: Revert.
4500         * ada-varobj.c: Revert.
4501         * ada-valprint.c: Revert.
4502         * ada-typeprint.c: Revert.
4503         * ada-tasks.c: Revert.
4504         * ada-lang.c: Revert.
4505         * aarch64-tdep.c: Revert.
4506         * aarch64-ravenscar-thread.c: Revert.
4507         * aarch64-newlib-tdep.c: Revert.
4508         * aarch64-linux-tdep.c: Revert.
4509         * aarch64-linux-nat.c: Revert.
4510         * aarch64-fbsd-tdep.c: Revert.
4511         * aarch64-fbsd-nat.c: Revert.
4512         * aarch32-linux-nat.c: Revert.
4513
4514 2019-04-05  Tom Tromey  <tom@tromey.com>
4515
4516         * ft32-tdep.c: Sort headers.
4517         * frv-tdep.c: Sort headers.
4518         * frv-linux-tdep.c: Sort headers.
4519         * frame.c: Sort headers.
4520         * frame-unwind.c: Sort headers.
4521         * frame-base.c: Sort headers.
4522         * fork-child.c: Sort headers.
4523         * findvar.c: Sort headers.
4524         * findcmd.c: Sort headers.
4525         * filesystem.c: Sort headers.
4526         * filename-seen-cache.h: Sort headers.
4527         * filename-seen-cache.c: Sort headers.
4528         * fbsd-tdep.c: Sort headers.
4529         * fbsd-nat.h: Sort headers.
4530         * fbsd-nat.c: Sort headers.
4531         * f-valprint.c: Sort headers.
4532         * f-typeprint.c: Sort headers.
4533         * f-lang.c: Sort headers.
4534         * extension.h: Sort headers.
4535         * extension.c: Sort headers.
4536         * extension-priv.h: Sort headers.
4537         * expprint.c: Sort headers.
4538         * exec.h: Sort headers.
4539         * exec.c: Sort headers.
4540         * exceptions.c: Sort headers.
4541         * event-top.c: Sort headers.
4542         * event-loop.c: Sort headers.
4543         * eval.c: Sort headers.
4544         * elfread.c: Sort headers.
4545         * dwarf2read.h: Sort headers.
4546         * dwarf2read.c: Sort headers.
4547         * dwarf2loc.c: Sort headers.
4548         * dwarf2expr.h: Sort headers.
4549         * dwarf2expr.c: Sort headers.
4550         * dwarf2-frame.c: Sort headers.
4551         * dwarf2-frame-tailcall.c: Sort headers.
4552         * dwarf-index-write.h: Sort headers.
4553         * dwarf-index-write.c: Sort headers.
4554         * dwarf-index-common.c: Sort headers.
4555         * dwarf-index-cache.h: Sort headers.
4556         * dwarf-index-cache.c: Sort headers.
4557         * dummy-frame.c: Sort headers.
4558         * dtrace-probe.c: Sort headers.
4559         * disasm.h: Sort headers.
4560         * disasm.c: Sort headers.
4561         * disasm-selftests.c: Sort headers.
4562         * dictionary.c: Sort headers.
4563         * dicos-tdep.c: Sort headers.
4564         * demangle.c: Sort headers.
4565         * dcache.h: Sort headers.
4566         * dcache.c: Sort headers.
4567         * darwin-nat.h: Sort headers.
4568         * darwin-nat.c: Sort headers.
4569         * darwin-nat-info.c: Sort headers.
4570         * d-valprint.c: Sort headers.
4571         * d-namespace.c: Sort headers.
4572         * d-lang.c: Sort headers.
4573         * ctf.c: Sort headers.
4574         * csky-tdep.c: Sort headers.
4575         * csky-linux-tdep.c: Sort headers.
4576         * cris-tdep.c: Sort headers.
4577         * cris-linux-tdep.c: Sort headers.
4578         * cp-valprint.c: Sort headers.
4579         * cp-support.c: Sort headers.
4580         * cp-namespace.c: Sort headers.
4581         * cp-abi.c: Sort headers.
4582         * corelow.c: Sort headers.
4583         * corefile.c: Sort headers.
4584         * continuations.c: Sort headers.
4585         * completer.h: Sort headers.
4586         * completer.c: Sort headers.
4587         * complaints.c: Sort headers.
4588         * coffread.c: Sort headers.
4589         * coff-pe-read.c: Sort headers.
4590         * cli-out.h: Sort headers.
4591         * cli-out.c: Sort headers.
4592         * charset.c: Sort headers.
4593         * c-varobj.c: Sort headers.
4594         * c-valprint.c: Sort headers.
4595         * c-typeprint.c: Sort headers.
4596         * c-lang.c: Sort headers.
4597         * buildsym.c: Sort headers.
4598         * buildsym-legacy.c: Sort headers.
4599         * build-id.h: Sort headers.
4600         * build-id.c: Sort headers.
4601         * btrace.c: Sort headers.
4602         * bsd-uthread.c: Sort headers.
4603         * breakpoint.h: Sort headers.
4604         * breakpoint.c: Sort headers.
4605         * break-catch-throw.c: Sort headers.
4606         * break-catch-syscall.c: Sort headers.
4607         * break-catch-sig.c: Sort headers.
4608         * blockframe.c: Sort headers.
4609         * block.c: Sort headers.
4610         * bfin-tdep.c: Sort headers.
4611         * bfin-linux-tdep.c: Sort headers.
4612         * bfd-target.c: Sort headers.
4613         * bcache.c: Sort headers.
4614         * ax-general.c: Sort headers.
4615         * ax-gdb.h: Sort headers.
4616         * ax-gdb.c: Sort headers.
4617         * avr-tdep.c: Sort headers.
4618         * auxv.c: Sort headers.
4619         * auto-load.c: Sort headers.
4620         * arm-wince-tdep.c: Sort headers.
4621         * arm-tdep.c: Sort headers.
4622         * arm-symbian-tdep.c: Sort headers.
4623         * arm-pikeos-tdep.c: Sort headers.
4624         * arm-obsd-tdep.c: Sort headers.
4625         * arm-nbsd-tdep.c: Sort headers.
4626         * arm-nbsd-nat.c: Sort headers.
4627         * arm-linux-tdep.c: Sort headers.
4628         * arm-linux-nat.c: Sort headers.
4629         * arm-fbsd-tdep.c: Sort headers.
4630         * arm-fbsd-nat.c: Sort headers.
4631         * arm-bsd-tdep.c: Sort headers.
4632         * arch-utils.c: Sort headers.
4633         * arc-tdep.c: Sort headers.
4634         * arc-newlib-tdep.c: Sort headers.
4635         * annotate.h: Sort headers.
4636         * annotate.c: Sort headers.
4637         * amd64-windows-tdep.c: Sort headers.
4638         * amd64-windows-nat.c: Sort headers.
4639         * amd64-tdep.c: Sort headers.
4640         * amd64-sol2-tdep.c: Sort headers.
4641         * amd64-obsd-tdep.c: Sort headers.
4642         * amd64-obsd-nat.c: Sort headers.
4643         * amd64-nbsd-tdep.c: Sort headers.
4644         * amd64-nbsd-nat.c: Sort headers.
4645         * amd64-nat.c: Sort headers.
4646         * amd64-linux-tdep.c: Sort headers.
4647         * amd64-linux-nat.c: Sort headers.
4648         * amd64-fbsd-tdep.c: Sort headers.
4649         * amd64-fbsd-nat.c: Sort headers.
4650         * amd64-dicos-tdep.c: Sort headers.
4651         * amd64-darwin-tdep.c: Sort headers.
4652         * amd64-bsd-nat.c: Sort headers.
4653         * alpha-tdep.c: Sort headers.
4654         * alpha-obsd-tdep.c: Sort headers.
4655         * alpha-nbsd-tdep.c: Sort headers.
4656         * alpha-mdebug-tdep.c: Sort headers.
4657         * alpha-linux-tdep.c: Sort headers.
4658         * alpha-linux-nat.c: Sort headers.
4659         * alpha-bsd-tdep.c: Sort headers.
4660         * alpha-bsd-nat.c: Sort headers.
4661         * aix-thread.c: Sort headers.
4662         * agent.c: Sort headers.
4663         * addrmap.c: Sort headers.
4664         * ada-varobj.c: Sort headers.
4665         * ada-valprint.c: Sort headers.
4666         * ada-typeprint.c: Sort headers.
4667         * ada-tasks.c: Sort headers.
4668         * ada-lang.c: Sort headers.
4669         * aarch64-tdep.c: Sort headers.
4670         * aarch64-ravenscar-thread.c: Sort headers.
4671         * aarch64-newlib-tdep.c: Sort headers.
4672         * aarch64-linux-tdep.c: Sort headers.
4673         * aarch64-linux-nat.c: Sort headers.
4674         * aarch64-fbsd-tdep.c: Sort headers.
4675         * aarch64-fbsd-nat.c: Sort headers.
4676         * aarch32-linux-nat.c: Sort headers.
4677
4678 2019-04-04  Tom Tromey  <tom@tromey.com>
4679
4680         * varobj.c (varobj_create): Update.
4681         * rust-exp.y (struct rust_parser) <update_innermost_block,
4682         lookup_symbol>: New methods.
4683         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4684         Rename.
4685         (rust_parser::rust_lookup_type)
4686         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4687         * printcmd.c (display_command, do_one_display): Update.
4688         * parser-defs.h (struct parser_state) <parser_state>: Add
4689         "tracker" parameter.
4690         (block_tracker): New member.
4691         (class innermost_block_tracker) <innermost_block_tracker>: Add
4692         "types" parameter.
4693         <reset>: Remove method.
4694         (innermost_block): Don't declare.
4695         (null_post_parser): Update.
4696         * parse.c (innermost_block): Remove global.
4697         (write_dollar_variable): Update.
4698         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4699         Remove "tracker_types" parameter.
4700         (parse_expression): Add "tracker" parameter.
4701         (parse_expression_for_completion): Update.
4702         (null_post_parser): Add "tracker" parameter.
4703         * p-exp.y: Update rules.
4704         * m2-exp.y: Update rules.
4705         * language.h (struct language_defn) <la_post_parser>: Add
4706         "tracker" parameter.
4707         * go-exp.y: Update rules.
4708         * f-exp.y: Update rules.
4709         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4710         parameter.
4711         * d-exp.y: Update rules.
4712         * c-exp.y: Update rules.
4713         * breakpoint.c (set_breakpoint_condition): Create an
4714         innermost_block_tracker.
4715         (watch_command_1): Likewise.
4716         * ada-lang.c (resolve): Add "tracker" parameter.
4717         (resolve_subexp): Likewise.
4718         * ada-exp.y (write_var_from_sym): Update.
4719
4720 2019-04-04  Tom Tromey  <tom@tromey.com>
4721
4722         * type-stack.h: New file.
4723         * type-stack.c: New file.
4724         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4725         type-stack.h.
4726         (insert_into_type_stack, insert_type, push_type, push_type_int)
4727         (insert_type_address_space, pop_type, pop_type_int)
4728         (pop_typelist, pop_type_stack, append_type_stack)
4729         (push_type_stack, get_type_stack, push_typelist)
4730         (follow_type_instance_flags, follow_types): Don't declare.
4731         * parse.c (type_stack): Remove global.
4732         (parse_exp_in_context): Update.
4733         (insert_into_type_stack, insert_type, push_type, push_type_int)
4734         (insert_type_address_space, pop_type, pop_type_int)
4735         (pop_typelist, pop_type_stack, append_type_stack)
4736         (push_type_stack, get_type_stack, push_typelist)
4737         (follow_type_instance_flags, follow_types): Remove (moved to
4738         type-stack.c).
4739         * f-exp.y (type_stack): New global.
4740         Update rules.
4741         (push_kind_type, f_parse): Update.
4742         * d-exp.y (type_stack): New global.
4743         Update rules.
4744         (d_parse): Update.
4745         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4746         Update rules.
4747         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4748         (HFILES_NO_SRCDIR): Add type-stack.h.
4749
4750 2019-04-04  Tom Tromey  <tom@tromey.com>
4751
4752         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4753         (rust_parser::convert_ast_to_expression, rust_parse)
4754         (rust_lex_test_completion, rust_lex_tests): Update.
4755         * parser-defs.h (struct expr_completion_state): New.
4756         (struct parser_state) <parser_state>: Add completion parameter.
4757         <mark_struct_expression, mark_completion_tag>: New methods.
4758         <parse_completion, m_completion_state>: New members.
4759         (prefixify_expression, null_post_parser): Update.
4760         (mark_struct_expression, mark_completion_tag): Don't declare.
4761         * parse.c (parse_completion, expout_last_struct)
4762         (expout_tag_completion_type, expout_completion_name): Remove
4763         globals.
4764         (parser_state::mark_struct_expression)
4765         (parser_state::mark_completion_tag): Now methods.
4766         (prefixify_expression): Add last_struct parameter.
4767         (prefixify_subexp): Likewise.
4768         (parse_exp_1): Update.
4769         (parse_exp_in_context): Add cstate parameter.  Update.
4770         (parse_expression_for_completion): Create an
4771         expr_completion_state.
4772         (null_post_parser): Add "completion" parameter.
4773         * p-exp.y: Update rules.
4774         (yylex): Update.
4775         * language.h (struct language_defn) <la_post_parser>: Add
4776         "completing" parameter.
4777         * go-exp.y: Update rules.
4778         (lex_one_token): Update.
4779         * expression.h (parse_completion): Don't declare.
4780         * d-exp.y: Update rules.
4781         (lex_one_token): Update rules.
4782         * c-exp.y: Update rules.
4783         (lex_one_token): Update.
4784         * ada-lang.c (resolve): Add "parse_completion" parameter.
4785         (resolve_subexp): Likewise.
4786         (ada_resolve_function): Likewise.
4787
4788 2019-04-04  Tom Tromey  <tom@tromey.com>
4789
4790         * parser-defs.h (struct parser_state) <start_arglist,
4791         end_arglist>: New methods.
4792         <arglist_len, m_funcall_chain>: New members.
4793         (arglist_len, start_arglist, end_arglist): Don't declare.
4794         * parse.c (arglist_len, funcall_chain): Remove global.
4795         (start_arglist, end_arglist): Remove functions.
4796         (parse_exp_in_context): Update.
4797         * p-exp.y: Update rules.
4798         * m2-exp.y: Update rules.
4799         * go-exp.y: Update rules.
4800         * f-exp.y: Update rules.
4801         * d-exp.y: Update rules.
4802         * c-exp.y: Update rules.
4803
4804 2019-04-04  Tom Tromey  <tom@tromey.com>
4805
4806         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4807         lex_operator, push_back>: New methods.
4808         Update all rules.
4809         (rust_parser::lex_hex, lex_escape): Rename and update.
4810         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4811         (rust_parser::lex_operator): Rename and update.
4812         (rust_parser::lex_number, rustyylex, rustyyerror)
4813         (rust_lex_test_init, rust_lex_test_sequence)
4814         (rust_lex_test_push_back, rust_lex_tests): Update.
4815         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4816         parameter.
4817         <lexptr, prev_lexptr>: New members.
4818         (lexptr, prev_lexptr): Don't declare.
4819         * parse.c (lexptr, prev_lexptr): Remove globals.
4820         (parse_exp_in_context): Update.
4821         * p-exp.y (yylex, yyerror): Update.
4822         * m2-exp.y (parse_number, yylex, yyerror): Update.
4823         * go-exp.y (lex_one_token, yyerror): Update.
4824         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4825         * d-exp.y (lex_one_token, yyerror): Update.
4826         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4827         (lex_one_token, yyerror): Update.
4828         * ada-lex.l (YY_INPUT): Update.
4829         (rewind_to_char): Update.
4830         * ada-exp.y (yyerror): Update.
4831
4832 2019-04-04  Tom Tromey  <tom@tromey.com>
4833
4834         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4835         * parser-defs.h (struct parser_state) <parser_state>: Add new
4836         parameter.
4837         <comma_terminates>: New member.
4838         (comma_terminates): Don't declare global.
4839         * parse.c (comma_terminates): Remove global.
4840         (parse_exp_in_context): Update.
4841         * p-exp.y (yylex): Update.
4842         * m2-exp.y (yylex): Update.
4843         * go-exp.y (lex_one_token): Update.
4844         * f-exp.y (yylex): Update.
4845         * d-exp.y (lex_one_token): Update.
4846         * c-exp.y (lex_one_token): Update.
4847         * ada-lex.l: Update.
4848
4849 2019-04-04  Tom Tromey  <tom@tromey.com>
4850
4851         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4852         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4853         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4854         * parser-defs.h (paren_depth): Don't declare.
4855         * parse.c (paren_depth): Remove global.
4856         (parse_exp_in_context): Update.
4857         * p-exp.y (paren_depth): New global.
4858         (pascal_parse): Initialize it.
4859         * m2-exp.y (paren_depth): New global.
4860         (m2_parse): Initialize it.
4861         * go-exp.y (paren_depth): New global.
4862         (go_parse): Initialize it.
4863         * f-exp.y (paren_depth): New global.
4864         (f_parse): Initialize it.
4865         * d-exp.y (paren_depth): New global.
4866         (d_parse): Initialize it.
4867         * c-exp.y (paren_depth): New global.
4868         (c_parse): Initialize it.
4869         * ada-lex.l (paren_depth): New global.
4870         (lexer_init): Initialize it.
4871
4872 2019-04-04  Tom Tromey  <tom@tromey.com>
4873
4874         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4875         (rust_parser::convert_ast_to_type)
4876         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4877         * parser-defs.h (struct parser_state) <parser_state>: Add
4878         parameters.  Initialize new members.
4879         <expression_context_block, expression_context_pc>: New members.
4880         * parse.c (expression_context_block, expression_context_pc):
4881         Remove globals.
4882         (parse_exp_in_context): Update.
4883         * p-exp.y: Update all rules.
4884         (yylex): Update.
4885         * m2-exp.y: Update all rules.
4886         (yylex): Update.
4887         * go-exp.y (yylex): Update.
4888         * f-exp.y (yylex): Update.
4889         * d-exp.y: Update all rules.
4890         (yylex): Update.
4891         * c-exp.y: Update all rules.
4892         (lex_one_token, classify_name, yylex, c_parse): Update.
4893         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4894
4895 2019-04-04  Tom Tromey  <tom@tromey.com>
4896
4897         * gdbarch.h, gdbarch.c: Rebuild.
4898         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4899         * stap-probe.h:
4900         (struct stap_parse_info): Replace "parser_state" with
4901         "expr_builder".
4902         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4903         (parser_state): New class.
4904         * parse.c (expr_builder): Rename.
4905         (expr_builder::release): Rename.
4906         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4907         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4908         (write_exp_elt_longcst, write_exp_elt_floatcst)
4909         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4910         (write_exp_string_vector, write_exp_bitstring)
4911         (write_exp_msymbol, mark_struct_expression)
4912         (write_dollar_variable)
4913         (insert_type_address_space, increase_expout_size): Replace
4914         "parser_state" with "expr_builder".
4915         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4916         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4917         "parser_state" with "expr_builder".
4918
4919 2019-04-04  Tom Tromey  <tom@tromey.com>
4920
4921         * rust-exp.y: Replace "parse_language" with method call.
4922         * p-exp.y:
4923         (yylex): Replace "parse_language" with method call.
4924         * m2-exp.y:
4925         (yylex): Replace "parse_language" with method call.
4926         * go-exp.y (classify_name): Replace "parse_language" with method
4927         call.
4928         * f-exp.y (yylex): Replace "parse_language" with method call.
4929         * d-exp.y (lex_one_token): Replace "parse_language" with method
4930         call.
4931         * c-exp.y:
4932         (lex_one_token, classify_name, yylex): Replace "parse_language"
4933         with method call.
4934         * ada-exp.y (find_primitive_type, type_char)
4935         (type_system_address): Replace "parse_language" with method call.
4936
4937 2019-04-04  Tom Tromey  <tom@tromey.com>
4938
4939         * rust-exp.y: Replace "parse_gdbarch" with method call.
4940         * parse.c (write_dollar_variable, insert_type_address_space):
4941         Replace "parse_gdbarch" with method call.
4942         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4943         call.
4944         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4945         call.
4946         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4947         "parse_gdbarch" with method call.
4948         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4949         with method call.
4950         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4951         "parse_gdbarch" with method call.
4952         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4953         "parse_gdbarch" with method call.
4954         * c-exp.y (parse_type, parse_number, classify_name): Replace
4955         "parse_gdbarch" with method call.
4956         * ada-lex.l: Replace "parse_gdbarch" with method call.
4957         * ada-exp.y (parse_type, find_primitive_type, type_char)
4958         (type_system_address): Replace "parse_gdbarch" with method call.
4959
4960 2019-04-04  Tom Tromey  <tom@tromey.com>
4961
4962         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4963         * stap-probe.c (stap_parse_argument): Update.
4964         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4965         initial_size parameter.
4966         * rust-exp.y (rust_lex_tests): Update.
4967         * parse.c (parser_state): Update.
4968         (parse_exp_in_context): Update.
4969         * parser-defs.h (struct parser_state) <parser_state>: Remove
4970         "initial_size" parameter.
4971
4972 2019-04-04  Tom Tromey  <tom@tromey.com>
4973
4974         * parser-defs.h (increase_expout_size): Don't declare.
4975         * parse.c (increase_expout_size): Now static.
4976
4977 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4978
4979         * gnu-nat.c (gnu_nat_target::wait): Fix
4980         target_waitstatus_to_string call.
4981
4982 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * eval.c (evaluate_subexp_standard): Handle internal functions
4985         during Fortran function call handling.
4986
4987 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4988
4989         * NEWS: Mention new internal functions.
4990         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4991         (read_base_type): Use dwarf2_init_complex_target_type.
4992         * value.c (creal_internal_fn): New function.
4993         (cimag_internal_fn): New function.
4994         (_initialize_values): Register new internal functions.
4995
4996 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4997
4998         * infrun.c (stop_all_threads): If debug_infrun, always
4999         trace the wait status after wait_one, using
5000         target_waitstatus_to_string and target_pid_to_str.
5001         (handle_inferior_event): Replace various trace of
5002         wait status kind by a single trace.
5003         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
5004         wait status kind image by target_waitstatus_to_string.
5005         * target/waitstatus.c (target_waitstatus_to_string): Fix
5006         obsolete comment.
5007
5008 2019-04-01  Tom Tromey  <tromey@adacore.com>
5009
5010         PR symtab/23331:
5011         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
5012
5013 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
5014             Pedro Alves  <palves@redhat.com>
5015
5016         * top.c (quit_force): Call 'finalize_values'.
5017         * value.c (finalize_values): New function.
5018         * value.h (finalize_values): Declare.
5019
5020 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
5021
5022         * NEWS: Announce $_gdb_major and $_gdb_minor.
5023
5024         * top.c (init_gdb_version_vars): New function.
5025         (gdb_init): Call init_gdb_version_vars.
5026
5027 2019-03-29  Tom Tromey  <tromey@adacore.com>
5028
5029         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
5030         help text.  Remove dead code.
5031
5032 2019-03-29  Keith Seitz  <keiths@redhat.com>
5033
5034         From Siddhesh Poyarekar:
5035         * f-lang.h (f77_get_upperbound): Return LONGEST.
5036         (f77_get_lowerbound): Likewise.
5037         * f-typeprint.c (f_type_print_varspec_suffix): Expand
5038         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
5039         print them.
5040         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
5041         plongest to format print it.
5042         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
5043         (f77_get_upperbound): Likewise.
5044         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
5045         LOWER_BOUND to LONGEST.
5046         (f77_create_arrayprint_offset_tbl): Likewise.
5047
5048 2019-03-29  Keith Seitz  <keiths@redhat.com>
5049
5050         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
5051         %s/pulongest for TYPE_LENGTH instead of %d in format
5052         strings.
5053         * ada-typerint.c (ada_print_type): Likewise.
5054         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
5055         * compile/compile-c-support.c (generate_register_struct): Likewise.
5056         * gdbtypes.c (recursive_dump_type): Likewise.
5057         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
5058         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
5059         instead of %d in format strings.
5060         * riscv-tdep.c (riscv_type_alignment): Cast second argument
5061         to std::min to ULONGEST.
5062         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
5063         instead of %d in format strings.
5064         * tracepoint.c (info_scope_command): Likewise.
5065         * typeprint.c (print_offset_data::update)
5066         (print_offset_data::finish): Likewise.
5067         * xtensa-tdep.c (xtensa_store_return_value)
5068         (xtensa_push_dummy_call): Likewise.
5069
5070 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
5071
5072         * windows-nat.c (display_selector): Fixed format specifications
5073         for 64-bit Cygwin.
5074
5075 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5076
5077         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
5078
5079 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
5080
5081         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
5082         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
5083         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
5084         (nios2_linux_init_abi): Install it.
5085
5086 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5087
5088         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
5089
5090 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
5091
5092         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
5093
5094 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5095             Tom Tromey  <tromey@adacore.com>
5096
5097         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
5098
5099 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
5100
5101         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
5102         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
5103         method to compute the bounds of range types. Also print "[evaluated]"
5104         if the bounds' values come from a dynamic evaluation.
5105
5106 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5107
5108         * cp-valprint.c (cp_print_value_fields): Don't print trailing
5109         whitespace when pretty printing is on.
5110
5111 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5112
5113         * ppc-linux-nat.c: Add include.
5114
5115 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5116
5117         * NEWS: Mention AArch64 Pointer Authentication.
5118
5119 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
5120
5121         * arm-linux-nat.c: Add include.
5122
5123 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
5124
5125         * source-cache.c (source_cache::get_source_lines): Re-read
5126         fullname after calling open_source_file.
5127
5128 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
5129
5130         * NEWS: Mention TLS support for FreeBSD.
5131
5132 2019-03-25  Tom Tromey  <tromey@adacore.com>
5133
5134         * minsyms.c (BUNCH_SIZE): Update comment.
5135         (~minimal_symbol_reader): Remove old comment.
5136         (compact_minimal_symbols): Update comment.
5137         (minimal_symbol_reader::install): Remove old comment.  Update
5138         other comments.
5139
5140 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5141
5142         * s390-linux-nat.c: Add include.
5143
5144 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
5145
5146         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5147         Call linux_get_hwcap.
5148         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
5149         Likewise.
5150         (aarch64_linux_get_hwcap): Remove function.
5151         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
5152         declaration.
5153         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
5154         linux_get_hwcap.
5155         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5156         * linux-tdep.c (linux_get_hwcap): Add function.
5157         (linux_get_hwcap2): Likewise.
5158         * linux-tdep.h (linux_get_hwcap): Add declaration.
5159         (linux_get_hwcap2): Likewise.
5160         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
5161         (ppc_linux_get_hwcap2): Likewise.
5162         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
5163         linux_get_hwcap.
5164         (ppc_linux_nat_target::insert_watchpoint): Likewise.
5165         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
5166         (ppc_linux_nat_target::read_description): Likewise.
5167         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
5168         * s390-linux-nat.c: Likewise.
5169         * s390-linux-tdep.c (s390_core_read_description): Likewise.
5170
5171 2019-03-24  Tom Tromey  <tom@tromey.com>
5172
5173         * ada-lang.c (standard_lookup): Simplify initialization.
5174         (ada_lookup_symbol_nonlocal): Simplify return.
5175         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
5176         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
5177         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
5178         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
5179         initialization.
5180         * solib.c (solib_global_lookup): Simplify.
5181         * symtab.c (null_block_symbol): Remove.
5182         (symbol_cache_lookup): Simplify returns.
5183         (lookup_language_this): Simplify returns.
5184         (lookup_symbol_aux): Simplify return.
5185         (lookup_local_symbol): Simplify returns.
5186         (lookup_global_symbol_from_objfile): Simplify return.
5187         (lookup_symbol_in_objfile_symtabs)
5188         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
5189         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
5190         (lookup_static_symbol, lookup_global_symbol): Simplify return.
5191         * cp-namespace.c (cp_lookup_bare_symbol)
5192         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
5193         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
5194         (cp_lookup_nested_symbol): Don't use null_block_symbol.
5195         (cp_lookup_symbol_via_imports): Simplify initialization.
5196         (find_symbol_in_baseclass): Likewise.
5197         * symtab.h (null_block_symbol): Remove.
5198         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
5199         (d_lookup_nested_symbol, d_lookup_symbol_imports)
5200         (d_lookup_symbol_module): Likewise.
5201         (find_symbol_in_baseclass): Simplify initialization.
5202
5203 2019-03-24  Tom Tromey  <tom@tromey.com>
5204
5205         * expression.h: Don't include symtab.h.
5206         (struct block): Forward declare.
5207
5208 2019-03-24  Tom Tromey  <tom@tromey.com>
5209
5210         * c-exp.y (typebase): Remove casts.
5211         * gdbtypes.c (lookup_unsigned_typename, )
5212         (lookup_signed_typename): Remove cast.
5213         * eval.c (parse_to_comma_and_eval): Remove cast.
5214         * parse.c (write_dollar_variable): Remove cast.
5215         * block.h (struct block) <superblock>: Now const.
5216         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
5217         * psymtab.c (psym_map_matching_symbols): Make "block" const.
5218         (map_block): Make "block" const.
5219         * symfile.h (struct quick_symbol_functions)
5220         <map_matching_symbols>: Constify block argument to "callback".
5221         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
5222         const.
5223         (find_pc_sect_compunit_symtab): Make "b" const.
5224         (find_symbol_at_address): Likewise.
5225         (search_symbols): Likewise.
5226         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
5227         (dw2_debug_names_lookup_symbol): Likewise.
5228         (dw2_map_matching_symbols): Update.
5229         * p-valprint.c (pascal_val_print): Remove "block".
5230         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
5231         (aux_add_nonlocal_symbols): Make "block" const.
5232         (resolve_subexp): Remove cast.
5233         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
5234         const.
5235         (iterate_over_file_blocks): Likewise.
5236         * f-exp.y (%union) <bval>: Remove.
5237         * coffread.c (patch_opaque_types): Make "b" const.
5238         * spu-tdep.c (spu_catch_start): Make "block" const.
5239         * c-valprint.c (print_unpacked_pointer): Remove "block".
5240         * symmisc.c (dump_symtab_1): Make "b" const.
5241         (block_depth): Make "block" const.
5242         * d-exp.y (%union) <bval>: Remove.
5243         * cp-support.h (cp_lookup_rtti_type): Update.
5244         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
5245         * psymtab.c (psym_lookup_symbol): Make "block" const.
5246         (maintenance_check_psymtabs): Make "b" const.
5247         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
5248         (enumerate_locals, enumerate_args): Update.
5249         * python/py-symtab.c (stpy_global_block): Make "block" const.
5250         (stpy_static_block): Likewise.
5251         * inline-frame.c (block_starting_point_at): Make "new_block"
5252         const.
5253         * block.c (find_block_in_blockvector): Make return type const.
5254         (blockvector_for_pc_sect): Make "b" const.
5255         (find_block_in_blockvector): Make "b" const.
5256
5257 2019-03-23  Tom Tromey  <tom@tromey.com>
5258
5259         * varobj.c (varobj_create): Update.
5260         * symfile.c (clear_symtab_users): Don't reset innermost_block.
5261         * printcmd.c (display_command, do_one_display): Don't reset
5262         innermost_block.
5263         * parser-defs.h (enum innermost_block_tracker_type): Move to
5264         expression.h.
5265         (innermost_block): Update comment.
5266         * parse.c (parse_exp_1): Add tracker_types parameter.
5267         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
5268         tracker_types parameter.  Reset innermost_block.
5269         (parse_exp_in_context): Remove.
5270         (parse_expression_for_completion): Update.
5271         * objfiles.c (~objfile): Don't reset expression_context_block or
5272         innermost_block.
5273         * expression.h (enum innermost_block_tracker_type): Move from
5274         parser-defs.h.
5275         (parse_exp_1): Add tracker_types parameter.
5276         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
5277         reset innermost_block.
5278
5279 2019-03-23  Tom Tromey  <tom@tromey.com>
5280
5281         * objfiles.h: Include bcache.h.
5282
5283 2019-03-23  Tom Tromey  <tom@tromey.com>
5284
5285         * linespec.c (get_current_search_block): Use
5286         scoped_restore_current_language.
5287         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
5288
5289 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5290             Jiong Wang  <jiong.wang@arm.com>
5291
5292         * aarch64-linux-tdep.c
5293         (aarch64_linux_iterate_over_regset_sections): Check for pauth
5294         section.
5295         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
5296
5297 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5298             Jiong Wang  <jiong.wang@arm.com>
5299
5300         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
5301         instructions.
5302         (aarch64_analyze_prologue_test): Add PACIASP test.
5303         (aarch64_prologue_prev_register): Unmask PC value.
5304
5305 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5306             Jiong Wang  <jiong.wang@arm.com>
5307
5308         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
5309         (aarch64_dwarf2_prev_register): Unmask PC value.
5310         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
5311         (aarch64_execute_dwarf_cfa_vendor_op): Check for
5312         DW_CFA_AARCH64_negate_ra_state.
5313         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
5314
5315 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5316             Jiong Wang  <jiong.wang@arm.com>
5317
5318         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
5319         registers.
5320         (aarch64_pseudo_register_name): Likewise.
5321         (aarch64_pseudo_register_type): Likewise.
5322         (aarch64_pseudo_register_reggroup_p): Likewise.
5323         (aarch64_gdbarch_init): Add pauth registers.
5324         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
5325         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
5326         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
5327         (struct gdbarch_tdep): Add regnum for ra_state.
5328
5329 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5330             Jiong Wang  <jiong.wang@arm.com>
5331
5332         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
5333
5334 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5335             Jiong Wang  <jiong.wang@arm.com>
5336
5337         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
5338         function.
5339         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
5340         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
5341         (aarch64_gdbarch_init): Add puth registers.
5342         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
5343         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
5344         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
5345
5346 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5347             Jiong Wang  <jiong.wang@arm.com>
5348
5349         * aarch64-linux-nat.c
5350         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
5351         * aarch64-linux-tdep.c
5352         (aarch64_linux_core_read_description): Likewise.
5353         (aarch64_linux_get_hwcap): New function.
5354         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
5355         (aarch64_linux_get_hwcap): New declaration.
5356
5357 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
5358             Jiong Wang  <jiong.wang@arm.com>
5359
5360         * aarch64-linux-nat.c
5361         (aarch64_linux_nat_target::read_description): Add pauth param.
5362         * aarch64-linux-tdep.c
5363         (aarch64_linux_core_read_description): Likewise.
5364         * aarch64-tdep.c (struct target_desc): Add in pauth.
5365         (aarch64_read_description): Add pauth param.
5366         (aarch64_gdbarch_init): Likewise.
5367         * aarch64-tdep.h (aarch64_read_description): Likewise.
5368         * arch/aarch64.c (aarch64_create_target_description): Likewise.
5369         * arch/aarch64.h (aarch64_create_target_description): Likewise.
5370         * features/Makefile: Add new files.
5371         * features/aarch64-pauth.c: New file.
5372         * features/aarch64-pauth.xml: New file.
5373
5374 2019-03-20  Tom Tromey  <tromey@adacore.com>
5375
5376         * infrun.c (handle_inferior_event): Rename from
5377         handle_inferior_event_1.  Create a scoped_value_mark.
5378         (handle_inferior_event): Remove.
5379
5380 2019-03-19  Tom Tromey  <tromey@adacore.com>
5381
5382         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
5383         * infrun.h (print_stop_event): Add "displays" parameter.
5384         * infrun.c (print_stop_event): Add "displays" parameter.
5385
5386 2019-03-19  Pedro Alves  <palves@redhat.com>
5387
5388         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
5389         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
5390         to -1.  Fix TABs vs spaces.
5391         (tui_ui_out::tui_ui_out): Don't initialize fields here.
5392         * tui/tui-out.h (tui_ui_out) Add intro comments.
5393         <m_line, m_start_of_line>: In-class initialize, and add describing
5394         comment.
5395
5396 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
5397
5398         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
5399         variable names.
5400         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
5401
5402 2019-03-18  Pedro Alves  <palves@redhat.com>
5403             Eli Zaretskii <eliz@gnu.org>
5404
5405         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
5406         m_line and m_start_of_line.
5407
5408 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
5409
5410         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
5411         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
5412         it returns a newline.  This fixes a regression in TU mode, whereby
5413         the next line is output on the same screen line as the user input.
5414
5415 2019-03-18  Tom Tromey  <tromey@adacore.com>
5416
5417         * minsyms.c (minimal_symbol_reader::install): Remove call to
5418         obstack_blank.
5419
5420 2019-03-18  Pedro Alves  <palves@redhat.com>
5421
5422         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
5423         New globals.
5424         (apply_style): New, factored out from ...
5425         (apply_ansi_escape): ... this.  Handle reverse video mode.
5426         (tui_set_reverse_mode): New function.
5427         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
5428         * tui/tui-winsource.c (tui_show_source_line): Use
5429         tui_set_reverse_mode instead of setting A_STANDOUT.
5430         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
5431         New setter methods.
5432
5433 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
5434
5435         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
5436         Handle tabs.
5437
5438 2019-03-18  Tom Tromey  <tromey@adacore.com>
5439
5440         * ada-lang.c (empty_array): Add "high" parameter.
5441         (ada_evaluate_subexp): Update.
5442
5443 2019-03-17  Sergei Trofimovich <siarheit@google.com>
5444
5445         * unittests/string_view-selftests.c: Define
5446         _initialize_string_view_selftests unconditionally.
5447
5448 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5449
5450         PR gdb/24350
5451         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
5452
5453 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
5454
5455         PR gdb/24351
5456         * windows-nat.c (display_selector): Fix format specifiers.
5457
5458 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
5459
5460         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
5461         tui_refill_source_window instead of tui_refresh_win, to update the
5462         current execution line.  This fixes redisplay of the current line
5463         when stepping through the code with "next" or "step".
5464
5465 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5466
5467         * source-cache.c (source_cache::get_source_lines): Call
5468         find_source_lines to initialize s->nlines.  This fixes vertical
5469         scrolling of TUI source window when the DOWN arrow is pressed.
5470
5471 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5472
5473         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
5474         linux-thread-db.c (_initialize_thread_db): Likewise.
5475
5476 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
5477
5478         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
5479         wclrtoeol in tui_show_source_line".  This reverts changes made in
5480         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
5481
5482 2019-03-15  Tom Tromey  <tom@tromey.com>
5483
5484         * symtab.h (struct minimal_symbol): Derive from
5485         general_symbol_info.
5486         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
5487         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
5488         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
5489         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
5490         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
5491         (MSYMBOL_SEARCH_NAME): Update.
5492         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
5493         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
5494         * minsyms.c (minimal_symbol_reader::record_full): Update.
5495
5496 2019-03-15  Tom Tromey  <tom@tromey.com>
5497
5498         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
5499
5500 2019-03-15  Tom Tromey  <tom@tromey.com>
5501
5502         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
5503         unique_xmalloc_ptr.
5504         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
5505         Update.
5506         * minsyms.c (lookup_minimal_symbol_by_pc_section)
5507         (build_minimal_symbol_hash_tables)
5508         (minimal_symbol_reader::install): Update.
5509
5510 2019-03-15  Tom Tromey  <tom@tromey.com>
5511
5512         * symtab.c (create_demangled_names_hash): Update.
5513         (symbol_set_names): Update.
5514         * objfiles.h (struct objfile_per_bfd_storage)
5515         <demangled_names_hash>: Now an htab_up.
5516         * objfiles.c (objfile_per_bfd_storage): Simplify.
5517
5518 2019-03-15  Tom Tromey  <tom@tromey.com>
5519
5520         * objfiles.h (struct objfile_per_bfd_storage): Declare
5521         destructor.
5522         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
5523         New.
5524         (get_objfile_bfd_data): Use new.  Don't initialize
5525         language_of_main.
5526         (free_objfile_per_bfd_storage): Remove.
5527         (objfile_bfd_data_free, objfile::~objfile): Use delete.
5528
5529 2019-03-15  Tom Tromey  <tom@tromey.com>
5530
5531         * symfile.c (reread_symbols): Update.
5532         * objfiles.c (objfile::objfile): Update.
5533         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
5534         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
5535         comment.
5536         (minimal_symbol_reader::install): Update.
5537         (terminate_minimal_symbol_table): Remove.
5538         * jit.c (jit_object_close_impl): Update.
5539
5540 2019-03-15  Tom Tromey  <tom@tromey.com>
5541
5542         * minsyms.c (minimal_symbol_reader::record_full): Remove some
5543         initializations.
5544
5545 2019-03-15  Tom Tromey  <tom@tromey.com>
5546
5547         * objfiles.h (struct objfile_per_bfd_storage)
5548         <demangled_hash_languages>: Now a bitset.
5549         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
5550         (lookup_minimal_symbol): Update.
5551
5552 2019-03-15  Tom Tromey  <tom@tromey.com>
5553
5554         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
5555         Don't return the symbol.
5556         * coffread.c (record_minimal_symbol): Use record_full.
5557
5558 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
5559
5560         The MS-Windows port of ncurses fails to switch to a color pair if
5561         one or both of the colors are the implicit default colors.  This
5562         change records the default colors when TUI is initialized, and
5563         then specifies them explicitly when a color pair uses the default
5564         colors.  This allows color styling in TUI mode on MS-Windows.
5565
5566         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
5567         ncurses_norm_attr.
5568         (tui_initialize_io) [__MINGW32__]: Record the default terminal
5569         colors in ncurses_norm_attr.
5570         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
5571         "none", replace it with the default color recorded in
5572         ncurses_norm_attr.
5573
5574 2019-03-14  Tom Tromey  <tromey@adacore.com>
5575
5576         * source-cache.h (class source_cache) <get_source_lines>: Return
5577         std::string.
5578         * source-cache.c (source_cache::extract_lines): Handle case where
5579         first_pos==npos.  Return std::string.
5580         (source_cache::get_source_lines): Update.
5581
5582 2019-03-14  Tom Tromey  <tromey@adacore.com>
5583
5584         * NEWS: Add item for "style sources" commands.
5585         * source-cache.c (source_cache::get_source_lines): Check
5586         source_styling.
5587         * cli/cli-style.c (source_styling): New global.
5588         (_initialize_cli_style): Add "style sources" commands.
5589         (show_style_sources): New function.
5590         * cli/cli-style.h (source_styling): Declare.
5591
5592 2019-03-14  Pedro Alves  <palves@redhat.com>
5593             Tom Tromey  <tromey@adacore.com>
5594
5595         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5596         * tui/tui-winsource.c (tui_refill_source_window): New function,
5597         from...
5598         (tui_horizontal_source_scroll): ... here.  Move some logic.
5599         * cli/cli-style.c (set_style_enabled): Notify new observable.
5600         * tui/tui-hooks.c (tui_redisplay_source): New function.
5601         (tui_attach_detach_observers): Attach or detach
5602         tui_redisplay_source.
5603         * observable.h (source_styling_changed): New observable.
5604         * observable.c: Define source_styling_changed observable.
5605
5606 2019-03-13  Tom Tromey  <tromey@adacore.com>
5607
5608         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5609         (i386_gnu_nat_target::store_registers): Update.
5610         * target-debug.h (target_debug_print_std_string): New macro.
5611         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5612         * windows-tdep.c (display_one_tib): Update.
5613         * tui/tui-stack.c (tui_make_status_line): Update.
5614         * top.c (print_inferior_quit_action): Update.
5615         * thread.c (thr_try_catch_cmd): Update.
5616         (add_thread_with_info): Update.
5617         (thread_target_id_str): Update.
5618         (thr_try_catch_cmd): Update.
5619         (thread_command): Update.
5620         (thread_find_command): Update.
5621         * record-btrace.c (record_btrace_target::info_record)
5622         (record_btrace_resume_thread, record_btrace_target::resume)
5623         (record_btrace_cancel_resume, record_btrace_step_thread)
5624         (record_btrace_target::wait, record_btrace_target::wait)
5625         (record_btrace_target::wait, record_btrace_target::stop): Update.
5626         * progspace.c (print_program_space): Update.
5627         * process-stratum-target.c
5628         (process_stratum_target::thread_address_space): Update.
5629         * linux-fork.c (linux_fork_mourn_inferior)
5630         (detach_checkpoint_command, info_checkpoints_command)
5631         (linux_fork_context): Update.
5632         (linux_fork_detach): Update.
5633         (class scoped_switch_fork_info): Update.
5634         (delete_checkpoint_command): Update.
5635         * infrun.c (follow_fork_inferior): Update.
5636         (follow_fork_inferior): Update.
5637         (proceed_after_vfork_done): Update.
5638         (handle_vfork_child_exec_or_exit): Update.
5639         (follow_exec): Update.
5640         (displaced_step_prepare_throw): Update.
5641         (displaced_step_restore): Update.
5642         (start_step_over): Update.
5643         (resume_1): Update.
5644         (clear_proceed_status_thread): Update.
5645         (proceed): Update.
5646         (print_target_wait_results): Update.
5647         (do_target_wait): Update.
5648         (context_switch): Update.
5649         (stop_all_threads): Update.
5650         (restart_threads): Update.
5651         (finish_step_over): Update.
5652         (handle_signal_stop): Update.
5653         (switch_back_to_stepped_thread): Update.
5654         (keep_going_pass_signal): Update.
5655         (print_exited_reason): Update.
5656         (normal_stop): Update.
5657         * inferior.c (inferior_pid_to_str): Change return type.
5658         (print_selected_inferior): Update.
5659         (add_inferior): Update.
5660         (detach_inferior): Update.
5661         * dummy-frame.c (fprint_dummy_frames): Update.
5662         * dcache.c (dcache_info_1): Update.
5663         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5664         (btrace_fetch, btrace_clear): Update.
5665         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5666         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5667         type.
5668         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5669         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5670         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5671         * gdbarch.c, gdbarch.h: Rebuild.
5672         * gdbarch.sh (core_pid_to_str): Change return type.
5673         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5674         return type.
5675         (windows_nat_target::pid_to_str): Change return type.
5676         (windows_delete_thread): Update.
5677         (windows_nat_target::attach): Update.
5678         (windows_nat_target::files_info): Update.
5679         * target-delegates.c: Rebuild.
5680         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5681         return type.
5682         (sol_thread_target::pid_to_str): Change return type.
5683         * remote.c (class remote_target) <pid_to_str>: Change return
5684         type.
5685         (remote_target::pid_to_str): Change return type.
5686         (extended_remote_target::attach, remote_target::remote_stop_ns)
5687         (remote_target::remote_notif_remove_queued_reply)
5688         (remote_target::push_stop_reply, remote_target::disable_btrace):
5689         Update.
5690         (extended_remote_target::attach): Update.
5691         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5692         type.
5693         (gdbsim_target::pid_to_str): Change return type.
5694         * ravenscar-thread.c (struct ravenscar_thread_target)
5695         <pid_to_str>: Change return type.
5696         (ravenscar_thread_target::pid_to_str): Change return type.
5697         * procfs.c (class procfs_target) <pid_to_str>: Change return
5698         type.
5699         (procfs_target::pid_to_str): Change return type.
5700         (procfs_target::attach): Update.
5701         (procfs_target::detach): Update.
5702         (procfs_target::fetch_registers): Update.
5703         (procfs_target::store_registers): Update.
5704         (procfs_target::wait): Update.
5705         (procfs_target::files_info): Update.
5706         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5707         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5708         return type.
5709         (nto_procfs_target::pid_to_str): Change return type.
5710         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5711         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5712         return type.
5713         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5714         (exit_lwp): Update.
5715         (attach_proc_task_lwp_callback, get_detach_signal)
5716         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5717         (linux_nat_target::resume, wait_lwp, stop_callback)
5718         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5719         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5720         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5721         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5722         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5723         type.
5724         (inf_ptrace_target::attach): Update.
5725         (inf_ptrace_target::files_info): Update.
5726         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5727         type.
5728         (go32_nat_target::pid_to_str): Change return type.
5729         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5730         (gnu_nat_target::wait): Update.
5731         (gnu_nat_target::wait): Update.
5732         (gnu_nat_target::resume): Update.
5733         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5734         (fbsd_nat_target::wait): Update.
5735         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5736         type.
5737         (darwin_nat_target::attach): Update.
5738         * corelow.c (class core_target) <pid_to_str>: Change return type.
5739         (core_target::pid_to_str): Change return type.
5740         * target.c (normal_pid_to_str): Change return type.
5741         (default_pid_to_str): Likewise.
5742         (target_pid_to_str): Change return type.
5743         (target_translate_tls_address): Update.
5744         (target_announce_detach): Update.
5745         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5746         return type.
5747         (bsd_uthread_target::pid_to_str): Change return type.
5748         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5749         type.
5750         (bsd_kvm_target::pid_to_str): Change return type.
5751         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5752         return type.
5753         (aix_thread_target::pid_to_str): Change return type.
5754         * target.h (struct target_ops) <pid_to_str>: Change return type.
5755         (target_pid_to_str, normal_pid_to_str): Likewise.
5756         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5757         type.
5758         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5759         type.
5760         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5761         return type.
5762         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5763         type.
5764         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5765         type.
5766         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5767         return type.
5768
5769 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5770
5771         * NEWS: Mention that the new default MI version is 3.  Mention
5772         changes to the output of commands and events that deal with
5773         multi-location breakpoints.
5774         * breakpoint.c: Include "mi/mi-out.h".
5775         (print_one_breakpoint): Change output syntax if using MI version
5776         >= 3.
5777         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5778         New.
5779         (mi_multi_location_breakpoint_output_fixed): New.
5780         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5781         (mi_cmd_fix_multi_location_breakpoint_output): New.
5782         (mi_multi_location_breakpoint_output_fixed): New.
5783         * mi/mi-cmds.c (mi_cmds): Register command
5784         -fix-multi-location-breakpoint-output.
5785         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5786         interpreter "mi".
5787
5788 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5789
5790         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5791         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5792         instantiate mi_ui_out based on interpreter name.
5793         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5794         * mi/mi-main.c (mi_load_progress): Likewise.
5795
5796 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5797
5798         * NEWS: Combine separate "New targets" sections for 8.3.
5799
5800 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5801
5802         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5803         (ppcfbsd_init_abi): Install gdbarch
5804         "fetch_tls_load_module_address" and "get_thread_local_address"
5805         methods.
5806
5807 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5808
5809         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5810         (riscv_fbsd_init_abi): Install gdbarch
5811         "fetch_tls_load_module_address" and "get_thread_local_address"
5812         methods.
5813
5814 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5815
5816         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5817         (i386fbsd_init_abi): Install gdbarch
5818         "fetch_tls_load_module_address" and "get_thread_local_address"
5819         methods.
5820
5821 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5822
5823         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5824         (amd64fbsd_init_abi): Install gdbarch
5825         "fetch_tls_load_module_address" and "get_thread_local_address"
5826         methods.
5827
5828 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5829
5830         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5831         (struct fbsd_pspace_data): New type.
5832         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5833         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5834         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5835         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5836         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5837
5838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5839
5840         * gdbtypes.c (lookup_struct_elt): New function.
5841         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5842         * gdbtypes.h (struct struct_elt): New type.
5843         (lookup_struct_elt): New prototype.
5844
5845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5846
5847         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5848         remove disabled code block.
5849
5850 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5851
5852         * gdbarch.sh (get_thread_local_address): New method.
5853         * gdbarch.h, gdbarch.c: Regenerate.
5854         * target.c (target_translate_tls_address): Use
5855         gdbarch_get_thread_local_address if present instead of
5856         target::get_thread_local_address.
5857
5858 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5859
5860         * target.h (target::get_thread_local_address): Update comment.
5861
5862 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5863
5864         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5865         objfile->separate_debug_objfile_backlink if not NULL.
5866
5867 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5868
5869         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5870         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5871         (amd64bsd_store_inferior_registers): Likewise.
5872         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5873         Enable segment base registers.
5874         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5875         PT_GETFSBASE and PT_GETGSBASE.
5876         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5877         PT_SETGSBASE.
5878         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5879         segment base registers.
5880         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5881
5882 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5883
5884         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5885         Update calls to i386_target_description to add 'segments'
5886         parameter.
5887         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5888         add segment base registers.
5889         * arch/i386.c (i386_create_target_description): Add 'segments'
5890         parameter to enable segment base registers.
5891         * arch/i386.h (i386_create_target_description): Likewise.
5892         * features/i386/32bit-segments.xml: New file.
5893         * features/i386/32bit-segments.c: Generate.
5894         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5895         call to i386_target_description to add 'segments' parameter.
5896         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5897         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5898         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5899         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5900         if feature is present.
5901         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5902         Add 'segments' parameter to call to i386_target_description.
5903         (i386_target_description): Add 'segments' parameter to enable
5904         segment base registers.
5905         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5906         to call to i386_target_description.
5907         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5908         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5909         Define I386_NUM_REGS.
5910         (i386_target_description): Add 'segments' parameter to enable
5911         segment base registers.
5912
5913 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5914
5915         PR/24325
5916         * source-cache.c: #undef open and close, to avoid unresolved
5917         externals during linking.
5918
5919 2019-03-12  Tom Tromey  <tromey@adacore.com>
5920
5921         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5922         const.  Add initializers.
5923         (_initialize_remote): Don't initialize ptid globals.
5924
5925 2019-03-12  Pedro Alves  <palves@redhat.com>
5926
5927         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5928
5929 2019-03-12  Pedro Alves  <palves@redhat.com>
5930
5931         * cp-name-parser.y (main): Remove unused 'len' variable.
5932
5933 2019-03-12  Tom Tromey  <tromey@adacore.com>
5934
5935         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5936         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5937
5938 2019-03-12  Tom Tromey  <tromey@adacore.com>
5939
5940         * linux-nat.c (iterate_over_lwps): Update.
5941         (stop_callback): Remove parameter.
5942         (stop_wait_callback, detach_callback, resume_set_callback)
5943         (select_singlestep_lwp_callback, set_ignore_sigint)
5944         (status_callback, resumed_callback, resume_clear_callback)
5945         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5946         data parameter.
5947         (linux_nat_target::detach, linux_nat_target::resume)
5948         (linux_stop_and_wait_all_lwps, select_event_lwp)
5949         (linux_nat_filter_event, linux_nat_wait_1)
5950         (linux_nat_target::kill, linux_nat_target::stop)
5951         (linux_nat_target::stop): Update.
5952         (linux_nat_resume_callback): Change type.
5953         (resume_stopped_resumed_lwps, count_events_callback)
5954         (select_event_lwp_callback): Likewise.
5955         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5956         * arm-linux-nat.c (struct update_registers_data): Remove.
5957         (update_registers_callback): Change type.
5958         (arm_linux_insert_hw_breakpoint1): Update.
5959         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5960         parameter.
5961         (x86_linux_dr_set_addr): Update.
5962         (x86_linux_dr_set_control): Update.
5963         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5964         (iterate_over_lwps): Use gdb::function_view.
5965         * nat/aarch64-linux-hw-point.c (struct
5966         aarch64_dr_update_callback_param): Remove.
5967         (debug_reg_change_callback): Change type.
5968         (aarch64_notify_debug_reg_change): Update.
5969         * s390-linux-nat.c (s390_refresh_per_info): Update.
5970
5971 2019-03-11  Tom Tromey  <tromey@adacore.com>
5972
5973         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5974         redundant assignment to "this_cu".
5975
5976 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5977
5978         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5979
5980 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5981
5982         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5983         from...
5984         (rank_one_type): ... this.
5985
5986 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5987
5988         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5989         from...
5990         (rank_one_type): ... this.
5991
5992 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5993
5994         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5995         from...
5996         (rank_one_type): ... this.
5997
5998 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5999
6000         * gdbtypes.c (rank_one_type_parm_float): New function extracted
6001         from...
6002         (rank_one_type): ... this.
6003
6004 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6005
6006         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
6007         from...
6008         (rank_one_type): ... this.
6009
6010 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6011
6012         * gdbtypes.c (rank_one_type_parm_range): New function extracted
6013         from...
6014         (rank_one_type): ... this.
6015
6016 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6017
6018         * gdbtypes.c (rank_one_type_parm_char): New function extracted
6019         from...
6020         (rank_one_type): ... this.
6021
6022 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6023
6024         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
6025         from...
6026         (rank_one_type): ... this.
6027
6028 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6029
6030         * gdbtypes.c (rank_one_type_parm_int): New function extracted
6031         from...
6032         (rank_one_type): ... this.
6033
6034 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6035
6036         * gdbtypes.c (rank_one_type_parm_func): New function extracted
6037         from...
6038         (rank_one_type): ... this.
6039
6040 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6041
6042         * gdbtypes.c (rank_one_type_parm_array): New function extracted
6043         from...
6044         (rank_one_type): ... this.
6045
6046 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
6047
6048         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
6049         from...
6050         (rank_one_type): ... this.
6051
6052 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6053
6054         * inferior.c (initialize_inferiors): Ensure 'help set/show print
6055         inferior-events' shows the example events.
6056
6057 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
6058
6059         Support styling on native MS-Windows console
6060
6061         PR/24315
6062         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
6063         on MS-Windows if $TERM is not defined.
6064
6065         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
6066
6067         * posix-hdep.c (gdb_console_fputs):
6068         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
6069         functions.
6070         * ui-file.h (gdb_console_fputs): Add prototype.
6071
6072         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
6073         back to fputs only if the former returns zero.
6074
6075 2019-03-07  Tom Tromey  <tom@tromey.com>
6076
6077         * symmisc.c (print_symbol_bcache_statistics): Update.
6078         (print_objfile_statistics): Update.
6079         * symfile.c (allocate_symtab): Update.
6080         * stabsread.c: Don't include bcache.h.
6081         * psymtab.h (struct psymbol_bcache): Don't declare.
6082         (class psymtab_storage) <psymbol_cache>: Now a bcache.
6083         (psymbol_bcache_init, psymbol_bcache_free)
6084         (psymbol_bcache_get_bcache): Don't declare.
6085         * psymtab.c (struct psymbol_bcache): Remove.
6086         (psymtab_storage::psymtab_storage): Update.
6087         (psymtab_storage::~psymtab_storage): Update.
6088         (psymbol_bcache_init, psymbol_bcache_free)
6089         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
6090         (add_psymbol_to_bcache): Update.
6091         (allocate_psymtab): Update.
6092         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
6093         macro_cache>: No longer pointers.
6094         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
6095         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
6096         * macrotab.c (macro_bcache): Update.
6097         * macroexp.c: Don't include bcache.h.
6098         * gdbtypes.c (check_types_worklist): Update.
6099         (types_deeply_equal): Remove TRY/CATCH.  Update.
6100         * elfread.c (elf_symtab_read): Update.
6101         * dwarf2read.c: Don't include bcache.h.
6102         * buildsym.c (buildsym_compunit::get_macro_table): Update.
6103         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
6104         (print_bcache_statistics, bcache_memory_used): Don't declare.
6105         (struct bcache): Move from bcache.c.  Add constructor, destructor,
6106         methods.  Rename all data members.
6107         * bcache.c (struct bcache): Move to bcache.h.
6108         (bcache::expand_hash_table): Rename from expand_hash_table.
6109         (bcache): Remove.
6110         (bcache::insert): Rename from bcache_full.
6111         (bcache::compare): Rename from bcache_compare.
6112         (bcache_xmalloc): Remove.
6113         (bcache::~bcache): Rename from bcache_xfree.
6114         (bcache::print_statistics): Rename from print_bcache_statistics.
6115         (bcache::memory_used): Rename from bcache_memory_used.
6116
6117 2019-03-07  Pedro Alves  <palves@redhat.com>
6118
6119         * infrun.c (normal_stop): Also check for
6120         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
6121
6122 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
6123
6124         * f-lang.c (value_from_host_double): Moved to...
6125         * value.c (value_from_host_double): ...here.
6126         * value.h (value_from_host_double): Declare.
6127         * guile/scm-math.c (vlscm_convert_typed_number): Use
6128         value_from_host_double.
6129         (vlscm_convert_number): Likewise.
6130         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
6131         * python/py-value.c (convert_value_from_python): Likewise.
6132
6133 2019-03-06  Tom Tromey  <tom@tromey.com>
6134
6135         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
6136
6137 2019-03-06  Tom Tromey  <tom@tromey.com>
6138
6139         * utils.h (free_current_contents): Don't declare.
6140         * utils.c (free_current_contents): Remove.
6141
6142 2019-03-06  Tom Tromey  <tom@tromey.com>
6143
6144         * top.c (quit_force): Update.
6145         * main.c (captured_command_loop): Update.
6146         * common/new-op.c (operator new): Update.
6147         * common/common-exceptions.c (struct catcher)
6148         <save_cleanup_chain>: Remove member.
6149         (exceptions_state_mc_init): Update.
6150         (exception_try_scope_entry): Return nullptr.
6151         (exception_try_scope_exit, exception_rethrow)
6152         (throw_exception_sjlj, throw_exception_cxx): Update.
6153         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
6154         (all_cleanups, do_cleanups, discard_cleanups)
6155         (discard_final_cleanups, save_cleanups, save_final_cleanups)
6156         (restore_cleanups, restore_final_cleanups): Don't declare.
6157         (do_final_cleanups): Remove parameter.
6158         * common/cleanups.c (cleanup_chain, make_cleanup)
6159         (make_cleanup_dtor, all_cleanups, do_cleanups)
6160         (discard_my_cleanups, discard_cleanups)
6161         (discard_final_cleanups, save_my_cleanups, save_cleanups)
6162         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
6163         (null_cleanup): Remove.
6164         (do_final_cleanups): Remove parameter.
6165
6166 2019-03-06  Tom Tromey  <tom@tromey.com>
6167
6168         * remote.c (remote_target::remote_parse_stop_reply): Use
6169         unique_xmalloc_ptr.
6170
6171 2019-03-06  Tom Tromey  <tom@tromey.com>
6172
6173         * stabsread.c (struct stabs_field_info): Rename from field_info.
6174         <list, fnlist>: Add initializers.
6175         <obstack>: New member.
6176         (read_member_functions, read_struct_fields, read_baseclasses):
6177         Allocate on obstack.  Don't use cleanups.
6178         (read_one_struct_field, read_member_functions, read_struct_fields)
6179         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
6180         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
6181         (read_struct_type): Update.
6182
6183 2019-03-06  Tom Tromey  <tom@tromey.com>
6184
6185         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
6186         * common/filestuff.h (make_cleanup_close): Don't declare.
6187         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
6188         Remove.
6189
6190 2019-03-06  Tom Tromey  <tom@tromey.com>
6191
6192         * solib-aix.c: Use make_scope_exit.
6193
6194 2019-03-06  Tom Tromey  <tom@tromey.com>
6195
6196         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
6197         Use make_scope_exit.
6198
6199 2019-03-06  Tom Tromey  <tom@tromey.com>
6200
6201         * solib-svr4.c (disable_probes_interface): Remove parameter.
6202         (svr4_handle_solib_event): Use make_scope_exit.
6203
6204 2019-03-06  Tom Tromey  <tom@tromey.com>
6205
6206         * remote.c (struct stop_reply_deleter): Remove.
6207         (stop_reply_up): Update.
6208         (struct stop_reply): Derive from notif_event.  Don't typedef.
6209         <regcache>: Now a std::vector.
6210         (stop_reply_xfree): Remove.
6211         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
6212         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
6213         (remote_target::discard_pending_stop_replies): Use delete.
6214         (remote_target::remote_parse_stop_reply): Update.
6215         (remote_target::process_stop_reply): Update.
6216         * remote-notif.h (struct notif_event): Add virtual destructor.
6217         Remove "dtr" member.
6218         (struct notif_client) <alloc_event>: Return a unique_ptr.
6219         (notif_event_xfree): Don't declare.
6220         (notif_event_up): New typedef.
6221         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
6222         (notif_event_xfree, do_notif_event_xfree): Remove.
6223         (remote_notif_state_xfree): Update.
6224
6225 2019-03-06  Tom Tromey  <tom@tromey.com>
6226
6227         * infrun.c (displaced_step_clear_cleanup): Now a
6228         forward_scope_exit type.
6229         (displaced_step_prepare_throw): Update.
6230         (displaced_step_fixup): Update.
6231
6232 2019-03-06  Tom Tromey  <tom@tromey.com>
6233
6234         * inferior.h (class inferior): Update comment.
6235         * gdbthread.h (class thread_info): Update comment.
6236
6237 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
6238             Tom Tromey  <tom@tromey.com>
6239
6240         * stabsread.h (struct stab_section_list): Remove.
6241         (coffstab_build_psymtabs): Update.
6242         * dbxread.c (symbuf_sections): Now a std::vector.
6243         (sect_idx): New global.
6244         (fill_symbuf): Update.
6245         (coffstab_build_psymtabs): Change type of stabsects parameter.
6246         Update.
6247         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
6248         std::vector.
6249         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
6250         (coff_locate_sections): Update.
6251         (coff_symfile_read): Remove cleanups.  Update.
6252         (init_stringtab): Add storage parameter.
6253         (free_stringtab, free_stringtab_cleanup): Remove.
6254         (init_lineno): Add storage parameter.
6255         (free_linetab, free_linetab_cleanup): Remove.
6256
6257 2019-03-06  Pedro Alves  <palves@redhat.com>
6258
6259         * linux-fork.c (fork_info::clobber_regs): Delete.
6260         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
6261         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
6262         comment.  Adjust.
6263         (scoped_switch_fork_info::scoped_switch_fork_info)
6264         (checkpoint_command, linux_fork_context): Adjust
6265         fork_save_infrun_state calls.
6266
6267 2019-03-06  Pedro Alves  <palves@redhat.com>
6268
6269         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
6270         (inf_has_multiple_threads): Return 'bool' and rewrite using
6271         inferior_info::threads().
6272
6273 2019-03-06  Pedro Alves  <palves@redhat.com>
6274
6275         * linux-fork.c: Include <list>.
6276         (fork_list): Now a std::list instance.
6277         (fork_info): Add ctor, dtor, and in-class initialize all fields.
6278         (forks_exist_p, find_last_fork): Adjust.
6279         (new_fork): Delete.
6280         (one_fork_p): New.
6281         (add_fork): Adjust.
6282         (free_fork): Delete, folded into fork_info::~fork_info().
6283         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
6284         Adjust.
6285         (init_fork_list): Delete.
6286         (linux_fork_killall, linux_fork_mourn_inferior)
6287         (linux_fork_detach, info_checkpoints_command): Adjust.
6288         (_initialize_linux_fork): No longer call init_fork_list.
6289
6290 2019-03-06  Pedro Alves  <palves@redhat.com>
6291
6292         * linux-fork.c (new_fork): New, split out of ...
6293         (add_fork): ... this.  Return void.  Move "first fork" special
6294         case from here, to ...
6295         (checkpoint_command): ... here.
6296         * linux-linux.h (add_fork): Return void.
6297
6298 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6299
6300         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
6301
6302 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6303             Chris January  <chris.january@arm.com>
6304             David Lecomber  <david.lecomber@arm.com>
6305
6306         * f-exp.y: New token, UNOP_INTRINSIC.
6307         (exp): New pattern using UNOP_INTRINSIC token.
6308         (f77_keywords): Add 'abs' keyword.
6309         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
6310         (value_from_host_double): New function.
6311         (evaluate_subexp_f): Support UNOP_ABS.
6312
6313 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6314
6315         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
6316         types.
6317
6318 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6319
6320         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
6321         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
6322         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
6323
6324 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6325
6326         * f-exp.y (convert_to_kind_type): Handle more type kinds.
6327
6328 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6329             Chris January  <chris.january@arm.com>
6330
6331         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
6332         * f-exp.y: Define 'KIND' token.
6333         (exp): New pattern for KIND expressions.
6334         (ptype): Handle types with a kind extension.
6335         (direct_abs_decl): Extend to spot kind extensions.
6336         (f77_keywords): Add 'kind' to the list.
6337         (push_kind_type): New function.
6338         (convert_to_kind_type): New function.
6339         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
6340         * parse.c (operator_length_standard): Likewise.
6341         * parser-defs.h (enum type_pieces): Add tp_kind.
6342         * std-operator.def: Add UNOP_KIND.
6343
6344 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6345
6346         * f-exp.y (f_parse): Set yydebug.
6347
6348 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6349
6350         * f-lang.c (evaluate_subexp_f): New function.
6351         (exp_descriptor_f): New global.
6352         (f_language_defn): Use exp_descriptor_f instead of
6353         exp_descriptor_standard.
6354
6355 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6356
6357         * f-exp.y (struct token): Add comments.
6358         (dot_ops): Remove uppercase versions and the end marker.
6359         (f77_keywords): Likewise.
6360         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
6361         entries in the dot_ops array are case insensitive, and use
6362         strncasecmp to compare strings.  Also some whitespace cleanup in
6363         this area.  Similar for the f77_keywords array, except entries in
6364         this list might be case sensitive.
6365
6366 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6367
6368         * f-exp.y (struct f77_boolean_val): Add comments.
6369         (boolean_values): Remove uppercase versions, and end marker.
6370         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
6371         and use strncasecmp to achieve case insensitivity.  Additionally,
6372         perform whitespace cleanup around this code.
6373
6374 2019-03-06  Tom Tromey  <tromey@adacore.com>
6375
6376         * remote-sim.c (gdbsim_target_open): Use result of
6377         gdb_argv::release.
6378
6379 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
6380         Dirk Schubert  <dirk.schubert@arm.com>
6381         Chris January  <chris.january@arm.com>
6382
6383         * eval.c (evaluate_subexp_standard): Call Fortran argument
6384         wrapping logic.
6385         * f-lang.c (struct value): A value which can be passed into a
6386         Fortran function call.
6387         (fortran_argument_convert): Wrap Fortran arguments in a pointer
6388         where appropriate.
6389         (struct type): Value ready for a Fortran function call.
6390         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
6391         is needed.
6392         * f-lang.h (fortran_argument_convert): Declaration.
6393         (fortran_preserve_arg_pointer): Declaration.
6394         * infcall.c (value_arg_coerce): Call Fortran argument logic.
6395
6396 2019-03-05  Tom Tromey  <tromey@adacore.com>
6397
6398         * python/py-prettyprint.c (print_string_repr): Remove #if.
6399         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
6400
6401 2019-03-05  Tom Tromey  <tromey@adacore.com>
6402
6403         * target.c (the_dummy_target): Move later.  Change type to
6404         "dummy_target".
6405         (initialize_targets): Don't initialize the_dummy_target.
6406
6407 2019-03-05  Tom Tromey  <tromey@adacore.com>
6408
6409         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
6410         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
6411
6412 2019-03-05  Tom Tromey  <tromey@adacore.com>
6413
6414         * windows-nat.c (windows_nat_target::attach)
6415         (windows_nat_target::detach): Don't call gdb_flush.
6416         * valprint.c (generic_val_print, val_print, val_print_string):
6417         Don't call gdb_flush.
6418         * utils.c (defaulted_query): Don't call gdb_flush.
6419         * typeprint.c (print_type_scalar): Don't call gdb_flush.
6420         * target.c (target_announce_detach): Don't call gdb_flush.
6421         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
6422         * remote.c (extended_remote_target::attach): Don't call
6423         gdb_flush.
6424         * procfs.c (procfs_target::detach): Don't call gdb_flush.
6425         * printcmd.c (do_examine): Don't call gdb_flush.
6426         (info_display_command): Don't call gdb_flush.
6427         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
6428         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
6429         * memattr.c (info_mem_command): Don't call gdb_flush.
6430         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
6431         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
6432         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
6433         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
6434         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
6435         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
6436         (gnu_nat_target::detach): Don't call gdb_flush.
6437         * f-valprint.c (f_val_print): Don't call gdb_flush.
6438         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
6439         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
6440         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
6441         gdb_flush.
6442         * c-valprint.c (c_val_print): Don't call gdb_flush.
6443         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
6444
6445 2019-03-05  Tom Tromey  <tromey@adacore.com>
6446
6447         * varobj.c (update_dynamic_varobj_children): Update.
6448         (install_default_visualizer): Use reset, not release.
6449         * value.c (set_internalvar): Update.
6450         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
6451         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
6452         ATTRIBUTE_UNUSED_RESULT.
6453
6454 2019-03-05  Tom Tromey  <tromey@adacore.com>
6455
6456         * remote.c (class scoped_remote_fd) <release>: Add
6457         ATTRIBUTE_UNUSED_RESULT.
6458
6459 2019-03-05  Tom Tromey  <tromey@adacore.com>
6460
6461         * macroexp.c (struct macro_buffer) <release>: Add
6462         ATTRIBUTE_UNUSED_RESULT.
6463
6464 2019-03-05  Tom Tromey  <tromey@adacore.com>
6465
6466         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
6467         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
6468         ATTRIBUTE_UNUSED_RESULT.
6469
6470 2019-03-05  Tom Tromey  <tromey@adacore.com>
6471
6472         * common/scoped_fd.h (class scoped_fd) <release>: Add
6473         ATTRIBUTE_UNUSED_RESULT.
6474
6475 2019-03-05  Tom Tromey  <tromey@adacore.com>
6476
6477         * parser-defs.h (struct parser_state) <release>: Add
6478         ATTRIBUTE_UNUSED_RESULT.
6479
6480 2019-03-05  Tom Tromey  <tromey@adacore.com>
6481
6482         * utils.h (class gdb_argv) <release>: Add
6483         ATTRIBUTE_UNUSED_RESULT.
6484         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
6485
6486 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
6487
6488         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
6489         for-loop range, to avoid compiler warnings.
6490
6491         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
6492         avoid compiler warnings about unused variables.
6493
6494         * NEWS: Mention end of support for native debugging on MS-Windows
6495         before XP.
6496
6497         PR gdb/24292
6498         * common/netstuff.c:
6499         * gdbserver/gdbreplay.c
6500         * gdbserver/remote-utils.c:
6501         * ser-tcp.c:
6502         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
6503         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
6504         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
6505         'getaddrinfo' and 'freeaddrinfo' were not available before
6506         Windows XP, and mingw.org's MinGW headers by default define
6507         _WIN32_WINNT to 0x500.
6508
6509 2019-03-01  Gary Benson <gbenson@redhat.com>
6510
6511         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
6512
6513 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
6514             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
6515
6516         PR gdb/8527
6517         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
6518         set_sigint_trap, clear_sigint_trap.
6519
6520 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6521
6522         * target.c (target_detach): Clear the regcache and the
6523         frame cache.
6524
6525 2019-02-27  Pedro Alves  <palves@redhat.com>
6526
6527         * utils.c (set_screen_size): When we cap the height/width sizes,
6528         tweak the corresponding command variable to show "unlimited":
6529
6530 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
6531             Pedro Alves  <palves@redhat.com>
6532
6533         * utils.c (set_screen_size): Reduce "infinite" rows and columns
6534         before calling rl_set_screen_size.
6535
6536 2019-02-27  Tom Tromey  <tromey@adacore.com>
6537
6538         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
6539         define.
6540         * python/py-value.c: Remove Python 2.4 workaround.
6541         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
6542         workaround.
6543         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
6544         Python 2.4 workaround.
6545         * python/python-internal.h: Remove Python 2.4 comment.
6546         (Py_ssize_t): Don't define.
6547         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
6548         (gdb_Py_DECREF): Remove Python 2.4 workaround.
6549         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
6550         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
6551         * python/python.c (do_start_initialization): Remove Python 2.4
6552         workaround.
6553         * python/py-prettyprint.c (class dummy_python_frame): Remove.
6554         (print_children): Remove Python 2.4 workaround.
6555         * python/py-inferior.c (buffer_procs): Remove Python 2.4
6556         workaround.
6557         (CHARBUFFERPROC_NAME): Remove.
6558         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
6559         Python 2.4 workaround.
6560
6561 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6562
6563         * NEWS: Note minimum Python version.
6564
6565 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
6566
6567         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
6568         code from these functions.  Remove corresponding ifdefs.  Use
6569         Py_buffer_up instead of explicit calls to PyBuffer_Release.
6570         Remove gotos and target of gotos.
6571         (infpy_search_memory): Likewise.
6572
6573 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6574
6575         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
6576         (hppa_gdbarch_init): Don't register deleted functions with
6577         gdbarch.
6578
6579 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6580
6581         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
6582         (h8300_unwind_sp): Delete.
6583         (h8300_dummy_id): Delete.
6584         (h8300_gdbarch_init): Don't register deleted functions with
6585         gdbarch.
6586
6587 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6588
6589         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6590         (ft32_unwind_pc): Delete.
6591         (ft32_unwind_sp): Delete.
6592         (ft32_gdbarch_init): Don't register deleted functions with
6593         gdbarch.
6594
6595 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6596
6597         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6598         (frv_unwind_pc): Delete.
6599         (frv_unwind_sp): Delete.
6600         (frv_gdbarch_init): Don't register deleted functions with
6601         gdbarch.
6602
6603 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6604
6605         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6606         (riscv_unwind_pc): Delete.
6607         (riscv_unwind_sp): Delete.
6608         (riscv_gdbarch_init): Don't register deleted functions with
6609         gdbarch.
6610
6611 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6612
6613         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6614         (csky_unwind_pc): Delete.
6615         (csky_unwind_sp): Delete.
6616         (csky_gdbarch_init): Don't register deleted functions with
6617         gdbarch.
6618
6619 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6620
6621         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6622         (cris_unwind_pc): Delete.
6623         (cris_unwind_sp): Delete.
6624         (cris_gdbarch_init): Don't register deleted functions with
6625         gdbarch.
6626
6627 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6628
6629         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6630         (bfin_unwind_pc): Delete.
6631         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6632
6633 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6634
6635         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6636         (arm_unwind_pc): Delete.
6637         (arm_unwind_sp): Delete.
6638         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6639
6640 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6641
6642         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6643         (arc_unwind_pc): Delete.
6644         (arc_unwind_sp): Delete.
6645         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6646
6647 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6648
6649         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6650         (alpha_unwind_pc): Delete.
6651         (alpha_gdbarch_init): Don't register deleted functions with
6652         gdbarch.
6653
6654 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6655
6656         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6657         (aarch64_unwind_pc): Delete.
6658         (aarch64_unwind_sp): Delete.
6659         (aarch64_gdbarch_init): Don't register deleted functions with
6660         gdbarch.
6661
6662 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6663
6664         * gdbtypes.c (type_align): Don't consider static members when
6665         computing structure alignment.
6666
6667 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6668
6669         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6670         return 0 for other types.
6671         * arch-utils.c (default_type_align): Always return 0.
6672         * gdbarch.h: Regenerate.
6673         * gdbarch.sh (type_align): Extend comment.
6674         * gdbtypes.c (type_align): Add additional comments, always call
6675         gdbarch_type_align before applying the default rules.
6676         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6677         generic code will then apply a suitable default.
6678         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6679         types, return 0 for other types.
6680
6681 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6682
6683         * NEWS: Create a new section for the next release branch.
6684         Rename the section of the current branch, now that it has
6685         been cut.
6686
6687 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6688
6689         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6690         * version.in: Bump version to 8.3.50.DATE-git.
6691
6692 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6693
6694         * aix-thread.c (ptid_cmp): Remove unused variable.
6695         (get_signaled_thread): Likewise.
6696         (store_regs_user_thread): Likewise.
6697         (store_regs_kernel_thread): Likewise.
6698         (fetch_regs_kernel_thread): Remove shadowed variable.
6699
6700 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6701
6702         * features/riscv/32bit-cpu.xml: Add register numbers.
6703         * features/riscv/32bit-fpu.c: Regenerate.
6704         * features/riscv/32bit-fpu.xml: Add register numbers.
6705         * features/riscv/64bit-cpu.xml: Add register numbers.
6706         * features/riscv/64bit-fpu.c: Regenerate.
6707         * features/riscv/64bit-fpu.xml: Add register numbers.
6708
6709 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6710
6711         * NEWS: Mention two argument form of gdb.Value constructor.
6712         * python/py-value.c (convert_buffer_and_type_to_value): New
6713         function.
6714         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6715         Add support for handling an optional second argument.  Call
6716         convert_buffer_and_type_to_value as appropriate.
6717         * python/python-internal.h (Py_buffer_deleter): New struct.
6718         (Py_buffer_up): New typedef.
6719
6720 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6721
6722         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6723         instead of releasing ownership.
6724
6725 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6726
6727         * dwarf2read.c (open_and_init_dwp_file): Call
6728         elf_numsections instead of bfd_count_sections to initialize
6729         dwp_file->num_sections.
6730
6731 2019-02-25  Tom Tromey  <tromey@adacore.com>
6732
6733         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6734
6735 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6736
6737         * gcore.in: Add '--readnever' option when invoking GDB.
6738
6739 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6740
6741         * MAINTAINERS: Update my email address.
6742
6743 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6744
6745         * build-id.c (build_id_to_debug_bfd_1): New function.
6746         (build_id_to_debug_bfd): Look for separate debug file in
6747         sysroot.
6748
6749 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6750
6751         * gdbarch.sh: Update the copyright year range that is placed into
6752         generated files.
6753
6754 2019-02-22  Keith Seitz  <keiths@redhat.com>
6755
6756         PR symtab/23853
6757         * linespec.c (create_sals_line_offset): Search for the default
6758         symtab's filename instead of its fullname.
6759
6760 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6761
6762         * NEWS: Update style defaults.
6763
6764 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6765
6766         * main.c (captured_main_1): Disable styling in batch mode.
6767
6768 2019-02-20  Tom Tromey  <tom@tromey.com>
6769
6770         * symtab.c (symtab_symbol_info): Fix typos.
6771
6772 2019-02-20  Tom Tromey  <tromey@adacore.com>
6773
6774         * findcmd.c (_initialize_mem_search): Use upper case for
6775         metasyntactic variables.
6776
6777 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6778
6779         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6780         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6781
6782 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6783
6784         * top.h (source_file_name): Change to std::string.
6785         * top.c (source_file_name): Likewise.
6786         (command_line_input): Adjust.
6787         * cli/cli-script.c (script_from_file): Adjust.
6788
6789 2019-02-19  Tom Tromey  <tromey@adacore.com>
6790
6791         * ravenscar-thread.c
6792         (ravenscar_thread_target::update_thread_list): Don't call
6793         ada_build_task_list.
6794         * ada-lang.h (ada_build_task_list): Don't declare.
6795         * ada-tasks.c (struct ada_tasks_inferior_data)
6796         <task_list_valid_p>: Now bool.
6797         (read_known_tasks, ada_task_list_changed)
6798         (ada_tasks_invalidate_inferior_data): Update.
6799         (read_known_tasks_array): Return bool.
6800         (read_known_tasks_list): Likewise.
6801         (read_known_tasks): Return void.
6802         (ada_build_task_list): Now static.
6803
6804 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6805
6806         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6807         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6808
6809 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6810
6811         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6812         variant for ada_tasks_pspace_data_handle and
6813         ada_tasks_inferior_data_handle.
6814         (ada_tasks_pspace_data_cleanup): New function.
6815         (ada_tasks_inferior_data_cleanup): New function.
6816
6817 2019-02-17  Tom Tromey  <tom@tromey.com>
6818
6819         * macrotab.h (macro_source_fullname): Return a std::string.
6820         * macrotab.c (macro_include, check_for_redefinition)
6821         (macro_undef, macro_lookup_definition, foreach_macro)
6822         (foreach_macro_in_scope): Update.
6823         (macro_source_fullname): Return a std::string.
6824         * macrocmd.c (show_pp_source_pos): Update.
6825
6826 2019-02-17  Tom Tromey  <tom@tromey.com>
6827
6828         * macrocmd.c (show_pp_source_pos): Style the file names.
6829
6830 2019-02-17  Tom Tromey  <tom@tromey.com>
6831
6832         PR tui/24197:
6833         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6834
6835 2019-02-17  Tom Tromey  <tom@tromey.com>
6836
6837         * ada-lang.c (user_select_syms): Use filtered printing.
6838         * utils.c (wrap_style): New global.
6839         (desired_style): Remove.
6840         (emit_style_escape): Add stream parameter.
6841         (set_output_style, reset_terminal_style, prompt_for_continue):
6842         Update.
6843         (flush_wrap_buffer): Only flush gdb_stdout.
6844         (wrap_here): Set wrap_style.
6845         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6846         treat escape sequences as a character.  Change when wrap buffer is
6847         flushed.
6848         (fputs_styled): Do not set the output style when the default is
6849         requested.
6850         * ui-style.h (struct ui_file_style) <is_default>: New method.
6851         * source.c (print_source_lines_base): Emit escape sequences in one
6852         piece.
6853
6854 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6855
6856         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6857         integers and enumeration types.
6858
6859 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6860
6861         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6862         instead of lookup_symbol_in_language
6863         (do_exact_match): New function.
6864         (ada_get_symbol_name_matcher): Return do_exact_match when
6865         doing a verbatim match.
6866
6867 2019-02-15  Tom Tromey  <tromey@adacore.com>
6868
6869         * ravenscar-thread.c (ravenscar_thread_target::resume)
6870         (ravenscar_thread_target::wait): Special case wildcard requests.
6871
6872 2019-02-15  Tom Tromey  <tromey@adacore.com>
6873
6874         * ravenscar-thread.c (base_ptid): Remove.
6875         (struct ravenscar_thread_target) <close>: New method.
6876         <m_base_ptid>: New member.
6877         <update_inferior_ptid, active_task, task_is_currently_active,
6878         runtime_initialized>: Declare methods.
6879         <ravenscar_thread_target>: Add constructor.
6880         (ravenscar_thread_target::task_is_currently_active)
6881         (ravenscar_thread_target::update_inferior_ptid)
6882         (ravenscar_runtime_initialized): Rename.  Now methods.
6883         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6884         (ravenscar_thread_target::update_thread_list): Update.
6885         (ravenscar_thread_target::active_task): Now method.
6886         (ravenscar_thread_target::store_registers)
6887         (ravenscar_thread_target::prepare_to_store)
6888         (ravenscar_thread_target::prepare_to_store)
6889         (ravenscar_thread_target::mourn_inferior): Update.
6890         (ravenscar_inferior_created): Use "new" to create target.
6891         (ravenscar_thread_target::get_ada_task_ptid): Update.
6892         (_initialize_ravenscar): Don't initialize base_ptid.
6893         (ravenscar_ops): Remove global.
6894
6895 2019-02-15  Tom Tromey  <tromey@adacore.com>
6896
6897         * target.h (push_target): Declare new overload.
6898         * target.c (push_target): New overload, taking an rvalue reference.
6899         * remote.c (remote_target::open_1): Use push_target overload.
6900         * corelow.c (core_target_open): Use push_target overload.
6901
6902 2019-02-15  Tom Tromey  <tromey@adacore.com>
6903
6904         * ravenscar-thread.c (is_ravenscar_task)
6905         (ravenscar_task_is_currently_active): Return bool.
6906         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6907         (_initialize_ravenscar): Remove "(void)".
6908         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6909         Return bool.
6910
6911 2019-02-15  Tom Tromey  <tromey@adacore.com>
6912
6913         * ravenscar-thread.c (ravenscar_runtime_initializer)
6914         (has_ravenscar_runtime, get_running_thread_id)
6915         (ravenscar_thread_target::resume): Fix indentation.
6916
6917 2019-02-15  Tom Tromey  <tromey@adacore.com>
6918
6919         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6920         from ravenscar_arch_ops.
6921         (sparc_ravenscar_ops::fetch_registers)
6922         (sparc_ravenscar_ops::store_registers): Now methods.
6923         (sparc_ravenscar_prepare_to_store): Remove.
6924         (sparc_ravenscar_ops): Redefine.
6925         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6926         methods and destructor.  Remove members.
6927         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6928         (ravenscar_thread_target::store_registers)
6929         (ravenscar_thread_target::prepare_to_store): Update.
6930         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6931         Remove.
6932         (struct ppc_ravenscar_powerpc_ops): Derive from
6933         ravenscar_arch_ops.
6934         (ppc_ravenscar_powerpc_ops::fetch_registers)
6935         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6936         (ppc_ravenscar_powerpc_ops): Redefine.
6937         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6938         (ppc_ravenscar_e500_ops::fetch_registers)
6939         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6940         (ppc_ravenscar_e500_ops): Redefine.
6941         * aarch64-ravenscar-thread.c
6942         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6943         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6944         (aarch64_ravenscar_fetch_registers)
6945         (aarch64_ravenscar_store_registers): Now methods.
6946         (aarch64_ravenscar_ops): Redefine.
6947
6948 2019-02-15  Tom Tromey  <tromey@adacore.com>
6949
6950         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6951         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6952         (ravenscar_thread_target::stopped_by_watchpoint)
6953         (ravenscar_thread_target::stopped_data_address)
6954         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6955
6956 2019-02-15  Tom Tromey  <tromey@adacore.com>
6957
6958         * ravenscar-thread.c: Fix some typos.
6959
6960 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6961             Tom Tromey  <tromey@adacore.com>
6962
6963         * ada-lang.c (ada_exception_sal): Change addr_string to a
6964         std::string.
6965         (create_ada_exception_catchpoint): Update.
6966
6967 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6968             Tom Tromey  <tromey@adacore.com>
6969
6970         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6971         (bp_location_ops): Remove.
6972         (base_breakpoint_allocate_location): Update.
6973         (free_bp_location): Update.
6974         * ada-lang.c (class ada_catchpoint_location)
6975         <ada_catchpoint_location>: Remove ops parameter.
6976         (ada_catchpoint_location_dtor): Remove.
6977         (ada_catchpoint_location_ops): Remove.
6978         (allocate_location_exception): Update.
6979         * breakpoint.h (struct bp_location_ops): Remove.
6980         (class bp_location) <bp_location>: Remove bp_location_ops
6981         parameter.
6982         <~bp_location>: Add destructor.
6983         <ops>: Remove.
6984
6985 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6986             Pedro Alves  <palves@redhat.com>
6987
6988         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6989         'PATH_MAX'.
6990
6991 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6992             Samuel Thibault  <samuel.thibault@gnu.org>
6993             Thomas Schwinge  <thomas@codesourcery.com>
6994
6995         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6996         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6997
6998 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6999
7000         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
7001         (check_empty): Use "const char *".
7002
7003         * gnu-nat.c (gnu_nat_target::detach): Instead of
7004         'detach_inferior (pid)' call
7005         'detach_inferior (find_inferior_pid (pid))'.
7006
7007         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
7008         'nat/fork-inferior.o'.
7009         * gnu-nat.c: #include "nat/fork-inferior.h".
7010
7011         * gnu-nat.c (gnu_nat_target::detach): Instead of
7012         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
7013         * gnu-nat.h: #include "inf-child.h".
7014         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
7015         'i386_gnu_nat_target::fetch_registers'.
7016         (gnu_store_registers): Rename/move to
7017         'i386_gnu_nat_target::store_registers'.
7018
7019         * config/i386/nm-i386gnu.h: Don't "#include" any files.
7020         * gnu-nat.h (mach_thread_info): New function.
7021         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
7022
7023         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
7024
7025 2019-02-14  Frederic Konrad  <konrad@adacore.com>
7026
7027         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
7028
7029 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
7030
7031         * windows-nat.c (windows_add_thread): Add new parameter
7032         "main_thread_p" with default value set to false.  Update
7033         function documentation as well as all callers.
7034         (windows_delete_thread): Likewise.
7035         (fake_create_process): Update call to windows_add_thread.
7036         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
7037         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
7038         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
7039         call to windows_delete_thread.
7040
7041 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
7042
7043         * MAINTAINERS: Add Andrew Burgess as global maintainer.
7044
7045 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7046
7047         * symfile.c (find_separate_debug_file): Use canonical path of
7048         sysroot with child_path instead of gdb_sysroot if it is valid.
7049
7050 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7051
7052         * symfile.c (find_separate_debug_file): Use child_path to
7053         determine if an object file is under a sysroot.
7054
7055 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7056
7057         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
7058         unittests/child-path-selftests.c.
7059         * common/pathstuff.c (child_path): New function.
7060         * common/pathstuff.h (child_path): New prototype.
7061         * unittests/child-path-selftests.c: New file.
7062
7063 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
7064
7065         * symfile.c (find_separate_debug_file): Look for separate debug
7066         files in debug directories under the sysroot.
7067
7068 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7069
7070         * symtab.h (struct minimal_symbol data_p): New const method.
7071         (struct minimal_symbol text_p): Likewise.
7072         * symtab.c (output_source_filename): Use file name style
7073         to print file name.
7074         (print_symbol_info): Likewise.
7075         (print_msymbol_info): Use address style to print addresses.
7076         Use function name style to print executable text symbols.
7077         (expand_symtab_containing_pc): Use data_p.
7078         (find_pc_sect_compunit_symtab): Likewise.
7079
7080 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7081
7082         * breakpoint.c (describe_other_breakpoints): Use address style
7083         to print addresses.
7084         (say_where): Likewise.
7085
7086 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7087
7088         * ada-typeprint.c (print_func_type): Print function name
7089         style to print function name.
7090         * c-typeprint.c (c_print_type_1): Likewise.
7091
7092 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
7093
7094         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
7095         for execve.
7096
7097 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7098
7099         * c-exp.y (direct_abs_decl): Use emplace_back to record the
7100         type_stack.
7101
7102 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
7103
7104         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
7105         TYPE_CODE_REF types.
7106
7107 2019-02-08  Jim Wilson  <jimw@sifive.com>
7108
7109         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
7110         (riscv_linux_fregset): New.
7111         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
7112
7113 2019-02-07  Tom Tromey  <tom@tromey.com>
7114
7115         * thread.c (thread_cancel_execution_command): Update.
7116         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
7117         methods.
7118         (struct thread_fsm_ops): Remove.
7119         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
7120         (thread_fsm_should_stop, thread_fsm_return_value)
7121         (thread_fsm_set_finished, thread_fsm_finished_p)
7122         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
7123         Don't declare.
7124         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
7125         * infrun.c (clear_proceed_status_thread)
7126         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
7127         (print_stop_event): Update.
7128         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
7129         Add constructor.
7130         (step_command_fsm_ops): Remove.
7131         (new_step_command_fsm): Remove.
7132         (step_1): Update.
7133         (step_command_fsm::should_stop): Rename from
7134         step_command_fsm_should_stop.
7135         (step_command_fsm::clean_up): Rename from
7136         step_command_fsm_clean_up.
7137         (step_command_fsm::do_async_reply_reason): Rename from
7138         step_command_fsm_async_reply_reason.
7139         (struct until_next_fsm): Inherit from thread_fsm.  Add
7140         constructor.
7141         (until_next_fsm_ops): Remove.
7142         (new_until_next_fsm): Remove.
7143         (until_next_fsm::should_stop): Rename from
7144         until_next_fsm_should_stop.
7145         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
7146         (until_next_fsm::do_async_reply_reason): Rename from
7147         until_next_fsm_async_reply_reason.
7148         (struct finish_command_fsm): Inherit from thread_fsm.  Add
7149         constructor.  Change type of breakpoint.
7150         (finish_command_fsm_ops): Remove.
7151         (new_finish_command_fsm): Remove.
7152         (finish_command_fsm::should_stop): Rename from
7153         finish_command_fsm_should_stop.
7154         (finish_command_fsm::clean_up): Rename from
7155         finish_command_fsm_clean_up.
7156         (finish_command_fsm::return_value): Rename from
7157         finish_command_fsm_return_value.
7158         (finish_command_fsm::do_async_reply_reason): Rename from
7159         finish_command_fsm_async_reply_reason.
7160         (finish_command): Update.
7161         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
7162         Add constructor.
7163         (call_thread_fsm_ops): Remove.
7164         (call_thread_fsm::call_thread_fsm): Rename from
7165         new_call_thread_fsm.
7166         (call_thread_fsm::should_stop): Rename from
7167         call_thread_fsm_should_stop.
7168         (call_thread_fsm::should_notify_stop): Rename from
7169         call_thread_fsm_should_notify_stop.
7170         (run_inferior_call, call_function_by_hand_dummy): Update.
7171         * cli/cli-interp.c (should_print_stop_to_console): Update.
7172         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
7173         Add constructor.  Change type of location_breakpoint,
7174         caller_breakpoint.
7175         (until_break_fsm_ops): Remove.
7176         (new_until_break_fsm): Remove.
7177         (until_break_fsm::should_stop): Rename from
7178         until_break_fsm_should_stop.
7179         (until_break_fsm::clean_up): Rename from
7180         until_break_fsm_clean_up.
7181         (until_break_fsm::do_async_reply_reason): Rename from
7182         until_break_fsm_async_reply_reason.
7183         (until_break_command): Update.
7184         * thread-fsm.c: Remove.
7185         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
7186
7187 2019-02-07  Tom Tromey  <tom@tromey.com>
7188
7189         * yy-remap.h: Add include guard.
7190         * xtensa-tdep.h: Add include guard.
7191         * xcoffread.h: Rename include guard.
7192         * varobj-iter.h: Add include guard.
7193         * tui/tui.h: Rename include guard.
7194         * tui/tui-winsource.h: Rename include guard.
7195         * tui/tui-wingeneral.h: Rename include guard.
7196         * tui/tui-windata.h: Rename include guard.
7197         * tui/tui-win.h: Rename include guard.
7198         * tui/tui-stack.h: Rename include guard.
7199         * tui/tui-source.h: Rename include guard.
7200         * tui/tui-regs.h: Rename include guard.
7201         * tui/tui-out.h: Rename include guard.
7202         * tui/tui-layout.h: Rename include guard.
7203         * tui/tui-io.h: Rename include guard.
7204         * tui/tui-hooks.h: Rename include guard.
7205         * tui/tui-file.h: Rename include guard.
7206         * tui/tui-disasm.h: Rename include guard.
7207         * tui/tui-data.h: Rename include guard.
7208         * tui/tui-command.h: Rename include guard.
7209         * tic6x-tdep.h: Add include guard.
7210         * target/waitstatus.h: Rename include guard.
7211         * target/wait.h: Rename include guard.
7212         * target/target.h: Rename include guard.
7213         * target/resume.h: Rename include guard.
7214         * target-float.h: Rename include guard.
7215         * stabsread.h: Add include guard.
7216         * rs6000-tdep.h: Add include guard.
7217         * riscv-fbsd-tdep.h: Add include guard.
7218         * regformats/regdef.h: Rename include guard.
7219         * record.h: Rename include guard.
7220         * python/python.h: Rename include guard.
7221         * python/python-internal.h: Rename include guard.
7222         * python/py-stopevent.h: Rename include guard.
7223         * python/py-ref.h: Rename include guard.
7224         * python/py-record.h: Rename include guard.
7225         * python/py-record-full.h: Rename include guard.
7226         * python/py-record-btrace.h: Rename include guard.
7227         * python/py-instruction.h: Rename include guard.
7228         * python/py-events.h: Rename include guard.
7229         * python/py-event.h: Rename include guard.
7230         * procfs.h: Add include guard.
7231         * proc-utils.h: Add include guard.
7232         * p-lang.h: Add include guard.
7233         * or1k-tdep.h: Rename include guard.
7234         * observable.h: Rename include guard.
7235         * nto-tdep.h: Rename include guard.
7236         * nat/x86-linux.h: Rename include guard.
7237         * nat/x86-linux-dregs.h: Rename include guard.
7238         * nat/x86-gcc-cpuid.h: Add include guard.
7239         * nat/x86-dregs.h: Rename include guard.
7240         * nat/x86-cpuid.h: Rename include guard.
7241         * nat/ppc-linux.h: Rename include guard.
7242         * nat/mips-linux-watch.h: Rename include guard.
7243         * nat/linux-waitpid.h: Rename include guard.
7244         * nat/linux-ptrace.h: Rename include guard.
7245         * nat/linux-procfs.h: Rename include guard.
7246         * nat/linux-osdata.h: Rename include guard.
7247         * nat/linux-nat.h: Rename include guard.
7248         * nat/linux-namespaces.h: Rename include guard.
7249         * nat/linux-btrace.h: Rename include guard.
7250         * nat/glibc_thread_db.h: Rename include guard.
7251         * nat/gdb_thread_db.h: Rename include guard.
7252         * nat/gdb_ptrace.h: Rename include guard.
7253         * nat/fork-inferior.h: Rename include guard.
7254         * nat/amd64-linux-siginfo.h: Rename include guard.
7255         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
7256         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
7257         * nat/aarch64-linux.h: Rename include guard.
7258         * nat/aarch64-linux-hw-point.h: Rename include guard.
7259         * mn10300-tdep.h: Add include guard.
7260         * mips-linux-tdep.h: Add include guard.
7261         * mi/mi-parse.h: Rename include guard.
7262         * mi/mi-out.h: Rename include guard.
7263         * mi/mi-main.h: Rename include guard.
7264         * mi/mi-interp.h: Rename include guard.
7265         * mi/mi-getopt.h: Rename include guard.
7266         * mi/mi-console.h: Rename include guard.
7267         * mi/mi-common.h: Rename include guard.
7268         * mi/mi-cmds.h: Rename include guard.
7269         * mi/mi-cmd-break.h: Rename include guard.
7270         * m2-lang.h: Add include guard.
7271         * location.h: Rename include guard.
7272         * linux-record.h: Rename include guard.
7273         * linux-nat.h: Add include guard.
7274         * linux-fork.h: Add include guard.
7275         * i386-darwin-tdep.h: Rename include guard.
7276         * hppa-linux-offsets.h: Add include guard.
7277         * guile/guile.h: Rename include guard.
7278         * guile/guile-internal.h: Rename include guard.
7279         * gnu-nat.h: Rename include guard.
7280         * gdb-stabs.h: Rename include guard.
7281         * frv-tdep.h: Add include guard.
7282         * f-lang.h: Add include guard.
7283         * event-loop.h: Add include guard.
7284         * darwin-nat.h: Rename include guard.
7285         * cp-abi.h: Rename include guard.
7286         * config/sparc/nm-sol2.h: Rename include guard.
7287         * config/nm-nto.h: Rename include guard.
7288         * config/nm-linux.h: Add include guard.
7289         * config/i386/nm-i386gnu.h: Rename include guard.
7290         * config/djgpp/nl_types.h: Rename include guard.
7291         * config/djgpp/langinfo.h: Rename include guard.
7292         * compile/gcc-cp-plugin.h: Add include guard.
7293         * compile/gcc-c-plugin.h: Add include guard.
7294         * compile/compile.h: Rename include guard.
7295         * compile/compile-object-run.h: Rename include guard.
7296         * compile/compile-object-load.h: Rename include guard.
7297         * compile/compile-internal.h: Rename include guard.
7298         * compile/compile-cplus.h: Rename include guard.
7299         * compile/compile-c.h: Rename include guard.
7300         * common/xml-utils.h: Rename include guard.
7301         * common/x86-xstate.h: Rename include guard.
7302         * common/version.h: Rename include guard.
7303         * common/vec.h: Rename include guard.
7304         * common/tdesc.h: Rename include guard.
7305         * common/selftest.h: Rename include guard.
7306         * common/scoped_restore.h: Rename include guard.
7307         * common/scoped_mmap.h: Rename include guard.
7308         * common/scoped_fd.h: Rename include guard.
7309         * common/safe-iterator.h: Rename include guard.
7310         * common/run-time-clock.h: Rename include guard.
7311         * common/refcounted-object.h: Rename include guard.
7312         * common/queue.h: Rename include guard.
7313         * common/ptid.h: Rename include guard.
7314         * common/print-utils.h: Rename include guard.
7315         * common/preprocessor.h: Rename include guard.
7316         * common/pathstuff.h: Rename include guard.
7317         * common/observable.h: Rename include guard.
7318         * common/netstuff.h: Rename include guard.
7319         * common/job-control.h: Rename include guard.
7320         * common/host-defs.h: Rename include guard.
7321         * common/gdb_wait.h: Rename include guard.
7322         * common/gdb_vecs.h: Rename include guard.
7323         * common/gdb_unlinker.h: Rename include guard.
7324         * common/gdb_unique_ptr.h: Rename include guard.
7325         * common/gdb_tilde_expand.h: Rename include guard.
7326         * common/gdb_sys_time.h: Rename include guard.
7327         * common/gdb_string_view.h: Rename include guard.
7328         * common/gdb_splay_tree.h: Rename include guard.
7329         * common/gdb_setjmp.h: Rename include guard.
7330         * common/gdb_ref_ptr.h: Rename include guard.
7331         * common/gdb_optional.h: Rename include guard.
7332         * common/gdb_locale.h: Rename include guard.
7333         * common/gdb_assert.h: Rename include guard.
7334         * common/filtered-iterator.h: Rename include guard.
7335         * common/filestuff.h: Rename include guard.
7336         * common/fileio.h: Rename include guard.
7337         * common/environ.h: Rename include guard.
7338         * common/common-utils.h: Rename include guard.
7339         * common/common-types.h: Rename include guard.
7340         * common/common-regcache.h: Rename include guard.
7341         * common/common-inferior.h: Rename include guard.
7342         * common/common-gdbthread.h: Rename include guard.
7343         * common/common-exceptions.h: Rename include guard.
7344         * common/common-defs.h: Rename include guard.
7345         * common/common-debug.h: Rename include guard.
7346         * common/cleanups.h: Rename include guard.
7347         * common/buffer.h: Rename include guard.
7348         * common/btrace-common.h: Rename include guard.
7349         * common/break-common.h: Rename include guard.
7350         * cli/cli-utils.h: Rename include guard.
7351         * cli/cli-style.h: Rename include guard.
7352         * cli/cli-setshow.h: Rename include guard.
7353         * cli/cli-script.h: Rename include guard.
7354         * cli/cli-interp.h: Rename include guard.
7355         * cli/cli-decode.h: Rename include guard.
7356         * cli/cli-cmds.h: Rename include guard.
7357         * charset-list.h: Add include guard.
7358         * buildsym-legacy.h: Rename include guard.
7359         * bfin-tdep.h: Add include guard.
7360         * ax.h: Rename include guard.
7361         * arm-linux-tdep.h: Add include guard.
7362         * arm-fbsd-tdep.h: Add include guard.
7363         * arch/xtensa.h: Rename include guard.
7364         * arch/tic6x.h: Add include guard.
7365         * arch/i386.h: Add include guard.
7366         * arch/arm.h: Rename include guard.
7367         * arch/arm-linux.h: Rename include guard.
7368         * arch/arm-get-next-pcs.h: Rename include guard.
7369         * arch/amd64.h: Add include guard.
7370         * arch/aarch64-insn.h: Rename include guard.
7371         * arch-utils.h: Rename include guard.
7372         * annotate.h: Add include guard.
7373         * amd64-darwin-tdep.h: Rename include guard.
7374         * aarch64-linux-tdep.h: Add include guard.
7375         * aarch64-fbsd-tdep.h: Add include guard.
7376         * aarch32-linux-nat.h: Add include guard.
7377
7378 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7379
7380         * macrotab.c (macro_define_internal): New function that
7381         factorizes macro_define_object_internal and macro_define_function
7382         code.
7383         (macro_define_object_internal): Use macro_define_internal.
7384         (macro_define_function): Likewise.
7385
7386 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7387
7388         * macrocmd.c (extract_identifier): Return
7389         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
7390         callers.
7391
7392 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
7393
7394         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
7395
7396 2019-02-05  Tom Tromey  <tom@tromey.com>
7397
7398         * target.c (target_stack::unpush): Move assertion earlier.
7399
7400 2019-01-30  Tom Tromey  <tom@tromey.com>
7401
7402         PR python/23615:
7403         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
7404         (gdbpy_parse_and_eval): Likewise.
7405         * python/python-internal.h (gdbpy_allow_threads): New class.
7406
7407 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
7408
7409         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
7410         (aarch64_fbsd_fpregmap): Move earlier.
7411         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
7412         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7413         instead of individual calls to trad_frame_set_reg_addr.
7414         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
7415         earlier.
7416         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
7417         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
7418         instead of individual calls to trad_frame_set_reg_addr.
7419
7420 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
7421
7422         * CONTRIBUTE: Replace contribution list with wiki link.
7423
7424 2019-01-25  Tom Tromey  <tom@tromey.com>
7425
7426         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
7427
7428 2019-01-25  Tom Tromey  <tom@tromey.com>
7429
7430         * xtensa-linux-nat.c: Fix common/ includes.
7431         * xml-support.h: Fix common/ includes.
7432         * xml-support.c: Fix common/ includes.
7433         * x86-linux-nat.c: Fix common/ includes.
7434         * windows-nat.c: Fix common/ includes.
7435         * varobj.h: Fix common/ includes.
7436         * varobj.c: Fix common/ includes.
7437         * value.c: Fix common/ includes.
7438         * valops.c: Fix common/ includes.
7439         * utils.c: Fix common/ includes.
7440         * unittests/xml-utils-selftests.c: Fix common/ includes.
7441         * unittests/utils-selftests.c: Fix common/ includes.
7442         * unittests/unpack-selftests.c: Fix common/ includes.
7443         * unittests/tracepoint-selftests.c: Fix common/ includes.
7444         * unittests/style-selftests.c: Fix common/ includes.
7445         * unittests/string_view-selftests.c: Fix common/ includes.
7446         * unittests/scoped_restore-selftests.c: Fix common/ includes.
7447         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
7448         * unittests/scoped_fd-selftests.c: Fix common/ includes.
7449         * unittests/rsp-low-selftests.c: Fix common/ includes.
7450         * unittests/parse-connection-spec-selftests.c: Fix common/
7451         includes.
7452         * unittests/optional-selftests.c: Fix common/ includes.
7453         * unittests/offset-type-selftests.c: Fix common/ includes.
7454         * unittests/observable-selftests.c: Fix common/ includes.
7455         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
7456         * unittests/memrange-selftests.c: Fix common/ includes.
7457         * unittests/memory-map-selftests.c: Fix common/ includes.
7458         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
7459         * unittests/function-view-selftests.c: Fix common/ includes.
7460         * unittests/environ-selftests.c: Fix common/ includes.
7461         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
7462         * unittests/common-utils-selftests.c: Fix common/ includes.
7463         * unittests/cli-utils-selftests.c: Fix common/ includes.
7464         * unittests/array-view-selftests.c: Fix common/ includes.
7465         * ui-file.c: Fix common/ includes.
7466         * tui/tui-io.c: Fix common/ includes.
7467         * tracepoint.h: Fix common/ includes.
7468         * tracepoint.c: Fix common/ includes.
7469         * tracefile-tfile.c: Fix common/ includes.
7470         * top.h: Fix common/ includes.
7471         * top.c: Fix common/ includes.
7472         * thread.c: Fix common/ includes.
7473         * target/waitstatus.h: Fix common/ includes.
7474         * target/waitstatus.c: Fix common/ includes.
7475         * target.h: Fix common/ includes.
7476         * target.c: Fix common/ includes.
7477         * target-memory.c: Fix common/ includes.
7478         * target-descriptions.c: Fix common/ includes.
7479         * symtab.h: Fix common/ includes.
7480         * symfile.c: Fix common/ includes.
7481         * stap-probe.c: Fix common/ includes.
7482         * spu-linux-nat.c: Fix common/ includes.
7483         * sparc-nat.c: Fix common/ includes.
7484         * source.c: Fix common/ includes.
7485         * solib.c: Fix common/ includes.
7486         * solib-target.c: Fix common/ includes.
7487         * ser-unix.c: Fix common/ includes.
7488         * ser-tcp.c: Fix common/ includes.
7489         * ser-pipe.c: Fix common/ includes.
7490         * ser-base.c: Fix common/ includes.
7491         * selftest-arch.c: Fix common/ includes.
7492         * s12z-tdep.c: Fix common/ includes.
7493         * rust-exp.y: Fix common/ includes.
7494         * rs6000-aix-tdep.c: Fix common/ includes.
7495         * riscv-tdep.c: Fix common/ includes.
7496         * remote.c: Fix common/ includes.
7497         * remote-notif.h: Fix common/ includes.
7498         * remote-fileio.h: Fix common/ includes.
7499         * remote-fileio.c: Fix common/ includes.
7500         * regcache.h: Fix common/ includes.
7501         * regcache.c: Fix common/ includes.
7502         * record-btrace.c: Fix common/ includes.
7503         * python/python.c: Fix common/ includes.
7504         * python/py-type.c: Fix common/ includes.
7505         * python/py-inferior.c: Fix common/ includes.
7506         * progspace.h: Fix common/ includes.
7507         * producer.c: Fix common/ includes.
7508         * procfs.c: Fix common/ includes.
7509         * proc-api.c: Fix common/ includes.
7510         * printcmd.c: Fix common/ includes.
7511         * ppc-linux-nat.c: Fix common/ includes.
7512         * parser-defs.h: Fix common/ includes.
7513         * osdata.c: Fix common/ includes.
7514         * obsd-nat.c: Fix common/ includes.
7515         * nat/x86-linux.c: Fix common/ includes.
7516         * nat/x86-linux-dregs.c: Fix common/ includes.
7517         * nat/x86-dregs.h: Fix common/ includes.
7518         * nat/x86-dregs.c: Fix common/ includes.
7519         * nat/ppc-linux.c: Fix common/ includes.
7520         * nat/mips-linux-watch.h: Fix common/ includes.
7521         * nat/mips-linux-watch.c: Fix common/ includes.
7522         * nat/linux-waitpid.c: Fix common/ includes.
7523         * nat/linux-ptrace.h: Fix common/ includes.
7524         * nat/linux-ptrace.c: Fix common/ includes.
7525         * nat/linux-procfs.c: Fix common/ includes.
7526         * nat/linux-personality.c: Fix common/ includes.
7527         * nat/linux-osdata.c: Fix common/ includes.
7528         * nat/linux-namespaces.c: Fix common/ includes.
7529         * nat/linux-btrace.h: Fix common/ includes.
7530         * nat/linux-btrace.c: Fix common/ includes.
7531         * nat/fork-inferior.c: Fix common/ includes.
7532         * nat/amd64-linux-siginfo.c: Fix common/ includes.
7533         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
7534         * nat/aarch64-linux.c: Fix common/ includes.
7535         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
7536         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
7537         * namespace.h: Fix common/ includes.
7538         * mips-linux-tdep.c: Fix common/ includes.
7539         * minsyms.c: Fix common/ includes.
7540         * mi/mi-parse.h: Fix common/ includes.
7541         * mi/mi-main.c: Fix common/ includes.
7542         * mi/mi-cmd-env.c: Fix common/ includes.
7543         * memrange.h: Fix common/ includes.
7544         * memattr.c: Fix common/ includes.
7545         * maint.h: Fix common/ includes.
7546         * maint.c: Fix common/ includes.
7547         * main.c: Fix common/ includes.
7548         * machoread.c: Fix common/ includes.
7549         * location.c: Fix common/ includes.
7550         * linux-thread-db.c: Fix common/ includes.
7551         * linux-nat.c: Fix common/ includes.
7552         * linux-fork.c: Fix common/ includes.
7553         * inline-frame.c: Fix common/ includes.
7554         * infrun.c: Fix common/ includes.
7555         * inflow.c: Fix common/ includes.
7556         * inferior.h: Fix common/ includes.
7557         * inferior.c: Fix common/ includes.
7558         * infcmd.c: Fix common/ includes.
7559         * inf-ptrace.c: Fix common/ includes.
7560         * inf-child.c: Fix common/ includes.
7561         * ia64-linux-nat.c: Fix common/ includes.
7562         * i387-tdep.c: Fix common/ includes.
7563         * i386-tdep.c: Fix common/ includes.
7564         * i386-linux-tdep.c: Fix common/ includes.
7565         * i386-linux-nat.c: Fix common/ includes.
7566         * i386-go32-tdep.c: Fix common/ includes.
7567         * i386-fbsd-tdep.c: Fix common/ includes.
7568         * i386-fbsd-nat.c: Fix common/ includes.
7569         * guile/scm-type.c: Fix common/ includes.
7570         * guile/guile.c: Fix common/ includes.
7571         * go32-nat.c: Fix common/ includes.
7572         * gnu-nat.c: Fix common/ includes.
7573         * gdbthread.h: Fix common/ includes.
7574         * gdbarch-selftests.c: Fix common/ includes.
7575         * gdb_usleep.c: Fix common/ includes.
7576         * gdb_select.h: Fix common/ includes.
7577         * gdb_bfd.c: Fix common/ includes.
7578         * gcore.c: Fix common/ includes.
7579         * fork-child.c: Fix common/ includes.
7580         * findvar.c: Fix common/ includes.
7581         * fbsd-nat.c: Fix common/ includes.
7582         * event-top.c: Fix common/ includes.
7583         * event-loop.c: Fix common/ includes.
7584         * dwarf2read.c: Fix common/ includes.
7585         * dwarf2loc.c: Fix common/ includes.
7586         * dwarf2-frame.c: Fix common/ includes.
7587         * dwarf-index-cache.c: Fix common/ includes.
7588         * dtrace-probe.c: Fix common/ includes.
7589         * disasm-selftests.c: Fix common/ includes.
7590         * defs.h: Fix common/ includes.
7591         * csky-tdep.c: Fix common/ includes.
7592         * cp-valprint.c: Fix common/ includes.
7593         * cp-support.h: Fix common/ includes.
7594         * cp-support.c: Fix common/ includes.
7595         * corelow.c: Fix common/ includes.
7596         * completer.h: Fix common/ includes.
7597         * completer.c: Fix common/ includes.
7598         * compile/compile.c: Fix common/ includes.
7599         * compile/compile-loc2c.c: Fix common/ includes.
7600         * compile/compile-cplus-types.c: Fix common/ includes.
7601         * compile/compile-cplus-symbols.c: Fix common/ includes.
7602         * command.h: Fix common/ includes.
7603         * cli/cli-dump.c: Fix common/ includes.
7604         * cli/cli-cmds.c: Fix common/ includes.
7605         * charset.c: Fix common/ includes.
7606         * build-id.c: Fix common/ includes.
7607         * btrace.h: Fix common/ includes.
7608         * btrace.c: Fix common/ includes.
7609         * breakpoint.h: Fix common/ includes.
7610         * breakpoint.c: Fix common/ includes.
7611         * ax.h:
7612         (enum agent_op): Fix common/ includes.
7613         * ax-general.c (struct aop_map): Fix common/ includes.
7614         * ax-gdb.c: Fix common/ includes.
7615         * auxv.c: Fix common/ includes.
7616         * auto-load.c: Fix common/ includes.
7617         * arm-tdep.c: Fix common/ includes.
7618         * arch/riscv.c: Fix common/ includes.
7619         * arch/ppc-linux-common.c: Fix common/ includes.
7620         * arch/i386.c: Fix common/ includes.
7621         * arch/arm.c: Fix common/ includes.
7622         * arch/arm-linux.c: Fix common/ includes.
7623         * arch/arm-get-next-pcs.c: Fix common/ includes.
7624         * arch/amd64.c: Fix common/ includes.
7625         * arch/aarch64.c: Fix common/ includes.
7626         * arch/aarch64-insn.c: Fix common/ includes.
7627         * arch-utils.c: Fix common/ includes.
7628         * amd64-windows-tdep.c: Fix common/ includes.
7629         * amd64-tdep.c: Fix common/ includes.
7630         * amd64-sol2-tdep.c: Fix common/ includes.
7631         * amd64-obsd-tdep.c: Fix common/ includes.
7632         * amd64-nbsd-tdep.c: Fix common/ includes.
7633         * amd64-linux-tdep.c: Fix common/ includes.
7634         * amd64-linux-nat.c: Fix common/ includes.
7635         * amd64-fbsd-tdep.c: Fix common/ includes.
7636         * amd64-fbsd-nat.c: Fix common/ includes.
7637         * amd64-dicos-tdep.c: Fix common/ includes.
7638         * amd64-darwin-tdep.c: Fix common/ includes.
7639         * agent.c: Fix common/ includes.
7640         * ada-lang.h: Fix common/ includes.
7641         * ada-lang.c: Fix common/ includes.
7642         * aarch64-tdep.c: Fix common/ includes.
7643
7644 2019-01-25  Tom Tromey  <tom@tromey.com>
7645
7646         * common/create-version.sh: Use common/version.h.
7647
7648 2019-01-24  Pedro Alves  <palves@redhat.com>
7649
7650         * infrun.c (signal_stop, signal_print, signal_program)
7651         (signal_catch, signal_pass): Now arrays instead of pointers.
7652         (update_signals_program_target, do_target_resume)
7653         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7654         * linux-nat.c (linux_nat_target::pass_signals)
7655         (linux_nat_target::create_inferior, linux_nat_target::attach):
7656         Adjust.
7657         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7658         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7659         * procfs.c (procfs_target::pass_signals): Adjust.
7660         * record-full.c (record_full_target::resume): Adjust.
7661         * remote.c (remote_target::pass_signals)
7662         (remote_target::program_signals): Adjust.
7663         * target-debug.h (target_debug_print_signals): Now takes a
7664         gdb::array_view as parameter.  Adjust.
7665         * target.h (target_ops) <pass_signals, program_signals>: Replace
7666         pointer and length parameters with gdb::array_view.
7667         (target_pass_signals, target_program_signals): Likewise.
7668         * target-delegates.c: Regenerate.
7669
7670 2019-01-24  Pedro Alves  <palves@redhat.com>
7671
7672         * common/forward-scope-exit.h
7673         (forward_scope_exit::forward_scope_exit): Pass arguments to
7674         m_bind_function directly, instead of creating a std::bind and
7675         copying that.
7676
7677 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7678
7679         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7680         for static members.
7681         (pass_in_v_vfp_candidate): Likewise.
7682
7683 2019-01-23  Tom Tromey  <tom@tromey.com>
7684             Pedro Alves  <palves@redhat.com>
7685
7686         * regcache.c (class regcache_invalidator): Remove.
7687         (regcache::raw_write): Use make_scope_exit.
7688
7689 2019-01-23  Tom Tromey  <tom@tromey.com>
7690
7691         * ui-out.h (class ui_out_emit_type): Update comment.
7692
7693 2019-01-23  Tom Tromey  <tom@tromey.com>
7694
7695         * infrun.c (fetch_inferior_event): Update comment.
7696
7697 2019-01-23  Tom Tromey  <tom@tromey.com>
7698             Pedro Alves  <palves@redhat.com>
7699
7700         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7701         parameter.
7702         (fetch_inferior_event): Use SCOPE_EXIT.
7703
7704
7705 2019-01-23  Tom Tromey  <tom@tromey.com>
7706             Pedro Alves  <palves@redhat.com>
7707
7708         * infrun.c (disable_thread_events): Delete.
7709         (stop_all_threads): Use SCOPE_EXIT.
7710
7711 2019-01-23  Tom Tromey  <tom@tromey.com>
7712             Pedro Alves  <palves@redhat.com>
7713
7714         * symfile.c: Include forward-scope-exit.h.
7715         (clear_symtab_users_cleanup): Replace forward declaration with
7716         a FORWARD_SCOPE_EXIT.
7717         (syms_from_objfile_1): Use the forward_scope_exit and
7718         gdb::optional instead of cleanup_function.
7719         (reread_symbols): Use the forward_scope_exit instead of
7720         cleanup_function.
7721         (clear_symtab_users_cleanup): Remove function.
7722
7723 2019-01-23  Tom Tromey  <tom@tromey.com>
7724             Pedro Alves  <palves@redhat.com>
7725
7726         * linux-nat.c: Include scope-exit.h.
7727         (cleanup_target_stop): Remove.
7728         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7729         SCOPE_EXIT.
7730
7731 2019-01-23  Tom Tromey  <tom@tromey.com>
7732             Pedro Alves  <palves@redhat.com>
7733
7734         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7735         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7736
7737 2019-01-23  Tom Tromey  <tom@tromey.com>
7738             Andrew Burgess  <andrew.burgess@embecosm.com>
7739             Pedro Alves  <palves@redhat.com>
7740
7741         * infrun.c (fetch_inferior_event): Use scope_exit.
7742         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7743         * top.c (execute_command): Use scope_exit.
7744         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7745         * utils.c (do_bpstat_clear_actions_cleanup)
7746         (make_bpstat_clear_actions_cleanup): Remove.
7747
7748 2019-01-23  Tom Tromey  <tom@tromey.com>
7749             Pedro Alves  <palves@redhat.com>
7750
7751         * infrun.c: Include "common/scope-exit.h"
7752         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7753         (wait_for_inferior): Use SCOPE_EXIT.
7754         (fetch_inferior_event): Use scope_exit.
7755
7756 2019-01-23  Tom Tromey  <tom@tromey.com>
7757             Pedro Alves  <palves@redhat.com>
7758
7759         * breakpoint.c (create_breakpoint): Remove cleanup.
7760
7761 2019-01-23  Tom Tromey  <tom@tromey.com>
7762             Andrew Burgess  <andrew.burgess@embecosm.com>
7763             Pedro Alves  <palves@redhat.com>
7764
7765 2019-01-23  Pedro Alves  <palves@redhat.com>
7766
7767         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7768
7769 2019-01-23  Pedro Alves  <palves@redhat.com>
7770             Andrew Burgess  <andrew.burgess@embecosm.com>
7771
7772         * gdbthread.h: Include "common/forward-scope-exit.h".
7773         (scoped_finish_thread_state): Redefine custom class in terms of
7774         forward_scope_exit.
7775
7776 2019-01-23  Pedro Alves  <palves@redhat.com>
7777             Andrew Burgess  <andrew.burgess@embecosm.com>
7778
7779         * common/forward-scope-exit.h: New file.
7780
7781 2019-01-23  Pedro Alves  <palves@redhat.com>
7782             Andrew Burgess  <andrew.burgess@embecosm.com>
7783             Tom Tromey  <tom@tromey.com>
7784
7785         * common/scope-exit.h: New file.
7786
7787 2019-01-23  Pedro Alves  <palves@redhat.com>
7788
7789         * common/preprocessor.h (ESC): Rename to ...
7790         (ESC_PARENS): ... this.
7791         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7792         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7793
7794 2019-01-23  Tom Tromey  <tom@tromey.com>
7795
7796         * language.h (class scoped_switch_to_sym_language_if_auto):
7797         Initialize m_lang in both cases.
7798
7799 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7800
7801         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7802         with XCNEW.
7803
7804 2019-01-22  Tom Tromey  <tom@tromey.com>
7805
7806         * corelow.c: Do not include sys/file.h.
7807
7808 2019-01-22  Tom Tromey  <tom@tromey.com>
7809
7810         * tui/tui-wingeneral.h: Include gdb_curses.h.
7811
7812 2019-01-22  Tom Tromey  <tom@tromey.com>
7813
7814         * source-cache.h (class source_cache) <get_source_lines,
7815         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7816
7817 2019-01-22  Tom Tromey  <tom@tromey.com>
7818
7819         * remote-fileio.h (struct remote_target): Declare.
7820
7821 2019-01-22  Tom Tromey  <tom@tromey.com>
7822
7823         * python/py-arch.c: Do not include py-ref.h.
7824         * python/py-bpevent.c: Do not include py-ref.h.
7825         * python/py-cmd.c: Do not include py-ref.h.
7826         * python/py-continueevent.c: Do not include py-ref.h.
7827         * python/py-event.h: Do not include py-ref.h.
7828         * python/py-evtregistry.c: Do not include py-ref.h.
7829         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7830         * python/py-frame.c: Do not include py-ref.h.
7831         * python/py-framefilter.c: Do not include py-ref.h.
7832         * python/py-function.c: Do not include py-ref.h.
7833         * python/py-infevents.c: Do not include py-ref.h.
7834         * python/py-linetable.c: Do not include py-ref.h.
7835         * python/py-objfile.c: Do not include py-ref.h.
7836         * python/py-param.c: Do not include py-ref.h.
7837         * python/py-prettyprint.c: Do not include py-ref.h.
7838         * python/py-progspace.c: Do not include py-ref.h.
7839         * python/py-symbol.c: Do not include py-ref.h.
7840         * python/py-symtab.c: Do not include py-ref.h.
7841         * python/py-type.c: Do not include py-ref.h.
7842         * python/py-unwind.c: Do not include py-ref.h.
7843         * python/py-utils.c: Do not include py-ref.h.
7844         * python/py-value.c: Do not include py-ref.h.
7845         * python/py-varobj.c: Do not include py-ref.h.
7846         * python/py-xmethods.c: Do not include py-ref.h.
7847         * python/python.c: Do not include py-ref.h.
7848         * varobj.c: Do not include py-ref.h.
7849
7850 2019-01-22  Tom Tromey  <tom@tromey.com>
7851
7852         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7853         keyword for bcache.
7854
7855 2019-01-22  Tom Tromey  <tom@tromey.com>
7856
7857         * compile/compile-cplus-types.c: Remove a comment by #include.
7858
7859 2019-01-22  Tom Tromey  <tom@tromey.com>
7860
7861         * compile/gcc-c-plugin.h: Include compile-internal.h.
7862
7863 2019-01-22  Tom Tromey  <tom@tromey.com>
7864
7865         * stabsread.c (EXTERN): Do not define.
7866         (symnum, next_symbol_text_func, processing_gcc_compilation)
7867         (within_function, global_sym_chain, global_stabs)
7868         (previous_stab_code, this_object_header_files)
7869         (n_this_object_header_files)
7870         (n_allocated_this_object_header_files): Define.
7871         * stabsread.h (EXTERN): Never define.  Use "extern".
7872
7873 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7874
7875         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7876         history_value.
7877
7878 2019-01-21  Tom Tromey  <tom@tromey.com>
7879
7880         * ui-out.c: Fix includes.
7881         * tui/tui-source.c: Fix includes.
7882         * target.c: Fix includes.
7883         * remote.c: Fix includes.
7884         * regcache.c: Fix includes.
7885         * python/py-block.c: Fix includes.
7886         * printcmd.c: Fix includes.
7887         * or1k-tdep.c: Fix includes.
7888         * mi/mi-main.c: Fix includes.
7889         * m32r-tdep.c: Fix includes.
7890         * csky-tdep.c: Fix includes.
7891         * compile/compile-cplus-types.c: Fix includes.
7892         * cli/cli-interp.c: Fix includes.
7893
7894 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7895
7896         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7897         for padding.
7898
7899 2019-01-16  Tom Tromey  <tom@tromey.com>
7900
7901         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7902         earlier.
7903         (struct objfile) <msymbols_range>: Move from top level.
7904         <msymbols>: New method.
7905         (class objfile_msymbols): Remove.
7906         * symtab.c (default_collect_symbol_completion_matches_break_on):
7907         Update.
7908         * symmisc.c (dump_msymbols): Update.
7909         * stabsread.c (scan_file_globals): Update.
7910         * objc-lang.c (info_selectors_command, info_classes_command)
7911         (find_methods): Update.
7912         * minsyms.c (find_solib_trampoline_target): Update.
7913         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7914         * coffread.c (coff_symfile_read): Update.
7915         * ada-lang.c (ada_lookup_simple_minsym)
7916         (ada_collect_symbol_completion_matches): Update.
7917
7918 2019-01-16  Tom Tromey  <tom@tromey.com>
7919
7920         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7921         type.  Remove no-argument constructor.
7922         <iterator::operator++>: Simplify.
7923         <begin>: Update.
7924         <end>: Use minimal_symbol_count.
7925
7926 2019-01-16  Tom Tromey  <tom@tromey.com>
7927
7928         * objfiles.h (struct objfile) <psymtabs>: New method.
7929         (class objfile_psymtabs): Remove.
7930         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7931         typedef.
7932         <range>: New method.
7933         (require_partial_symbols): Change return type.
7934         * psymtab.c (require_partial_symbols)
7935         (psym_expand_symtabs_matching): Update.
7936         * mdebugread.c (parse_partial_symbols): Update.
7937         * dbxread.c (dbx_end_psymtab): Update.
7938
7939 2019-01-15  Tom Tromey  <tom@tromey.com>
7940
7941         * symtab.c (lookup_objfile_from_block)
7942         (lookup_symbol_in_objfile_symtabs)
7943         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7944         (find_line_symtab, info_sources_command)
7945         (default_collect_symbol_completion_matches_break_on)
7946         (make_source_files_completion_list): Update.
7947         * symmisc.c (print_objfile_statistics, dump_objfile)
7948         (maintenance_print_symbols, maintenance_info_symtabs)
7949         (maintenance_check_symtabs, maintenance_info_line_tables):
7950         Update.
7951         * source.c (select_source_symtab)
7952         (forget_cached_source_info_for_objfile): Update.
7953         * objfiles.h (class objfile_compunits): Remove.
7954         (struct objfile) <compunits_range>: New typedef.
7955         (compunits): New method.
7956         * objfiles.c (objfile_relocate1): Update.
7957         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7958         * maint.c (count_symtabs_and_blocks): Update.
7959         * linespec.c (iterate_over_all_matching_symtabs): Update.
7960         * cp-support.c (add_symbol_overload_list_qualified): Update.
7961         * coffread.c (coff_symtab_read): Update.
7962         * ada-lang.c (add_nonlocal_symbols)
7963         (ada_collect_symbol_completion_matches)
7964         (ada_add_global_exceptions): Update.
7965
7966 2019-01-15  Tom Tromey  <tom@tromey.com>
7967
7968         * progspace.h (program_space) <objfiles_safe_range>: New
7969         typedef.
7970         <objfiles_safe>: New method.
7971         * objfiles.h (class all_objfiles_safe): Remove.
7972         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7973         * jit.c (jit_inferior_exit_hook): Update.
7974
7975 2019-01-17  Tom Tromey  <tom@tromey.com>
7976
7977         * progspace.h (program_space) <objfiles_range>: New typedef.
7978         <objfiles>: New method.
7979         <objfiles_head>: Rename from objfiles.
7980         (object_files): Update.
7981         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7982         * guile/scm-pretty-print.c
7983         (ppscm_find_pretty_printer_from_objfiles): Update.
7984         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7985         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7986         Update.
7987         * python/py-progspace.c (pspy_get_objfiles): Update.
7988         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7989         Update.
7990         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7991         (objfpy_lookup_objfile_by_build_id): Update.
7992         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7993         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7994         Update.
7995         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7996         (expand_symtab_containing_pc, lookup_objfile_from_block)
7997         (lookup_static_symbol, basic_lookup_transparent_type)
7998         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7999         (find_line_symtab, info_sources_command)
8000         (default_collect_symbol_completion_matches_break_on)
8001         (make_source_files_completion_list, find_main_name): Update.
8002         * symmisc.c (print_symbol_bcache_statistics)
8003         (print_objfile_statistics, maintenance_print_symbols)
8004         (maintenance_print_msymbols, maintenance_print_objfiles)
8005         (maintenance_info_symtabs, maintenance_check_symtabs)
8006         (maintenance_expand_symtabs, maintenance_info_line_tables):
8007         Update.
8008         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
8009         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
8010         (map_overlay_command, unmap_overlay_command)
8011         (simple_overlay_update, expand_symtabs_matching)
8012         (map_symbol_filenames): Update.
8013         * symfile-debug.c (set_debug_symfile): Update.
8014         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
8015         Update.
8016         * source.c (select_source_symtab, forget_cached_source_info):
8017         Update.
8018         * solib.c (solib_read_symbols): Update.
8019         * solib-spu.c (append_ocl_sos): Update.
8020         * psymtab.c (maintenance_print_psymbols)
8021         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
8022         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
8023         * printcmd.c (info_symbol_command): Update.
8024         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
8025         Update.
8026         * objfiles.h (class all_objfiles): Remove.
8027         * objfiles.c (have_partial_symbols, have_full_symbols)
8028         (have_minimal_symbols, qsort_cmp, update_section_map)
8029         (shared_objfile_contains_address_p)
8030         (default_iterate_over_objfiles_in_search_order): Update.
8031         * objc-lang.c (info_selectors_command, info_classes_command)
8032         (find_methods): Update.
8033         * minsyms.c (find_solib_trampoline_target): Update.
8034         * maint.c (maintenance_info_sections)
8035         (maintenance_translate_address, count_symtabs_and_blocks):
8036         Update.
8037         * main.c (captured_main_1): Update.
8038         * linux-thread-db.c (try_thread_db_load_from_pdir)
8039         (has_libpthread): Update.
8040         * linespec.c (iterate_over_all_matching_symtabs)
8041         (search_minsyms_for_name): Update.
8042         * jit.c (jit_find_objf_with_entry_addr): Update.
8043         * hppa-tdep.c (find_unwind_entry)
8044         (hppa_lookup_stub_minimal_symbol): Update.
8045         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
8046         Update.
8047         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8048         (elf_gnu_ifunc_resolve_by_got): Update.
8049         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
8050         * dwarf-index-write.c (save_gdb_index_command): Update.
8051         * cp-support.c (add_symbol_overload_list_qualified): Update.
8052         * breakpoint.c (create_overlay_event_breakpoint)
8053         (create_longjmp_master_breakpoint)
8054         (create_std_terminate_master_breakpoint)
8055         (create_exception_master_breakpoint): Update.
8056         * blockframe.c (find_pc_partial_function): Update.
8057         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
8058         (ada_collect_symbol_completion_matches)
8059         (ada_add_global_exceptions): Update.
8060
8061 2019-01-17  Tom Tromey  <tom@tromey.com>
8062
8063         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
8064         declare VEC.
8065         (solib_target_parse_libraries): Change return type.
8066         (library_list_start_segment, library_list_start_section)
8067         (library_list_end_library, library_list_start_library); Update.
8068         (solib_target_free_library_list): Remove.
8069         (solib_target_parse_libraries): Remove cleanup.  Change return
8070         type.
8071         (solib_target_current_sos): Update.
8072
8073 2019-01-17  Tom Tromey  <tromey@bapiya>
8074
8075         * valprint.c: Replace "the the" with "the".
8076         * symtab.c: Replace "the the" with "the".
8077         * solib.c: Replace "the the" with "the".
8078         * solib-dsbt.c: Replace "the the" with "the".
8079         * linespec.c: Replace "the the" with "the".
8080         * dwarf2loc.h: Replace "the the" with "the".
8081         * amd64-windows-tdep.c: Replace "the the" with "the".
8082         * aarch64-tdep.c: Replace "the the" with "the".
8083
8084 2019-01-16  Keith Seitz  <keiths@redhat.com>
8085
8086         PR gdb/23773
8087         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
8088         <builder>: Rename to ..
8089         <m_builder>: ... this and make private.
8090         (dwarf2_cu::get_builder): New method.  Change all users of
8091         `builder' to use this method.
8092         (dwarf2_start_symtab): Move to ...
8093         (dwarf2_cu::start_symtab): ... here.  Update all callers
8094         (setup_type_unit_groups): Move to ...
8095         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
8096         callers.
8097         (dwarf2_cu::reset_builder): New method.
8098         (process_full_compunit, process_full_type_unit): Use
8099         dwarf2_cu::reset_builder.
8100         (follow_die_offset): Record the ancestor CU if it is different
8101         from the followed DIE's CU.
8102         (follow_die_sig_1): Likewise.
8103
8104 2019-01-15  Tom Tromey  <tom@tromey.com>
8105
8106         * remote.c (class remote_state) <buf>: Now a char_vector.
8107         <buf_size>: Remove.
8108         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
8109         parameter.
8110         (remote_target::getpkt_or_notif_sane_1)
8111         (remote_target::getpkt_sane)
8112         (remote_target::getpkt_or_notif_sane): Likewise.
8113         (class remote_target) <putpkt>: New overload.
8114         (remote_target::read_frame): Change type of "buf_p".  Remove
8115         sizeof_p parameter.
8116         (packet_ok): New overload.
8117         (packet_check_result): New overload.
8118         Update all uses.
8119
8120 2019-01-14  Tom Tromey  <tom@tromey.com>
8121
8122         * remote-notif.c (handle_notification, remote_notif_ack)
8123         (remote_notif_parse): Make "buf" const.
8124         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
8125         const.
8126         (remote_notif_parse, remote_notif_ack, handle_notification):
8127         Likewise.
8128         * remote.c (remote_notif_stop_parse): Make "buf" const.
8129         (remote_target::remote_parse_stop_reply): Make "buf" const.
8130         (remote_notif_stop_ack): Make "buf" const.
8131
8132 2019-01-14  Tom Tromey  <tom@tromey.com>
8133
8134         * remote.c (remote_console_output): Make parameter const.
8135
8136 2019-01-14  Tom Tromey  <tom@tromey.com>
8137
8138         * target-debug.h (target_debug_print_signals): Constify.
8139         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
8140         * procfs.c (procfs_target::pass_signals): Update.
8141         * linux-nat.c (linux_nat_target::pass_signals): Update.
8142         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
8143         * target-delegates.c: Rebuild.
8144         * remote.c (remote_target::program_signals): Update.
8145         (remote_target::pass_signals): Update.
8146         * target.c (target_pass_signals): Constify argument.
8147         (target_program_signals): Likewise.
8148         * target.h (struct target_ops) <pass_signals, program_signals>:
8149         Constify argument.
8150         (target_pass_signals, target_program_signals): Constify argument.
8151
8152 2019-01-14  Tom Tromey  <tom@tromey.com>
8153
8154         PR tui/28819:
8155         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
8156
8157 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
8158
8159         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
8160         field.
8161         * rs6000-tdep.c: Include reggroups.h.
8162         (IS_V_ALIAS_PSEUDOREG): Define.
8163         (rs6000_register_name): Return names for the "vX" aliases.
8164         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
8165         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
8166         aliases.  Call default_register_reggroup_p for all other
8167         pseudo-registers.
8168         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
8169         New functions.
8170         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
8171         Handle "vX" aliases.
8172         (v_alias_pseudo_register_collect): New function.
8173         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
8174         (rs6000_gdbarch_init): Initialize "vX" aliases as
8175         pseudo-registers.  Restore registration of
8176         rs6000_pseudo_register_reggroup_p with
8177         set_tdesc_pseudo_register_reggroup_p.
8178
8179 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
8180
8181         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
8182         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
8183         set_gdbarch_num_pseudo_regs.
8184
8185 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8186
8187         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
8188         Remove arg prefixname, add do_set and do_show.
8189         Add member functions set_list and show_list.
8190         * cli/cli-style.c (class cli_style_option): Update accordingly.
8191         (style_set_list): Move to file scope.
8192         (style_show_list): Likewise.
8193         (set_style): Call help_list.
8194         (show_style): Call cmd_show_list.
8195         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
8196         Update to use the new macro.
8197
8198 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
8199
8200         * ada-lang.c (_initialize_ada_language): Expand the help text
8201         for the "catch exception" command.
8202
8203 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8204
8205         * symtab.c (matching_obj_sections): Initialize obj,
8206         declare it closer to its usage.
8207
8208 2019-01-10  Tom Tromey  <tom@tromey.com>
8209
8210         * thread-iter.h (inf_threads_iterator): Use next_iterator.
8211         (basic_inf_threads_range): Remove.
8212         (inf_threads_range, inf_non_exited_threads_range)
8213         (safe_inf_threads_range): Use next_adapter.
8214
8215 2019-01-10  Keith Seitz  <keiths@redhat.com>
8216
8217         PR gdb/23712
8218         PR symtab/23010
8219         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
8220         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
8221
8222 2019-01-10  Keith Seitz  <keiths@redhat.com>
8223
8224         PR gdb/23712
8225         PR symtab/23010
8226         * dictionary.c (pending_to_vector): Remove.
8227         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8228         Remove _1 suffix, replacing functions of the same name.  Update
8229         all callers.
8230         (dict_create_hashed, dict_create_hashed_expandable)
8231         (dict_create_linear, dict_create_linear_expandable, dict_free)
8232         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
8233         Make functions static.
8234
8235 2019-01-10  Keith Seitz  <keiths@redhat.com>
8236
8237         PR gdb/23712
8238         PR symtab/23010
8239         * dictionary.h (struct dictionary): Replace declaration with
8240         multidictionary.
8241         (dict_create_hashed, dict_create_hashed_expandable)
8242         (dict_create_linear, dict_create_linear_expandable)
8243         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
8244         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
8245         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
8246         taking multidictionary argument.
8247         [ALL_DICT_SYMBOLS]: Update for multidictionary.
8248         * block.h (struct block) <dict>: Change to multidictionary
8249         and rename `multidict'.
8250         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
8251         symmisc.c: Update all dictionary references to multidictionary.
8252
8253 2019-01-10  Keith Seitz  <keiths@redhat.com>
8254
8255         PR gdb/23712
8256         PR symtab/23010
8257         * dictionary.c: Include unordered_map.
8258         (pending_to_vector): New function.
8259         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
8260         Rewrite the non-"_1" functions to take vector instead
8261         of linked list.
8262         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
8263         "new" _1 versions of the same name.
8264         (multidictionary): Define.
8265         (std::hash<enum language): New definition.
8266         (collate_pending_symbols_by_language, mdict_create_hashed)
8267         (mdict_create_hashed_expandable, mdict_create_linear)
8268         (mdict_create_linear_expandable, mdict_free)
8269         (find_language_dictionary, create_new_language_dictionary)
8270         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
8271         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
8272         (mdict_size, mdict_empty): New functions.
8273         * dictionary.h (mdict_iterator): Define.
8274
8275 2019-01-10  Pedro Alves  <palves@redhat.com>
8276
8277         * breakpoint.c (read_uploaded_action)
8278         (create_tracepoint_from_upload): Adjust to use
8279         gdb::unique_xmalloc_ptr.
8280         * ctf.c (ctf_write_uploaded_tp):
8281         (SET_ARRAY_FIELD): Use emplace_back.
8282         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
8283         * tracefile-tfile.c (tfile_write_uploaded_tp):
8284         * tracepoint.c (parse_tracepoint_definition): Adjust to use
8285         gdb::unique_xmalloc_ptr.
8286         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
8287         at_string, cond_string, cmd_strings>: Replace char pointers
8288         with gdb::unique_xmalloc_ptr.
8289
8290 2019-01-10  Pedro Alves  <palves@redhat.com>
8291
8292         * solib-target.c (library_list_start_library): Don't xstrdup name.
8293
8294 2019-01-10  Pedro Alves  <palves@redhat.com>
8295
8296         * mdebugread.c (parse_partial_symbols): Use
8297         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
8298
8299 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8300
8301         * linux-fork.c (scoped_switch_fork_info)
8302         <~scoped_switch_fork_info>: Fix incorrect variable name.
8303
8304 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
8305
8306         * linux-fork.c (scoped_switch_fork_info)
8307         <scoped_switch_fork_info>: Make explicit.
8308         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
8309
8310 2019-01-10  Tom Tromey  <tom@tromey.com>
8311
8312         * objfiles.h (objfile::reset_psymtabs): Update.
8313         * objfiles.c (objfile::objfile): Update.
8314         * psymtab.h (psymtab_storage::obstack): Update.
8315         (psymtab_storage::m_obstack): Use gdb::optional.
8316         (class psymtab_storage): Update comment.  Remove objfile
8317         parameter.
8318         * psymtab.c (psymtab_storage::psymtab_storage): Update.
8319
8320 2019-01-10  Tom Tromey  <tom@tromey.com>
8321
8322         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
8323         <free_psymtabs>: Now private.
8324         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
8325         (allocate_psymtab): Use new method.
8326
8327 2019-01-10  Tom Tromey  <tom@tromey.com>
8328
8329         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
8330         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
8331         * mdebugread.c (parse_partial_symbols): Use
8332         allocate_dependencies.
8333         * dwarf2read.c (dwarf2_create_include_psymtab): Use
8334         allocate_dependencies.
8335         (process_psymtab_comp_unit_reader)
8336         (build_type_psymtab_dependencies): Likewise.
8337         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
8338
8339 2019-01-10  Tom Tromey  <tom@tromey.com>
8340
8341         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
8342         PSYMBOL_SET_LANGUAGE.
8343         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
8344
8345 2019-01-10  Tom Tromey  <tom@tromey.com>
8346
8347         * psymtab.h (psymtab_storage::obstack): New method.
8348         <m_obstack>: Rename from obstack; now private.
8349         * psymtab.c (psymtab_storage): Update.
8350         * dwarf2read.c (create_addrmap_from_index)
8351         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
8352         Update.
8353
8354 2019-01-10  Tom Tromey  <tom@tromey.com>
8355
8356         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
8357         * objfiles.h (objfile::reset_psymtabs): New method.
8358
8359 2019-01-10  Tom Tromey  <tom@tromey.com>
8360
8361         * symmisc.c (print_symbol_bcache_statistics): Update.
8362         (print_objfile_statistics): Update.
8363         * symfile.c (reread_symbols): Update.
8364         * psymtab.h (class psymtab_storage): New.
8365         * psymtab.c (psymtab_storage): New constructor.
8366         (~psymtab_storage): New destructor.
8367         (require_partial_symbols): Update.
8368         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
8369         (find_pc_sect_psymtab, find_pc_sect_psymbol)
8370         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
8371         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
8372         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
8373         (start_psymtab_common, end_psymtab_common)
8374         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
8375         (allocate_psymtab): Update.
8376         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
8377         Update.
8378         (dump_psymtab_addrmap, maintenance_print_psymbols)
8379         (maintenance_check_psymtabs): Update.
8380         (class objfile_psymtabs): Move to objfiles.h.
8381         * psympriv.h (discard_psymtab): Now inline.
8382         (psymtab_discarder::psymtab_discarder): Update.
8383         (psymtab_discarder::~psymtab_discarder): Update.
8384         (ALL_OBJFILE_PSYMTABS): Rewrite.
8385         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
8386         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
8387         Remove fields.
8388         <partial_symtabs>: New field.
8389         (class objfile_psymtabs): Move from psymtab.h.  Update.
8390         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
8391         psymbol_cache.
8392         (objfile::~objfile): Don't destroy psymbol_cache.
8393         * mdebugread.c (parse_partial_symbols): Update.
8394         * dwarf2read.c (create_addrmap_from_index)
8395         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
8396         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
8397         (add_partial_subprogram, dwarf2_ranges_read): Update.
8398         * dwarf-index-write.c (write_address_map)
8399         (write_one_signatured_type, recursively_write_psymbols)
8400         (class debug_names, class debug_names, write_psymtabs_to_index):
8401         Update.
8402
8403 2019-01-10  Tom Tromey  <tom@tromey.com>
8404
8405         * symtab.h (SYMBOL_SET_NAMES): Update.
8406         (symbol_set_names): Update.
8407         (MSYMBOL_SET_NAMES): Update.
8408         * symtab.c (symbol_set_names): Change argument to be an
8409         objfile_per_bfd_storage.
8410         * psymtab.c (add_psymbol_to_bcache): Update.
8411         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
8412
8413 2019-01-10  Tom Tromey  <tom@tromey.com>
8414
8415         * symtab.c (create_demangled_names_hash): Change argument to be an
8416         objfile_per_bfd_storage.
8417         (symbol_set_names): Update.
8418
8419 2019-01-10  Tom Tromey  <tom@tromey.com>
8420
8421         * xcoffread.c (xcoff_initial_scan): Unconditionally call
8422         init_psymbol_list.
8423         * psymtab.c (init_psymbol_list): Do nothing if already called.
8424         * psympriv.h (init_psymbol_list): Add comment.
8425         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
8426         init_psymbol_list.
8427         * dbxread.c (dbx_symfile_read): Unconditionally call
8428         init_psymbol_list.
8429
8430 2019-01-10  Tom Tromey  <tom@tromey.com>
8431
8432         * xcoffread.c (scan_xcoff_symtab): Update.
8433         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
8434         "where".
8435         * mdebugread.c (parse_partial_symbols)
8436         (handle_psymbol_enumerators): Update.
8437         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
8438         * dbxread.c (read_dbx_symtab): Update.
8439         * psympriv.h (psymbol_placement): New enum.
8440         (add_psymbol_to_list): Update.
8441
8442 2019-01-10  Tom Tromey  <tom@tromey.com>
8443
8444         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
8445         static_psymbols parameters.
8446         (scan_xcoff_symtab): Update.
8447         * psymtab.c (start_psymtab_common): Remove global_psymbols and
8448         static_psymbols parameters.
8449         * psympriv.h (start_psymtab_common): Update.
8450         * mdebugread.c (parse_partial_symbols): Update.
8451         * dwarf2read.c (create_partial_symtab): Update.
8452         * dbxread.c (read_dbx_symtab): Update.
8453         (start_psymtab): Remove global_psymbols and static_psymbols
8454         parameters.
8455
8456 2019-01-10  Tom Tromey  <tom@tromey.com>
8457
8458         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
8459         * psymtab.c (allocate_psymtab): Add comment.
8460         * psympriv.h (allocate_psymtab): Add comment.
8461         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
8462         initializations.
8463         * dbxread.c (dbx_end_psymtab): Remove some initializations.
8464
8465 2019-01-10  Tom Tromey  <tom@tromey.com>
8466
8467         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8468         Don't declare.
8469         * mipsread.c: Include mdebugread.h.
8470         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
8471         Declare.
8472         * elfread.c: Include mdebugread.h.
8473
8474 2019-01-09  Tom Tromey  <tom@tromey.com>
8475
8476         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
8477         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
8478         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
8479         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
8480         (psym_lookup_symbol, psym_find_last_source_symtab)
8481         (psym_forget_cached_source_info, psym_print_stats)
8482         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
8483         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
8484         (psym_map_matching_symbols, psym_expand_symtabs_matching)
8485         (psym_find_compunit_symtab_by_address)
8486         (maintenance_print_psymbols, maintenance_info_psymtabs)
8487         (maintenance_check_psymtabs): Use ranged for.
8488         * psymtab.h (class objfile_psymtabs): New.
8489         (require_partial_symbols): Return objfile_psymtabs.
8490         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
8491
8492 2019-01-09  Tom Tromey  <tom@tromey.com>
8493
8494         * symfile.c (overlay_invalidate_all, find_pc_overlay)
8495         (find_pc_mapped_section, list_overlays_command)
8496         (map_overlay_command, unmap_overlay_command)
8497         (simple_overlay_update): Use all_objfiles.
8498         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
8499         * printcmd.c (info_symbol_command): Use all_objfiles.
8500         * objfiles.h (ALL_OBJSECTIONS): Remove.
8501         * maint.c (maintenance_translate_address): Use all_objfiles.
8502         * gcore.c (gcore_create_callback): Use all_objfiles.
8503         (objfile_find_memory_regions): Likewise.
8504
8505 2019-01-09  Tom Tromey  <tom@tromey.com>
8506
8507         * symtab.c (find_line_symtab, info_sources_command)
8508         (make_source_files_completion_list): Use objfile_compunits.
8509         * source.c (select_source_symtab): Use objfile_compunits.
8510         * objfiles.h (struct objfile): Update comment.
8511         (ALL_OBJFILES): Remove.
8512         (ALL_FILETABS): Remove.
8513         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
8514         objfile_compunits.
8515
8516 2019-01-09  Tom Tromey  <tom@tromey.com>
8517
8518         * symmisc.c (print_objfile_statistics, dump_objfile)
8519         (maintenance_print_symbols): Use compunit_filetabs.
8520         * source.c (forget_cached_source_info_for_objfile): Use
8521         compunit_filetabs.
8522         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
8523         (ALL_FILETABS): Use compunit_filetabs.
8524         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
8525         * coffread.c (coff_symtab_read): Use compunit_filetabs.
8526
8527 2019-01-09  Tom Tromey  <tom@tromey.com>
8528
8529         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
8530         (compunit_filetabs): New.
8531         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
8532         compunit_filetabs.
8533         (info_sources_command, make_source_files_completion_list): Remove
8534         declaration.
8535         * symmisc.c (print_objfile_statistics, dump_objfile)
8536         (maintenance_print_symbols): Remove declaration.
8537         (maintenance_info_symtabs): Use compunit_filetabs.
8538         (maintenance_info_line_tables): Likewise.
8539         * source.c (select_source_symtab): Change local variable name.
8540         (forget_cached_source_info_for_objfile): Remove declaration.
8541         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
8542         * objfiles.c (objfile_relocate1): Remove declaration.
8543         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8544         declaration.
8545         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
8546         * coffread.c (coff_symtab_read): Remove declaration.
8547         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
8548         compunit_filetabs.
8549
8550 2019-01-09  Tom Tromey  <tom@tromey.com>
8551
8552         * symtab.c (lookup_objfile_from_block)
8553         (find_pc_sect_compunit_symtab, search_symbols)
8554         (default_collect_symbol_completion_matches_break_on): Use
8555         objfile_compunits.
8556         * objfiles.h (ALL_COMPUNITS): Remove.
8557         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
8558         * cp-support.c (add_symbol_overload_list_qualified): Use
8559         objfile_compunits.
8560         * ada-lang.c (ada_collect_symbol_completion_matches)
8561         (ada_add_global_exceptions): Use objfile_compunits.
8562
8563 2019-01-09  Tom Tromey  <tom@tromey.com>
8564
8565         * source.c (select_source_symtab)
8566         (forget_cached_source_info_for_objfile): Remove declaration.
8567         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
8568         declaration.
8569         * maint.c (count_symtabs_and_blocks): Remove declaration.
8570         * cp-support.c (add_symbol_overload_list_qualified): Remove
8571         declaration.
8572         * coffread.c (coff_symtab_read): Remove declaration.
8573         * symtab.c (lookup_symbol_in_objfile_symtabs)
8574         (basic_lookup_transparent_type_1): Use objfile_compunits.
8575         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
8576         (info_sources_command, search_symbols)
8577         (default_collect_symbol_completion_matches_break_on)
8578         (make_source_files_completion_list): Remove declaration.
8579         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
8580         (ada_collect_symbol_completion_matches)
8581         (ada_add_global_exceptions): Remove declaration.
8582         * linespec.c (iterate_over_all_matching_symtabs): Use
8583         objfile_compunits.
8584         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8585         (class objfile_compunits): New.
8586         (ALL_COMPUNITS): Use objfile_compunits.
8587         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8588         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8589         objfile_compunits.
8590         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8591
8592 2019-01-09  Tom Tromey  <tom@tromey.com>
8593
8594         * symtab.c (search_symbols)
8595         (default_collect_symbol_completion_matches_break_on): Use
8596         objfile_msymbols.
8597         * ada-lang.c (ada_lookup_simple_minsym)
8598         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8599         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8600         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8601         objfile_msymbols.
8602         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8603         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8604         * objc-lang.c (find_methods): Use objfile_msymbols.
8605         (info_selectors_command, info_classes_command): Likewise.
8606         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8607         * objfiles.h (class objfile_msymbols): New.
8608         (ALL_OBJFILE_MSYMBOLS): Remove.
8609         (ALL_MSYMBOLS): Remove.
8610
8611 2019-01-09  Tom Tromey  <tom@tromey.com>
8612
8613         * common/next-iterator.h (next_adapter): Add Iterator template
8614         parameter.
8615         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8616         (class all_objfiles_safe): New.
8617         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8618         * objfiles.c (put_objfile_before): Update comment.
8619         (add_separate_debug_objfile): Likewise.
8620         (free_all_objfiles): Use all_objfiles_safe.
8621         (objfile_purge_solibs): Likewise.
8622
8623 2019-01-09  Tom Tromey  <tom@tromey.com>
8624
8625         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8626         (expand_symtab_containing_pc, lookup_static_symbol)
8627         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8628         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8629         all_objfiles.
8630         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8631         * breakpoint.c (create_overlay_event_breakpoint)
8632         (create_longjmp_master_breakpoint)
8633         (create_std_terminate_master_breakpoint)
8634         (create_exception_master_breakpoint): Use all_objfiles.
8635         * linux-thread-db.c (try_thread_db_load_from_pdir)
8636         (has_libpthread): Use all_objfiles.
8637         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8638         * linespec.c (iterate_over_all_matching_symtabs)
8639         (search_minsyms_for_name): Use all_objfiles.
8640         * maint.c (maintenance_info_sections): Use all_objfiles.
8641         * main.c (captured_main_1): Use all_objfiles.
8642         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8643         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8644         * guile/scm-pretty-print.c
8645         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8646         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8647         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8648         (maintenance_print_msymbols): Use all_objfiles.
8649         * source.c (select_source_symtab): Use all_objfiles.
8650         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8651         * symfile.c (remove_symbol_file_command)
8652         (expand_symtabs_matching, map_symbol_filenames): Use
8653         all_objfiles.
8654         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8655         all_objfiles.
8656         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8657         * objc-lang.c (find_methods): Use all_objfiles.
8658         * objfiles.c (have_partial_symbols, have_full_symbols)
8659         (have_minimal_symbols, qsort_cmp)
8660         (default_iterate_over_objfiles_in_search_order): Use
8661         all_objfiles.
8662         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8663         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8664         (maintenance_check_psymtabs): Use all_objfiles.
8665         (ALL_PSYMTABS): Remove.
8666         * compile/compile-object-run.c (do_module_cleanup): Use
8667         all_objfiles.
8668         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8669         * cp-support.c (add_symbol_overload_list_qualified): Use
8670         all_objfiles.
8671         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8672         Use all_objfiles.
8673         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8674         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8675         all_objfiles.
8676         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8677         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8678         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8679         Uses all_objfiles.
8680         * solib.c (solib_read_symbols): Use all_objfiles
8681
8682 2019-01-09  Tom Tromey  <tom@tromey.com>
8683
8684         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8685         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8686         all_objfiles.
8687         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8688         * symmisc.c (print_symbol_bcache_statistics)
8689         (print_objfile_statistics, maintenance_print_objfiles)
8690         (maintenance_info_symtabs, maintenance_check_symtabs)
8691         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8692         all_objfiles.
8693         * source.c (forget_cached_source_info): Use all_objfiles.
8694         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8695         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8696         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8697         * objfiles.c (update_section_map): Use all_objfiles.
8698         (shared_objfile_contains_address_p): Likewise.
8699         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8700         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8701
8702 2019-01-09  Tom Tromey  <tom@tromey.com>
8703
8704         * common/next-iterator.h: New file.
8705         * objfiles.h (class all_objfiles): New.
8706         (struct objfile_iterator): New.
8707
8708 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8709
8710         * NEWS: Move the description of the changed "frame", "select-frame",
8711          and "info frame" commands to the Changed commands section.
8712
8713 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8714
8715         * gdbtypes.c (check_stub_method_group): Remove handling of old
8716         mangling schemes.
8717         * linespec.c (find_methods): Likewise.
8718         * stabsread.c (read_member_functions): Likewise.
8719         * valops.c (search_struct_method): Likewise.
8720         (value_struct_elt_for_reference): Likewise.
8721         * NEWS: Mention this change.
8722
8723 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8724
8725         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8726         print_source_lines.
8727         * source.c (print_source_lines_base): Update line number check.
8728         (print_source_lines): New function.
8729         (source_lines_range::source_lines_range): New function.
8730         * source.h (class source_lines_range): New class.
8731         (print_source_lines): New declaration.
8732
8733 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8734
8735         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8736
8737 2019-01-08  Tom Tromey  <tom@tromey.com>
8738             Simon Marchi  <simon.marchi@ericsson.com>
8739
8740         PR gdb/24060
8741         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8742         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8743         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8744         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8745         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8746         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8747
8748 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8749
8750         * source.c (select_source_symtab): Move header comment to
8751         declaration in source.h.
8752         (forget_cached_source_info_for_objfile): Likewise.
8753         (forget_cached_source_info): Likewise.
8754         (identify_source_line): Likewise.
8755         * source.h (identify_source_line): Move declaration from symtab.h
8756         and add comment from source.c
8757         (print_source_lines): Likewise.
8758         (forget_cached_source_info_for_objfile): Likewise.
8759         (forget_cached_source_info): Likewise.
8760         (select_source_symtab): Likewise.
8761         (enum print_source_lines_flag): Move definition from symtab.h.
8762         * symtab.h (identify_source_line): Move declaration to source.h.
8763         (print_source_lines): Likewise.
8764         (forget_cached_source_info_for_objfile): Likewise.
8765         (forget_cached_source_info): Likewise.
8766         (select_source_symtab): Likewise.
8767         (enum print_source_lines_flag): Move definition to source.h.
8768         * tui/tui-hooks.c: Add 'source.h' include.
8769
8770 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8771
8772         * source.c (print_source_lines_base): Handle requests to print
8773         reverse line number sequences, and guard against empty lines
8774         string.
8775
8776 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8777
8778         * source.c (print_source_lines_base): Fix skip of '\r' if next
8779         character is '\n'.
8780
8781 2019-01-06  Tom Tromey  <tom@tromey.com>
8782
8783         * c-exp.y (struct c_parse_state) <macro_original_text,
8784         expansion_obstack>: New member.
8785         (macro_original_text, expansion_obstack): Remove globals.
8786         (scan_macro_expansion, scanning_macro_expansion)
8787         (finished_macro_expansion): Update.
8788         (scan_macro_cleanup): Remove.
8789         (yylex, c_parse): Update.
8790
8791 2019-01-06  Tom Tromey  <tom@tromey.com>
8792
8793         * c-exp.y (struct c_parse_state) <strings>: New member.
8794         (operator_stoken): Update.
8795
8796 2019-01-06  Tom Tromey  <tom@tromey.com>
8797
8798         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8799         (union type_stack_elt) <typelist_val>: Now a pointer to
8800         std::vector.
8801         (type_stack_cleanup): Don't declare.
8802         (push_typelist): Update.
8803         * parse.c (pop_typelist): Return a std::vector.
8804         (push_typelist): Take a std::vector.
8805         (follow_types): Update.  Do not free args.
8806         (type_stack_cleanup): Remove.
8807         * c-exp.y (struct c_parse_state): New.
8808         (cpstate): New global.
8809         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8810         (nonempty_typelist): Update.
8811         (func_mod): Create a new vector.
8812         (c_parse): Create a c_parse_state.
8813         (check_parameter_typelist): Do not delete params.
8814         (function_method): Update.  Do not delete type_list.
8815
8816 2019-01-06  Tom Tromey  <tom@tromey.com>
8817
8818         PR gdb/28155:
8819         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8820         check_typedef.
8821         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8822         (print_return_value): Likewise.
8823
8824 2019-01-05  Tom Tromey  <tom@tromey.com>
8825
8826         * contrib/cleanup_check.py: Remove.
8827         * contrib/gcc-with-excheck: Remove.
8828         * contrib/exsummary.py: Remove.
8829         * contrib/excheck.py: Remove.
8830
8831 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8832
8833         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8834         NULL. Initialize tpprev to NULL instead of assigning it
8835         to NULL on the next statement.
8836         * windows-nat.c (windows_delete_thread): Remove check for
8837         main_thread_id before printing thread exit notifications.
8838         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8839         Remove thread ID check against main_thread_id.
8840         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8841         windows_delete_thread.
8842         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8843
8844 2019-01-04  Tom Tromey  <tom@tromey.com>
8845
8846         * compile/compile.c (_initialize_compile): Use upper case for
8847         metasyntactic variables.
8848         * symmisc.c (_initialize_symmisc): Use upper case for
8849         metasyntactic variables.
8850         * psymtab.c (_initialize_psymtab): Use upper case for
8851         metasyntactic variables.
8852         * demangle.c (demangle_command): Use upper case for metasyntactic
8853         variables.
8854         (_initialize_demangler): Likewise.
8855         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8856         variables.
8857
8858 2019-01-03  Tom Tromey  <tom@tromey.com>
8859
8860         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8861
8862 2019-01-03  Tom Tromey  <tom@tromey.com>
8863
8864         * python/py-symtab.c (salpy_str): Update.
8865         (struct salpy_sal_object) <symtab>: Now a PyObject.
8866         (salpy_dealloc): Update.
8867         (del_objfile_sal): Use gdbpy_ref.
8868
8869 2019-01-03  Tom Tromey  <tom@tromey.com>
8870
8871         * python/py-type.c (convert_field): Use new_reference.  Return
8872         gdbpy_ref.
8873         (make_fielditem): Return gdbpy_ref.
8874         (typy_fields): Update.
8875         (typy_getitem): Update.
8876         (field_name): Return gdbpy_ref.  Use new_reference.
8877         (typy_iterator_iternext): Update.
8878
8879 2019-01-03  Tom Tromey  <tom@tromey.com>
8880
8881         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8882
8883 2019-01-03  Tom Tromey  <tom@tromey.com>
8884
8885         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8886         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8887         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8888         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8889         (pspy_set_type_printers): Likewise.
8890         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8891         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8892         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8893         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8894         (objfpy_set_type_printers): Likewise.
8895
8896 2019-01-03  Tom Tromey  <tom@tromey.com>
8897
8898         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8899         (gdbpy_print_stack): Use gdbpy_err_fetch.
8900         * python/python-internal.h (class gdbpy_err_fetch): New class.
8901         (class gdbpy_enter) <m_error_type, m_error_value,
8902         m_error_traceback>: Remove.
8903         <m_error>: New member.
8904         (gdbpy_exception_to_string): Don't declare.
8905         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8906         * python/py-value.c (convert_value_from_python): Use
8907         gdbpy_err_fetch.
8908         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8909         gdbpy_exception_to_string.
8910         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8911         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8912         gdbpy_err_fetch.
8913
8914 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8915
8916         * linux-nat.c (delete_lwp_cleanup): Delete.
8917         (struct lwp_deleter): New struct.
8918         (lwp_info_up): New typedef.
8919         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8920         lwp_info_up.
8921
8922 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8923
8924         * linux-fork.c (class scoped_switch_fork_info): New class.
8925         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8926
8927 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8928
8929         * valops.c (find_overload_match): Remove use of null_cleanup, and
8930         calls to do_cleanups.
8931
8932 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8933
8934         * compile/compile-cplus-types.c
8935         (compile_cplus_instance::decl_name): Handle changes to
8936         cp_func_name.
8937         * cp-support.c (cp_func_name): Update header comment, update
8938         return type.
8939         * cp-support.h (cp_func_name): Update return type in declaration.
8940         * valops.c (find_overload_match): Move temp_func local to top
8941         level of function and change its type.  Use temp_func to hold and
8942         delete temporary string obtained from cp_func_name.
8943
8944 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8945
8946         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8947         gdb::char_vector, remove cleanup, and update uses of `msg`.
8948
8949 2019-01-03  Jim Wilson  <jimw@sifive.com>
8950
8951         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8952
8953 2019-01-02  Tom Tromey  <tom@tromey.com>
8954
8955         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8956         (tdesc_parse_xml): Remove cleanups.
8957         * target-descriptions.h (make_cleanup_free_target_description):
8958         Don't declare.
8959         (target_desc_deleter): New struct.
8960         (target_desc_up): New typedef.
8961         * target-descriptions.c (target_desc_deleter::operator()): Rename
8962         from free_target_description.
8963         (make_cleanup_free_target_description): Remove.
8964
8965 2019-01-02  Tom Tromey  <tom@tromey.com>
8966
8967         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8968         constructor, destructor.
8969         (linespec_parser): Remove typedef.
8970         (~linespec_parser): Rename from linespec_parser_delete.
8971         (linespec_lex_to_end, linespec_complete_label)
8972         (linespec_complete): Update.
8973         (decode_line_full): Remove cleanups.
8974         (decode_line_1): Update.
8975
8976 2019-01-02  Tom Tromey  <tom@tromey.com>
8977
8978         * python/python-internal.h (inferior_to_inferior_object): Change
8979         return type.
8980         * python/py-exitedevent.c (create_exited_event_object): Update.
8981         * python/py-inferior.c (inferior_to_inferior_object): Return
8982         gdbpy_ref.
8983         (python_new_inferior, python_inferior_deleted)
8984         (thread_to_thread_object, delete_thread_object)
8985         (build_inferior_list, gdbpy_selected_inferior): Update.
8986         * python/py-infthread.c (create_thread_object): Update.  Also fail
8987         if inferior_to_inferior_object fails.
8988
8989 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8990
8991         * inferior.h (class inferior) <displaced_step_state>: New field.
8992         * infrun.h (struct displaced_step_state): Move here from
8993         infrun.c.  Initialize fields, add constructor.
8994         <inf>: Remove field.
8995         <reset>: New method.
8996         * infrun.c (struct displaced_step_inferior_state): Move to
8997         infrun.h.
8998         (displaced_step_inferior_states): Remove.
8999         (get_displaced_stepping_state): Adust.
9000         (displaced_step_in_progress_any_inferior): Adjust.
9001         (displaced_step_in_progress_thread): Adjust.
9002         (displaced_step_in_progress): Adjust.
9003         (add_displaced_stepping_state): Remove.
9004         (get_displaced_step_closure_by_addr): Adjust.
9005         (remove_displaced_stepping_state): Remove.
9006         (infrun_inferior_exit): Call displaced_step_state.reset.
9007         (use_displaced_stepping): Don't check for NULL.
9008         (displaced_step_prepare_throw): Call
9009         get_displaced_stepping_state.
9010         (displaced_step_fixup): Don't check for NULL.
9011         (prepare_for_detach): Don't check for NULL.
9012
9013 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9014
9015         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
9016          in case of call that did not complete.
9017
9018 2019-01-02  Andrey Utkin  <autkin@undo.io>
9019
9020         * symfile.c (find_separate_debug_file): Fix search of debug files for
9021         remote debuggee.
9022
9023 2019-01-02  Tom Tromey  <tom@tromey.com>
9024
9025         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
9026         indentation.
9027         * python/py-frame.c (frapy_older): Remove cast.
9028         (frapy_newer): Likewise.
9029         * python/py-breakpoint.c (local_setattro): Remove cast.
9030         * python/py-arch.c (archpy_name): Remove local variable.
9031         * python/py-type.c (gdbpy_lookup_type): Remove cast.
9032
9033 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
9034
9035         * unittests/basic_string_view/element_access/char/empty.cc:
9036         Fix year range in copyright header.
9037
9038 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9039
9040         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
9041         Delete.
9042         <operator==>: Update with for removed field.
9043         <hash>: Likewise.
9044         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
9045         <isa_features>: ...this.
9046         <abi_features>: New field.
9047         (riscv_isa_flen): Update comment.
9048         (riscv_abi_xlen): New declaration.
9049         (riscv_abi_flen): New declaration.
9050         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
9051         isa_features.
9052         (riscv_abi_xlen): New function.
9053         (riscv_isa_flen): Update to get answer from isa_features.
9054         (riscv_abi_flen): New function.
9055         (riscv_has_fp_abi): Update to get answer from abi_features.
9056         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
9057         xlen and flen.
9058         (riscv_call_info) <xlen, flen>: Update comment.
9059         (riscv_call_arg_struct): Remove invalid assertions
9060         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
9061         is removed.
9062         (riscv_gdbarch_init): Gather isa features and abi features
9063         separately, ensure both match on the gdbarch when reusing an old
9064         gdbarch.  Relax an error check to allow 32-bit abi float to run on
9065         a target with 64-bit float hardware.
9066
9067 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9068
9069         * source.c (search_command_helper): Stop reverse search
9070         when line 1 has been searched.
9071
9072 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9073
9074         * record-full.c (record_full_base_target::close): Rewrite
9075         record_full_core_buf_list free logic.
9076
9077 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9078
9079         * break-catch-syscall.c (print_one_catch_syscall): xfree
9080         the last text.
9081
9082 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9083
9084         * top.c (print_gdb_version): Update Copyright year in version
9085         message.
9086
9087 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
9088
9089         Update copyright year range in all GDB files.
9090
9091 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
9092
9093         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
9094
9095 For older changes see ChangeLog-2018.
9096 \f
9097 Local Variables:
9098 mode: change-log
9099 left-margin: 8
9100 fill-column: 74
9101 version-control: never
9102 coding: utf-8
9103 End:
9104