gdb/ChangeLog

   1 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * nds32-tdep.c (nds32_dummy_id): Delete.
   4         (nds32_unwind_pc): Delete.
   5         (nds32_unwind_sp): Delete.
   6         (nds32_gdbarch_init): Don't register deleted functions with
   7         gdbarch.
   8
   9 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  10
  11         * msp430-tdep.c (msp430_unwind_pc): Delete.
  12         (msp430_unwind_sp): Delete.
  13         (msp430_dummy_id): Delete.
  14         (msp430_gdbarch_init): Don't register deleted functions with
  15         gdbarch.
  16
  17 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  18
  19         * moxie-tdep.c (moxie_unwind_sp): Delete.
  20         (moxie_unwind_pc): Delete.
  21         (moxie_dummy_id): Delete.
  22         (moxie_gdbarch_init): Don't register deleted functions with
  23         gdbarch.
  24
  25 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  26
  27         * mn10300-tdep.c (mn10300_dummy_id): Delete.
  28         (mn10300_unwind_pc): Delete.
  29         (mn10300_unwind_sp): Delete.
  30         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
  31         mn10300_unwind_sp.
  32         (mn10300_frame_unwind_init): Don't register deleted functions with
  33         gdbarch.
  34
  35 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  36
  37         * mep-tdep.c (mep_unwind_pc): Delete.
  38         (mep_unwind_sp): Delete.
  39         (mep_dummy_id): Delete.
  40         (mep_gdbarch_init): Don't register deleted functions with
  41         gdbarch.
  42
  43 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  44
  45         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
  46         (m68hc11_unwind_sp): Delete.
  47         (m68hc11_gdbarch_init): Don't register deleted functions with
  48         gdbarch.
  49
  50 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  51
  52         * m32r-tdep.c (m32r_unwind_sp): Delete.
  53         (m32r_unwind_pc): Delete.
  54         (m32r_dummy_id): Delete.
  55         (m32r_gdbarch_init): Don't register deleted functions with
  56         gdbarch.
  57
  58 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  59
  60         * m32c-tdep.c (m32c_unwind_pc): Delete.
  61         (m32c_unwind_sp): Delete.
  62         (m32c_dummy_id): Delete.
  63         (m32c_gdbarch_init): Don't register deleted functions with
  64         gdbarch.
  65
  66 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  67
  68         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
  69         (lm32_unwind_pc): Delete.
  70         (lm32_dummy_id): Delete.
  71         (lm32_gdbarch_init): Don't register deleted functions with
  72         gdbarch.
  73
  74 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  75
  76         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
  77         (iq2000_unwind_pc): Delete.
  78         (iq2000_dummy_id): Delete.
  79         (iq2000_gdbarch_init): Don't register deleted functions with
  80         gdbarch.
  81
  82 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  83
  84         * nds32-tdep.c (nds32_type_align): Delete.
  85         (nds32_push_dummy_call): Use type_align instead.
  86
  87 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * arm-tdep.c (arm_type_align): Only handle vector override case.
  90         (arm_push_dummy_call): Use type_align.
  91         (arm_gdbarch_init): Register arm_type_align gdbarch function.
  92
  93 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
  94
  95         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
  96         case.
  97         (pass_on_stack): Use type_align.
  98         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
  99         function.
 100
 101 2019-04-23  Tom Tromey  <tromey@adacore.com>
 102
 103         * dwarf2read.c (line_header::file_name_at): Remove unused
 104         overload.
 105
 106 2019-04-23  Tom de Vries  <tdevries@suse.de>
 107
 108         PR gdb/24438
 109         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
 110         invocation.
 111
 112
 113 2019-03-27  Ali Tamur  <tamur@google.com>
 114
 115         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
 116         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
 117         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
 118         (dwarf_expr_context::get_addr_index): Likewise
 119         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
 120         (symbol_needs_eval_context::get_addr_index): Likewise
 121         (disassemble_dwarf_expression): Add DW_OP_addrx
 122         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
 123         (read_cutu_die_from_dwo): Update comment
 124         (skip_one_die): Add DW_FORM_addrx
 125         (read_attribute_value): Likewise
 126         (var_decode_location): Add DW_OP_addrx
 127         (dwarf2_const_value_attr): Add DW_FORM_addrx
 128         (dump_die_shallow): Likewise
 129         (dwarf2_fetch_constant_bytes): Likewise
 130         (decode_locdesc): Add DW_OP_addrx
 131         (skip_form_bytes): Add DW_FORM_addrx
 132
 133 2019-04-22  Ali Tamur  <tamur@google.com>
 134
 135         * MAINTAINERS (Write After Approval): Add self.
 136
 137 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
 138
 139         * solib-svr4.c (get_svr4_info): Add pspace parameter.
 140         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
 141         (open_symbol_file_object): Likewise.
 142         (svr4_default_sos): Add info parameter.
 143         (svr4_read_so_list): Likewise.
 144         (svr4_current_sos_direct): Adjust functions calls to pass down
 145         info.
 146         (svr4_current_sos_1): Add info parameter.
 147         (svr4_current_sos): Call get_svr4_info, pass info down to
 148         svr4_current_sos_1.
 149         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
 150         get_svr4_info.
 151         (svr4_in_dynsym_resolve_code): Pass current_program_space to
 152         get_svr4_info.
 153         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
 154         to get_svr4_info.
 155         (probes_table_remove_objfile_probes): Likewise.
 156         (register_solib_event_probe): Add info parameter.
 157         (solist_update_incremental): Pass info parameter down to
 158         svr4_read_so_list.
 159         (disable_probes_interface): Add info parameter.
 160         (svr4_handle_solib_event): Pass current_program_space to
 161         get_svr4_info.  Adjust disable_probes_interface cleanup.
 162         (svr4_create_probe_breakpoints): Add info parameter, pass it
 163         down to register_solib_event_probe.
 164         (svr4_create_solib_event_breakpoints): Add info parameter,
 165         pass it down to svr4_create_probe_breakpoints.
 166         (enable_break): Pass info down to
 167         svr4_create_solib_event_breakpoints.
 168         (svr4_solib_create_inferior_hook): Pass current_program_space to
 169         get_svr4_info.
 170         (svr4_clear_solib): Likewise.
 171
 172 2019-04-22  Pedro Alves  <palves@redhat.com>
 173
 174         * solib-svr4.c (svr4_free_objfile_observer): New.
 175         (probe_and_action::objfile): New field.
 176         (probes_table_htab_remove_objfile_probes)
 177         (probes_table_remove_objfile_probes): New functions.
 178         (register_solib_event_probe): Add 'objfile' parameter.  Store it
 179         in the new probe_and_action.  Don't store the probe in 'lookup'.
 180         (svr4_create_probe_breakpoints): Pass objfile to
 181         register_solib_event_probe.
 182         (_initialize_svr4_solib): Register a free_objfile observer.
 183
 184 2019-04-19  Tom Tromey  <tom@tromey.com>
 185
 186         * common/queue.h: Remove.
 187
 188 2019-04-19  Tom Tromey  <tom@tromey.com>
 189
 190         * event-loop.c: Don't include "common/queue.h".
 191
 192 2019-04-19  Tom Tromey  <tom@tromey.com>
 193
 194         * remote.c (remote_target): Use delete.
 195         * remote-notif.h: Include <list>, not "common/queue.h".
 196         (notif_client_p): Remove typedef.
 197         (remote_notif_state): Add constructor, destructor, initializer.
 198         <notif_queue>: Now a std::list.
 199         (remote_notif_state_xfree): Don't declare.
 200         * remote-notif.c (remote_notif_process, handle_notification)
 201         (remote_notif_state_allocate): Update.
 202         (~remote_notif_state): Rename from remote_notif_state_xfree.
 203
 204 2019-04-19  Tom Tromey  <tom@tromey.com>
 205
 206         * symfile.c (reread_symbols): Update.
 207         * objfiles.c (objfile_register_static_link)
 208         (objfile_lookup_static_link): Update
 209         (~objfile) Don't delete static_links.
 210         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
 211
 212 2019-04-19  Tom Tromey  <tom@tromey.com>
 213
 214         * type-stack.h (struct type_stack) <insert>: Constify string.
 215         * type-stack.c (type_stack::insert): Constify string.
 216         * gdbtypes.h (lookup_template_type): Update.
 217         (address_space_name_to_int): Update.
 218         * gdbtypes.c (address_space_name_to_int): Make space_identifier
 219         const.
 220         (lookup_template_type): Make name const.
 221         * c-exp.y: Update rules.
 222         (lex_one_token, classify_name, classify_inner_name)
 223         (c_print_token): Update.
 224         * p-exp.y: Update rules.
 225         (yylex): Update.
 226         * f-exp.y: Update rules.
 227         (yylex): Update.
 228         * d-exp.y: Update rules.
 229         (lex_one_token, classify_name, classify_inner_name): Update.
 230         * parse.c (write_dollar_variable, copy_name): Return std::string.
 231         * parser-defs.h (copy_name): Change return type.
 232         * m2-exp.y: Update rules.
 233         (yylex): Update.
 234         * go-exp.y (lex_one_token): Update.
 235         Update rules.
 236         (classify_unsafe_function, classify_packaged_name)
 237         (classify_name, yylex): Update.
 238
 239 2019-04-19  Sergei Trofimovich <siarheit@google.com>
 240
 241         * configure.ac: add --enable-source-highlight switch.
 242         * configure: Regenerate.
 243         * top.c (print_gdb_version): plumb --enable-source-highlight
 244         status to "show configuration".
 245
 246 2019-04-19  Tom Tromey  <tromey@adacore.com>
 247
 248         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
 249         Check ADA_TYPE_P.
 250         (empty_record, ada_template_to_fixed_record_type_1)
 251         (template_to_static_fixed_type)
 252         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
 253         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
 254         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
 255         macros.
 256
 257 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
 258
 259         PR symtab/24423:
 260         * source.c (print_source_lines_base): Advance "iter" when a
 261         control character is seen.
 262
 263 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 264
 265         * inferior.h (struct infcall_suspend_state_deleter):
 266         Catch exception in destructor to avoid crash.
 267
 268 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 269
 270         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
 271         close to the add_com "shell".
 272
 273 2019-04-18  Tom Tromey  <tromey@adacore.com>
 274
 275         * process-stratum-target.h (class process_stratum_target)
 276         <stratum>: Add "final".
 277
 278 2019-04-17  Tom Tromey  <tromey@adacore.com>
 279
 280         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
 281         against nullptr before use.
 282
 283 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
 284
 285         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
 286
 287 2019-04-17  Jim Wilson  <jimw@sifive.com>
 288             Andrew Burgess  <andrew.burgess@embecosm.com>
 289
 290         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
 291         code read might fail, assume 4-byte breakpoint in that case.
 292
 293 2019-04-15  Leszek Swirski  <leszeks@google.com>
 294
 295         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
 296         rather than a hand-rolled POD check when checking for forced MEMORY
 297         classification.
 298
 299 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 300
 301         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
 302         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
 303         function.
 304         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
 305         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
 306         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
 307         declaration.
 308
 309 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 310
 311         * aarch64-linux-nat.c
 312         (aarch64_linux_nat_target::thread_architecture): Add override.
 313         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
 314         each VQ.
 315
 316 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
 317
 318         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
 319
 320 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
 321
 322         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
 323         target types of size 96-bits, add some additional comments, and
 324         check that the builtin type we found was the correct size.
 325
 326 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
 327
 328         * utils.c (prompt_for_continue): Don't restore the styling at the
 329         end, as applied_style has the wrong value.  This fixes styling in
 330         long lists of file names that are interrupted by the "Continue?"
 331         prompt.
 332
 333 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
 334
 335         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
 336         * c-lang.c (c_language_defn): Likewise.
 337         (cplus_language_defn): Likewise.
 338         (asm_language_defn): Likewise.
 339         (minimal_language_defn): Likewise.
 340         * d-lang.c (d_language_defn): Likewise.
 341         * f-lang.c (f_language_defn): Likewise.
 342         * go-lang.c (go_language_defn): Likewise.
 343         * language.c (unknown_language_defn): Likewise.
 344         (auto_language_defn): Likewise.
 345         * language.h (struct language_defn): Remove la_magic field.
 346         (LANG_MAGIC): Delete.
 347         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
 348         * objc-lang.c (objc_language_defn): Likewise.
 349         * opencl-lang.c (opencl_language_defn): Likewise.
 350         * p-lang.c (pascal_language_defn): Likewise.
 351         * rust-lang.c (rust_language_defn): Likewise.
 352
 353 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 354
 355         * riscv-tdep.c (riscv_type_align): New function.
 356         (riscv_type_alignment): Delete.
 357         (riscv_arg_location): Use 'type_align'.
 358         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
 359
 360 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 361
 362         * gdbtypes.c (type_align): A struct with no non-static fields also
 363         has alignment of 1.
 364
 365 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
 366
 367         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
 368         component to 0.
 369         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
 370         member.
 371         (riscv_struct_info::analyse): New implementation using new
 372         analyse_inner member function.
 373         (riscv_struct_info::field_offset): New member function.
 374         (riscv_struct_info::m_offsets): New member variable.
 375         (riscv_struct_info::analyse_inner): New private member function,
 376         takes the old implementation of riscv_struct_info::analyse but
 377         extended to track field offsets.
 378         (riscv_call_arg_struct): Update the struct folding special cases
 379         to handle cases where empty C++ structs, which are non-zero
 380         length, are found.
 381         (riscv_arg_location): Initialise the length of each location, a
 382         non-zero length now indicates the location is in use.
 383         (riscv_push_dummy_call): Allow for the first location having a
 384         non-zero offset when setting up arguments.
 385         (riscv_return_value): Likewise, but for return values.
 386
 387 2019-04-11  Tom Tromey  <tromey@adacore.com>
 388
 389         * utils.c (internal_vproblem): Make "msg" const.
 390
 391 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
 392
 393         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
 394         * trad-frame.c (trad_frame_reset_saved_regs): New function.
 395         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
 396         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
 397
 398 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
 399
 400         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
 401         function.
 402         (fill_gregset): Call amd64_linux_collect_native_gregset instead
 403         of amd64_collect_native_gregset.
 404         (amd64_linux_nat_target::store_registers): Likewise.
 405
 406 2019-04-10  Tom Tromey  <tom@tromey.com>
 407
 408         * symtab.c (lookup_global_symbol_from_objfile)
 409         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
 410         * objfiles.h (class separate_debug_iterator): New.
 411         (class separate_debug_range): New.
 412         (struct objfile) <separate_debug_objfiles>: New method.
 413         (objfile_separate_debug_iterate): Don't declare.
 414         * objfiles.c (separate_debug_iterator::operator++): Rename from
 415         objfile_separate_debug_iterate.
 416         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
 417         iterator.
 418         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
 419         iterator.
 420
 421 2019-04-10  Tom Tromey  <tom@tromey.com>
 422
 423         * symfile.c (reread_symbols): Remove old comment.
 424         * objfiles.c (free_all_objfiles): Fix a typo.
 425
 426 2019-04-10  Tom Tromey  <tom@tromey.com>
 427
 428         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
 429         * minsyms.c (lookup_minimal_symbol): Use foreach.
 430         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
 431         (lookup_minimal_symbol_solib_trampoline): Likewise.
 432         * symfile.c (reread_symbols): Use foreach.
 433
 434 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
 435             Tom Tromey  <tromey@adacore.com>
 436
 437         PR rust/24414:
 438         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
 439         (rust_lex_int_test): Change "value" to be LONGEST.
 440         (rust_lex_tests): Add test for long integer literal.
 441
 442 2019-04-09  Tom Tromey  <tromey@adacore.com>
 443
 444         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
 445         to bool.
 446         (extended_remote_target::attach): Update.
 447         (remote_target::remote_notice_new_inferior): Update.
 448         (remote_target::add_current_inferior_and_thread): Update.
 449         * inferior.c (exit_inferior_1): Use "false".
 450         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
 451
 452 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
 453
 454         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
 455         the "start" command.
 456
 457 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 458
 459         * python/py-inferior.c (infpy_thread_from_thread_handle):
 460         Adjust comments to reflect renaming of thread_from_thread_handle
 461         to thread_from_handle.  Adjust keywords.  Fix type error message.
 462         (inferior_object_methods): Add thread_from_handle.  Retain
 463         thread_from_thread_handle, but mark it as deprecated.
 464
 465 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 466
 467         * gdbthread.h (find_thread_by_handle): Revise declaration.
 468         * thread.c (find_thread_by_handle): Likewise.  Adjust
 469         implementation too.
 470         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
 471         support for buffer objects as handles.
 472
 473 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 474
 475         * python/py-infthread.c (thpy_thread_handle): New function.
 476         (thread_object_methods): Register thpy_thread_handle.
 477
 478 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
 479
 480         * gdbthread.h (thread_to_thread_handle): Declare.
 481         * thread.c (gdbtypes.h): Include.
 482         (thread_to_thread_handle): New function.
 483
 484         * target.h (struct target_ops): Add thread_info_to_thread_handle.
 485         (target_thread_info_to_thread_handle): Declare.
 486         * target.c (target_thread_info_to_thread_handle): New function.
 487         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
 488         * target-delegates.c: Regenerate.
 489
 490         * linux-thread-db.c (class thread_db_target): Add method
 491         thread_info_to_thread_handle.
 492         (thread_db_target::thread_info_to_thread_handle): Define.
 493         * remote.c (class remote_target): Add new method
 494         thread_info_to_thread_handle.
 495         (remote_target::thread_info_to_thread_handle): Define.
 496
 497 2019-04-08  Pedro Alves  <palves@redhat.com>
 498
 499         * common/common-exceptions.c (throw_exception): Don't create
 500         named object to throw; throw directly.
 501         (throw_it): Likewise.  Don't initialize gdb_exception::message
 502         here, with new; pass FMT and AP to the ctor instead.
 503         * common/common-exceptions.h: Include <string>.
 504         (gdb_exception::gdb_exception(enum return_reason, enum errors,
 505         const char *, va_list)): New ctor.  Use std::make_shared.
 506         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
 507         errors)): Delete.
 508         (gdb_exception_error::gdb_exception_error(enum errors, const char
 509         *, va_list)): New.
 510         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
 511         Add assertion.
 512         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
 513         errors)): Delete.
 514         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
 515         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
 516         Add assertion.
 517
 518 2019-04-08  Tom Tromey  <tom@tromey.com>
 519
 520         * valops.c (value_rtti_indirect_type): Replace throw_exception
 521         with throw.
 522         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
 523         with throw.
 524         * thread.c (thr_try_catch_cmd): Replace throw_exception with
 525         throw.
 526         * target.c (target_translate_tls_address): Replace throw_exception
 527         with throw.
 528         * stack.c (frame_apply_command_count): Replace throw_exception
 529         with throw.
 530         * solib-spu.c (append_ocl_sos): Replace throw_exception with
 531         throw.
 532         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
 533         with throw.
 534         * rs6000-tdep.c (rs6000_frame_cache)
 535         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
 536         * remote.c: Replace throw_exception with throw.
 537         * record-full.c (record_full_message, record_full_wait_1)
 538         (record_full_restore): Replace throw_exception with throw.
 539         * record-btrace.c:
 540         (get_thread_current_frame_id, record_btrace_start_replaying)
 541         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
 542         (cmd_record_btrace_start): Replace throw_exception with throw.
 543         * parse.c (parse_exp_in_context_1): Replace throw_exception with
 544         throw.
 545         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
 546         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
 547         * linespec.c:
 548         (find_linespec_symbols): Replace throw_exception with throw.
 549         * infrun.c (displaced_step_prepare, resume): Replace
 550         throw_exception with throw.
 551         * infcmd.c (post_create_inferior): Replace throw_exception with
 552         throw.
 553         * inf-loop.c (inferior_event_handler): Replace throw_exception
 554         with throw.
 555         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
 556         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
 557         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
 558         (get_prev_frame_always, get_frame_pc_if_available)
 559         (get_frame_address_in_block_if_available, get_frame_language):
 560         Replace throw_exception with throw.
 561         * frame-unwind.c (frame_unwind_try_unwinder): Replace
 562         throw_exception with throw.
 563         * eval.c (fetch_subexp_value, evaluate_var_value)
 564         (evaluate_funcall, evaluate_subexp_standard): Replace
 565         throw_exception with throw.
 566         * dwarf2loc.c (call_site_find_chain)
 567         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
 568         Replace throw_exception with throw.
 569         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
 570         with throw.
 571         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
 572         throw.
 573         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
 574         * completer.c (complete_line_internal): Replace throw_exception
 575         with throw.
 576         * compile/compile-object-run.c (compile_object_run): Replace
 577         throw_exception with throw.
 578         * cli/cli-script.c (process_next_line): Replace throw_exception
 579         with throw.
 580         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
 581         (btrace_enable, btrace_maint_update_pt_packets): Replace
 582         throw_exception with throw.
 583         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
 584         throw_exception with throw.
 585         * break-catch-throw.c (re_set_exception_catchpoint): Replace
 586         throw_exception with throw.
 587         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
 588         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
 589         * aarch64-tdep.c (aarch64_make_prologue_cache)
 590         (aarch64_make_stub_cache): Replace throw_exception with throw.
 591
 592 2019-04-08  Tom Tromey  <tom@tromey.com>
 593
 594         * common/common-exceptions.c (throw_exception): Rename from
 595         throw_exception_cxx.  Remove old copy.  Make argument const.
 596         (throw_it): Create and throw exception objects directly.
 597         * common/common-exceptions.h (throw_exception): Make argument
 598         const.
 599         (struct gdb_exception_error): Add constructor.
 600         (struct gdb_exception_quit): Add constructor.
 601
 602 2019-04-08  Tom Tromey  <tom@tromey.com>
 603
 604         * common/common-exceptions.h (exception_rethrow): Don't declare.
 605         (TRY_SJLJ): Update comment.
 606         (TRY, CATCH, END_CATCH): Remove.
 607         * common/common-exceptions.c (exception_rethrow): Remove.
 608
 609 2019-04-08  Tom Tromey  <tom@tromey.com>
 610
 611         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
 612         Remove.
 613         (gdb_exception_error): Rename from
 614         gdb_exception_RETURN_MASK_ERROR.
 615         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
 616         (gdb_quit_bad_alloc): Update.
 617         * aarch64-tdep.c: Update.
 618         * ada-lang.c: Update.
 619         * ada-typeprint.c: Update.
 620         * ada-valprint.c: Update.
 621         * amd64-tdep.c: Update.
 622         * arch-utils.c: Update.
 623         * break-catch-throw.c: Update.
 624         * breakpoint.c: Update.
 625         * btrace.c: Update.
 626         * c-varobj.c: Update.
 627         * cli/cli-cmds.c: Update.
 628         * cli/cli-interp.c: Update.
 629         * cli/cli-script.c: Update.
 630         * common/common-exceptions.c: Update.
 631         * common/new-op.c: Update.
 632         * common/selftest.c: Update.
 633         * compile/compile-c-symbols.c: Update.
 634         * compile/compile-cplus-symbols.c: Update.
 635         * compile/compile-object-load.c: Update.
 636         * compile/compile-object-run.c: Update.
 637         * completer.c: Update.
 638         * corelow.c: Update.
 639         * cp-abi.c: Update.
 640         * cp-support.c: Update.
 641         * cp-valprint.c: Update.
 642         * darwin-nat.c: Update.
 643         * disasm-selftests.c: Update.
 644         * dtrace-probe.c: Update.
 645         * dwarf-index-cache.c: Update.
 646         * dwarf-index-write.c: Update.
 647         * dwarf2-frame-tailcall.c: Update.
 648         * dwarf2-frame.c: Update.
 649         * dwarf2loc.c: Update.
 650         * dwarf2read.c: Update.
 651         * eval.c: Update.
 652         * event-loop.c: Update.
 653         * event-top.c: Update.
 654         * exec.c: Update.
 655         * f-valprint.c: Update.
 656         * fbsd-tdep.c: Update.
 657         * frame-unwind.c: Update.
 658         * frame.c: Update.
 659         * gdbtypes.c: Update.
 660         * gnu-v3-abi.c: Update.
 661         * guile/guile-internal.h: Update.
 662         * guile/scm-block.c: Update.
 663         * guile/scm-breakpoint.c: Update.
 664         * guile/scm-cmd.c: Update.
 665         * guile/scm-disasm.c: Update.
 666         * guile/scm-frame.c: Update.
 667         * guile/scm-lazy-string.c: Update.
 668         * guile/scm-math.c: Update.
 669         * guile/scm-param.c: Update.
 670         * guile/scm-ports.c: Update.
 671         * guile/scm-pretty-print.c: Update.
 672         * guile/scm-symbol.c: Update.
 673         * guile/scm-symtab.c: Update.
 674         * guile/scm-type.c: Update.
 675         * guile/scm-value.c: Update.
 676         * i386-linux-tdep.c: Update.
 677         * i386-tdep.c: Update.
 678         * inf-loop.c: Update.
 679         * infcall.c: Update.
 680         * infcmd.c: Update.
 681         * infrun.c: Update.
 682         * jit.c: Update.
 683         * language.c: Update.
 684         * linespec.c: Update.
 685         * linux-fork.c: Update.
 686         * linux-nat.c: Update.
 687         * linux-tdep.c: Update.
 688         * linux-thread-db.c: Update.
 689         * main.c: Update.
 690         * mi/mi-cmd-break.c: Update.
 691         * mi/mi-cmd-stack.c: Update.
 692         * mi/mi-interp.c: Update.
 693         * mi/mi-main.c: Update.
 694         * objc-lang.c: Update.
 695         * p-valprint.c: Update.
 696         * parse.c: Update.
 697         * ppc-linux-tdep.c: Update.
 698         * printcmd.c: Update.
 699         * python/py-arch.c: Update.
 700         * python/py-breakpoint.c: Update.
 701         * python/py-cmd.c: Update.
 702         * python/py-finishbreakpoint.c: Update.
 703         * python/py-frame.c: Update.
 704         * python/py-framefilter.c: Update.
 705         * python/py-gdb-readline.c: Update.
 706         * python/py-inferior.c: Update.
 707         * python/py-infthread.c: Update.
 708         * python/py-lazy-string.c: Update.
 709         * python/py-linetable.c: Update.
 710         * python/py-objfile.c: Update.
 711         * python/py-param.c: Update.
 712         * python/py-prettyprint.c: Update.
 713         * python/py-progspace.c: Update.
 714         * python/py-record-btrace.c: Update.
 715         * python/py-record.c: Update.
 716         * python/py-symbol.c: Update.
 717         * python/py-type.c: Update.
 718         * python/py-unwind.c: Update.
 719         * python/py-utils.c: Update.
 720         * python/py-value.c: Update.
 721         * python/python.c: Update.
 722         * record-btrace.c: Update.
 723         * record-full.c: Update.
 724         * remote-fileio.c: Update.
 725         * remote.c: Update.
 726         * riscv-tdep.c: Update.
 727         * rs6000-aix-tdep.c: Update.
 728         * rs6000-tdep.c: Update.
 729         * rust-exp.y: Update.
 730         * rust-lang.c: Update.
 731         * s390-tdep.c: Update.
 732         * selftest-arch.c: Update.
 733         * solib-dsbt.c: Update.
 734         * solib-frv.c: Update.
 735         * solib-spu.c: Update.
 736         * solib-svr4.c: Update.
 737         * solib.c: Update.
 738         * sparc64-linux-tdep.c: Update.
 739         * stack.c: Update.
 740         * symfile-mem.c: Update.
 741         * symmisc.c: Update.
 742         * target.c: Update.
 743         * thread.c: Update.
 744         * top.c: Update.
 745         * tracefile-tfile.c: Update.
 746         * tui/tui.c: Update.
 747         * typeprint.c: Update.
 748         * unittests/cli-utils-selftests.c: Update.
 749         * unittests/parse-connection-spec-selftests.c: Update.
 750         * valops.c: Update.
 751         * valprint.c: Update.
 752         * value.c: Update.
 753         * varobj.c: Update.
 754         * windows-nat.c: Update.
 755         * x86-linux-nat.c: Update.
 756         * xml-support.c: Update.
 757
 758 2019-04-08  Tom Tromey  <tom@tromey.com>
 759
 760         * xml-support.c: Use C++ exception handling.
 761         * x86-linux-nat.c: Use C++ exception handling.
 762         * windows-nat.c: Use C++ exception handling.
 763         * varobj.c: Use C++ exception handling.
 764         * value.c: Use C++ exception handling.
 765         * valprint.c: Use C++ exception handling.
 766         * valops.c: Use C++ exception handling.
 767         * unittests/parse-connection-spec-selftests.c: Use C++ exception
 768         handling.
 769         * unittests/cli-utils-selftests.c: Use C++ exception handling.
 770         * typeprint.c: Use C++ exception handling.
 771         * tui/tui.c: Use C++ exception handling.
 772         * tracefile-tfile.c: Use C++ exception handling.
 773         * top.c: Use C++ exception handling.
 774         * thread.c: Use C++ exception handling.
 775         * target.c: Use C++ exception handling.
 776         * symmisc.c: Use C++ exception handling.
 777         * symfile-mem.c: Use C++ exception handling.
 778         * stack.c: Use C++ exception handling.
 779         * sparc64-linux-tdep.c: Use C++ exception handling.
 780         * solib.c: Use C++ exception handling.
 781         * solib-svr4.c: Use C++ exception handling.
 782         * solib-spu.c: Use C++ exception handling.
 783         * solib-frv.c: Use C++ exception handling.
 784         * solib-dsbt.c: Use C++ exception handling.
 785         * selftest-arch.c: Use C++ exception handling.
 786         * s390-tdep.c: Use C++ exception handling.
 787         * rust-lang.c: Use C++ exception handling.
 788         * rust-exp.y: Use C++ exception handling.
 789         * rs6000-tdep.c: Use C++ exception handling.
 790         * rs6000-aix-tdep.c: Use C++ exception handling.
 791         * riscv-tdep.c: Use C++ exception handling.
 792         * remote.c: Use C++ exception handling.
 793         * remote-fileio.c: Use C++ exception handling.
 794         * record-full.c: Use C++ exception handling.
 795         * record-btrace.c: Use C++ exception handling.
 796         * python/python.c: Use C++ exception handling.
 797         * python/py-value.c: Use C++ exception handling.
 798         * python/py-utils.c: Use C++ exception handling.
 799         * python/py-unwind.c: Use C++ exception handling.
 800         * python/py-type.c: Use C++ exception handling.
 801         * python/py-symbol.c: Use C++ exception handling.
 802         * python/py-record.c: Use C++ exception handling.
 803         * python/py-record-btrace.c: Use C++ exception handling.
 804         * python/py-progspace.c: Use C++ exception handling.
 805         * python/py-prettyprint.c: Use C++ exception handling.
 806         * python/py-param.c: Use C++ exception handling.
 807         * python/py-objfile.c: Use C++ exception handling.
 808         * python/py-linetable.c: Use C++ exception handling.
 809         * python/py-lazy-string.c: Use C++ exception handling.
 810         * python/py-infthread.c: Use C++ exception handling.
 811         * python/py-inferior.c: Use C++ exception handling.
 812         * python/py-gdb-readline.c: Use C++ exception handling.
 813         * python/py-framefilter.c: Use C++ exception handling.
 814         * python/py-frame.c: Use C++ exception handling.
 815         * python/py-finishbreakpoint.c: Use C++ exception handling.
 816         * python/py-cmd.c: Use C++ exception handling.
 817         * python/py-breakpoint.c: Use C++ exception handling.
 818         * python/py-arch.c: Use C++ exception handling.
 819         * printcmd.c: Use C++ exception handling.
 820         * ppc-linux-tdep.c: Use C++ exception handling.
 821         * parse.c: Use C++ exception handling.
 822         * p-valprint.c: Use C++ exception handling.
 823         * objc-lang.c: Use C++ exception handling.
 824         * mi/mi-main.c: Use C++ exception handling.
 825         * mi/mi-interp.c: Use C++ exception handling.
 826         * mi/mi-cmd-stack.c: Use C++ exception handling.
 827         * mi/mi-cmd-break.c: Use C++ exception handling.
 828         * main.c: Use C++ exception handling.
 829         * linux-thread-db.c: Use C++ exception handling.
 830         * linux-tdep.c: Use C++ exception handling.
 831         * linux-nat.c: Use C++ exception handling.
 832         * linux-fork.c: Use C++ exception handling.
 833         * linespec.c: Use C++ exception handling.
 834         * language.c: Use C++ exception handling.
 835         * jit.c: Use C++ exception handling.
 836         * infrun.c: Use C++ exception handling.
 837         * infcmd.c: Use C++ exception handling.
 838         * infcall.c: Use C++ exception handling.
 839         * inf-loop.c: Use C++ exception handling.
 840         * i386-tdep.c: Use C++ exception handling.
 841         * i386-linux-tdep.c: Use C++ exception handling.
 842         * guile/scm-value.c: Use C++ exception handling.
 843         * guile/scm-type.c: Use C++ exception handling.
 844         * guile/scm-symtab.c: Use C++ exception handling.
 845         * guile/scm-symbol.c: Use C++ exception handling.
 846         * guile/scm-pretty-print.c: Use C++ exception handling.
 847         * guile/scm-ports.c: Use C++ exception handling.
 848         * guile/scm-param.c: Use C++ exception handling.
 849         * guile/scm-math.c: Use C++ exception handling.
 850         * guile/scm-lazy-string.c: Use C++ exception handling.
 851         * guile/scm-frame.c: Use C++ exception handling.
 852         * guile/scm-disasm.c: Use C++ exception handling.
 853         * guile/scm-cmd.c: Use C++ exception handling.
 854         * guile/scm-breakpoint.c: Use C++ exception handling.
 855         * guile/scm-block.c: Use C++ exception handling.
 856         * guile/guile-internal.h: Use C++ exception handling.
 857         * gnu-v3-abi.c: Use C++ exception handling.
 858         * gdbtypes.c: Use C++ exception handling.
 859         * frame.c: Use C++ exception handling.
 860         * frame-unwind.c: Use C++ exception handling.
 861         * fbsd-tdep.c: Use C++ exception handling.
 862         * f-valprint.c: Use C++ exception handling.
 863         * exec.c: Use C++ exception handling.
 864         * event-top.c: Use C++ exception handling.
 865         * event-loop.c: Use C++ exception handling.
 866         * eval.c: Use C++ exception handling.
 867         * dwarf2read.c: Use C++ exception handling.
 868         * dwarf2loc.c: Use C++ exception handling.
 869         * dwarf2-frame.c: Use C++ exception handling.
 870         * dwarf2-frame-tailcall.c: Use C++ exception handling.
 871         * dwarf-index-write.c: Use C++ exception handling.
 872         * dwarf-index-cache.c: Use C++ exception handling.
 873         * dtrace-probe.c: Use C++ exception handling.
 874         * disasm-selftests.c: Use C++ exception handling.
 875         * darwin-nat.c: Use C++ exception handling.
 876         * cp-valprint.c: Use C++ exception handling.
 877         * cp-support.c: Use C++ exception handling.
 878         * cp-abi.c: Use C++ exception handling.
 879         * corelow.c: Use C++ exception handling.
 880         * completer.c: Use C++ exception handling.
 881         * compile/compile-object-run.c: Use C++ exception handling.
 882         * compile/compile-object-load.c: Use C++ exception handling.
 883         * compile/compile-cplus-symbols.c: Use C++ exception handling.
 884         * compile/compile-c-symbols.c: Use C++ exception handling.
 885         * common/selftest.c: Use C++ exception handling.
 886         * common/new-op.c: Use C++ exception handling.
 887         * cli/cli-script.c: Use C++ exception handling.
 888         * cli/cli-interp.c: Use C++ exception handling.
 889         * cli/cli-cmds.c: Use C++ exception handling.
 890         * c-varobj.c: Use C++ exception handling.
 891         * btrace.c: Use C++ exception handling.
 892         * breakpoint.c: Use C++ exception handling.
 893         * break-catch-throw.c: Use C++ exception handling.
 894         * arch-utils.c: Use C++ exception handling.
 895         * amd64-tdep.c: Use C++ exception handling.
 896         * ada-valprint.c: Use C++ exception handling.
 897         * ada-typeprint.c: Use C++ exception handling.
 898         * ada-lang.c: Use C++ exception handling.
 899         * aarch64-tdep.c: Use C++ exception handling.
 900
 901 2019-04-08  Tom Tromey  <tom@tromey.com>
 902
 903         * xml-support.c (gdb_xml_parser::parse): Update.
 904         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
 905         * value.c (show_convenience): Update.
 906         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
 907         (test_parse_flags_qcs): Update.
 908         * thread.c (thr_try_catch_cmd): Update.
 909         * target.c (target_translate_tls_address): Update.
 910         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
 911         (info_frame_command_core, frame_apply_command_count): Update.
 912         * rust-exp.y (rust_lex_exception_test): Update.
 913         * riscv-tdep.c (riscv_print_one_register_info): Update.
 914         * remote.c (remote_target::enable_btrace): Update.
 915         * record-btrace.c (record_btrace_enable_warn): Update.
 916         * python/py-utils.c (gdbpy_convert_exception): Update.
 917         * printcmd.c (do_one_display, print_variable_and_value): Update.
 918         * mi/mi-main.c (mi_print_exception): Update.
 919         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
 920         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 921         * linux-nat.c (linux_nat_target::attach): Update.
 922         * linux-fork.c (class scoped_switch_fork_info): Update.
 923         * infrun.c (displaced_step_prepare): Update.
 924         * infcall.c (call_function_by_hand_dummy): Update.
 925         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
 926         * gnu-v3-abi.c (print_one_vtable): Update.
 927         * frame.c (get_prev_frame_always): Update.
 928         * f-valprint.c (info_common_command_for_block): Update.
 929         * exec.c (try_open_exec_file): Update.
 930         * exceptions.c (print_exception, exception_print)
 931         (exception_fprintf, exception_print_same): Update.
 932         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
 933         * dwarf-index-cache.c (index_cache::store)
 934         (index_cache::lookup_gdb_index): Update.
 935         * darwin-nat.c (maybe_cache_shell): Update.
 936         * cp-valprint.c (cp_print_value_fields): Update.
 937         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
 938         (gcc_cplus_symbol_address): Update.
 939         * compile/compile-c-symbols.c (gcc_convert_symbol)
 940         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
 941         * common/selftest.c: Update.
 942         * common/common-exceptions.h (struct gdb_exception) <message>: Now
 943         a std::string.
 944         (exception_try_scope_entry, exception_try_scope_exit): Don't
 945         declare.
 946         (struct exception_try_scope): Remove.
 947         (TRY): Don't use exception_try_scope.
 948         (struct gdb_exception): Add constructor, operator=.
 949         <what>: New method.
 950         (struct gdb_exception_RETURN_MASK_ALL)
 951         (struct gdb_exception_RETURN_MASK_ERROR)
 952         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
 953         (struct gdb_quit_bad_alloc): Update.
 954         * common/common-exceptions.c (exception_none): Change
 955         initializer.
 956         (struct catcher) <state, exception>: Initialize inline.
 957         <prev>: Remove member.
 958         (current_catcher): Remove.
 959         (catchers): New global.
 960         (exceptions_state_mc_init): Simplify.
 961         (catcher_pop): Remove.
 962         (exceptions_state_mc, exceptions_state_mc_catch): Update.
 963         (try_scope_depth, exception_try_scope_entry)
 964         (exception_try_scope_exit): Remove.
 965         (throw_exception_sjlj): Update.
 966         (exception_messages, exception_messages_size): Remove.
 967         (throw_it): Simplify.
 968         (gdb_exception_sliced_copy): Remove.
 969         (throw_exception_cxx): Update.
 970         * cli/cli-script.c (script_from_file): Update.
 971         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
 972         Update.
 973         * ada-valprint.c (ada_val_print): Update.
 974         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
 975         (create_excep_cond_exprs): Update.
 976
 977 2019-04-08  Tom Tromey  <tom@tromey.com>
 978
 979         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
 980         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
 981         (TRY, CATCH, END_CATCH): Remove some definitions.
 982         * common/common-exceptions.c: Don't use GDB_XCPT.
 983         (catcher_list_size): Remove.
 984         (throw_exception, throw_it): Simplify.
 985
 986 2019-04-05  Tom Tromey  <tom@tromey.com>
 987
 988         Revert the header-sorting patch.
 989         * ft32-tdep.c: Revert.
 990         * frv-tdep.c: Revert.
 991         * frv-linux-tdep.c: Revert.
 992         * frame.c: Revert.
 993         * frame-unwind.c: Revert.
 994         * frame-base.c: Revert.
 995         * fork-child.c: Revert.
 996         * findvar.c: Revert.
 997         * findcmd.c: Revert.
 998         * filesystem.c: Revert.
 999         * filename-seen-cache.h: Revert.
1000         * filename-seen-cache.c: Revert.
1001         * fbsd-tdep.c: Revert.
1002         * fbsd-nat.h: Revert.
1003         * fbsd-nat.c: Revert.
1004         * f-valprint.c: Revert.
1005         * f-typeprint.c: Revert.
1006         * f-lang.c: Revert.
1007         * extension.h: Revert.
1008         * extension.c: Revert.
1009         * extension-priv.h: Revert.
1010         * expprint.c: Revert.
1011         * exec.h: Revert.
1012         * exec.c: Revert.
1013         * exceptions.c: Revert.
1014         * event-top.c: Revert.
1015         * event-loop.c: Revert.
1016         * eval.c: Revert.
1017         * elfread.c: Revert.
1018         * dwarf2read.h: Revert.
1019         * dwarf2read.c: Revert.
1020         * dwarf2loc.c: Revert.
1021         * dwarf2expr.h: Revert.
1022         * dwarf2expr.c: Revert.
1023         * dwarf2-frame.c: Revert.
1024         * dwarf2-frame-tailcall.c: Revert.
1025         * dwarf-index-write.h: Revert.
1026         * dwarf-index-write.c: Revert.
1027         * dwarf-index-common.c: Revert.
1028         * dwarf-index-cache.h: Revert.
1029         * dwarf-index-cache.c: Revert.
1030         * dummy-frame.c: Revert.
1031         * dtrace-probe.c: Revert.
1032         * disasm.h: Revert.
1033         * disasm.c: Revert.
1034         * disasm-selftests.c: Revert.
1035         * dictionary.c: Revert.
1036         * dicos-tdep.c: Revert.
1037         * demangle.c: Revert.
1038         * dcache.h: Revert.
1039         * dcache.c: Revert.
1040         * darwin-nat.h: Revert.
1041         * darwin-nat.c: Revert.
1042         * darwin-nat-info.c: Revert.
1043         * d-valprint.c: Revert.
1044         * d-namespace.c: Revert.
1045         * d-lang.c: Revert.
1046         * ctf.c: Revert.
1047         * csky-tdep.c: Revert.
1048         * csky-linux-tdep.c: Revert.
1049         * cris-tdep.c: Revert.
1050         * cris-linux-tdep.c: Revert.
1051         * cp-valprint.c: Revert.
1052         * cp-support.c: Revert.
1053         * cp-namespace.c: Revert.
1054         * cp-abi.c: Revert.
1055         * corelow.c: Revert.
1056         * corefile.c: Revert.
1057         * continuations.c: Revert.
1058         * completer.h: Revert.
1059         * completer.c: Revert.
1060         * complaints.c: Revert.
1061         * coffread.c: Revert.
1062         * coff-pe-read.c: Revert.
1063         * cli-out.h: Revert.
1064         * cli-out.c: Revert.
1065         * charset.c: Revert.
1066         * c-varobj.c: Revert.
1067         * c-valprint.c: Revert.
1068         * c-typeprint.c: Revert.
1069         * c-lang.c: Revert.
1070         * buildsym.c: Revert.
1071         * buildsym-legacy.c: Revert.
1072         * build-id.h: Revert.
1073         * build-id.c: Revert.
1074         * btrace.c: Revert.
1075         * bsd-uthread.c: Revert.
1076         * breakpoint.h: Revert.
1077         * breakpoint.c: Revert.
1078         * break-catch-throw.c: Revert.
1079         * break-catch-syscall.c: Revert.
1080         * break-catch-sig.c: Revert.
1081         * blockframe.c: Revert.
1082         * block.c: Revert.
1083         * bfin-tdep.c: Revert.
1084         * bfin-linux-tdep.c: Revert.
1085         * bfd-target.c: Revert.
1086         * bcache.c: Revert.
1087         * ax-general.c: Revert.
1088         * ax-gdb.h: Revert.
1089         * ax-gdb.c: Revert.
1090         * avr-tdep.c: Revert.
1091         * auxv.c: Revert.
1092         * auto-load.c: Revert.
1093         * arm-wince-tdep.c: Revert.
1094         * arm-tdep.c: Revert.
1095         * arm-symbian-tdep.c: Revert.
1096         * arm-pikeos-tdep.c: Revert.
1097         * arm-obsd-tdep.c: Revert.
1098         * arm-nbsd-tdep.c: Revert.
1099         * arm-nbsd-nat.c: Revert.
1100         * arm-linux-tdep.c: Revert.
1101         * arm-linux-nat.c: Revert.
1102         * arm-fbsd-tdep.c: Revert.
1103         * arm-fbsd-nat.c: Revert.
1104         * arm-bsd-tdep.c: Revert.
1105         * arch-utils.c: Revert.
1106         * arc-tdep.c: Revert.
1107         * arc-newlib-tdep.c: Revert.
1108         * annotate.h: Revert.
1109         * annotate.c: Revert.
1110         * amd64-windows-tdep.c: Revert.
1111         * amd64-windows-nat.c: Revert.
1112         * amd64-tdep.c: Revert.
1113         * amd64-sol2-tdep.c: Revert.
1114         * amd64-obsd-tdep.c: Revert.
1115         * amd64-obsd-nat.c: Revert.
1116         * amd64-nbsd-tdep.c: Revert.
1117         * amd64-nbsd-nat.c: Revert.
1118         * amd64-nat.c: Revert.
1119         * amd64-linux-tdep.c: Revert.
1120         * amd64-linux-nat.c: Revert.
1121         * amd64-fbsd-tdep.c: Revert.
1122         * amd64-fbsd-nat.c: Revert.
1123         * amd64-dicos-tdep.c: Revert.
1124         * amd64-darwin-tdep.c: Revert.
1125         * amd64-bsd-nat.c: Revert.
1126         * alpha-tdep.c: Revert.
1127         * alpha-obsd-tdep.c: Revert.
1128         * alpha-nbsd-tdep.c: Revert.
1129         * alpha-mdebug-tdep.c: Revert.
1130         * alpha-linux-tdep.c: Revert.
1131         * alpha-linux-nat.c: Revert.
1132         * alpha-bsd-tdep.c: Revert.
1133         * alpha-bsd-nat.c: Revert.
1134         * aix-thread.c: Revert.
1135         * agent.c: Revert.
1136         * addrmap.c: Revert.
1137         * ada-varobj.c: Revert.
1138         * ada-valprint.c: Revert.
1139         * ada-typeprint.c: Revert.
1140         * ada-tasks.c: Revert.
1141         * ada-lang.c: Revert.
1142         * aarch64-tdep.c: Revert.
1143         * aarch64-ravenscar-thread.c: Revert.
1144         * aarch64-newlib-tdep.c: Revert.
1145         * aarch64-linux-tdep.c: Revert.
1146         * aarch64-linux-nat.c: Revert.
1147         * aarch64-fbsd-tdep.c: Revert.
1148         * aarch64-fbsd-nat.c: Revert.
1149         * aarch32-linux-nat.c: Revert.
1150
1151 2019-04-05  Tom Tromey  <tom@tromey.com>
1152
1153         * ft32-tdep.c: Sort headers.
1154         * frv-tdep.c: Sort headers.
1155         * frv-linux-tdep.c: Sort headers.
1156         * frame.c: Sort headers.
1157         * frame-unwind.c: Sort headers.
1158         * frame-base.c: Sort headers.
1159         * fork-child.c: Sort headers.
1160         * findvar.c: Sort headers.
1161         * findcmd.c: Sort headers.
1162         * filesystem.c: Sort headers.
1163         * filename-seen-cache.h: Sort headers.
1164         * filename-seen-cache.c: Sort headers.
1165         * fbsd-tdep.c: Sort headers.
1166         * fbsd-nat.h: Sort headers.
1167         * fbsd-nat.c: Sort headers.
1168         * f-valprint.c: Sort headers.
1169         * f-typeprint.c: Sort headers.
1170         * f-lang.c: Sort headers.
1171         * extension.h: Sort headers.
1172         * extension.c: Sort headers.
1173         * extension-priv.h: Sort headers.
1174         * expprint.c: Sort headers.
1175         * exec.h: Sort headers.
1176         * exec.c: Sort headers.
1177         * exceptions.c: Sort headers.
1178         * event-top.c: Sort headers.
1179         * event-loop.c: Sort headers.
1180         * eval.c: Sort headers.
1181         * elfread.c: Sort headers.
1182         * dwarf2read.h: Sort headers.
1183         * dwarf2read.c: Sort headers.
1184         * dwarf2loc.c: Sort headers.
1185         * dwarf2expr.h: Sort headers.
1186         * dwarf2expr.c: Sort headers.
1187         * dwarf2-frame.c: Sort headers.
1188         * dwarf2-frame-tailcall.c: Sort headers.
1189         * dwarf-index-write.h: Sort headers.
1190         * dwarf-index-write.c: Sort headers.
1191         * dwarf-index-common.c: Sort headers.
1192         * dwarf-index-cache.h: Sort headers.
1193         * dwarf-index-cache.c: Sort headers.
1194         * dummy-frame.c: Sort headers.
1195         * dtrace-probe.c: Sort headers.
1196         * disasm.h: Sort headers.
1197         * disasm.c: Sort headers.
1198         * disasm-selftests.c: Sort headers.
1199         * dictionary.c: Sort headers.
1200         * dicos-tdep.c: Sort headers.
1201         * demangle.c: Sort headers.
1202         * dcache.h: Sort headers.
1203         * dcache.c: Sort headers.
1204         * darwin-nat.h: Sort headers.
1205         * darwin-nat.c: Sort headers.
1206         * darwin-nat-info.c: Sort headers.
1207         * d-valprint.c: Sort headers.
1208         * d-namespace.c: Sort headers.
1209         * d-lang.c: Sort headers.
1210         * ctf.c: Sort headers.
1211         * csky-tdep.c: Sort headers.
1212         * csky-linux-tdep.c: Sort headers.
1213         * cris-tdep.c: Sort headers.
1214         * cris-linux-tdep.c: Sort headers.
1215         * cp-valprint.c: Sort headers.
1216         * cp-support.c: Sort headers.
1217         * cp-namespace.c: Sort headers.
1218         * cp-abi.c: Sort headers.
1219         * corelow.c: Sort headers.
1220         * corefile.c: Sort headers.
1221         * continuations.c: Sort headers.
1222         * completer.h: Sort headers.
1223         * completer.c: Sort headers.
1224         * complaints.c: Sort headers.
1225         * coffread.c: Sort headers.
1226         * coff-pe-read.c: Sort headers.
1227         * cli-out.h: Sort headers.
1228         * cli-out.c: Sort headers.
1229         * charset.c: Sort headers.
1230         * c-varobj.c: Sort headers.
1231         * c-valprint.c: Sort headers.
1232         * c-typeprint.c: Sort headers.
1233         * c-lang.c: Sort headers.
1234         * buildsym.c: Sort headers.
1235         * buildsym-legacy.c: Sort headers.
1236         * build-id.h: Sort headers.
1237         * build-id.c: Sort headers.
1238         * btrace.c: Sort headers.
1239         * bsd-uthread.c: Sort headers.
1240         * breakpoint.h: Sort headers.
1241         * breakpoint.c: Sort headers.
1242         * break-catch-throw.c: Sort headers.
1243         * break-catch-syscall.c: Sort headers.
1244         * break-catch-sig.c: Sort headers.
1245         * blockframe.c: Sort headers.
1246         * block.c: Sort headers.
1247         * bfin-tdep.c: Sort headers.
1248         * bfin-linux-tdep.c: Sort headers.
1249         * bfd-target.c: Sort headers.
1250         * bcache.c: Sort headers.
1251         * ax-general.c: Sort headers.
1252         * ax-gdb.h: Sort headers.
1253         * ax-gdb.c: Sort headers.
1254         * avr-tdep.c: Sort headers.
1255         * auxv.c: Sort headers.
1256         * auto-load.c: Sort headers.
1257         * arm-wince-tdep.c: Sort headers.
1258         * arm-tdep.c: Sort headers.
1259         * arm-symbian-tdep.c: Sort headers.
1260         * arm-pikeos-tdep.c: Sort headers.
1261         * arm-obsd-tdep.c: Sort headers.
1262         * arm-nbsd-tdep.c: Sort headers.
1263         * arm-nbsd-nat.c: Sort headers.
1264         * arm-linux-tdep.c: Sort headers.
1265         * arm-linux-nat.c: Sort headers.
1266         * arm-fbsd-tdep.c: Sort headers.
1267         * arm-fbsd-nat.c: Sort headers.
1268         * arm-bsd-tdep.c: Sort headers.
1269         * arch-utils.c: Sort headers.
1270         * arc-tdep.c: Sort headers.
1271         * arc-newlib-tdep.c: Sort headers.
1272         * annotate.h: Sort headers.
1273         * annotate.c: Sort headers.
1274         * amd64-windows-tdep.c: Sort headers.
1275         * amd64-windows-nat.c: Sort headers.
1276         * amd64-tdep.c: Sort headers.
1277         * amd64-sol2-tdep.c: Sort headers.
1278         * amd64-obsd-tdep.c: Sort headers.
1279         * amd64-obsd-nat.c: Sort headers.
1280         * amd64-nbsd-tdep.c: Sort headers.
1281         * amd64-nbsd-nat.c: Sort headers.
1282         * amd64-nat.c: Sort headers.
1283         * amd64-linux-tdep.c: Sort headers.
1284         * amd64-linux-nat.c: Sort headers.
1285         * amd64-fbsd-tdep.c: Sort headers.
1286         * amd64-fbsd-nat.c: Sort headers.
1287         * amd64-dicos-tdep.c: Sort headers.
1288         * amd64-darwin-tdep.c: Sort headers.
1289         * amd64-bsd-nat.c: Sort headers.
1290         * alpha-tdep.c: Sort headers.
1291         * alpha-obsd-tdep.c: Sort headers.
1292         * alpha-nbsd-tdep.c: Sort headers.
1293         * alpha-mdebug-tdep.c: Sort headers.
1294         * alpha-linux-tdep.c: Sort headers.
1295         * alpha-linux-nat.c: Sort headers.
1296         * alpha-bsd-tdep.c: Sort headers.
1297         * alpha-bsd-nat.c: Sort headers.
1298         * aix-thread.c: Sort headers.
1299         * agent.c: Sort headers.
1300         * addrmap.c: Sort headers.
1301         * ada-varobj.c: Sort headers.
1302         * ada-valprint.c: Sort headers.
1303         * ada-typeprint.c: Sort headers.
1304         * ada-tasks.c: Sort headers.
1305         * ada-lang.c: Sort headers.
1306         * aarch64-tdep.c: Sort headers.
1307         * aarch64-ravenscar-thread.c: Sort headers.
1308         * aarch64-newlib-tdep.c: Sort headers.
1309         * aarch64-linux-tdep.c: Sort headers.
1310         * aarch64-linux-nat.c: Sort headers.
1311         * aarch64-fbsd-tdep.c: Sort headers.
1312         * aarch64-fbsd-nat.c: Sort headers.
1313         * aarch32-linux-nat.c: Sort headers.
1314
1315 2019-04-04  Tom Tromey  <tom@tromey.com>
1316
1317         * varobj.c (varobj_create): Update.
1318         * rust-exp.y (struct rust_parser) <update_innermost_block,
1319         lookup_symbol>: New methods.
1320         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
1321         Rename.
1322         (rust_parser::rust_lookup_type)
1323         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1324         * printcmd.c (display_command, do_one_display): Update.
1325         * parser-defs.h (struct parser_state) <parser_state>: Add
1326         "tracker" parameter.
1327         (block_tracker): New member.
1328         (class innermost_block_tracker) <innermost_block_tracker>: Add
1329         "types" parameter.
1330         <reset>: Remove method.
1331         (innermost_block): Don't declare.
1332         (null_post_parser): Update.
1333         * parse.c (innermost_block): Remove global.
1334         (write_dollar_variable): Update.
1335         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
1336         Remove "tracker_types" parameter.
1337         (parse_expression): Add "tracker" parameter.
1338         (parse_expression_for_completion): Update.
1339         (null_post_parser): Add "tracker" parameter.
1340         * p-exp.y: Update rules.
1341         * m2-exp.y: Update rules.
1342         * language.h (struct language_defn) <la_post_parser>: Add
1343         "tracker" parameter.
1344         * go-exp.y: Update rules.
1345         * f-exp.y: Update rules.
1346         * expression.h (parse_expression, parse_exp_1): Add "tracker"
1347         parameter.
1348         * d-exp.y: Update rules.
1349         * c-exp.y: Update rules.
1350         * breakpoint.c (set_breakpoint_condition): Create an
1351         innermost_block_tracker.
1352         (watch_command_1): Likewise.
1353         * ada-lang.c (resolve): Add "tracker" parameter.
1354         (resolve_subexp): Likewise.
1355         * ada-exp.y (write_var_from_sym): Update.
1356
1357 2019-04-04  Tom Tromey  <tom@tromey.com>
1358
1359         * type-stack.h: New file.
1360         * type-stack.c: New file.
1361         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
1362         type-stack.h.
1363         (insert_into_type_stack, insert_type, push_type, push_type_int)
1364         (insert_type_address_space, pop_type, pop_type_int)
1365         (pop_typelist, pop_type_stack, append_type_stack)
1366         (push_type_stack, get_type_stack, push_typelist)
1367         (follow_type_instance_flags, follow_types): Don't declare.
1368         * parse.c (type_stack): Remove global.
1369         (parse_exp_in_context): Update.
1370         (insert_into_type_stack, insert_type, push_type, push_type_int)
1371         (insert_type_address_space, pop_type, pop_type_int)
1372         (pop_typelist, pop_type_stack, append_type_stack)
1373         (push_type_stack, get_type_stack, push_typelist)
1374         (follow_type_instance_flags, follow_types): Remove (moved to
1375         type-stack.c).
1376         * f-exp.y (type_stack): New global.
1377         Update rules.
1378         (push_kind_type, f_parse): Update.
1379         * d-exp.y (type_stack): New global.
1380         Update rules.
1381         (d_parse): Update.
1382         * c-exp.y (struct c_parse_state) <type_stack>: New member.
1383         Update rules.
1384         * Makefile.in (COMMON_SFILES): Add type-stack.c.
1385         (HFILES_NO_SRCDIR): Add type-stack.h.
1386
1387 2019-04-04  Tom Tromey  <tom@tromey.com>
1388
1389         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
1390         (rust_parser::convert_ast_to_expression, rust_parse)
1391         (rust_lex_test_completion, rust_lex_tests): Update.
1392         * parser-defs.h (struct expr_completion_state): New.
1393         (struct parser_state) <parser_state>: Add completion parameter.
1394         <mark_struct_expression, mark_completion_tag>: New methods.
1395         <parse_completion, m_completion_state>: New members.
1396         (prefixify_expression, null_post_parser): Update.
1397         (mark_struct_expression, mark_completion_tag): Don't declare.
1398         * parse.c (parse_completion, expout_last_struct)
1399         (expout_tag_completion_type, expout_completion_name): Remove
1400         globals.
1401         (parser_state::mark_struct_expression)
1402         (parser_state::mark_completion_tag): Now methods.
1403         (prefixify_expression): Add last_struct parameter.
1404         (prefixify_subexp): Likewise.
1405         (parse_exp_1): Update.
1406         (parse_exp_in_context): Add cstate parameter.  Update.
1407         (parse_expression_for_completion): Create an
1408         expr_completion_state.
1409         (null_post_parser): Add "completion" parameter.
1410         * p-exp.y: Update rules.
1411         (yylex): Update.
1412         * language.h (struct language_defn) <la_post_parser>: Add
1413         "completing" parameter.
1414         * go-exp.y: Update rules.
1415         (lex_one_token): Update.
1416         * expression.h (parse_completion): Don't declare.
1417         * d-exp.y: Update rules.
1418         (lex_one_token): Update rules.
1419         * c-exp.y: Update rules.
1420         (lex_one_token): Update.
1421         * ada-lang.c (resolve): Add "parse_completion" parameter.
1422         (resolve_subexp): Likewise.
1423         (ada_resolve_function): Likewise.
1424
1425 2019-04-04  Tom Tromey  <tom@tromey.com>
1426
1427         * parser-defs.h (struct parser_state) <start_arglist,
1428         end_arglist>: New methods.
1429         <arglist_len, m_funcall_chain>: New members.
1430         (arglist_len, start_arglist, end_arglist): Don't declare.
1431         * parse.c (arglist_len, funcall_chain): Remove global.
1432         (start_arglist, end_arglist): Remove functions.
1433         (parse_exp_in_context): Update.
1434         * p-exp.y: Update rules.
1435         * m2-exp.y: Update rules.
1436         * go-exp.y: Update rules.
1437         * f-exp.y: Update rules.
1438         * d-exp.y: Update rules.
1439         * c-exp.y: Update rules.
1440
1441 2019-04-04  Tom Tromey  <tom@tromey.com>
1442
1443         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
1444         lex_operator, push_back>: New methods.
1445         Update all rules.
1446         (rust_parser::lex_hex, lex_escape): Rename and update.
1447         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
1448         (rust_parser::lex_operator): Rename and update.
1449         (rust_parser::lex_number, rustyylex, rustyyerror)
1450         (rust_lex_test_init, rust_lex_test_sequence)
1451         (rust_lex_test_push_back, rust_lex_tests): Update.
1452         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
1453         parameter.
1454         <lexptr, prev_lexptr>: New members.
1455         (lexptr, prev_lexptr): Don't declare.
1456         * parse.c (lexptr, prev_lexptr): Remove globals.
1457         (parse_exp_in_context): Update.
1458         * p-exp.y (yylex, yyerror): Update.
1459         * m2-exp.y (parse_number, yylex, yyerror): Update.
1460         * go-exp.y (lex_one_token, yyerror): Update.
1461         * f-exp.y (match_string_literal, yylex, yyerror): Update.
1462         * d-exp.y (lex_one_token, yyerror): Update.
1463         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
1464         (lex_one_token, yyerror): Update.
1465         * ada-lex.l (YY_INPUT): Update.
1466         (rewind_to_char): Update.
1467         * ada-exp.y (yyerror): Update.
1468
1469 2019-04-04  Tom Tromey  <tom@tromey.com>
1470
1471         * rust-exp.y (rustyylex, rust_lex_tests): Update.
1472         * parser-defs.h (struct parser_state) <parser_state>: Add new
1473         parameter.
1474         <comma_terminates>: New member.
1475         (comma_terminates): Don't declare global.
1476         * parse.c (comma_terminates): Remove global.
1477         (parse_exp_in_context): Update.
1478         * p-exp.y (yylex): Update.
1479         * m2-exp.y (yylex): Update.
1480         * go-exp.y (lex_one_token): Update.
1481         * f-exp.y (yylex): Update.
1482         * d-exp.y (lex_one_token): Update.
1483         * c-exp.y (lex_one_token): Update.
1484         * ada-lex.l: Update.
1485
1486 2019-04-04  Tom Tromey  <tom@tromey.com>
1487
1488         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
1489         (rustyylex, rust_lex_test_init, rust_lex_test_one)
1490         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
1491         * parser-defs.h (paren_depth): Don't declare.
1492         * parse.c (paren_depth): Remove global.
1493         (parse_exp_in_context): Update.
1494         * p-exp.y (paren_depth): New global.
1495         (pascal_parse): Initialize it.
1496         * m2-exp.y (paren_depth): New global.
1497         (m2_parse): Initialize it.
1498         * go-exp.y (paren_depth): New global.
1499         (go_parse): Initialize it.
1500         * f-exp.y (paren_depth): New global.
1501         (f_parse): Initialize it.
1502         * d-exp.y (paren_depth): New global.
1503         (d_parse): Initialize it.
1504         * c-exp.y (paren_depth): New global.
1505         (c_parse): Initialize it.
1506         * ada-lex.l (paren_depth): New global.
1507         (lexer_init): Initialize it.
1508
1509 2019-04-04  Tom Tromey  <tom@tromey.com>
1510
1511         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
1512         (rust_parser::convert_ast_to_type)
1513         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
1514         * parser-defs.h (struct parser_state) <parser_state>: Add
1515         parameters.  Initialize new members.
1516         <expression_context_block, expression_context_pc>: New members.
1517         * parse.c (expression_context_block, expression_context_pc):
1518         Remove globals.
1519         (parse_exp_in_context): Update.
1520         * p-exp.y: Update all rules.
1521         (yylex): Update.
1522         * m2-exp.y: Update all rules.
1523         (yylex): Update.
1524         * go-exp.y (yylex): Update.
1525         * f-exp.y (yylex): Update.
1526         * d-exp.y: Update all rules.
1527         (yylex): Update.
1528         * c-exp.y: Update all rules.
1529         (lex_one_token, classify_name, yylex, c_parse): Update.
1530         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
1531
1532 2019-04-04  Tom Tromey  <tom@tromey.com>
1533
1534         * gdbarch.h, gdbarch.c: Rebuild.
1535         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
1536         * stap-probe.h:
1537         (struct stap_parse_info): Replace "parser_state" with
1538         "expr_builder".
1539         * parser-defs.h (struct expr_builder): Rename from "parser_state".
1540         (parser_state): New class.
1541         * parse.c (expr_builder): Rename.
1542         (expr_builder::release): Rename.
1543         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
1544         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
1545         (write_exp_elt_longcst, write_exp_elt_floatcst)
1546         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
1547         (write_exp_string_vector, write_exp_bitstring)
1548         (write_exp_msymbol, mark_struct_expression)
1549         (write_dollar_variable)
1550         (insert_type_address_space, increase_expout_size): Replace
1551         "parser_state" with "expr_builder".
1552         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
1553         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
1554         "parser_state" with "expr_builder".
1555
1556 2019-04-04  Tom Tromey  <tom@tromey.com>
1557
1558         * rust-exp.y: Replace "parse_language" with method call.
1559         * p-exp.y:
1560         (yylex): Replace "parse_language" with method call.
1561         * m2-exp.y:
1562         (yylex): Replace "parse_language" with method call.
1563         * go-exp.y (classify_name): Replace "parse_language" with method
1564         call.
1565         * f-exp.y (yylex): Replace "parse_language" with method call.
1566         * d-exp.y (lex_one_token): Replace "parse_language" with method
1567         call.
1568         * c-exp.y:
1569         (lex_one_token, classify_name, yylex): Replace "parse_language"
1570         with method call.
1571         * ada-exp.y (find_primitive_type, type_char)
1572         (type_system_address): Replace "parse_language" with method call.
1573
1574 2019-04-04  Tom Tromey  <tom@tromey.com>
1575
1576         * rust-exp.y: Replace "parse_gdbarch" with method call.
1577         * parse.c (write_dollar_variable, insert_type_address_space):
1578         Replace "parse_gdbarch" with method call.
1579         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
1580         call.
1581         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
1582         call.
1583         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
1584         "parse_gdbarch" with method call.
1585         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
1586         with method call.
1587         * f-exp.y (parse_type, parse_f_type, yylex): Replace
1588         "parse_gdbarch" with method call.
1589         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
1590         "parse_gdbarch" with method call.
1591         * c-exp.y (parse_type, parse_number, classify_name): Replace
1592         "parse_gdbarch" with method call.
1593         * ada-lex.l: Replace "parse_gdbarch" with method call.
1594         * ada-exp.y (parse_type, find_primitive_type, type_char)
1595         (type_system_address): Replace "parse_gdbarch" with method call.
1596
1597 2019-04-04  Tom Tromey  <tom@tromey.com>
1598
1599         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
1600         * stap-probe.c (stap_parse_argument): Update.
1601         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
1602         initial_size parameter.
1603         * rust-exp.y (rust_lex_tests): Update.
1604         * parse.c (parser_state): Update.
1605         (parse_exp_in_context): Update.
1606         * parser-defs.h (struct parser_state) <parser_state>: Remove
1607         "initial_size" parameter.
1608
1609 2019-04-04  Tom Tromey  <tom@tromey.com>
1610
1611         * parser-defs.h (increase_expout_size): Don't declare.
1612         * parse.c (increase_expout_size): Now static.
1613
1614 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
1615
1616         * gnu-nat.c (gnu_nat_target::wait): Fix
1617         target_waitstatus_to_string call.
1618
1619 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1620
1621         * eval.c (evaluate_subexp_standard): Handle internal functions
1622         during Fortran function call handling.
1623
1624 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1625
1626         * NEWS: Mention new internal functions.
1627         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
1628         (read_base_type): Use dwarf2_init_complex_target_type.
1629         * value.c (creal_internal_fn): New function.
1630         (cimag_internal_fn): New function.
1631         (_initialize_values): Register new internal functions.
1632
1633 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1634
1635         * infrun.c (stop_all_threads): If debug_infrun, always
1636         trace the wait status after wait_one, using
1637         target_waitstatus_to_string and target_pid_to_str.
1638         (handle_inferior_event): Replace various trace of
1639         wait status kind by a single trace.
1640         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
1641         wait status kind image by target_waitstatus_to_string.
1642         * target/waitstatus.c (target_waitstatus_to_string): Fix
1643         obsolete comment.
1644
1645 2019-04-01  Tom Tromey  <tromey@adacore.com>
1646
1647         PR symtab/23331:
1648         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
1649
1650 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
1651             Pedro Alves  <palves@redhat.com>
1652
1653         * top.c (quit_force): Call 'finalize_values'.
1654         * value.c (finalize_values): New function.
1655         * value.h (finalize_values): Declare.
1656
1657 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
1658
1659         * NEWS: Announce $_gdb_major and $_gdb_minor.
1660
1661         * top.c (init_gdb_version_vars): New function.
1662         (gdb_init): Call init_gdb_version_vars.
1663
1664 2019-03-29  Tom Tromey  <tromey@adacore.com>
1665
1666         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
1667         help text.  Remove dead code.
1668
1669 2019-03-29  Keith Seitz  <keiths@redhat.com>
1670
1671         From Siddhesh Poyarekar:
1672         * f-lang.h (f77_get_upperbound): Return LONGEST.
1673         (f77_get_lowerbound): Likewise.
1674         * f-typeprint.c (f_type_print_varspec_suffix): Expand
1675         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
1676         print them.
1677         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
1678         plongest to format print it.
1679         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
1680         (f77_get_upperbound): Likewise.
1681         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
1682         LOWER_BOUND to LONGEST.
1683         (f77_create_arrayprint_offset_tbl): Likewise.
1684
1685 2019-03-29  Keith Seitz  <keiths@redhat.com>
1686
1687         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
1688         %s/pulongest for TYPE_LENGTH instead of %d in format
1689         strings.
1690         * ada-typerint.c (ada_print_type): Likewise.
1691         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
1692         * compile/compile-c-support.c (generate_register_struct): Likewise.
1693         * gdbtypes.c (recursive_dump_type): Likewise.
1694         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
1695         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
1696         instead of %d in format strings.
1697         * riscv-tdep.c (riscv_type_alignment): Cast second argument
1698         to std::min to ULONGEST.
1699         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
1700         instead of %d in format strings.
1701         * tracepoint.c (info_scope_command): Likewise.
1702         * typeprint.c (print_offset_data::update)
1703         (print_offset_data::finish): Likewise.
1704         * xtensa-tdep.c (xtensa_store_return_value)
1705         (xtensa_push_dummy_call): Likewise.
1706
1707 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
1708
1709         * windows-nat.c (display_selector): Fixed format specifications
1710         for 64-bit Cygwin.
1711
1712 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1713
1714         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
1715
1716 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
1717
1718         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
1719         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
1720         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
1721         (nios2_linux_init_abi): Install it.
1722
1723 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1724
1725         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
1726
1727 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
1728
1729         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
1730
1731 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1732             Tom Tromey  <tromey@adacore.com>
1733
1734         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
1735
1736 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
1737
1738         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
1739         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
1740         method to compute the bounds of range types. Also print "[evaluated]"
1741         if the bounds' values come from a dynamic evaluation.
1742
1743 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
1744
1745         * cp-valprint.c (cp_print_value_fields): Don't print trailing
1746         whitespace when pretty printing is on.
1747
1748 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1749
1750         * ppc-linux-nat.c: Add include.
1751
1752 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1753
1754         * NEWS: Mention AArch64 Pointer Authentication.
1755
1756 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
1757
1758         * arm-linux-nat.c: Add include.
1759
1760 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
1761
1762         * source-cache.c (source_cache::get_source_lines): Re-read
1763         fullname after calling open_source_file.
1764
1765 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
1766
1767         * NEWS: Mention TLS support for FreeBSD.
1768
1769 2019-03-25  Tom Tromey  <tromey@adacore.com>
1770
1771         * minsyms.c (BUNCH_SIZE): Update comment.
1772         (~minimal_symbol_reader): Remove old comment.
1773         (compact_minimal_symbols): Update comment.
1774         (minimal_symbol_reader::install): Remove old comment.  Update
1775         other comments.
1776
1777 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1778
1779         * s390-linux-nat.c: Add include.
1780
1781 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
1782
1783         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
1784         Call linux_get_hwcap.
1785         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
1786         Likewise.
1787         (aarch64_linux_get_hwcap): Remove function.
1788         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
1789         declaration.
1790         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
1791         linux_get_hwcap.
1792         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
1793         * linux-tdep.c (linux_get_hwcap): Add function.
1794         (linux_get_hwcap2): Likewise.
1795         * linux-tdep.h (linux_get_hwcap): Add declaration.
1796         (linux_get_hwcap2): Likewise.
1797         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
1798         (ppc_linux_get_hwcap2): Likewise.
1799         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
1800         linux_get_hwcap.
1801         (ppc_linux_nat_target::insert_watchpoint): Likewise.
1802         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
1803         (ppc_linux_nat_target::read_description): Likewise.
1804         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
1805         * s390-linux-nat.c: Likewise.
1806         * s390-linux-tdep.c (s390_core_read_description): Likewise.
1807
1808 2019-03-24  Tom Tromey  <tom@tromey.com>
1809
1810         * ada-lang.c (standard_lookup): Simplify initialization.
1811         (ada_lookup_symbol_nonlocal): Simplify return.
1812         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
1813         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
1814         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
1815         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
1816         initialization.
1817         * solib.c (solib_global_lookup): Simplify.
1818         * symtab.c (null_block_symbol): Remove.
1819         (symbol_cache_lookup): Simplify returns.
1820         (lookup_language_this): Simplify returns.
1821         (lookup_symbol_aux): Simplify return.
1822         (lookup_local_symbol): Simplify returns.
1823         (lookup_global_symbol_from_objfile): Simplify return.
1824         (lookup_symbol_in_objfile_symtabs)
1825         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
1826         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
1827         (lookup_static_symbol, lookup_global_symbol): Simplify return.
1828         * cp-namespace.c (cp_lookup_bare_symbol)
1829         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
1830         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
1831         (cp_lookup_nested_symbol): Don't use null_block_symbol.
1832         (cp_lookup_symbol_via_imports): Simplify initialization.
1833         (find_symbol_in_baseclass): Likewise.
1834         * symtab.h (null_block_symbol): Remove.
1835         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
1836         (d_lookup_nested_symbol, d_lookup_symbol_imports)
1837         (d_lookup_symbol_module): Likewise.
1838         (find_symbol_in_baseclass): Simplify initialization.
1839
1840 2019-03-24  Tom Tromey  <tom@tromey.com>
1841
1842         * expression.h: Don't include symtab.h.
1843         (struct block): Forward declare.
1844
1845 2019-03-24  Tom Tromey  <tom@tromey.com>
1846
1847         * c-exp.y (typebase): Remove casts.
1848         * gdbtypes.c (lookup_unsigned_typename, )
1849         (lookup_signed_typename): Remove cast.
1850         * eval.c (parse_to_comma_and_eval): Remove cast.
1851         * parse.c (write_dollar_variable): Remove cast.
1852         * block.h (struct block) <superblock>: Now const.
1853         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
1854         * psymtab.c (psym_map_matching_symbols): Make "block" const.
1855         (map_block): Make "block" const.
1856         * symfile.h (struct quick_symbol_functions)
1857         <map_matching_symbols>: Constify block argument to "callback".
1858         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
1859         const.
1860         (find_pc_sect_compunit_symtab): Make "b" const.
1861         (find_symbol_at_address): Likewise.
1862         (search_symbols): Likewise.
1863         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
1864         (dw2_debug_names_lookup_symbol): Likewise.
1865         (dw2_map_matching_symbols): Update.
1866         * p-valprint.c (pascal_val_print): Remove "block".
1867         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
1868         (aux_add_nonlocal_symbols): Make "block" const.
1869         (resolve_subexp): Remove cast.
1870         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
1871         const.
1872         (iterate_over_file_blocks): Likewise.
1873         * f-exp.y (%union) <bval>: Remove.
1874         * coffread.c (patch_opaque_types): Make "b" const.
1875         * spu-tdep.c (spu_catch_start): Make "block" const.
1876         * c-valprint.c (print_unpacked_pointer): Remove "block".
1877         * symmisc.c (dump_symtab_1): Make "b" const.
1878         (block_depth): Make "block" const.
1879         * d-exp.y (%union) <bval>: Remove.
1880         * cp-support.h (cp_lookup_rtti_type): Update.
1881         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
1882         * psymtab.c (psym_lookup_symbol): Make "block" const.
1883         (maintenance_check_psymtabs): Make "b" const.
1884         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
1885         (enumerate_locals, enumerate_args): Update.
1886         * python/py-symtab.c (stpy_global_block): Make "block" const.
1887         (stpy_static_block): Likewise.
1888         * inline-frame.c (block_starting_point_at): Make "new_block"
1889         const.
1890         * block.c (find_block_in_blockvector): Make return type const.
1891         (blockvector_for_pc_sect): Make "b" const.
1892         (find_block_in_blockvector): Make "b" const.
1893
1894 2019-03-23  Tom Tromey  <tom@tromey.com>
1895
1896         * varobj.c (varobj_create): Update.
1897         * symfile.c (clear_symtab_users): Don't reset innermost_block.
1898         * printcmd.c (display_command, do_one_display): Don't reset
1899         innermost_block.
1900         * parser-defs.h (enum innermost_block_tracker_type): Move to
1901         expression.h.
1902         (innermost_block): Update comment.
1903         * parse.c (parse_exp_1): Add tracker_types parameter.
1904         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
1905         tracker_types parameter.  Reset innermost_block.
1906         (parse_exp_in_context): Remove.
1907         (parse_expression_for_completion): Update.
1908         * objfiles.c (~objfile): Don't reset expression_context_block or
1909         innermost_block.
1910         * expression.h (enum innermost_block_tracker_type): Move from
1911         parser-defs.h.
1912         (parse_exp_1): Add tracker_types parameter.
1913         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
1914         reset innermost_block.
1915
1916 2019-03-23  Tom Tromey  <tom@tromey.com>
1917
1918         * objfiles.h: Include bcache.h.
1919
1920 2019-03-23  Tom Tromey  <tom@tromey.com>
1921
1922         * linespec.c (get_current_search_block): Use
1923         scoped_restore_current_language.
1924         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
1925
1926 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1927             Jiong Wang  <jiong.wang@arm.com>
1928
1929         * aarch64-linux-tdep.c
1930         (aarch64_linux_iterate_over_regset_sections): Check for pauth
1931         section.
1932         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
1933
1934 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1935             Jiong Wang  <jiong.wang@arm.com>
1936
1937         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
1938         instructions.
1939         (aarch64_analyze_prologue_test): Add PACIASP test.
1940         (aarch64_prologue_prev_register): Unmask PC value.
1941
1942 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1943             Jiong Wang  <jiong.wang@arm.com>
1944
1945         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
1946         (aarch64_dwarf2_prev_register): Unmask PC value.
1947         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
1948         (aarch64_execute_dwarf_cfa_vendor_op): Check for
1949         DW_CFA_AARCH64_negate_ra_state.
1950         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
1951
1952 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1953             Jiong Wang  <jiong.wang@arm.com>
1954
1955         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
1956         registers.
1957         (aarch64_pseudo_register_name): Likewise.
1958         (aarch64_pseudo_register_type): Likewise.
1959         (aarch64_pseudo_register_reggroup_p): Likewise.
1960         (aarch64_gdbarch_init): Add pauth registers.
1961         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
1962         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
1963         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
1964         (struct gdbarch_tdep): Add regnum for ra_state.
1965
1966 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1967             Jiong Wang  <jiong.wang@arm.com>
1968
1969         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
1970
1971 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1972             Jiong Wang  <jiong.wang@arm.com>
1973
1974         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
1975         function.
1976         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
1977         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
1978         (aarch64_gdbarch_init): Add puth registers.
1979         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
1980         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
1981         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
1982
1983 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1984             Jiong Wang  <jiong.wang@arm.com>
1985
1986         * aarch64-linux-nat.c
1987         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
1988         * aarch64-linux-tdep.c
1989         (aarch64_linux_core_read_description): Likewise.
1990         (aarch64_linux_get_hwcap): New function.
1991         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
1992         (aarch64_linux_get_hwcap): New declaration.
1993
1994 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
1995             Jiong Wang  <jiong.wang@arm.com>
1996
1997         * aarch64-linux-nat.c
1998         (aarch64_linux_nat_target::read_description): Add pauth param.
1999         * aarch64-linux-tdep.c
2000         (aarch64_linux_core_read_description): Likewise.
2001         * aarch64-tdep.c (struct target_desc): Add in pauth.
2002         (aarch64_read_description): Add pauth param.
2003         (aarch64_gdbarch_init): Likewise.
2004         * aarch64-tdep.h (aarch64_read_description): Likewise.
2005         * arch/aarch64.c (aarch64_create_target_description): Likewise.
2006         * arch/aarch64.h (aarch64_create_target_description): Likewise.
2007         * features/Makefile: Add new files.
2008         * features/aarch64-pauth.c: New file.
2009         * features/aarch64-pauth.xml: New file.
2010
2011 2019-03-20  Tom Tromey  <tromey@adacore.com>
2012
2013         * infrun.c (handle_inferior_event): Rename from
2014         handle_inferior_event_1.  Create a scoped_value_mark.
2015         (handle_inferior_event): Remove.
2016
2017 2019-03-19  Tom Tromey  <tromey@adacore.com>
2018
2019         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
2020         * infrun.h (print_stop_event): Add "displays" parameter.
2021         * infrun.c (print_stop_event): Add "displays" parameter.
2022
2023 2019-03-19  Pedro Alves  <palves@redhat.com>
2024
2025         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
2026         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
2027         to -1.  Fix TABs vs spaces.
2028         (tui_ui_out::tui_ui_out): Don't initialize fields here.
2029         * tui/tui-out.h (tui_ui_out) Add intro comments.
2030         <m_line, m_start_of_line>: In-class initialize, and add describing
2031         comment.
2032
2033 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
2034
2035         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
2036         variable names.
2037         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
2038
2039 2019-03-18  Pedro Alves  <palves@redhat.com>
2040             Eli Zaretskii <eliz@gnu.org>
2041
2042         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
2043         m_line and m_start_of_line.
2044
2045 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
2046
2047         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
2048         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
2049         it returns a newline.  This fixes a regression in TU mode, whereby
2050         the next line is output on the same screen line as the user input.
2051
2052 2019-03-18  Tom Tromey  <tromey@adacore.com>
2053
2054         * minsyms.c (minimal_symbol_reader::install): Remove call to
2055         obstack_blank.
2056
2057 2019-03-18  Pedro Alves  <palves@redhat.com>
2058
2059         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
2060         New globals.
2061         (apply_style): New, factored out from ...
2062         (apply_ansi_escape): ... this.  Handle reverse video mode.
2063         (tui_set_reverse_mode): New function.
2064         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
2065         * tui/tui-winsource.c (tui_show_source_line): Use
2066         tui_set_reverse_mode instead of setting A_STANDOUT.
2067         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
2068         New setter methods.
2069
2070 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
2071
2072         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
2073         Handle tabs.
2074
2075 2019-03-18  Tom Tromey  <tromey@adacore.com>
2076
2077         * ada-lang.c (empty_array): Add "high" parameter.
2078         (ada_evaluate_subexp): Update.
2079
2080 2019-03-17  Sergei Trofimovich <siarheit@google.com>
2081
2082         * unittests/string_view-selftests.c: Define
2083         _initialize_string_view_selftests unconditionally.
2084
2085 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2086
2087         PR gdb/24350
2088         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
2089
2090 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
2091
2092         PR gdb/24351
2093         * windows-nat.c (display_selector): Fix format specifiers.
2094
2095 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
2096
2097         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
2098         tui_refill_source_window instead of tui_refresh_win, to update the
2099         current execution line.  This fixes redisplay of the current line
2100         when stepping through the code with "next" or "step".
2101
2102 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2103
2104         * source-cache.c (source_cache::get_source_lines): Call
2105         find_source_lines to initialize s->nlines.  This fixes vertical
2106         scrolling of TUI source window when the DOWN arrow is pressed.
2107
2108 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2109
2110         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
2111         linux-thread-db.c (_initialize_thread_db): Likewise.
2112
2113 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
2114
2115         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
2116         wclrtoeol in tui_show_source_line".  This reverts changes made in
2117         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
2118
2119 2019-03-15  Tom Tromey  <tom@tromey.com>
2120
2121         * symtab.h (struct minimal_symbol): Derive from
2122         general_symbol_info.
2123         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
2124         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
2125         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
2126         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
2127         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
2128         (MSYMBOL_SEARCH_NAME): Update.
2129         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
2130         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
2131         * minsyms.c (minimal_symbol_reader::record_full): Update.
2132
2133 2019-03-15  Tom Tromey  <tom@tromey.com>
2134
2135         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
2136
2137 2019-03-15  Tom Tromey  <tom@tromey.com>
2138
2139         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
2140         unique_xmalloc_ptr.
2141         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
2142         Update.
2143         * minsyms.c (lookup_minimal_symbol_by_pc_section)
2144         (build_minimal_symbol_hash_tables)
2145         (minimal_symbol_reader::install): Update.
2146
2147 2019-03-15  Tom Tromey  <tom@tromey.com>
2148
2149         * symtab.c (create_demangled_names_hash): Update.
2150         (symbol_set_names): Update.
2151         * objfiles.h (struct objfile_per_bfd_storage)
2152         <demangled_names_hash>: Now an htab_up.
2153         * objfiles.c (objfile_per_bfd_storage): Simplify.
2154
2155 2019-03-15  Tom Tromey  <tom@tromey.com>
2156
2157         * objfiles.h (struct objfile_per_bfd_storage): Declare
2158         destructor.
2159         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
2160         New.
2161         (get_objfile_bfd_data): Use new.  Don't initialize
2162         language_of_main.
2163         (free_objfile_per_bfd_storage): Remove.
2164         (objfile_bfd_data_free, objfile::~objfile): Use delete.
2165
2166 2019-03-15  Tom Tromey  <tom@tromey.com>
2167
2168         * symfile.c (reread_symbols): Update.
2169         * objfiles.c (objfile::objfile): Update.
2170         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
2171         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
2172         comment.
2173         (minimal_symbol_reader::install): Update.
2174         (terminate_minimal_symbol_table): Remove.
2175         * jit.c (jit_object_close_impl): Update.
2176
2177 2019-03-15  Tom Tromey  <tom@tromey.com>
2178
2179         * minsyms.c (minimal_symbol_reader::record_full): Remove some
2180         initializations.
2181
2182 2019-03-15  Tom Tromey  <tom@tromey.com>
2183
2184         * objfiles.h (struct objfile_per_bfd_storage)
2185         <demangled_hash_languages>: Now a bitset.
2186         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
2187         (lookup_minimal_symbol): Update.
2188
2189 2019-03-15  Tom Tromey  <tom@tromey.com>
2190
2191         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
2192         Don't return the symbol.
2193         * coffread.c (record_minimal_symbol): Use record_full.
2194
2195 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
2196
2197         The MS-Windows port of ncurses fails to switch to a color pair if
2198         one or both of the colors are the implicit default colors.  This
2199         change records the default colors when TUI is initialized, and
2200         then specifies them explicitly when a color pair uses the default
2201         colors.  This allows color styling in TUI mode on MS-Windows.
2202
2203         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
2204         ncurses_norm_attr.
2205         (tui_initialize_io) [__MINGW32__]: Record the default terminal
2206         colors in ncurses_norm_attr.
2207         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
2208         "none", replace it with the default color recorded in
2209         ncurses_norm_attr.
2210
2211 2019-03-14  Tom Tromey  <tromey@adacore.com>
2212
2213         * source-cache.h (class source_cache) <get_source_lines>: Return
2214         std::string.
2215         * source-cache.c (source_cache::extract_lines): Handle case where
2216         first_pos==npos.  Return std::string.
2217         (source_cache::get_source_lines): Update.
2218
2219 2019-03-14  Tom Tromey  <tromey@adacore.com>
2220
2221         * NEWS: Add item for "style sources" commands.
2222         * source-cache.c (source_cache::get_source_lines): Check
2223         source_styling.
2224         * cli/cli-style.c (source_styling): New global.
2225         (_initialize_cli_style): Add "style sources" commands.
2226         (show_style_sources): New function.
2227         * cli/cli-style.h (source_styling): Declare.
2228
2229 2019-03-14  Pedro Alves  <palves@redhat.com>
2230             Tom Tromey  <tromey@adacore.com>
2231
2232         * tui/tui-winsource.h (tui_refill_source_window): Declare.
2233         * tui/tui-winsource.c (tui_refill_source_window): New function,
2234         from...
2235         (tui_horizontal_source_scroll): ... here.  Move some logic.
2236         * cli/cli-style.c (set_style_enabled): Notify new observable.
2237         * tui/tui-hooks.c (tui_redisplay_source): New function.
2238         (tui_attach_detach_observers): Attach or detach
2239         tui_redisplay_source.
2240         * observable.h (source_styling_changed): New observable.
2241         * observable.c: Define source_styling_changed observable.
2242
2243 2019-03-13  Tom Tromey  <tromey@adacore.com>
2244
2245         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
2246         (i386_gnu_nat_target::store_registers): Update.
2247         * target-debug.h (target_debug_print_std_string): New macro.
2248         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2249         * windows-tdep.c (display_one_tib): Update.
2250         * tui/tui-stack.c (tui_make_status_line): Update.
2251         * top.c (print_inferior_quit_action): Update.
2252         * thread.c (thr_try_catch_cmd): Update.
2253         (add_thread_with_info): Update.
2254         (thread_target_id_str): Update.
2255         (thr_try_catch_cmd): Update.
2256         (thread_command): Update.
2257         (thread_find_command): Update.
2258         * record-btrace.c (record_btrace_target::info_record)
2259         (record_btrace_resume_thread, record_btrace_target::resume)
2260         (record_btrace_cancel_resume, record_btrace_step_thread)
2261         (record_btrace_target::wait, record_btrace_target::wait)
2262         (record_btrace_target::wait, record_btrace_target::stop): Update.
2263         * progspace.c (print_program_space): Update.
2264         * process-stratum-target.c
2265         (process_stratum_target::thread_address_space): Update.
2266         * linux-fork.c (linux_fork_mourn_inferior)
2267         (detach_checkpoint_command, info_checkpoints_command)
2268         (linux_fork_context): Update.
2269         (linux_fork_detach): Update.
2270         (class scoped_switch_fork_info): Update.
2271         (delete_checkpoint_command): Update.
2272         * infrun.c (follow_fork_inferior): Update.
2273         (follow_fork_inferior): Update.
2274         (proceed_after_vfork_done): Update.
2275         (handle_vfork_child_exec_or_exit): Update.
2276         (follow_exec): Update.
2277         (displaced_step_prepare_throw): Update.
2278         (displaced_step_restore): Update.
2279         (start_step_over): Update.
2280         (resume_1): Update.
2281         (clear_proceed_status_thread): Update.
2282         (proceed): Update.
2283         (print_target_wait_results): Update.
2284         (do_target_wait): Update.
2285         (context_switch): Update.
2286         (stop_all_threads): Update.
2287         (restart_threads): Update.
2288         (finish_step_over): Update.
2289         (handle_signal_stop): Update.
2290         (switch_back_to_stepped_thread): Update.
2291         (keep_going_pass_signal): Update.
2292         (print_exited_reason): Update.
2293         (normal_stop): Update.
2294         * inferior.c (inferior_pid_to_str): Change return type.
2295         (print_selected_inferior): Update.
2296         (add_inferior): Update.
2297         (detach_inferior): Update.
2298         * dummy-frame.c (fprint_dummy_frames): Update.
2299         * dcache.c (dcache_info_1): Update.
2300         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
2301         (btrace_fetch, btrace_clear): Update.
2302         * linux-tdep.c (linux_core_pid_to_str): Change return type.
2303         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
2304         type.
2305         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
2306         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
2307         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
2308         * gdbarch.c, gdbarch.h: Rebuild.
2309         * gdbarch.sh (core_pid_to_str): Change return type.
2310         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
2311         return type.
2312         (windows_nat_target::pid_to_str): Change return type.
2313         (windows_delete_thread): Update.
2314         (windows_nat_target::attach): Update.
2315         (windows_nat_target::files_info): Update.
2316         * target-delegates.c: Rebuild.
2317         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
2318         return type.
2319         (sol_thread_target::pid_to_str): Change return type.
2320         * remote.c (class remote_target) <pid_to_str>: Change return
2321         type.
2322         (remote_target::pid_to_str): Change return type.
2323         (extended_remote_target::attach, remote_target::remote_stop_ns)
2324         (remote_target::remote_notif_remove_queued_reply)
2325         (remote_target::push_stop_reply, remote_target::disable_btrace):
2326         Update.
2327         (extended_remote_target::attach): Update.
2328         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
2329         type.
2330         (gdbsim_target::pid_to_str): Change return type.
2331         * ravenscar-thread.c (struct ravenscar_thread_target)
2332         <pid_to_str>: Change return type.
2333         (ravenscar_thread_target::pid_to_str): Change return type.
2334         * procfs.c (class procfs_target) <pid_to_str>: Change return
2335         type.
2336         (procfs_target::pid_to_str): Change return type.
2337         (procfs_target::attach): Update.
2338         (procfs_target::detach): Update.
2339         (procfs_target::fetch_registers): Update.
2340         (procfs_target::store_registers): Update.
2341         (procfs_target::wait): Update.
2342         (procfs_target::files_info): Update.
2343         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
2344         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
2345         return type.
2346         (nto_procfs_target::pid_to_str): Change return type.
2347         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
2348         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
2349         return type.
2350         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
2351         (exit_lwp): Update.
2352         (attach_proc_task_lwp_callback, get_detach_signal)
2353         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
2354         (linux_nat_target::resume, wait_lwp, stop_callback)
2355         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
2356         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
2357         (linux_nat_wait_1, resume_stopped_resumed_lwps)
2358         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
2359         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
2360         type.
2361         (inf_ptrace_target::attach): Update.
2362         (inf_ptrace_target::files_info): Update.
2363         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
2364         type.
2365         (go32_nat_target::pid_to_str): Change return type.
2366         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
2367         (gnu_nat_target::wait): Update.
2368         (gnu_nat_target::wait): Update.
2369         (gnu_nat_target::resume): Update.
2370         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
2371         (fbsd_nat_target::wait): Update.
2372         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
2373         type.
2374         (darwin_nat_target::attach): Update.
2375         * corelow.c (class core_target) <pid_to_str>: Change return type.
2376         (core_target::pid_to_str): Change return type.
2377         * target.c (normal_pid_to_str): Change return type.
2378         (default_pid_to_str): Likewise.
2379         (target_pid_to_str): Change return type.
2380         (target_translate_tls_address): Update.
2381         (target_announce_detach): Update.
2382         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
2383         return type.
2384         (bsd_uthread_target::pid_to_str): Change return type.
2385         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
2386         type.
2387         (bsd_kvm_target::pid_to_str): Change return type.
2388         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
2389         return type.
2390         (aix_thread_target::pid_to_str): Change return type.
2391         * target.h (struct target_ops) <pid_to_str>: Change return type.
2392         (target_pid_to_str, normal_pid_to_str): Likewise.
2393         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
2394         type.
2395         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
2396         type.
2397         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
2398         return type.
2399         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
2400         type.
2401         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
2402         type.
2403         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
2404         return type.
2405
2406 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
2407
2408         * NEWS: Mention that the new default MI version is 3.  Mention
2409         changes to the output of commands and events that deal with
2410         multi-location breakpoints.
2411         * breakpoint.c: Include "mi/mi-out.h".
2412         (print_one_breakpoint): Change output syntax if using MI version
2413         >= 3.
2414         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
2415         New.
2416         (mi_multi_location_breakpoint_output_fixed): New.
2417         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
2418         (mi_cmd_fix_multi_location_breakpoint_output): New.
2419         (mi_multi_location_breakpoint_output_fixed): New.
2420         * mi/mi-cmds.c (mi_cmds): Register command
2421         -fix-multi-location-breakpoint-output.
2422         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
2423         interpreter "mi".
2424
2425 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
2426
2427         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
2428         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
2429         instantiate mi_ui_out based on interpreter name.
2430         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
2431         * mi/mi-main.c (mi_load_progress): Likewise.
2432
2433 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2434
2435         * NEWS: Combine separate "New targets" sections for 8.3.
2436
2437 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2438
2439         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
2440         (ppcfbsd_init_abi): Install gdbarch
2441         "fetch_tls_load_module_address" and "get_thread_local_address"
2442         methods.
2443
2444 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2445
2446         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
2447         (riscv_fbsd_init_abi): Install gdbarch
2448         "fetch_tls_load_module_address" and "get_thread_local_address"
2449         methods.
2450
2451 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2452
2453         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
2454         (i386fbsd_init_abi): Install gdbarch
2455         "fetch_tls_load_module_address" and "get_thread_local_address"
2456         methods.
2457
2458 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2459
2460         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
2461         (amd64fbsd_init_abi): Install gdbarch
2462         "fetch_tls_load_module_address" and "get_thread_local_address"
2463         methods.
2464
2465 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2466
2467         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
2468         (struct fbsd_pspace_data): New type.
2469         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
2470         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
2471         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
2472         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
2473         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
2474
2475 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2476
2477         * gdbtypes.c (lookup_struct_elt): New function.
2478         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
2479         * gdbtypes.h (struct struct_elt): New type.
2480         (lookup_struct_elt): New prototype.
2481
2482 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2483
2484         * gdbtypes.c (lookup_struct_elt_type): Update comment and
2485         remove disabled code block.
2486
2487 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2488
2489         * gdbarch.sh (get_thread_local_address): New method.
2490         * gdbarch.h, gdbarch.c: Regenerate.
2491         * target.c (target_translate_tls_address): Use
2492         gdbarch_get_thread_local_address if present instead of
2493         target::get_thread_local_address.
2494
2495 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2496
2497         * target.h (target::get_thread_local_address): Update comment.
2498
2499 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2500
2501         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
2502         objfile->separate_debug_objfile_backlink if not NULL.
2503
2504 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2505
2506         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
2507         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
2508         (amd64bsd_store_inferior_registers): Likewise.
2509         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2510         Enable segment base registers.
2511         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
2512         PT_GETFSBASE and PT_GETGSBASE.
2513         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
2514         PT_SETGSBASE.
2515         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
2516         segment base registers.
2517         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2518
2519 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
2520
2521         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
2522         Update calls to i386_target_description to add 'segments'
2523         parameter.
2524         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
2525         add segment base registers.
2526         * arch/i386.c (i386_create_target_description): Add 'segments'
2527         parameter to enable segment base registers.
2528         * arch/i386.h (i386_create_target_description): Likewise.
2529         * features/i386/32bit-segments.xml: New file.
2530         * features/i386/32bit-segments.c: Generate.
2531         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
2532         call to i386_target_description to add 'segments' parameter.
2533         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
2534         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
2535         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
2536         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
2537         if feature is present.
2538         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
2539         Add 'segments' parameter to call to i386_target_description.
2540         (i386_target_description): Add 'segments' parameter to enable
2541         segment base registers.
2542         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
2543         to call to i386_target_description.
2544         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
2545         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
2546         Define I386_NUM_REGS.
2547         (i386_target_description): Add 'segments' parameter to enable
2548         segment base registers.
2549
2550 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
2551
2552         PR/24325
2553         * source-cache.c: #undef open and close, to avoid unresolved
2554         externals during linking.
2555
2556 2019-03-12  Tom Tromey  <tromey@adacore.com>
2557
2558         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
2559         const.  Add initializers.
2560         (_initialize_remote): Don't initialize ptid globals.
2561
2562 2019-03-12  Pedro Alves  <palves@redhat.com>
2563
2564         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
2565
2566 2019-03-12  Pedro Alves  <palves@redhat.com>
2567
2568         * cp-name-parser.y (main): Remove unused 'len' variable.
2569
2570 2019-03-12  Tom Tromey  <tromey@adacore.com>
2571
2572         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
2573         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
2574
2575 2019-03-12  Tom Tromey  <tromey@adacore.com>
2576
2577         * linux-nat.c (iterate_over_lwps): Update.
2578         (stop_callback): Remove parameter.
2579         (stop_wait_callback, detach_callback, resume_set_callback)
2580         (select_singlestep_lwp_callback, set_ignore_sigint)
2581         (status_callback, resumed_callback, resume_clear_callback)
2582         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
2583         data parameter.
2584         (linux_nat_target::detach, linux_nat_target::resume)
2585         (linux_stop_and_wait_all_lwps, select_event_lwp)
2586         (linux_nat_filter_event, linux_nat_wait_1)
2587         (linux_nat_target::kill, linux_nat_target::stop)
2588         (linux_nat_target::stop): Update.
2589         (linux_nat_resume_callback): Change type.
2590         (resume_stopped_resumed_lwps, count_events_callback)
2591         (select_event_lwp_callback): Likewise.
2592         (linux_stop_lwp, linux_nat_stop_lwp): Update.
2593         * arm-linux-nat.c (struct update_registers_data): Remove.
2594         (update_registers_callback): Change type.
2595         (arm_linux_insert_hw_breakpoint1): Update.
2596         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
2597         parameter.
2598         (x86_linux_dr_set_addr): Update.
2599         (x86_linux_dr_set_control): Update.
2600         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
2601         (iterate_over_lwps): Use gdb::function_view.
2602         * nat/aarch64-linux-hw-point.c (struct
2603         aarch64_dr_update_callback_param): Remove.
2604         (debug_reg_change_callback): Change type.
2605         (aarch64_notify_debug_reg_change): Update.
2606         * s390-linux-nat.c (s390_refresh_per_info): Update.
2607
2608 2019-03-11  Tom Tromey  <tromey@adacore.com>
2609
2610         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
2611         redundant assignment to "this_cu".
2612
2613 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2614
2615         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
2616
2617 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2618
2619         * gdbtypes.c (rank_one_type_parm_set): New function extracted
2620         from...
2621         (rank_one_type): ... this.
2622
2623 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2624
2625         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
2626         from...
2627         (rank_one_type): ... this.
2628
2629 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2630
2631         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
2632         from...
2633         (rank_one_type): ... this.
2634
2635 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2636
2637         * gdbtypes.c (rank_one_type_parm_float): New function extracted
2638         from...
2639         (rank_one_type): ... this.
2640
2641 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2642
2643         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
2644         from...
2645         (rank_one_type): ... this.
2646
2647 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2648
2649         * gdbtypes.c (rank_one_type_parm_range): New function extracted
2650         from...
2651         (rank_one_type): ... this.
2652
2653 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2654
2655         * gdbtypes.c (rank_one_type_parm_char): New function extracted
2656         from...
2657         (rank_one_type): ... this.
2658
2659 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2660
2661         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
2662         from...
2663         (rank_one_type): ... this.
2664
2665 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2666
2667         * gdbtypes.c (rank_one_type_parm_int): New function extracted
2668         from...
2669         (rank_one_type): ... this.
2670
2671 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2672
2673         * gdbtypes.c (rank_one_type_parm_func): New function extracted
2674         from...
2675         (rank_one_type): ... this.
2676
2677 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2678
2679         * gdbtypes.c (rank_one_type_parm_array): New function extracted
2680         from...
2681         (rank_one_type): ... this.
2682
2683 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
2684
2685         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
2686         from...
2687         (rank_one_type): ... this.
2688
2689 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2690
2691         * inferior.c (initialize_inferiors): Ensure 'help set/show print
2692         inferior-events' shows the example events.
2693
2694 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
2695
2696         Support styling on native MS-Windows console
2697
2698         PR/24315
2699         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
2700         on MS-Windows if $TERM is not defined.
2701
2702         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
2703
2704         * posix-hdep.c (gdb_console_fputs):
2705         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
2706         functions.
2707         * ui-file.h (gdb_console_fputs): Add prototype.
2708
2709         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
2710         back to fputs only if the former returns zero.
2711
2712 2019-03-07  Tom Tromey  <tom@tromey.com>
2713
2714         * symmisc.c (print_symbol_bcache_statistics): Update.
2715         (print_objfile_statistics): Update.
2716         * symfile.c (allocate_symtab): Update.
2717         * stabsread.c: Don't include bcache.h.
2718         * psymtab.h (struct psymbol_bcache): Don't declare.
2719         (class psymtab_storage) <psymbol_cache>: Now a bcache.
2720         (psymbol_bcache_init, psymbol_bcache_free)
2721         (psymbol_bcache_get_bcache): Don't declare.
2722         * psymtab.c (struct psymbol_bcache): Remove.
2723         (psymtab_storage::psymtab_storage): Update.
2724         (psymtab_storage::~psymtab_storage): Update.
2725         (psymbol_bcache_init, psymbol_bcache_free)
2726         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
2727         (add_psymbol_to_bcache): Update.
2728         (allocate_psymtab): Update.
2729         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
2730         macro_cache>: No longer pointers.
2731         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
2732         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
2733         * macrotab.c (macro_bcache): Update.
2734         * macroexp.c: Don't include bcache.h.
2735         * gdbtypes.c (check_types_worklist): Update.
2736         (types_deeply_equal): Remove TRY/CATCH.  Update.
2737         * elfread.c (elf_symtab_read): Update.
2738         * dwarf2read.c: Don't include bcache.h.
2739         * buildsym.c (buildsym_compunit::get_macro_table): Update.
2740         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
2741         (print_bcache_statistics, bcache_memory_used): Don't declare.
2742         (struct bcache): Move from bcache.c.  Add constructor, destructor,
2743         methods.  Rename all data members.
2744         * bcache.c (struct bcache): Move to bcache.h.
2745         (bcache::expand_hash_table): Rename from expand_hash_table.
2746         (bcache): Remove.
2747         (bcache::insert): Rename from bcache_full.
2748         (bcache::compare): Rename from bcache_compare.
2749         (bcache_xmalloc): Remove.
2750         (bcache::~bcache): Rename from bcache_xfree.
2751         (bcache::print_statistics): Rename from print_bcache_statistics.
2752         (bcache::memory_used): Rename from bcache_memory_used.
2753
2754 2019-03-07  Pedro Alves  <palves@redhat.com>
2755
2756         * infrun.c (normal_stop): Also check for
2757         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
2758
2759 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
2760
2761         * f-lang.c (value_from_host_double): Moved to...
2762         * value.c (value_from_host_double): ...here.
2763         * value.h (value_from_host_double): Declare.
2764         * guile/scm-math.c (vlscm_convert_typed_number): Use
2765         value_from_host_double.
2766         (vlscm_convert_number): Likewise.
2767         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
2768         * python/py-value.c (convert_value_from_python): Likewise.
2769
2770 2019-03-06  Tom Tromey  <tom@tromey.com>
2771
2772         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
2773
2774 2019-03-06  Tom Tromey  <tom@tromey.com>
2775
2776         * utils.h (free_current_contents): Don't declare.
2777         * utils.c (free_current_contents): Remove.
2778
2779 2019-03-06  Tom Tromey  <tom@tromey.com>
2780
2781         * top.c (quit_force): Update.
2782         * main.c (captured_command_loop): Update.
2783         * common/new-op.c (operator new): Update.
2784         * common/common-exceptions.c (struct catcher)
2785         <save_cleanup_chain>: Remove member.
2786         (exceptions_state_mc_init): Update.
2787         (exception_try_scope_entry): Return nullptr.
2788         (exception_try_scope_exit, exception_rethrow)
2789         (throw_exception_sjlj, throw_exception_cxx): Update.
2790         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
2791         (all_cleanups, do_cleanups, discard_cleanups)
2792         (discard_final_cleanups, save_cleanups, save_final_cleanups)
2793         (restore_cleanups, restore_final_cleanups): Don't declare.
2794         (do_final_cleanups): Remove parameter.
2795         * common/cleanups.c (cleanup_chain, make_cleanup)
2796         (make_cleanup_dtor, all_cleanups, do_cleanups)
2797         (discard_my_cleanups, discard_cleanups)
2798         (discard_final_cleanups, save_my_cleanups, save_cleanups)
2799         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
2800         (null_cleanup): Remove.
2801         (do_final_cleanups): Remove parameter.
2802
2803 2019-03-06  Tom Tromey  <tom@tromey.com>
2804
2805         * remote.c (remote_target::remote_parse_stop_reply): Use
2806         unique_xmalloc_ptr.
2807
2808 2019-03-06  Tom Tromey  <tom@tromey.com>
2809
2810         * stabsread.c (struct stabs_field_info): Rename from field_info.
2811         <list, fnlist>: Add initializers.
2812         <obstack>: New member.
2813         (read_member_functions, read_struct_fields, read_baseclasses):
2814         Allocate on obstack.  Don't use cleanups.
2815         (read_one_struct_field, read_member_functions, read_struct_fields)
2816         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
2817         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
2818         (read_struct_type): Update.
2819
2820 2019-03-06  Tom Tromey  <tom@tromey.com>
2821
2822         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
2823         * common/filestuff.h (make_cleanup_close): Don't declare.
2824         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
2825         Remove.
2826
2827 2019-03-06  Tom Tromey  <tom@tromey.com>
2828
2829         * solib-aix.c: Use make_scope_exit.
2830
2831 2019-03-06  Tom Tromey  <tom@tromey.com>
2832
2833         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
2834         Use make_scope_exit.
2835
2836 2019-03-06  Tom Tromey  <tom@tromey.com>
2837
2838         * solib-svr4.c (disable_probes_interface): Remove parameter.
2839         (svr4_handle_solib_event): Use make_scope_exit.
2840
2841 2019-03-06  Tom Tromey  <tom@tromey.com>
2842
2843         * remote.c (struct stop_reply_deleter): Remove.
2844         (stop_reply_up): Update.
2845         (struct stop_reply): Derive from notif_event.  Don't typedef.
2846         <regcache>: Now a std::vector.
2847         (stop_reply_xfree): Remove.
2848         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
2849         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
2850         (remote_target::discard_pending_stop_replies): Use delete.
2851         (remote_target::remote_parse_stop_reply): Update.
2852         (remote_target::process_stop_reply): Update.
2853         * remote-notif.h (struct notif_event): Add virtual destructor.
2854         Remove "dtr" member.
2855         (struct notif_client) <alloc_event>: Return a unique_ptr.
2856         (notif_event_xfree): Don't declare.
2857         (notif_event_up): New typedef.
2858         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
2859         (notif_event_xfree, do_notif_event_xfree): Remove.
2860         (remote_notif_state_xfree): Update.
2861
2862 2019-03-06  Tom Tromey  <tom@tromey.com>
2863
2864         * infrun.c (displaced_step_clear_cleanup): Now a
2865         forward_scope_exit type.
2866         (displaced_step_prepare_throw): Update.
2867         (displaced_step_fixup): Update.
2868
2869 2019-03-06  Tom Tromey  <tom@tromey.com>
2870
2871         * inferior.h (class inferior): Update comment.
2872         * gdbthread.h (class thread_info): Update comment.
2873
2874 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
2875             Tom Tromey  <tom@tromey.com>
2876
2877         * stabsread.h (struct stab_section_list): Remove.
2878         (coffstab_build_psymtabs): Update.
2879         * dbxread.c (symbuf_sections): Now a std::vector.
2880         (sect_idx): New global.
2881         (fill_symbuf): Update.
2882         (coffstab_build_psymtabs): Change type of stabsects parameter.
2883         Update.
2884         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
2885         std::vector.
2886         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
2887         (coff_locate_sections): Update.
2888         (coff_symfile_read): Remove cleanups.  Update.
2889         (init_stringtab): Add storage parameter.
2890         (free_stringtab, free_stringtab_cleanup): Remove.
2891         (init_lineno): Add storage parameter.
2892         (free_linetab, free_linetab_cleanup): Remove.
2893
2894 2019-03-06  Pedro Alves  <palves@redhat.com>
2895
2896         * linux-fork.c (fork_info::clobber_regs): Delete.
2897         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
2898         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
2899         comment.  Adjust.
2900         (scoped_switch_fork_info::scoped_switch_fork_info)
2901         (checkpoint_command, linux_fork_context): Adjust
2902         fork_save_infrun_state calls.
2903
2904 2019-03-06  Pedro Alves  <palves@redhat.com>
2905
2906         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
2907         (inf_has_multiple_threads): Return 'bool' and rewrite using
2908         inferior_info::threads().
2909
2910 2019-03-06  Pedro Alves  <palves@redhat.com>
2911
2912         * linux-fork.c: Include <list>.
2913         (fork_list): Now a std::list instance.
2914         (fork_info): Add ctor, dtor, and in-class initialize all fields.
2915         (forks_exist_p, find_last_fork): Adjust.
2916         (new_fork): Delete.
2917         (one_fork_p): New.
2918         (add_fork): Adjust.
2919         (free_fork): Delete, folded into fork_info::~fork_info().
2920         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
2921         Adjust.
2922         (init_fork_list): Delete.
2923         (linux_fork_killall, linux_fork_mourn_inferior)
2924         (linux_fork_detach, info_checkpoints_command): Adjust.
2925         (_initialize_linux_fork): No longer call init_fork_list.
2926
2927 2019-03-06  Pedro Alves  <palves@redhat.com>
2928
2929         * linux-fork.c (new_fork): New, split out of ...
2930         (add_fork): ... this.  Return void.  Move "first fork" special
2931         case from here, to ...
2932         (checkpoint_command): ... here.
2933         * linux-linux.h (add_fork): Return void.
2934
2935 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2936
2937         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
2938
2939 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2940             Chris January  <chris.january@arm.com>
2941             David Lecomber  <david.lecomber@arm.com>
2942
2943         * f-exp.y: New token, UNOP_INTRINSIC.
2944         (exp): New pattern using UNOP_INTRINSIC token.
2945         (f77_keywords): Add 'abs' keyword.
2946         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
2947         (value_from_host_double): New function.
2948         (evaluate_subexp_f): Support UNOP_ABS.
2949
2950 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
2953         types.
2954
2955 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2956
2957         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
2958         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
2959         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
2960
2961 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2962
2963         * f-exp.y (convert_to_kind_type): Handle more type kinds.
2964
2965 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2966             Chris January  <chris.january@arm.com>
2967
2968         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
2969         * f-exp.y: Define 'KIND' token.
2970         (exp): New pattern for KIND expressions.
2971         (ptype): Handle types with a kind extension.
2972         (direct_abs_decl): Extend to spot kind extensions.
2973         (f77_keywords): Add 'kind' to the list.
2974         (push_kind_type): New function.
2975         (convert_to_kind_type): New function.
2976         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
2977         * parse.c (operator_length_standard): Likewise.
2978         * parser-defs.h (enum type_pieces): Add tp_kind.
2979         * std-operator.def: Add UNOP_KIND.
2980
2981 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2982
2983         * f-exp.y (f_parse): Set yydebug.
2984
2985 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2986
2987         * f-lang.c (evaluate_subexp_f): New function.
2988         (exp_descriptor_f): New global.
2989         (f_language_defn): Use exp_descriptor_f instead of
2990         exp_descriptor_standard.
2991
2992 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
2993
2994         * f-exp.y (struct token): Add comments.
2995         (dot_ops): Remove uppercase versions and the end marker.
2996         (f77_keywords): Likewise.
2997         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
2998         entries in the dot_ops array are case insensitive, and use
2999         strncasecmp to compare strings.  Also some whitespace cleanup in
3000         this area.  Similar for the f77_keywords array, except entries in
3001         this list might be case sensitive.
3002
3003 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3004
3005         * f-exp.y (struct f77_boolean_val): Add comments.
3006         (boolean_values): Remove uppercase versions, and end marker.
3007         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
3008         and use strncasecmp to achieve case insensitivity.  Additionally,
3009         perform whitespace cleanup around this code.
3010
3011 2019-03-06  Tom Tromey  <tromey@adacore.com>
3012
3013         * remote-sim.c (gdbsim_target_open): Use result of
3014         gdb_argv::release.
3015
3016 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
3017         Dirk Schubert  <dirk.schubert@arm.com>
3018         Chris January  <chris.january@arm.com>
3019
3020         * eval.c (evaluate_subexp_standard): Call Fortran argument
3021         wrapping logic.
3022         * f-lang.c (struct value): A value which can be passed into a
3023         Fortran function call.
3024         (fortran_argument_convert): Wrap Fortran arguments in a pointer
3025         where appropriate.
3026         (struct type): Value ready for a Fortran function call.
3027         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
3028         is needed.
3029         * f-lang.h (fortran_argument_convert): Declaration.
3030         (fortran_preserve_arg_pointer): Declaration.
3031         * infcall.c (value_arg_coerce): Call Fortran argument logic.
3032
3033 2019-03-05  Tom Tromey  <tromey@adacore.com>
3034
3035         * python/py-prettyprint.c (print_string_repr): Remove #if.
3036         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
3037
3038 2019-03-05  Tom Tromey  <tromey@adacore.com>
3039
3040         * target.c (the_dummy_target): Move later.  Change type to
3041         "dummy_target".
3042         (initialize_targets): Don't initialize the_dummy_target.
3043
3044 2019-03-05  Tom Tromey  <tromey@adacore.com>
3045
3046         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
3047         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
3048
3049 2019-03-05  Tom Tromey  <tromey@adacore.com>
3050
3051         * windows-nat.c (windows_nat_target::attach)
3052         (windows_nat_target::detach): Don't call gdb_flush.
3053         * valprint.c (generic_val_print, val_print, val_print_string):
3054         Don't call gdb_flush.
3055         * utils.c (defaulted_query): Don't call gdb_flush.
3056         * typeprint.c (print_type_scalar): Don't call gdb_flush.
3057         * target.c (target_announce_detach): Don't call gdb_flush.
3058         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
3059         * remote.c (extended_remote_target::attach): Don't call
3060         gdb_flush.
3061         * procfs.c (procfs_target::detach): Don't call gdb_flush.
3062         * printcmd.c (do_examine): Don't call gdb_flush.
3063         (info_display_command): Don't call gdb_flush.
3064         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
3065         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
3066         * memattr.c (info_mem_command): Don't call gdb_flush.
3067         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
3068         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
3069         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
3070         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
3071         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
3072         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
3073         (gnu_nat_target::detach): Don't call gdb_flush.
3074         * f-valprint.c (f_val_print): Don't call gdb_flush.
3075         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
3076         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
3077         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
3078         gdb_flush.
3079         * c-valprint.c (c_val_print): Don't call gdb_flush.
3080         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
3081
3082 2019-03-05  Tom Tromey  <tromey@adacore.com>
3083
3084         * varobj.c (update_dynamic_varobj_children): Update.
3085         (install_default_visualizer): Use reset, not release.
3086         * value.c (set_internalvar): Update.
3087         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
3088         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
3089         ATTRIBUTE_UNUSED_RESULT.
3090
3091 2019-03-05  Tom Tromey  <tromey@adacore.com>
3092
3093         * remote.c (class scoped_remote_fd) <release>: Add
3094         ATTRIBUTE_UNUSED_RESULT.
3095
3096 2019-03-05  Tom Tromey  <tromey@adacore.com>
3097
3098         * macroexp.c (struct macro_buffer) <release>: Add
3099         ATTRIBUTE_UNUSED_RESULT.
3100
3101 2019-03-05  Tom Tromey  <tromey@adacore.com>
3102
3103         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
3104         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
3105         ATTRIBUTE_UNUSED_RESULT.
3106
3107 2019-03-05  Tom Tromey  <tromey@adacore.com>
3108
3109         * common/scoped_fd.h (class scoped_fd) <release>: Add
3110         ATTRIBUTE_UNUSED_RESULT.
3111
3112 2019-03-05  Tom Tromey  <tromey@adacore.com>
3113
3114         * parser-defs.h (struct parser_state) <release>: Add
3115         ATTRIBUTE_UNUSED_RESULT.
3116
3117 2019-03-05  Tom Tromey  <tromey@adacore.com>
3118
3119         * utils.h (class gdb_argv) <release>: Add
3120         ATTRIBUTE_UNUSED_RESULT.
3121         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
3122
3123 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
3124
3125         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
3126         for-loop range, to avoid compiler warnings.
3127
3128         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
3129         avoid compiler warnings about unused variables.
3130
3131         * NEWS: Mention end of support for native debugging on MS-Windows
3132         before XP.
3133
3134         PR gdb/24292
3135         * common/netstuff.c:
3136         * gdbserver/gdbreplay.c
3137         * gdbserver/remote-utils.c:
3138         * ser-tcp.c:
3139         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
3140         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
3141         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
3142         'getaddrinfo' and 'freeaddrinfo' were not available before
3143         Windows XP, and mingw.org's MinGW headers by default define
3144         _WIN32_WINNT to 0x500.
3145
3146 2019-03-01  Gary Benson <gbenson@redhat.com>
3147
3148         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
3149
3150 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
3151             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
3152
3153         PR gdb/8527
3154         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
3155         set_sigint_trap, clear_sigint_trap.
3156
3157 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3158
3159         * target.c (target_detach): Clear the regcache and the
3160         frame cache.
3161
3162 2019-02-27  Pedro Alves  <palves@redhat.com>
3163
3164         * utils.c (set_screen_size): When we cap the height/width sizes,
3165         tweak the corresponding command variable to show "unlimited":
3166
3167 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
3168             Pedro Alves  <palves@redhat.com>
3169
3170         * utils.c (set_screen_size): Reduce "infinite" rows and columns
3171         before calling rl_set_screen_size.
3172
3173 2019-02-27  Tom Tromey  <tromey@adacore.com>
3174
3175         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
3176         define.
3177         * python/py-value.c: Remove Python 2.4 workaround.
3178         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
3179         workaround.
3180         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
3181         Python 2.4 workaround.
3182         * python/python-internal.h: Remove Python 2.4 comment.
3183         (Py_ssize_t): Don't define.
3184         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
3185         (gdb_Py_DECREF): Remove Python 2.4 workaround.
3186         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
3187         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
3188         * python/python.c (do_start_initialization): Remove Python 2.4
3189         workaround.
3190         * python/py-prettyprint.c (class dummy_python_frame): Remove.
3191         (print_children): Remove Python 2.4 workaround.
3192         * python/py-inferior.c (buffer_procs): Remove Python 2.4
3193         workaround.
3194         (CHARBUFFERPROC_NAME): Remove.
3195         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
3196         Python 2.4 workaround.
3197
3198 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3199
3200         * NEWS: Note minimum Python version.
3201
3202 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
3203
3204         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
3205         code from these functions.  Remove corresponding ifdefs.  Use
3206         Py_buffer_up instead of explicit calls to PyBuffer_Release.
3207         Remove gotos and target of gotos.
3208         (infpy_search_memory): Likewise.
3209
3210 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3211
3212         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
3213         (hppa_gdbarch_init): Don't register deleted functions with
3214         gdbarch.
3215
3216 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3217
3218         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
3219         (h8300_unwind_sp): Delete.
3220         (h8300_dummy_id): Delete.
3221         (h8300_gdbarch_init): Don't register deleted functions with
3222         gdbarch.
3223
3224 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3225
3226         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
3227         (ft32_unwind_pc): Delete.
3228         (ft32_unwind_sp): Delete.
3229         (ft32_gdbarch_init): Don't register deleted functions with
3230         gdbarch.
3231
3232 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3233
3234         * gdb/frv-tdep.c (frv_dummy_id): Delete.
3235         (frv_unwind_pc): Delete.
3236         (frv_unwind_sp): Delete.
3237         (frv_gdbarch_init): Don't register deleted functions with
3238         gdbarch.
3239
3240 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3241
3242         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
3243         (riscv_unwind_pc): Delete.
3244         (riscv_unwind_sp): Delete.
3245         (riscv_gdbarch_init): Don't register deleted functions with
3246         gdbarch.
3247
3248 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3249
3250         * gdb/csky-tdep.c (csky_dummy_id): Delete.
3251         (csky_unwind_pc): Delete.
3252         (csky_unwind_sp): Delete.
3253         (csky_gdbarch_init): Don't register deleted functions with
3254         gdbarch.
3255
3256 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3257
3258         * gdb/cris-tdep.c (cris_dummy_id): Delete.
3259         (cris_unwind_pc): Delete.
3260         (cris_unwind_sp): Delete.
3261         (cris_gdbarch_init): Don't register deleted functions with
3262         gdbarch.
3263
3264 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3265
3266         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
3267         (bfin_unwind_pc): Delete.
3268         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
3269
3270 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3271
3272         * gdb/arm-tdep.c (arm_dummy_id): Delete.
3273         (arm_unwind_pc): Delete.
3274         (arm_unwind_sp): Delete.
3275         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
3276
3277 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3278
3279         * gdb/arc-tdep.c (arc_dummy_id): Delete.
3280         (arc_unwind_pc): Delete.
3281         (arc_unwind_sp): Delete.
3282         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
3283
3284 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3285
3286         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
3287         (alpha_unwind_pc): Delete.
3288         (alpha_gdbarch_init): Don't register deleted functions with
3289         gdbarch.
3290
3291 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3292
3293         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
3294         (aarch64_unwind_pc): Delete.
3295         (aarch64_unwind_sp): Delete.
3296         (aarch64_gdbarch_init): Don't register deleted functions with
3297         gdbarch.
3298
3299 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3300
3301         * gdbtypes.c (type_align): Don't consider static members when
3302         computing structure alignment.
3303
3304 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3305
3306         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
3307         return 0 for other types.
3308         * arch-utils.c (default_type_align): Always return 0.
3309         * gdbarch.h: Regenerate.
3310         * gdbarch.sh (type_align): Extend comment.
3311         * gdbtypes.c (type_align): Add additional comments, always call
3312         gdbarch_type_align before applying the default rules.
3313         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
3314         generic code will then apply a suitable default.
3315         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
3316         types, return 0 for other types.
3317
3318 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3319
3320         * NEWS: Create a new section for the next release branch.
3321         Rename the section of the current branch, now that it has
3322         been cut.
3323
3324 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
3325
3326         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
3327         * version.in: Bump version to 8.3.50.DATE-git.
3328
3329 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
3330
3331         * aix-thread.c (ptid_cmp): Remove unused variable.
3332         (get_signaled_thread): Likewise.
3333         (store_regs_user_thread): Likewise.
3334         (store_regs_kernel_thread): Likewise.
3335         (fetch_regs_kernel_thread): Remove shadowed variable.
3336
3337 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3338
3339         * features/riscv/32bit-cpu.xml: Add register numbers.
3340         * features/riscv/32bit-fpu.c: Regenerate.
3341         * features/riscv/32bit-fpu.xml: Add register numbers.
3342         * features/riscv/64bit-cpu.xml: Add register numbers.
3343         * features/riscv/64bit-fpu.c: Regenerate.
3344         * features/riscv/64bit-fpu.xml: Add register numbers.
3345
3346 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
3347
3348         * NEWS: Mention two argument form of gdb.Value constructor.
3349         * python/py-value.c (convert_buffer_and_type_to_value): New
3350         function.
3351         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
3352         Add support for handling an optional second argument.  Call
3353         convert_buffer_and_type_to_value as appropriate.
3354         * python/python-internal.h (Py_buffer_deleter): New struct.
3355         (Py_buffer_up): New typedef.
3356
3357 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
3358
3359         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
3360         instead of releasing ownership.
3361
3362 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
3363
3364         * dwarf2read.c (open_and_init_dwp_file): Call
3365         elf_numsections instead of bfd_count_sections to initialize
3366         dwp_file->num_sections.
3367
3368 2019-02-25  Tom Tromey  <tromey@adacore.com>
3369
3370         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
3371
3372 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
3373
3374         * gcore.in: Add '--readnever' option when invoking GDB.
3375
3376 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3377
3378         * MAINTAINERS: Update my email address.
3379
3380 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
3381
3382         * build-id.c (build_id_to_debug_bfd_1): New function.
3383         (build_id_to_debug_bfd): Look for separate debug file in
3384         sysroot.
3385
3386 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3387
3388         * gdbarch.sh: Update the copyright year range that is placed into
3389         generated files.
3390
3391 2019-02-22  Keith Seitz  <keiths@redhat.com>
3392
3393         PR symtab/23853
3394         * linespec.c (create_sals_line_offset): Search for the default
3395         symtab's filename instead of its fullname.
3396
3397 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3398
3399         * NEWS: Update style defaults.
3400
3401 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
3402
3403         * main.c (captured_main_1): Disable styling in batch mode.
3404
3405 2019-02-20  Tom Tromey  <tom@tromey.com>
3406
3407         * symtab.c (symtab_symbol_info): Fix typos.
3408
3409 2019-02-20  Tom Tromey  <tromey@adacore.com>
3410
3411         * findcmd.c (_initialize_mem_search): Use upper case for
3412         metasyntactic variables.
3413
3414 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
3415
3416         * aarch64-tdep.c (aarch64_add_reggroups): New function.
3417         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
3418
3419 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
3420
3421         * top.h (source_file_name): Change to std::string.
3422         * top.c (source_file_name): Likewise.
3423         (command_line_input): Adjust.
3424         * cli/cli-script.c (script_from_file): Adjust.
3425
3426 2019-02-19  Tom Tromey  <tromey@adacore.com>
3427
3428         * ravenscar-thread.c
3429         (ravenscar_thread_target::update_thread_list): Don't call
3430         ada_build_task_list.
3431         * ada-lang.h (ada_build_task_list): Don't declare.
3432         * ada-tasks.c (struct ada_tasks_inferior_data)
3433         <task_list_valid_p>: Now bool.
3434         (read_known_tasks, ada_task_list_changed)
3435         (ada_tasks_invalidate_inferior_data): Update.
3436         (read_known_tasks_array): Return bool.
3437         (read_known_tasks_list): Likewise.
3438         (read_known_tasks): Return void.
3439         (ada_build_task_list): Now static.
3440
3441 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
3442
3443         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
3444         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
3445
3446 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3447
3448         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
3449         variant for ada_tasks_pspace_data_handle and
3450         ada_tasks_inferior_data_handle.
3451         (ada_tasks_pspace_data_cleanup): New function.
3452         (ada_tasks_inferior_data_cleanup): New function.
3453
3454 2019-02-17  Tom Tromey  <tom@tromey.com>
3455
3456         * macrotab.h (macro_source_fullname): Return a std::string.
3457         * macrotab.c (macro_include, check_for_redefinition)
3458         (macro_undef, macro_lookup_definition, foreach_macro)
3459         (foreach_macro_in_scope): Update.
3460         (macro_source_fullname): Return a std::string.
3461         * macrocmd.c (show_pp_source_pos): Update.
3462
3463 2019-02-17  Tom Tromey  <tom@tromey.com>
3464
3465         * macrocmd.c (show_pp_source_pos): Style the file names.
3466
3467 2019-02-17  Tom Tromey  <tom@tromey.com>
3468
3469         PR tui/24197:
3470         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
3471
3472 2019-02-17  Tom Tromey  <tom@tromey.com>
3473
3474         * ada-lang.c (user_select_syms): Use filtered printing.
3475         * utils.c (wrap_style): New global.
3476         (desired_style): Remove.
3477         (emit_style_escape): Add stream parameter.
3478         (set_output_style, reset_terminal_style, prompt_for_continue):
3479         Update.
3480         (flush_wrap_buffer): Only flush gdb_stdout.
3481         (wrap_here): Set wrap_style.
3482         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
3483         treat escape sequences as a character.  Change when wrap buffer is
3484         flushed.
3485         (fputs_styled): Do not set the output style when the default is
3486         requested.
3487         * ui-style.h (struct ui_file_style) <is_default>: New method.
3488         * source.c (print_source_lines_base): Emit escape sequences in one
3489         piece.
3490
3491 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3492
3493         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
3494         integers and enumeration types.
3495
3496 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
3497
3498         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
3499         instead of lookup_symbol_in_language
3500         (do_exact_match): New function.
3501         (ada_get_symbol_name_matcher): Return do_exact_match when
3502         doing a verbatim match.
3503
3504 2019-02-15  Tom Tromey  <tromey@adacore.com>
3505
3506         * ravenscar-thread.c (ravenscar_thread_target::resume)
3507         (ravenscar_thread_target::wait): Special case wildcard requests.
3508
3509 2019-02-15  Tom Tromey  <tromey@adacore.com>
3510
3511         * ravenscar-thread.c (base_ptid): Remove.
3512         (struct ravenscar_thread_target) <close>: New method.
3513         <m_base_ptid>: New member.
3514         <update_inferior_ptid, active_task, task_is_currently_active,
3515         runtime_initialized>: Declare methods.
3516         <ravenscar_thread_target>: Add constructor.
3517         (ravenscar_thread_target::task_is_currently_active)
3518         (ravenscar_thread_target::update_inferior_ptid)
3519         (ravenscar_runtime_initialized): Rename.  Now methods.
3520         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
3521         (ravenscar_thread_target::update_thread_list): Update.
3522         (ravenscar_thread_target::active_task): Now method.
3523         (ravenscar_thread_target::store_registers)
3524         (ravenscar_thread_target::prepare_to_store)
3525         (ravenscar_thread_target::prepare_to_store)
3526         (ravenscar_thread_target::mourn_inferior): Update.
3527         (ravenscar_inferior_created): Use "new" to create target.
3528         (ravenscar_thread_target::get_ada_task_ptid): Update.
3529         (_initialize_ravenscar): Don't initialize base_ptid.
3530         (ravenscar_ops): Remove global.
3531
3532 2019-02-15  Tom Tromey  <tromey@adacore.com>
3533
3534         * target.h (push_target): Declare new overload.
3535         * target.c (push_target): New overload, taking an rvalue reference.
3536         * remote.c (remote_target::open_1): Use push_target overload.
3537         * corelow.c (core_target_open): Use push_target overload.
3538
3539 2019-02-15  Tom Tromey  <tromey@adacore.com>
3540
3541         * ravenscar-thread.c (is_ravenscar_task)
3542         (ravenscar_task_is_currently_active): Return bool.
3543         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
3544         (_initialize_ravenscar): Remove "(void)".
3545         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
3546         Return bool.
3547
3548 2019-02-15  Tom Tromey  <tromey@adacore.com>
3549
3550         * ravenscar-thread.c (ravenscar_runtime_initializer)
3551         (has_ravenscar_runtime, get_running_thread_id)
3552         (ravenscar_thread_target::resume): Fix indentation.
3553
3554 2019-02-15  Tom Tromey  <tromey@adacore.com>
3555
3556         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
3557         from ravenscar_arch_ops.
3558         (sparc_ravenscar_ops::fetch_registers)
3559         (sparc_ravenscar_ops::store_registers): Now methods.
3560         (sparc_ravenscar_prepare_to_store): Remove.
3561         (sparc_ravenscar_ops): Redefine.
3562         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
3563         methods and destructor.  Remove members.
3564         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
3565         (ravenscar_thread_target::store_registers)
3566         (ravenscar_thread_target::prepare_to_store): Update.
3567         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
3568         Remove.
3569         (struct ppc_ravenscar_powerpc_ops): Derive from
3570         ravenscar_arch_ops.
3571         (ppc_ravenscar_powerpc_ops::fetch_registers)
3572         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
3573         (ppc_ravenscar_powerpc_ops): Redefine.
3574         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
3575         (ppc_ravenscar_e500_ops::fetch_registers)
3576         (ppc_ravenscar_e500_ops::store_registers): Now methods.
3577         (ppc_ravenscar_e500_ops): Redefine.
3578         * aarch64-ravenscar-thread.c
3579         (aarch64_ravenscar_generic_prepare_to_store): Remove.
3580         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
3581         (aarch64_ravenscar_fetch_registers)
3582         (aarch64_ravenscar_store_registers): Now methods.
3583         (aarch64_ravenscar_ops): Redefine.
3584
3585 2019-02-15  Tom Tromey  <tromey@adacore.com>
3586
3587         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
3588         (ravenscar_thread_target::stopped_by_hw_breakpoint)
3589         (ravenscar_thread_target::stopped_by_watchpoint)
3590         (ravenscar_thread_target::stopped_data_address)
3591         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
3592
3593 2019-02-15  Tom Tromey  <tromey@adacore.com>
3594
3595         * ravenscar-thread.c: Fix some typos.
3596
3597 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3598             Tom Tromey  <tromey@adacore.com>
3599
3600         * ada-lang.c (ada_exception_sal): Change addr_string to a
3601         std::string.
3602         (create_ada_exception_catchpoint): Update.
3603
3604 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3605             Tom Tromey  <tromey@adacore.com>
3606
3607         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
3608         (bp_location_ops): Remove.
3609         (base_breakpoint_allocate_location): Update.
3610         (free_bp_location): Update.
3611         * ada-lang.c (class ada_catchpoint_location)
3612         <ada_catchpoint_location>: Remove ops parameter.
3613         (ada_catchpoint_location_dtor): Remove.
3614         (ada_catchpoint_location_ops): Remove.
3615         (allocate_location_exception): Update.
3616         * breakpoint.h (struct bp_location_ops): Remove.
3617         (class bp_location) <bp_location>: Remove bp_location_ops
3618         parameter.
3619         <~bp_location>: Add destructor.
3620         <ops>: Remove.
3621
3622 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3623             Pedro Alves  <palves@redhat.com>
3624
3625         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
3626         'PATH_MAX'.
3627
3628 2019-02-14  David Michael  <fedora.dm0@gmail.com>
3629             Samuel Thibault  <samuel.thibault@gnu.org>
3630             Thomas Schwinge  <thomas@codesourcery.com>
3631
3632         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
3633         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
3634
3635 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
3636
3637         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
3638         (check_empty): Use "const char *".
3639
3640         * gnu-nat.c (gnu_nat_target::detach): Instead of
3641         'detach_inferior (pid)' call
3642         'detach_inferior (find_inferior_pid (pid))'.
3643
3644         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
3645         'nat/fork-inferior.o'.
3646         * gnu-nat.c: #include "nat/fork-inferior.h".
3647
3648         * gnu-nat.c (gnu_nat_target::detach): Instead of
3649         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
3650         * gnu-nat.h: #include "inf-child.h".
3651         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
3652         'i386_gnu_nat_target::fetch_registers'.
3653         (gnu_store_registers): Rename/move to
3654         'i386_gnu_nat_target::store_registers'.
3655
3656         * config/i386/nm-i386gnu.h: Don't "#include" any files.
3657         * gnu-nat.h (mach_thread_info): New function.
3658         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
3659
3660         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
3661
3662 2019-02-14  Frederic Konrad  <konrad@adacore.com>
3663
3664         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
3665
3666 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
3667
3668         * windows-nat.c (windows_add_thread): Add new parameter
3669         "main_thread_p" with default value set to false.  Update
3670         function documentation as well as all callers.
3671         (windows_delete_thread): Likewise.
3672         (fake_create_process): Update call to windows_add_thread.
3673         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
3674         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
3675         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
3676         call to windows_delete_thread.
3677
3678 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
3679
3680         * MAINTAINERS: Add Andrew Burgess as global maintainer.
3681
3682 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3683
3684         * symfile.c (find_separate_debug_file): Use canonical path of
3685         sysroot with child_path instead of gdb_sysroot if it is valid.
3686
3687 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3688
3689         * symfile.c (find_separate_debug_file): Use child_path to
3690         determine if an object file is under a sysroot.
3691
3692 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3693
3694         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
3695         unittests/child-path-selftests.c.
3696         * common/pathstuff.c (child_path): New function.
3697         * common/pathstuff.h (child_path): New prototype.
3698         * unittests/child-path-selftests.c: New file.
3699
3700 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
3701
3702         * symfile.c (find_separate_debug_file): Look for separate debug
3703         files in debug directories under the sysroot.
3704
3705 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3706
3707         * symtab.h (struct minimal_symbol data_p): New const method.
3708         (struct minimal_symbol text_p): Likewise.
3709         * symtab.c (output_source_filename): Use file name style
3710         to print file name.
3711         (print_symbol_info): Likewise.
3712         (print_msymbol_info): Use address style to print addresses.
3713         Use function name style to print executable text symbols.
3714         (expand_symtab_containing_pc): Use data_p.
3715         (find_pc_sect_compunit_symtab): Likewise.
3716
3717 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3718
3719         * breakpoint.c (describe_other_breakpoints): Use address style
3720         to print addresses.
3721         (say_where): Likewise.
3722
3723 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3724
3725         * ada-typeprint.c (print_func_type): Print function name
3726         style to print function name.
3727         * c-typeprint.c (c_print_type_1): Likewise.
3728
3729 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
3730
3731         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
3732         for execve.
3733
3734 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3735
3736         * c-exp.y (direct_abs_decl): Use emplace_back to record the
3737         type_stack.
3738
3739 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
3740
3741         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
3742         TYPE_CODE_REF types.
3743
3744 2019-02-08  Jim Wilson  <jimw@sifive.com>
3745
3746         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
3747         (riscv_linux_fregset): New.
3748         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
3749
3750 2019-02-07  Tom Tromey  <tom@tromey.com>
3751
3752         * thread.c (thread_cancel_execution_command): Update.
3753         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
3754         methods.
3755         (struct thread_fsm_ops): Remove.
3756         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
3757         (thread_fsm_should_stop, thread_fsm_return_value)
3758         (thread_fsm_set_finished, thread_fsm_finished_p)
3759         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
3760         Don't declare.
3761         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
3762         * infrun.c (clear_proceed_status_thread)
3763         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
3764         (print_stop_event): Update.
3765         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
3766         Add constructor.
3767         (step_command_fsm_ops): Remove.
3768         (new_step_command_fsm): Remove.
3769         (step_1): Update.
3770         (step_command_fsm::should_stop): Rename from
3771         step_command_fsm_should_stop.
3772         (step_command_fsm::clean_up): Rename from
3773         step_command_fsm_clean_up.
3774         (step_command_fsm::do_async_reply_reason): Rename from
3775         step_command_fsm_async_reply_reason.
3776         (struct until_next_fsm): Inherit from thread_fsm.  Add
3777         constructor.
3778         (until_next_fsm_ops): Remove.
3779         (new_until_next_fsm): Remove.
3780         (until_next_fsm::should_stop): Rename from
3781         until_next_fsm_should_stop.
3782         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
3783         (until_next_fsm::do_async_reply_reason): Rename from
3784         until_next_fsm_async_reply_reason.
3785         (struct finish_command_fsm): Inherit from thread_fsm.  Add
3786         constructor.  Change type of breakpoint.
3787         (finish_command_fsm_ops): Remove.
3788         (new_finish_command_fsm): Remove.
3789         (finish_command_fsm::should_stop): Rename from
3790         finish_command_fsm_should_stop.
3791         (finish_command_fsm::clean_up): Rename from
3792         finish_command_fsm_clean_up.
3793         (finish_command_fsm::return_value): Rename from
3794         finish_command_fsm_return_value.
3795         (finish_command_fsm::do_async_reply_reason): Rename from
3796         finish_command_fsm_async_reply_reason.
3797         (finish_command): Update.
3798         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
3799         Add constructor.
3800         (call_thread_fsm_ops): Remove.
3801         (call_thread_fsm::call_thread_fsm): Rename from
3802         new_call_thread_fsm.
3803         (call_thread_fsm::should_stop): Rename from
3804         call_thread_fsm_should_stop.
3805         (call_thread_fsm::should_notify_stop): Rename from
3806         call_thread_fsm_should_notify_stop.
3807         (run_inferior_call, call_function_by_hand_dummy): Update.
3808         * cli/cli-interp.c (should_print_stop_to_console): Update.
3809         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
3810         Add constructor.  Change type of location_breakpoint,
3811         caller_breakpoint.
3812         (until_break_fsm_ops): Remove.
3813         (new_until_break_fsm): Remove.
3814         (until_break_fsm::should_stop): Rename from
3815         until_break_fsm_should_stop.
3816         (until_break_fsm::clean_up): Rename from
3817         until_break_fsm_clean_up.
3818         (until_break_fsm::do_async_reply_reason): Rename from
3819         until_break_fsm_async_reply_reason.
3820         (until_break_command): Update.
3821         * thread-fsm.c: Remove.
3822         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
3823
3824 2019-02-07  Tom Tromey  <tom@tromey.com>
3825
3826         * yy-remap.h: Add include guard.
3827         * xtensa-tdep.h: Add include guard.
3828         * xcoffread.h: Rename include guard.
3829         * varobj-iter.h: Add include guard.
3830         * tui/tui.h: Rename include guard.
3831         * tui/tui-winsource.h: Rename include guard.
3832         * tui/tui-wingeneral.h: Rename include guard.
3833         * tui/tui-windata.h: Rename include guard.
3834         * tui/tui-win.h: Rename include guard.
3835         * tui/tui-stack.h: Rename include guard.
3836         * tui/tui-source.h: Rename include guard.
3837         * tui/tui-regs.h: Rename include guard.
3838         * tui/tui-out.h: Rename include guard.
3839         * tui/tui-layout.h: Rename include guard.
3840         * tui/tui-io.h: Rename include guard.
3841         * tui/tui-hooks.h: Rename include guard.
3842         * tui/tui-file.h: Rename include guard.
3843         * tui/tui-disasm.h: Rename include guard.
3844         * tui/tui-data.h: Rename include guard.
3845         * tui/tui-command.h: Rename include guard.
3846         * tic6x-tdep.h: Add include guard.
3847         * target/waitstatus.h: Rename include guard.
3848         * target/wait.h: Rename include guard.
3849         * target/target.h: Rename include guard.
3850         * target/resume.h: Rename include guard.
3851         * target-float.h: Rename include guard.
3852         * stabsread.h: Add include guard.
3853         * rs6000-tdep.h: Add include guard.
3854         * riscv-fbsd-tdep.h: Add include guard.
3855         * regformats/regdef.h: Rename include guard.
3856         * record.h: Rename include guard.
3857         * python/python.h: Rename include guard.
3858         * python/python-internal.h: Rename include guard.
3859         * python/py-stopevent.h: Rename include guard.
3860         * python/py-ref.h: Rename include guard.
3861         * python/py-record.h: Rename include guard.
3862         * python/py-record-full.h: Rename include guard.
3863         * python/py-record-btrace.h: Rename include guard.
3864         * python/py-instruction.h: Rename include guard.
3865         * python/py-events.h: Rename include guard.
3866         * python/py-event.h: Rename include guard.
3867         * procfs.h: Add include guard.
3868         * proc-utils.h: Add include guard.
3869         * p-lang.h: Add include guard.
3870         * or1k-tdep.h: Rename include guard.
3871         * observable.h: Rename include guard.
3872         * nto-tdep.h: Rename include guard.
3873         * nat/x86-linux.h: Rename include guard.
3874         * nat/x86-linux-dregs.h: Rename include guard.
3875         * nat/x86-gcc-cpuid.h: Add include guard.
3876         * nat/x86-dregs.h: Rename include guard.
3877         * nat/x86-cpuid.h: Rename include guard.
3878         * nat/ppc-linux.h: Rename include guard.
3879         * nat/mips-linux-watch.h: Rename include guard.
3880         * nat/linux-waitpid.h: Rename include guard.
3881         * nat/linux-ptrace.h: Rename include guard.
3882         * nat/linux-procfs.h: Rename include guard.
3883         * nat/linux-osdata.h: Rename include guard.
3884         * nat/linux-nat.h: Rename include guard.
3885         * nat/linux-namespaces.h: Rename include guard.
3886         * nat/linux-btrace.h: Rename include guard.
3887         * nat/glibc_thread_db.h: Rename include guard.
3888         * nat/gdb_thread_db.h: Rename include guard.
3889         * nat/gdb_ptrace.h: Rename include guard.
3890         * nat/fork-inferior.h: Rename include guard.
3891         * nat/amd64-linux-siginfo.h: Rename include guard.
3892         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
3893         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
3894         * nat/aarch64-linux.h: Rename include guard.
3895         * nat/aarch64-linux-hw-point.h: Rename include guard.
3896         * mn10300-tdep.h: Add include guard.
3897         * mips-linux-tdep.h: Add include guard.
3898         * mi/mi-parse.h: Rename include guard.
3899         * mi/mi-out.h: Rename include guard.
3900         * mi/mi-main.h: Rename include guard.
3901         * mi/mi-interp.h: Rename include guard.
3902         * mi/mi-getopt.h: Rename include guard.
3903         * mi/mi-console.h: Rename include guard.
3904         * mi/mi-common.h: Rename include guard.
3905         * mi/mi-cmds.h: Rename include guard.
3906         * mi/mi-cmd-break.h: Rename include guard.
3907         * m2-lang.h: Add include guard.
3908         * location.h: Rename include guard.
3909         * linux-record.h: Rename include guard.
3910         * linux-nat.h: Add include guard.
3911         * linux-fork.h: Add include guard.
3912         * i386-darwin-tdep.h: Rename include guard.
3913         * hppa-linux-offsets.h: Add include guard.
3914         * guile/guile.h: Rename include guard.
3915         * guile/guile-internal.h: Rename include guard.
3916         * gnu-nat.h: Rename include guard.
3917         * gdb-stabs.h: Rename include guard.
3918         * frv-tdep.h: Add include guard.
3919         * f-lang.h: Add include guard.
3920         * event-loop.h: Add include guard.
3921         * darwin-nat.h: Rename include guard.
3922         * cp-abi.h: Rename include guard.
3923         * config/sparc/nm-sol2.h: Rename include guard.
3924         * config/nm-nto.h: Rename include guard.
3925         * config/nm-linux.h: Add include guard.
3926         * config/i386/nm-i386gnu.h: Rename include guard.
3927         * config/djgpp/nl_types.h: Rename include guard.
3928         * config/djgpp/langinfo.h: Rename include guard.
3929         * compile/gcc-cp-plugin.h: Add include guard.
3930         * compile/gcc-c-plugin.h: Add include guard.
3931         * compile/compile.h: Rename include guard.
3932         * compile/compile-object-run.h: Rename include guard.
3933         * compile/compile-object-load.h: Rename include guard.
3934         * compile/compile-internal.h: Rename include guard.
3935         * compile/compile-cplus.h: Rename include guard.
3936         * compile/compile-c.h: Rename include guard.
3937         * common/xml-utils.h: Rename include guard.
3938         * common/x86-xstate.h: Rename include guard.
3939         * common/version.h: Rename include guard.
3940         * common/vec.h: Rename include guard.
3941         * common/tdesc.h: Rename include guard.
3942         * common/selftest.h: Rename include guard.
3943         * common/scoped_restore.h: Rename include guard.
3944         * common/scoped_mmap.h: Rename include guard.
3945         * common/scoped_fd.h: Rename include guard.
3946         * common/safe-iterator.h: Rename include guard.
3947         * common/run-time-clock.h: Rename include guard.
3948         * common/refcounted-object.h: Rename include guard.
3949         * common/queue.h: Rename include guard.
3950         * common/ptid.h: Rename include guard.
3951         * common/print-utils.h: Rename include guard.
3952         * common/preprocessor.h: Rename include guard.
3953         * common/pathstuff.h: Rename include guard.
3954         * common/observable.h: Rename include guard.
3955         * common/netstuff.h: Rename include guard.
3956         * common/job-control.h: Rename include guard.
3957         * common/host-defs.h: Rename include guard.
3958         * common/gdb_wait.h: Rename include guard.
3959         * common/gdb_vecs.h: Rename include guard.
3960         * common/gdb_unlinker.h: Rename include guard.
3961         * common/gdb_unique_ptr.h: Rename include guard.
3962         * common/gdb_tilde_expand.h: Rename include guard.
3963         * common/gdb_sys_time.h: Rename include guard.
3964         * common/gdb_string_view.h: Rename include guard.
3965         * common/gdb_splay_tree.h: Rename include guard.
3966         * common/gdb_setjmp.h: Rename include guard.
3967         * common/gdb_ref_ptr.h: Rename include guard.
3968         * common/gdb_optional.h: Rename include guard.
3969         * common/gdb_locale.h: Rename include guard.
3970         * common/gdb_assert.h: Rename include guard.
3971         * common/filtered-iterator.h: Rename include guard.
3972         * common/filestuff.h: Rename include guard.
3973         * common/fileio.h: Rename include guard.
3974         * common/environ.h: Rename include guard.
3975         * common/common-utils.h: Rename include guard.
3976         * common/common-types.h: Rename include guard.
3977         * common/common-regcache.h: Rename include guard.
3978         * common/common-inferior.h: Rename include guard.
3979         * common/common-gdbthread.h: Rename include guard.
3980         * common/common-exceptions.h: Rename include guard.
3981         * common/common-defs.h: Rename include guard.
3982         * common/common-debug.h: Rename include guard.
3983         * common/cleanups.h: Rename include guard.
3984         * common/buffer.h: Rename include guard.
3985         * common/btrace-common.h: Rename include guard.
3986         * common/break-common.h: Rename include guard.
3987         * cli/cli-utils.h: Rename include guard.
3988         * cli/cli-style.h: Rename include guard.
3989         * cli/cli-setshow.h: Rename include guard.
3990         * cli/cli-script.h: Rename include guard.
3991         * cli/cli-interp.h: Rename include guard.
3992         * cli/cli-decode.h: Rename include guard.
3993         * cli/cli-cmds.h: Rename include guard.
3994         * charset-list.h: Add include guard.
3995         * buildsym-legacy.h: Rename include guard.
3996         * bfin-tdep.h: Add include guard.
3997         * ax.h: Rename include guard.
3998         * arm-linux-tdep.h: Add include guard.
3999         * arm-fbsd-tdep.h: Add include guard.
4000         * arch/xtensa.h: Rename include guard.
4001         * arch/tic6x.h: Add include guard.
4002         * arch/i386.h: Add include guard.
4003         * arch/arm.h: Rename include guard.
4004         * arch/arm-linux.h: Rename include guard.
4005         * arch/arm-get-next-pcs.h: Rename include guard.
4006         * arch/amd64.h: Add include guard.
4007         * arch/aarch64-insn.h: Rename include guard.
4008         * arch-utils.h: Rename include guard.
4009         * annotate.h: Add include guard.
4010         * amd64-darwin-tdep.h: Rename include guard.
4011         * aarch64-linux-tdep.h: Add include guard.
4012         * aarch64-fbsd-tdep.h: Add include guard.
4013         * aarch32-linux-nat.h: Add include guard.
4014
4015 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4016
4017         * macrotab.c (macro_define_internal): New function that
4018         factorizes macro_define_object_internal and macro_define_function
4019         code.
4020         (macro_define_object_internal): Use macro_define_internal.
4021         (macro_define_function): Likewise.
4022
4023 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4024
4025         * macrocmd.c (extract_identifier): Return
4026         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
4027         callers.
4028
4029 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
4030
4031         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
4032
4033 2019-02-05  Tom Tromey  <tom@tromey.com>
4034
4035         * target.c (target_stack::unpush): Move assertion earlier.
4036
4037 2019-01-30  Tom Tromey  <tom@tromey.com>
4038
4039         PR python/23615:
4040         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
4041         (gdbpy_parse_and_eval): Likewise.
4042         * python/python-internal.h (gdbpy_allow_threads): New class.
4043
4044 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
4045
4046         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
4047         (aarch64_fbsd_fpregmap): Move earlier.
4048         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
4049         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4050         instead of individual calls to trad_frame_set_reg_addr.
4051         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
4052         earlier.
4053         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
4054         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
4055         instead of individual calls to trad_frame_set_reg_addr.
4056
4057 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
4058
4059         * CONTRIBUTE: Replace contribution list with wiki link.
4060
4061 2019-01-25  Tom Tromey  <tom@tromey.com>
4062
4063         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
4064
4065 2019-01-25  Tom Tromey  <tom@tromey.com>
4066
4067         * xtensa-linux-nat.c: Fix common/ includes.
4068         * xml-support.h: Fix common/ includes.
4069         * xml-support.c: Fix common/ includes.
4070         * x86-linux-nat.c: Fix common/ includes.
4071         * windows-nat.c: Fix common/ includes.
4072         * varobj.h: Fix common/ includes.
4073         * varobj.c: Fix common/ includes.
4074         * value.c: Fix common/ includes.
4075         * valops.c: Fix common/ includes.
4076         * utils.c: Fix common/ includes.
4077         * unittests/xml-utils-selftests.c: Fix common/ includes.
4078         * unittests/utils-selftests.c: Fix common/ includes.
4079         * unittests/unpack-selftests.c: Fix common/ includes.
4080         * unittests/tracepoint-selftests.c: Fix common/ includes.
4081         * unittests/style-selftests.c: Fix common/ includes.
4082         * unittests/string_view-selftests.c: Fix common/ includes.
4083         * unittests/scoped_restore-selftests.c: Fix common/ includes.
4084         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
4085         * unittests/scoped_fd-selftests.c: Fix common/ includes.
4086         * unittests/rsp-low-selftests.c: Fix common/ includes.
4087         * unittests/parse-connection-spec-selftests.c: Fix common/
4088         includes.
4089         * unittests/optional-selftests.c: Fix common/ includes.
4090         * unittests/offset-type-selftests.c: Fix common/ includes.
4091         * unittests/observable-selftests.c: Fix common/ includes.
4092         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
4093         * unittests/memrange-selftests.c: Fix common/ includes.
4094         * unittests/memory-map-selftests.c: Fix common/ includes.
4095         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
4096         * unittests/function-view-selftests.c: Fix common/ includes.
4097         * unittests/environ-selftests.c: Fix common/ includes.
4098         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
4099         * unittests/common-utils-selftests.c: Fix common/ includes.
4100         * unittests/cli-utils-selftests.c: Fix common/ includes.
4101         * unittests/array-view-selftests.c: Fix common/ includes.
4102         * ui-file.c: Fix common/ includes.
4103         * tui/tui-io.c: Fix common/ includes.
4104         * tracepoint.h: Fix common/ includes.
4105         * tracepoint.c: Fix common/ includes.
4106         * tracefile-tfile.c: Fix common/ includes.
4107         * top.h: Fix common/ includes.
4108         * top.c: Fix common/ includes.
4109         * thread.c: Fix common/ includes.
4110         * target/waitstatus.h: Fix common/ includes.
4111         * target/waitstatus.c: Fix common/ includes.
4112         * target.h: Fix common/ includes.
4113         * target.c: Fix common/ includes.
4114         * target-memory.c: Fix common/ includes.
4115         * target-descriptions.c: Fix common/ includes.
4116         * symtab.h: Fix common/ includes.
4117         * symfile.c: Fix common/ includes.
4118         * stap-probe.c: Fix common/ includes.
4119         * spu-linux-nat.c: Fix common/ includes.
4120         * sparc-nat.c: Fix common/ includes.
4121         * source.c: Fix common/ includes.
4122         * solib.c: Fix common/ includes.
4123         * solib-target.c: Fix common/ includes.
4124         * ser-unix.c: Fix common/ includes.
4125         * ser-tcp.c: Fix common/ includes.
4126         * ser-pipe.c: Fix common/ includes.
4127         * ser-base.c: Fix common/ includes.
4128         * selftest-arch.c: Fix common/ includes.
4129         * s12z-tdep.c: Fix common/ includes.
4130         * rust-exp.y: Fix common/ includes.
4131         * rs6000-aix-tdep.c: Fix common/ includes.
4132         * riscv-tdep.c: Fix common/ includes.
4133         * remote.c: Fix common/ includes.
4134         * remote-notif.h: Fix common/ includes.
4135         * remote-fileio.h: Fix common/ includes.
4136         * remote-fileio.c: Fix common/ includes.
4137         * regcache.h: Fix common/ includes.
4138         * regcache.c: Fix common/ includes.
4139         * record-btrace.c: Fix common/ includes.
4140         * python/python.c: Fix common/ includes.
4141         * python/py-type.c: Fix common/ includes.
4142         * python/py-inferior.c: Fix common/ includes.
4143         * progspace.h: Fix common/ includes.
4144         * producer.c: Fix common/ includes.
4145         * procfs.c: Fix common/ includes.
4146         * proc-api.c: Fix common/ includes.
4147         * printcmd.c: Fix common/ includes.
4148         * ppc-linux-nat.c: Fix common/ includes.
4149         * parser-defs.h: Fix common/ includes.
4150         * osdata.c: Fix common/ includes.
4151         * obsd-nat.c: Fix common/ includes.
4152         * nat/x86-linux.c: Fix common/ includes.
4153         * nat/x86-linux-dregs.c: Fix common/ includes.
4154         * nat/x86-dregs.h: Fix common/ includes.
4155         * nat/x86-dregs.c: Fix common/ includes.
4156         * nat/ppc-linux.c: Fix common/ includes.
4157         * nat/mips-linux-watch.h: Fix common/ includes.
4158         * nat/mips-linux-watch.c: Fix common/ includes.
4159         * nat/linux-waitpid.c: Fix common/ includes.
4160         * nat/linux-ptrace.h: Fix common/ includes.
4161         * nat/linux-ptrace.c: Fix common/ includes.
4162         * nat/linux-procfs.c: Fix common/ includes.
4163         * nat/linux-personality.c: Fix common/ includes.
4164         * nat/linux-osdata.c: Fix common/ includes.
4165         * nat/linux-namespaces.c: Fix common/ includes.
4166         * nat/linux-btrace.h: Fix common/ includes.
4167         * nat/linux-btrace.c: Fix common/ includes.
4168         * nat/fork-inferior.c: Fix common/ includes.
4169         * nat/amd64-linux-siginfo.c: Fix common/ includes.
4170         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
4171         * nat/aarch64-linux.c: Fix common/ includes.
4172         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
4173         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
4174         * namespace.h: Fix common/ includes.
4175         * mips-linux-tdep.c: Fix common/ includes.
4176         * minsyms.c: Fix common/ includes.
4177         * mi/mi-parse.h: Fix common/ includes.
4178         * mi/mi-main.c: Fix common/ includes.
4179         * mi/mi-cmd-env.c: Fix common/ includes.
4180         * memrange.h: Fix common/ includes.
4181         * memattr.c: Fix common/ includes.
4182         * maint.h: Fix common/ includes.
4183         * maint.c: Fix common/ includes.
4184         * main.c: Fix common/ includes.
4185         * machoread.c: Fix common/ includes.
4186         * location.c: Fix common/ includes.
4187         * linux-thread-db.c: Fix common/ includes.
4188         * linux-nat.c: Fix common/ includes.
4189         * linux-fork.c: Fix common/ includes.
4190         * inline-frame.c: Fix common/ includes.
4191         * infrun.c: Fix common/ includes.
4192         * inflow.c: Fix common/ includes.
4193         * inferior.h: Fix common/ includes.
4194         * inferior.c: Fix common/ includes.
4195         * infcmd.c: Fix common/ includes.
4196         * inf-ptrace.c: Fix common/ includes.
4197         * inf-child.c: Fix common/ includes.
4198         * ia64-linux-nat.c: Fix common/ includes.
4199         * i387-tdep.c: Fix common/ includes.
4200         * i386-tdep.c: Fix common/ includes.
4201         * i386-linux-tdep.c: Fix common/ includes.
4202         * i386-linux-nat.c: Fix common/ includes.
4203         * i386-go32-tdep.c: Fix common/ includes.
4204         * i386-fbsd-tdep.c: Fix common/ includes.
4205         * i386-fbsd-nat.c: Fix common/ includes.
4206         * guile/scm-type.c: Fix common/ includes.
4207         * guile/guile.c: Fix common/ includes.
4208         * go32-nat.c: Fix common/ includes.
4209         * gnu-nat.c: Fix common/ includes.
4210         * gdbthread.h: Fix common/ includes.
4211         * gdbarch-selftests.c: Fix common/ includes.
4212         * gdb_usleep.c: Fix common/ includes.
4213         * gdb_select.h: Fix common/ includes.
4214         * gdb_bfd.c: Fix common/ includes.
4215         * gcore.c: Fix common/ includes.
4216         * fork-child.c: Fix common/ includes.
4217         * findvar.c: Fix common/ includes.
4218         * fbsd-nat.c: Fix common/ includes.
4219         * event-top.c: Fix common/ includes.
4220         * event-loop.c: Fix common/ includes.
4221         * dwarf2read.c: Fix common/ includes.
4222         * dwarf2loc.c: Fix common/ includes.
4223         * dwarf2-frame.c: Fix common/ includes.
4224         * dwarf-index-cache.c: Fix common/ includes.
4225         * dtrace-probe.c: Fix common/ includes.
4226         * disasm-selftests.c: Fix common/ includes.
4227         * defs.h: Fix common/ includes.
4228         * csky-tdep.c: Fix common/ includes.
4229         * cp-valprint.c: Fix common/ includes.
4230         * cp-support.h: Fix common/ includes.
4231         * cp-support.c: Fix common/ includes.
4232         * corelow.c: Fix common/ includes.
4233         * completer.h: Fix common/ includes.
4234         * completer.c: Fix common/ includes.
4235         * compile/compile.c: Fix common/ includes.
4236         * compile/compile-loc2c.c: Fix common/ includes.
4237         * compile/compile-cplus-types.c: Fix common/ includes.
4238         * compile/compile-cplus-symbols.c: Fix common/ includes.
4239         * command.h: Fix common/ includes.
4240         * cli/cli-dump.c: Fix common/ includes.
4241         * cli/cli-cmds.c: Fix common/ includes.
4242         * charset.c: Fix common/ includes.
4243         * build-id.c: Fix common/ includes.
4244         * btrace.h: Fix common/ includes.
4245         * btrace.c: Fix common/ includes.
4246         * breakpoint.h: Fix common/ includes.
4247         * breakpoint.c: Fix common/ includes.
4248         * ax.h:
4249         (enum agent_op): Fix common/ includes.
4250         * ax-general.c (struct aop_map): Fix common/ includes.
4251         * ax-gdb.c: Fix common/ includes.
4252         * auxv.c: Fix common/ includes.
4253         * auto-load.c: Fix common/ includes.
4254         * arm-tdep.c: Fix common/ includes.
4255         * arch/riscv.c: Fix common/ includes.
4256         * arch/ppc-linux-common.c: Fix common/ includes.
4257         * arch/i386.c: Fix common/ includes.
4258         * arch/arm.c: Fix common/ includes.
4259         * arch/arm-linux.c: Fix common/ includes.
4260         * arch/arm-get-next-pcs.c: Fix common/ includes.
4261         * arch/amd64.c: Fix common/ includes.
4262         * arch/aarch64.c: Fix common/ includes.
4263         * arch/aarch64-insn.c: Fix common/ includes.
4264         * arch-utils.c: Fix common/ includes.
4265         * amd64-windows-tdep.c: Fix common/ includes.
4266         * amd64-tdep.c: Fix common/ includes.
4267         * amd64-sol2-tdep.c: Fix common/ includes.
4268         * amd64-obsd-tdep.c: Fix common/ includes.
4269         * amd64-nbsd-tdep.c: Fix common/ includes.
4270         * amd64-linux-tdep.c: Fix common/ includes.
4271         * amd64-linux-nat.c: Fix common/ includes.
4272         * amd64-fbsd-tdep.c: Fix common/ includes.
4273         * amd64-fbsd-nat.c: Fix common/ includes.
4274         * amd64-dicos-tdep.c: Fix common/ includes.
4275         * amd64-darwin-tdep.c: Fix common/ includes.
4276         * agent.c: Fix common/ includes.
4277         * ada-lang.h: Fix common/ includes.
4278         * ada-lang.c: Fix common/ includes.
4279         * aarch64-tdep.c: Fix common/ includes.
4280
4281 2019-01-25  Tom Tromey  <tom@tromey.com>
4282
4283         * common/create-version.sh: Use common/version.h.
4284
4285 2019-01-24  Pedro Alves  <palves@redhat.com>
4286
4287         * infrun.c (signal_stop, signal_print, signal_program)
4288         (signal_catch, signal_pass): Now arrays instead of pointers.
4289         (update_signals_program_target, do_target_resume)
4290         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
4291         * linux-nat.c (linux_nat_target::pass_signals)
4292         (linux_nat_target::create_inferior, linux_nat_target::attach):
4293         Adjust.
4294         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
4295         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
4296         * procfs.c (procfs_target::pass_signals): Adjust.
4297         * record-full.c (record_full_target::resume): Adjust.
4298         * remote.c (remote_target::pass_signals)
4299         (remote_target::program_signals): Adjust.
4300         * target-debug.h (target_debug_print_signals): Now takes a
4301         gdb::array_view as parameter.  Adjust.
4302         * target.h (target_ops) <pass_signals, program_signals>: Replace
4303         pointer and length parameters with gdb::array_view.
4304         (target_pass_signals, target_program_signals): Likewise.
4305         * target-delegates.c: Regenerate.
4306
4307 2019-01-24  Pedro Alves  <palves@redhat.com>
4308
4309         * common/forward-scope-exit.h
4310         (forward_scope_exit::forward_scope_exit): Pass arguments to
4311         m_bind_function directly, instead of creating a std::bind and
4312         copying that.
4313
4314 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
4315
4316         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4317         for static members.
4318         (pass_in_v_vfp_candidate): Likewise.
4319
4320 2019-01-23  Tom Tromey  <tom@tromey.com>
4321             Pedro Alves  <palves@redhat.com>
4322
4323         * regcache.c (class regcache_invalidator): Remove.
4324         (regcache::raw_write): Use make_scope_exit.
4325
4326 2019-01-23  Tom Tromey  <tom@tromey.com>
4327
4328         * ui-out.h (class ui_out_emit_type): Update comment.
4329
4330 2019-01-23  Tom Tromey  <tom@tromey.com>
4331
4332         * infrun.c (fetch_inferior_event): Update comment.
4333
4334 2019-01-23  Tom Tromey  <tom@tromey.com>
4335             Pedro Alves  <palves@redhat.com>
4336
4337         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
4338         parameter.
4339         (fetch_inferior_event): Use SCOPE_EXIT.
4340
4341
4342 2019-01-23  Tom Tromey  <tom@tromey.com>
4343             Pedro Alves  <palves@redhat.com>
4344
4345         * infrun.c (disable_thread_events): Delete.
4346         (stop_all_threads): Use SCOPE_EXIT.
4347
4348 2019-01-23  Tom Tromey  <tom@tromey.com>
4349             Pedro Alves  <palves@redhat.com>
4350
4351         * symfile.c: Include forward-scope-exit.h.
4352         (clear_symtab_users_cleanup): Replace forward declaration with
4353         a FORWARD_SCOPE_EXIT.
4354         (syms_from_objfile_1): Use the forward_scope_exit and
4355         gdb::optional instead of cleanup_function.
4356         (reread_symbols): Use the forward_scope_exit instead of
4357         cleanup_function.
4358         (clear_symtab_users_cleanup): Remove function.
4359
4360 2019-01-23  Tom Tromey  <tom@tromey.com>
4361             Pedro Alves  <palves@redhat.com>
4362
4363         * linux-nat.c: Include scope-exit.h.
4364         (cleanup_target_stop): Remove.
4365         (linux_nat_target::static_tracepoint_markers_by_strid): Use
4366         SCOPE_EXIT.
4367
4368 2019-01-23  Tom Tromey  <tom@tromey.com>
4369             Pedro Alves  <palves@redhat.com>
4370
4371         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
4372         (call_function_by_hand_dummy): Use SCOPE_EXIT.
4373
4374 2019-01-23  Tom Tromey  <tom@tromey.com>
4375             Andrew Burgess  <andrew.burgess@embecosm.com>
4376             Pedro Alves  <palves@redhat.com>
4377
4378         * infrun.c (fetch_inferior_event): Use scope_exit.
4379         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
4380         * top.c (execute_command): Use scope_exit.
4381         * breakpoint.c (bpstat_do_actions): Use scope_exit.
4382         * utils.c (do_bpstat_clear_actions_cleanup)
4383         (make_bpstat_clear_actions_cleanup): Remove.
4384
4385 2019-01-23  Tom Tromey  <tom@tromey.com>
4386             Pedro Alves  <palves@redhat.com>
4387
4388         * infrun.c: Include "common/scope-exit.h"
4389         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
4390         (wait_for_inferior): Use SCOPE_EXIT.
4391         (fetch_inferior_event): Use scope_exit.
4392
4393 2019-01-23  Tom Tromey  <tom@tromey.com>
4394             Pedro Alves  <palves@redhat.com>
4395
4396         * breakpoint.c (create_breakpoint): Remove cleanup.
4397
4398 2019-01-23  Tom Tromey  <tom@tromey.com>
4399             Andrew Burgess  <andrew.burgess@embecosm.com>
4400             Pedro Alves  <palves@redhat.com>
4401
4402 2019-01-23  Pedro Alves  <palves@redhat.com>
4403
4404         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
4405
4406 2019-01-23  Pedro Alves  <palves@redhat.com>
4407             Andrew Burgess  <andrew.burgess@embecosm.com>
4408
4409         * gdbthread.h: Include "common/forward-scope-exit.h".
4410         (scoped_finish_thread_state): Redefine custom class in terms of
4411         forward_scope_exit.
4412
4413 2019-01-23  Pedro Alves  <palves@redhat.com>
4414             Andrew Burgess  <andrew.burgess@embecosm.com>
4415
4416         * common/forward-scope-exit.h: New file.
4417
4418 2019-01-23  Pedro Alves  <palves@redhat.com>
4419             Andrew Burgess  <andrew.burgess@embecosm.com>
4420             Tom Tromey  <tom@tromey.com>
4421
4422         * common/scope-exit.h: New file.
4423
4424 2019-01-23  Pedro Alves  <palves@redhat.com>
4425
4426         * common/preprocessor.h (ESC): Rename to ...
4427         (ESC_PARENS): ... this.
4428         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
4429         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
4430
4431 2019-01-23  Tom Tromey  <tom@tromey.com>
4432
4433         * language.h (class scoped_switch_to_sym_language_if_auto):
4434         Initialize m_lang in both cases.
4435
4436 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
4437
4438         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
4439         with XCNEW.
4440
4441 2019-01-22  Tom Tromey  <tom@tromey.com>
4442
4443         * corelow.c: Do not include sys/file.h.
4444
4445 2019-01-22  Tom Tromey  <tom@tromey.com>
4446
4447         * tui/tui-wingeneral.h: Include gdb_curses.h.
4448
4449 2019-01-22  Tom Tromey  <tom@tromey.com>
4450
4451         * source-cache.h (class source_cache) <get_source_lines,
4452         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
4453
4454 2019-01-22  Tom Tromey  <tom@tromey.com>
4455
4456         * remote-fileio.h (struct remote_target): Declare.
4457
4458 2019-01-22  Tom Tromey  <tom@tromey.com>
4459
4460         * python/py-arch.c: Do not include py-ref.h.
4461         * python/py-bpevent.c: Do not include py-ref.h.
4462         * python/py-cmd.c: Do not include py-ref.h.
4463         * python/py-continueevent.c: Do not include py-ref.h.
4464         * python/py-event.h: Do not include py-ref.h.
4465         * python/py-evtregistry.c: Do not include py-ref.h.
4466         * python/py-finishbreakpoint.c: Do not include py-ref.h.
4467         * python/py-frame.c: Do not include py-ref.h.
4468         * python/py-framefilter.c: Do not include py-ref.h.
4469         * python/py-function.c: Do not include py-ref.h.
4470         * python/py-infevents.c: Do not include py-ref.h.
4471         * python/py-linetable.c: Do not include py-ref.h.
4472         * python/py-objfile.c: Do not include py-ref.h.
4473         * python/py-param.c: Do not include py-ref.h.
4474         * python/py-prettyprint.c: Do not include py-ref.h.
4475         * python/py-progspace.c: Do not include py-ref.h.
4476         * python/py-symbol.c: Do not include py-ref.h.
4477         * python/py-symtab.c: Do not include py-ref.h.
4478         * python/py-type.c: Do not include py-ref.h.
4479         * python/py-unwind.c: Do not include py-ref.h.
4480         * python/py-utils.c: Do not include py-ref.h.
4481         * python/py-value.c: Do not include py-ref.h.
4482         * python/py-varobj.c: Do not include py-ref.h.
4483         * python/py-xmethods.c: Do not include py-ref.h.
4484         * python/python.c: Do not include py-ref.h.
4485         * varobj.c: Do not include py-ref.h.
4486
4487 2019-01-22  Tom Tromey  <tom@tromey.com>
4488
4489         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
4490         keyword for bcache.
4491
4492 2019-01-22  Tom Tromey  <tom@tromey.com>
4493
4494         * compile/compile-cplus-types.c: Remove a comment by #include.
4495
4496 2019-01-22  Tom Tromey  <tom@tromey.com>
4497
4498         * compile/gcc-c-plugin.h: Include compile-internal.h.
4499
4500 2019-01-22  Tom Tromey  <tom@tromey.com>
4501
4502         * stabsread.c (EXTERN): Do not define.
4503         (symnum, next_symbol_text_func, processing_gcc_compilation)
4504         (within_function, global_sym_chain, global_stabs)
4505         (previous_stab_code, this_object_header_files)
4506         (n_this_object_header_files)
4507         (n_allocated_this_object_header_files): Define.
4508         * stabsread.h (EXTERN): Never define.  Use "extern".
4509
4510 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4511
4512         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
4513         history_value.
4514
4515 2019-01-21  Tom Tromey  <tom@tromey.com>
4516
4517         * ui-out.c: Fix includes.
4518         * tui/tui-source.c: Fix includes.
4519         * target.c: Fix includes.
4520         * remote.c: Fix includes.
4521         * regcache.c: Fix includes.
4522         * python/py-block.c: Fix includes.
4523         * printcmd.c: Fix includes.
4524         * or1k-tdep.c: Fix includes.
4525         * mi/mi-main.c: Fix includes.
4526         * m32r-tdep.c: Fix includes.
4527         * csky-tdep.c: Fix includes.
4528         * compile/compile-cplus-types.c: Fix includes.
4529         * cli/cli-interp.c: Fix includes.
4530
4531 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
4532
4533         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
4534         for padding.
4535
4536 2019-01-16  Tom Tromey  <tom@tromey.com>
4537
4538         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
4539         earlier.
4540         (struct objfile) <msymbols_range>: Move from top level.
4541         <msymbols>: New method.
4542         (class objfile_msymbols): Remove.
4543         * symtab.c (default_collect_symbol_completion_matches_break_on):
4544         Update.
4545         * symmisc.c (dump_msymbols): Update.
4546         * stabsread.c (scan_file_globals): Update.
4547         * objc-lang.c (info_selectors_command, info_classes_command)
4548         (find_methods): Update.
4549         * minsyms.c (find_solib_trampoline_target): Update.
4550         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
4551         * coffread.c (coff_symfile_read): Update.
4552         * ada-lang.c (ada_lookup_simple_minsym)
4553         (ada_collect_symbol_completion_matches): Update.
4554
4555 2019-01-16  Tom Tromey  <tom@tromey.com>
4556
4557         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
4558         type.  Remove no-argument constructor.
4559         <iterator::operator++>: Simplify.
4560         <begin>: Update.
4561         <end>: Use minimal_symbol_count.
4562
4563 2019-01-16  Tom Tromey  <tom@tromey.com>
4564
4565         * objfiles.h (struct objfile) <psymtabs>: New method.
4566         (class objfile_psymtabs): Remove.
4567         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
4568         typedef.
4569         <range>: New method.
4570         (require_partial_symbols): Change return type.
4571         * psymtab.c (require_partial_symbols)
4572         (psym_expand_symtabs_matching): Update.
4573         * mdebugread.c (parse_partial_symbols): Update.
4574         * dbxread.c (dbx_end_psymtab): Update.
4575
4576 2019-01-15  Tom Tromey  <tom@tromey.com>
4577
4578         * symtab.c (lookup_objfile_from_block)
4579         (lookup_symbol_in_objfile_symtabs)
4580         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
4581         (find_line_symtab, info_sources_command)
4582         (default_collect_symbol_completion_matches_break_on)
4583         (make_source_files_completion_list): Update.
4584         * symmisc.c (print_objfile_statistics, dump_objfile)
4585         (maintenance_print_symbols, maintenance_info_symtabs)
4586         (maintenance_check_symtabs, maintenance_info_line_tables):
4587         Update.
4588         * source.c (select_source_symtab)
4589         (forget_cached_source_info_for_objfile): Update.
4590         * objfiles.h (class objfile_compunits): Remove.
4591         (struct objfile) <compunits_range>: New typedef.
4592         (compunits): New method.
4593         * objfiles.c (objfile_relocate1): Update.
4594         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4595         * maint.c (count_symtabs_and_blocks): Update.
4596         * linespec.c (iterate_over_all_matching_symtabs): Update.
4597         * cp-support.c (add_symbol_overload_list_qualified): Update.
4598         * coffread.c (coff_symtab_read): Update.
4599         * ada-lang.c (add_nonlocal_symbols)
4600         (ada_collect_symbol_completion_matches)
4601         (ada_add_global_exceptions): Update.
4602
4603 2019-01-15  Tom Tromey  <tom@tromey.com>
4604
4605         * progspace.h (program_space) <objfiles_safe_range>: New
4606         typedef.
4607         <objfiles_safe>: New method.
4608         * objfiles.h (class all_objfiles_safe): Remove.
4609         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
4610         * jit.c (jit_inferior_exit_hook): Update.
4611
4612 2019-01-17  Tom Tromey  <tom@tromey.com>
4613
4614         * progspace.h (program_space) <objfiles_range>: New typedef.
4615         <objfiles>: New method.
4616         <objfiles_head>: Rename from objfiles.
4617         (object_files): Update.
4618         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
4619         * guile/scm-pretty-print.c
4620         (ppscm_find_pretty_printer_from_objfiles): Update.
4621         * guile/scm-objfile.c (gdbscm_objfiles): Update.
4622         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
4623         Update.
4624         * python/py-progspace.c (pspy_get_objfiles): Update.
4625         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
4626         Update.
4627         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
4628         (objfpy_lookup_objfile_by_build_id): Update.
4629         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
4630         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
4631         Update.
4632         * symtab.c (iterate_over_symtabs, matching_obj_sections)
4633         (expand_symtab_containing_pc, lookup_objfile_from_block)
4634         (lookup_static_symbol, basic_lookup_transparent_type)
4635         (find_pc_sect_compunit_symtab, find_symbol_at_address)
4636         (find_line_symtab, info_sources_command)
4637         (default_collect_symbol_completion_matches_break_on)
4638         (make_source_files_completion_list, find_main_name): Update.
4639         * symmisc.c (print_symbol_bcache_statistics)
4640         (print_objfile_statistics, maintenance_print_symbols)
4641         (maintenance_print_msymbols, maintenance_print_objfiles)
4642         (maintenance_info_symtabs, maintenance_check_symtabs)
4643         (maintenance_expand_symtabs, maintenance_info_line_tables):
4644         Update.
4645         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
4646         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
4647         (map_overlay_command, unmap_overlay_command)
4648         (simple_overlay_update, expand_symtabs_matching)
4649         (map_symbol_filenames): Update.
4650         * symfile-debug.c (set_debug_symfile): Update.
4651         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
4652         Update.
4653         * source.c (select_source_symtab, forget_cached_source_info):
4654         Update.
4655         * solib.c (solib_read_symbols): Update.
4656         * solib-spu.c (append_ocl_sos): Update.
4657         * psymtab.c (maintenance_print_psymbols)
4658         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
4659         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
4660         * printcmd.c (info_symbol_command): Update.
4661         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
4662         Update.
4663         * objfiles.h (class all_objfiles): Remove.
4664         * objfiles.c (have_partial_symbols, have_full_symbols)
4665         (have_minimal_symbols, qsort_cmp, update_section_map)
4666         (shared_objfile_contains_address_p)
4667         (default_iterate_over_objfiles_in_search_order): Update.
4668         * objc-lang.c (info_selectors_command, info_classes_command)
4669         (find_methods): Update.
4670         * minsyms.c (find_solib_trampoline_target): Update.
4671         * maint.c (maintenance_info_sections)
4672         (maintenance_translate_address, count_symtabs_and_blocks):
4673         Update.
4674         * main.c (captured_main_1): Update.
4675         * linux-thread-db.c (try_thread_db_load_from_pdir)
4676         (has_libpthread): Update.
4677         * linespec.c (iterate_over_all_matching_symtabs)
4678         (search_minsyms_for_name): Update.
4679         * jit.c (jit_find_objf_with_entry_addr): Update.
4680         * hppa-tdep.c (find_unwind_entry)
4681         (hppa_lookup_stub_minimal_symbol): Update.
4682         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
4683         Update.
4684         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
4685         (elf_gnu_ifunc_resolve_by_got): Update.
4686         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
4687         * dwarf-index-write.c (save_gdb_index_command): Update.
4688         * cp-support.c (add_symbol_overload_list_qualified): Update.
4689         * breakpoint.c (create_overlay_event_breakpoint)
4690         (create_longjmp_master_breakpoint)
4691         (create_std_terminate_master_breakpoint)
4692         (create_exception_master_breakpoint): Update.
4693         * blockframe.c (find_pc_partial_function): Update.
4694         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
4695         (ada_collect_symbol_completion_matches)
4696         (ada_add_global_exceptions): Update.
4697
4698 2019-01-17  Tom Tromey  <tom@tromey.com>
4699
4700         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
4701         declare VEC.
4702         (solib_target_parse_libraries): Change return type.
4703         (library_list_start_segment, library_list_start_section)
4704         (library_list_end_library, library_list_start_library); Update.
4705         (solib_target_free_library_list): Remove.
4706         (solib_target_parse_libraries): Remove cleanup.  Change return
4707         type.
4708         (solib_target_current_sos): Update.
4709
4710 2019-01-17  Tom Tromey  <tromey@bapiya>
4711
4712         * valprint.c: Replace "the the" with "the".
4713         * symtab.c: Replace "the the" with "the".
4714         * solib.c: Replace "the the" with "the".
4715         * solib-dsbt.c: Replace "the the" with "the".
4716         * linespec.c: Replace "the the" with "the".
4717         * dwarf2loc.h: Replace "the the" with "the".
4718         * amd64-windows-tdep.c: Replace "the the" with "the".
4719         * aarch64-tdep.c: Replace "the the" with "the".
4720
4721 2019-01-16  Keith Seitz  <keiths@redhat.com>
4722
4723         PR gdb/23773
4724         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
4725         <builder>: Rename to ..
4726         <m_builder>: ... this and make private.
4727         (dwarf2_cu::get_builder): New method.  Change all users of
4728         `builder' to use this method.
4729         (dwarf2_start_symtab): Move to ...
4730         (dwarf2_cu::start_symtab): ... here.  Update all callers
4731         (setup_type_unit_groups): Move to ...
4732         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
4733         callers.
4734         (dwarf2_cu::reset_builder): New method.
4735         (process_full_compunit, process_full_type_unit): Use
4736         dwarf2_cu::reset_builder.
4737         (follow_die_offset): Record the ancestor CU if it is different
4738         from the followed DIE's CU.
4739         (follow_die_sig_1): Likewise.
4740
4741 2019-01-15  Tom Tromey  <tom@tromey.com>
4742
4743         * remote.c (class remote_state) <buf>: Now a char_vector.
4744         <buf_size>: Remove.
4745         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
4746         parameter.
4747         (remote_target::getpkt_or_notif_sane_1)
4748         (remote_target::getpkt_sane)
4749         (remote_target::getpkt_or_notif_sane): Likewise.
4750         (class remote_target) <putpkt>: New overload.
4751         (remote_target::read_frame): Change type of "buf_p".  Remove
4752         sizeof_p parameter.
4753         (packet_ok): New overload.
4754         (packet_check_result): New overload.
4755         Update all uses.
4756
4757 2019-01-14  Tom Tromey  <tom@tromey.com>
4758
4759         * remote-notif.c (handle_notification, remote_notif_ack)
4760         (remote_notif_parse): Make "buf" const.
4761         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
4762         const.
4763         (remote_notif_parse, remote_notif_ack, handle_notification):
4764         Likewise.
4765         * remote.c (remote_notif_stop_parse): Make "buf" const.
4766         (remote_target::remote_parse_stop_reply): Make "buf" const.
4767         (remote_notif_stop_ack): Make "buf" const.
4768
4769 2019-01-14  Tom Tromey  <tom@tromey.com>
4770
4771         * remote.c (remote_console_output): Make parameter const.
4772
4773 2019-01-14  Tom Tromey  <tom@tromey.com>
4774
4775         * target-debug.h (target_debug_print_signals): Constify.
4776         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
4777         * procfs.c (procfs_target::pass_signals): Update.
4778         * linux-nat.c (linux_nat_target::pass_signals): Update.
4779         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
4780         * target-delegates.c: Rebuild.
4781         * remote.c (remote_target::program_signals): Update.
4782         (remote_target::pass_signals): Update.
4783         * target.c (target_pass_signals): Constify argument.
4784         (target_program_signals): Likewise.
4785         * target.h (struct target_ops) <pass_signals, program_signals>:
4786         Constify argument.
4787         (target_pass_signals, target_program_signals): Constify argument.
4788
4789 2019-01-14  Tom Tromey  <tom@tromey.com>
4790
4791         PR tui/28819:
4792         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
4793
4794 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
4795
4796         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
4797         field.
4798         * rs6000-tdep.c: Include reggroups.h.
4799         (IS_V_ALIAS_PSEUDOREG): Define.
4800         (rs6000_register_name): Return names for the "vX" aliases.
4801         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
4802         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
4803         aliases.  Call default_register_reggroup_p for all other
4804         pseudo-registers.
4805         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
4806         New functions.
4807         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
4808         Handle "vX" aliases.
4809         (v_alias_pseudo_register_collect): New function.
4810         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
4811         (rs6000_gdbarch_init): Initialize "vX" aliases as
4812         pseudo-registers.  Restore registration of
4813         rs6000_pseudo_register_reggroup_p with
4814         set_tdesc_pseudo_register_reggroup_p.
4815
4816 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
4817
4818         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
4819         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
4820         set_gdbarch_num_pseudo_regs.
4821
4822 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4823
4824         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
4825         Remove arg prefixname, add do_set and do_show.
4826         Add member functions set_list and show_list.
4827         * cli/cli-style.c (class cli_style_option): Update accordingly.
4828         (style_set_list): Move to file scope.
4829         (style_show_list): Likewise.
4830         (set_style): Call help_list.
4831         (show_style): Call cmd_show_list.
4832         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
4833         Update to use the new macro.
4834
4835 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
4836
4837         * ada-lang.c (_initialize_ada_language): Expand the help text
4838         for the "catch exception" command.
4839
4840 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4841
4842         * symtab.c (matching_obj_sections): Initialize obj,
4843         declare it closer to its usage.
4844
4845 2019-01-10  Tom Tromey  <tom@tromey.com>
4846
4847         * thread-iter.h (inf_threads_iterator): Use next_iterator.
4848         (basic_inf_threads_range): Remove.
4849         (inf_threads_range, inf_non_exited_threads_range)
4850         (safe_inf_threads_range): Use next_adapter.
4851
4852 2019-01-10  Keith Seitz  <keiths@redhat.com>
4853
4854         PR gdb/23712
4855         PR symtab/23010
4856         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
4857         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
4858
4859 2019-01-10  Keith Seitz  <keiths@redhat.com>
4860
4861         PR gdb/23712
4862         PR symtab/23010
4863         * dictionary.c (pending_to_vector): Remove.
4864         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4865         Remove _1 suffix, replacing functions of the same name.  Update
4866         all callers.
4867         (dict_create_hashed, dict_create_hashed_expandable)
4868         (dict_create_linear, dict_create_linear_expandable, dict_free)
4869         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
4870         Make functions static.
4871
4872 2019-01-10  Keith Seitz  <keiths@redhat.com>
4873
4874         PR gdb/23712
4875         PR symtab/23010
4876         * dictionary.h (struct dictionary): Replace declaration with
4877         multidictionary.
4878         (dict_create_hashed, dict_create_hashed_expandable)
4879         (dict_create_linear, dict_create_linear_expandable)
4880         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
4881         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
4882         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
4883         taking multidictionary argument.
4884         [ALL_DICT_SYMBOLS]: Update for multidictionary.
4885         * block.h (struct block) <dict>: Change to multidictionary
4886         and rename `multidict'.
4887         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
4888         symmisc.c: Update all dictionary references to multidictionary.
4889
4890 2019-01-10  Keith Seitz  <keiths@redhat.com>
4891
4892         PR gdb/23712
4893         PR symtab/23010
4894         * dictionary.c: Include unordered_map.
4895         (pending_to_vector): New function.
4896         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
4897         Rewrite the non-"_1" functions to take vector instead
4898         of linked list.
4899         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
4900         "new" _1 versions of the same name.
4901         (multidictionary): Define.
4902         (std::hash<enum language): New definition.
4903         (collate_pending_symbols_by_language, mdict_create_hashed)
4904         (mdict_create_hashed_expandable, mdict_create_linear)
4905         (mdict_create_linear_expandable, mdict_free)
4906         (find_language_dictionary, create_new_language_dictionary)
4907         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
4908         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
4909         (mdict_size, mdict_empty): New functions.
4910         * dictionary.h (mdict_iterator): Define.
4911
4912 2019-01-10  Pedro Alves  <palves@redhat.com>
4913
4914         * breakpoint.c (read_uploaded_action)
4915         (create_tracepoint_from_upload): Adjust to use
4916         gdb::unique_xmalloc_ptr.
4917         * ctf.c (ctf_write_uploaded_tp):
4918         (SET_ARRAY_FIELD): Use emplace_back.
4919         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
4920         * tracefile-tfile.c (tfile_write_uploaded_tp):
4921         * tracepoint.c (parse_tracepoint_definition): Adjust to use
4922         gdb::unique_xmalloc_ptr.
4923         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
4924         at_string, cond_string, cmd_strings>: Replace char pointers
4925         with gdb::unique_xmalloc_ptr.
4926
4927 2019-01-10  Pedro Alves  <palves@redhat.com>
4928
4929         * solib-target.c (library_list_start_library): Don't xstrdup name.
4930
4931 2019-01-10  Pedro Alves  <palves@redhat.com>
4932
4933         * mdebugread.c (parse_partial_symbols): Use
4934         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
4935
4936 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4937
4938         * linux-fork.c (scoped_switch_fork_info)
4939         <~scoped_switch_fork_info>: Fix incorrect variable name.
4940
4941 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
4942
4943         * linux-fork.c (scoped_switch_fork_info)
4944         <scoped_switch_fork_info>: Make explicit.
4945         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
4946
4947 2019-01-10  Tom Tromey  <tom@tromey.com>
4948
4949         * objfiles.h (objfile::reset_psymtabs): Update.
4950         * objfiles.c (objfile::objfile): Update.
4951         * psymtab.h (psymtab_storage::obstack): Update.
4952         (psymtab_storage::m_obstack): Use gdb::optional.
4953         (class psymtab_storage): Update comment.  Remove objfile
4954         parameter.
4955         * psymtab.c (psymtab_storage::psymtab_storage): Update.
4956
4957 2019-01-10  Tom Tromey  <tom@tromey.com>
4958
4959         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
4960         <free_psymtabs>: Now private.
4961         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
4962         (allocate_psymtab): Use new method.
4963
4964 2019-01-10  Tom Tromey  <tom@tromey.com>
4965
4966         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
4967         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
4968         * mdebugread.c (parse_partial_symbols): Use
4969         allocate_dependencies.
4970         * dwarf2read.c (dwarf2_create_include_psymtab): Use
4971         allocate_dependencies.
4972         (process_psymtab_comp_unit_reader)
4973         (build_type_psymtab_dependencies): Likewise.
4974         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
4975
4976 2019-01-10  Tom Tromey  <tom@tromey.com>
4977
4978         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
4979         PSYMBOL_SET_LANGUAGE.
4980         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
4981
4982 2019-01-10  Tom Tromey  <tom@tromey.com>
4983
4984         * psymtab.h (psymtab_storage::obstack): New method.
4985         <m_obstack>: Rename from obstack; now private.
4986         * psymtab.c (psymtab_storage): Update.
4987         * dwarf2read.c (create_addrmap_from_index)
4988         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
4989         Update.
4990
4991 2019-01-10  Tom Tromey  <tom@tromey.com>
4992
4993         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
4994         * objfiles.h (objfile::reset_psymtabs): New method.
4995
4996 2019-01-10  Tom Tromey  <tom@tromey.com>
4997
4998         * symmisc.c (print_symbol_bcache_statistics): Update.
4999         (print_objfile_statistics): Update.
5000         * symfile.c (reread_symbols): Update.
5001         * psymtab.h (class psymtab_storage): New.
5002         * psymtab.c (psymtab_storage): New constructor.
5003         (~psymtab_storage): New destructor.
5004         (require_partial_symbols): Update.
5005         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
5006         (find_pc_sect_psymtab, find_pc_sect_psymbol)
5007         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
5008         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
5009         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
5010         (start_psymtab_common, end_psymtab_common)
5011         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
5012         (allocate_psymtab): Update.
5013         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
5014         Update.
5015         (dump_psymtab_addrmap, maintenance_print_psymbols)
5016         (maintenance_check_psymtabs): Update.
5017         (class objfile_psymtabs): Move to objfiles.h.
5018         * psympriv.h (discard_psymtab): Now inline.
5019         (psymtab_discarder::psymtab_discarder): Update.
5020         (psymtab_discarder::~psymtab_discarder): Update.
5021         (ALL_OBJFILE_PSYMTABS): Rewrite.
5022         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
5023         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
5024         Remove fields.
5025         <partial_symtabs>: New field.
5026         (class objfile_psymtabs): Move from psymtab.h.  Update.
5027         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
5028         psymbol_cache.
5029         (objfile::~objfile): Don't destroy psymbol_cache.
5030         * mdebugread.c (parse_partial_symbols): Update.
5031         * dwarf2read.c (create_addrmap_from_index)
5032         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
5033         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
5034         (add_partial_subprogram, dwarf2_ranges_read): Update.
5035         * dwarf-index-write.c (write_address_map)
5036         (write_one_signatured_type, recursively_write_psymbols)
5037         (class debug_names, class debug_names, write_psymtabs_to_index):
5038         Update.
5039
5040 2019-01-10  Tom Tromey  <tom@tromey.com>
5041
5042         * symtab.h (SYMBOL_SET_NAMES): Update.
5043         (symbol_set_names): Update.
5044         (MSYMBOL_SET_NAMES): Update.
5045         * symtab.c (symbol_set_names): Change argument to be an
5046         objfile_per_bfd_storage.
5047         * psymtab.c (add_psymbol_to_bcache): Update.
5048         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
5049
5050 2019-01-10  Tom Tromey  <tom@tromey.com>
5051
5052         * symtab.c (create_demangled_names_hash): Change argument to be an
5053         objfile_per_bfd_storage.
5054         (symbol_set_names): Update.
5055
5056 2019-01-10  Tom Tromey  <tom@tromey.com>
5057
5058         * xcoffread.c (xcoff_initial_scan): Unconditionally call
5059         init_psymbol_list.
5060         * psymtab.c (init_psymbol_list): Do nothing if already called.
5061         * psympriv.h (init_psymbol_list): Add comment.
5062         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
5063         init_psymbol_list.
5064         * dbxread.c (dbx_symfile_read): Unconditionally call
5065         init_psymbol_list.
5066
5067 2019-01-10  Tom Tromey  <tom@tromey.com>
5068
5069         * xcoffread.c (scan_xcoff_symtab): Update.
5070         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
5071         "where".
5072         * mdebugread.c (parse_partial_symbols)
5073         (handle_psymbol_enumerators): Update.
5074         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
5075         * dbxread.c (read_dbx_symtab): Update.
5076         * psympriv.h (psymbol_placement): New enum.
5077         (add_psymbol_to_list): Update.
5078
5079 2019-01-10  Tom Tromey  <tom@tromey.com>
5080
5081         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
5082         static_psymbols parameters.
5083         (scan_xcoff_symtab): Update.
5084         * psymtab.c (start_psymtab_common): Remove global_psymbols and
5085         static_psymbols parameters.
5086         * psympriv.h (start_psymtab_common): Update.
5087         * mdebugread.c (parse_partial_symbols): Update.
5088         * dwarf2read.c (create_partial_symtab): Update.
5089         * dbxread.c (read_dbx_symtab): Update.
5090         (start_psymtab): Remove global_psymbols and static_psymbols
5091         parameters.
5092
5093 2019-01-10  Tom Tromey  <tom@tromey.com>
5094
5095         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
5096         * psymtab.c (allocate_psymtab): Add comment.
5097         * psympriv.h (allocate_psymtab): Add comment.
5098         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
5099         initializations.
5100         * dbxread.c (dbx_end_psymtab): Remove some initializations.
5101
5102 2019-01-10  Tom Tromey  <tom@tromey.com>
5103
5104         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5105         Don't declare.
5106         * mipsread.c: Include mdebugread.h.
5107         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
5108         Declare.
5109         * elfread.c: Include mdebugread.h.
5110
5111 2019-01-09  Tom Tromey  <tom@tromey.com>
5112
5113         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
5114         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
5115         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
5116         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
5117         (psym_lookup_symbol, psym_find_last_source_symtab)
5118         (psym_forget_cached_source_info, psym_print_stats)
5119         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
5120         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
5121         (psym_map_matching_symbols, psym_expand_symtabs_matching)
5122         (psym_find_compunit_symtab_by_address)
5123         (maintenance_print_psymbols, maintenance_info_psymtabs)
5124         (maintenance_check_psymtabs): Use ranged for.
5125         * psymtab.h (class objfile_psymtabs): New.
5126         (require_partial_symbols): Return objfile_psymtabs.
5127         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
5128
5129 2019-01-09  Tom Tromey  <tom@tromey.com>
5130
5131         * symfile.c (overlay_invalidate_all, find_pc_overlay)
5132         (find_pc_mapped_section, list_overlays_command)
5133         (map_overlay_command, unmap_overlay_command)
5134         (simple_overlay_update): Use all_objfiles.
5135         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
5136         * printcmd.c (info_symbol_command): Use all_objfiles.
5137         * objfiles.h (ALL_OBJSECTIONS): Remove.
5138         * maint.c (maintenance_translate_address): Use all_objfiles.
5139         * gcore.c (gcore_create_callback): Use all_objfiles.
5140         (objfile_find_memory_regions): Likewise.
5141
5142 2019-01-09  Tom Tromey  <tom@tromey.com>
5143
5144         * symtab.c (find_line_symtab, info_sources_command)
5145         (make_source_files_completion_list): Use objfile_compunits.
5146         * source.c (select_source_symtab): Use objfile_compunits.
5147         * objfiles.h (struct objfile): Update comment.
5148         (ALL_OBJFILES): Remove.
5149         (ALL_FILETABS): Remove.
5150         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
5151         objfile_compunits.
5152
5153 2019-01-09  Tom Tromey  <tom@tromey.com>
5154
5155         * symmisc.c (print_objfile_statistics, dump_objfile)
5156         (maintenance_print_symbols): Use compunit_filetabs.
5157         * source.c (forget_cached_source_info_for_objfile): Use
5158         compunit_filetabs.
5159         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
5160         (ALL_FILETABS): Use compunit_filetabs.
5161         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
5162         * coffread.c (coff_symtab_read): Use compunit_filetabs.
5163
5164 2019-01-09  Tom Tromey  <tom@tromey.com>
5165
5166         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
5167         (compunit_filetabs): New.
5168         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
5169         compunit_filetabs.
5170         (info_sources_command, make_source_files_completion_list): Remove
5171         declaration.
5172         * symmisc.c (print_objfile_statistics, dump_objfile)
5173         (maintenance_print_symbols): Remove declaration.
5174         (maintenance_info_symtabs): Use compunit_filetabs.
5175         (maintenance_info_line_tables): Likewise.
5176         * source.c (select_source_symtab): Change local variable name.
5177         (forget_cached_source_info_for_objfile): Remove declaration.
5178         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
5179         * objfiles.c (objfile_relocate1): Remove declaration.
5180         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5181         declaration.
5182         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
5183         * coffread.c (coff_symtab_read): Remove declaration.
5184         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5185         compunit_filetabs.
5186
5187 2019-01-09  Tom Tromey  <tom@tromey.com>
5188
5189         * symtab.c (lookup_objfile_from_block)
5190         (find_pc_sect_compunit_symtab, search_symbols)
5191         (default_collect_symbol_completion_matches_break_on): Use
5192         objfile_compunits.
5193         * objfiles.h (ALL_COMPUNITS): Remove.
5194         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
5195         * cp-support.c (add_symbol_overload_list_qualified): Use
5196         objfile_compunits.
5197         * ada-lang.c (ada_collect_symbol_completion_matches)
5198         (ada_add_global_exceptions): Use objfile_compunits.
5199
5200 2019-01-09  Tom Tromey  <tom@tromey.com>
5201
5202         * source.c (select_source_symtab)
5203         (forget_cached_source_info_for_objfile): Remove declaration.
5204         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
5205         declaration.
5206         * maint.c (count_symtabs_and_blocks): Remove declaration.
5207         * cp-support.c (add_symbol_overload_list_qualified): Remove
5208         declaration.
5209         * coffread.c (coff_symtab_read): Remove declaration.
5210         * symtab.c (lookup_symbol_in_objfile_symtabs)
5211         (basic_lookup_transparent_type_1): Use objfile_compunits.
5212         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
5213         (info_sources_command, search_symbols)
5214         (default_collect_symbol_completion_matches_break_on)
5215         (make_source_files_completion_list): Remove declaration.
5216         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
5217         (ada_collect_symbol_completion_matches)
5218         (ada_add_global_exceptions): Remove declaration.
5219         * linespec.c (iterate_over_all_matching_symtabs): Use
5220         objfile_compunits.
5221         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
5222         (class objfile_compunits): New.
5223         (ALL_COMPUNITS): Use objfile_compunits.
5224         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
5225         (maintenance_check_symtabs, maintenance_info_line_tables): Use
5226         objfile_compunits.
5227         * objfiles.c (objfile_relocate1): Use objfile_compunits.
5228
5229 2019-01-09  Tom Tromey  <tom@tromey.com>
5230
5231         * symtab.c (search_symbols)
5232         (default_collect_symbol_completion_matches_break_on): Use
5233         objfile_msymbols.
5234         * ada-lang.c (ada_lookup_simple_minsym)
5235         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
5236         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
5237         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
5238         objfile_msymbols.
5239         * coffread.c (coff_symfile_read): Use objfile_msymbols.
5240         * symmisc.c (dump_msymbols): Use objfile_msymbols.
5241         * objc-lang.c (find_methods): Use objfile_msymbols.
5242         (info_selectors_command, info_classes_command): Likewise.
5243         * stabsread.c (scan_file_globals): Use objfile_msymbols.
5244         * objfiles.h (class objfile_msymbols): New.
5245         (ALL_OBJFILE_MSYMBOLS): Remove.
5246         (ALL_MSYMBOLS): Remove.
5247
5248 2019-01-09  Tom Tromey  <tom@tromey.com>
5249
5250         * common/next-iterator.h (next_adapter): Add Iterator template
5251         parameter.
5252         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
5253         (class all_objfiles_safe): New.
5254         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
5255         * objfiles.c (put_objfile_before): Update comment.
5256         (add_separate_debug_objfile): Likewise.
5257         (free_all_objfiles): Use all_objfiles_safe.
5258         (objfile_purge_solibs): Likewise.
5259
5260 2019-01-09  Tom Tromey  <tom@tromey.com>
5261
5262         * symtab.c (iterate_over_symtabs, matching_obj_sections)
5263         (expand_symtab_containing_pc, lookup_static_symbol)
5264         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
5265         (find_symbol_at_address, find_line_symtab, find_main_name): Use
5266         all_objfiles.
5267         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
5268         * breakpoint.c (create_overlay_event_breakpoint)
5269         (create_longjmp_master_breakpoint)
5270         (create_std_terminate_master_breakpoint)
5271         (create_exception_master_breakpoint): Use all_objfiles.
5272         * linux-thread-db.c (try_thread_db_load_from_pdir)
5273         (has_libpthread): Use all_objfiles.
5274         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
5275         * linespec.c (iterate_over_all_matching_symtabs)
5276         (search_minsyms_for_name): Use all_objfiles.
5277         * maint.c (maintenance_info_sections): Use all_objfiles.
5278         * main.c (captured_main_1): Use all_objfiles.
5279         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
5280         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
5281         * guile/scm-pretty-print.c
5282         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
5283         * solib-spu.c (append_ocl_sos): Use all_objfiles.
5284         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
5285         (maintenance_print_msymbols): Use all_objfiles.
5286         * source.c (select_source_symtab): Use all_objfiles.
5287         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
5288         * symfile.c (remove_symbol_file_command)
5289         (expand_symtabs_matching, map_symbol_filenames): Use
5290         all_objfiles.
5291         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
5292         all_objfiles.
5293         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
5294         * objc-lang.c (find_methods): Use all_objfiles.
5295         * objfiles.c (have_partial_symbols, have_full_symbols)
5296         (have_minimal_symbols, qsort_cmp)
5297         (default_iterate_over_objfiles_in_search_order): Use
5298         all_objfiles.
5299         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
5300         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
5301         (maintenance_check_psymtabs): Use all_objfiles.
5302         (ALL_PSYMTABS): Remove.
5303         * compile/compile-object-run.c (do_module_cleanup): Use
5304         all_objfiles.
5305         * blockframe.c (find_pc_partial_function): Use all_objfiles.
5306         * cp-support.c (add_symbol_overload_list_qualified): Use
5307         all_objfiles.
5308         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
5309         Use all_objfiles.
5310         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
5311         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
5312         all_objfiles.
5313         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
5314         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
5315         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
5316         Uses all_objfiles.
5317         * solib.c (solib_read_symbols): Use all_objfiles
5318
5319 2019-01-09  Tom Tromey  <tom@tromey.com>
5320
5321         * probe.c (parse_probes_in_pspace): Use all_objfiles.
5322         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
5323         all_objfiles.
5324         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
5325         * symmisc.c (print_symbol_bcache_statistics)
5326         (print_objfile_statistics, maintenance_print_objfiles)
5327         (maintenance_info_symtabs, maintenance_check_symtabs)
5328         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
5329         all_objfiles.
5330         * source.c (forget_cached_source_info): Use all_objfiles.
5331         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
5332         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
5333         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
5334         * objfiles.c (update_section_map): Use all_objfiles.
5335         (shared_objfile_contains_address_p): Likewise.
5336         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
5337         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
5338
5339 2019-01-09  Tom Tromey  <tom@tromey.com>
5340
5341         * common/next-iterator.h: New file.
5342         * objfiles.h (class all_objfiles): New.
5343         (struct objfile_iterator): New.
5344
5345 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5346
5347         * NEWS: Move the description of the changed "frame", "select-frame",
5348          and "info frame" commands to the Changed commands section.
5349
5350 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
5351
5352         * gdbtypes.c (check_stub_method_group): Remove handling of old
5353         mangling schemes.
5354         * linespec.c (find_methods): Likewise.
5355         * stabsread.c (read_member_functions): Likewise.
5356         * valops.c (search_struct_method): Likewise.
5357         (value_struct_elt_for_reference): Likewise.
5358         * NEWS: Mention this change.
5359
5360 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
5361
5362         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
5363         print_source_lines.
5364         * source.c (print_source_lines_base): Update line number check.
5365         (print_source_lines): New function.
5366         (source_lines_range::source_lines_range): New function.
5367         * source.h (class source_lines_range): New class.
5368         (print_source_lines): New declaration.
5369
5370 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5371
5372         * linespec.c (linespec_state_destructor): Free self->canonical_names.
5373
5374 2019-01-08  Tom Tromey  <tom@tromey.com>
5375             Simon Marchi  <simon.marchi@ericsson.com>
5376
5377         PR gdb/24060
5378         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
5379         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
5380         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5381         * f-exp.y (DOLLAR_VARIABLE): Likewise.
5382         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
5383         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
5384
5385 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5386
5387         * source.c (select_source_symtab): Move header comment to
5388         declaration in source.h.
5389         (forget_cached_source_info_for_objfile): Likewise.
5390         (forget_cached_source_info): Likewise.
5391         (identify_source_line): Likewise.
5392         * source.h (identify_source_line): Move declaration from symtab.h
5393         and add comment from source.c
5394         (print_source_lines): Likewise.
5395         (forget_cached_source_info_for_objfile): Likewise.
5396         (forget_cached_source_info): Likewise.
5397         (select_source_symtab): Likewise.
5398         (enum print_source_lines_flag): Move definition from symtab.h.
5399         * symtab.h (identify_source_line): Move declaration to source.h.
5400         (print_source_lines): Likewise.
5401         (forget_cached_source_info_for_objfile): Likewise.
5402         (forget_cached_source_info): Likewise.
5403         (select_source_symtab): Likewise.
5404         (enum print_source_lines_flag): Move definition to source.h.
5405         * tui/tui-hooks.c: Add 'source.h' include.
5406
5407 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5408
5409         * source.c (print_source_lines_base): Handle requests to print
5410         reverse line number sequences, and guard against empty lines
5411         string.
5412
5413 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
5414
5415         * source.c (print_source_lines_base): Fix skip of '\r' if next
5416         character is '\n'.
5417
5418 2019-01-06  Tom Tromey  <tom@tromey.com>
5419
5420         * c-exp.y (struct c_parse_state) <macro_original_text,
5421         expansion_obstack>: New member.
5422         (macro_original_text, expansion_obstack): Remove globals.
5423         (scan_macro_expansion, scanning_macro_expansion)
5424         (finished_macro_expansion): Update.
5425         (scan_macro_cleanup): Remove.
5426         (yylex, c_parse): Update.
5427
5428 2019-01-06  Tom Tromey  <tom@tromey.com>
5429
5430         * c-exp.y (struct c_parse_state) <strings>: New member.
5431         (operator_stoken): Update.
5432
5433 2019-01-06  Tom Tromey  <tom@tromey.com>
5434
5435         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
5436         (union type_stack_elt) <typelist_val>: Now a pointer to
5437         std::vector.
5438         (type_stack_cleanup): Don't declare.
5439         (push_typelist): Update.
5440         * parse.c (pop_typelist): Return a std::vector.
5441         (push_typelist): Take a std::vector.
5442         (follow_types): Update.  Do not free args.
5443         (type_stack_cleanup): Remove.
5444         * c-exp.y (struct c_parse_state): New.
5445         (cpstate): New global.
5446         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
5447         (nonempty_typelist): Update.
5448         (func_mod): Create a new vector.
5449         (c_parse): Create a c_parse_state.
5450         (check_parameter_typelist): Do not delete params.
5451         (function_method): Update.  Do not delete type_list.
5452
5453 2019-01-06  Tom Tromey  <tom@tromey.com>
5454
5455         PR gdb/28155:
5456         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
5457         check_typedef.
5458         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
5459         (print_return_value): Likewise.
5460
5461 2019-01-05  Tom Tromey  <tom@tromey.com>
5462
5463         * contrib/cleanup_check.py: Remove.
5464         * contrib/gcc-with-excheck: Remove.
5465         * contrib/exsummary.py: Remove.
5466         * contrib/excheck.py: Remove.
5467
5468 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
5469
5470         * thread.c (delete_thread_1): Add gdb_assert that THR is not
5471         NULL. Initialize tpprev to NULL instead of assigning it
5472         to NULL on the next statement.
5473         * windows-nat.c (windows_delete_thread): Remove check for
5474         main_thread_id before printing thread exit notifications.
5475         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
5476         Remove thread ID check against main_thread_id.
5477         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
5478         windows_delete_thread.
5479         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
5480
5481 2019-01-04  Tom Tromey  <tom@tromey.com>
5482
5483         * compile/compile.c (_initialize_compile): Use upper case for
5484         metasyntactic variables.
5485         * symmisc.c (_initialize_symmisc): Use upper case for
5486         metasyntactic variables.
5487         * psymtab.c (_initialize_psymtab): Use upper case for
5488         metasyntactic variables.
5489         * demangle.c (demangle_command): Use upper case for metasyntactic
5490         variables.
5491         (_initialize_demangler): Likewise.
5492         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
5493         variables.
5494
5495 2019-01-03  Tom Tromey  <tom@tromey.com>
5496
5497         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
5498
5499 2019-01-03  Tom Tromey  <tom@tromey.com>
5500
5501         * python/py-symtab.c (salpy_str): Update.
5502         (struct salpy_sal_object) <symtab>: Now a PyObject.
5503         (salpy_dealloc): Update.
5504         (del_objfile_sal): Use gdbpy_ref.
5505
5506 2019-01-03  Tom Tromey  <tom@tromey.com>
5507
5508         * python/py-type.c (convert_field): Use new_reference.  Return
5509         gdbpy_ref.
5510         (make_fielditem): Return gdbpy_ref.
5511         (typy_fields): Update.
5512         (typy_getitem): Update.
5513         (field_name): Return gdbpy_ref.  Use new_reference.
5514         (typy_iterator_iternext): Update.
5515
5516 2019-01-03  Tom Tromey  <tom@tromey.com>
5517
5518         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
5519
5520 2019-01-03  Tom Tromey  <tom@tromey.com>
5521
5522         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
5523         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
5524         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
5525         (pspy_set_frame_filters, pspy_set_frame_unwinders)
5526         (pspy_set_type_printers): Likewise.
5527         * python/py-function.c (fnpy_init): Use gdbpy_ref.
5528         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
5529         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
5530         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
5531         (objfpy_set_type_printers): Likewise.
5532
5533 2019-01-03  Tom Tromey  <tom@tromey.com>
5534
5535         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
5536         (gdbpy_print_stack): Use gdbpy_err_fetch.
5537         * python/python-internal.h (class gdbpy_err_fetch): New class.
5538         (class gdbpy_enter) <m_error_type, m_error_value,
5539         m_error_traceback>: Remove.
5540         <m_error>: New member.
5541         (gdbpy_exception_to_string): Don't declare.
5542         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
5543         * python/py-value.c (convert_value_from_python): Use
5544         gdbpy_err_fetch.
5545         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
5546         gdbpy_exception_to_string.
5547         (gdbpy_handle_exception): Use gdbpy_err_fetch.
5548         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
5549         gdbpy_err_fetch.
5550
5551 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5552
5553         * linux-nat.c (delete_lwp_cleanup): Delete.
5554         (struct lwp_deleter): New struct.
5555         (lwp_info_up): New typedef.
5556         (linux_nat_target::follow_fork): Delete cleanup, and make use of
5557         lwp_info_up.
5558
5559 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5560
5561         * linux-fork.c (class scoped_switch_fork_info): New class.
5562         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
5563
5564 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5565
5566         * valops.c (find_overload_match): Remove use of null_cleanup, and
5567         calls to do_cleanups.
5568
5569 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5570
5571         * compile/compile-cplus-types.c
5572         (compile_cplus_instance::decl_name): Handle changes to
5573         cp_func_name.
5574         * cp-support.c (cp_func_name): Update header comment, update
5575         return type.
5576         * cp-support.h (cp_func_name): Update return type in declaration.
5577         * valops.c (find_overload_match): Move temp_func local to top
5578         level of function and change its type.  Use temp_func to hold and
5579         delete temporary string obtained from cp_func_name.
5580
5581 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5582
5583         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
5584         gdb::char_vector, remove cleanup, and update uses of `msg`.
5585
5586 2019-01-03  Jim Wilson  <jimw@sifive.com>
5587
5588         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
5589
5590 2019-01-02  Tom Tromey  <tom@tromey.com>
5591
5592         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
5593         (tdesc_parse_xml): Remove cleanups.
5594         * target-descriptions.h (make_cleanup_free_target_description):
5595         Don't declare.
5596         (target_desc_deleter): New struct.
5597         (target_desc_up): New typedef.
5598         * target-descriptions.c (target_desc_deleter::operator()): Rename
5599         from free_target_description.
5600         (make_cleanup_free_target_description): Remove.
5601
5602 2019-01-02  Tom Tromey  <tom@tromey.com>
5603
5604         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
5605         constructor, destructor.
5606         (linespec_parser): Remove typedef.
5607         (~linespec_parser): Rename from linespec_parser_delete.
5608         (linespec_lex_to_end, linespec_complete_label)
5609         (linespec_complete): Update.
5610         (decode_line_full): Remove cleanups.
5611         (decode_line_1): Update.
5612
5613 2019-01-02  Tom Tromey  <tom@tromey.com>
5614
5615         * python/python-internal.h (inferior_to_inferior_object): Change
5616         return type.
5617         * python/py-exitedevent.c (create_exited_event_object): Update.
5618         * python/py-inferior.c (inferior_to_inferior_object): Return
5619         gdbpy_ref.
5620         (python_new_inferior, python_inferior_deleted)
5621         (thread_to_thread_object, delete_thread_object)
5622         (build_inferior_list, gdbpy_selected_inferior): Update.
5623         * python/py-infthread.c (create_thread_object): Update.  Also fail
5624         if inferior_to_inferior_object fails.
5625
5626 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
5627
5628         * inferior.h (class inferior) <displaced_step_state>: New field.
5629         * infrun.h (struct displaced_step_state): Move here from
5630         infrun.c.  Initialize fields, add constructor.
5631         <inf>: Remove field.
5632         <reset>: New method.
5633         * infrun.c (struct displaced_step_inferior_state): Move to
5634         infrun.h.
5635         (displaced_step_inferior_states): Remove.
5636         (get_displaced_stepping_state): Adust.
5637         (displaced_step_in_progress_any_inferior): Adjust.
5638         (displaced_step_in_progress_thread): Adjust.
5639         (displaced_step_in_progress): Adjust.
5640         (add_displaced_stepping_state): Remove.
5641         (get_displaced_step_closure_by_addr): Adjust.
5642         (remove_displaced_stepping_state): Remove.
5643         (infrun_inferior_exit): Call displaced_step_state.reset.
5644         (use_displaced_stepping): Don't check for NULL.
5645         (displaced_step_prepare_throw): Call
5646         get_displaced_stepping_state.
5647         (displaced_step_fixup): Don't check for NULL.
5648         (prepare_for_detach): Don't check for NULL.
5649
5650 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5651
5652         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
5653          in case of call that did not complete.
5654
5655 2019-01-02  Andrey Utkin  <autkin@undo.io>
5656
5657         * symfile.c (find_separate_debug_file): Fix search of debug files for
5658         remote debuggee.
5659
5660 2019-01-02  Tom Tromey  <tom@tromey.com>
5661
5662         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
5663         indentation.
5664         * python/py-frame.c (frapy_older): Remove cast.
5665         (frapy_newer): Likewise.
5666         * python/py-breakpoint.c (local_setattro): Remove cast.
5667         * python/py-arch.c (archpy_name): Remove local variable.
5668         * python/py-type.c (gdbpy_lookup_type): Remove cast.
5669
5670 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
5671
5672         * unittests/basic_string_view/element_access/char/empty.cc:
5673         Fix year range in copyright header.
5674
5675 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
5676
5677         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
5678         Delete.
5679         <operator==>: Update with for removed field.
5680         <hash>: Likewise.
5681         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
5682         <isa_features>: ...this.
5683         <abi_features>: New field.
5684         (riscv_isa_flen): Update comment.
5685         (riscv_abi_xlen): New declaration.
5686         (riscv_abi_flen): New declaration.
5687         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
5688         isa_features.
5689         (riscv_abi_xlen): New function.
5690         (riscv_isa_flen): Update to get answer from isa_features.
5691         (riscv_abi_flen): New function.
5692         (riscv_has_fp_abi): Update to get answer from abi_features.
5693         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
5694         xlen and flen.
5695         (riscv_call_info) <xlen, flen>: Update comment.
5696         (riscv_call_arg_struct): Remove invalid assertions
5697         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
5698         is removed.
5699         (riscv_gdbarch_init): Gather isa features and abi features
5700         separately, ensure both match on the gdbarch when reusing an old
5701         gdbarch.  Relax an error check to allow 32-bit abi float to run on
5702         a target with 64-bit float hardware.
5703
5704 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5705
5706         * source.c (search_command_helper): Stop reverse search
5707         when line 1 has been searched.
5708
5709 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5710
5711         * record-full.c (record_full_base_target::close): Rewrite
5712         record_full_core_buf_list free logic.
5713
5714 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5715
5716         * break-catch-syscall.c (print_one_catch_syscall): xfree
5717         the last text.
5718
5719 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5720
5721         * top.c (print_gdb_version): Update Copyright year in version
5722         message.
5723
5724 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
5725
5726         Update copyright year range in all GDB files.
5727
5728 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
5729
5730         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
5731
5732 For older changes see ChangeLog-2018.
5733 \f
5734 Local Variables:
5735 mode: change-log
5736 left-margin: 8
5737 fill-column: 74
5738 version-control: never
5739 coding: utf-8
5740 End:
5741