gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
   4         after item.
   5
   6 2019-06-13  Pedro Alves  <palves@redhat.com>
   7
   8         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
   9
  10 2019-06-13  Pedro Alves <palves@redhat.com>
  11
  12         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
  13         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
  14         call.
  15         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
  16         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
  17         calls.
  18         (check_for_argument): Skip spaces after argument.
  19
  20 2019-06-13  Pedro Alves  <palves@redhat.com>
  21
  22         * thread.c (thread_apply_command): Adjust TID parsing.
  23         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
  24         detected before end of string.
  25         (tid_is_in_list): Error out if LIST is invalid.
  26
  27 2019-06-13  Pedro Alves  <palves@redhat.com>
  28
  29         * completer.c (complete_line_internal_1): Rewind completion word
  30         point.
  31         (completion_tracker::advance_custom_word_point_by): Change
  32         parameter type to int.
  33         * completer.h (completion_tracker::advance_custom_word_point_by):
  34         Likewise.
  35
  36 2019-06-13  Pedro Alves  <palves@redhat.com>
  37
  38         * completer.c (advance_to_completion_word): Handle delimiters.
  39
  40 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
  41
  42         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
  43
  44 2019-06-11  Tom Tromey  <tom@tromey.com>
  45
  46         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
  47         (xmalloc_failed): Move to alloc.c.
  48         * alloc.c: New file.
  49         * Makefile.in (COMMON_SFILES): Add alloc.c.
  50
  51 2019-06-11  Tom Tromey  <tom@tromey.com>
  52
  53         * nat/linux-waitpid.c: Don't include server.h.
  54         (linux_debug): Remove.
  55         (my_waitpid): Update.
  56
  57 2019-06-11  Tom Tromey  <tromey@adacore.com>
  58
  59         * infcall.c (_initialize_infcall): Remove trailing newline from
  60         help.
  61         * user-regs.c (_initialize_user_regs): Remove trailing newline
  62         from help.
  63         * typeprint.c (_initialize_typeprint): Remove trailing newline
  64         from help.
  65         * reverse.c (_initialize_reverse): Remove trailing newlines from
  66         help.
  67         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
  68         from help.
  69         * language.c (add_set_language_command): Remove trailing newline
  70         from help.
  71         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
  72         help.
  73         * disasm.c (_initialize_disasm): Remove trailing newline from
  74         help.
  75         * top.c (init_main): Remove trailing newline from help.
  76         * interps.c (_initialize_interpreter): Remove trailing newline
  77         from help.
  78         * btrace.c (_initialize_btrace): Remove trailing newlines from
  79         help.
  80         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
  81         from help.
  82         * python/python.c (_initialize_python): Remove trailing newline
  83         from help.
  84         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
  85         help.
  86         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
  87         from help.  Reformat some text.
  88         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
  89         from help.
  90         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
  91         newline from help.
  92
  93 2019-06-11  Tom Tromey  <tromey@adacore.com>
  94
  95         * darwin-nat.c (darwin_decode_exception_message)
  96         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
  97
  98 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
  99
 100         * valops.c (value_slice): Check for not allocated or not
 101         associated values.
 102
 103 2019-06-10  Tom de Vries  <tdevries@suse.de>
 104
 105         PR gdb/24618
 106         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 107         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 108         invalid.
 109
 110 2019-06-10  Tom de Vries  <tdevries@suse.de>
 111
 112         PR gdb/24611
 113         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 114         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 115
 116 2019-06-10  Tom de Vries  <tdevries@suse.de>
 117
 118         PR symtab/24545
 119         * symtab.c (struct demangled_name_entry): Add language field.
 120         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 121         static minimal symbol".  Set and use language field.
 122
 123 2019-06-10  Tom Tromey  <tromey@adacore.com>
 124
 125         * ada-lang.c (_initialize_ada_language): Update help text.
 126
 127 2019-06-10  Tom Tromey  <tromey@adacore.com>
 128
 129         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 130         with a newline.
 131         * guile/guile.c (handle_boot_error): Don't end warning with a
 132         newline.
 133         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 134         warning with a newline.
 135         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 136         newline.
 137         (s12z_frame_cache): Likewise.
 138         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 139         a newline.
 140         * solib-svr4.c (disable_probes_interface): Don't end warning with
 141         a newline.
 142         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 143         newline.
 144         * python/python.c (do_finish_initialization): Don't end warning
 145         with a newline.
 146
 147 2019-06-10  Tom Tromey  <tom@tromey.com>
 148
 149         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 150         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 151         gdbpy_enter.
 152
 153 2019-06-10  Tom Tromey  <tromey@adacore.com>
 154
 155         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 156         data.
 157         (elf_new_init): Don't call stabsread_new_init.
 158         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 159         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 160         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 161
 162 2019-06-10  Tom de Vries  <tdevries@suse.de>
 163
 164         PR symtab/16264
 165         PR symtab/24517
 166         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 167
 168 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 169
 170         * source.c (find_and_open_source): Also rewrite relative file
 171         names.
 172
 173 2019-04-26  Amos Bird  <amosbird@gmail.com>
 174
 175         * annotate.c (annotate_thread_exited): Add "thread-exited"
 176         annotation.
 177
 178 2019-06-06  Tom Tromey  <tromey@adacore.com>
 179
 180         * maint.h (class scoped_command_stats): Use
 181         DISABLE_COPY_AND_ASSIGN.
 182         <print_time>: New method.
 183         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 184         print_time.
 185         (scoped_command_stats::print_time): New method.
 186
 187 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 188
 189         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 190         instructions of lengths 6 or 8 bytes.
 191
 192 2019-06-04  Pedro Alves  <palves@redhat.com>
 193
 194         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 195
 196         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 197         * breakpoint.c (condition_completer): Likewise.
 198         * cli/cli-dump.c (scan_expression): Likewise.
 199         * common/filestuff.c (mkdir_recursive): Likewise.
 200         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 201         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 202         (gdb_abspath): Likewise.
 203         * compile/compile-cplus-types.c
 204         (compile_cplus_instance::decl_name): Likewise.
 205         * completer.c (complete_explicit_location):
 206         (signal_completer, reg_or_group_completer_1): Likewise.
 207         * cp-support.c (cp_remove_params_if_any): Likewise.
 208         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 209         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 210         * infcmd.c (strip_bg_char): Likewise.
 211         * linespec.c (copy_token_string): Likewise.
 212         * mi/mi-main.c (output_cores): Likewise.
 213         * psymtab.c (psymtab_search_name):
 214         * symfile.c (test_set_ext_lang_command): Likewise.
 215         * target.c (target_fileio_read_stralloc): Likewise.
 216         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 217         * value.c (complete_internalvar): Likewise.
 218
 219 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 220
 221         Add objfile property to gdb.Type.
 222         * NEWS: Mention Python API addition.
 223         * python/py-type.c (typy_get_objfile): New method.
 224
 225 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 226
 227         * NEWS: Mention the new set|show style [title|highlight].
 228         Mention changes to "show style", "help" and "apropos".
 229
 230 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 231
 232         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 233         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 234         instead of print_help_for_command.
 235         (print_doc_of_command): New function.
 236         (help_list): Add 'apropos -v word' suggestion.
 237         (print_help_for_command): Style the command name using title style.
 238         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 239         (_initialize_cli_cmds): Describe -v in apropos_command help.
 240
 241 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 242
 243         * cli/cli-style.h (cli_style_option): Add name in constructor,
 244         add m_name class member, add constructor with intensity,
 245         add name class function.
 246         (cli_style_option::add_setshow_commands): Remove name argument.
 247         (highlight_style, title_style): New styles.
 248         * cli/cli-style.c (do_show): New function that shows a style
 249         characteristic styling the style name with itself.
 250         (set_style_name): New function.
 251         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 252         Update all callers according to the changes in cli/cli-style.h.
 253         * utils.h (fputs_highlighted): New function.
 254         * utils.c (fputs_highlighted): Likewise.
 255
 256 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 257
 258         * NEWS: Mention new pipe command and new convenience variables.
 259
 260 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 261
 262         * cli/cli-cmds.c (pipe_command): New function.
 263         (_initialize_cli_cmds): Call add_com for pipe_command.
 264         Define | as an alias for pipe.
 265         (exit_status_set_internal_vars): New function.
 266         (shell_escape): Call exit_status_set_internal_vars.
 267         cli/cli-decode.c (find_command_name_length): Recognize | as
 268         a single character command.
 269
 270 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 271
 272         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 273         top.c (execute_command_to_ui_file): New function, mostly a copy
 274         of execute_command_to_string.
 275         (execute_command_to_string): Implement by calling
 276         execute_command_to_ui_file.
 277
 278 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 279
 280         * top.h (saved_command_line): Remove declaration.
 281         * top.c (previous_saved_command_line, previous_repeat_arguments):
 282         New variables.
 283         (saved_command_line): Make static, define together with other
 284         'repeat variables'.
 285         (dont_repeat): Clear repeat_arguments.
 286         (repeat_previous, get_saved_command_line, save_command_line):
 287         New functions.
 288         (gdb_init): Initialize saved_command_line
 289         and previous_saved_command_line.
 290         * main.c (captured_main_1): Remove saved_command_line initialization.
 291         * event-top.c (handle_line_of_input): Update to use
 292         the new 'repeat' related functions instead of direct access to
 293         saved_command_line.
 294         * command.h (repeat_previous, get_saved_command_line,
 295         save_command_line): New declarations.
 296         (dont_repeat): Add comment.
 297
 298 2019-05-30  Tom Tromey  <tromey@adacore.com>
 299
 300         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 301         Fix comment.
 302         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 303
 304 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 305
 306         PR cli/24587
 307         * completer.c (complete): Initialize variable word.
 308
 309 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 310
 311         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 312         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 313         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 314         'body' is NULL to the outter 'if', protecting the '!is_define'
 315         situation as well.
 316
 317 2019-05-29  Tom Tromey  <tromey@adacore.com>
 318
 319         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 320         (dwarf_unknown): New function.
 321         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 322         (dwarf_type_encoding_name): Use dwarf_unknown.
 323
 324 2019-05-29  Tom Tromey  <tromey@adacore.com>
 325
 326         PR c++/20020:
 327         * cp-valprint.c (cp_print_value_fields): Call
 328         cp_print_static_field inside "try".
 329
 330 2019-05-29  Tom Tromey  <tromey@adacore.com>
 331
 332         * inflow.c (struct terminal_info): Add default operator=.
 333         * configure: Rebuild.
 334         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 335         -Wdeprecated-copy-dtor, -Wredundant-move.
 336
 337 2019-05-29  Tom Tromey  <tromey@adacore.com>
 338
 339         * NEWS: Add entry.
 340         * infcmd.c (print_return_value_1): Handle finish_print
 341         option.
 342         (show_print_finish): New function.
 343         (_initialize_infcmd): Add "set/show print finish" commands.
 344         * valprint.c (user_print_options): Initialize new member.
 345         * valprint.h (struct value_print_options) <finish_print>: New
 346         member.
 347
 348 2019-05-28  Tom Tromey  <tromey@adacore.com>
 349
 350         * ada-lang.c (ada_remove_Xbn_suffix)
 351         (find_old_style_renaming_symbol)
 352         (parse_old_style_renaming): Remove.
 353         (ada_find_renaming_symbol): Don't call
 354         find_old_style_renaming_symbol.
 355         (ada_is_renaming_symbol): Rename from
 356         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 357         bool.  Now static.
 358         (ada_read_var_value): Update and simplify.
 359         * ada-exp.y (write_var_or_type): Remove old code.
 360
 361 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 362
 363         * event-top.c: Remove include comment.
 364         * inflow.c (class scoped_ignore_sigttou): Move from here...
 365         * inflow.h (class scoped_ignore_sigttou): ...to here.
 366         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 367         * top.c:  Remove include comment.
 368
 369 2019-05-27  Tom Tromey  <tom@tromey.com>
 370
 371         * NEWS: Fix typo.
 372
 373 2019-05-22  Tom Tromey  <tromey@adacore.com>
 374
 375         * target.c (target_follow_exec): Constify parameter.
 376         * target-delegates.c: Rebuild.
 377         * remote.c (remote_target::follow_exec): Constify parameter.
 378         * infrun.c (follow_exec): Constify parameter.
 379         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 380         (target_follow_exec): Likewise.
 381
 382 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 383
 384         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 385         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 386
 387 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 388
 389         * NEWS: Add debugredirect and testsuite sections.
 390
 391 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 392
 393         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 394         target descriptions using exclusively floating point register name
 395         aliases.
 396
 397 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 398
 399         PR gdb/18644:
 400         * f-lang.c (build_fortran_types): Handle the case where
 401         gdbarch_floatformat_for_type returns a nullptr.
 402
 403 2019-05-21  Tom de Vries  <tdevries@suse.de>
 404
 405         PR cli/24587
 406         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 407
 408 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 409
 410         PR gdb/18644:
 411         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 412         16-byte floats.
 413         * i386-tdep.c (i386_floatformat_for_type): Use
 414         floatformats_ia64_quad for the 16-byte floating point component
 415         within a fortran 32-byte complex number.
 416
 417 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 418
 419         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 420         delete default constructor.
 421         (find_partial_die): Update to return const struct.
 422         (partial_die_parent_scope): Move variable declaration into scope
 423         of its use and change its type to auto.
 424         (guess_partial_die_structure_name): Likewise.
 425         (partial_die_info::fixup): Likewise.
 426
 427 2019-05-17  Tom Tromey  <tromey@adacore.com>
 428
 429         * source.c (find_and_open_source): Remove cast.
 430
 431 2019-05-17  Tom Tromey  <tromey@adacore.com>
 432
 433         * annotate.c (annotate_source): Make "filename" const.
 434         * annotate.h (annotate_source): Use const.
 435
 436 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 437
 438         * disasm.c (set_disassembler_options): Send errors to stderr.
 439
 440 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 441
 442         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 443         (cli_interp_base::set_logging): Check debug_redirect.
 444         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 445         * cli/cli-logging.c (debug_redirect): Add static variable.
 446         (pop_output_files): Add default param.
 447         (handle_redirections): Print debug setting.
 448         (show_logging_command): Likewise.
 449         (_initialize_cli_logging): Add debugredirect command.
 450         * interps.c (current_interp_set_logging): Add debug_redirect
 451         parameter.
 452         * interps.h (set_logging): Add debug_redirect parameter.
 453         (current_interp_set_logging): Likewise.
 454         * mi/mi-common.h: Likewise.
 455         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 456
 457 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 458             Tom Tromey  <tromey@adacore.com>
 459
 460         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 461         directly.
 462         * cli/cli-interp.h (make_logging_output): Remove declaration.
 463         * cli/cli-logging.c (make_logging_output): Remove function.
 464         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 465         directly.
 466         * ui-file.c (tee_file::tee_file): Remove bools.
 467         (tee_file::~tee_file): Remove deletes.
 468         * ui-file.h (tee_file): Remove bools.
 469
 470 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 471
 472         * mi/mi-cmds.h (mi_cmd_complete): New function.
 473         * mi/mi-main.c (mi_cmd_complete): Likewise.
 474         * mi/mi-cmds.c: Define new MI command -complete.
 475         * NEWS: Mention new -complete command.
 476
 477 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 478
 479         * completer.h (complete): New function.
 480         * completer.c (complete): Likewise.
 481         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 482         function defined in completer.h.
 483
 484 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 485
 486        * MAINTAINERS (Write After Approval): Add myself.
 487
 488 2019-05-17  Tom de Vries  <tdevries@suse.de>
 489
 490         PR gdb/24094
 491         * dwarf2read.c (struct cu_partial_die_info): New struct.
 492         (find_partial_die): Return cu_partial_die_info.
 493         (partial_die_parent_scope, guess_partial_die_structure_name)
 494         (partial_die_info::fixup): Handle new return type of find_partial_die.
 495
 496 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 497
 498         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 499         "std::string", simplifying the algorithm.
 500
 501 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 502
 503         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 504         (stap_static_probe_ops::get_probes): Likewise.
 505
 506 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 507
 508         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 509         '-')" and "else if".
 510         (stap_parse_single_operand): Join checks for
 511         "gdbarch_stap_parse_special_token_p" and
 512         "gdbarch_stap_parse_special_token" in the same "if" statement.
 513         Invert check when verifying for operation on register
 514         displacement.
 515
 516 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 517
 518         * stap-probe.c (stap_get_opcode): Update comment.
 519         (stap_get_expected_argument_type): Likewise.
 520         (handle_stap_probe): Likewise.
 521
 522 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 523
 524         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 525         return type to 'bool'.  Adjust comment.  Use 'bool' when
 526         appropriate.
 527         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 528         * stap-probe.c (stap_parse_argument_1): Likewise.
 529         (stap_is_operator): Likewise.
 530         (stap_is_generic_prefix): Likewise.
 531         (stap_is_register_prefix): Likewise.
 532         (stap_is_register_indirection_prefix): Likewise.
 533         (stap_is_integer_prefix): Likewise.
 534         (stap_generic_check_suffix): Likewise.
 535         (stap_check_integer_suffix): Likewise.
 536         (stap_check_register_suffix): Likewise.
 537         (stap_check_register_indirection_suffix): Likewise.
 538         (stap_parse_register_operand): Likewise.
 539         (stap_parse_single_operand): Likewise.
 540         (stap_parse_argument_1): Likewise.
 541         (stap_probe::get_argument_count): Likewise.
 542         (stap_is_operator): Likewise.
 543
 544 2019-05-16  Tom Tromey  <tromey@adacore.com>
 545
 546         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 547         keyword to foreach.
 548
 549 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 550
 551         * linux-thread-db.c (try_thread_db_load_1): Change return type
 552         to bool.
 553         (try_thread_db_load): Likewise.
 554         (try_thread_db_load_from_pdir_1): Likewise.
 555         (try_thread_db_load_from_pdir): Likewise.
 556         (try_thread_db_load_from_sdir): Likewise.
 557         (try_thread_db_load_from_dir): Likewise.
 558         (thread_db_load_search): Likewise.
 559         (has_libpthread): Likewise.
 560         (thread_db_load): Likewise.
 561
 562 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 563
 564         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 565         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 566         NULL, and complain/return if that's the case.
 567
 568 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 569
 570         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 571         (advance, posn, abstract_read_memory): New functions.
 572         [struct mem_read_abstraction]: New struct.
 573         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 574
 575 2019-05-14  Tom Tromey  <tromey@adacore.com>
 576
 577         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 578         value is not lval_memory.
 579
 580 2019-05-14  Tom Tromey  <tromey@adacore.com>
 581
 582         * solib.c (info_sharedlibrary_command): Style the file name.
 583
 584 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 585
 586         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 587         (aarch64_vnv_type): Likewise.
 588         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 589         * common/tdesc.c: Likewise.
 590         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 591         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 592         * features/aarch64-fpu.xml: Add ieee half view.
 593         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 594         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 595         * gdbtypes.h (struct builtin_type): Likewise.
 596         (struct objfile_type): Likewise.
 597
 598 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 599
 600         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 601         typo.
 602         * location.h (string_to_event_location): Likewise.
 603
 604 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 605
 606         GDB 8.3 released.
 607
 608 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 609
 610         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 611         New variable declaration.
 612         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 613         New variable.
 614         (print_one_breakpoint): Use ui_out::test_flags and new global
 615         variable to compute use_fixed_output.
 616         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 617         Remove.
 618         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 619         (mi_multi_location_breakpoint_output_fixed): Remove.
 620         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 621         new variable.
 622         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 623         fix_multi_location_breakpoint_output flag if version >= 3.
 624         * ui-out.h (enum ui_out_flag)
 625         <fix_multi_location_breakpoint_output>: New enumerator.
 626
 627 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 628
 629         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 630
 631 2019-05-10  Tom Tromey  <tromey@adacore.com>
 632
 633         * ada-lang.c (catch_ada_completer): New function.
 634         (_initialize_ada_language): Use it.
 635
 636 2019-05-10  Tom Tromey  <tromey@adacore.com>
 637
 638         * thread.c (print_thread_info): Make "requested_threads" const.
 639         * gdbthread.h (print_thread_info): Make "requested_threads"
 640         const.
 641         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 642         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 643
 644 2019-05-08  Tom Tromey  <tom@tromey.com>
 645
 646         * gdbtypes.c (objfile_type_data): Change type.
 647         (objfile_type, _initialize_gdbtypes): Update.
 648
 649 2019-05-08  Tom Tromey  <tom@tromey.com>
 650
 651         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 652         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 653         (_initialize_dwarf2_frame): Update.
 654
 655 2019-05-08  Tom Tromey  <tom@tromey.com>
 656
 657         * objc-lang.c (objc_objfile_data): Change type.
 658         (find_methods): Update.
 659         (_initialize_objc_lang): Remove.
 660
 661 2019-05-08  Tom Tromey  <tom@tromey.com>
 662
 663         * stabsread.c (rs6000_builtin_type_data): Change type.
 664         (rs6000_builtin_type, _initialize_stabsread): Update.
 665
 666 2019-05-08  Tom Tromey  <tom@tromey.com>
 667
 668         * mips-tdep.c (mips_pdr_data): Remove.
 669         (_initialize_mips_tdep): Update.
 670
 671 2019-05-08  Tom Tromey  <tom@tromey.com>
 672
 673         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 674         (hppa_init_objfile_priv_data, read_unwind_info)
 675         (find_unwind_entry, _initialize_hppa_tdep): Update.
 676
 677 2019-05-08  Tom Tromey  <tom@tromey.com>
 678
 679         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 680         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 681         on obstack.
 682         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 683
 684 2019-05-08  Tom Tromey  <tom@tromey.com>
 685
 686         * mdebugread.c (basic_type_data): Change type.
 687         (basic_type, _initialize_mdebugread): Update.
 688
 689 2019-05-08  Tom Tromey  <tom@tromey.com>
 690
 691         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 692
 693 2019-05-08  Tom Tromey  <tom@tromey.com>
 694
 695         * nto-tdep.c (nto_inferior_data_reg): Change type.
 696         (nto_inferior_data): Update.
 697         (nto_inferior_data_cleanup, nto_new_inferior_data)
 698         (_initialize_nto_tdep): Remove.
 699         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 700
 701 2019-05-08  Tom Tromey  <tom@tromey.com>
 702
 703         * ada-lang.c (struct ada_inferior_data): Add initializers.
 704         (ada_inferior_data): Change type.
 705         (ada_inferior_data_cleanup): Remove.
 706         (get_ada_inferior_data, ada_inferior_exit)
 707         (struct ada_pspace_data): Add initializers, destructor.
 708         (ada_pspace_data_handle): Change type.
 709         (get_ada_pspace_data): Update.
 710         (ada_pspace_data_cleanup): Remove.
 711
 712 2019-05-08  Tom Tromey  <tom@tromey.com>
 713
 714         * coffread.c (struct coff_symfile_info): Add initializers.
 715         (coff_objfile_data_key): Move lower.  Change type.
 716         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 717         Update.
 718         (coff_free_info): Remove.
 719
 720 2019-05-08  Tom Tromey  <tom@tromey.com>
 721
 722         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 723         (fbsd_pspace_data_handle): Move lower.  Change type.
 724         (get_fbsd_pspace_data): Update.
 725         (fbsd_pspace_data_cleanup): Remove.
 726         (_initialize_fbsd_tdep): Update.
 727
 728 2019-05-08  Tom Tromey  <tom@tromey.com>
 729
 730         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 731         (get_ada_tasks_pspace_data): Update.
 732         (ada_tasks_pspace_data_cleanup): Remove.
 733         (_initialize_tasks): Update.
 734         (ada_tasks_inferior_data_handle): Change type.
 735         (get_ada_tasks_inferior_data): Update.
 736         (ada_tasks_inferior_data_cleanup): Remove.
 737         (struct ada_tasks_pspace_data): Add initializers.
 738
 739 2019-05-08  Tom Tromey  <tom@tromey.com>
 740
 741         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 742         * symfile-debug.c (debug_sym_get_probes): Change type.
 743         * stap-probe.c (handle_stap_probe):
 744         (stap_static_probe_ops::get_probes): Change type.
 745         * probe.h (class static_probe_ops) <get_probes>: Change type.
 746         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 747         (parse_probes_in_pspace): Update.
 748         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 749         Update.
 750         (any_static_probe_ops::get_probes): Change type.
 751         * elfread.c (elfread_data): New typedef.
 752         (probe_key): Change type.
 753         (elf_get_probes): Likewise.  Update.
 754         (probe_key_free): Remove.
 755         (_initialize_elfread): Update.
 756         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 757         Change type.
 758         (dtrace_process_dof_probe, dtrace_process_dof)
 759         (dtrace_static_probe_ops::get_probe): Change type.
 760
 761 2019-05-08  Tom Tromey  <tom@tromey.com>
 762
 763         * xcoffread.c (struct xcoff_symfile_info): Rename from
 764         coff_symfile_info.  Add initializers.
 765         (xcoff_objfile_data_key): Move lower.  Change type.
 766         (XCOFF_DATA): Rewrite.
 767         (xcoff_free_info): Remove.
 768         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 769         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 770         (xcoff_initial_scan): Update.
 771
 772 2019-05-08  Tom Tromey  <tom@tromey.com>
 773
 774         * solib-svr4.c (struct svr4_info): Add initializers and
 775         destructor.
 776         <probes_table>: Now an htab_up.
 777         (solib_svr4_pspace_data): Change type.
 778         (free_probes_table): Simplify.
 779         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 780         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 781         (probes_table_remove_objfile_probes, register_solib_event_probe)
 782         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 783         (_initialize_svr4_solib): Update.
 784
 785 2019-05-08  Tom Tromey  <tom@tromey.com>
 786
 787         * remote.c (remote_pspace_data): Change type.
 788         (remote_pspace_data_cleanup): Remove.
 789         (get_remote_exec_file, set_pspace_remote_exec_file)
 790         (_initialize_remote): Update.
 791
 792 2019-05-08  Tom Tromey  <tom@tromey.com>
 793
 794         * breakpoint.c (breakpoint_objfile_key): Change type.
 795         (get_breakpoint_objfile_data): Update.
 796         (free_breakpoint_objfile_data): Remove.
 797         (_initialize_breakpoint): Update.
 798
 799 2019-05-08  Tom Tromey  <tom@tromey.com>
 800
 801         * linux-tdep.c (struct linux_info): Add initializers.
 802         (linux_inferior_data): Move.  Change type.
 803         (invalidate_linux_cache_inf): Update.
 804         (linux_inferior_data_cleanup): Remove.
 805         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 806
 807 2019-05-08  Tom Tromey  <tom@tromey.com>
 808
 809         * auxv.c (auxv_inferior_data): Move.  Change type.
 810         (auxv_inferior_data_cleanup): Remove.
 811         (invalidate_auxv_cache_inf): Rewrite.
 812         (get_auxv_inferior_data, _initialize_auxv): Update.
 813
 814 2019-05-08  Tom Tromey  <tom@tromey.com>
 815
 816         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 817         (symfile_debug_objfile_data_key): Change type.
 818         (symfile_debug_installed, debug_qf_has_symbols)
 819         (debug_qf_find_last_source_symtab)
 820         (debug_qf_forget_cached_source_info)
 821         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 822         (debug_qf_print_stats, debug_qf_dump)
 823         (debug_qf_expand_symtabs_for_function)
 824         (debug_qf_expand_all_symtabs)
 825         (debug_qf_expand_symtabs_with_fullname)
 826         (debug_qf_map_matching_symbols)
 827         (debug_qf_expand_symtabs_matching)
 828         (debug_qf_find_pc_sect_compunit_symtab)
 829         (debug_qf_map_symbol_filenames)
 830         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 831         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 832         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 833         (debug_sym_read_linetable, debug_sym_relocate): Update.
 834         (symfile_debug_free_objfile): Remove.
 835         (install_symfile_debug_logging, _initialize_symfile_debug):
 836         Update.
 837
 838 2019-05-08  Tom Tromey  <tom@tromey.com>
 839
 840         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 841         allocate_on_obstack.
 842         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 843         (get_dwarf2_per_objfile): Update.
 844         (set_dwarf2_per_objfile): Remove.
 845         (dwarf2_has_info, dwarf2_get_section_info): Update.
 846         (dwarf2_free_objfile): Remove.
 847         (_initialize_dwarf2_read): Update.
 848
 849 2019-05-08  Tom Tromey  <tom@tromey.com>
 850
 851         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 852         initializers.
 853         <unsupported_script_warning_printed,
 854         script_not_found_warning_printed>: Now bool.
 855         (auto_load_pspace_data): Change type.
 856         (~auto_load_pspace_info): Rename from
 857         auto_load_pspace_data_cleanup.
 858         (get_auto_load_pspace_data, init_loaded_scripts_info)
 859         (clear_section_scripts, maybe_print_unsupported_script_warning)
 860         (maybe_print_script_not_found_warning, _initialize_auto_load):
 861         Update.
 862
 863 2019-05-08  Tom Tromey  <tom@tromey.com>
 864
 865         * objfiles.c (objfile_pspace_info): Add destructor and
 866         initializers.
 867         (objfiles_pspace_data): Change type.
 868         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 869         (get_objfile_pspace_data): Update.
 870         (objfiles_bfd_data): Change type.
 871         (get_objfile_bfd_data): Update.
 872         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 873
 874 2019-05-08  Tom Tromey  <tom@tromey.com>
 875
 876         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
 877         Change type.
 878         (get_catch_syscall_inferior_data): Update.
 879         (catch_syscall_inferior_data_cleanup): Remove.
 880         (_initialize_break_catch_syscall): Update.
 881
 882 2019-05-08  Tom Tromey  <tom@tromey.com>
 883
 884         * inflow.c (struct terminal_info): Add destructor and
 885         initializers.
 886         (inflow_inferior_data): Change type.
 887         (~terminal_info): Rename from inflow_inferior_data_cleanup.
 888         (get_inflow_inferior_data, inflow_inferior_exit)
 889         (swap_terminal_info, _initialize_inflow): Update.
 890
 891 2019-05-08  Tom Tromey  <tom@tromey.com>
 892
 893         * target-dcache.c (target_dcache_cleanup): Remove.
 894         (target_dcache_aspace_key): Change type.
 895         (target_dcache_init_p, target_dcache_invalidate)
 896         (target_dcache_get, target_dcache_get_or_init)
 897         (_initialize_target_dcache): Update.
 898         * dcache.h (struct dcache_deleter): New.
 899
 900 2019-05-08  Tom Tromey  <tom@tromey.com>
 901
 902         * symtab.c (struct symbol_cache): Add destructor and
 903         initializers.
 904         (symbol_cache_key): Move.  Change type.
 905         (make_symbol_cache, free_symbol_cache): Remove.
 906         (get_symbol_cache): Update.
 907         (symbol_cache_cleanup): Remove.
 908         (ALL_PSPACES, symbol_cache_flush)
 909         (maintenance_print_symbol_cache)
 910         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
 911         Update.
 912
 913 2019-05-08  Tom Tromey  <tom@tromey.com>
 914
 915         * symtab.c (struct main_info): Add destructor and initializers.
 916         (main_progspace_key): Move.  Change type.
 917         (get_main_info): Update.
 918         (main_info_cleanup): Remove.
 919         (_initialize_symtab): Update.
 920
 921 2019-05-08  Tom Tromey  <tom@tromey.com>
 922
 923         * registry.h (DECLARE_REGISTRY): Define the _key class.
 924
 925 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
 926
 927         * NEWS: Merge two 'New commands' sections.
 928
 929 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
 930
 931         * ada-valprint.c (ada_val_print_gnat_array): Remove language
 932         parameter and use Ada language definition instead.
 933         (ada_val_print_ptr): Remove unused language parameter.
 934         (ada_val_print_num): Remove language parameter and use Ada language
 935         definition instead.
 936         (ada_val_print_enum, ada_val_print_flt): Remove unused language
 937         parameter.
 938         (ada_val_print_struct_union, ada_val_print_ref): Remove language
 939         parameter and use Ada language definition instead.
 940         (ada_val_print_1): Update all ada_val_print_xxx calls.
 941         Remove language parameter.
 942         (ada_val_print): Update ada_val_print_1 call.
 943
 944 2019-05-08  Tom Tromey  <tromey@adacore.com>
 945
 946         * remote.c (remote_hw_watchpoint_limit)
 947         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
 948         Now static.
 949
 950 2019-05-08  Tom Tromey  <tromey@adacore.com>
 951
 952         * maint.c (_initialize_maint_cmds): Move initialization code to
 953         remote.c.
 954         (watchdog, show_watchdog): Move to remote.c.
 955         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
 956         "watchdog" static.
 957         (_initialize_remote): Move initialization code from maint.c.
 958         * defs.h (watchdog): Don't declare.
 959
 960 2019-05-08  Tom Tromey  <tromey@adacore.com>
 961
 962         * tui/tui-interp.c: Include main.h.
 963         * interps.c: Include main.h.
 964         * main.h (interpreter_p): Declare.
 965         * defs.h (interpreter_p): Don't declare.
 966
 967 2019-05-08  Tom Tromey  <tromey@adacore.com>
 968
 969         * dwarf2loc.c: Include dwarf2read.h.
 970         * defs.h (read_unsigned_leb128): Don't declare.
 971         * dwarf2read.h (read_unsigned_leb128): Declare.
 972
 973 2019-05-08  Tom Tromey  <tromey@adacore.com>
 974
 975         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
 976         method.
 977
 978 2019-05-08  Tom Tromey  <tromey@adacore.com>
 979
 980         * utils.c (fputs_maybe_filtered): Reset style after paging, even
 981         when no wrap column is set.
 982
 983 2019-05-08  Tom Tromey  <tromey@adacore.com>
 984
 985         * c-lang.c (c_get_string): Handle non-C-style arrays.
 986
 987 2019-05-08  Tom Tromey  <tromey@adacore.com>
 988
 989         * typeprint.c (print_offset_data::update): Print the bit offset,
 990         not the number of bits remaining.
 991
 992 2019-05-08  Tom Tromey  <tromey@adacore.com>
 993
 994         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
 995         padding at end of comment.
 996
 997 2019-05-08  Tom Tromey  <tromey@adacore.com>
 998
 999         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1000         Compare main types.
1001
1002 2019-05-06  Tom Tromey  <tom@tromey.com>
1003
1004         * common/scoped_mmap.c: Include common-defs.h.
1005         * common/scoped_mmap.h: Don't include config.h.
1006
1007 2019-05-04  Tom Tromey  <tom@tromey.com>
1008
1009         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1010         (struct aarch64_call_info): Add initializers.
1011         <si>: Now a std::vector.
1012         (pass_on_stack, aarch64_push_dummy_call): Update.
1013
1014 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1015             Tom Tromey  <tom@tromey.com>
1016
1017         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1018         (ppc_threads): Now a std::vector.  Now static.
1019         (hwdebug_find_thread_points_by_tid)
1020         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1021         Update.
1022
1023 2019-05-04  Tom Tromey  <tom@tromey.com>
1024
1025         * arc-tdep.c (arc_tdesc_init): Return bool.
1026
1027 2019-05-04  Tom Tromey  <tom@tromey.com>
1028
1029         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1030         Use gdb_assert_not_reached.
1031
1032 2019-05-04  Tom Tromey  <tom@tromey.com>
1033
1034         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1035         "false".
1036
1037 2019-05-04  Tom Tromey  <tom@tromey.com>
1038
1039         * arc-tdep.c (arc_tdesc_init): Use bool.
1040
1041 2019-05-04  Tom Tromey  <tom@tromey.com>
1042
1043         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1044
1045 2019-05-04  Tom Tromey  <tom@tromey.com>
1046
1047         * cli/cli-cmds.c (valid_command_p): Return bool.
1048
1049 2019-05-04  Tom Tromey  <tom@tromey.com>
1050
1051         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1052         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1053
1054 2019-05-04  Raul Tambre  <raul@tambre.ee>
1055
1056         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1057         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1058         operator for comparison.
1059
1060 2019-05-04  Tom Tromey  <tom@tromey.com>
1061
1062         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1063         (lookup_partial_symbol, print_partial_symbols)
1064         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1065         (psymbol_compare): Update.
1066         (add_psymbol_to_bcache): Clear the entire psymbol.
1067         (maintenance_check_psymtabs): Update.
1068         * psympriv.h (struct partial_symbol): Don't derive from
1069         general_symbol_info.
1070         <obj_section, unrelocated_address, address,
1071         set_unrelocated_address>: Update.
1072         <ginfo>: New member.
1073         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1074         (debug_names::write_psymbols): Update.
1075
1076 2019-05-04  Tom de Vries  <tdevries@suse.de>
1077
1078         * contrib/cc-with-tweaks.sh: Support -n arg.
1079
1080 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1081
1082         * corelow.c (core_target::detach): Ensure frame cache and
1083         register caches are cleared.
1084         inferior.c (exit_inferior_1): Likewise.
1085
1086 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1087             Tom Tromey  <tom@tromey.com>
1088
1089         * dictionary.c (collate_pending_symbols_by_language): Remove
1090         "struct" from foreach.
1091         * symtab.c (lookup_global_symbol_from_objfile)
1092         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1093         foreach.
1094         * ser-tcp.c (net_open): Remove "struct" from foreach.
1095         * objfiles.c (objfile_relocate, objfile_rebase)
1096         (objfile_has_symbols): Remove "struct" from foreach.
1097         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1098         from foreach.
1099         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1100         foreach.
1101         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1102         "struct" from foreach.
1103         * ada-lang.c (create_excep_cond_exprs)
1104         (ada_exception_catchpoint_cond_string): Remove "struct" from
1105         foreach.
1106
1107 2019-05-03  Tom Tromey  <tromey@adacore.com>
1108
1109         * ada-exp.y (convert_char_literal): Check suffix of each
1110         enumerator.
1111
1112 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1113
1114         PR ada/21406:
1115         * ada-exp.y (yywrap): Don't define.
1116         * ada-lex.l (%option): Add noyywrap
1117         (yywrap): Remove.
1118
1119 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1120
1121         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1122         _WIN32_WINNT to the XP level, unless already defined to a higher
1123         level.
1124
1125         * unittests/parse-connection-spec-selftests.c:
1126         * ser-tcp.c:
1127         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1128         override.
1129
1130         * symfile.c (find_separate_debug_file): Remove colon from the
1131         drive spec of DOS/Windows file names of the target, so that the
1132         file name produced from DEBUGDIR and the target's directory will
1133         be valid on DOS/Windows systems.
1134
1135 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1136
1137         * rust-lang.c (val_print_struct): Handle printing structures
1138         containing strings.
1139
1140 2019-05-02  Tom Tromey  <tromey@adacore.com>
1141
1142         * valarith.c (_initialize_valarith): Remove.
1143
1144 2019-05-01  Tom Tromey  <tromey@adacore.com>
1145
1146         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1147         bitfields.
1148
1149 2019-05-01  Tom Tromey  <tromey@adacore.com>
1150
1151         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1152         for big-endian copies.
1153
1154 2019-04-30  Ali Tamur  <tamur@google.com>
1155         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1156         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1157         (read_3_bytes): New function.
1158
1159 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1160
1161         * windows-nat.c (main_thread_id): Delete.
1162         (handle_output_debug_string): Replace main_thread_id by
1163         current_event.dwThreadId.
1164         (fake_create_process): Likewise.
1165         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1166         Do not set main_thread_id.
1167         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1168         current_event.dwThreadId.
1169         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1170
1171 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1172
1173         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1174         Use current_event.dwThreadId instead of main_thread_id.
1175
1176 2019-04-30  Tom Tromey  <tromey@adacore.com>
1177
1178         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1179         (create_excep_cond_exprs): Iterate over program spaces.
1180         (ada_exception_catchpoint_cond_string): Examine all minimal
1181         symbols for exception types.
1182
1183 2019-04-30  Tom Tromey  <tromey@adacore.com>
1184
1185         PR c++/24470:
1186         * dwarf2read.c (process_structure_scope): Handle case where type
1187         has template parameters but no symbol was created.
1188
1189 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1190             Chris January  <chris.january@arm.com>
1191
1192         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1193         qualifier.
1194         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1195
1196 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1197
1198         * f-typeprint.c (f_print_type): Update rules for printing
1199         whitespace.
1200         (f_type_print_varspec_suffix): Likewise.
1201
1202 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1203             Chris January  <chris.january@arm.com>
1204
1205         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1206         function arguments.
1207
1208 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1209
1210         * f-lang.c (build_fortran_types): Change name of void type to
1211         lower case.
1212         * f-typeprint.c (f_type_print_base): Print the name of the void
1213         type, rather than a fixed string.
1214         * f-valprint.c (f_decorations): Use lower case void string.
1215
1216 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1217             Chris January  <chris.january@arm.com>
1218
1219         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1220         types for Fortran.
1221
1222 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1223             Chris January  <chris.january@arm.com>
1224             David Lecomber  <david.lecomber@arm.com>
1225
1226         * f-exp.y (BINOP_INTRINSIC): New token.
1227         (exp): New parser rule handling BINOP_INTRINSIC.
1228         (f77_keywords): Add new builtin procedures.
1229         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1230         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1231         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1232         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1233         (print_unop_subexp_f): New function.
1234         (print_binop_subexp_f): New function.
1235         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1236         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1237         (dump_subexp_body_f): Likewise.
1238         (operator_check_f): Likewise.
1239         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1240         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1241
1242 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1243
1244         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1245         UNOP_KIND.
1246         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1247         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1248         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1249         (operator_length_f): New fuction.
1250         (print_subexp_f): New function.
1251         (op_name_f): New function.
1252         (dump_subexp_body_f): New function.
1253         (operator_check_f): New function.
1254         (exp_descriptor_f): Replace standard expression handling functions
1255         with new functions.
1256         * gdb/fortran-operator.def: New file.
1257         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1258         * gdb/std-operator.def: Remove UNOP_KIND.
1259
1260 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * std-operator.def: Remove unbalanced, stray double quote
1263         character.
1264
1265 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1266             Chris January  <chris.january@arm.com>
1267             Daniel Everett  <daniel.everett@arm.com>
1268             Nick Forrington  <nick.forrington@arm.com>
1269             Richard Bunt  <richard.bunt@arm.com>
1270
1271         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1272         of depth when printing anonymous structs or unions.
1273         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1274         Don't print either the top-level value, or the children if the
1275         max-depth is exceeded.
1276         (ppscm_print_children): When printing the key of a map, allow one
1277         extra level of depth.
1278         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1279         print either the top-level value, or the children if the max-depth
1280         is exceeded.
1281         (print_children): When printing the key of a map, allow one extra
1282         level of depth.
1283         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1284         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1285         (user_print_options): Initialise max_depth field.
1286         (val_print_scalar_or_string_type_p): New function.
1287         (val_print): Check to see if the max depth has been reached.
1288         (val_print_check_max_depth): Define new function.
1289         (show_print_max_depth): New function.
1290         (_initialize_valprint): Add 'print max-depth' option.
1291         * valprint.h (struct value_print_options) <max_depth>: New field.
1292         (val_print_check_max_depth): Declare new function.
1293         * NEWS: Document new feature.
1294
1295 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1296
1297         * ada-lang.c (ada_language_defn): Initialise new field.
1298         * c-lang.c (c_is_string_type_p): New function.
1299         (c_language_defn): Initialise new field.
1300         (cplus_language_defn): Initialise new field.
1301         (asm_language_defn): Initialise new field.
1302         (minimal_language_defn): Initialise new field.
1303         * c-lang.h (c_is_string_type_p): Declare new function.
1304         * d-lang.c (d_language_defn): Initialise new field.
1305         * f-lang.c (f_is_string_type_p): New function.
1306         (f_language_defn): Initialise new field.
1307         * go-lang.c (go_is_string_type_p): New function.
1308         (go_language_defn): Initialise new field.
1309         * language.c (default_is_string_type_p): New function.
1310         (unknown_language_defn): Initialise new field.
1311         (auto_language_defn): Initialise new field.
1312         * language.h (struct language_defn) <la_is_string_type_p>: New
1313         member variable.
1314         (default_is_string_type_p): Declare new function.
1315         * m2-lang.c (m2_language_defn): Initialise new field.
1316         * objc-lang.c (objc_language_defn): Initialise new field.
1317         * opencl-lang.c (opencl_language_defn): Initialise new field.
1318         * p-lang.c (pascal_is_string_type_p): New function.
1319         (pascal_language_defn): Initialise new field.
1320         * rust-lang.c (rust_is_string_type_p): New function.
1321         (rust_language_defn): Initialise new field.
1322
1323 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1324
1325         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1326         New field.
1327         * ada-lang.c (ada_language_defn): Initialise new field.
1328         * c-lang.c (c_language_defn): Likewise.
1329         (cplus_language_defn): Likewise.
1330         (asm_language_defn): Likewise.
1331         (minimal_language_defn): Likewise.
1332         * d-lang.c (d_language_defn): Likewise.
1333         * f-lang.c (f_language_defn): Likewise.
1334         * go-lang.c (go_language_defn): Likewise.
1335         * language.c (unknown_language_defn): Likewise.
1336         (auto_language_defn): Likewise.
1337         * m2-lang.c (m2_language_defn): Likewise.
1338         * objc-lang.c (objc_language_defn): Likewise.
1339         * opencl-lang.c (opencl_language_defn): Likewise.
1340         * p-lang.c (pascal_language_defn): Likewise.
1341         * rust-lang.c (rust_language_defn): Likewise.
1342
1343 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1344
1345         * ada-lang.c (ada_is_character_type): Change return type to bool.
1346         (ada_is_string_type): Likewise.
1347         * ada-lang.h (ada_is_character_type): Update declaration
1348         (ada_is_string_type): Likewise.
1349
1350 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1351
1352         Support style in 'frame|thread apply'
1353
1354         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1355         * record.c (record_start, record_stop): Update callers of
1356         execute_command_to_string with false.
1357         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1358         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1359         methods.
1360         (class string_file): New constructor with term_out parameter.
1361         Override methods term_out and can_emit_style_escape.  New member
1362         term_out.
1363         (class stdio_file): Override can_emit_style_escape.
1364         (class tee_file): Override term_out and can_emit_style_escape.
1365         * utils.h (can_emit_style_escape): Remove.
1366         * utils.c (can_emit_style_escape): Likewise.
1367         Update all callers of can_emit_style_escape (SOMESTREAM) to
1368         SOMESTREAM->can_emit_style_escape.
1369         * source-cache.c (source_cache::get_source_lines): Likewise.
1370         * stack.c (frame_apply_command_count): Call execute_command_to_string
1371         passing the term_out characteristic of the current gdb_stdout.
1372         * thread.c (thr_try_catch_cmd): Likewise.
1373         * top.c (execute_command_to_string): pass term_out parameter
1374         to construct the string_file for the command output.
1375         * ui-file.c (term_cli_styling): New function (most code moved
1376         from utils.c can_emit_style_escape).
1377         (string_file::string_file, string_file::can_emit_style_escape,
1378         stdio_file::can_emit_style_escape, tee_file::term_out,
1379         tee_file::can_emit_style_escape): New functions.
1380
1381 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1382
1383         * NEWS: Mention the new set|show may-call-functions.
1384         * infcall.c (may_call_functions_p): New variable.
1385         (show_may_call_functions_p): New function.
1386         (call_function_by_hand_dummy): Throws an error if not
1387         may-call-functions.
1388         (_initialize_infcall): Call add_setshow_boolean_cmd for
1389         may-call-functions.
1390
1391 2019-04-25  Keith Seitz  <keiths@redhat.com>
1392
1393         PR c++/24367
1394         * cp-support.c (inspect_type): Don't attempt substitutions
1395         of symbol with the same name.
1396
1397 2019-04-25  Tom Tromey  <tromey@adacore.com>
1398
1399         PR gdb/24475:
1400         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1401         static.
1402
1403 2019-04-25  Tom Tromey  <tromey@adacore.com>
1404
1405         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1406         rvalue reference.
1407         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1408         (gdb_xml_parser::parse): Use std::move.
1409         * python/python-internal.h (gdbpy_convert_exception): Take a const
1410         reference.
1411         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1412         std::move.
1413         * python/py-utils.c (gdbpy_convert_exception): Take a const
1414         reference.
1415         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1416         Use std::move.
1417         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1418         Use std::move.
1419         * mi/mi-main.c (mi_print_exception): Take a const reference.
1420         * main.c (handle_command_errors): Take a const reference.
1421         * linespec.c (parse_linespec): Use std::move.
1422         * infcall.c (run_inferior_call): Use std::move.
1423         (call_function_by_hand_dummy): Use std::move.
1424         * exec.c (try_open_exec_file): Use std::move.
1425         * exceptions.h (exception_print, exception_fprintf)
1426         (exception_print_same): Update.
1427         * exceptions.c (print_exception, exception_print)
1428         (exception_fprintf, exception_print_same): Change parameters to
1429         const reference.
1430         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1431         * common/new-op.c: Use std::move.
1432         * common/common-exceptions.h (struct gdb_exception): Add move
1433         constructor.
1434         (struct gdb_exception_error, struct gdb_exception_quit, struct
1435         gdb_quit_bad_alloc): Change constructor to move constructor.
1436         (throw_exception): Change parameter to rvalue reference.
1437         * common/common-exceptions.c (throw_exception): Take rvalue
1438         reference.
1439         * cli/cli-interp.c (safe_execute_command): Use std::move.
1440         * breakpoint.c (insert_bp_location, location_to_sals): Use
1441         std::move.
1442
1443 2019-04-25  Tom Tromey  <tromey@adacore.com>
1444
1445         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1446         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1447         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1448         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1449         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1450         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1451         guile/scm-value.c: Use unpack.
1452         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1453         gdbscm_gdb_exception.
1454         (gdbscm_throw_gdb_exception): Likewise.
1455         (struct gdbscm_gdb_exception): New.
1456         (unpack): New function.
1457         (gdbscm_wrap): Use unpack.
1458
1459 2019-04-25  Tom Tromey  <tromey@adacore.com>
1460
1461         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1462         (gdb_rl_callback_handler): Use std::move.
1463         * common/common-exceptions.h (struct gdb_exception): Add move
1464         assignment operator.
1465         (throw_exception_sjlj): Change "exception" to const reference.
1466         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1467         (throw_exception_sjlj): Change "exception" to const reference.
1468
1469 2019-04-25  Tom Tromey  <tromey@adacore.com>
1470
1471         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1472         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1473         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1474         Update.
1475         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1476         Update.
1477         * mi/mi-interp.c (mi_interp::exec): Update.
1478         * linespec.c (parse_linespec): Update.
1479         * infcall.c (run_inferior_call): Update.
1480         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1481         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1482         (gdbscm_lookup_global_symbol): Update.
1483         * guile/scm-param.c (gdbscm_parameter_value): Update.
1484         * guile/scm-frame.c (gdbscm_frame_read_register)
1485         (gdbscm_frame_read_var): Update.
1486         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1487         * exec.c (try_open_exec_file): Update.
1488         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1489         (gdb_rl_callback_handler): Update.
1490         * common/common-exceptions.h (exception_none): Don't declare.
1491         * common/common-exceptions.c (exception_none): Don't define.
1492         (struct catcher) <exception>: Update.
1493         * cli/cli-interp.c (safe_execute_command): Update.
1494         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1495
1496 2019-04-25  Ali Tamur  <tamur@google.com>
1497
1498         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1499         (read_attribute_value): Likewise.
1500         (dwarf2_read_addr_index): Update comment.
1501         (read_str_index): Add DW_FORM_strx.
1502         (dwarf2_string_attr): Likewise.
1503         (dwarf2_const_value_attr): Likewise.
1504         (dump_die_shallow): Likewise.
1505         (dwarf2_fetch_constant_bytes): Likewise.
1506         (skip_form_bytes): Likewise.
1507         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1508
1509 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1510
1511         PR corefiles/11608
1512         PR corefiles/18187
1513         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1514         OFFSET.  Verify if current mapping contains an ELF header.
1515         (linux_find_memory_regions_full): Adjust call to
1516         dump_mapping_p.
1517
1518 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1519             Kang Li <kanglictf@gmail.com>
1520
1521         PR gdb/21600
1522
1523         * dwarf2-frame.c (read_initial_length): Be consistent about using
1524         unsigned representation of length.
1525         (decode_frame_entry_1): Likewise.  Check for wraparound of
1526         end pointer as well as buffer overflow.
1527
1528 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1529
1530         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1531         "vq".
1532
1533 2019-04-24  Tom Tromey  <tromey@adacore.com>
1534
1535         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1536
1537 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * s12z-tdep.c (s12z_unwind_pc): Delete.
1540         (s12z_unwind_sp): Delete.
1541         (s12z_gdbarch_init): Don't register deleted functions with
1542         gdbarch.
1543
1544 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         * rl78-tdep.c (rl78_unwind_sp): Delete.
1547         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1548
1549 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1550
1551         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1552         (xstormy16_unwind_pc): Delete.
1553         (xstormy16_dummy_id): Delete.
1554         (xstormy16_gdbarch_init): Don't register deleted functions with
1555         gdbarch.
1556
1557 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1558
1559         * vax-tdep.c (vax_unwind_pc): Delete.
1560         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1561
1562 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1563
1564         * v850-tdep.c (v850_unwind_sp): Delete.
1565         (v850_unwind_pc): Delete.
1566         (v850_dummy_id): Delete.
1567         (v850_gdbarch_init): Don't register deleted functions with
1568         gdbarch.
1569
1570 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1571
1572         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1573         (tilegx_unwind_pc): Delete.
1574         (tilegx_unwind_dummy_id): Delete.
1575         (tilegx_gdbarch_init): Don't register deleted functions with
1576         gdbarch.
1577
1578 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1579
1580         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1581         (tic6x_dummy_id): Delete.
1582         (tic6x_gdbarch_init): Don't register deleted functions with
1583         gdbarch.
1584
1585 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1586
1587         * sparc-tdep.c (sparc_unwind_pc): Delete.
1588         (sparc32_gdbarch_init): Don't register deleted function with
1589         gdbarch.
1590
1591 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1592
1593         * sh-tdep.c (sh_unwind_sp): Delete.
1594         (sh_unwind_pc): Delete.
1595         (sh_dummy_id): Delete.
1596         (sh_gdbarch_init): Don't register deleted functions with
1597         gdbarch.
1598
1599 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1600
1601         * score-tdep.c (score_unwind_sp): Delete.
1602         (score_unwind_pc): Delete.
1603         (score_dummy_id): Delete.
1604         (score_gdbarch_init): Don't register deleted functions with
1605         gdbarch.
1606
1607 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1608
1609         * rx-tdep.c (rx_unwind_pc): Delete.
1610         (rx_unwind_sp): Delete.
1611         (rx_dummy_id): Delete.
1612         (rx_gdbarch_init): Don't register deleted functions with
1613         gdbarch.  Update comment.
1614
1615 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1616
1617         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1618         (rs6000_dummy_id): Delete.
1619         (rs6000_gdbarch_init): Don't register deleted functions with
1620         gdbarch.
1621
1622 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1623
1624         * or1k-tdep.c (or1k_dummy_id): Delete.
1625         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1626
1627 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1628
1629         * nios2-tdep.c (nios2_dummy_id): Delete.
1630         (nios2_unwind_sp): Delete.
1631         (nios2_gdbarch_init): Don't register deleted functions with
1632         gdbarch.
1633
1634 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1635
1636         * nds32-tdep.c (nds32_dummy_id): Delete.
1637         (nds32_unwind_pc): Delete.
1638         (nds32_unwind_sp): Delete.
1639         (nds32_gdbarch_init): Don't register deleted functions with
1640         gdbarch.
1641
1642 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1643
1644         * msp430-tdep.c (msp430_unwind_pc): Delete.
1645         (msp430_unwind_sp): Delete.
1646         (msp430_dummy_id): Delete.
1647         (msp430_gdbarch_init): Don't register deleted functions with
1648         gdbarch.
1649
1650 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1651
1652         * moxie-tdep.c (moxie_unwind_sp): Delete.
1653         (moxie_unwind_pc): Delete.
1654         (moxie_dummy_id): Delete.
1655         (moxie_gdbarch_init): Don't register deleted functions with
1656         gdbarch.
1657
1658 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1659
1660         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1661         (mn10300_unwind_pc): Delete.
1662         (mn10300_unwind_sp): Delete.
1663         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1664         mn10300_unwind_sp.
1665         (mn10300_frame_unwind_init): Don't register deleted functions with
1666         gdbarch.
1667
1668 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1669
1670         * mep-tdep.c (mep_unwind_pc): Delete.
1671         (mep_unwind_sp): Delete.
1672         (mep_dummy_id): Delete.
1673         (mep_gdbarch_init): Don't register deleted functions with
1674         gdbarch.
1675
1676 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1677
1678         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1679         (m68hc11_unwind_sp): Delete.
1680         (m68hc11_gdbarch_init): Don't register deleted functions with
1681         gdbarch.
1682
1683 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1684
1685         * m32r-tdep.c (m32r_unwind_sp): Delete.
1686         (m32r_unwind_pc): Delete.
1687         (m32r_dummy_id): Delete.
1688         (m32r_gdbarch_init): Don't register deleted functions with
1689         gdbarch.
1690
1691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1692
1693         * m32c-tdep.c (m32c_unwind_pc): Delete.
1694         (m32c_unwind_sp): Delete.
1695         (m32c_dummy_id): Delete.
1696         (m32c_gdbarch_init): Don't register deleted functions with
1697         gdbarch.
1698
1699 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1700
1701         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1702         (lm32_unwind_pc): Delete.
1703         (lm32_dummy_id): Delete.
1704         (lm32_gdbarch_init): Don't register deleted functions with
1705         gdbarch.
1706
1707 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1708
1709         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1710         (iq2000_unwind_pc): Delete.
1711         (iq2000_dummy_id): Delete.
1712         (iq2000_gdbarch_init): Don't register deleted functions with
1713         gdbarch.
1714
1715 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1716
1717         * nds32-tdep.c (nds32_type_align): Delete.
1718         (nds32_push_dummy_call): Use type_align instead.
1719
1720 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1721
1722         * arm-tdep.c (arm_type_align): Only handle vector override case.
1723         (arm_push_dummy_call): Use type_align.
1724         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1725
1726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1727
1728         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1729         case.
1730         (pass_on_stack): Use type_align.
1731         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1732         function.
1733
1734 2019-04-23  Tom Tromey  <tromey@adacore.com>
1735
1736         * dwarf2read.c (line_header::file_name_at): Remove unused
1737         overload.
1738
1739 2019-04-23  Tom de Vries  <tdevries@suse.de>
1740
1741         PR gdb/24438
1742         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1743         invocation.
1744
1745
1746 2019-03-27  Ali Tamur  <tamur@google.com>
1747
1748         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1749         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1750         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1751         (dwarf_expr_context::get_addr_index): Likewise
1752         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1753         (symbol_needs_eval_context::get_addr_index): Likewise
1754         (disassemble_dwarf_expression): Add DW_OP_addrx
1755         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1756         (read_cutu_die_from_dwo): Update comment
1757         (skip_one_die): Add DW_FORM_addrx
1758         (read_attribute_value): Likewise
1759         (var_decode_location): Add DW_OP_addrx
1760         (dwarf2_const_value_attr): Add DW_FORM_addrx
1761         (dump_die_shallow): Likewise
1762         (dwarf2_fetch_constant_bytes): Likewise
1763         (decode_locdesc): Add DW_OP_addrx
1764         (skip_form_bytes): Add DW_FORM_addrx
1765
1766 2019-04-22  Ali Tamur  <tamur@google.com>
1767
1768         * MAINTAINERS (Write After Approval): Add self.
1769
1770 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1771
1772         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1773         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1774         (open_symbol_file_object): Likewise.
1775         (svr4_default_sos): Add info parameter.
1776         (svr4_read_so_list): Likewise.
1777         (svr4_current_sos_direct): Adjust functions calls to pass down
1778         info.
1779         (svr4_current_sos_1): Add info parameter.
1780         (svr4_current_sos): Call get_svr4_info, pass info down to
1781         svr4_current_sos_1.
1782         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1783         get_svr4_info.
1784         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1785         get_svr4_info.
1786         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1787         to get_svr4_info.
1788         (probes_table_remove_objfile_probes): Likewise.
1789         (register_solib_event_probe): Add info parameter.
1790         (solist_update_incremental): Pass info parameter down to
1791         svr4_read_so_list.
1792         (disable_probes_interface): Add info parameter.
1793         (svr4_handle_solib_event): Pass current_program_space to
1794         get_svr4_info.  Adjust disable_probes_interface cleanup.
1795         (svr4_create_probe_breakpoints): Add info parameter, pass it
1796         down to register_solib_event_probe.
1797         (svr4_create_solib_event_breakpoints): Add info parameter,
1798         pass it down to svr4_create_probe_breakpoints.
1799         (enable_break): Pass info down to
1800         svr4_create_solib_event_breakpoints.
1801         (svr4_solib_create_inferior_hook): Pass current_program_space to
1802         get_svr4_info.
1803         (svr4_clear_solib): Likewise.
1804
1805 2019-04-22  Pedro Alves  <palves@redhat.com>
1806
1807         * solib-svr4.c (svr4_free_objfile_observer): New.
1808         (probe_and_action::objfile): New field.
1809         (probes_table_htab_remove_objfile_probes)
1810         (probes_table_remove_objfile_probes): New functions.
1811         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1812         in the new probe_and_action.  Don't store the probe in 'lookup'.
1813         (svr4_create_probe_breakpoints): Pass objfile to
1814         register_solib_event_probe.
1815         (_initialize_svr4_solib): Register a free_objfile observer.
1816
1817 2019-04-19  Tom Tromey  <tom@tromey.com>
1818
1819         * common/queue.h: Remove.
1820
1821 2019-04-19  Tom Tromey  <tom@tromey.com>
1822
1823         * event-loop.c: Don't include "common/queue.h".
1824
1825 2019-04-19  Tom Tromey  <tom@tromey.com>
1826
1827         * remote.c (remote_target): Use delete.
1828         * remote-notif.h: Include <list>, not "common/queue.h".
1829         (notif_client_p): Remove typedef.
1830         (remote_notif_state): Add constructor, destructor, initializer.
1831         <notif_queue>: Now a std::list.
1832         (remote_notif_state_xfree): Don't declare.
1833         * remote-notif.c (remote_notif_process, handle_notification)
1834         (remote_notif_state_allocate): Update.
1835         (~remote_notif_state): Rename from remote_notif_state_xfree.
1836
1837 2019-04-19  Tom Tromey  <tom@tromey.com>
1838
1839         * symfile.c (reread_symbols): Update.
1840         * objfiles.c (objfile_register_static_link)
1841         (objfile_lookup_static_link): Update
1842         (~objfile) Don't delete static_links.
1843         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1844
1845 2019-04-19  Tom Tromey  <tom@tromey.com>
1846
1847         * type-stack.h (struct type_stack) <insert>: Constify string.
1848         * type-stack.c (type_stack::insert): Constify string.
1849         * gdbtypes.h (lookup_template_type): Update.
1850         (address_space_name_to_int): Update.
1851         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1852         const.
1853         (lookup_template_type): Make name const.
1854         * c-exp.y: Update rules.
1855         (lex_one_token, classify_name, classify_inner_name)
1856         (c_print_token): Update.
1857         * p-exp.y: Update rules.
1858         (yylex): Update.
1859         * f-exp.y: Update rules.
1860         (yylex): Update.
1861         * d-exp.y: Update rules.
1862         (lex_one_token, classify_name, classify_inner_name): Update.
1863         * parse.c (write_dollar_variable, copy_name): Return std::string.
1864         * parser-defs.h (copy_name): Change return type.
1865         * m2-exp.y: Update rules.
1866         (yylex): Update.
1867         * go-exp.y (lex_one_token): Update.
1868         Update rules.
1869         (classify_unsafe_function, classify_packaged_name)
1870         (classify_name, yylex): Update.
1871
1872 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1873
1874         * configure.ac: add --enable-source-highlight switch.
1875         * configure: Regenerate.
1876         * top.c (print_gdb_version): plumb --enable-source-highlight
1877         status to "show configuration".
1878
1879 2019-04-19  Tom Tromey  <tromey@adacore.com>
1880
1881         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
1882         Check ADA_TYPE_P.
1883         (empty_record, ada_template_to_fixed_record_type_1)
1884         (template_to_static_fixed_type)
1885         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
1886         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
1887         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
1888         macros.
1889
1890 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
1891
1892         PR symtab/24423:
1893         * source.c (print_source_lines_base): Advance "iter" when a
1894         control character is seen.
1895
1896 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1897
1898         * inferior.h (struct infcall_suspend_state_deleter):
1899         Catch exception in destructor to avoid crash.
1900
1901 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1902
1903         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
1904         close to the add_com "shell".
1905
1906 2019-04-18  Tom Tromey  <tromey@adacore.com>
1907
1908         * process-stratum-target.h (class process_stratum_target)
1909         <stratum>: Add "final".
1910
1911 2019-04-17  Tom Tromey  <tromey@adacore.com>
1912
1913         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
1914         against nullptr before use.
1915
1916 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
1917
1918         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
1919
1920 2019-04-17  Jim Wilson  <jimw@sifive.com>
1921             Andrew Burgess  <andrew.burgess@embecosm.com>
1922
1923         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
1924         code read might fail, assume 4-byte breakpoint in that case.
1925
1926 2019-04-15  Leszek Swirski  <leszeks@google.com>
1927
1928         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
1929         rather than a hand-rolled POD check when checking for forced MEMORY
1930         classification.
1931
1932 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1933
1934         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
1935         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
1936         function.
1937         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
1938         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
1939         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
1940         declaration.
1941
1942 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1943
1944         * aarch64-linux-nat.c
1945         (aarch64_linux_nat_target::thread_architecture): Add override.
1946         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
1947         each VQ.
1948
1949 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
1950
1951         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
1952
1953 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
1954
1955         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
1956         target types of size 96-bits, add some additional comments, and
1957         check that the builtin type we found was the correct size.
1958
1959 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
1960
1961         * utils.c (prompt_for_continue): Don't restore the styling at the
1962         end, as applied_style has the wrong value.  This fixes styling in
1963         long lists of file names that are interrupted by the "Continue?"
1964         prompt.
1965
1966 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1967
1968         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
1969         * c-lang.c (c_language_defn): Likewise.
1970         (cplus_language_defn): Likewise.
1971         (asm_language_defn): Likewise.
1972         (minimal_language_defn): Likewise.
1973         * d-lang.c (d_language_defn): Likewise.
1974         * f-lang.c (f_language_defn): Likewise.
1975         * go-lang.c (go_language_defn): Likewise.
1976         * language.c (unknown_language_defn): Likewise.
1977         (auto_language_defn): Likewise.
1978         * language.h (struct language_defn): Remove la_magic field.
1979         (LANG_MAGIC): Delete.
1980         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
1981         * objc-lang.c (objc_language_defn): Likewise.
1982         * opencl-lang.c (opencl_language_defn): Likewise.
1983         * p-lang.c (pascal_language_defn): Likewise.
1984         * rust-lang.c (rust_language_defn): Likewise.
1985
1986 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1987
1988         * riscv-tdep.c (riscv_type_align): New function.
1989         (riscv_type_alignment): Delete.
1990         (riscv_arg_location): Use 'type_align'.
1991         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
1992
1993 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1994
1995         * gdbtypes.c (type_align): A struct with no non-static fields also
1996         has alignment of 1.
1997
1998 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
1999
2000         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2001         component to 0.
2002         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2003         member.
2004         (riscv_struct_info::analyse): New implementation using new
2005         analyse_inner member function.
2006         (riscv_struct_info::field_offset): New member function.
2007         (riscv_struct_info::m_offsets): New member variable.
2008         (riscv_struct_info::analyse_inner): New private member function,
2009         takes the old implementation of riscv_struct_info::analyse but
2010         extended to track field offsets.
2011         (riscv_call_arg_struct): Update the struct folding special cases
2012         to handle cases where empty C++ structs, which are non-zero
2013         length, are found.
2014         (riscv_arg_location): Initialise the length of each location, a
2015         non-zero length now indicates the location is in use.
2016         (riscv_push_dummy_call): Allow for the first location having a
2017         non-zero offset when setting up arguments.
2018         (riscv_return_value): Likewise, but for return values.
2019
2020 2019-04-11  Tom Tromey  <tromey@adacore.com>
2021
2022         * utils.c (internal_vproblem): Make "msg" const.
2023
2024 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2025
2026         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2027         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2028         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2029         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2030
2031 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2032
2033         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2034         function.
2035         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2036         of amd64_collect_native_gregset.
2037         (amd64_linux_nat_target::store_registers): Likewise.
2038
2039 2019-04-10  Tom Tromey  <tom@tromey.com>
2040
2041         * symtab.c (lookup_global_symbol_from_objfile)
2042         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2043         * objfiles.h (class separate_debug_iterator): New.
2044         (class separate_debug_range): New.
2045         (struct objfile) <separate_debug_objfiles>: New method.
2046         (objfile_separate_debug_iterate): Don't declare.
2047         * objfiles.c (separate_debug_iterator::operator++): Rename from
2048         objfile_separate_debug_iterate.
2049         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2050         iterator.
2051         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2052         iterator.
2053
2054 2019-04-10  Tom Tromey  <tom@tromey.com>
2055
2056         * symfile.c (reread_symbols): Remove old comment.
2057         * objfiles.c (free_all_objfiles): Fix a typo.
2058
2059 2019-04-10  Tom Tromey  <tom@tromey.com>
2060
2061         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2062         * minsyms.c (lookup_minimal_symbol): Use foreach.
2063         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2064         (lookup_minimal_symbol_solib_trampoline): Likewise.
2065         * symfile.c (reread_symbols): Use foreach.
2066
2067 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2068             Tom Tromey  <tromey@adacore.com>
2069
2070         PR rust/24414:
2071         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2072         (rust_lex_int_test): Change "value" to be LONGEST.
2073         (rust_lex_tests): Add test for long integer literal.
2074
2075 2019-04-09  Tom Tromey  <tromey@adacore.com>
2076
2077         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2078         to bool.
2079         (extended_remote_target::attach): Update.
2080         (remote_target::remote_notice_new_inferior): Update.
2081         (remote_target::add_current_inferior_and_thread): Update.
2082         * inferior.c (exit_inferior_1): Use "false".
2083         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2084
2085 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2086
2087         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2088         the "start" command.
2089
2090 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2091
2092         * python/py-inferior.c (infpy_thread_from_thread_handle):
2093         Adjust comments to reflect renaming of thread_from_thread_handle
2094         to thread_from_handle.  Adjust keywords.  Fix type error message.
2095         (inferior_object_methods): Add thread_from_handle.  Retain
2096         thread_from_thread_handle, but mark it as deprecated.
2097
2098 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2099
2100         * gdbthread.h (find_thread_by_handle): Revise declaration.
2101         * thread.c (find_thread_by_handle): Likewise.  Adjust
2102         implementation too.
2103         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2104         support for buffer objects as handles.
2105
2106 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2107
2108         * python/py-infthread.c (thpy_thread_handle): New function.
2109         (thread_object_methods): Register thpy_thread_handle.
2110
2111 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2112
2113         * gdbthread.h (thread_to_thread_handle): Declare.
2114         * thread.c (gdbtypes.h): Include.
2115         (thread_to_thread_handle): New function.
2116
2117         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2118         (target_thread_info_to_thread_handle): Declare.
2119         * target.c (target_thread_info_to_thread_handle): New function.
2120         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2121         * target-delegates.c: Regenerate.
2122
2123         * linux-thread-db.c (class thread_db_target): Add method
2124         thread_info_to_thread_handle.
2125         (thread_db_target::thread_info_to_thread_handle): Define.
2126         * remote.c (class remote_target): Add new method
2127         thread_info_to_thread_handle.
2128         (remote_target::thread_info_to_thread_handle): Define.
2129
2130 2019-04-08  Pedro Alves  <palves@redhat.com>
2131
2132         * common/common-exceptions.c (throw_exception): Don't create
2133         named object to throw; throw directly.
2134         (throw_it): Likewise.  Don't initialize gdb_exception::message
2135         here, with new; pass FMT and AP to the ctor instead.
2136         * common/common-exceptions.h: Include <string>.
2137         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2138         const char *, va_list)): New ctor.  Use std::make_shared.
2139         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2140         errors)): Delete.
2141         (gdb_exception_error::gdb_exception_error(enum errors, const char
2142         *, va_list)): New.
2143         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2144         Add assertion.
2145         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2146         errors)): Delete.
2147         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2148         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2149         Add assertion.
2150
2151 2019-04-08  Tom Tromey  <tom@tromey.com>
2152
2153         * valops.c (value_rtti_indirect_type): Replace throw_exception
2154         with throw.
2155         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2156         with throw.
2157         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2158         throw.
2159         * target.c (target_translate_tls_address): Replace throw_exception
2160         with throw.
2161         * stack.c (frame_apply_command_count): Replace throw_exception
2162         with throw.
2163         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2164         throw.
2165         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2166         with throw.
2167         * rs6000-tdep.c (rs6000_frame_cache)
2168         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2169         * remote.c: Replace throw_exception with throw.
2170         * record-full.c (record_full_message, record_full_wait_1)
2171         (record_full_restore): Replace throw_exception with throw.
2172         * record-btrace.c:
2173         (get_thread_current_frame_id, record_btrace_start_replaying)
2174         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2175         (cmd_record_btrace_start): Replace throw_exception with throw.
2176         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2177         throw.
2178         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2179         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2180         * linespec.c:
2181         (find_linespec_symbols): Replace throw_exception with throw.
2182         * infrun.c (displaced_step_prepare, resume): Replace
2183         throw_exception with throw.
2184         * infcmd.c (post_create_inferior): Replace throw_exception with
2185         throw.
2186         * inf-loop.c (inferior_event_handler): Replace throw_exception
2187         with throw.
2188         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2189         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2190         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2191         (get_prev_frame_always, get_frame_pc_if_available)
2192         (get_frame_address_in_block_if_available, get_frame_language):
2193         Replace throw_exception with throw.
2194         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2195         throw_exception with throw.
2196         * eval.c (fetch_subexp_value, evaluate_var_value)
2197         (evaluate_funcall, evaluate_subexp_standard): Replace
2198         throw_exception with throw.
2199         * dwarf2loc.c (call_site_find_chain)
2200         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2201         Replace throw_exception with throw.
2202         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2203         with throw.
2204         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2205         throw.
2206         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2207         * completer.c (complete_line_internal): Replace throw_exception
2208         with throw.
2209         * compile/compile-object-run.c (compile_object_run): Replace
2210         throw_exception with throw.
2211         * cli/cli-script.c (process_next_line): Replace throw_exception
2212         with throw.
2213         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2214         (btrace_enable, btrace_maint_update_pt_packets): Replace
2215         throw_exception with throw.
2216         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2217         throw_exception with throw.
2218         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2219         throw_exception with throw.
2220         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2221         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2222         * aarch64-tdep.c (aarch64_make_prologue_cache)
2223         (aarch64_make_stub_cache): Replace throw_exception with throw.
2224
2225 2019-04-08  Tom Tromey  <tom@tromey.com>
2226
2227         * common/common-exceptions.c (throw_exception): Rename from
2228         throw_exception_cxx.  Remove old copy.  Make argument const.
2229         (throw_it): Create and throw exception objects directly.
2230         * common/common-exceptions.h (throw_exception): Make argument
2231         const.
2232         (struct gdb_exception_error): Add constructor.
2233         (struct gdb_exception_quit): Add constructor.
2234
2235 2019-04-08  Tom Tromey  <tom@tromey.com>
2236
2237         * common/common-exceptions.h (exception_rethrow): Don't declare.
2238         (TRY_SJLJ): Update comment.
2239         (TRY, CATCH, END_CATCH): Remove.
2240         * common/common-exceptions.c (exception_rethrow): Remove.
2241
2242 2019-04-08  Tom Tromey  <tom@tromey.com>
2243
2244         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2245         Remove.
2246         (gdb_exception_error): Rename from
2247         gdb_exception_RETURN_MASK_ERROR.
2248         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2249         (gdb_quit_bad_alloc): Update.
2250         * aarch64-tdep.c: Update.
2251         * ada-lang.c: Update.
2252         * ada-typeprint.c: Update.
2253         * ada-valprint.c: Update.
2254         * amd64-tdep.c: Update.
2255         * arch-utils.c: Update.
2256         * break-catch-throw.c: Update.
2257         * breakpoint.c: Update.
2258         * btrace.c: Update.
2259         * c-varobj.c: Update.
2260         * cli/cli-cmds.c: Update.
2261         * cli/cli-interp.c: Update.
2262         * cli/cli-script.c: Update.
2263         * common/common-exceptions.c: Update.
2264         * common/new-op.c: Update.
2265         * common/selftest.c: Update.
2266         * compile/compile-c-symbols.c: Update.
2267         * compile/compile-cplus-symbols.c: Update.
2268         * compile/compile-object-load.c: Update.
2269         * compile/compile-object-run.c: Update.
2270         * completer.c: Update.
2271         * corelow.c: Update.
2272         * cp-abi.c: Update.
2273         * cp-support.c: Update.
2274         * cp-valprint.c: Update.
2275         * darwin-nat.c: Update.
2276         * disasm-selftests.c: Update.
2277         * dtrace-probe.c: Update.
2278         * dwarf-index-cache.c: Update.
2279         * dwarf-index-write.c: Update.
2280         * dwarf2-frame-tailcall.c: Update.
2281         * dwarf2-frame.c: Update.
2282         * dwarf2loc.c: Update.
2283         * dwarf2read.c: Update.
2284         * eval.c: Update.
2285         * event-loop.c: Update.
2286         * event-top.c: Update.
2287         * exec.c: Update.
2288         * f-valprint.c: Update.
2289         * fbsd-tdep.c: Update.
2290         * frame-unwind.c: Update.
2291         * frame.c: Update.
2292         * gdbtypes.c: Update.
2293         * gnu-v3-abi.c: Update.
2294         * guile/guile-internal.h: Update.
2295         * guile/scm-block.c: Update.
2296         * guile/scm-breakpoint.c: Update.
2297         * guile/scm-cmd.c: Update.
2298         * guile/scm-disasm.c: Update.
2299         * guile/scm-frame.c: Update.
2300         * guile/scm-lazy-string.c: Update.
2301         * guile/scm-math.c: Update.
2302         * guile/scm-param.c: Update.
2303         * guile/scm-ports.c: Update.
2304         * guile/scm-pretty-print.c: Update.
2305         * guile/scm-symbol.c: Update.
2306         * guile/scm-symtab.c: Update.
2307         * guile/scm-type.c: Update.
2308         * guile/scm-value.c: Update.
2309         * i386-linux-tdep.c: Update.
2310         * i386-tdep.c: Update.
2311         * inf-loop.c: Update.
2312         * infcall.c: Update.
2313         * infcmd.c: Update.
2314         * infrun.c: Update.
2315         * jit.c: Update.
2316         * language.c: Update.
2317         * linespec.c: Update.
2318         * linux-fork.c: Update.
2319         * linux-nat.c: Update.
2320         * linux-tdep.c: Update.
2321         * linux-thread-db.c: Update.
2322         * main.c: Update.
2323         * mi/mi-cmd-break.c: Update.
2324         * mi/mi-cmd-stack.c: Update.
2325         * mi/mi-interp.c: Update.
2326         * mi/mi-main.c: Update.
2327         * objc-lang.c: Update.
2328         * p-valprint.c: Update.
2329         * parse.c: Update.
2330         * ppc-linux-tdep.c: Update.
2331         * printcmd.c: Update.
2332         * python/py-arch.c: Update.
2333         * python/py-breakpoint.c: Update.
2334         * python/py-cmd.c: Update.
2335         * python/py-finishbreakpoint.c: Update.
2336         * python/py-frame.c: Update.
2337         * python/py-framefilter.c: Update.
2338         * python/py-gdb-readline.c: Update.
2339         * python/py-inferior.c: Update.
2340         * python/py-infthread.c: Update.
2341         * python/py-lazy-string.c: Update.
2342         * python/py-linetable.c: Update.
2343         * python/py-objfile.c: Update.
2344         * python/py-param.c: Update.
2345         * python/py-prettyprint.c: Update.
2346         * python/py-progspace.c: Update.
2347         * python/py-record-btrace.c: Update.
2348         * python/py-record.c: Update.
2349         * python/py-symbol.c: Update.
2350         * python/py-type.c: Update.
2351         * python/py-unwind.c: Update.
2352         * python/py-utils.c: Update.
2353         * python/py-value.c: Update.
2354         * python/python.c: Update.
2355         * record-btrace.c: Update.
2356         * record-full.c: Update.
2357         * remote-fileio.c: Update.
2358         * remote.c: Update.
2359         * riscv-tdep.c: Update.
2360         * rs6000-aix-tdep.c: Update.
2361         * rs6000-tdep.c: Update.
2362         * rust-exp.y: Update.
2363         * rust-lang.c: Update.
2364         * s390-tdep.c: Update.
2365         * selftest-arch.c: Update.
2366         * solib-dsbt.c: Update.
2367         * solib-frv.c: Update.
2368         * solib-spu.c: Update.
2369         * solib-svr4.c: Update.
2370         * solib.c: Update.
2371         * sparc64-linux-tdep.c: Update.
2372         * stack.c: Update.
2373         * symfile-mem.c: Update.
2374         * symmisc.c: Update.
2375         * target.c: Update.
2376         * thread.c: Update.
2377         * top.c: Update.
2378         * tracefile-tfile.c: Update.
2379         * tui/tui.c: Update.
2380         * typeprint.c: Update.
2381         * unittests/cli-utils-selftests.c: Update.
2382         * unittests/parse-connection-spec-selftests.c: Update.
2383         * valops.c: Update.
2384         * valprint.c: Update.
2385         * value.c: Update.
2386         * varobj.c: Update.
2387         * windows-nat.c: Update.
2388         * x86-linux-nat.c: Update.
2389         * xml-support.c: Update.
2390
2391 2019-04-08  Tom Tromey  <tom@tromey.com>
2392
2393         * xml-support.c: Use C++ exception handling.
2394         * x86-linux-nat.c: Use C++ exception handling.
2395         * windows-nat.c: Use C++ exception handling.
2396         * varobj.c: Use C++ exception handling.
2397         * value.c: Use C++ exception handling.
2398         * valprint.c: Use C++ exception handling.
2399         * valops.c: Use C++ exception handling.
2400         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2401         handling.
2402         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2403         * typeprint.c: Use C++ exception handling.
2404         * tui/tui.c: Use C++ exception handling.
2405         * tracefile-tfile.c: Use C++ exception handling.
2406         * top.c: Use C++ exception handling.
2407         * thread.c: Use C++ exception handling.
2408         * target.c: Use C++ exception handling.
2409         * symmisc.c: Use C++ exception handling.
2410         * symfile-mem.c: Use C++ exception handling.
2411         * stack.c: Use C++ exception handling.
2412         * sparc64-linux-tdep.c: Use C++ exception handling.
2413         * solib.c: Use C++ exception handling.
2414         * solib-svr4.c: Use C++ exception handling.
2415         * solib-spu.c: Use C++ exception handling.
2416         * solib-frv.c: Use C++ exception handling.
2417         * solib-dsbt.c: Use C++ exception handling.
2418         * selftest-arch.c: Use C++ exception handling.
2419         * s390-tdep.c: Use C++ exception handling.
2420         * rust-lang.c: Use C++ exception handling.
2421         * rust-exp.y: Use C++ exception handling.
2422         * rs6000-tdep.c: Use C++ exception handling.
2423         * rs6000-aix-tdep.c: Use C++ exception handling.
2424         * riscv-tdep.c: Use C++ exception handling.
2425         * remote.c: Use C++ exception handling.
2426         * remote-fileio.c: Use C++ exception handling.
2427         * record-full.c: Use C++ exception handling.
2428         * record-btrace.c: Use C++ exception handling.
2429         * python/python.c: Use C++ exception handling.
2430         * python/py-value.c: Use C++ exception handling.
2431         * python/py-utils.c: Use C++ exception handling.
2432         * python/py-unwind.c: Use C++ exception handling.
2433         * python/py-type.c: Use C++ exception handling.
2434         * python/py-symbol.c: Use C++ exception handling.
2435         * python/py-record.c: Use C++ exception handling.
2436         * python/py-record-btrace.c: Use C++ exception handling.
2437         * python/py-progspace.c: Use C++ exception handling.
2438         * python/py-prettyprint.c: Use C++ exception handling.
2439         * python/py-param.c: Use C++ exception handling.
2440         * python/py-objfile.c: Use C++ exception handling.
2441         * python/py-linetable.c: Use C++ exception handling.
2442         * python/py-lazy-string.c: Use C++ exception handling.
2443         * python/py-infthread.c: Use C++ exception handling.
2444         * python/py-inferior.c: Use C++ exception handling.
2445         * python/py-gdb-readline.c: Use C++ exception handling.
2446         * python/py-framefilter.c: Use C++ exception handling.
2447         * python/py-frame.c: Use C++ exception handling.
2448         * python/py-finishbreakpoint.c: Use C++ exception handling.
2449         * python/py-cmd.c: Use C++ exception handling.
2450         * python/py-breakpoint.c: Use C++ exception handling.
2451         * python/py-arch.c: Use C++ exception handling.
2452         * printcmd.c: Use C++ exception handling.
2453         * ppc-linux-tdep.c: Use C++ exception handling.
2454         * parse.c: Use C++ exception handling.
2455         * p-valprint.c: Use C++ exception handling.
2456         * objc-lang.c: Use C++ exception handling.
2457         * mi/mi-main.c: Use C++ exception handling.
2458         * mi/mi-interp.c: Use C++ exception handling.
2459         * mi/mi-cmd-stack.c: Use C++ exception handling.
2460         * mi/mi-cmd-break.c: Use C++ exception handling.
2461         * main.c: Use C++ exception handling.
2462         * linux-thread-db.c: Use C++ exception handling.
2463         * linux-tdep.c: Use C++ exception handling.
2464         * linux-nat.c: Use C++ exception handling.
2465         * linux-fork.c: Use C++ exception handling.
2466         * linespec.c: Use C++ exception handling.
2467         * language.c: Use C++ exception handling.
2468         * jit.c: Use C++ exception handling.
2469         * infrun.c: Use C++ exception handling.
2470         * infcmd.c: Use C++ exception handling.
2471         * infcall.c: Use C++ exception handling.
2472         * inf-loop.c: Use C++ exception handling.
2473         * i386-tdep.c: Use C++ exception handling.
2474         * i386-linux-tdep.c: Use C++ exception handling.
2475         * guile/scm-value.c: Use C++ exception handling.
2476         * guile/scm-type.c: Use C++ exception handling.
2477         * guile/scm-symtab.c: Use C++ exception handling.
2478         * guile/scm-symbol.c: Use C++ exception handling.
2479         * guile/scm-pretty-print.c: Use C++ exception handling.
2480         * guile/scm-ports.c: Use C++ exception handling.
2481         * guile/scm-param.c: Use C++ exception handling.
2482         * guile/scm-math.c: Use C++ exception handling.
2483         * guile/scm-lazy-string.c: Use C++ exception handling.
2484         * guile/scm-frame.c: Use C++ exception handling.
2485         * guile/scm-disasm.c: Use C++ exception handling.
2486         * guile/scm-cmd.c: Use C++ exception handling.
2487         * guile/scm-breakpoint.c: Use C++ exception handling.
2488         * guile/scm-block.c: Use C++ exception handling.
2489         * guile/guile-internal.h: Use C++ exception handling.
2490         * gnu-v3-abi.c: Use C++ exception handling.
2491         * gdbtypes.c: Use C++ exception handling.
2492         * frame.c: Use C++ exception handling.
2493         * frame-unwind.c: Use C++ exception handling.
2494         * fbsd-tdep.c: Use C++ exception handling.
2495         * f-valprint.c: Use C++ exception handling.
2496         * exec.c: Use C++ exception handling.
2497         * event-top.c: Use C++ exception handling.
2498         * event-loop.c: Use C++ exception handling.
2499         * eval.c: Use C++ exception handling.
2500         * dwarf2read.c: Use C++ exception handling.
2501         * dwarf2loc.c: Use C++ exception handling.
2502         * dwarf2-frame.c: Use C++ exception handling.
2503         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2504         * dwarf-index-write.c: Use C++ exception handling.
2505         * dwarf-index-cache.c: Use C++ exception handling.
2506         * dtrace-probe.c: Use C++ exception handling.
2507         * disasm-selftests.c: Use C++ exception handling.
2508         * darwin-nat.c: Use C++ exception handling.
2509         * cp-valprint.c: Use C++ exception handling.
2510         * cp-support.c: Use C++ exception handling.
2511         * cp-abi.c: Use C++ exception handling.
2512         * corelow.c: Use C++ exception handling.
2513         * completer.c: Use C++ exception handling.
2514         * compile/compile-object-run.c: Use C++ exception handling.
2515         * compile/compile-object-load.c: Use C++ exception handling.
2516         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2517         * compile/compile-c-symbols.c: Use C++ exception handling.
2518         * common/selftest.c: Use C++ exception handling.
2519         * common/new-op.c: Use C++ exception handling.
2520         * cli/cli-script.c: Use C++ exception handling.
2521         * cli/cli-interp.c: Use C++ exception handling.
2522         * cli/cli-cmds.c: Use C++ exception handling.
2523         * c-varobj.c: Use C++ exception handling.
2524         * btrace.c: Use C++ exception handling.
2525         * breakpoint.c: Use C++ exception handling.
2526         * break-catch-throw.c: Use C++ exception handling.
2527         * arch-utils.c: Use C++ exception handling.
2528         * amd64-tdep.c: Use C++ exception handling.
2529         * ada-valprint.c: Use C++ exception handling.
2530         * ada-typeprint.c: Use C++ exception handling.
2531         * ada-lang.c: Use C++ exception handling.
2532         * aarch64-tdep.c: Use C++ exception handling.
2533
2534 2019-04-08  Tom Tromey  <tom@tromey.com>
2535
2536         * xml-support.c (gdb_xml_parser::parse): Update.
2537         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2538         * value.c (show_convenience): Update.
2539         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2540         (test_parse_flags_qcs): Update.
2541         * thread.c (thr_try_catch_cmd): Update.
2542         * target.c (target_translate_tls_address): Update.
2543         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2544         (info_frame_command_core, frame_apply_command_count): Update.
2545         * rust-exp.y (rust_lex_exception_test): Update.
2546         * riscv-tdep.c (riscv_print_one_register_info): Update.
2547         * remote.c (remote_target::enable_btrace): Update.
2548         * record-btrace.c (record_btrace_enable_warn): Update.
2549         * python/py-utils.c (gdbpy_convert_exception): Update.
2550         * printcmd.c (do_one_display, print_variable_and_value): Update.
2551         * mi/mi-main.c (mi_print_exception): Update.
2552         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2553         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2554         * linux-nat.c (linux_nat_target::attach): Update.
2555         * linux-fork.c (class scoped_switch_fork_info): Update.
2556         * infrun.c (displaced_step_prepare): Update.
2557         * infcall.c (call_function_by_hand_dummy): Update.
2558         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2559         * gnu-v3-abi.c (print_one_vtable): Update.
2560         * frame.c (get_prev_frame_always): Update.
2561         * f-valprint.c (info_common_command_for_block): Update.
2562         * exec.c (try_open_exec_file): Update.
2563         * exceptions.c (print_exception, exception_print)
2564         (exception_fprintf, exception_print_same): Update.
2565         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2566         * dwarf-index-cache.c (index_cache::store)
2567         (index_cache::lookup_gdb_index): Update.
2568         * darwin-nat.c (maybe_cache_shell): Update.
2569         * cp-valprint.c (cp_print_value_fields): Update.
2570         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2571         (gcc_cplus_symbol_address): Update.
2572         * compile/compile-c-symbols.c (gcc_convert_symbol)
2573         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2574         * common/selftest.c: Update.
2575         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2576         a std::string.
2577         (exception_try_scope_entry, exception_try_scope_exit): Don't
2578         declare.
2579         (struct exception_try_scope): Remove.
2580         (TRY): Don't use exception_try_scope.
2581         (struct gdb_exception): Add constructor, operator=.
2582         <what>: New method.
2583         (struct gdb_exception_RETURN_MASK_ALL)
2584         (struct gdb_exception_RETURN_MASK_ERROR)
2585         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2586         (struct gdb_quit_bad_alloc): Update.
2587         * common/common-exceptions.c (exception_none): Change
2588         initializer.
2589         (struct catcher) <state, exception>: Initialize inline.
2590         <prev>: Remove member.
2591         (current_catcher): Remove.
2592         (catchers): New global.
2593         (exceptions_state_mc_init): Simplify.
2594         (catcher_pop): Remove.
2595         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2596         (try_scope_depth, exception_try_scope_entry)
2597         (exception_try_scope_exit): Remove.
2598         (throw_exception_sjlj): Update.
2599         (exception_messages, exception_messages_size): Remove.
2600         (throw_it): Simplify.
2601         (gdb_exception_sliced_copy): Remove.
2602         (throw_exception_cxx): Update.
2603         * cli/cli-script.c (script_from_file): Update.
2604         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2605         Update.
2606         * ada-valprint.c (ada_val_print): Update.
2607         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2608         (create_excep_cond_exprs): Update.
2609
2610 2019-04-08  Tom Tromey  <tom@tromey.com>
2611
2612         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2613         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2614         (TRY, CATCH, END_CATCH): Remove some definitions.
2615         * common/common-exceptions.c: Don't use GDB_XCPT.
2616         (catcher_list_size): Remove.
2617         (throw_exception, throw_it): Simplify.
2618
2619 2019-04-05  Tom Tromey  <tom@tromey.com>
2620
2621         Revert the header-sorting patch.
2622         * ft32-tdep.c: Revert.
2623         * frv-tdep.c: Revert.
2624         * frv-linux-tdep.c: Revert.
2625         * frame.c: Revert.
2626         * frame-unwind.c: Revert.
2627         * frame-base.c: Revert.
2628         * fork-child.c: Revert.
2629         * findvar.c: Revert.
2630         * findcmd.c: Revert.
2631         * filesystem.c: Revert.
2632         * filename-seen-cache.h: Revert.
2633         * filename-seen-cache.c: Revert.
2634         * fbsd-tdep.c: Revert.
2635         * fbsd-nat.h: Revert.
2636         * fbsd-nat.c: Revert.
2637         * f-valprint.c: Revert.
2638         * f-typeprint.c: Revert.
2639         * f-lang.c: Revert.
2640         * extension.h: Revert.
2641         * extension.c: Revert.
2642         * extension-priv.h: Revert.
2643         * expprint.c: Revert.
2644         * exec.h: Revert.
2645         * exec.c: Revert.
2646         * exceptions.c: Revert.
2647         * event-top.c: Revert.
2648         * event-loop.c: Revert.
2649         * eval.c: Revert.
2650         * elfread.c: Revert.
2651         * dwarf2read.h: Revert.
2652         * dwarf2read.c: Revert.
2653         * dwarf2loc.c: Revert.
2654         * dwarf2expr.h: Revert.
2655         * dwarf2expr.c: Revert.
2656         * dwarf2-frame.c: Revert.
2657         * dwarf2-frame-tailcall.c: Revert.
2658         * dwarf-index-write.h: Revert.
2659         * dwarf-index-write.c: Revert.
2660         * dwarf-index-common.c: Revert.
2661         * dwarf-index-cache.h: Revert.
2662         * dwarf-index-cache.c: Revert.
2663         * dummy-frame.c: Revert.
2664         * dtrace-probe.c: Revert.
2665         * disasm.h: Revert.
2666         * disasm.c: Revert.
2667         * disasm-selftests.c: Revert.
2668         * dictionary.c: Revert.
2669         * dicos-tdep.c: Revert.
2670         * demangle.c: Revert.
2671         * dcache.h: Revert.
2672         * dcache.c: Revert.
2673         * darwin-nat.h: Revert.
2674         * darwin-nat.c: Revert.
2675         * darwin-nat-info.c: Revert.
2676         * d-valprint.c: Revert.
2677         * d-namespace.c: Revert.
2678         * d-lang.c: Revert.
2679         * ctf.c: Revert.
2680         * csky-tdep.c: Revert.
2681         * csky-linux-tdep.c: Revert.
2682         * cris-tdep.c: Revert.
2683         * cris-linux-tdep.c: Revert.
2684         * cp-valprint.c: Revert.
2685         * cp-support.c: Revert.
2686         * cp-namespace.c: Revert.
2687         * cp-abi.c: Revert.
2688         * corelow.c: Revert.
2689         * corefile.c: Revert.
2690         * continuations.c: Revert.
2691         * completer.h: Revert.
2692         * completer.c: Revert.
2693         * complaints.c: Revert.
2694         * coffread.c: Revert.
2695         * coff-pe-read.c: Revert.
2696         * cli-out.h: Revert.
2697         * cli-out.c: Revert.
2698         * charset.c: Revert.
2699         * c-varobj.c: Revert.
2700         * c-valprint.c: Revert.
2701         * c-typeprint.c: Revert.
2702         * c-lang.c: Revert.
2703         * buildsym.c: Revert.
2704         * buildsym-legacy.c: Revert.
2705         * build-id.h: Revert.
2706         * build-id.c: Revert.
2707         * btrace.c: Revert.
2708         * bsd-uthread.c: Revert.
2709         * breakpoint.h: Revert.
2710         * breakpoint.c: Revert.
2711         * break-catch-throw.c: Revert.
2712         * break-catch-syscall.c: Revert.
2713         * break-catch-sig.c: Revert.
2714         * blockframe.c: Revert.
2715         * block.c: Revert.
2716         * bfin-tdep.c: Revert.
2717         * bfin-linux-tdep.c: Revert.
2718         * bfd-target.c: Revert.
2719         * bcache.c: Revert.
2720         * ax-general.c: Revert.
2721         * ax-gdb.h: Revert.
2722         * ax-gdb.c: Revert.
2723         * avr-tdep.c: Revert.
2724         * auxv.c: Revert.
2725         * auto-load.c: Revert.
2726         * arm-wince-tdep.c: Revert.
2727         * arm-tdep.c: Revert.
2728         * arm-symbian-tdep.c: Revert.
2729         * arm-pikeos-tdep.c: Revert.
2730         * arm-obsd-tdep.c: Revert.
2731         * arm-nbsd-tdep.c: Revert.
2732         * arm-nbsd-nat.c: Revert.
2733         * arm-linux-tdep.c: Revert.
2734         * arm-linux-nat.c: Revert.
2735         * arm-fbsd-tdep.c: Revert.
2736         * arm-fbsd-nat.c: Revert.
2737         * arm-bsd-tdep.c: Revert.
2738         * arch-utils.c: Revert.
2739         * arc-tdep.c: Revert.
2740         * arc-newlib-tdep.c: Revert.
2741         * annotate.h: Revert.
2742         * annotate.c: Revert.
2743         * amd64-windows-tdep.c: Revert.
2744         * amd64-windows-nat.c: Revert.
2745         * amd64-tdep.c: Revert.
2746         * amd64-sol2-tdep.c: Revert.
2747         * amd64-obsd-tdep.c: Revert.
2748         * amd64-obsd-nat.c: Revert.
2749         * amd64-nbsd-tdep.c: Revert.
2750         * amd64-nbsd-nat.c: Revert.
2751         * amd64-nat.c: Revert.
2752         * amd64-linux-tdep.c: Revert.
2753         * amd64-linux-nat.c: Revert.
2754         * amd64-fbsd-tdep.c: Revert.
2755         * amd64-fbsd-nat.c: Revert.
2756         * amd64-dicos-tdep.c: Revert.
2757         * amd64-darwin-tdep.c: Revert.
2758         * amd64-bsd-nat.c: Revert.
2759         * alpha-tdep.c: Revert.
2760         * alpha-obsd-tdep.c: Revert.
2761         * alpha-nbsd-tdep.c: Revert.
2762         * alpha-mdebug-tdep.c: Revert.
2763         * alpha-linux-tdep.c: Revert.
2764         * alpha-linux-nat.c: Revert.
2765         * alpha-bsd-tdep.c: Revert.
2766         * alpha-bsd-nat.c: Revert.
2767         * aix-thread.c: Revert.
2768         * agent.c: Revert.
2769         * addrmap.c: Revert.
2770         * ada-varobj.c: Revert.
2771         * ada-valprint.c: Revert.
2772         * ada-typeprint.c: Revert.
2773         * ada-tasks.c: Revert.
2774         * ada-lang.c: Revert.
2775         * aarch64-tdep.c: Revert.
2776         * aarch64-ravenscar-thread.c: Revert.
2777         * aarch64-newlib-tdep.c: Revert.
2778         * aarch64-linux-tdep.c: Revert.
2779         * aarch64-linux-nat.c: Revert.
2780         * aarch64-fbsd-tdep.c: Revert.
2781         * aarch64-fbsd-nat.c: Revert.
2782         * aarch32-linux-nat.c: Revert.
2783
2784 2019-04-05  Tom Tromey  <tom@tromey.com>
2785
2786         * ft32-tdep.c: Sort headers.
2787         * frv-tdep.c: Sort headers.
2788         * frv-linux-tdep.c: Sort headers.
2789         * frame.c: Sort headers.
2790         * frame-unwind.c: Sort headers.
2791         * frame-base.c: Sort headers.
2792         * fork-child.c: Sort headers.
2793         * findvar.c: Sort headers.
2794         * findcmd.c: Sort headers.
2795         * filesystem.c: Sort headers.
2796         * filename-seen-cache.h: Sort headers.
2797         * filename-seen-cache.c: Sort headers.
2798         * fbsd-tdep.c: Sort headers.
2799         * fbsd-nat.h: Sort headers.
2800         * fbsd-nat.c: Sort headers.
2801         * f-valprint.c: Sort headers.
2802         * f-typeprint.c: Sort headers.
2803         * f-lang.c: Sort headers.
2804         * extension.h: Sort headers.
2805         * extension.c: Sort headers.
2806         * extension-priv.h: Sort headers.
2807         * expprint.c: Sort headers.
2808         * exec.h: Sort headers.
2809         * exec.c: Sort headers.
2810         * exceptions.c: Sort headers.
2811         * event-top.c: Sort headers.
2812         * event-loop.c: Sort headers.
2813         * eval.c: Sort headers.
2814         * elfread.c: Sort headers.
2815         * dwarf2read.h: Sort headers.
2816         * dwarf2read.c: Sort headers.
2817         * dwarf2loc.c: Sort headers.
2818         * dwarf2expr.h: Sort headers.
2819         * dwarf2expr.c: Sort headers.
2820         * dwarf2-frame.c: Sort headers.
2821         * dwarf2-frame-tailcall.c: Sort headers.
2822         * dwarf-index-write.h: Sort headers.
2823         * dwarf-index-write.c: Sort headers.
2824         * dwarf-index-common.c: Sort headers.
2825         * dwarf-index-cache.h: Sort headers.
2826         * dwarf-index-cache.c: Sort headers.
2827         * dummy-frame.c: Sort headers.
2828         * dtrace-probe.c: Sort headers.
2829         * disasm.h: Sort headers.
2830         * disasm.c: Sort headers.
2831         * disasm-selftests.c: Sort headers.
2832         * dictionary.c: Sort headers.
2833         * dicos-tdep.c: Sort headers.
2834         * demangle.c: Sort headers.
2835         * dcache.h: Sort headers.
2836         * dcache.c: Sort headers.
2837         * darwin-nat.h: Sort headers.
2838         * darwin-nat.c: Sort headers.
2839         * darwin-nat-info.c: Sort headers.
2840         * d-valprint.c: Sort headers.
2841         * d-namespace.c: Sort headers.
2842         * d-lang.c: Sort headers.
2843         * ctf.c: Sort headers.
2844         * csky-tdep.c: Sort headers.
2845         * csky-linux-tdep.c: Sort headers.
2846         * cris-tdep.c: Sort headers.
2847         * cris-linux-tdep.c: Sort headers.
2848         * cp-valprint.c: Sort headers.
2849         * cp-support.c: Sort headers.
2850         * cp-namespace.c: Sort headers.
2851         * cp-abi.c: Sort headers.
2852         * corelow.c: Sort headers.
2853         * corefile.c: Sort headers.
2854         * continuations.c: Sort headers.
2855         * completer.h: Sort headers.
2856         * completer.c: Sort headers.
2857         * complaints.c: Sort headers.
2858         * coffread.c: Sort headers.
2859         * coff-pe-read.c: Sort headers.
2860         * cli-out.h: Sort headers.
2861         * cli-out.c: Sort headers.
2862         * charset.c: Sort headers.
2863         * c-varobj.c: Sort headers.
2864         * c-valprint.c: Sort headers.
2865         * c-typeprint.c: Sort headers.
2866         * c-lang.c: Sort headers.
2867         * buildsym.c: Sort headers.
2868         * buildsym-legacy.c: Sort headers.
2869         * build-id.h: Sort headers.
2870         * build-id.c: Sort headers.
2871         * btrace.c: Sort headers.
2872         * bsd-uthread.c: Sort headers.
2873         * breakpoint.h: Sort headers.
2874         * breakpoint.c: Sort headers.
2875         * break-catch-throw.c: Sort headers.
2876         * break-catch-syscall.c: Sort headers.
2877         * break-catch-sig.c: Sort headers.
2878         * blockframe.c: Sort headers.
2879         * block.c: Sort headers.
2880         * bfin-tdep.c: Sort headers.
2881         * bfin-linux-tdep.c: Sort headers.
2882         * bfd-target.c: Sort headers.
2883         * bcache.c: Sort headers.
2884         * ax-general.c: Sort headers.
2885         * ax-gdb.h: Sort headers.
2886         * ax-gdb.c: Sort headers.
2887         * avr-tdep.c: Sort headers.
2888         * auxv.c: Sort headers.
2889         * auto-load.c: Sort headers.
2890         * arm-wince-tdep.c: Sort headers.
2891         * arm-tdep.c: Sort headers.
2892         * arm-symbian-tdep.c: Sort headers.
2893         * arm-pikeos-tdep.c: Sort headers.
2894         * arm-obsd-tdep.c: Sort headers.
2895         * arm-nbsd-tdep.c: Sort headers.
2896         * arm-nbsd-nat.c: Sort headers.
2897         * arm-linux-tdep.c: Sort headers.
2898         * arm-linux-nat.c: Sort headers.
2899         * arm-fbsd-tdep.c: Sort headers.
2900         * arm-fbsd-nat.c: Sort headers.
2901         * arm-bsd-tdep.c: Sort headers.
2902         * arch-utils.c: Sort headers.
2903         * arc-tdep.c: Sort headers.
2904         * arc-newlib-tdep.c: Sort headers.
2905         * annotate.h: Sort headers.
2906         * annotate.c: Sort headers.
2907         * amd64-windows-tdep.c: Sort headers.
2908         * amd64-windows-nat.c: Sort headers.
2909         * amd64-tdep.c: Sort headers.
2910         * amd64-sol2-tdep.c: Sort headers.
2911         * amd64-obsd-tdep.c: Sort headers.
2912         * amd64-obsd-nat.c: Sort headers.
2913         * amd64-nbsd-tdep.c: Sort headers.
2914         * amd64-nbsd-nat.c: Sort headers.
2915         * amd64-nat.c: Sort headers.
2916         * amd64-linux-tdep.c: Sort headers.
2917         * amd64-linux-nat.c: Sort headers.
2918         * amd64-fbsd-tdep.c: Sort headers.
2919         * amd64-fbsd-nat.c: Sort headers.
2920         * amd64-dicos-tdep.c: Sort headers.
2921         * amd64-darwin-tdep.c: Sort headers.
2922         * amd64-bsd-nat.c: Sort headers.
2923         * alpha-tdep.c: Sort headers.
2924         * alpha-obsd-tdep.c: Sort headers.
2925         * alpha-nbsd-tdep.c: Sort headers.
2926         * alpha-mdebug-tdep.c: Sort headers.
2927         * alpha-linux-tdep.c: Sort headers.
2928         * alpha-linux-nat.c: Sort headers.
2929         * alpha-bsd-tdep.c: Sort headers.
2930         * alpha-bsd-nat.c: Sort headers.
2931         * aix-thread.c: Sort headers.
2932         * agent.c: Sort headers.
2933         * addrmap.c: Sort headers.
2934         * ada-varobj.c: Sort headers.
2935         * ada-valprint.c: Sort headers.
2936         * ada-typeprint.c: Sort headers.
2937         * ada-tasks.c: Sort headers.
2938         * ada-lang.c: Sort headers.
2939         * aarch64-tdep.c: Sort headers.
2940         * aarch64-ravenscar-thread.c: Sort headers.
2941         * aarch64-newlib-tdep.c: Sort headers.
2942         * aarch64-linux-tdep.c: Sort headers.
2943         * aarch64-linux-nat.c: Sort headers.
2944         * aarch64-fbsd-tdep.c: Sort headers.
2945         * aarch64-fbsd-nat.c: Sort headers.
2946         * aarch32-linux-nat.c: Sort headers.
2947
2948 2019-04-04  Tom Tromey  <tom@tromey.com>
2949
2950         * varobj.c (varobj_create): Update.
2951         * rust-exp.y (struct rust_parser) <update_innermost_block,
2952         lookup_symbol>: New methods.
2953         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
2954         Rename.
2955         (rust_parser::rust_lookup_type)
2956         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
2957         * printcmd.c (display_command, do_one_display): Update.
2958         * parser-defs.h (struct parser_state) <parser_state>: Add
2959         "tracker" parameter.
2960         (block_tracker): New member.
2961         (class innermost_block_tracker) <innermost_block_tracker>: Add
2962         "types" parameter.
2963         <reset>: Remove method.
2964         (innermost_block): Don't declare.
2965         (null_post_parser): Update.
2966         * parse.c (innermost_block): Remove global.
2967         (write_dollar_variable): Update.
2968         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
2969         Remove "tracker_types" parameter.
2970         (parse_expression): Add "tracker" parameter.
2971         (parse_expression_for_completion): Update.
2972         (null_post_parser): Add "tracker" parameter.
2973         * p-exp.y: Update rules.
2974         * m2-exp.y: Update rules.
2975         * language.h (struct language_defn) <la_post_parser>: Add
2976         "tracker" parameter.
2977         * go-exp.y: Update rules.
2978         * f-exp.y: Update rules.
2979         * expression.h (parse_expression, parse_exp_1): Add "tracker"
2980         parameter.
2981         * d-exp.y: Update rules.
2982         * c-exp.y: Update rules.
2983         * breakpoint.c (set_breakpoint_condition): Create an
2984         innermost_block_tracker.
2985         (watch_command_1): Likewise.
2986         * ada-lang.c (resolve): Add "tracker" parameter.
2987         (resolve_subexp): Likewise.
2988         * ada-exp.y (write_var_from_sym): Update.
2989
2990 2019-04-04  Tom Tromey  <tom@tromey.com>
2991
2992         * type-stack.h: New file.
2993         * type-stack.c: New file.
2994         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
2995         type-stack.h.
2996         (insert_into_type_stack, insert_type, push_type, push_type_int)
2997         (insert_type_address_space, pop_type, pop_type_int)
2998         (pop_typelist, pop_type_stack, append_type_stack)
2999         (push_type_stack, get_type_stack, push_typelist)
3000         (follow_type_instance_flags, follow_types): Don't declare.
3001         * parse.c (type_stack): Remove global.
3002         (parse_exp_in_context): Update.
3003         (insert_into_type_stack, insert_type, push_type, push_type_int)
3004         (insert_type_address_space, pop_type, pop_type_int)
3005         (pop_typelist, pop_type_stack, append_type_stack)
3006         (push_type_stack, get_type_stack, push_typelist)
3007         (follow_type_instance_flags, follow_types): Remove (moved to
3008         type-stack.c).
3009         * f-exp.y (type_stack): New global.
3010         Update rules.
3011         (push_kind_type, f_parse): Update.
3012         * d-exp.y (type_stack): New global.
3013         Update rules.
3014         (d_parse): Update.
3015         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3016         Update rules.
3017         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3018         (HFILES_NO_SRCDIR): Add type-stack.h.
3019
3020 2019-04-04  Tom Tromey  <tom@tromey.com>
3021
3022         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3023         (rust_parser::convert_ast_to_expression, rust_parse)
3024         (rust_lex_test_completion, rust_lex_tests): Update.
3025         * parser-defs.h (struct expr_completion_state): New.
3026         (struct parser_state) <parser_state>: Add completion parameter.
3027         <mark_struct_expression, mark_completion_tag>: New methods.
3028         <parse_completion, m_completion_state>: New members.
3029         (prefixify_expression, null_post_parser): Update.
3030         (mark_struct_expression, mark_completion_tag): Don't declare.
3031         * parse.c (parse_completion, expout_last_struct)
3032         (expout_tag_completion_type, expout_completion_name): Remove
3033         globals.
3034         (parser_state::mark_struct_expression)
3035         (parser_state::mark_completion_tag): Now methods.
3036         (prefixify_expression): Add last_struct parameter.
3037         (prefixify_subexp): Likewise.
3038         (parse_exp_1): Update.
3039         (parse_exp_in_context): Add cstate parameter.  Update.
3040         (parse_expression_for_completion): Create an
3041         expr_completion_state.
3042         (null_post_parser): Add "completion" parameter.
3043         * p-exp.y: Update rules.
3044         (yylex): Update.
3045         * language.h (struct language_defn) <la_post_parser>: Add
3046         "completing" parameter.
3047         * go-exp.y: Update rules.
3048         (lex_one_token): Update.
3049         * expression.h (parse_completion): Don't declare.
3050         * d-exp.y: Update rules.
3051         (lex_one_token): Update rules.
3052         * c-exp.y: Update rules.
3053         (lex_one_token): Update.
3054         * ada-lang.c (resolve): Add "parse_completion" parameter.
3055         (resolve_subexp): Likewise.
3056         (ada_resolve_function): Likewise.
3057
3058 2019-04-04  Tom Tromey  <tom@tromey.com>
3059
3060         * parser-defs.h (struct parser_state) <start_arglist,
3061         end_arglist>: New methods.
3062         <arglist_len, m_funcall_chain>: New members.
3063         (arglist_len, start_arglist, end_arglist): Don't declare.
3064         * parse.c (arglist_len, funcall_chain): Remove global.
3065         (start_arglist, end_arglist): Remove functions.
3066         (parse_exp_in_context): Update.
3067         * p-exp.y: Update rules.
3068         * m2-exp.y: Update rules.
3069         * go-exp.y: Update rules.
3070         * f-exp.y: Update rules.
3071         * d-exp.y: Update rules.
3072         * c-exp.y: Update rules.
3073
3074 2019-04-04  Tom Tromey  <tom@tromey.com>
3075
3076         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3077         lex_operator, push_back>: New methods.
3078         Update all rules.
3079         (rust_parser::lex_hex, lex_escape): Rename and update.
3080         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3081         (rust_parser::lex_operator): Rename and update.
3082         (rust_parser::lex_number, rustyylex, rustyyerror)
3083         (rust_lex_test_init, rust_lex_test_sequence)
3084         (rust_lex_test_push_back, rust_lex_tests): Update.
3085         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3086         parameter.
3087         <lexptr, prev_lexptr>: New members.
3088         (lexptr, prev_lexptr): Don't declare.
3089         * parse.c (lexptr, prev_lexptr): Remove globals.
3090         (parse_exp_in_context): Update.
3091         * p-exp.y (yylex, yyerror): Update.
3092         * m2-exp.y (parse_number, yylex, yyerror): Update.
3093         * go-exp.y (lex_one_token, yyerror): Update.
3094         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3095         * d-exp.y (lex_one_token, yyerror): Update.
3096         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3097         (lex_one_token, yyerror): Update.
3098         * ada-lex.l (YY_INPUT): Update.
3099         (rewind_to_char): Update.
3100         * ada-exp.y (yyerror): Update.
3101
3102 2019-04-04  Tom Tromey  <tom@tromey.com>
3103
3104         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3105         * parser-defs.h (struct parser_state) <parser_state>: Add new
3106         parameter.
3107         <comma_terminates>: New member.
3108         (comma_terminates): Don't declare global.
3109         * parse.c (comma_terminates): Remove global.
3110         (parse_exp_in_context): Update.
3111         * p-exp.y (yylex): Update.
3112         * m2-exp.y (yylex): Update.
3113         * go-exp.y (lex_one_token): Update.
3114         * f-exp.y (yylex): Update.
3115         * d-exp.y (lex_one_token): Update.
3116         * c-exp.y (lex_one_token): Update.
3117         * ada-lex.l: Update.
3118
3119 2019-04-04  Tom Tromey  <tom@tromey.com>
3120
3121         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3122         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3123         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3124         * parser-defs.h (paren_depth): Don't declare.
3125         * parse.c (paren_depth): Remove global.
3126         (parse_exp_in_context): Update.
3127         * p-exp.y (paren_depth): New global.
3128         (pascal_parse): Initialize it.
3129         * m2-exp.y (paren_depth): New global.
3130         (m2_parse): Initialize it.
3131         * go-exp.y (paren_depth): New global.
3132         (go_parse): Initialize it.
3133         * f-exp.y (paren_depth): New global.
3134         (f_parse): Initialize it.
3135         * d-exp.y (paren_depth): New global.
3136         (d_parse): Initialize it.
3137         * c-exp.y (paren_depth): New global.
3138         (c_parse): Initialize it.
3139         * ada-lex.l (paren_depth): New global.
3140         (lexer_init): Initialize it.
3141
3142 2019-04-04  Tom Tromey  <tom@tromey.com>
3143
3144         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3145         (rust_parser::convert_ast_to_type)
3146         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3147         * parser-defs.h (struct parser_state) <parser_state>: Add
3148         parameters.  Initialize new members.
3149         <expression_context_block, expression_context_pc>: New members.
3150         * parse.c (expression_context_block, expression_context_pc):
3151         Remove globals.
3152         (parse_exp_in_context): Update.
3153         * p-exp.y: Update all rules.
3154         (yylex): Update.
3155         * m2-exp.y: Update all rules.
3156         (yylex): Update.
3157         * go-exp.y (yylex): Update.
3158         * f-exp.y (yylex): Update.
3159         * d-exp.y: Update all rules.
3160         (yylex): Update.
3161         * c-exp.y: Update all rules.
3162         (lex_one_token, classify_name, yylex, c_parse): Update.
3163         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3164
3165 2019-04-04  Tom Tromey  <tom@tromey.com>
3166
3167         * gdbarch.h, gdbarch.c: Rebuild.
3168         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3169         * stap-probe.h:
3170         (struct stap_parse_info): Replace "parser_state" with
3171         "expr_builder".
3172         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3173         (parser_state): New class.
3174         * parse.c (expr_builder): Rename.
3175         (expr_builder::release): Rename.
3176         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3177         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3178         (write_exp_elt_longcst, write_exp_elt_floatcst)
3179         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3180         (write_exp_string_vector, write_exp_bitstring)
3181         (write_exp_msymbol, mark_struct_expression)
3182         (write_dollar_variable)
3183         (insert_type_address_space, increase_expout_size): Replace
3184         "parser_state" with "expr_builder".
3185         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3186         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3187         "parser_state" with "expr_builder".
3188
3189 2019-04-04  Tom Tromey  <tom@tromey.com>
3190
3191         * rust-exp.y: Replace "parse_language" with method call.
3192         * p-exp.y:
3193         (yylex): Replace "parse_language" with method call.
3194         * m2-exp.y:
3195         (yylex): Replace "parse_language" with method call.
3196         * go-exp.y (classify_name): Replace "parse_language" with method
3197         call.
3198         * f-exp.y (yylex): Replace "parse_language" with method call.
3199         * d-exp.y (lex_one_token): Replace "parse_language" with method
3200         call.
3201         * c-exp.y:
3202         (lex_one_token, classify_name, yylex): Replace "parse_language"
3203         with method call.
3204         * ada-exp.y (find_primitive_type, type_char)
3205         (type_system_address): Replace "parse_language" with method call.
3206
3207 2019-04-04  Tom Tromey  <tom@tromey.com>
3208
3209         * rust-exp.y: Replace "parse_gdbarch" with method call.
3210         * parse.c (write_dollar_variable, insert_type_address_space):
3211         Replace "parse_gdbarch" with method call.
3212         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3213         call.
3214         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3215         call.
3216         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3217         "parse_gdbarch" with method call.
3218         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3219         with method call.
3220         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3221         "parse_gdbarch" with method call.
3222         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3223         "parse_gdbarch" with method call.
3224         * c-exp.y (parse_type, parse_number, classify_name): Replace
3225         "parse_gdbarch" with method call.
3226         * ada-lex.l: Replace "parse_gdbarch" with method call.
3227         * ada-exp.y (parse_type, find_primitive_type, type_char)
3228         (type_system_address): Replace "parse_gdbarch" with method call.
3229
3230 2019-04-04  Tom Tromey  <tom@tromey.com>
3231
3232         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3233         * stap-probe.c (stap_parse_argument): Update.
3234         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3235         initial_size parameter.
3236         * rust-exp.y (rust_lex_tests): Update.
3237         * parse.c (parser_state): Update.
3238         (parse_exp_in_context): Update.
3239         * parser-defs.h (struct parser_state) <parser_state>: Remove
3240         "initial_size" parameter.
3241
3242 2019-04-04  Tom Tromey  <tom@tromey.com>
3243
3244         * parser-defs.h (increase_expout_size): Don't declare.
3245         * parse.c (increase_expout_size): Now static.
3246
3247 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3248
3249         * gnu-nat.c (gnu_nat_target::wait): Fix
3250         target_waitstatus_to_string call.
3251
3252 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3253
3254         * eval.c (evaluate_subexp_standard): Handle internal functions
3255         during Fortran function call handling.
3256
3257 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3258
3259         * NEWS: Mention new internal functions.
3260         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3261         (read_base_type): Use dwarf2_init_complex_target_type.
3262         * value.c (creal_internal_fn): New function.
3263         (cimag_internal_fn): New function.
3264         (_initialize_values): Register new internal functions.
3265
3266 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3267
3268         * infrun.c (stop_all_threads): If debug_infrun, always
3269         trace the wait status after wait_one, using
3270         target_waitstatus_to_string and target_pid_to_str.
3271         (handle_inferior_event): Replace various trace of
3272         wait status kind by a single trace.
3273         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3274         wait status kind image by target_waitstatus_to_string.
3275         * target/waitstatus.c (target_waitstatus_to_string): Fix
3276         obsolete comment.
3277
3278 2019-04-01  Tom Tromey  <tromey@adacore.com>
3279
3280         PR symtab/23331:
3281         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3282
3283 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3284             Pedro Alves  <palves@redhat.com>
3285
3286         * top.c (quit_force): Call 'finalize_values'.
3287         * value.c (finalize_values): New function.
3288         * value.h (finalize_values): Declare.
3289
3290 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3291
3292         * NEWS: Announce $_gdb_major and $_gdb_minor.
3293
3294         * top.c (init_gdb_version_vars): New function.
3295         (gdb_init): Call init_gdb_version_vars.
3296
3297 2019-03-29  Tom Tromey  <tromey@adacore.com>
3298
3299         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3300         help text.  Remove dead code.
3301
3302 2019-03-29  Keith Seitz  <keiths@redhat.com>
3303
3304         From Siddhesh Poyarekar:
3305         * f-lang.h (f77_get_upperbound): Return LONGEST.
3306         (f77_get_lowerbound): Likewise.
3307         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3308         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3309         print them.
3310         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3311         plongest to format print it.
3312         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3313         (f77_get_upperbound): Likewise.
3314         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3315         LOWER_BOUND to LONGEST.
3316         (f77_create_arrayprint_offset_tbl): Likewise.
3317
3318 2019-03-29  Keith Seitz  <keiths@redhat.com>
3319
3320         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3321         %s/pulongest for TYPE_LENGTH instead of %d in format
3322         strings.
3323         * ada-typerint.c (ada_print_type): Likewise.
3324         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3325         * compile/compile-c-support.c (generate_register_struct): Likewise.
3326         * gdbtypes.c (recursive_dump_type): Likewise.
3327         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3328         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3329         instead of %d in format strings.
3330         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3331         to std::min to ULONGEST.
3332         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3333         instead of %d in format strings.
3334         * tracepoint.c (info_scope_command): Likewise.
3335         * typeprint.c (print_offset_data::update)
3336         (print_offset_data::finish): Likewise.
3337         * xtensa-tdep.c (xtensa_store_return_value)
3338         (xtensa_push_dummy_call): Likewise.
3339
3340 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3341
3342         * windows-nat.c (display_selector): Fixed format specifications
3343         for 64-bit Cygwin.
3344
3345 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3346
3347         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3348
3349 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3350
3351         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3352         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3353         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3354         (nios2_linux_init_abi): Install it.
3355
3356 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3357
3358         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3359
3360 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3361
3362         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3363
3364 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3365             Tom Tromey  <tromey@adacore.com>
3366
3367         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3368
3369 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3370
3371         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3372         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3373         method to compute the bounds of range types. Also print "[evaluated]"
3374         if the bounds' values come from a dynamic evaluation.
3375
3376 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3377
3378         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3379         whitespace when pretty printing is on.
3380
3381 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3382
3383         * ppc-linux-nat.c: Add include.
3384
3385 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3386
3387         * NEWS: Mention AArch64 Pointer Authentication.
3388
3389 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3390
3391         * arm-linux-nat.c: Add include.
3392
3393 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3394
3395         * source-cache.c (source_cache::get_source_lines): Re-read
3396         fullname after calling open_source_file.
3397
3398 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3399
3400         * NEWS: Mention TLS support for FreeBSD.
3401
3402 2019-03-25  Tom Tromey  <tromey@adacore.com>
3403
3404         * minsyms.c (BUNCH_SIZE): Update comment.
3405         (~minimal_symbol_reader): Remove old comment.
3406         (compact_minimal_symbols): Update comment.
3407         (minimal_symbol_reader::install): Remove old comment.  Update
3408         other comments.
3409
3410 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3411
3412         * s390-linux-nat.c: Add include.
3413
3414 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3415
3416         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3417         Call linux_get_hwcap.
3418         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3419         Likewise.
3420         (aarch64_linux_get_hwcap): Remove function.
3421         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3422         declaration.
3423         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3424         linux_get_hwcap.
3425         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3426         * linux-tdep.c (linux_get_hwcap): Add function.
3427         (linux_get_hwcap2): Likewise.
3428         * linux-tdep.h (linux_get_hwcap): Add declaration.
3429         (linux_get_hwcap2): Likewise.
3430         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3431         (ppc_linux_get_hwcap2): Likewise.
3432         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3433         linux_get_hwcap.
3434         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3435         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3436         (ppc_linux_nat_target::read_description): Likewise.
3437         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3438         * s390-linux-nat.c: Likewise.
3439         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3440
3441 2019-03-24  Tom Tromey  <tom@tromey.com>
3442
3443         * ada-lang.c (standard_lookup): Simplify initialization.
3444         (ada_lookup_symbol_nonlocal): Simplify return.
3445         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3446         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3447         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3448         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3449         initialization.
3450         * solib.c (solib_global_lookup): Simplify.
3451         * symtab.c (null_block_symbol): Remove.
3452         (symbol_cache_lookup): Simplify returns.
3453         (lookup_language_this): Simplify returns.
3454         (lookup_symbol_aux): Simplify return.
3455         (lookup_local_symbol): Simplify returns.
3456         (lookup_global_symbol_from_objfile): Simplify return.
3457         (lookup_symbol_in_objfile_symtabs)
3458         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3459         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3460         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3461         * cp-namespace.c (cp_lookup_bare_symbol)
3462         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3463         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3464         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3465         (cp_lookup_symbol_via_imports): Simplify initialization.
3466         (find_symbol_in_baseclass): Likewise.
3467         * symtab.h (null_block_symbol): Remove.
3468         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3469         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3470         (d_lookup_symbol_module): Likewise.
3471         (find_symbol_in_baseclass): Simplify initialization.
3472
3473 2019-03-24  Tom Tromey  <tom@tromey.com>
3474
3475         * expression.h: Don't include symtab.h.
3476         (struct block): Forward declare.
3477
3478 2019-03-24  Tom Tromey  <tom@tromey.com>
3479
3480         * c-exp.y (typebase): Remove casts.
3481         * gdbtypes.c (lookup_unsigned_typename, )
3482         (lookup_signed_typename): Remove cast.
3483         * eval.c (parse_to_comma_and_eval): Remove cast.
3484         * parse.c (write_dollar_variable): Remove cast.
3485         * block.h (struct block) <superblock>: Now const.
3486         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3487         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3488         (map_block): Make "block" const.
3489         * symfile.h (struct quick_symbol_functions)
3490         <map_matching_symbols>: Constify block argument to "callback".
3491         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3492         const.
3493         (find_pc_sect_compunit_symtab): Make "b" const.
3494         (find_symbol_at_address): Likewise.
3495         (search_symbols): Likewise.
3496         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3497         (dw2_debug_names_lookup_symbol): Likewise.
3498         (dw2_map_matching_symbols): Update.
3499         * p-valprint.c (pascal_val_print): Remove "block".
3500         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3501         (aux_add_nonlocal_symbols): Make "block" const.
3502         (resolve_subexp): Remove cast.
3503         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3504         const.
3505         (iterate_over_file_blocks): Likewise.
3506         * f-exp.y (%union) <bval>: Remove.
3507         * coffread.c (patch_opaque_types): Make "b" const.
3508         * spu-tdep.c (spu_catch_start): Make "block" const.
3509         * c-valprint.c (print_unpacked_pointer): Remove "block".
3510         * symmisc.c (dump_symtab_1): Make "b" const.
3511         (block_depth): Make "block" const.
3512         * d-exp.y (%union) <bval>: Remove.
3513         * cp-support.h (cp_lookup_rtti_type): Update.
3514         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3515         * psymtab.c (psym_lookup_symbol): Make "block" const.
3516         (maintenance_check_psymtabs): Make "b" const.
3517         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3518         (enumerate_locals, enumerate_args): Update.
3519         * python/py-symtab.c (stpy_global_block): Make "block" const.
3520         (stpy_static_block): Likewise.
3521         * inline-frame.c (block_starting_point_at): Make "new_block"
3522         const.
3523         * block.c (find_block_in_blockvector): Make return type const.
3524         (blockvector_for_pc_sect): Make "b" const.
3525         (find_block_in_blockvector): Make "b" const.
3526
3527 2019-03-23  Tom Tromey  <tom@tromey.com>
3528
3529         * varobj.c (varobj_create): Update.
3530         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3531         * printcmd.c (display_command, do_one_display): Don't reset
3532         innermost_block.
3533         * parser-defs.h (enum innermost_block_tracker_type): Move to
3534         expression.h.
3535         (innermost_block): Update comment.
3536         * parse.c (parse_exp_1): Add tracker_types parameter.
3537         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3538         tracker_types parameter.  Reset innermost_block.
3539         (parse_exp_in_context): Remove.
3540         (parse_expression_for_completion): Update.
3541         * objfiles.c (~objfile): Don't reset expression_context_block or
3542         innermost_block.
3543         * expression.h (enum innermost_block_tracker_type): Move from
3544         parser-defs.h.
3545         (parse_exp_1): Add tracker_types parameter.
3546         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3547         reset innermost_block.
3548
3549 2019-03-23  Tom Tromey  <tom@tromey.com>
3550
3551         * objfiles.h: Include bcache.h.
3552
3553 2019-03-23  Tom Tromey  <tom@tromey.com>
3554
3555         * linespec.c (get_current_search_block): Use
3556         scoped_restore_current_language.
3557         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3558
3559 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3560             Jiong Wang  <jiong.wang@arm.com>
3561
3562         * aarch64-linux-tdep.c
3563         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3564         section.
3565         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3566
3567 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3568             Jiong Wang  <jiong.wang@arm.com>
3569
3570         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3571         instructions.
3572         (aarch64_analyze_prologue_test): Add PACIASP test.
3573         (aarch64_prologue_prev_register): Unmask PC value.
3574
3575 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3576             Jiong Wang  <jiong.wang@arm.com>
3577
3578         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3579         (aarch64_dwarf2_prev_register): Unmask PC value.
3580         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3581         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3582         DW_CFA_AARCH64_negate_ra_state.
3583         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3584
3585 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3586             Jiong Wang  <jiong.wang@arm.com>
3587
3588         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3589         registers.
3590         (aarch64_pseudo_register_name): Likewise.
3591         (aarch64_pseudo_register_type): Likewise.
3592         (aarch64_pseudo_register_reggroup_p): Likewise.
3593         (aarch64_gdbarch_init): Add pauth registers.
3594         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3595         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3596         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3597         (struct gdbarch_tdep): Add regnum for ra_state.
3598
3599 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3600             Jiong Wang  <jiong.wang@arm.com>
3601
3602         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3603
3604 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3605             Jiong Wang  <jiong.wang@arm.com>
3606
3607         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3608         function.
3609         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3610         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3611         (aarch64_gdbarch_init): Add puth registers.
3612         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3613         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3614         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3615
3616 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3617             Jiong Wang  <jiong.wang@arm.com>
3618
3619         * aarch64-linux-nat.c
3620         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3621         * aarch64-linux-tdep.c
3622         (aarch64_linux_core_read_description): Likewise.
3623         (aarch64_linux_get_hwcap): New function.
3624         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3625         (aarch64_linux_get_hwcap): New declaration.
3626
3627 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3628             Jiong Wang  <jiong.wang@arm.com>
3629
3630         * aarch64-linux-nat.c
3631         (aarch64_linux_nat_target::read_description): Add pauth param.
3632         * aarch64-linux-tdep.c
3633         (aarch64_linux_core_read_description): Likewise.
3634         * aarch64-tdep.c (struct target_desc): Add in pauth.
3635         (aarch64_read_description): Add pauth param.
3636         (aarch64_gdbarch_init): Likewise.
3637         * aarch64-tdep.h (aarch64_read_description): Likewise.
3638         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3639         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3640         * features/Makefile: Add new files.
3641         * features/aarch64-pauth.c: New file.
3642         * features/aarch64-pauth.xml: New file.
3643
3644 2019-03-20  Tom Tromey  <tromey@adacore.com>
3645
3646         * infrun.c (handle_inferior_event): Rename from
3647         handle_inferior_event_1.  Create a scoped_value_mark.
3648         (handle_inferior_event): Remove.
3649
3650 2019-03-19  Tom Tromey  <tromey@adacore.com>
3651
3652         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3653         * infrun.h (print_stop_event): Add "displays" parameter.
3654         * infrun.c (print_stop_event): Add "displays" parameter.
3655
3656 2019-03-19  Pedro Alves  <palves@redhat.com>
3657
3658         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3659         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3660         to -1.  Fix TABs vs spaces.
3661         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3662         * tui/tui-out.h (tui_ui_out) Add intro comments.
3663         <m_line, m_start_of_line>: In-class initialize, and add describing
3664         comment.
3665
3666 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3667
3668         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3669         variable names.
3670         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3671
3672 2019-03-18  Pedro Alves  <palves@redhat.com>
3673             Eli Zaretskii <eliz@gnu.org>
3674
3675         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3676         m_line and m_start_of_line.
3677
3678 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3679
3680         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3681         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3682         it returns a newline.  This fixes a regression in TU mode, whereby
3683         the next line is output on the same screen line as the user input.
3684
3685 2019-03-18  Tom Tromey  <tromey@adacore.com>
3686
3687         * minsyms.c (minimal_symbol_reader::install): Remove call to
3688         obstack_blank.
3689
3690 2019-03-18  Pedro Alves  <palves@redhat.com>
3691
3692         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3693         New globals.
3694         (apply_style): New, factored out from ...
3695         (apply_ansi_escape): ... this.  Handle reverse video mode.
3696         (tui_set_reverse_mode): New function.
3697         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3698         * tui/tui-winsource.c (tui_show_source_line): Use
3699         tui_set_reverse_mode instead of setting A_STANDOUT.
3700         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3701         New setter methods.
3702
3703 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3704
3705         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3706         Handle tabs.
3707
3708 2019-03-18  Tom Tromey  <tromey@adacore.com>
3709
3710         * ada-lang.c (empty_array): Add "high" parameter.
3711         (ada_evaluate_subexp): Update.
3712
3713 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3714
3715         * unittests/string_view-selftests.c: Define
3716         _initialize_string_view_selftests unconditionally.
3717
3718 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3719
3720         PR gdb/24350
3721         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3722
3723 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3724
3725         PR gdb/24351
3726         * windows-nat.c (display_selector): Fix format specifiers.
3727
3728 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3729
3730         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3731         tui_refill_source_window instead of tui_refresh_win, to update the
3732         current execution line.  This fixes redisplay of the current line
3733         when stepping through the code with "next" or "step".
3734
3735 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3736
3737         * source-cache.c (source_cache::get_source_lines): Call
3738         find_source_lines to initialize s->nlines.  This fixes vertical
3739         scrolling of TUI source window when the DOWN arrow is pressed.
3740
3741 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3742
3743         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3744         linux-thread-db.c (_initialize_thread_db): Likewise.
3745
3746 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3747
3748         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3749         wclrtoeol in tui_show_source_line".  This reverts changes made in
3750         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3751
3752 2019-03-15  Tom Tromey  <tom@tromey.com>
3753
3754         * symtab.h (struct minimal_symbol): Derive from
3755         general_symbol_info.
3756         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3757         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3758         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3759         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3760         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3761         (MSYMBOL_SEARCH_NAME): Update.
3762         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3763         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3764         * minsyms.c (minimal_symbol_reader::record_full): Update.
3765
3766 2019-03-15  Tom Tromey  <tom@tromey.com>
3767
3768         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3769
3770 2019-03-15  Tom Tromey  <tom@tromey.com>
3771
3772         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3773         unique_xmalloc_ptr.
3774         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3775         Update.
3776         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3777         (build_minimal_symbol_hash_tables)
3778         (minimal_symbol_reader::install): Update.
3779
3780 2019-03-15  Tom Tromey  <tom@tromey.com>
3781
3782         * symtab.c (create_demangled_names_hash): Update.
3783         (symbol_set_names): Update.
3784         * objfiles.h (struct objfile_per_bfd_storage)
3785         <demangled_names_hash>: Now an htab_up.
3786         * objfiles.c (objfile_per_bfd_storage): Simplify.
3787
3788 2019-03-15  Tom Tromey  <tom@tromey.com>
3789
3790         * objfiles.h (struct objfile_per_bfd_storage): Declare
3791         destructor.
3792         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3793         New.
3794         (get_objfile_bfd_data): Use new.  Don't initialize
3795         language_of_main.
3796         (free_objfile_per_bfd_storage): Remove.
3797         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3798
3799 2019-03-15  Tom Tromey  <tom@tromey.com>
3800
3801         * symfile.c (reread_symbols): Update.
3802         * objfiles.c (objfile::objfile): Update.
3803         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3804         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3805         comment.
3806         (minimal_symbol_reader::install): Update.
3807         (terminate_minimal_symbol_table): Remove.
3808         * jit.c (jit_object_close_impl): Update.
3809
3810 2019-03-15  Tom Tromey  <tom@tromey.com>
3811
3812         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3813         initializations.
3814
3815 2019-03-15  Tom Tromey  <tom@tromey.com>
3816
3817         * objfiles.h (struct objfile_per_bfd_storage)
3818         <demangled_hash_languages>: Now a bitset.
3819         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3820         (lookup_minimal_symbol): Update.
3821
3822 2019-03-15  Tom Tromey  <tom@tromey.com>
3823
3824         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3825         Don't return the symbol.
3826         * coffread.c (record_minimal_symbol): Use record_full.
3827
3828 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3829
3830         The MS-Windows port of ncurses fails to switch to a color pair if
3831         one or both of the colors are the implicit default colors.  This
3832         change records the default colors when TUI is initialized, and
3833         then specifies them explicitly when a color pair uses the default
3834         colors.  This allows color styling in TUI mode on MS-Windows.
3835
3836         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3837         ncurses_norm_attr.
3838         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3839         colors in ncurses_norm_attr.
3840         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3841         "none", replace it with the default color recorded in
3842         ncurses_norm_attr.
3843
3844 2019-03-14  Tom Tromey  <tromey@adacore.com>
3845
3846         * source-cache.h (class source_cache) <get_source_lines>: Return
3847         std::string.
3848         * source-cache.c (source_cache::extract_lines): Handle case where
3849         first_pos==npos.  Return std::string.
3850         (source_cache::get_source_lines): Update.
3851
3852 2019-03-14  Tom Tromey  <tromey@adacore.com>
3853
3854         * NEWS: Add item for "style sources" commands.
3855         * source-cache.c (source_cache::get_source_lines): Check
3856         source_styling.
3857         * cli/cli-style.c (source_styling): New global.
3858         (_initialize_cli_style): Add "style sources" commands.
3859         (show_style_sources): New function.
3860         * cli/cli-style.h (source_styling): Declare.
3861
3862 2019-03-14  Pedro Alves  <palves@redhat.com>
3863             Tom Tromey  <tromey@adacore.com>
3864
3865         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3866         * tui/tui-winsource.c (tui_refill_source_window): New function,
3867         from...
3868         (tui_horizontal_source_scroll): ... here.  Move some logic.
3869         * cli/cli-style.c (set_style_enabled): Notify new observable.
3870         * tui/tui-hooks.c (tui_redisplay_source): New function.
3871         (tui_attach_detach_observers): Attach or detach
3872         tui_redisplay_source.
3873         * observable.h (source_styling_changed): New observable.
3874         * observable.c: Define source_styling_changed observable.
3875
3876 2019-03-13  Tom Tromey  <tromey@adacore.com>
3877
3878         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
3879         (i386_gnu_nat_target::store_registers): Update.
3880         * target-debug.h (target_debug_print_std_string): New macro.
3881         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3882         * windows-tdep.c (display_one_tib): Update.
3883         * tui/tui-stack.c (tui_make_status_line): Update.
3884         * top.c (print_inferior_quit_action): Update.
3885         * thread.c (thr_try_catch_cmd): Update.
3886         (add_thread_with_info): Update.
3887         (thread_target_id_str): Update.
3888         (thr_try_catch_cmd): Update.
3889         (thread_command): Update.
3890         (thread_find_command): Update.
3891         * record-btrace.c (record_btrace_target::info_record)
3892         (record_btrace_resume_thread, record_btrace_target::resume)
3893         (record_btrace_cancel_resume, record_btrace_step_thread)
3894         (record_btrace_target::wait, record_btrace_target::wait)
3895         (record_btrace_target::wait, record_btrace_target::stop): Update.
3896         * progspace.c (print_program_space): Update.
3897         * process-stratum-target.c
3898         (process_stratum_target::thread_address_space): Update.
3899         * linux-fork.c (linux_fork_mourn_inferior)
3900         (detach_checkpoint_command, info_checkpoints_command)
3901         (linux_fork_context): Update.
3902         (linux_fork_detach): Update.
3903         (class scoped_switch_fork_info): Update.
3904         (delete_checkpoint_command): Update.
3905         * infrun.c (follow_fork_inferior): Update.
3906         (follow_fork_inferior): Update.
3907         (proceed_after_vfork_done): Update.
3908         (handle_vfork_child_exec_or_exit): Update.
3909         (follow_exec): Update.
3910         (displaced_step_prepare_throw): Update.
3911         (displaced_step_restore): Update.
3912         (start_step_over): Update.
3913         (resume_1): Update.
3914         (clear_proceed_status_thread): Update.
3915         (proceed): Update.
3916         (print_target_wait_results): Update.
3917         (do_target_wait): Update.
3918         (context_switch): Update.
3919         (stop_all_threads): Update.
3920         (restart_threads): Update.
3921         (finish_step_over): Update.
3922         (handle_signal_stop): Update.
3923         (switch_back_to_stepped_thread): Update.
3924         (keep_going_pass_signal): Update.
3925         (print_exited_reason): Update.
3926         (normal_stop): Update.
3927         * inferior.c (inferior_pid_to_str): Change return type.
3928         (print_selected_inferior): Update.
3929         (add_inferior): Update.
3930         (detach_inferior): Update.
3931         * dummy-frame.c (fprint_dummy_frames): Update.
3932         * dcache.c (dcache_info_1): Update.
3933         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
3934         (btrace_fetch, btrace_clear): Update.
3935         * linux-tdep.c (linux_core_pid_to_str): Change return type.
3936         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
3937         type.
3938         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
3939         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
3940         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
3941         * gdbarch.c, gdbarch.h: Rebuild.
3942         * gdbarch.sh (core_pid_to_str): Change return type.
3943         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
3944         return type.
3945         (windows_nat_target::pid_to_str): Change return type.
3946         (windows_delete_thread): Update.
3947         (windows_nat_target::attach): Update.
3948         (windows_nat_target::files_info): Update.
3949         * target-delegates.c: Rebuild.
3950         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
3951         return type.
3952         (sol_thread_target::pid_to_str): Change return type.
3953         * remote.c (class remote_target) <pid_to_str>: Change return
3954         type.
3955         (remote_target::pid_to_str): Change return type.
3956         (extended_remote_target::attach, remote_target::remote_stop_ns)
3957         (remote_target::remote_notif_remove_queued_reply)
3958         (remote_target::push_stop_reply, remote_target::disable_btrace):
3959         Update.
3960         (extended_remote_target::attach): Update.
3961         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
3962         type.
3963         (gdbsim_target::pid_to_str): Change return type.
3964         * ravenscar-thread.c (struct ravenscar_thread_target)
3965         <pid_to_str>: Change return type.
3966         (ravenscar_thread_target::pid_to_str): Change return type.
3967         * procfs.c (class procfs_target) <pid_to_str>: Change return
3968         type.
3969         (procfs_target::pid_to_str): Change return type.
3970         (procfs_target::attach): Update.
3971         (procfs_target::detach): Update.
3972         (procfs_target::fetch_registers): Update.
3973         (procfs_target::store_registers): Update.
3974         (procfs_target::wait): Update.
3975         (procfs_target::files_info): Update.
3976         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
3977         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
3978         return type.
3979         (nto_procfs_target::pid_to_str): Change return type.
3980         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
3981         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
3982         return type.
3983         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
3984         (exit_lwp): Update.
3985         (attach_proc_task_lwp_callback, get_detach_signal)
3986         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
3987         (linux_nat_target::resume, wait_lwp, stop_callback)
3988         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
3989         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
3990         (linux_nat_wait_1, resume_stopped_resumed_lwps)
3991         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
3992         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
3993         type.
3994         (inf_ptrace_target::attach): Update.
3995         (inf_ptrace_target::files_info): Update.
3996         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
3997         type.
3998         (go32_nat_target::pid_to_str): Change return type.
3999         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4000         (gnu_nat_target::wait): Update.
4001         (gnu_nat_target::wait): Update.
4002         (gnu_nat_target::resume): Update.
4003         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4004         (fbsd_nat_target::wait): Update.
4005         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4006         type.
4007         (darwin_nat_target::attach): Update.
4008         * corelow.c (class core_target) <pid_to_str>: Change return type.
4009         (core_target::pid_to_str): Change return type.
4010         * target.c (normal_pid_to_str): Change return type.
4011         (default_pid_to_str): Likewise.
4012         (target_pid_to_str): Change return type.
4013         (target_translate_tls_address): Update.
4014         (target_announce_detach): Update.
4015         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4016         return type.
4017         (bsd_uthread_target::pid_to_str): Change return type.
4018         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4019         type.
4020         (bsd_kvm_target::pid_to_str): Change return type.
4021         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4022         return type.
4023         (aix_thread_target::pid_to_str): Change return type.
4024         * target.h (struct target_ops) <pid_to_str>: Change return type.
4025         (target_pid_to_str, normal_pid_to_str): Likewise.
4026         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4027         type.
4028         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4029         type.
4030         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4031         return type.
4032         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4033         type.
4034         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4035         type.
4036         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4037         return type.
4038
4039 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4040
4041         * NEWS: Mention that the new default MI version is 3.  Mention
4042         changes to the output of commands and events that deal with
4043         multi-location breakpoints.
4044         * breakpoint.c: Include "mi/mi-out.h".
4045         (print_one_breakpoint): Change output syntax if using MI version
4046         >= 3.
4047         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4048         New.
4049         (mi_multi_location_breakpoint_output_fixed): New.
4050         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4051         (mi_cmd_fix_multi_location_breakpoint_output): New.
4052         (mi_multi_location_breakpoint_output_fixed): New.
4053         * mi/mi-cmds.c (mi_cmds): Register command
4054         -fix-multi-location-breakpoint-output.
4055         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4056         interpreter "mi".
4057
4058 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4059
4060         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4061         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4062         instantiate mi_ui_out based on interpreter name.
4063         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4064         * mi/mi-main.c (mi_load_progress): Likewise.
4065
4066 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4067
4068         * NEWS: Combine separate "New targets" sections for 8.3.
4069
4070 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4071
4072         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4073         (ppcfbsd_init_abi): Install gdbarch
4074         "fetch_tls_load_module_address" and "get_thread_local_address"
4075         methods.
4076
4077 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4078
4079         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4080         (riscv_fbsd_init_abi): Install gdbarch
4081         "fetch_tls_load_module_address" and "get_thread_local_address"
4082         methods.
4083
4084 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4085
4086         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4087         (i386fbsd_init_abi): Install gdbarch
4088         "fetch_tls_load_module_address" and "get_thread_local_address"
4089         methods.
4090
4091 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4092
4093         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4094         (amd64fbsd_init_abi): Install gdbarch
4095         "fetch_tls_load_module_address" and "get_thread_local_address"
4096         methods.
4097
4098 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4099
4100         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4101         (struct fbsd_pspace_data): New type.
4102         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4103         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4104         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4105         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4106         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4107
4108 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4109
4110         * gdbtypes.c (lookup_struct_elt): New function.
4111         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4112         * gdbtypes.h (struct struct_elt): New type.
4113         (lookup_struct_elt): New prototype.
4114
4115 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4116
4117         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4118         remove disabled code block.
4119
4120 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4121
4122         * gdbarch.sh (get_thread_local_address): New method.
4123         * gdbarch.h, gdbarch.c: Regenerate.
4124         * target.c (target_translate_tls_address): Use
4125         gdbarch_get_thread_local_address if present instead of
4126         target::get_thread_local_address.
4127
4128 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4129
4130         * target.h (target::get_thread_local_address): Update comment.
4131
4132 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4133
4134         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4135         objfile->separate_debug_objfile_backlink if not NULL.
4136
4137 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4138
4139         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4140         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4141         (amd64bsd_store_inferior_registers): Likewise.
4142         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4143         Enable segment base registers.
4144         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4145         PT_GETFSBASE and PT_GETGSBASE.
4146         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4147         PT_SETGSBASE.
4148         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4149         segment base registers.
4150         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4151
4152 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4153
4154         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4155         Update calls to i386_target_description to add 'segments'
4156         parameter.
4157         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4158         add segment base registers.
4159         * arch/i386.c (i386_create_target_description): Add 'segments'
4160         parameter to enable segment base registers.
4161         * arch/i386.h (i386_create_target_description): Likewise.
4162         * features/i386/32bit-segments.xml: New file.
4163         * features/i386/32bit-segments.c: Generate.
4164         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4165         call to i386_target_description to add 'segments' parameter.
4166         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4167         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4168         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4169         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4170         if feature is present.
4171         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4172         Add 'segments' parameter to call to i386_target_description.
4173         (i386_target_description): Add 'segments' parameter to enable
4174         segment base registers.
4175         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4176         to call to i386_target_description.
4177         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4178         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4179         Define I386_NUM_REGS.
4180         (i386_target_description): Add 'segments' parameter to enable
4181         segment base registers.
4182
4183 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4184
4185         PR/24325
4186         * source-cache.c: #undef open and close, to avoid unresolved
4187         externals during linking.
4188
4189 2019-03-12  Tom Tromey  <tromey@adacore.com>
4190
4191         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4192         const.  Add initializers.
4193         (_initialize_remote): Don't initialize ptid globals.
4194
4195 2019-03-12  Pedro Alves  <palves@redhat.com>
4196
4197         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4198
4199 2019-03-12  Pedro Alves  <palves@redhat.com>
4200
4201         * cp-name-parser.y (main): Remove unused 'len' variable.
4202
4203 2019-03-12  Tom Tromey  <tromey@adacore.com>
4204
4205         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4206         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4207
4208 2019-03-12  Tom Tromey  <tromey@adacore.com>
4209
4210         * linux-nat.c (iterate_over_lwps): Update.
4211         (stop_callback): Remove parameter.
4212         (stop_wait_callback, detach_callback, resume_set_callback)
4213         (select_singlestep_lwp_callback, set_ignore_sigint)
4214         (status_callback, resumed_callback, resume_clear_callback)
4215         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4216         data parameter.
4217         (linux_nat_target::detach, linux_nat_target::resume)
4218         (linux_stop_and_wait_all_lwps, select_event_lwp)
4219         (linux_nat_filter_event, linux_nat_wait_1)
4220         (linux_nat_target::kill, linux_nat_target::stop)
4221         (linux_nat_target::stop): Update.
4222         (linux_nat_resume_callback): Change type.
4223         (resume_stopped_resumed_lwps, count_events_callback)
4224         (select_event_lwp_callback): Likewise.
4225         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4226         * arm-linux-nat.c (struct update_registers_data): Remove.
4227         (update_registers_callback): Change type.
4228         (arm_linux_insert_hw_breakpoint1): Update.
4229         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4230         parameter.
4231         (x86_linux_dr_set_addr): Update.
4232         (x86_linux_dr_set_control): Update.
4233         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4234         (iterate_over_lwps): Use gdb::function_view.
4235         * nat/aarch64-linux-hw-point.c (struct
4236         aarch64_dr_update_callback_param): Remove.
4237         (debug_reg_change_callback): Change type.
4238         (aarch64_notify_debug_reg_change): Update.
4239         * s390-linux-nat.c (s390_refresh_per_info): Update.
4240
4241 2019-03-11  Tom Tromey  <tromey@adacore.com>
4242
4243         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4244         redundant assignment to "this_cu".
4245
4246 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4247
4248         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4249
4250 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4251
4252         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4253         from...
4254         (rank_one_type): ... this.
4255
4256 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4257
4258         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4259         from...
4260         (rank_one_type): ... this.
4261
4262 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4263
4264         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4265         from...
4266         (rank_one_type): ... this.
4267
4268 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4269
4270         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4271         from...
4272         (rank_one_type): ... this.
4273
4274 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4275
4276         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4277         from...
4278         (rank_one_type): ... this.
4279
4280 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4281
4282         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4283         from...
4284         (rank_one_type): ... this.
4285
4286 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4287
4288         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4289         from...
4290         (rank_one_type): ... this.
4291
4292 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4293
4294         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4295         from...
4296         (rank_one_type): ... this.
4297
4298 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4299
4300         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4301         from...
4302         (rank_one_type): ... this.
4303
4304 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4305
4306         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4307         from...
4308         (rank_one_type): ... this.
4309
4310 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4311
4312         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4313         from...
4314         (rank_one_type): ... this.
4315
4316 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4317
4318         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4319         from...
4320         (rank_one_type): ... this.
4321
4322 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4323
4324         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4325         inferior-events' shows the example events.
4326
4327 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4328
4329         Support styling on native MS-Windows console
4330
4331         PR/24315
4332         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4333         on MS-Windows if $TERM is not defined.
4334
4335         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4336
4337         * posix-hdep.c (gdb_console_fputs):
4338         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4339         functions.
4340         * ui-file.h (gdb_console_fputs): Add prototype.
4341
4342         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4343         back to fputs only if the former returns zero.
4344
4345 2019-03-07  Tom Tromey  <tom@tromey.com>
4346
4347         * symmisc.c (print_symbol_bcache_statistics): Update.
4348         (print_objfile_statistics): Update.
4349         * symfile.c (allocate_symtab): Update.
4350         * stabsread.c: Don't include bcache.h.
4351         * psymtab.h (struct psymbol_bcache): Don't declare.
4352         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4353         (psymbol_bcache_init, psymbol_bcache_free)
4354         (psymbol_bcache_get_bcache): Don't declare.
4355         * psymtab.c (struct psymbol_bcache): Remove.
4356         (psymtab_storage::psymtab_storage): Update.
4357         (psymtab_storage::~psymtab_storage): Update.
4358         (psymbol_bcache_init, psymbol_bcache_free)
4359         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4360         (add_psymbol_to_bcache): Update.
4361         (allocate_psymtab): Update.
4362         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4363         macro_cache>: No longer pointers.
4364         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4365         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4366         * macrotab.c (macro_bcache): Update.
4367         * macroexp.c: Don't include bcache.h.
4368         * gdbtypes.c (check_types_worklist): Update.
4369         (types_deeply_equal): Remove TRY/CATCH.  Update.
4370         * elfread.c (elf_symtab_read): Update.
4371         * dwarf2read.c: Don't include bcache.h.
4372         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4373         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4374         (print_bcache_statistics, bcache_memory_used): Don't declare.
4375         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4376         methods.  Rename all data members.
4377         * bcache.c (struct bcache): Move to bcache.h.
4378         (bcache::expand_hash_table): Rename from expand_hash_table.
4379         (bcache): Remove.
4380         (bcache::insert): Rename from bcache_full.
4381         (bcache::compare): Rename from bcache_compare.
4382         (bcache_xmalloc): Remove.
4383         (bcache::~bcache): Rename from bcache_xfree.
4384         (bcache::print_statistics): Rename from print_bcache_statistics.
4385         (bcache::memory_used): Rename from bcache_memory_used.
4386
4387 2019-03-07  Pedro Alves  <palves@redhat.com>
4388
4389         * infrun.c (normal_stop): Also check for
4390         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4391
4392 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4393
4394         * f-lang.c (value_from_host_double): Moved to...
4395         * value.c (value_from_host_double): ...here.
4396         * value.h (value_from_host_double): Declare.
4397         * guile/scm-math.c (vlscm_convert_typed_number): Use
4398         value_from_host_double.
4399         (vlscm_convert_number): Likewise.
4400         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4401         * python/py-value.c (convert_value_from_python): Likewise.
4402
4403 2019-03-06  Tom Tromey  <tom@tromey.com>
4404
4405         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4406
4407 2019-03-06  Tom Tromey  <tom@tromey.com>
4408
4409         * utils.h (free_current_contents): Don't declare.
4410         * utils.c (free_current_contents): Remove.
4411
4412 2019-03-06  Tom Tromey  <tom@tromey.com>
4413
4414         * top.c (quit_force): Update.
4415         * main.c (captured_command_loop): Update.
4416         * common/new-op.c (operator new): Update.
4417         * common/common-exceptions.c (struct catcher)
4418         <save_cleanup_chain>: Remove member.
4419         (exceptions_state_mc_init): Update.
4420         (exception_try_scope_entry): Return nullptr.
4421         (exception_try_scope_exit, exception_rethrow)
4422         (throw_exception_sjlj, throw_exception_cxx): Update.
4423         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4424         (all_cleanups, do_cleanups, discard_cleanups)
4425         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4426         (restore_cleanups, restore_final_cleanups): Don't declare.
4427         (do_final_cleanups): Remove parameter.
4428         * common/cleanups.c (cleanup_chain, make_cleanup)
4429         (make_cleanup_dtor, all_cleanups, do_cleanups)
4430         (discard_my_cleanups, discard_cleanups)
4431         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4432         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4433         (null_cleanup): Remove.
4434         (do_final_cleanups): Remove parameter.
4435
4436 2019-03-06  Tom Tromey  <tom@tromey.com>
4437
4438         * remote.c (remote_target::remote_parse_stop_reply): Use
4439         unique_xmalloc_ptr.
4440
4441 2019-03-06  Tom Tromey  <tom@tromey.com>
4442
4443         * stabsread.c (struct stabs_field_info): Rename from field_info.
4444         <list, fnlist>: Add initializers.
4445         <obstack>: New member.
4446         (read_member_functions, read_struct_fields, read_baseclasses):
4447         Allocate on obstack.  Don't use cleanups.
4448         (read_one_struct_field, read_member_functions, read_struct_fields)
4449         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4450         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4451         (read_struct_type): Update.
4452
4453 2019-03-06  Tom Tromey  <tom@tromey.com>
4454
4455         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4456         * common/filestuff.h (make_cleanup_close): Don't declare.
4457         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4458         Remove.
4459
4460 2019-03-06  Tom Tromey  <tom@tromey.com>
4461
4462         * solib-aix.c: Use make_scope_exit.
4463
4464 2019-03-06  Tom Tromey  <tom@tromey.com>
4465
4466         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4467         Use make_scope_exit.
4468
4469 2019-03-06  Tom Tromey  <tom@tromey.com>
4470
4471         * solib-svr4.c (disable_probes_interface): Remove parameter.
4472         (svr4_handle_solib_event): Use make_scope_exit.
4473
4474 2019-03-06  Tom Tromey  <tom@tromey.com>
4475
4476         * remote.c (struct stop_reply_deleter): Remove.
4477         (stop_reply_up): Update.
4478         (struct stop_reply): Derive from notif_event.  Don't typedef.
4479         <regcache>: Now a std::vector.
4480         (stop_reply_xfree): Remove.
4481         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4482         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4483         (remote_target::discard_pending_stop_replies): Use delete.
4484         (remote_target::remote_parse_stop_reply): Update.
4485         (remote_target::process_stop_reply): Update.
4486         * remote-notif.h (struct notif_event): Add virtual destructor.
4487         Remove "dtr" member.
4488         (struct notif_client) <alloc_event>: Return a unique_ptr.
4489         (notif_event_xfree): Don't declare.
4490         (notif_event_up): New typedef.
4491         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4492         (notif_event_xfree, do_notif_event_xfree): Remove.
4493         (remote_notif_state_xfree): Update.
4494
4495 2019-03-06  Tom Tromey  <tom@tromey.com>
4496
4497         * infrun.c (displaced_step_clear_cleanup): Now a
4498         forward_scope_exit type.
4499         (displaced_step_prepare_throw): Update.
4500         (displaced_step_fixup): Update.
4501
4502 2019-03-06  Tom Tromey  <tom@tromey.com>
4503
4504         * inferior.h (class inferior): Update comment.
4505         * gdbthread.h (class thread_info): Update comment.
4506
4507 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4508             Tom Tromey  <tom@tromey.com>
4509
4510         * stabsread.h (struct stab_section_list): Remove.
4511         (coffstab_build_psymtabs): Update.
4512         * dbxread.c (symbuf_sections): Now a std::vector.
4513         (sect_idx): New global.
4514         (fill_symbuf): Update.
4515         (coffstab_build_psymtabs): Change type of stabsects parameter.
4516         Update.
4517         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4518         std::vector.
4519         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4520         (coff_locate_sections): Update.
4521         (coff_symfile_read): Remove cleanups.  Update.
4522         (init_stringtab): Add storage parameter.
4523         (free_stringtab, free_stringtab_cleanup): Remove.
4524         (init_lineno): Add storage parameter.
4525         (free_linetab, free_linetab_cleanup): Remove.
4526
4527 2019-03-06  Pedro Alves  <palves@redhat.com>
4528
4529         * linux-fork.c (fork_info::clobber_regs): Delete.
4530         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4531         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4532         comment.  Adjust.
4533         (scoped_switch_fork_info::scoped_switch_fork_info)
4534         (checkpoint_command, linux_fork_context): Adjust
4535         fork_save_infrun_state calls.
4536
4537 2019-03-06  Pedro Alves  <palves@redhat.com>
4538
4539         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4540         (inf_has_multiple_threads): Return 'bool' and rewrite using
4541         inferior_info::threads().
4542
4543 2019-03-06  Pedro Alves  <palves@redhat.com>
4544
4545         * linux-fork.c: Include <list>.
4546         (fork_list): Now a std::list instance.
4547         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4548         (forks_exist_p, find_last_fork): Adjust.
4549         (new_fork): Delete.
4550         (one_fork_p): New.
4551         (add_fork): Adjust.
4552         (free_fork): Delete, folded into fork_info::~fork_info().
4553         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4554         Adjust.
4555         (init_fork_list): Delete.
4556         (linux_fork_killall, linux_fork_mourn_inferior)
4557         (linux_fork_detach, info_checkpoints_command): Adjust.
4558         (_initialize_linux_fork): No longer call init_fork_list.
4559
4560 2019-03-06  Pedro Alves  <palves@redhat.com>
4561
4562         * linux-fork.c (new_fork): New, split out of ...
4563         (add_fork): ... this.  Return void.  Move "first fork" special
4564         case from here, to ...
4565         (checkpoint_command): ... here.
4566         * linux-linux.h (add_fork): Return void.
4567
4568 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4569
4570         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4571
4572 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4573             Chris January  <chris.january@arm.com>
4574             David Lecomber  <david.lecomber@arm.com>
4575
4576         * f-exp.y: New token, UNOP_INTRINSIC.
4577         (exp): New pattern using UNOP_INTRINSIC token.
4578         (f77_keywords): Add 'abs' keyword.
4579         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4580         (value_from_host_double): New function.
4581         (evaluate_subexp_f): Support UNOP_ABS.
4582
4583 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4584
4585         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4586         types.
4587
4588 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4589
4590         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4591         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4592         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4593
4594 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4595
4596         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4597
4598 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4599             Chris January  <chris.january@arm.com>
4600
4601         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4602         * f-exp.y: Define 'KIND' token.
4603         (exp): New pattern for KIND expressions.
4604         (ptype): Handle types with a kind extension.
4605         (direct_abs_decl): Extend to spot kind extensions.
4606         (f77_keywords): Add 'kind' to the list.
4607         (push_kind_type): New function.
4608         (convert_to_kind_type): New function.
4609         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4610         * parse.c (operator_length_standard): Likewise.
4611         * parser-defs.h (enum type_pieces): Add tp_kind.
4612         * std-operator.def: Add UNOP_KIND.
4613
4614 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4615
4616         * f-exp.y (f_parse): Set yydebug.
4617
4618 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4619
4620         * f-lang.c (evaluate_subexp_f): New function.
4621         (exp_descriptor_f): New global.
4622         (f_language_defn): Use exp_descriptor_f instead of
4623         exp_descriptor_standard.
4624
4625 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4626
4627         * f-exp.y (struct token): Add comments.
4628         (dot_ops): Remove uppercase versions and the end marker.
4629         (f77_keywords): Likewise.
4630         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4631         entries in the dot_ops array are case insensitive, and use
4632         strncasecmp to compare strings.  Also some whitespace cleanup in
4633         this area.  Similar for the f77_keywords array, except entries in
4634         this list might be case sensitive.
4635
4636 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4637
4638         * f-exp.y (struct f77_boolean_val): Add comments.
4639         (boolean_values): Remove uppercase versions, and end marker.
4640         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4641         and use strncasecmp to achieve case insensitivity.  Additionally,
4642         perform whitespace cleanup around this code.
4643
4644 2019-03-06  Tom Tromey  <tromey@adacore.com>
4645
4646         * remote-sim.c (gdbsim_target_open): Use result of
4647         gdb_argv::release.
4648
4649 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4650         Dirk Schubert  <dirk.schubert@arm.com>
4651         Chris January  <chris.january@arm.com>
4652
4653         * eval.c (evaluate_subexp_standard): Call Fortran argument
4654         wrapping logic.
4655         * f-lang.c (struct value): A value which can be passed into a
4656         Fortran function call.
4657         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4658         where appropriate.
4659         (struct type): Value ready for a Fortran function call.
4660         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4661         is needed.
4662         * f-lang.h (fortran_argument_convert): Declaration.
4663         (fortran_preserve_arg_pointer): Declaration.
4664         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4665
4666 2019-03-05  Tom Tromey  <tromey@adacore.com>
4667
4668         * python/py-prettyprint.c (print_string_repr): Remove #if.
4669         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4670
4671 2019-03-05  Tom Tromey  <tromey@adacore.com>
4672
4673         * target.c (the_dummy_target): Move later.  Change type to
4674         "dummy_target".
4675         (initialize_targets): Don't initialize the_dummy_target.
4676
4677 2019-03-05  Tom Tromey  <tromey@adacore.com>
4678
4679         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4680         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4681
4682 2019-03-05  Tom Tromey  <tromey@adacore.com>
4683
4684         * windows-nat.c (windows_nat_target::attach)
4685         (windows_nat_target::detach): Don't call gdb_flush.
4686         * valprint.c (generic_val_print, val_print, val_print_string):
4687         Don't call gdb_flush.
4688         * utils.c (defaulted_query): Don't call gdb_flush.
4689         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4690         * target.c (target_announce_detach): Don't call gdb_flush.
4691         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4692         * remote.c (extended_remote_target::attach): Don't call
4693         gdb_flush.
4694         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4695         * printcmd.c (do_examine): Don't call gdb_flush.
4696         (info_display_command): Don't call gdb_flush.
4697         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4698         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4699         * memattr.c (info_mem_command): Don't call gdb_flush.
4700         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4701         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4702         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4703         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4704         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4705         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4706         (gnu_nat_target::detach): Don't call gdb_flush.
4707         * f-valprint.c (f_val_print): Don't call gdb_flush.
4708         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4709         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4710         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4711         gdb_flush.
4712         * c-valprint.c (c_val_print): Don't call gdb_flush.
4713         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4714
4715 2019-03-05  Tom Tromey  <tromey@adacore.com>
4716
4717         * varobj.c (update_dynamic_varobj_children): Update.
4718         (install_default_visualizer): Use reset, not release.
4719         * value.c (set_internalvar): Update.
4720         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4721         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4722         ATTRIBUTE_UNUSED_RESULT.
4723
4724 2019-03-05  Tom Tromey  <tromey@adacore.com>
4725
4726         * remote.c (class scoped_remote_fd) <release>: Add
4727         ATTRIBUTE_UNUSED_RESULT.
4728
4729 2019-03-05  Tom Tromey  <tromey@adacore.com>
4730
4731         * macroexp.c (struct macro_buffer) <release>: Add
4732         ATTRIBUTE_UNUSED_RESULT.
4733
4734 2019-03-05  Tom Tromey  <tromey@adacore.com>
4735
4736         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4737         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4738         ATTRIBUTE_UNUSED_RESULT.
4739
4740 2019-03-05  Tom Tromey  <tromey@adacore.com>
4741
4742         * common/scoped_fd.h (class scoped_fd) <release>: Add
4743         ATTRIBUTE_UNUSED_RESULT.
4744
4745 2019-03-05  Tom Tromey  <tromey@adacore.com>
4746
4747         * parser-defs.h (struct parser_state) <release>: Add
4748         ATTRIBUTE_UNUSED_RESULT.
4749
4750 2019-03-05  Tom Tromey  <tromey@adacore.com>
4751
4752         * utils.h (class gdb_argv) <release>: Add
4753         ATTRIBUTE_UNUSED_RESULT.
4754         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4755
4756 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4757
4758         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4759         for-loop range, to avoid compiler warnings.
4760
4761         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4762         avoid compiler warnings about unused variables.
4763
4764         * NEWS: Mention end of support for native debugging on MS-Windows
4765         before XP.
4766
4767         PR gdb/24292
4768         * common/netstuff.c:
4769         * gdbserver/gdbreplay.c
4770         * gdbserver/remote-utils.c:
4771         * ser-tcp.c:
4772         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4773         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4774         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4775         'getaddrinfo' and 'freeaddrinfo' were not available before
4776         Windows XP, and mingw.org's MinGW headers by default define
4777         _WIN32_WINNT to 0x500.
4778
4779 2019-03-01  Gary Benson <gbenson@redhat.com>
4780
4781         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4782
4783 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4784             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4785
4786         PR gdb/8527
4787         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4788         set_sigint_trap, clear_sigint_trap.
4789
4790 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4791
4792         * target.c (target_detach): Clear the regcache and the
4793         frame cache.
4794
4795 2019-02-27  Pedro Alves  <palves@redhat.com>
4796
4797         * utils.c (set_screen_size): When we cap the height/width sizes,
4798         tweak the corresponding command variable to show "unlimited":
4799
4800 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4801             Pedro Alves  <palves@redhat.com>
4802
4803         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4804         before calling rl_set_screen_size.
4805
4806 2019-02-27  Tom Tromey  <tromey@adacore.com>
4807
4808         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4809         define.
4810         * python/py-value.c: Remove Python 2.4 workaround.
4811         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4812         workaround.
4813         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4814         Python 2.4 workaround.
4815         * python/python-internal.h: Remove Python 2.4 comment.
4816         (Py_ssize_t): Don't define.
4817         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4818         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4819         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4820         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4821         * python/python.c (do_start_initialization): Remove Python 2.4
4822         workaround.
4823         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4824         (print_children): Remove Python 2.4 workaround.
4825         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4826         workaround.
4827         (CHARBUFFERPROC_NAME): Remove.
4828         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4829         Python 2.4 workaround.
4830
4831 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4832
4833         * NEWS: Note minimum Python version.
4834
4835 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4836
4837         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4838         code from these functions.  Remove corresponding ifdefs.  Use
4839         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4840         Remove gotos and target of gotos.
4841         (infpy_search_memory): Likewise.
4842
4843 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4844
4845         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4846         (hppa_gdbarch_init): Don't register deleted functions with
4847         gdbarch.
4848
4849 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4850
4851         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4852         (h8300_unwind_sp): Delete.
4853         (h8300_dummy_id): Delete.
4854         (h8300_gdbarch_init): Don't register deleted functions with
4855         gdbarch.
4856
4857 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4858
4859         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4860         (ft32_unwind_pc): Delete.
4861         (ft32_unwind_sp): Delete.
4862         (ft32_gdbarch_init): Don't register deleted functions with
4863         gdbarch.
4864
4865 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4866
4867         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4868         (frv_unwind_pc): Delete.
4869         (frv_unwind_sp): Delete.
4870         (frv_gdbarch_init): Don't register deleted functions with
4871         gdbarch.
4872
4873 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4874
4875         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
4876         (riscv_unwind_pc): Delete.
4877         (riscv_unwind_sp): Delete.
4878         (riscv_gdbarch_init): Don't register deleted functions with
4879         gdbarch.
4880
4881 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4882
4883         * gdb/csky-tdep.c (csky_dummy_id): Delete.
4884         (csky_unwind_pc): Delete.
4885         (csky_unwind_sp): Delete.
4886         (csky_gdbarch_init): Don't register deleted functions with
4887         gdbarch.
4888
4889 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4890
4891         * gdb/cris-tdep.c (cris_dummy_id): Delete.
4892         (cris_unwind_pc): Delete.
4893         (cris_unwind_sp): Delete.
4894         (cris_gdbarch_init): Don't register deleted functions with
4895         gdbarch.
4896
4897 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4898
4899         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
4900         (bfin_unwind_pc): Delete.
4901         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
4902
4903 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4904
4905         * gdb/arm-tdep.c (arm_dummy_id): Delete.
4906         (arm_unwind_pc): Delete.
4907         (arm_unwind_sp): Delete.
4908         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
4909
4910 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4911
4912         * gdb/arc-tdep.c (arc_dummy_id): Delete.
4913         (arc_unwind_pc): Delete.
4914         (arc_unwind_sp): Delete.
4915         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
4916
4917 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4918
4919         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
4920         (alpha_unwind_pc): Delete.
4921         (alpha_gdbarch_init): Don't register deleted functions with
4922         gdbarch.
4923
4924 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4925
4926         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
4927         (aarch64_unwind_pc): Delete.
4928         (aarch64_unwind_sp): Delete.
4929         (aarch64_gdbarch_init): Don't register deleted functions with
4930         gdbarch.
4931
4932 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4933
4934         * gdbtypes.c (type_align): Don't consider static members when
4935         computing structure alignment.
4936
4937 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4938
4939         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
4940         return 0 for other types.
4941         * arch-utils.c (default_type_align): Always return 0.
4942         * gdbarch.h: Regenerate.
4943         * gdbarch.sh (type_align): Extend comment.
4944         * gdbtypes.c (type_align): Add additional comments, always call
4945         gdbarch_type_align before applying the default rules.
4946         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
4947         generic code will then apply a suitable default.
4948         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
4949         types, return 0 for other types.
4950
4951 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4952
4953         * NEWS: Create a new section for the next release branch.
4954         Rename the section of the current branch, now that it has
4955         been cut.
4956
4957 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
4958
4959         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
4960         * version.in: Bump version to 8.3.50.DATE-git.
4961
4962 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
4963
4964         * aix-thread.c (ptid_cmp): Remove unused variable.
4965         (get_signaled_thread): Likewise.
4966         (store_regs_user_thread): Likewise.
4967         (store_regs_kernel_thread): Likewise.
4968         (fetch_regs_kernel_thread): Remove shadowed variable.
4969
4970 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4971
4972         * features/riscv/32bit-cpu.xml: Add register numbers.
4973         * features/riscv/32bit-fpu.c: Regenerate.
4974         * features/riscv/32bit-fpu.xml: Add register numbers.
4975         * features/riscv/64bit-cpu.xml: Add register numbers.
4976         * features/riscv/64bit-fpu.c: Regenerate.
4977         * features/riscv/64bit-fpu.xml: Add register numbers.
4978
4979 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
4980
4981         * NEWS: Mention two argument form of gdb.Value constructor.
4982         * python/py-value.c (convert_buffer_and_type_to_value): New
4983         function.
4984         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
4985         Add support for handling an optional second argument.  Call
4986         convert_buffer_and_type_to_value as appropriate.
4987         * python/python-internal.h (Py_buffer_deleter): New struct.
4988         (Py_buffer_up): New typedef.
4989
4990 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
4991
4992         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
4993         instead of releasing ownership.
4994
4995 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
4996
4997         * dwarf2read.c (open_and_init_dwp_file): Call
4998         elf_numsections instead of bfd_count_sections to initialize
4999         dwp_file->num_sections.
5000
5001 2019-02-25  Tom Tromey  <tromey@adacore.com>
5002
5003         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5004
5005 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5006
5007         * gcore.in: Add '--readnever' option when invoking GDB.
5008
5009 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5010
5011         * MAINTAINERS: Update my email address.
5012
5013 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5014
5015         * build-id.c (build_id_to_debug_bfd_1): New function.
5016         (build_id_to_debug_bfd): Look for separate debug file in
5017         sysroot.
5018
5019 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5020
5021         * gdbarch.sh: Update the copyright year range that is placed into
5022         generated files.
5023
5024 2019-02-22  Keith Seitz  <keiths@redhat.com>
5025
5026         PR symtab/23853
5027         * linespec.c (create_sals_line_offset): Search for the default
5028         symtab's filename instead of its fullname.
5029
5030 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5031
5032         * NEWS: Update style defaults.
5033
5034 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5035
5036         * main.c (captured_main_1): Disable styling in batch mode.
5037
5038 2019-02-20  Tom Tromey  <tom@tromey.com>
5039
5040         * symtab.c (symtab_symbol_info): Fix typos.
5041
5042 2019-02-20  Tom Tromey  <tromey@adacore.com>
5043
5044         * findcmd.c (_initialize_mem_search): Use upper case for
5045         metasyntactic variables.
5046
5047 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5048
5049         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5050         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5051
5052 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5053
5054         * top.h (source_file_name): Change to std::string.
5055         * top.c (source_file_name): Likewise.
5056         (command_line_input): Adjust.
5057         * cli/cli-script.c (script_from_file): Adjust.
5058
5059 2019-02-19  Tom Tromey  <tromey@adacore.com>
5060
5061         * ravenscar-thread.c
5062         (ravenscar_thread_target::update_thread_list): Don't call
5063         ada_build_task_list.
5064         * ada-lang.h (ada_build_task_list): Don't declare.
5065         * ada-tasks.c (struct ada_tasks_inferior_data)
5066         <task_list_valid_p>: Now bool.
5067         (read_known_tasks, ada_task_list_changed)
5068         (ada_tasks_invalidate_inferior_data): Update.
5069         (read_known_tasks_array): Return bool.
5070         (read_known_tasks_list): Likewise.
5071         (read_known_tasks): Return void.
5072         (ada_build_task_list): Now static.
5073
5074 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5075
5076         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5077         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5078
5079 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5080
5081         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5082         variant for ada_tasks_pspace_data_handle and
5083         ada_tasks_inferior_data_handle.
5084         (ada_tasks_pspace_data_cleanup): New function.
5085         (ada_tasks_inferior_data_cleanup): New function.
5086
5087 2019-02-17  Tom Tromey  <tom@tromey.com>
5088
5089         * macrotab.h (macro_source_fullname): Return a std::string.
5090         * macrotab.c (macro_include, check_for_redefinition)
5091         (macro_undef, macro_lookup_definition, foreach_macro)
5092         (foreach_macro_in_scope): Update.
5093         (macro_source_fullname): Return a std::string.
5094         * macrocmd.c (show_pp_source_pos): Update.
5095
5096 2019-02-17  Tom Tromey  <tom@tromey.com>
5097
5098         * macrocmd.c (show_pp_source_pos): Style the file names.
5099
5100 2019-02-17  Tom Tromey  <tom@tromey.com>
5101
5102         PR tui/24197:
5103         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5104
5105 2019-02-17  Tom Tromey  <tom@tromey.com>
5106
5107         * ada-lang.c (user_select_syms): Use filtered printing.
5108         * utils.c (wrap_style): New global.
5109         (desired_style): Remove.
5110         (emit_style_escape): Add stream parameter.
5111         (set_output_style, reset_terminal_style, prompt_for_continue):
5112         Update.
5113         (flush_wrap_buffer): Only flush gdb_stdout.
5114         (wrap_here): Set wrap_style.
5115         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5116         treat escape sequences as a character.  Change when wrap buffer is
5117         flushed.
5118         (fputs_styled): Do not set the output style when the default is
5119         requested.
5120         * ui-style.h (struct ui_file_style) <is_default>: New method.
5121         * source.c (print_source_lines_base): Emit escape sequences in one
5122         piece.
5123
5124 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5125
5126         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5127         integers and enumeration types.
5128
5129 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5130
5131         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5132         instead of lookup_symbol_in_language
5133         (do_exact_match): New function.
5134         (ada_get_symbol_name_matcher): Return do_exact_match when
5135         doing a verbatim match.
5136
5137 2019-02-15  Tom Tromey  <tromey@adacore.com>
5138
5139         * ravenscar-thread.c (ravenscar_thread_target::resume)
5140         (ravenscar_thread_target::wait): Special case wildcard requests.
5141
5142 2019-02-15  Tom Tromey  <tromey@adacore.com>
5143
5144         * ravenscar-thread.c (base_ptid): Remove.
5145         (struct ravenscar_thread_target) <close>: New method.
5146         <m_base_ptid>: New member.
5147         <update_inferior_ptid, active_task, task_is_currently_active,
5148         runtime_initialized>: Declare methods.
5149         <ravenscar_thread_target>: Add constructor.
5150         (ravenscar_thread_target::task_is_currently_active)
5151         (ravenscar_thread_target::update_inferior_ptid)
5152         (ravenscar_runtime_initialized): Rename.  Now methods.
5153         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5154         (ravenscar_thread_target::update_thread_list): Update.
5155         (ravenscar_thread_target::active_task): Now method.
5156         (ravenscar_thread_target::store_registers)
5157         (ravenscar_thread_target::prepare_to_store)
5158         (ravenscar_thread_target::prepare_to_store)
5159         (ravenscar_thread_target::mourn_inferior): Update.
5160         (ravenscar_inferior_created): Use "new" to create target.
5161         (ravenscar_thread_target::get_ada_task_ptid): Update.
5162         (_initialize_ravenscar): Don't initialize base_ptid.
5163         (ravenscar_ops): Remove global.
5164
5165 2019-02-15  Tom Tromey  <tromey@adacore.com>
5166
5167         * target.h (push_target): Declare new overload.
5168         * target.c (push_target): New overload, taking an rvalue reference.
5169         * remote.c (remote_target::open_1): Use push_target overload.
5170         * corelow.c (core_target_open): Use push_target overload.
5171
5172 2019-02-15  Tom Tromey  <tromey@adacore.com>
5173
5174         * ravenscar-thread.c (is_ravenscar_task)
5175         (ravenscar_task_is_currently_active): Return bool.
5176         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5177         (_initialize_ravenscar): Remove "(void)".
5178         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5179         Return bool.
5180
5181 2019-02-15  Tom Tromey  <tromey@adacore.com>
5182
5183         * ravenscar-thread.c (ravenscar_runtime_initializer)
5184         (has_ravenscar_runtime, get_running_thread_id)
5185         (ravenscar_thread_target::resume): Fix indentation.
5186
5187 2019-02-15  Tom Tromey  <tromey@adacore.com>
5188
5189         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5190         from ravenscar_arch_ops.
5191         (sparc_ravenscar_ops::fetch_registers)
5192         (sparc_ravenscar_ops::store_registers): Now methods.
5193         (sparc_ravenscar_prepare_to_store): Remove.
5194         (sparc_ravenscar_ops): Redefine.
5195         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5196         methods and destructor.  Remove members.
5197         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5198         (ravenscar_thread_target::store_registers)
5199         (ravenscar_thread_target::prepare_to_store): Update.
5200         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5201         Remove.
5202         (struct ppc_ravenscar_powerpc_ops): Derive from
5203         ravenscar_arch_ops.
5204         (ppc_ravenscar_powerpc_ops::fetch_registers)
5205         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5206         (ppc_ravenscar_powerpc_ops): Redefine.
5207         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5208         (ppc_ravenscar_e500_ops::fetch_registers)
5209         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5210         (ppc_ravenscar_e500_ops): Redefine.
5211         * aarch64-ravenscar-thread.c
5212         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5213         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5214         (aarch64_ravenscar_fetch_registers)
5215         (aarch64_ravenscar_store_registers): Now methods.
5216         (aarch64_ravenscar_ops): Redefine.
5217
5218 2019-02-15  Tom Tromey  <tromey@adacore.com>
5219
5220         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5221         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5222         (ravenscar_thread_target::stopped_by_watchpoint)
5223         (ravenscar_thread_target::stopped_data_address)
5224         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5225
5226 2019-02-15  Tom Tromey  <tromey@adacore.com>
5227
5228         * ravenscar-thread.c: Fix some typos.
5229
5230 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5231             Tom Tromey  <tromey@adacore.com>
5232
5233         * ada-lang.c (ada_exception_sal): Change addr_string to a
5234         std::string.
5235         (create_ada_exception_catchpoint): Update.
5236
5237 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5238             Tom Tromey  <tromey@adacore.com>
5239
5240         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5241         (bp_location_ops): Remove.
5242         (base_breakpoint_allocate_location): Update.
5243         (free_bp_location): Update.
5244         * ada-lang.c (class ada_catchpoint_location)
5245         <ada_catchpoint_location>: Remove ops parameter.
5246         (ada_catchpoint_location_dtor): Remove.
5247         (ada_catchpoint_location_ops): Remove.
5248         (allocate_location_exception): Update.
5249         * breakpoint.h (struct bp_location_ops): Remove.
5250         (class bp_location) <bp_location>: Remove bp_location_ops
5251         parameter.
5252         <~bp_location>: Add destructor.
5253         <ops>: Remove.
5254
5255 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5256             Pedro Alves  <palves@redhat.com>
5257
5258         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5259         'PATH_MAX'.
5260
5261 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5262             Samuel Thibault  <samuel.thibault@gnu.org>
5263             Thomas Schwinge  <thomas@codesourcery.com>
5264
5265         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5266         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5267
5268 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5269
5270         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5271         (check_empty): Use "const char *".
5272
5273         * gnu-nat.c (gnu_nat_target::detach): Instead of
5274         'detach_inferior (pid)' call
5275         'detach_inferior (find_inferior_pid (pid))'.
5276
5277         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5278         'nat/fork-inferior.o'.
5279         * gnu-nat.c: #include "nat/fork-inferior.h".
5280
5281         * gnu-nat.c (gnu_nat_target::detach): Instead of
5282         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5283         * gnu-nat.h: #include "inf-child.h".
5284         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5285         'i386_gnu_nat_target::fetch_registers'.
5286         (gnu_store_registers): Rename/move to
5287         'i386_gnu_nat_target::store_registers'.
5288
5289         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5290         * gnu-nat.h (mach_thread_info): New function.
5291         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5292
5293         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5294
5295 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5296
5297         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5298
5299 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5300
5301         * windows-nat.c (windows_add_thread): Add new parameter
5302         "main_thread_p" with default value set to false.  Update
5303         function documentation as well as all callers.
5304         (windows_delete_thread): Likewise.
5305         (fake_create_process): Update call to windows_add_thread.
5306         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5307         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5308         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5309         call to windows_delete_thread.
5310
5311 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5312
5313         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5314
5315 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5316
5317         * symfile.c (find_separate_debug_file): Use canonical path of
5318         sysroot with child_path instead of gdb_sysroot if it is valid.
5319
5320 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5321
5322         * symfile.c (find_separate_debug_file): Use child_path to
5323         determine if an object file is under a sysroot.
5324
5325 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5326
5327         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5328         unittests/child-path-selftests.c.
5329         * common/pathstuff.c (child_path): New function.
5330         * common/pathstuff.h (child_path): New prototype.
5331         * unittests/child-path-selftests.c: New file.
5332
5333 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5334
5335         * symfile.c (find_separate_debug_file): Look for separate debug
5336         files in debug directories under the sysroot.
5337
5338 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5339
5340         * symtab.h (struct minimal_symbol data_p): New const method.
5341         (struct minimal_symbol text_p): Likewise.
5342         * symtab.c (output_source_filename): Use file name style
5343         to print file name.
5344         (print_symbol_info): Likewise.
5345         (print_msymbol_info): Use address style to print addresses.
5346         Use function name style to print executable text symbols.
5347         (expand_symtab_containing_pc): Use data_p.
5348         (find_pc_sect_compunit_symtab): Likewise.
5349
5350 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5351
5352         * breakpoint.c (describe_other_breakpoints): Use address style
5353         to print addresses.
5354         (say_where): Likewise.
5355
5356 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5357
5358         * ada-typeprint.c (print_func_type): Print function name
5359         style to print function name.
5360         * c-typeprint.c (c_print_type_1): Likewise.
5361
5362 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5363
5364         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5365         for execve.
5366
5367 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5368
5369         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5370         type_stack.
5371
5372 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5373
5374         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5375         TYPE_CODE_REF types.
5376
5377 2019-02-08  Jim Wilson  <jimw@sifive.com>
5378
5379         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5380         (riscv_linux_fregset): New.
5381         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5382
5383 2019-02-07  Tom Tromey  <tom@tromey.com>
5384
5385         * thread.c (thread_cancel_execution_command): Update.
5386         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5387         methods.
5388         (struct thread_fsm_ops): Remove.
5389         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5390         (thread_fsm_should_stop, thread_fsm_return_value)
5391         (thread_fsm_set_finished, thread_fsm_finished_p)
5392         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5393         Don't declare.
5394         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5395         * infrun.c (clear_proceed_status_thread)
5396         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5397         (print_stop_event): Update.
5398         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5399         Add constructor.
5400         (step_command_fsm_ops): Remove.
5401         (new_step_command_fsm): Remove.
5402         (step_1): Update.
5403         (step_command_fsm::should_stop): Rename from
5404         step_command_fsm_should_stop.
5405         (step_command_fsm::clean_up): Rename from
5406         step_command_fsm_clean_up.
5407         (step_command_fsm::do_async_reply_reason): Rename from
5408         step_command_fsm_async_reply_reason.
5409         (struct until_next_fsm): Inherit from thread_fsm.  Add
5410         constructor.
5411         (until_next_fsm_ops): Remove.
5412         (new_until_next_fsm): Remove.
5413         (until_next_fsm::should_stop): Rename from
5414         until_next_fsm_should_stop.
5415         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5416         (until_next_fsm::do_async_reply_reason): Rename from
5417         until_next_fsm_async_reply_reason.
5418         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5419         constructor.  Change type of breakpoint.
5420         (finish_command_fsm_ops): Remove.
5421         (new_finish_command_fsm): Remove.
5422         (finish_command_fsm::should_stop): Rename from
5423         finish_command_fsm_should_stop.
5424         (finish_command_fsm::clean_up): Rename from
5425         finish_command_fsm_clean_up.
5426         (finish_command_fsm::return_value): Rename from
5427         finish_command_fsm_return_value.
5428         (finish_command_fsm::do_async_reply_reason): Rename from
5429         finish_command_fsm_async_reply_reason.
5430         (finish_command): Update.
5431         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5432         Add constructor.
5433         (call_thread_fsm_ops): Remove.
5434         (call_thread_fsm::call_thread_fsm): Rename from
5435         new_call_thread_fsm.
5436         (call_thread_fsm::should_stop): Rename from
5437         call_thread_fsm_should_stop.
5438         (call_thread_fsm::should_notify_stop): Rename from
5439         call_thread_fsm_should_notify_stop.
5440         (run_inferior_call, call_function_by_hand_dummy): Update.
5441         * cli/cli-interp.c (should_print_stop_to_console): Update.
5442         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5443         Add constructor.  Change type of location_breakpoint,
5444         caller_breakpoint.
5445         (until_break_fsm_ops): Remove.
5446         (new_until_break_fsm): Remove.
5447         (until_break_fsm::should_stop): Rename from
5448         until_break_fsm_should_stop.
5449         (until_break_fsm::clean_up): Rename from
5450         until_break_fsm_clean_up.
5451         (until_break_fsm::do_async_reply_reason): Rename from
5452         until_break_fsm_async_reply_reason.
5453         (until_break_command): Update.
5454         * thread-fsm.c: Remove.
5455         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5456
5457 2019-02-07  Tom Tromey  <tom@tromey.com>
5458
5459         * yy-remap.h: Add include guard.
5460         * xtensa-tdep.h: Add include guard.
5461         * xcoffread.h: Rename include guard.
5462         * varobj-iter.h: Add include guard.
5463         * tui/tui.h: Rename include guard.
5464         * tui/tui-winsource.h: Rename include guard.
5465         * tui/tui-wingeneral.h: Rename include guard.
5466         * tui/tui-windata.h: Rename include guard.
5467         * tui/tui-win.h: Rename include guard.
5468         * tui/tui-stack.h: Rename include guard.
5469         * tui/tui-source.h: Rename include guard.
5470         * tui/tui-regs.h: Rename include guard.
5471         * tui/tui-out.h: Rename include guard.
5472         * tui/tui-layout.h: Rename include guard.
5473         * tui/tui-io.h: Rename include guard.
5474         * tui/tui-hooks.h: Rename include guard.
5475         * tui/tui-file.h: Rename include guard.
5476         * tui/tui-disasm.h: Rename include guard.
5477         * tui/tui-data.h: Rename include guard.
5478         * tui/tui-command.h: Rename include guard.
5479         * tic6x-tdep.h: Add include guard.
5480         * target/waitstatus.h: Rename include guard.
5481         * target/wait.h: Rename include guard.
5482         * target/target.h: Rename include guard.
5483         * target/resume.h: Rename include guard.
5484         * target-float.h: Rename include guard.
5485         * stabsread.h: Add include guard.
5486         * rs6000-tdep.h: Add include guard.
5487         * riscv-fbsd-tdep.h: Add include guard.
5488         * regformats/regdef.h: Rename include guard.
5489         * record.h: Rename include guard.
5490         * python/python.h: Rename include guard.
5491         * python/python-internal.h: Rename include guard.
5492         * python/py-stopevent.h: Rename include guard.
5493         * python/py-ref.h: Rename include guard.
5494         * python/py-record.h: Rename include guard.
5495         * python/py-record-full.h: Rename include guard.
5496         * python/py-record-btrace.h: Rename include guard.
5497         * python/py-instruction.h: Rename include guard.
5498         * python/py-events.h: Rename include guard.
5499         * python/py-event.h: Rename include guard.
5500         * procfs.h: Add include guard.
5501         * proc-utils.h: Add include guard.
5502         * p-lang.h: Add include guard.
5503         * or1k-tdep.h: Rename include guard.
5504         * observable.h: Rename include guard.
5505         * nto-tdep.h: Rename include guard.
5506         * nat/x86-linux.h: Rename include guard.
5507         * nat/x86-linux-dregs.h: Rename include guard.
5508         * nat/x86-gcc-cpuid.h: Add include guard.
5509         * nat/x86-dregs.h: Rename include guard.
5510         * nat/x86-cpuid.h: Rename include guard.
5511         * nat/ppc-linux.h: Rename include guard.
5512         * nat/mips-linux-watch.h: Rename include guard.
5513         * nat/linux-waitpid.h: Rename include guard.
5514         * nat/linux-ptrace.h: Rename include guard.
5515         * nat/linux-procfs.h: Rename include guard.
5516         * nat/linux-osdata.h: Rename include guard.
5517         * nat/linux-nat.h: Rename include guard.
5518         * nat/linux-namespaces.h: Rename include guard.
5519         * nat/linux-btrace.h: Rename include guard.
5520         * nat/glibc_thread_db.h: Rename include guard.
5521         * nat/gdb_thread_db.h: Rename include guard.
5522         * nat/gdb_ptrace.h: Rename include guard.
5523         * nat/fork-inferior.h: Rename include guard.
5524         * nat/amd64-linux-siginfo.h: Rename include guard.
5525         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5526         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5527         * nat/aarch64-linux.h: Rename include guard.
5528         * nat/aarch64-linux-hw-point.h: Rename include guard.
5529         * mn10300-tdep.h: Add include guard.
5530         * mips-linux-tdep.h: Add include guard.
5531         * mi/mi-parse.h: Rename include guard.
5532         * mi/mi-out.h: Rename include guard.
5533         * mi/mi-main.h: Rename include guard.
5534         * mi/mi-interp.h: Rename include guard.
5535         * mi/mi-getopt.h: Rename include guard.
5536         * mi/mi-console.h: Rename include guard.
5537         * mi/mi-common.h: Rename include guard.
5538         * mi/mi-cmds.h: Rename include guard.
5539         * mi/mi-cmd-break.h: Rename include guard.
5540         * m2-lang.h: Add include guard.
5541         * location.h: Rename include guard.
5542         * linux-record.h: Rename include guard.
5543         * linux-nat.h: Add include guard.
5544         * linux-fork.h: Add include guard.
5545         * i386-darwin-tdep.h: Rename include guard.
5546         * hppa-linux-offsets.h: Add include guard.
5547         * guile/guile.h: Rename include guard.
5548         * guile/guile-internal.h: Rename include guard.
5549         * gnu-nat.h: Rename include guard.
5550         * gdb-stabs.h: Rename include guard.
5551         * frv-tdep.h: Add include guard.
5552         * f-lang.h: Add include guard.
5553         * event-loop.h: Add include guard.
5554         * darwin-nat.h: Rename include guard.
5555         * cp-abi.h: Rename include guard.
5556         * config/sparc/nm-sol2.h: Rename include guard.
5557         * config/nm-nto.h: Rename include guard.
5558         * config/nm-linux.h: Add include guard.
5559         * config/i386/nm-i386gnu.h: Rename include guard.
5560         * config/djgpp/nl_types.h: Rename include guard.
5561         * config/djgpp/langinfo.h: Rename include guard.
5562         * compile/gcc-cp-plugin.h: Add include guard.
5563         * compile/gcc-c-plugin.h: Add include guard.
5564         * compile/compile.h: Rename include guard.
5565         * compile/compile-object-run.h: Rename include guard.
5566         * compile/compile-object-load.h: Rename include guard.
5567         * compile/compile-internal.h: Rename include guard.
5568         * compile/compile-cplus.h: Rename include guard.
5569         * compile/compile-c.h: Rename include guard.
5570         * common/xml-utils.h: Rename include guard.
5571         * common/x86-xstate.h: Rename include guard.
5572         * common/version.h: Rename include guard.
5573         * common/vec.h: Rename include guard.
5574         * common/tdesc.h: Rename include guard.
5575         * common/selftest.h: Rename include guard.
5576         * common/scoped_restore.h: Rename include guard.
5577         * common/scoped_mmap.h: Rename include guard.
5578         * common/scoped_fd.h: Rename include guard.
5579         * common/safe-iterator.h: Rename include guard.
5580         * common/run-time-clock.h: Rename include guard.
5581         * common/refcounted-object.h: Rename include guard.
5582         * common/queue.h: Rename include guard.
5583         * common/ptid.h: Rename include guard.
5584         * common/print-utils.h: Rename include guard.
5585         * common/preprocessor.h: Rename include guard.
5586         * common/pathstuff.h: Rename include guard.
5587         * common/observable.h: Rename include guard.
5588         * common/netstuff.h: Rename include guard.
5589         * common/job-control.h: Rename include guard.
5590         * common/host-defs.h: Rename include guard.
5591         * common/gdb_wait.h: Rename include guard.
5592         * common/gdb_vecs.h: Rename include guard.
5593         * common/gdb_unlinker.h: Rename include guard.
5594         * common/gdb_unique_ptr.h: Rename include guard.
5595         * common/gdb_tilde_expand.h: Rename include guard.
5596         * common/gdb_sys_time.h: Rename include guard.
5597         * common/gdb_string_view.h: Rename include guard.
5598         * common/gdb_splay_tree.h: Rename include guard.
5599         * common/gdb_setjmp.h: Rename include guard.
5600         * common/gdb_ref_ptr.h: Rename include guard.
5601         * common/gdb_optional.h: Rename include guard.
5602         * common/gdb_locale.h: Rename include guard.
5603         * common/gdb_assert.h: Rename include guard.
5604         * common/filtered-iterator.h: Rename include guard.
5605         * common/filestuff.h: Rename include guard.
5606         * common/fileio.h: Rename include guard.
5607         * common/environ.h: Rename include guard.
5608         * common/common-utils.h: Rename include guard.
5609         * common/common-types.h: Rename include guard.
5610         * common/common-regcache.h: Rename include guard.
5611         * common/common-inferior.h: Rename include guard.
5612         * common/common-gdbthread.h: Rename include guard.
5613         * common/common-exceptions.h: Rename include guard.
5614         * common/common-defs.h: Rename include guard.
5615         * common/common-debug.h: Rename include guard.
5616         * common/cleanups.h: Rename include guard.
5617         * common/buffer.h: Rename include guard.
5618         * common/btrace-common.h: Rename include guard.
5619         * common/break-common.h: Rename include guard.
5620         * cli/cli-utils.h: Rename include guard.
5621         * cli/cli-style.h: Rename include guard.
5622         * cli/cli-setshow.h: Rename include guard.
5623         * cli/cli-script.h: Rename include guard.
5624         * cli/cli-interp.h: Rename include guard.
5625         * cli/cli-decode.h: Rename include guard.
5626         * cli/cli-cmds.h: Rename include guard.
5627         * charset-list.h: Add include guard.
5628         * buildsym-legacy.h: Rename include guard.
5629         * bfin-tdep.h: Add include guard.
5630         * ax.h: Rename include guard.
5631         * arm-linux-tdep.h: Add include guard.
5632         * arm-fbsd-tdep.h: Add include guard.
5633         * arch/xtensa.h: Rename include guard.
5634         * arch/tic6x.h: Add include guard.
5635         * arch/i386.h: Add include guard.
5636         * arch/arm.h: Rename include guard.
5637         * arch/arm-linux.h: Rename include guard.
5638         * arch/arm-get-next-pcs.h: Rename include guard.
5639         * arch/amd64.h: Add include guard.
5640         * arch/aarch64-insn.h: Rename include guard.
5641         * arch-utils.h: Rename include guard.
5642         * annotate.h: Add include guard.
5643         * amd64-darwin-tdep.h: Rename include guard.
5644         * aarch64-linux-tdep.h: Add include guard.
5645         * aarch64-fbsd-tdep.h: Add include guard.
5646         * aarch32-linux-nat.h: Add include guard.
5647
5648 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5649
5650         * macrotab.c (macro_define_internal): New function that
5651         factorizes macro_define_object_internal and macro_define_function
5652         code.
5653         (macro_define_object_internal): Use macro_define_internal.
5654         (macro_define_function): Likewise.
5655
5656 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5657
5658         * macrocmd.c (extract_identifier): Return
5659         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5660         callers.
5661
5662 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5663
5664         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5665
5666 2019-02-05  Tom Tromey  <tom@tromey.com>
5667
5668         * target.c (target_stack::unpush): Move assertion earlier.
5669
5670 2019-01-30  Tom Tromey  <tom@tromey.com>
5671
5672         PR python/23615:
5673         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5674         (gdbpy_parse_and_eval): Likewise.
5675         * python/python-internal.h (gdbpy_allow_threads): New class.
5676
5677 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5678
5679         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5680         (aarch64_fbsd_fpregmap): Move earlier.
5681         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5682         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5683         instead of individual calls to trad_frame_set_reg_addr.
5684         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5685         earlier.
5686         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5687         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5688         instead of individual calls to trad_frame_set_reg_addr.
5689
5690 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5691
5692         * CONTRIBUTE: Replace contribution list with wiki link.
5693
5694 2019-01-25  Tom Tromey  <tom@tromey.com>
5695
5696         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5697
5698 2019-01-25  Tom Tromey  <tom@tromey.com>
5699
5700         * xtensa-linux-nat.c: Fix common/ includes.
5701         * xml-support.h: Fix common/ includes.
5702         * xml-support.c: Fix common/ includes.
5703         * x86-linux-nat.c: Fix common/ includes.
5704         * windows-nat.c: Fix common/ includes.
5705         * varobj.h: Fix common/ includes.
5706         * varobj.c: Fix common/ includes.
5707         * value.c: Fix common/ includes.
5708         * valops.c: Fix common/ includes.
5709         * utils.c: Fix common/ includes.
5710         * unittests/xml-utils-selftests.c: Fix common/ includes.
5711         * unittests/utils-selftests.c: Fix common/ includes.
5712         * unittests/unpack-selftests.c: Fix common/ includes.
5713         * unittests/tracepoint-selftests.c: Fix common/ includes.
5714         * unittests/style-selftests.c: Fix common/ includes.
5715         * unittests/string_view-selftests.c: Fix common/ includes.
5716         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5717         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5718         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5719         * unittests/rsp-low-selftests.c: Fix common/ includes.
5720         * unittests/parse-connection-spec-selftests.c: Fix common/
5721         includes.
5722         * unittests/optional-selftests.c: Fix common/ includes.
5723         * unittests/offset-type-selftests.c: Fix common/ includes.
5724         * unittests/observable-selftests.c: Fix common/ includes.
5725         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5726         * unittests/memrange-selftests.c: Fix common/ includes.
5727         * unittests/memory-map-selftests.c: Fix common/ includes.
5728         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5729         * unittests/function-view-selftests.c: Fix common/ includes.
5730         * unittests/environ-selftests.c: Fix common/ includes.
5731         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5732         * unittests/common-utils-selftests.c: Fix common/ includes.
5733         * unittests/cli-utils-selftests.c: Fix common/ includes.
5734         * unittests/array-view-selftests.c: Fix common/ includes.
5735         * ui-file.c: Fix common/ includes.
5736         * tui/tui-io.c: Fix common/ includes.
5737         * tracepoint.h: Fix common/ includes.
5738         * tracepoint.c: Fix common/ includes.
5739         * tracefile-tfile.c: Fix common/ includes.
5740         * top.h: Fix common/ includes.
5741         * top.c: Fix common/ includes.
5742         * thread.c: Fix common/ includes.
5743         * target/waitstatus.h: Fix common/ includes.
5744         * target/waitstatus.c: Fix common/ includes.
5745         * target.h: Fix common/ includes.
5746         * target.c: Fix common/ includes.
5747         * target-memory.c: Fix common/ includes.
5748         * target-descriptions.c: Fix common/ includes.
5749         * symtab.h: Fix common/ includes.
5750         * symfile.c: Fix common/ includes.
5751         * stap-probe.c: Fix common/ includes.
5752         * spu-linux-nat.c: Fix common/ includes.
5753         * sparc-nat.c: Fix common/ includes.
5754         * source.c: Fix common/ includes.
5755         * solib.c: Fix common/ includes.
5756         * solib-target.c: Fix common/ includes.
5757         * ser-unix.c: Fix common/ includes.
5758         * ser-tcp.c: Fix common/ includes.
5759         * ser-pipe.c: Fix common/ includes.
5760         * ser-base.c: Fix common/ includes.
5761         * selftest-arch.c: Fix common/ includes.
5762         * s12z-tdep.c: Fix common/ includes.
5763         * rust-exp.y: Fix common/ includes.
5764         * rs6000-aix-tdep.c: Fix common/ includes.
5765         * riscv-tdep.c: Fix common/ includes.
5766         * remote.c: Fix common/ includes.
5767         * remote-notif.h: Fix common/ includes.
5768         * remote-fileio.h: Fix common/ includes.
5769         * remote-fileio.c: Fix common/ includes.
5770         * regcache.h: Fix common/ includes.
5771         * regcache.c: Fix common/ includes.
5772         * record-btrace.c: Fix common/ includes.
5773         * python/python.c: Fix common/ includes.
5774         * python/py-type.c: Fix common/ includes.
5775         * python/py-inferior.c: Fix common/ includes.
5776         * progspace.h: Fix common/ includes.
5777         * producer.c: Fix common/ includes.
5778         * procfs.c: Fix common/ includes.
5779         * proc-api.c: Fix common/ includes.
5780         * printcmd.c: Fix common/ includes.
5781         * ppc-linux-nat.c: Fix common/ includes.
5782         * parser-defs.h: Fix common/ includes.
5783         * osdata.c: Fix common/ includes.
5784         * obsd-nat.c: Fix common/ includes.
5785         * nat/x86-linux.c: Fix common/ includes.
5786         * nat/x86-linux-dregs.c: Fix common/ includes.
5787         * nat/x86-dregs.h: Fix common/ includes.
5788         * nat/x86-dregs.c: Fix common/ includes.
5789         * nat/ppc-linux.c: Fix common/ includes.
5790         * nat/mips-linux-watch.h: Fix common/ includes.
5791         * nat/mips-linux-watch.c: Fix common/ includes.
5792         * nat/linux-waitpid.c: Fix common/ includes.
5793         * nat/linux-ptrace.h: Fix common/ includes.
5794         * nat/linux-ptrace.c: Fix common/ includes.
5795         * nat/linux-procfs.c: Fix common/ includes.
5796         * nat/linux-personality.c: Fix common/ includes.
5797         * nat/linux-osdata.c: Fix common/ includes.
5798         * nat/linux-namespaces.c: Fix common/ includes.
5799         * nat/linux-btrace.h: Fix common/ includes.
5800         * nat/linux-btrace.c: Fix common/ includes.
5801         * nat/fork-inferior.c: Fix common/ includes.
5802         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5803         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5804         * nat/aarch64-linux.c: Fix common/ includes.
5805         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5806         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5807         * namespace.h: Fix common/ includes.
5808         * mips-linux-tdep.c: Fix common/ includes.
5809         * minsyms.c: Fix common/ includes.
5810         * mi/mi-parse.h: Fix common/ includes.
5811         * mi/mi-main.c: Fix common/ includes.
5812         * mi/mi-cmd-env.c: Fix common/ includes.
5813         * memrange.h: Fix common/ includes.
5814         * memattr.c: Fix common/ includes.
5815         * maint.h: Fix common/ includes.
5816         * maint.c: Fix common/ includes.
5817         * main.c: Fix common/ includes.
5818         * machoread.c: Fix common/ includes.
5819         * location.c: Fix common/ includes.
5820         * linux-thread-db.c: Fix common/ includes.
5821         * linux-nat.c: Fix common/ includes.
5822         * linux-fork.c: Fix common/ includes.
5823         * inline-frame.c: Fix common/ includes.
5824         * infrun.c: Fix common/ includes.
5825         * inflow.c: Fix common/ includes.
5826         * inferior.h: Fix common/ includes.
5827         * inferior.c: Fix common/ includes.
5828         * infcmd.c: Fix common/ includes.
5829         * inf-ptrace.c: Fix common/ includes.
5830         * inf-child.c: Fix common/ includes.
5831         * ia64-linux-nat.c: Fix common/ includes.
5832         * i387-tdep.c: Fix common/ includes.
5833         * i386-tdep.c: Fix common/ includes.
5834         * i386-linux-tdep.c: Fix common/ includes.
5835         * i386-linux-nat.c: Fix common/ includes.
5836         * i386-go32-tdep.c: Fix common/ includes.
5837         * i386-fbsd-tdep.c: Fix common/ includes.
5838         * i386-fbsd-nat.c: Fix common/ includes.
5839         * guile/scm-type.c: Fix common/ includes.
5840         * guile/guile.c: Fix common/ includes.
5841         * go32-nat.c: Fix common/ includes.
5842         * gnu-nat.c: Fix common/ includes.
5843         * gdbthread.h: Fix common/ includes.
5844         * gdbarch-selftests.c: Fix common/ includes.
5845         * gdb_usleep.c: Fix common/ includes.
5846         * gdb_select.h: Fix common/ includes.
5847         * gdb_bfd.c: Fix common/ includes.
5848         * gcore.c: Fix common/ includes.
5849         * fork-child.c: Fix common/ includes.
5850         * findvar.c: Fix common/ includes.
5851         * fbsd-nat.c: Fix common/ includes.
5852         * event-top.c: Fix common/ includes.
5853         * event-loop.c: Fix common/ includes.
5854         * dwarf2read.c: Fix common/ includes.
5855         * dwarf2loc.c: Fix common/ includes.
5856         * dwarf2-frame.c: Fix common/ includes.
5857         * dwarf-index-cache.c: Fix common/ includes.
5858         * dtrace-probe.c: Fix common/ includes.
5859         * disasm-selftests.c: Fix common/ includes.
5860         * defs.h: Fix common/ includes.
5861         * csky-tdep.c: Fix common/ includes.
5862         * cp-valprint.c: Fix common/ includes.
5863         * cp-support.h: Fix common/ includes.
5864         * cp-support.c: Fix common/ includes.
5865         * corelow.c: Fix common/ includes.
5866         * completer.h: Fix common/ includes.
5867         * completer.c: Fix common/ includes.
5868         * compile/compile.c: Fix common/ includes.
5869         * compile/compile-loc2c.c: Fix common/ includes.
5870         * compile/compile-cplus-types.c: Fix common/ includes.
5871         * compile/compile-cplus-symbols.c: Fix common/ includes.
5872         * command.h: Fix common/ includes.
5873         * cli/cli-dump.c: Fix common/ includes.
5874         * cli/cli-cmds.c: Fix common/ includes.
5875         * charset.c: Fix common/ includes.
5876         * build-id.c: Fix common/ includes.
5877         * btrace.h: Fix common/ includes.
5878         * btrace.c: Fix common/ includes.
5879         * breakpoint.h: Fix common/ includes.
5880         * breakpoint.c: Fix common/ includes.
5881         * ax.h:
5882         (enum agent_op): Fix common/ includes.
5883         * ax-general.c (struct aop_map): Fix common/ includes.
5884         * ax-gdb.c: Fix common/ includes.
5885         * auxv.c: Fix common/ includes.
5886         * auto-load.c: Fix common/ includes.
5887         * arm-tdep.c: Fix common/ includes.
5888         * arch/riscv.c: Fix common/ includes.
5889         * arch/ppc-linux-common.c: Fix common/ includes.
5890         * arch/i386.c: Fix common/ includes.
5891         * arch/arm.c: Fix common/ includes.
5892         * arch/arm-linux.c: Fix common/ includes.
5893         * arch/arm-get-next-pcs.c: Fix common/ includes.
5894         * arch/amd64.c: Fix common/ includes.
5895         * arch/aarch64.c: Fix common/ includes.
5896         * arch/aarch64-insn.c: Fix common/ includes.
5897         * arch-utils.c: Fix common/ includes.
5898         * amd64-windows-tdep.c: Fix common/ includes.
5899         * amd64-tdep.c: Fix common/ includes.
5900         * amd64-sol2-tdep.c: Fix common/ includes.
5901         * amd64-obsd-tdep.c: Fix common/ includes.
5902         * amd64-nbsd-tdep.c: Fix common/ includes.
5903         * amd64-linux-tdep.c: Fix common/ includes.
5904         * amd64-linux-nat.c: Fix common/ includes.
5905         * amd64-fbsd-tdep.c: Fix common/ includes.
5906         * amd64-fbsd-nat.c: Fix common/ includes.
5907         * amd64-dicos-tdep.c: Fix common/ includes.
5908         * amd64-darwin-tdep.c: Fix common/ includes.
5909         * agent.c: Fix common/ includes.
5910         * ada-lang.h: Fix common/ includes.
5911         * ada-lang.c: Fix common/ includes.
5912         * aarch64-tdep.c: Fix common/ includes.
5913
5914 2019-01-25  Tom Tromey  <tom@tromey.com>
5915
5916         * common/create-version.sh: Use common/version.h.
5917
5918 2019-01-24  Pedro Alves  <palves@redhat.com>
5919
5920         * infrun.c (signal_stop, signal_print, signal_program)
5921         (signal_catch, signal_pass): Now arrays instead of pointers.
5922         (update_signals_program_target, do_target_resume)
5923         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
5924         * linux-nat.c (linux_nat_target::pass_signals)
5925         (linux_nat_target::create_inferior, linux_nat_target::attach):
5926         Adjust.
5927         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
5928         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
5929         * procfs.c (procfs_target::pass_signals): Adjust.
5930         * record-full.c (record_full_target::resume): Adjust.
5931         * remote.c (remote_target::pass_signals)
5932         (remote_target::program_signals): Adjust.
5933         * target-debug.h (target_debug_print_signals): Now takes a
5934         gdb::array_view as parameter.  Adjust.
5935         * target.h (target_ops) <pass_signals, program_signals>: Replace
5936         pointer and length parameters with gdb::array_view.
5937         (target_pass_signals, target_program_signals): Likewise.
5938         * target-delegates.c: Regenerate.
5939
5940 2019-01-24  Pedro Alves  <palves@redhat.com>
5941
5942         * common/forward-scope-exit.h
5943         (forward_scope_exit::forward_scope_exit): Pass arguments to
5944         m_bind_function directly, instead of creating a std::bind and
5945         copying that.
5946
5947 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
5948
5949         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
5950         for static members.
5951         (pass_in_v_vfp_candidate): Likewise.
5952
5953 2019-01-23  Tom Tromey  <tom@tromey.com>
5954             Pedro Alves  <palves@redhat.com>
5955
5956         * regcache.c (class regcache_invalidator): Remove.
5957         (regcache::raw_write): Use make_scope_exit.
5958
5959 2019-01-23  Tom Tromey  <tom@tromey.com>
5960
5961         * ui-out.h (class ui_out_emit_type): Update comment.
5962
5963 2019-01-23  Tom Tromey  <tom@tromey.com>
5964
5965         * infrun.c (fetch_inferior_event): Update comment.
5966
5967 2019-01-23  Tom Tromey  <tom@tromey.com>
5968             Pedro Alves  <palves@redhat.com>
5969
5970         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
5971         parameter.
5972         (fetch_inferior_event): Use SCOPE_EXIT.
5973
5974
5975 2019-01-23  Tom Tromey  <tom@tromey.com>
5976             Pedro Alves  <palves@redhat.com>
5977
5978         * infrun.c (disable_thread_events): Delete.
5979         (stop_all_threads): Use SCOPE_EXIT.
5980
5981 2019-01-23  Tom Tromey  <tom@tromey.com>
5982             Pedro Alves  <palves@redhat.com>
5983
5984         * symfile.c: Include forward-scope-exit.h.
5985         (clear_symtab_users_cleanup): Replace forward declaration with
5986         a FORWARD_SCOPE_EXIT.
5987         (syms_from_objfile_1): Use the forward_scope_exit and
5988         gdb::optional instead of cleanup_function.
5989         (reread_symbols): Use the forward_scope_exit instead of
5990         cleanup_function.
5991         (clear_symtab_users_cleanup): Remove function.
5992
5993 2019-01-23  Tom Tromey  <tom@tromey.com>
5994             Pedro Alves  <palves@redhat.com>
5995
5996         * linux-nat.c: Include scope-exit.h.
5997         (cleanup_target_stop): Remove.
5998         (linux_nat_target::static_tracepoint_markers_by_strid): Use
5999         SCOPE_EXIT.
6000
6001 2019-01-23  Tom Tromey  <tom@tromey.com>
6002             Pedro Alves  <palves@redhat.com>
6003
6004         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6005         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6006
6007 2019-01-23  Tom Tromey  <tom@tromey.com>
6008             Andrew Burgess  <andrew.burgess@embecosm.com>
6009             Pedro Alves  <palves@redhat.com>
6010
6011         * infrun.c (fetch_inferior_event): Use scope_exit.
6012         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6013         * top.c (execute_command): Use scope_exit.
6014         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6015         * utils.c (do_bpstat_clear_actions_cleanup)
6016         (make_bpstat_clear_actions_cleanup): Remove.
6017
6018 2019-01-23  Tom Tromey  <tom@tromey.com>
6019             Pedro Alves  <palves@redhat.com>
6020
6021         * infrun.c: Include "common/scope-exit.h"
6022         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6023         (wait_for_inferior): Use SCOPE_EXIT.
6024         (fetch_inferior_event): Use scope_exit.
6025
6026 2019-01-23  Tom Tromey  <tom@tromey.com>
6027             Pedro Alves  <palves@redhat.com>
6028
6029         * breakpoint.c (create_breakpoint): Remove cleanup.
6030
6031 2019-01-23  Tom Tromey  <tom@tromey.com>
6032             Andrew Burgess  <andrew.burgess@embecosm.com>
6033             Pedro Alves  <palves@redhat.com>
6034
6035 2019-01-23  Pedro Alves  <palves@redhat.com>
6036
6037         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6038
6039 2019-01-23  Pedro Alves  <palves@redhat.com>
6040             Andrew Burgess  <andrew.burgess@embecosm.com>
6041
6042         * gdbthread.h: Include "common/forward-scope-exit.h".
6043         (scoped_finish_thread_state): Redefine custom class in terms of
6044         forward_scope_exit.
6045
6046 2019-01-23  Pedro Alves  <palves@redhat.com>
6047             Andrew Burgess  <andrew.burgess@embecosm.com>
6048
6049         * common/forward-scope-exit.h: New file.
6050
6051 2019-01-23  Pedro Alves  <palves@redhat.com>
6052             Andrew Burgess  <andrew.burgess@embecosm.com>
6053             Tom Tromey  <tom@tromey.com>
6054
6055         * common/scope-exit.h: New file.
6056
6057 2019-01-23  Pedro Alves  <palves@redhat.com>
6058
6059         * common/preprocessor.h (ESC): Rename to ...
6060         (ESC_PARENS): ... this.
6061         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6062         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6063
6064 2019-01-23  Tom Tromey  <tom@tromey.com>
6065
6066         * language.h (class scoped_switch_to_sym_language_if_auto):
6067         Initialize m_lang in both cases.
6068
6069 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6070
6071         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6072         with XCNEW.
6073
6074 2019-01-22  Tom Tromey  <tom@tromey.com>
6075
6076         * corelow.c: Do not include sys/file.h.
6077
6078 2019-01-22  Tom Tromey  <tom@tromey.com>
6079
6080         * tui/tui-wingeneral.h: Include gdb_curses.h.
6081
6082 2019-01-22  Tom Tromey  <tom@tromey.com>
6083
6084         * source-cache.h (class source_cache) <get_source_lines,
6085         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6086
6087 2019-01-22  Tom Tromey  <tom@tromey.com>
6088
6089         * remote-fileio.h (struct remote_target): Declare.
6090
6091 2019-01-22  Tom Tromey  <tom@tromey.com>
6092
6093         * python/py-arch.c: Do not include py-ref.h.
6094         * python/py-bpevent.c: Do not include py-ref.h.
6095         * python/py-cmd.c: Do not include py-ref.h.
6096         * python/py-continueevent.c: Do not include py-ref.h.
6097         * python/py-event.h: Do not include py-ref.h.
6098         * python/py-evtregistry.c: Do not include py-ref.h.
6099         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6100         * python/py-frame.c: Do not include py-ref.h.
6101         * python/py-framefilter.c: Do not include py-ref.h.
6102         * python/py-function.c: Do not include py-ref.h.
6103         * python/py-infevents.c: Do not include py-ref.h.
6104         * python/py-linetable.c: Do not include py-ref.h.
6105         * python/py-objfile.c: Do not include py-ref.h.
6106         * python/py-param.c: Do not include py-ref.h.
6107         * python/py-prettyprint.c: Do not include py-ref.h.
6108         * python/py-progspace.c: Do not include py-ref.h.
6109         * python/py-symbol.c: Do not include py-ref.h.
6110         * python/py-symtab.c: Do not include py-ref.h.
6111         * python/py-type.c: Do not include py-ref.h.
6112         * python/py-unwind.c: Do not include py-ref.h.
6113         * python/py-utils.c: Do not include py-ref.h.
6114         * python/py-value.c: Do not include py-ref.h.
6115         * python/py-varobj.c: Do not include py-ref.h.
6116         * python/py-xmethods.c: Do not include py-ref.h.
6117         * python/python.c: Do not include py-ref.h.
6118         * varobj.c: Do not include py-ref.h.
6119
6120 2019-01-22  Tom Tromey  <tom@tromey.com>
6121
6122         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6123         keyword for bcache.
6124
6125 2019-01-22  Tom Tromey  <tom@tromey.com>
6126
6127         * compile/compile-cplus-types.c: Remove a comment by #include.
6128
6129 2019-01-22  Tom Tromey  <tom@tromey.com>
6130
6131         * compile/gcc-c-plugin.h: Include compile-internal.h.
6132
6133 2019-01-22  Tom Tromey  <tom@tromey.com>
6134
6135         * stabsread.c (EXTERN): Do not define.
6136         (symnum, next_symbol_text_func, processing_gcc_compilation)
6137         (within_function, global_sym_chain, global_stabs)
6138         (previous_stab_code, this_object_header_files)
6139         (n_this_object_header_files)
6140         (n_allocated_this_object_header_files): Define.
6141         * stabsread.h (EXTERN): Never define.  Use "extern".
6142
6143 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6144
6145         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6146         history_value.
6147
6148 2019-01-21  Tom Tromey  <tom@tromey.com>
6149
6150         * ui-out.c: Fix includes.
6151         * tui/tui-source.c: Fix includes.
6152         * target.c: Fix includes.
6153         * remote.c: Fix includes.
6154         * regcache.c: Fix includes.
6155         * python/py-block.c: Fix includes.
6156         * printcmd.c: Fix includes.
6157         * or1k-tdep.c: Fix includes.
6158         * mi/mi-main.c: Fix includes.
6159         * m32r-tdep.c: Fix includes.
6160         * csky-tdep.c: Fix includes.
6161         * compile/compile-cplus-types.c: Fix includes.
6162         * cli/cli-interp.c: Fix includes.
6163
6164 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6165
6166         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6167         for padding.
6168
6169 2019-01-16  Tom Tromey  <tom@tromey.com>
6170
6171         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6172         earlier.
6173         (struct objfile) <msymbols_range>: Move from top level.
6174         <msymbols>: New method.
6175         (class objfile_msymbols): Remove.
6176         * symtab.c (default_collect_symbol_completion_matches_break_on):
6177         Update.
6178         * symmisc.c (dump_msymbols): Update.
6179         * stabsread.c (scan_file_globals): Update.
6180         * objc-lang.c (info_selectors_command, info_classes_command)
6181         (find_methods): Update.
6182         * minsyms.c (find_solib_trampoline_target): Update.
6183         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6184         * coffread.c (coff_symfile_read): Update.
6185         * ada-lang.c (ada_lookup_simple_minsym)
6186         (ada_collect_symbol_completion_matches): Update.
6187
6188 2019-01-16  Tom Tromey  <tom@tromey.com>
6189
6190         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6191         type.  Remove no-argument constructor.
6192         <iterator::operator++>: Simplify.
6193         <begin>: Update.
6194         <end>: Use minimal_symbol_count.
6195
6196 2019-01-16  Tom Tromey  <tom@tromey.com>
6197
6198         * objfiles.h (struct objfile) <psymtabs>: New method.
6199         (class objfile_psymtabs): Remove.
6200         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6201         typedef.
6202         <range>: New method.
6203         (require_partial_symbols): Change return type.
6204         * psymtab.c (require_partial_symbols)
6205         (psym_expand_symtabs_matching): Update.
6206         * mdebugread.c (parse_partial_symbols): Update.
6207         * dbxread.c (dbx_end_psymtab): Update.
6208
6209 2019-01-15  Tom Tromey  <tom@tromey.com>
6210
6211         * symtab.c (lookup_objfile_from_block)
6212         (lookup_symbol_in_objfile_symtabs)
6213         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6214         (find_line_symtab, info_sources_command)
6215         (default_collect_symbol_completion_matches_break_on)
6216         (make_source_files_completion_list): Update.
6217         * symmisc.c (print_objfile_statistics, dump_objfile)
6218         (maintenance_print_symbols, maintenance_info_symtabs)
6219         (maintenance_check_symtabs, maintenance_info_line_tables):
6220         Update.
6221         * source.c (select_source_symtab)
6222         (forget_cached_source_info_for_objfile): Update.
6223         * objfiles.h (class objfile_compunits): Remove.
6224         (struct objfile) <compunits_range>: New typedef.
6225         (compunits): New method.
6226         * objfiles.c (objfile_relocate1): Update.
6227         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6228         * maint.c (count_symtabs_and_blocks): Update.
6229         * linespec.c (iterate_over_all_matching_symtabs): Update.
6230         * cp-support.c (add_symbol_overload_list_qualified): Update.
6231         * coffread.c (coff_symtab_read): Update.
6232         * ada-lang.c (add_nonlocal_symbols)
6233         (ada_collect_symbol_completion_matches)
6234         (ada_add_global_exceptions): Update.
6235
6236 2019-01-15  Tom Tromey  <tom@tromey.com>
6237
6238         * progspace.h (program_space) <objfiles_safe_range>: New
6239         typedef.
6240         <objfiles_safe>: New method.
6241         * objfiles.h (class all_objfiles_safe): Remove.
6242         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6243         * jit.c (jit_inferior_exit_hook): Update.
6244
6245 2019-01-17  Tom Tromey  <tom@tromey.com>
6246
6247         * progspace.h (program_space) <objfiles_range>: New typedef.
6248         <objfiles>: New method.
6249         <objfiles_head>: Rename from objfiles.
6250         (object_files): Update.
6251         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6252         * guile/scm-pretty-print.c
6253         (ppscm_find_pretty_printer_from_objfiles): Update.
6254         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6255         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6256         Update.
6257         * python/py-progspace.c (pspy_get_objfiles): Update.
6258         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6259         Update.
6260         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6261         (objfpy_lookup_objfile_by_build_id): Update.
6262         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6263         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6264         Update.
6265         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6266         (expand_symtab_containing_pc, lookup_objfile_from_block)
6267         (lookup_static_symbol, basic_lookup_transparent_type)
6268         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6269         (find_line_symtab, info_sources_command)
6270         (default_collect_symbol_completion_matches_break_on)
6271         (make_source_files_completion_list, find_main_name): Update.
6272         * symmisc.c (print_symbol_bcache_statistics)
6273         (print_objfile_statistics, maintenance_print_symbols)
6274         (maintenance_print_msymbols, maintenance_print_objfiles)
6275         (maintenance_info_symtabs, maintenance_check_symtabs)
6276         (maintenance_expand_symtabs, maintenance_info_line_tables):
6277         Update.
6278         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6279         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6280         (map_overlay_command, unmap_overlay_command)
6281         (simple_overlay_update, expand_symtabs_matching)
6282         (map_symbol_filenames): Update.
6283         * symfile-debug.c (set_debug_symfile): Update.
6284         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6285         Update.
6286         * source.c (select_source_symtab, forget_cached_source_info):
6287         Update.
6288         * solib.c (solib_read_symbols): Update.
6289         * solib-spu.c (append_ocl_sos): Update.
6290         * psymtab.c (maintenance_print_psymbols)
6291         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6292         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6293         * printcmd.c (info_symbol_command): Update.
6294         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6295         Update.
6296         * objfiles.h (class all_objfiles): Remove.
6297         * objfiles.c (have_partial_symbols, have_full_symbols)
6298         (have_minimal_symbols, qsort_cmp, update_section_map)
6299         (shared_objfile_contains_address_p)
6300         (default_iterate_over_objfiles_in_search_order): Update.
6301         * objc-lang.c (info_selectors_command, info_classes_command)
6302         (find_methods): Update.
6303         * minsyms.c (find_solib_trampoline_target): Update.
6304         * maint.c (maintenance_info_sections)
6305         (maintenance_translate_address, count_symtabs_and_blocks):
6306         Update.
6307         * main.c (captured_main_1): Update.
6308         * linux-thread-db.c (try_thread_db_load_from_pdir)
6309         (has_libpthread): Update.
6310         * linespec.c (iterate_over_all_matching_symtabs)
6311         (search_minsyms_for_name): Update.
6312         * jit.c (jit_find_objf_with_entry_addr): Update.
6313         * hppa-tdep.c (find_unwind_entry)
6314         (hppa_lookup_stub_minimal_symbol): Update.
6315         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6316         Update.
6317         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6318         (elf_gnu_ifunc_resolve_by_got): Update.
6319         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6320         * dwarf-index-write.c (save_gdb_index_command): Update.
6321         * cp-support.c (add_symbol_overload_list_qualified): Update.
6322         * breakpoint.c (create_overlay_event_breakpoint)
6323         (create_longjmp_master_breakpoint)
6324         (create_std_terminate_master_breakpoint)
6325         (create_exception_master_breakpoint): Update.
6326         * blockframe.c (find_pc_partial_function): Update.
6327         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6328         (ada_collect_symbol_completion_matches)
6329         (ada_add_global_exceptions): Update.
6330
6331 2019-01-17  Tom Tromey  <tom@tromey.com>
6332
6333         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6334         declare VEC.
6335         (solib_target_parse_libraries): Change return type.
6336         (library_list_start_segment, library_list_start_section)
6337         (library_list_end_library, library_list_start_library); Update.
6338         (solib_target_free_library_list): Remove.
6339         (solib_target_parse_libraries): Remove cleanup.  Change return
6340         type.
6341         (solib_target_current_sos): Update.
6342
6343 2019-01-17  Tom Tromey  <tromey@bapiya>
6344
6345         * valprint.c: Replace "the the" with "the".
6346         * symtab.c: Replace "the the" with "the".
6347         * solib.c: Replace "the the" with "the".
6348         * solib-dsbt.c: Replace "the the" with "the".
6349         * linespec.c: Replace "the the" with "the".
6350         * dwarf2loc.h: Replace "the the" with "the".
6351         * amd64-windows-tdep.c: Replace "the the" with "the".
6352         * aarch64-tdep.c: Replace "the the" with "the".
6353
6354 2019-01-16  Keith Seitz  <keiths@redhat.com>
6355
6356         PR gdb/23773
6357         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6358         <builder>: Rename to ..
6359         <m_builder>: ... this and make private.
6360         (dwarf2_cu::get_builder): New method.  Change all users of
6361         `builder' to use this method.
6362         (dwarf2_start_symtab): Move to ...
6363         (dwarf2_cu::start_symtab): ... here.  Update all callers
6364         (setup_type_unit_groups): Move to ...
6365         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6366         callers.
6367         (dwarf2_cu::reset_builder): New method.
6368         (process_full_compunit, process_full_type_unit): Use
6369         dwarf2_cu::reset_builder.
6370         (follow_die_offset): Record the ancestor CU if it is different
6371         from the followed DIE's CU.
6372         (follow_die_sig_1): Likewise.
6373
6374 2019-01-15  Tom Tromey  <tom@tromey.com>
6375
6376         * remote.c (class remote_state) <buf>: Now a char_vector.
6377         <buf_size>: Remove.
6378         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6379         parameter.
6380         (remote_target::getpkt_or_notif_sane_1)
6381         (remote_target::getpkt_sane)
6382         (remote_target::getpkt_or_notif_sane): Likewise.
6383         (class remote_target) <putpkt>: New overload.
6384         (remote_target::read_frame): Change type of "buf_p".  Remove
6385         sizeof_p parameter.
6386         (packet_ok): New overload.
6387         (packet_check_result): New overload.
6388         Update all uses.
6389
6390 2019-01-14  Tom Tromey  <tom@tromey.com>
6391
6392         * remote-notif.c (handle_notification, remote_notif_ack)
6393         (remote_notif_parse): Make "buf" const.
6394         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6395         const.
6396         (remote_notif_parse, remote_notif_ack, handle_notification):
6397         Likewise.
6398         * remote.c (remote_notif_stop_parse): Make "buf" const.
6399         (remote_target::remote_parse_stop_reply): Make "buf" const.
6400         (remote_notif_stop_ack): Make "buf" const.
6401
6402 2019-01-14  Tom Tromey  <tom@tromey.com>
6403
6404         * remote.c (remote_console_output): Make parameter const.
6405
6406 2019-01-14  Tom Tromey  <tom@tromey.com>
6407
6408         * target-debug.h (target_debug_print_signals): Constify.
6409         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6410         * procfs.c (procfs_target::pass_signals): Update.
6411         * linux-nat.c (linux_nat_target::pass_signals): Update.
6412         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6413         * target-delegates.c: Rebuild.
6414         * remote.c (remote_target::program_signals): Update.
6415         (remote_target::pass_signals): Update.
6416         * target.c (target_pass_signals): Constify argument.
6417         (target_program_signals): Likewise.
6418         * target.h (struct target_ops) <pass_signals, program_signals>:
6419         Constify argument.
6420         (target_pass_signals, target_program_signals): Constify argument.
6421
6422 2019-01-14  Tom Tromey  <tom@tromey.com>
6423
6424         PR tui/28819:
6425         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6426
6427 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6428
6429         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6430         field.
6431         * rs6000-tdep.c: Include reggroups.h.
6432         (IS_V_ALIAS_PSEUDOREG): Define.
6433         (rs6000_register_name): Return names for the "vX" aliases.
6434         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6435         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6436         aliases.  Call default_register_reggroup_p for all other
6437         pseudo-registers.
6438         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6439         New functions.
6440         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6441         Handle "vX" aliases.
6442         (v_alias_pseudo_register_collect): New function.
6443         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6444         (rs6000_gdbarch_init): Initialize "vX" aliases as
6445         pseudo-registers.  Restore registration of
6446         rs6000_pseudo_register_reggroup_p with
6447         set_tdesc_pseudo_register_reggroup_p.
6448
6449 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6450
6451         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6452         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6453         set_gdbarch_num_pseudo_regs.
6454
6455 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6456
6457         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6458         Remove arg prefixname, add do_set and do_show.
6459         Add member functions set_list and show_list.
6460         * cli/cli-style.c (class cli_style_option): Update accordingly.
6461         (style_set_list): Move to file scope.
6462         (style_show_list): Likewise.
6463         (set_style): Call help_list.
6464         (show_style): Call cmd_show_list.
6465         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6466         Update to use the new macro.
6467
6468 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6469
6470         * ada-lang.c (_initialize_ada_language): Expand the help text
6471         for the "catch exception" command.
6472
6473 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6474
6475         * symtab.c (matching_obj_sections): Initialize obj,
6476         declare it closer to its usage.
6477
6478 2019-01-10  Tom Tromey  <tom@tromey.com>
6479
6480         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6481         (basic_inf_threads_range): Remove.
6482         (inf_threads_range, inf_non_exited_threads_range)
6483         (safe_inf_threads_range): Use next_adapter.
6484
6485 2019-01-10  Keith Seitz  <keiths@redhat.com>
6486
6487         PR gdb/23712
6488         PR symtab/23010
6489         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6490         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6491
6492 2019-01-10  Keith Seitz  <keiths@redhat.com>
6493
6494         PR gdb/23712
6495         PR symtab/23010
6496         * dictionary.c (pending_to_vector): Remove.
6497         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6498         Remove _1 suffix, replacing functions of the same name.  Update
6499         all callers.
6500         (dict_create_hashed, dict_create_hashed_expandable)
6501         (dict_create_linear, dict_create_linear_expandable, dict_free)
6502         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6503         Make functions static.
6504
6505 2019-01-10  Keith Seitz  <keiths@redhat.com>
6506
6507         PR gdb/23712
6508         PR symtab/23010
6509         * dictionary.h (struct dictionary): Replace declaration with
6510         multidictionary.
6511         (dict_create_hashed, dict_create_hashed_expandable)
6512         (dict_create_linear, dict_create_linear_expandable)
6513         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6514         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6515         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6516         taking multidictionary argument.
6517         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6518         * block.h (struct block) <dict>: Change to multidictionary
6519         and rename `multidict'.
6520         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6521         symmisc.c: Update all dictionary references to multidictionary.
6522
6523 2019-01-10  Keith Seitz  <keiths@redhat.com>
6524
6525         PR gdb/23712
6526         PR symtab/23010
6527         * dictionary.c: Include unordered_map.
6528         (pending_to_vector): New function.
6529         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6530         Rewrite the non-"_1" functions to take vector instead
6531         of linked list.
6532         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6533         "new" _1 versions of the same name.
6534         (multidictionary): Define.
6535         (std::hash<enum language): New definition.
6536         (collate_pending_symbols_by_language, mdict_create_hashed)
6537         (mdict_create_hashed_expandable, mdict_create_linear)
6538         (mdict_create_linear_expandable, mdict_free)
6539         (find_language_dictionary, create_new_language_dictionary)
6540         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6541         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6542         (mdict_size, mdict_empty): New functions.
6543         * dictionary.h (mdict_iterator): Define.
6544
6545 2019-01-10  Pedro Alves  <palves@redhat.com>
6546
6547         * breakpoint.c (read_uploaded_action)
6548         (create_tracepoint_from_upload): Adjust to use
6549         gdb::unique_xmalloc_ptr.
6550         * ctf.c (ctf_write_uploaded_tp):
6551         (SET_ARRAY_FIELD): Use emplace_back.
6552         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6553         * tracefile-tfile.c (tfile_write_uploaded_tp):
6554         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6555         gdb::unique_xmalloc_ptr.
6556         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6557         at_string, cond_string, cmd_strings>: Replace char pointers
6558         with gdb::unique_xmalloc_ptr.
6559
6560 2019-01-10  Pedro Alves  <palves@redhat.com>
6561
6562         * solib-target.c (library_list_start_library): Don't xstrdup name.
6563
6564 2019-01-10  Pedro Alves  <palves@redhat.com>
6565
6566         * mdebugread.c (parse_partial_symbols): Use
6567         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6568
6569 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6570
6571         * linux-fork.c (scoped_switch_fork_info)
6572         <~scoped_switch_fork_info>: Fix incorrect variable name.
6573
6574 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6575
6576         * linux-fork.c (scoped_switch_fork_info)
6577         <scoped_switch_fork_info>: Make explicit.
6578         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6579
6580 2019-01-10  Tom Tromey  <tom@tromey.com>
6581
6582         * objfiles.h (objfile::reset_psymtabs): Update.
6583         * objfiles.c (objfile::objfile): Update.
6584         * psymtab.h (psymtab_storage::obstack): Update.
6585         (psymtab_storage::m_obstack): Use gdb::optional.
6586         (class psymtab_storage): Update comment.  Remove objfile
6587         parameter.
6588         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6589
6590 2019-01-10  Tom Tromey  <tom@tromey.com>
6591
6592         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6593         <free_psymtabs>: Now private.
6594         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6595         (allocate_psymtab): Use new method.
6596
6597 2019-01-10  Tom Tromey  <tom@tromey.com>
6598
6599         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6600         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6601         * mdebugread.c (parse_partial_symbols): Use
6602         allocate_dependencies.
6603         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6604         allocate_dependencies.
6605         (process_psymtab_comp_unit_reader)
6606         (build_type_psymtab_dependencies): Likewise.
6607         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6608
6609 2019-01-10  Tom Tromey  <tom@tromey.com>
6610
6611         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6612         PSYMBOL_SET_LANGUAGE.
6613         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6614
6615 2019-01-10  Tom Tromey  <tom@tromey.com>
6616
6617         * psymtab.h (psymtab_storage::obstack): New method.
6618         <m_obstack>: Rename from obstack; now private.
6619         * psymtab.c (psymtab_storage): Update.
6620         * dwarf2read.c (create_addrmap_from_index)
6621         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6622         Update.
6623
6624 2019-01-10  Tom Tromey  <tom@tromey.com>
6625
6626         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6627         * objfiles.h (objfile::reset_psymtabs): New method.
6628
6629 2019-01-10  Tom Tromey  <tom@tromey.com>
6630
6631         * symmisc.c (print_symbol_bcache_statistics): Update.
6632         (print_objfile_statistics): Update.
6633         * symfile.c (reread_symbols): Update.
6634         * psymtab.h (class psymtab_storage): New.
6635         * psymtab.c (psymtab_storage): New constructor.
6636         (~psymtab_storage): New destructor.
6637         (require_partial_symbols): Update.
6638         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6639         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6640         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6641         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6642         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6643         (start_psymtab_common, end_psymtab_common)
6644         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6645         (allocate_psymtab): Update.
6646         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6647         Update.
6648         (dump_psymtab_addrmap, maintenance_print_psymbols)
6649         (maintenance_check_psymtabs): Update.
6650         (class objfile_psymtabs): Move to objfiles.h.
6651         * psympriv.h (discard_psymtab): Now inline.
6652         (psymtab_discarder::psymtab_discarder): Update.
6653         (psymtab_discarder::~psymtab_discarder): Update.
6654         (ALL_OBJFILE_PSYMTABS): Rewrite.
6655         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6656         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6657         Remove fields.
6658         <partial_symtabs>: New field.
6659         (class objfile_psymtabs): Move from psymtab.h.  Update.
6660         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6661         psymbol_cache.
6662         (objfile::~objfile): Don't destroy psymbol_cache.
6663         * mdebugread.c (parse_partial_symbols): Update.
6664         * dwarf2read.c (create_addrmap_from_index)
6665         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6666         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6667         (add_partial_subprogram, dwarf2_ranges_read): Update.
6668         * dwarf-index-write.c (write_address_map)
6669         (write_one_signatured_type, recursively_write_psymbols)
6670         (class debug_names, class debug_names, write_psymtabs_to_index):
6671         Update.
6672
6673 2019-01-10  Tom Tromey  <tom@tromey.com>
6674
6675         * symtab.h (SYMBOL_SET_NAMES): Update.
6676         (symbol_set_names): Update.
6677         (MSYMBOL_SET_NAMES): Update.
6678         * symtab.c (symbol_set_names): Change argument to be an
6679         objfile_per_bfd_storage.
6680         * psymtab.c (add_psymbol_to_bcache): Update.
6681         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6682
6683 2019-01-10  Tom Tromey  <tom@tromey.com>
6684
6685         * symtab.c (create_demangled_names_hash): Change argument to be an
6686         objfile_per_bfd_storage.
6687         (symbol_set_names): Update.
6688
6689 2019-01-10  Tom Tromey  <tom@tromey.com>
6690
6691         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6692         init_psymbol_list.
6693         * psymtab.c (init_psymbol_list): Do nothing if already called.
6694         * psympriv.h (init_psymbol_list): Add comment.
6695         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6696         init_psymbol_list.
6697         * dbxread.c (dbx_symfile_read): Unconditionally call
6698         init_psymbol_list.
6699
6700 2019-01-10  Tom Tromey  <tom@tromey.com>
6701
6702         * xcoffread.c (scan_xcoff_symtab): Update.
6703         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6704         "where".
6705         * mdebugread.c (parse_partial_symbols)
6706         (handle_psymbol_enumerators): Update.
6707         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6708         * dbxread.c (read_dbx_symtab): Update.
6709         * psympriv.h (psymbol_placement): New enum.
6710         (add_psymbol_to_list): Update.
6711
6712 2019-01-10  Tom Tromey  <tom@tromey.com>
6713
6714         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6715         static_psymbols parameters.
6716         (scan_xcoff_symtab): Update.
6717         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6718         static_psymbols parameters.
6719         * psympriv.h (start_psymtab_common): Update.
6720         * mdebugread.c (parse_partial_symbols): Update.
6721         * dwarf2read.c (create_partial_symtab): Update.
6722         * dbxread.c (read_dbx_symtab): Update.
6723         (start_psymtab): Remove global_psymbols and static_psymbols
6724         parameters.
6725
6726 2019-01-10  Tom Tromey  <tom@tromey.com>
6727
6728         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6729         * psymtab.c (allocate_psymtab): Add comment.
6730         * psympriv.h (allocate_psymtab): Add comment.
6731         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6732         initializations.
6733         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6734
6735 2019-01-10  Tom Tromey  <tom@tromey.com>
6736
6737         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6738         Don't declare.
6739         * mipsread.c: Include mdebugread.h.
6740         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6741         Declare.
6742         * elfread.c: Include mdebugread.h.
6743
6744 2019-01-09  Tom Tromey  <tom@tromey.com>
6745
6746         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6747         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6748         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6749         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6750         (psym_lookup_symbol, psym_find_last_source_symtab)
6751         (psym_forget_cached_source_info, psym_print_stats)
6752         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6753         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6754         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6755         (psym_find_compunit_symtab_by_address)
6756         (maintenance_print_psymbols, maintenance_info_psymtabs)
6757         (maintenance_check_psymtabs): Use ranged for.
6758         * psymtab.h (class objfile_psymtabs): New.
6759         (require_partial_symbols): Return objfile_psymtabs.
6760         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6761
6762 2019-01-09  Tom Tromey  <tom@tromey.com>
6763
6764         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6765         (find_pc_mapped_section, list_overlays_command)
6766         (map_overlay_command, unmap_overlay_command)
6767         (simple_overlay_update): Use all_objfiles.
6768         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6769         * printcmd.c (info_symbol_command): Use all_objfiles.
6770         * objfiles.h (ALL_OBJSECTIONS): Remove.
6771         * maint.c (maintenance_translate_address): Use all_objfiles.
6772         * gcore.c (gcore_create_callback): Use all_objfiles.
6773         (objfile_find_memory_regions): Likewise.
6774
6775 2019-01-09  Tom Tromey  <tom@tromey.com>
6776
6777         * symtab.c (find_line_symtab, info_sources_command)
6778         (make_source_files_completion_list): Use objfile_compunits.
6779         * source.c (select_source_symtab): Use objfile_compunits.
6780         * objfiles.h (struct objfile): Update comment.
6781         (ALL_OBJFILES): Remove.
6782         (ALL_FILETABS): Remove.
6783         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6784         objfile_compunits.
6785
6786 2019-01-09  Tom Tromey  <tom@tromey.com>
6787
6788         * symmisc.c (print_objfile_statistics, dump_objfile)
6789         (maintenance_print_symbols): Use compunit_filetabs.
6790         * source.c (forget_cached_source_info_for_objfile): Use
6791         compunit_filetabs.
6792         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6793         (ALL_FILETABS): Use compunit_filetabs.
6794         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6795         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6796
6797 2019-01-09  Tom Tromey  <tom@tromey.com>
6798
6799         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6800         (compunit_filetabs): New.
6801         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6802         compunit_filetabs.
6803         (info_sources_command, make_source_files_completion_list): Remove
6804         declaration.
6805         * symmisc.c (print_objfile_statistics, dump_objfile)
6806         (maintenance_print_symbols): Remove declaration.
6807         (maintenance_info_symtabs): Use compunit_filetabs.
6808         (maintenance_info_line_tables): Likewise.
6809         * source.c (select_source_symtab): Change local variable name.
6810         (forget_cached_source_info_for_objfile): Remove declaration.
6811         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6812         * objfiles.c (objfile_relocate1): Remove declaration.
6813         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6814         declaration.
6815         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6816         * coffread.c (coff_symtab_read): Remove declaration.
6817         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6818         compunit_filetabs.
6819
6820 2019-01-09  Tom Tromey  <tom@tromey.com>
6821
6822         * symtab.c (lookup_objfile_from_block)
6823         (find_pc_sect_compunit_symtab, search_symbols)
6824         (default_collect_symbol_completion_matches_break_on): Use
6825         objfile_compunits.
6826         * objfiles.h (ALL_COMPUNITS): Remove.
6827         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6828         * cp-support.c (add_symbol_overload_list_qualified): Use
6829         objfile_compunits.
6830         * ada-lang.c (ada_collect_symbol_completion_matches)
6831         (ada_add_global_exceptions): Use objfile_compunits.
6832
6833 2019-01-09  Tom Tromey  <tom@tromey.com>
6834
6835         * source.c (select_source_symtab)
6836         (forget_cached_source_info_for_objfile): Remove declaration.
6837         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6838         declaration.
6839         * maint.c (count_symtabs_and_blocks): Remove declaration.
6840         * cp-support.c (add_symbol_overload_list_qualified): Remove
6841         declaration.
6842         * coffread.c (coff_symtab_read): Remove declaration.
6843         * symtab.c (lookup_symbol_in_objfile_symtabs)
6844         (basic_lookup_transparent_type_1): Use objfile_compunits.
6845         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6846         (info_sources_command, search_symbols)
6847         (default_collect_symbol_completion_matches_break_on)
6848         (make_source_files_completion_list): Remove declaration.
6849         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6850         (ada_collect_symbol_completion_matches)
6851         (ada_add_global_exceptions): Remove declaration.
6852         * linespec.c (iterate_over_all_matching_symtabs): Use
6853         objfile_compunits.
6854         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6855         (class objfile_compunits): New.
6856         (ALL_COMPUNITS): Use objfile_compunits.
6857         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6858         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6859         objfile_compunits.
6860         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6861
6862 2019-01-09  Tom Tromey  <tom@tromey.com>
6863
6864         * symtab.c (search_symbols)
6865         (default_collect_symbol_completion_matches_break_on): Use
6866         objfile_msymbols.
6867         * ada-lang.c (ada_lookup_simple_minsym)
6868         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6869         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6870         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6871         objfile_msymbols.
6872         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6873         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6874         * objc-lang.c (find_methods): Use objfile_msymbols.
6875         (info_selectors_command, info_classes_command): Likewise.
6876         * stabsread.c (scan_file_globals): Use objfile_msymbols.
6877         * objfiles.h (class objfile_msymbols): New.
6878         (ALL_OBJFILE_MSYMBOLS): Remove.
6879         (ALL_MSYMBOLS): Remove.
6880
6881 2019-01-09  Tom Tromey  <tom@tromey.com>
6882
6883         * common/next-iterator.h (next_adapter): Add Iterator template
6884         parameter.
6885         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
6886         (class all_objfiles_safe): New.
6887         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
6888         * objfiles.c (put_objfile_before): Update comment.
6889         (add_separate_debug_objfile): Likewise.
6890         (free_all_objfiles): Use all_objfiles_safe.
6891         (objfile_purge_solibs): Likewise.
6892
6893 2019-01-09  Tom Tromey  <tom@tromey.com>
6894
6895         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6896         (expand_symtab_containing_pc, lookup_static_symbol)
6897         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
6898         (find_symbol_at_address, find_line_symtab, find_main_name): Use
6899         all_objfiles.
6900         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
6901         * breakpoint.c (create_overlay_event_breakpoint)
6902         (create_longjmp_master_breakpoint)
6903         (create_std_terminate_master_breakpoint)
6904         (create_exception_master_breakpoint): Use all_objfiles.
6905         * linux-thread-db.c (try_thread_db_load_from_pdir)
6906         (has_libpthread): Use all_objfiles.
6907         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
6908         * linespec.c (iterate_over_all_matching_symtabs)
6909         (search_minsyms_for_name): Use all_objfiles.
6910         * maint.c (maintenance_info_sections): Use all_objfiles.
6911         * main.c (captured_main_1): Use all_objfiles.
6912         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
6913         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
6914         * guile/scm-pretty-print.c
6915         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
6916         * solib-spu.c (append_ocl_sos): Use all_objfiles.
6917         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
6918         (maintenance_print_msymbols): Use all_objfiles.
6919         * source.c (select_source_symtab): Use all_objfiles.
6920         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
6921         * symfile.c (remove_symbol_file_command)
6922         (expand_symtabs_matching, map_symbol_filenames): Use
6923         all_objfiles.
6924         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
6925         all_objfiles.
6926         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
6927         * objc-lang.c (find_methods): Use all_objfiles.
6928         * objfiles.c (have_partial_symbols, have_full_symbols)
6929         (have_minimal_symbols, qsort_cmp)
6930         (default_iterate_over_objfiles_in_search_order): Use
6931         all_objfiles.
6932         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
6933         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
6934         (maintenance_check_psymtabs): Use all_objfiles.
6935         (ALL_PSYMTABS): Remove.
6936         * compile/compile-object-run.c (do_module_cleanup): Use
6937         all_objfiles.
6938         * blockframe.c (find_pc_partial_function): Use all_objfiles.
6939         * cp-support.c (add_symbol_overload_list_qualified): Use
6940         all_objfiles.
6941         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6942         Use all_objfiles.
6943         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
6944         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
6945         all_objfiles.
6946         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6947         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
6948         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6949         Uses all_objfiles.
6950         * solib.c (solib_read_symbols): Use all_objfiles
6951
6952 2019-01-09  Tom Tromey  <tom@tromey.com>
6953
6954         * probe.c (parse_probes_in_pspace): Use all_objfiles.
6955         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
6956         all_objfiles.
6957         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
6958         * symmisc.c (print_symbol_bcache_statistics)
6959         (print_objfile_statistics, maintenance_print_objfiles)
6960         (maintenance_info_symtabs, maintenance_check_symtabs)
6961         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
6962         all_objfiles.
6963         * source.c (forget_cached_source_info): Use all_objfiles.
6964         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
6965         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6966         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
6967         * objfiles.c (update_section_map): Use all_objfiles.
6968         (shared_objfile_contains_address_p): Likewise.
6969         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
6970         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
6971
6972 2019-01-09  Tom Tromey  <tom@tromey.com>
6973
6974         * common/next-iterator.h: New file.
6975         * objfiles.h (class all_objfiles): New.
6976         (struct objfile_iterator): New.
6977
6978 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6979
6980         * NEWS: Move the description of the changed "frame", "select-frame",
6981          and "info frame" commands to the Changed commands section.
6982
6983 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
6984
6985         * gdbtypes.c (check_stub_method_group): Remove handling of old
6986         mangling schemes.
6987         * linespec.c (find_methods): Likewise.
6988         * stabsread.c (read_member_functions): Likewise.
6989         * valops.c (search_struct_method): Likewise.
6990         (value_struct_elt_for_reference): Likewise.
6991         * NEWS: Mention this change.
6992
6993 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6994
6995         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
6996         print_source_lines.
6997         * source.c (print_source_lines_base): Update line number check.
6998         (print_source_lines): New function.
6999         (source_lines_range::source_lines_range): New function.
7000         * source.h (class source_lines_range): New class.
7001         (print_source_lines): New declaration.
7002
7003 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7004
7005         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7006
7007 2019-01-08  Tom Tromey  <tom@tromey.com>
7008             Simon Marchi  <simon.marchi@ericsson.com>
7009
7010         PR gdb/24060
7011         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7012         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7013         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7014         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7015         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7016         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7017
7018 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7019
7020         * source.c (select_source_symtab): Move header comment to
7021         declaration in source.h.
7022         (forget_cached_source_info_for_objfile): Likewise.
7023         (forget_cached_source_info): Likewise.
7024         (identify_source_line): Likewise.
7025         * source.h (identify_source_line): Move declaration from symtab.h
7026         and add comment from source.c
7027         (print_source_lines): Likewise.
7028         (forget_cached_source_info_for_objfile): Likewise.
7029         (forget_cached_source_info): Likewise.
7030         (select_source_symtab): Likewise.
7031         (enum print_source_lines_flag): Move definition from symtab.h.
7032         * symtab.h (identify_source_line): Move declaration to source.h.
7033         (print_source_lines): Likewise.
7034         (forget_cached_source_info_for_objfile): Likewise.
7035         (forget_cached_source_info): Likewise.
7036         (select_source_symtab): Likewise.
7037         (enum print_source_lines_flag): Move definition to source.h.
7038         * tui/tui-hooks.c: Add 'source.h' include.
7039
7040 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7041
7042         * source.c (print_source_lines_base): Handle requests to print
7043         reverse line number sequences, and guard against empty lines
7044         string.
7045
7046 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7047
7048         * source.c (print_source_lines_base): Fix skip of '\r' if next
7049         character is '\n'.
7050
7051 2019-01-06  Tom Tromey  <tom@tromey.com>
7052
7053         * c-exp.y (struct c_parse_state) <macro_original_text,
7054         expansion_obstack>: New member.
7055         (macro_original_text, expansion_obstack): Remove globals.
7056         (scan_macro_expansion, scanning_macro_expansion)
7057         (finished_macro_expansion): Update.
7058         (scan_macro_cleanup): Remove.
7059         (yylex, c_parse): Update.
7060
7061 2019-01-06  Tom Tromey  <tom@tromey.com>
7062
7063         * c-exp.y (struct c_parse_state) <strings>: New member.
7064         (operator_stoken): Update.
7065
7066 2019-01-06  Tom Tromey  <tom@tromey.com>
7067
7068         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7069         (union type_stack_elt) <typelist_val>: Now a pointer to
7070         std::vector.
7071         (type_stack_cleanup): Don't declare.
7072         (push_typelist): Update.
7073         * parse.c (pop_typelist): Return a std::vector.
7074         (push_typelist): Take a std::vector.
7075         (follow_types): Update.  Do not free args.
7076         (type_stack_cleanup): Remove.
7077         * c-exp.y (struct c_parse_state): New.
7078         (cpstate): New global.
7079         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7080         (nonempty_typelist): Update.
7081         (func_mod): Create a new vector.
7082         (c_parse): Create a c_parse_state.
7083         (check_parameter_typelist): Do not delete params.
7084         (function_method): Update.  Do not delete type_list.
7085
7086 2019-01-06  Tom Tromey  <tom@tromey.com>
7087
7088         PR gdb/28155:
7089         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7090         check_typedef.
7091         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7092         (print_return_value): Likewise.
7093
7094 2019-01-05  Tom Tromey  <tom@tromey.com>
7095
7096         * contrib/cleanup_check.py: Remove.
7097         * contrib/gcc-with-excheck: Remove.
7098         * contrib/exsummary.py: Remove.
7099         * contrib/excheck.py: Remove.
7100
7101 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7102
7103         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7104         NULL. Initialize tpprev to NULL instead of assigning it
7105         to NULL on the next statement.
7106         * windows-nat.c (windows_delete_thread): Remove check for
7107         main_thread_id before printing thread exit notifications.
7108         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7109         Remove thread ID check against main_thread_id.
7110         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7111         windows_delete_thread.
7112         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7113
7114 2019-01-04  Tom Tromey  <tom@tromey.com>
7115
7116         * compile/compile.c (_initialize_compile): Use upper case for
7117         metasyntactic variables.
7118         * symmisc.c (_initialize_symmisc): Use upper case for
7119         metasyntactic variables.
7120         * psymtab.c (_initialize_psymtab): Use upper case for
7121         metasyntactic variables.
7122         * demangle.c (demangle_command): Use upper case for metasyntactic
7123         variables.
7124         (_initialize_demangler): Likewise.
7125         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7126         variables.
7127
7128 2019-01-03  Tom Tromey  <tom@tromey.com>
7129
7130         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7131
7132 2019-01-03  Tom Tromey  <tom@tromey.com>
7133
7134         * python/py-symtab.c (salpy_str): Update.
7135         (struct salpy_sal_object) <symtab>: Now a PyObject.
7136         (salpy_dealloc): Update.
7137         (del_objfile_sal): Use gdbpy_ref.
7138
7139 2019-01-03  Tom Tromey  <tom@tromey.com>
7140
7141         * python/py-type.c (convert_field): Use new_reference.  Return
7142         gdbpy_ref.
7143         (make_fielditem): Return gdbpy_ref.
7144         (typy_fields): Update.
7145         (typy_getitem): Update.
7146         (field_name): Return gdbpy_ref.  Use new_reference.
7147         (typy_iterator_iternext): Update.
7148
7149 2019-01-03  Tom Tromey  <tom@tromey.com>
7150
7151         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7152
7153 2019-01-03  Tom Tromey  <tom@tromey.com>
7154
7155         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7156         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7157         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7158         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7159         (pspy_set_type_printers): Likewise.
7160         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7161         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7162         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7163         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7164         (objfpy_set_type_printers): Likewise.
7165
7166 2019-01-03  Tom Tromey  <tom@tromey.com>
7167
7168         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7169         (gdbpy_print_stack): Use gdbpy_err_fetch.
7170         * python/python-internal.h (class gdbpy_err_fetch): New class.
7171         (class gdbpy_enter) <m_error_type, m_error_value,
7172         m_error_traceback>: Remove.
7173         <m_error>: New member.
7174         (gdbpy_exception_to_string): Don't declare.
7175         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7176         * python/py-value.c (convert_value_from_python): Use
7177         gdbpy_err_fetch.
7178         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7179         gdbpy_exception_to_string.
7180         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7181         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7182         gdbpy_err_fetch.
7183
7184 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7185
7186         * linux-nat.c (delete_lwp_cleanup): Delete.
7187         (struct lwp_deleter): New struct.
7188         (lwp_info_up): New typedef.
7189         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7190         lwp_info_up.
7191
7192 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7193
7194         * linux-fork.c (class scoped_switch_fork_info): New class.
7195         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7196
7197 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7198
7199         * valops.c (find_overload_match): Remove use of null_cleanup, and
7200         calls to do_cleanups.
7201
7202 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7203
7204         * compile/compile-cplus-types.c
7205         (compile_cplus_instance::decl_name): Handle changes to
7206         cp_func_name.
7207         * cp-support.c (cp_func_name): Update header comment, update
7208         return type.
7209         * cp-support.h (cp_func_name): Update return type in declaration.
7210         * valops.c (find_overload_match): Move temp_func local to top
7211         level of function and change its type.  Use temp_func to hold and
7212         delete temporary string obtained from cp_func_name.
7213
7214 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7215
7216         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7217         gdb::char_vector, remove cleanup, and update uses of `msg`.
7218
7219 2019-01-03  Jim Wilson  <jimw@sifive.com>
7220
7221         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7222
7223 2019-01-02  Tom Tromey  <tom@tromey.com>
7224
7225         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7226         (tdesc_parse_xml): Remove cleanups.
7227         * target-descriptions.h (make_cleanup_free_target_description):
7228         Don't declare.
7229         (target_desc_deleter): New struct.
7230         (target_desc_up): New typedef.
7231         * target-descriptions.c (target_desc_deleter::operator()): Rename
7232         from free_target_description.
7233         (make_cleanup_free_target_description): Remove.
7234
7235 2019-01-02  Tom Tromey  <tom@tromey.com>
7236
7237         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7238         constructor, destructor.
7239         (linespec_parser): Remove typedef.
7240         (~linespec_parser): Rename from linespec_parser_delete.
7241         (linespec_lex_to_end, linespec_complete_label)
7242         (linespec_complete): Update.
7243         (decode_line_full): Remove cleanups.
7244         (decode_line_1): Update.
7245
7246 2019-01-02  Tom Tromey  <tom@tromey.com>
7247
7248         * python/python-internal.h (inferior_to_inferior_object): Change
7249         return type.
7250         * python/py-exitedevent.c (create_exited_event_object): Update.
7251         * python/py-inferior.c (inferior_to_inferior_object): Return
7252         gdbpy_ref.
7253         (python_new_inferior, python_inferior_deleted)
7254         (thread_to_thread_object, delete_thread_object)
7255         (build_inferior_list, gdbpy_selected_inferior): Update.
7256         * python/py-infthread.c (create_thread_object): Update.  Also fail
7257         if inferior_to_inferior_object fails.
7258
7259 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7260
7261         * inferior.h (class inferior) <displaced_step_state>: New field.
7262         * infrun.h (struct displaced_step_state): Move here from
7263         infrun.c.  Initialize fields, add constructor.
7264         <inf>: Remove field.
7265         <reset>: New method.
7266         * infrun.c (struct displaced_step_inferior_state): Move to
7267         infrun.h.
7268         (displaced_step_inferior_states): Remove.
7269         (get_displaced_stepping_state): Adust.
7270         (displaced_step_in_progress_any_inferior): Adjust.
7271         (displaced_step_in_progress_thread): Adjust.
7272         (displaced_step_in_progress): Adjust.
7273         (add_displaced_stepping_state): Remove.
7274         (get_displaced_step_closure_by_addr): Adjust.
7275         (remove_displaced_stepping_state): Remove.
7276         (infrun_inferior_exit): Call displaced_step_state.reset.
7277         (use_displaced_stepping): Don't check for NULL.
7278         (displaced_step_prepare_throw): Call
7279         get_displaced_stepping_state.
7280         (displaced_step_fixup): Don't check for NULL.
7281         (prepare_for_detach): Don't check for NULL.
7282
7283 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7284
7285         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7286          in case of call that did not complete.
7287
7288 2019-01-02  Andrey Utkin  <autkin@undo.io>
7289
7290         * symfile.c (find_separate_debug_file): Fix search of debug files for
7291         remote debuggee.
7292
7293 2019-01-02  Tom Tromey  <tom@tromey.com>
7294
7295         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7296         indentation.
7297         * python/py-frame.c (frapy_older): Remove cast.
7298         (frapy_newer): Likewise.
7299         * python/py-breakpoint.c (local_setattro): Remove cast.
7300         * python/py-arch.c (archpy_name): Remove local variable.
7301         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7302
7303 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7304
7305         * unittests/basic_string_view/element_access/char/empty.cc:
7306         Fix year range in copyright header.
7307
7308 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7309
7310         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7311         Delete.
7312         <operator==>: Update with for removed field.
7313         <hash>: Likewise.
7314         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7315         <isa_features>: ...this.
7316         <abi_features>: New field.
7317         (riscv_isa_flen): Update comment.
7318         (riscv_abi_xlen): New declaration.
7319         (riscv_abi_flen): New declaration.
7320         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7321         isa_features.
7322         (riscv_abi_xlen): New function.
7323         (riscv_isa_flen): Update to get answer from isa_features.
7324         (riscv_abi_flen): New function.
7325         (riscv_has_fp_abi): Update to get answer from abi_features.
7326         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7327         xlen and flen.
7328         (riscv_call_info) <xlen, flen>: Update comment.
7329         (riscv_call_arg_struct): Remove invalid assertions
7330         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7331         is removed.
7332         (riscv_gdbarch_init): Gather isa features and abi features
7333         separately, ensure both match on the gdbarch when reusing an old
7334         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7335         a target with 64-bit float hardware.
7336
7337 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7338
7339         * source.c (search_command_helper): Stop reverse search
7340         when line 1 has been searched.
7341
7342 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7343
7344         * record-full.c (record_full_base_target::close): Rewrite
7345         record_full_core_buf_list free logic.
7346
7347 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7348
7349         * break-catch-syscall.c (print_one_catch_syscall): xfree
7350         the last text.
7351
7352 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7353
7354         * top.c (print_gdb_version): Update Copyright year in version
7355         message.
7356
7357 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7358
7359         Update copyright year range in all GDB files.
7360
7361 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7362
7363         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7364
7365 For older changes see ChangeLog-2018.
7366 \f
7367 Local Variables:
7368 mode: change-log
7369 left-margin: 8
7370 fill-column: 74
7371 version-control: never
7372 coding: utf-8
7373 End:
7374