gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
   4         and that "set/show print raw frame-arguments" are now deprecated.
   5
   6         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
   7         command.
   8         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
   9         * stack.c (_initialize_stack): Install "set/show print
  10         raw-frame-arguments", and deprecate "set/show print raw
  11         frame-arguments".
  12         * valprint.c (_initialize_valprint): Deprecate "set/show print
  13         raw".
  14
  15 2019-06-13  Pedro Alves  <palves@redhat.com>
  16
  17         * compile/compile.c (struct compile_options): New.
  18         (compile_flag_option_def, compile_command_option_defs)
  19         (make_compile_options_def_group): New.
  20         (compile_file_command): Handle options with
  21         gdb::option::process_options.
  22         (compile_file_command_completer): New function.
  23         (compile_code_command): Handle options with
  24         gdb::option::process_options.
  25         (compile_code_command_completer): New function.
  26         (_initialize_compiler): Install completers for "compile code" and
  27         "compile file".  Mention available options in "compile code" and
  28         "compile code"'s help.
  29         * completer.c (advance_to_completion_word): New, factored out from
  30         ...
  31         (advance_to_expression_complete_word_point): ... this.
  32         (advance_to_filename_complete_word_point): New.
  33         * completer.h (advance_to_filename_complete_word_point): New
  34         declaration.
  35
  36 2019-06-13  Pedro Alves  <palves@redhat.com>
  37
  38         * compile/compile.c: Include "cli/cli-option.h".
  39         (compile_print_value): Scope data pointer is now a
  40         value_print_options pointer; adjust.
  41         (compile_print_command): Process options.  Scope data pointer is
  42         now a value_print_options pointer; adjust.
  43         (_initialize_compile): Update "compile print"'s help to include
  44         supported options.  Install a completer for "compile print".
  45         * cp-valprint.c (show_vtblprint, show_objectprint)
  46         (show_static_field_print): Delete.
  47         (_initialize_cp_valprint): Don't install "set print
  48         static-members", "set print vtbl", "set print object" here.
  49         * printcmd.c: Include "cli/cli-option.h" and
  50         "common/gdb_optional.h".
  51         (print_command_parse_format): Rework to fill in a
  52         value_print_options instead of a format_data.
  53         (print_value): Change parameter type from format_data pointer to
  54         value_print_options reference.  Adjust.
  55         (print_command_1): Process options.  Adjust to pass down a
  56         value_print_options.
  57         (print_command_completer): New.
  58         (_initialize_printcmd): Install print_command_completer as
  59         handle_brkchars completer for the "print" command.  Update
  60         "print"'s help to include supported options.
  61         * valprint.c: Include "cli/cli-option.h".
  62         (show_vtblprint, show_objectprint, show_static_field_print): Moved
  63         here from cp-valprint.c.
  64         (boolean_option_def, uinteger_option_def)
  65         (value_print_option_defs, make_value_print_options_def_group):
  66         New.  Use gdb::option::add_setshow_cmds_for_options to install
  67         "set print elements", "set print null-stop", "set print repeats",
  68         "set print pretty", "set print union", "set print array", "set
  69         print address", "set print symbol", "set print array-indexes".
  70         * valprint.h: Include <string> and "cli/cli-option.h".
  71         (make_value_print_options_def_group): Declare.
  72         (print_value): Change parameter type from format_data pointer to
  73         value_print_options reference.
  74         (print_command_completer): Declare.
  75
  76 2019-06-13  Pedro Alves  <palves@redhat.com>
  77
  78         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
  79         (COMMON_SFILES): Add maint-test-settings.c.
  80         * cli/cli-decode.c (boolean_enums): New global, factored out from
  81         ...
  82         (add_setshow_boolean_cmd): ... here.
  83         * cli/cli-decode.h (boolean_enums): Declare.
  84         * cli/cli-option.c: New file.
  85         * cli/cli-option.h: New file.
  86         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
  87         factored out from ...
  88         (parse_cli_boolean_value(const char *)): ... this.
  89         (is_unlimited_literal): Change parameter type to pointer to
  90         pointer.  Adjust and advance ARG pointer.
  91         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  92         (parse_cli_var_enum): New, factored out from ...
  93         (do_set_command): ... this.  Adjust.
  94         * cli/cli-setshow.h (parse_cli_boolean_value)
  95         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
  96         (parse_cli_var_enum): Declare.
  97         * cli/cli-utils.c: Include "cli/cli-option.h".
  98         (get_ulongest): New.
  99         * cli/cli-utils.h (get_ulongest): Declare.
 100         (check_for_argument): New overloads.
 101         * maint-test-options.c: New file.
 102
 103 2019-06-13  Pedro Alves  <palves@redhat.com>
 104
 105         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 106         parse a range if "-" is at the end of the string.
 107
 108 2019-06-13  Pedro Alves  <palves@redhat.com>
 109
 110         * cli/cli-setshow.c (parse_auto_binary_operation)
 111         (parse_cli_boolean_value): Don't allow "o".
 112
 113 2019-06-13  Pedro Alves  <palves@redhat.com>
 114
 115         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 116         * NEWS: Mention maint test-settings KIND.
 117         * maint-test-settings.c: New file.
 118
 119 2019-06-13  Pedro Alves  <palves@redhat.com>
 120
 121         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 122         completer.
 123         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 124         "set" completers.
 125
 126 2019-06-13  Pedro Alves  <palves@redhat.com>
 127
 128         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 129         after item.
 130
 131 2019-06-13  Pedro Alves  <palves@redhat.com>
 132
 133         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 134
 135 2019-06-13  Pedro Alves <palves@redhat.com>
 136
 137         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 138         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 139         call.
 140         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 141         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 142         calls.
 143         (check_for_argument): Skip spaces after argument.
 144
 145 2019-06-13  Pedro Alves  <palves@redhat.com>
 146
 147         * thread.c (thread_apply_command): Adjust TID parsing.
 148         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 149         detected before end of string.
 150         (tid_is_in_list): Error out if LIST is invalid.
 151
 152 2019-06-13  Pedro Alves  <palves@redhat.com>
 153
 154         * completer.c (complete_line_internal_1): Rewind completion word
 155         point.
 156         (completion_tracker::advance_custom_word_point_by): Change
 157         parameter type to int.
 158         * completer.h (completion_tracker::advance_custom_word_point_by):
 159         Likewise.
 160
 161 2019-06-13  Pedro Alves  <palves@redhat.com>
 162
 163         * completer.c (advance_to_completion_word): Handle delimiters.
 164
 165 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 166
 167         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 168
 169 2019-06-11  Tom Tromey  <tom@tromey.com>
 170
 171         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 172         (xmalloc_failed): Move to alloc.c.
 173         * alloc.c: New file.
 174         * Makefile.in (COMMON_SFILES): Add alloc.c.
 175
 176 2019-06-11  Tom Tromey  <tom@tromey.com>
 177
 178         * nat/linux-waitpid.c: Don't include server.h.
 179         (linux_debug): Remove.
 180         (my_waitpid): Update.
 181
 182 2019-06-11  Tom Tromey  <tromey@adacore.com>
 183
 184         * infcall.c (_initialize_infcall): Remove trailing newline from
 185         help.
 186         * user-regs.c (_initialize_user_regs): Remove trailing newline
 187         from help.
 188         * typeprint.c (_initialize_typeprint): Remove trailing newline
 189         from help.
 190         * reverse.c (_initialize_reverse): Remove trailing newlines from
 191         help.
 192         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 193         from help.
 194         * language.c (add_set_language_command): Remove trailing newline
 195         from help.
 196         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 197         help.
 198         * disasm.c (_initialize_disasm): Remove trailing newline from
 199         help.
 200         * top.c (init_main): Remove trailing newline from help.
 201         * interps.c (_initialize_interpreter): Remove trailing newline
 202         from help.
 203         * btrace.c (_initialize_btrace): Remove trailing newlines from
 204         help.
 205         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 206         from help.
 207         * python/python.c (_initialize_python): Remove trailing newline
 208         from help.
 209         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 210         help.
 211         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 212         from help.  Reformat some text.
 213         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 214         from help.
 215         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 216         newline from help.
 217
 218 2019-06-11  Tom Tromey  <tromey@adacore.com>
 219
 220         * darwin-nat.c (darwin_decode_exception_message)
 221         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 222
 223 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 224
 225         * valops.c (value_slice): Check for not allocated or not
 226         associated values.
 227
 228 2019-06-10  Tom de Vries  <tdevries@suse.de>
 229
 230         PR gdb/24618
 231         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 232         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 233         invalid.
 234
 235 2019-06-10  Tom de Vries  <tdevries@suse.de>
 236
 237         PR gdb/24611
 238         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 239         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 240
 241 2019-06-10  Tom de Vries  <tdevries@suse.de>
 242
 243         PR symtab/24545
 244         * symtab.c (struct demangled_name_entry): Add language field.
 245         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 246         static minimal symbol".  Set and use language field.
 247
 248 2019-06-10  Tom Tromey  <tromey@adacore.com>
 249
 250         * ada-lang.c (_initialize_ada_language): Update help text.
 251
 252 2019-06-10  Tom Tromey  <tromey@adacore.com>
 253
 254         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 255         with a newline.
 256         * guile/guile.c (handle_boot_error): Don't end warning with a
 257         newline.
 258         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 259         warning with a newline.
 260         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 261         newline.
 262         (s12z_frame_cache): Likewise.
 263         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 264         a newline.
 265         * solib-svr4.c (disable_probes_interface): Don't end warning with
 266         a newline.
 267         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 268         newline.
 269         * python/python.c (do_finish_initialization): Don't end warning
 270         with a newline.
 271
 272 2019-06-10  Tom Tromey  <tom@tromey.com>
 273
 274         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 275         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 276         gdbpy_enter.
 277
 278 2019-06-10  Tom Tromey  <tromey@adacore.com>
 279
 280         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 281         data.
 282         (elf_new_init): Don't call stabsread_new_init.
 283         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 284         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 285         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 286
 287 2019-06-10  Tom de Vries  <tdevries@suse.de>
 288
 289         PR symtab/16264
 290         PR symtab/24517
 291         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 292
 293 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 294
 295         * source.c (find_and_open_source): Also rewrite relative file
 296         names.
 297
 298 2019-04-26  Amos Bird  <amosbird@gmail.com>
 299
 300         * annotate.c (annotate_thread_exited): Add "thread-exited"
 301         annotation.
 302
 303 2019-06-06  Tom Tromey  <tromey@adacore.com>
 304
 305         * maint.h (class scoped_command_stats): Use
 306         DISABLE_COPY_AND_ASSIGN.
 307         <print_time>: New method.
 308         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 309         print_time.
 310         (scoped_command_stats::print_time): New method.
 311
 312 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 313
 314         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 315         instructions of lengths 6 or 8 bytes.
 316
 317 2019-06-04  Pedro Alves  <palves@redhat.com>
 318
 319         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 320
 321         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 322         * breakpoint.c (condition_completer): Likewise.
 323         * cli/cli-dump.c (scan_expression): Likewise.
 324         * common/filestuff.c (mkdir_recursive): Likewise.
 325         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 326         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 327         (gdb_abspath): Likewise.
 328         * compile/compile-cplus-types.c
 329         (compile_cplus_instance::decl_name): Likewise.
 330         * completer.c (complete_explicit_location):
 331         (signal_completer, reg_or_group_completer_1): Likewise.
 332         * cp-support.c (cp_remove_params_if_any): Likewise.
 333         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 334         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 335         * infcmd.c (strip_bg_char): Likewise.
 336         * linespec.c (copy_token_string): Likewise.
 337         * mi/mi-main.c (output_cores): Likewise.
 338         * psymtab.c (psymtab_search_name):
 339         * symfile.c (test_set_ext_lang_command): Likewise.
 340         * target.c (target_fileio_read_stralloc): Likewise.
 341         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 342         * value.c (complete_internalvar): Likewise.
 343
 344 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 345
 346         Add objfile property to gdb.Type.
 347         * NEWS: Mention Python API addition.
 348         * python/py-type.c (typy_get_objfile): New method.
 349
 350 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 351
 352         * NEWS: Mention the new set|show style [title|highlight].
 353         Mention changes to "show style", "help" and "apropos".
 354
 355 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 356
 357         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 358         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 359         instead of print_help_for_command.
 360         (print_doc_of_command): New function.
 361         (help_list): Add 'apropos -v word' suggestion.
 362         (print_help_for_command): Style the command name using title style.
 363         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 364         (_initialize_cli_cmds): Describe -v in apropos_command help.
 365
 366 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 367
 368         * cli/cli-style.h (cli_style_option): Add name in constructor,
 369         add m_name class member, add constructor with intensity,
 370         add name class function.
 371         (cli_style_option::add_setshow_commands): Remove name argument.
 372         (highlight_style, title_style): New styles.
 373         * cli/cli-style.c (do_show): New function that shows a style
 374         characteristic styling the style name with itself.
 375         (set_style_name): New function.
 376         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 377         Update all callers according to the changes in cli/cli-style.h.
 378         * utils.h (fputs_highlighted): New function.
 379         * utils.c (fputs_highlighted): Likewise.
 380
 381 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 382
 383         * NEWS: Mention new pipe command and new convenience variables.
 384
 385 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 386
 387         * cli/cli-cmds.c (pipe_command): New function.
 388         (_initialize_cli_cmds): Call add_com for pipe_command.
 389         Define | as an alias for pipe.
 390         (exit_status_set_internal_vars): New function.
 391         (shell_escape): Call exit_status_set_internal_vars.
 392         cli/cli-decode.c (find_command_name_length): Recognize | as
 393         a single character command.
 394
 395 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 396
 397         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 398         top.c (execute_command_to_ui_file): New function, mostly a copy
 399         of execute_command_to_string.
 400         (execute_command_to_string): Implement by calling
 401         execute_command_to_ui_file.
 402
 403 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 404
 405         * top.h (saved_command_line): Remove declaration.
 406         * top.c (previous_saved_command_line, previous_repeat_arguments):
 407         New variables.
 408         (saved_command_line): Make static, define together with other
 409         'repeat variables'.
 410         (dont_repeat): Clear repeat_arguments.
 411         (repeat_previous, get_saved_command_line, save_command_line):
 412         New functions.
 413         (gdb_init): Initialize saved_command_line
 414         and previous_saved_command_line.
 415         * main.c (captured_main_1): Remove saved_command_line initialization.
 416         * event-top.c (handle_line_of_input): Update to use
 417         the new 'repeat' related functions instead of direct access to
 418         saved_command_line.
 419         * command.h (repeat_previous, get_saved_command_line,
 420         save_command_line): New declarations.
 421         (dont_repeat): Add comment.
 422
 423 2019-05-30  Tom Tromey  <tromey@adacore.com>
 424
 425         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 426         Fix comment.
 427         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 428
 429 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 430
 431         PR cli/24587
 432         * completer.c (complete): Initialize variable word.
 433
 434 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 435
 436         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 437         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 438         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 439         'body' is NULL to the outter 'if', protecting the '!is_define'
 440         situation as well.
 441
 442 2019-05-29  Tom Tromey  <tromey@adacore.com>
 443
 444         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 445         (dwarf_unknown): New function.
 446         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 447         (dwarf_type_encoding_name): Use dwarf_unknown.
 448
 449 2019-05-29  Tom Tromey  <tromey@adacore.com>
 450
 451         PR c++/20020:
 452         * cp-valprint.c (cp_print_value_fields): Call
 453         cp_print_static_field inside "try".
 454
 455 2019-05-29  Tom Tromey  <tromey@adacore.com>
 456
 457         * inflow.c (struct terminal_info): Add default operator=.
 458         * configure: Rebuild.
 459         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 460         -Wdeprecated-copy-dtor, -Wredundant-move.
 461
 462 2019-05-29  Tom Tromey  <tromey@adacore.com>
 463
 464         * NEWS: Add entry.
 465         * infcmd.c (print_return_value_1): Handle finish_print
 466         option.
 467         (show_print_finish): New function.
 468         (_initialize_infcmd): Add "set/show print finish" commands.
 469         * valprint.c (user_print_options): Initialize new member.
 470         * valprint.h (struct value_print_options) <finish_print>: New
 471         member.
 472
 473 2019-05-28  Tom Tromey  <tromey@adacore.com>
 474
 475         * ada-lang.c (ada_remove_Xbn_suffix)
 476         (find_old_style_renaming_symbol)
 477         (parse_old_style_renaming): Remove.
 478         (ada_find_renaming_symbol): Don't call
 479         find_old_style_renaming_symbol.
 480         (ada_is_renaming_symbol): Rename from
 481         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 482         bool.  Now static.
 483         (ada_read_var_value): Update and simplify.
 484         * ada-exp.y (write_var_or_type): Remove old code.
 485
 486 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 487
 488         * event-top.c: Remove include comment.
 489         * inflow.c (class scoped_ignore_sigttou): Move from here...
 490         * inflow.h (class scoped_ignore_sigttou): ...to here.
 491         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 492         * top.c:  Remove include comment.
 493
 494 2019-05-27  Tom Tromey  <tom@tromey.com>
 495
 496         * NEWS: Fix typo.
 497
 498 2019-05-22  Tom Tromey  <tromey@adacore.com>
 499
 500         * target.c (target_follow_exec): Constify parameter.
 501         * target-delegates.c: Rebuild.
 502         * remote.c (remote_target::follow_exec): Constify parameter.
 503         * infrun.c (follow_exec): Constify parameter.
 504         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 505         (target_follow_exec): Likewise.
 506
 507 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 508
 509         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 510         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 511
 512 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 513
 514         * NEWS: Add debugredirect and testsuite sections.
 515
 516 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 517
 518         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 519         target descriptions using exclusively floating point register name
 520         aliases.
 521
 522 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 523
 524         PR gdb/18644:
 525         * f-lang.c (build_fortran_types): Handle the case where
 526         gdbarch_floatformat_for_type returns a nullptr.
 527
 528 2019-05-21  Tom de Vries  <tdevries@suse.de>
 529
 530         PR cli/24587
 531         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 532
 533 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 534
 535         PR gdb/18644:
 536         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 537         16-byte floats.
 538         * i386-tdep.c (i386_floatformat_for_type): Use
 539         floatformats_ia64_quad for the 16-byte floating point component
 540         within a fortran 32-byte complex number.
 541
 542 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 543
 544         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 545         delete default constructor.
 546         (find_partial_die): Update to return const struct.
 547         (partial_die_parent_scope): Move variable declaration into scope
 548         of its use and change its type to auto.
 549         (guess_partial_die_structure_name): Likewise.
 550         (partial_die_info::fixup): Likewise.
 551
 552 2019-05-17  Tom Tromey  <tromey@adacore.com>
 553
 554         * source.c (find_and_open_source): Remove cast.
 555
 556 2019-05-17  Tom Tromey  <tromey@adacore.com>
 557
 558         * annotate.c (annotate_source): Make "filename" const.
 559         * annotate.h (annotate_source): Use const.
 560
 561 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 562
 563         * disasm.c (set_disassembler_options): Send errors to stderr.
 564
 565 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 566
 567         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 568         (cli_interp_base::set_logging): Check debug_redirect.
 569         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 570         * cli/cli-logging.c (debug_redirect): Add static variable.
 571         (pop_output_files): Add default param.
 572         (handle_redirections): Print debug setting.
 573         (show_logging_command): Likewise.
 574         (_initialize_cli_logging): Add debugredirect command.
 575         * interps.c (current_interp_set_logging): Add debug_redirect
 576         parameter.
 577         * interps.h (set_logging): Add debug_redirect parameter.
 578         (current_interp_set_logging): Likewise.
 579         * mi/mi-common.h: Likewise.
 580         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 581
 582 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 583             Tom Tromey  <tromey@adacore.com>
 584
 585         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 586         directly.
 587         * cli/cli-interp.h (make_logging_output): Remove declaration.
 588         * cli/cli-logging.c (make_logging_output): Remove function.
 589         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 590         directly.
 591         * ui-file.c (tee_file::tee_file): Remove bools.
 592         (tee_file::~tee_file): Remove deletes.
 593         * ui-file.h (tee_file): Remove bools.
 594
 595 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 596
 597         * mi/mi-cmds.h (mi_cmd_complete): New function.
 598         * mi/mi-main.c (mi_cmd_complete): Likewise.
 599         * mi/mi-cmds.c: Define new MI command -complete.
 600         * NEWS: Mention new -complete command.
 601
 602 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 603
 604         * completer.h (complete): New function.
 605         * completer.c (complete): Likewise.
 606         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 607         function defined in completer.h.
 608
 609 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 610
 611        * MAINTAINERS (Write After Approval): Add myself.
 612
 613 2019-05-17  Tom de Vries  <tdevries@suse.de>
 614
 615         PR gdb/24094
 616         * dwarf2read.c (struct cu_partial_die_info): New struct.
 617         (find_partial_die): Return cu_partial_die_info.
 618         (partial_die_parent_scope, guess_partial_die_structure_name)
 619         (partial_die_info::fixup): Handle new return type of find_partial_die.
 620
 621 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 622
 623         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 624         "std::string", simplifying the algorithm.
 625
 626 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 627
 628         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 629         (stap_static_probe_ops::get_probes): Likewise.
 630
 631 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 632
 633         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 634         '-')" and "else if".
 635         (stap_parse_single_operand): Join checks for
 636         "gdbarch_stap_parse_special_token_p" and
 637         "gdbarch_stap_parse_special_token" in the same "if" statement.
 638         Invert check when verifying for operation on register
 639         displacement.
 640
 641 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 642
 643         * stap-probe.c (stap_get_opcode): Update comment.
 644         (stap_get_expected_argument_type): Likewise.
 645         (handle_stap_probe): Likewise.
 646
 647 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 648
 649         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 650         return type to 'bool'.  Adjust comment.  Use 'bool' when
 651         appropriate.
 652         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 653         * stap-probe.c (stap_parse_argument_1): Likewise.
 654         (stap_is_operator): Likewise.
 655         (stap_is_generic_prefix): Likewise.
 656         (stap_is_register_prefix): Likewise.
 657         (stap_is_register_indirection_prefix): Likewise.
 658         (stap_is_integer_prefix): Likewise.
 659         (stap_generic_check_suffix): Likewise.
 660         (stap_check_integer_suffix): Likewise.
 661         (stap_check_register_suffix): Likewise.
 662         (stap_check_register_indirection_suffix): Likewise.
 663         (stap_parse_register_operand): Likewise.
 664         (stap_parse_single_operand): Likewise.
 665         (stap_parse_argument_1): Likewise.
 666         (stap_probe::get_argument_count): Likewise.
 667         (stap_is_operator): Likewise.
 668
 669 2019-05-16  Tom Tromey  <tromey@adacore.com>
 670
 671         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 672         keyword to foreach.
 673
 674 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 675
 676         * linux-thread-db.c (try_thread_db_load_1): Change return type
 677         to bool.
 678         (try_thread_db_load): Likewise.
 679         (try_thread_db_load_from_pdir_1): Likewise.
 680         (try_thread_db_load_from_pdir): Likewise.
 681         (try_thread_db_load_from_sdir): Likewise.
 682         (try_thread_db_load_from_dir): Likewise.
 683         (thread_db_load_search): Likewise.
 684         (has_libpthread): Likewise.
 685         (thread_db_load): Likewise.
 686
 687 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 688
 689         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 690         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 691         NULL, and complain/return if that's the case.
 692
 693 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 694
 695         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 696         (advance, posn, abstract_read_memory): New functions.
 697         [struct mem_read_abstraction]: New struct.
 698         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 699
 700 2019-05-14  Tom Tromey  <tromey@adacore.com>
 701
 702         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 703         value is not lval_memory.
 704
 705 2019-05-14  Tom Tromey  <tromey@adacore.com>
 706
 707         * solib.c (info_sharedlibrary_command): Style the file name.
 708
 709 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 710
 711         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 712         (aarch64_vnv_type): Likewise.
 713         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 714         * common/tdesc.c: Likewise.
 715         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 716         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 717         * features/aarch64-fpu.xml: Add ieee half view.
 718         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 719         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 720         * gdbtypes.h (struct builtin_type): Likewise.
 721         (struct objfile_type): Likewise.
 722
 723 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 724
 725         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 726         typo.
 727         * location.h (string_to_event_location): Likewise.
 728
 729 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 730
 731         GDB 8.3 released.
 732
 733 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 734
 735         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 736         New variable declaration.
 737         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 738         New variable.
 739         (print_one_breakpoint): Use ui_out::test_flags and new global
 740         variable to compute use_fixed_output.
 741         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 742         Remove.
 743         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 744         (mi_multi_location_breakpoint_output_fixed): Remove.
 745         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 746         new variable.
 747         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 748         fix_multi_location_breakpoint_output flag if version >= 3.
 749         * ui-out.h (enum ui_out_flag)
 750         <fix_multi_location_breakpoint_output>: New enumerator.
 751
 752 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 753
 754         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 755
 756 2019-05-10  Tom Tromey  <tromey@adacore.com>
 757
 758         * ada-lang.c (catch_ada_completer): New function.
 759         (_initialize_ada_language): Use it.
 760
 761 2019-05-10  Tom Tromey  <tromey@adacore.com>
 762
 763         * thread.c (print_thread_info): Make "requested_threads" const.
 764         * gdbthread.h (print_thread_info): Make "requested_threads"
 765         const.
 766         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 767         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 768
 769 2019-05-08  Tom Tromey  <tom@tromey.com>
 770
 771         * gdbtypes.c (objfile_type_data): Change type.
 772         (objfile_type, _initialize_gdbtypes): Update.
 773
 774 2019-05-08  Tom Tromey  <tom@tromey.com>
 775
 776         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 777         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 778         (_initialize_dwarf2_frame): Update.
 779
 780 2019-05-08  Tom Tromey  <tom@tromey.com>
 781
 782         * objc-lang.c (objc_objfile_data): Change type.
 783         (find_methods): Update.
 784         (_initialize_objc_lang): Remove.
 785
 786 2019-05-08  Tom Tromey  <tom@tromey.com>
 787
 788         * stabsread.c (rs6000_builtin_type_data): Change type.
 789         (rs6000_builtin_type, _initialize_stabsread): Update.
 790
 791 2019-05-08  Tom Tromey  <tom@tromey.com>
 792
 793         * mips-tdep.c (mips_pdr_data): Remove.
 794         (_initialize_mips_tdep): Update.
 795
 796 2019-05-08  Tom Tromey  <tom@tromey.com>
 797
 798         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 799         (hppa_init_objfile_priv_data, read_unwind_info)
 800         (find_unwind_entry, _initialize_hppa_tdep): Update.
 801
 802 2019-05-08  Tom Tromey  <tom@tromey.com>
 803
 804         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 805         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 806         on obstack.
 807         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 808
 809 2019-05-08  Tom Tromey  <tom@tromey.com>
 810
 811         * mdebugread.c (basic_type_data): Change type.
 812         (basic_type, _initialize_mdebugread): Update.
 813
 814 2019-05-08  Tom Tromey  <tom@tromey.com>
 815
 816         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 817
 818 2019-05-08  Tom Tromey  <tom@tromey.com>
 819
 820         * nto-tdep.c (nto_inferior_data_reg): Change type.
 821         (nto_inferior_data): Update.
 822         (nto_inferior_data_cleanup, nto_new_inferior_data)
 823         (_initialize_nto_tdep): Remove.
 824         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 825
 826 2019-05-08  Tom Tromey  <tom@tromey.com>
 827
 828         * ada-lang.c (struct ada_inferior_data): Add initializers.
 829         (ada_inferior_data): Change type.
 830         (ada_inferior_data_cleanup): Remove.
 831         (get_ada_inferior_data, ada_inferior_exit)
 832         (struct ada_pspace_data): Add initializers, destructor.
 833         (ada_pspace_data_handle): Change type.
 834         (get_ada_pspace_data): Update.
 835         (ada_pspace_data_cleanup): Remove.
 836
 837 2019-05-08  Tom Tromey  <tom@tromey.com>
 838
 839         * coffread.c (struct coff_symfile_info): Add initializers.
 840         (coff_objfile_data_key): Move lower.  Change type.
 841         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 842         Update.
 843         (coff_free_info): Remove.
 844
 845 2019-05-08  Tom Tromey  <tom@tromey.com>
 846
 847         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 848         (fbsd_pspace_data_handle): Move lower.  Change type.
 849         (get_fbsd_pspace_data): Update.
 850         (fbsd_pspace_data_cleanup): Remove.
 851         (_initialize_fbsd_tdep): Update.
 852
 853 2019-05-08  Tom Tromey  <tom@tromey.com>
 854
 855         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 856         (get_ada_tasks_pspace_data): Update.
 857         (ada_tasks_pspace_data_cleanup): Remove.
 858         (_initialize_tasks): Update.
 859         (ada_tasks_inferior_data_handle): Change type.
 860         (get_ada_tasks_inferior_data): Update.
 861         (ada_tasks_inferior_data_cleanup): Remove.
 862         (struct ada_tasks_pspace_data): Add initializers.
 863
 864 2019-05-08  Tom Tromey  <tom@tromey.com>
 865
 866         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 867         * symfile-debug.c (debug_sym_get_probes): Change type.
 868         * stap-probe.c (handle_stap_probe):
 869         (stap_static_probe_ops::get_probes): Change type.
 870         * probe.h (class static_probe_ops) <get_probes>: Change type.
 871         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 872         (parse_probes_in_pspace): Update.
 873         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 874         Update.
 875         (any_static_probe_ops::get_probes): Change type.
 876         * elfread.c (elfread_data): New typedef.
 877         (probe_key): Change type.
 878         (elf_get_probes): Likewise.  Update.
 879         (probe_key_free): Remove.
 880         (_initialize_elfread): Update.
 881         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 882         Change type.
 883         (dtrace_process_dof_probe, dtrace_process_dof)
 884         (dtrace_static_probe_ops::get_probe): Change type.
 885
 886 2019-05-08  Tom Tromey  <tom@tromey.com>
 887
 888         * xcoffread.c (struct xcoff_symfile_info): Rename from
 889         coff_symfile_info.  Add initializers.
 890         (xcoff_objfile_data_key): Move lower.  Change type.
 891         (XCOFF_DATA): Rewrite.
 892         (xcoff_free_info): Remove.
 893         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 894         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 895         (xcoff_initial_scan): Update.
 896
 897 2019-05-08  Tom Tromey  <tom@tromey.com>
 898
 899         * solib-svr4.c (struct svr4_info): Add initializers and
 900         destructor.
 901         <probes_table>: Now an htab_up.
 902         (solib_svr4_pspace_data): Change type.
 903         (free_probes_table): Simplify.
 904         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 905         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 906         (probes_table_remove_objfile_probes, register_solib_event_probe)
 907         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 908         (_initialize_svr4_solib): Update.
 909
 910 2019-05-08  Tom Tromey  <tom@tromey.com>
 911
 912         * remote.c (remote_pspace_data): Change type.
 913         (remote_pspace_data_cleanup): Remove.
 914         (get_remote_exec_file, set_pspace_remote_exec_file)
 915         (_initialize_remote): Update.
 916
 917 2019-05-08  Tom Tromey  <tom@tromey.com>
 918
 919         * breakpoint.c (breakpoint_objfile_key): Change type.
 920         (get_breakpoint_objfile_data): Update.
 921         (free_breakpoint_objfile_data): Remove.
 922         (_initialize_breakpoint): Update.
 923
 924 2019-05-08  Tom Tromey  <tom@tromey.com>
 925
 926         * linux-tdep.c (struct linux_info): Add initializers.
 927         (linux_inferior_data): Move.  Change type.
 928         (invalidate_linux_cache_inf): Update.
 929         (linux_inferior_data_cleanup): Remove.
 930         (get_linux_inferior_data, _initialize_linux_tdep): Update.
 931
 932 2019-05-08  Tom Tromey  <tom@tromey.com>
 933
 934         * auxv.c (auxv_inferior_data): Move.  Change type.
 935         (auxv_inferior_data_cleanup): Remove.
 936         (invalidate_auxv_cache_inf): Rewrite.
 937         (get_auxv_inferior_data, _initialize_auxv): Update.
 938
 939 2019-05-08  Tom Tromey  <tom@tromey.com>
 940
 941         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
 942         (symfile_debug_objfile_data_key): Change type.
 943         (symfile_debug_installed, debug_qf_has_symbols)
 944         (debug_qf_find_last_source_symtab)
 945         (debug_qf_forget_cached_source_info)
 946         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
 947         (debug_qf_print_stats, debug_qf_dump)
 948         (debug_qf_expand_symtabs_for_function)
 949         (debug_qf_expand_all_symtabs)
 950         (debug_qf_expand_symtabs_with_fullname)
 951         (debug_qf_map_matching_symbols)
 952         (debug_qf_expand_symtabs_matching)
 953         (debug_qf_find_pc_sect_compunit_symtab)
 954         (debug_qf_map_symbol_filenames)
 955         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
 956         (debug_sym_new_init, debug_sym_init, debug_sym_read)
 957         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
 958         (debug_sym_read_linetable, debug_sym_relocate): Update.
 959         (symfile_debug_free_objfile): Remove.
 960         (install_symfile_debug_logging, _initialize_symfile_debug):
 961         Update.
 962
 963 2019-05-08  Tom Tromey  <tom@tromey.com>
 964
 965         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
 966         allocate_on_obstack.
 967         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
 968         (get_dwarf2_per_objfile): Update.
 969         (set_dwarf2_per_objfile): Remove.
 970         (dwarf2_has_info, dwarf2_get_section_info): Update.
 971         (dwarf2_free_objfile): Remove.
 972         (_initialize_dwarf2_read): Update.
 973
 974 2019-05-08  Tom Tromey  <tom@tromey.com>
 975
 976         * auto-load.c (struct auto_load_pspace_info): Add destructor and
 977         initializers.
 978         <unsupported_script_warning_printed,
 979         script_not_found_warning_printed>: Now bool.
 980         (auto_load_pspace_data): Change type.
 981         (~auto_load_pspace_info): Rename from
 982         auto_load_pspace_data_cleanup.
 983         (get_auto_load_pspace_data, init_loaded_scripts_info)
 984         (clear_section_scripts, maybe_print_unsupported_script_warning)
 985         (maybe_print_script_not_found_warning, _initialize_auto_load):
 986         Update.
 987
 988 2019-05-08  Tom Tromey  <tom@tromey.com>
 989
 990         * objfiles.c (objfile_pspace_info): Add destructor and
 991         initializers.
 992         (objfiles_pspace_data): Change type.
 993         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
 994         (get_objfile_pspace_data): Update.
 995         (objfiles_bfd_data): Change type.
 996         (get_objfile_bfd_data): Update.
 997         (objfile_bfd_data_free, _initialize_objfiles): Remove.
 998
 999 2019-05-08  Tom Tromey  <tom@tromey.com>
1000
1001         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1002         Change type.
1003         (get_catch_syscall_inferior_data): Update.
1004         (catch_syscall_inferior_data_cleanup): Remove.
1005         (_initialize_break_catch_syscall): Update.
1006
1007 2019-05-08  Tom Tromey  <tom@tromey.com>
1008
1009         * inflow.c (struct terminal_info): Add destructor and
1010         initializers.
1011         (inflow_inferior_data): Change type.
1012         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1013         (get_inflow_inferior_data, inflow_inferior_exit)
1014         (swap_terminal_info, _initialize_inflow): Update.
1015
1016 2019-05-08  Tom Tromey  <tom@tromey.com>
1017
1018         * target-dcache.c (target_dcache_cleanup): Remove.
1019         (target_dcache_aspace_key): Change type.
1020         (target_dcache_init_p, target_dcache_invalidate)
1021         (target_dcache_get, target_dcache_get_or_init)
1022         (_initialize_target_dcache): Update.
1023         * dcache.h (struct dcache_deleter): New.
1024
1025 2019-05-08  Tom Tromey  <tom@tromey.com>
1026
1027         * symtab.c (struct symbol_cache): Add destructor and
1028         initializers.
1029         (symbol_cache_key): Move.  Change type.
1030         (make_symbol_cache, free_symbol_cache): Remove.
1031         (get_symbol_cache): Update.
1032         (symbol_cache_cleanup): Remove.
1033         (ALL_PSPACES, symbol_cache_flush)
1034         (maintenance_print_symbol_cache)
1035         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1036         Update.
1037
1038 2019-05-08  Tom Tromey  <tom@tromey.com>
1039
1040         * symtab.c (struct main_info): Add destructor and initializers.
1041         (main_progspace_key): Move.  Change type.
1042         (get_main_info): Update.
1043         (main_info_cleanup): Remove.
1044         (_initialize_symtab): Update.
1045
1046 2019-05-08  Tom Tromey  <tom@tromey.com>
1047
1048         * registry.h (DECLARE_REGISTRY): Define the _key class.
1049
1050 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1051
1052         * NEWS: Merge two 'New commands' sections.
1053
1054 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1055
1056         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1057         parameter and use Ada language definition instead.
1058         (ada_val_print_ptr): Remove unused language parameter.
1059         (ada_val_print_num): Remove language parameter and use Ada language
1060         definition instead.
1061         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1062         parameter.
1063         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1064         parameter and use Ada language definition instead.
1065         (ada_val_print_1): Update all ada_val_print_xxx calls.
1066         Remove language parameter.
1067         (ada_val_print): Update ada_val_print_1 call.
1068
1069 2019-05-08  Tom Tromey  <tromey@adacore.com>
1070
1071         * remote.c (remote_hw_watchpoint_limit)
1072         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1073         Now static.
1074
1075 2019-05-08  Tom Tromey  <tromey@adacore.com>
1076
1077         * maint.c (_initialize_maint_cmds): Move initialization code to
1078         remote.c.
1079         (watchdog, show_watchdog): Move to remote.c.
1080         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1081         "watchdog" static.
1082         (_initialize_remote): Move initialization code from maint.c.
1083         * defs.h (watchdog): Don't declare.
1084
1085 2019-05-08  Tom Tromey  <tromey@adacore.com>
1086
1087         * tui/tui-interp.c: Include main.h.
1088         * interps.c: Include main.h.
1089         * main.h (interpreter_p): Declare.
1090         * defs.h (interpreter_p): Don't declare.
1091
1092 2019-05-08  Tom Tromey  <tromey@adacore.com>
1093
1094         * dwarf2loc.c: Include dwarf2read.h.
1095         * defs.h (read_unsigned_leb128): Don't declare.
1096         * dwarf2read.h (read_unsigned_leb128): Declare.
1097
1098 2019-05-08  Tom Tromey  <tromey@adacore.com>
1099
1100         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1101         method.
1102
1103 2019-05-08  Tom Tromey  <tromey@adacore.com>
1104
1105         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1106         when no wrap column is set.
1107
1108 2019-05-08  Tom Tromey  <tromey@adacore.com>
1109
1110         * c-lang.c (c_get_string): Handle non-C-style arrays.
1111
1112 2019-05-08  Tom Tromey  <tromey@adacore.com>
1113
1114         * typeprint.c (print_offset_data::update): Print the bit offset,
1115         not the number of bits remaining.
1116
1117 2019-05-08  Tom Tromey  <tromey@adacore.com>
1118
1119         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1120         padding at end of comment.
1121
1122 2019-05-08  Tom Tromey  <tromey@adacore.com>
1123
1124         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1125         Compare main types.
1126
1127 2019-05-06  Tom Tromey  <tom@tromey.com>
1128
1129         * common/scoped_mmap.c: Include common-defs.h.
1130         * common/scoped_mmap.h: Don't include config.h.
1131
1132 2019-05-04  Tom Tromey  <tom@tromey.com>
1133
1134         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1135         (struct aarch64_call_info): Add initializers.
1136         <si>: Now a std::vector.
1137         (pass_on_stack, aarch64_push_dummy_call): Update.
1138
1139 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1140             Tom Tromey  <tom@tromey.com>
1141
1142         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1143         (ppc_threads): Now a std::vector.  Now static.
1144         (hwdebug_find_thread_points_by_tid)
1145         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1146         Update.
1147
1148 2019-05-04  Tom Tromey  <tom@tromey.com>
1149
1150         * arc-tdep.c (arc_tdesc_init): Return bool.
1151
1152 2019-05-04  Tom Tromey  <tom@tromey.com>
1153
1154         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1155         Use gdb_assert_not_reached.
1156
1157 2019-05-04  Tom Tromey  <tom@tromey.com>
1158
1159         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1160         "false".
1161
1162 2019-05-04  Tom Tromey  <tom@tromey.com>
1163
1164         * arc-tdep.c (arc_tdesc_init): Use bool.
1165
1166 2019-05-04  Tom Tromey  <tom@tromey.com>
1167
1168         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1169
1170 2019-05-04  Tom Tromey  <tom@tromey.com>
1171
1172         * cli/cli-cmds.c (valid_command_p): Return bool.
1173
1174 2019-05-04  Tom Tromey  <tom@tromey.com>
1175
1176         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1177         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1178
1179 2019-05-04  Raul Tambre  <raul@tambre.ee>
1180
1181         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1182         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1183         operator for comparison.
1184
1185 2019-05-04  Tom Tromey  <tom@tromey.com>
1186
1187         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1188         (lookup_partial_symbol, print_partial_symbols)
1189         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1190         (psymbol_compare): Update.
1191         (add_psymbol_to_bcache): Clear the entire psymbol.
1192         (maintenance_check_psymtabs): Update.
1193         * psympriv.h (struct partial_symbol): Don't derive from
1194         general_symbol_info.
1195         <obj_section, unrelocated_address, address,
1196         set_unrelocated_address>: Update.
1197         <ginfo>: New member.
1198         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1199         (debug_names::write_psymbols): Update.
1200
1201 2019-05-04  Tom de Vries  <tdevries@suse.de>
1202
1203         * contrib/cc-with-tweaks.sh: Support -n arg.
1204
1205 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1206
1207         * corelow.c (core_target::detach): Ensure frame cache and
1208         register caches are cleared.
1209         inferior.c (exit_inferior_1): Likewise.
1210
1211 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1212             Tom Tromey  <tom@tromey.com>
1213
1214         * dictionary.c (collate_pending_symbols_by_language): Remove
1215         "struct" from foreach.
1216         * symtab.c (lookup_global_symbol_from_objfile)
1217         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1218         foreach.
1219         * ser-tcp.c (net_open): Remove "struct" from foreach.
1220         * objfiles.c (objfile_relocate, objfile_rebase)
1221         (objfile_has_symbols): Remove "struct" from foreach.
1222         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1223         from foreach.
1224         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1225         foreach.
1226         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1227         "struct" from foreach.
1228         * ada-lang.c (create_excep_cond_exprs)
1229         (ada_exception_catchpoint_cond_string): Remove "struct" from
1230         foreach.
1231
1232 2019-05-03  Tom Tromey  <tromey@adacore.com>
1233
1234         * ada-exp.y (convert_char_literal): Check suffix of each
1235         enumerator.
1236
1237 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1238
1239         PR ada/21406:
1240         * ada-exp.y (yywrap): Don't define.
1241         * ada-lex.l (%option): Add noyywrap
1242         (yywrap): Remove.
1243
1244 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1245
1246         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1247         _WIN32_WINNT to the XP level, unless already defined to a higher
1248         level.
1249
1250         * unittests/parse-connection-spec-selftests.c:
1251         * ser-tcp.c:
1252         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1253         override.
1254
1255         * symfile.c (find_separate_debug_file): Remove colon from the
1256         drive spec of DOS/Windows file names of the target, so that the
1257         file name produced from DEBUGDIR and the target's directory will
1258         be valid on DOS/Windows systems.
1259
1260 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1261
1262         * rust-lang.c (val_print_struct): Handle printing structures
1263         containing strings.
1264
1265 2019-05-02  Tom Tromey  <tromey@adacore.com>
1266
1267         * valarith.c (_initialize_valarith): Remove.
1268
1269 2019-05-01  Tom Tromey  <tromey@adacore.com>
1270
1271         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1272         bitfields.
1273
1274 2019-05-01  Tom Tromey  <tromey@adacore.com>
1275
1276         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1277         for big-endian copies.
1278
1279 2019-04-30  Ali Tamur  <tamur@google.com>
1280         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1281         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1282         (read_3_bytes): New function.
1283
1284 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1285
1286         * windows-nat.c (main_thread_id): Delete.
1287         (handle_output_debug_string): Replace main_thread_id by
1288         current_event.dwThreadId.
1289         (fake_create_process): Likewise.
1290         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1291         Do not set main_thread_id.
1292         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1293         current_event.dwThreadId.
1294         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1295
1296 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1297
1298         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1299         Use current_event.dwThreadId instead of main_thread_id.
1300
1301 2019-04-30  Tom Tromey  <tromey@adacore.com>
1302
1303         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1304         (create_excep_cond_exprs): Iterate over program spaces.
1305         (ada_exception_catchpoint_cond_string): Examine all minimal
1306         symbols for exception types.
1307
1308 2019-04-30  Tom Tromey  <tromey@adacore.com>
1309
1310         PR c++/24470:
1311         * dwarf2read.c (process_structure_scope): Handle case where type
1312         has template parameters but no symbol was created.
1313
1314 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1315             Chris January  <chris.january@arm.com>
1316
1317         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1318         qualifier.
1319         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1320
1321 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1322
1323         * f-typeprint.c (f_print_type): Update rules for printing
1324         whitespace.
1325         (f_type_print_varspec_suffix): Likewise.
1326
1327 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1328             Chris January  <chris.january@arm.com>
1329
1330         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1331         function arguments.
1332
1333 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1334
1335         * f-lang.c (build_fortran_types): Change name of void type to
1336         lower case.
1337         * f-typeprint.c (f_type_print_base): Print the name of the void
1338         type, rather than a fixed string.
1339         * f-valprint.c (f_decorations): Use lower case void string.
1340
1341 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1342             Chris January  <chris.january@arm.com>
1343
1344         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1345         types for Fortran.
1346
1347 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1348             Chris January  <chris.january@arm.com>
1349             David Lecomber  <david.lecomber@arm.com>
1350
1351         * f-exp.y (BINOP_INTRINSIC): New token.
1352         (exp): New parser rule handling BINOP_INTRINSIC.
1353         (f77_keywords): Add new builtin procedures.
1354         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1355         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1356         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1357         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1358         (print_unop_subexp_f): New function.
1359         (print_binop_subexp_f): New function.
1360         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1361         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1362         (dump_subexp_body_f): Likewise.
1363         (operator_check_f): Likewise.
1364         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1365         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1366
1367 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1368
1369         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1370         UNOP_KIND.
1371         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1372         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1373         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1374         (operator_length_f): New fuction.
1375         (print_subexp_f): New function.
1376         (op_name_f): New function.
1377         (dump_subexp_body_f): New function.
1378         (operator_check_f): New function.
1379         (exp_descriptor_f): Replace standard expression handling functions
1380         with new functions.
1381         * gdb/fortran-operator.def: New file.
1382         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1383         * gdb/std-operator.def: Remove UNOP_KIND.
1384
1385 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1386
1387         * std-operator.def: Remove unbalanced, stray double quote
1388         character.
1389
1390 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1391             Chris January  <chris.january@arm.com>
1392             Daniel Everett  <daniel.everett@arm.com>
1393             Nick Forrington  <nick.forrington@arm.com>
1394             Richard Bunt  <richard.bunt@arm.com>
1395
1396         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1397         of depth when printing anonymous structs or unions.
1398         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1399         Don't print either the top-level value, or the children if the
1400         max-depth is exceeded.
1401         (ppscm_print_children): When printing the key of a map, allow one
1402         extra level of depth.
1403         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1404         print either the top-level value, or the children if the max-depth
1405         is exceeded.
1406         (print_children): When printing the key of a map, allow one extra
1407         level of depth.
1408         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1409         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1410         (user_print_options): Initialise max_depth field.
1411         (val_print_scalar_or_string_type_p): New function.
1412         (val_print): Check to see if the max depth has been reached.
1413         (val_print_check_max_depth): Define new function.
1414         (show_print_max_depth): New function.
1415         (_initialize_valprint): Add 'print max-depth' option.
1416         * valprint.h (struct value_print_options) <max_depth>: New field.
1417         (val_print_check_max_depth): Declare new function.
1418         * NEWS: Document new feature.
1419
1420 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1421
1422         * ada-lang.c (ada_language_defn): Initialise new field.
1423         * c-lang.c (c_is_string_type_p): New function.
1424         (c_language_defn): Initialise new field.
1425         (cplus_language_defn): Initialise new field.
1426         (asm_language_defn): Initialise new field.
1427         (minimal_language_defn): Initialise new field.
1428         * c-lang.h (c_is_string_type_p): Declare new function.
1429         * d-lang.c (d_language_defn): Initialise new field.
1430         * f-lang.c (f_is_string_type_p): New function.
1431         (f_language_defn): Initialise new field.
1432         * go-lang.c (go_is_string_type_p): New function.
1433         (go_language_defn): Initialise new field.
1434         * language.c (default_is_string_type_p): New function.
1435         (unknown_language_defn): Initialise new field.
1436         (auto_language_defn): Initialise new field.
1437         * language.h (struct language_defn) <la_is_string_type_p>: New
1438         member variable.
1439         (default_is_string_type_p): Declare new function.
1440         * m2-lang.c (m2_language_defn): Initialise new field.
1441         * objc-lang.c (objc_language_defn): Initialise new field.
1442         * opencl-lang.c (opencl_language_defn): Initialise new field.
1443         * p-lang.c (pascal_is_string_type_p): New function.
1444         (pascal_language_defn): Initialise new field.
1445         * rust-lang.c (rust_is_string_type_p): New function.
1446         (rust_language_defn): Initialise new field.
1447
1448 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1449
1450         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1451         New field.
1452         * ada-lang.c (ada_language_defn): Initialise new field.
1453         * c-lang.c (c_language_defn): Likewise.
1454         (cplus_language_defn): Likewise.
1455         (asm_language_defn): Likewise.
1456         (minimal_language_defn): Likewise.
1457         * d-lang.c (d_language_defn): Likewise.
1458         * f-lang.c (f_language_defn): Likewise.
1459         * go-lang.c (go_language_defn): Likewise.
1460         * language.c (unknown_language_defn): Likewise.
1461         (auto_language_defn): Likewise.
1462         * m2-lang.c (m2_language_defn): Likewise.
1463         * objc-lang.c (objc_language_defn): Likewise.
1464         * opencl-lang.c (opencl_language_defn): Likewise.
1465         * p-lang.c (pascal_language_defn): Likewise.
1466         * rust-lang.c (rust_language_defn): Likewise.
1467
1468 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1469
1470         * ada-lang.c (ada_is_character_type): Change return type to bool.
1471         (ada_is_string_type): Likewise.
1472         * ada-lang.h (ada_is_character_type): Update declaration
1473         (ada_is_string_type): Likewise.
1474
1475 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1476
1477         Support style in 'frame|thread apply'
1478
1479         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1480         * record.c (record_start, record_stop): Update callers of
1481         execute_command_to_string with false.
1482         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1483         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1484         methods.
1485         (class string_file): New constructor with term_out parameter.
1486         Override methods term_out and can_emit_style_escape.  New member
1487         term_out.
1488         (class stdio_file): Override can_emit_style_escape.
1489         (class tee_file): Override term_out and can_emit_style_escape.
1490         * utils.h (can_emit_style_escape): Remove.
1491         * utils.c (can_emit_style_escape): Likewise.
1492         Update all callers of can_emit_style_escape (SOMESTREAM) to
1493         SOMESTREAM->can_emit_style_escape.
1494         * source-cache.c (source_cache::get_source_lines): Likewise.
1495         * stack.c (frame_apply_command_count): Call execute_command_to_string
1496         passing the term_out characteristic of the current gdb_stdout.
1497         * thread.c (thr_try_catch_cmd): Likewise.
1498         * top.c (execute_command_to_string): pass term_out parameter
1499         to construct the string_file for the command output.
1500         * ui-file.c (term_cli_styling): New function (most code moved
1501         from utils.c can_emit_style_escape).
1502         (string_file::string_file, string_file::can_emit_style_escape,
1503         stdio_file::can_emit_style_escape, tee_file::term_out,
1504         tee_file::can_emit_style_escape): New functions.
1505
1506 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1507
1508         * NEWS: Mention the new set|show may-call-functions.
1509         * infcall.c (may_call_functions_p): New variable.
1510         (show_may_call_functions_p): New function.
1511         (call_function_by_hand_dummy): Throws an error if not
1512         may-call-functions.
1513         (_initialize_infcall): Call add_setshow_boolean_cmd for
1514         may-call-functions.
1515
1516 2019-04-25  Keith Seitz  <keiths@redhat.com>
1517
1518         PR c++/24367
1519         * cp-support.c (inspect_type): Don't attempt substitutions
1520         of symbol with the same name.
1521
1522 2019-04-25  Tom Tromey  <tromey@adacore.com>
1523
1524         PR gdb/24475:
1525         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1526         static.
1527
1528 2019-04-25  Tom Tromey  <tromey@adacore.com>
1529
1530         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1531         rvalue reference.
1532         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1533         (gdb_xml_parser::parse): Use std::move.
1534         * python/python-internal.h (gdbpy_convert_exception): Take a const
1535         reference.
1536         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1537         std::move.
1538         * python/py-utils.c (gdbpy_convert_exception): Take a const
1539         reference.
1540         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1541         Use std::move.
1542         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1543         Use std::move.
1544         * mi/mi-main.c (mi_print_exception): Take a const reference.
1545         * main.c (handle_command_errors): Take a const reference.
1546         * linespec.c (parse_linespec): Use std::move.
1547         * infcall.c (run_inferior_call): Use std::move.
1548         (call_function_by_hand_dummy): Use std::move.
1549         * exec.c (try_open_exec_file): Use std::move.
1550         * exceptions.h (exception_print, exception_fprintf)
1551         (exception_print_same): Update.
1552         * exceptions.c (print_exception, exception_print)
1553         (exception_fprintf, exception_print_same): Change parameters to
1554         const reference.
1555         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1556         * common/new-op.c: Use std::move.
1557         * common/common-exceptions.h (struct gdb_exception): Add move
1558         constructor.
1559         (struct gdb_exception_error, struct gdb_exception_quit, struct
1560         gdb_quit_bad_alloc): Change constructor to move constructor.
1561         (throw_exception): Change parameter to rvalue reference.
1562         * common/common-exceptions.c (throw_exception): Take rvalue
1563         reference.
1564         * cli/cli-interp.c (safe_execute_command): Use std::move.
1565         * breakpoint.c (insert_bp_location, location_to_sals): Use
1566         std::move.
1567
1568 2019-04-25  Tom Tromey  <tromey@adacore.com>
1569
1570         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1571         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1572         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1573         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1574         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1575         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1576         guile/scm-value.c: Use unpack.
1577         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1578         gdbscm_gdb_exception.
1579         (gdbscm_throw_gdb_exception): Likewise.
1580         (struct gdbscm_gdb_exception): New.
1581         (unpack): New function.
1582         (gdbscm_wrap): Use unpack.
1583
1584 2019-04-25  Tom Tromey  <tromey@adacore.com>
1585
1586         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1587         (gdb_rl_callback_handler): Use std::move.
1588         * common/common-exceptions.h (struct gdb_exception): Add move
1589         assignment operator.
1590         (throw_exception_sjlj): Change "exception" to const reference.
1591         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1592         (throw_exception_sjlj): Change "exception" to const reference.
1593
1594 2019-04-25  Tom Tromey  <tromey@adacore.com>
1595
1596         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1597         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1598         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1599         Update.
1600         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1601         Update.
1602         * mi/mi-interp.c (mi_interp::exec): Update.
1603         * linespec.c (parse_linespec): Update.
1604         * infcall.c (run_inferior_call): Update.
1605         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1606         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1607         (gdbscm_lookup_global_symbol): Update.
1608         * guile/scm-param.c (gdbscm_parameter_value): Update.
1609         * guile/scm-frame.c (gdbscm_frame_read_register)
1610         (gdbscm_frame_read_var): Update.
1611         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1612         * exec.c (try_open_exec_file): Update.
1613         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1614         (gdb_rl_callback_handler): Update.
1615         * common/common-exceptions.h (exception_none): Don't declare.
1616         * common/common-exceptions.c (exception_none): Don't define.
1617         (struct catcher) <exception>: Update.
1618         * cli/cli-interp.c (safe_execute_command): Update.
1619         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1620
1621 2019-04-25  Ali Tamur  <tamur@google.com>
1622
1623         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1624         (read_attribute_value): Likewise.
1625         (dwarf2_read_addr_index): Update comment.
1626         (read_str_index): Add DW_FORM_strx.
1627         (dwarf2_string_attr): Likewise.
1628         (dwarf2_const_value_attr): Likewise.
1629         (dump_die_shallow): Likewise.
1630         (dwarf2_fetch_constant_bytes): Likewise.
1631         (skip_form_bytes): Likewise.
1632         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1633
1634 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1635
1636         PR corefiles/11608
1637         PR corefiles/18187
1638         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1639         OFFSET.  Verify if current mapping contains an ELF header.
1640         (linux_find_memory_regions_full): Adjust call to
1641         dump_mapping_p.
1642
1643 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1644             Kang Li <kanglictf@gmail.com>
1645
1646         PR gdb/21600
1647
1648         * dwarf2-frame.c (read_initial_length): Be consistent about using
1649         unsigned representation of length.
1650         (decode_frame_entry_1): Likewise.  Check for wraparound of
1651         end pointer as well as buffer overflow.
1652
1653 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1654
1655         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1656         "vq".
1657
1658 2019-04-24  Tom Tromey  <tromey@adacore.com>
1659
1660         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1661
1662 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1663
1664         * s12z-tdep.c (s12z_unwind_pc): Delete.
1665         (s12z_unwind_sp): Delete.
1666         (s12z_gdbarch_init): Don't register deleted functions with
1667         gdbarch.
1668
1669 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * rl78-tdep.c (rl78_unwind_sp): Delete.
1672         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1673
1674 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1675
1676         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1677         (xstormy16_unwind_pc): Delete.
1678         (xstormy16_dummy_id): Delete.
1679         (xstormy16_gdbarch_init): Don't register deleted functions with
1680         gdbarch.
1681
1682 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1683
1684         * vax-tdep.c (vax_unwind_pc): Delete.
1685         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1686
1687 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1688
1689         * v850-tdep.c (v850_unwind_sp): Delete.
1690         (v850_unwind_pc): Delete.
1691         (v850_dummy_id): Delete.
1692         (v850_gdbarch_init): Don't register deleted functions with
1693         gdbarch.
1694
1695 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1696
1697         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1698         (tilegx_unwind_pc): Delete.
1699         (tilegx_unwind_dummy_id): Delete.
1700         (tilegx_gdbarch_init): Don't register deleted functions with
1701         gdbarch.
1702
1703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1704
1705         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1706         (tic6x_dummy_id): Delete.
1707         (tic6x_gdbarch_init): Don't register deleted functions with
1708         gdbarch.
1709
1710 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1711
1712         * sparc-tdep.c (sparc_unwind_pc): Delete.
1713         (sparc32_gdbarch_init): Don't register deleted function with
1714         gdbarch.
1715
1716 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1717
1718         * sh-tdep.c (sh_unwind_sp): Delete.
1719         (sh_unwind_pc): Delete.
1720         (sh_dummy_id): Delete.
1721         (sh_gdbarch_init): Don't register deleted functions with
1722         gdbarch.
1723
1724 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1725
1726         * score-tdep.c (score_unwind_sp): Delete.
1727         (score_unwind_pc): Delete.
1728         (score_dummy_id): Delete.
1729         (score_gdbarch_init): Don't register deleted functions with
1730         gdbarch.
1731
1732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1733
1734         * rx-tdep.c (rx_unwind_pc): Delete.
1735         (rx_unwind_sp): Delete.
1736         (rx_dummy_id): Delete.
1737         (rx_gdbarch_init): Don't register deleted functions with
1738         gdbarch.  Update comment.
1739
1740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1741
1742         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1743         (rs6000_dummy_id): Delete.
1744         (rs6000_gdbarch_init): Don't register deleted functions with
1745         gdbarch.
1746
1747 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1748
1749         * or1k-tdep.c (or1k_dummy_id): Delete.
1750         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1751
1752 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1753
1754         * nios2-tdep.c (nios2_dummy_id): Delete.
1755         (nios2_unwind_sp): Delete.
1756         (nios2_gdbarch_init): Don't register deleted functions with
1757         gdbarch.
1758
1759 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1760
1761         * nds32-tdep.c (nds32_dummy_id): Delete.
1762         (nds32_unwind_pc): Delete.
1763         (nds32_unwind_sp): Delete.
1764         (nds32_gdbarch_init): Don't register deleted functions with
1765         gdbarch.
1766
1767 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1768
1769         * msp430-tdep.c (msp430_unwind_pc): Delete.
1770         (msp430_unwind_sp): Delete.
1771         (msp430_dummy_id): Delete.
1772         (msp430_gdbarch_init): Don't register deleted functions with
1773         gdbarch.
1774
1775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1776
1777         * moxie-tdep.c (moxie_unwind_sp): Delete.
1778         (moxie_unwind_pc): Delete.
1779         (moxie_dummy_id): Delete.
1780         (moxie_gdbarch_init): Don't register deleted functions with
1781         gdbarch.
1782
1783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1784
1785         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1786         (mn10300_unwind_pc): Delete.
1787         (mn10300_unwind_sp): Delete.
1788         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1789         mn10300_unwind_sp.
1790         (mn10300_frame_unwind_init): Don't register deleted functions with
1791         gdbarch.
1792
1793 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1794
1795         * mep-tdep.c (mep_unwind_pc): Delete.
1796         (mep_unwind_sp): Delete.
1797         (mep_dummy_id): Delete.
1798         (mep_gdbarch_init): Don't register deleted functions with
1799         gdbarch.
1800
1801 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1802
1803         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1804         (m68hc11_unwind_sp): Delete.
1805         (m68hc11_gdbarch_init): Don't register deleted functions with
1806         gdbarch.
1807
1808 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1809
1810         * m32r-tdep.c (m32r_unwind_sp): Delete.
1811         (m32r_unwind_pc): Delete.
1812         (m32r_dummy_id): Delete.
1813         (m32r_gdbarch_init): Don't register deleted functions with
1814         gdbarch.
1815
1816 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * m32c-tdep.c (m32c_unwind_pc): Delete.
1819         (m32c_unwind_sp): Delete.
1820         (m32c_dummy_id): Delete.
1821         (m32c_gdbarch_init): Don't register deleted functions with
1822         gdbarch.
1823
1824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1825
1826         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1827         (lm32_unwind_pc): Delete.
1828         (lm32_dummy_id): Delete.
1829         (lm32_gdbarch_init): Don't register deleted functions with
1830         gdbarch.
1831
1832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1833
1834         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1835         (iq2000_unwind_pc): Delete.
1836         (iq2000_dummy_id): Delete.
1837         (iq2000_gdbarch_init): Don't register deleted functions with
1838         gdbarch.
1839
1840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1841
1842         * nds32-tdep.c (nds32_type_align): Delete.
1843         (nds32_push_dummy_call): Use type_align instead.
1844
1845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1846
1847         * arm-tdep.c (arm_type_align): Only handle vector override case.
1848         (arm_push_dummy_call): Use type_align.
1849         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1850
1851 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1852
1853         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1854         case.
1855         (pass_on_stack): Use type_align.
1856         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1857         function.
1858
1859 2019-04-23  Tom Tromey  <tromey@adacore.com>
1860
1861         * dwarf2read.c (line_header::file_name_at): Remove unused
1862         overload.
1863
1864 2019-04-23  Tom de Vries  <tdevries@suse.de>
1865
1866         PR gdb/24438
1867         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1868         invocation.
1869
1870
1871 2019-03-27  Ali Tamur  <tamur@google.com>
1872
1873         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1874         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1875         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1876         (dwarf_expr_context::get_addr_index): Likewise
1877         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1878         (symbol_needs_eval_context::get_addr_index): Likewise
1879         (disassemble_dwarf_expression): Add DW_OP_addrx
1880         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1881         (read_cutu_die_from_dwo): Update comment
1882         (skip_one_die): Add DW_FORM_addrx
1883         (read_attribute_value): Likewise
1884         (var_decode_location): Add DW_OP_addrx
1885         (dwarf2_const_value_attr): Add DW_FORM_addrx
1886         (dump_die_shallow): Likewise
1887         (dwarf2_fetch_constant_bytes): Likewise
1888         (decode_locdesc): Add DW_OP_addrx
1889         (skip_form_bytes): Add DW_FORM_addrx
1890
1891 2019-04-22  Ali Tamur  <tamur@google.com>
1892
1893         * MAINTAINERS (Write After Approval): Add self.
1894
1895 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1896
1897         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1898         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1899         (open_symbol_file_object): Likewise.
1900         (svr4_default_sos): Add info parameter.
1901         (svr4_read_so_list): Likewise.
1902         (svr4_current_sos_direct): Adjust functions calls to pass down
1903         info.
1904         (svr4_current_sos_1): Add info parameter.
1905         (svr4_current_sos): Call get_svr4_info, pass info down to
1906         svr4_current_sos_1.
1907         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1908         get_svr4_info.
1909         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1910         get_svr4_info.
1911         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1912         to get_svr4_info.
1913         (probes_table_remove_objfile_probes): Likewise.
1914         (register_solib_event_probe): Add info parameter.
1915         (solist_update_incremental): Pass info parameter down to
1916         svr4_read_so_list.
1917         (disable_probes_interface): Add info parameter.
1918         (svr4_handle_solib_event): Pass current_program_space to
1919         get_svr4_info.  Adjust disable_probes_interface cleanup.
1920         (svr4_create_probe_breakpoints): Add info parameter, pass it
1921         down to register_solib_event_probe.
1922         (svr4_create_solib_event_breakpoints): Add info parameter,
1923         pass it down to svr4_create_probe_breakpoints.
1924         (enable_break): Pass info down to
1925         svr4_create_solib_event_breakpoints.
1926         (svr4_solib_create_inferior_hook): Pass current_program_space to
1927         get_svr4_info.
1928         (svr4_clear_solib): Likewise.
1929
1930 2019-04-22  Pedro Alves  <palves@redhat.com>
1931
1932         * solib-svr4.c (svr4_free_objfile_observer): New.
1933         (probe_and_action::objfile): New field.
1934         (probes_table_htab_remove_objfile_probes)
1935         (probes_table_remove_objfile_probes): New functions.
1936         (register_solib_event_probe): Add 'objfile' parameter.  Store it
1937         in the new probe_and_action.  Don't store the probe in 'lookup'.
1938         (svr4_create_probe_breakpoints): Pass objfile to
1939         register_solib_event_probe.
1940         (_initialize_svr4_solib): Register a free_objfile observer.
1941
1942 2019-04-19  Tom Tromey  <tom@tromey.com>
1943
1944         * common/queue.h: Remove.
1945
1946 2019-04-19  Tom Tromey  <tom@tromey.com>
1947
1948         * event-loop.c: Don't include "common/queue.h".
1949
1950 2019-04-19  Tom Tromey  <tom@tromey.com>
1951
1952         * remote.c (remote_target): Use delete.
1953         * remote-notif.h: Include <list>, not "common/queue.h".
1954         (notif_client_p): Remove typedef.
1955         (remote_notif_state): Add constructor, destructor, initializer.
1956         <notif_queue>: Now a std::list.
1957         (remote_notif_state_xfree): Don't declare.
1958         * remote-notif.c (remote_notif_process, handle_notification)
1959         (remote_notif_state_allocate): Update.
1960         (~remote_notif_state): Rename from remote_notif_state_xfree.
1961
1962 2019-04-19  Tom Tromey  <tom@tromey.com>
1963
1964         * symfile.c (reread_symbols): Update.
1965         * objfiles.c (objfile_register_static_link)
1966         (objfile_lookup_static_link): Update
1967         (~objfile) Don't delete static_links.
1968         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
1969
1970 2019-04-19  Tom Tromey  <tom@tromey.com>
1971
1972         * type-stack.h (struct type_stack) <insert>: Constify string.
1973         * type-stack.c (type_stack::insert): Constify string.
1974         * gdbtypes.h (lookup_template_type): Update.
1975         (address_space_name_to_int): Update.
1976         * gdbtypes.c (address_space_name_to_int): Make space_identifier
1977         const.
1978         (lookup_template_type): Make name const.
1979         * c-exp.y: Update rules.
1980         (lex_one_token, classify_name, classify_inner_name)
1981         (c_print_token): Update.
1982         * p-exp.y: Update rules.
1983         (yylex): Update.
1984         * f-exp.y: Update rules.
1985         (yylex): Update.
1986         * d-exp.y: Update rules.
1987         (lex_one_token, classify_name, classify_inner_name): Update.
1988         * parse.c (write_dollar_variable, copy_name): Return std::string.
1989         * parser-defs.h (copy_name): Change return type.
1990         * m2-exp.y: Update rules.
1991         (yylex): Update.
1992         * go-exp.y (lex_one_token): Update.
1993         Update rules.
1994         (classify_unsafe_function, classify_packaged_name)
1995         (classify_name, yylex): Update.
1996
1997 2019-04-19  Sergei Trofimovich <siarheit@google.com>
1998
1999         * configure.ac: add --enable-source-highlight switch.
2000         * configure: Regenerate.
2001         * top.c (print_gdb_version): plumb --enable-source-highlight
2002         status to "show configuration".
2003
2004 2019-04-19  Tom Tromey  <tromey@adacore.com>
2005
2006         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2007         Check ADA_TYPE_P.
2008         (empty_record, ada_template_to_fixed_record_type_1)
2009         (template_to_static_fixed_type)
2010         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2011         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2012         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2013         macros.
2014
2015 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2016
2017         PR symtab/24423:
2018         * source.c (print_source_lines_base): Advance "iter" when a
2019         control character is seen.
2020
2021 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2022
2023         * inferior.h (struct infcall_suspend_state_deleter):
2024         Catch exception in destructor to avoid crash.
2025
2026 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2027
2028         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2029         close to the add_com "shell".
2030
2031 2019-04-18  Tom Tromey  <tromey@adacore.com>
2032
2033         * process-stratum-target.h (class process_stratum_target)
2034         <stratum>: Add "final".
2035
2036 2019-04-17  Tom Tromey  <tromey@adacore.com>
2037
2038         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2039         against nullptr before use.
2040
2041 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2042
2043         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2044
2045 2019-04-17  Jim Wilson  <jimw@sifive.com>
2046             Andrew Burgess  <andrew.burgess@embecosm.com>
2047
2048         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2049         code read might fail, assume 4-byte breakpoint in that case.
2050
2051 2019-04-15  Leszek Swirski  <leszeks@google.com>
2052
2053         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2054         rather than a hand-rolled POD check when checking for forced MEMORY
2055         classification.
2056
2057 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2058
2059         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2060         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2061         function.
2062         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2063         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2064         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2065         declaration.
2066
2067 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2068
2069         * aarch64-linux-nat.c
2070         (aarch64_linux_nat_target::thread_architecture): Add override.
2071         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2072         each VQ.
2073
2074 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2075
2076         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2077
2078 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2079
2080         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2081         target types of size 96-bits, add some additional comments, and
2082         check that the builtin type we found was the correct size.
2083
2084 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2085
2086         * utils.c (prompt_for_continue): Don't restore the styling at the
2087         end, as applied_style has the wrong value.  This fixes styling in
2088         long lists of file names that are interrupted by the "Continue?"
2089         prompt.
2090
2091 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2092
2093         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2094         * c-lang.c (c_language_defn): Likewise.
2095         (cplus_language_defn): Likewise.
2096         (asm_language_defn): Likewise.
2097         (minimal_language_defn): Likewise.
2098         * d-lang.c (d_language_defn): Likewise.
2099         * f-lang.c (f_language_defn): Likewise.
2100         * go-lang.c (go_language_defn): Likewise.
2101         * language.c (unknown_language_defn): Likewise.
2102         (auto_language_defn): Likewise.
2103         * language.h (struct language_defn): Remove la_magic field.
2104         (LANG_MAGIC): Delete.
2105         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2106         * objc-lang.c (objc_language_defn): Likewise.
2107         * opencl-lang.c (opencl_language_defn): Likewise.
2108         * p-lang.c (pascal_language_defn): Likewise.
2109         * rust-lang.c (rust_language_defn): Likewise.
2110
2111 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2112
2113         * riscv-tdep.c (riscv_type_align): New function.
2114         (riscv_type_alignment): Delete.
2115         (riscv_arg_location): Use 'type_align'.
2116         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2117
2118 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2119
2120         * gdbtypes.c (type_align): A struct with no non-static fields also
2121         has alignment of 1.
2122
2123 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2124
2125         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2126         component to 0.
2127         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2128         member.
2129         (riscv_struct_info::analyse): New implementation using new
2130         analyse_inner member function.
2131         (riscv_struct_info::field_offset): New member function.
2132         (riscv_struct_info::m_offsets): New member variable.
2133         (riscv_struct_info::analyse_inner): New private member function,
2134         takes the old implementation of riscv_struct_info::analyse but
2135         extended to track field offsets.
2136         (riscv_call_arg_struct): Update the struct folding special cases
2137         to handle cases where empty C++ structs, which are non-zero
2138         length, are found.
2139         (riscv_arg_location): Initialise the length of each location, a
2140         non-zero length now indicates the location is in use.
2141         (riscv_push_dummy_call): Allow for the first location having a
2142         non-zero offset when setting up arguments.
2143         (riscv_return_value): Likewise, but for return values.
2144
2145 2019-04-11  Tom Tromey  <tromey@adacore.com>
2146
2147         * utils.c (internal_vproblem): Make "msg" const.
2148
2149 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2150
2151         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2152         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2153         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2154         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2155
2156 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2157
2158         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2159         function.
2160         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2161         of amd64_collect_native_gregset.
2162         (amd64_linux_nat_target::store_registers): Likewise.
2163
2164 2019-04-10  Tom Tromey  <tom@tromey.com>
2165
2166         * symtab.c (lookup_global_symbol_from_objfile)
2167         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2168         * objfiles.h (class separate_debug_iterator): New.
2169         (class separate_debug_range): New.
2170         (struct objfile) <separate_debug_objfiles>: New method.
2171         (objfile_separate_debug_iterate): Don't declare.
2172         * objfiles.c (separate_debug_iterator::operator++): Rename from
2173         objfile_separate_debug_iterate.
2174         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2175         iterator.
2176         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2177         iterator.
2178
2179 2019-04-10  Tom Tromey  <tom@tromey.com>
2180
2181         * symfile.c (reread_symbols): Remove old comment.
2182         * objfiles.c (free_all_objfiles): Fix a typo.
2183
2184 2019-04-10  Tom Tromey  <tom@tromey.com>
2185
2186         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2187         * minsyms.c (lookup_minimal_symbol): Use foreach.
2188         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2189         (lookup_minimal_symbol_solib_trampoline): Likewise.
2190         * symfile.c (reread_symbols): Use foreach.
2191
2192 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2193             Tom Tromey  <tromey@adacore.com>
2194
2195         PR rust/24414:
2196         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2197         (rust_lex_int_test): Change "value" to be LONGEST.
2198         (rust_lex_tests): Add test for long integer literal.
2199
2200 2019-04-09  Tom Tromey  <tromey@adacore.com>
2201
2202         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2203         to bool.
2204         (extended_remote_target::attach): Update.
2205         (remote_target::remote_notice_new_inferior): Update.
2206         (remote_target::add_current_inferior_and_thread): Update.
2207         * inferior.c (exit_inferior_1): Use "false".
2208         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2209
2210 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2211
2212         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2213         the "start" command.
2214
2215 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2216
2217         * python/py-inferior.c (infpy_thread_from_thread_handle):
2218         Adjust comments to reflect renaming of thread_from_thread_handle
2219         to thread_from_handle.  Adjust keywords.  Fix type error message.
2220         (inferior_object_methods): Add thread_from_handle.  Retain
2221         thread_from_thread_handle, but mark it as deprecated.
2222
2223 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2224
2225         * gdbthread.h (find_thread_by_handle): Revise declaration.
2226         * thread.c (find_thread_by_handle): Likewise.  Adjust
2227         implementation too.
2228         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2229         support for buffer objects as handles.
2230
2231 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2232
2233         * python/py-infthread.c (thpy_thread_handle): New function.
2234         (thread_object_methods): Register thpy_thread_handle.
2235
2236 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2237
2238         * gdbthread.h (thread_to_thread_handle): Declare.
2239         * thread.c (gdbtypes.h): Include.
2240         (thread_to_thread_handle): New function.
2241
2242         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2243         (target_thread_info_to_thread_handle): Declare.
2244         * target.c (target_thread_info_to_thread_handle): New function.
2245         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2246         * target-delegates.c: Regenerate.
2247
2248         * linux-thread-db.c (class thread_db_target): Add method
2249         thread_info_to_thread_handle.
2250         (thread_db_target::thread_info_to_thread_handle): Define.
2251         * remote.c (class remote_target): Add new method
2252         thread_info_to_thread_handle.
2253         (remote_target::thread_info_to_thread_handle): Define.
2254
2255 2019-04-08  Pedro Alves  <palves@redhat.com>
2256
2257         * common/common-exceptions.c (throw_exception): Don't create
2258         named object to throw; throw directly.
2259         (throw_it): Likewise.  Don't initialize gdb_exception::message
2260         here, with new; pass FMT and AP to the ctor instead.
2261         * common/common-exceptions.h: Include <string>.
2262         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2263         const char *, va_list)): New ctor.  Use std::make_shared.
2264         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2265         errors)): Delete.
2266         (gdb_exception_error::gdb_exception_error(enum errors, const char
2267         *, va_list)): New.
2268         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2269         Add assertion.
2270         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2271         errors)): Delete.
2272         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2273         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2274         Add assertion.
2275
2276 2019-04-08  Tom Tromey  <tom@tromey.com>
2277
2278         * valops.c (value_rtti_indirect_type): Replace throw_exception
2279         with throw.
2280         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2281         with throw.
2282         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2283         throw.
2284         * target.c (target_translate_tls_address): Replace throw_exception
2285         with throw.
2286         * stack.c (frame_apply_command_count): Replace throw_exception
2287         with throw.
2288         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2289         throw.
2290         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2291         with throw.
2292         * rs6000-tdep.c (rs6000_frame_cache)
2293         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2294         * remote.c: Replace throw_exception with throw.
2295         * record-full.c (record_full_message, record_full_wait_1)
2296         (record_full_restore): Replace throw_exception with throw.
2297         * record-btrace.c:
2298         (get_thread_current_frame_id, record_btrace_start_replaying)
2299         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2300         (cmd_record_btrace_start): Replace throw_exception with throw.
2301         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2302         throw.
2303         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2304         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2305         * linespec.c:
2306         (find_linespec_symbols): Replace throw_exception with throw.
2307         * infrun.c (displaced_step_prepare, resume): Replace
2308         throw_exception with throw.
2309         * infcmd.c (post_create_inferior): Replace throw_exception with
2310         throw.
2311         * inf-loop.c (inferior_event_handler): Replace throw_exception
2312         with throw.
2313         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2314         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2315         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2316         (get_prev_frame_always, get_frame_pc_if_available)
2317         (get_frame_address_in_block_if_available, get_frame_language):
2318         Replace throw_exception with throw.
2319         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2320         throw_exception with throw.
2321         * eval.c (fetch_subexp_value, evaluate_var_value)
2322         (evaluate_funcall, evaluate_subexp_standard): Replace
2323         throw_exception with throw.
2324         * dwarf2loc.c (call_site_find_chain)
2325         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2326         Replace throw_exception with throw.
2327         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2328         with throw.
2329         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2330         throw.
2331         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2332         * completer.c (complete_line_internal): Replace throw_exception
2333         with throw.
2334         * compile/compile-object-run.c (compile_object_run): Replace
2335         throw_exception with throw.
2336         * cli/cli-script.c (process_next_line): Replace throw_exception
2337         with throw.
2338         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2339         (btrace_enable, btrace_maint_update_pt_packets): Replace
2340         throw_exception with throw.
2341         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2342         throw_exception with throw.
2343         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2344         throw_exception with throw.
2345         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2346         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2347         * aarch64-tdep.c (aarch64_make_prologue_cache)
2348         (aarch64_make_stub_cache): Replace throw_exception with throw.
2349
2350 2019-04-08  Tom Tromey  <tom@tromey.com>
2351
2352         * common/common-exceptions.c (throw_exception): Rename from
2353         throw_exception_cxx.  Remove old copy.  Make argument const.
2354         (throw_it): Create and throw exception objects directly.
2355         * common/common-exceptions.h (throw_exception): Make argument
2356         const.
2357         (struct gdb_exception_error): Add constructor.
2358         (struct gdb_exception_quit): Add constructor.
2359
2360 2019-04-08  Tom Tromey  <tom@tromey.com>
2361
2362         * common/common-exceptions.h (exception_rethrow): Don't declare.
2363         (TRY_SJLJ): Update comment.
2364         (TRY, CATCH, END_CATCH): Remove.
2365         * common/common-exceptions.c (exception_rethrow): Remove.
2366
2367 2019-04-08  Tom Tromey  <tom@tromey.com>
2368
2369         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2370         Remove.
2371         (gdb_exception_error): Rename from
2372         gdb_exception_RETURN_MASK_ERROR.
2373         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2374         (gdb_quit_bad_alloc): Update.
2375         * aarch64-tdep.c: Update.
2376         * ada-lang.c: Update.
2377         * ada-typeprint.c: Update.
2378         * ada-valprint.c: Update.
2379         * amd64-tdep.c: Update.
2380         * arch-utils.c: Update.
2381         * break-catch-throw.c: Update.
2382         * breakpoint.c: Update.
2383         * btrace.c: Update.
2384         * c-varobj.c: Update.
2385         * cli/cli-cmds.c: Update.
2386         * cli/cli-interp.c: Update.
2387         * cli/cli-script.c: Update.
2388         * common/common-exceptions.c: Update.
2389         * common/new-op.c: Update.
2390         * common/selftest.c: Update.
2391         * compile/compile-c-symbols.c: Update.
2392         * compile/compile-cplus-symbols.c: Update.
2393         * compile/compile-object-load.c: Update.
2394         * compile/compile-object-run.c: Update.
2395         * completer.c: Update.
2396         * corelow.c: Update.
2397         * cp-abi.c: Update.
2398         * cp-support.c: Update.
2399         * cp-valprint.c: Update.
2400         * darwin-nat.c: Update.
2401         * disasm-selftests.c: Update.
2402         * dtrace-probe.c: Update.
2403         * dwarf-index-cache.c: Update.
2404         * dwarf-index-write.c: Update.
2405         * dwarf2-frame-tailcall.c: Update.
2406         * dwarf2-frame.c: Update.
2407         * dwarf2loc.c: Update.
2408         * dwarf2read.c: Update.
2409         * eval.c: Update.
2410         * event-loop.c: Update.
2411         * event-top.c: Update.
2412         * exec.c: Update.
2413         * f-valprint.c: Update.
2414         * fbsd-tdep.c: Update.
2415         * frame-unwind.c: Update.
2416         * frame.c: Update.
2417         * gdbtypes.c: Update.
2418         * gnu-v3-abi.c: Update.
2419         * guile/guile-internal.h: Update.
2420         * guile/scm-block.c: Update.
2421         * guile/scm-breakpoint.c: Update.
2422         * guile/scm-cmd.c: Update.
2423         * guile/scm-disasm.c: Update.
2424         * guile/scm-frame.c: Update.
2425         * guile/scm-lazy-string.c: Update.
2426         * guile/scm-math.c: Update.
2427         * guile/scm-param.c: Update.
2428         * guile/scm-ports.c: Update.
2429         * guile/scm-pretty-print.c: Update.
2430         * guile/scm-symbol.c: Update.
2431         * guile/scm-symtab.c: Update.
2432         * guile/scm-type.c: Update.
2433         * guile/scm-value.c: Update.
2434         * i386-linux-tdep.c: Update.
2435         * i386-tdep.c: Update.
2436         * inf-loop.c: Update.
2437         * infcall.c: Update.
2438         * infcmd.c: Update.
2439         * infrun.c: Update.
2440         * jit.c: Update.
2441         * language.c: Update.
2442         * linespec.c: Update.
2443         * linux-fork.c: Update.
2444         * linux-nat.c: Update.
2445         * linux-tdep.c: Update.
2446         * linux-thread-db.c: Update.
2447         * main.c: Update.
2448         * mi/mi-cmd-break.c: Update.
2449         * mi/mi-cmd-stack.c: Update.
2450         * mi/mi-interp.c: Update.
2451         * mi/mi-main.c: Update.
2452         * objc-lang.c: Update.
2453         * p-valprint.c: Update.
2454         * parse.c: Update.
2455         * ppc-linux-tdep.c: Update.
2456         * printcmd.c: Update.
2457         * python/py-arch.c: Update.
2458         * python/py-breakpoint.c: Update.
2459         * python/py-cmd.c: Update.
2460         * python/py-finishbreakpoint.c: Update.
2461         * python/py-frame.c: Update.
2462         * python/py-framefilter.c: Update.
2463         * python/py-gdb-readline.c: Update.
2464         * python/py-inferior.c: Update.
2465         * python/py-infthread.c: Update.
2466         * python/py-lazy-string.c: Update.
2467         * python/py-linetable.c: Update.
2468         * python/py-objfile.c: Update.
2469         * python/py-param.c: Update.
2470         * python/py-prettyprint.c: Update.
2471         * python/py-progspace.c: Update.
2472         * python/py-record-btrace.c: Update.
2473         * python/py-record.c: Update.
2474         * python/py-symbol.c: Update.
2475         * python/py-type.c: Update.
2476         * python/py-unwind.c: Update.
2477         * python/py-utils.c: Update.
2478         * python/py-value.c: Update.
2479         * python/python.c: Update.
2480         * record-btrace.c: Update.
2481         * record-full.c: Update.
2482         * remote-fileio.c: Update.
2483         * remote.c: Update.
2484         * riscv-tdep.c: Update.
2485         * rs6000-aix-tdep.c: Update.
2486         * rs6000-tdep.c: Update.
2487         * rust-exp.y: Update.
2488         * rust-lang.c: Update.
2489         * s390-tdep.c: Update.
2490         * selftest-arch.c: Update.
2491         * solib-dsbt.c: Update.
2492         * solib-frv.c: Update.
2493         * solib-spu.c: Update.
2494         * solib-svr4.c: Update.
2495         * solib.c: Update.
2496         * sparc64-linux-tdep.c: Update.
2497         * stack.c: Update.
2498         * symfile-mem.c: Update.
2499         * symmisc.c: Update.
2500         * target.c: Update.
2501         * thread.c: Update.
2502         * top.c: Update.
2503         * tracefile-tfile.c: Update.
2504         * tui/tui.c: Update.
2505         * typeprint.c: Update.
2506         * unittests/cli-utils-selftests.c: Update.
2507         * unittests/parse-connection-spec-selftests.c: Update.
2508         * valops.c: Update.
2509         * valprint.c: Update.
2510         * value.c: Update.
2511         * varobj.c: Update.
2512         * windows-nat.c: Update.
2513         * x86-linux-nat.c: Update.
2514         * xml-support.c: Update.
2515
2516 2019-04-08  Tom Tromey  <tom@tromey.com>
2517
2518         * xml-support.c: Use C++ exception handling.
2519         * x86-linux-nat.c: Use C++ exception handling.
2520         * windows-nat.c: Use C++ exception handling.
2521         * varobj.c: Use C++ exception handling.
2522         * value.c: Use C++ exception handling.
2523         * valprint.c: Use C++ exception handling.
2524         * valops.c: Use C++ exception handling.
2525         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2526         handling.
2527         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2528         * typeprint.c: Use C++ exception handling.
2529         * tui/tui.c: Use C++ exception handling.
2530         * tracefile-tfile.c: Use C++ exception handling.
2531         * top.c: Use C++ exception handling.
2532         * thread.c: Use C++ exception handling.
2533         * target.c: Use C++ exception handling.
2534         * symmisc.c: Use C++ exception handling.
2535         * symfile-mem.c: Use C++ exception handling.
2536         * stack.c: Use C++ exception handling.
2537         * sparc64-linux-tdep.c: Use C++ exception handling.
2538         * solib.c: Use C++ exception handling.
2539         * solib-svr4.c: Use C++ exception handling.
2540         * solib-spu.c: Use C++ exception handling.
2541         * solib-frv.c: Use C++ exception handling.
2542         * solib-dsbt.c: Use C++ exception handling.
2543         * selftest-arch.c: Use C++ exception handling.
2544         * s390-tdep.c: Use C++ exception handling.
2545         * rust-lang.c: Use C++ exception handling.
2546         * rust-exp.y: Use C++ exception handling.
2547         * rs6000-tdep.c: Use C++ exception handling.
2548         * rs6000-aix-tdep.c: Use C++ exception handling.
2549         * riscv-tdep.c: Use C++ exception handling.
2550         * remote.c: Use C++ exception handling.
2551         * remote-fileio.c: Use C++ exception handling.
2552         * record-full.c: Use C++ exception handling.
2553         * record-btrace.c: Use C++ exception handling.
2554         * python/python.c: Use C++ exception handling.
2555         * python/py-value.c: Use C++ exception handling.
2556         * python/py-utils.c: Use C++ exception handling.
2557         * python/py-unwind.c: Use C++ exception handling.
2558         * python/py-type.c: Use C++ exception handling.
2559         * python/py-symbol.c: Use C++ exception handling.
2560         * python/py-record.c: Use C++ exception handling.
2561         * python/py-record-btrace.c: Use C++ exception handling.
2562         * python/py-progspace.c: Use C++ exception handling.
2563         * python/py-prettyprint.c: Use C++ exception handling.
2564         * python/py-param.c: Use C++ exception handling.
2565         * python/py-objfile.c: Use C++ exception handling.
2566         * python/py-linetable.c: Use C++ exception handling.
2567         * python/py-lazy-string.c: Use C++ exception handling.
2568         * python/py-infthread.c: Use C++ exception handling.
2569         * python/py-inferior.c: Use C++ exception handling.
2570         * python/py-gdb-readline.c: Use C++ exception handling.
2571         * python/py-framefilter.c: Use C++ exception handling.
2572         * python/py-frame.c: Use C++ exception handling.
2573         * python/py-finishbreakpoint.c: Use C++ exception handling.
2574         * python/py-cmd.c: Use C++ exception handling.
2575         * python/py-breakpoint.c: Use C++ exception handling.
2576         * python/py-arch.c: Use C++ exception handling.
2577         * printcmd.c: Use C++ exception handling.
2578         * ppc-linux-tdep.c: Use C++ exception handling.
2579         * parse.c: Use C++ exception handling.
2580         * p-valprint.c: Use C++ exception handling.
2581         * objc-lang.c: Use C++ exception handling.
2582         * mi/mi-main.c: Use C++ exception handling.
2583         * mi/mi-interp.c: Use C++ exception handling.
2584         * mi/mi-cmd-stack.c: Use C++ exception handling.
2585         * mi/mi-cmd-break.c: Use C++ exception handling.
2586         * main.c: Use C++ exception handling.
2587         * linux-thread-db.c: Use C++ exception handling.
2588         * linux-tdep.c: Use C++ exception handling.
2589         * linux-nat.c: Use C++ exception handling.
2590         * linux-fork.c: Use C++ exception handling.
2591         * linespec.c: Use C++ exception handling.
2592         * language.c: Use C++ exception handling.
2593         * jit.c: Use C++ exception handling.
2594         * infrun.c: Use C++ exception handling.
2595         * infcmd.c: Use C++ exception handling.
2596         * infcall.c: Use C++ exception handling.
2597         * inf-loop.c: Use C++ exception handling.
2598         * i386-tdep.c: Use C++ exception handling.
2599         * i386-linux-tdep.c: Use C++ exception handling.
2600         * guile/scm-value.c: Use C++ exception handling.
2601         * guile/scm-type.c: Use C++ exception handling.
2602         * guile/scm-symtab.c: Use C++ exception handling.
2603         * guile/scm-symbol.c: Use C++ exception handling.
2604         * guile/scm-pretty-print.c: Use C++ exception handling.
2605         * guile/scm-ports.c: Use C++ exception handling.
2606         * guile/scm-param.c: Use C++ exception handling.
2607         * guile/scm-math.c: Use C++ exception handling.
2608         * guile/scm-lazy-string.c: Use C++ exception handling.
2609         * guile/scm-frame.c: Use C++ exception handling.
2610         * guile/scm-disasm.c: Use C++ exception handling.
2611         * guile/scm-cmd.c: Use C++ exception handling.
2612         * guile/scm-breakpoint.c: Use C++ exception handling.
2613         * guile/scm-block.c: Use C++ exception handling.
2614         * guile/guile-internal.h: Use C++ exception handling.
2615         * gnu-v3-abi.c: Use C++ exception handling.
2616         * gdbtypes.c: Use C++ exception handling.
2617         * frame.c: Use C++ exception handling.
2618         * frame-unwind.c: Use C++ exception handling.
2619         * fbsd-tdep.c: Use C++ exception handling.
2620         * f-valprint.c: Use C++ exception handling.
2621         * exec.c: Use C++ exception handling.
2622         * event-top.c: Use C++ exception handling.
2623         * event-loop.c: Use C++ exception handling.
2624         * eval.c: Use C++ exception handling.
2625         * dwarf2read.c: Use C++ exception handling.
2626         * dwarf2loc.c: Use C++ exception handling.
2627         * dwarf2-frame.c: Use C++ exception handling.
2628         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2629         * dwarf-index-write.c: Use C++ exception handling.
2630         * dwarf-index-cache.c: Use C++ exception handling.
2631         * dtrace-probe.c: Use C++ exception handling.
2632         * disasm-selftests.c: Use C++ exception handling.
2633         * darwin-nat.c: Use C++ exception handling.
2634         * cp-valprint.c: Use C++ exception handling.
2635         * cp-support.c: Use C++ exception handling.
2636         * cp-abi.c: Use C++ exception handling.
2637         * corelow.c: Use C++ exception handling.
2638         * completer.c: Use C++ exception handling.
2639         * compile/compile-object-run.c: Use C++ exception handling.
2640         * compile/compile-object-load.c: Use C++ exception handling.
2641         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2642         * compile/compile-c-symbols.c: Use C++ exception handling.
2643         * common/selftest.c: Use C++ exception handling.
2644         * common/new-op.c: Use C++ exception handling.
2645         * cli/cli-script.c: Use C++ exception handling.
2646         * cli/cli-interp.c: Use C++ exception handling.
2647         * cli/cli-cmds.c: Use C++ exception handling.
2648         * c-varobj.c: Use C++ exception handling.
2649         * btrace.c: Use C++ exception handling.
2650         * breakpoint.c: Use C++ exception handling.
2651         * break-catch-throw.c: Use C++ exception handling.
2652         * arch-utils.c: Use C++ exception handling.
2653         * amd64-tdep.c: Use C++ exception handling.
2654         * ada-valprint.c: Use C++ exception handling.
2655         * ada-typeprint.c: Use C++ exception handling.
2656         * ada-lang.c: Use C++ exception handling.
2657         * aarch64-tdep.c: Use C++ exception handling.
2658
2659 2019-04-08  Tom Tromey  <tom@tromey.com>
2660
2661         * xml-support.c (gdb_xml_parser::parse): Update.
2662         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2663         * value.c (show_convenience): Update.
2664         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2665         (test_parse_flags_qcs): Update.
2666         * thread.c (thr_try_catch_cmd): Update.
2667         * target.c (target_translate_tls_address): Update.
2668         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2669         (info_frame_command_core, frame_apply_command_count): Update.
2670         * rust-exp.y (rust_lex_exception_test): Update.
2671         * riscv-tdep.c (riscv_print_one_register_info): Update.
2672         * remote.c (remote_target::enable_btrace): Update.
2673         * record-btrace.c (record_btrace_enable_warn): Update.
2674         * python/py-utils.c (gdbpy_convert_exception): Update.
2675         * printcmd.c (do_one_display, print_variable_and_value): Update.
2676         * mi/mi-main.c (mi_print_exception): Update.
2677         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2678         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2679         * linux-nat.c (linux_nat_target::attach): Update.
2680         * linux-fork.c (class scoped_switch_fork_info): Update.
2681         * infrun.c (displaced_step_prepare): Update.
2682         * infcall.c (call_function_by_hand_dummy): Update.
2683         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2684         * gnu-v3-abi.c (print_one_vtable): Update.
2685         * frame.c (get_prev_frame_always): Update.
2686         * f-valprint.c (info_common_command_for_block): Update.
2687         * exec.c (try_open_exec_file): Update.
2688         * exceptions.c (print_exception, exception_print)
2689         (exception_fprintf, exception_print_same): Update.
2690         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2691         * dwarf-index-cache.c (index_cache::store)
2692         (index_cache::lookup_gdb_index): Update.
2693         * darwin-nat.c (maybe_cache_shell): Update.
2694         * cp-valprint.c (cp_print_value_fields): Update.
2695         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2696         (gcc_cplus_symbol_address): Update.
2697         * compile/compile-c-symbols.c (gcc_convert_symbol)
2698         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2699         * common/selftest.c: Update.
2700         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2701         a std::string.
2702         (exception_try_scope_entry, exception_try_scope_exit): Don't
2703         declare.
2704         (struct exception_try_scope): Remove.
2705         (TRY): Don't use exception_try_scope.
2706         (struct gdb_exception): Add constructor, operator=.
2707         <what>: New method.
2708         (struct gdb_exception_RETURN_MASK_ALL)
2709         (struct gdb_exception_RETURN_MASK_ERROR)
2710         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2711         (struct gdb_quit_bad_alloc): Update.
2712         * common/common-exceptions.c (exception_none): Change
2713         initializer.
2714         (struct catcher) <state, exception>: Initialize inline.
2715         <prev>: Remove member.
2716         (current_catcher): Remove.
2717         (catchers): New global.
2718         (exceptions_state_mc_init): Simplify.
2719         (catcher_pop): Remove.
2720         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2721         (try_scope_depth, exception_try_scope_entry)
2722         (exception_try_scope_exit): Remove.
2723         (throw_exception_sjlj): Update.
2724         (exception_messages, exception_messages_size): Remove.
2725         (throw_it): Simplify.
2726         (gdb_exception_sliced_copy): Remove.
2727         (throw_exception_cxx): Update.
2728         * cli/cli-script.c (script_from_file): Update.
2729         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2730         Update.
2731         * ada-valprint.c (ada_val_print): Update.
2732         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2733         (create_excep_cond_exprs): Update.
2734
2735 2019-04-08  Tom Tromey  <tom@tromey.com>
2736
2737         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2738         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2739         (TRY, CATCH, END_CATCH): Remove some definitions.
2740         * common/common-exceptions.c: Don't use GDB_XCPT.
2741         (catcher_list_size): Remove.
2742         (throw_exception, throw_it): Simplify.
2743
2744 2019-04-05  Tom Tromey  <tom@tromey.com>
2745
2746         Revert the header-sorting patch.
2747         * ft32-tdep.c: Revert.
2748         * frv-tdep.c: Revert.
2749         * frv-linux-tdep.c: Revert.
2750         * frame.c: Revert.
2751         * frame-unwind.c: Revert.
2752         * frame-base.c: Revert.
2753         * fork-child.c: Revert.
2754         * findvar.c: Revert.
2755         * findcmd.c: Revert.
2756         * filesystem.c: Revert.
2757         * filename-seen-cache.h: Revert.
2758         * filename-seen-cache.c: Revert.
2759         * fbsd-tdep.c: Revert.
2760         * fbsd-nat.h: Revert.
2761         * fbsd-nat.c: Revert.
2762         * f-valprint.c: Revert.
2763         * f-typeprint.c: Revert.
2764         * f-lang.c: Revert.
2765         * extension.h: Revert.
2766         * extension.c: Revert.
2767         * extension-priv.h: Revert.
2768         * expprint.c: Revert.
2769         * exec.h: Revert.
2770         * exec.c: Revert.
2771         * exceptions.c: Revert.
2772         * event-top.c: Revert.
2773         * event-loop.c: Revert.
2774         * eval.c: Revert.
2775         * elfread.c: Revert.
2776         * dwarf2read.h: Revert.
2777         * dwarf2read.c: Revert.
2778         * dwarf2loc.c: Revert.
2779         * dwarf2expr.h: Revert.
2780         * dwarf2expr.c: Revert.
2781         * dwarf2-frame.c: Revert.
2782         * dwarf2-frame-tailcall.c: Revert.
2783         * dwarf-index-write.h: Revert.
2784         * dwarf-index-write.c: Revert.
2785         * dwarf-index-common.c: Revert.
2786         * dwarf-index-cache.h: Revert.
2787         * dwarf-index-cache.c: Revert.
2788         * dummy-frame.c: Revert.
2789         * dtrace-probe.c: Revert.
2790         * disasm.h: Revert.
2791         * disasm.c: Revert.
2792         * disasm-selftests.c: Revert.
2793         * dictionary.c: Revert.
2794         * dicos-tdep.c: Revert.
2795         * demangle.c: Revert.
2796         * dcache.h: Revert.
2797         * dcache.c: Revert.
2798         * darwin-nat.h: Revert.
2799         * darwin-nat.c: Revert.
2800         * darwin-nat-info.c: Revert.
2801         * d-valprint.c: Revert.
2802         * d-namespace.c: Revert.
2803         * d-lang.c: Revert.
2804         * ctf.c: Revert.
2805         * csky-tdep.c: Revert.
2806         * csky-linux-tdep.c: Revert.
2807         * cris-tdep.c: Revert.
2808         * cris-linux-tdep.c: Revert.
2809         * cp-valprint.c: Revert.
2810         * cp-support.c: Revert.
2811         * cp-namespace.c: Revert.
2812         * cp-abi.c: Revert.
2813         * corelow.c: Revert.
2814         * corefile.c: Revert.
2815         * continuations.c: Revert.
2816         * completer.h: Revert.
2817         * completer.c: Revert.
2818         * complaints.c: Revert.
2819         * coffread.c: Revert.
2820         * coff-pe-read.c: Revert.
2821         * cli-out.h: Revert.
2822         * cli-out.c: Revert.
2823         * charset.c: Revert.
2824         * c-varobj.c: Revert.
2825         * c-valprint.c: Revert.
2826         * c-typeprint.c: Revert.
2827         * c-lang.c: Revert.
2828         * buildsym.c: Revert.
2829         * buildsym-legacy.c: Revert.
2830         * build-id.h: Revert.
2831         * build-id.c: Revert.
2832         * btrace.c: Revert.
2833         * bsd-uthread.c: Revert.
2834         * breakpoint.h: Revert.
2835         * breakpoint.c: Revert.
2836         * break-catch-throw.c: Revert.
2837         * break-catch-syscall.c: Revert.
2838         * break-catch-sig.c: Revert.
2839         * blockframe.c: Revert.
2840         * block.c: Revert.
2841         * bfin-tdep.c: Revert.
2842         * bfin-linux-tdep.c: Revert.
2843         * bfd-target.c: Revert.
2844         * bcache.c: Revert.
2845         * ax-general.c: Revert.
2846         * ax-gdb.h: Revert.
2847         * ax-gdb.c: Revert.
2848         * avr-tdep.c: Revert.
2849         * auxv.c: Revert.
2850         * auto-load.c: Revert.
2851         * arm-wince-tdep.c: Revert.
2852         * arm-tdep.c: Revert.
2853         * arm-symbian-tdep.c: Revert.
2854         * arm-pikeos-tdep.c: Revert.
2855         * arm-obsd-tdep.c: Revert.
2856         * arm-nbsd-tdep.c: Revert.
2857         * arm-nbsd-nat.c: Revert.
2858         * arm-linux-tdep.c: Revert.
2859         * arm-linux-nat.c: Revert.
2860         * arm-fbsd-tdep.c: Revert.
2861         * arm-fbsd-nat.c: Revert.
2862         * arm-bsd-tdep.c: Revert.
2863         * arch-utils.c: Revert.
2864         * arc-tdep.c: Revert.
2865         * arc-newlib-tdep.c: Revert.
2866         * annotate.h: Revert.
2867         * annotate.c: Revert.
2868         * amd64-windows-tdep.c: Revert.
2869         * amd64-windows-nat.c: Revert.
2870         * amd64-tdep.c: Revert.
2871         * amd64-sol2-tdep.c: Revert.
2872         * amd64-obsd-tdep.c: Revert.
2873         * amd64-obsd-nat.c: Revert.
2874         * amd64-nbsd-tdep.c: Revert.
2875         * amd64-nbsd-nat.c: Revert.
2876         * amd64-nat.c: Revert.
2877         * amd64-linux-tdep.c: Revert.
2878         * amd64-linux-nat.c: Revert.
2879         * amd64-fbsd-tdep.c: Revert.
2880         * amd64-fbsd-nat.c: Revert.
2881         * amd64-dicos-tdep.c: Revert.
2882         * amd64-darwin-tdep.c: Revert.
2883         * amd64-bsd-nat.c: Revert.
2884         * alpha-tdep.c: Revert.
2885         * alpha-obsd-tdep.c: Revert.
2886         * alpha-nbsd-tdep.c: Revert.
2887         * alpha-mdebug-tdep.c: Revert.
2888         * alpha-linux-tdep.c: Revert.
2889         * alpha-linux-nat.c: Revert.
2890         * alpha-bsd-tdep.c: Revert.
2891         * alpha-bsd-nat.c: Revert.
2892         * aix-thread.c: Revert.
2893         * agent.c: Revert.
2894         * addrmap.c: Revert.
2895         * ada-varobj.c: Revert.
2896         * ada-valprint.c: Revert.
2897         * ada-typeprint.c: Revert.
2898         * ada-tasks.c: Revert.
2899         * ada-lang.c: Revert.
2900         * aarch64-tdep.c: Revert.
2901         * aarch64-ravenscar-thread.c: Revert.
2902         * aarch64-newlib-tdep.c: Revert.
2903         * aarch64-linux-tdep.c: Revert.
2904         * aarch64-linux-nat.c: Revert.
2905         * aarch64-fbsd-tdep.c: Revert.
2906         * aarch64-fbsd-nat.c: Revert.
2907         * aarch32-linux-nat.c: Revert.
2908
2909 2019-04-05  Tom Tromey  <tom@tromey.com>
2910
2911         * ft32-tdep.c: Sort headers.
2912         * frv-tdep.c: Sort headers.
2913         * frv-linux-tdep.c: Sort headers.
2914         * frame.c: Sort headers.
2915         * frame-unwind.c: Sort headers.
2916         * frame-base.c: Sort headers.
2917         * fork-child.c: Sort headers.
2918         * findvar.c: Sort headers.
2919         * findcmd.c: Sort headers.
2920         * filesystem.c: Sort headers.
2921         * filename-seen-cache.h: Sort headers.
2922         * filename-seen-cache.c: Sort headers.
2923         * fbsd-tdep.c: Sort headers.
2924         * fbsd-nat.h: Sort headers.
2925         * fbsd-nat.c: Sort headers.
2926         * f-valprint.c: Sort headers.
2927         * f-typeprint.c: Sort headers.
2928         * f-lang.c: Sort headers.
2929         * extension.h: Sort headers.
2930         * extension.c: Sort headers.
2931         * extension-priv.h: Sort headers.
2932         * expprint.c: Sort headers.
2933         * exec.h: Sort headers.
2934         * exec.c: Sort headers.
2935         * exceptions.c: Sort headers.
2936         * event-top.c: Sort headers.
2937         * event-loop.c: Sort headers.
2938         * eval.c: Sort headers.
2939         * elfread.c: Sort headers.
2940         * dwarf2read.h: Sort headers.
2941         * dwarf2read.c: Sort headers.
2942         * dwarf2loc.c: Sort headers.
2943         * dwarf2expr.h: Sort headers.
2944         * dwarf2expr.c: Sort headers.
2945         * dwarf2-frame.c: Sort headers.
2946         * dwarf2-frame-tailcall.c: Sort headers.
2947         * dwarf-index-write.h: Sort headers.
2948         * dwarf-index-write.c: Sort headers.
2949         * dwarf-index-common.c: Sort headers.
2950         * dwarf-index-cache.h: Sort headers.
2951         * dwarf-index-cache.c: Sort headers.
2952         * dummy-frame.c: Sort headers.
2953         * dtrace-probe.c: Sort headers.
2954         * disasm.h: Sort headers.
2955         * disasm.c: Sort headers.
2956         * disasm-selftests.c: Sort headers.
2957         * dictionary.c: Sort headers.
2958         * dicos-tdep.c: Sort headers.
2959         * demangle.c: Sort headers.
2960         * dcache.h: Sort headers.
2961         * dcache.c: Sort headers.
2962         * darwin-nat.h: Sort headers.
2963         * darwin-nat.c: Sort headers.
2964         * darwin-nat-info.c: Sort headers.
2965         * d-valprint.c: Sort headers.
2966         * d-namespace.c: Sort headers.
2967         * d-lang.c: Sort headers.
2968         * ctf.c: Sort headers.
2969         * csky-tdep.c: Sort headers.
2970         * csky-linux-tdep.c: Sort headers.
2971         * cris-tdep.c: Sort headers.
2972         * cris-linux-tdep.c: Sort headers.
2973         * cp-valprint.c: Sort headers.
2974         * cp-support.c: Sort headers.
2975         * cp-namespace.c: Sort headers.
2976         * cp-abi.c: Sort headers.
2977         * corelow.c: Sort headers.
2978         * corefile.c: Sort headers.
2979         * continuations.c: Sort headers.
2980         * completer.h: Sort headers.
2981         * completer.c: Sort headers.
2982         * complaints.c: Sort headers.
2983         * coffread.c: Sort headers.
2984         * coff-pe-read.c: Sort headers.
2985         * cli-out.h: Sort headers.
2986         * cli-out.c: Sort headers.
2987         * charset.c: Sort headers.
2988         * c-varobj.c: Sort headers.
2989         * c-valprint.c: Sort headers.
2990         * c-typeprint.c: Sort headers.
2991         * c-lang.c: Sort headers.
2992         * buildsym.c: Sort headers.
2993         * buildsym-legacy.c: Sort headers.
2994         * build-id.h: Sort headers.
2995         * build-id.c: Sort headers.
2996         * btrace.c: Sort headers.
2997         * bsd-uthread.c: Sort headers.
2998         * breakpoint.h: Sort headers.
2999         * breakpoint.c: Sort headers.
3000         * break-catch-throw.c: Sort headers.
3001         * break-catch-syscall.c: Sort headers.
3002         * break-catch-sig.c: Sort headers.
3003         * blockframe.c: Sort headers.
3004         * block.c: Sort headers.
3005         * bfin-tdep.c: Sort headers.
3006         * bfin-linux-tdep.c: Sort headers.
3007         * bfd-target.c: Sort headers.
3008         * bcache.c: Sort headers.
3009         * ax-general.c: Sort headers.
3010         * ax-gdb.h: Sort headers.
3011         * ax-gdb.c: Sort headers.
3012         * avr-tdep.c: Sort headers.
3013         * auxv.c: Sort headers.
3014         * auto-load.c: Sort headers.
3015         * arm-wince-tdep.c: Sort headers.
3016         * arm-tdep.c: Sort headers.
3017         * arm-symbian-tdep.c: Sort headers.
3018         * arm-pikeos-tdep.c: Sort headers.
3019         * arm-obsd-tdep.c: Sort headers.
3020         * arm-nbsd-tdep.c: Sort headers.
3021         * arm-nbsd-nat.c: Sort headers.
3022         * arm-linux-tdep.c: Sort headers.
3023         * arm-linux-nat.c: Sort headers.
3024         * arm-fbsd-tdep.c: Sort headers.
3025         * arm-fbsd-nat.c: Sort headers.
3026         * arm-bsd-tdep.c: Sort headers.
3027         * arch-utils.c: Sort headers.
3028         * arc-tdep.c: Sort headers.
3029         * arc-newlib-tdep.c: Sort headers.
3030         * annotate.h: Sort headers.
3031         * annotate.c: Sort headers.
3032         * amd64-windows-tdep.c: Sort headers.
3033         * amd64-windows-nat.c: Sort headers.
3034         * amd64-tdep.c: Sort headers.
3035         * amd64-sol2-tdep.c: Sort headers.
3036         * amd64-obsd-tdep.c: Sort headers.
3037         * amd64-obsd-nat.c: Sort headers.
3038         * amd64-nbsd-tdep.c: Sort headers.
3039         * amd64-nbsd-nat.c: Sort headers.
3040         * amd64-nat.c: Sort headers.
3041         * amd64-linux-tdep.c: Sort headers.
3042         * amd64-linux-nat.c: Sort headers.
3043         * amd64-fbsd-tdep.c: Sort headers.
3044         * amd64-fbsd-nat.c: Sort headers.
3045         * amd64-dicos-tdep.c: Sort headers.
3046         * amd64-darwin-tdep.c: Sort headers.
3047         * amd64-bsd-nat.c: Sort headers.
3048         * alpha-tdep.c: Sort headers.
3049         * alpha-obsd-tdep.c: Sort headers.
3050         * alpha-nbsd-tdep.c: Sort headers.
3051         * alpha-mdebug-tdep.c: Sort headers.
3052         * alpha-linux-tdep.c: Sort headers.
3053         * alpha-linux-nat.c: Sort headers.
3054         * alpha-bsd-tdep.c: Sort headers.
3055         * alpha-bsd-nat.c: Sort headers.
3056         * aix-thread.c: Sort headers.
3057         * agent.c: Sort headers.
3058         * addrmap.c: Sort headers.
3059         * ada-varobj.c: Sort headers.
3060         * ada-valprint.c: Sort headers.
3061         * ada-typeprint.c: Sort headers.
3062         * ada-tasks.c: Sort headers.
3063         * ada-lang.c: Sort headers.
3064         * aarch64-tdep.c: Sort headers.
3065         * aarch64-ravenscar-thread.c: Sort headers.
3066         * aarch64-newlib-tdep.c: Sort headers.
3067         * aarch64-linux-tdep.c: Sort headers.
3068         * aarch64-linux-nat.c: Sort headers.
3069         * aarch64-fbsd-tdep.c: Sort headers.
3070         * aarch64-fbsd-nat.c: Sort headers.
3071         * aarch32-linux-nat.c: Sort headers.
3072
3073 2019-04-04  Tom Tromey  <tom@tromey.com>
3074
3075         * varobj.c (varobj_create): Update.
3076         * rust-exp.y (struct rust_parser) <update_innermost_block,
3077         lookup_symbol>: New methods.
3078         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3079         Rename.
3080         (rust_parser::rust_lookup_type)
3081         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3082         * printcmd.c (display_command, do_one_display): Update.
3083         * parser-defs.h (struct parser_state) <parser_state>: Add
3084         "tracker" parameter.
3085         (block_tracker): New member.
3086         (class innermost_block_tracker) <innermost_block_tracker>: Add
3087         "types" parameter.
3088         <reset>: Remove method.
3089         (innermost_block): Don't declare.
3090         (null_post_parser): Update.
3091         * parse.c (innermost_block): Remove global.
3092         (write_dollar_variable): Update.
3093         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3094         Remove "tracker_types" parameter.
3095         (parse_expression): Add "tracker" parameter.
3096         (parse_expression_for_completion): Update.
3097         (null_post_parser): Add "tracker" parameter.
3098         * p-exp.y: Update rules.
3099         * m2-exp.y: Update rules.
3100         * language.h (struct language_defn) <la_post_parser>: Add
3101         "tracker" parameter.
3102         * go-exp.y: Update rules.
3103         * f-exp.y: Update rules.
3104         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3105         parameter.
3106         * d-exp.y: Update rules.
3107         * c-exp.y: Update rules.
3108         * breakpoint.c (set_breakpoint_condition): Create an
3109         innermost_block_tracker.
3110         (watch_command_1): Likewise.
3111         * ada-lang.c (resolve): Add "tracker" parameter.
3112         (resolve_subexp): Likewise.
3113         * ada-exp.y (write_var_from_sym): Update.
3114
3115 2019-04-04  Tom Tromey  <tom@tromey.com>
3116
3117         * type-stack.h: New file.
3118         * type-stack.c: New file.
3119         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3120         type-stack.h.
3121         (insert_into_type_stack, insert_type, push_type, push_type_int)
3122         (insert_type_address_space, pop_type, pop_type_int)
3123         (pop_typelist, pop_type_stack, append_type_stack)
3124         (push_type_stack, get_type_stack, push_typelist)
3125         (follow_type_instance_flags, follow_types): Don't declare.
3126         * parse.c (type_stack): Remove global.
3127         (parse_exp_in_context): Update.
3128         (insert_into_type_stack, insert_type, push_type, push_type_int)
3129         (insert_type_address_space, pop_type, pop_type_int)
3130         (pop_typelist, pop_type_stack, append_type_stack)
3131         (push_type_stack, get_type_stack, push_typelist)
3132         (follow_type_instance_flags, follow_types): Remove (moved to
3133         type-stack.c).
3134         * f-exp.y (type_stack): New global.
3135         Update rules.
3136         (push_kind_type, f_parse): Update.
3137         * d-exp.y (type_stack): New global.
3138         Update rules.
3139         (d_parse): Update.
3140         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3141         Update rules.
3142         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3143         (HFILES_NO_SRCDIR): Add type-stack.h.
3144
3145 2019-04-04  Tom Tromey  <tom@tromey.com>
3146
3147         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3148         (rust_parser::convert_ast_to_expression, rust_parse)
3149         (rust_lex_test_completion, rust_lex_tests): Update.
3150         * parser-defs.h (struct expr_completion_state): New.
3151         (struct parser_state) <parser_state>: Add completion parameter.
3152         <mark_struct_expression, mark_completion_tag>: New methods.
3153         <parse_completion, m_completion_state>: New members.
3154         (prefixify_expression, null_post_parser): Update.
3155         (mark_struct_expression, mark_completion_tag): Don't declare.
3156         * parse.c (parse_completion, expout_last_struct)
3157         (expout_tag_completion_type, expout_completion_name): Remove
3158         globals.
3159         (parser_state::mark_struct_expression)
3160         (parser_state::mark_completion_tag): Now methods.
3161         (prefixify_expression): Add last_struct parameter.
3162         (prefixify_subexp): Likewise.
3163         (parse_exp_1): Update.
3164         (parse_exp_in_context): Add cstate parameter.  Update.
3165         (parse_expression_for_completion): Create an
3166         expr_completion_state.
3167         (null_post_parser): Add "completion" parameter.
3168         * p-exp.y: Update rules.
3169         (yylex): Update.
3170         * language.h (struct language_defn) <la_post_parser>: Add
3171         "completing" parameter.
3172         * go-exp.y: Update rules.
3173         (lex_one_token): Update.
3174         * expression.h (parse_completion): Don't declare.
3175         * d-exp.y: Update rules.
3176         (lex_one_token): Update rules.
3177         * c-exp.y: Update rules.
3178         (lex_one_token): Update.
3179         * ada-lang.c (resolve): Add "parse_completion" parameter.
3180         (resolve_subexp): Likewise.
3181         (ada_resolve_function): Likewise.
3182
3183 2019-04-04  Tom Tromey  <tom@tromey.com>
3184
3185         * parser-defs.h (struct parser_state) <start_arglist,
3186         end_arglist>: New methods.
3187         <arglist_len, m_funcall_chain>: New members.
3188         (arglist_len, start_arglist, end_arglist): Don't declare.
3189         * parse.c (arglist_len, funcall_chain): Remove global.
3190         (start_arglist, end_arglist): Remove functions.
3191         (parse_exp_in_context): Update.
3192         * p-exp.y: Update rules.
3193         * m2-exp.y: Update rules.
3194         * go-exp.y: Update rules.
3195         * f-exp.y: Update rules.
3196         * d-exp.y: Update rules.
3197         * c-exp.y: Update rules.
3198
3199 2019-04-04  Tom Tromey  <tom@tromey.com>
3200
3201         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3202         lex_operator, push_back>: New methods.
3203         Update all rules.
3204         (rust_parser::lex_hex, lex_escape): Rename and update.
3205         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3206         (rust_parser::lex_operator): Rename and update.
3207         (rust_parser::lex_number, rustyylex, rustyyerror)
3208         (rust_lex_test_init, rust_lex_test_sequence)
3209         (rust_lex_test_push_back, rust_lex_tests): Update.
3210         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3211         parameter.
3212         <lexptr, prev_lexptr>: New members.
3213         (lexptr, prev_lexptr): Don't declare.
3214         * parse.c (lexptr, prev_lexptr): Remove globals.
3215         (parse_exp_in_context): Update.
3216         * p-exp.y (yylex, yyerror): Update.
3217         * m2-exp.y (parse_number, yylex, yyerror): Update.
3218         * go-exp.y (lex_one_token, yyerror): Update.
3219         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3220         * d-exp.y (lex_one_token, yyerror): Update.
3221         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3222         (lex_one_token, yyerror): Update.
3223         * ada-lex.l (YY_INPUT): Update.
3224         (rewind_to_char): Update.
3225         * ada-exp.y (yyerror): Update.
3226
3227 2019-04-04  Tom Tromey  <tom@tromey.com>
3228
3229         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3230         * parser-defs.h (struct parser_state) <parser_state>: Add new
3231         parameter.
3232         <comma_terminates>: New member.
3233         (comma_terminates): Don't declare global.
3234         * parse.c (comma_terminates): Remove global.
3235         (parse_exp_in_context): Update.
3236         * p-exp.y (yylex): Update.
3237         * m2-exp.y (yylex): Update.
3238         * go-exp.y (lex_one_token): Update.
3239         * f-exp.y (yylex): Update.
3240         * d-exp.y (lex_one_token): Update.
3241         * c-exp.y (lex_one_token): Update.
3242         * ada-lex.l: Update.
3243
3244 2019-04-04  Tom Tromey  <tom@tromey.com>
3245
3246         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3247         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3248         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3249         * parser-defs.h (paren_depth): Don't declare.
3250         * parse.c (paren_depth): Remove global.
3251         (parse_exp_in_context): Update.
3252         * p-exp.y (paren_depth): New global.
3253         (pascal_parse): Initialize it.
3254         * m2-exp.y (paren_depth): New global.
3255         (m2_parse): Initialize it.
3256         * go-exp.y (paren_depth): New global.
3257         (go_parse): Initialize it.
3258         * f-exp.y (paren_depth): New global.
3259         (f_parse): Initialize it.
3260         * d-exp.y (paren_depth): New global.
3261         (d_parse): Initialize it.
3262         * c-exp.y (paren_depth): New global.
3263         (c_parse): Initialize it.
3264         * ada-lex.l (paren_depth): New global.
3265         (lexer_init): Initialize it.
3266
3267 2019-04-04  Tom Tromey  <tom@tromey.com>
3268
3269         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3270         (rust_parser::convert_ast_to_type)
3271         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3272         * parser-defs.h (struct parser_state) <parser_state>: Add
3273         parameters.  Initialize new members.
3274         <expression_context_block, expression_context_pc>: New members.
3275         * parse.c (expression_context_block, expression_context_pc):
3276         Remove globals.
3277         (parse_exp_in_context): Update.
3278         * p-exp.y: Update all rules.
3279         (yylex): Update.
3280         * m2-exp.y: Update all rules.
3281         (yylex): Update.
3282         * go-exp.y (yylex): Update.
3283         * f-exp.y (yylex): Update.
3284         * d-exp.y: Update all rules.
3285         (yylex): Update.
3286         * c-exp.y: Update all rules.
3287         (lex_one_token, classify_name, yylex, c_parse): Update.
3288         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3289
3290 2019-04-04  Tom Tromey  <tom@tromey.com>
3291
3292         * gdbarch.h, gdbarch.c: Rebuild.
3293         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3294         * stap-probe.h:
3295         (struct stap_parse_info): Replace "parser_state" with
3296         "expr_builder".
3297         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3298         (parser_state): New class.
3299         * parse.c (expr_builder): Rename.
3300         (expr_builder::release): Rename.
3301         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3302         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3303         (write_exp_elt_longcst, write_exp_elt_floatcst)
3304         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3305         (write_exp_string_vector, write_exp_bitstring)
3306         (write_exp_msymbol, mark_struct_expression)
3307         (write_dollar_variable)
3308         (insert_type_address_space, increase_expout_size): Replace
3309         "parser_state" with "expr_builder".
3310         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3311         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3312         "parser_state" with "expr_builder".
3313
3314 2019-04-04  Tom Tromey  <tom@tromey.com>
3315
3316         * rust-exp.y: Replace "parse_language" with method call.
3317         * p-exp.y:
3318         (yylex): Replace "parse_language" with method call.
3319         * m2-exp.y:
3320         (yylex): Replace "parse_language" with method call.
3321         * go-exp.y (classify_name): Replace "parse_language" with method
3322         call.
3323         * f-exp.y (yylex): Replace "parse_language" with method call.
3324         * d-exp.y (lex_one_token): Replace "parse_language" with method
3325         call.
3326         * c-exp.y:
3327         (lex_one_token, classify_name, yylex): Replace "parse_language"
3328         with method call.
3329         * ada-exp.y (find_primitive_type, type_char)
3330         (type_system_address): Replace "parse_language" with method call.
3331
3332 2019-04-04  Tom Tromey  <tom@tromey.com>
3333
3334         * rust-exp.y: Replace "parse_gdbarch" with method call.
3335         * parse.c (write_dollar_variable, insert_type_address_space):
3336         Replace "parse_gdbarch" with method call.
3337         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3338         call.
3339         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3340         call.
3341         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3342         "parse_gdbarch" with method call.
3343         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3344         with method call.
3345         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3346         "parse_gdbarch" with method call.
3347         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3348         "parse_gdbarch" with method call.
3349         * c-exp.y (parse_type, parse_number, classify_name): Replace
3350         "parse_gdbarch" with method call.
3351         * ada-lex.l: Replace "parse_gdbarch" with method call.
3352         * ada-exp.y (parse_type, find_primitive_type, type_char)
3353         (type_system_address): Replace "parse_gdbarch" with method call.
3354
3355 2019-04-04  Tom Tromey  <tom@tromey.com>
3356
3357         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3358         * stap-probe.c (stap_parse_argument): Update.
3359         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3360         initial_size parameter.
3361         * rust-exp.y (rust_lex_tests): Update.
3362         * parse.c (parser_state): Update.
3363         (parse_exp_in_context): Update.
3364         * parser-defs.h (struct parser_state) <parser_state>: Remove
3365         "initial_size" parameter.
3366
3367 2019-04-04  Tom Tromey  <tom@tromey.com>
3368
3369         * parser-defs.h (increase_expout_size): Don't declare.
3370         * parse.c (increase_expout_size): Now static.
3371
3372 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3373
3374         * gnu-nat.c (gnu_nat_target::wait): Fix
3375         target_waitstatus_to_string call.
3376
3377 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3378
3379         * eval.c (evaluate_subexp_standard): Handle internal functions
3380         during Fortran function call handling.
3381
3382 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3383
3384         * NEWS: Mention new internal functions.
3385         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3386         (read_base_type): Use dwarf2_init_complex_target_type.
3387         * value.c (creal_internal_fn): New function.
3388         (cimag_internal_fn): New function.
3389         (_initialize_values): Register new internal functions.
3390
3391 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3392
3393         * infrun.c (stop_all_threads): If debug_infrun, always
3394         trace the wait status after wait_one, using
3395         target_waitstatus_to_string and target_pid_to_str.
3396         (handle_inferior_event): Replace various trace of
3397         wait status kind by a single trace.
3398         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3399         wait status kind image by target_waitstatus_to_string.
3400         * target/waitstatus.c (target_waitstatus_to_string): Fix
3401         obsolete comment.
3402
3403 2019-04-01  Tom Tromey  <tromey@adacore.com>
3404
3405         PR symtab/23331:
3406         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3407
3408 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3409             Pedro Alves  <palves@redhat.com>
3410
3411         * top.c (quit_force): Call 'finalize_values'.
3412         * value.c (finalize_values): New function.
3413         * value.h (finalize_values): Declare.
3414
3415 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3416
3417         * NEWS: Announce $_gdb_major and $_gdb_minor.
3418
3419         * top.c (init_gdb_version_vars): New function.
3420         (gdb_init): Call init_gdb_version_vars.
3421
3422 2019-03-29  Tom Tromey  <tromey@adacore.com>
3423
3424         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3425         help text.  Remove dead code.
3426
3427 2019-03-29  Keith Seitz  <keiths@redhat.com>
3428
3429         From Siddhesh Poyarekar:
3430         * f-lang.h (f77_get_upperbound): Return LONGEST.
3431         (f77_get_lowerbound): Likewise.
3432         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3433         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3434         print them.
3435         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3436         plongest to format print it.
3437         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3438         (f77_get_upperbound): Likewise.
3439         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3440         LOWER_BOUND to LONGEST.
3441         (f77_create_arrayprint_offset_tbl): Likewise.
3442
3443 2019-03-29  Keith Seitz  <keiths@redhat.com>
3444
3445         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3446         %s/pulongest for TYPE_LENGTH instead of %d in format
3447         strings.
3448         * ada-typerint.c (ada_print_type): Likewise.
3449         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3450         * compile/compile-c-support.c (generate_register_struct): Likewise.
3451         * gdbtypes.c (recursive_dump_type): Likewise.
3452         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3453         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3454         instead of %d in format strings.
3455         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3456         to std::min to ULONGEST.
3457         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3458         instead of %d in format strings.
3459         * tracepoint.c (info_scope_command): Likewise.
3460         * typeprint.c (print_offset_data::update)
3461         (print_offset_data::finish): Likewise.
3462         * xtensa-tdep.c (xtensa_store_return_value)
3463         (xtensa_push_dummy_call): Likewise.
3464
3465 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3466
3467         * windows-nat.c (display_selector): Fixed format specifications
3468         for 64-bit Cygwin.
3469
3470 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3471
3472         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3473
3474 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3475
3476         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3477         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3478         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3479         (nios2_linux_init_abi): Install it.
3480
3481 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3482
3483         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3484
3485 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3486
3487         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3488
3489 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3490             Tom Tromey  <tromey@adacore.com>
3491
3492         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3493
3494 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3495
3496         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3497         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3498         method to compute the bounds of range types. Also print "[evaluated]"
3499         if the bounds' values come from a dynamic evaluation.
3500
3501 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3502
3503         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3504         whitespace when pretty printing is on.
3505
3506 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3507
3508         * ppc-linux-nat.c: Add include.
3509
3510 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3511
3512         * NEWS: Mention AArch64 Pointer Authentication.
3513
3514 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3515
3516         * arm-linux-nat.c: Add include.
3517
3518 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3519
3520         * source-cache.c (source_cache::get_source_lines): Re-read
3521         fullname after calling open_source_file.
3522
3523 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3524
3525         * NEWS: Mention TLS support for FreeBSD.
3526
3527 2019-03-25  Tom Tromey  <tromey@adacore.com>
3528
3529         * minsyms.c (BUNCH_SIZE): Update comment.
3530         (~minimal_symbol_reader): Remove old comment.
3531         (compact_minimal_symbols): Update comment.
3532         (minimal_symbol_reader::install): Remove old comment.  Update
3533         other comments.
3534
3535 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3536
3537         * s390-linux-nat.c: Add include.
3538
3539 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3540
3541         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3542         Call linux_get_hwcap.
3543         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3544         Likewise.
3545         (aarch64_linux_get_hwcap): Remove function.
3546         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3547         declaration.
3548         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3549         linux_get_hwcap.
3550         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3551         * linux-tdep.c (linux_get_hwcap): Add function.
3552         (linux_get_hwcap2): Likewise.
3553         * linux-tdep.h (linux_get_hwcap): Add declaration.
3554         (linux_get_hwcap2): Likewise.
3555         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3556         (ppc_linux_get_hwcap2): Likewise.
3557         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3558         linux_get_hwcap.
3559         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3560         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3561         (ppc_linux_nat_target::read_description): Likewise.
3562         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3563         * s390-linux-nat.c: Likewise.
3564         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3565
3566 2019-03-24  Tom Tromey  <tom@tromey.com>
3567
3568         * ada-lang.c (standard_lookup): Simplify initialization.
3569         (ada_lookup_symbol_nonlocal): Simplify return.
3570         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3571         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3572         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3573         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3574         initialization.
3575         * solib.c (solib_global_lookup): Simplify.
3576         * symtab.c (null_block_symbol): Remove.
3577         (symbol_cache_lookup): Simplify returns.
3578         (lookup_language_this): Simplify returns.
3579         (lookup_symbol_aux): Simplify return.
3580         (lookup_local_symbol): Simplify returns.
3581         (lookup_global_symbol_from_objfile): Simplify return.
3582         (lookup_symbol_in_objfile_symtabs)
3583         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3584         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3585         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3586         * cp-namespace.c (cp_lookup_bare_symbol)
3587         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3588         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3589         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3590         (cp_lookup_symbol_via_imports): Simplify initialization.
3591         (find_symbol_in_baseclass): Likewise.
3592         * symtab.h (null_block_symbol): Remove.
3593         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3594         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3595         (d_lookup_symbol_module): Likewise.
3596         (find_symbol_in_baseclass): Simplify initialization.
3597
3598 2019-03-24  Tom Tromey  <tom@tromey.com>
3599
3600         * expression.h: Don't include symtab.h.
3601         (struct block): Forward declare.
3602
3603 2019-03-24  Tom Tromey  <tom@tromey.com>
3604
3605         * c-exp.y (typebase): Remove casts.
3606         * gdbtypes.c (lookup_unsigned_typename, )
3607         (lookup_signed_typename): Remove cast.
3608         * eval.c (parse_to_comma_and_eval): Remove cast.
3609         * parse.c (write_dollar_variable): Remove cast.
3610         * block.h (struct block) <superblock>: Now const.
3611         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3612         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3613         (map_block): Make "block" const.
3614         * symfile.h (struct quick_symbol_functions)
3615         <map_matching_symbols>: Constify block argument to "callback".
3616         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3617         const.
3618         (find_pc_sect_compunit_symtab): Make "b" const.
3619         (find_symbol_at_address): Likewise.
3620         (search_symbols): Likewise.
3621         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3622         (dw2_debug_names_lookup_symbol): Likewise.
3623         (dw2_map_matching_symbols): Update.
3624         * p-valprint.c (pascal_val_print): Remove "block".
3625         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3626         (aux_add_nonlocal_symbols): Make "block" const.
3627         (resolve_subexp): Remove cast.
3628         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3629         const.
3630         (iterate_over_file_blocks): Likewise.
3631         * f-exp.y (%union) <bval>: Remove.
3632         * coffread.c (patch_opaque_types): Make "b" const.
3633         * spu-tdep.c (spu_catch_start): Make "block" const.
3634         * c-valprint.c (print_unpacked_pointer): Remove "block".
3635         * symmisc.c (dump_symtab_1): Make "b" const.
3636         (block_depth): Make "block" const.
3637         * d-exp.y (%union) <bval>: Remove.
3638         * cp-support.h (cp_lookup_rtti_type): Update.
3639         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3640         * psymtab.c (psym_lookup_symbol): Make "block" const.
3641         (maintenance_check_psymtabs): Make "b" const.
3642         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3643         (enumerate_locals, enumerate_args): Update.
3644         * python/py-symtab.c (stpy_global_block): Make "block" const.
3645         (stpy_static_block): Likewise.
3646         * inline-frame.c (block_starting_point_at): Make "new_block"
3647         const.
3648         * block.c (find_block_in_blockvector): Make return type const.
3649         (blockvector_for_pc_sect): Make "b" const.
3650         (find_block_in_blockvector): Make "b" const.
3651
3652 2019-03-23  Tom Tromey  <tom@tromey.com>
3653
3654         * varobj.c (varobj_create): Update.
3655         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3656         * printcmd.c (display_command, do_one_display): Don't reset
3657         innermost_block.
3658         * parser-defs.h (enum innermost_block_tracker_type): Move to
3659         expression.h.
3660         (innermost_block): Update comment.
3661         * parse.c (parse_exp_1): Add tracker_types parameter.
3662         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3663         tracker_types parameter.  Reset innermost_block.
3664         (parse_exp_in_context): Remove.
3665         (parse_expression_for_completion): Update.
3666         * objfiles.c (~objfile): Don't reset expression_context_block or
3667         innermost_block.
3668         * expression.h (enum innermost_block_tracker_type): Move from
3669         parser-defs.h.
3670         (parse_exp_1): Add tracker_types parameter.
3671         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3672         reset innermost_block.
3673
3674 2019-03-23  Tom Tromey  <tom@tromey.com>
3675
3676         * objfiles.h: Include bcache.h.
3677
3678 2019-03-23  Tom Tromey  <tom@tromey.com>
3679
3680         * linespec.c (get_current_search_block): Use
3681         scoped_restore_current_language.
3682         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3683
3684 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3685             Jiong Wang  <jiong.wang@arm.com>
3686
3687         * aarch64-linux-tdep.c
3688         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3689         section.
3690         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3691
3692 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3693             Jiong Wang  <jiong.wang@arm.com>
3694
3695         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3696         instructions.
3697         (aarch64_analyze_prologue_test): Add PACIASP test.
3698         (aarch64_prologue_prev_register): Unmask PC value.
3699
3700 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3701             Jiong Wang  <jiong.wang@arm.com>
3702
3703         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3704         (aarch64_dwarf2_prev_register): Unmask PC value.
3705         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3706         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3707         DW_CFA_AARCH64_negate_ra_state.
3708         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3709
3710 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3711             Jiong Wang  <jiong.wang@arm.com>
3712
3713         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3714         registers.
3715         (aarch64_pseudo_register_name): Likewise.
3716         (aarch64_pseudo_register_type): Likewise.
3717         (aarch64_pseudo_register_reggroup_p): Likewise.
3718         (aarch64_gdbarch_init): Add pauth registers.
3719         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3720         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3721         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3722         (struct gdbarch_tdep): Add regnum for ra_state.
3723
3724 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3725             Jiong Wang  <jiong.wang@arm.com>
3726
3727         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3728
3729 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3730             Jiong Wang  <jiong.wang@arm.com>
3731
3732         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3733         function.
3734         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3735         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3736         (aarch64_gdbarch_init): Add puth registers.
3737         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3738         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3739         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3740
3741 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3742             Jiong Wang  <jiong.wang@arm.com>
3743
3744         * aarch64-linux-nat.c
3745         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3746         * aarch64-linux-tdep.c
3747         (aarch64_linux_core_read_description): Likewise.
3748         (aarch64_linux_get_hwcap): New function.
3749         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3750         (aarch64_linux_get_hwcap): New declaration.
3751
3752 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3753             Jiong Wang  <jiong.wang@arm.com>
3754
3755         * aarch64-linux-nat.c
3756         (aarch64_linux_nat_target::read_description): Add pauth param.
3757         * aarch64-linux-tdep.c
3758         (aarch64_linux_core_read_description): Likewise.
3759         * aarch64-tdep.c (struct target_desc): Add in pauth.
3760         (aarch64_read_description): Add pauth param.
3761         (aarch64_gdbarch_init): Likewise.
3762         * aarch64-tdep.h (aarch64_read_description): Likewise.
3763         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3764         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3765         * features/Makefile: Add new files.
3766         * features/aarch64-pauth.c: New file.
3767         * features/aarch64-pauth.xml: New file.
3768
3769 2019-03-20  Tom Tromey  <tromey@adacore.com>
3770
3771         * infrun.c (handle_inferior_event): Rename from
3772         handle_inferior_event_1.  Create a scoped_value_mark.
3773         (handle_inferior_event): Remove.
3774
3775 2019-03-19  Tom Tromey  <tromey@adacore.com>
3776
3777         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3778         * infrun.h (print_stop_event): Add "displays" parameter.
3779         * infrun.c (print_stop_event): Add "displays" parameter.
3780
3781 2019-03-19  Pedro Alves  <palves@redhat.com>
3782
3783         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3784         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3785         to -1.  Fix TABs vs spaces.
3786         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3787         * tui/tui-out.h (tui_ui_out) Add intro comments.
3788         <m_line, m_start_of_line>: In-class initialize, and add describing
3789         comment.
3790
3791 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3792
3793         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3794         variable names.
3795         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3796
3797 2019-03-18  Pedro Alves  <palves@redhat.com>
3798             Eli Zaretskii <eliz@gnu.org>
3799
3800         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3801         m_line and m_start_of_line.
3802
3803 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3804
3805         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3806         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3807         it returns a newline.  This fixes a regression in TU mode, whereby
3808         the next line is output on the same screen line as the user input.
3809
3810 2019-03-18  Tom Tromey  <tromey@adacore.com>
3811
3812         * minsyms.c (minimal_symbol_reader::install): Remove call to
3813         obstack_blank.
3814
3815 2019-03-18  Pedro Alves  <palves@redhat.com>
3816
3817         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3818         New globals.
3819         (apply_style): New, factored out from ...
3820         (apply_ansi_escape): ... this.  Handle reverse video mode.
3821         (tui_set_reverse_mode): New function.
3822         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3823         * tui/tui-winsource.c (tui_show_source_line): Use
3824         tui_set_reverse_mode instead of setting A_STANDOUT.
3825         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3826         New setter methods.
3827
3828 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3829
3830         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3831         Handle tabs.
3832
3833 2019-03-18  Tom Tromey  <tromey@adacore.com>
3834
3835         * ada-lang.c (empty_array): Add "high" parameter.
3836         (ada_evaluate_subexp): Update.
3837
3838 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3839
3840         * unittests/string_view-selftests.c: Define
3841         _initialize_string_view_selftests unconditionally.
3842
3843 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3844
3845         PR gdb/24350
3846         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3847
3848 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3849
3850         PR gdb/24351
3851         * windows-nat.c (display_selector): Fix format specifiers.
3852
3853 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3854
3855         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3856         tui_refill_source_window instead of tui_refresh_win, to update the
3857         current execution line.  This fixes redisplay of the current line
3858         when stepping through the code with "next" or "step".
3859
3860 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3861
3862         * source-cache.c (source_cache::get_source_lines): Call
3863         find_source_lines to initialize s->nlines.  This fixes vertical
3864         scrolling of TUI source window when the DOWN arrow is pressed.
3865
3866 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3867
3868         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3869         linux-thread-db.c (_initialize_thread_db): Likewise.
3870
3871 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3872
3873         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3874         wclrtoeol in tui_show_source_line".  This reverts changes made in
3875         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3876
3877 2019-03-15  Tom Tromey  <tom@tromey.com>
3878
3879         * symtab.h (struct minimal_symbol): Derive from
3880         general_symbol_info.
3881         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3882         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3883         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3884         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3885         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3886         (MSYMBOL_SEARCH_NAME): Update.
3887         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3888         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3889         * minsyms.c (minimal_symbol_reader::record_full): Update.
3890
3891 2019-03-15  Tom Tromey  <tom@tromey.com>
3892
3893         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3894
3895 2019-03-15  Tom Tromey  <tom@tromey.com>
3896
3897         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3898         unique_xmalloc_ptr.
3899         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3900         Update.
3901         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3902         (build_minimal_symbol_hash_tables)
3903         (minimal_symbol_reader::install): Update.
3904
3905 2019-03-15  Tom Tromey  <tom@tromey.com>
3906
3907         * symtab.c (create_demangled_names_hash): Update.
3908         (symbol_set_names): Update.
3909         * objfiles.h (struct objfile_per_bfd_storage)
3910         <demangled_names_hash>: Now an htab_up.
3911         * objfiles.c (objfile_per_bfd_storage): Simplify.
3912
3913 2019-03-15  Tom Tromey  <tom@tromey.com>
3914
3915         * objfiles.h (struct objfile_per_bfd_storage): Declare
3916         destructor.
3917         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
3918         New.
3919         (get_objfile_bfd_data): Use new.  Don't initialize
3920         language_of_main.
3921         (free_objfile_per_bfd_storage): Remove.
3922         (objfile_bfd_data_free, objfile::~objfile): Use delete.
3923
3924 2019-03-15  Tom Tromey  <tom@tromey.com>
3925
3926         * symfile.c (reread_symbols): Update.
3927         * objfiles.c (objfile::objfile): Update.
3928         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
3929         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
3930         comment.
3931         (minimal_symbol_reader::install): Update.
3932         (terminate_minimal_symbol_table): Remove.
3933         * jit.c (jit_object_close_impl): Update.
3934
3935 2019-03-15  Tom Tromey  <tom@tromey.com>
3936
3937         * minsyms.c (minimal_symbol_reader::record_full): Remove some
3938         initializations.
3939
3940 2019-03-15  Tom Tromey  <tom@tromey.com>
3941
3942         * objfiles.h (struct objfile_per_bfd_storage)
3943         <demangled_hash_languages>: Now a bitset.
3944         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
3945         (lookup_minimal_symbol): Update.
3946
3947 2019-03-15  Tom Tromey  <tom@tromey.com>
3948
3949         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
3950         Don't return the symbol.
3951         * coffread.c (record_minimal_symbol): Use record_full.
3952
3953 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
3954
3955         The MS-Windows port of ncurses fails to switch to a color pair if
3956         one or both of the colors are the implicit default colors.  This
3957         change records the default colors when TUI is initialized, and
3958         then specifies them explicitly when a color pair uses the default
3959         colors.  This allows color styling in TUI mode on MS-Windows.
3960
3961         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
3962         ncurses_norm_attr.
3963         (tui_initialize_io) [__MINGW32__]: Record the default terminal
3964         colors in ncurses_norm_attr.
3965         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
3966         "none", replace it with the default color recorded in
3967         ncurses_norm_attr.
3968
3969 2019-03-14  Tom Tromey  <tromey@adacore.com>
3970
3971         * source-cache.h (class source_cache) <get_source_lines>: Return
3972         std::string.
3973         * source-cache.c (source_cache::extract_lines): Handle case where
3974         first_pos==npos.  Return std::string.
3975         (source_cache::get_source_lines): Update.
3976
3977 2019-03-14  Tom Tromey  <tromey@adacore.com>
3978
3979         * NEWS: Add item for "style sources" commands.
3980         * source-cache.c (source_cache::get_source_lines): Check
3981         source_styling.
3982         * cli/cli-style.c (source_styling): New global.
3983         (_initialize_cli_style): Add "style sources" commands.
3984         (show_style_sources): New function.
3985         * cli/cli-style.h (source_styling): Declare.
3986
3987 2019-03-14  Pedro Alves  <palves@redhat.com>
3988             Tom Tromey  <tromey@adacore.com>
3989
3990         * tui/tui-winsource.h (tui_refill_source_window): Declare.
3991         * tui/tui-winsource.c (tui_refill_source_window): New function,
3992         from...
3993         (tui_horizontal_source_scroll): ... here.  Move some logic.
3994         * cli/cli-style.c (set_style_enabled): Notify new observable.
3995         * tui/tui-hooks.c (tui_redisplay_source): New function.
3996         (tui_attach_detach_observers): Attach or detach
3997         tui_redisplay_source.
3998         * observable.h (source_styling_changed): New observable.
3999         * observable.c: Define source_styling_changed observable.
4000
4001 2019-03-13  Tom Tromey  <tromey@adacore.com>
4002
4003         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4004         (i386_gnu_nat_target::store_registers): Update.
4005         * target-debug.h (target_debug_print_std_string): New macro.
4006         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4007         * windows-tdep.c (display_one_tib): Update.
4008         * tui/tui-stack.c (tui_make_status_line): Update.
4009         * top.c (print_inferior_quit_action): Update.
4010         * thread.c (thr_try_catch_cmd): Update.
4011         (add_thread_with_info): Update.
4012         (thread_target_id_str): Update.
4013         (thr_try_catch_cmd): Update.
4014         (thread_command): Update.
4015         (thread_find_command): Update.
4016         * record-btrace.c (record_btrace_target::info_record)
4017         (record_btrace_resume_thread, record_btrace_target::resume)
4018         (record_btrace_cancel_resume, record_btrace_step_thread)
4019         (record_btrace_target::wait, record_btrace_target::wait)
4020         (record_btrace_target::wait, record_btrace_target::stop): Update.
4021         * progspace.c (print_program_space): Update.
4022         * process-stratum-target.c
4023         (process_stratum_target::thread_address_space): Update.
4024         * linux-fork.c (linux_fork_mourn_inferior)
4025         (detach_checkpoint_command, info_checkpoints_command)
4026         (linux_fork_context): Update.
4027         (linux_fork_detach): Update.
4028         (class scoped_switch_fork_info): Update.
4029         (delete_checkpoint_command): Update.
4030         * infrun.c (follow_fork_inferior): Update.
4031         (follow_fork_inferior): Update.
4032         (proceed_after_vfork_done): Update.
4033         (handle_vfork_child_exec_or_exit): Update.
4034         (follow_exec): Update.
4035         (displaced_step_prepare_throw): Update.
4036         (displaced_step_restore): Update.
4037         (start_step_over): Update.
4038         (resume_1): Update.
4039         (clear_proceed_status_thread): Update.
4040         (proceed): Update.
4041         (print_target_wait_results): Update.
4042         (do_target_wait): Update.
4043         (context_switch): Update.
4044         (stop_all_threads): Update.
4045         (restart_threads): Update.
4046         (finish_step_over): Update.
4047         (handle_signal_stop): Update.
4048         (switch_back_to_stepped_thread): Update.
4049         (keep_going_pass_signal): Update.
4050         (print_exited_reason): Update.
4051         (normal_stop): Update.
4052         * inferior.c (inferior_pid_to_str): Change return type.
4053         (print_selected_inferior): Update.
4054         (add_inferior): Update.
4055         (detach_inferior): Update.
4056         * dummy-frame.c (fprint_dummy_frames): Update.
4057         * dcache.c (dcache_info_1): Update.
4058         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4059         (btrace_fetch, btrace_clear): Update.
4060         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4061         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4062         type.
4063         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4064         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4065         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4066         * gdbarch.c, gdbarch.h: Rebuild.
4067         * gdbarch.sh (core_pid_to_str): Change return type.
4068         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4069         return type.
4070         (windows_nat_target::pid_to_str): Change return type.
4071         (windows_delete_thread): Update.
4072         (windows_nat_target::attach): Update.
4073         (windows_nat_target::files_info): Update.
4074         * target-delegates.c: Rebuild.
4075         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4076         return type.
4077         (sol_thread_target::pid_to_str): Change return type.
4078         * remote.c (class remote_target) <pid_to_str>: Change return
4079         type.
4080         (remote_target::pid_to_str): Change return type.
4081         (extended_remote_target::attach, remote_target::remote_stop_ns)
4082         (remote_target::remote_notif_remove_queued_reply)
4083         (remote_target::push_stop_reply, remote_target::disable_btrace):
4084         Update.
4085         (extended_remote_target::attach): Update.
4086         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4087         type.
4088         (gdbsim_target::pid_to_str): Change return type.
4089         * ravenscar-thread.c (struct ravenscar_thread_target)
4090         <pid_to_str>: Change return type.
4091         (ravenscar_thread_target::pid_to_str): Change return type.
4092         * procfs.c (class procfs_target) <pid_to_str>: Change return
4093         type.
4094         (procfs_target::pid_to_str): Change return type.
4095         (procfs_target::attach): Update.
4096         (procfs_target::detach): Update.
4097         (procfs_target::fetch_registers): Update.
4098         (procfs_target::store_registers): Update.
4099         (procfs_target::wait): Update.
4100         (procfs_target::files_info): Update.
4101         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4102         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4103         return type.
4104         (nto_procfs_target::pid_to_str): Change return type.
4105         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4106         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4107         return type.
4108         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4109         (exit_lwp): Update.
4110         (attach_proc_task_lwp_callback, get_detach_signal)
4111         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4112         (linux_nat_target::resume, wait_lwp, stop_callback)
4113         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4114         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4115         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4116         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4117         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4118         type.
4119         (inf_ptrace_target::attach): Update.
4120         (inf_ptrace_target::files_info): Update.
4121         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4122         type.
4123         (go32_nat_target::pid_to_str): Change return type.
4124         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4125         (gnu_nat_target::wait): Update.
4126         (gnu_nat_target::wait): Update.
4127         (gnu_nat_target::resume): Update.
4128         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4129         (fbsd_nat_target::wait): Update.
4130         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4131         type.
4132         (darwin_nat_target::attach): Update.
4133         * corelow.c (class core_target) <pid_to_str>: Change return type.
4134         (core_target::pid_to_str): Change return type.
4135         * target.c (normal_pid_to_str): Change return type.
4136         (default_pid_to_str): Likewise.
4137         (target_pid_to_str): Change return type.
4138         (target_translate_tls_address): Update.
4139         (target_announce_detach): Update.
4140         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4141         return type.
4142         (bsd_uthread_target::pid_to_str): Change return type.
4143         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4144         type.
4145         (bsd_kvm_target::pid_to_str): Change return type.
4146         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4147         return type.
4148         (aix_thread_target::pid_to_str): Change return type.
4149         * target.h (struct target_ops) <pid_to_str>: Change return type.
4150         (target_pid_to_str, normal_pid_to_str): Likewise.
4151         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4152         type.
4153         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4154         type.
4155         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4156         return type.
4157         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4158         type.
4159         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4160         type.
4161         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4162         return type.
4163
4164 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4165
4166         * NEWS: Mention that the new default MI version is 3.  Mention
4167         changes to the output of commands and events that deal with
4168         multi-location breakpoints.
4169         * breakpoint.c: Include "mi/mi-out.h".
4170         (print_one_breakpoint): Change output syntax if using MI version
4171         >= 3.
4172         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4173         New.
4174         (mi_multi_location_breakpoint_output_fixed): New.
4175         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4176         (mi_cmd_fix_multi_location_breakpoint_output): New.
4177         (mi_multi_location_breakpoint_output_fixed): New.
4178         * mi/mi-cmds.c (mi_cmds): Register command
4179         -fix-multi-location-breakpoint-output.
4180         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4181         interpreter "mi".
4182
4183 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4184
4185         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4186         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4187         instantiate mi_ui_out based on interpreter name.
4188         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4189         * mi/mi-main.c (mi_load_progress): Likewise.
4190
4191 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4192
4193         * NEWS: Combine separate "New targets" sections for 8.3.
4194
4195 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4196
4197         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4198         (ppcfbsd_init_abi): Install gdbarch
4199         "fetch_tls_load_module_address" and "get_thread_local_address"
4200         methods.
4201
4202 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4203
4204         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4205         (riscv_fbsd_init_abi): Install gdbarch
4206         "fetch_tls_load_module_address" and "get_thread_local_address"
4207         methods.
4208
4209 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4210
4211         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4212         (i386fbsd_init_abi): Install gdbarch
4213         "fetch_tls_load_module_address" and "get_thread_local_address"
4214         methods.
4215
4216 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4217
4218         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4219         (amd64fbsd_init_abi): Install gdbarch
4220         "fetch_tls_load_module_address" and "get_thread_local_address"
4221         methods.
4222
4223 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4224
4225         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4226         (struct fbsd_pspace_data): New type.
4227         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4228         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4229         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4230         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4231         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4232
4233 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4234
4235         * gdbtypes.c (lookup_struct_elt): New function.
4236         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4237         * gdbtypes.h (struct struct_elt): New type.
4238         (lookup_struct_elt): New prototype.
4239
4240 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4241
4242         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4243         remove disabled code block.
4244
4245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4246
4247         * gdbarch.sh (get_thread_local_address): New method.
4248         * gdbarch.h, gdbarch.c: Regenerate.
4249         * target.c (target_translate_tls_address): Use
4250         gdbarch_get_thread_local_address if present instead of
4251         target::get_thread_local_address.
4252
4253 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4254
4255         * target.h (target::get_thread_local_address): Update comment.
4256
4257 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4258
4259         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4260         objfile->separate_debug_objfile_backlink if not NULL.
4261
4262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4263
4264         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4265         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4266         (amd64bsd_store_inferior_registers): Likewise.
4267         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4268         Enable segment base registers.
4269         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4270         PT_GETFSBASE and PT_GETGSBASE.
4271         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4272         PT_SETGSBASE.
4273         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4274         segment base registers.
4275         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4276
4277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4278
4279         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4280         Update calls to i386_target_description to add 'segments'
4281         parameter.
4282         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4283         add segment base registers.
4284         * arch/i386.c (i386_create_target_description): Add 'segments'
4285         parameter to enable segment base registers.
4286         * arch/i386.h (i386_create_target_description): Likewise.
4287         * features/i386/32bit-segments.xml: New file.
4288         * features/i386/32bit-segments.c: Generate.
4289         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4290         call to i386_target_description to add 'segments' parameter.
4291         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4292         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4293         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4294         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4295         if feature is present.
4296         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4297         Add 'segments' parameter to call to i386_target_description.
4298         (i386_target_description): Add 'segments' parameter to enable
4299         segment base registers.
4300         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4301         to call to i386_target_description.
4302         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4303         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4304         Define I386_NUM_REGS.
4305         (i386_target_description): Add 'segments' parameter to enable
4306         segment base registers.
4307
4308 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4309
4310         PR/24325
4311         * source-cache.c: #undef open and close, to avoid unresolved
4312         externals during linking.
4313
4314 2019-03-12  Tom Tromey  <tromey@adacore.com>
4315
4316         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4317         const.  Add initializers.
4318         (_initialize_remote): Don't initialize ptid globals.
4319
4320 2019-03-12  Pedro Alves  <palves@redhat.com>
4321
4322         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4323
4324 2019-03-12  Pedro Alves  <palves@redhat.com>
4325
4326         * cp-name-parser.y (main): Remove unused 'len' variable.
4327
4328 2019-03-12  Tom Tromey  <tromey@adacore.com>
4329
4330         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4331         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4332
4333 2019-03-12  Tom Tromey  <tromey@adacore.com>
4334
4335         * linux-nat.c (iterate_over_lwps): Update.
4336         (stop_callback): Remove parameter.
4337         (stop_wait_callback, detach_callback, resume_set_callback)
4338         (select_singlestep_lwp_callback, set_ignore_sigint)
4339         (status_callback, resumed_callback, resume_clear_callback)
4340         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4341         data parameter.
4342         (linux_nat_target::detach, linux_nat_target::resume)
4343         (linux_stop_and_wait_all_lwps, select_event_lwp)
4344         (linux_nat_filter_event, linux_nat_wait_1)
4345         (linux_nat_target::kill, linux_nat_target::stop)
4346         (linux_nat_target::stop): Update.
4347         (linux_nat_resume_callback): Change type.
4348         (resume_stopped_resumed_lwps, count_events_callback)
4349         (select_event_lwp_callback): Likewise.
4350         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4351         * arm-linux-nat.c (struct update_registers_data): Remove.
4352         (update_registers_callback): Change type.
4353         (arm_linux_insert_hw_breakpoint1): Update.
4354         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4355         parameter.
4356         (x86_linux_dr_set_addr): Update.
4357         (x86_linux_dr_set_control): Update.
4358         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4359         (iterate_over_lwps): Use gdb::function_view.
4360         * nat/aarch64-linux-hw-point.c (struct
4361         aarch64_dr_update_callback_param): Remove.
4362         (debug_reg_change_callback): Change type.
4363         (aarch64_notify_debug_reg_change): Update.
4364         * s390-linux-nat.c (s390_refresh_per_info): Update.
4365
4366 2019-03-11  Tom Tromey  <tromey@adacore.com>
4367
4368         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4369         redundant assignment to "this_cu".
4370
4371 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4372
4373         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4374
4375 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4376
4377         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4378         from...
4379         (rank_one_type): ... this.
4380
4381 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4382
4383         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4384         from...
4385         (rank_one_type): ... this.
4386
4387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4388
4389         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4390         from...
4391         (rank_one_type): ... this.
4392
4393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4394
4395         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4396         from...
4397         (rank_one_type): ... this.
4398
4399 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4400
4401         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4402         from...
4403         (rank_one_type): ... this.
4404
4405 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4406
4407         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4408         from...
4409         (rank_one_type): ... this.
4410
4411 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4412
4413         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4414         from...
4415         (rank_one_type): ... this.
4416
4417 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4418
4419         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4420         from...
4421         (rank_one_type): ... this.
4422
4423 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4424
4425         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4426         from...
4427         (rank_one_type): ... this.
4428
4429 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4430
4431         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4432         from...
4433         (rank_one_type): ... this.
4434
4435 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4436
4437         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4438         from...
4439         (rank_one_type): ... this.
4440
4441 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4442
4443         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4444         from...
4445         (rank_one_type): ... this.
4446
4447 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4448
4449         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4450         inferior-events' shows the example events.
4451
4452 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4453
4454         Support styling on native MS-Windows console
4455
4456         PR/24315
4457         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4458         on MS-Windows if $TERM is not defined.
4459
4460         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4461
4462         * posix-hdep.c (gdb_console_fputs):
4463         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4464         functions.
4465         * ui-file.h (gdb_console_fputs): Add prototype.
4466
4467         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4468         back to fputs only if the former returns zero.
4469
4470 2019-03-07  Tom Tromey  <tom@tromey.com>
4471
4472         * symmisc.c (print_symbol_bcache_statistics): Update.
4473         (print_objfile_statistics): Update.
4474         * symfile.c (allocate_symtab): Update.
4475         * stabsread.c: Don't include bcache.h.
4476         * psymtab.h (struct psymbol_bcache): Don't declare.
4477         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4478         (psymbol_bcache_init, psymbol_bcache_free)
4479         (psymbol_bcache_get_bcache): Don't declare.
4480         * psymtab.c (struct psymbol_bcache): Remove.
4481         (psymtab_storage::psymtab_storage): Update.
4482         (psymtab_storage::~psymtab_storage): Update.
4483         (psymbol_bcache_init, psymbol_bcache_free)
4484         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4485         (add_psymbol_to_bcache): Update.
4486         (allocate_psymtab): Update.
4487         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4488         macro_cache>: No longer pointers.
4489         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4490         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4491         * macrotab.c (macro_bcache): Update.
4492         * macroexp.c: Don't include bcache.h.
4493         * gdbtypes.c (check_types_worklist): Update.
4494         (types_deeply_equal): Remove TRY/CATCH.  Update.
4495         * elfread.c (elf_symtab_read): Update.
4496         * dwarf2read.c: Don't include bcache.h.
4497         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4498         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4499         (print_bcache_statistics, bcache_memory_used): Don't declare.
4500         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4501         methods.  Rename all data members.
4502         * bcache.c (struct bcache): Move to bcache.h.
4503         (bcache::expand_hash_table): Rename from expand_hash_table.
4504         (bcache): Remove.
4505         (bcache::insert): Rename from bcache_full.
4506         (bcache::compare): Rename from bcache_compare.
4507         (bcache_xmalloc): Remove.
4508         (bcache::~bcache): Rename from bcache_xfree.
4509         (bcache::print_statistics): Rename from print_bcache_statistics.
4510         (bcache::memory_used): Rename from bcache_memory_used.
4511
4512 2019-03-07  Pedro Alves  <palves@redhat.com>
4513
4514         * infrun.c (normal_stop): Also check for
4515         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4516
4517 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4518
4519         * f-lang.c (value_from_host_double): Moved to...
4520         * value.c (value_from_host_double): ...here.
4521         * value.h (value_from_host_double): Declare.
4522         * guile/scm-math.c (vlscm_convert_typed_number): Use
4523         value_from_host_double.
4524         (vlscm_convert_number): Likewise.
4525         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4526         * python/py-value.c (convert_value_from_python): Likewise.
4527
4528 2019-03-06  Tom Tromey  <tom@tromey.com>
4529
4530         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4531
4532 2019-03-06  Tom Tromey  <tom@tromey.com>
4533
4534         * utils.h (free_current_contents): Don't declare.
4535         * utils.c (free_current_contents): Remove.
4536
4537 2019-03-06  Tom Tromey  <tom@tromey.com>
4538
4539         * top.c (quit_force): Update.
4540         * main.c (captured_command_loop): Update.
4541         * common/new-op.c (operator new): Update.
4542         * common/common-exceptions.c (struct catcher)
4543         <save_cleanup_chain>: Remove member.
4544         (exceptions_state_mc_init): Update.
4545         (exception_try_scope_entry): Return nullptr.
4546         (exception_try_scope_exit, exception_rethrow)
4547         (throw_exception_sjlj, throw_exception_cxx): Update.
4548         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4549         (all_cleanups, do_cleanups, discard_cleanups)
4550         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4551         (restore_cleanups, restore_final_cleanups): Don't declare.
4552         (do_final_cleanups): Remove parameter.
4553         * common/cleanups.c (cleanup_chain, make_cleanup)
4554         (make_cleanup_dtor, all_cleanups, do_cleanups)
4555         (discard_my_cleanups, discard_cleanups)
4556         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4557         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4558         (null_cleanup): Remove.
4559         (do_final_cleanups): Remove parameter.
4560
4561 2019-03-06  Tom Tromey  <tom@tromey.com>
4562
4563         * remote.c (remote_target::remote_parse_stop_reply): Use
4564         unique_xmalloc_ptr.
4565
4566 2019-03-06  Tom Tromey  <tom@tromey.com>
4567
4568         * stabsread.c (struct stabs_field_info): Rename from field_info.
4569         <list, fnlist>: Add initializers.
4570         <obstack>: New member.
4571         (read_member_functions, read_struct_fields, read_baseclasses):
4572         Allocate on obstack.  Don't use cleanups.
4573         (read_one_struct_field, read_member_functions, read_struct_fields)
4574         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4575         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4576         (read_struct_type): Update.
4577
4578 2019-03-06  Tom Tromey  <tom@tromey.com>
4579
4580         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4581         * common/filestuff.h (make_cleanup_close): Don't declare.
4582         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4583         Remove.
4584
4585 2019-03-06  Tom Tromey  <tom@tromey.com>
4586
4587         * solib-aix.c: Use make_scope_exit.
4588
4589 2019-03-06  Tom Tromey  <tom@tromey.com>
4590
4591         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4592         Use make_scope_exit.
4593
4594 2019-03-06  Tom Tromey  <tom@tromey.com>
4595
4596         * solib-svr4.c (disable_probes_interface): Remove parameter.
4597         (svr4_handle_solib_event): Use make_scope_exit.
4598
4599 2019-03-06  Tom Tromey  <tom@tromey.com>
4600
4601         * remote.c (struct stop_reply_deleter): Remove.
4602         (stop_reply_up): Update.
4603         (struct stop_reply): Derive from notif_event.  Don't typedef.
4604         <regcache>: Now a std::vector.
4605         (stop_reply_xfree): Remove.
4606         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4607         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4608         (remote_target::discard_pending_stop_replies): Use delete.
4609         (remote_target::remote_parse_stop_reply): Update.
4610         (remote_target::process_stop_reply): Update.
4611         * remote-notif.h (struct notif_event): Add virtual destructor.
4612         Remove "dtr" member.
4613         (struct notif_client) <alloc_event>: Return a unique_ptr.
4614         (notif_event_xfree): Don't declare.
4615         (notif_event_up): New typedef.
4616         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4617         (notif_event_xfree, do_notif_event_xfree): Remove.
4618         (remote_notif_state_xfree): Update.
4619
4620 2019-03-06  Tom Tromey  <tom@tromey.com>
4621
4622         * infrun.c (displaced_step_clear_cleanup): Now a
4623         forward_scope_exit type.
4624         (displaced_step_prepare_throw): Update.
4625         (displaced_step_fixup): Update.
4626
4627 2019-03-06  Tom Tromey  <tom@tromey.com>
4628
4629         * inferior.h (class inferior): Update comment.
4630         * gdbthread.h (class thread_info): Update comment.
4631
4632 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4633             Tom Tromey  <tom@tromey.com>
4634
4635         * stabsread.h (struct stab_section_list): Remove.
4636         (coffstab_build_psymtabs): Update.
4637         * dbxread.c (symbuf_sections): Now a std::vector.
4638         (sect_idx): New global.
4639         (fill_symbuf): Update.
4640         (coffstab_build_psymtabs): Change type of stabsects parameter.
4641         Update.
4642         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4643         std::vector.
4644         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4645         (coff_locate_sections): Update.
4646         (coff_symfile_read): Remove cleanups.  Update.
4647         (init_stringtab): Add storage parameter.
4648         (free_stringtab, free_stringtab_cleanup): Remove.
4649         (init_lineno): Add storage parameter.
4650         (free_linetab, free_linetab_cleanup): Remove.
4651
4652 2019-03-06  Pedro Alves  <palves@redhat.com>
4653
4654         * linux-fork.c (fork_info::clobber_regs): Delete.
4655         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4656         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4657         comment.  Adjust.
4658         (scoped_switch_fork_info::scoped_switch_fork_info)
4659         (checkpoint_command, linux_fork_context): Adjust
4660         fork_save_infrun_state calls.
4661
4662 2019-03-06  Pedro Alves  <palves@redhat.com>
4663
4664         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4665         (inf_has_multiple_threads): Return 'bool' and rewrite using
4666         inferior_info::threads().
4667
4668 2019-03-06  Pedro Alves  <palves@redhat.com>
4669
4670         * linux-fork.c: Include <list>.
4671         (fork_list): Now a std::list instance.
4672         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4673         (forks_exist_p, find_last_fork): Adjust.
4674         (new_fork): Delete.
4675         (one_fork_p): New.
4676         (add_fork): Adjust.
4677         (free_fork): Delete, folded into fork_info::~fork_info().
4678         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4679         Adjust.
4680         (init_fork_list): Delete.
4681         (linux_fork_killall, linux_fork_mourn_inferior)
4682         (linux_fork_detach, info_checkpoints_command): Adjust.
4683         (_initialize_linux_fork): No longer call init_fork_list.
4684
4685 2019-03-06  Pedro Alves  <palves@redhat.com>
4686
4687         * linux-fork.c (new_fork): New, split out of ...
4688         (add_fork): ... this.  Return void.  Move "first fork" special
4689         case from here, to ...
4690         (checkpoint_command): ... here.
4691         * linux-linux.h (add_fork): Return void.
4692
4693 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4694
4695         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4696
4697 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4698             Chris January  <chris.january@arm.com>
4699             David Lecomber  <david.lecomber@arm.com>
4700
4701         * f-exp.y: New token, UNOP_INTRINSIC.
4702         (exp): New pattern using UNOP_INTRINSIC token.
4703         (f77_keywords): Add 'abs' keyword.
4704         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4705         (value_from_host_double): New function.
4706         (evaluate_subexp_f): Support UNOP_ABS.
4707
4708 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4709
4710         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4711         types.
4712
4713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4714
4715         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4716         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4717         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4718
4719 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4720
4721         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4722
4723 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4724             Chris January  <chris.january@arm.com>
4725
4726         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4727         * f-exp.y: Define 'KIND' token.
4728         (exp): New pattern for KIND expressions.
4729         (ptype): Handle types with a kind extension.
4730         (direct_abs_decl): Extend to spot kind extensions.
4731         (f77_keywords): Add 'kind' to the list.
4732         (push_kind_type): New function.
4733         (convert_to_kind_type): New function.
4734         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4735         * parse.c (operator_length_standard): Likewise.
4736         * parser-defs.h (enum type_pieces): Add tp_kind.
4737         * std-operator.def: Add UNOP_KIND.
4738
4739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4740
4741         * f-exp.y (f_parse): Set yydebug.
4742
4743 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4744
4745         * f-lang.c (evaluate_subexp_f): New function.
4746         (exp_descriptor_f): New global.
4747         (f_language_defn): Use exp_descriptor_f instead of
4748         exp_descriptor_standard.
4749
4750 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4751
4752         * f-exp.y (struct token): Add comments.
4753         (dot_ops): Remove uppercase versions and the end marker.
4754         (f77_keywords): Likewise.
4755         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4756         entries in the dot_ops array are case insensitive, and use
4757         strncasecmp to compare strings.  Also some whitespace cleanup in
4758         this area.  Similar for the f77_keywords array, except entries in
4759         this list might be case sensitive.
4760
4761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4762
4763         * f-exp.y (struct f77_boolean_val): Add comments.
4764         (boolean_values): Remove uppercase versions, and end marker.
4765         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4766         and use strncasecmp to achieve case insensitivity.  Additionally,
4767         perform whitespace cleanup around this code.
4768
4769 2019-03-06  Tom Tromey  <tromey@adacore.com>
4770
4771         * remote-sim.c (gdbsim_target_open): Use result of
4772         gdb_argv::release.
4773
4774 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4775         Dirk Schubert  <dirk.schubert@arm.com>
4776         Chris January  <chris.january@arm.com>
4777
4778         * eval.c (evaluate_subexp_standard): Call Fortran argument
4779         wrapping logic.
4780         * f-lang.c (struct value): A value which can be passed into a
4781         Fortran function call.
4782         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4783         where appropriate.
4784         (struct type): Value ready for a Fortran function call.
4785         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4786         is needed.
4787         * f-lang.h (fortran_argument_convert): Declaration.
4788         (fortran_preserve_arg_pointer): Declaration.
4789         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4790
4791 2019-03-05  Tom Tromey  <tromey@adacore.com>
4792
4793         * python/py-prettyprint.c (print_string_repr): Remove #if.
4794         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4795
4796 2019-03-05  Tom Tromey  <tromey@adacore.com>
4797
4798         * target.c (the_dummy_target): Move later.  Change type to
4799         "dummy_target".
4800         (initialize_targets): Don't initialize the_dummy_target.
4801
4802 2019-03-05  Tom Tromey  <tromey@adacore.com>
4803
4804         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4805         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4806
4807 2019-03-05  Tom Tromey  <tromey@adacore.com>
4808
4809         * windows-nat.c (windows_nat_target::attach)
4810         (windows_nat_target::detach): Don't call gdb_flush.
4811         * valprint.c (generic_val_print, val_print, val_print_string):
4812         Don't call gdb_flush.
4813         * utils.c (defaulted_query): Don't call gdb_flush.
4814         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4815         * target.c (target_announce_detach): Don't call gdb_flush.
4816         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4817         * remote.c (extended_remote_target::attach): Don't call
4818         gdb_flush.
4819         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4820         * printcmd.c (do_examine): Don't call gdb_flush.
4821         (info_display_command): Don't call gdb_flush.
4822         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4823         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4824         * memattr.c (info_mem_command): Don't call gdb_flush.
4825         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4826         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4827         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4828         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4829         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4830         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4831         (gnu_nat_target::detach): Don't call gdb_flush.
4832         * f-valprint.c (f_val_print): Don't call gdb_flush.
4833         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4834         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4835         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4836         gdb_flush.
4837         * c-valprint.c (c_val_print): Don't call gdb_flush.
4838         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4839
4840 2019-03-05  Tom Tromey  <tromey@adacore.com>
4841
4842         * varobj.c (update_dynamic_varobj_children): Update.
4843         (install_default_visualizer): Use reset, not release.
4844         * value.c (set_internalvar): Update.
4845         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4846         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4847         ATTRIBUTE_UNUSED_RESULT.
4848
4849 2019-03-05  Tom Tromey  <tromey@adacore.com>
4850
4851         * remote.c (class scoped_remote_fd) <release>: Add
4852         ATTRIBUTE_UNUSED_RESULT.
4853
4854 2019-03-05  Tom Tromey  <tromey@adacore.com>
4855
4856         * macroexp.c (struct macro_buffer) <release>: Add
4857         ATTRIBUTE_UNUSED_RESULT.
4858
4859 2019-03-05  Tom Tromey  <tromey@adacore.com>
4860
4861         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4862         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4863         ATTRIBUTE_UNUSED_RESULT.
4864
4865 2019-03-05  Tom Tromey  <tromey@adacore.com>
4866
4867         * common/scoped_fd.h (class scoped_fd) <release>: Add
4868         ATTRIBUTE_UNUSED_RESULT.
4869
4870 2019-03-05  Tom Tromey  <tromey@adacore.com>
4871
4872         * parser-defs.h (struct parser_state) <release>: Add
4873         ATTRIBUTE_UNUSED_RESULT.
4874
4875 2019-03-05  Tom Tromey  <tromey@adacore.com>
4876
4877         * utils.h (class gdb_argv) <release>: Add
4878         ATTRIBUTE_UNUSED_RESULT.
4879         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4880
4881 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4882
4883         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4884         for-loop range, to avoid compiler warnings.
4885
4886         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4887         avoid compiler warnings about unused variables.
4888
4889         * NEWS: Mention end of support for native debugging on MS-Windows
4890         before XP.
4891
4892         PR gdb/24292
4893         * common/netstuff.c:
4894         * gdbserver/gdbreplay.c
4895         * gdbserver/remote-utils.c:
4896         * ser-tcp.c:
4897         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4898         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4899         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4900         'getaddrinfo' and 'freeaddrinfo' were not available before
4901         Windows XP, and mingw.org's MinGW headers by default define
4902         _WIN32_WINNT to 0x500.
4903
4904 2019-03-01  Gary Benson <gbenson@redhat.com>
4905
4906         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4907
4908 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4909             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4910
4911         PR gdb/8527
4912         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4913         set_sigint_trap, clear_sigint_trap.
4914
4915 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4916
4917         * target.c (target_detach): Clear the regcache and the
4918         frame cache.
4919
4920 2019-02-27  Pedro Alves  <palves@redhat.com>
4921
4922         * utils.c (set_screen_size): When we cap the height/width sizes,
4923         tweak the corresponding command variable to show "unlimited":
4924
4925 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
4926             Pedro Alves  <palves@redhat.com>
4927
4928         * utils.c (set_screen_size): Reduce "infinite" rows and columns
4929         before calling rl_set_screen_size.
4930
4931 2019-02-27  Tom Tromey  <tromey@adacore.com>
4932
4933         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
4934         define.
4935         * python/py-value.c: Remove Python 2.4 workaround.
4936         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
4937         workaround.
4938         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
4939         Python 2.4 workaround.
4940         * python/python-internal.h: Remove Python 2.4 comment.
4941         (Py_ssize_t): Don't define.
4942         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
4943         (gdb_Py_DECREF): Remove Python 2.4 workaround.
4944         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
4945         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
4946         * python/python.c (do_start_initialization): Remove Python 2.4
4947         workaround.
4948         * python/py-prettyprint.c (class dummy_python_frame): Remove.
4949         (print_children): Remove Python 2.4 workaround.
4950         * python/py-inferior.c (buffer_procs): Remove Python 2.4
4951         workaround.
4952         (CHARBUFFERPROC_NAME): Remove.
4953         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
4954         Python 2.4 workaround.
4955
4956 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4957
4958         * NEWS: Note minimum Python version.
4959
4960 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
4961
4962         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
4963         code from these functions.  Remove corresponding ifdefs.  Use
4964         Py_buffer_up instead of explicit calls to PyBuffer_Release.
4965         Remove gotos and target of gotos.
4966         (infpy_search_memory): Likewise.
4967
4968 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4969
4970         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
4971         (hppa_gdbarch_init): Don't register deleted functions with
4972         gdbarch.
4973
4974 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4975
4976         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
4977         (h8300_unwind_sp): Delete.
4978         (h8300_dummy_id): Delete.
4979         (h8300_gdbarch_init): Don't register deleted functions with
4980         gdbarch.
4981
4982 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4983
4984         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
4985         (ft32_unwind_pc): Delete.
4986         (ft32_unwind_sp): Delete.
4987         (ft32_gdbarch_init): Don't register deleted functions with
4988         gdbarch.
4989
4990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4991
4992         * gdb/frv-tdep.c (frv_dummy_id): Delete.
4993         (frv_unwind_pc): Delete.
4994         (frv_unwind_sp): Delete.
4995         (frv_gdbarch_init): Don't register deleted functions with
4996         gdbarch.
4997
4998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
4999
5000         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5001         (riscv_unwind_pc): Delete.
5002         (riscv_unwind_sp): Delete.
5003         (riscv_gdbarch_init): Don't register deleted functions with
5004         gdbarch.
5005
5006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5007
5008         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5009         (csky_unwind_pc): Delete.
5010         (csky_unwind_sp): Delete.
5011         (csky_gdbarch_init): Don't register deleted functions with
5012         gdbarch.
5013
5014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5015
5016         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5017         (cris_unwind_pc): Delete.
5018         (cris_unwind_sp): Delete.
5019         (cris_gdbarch_init): Don't register deleted functions with
5020         gdbarch.
5021
5022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5023
5024         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5025         (bfin_unwind_pc): Delete.
5026         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5027
5028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5029
5030         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5031         (arm_unwind_pc): Delete.
5032         (arm_unwind_sp): Delete.
5033         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5034
5035 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5036
5037         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5038         (arc_unwind_pc): Delete.
5039         (arc_unwind_sp): Delete.
5040         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5041
5042 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5043
5044         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5045         (alpha_unwind_pc): Delete.
5046         (alpha_gdbarch_init): Don't register deleted functions with
5047         gdbarch.
5048
5049 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5050
5051         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5052         (aarch64_unwind_pc): Delete.
5053         (aarch64_unwind_sp): Delete.
5054         (aarch64_gdbarch_init): Don't register deleted functions with
5055         gdbarch.
5056
5057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5058
5059         * gdbtypes.c (type_align): Don't consider static members when
5060         computing structure alignment.
5061
5062 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5063
5064         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5065         return 0 for other types.
5066         * arch-utils.c (default_type_align): Always return 0.
5067         * gdbarch.h: Regenerate.
5068         * gdbarch.sh (type_align): Extend comment.
5069         * gdbtypes.c (type_align): Add additional comments, always call
5070         gdbarch_type_align before applying the default rules.
5071         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5072         generic code will then apply a suitable default.
5073         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5074         types, return 0 for other types.
5075
5076 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5077
5078         * NEWS: Create a new section for the next release branch.
5079         Rename the section of the current branch, now that it has
5080         been cut.
5081
5082 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5083
5084         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5085         * version.in: Bump version to 8.3.50.DATE-git.
5086
5087 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5088
5089         * aix-thread.c (ptid_cmp): Remove unused variable.
5090         (get_signaled_thread): Likewise.
5091         (store_regs_user_thread): Likewise.
5092         (store_regs_kernel_thread): Likewise.
5093         (fetch_regs_kernel_thread): Remove shadowed variable.
5094
5095 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5096
5097         * features/riscv/32bit-cpu.xml: Add register numbers.
5098         * features/riscv/32bit-fpu.c: Regenerate.
5099         * features/riscv/32bit-fpu.xml: Add register numbers.
5100         * features/riscv/64bit-cpu.xml: Add register numbers.
5101         * features/riscv/64bit-fpu.c: Regenerate.
5102         * features/riscv/64bit-fpu.xml: Add register numbers.
5103
5104 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5105
5106         * NEWS: Mention two argument form of gdb.Value constructor.
5107         * python/py-value.c (convert_buffer_and_type_to_value): New
5108         function.
5109         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5110         Add support for handling an optional second argument.  Call
5111         convert_buffer_and_type_to_value as appropriate.
5112         * python/python-internal.h (Py_buffer_deleter): New struct.
5113         (Py_buffer_up): New typedef.
5114
5115 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5116
5117         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5118         instead of releasing ownership.
5119
5120 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5121
5122         * dwarf2read.c (open_and_init_dwp_file): Call
5123         elf_numsections instead of bfd_count_sections to initialize
5124         dwp_file->num_sections.
5125
5126 2019-02-25  Tom Tromey  <tromey@adacore.com>
5127
5128         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5129
5130 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5131
5132         * gcore.in: Add '--readnever' option when invoking GDB.
5133
5134 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5135
5136         * MAINTAINERS: Update my email address.
5137
5138 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5139
5140         * build-id.c (build_id_to_debug_bfd_1): New function.
5141         (build_id_to_debug_bfd): Look for separate debug file in
5142         sysroot.
5143
5144 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5145
5146         * gdbarch.sh: Update the copyright year range that is placed into
5147         generated files.
5148
5149 2019-02-22  Keith Seitz  <keiths@redhat.com>
5150
5151         PR symtab/23853
5152         * linespec.c (create_sals_line_offset): Search for the default
5153         symtab's filename instead of its fullname.
5154
5155 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5156
5157         * NEWS: Update style defaults.
5158
5159 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5160
5161         * main.c (captured_main_1): Disable styling in batch mode.
5162
5163 2019-02-20  Tom Tromey  <tom@tromey.com>
5164
5165         * symtab.c (symtab_symbol_info): Fix typos.
5166
5167 2019-02-20  Tom Tromey  <tromey@adacore.com>
5168
5169         * findcmd.c (_initialize_mem_search): Use upper case for
5170         metasyntactic variables.
5171
5172 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5173
5174         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5175         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5176
5177 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5178
5179         * top.h (source_file_name): Change to std::string.
5180         * top.c (source_file_name): Likewise.
5181         (command_line_input): Adjust.
5182         * cli/cli-script.c (script_from_file): Adjust.
5183
5184 2019-02-19  Tom Tromey  <tromey@adacore.com>
5185
5186         * ravenscar-thread.c
5187         (ravenscar_thread_target::update_thread_list): Don't call
5188         ada_build_task_list.
5189         * ada-lang.h (ada_build_task_list): Don't declare.
5190         * ada-tasks.c (struct ada_tasks_inferior_data)
5191         <task_list_valid_p>: Now bool.
5192         (read_known_tasks, ada_task_list_changed)
5193         (ada_tasks_invalidate_inferior_data): Update.
5194         (read_known_tasks_array): Return bool.
5195         (read_known_tasks_list): Likewise.
5196         (read_known_tasks): Return void.
5197         (ada_build_task_list): Now static.
5198
5199 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5200
5201         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5202         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5203
5204 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5205
5206         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5207         variant for ada_tasks_pspace_data_handle and
5208         ada_tasks_inferior_data_handle.
5209         (ada_tasks_pspace_data_cleanup): New function.
5210         (ada_tasks_inferior_data_cleanup): New function.
5211
5212 2019-02-17  Tom Tromey  <tom@tromey.com>
5213
5214         * macrotab.h (macro_source_fullname): Return a std::string.
5215         * macrotab.c (macro_include, check_for_redefinition)
5216         (macro_undef, macro_lookup_definition, foreach_macro)
5217         (foreach_macro_in_scope): Update.
5218         (macro_source_fullname): Return a std::string.
5219         * macrocmd.c (show_pp_source_pos): Update.
5220
5221 2019-02-17  Tom Tromey  <tom@tromey.com>
5222
5223         * macrocmd.c (show_pp_source_pos): Style the file names.
5224
5225 2019-02-17  Tom Tromey  <tom@tromey.com>
5226
5227         PR tui/24197:
5228         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5229
5230 2019-02-17  Tom Tromey  <tom@tromey.com>
5231
5232         * ada-lang.c (user_select_syms): Use filtered printing.
5233         * utils.c (wrap_style): New global.
5234         (desired_style): Remove.
5235         (emit_style_escape): Add stream parameter.
5236         (set_output_style, reset_terminal_style, prompt_for_continue):
5237         Update.
5238         (flush_wrap_buffer): Only flush gdb_stdout.
5239         (wrap_here): Set wrap_style.
5240         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5241         treat escape sequences as a character.  Change when wrap buffer is
5242         flushed.
5243         (fputs_styled): Do not set the output style when the default is
5244         requested.
5245         * ui-style.h (struct ui_file_style) <is_default>: New method.
5246         * source.c (print_source_lines_base): Emit escape sequences in one
5247         piece.
5248
5249 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5250
5251         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5252         integers and enumeration types.
5253
5254 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5255
5256         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5257         instead of lookup_symbol_in_language
5258         (do_exact_match): New function.
5259         (ada_get_symbol_name_matcher): Return do_exact_match when
5260         doing a verbatim match.
5261
5262 2019-02-15  Tom Tromey  <tromey@adacore.com>
5263
5264         * ravenscar-thread.c (ravenscar_thread_target::resume)
5265         (ravenscar_thread_target::wait): Special case wildcard requests.
5266
5267 2019-02-15  Tom Tromey  <tromey@adacore.com>
5268
5269         * ravenscar-thread.c (base_ptid): Remove.
5270         (struct ravenscar_thread_target) <close>: New method.
5271         <m_base_ptid>: New member.
5272         <update_inferior_ptid, active_task, task_is_currently_active,
5273         runtime_initialized>: Declare methods.
5274         <ravenscar_thread_target>: Add constructor.
5275         (ravenscar_thread_target::task_is_currently_active)
5276         (ravenscar_thread_target::update_inferior_ptid)
5277         (ravenscar_runtime_initialized): Rename.  Now methods.
5278         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5279         (ravenscar_thread_target::update_thread_list): Update.
5280         (ravenscar_thread_target::active_task): Now method.
5281         (ravenscar_thread_target::store_registers)
5282         (ravenscar_thread_target::prepare_to_store)
5283         (ravenscar_thread_target::prepare_to_store)
5284         (ravenscar_thread_target::mourn_inferior): Update.
5285         (ravenscar_inferior_created): Use "new" to create target.
5286         (ravenscar_thread_target::get_ada_task_ptid): Update.
5287         (_initialize_ravenscar): Don't initialize base_ptid.
5288         (ravenscar_ops): Remove global.
5289
5290 2019-02-15  Tom Tromey  <tromey@adacore.com>
5291
5292         * target.h (push_target): Declare new overload.
5293         * target.c (push_target): New overload, taking an rvalue reference.
5294         * remote.c (remote_target::open_1): Use push_target overload.
5295         * corelow.c (core_target_open): Use push_target overload.
5296
5297 2019-02-15  Tom Tromey  <tromey@adacore.com>
5298
5299         * ravenscar-thread.c (is_ravenscar_task)
5300         (ravenscar_task_is_currently_active): Return bool.
5301         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5302         (_initialize_ravenscar): Remove "(void)".
5303         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5304         Return bool.
5305
5306 2019-02-15  Tom Tromey  <tromey@adacore.com>
5307
5308         * ravenscar-thread.c (ravenscar_runtime_initializer)
5309         (has_ravenscar_runtime, get_running_thread_id)
5310         (ravenscar_thread_target::resume): Fix indentation.
5311
5312 2019-02-15  Tom Tromey  <tromey@adacore.com>
5313
5314         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5315         from ravenscar_arch_ops.
5316         (sparc_ravenscar_ops::fetch_registers)
5317         (sparc_ravenscar_ops::store_registers): Now methods.
5318         (sparc_ravenscar_prepare_to_store): Remove.
5319         (sparc_ravenscar_ops): Redefine.
5320         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5321         methods and destructor.  Remove members.
5322         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5323         (ravenscar_thread_target::store_registers)
5324         (ravenscar_thread_target::prepare_to_store): Update.
5325         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5326         Remove.
5327         (struct ppc_ravenscar_powerpc_ops): Derive from
5328         ravenscar_arch_ops.
5329         (ppc_ravenscar_powerpc_ops::fetch_registers)
5330         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5331         (ppc_ravenscar_powerpc_ops): Redefine.
5332         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5333         (ppc_ravenscar_e500_ops::fetch_registers)
5334         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5335         (ppc_ravenscar_e500_ops): Redefine.
5336         * aarch64-ravenscar-thread.c
5337         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5338         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5339         (aarch64_ravenscar_fetch_registers)
5340         (aarch64_ravenscar_store_registers): Now methods.
5341         (aarch64_ravenscar_ops): Redefine.
5342
5343 2019-02-15  Tom Tromey  <tromey@adacore.com>
5344
5345         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5346         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5347         (ravenscar_thread_target::stopped_by_watchpoint)
5348         (ravenscar_thread_target::stopped_data_address)
5349         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5350
5351 2019-02-15  Tom Tromey  <tromey@adacore.com>
5352
5353         * ravenscar-thread.c: Fix some typos.
5354
5355 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5356             Tom Tromey  <tromey@adacore.com>
5357
5358         * ada-lang.c (ada_exception_sal): Change addr_string to a
5359         std::string.
5360         (create_ada_exception_catchpoint): Update.
5361
5362 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5363             Tom Tromey  <tromey@adacore.com>
5364
5365         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5366         (bp_location_ops): Remove.
5367         (base_breakpoint_allocate_location): Update.
5368         (free_bp_location): Update.
5369         * ada-lang.c (class ada_catchpoint_location)
5370         <ada_catchpoint_location>: Remove ops parameter.
5371         (ada_catchpoint_location_dtor): Remove.
5372         (ada_catchpoint_location_ops): Remove.
5373         (allocate_location_exception): Update.
5374         * breakpoint.h (struct bp_location_ops): Remove.
5375         (class bp_location) <bp_location>: Remove bp_location_ops
5376         parameter.
5377         <~bp_location>: Add destructor.
5378         <ops>: Remove.
5379
5380 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5381             Pedro Alves  <palves@redhat.com>
5382
5383         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5384         'PATH_MAX'.
5385
5386 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5387             Samuel Thibault  <samuel.thibault@gnu.org>
5388             Thomas Schwinge  <thomas@codesourcery.com>
5389
5390         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5391         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5392
5393 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5394
5395         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5396         (check_empty): Use "const char *".
5397
5398         * gnu-nat.c (gnu_nat_target::detach): Instead of
5399         'detach_inferior (pid)' call
5400         'detach_inferior (find_inferior_pid (pid))'.
5401
5402         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5403         'nat/fork-inferior.o'.
5404         * gnu-nat.c: #include "nat/fork-inferior.h".
5405
5406         * gnu-nat.c (gnu_nat_target::detach): Instead of
5407         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5408         * gnu-nat.h: #include "inf-child.h".
5409         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5410         'i386_gnu_nat_target::fetch_registers'.
5411         (gnu_store_registers): Rename/move to
5412         'i386_gnu_nat_target::store_registers'.
5413
5414         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5415         * gnu-nat.h (mach_thread_info): New function.
5416         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5417
5418         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5419
5420 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5421
5422         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5423
5424 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5425
5426         * windows-nat.c (windows_add_thread): Add new parameter
5427         "main_thread_p" with default value set to false.  Update
5428         function documentation as well as all callers.
5429         (windows_delete_thread): Likewise.
5430         (fake_create_process): Update call to windows_add_thread.
5431         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5432         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5433         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5434         call to windows_delete_thread.
5435
5436 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5437
5438         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5439
5440 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5441
5442         * symfile.c (find_separate_debug_file): Use canonical path of
5443         sysroot with child_path instead of gdb_sysroot if it is valid.
5444
5445 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5446
5447         * symfile.c (find_separate_debug_file): Use child_path to
5448         determine if an object file is under a sysroot.
5449
5450 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5451
5452         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5453         unittests/child-path-selftests.c.
5454         * common/pathstuff.c (child_path): New function.
5455         * common/pathstuff.h (child_path): New prototype.
5456         * unittests/child-path-selftests.c: New file.
5457
5458 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5459
5460         * symfile.c (find_separate_debug_file): Look for separate debug
5461         files in debug directories under the sysroot.
5462
5463 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5464
5465         * symtab.h (struct minimal_symbol data_p): New const method.
5466         (struct minimal_symbol text_p): Likewise.
5467         * symtab.c (output_source_filename): Use file name style
5468         to print file name.
5469         (print_symbol_info): Likewise.
5470         (print_msymbol_info): Use address style to print addresses.
5471         Use function name style to print executable text symbols.
5472         (expand_symtab_containing_pc): Use data_p.
5473         (find_pc_sect_compunit_symtab): Likewise.
5474
5475 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5476
5477         * breakpoint.c (describe_other_breakpoints): Use address style
5478         to print addresses.
5479         (say_where): Likewise.
5480
5481 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5482
5483         * ada-typeprint.c (print_func_type): Print function name
5484         style to print function name.
5485         * c-typeprint.c (c_print_type_1): Likewise.
5486
5487 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5488
5489         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5490         for execve.
5491
5492 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5493
5494         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5495         type_stack.
5496
5497 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5498
5499         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5500         TYPE_CODE_REF types.
5501
5502 2019-02-08  Jim Wilson  <jimw@sifive.com>
5503
5504         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5505         (riscv_linux_fregset): New.
5506         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5507
5508 2019-02-07  Tom Tromey  <tom@tromey.com>
5509
5510         * thread.c (thread_cancel_execution_command): Update.
5511         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5512         methods.
5513         (struct thread_fsm_ops): Remove.
5514         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5515         (thread_fsm_should_stop, thread_fsm_return_value)
5516         (thread_fsm_set_finished, thread_fsm_finished_p)
5517         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5518         Don't declare.
5519         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5520         * infrun.c (clear_proceed_status_thread)
5521         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5522         (print_stop_event): Update.
5523         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5524         Add constructor.
5525         (step_command_fsm_ops): Remove.
5526         (new_step_command_fsm): Remove.
5527         (step_1): Update.
5528         (step_command_fsm::should_stop): Rename from
5529         step_command_fsm_should_stop.
5530         (step_command_fsm::clean_up): Rename from
5531         step_command_fsm_clean_up.
5532         (step_command_fsm::do_async_reply_reason): Rename from
5533         step_command_fsm_async_reply_reason.
5534         (struct until_next_fsm): Inherit from thread_fsm.  Add
5535         constructor.
5536         (until_next_fsm_ops): Remove.
5537         (new_until_next_fsm): Remove.
5538         (until_next_fsm::should_stop): Rename from
5539         until_next_fsm_should_stop.
5540         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5541         (until_next_fsm::do_async_reply_reason): Rename from
5542         until_next_fsm_async_reply_reason.
5543         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5544         constructor.  Change type of breakpoint.
5545         (finish_command_fsm_ops): Remove.
5546         (new_finish_command_fsm): Remove.
5547         (finish_command_fsm::should_stop): Rename from
5548         finish_command_fsm_should_stop.
5549         (finish_command_fsm::clean_up): Rename from
5550         finish_command_fsm_clean_up.
5551         (finish_command_fsm::return_value): Rename from
5552         finish_command_fsm_return_value.
5553         (finish_command_fsm::do_async_reply_reason): Rename from
5554         finish_command_fsm_async_reply_reason.
5555         (finish_command): Update.
5556         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5557         Add constructor.
5558         (call_thread_fsm_ops): Remove.
5559         (call_thread_fsm::call_thread_fsm): Rename from
5560         new_call_thread_fsm.
5561         (call_thread_fsm::should_stop): Rename from
5562         call_thread_fsm_should_stop.
5563         (call_thread_fsm::should_notify_stop): Rename from
5564         call_thread_fsm_should_notify_stop.
5565         (run_inferior_call, call_function_by_hand_dummy): Update.
5566         * cli/cli-interp.c (should_print_stop_to_console): Update.
5567         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5568         Add constructor.  Change type of location_breakpoint,
5569         caller_breakpoint.
5570         (until_break_fsm_ops): Remove.
5571         (new_until_break_fsm): Remove.
5572         (until_break_fsm::should_stop): Rename from
5573         until_break_fsm_should_stop.
5574         (until_break_fsm::clean_up): Rename from
5575         until_break_fsm_clean_up.
5576         (until_break_fsm::do_async_reply_reason): Rename from
5577         until_break_fsm_async_reply_reason.
5578         (until_break_command): Update.
5579         * thread-fsm.c: Remove.
5580         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5581
5582 2019-02-07  Tom Tromey  <tom@tromey.com>
5583
5584         * yy-remap.h: Add include guard.
5585         * xtensa-tdep.h: Add include guard.
5586         * xcoffread.h: Rename include guard.
5587         * varobj-iter.h: Add include guard.
5588         * tui/tui.h: Rename include guard.
5589         * tui/tui-winsource.h: Rename include guard.
5590         * tui/tui-wingeneral.h: Rename include guard.
5591         * tui/tui-windata.h: Rename include guard.
5592         * tui/tui-win.h: Rename include guard.
5593         * tui/tui-stack.h: Rename include guard.
5594         * tui/tui-source.h: Rename include guard.
5595         * tui/tui-regs.h: Rename include guard.
5596         * tui/tui-out.h: Rename include guard.
5597         * tui/tui-layout.h: Rename include guard.
5598         * tui/tui-io.h: Rename include guard.
5599         * tui/tui-hooks.h: Rename include guard.
5600         * tui/tui-file.h: Rename include guard.
5601         * tui/tui-disasm.h: Rename include guard.
5602         * tui/tui-data.h: Rename include guard.
5603         * tui/tui-command.h: Rename include guard.
5604         * tic6x-tdep.h: Add include guard.
5605         * target/waitstatus.h: Rename include guard.
5606         * target/wait.h: Rename include guard.
5607         * target/target.h: Rename include guard.
5608         * target/resume.h: Rename include guard.
5609         * target-float.h: Rename include guard.
5610         * stabsread.h: Add include guard.
5611         * rs6000-tdep.h: Add include guard.
5612         * riscv-fbsd-tdep.h: Add include guard.
5613         * regformats/regdef.h: Rename include guard.
5614         * record.h: Rename include guard.
5615         * python/python.h: Rename include guard.
5616         * python/python-internal.h: Rename include guard.
5617         * python/py-stopevent.h: Rename include guard.
5618         * python/py-ref.h: Rename include guard.
5619         * python/py-record.h: Rename include guard.
5620         * python/py-record-full.h: Rename include guard.
5621         * python/py-record-btrace.h: Rename include guard.
5622         * python/py-instruction.h: Rename include guard.
5623         * python/py-events.h: Rename include guard.
5624         * python/py-event.h: Rename include guard.
5625         * procfs.h: Add include guard.
5626         * proc-utils.h: Add include guard.
5627         * p-lang.h: Add include guard.
5628         * or1k-tdep.h: Rename include guard.
5629         * observable.h: Rename include guard.
5630         * nto-tdep.h: Rename include guard.
5631         * nat/x86-linux.h: Rename include guard.
5632         * nat/x86-linux-dregs.h: Rename include guard.
5633         * nat/x86-gcc-cpuid.h: Add include guard.
5634         * nat/x86-dregs.h: Rename include guard.
5635         * nat/x86-cpuid.h: Rename include guard.
5636         * nat/ppc-linux.h: Rename include guard.
5637         * nat/mips-linux-watch.h: Rename include guard.
5638         * nat/linux-waitpid.h: Rename include guard.
5639         * nat/linux-ptrace.h: Rename include guard.
5640         * nat/linux-procfs.h: Rename include guard.
5641         * nat/linux-osdata.h: Rename include guard.
5642         * nat/linux-nat.h: Rename include guard.
5643         * nat/linux-namespaces.h: Rename include guard.
5644         * nat/linux-btrace.h: Rename include guard.
5645         * nat/glibc_thread_db.h: Rename include guard.
5646         * nat/gdb_thread_db.h: Rename include guard.
5647         * nat/gdb_ptrace.h: Rename include guard.
5648         * nat/fork-inferior.h: Rename include guard.
5649         * nat/amd64-linux-siginfo.h: Rename include guard.
5650         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5651         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5652         * nat/aarch64-linux.h: Rename include guard.
5653         * nat/aarch64-linux-hw-point.h: Rename include guard.
5654         * mn10300-tdep.h: Add include guard.
5655         * mips-linux-tdep.h: Add include guard.
5656         * mi/mi-parse.h: Rename include guard.
5657         * mi/mi-out.h: Rename include guard.
5658         * mi/mi-main.h: Rename include guard.
5659         * mi/mi-interp.h: Rename include guard.
5660         * mi/mi-getopt.h: Rename include guard.
5661         * mi/mi-console.h: Rename include guard.
5662         * mi/mi-common.h: Rename include guard.
5663         * mi/mi-cmds.h: Rename include guard.
5664         * mi/mi-cmd-break.h: Rename include guard.
5665         * m2-lang.h: Add include guard.
5666         * location.h: Rename include guard.
5667         * linux-record.h: Rename include guard.
5668         * linux-nat.h: Add include guard.
5669         * linux-fork.h: Add include guard.
5670         * i386-darwin-tdep.h: Rename include guard.
5671         * hppa-linux-offsets.h: Add include guard.
5672         * guile/guile.h: Rename include guard.
5673         * guile/guile-internal.h: Rename include guard.
5674         * gnu-nat.h: Rename include guard.
5675         * gdb-stabs.h: Rename include guard.
5676         * frv-tdep.h: Add include guard.
5677         * f-lang.h: Add include guard.
5678         * event-loop.h: Add include guard.
5679         * darwin-nat.h: Rename include guard.
5680         * cp-abi.h: Rename include guard.
5681         * config/sparc/nm-sol2.h: Rename include guard.
5682         * config/nm-nto.h: Rename include guard.
5683         * config/nm-linux.h: Add include guard.
5684         * config/i386/nm-i386gnu.h: Rename include guard.
5685         * config/djgpp/nl_types.h: Rename include guard.
5686         * config/djgpp/langinfo.h: Rename include guard.
5687         * compile/gcc-cp-plugin.h: Add include guard.
5688         * compile/gcc-c-plugin.h: Add include guard.
5689         * compile/compile.h: Rename include guard.
5690         * compile/compile-object-run.h: Rename include guard.
5691         * compile/compile-object-load.h: Rename include guard.
5692         * compile/compile-internal.h: Rename include guard.
5693         * compile/compile-cplus.h: Rename include guard.
5694         * compile/compile-c.h: Rename include guard.
5695         * common/xml-utils.h: Rename include guard.
5696         * common/x86-xstate.h: Rename include guard.
5697         * common/version.h: Rename include guard.
5698         * common/vec.h: Rename include guard.
5699         * common/tdesc.h: Rename include guard.
5700         * common/selftest.h: Rename include guard.
5701         * common/scoped_restore.h: Rename include guard.
5702         * common/scoped_mmap.h: Rename include guard.
5703         * common/scoped_fd.h: Rename include guard.
5704         * common/safe-iterator.h: Rename include guard.
5705         * common/run-time-clock.h: Rename include guard.
5706         * common/refcounted-object.h: Rename include guard.
5707         * common/queue.h: Rename include guard.
5708         * common/ptid.h: Rename include guard.
5709         * common/print-utils.h: Rename include guard.
5710         * common/preprocessor.h: Rename include guard.
5711         * common/pathstuff.h: Rename include guard.
5712         * common/observable.h: Rename include guard.
5713         * common/netstuff.h: Rename include guard.
5714         * common/job-control.h: Rename include guard.
5715         * common/host-defs.h: Rename include guard.
5716         * common/gdb_wait.h: Rename include guard.
5717         * common/gdb_vecs.h: Rename include guard.
5718         * common/gdb_unlinker.h: Rename include guard.
5719         * common/gdb_unique_ptr.h: Rename include guard.
5720         * common/gdb_tilde_expand.h: Rename include guard.
5721         * common/gdb_sys_time.h: Rename include guard.
5722         * common/gdb_string_view.h: Rename include guard.
5723         * common/gdb_splay_tree.h: Rename include guard.
5724         * common/gdb_setjmp.h: Rename include guard.
5725         * common/gdb_ref_ptr.h: Rename include guard.
5726         * common/gdb_optional.h: Rename include guard.
5727         * common/gdb_locale.h: Rename include guard.
5728         * common/gdb_assert.h: Rename include guard.
5729         * common/filtered-iterator.h: Rename include guard.
5730         * common/filestuff.h: Rename include guard.
5731         * common/fileio.h: Rename include guard.
5732         * common/environ.h: Rename include guard.
5733         * common/common-utils.h: Rename include guard.
5734         * common/common-types.h: Rename include guard.
5735         * common/common-regcache.h: Rename include guard.
5736         * common/common-inferior.h: Rename include guard.
5737         * common/common-gdbthread.h: Rename include guard.
5738         * common/common-exceptions.h: Rename include guard.
5739         * common/common-defs.h: Rename include guard.
5740         * common/common-debug.h: Rename include guard.
5741         * common/cleanups.h: Rename include guard.
5742         * common/buffer.h: Rename include guard.
5743         * common/btrace-common.h: Rename include guard.
5744         * common/break-common.h: Rename include guard.
5745         * cli/cli-utils.h: Rename include guard.
5746         * cli/cli-style.h: Rename include guard.
5747         * cli/cli-setshow.h: Rename include guard.
5748         * cli/cli-script.h: Rename include guard.
5749         * cli/cli-interp.h: Rename include guard.
5750         * cli/cli-decode.h: Rename include guard.
5751         * cli/cli-cmds.h: Rename include guard.
5752         * charset-list.h: Add include guard.
5753         * buildsym-legacy.h: Rename include guard.
5754         * bfin-tdep.h: Add include guard.
5755         * ax.h: Rename include guard.
5756         * arm-linux-tdep.h: Add include guard.
5757         * arm-fbsd-tdep.h: Add include guard.
5758         * arch/xtensa.h: Rename include guard.
5759         * arch/tic6x.h: Add include guard.
5760         * arch/i386.h: Add include guard.
5761         * arch/arm.h: Rename include guard.
5762         * arch/arm-linux.h: Rename include guard.
5763         * arch/arm-get-next-pcs.h: Rename include guard.
5764         * arch/amd64.h: Add include guard.
5765         * arch/aarch64-insn.h: Rename include guard.
5766         * arch-utils.h: Rename include guard.
5767         * annotate.h: Add include guard.
5768         * amd64-darwin-tdep.h: Rename include guard.
5769         * aarch64-linux-tdep.h: Add include guard.
5770         * aarch64-fbsd-tdep.h: Add include guard.
5771         * aarch32-linux-nat.h: Add include guard.
5772
5773 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5774
5775         * macrotab.c (macro_define_internal): New function that
5776         factorizes macro_define_object_internal and macro_define_function
5777         code.
5778         (macro_define_object_internal): Use macro_define_internal.
5779         (macro_define_function): Likewise.
5780
5781 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5782
5783         * macrocmd.c (extract_identifier): Return
5784         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5785         callers.
5786
5787 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5788
5789         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5790
5791 2019-02-05  Tom Tromey  <tom@tromey.com>
5792
5793         * target.c (target_stack::unpush): Move assertion earlier.
5794
5795 2019-01-30  Tom Tromey  <tom@tromey.com>
5796
5797         PR python/23615:
5798         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5799         (gdbpy_parse_and_eval): Likewise.
5800         * python/python-internal.h (gdbpy_allow_threads): New class.
5801
5802 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5803
5804         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5805         (aarch64_fbsd_fpregmap): Move earlier.
5806         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5807         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5808         instead of individual calls to trad_frame_set_reg_addr.
5809         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5810         earlier.
5811         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5812         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5813         instead of individual calls to trad_frame_set_reg_addr.
5814
5815 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5816
5817         * CONTRIBUTE: Replace contribution list with wiki link.
5818
5819 2019-01-25  Tom Tromey  <tom@tromey.com>
5820
5821         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5822
5823 2019-01-25  Tom Tromey  <tom@tromey.com>
5824
5825         * xtensa-linux-nat.c: Fix common/ includes.
5826         * xml-support.h: Fix common/ includes.
5827         * xml-support.c: Fix common/ includes.
5828         * x86-linux-nat.c: Fix common/ includes.
5829         * windows-nat.c: Fix common/ includes.
5830         * varobj.h: Fix common/ includes.
5831         * varobj.c: Fix common/ includes.
5832         * value.c: Fix common/ includes.
5833         * valops.c: Fix common/ includes.
5834         * utils.c: Fix common/ includes.
5835         * unittests/xml-utils-selftests.c: Fix common/ includes.
5836         * unittests/utils-selftests.c: Fix common/ includes.
5837         * unittests/unpack-selftests.c: Fix common/ includes.
5838         * unittests/tracepoint-selftests.c: Fix common/ includes.
5839         * unittests/style-selftests.c: Fix common/ includes.
5840         * unittests/string_view-selftests.c: Fix common/ includes.
5841         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5842         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5843         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5844         * unittests/rsp-low-selftests.c: Fix common/ includes.
5845         * unittests/parse-connection-spec-selftests.c: Fix common/
5846         includes.
5847         * unittests/optional-selftests.c: Fix common/ includes.
5848         * unittests/offset-type-selftests.c: Fix common/ includes.
5849         * unittests/observable-selftests.c: Fix common/ includes.
5850         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5851         * unittests/memrange-selftests.c: Fix common/ includes.
5852         * unittests/memory-map-selftests.c: Fix common/ includes.
5853         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5854         * unittests/function-view-selftests.c: Fix common/ includes.
5855         * unittests/environ-selftests.c: Fix common/ includes.
5856         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5857         * unittests/common-utils-selftests.c: Fix common/ includes.
5858         * unittests/cli-utils-selftests.c: Fix common/ includes.
5859         * unittests/array-view-selftests.c: Fix common/ includes.
5860         * ui-file.c: Fix common/ includes.
5861         * tui/tui-io.c: Fix common/ includes.
5862         * tracepoint.h: Fix common/ includes.
5863         * tracepoint.c: Fix common/ includes.
5864         * tracefile-tfile.c: Fix common/ includes.
5865         * top.h: Fix common/ includes.
5866         * top.c: Fix common/ includes.
5867         * thread.c: Fix common/ includes.
5868         * target/waitstatus.h: Fix common/ includes.
5869         * target/waitstatus.c: Fix common/ includes.
5870         * target.h: Fix common/ includes.
5871         * target.c: Fix common/ includes.
5872         * target-memory.c: Fix common/ includes.
5873         * target-descriptions.c: Fix common/ includes.
5874         * symtab.h: Fix common/ includes.
5875         * symfile.c: Fix common/ includes.
5876         * stap-probe.c: Fix common/ includes.
5877         * spu-linux-nat.c: Fix common/ includes.
5878         * sparc-nat.c: Fix common/ includes.
5879         * source.c: Fix common/ includes.
5880         * solib.c: Fix common/ includes.
5881         * solib-target.c: Fix common/ includes.
5882         * ser-unix.c: Fix common/ includes.
5883         * ser-tcp.c: Fix common/ includes.
5884         * ser-pipe.c: Fix common/ includes.
5885         * ser-base.c: Fix common/ includes.
5886         * selftest-arch.c: Fix common/ includes.
5887         * s12z-tdep.c: Fix common/ includes.
5888         * rust-exp.y: Fix common/ includes.
5889         * rs6000-aix-tdep.c: Fix common/ includes.
5890         * riscv-tdep.c: Fix common/ includes.
5891         * remote.c: Fix common/ includes.
5892         * remote-notif.h: Fix common/ includes.
5893         * remote-fileio.h: Fix common/ includes.
5894         * remote-fileio.c: Fix common/ includes.
5895         * regcache.h: Fix common/ includes.
5896         * regcache.c: Fix common/ includes.
5897         * record-btrace.c: Fix common/ includes.
5898         * python/python.c: Fix common/ includes.
5899         * python/py-type.c: Fix common/ includes.
5900         * python/py-inferior.c: Fix common/ includes.
5901         * progspace.h: Fix common/ includes.
5902         * producer.c: Fix common/ includes.
5903         * procfs.c: Fix common/ includes.
5904         * proc-api.c: Fix common/ includes.
5905         * printcmd.c: Fix common/ includes.
5906         * ppc-linux-nat.c: Fix common/ includes.
5907         * parser-defs.h: Fix common/ includes.
5908         * osdata.c: Fix common/ includes.
5909         * obsd-nat.c: Fix common/ includes.
5910         * nat/x86-linux.c: Fix common/ includes.
5911         * nat/x86-linux-dregs.c: Fix common/ includes.
5912         * nat/x86-dregs.h: Fix common/ includes.
5913         * nat/x86-dregs.c: Fix common/ includes.
5914         * nat/ppc-linux.c: Fix common/ includes.
5915         * nat/mips-linux-watch.h: Fix common/ includes.
5916         * nat/mips-linux-watch.c: Fix common/ includes.
5917         * nat/linux-waitpid.c: Fix common/ includes.
5918         * nat/linux-ptrace.h: Fix common/ includes.
5919         * nat/linux-ptrace.c: Fix common/ includes.
5920         * nat/linux-procfs.c: Fix common/ includes.
5921         * nat/linux-personality.c: Fix common/ includes.
5922         * nat/linux-osdata.c: Fix common/ includes.
5923         * nat/linux-namespaces.c: Fix common/ includes.
5924         * nat/linux-btrace.h: Fix common/ includes.
5925         * nat/linux-btrace.c: Fix common/ includes.
5926         * nat/fork-inferior.c: Fix common/ includes.
5927         * nat/amd64-linux-siginfo.c: Fix common/ includes.
5928         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
5929         * nat/aarch64-linux.c: Fix common/ includes.
5930         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
5931         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
5932         * namespace.h: Fix common/ includes.
5933         * mips-linux-tdep.c: Fix common/ includes.
5934         * minsyms.c: Fix common/ includes.
5935         * mi/mi-parse.h: Fix common/ includes.
5936         * mi/mi-main.c: Fix common/ includes.
5937         * mi/mi-cmd-env.c: Fix common/ includes.
5938         * memrange.h: Fix common/ includes.
5939         * memattr.c: Fix common/ includes.
5940         * maint.h: Fix common/ includes.
5941         * maint.c: Fix common/ includes.
5942         * main.c: Fix common/ includes.
5943         * machoread.c: Fix common/ includes.
5944         * location.c: Fix common/ includes.
5945         * linux-thread-db.c: Fix common/ includes.
5946         * linux-nat.c: Fix common/ includes.
5947         * linux-fork.c: Fix common/ includes.
5948         * inline-frame.c: Fix common/ includes.
5949         * infrun.c: Fix common/ includes.
5950         * inflow.c: Fix common/ includes.
5951         * inferior.h: Fix common/ includes.
5952         * inferior.c: Fix common/ includes.
5953         * infcmd.c: Fix common/ includes.
5954         * inf-ptrace.c: Fix common/ includes.
5955         * inf-child.c: Fix common/ includes.
5956         * ia64-linux-nat.c: Fix common/ includes.
5957         * i387-tdep.c: Fix common/ includes.
5958         * i386-tdep.c: Fix common/ includes.
5959         * i386-linux-tdep.c: Fix common/ includes.
5960         * i386-linux-nat.c: Fix common/ includes.
5961         * i386-go32-tdep.c: Fix common/ includes.
5962         * i386-fbsd-tdep.c: Fix common/ includes.
5963         * i386-fbsd-nat.c: Fix common/ includes.
5964         * guile/scm-type.c: Fix common/ includes.
5965         * guile/guile.c: Fix common/ includes.
5966         * go32-nat.c: Fix common/ includes.
5967         * gnu-nat.c: Fix common/ includes.
5968         * gdbthread.h: Fix common/ includes.
5969         * gdbarch-selftests.c: Fix common/ includes.
5970         * gdb_usleep.c: Fix common/ includes.
5971         * gdb_select.h: Fix common/ includes.
5972         * gdb_bfd.c: Fix common/ includes.
5973         * gcore.c: Fix common/ includes.
5974         * fork-child.c: Fix common/ includes.
5975         * findvar.c: Fix common/ includes.
5976         * fbsd-nat.c: Fix common/ includes.
5977         * event-top.c: Fix common/ includes.
5978         * event-loop.c: Fix common/ includes.
5979         * dwarf2read.c: Fix common/ includes.
5980         * dwarf2loc.c: Fix common/ includes.
5981         * dwarf2-frame.c: Fix common/ includes.
5982         * dwarf-index-cache.c: Fix common/ includes.
5983         * dtrace-probe.c: Fix common/ includes.
5984         * disasm-selftests.c: Fix common/ includes.
5985         * defs.h: Fix common/ includes.
5986         * csky-tdep.c: Fix common/ includes.
5987         * cp-valprint.c: Fix common/ includes.
5988         * cp-support.h: Fix common/ includes.
5989         * cp-support.c: Fix common/ includes.
5990         * corelow.c: Fix common/ includes.
5991         * completer.h: Fix common/ includes.
5992         * completer.c: Fix common/ includes.
5993         * compile/compile.c: Fix common/ includes.
5994         * compile/compile-loc2c.c: Fix common/ includes.
5995         * compile/compile-cplus-types.c: Fix common/ includes.
5996         * compile/compile-cplus-symbols.c: Fix common/ includes.
5997         * command.h: Fix common/ includes.
5998         * cli/cli-dump.c: Fix common/ includes.
5999         * cli/cli-cmds.c: Fix common/ includes.
6000         * charset.c: Fix common/ includes.
6001         * build-id.c: Fix common/ includes.
6002         * btrace.h: Fix common/ includes.
6003         * btrace.c: Fix common/ includes.
6004         * breakpoint.h: Fix common/ includes.
6005         * breakpoint.c: Fix common/ includes.
6006         * ax.h:
6007         (enum agent_op): Fix common/ includes.
6008         * ax-general.c (struct aop_map): Fix common/ includes.
6009         * ax-gdb.c: Fix common/ includes.
6010         * auxv.c: Fix common/ includes.
6011         * auto-load.c: Fix common/ includes.
6012         * arm-tdep.c: Fix common/ includes.
6013         * arch/riscv.c: Fix common/ includes.
6014         * arch/ppc-linux-common.c: Fix common/ includes.
6015         * arch/i386.c: Fix common/ includes.
6016         * arch/arm.c: Fix common/ includes.
6017         * arch/arm-linux.c: Fix common/ includes.
6018         * arch/arm-get-next-pcs.c: Fix common/ includes.
6019         * arch/amd64.c: Fix common/ includes.
6020         * arch/aarch64.c: Fix common/ includes.
6021         * arch/aarch64-insn.c: Fix common/ includes.
6022         * arch-utils.c: Fix common/ includes.
6023         * amd64-windows-tdep.c: Fix common/ includes.
6024         * amd64-tdep.c: Fix common/ includes.
6025         * amd64-sol2-tdep.c: Fix common/ includes.
6026         * amd64-obsd-tdep.c: Fix common/ includes.
6027         * amd64-nbsd-tdep.c: Fix common/ includes.
6028         * amd64-linux-tdep.c: Fix common/ includes.
6029         * amd64-linux-nat.c: Fix common/ includes.
6030         * amd64-fbsd-tdep.c: Fix common/ includes.
6031         * amd64-fbsd-nat.c: Fix common/ includes.
6032         * amd64-dicos-tdep.c: Fix common/ includes.
6033         * amd64-darwin-tdep.c: Fix common/ includes.
6034         * agent.c: Fix common/ includes.
6035         * ada-lang.h: Fix common/ includes.
6036         * ada-lang.c: Fix common/ includes.
6037         * aarch64-tdep.c: Fix common/ includes.
6038
6039 2019-01-25  Tom Tromey  <tom@tromey.com>
6040
6041         * common/create-version.sh: Use common/version.h.
6042
6043 2019-01-24  Pedro Alves  <palves@redhat.com>
6044
6045         * infrun.c (signal_stop, signal_print, signal_program)
6046         (signal_catch, signal_pass): Now arrays instead of pointers.
6047         (update_signals_program_target, do_target_resume)
6048         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6049         * linux-nat.c (linux_nat_target::pass_signals)
6050         (linux_nat_target::create_inferior, linux_nat_target::attach):
6051         Adjust.
6052         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6053         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6054         * procfs.c (procfs_target::pass_signals): Adjust.
6055         * record-full.c (record_full_target::resume): Adjust.
6056         * remote.c (remote_target::pass_signals)
6057         (remote_target::program_signals): Adjust.
6058         * target-debug.h (target_debug_print_signals): Now takes a
6059         gdb::array_view as parameter.  Adjust.
6060         * target.h (target_ops) <pass_signals, program_signals>: Replace
6061         pointer and length parameters with gdb::array_view.
6062         (target_pass_signals, target_program_signals): Likewise.
6063         * target-delegates.c: Regenerate.
6064
6065 2019-01-24  Pedro Alves  <palves@redhat.com>
6066
6067         * common/forward-scope-exit.h
6068         (forward_scope_exit::forward_scope_exit): Pass arguments to
6069         m_bind_function directly, instead of creating a std::bind and
6070         copying that.
6071
6072 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6073
6074         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6075         for static members.
6076         (pass_in_v_vfp_candidate): Likewise.
6077
6078 2019-01-23  Tom Tromey  <tom@tromey.com>
6079             Pedro Alves  <palves@redhat.com>
6080
6081         * regcache.c (class regcache_invalidator): Remove.
6082         (regcache::raw_write): Use make_scope_exit.
6083
6084 2019-01-23  Tom Tromey  <tom@tromey.com>
6085
6086         * ui-out.h (class ui_out_emit_type): Update comment.
6087
6088 2019-01-23  Tom Tromey  <tom@tromey.com>
6089
6090         * infrun.c (fetch_inferior_event): Update comment.
6091
6092 2019-01-23  Tom Tromey  <tom@tromey.com>
6093             Pedro Alves  <palves@redhat.com>
6094
6095         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6096         parameter.
6097         (fetch_inferior_event): Use SCOPE_EXIT.
6098
6099
6100 2019-01-23  Tom Tromey  <tom@tromey.com>
6101             Pedro Alves  <palves@redhat.com>
6102
6103         * infrun.c (disable_thread_events): Delete.
6104         (stop_all_threads): Use SCOPE_EXIT.
6105
6106 2019-01-23  Tom Tromey  <tom@tromey.com>
6107             Pedro Alves  <palves@redhat.com>
6108
6109         * symfile.c: Include forward-scope-exit.h.
6110         (clear_symtab_users_cleanup): Replace forward declaration with
6111         a FORWARD_SCOPE_EXIT.
6112         (syms_from_objfile_1): Use the forward_scope_exit and
6113         gdb::optional instead of cleanup_function.
6114         (reread_symbols): Use the forward_scope_exit instead of
6115         cleanup_function.
6116         (clear_symtab_users_cleanup): Remove function.
6117
6118 2019-01-23  Tom Tromey  <tom@tromey.com>
6119             Pedro Alves  <palves@redhat.com>
6120
6121         * linux-nat.c: Include scope-exit.h.
6122         (cleanup_target_stop): Remove.
6123         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6124         SCOPE_EXIT.
6125
6126 2019-01-23  Tom Tromey  <tom@tromey.com>
6127             Pedro Alves  <palves@redhat.com>
6128
6129         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6130         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6131
6132 2019-01-23  Tom Tromey  <tom@tromey.com>
6133             Andrew Burgess  <andrew.burgess@embecosm.com>
6134             Pedro Alves  <palves@redhat.com>
6135
6136         * infrun.c (fetch_inferior_event): Use scope_exit.
6137         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6138         * top.c (execute_command): Use scope_exit.
6139         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6140         * utils.c (do_bpstat_clear_actions_cleanup)
6141         (make_bpstat_clear_actions_cleanup): Remove.
6142
6143 2019-01-23  Tom Tromey  <tom@tromey.com>
6144             Pedro Alves  <palves@redhat.com>
6145
6146         * infrun.c: Include "common/scope-exit.h"
6147         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6148         (wait_for_inferior): Use SCOPE_EXIT.
6149         (fetch_inferior_event): Use scope_exit.
6150
6151 2019-01-23  Tom Tromey  <tom@tromey.com>
6152             Pedro Alves  <palves@redhat.com>
6153
6154         * breakpoint.c (create_breakpoint): Remove cleanup.
6155
6156 2019-01-23  Tom Tromey  <tom@tromey.com>
6157             Andrew Burgess  <andrew.burgess@embecosm.com>
6158             Pedro Alves  <palves@redhat.com>
6159
6160 2019-01-23  Pedro Alves  <palves@redhat.com>
6161
6162         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6163
6164 2019-01-23  Pedro Alves  <palves@redhat.com>
6165             Andrew Burgess  <andrew.burgess@embecosm.com>
6166
6167         * gdbthread.h: Include "common/forward-scope-exit.h".
6168         (scoped_finish_thread_state): Redefine custom class in terms of
6169         forward_scope_exit.
6170
6171 2019-01-23  Pedro Alves  <palves@redhat.com>
6172             Andrew Burgess  <andrew.burgess@embecosm.com>
6173
6174         * common/forward-scope-exit.h: New file.
6175
6176 2019-01-23  Pedro Alves  <palves@redhat.com>
6177             Andrew Burgess  <andrew.burgess@embecosm.com>
6178             Tom Tromey  <tom@tromey.com>
6179
6180         * common/scope-exit.h: New file.
6181
6182 2019-01-23  Pedro Alves  <palves@redhat.com>
6183
6184         * common/preprocessor.h (ESC): Rename to ...
6185         (ESC_PARENS): ... this.
6186         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6187         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6188
6189 2019-01-23  Tom Tromey  <tom@tromey.com>
6190
6191         * language.h (class scoped_switch_to_sym_language_if_auto):
6192         Initialize m_lang in both cases.
6193
6194 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6195
6196         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6197         with XCNEW.
6198
6199 2019-01-22  Tom Tromey  <tom@tromey.com>
6200
6201         * corelow.c: Do not include sys/file.h.
6202
6203 2019-01-22  Tom Tromey  <tom@tromey.com>
6204
6205         * tui/tui-wingeneral.h: Include gdb_curses.h.
6206
6207 2019-01-22  Tom Tromey  <tom@tromey.com>
6208
6209         * source-cache.h (class source_cache) <get_source_lines,
6210         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6211
6212 2019-01-22  Tom Tromey  <tom@tromey.com>
6213
6214         * remote-fileio.h (struct remote_target): Declare.
6215
6216 2019-01-22  Tom Tromey  <tom@tromey.com>
6217
6218         * python/py-arch.c: Do not include py-ref.h.
6219         * python/py-bpevent.c: Do not include py-ref.h.
6220         * python/py-cmd.c: Do not include py-ref.h.
6221         * python/py-continueevent.c: Do not include py-ref.h.
6222         * python/py-event.h: Do not include py-ref.h.
6223         * python/py-evtregistry.c: Do not include py-ref.h.
6224         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6225         * python/py-frame.c: Do not include py-ref.h.
6226         * python/py-framefilter.c: Do not include py-ref.h.
6227         * python/py-function.c: Do not include py-ref.h.
6228         * python/py-infevents.c: Do not include py-ref.h.
6229         * python/py-linetable.c: Do not include py-ref.h.
6230         * python/py-objfile.c: Do not include py-ref.h.
6231         * python/py-param.c: Do not include py-ref.h.
6232         * python/py-prettyprint.c: Do not include py-ref.h.
6233         * python/py-progspace.c: Do not include py-ref.h.
6234         * python/py-symbol.c: Do not include py-ref.h.
6235         * python/py-symtab.c: Do not include py-ref.h.
6236         * python/py-type.c: Do not include py-ref.h.
6237         * python/py-unwind.c: Do not include py-ref.h.
6238         * python/py-utils.c: Do not include py-ref.h.
6239         * python/py-value.c: Do not include py-ref.h.
6240         * python/py-varobj.c: Do not include py-ref.h.
6241         * python/py-xmethods.c: Do not include py-ref.h.
6242         * python/python.c: Do not include py-ref.h.
6243         * varobj.c: Do not include py-ref.h.
6244
6245 2019-01-22  Tom Tromey  <tom@tromey.com>
6246
6247         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6248         keyword for bcache.
6249
6250 2019-01-22  Tom Tromey  <tom@tromey.com>
6251
6252         * compile/compile-cplus-types.c: Remove a comment by #include.
6253
6254 2019-01-22  Tom Tromey  <tom@tromey.com>
6255
6256         * compile/gcc-c-plugin.h: Include compile-internal.h.
6257
6258 2019-01-22  Tom Tromey  <tom@tromey.com>
6259
6260         * stabsread.c (EXTERN): Do not define.
6261         (symnum, next_symbol_text_func, processing_gcc_compilation)
6262         (within_function, global_sym_chain, global_stabs)
6263         (previous_stab_code, this_object_header_files)
6264         (n_this_object_header_files)
6265         (n_allocated_this_object_header_files): Define.
6266         * stabsread.h (EXTERN): Never define.  Use "extern".
6267
6268 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6269
6270         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6271         history_value.
6272
6273 2019-01-21  Tom Tromey  <tom@tromey.com>
6274
6275         * ui-out.c: Fix includes.
6276         * tui/tui-source.c: Fix includes.
6277         * target.c: Fix includes.
6278         * remote.c: Fix includes.
6279         * regcache.c: Fix includes.
6280         * python/py-block.c: Fix includes.
6281         * printcmd.c: Fix includes.
6282         * or1k-tdep.c: Fix includes.
6283         * mi/mi-main.c: Fix includes.
6284         * m32r-tdep.c: Fix includes.
6285         * csky-tdep.c: Fix includes.
6286         * compile/compile-cplus-types.c: Fix includes.
6287         * cli/cli-interp.c: Fix includes.
6288
6289 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6290
6291         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6292         for padding.
6293
6294 2019-01-16  Tom Tromey  <tom@tromey.com>
6295
6296         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6297         earlier.
6298         (struct objfile) <msymbols_range>: Move from top level.
6299         <msymbols>: New method.
6300         (class objfile_msymbols): Remove.
6301         * symtab.c (default_collect_symbol_completion_matches_break_on):
6302         Update.
6303         * symmisc.c (dump_msymbols): Update.
6304         * stabsread.c (scan_file_globals): Update.
6305         * objc-lang.c (info_selectors_command, info_classes_command)
6306         (find_methods): Update.
6307         * minsyms.c (find_solib_trampoline_target): Update.
6308         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6309         * coffread.c (coff_symfile_read): Update.
6310         * ada-lang.c (ada_lookup_simple_minsym)
6311         (ada_collect_symbol_completion_matches): Update.
6312
6313 2019-01-16  Tom Tromey  <tom@tromey.com>
6314
6315         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6316         type.  Remove no-argument constructor.
6317         <iterator::operator++>: Simplify.
6318         <begin>: Update.
6319         <end>: Use minimal_symbol_count.
6320
6321 2019-01-16  Tom Tromey  <tom@tromey.com>
6322
6323         * objfiles.h (struct objfile) <psymtabs>: New method.
6324         (class objfile_psymtabs): Remove.
6325         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6326         typedef.
6327         <range>: New method.
6328         (require_partial_symbols): Change return type.
6329         * psymtab.c (require_partial_symbols)
6330         (psym_expand_symtabs_matching): Update.
6331         * mdebugread.c (parse_partial_symbols): Update.
6332         * dbxread.c (dbx_end_psymtab): Update.
6333
6334 2019-01-15  Tom Tromey  <tom@tromey.com>
6335
6336         * symtab.c (lookup_objfile_from_block)
6337         (lookup_symbol_in_objfile_symtabs)
6338         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6339         (find_line_symtab, info_sources_command)
6340         (default_collect_symbol_completion_matches_break_on)
6341         (make_source_files_completion_list): Update.
6342         * symmisc.c (print_objfile_statistics, dump_objfile)
6343         (maintenance_print_symbols, maintenance_info_symtabs)
6344         (maintenance_check_symtabs, maintenance_info_line_tables):
6345         Update.
6346         * source.c (select_source_symtab)
6347         (forget_cached_source_info_for_objfile): Update.
6348         * objfiles.h (class objfile_compunits): Remove.
6349         (struct objfile) <compunits_range>: New typedef.
6350         (compunits): New method.
6351         * objfiles.c (objfile_relocate1): Update.
6352         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6353         * maint.c (count_symtabs_and_blocks): Update.
6354         * linespec.c (iterate_over_all_matching_symtabs): Update.
6355         * cp-support.c (add_symbol_overload_list_qualified): Update.
6356         * coffread.c (coff_symtab_read): Update.
6357         * ada-lang.c (add_nonlocal_symbols)
6358         (ada_collect_symbol_completion_matches)
6359         (ada_add_global_exceptions): Update.
6360
6361 2019-01-15  Tom Tromey  <tom@tromey.com>
6362
6363         * progspace.h (program_space) <objfiles_safe_range>: New
6364         typedef.
6365         <objfiles_safe>: New method.
6366         * objfiles.h (class all_objfiles_safe): Remove.
6367         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6368         * jit.c (jit_inferior_exit_hook): Update.
6369
6370 2019-01-17  Tom Tromey  <tom@tromey.com>
6371
6372         * progspace.h (program_space) <objfiles_range>: New typedef.
6373         <objfiles>: New method.
6374         <objfiles_head>: Rename from objfiles.
6375         (object_files): Update.
6376         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6377         * guile/scm-pretty-print.c
6378         (ppscm_find_pretty_printer_from_objfiles): Update.
6379         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6380         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6381         Update.
6382         * python/py-progspace.c (pspy_get_objfiles): Update.
6383         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6384         Update.
6385         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6386         (objfpy_lookup_objfile_by_build_id): Update.
6387         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6388         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6389         Update.
6390         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6391         (expand_symtab_containing_pc, lookup_objfile_from_block)
6392         (lookup_static_symbol, basic_lookup_transparent_type)
6393         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6394         (find_line_symtab, info_sources_command)
6395         (default_collect_symbol_completion_matches_break_on)
6396         (make_source_files_completion_list, find_main_name): Update.
6397         * symmisc.c (print_symbol_bcache_statistics)
6398         (print_objfile_statistics, maintenance_print_symbols)
6399         (maintenance_print_msymbols, maintenance_print_objfiles)
6400         (maintenance_info_symtabs, maintenance_check_symtabs)
6401         (maintenance_expand_symtabs, maintenance_info_line_tables):
6402         Update.
6403         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6404         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6405         (map_overlay_command, unmap_overlay_command)
6406         (simple_overlay_update, expand_symtabs_matching)
6407         (map_symbol_filenames): Update.
6408         * symfile-debug.c (set_debug_symfile): Update.
6409         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6410         Update.
6411         * source.c (select_source_symtab, forget_cached_source_info):
6412         Update.
6413         * solib.c (solib_read_symbols): Update.
6414         * solib-spu.c (append_ocl_sos): Update.
6415         * psymtab.c (maintenance_print_psymbols)
6416         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6417         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6418         * printcmd.c (info_symbol_command): Update.
6419         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6420         Update.
6421         * objfiles.h (class all_objfiles): Remove.
6422         * objfiles.c (have_partial_symbols, have_full_symbols)
6423         (have_minimal_symbols, qsort_cmp, update_section_map)
6424         (shared_objfile_contains_address_p)
6425         (default_iterate_over_objfiles_in_search_order): Update.
6426         * objc-lang.c (info_selectors_command, info_classes_command)
6427         (find_methods): Update.
6428         * minsyms.c (find_solib_trampoline_target): Update.
6429         * maint.c (maintenance_info_sections)
6430         (maintenance_translate_address, count_symtabs_and_blocks):
6431         Update.
6432         * main.c (captured_main_1): Update.
6433         * linux-thread-db.c (try_thread_db_load_from_pdir)
6434         (has_libpthread): Update.
6435         * linespec.c (iterate_over_all_matching_symtabs)
6436         (search_minsyms_for_name): Update.
6437         * jit.c (jit_find_objf_with_entry_addr): Update.
6438         * hppa-tdep.c (find_unwind_entry)
6439         (hppa_lookup_stub_minimal_symbol): Update.
6440         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6441         Update.
6442         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6443         (elf_gnu_ifunc_resolve_by_got): Update.
6444         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6445         * dwarf-index-write.c (save_gdb_index_command): Update.
6446         * cp-support.c (add_symbol_overload_list_qualified): Update.
6447         * breakpoint.c (create_overlay_event_breakpoint)
6448         (create_longjmp_master_breakpoint)
6449         (create_std_terminate_master_breakpoint)
6450         (create_exception_master_breakpoint): Update.
6451         * blockframe.c (find_pc_partial_function): Update.
6452         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6453         (ada_collect_symbol_completion_matches)
6454         (ada_add_global_exceptions): Update.
6455
6456 2019-01-17  Tom Tromey  <tom@tromey.com>
6457
6458         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6459         declare VEC.
6460         (solib_target_parse_libraries): Change return type.
6461         (library_list_start_segment, library_list_start_section)
6462         (library_list_end_library, library_list_start_library); Update.
6463         (solib_target_free_library_list): Remove.
6464         (solib_target_parse_libraries): Remove cleanup.  Change return
6465         type.
6466         (solib_target_current_sos): Update.
6467
6468 2019-01-17  Tom Tromey  <tromey@bapiya>
6469
6470         * valprint.c: Replace "the the" with "the".
6471         * symtab.c: Replace "the the" with "the".
6472         * solib.c: Replace "the the" with "the".
6473         * solib-dsbt.c: Replace "the the" with "the".
6474         * linespec.c: Replace "the the" with "the".
6475         * dwarf2loc.h: Replace "the the" with "the".
6476         * amd64-windows-tdep.c: Replace "the the" with "the".
6477         * aarch64-tdep.c: Replace "the the" with "the".
6478
6479 2019-01-16  Keith Seitz  <keiths@redhat.com>
6480
6481         PR gdb/23773
6482         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6483         <builder>: Rename to ..
6484         <m_builder>: ... this and make private.
6485         (dwarf2_cu::get_builder): New method.  Change all users of
6486         `builder' to use this method.
6487         (dwarf2_start_symtab): Move to ...
6488         (dwarf2_cu::start_symtab): ... here.  Update all callers
6489         (setup_type_unit_groups): Move to ...
6490         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6491         callers.
6492         (dwarf2_cu::reset_builder): New method.
6493         (process_full_compunit, process_full_type_unit): Use
6494         dwarf2_cu::reset_builder.
6495         (follow_die_offset): Record the ancestor CU if it is different
6496         from the followed DIE's CU.
6497         (follow_die_sig_1): Likewise.
6498
6499 2019-01-15  Tom Tromey  <tom@tromey.com>
6500
6501         * remote.c (class remote_state) <buf>: Now a char_vector.
6502         <buf_size>: Remove.
6503         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6504         parameter.
6505         (remote_target::getpkt_or_notif_sane_1)
6506         (remote_target::getpkt_sane)
6507         (remote_target::getpkt_or_notif_sane): Likewise.
6508         (class remote_target) <putpkt>: New overload.
6509         (remote_target::read_frame): Change type of "buf_p".  Remove
6510         sizeof_p parameter.
6511         (packet_ok): New overload.
6512         (packet_check_result): New overload.
6513         Update all uses.
6514
6515 2019-01-14  Tom Tromey  <tom@tromey.com>
6516
6517         * remote-notif.c (handle_notification, remote_notif_ack)
6518         (remote_notif_parse): Make "buf" const.
6519         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6520         const.
6521         (remote_notif_parse, remote_notif_ack, handle_notification):
6522         Likewise.
6523         * remote.c (remote_notif_stop_parse): Make "buf" const.
6524         (remote_target::remote_parse_stop_reply): Make "buf" const.
6525         (remote_notif_stop_ack): Make "buf" const.
6526
6527 2019-01-14  Tom Tromey  <tom@tromey.com>
6528
6529         * remote.c (remote_console_output): Make parameter const.
6530
6531 2019-01-14  Tom Tromey  <tom@tromey.com>
6532
6533         * target-debug.h (target_debug_print_signals): Constify.
6534         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6535         * procfs.c (procfs_target::pass_signals): Update.
6536         * linux-nat.c (linux_nat_target::pass_signals): Update.
6537         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6538         * target-delegates.c: Rebuild.
6539         * remote.c (remote_target::program_signals): Update.
6540         (remote_target::pass_signals): Update.
6541         * target.c (target_pass_signals): Constify argument.
6542         (target_program_signals): Likewise.
6543         * target.h (struct target_ops) <pass_signals, program_signals>:
6544         Constify argument.
6545         (target_pass_signals, target_program_signals): Constify argument.
6546
6547 2019-01-14  Tom Tromey  <tom@tromey.com>
6548
6549         PR tui/28819:
6550         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6551
6552 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6553
6554         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6555         field.
6556         * rs6000-tdep.c: Include reggroups.h.
6557         (IS_V_ALIAS_PSEUDOREG): Define.
6558         (rs6000_register_name): Return names for the "vX" aliases.
6559         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6560         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6561         aliases.  Call default_register_reggroup_p for all other
6562         pseudo-registers.
6563         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6564         New functions.
6565         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6566         Handle "vX" aliases.
6567         (v_alias_pseudo_register_collect): New function.
6568         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6569         (rs6000_gdbarch_init): Initialize "vX" aliases as
6570         pseudo-registers.  Restore registration of
6571         rs6000_pseudo_register_reggroup_p with
6572         set_tdesc_pseudo_register_reggroup_p.
6573
6574 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6575
6576         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6577         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6578         set_gdbarch_num_pseudo_regs.
6579
6580 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6581
6582         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6583         Remove arg prefixname, add do_set and do_show.
6584         Add member functions set_list and show_list.
6585         * cli/cli-style.c (class cli_style_option): Update accordingly.
6586         (style_set_list): Move to file scope.
6587         (style_show_list): Likewise.
6588         (set_style): Call help_list.
6589         (show_style): Call cmd_show_list.
6590         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6591         Update to use the new macro.
6592
6593 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6594
6595         * ada-lang.c (_initialize_ada_language): Expand the help text
6596         for the "catch exception" command.
6597
6598 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6599
6600         * symtab.c (matching_obj_sections): Initialize obj,
6601         declare it closer to its usage.
6602
6603 2019-01-10  Tom Tromey  <tom@tromey.com>
6604
6605         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6606         (basic_inf_threads_range): Remove.
6607         (inf_threads_range, inf_non_exited_threads_range)
6608         (safe_inf_threads_range): Use next_adapter.
6609
6610 2019-01-10  Keith Seitz  <keiths@redhat.com>
6611
6612         PR gdb/23712
6613         PR symtab/23010
6614         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6615         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6616
6617 2019-01-10  Keith Seitz  <keiths@redhat.com>
6618
6619         PR gdb/23712
6620         PR symtab/23010
6621         * dictionary.c (pending_to_vector): Remove.
6622         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6623         Remove _1 suffix, replacing functions of the same name.  Update
6624         all callers.
6625         (dict_create_hashed, dict_create_hashed_expandable)
6626         (dict_create_linear, dict_create_linear_expandable, dict_free)
6627         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6628         Make functions static.
6629
6630 2019-01-10  Keith Seitz  <keiths@redhat.com>
6631
6632         PR gdb/23712
6633         PR symtab/23010
6634         * dictionary.h (struct dictionary): Replace declaration with
6635         multidictionary.
6636         (dict_create_hashed, dict_create_hashed_expandable)
6637         (dict_create_linear, dict_create_linear_expandable)
6638         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6639         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6640         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6641         taking multidictionary argument.
6642         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6643         * block.h (struct block) <dict>: Change to multidictionary
6644         and rename `multidict'.
6645         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6646         symmisc.c: Update all dictionary references to multidictionary.
6647
6648 2019-01-10  Keith Seitz  <keiths@redhat.com>
6649
6650         PR gdb/23712
6651         PR symtab/23010
6652         * dictionary.c: Include unordered_map.
6653         (pending_to_vector): New function.
6654         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6655         Rewrite the non-"_1" functions to take vector instead
6656         of linked list.
6657         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6658         "new" _1 versions of the same name.
6659         (multidictionary): Define.
6660         (std::hash<enum language): New definition.
6661         (collate_pending_symbols_by_language, mdict_create_hashed)
6662         (mdict_create_hashed_expandable, mdict_create_linear)
6663         (mdict_create_linear_expandable, mdict_free)
6664         (find_language_dictionary, create_new_language_dictionary)
6665         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6666         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6667         (mdict_size, mdict_empty): New functions.
6668         * dictionary.h (mdict_iterator): Define.
6669
6670 2019-01-10  Pedro Alves  <palves@redhat.com>
6671
6672         * breakpoint.c (read_uploaded_action)
6673         (create_tracepoint_from_upload): Adjust to use
6674         gdb::unique_xmalloc_ptr.
6675         * ctf.c (ctf_write_uploaded_tp):
6676         (SET_ARRAY_FIELD): Use emplace_back.
6677         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6678         * tracefile-tfile.c (tfile_write_uploaded_tp):
6679         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6680         gdb::unique_xmalloc_ptr.
6681         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6682         at_string, cond_string, cmd_strings>: Replace char pointers
6683         with gdb::unique_xmalloc_ptr.
6684
6685 2019-01-10  Pedro Alves  <palves@redhat.com>
6686
6687         * solib-target.c (library_list_start_library): Don't xstrdup name.
6688
6689 2019-01-10  Pedro Alves  <palves@redhat.com>
6690
6691         * mdebugread.c (parse_partial_symbols): Use
6692         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6693
6694 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6695
6696         * linux-fork.c (scoped_switch_fork_info)
6697         <~scoped_switch_fork_info>: Fix incorrect variable name.
6698
6699 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6700
6701         * linux-fork.c (scoped_switch_fork_info)
6702         <scoped_switch_fork_info>: Make explicit.
6703         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6704
6705 2019-01-10  Tom Tromey  <tom@tromey.com>
6706
6707         * objfiles.h (objfile::reset_psymtabs): Update.
6708         * objfiles.c (objfile::objfile): Update.
6709         * psymtab.h (psymtab_storage::obstack): Update.
6710         (psymtab_storage::m_obstack): Use gdb::optional.
6711         (class psymtab_storage): Update comment.  Remove objfile
6712         parameter.
6713         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6714
6715 2019-01-10  Tom Tromey  <tom@tromey.com>
6716
6717         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6718         <free_psymtabs>: Now private.
6719         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6720         (allocate_psymtab): Use new method.
6721
6722 2019-01-10  Tom Tromey  <tom@tromey.com>
6723
6724         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6725         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6726         * mdebugread.c (parse_partial_symbols): Use
6727         allocate_dependencies.
6728         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6729         allocate_dependencies.
6730         (process_psymtab_comp_unit_reader)
6731         (build_type_psymtab_dependencies): Likewise.
6732         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6733
6734 2019-01-10  Tom Tromey  <tom@tromey.com>
6735
6736         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6737         PSYMBOL_SET_LANGUAGE.
6738         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6739
6740 2019-01-10  Tom Tromey  <tom@tromey.com>
6741
6742         * psymtab.h (psymtab_storage::obstack): New method.
6743         <m_obstack>: Rename from obstack; now private.
6744         * psymtab.c (psymtab_storage): Update.
6745         * dwarf2read.c (create_addrmap_from_index)
6746         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6747         Update.
6748
6749 2019-01-10  Tom Tromey  <tom@tromey.com>
6750
6751         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6752         * objfiles.h (objfile::reset_psymtabs): New method.
6753
6754 2019-01-10  Tom Tromey  <tom@tromey.com>
6755
6756         * symmisc.c (print_symbol_bcache_statistics): Update.
6757         (print_objfile_statistics): Update.
6758         * symfile.c (reread_symbols): Update.
6759         * psymtab.h (class psymtab_storage): New.
6760         * psymtab.c (psymtab_storage): New constructor.
6761         (~psymtab_storage): New destructor.
6762         (require_partial_symbols): Update.
6763         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6764         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6765         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6766         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6767         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6768         (start_psymtab_common, end_psymtab_common)
6769         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6770         (allocate_psymtab): Update.
6771         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6772         Update.
6773         (dump_psymtab_addrmap, maintenance_print_psymbols)
6774         (maintenance_check_psymtabs): Update.
6775         (class objfile_psymtabs): Move to objfiles.h.
6776         * psympriv.h (discard_psymtab): Now inline.
6777         (psymtab_discarder::psymtab_discarder): Update.
6778         (psymtab_discarder::~psymtab_discarder): Update.
6779         (ALL_OBJFILE_PSYMTABS): Rewrite.
6780         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6781         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6782         Remove fields.
6783         <partial_symtabs>: New field.
6784         (class objfile_psymtabs): Move from psymtab.h.  Update.
6785         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6786         psymbol_cache.
6787         (objfile::~objfile): Don't destroy psymbol_cache.
6788         * mdebugread.c (parse_partial_symbols): Update.
6789         * dwarf2read.c (create_addrmap_from_index)
6790         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6791         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6792         (add_partial_subprogram, dwarf2_ranges_read): Update.
6793         * dwarf-index-write.c (write_address_map)
6794         (write_one_signatured_type, recursively_write_psymbols)
6795         (class debug_names, class debug_names, write_psymtabs_to_index):
6796         Update.
6797
6798 2019-01-10  Tom Tromey  <tom@tromey.com>
6799
6800         * symtab.h (SYMBOL_SET_NAMES): Update.
6801         (symbol_set_names): Update.
6802         (MSYMBOL_SET_NAMES): Update.
6803         * symtab.c (symbol_set_names): Change argument to be an
6804         objfile_per_bfd_storage.
6805         * psymtab.c (add_psymbol_to_bcache): Update.
6806         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6807
6808 2019-01-10  Tom Tromey  <tom@tromey.com>
6809
6810         * symtab.c (create_demangled_names_hash): Change argument to be an
6811         objfile_per_bfd_storage.
6812         (symbol_set_names): Update.
6813
6814 2019-01-10  Tom Tromey  <tom@tromey.com>
6815
6816         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6817         init_psymbol_list.
6818         * psymtab.c (init_psymbol_list): Do nothing if already called.
6819         * psympriv.h (init_psymbol_list): Add comment.
6820         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6821         init_psymbol_list.
6822         * dbxread.c (dbx_symfile_read): Unconditionally call
6823         init_psymbol_list.
6824
6825 2019-01-10  Tom Tromey  <tom@tromey.com>
6826
6827         * xcoffread.c (scan_xcoff_symtab): Update.
6828         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6829         "where".
6830         * mdebugread.c (parse_partial_symbols)
6831         (handle_psymbol_enumerators): Update.
6832         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6833         * dbxread.c (read_dbx_symtab): Update.
6834         * psympriv.h (psymbol_placement): New enum.
6835         (add_psymbol_to_list): Update.
6836
6837 2019-01-10  Tom Tromey  <tom@tromey.com>
6838
6839         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6840         static_psymbols parameters.
6841         (scan_xcoff_symtab): Update.
6842         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6843         static_psymbols parameters.
6844         * psympriv.h (start_psymtab_common): Update.
6845         * mdebugread.c (parse_partial_symbols): Update.
6846         * dwarf2read.c (create_partial_symtab): Update.
6847         * dbxread.c (read_dbx_symtab): Update.
6848         (start_psymtab): Remove global_psymbols and static_psymbols
6849         parameters.
6850
6851 2019-01-10  Tom Tromey  <tom@tromey.com>
6852
6853         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6854         * psymtab.c (allocate_psymtab): Add comment.
6855         * psympriv.h (allocate_psymtab): Add comment.
6856         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6857         initializations.
6858         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6859
6860 2019-01-10  Tom Tromey  <tom@tromey.com>
6861
6862         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6863         Don't declare.
6864         * mipsread.c: Include mdebugread.h.
6865         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6866         Declare.
6867         * elfread.c: Include mdebugread.h.
6868
6869 2019-01-09  Tom Tromey  <tom@tromey.com>
6870
6871         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6872         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6873         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6874         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6875         (psym_lookup_symbol, psym_find_last_source_symtab)
6876         (psym_forget_cached_source_info, psym_print_stats)
6877         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6878         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6879         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6880         (psym_find_compunit_symtab_by_address)
6881         (maintenance_print_psymbols, maintenance_info_psymtabs)
6882         (maintenance_check_psymtabs): Use ranged for.
6883         * psymtab.h (class objfile_psymtabs): New.
6884         (require_partial_symbols): Return objfile_psymtabs.
6885         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6886
6887 2019-01-09  Tom Tromey  <tom@tromey.com>
6888
6889         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6890         (find_pc_mapped_section, list_overlays_command)
6891         (map_overlay_command, unmap_overlay_command)
6892         (simple_overlay_update): Use all_objfiles.
6893         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6894         * printcmd.c (info_symbol_command): Use all_objfiles.
6895         * objfiles.h (ALL_OBJSECTIONS): Remove.
6896         * maint.c (maintenance_translate_address): Use all_objfiles.
6897         * gcore.c (gcore_create_callback): Use all_objfiles.
6898         (objfile_find_memory_regions): Likewise.
6899
6900 2019-01-09  Tom Tromey  <tom@tromey.com>
6901
6902         * symtab.c (find_line_symtab, info_sources_command)
6903         (make_source_files_completion_list): Use objfile_compunits.
6904         * source.c (select_source_symtab): Use objfile_compunits.
6905         * objfiles.h (struct objfile): Update comment.
6906         (ALL_OBJFILES): Remove.
6907         (ALL_FILETABS): Remove.
6908         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6909         objfile_compunits.
6910
6911 2019-01-09  Tom Tromey  <tom@tromey.com>
6912
6913         * symmisc.c (print_objfile_statistics, dump_objfile)
6914         (maintenance_print_symbols): Use compunit_filetabs.
6915         * source.c (forget_cached_source_info_for_objfile): Use
6916         compunit_filetabs.
6917         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
6918         (ALL_FILETABS): Use compunit_filetabs.
6919         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
6920         * coffread.c (coff_symtab_read): Use compunit_filetabs.
6921
6922 2019-01-09  Tom Tromey  <tom@tromey.com>
6923
6924         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
6925         (compunit_filetabs): New.
6926         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
6927         compunit_filetabs.
6928         (info_sources_command, make_source_files_completion_list): Remove
6929         declaration.
6930         * symmisc.c (print_objfile_statistics, dump_objfile)
6931         (maintenance_print_symbols): Remove declaration.
6932         (maintenance_info_symtabs): Use compunit_filetabs.
6933         (maintenance_info_line_tables): Likewise.
6934         * source.c (select_source_symtab): Change local variable name.
6935         (forget_cached_source_info_for_objfile): Remove declaration.
6936         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
6937         * objfiles.c (objfile_relocate1): Remove declaration.
6938         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6939         declaration.
6940         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
6941         * coffread.c (coff_symtab_read): Remove declaration.
6942         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6943         compunit_filetabs.
6944
6945 2019-01-09  Tom Tromey  <tom@tromey.com>
6946
6947         * symtab.c (lookup_objfile_from_block)
6948         (find_pc_sect_compunit_symtab, search_symbols)
6949         (default_collect_symbol_completion_matches_break_on): Use
6950         objfile_compunits.
6951         * objfiles.h (ALL_COMPUNITS): Remove.
6952         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
6953         * cp-support.c (add_symbol_overload_list_qualified): Use
6954         objfile_compunits.
6955         * ada-lang.c (ada_collect_symbol_completion_matches)
6956         (ada_add_global_exceptions): Use objfile_compunits.
6957
6958 2019-01-09  Tom Tromey  <tom@tromey.com>
6959
6960         * source.c (select_source_symtab)
6961         (forget_cached_source_info_for_objfile): Remove declaration.
6962         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
6963         declaration.
6964         * maint.c (count_symtabs_and_blocks): Remove declaration.
6965         * cp-support.c (add_symbol_overload_list_qualified): Remove
6966         declaration.
6967         * coffread.c (coff_symtab_read): Remove declaration.
6968         * symtab.c (lookup_symbol_in_objfile_symtabs)
6969         (basic_lookup_transparent_type_1): Use objfile_compunits.
6970         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
6971         (info_sources_command, search_symbols)
6972         (default_collect_symbol_completion_matches_break_on)
6973         (make_source_files_completion_list): Remove declaration.
6974         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
6975         (ada_collect_symbol_completion_matches)
6976         (ada_add_global_exceptions): Remove declaration.
6977         * linespec.c (iterate_over_all_matching_symtabs): Use
6978         objfile_compunits.
6979         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
6980         (class objfile_compunits): New.
6981         (ALL_COMPUNITS): Use objfile_compunits.
6982         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
6983         (maintenance_check_symtabs, maintenance_info_line_tables): Use
6984         objfile_compunits.
6985         * objfiles.c (objfile_relocate1): Use objfile_compunits.
6986
6987 2019-01-09  Tom Tromey  <tom@tromey.com>
6988
6989         * symtab.c (search_symbols)
6990         (default_collect_symbol_completion_matches_break_on): Use
6991         objfile_msymbols.
6992         * ada-lang.c (ada_lookup_simple_minsym)
6993         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
6994         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
6995         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
6996         objfile_msymbols.
6997         * coffread.c (coff_symfile_read): Use objfile_msymbols.
6998         * symmisc.c (dump_msymbols): Use objfile_msymbols.
6999         * objc-lang.c (find_methods): Use objfile_msymbols.
7000         (info_selectors_command, info_classes_command): Likewise.
7001         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7002         * objfiles.h (class objfile_msymbols): New.
7003         (ALL_OBJFILE_MSYMBOLS): Remove.
7004         (ALL_MSYMBOLS): Remove.
7005
7006 2019-01-09  Tom Tromey  <tom@tromey.com>
7007
7008         * common/next-iterator.h (next_adapter): Add Iterator template
7009         parameter.
7010         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7011         (class all_objfiles_safe): New.
7012         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7013         * objfiles.c (put_objfile_before): Update comment.
7014         (add_separate_debug_objfile): Likewise.
7015         (free_all_objfiles): Use all_objfiles_safe.
7016         (objfile_purge_solibs): Likewise.
7017
7018 2019-01-09  Tom Tromey  <tom@tromey.com>
7019
7020         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7021         (expand_symtab_containing_pc, lookup_static_symbol)
7022         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7023         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7024         all_objfiles.
7025         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7026         * breakpoint.c (create_overlay_event_breakpoint)
7027         (create_longjmp_master_breakpoint)
7028         (create_std_terminate_master_breakpoint)
7029         (create_exception_master_breakpoint): Use all_objfiles.
7030         * linux-thread-db.c (try_thread_db_load_from_pdir)
7031         (has_libpthread): Use all_objfiles.
7032         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7033         * linespec.c (iterate_over_all_matching_symtabs)
7034         (search_minsyms_for_name): Use all_objfiles.
7035         * maint.c (maintenance_info_sections): Use all_objfiles.
7036         * main.c (captured_main_1): Use all_objfiles.
7037         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7038         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7039         * guile/scm-pretty-print.c
7040         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7041         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7042         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7043         (maintenance_print_msymbols): Use all_objfiles.
7044         * source.c (select_source_symtab): Use all_objfiles.
7045         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7046         * symfile.c (remove_symbol_file_command)
7047         (expand_symtabs_matching, map_symbol_filenames): Use
7048         all_objfiles.
7049         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7050         all_objfiles.
7051         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7052         * objc-lang.c (find_methods): Use all_objfiles.
7053         * objfiles.c (have_partial_symbols, have_full_symbols)
7054         (have_minimal_symbols, qsort_cmp)
7055         (default_iterate_over_objfiles_in_search_order): Use
7056         all_objfiles.
7057         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7058         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7059         (maintenance_check_psymtabs): Use all_objfiles.
7060         (ALL_PSYMTABS): Remove.
7061         * compile/compile-object-run.c (do_module_cleanup): Use
7062         all_objfiles.
7063         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7064         * cp-support.c (add_symbol_overload_list_qualified): Use
7065         all_objfiles.
7066         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7067         Use all_objfiles.
7068         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7069         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7070         all_objfiles.
7071         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7072         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7073         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7074         Uses all_objfiles.
7075         * solib.c (solib_read_symbols): Use all_objfiles
7076
7077 2019-01-09  Tom Tromey  <tom@tromey.com>
7078
7079         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7080         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7081         all_objfiles.
7082         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7083         * symmisc.c (print_symbol_bcache_statistics)
7084         (print_objfile_statistics, maintenance_print_objfiles)
7085         (maintenance_info_symtabs, maintenance_check_symtabs)
7086         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7087         all_objfiles.
7088         * source.c (forget_cached_source_info): Use all_objfiles.
7089         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7090         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7091         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7092         * objfiles.c (update_section_map): Use all_objfiles.
7093         (shared_objfile_contains_address_p): Likewise.
7094         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7095         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7096
7097 2019-01-09  Tom Tromey  <tom@tromey.com>
7098
7099         * common/next-iterator.h: New file.
7100         * objfiles.h (class all_objfiles): New.
7101         (struct objfile_iterator): New.
7102
7103 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7104
7105         * NEWS: Move the description of the changed "frame", "select-frame",
7106          and "info frame" commands to the Changed commands section.
7107
7108 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7109
7110         * gdbtypes.c (check_stub_method_group): Remove handling of old
7111         mangling schemes.
7112         * linespec.c (find_methods): Likewise.
7113         * stabsread.c (read_member_functions): Likewise.
7114         * valops.c (search_struct_method): Likewise.
7115         (value_struct_elt_for_reference): Likewise.
7116         * NEWS: Mention this change.
7117
7118 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7119
7120         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7121         print_source_lines.
7122         * source.c (print_source_lines_base): Update line number check.
7123         (print_source_lines): New function.
7124         (source_lines_range::source_lines_range): New function.
7125         * source.h (class source_lines_range): New class.
7126         (print_source_lines): New declaration.
7127
7128 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7129
7130         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7131
7132 2019-01-08  Tom Tromey  <tom@tromey.com>
7133             Simon Marchi  <simon.marchi@ericsson.com>
7134
7135         PR gdb/24060
7136         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7137         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7138         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7139         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7140         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7141         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7142
7143 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7144
7145         * source.c (select_source_symtab): Move header comment to
7146         declaration in source.h.
7147         (forget_cached_source_info_for_objfile): Likewise.
7148         (forget_cached_source_info): Likewise.
7149         (identify_source_line): Likewise.
7150         * source.h (identify_source_line): Move declaration from symtab.h
7151         and add comment from source.c
7152         (print_source_lines): Likewise.
7153         (forget_cached_source_info_for_objfile): Likewise.
7154         (forget_cached_source_info): Likewise.
7155         (select_source_symtab): Likewise.
7156         (enum print_source_lines_flag): Move definition from symtab.h.
7157         * symtab.h (identify_source_line): Move declaration to source.h.
7158         (print_source_lines): Likewise.
7159         (forget_cached_source_info_for_objfile): Likewise.
7160         (forget_cached_source_info): Likewise.
7161         (select_source_symtab): Likewise.
7162         (enum print_source_lines_flag): Move definition to source.h.
7163         * tui/tui-hooks.c: Add 'source.h' include.
7164
7165 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7166
7167         * source.c (print_source_lines_base): Handle requests to print
7168         reverse line number sequences, and guard against empty lines
7169         string.
7170
7171 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7172
7173         * source.c (print_source_lines_base): Fix skip of '\r' if next
7174         character is '\n'.
7175
7176 2019-01-06  Tom Tromey  <tom@tromey.com>
7177
7178         * c-exp.y (struct c_parse_state) <macro_original_text,
7179         expansion_obstack>: New member.
7180         (macro_original_text, expansion_obstack): Remove globals.
7181         (scan_macro_expansion, scanning_macro_expansion)
7182         (finished_macro_expansion): Update.
7183         (scan_macro_cleanup): Remove.
7184         (yylex, c_parse): Update.
7185
7186 2019-01-06  Tom Tromey  <tom@tromey.com>
7187
7188         * c-exp.y (struct c_parse_state) <strings>: New member.
7189         (operator_stoken): Update.
7190
7191 2019-01-06  Tom Tromey  <tom@tromey.com>
7192
7193         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7194         (union type_stack_elt) <typelist_val>: Now a pointer to
7195         std::vector.
7196         (type_stack_cleanup): Don't declare.
7197         (push_typelist): Update.
7198         * parse.c (pop_typelist): Return a std::vector.
7199         (push_typelist): Take a std::vector.
7200         (follow_types): Update.  Do not free args.
7201         (type_stack_cleanup): Remove.
7202         * c-exp.y (struct c_parse_state): New.
7203         (cpstate): New global.
7204         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7205         (nonempty_typelist): Update.
7206         (func_mod): Create a new vector.
7207         (c_parse): Create a c_parse_state.
7208         (check_parameter_typelist): Do not delete params.
7209         (function_method): Update.  Do not delete type_list.
7210
7211 2019-01-06  Tom Tromey  <tom@tromey.com>
7212
7213         PR gdb/28155:
7214         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7215         check_typedef.
7216         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7217         (print_return_value): Likewise.
7218
7219 2019-01-05  Tom Tromey  <tom@tromey.com>
7220
7221         * contrib/cleanup_check.py: Remove.
7222         * contrib/gcc-with-excheck: Remove.
7223         * contrib/exsummary.py: Remove.
7224         * contrib/excheck.py: Remove.
7225
7226 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7227
7228         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7229         NULL. Initialize tpprev to NULL instead of assigning it
7230         to NULL on the next statement.
7231         * windows-nat.c (windows_delete_thread): Remove check for
7232         main_thread_id before printing thread exit notifications.
7233         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7234         Remove thread ID check against main_thread_id.
7235         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7236         windows_delete_thread.
7237         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7238
7239 2019-01-04  Tom Tromey  <tom@tromey.com>
7240
7241         * compile/compile.c (_initialize_compile): Use upper case for
7242         metasyntactic variables.
7243         * symmisc.c (_initialize_symmisc): Use upper case for
7244         metasyntactic variables.
7245         * psymtab.c (_initialize_psymtab): Use upper case for
7246         metasyntactic variables.
7247         * demangle.c (demangle_command): Use upper case for metasyntactic
7248         variables.
7249         (_initialize_demangler): Likewise.
7250         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7251         variables.
7252
7253 2019-01-03  Tom Tromey  <tom@tromey.com>
7254
7255         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7256
7257 2019-01-03  Tom Tromey  <tom@tromey.com>
7258
7259         * python/py-symtab.c (salpy_str): Update.
7260         (struct salpy_sal_object) <symtab>: Now a PyObject.
7261         (salpy_dealloc): Update.
7262         (del_objfile_sal): Use gdbpy_ref.
7263
7264 2019-01-03  Tom Tromey  <tom@tromey.com>
7265
7266         * python/py-type.c (convert_field): Use new_reference.  Return
7267         gdbpy_ref.
7268         (make_fielditem): Return gdbpy_ref.
7269         (typy_fields): Update.
7270         (typy_getitem): Update.
7271         (field_name): Return gdbpy_ref.  Use new_reference.
7272         (typy_iterator_iternext): Update.
7273
7274 2019-01-03  Tom Tromey  <tom@tromey.com>
7275
7276         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7277
7278 2019-01-03  Tom Tromey  <tom@tromey.com>
7279
7280         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7281         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7282         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7283         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7284         (pspy_set_type_printers): Likewise.
7285         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7286         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7287         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7288         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7289         (objfpy_set_type_printers): Likewise.
7290
7291 2019-01-03  Tom Tromey  <tom@tromey.com>
7292
7293         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7294         (gdbpy_print_stack): Use gdbpy_err_fetch.
7295         * python/python-internal.h (class gdbpy_err_fetch): New class.
7296         (class gdbpy_enter) <m_error_type, m_error_value,
7297         m_error_traceback>: Remove.
7298         <m_error>: New member.
7299         (gdbpy_exception_to_string): Don't declare.
7300         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7301         * python/py-value.c (convert_value_from_python): Use
7302         gdbpy_err_fetch.
7303         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7304         gdbpy_exception_to_string.
7305         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7306         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7307         gdbpy_err_fetch.
7308
7309 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7310
7311         * linux-nat.c (delete_lwp_cleanup): Delete.
7312         (struct lwp_deleter): New struct.
7313         (lwp_info_up): New typedef.
7314         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7315         lwp_info_up.
7316
7317 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7318
7319         * linux-fork.c (class scoped_switch_fork_info): New class.
7320         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7321
7322 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7323
7324         * valops.c (find_overload_match): Remove use of null_cleanup, and
7325         calls to do_cleanups.
7326
7327 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7328
7329         * compile/compile-cplus-types.c
7330         (compile_cplus_instance::decl_name): Handle changes to
7331         cp_func_name.
7332         * cp-support.c (cp_func_name): Update header comment, update
7333         return type.
7334         * cp-support.h (cp_func_name): Update return type in declaration.
7335         * valops.c (find_overload_match): Move temp_func local to top
7336         level of function and change its type.  Use temp_func to hold and
7337         delete temporary string obtained from cp_func_name.
7338
7339 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7340
7341         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7342         gdb::char_vector, remove cleanup, and update uses of `msg`.
7343
7344 2019-01-03  Jim Wilson  <jimw@sifive.com>
7345
7346         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7347
7348 2019-01-02  Tom Tromey  <tom@tromey.com>
7349
7350         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7351         (tdesc_parse_xml): Remove cleanups.
7352         * target-descriptions.h (make_cleanup_free_target_description):
7353         Don't declare.
7354         (target_desc_deleter): New struct.
7355         (target_desc_up): New typedef.
7356         * target-descriptions.c (target_desc_deleter::operator()): Rename
7357         from free_target_description.
7358         (make_cleanup_free_target_description): Remove.
7359
7360 2019-01-02  Tom Tromey  <tom@tromey.com>
7361
7362         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7363         constructor, destructor.
7364         (linespec_parser): Remove typedef.
7365         (~linespec_parser): Rename from linespec_parser_delete.
7366         (linespec_lex_to_end, linespec_complete_label)
7367         (linespec_complete): Update.
7368         (decode_line_full): Remove cleanups.
7369         (decode_line_1): Update.
7370
7371 2019-01-02  Tom Tromey  <tom@tromey.com>
7372
7373         * python/python-internal.h (inferior_to_inferior_object): Change
7374         return type.
7375         * python/py-exitedevent.c (create_exited_event_object): Update.
7376         * python/py-inferior.c (inferior_to_inferior_object): Return
7377         gdbpy_ref.
7378         (python_new_inferior, python_inferior_deleted)
7379         (thread_to_thread_object, delete_thread_object)
7380         (build_inferior_list, gdbpy_selected_inferior): Update.
7381         * python/py-infthread.c (create_thread_object): Update.  Also fail
7382         if inferior_to_inferior_object fails.
7383
7384 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7385
7386         * inferior.h (class inferior) <displaced_step_state>: New field.
7387         * infrun.h (struct displaced_step_state): Move here from
7388         infrun.c.  Initialize fields, add constructor.
7389         <inf>: Remove field.
7390         <reset>: New method.
7391         * infrun.c (struct displaced_step_inferior_state): Move to
7392         infrun.h.
7393         (displaced_step_inferior_states): Remove.
7394         (get_displaced_stepping_state): Adust.
7395         (displaced_step_in_progress_any_inferior): Adjust.
7396         (displaced_step_in_progress_thread): Adjust.
7397         (displaced_step_in_progress): Adjust.
7398         (add_displaced_stepping_state): Remove.
7399         (get_displaced_step_closure_by_addr): Adjust.
7400         (remove_displaced_stepping_state): Remove.
7401         (infrun_inferior_exit): Call displaced_step_state.reset.
7402         (use_displaced_stepping): Don't check for NULL.
7403         (displaced_step_prepare_throw): Call
7404         get_displaced_stepping_state.
7405         (displaced_step_fixup): Don't check for NULL.
7406         (prepare_for_detach): Don't check for NULL.
7407
7408 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7409
7410         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7411          in case of call that did not complete.
7412
7413 2019-01-02  Andrey Utkin  <autkin@undo.io>
7414
7415         * symfile.c (find_separate_debug_file): Fix search of debug files for
7416         remote debuggee.
7417
7418 2019-01-02  Tom Tromey  <tom@tromey.com>
7419
7420         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7421         indentation.
7422         * python/py-frame.c (frapy_older): Remove cast.
7423         (frapy_newer): Likewise.
7424         * python/py-breakpoint.c (local_setattro): Remove cast.
7425         * python/py-arch.c (archpy_name): Remove local variable.
7426         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7427
7428 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7429
7430         * unittests/basic_string_view/element_access/char/empty.cc:
7431         Fix year range in copyright header.
7432
7433 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7434
7435         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7436         Delete.
7437         <operator==>: Update with for removed field.
7438         <hash>: Likewise.
7439         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7440         <isa_features>: ...this.
7441         <abi_features>: New field.
7442         (riscv_isa_flen): Update comment.
7443         (riscv_abi_xlen): New declaration.
7444         (riscv_abi_flen): New declaration.
7445         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7446         isa_features.
7447         (riscv_abi_xlen): New function.
7448         (riscv_isa_flen): Update to get answer from isa_features.
7449         (riscv_abi_flen): New function.
7450         (riscv_has_fp_abi): Update to get answer from abi_features.
7451         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7452         xlen and flen.
7453         (riscv_call_info) <xlen, flen>: Update comment.
7454         (riscv_call_arg_struct): Remove invalid assertions
7455         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7456         is removed.
7457         (riscv_gdbarch_init): Gather isa features and abi features
7458         separately, ensure both match on the gdbarch when reusing an old
7459         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7460         a target with 64-bit float hardware.
7461
7462 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7463
7464         * source.c (search_command_helper): Stop reverse search
7465         when line 1 has been searched.
7466
7467 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7468
7469         * record-full.c (record_full_base_target::close): Rewrite
7470         record_full_core_buf_list free logic.
7471
7472 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7473
7474         * break-catch-syscall.c (print_one_catch_syscall): xfree
7475         the last text.
7476
7477 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7478
7479         * top.c (print_gdb_version): Update Copyright year in version
7480         message.
7481
7482 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7483
7484         Update copyright year range in all GDB files.
7485
7486 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7487
7488         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7489
7490 For older changes see ChangeLog-2018.
7491 \f
7492 Local Variables:
7493 mode: change-log
7494 left-margin: 8
7495 fill-column: 74
7496 version-control: never
7497 coding: utf-8
7498 End:
7499