gdb/ChangeLog

   1 2019-10-02  Tom Tromey  <tromey@adacore.com>
   2
   3         * NEWS: Add $_ada_exception entry.
   4         * ada-lang.c (struct ada_catchpoint): Add constructor.
   5         <m_kind>: New member.
   6         (allocate_location_exception, re_set_exception): Remove
   7         "ex" parameter.
   8         (should_stop_exception): Compute $_ada_exception.
   9         (check_status_exception, print_it_exception)
  10         (print_one_exception, print_mention_exception): Remove
  11         "ex" parameter.
  12         (allocate_location_catch_exception, re_set_catch_exception)
  13         (check_status_exception, print_it_catch_exception)
  14         (print_one_catch_exception, print_mention_catch_exception)
  15         (print_recreate_catch_exception)
  16         (allocate_location_catch_exception_unhandled)
  17         (re_set_catch_exception_unhandled)
  18         (check_status_exception, print_it_catch_exception_unhandled)
  19         (print_one_catch_exception_unhandled)
  20         (print_mention_catch_exception_unhandled)
  21         (print_recreate_catch_exception_unhandled)
  22         (allocate_location_catch_assert, re_set_catch_assert)
  23         (check_status_assert, print_it_catch_assert)
  24         (print_one_catch_assert, print_mention_catch_assert)
  25         (print_recreate_catch_assert)
  26         (allocate_location_catch_handlers, re_set_catch_handlers)
  27         (check_status_handlers, print_it_catch_handlers)
  28         (print_one_catch_handlers, print_mention_catch_handlers)
  29         (print_recreate_catch_handlers): Remove.
  30         (create_ada_exception_catchpoint): Update.
  31         (initialize_ada_catchpoint_ops): Update.
  32
  33 2019-10-02  Tom Tromey  <tromey@adacore.com>
  34
  35         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
  36         (create_excep_cond_exprs): Simplify exception string computation.
  37         (ada_exception_catchpoint_cond_string): Likewise.
  38
  39 2019-10-02  Tom Tromey  <tromey@adacore.com>
  40
  41         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
  42         * ada-lang.c (lesseq_defined_than): Handle
  43         LOC_STATIC.
  44         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
  45         parameter.
  46         (dwarf2_has_info): Likewise.
  47         (new_symbol): Set maybe_copied on symbol when
  48         appropriate.
  49         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
  50         parameter.
  51         <can_copy>: New member.
  52         * elfread.c (record_minimal_symbol): Set maybe_copied
  53         on symbol when appropriate.
  54         (elf_symfile_read): Update call to dwarf2_has_info.
  55         * minsyms.c (lookup_minimal_symbol_linkage): New
  56         function.
  57         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
  58         * symtab.c (get_symbol_address, get_msymbol_address):
  59         New functions.
  60         * symtab.h (get_symbol_address, get_msymbol_address):
  61         Declare.
  62         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
  63         maybe_copied.
  64         (struct symbol, struct minimal_symbol) <maybe_copied>:
  65         New member.
  66
  67 2019-10-02  Tom Tromey  <tromey@adacore.com>
  68
  69         * source.c (struct current_source_location): New.
  70         (current_source_key): New global.
  71         (current_source_symtab, current_source_line)
  72         (current_source_pspace): Remove.
  73         (get_source_location): New function.
  74         (get_current_source_symtab_and_line)
  75         (set_default_source_symtab_and_line)
  76         (set_current_source_symtab_and_line)
  77         (clear_current_source_symtab_and_line, select_source_symtab)
  78         (info_source_command, print_source_lines_base)
  79         (info_line_command, search_command_helper, _initialize_source):
  80         Update.
  81
  82 2019-10-02  Tom Tromey  <tromey@adacore.com>
  83
  84         * source.c (select_source_symtab): Don't call
  85         decode_line_with_current_source.
  86
  87 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
  88
  89         * symtab.c (lookup_global_symbol): Search global block.
  90
  91 2019-10-02  Tom Tromey  <tromey@adacore.com>
  92
  93         * coffread.c (process_coff_symbol): Update.
  94         * dwarf2read.c (var_decode_location, new_symbol): Update.
  95         * mdebugread.c (parse_symbol): Update.
  96         * objfiles.c (relocate_one_symbol): Update.
  97         * stabsread.c (define_symbol, fix_common_block)
  98         (scan_file_globals): Update.
  99         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 100         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 101         * xcoffread.c (process_xcoff_symbol): Update.
 102
 103 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 104
 105         * MAINTAINERS: Update my email address.
 106
 107 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 108
 109         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 110         std::vector.
 111         (build_type_psymtabs_reader): Update for std::vector.
 112         (build_type_psymtab_dependencies): Likewise.
 113         * dwarf2read.h: Remove use of DEF_VEC_P.
 114         (typedef sig_type_ptr): Delete.
 115
 116 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 117
 118         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 119         to std::vector.
 120         (btrace_maint_decode_pt): Likewise, and move allocation of the
 121         vector outside of the loop.
 122         (btrace_maint_update_packets): Update to handle change from VEC to
 123         std::vector.
 124         (btrace_maint_print_packets): Likewise.
 125         (maint_info_btrace_cmd): Likewise.
 126         * btrace.h: Remove use of DEF_VEC_O.
 127         (typedef btrace_pt_packet_s): Delete.
 128         (struct btrace_maint_info) <packets>: Change fromm VEC to
 129         std::vector.
 130         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 131
 132 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 133
 134         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 135         make accesses into the vector constant references.
 136         (btrace_add_pc): Update for std::vector.
 137         (btrace_stitch_bts): Likewise.
 138         (parse_xml_btrace_block): Likewise.
 139         (btrace_maint_update_packets): Likewise.
 140         (btrace_maint_print_packets): Likewise.
 141         (maint_info_btrace_cmd): Likewise.
 142         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 143         std::vector.
 144         (btrace_data::empty): Likewise.
 145         (btrace_data_append): Likewise.
 146         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 147         (typedef btrace_block_s): Delete.
 148         (struct btrace_block): Add constructor.
 149         (struct btrace_data_bts) <blocks>: Change to std::vector.
 150         * nat/linux-btrace.c (perf_event_read_bts): Update for
 151         std::vector.
 152         (linux_read_bts): Likewise.
 153
 154 2019-10-01  Tom Tromey  <tom@tromey.com>
 155
 156         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 157
 158 2019-10-01  Tom Tromey  <tom@tromey.com>
 159
 160         * stack.c (print_frame, info_frame_command_core): Use
 161         styled_string.
 162         * linux-thread-db.c (try_thread_db_load_1)
 163         (try_thread_db_load_from_pdir_1): Use styled_string.
 164         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 165         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 166         (maybe_print_unsupported_script_warning)
 167         (maybe_print_script_not_found_warning): Use styled_string.
 168         * ada-lang.c (user_select_syms): Use styled_string.
 169
 170 2019-10-01  Tom Tromey  <tom@tromey.com>
 171
 172         * p-lang.c (pascal_printstr): Use metadata style.
 173         * value.c (show_convenience): Use metadata style.
 174         * valprint.c (valprint_check_validity, val_print_optimized_out)
 175         (val_print_not_saved, val_print_unavailable)
 176         (val_print_invalid_address, generic_val_print, val_print)
 177         (value_check_printable, val_print_array_elements): Use metadata
 178         style.
 179         * ui-out.h (class ui_out) <field_fmt>: New overload.
 180         <do_field_fmt>: Add style parameter.
 181         * ui-out.c (ui_out::field_fmt): New overload.
 182         * typeprint.c (type_print_unknown_return_type)
 183         (val_print_not_allocated, val_print_not_associated): Use metadata
 184         style.
 185         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 186         parameter.
 187         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 188         * tracepoint.c (tvariables_info_1): Use metadata style.
 189         * stack.c (print_frame_arg, print_frame_info, print_frame)
 190         (info_frame_command_core): Use metadata style.
 191         * skip.c (info_skip_command): Use metadata style.
 192         * rust-lang.c (rust_print_enum): Use metadata style.
 193         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 194         metadata style.
 195         * python/py-framefilter.c (py_print_single_arg): Use metadata
 196         style.
 197         * printcmd.c (do_one_display, print_variable_and_value): Use
 198         metadata style.
 199         * p-valprint.c (pascal_val_print)
 200         (pascal_object_print_value_fields): Use metadata style.
 201         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 202         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 203         parameter.
 204         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 205         * m2-valprint.c (m2_print_long_set): Use metadata style.
 206         * m2-typeprint.c (m2_print_type): Use metadata style.
 207         * infcmd.c (print_return_value_1): Use metadata style.
 208         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 209         * f-valprint.c (info_common_command_for_block): Use metadata
 210         style.
 211         * f-typeprint.c (f_type_print_base): Use metadata style.
 212         * expprint.c (print_subexp_standard): Use metadata style.
 213         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 214         * cli/cli-style.h (class cli_style_option): Add constructor.
 215         (metadata_style): Declare.
 216         * cli/cli-style.c (metadata_style): New global.
 217         (_initialize_cli_style): Register metadata style.
 218         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 219         parameter.
 220         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 221         * c-typeprint.c (c_type_print_base_struct_union)
 222         (c_type_print_base_1): Use metadata style.
 223         * breakpoint.c (watchpoint_value_print)
 224         (print_one_breakpoint_location): Use metadata style.
 225         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 226         style.
 227         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 228         style.
 229         * ada-valprint.c (val_print_packed_array_elements, printstr)
 230         (print_field_values, ada_val_print_ref, ada_val_print): Use
 231         metadata style.
 232         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 233         style.
 234         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 235         style.
 236         * ada-lang.c (user_select_syms): Use metadata style.
 237
 238 2019-10-01  Tom Tromey  <tom@tromey.com>
 239
 240         * cli/cli-cmds.c (pwd_command): Style output.
 241
 242 2019-10-01  Pedro Alves  <palves@redhat.com>
 243             Tom Tromey  <tom@tromey.com>
 244
 245         * symtab.c (print_symbol_info): Use %ps.
 246         (print_msymbol_info): Use %ps.
 247         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 248         * printcmd.c (print_variable_and_value): Use %ps.
 249         * macrocmd.c (show_pp_source_pos): Use %ps.
 250         * infrun.c (print_exited_reason): Use ui_out::message.
 251         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 252         (describe_other_breakpoints): Use ui_out::message and new
 253         formats.
 254         (say_where): Use new formats.
 255         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 256         and new formats.
 257
 258 2019-10-01  Pedro Alves  <palves@redhat.com>
 259             Tom Tromey  <tom@tromey.com>
 260
 261         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 262         (test_gdb_formats): New function.
 263         (run_tests): Call it.
 264         (test_format_specifier): Update.
 265         * utils.h (fputs_filtered): Update comment.
 266         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 267         (fputs_styled_unfiltered): Declare.
 268         * utils.c (fputs_styled_unfiltered): New function.
 269         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 270         (vfprintf_filtered): Update.
 271         (vfprintf_unfiltered, vprintf_filtered): Update.
 272         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 273         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 274         disallow_ui_out_field>: New constants.
 275         (enum class field_kind): New.
 276         (struct base_field_s, struct signed_field_s): New.
 277         (signed_field): New function.
 278         (struct string_field_s): New.
 279         (string_field): New function.
 280         (struct styled_string_s): New.
 281         (styled_string): New function.
 282         (class ui_out) <message>: Add comment.
 283         <vmessage, call_do_message>: New methods.
 284         <do_message>: Add style parameter.
 285         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 286         methods.
 287         (ui_out::message): Rewrite.
 288         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 289         parameter.
 290         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 291         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 292         gdb_extensions parameter.
 293         (class format_piece): Add parameter to constructor.
 294         (n_int_args): New field.
 295         * gdbsupport/format.c (format_pieces::format_pieces): Add
 296         gdb_extensions parameter.  Handle '*'.
 297         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 298         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 299         vfprintf_styled_no_gdbfmt.
 300         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 301         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 302         unfiltered output.
 303         * ui-style.h (struct ui_file_style) <ptr>: New method.
 304
 305 2019-10-01  Tom Tromey  <tom@tromey.com>
 306
 307         * unittests/format_pieces-selftests.c: Update.  Add final format.
 308         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 309         empty literal pieces.
 310
 311 2019-10-01  Tom Tromey  <tom@tromey.com>
 312
 313         * ui-out.h (enum class ui_out_style_kind): Remove.
 314         (class ui_out) <field_string, field_stsream, do_field_string>:
 315         Change type of "style".
 316         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 317         (ui_out::field_string): Update.
 318         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 319         of "style".
 320         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 321         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 322         * stack.c (print_frame_arg, print_frame_info, print_frame):
 323         Update.
 324         * source.c (print_source_lines_base): Update.
 325         * solib.c (info_sharedlibrary_command): Update.
 326         * skip.c (info_skip_command): Update.
 327         * record-btrace.c (btrace_call_history_src_line)
 328         (btrace_call_history): Update.
 329         * python/py-framefilter.c (py_print_frame): Update.
 330         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 331         "style".
 332         * mi/mi-out.c (mi_ui_out::do_table_header)
 333         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 334         (mi_ui_out::do_field_string): Update.
 335         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 336         Update.
 337         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 338         "style".
 339         * cli-out.c (cli_ui_out::do_table_header)
 340         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 341         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 342         (cli_ui_out::do_field_fmt): Update.
 343         * breakpoint.c (print_breakpoint_location): Update.
 344         (update_static_tracepoint): Update.
 345
 346 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 347
 348         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 349         conversion of gdb_datadir.
 350         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 351         remove not needed c_str ().
 352
 353 2019-09-30  Ali Tamur <tamur@google.com>
 354
 355         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 356         (dwarf2_string_attr): Likewise.
 357
 358 2019-09-30  Ali Tamur <tamur@google.com>
 359
 360         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 361         (process_full_type_unit): Likewise.
 362         (dump_die_shallow): Likewise.
 363         (cu_debug_loc_section): Likewise.
 364
 365 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 366
 367         * minsyms.c (compare_minimal_symbols): Rename to...
 368         (minimal_symbol_is_less_than): ...this, and adjust to STL
 369         conventions (return bool, take arguments as references)
 370         (minimal_symbol_reader::install): Call std::sort instead
 371         of qsort.
 372
 373 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 374
 375         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 376         hash and why.
 377         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 378         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 379
 380 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 381
 382         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 383         * psympriv.h (add_psymbol_to_list): Move comment here and update
 384         it.
 385
 386 2019-09-29  Tom de Vries  <tdevries@suse.de>
 387
 388         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 389         Use $tmpdir/$(basename "$output_file").dwz instead of
 390         "${output_file}.dwz".
 391
 392 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 393
 394         PR gdb/25045
 395         * hppa-linux-nat.c: Include gdbarch.h.
 396
 397 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 398
 399         * blockframe.c (find_pc_partial_function): Change return type to bool.
 400         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 401         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 402         (stub_gnu_ifunc_resolve_name): Likewise.
 403         * symtab.c (compare_filenames_for_search): Likewise.
 404         (compare_glob_filenames_for_search): Likewise.
 405         (matching_obj_sections): Likewise.
 406         (symbol_matches_domain): Likewise.
 407         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 408         (find_line_pc): Change return type to bool.
 409         (find_line_pc_range): Likewise.
 410         (producer_is_realview): Likewise.
 411         * symtab.h (symbol_matches_domain): Likewise.
 412         (find_pc_partial_function): Likewise.
 413         (find_pc_line_pc_range): Likewise.
 414         (in_gnu_ifunc_stub): Likewise.
 415         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 416         (find_line_pc): Likewise.
 417         (find_line_pc_range): Likewise.
 418         (matching_obj_sections): Likewise.
 419         (find_line_symtab): Change out parameter to bool.
 420         (producer_is_realview): Change return type to bool.
 421         (compare_filenames_for_search): Likewise.
 422         (compare_glob_filenames_for_search): Likewise.
 423
 424 2019-09-26  Tom Tromey  <tom@tromey.com>
 425
 426         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 427         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 428         * gdb_usleep.h: Remove.
 429         * gdb_usleep.c: Remove.
 430         * utils.c: Don't include gdb_usleep.h.
 431
 432 2019-09-26  Tom Tromey  <tromey@adacore.com>
 433
 434         * python/py-type.c (type_to_type_object): Call check_typedef
 435         for stub types.
 436
 437 2019-09-26  Tom Tromey  <tom@tromey.com>
 438
 439         * utils.h (initialize_utils): Don't declare.
 440         * top.c (gdb_init): Don't call initialize_utils.
 441         * utils.c (initialize_utils): Remove.  Move contents...
 442         (_initialize_utils): ... here.
 443
 444 2019-09-25  Tom Tromey  <tom@tromey.com>
 445
 446         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 447         * utils.h (make_hex_string): Don't declare.
 448         * utils.c (make_hex_string): Remove.
 449
 450 2019-09-24  Tom de Vries  <tdevries@suse.de>
 451
 452         PR gdb/23815
 453         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 454         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 455
 456 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 457
 458         * NEWS: Mention new simulator port for PRU.
 459
 460 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 461
 462         * ada-exp.y (write_object_remaining): Update.
 463         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 464         and eliminate the static buffer.
 465         (ada_decode_symbol): Update.
 466         (ada_la_decode): Update.
 467         (ada_sniff_from_mangled_name): Update.
 468         (is_valid_name_for_wild_match): Update.
 469         (ada_lookup_name_info::matches): Update and simplify.
 470         (name_matches_regex): Update.
 471         (ada_add_global_exceptions): Update.
 472         * ada-lang.h (ada_decode): Update signature.
 473         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 474         * dwarf-index-write.c (debug_names::insert): Update.
 475
 476 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 477
 478         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 479         formatting.
 480
 481 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 482
 483         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 484         Change "nonzero" to "true" in documentation.
 485
 486 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 487
 488         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 489         (_initialize_darwin_solib): Don't set
 490         darwin_so_ops.lookup_lib_global_symbol.
 491         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 492         set_gdbarch_iterate_over_objfiles_in_search_order.
 493         (elf_lookup_lib_symbol): Rename to...
 494         (svr4_iterate_over_objfiles_in_search_order): this, and update
 495         to iterate semantics.
 496         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 497         * solib.c (solib_global_lookup): Remove.
 498         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 499         (solib_global_lookup): Remove.
 500         * symtab.c (lookup_global_or_static_symbol): Remove call to
 501         solib_global_lookup.
 502
 503 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 504
 505         * NEWS: Move entries about default MI version now being
 506         version 3, and about the GDB/MI fix for multi-location
 507         breakpoints to the "since GDB 8.3" section.
 508
 509 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 510
 511         GDB 8.3.1 released.
 512
 513 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 514
 515         * NEWS: Mention that Cell/B.E. debugging support was removed.
 516         * MAINTAINERS: Remove spu target.
 517
 518         * config/djgpp/fnchange.lst: Remove entries for removed files.
 519
 520         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 521         spu-multiarch.o, and spu-tdep.o.
 522         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 523         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 524         spu-multiarch.c, and spu-tdep.c.
 525         * spu-linux-nat.c: Remove file.
 526         * spu-multiarch.c: Remove file.
 527         * spu-tdep.c: Remove file.
 528         * spu-tdep.h: Remove file.
 529         * solib-spu.c: Remove file.
 530         * solib-spu.h: Remove file.
 531
 532         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 533         * configure.nat (spu-linux): Remove.
 534         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 535         solib-multiarch.o from gdb_target_obs.
 536         (spu*-*-*): Remove.
 537
 538         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 539         feature flag.
 540         (ppc_linux_no_features): Update.
 541         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 542         Cell/B.E. support.
 543         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 544         (tdesc_powerpc_cell64l): Likewise.
 545         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 546         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 547         Cell/B.E. support.
 548         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 549         Do not include "features/rs6000/powerpc-cell32l.c" or
 550         "features/rs6000/powerpc-cell64l.c".
 551         (ppc_linux_spu_section): Remove.
 552         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 553         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 554         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 555         (ppc_linux_spe_context_lookup): Remove.
 556         (ppc_linux_spe_context_inferior_created): Remove.
 557         (ppc_linux_spe_context_solib_loaded): Remove.
 558         (ppc_linux_spe_context_solib_unloaded): Remove.
 559         (ppc_linux_spe_context): Remove.
 560         (struct ppu2spu_cache): Remove.
 561         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 562         (struct ppu2spu_data): Remove.
 563         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 564         ppu2spu_unwind): Remove.
 565         (ppc_linux_init_abi): Remove Cell/B.E. support.
 566         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 567
 568         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 569         (rs6000/powerpc-cell64l-expedite): Likewise
 570         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 571         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 572         rs6000/powerpc-cell64l.xml.
 573         * features/rs6000/powerpc-cell32l.xml: Remove.
 574         * features/rs6000/powerpc-cell64l.xml: Likewise.
 575         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 576         * features/rs6000/powerpc-cell64l.c: Likewise.
 577         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 578         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 579         * regformats/reg-spu.dat: Remove.
 580
 581         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 582         * corelow.c (struct spuid_list): Remove.
 583         (add_to_spuid_list): Remove.
 584         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 585         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 586         (remote_protocol_features): Remove associated entries.
 587         (_initialize_remote): No longer initialize them.
 588         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 589         * linux-nat.c (SPUFS_MAGIC): Remove.
 590         (linux_proc_xfer_spu): Remove.
 591         (spu_enumerate_spu_ids): Remove.
 592         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 593         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 594         (linux_make_corefile_notes): No longer call it.
 595
 596         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 597         (cooked_write_test): Likewise.
 598
 599 2019-09-20  Tom Tromey  <tom@tromey.com>
 600
 601         * NEWS: Mention case-sensitivity of TUI commands.
 602         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 603         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 604         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 605
 606 2019-09-20  Tom Tromey  <tom@tromey.com>
 607
 608         * tui/tui-source.c (tui_source_window::set_contents): Use
 609         make_unique_xstrdup.
 610         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 611         make_unique_xstrdup.
 612
 613 2019-09-20  Tom Tromey  <tom@tromey.com>
 614
 615         * tui/tui-data.c: Remove separator comments.
 616         * tui/tui-layout.c: Remove separator comments.
 617         * tui/tui-win.c: Remove separator comments.
 618         * tui/tui-wingeneral.c: Remove separator comments.
 619
 620 2019-09-20  Tom Tromey  <tom@tromey.com>
 621
 622         * tui/tui.h (strcat_to_buf): Don't declare.
 623         * tui/tui.c (strcat_to_buf): Remove.
 624
 625 2019-09-20  Tom Tromey  <tom@tromey.com>
 626
 627         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 628         from "fullname".
 629         * tui/tui-source.c (tui_source_window::set_contents)
 630         (tui_source_window::location_matches_p)
 631         (tui_source_window::maybe_update): Update.
 632
 633 2019-09-20  Tom Tromey  <tom@tromey.com>
 634
 635         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 636         Update.
 637         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 638         prefix.
 639         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 640         (tui_data_window::line_from_reg_element_no)
 641         (tui_data_window::first_reg_element_no_inline)
 642         (tui_data_window::show_registers)
 643         (tui_data_window::show_register_group)
 644         (tui_data_window::display_registers_from)
 645         (tui_data_window::display_registers_from_line)
 646         (tui_data_window::first_data_item_displayed)
 647         (tui_data_window::delete_data_content_windows)
 648         (tui_data_window::erase_data_content)
 649         (tui_data_window::do_scroll_vertical)
 650         (tui_data_window::refresh_window)
 651         (tui_data_window::check_register_values): Update.
 652
 653 2019-09-20  Tom Tromey  <tom@tromey.com>
 654
 655         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
 656         (struct tui_locator_window) <full_name, proc_name>: Now
 657         std::string.
 658         * tui/tui-stack.c (tui_locator_window::make_status_line)
 659         (tui_locator_window::set_locator_fullname)
 660         (tui_locator_window::set_locator_info): Update.
 661         * tui/tui-source.c (tui_source_window::set_contents)
 662         (tui_source_window::showing_source_p): Update.
 663
 664 2019-09-20  Tom Tromey  <tom@tromey.com>
 665
 666         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
 667         Don't call tui_locator_win_info_ptr.
 668
 669 2019-09-20  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-win.c (tui_resize_all): Don't call refresh.
 672
 673 2019-09-20  Tom Tromey  <tom@tromey.com>
 674
 675         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
 676         height for locator.
 677         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
 678         * tui/tui-layout.c (show_source_disasm_command, show_data)
 679         (show_source_or_disasm_and_command): Use 1 as height for locator.
 680
 681 2019-09-20  Tom Tromey  <tom@tromey.com>
 682
 683         * tui/tui.c (tui_enable): Update.
 684         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
 685         Update.
 686         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
 687         Update.
 688         * tui/tui-data.c (win_resized): Now bool.
 689         (tui_win_resized): Return bool.
 690         (tui_set_win_resized_to): Accept a bool.
 691
 692 2019-09-20  Tom Tromey  <tom@tromey.com>
 693
 694         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
 695         Change type of "refresh_values_only".
 696         * tui/tui-regs.c (tui_data_window::show_register_group): Change
 697         type of "refresh_values_only".
 698
 699 2019-09-20  Tom Tromey  <tom@tromey.com>
 700
 701         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
 702         std::string.
 703         (tui_disassemble): Add "pos" parameter.
 704         (tui_disasm_window::set_contents): Simplify.
 705
 706 2019-09-20  Tom Tromey  <tom@tromey.com>
 707
 708         * tui/tui-winsource.h (struct tui_source_window_base)
 709         <show_source_content>: Now private.
 710         * tui/tui-winsource.c
 711         (tui_source_window_base::show_source_content): Don't handle empty
 712         content case.
 713
 714 2019-09-20  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-layout.c (show_source_disasm_command)
 717         (show_source_or_disasm_and_command): Don't call
 718         show_source_content.
 719
 720 2019-09-20  Tom Tromey  <tom@tromey.com>
 721
 722         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
 723         Declare.
 724         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
 725         from tui_make_status_line.
 726         (tui_locator_window::rerender): Update.
 727
 728 2019-09-20  Tom Tromey  <tom@tromey.com>
 729
 730         * tui/tui-stack.c (tui_make_status_line): Return std::string.
 731         (tui_locator_window::rerender): Update.
 732
 733 2019-09-20  Tom Tromey  <tom@tromey.com>
 734
 735         * tui/tui-winsource.h (struct tui_source_window_base)
 736         <~tui_source_window_base>: Don't declare.
 737         <fullname>: Remove.
 738         * tui/tui-winsource.c (~tui_source_window_base): Remove.
 739         * tui/tui-source.h (struct tui_source_window) <fullname>: New
 740         member.
 741         * tui/tui-source.c (tui_source_window::set_contents): Update.
 742         (tui_source_window::location_matches_p)
 743         (tui_source_window::maybe_update): Update.
 744
 745 2019-09-20  Tom Tromey  <tom@tromey.com>
 746
 747         * tui/tui-winsource.h (~tui_source_element): Remove.
 748         (tui_source_element): Update.
 749         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
 750         * tui/tui-winsource.c (tui_show_source_line): Update.
 751         * tui/tui-source.c (tui_source_window::set_contents): Update.
 752         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
 753
 754 2019-09-20  Tom Tromey  <tom@tromey.com>
 755
 756         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
 757         declare.
 758         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
 759         tui_clear_source_windows_detail.
 760         * tui/tui-winsource.h (struct tui_source_window_base)
 761         <clear_detail>: Don't declare.
 762         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
 763         Remove.
 764         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
 765
 766 2019-09-20  Tom Tromey  <tromey@adacore.com>
 767
 768         PR ada/24919:
 769         * block.c (contained_in): Fix final return value.
 770
 771 2019-09-20  Alan Modra  <amodra@gmail.com>
 772
 773         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
 774         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
 775         (read_indirect_string_from_dwz): Use bfd accessor.
 776         * dwarf2read.h (struct dwz_file <filename>): Likewise.
 777         * machoread.c (macho_symfile_read_all_oso): Likewise.
 778         * solib.c (solib_bfd_open): Likewise.
 779
 780 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 781
 782         * eval.c: Move declaration of overload_resolution to...
 783         * value.h: ...here.
 784
 785 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 786
 787         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
 788         * arm-linux-tdep.c: Likewise.
 789         * arm-nbsd-nat.c: Likewise.
 790         * arm-tdep.h: Declare arm_apcs_32.
 791         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
 792
 793 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
 794
 795         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
 796         * dwarf2read.h: Declare dwarf_always_disassemble.
 797
 798 2019-09-19  Tom de Vries  <tdevries@suse.de>
 799
 800         PR gdb/25009
 801         * source-cache.c (source_cache::ensure): Catch exception thrown during
 802         construction of the highlighter.
 803
 804 2019-09-18  Alan Modra  <amodra@gmail.com>
 805
 806         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
 807         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
 808         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
 809         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
 810         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
 811         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
 812         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
 813         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
 814         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
 815         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
 816         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
 817         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
 818         * solib-spu.c, * solib-svr4.c, * solib-target.c,
 819         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
 820         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
 821         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
 822         * mi/mi-interp.c: Update throughout for bfd section macro and
 823         function changes.
 824         * gcore (gcore_create_callback): Use bfd_set_section_lma.
 825         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
 826
 827 2019-09-18  Tom Tromey  <tom@tromey.com>
 828
 829         * NEWS: Add entry.
 830         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
 831         call rl_initialize.
 832         (tui_enable): Do not call rl_initialize.
 833
 834 2019-09-18  Christian Groessler  <chris@groessler.org>
 835
 836         * alpha-linux-nat.c: Include gdbarch.h.
 837
 838 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
 839
 840         * ui-file.c: Include cli/cli-style.h.
 841         (term_cli_styling): Remove cli_styling declaration.
 842
 843 2019-09-18  Alan Modra  <amodra@gmail.com>
 844
 845         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
 846         to bfd_asymbol_section.
 847
 848 2019-09-18  Alan Modra  <amodra@gmail.com>
 849
 850         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
 851         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
 852         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
 853
 854 2019-09-18  Alan Modra  <amodra@gmail.com>
 855
 856         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
 857         * spu-linux-nat.c (spu_bfd_open): Likewise.
 858
 859 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
 860
 861         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
 862         to bool to match definition in dwarf2read.c.
 863
 864 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
 865
 866         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
 867         (print_signatures): Likewise.
 868         (trust_pad_over_xvs): Likewise.
 869         * arch/aarch64-insn.c (aarch64_debug): Likewise.
 870         * arch/aarch64-insn.h (aarch64_debug): Likewise.
 871         * arm-linux-nat.c (arm_apcs_32): Likewise.
 872         * arm-linux-tdep.c (arm_apcs_32): Likewise.
 873         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
 874         * arm-tdep.c (arm_debug): Likewise.
 875         (arm_apcs_32): Likewise.
 876         * auto-load.c (debug_auto_load): Likewise.
 877         (auto_load_gdb_scripts): Likewise.
 878         (global_auto_load): Likewise.
 879         (auto_load_local_gdbinit): Likewise.
 880         (auto_load_local_gdbinit_loaded): Likewise.
 881         * auto-load.h (global_auto_load): Likewise.
 882         (auto_load_local_gdbinit): Likewise.
 883         (auto_load_local_gdbinit_loaded): Likewise.
 884         * breakpoint.c (disconnected_dprintf): Likewise.
 885         (breakpoint_proceeded): Likewise.
 886         (automatic_hardware_breakpoints): Likewise.
 887         (always_inserted_mode): Likewise.
 888         (target_exact_watchpoints): Likewise.
 889         (_initialize_breakpoint): Update.
 890         * breakpoint.h (target_exact_watchpoints): Change to bool.
 891         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
 892         * cli/cli-cmds.c (trace_commands): Likewise.
 893         * cli/cli-cmds.h (trace_commands): Likewise.
 894         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
 895         to bool*.
 896         * cli/cli-logging.c (logging_overwrite): Change to bool.
 897         (logging_redirect): Likewise.
 898         (debug_redirect): Likewise.
 899         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
 900         (struct boolean_option_def) <get_var_address_cb_>: Change return type
 901         to bool.
 902         <boolean_option_def>: Update.
 903         (struct flag_option_def): Change default type of Context to bool
 904         from int.
 905         <flag_option_def>: Change return type of var_address_cb_ to bool*.
 906         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
 907         (get_setshow_command_value_string): Likewise.
 908         * cli/cli-style.c (cli_styling): Change to bool.
 909         (source_styling): Likewise.
 910         * cli/cli-style.h (source_styling): Likewise.
 911         (cli_styling): Likewise.
 912         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
 913         to bool.
 914         * command.h (var_types): Update comment.
 915         (add_setshow_boolean_cmd): Change int* var argument to bool*.
 916         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
 917         bool.
 918         (debug_compile_cplus_scopes): Likewise.
 919         * compile/compile-internal.h (compile_debug): Likewise.
 920         * compile/compile.c (compile_debug): Likewise.
 921         (struct compile_options) <raw>: Likewise.
 922         * cp-support.c (catch_demangler_crashes): Likewise.
 923         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
 924         (usr_cmd_cris_dwarf2_cfi): Likewise.
 925         * csky-tdep.c (csky_debug): Likewise.
 926         * darwin-nat.c (enable_mach_exceptions): Likewise.
 927         * dcache.c (dcache_enabled_p): Likewise.
 928         * defs.h (info_verbose): Likewise.
 929         * demangle.c (demangle): Likewise.
 930         (asm_demangle): Likewise.
 931         * dwarf-index-cache.c (debug_index_cache): Likewise.
 932         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
 933         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
 934         * dwarf2read.c (check_physname): Likewise.
 935         (use_deprecated_index_sections): Likewise.
 936         (dwarf_always_disassemble): Likewise.
 937         * eval.c (overload_resolution): Likewise.
 938         * event-top.c (set_editing_cmd_var): Likewise.
 939         (exec_done_display_p): Likewise.
 940         * event-top.h (set_editing_cmd_var): Likewise.
 941         (exec_done_display_p): Likewise.
 942         * exec.c (write_files): Likewise.
 943         * fbsd-nat.c (debug_fbsd_lwp): Likewise
 944         (debug_fbsd_nat): Likewise.
 945         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
 946         Likewise.
 947         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
 948         <backtrace_past_entry> Likewise.
 949         * gdb-demangle.h (demangle): Likewise.
 950         (asm_demangle): Likewise.
 951         * gdb_bfd.c (bfd_sharing): Likewise.
 952         * gdbcore.h (write_files): Likewise.
 953         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
 954         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
 955         * gdbthread.h (print_thread_events): Likewise.
 956         * gdbtypes.c (opaque_type_resolution): Likewise.
 957         (strict_type_checking): Likewise.
 958         * gnu-nat.c (gnu_debug_flag): Likewise.
 959         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
 960         * guile/scm-param.c (pascm_variable): Add boolval.
 961         (add_setshow_generic): Update.
 962         (pascm_param_value): Update.
 963         (pascm_set_param_value_x): Update.
 964         * hppa-tdep.c (hppa_debug): Change to bool..
 965         * infcall.c (may_call_functions_p): Likewise.
 966         (coerce_float_to_double_p): Likewise.
 967         (unwind_on_signal_p): Likewise.
 968         (unwind_on_terminating_exception_p): Likewise.
 969         * infcmd.c (startup_with_shell): Likewise.
 970         * inferior.c (print_inferior_events): Likewise.
 971         * inferior.h (startup_with_shell): Likewise.
 972         (print_inferior_events): Likewise.
 973         * infrun.c (step_stop_if_no_debug): Likewise.
 974         (detach_fork): Likewise.
 975         (debug_displaced): Likewise.
 976         (disable_randomization): Likewise.
 977         (non_stop): Likewise.
 978         (non_stop_1): Likewise.
 979         (observer_mode): Likewise.
 980         (observer_mode_1): Likewise.
 981         (set_observer_mode): Update.
 982         (sched_multi): Change to bool.
 983         * infrun.h (debug_displaced): Likewise.
 984         (sched_multi): Likewise.
 985         (step_stop_if_no_debug): Likewise.
 986         (non_stop): Likewise.
 987         (disable_randomization): Likewise.
 988         * linux-tdep.c (use_coredump_filter): Likewise.
 989         (dump_excluded_mappings): Likewise.
 990         * linux-thread-db.c (auto_load_thread_db): Likewise.
 991         (check_thread_db_on_load): Likewise.
 992         * main.c (captured_main_1): Update.
 993         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
 994         xx2_opt, boolean_opt>: Change to bool.
 995         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
 996         * maint.c (maintenance_profile_p): Likewise.
 997         (per_command_time): Likewise.
 998         (per_command_space): Likewise.
 999         (per_command_symtab): Likewise.
1000         * memattr.c (inaccessible_by_default): Likewise.
1001         * mi/mi-main.c (mi_async): Likewise.
1002         (mi_async_1): Likewise.
1003         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1004         * nat/fork-inferior.h (startup_with_shell): Likewise.
1005         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1006         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1007         * nios2-tdep.c (nios2_debug): Likewise.
1008         * or1k-tdep.c (or1k_debug): Likewise.
1009         * parse.c (parser_debug): Likewise.
1010         * parser-defs.h (parser_debug): Likewise.
1011         * printcmd.c (print_symbol_filename): Likewise.
1012         * proc-api.c (procfs_trace): Likewise.
1013         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1014         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1015         (set_parameter_value): Update.
1016         (add_setshow_generic): Update.
1017         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1018         to bool*.
1019         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1020         int*.
1021         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1022         * record-btrace.c (record_btrace_target::store_registers): Update.
1023         * record-full.c (record_full_memory_query): Change to bool.
1024         (record_full_stop_at_limit): Likewise.
1025         * record-full.h (record_full_memory_query): Likewise.
1026         * remote-notif.c (notif_debug): Likewise.
1027         * remote-notif.h (notif_debug): Likewise.
1028         * remote.c (use_range_stepping): Likewise.
1029         (interrupt_on_connect): Likewise.
1030         (remote_break): Likewise.
1031         * ser-tcp.c (tcp_auto_retry): Likewise.
1032         * ser-unix.c (serial_hwflow): Likewise.
1033         * skip.c (debug_skip): Likewise.
1034         * solib-aix.c (solib_aix_debug): Likewise.
1035         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1036         (spu_auto_flush_cache_p): Likewise.
1037         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1038         Likewise.
1039         (struct info_print_options) <quiet>: Likewise.
1040         * symfile-debug.c (debug_symfile): Likewise.
1041         * symfile.c (auto_solib_add): Likewise.
1042         (separate_debug_file_debug): Likewise.
1043         * symfile.h (auto_solib_add): Likewise.
1044         (separate_debug_file_debug): Likewise.
1045         * symtab.c (basenames_may_differ): Likewise.
1046         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1047         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1048         (struct info_types_options) <quiet>: Likewise.
1049         * symtab.h (demangle): Likewise.
1050         (basenames_may_differ): Likewise.
1051         * target-dcache.c (stack_cache_enabled_1): Likewise.
1052         (code_cache_enabled_1): Likewise.
1053         * target.c (trust_readonly): Likewise.
1054         (may_write_registers): Likewise.
1055         (may_write_memory): Likewise.
1056         (may_insert_breakpoints): Likewise.
1057         (may_insert_tracepoints): Likewise.
1058         (may_insert_fast_tracepoints): Likewise.
1059         (may_stop): Likewise.
1060         (auto_connect_native_target): Likewise.
1061         (target_stop_and_wait): Update.
1062         (target_async_permitted): Change to bool.
1063         (target_async_permitted_1): Likewise.
1064         (may_write_registers_1): Likewise.
1065         (may_write_memory_1): Likewise.
1066         (may_insert_breakpoints_1): Likewise.
1067         (may_insert_tracepoints_1): Likewise.
1068         (may_insert_fast_tracepoints_1): Likewise.
1069         (may_stop_1): Likewise.
1070         * target.h (target_async_permitted): Likewise.
1071         (may_write_registers): Likewise.
1072         (may_write_memory): Likewise.
1073         (may_insert_breakpoints): Likewise.
1074         (may_insert_tracepoints): Likewise.
1075         (may_insert_fast_tracepoints): Likewise.
1076         (may_stop): Likewise.
1077         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1078         (make_thread_apply_all_options_def_group): Change argument from int*
1079         to bool*.
1080         (thread_apply_all_command): Update.
1081         (print_thread_events): Change to bool.
1082         * top.c (confirm): Likewise.
1083         (command_editing_p): Likewise.
1084         (history_expansion_p): Likewise.
1085         (write_history_p): Likewise.
1086         (info_verbose): Likewise.
1087         * top.h (confirm): Likewise.
1088         (history_expansion_p): Likewise.
1089         * tracepoint.c (disconnected_tracing): Likewise.
1090         (circular_trace_buffer): Likewise.
1091         * typeprint.c (print_methods): Likewise.
1092         (print_typedefs): Likewise.
1093         * utils.c (debug_timestamp): Likewise.
1094         (sevenbit_strings): Likewise.
1095         (pagination_enabled): Likewise.
1096         * utils.h (sevenbit_strings): Likewise.
1097         (pagination_enabled): Likewise.
1098         * valops.c (overload_resolution): Likewise.
1099         * valprint.h (struct value_print_options) <prettyformat_arrays,
1100         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1101         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1102         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1103         Likewise.
1104         * windows-nat.c (new_console): Likewise.
1105         (cygwin_exceptions): Likewise.
1106         (new_group): Likewise.
1107         (debug_exec): Likewise.
1108         (debug_events): Likewise.
1109         (debug_memory): Likewise.
1110         (debug_exceptions): Likewise.
1111         (useshell): Likewise.
1112         * windows-tdep.c (maint_display_all_tib): Likewise.
1113         * xml-support.c (debug_xml): Likewise.
1114
1115 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1116
1117         * source.c (prepare_path_for_appending): New function.
1118         (openp): Make use of new function.
1119         (find_and_open_source): Search for the compilation directory and
1120         source file as a relative path beneath the directory search path.
1121
1122 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1123
1124         * source-cache.c (source_cache::get_line_charpos): Catch
1125         exceptions and return false, this matches the behaviour documented
1126         in the header file.
1127
1128 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1129
1130         * ada-tasks.c (info_task): Remove quoting of the task's name.
1131
1132 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1133
1134         * symfile.c (auto_solib_add): Replace comment with a reference
1135         to the header file.
1136
1137 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1138
1139         * NEWS: Mention that gdb can now be compiled with Python 3
1140         on Windows.
1141
1142 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1143
1144         * maint.c (maint_print_section_data::maint_print_section_data):
1145         Force use of 'float log10 (float)' by casting the argument to
1146         float.
1147
1148 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1149
1150         * maint.c: Add 'cmath' include.
1151         (struct maint_print_section_data): New structure.
1152         (print_section_index): New function.
1153         (print_bfd_section_info): Add header comment, small whitespace
1154         cleanup, and update to call new print_section_index function.
1155         (print_objfile_section_info): Likewise.
1156         (maint_obj_section_from_bfd_section): New function.
1157         (print_bfd_section_info_maybe_relocated): New function.
1158         (maintenance_info_sections): Add header comment, always use
1159         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1160
1161 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1162
1163         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1164         inner scope, add check that the objfile has psymtabs before
1165         checking psymtabs_addrmap.
1166         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1167
1168 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1169
1170         * NEWS: Announce that Ada task names are now shown at more places,
1171         and between quotes (except in info task output).
1172         * gdb/ada-tasks.c (task_to_str): New function.
1173         (display_current_task_id): Call task_to_str.
1174         (task_command_1): Likewise.
1175         (print_ada_task_info): In non-mi mode, Properly align headers and data
1176         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1177
1178 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1179
1180         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1181         prstatus.pr_lwp.pr_info instead of making it up.
1182
1183 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1184
1185         * auto-load.c (auto_load_expand_dir_vars): Update.
1186         * defs.h (gdb_datadir): Change to std::string.
1187         (python_libdir): Likewise.
1188         (relocate_gdb_directory): Change return type to std::string.
1189         * guile/guile.c (gdbscm_data_directory): Update.
1190         (initialize_scheme_side): Update.
1191         * jit.c (jit_reader_dir): Change to std::string.
1192         (jit_reader_load_command): Update.
1193         * main.c (gdb_datadir): Change to std::string.
1194         (python_libdir): Likewise.
1195         (set_gdb_data_directory): Update.
1196         (relocate_path): Change to return std::string.
1197         (relocate_gdb_directory): Change to return std::string.
1198         (relocate_gdbinit_path_maybe_in_datadir): Update.
1199         (captured_main_1): Update.
1200         * python/python.c (do_start_initialization): Update.
1201         * top.c (show_gdb_datadir): Update.
1202         * xml-syscall.c (xml_init_syscalls_info): Update.
1203         (init_syscalls_info): Update.
1204
1205 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1206
1207         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1208         out of get_init_files.
1209         (get_init_files): Update.
1210
1211 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1212
1213         * main.c (get_init_files): Change to use std::string.
1214         (captured_main_1): Update.
1215         (print_gdb_help): Update.
1216
1217 2019-09-11  Ali Tamur  <tamur@google.com>
1218
1219         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1220         implementation.
1221
1222 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1223
1224         * dbxread.c (read_dbx_symtab): Update.
1225         * dwarf2read.c (load_partial_dies): Update.
1226         * mdebugread.c (parse_partial_symbols): Update.
1227         (handle_psymbol_enumerators): Update.
1228         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1229         * psymtab.c (add_psymbol_to_bcache): Likewise.
1230         (add_psymbol_to_list): Likewise.
1231         * symtab.c (symbol_set_names): Likewise.
1232         * symtab.h (symbol_set_names): Likewise.
1233         * xcoffread.c (scan_xcoff_symtab): Update.
1234
1235 2019-09-11  Tom Tromey  <tom@tromey.com>
1236
1237         * symfile-mem.c (symbol_file_add_from_memory): Use
1238         bfd_set_filename.
1239         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1240         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1241
1242 2019-09-10  Tom Tromey  <tromey@adacore.com>
1243
1244         * dwarf-index-write.c (write_psymbols): Extend error message.
1245         (debug_names::insert): Add Ada code.
1246         (debug_names::write_psymbols): Remove Ada check.
1247         (debug_names) <m_string_obstack>: New member.
1248         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1249         (gdb_index_symbol_name_matcher::matches): Remove.
1250         (mapped_index_base::find_name_components_bounds): Add "lang"
1251         parameter.
1252         (mapped_index_base::build_name_components): Also split names
1253         according to Ada syntax.
1254         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1255         type of "match_callback".
1256         (check_match, check_find_bounds_finds)
1257         (dw2_expand_symtabs_matching): Update.
1258         (dw2_debug_names_iterator): Add new constructor.
1259         (dw2_debug_names_map_matching_symbols): New function.
1260         (dw2_debug_names_expand_symtabs_matching): Update.
1261         (dwarf2_debug_names_functions): Use
1262         dw2_debug_names_map_matching_symbols.
1263
1264 2019-09-10  Tom Tromey  <tromey@adacore.com>
1265
1266         * dwarf2read.c (dw2_get_file_names_reader): Add the
1267         CU's file name to the results.
1268
1269 2019-09-10  Tom Tromey  <tromey@adacore.com>
1270
1271         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1272         map_matching_symbols.  Update.
1273         * dwarf2read.c (dw2_map_matching_symbols): Update.
1274         * psymtab.c (match_partial_symbol): Change type; update.
1275         (psym_map_matching_symbols): Likewise.
1276         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1277         type; update.
1278         * symfile.h (struct quick_symbol_functions)
1279         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1280         Remove "match".
1281
1282 2019-09-10  Tom Tromey  <tromey@adacore.com>
1283
1284         * psymtab.c (map_block): Remove.
1285         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1286         * symtab.c (iterate_over_symbols_terminated): New function.
1287         * symtab.c (iterate_over_symbols_terminated): Declare.
1288
1289 2019-09-10  Tom Tromey  <tromey@adacore.com>
1290
1291         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1292         * language.h (struct language_defn) <la_iterate_over_symbols>:
1293         Return bool.
1294         * symtab.c (iterate_over_symbols): Return bool.
1295         * symtab.h (iterate_over_symbols): Return bool.
1296
1297 2019-09-10  Tom Tromey  <tromey@adacore.com>
1298
1299         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1300         (add_nonlocal_symbols): Update.
1301         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1302         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1303         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1304         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1305         Change type of "callback".  Remove "data".
1306
1307
1308 2019-09-09  Ali Tamur  <tamur@google.com>
1309
1310         * dwarf2read.c (comp_unit_head): Update comment.
1311         (dwarf2_dwo_name): New function declaration.
1312         (dwarf_unit_type_name): New function declaration.
1313         (read_comp_unit_head): Add support for new compilation units,
1314         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1315         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1316         (currently named as "signature") in their header. Also clarify error
1317         messages.
1318         (lookup_dwo_id): New function. Returns the dwo id of the given
1319         compile unit.
1320         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1321         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1322         functions.
1323         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1324         (dwarf2_dwo_name): Get the dwo name if present.
1325         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1326         purposes.
1327
1328 2019-09-09  Tom Tromey  <tom@tromey.com>
1329
1330         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1331
1332 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1333
1334         * python/python.c (do_start_initialization): Make progname_copy static,
1335         to avoid a leak report.
1336
1337 2019-09-08  Tom Tromey  <tom@tromey.com>
1338
1339         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1340
1341 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1342
1343         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1344         Change type to gdb::optional<block_enum>.
1345         (dw2_symtab_iter_init): Change block_index parameter type
1346         to gdb::optional<block_enum>.
1347         (dw2_lookup_symbol): Change block_index parameter
1348         type to block_enum.c
1349         (dw2_debug_names_lookup_symbol): Likewise.
1350         * psymtab.c (psym_lookup_symbol): Likewise.
1351         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1352         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1353         Likewise.
1354
1355 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1356
1357         * defs.h (relocate_gdb_directory): Change int to bool in
1358         signature and rename flag to relocatable.
1359         * main.c (relocate_path): Likewise.
1360         (relocate_gdb_directory): Likewise.
1361
1362 2019-09-06  Alan Modra  <amodra@gmail.com>
1363
1364         * coffread.c (coff_symfile_read): Constify filename variable.
1365         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1366         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1367         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1368         * solib.c (reload_shared_libraries_1): Likewise.
1369         * symfile.c (reread_symbols): Likewise.
1370         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1371         * solib-darwin.c (darwin_bfd_open): Likewise.
1372         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1373
1374 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1375
1376         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1377         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1378
1379 2019-09-03  Tom Tromey  <tromey@adacore.com>
1380
1381         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1382         types.
1383         (has_negatives): Unbias a range type bound.
1384         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1385         * gdbtypes.c (operator==): Handle new field.
1386         (create_range_type): Add "bias" parameter.
1387         (create_static_range_type, resolve_dynamic_range): Update.
1388         * gdbtypes.h (struct range_bounds) <bias>: New member.
1389         (create_range_type): Add bias parameter.
1390         * printcmd.c (print_scalar_formatted): Unbias range types.
1391         * value.c (unpack_long): Unbias range types.
1392         (pack_long): Bias range types.
1393
1394 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1395
1396         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1397         probe arguments.
1398
1399 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1400
1401         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1402         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1403         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1404         (compile_probe_arg): Likewise.
1405         * probe.h (get_argument_count): Likewise.
1406         * solib-svr4.c (solib_event_probe_action): Likewise.
1407         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1408
1409 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1410
1411         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1412         code to here...
1413         (svr4_create_solib_event_breakpoints): ...from here.
1414
1415 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1416
1417         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1418         suffix from warning message.
1419
1420 2019-08-30  Tom Tromey  <tom@tromey.com>
1421
1422         * tui/tui-winsource.h (struct tui_source_window_base)
1423         <refresh_all>: Don't declare.
1424         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1425         Remove.
1426         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1427         tui_show_locator_content.
1428         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1429         declare.
1430         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1431         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1432         declare.
1433
1434 2019-08-30  Tom Tromey  <tom@tromey.com>
1435
1436         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1437
1438 2019-08-30  Tom Tromey  <tom@tromey.com>
1439
1440         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1441         Remove unnecessary forward declarations.
1442
1443 2019-08-30  Tom Tromey  <tom@tromey.com>
1444
1445         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1446         rerender.
1447         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1448         tui_show_locator_content.
1449
1450 2019-08-30  Tom Tromey  <tom@tromey.com>
1451
1452         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1453         (tui_locator_window::rerender): Rewrite using body of previous
1454         tui_show_locator_content.
1455
1456 2019-08-30  Tom Tromey  <tom@tromey.com>
1457
1458         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1459         set_locator_fullname>: New methods.
1460         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1461         Rename from tui_set_locator_fullname.
1462         (tui_locator_window::set_locator_info): Rename from
1463         tui_set_locator_info.  Return bool.
1464         (tui_update_locator_fullname, tui_show_frame_info): Update.
1465
1466 2019-08-30  Tom Tromey  <tom@tromey.com>
1467
1468         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1469
1470 2019-08-30  Tom Tromey  <tom@tromey.com>
1471
1472         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1473         call touchwin.
1474
1475 2019-08-30  Tom Tromey  <tom@tromey.com>
1476
1477         * tui/tui-wingeneral.c (box_win): Assume win_info and
1478         win_info->handle cannot be NULL.
1479
1480 2019-08-30  Tom Tromey  <tom@tromey.com>
1481
1482         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1483         refresh_window>: Declare.
1484         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1485         resize.
1486         (tui_data_item_window::rerender): Rename from
1487         tui_display_register.
1488         (tui_data_item_window::refresh_window): New method.
1489         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1490         no-op.
1491
1492 2019-08-30  Tom Tromey  <tom@tromey.com>
1493
1494         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1495         regs_column_count, current_group>: Move later.  Now private.
1496         <get_current_group>: New method.
1497         * tui/tui-regs.c (tui_reg_command): Update.
1498         * tui/tui-layout.c (tui_set_layout): Update.
1499
1500 2019-08-30  Tom Tromey  <tom@tromey.com>
1501
1502         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1503         (tui_data_window::rerender): Don't call
1504         check_and_display_highlight_if_needed.
1505         (tui_data_window::refresh_all): Remove call to
1506         erase_data_content.
1507
1508 2019-08-30  Tom Tromey  <tom@tromey.com>
1509
1510         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1511         (tui_data_window::display_registers_from)
1512         (tui_data_window::display_reg_element_at_line)
1513         (tui_data_window::display_registers_from_line): Remove checks of
1514         "empty".
1515
1516 2019-08-30  Tom Tromey  <tom@tromey.com>
1517
1518         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1519         Don't declare.
1520         * tui/tui-regs.c (tui_data_window::show_registers): Call
1521         rerender.
1522         (tui_data_window::rerender): Rename from display_all_data.
1523         (tui_data_window::rerender): Remove old implementation.
1524
1525 2019-08-30  Tom Tromey  <tom@tromey.com>
1526
1527         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1528         text.
1529         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1530
1531 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1532             Sergio Durigan Junior  <sergiodj@redhat.com>
1533
1534         PR win32/24284
1535         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1536
1537 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1538
1539         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1540         when searching for types.
1541
1542 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1543
1544         * f-lang.c (f_language_defn): Use f_print_typedef.
1545         * f-lang.h (f_print_typedef): Declare.
1546         * f-typeprint.c (f_print_typedef): Define.
1547
1548 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1549
1550         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1551
1552 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1553
1554         * cli/cli-utils.c (info_print_options_defs): Delete.
1555         (make_info_print_options_def_group): Delete.
1556         (extract_info_print_options): Delete.
1557         (info_print_command_completer): Delete.
1558         (info_print_args_help): Add extra parameter, and optionally
1559         include text about -n flag.
1560         * cli/cli-utils.h (struct info_print_options): Delete.
1561         (extract_info_print_options): Delete declaration.
1562         (info_print_command_completer): Delete declaration.
1563         (info_print_args_help): Add extra parameter, extend header
1564         comment.
1565         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1566         search_symbols.
1567         * stack.c (struct info_print_options): New type.
1568         (info_print_options_defs): New file scoped variable.
1569         (make_info_print_options_def_group): New static function.
1570         (info_print_command_completer): New static function.
1571         (info_locals_command): Update to use new local functions.
1572         (info_args_command): Likewise.
1573         (_initialize_stack): Add extra parameter to calls to
1574         info_print_args_help.
1575         * symtab.c (search_symbols): Add extra parameter, use this to
1576         possibly excluse non-debug symbols.
1577         (symtab_symbol_info): Add extra parameter, which is passed on to
1578         search_symbols.
1579         (struct info_print_options): New type.
1580         (info_print_options_defs): New file scoped variable.
1581         (make_info_print_options_def_group): New static function.
1582         (info_print_command_completer): New static function.
1583         (info_variables_command): Update to use local functions, and pass
1584         extra parameter through to symtab_symbol_info.
1585         (info_functions_command): Likewise.
1586         (info_types_command): Pass additional argument through to
1587         symtab_symbol_info.
1588         (rbreak_command): Pass extra argument to search_symbols.
1589         (_initialize_symtab): Add extra arguments for calls to
1590         info_print_args_help, and update help text for 'info variables',
1591         'whereis', and 'info functions' commands.
1592         * symtab.h (search_symbols): Add extra argument to declaration.
1593         * NEWS: Mention new flags.
1594
1595 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1596
1597         * symtab.c (lookup_static_symbol): Call the new function (and move
1598         it down to be next to lookup_global_symbol).
1599         (struct global_sym_lookup_data): Add block_enum member and rename to...
1600         (struct global_or_static_sym_lookup_data): ...this.
1601         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1602         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1603         (lookup_symbol_global_or_static_iterator_cb): ...this.
1604         (lookup_global_or_static_symbol): New function.
1605         (lookup_global_symbol): Call new function.
1606
1607 2019-08-26  Tom de Vries  <tdevries@suse.de>
1608
1609         PR c++/24852
1610         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1611         when pc_probe.prob == NULL.
1612
1613 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1614
1615         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1616         variable symbol_linkage to symbol_linkage_.
1617
1618 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1619
1620         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1621         represent whether the symbol is static, dynamic, or we don't
1622         know.
1623
1624 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1625
1626         * gdb/rx-tdep.c (rx_register_names): New.
1627         (rx_register_name): Delete.
1628         (rx_psw_type): Delete.
1629         (rx_fpsw_type): Delete.
1630         (rx_register_type): Delete.
1631         (rx_gdbarch_init): Convert target-descriptions.
1632         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1633         * gdb/features/Makefile: Add rx.xml.
1634         * gdb/features/rx.xml: New.
1635         * gdb/features/rx.c: Generated.
1636         * gdb/NEWS: Mention target description support.
1637
1638 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1639
1640         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1641         *slot_ptr.
1642
1643 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1644
1645         * configure.ac: Don't check for 'dlfcn.h' (moved to
1646         gdbsupport/common.m4).
1647         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
1648         'gdbsupport/'.
1649         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
1650         * compile/compile-c-support.c: Include
1651         'gdbsupport/gdb-dlfcn.h'.
1652         * gdbsupport/common.m4: Check for 'dlfcn.h'.
1653         * gdb-dlfcn.c: Move to...
1654         * gdbsupport/gdb-dlfcn.c: ... here.
1655         * gdb-dlfcn.h: Move to...
1656         * gdbsupport/gdb-dlfcn.h: ... here.
1657
1658 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
1659
1660         * nios2-tdep.c (struct reg_value): Improve comments.  Make
1661         the offset field signed.
1662
1663 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1664
1665         * python/lib/gdb/__init__.py (_execute_file): New function.
1666         * python/python.c (python_run_simple_file): Call gdb._execute_file
1667         on Windows.
1668
1669 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
1670
1671         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
1672         all uses as this was never set to anything but a zero value.
1673
1674 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
1675
1676         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
1677
1678 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
1679
1680         * tui/tui-data.h (tui_gen_win_info): Add an =default
1681         move constructor, required by some GCC versions.
1682
1683 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
1684
1685         * go32-nat.c (go32_sysinfo): Add hygon_p.
1686
1687 2019-08-20  Tom Tromey  <tom@tromey.com>
1688
1689         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
1690         line_from_reg_element_no, first_reg_element_no_inline,
1691         display_all_data, delete_data_content_windows,
1692         erase_data_content>: Now private.
1693
1694 2019-08-20  Tom Tromey  <tom@tromey.com>
1695
1696         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
1697         (tui_unhighlight_win, tui_highlight_win)
1698         (tui_win_info::make_window): Update.
1699         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
1700
1701 2019-08-20  Tom Tromey  <tom@tromey.com>
1702
1703         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1704         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1705         (MAX_PID_WIDTH): Move to tui-stack.c.
1706         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
1707         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
1708         (MAX_PID_WIDTH): Move from tui-data.h.
1709
1710 2019-08-20  Tom Tromey  <tom@tromey.com>
1711
1712         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
1713         * tui/tui-wingeneral.c (box_win): Change type of win_info.
1714         (box_win): Update.
1715         (tui_gen_win_info::make_window): Rename from tui_make_window.
1716         (tui_win_info::make_window): New method.
1717         (tui_gen_win_info::make_visible): Update.
1718         * tui/tui-source.c (tui_source_window::set_contents): Update.
1719         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
1720         (tui_data_window::display_registers_from): Update.
1721         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
1722         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
1723         Declare.
1724         <can_box>: Remove.
1725         <title>: Remove.
1726         (struct tui_win_info) <make_window>: Declare.
1727         <can_box>: Now virtual.
1728         <title>: New member.
1729         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
1730         * tui/tui-command.c (tui_cmd_window::resize): Update.
1731
1732 2019-08-20  Tom Tromey  <tom@tromey.com>
1733
1734         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
1735         * tui/tui-regs.c (tui_data_window::show_registers): Update.
1736         (tui_data_window::check_register_values): Update.
1737
1738 2019-08-20  Tom Tromey  <tom@tromey.com>
1739
1740         * tui/tui-regs.h (struct tui_data_window): Use
1741         DISABLE_COPY_AND_ASSIGN.
1742         <regs_content>: Change type, removing unique_ptr.
1743         <tui_data_window>: Add move constructor.
1744         * tui/tui-regs.c (tui_data_window::show_registers)
1745         (tui_data_window::show_register_group)
1746         (tui_data_window::display_registers_from)
1747         (tui_data_window::display_registers_from)
1748         (tui_data_window::first_data_item_displayed)
1749         (tui_data_window::delete_data_content_windows)
1750         (tui_data_window::rerender, tui_data_window::refresh_window)
1751         (tui_data_window::check_register_values): Update.
1752
1753 2019-08-20  Tom Tromey  <tom@tromey.com>
1754
1755         * tui/tui-regs.h (struct tui_data_window) <show_registers,
1756         show_register_group>: Declare.
1757         (tui_show_register_group): Don't declare.
1758         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
1759         tui_show_registers.
1760         (tui_data_window::show_register_group): Rename from
1761         tui_show_register_group.
1762         (tui_data_window::check_register_values, tui_reg_command):
1763         Update.
1764         * tui/tui-layout.c (tui_set_layout): Update.
1765
1766 2019-08-20  Tom Tromey  <tom@tromey.com>
1767
1768         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
1769         Declare.
1770         (tui_check_register_values): Don't declare.
1771         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
1772         from tui_check_register_values.
1773         * tui/tui-hooks.c (tui_register_changed): Update.
1774
1775 2019-08-20  Tom Tromey  <tom@tromey.com>
1776
1777         * tui/tui-regs.c (tui_reg_layout): Move later.
1778         (tui_show_registers): Don't enable TUI mode or change layout.
1779
1780 2019-08-20  Tom Tromey  <tom@tromey.com>
1781
1782         * tui/tui-regs.h (struct tui_data_item_window)
1783         <~tui_data_item_window>: Remove.
1784         <content>: Now a unique_xmalloc_ptr.
1785         * tui/tui-regs.c (tui_register_format): Return a
1786         unique_xmalloc_ptr.
1787         (tui_get_register): Update.
1788         (~tui_data_item_window): Remove.
1789         (tui_data_window::display_registers_from, tui_display_register):
1790         Update.
1791         * tui/tui-io.h (tui_expand_tabs): Update.
1792         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
1793         Remove "col" parameter.
1794
1795 2019-08-20  Tom Tromey  <tom@tromey.com>
1796
1797         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
1798         field.
1799         * tui/tui-regs.c (~tui_data_item_window): Update.
1800
1801 2019-08-20  Tom Tromey  <tom@tromey.com>
1802
1803         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
1804         earlier.
1805
1806 2019-08-20  Tom Tromey  <tom@tromey.com>
1807
1808         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
1809
1810 2019-08-20  Tom Tromey  <tom@tromey.com>
1811
1812         * tui/tui-source.h (struct tui_source_window): Update.
1813         * tui/tui-regs.c (tui_show_registers): Update.
1814         * tui/tui-disasm.h (struct tui_disasm_window): Update.
1815         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
1816         (NO_REGS_STRING): Remove defines.
1817
1818 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
1819
1820         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
1821         unnecessary thread walk if remote doesn't support the packet.
1822
1823 2019-08-19  Tom Tromey  <tromey@adacore.com>
1824
1825         * python/py-value.c (value_has_field): Fix indentation.
1826
1827 2019-08-19  Tom Tromey  <tromey@adacore.com>
1828
1829         * printcmd.c (do_one_display, info_display_command): Update.
1830         * block.h (contained_in): Return bool.  Add allow_nested
1831         parameter.
1832         * block.c (contained_in): Return bool.  Add allow_nested
1833         parameter.
1834
1835 2019-08-19  Tom Tromey  <tom@tromey.com>
1836
1837         * configure: Rebuild.
1838         * configure.ac: Disallow the combination of -static-libstdc++ and
1839         source highlight.
1840         * source-cache.c (get_language_name): Handle rust.
1841         (source_cache::get_source_lines): Ignore highlighting exceptions.
1842
1843 2019-08-16  Tom Tromey  <tom@tromey.com>
1844
1845         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
1846         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
1847         (struct tui_source_window_base) <make_visible, refresh_window,
1848         resize>: Remove methods.
1849         <execution_info>: Remove field.
1850         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
1851         (tui_show_source_line, tui_source_window_base)
1852         (~tui_source_window_base): Update.
1853         (tui_source_window_base::resize)
1854         (tui_source_window_base::make_visible)
1855         (tui_source_window_base::refresh_window): Remove.
1856         (tui_source_window_base::update_exec_info): Update.
1857         * tui/tui-source.c (tui_source_window::set_contents): Update.
1858         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1859
1860 2019-08-16  Tom Tromey  <tom@tromey.com>
1861
1862         * tui/tui-hooks.c (tui_remove_hooks): Don't set
1863         deprecated_query_hook.
1864
1865 2019-08-16  Tom Tromey  <tom@tromey.com>
1866
1867         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
1868         (tui_update_source_windows_with_line): Update.
1869         * tui/tui-source.h (struct tui_source_window)
1870         <show_symtab_source>: Declare.
1871         (tui_show_symtab_source): Don't declare.
1872         * tui/tui-source.c (tui_show_symtab_source): Rename from
1873         tui_show_symtab_source.
1874
1875 2019-08-16  Tom Tromey  <tom@tromey.com>
1876
1877         * tui/tui-winsource.h (struct tui_source_window_base)
1878         <set_contents>: Declare.
1879         * tui/tui-winsource.c
1880         (tui_source_window_base::update_source_window_as_is): Update.
1881         * tui/tui-source.h (struct tui_source_window) <set_contents>:
1882         Declare.
1883         (tui_set_source_content): Don't declare.
1884         * tui/tui-source.c (tui_source_window::set_contents): Rename from
1885         tui_set_source_content.
1886         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
1887         Declare.
1888         (tui_set_disassem_content): Don't declare.
1889         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
1890         tui_set_disassem_content.
1891
1892 2019-08-16  Tom Tromey  <tom@tromey.com>
1893
1894         * tui/tui-winsource.h (struct tui_source_window_base)
1895         <update_breakpoint_info>: Declare.
1896         (tui_update_breakpoint_info): Don't declare.
1897         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
1898         (tui_update_all_breakpoint_info): Update.
1899         (tui_source_window_base::update_breakpoint_info): Rename from
1900         tui_update_breakpoint_info.
1901         (tui_source_window_base::update_exec_info): Update.
1902
1903 2019-08-16  Tom Tromey  <tom@tromey.com>
1904
1905         * tui/tui-winsource.h (struct tui_source_window_base)
1906         <update_source_window>: Declare.
1907         (tui_update_source_window): Don't declare.
1908         * tui/tui-winsource.c
1909         (tui_source_window_base::update_source_window): Rename from
1910         tui_update_source_window.
1911         (tui_source_window_base::rerender): Update.
1912         * tui/tui-source.c (tui_source_window::maybe_update): Update.
1913         * tui/tui-disasm.c (tui_show_disassem)
1914         (tui_show_disassem_and_update_source)
1915         (tui_disasm_window::maybe_update): Update.
1916
1917 2019-08-16  Tom Tromey  <tom@tromey.com>
1918
1919         * tui/tui-winsource.h (struct tui_source_window_base)
1920         <update_source_window_as_is>: Declare.
1921         (tui_update_source_window_as_is): Don't declare.
1922         * tui/tui-winsource.c (tui_update_source_window): Update
1923         (tui_source_window_base::update_source_window_as_is): Rename from
1924         tui_update_source_window_as_is.
1925         (tui_source_window_base::refill): Update.
1926         * tui/tui-source.c (tui_show_symtab_source): Update.
1927         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
1928         Update.
1929
1930 2019-08-16  Tom Tromey  <tom@tromey.com>
1931
1932         * tui/tui-winsource.h (tui_update_source_window)
1933         (tui_update_source_window_as_is): Remove "noerror" parameter.
1934         * tui/tui-winsource.c (tui_update_source_window)
1935         (tui_update_source_window_as_is): Remove "noerror" parameter.
1936         (tui_update_source_windows_with_addr)
1937         (tui_update_source_windows_with_line)
1938         (tui_source_window_base::rerender)
1939         (tui_source_window_base::refill): Update.
1940         * tui/tui-source.h (tui_set_source_content)
1941         (tui_show_symtab_source): Remove "noerror" parameter.
1942         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
1943         parameter.
1944         (tui_show_symtab_source): Likewise.
1945         (tui_source_window::maybe_update): Update.
1946         * tui/tui-disasm.c (tui_show_disassem)
1947         (tui_show_disassem_and_update_source)
1948         (tui_disasm_window::do_scroll_vertical)
1949         (tui_disasm_window::maybe_update): Update.
1950
1951 2019-08-16  Tom Tromey  <tom@tromey.com>
1952
1953         * tui/tui.c (tui_is_window_visible): Update.
1954         * tui/tui-wingeneral.c (tui_make_window)
1955         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
1956         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
1957         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
1958         (tui_set_win_height_command, parse_scrolling_args): Update.
1959         * tui/tui-source.c (tui_source_window::style_changed): Update.
1960         * tui/tui-regs.c (tui_show_registers)
1961         (tui_data_window::first_data_item_displayed)
1962         (tui_data_window::delete_data_content_windows)
1963         (tui_check_register_values, tui_reg_command): Update.
1964         * tui/tui-disasm.c (tui_show_disassem): Update.
1965         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
1966         method.
1967         <is_visible>: Remove field.
1968         * tui/tui-data.c (tui_next_win, tui_prev_win)
1969         (tui_delete_invisible_windows): Update.
1970
1971 2019-08-16  Tom Tromey  <tom@tromey.com>
1972
1973         * tui/tui-winsource.h (struct tui_source_window_base)
1974         <m_has_locator>: Remove.
1975         * tui/tui-layout.c (show_source_disasm_command, show_data)
1976         (show_source_or_disasm_and_command): Update.
1977
1978 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
1979
1980         * NEWS (Other MI changes): New subsection.
1981         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
1982         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
1983         * arch-utils.c (default_get_pc_address_flags): New function.
1984         * arch-utils.h (default_get_pc_address_flags): New declaration.
1985         * gdbarch.sh: Add get_pc_address_flags.
1986         * gdbarch.c: Regenerate.
1987         * gdbarch.h: Likewise.
1988         * stack.c (print_pc): New function.
1989         (print_frame_info) (print_frame): Call print_pc.
1990
1991 2019-08-16  Tom de Vries  <tdevries@suse.de>
1992
1993         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
1994         print_objfile_section_info.
1995
1996 2019-08-15  Tom Tromey  <tom@tromey.com>
1997
1998         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
1999         calling update_cmdwin_start_line.
2000         * tui/tui-winsource.h (struct tui_source_window_base)
2001         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2002         <rerender>: Declare.
2003         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2004         Call rerender.
2005         (tui_source_window_base::set_new_height): Remove.
2006         (tui_source_window_base::rerender): Rename from
2007         do_make_visible_with_new_height.
2008         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2009         resize method.
2010         (tui_win_info::make_invisible_and_set_new_height)
2011         (tui_win_info::make_visible_with_new_height): Remove.
2012         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2013         Declare.
2014         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2015         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2016         do_make_visible_with_new_height>: Don't declare.
2017         <rerender>: Declare.
2018         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2019         set_new_height.
2020         (tui_data_window::do_make_visible_with_new_height): Remove.
2021         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2022         call tui_show_locator_content.
2023         (tui_gen_win_info::resize): Call rerender.
2024         (show_source_or_disasm_and_command): Don't call
2025         tui_show_locator_content.
2026         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2027         method.
2028         (struct tui_win_info) <rerender>: Declare.
2029         <set_new_height, make_invisible_and_set_new_height,
2030         make_visible_with_new_height>: Don't declare.
2031         * tui/tui-data.c (tui_win_list::rerender): New method.
2032         * tui/tui-command.h (struct tui_cmd_window)
2033         <do_make_visible_with_new_height>: Don't declare.
2034         * tui/tui-command.c
2035         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2036
2037 2019-08-15  Tom Tromey  <tromey@adacore.com>
2038
2039         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2040         * ada-lang.c (ada_enum_name): Likewise.
2041
2042 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2043
2044         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2045         leading underscore.
2046         (GdbOutputErrorFile): Likewise.
2047         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2048         accordingly.
2049         (execute_unwinders): Rename to have a leading underscore.
2050         (auto_load_packages): Likewise.
2051         (global scope): Adjust call to auto_load_packages accordingly.
2052         (GdbSetPythonDirectory): Likewise.
2053         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2054         instead of execute_unwinders.
2055
2056 2019-08-15  Tom Tromey  <tom@tromey.com>
2057
2058         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2059         (show_data): Don't change window visibility.
2060         (tui_gen_win_info::resize): Remove special case for command
2061         window.  Use wresize, when available.
2062         (show_source_or_disasm_and_command): Don't change window
2063         visibility.
2064         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2065         <make_visible>: New method.
2066         * tui/tui-command.c (tui_cmd_window::resize): New method.
2067
2068 2019-08-15  Tom Tromey  <tom@tromey.com>
2069
2070         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2071         (struct tui_source_windows): New.
2072         * tui/tui-winsource.c (tui_display_main): Update.
2073         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2074         (new_height_ok, parse_scrolling_args): Update.
2075         * tui/tui-layout.c (show_layout, show_data): Update.
2076         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2077         (tui_add_to_source_windows): Don't declare.
2078         * tui/tui-data.c (source_windows, tui_source_windows)
2079         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2080
2081 2019-08-15  Tom Tromey  <tom@tromey.com>
2082
2083         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2084         Rename from reset.
2085         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2086         * tui/tui-layout.c (show_source_disasm_command, show_data):
2087         Update.
2088         (tui_gen_win_info::resize): Rename.
2089         (show_source_or_disasm_and_command): Update.
2090         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2091         reset.
2092
2093 2019-08-15  Tom Tromey  <tom@tromey.com>
2094
2095         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2096         * tui/tui-interp.c (tui_interp::init): Don't call
2097         tui_initialize_static_data.
2098         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2099
2100 2019-08-15  Tom Tromey  <tom@tromey.com>
2101
2102         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2103         examine tui_win_list.
2104
2105 2019-08-15  Tom Tromey  <tom@tromey.com>
2106
2107         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2108         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2109         tui_clear_source_content.
2110         (tui_clear_source_content): Remove.
2111         (tui_source_window_base::do_erase_source_content): Hoist call to
2112         content.clear().
2113         * tui/tui-stack.c (tui_show_frame_info): Don't call
2114         tui_clear_source_content.
2115
2116 2019-08-15  Tom Tromey  <tom@tromey.com>
2117
2118         * tui/tui-winsource.h (struct tui_source_window_base)
2119         <do_erase_source_content>: New method.
2120         <erase_source_content>: New method.
2121         (tui_erase_source_content): Don't declare.
2122         * tui/tui-winsource.c (tui_clear_source_content): Update.
2123         (tui_source_window_base::do_erase_source_content): Rename from
2124         tui_erase_source_content.
2125         (tui_source_window_base::show_source_content): Update.
2126         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2127         * tui/tui-source.h (struct tui_source_window)
2128         <erase_source_content>: New method.
2129         * tui/tui-disasm.h (struct tui_disasm_window)
2130         <erase_source_content>: New method.
2131
2132 2019-08-15  Tom Tromey  <tom@tromey.com>
2133
2134         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2135         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2136         constructor.
2137         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2138         * tui/tui-source.c (tui_set_source_content): Update.
2139         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2140
2141 2019-08-15  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2144         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2145         tui-source.c.
2146         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2147         Declare.
2148         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2149         method.
2150         (tui_source_window::maybe_update): Update.
2151
2152 2019-08-15  Tom Tromey  <tom@tromey.com>
2153
2154         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2155         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2156         tui-disasm.c.
2157         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2158         Declare.
2159         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2160         method.
2161         (tui_disasm_window::maybe_update): Update.
2162
2163 2019-08-15  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-winsource.h (struct tui_source_window_base)
2166         <maybe_update>: Declare.
2167         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2168         method.
2169         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2170         Declare.
2171         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2172         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2173         Declare.
2174         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2175
2176 2019-08-15  Tom Tromey  <tom@tromey.com>
2177
2178         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2179
2180 2019-08-15  Tom Tromey  <tom@tromey.com>
2181
2182         * tui/tui-wingeneral.c: Include tui-stack.h.
2183         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2184         (struct tui_locator_window): Move from tui-data.h.
2185         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2186         (tui_initialize_static_data): Move from tui-data.c.
2187         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2188         (struct tui_locator_window): Move to tui-stack.c.
2189         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2190         (tui_initialize_static_data): Move to tui-stack.c.
2191
2192 2019-08-15  Tom Tromey  <tom@tromey.com>
2193
2194         * tui/tui-layout.c (show_source_disasm_command)
2195         (show_source_or_disasm_and_command): Use make_visible method, not
2196         tui_make_window.
2197         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2198         Remove.
2199
2200 2019-08-15  Tom Tromey  <tom@tromey.com>
2201
2202         * tui/tui-wingeneral.h (tui_make_window): Update.
2203         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2204         parameter.
2205         (tui_gen_win_info::make_visible): Update.
2206         * tui/tui-regs.c (tui_data_window::display_registers_from):
2207         Update.
2208         * tui/tui-layout.c (show_source_disasm_command)
2209         (show_source_or_disasm_and_command): Update.
2210         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2211         (enum tui_box): Remove.
2212         (struct tui_win_info) <can_box>: New method.
2213         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2214         method.
2215
2216 2019-08-15  Tom de Vries  <tdevries@suse.de>
2217
2218         * linux-nat-trad.c: Include gdbarch.h.
2219
2220 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2221
2222         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2223         register sizes.
2224
2225 2019-08-14  Tom Tromey  <tromey@adacore.com>
2226
2227         * darwin-nat.c: Include gdbarch.h.
2228         * darwin-nat-info.c: Include gdbarch.h.
2229
2230 2019-08-13  Tom Tromey  <tom@tromey.com>
2231
2232         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2233         Remove.
2234         * tui/tui-data.c (tui_initialize_static_data): Update.
2235
2236 2019-08-13  Tom Tromey  <tom@tromey.com>
2237
2238         * tui/tui-winsource.h (struct tui_exec_info_window)
2239         <~tui_exec_info_window, maybe_allocate_content, get_content,
2240         m_content>: Remove.
2241         (struct tui_source_window_base) <set_exec_info_content,
2242         show_exec_info_content>: Don't declare.
2243         * tui/tui-winsource.c
2244         (tui_exec_info_window::maybe_allocate_content): Remove.
2245         (tui_source_window_base::update_exec_info): Rename from
2246         set_exec_info_content.
2247         (tui_source_window_base::show_exec_info_content)
2248         (tui_source_window_base::update_exec_info): Remove.
2249
2250 2019-08-13  Tom Tromey  <tom@tromey.com>
2251
2252         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2253         declare.
2254         * tui/tui-winsource.c (tui_update_source_window_as_is)
2255         (tui_update_source_windows_with_addr, tui_erase_source_content):
2256         Update.
2257         (tui_clear_exec_info_content): Remove.
2258
2259 2019-08-13  Tom Tromey  <tom@tromey.com>
2260
2261         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2262         declare.
2263         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2264         call tui_erase_exec_info_content.
2265         (tui_clear_exec_info_content): Rename from
2266         tui_erase_exec_info_content.
2267         (tui_clear_exec_info_content): Delete.
2268
2269 2019-08-13  Tom Tromey  <tom@tromey.com>
2270
2271         * tui/tui-winsource.h (struct tui_source_window_base)
2272         <show_exec_info_content>: Declare.
2273         (tui_show_exec_info_content): Don't declare.
2274         * tui/tui-winsource.c
2275         (tui_source_window_base::show_exec_info_content): Rename from
2276         tui_show_exec_info_content.
2277         (tui_source_window_base::update_exec_info): Update.
2278
2279 2019-08-13  Tom Tromey  <tom@tromey.com>
2280
2281         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2282         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2283         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2284         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2285         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2286         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2287         ... here.
2288
2289 2019-08-13  Tom Tromey  <tom@tromey.com>
2290
2291         * tui/tui-winsource.h (struct tui_source_window_base)
2292         <update_exec_info>: Declare.
2293         (tui_update_exec_info): Don't declare.
2294         * tui/tui-winsource.c (tui_update_source_window_as_is)
2295         (tui_source_window_base::refresh_all)
2296         (tui_update_all_breakpoint_info): Update.
2297         (tui_source_window_base::update_exec_info): Rename from
2298         tui_update_exec_info.
2299         * tui/tui-stack.c (tui_show_frame_info): Update.
2300
2301 2019-08-13  Tom Tromey  <tom@tromey.com>
2302
2303         * tui/tui-winsource.h (struct tui_source_window_base)
2304         <set_exec_info_content>: Declare.
2305         (tui_set_exec_info_content): Don't declare.
2306         * tui/tui-winsource.c
2307         (tui_source_window_base::set_exec_info_content): Rename from
2308         tui_set_exec_info_content.
2309         (tui_update_exec_info): Update.
2310
2311 2019-08-13  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-winsource.h (struct tui_source_window_base)
2314         <show_source_content>: Declare.
2315         (tui_show_source_content): Don't declare.
2316         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2317         (tui_source_window_base::show_source_content): Rename from
2318         tui_show_source_content.
2319         (tui_source_window_base::refresh_all): Update.
2320         * tui/tui-layout.c (show_source_disasm_command)
2321         (show_source_or_disasm_and_command): Update.
2322
2323 2019-08-13  Tom Tromey  <tom@tromey.com>
2324
2325         * tui/tui-winsource.c (tui_erase_source_content)
2326         (tui_show_source_content, tui_source_window_base::refresh_all):
2327         Update.
2328         * tui/tui-wingeneral.h
2329         (tui_check_and_display_highlight_if_needed): Don't declare.
2330         * tui/tui-wingeneral.c
2331         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2332         check_and_display_highlight_if_needed.
2333         * tui/tui-win.c (tui_rehighlight_all)
2334         (tui_win_info::make_visible_with_new_height): Update.
2335         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2336         (tui_data_window::erase_data_content)
2337         (tui_data_window::display_all_data): Update.
2338         * tui/tui-data.h (struct tui_win_info)
2339         <check_and_display_highlight_if_needed>: Declare.
2340
2341 2019-08-13  Tom Tromey  <tom@tromey.com>
2342
2343         * tui/tui-win.c (tui_resize_all): Call
2344         tui_delete_invisible_windows.
2345         * tui/tui-layout.c (show_layout): Call
2346         tui_delete_invisible_windows.
2347         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2348         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2349
2350 2019-08-13  Tom Tromey  <tom@tromey.com>
2351
2352         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2353         tui_add_win_to_layout.
2354
2355 2019-08-13  Tom Tromey  <tom@tromey.com>
2356
2357         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2358         * tui/tui-layout.c (tui_default_win_height): Now static.
2359
2360 2019-08-13  Tom Tromey  <tom@tromey.com>
2361
2362         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2363         single switch.
2364         (show_source_disasm_command, show_source_or_disasm_and_command):
2365         Don't check current layout.
2366
2367 2019-08-13  Tom Tromey  <tom@tromey.com>
2368
2369         * tui/tui-wingeneral.c (make_all_visible): Remove.
2370         (tui_make_all_invisible): Simplify.
2371         * tui/tui-layout.c (tui_make_all_invisible): Move from
2372         tui-wingeneral.c; simplify.
2373         (show_layout): Hoist call to tui_make_all_invisible.
2374         (show_data): Don't call tui_make_all_invisible.
2375
2376 2019-08-13  Tom Tromey  <tom@tromey.com>
2377
2378         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2379         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2380
2381 2019-08-13  Tom Tromey  <tom@tromey.com>
2382
2383         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2384         tui-data.c.
2385         (show_source_disasm_command, show_data)
2386         (show_source_or_disasm_and_command): Don't use
2387         tui_set_current_layout_to.
2388         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2389         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2390         tui-layout.c.
2391         (tui_set_current_layout_to): Remove.
2392
2393 2019-08-13  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-layout.c (tui_set_layout): Update.
2396         * tui/tui-data.h (struct tui_layout_def): Remove.
2397         (tui_layout_def): Don't declare.
2398         * tui/tui-data.c (layout_def): Remove.
2399         (tui_layout_def): Remove.
2400
2401 2019-08-13  Tom Tromey  <tom@tromey.com>
2402
2403         * tui/tui-winsource.h (struct tui_source_window_base)
2404         <clear_detail>: No longer "override".
2405         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2406         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2407         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2408         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2409         Remove.
2410         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2411
2412 2019-08-13  Tom Tromey  <tromey@adacore.com>
2413
2414         * tracepoint.c: Don't include readline.h or history.h.
2415
2416 2019-08-12  Tom Tromey  <tom@tromey.com>
2417
2418         * configure: Rebuild.
2419         * configure.ac: Check for readline 7.
2420         * NEWS: Mention readline 7 requirement.
2421         * README: Update.
2422
2423 2019-08-12  Tom Tromey  <tom@tromey.com>
2424
2425         * mingw-hdep.c (gdb_select): Remove readline hack.
2426
2427 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2428
2429         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2430         when the function fails.
2431
2432 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2433
2434         * s390-tdep.c (s390_type_align): New function.
2435         (s390_gdbarch_init): Set it as type_align gdbarch method.
2436
2437 2019-08-09  Tom de Vries  <tdevries@suse.de>
2438
2439         PR gdb/24591
2440         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2441         pc_low with relocation offset.
2442
2443 2019-08-07  Tom Tromey  <tromey@adacore.com>
2444
2445         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2446         (print_frame_args): Update.
2447         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2448         Update.
2449         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2450         * frame.h (struct frame_arg): Add initializers.
2451         <error>: Now a unique_xmalloc_ptr.
2452
2453 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2454
2455         * NEWS: Expand the Pointer Authentication entry.
2456         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2457         (aarch64_frame_unmask_lr): ... to this.
2458         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2459         Call aarch64_frame_unmask_lr.
2460         * frame.c (struct frame_info): Add "masked" variable.
2461         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2462         (fprint_frame): Check for masked pc.
2463         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2464         declarations.
2465         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2466         * stack.c (print_frame): Check for masked pc.
2467
2468 2019-08-06  Tom Tromey  <tom@tromey.com>
2469
2470         * stabsread.c (patch_block_stabs, read_one_struct_field)
2471         (read_enum_type): Use obstack_strndup.
2472         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2473         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2474         * dwarf2read.c (guess_full_die_structure_name)
2475         (anonymous_struct_prefix): Use obstack_strndup.
2476         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2477         * c-exp.y (yylex): Use obstack_strndup.
2478         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2479         (write_var_or_type): Use obstack_strndup.
2480
2481 2019-08-06  Tom Tromey  <tom@tromey.com>
2482
2483         * symfile.c (reread_symbols): Use obstack_strdup.
2484         * stabsread.c (read_type): Use obstack_strdup.
2485         * gdb_obstack.h (obstack_strdup): New overload.
2486         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2487         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2488         (dwarf2_canonicalize_name): Use obstack_strdup.
2489         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2490         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2491         Use obstack_strdup.
2492
2493 2019-08-06  Tom Tromey  <tom@tromey.com>
2494
2495         * gdb_obstack.h (obstack_strdup): Define.
2496         * gdb_obstack.c (obstack_strdup): Don't define.
2497
2498 2019-08-06  Tom Tromey  <tom@tromey.com>
2499
2500         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2501         obstack_strdup.
2502         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2503         obstack_strdup.
2504         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2505         * stabsread.c (common_block_start): Use obstack_strdup.
2506         * objfiles.c (set_objfile_main_name, objfile): Use
2507         obstack_strdup.
2508         * namespace.c (add_using_directive): Use obstack_strdup.
2509         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2510         * jit.c (finalize_symtab): Use obstack_strdup.
2511         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2512         (guess_partial_die_structure_name, partial_die_info::fixup)
2513         (dwarf2_name): Use obstack_strdup.
2514         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2515         obstack_strdup.
2516         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2517         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2518         obstack_strdup.
2519         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2520
2521 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2522
2523         * unittests/help-doc-selftests.c: New file.
2524         * Makefile.in: Add the new file.
2525
2526 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2527
2528         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2529         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2530         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2531         the trailing '.' is not output, and the first character is uppercased.
2532         (print_help_for_command): Update call to print_doc_line.
2533         (print_doc_of_command): Likewise.
2534         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2535         * cli/cli-option.c (append_indented_doc): Do not append newline.
2536         (build_help_option): Append newline after first appended_indented_doc
2537         only if a second call is done.
2538         (build_help): Append 2 new lines before each option, except the first
2539         one.
2540         * compile/compile.c (_initialize_compile): Add new lines after
2541         %OPTIONS%, when not at the end of the help.
2542         Change help doc or code
2543         producing the help doc to respect the invariants.
2544         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2545         Also removed the new line after 'Options:', as all other commands
2546         do not put an empty line between 'Options:' and the first option.
2547         * printcmd.c (_initialize_printcmd): Likewise.
2548         * stack.c (_initialize_stack): Likewise.
2549         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2550         incorrectly telling COMMAND is optional.
2551         * ada-lang.c (_initialize_ada_language): Change help doc or code
2552         producing the help doc to respect the invariants.
2553         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2554         * breakpoint.c (_initialize_breakpoint): Likewise.
2555         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2556         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2557         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2558         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2559         _initialize_cli_style): Likewise.
2560         * corelow.c (core_target_info): Likewise.
2561         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2562         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2563         * filesystem.c (_initialize_filesystem): Likewise.
2564         * frame.c (_initialize_frame): Likewise.
2565         * gnu-nat.c (add_task_commands): Likewise.
2566         * infcall.c (_initialize_infcall): Likewise.
2567         * infcmd.c (_initialize_infcmd): Likewise.
2568         * interps.c (_initialize_interpreter): Likewise.
2569         * language.c (_initialize_language): Likewise.
2570         * linux-fork.c (_initialize_linux_fork): Likewise.
2571         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2572         * maint.c (_initialize_maint_cmds): Likewise.
2573         * memattr.c (_initialize_mem): Likewise.
2574         * printcmd.c (_initialize_printcmd): Likewise.
2575         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2576         _RegEx): Likewise.
2577         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2578         * record-btrace.c (_initialize_record_btrace): Likewise.
2579         * record-full.c (_initialize_record_full): Likewise.
2580         * record.c (_initialize_record): Likewise.
2581         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2582         * regcache.c (_initialize_regcache): Likewise.
2583         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2584         _initialize_remote): Likewise.
2585         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2586         * serial.c (_initialize_serial): Likewise.
2587         * skip.c (_initialize_step_skip): Likewise.
2588         * source.c (_initialize_source): Likewise.
2589         * stack.c (_initialize_stack): Likewise.
2590         * symfile.c (_initialize_symfile): Likewise.
2591         * symtab.c (_initialize_symtab): Likewise.
2592         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2593         * top.c (init_main): Likewise.
2594         * tracefile-tfile.c (tfile_target_info): Likewise.
2595         * tracepoint.c (_initialize_tracepoint): Likewise.
2596         * tui/tui-win.c (_initialize_tui_win): Likewise.
2597         * utils.c (add_internal_problem_command): Likewise.
2598         * valprint.c (value_print_option_defs): Likewise.
2599
2600 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2601
2602         PR build/24886
2603         * configure.ac: Drop enable-libmcheck support.
2604         * configure, config.in: Rebuild.
2605         * libmcheck.m4: Remove.
2606         * acinclude.m4: Don't include it.
2607         * Makefile.in: Don't distribute it.
2608         * top.c (print_gdb_configuration): Don't mention it.
2609
2610 2019-08-06  Tom Tromey  <tom@tromey.com>
2611
2612         * utils.c (set_output_style): Sometimes pass stream to
2613         emit_style_escape.
2614         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2615         * record-btrace.c (btrace_insn_history): Update.
2616         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2617         method.
2618         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2619         Update initializers.
2620         <m_uiout>: New field.
2621         <m_di>: Move lower.
2622         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2623         Remove "uiout" parameter.
2624         (dump_insns): Update.
2625         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2626         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2627
2628 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2629
2630         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2631         (error_in_psymtab_expansion): Likewise.
2632         (lookup_symbol_via_quick_fns): Likewise.
2633         (basic_lookup_transparent_type_quick): Likewise.
2634         (basic_lookup_transparent_type_1): Likewise.
2635
2636 2019-08-06  Tom Tromey  <tromey@adacore.com>
2637
2638         * source.c (last_source_error): Now bool.
2639         (print_source_lines_base): Make "noprint" bool.  Only open
2640         source file when last_source_visited changes.
2641
2642 2019-08-06  Tom Tromey  <tromey@adacore.com>
2643
2644         * annotate.c (annotate_source_line): Use g_source_cache.
2645         * source-cache.c (source_cache::get_plain_source_lines): Change
2646         parameters.  Populate m_offset_cache.
2647         (source_cache::ensure): New method.
2648         (source_cache::get_line_charpos): New method.
2649         (extract_lines): Move lower.  Change parameters.
2650         (source_cache::get_source_lines): Move lower.
2651         * source-cache.h (class source_cache): Update comment.
2652         <get_line_charpos>: New method.
2653         <get_source_lines>: Update comment.
2654         <clear>: Clear m_offset_cache.
2655         <get_plain_source_lines>: Change parameters.
2656         <ensure>: New method
2657         <m_offset_cache>: New member.
2658         * source.c (forget_cached_source_info_for_objfile): Update.
2659         (info_source_command): Use g_source_cache.
2660         (find_source_lines, open_source_file_with_line_charpos): Remove.
2661         (print_source_lines_base, search_command_helper): Use g_source_cache.
2662         * source.h (open_source_file_with_line_charpos): Don't declare.
2663         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
2664         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
2665         Use g_source_cache.
2666
2667 2019-08-06  Tom Tromey  <tromey@adacore.com>
2668
2669         * source-cache.c (source_cache::get_plain_source_lines):
2670         Remove "first_line" and "last_line" parameters.
2671         (source_cache::get_source_lines): Cache plain text.
2672         * source-cache.h (class source_cache)
2673         <get_plain_source_lines>: Update.
2674
2675 2019-08-06  Tom Tromey  <tromey@adacore.com>
2676
2677         * source-cache.c (extract_lines): No longer a method.
2678         Changed type of parameter.  Include final newline.
2679         (selftests::extract_lines_test): New function.
2680         (_initialize_source_cache): Likewise.
2681         * source-cache.h (class source_cache)
2682         <extract_lines>: Don't declare.
2683
2684 2019-08-06  Tom Tromey  <tromey@adacore.com>
2685
2686         * breakpoint.c (init_breakpoint_sal): Update.
2687         (breakpoint): Update.
2688         * breakpoint.h (struct breakpoint) <filter>: Now a
2689         unique_xmalloc_ptr.
2690
2691 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2692
2693         * NEWS: Mention dictionary access on blocks.
2694         * python/py-block.c (blpy_getitem): New function.
2695         (block_object_as_mapping): New struct.
2696         (block_object_type): Use new struct for tp_as_mapping field.
2697
2698 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
2699
2700         * objfiles.h (objfile): Add a comment describing partial symbols.
2701
2702 2019-08-05  Tom Tromey  <tromey@adacore.com>
2703
2704         * compile/compile.c (_initialize_compile): Use _(), not N_().
2705         * thread.c (_initialize_thread): Use _(), not N_().
2706         * stack.c (_initialize_stack): Use _(), not N_().
2707         * printcmd.c (_initialize_printcmd): Use _(), not N_().
2708
2709 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
2710
2711         * dwarf2read.c (struct dw2_symtab_iterator):
2712         <want_specific_block>: Remove.
2713         <block_index>: Change type to gdb::optional.
2714         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
2715         change type of BLOCK_INDEX parameter to gdb::optional.
2716         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
2717         (dw2_lookup_symbol): Don't pass argument for
2718         WANT_SPECIFIC_BLOCK.
2719         (dw2_expand_symtabs_for_function): Don't pass argument for
2720         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
2721         (class dw2_debug_names_iterator)
2722         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
2723         parameter, change BLOCK_INDEX type to gdb::optional.
2724         <m_want_specific_block>: Remove.
2725         <m_block_index>: Change type to gdb::optional.
2726         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
2727         gdb::optional.  Re-write in function of gdb::optional.
2728         (dw2_debug_names_lookup_symbol): Don't pass argument for
2729         WANT_SPECIFIC_BLOCK.
2730         (dw2_debug_names_expand_symtabs_for_function): Don't pass
2731         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
2732         BLOCK_INDEX.
2733
2734 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2735
2736         * NEWS: Mention changes to "info sources" command.
2737
2738 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2739
2740         * symtab.c (filename_partial_match_opts): New struct type.
2741         (struct output_source_filename_data): New members
2742         regexp, c_regexp, partial_match.
2743         (output_source_filename): Use new members to decide to print file.
2744         (info_sources_option_defs): New variable.
2745         (make_info_sources_options_def_group, print_info_sources_header,
2746         info_sources_command_completer):
2747         New functions.
2748         (info_sources_command): Read new optional arguments.
2749         (_initialize_symtab): Update info sources help.
2750
2751 2019-08-02  Alexandre Oliva <oliva@adacore.com>
2752
2753         * ada-lang.c (exception_support_info_v0): Renamed from...
2754         (default_exception_support_info): ... this.  Create new
2755         definition for v1.
2756         (ada_has_this_exception_support): Look up catch_handlers_sym.
2757         (ada_exception_support_info_sniffer): Try v0 after default.
2758
2759 2019-08-01  Tom Tromey  <tromey@adacore.com>
2760
2761         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
2762         gdbarch.h.
2763
2764 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
2765
2766         * s12z-tdep.c: Fix include path for s12z-opc.h.
2767
2768 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
2769
2770         * NEWS: Require GNU make 3.82.
2771
2772 2019-07-16  Tom Tromey  <tom@tromey.com>
2773
2774         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
2775         declare.
2776
2777 2019-07-30  Tom Tromey  <tromey@adacore.com>
2778
2779         * block.c (contained_in): Remove BLOCK_FUNCTION check.
2780
2781 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
2782
2783         * printcmd.c (print_address_symbolic): Print negative offsets.
2784         (build_address_symbolic): Force signed arithmetic when computing
2785         offset.
2786
2787 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
2788
2789         PR/24474: Add a function to lookup static variables.
2790         * NEWS: Mention this new function.
2791         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
2792         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
2793         * python/python.c (python_GdbMethods): Add new function.
2794
2795 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
2796
2797         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
2798         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
2799         (objfpy_lookup_static_symbol): New function.
2800         (objfile_object_methods): Add new functions.
2801
2802 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2803
2804         * NEWS: Mention 'set|show print frame-info'.  Mention new
2805         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
2806         backtrace argument.  Mention that python frame filtering code
2807         is now consistent with what 'backtrace' command prints.
2808
2809 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2810
2811         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
2812         comments.
2813         (print_frame_info_auto, print_frame_info_source_line,
2814         print_frame_info_location, print_frame_info_source_and_location,
2815         print_frame_info_location_and_address, print_frame_info_short_location):
2816         New declarations.
2817         (struct frame_print_options): New member print_frame_info.
2818         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
2819         * stack.h (get_user_print_what_frame_info): New declaration.
2820         (frame_show_address): New declaration.
2821         * stack.c (print_frame_arguments_choices): New value 'presence'.
2822         (print_frame_info_auto, print_frame_info_source_line,
2823         print_frame_info_location, print_frame_info_source_and_location,
2824         print_frame_info_location_and_address, print_frame_info_short_location,
2825         print_frame_info_choices, print_frame_info_print_what): New definitions.
2826         (print_frame_args): Only print dots for args if print frame-arguments
2827         is 'presence'.
2828         (frame_print_option_defs): New element for "frame-info".
2829         (get_user_print_what_frame_info): New function.
2830         (frame_show_address): Make non static.  Move comment to stack.h.
2831         (print_frame_info_to_print_what): New function.
2832         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
2833         to decide what to print.
2834         (backtrace_command_1): Handle the new print_frame_arguments_presence
2835         value.
2836         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
2837         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
2838         (py_print_frame): In non-mi mode, use LOCATION as default for
2839         print_what, similarly to frame information printed directly by
2840         backtrace command. Handle frame-info user option in non MI mode.
2841
2842 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2843
2844         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
2845         Add case for debugging 32-bit target on 64-bit host.  Revise
2846         comment.
2847
2848 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2849
2850         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
2851         instead of find_function_entry_range_from_pc.
2852
2853 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
2854
2855         * stack.c (find_frame_funname): Remove code which preferred
2856         minsym over symtab sym in "certain pathological cases".
2857
2858         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
2859         parameter.  Change type of "do_demangle" to bool.
2860         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2861         Pass suitable "prefer_sym_over_minsym" flag to
2862         build_address_symbolic().  Don't output "+" for negative offsets.
2863         * printcmd.c (print_address_symbolic): Update invocation of
2864         build_address_symbolic to include a "prefer_sym_over_minsym"
2865         flag.
2866         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
2867         Restrict cases in which use of minimal symbol is preferred to that
2868         of a found symbol.  Update comments.
2869
2870         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
2871         for entry pc when entry pc is out of range for that FDE.
2872
2873 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
2874
2875         PR gdb/24839:
2876         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
2877         type.
2878
2879 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
2880
2881         * python/py-objfile.c (add_separate_debug_file): Fix comment about
2882         this function's Python signature.
2883
2884
2885 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
2886
2887         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
2888         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2889         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
2890         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
2891         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
2892
2893
2894 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
2895
2896         * h8300-tdep.c (h8300_register_name_common): New.
2897         h8300_register_name): Use h8300_register_name_common.
2898         (h8300s_register_name): Likewise.
2899         (h8300sx_register_name): Likewise.
2900         (h8300h_register_nam): New.
2901         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
2902
2903
2904 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
2905
2906         * arm-tdep.c (arm_skip_cmse_entry): New function.
2907         (arm_is_sgstubs_section): New function.
2908         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
2909
2910 2019-07-22  Tom Tromey  <tom@tromey.com>
2911
2912         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
2913         Don't self-assign.
2914
2915 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2916
2917         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
2918         type_print.
2919
2920 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2921
2922         * symtab.c (search_symbols): Adjust msymbol matching type arrays
2923         so that GDB doesn't match any msymbols when searching in the
2924         TYPES_DOMAIN.
2925         (print_symbol_info): Print using typedef_print or type_print based
2926         on the type of the symbol.  Add updated FIXME comment moved from...
2927         (_initialize_symtab): ... move and update FIXME comment to above.
2928
2929 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2930
2931         * NEWS: Mention adding -q option to "info types".
2932         * symtab.c (struct info_types_options): New struct.
2933         (info_types_options_defs): New variable.
2934         (make_info_types_options_def_group): New function.
2935         (info_types_command): Use gdb::option framework to parse options.
2936         (info_types_command_completer): New function.
2937         (_initialize_symtab): Extend the help text on "info types" and
2938         register command completer.
2939
2940 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
2941
2942         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
2943         (lookup_symbol_in_objfile): Change int to block_enum and add a
2944         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
2945
2946 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
2947
2948         * MAINTAINERS (Write After Approval): Add self.
2949
2950 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2951
2952         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
2953         instruction to the dummy code region.
2954
2955 2019-07-19  Tom Tromey  <tromey@adacore.com>
2956
2957         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
2958         (ARGSUSED, PARAMS, __func__): Remove rules.
2959
2960 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2961
2962         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
2963         * features/arm/arm-with-iwmmxt.c: Remove.
2964         * features/arm/arm-with-iwmmxt.xml: Remove.
2965         * features/arm/arm-with-m-fpa-layout.c: Remove.
2966         * features/arm/arm-with-m-fpa-layout.xml: Remove.
2967         * features/arm/arm-with-m-vfp-d16.c: Remove.
2968         * features/arm/arm-with-m-vfp-d16.xml: Remove.
2969         * features/arm/arm-with-m.c: Remove.
2970         * features/arm/arm-with-m.xml: Remove.
2971         * features/arm/arm-with-neon.c: Remove.
2972         * features/arm/arm-with-neon.xml: Remove.
2973         * features/arm/arm-with-vfpv2.c: Remove.
2974         * features/arm/arm-with-vfpv2.xml: Remove.
2975         * features/arm/arm-with-vfpv3.c: Remove.
2976         * features/arm/arm-with-vfpv3.xml: Remove.
2977
2978 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2979
2980         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
2981
2982 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2983
2984         * arch/aarch32.c (aarch32_create_target_description): Create
2985         target descriptions using features.
2986         * arch/arm.c (arm_create_target_description)
2987         (arm_create_mprofile_target_description): Likewise.
2988         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
2989
2990 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
2991
2992         * Makefile.in: Add new files.
2993         * aarch32-tdep.c: New file.
2994         * aarch32-tdep.h: New file.
2995         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
2996         Call aarch32_read_description.
2997         * arch/aarch32.c: New file.
2998         * arch/aarch32.h: New file.
2999         * arch/arm.c (arm_create_target_description)
3000         (arm_create_mprofile_target_description): New function.
3001         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3002         (arm_create_target_description)
3003         (arm_create_mprofile_target_description): New declaration.
3004         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3005         read_description functions.
3006         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3007         Likewise.
3008         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3009         * arm-tdep.c (tdesc_arm_list): New variable.
3010         (arm_register_g_packet_guesses): Call create description functions.
3011         (arm_read_description) (arm_read_mprofile_description): New
3012         function.
3013         * arm-tdep.h (arm_read_description)
3014         (arm_read_mprofile_description): Add declaration.
3015         * configure.tgt: Add new files.
3016
3017 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3018
3019         * top.c (new_ui_command): Open specified terminal just once.
3020
3021 2019-07-18  Tom Tromey  <tromey@adacore.com>
3022
3023         * symtab.c (main_name): Constify return type.
3024         * symfile.c (set_initial_language): Update.
3025         * symtab.h (main_name): Constify return type.
3026
3027 2019-07-17  Tom Tromey  <tom@tromey.com>
3028
3029         * tui/tui-winsource.c (tui_update_source_window)
3030         (tui_update_source_window_as_is)
3031         (tui_update_source_windows_with_line): Remove return.
3032         * tui/tui-disasm.c (tui_show_disassem)
3033         (tui_show_disassem_and_update_source): Remove return.
3034         * tui/tui.c (tui_reset): Remove return.
3035         * tui/tui-wingeneral.c
3036         (tui_check_and_display_highlight_if_needed): Remove return.
3037
3038 2019-07-17  Tom Tromey  <tom@tromey.com>
3039
3040         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3041
3042 2019-07-17  Tom Tromey  <tom@tromey.com>
3043
3044         * tui/tui-winsource.h (struct tui_exec_info_window)
3045         (struct tui_source_window_base): Move from tui-data.h.
3046         * tui/tui-winsource.c: Move many method definitions from
3047         elsewhere.  Remove "structuring" comments.
3048         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3049         (tui_source_window_base::refresh_window): Move to
3050         tui-winsource.c.
3051         * tui/tui-win.c (tui_source_window_base::refresh_all)
3052         (tui_source_window_base::update_tab_width)
3053         (tui_source_window_base::set_new_height)
3054         (tui_source_window_base::do_make_visible_with_new_height): Move to
3055         tui-winsource.c.
3056         * tui/tui-source.h: Update.
3057         * tui/tui-source.c (tui_source_window_base::reset): Move to
3058         tui-winsource.c.
3059         * tui/tui-disasm.h: Update.
3060         * tui/tui-data.h (struct tui_exec_info_window): Move to
3061         tui-winsource.h.
3062         (struct tui_source_window_base): Likewise.
3063         * tui/tui-data.c (tui_source_window_base::clear_detail)
3064         (tui_source_window_base, ~tui_source_window_base): Move to
3065         tui-winsource.c.
3066
3067 2019-07-17  Tom Tromey  <tom@tromey.com>
3068
3069         * tui/tui-win.c (tui_resize_all)
3070         (tui_source_window_base::update_tab_width)
3071         (tui_adjust_win_heights): Update.
3072         (tui_win_info::make_invisible_and_set_new_height): Rename from
3073         make_invisible_and_set_new_height.
3074         * tui/tui-data.h (struct tui_win_info)
3075         <make_invisible_and_set_new_height>: New method.
3076
3077 2019-07-17  Tom Tromey  <tom@tromey.com>
3078
3079         * tui/tui.c: Update.
3080         * tui/tui-source.h (struct tui_source_window): Move from
3081         tui-data.h.
3082         * tui/tui-layout.c: Update.
3083         * tui/tui-disasm.c: Update.
3084         * tui/tui-data.h (struct tui_source_window): Move to
3085         tui-source.h.
3086
3087 2019-07-17  Tom Tromey  <tom@tromey.com>
3088
3089         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3090         tui-data.h.
3091         * tui/tui-data.h (struct tui_disasm_window): Move to
3092         tui-disasm.h.
3093
3094 2019-07-17  Tom Tromey  <tom@tromey.com>
3095
3096         * tui/tui-regs.h (struct tui_data_item_window): Move from
3097         tui-data.h.
3098         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3099         * tui/tui-data.h (struct tui_data_item_window): Move to
3100         tui-regs.h.
3101         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3102
3103 2019-07-17  Tom Tromey  <tom@tromey.com>
3104
3105         * tui/tui.c: Update.
3106         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3107         (tui_cmd_window::max_height): Move to tui-command.c.
3108         * tui/tui-layout.c: Update.
3109         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3110         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3111         tui-command.c.
3112         * tui/tui-command.h (struct tui_cmd_window): Move from
3113         tui-data.h.
3114         * tui/tui-command.c: Remove "structuring" comments.
3115         (tui_cmd_window::clear_detail)
3116         (tui_cmd_window::do_make_visible_with_new_height)
3117         (tui_cmd_window::max_height): Move from elsewhere.
3118
3119 2019-07-17  Tom Tromey  <tom@tromey.com>
3120
3121         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3122         Now static.
3123         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3124         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3125
3126 2019-07-17  Tom Tromey  <tom@tromey.com>
3127
3128         * tui/tui.c: Update.
3129         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3130         tui-regs.c.
3131         * tui/tui-windata.h: Remove file.
3132         * tui/tui-windata.c: Remove file.
3133         * tui/tui-win.c (tui_data_window::set_new_height)
3134         (tui_data_window::do_make_visible_with_new_height): Move to
3135         tui-regs.c.
3136         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3137         * tui/tui-regs.c: Remove "structuring" comments.
3138         (tui_data_window::first_data_item_displayed)
3139         (tui_data_window::delete_data_content_windows)
3140         (tui_data_window::erase_data_content)
3141         (tui_data_window::display_all_data)
3142         (tui_data_window::refresh_all)
3143         (tui_data_window::do_scroll_vertical)
3144         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3145         (tui_data_window::do_make_visible_with_new_height)
3146         (tui_data_window::refresh_window): Move from elsewhere.
3147         (_initialize_tui_regs): Move to end of file.
3148         * tui/tui-layout.c: Update.
3149         * tui/tui-hooks.c: Update.
3150         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3151         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3152         tui-regs.c.
3153         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3154
3155 2019-07-17  Tom Tromey  <tom@tromey.com>
3156
3157         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3158         seen.
3159
3160 2019-07-17  Tom Tromey  <tom@tromey.com>
3161
3162         * tui/tui-win.c (tui_source_window_base::set_new_height)
3163         (tui_source_window_base::do_make_visible_with_new_height): Use
3164         m_has_locator field directly.
3165         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3166         method.
3167         (struct tui_source_window_base) <has_locator>: Likewise.
3168
3169 2019-07-17  Tom Tromey  <tom@tromey.com>
3170
3171         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3172         Don't declare.
3173         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3174         Remove.
3175         * tui/tui-win.c (tui_source_window_base::set_new_height)
3176         (tui_source_window_base::set_new_height)
3177         (make_invisible_and_set_new_height)
3178         (tui_source_window_base::do_make_visible_with_new_height)
3179         (tui_source_window_base::do_make_visible_with_new_height):
3180         Update.
3181         * tui/tui-layout.c (show_source_disasm_command, show_data)
3182         (show_source_or_disasm_and_command): Update.
3183         * tui/tui-layout.c (show_layout): Update.
3184
3185 2019-07-17  Tom Tromey  <tom@tromey.com>
3186
3187         * tui/tui-layout.c (make_data_window): Remove.
3188         (show_data): Unify creation and re-initialization cases.
3189
3190 2019-07-17  Tom Tromey  <tom@tromey.com>
3191
3192         * tui/tui-layout.c (make_source_window, make_disasm_window):
3193         Remove.
3194         (show_data): Unify creation and re-initialization cases.
3195
3196 2019-07-17  Tom Tromey  <tom@tromey.com>
3197
3198         * tui/tui-layout.c (make_command_window): Remove.
3199         (show_source_disasm_command, show_source_or_disasm_and_command):
3200         Unify creation and re-initialization cases.
3201
3202 2019-07-17  Tom Tromey  <tom@tromey.com>
3203
3204         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3205         creation and re-initialization cases.
3206
3207 2019-07-17  Tom Tromey  <tom@tromey.com>
3208
3209         * tui/tui-regs.c (tui_get_register): Return void.
3210
3211 2019-07-17  Tom Tromey  <tom@tromey.com>
3212
3213         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3214         Simplify.
3215
3216 2019-07-17  Tom Tromey  <tom@tromey.com>
3217
3218         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3219         resetting.
3220
3221 2019-07-17  Tom Tromey  <tom@tromey.com>
3222
3223         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3224         * tui/tui-regs.c (tui_reg_layout): New function.
3225         (tui_show_registers, tui_reg_command): Use it.
3226         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3227         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3228         parameters.
3229         (tui_layout_command): Remove.
3230
3231 2019-07-17  Tom Tromey  <tom@tromey.com>
3232
3233         * tui/tui-layout.h (tui/tui-layout): Return void.
3234         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3235
3236 2019-07-17  Tom Tromey  <tom@tromey.com>
3237
3238         * tui/tui-layout.c (show_source_disasm_command, show_data):
3239         Update.
3240         (reset_locator): Remove.
3241         (show_source_or_disasm_and_command): Update.
3242
3243 2019-07-17  Tom Tromey  <tom@tromey.com>
3244
3245         * tui/tui-source.c (tui_source_window_base::reset): Remove
3246         win_type parameter.
3247         * tui/tui-layout.c (make_command_window, make_source_window)
3248         (make_disasm_window, make_data_window)
3249         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3250         (reset_locator, show_source_or_disasm_and_command): Update.
3251         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3252         win_type parameter.
3253         (struct tui_source_window_base) <reset>: Likewise.
3254
3255 2019-07-17  Tom Tromey  <tom@tromey.com>
3256
3257         * tui/tui-layout.c (show_source_disasm_command): Use
3258         reset_locator.
3259         (reset_locator): New function.
3260         (init_and_make_win): Remove.
3261         (show_source_or_disasm_and_command): Use reset_locator.
3262
3263 2019-07-17  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3266         condition.
3267         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3268         Remove condition.
3269         * tui/tui-source.c (tui_source_window_base::reset): New method.
3270         * tui/tui-layout.c (make_command_window): Don't call
3271         init_and_make_win.
3272         (make_source_window, make_disasm_window): Don't call
3273         make_source_or_disasm_window.
3274         (make_data_window): Don't call init_and_make_win.  Change calling
3275         convention.
3276         (show_source_disasm_command, show_data): Simplify.
3277         (make_source_or_disasm_window): Remove.
3278         (show_source_or_disasm_and_command): Simplify.
3279         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3280         (struct tui_source_window_base) <reset>: Likewise.
3281         <execution_info>: Remove initializer.
3282         * tui/tui-data.c (tui_source_window_base): Initialize
3283         execution_info.
3284
3285 2019-07-17  Tom Tromey  <tom@tromey.com>
3286
3287         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3288         variable.
3289
3290 2019-07-17  Tom Tromey  <tom@tromey.com>
3291
3292         * tui/tui.c (tui_rl_other_window): Update.
3293         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3294         superclass method first.  Always iterate over regs_content.
3295         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3296         method.
3297         * tui/tui-win.c (tui_set_focus_command): Update.
3298
3299 2019-07-17  Tom Tromey  <tom@tromey.com>
3300
3301         * tui/tui-win.c (tui_set_focus_command): Rename from
3302         tui_set_focus.  Call tui_enable.
3303         (tui_set_focus_command): Remove.
3304
3305 2019-07-17  Tom Tromey  <tom@tromey.com>
3306
3307         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3308         refresh_window.
3309         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3310         touchwin.
3311         (tui_data_window::refresh_window): Call refresh_window on data
3312         items.  Always call superclass refresh_window.
3313         (tui_win_info::refresh): Remove.
3314         (tui_source_window_base::refresh_window): Update.
3315         (tui_refresh_all): Update.
3316         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3317         refresh_window.
3318         (show_source_or_disasm_and_command): Likewise.
3319         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3320         (struct tui_source_window_base) <refresh>: Likewise.
3321
3322 2019-07-17  Tom Tromey  <tom@tromey.com>
3323
3324         * tui/tui-winsource.c (tui_clear_source_content)
3325         (tui_show_source_content): Update.
3326         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3327         whether content is empty.
3328         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3329         Remove.
3330
3331 2019-07-17  Tom Tromey  <tom@tromey.com>
3332
3333         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3334         window's contents.
3335         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3336         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3337
3338 2019-07-17  Tom Tromey  <tom@tromey.com>
3339
3340         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3341         (struct tui_data_item_window): Update.
3342
3343 2019-07-17  Tom Tromey  <tom@tromey.com>
3344
3345         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3346         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3347         defines.
3348
3349 2019-07-17  Tom Tromey  <tom@tromey.com>
3350
3351         * tui/tui-winsource.h (tui_erase_source_content)
3352         (tui_clear_source_content): Remove "display_prompt" parameter.
3353         * tui/tui-winsource.c (tui_update_source_window_as_is)
3354         (tui_update_source_windows_with_addr): Update.
3355         (tui_clear_source_content): Remove "display_prompt" parameter.
3356         (tui_erase_source_content): Likewise.  Simplify.
3357         (tui_show_source_content): Update.
3358         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3359         * tui/tui-stack.c (tui_show_frame_info): Update.
3360         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3361         Remove defines.
3362
3363 2019-07-17  Tom Tromey  <tom@tromey.com>
3364
3365         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3366         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3367         parameter.
3368         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3369         parameter.
3370
3371 2019-07-17  Tom Tromey  <tom@tromey.com>
3372
3373         * tui/tui-winsource.c (tui_clear_source_content)
3374         (tui_show_source_content, tui_show_exec_info_content)
3375         (tui_clear_exec_info_content): Update.
3376         * tui/tui-stack.c (tui_show_locator_content): Update.
3377         (tui_show_frame_info): Update.
3378         * tui/tui-source.h (tui_source_window): Don't declare.
3379         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3380         from tui_source_is_displayed.
3381         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3382         Remove field.
3383         (struct tui_source_window_base) <content_in_use>: New field.  Now
3384         bool.
3385         (struct tui_source_window) <showing_source_p>: New method.
3386         (TUI_SRC_WIN): Change cast.
3387         * tui/tui-data.c (tui_initialize_static_data): Update.
3388
3389 2019-07-17  Tom Tromey  <tom@tromey.com>
3390
3391         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3392         location_matches_p.
3393         * tui/tui-source.c (tui_source_window::location_matches_p): New
3394         method.
3395         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3396         method.
3397         * tui/tui-data.h (struct tui_source_window_base)
3398         <location_matches_p>: New method.
3399         (struct tui_source_window, struct tui_disasm_window)
3400         <location_matches_p>: Likewise.
3401
3402 2019-07-17  Tom Tromey  <tom@tromey.com>
3403
3404         * tui/tui-win.c (tui_set_win_height_command): Rename from
3405         tui_set_win_height.
3406         (tui_set_win_height_command): Remove.
3407
3408 2019-07-17  Tom Tromey  <tom@tromey.com>
3409
3410         * tui/tui-source.c (tui_source_window): New constructor.  Add
3411         observer.
3412         (~tui_source_window): New destructor.
3413         (tui_source_window::style_changed): New method.
3414         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3415         (tui_attach_detach_observers): Update.
3416         * tui/tui-data.h (struct tui_source_window): Make constructor not
3417         inline.  Add destructor.
3418         (struct tui_source_window) <style_changed>: New method.
3419         <m_observable>: New member.
3420
3421 2019-07-17  Tom Tromey  <tom@tromey.com>
3422
3423         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3424         * tui/tui-win.c (tui_resize_all): Fix typo.
3425
3426 2019-07-17  Tom Tromey  <tom@tromey.com>
3427
3428         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3429         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3430         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3431         * tui/tui-win.c (window_name_completer): Use foreach.
3432         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3433         (update_tab_width): Likewise.
3434         * tui/tui-layout.c (show_layout): Update.
3435         * tui/tui-data.h (class tui_window_iterator): New.
3436         (struct all_tui_windows): New.
3437         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3438
3439 2019-07-17  Tom Tromey  <tom@tromey.com>
3440
3441         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3442         parameter.  Don't reference globals.
3443         (tui_reg_command): Update.
3444
3445 2019-07-17  Tom Tromey  <tom@tromey.com>
3446
3447         * tui/tui-regs.c (tui_show_registers): Simplify.
3448
3449 2019-07-17  Tom Tromey  <tom@tromey.com>
3450
3451         * tui/tui-regs.c (tui_show_registers): Update.
3452         (tui_show_register_group): Add win_info parameter.
3453
3454 2019-07-17  Tom Tromey  <tom@tromey.com>
3455
3456         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3457         Rename from tui_display_reg_element_at_line.
3458         (tui_data_window::display_registers_from_line): Update.
3459         * tui/tui-data.h (struct tui_data_window)
3460         <display_reg_element_at_line>: New method.
3461
3462 2019-07-17  Tom Tromey  <tom@tromey.com>
3463
3464         * tui/tui-regs.h (tui_display_registers_from)
3465         (tui_display_registers_from_line): Don't declare.
3466         * tui/tui-windata.c (tui_data_window::display_all_data)
3467         (tui_data_window::refresh_all)
3468         (tui_data_window::do_scroll_vertical): Update.
3469         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3470         from tui_display_registers_from.
3471         (tui_display_reg_element_at_line): Update.
3472         (tui_data_window::display_registers_from_line): Rename from
3473         tui_display_registers_from_line.
3474         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3475         display_registers_from_line>: New methods.
3476
3477 2019-07-17  Tom Tromey  <tom@tromey.com>
3478
3479         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3480         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3481         from tui_erase_data_content.
3482         (tui_data_window::display_all_data)
3483         (tui_data_window::refresh_all)
3484         (tui_data_window::do_scroll_vertical): Update.
3485         * tui/tui-regs.c (tui_show_registers): Update.
3486         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3487         New method.
3488
3489 2019-07-17  Tom Tromey  <tom@tromey.com>
3490
3491         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3492         declare.
3493         * tui/tui-windata.c
3494         (tui_data_window::delete_data_content_windows): Rename from
3495         tui_delete_data_content_windows.
3496         (tui_data_window::display_all_data)
3497         (tui_data_window::do_scroll_vertical): Update.
3498         * tui/tui-data.h (struct tui_data_window)
3499         <delete_data_content_windows>: New method.
3500
3501 2019-07-17  Tom Tromey  <tom@tromey.com>
3502
3503         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3504         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3505
3506 2019-07-17  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3509         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3510         from tui_display_all_data.
3511         * tui/tui-win.c
3512         (tui_data_window::do_make_visible_with_new_height): Update.
3513         * tui/tui-regs.c (tui_show_registers): Update.
3514         * tui/tui-layout.c (tui_set_layout): Update.
3515         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3516         method.
3517
3518 2019-07-17  Tom Tromey  <tom@tromey.com>
3519
3520         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3521         * tui/tui-windata.c (tui_display_data_from): Remove.
3522         (tui_data_window::refresh_all): Update.
3523
3524 2019-07-17  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3527         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3528         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3529         tui_display_registers_from_line.
3530         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3531         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3532         "force_display" parameter.
3533
3534 2019-07-17  Tom Tromey  <tom@tromey.com>
3535
3536         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3537         declare.
3538         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3539         Rename from tui_first_reg_element_no_inline.
3540         (tui_display_reg_element_at_line)
3541         (tui_display_registers_from_line): Update.
3542         * tui/tui-data.h (struct tui_data_window)
3543         <first_reg_element_no_inline>: New method.
3544
3545 2019-07-17  Tom Tromey  <tom@tromey.com>
3546
3547         * tui/tui-windata.c (tui_display_data_from)
3548         (tui_data_window::do_scroll_vertical): Update.
3549         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3550         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3551         Rename from tui_line_from_reg_element_no.
3552         (tui_display_registers_from_line): Update.
3553         * tui/tui-data.h (struct tui_data_window)
3554         <line_from_reg_element_no>: New method.
3555
3556 2019-07-17  Tom Tromey  <tom@tromey.com>
3557
3558         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3559         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3560         tui_last_regs_line_no.
3561         (tui_display_reg_element_at_line)
3562         (tui_display_registers_from_line): Update.
3563         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3564         method.
3565
3566 2019-07-17  Tom Tromey  <tom@tromey.com>
3567
3568         PR tui/24722:
3569         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3570         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3571         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3572         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3573         (tui_update_breakpoint_info): Likewise.
3574         * tui/tui-hooks.c (tui_event_create_breakpoint)
3575         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3576         Update.
3577
3578 2019-07-17  Tom Tromey  <tom@tromey.com>
3579
3580         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3581
3582 2019-07-17  Tom Tromey  <tom@tromey.com>
3583
3584         * tui/tui-winsource.c (tui_update_source_window_as_is)
3585         (tui_update_source_windows_with_addr): Update.
3586         * tui/tui-source.h (tui_set_source_content)
3587         (tui_show_symtab_source): Add "win_info" parameter.
3588         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3589         parameter.
3590         (tui_show_symtab_source): Likewise.
3591
3592 2019-07-17  Tom Tromey  <tom@tromey.com>
3593
3594         * tui/tui-wingeneral.c
3595         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3596
3597 2019-07-17  Tom Tromey  <tom@tromey.com>
3598
3599         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3600         (struct tui_cmd_window) <can_scroll>: New method.
3601         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3602         method.
3603
3604 2019-07-17  Tom Tromey  <tromey@adacore.com>
3605
3606         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3607         do_field_signed>: Rename.  Change type of "value".
3608         * ui-out.c (ui_out::field_signed): Rename from field_int.
3609         Change type of "value".
3610         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3611         type of "value".
3612         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3613         do_field_int.  Change type of "value".
3614         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3615         do_field_int.  Change type of "value".
3616         * tracepoint.c (trace_status_mi, tfind_1)
3617         (print_one_static_tracepoint_marker): Update.
3618         * thread.c (print_thread_info_1, print_selected_thread_frame):
3619         Update.
3620         * stack.c (print_frame, print_frame_info): Update.
3621         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3622         Update.
3623         * source.c (print_source_lines_base): Update.
3624         * skip.c (info_skip_command): Update.
3625         * record-btrace.c (btrace_ui_out_decode_error)
3626         (btrace_call_history_src_line): Update.
3627         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3628         Update.
3629         * progspace.c (print_program_space): Update.
3630         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3631         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3632         do_field_int.  Change type of "value".
3633         * mi/mi-out.c (mi_ui_out::do_table_begin)
3634         (mi_ui_out::do_table_header): Update.
3635         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3636         type of "value".
3637         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3638         (mi_cmd_data_list_changed_registers, output_register)
3639         (mi_cmd_data_read_memory, mi_load_progress)
3640         (mi_cmd_trace_frame_collected): Update.
3641         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3642         Update.
3643         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3644         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3645         (mi_cmd_var_list_children, varobj_update_one): Update.
3646         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
3647         (mi_cmd_stack_list_args, list_arg_or_local): Update.
3648         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
3649         * inferior.c (print_inferior): Update.
3650         * gdb_bfd.c (print_one_bfd): Update.
3651         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3652         Update.
3653         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
3654         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
3655         do_field_int.  Change type of "value".
3656         * cli-out.c (cli_ui_out::do_field_signed): Rename from
3657         do_field_int.  Change type of "value".
3658         * breakpoint.c (watchpoint_check, print_breakpoint_location)
3659         (print_one_breakpoint_location, print_it_catch_fork)
3660         (print_one_catch_fork, print_it_catch_vfork)
3661         (print_one_catch_vfork, print_it_catch_solib)
3662         (print_it_catch_exec, print_it_ranged_breakpoint)
3663         (print_mention_watchpoint, print_mention_masked_watchpoint)
3664         (bkpt_print_it, update_static_tracepoint): Update.
3665         * break-catch-throw.c (print_it_exception_catchpoint): Update.
3666         * break-catch-syscall.c (print_it_catch_syscall): Update.
3667         * ada-tasks.c (print_ada_task_info): Update.
3668         * ada-lang.c (print_it_exception, print_mention_exception):
3669         Update.
3670
3671 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
3672
3673         PR breakpoints/24541
3674         * gdbarch.c: Regenerate.
3675         * gdbarch.h: Regenerate.
3676         * gdbarch.sh: Adjust return type and parameter types for
3677         'stap_adjust_register'.
3678         (i386_stap_adjust_register): Adjust signature and return new
3679         register name.
3680         * stap-probe.c (stap_parse_register_operand): Adjust use of
3681         'gdbarch_stap_adjust_register'.
3682
3683 2019-07-17  Tom Tromey  <tromey@adacore.com>
3684
3685         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
3686         declare VEC.
3687         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
3688         std::vector.
3689         (struct s390_process_info): Add initializers.
3690         (s390_add_process): Use new.
3691         (s390_linux_nat_target::low_forget_process): Use delete.
3692         (s390_linux_nat_target::low_new_fork)
3693         (s390_linux_nat_target::stopped_by_watchpoint)
3694         (s390_linux_nat_target::low_prepare_to_resume)
3695         (s390_linux_nat_target::insert_watchpoint)
3696         (s390_linux_nat_target::insert_hw_breakpoint)
3697         (s390_linux_nat_target::remove_watchpoint)
3698         (s390_linux_nat_target::remove_hw_breakpoint): Update.
3699
3700 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3701
3702         * aarch64-fbsd-nat.c: Include regcache.h.
3703         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
3704         argument.
3705         (aarch64_fbsd_nat_target::fetch_registers)
3706         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
3707         variable.
3708         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
3709
3710 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
3711
3712         * fbsd-nat.c: Include gdbarch.h.
3713
3714 2019-07-15  Tom Tromey  <tromey@adacore.com>
3715
3716         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
3717
3718 2019-07-15  Tom Tromey  <tromey@adacore.com>
3719
3720         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
3721         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
3722         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
3723         * cli-out.c (cli_ui_out::do_field_int): New method.
3724         * ui-out.c (ui_out::field_unsigned): New method.
3725         * symfile.c (generic_load): Use field_unsigned.
3726         (print_transfer_performance): Likewise.
3727         * record-btrace.c (ui_out_field_uint): Remove.
3728         (btrace_call_history_insn_range, btrace_call_history): Use
3729         field_unsigned.
3730         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
3731         field_unsigned.
3732         * ui-out.h (class ui_out) <field_unsigned>: New method.
3733         <do_field_unsigned>: Likewise.
3734
3735 2019-07-15  Tom Tromey  <tromey@adacore.com>
3736
3737         * mi/mi-main.c (list_available_thread_groups): Use field_string.
3738         * mi/mi-interp.c (mi_memory_changed): Use field_string.
3739         * target.c (flash_erase_command): Use field_string.
3740         * infrun.c (print_signal_received_reason): Use field_string.
3741         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
3742         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
3743         field_string.
3744         * ada-tasks.c (print_ada_task_info): Use field_string.
3745
3746 2019-07-15  Tom Tromey  <tromey@adacore.com>
3747
3748         * target.c (flash_erase_command): Use field_core_addr.
3749         * symfile.c (generic_load): Use field_core_addr.
3750         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
3751         Use field_core_addr.
3752         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
3753         field_core_addr.
3754
3755 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3756
3757         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
3758         value if its desired type is smaller than a CORE_ADDR and signed.
3759
3760 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3761
3762         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
3763         of changes to field names, and use new is_reference field to
3764         decide if a property is a reference or not.
3765         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
3766         field.
3767         (struct dwarf2_property_baton): Update header comment, rename
3768         'referenced_type' to 'property_type' and update comments.
3769         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
3770         default property type, store in property baton, update to take
3771         accound of renamed field.
3772         (read_func_scope): Update call to attr_to_dynamic_prop.
3773         (read_array_type): Likewise.
3774         (dwarf2_per_cu_addr_sized_int_type): New function.
3775         (read_subrange_index_type): Move type finding code to
3776         dwarf2_per_cu_addr_sized_int_type.
3777         (read_subrange_type): Update calls to attr_to_dynamic_prop.
3778         (dwarf2_per_cu_addr_type): New function.
3779         (set_die_type): Update calls to attr_to_dynamic_prop.
3780
3781 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3782
3783         * dwarf2read.c (read_subrange_index_type): New function.
3784         (read_subrange_type): Move code into new function and call it.
3785         * gdbtypes.c (create_range_type): Add some asserts.
3786
3787 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3788
3789         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
3790         update return statements.
3791         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
3792         declaration, and update comment to match.
3793         * gdbtypes.c (resolve_dynamic_array): Update call to
3794         dwarf2_evaluate_property to match new return type.
3795
3796 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3797
3798         * valarith.c (value_subscripted_rvalue): Change lowerbound
3799         parameter type from int to LONGEST.
3800         * value.h (value_subscripted_rvalue): Likewise in declaration.
3801
3802 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3803
3804         * cli/cli-utils.c (info_print_command_completer): New function.
3805         * cli/cli-utils.h: Add 'completer.h' include, and forward
3806         declaration for 'struct cmd_list_element'.
3807         (info_print_command_completer): Declare.
3808         * stack.c (_initialize_stack): Add completer for 'info locals' and
3809         'info args'.
3810         * symtab.c (_initialize_symtab): Add completer for 'info
3811         variables' and 'info functions'.
3812         * NEWS: Mention completion for additional info commands.
3813
3814 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3815
3816         * cli/cli-utils.c (extract_info_print_args): Delete.
3817         (extract_arg_maybe_quoted): Delete.
3818         (info_print_options_defs): New variable.
3819         (make_info_print_options_def_group): New function.
3820         (extract_info_print_options): Define new function.
3821         * cli/cli-utils.h (extract_info_print_args): Delete.
3822         (struct info_print_options): New structure.
3823         (extract_info_print_options): Declare new function.
3824         * stack.c (info_locals_command): Update to use new
3825         extract_info_print_options, also add a header comment.
3826         (info_args_command): Likewise.
3827         * symtab.c (info_variables_command): Likewise.
3828         (info_functions_command): Likewise.
3829
3830 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3831
3832         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
3833         to extract string arguments.
3834         * common/common-utils.c (extract_string_maybe_quoted): New function.
3835         * common/common-utils.h (extract_string_maybe_quoted): Declare.
3836
3837 2019-07-11  Tom Tromey  <tromey@adacore.com>
3838
3839         * main.c (get_init_files): Use GDBINIT, not gdbinit.
3840         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
3841         * top.h (gdbinit): Don't declare.
3842         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
3843         into...
3844         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
3845         * top.c (gdb_init): Don't call init_cli_cmds.
3846         (gdbinit): Remove.
3847         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
3848
3849 2019-07-11  Tom Tromey  <tromey@adacore.com>
3850
3851         * python/py-inferior.c (add_thread_object): Don't use thread_obj
3852         after it has been moved.
3853
3854 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
3855
3856         * valops.c (value_must_coerce_to_target): Change return type to
3857         bool.
3858         * value.h (value_must_coerce_to_target): Likewise.
3859
3860 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
3861
3862         * breakpoint.c (is_hardware_watchpoint): Remove
3863         forward-declaration.
3864         (is_masked_watchpoint): Change return type to bool.
3865         (is_tracepoint): Likewise.
3866         (is_breakpoint): Likewise.
3867         (is_hardware_watchpoint): Likewise.
3868         (is_watchpoint): Likewise.
3869         (is_no_memory_software_watchpoint): Likewise.
3870         (is_catchpoint): Likewise.
3871         (breakpoint_1): Make FILTER parameter's return type bool.
3872         is_masked_watchpoint): Change return type to bool.
3873         (save_breakpoints): Make FILTER parameter's return type bool.
3874         * breakpoint.h (is_breakpoint): Change return type to bool.
3875         (is_watchpoint): Likewise.
3876         (is_catchpoint): Likewise.
3877         (is_tracepoint): Likewise.
3878
3879 2019-07-10  Tom Tromey  <tom@tromey.com>
3880
3881         * defs.h: Don't include gdbarch.h.
3882         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
3883         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
3884         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
3885         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
3886         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
3887         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
3888         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
3889         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
3890         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
3891         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
3892         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
3893         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
3894         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
3895         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
3896         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
3897         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
3898         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
3899         record-btrace.c, record.h, regcache-dump.c, regcache.h,
3900         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
3901         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
3902         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
3903         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
3904         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
3905         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
3906         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
3907         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
3908         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
3909
3910 2019-07-10  Tom Tromey  <tromey@adacore.com>
3911
3912         * ada-lang.h (is_ada_exception_catchpoint): Declare.
3913         * breakpoint.c (init_ada_exception_breakpoint): Register as
3914         bp_catchpoint.
3915         (print_one_breakpoint_location, print_one_breakpoint): Use
3916         is_ada_exception_catchpoint.
3917         * ada-lang.c (class ada_catchpoint_location): Pass
3918         bp_loc_software_breakpoint to bp_location constructor.
3919         (is_ada_exception_catchpoint): New function.
3920
3921 2019-07-10  Tom Tromey  <tromey@adacore.com>
3922
3923         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
3924         VEC.
3925         (struct arm_exidx_entry): New method operator<.
3926         (struct arm_exidx_data) <section_maps>: Change type.
3927         (arm_exidx_data_free): Remove.
3928         (arm_exidx_data_key): Change type.  Move lower.
3929         (arm_exidx_new_objfile): Update.
3930         (arm_compare_exidx_entries): Remove.
3931         (arm_find_exidx_entry, _initialize_arm_tdep)
3932
3933 2019-07-10  Tom Tromey  <tromey@adacore.com>
3934
3935         * solib-spu.c (ocl_program_data_key): Change type.
3936         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
3937         Update.
3938
3939 2019-07-10  Tom Tromey  <tromey@adacore.com>
3940
3941         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
3942         (struct solib_aix_inferior_data) <library_list>: Change type.
3943         (solib_aix_inferior_data_handle): Change type.
3944         (get_solib_aix_inferior_data): Update.
3945         (solib_aix_free_library_list): Remove.
3946         (library_list_start_library): Update.
3947         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
3948         return type.
3949         (solib_aix_get_library_list)
3950         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
3951         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
3952
3953 2019-07-10  Tom Tromey  <tromey@adacore.com>
3954
3955         * solib-dsbt.c (struct dsbt_info): Add initializers.
3956         (solib_dsbt_pspace_data): Change type.
3957         (dsbt_pspace_data_cleanup): Remove.
3958         (get_dsbt_info, _initialize_dsbt_solib): Update.
3959
3960 2019-07-10  Tom Tromey  <tromey@adacore.com>
3961
3962         * spu-tdep.c (spu_overlay_data): Change type.
3963         (spu_get_overlay_table, spu_overlay_new_objfile)
3964         (_initialize_spu_tdep): Update.
3965
3966 2019-07-10  Tom Tromey  <tromey@adacore.com>
3967
3968         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
3969         destructor.
3970         (dbx_objfile_data_key): Change type and declare later.
3971         (DBX_SYMFILE_INFO): Rewrite.
3972         * dbxread.c (dbx_objfile_data_key): Change type.
3973         (dbx_symfile_init): Update.
3974         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
3975         (coffstab_build_psymtabs, elfstab_build_psymtabs)
3976         (stabsect_build_psymtabs, _initialize_dbxread): Update.
3977
3978 2019-07-10  Tom Tromey  <tromey@adacore.com>
3979
3980         * jit.c (jit_program_space_key): Change type.  Move lower.
3981         (get_jit_program_space_data): Update.
3982         (jit_program_space_data_cleanup): Remove.
3983         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
3984         Update.
3985         (struct jit_program_space_data): Add initializers.
3986
3987 2019-07-10  Tom Tromey  <tromey@adacore.com>
3988
3989         * solib-darwin.c (struct darwin_info): Add initializers.
3990         (solib_darwin_pspace_data): Change type.
3991         (darwin_pspace_data_cleanup): Remove.
3992         (get_darwin_info, _initialize_darwin_solib): Update.
3993
3994 2019-07-10  Tom Tromey  <tromey@adacore.com>
3995
3996         * remote-sim.c (struct sim_inferior_data): Add initializers,
3997         constructor, and destructor.
3998         (sim_inferior_data_key): Change type.  Move lower.
3999         (check_for_duplicate_sim_descriptor): Update.
4000         (get_sim_inferior_data): Use new.  Update.
4001         (~sim_inferior_data_cleanup): Rename from
4002         sim_inferior_data_cleanup.  Simplify.
4003         (gdbsim_close_inferior, simulator_command)
4004         (sim_command_completer, _initialize_remote_sim): Update.
4005         (next_pid, INITIAL_PID): Move earlier.
4006
4007 2019-07-10  Tom Tromey  <tromey@adacore.com>
4008
4009         * python/python-internal.h (create_thread_object): Return
4010         gdbpy_ref.
4011         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4012         * python/py-inferior.c (struct threadlist_entry): Add
4013         constructor.
4014         <thread_obj>: Now a gdbpy_ref.
4015         (thread_to_thread_object): Update.
4016         (add_thread_object): Use new.
4017         (delete_thread_object): Use delete.
4018         (infpy_threads): Update.
4019         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4020         GIL.
4021
4022 2019-07-10  Tom Tromey  <tromey@adacore.com>
4023
4024         * valops.c (value_cast): Specialize error message for Ada.
4025
4026 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4027
4028         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4029
4030 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4031
4032         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4033         bpstat_should_step): Return bool, adjust comments.
4034         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4035         bpstat_should_step): Likewise.
4036
4037 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4038
4039         * features/Makefile: Use feature target descriptions for Arm.
4040         * features/arm/arm-core.c: Generate new file.
4041         * features/arm/arm-fpa.c: Likewise.
4042         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4043         * features/arm/arm-m-profile.c: Likewise.
4044         * features/arm/arm-vfpv2.c: Likewise.
4045         * features/arm/arm-vfpv3.c: Likewise.
4046         * features/arm/xscale-iwmmxt.c: Likewise.
4047         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4048
4049 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4050
4051         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4052         ptrace earlier.
4053
4054 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4055
4056         * features/aarch64-pauth.c: Regenerate.
4057
4058 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4059
4060         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4061         bool.
4062         (bpstat_what): Use false instead of 0.
4063
4064 2019-07-09  Pedro Alves  <palves@redhat.com>
4065
4066         * break-catch-throw.c (is_exception_catchpoint): New.
4067         * breakpoint.c (print_one_breakpoint_location): New parameter
4068         'raw_loc'.  Handle it.  Use
4069         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4070         looking at the breakpoint's type.
4071         (print_one_breakpoint): If handling "maint info breakpoints", also
4072         print locations of exception catchpoints.
4073         * breakpoint.h (is_exception_catchpoint): Declare.
4074
4075 2019-07-09  Pedro Alves  <palves@redhat.com>
4076
4077         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4078         "addr" field.
4079         (allocate_location_exception_catchpoint): New.
4080         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4081         (initialize_throw_catchpoint_ops): Install
4082         allocate_location_exception_catchpoint as allocate_location
4083         method.
4084         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4085         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4086         bp_loc_other.
4087         (breakpoint_address_is_meaningful): Delete.
4088         (bl_address_is_meaningful): New.
4089         (breakpoint_locations_match): Adjust comment.
4090         (bp_location_from_bp_type): New, factored out of...
4091         (bp_location::bp_location(breakpoint *)): ... this.
4092         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4093         factored out of...
4094         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4095         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4096         breakpoint_address_is_meaningful.
4097         (bp_locations_compare): Adjust comment.
4098         (update_global_location_list): Use bl_address_is_meaningful
4099         instead of breakpoint_address_is_meaningful.
4100         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4101         explicit.
4102         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4103         * python/py-breakpoint.c (bppy_get_location): No longer check
4104         whether location is null.
4105
4106 2019-07-09  Pedro Alves  <palves@redhat.com>
4107
4108         PR c++/15468
4109         * breakpoint.c (print_one_breakpoint_location): Remove
4110         single-location assert.
4111
4112 2019-07-09  Tom Tromey  <tom@tromey.com>
4113
4114         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4115         * configure: Rebuild.
4116         * configure.ac: Change common to gdbsupport.
4117         * gdbsupport: Rename from common.
4118         * acinclude.m4: Change common to gdbsupport.
4119         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4120         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4121         gdbsupport.
4122         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4123         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4124         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4125         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4126         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4127         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4128         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4129         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4130         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4131         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4132         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4133         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4134         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4135         coff-pe-read.c, command.h, compile/compile-c-support.c,
4136         compile/compile-c.h, compile/compile-cplus-symbols.c,
4137         compile/compile-cplus-types.c, compile/compile-cplus.h,
4138         compile/compile-loc2c.c, compile/compile.c, completer.c,
4139         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4140         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4141         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4142         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4143         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4144         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4145         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4146         features/aarch64-core.c, features/aarch64-fpu.c,
4147         features/aarch64-pauth.c, features/aarch64-sve.c,
4148         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4149         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4150         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4151         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4152         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4153         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4154         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4155         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4156         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4157         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4158         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4159         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4160         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4161         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4162         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4163         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4164         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4165         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4166         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4167         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4168         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4169         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4170         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4171         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4172         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4173         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4174         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4175         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4176         minsyms.c, mips-linux-tdep.c, namespace.h,
4177         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4178         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4179         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4180         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4181         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4182         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4183         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4184         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4185         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4186         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4187         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4188         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4189         procfs.c, producer.c, progspace.h, psymtab.h,
4190         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4191         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4192         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4193         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4194         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4195         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4196         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4197         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4198         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4199         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4200         target-memory.c, target.c, target.h, target/waitstatus.c,
4201         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4202         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4203         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4204         unittests/array-view-selftests.c,
4205         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4206         unittests/common-utils-selftests.c,
4207         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4208         unittests/format_pieces-selftests.c,
4209         unittests/function-view-selftests.c,
4210         unittests/lookup_name_info-selftests.c,
4211         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4212         unittests/mkdir-recursive-selftests.c,
4213         unittests/observable-selftests.c,
4214         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4215         unittests/parse-connection-spec-selftests.c,
4216         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4217         unittests/scoped_fd-selftests.c,
4218         unittests/scoped_mmap-selftests.c,
4219         unittests/scoped_restore-selftests.c,
4220         unittests/string_view-selftests.c, unittests/style-selftests.c,
4221         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4222         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4223         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4224         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4225         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4226         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4227
4228 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4229
4230         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4231         bool value.
4232         (decode_digits_ordinary): Set explicit_line field in sal.
4233         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4234         symtab_and_line that was set on an explicit line number in
4235         assembler code.  Do always update the recorded symtab and line if
4236         we do skip the prologue.
4237
4238 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4239
4240         * breakpoint.c (set_breakpoint_location_function): Remove
4241         explicit_loc parameter.
4242         (momentary_breakpoint_from_master): Update call to
4243         set_breakpoint_location_function.
4244         (add_location_to_breakpoint): Likewise.
4245
4246 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4247
4248         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4249         required features based on default bfd type when no specific bfd
4250         is present.
4251
4252 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4253
4254         * NEWS: Mention that GDB printf and eval commands can now print
4255         C-style and Ada-style convenience var strings without
4256         calling the inferior.
4257         * printcmd.c (printf_c_string): Locally print GDB internal var
4258         instead of transiting via the inferior.
4259         (printf_wide_c_string): Likewise.
4260
4261 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4262
4263         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4264
4265 2019-07-04  Tom Tromey  <tom@tromey.com>
4266
4267         PR tui/24724:
4268         * tui/tui-winsource.c (tui_clear_source_content): Update.
4269         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4270         (tui_update_breakpoint_info): Update.
4271         (tui_set_exec_info_content): Update.
4272         * tui/tui-source.c (tui_set_source_content_nil): Update.
4273         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4274         has_break.
4275         * tui/tui-data.h (enum tui_bp_flag): New.
4276         (tui_bp_flags): New enum flags type.
4277         (struct tui_source_element) <break_mode>: Change type.  Rename
4278         from has_break.
4279         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4280         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4281         constants.
4282         * tui/tui-winsource.h: Fix comment.
4283
4284 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4285
4286         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4287         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4288         (store_fpregs_to_thread)
4289         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4290         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4291         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4292         (IWMMXT_REGS_SIZE): Add define.
4293         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4294         (fetch_vfp_regs, store_vfp_regs)
4295         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4296         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4297
4298 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4299
4300         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4301         defines.
4302         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4303         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4304         (ARM_INT_REGISTER_SIZE): ...to this.
4305         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4306         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4307         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4308         (arm_linux_collect_gregset, supply_nwfpe_register)
4309         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4310         defines.
4311         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4312         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4313         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4314         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4315         (arm_return_in_memory, arm_store_return_value)
4316         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4317         (arm_record_ld_st_multiple): Likewise.
4318         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4319         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4320
4321 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4322
4323         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4324         AARCH64_DISPLACED_MODIFIED_INSNS.
4325         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4326         (aarch64_displaced_step_copy_insn): Likewise.
4327         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4328         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4329         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4330         ARM_DISPLACED_MODIFIED_INSNS.
4331         * arm-tdep.c (arm_gdbarch_init): Likewise.
4332         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4333         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4334         (struct arm_displaced_step_closure): Use
4335         ARM_DISPLACED_MODIFIED_INSNS.
4336
4337 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4338
4339         * features/Makefile: Remove unused xml files.
4340         * features/aarch64.xml: Remove.
4341         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4342         * features/i386/amd64-avx-avx512.xml: Remove.
4343         * features/i386/amd64-avx-linux.xml: Remove.
4344         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4345         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4346         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4347         * features/i386/amd64-avx-mpx.xml: Remove.
4348         * features/i386/amd64-avx.xml: Remove.
4349         * features/i386/amd64-linux.xml: Remove.
4350         * features/i386/amd64-mpx-linux.xml: Remove.
4351         * features/i386/amd64-mpx.xml: Remove.
4352         * features/i386/amd64.xml: Remove.
4353         * features/i386/i386-avx-avx512-linux.xml: Remove.
4354         * features/i386/i386-avx-avx512.xml: Remove.
4355         * features/i386/i386-avx-linux.xml: Remove.
4356         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4357         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4358         * features/i386/i386-avx-mpx-linux.xml: Remove.
4359         * features/i386/i386-avx-mpx.xml: Remove.
4360         * features/i386/i386-avx.xml: Remove.
4361         * features/i386/i386-linux.xml: Remove.
4362         * features/i386/i386-mmx-linux.xml: Remove.
4363         * features/i386/i386-mmx.xml: Remove.
4364         * features/i386/i386-mpx-linux.xml: Remove.
4365         * features/i386/i386-mpx.xml: Remove.
4366         * features/i386/i386.xml: Remove.
4367         * features/i386/x32-avx-avx512-linux.xml: Remove.
4368         * features/i386/x32-avx-linux.xml: Remove.
4369         * features/i386/x32-linux.xml: Remove.
4370
4371 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4372
4373         * regformats/aarch64.dat: Remove.
4374         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4375         * regformats/i386/amd64-avx-linux.dat: Remove.
4376         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4377         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4378         * regformats/i386/amd64-linux.dat: Remove.
4379         * regformats/i386/amd64-mpx-linux.dat: Remove.
4380         * regformats/i386/amd64.dat: Remove.
4381         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4382         * regformats/i386/i386-avx-linux.dat: Remove.
4383         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4384         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4385         * regformats/i386/i386-linux.dat: Remove.
4386         * regformats/i386/i386-mmx-linux.dat: Remove.
4387         * regformats/i386/i386-mpx-linux.dat: Remove.
4388         * regformats/i386/i386.dat: Remove.
4389         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4390         * regformats/i386/x32-avx-linux.dat: Remove.
4391         * regformats/i386/x32-linux.dat: Remove.
4392
4393 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4394
4395         * aarch64-tdep.c: Remove xml self tests.
4396         * amd64-linux-tdep.c: Likewise.
4397         * amd64-tdep.c: Likewise.
4398         * i386-linux-tdep.c: Likewise.
4399         * i386-tdep.c: Likewise.
4400
4401 2019-07-03  Pedro Alves  <palves@redhat.com>
4402
4403         PR cli/24732
4404         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4405         (pipe_cmd_option_defs): New.
4406         (make_pipe_cmd_options_def_group): New.
4407         (pipe_command): Use gdb::option::process_options.
4408         (pipe_command_completer): New function.
4409         (_initialize_cli_cmds): Install completer for "pipe" command.
4410
4411 2019-07-03  Pedro Alves  <palves@redhat.com>
4412
4413         * cli/cli-option.c (union option_value) <string>: New field.
4414         (struct option_def_and_value): Add ctor, move ctor, dtor and
4415         use DISABLE_COPY_AND_ASSIGN.
4416         (option_def_and_value::clear_value): New.
4417         (parse_option, save_option_value_in_ctx, get_val_type_str)
4418         (add_setshow_cmds_for_options): Handle var_string.
4419         * cli-option.h (union option_def::var_address) <string>: New
4420         field.
4421         (struct string_option_def): New.
4422         * maint-test-options.c (struct test_options_opts): Add default
4423         ctor and use DISABLE_COPY_AND_ASSIGN.
4424         <string_opt>: New field.
4425         (test_options_opts::~test_options_opts): New.
4426         (test_options_opts::dump): Also dump "-string".
4427         (test_options_option_defs): Install "string.
4428
4429 2019-07-03  Pedro Alves  <palves@redhat.com>
4430
4431         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4432         option_value with a null enumeration.
4433         (complete_options): Save the option values in the context.
4434         (save_option_value_in_ctx): New, factored out from ...
4435         (process_options): ... here.
4436         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4437         of the function.
4438         * maint-test-options.c (test_options_opts::dump): New, factored
4439         out from ...
4440         (maintenance_test_options_command_mode): ... here.
4441         (maintenance_test_options_command_completion_result): Delete.
4442         (maintenance_test_options_command_completion_text): Update
4443         comment.
4444         (maintenance_show_test_options_completion_result): Change
4445         prototype.  Just print
4446         maintenance_test_options_command_completion_text.
4447         (save_completion_result): New.
4448         (maintenance_test_options_completer_mode): Pass options context to
4449         complete_options, and then save a dump.
4450         (_initialize_maint_test_options): Use add_cmd to install "maint
4451         show test-options-completion-result".
4452
4453 2019-07-03  Pedro Alves  <palves@redhat.com>
4454
4455         * NEWS (New commands): Mention "with" and "maint with".
4456         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4457         (with_command, with_command_completer): New.
4458         (pipe_command): Adjust to new repeat_previous
4459         interface.
4460         (_initialize_cli_cmds): Install the "with" command and its "w"
4461         alias.
4462         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4463         declarations.
4464         * cli/cli-setshow.c (parse_cli_var_uinteger)
4465         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4466         argument strings for all var_types.
4467         (get_setshow_command_value_string): New, factored out from ...
4468         (do_show_command): ... this.
4469         * cli/cli-setshow.h: Include <string>.
4470         (get_setshow_command_value_string): Declare.
4471         * command.h (repeat_previous): Now returns const char *.  Adjust
4472         comment.
4473         * maint.c: Include "cli/cli-cmds.h".
4474         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4475         (_initialize_maint_cmds): Register the "maintenance with" command.
4476         * top.c (repeat_previous): Move bits from pipe_command here:
4477         Return the saved command line, if any; error out if there's no
4478         command to relaunch.
4479
4480 2019-07-03  Pedro Alves  <palves@redhat.com>
4481
4482         * NEWS (New commands): Mention "maint set/show test-settings"
4483         instead of "maint test-settings".
4484         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4485         (maintenance_test_settings_set_list): Rename to ...
4486         (maintenance_set_test_settings_list): ... this.
4487         (maintenance_test_settings_show_list): Rename to  ...
4488         (maintenance_show_test_settings_list): ... this.
4489         (maintenance_test_settings_cmd): Delete.
4490         (maintenance_test_settings_set_cmd): ...
4491         (maintenance_set_test_settings_cmd): ... this.
4492         (maintenance_test_settings_show_cmd): ...
4493         (maintenance_show_test_settings_cmd): ... this.
4494         (maintenance_test_settings_show_value_cmd):
4495         (maintenance_show_test_settings_value_cmd): ... this.
4496         (_initialize_maint_test_settings): No longer install the "maint
4497         test-settings" prefix command.  Rename "maint test-settings set"
4498         to "maint set test-settings", and "maint test-settings show" to
4499         "maint show test-settings".  Adjust all subcommands.
4500
4501 2019-07-03  Pedro Alves  <palves@redhat.com>
4502
4503         * maint-test-settings.c: Fix file's intro comment.  Replace all
4504         references to "test-options" with references to "test-settings",
4505         in comments.
4506
4507 2019-07-03  Pedro Alves  <palves@redhat.com>
4508
4509         * maint-test-settings.c (maintenance_test_settings_xxx)
4510         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4511         New.
4512         (maintenance_test_settings_enums): Use them.
4513         (maintenance_test_settings_enum): Default to
4514         maintenance_test_settings_xxx.
4515         (_initialize_maint_test_settings): Initialize
4516         MAINTENANCE_TEST_SETTINGS_FILENAME.
4517
4518 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4519
4520         * breakpoint.h (remove_breakpoints_inf): Change return type to
4521         void, move function documentation here.
4522         * breakpoint.c (remove_breakpoints_inf): Change return type to
4523         void, move function documentation to header.
4524
4525 2019-07-02  Pedro Alves  <palves@redhat.com>
4526
4527         * NEWS (Completion improvements): Mention "info threads".
4528         * thread.c (struct info_threads_opts, info_threads_option_defs)
4529         (make_info_threads_options_def_group): New.
4530         (info_threads_command): Use gdb::option::process_options.
4531         (info_threads_command_completer): New.
4532         (_initialize_thread): Use gdb::option::build_help to build the
4533         help text for "info threads".
4534
4535 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4536
4537         * defs.h (generic_load): Move from here...
4538         * symfile.h (generic_load): ... to here.  Rename name parameter
4539         to args.
4540         * symfile.c (generic_load): Add comment.
4541
4542 2019-07-01  Tom Tromey  <tromey@adacore.com>
4543
4544         * dwarf2read.c
4545         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4546         declaration of without_params.  Fix formatting.
4547
4548 2019-07-01  Tom Tromey  <tromey@adacore.com>
4549
4550         * ada-exp.y (find_primitive_type): Update.
4551         * ada-lang.h (ada_lookup_symbol): Update.
4552         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4553         parameter.
4554         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4555
4556 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4557
4558         PR breakpoints/24541
4559         * gdbarch.c: Regenerate.
4560         * gdbarch.h: Regenerate.
4561         * gdbarch.sh: Add 'stap_adjust_register'.
4562         * i386-tdep.c: Include '<unordered_set>'.
4563         (i386_stap_adjust_register): New function.
4564         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4565         * stap-probe.c (stap_parse_register_operand): Call
4566         'gdbarch_stap_adjust_register'.
4567
4568 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4569
4570         PR python/24742
4571         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4572         * python/python.c (do_start_initialization): Use 'xmalloc'
4573         instead of 'PyMem_Malloc'.
4574
4575 2019-06-28  Tom Tromey  <tromey@adacore.com>
4576
4577         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4578         for Ada.
4579
4580 2019-06-27  Tom Tromey  <tromey@adacore.com>
4581
4582         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4583         objfile_key.
4584         (arm_find_mapping_symbol, arm_record_special_symbol)
4585         (_initialize_arm_tdep): Update.
4586         (arm_objfile_data_free): Remove.
4587
4588 2019-06-27  Tom Tromey  <tromey@adacore.com>
4589
4590         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4591         to cp_print_static_field.
4592
4593 2019-06-26  Tom Tromey  <tromey@adacore.com>
4594
4595         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4596         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4597         declare.
4598
4599 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4600
4601         * features/aarch64-core.c (create_feature_aarch64_core):
4602         Regenerate.
4603         * features/aarch64-core.xml: Add cpsr flags.
4604
4605 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4606
4607         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4608         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4609
4610 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4611
4612         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4613         field.
4614         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4615         use.
4616         (arm_record_special_symbol): Don't insert new symbol in sorted
4617         position, push it at the end.
4618
4619 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4620
4621         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4622         (arm_mapping_symbol_s): Remove.
4623         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4624         (arm_mapping_symbol_vec): New typedef.
4625         (struct arm_per_objfile): Add constructor.
4626         <section_maps>: Change type to
4627         std::unique_ptr<arm_mapping_symbol_vec[]>.
4628         (arm_compare_mapping_symbols): Remove.
4629         (arm_find_mapping_symbol): Adjust to section_maps type change.
4630         (arm_objfile_data_free): Call delete on arm_per_objfile.
4631         (arm_record_special_symbol): Adjust to section_maps type change.
4632         Allocate arm_per_objfile with new.
4633
4634 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4635
4636         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4637         with the command prefix.
4638
4639 2019-06-25  Tom Tromey  <tom@tromey.com>
4640
4641         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4642         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4643
4644 2019-06-25  Tom Tromey  <tom@tromey.com>
4645
4646         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
4647         type.
4648         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
4649         protected.
4650
4651 2019-06-25  Tom Tromey  <tom@tromey.com>
4652
4653         * tui/tui-winsource.c
4654         (tui_source_window_base::set_is_exec_point_at): Add check against
4655         LOA_ADDRESS.
4656
4657 2019-06-25  Tom Tromey  <tom@tromey.com>
4658
4659         * tui/tui-source.c (tui_set_source_content): Don't check before
4660         xfree.
4661         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
4662
4663 2019-06-25  Tom Tromey  <tom@tromey.com>
4664
4665         * tui/tui-winsource.h (tui_update_source_window_as_is)
4666         (tui_alloc_source_buffer, tui_line_is_displayed)
4667         (tui_addr_is_displayed): Change type of win_info.
4668         * tui/tui-winsource.c (tui_update_source_window_as_is)
4669         (tui_clear_source_content, tui_show_source_line)
4670         (tui_show_source_content, tui_source_window_base::refill)
4671         (tui_source_window_base::set_is_exec_point_at)
4672         (tui_source_window_base::set_is_exec_point_at)
4673         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
4674         (tui_alloc_source_buffer, tui_line_is_displayed)
4675         (tui_addr_is_displayed): Change type of win_info.  Update.
4676         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4677         (tui_source_window_base::do_make_visible_with_new_height):
4678         Update.
4679         * tui/tui-source.c (tui_set_source_content)
4680         (tui_set_source_content_nil)
4681         (tui_source_window::do_scroll_vertical): Update.
4682         * tui/tui-layout.c (show_layout): Update.
4683         * tui/tui-disasm.c (tui_set_disassem_content)
4684         (tui_disasm_window::do_scroll_vertical): Update.
4685         * tui/tui-data.h (tui_win_content): Remove.
4686         (struct tui_gen_win_info) <content, content_size>: Remove.
4687         (struct tui_source_element): Add initializers and destructor.
4688         (union tui_which_element, struct tui_win_element): Remove.
4689         (struct tui_source_window_base) <content>: New field.
4690         (struct tui_data_window): Remove destructor.
4691         (tui_alloc_content, tui_free_win_content)
4692         (tui_free_all_source_wins_content): Don't declare.
4693         * tui/tui-data.c (tui_initialize_static_data): Update.
4694         (init_content_element, tui_alloc_content): Remove.
4695         (~tui_gen_win_info): Update.
4696         (~tui_data_window, tui_free_all_source_wins_content)
4697         (tui_free_win_content, free_content, free_content_elements):
4698         Remove.
4699
4700 2019-06-25  Tom Tromey  <tom@tromey.com>
4701
4702         * tui/tui-winsource.h (tui_clear_source_content)
4703         (tui_erase_source_content, tui_show_source_content): Change type
4704         of win_info.
4705         * tui/tui-winsource.c (tui_clear_source_content)
4706         (tui_erase_source_content, tui_show_source_content): Change type
4707         of win_info.
4708         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4709         * tui/tui-source.h (tui_set_source_content_nil): Change type of
4710         win_info.
4711         * tui/tui-source.c (tui_set_source_content_nil): Change type of
4712         win_info.
4713         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
4714
4715 2019-06-25  Tom Tromey  <tom@tromey.com>
4716
4717         * tui/tui-winsource.c (tui_clear_source_content)
4718         (tui_source_window_base::set_is_exec_point_at): Update.
4719         * tui/tui-source.c (tui_set_source_content_nil): Update.
4720         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
4721         a bool.
4722         * tui/tui-data.c (init_content_element): Update.
4723
4724 2019-06-25  Tom Tromey  <tom@tromey.com>
4725
4726         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
4727         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
4728         * tui/tui-layout.c (init_and_make_win): Update.
4729         * tui/tui.h (enum tui_win_type): Update.
4730         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
4731         tui_win_is_auxillary.
4732         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
4733         tui_win_is_auxillary.
4734
4735 2019-06-25  Tom Tromey  <tom@tromey.com>
4736
4737         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
4738         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
4739         (tui_delete_data_content_windows, tui_display_all_data)
4740         (tui_data_window::do_scroll_vertical, tui_display_data_from):
4741         Update.
4742         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
4743         * tui/tui-regs.c (tui_last_regs_line_no)
4744         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
4745         (tui_show_registers): Update.
4746         (tui_show_register_group): Return void.  Update.
4747         (tui_display_registers_from, tui_display_reg_element_at_line)
4748         (tui_display_registers_from_line, tui_check_register_values):
4749         Update.
4750         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
4751         member.
4752         (struct tui_data_window) <regs_content>: Now a std::vector.
4753         <regs_content_count>: Remove.
4754         (tui_add_content_elements, tui_free_data_content): Don't declare.
4755         * tui/tui-data.c (tui_data_window::clear_detail): Update.
4756         (init_content_element): Remove DATA_WIN case.  Add assert.
4757         (tui_add_content_elements): Remove.
4758         (tui_data_window): Update.
4759         (tui_free_data_content): Remove.
4760         (free_content_elements): Remove DATA_WIN case.
4761
4762 2019-06-25  Tom Tromey  <tom@tromey.com>
4763
4764         * tui/tui-data.c (tui_data_item_window): Update.
4765         * tui/tui-windata.h (tui_check_data_values): Don't declare.
4766         * tui/tui-windata.c (tui_display_all_data)
4767         (tui_display_data_from_line): Update.
4768         (tui_check_data_values): Remove.
4769         * tui/tui-regs.c (tui_show_register_group)
4770         (tui_display_reg_element_at_line): Update.
4771         * tui/tui-hooks.c (tui_register_changed)
4772         (tui_refresh_frame_and_register_information): Call
4773         tui_check_register_values.
4774         * tui/tui-data.h (struct tui_data_window) <data_content,
4775         data_content_count, data_type>: Remove.
4776         (enum tui_data_type): Remove.
4777
4778         * tui/tui-data.c (tui_data_window::clear_detail)
4779         (~tui_data_window): Update.
4780
4781 2019-06-25  Tom Tromey  <tom@tromey.com>
4782
4783         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
4784         declare.
4785         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
4786         Rename from tui_first_data_item_displayed.  Update.
4787         (tui_data_window::refresh_all)
4788         (tui_data_window::do_scroll_vertical): Update.
4789         * tui/tui-data.h (struct tui_data_window)
4790         <first_data_item_displayed>: Declare new method.
4791
4792 2019-06-25  Tom Tromey  <tom@tromey.com>
4793
4794         * tui/tui-data.h (tui_init_generic_part): Don't declare.
4795         * tui/tui-data.c (tui_init_generic_part): Remove, moving
4796         contents...
4797         (tui_initialize_static_data): ...here.
4798
4799 2019-06-25  Tom Tromey  <tom@tromey.com>
4800
4801         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
4802         (tui_display_registers_from, tui_check_register_values): Update.
4803         (tui_display_register): Remove win_info parameter; update.
4804         (tui_get_register): Change type of parameters.
4805         * tui/tui-data.h (struct tui_data_element): Remove.
4806         (union tui_which_element) <data>: Remove.
4807         <data_window>: Change type.
4808         (struct tui_data_item_window): New.
4809         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
4810         case.  Add assert.
4811         (~tui_data_item_window): New destructor.
4812         (free_content_elements): Remove DATA_ITEM_WIN case.
4813
4814 2019-06-25  Tom Tromey  <tom@tromey.com>
4815
4816         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
4817         Remove.
4818
4819 2019-06-25  Tom Tromey  <tom@tromey.com>
4820
4821         * tui/tui-data.h (struct tui_command_element): Remove.
4822         (union tui_which_element) <command>: Remove.
4823         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
4824         assert.
4825         (free_content_elements): Remove CMD_WIN case.
4826
4827 2019-06-25  Tom Tromey  <tom@tromey.com>
4828
4829         * tui/tui-layout.c (tui_set_layout): Update.
4830         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
4831         * tui/tui-data.c (layout_def): Update.
4832
4833 2019-06-25  Tom Tromey  <tom@tromey.com>
4834
4835         * tui/tui-wingeneral.c (tui_refresh_all): Update.
4836         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4837         (tui_source_window_base::set_new_height): Update.
4838         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
4839         Update.
4840         (tui_set_locator_fullname, tui_set_locator_info)
4841         (tui_show_frame_info): Update.
4842         * tui/tui-source.c (tui_set_source_content)
4843         (tui_source_is_displayed): Update.
4844         * tui/tui-layout.c (show_source_disasm_command, show_data)
4845         (show_source_or_disasm_and_command): Update.
4846         * tui/tui-disasm.c (tui_set_disassem_content)
4847         (tui_get_begin_asm_address): Update.
4848         * tui/tui-data.h (struct tui_locator_element): Remove.
4849         (union tui_which_element) <locator>: Remove.
4850         (struct tui_locator_window): New.
4851         (tui_locator_win_info_ptr): Change return type.
4852         * tui/tui-data.c (_locator): Change type.
4853         (tui_locator_win_info_ptr): Change return type.
4854         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
4855         (tui_alloc_content): Add assert.
4856
4857 2019-06-25  Tom Tromey  <tom@tromey.com>
4858
4859         * tui/tui-winsource.c
4860         (tui_exec_info_window::maybe_allocate_content): New method.
4861         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
4862         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
4863         (make_source_or_disasm_window): Add cast.
4864         * tui/tui-data.h (union tui_which_element) <simple_string>:
4865         Remove.
4866         (struct tui_source_info): New.
4867         (struct tui_source_window_base) <execution_info>: Change type.
4868         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
4869         case, and add assert.
4870         (tui_alloc_content): Add assert.
4871
4872 2019-06-25  Tom Tromey  <tom@tromey.com>
4873
4874         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
4875         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
4876         * tui/tui-data.c (tui_alloc_win_info): Remove.
4877
4878 2019-06-25  Tom Tromey  <tom@tromey.com>
4879
4880         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
4881         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
4882         can_highlight.
4883
4884 2019-06-25  Tom Tromey  <tom@tromey.com>
4885
4886         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
4887         make_visible_with_new_height method.
4888         (tui_win_info::make_visible_with_new_height): New method.
4889         (tui_source_window_base::do_make_visible_with_new_height)
4890         (tui_data_window::do_make_visible_with_new_height)
4891         (tui_cmd_window::do_make_visible_with_new_height): New methods.
4892         (make_visible_with_new_height): Remove.
4893         (tui_resize_all, tui_adjust_win_heights): Use
4894         make_visible_with_new_height method.
4895         * tui/tui-data.h (struct tui_win_info)
4896         <do_make_visible_with_new_height, make_visible_with_new_height>:
4897         New methods.
4898         (struct tui_source_window_base, struct tui_data_window)
4899         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
4900         methods.
4901
4902 2019-06-25  Tom Tromey  <tom@tromey.com>
4903
4904         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
4905         method.
4906         (update_tab_width): Call update_tab_width method.
4907         * tui/tui-data.h (struct tui_win_info)
4908         (struct tui_source_window_base) <update_tab_width>: New methods.
4909
4910 2019-06-25  Tom Tromey  <tom@tromey.com>
4911
4912         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
4913         parameter.
4914         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
4915         parameter.
4916         (tui_gen_win_info::make_visible): Update.
4917         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
4918         parameter.
4919         * tui/tui-data.h (enum tui_box): New enum.
4920         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
4921
4922 2019-06-25  Tom Tromey  <tom@tromey.com>
4923
4924         * tui/tui-layout.c (make_source_or_disasm_window): Always use
4925         init_and_make_win for EXEC_INFO_WIN.
4926         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
4927         longer inline.
4928         (struct tui_win_info) <~tui_win_info>: Inline.
4929         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4930         Don't declare.
4931         * tui/tui-data.c (source_win, disasm_win): Remove globals.
4932         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
4933         Remove.
4934         (tui_initialize_static_data): Update.
4935         (~tui_gen_win_info): Handle more cleanup here.
4936         (~tui_source_window_base): Delete "execution_info".
4937         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
4938
4939 2019-06-25  Tom Tromey  <tom@tromey.com>
4940
4941         * tui/tui-layout.c (make_command_window): Don't set
4942         can_highlight.
4943         (show_source_disasm_command): Call the reset method.
4944         (show_data): Don't set can_highlight.  Call the reset method.
4945         (tui_gen_win_info::reset): Rename from init_gen_win_info
4946         (init_and_make_win): Simplify.  Return tui_gen_win_info.
4947         (show_source_or_disasm_and_command): Call the reset method.
4948         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
4949         (struct tui_cmd_window): Set can_highlight.
4950
4951 2019-06-25  Tom Tromey  <tom@tromey.com>
4952
4953         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
4954         from make_visible.
4955         (tui_make_visible, tui_make_invisible): Rewrite.
4956         (tui_win_info::make_visible): Remove.
4957         (tui_source_window_base::make_visible): Update.
4958         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
4959         method.  Moved from...
4960         (struct tui_win_info) <make_visible>: ...here.
4961
4962 2019-06-25  Tom Tromey  <tom@tromey.com>
4963
4964         * tui/tui-winsource.c
4965         (tui_source_window_base::do_scroll_horizontal): Remove direction
4966         parameter.
4967         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
4968         direction parameter.
4969         * tui/tui-win.c (tui_win_info::forward_scroll)
4970         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
4971         (tui_win_info::right_scroll): Update.
4972         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
4973         direction parameter.
4974         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
4975         direction parameter.
4976         * tui/tui-data.h (enum tui_scroll_direction): Remove.
4977         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
4978         Remove direction parameter.
4979         (struct tui_source_window_base, struct tui_source_window)
4980         (struct tui_disasm_window, struct tui_data_window)
4981         (struct tui_cmd_window): Update.
4982
4983 2019-06-25  Tom Tromey  <tom@tromey.com>
4984
4985         * tui/tui-winsource.h (tui_set_exec_info_content)
4986         (tui_show_exec_info_content, tui_erase_exec_info_content)
4987         (tui_clear_exec_info_content, tui_update_exec_info): Change
4988         argument to tui_source_window_base.
4989         * tui/tui-winsource.c (tui_set_exec_info_content)
4990         (tui_show_exec_info_content, tui_erase_exec_info_content)
4991         (tui_clear_exec_info_content, tui_update_exec_info): Change
4992         argument to tui_source_window_base.
4993
4994 2019-06-25  Tom Tromey  <tom@tromey.com>
4995
4996         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
4997         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
4998
4999 2019-06-25  Tom Tromey  <tom@tromey.com>
5000
5001         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5002         check.
5003
5004 2019-06-25  Tom Tromey  <tom@tromey.com>
5005
5006         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5007         type to void.
5008         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5009         type to void.
5010         * tui/tui-source.c (tui_set_source_content): Update.
5011         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5012
5013 2019-06-25  Tom Tromey  <tom@tromey.com>
5014
5015         * tui/tui-win.c (window_name_completer, tui_set_focus)
5016         (tui_all_windows_info): Use name method.
5017         * tui/tui-data.h (struct tui_gen_win_info)
5018         (struct tui_source_window, struct tui_disasm_window)
5019         (struct tui_data_window, struct tui_cmd_window) <name>: New
5020         method.
5021         (tui_win_name): Don't declare.
5022         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5023         (tui_win_name): Remove.
5024
5025 2019-06-25  Tom Tromey  <tom@tromey.com>
5026
5027         * tui/tui-winsource.h (tui_update_source_window)
5028         (tui_update_source_window_as_is): Change parameter type.
5029         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5030         to be a tui_source_window_base.
5031         (tui_update_source_window_as_is): Likewise.
5032         * tui/tui-win.c (make_visible_with_new_height): Update.
5033
5034 2019-06-25  Tom Tromey  <tom@tromey.com>
5035
5036         * tui/tui-winsource.c (tui_erase_source_content)
5037         (tui_show_source_content, tui_show_exec_info_content)
5038         (tui_erase_exec_info_content): Use refresh_window method.
5039         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5040         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5041         from tui_refresh_win.
5042         (tui_data_window::refresh_window): New method.
5043         (tui_win_info::refresh, tui_source_window_base::refresh)
5044         (tui_refresh_all): Use refresh_window method.
5045         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5046         method.
5047         * tui/tui-regs.c (tui_display_register): Call refresh_window
5048         method.
5049         * tui/tui-layout.c (show_source_disasm_command)
5050         (show_source_or_disasm_and_command): Call refresh_window method.
5051         * tui/tui-data.h (struct tui_gen_win_info)
5052         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5053         New method.
5054
5055 2019-06-25  Tom Tromey  <tom@tromey.com>
5056
5057         * tui/tui.c (tui_rl_other_window, tui_enable)
5058         (tui_is_window_visible, tui_get_command_dimension): Update.
5059         * tui/tui-winsource.c (tui_update_source_window_as_is)
5060         (tui_clear_source_content, tui_erase_source_content)
5061         (tui_show_source_line, tui_source_window_base::refill)
5062         (tui_source_window_base::do_scroll_horizontal)
5063         (tui_source_window_base::set_is_exec_point_at)
5064         (tui_update_breakpoint_info, tui_set_exec_info_content)
5065         (tui_alloc_source_buffer, tui_line_is_displayed)
5066         (tui_addr_is_displayed): Update.
5067         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5068         (tui_check_and_display_highlight_if_needed)
5069         (tui_win_info::make_visible, tui_win_info::refresh)
5070         (tui_refresh_all): Update.
5071         * tui/tui-windata.c (tui_first_data_item_displayed)
5072         (tui_delete_data_content_windows, tui_erase_data_content)
5073         (tui_display_all_data, tui_data_window::refresh_all)
5074         (tui_check_data_values): Update.
5075         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5076         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5077         (tui_win_info::backward_scroll, tui_refresh_all_win)
5078         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5079         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5080         (tui_source_window_base::set_new_height)
5081         (tui_data_window::set_new_height)
5082         (make_invisible_and_set_new_height)
5083         (make_visible_with_new_height, new_height_ok)
5084         (parse_scrolling_args): Update.
5085         * tui/tui-stack.c (tui_show_frame_info): Update.
5086         * tui/tui-source.c (tui_set_source_content)
5087         (tui_set_source_content_nil, tui_source_is_displayed)
5088         (tui_source_window::do_scroll_vertical): Update.
5089         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5090         (tui_display_registers_from, tui_display_reg_element_at_line)
5091         (tui_check_register_values, tui_reg_command): Update.
5092         * tui/tui-layout.c (tui_default_win_height)
5093         (show_source_disasm_command, show_data, init_and_make_win)
5094         (show_source_or_disasm_and_command): Update.
5095         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5096         (tui_redisplay_readline, tui_mld_flush)
5097         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5098         (tui_getc): Update.
5099         * tui/tui-disasm.c (tui_set_disassem_content)
5100         (tui_disasm_window::do_scroll_vertical): Update.
5101         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5102         Now virtual.
5103         (struct tui_win_info): Derive from tui_gen_win_info.
5104         <~tui_win_info>: Mark as override.
5105         <generic>: Remove member.
5106         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5107         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5108         (~tui_data_window, ~tui_win_info)
5109         (tui_free_all_source_wins_content): Update.
5110         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5111
5112 2019-06-25  Tom Tromey  <tom@tromey.com>
5113
5114         * tui/tui-layout.c (init_and_make_win): Use new.
5115         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5116         destructor, initializers.
5117         (tui_alloc_generic_win_info): Don't declare.
5118         * tui/tui-data.c (_locator): Add argument to constructor.
5119         (source_win, disasm_win): New globals.
5120         (exec_info): Remove.
5121         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5122         Update.
5123         (tui_alloc_generic_win_info): Remove.
5124         (init_content_element): Use new.
5125         (tui_win_info::tui_win_info): Update.
5126         (free_content_elements) <case DATA_WIN>: Use delete.
5127
5128 2019-06-25  Tom Tromey  <tom@tromey.com>
5129
5130         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5131         * tui/tui-windata.c (tui_first_data_item_displayed)
5132         (tui_delete_data_content_windows): Update.
5133         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5134         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5135         (tui_display_registers_from, tui_check_register_values): Update.
5136         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5137         pointer.
5138         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5139         window.
5140         (tui_free_data_content): Update.
5141         (free_content_elements) <case DATA_WIN>: Free the window.
5142
5143 2019-06-25  Tom Tromey  <tom@tromey.com>
5144
5145         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5146         Update.
5147         * tui/tui-layout.c (make_command_window)
5148         (show_source_disasm_command, show_data, init_and_make_win)
5149         (show_source_or_disasm_and_command): Update.
5150         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5151         method.
5152         <can_highight, is_highlighted>: Now bool.
5153         (tui_set_win_highlight): Don't declare.
5154         * tui/tui-data.c (tui_set_win_highlight): Remove.
5155
5156 2019-06-25  Tom Tromey  <tom@tromey.com>
5157
5158         * tui/tui-wingeneral.c (make_visible): Remove check of window
5159         type.
5160
5161 2019-06-25  Tom Tromey  <tom@tromey.com>
5162
5163         * tui/tui-win.c (tui_win_info::max_height)
5164         (tui_cmd_window::max_height): New methods.
5165         (new_height_ok): Call max_height.
5166         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5167         <max_height>: New method.
5168
5169 2019-06-25  Tom Tromey  <tom@tromey.com>
5170
5171         * tui/tui-win.c (tui_source_window_base::set_new_height)
5172         (tui_data_window::set_new_height): New methods.
5173         (make_invisible_and_set_new_height): Call set_new_height method.
5174         * tui/tui-data.h (struct tui_win_info)
5175         (struct tui_source_window_base, struct tui_data_window)
5176         <set_new_height>: New method.
5177
5178 2019-06-25  Tom Tromey  <tom@tromey.com>
5179
5180         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5181         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5182         tui_refresh_data_win.
5183         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5184         method.
5185         (tui_refresh_all_win): Call the refresh_all method.
5186         (tui_set_focus): Likewise.
5187         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5188         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5189         Likewise.
5190
5191 2019-06-25  Tom Tromey  <tom@tromey.com>
5192
5193         * tui/tui-winsource.h (tui_refill_source_window)
5194         (tui_set_is_exec_point_at): Don't declare.
5195         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5196         (tui_source_window_base::refill): Rename from
5197         tui_refill_source_window.
5198         (tui_source_window_base::do_scroll_horizontal): Update.
5199         (tui_source_window_base::set_is_exec_point_at): Rename from
5200         tui_set_is_exec_point_at.
5201         (tui_update_all_breakpoint_info): Update.
5202         * tui/tui-stack.c (tui_show_frame_info): Update.
5203         * tui/tui-layout.c (show_data): Add cast.
5204         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5205         * tui/tui-data.h (struct tui_source_window_base) <refill,
5206         set_is_exec_point_at>: New methods.
5207         (tui_source_windows, tui_add_to_source_windows): Update types.
5208         (tui_add_to_source_windows): Remove redundant declaration.
5209         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5210         (tui_source_windows): Change return type.
5211         (tui_clear_source_windows_detail): Update.
5212         (tui_add_to_source_windows): Change type of parameter.
5213         (tui_free_all_source_wins_content): Update.
5214
5215 2019-06-25  Tom Tromey  <tom@tromey.com>
5216
5217         * tui/tui-wingeneral.c (tui_win_info::refresh)
5218         (tui_source_window_base::refresh): New methods.
5219         (tui_refresh_all): Call the refresh method.
5220         * tui/tui-data.h (struct tui_win_info)
5221         (struct tui_source_window_base) <refresh>: New method.
5222
5223 2019-06-25  Tom Tromey  <tom@tromey.com>
5224
5225         * tui/tui.h (tui_is_window_visible): Return bool.
5226         * tui/tui.c (tui_is_window_visible): Return bool.
5227         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5228         (tui_make_visible, tui_make_invisible)
5229         (tui_win_info::make_visible)
5230         (tui_source_window_base::make_visible, make_all_visible)
5231         (tui_make_all_visible, tui_make_all_invisible): Update.
5232         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5233         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5234         bool.
5235         (struct tui_win_info, struct tui_source_window_base)
5236         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5237         * tui/tui-data.c (tui_init_generic_part): Update.
5238
5239 2019-06-25  Tom Tromey  <tom@tromey.com>
5240
5241         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5242         (tui_source_window_base::make_visible): New methods.
5243         (make_all_visible): Make method call.
5244         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5245         (struct tui_source_window_base, struct tui_cmd_window): Override
5246         make_visible.
5247         (tui_win_is_source_type): Don't declare.
5248         * tui/tui-data.c (tui_win_is_source_type): Remove.
5249
5250 2019-06-25  Tom Tromey  <tom@tromey.com>
5251
5252         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5253         NULL check.
5254
5255 2019-06-25  Tom Tromey  <tom@tromey.com>
5256
5257         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5258         Inline constructor.  Add initializers for members.
5259         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5260         constructors; now inline in class.
5261
5262 2019-06-25  Tom Tromey  <tom@tromey.com>
5263
5264         * tui/tui-regs.c (tui_show_registers): Update.
5265         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5266         bool.
5267         * tui/tui-data.c (tui_data_window::clear_detail)
5268         (tui_data_window): Update.
5269
5270 2019-06-25  Tom Tromey  <tom@tromey.com>
5271
5272         * tui/tui-windata.c (tui_display_all_data)
5273         (tui_display_data_from_line, tui_display_data_from)
5274         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5275         Update.
5276         * tui/tui-regs.c (tui_last_regs_line_no)
5277         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5278         (tui_show_registers, tui_show_register_group)
5279         (tui_display_registers_from, tui_display_reg_element_at_line)
5280         (tui_display_registers_from_line, tui_check_register_values)
5281         (tui_reg_next, tui_reg_prev): Update.
5282         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5283         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5284         tui_data_window.
5285         (struct tui_win_info) <detail>: Remove.  Add new fields from
5286         tui_data_info.
5287         (TUI_DATA_WIN): Add cast.
5288         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5289         (~tui_data_window): Simplify.
5290
5291 2019-06-25  Tom Tromey  <tom@tromey.com>
5292
5293         * tui/tui-layout.c (show_source_disasm_command)
5294         (show_source_or_disasm_and_command): Update.
5295         * tui/tui-io.c (update_cmdwin_start_line)
5296         (tui_redisplay_readline): Update.
5297         * tui/tui-data.h (struct tui_command_info): Remove.
5298         (struct tui_win_info) <detail>: Remove command_info member.
5299         (struct tui_data_window) <start_line>: New member, from
5300         tui_command_info.
5301         (TUI_CMD_WIN): Add casts.
5302
5303 2019-06-25  Tom Tromey  <tom@tromey.com>
5304
5305         * tui/tui-winsource.c (tui_update_source_window)
5306         (tui_refill_source_window)
5307         (tui_source_window_base::do_scroll_horizontal)
5308         (tui_update_breakpoint_info, tui_set_exec_info_content)
5309         (tui_show_exec_info_content, tui_erase_exec_info_content)
5310         (tui_clear_exec_info_content): Update.
5311         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5312         Update.
5313         * tui/tui-win.c (make_invisible_and_set_new_height)
5314         (make_visible_with_new_height): Update.
5315         * tui/tui-source.c (tui_set_source_content)
5316         (tui_show_symtab_source): Update.
5317         * tui/tui-layout.c (extract_display_start_addr)
5318         (show_source_disasm_command, show_data)
5319         (make_source_or_disasm_window)
5320         (show_source_or_disasm_and_command): Update.
5321         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5322         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5323         "gdbarch".
5324         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5325         to tui_source_window_base.
5326         (struct tui_win_info) <detail>: Remove source_info member.
5327         (struct tui_source_window_base) <has_locator>: Inline.
5328         Move contents from tui_source_info; rename has_locator member to
5329         m_has_locator.
5330         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5331         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5332         header file.
5333         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5334         Simplify.
5335         (tui_free_all_source_wins_content): Cast to
5336         tui_source_window_base.
5337
5338 2019-06-25  Tom Tromey  <tom@tromey.com>
5339
5340         * tui/tui-win.c (make_invisible_and_set_new_height)
5341         (make_visible_with_new_height): Call has_locator method.
5342         * tui/tui-layout.c (show_source_disasm_command, show_data)
5343         (show_source_or_disasm_and_command): Update for bool change.
5344         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5345         (tui_win_info) <has_locator>: New method.
5346         (struct tui_source_window_base) <has_locator>: New method.
5347         (tui_win_has_locator): Don't declare.
5348         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5349         from tui_win_has_locator.
5350         (tui_source_window_base): Use false, not FALSE.
5351
5352 2019-06-25  Tom Tromey  <tom@tromey.com>
5353
5354         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5355         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5356         clear_detail method directly.
5357         (tui_clear_win_detail): Remove.
5358
5359 2019-06-25  Tom Tromey  <tom@tromey.com>
5360
5361         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5362         "this", not TUI_DISASM_WIN.
5363
5364 2019-06-25  Tom Tromey  <tom@tromey.com>
5365
5366         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5367         declare.
5368         * tui/tui-winsource.c
5369         (tui_source_window_base::do_scroll_horizontal): Rename from
5370         tui_horizontal_source_scroll.
5371         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5372         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5373         from tui_vertical_data_scroll.
5374         * tui/tui-win.h (tui_scroll): Don't declare.
5375         * tui/tui-win.c (tui_win_info::forward_scroll)
5376         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5377         (tui_win_info::right_scroll): Rename and update.
5378         (tui_scroll_forward_command, tui_scroll_backward_command)
5379         (tui_scroll_left_command, tui_scroll_right_command): Update.
5380         (tui_scroll): Remove.
5381         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5382         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5383         from tui_vertical_source_scroll.
5384         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5385         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5386         from tui_vertical_disassem_scroll.
5387         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5388         do_scroll_horizontal>: New methods.
5389         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5390         Likewise.
5391         (struct tui_source_window_base): Add do_scroll_horizontal.
5392         (struct tui_source_window, struct tui_disasm_window): Add
5393         do_scroll_vertical.
5394         (struct tui_data_window, struct tui_cmd_window): Add
5395         do_scroll_horizontal and do_scroll_vertical.
5396         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5397
5398 2019-06-25  Tom Tromey  <tom@tromey.com>
5399
5400         * tui/tui-data.h (struct tui_source_window_base): New struct.
5401         (struct tui_source_window): Derive from tui_source_window_base.
5402         (struct tui_disasm_window): New struct.
5403         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5404         from tui_source_window::clear_detail.
5405         (tui_source_window_base): Rename from tui_source_window.
5406         (~tui_source_window_base): Rename from ~tui_source_window.
5407         (tui_alloc_win_info): Create a tui_disasm_window.
5408
5409 2019-06-25  Tom Tromey  <tom@tromey.com>
5410
5411         * tui/tui-data.h (struct tui_source_window)
5412         (struct tui_data_window): Declare destructors.
5413         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5414         destructors.
5415         (tui_win_info): Simplify.
5416
5417 2019-06-25  Tom Tromey  <tom@tromey.com>
5418
5419         * tui/tui-winsource.c (tui_display_main)
5420         (tui_update_source_windows_with_addr)
5421         (tui_update_all_breakpoint_info): Update.
5422         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5423         (new_height_ok, parse_scrolling_args): Update.
5424         * tui/tui-stack.c (tui_show_frame_info): Update.
5425         * tui/tui-data.h (struct tui_list): Remove.
5426         (tui_source_windows): Return a reference to a std::vector.
5427         * tui/tui-data.c (source_windows): Now a std::vector.
5428         (tui_source_windows): Change return type.
5429         (tui_clear_source_windows): Rewrite.
5430         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5431         (tui_free_all_source_wins_content): Rewrite.
5432
5433 2019-06-25  Tom Tromey  <tom@tromey.com>
5434
5435         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5436         (struct tui_data_window, struct tui_cmd_window): Declare
5437         clear_detail method.
5438         * tui/tui-data.c (tui_source_window::clear_detail)
5439         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5440         methods.
5441         (tui_clear_win_detail): Simplify.
5442
5443 2019-06-25  Tom Tromey  <tom@tromey.com>
5444
5445         * tui/tui-layout.c (make_source_window, make_disasm_window)
5446         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5447         Return the new window.
5448         (show_source_disasm_command, show_data)
5449         (show_source_or_disasm_and_command): Update.
5450
5451 2019-06-25  Tom Tromey  <tom@tromey.com>
5452
5453         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5454         parameter.  Return the new window.
5455         (show_source_disasm_command): Update and remove NULL check.
5456         (show_source_or_disasm_and_command): Update.
5457
5458 2019-06-25  Tom Tromey  <tom@tromey.com>
5459
5460         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5461
5462 2019-06-25  Tom Tromey  <tom@tromey.com>
5463
5464         * tui/tui-data.h (struct tui_win_info): Make constructor
5465         protected.  Make destructor virtual.  Add initializers.
5466         (tui_source_window, tui_data_window, tui_cmd_window): New
5467         classes.
5468         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5469         constructor.  Add "type" parameter.
5470         (tui_source_window, tui_data_window, tui_cmd_window): New
5471         constructors.
5472         (tui_alloc_win_info): Instantiate the appropriate subclass.
5473
5474 2019-06-25  Tom Tromey  <tom@tromey.com>
5475
5476         * tui/tui-win.c (tui_resize_all): Use delete.
5477         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5478         destructor.
5479         (tui_free_window): Don't declare.
5480         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5481         Update.
5482
5483 2019-06-25  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-data.h (struct tui_win_info): Add constructor.
5486         * tui/tui-data.c (tui_alloc_win_info): Use new.
5487         (tui_free_window): Use delete.
5488
5489 2019-06-22  Tom Tromey  <tom@tromey.com>
5490
5491         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5492         declare.
5493         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5494
5495 2019-06-22  Tom Tromey  <tom@tromey.com>
5496
5497         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5498         declare.
5499         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5500
5501 2019-06-22  Tom de Vries  <tdevries@suse.de>
5502
5503         * dwarf2read.c (create_addrmap_from_aranges)
5504         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5505         instead of '%zu'.
5506
5507 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5508
5509         * dwarf2read.h (dwarf2_section_info_def): Remove.
5510         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5511         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5512         std::vector<dwarf2_section_info>.
5513         (struct dwo_file) <~dwo_file>: Remove.
5514         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5515         types field.
5516         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5517         (dwarf2_read_debug_names): Likewise.
5518         (create_debug_types_hash_table): Change parameter type to
5519         array_view, adjust code accordingly.
5520         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5521         (partial_die_info::fixup): Likewise.
5522         (determine_prefix): Likewise.
5523         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5524
5525 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5526
5527         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5528         gdb_bfd_ref_ptr.
5529         <~dwo_file>: Remove call to gdb_bfd_unref.
5530         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5531         gdb_bfd_ref_ptr::get.
5532
5533 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5534
5535         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5536         type to htab_up.
5537         * dwarf2read.c (struct dwo_file): Initialize fields.
5538         <~dwo_file>: New.
5539         (free_dwo_file): Remove, move content to ~dwo_file.
5540         (struct dwo_file_deleter): Remove.
5541         (dwo_file_up>: Remove custom deleter.
5542         (free_dwo_files): Remove.
5543         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5544         dwo_files.
5545         (process_skeletonless_type_units): Call unique_ptr::get.
5546         (allocate_dwo_file_hash_table): Add deleter to created hash
5547         table.  Change return type to htab_up.
5548         (lookup_dwo_file_slot): Don't memset dwo_file, call
5549         unique_ptr::get.
5550         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5551         (create_dwo_unit_in_dwp_v2): Likewise.
5552         (open_and_init_dwo_file): Likewise.
5553         (free_dwo_file_from_slot): Remove.
5554
5555 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5556
5557         * dwarf2read.h (struct dwarf2_section_info) <readin,
5558         is_virtual>: Change type to bool.
5559         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5560         true instead of 1.
5561
5562 2019-06-19  Tom Tromey  <tom@tromey.com>
5563
5564         * tui/tui-data.h (tui_init_content_element): Don't declare.
5565
5566 2019-06-19  Tom Tromey  <tom@tromey.com>
5567
5568         * tui/tui-data.h (tui_init_win_info): Don't declare.
5569
5570 2019-06-19  Tom de Vries  <tdevries@suse.de>
5571
5572         * dwarf2read.h (abstract_to_concrete): Change type to
5573         std::unordered_map<sect_offset, std::vector<sect_offset>,
5574         gdb::hash_enum<sect_offset>>.
5575
5576 2019-06-19  Tom Tromey  <tromey@adacore.com>
5577
5578         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5579         EVAL_AVOID_SIDE_EFFECTS specially.
5580
5581 2019-06-19  Tom Tromey  <tromey@adacore.com>
5582
5583         * source-cache.c (highlighter): New global.
5584         (source_cache::get_source_lines): Create a highlighter on demand.
5585
5586 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5587
5588         * defs.h (deprecated_interactive_hook): Delete declaration.
5589         * interps.c (clear_interpreter_hooks): Remove use of
5590         deprecated_interactive_hook.
5591         * top.c (deprecated_interactive_hook): Delete definition.
5592         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5593
5594 2019-06-18  Tom de Vries  <tdevries@suse.de>
5595
5596         PR gdb/24515
5597         * dwarf2read.h (abstract_to_concrete): Change type from
5598         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5599         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5600         * dwarf2read.c (read_variable): Update.
5601         (dwarf2_fetch_die_loc_sect_off): Update.
5602
5603 2019-06-17  Tom de Vries  <tdevries@suse.de>
5604
5605         PR gdb/24617
5606         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5607         accessing parent[parent_len - 1].
5608
5609 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5610
5611         PR gdb/24364
5612         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5613         call dtrace_process_dof with NULL dof.
5614
5615 2019-06-16  Tom de Vries  <tdevries@suse.de>
5616
5617         PR gdb/24445
5618         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5619
5620 2019-06-16  Tom Tromey  <tom@tromey.com>
5621
5622         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5623         (make_all_visible): Use address of member.
5624
5625 2019-06-16  Tom Tromey  <tom@tromey.com>
5626
5627         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5628         (tui_free_window, free_content, free_content_elements): Remove
5629         unnecessary cast.
5630         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5631         cast.
5632         * tui/tui-regs.c (tui_show_register_group)
5633         (tui_display_registers_from, tui_display_reg_element_at_line):
5634         Remove unnecessary cast.
5635
5636 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5637
5638         * linux-nat.c (normal_mask): Delete.
5639         (_initialize_linux_nat): Don't initialise normal_mask.
5640
5641 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5642
5643         PR gdb/24445
5644         * dwarf-index-write.h (write_psymtabs_to_index): Add
5645         dwz_basename parameter.
5646         * dwarf-index-write.c (write_gdbindex): Move file writing to
5647         write_gdbindex_1.  Change return type void.
5648         (assert_file_size): Move up, remove filename parameter.
5649         (write_gdbindex_1): New function.
5650         (write_debug_names): Change return type to void, call
5651         assert_file_size.
5652         (struct index_wip_file): New struct.
5653         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
5654         file logic to index_wip_file.  Write index for dwz file if
5655         needed.
5656         (save_gdb_index_command): Pass basename of dwz file, if present.
5657         * dwarf-index-cache.c (index_cache::store): Obtain and pass
5658         build-id of dwz file, if present.
5659         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
5660         (dwarf2_get_dwz_file): Likewise.
5661         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
5662         (dwarf2_get_dwz_file): Likewise.
5663
5664 2019-06-16  Tom Tromey  <tom@tromey.com>
5665
5666         * coffread.c (process_coff_symbol): Use xstrdup.
5667         * value.c (create_internalvar): Use xstrdup.
5668
5669 2019-06-16  Tom Tromey  <tom@tromey.com>
5670
5671         * valops.c (value_cast, value_slice): Remove unnecessary cast.
5672         * breakpoint.c (stopin_command, stopat_command)
5673         (until_break_command, decode_location_default): Remove unnecessary
5674         cast.
5675         * utils.c (subset_compare): Remove unnecessary cast.
5676         * ada-lang.c (ada_update_initial_language): Remove unnecessary
5677         cast.
5678         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
5679         cast.
5680         * infcmd.c (path_command): Remove unnecessary cast.
5681         * coffread.c (decode_type): Remove unnecessary cast.
5682         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
5683         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
5684         * tui/tui-stack.c (tui_show_locator_content)
5685         (tui_show_frame_info): Remove unnecessary cast.
5686         * tui/tui-win.c (tui_scroll_forward_command)
5687         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
5688         (parse_scrolling_args): Remove unnecessary cast.
5689         * tui/tui-data.c (init_win_info, tui_del_window)
5690         (tui_free_window, tui_del_data_windows, tui_free_data_content)
5691         (free_content_elements): Remove unnecessary cast.
5692         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
5693         unnecessary cast.
5694         * tui/tui-source.c (tui_set_source_content)
5695         (tui_vertical_source_scroll): Remove unnecessary cast.
5696         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
5697         cast.
5698         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
5699         * tui/tui-regs.c (tui_display_registers_from)
5700         (tui_display_register): Remove unnecessary cast.
5701         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
5702         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
5703         (make_visible): Remove unnecessary cast.
5704         * tui/tui-winsource.c (tui_erase_source_content)
5705         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
5706         unnecessary cast.
5707         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
5708         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
5709         * stabsread.c (read_type, read_array_type, read_range_type):
5710         Remove unnecessary cast.
5711         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
5712         (parse_symbol, parse_type, upgrade_type, parse_external)
5713         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
5714         unnecessary cast.
5715         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
5716
5717 2019-06-16  Tom Tromey  <tom@tromey.com>
5718
5719         * tui/tui-data.c (tui_alloc_generic_win_info)
5720         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
5721         checks.
5722
5723 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
5724             Andrew Burgess  <andrew.burgess@embecosm.com>
5725
5726         * f-typeprint.c (f_print_type): Don't return early for not
5727         associated or not allocated types.
5728         (f_type_print_varspec_suffix): Add print_rank parameter and print
5729         ranks of array types in case they dangling.
5730         (f_type_print_base): Add print_rank parameter.
5731
5732 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5733
5734         * NEWS: Mention new MI commands.
5735         * break-catch-throw.c (enum exception_event_kind): Move to
5736         breakpoint.h.
5737         (print_mention_exception_catchpoint): Output text as a single
5738         message.
5739         (catch_exception_command_1): Rename to...
5740         (catch_exception_event): ...this, make non-static, update header
5741         command, and change some parameter types.
5742         (catch_catch_command): Update for changes to
5743         catch_exception_command_1.
5744         (catch_throw_command): Likewise.
5745         (catch_rethrow_command): Likewise.
5746         * breakpoint.c (enum exception_event_kind): Delete.
5747         * breakpoint.h (enum exception_event_kind): Moved here from
5748         break-catch-throw.c.
5749         (catch_exception_event): Declare.
5750         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
5751         (mi_cmd_catch_throw): New function.
5752         (mi_cmd_catch_rethrow): New function.
5753         (mi_cmd_catch_catch): New function.
5754         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
5755         'catch-catch' entries.
5756         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
5757         (mi_cmd_catch_rethrow): Declare.
5758         (mi_cmd_catch_catch): Declare.
5759
5760 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5761
5762         * annotate.c (annotate_source_line): Change return type to void,
5763         update implementation to match.
5764         * annotate.h (annotate_source_line): Change return type to void,
5765         update header comment.
5766         * stack.c (print_frame_info): Don't change what frame information
5767         is printed based on whether annotations are on or not.
5768
5769 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5770
5771         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
5772         (annotate_source): Make static.
5773         (annotate_source_line): Moved from source.c and renamed from
5774         identify_source_line.  Update the return type.
5775         * annotate.h (annotate_source): Delete declaration.
5776         (annotate_source_line): Declaration moved from source.h, and
5777         renamed from identify_source_line.  Return type updated.
5778         * source.c (identify_source_line): Moved to annotate.c and renamed
5779         to annotate_source_line.
5780         (info_line_command): Remove check of annotation_level.
5781         * source.h (identify_source_line): Move declaration to annotate.h
5782         and rename to annotate_source_line.
5783         * stack.c: Add 'annotate.h' include.
5784         (print_frame_info): Remove check of annotation_level before
5785         calling annotate_source_line.
5786
5787 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5788
5789         * source-cache.c (source_cache::get_plain_source_lines): Use
5790         open_source_file_with_line_charpos instead of just
5791         open_source_file, remove call to find_source_lines.
5792         (source_cache::get_source_lines): Likewise.
5793         * source.c (find_source_lines): Make static.
5794         (get_filename_and_charpos): Renamed into...
5795         (open_source_file_with_line_charpos): ..this along with changes to
5796         return a scoped_fd, and some other minor clean ups.
5797         (identify_source_line): Use open_source_file_with_line_charpos.
5798         (search_command_helper): Use open_source_file_with_line_charpos
5799         instead of just open_source_file, remove call to
5800         find_source_lines.
5801         * source.h (open_source_file_with_line_charpos): Declare new
5802         function.
5803         (find_source_lines): Delete declaration.
5804
5805 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
5806
5807         * source.c (get_filename_and_charpos): Remove fullname
5808         parameter.
5809         (identify_source_line): Update call to get_filename_and_charpos.
5810
5811 2019-06-14  Tom Tromey  <tromey@adacore.com>
5812
5813         PR gdb/24502:
5814         * ui-style.h (skip_ansi_escape): Update comment.
5815         * ui-file.h (class no_terminal_escape_file): New class.
5816         * ui-file.c (no_terminal_escape_file::write)
5817         (no_terminal_escape_file::puts): New methods.
5818         * cli/cli-logging.c (handle_redirections): Use
5819         no_terminal_escape_file.
5820
5821 2019-06-14  Tom Tromey  <tromey@adacore.com>
5822
5823         * NEWS: Move convenience variable news above Python news.
5824
5825 2019-06-14  Tom Tromey  <tom@tromey.com>
5826
5827         * gnulib: Move directory to top-level.
5828         * configure.ac: Don't configure gnulib.
5829         * configure: Rebuild.
5830         * common/common-defs.h: Use new path to gnulib.
5831         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
5832         (GNULIB_H): Remove.
5833         (INCGNU): Look in new gnulib location.
5834         (HFILES_NO_SRCDIR): Remove gnulib files.
5835         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
5836         (generated_files): Remove GNULIB_H.
5837         ($(LIBGNU), all-lib): Remove targets.
5838         (distclean): Don't mention GNULIB_BUILDDIR.
5839         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
5840
5841 2019-06-14  Tom Tromey  <tromey@adacore.com>
5842
5843         * symfile.c (add_symbol_file_command): Remove obsolete comment.
5844         Warn if symbol file does not provide any symbols.
5845
5846 2019-06-14  Tom Tromey  <tromey@adacore.com>
5847
5848         * source.c (find_and_open_source): Respect basenames_may_differ.
5849
5850 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
5851
5852         * annotate.c (annotate_breakpoints_invalid): Make use of
5853         scoped_restore_terminal_state.
5854         (annotate_frames_invalid): Likewise.
5855
5856 2019-06-14  Tom Tromey  <tromey@adacore.com>
5857
5858         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
5859         allow assignment to an internalvar.
5860
5861 2019-06-14  Tom Tromey  <tromey@adacore.com>
5862
5863         * ada-lex.l: Allow "_" in attribute names.
5864
5865 2019-06-14  Tom Tromey  <tromey@adacore.com>
5866
5867         PR gdb/24653:
5868         * regcache.c (registers_changed): Don't call alloca.
5869         * top.c (execute_command): Don't call alloca.
5870
5871 2019-06-13  Pedro Alves  <palves@redhat.com>
5872
5873         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
5874         'expression'.  When parsing an expression, error out if there's
5875         junk after "unlimited".
5876         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
5877         (do_set_command): Adjust calls to is_unlimited_literal.
5878
5879 2019-06-13  Pedro Alves  <palves@redhat.com>
5880
5881         * compile/compile.c (make_compile_options_def_group): Add braces
5882         around array_view initializer.
5883         * thread.c (make_thread_apply_all_options_def_group)
5884         (make_thread_apply_all_options_def_group): Likewise.
5885
5886 2019-06-13  Pedro Alves  <palves@redhat.com>
5887
5888         * NEWS (New commands): Mention "maint test-options
5889         require-delimiter", "maint test-options unknown-is-error", "maint
5890         test-options unknown-is-operand" and "maint show
5891         test-options-completion-result".
5892         (New command options, command completion): New section.
5893         (Completion improvements): New section.
5894         Mention that you can abbreviate "unlimited".
5895
5896 2019-06-13  Pedro Alves  <palves@redhat.com>
5897
5898         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
5899         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
5900         * unittests/cli-utils-selftests.c (test_parse_flags)
5901         (test_parse_flags_qcs): Delete.
5902         (test_cli_utils): Don't call deleted functions.
5903
5904 2019-06-13  Pedro Alves  <palves@redhat.com>
5905
5906         * thread.c: Include "cli/cli-option.h".
5907         (tp_array_compar_ascending): Global.
5908         (tp_array_compar): Delete function.
5909         (tp_array_compar_ascending, tp_array_compar_descending): New
5910         functions.
5911         (ascending_option_def, qcs_flag_option_def)
5912         (thr_qcs_flags_option_defs)
5913         (make_thread_apply_all_options_def_group)
5914         (make_thread_apply_options_def_group): New.
5915         (thread_apply_all_command): Use gdb::option::process_options.
5916         (thread_apply_command_completer)
5917         (thread_apply_all_command_completer): New.
5918         (thread_apply_command): Use gdb::option::process_options.
5919         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
5920         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
5921         to generate help text of "thread apply".  Adjust "taas"'s help.
5922         * tid-parse.c (tid_range_parser::in_thread_range): New method.
5923         * tid-parse.h (tid_range_parser::in_thread_range): New method.
5924
5925 2019-06-13  Pedro Alves  <palves@redhat.com>
5926
5927         * thread.c (thread_apply_command): Check for invalid TID with
5928         isdigit instead of !isalpha.
5929
5930 2019-06-13  Pedro Alves  <palves@redhat.com>
5931
5932         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
5933         (validate_flags_qcs): New.
5934         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
5935         (validate_flags_qcs): Declare.
5936         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
5937         (make_frame_apply_options_def_group): New.
5938         (frame_apply_command_count): Process options with
5939         gdb::option::process_options.
5940         (frame_apply_completer): New.
5941         (frame_apply_level_completer, frame_apply_all_completer)
5942         (frame_apply_completer): New.
5943         (_initialize_stack): Update help of "frame apply", "frame apply
5944         level", "frame apply all" and "faas" to mention supported options
5945         and install command completers.
5946         * stack.h (frame_apply_all_completer): Declare.
5947         * thread.c: Include "stack.h".
5948         (tfaas_command): Add "--".
5949         (_initialize_thread): Update help "tfaas" to mention supported
5950         options and install command completer.
5951
5952 2019-06-13  Pedro Alves  <palves@redhat.com>
5953
5954         * completer.c (complete_nested_command_line): New.
5955         (gdb_completion_word_break_characters_throw): Add assertion.
5956         * completer.h (complete_nested_command_line): Declare.
5957
5958 2019-06-13  Pedro Alves  <palves@redhat.com>
5959
5960         * stack.c (parse_backtrace_qualifiers): New.
5961         (backtrace_command): Use it.
5962         (backtrace_command_completer): Complete on qualifiers.
5963
5964 2019-06-13  Pedro Alves  <palves@redhat.com>
5965
5966         * frame.c: Include "cli/cli-option.h.
5967         (user_set_backtrace_options): New.
5968         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
5969         Delete.
5970         (get_prev_frame): Adjust.
5971         (boolean_option_def, uinteger_option_def)
5972         (set_backtrace_option_defs): New.
5973         (_initialize_frame): Adjust and use
5974         gdb::option::add_setshow_cmds_for_options to install "set
5975         backtrace past-main" and "set backtrace past-entry".
5976         * frame.h: Include "cli/cli-option.h".
5977         (struct frame_print_options): Forward declare.
5978         (print_frame_arguments_all, print_frame_arguments_scalars)
5979         (print_frame_arguments_none): Declare.
5980         (print_entry_values): Delete declaration.
5981         (struct frame_print_options, user_frame_print_options): New.
5982         (struct set_backtrace_options): New.
5983         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
5984         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
5985         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
5986         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
5987         (list_args_or_locals): Add frame_print_options parameter.
5988         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
5989         * python/py-framefilter.c (enumerate_args): Pass down
5990         USER_FRAME_PRINT_OPTIONS.
5991         * stack.c: Include "cli/cli-option.h".
5992         (print_frame_arguments_all, print_frame_arguments_scalars)
5993         (print_frame_arguments_none): Declare.
5994         (print_raw_frame_arguments, print_entry_values): Delete.
5995         (user_frame_print_options): New.
5996         (boolean_option_def, enum_option_def, frame_print_option_defs):
5997         New.
5998         (struct backtrace_cmd_options): New.
5999         (bt_flag_option_def): New.
6000         (backtrace_command_option_defs): New.
6001         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6002         (print_frame_arg, read_frame_arg, print_frame_args)
6003         (print_frame_info, print_frame): Add frame_print_options parameter
6004         and use it.
6005         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6006         (backtrace_command_1): Add frame_print_options and
6007         backtrace_cmd_options parameters and use them.
6008         (make_backtrace_options_def_group): New.
6009         (backtrace_command): Process command options with
6010         gdb::option::process_options.
6011         (backtrace_command_completer): New.
6012         (_initialize_stack): Extend "backtrace"'s help to mention
6013         supported options.  Install completer for "backtrace".
6014         Install some settings commands with add_setshow_cmds_for_options.
6015
6016 2019-06-13  Pedro Alves  <palves@redhat.com>
6017
6018         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6019         and that "set/show print raw frame-arguments" are now deprecated.
6020
6021         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6022         command.
6023         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6024         * stack.c (_initialize_stack): Install "set/show print
6025         raw-frame-arguments", and deprecate "set/show print raw
6026         frame-arguments".
6027         * valprint.c (_initialize_valprint): Deprecate "set/show print
6028         raw".
6029
6030 2019-06-13  Pedro Alves  <palves@redhat.com>
6031
6032         * compile/compile.c (struct compile_options): New.
6033         (compile_flag_option_def, compile_command_option_defs)
6034         (make_compile_options_def_group): New.
6035         (compile_file_command): Handle options with
6036         gdb::option::process_options.
6037         (compile_file_command_completer): New function.
6038         (compile_code_command): Handle options with
6039         gdb::option::process_options.
6040         (compile_code_command_completer): New function.
6041         (_initialize_compiler): Install completers for "compile code" and
6042         "compile file".  Mention available options in "compile code" and
6043         "compile code"'s help.
6044         * completer.c (advance_to_completion_word): New, factored out from
6045         ...
6046         (advance_to_expression_complete_word_point): ... this.
6047         (advance_to_filename_complete_word_point): New.
6048         * completer.h (advance_to_filename_complete_word_point): New
6049         declaration.
6050
6051 2019-06-13  Pedro Alves  <palves@redhat.com>
6052
6053         * compile/compile.c: Include "cli/cli-option.h".
6054         (compile_print_value): Scope data pointer is now a
6055         value_print_options pointer; adjust.
6056         (compile_print_command): Process options.  Scope data pointer is
6057         now a value_print_options pointer; adjust.
6058         (_initialize_compile): Update "compile print"'s help to include
6059         supported options.  Install a completer for "compile print".
6060         * cp-valprint.c (show_vtblprint, show_objectprint)
6061         (show_static_field_print): Delete.
6062         (_initialize_cp_valprint): Don't install "set print
6063         static-members", "set print vtbl", "set print object" here.
6064         * printcmd.c: Include "cli/cli-option.h" and
6065         "common/gdb_optional.h".
6066         (print_command_parse_format): Rework to fill in a
6067         value_print_options instead of a format_data.
6068         (print_value): Change parameter type from format_data pointer to
6069         value_print_options reference.  Adjust.
6070         (print_command_1): Process options.  Adjust to pass down a
6071         value_print_options.
6072         (print_command_completer): New.
6073         (_initialize_printcmd): Install print_command_completer as
6074         handle_brkchars completer for the "print" command.  Update
6075         "print"'s help to include supported options.
6076         * valprint.c: Include "cli/cli-option.h".
6077         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6078         here from cp-valprint.c.
6079         (boolean_option_def, uinteger_option_def)
6080         (value_print_option_defs, make_value_print_options_def_group):
6081         New.  Use gdb::option::add_setshow_cmds_for_options to install
6082         "set print elements", "set print null-stop", "set print repeats",
6083         "set print pretty", "set print union", "set print array", "set
6084         print address", "set print symbol", "set print array-indexes".
6085         * valprint.h: Include <string> and "cli/cli-option.h".
6086         (make_value_print_options_def_group): Declare.
6087         (print_value): Change parameter type from format_data pointer to
6088         value_print_options reference.
6089         (print_command_completer): Declare.
6090
6091 2019-06-13  Pedro Alves  <palves@redhat.com>
6092
6093         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6094         (COMMON_SFILES): Add maint-test-settings.c.
6095         * cli/cli-decode.c (boolean_enums): New global, factored out from
6096         ...
6097         (add_setshow_boolean_cmd): ... here.
6098         * cli/cli-decode.h (boolean_enums): Declare.
6099         * cli/cli-option.c: New file.
6100         * cli/cli-option.h: New file.
6101         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6102         factored out from ...
6103         (parse_cli_boolean_value(const char *)): ... this.
6104         (is_unlimited_literal): Change parameter type to pointer to
6105         pointer.  Adjust and advance ARG pointer.
6106         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6107         (parse_cli_var_enum): New, factored out from ...
6108         (do_set_command): ... this.  Adjust.
6109         * cli/cli-setshow.h (parse_cli_boolean_value)
6110         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6111         (parse_cli_var_enum): Declare.
6112         * cli/cli-utils.c: Include "cli/cli-option.h".
6113         (get_ulongest): New.
6114         * cli/cli-utils.h (get_ulongest): Declare.
6115         (check_for_argument): New overloads.
6116         * maint-test-options.c: New file.
6117
6118 2019-06-13  Pedro Alves  <palves@redhat.com>
6119
6120         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6121         parse a range if "-" is at the end of the string.
6122
6123 2019-06-13  Pedro Alves  <palves@redhat.com>
6124
6125         * cli/cli-setshow.c (parse_auto_binary_operation)
6126         (parse_cli_boolean_value): Don't allow "o".
6127
6128 2019-06-13  Pedro Alves  <palves@redhat.com>
6129
6130         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6131         * NEWS: Mention maint test-settings KIND.
6132         * maint-test-settings.c: New file.
6133
6134 2019-06-13  Pedro Alves  <palves@redhat.com>
6135
6136         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6137         completer.
6138         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6139         "set" completers.
6140
6141 2019-06-13  Pedro Alves  <palves@redhat.com>
6142
6143         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6144         after item.
6145
6146 2019-06-13  Pedro Alves  <palves@redhat.com>
6147
6148         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6149
6150 2019-06-13  Pedro Alves <palves@redhat.com>
6151
6152         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6153         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6154         call.
6155         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6156         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6157         calls.
6158         (check_for_argument): Skip spaces after argument.
6159
6160 2019-06-13  Pedro Alves  <palves@redhat.com>
6161
6162         * thread.c (thread_apply_command): Adjust TID parsing.
6163         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6164         detected before end of string.
6165         (tid_is_in_list): Error out if LIST is invalid.
6166
6167 2019-06-13  Pedro Alves  <palves@redhat.com>
6168
6169         * completer.c (complete_line_internal_1): Rewind completion word
6170         point.
6171         (completion_tracker::advance_custom_word_point_by): Change
6172         parameter type to int.
6173         * completer.h (completion_tracker::advance_custom_word_point_by):
6174         Likewise.
6175
6176 2019-06-13  Pedro Alves  <palves@redhat.com>
6177
6178         * completer.c (advance_to_completion_word): Handle delimiters.
6179
6180 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6181
6182         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6183
6184 2019-06-11  Tom Tromey  <tom@tromey.com>
6185
6186         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6187         (xmalloc_failed): Move to alloc.c.
6188         * alloc.c: New file.
6189         * Makefile.in (COMMON_SFILES): Add alloc.c.
6190
6191 2019-06-11  Tom Tromey  <tom@tromey.com>
6192
6193         * nat/linux-waitpid.c: Don't include server.h.
6194         (linux_debug): Remove.
6195         (my_waitpid): Update.
6196
6197 2019-06-11  Tom Tromey  <tromey@adacore.com>
6198
6199         * infcall.c (_initialize_infcall): Remove trailing newline from
6200         help.
6201         * user-regs.c (_initialize_user_regs): Remove trailing newline
6202         from help.
6203         * typeprint.c (_initialize_typeprint): Remove trailing newline
6204         from help.
6205         * reverse.c (_initialize_reverse): Remove trailing newlines from
6206         help.
6207         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6208         from help.
6209         * language.c (add_set_language_command): Remove trailing newline
6210         from help.
6211         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6212         help.
6213         * disasm.c (_initialize_disasm): Remove trailing newline from
6214         help.
6215         * top.c (init_main): Remove trailing newline from help.
6216         * interps.c (_initialize_interpreter): Remove trailing newline
6217         from help.
6218         * btrace.c (_initialize_btrace): Remove trailing newlines from
6219         help.
6220         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6221         from help.
6222         * python/python.c (_initialize_python): Remove trailing newline
6223         from help.
6224         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6225         help.
6226         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6227         from help.  Reformat some text.
6228         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6229         from help.
6230         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6231         newline from help.
6232
6233 2019-06-11  Tom Tromey  <tromey@adacore.com>
6234
6235         * darwin-nat.c (darwin_decode_exception_message)
6236         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6237
6238 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6239
6240         * valops.c (value_slice): Check for not allocated or not
6241         associated values.
6242
6243 2019-06-10  Tom de Vries  <tdevries@suse.de>
6244
6245         PR gdb/24618
6246         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6247         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6248         invalid.
6249
6250 2019-06-10  Tom de Vries  <tdevries@suse.de>
6251
6252         PR gdb/24611
6253         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6254         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6255
6256 2019-06-10  Tom de Vries  <tdevries@suse.de>
6257
6258         PR symtab/24545
6259         * symtab.c (struct demangled_name_entry): Add language field.
6260         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6261         static minimal symbol".  Set and use language field.
6262
6263 2019-06-10  Tom Tromey  <tromey@adacore.com>
6264
6265         * ada-lang.c (_initialize_ada_language): Update help text.
6266
6267 2019-06-10  Tom Tromey  <tromey@adacore.com>
6268
6269         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6270         with a newline.
6271         * guile/guile.c (handle_boot_error): Don't end warning with a
6272         newline.
6273         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6274         warning with a newline.
6275         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6276         newline.
6277         (s12z_frame_cache): Likewise.
6278         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6279         a newline.
6280         * solib-svr4.c (disable_probes_interface): Don't end warning with
6281         a newline.
6282         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6283         newline.
6284         * python/python.c (do_finish_initialization): Don't end warning
6285         with a newline.
6286
6287 2019-06-10  Tom Tromey  <tom@tromey.com>
6288
6289         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6290         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6291         gdbpy_enter.
6292
6293 2019-06-10  Tom Tromey  <tromey@adacore.com>
6294
6295         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6296         data.
6297         (elf_new_init): Don't call stabsread_new_init.
6298         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6299         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6300         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6301
6302 2019-06-10  Tom de Vries  <tdevries@suse.de>
6303
6304         PR symtab/16264
6305         PR symtab/24517
6306         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6307
6308 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6309
6310         * source.c (find_and_open_source): Also rewrite relative file
6311         names.
6312
6313 2019-04-26  Amos Bird  <amosbird@gmail.com>
6314
6315         * annotate.c (annotate_thread_exited): Add "thread-exited"
6316         annotation.
6317
6318 2019-06-06  Tom Tromey  <tromey@adacore.com>
6319
6320         * maint.h (class scoped_command_stats): Use
6321         DISABLE_COPY_AND_ASSIGN.
6322         <print_time>: New method.
6323         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6324         print_time.
6325         (scoped_command_stats::print_time): New method.
6326
6327 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6328
6329         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6330         instructions of lengths 6 or 8 bytes.
6331
6332 2019-06-04  Pedro Alves  <palves@redhat.com>
6333
6334         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6335
6336         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6337         * breakpoint.c (condition_completer): Likewise.
6338         * cli/cli-dump.c (scan_expression): Likewise.
6339         * common/filestuff.c (mkdir_recursive): Likewise.
6340         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6341         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6342         (gdb_abspath): Likewise.
6343         * compile/compile-cplus-types.c
6344         (compile_cplus_instance::decl_name): Likewise.
6345         * completer.c (complete_explicit_location):
6346         (signal_completer, reg_or_group_completer_1): Likewise.
6347         * cp-support.c (cp_remove_params_if_any): Likewise.
6348         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6349         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6350         * infcmd.c (strip_bg_char): Likewise.
6351         * linespec.c (copy_token_string): Likewise.
6352         * mi/mi-main.c (output_cores): Likewise.
6353         * psymtab.c (psymtab_search_name):
6354         * symfile.c (test_set_ext_lang_command): Likewise.
6355         * target.c (target_fileio_read_stralloc): Likewise.
6356         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6357         * value.c (complete_internalvar): Likewise.
6358
6359 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6360
6361         Add objfile property to gdb.Type.
6362         * NEWS: Mention Python API addition.
6363         * python/py-type.c (typy_get_objfile): New method.
6364
6365 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6366
6367         * NEWS: Mention the new set|show style [title|highlight].
6368         Mention changes to "show style", "help" and "apropos".
6369
6370 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6371
6372         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6373         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6374         instead of print_help_for_command.
6375         (print_doc_of_command): New function.
6376         (help_list): Add 'apropos -v word' suggestion.
6377         (print_help_for_command): Style the command name using title style.
6378         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6379         (_initialize_cli_cmds): Describe -v in apropos_command help.
6380
6381 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6382
6383         * cli/cli-style.h (cli_style_option): Add name in constructor,
6384         add m_name class member, add constructor with intensity,
6385         add name class function.
6386         (cli_style_option::add_setshow_commands): Remove name argument.
6387         (highlight_style, title_style): New styles.
6388         * cli/cli-style.c (do_show): New function that shows a style
6389         characteristic styling the style name with itself.
6390         (set_style_name): New function.
6391         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6392         Update all callers according to the changes in cli/cli-style.h.
6393         * utils.h (fputs_highlighted): New function.
6394         * utils.c (fputs_highlighted): Likewise.
6395
6396 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6397
6398         * NEWS: Mention new pipe command and new convenience variables.
6399
6400 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6401
6402         * cli/cli-cmds.c (pipe_command): New function.
6403         (_initialize_cli_cmds): Call add_com for pipe_command.
6404         Define | as an alias for pipe.
6405         (exit_status_set_internal_vars): New function.
6406         (shell_escape): Call exit_status_set_internal_vars.
6407         cli/cli-decode.c (find_command_name_length): Recognize | as
6408         a single character command.
6409
6410 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6411
6412         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6413         top.c (execute_command_to_ui_file): New function, mostly a copy
6414         of execute_command_to_string.
6415         (execute_command_to_string): Implement by calling
6416         execute_command_to_ui_file.
6417
6418 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6419
6420         * top.h (saved_command_line): Remove declaration.
6421         * top.c (previous_saved_command_line, previous_repeat_arguments):
6422         New variables.
6423         (saved_command_line): Make static, define together with other
6424         'repeat variables'.
6425         (dont_repeat): Clear repeat_arguments.
6426         (repeat_previous, get_saved_command_line, save_command_line):
6427         New functions.
6428         (gdb_init): Initialize saved_command_line
6429         and previous_saved_command_line.
6430         * main.c (captured_main_1): Remove saved_command_line initialization.
6431         * event-top.c (handle_line_of_input): Update to use
6432         the new 'repeat' related functions instead of direct access to
6433         saved_command_line.
6434         * command.h (repeat_previous, get_saved_command_line,
6435         save_command_line): New declarations.
6436         (dont_repeat): Add comment.
6437
6438 2019-05-30  Tom Tromey  <tromey@adacore.com>
6439
6440         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6441         Fix comment.
6442         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6443
6444 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6445
6446         PR cli/24587
6447         * completer.c (complete): Initialize variable word.
6448
6449 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6450
6451         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6452         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6453         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6454         'body' is NULL to the outter 'if', protecting the '!is_define'
6455         situation as well.
6456
6457 2019-05-29  Tom Tromey  <tromey@adacore.com>
6458
6459         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6460         (dwarf_unknown): New function.
6461         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6462         (dwarf_type_encoding_name): Use dwarf_unknown.
6463
6464 2019-05-29  Tom Tromey  <tromey@adacore.com>
6465
6466         PR c++/20020:
6467         * cp-valprint.c (cp_print_value_fields): Call
6468         cp_print_static_field inside "try".
6469
6470 2019-05-29  Tom Tromey  <tromey@adacore.com>
6471
6472         * inflow.c (struct terminal_info): Add default operator=.
6473         * configure: Rebuild.
6474         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6475         -Wdeprecated-copy-dtor, -Wredundant-move.
6476
6477 2019-05-29  Tom Tromey  <tromey@adacore.com>
6478
6479         * NEWS: Add entry.
6480         * infcmd.c (print_return_value_1): Handle finish_print
6481         option.
6482         (show_print_finish): New function.
6483         (_initialize_infcmd): Add "set/show print finish" commands.
6484         * valprint.c (user_print_options): Initialize new member.
6485         * valprint.h (struct value_print_options) <finish_print>: New
6486         member.
6487
6488 2019-05-28  Tom Tromey  <tromey@adacore.com>
6489
6490         * ada-lang.c (ada_remove_Xbn_suffix)
6491         (find_old_style_renaming_symbol)
6492         (parse_old_style_renaming): Remove.
6493         (ada_find_renaming_symbol): Don't call
6494         find_old_style_renaming_symbol.
6495         (ada_is_renaming_symbol): Rename from
6496         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6497         bool.  Now static.
6498         (ada_read_var_value): Update and simplify.
6499         * ada-exp.y (write_var_or_type): Remove old code.
6500
6501 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6502
6503         * event-top.c: Remove include comment.
6504         * inflow.c (class scoped_ignore_sigttou): Move from here...
6505         * inflow.h (class scoped_ignore_sigttou): ...to here.
6506         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6507         * top.c:  Remove include comment.
6508
6509 2019-05-27  Tom Tromey  <tom@tromey.com>
6510
6511         * NEWS: Fix typo.
6512
6513 2019-05-22  Tom Tromey  <tromey@adacore.com>
6514
6515         * target.c (target_follow_exec): Constify parameter.
6516         * target-delegates.c: Rebuild.
6517         * remote.c (remote_target::follow_exec): Constify parameter.
6518         * infrun.c (follow_exec): Constify parameter.
6519         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6520         (target_follow_exec): Likewise.
6521
6522 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6523
6524         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6525         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6526
6527 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6528
6529         * NEWS: Add debugredirect and testsuite sections.
6530
6531 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6532
6533         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6534         target descriptions using exclusively floating point register name
6535         aliases.
6536
6537 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6538
6539         PR gdb/18644:
6540         * f-lang.c (build_fortran_types): Handle the case where
6541         gdbarch_floatformat_for_type returns a nullptr.
6542
6543 2019-05-21  Tom de Vries  <tdevries@suse.de>
6544
6545         PR cli/24587
6546         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6547
6548 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6549
6550         PR gdb/18644:
6551         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6552         16-byte floats.
6553         * i386-tdep.c (i386_floatformat_for_type): Use
6554         floatformats_ia64_quad for the 16-byte floating point component
6555         within a fortran 32-byte complex number.
6556
6557 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6558
6559         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6560         delete default constructor.
6561         (find_partial_die): Update to return const struct.
6562         (partial_die_parent_scope): Move variable declaration into scope
6563         of its use and change its type to auto.
6564         (guess_partial_die_structure_name): Likewise.
6565         (partial_die_info::fixup): Likewise.
6566
6567 2019-05-17  Tom Tromey  <tromey@adacore.com>
6568
6569         * source.c (find_and_open_source): Remove cast.
6570
6571 2019-05-17  Tom Tromey  <tromey@adacore.com>
6572
6573         * annotate.c (annotate_source): Make "filename" const.
6574         * annotate.h (annotate_source): Use const.
6575
6576 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6577
6578         * disasm.c (set_disassembler_options): Send errors to stderr.
6579
6580 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6581
6582         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6583         (cli_interp_base::set_logging): Check debug_redirect.
6584         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6585         * cli/cli-logging.c (debug_redirect): Add static variable.
6586         (pop_output_files): Add default param.
6587         (handle_redirections): Print debug setting.
6588         (show_logging_command): Likewise.
6589         (_initialize_cli_logging): Add debugredirect command.
6590         * interps.c (current_interp_set_logging): Add debug_redirect
6591         parameter.
6592         * interps.h (set_logging): Add debug_redirect parameter.
6593         (current_interp_set_logging): Likewise.
6594         * mi/mi-common.h: Likewise.
6595         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6596
6597 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6598             Tom Tromey  <tromey@adacore.com>
6599
6600         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6601         directly.
6602         * cli/cli-interp.h (make_logging_output): Remove declaration.
6603         * cli/cli-logging.c (make_logging_output): Remove function.
6604         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6605         directly.
6606         * ui-file.c (tee_file::tee_file): Remove bools.
6607         (tee_file::~tee_file): Remove deletes.
6608         * ui-file.h (tee_file): Remove bools.
6609
6610 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6611
6612         * mi/mi-cmds.h (mi_cmd_complete): New function.
6613         * mi/mi-main.c (mi_cmd_complete): Likewise.
6614         * mi/mi-cmds.c: Define new MI command -complete.
6615         * NEWS: Mention new -complete command.
6616
6617 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6618
6619         * completer.h (complete): New function.
6620         * completer.c (complete): Likewise.
6621         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6622         function defined in completer.h.
6623
6624 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6625
6626         * MAINTAINERS (Write After Approval): Add myself.
6627
6628 2019-05-17  Tom de Vries  <tdevries@suse.de>
6629
6630         PR gdb/24094
6631         * dwarf2read.c (struct cu_partial_die_info): New struct.
6632         (find_partial_die): Return cu_partial_die_info.
6633         (partial_die_parent_scope, guess_partial_die_structure_name)
6634         (partial_die_info::fixup): Handle new return type of find_partial_die.
6635
6636 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6637
6638         PR breakpoints/24541
6639         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6640         "std::string", simplifying the algorithm.
6641
6642 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6643
6644         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
6645         (stap_static_probe_ops::get_probes): Likewise.
6646
6647 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6648
6649         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
6650         '-')" and "else if".
6651         (stap_parse_single_operand): Join checks for
6652         "gdbarch_stap_parse_special_token_p" and
6653         "gdbarch_stap_parse_special_token" in the same "if" statement.
6654         Invert check when verifying for operation on register
6655         displacement.
6656
6657 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6658
6659         * stap-probe.c (stap_get_opcode): Update comment.
6660         (stap_get_expected_argument_type): Likewise.
6661         (handle_stap_probe): Likewise.
6662
6663 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6664
6665         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
6666         return type to 'bool'.  Adjust comment.  Use 'bool' when
6667         appropriate.
6668         (i386_stap_parse_special_token_three_arg_disp): Likewise.
6669         * stap-probe.c (stap_parse_argument_1): Likewise.
6670         (stap_is_operator): Likewise.
6671         (stap_is_generic_prefix): Likewise.
6672         (stap_is_register_prefix): Likewise.
6673         (stap_is_register_indirection_prefix): Likewise.
6674         (stap_is_integer_prefix): Likewise.
6675         (stap_generic_check_suffix): Likewise.
6676         (stap_check_integer_suffix): Likewise.
6677         (stap_check_register_suffix): Likewise.
6678         (stap_check_register_indirection_suffix): Likewise.
6679         (stap_parse_register_operand): Likewise.
6680         (stap_parse_single_operand): Likewise.
6681         (stap_parse_argument_1): Likewise.
6682         (stap_probe::get_argument_count): Likewise.
6683         (stap_is_operator): Likewise.
6684
6685 2019-05-16  Tom Tromey  <tromey@adacore.com>
6686
6687         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
6688         keyword to foreach.
6689
6690 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
6691
6692         * linux-thread-db.c (try_thread_db_load_1): Change return type
6693         to bool.
6694         (try_thread_db_load): Likewise.
6695         (try_thread_db_load_from_pdir_1): Likewise.
6696         (try_thread_db_load_from_pdir): Likewise.
6697         (try_thread_db_load_from_sdir): Likewise.
6698         (try_thread_db_load_from_dir): Likewise.
6699         (thread_db_load_search): Likewise.
6700         (has_libpthread): Likewise.
6701         (thread_db_load): Likewise.
6702
6703 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
6704
6705         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6706         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
6707         NULL, and complain/return if that's the case.
6708
6709 2019-05-15  John Darrington <john@darrington.wattle.id.au>
6710
6711         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
6712         (advance, posn, abstract_read_memory): New functions.
6713         [struct mem_read_abstraction]: New struct.
6714         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
6715
6716 2019-05-14  Tom Tromey  <tromey@adacore.com>
6717
6718         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
6719         value is not lval_memory.
6720
6721 2019-05-14  Tom Tromey  <tromey@adacore.com>
6722
6723         * solib.c (info_sharedlibrary_command): Style the file name.
6724
6725 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
6726
6727         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
6728         (aarch64_vnv_type): Likewise.
6729         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
6730         * common/tdesc.c: Likewise.
6731         * common/tdesc.h (enum tdesc_type_kind): Likewise.
6732         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
6733         * features/aarch64-fpu.xml: Add ieee half view.
6734         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
6735         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
6736         * gdbtypes.h (struct builtin_type): Likewise.
6737         (struct objfile_type): Likewise.
6738
6739 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
6740
6741         * language.c (language_sniff_from_mangled_name): Fix "langauge"
6742         typo.
6743         * location.h (string_to_event_location): Likewise.
6744
6745 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
6746
6747         GDB 8.3 released.
6748
6749 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6750
6751         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
6752         New variable declaration.
6753         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
6754         New variable.
6755         (print_one_breakpoint): Use ui_out::test_flags and new global
6756         variable to compute use_fixed_output.
6757         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
6758         Remove.
6759         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
6760         (mi_multi_location_breakpoint_output_fixed): Remove.
6761         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
6762         new variable.
6763         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
6764         fix_multi_location_breakpoint_output flag if version >= 3.
6765         * ui-out.h (enum ui_out_flag)
6766         <fix_multi_location_breakpoint_output>: New enumerator.
6767
6768 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
6769
6770         * contrib/cc-with-tweaks.sh: Validate dwz's work.
6771
6772 2019-05-10  Tom Tromey  <tromey@adacore.com>
6773
6774         * ada-lang.c (catch_ada_completer): New function.
6775         (_initialize_ada_language): Use it.
6776
6777 2019-05-10  Tom Tromey  <tromey@adacore.com>
6778
6779         * thread.c (print_thread_info): Make "requested_threads" const.
6780         * gdbthread.h (print_thread_info): Make "requested_threads"
6781         const.
6782         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
6783         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
6784
6785 2019-05-08  Tom Tromey  <tom@tromey.com>
6786
6787         * gdbtypes.c (objfile_type_data): Change type.
6788         (objfile_type, _initialize_gdbtypes): Update.
6789
6790 2019-05-08  Tom Tromey  <tom@tromey.com>
6791
6792         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
6793         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
6794         (_initialize_dwarf2_frame): Update.
6795
6796 2019-05-08  Tom Tromey  <tom@tromey.com>
6797
6798         * objc-lang.c (objc_objfile_data): Change type.
6799         (find_methods): Update.
6800         (_initialize_objc_lang): Remove.
6801
6802 2019-05-08  Tom Tromey  <tom@tromey.com>
6803
6804         * stabsread.c (rs6000_builtin_type_data): Change type.
6805         (rs6000_builtin_type, _initialize_stabsread): Update.
6806
6807 2019-05-08  Tom Tromey  <tom@tromey.com>
6808
6809         * mips-tdep.c (mips_pdr_data): Remove.
6810         (_initialize_mips_tdep): Update.
6811
6812 2019-05-08  Tom Tromey  <tom@tromey.com>
6813
6814         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
6815         (hppa_init_objfile_priv_data, read_unwind_info)
6816         (find_unwind_entry, _initialize_hppa_tdep): Update.
6817
6818 2019-05-08  Tom Tromey  <tom@tromey.com>
6819
6820         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
6821         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
6822         on obstack.
6823         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
6824
6825 2019-05-08  Tom Tromey  <tom@tromey.com>
6826
6827         * mdebugread.c (basic_type_data): Change type.
6828         (basic_type, _initialize_mdebugread): Update.
6829
6830 2019-05-08  Tom Tromey  <tom@tromey.com>
6831
6832         * common/gdb_unique_ptr.h (struct noop_deleter): New.
6833
6834 2019-05-08  Tom Tromey  <tom@tromey.com>
6835
6836         * nto-tdep.c (nto_inferior_data_reg): Change type.
6837         (nto_inferior_data): Update.
6838         (nto_inferior_data_cleanup, nto_new_inferior_data)
6839         (_initialize_nto_tdep): Remove.
6840         * nto-tdep.h (struct nto_inferior_data): Add initializers.
6841
6842 2019-05-08  Tom Tromey  <tom@tromey.com>
6843
6844         * ada-lang.c (struct ada_inferior_data): Add initializers.
6845         (ada_inferior_data): Change type.
6846         (ada_inferior_data_cleanup): Remove.
6847         (get_ada_inferior_data, ada_inferior_exit)
6848         (struct ada_pspace_data): Add initializers, destructor.
6849         (ada_pspace_data_handle): Change type.
6850         (get_ada_pspace_data): Update.
6851         (ada_pspace_data_cleanup): Remove.
6852
6853 2019-05-08  Tom Tromey  <tom@tromey.com>
6854
6855         * coffread.c (struct coff_symfile_info): Add initializers.
6856         (coff_objfile_data_key): Move lower.  Change type.
6857         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
6858         Update.
6859         (coff_free_info): Remove.
6860
6861 2019-05-08  Tom Tromey  <tom@tromey.com>
6862
6863         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
6864         (fbsd_pspace_data_handle): Move lower.  Change type.
6865         (get_fbsd_pspace_data): Update.
6866         (fbsd_pspace_data_cleanup): Remove.
6867         (_initialize_fbsd_tdep): Update.
6868
6869 2019-05-08  Tom Tromey  <tom@tromey.com>
6870
6871         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
6872         (get_ada_tasks_pspace_data): Update.
6873         (ada_tasks_pspace_data_cleanup): Remove.
6874         (_initialize_tasks): Update.
6875         (ada_tasks_inferior_data_handle): Change type.
6876         (get_ada_tasks_inferior_data): Update.
6877         (ada_tasks_inferior_data_cleanup): Remove.
6878         (struct ada_tasks_pspace_data): Add initializers.
6879
6880 2019-05-08  Tom Tromey  <tom@tromey.com>
6881
6882         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
6883         * symfile-debug.c (debug_sym_get_probes): Change type.
6884         * stap-probe.c (handle_stap_probe):
6885         (stap_static_probe_ops::get_probes): Change type.
6886         * probe.h (class static_probe_ops) <get_probes>: Change type.
6887         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
6888         (parse_probes_in_pspace): Update.
6889         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
6890         Update.
6891         (any_static_probe_ops::get_probes): Change type.
6892         * elfread.c (elfread_data): New typedef.
6893         (probe_key): Change type.
6894         (elf_get_probes): Likewise.  Update.
6895         (probe_key_free): Remove.
6896         (_initialize_elfread): Update.
6897         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
6898         Change type.
6899         (dtrace_process_dof_probe, dtrace_process_dof)
6900         (dtrace_static_probe_ops::get_probe): Change type.
6901
6902 2019-05-08  Tom Tromey  <tom@tromey.com>
6903
6904         * xcoffread.c (struct xcoff_symfile_info): Rename from
6905         coff_symfile_info.  Add initializers.
6906         (xcoff_objfile_data_key): Move lower.  Change type.
6907         (XCOFF_DATA): Rewrite.
6908         (xcoff_free_info): Remove.
6909         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
6910         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
6911         (xcoff_initial_scan): Update.
6912
6913 2019-05-08  Tom Tromey  <tom@tromey.com>
6914
6915         * solib-svr4.c (struct svr4_info): Add initializers and
6916         destructor.
6917         <probes_table>: Now an htab_up.
6918         (solib_svr4_pspace_data): Change type.
6919         (free_probes_table): Simplify.
6920         (~svr4_info): Rename from svr4_pspace_data_cleanup.
6921         (get_svr4_info, probes_table_htab_remove_objfile_probes)
6922         (probes_table_remove_objfile_probes, register_solib_event_probe)
6923         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
6924         (_initialize_svr4_solib): Update.
6925
6926 2019-05-08  Tom Tromey  <tom@tromey.com>
6927
6928         * remote.c (remote_pspace_data): Change type.
6929         (remote_pspace_data_cleanup): Remove.
6930         (get_remote_exec_file, set_pspace_remote_exec_file)
6931         (_initialize_remote): Update.
6932
6933 2019-05-08  Tom Tromey  <tom@tromey.com>
6934
6935         * breakpoint.c (breakpoint_objfile_key): Change type.
6936         (get_breakpoint_objfile_data): Update.
6937         (free_breakpoint_objfile_data): Remove.
6938         (_initialize_breakpoint): Update.
6939
6940 2019-05-08  Tom Tromey  <tom@tromey.com>
6941
6942         * linux-tdep.c (struct linux_info): Add initializers.
6943         (linux_inferior_data): Move.  Change type.
6944         (invalidate_linux_cache_inf): Update.
6945         (linux_inferior_data_cleanup): Remove.
6946         (get_linux_inferior_data, _initialize_linux_tdep): Update.
6947
6948 2019-05-08  Tom Tromey  <tom@tromey.com>
6949
6950         * auxv.c (auxv_inferior_data): Move.  Change type.
6951         (auxv_inferior_data_cleanup): Remove.
6952         (invalidate_auxv_cache_inf): Rewrite.
6953         (get_auxv_inferior_data, _initialize_auxv): Update.
6954
6955 2019-05-08  Tom Tromey  <tom@tromey.com>
6956
6957         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
6958         (symfile_debug_objfile_data_key): Change type.
6959         (symfile_debug_installed, debug_qf_has_symbols)
6960         (debug_qf_find_last_source_symtab)
6961         (debug_qf_forget_cached_source_info)
6962         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
6963         (debug_qf_print_stats, debug_qf_dump)
6964         (debug_qf_expand_symtabs_for_function)
6965         (debug_qf_expand_all_symtabs)
6966         (debug_qf_expand_symtabs_with_fullname)
6967         (debug_qf_map_matching_symbols)
6968         (debug_qf_expand_symtabs_matching)
6969         (debug_qf_find_pc_sect_compunit_symtab)
6970         (debug_qf_map_symbol_filenames)
6971         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
6972         (debug_sym_new_init, debug_sym_init, debug_sym_read)
6973         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
6974         (debug_sym_read_linetable, debug_sym_relocate): Update.
6975         (symfile_debug_free_objfile): Remove.
6976         (install_symfile_debug_logging, _initialize_symfile_debug):
6977         Update.
6978
6979 2019-05-08  Tom Tromey  <tom@tromey.com>
6980
6981         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
6982         allocate_on_obstack.
6983         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
6984         (get_dwarf2_per_objfile): Update.
6985         (set_dwarf2_per_objfile): Remove.
6986         (dwarf2_has_info, dwarf2_get_section_info): Update.
6987         (dwarf2_free_objfile): Remove.
6988         (_initialize_dwarf2_read): Update.
6989
6990 2019-05-08  Tom Tromey  <tom@tromey.com>
6991
6992         * auto-load.c (struct auto_load_pspace_info): Add destructor and
6993         initializers.
6994         <unsupported_script_warning_printed,
6995         script_not_found_warning_printed>: Now bool.
6996         (auto_load_pspace_data): Change type.
6997         (~auto_load_pspace_info): Rename from
6998         auto_load_pspace_data_cleanup.
6999         (get_auto_load_pspace_data, init_loaded_scripts_info)
7000         (clear_section_scripts, maybe_print_unsupported_script_warning)
7001         (maybe_print_script_not_found_warning, _initialize_auto_load):
7002         Update.
7003
7004 2019-05-08  Tom Tromey  <tom@tromey.com>
7005
7006         * objfiles.c (objfile_pspace_info): Add destructor and
7007         initializers.
7008         (objfiles_pspace_data): Change type.
7009         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7010         (get_objfile_pspace_data): Update.
7011         (objfiles_bfd_data): Change type.
7012         (get_objfile_bfd_data): Update.
7013         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7014
7015 2019-05-08  Tom Tromey  <tom@tromey.com>
7016
7017         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7018         Change type.
7019         (get_catch_syscall_inferior_data): Update.
7020         (catch_syscall_inferior_data_cleanup): Remove.
7021         (_initialize_break_catch_syscall): Update.
7022
7023 2019-05-08  Tom Tromey  <tom@tromey.com>
7024
7025         * inflow.c (struct terminal_info): Add destructor and
7026         initializers.
7027         (inflow_inferior_data): Change type.
7028         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7029         (get_inflow_inferior_data, inflow_inferior_exit)
7030         (swap_terminal_info, _initialize_inflow): Update.
7031
7032 2019-05-08  Tom Tromey  <tom@tromey.com>
7033
7034         * target-dcache.c (target_dcache_cleanup): Remove.
7035         (target_dcache_aspace_key): Change type.
7036         (target_dcache_init_p, target_dcache_invalidate)
7037         (target_dcache_get, target_dcache_get_or_init)
7038         (_initialize_target_dcache): Update.
7039         * dcache.h (struct dcache_deleter): New.
7040
7041 2019-05-08  Tom Tromey  <tom@tromey.com>
7042
7043         * symtab.c (struct symbol_cache): Add destructor and
7044         initializers.
7045         (symbol_cache_key): Move.  Change type.
7046         (make_symbol_cache, free_symbol_cache): Remove.
7047         (get_symbol_cache): Update.
7048         (symbol_cache_cleanup): Remove.
7049         (ALL_PSPACES, symbol_cache_flush)
7050         (maintenance_print_symbol_cache)
7051         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7052         Update.
7053
7054 2019-05-08  Tom Tromey  <tom@tromey.com>
7055
7056         * symtab.c (struct main_info): Add destructor and initializers.
7057         (main_progspace_key): Move.  Change type.
7058         (get_main_info): Update.
7059         (main_info_cleanup): Remove.
7060         (_initialize_symtab): Update.
7061
7062 2019-05-08  Tom Tromey  <tom@tromey.com>
7063
7064         * registry.h (DECLARE_REGISTRY): Define the _key class.
7065
7066 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7067
7068         * NEWS: Merge two 'New commands' sections.
7069
7070 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7071
7072         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7073         parameter and use Ada language definition instead.
7074         (ada_val_print_ptr): Remove unused language parameter.
7075         (ada_val_print_num): Remove language parameter and use Ada language
7076         definition instead.
7077         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7078         parameter.
7079         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7080         parameter and use Ada language definition instead.
7081         (ada_val_print_1): Update all ada_val_print_xxx calls.
7082         Remove language parameter.
7083         (ada_val_print): Update ada_val_print_1 call.
7084
7085 2019-05-08  Tom Tromey  <tromey@adacore.com>
7086
7087         * remote.c (remote_hw_watchpoint_limit)
7088         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7089         Now static.
7090
7091 2019-05-08  Tom Tromey  <tromey@adacore.com>
7092
7093         * maint.c (_initialize_maint_cmds): Move initialization code to
7094         remote.c.
7095         (watchdog, show_watchdog): Move to remote.c.
7096         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7097         "watchdog" static.
7098         (_initialize_remote): Move initialization code from maint.c.
7099         * defs.h (watchdog): Don't declare.
7100
7101 2019-05-08  Tom Tromey  <tromey@adacore.com>
7102
7103         * tui/tui-interp.c: Include main.h.
7104         * interps.c: Include main.h.
7105         * main.h (interpreter_p): Declare.
7106         * defs.h (interpreter_p): Don't declare.
7107
7108 2019-05-08  Tom Tromey  <tromey@adacore.com>
7109
7110         * dwarf2loc.c: Include dwarf2read.h.
7111         * defs.h (read_unsigned_leb128): Don't declare.
7112         * dwarf2read.h (read_unsigned_leb128): Declare.
7113
7114 2019-05-08  Tom Tromey  <tromey@adacore.com>
7115
7116         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7117         method.
7118
7119 2019-05-08  Tom Tromey  <tromey@adacore.com>
7120
7121         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7122         when no wrap column is set.
7123
7124 2019-05-08  Tom Tromey  <tromey@adacore.com>
7125
7126         * c-lang.c (c_get_string): Handle non-C-style arrays.
7127
7128 2019-05-08  Tom Tromey  <tromey@adacore.com>
7129
7130         * typeprint.c (print_offset_data::update): Print the bit offset,
7131         not the number of bits remaining.
7132
7133 2019-05-08  Tom Tromey  <tromey@adacore.com>
7134
7135         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7136         padding at end of comment.
7137
7138 2019-05-08  Tom Tromey  <tromey@adacore.com>
7139
7140         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7141         Compare main types.
7142
7143 2019-05-06  Tom Tromey  <tom@tromey.com>
7144
7145         * common/scoped_mmap.c: Include common-defs.h.
7146         * common/scoped_mmap.h: Don't include config.h.
7147
7148 2019-05-04  Tom Tromey  <tom@tromey.com>
7149
7150         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7151         (struct aarch64_call_info): Add initializers.
7152         <si>: Now a std::vector.
7153         (pass_on_stack, aarch64_push_dummy_call): Update.
7154
7155 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7156             Tom Tromey  <tom@tromey.com>
7157
7158         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7159         (ppc_threads): Now a std::vector.  Now static.
7160         (hwdebug_find_thread_points_by_tid)
7161         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7162         Update.
7163
7164 2019-05-04  Tom Tromey  <tom@tromey.com>
7165
7166         * arc-tdep.c (arc_tdesc_init): Return bool.
7167
7168 2019-05-04  Tom Tromey  <tom@tromey.com>
7169
7170         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7171         Use gdb_assert_not_reached.
7172
7173 2019-05-04  Tom Tromey  <tom@tromey.com>
7174
7175         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7176         "false".
7177
7178 2019-05-04  Tom Tromey  <tom@tromey.com>
7179
7180         * arc-tdep.c (arc_tdesc_init): Use bool.
7181
7182 2019-05-04  Tom Tromey  <tom@tromey.com>
7183
7184         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7185
7186 2019-05-04  Tom Tromey  <tom@tromey.com>
7187
7188         * cli/cli-cmds.c (valid_command_p): Return bool.
7189
7190 2019-05-04  Tom Tromey  <tom@tromey.com>
7191
7192         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7193         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7194
7195 2019-05-04  Raul Tambre  <raul@tambre.ee>
7196
7197         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7198         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7199         operator for comparison.
7200
7201 2019-05-04  Tom Tromey  <tom@tromey.com>
7202
7203         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7204         (lookup_partial_symbol, print_partial_symbols)
7205         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7206         (psymbol_compare): Update.
7207         (add_psymbol_to_bcache): Clear the entire psymbol.
7208         (maintenance_check_psymtabs): Update.
7209         * psympriv.h (struct partial_symbol): Don't derive from
7210         general_symbol_info.
7211         <obj_section, unrelocated_address, address,
7212         set_unrelocated_address>: Update.
7213         <ginfo>: New member.
7214         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7215         (debug_names::write_psymbols): Update.
7216
7217 2019-05-04  Tom de Vries  <tdevries@suse.de>
7218
7219         * contrib/cc-with-tweaks.sh: Support -n arg.
7220
7221 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7222
7223         * corelow.c (core_target::detach): Ensure frame cache and
7224         register caches are cleared.
7225         inferior.c (exit_inferior_1): Likewise.
7226
7227 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7228             Tom Tromey  <tom@tromey.com>
7229
7230         * dictionary.c (collate_pending_symbols_by_language): Remove
7231         "struct" from foreach.
7232         * symtab.c (lookup_global_symbol_from_objfile)
7233         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7234         foreach.
7235         * ser-tcp.c (net_open): Remove "struct" from foreach.
7236         * objfiles.c (objfile_relocate, objfile_rebase)
7237         (objfile_has_symbols): Remove "struct" from foreach.
7238         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7239         from foreach.
7240         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7241         foreach.
7242         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7243         "struct" from foreach.
7244         * ada-lang.c (create_excep_cond_exprs)
7245         (ada_exception_catchpoint_cond_string): Remove "struct" from
7246         foreach.
7247
7248 2019-05-03  Tom Tromey  <tromey@adacore.com>
7249
7250         * ada-exp.y (convert_char_literal): Check suffix of each
7251         enumerator.
7252
7253 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7254
7255         PR ada/21406:
7256         * ada-exp.y (yywrap): Don't define.
7257         * ada-lex.l (%option): Add noyywrap
7258         (yywrap): Remove.
7259
7260 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7261
7262         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7263         _WIN32_WINNT to the XP level, unless already defined to a higher
7264         level.
7265
7266         * unittests/parse-connection-spec-selftests.c:
7267         * ser-tcp.c:
7268         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7269         override.
7270
7271         * symfile.c (find_separate_debug_file): Remove colon from the
7272         drive spec of DOS/Windows file names of the target, so that the
7273         file name produced from DEBUGDIR and the target's directory will
7274         be valid on DOS/Windows systems.
7275
7276 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7277
7278         * rust-lang.c (val_print_struct): Handle printing structures
7279         containing strings.
7280
7281 2019-05-02  Tom Tromey  <tromey@adacore.com>
7282
7283         * valarith.c (_initialize_valarith): Remove.
7284
7285 2019-05-01  Tom Tromey  <tromey@adacore.com>
7286
7287         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7288         bitfields.
7289
7290 2019-05-01  Tom Tromey  <tromey@adacore.com>
7291
7292         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7293         for big-endian copies.
7294
7295 2019-04-30  Ali Tamur  <tamur@google.com>
7296         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7297         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7298         (read_3_bytes): New function.
7299
7300 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7301
7302         * windows-nat.c (main_thread_id): Delete.
7303         (handle_output_debug_string): Replace main_thread_id by
7304         current_event.dwThreadId.
7305         (fake_create_process): Likewise.
7306         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7307         Do not set main_thread_id.
7308         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7309         current_event.dwThreadId.
7310         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7311
7312 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7313
7314         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7315         Use current_event.dwThreadId instead of main_thread_id.
7316
7317 2019-04-30  Tom Tromey  <tromey@adacore.com>
7318
7319         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7320         (create_excep_cond_exprs): Iterate over program spaces.
7321         (ada_exception_catchpoint_cond_string): Examine all minimal
7322         symbols for exception types.
7323
7324 2019-04-30  Tom Tromey  <tromey@adacore.com>
7325
7326         PR c++/24470:
7327         * dwarf2read.c (process_structure_scope): Handle case where type
7328         has template parameters but no symbol was created.
7329
7330 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7331             Chris January  <chris.january@arm.com>
7332
7333         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7334         qualifier.
7335         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7336
7337 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7338
7339         * f-typeprint.c (f_print_type): Update rules for printing
7340         whitespace.
7341         (f_type_print_varspec_suffix): Likewise.
7342
7343 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7344             Chris January  <chris.january@arm.com>
7345
7346         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7347         function arguments.
7348
7349 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7350
7351         * f-lang.c (build_fortran_types): Change name of void type to
7352         lower case.
7353         * f-typeprint.c (f_type_print_base): Print the name of the void
7354         type, rather than a fixed string.
7355         * f-valprint.c (f_decorations): Use lower case void string.
7356
7357 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7358             Chris January  <chris.january@arm.com>
7359
7360         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7361         types for Fortran.
7362
7363 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7364             Chris January  <chris.january@arm.com>
7365             David Lecomber  <david.lecomber@arm.com>
7366
7367         * f-exp.y (BINOP_INTRINSIC): New token.
7368         (exp): New parser rule handling BINOP_INTRINSIC.
7369         (f77_keywords): Add new builtin procedures.
7370         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7371         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7372         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7373         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7374         (print_unop_subexp_f): New function.
7375         (print_binop_subexp_f): New function.
7376         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7377         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7378         (dump_subexp_body_f): Likewise.
7379         (operator_check_f): Likewise.
7380         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7381         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7382
7383 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7384
7385         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7386         UNOP_KIND.
7387         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7388         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7389         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7390         (operator_length_f): New fuction.
7391         (print_subexp_f): New function.
7392         (op_name_f): New function.
7393         (dump_subexp_body_f): New function.
7394         (operator_check_f): New function.
7395         (exp_descriptor_f): Replace standard expression handling functions
7396         with new functions.
7397         * gdb/fortran-operator.def: New file.
7398         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7399         * gdb/std-operator.def: Remove UNOP_KIND.
7400
7401 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7402
7403         * std-operator.def: Remove unbalanced, stray double quote
7404         character.
7405
7406 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7407             Chris January  <chris.january@arm.com>
7408             Daniel Everett  <daniel.everett@arm.com>
7409             Nick Forrington  <nick.forrington@arm.com>
7410             Richard Bunt  <richard.bunt@arm.com>
7411
7412         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7413         of depth when printing anonymous structs or unions.
7414         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7415         Don't print either the top-level value, or the children if the
7416         max-depth is exceeded.
7417         (ppscm_print_children): When printing the key of a map, allow one
7418         extra level of depth.
7419         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7420         print either the top-level value, or the children if the max-depth
7421         is exceeded.
7422         (print_children): When printing the key of a map, allow one extra
7423         level of depth.
7424         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7425         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7426         (user_print_options): Initialise max_depth field.
7427         (val_print_scalar_or_string_type_p): New function.
7428         (val_print): Check to see if the max depth has been reached.
7429         (val_print_check_max_depth): Define new function.
7430         (show_print_max_depth): New function.
7431         (_initialize_valprint): Add 'print max-depth' option.
7432         * valprint.h (struct value_print_options) <max_depth>: New field.
7433         (val_print_check_max_depth): Declare new function.
7434         * NEWS: Document new feature.
7435
7436 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7437
7438         * ada-lang.c (ada_language_defn): Initialise new field.
7439         * c-lang.c (c_is_string_type_p): New function.
7440         (c_language_defn): Initialise new field.
7441         (cplus_language_defn): Initialise new field.
7442         (asm_language_defn): Initialise new field.
7443         (minimal_language_defn): Initialise new field.
7444         * c-lang.h (c_is_string_type_p): Declare new function.
7445         * d-lang.c (d_language_defn): Initialise new field.
7446         * f-lang.c (f_is_string_type_p): New function.
7447         (f_language_defn): Initialise new field.
7448         * go-lang.c (go_is_string_type_p): New function.
7449         (go_language_defn): Initialise new field.
7450         * language.c (default_is_string_type_p): New function.
7451         (unknown_language_defn): Initialise new field.
7452         (auto_language_defn): Initialise new field.
7453         * language.h (struct language_defn) <la_is_string_type_p>: New
7454         member variable.
7455         (default_is_string_type_p): Declare new function.
7456         * m2-lang.c (m2_language_defn): Initialise new field.
7457         * objc-lang.c (objc_language_defn): Initialise new field.
7458         * opencl-lang.c (opencl_language_defn): Initialise new field.
7459         * p-lang.c (pascal_is_string_type_p): New function.
7460         (pascal_language_defn): Initialise new field.
7461         * rust-lang.c (rust_is_string_type_p): New function.
7462         (rust_language_defn): Initialise new field.
7463
7464 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7465
7466         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7467         New field.
7468         * ada-lang.c (ada_language_defn): Initialise new field.
7469         * c-lang.c (c_language_defn): Likewise.
7470         (cplus_language_defn): Likewise.
7471         (asm_language_defn): Likewise.
7472         (minimal_language_defn): Likewise.
7473         * d-lang.c (d_language_defn): Likewise.
7474         * f-lang.c (f_language_defn): Likewise.
7475         * go-lang.c (go_language_defn): Likewise.
7476         * language.c (unknown_language_defn): Likewise.
7477         (auto_language_defn): Likewise.
7478         * m2-lang.c (m2_language_defn): Likewise.
7479         * objc-lang.c (objc_language_defn): Likewise.
7480         * opencl-lang.c (opencl_language_defn): Likewise.
7481         * p-lang.c (pascal_language_defn): Likewise.
7482         * rust-lang.c (rust_language_defn): Likewise.
7483
7484 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7485
7486         * ada-lang.c (ada_is_character_type): Change return type to bool.
7487         (ada_is_string_type): Likewise.
7488         * ada-lang.h (ada_is_character_type): Update declaration
7489         (ada_is_string_type): Likewise.
7490
7491 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7492
7493         Support style in 'frame|thread apply'
7494
7495         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7496         * record.c (record_start, record_stop): Update callers of
7497         execute_command_to_string with false.
7498         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7499         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7500         methods.
7501         (class string_file): New constructor with term_out parameter.
7502         Override methods term_out and can_emit_style_escape.  New member
7503         term_out.
7504         (class stdio_file): Override can_emit_style_escape.
7505         (class tee_file): Override term_out and can_emit_style_escape.
7506         * utils.h (can_emit_style_escape): Remove.
7507         * utils.c (can_emit_style_escape): Likewise.
7508         Update all callers of can_emit_style_escape (SOMESTREAM) to
7509         SOMESTREAM->can_emit_style_escape.
7510         * source-cache.c (source_cache::get_source_lines): Likewise.
7511         * stack.c (frame_apply_command_count): Call execute_command_to_string
7512         passing the term_out characteristic of the current gdb_stdout.
7513         * thread.c (thr_try_catch_cmd): Likewise.
7514         * top.c (execute_command_to_string): pass term_out parameter
7515         to construct the string_file for the command output.
7516         * ui-file.c (term_cli_styling): New function (most code moved
7517         from utils.c can_emit_style_escape).
7518         (string_file::string_file, string_file::can_emit_style_escape,
7519         stdio_file::can_emit_style_escape, tee_file::term_out,
7520         tee_file::can_emit_style_escape): New functions.
7521
7522 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7523
7524         * NEWS: Mention the new set|show may-call-functions.
7525         * infcall.c (may_call_functions_p): New variable.
7526         (show_may_call_functions_p): New function.
7527         (call_function_by_hand_dummy): Throws an error if not
7528         may-call-functions.
7529         (_initialize_infcall): Call add_setshow_boolean_cmd for
7530         may-call-functions.
7531
7532 2019-04-25  Keith Seitz  <keiths@redhat.com>
7533
7534         PR c++/24367
7535         * cp-support.c (inspect_type): Don't attempt substitutions
7536         of symbol with the same name.
7537
7538 2019-04-25  Tom Tromey  <tromey@adacore.com>
7539
7540         PR gdb/24475:
7541         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7542         static.
7543
7544 2019-04-25  Tom Tromey  <tromey@adacore.com>
7545
7546         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7547         rvalue reference.
7548         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7549         (gdb_xml_parser::parse): Use std::move.
7550         * python/python-internal.h (gdbpy_convert_exception): Take a const
7551         reference.
7552         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7553         std::move.
7554         * python/py-utils.c (gdbpy_convert_exception): Take a const
7555         reference.
7556         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7557         Use std::move.
7558         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7559         Use std::move.
7560         * mi/mi-main.c (mi_print_exception): Take a const reference.
7561         * main.c (handle_command_errors): Take a const reference.
7562         * linespec.c (parse_linespec): Use std::move.
7563         * infcall.c (run_inferior_call): Use std::move.
7564         (call_function_by_hand_dummy): Use std::move.
7565         * exec.c (try_open_exec_file): Use std::move.
7566         * exceptions.h (exception_print, exception_fprintf)
7567         (exception_print_same): Update.
7568         * exceptions.c (print_exception, exception_print)
7569         (exception_fprintf, exception_print_same): Change parameters to
7570         const reference.
7571         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7572         * common/new-op.c: Use std::move.
7573         * common/common-exceptions.h (struct gdb_exception): Add move
7574         constructor.
7575         (struct gdb_exception_error, struct gdb_exception_quit, struct
7576         gdb_quit_bad_alloc): Change constructor to move constructor.
7577         (throw_exception): Change parameter to rvalue reference.
7578         * common/common-exceptions.c (throw_exception): Take rvalue
7579         reference.
7580         * cli/cli-interp.c (safe_execute_command): Use std::move.
7581         * breakpoint.c (insert_bp_location, location_to_sals): Use
7582         std::move.
7583
7584 2019-04-25  Tom Tromey  <tromey@adacore.com>
7585
7586         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7587         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7588         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7589         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7590         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7591         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7592         guile/scm-value.c: Use unpack.
7593         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7594         gdbscm_gdb_exception.
7595         (gdbscm_throw_gdb_exception): Likewise.
7596         (struct gdbscm_gdb_exception): New.
7597         (unpack): New function.
7598         (gdbscm_wrap): Use unpack.
7599
7600 2019-04-25  Tom Tromey  <tromey@adacore.com>
7601
7602         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7603         (gdb_rl_callback_handler): Use std::move.
7604         * common/common-exceptions.h (struct gdb_exception): Add move
7605         assignment operator.
7606         (throw_exception_sjlj): Change "exception" to const reference.
7607         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7608         (throw_exception_sjlj): Change "exception" to const reference.
7609
7610 2019-04-25  Tom Tromey  <tromey@adacore.com>
7611
7612         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7613         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7614         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7615         Update.
7616         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7617         Update.
7618         * mi/mi-interp.c (mi_interp::exec): Update.
7619         * linespec.c (parse_linespec): Update.
7620         * infcall.c (run_inferior_call): Update.
7621         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7622         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7623         (gdbscm_lookup_global_symbol): Update.
7624         * guile/scm-param.c (gdbscm_parameter_value): Update.
7625         * guile/scm-frame.c (gdbscm_frame_read_register)
7626         (gdbscm_frame_read_var): Update.
7627         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7628         * exec.c (try_open_exec_file): Update.
7629         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7630         (gdb_rl_callback_handler): Update.
7631         * common/common-exceptions.h (exception_none): Don't declare.
7632         * common/common-exceptions.c (exception_none): Don't define.
7633         (struct catcher) <exception>: Update.
7634         * cli/cli-interp.c (safe_execute_command): Update.
7635         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7636
7637 2019-04-25  Ali Tamur  <tamur@google.com>
7638
7639         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7640         (read_attribute_value): Likewise.
7641         (dwarf2_read_addr_index): Update comment.
7642         (read_str_index): Add DW_FORM_strx.
7643         (dwarf2_string_attr): Likewise.
7644         (dwarf2_const_value_attr): Likewise.
7645         (dump_die_shallow): Likewise.
7646         (dwarf2_fetch_constant_bytes): Likewise.
7647         (skip_form_bytes): Likewise.
7648         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
7649
7650 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
7651
7652         PR corefiles/11608
7653         PR corefiles/18187
7654         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
7655         OFFSET.  Verify if current mapping contains an ELF header.
7656         (linux_find_memory_regions_full): Adjust call to
7657         dump_mapping_p.
7658
7659 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
7660             Kang Li <kanglictf@gmail.com>
7661
7662         PR gdb/21600
7663
7664         * dwarf2-frame.c (read_initial_length): Be consistent about using
7665         unsigned representation of length.
7666         (decode_frame_entry_1): Likewise.  Check for wraparound of
7667         end pointer as well as buffer overflow.
7668
7669 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
7670
7671         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
7672         "vq".
7673
7674 2019-04-24  Tom Tromey  <tromey@adacore.com>
7675
7676         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
7677
7678 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7679
7680         * s12z-tdep.c (s12z_unwind_pc): Delete.
7681         (s12z_unwind_sp): Delete.
7682         (s12z_gdbarch_init): Don't register deleted functions with
7683         gdbarch.
7684
7685 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7686
7687         * rl78-tdep.c (rl78_unwind_sp): Delete.
7688         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
7689
7690 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7691
7692         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
7693         (xstormy16_unwind_pc): Delete.
7694         (xstormy16_dummy_id): Delete.
7695         (xstormy16_gdbarch_init): Don't register deleted functions with
7696         gdbarch.
7697
7698 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7699
7700         * vax-tdep.c (vax_unwind_pc): Delete.
7701         (vax_gdbarch_init): Don't register deleted function with gdbarch.
7702
7703 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7704
7705         * v850-tdep.c (v850_unwind_sp): Delete.
7706         (v850_unwind_pc): Delete.
7707         (v850_dummy_id): Delete.
7708         (v850_gdbarch_init): Don't register deleted functions with
7709         gdbarch.
7710
7711 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7712
7713         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
7714         (tilegx_unwind_pc): Delete.
7715         (tilegx_unwind_dummy_id): Delete.
7716         (tilegx_gdbarch_init): Don't register deleted functions with
7717         gdbarch.
7718
7719 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7720
7721         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
7722         (tic6x_dummy_id): Delete.
7723         (tic6x_gdbarch_init): Don't register deleted functions with
7724         gdbarch.
7725
7726 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7727
7728         * sparc-tdep.c (sparc_unwind_pc): Delete.
7729         (sparc32_gdbarch_init): Don't register deleted function with
7730         gdbarch.
7731
7732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7733
7734         * sh-tdep.c (sh_unwind_sp): Delete.
7735         (sh_unwind_pc): Delete.
7736         (sh_dummy_id): Delete.
7737         (sh_gdbarch_init): Don't register deleted functions with
7738         gdbarch.
7739
7740 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7741
7742         * score-tdep.c (score_unwind_sp): Delete.
7743         (score_unwind_pc): Delete.
7744         (score_dummy_id): Delete.
7745         (score_gdbarch_init): Don't register deleted functions with
7746         gdbarch.
7747
7748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7749
7750         * rx-tdep.c (rx_unwind_pc): Delete.
7751         (rx_unwind_sp): Delete.
7752         (rx_dummy_id): Delete.
7753         (rx_gdbarch_init): Don't register deleted functions with
7754         gdbarch.  Update comment.
7755
7756 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7757
7758         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
7759         (rs6000_dummy_id): Delete.
7760         (rs6000_gdbarch_init): Don't register deleted functions with
7761         gdbarch.
7762
7763 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7764
7765         * or1k-tdep.c (or1k_dummy_id): Delete.
7766         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
7767
7768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7769
7770         * nios2-tdep.c (nios2_dummy_id): Delete.
7771         (nios2_unwind_sp): Delete.
7772         (nios2_gdbarch_init): Don't register deleted functions with
7773         gdbarch.
7774
7775 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7776
7777         * nds32-tdep.c (nds32_dummy_id): Delete.
7778         (nds32_unwind_pc): Delete.
7779         (nds32_unwind_sp): Delete.
7780         (nds32_gdbarch_init): Don't register deleted functions with
7781         gdbarch.
7782
7783 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7784
7785         * msp430-tdep.c (msp430_unwind_pc): Delete.
7786         (msp430_unwind_sp): Delete.
7787         (msp430_dummy_id): Delete.
7788         (msp430_gdbarch_init): Don't register deleted functions with
7789         gdbarch.
7790
7791 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7792
7793         * moxie-tdep.c (moxie_unwind_sp): Delete.
7794         (moxie_unwind_pc): Delete.
7795         (moxie_dummy_id): Delete.
7796         (moxie_gdbarch_init): Don't register deleted functions with
7797         gdbarch.
7798
7799 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7800
7801         * mn10300-tdep.c (mn10300_dummy_id): Delete.
7802         (mn10300_unwind_pc): Delete.
7803         (mn10300_unwind_sp): Delete.
7804         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
7805         mn10300_unwind_sp.
7806         (mn10300_frame_unwind_init): Don't register deleted functions with
7807         gdbarch.
7808
7809 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7810
7811         * mep-tdep.c (mep_unwind_pc): Delete.
7812         (mep_unwind_sp): Delete.
7813         (mep_dummy_id): Delete.
7814         (mep_gdbarch_init): Don't register deleted functions with
7815         gdbarch.
7816
7817 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7818
7819         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
7820         (m68hc11_unwind_sp): Delete.
7821         (m68hc11_gdbarch_init): Don't register deleted functions with
7822         gdbarch.
7823
7824 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7825
7826         * m32r-tdep.c (m32r_unwind_sp): Delete.
7827         (m32r_unwind_pc): Delete.
7828         (m32r_dummy_id): Delete.
7829         (m32r_gdbarch_init): Don't register deleted functions with
7830         gdbarch.
7831
7832 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7833
7834         * m32c-tdep.c (m32c_unwind_pc): Delete.
7835         (m32c_unwind_sp): Delete.
7836         (m32c_dummy_id): Delete.
7837         (m32c_gdbarch_init): Don't register deleted functions with
7838         gdbarch.
7839
7840 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7841
7842         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
7843         (lm32_unwind_pc): Delete.
7844         (lm32_dummy_id): Delete.
7845         (lm32_gdbarch_init): Don't register deleted functions with
7846         gdbarch.
7847
7848 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7849
7850         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
7851         (iq2000_unwind_pc): Delete.
7852         (iq2000_dummy_id): Delete.
7853         (iq2000_gdbarch_init): Don't register deleted functions with
7854         gdbarch.
7855
7856 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * nds32-tdep.c (nds32_type_align): Delete.
7859         (nds32_push_dummy_call): Use type_align instead.
7860
7861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7862
7863         * arm-tdep.c (arm_type_align): Only handle vector override case.
7864         (arm_push_dummy_call): Use type_align.
7865         (arm_gdbarch_init): Register arm_type_align gdbarch function.
7866
7867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
7868
7869         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
7870         case.
7871         (pass_on_stack): Use type_align.
7872         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
7873         function.
7874
7875 2019-04-23  Tom Tromey  <tromey@adacore.com>
7876
7877         * dwarf2read.c (line_header::file_name_at): Remove unused
7878         overload.
7879
7880 2019-04-23  Tom de Vries  <tdevries@suse.de>
7881
7882         PR gdb/24438
7883         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
7884         invocation.
7885
7886
7887 2019-03-27  Ali Tamur  <tamur@google.com>
7888
7889         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
7890         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
7891         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
7892         (dwarf_expr_context::get_addr_index): Likewise
7893         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
7894         (symbol_needs_eval_context::get_addr_index): Likewise
7895         (disassemble_dwarf_expression): Add DW_OP_addrx
7896         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
7897         (read_cutu_die_from_dwo): Update comment
7898         (skip_one_die): Add DW_FORM_addrx
7899         (read_attribute_value): Likewise
7900         (var_decode_location): Add DW_OP_addrx
7901         (dwarf2_const_value_attr): Add DW_FORM_addrx
7902         (dump_die_shallow): Likewise
7903         (dwarf2_fetch_constant_bytes): Likewise
7904         (decode_locdesc): Add DW_OP_addrx
7905         (skip_form_bytes): Add DW_FORM_addrx
7906
7907 2019-04-22  Ali Tamur  <tamur@google.com>
7908
7909         * MAINTAINERS (Write After Approval): Add self.
7910
7911 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
7912
7913         * solib-svr4.c (get_svr4_info): Add pspace parameter.
7914         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
7915         (open_symbol_file_object): Likewise.
7916         (svr4_default_sos): Add info parameter.
7917         (svr4_read_so_list): Likewise.
7918         (svr4_current_sos_direct): Adjust functions calls to pass down
7919         info.
7920         (svr4_current_sos_1): Add info parameter.
7921         (svr4_current_sos): Call get_svr4_info, pass info down to
7922         svr4_current_sos_1.
7923         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
7924         get_svr4_info.
7925         (svr4_in_dynsym_resolve_code): Pass current_program_space to
7926         get_svr4_info.
7927         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
7928         to get_svr4_info.
7929         (probes_table_remove_objfile_probes): Likewise.
7930         (register_solib_event_probe): Add info parameter.
7931         (solist_update_incremental): Pass info parameter down to
7932         svr4_read_so_list.
7933         (disable_probes_interface): Add info parameter.
7934         (svr4_handle_solib_event): Pass current_program_space to
7935         get_svr4_info.  Adjust disable_probes_interface cleanup.
7936         (svr4_create_probe_breakpoints): Add info parameter, pass it
7937         down to register_solib_event_probe.
7938         (svr4_create_solib_event_breakpoints): Add info parameter,
7939         pass it down to svr4_create_probe_breakpoints.
7940         (enable_break): Pass info down to
7941         svr4_create_solib_event_breakpoints.
7942         (svr4_solib_create_inferior_hook): Pass current_program_space to
7943         get_svr4_info.
7944         (svr4_clear_solib): Likewise.
7945
7946 2019-04-22  Pedro Alves  <palves@redhat.com>
7947
7948         * solib-svr4.c (svr4_free_objfile_observer): New.
7949         (probe_and_action::objfile): New field.
7950         (probes_table_htab_remove_objfile_probes)
7951         (probes_table_remove_objfile_probes): New functions.
7952         (register_solib_event_probe): Add 'objfile' parameter.  Store it
7953         in the new probe_and_action.  Don't store the probe in 'lookup'.
7954         (svr4_create_probe_breakpoints): Pass objfile to
7955         register_solib_event_probe.
7956         (_initialize_svr4_solib): Register a free_objfile observer.
7957
7958 2019-04-19  Tom Tromey  <tom@tromey.com>
7959
7960         * common/queue.h: Remove.
7961
7962 2019-04-19  Tom Tromey  <tom@tromey.com>
7963
7964         * event-loop.c: Don't include "common/queue.h".
7965
7966 2019-04-19  Tom Tromey  <tom@tromey.com>
7967
7968         * remote.c (remote_target): Use delete.
7969         * remote-notif.h: Include <list>, not "common/queue.h".
7970         (notif_client_p): Remove typedef.
7971         (remote_notif_state): Add constructor, destructor, initializer.
7972         <notif_queue>: Now a std::list.
7973         (remote_notif_state_xfree): Don't declare.
7974         * remote-notif.c (remote_notif_process, handle_notification)
7975         (remote_notif_state_allocate): Update.
7976         (~remote_notif_state): Rename from remote_notif_state_xfree.
7977
7978 2019-04-19  Tom Tromey  <tom@tromey.com>
7979
7980         * symfile.c (reread_symbols): Update.
7981         * objfiles.c (objfile_register_static_link)
7982         (objfile_lookup_static_link): Update
7983         (~objfile) Don't delete static_links.
7984         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
7985
7986 2019-04-19  Tom Tromey  <tom@tromey.com>
7987
7988         * type-stack.h (struct type_stack) <insert>: Constify string.
7989         * type-stack.c (type_stack::insert): Constify string.
7990         * gdbtypes.h (lookup_template_type): Update.
7991         (address_space_name_to_int): Update.
7992         * gdbtypes.c (address_space_name_to_int): Make space_identifier
7993         const.
7994         (lookup_template_type): Make name const.
7995         * c-exp.y: Update rules.
7996         (lex_one_token, classify_name, classify_inner_name)
7997         (c_print_token): Update.
7998         * p-exp.y: Update rules.
7999         (yylex): Update.
8000         * f-exp.y: Update rules.
8001         (yylex): Update.
8002         * d-exp.y: Update rules.
8003         (lex_one_token, classify_name, classify_inner_name): Update.
8004         * parse.c (write_dollar_variable, copy_name): Return std::string.
8005         * parser-defs.h (copy_name): Change return type.
8006         * m2-exp.y: Update rules.
8007         (yylex): Update.
8008         * go-exp.y (lex_one_token): Update.
8009         Update rules.
8010         (classify_unsafe_function, classify_packaged_name)
8011         (classify_name, yylex): Update.
8012
8013 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8014
8015         * configure.ac: add --enable-source-highlight switch.
8016         * configure: Regenerate.
8017         * top.c (print_gdb_version): plumb --enable-source-highlight
8018         status to "show configuration".
8019
8020 2019-04-19  Tom Tromey  <tromey@adacore.com>
8021
8022         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8023         Check ADA_TYPE_P.
8024         (empty_record, ada_template_to_fixed_record_type_1)
8025         (template_to_static_fixed_type)
8026         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8027         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8028         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8029         macros.
8030
8031 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8032
8033         PR symtab/24423:
8034         * source.c (print_source_lines_base): Advance "iter" when a
8035         control character is seen.
8036
8037 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8038
8039         * inferior.h (struct infcall_suspend_state_deleter):
8040         Catch exception in destructor to avoid crash.
8041
8042 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8043
8044         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8045         close to the add_com "shell".
8046
8047 2019-04-18  Tom Tromey  <tromey@adacore.com>
8048
8049         * process-stratum-target.h (class process_stratum_target)
8050         <stratum>: Add "final".
8051
8052 2019-04-17  Tom Tromey  <tromey@adacore.com>
8053
8054         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8055         against nullptr before use.
8056
8057 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8058
8059         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8060
8061 2019-04-17  Jim Wilson  <jimw@sifive.com>
8062             Andrew Burgess  <andrew.burgess@embecosm.com>
8063
8064         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8065         code read might fail, assume 4-byte breakpoint in that case.
8066
8067 2019-04-15  Leszek Swirski  <leszeks@google.com>
8068
8069         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8070         rather than a hand-rolled POD check when checking for forced MEMORY
8071         classification.
8072
8073 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8074
8075         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8076         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8077         function.
8078         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8079         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8080         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8081         declaration.
8082
8083 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8084
8085         * aarch64-linux-nat.c
8086         (aarch64_linux_nat_target::thread_architecture): Add override.
8087         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8088         each VQ.
8089
8090 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8091
8092         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8093
8094 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8095
8096         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8097         target types of size 96-bits, add some additional comments, and
8098         check that the builtin type we found was the correct size.
8099
8100 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8101
8102         * utils.c (prompt_for_continue): Don't restore the styling at the
8103         end, as applied_style has the wrong value.  This fixes styling in
8104         long lists of file names that are interrupted by the "Continue?"
8105         prompt.
8106
8107 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8108
8109         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8110         * c-lang.c (c_language_defn): Likewise.
8111         (cplus_language_defn): Likewise.
8112         (asm_language_defn): Likewise.
8113         (minimal_language_defn): Likewise.
8114         * d-lang.c (d_language_defn): Likewise.
8115         * f-lang.c (f_language_defn): Likewise.
8116         * go-lang.c (go_language_defn): Likewise.
8117         * language.c (unknown_language_defn): Likewise.
8118         (auto_language_defn): Likewise.
8119         * language.h (struct language_defn): Remove la_magic field.
8120         (LANG_MAGIC): Delete.
8121         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8122         * objc-lang.c (objc_language_defn): Likewise.
8123         * opencl-lang.c (opencl_language_defn): Likewise.
8124         * p-lang.c (pascal_language_defn): Likewise.
8125         * rust-lang.c (rust_language_defn): Likewise.
8126
8127 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8128
8129         * riscv-tdep.c (riscv_type_align): New function.
8130         (riscv_type_alignment): Delete.
8131         (riscv_arg_location): Use 'type_align'.
8132         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8133
8134 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8135
8136         * gdbtypes.c (type_align): A struct with no non-static fields also
8137         has alignment of 1.
8138
8139 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8140
8141         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8142         component to 0.
8143         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8144         member.
8145         (riscv_struct_info::analyse): New implementation using new
8146         analyse_inner member function.
8147         (riscv_struct_info::field_offset): New member function.
8148         (riscv_struct_info::m_offsets): New member variable.
8149         (riscv_struct_info::analyse_inner): New private member function,
8150         takes the old implementation of riscv_struct_info::analyse but
8151         extended to track field offsets.
8152         (riscv_call_arg_struct): Update the struct folding special cases
8153         to handle cases where empty C++ structs, which are non-zero
8154         length, are found.
8155         (riscv_arg_location): Initialise the length of each location, a
8156         non-zero length now indicates the location is in use.
8157         (riscv_push_dummy_call): Allow for the first location having a
8158         non-zero offset when setting up arguments.
8159         (riscv_return_value): Likewise, but for return values.
8160
8161 2019-04-11  Tom Tromey  <tromey@adacore.com>
8162
8163         * utils.c (internal_vproblem): Make "msg" const.
8164
8165 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8166
8167         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8168         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8169         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8170         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8171
8172 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8173
8174         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8175         function.
8176         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8177         of amd64_collect_native_gregset.
8178         (amd64_linux_nat_target::store_registers): Likewise.
8179
8180 2019-04-10  Tom Tromey  <tom@tromey.com>
8181
8182         * symtab.c (lookup_global_symbol_from_objfile)
8183         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8184         * objfiles.h (class separate_debug_iterator): New.
8185         (class separate_debug_range): New.
8186         (struct objfile) <separate_debug_objfiles>: New method.
8187         (objfile_separate_debug_iterate): Don't declare.
8188         * objfiles.c (separate_debug_iterator::operator++): Rename from
8189         objfile_separate_debug_iterate.
8190         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8191         iterator.
8192         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8193         iterator.
8194
8195 2019-04-10  Tom Tromey  <tom@tromey.com>
8196
8197         * symfile.c (reread_symbols): Remove old comment.
8198         * objfiles.c (free_all_objfiles): Fix a typo.
8199
8200 2019-04-10  Tom Tromey  <tom@tromey.com>
8201
8202         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8203         * minsyms.c (lookup_minimal_symbol): Use foreach.
8204         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8205         (lookup_minimal_symbol_solib_trampoline): Likewise.
8206         * symfile.c (reread_symbols): Use foreach.
8207
8208 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8209             Tom Tromey  <tromey@adacore.com>
8210
8211         PR rust/24414:
8212         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8213         (rust_lex_int_test): Change "value" to be LONGEST.
8214         (rust_lex_tests): Add test for long integer literal.
8215
8216 2019-04-09  Tom Tromey  <tromey@adacore.com>
8217
8218         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8219         to bool.
8220         (extended_remote_target::attach): Update.
8221         (remote_target::remote_notice_new_inferior): Update.
8222         (remote_target::add_current_inferior_and_thread): Update.
8223         * inferior.c (exit_inferior_1): Use "false".
8224         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8225
8226 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8227
8228         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8229         the "start" command.
8230
8231 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8232
8233         * python/py-inferior.c (infpy_thread_from_thread_handle):
8234         Adjust comments to reflect renaming of thread_from_thread_handle
8235         to thread_from_handle.  Adjust keywords.  Fix type error message.
8236         (inferior_object_methods): Add thread_from_handle.  Retain
8237         thread_from_thread_handle, but mark it as deprecated.
8238
8239 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8240
8241         * gdbthread.h (find_thread_by_handle): Revise declaration.
8242         * thread.c (find_thread_by_handle): Likewise.  Adjust
8243         implementation too.
8244         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8245         support for buffer objects as handles.
8246
8247 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8248
8249         * python/py-infthread.c (thpy_thread_handle): New function.
8250         (thread_object_methods): Register thpy_thread_handle.
8251
8252 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8253
8254         * gdbthread.h (thread_to_thread_handle): Declare.
8255         * thread.c (gdbtypes.h): Include.
8256         (thread_to_thread_handle): New function.
8257
8258         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8259         (target_thread_info_to_thread_handle): Declare.
8260         * target.c (target_thread_info_to_thread_handle): New function.
8261         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8262         * target-delegates.c: Regenerate.
8263
8264         * linux-thread-db.c (class thread_db_target): Add method
8265         thread_info_to_thread_handle.
8266         (thread_db_target::thread_info_to_thread_handle): Define.
8267         * remote.c (class remote_target): Add new method
8268         thread_info_to_thread_handle.
8269         (remote_target::thread_info_to_thread_handle): Define.
8270
8271 2019-04-08  Pedro Alves  <palves@redhat.com>
8272
8273         * common/common-exceptions.c (throw_exception): Don't create
8274         named object to throw; throw directly.
8275         (throw_it): Likewise.  Don't initialize gdb_exception::message
8276         here, with new; pass FMT and AP to the ctor instead.
8277         * common/common-exceptions.h: Include <string>.
8278         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8279         const char *, va_list)): New ctor.  Use std::make_shared.
8280         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8281         errors)): Delete.
8282         (gdb_exception_error::gdb_exception_error(enum errors, const char
8283         *, va_list)): New.
8284         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8285         Add assertion.
8286         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8287         errors)): Delete.
8288         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8289         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8290         Add assertion.
8291
8292 2019-04-08  Tom Tromey  <tom@tromey.com>
8293
8294         * valops.c (value_rtti_indirect_type): Replace throw_exception
8295         with throw.
8296         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8297         with throw.
8298         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8299         throw.
8300         * target.c (target_translate_tls_address): Replace throw_exception
8301         with throw.
8302         * stack.c (frame_apply_command_count): Replace throw_exception
8303         with throw.
8304         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8305         throw.
8306         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8307         with throw.
8308         * rs6000-tdep.c (rs6000_frame_cache)
8309         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8310         * remote.c: Replace throw_exception with throw.
8311         * record-full.c (record_full_message, record_full_wait_1)
8312         (record_full_restore): Replace throw_exception with throw.
8313         * record-btrace.c:
8314         (get_thread_current_frame_id, record_btrace_start_replaying)
8315         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8316         (cmd_record_btrace_start): Replace throw_exception with throw.
8317         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8318         throw.
8319         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8320         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8321         * linespec.c:
8322         (find_linespec_symbols): Replace throw_exception with throw.
8323         * infrun.c (displaced_step_prepare, resume): Replace
8324         throw_exception with throw.
8325         * infcmd.c (post_create_inferior): Replace throw_exception with
8326         throw.
8327         * inf-loop.c (inferior_event_handler): Replace throw_exception
8328         with throw.
8329         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8330         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8331         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8332         (get_prev_frame_always, get_frame_pc_if_available)
8333         (get_frame_address_in_block_if_available, get_frame_language):
8334         Replace throw_exception with throw.
8335         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8336         throw_exception with throw.
8337         * eval.c (fetch_subexp_value, evaluate_var_value)
8338         (evaluate_funcall, evaluate_subexp_standard): Replace
8339         throw_exception with throw.
8340         * dwarf2loc.c (call_site_find_chain)
8341         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8342         Replace throw_exception with throw.
8343         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8344         with throw.
8345         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8346         throw.
8347         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8348         * completer.c (complete_line_internal): Replace throw_exception
8349         with throw.
8350         * compile/compile-object-run.c (compile_object_run): Replace
8351         throw_exception with throw.
8352         * cli/cli-script.c (process_next_line): Replace throw_exception
8353         with throw.
8354         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8355         (btrace_enable, btrace_maint_update_pt_packets): Replace
8356         throw_exception with throw.
8357         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8358         throw_exception with throw.
8359         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8360         throw_exception with throw.
8361         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8362         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8363         * aarch64-tdep.c (aarch64_make_prologue_cache)
8364         (aarch64_make_stub_cache): Replace throw_exception with throw.
8365
8366 2019-04-08  Tom Tromey  <tom@tromey.com>
8367
8368         * common/common-exceptions.c (throw_exception): Rename from
8369         throw_exception_cxx.  Remove old copy.  Make argument const.
8370         (throw_it): Create and throw exception objects directly.
8371         * common/common-exceptions.h (throw_exception): Make argument
8372         const.
8373         (struct gdb_exception_error): Add constructor.
8374         (struct gdb_exception_quit): Add constructor.
8375
8376 2019-04-08  Tom Tromey  <tom@tromey.com>
8377
8378         * common/common-exceptions.h (exception_rethrow): Don't declare.
8379         (TRY_SJLJ): Update comment.
8380         (TRY, CATCH, END_CATCH): Remove.
8381         * common/common-exceptions.c (exception_rethrow): Remove.
8382
8383 2019-04-08  Tom Tromey  <tom@tromey.com>
8384
8385         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8386         Remove.
8387         (gdb_exception_error): Rename from
8388         gdb_exception_RETURN_MASK_ERROR.
8389         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8390         (gdb_quit_bad_alloc): Update.
8391         * aarch64-tdep.c: Update.
8392         * ada-lang.c: Update.
8393         * ada-typeprint.c: Update.
8394         * ada-valprint.c: Update.
8395         * amd64-tdep.c: Update.
8396         * arch-utils.c: Update.
8397         * break-catch-throw.c: Update.
8398         * breakpoint.c: Update.
8399         * btrace.c: Update.
8400         * c-varobj.c: Update.
8401         * cli/cli-cmds.c: Update.
8402         * cli/cli-interp.c: Update.
8403         * cli/cli-script.c: Update.
8404         * common/common-exceptions.c: Update.
8405         * common/new-op.c: Update.
8406         * common/selftest.c: Update.
8407         * compile/compile-c-symbols.c: Update.
8408         * compile/compile-cplus-symbols.c: Update.
8409         * compile/compile-object-load.c: Update.
8410         * compile/compile-object-run.c: Update.
8411         * completer.c: Update.
8412         * corelow.c: Update.
8413         * cp-abi.c: Update.
8414         * cp-support.c: Update.
8415         * cp-valprint.c: Update.
8416         * darwin-nat.c: Update.
8417         * disasm-selftests.c: Update.
8418         * dtrace-probe.c: Update.
8419         * dwarf-index-cache.c: Update.
8420         * dwarf-index-write.c: Update.
8421         * dwarf2-frame-tailcall.c: Update.
8422         * dwarf2-frame.c: Update.
8423         * dwarf2loc.c: Update.
8424         * dwarf2read.c: Update.
8425         * eval.c: Update.
8426         * event-loop.c: Update.
8427         * event-top.c: Update.
8428         * exec.c: Update.
8429         * f-valprint.c: Update.
8430         * fbsd-tdep.c: Update.
8431         * frame-unwind.c: Update.
8432         * frame.c: Update.
8433         * gdbtypes.c: Update.
8434         * gnu-v3-abi.c: Update.
8435         * guile/guile-internal.h: Update.
8436         * guile/scm-block.c: Update.
8437         * guile/scm-breakpoint.c: Update.
8438         * guile/scm-cmd.c: Update.
8439         * guile/scm-disasm.c: Update.
8440         * guile/scm-frame.c: Update.
8441         * guile/scm-lazy-string.c: Update.
8442         * guile/scm-math.c: Update.
8443         * guile/scm-param.c: Update.
8444         * guile/scm-ports.c: Update.
8445         * guile/scm-pretty-print.c: Update.
8446         * guile/scm-symbol.c: Update.
8447         * guile/scm-symtab.c: Update.
8448         * guile/scm-type.c: Update.
8449         * guile/scm-value.c: Update.
8450         * i386-linux-tdep.c: Update.
8451         * i386-tdep.c: Update.
8452         * inf-loop.c: Update.
8453         * infcall.c: Update.
8454         * infcmd.c: Update.
8455         * infrun.c: Update.
8456         * jit.c: Update.
8457         * language.c: Update.
8458         * linespec.c: Update.
8459         * linux-fork.c: Update.
8460         * linux-nat.c: Update.
8461         * linux-tdep.c: Update.
8462         * linux-thread-db.c: Update.
8463         * main.c: Update.
8464         * mi/mi-cmd-break.c: Update.
8465         * mi/mi-cmd-stack.c: Update.
8466         * mi/mi-interp.c: Update.
8467         * mi/mi-main.c: Update.
8468         * objc-lang.c: Update.
8469         * p-valprint.c: Update.
8470         * parse.c: Update.
8471         * ppc-linux-tdep.c: Update.
8472         * printcmd.c: Update.
8473         * python/py-arch.c: Update.
8474         * python/py-breakpoint.c: Update.
8475         * python/py-cmd.c: Update.
8476         * python/py-finishbreakpoint.c: Update.
8477         * python/py-frame.c: Update.
8478         * python/py-framefilter.c: Update.
8479         * python/py-gdb-readline.c: Update.
8480         * python/py-inferior.c: Update.
8481         * python/py-infthread.c: Update.
8482         * python/py-lazy-string.c: Update.
8483         * python/py-linetable.c: Update.
8484         * python/py-objfile.c: Update.
8485         * python/py-param.c: Update.
8486         * python/py-prettyprint.c: Update.
8487         * python/py-progspace.c: Update.
8488         * python/py-record-btrace.c: Update.
8489         * python/py-record.c: Update.
8490         * python/py-symbol.c: Update.
8491         * python/py-type.c: Update.
8492         * python/py-unwind.c: Update.
8493         * python/py-utils.c: Update.
8494         * python/py-value.c: Update.
8495         * python/python.c: Update.
8496         * record-btrace.c: Update.
8497         * record-full.c: Update.
8498         * remote-fileio.c: Update.
8499         * remote.c: Update.
8500         * riscv-tdep.c: Update.
8501         * rs6000-aix-tdep.c: Update.
8502         * rs6000-tdep.c: Update.
8503         * rust-exp.y: Update.
8504         * rust-lang.c: Update.
8505         * s390-tdep.c: Update.
8506         * selftest-arch.c: Update.
8507         * solib-dsbt.c: Update.
8508         * solib-frv.c: Update.
8509         * solib-spu.c: Update.
8510         * solib-svr4.c: Update.
8511         * solib.c: Update.
8512         * sparc64-linux-tdep.c: Update.
8513         * stack.c: Update.
8514         * symfile-mem.c: Update.
8515         * symmisc.c: Update.
8516         * target.c: Update.
8517         * thread.c: Update.
8518         * top.c: Update.
8519         * tracefile-tfile.c: Update.
8520         * tui/tui.c: Update.
8521         * typeprint.c: Update.
8522         * unittests/cli-utils-selftests.c: Update.
8523         * unittests/parse-connection-spec-selftests.c: Update.
8524         * valops.c: Update.
8525         * valprint.c: Update.
8526         * value.c: Update.
8527         * varobj.c: Update.
8528         * windows-nat.c: Update.
8529         * x86-linux-nat.c: Update.
8530         * xml-support.c: Update.
8531
8532 2019-04-08  Tom Tromey  <tom@tromey.com>
8533
8534         * xml-support.c: Use C++ exception handling.
8535         * x86-linux-nat.c: Use C++ exception handling.
8536         * windows-nat.c: Use C++ exception handling.
8537         * varobj.c: Use C++ exception handling.
8538         * value.c: Use C++ exception handling.
8539         * valprint.c: Use C++ exception handling.
8540         * valops.c: Use C++ exception handling.
8541         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8542         handling.
8543         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8544         * typeprint.c: Use C++ exception handling.
8545         * tui/tui.c: Use C++ exception handling.
8546         * tracefile-tfile.c: Use C++ exception handling.
8547         * top.c: Use C++ exception handling.
8548         * thread.c: Use C++ exception handling.
8549         * target.c: Use C++ exception handling.
8550         * symmisc.c: Use C++ exception handling.
8551         * symfile-mem.c: Use C++ exception handling.
8552         * stack.c: Use C++ exception handling.
8553         * sparc64-linux-tdep.c: Use C++ exception handling.
8554         * solib.c: Use C++ exception handling.
8555         * solib-svr4.c: Use C++ exception handling.
8556         * solib-spu.c: Use C++ exception handling.
8557         * solib-frv.c: Use C++ exception handling.
8558         * solib-dsbt.c: Use C++ exception handling.
8559         * selftest-arch.c: Use C++ exception handling.
8560         * s390-tdep.c: Use C++ exception handling.
8561         * rust-lang.c: Use C++ exception handling.
8562         * rust-exp.y: Use C++ exception handling.
8563         * rs6000-tdep.c: Use C++ exception handling.
8564         * rs6000-aix-tdep.c: Use C++ exception handling.
8565         * riscv-tdep.c: Use C++ exception handling.
8566         * remote.c: Use C++ exception handling.
8567         * remote-fileio.c: Use C++ exception handling.
8568         * record-full.c: Use C++ exception handling.
8569         * record-btrace.c: Use C++ exception handling.
8570         * python/python.c: Use C++ exception handling.
8571         * python/py-value.c: Use C++ exception handling.
8572         * python/py-utils.c: Use C++ exception handling.
8573         * python/py-unwind.c: Use C++ exception handling.
8574         * python/py-type.c: Use C++ exception handling.
8575         * python/py-symbol.c: Use C++ exception handling.
8576         * python/py-record.c: Use C++ exception handling.
8577         * python/py-record-btrace.c: Use C++ exception handling.
8578         * python/py-progspace.c: Use C++ exception handling.
8579         * python/py-prettyprint.c: Use C++ exception handling.
8580         * python/py-param.c: Use C++ exception handling.
8581         * python/py-objfile.c: Use C++ exception handling.
8582         * python/py-linetable.c: Use C++ exception handling.
8583         * python/py-lazy-string.c: Use C++ exception handling.
8584         * python/py-infthread.c: Use C++ exception handling.
8585         * python/py-inferior.c: Use C++ exception handling.
8586         * python/py-gdb-readline.c: Use C++ exception handling.
8587         * python/py-framefilter.c: Use C++ exception handling.
8588         * python/py-frame.c: Use C++ exception handling.
8589         * python/py-finishbreakpoint.c: Use C++ exception handling.
8590         * python/py-cmd.c: Use C++ exception handling.
8591         * python/py-breakpoint.c: Use C++ exception handling.
8592         * python/py-arch.c: Use C++ exception handling.
8593         * printcmd.c: Use C++ exception handling.
8594         * ppc-linux-tdep.c: Use C++ exception handling.
8595         * parse.c: Use C++ exception handling.
8596         * p-valprint.c: Use C++ exception handling.
8597         * objc-lang.c: Use C++ exception handling.
8598         * mi/mi-main.c: Use C++ exception handling.
8599         * mi/mi-interp.c: Use C++ exception handling.
8600         * mi/mi-cmd-stack.c: Use C++ exception handling.
8601         * mi/mi-cmd-break.c: Use C++ exception handling.
8602         * main.c: Use C++ exception handling.
8603         * linux-thread-db.c: Use C++ exception handling.
8604         * linux-tdep.c: Use C++ exception handling.
8605         * linux-nat.c: Use C++ exception handling.
8606         * linux-fork.c: Use C++ exception handling.
8607         * linespec.c: Use C++ exception handling.
8608         * language.c: Use C++ exception handling.
8609         * jit.c: Use C++ exception handling.
8610         * infrun.c: Use C++ exception handling.
8611         * infcmd.c: Use C++ exception handling.
8612         * infcall.c: Use C++ exception handling.
8613         * inf-loop.c: Use C++ exception handling.
8614         * i386-tdep.c: Use C++ exception handling.
8615         * i386-linux-tdep.c: Use C++ exception handling.
8616         * guile/scm-value.c: Use C++ exception handling.
8617         * guile/scm-type.c: Use C++ exception handling.
8618         * guile/scm-symtab.c: Use C++ exception handling.
8619         * guile/scm-symbol.c: Use C++ exception handling.
8620         * guile/scm-pretty-print.c: Use C++ exception handling.
8621         * guile/scm-ports.c: Use C++ exception handling.
8622         * guile/scm-param.c: Use C++ exception handling.
8623         * guile/scm-math.c: Use C++ exception handling.
8624         * guile/scm-lazy-string.c: Use C++ exception handling.
8625         * guile/scm-frame.c: Use C++ exception handling.
8626         * guile/scm-disasm.c: Use C++ exception handling.
8627         * guile/scm-cmd.c: Use C++ exception handling.
8628         * guile/scm-breakpoint.c: Use C++ exception handling.
8629         * guile/scm-block.c: Use C++ exception handling.
8630         * guile/guile-internal.h: Use C++ exception handling.
8631         * gnu-v3-abi.c: Use C++ exception handling.
8632         * gdbtypes.c: Use C++ exception handling.
8633         * frame.c: Use C++ exception handling.
8634         * frame-unwind.c: Use C++ exception handling.
8635         * fbsd-tdep.c: Use C++ exception handling.
8636         * f-valprint.c: Use C++ exception handling.
8637         * exec.c: Use C++ exception handling.
8638         * event-top.c: Use C++ exception handling.
8639         * event-loop.c: Use C++ exception handling.
8640         * eval.c: Use C++ exception handling.
8641         * dwarf2read.c: Use C++ exception handling.
8642         * dwarf2loc.c: Use C++ exception handling.
8643         * dwarf2-frame.c: Use C++ exception handling.
8644         * dwarf2-frame-tailcall.c: Use C++ exception handling.
8645         * dwarf-index-write.c: Use C++ exception handling.
8646         * dwarf-index-cache.c: Use C++ exception handling.
8647         * dtrace-probe.c: Use C++ exception handling.
8648         * disasm-selftests.c: Use C++ exception handling.
8649         * darwin-nat.c: Use C++ exception handling.
8650         * cp-valprint.c: Use C++ exception handling.
8651         * cp-support.c: Use C++ exception handling.
8652         * cp-abi.c: Use C++ exception handling.
8653         * corelow.c: Use C++ exception handling.
8654         * completer.c: Use C++ exception handling.
8655         * compile/compile-object-run.c: Use C++ exception handling.
8656         * compile/compile-object-load.c: Use C++ exception handling.
8657         * compile/compile-cplus-symbols.c: Use C++ exception handling.
8658         * compile/compile-c-symbols.c: Use C++ exception handling.
8659         * common/selftest.c: Use C++ exception handling.
8660         * common/new-op.c: Use C++ exception handling.
8661         * cli/cli-script.c: Use C++ exception handling.
8662         * cli/cli-interp.c: Use C++ exception handling.
8663         * cli/cli-cmds.c: Use C++ exception handling.
8664         * c-varobj.c: Use C++ exception handling.
8665         * btrace.c: Use C++ exception handling.
8666         * breakpoint.c: Use C++ exception handling.
8667         * break-catch-throw.c: Use C++ exception handling.
8668         * arch-utils.c: Use C++ exception handling.
8669         * amd64-tdep.c: Use C++ exception handling.
8670         * ada-valprint.c: Use C++ exception handling.
8671         * ada-typeprint.c: Use C++ exception handling.
8672         * ada-lang.c: Use C++ exception handling.
8673         * aarch64-tdep.c: Use C++ exception handling.
8674
8675 2019-04-08  Tom Tromey  <tom@tromey.com>
8676
8677         * xml-support.c (gdb_xml_parser::parse): Update.
8678         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
8679         * value.c (show_convenience): Update.
8680         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
8681         (test_parse_flags_qcs): Update.
8682         * thread.c (thr_try_catch_cmd): Update.
8683         * target.c (target_translate_tls_address): Update.
8684         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
8685         (info_frame_command_core, frame_apply_command_count): Update.
8686         * rust-exp.y (rust_lex_exception_test): Update.
8687         * riscv-tdep.c (riscv_print_one_register_info): Update.
8688         * remote.c (remote_target::enable_btrace): Update.
8689         * record-btrace.c (record_btrace_enable_warn): Update.
8690         * python/py-utils.c (gdbpy_convert_exception): Update.
8691         * printcmd.c (do_one_display, print_variable_and_value): Update.
8692         * mi/mi-main.c (mi_print_exception): Update.
8693         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
8694         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
8695         * linux-nat.c (linux_nat_target::attach): Update.
8696         * linux-fork.c (class scoped_switch_fork_info): Update.
8697         * infrun.c (displaced_step_prepare): Update.
8698         * infcall.c (call_function_by_hand_dummy): Update.
8699         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
8700         * gnu-v3-abi.c (print_one_vtable): Update.
8701         * frame.c (get_prev_frame_always): Update.
8702         * f-valprint.c (info_common_command_for_block): Update.
8703         * exec.c (try_open_exec_file): Update.
8704         * exceptions.c (print_exception, exception_print)
8705         (exception_fprintf, exception_print_same): Update.
8706         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
8707         * dwarf-index-cache.c (index_cache::store)
8708         (index_cache::lookup_gdb_index): Update.
8709         * darwin-nat.c (maybe_cache_shell): Update.
8710         * cp-valprint.c (cp_print_value_fields): Update.
8711         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
8712         (gcc_cplus_symbol_address): Update.
8713         * compile/compile-c-symbols.c (gcc_convert_symbol)
8714         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
8715         * common/selftest.c: Update.
8716         * common/common-exceptions.h (struct gdb_exception) <message>: Now
8717         a std::string.
8718         (exception_try_scope_entry, exception_try_scope_exit): Don't
8719         declare.
8720         (struct exception_try_scope): Remove.
8721         (TRY): Don't use exception_try_scope.
8722         (struct gdb_exception): Add constructor, operator=.
8723         <what>: New method.
8724         (struct gdb_exception_RETURN_MASK_ALL)
8725         (struct gdb_exception_RETURN_MASK_ERROR)
8726         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
8727         (struct gdb_quit_bad_alloc): Update.
8728         * common/common-exceptions.c (exception_none): Change
8729         initializer.
8730         (struct catcher) <state, exception>: Initialize inline.
8731         <prev>: Remove member.
8732         (current_catcher): Remove.
8733         (catchers): New global.
8734         (exceptions_state_mc_init): Simplify.
8735         (catcher_pop): Remove.
8736         (exceptions_state_mc, exceptions_state_mc_catch): Update.
8737         (try_scope_depth, exception_try_scope_entry)
8738         (exception_try_scope_exit): Remove.
8739         (throw_exception_sjlj): Update.
8740         (exception_messages, exception_messages_size): Remove.
8741         (throw_it): Simplify.
8742         (gdb_exception_sliced_copy): Remove.
8743         (throw_exception_cxx): Update.
8744         * cli/cli-script.c (script_from_file): Update.
8745         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
8746         Update.
8747         * ada-valprint.c (ada_val_print): Update.
8748         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
8749         (create_excep_cond_exprs): Update.
8750
8751 2019-04-08  Tom Tromey  <tom@tromey.com>
8752
8753         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
8754         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
8755         (TRY, CATCH, END_CATCH): Remove some definitions.
8756         * common/common-exceptions.c: Don't use GDB_XCPT.
8757         (catcher_list_size): Remove.
8758         (throw_exception, throw_it): Simplify.
8759
8760 2019-04-05  Tom Tromey  <tom@tromey.com>
8761
8762         Revert the header-sorting patch.
8763         * ft32-tdep.c: Revert.
8764         * frv-tdep.c: Revert.
8765         * frv-linux-tdep.c: Revert.
8766         * frame.c: Revert.
8767         * frame-unwind.c: Revert.
8768         * frame-base.c: Revert.
8769         * fork-child.c: Revert.
8770         * findvar.c: Revert.
8771         * findcmd.c: Revert.
8772         * filesystem.c: Revert.
8773         * filename-seen-cache.h: Revert.
8774         * filename-seen-cache.c: Revert.
8775         * fbsd-tdep.c: Revert.
8776         * fbsd-nat.h: Revert.
8777         * fbsd-nat.c: Revert.
8778         * f-valprint.c: Revert.
8779         * f-typeprint.c: Revert.
8780         * f-lang.c: Revert.
8781         * extension.h: Revert.
8782         * extension.c: Revert.
8783         * extension-priv.h: Revert.
8784         * expprint.c: Revert.
8785         * exec.h: Revert.
8786         * exec.c: Revert.
8787         * exceptions.c: Revert.
8788         * event-top.c: Revert.
8789         * event-loop.c: Revert.
8790         * eval.c: Revert.
8791         * elfread.c: Revert.
8792         * dwarf2read.h: Revert.
8793         * dwarf2read.c: Revert.
8794         * dwarf2loc.c: Revert.
8795         * dwarf2expr.h: Revert.
8796         * dwarf2expr.c: Revert.
8797         * dwarf2-frame.c: Revert.
8798         * dwarf2-frame-tailcall.c: Revert.
8799         * dwarf-index-write.h: Revert.
8800         * dwarf-index-write.c: Revert.
8801         * dwarf-index-common.c: Revert.
8802         * dwarf-index-cache.h: Revert.
8803         * dwarf-index-cache.c: Revert.
8804         * dummy-frame.c: Revert.
8805         * dtrace-probe.c: Revert.
8806         * disasm.h: Revert.
8807         * disasm.c: Revert.
8808         * disasm-selftests.c: Revert.
8809         * dictionary.c: Revert.
8810         * dicos-tdep.c: Revert.
8811         * demangle.c: Revert.
8812         * dcache.h: Revert.
8813         * dcache.c: Revert.
8814         * darwin-nat.h: Revert.
8815         * darwin-nat.c: Revert.
8816         * darwin-nat-info.c: Revert.
8817         * d-valprint.c: Revert.
8818         * d-namespace.c: Revert.
8819         * d-lang.c: Revert.
8820         * ctf.c: Revert.
8821         * csky-tdep.c: Revert.
8822         * csky-linux-tdep.c: Revert.
8823         * cris-tdep.c: Revert.
8824         * cris-linux-tdep.c: Revert.
8825         * cp-valprint.c: Revert.
8826         * cp-support.c: Revert.
8827         * cp-namespace.c: Revert.
8828         * cp-abi.c: Revert.
8829         * corelow.c: Revert.
8830         * corefile.c: Revert.
8831         * continuations.c: Revert.
8832         * completer.h: Revert.
8833         * completer.c: Revert.
8834         * complaints.c: Revert.
8835         * coffread.c: Revert.
8836         * coff-pe-read.c: Revert.
8837         * cli-out.h: Revert.
8838         * cli-out.c: Revert.
8839         * charset.c: Revert.
8840         * c-varobj.c: Revert.
8841         * c-valprint.c: Revert.
8842         * c-typeprint.c: Revert.
8843         * c-lang.c: Revert.
8844         * buildsym.c: Revert.
8845         * buildsym-legacy.c: Revert.
8846         * build-id.h: Revert.
8847         * build-id.c: Revert.
8848         * btrace.c: Revert.
8849         * bsd-uthread.c: Revert.
8850         * breakpoint.h: Revert.
8851         * breakpoint.c: Revert.
8852         * break-catch-throw.c: Revert.
8853         * break-catch-syscall.c: Revert.
8854         * break-catch-sig.c: Revert.
8855         * blockframe.c: Revert.
8856         * block.c: Revert.
8857         * bfin-tdep.c: Revert.
8858         * bfin-linux-tdep.c: Revert.
8859         * bfd-target.c: Revert.
8860         * bcache.c: Revert.
8861         * ax-general.c: Revert.
8862         * ax-gdb.h: Revert.
8863         * ax-gdb.c: Revert.
8864         * avr-tdep.c: Revert.
8865         * auxv.c: Revert.
8866         * auto-load.c: Revert.
8867         * arm-wince-tdep.c: Revert.
8868         * arm-tdep.c: Revert.
8869         * arm-symbian-tdep.c: Revert.
8870         * arm-pikeos-tdep.c: Revert.
8871         * arm-obsd-tdep.c: Revert.
8872         * arm-nbsd-tdep.c: Revert.
8873         * arm-nbsd-nat.c: Revert.
8874         * arm-linux-tdep.c: Revert.
8875         * arm-linux-nat.c: Revert.
8876         * arm-fbsd-tdep.c: Revert.
8877         * arm-fbsd-nat.c: Revert.
8878         * arm-bsd-tdep.c: Revert.
8879         * arch-utils.c: Revert.
8880         * arc-tdep.c: Revert.
8881         * arc-newlib-tdep.c: Revert.
8882         * annotate.h: Revert.
8883         * annotate.c: Revert.
8884         * amd64-windows-tdep.c: Revert.
8885         * amd64-windows-nat.c: Revert.
8886         * amd64-tdep.c: Revert.
8887         * amd64-sol2-tdep.c: Revert.
8888         * amd64-obsd-tdep.c: Revert.
8889         * amd64-obsd-nat.c: Revert.
8890         * amd64-nbsd-tdep.c: Revert.
8891         * amd64-nbsd-nat.c: Revert.
8892         * amd64-nat.c: Revert.
8893         * amd64-linux-tdep.c: Revert.
8894         * amd64-linux-nat.c: Revert.
8895         * amd64-fbsd-tdep.c: Revert.
8896         * amd64-fbsd-nat.c: Revert.
8897         * amd64-dicos-tdep.c: Revert.
8898         * amd64-darwin-tdep.c: Revert.
8899         * amd64-bsd-nat.c: Revert.
8900         * alpha-tdep.c: Revert.
8901         * alpha-obsd-tdep.c: Revert.
8902         * alpha-nbsd-tdep.c: Revert.
8903         * alpha-mdebug-tdep.c: Revert.
8904         * alpha-linux-tdep.c: Revert.
8905         * alpha-linux-nat.c: Revert.
8906         * alpha-bsd-tdep.c: Revert.
8907         * alpha-bsd-nat.c: Revert.
8908         * aix-thread.c: Revert.
8909         * agent.c: Revert.
8910         * addrmap.c: Revert.
8911         * ada-varobj.c: Revert.
8912         * ada-valprint.c: Revert.
8913         * ada-typeprint.c: Revert.
8914         * ada-tasks.c: Revert.
8915         * ada-lang.c: Revert.
8916         * aarch64-tdep.c: Revert.
8917         * aarch64-ravenscar-thread.c: Revert.
8918         * aarch64-newlib-tdep.c: Revert.
8919         * aarch64-linux-tdep.c: Revert.
8920         * aarch64-linux-nat.c: Revert.
8921         * aarch64-fbsd-tdep.c: Revert.
8922         * aarch64-fbsd-nat.c: Revert.
8923         * aarch32-linux-nat.c: Revert.
8924
8925 2019-04-05  Tom Tromey  <tom@tromey.com>
8926
8927         * ft32-tdep.c: Sort headers.
8928         * frv-tdep.c: Sort headers.
8929         * frv-linux-tdep.c: Sort headers.
8930         * frame.c: Sort headers.
8931         * frame-unwind.c: Sort headers.
8932         * frame-base.c: Sort headers.
8933         * fork-child.c: Sort headers.
8934         * findvar.c: Sort headers.
8935         * findcmd.c: Sort headers.
8936         * filesystem.c: Sort headers.
8937         * filename-seen-cache.h: Sort headers.
8938         * filename-seen-cache.c: Sort headers.
8939         * fbsd-tdep.c: Sort headers.
8940         * fbsd-nat.h: Sort headers.
8941         * fbsd-nat.c: Sort headers.
8942         * f-valprint.c: Sort headers.
8943         * f-typeprint.c: Sort headers.
8944         * f-lang.c: Sort headers.
8945         * extension.h: Sort headers.
8946         * extension.c: Sort headers.
8947         * extension-priv.h: Sort headers.
8948         * expprint.c: Sort headers.
8949         * exec.h: Sort headers.
8950         * exec.c: Sort headers.
8951         * exceptions.c: Sort headers.
8952         * event-top.c: Sort headers.
8953         * event-loop.c: Sort headers.
8954         * eval.c: Sort headers.
8955         * elfread.c: Sort headers.
8956         * dwarf2read.h: Sort headers.
8957         * dwarf2read.c: Sort headers.
8958         * dwarf2loc.c: Sort headers.
8959         * dwarf2expr.h: Sort headers.
8960         * dwarf2expr.c: Sort headers.
8961         * dwarf2-frame.c: Sort headers.
8962         * dwarf2-frame-tailcall.c: Sort headers.
8963         * dwarf-index-write.h: Sort headers.
8964         * dwarf-index-write.c: Sort headers.
8965         * dwarf-index-common.c: Sort headers.
8966         * dwarf-index-cache.h: Sort headers.
8967         * dwarf-index-cache.c: Sort headers.
8968         * dummy-frame.c: Sort headers.
8969         * dtrace-probe.c: Sort headers.
8970         * disasm.h: Sort headers.
8971         * disasm.c: Sort headers.
8972         * disasm-selftests.c: Sort headers.
8973         * dictionary.c: Sort headers.
8974         * dicos-tdep.c: Sort headers.
8975         * demangle.c: Sort headers.
8976         * dcache.h: Sort headers.
8977         * dcache.c: Sort headers.
8978         * darwin-nat.h: Sort headers.
8979         * darwin-nat.c: Sort headers.
8980         * darwin-nat-info.c: Sort headers.
8981         * d-valprint.c: Sort headers.
8982         * d-namespace.c: Sort headers.
8983         * d-lang.c: Sort headers.
8984         * ctf.c: Sort headers.
8985         * csky-tdep.c: Sort headers.
8986         * csky-linux-tdep.c: Sort headers.
8987         * cris-tdep.c: Sort headers.
8988         * cris-linux-tdep.c: Sort headers.
8989         * cp-valprint.c: Sort headers.
8990         * cp-support.c: Sort headers.
8991         * cp-namespace.c: Sort headers.
8992         * cp-abi.c: Sort headers.
8993         * corelow.c: Sort headers.
8994         * corefile.c: Sort headers.
8995         * continuations.c: Sort headers.
8996         * completer.h: Sort headers.
8997         * completer.c: Sort headers.
8998         * complaints.c: Sort headers.
8999         * coffread.c: Sort headers.
9000         * coff-pe-read.c: Sort headers.
9001         * cli-out.h: Sort headers.
9002         * cli-out.c: Sort headers.
9003         * charset.c: Sort headers.
9004         * c-varobj.c: Sort headers.
9005         * c-valprint.c: Sort headers.
9006         * c-typeprint.c: Sort headers.
9007         * c-lang.c: Sort headers.
9008         * buildsym.c: Sort headers.
9009         * buildsym-legacy.c: Sort headers.
9010         * build-id.h: Sort headers.
9011         * build-id.c: Sort headers.
9012         * btrace.c: Sort headers.
9013         * bsd-uthread.c: Sort headers.
9014         * breakpoint.h: Sort headers.
9015         * breakpoint.c: Sort headers.
9016         * break-catch-throw.c: Sort headers.
9017         * break-catch-syscall.c: Sort headers.
9018         * break-catch-sig.c: Sort headers.
9019         * blockframe.c: Sort headers.
9020         * block.c: Sort headers.
9021         * bfin-tdep.c: Sort headers.
9022         * bfin-linux-tdep.c: Sort headers.
9023         * bfd-target.c: Sort headers.
9024         * bcache.c: Sort headers.
9025         * ax-general.c: Sort headers.
9026         * ax-gdb.h: Sort headers.
9027         * ax-gdb.c: Sort headers.
9028         * avr-tdep.c: Sort headers.
9029         * auxv.c: Sort headers.
9030         * auto-load.c: Sort headers.
9031         * arm-wince-tdep.c: Sort headers.
9032         * arm-tdep.c: Sort headers.
9033         * arm-symbian-tdep.c: Sort headers.
9034         * arm-pikeos-tdep.c: Sort headers.
9035         * arm-obsd-tdep.c: Sort headers.
9036         * arm-nbsd-tdep.c: Sort headers.
9037         * arm-nbsd-nat.c: Sort headers.
9038         * arm-linux-tdep.c: Sort headers.
9039         * arm-linux-nat.c: Sort headers.
9040         * arm-fbsd-tdep.c: Sort headers.
9041         * arm-fbsd-nat.c: Sort headers.
9042         * arm-bsd-tdep.c: Sort headers.
9043         * arch-utils.c: Sort headers.
9044         * arc-tdep.c: Sort headers.
9045         * arc-newlib-tdep.c: Sort headers.
9046         * annotate.h: Sort headers.
9047         * annotate.c: Sort headers.
9048         * amd64-windows-tdep.c: Sort headers.
9049         * amd64-windows-nat.c: Sort headers.
9050         * amd64-tdep.c: Sort headers.
9051         * amd64-sol2-tdep.c: Sort headers.
9052         * amd64-obsd-tdep.c: Sort headers.
9053         * amd64-obsd-nat.c: Sort headers.
9054         * amd64-nbsd-tdep.c: Sort headers.
9055         * amd64-nbsd-nat.c: Sort headers.
9056         * amd64-nat.c: Sort headers.
9057         * amd64-linux-tdep.c: Sort headers.
9058         * amd64-linux-nat.c: Sort headers.
9059         * amd64-fbsd-tdep.c: Sort headers.
9060         * amd64-fbsd-nat.c: Sort headers.
9061         * amd64-dicos-tdep.c: Sort headers.
9062         * amd64-darwin-tdep.c: Sort headers.
9063         * amd64-bsd-nat.c: Sort headers.
9064         * alpha-tdep.c: Sort headers.
9065         * alpha-obsd-tdep.c: Sort headers.
9066         * alpha-nbsd-tdep.c: Sort headers.
9067         * alpha-mdebug-tdep.c: Sort headers.
9068         * alpha-linux-tdep.c: Sort headers.
9069         * alpha-linux-nat.c: Sort headers.
9070         * alpha-bsd-tdep.c: Sort headers.
9071         * alpha-bsd-nat.c: Sort headers.
9072         * aix-thread.c: Sort headers.
9073         * agent.c: Sort headers.
9074         * addrmap.c: Sort headers.
9075         * ada-varobj.c: Sort headers.
9076         * ada-valprint.c: Sort headers.
9077         * ada-typeprint.c: Sort headers.
9078         * ada-tasks.c: Sort headers.
9079         * ada-lang.c: Sort headers.
9080         * aarch64-tdep.c: Sort headers.
9081         * aarch64-ravenscar-thread.c: Sort headers.
9082         * aarch64-newlib-tdep.c: Sort headers.
9083         * aarch64-linux-tdep.c: Sort headers.
9084         * aarch64-linux-nat.c: Sort headers.
9085         * aarch64-fbsd-tdep.c: Sort headers.
9086         * aarch64-fbsd-nat.c: Sort headers.
9087         * aarch32-linux-nat.c: Sort headers.
9088
9089 2019-04-04  Tom Tromey  <tom@tromey.com>
9090
9091         * varobj.c (varobj_create): Update.
9092         * rust-exp.y (struct rust_parser) <update_innermost_block,
9093         lookup_symbol>: New methods.
9094         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9095         Rename.
9096         (rust_parser::rust_lookup_type)
9097         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9098         * printcmd.c (display_command, do_one_display): Update.
9099         * parser-defs.h (struct parser_state) <parser_state>: Add
9100         "tracker" parameter.
9101         (block_tracker): New member.
9102         (class innermost_block_tracker) <innermost_block_tracker>: Add
9103         "types" parameter.
9104         <reset>: Remove method.
9105         (innermost_block): Don't declare.
9106         (null_post_parser): Update.
9107         * parse.c (innermost_block): Remove global.
9108         (write_dollar_variable): Update.
9109         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9110         Remove "tracker_types" parameter.
9111         (parse_expression): Add "tracker" parameter.
9112         (parse_expression_for_completion): Update.
9113         (null_post_parser): Add "tracker" parameter.
9114         * p-exp.y: Update rules.
9115         * m2-exp.y: Update rules.
9116         * language.h (struct language_defn) <la_post_parser>: Add
9117         "tracker" parameter.
9118         * go-exp.y: Update rules.
9119         * f-exp.y: Update rules.
9120         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9121         parameter.
9122         * d-exp.y: Update rules.
9123         * c-exp.y: Update rules.
9124         * breakpoint.c (set_breakpoint_condition): Create an
9125         innermost_block_tracker.
9126         (watch_command_1): Likewise.
9127         * ada-lang.c (resolve): Add "tracker" parameter.
9128         (resolve_subexp): Likewise.
9129         * ada-exp.y (write_var_from_sym): Update.
9130
9131 2019-04-04  Tom Tromey  <tom@tromey.com>
9132
9133         * type-stack.h: New file.
9134         * type-stack.c: New file.
9135         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9136         type-stack.h.
9137         (insert_into_type_stack, insert_type, push_type, push_type_int)
9138         (insert_type_address_space, pop_type, pop_type_int)
9139         (pop_typelist, pop_type_stack, append_type_stack)
9140         (push_type_stack, get_type_stack, push_typelist)
9141         (follow_type_instance_flags, follow_types): Don't declare.
9142         * parse.c (type_stack): Remove global.
9143         (parse_exp_in_context): Update.
9144         (insert_into_type_stack, insert_type, push_type, push_type_int)
9145         (insert_type_address_space, pop_type, pop_type_int)
9146         (pop_typelist, pop_type_stack, append_type_stack)
9147         (push_type_stack, get_type_stack, push_typelist)
9148         (follow_type_instance_flags, follow_types): Remove (moved to
9149         type-stack.c).
9150         * f-exp.y (type_stack): New global.
9151         Update rules.
9152         (push_kind_type, f_parse): Update.
9153         * d-exp.y (type_stack): New global.
9154         Update rules.
9155         (d_parse): Update.
9156         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9157         Update rules.
9158         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9159         (HFILES_NO_SRCDIR): Add type-stack.h.
9160
9161 2019-04-04  Tom Tromey  <tom@tromey.com>
9162
9163         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9164         (rust_parser::convert_ast_to_expression, rust_parse)
9165         (rust_lex_test_completion, rust_lex_tests): Update.
9166         * parser-defs.h (struct expr_completion_state): New.
9167         (struct parser_state) <parser_state>: Add completion parameter.
9168         <mark_struct_expression, mark_completion_tag>: New methods.
9169         <parse_completion, m_completion_state>: New members.
9170         (prefixify_expression, null_post_parser): Update.
9171         (mark_struct_expression, mark_completion_tag): Don't declare.
9172         * parse.c (parse_completion, expout_last_struct)
9173         (expout_tag_completion_type, expout_completion_name): Remove
9174         globals.
9175         (parser_state::mark_struct_expression)
9176         (parser_state::mark_completion_tag): Now methods.
9177         (prefixify_expression): Add last_struct parameter.
9178         (prefixify_subexp): Likewise.
9179         (parse_exp_1): Update.
9180         (parse_exp_in_context): Add cstate parameter.  Update.
9181         (parse_expression_for_completion): Create an
9182         expr_completion_state.
9183         (null_post_parser): Add "completion" parameter.
9184         * p-exp.y: Update rules.
9185         (yylex): Update.
9186         * language.h (struct language_defn) <la_post_parser>: Add
9187         "completing" parameter.
9188         * go-exp.y: Update rules.
9189         (lex_one_token): Update.
9190         * expression.h (parse_completion): Don't declare.
9191         * d-exp.y: Update rules.
9192         (lex_one_token): Update rules.
9193         * c-exp.y: Update rules.
9194         (lex_one_token): Update.
9195         * ada-lang.c (resolve): Add "parse_completion" parameter.
9196         (resolve_subexp): Likewise.
9197         (ada_resolve_function): Likewise.
9198
9199 2019-04-04  Tom Tromey  <tom@tromey.com>
9200
9201         * parser-defs.h (struct parser_state) <start_arglist,
9202         end_arglist>: New methods.
9203         <arglist_len, m_funcall_chain>: New members.
9204         (arglist_len, start_arglist, end_arglist): Don't declare.
9205         * parse.c (arglist_len, funcall_chain): Remove global.
9206         (start_arglist, end_arglist): Remove functions.
9207         (parse_exp_in_context): Update.
9208         * p-exp.y: Update rules.
9209         * m2-exp.y: Update rules.
9210         * go-exp.y: Update rules.
9211         * f-exp.y: Update rules.
9212         * d-exp.y: Update rules.
9213         * c-exp.y: Update rules.
9214
9215 2019-04-04  Tom Tromey  <tom@tromey.com>
9216
9217         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9218         lex_operator, push_back>: New methods.
9219         Update all rules.
9220         (rust_parser::lex_hex, lex_escape): Rename and update.
9221         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9222         (rust_parser::lex_operator): Rename and update.
9223         (rust_parser::lex_number, rustyylex, rustyyerror)
9224         (rust_lex_test_init, rust_lex_test_sequence)
9225         (rust_lex_test_push_back, rust_lex_tests): Update.
9226         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9227         parameter.
9228         <lexptr, prev_lexptr>: New members.
9229         (lexptr, prev_lexptr): Don't declare.
9230         * parse.c (lexptr, prev_lexptr): Remove globals.
9231         (parse_exp_in_context): Update.
9232         * p-exp.y (yylex, yyerror): Update.
9233         * m2-exp.y (parse_number, yylex, yyerror): Update.
9234         * go-exp.y (lex_one_token, yyerror): Update.
9235         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9236         * d-exp.y (lex_one_token, yyerror): Update.
9237         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9238         (lex_one_token, yyerror): Update.
9239         * ada-lex.l (YY_INPUT): Update.
9240         (rewind_to_char): Update.
9241         * ada-exp.y (yyerror): Update.
9242
9243 2019-04-04  Tom Tromey  <tom@tromey.com>
9244
9245         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9246         * parser-defs.h (struct parser_state) <parser_state>: Add new
9247         parameter.
9248         <comma_terminates>: New member.
9249         (comma_terminates): Don't declare global.
9250         * parse.c (comma_terminates): Remove global.
9251         (parse_exp_in_context): Update.
9252         * p-exp.y (yylex): Update.
9253         * m2-exp.y (yylex): Update.
9254         * go-exp.y (lex_one_token): Update.
9255         * f-exp.y (yylex): Update.
9256         * d-exp.y (lex_one_token): Update.
9257         * c-exp.y (lex_one_token): Update.
9258         * ada-lex.l: Update.
9259
9260 2019-04-04  Tom Tromey  <tom@tromey.com>
9261
9262         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9263         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9264         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9265         * parser-defs.h (paren_depth): Don't declare.
9266         * parse.c (paren_depth): Remove global.
9267         (parse_exp_in_context): Update.
9268         * p-exp.y (paren_depth): New global.
9269         (pascal_parse): Initialize it.
9270         * m2-exp.y (paren_depth): New global.
9271         (m2_parse): Initialize it.
9272         * go-exp.y (paren_depth): New global.
9273         (go_parse): Initialize it.
9274         * f-exp.y (paren_depth): New global.
9275         (f_parse): Initialize it.
9276         * d-exp.y (paren_depth): New global.
9277         (d_parse): Initialize it.
9278         * c-exp.y (paren_depth): New global.
9279         (c_parse): Initialize it.
9280         * ada-lex.l (paren_depth): New global.
9281         (lexer_init): Initialize it.
9282
9283 2019-04-04  Tom Tromey  <tom@tromey.com>
9284
9285         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9286         (rust_parser::convert_ast_to_type)
9287         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9288         * parser-defs.h (struct parser_state) <parser_state>: Add
9289         parameters.  Initialize new members.
9290         <expression_context_block, expression_context_pc>: New members.
9291         * parse.c (expression_context_block, expression_context_pc):
9292         Remove globals.
9293         (parse_exp_in_context): Update.
9294         * p-exp.y: Update all rules.
9295         (yylex): Update.
9296         * m2-exp.y: Update all rules.
9297         (yylex): Update.
9298         * go-exp.y (yylex): Update.
9299         * f-exp.y (yylex): Update.
9300         * d-exp.y: Update all rules.
9301         (yylex): Update.
9302         * c-exp.y: Update all rules.
9303         (lex_one_token, classify_name, yylex, c_parse): Update.
9304         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9305
9306 2019-04-04  Tom Tromey  <tom@tromey.com>
9307
9308         * gdbarch.h, gdbarch.c: Rebuild.
9309         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9310         * stap-probe.h:
9311         (struct stap_parse_info): Replace "parser_state" with
9312         "expr_builder".
9313         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9314         (parser_state): New class.
9315         * parse.c (expr_builder): Rename.
9316         (expr_builder::release): Rename.
9317         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9318         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9319         (write_exp_elt_longcst, write_exp_elt_floatcst)
9320         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9321         (write_exp_string_vector, write_exp_bitstring)
9322         (write_exp_msymbol, mark_struct_expression)
9323         (write_dollar_variable)
9324         (insert_type_address_space, increase_expout_size): Replace
9325         "parser_state" with "expr_builder".
9326         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9327         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9328         "parser_state" with "expr_builder".
9329
9330 2019-04-04  Tom Tromey  <tom@tromey.com>
9331
9332         * rust-exp.y: Replace "parse_language" with method call.
9333         * p-exp.y:
9334         (yylex): Replace "parse_language" with method call.
9335         * m2-exp.y:
9336         (yylex): Replace "parse_language" with method call.
9337         * go-exp.y (classify_name): Replace "parse_language" with method
9338         call.
9339         * f-exp.y (yylex): Replace "parse_language" with method call.
9340         * d-exp.y (lex_one_token): Replace "parse_language" with method
9341         call.
9342         * c-exp.y:
9343         (lex_one_token, classify_name, yylex): Replace "parse_language"
9344         with method call.
9345         * ada-exp.y (find_primitive_type, type_char)
9346         (type_system_address): Replace "parse_language" with method call.
9347
9348 2019-04-04  Tom Tromey  <tom@tromey.com>
9349
9350         * rust-exp.y: Replace "parse_gdbarch" with method call.
9351         * parse.c (write_dollar_variable, insert_type_address_space):
9352         Replace "parse_gdbarch" with method call.
9353         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9354         call.
9355         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9356         call.
9357         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9358         "parse_gdbarch" with method call.
9359         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9360         with method call.
9361         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9362         "parse_gdbarch" with method call.
9363         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9364         "parse_gdbarch" with method call.
9365         * c-exp.y (parse_type, parse_number, classify_name): Replace
9366         "parse_gdbarch" with method call.
9367         * ada-lex.l: Replace "parse_gdbarch" with method call.
9368         * ada-exp.y (parse_type, find_primitive_type, type_char)
9369         (type_system_address): Replace "parse_gdbarch" with method call.
9370
9371 2019-04-04  Tom Tromey  <tom@tromey.com>
9372
9373         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9374         * stap-probe.c (stap_parse_argument): Update.
9375         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9376         initial_size parameter.
9377         * rust-exp.y (rust_lex_tests): Update.
9378         * parse.c (parser_state): Update.
9379         (parse_exp_in_context): Update.
9380         * parser-defs.h (struct parser_state) <parser_state>: Remove
9381         "initial_size" parameter.
9382
9383 2019-04-04  Tom Tromey  <tom@tromey.com>
9384
9385         * parser-defs.h (increase_expout_size): Don't declare.
9386         * parse.c (increase_expout_size): Now static.
9387
9388 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9389
9390         * gnu-nat.c (gnu_nat_target::wait): Fix
9391         target_waitstatus_to_string call.
9392
9393 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9394
9395         * eval.c (evaluate_subexp_standard): Handle internal functions
9396         during Fortran function call handling.
9397
9398 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9399
9400         * NEWS: Mention new internal functions.
9401         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9402         (read_base_type): Use dwarf2_init_complex_target_type.
9403         * value.c (creal_internal_fn): New function.
9404         (cimag_internal_fn): New function.
9405         (_initialize_values): Register new internal functions.
9406
9407 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9408
9409         * infrun.c (stop_all_threads): If debug_infrun, always
9410         trace the wait status after wait_one, using
9411         target_waitstatus_to_string and target_pid_to_str.
9412         (handle_inferior_event): Replace various trace of
9413         wait status kind by a single trace.
9414         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9415         wait status kind image by target_waitstatus_to_string.
9416         * target/waitstatus.c (target_waitstatus_to_string): Fix
9417         obsolete comment.
9418
9419 2019-04-01  Tom Tromey  <tromey@adacore.com>
9420
9421         PR symtab/23331:
9422         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9423
9424 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9425             Pedro Alves  <palves@redhat.com>
9426
9427         * top.c (quit_force): Call 'finalize_values'.
9428         * value.c (finalize_values): New function.
9429         * value.h (finalize_values): Declare.
9430
9431 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9432
9433         * NEWS: Announce $_gdb_major and $_gdb_minor.
9434
9435         * top.c (init_gdb_version_vars): New function.
9436         (gdb_init): Call init_gdb_version_vars.
9437
9438 2019-03-29  Tom Tromey  <tromey@adacore.com>
9439
9440         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9441         help text.  Remove dead code.
9442
9443 2019-03-29  Keith Seitz  <keiths@redhat.com>
9444
9445         From Siddhesh Poyarekar:
9446         * f-lang.h (f77_get_upperbound): Return LONGEST.
9447         (f77_get_lowerbound): Likewise.
9448         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9449         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9450         print them.
9451         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9452         plongest to format print it.
9453         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9454         (f77_get_upperbound): Likewise.
9455         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9456         LOWER_BOUND to LONGEST.
9457         (f77_create_arrayprint_offset_tbl): Likewise.
9458
9459 2019-03-29  Keith Seitz  <keiths@redhat.com>
9460
9461         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9462         %s/pulongest for TYPE_LENGTH instead of %d in format
9463         strings.
9464         * ada-typerint.c (ada_print_type): Likewise.
9465         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9466         * compile/compile-c-support.c (generate_register_struct): Likewise.
9467         * gdbtypes.c (recursive_dump_type): Likewise.
9468         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9469         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9470         instead of %d in format strings.
9471         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9472         to std::min to ULONGEST.
9473         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9474         instead of %d in format strings.
9475         * tracepoint.c (info_scope_command): Likewise.
9476         * typeprint.c (print_offset_data::update)
9477         (print_offset_data::finish): Likewise.
9478         * xtensa-tdep.c (xtensa_store_return_value)
9479         (xtensa_push_dummy_call): Likewise.
9480
9481 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9482
9483         * windows-nat.c (display_selector): Fixed format specifications
9484         for 64-bit Cygwin.
9485
9486 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9487
9488         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9489
9490 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9491
9492         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9493         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9494         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9495         (nios2_linux_init_abi): Install it.
9496
9497 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9498
9499         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9500
9501 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9502
9503         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9504
9505 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9506             Tom Tromey  <tromey@adacore.com>
9507
9508         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9509
9510 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9511
9512         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9513         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9514         method to compute the bounds of range types. Also print "[evaluated]"
9515         if the bounds' values come from a dynamic evaluation.
9516
9517 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9518
9519         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9520         whitespace when pretty printing is on.
9521
9522 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9523
9524         * ppc-linux-nat.c: Add include.
9525
9526 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9527
9528         * NEWS: Mention AArch64 Pointer Authentication.
9529
9530 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9531
9532         * arm-linux-nat.c: Add include.
9533
9534 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9535
9536         * source-cache.c (source_cache::get_source_lines): Re-read
9537         fullname after calling open_source_file.
9538
9539 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9540
9541         * NEWS: Mention TLS support for FreeBSD.
9542
9543 2019-03-25  Tom Tromey  <tromey@adacore.com>
9544
9545         * minsyms.c (BUNCH_SIZE): Update comment.
9546         (~minimal_symbol_reader): Remove old comment.
9547         (compact_minimal_symbols): Update comment.
9548         (minimal_symbol_reader::install): Remove old comment.  Update
9549         other comments.
9550
9551 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9552
9553         * s390-linux-nat.c: Add include.
9554
9555 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9556
9557         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9558         Call linux_get_hwcap.
9559         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9560         Likewise.
9561         (aarch64_linux_get_hwcap): Remove function.
9562         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9563         declaration.
9564         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9565         linux_get_hwcap.
9566         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9567         * linux-tdep.c (linux_get_hwcap): Add function.
9568         (linux_get_hwcap2): Likewise.
9569         * linux-tdep.h (linux_get_hwcap): Add declaration.
9570         (linux_get_hwcap2): Likewise.
9571         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9572         (ppc_linux_get_hwcap2): Likewise.
9573         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9574         linux_get_hwcap.
9575         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9576         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9577         (ppc_linux_nat_target::read_description): Likewise.
9578         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9579         * s390-linux-nat.c: Likewise.
9580         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9581
9582 2019-03-24  Tom Tromey  <tom@tromey.com>
9583
9584         * ada-lang.c (standard_lookup): Simplify initialization.
9585         (ada_lookup_symbol_nonlocal): Simplify return.
9586         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9587         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9588         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9589         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9590         initialization.
9591         * solib.c (solib_global_lookup): Simplify.
9592         * symtab.c (null_block_symbol): Remove.
9593         (symbol_cache_lookup): Simplify returns.
9594         (lookup_language_this): Simplify returns.
9595         (lookup_symbol_aux): Simplify return.
9596         (lookup_local_symbol): Simplify returns.
9597         (lookup_global_symbol_from_objfile): Simplify return.
9598         (lookup_symbol_in_objfile_symtabs)
9599         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9600         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9601         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9602         * cp-namespace.c (cp_lookup_bare_symbol)
9603         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9604         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9605         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9606         (cp_lookup_symbol_via_imports): Simplify initialization.
9607         (find_symbol_in_baseclass): Likewise.
9608         * symtab.h (null_block_symbol): Remove.
9609         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9610         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9611         (d_lookup_symbol_module): Likewise.
9612         (find_symbol_in_baseclass): Simplify initialization.
9613
9614 2019-03-24  Tom Tromey  <tom@tromey.com>
9615
9616         * expression.h: Don't include symtab.h.
9617         (struct block): Forward declare.
9618
9619 2019-03-24  Tom Tromey  <tom@tromey.com>
9620
9621         * c-exp.y (typebase): Remove casts.
9622         * gdbtypes.c (lookup_unsigned_typename, )
9623         (lookup_signed_typename): Remove cast.
9624         * eval.c (parse_to_comma_and_eval): Remove cast.
9625         * parse.c (write_dollar_variable): Remove cast.
9626         * block.h (struct block) <superblock>: Now const.
9627         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9628         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9629         (map_block): Make "block" const.
9630         * symfile.h (struct quick_symbol_functions)
9631         <map_matching_symbols>: Constify block argument to "callback".
9632         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9633         const.
9634         (find_pc_sect_compunit_symtab): Make "b" const.
9635         (find_symbol_at_address): Likewise.
9636         (search_symbols): Likewise.
9637         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9638         (dw2_debug_names_lookup_symbol): Likewise.
9639         (dw2_map_matching_symbols): Update.
9640         * p-valprint.c (pascal_val_print): Remove "block".
9641         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9642         (aux_add_nonlocal_symbols): Make "block" const.
9643         (resolve_subexp): Remove cast.
9644         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
9645         const.
9646         (iterate_over_file_blocks): Likewise.
9647         * f-exp.y (%union) <bval>: Remove.
9648         * coffread.c (patch_opaque_types): Make "b" const.
9649         * spu-tdep.c (spu_catch_start): Make "block" const.
9650         * c-valprint.c (print_unpacked_pointer): Remove "block".
9651         * symmisc.c (dump_symtab_1): Make "b" const.
9652         (block_depth): Make "block" const.
9653         * d-exp.y (%union) <bval>: Remove.
9654         * cp-support.h (cp_lookup_rtti_type): Update.
9655         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
9656         * psymtab.c (psym_lookup_symbol): Make "block" const.
9657         (maintenance_check_psymtabs): Make "b" const.
9658         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
9659         (enumerate_locals, enumerate_args): Update.
9660         * python/py-symtab.c (stpy_global_block): Make "block" const.
9661         (stpy_static_block): Likewise.
9662         * inline-frame.c (block_starting_point_at): Make "new_block"
9663         const.
9664         * block.c (find_block_in_blockvector): Make return type const.
9665         (blockvector_for_pc_sect): Make "b" const.
9666         (find_block_in_blockvector): Make "b" const.
9667
9668 2019-03-23  Tom Tromey  <tom@tromey.com>
9669
9670         * varobj.c (varobj_create): Update.
9671         * symfile.c (clear_symtab_users): Don't reset innermost_block.
9672         * printcmd.c (display_command, do_one_display): Don't reset
9673         innermost_block.
9674         * parser-defs.h (enum innermost_block_tracker_type): Move to
9675         expression.h.
9676         (innermost_block): Update comment.
9677         * parse.c (parse_exp_1): Add tracker_types parameter.
9678         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
9679         tracker_types parameter.  Reset innermost_block.
9680         (parse_exp_in_context): Remove.
9681         (parse_expression_for_completion): Update.
9682         * objfiles.c (~objfile): Don't reset expression_context_block or
9683         innermost_block.
9684         * expression.h (enum innermost_block_tracker_type): Move from
9685         parser-defs.h.
9686         (parse_exp_1): Add tracker_types parameter.
9687         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
9688         reset innermost_block.
9689
9690 2019-03-23  Tom Tromey  <tom@tromey.com>
9691
9692         * objfiles.h: Include bcache.h.
9693
9694 2019-03-23  Tom Tromey  <tom@tromey.com>
9695
9696         * linespec.c (get_current_search_block): Use
9697         scoped_restore_current_language.
9698         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
9699
9700 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9701             Jiong Wang  <jiong.wang@arm.com>
9702
9703         * aarch64-linux-tdep.c
9704         (aarch64_linux_iterate_over_regset_sections): Check for pauth
9705         section.
9706         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
9707
9708 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9709             Jiong Wang  <jiong.wang@arm.com>
9710
9711         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
9712         instructions.
9713         (aarch64_analyze_prologue_test): Add PACIASP test.
9714         (aarch64_prologue_prev_register): Unmask PC value.
9715
9716 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9717             Jiong Wang  <jiong.wang@arm.com>
9718
9719         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
9720         (aarch64_dwarf2_prev_register): Unmask PC value.
9721         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
9722         (aarch64_execute_dwarf_cfa_vendor_op): Check for
9723         DW_CFA_AARCH64_negate_ra_state.
9724         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
9725
9726 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9727             Jiong Wang  <jiong.wang@arm.com>
9728
9729         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
9730         registers.
9731         (aarch64_pseudo_register_name): Likewise.
9732         (aarch64_pseudo_register_type): Likewise.
9733         (aarch64_pseudo_register_reggroup_p): Likewise.
9734         (aarch64_gdbarch_init): Add pauth registers.
9735         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
9736         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
9737         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
9738         (struct gdbarch_tdep): Add regnum for ra_state.
9739
9740 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9741             Jiong Wang  <jiong.wang@arm.com>
9742
9743         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
9744
9745 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9746             Jiong Wang  <jiong.wang@arm.com>
9747
9748         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
9749         function.
9750         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
9751         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
9752         (aarch64_gdbarch_init): Add puth registers.
9753         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
9754         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
9755         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
9756
9757 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9758             Jiong Wang  <jiong.wang@arm.com>
9759
9760         * aarch64-linux-nat.c
9761         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
9762         * aarch64-linux-tdep.c
9763         (aarch64_linux_core_read_description): Likewise.
9764         (aarch64_linux_get_hwcap): New function.
9765         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
9766         (aarch64_linux_get_hwcap): New declaration.
9767
9768 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
9769             Jiong Wang  <jiong.wang@arm.com>
9770
9771         * aarch64-linux-nat.c
9772         (aarch64_linux_nat_target::read_description): Add pauth param.
9773         * aarch64-linux-tdep.c
9774         (aarch64_linux_core_read_description): Likewise.
9775         * aarch64-tdep.c (struct target_desc): Add in pauth.
9776         (aarch64_read_description): Add pauth param.
9777         (aarch64_gdbarch_init): Likewise.
9778         * aarch64-tdep.h (aarch64_read_description): Likewise.
9779         * arch/aarch64.c (aarch64_create_target_description): Likewise.
9780         * arch/aarch64.h (aarch64_create_target_description): Likewise.
9781         * features/Makefile: Add new files.
9782         * features/aarch64-pauth.c: New file.
9783         * features/aarch64-pauth.xml: New file.
9784
9785 2019-03-20  Tom Tromey  <tromey@adacore.com>
9786
9787         * infrun.c (handle_inferior_event): Rename from
9788         handle_inferior_event_1.  Create a scoped_value_mark.
9789         (handle_inferior_event): Remove.
9790
9791 2019-03-19  Tom Tromey  <tromey@adacore.com>
9792
9793         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
9794         * infrun.h (print_stop_event): Add "displays" parameter.
9795         * infrun.c (print_stop_event): Add "displays" parameter.
9796
9797 2019-03-19  Pedro Alves  <palves@redhat.com>
9798
9799         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
9800         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
9801         to -1.  Fix TABs vs spaces.
9802         (tui_ui_out::tui_ui_out): Don't initialize fields here.
9803         * tui/tui-out.h (tui_ui_out) Add intro comments.
9804         <m_line, m_start_of_line>: In-class initialize, and add describing
9805         comment.
9806
9807 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
9808
9809         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
9810         variable names.
9811         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
9812
9813 2019-03-18  Pedro Alves  <palves@redhat.com>
9814             Eli Zaretskii <eliz@gnu.org>
9815
9816         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
9817         m_line and m_start_of_line.
9818
9819 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
9820
9821         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
9822         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
9823         it returns a newline.  This fixes a regression in TU mode, whereby
9824         the next line is output on the same screen line as the user input.
9825
9826 2019-03-18  Tom Tromey  <tromey@adacore.com>
9827
9828         * minsyms.c (minimal_symbol_reader::install): Remove call to
9829         obstack_blank.
9830
9831 2019-03-18  Pedro Alves  <palves@redhat.com>
9832
9833         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
9834         New globals.
9835         (apply_style): New, factored out from ...
9836         (apply_ansi_escape): ... this.  Handle reverse video mode.
9837         (tui_set_reverse_mode): New function.
9838         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
9839         * tui/tui-winsource.c (tui_show_source_line): Use
9840         tui_set_reverse_mode instead of setting A_STANDOUT.
9841         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
9842         New setter methods.
9843
9844 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
9845
9846         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
9847         Handle tabs.
9848
9849 2019-03-18  Tom Tromey  <tromey@adacore.com>
9850
9851         * ada-lang.c (empty_array): Add "high" parameter.
9852         (ada_evaluate_subexp): Update.
9853
9854 2019-03-17  Sergei Trofimovich <siarheit@google.com>
9855
9856         * unittests/string_view-selftests.c: Define
9857         _initialize_string_view_selftests unconditionally.
9858
9859 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9860
9861         PR gdb/24350
9862         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
9863
9864 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
9865
9866         PR gdb/24351
9867         * windows-nat.c (display_selector): Fix format specifiers.
9868
9869 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
9870
9871         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
9872         tui_refill_source_window instead of tui_refresh_win, to update the
9873         current execution line.  This fixes redisplay of the current line
9874         when stepping through the code with "next" or "step".
9875
9876 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9877
9878         * source-cache.c (source_cache::get_source_lines): Call
9879         find_source_lines to initialize s->nlines.  This fixes vertical
9880         scrolling of TUI source window when the DOWN arrow is pressed.
9881
9882 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9883
9884         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
9885         linux-thread-db.c (_initialize_thread_db): Likewise.
9886
9887 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
9888
9889         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
9890         wclrtoeol in tui_show_source_line".  This reverts changes made in
9891         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
9892
9893 2019-03-15  Tom Tromey  <tom@tromey.com>
9894
9895         * symtab.h (struct minimal_symbol): Derive from
9896         general_symbol_info.
9897         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
9898         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
9899         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
9900         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
9901         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
9902         (MSYMBOL_SEARCH_NAME): Update.
9903         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
9904         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
9905         * minsyms.c (minimal_symbol_reader::record_full): Update.
9906
9907 2019-03-15  Tom Tromey  <tom@tromey.com>
9908
9909         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
9910
9911 2019-03-15  Tom Tromey  <tom@tromey.com>
9912
9913         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
9914         unique_xmalloc_ptr.
9915         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
9916         Update.
9917         * minsyms.c (lookup_minimal_symbol_by_pc_section)
9918         (build_minimal_symbol_hash_tables)
9919         (minimal_symbol_reader::install): Update.
9920
9921 2019-03-15  Tom Tromey  <tom@tromey.com>
9922
9923         * symtab.c (create_demangled_names_hash): Update.
9924         (symbol_set_names): Update.
9925         * objfiles.h (struct objfile_per_bfd_storage)
9926         <demangled_names_hash>: Now an htab_up.
9927         * objfiles.c (objfile_per_bfd_storage): Simplify.
9928
9929 2019-03-15  Tom Tromey  <tom@tromey.com>
9930
9931         * objfiles.h (struct objfile_per_bfd_storage): Declare
9932         destructor.
9933         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
9934         New.
9935         (get_objfile_bfd_data): Use new.  Don't initialize
9936         language_of_main.
9937         (free_objfile_per_bfd_storage): Remove.
9938         (objfile_bfd_data_free, objfile::~objfile): Use delete.
9939
9940 2019-03-15  Tom Tromey  <tom@tromey.com>
9941
9942         * symfile.c (reread_symbols): Update.
9943         * objfiles.c (objfile::objfile): Update.
9944         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
9945         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
9946         comment.
9947         (minimal_symbol_reader::install): Update.
9948         (terminate_minimal_symbol_table): Remove.
9949         * jit.c (jit_object_close_impl): Update.
9950
9951 2019-03-15  Tom Tromey  <tom@tromey.com>
9952
9953         * minsyms.c (minimal_symbol_reader::record_full): Remove some
9954         initializations.
9955
9956 2019-03-15  Tom Tromey  <tom@tromey.com>
9957
9958         * objfiles.h (struct objfile_per_bfd_storage)
9959         <demangled_hash_languages>: Now a bitset.
9960         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
9961         (lookup_minimal_symbol): Update.
9962
9963 2019-03-15  Tom Tromey  <tom@tromey.com>
9964
9965         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
9966         Don't return the symbol.
9967         * coffread.c (record_minimal_symbol): Use record_full.
9968
9969 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
9970
9971         The MS-Windows port of ncurses fails to switch to a color pair if
9972         one or both of the colors are the implicit default colors.  This
9973         change records the default colors when TUI is initialized, and
9974         then specifies them explicitly when a color pair uses the default
9975         colors.  This allows color styling in TUI mode on MS-Windows.
9976
9977         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
9978         ncurses_norm_attr.
9979         (tui_initialize_io) [__MINGW32__]: Record the default terminal
9980         colors in ncurses_norm_attr.
9981         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
9982         "none", replace it with the default color recorded in
9983         ncurses_norm_attr.
9984
9985 2019-03-14  Tom Tromey  <tromey@adacore.com>
9986
9987         * source-cache.h (class source_cache) <get_source_lines>: Return
9988         std::string.
9989         * source-cache.c (source_cache::extract_lines): Handle case where
9990         first_pos==npos.  Return std::string.
9991         (source_cache::get_source_lines): Update.
9992
9993 2019-03-14  Tom Tromey  <tromey@adacore.com>
9994
9995         * NEWS: Add item for "style sources" commands.
9996         * source-cache.c (source_cache::get_source_lines): Check
9997         source_styling.
9998         * cli/cli-style.c (source_styling): New global.
9999         (_initialize_cli_style): Add "style sources" commands.
10000         (show_style_sources): New function.
10001         * cli/cli-style.h (source_styling): Declare.
10002
10003 2019-03-14  Pedro Alves  <palves@redhat.com>
10004             Tom Tromey  <tromey@adacore.com>
10005
10006         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10007         * tui/tui-winsource.c (tui_refill_source_window): New function,
10008         from...
10009         (tui_horizontal_source_scroll): ... here.  Move some logic.
10010         * cli/cli-style.c (set_style_enabled): Notify new observable.
10011         * tui/tui-hooks.c (tui_redisplay_source): New function.
10012         (tui_attach_detach_observers): Attach or detach
10013         tui_redisplay_source.
10014         * observable.h (source_styling_changed): New observable.
10015         * observable.c: Define source_styling_changed observable.
10016
10017 2019-03-13  Tom Tromey  <tromey@adacore.com>
10018
10019         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10020         (i386_gnu_nat_target::store_registers): Update.
10021         * target-debug.h (target_debug_print_std_string): New macro.
10022         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10023         * windows-tdep.c (display_one_tib): Update.
10024         * tui/tui-stack.c (tui_make_status_line): Update.
10025         * top.c (print_inferior_quit_action): Update.
10026         * thread.c (thr_try_catch_cmd): Update.
10027         (add_thread_with_info): Update.
10028         (thread_target_id_str): Update.
10029         (thr_try_catch_cmd): Update.
10030         (thread_command): Update.
10031         (thread_find_command): Update.
10032         * record-btrace.c (record_btrace_target::info_record)
10033         (record_btrace_resume_thread, record_btrace_target::resume)
10034         (record_btrace_cancel_resume, record_btrace_step_thread)
10035         (record_btrace_target::wait, record_btrace_target::wait)
10036         (record_btrace_target::wait, record_btrace_target::stop): Update.
10037         * progspace.c (print_program_space): Update.
10038         * process-stratum-target.c
10039         (process_stratum_target::thread_address_space): Update.
10040         * linux-fork.c (linux_fork_mourn_inferior)
10041         (detach_checkpoint_command, info_checkpoints_command)
10042         (linux_fork_context): Update.
10043         (linux_fork_detach): Update.
10044         (class scoped_switch_fork_info): Update.
10045         (delete_checkpoint_command): Update.
10046         * infrun.c (follow_fork_inferior): Update.
10047         (follow_fork_inferior): Update.
10048         (proceed_after_vfork_done): Update.
10049         (handle_vfork_child_exec_or_exit): Update.
10050         (follow_exec): Update.
10051         (displaced_step_prepare_throw): Update.
10052         (displaced_step_restore): Update.
10053         (start_step_over): Update.
10054         (resume_1): Update.
10055         (clear_proceed_status_thread): Update.
10056         (proceed): Update.
10057         (print_target_wait_results): Update.
10058         (do_target_wait): Update.
10059         (context_switch): Update.
10060         (stop_all_threads): Update.
10061         (restart_threads): Update.
10062         (finish_step_over): Update.
10063         (handle_signal_stop): Update.
10064         (switch_back_to_stepped_thread): Update.
10065         (keep_going_pass_signal): Update.
10066         (print_exited_reason): Update.
10067         (normal_stop): Update.
10068         * inferior.c (inferior_pid_to_str): Change return type.
10069         (print_selected_inferior): Update.
10070         (add_inferior): Update.
10071         (detach_inferior): Update.
10072         * dummy-frame.c (fprint_dummy_frames): Update.
10073         * dcache.c (dcache_info_1): Update.
10074         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10075         (btrace_fetch, btrace_clear): Update.
10076         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10077         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10078         type.
10079         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10080         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10081         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10082         * gdbarch.c, gdbarch.h: Rebuild.
10083         * gdbarch.sh (core_pid_to_str): Change return type.
10084         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10085         return type.
10086         (windows_nat_target::pid_to_str): Change return type.
10087         (windows_delete_thread): Update.
10088         (windows_nat_target::attach): Update.
10089         (windows_nat_target::files_info): Update.
10090         * target-delegates.c: Rebuild.
10091         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10092         return type.
10093         (sol_thread_target::pid_to_str): Change return type.
10094         * remote.c (class remote_target) <pid_to_str>: Change return
10095         type.
10096         (remote_target::pid_to_str): Change return type.
10097         (extended_remote_target::attach, remote_target::remote_stop_ns)
10098         (remote_target::remote_notif_remove_queued_reply)
10099         (remote_target::push_stop_reply, remote_target::disable_btrace):
10100         Update.
10101         (extended_remote_target::attach): Update.
10102         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10103         type.
10104         (gdbsim_target::pid_to_str): Change return type.
10105         * ravenscar-thread.c (struct ravenscar_thread_target)
10106         <pid_to_str>: Change return type.
10107         (ravenscar_thread_target::pid_to_str): Change return type.
10108         * procfs.c (class procfs_target) <pid_to_str>: Change return
10109         type.
10110         (procfs_target::pid_to_str): Change return type.
10111         (procfs_target::attach): Update.
10112         (procfs_target::detach): Update.
10113         (procfs_target::fetch_registers): Update.
10114         (procfs_target::store_registers): Update.
10115         (procfs_target::wait): Update.
10116         (procfs_target::files_info): Update.
10117         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10118         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10119         return type.
10120         (nto_procfs_target::pid_to_str): Change return type.
10121         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10122         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10123         return type.
10124         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10125         (exit_lwp): Update.
10126         (attach_proc_task_lwp_callback, get_detach_signal)
10127         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10128         (linux_nat_target::resume, wait_lwp, stop_callback)
10129         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10130         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10131         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10132         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10133         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10134         type.
10135         (inf_ptrace_target::attach): Update.
10136         (inf_ptrace_target::files_info): Update.
10137         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10138         type.
10139         (go32_nat_target::pid_to_str): Change return type.
10140         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10141         (gnu_nat_target::wait): Update.
10142         (gnu_nat_target::wait): Update.
10143         (gnu_nat_target::resume): Update.
10144         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10145         (fbsd_nat_target::wait): Update.
10146         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10147         type.
10148         (darwin_nat_target::attach): Update.
10149         * corelow.c (class core_target) <pid_to_str>: Change return type.
10150         (core_target::pid_to_str): Change return type.
10151         * target.c (normal_pid_to_str): Change return type.
10152         (default_pid_to_str): Likewise.
10153         (target_pid_to_str): Change return type.
10154         (target_translate_tls_address): Update.
10155         (target_announce_detach): Update.
10156         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10157         return type.
10158         (bsd_uthread_target::pid_to_str): Change return type.
10159         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10160         type.
10161         (bsd_kvm_target::pid_to_str): Change return type.
10162         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10163         return type.
10164         (aix_thread_target::pid_to_str): Change return type.
10165         * target.h (struct target_ops) <pid_to_str>: Change return type.
10166         (target_pid_to_str, normal_pid_to_str): Likewise.
10167         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10168         type.
10169         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10170         type.
10171         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10172         return type.
10173         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10174         type.
10175         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10176         type.
10177         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10178         return type.
10179
10180 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10181
10182         * NEWS: Mention that the new default MI version is 3.  Mention
10183         changes to the output of commands and events that deal with
10184         multi-location breakpoints.
10185         * breakpoint.c: Include "mi/mi-out.h".
10186         (print_one_breakpoint): Change output syntax if using MI version
10187         >= 3.
10188         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10189         New.
10190         (mi_multi_location_breakpoint_output_fixed): New.
10191         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10192         (mi_cmd_fix_multi_location_breakpoint_output): New.
10193         (mi_multi_location_breakpoint_output_fixed): New.
10194         * mi/mi-cmds.c (mi_cmds): Register command
10195         -fix-multi-location-breakpoint-output.
10196         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10197         interpreter "mi".
10198
10199 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10200
10201         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10202         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10203         instantiate mi_ui_out based on interpreter name.
10204         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10205         * mi/mi-main.c (mi_load_progress): Likewise.
10206
10207 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10208
10209         * NEWS: Combine separate "New targets" sections for 8.3.
10210
10211 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10212
10213         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10214         (ppcfbsd_init_abi): Install gdbarch
10215         "fetch_tls_load_module_address" and "get_thread_local_address"
10216         methods.
10217
10218 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10219
10220         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10221         (riscv_fbsd_init_abi): Install gdbarch
10222         "fetch_tls_load_module_address" and "get_thread_local_address"
10223         methods.
10224
10225 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10226
10227         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10228         (i386fbsd_init_abi): Install gdbarch
10229         "fetch_tls_load_module_address" and "get_thread_local_address"
10230         methods.
10231
10232 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10233
10234         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10235         (amd64fbsd_init_abi): Install gdbarch
10236         "fetch_tls_load_module_address" and "get_thread_local_address"
10237         methods.
10238
10239 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10240
10241         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10242         (struct fbsd_pspace_data): New type.
10243         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10244         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10245         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10246         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10247         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10248
10249 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10250
10251         * gdbtypes.c (lookup_struct_elt): New function.
10252         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10253         * gdbtypes.h (struct struct_elt): New type.
10254         (lookup_struct_elt): New prototype.
10255
10256 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10257
10258         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10259         remove disabled code block.
10260
10261 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10262
10263         * gdbarch.sh (get_thread_local_address): New method.
10264         * gdbarch.h, gdbarch.c: Regenerate.
10265         * target.c (target_translate_tls_address): Use
10266         gdbarch_get_thread_local_address if present instead of
10267         target::get_thread_local_address.
10268
10269 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10270
10271         * target.h (target::get_thread_local_address): Update comment.
10272
10273 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10274
10275         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10276         objfile->separate_debug_objfile_backlink if not NULL.
10277
10278 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10279
10280         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10281         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10282         (amd64bsd_store_inferior_registers): Likewise.
10283         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10284         Enable segment base registers.
10285         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10286         PT_GETFSBASE and PT_GETGSBASE.
10287         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10288         PT_SETGSBASE.
10289         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10290         segment base registers.
10291         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10292
10293 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10294
10295         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10296         Update calls to i386_target_description to add 'segments'
10297         parameter.
10298         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10299         add segment base registers.
10300         * arch/i386.c (i386_create_target_description): Add 'segments'
10301         parameter to enable segment base registers.
10302         * arch/i386.h (i386_create_target_description): Likewise.
10303         * features/i386/32bit-segments.xml: New file.
10304         * features/i386/32bit-segments.c: Generate.
10305         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10306         call to i386_target_description to add 'segments' parameter.
10307         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10308         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10309         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10310         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10311         if feature is present.
10312         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10313         Add 'segments' parameter to call to i386_target_description.
10314         (i386_target_description): Add 'segments' parameter to enable
10315         segment base registers.
10316         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10317         to call to i386_target_description.
10318         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10319         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10320         Define I386_NUM_REGS.
10321         (i386_target_description): Add 'segments' parameter to enable
10322         segment base registers.
10323
10324 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10325
10326         PR/24325
10327         * source-cache.c: #undef open and close, to avoid unresolved
10328         externals during linking.
10329
10330 2019-03-12  Tom Tromey  <tromey@adacore.com>
10331
10332         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10333         const.  Add initializers.
10334         (_initialize_remote): Don't initialize ptid globals.
10335
10336 2019-03-12  Pedro Alves  <palves@redhat.com>
10337
10338         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10339
10340 2019-03-12  Pedro Alves  <palves@redhat.com>
10341
10342         * cp-name-parser.y (main): Remove unused 'len' variable.
10343
10344 2019-03-12  Tom Tromey  <tromey@adacore.com>
10345
10346         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10347         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10348
10349 2019-03-12  Tom Tromey  <tromey@adacore.com>
10350
10351         * linux-nat.c (iterate_over_lwps): Update.
10352         (stop_callback): Remove parameter.
10353         (stop_wait_callback, detach_callback, resume_set_callback)
10354         (select_singlestep_lwp_callback, set_ignore_sigint)
10355         (status_callback, resumed_callback, resume_clear_callback)
10356         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10357         data parameter.
10358         (linux_nat_target::detach, linux_nat_target::resume)
10359         (linux_stop_and_wait_all_lwps, select_event_lwp)
10360         (linux_nat_filter_event, linux_nat_wait_1)
10361         (linux_nat_target::kill, linux_nat_target::stop)
10362         (linux_nat_target::stop): Update.
10363         (linux_nat_resume_callback): Change type.
10364         (resume_stopped_resumed_lwps, count_events_callback)
10365         (select_event_lwp_callback): Likewise.
10366         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10367         * arm-linux-nat.c (struct update_registers_data): Remove.
10368         (update_registers_callback): Change type.
10369         (arm_linux_insert_hw_breakpoint1): Update.
10370         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10371         parameter.
10372         (x86_linux_dr_set_addr): Update.
10373         (x86_linux_dr_set_control): Update.
10374         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10375         (iterate_over_lwps): Use gdb::function_view.
10376         * nat/aarch64-linux-hw-point.c (struct
10377         aarch64_dr_update_callback_param): Remove.
10378         (debug_reg_change_callback): Change type.
10379         (aarch64_notify_debug_reg_change): Update.
10380         * s390-linux-nat.c (s390_refresh_per_info): Update.
10381
10382 2019-03-11  Tom Tromey  <tromey@adacore.com>
10383
10384         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10385         redundant assignment to "this_cu".
10386
10387 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10388
10389         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10390
10391 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10392
10393         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10394         from...
10395         (rank_one_type): ... this.
10396
10397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10398
10399         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10400         from...
10401         (rank_one_type): ... this.
10402
10403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10404
10405         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10406         from...
10407         (rank_one_type): ... this.
10408
10409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10410
10411         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10412         from...
10413         (rank_one_type): ... this.
10414
10415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10416
10417         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10418         from...
10419         (rank_one_type): ... this.
10420
10421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10422
10423         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10424         from...
10425         (rank_one_type): ... this.
10426
10427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10428
10429         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10430         from...
10431         (rank_one_type): ... this.
10432
10433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10434
10435         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10436         from...
10437         (rank_one_type): ... this.
10438
10439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10440
10441         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10442         from...
10443         (rank_one_type): ... this.
10444
10445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10446
10447         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10448         from...
10449         (rank_one_type): ... this.
10450
10451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10452
10453         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10454         from...
10455         (rank_one_type): ... this.
10456
10457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10458
10459         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10460         from...
10461         (rank_one_type): ... this.
10462
10463 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10464
10465         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10466         inferior-events' shows the example events.
10467
10468 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10469
10470         Support styling on native MS-Windows console
10471
10472         PR/24315
10473         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10474         on MS-Windows if $TERM is not defined.
10475
10476         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10477
10478         * posix-hdep.c (gdb_console_fputs):
10479         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10480         functions.
10481         * ui-file.h (gdb_console_fputs): Add prototype.
10482
10483         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10484         back to fputs only if the former returns zero.
10485
10486 2019-03-07  Tom Tromey  <tom@tromey.com>
10487
10488         * symmisc.c (print_symbol_bcache_statistics): Update.
10489         (print_objfile_statistics): Update.
10490         * symfile.c (allocate_symtab): Update.
10491         * stabsread.c: Don't include bcache.h.
10492         * psymtab.h (struct psymbol_bcache): Don't declare.
10493         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10494         (psymbol_bcache_init, psymbol_bcache_free)
10495         (psymbol_bcache_get_bcache): Don't declare.
10496         * psymtab.c (struct psymbol_bcache): Remove.
10497         (psymtab_storage::psymtab_storage): Update.
10498         (psymtab_storage::~psymtab_storage): Update.
10499         (psymbol_bcache_init, psymbol_bcache_free)
10500         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10501         (add_psymbol_to_bcache): Update.
10502         (allocate_psymtab): Update.
10503         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10504         macro_cache>: No longer pointers.
10505         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10506         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10507         * macrotab.c (macro_bcache): Update.
10508         * macroexp.c: Don't include bcache.h.
10509         * gdbtypes.c (check_types_worklist): Update.
10510         (types_deeply_equal): Remove TRY/CATCH.  Update.
10511         * elfread.c (elf_symtab_read): Update.
10512         * dwarf2read.c: Don't include bcache.h.
10513         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10514         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10515         (print_bcache_statistics, bcache_memory_used): Don't declare.
10516         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10517         methods.  Rename all data members.
10518         * bcache.c (struct bcache): Move to bcache.h.
10519         (bcache::expand_hash_table): Rename from expand_hash_table.
10520         (bcache): Remove.
10521         (bcache::insert): Rename from bcache_full.
10522         (bcache::compare): Rename from bcache_compare.
10523         (bcache_xmalloc): Remove.
10524         (bcache::~bcache): Rename from bcache_xfree.
10525         (bcache::print_statistics): Rename from print_bcache_statistics.
10526         (bcache::memory_used): Rename from bcache_memory_used.
10527
10528 2019-03-07  Pedro Alves  <palves@redhat.com>
10529
10530         * infrun.c (normal_stop): Also check for
10531         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10532
10533 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10534
10535         * f-lang.c (value_from_host_double): Moved to...
10536         * value.c (value_from_host_double): ...here.
10537         * value.h (value_from_host_double): Declare.
10538         * guile/scm-math.c (vlscm_convert_typed_number): Use
10539         value_from_host_double.
10540         (vlscm_convert_number): Likewise.
10541         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10542         * python/py-value.c (convert_value_from_python): Likewise.
10543
10544 2019-03-06  Tom Tromey  <tom@tromey.com>
10545
10546         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10547
10548 2019-03-06  Tom Tromey  <tom@tromey.com>
10549
10550         * utils.h (free_current_contents): Don't declare.
10551         * utils.c (free_current_contents): Remove.
10552
10553 2019-03-06  Tom Tromey  <tom@tromey.com>
10554
10555         * top.c (quit_force): Update.
10556         * main.c (captured_command_loop): Update.
10557         * common/new-op.c (operator new): Update.
10558         * common/common-exceptions.c (struct catcher)
10559         <save_cleanup_chain>: Remove member.
10560         (exceptions_state_mc_init): Update.
10561         (exception_try_scope_entry): Return nullptr.
10562         (exception_try_scope_exit, exception_rethrow)
10563         (throw_exception_sjlj, throw_exception_cxx): Update.
10564         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10565         (all_cleanups, do_cleanups, discard_cleanups)
10566         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10567         (restore_cleanups, restore_final_cleanups): Don't declare.
10568         (do_final_cleanups): Remove parameter.
10569         * common/cleanups.c (cleanup_chain, make_cleanup)
10570         (make_cleanup_dtor, all_cleanups, do_cleanups)
10571         (discard_my_cleanups, discard_cleanups)
10572         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10573         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10574         (null_cleanup): Remove.
10575         (do_final_cleanups): Remove parameter.
10576
10577 2019-03-06  Tom Tromey  <tom@tromey.com>
10578
10579         * remote.c (remote_target::remote_parse_stop_reply): Use
10580         unique_xmalloc_ptr.
10581
10582 2019-03-06  Tom Tromey  <tom@tromey.com>
10583
10584         * stabsread.c (struct stabs_field_info): Rename from field_info.
10585         <list, fnlist>: Add initializers.
10586         <obstack>: New member.
10587         (read_member_functions, read_struct_fields, read_baseclasses):
10588         Allocate on obstack.  Don't use cleanups.
10589         (read_one_struct_field, read_member_functions, read_struct_fields)
10590         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10591         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10592         (read_struct_type): Update.
10593
10594 2019-03-06  Tom Tromey  <tom@tromey.com>
10595
10596         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10597         * common/filestuff.h (make_cleanup_close): Don't declare.
10598         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10599         Remove.
10600
10601 2019-03-06  Tom Tromey  <tom@tromey.com>
10602
10603         * solib-aix.c: Use make_scope_exit.
10604
10605 2019-03-06  Tom Tromey  <tom@tromey.com>
10606
10607         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10608         Use make_scope_exit.
10609
10610 2019-03-06  Tom Tromey  <tom@tromey.com>
10611
10612         * solib-svr4.c (disable_probes_interface): Remove parameter.
10613         (svr4_handle_solib_event): Use make_scope_exit.
10614
10615 2019-03-06  Tom Tromey  <tom@tromey.com>
10616
10617         * remote.c (struct stop_reply_deleter): Remove.
10618         (stop_reply_up): Update.
10619         (struct stop_reply): Derive from notif_event.  Don't typedef.
10620         <regcache>: Now a std::vector.
10621         (stop_reply_xfree): Remove.
10622         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10623         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10624         (remote_target::discard_pending_stop_replies): Use delete.
10625         (remote_target::remote_parse_stop_reply): Update.
10626         (remote_target::process_stop_reply): Update.
10627         * remote-notif.h (struct notif_event): Add virtual destructor.
10628         Remove "dtr" member.
10629         (struct notif_client) <alloc_event>: Return a unique_ptr.
10630         (notif_event_xfree): Don't declare.
10631         (notif_event_up): New typedef.
10632         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10633         (notif_event_xfree, do_notif_event_xfree): Remove.
10634         (remote_notif_state_xfree): Update.
10635
10636 2019-03-06  Tom Tromey  <tom@tromey.com>
10637
10638         * infrun.c (displaced_step_clear_cleanup): Now a
10639         forward_scope_exit type.
10640         (displaced_step_prepare_throw): Update.
10641         (displaced_step_fixup): Update.
10642
10643 2019-03-06  Tom Tromey  <tom@tromey.com>
10644
10645         * inferior.h (class inferior): Update comment.
10646         * gdbthread.h (class thread_info): Update comment.
10647
10648 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
10649             Tom Tromey  <tom@tromey.com>
10650
10651         * stabsread.h (struct stab_section_list): Remove.
10652         (coffstab_build_psymtabs): Update.
10653         * dbxread.c (symbuf_sections): Now a std::vector.
10654         (sect_idx): New global.
10655         (fill_symbuf): Update.
10656         (coffstab_build_psymtabs): Change type of stabsects parameter.
10657         Update.
10658         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
10659         std::vector.
10660         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
10661         (coff_locate_sections): Update.
10662         (coff_symfile_read): Remove cleanups.  Update.
10663         (init_stringtab): Add storage parameter.
10664         (free_stringtab, free_stringtab_cleanup): Remove.
10665         (init_lineno): Add storage parameter.
10666         (free_linetab, free_linetab_cleanup): Remove.
10667
10668 2019-03-06  Pedro Alves  <palves@redhat.com>
10669
10670         * linux-fork.c (fork_info::clobber_regs): Delete.
10671         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
10672         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
10673         comment.  Adjust.
10674         (scoped_switch_fork_info::scoped_switch_fork_info)
10675         (checkpoint_command, linux_fork_context): Adjust
10676         fork_save_infrun_state calls.
10677
10678 2019-03-06  Pedro Alves  <palves@redhat.com>
10679
10680         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
10681         (inf_has_multiple_threads): Return 'bool' and rewrite using
10682         inferior_info::threads().
10683
10684 2019-03-06  Pedro Alves  <palves@redhat.com>
10685
10686         * linux-fork.c: Include <list>.
10687         (fork_list): Now a std::list instance.
10688         (fork_info): Add ctor, dtor, and in-class initialize all fields.
10689         (forks_exist_p, find_last_fork): Adjust.
10690         (new_fork): Delete.
10691         (one_fork_p): New.
10692         (add_fork): Adjust.
10693         (free_fork): Delete, folded into fork_info::~fork_info().
10694         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
10695         Adjust.
10696         (init_fork_list): Delete.
10697         (linux_fork_killall, linux_fork_mourn_inferior)
10698         (linux_fork_detach, info_checkpoints_command): Adjust.
10699         (_initialize_linux_fork): No longer call init_fork_list.
10700
10701 2019-03-06  Pedro Alves  <palves@redhat.com>
10702
10703         * linux-fork.c (new_fork): New, split out of ...
10704         (add_fork): ... this.  Return void.  Move "first fork" special
10705         case from here, to ...
10706         (checkpoint_command): ... here.
10707         * linux-linux.h (add_fork): Return void.
10708
10709 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10710
10711         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
10712
10713 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10714             Chris January  <chris.january@arm.com>
10715             David Lecomber  <david.lecomber@arm.com>
10716
10717         * f-exp.y: New token, UNOP_INTRINSIC.
10718         (exp): New pattern using UNOP_INTRINSIC token.
10719         (f77_keywords): Add 'abs' keyword.
10720         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
10721         (value_from_host_double): New function.
10722         (evaluate_subexp_f): Support UNOP_ABS.
10723
10724 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10725
10726         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
10727         types.
10728
10729 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10730
10731         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
10732         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
10733         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
10734
10735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10736
10737         * f-exp.y (convert_to_kind_type): Handle more type kinds.
10738
10739 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10740             Chris January  <chris.january@arm.com>
10741
10742         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
10743         * f-exp.y: Define 'KIND' token.
10744         (exp): New pattern for KIND expressions.
10745         (ptype): Handle types with a kind extension.
10746         (direct_abs_decl): Extend to spot kind extensions.
10747         (f77_keywords): Add 'kind' to the list.
10748         (push_kind_type): New function.
10749         (convert_to_kind_type): New function.
10750         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
10751         * parse.c (operator_length_standard): Likewise.
10752         * parser-defs.h (enum type_pieces): Add tp_kind.
10753         * std-operator.def: Add UNOP_KIND.
10754
10755 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10756
10757         * f-exp.y (f_parse): Set yydebug.
10758
10759 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10760
10761         * f-lang.c (evaluate_subexp_f): New function.
10762         (exp_descriptor_f): New global.
10763         (f_language_defn): Use exp_descriptor_f instead of
10764         exp_descriptor_standard.
10765
10766 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10767
10768         * f-exp.y (struct token): Add comments.
10769         (dot_ops): Remove uppercase versions and the end marker.
10770         (f77_keywords): Likewise.
10771         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
10772         entries in the dot_ops array are case insensitive, and use
10773         strncasecmp to compare strings.  Also some whitespace cleanup in
10774         this area.  Similar for the f77_keywords array, except entries in
10775         this list might be case sensitive.
10776
10777 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
10778
10779         * f-exp.y (struct f77_boolean_val): Add comments.
10780         (boolean_values): Remove uppercase versions, and end marker.
10781         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
10782         and use strncasecmp to achieve case insensitivity.  Additionally,
10783         perform whitespace cleanup around this code.
10784
10785 2019-03-06  Tom Tromey  <tromey@adacore.com>
10786
10787         * remote-sim.c (gdbsim_target_open): Use result of
10788         gdb_argv::release.
10789
10790 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
10791         Dirk Schubert  <dirk.schubert@arm.com>
10792         Chris January  <chris.january@arm.com>
10793
10794         * eval.c (evaluate_subexp_standard): Call Fortran argument
10795         wrapping logic.
10796         * f-lang.c (struct value): A value which can be passed into a
10797         Fortran function call.
10798         (fortran_argument_convert): Wrap Fortran arguments in a pointer
10799         where appropriate.
10800         (struct type): Value ready for a Fortran function call.
10801         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
10802         is needed.
10803         * f-lang.h (fortran_argument_convert): Declaration.
10804         (fortran_preserve_arg_pointer): Declaration.
10805         * infcall.c (value_arg_coerce): Call Fortran argument logic.
10806
10807 2019-03-05  Tom Tromey  <tromey@adacore.com>
10808
10809         * python/py-prettyprint.c (print_string_repr): Remove #if.
10810         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
10811
10812 2019-03-05  Tom Tromey  <tromey@adacore.com>
10813
10814         * target.c (the_dummy_target): Move later.  Change type to
10815         "dummy_target".
10816         (initialize_targets): Don't initialize the_dummy_target.
10817
10818 2019-03-05  Tom Tromey  <tromey@adacore.com>
10819
10820         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
10821         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
10822
10823 2019-03-05  Tom Tromey  <tromey@adacore.com>
10824
10825         * windows-nat.c (windows_nat_target::attach)
10826         (windows_nat_target::detach): Don't call gdb_flush.
10827         * valprint.c (generic_val_print, val_print, val_print_string):
10828         Don't call gdb_flush.
10829         * utils.c (defaulted_query): Don't call gdb_flush.
10830         * typeprint.c (print_type_scalar): Don't call gdb_flush.
10831         * target.c (target_announce_detach): Don't call gdb_flush.
10832         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
10833         * remote.c (extended_remote_target::attach): Don't call
10834         gdb_flush.
10835         * procfs.c (procfs_target::detach): Don't call gdb_flush.
10836         * printcmd.c (do_examine): Don't call gdb_flush.
10837         (info_display_command): Don't call gdb_flush.
10838         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
10839         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
10840         * memattr.c (info_mem_command): Don't call gdb_flush.
10841         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
10842         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
10843         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
10844         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
10845         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
10846         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
10847         (gnu_nat_target::detach): Don't call gdb_flush.
10848         * f-valprint.c (f_val_print): Don't call gdb_flush.
10849         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
10850         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
10851         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
10852         gdb_flush.
10853         * c-valprint.c (c_val_print): Don't call gdb_flush.
10854         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
10855
10856 2019-03-05  Tom Tromey  <tromey@adacore.com>
10857
10858         * varobj.c (update_dynamic_varobj_children): Update.
10859         (install_default_visualizer): Use reset, not release.
10860         * value.c (set_internalvar): Update.
10861         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
10862         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
10863         ATTRIBUTE_UNUSED_RESULT.
10864
10865 2019-03-05  Tom Tromey  <tromey@adacore.com>
10866
10867         * remote.c (class scoped_remote_fd) <release>: Add
10868         ATTRIBUTE_UNUSED_RESULT.
10869
10870 2019-03-05  Tom Tromey  <tromey@adacore.com>
10871
10872         * macroexp.c (struct macro_buffer) <release>: Add
10873         ATTRIBUTE_UNUSED_RESULT.
10874
10875 2019-03-05  Tom Tromey  <tromey@adacore.com>
10876
10877         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
10878         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
10879         ATTRIBUTE_UNUSED_RESULT.
10880
10881 2019-03-05  Tom Tromey  <tromey@adacore.com>
10882
10883         * common/scoped_fd.h (class scoped_fd) <release>: Add
10884         ATTRIBUTE_UNUSED_RESULT.
10885
10886 2019-03-05  Tom Tromey  <tromey@adacore.com>
10887
10888         * parser-defs.h (struct parser_state) <release>: Add
10889         ATTRIBUTE_UNUSED_RESULT.
10890
10891 2019-03-05  Tom Tromey  <tromey@adacore.com>
10892
10893         * utils.h (class gdb_argv) <release>: Add
10894         ATTRIBUTE_UNUSED_RESULT.
10895         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
10896
10897 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
10898
10899         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
10900         for-loop range, to avoid compiler warnings.
10901
10902         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
10903         avoid compiler warnings about unused variables.
10904
10905         * NEWS: Mention end of support for native debugging on MS-Windows
10906         before XP.
10907
10908         PR gdb/24292
10909         * common/netstuff.c:
10910         * gdbserver/gdbreplay.c
10911         * gdbserver/remote-utils.c:
10912         * ser-tcp.c:
10913         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
10914         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
10915         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
10916         'getaddrinfo' and 'freeaddrinfo' were not available before
10917         Windows XP, and mingw.org's MinGW headers by default define
10918         _WIN32_WINNT to 0x500.
10919
10920 2019-03-01  Gary Benson <gbenson@redhat.com>
10921
10922         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
10923
10924 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
10925             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
10926
10927         PR gdb/8527
10928         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
10929         set_sigint_trap, clear_sigint_trap.
10930
10931 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10932
10933         * target.c (target_detach): Clear the regcache and the
10934         frame cache.
10935
10936 2019-02-27  Pedro Alves  <palves@redhat.com>
10937
10938         * utils.c (set_screen_size): When we cap the height/width sizes,
10939         tweak the corresponding command variable to show "unlimited":
10940
10941 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
10942             Pedro Alves  <palves@redhat.com>
10943
10944         * utils.c (set_screen_size): Reduce "infinite" rows and columns
10945         before calling rl_set_screen_size.
10946
10947 2019-02-27  Tom Tromey  <tromey@adacore.com>
10948
10949         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
10950         define.
10951         * python/py-value.c: Remove Python 2.4 workaround.
10952         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
10953         workaround.
10954         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
10955         Python 2.4 workaround.
10956         * python/python-internal.h: Remove Python 2.4 comment.
10957         (Py_ssize_t): Don't define.
10958         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
10959         (gdb_Py_DECREF): Remove Python 2.4 workaround.
10960         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
10961         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
10962         * python/python.c (do_start_initialization): Remove Python 2.4
10963         workaround.
10964         * python/py-prettyprint.c (class dummy_python_frame): Remove.
10965         (print_children): Remove Python 2.4 workaround.
10966         * python/py-inferior.c (buffer_procs): Remove Python 2.4
10967         workaround.
10968         (CHARBUFFERPROC_NAME): Remove.
10969         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
10970         Python 2.4 workaround.
10971
10972 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10973
10974         * NEWS: Note minimum Python version.
10975
10976 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
10977
10978         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
10979         code from these functions.  Remove corresponding ifdefs.  Use
10980         Py_buffer_up instead of explicit calls to PyBuffer_Release.
10981         Remove gotos and target of gotos.
10982         (infpy_search_memory): Likewise.
10983
10984 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10985
10986         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
10987         (hppa_gdbarch_init): Don't register deleted functions with
10988         gdbarch.
10989
10990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10991
10992         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
10993         (h8300_unwind_sp): Delete.
10994         (h8300_dummy_id): Delete.
10995         (h8300_gdbarch_init): Don't register deleted functions with
10996         gdbarch.
10997
10998 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
10999
11000         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11001         (ft32_unwind_pc): Delete.
11002         (ft32_unwind_sp): Delete.
11003         (ft32_gdbarch_init): Don't register deleted functions with
11004         gdbarch.
11005
11006 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11007
11008         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11009         (frv_unwind_pc): Delete.
11010         (frv_unwind_sp): Delete.
11011         (frv_gdbarch_init): Don't register deleted functions with
11012         gdbarch.
11013
11014 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11015
11016         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11017         (riscv_unwind_pc): Delete.
11018         (riscv_unwind_sp): Delete.
11019         (riscv_gdbarch_init): Don't register deleted functions with
11020         gdbarch.
11021
11022 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11023
11024         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11025         (csky_unwind_pc): Delete.
11026         (csky_unwind_sp): Delete.
11027         (csky_gdbarch_init): Don't register deleted functions with
11028         gdbarch.
11029
11030 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11031
11032         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11033         (cris_unwind_pc): Delete.
11034         (cris_unwind_sp): Delete.
11035         (cris_gdbarch_init): Don't register deleted functions with
11036         gdbarch.
11037
11038 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11039
11040         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11041         (bfin_unwind_pc): Delete.
11042         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11043
11044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11045
11046         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11047         (arm_unwind_pc): Delete.
11048         (arm_unwind_sp): Delete.
11049         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11050
11051 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11052
11053         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11054         (arc_unwind_pc): Delete.
11055         (arc_unwind_sp): Delete.
11056         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11057
11058 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11059
11060         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11061         (alpha_unwind_pc): Delete.
11062         (alpha_gdbarch_init): Don't register deleted functions with
11063         gdbarch.
11064
11065 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11066
11067         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11068         (aarch64_unwind_pc): Delete.
11069         (aarch64_unwind_sp): Delete.
11070         (aarch64_gdbarch_init): Don't register deleted functions with
11071         gdbarch.
11072
11073 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11074
11075         * gdbtypes.c (type_align): Don't consider static members when
11076         computing structure alignment.
11077
11078 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11079
11080         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11081         return 0 for other types.
11082         * arch-utils.c (default_type_align): Always return 0.
11083         * gdbarch.h: Regenerate.
11084         * gdbarch.sh (type_align): Extend comment.
11085         * gdbtypes.c (type_align): Add additional comments, always call
11086         gdbarch_type_align before applying the default rules.
11087         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11088         generic code will then apply a suitable default.
11089         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11090         types, return 0 for other types.
11091
11092 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11093
11094         * NEWS: Create a new section for the next release branch.
11095         Rename the section of the current branch, now that it has
11096         been cut.
11097
11098 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11099
11100         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11101         * version.in: Bump version to 8.3.50.DATE-git.
11102
11103 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11104
11105         * aix-thread.c (ptid_cmp): Remove unused variable.
11106         (get_signaled_thread): Likewise.
11107         (store_regs_user_thread): Likewise.
11108         (store_regs_kernel_thread): Likewise.
11109         (fetch_regs_kernel_thread): Remove shadowed variable.
11110
11111 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11112
11113         * features/riscv/32bit-cpu.xml: Add register numbers.
11114         * features/riscv/32bit-fpu.c: Regenerate.
11115         * features/riscv/32bit-fpu.xml: Add register numbers.
11116         * features/riscv/64bit-cpu.xml: Add register numbers.
11117         * features/riscv/64bit-fpu.c: Regenerate.
11118         * features/riscv/64bit-fpu.xml: Add register numbers.
11119
11120 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11121
11122         * NEWS: Mention two argument form of gdb.Value constructor.
11123         * python/py-value.c (convert_buffer_and_type_to_value): New
11124         function.
11125         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11126         Add support for handling an optional second argument.  Call
11127         convert_buffer_and_type_to_value as appropriate.
11128         * python/python-internal.h (Py_buffer_deleter): New struct.
11129         (Py_buffer_up): New typedef.
11130
11131 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11132
11133         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11134         instead of releasing ownership.
11135
11136 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11137
11138         * dwarf2read.c (open_and_init_dwp_file): Call
11139         elf_numsections instead of bfd_count_sections to initialize
11140         dwp_file->num_sections.
11141
11142 2019-02-25  Tom Tromey  <tromey@adacore.com>
11143
11144         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11145
11146 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11147
11148         * gcore.in: Add '--readnever' option when invoking GDB.
11149
11150 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11151
11152         * MAINTAINERS: Update my email address.
11153
11154 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11155
11156         * build-id.c (build_id_to_debug_bfd_1): New function.
11157         (build_id_to_debug_bfd): Look for separate debug file in
11158         sysroot.
11159
11160 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11161
11162         * gdbarch.sh: Update the copyright year range that is placed into
11163         generated files.
11164
11165 2019-02-22  Keith Seitz  <keiths@redhat.com>
11166
11167         PR symtab/23853
11168         * linespec.c (create_sals_line_offset): Search for the default
11169         symtab's filename instead of its fullname.
11170
11171 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11172
11173         * NEWS: Update style defaults.
11174
11175 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11176
11177         * main.c (captured_main_1): Disable styling in batch mode.
11178
11179 2019-02-20  Tom Tromey  <tom@tromey.com>
11180
11181         * symtab.c (symtab_symbol_info): Fix typos.
11182
11183 2019-02-20  Tom Tromey  <tromey@adacore.com>
11184
11185         * findcmd.c (_initialize_mem_search): Use upper case for
11186         metasyntactic variables.
11187
11188 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11189
11190         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11191         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11192
11193 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11194
11195         * top.h (source_file_name): Change to std::string.
11196         * top.c (source_file_name): Likewise.
11197         (command_line_input): Adjust.
11198         * cli/cli-script.c (script_from_file): Adjust.
11199
11200 2019-02-19  Tom Tromey  <tromey@adacore.com>
11201
11202         * ravenscar-thread.c
11203         (ravenscar_thread_target::update_thread_list): Don't call
11204         ada_build_task_list.
11205         * ada-lang.h (ada_build_task_list): Don't declare.
11206         * ada-tasks.c (struct ada_tasks_inferior_data)
11207         <task_list_valid_p>: Now bool.
11208         (read_known_tasks, ada_task_list_changed)
11209         (ada_tasks_invalidate_inferior_data): Update.
11210         (read_known_tasks_array): Return bool.
11211         (read_known_tasks_list): Likewise.
11212         (read_known_tasks): Return void.
11213         (ada_build_task_list): Now static.
11214
11215 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11216
11217         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11218         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11219
11220 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11221
11222         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11223         variant for ada_tasks_pspace_data_handle and
11224         ada_tasks_inferior_data_handle.
11225         (ada_tasks_pspace_data_cleanup): New function.
11226         (ada_tasks_inferior_data_cleanup): New function.
11227
11228 2019-02-17  Tom Tromey  <tom@tromey.com>
11229
11230         * macrotab.h (macro_source_fullname): Return a std::string.
11231         * macrotab.c (macro_include, check_for_redefinition)
11232         (macro_undef, macro_lookup_definition, foreach_macro)
11233         (foreach_macro_in_scope): Update.
11234         (macro_source_fullname): Return a std::string.
11235         * macrocmd.c (show_pp_source_pos): Update.
11236
11237 2019-02-17  Tom Tromey  <tom@tromey.com>
11238
11239         * macrocmd.c (show_pp_source_pos): Style the file names.
11240
11241 2019-02-17  Tom Tromey  <tom@tromey.com>
11242
11243         PR tui/24197:
11244         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11245
11246 2019-02-17  Tom Tromey  <tom@tromey.com>
11247
11248         * ada-lang.c (user_select_syms): Use filtered printing.
11249         * utils.c (wrap_style): New global.
11250         (desired_style): Remove.
11251         (emit_style_escape): Add stream parameter.
11252         (set_output_style, reset_terminal_style, prompt_for_continue):
11253         Update.
11254         (flush_wrap_buffer): Only flush gdb_stdout.
11255         (wrap_here): Set wrap_style.
11256         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11257         treat escape sequences as a character.  Change when wrap buffer is
11258         flushed.
11259         (fputs_styled): Do not set the output style when the default is
11260         requested.
11261         * ui-style.h (struct ui_file_style) <is_default>: New method.
11262         * source.c (print_source_lines_base): Emit escape sequences in one
11263         piece.
11264
11265 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11266
11267         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11268         integers and enumeration types.
11269
11270 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11271
11272         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11273         instead of lookup_symbol_in_language
11274         (do_exact_match): New function.
11275         (ada_get_symbol_name_matcher): Return do_exact_match when
11276         doing a verbatim match.
11277
11278 2019-02-15  Tom Tromey  <tromey@adacore.com>
11279
11280         * ravenscar-thread.c (ravenscar_thread_target::resume)
11281         (ravenscar_thread_target::wait): Special case wildcard requests.
11282
11283 2019-02-15  Tom Tromey  <tromey@adacore.com>
11284
11285         * ravenscar-thread.c (base_ptid): Remove.
11286         (struct ravenscar_thread_target) <close>: New method.
11287         <m_base_ptid>: New member.
11288         <update_inferior_ptid, active_task, task_is_currently_active,
11289         runtime_initialized>: Declare methods.
11290         <ravenscar_thread_target>: Add constructor.
11291         (ravenscar_thread_target::task_is_currently_active)
11292         (ravenscar_thread_target::update_inferior_ptid)
11293         (ravenscar_runtime_initialized): Rename.  Now methods.
11294         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11295         (ravenscar_thread_target::update_thread_list): Update.
11296         (ravenscar_thread_target::active_task): Now method.
11297         (ravenscar_thread_target::store_registers)
11298         (ravenscar_thread_target::prepare_to_store)
11299         (ravenscar_thread_target::prepare_to_store)
11300         (ravenscar_thread_target::mourn_inferior): Update.
11301         (ravenscar_inferior_created): Use "new" to create target.
11302         (ravenscar_thread_target::get_ada_task_ptid): Update.
11303         (_initialize_ravenscar): Don't initialize base_ptid.
11304         (ravenscar_ops): Remove global.
11305
11306 2019-02-15  Tom Tromey  <tromey@adacore.com>
11307
11308         * target.h (push_target): Declare new overload.
11309         * target.c (push_target): New overload, taking an rvalue reference.
11310         * remote.c (remote_target::open_1): Use push_target overload.
11311         * corelow.c (core_target_open): Use push_target overload.
11312
11313 2019-02-15  Tom Tromey  <tromey@adacore.com>
11314
11315         * ravenscar-thread.c (is_ravenscar_task)
11316         (ravenscar_task_is_currently_active): Return bool.
11317         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11318         (_initialize_ravenscar): Remove "(void)".
11319         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11320         Return bool.
11321
11322 2019-02-15  Tom Tromey  <tromey@adacore.com>
11323
11324         * ravenscar-thread.c (ravenscar_runtime_initializer)
11325         (has_ravenscar_runtime, get_running_thread_id)
11326         (ravenscar_thread_target::resume): Fix indentation.
11327
11328 2019-02-15  Tom Tromey  <tromey@adacore.com>
11329
11330         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11331         from ravenscar_arch_ops.
11332         (sparc_ravenscar_ops::fetch_registers)
11333         (sparc_ravenscar_ops::store_registers): Now methods.
11334         (sparc_ravenscar_prepare_to_store): Remove.
11335         (sparc_ravenscar_ops): Redefine.
11336         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11337         methods and destructor.  Remove members.
11338         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11339         (ravenscar_thread_target::store_registers)
11340         (ravenscar_thread_target::prepare_to_store): Update.
11341         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11342         Remove.
11343         (struct ppc_ravenscar_powerpc_ops): Derive from
11344         ravenscar_arch_ops.
11345         (ppc_ravenscar_powerpc_ops::fetch_registers)
11346         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11347         (ppc_ravenscar_powerpc_ops): Redefine.
11348         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11349         (ppc_ravenscar_e500_ops::fetch_registers)
11350         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11351         (ppc_ravenscar_e500_ops): Redefine.
11352         * aarch64-ravenscar-thread.c
11353         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11354         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11355         (aarch64_ravenscar_fetch_registers)
11356         (aarch64_ravenscar_store_registers): Now methods.
11357         (aarch64_ravenscar_ops): Redefine.
11358
11359 2019-02-15  Tom Tromey  <tromey@adacore.com>
11360
11361         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11362         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11363         (ravenscar_thread_target::stopped_by_watchpoint)
11364         (ravenscar_thread_target::stopped_data_address)
11365         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11366
11367 2019-02-15  Tom Tromey  <tromey@adacore.com>
11368
11369         * ravenscar-thread.c: Fix some typos.
11370
11371 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11372             Tom Tromey  <tromey@adacore.com>
11373
11374         * ada-lang.c (ada_exception_sal): Change addr_string to a
11375         std::string.
11376         (create_ada_exception_catchpoint): Update.
11377
11378 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11379             Tom Tromey  <tromey@adacore.com>
11380
11381         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11382         (bp_location_ops): Remove.
11383         (base_breakpoint_allocate_location): Update.
11384         (free_bp_location): Update.
11385         * ada-lang.c (class ada_catchpoint_location)
11386         <ada_catchpoint_location>: Remove ops parameter.
11387         (ada_catchpoint_location_dtor): Remove.
11388         (ada_catchpoint_location_ops): Remove.
11389         (allocate_location_exception): Update.
11390         * breakpoint.h (struct bp_location_ops): Remove.
11391         (class bp_location) <bp_location>: Remove bp_location_ops
11392         parameter.
11393         <~bp_location>: Add destructor.
11394         <ops>: Remove.
11395
11396 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11397             Pedro Alves  <palves@redhat.com>
11398
11399         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11400         'PATH_MAX'.
11401
11402 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11403             Samuel Thibault  <samuel.thibault@gnu.org>
11404             Thomas Schwinge  <thomas@codesourcery.com>
11405
11406         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11407         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11408
11409 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11410
11411         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11412         (check_empty): Use "const char *".
11413
11414         * gnu-nat.c (gnu_nat_target::detach): Instead of
11415         'detach_inferior (pid)' call
11416         'detach_inferior (find_inferior_pid (pid))'.
11417
11418         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11419         'nat/fork-inferior.o'.
11420         * gnu-nat.c: #include "nat/fork-inferior.h".
11421
11422         * gnu-nat.c (gnu_nat_target::detach): Instead of
11423         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11424         * gnu-nat.h: #include "inf-child.h".
11425         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11426         'i386_gnu_nat_target::fetch_registers'.
11427         (gnu_store_registers): Rename/move to
11428         'i386_gnu_nat_target::store_registers'.
11429
11430         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11431         * gnu-nat.h (mach_thread_info): New function.
11432         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11433
11434         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11435
11436 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11437
11438         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11439
11440 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11441
11442         * windows-nat.c (windows_add_thread): Add new parameter
11443         "main_thread_p" with default value set to false.  Update
11444         function documentation as well as all callers.
11445         (windows_delete_thread): Likewise.
11446         (fake_create_process): Update call to windows_add_thread.
11447         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11448         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11449         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11450         call to windows_delete_thread.
11451
11452 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11453
11454         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11455
11456 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11457
11458         * symfile.c (find_separate_debug_file): Use canonical path of
11459         sysroot with child_path instead of gdb_sysroot if it is valid.
11460
11461 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11462
11463         * symfile.c (find_separate_debug_file): Use child_path to
11464         determine if an object file is under a sysroot.
11465
11466 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11467
11468         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11469         unittests/child-path-selftests.c.
11470         * common/pathstuff.c (child_path): New function.
11471         * common/pathstuff.h (child_path): New prototype.
11472         * unittests/child-path-selftests.c: New file.
11473
11474 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11475
11476         * symfile.c (find_separate_debug_file): Look for separate debug
11477         files in debug directories under the sysroot.
11478
11479 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11480
11481         * symtab.h (struct minimal_symbol data_p): New const method.
11482         (struct minimal_symbol text_p): Likewise.
11483         * symtab.c (output_source_filename): Use file name style
11484         to print file name.
11485         (print_symbol_info): Likewise.
11486         (print_msymbol_info): Use address style to print addresses.
11487         Use function name style to print executable text symbols.
11488         (expand_symtab_containing_pc): Use data_p.
11489         (find_pc_sect_compunit_symtab): Likewise.
11490
11491 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11492
11493         * breakpoint.c (describe_other_breakpoints): Use address style
11494         to print addresses.
11495         (say_where): Likewise.
11496
11497 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11498
11499         * ada-typeprint.c (print_func_type): Print function name
11500         style to print function name.
11501         * c-typeprint.c (c_print_type_1): Likewise.
11502
11503 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11504
11505         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11506         for execve.
11507
11508 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11509
11510         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11511         type_stack.
11512
11513 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11514
11515         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11516         TYPE_CODE_REF types.
11517
11518 2019-02-08  Jim Wilson  <jimw@sifive.com>
11519
11520         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11521         (riscv_linux_fregset): New.
11522         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11523
11524 2019-02-07  Tom Tromey  <tom@tromey.com>
11525
11526         * thread.c (thread_cancel_execution_command): Update.
11527         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11528         methods.
11529         (struct thread_fsm_ops): Remove.
11530         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11531         (thread_fsm_should_stop, thread_fsm_return_value)
11532         (thread_fsm_set_finished, thread_fsm_finished_p)
11533         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11534         Don't declare.
11535         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11536         * infrun.c (clear_proceed_status_thread)
11537         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11538         (print_stop_event): Update.
11539         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11540         Add constructor.
11541         (step_command_fsm_ops): Remove.
11542         (new_step_command_fsm): Remove.
11543         (step_1): Update.
11544         (step_command_fsm::should_stop): Rename from
11545         step_command_fsm_should_stop.
11546         (step_command_fsm::clean_up): Rename from
11547         step_command_fsm_clean_up.
11548         (step_command_fsm::do_async_reply_reason): Rename from
11549         step_command_fsm_async_reply_reason.
11550         (struct until_next_fsm): Inherit from thread_fsm.  Add
11551         constructor.
11552         (until_next_fsm_ops): Remove.
11553         (new_until_next_fsm): Remove.
11554         (until_next_fsm::should_stop): Rename from
11555         until_next_fsm_should_stop.
11556         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11557         (until_next_fsm::do_async_reply_reason): Rename from
11558         until_next_fsm_async_reply_reason.
11559         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11560         constructor.  Change type of breakpoint.
11561         (finish_command_fsm_ops): Remove.
11562         (new_finish_command_fsm): Remove.
11563         (finish_command_fsm::should_stop): Rename from
11564         finish_command_fsm_should_stop.
11565         (finish_command_fsm::clean_up): Rename from
11566         finish_command_fsm_clean_up.
11567         (finish_command_fsm::return_value): Rename from
11568         finish_command_fsm_return_value.
11569         (finish_command_fsm::do_async_reply_reason): Rename from
11570         finish_command_fsm_async_reply_reason.
11571         (finish_command): Update.
11572         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11573         Add constructor.
11574         (call_thread_fsm_ops): Remove.
11575         (call_thread_fsm::call_thread_fsm): Rename from
11576         new_call_thread_fsm.
11577         (call_thread_fsm::should_stop): Rename from
11578         call_thread_fsm_should_stop.
11579         (call_thread_fsm::should_notify_stop): Rename from
11580         call_thread_fsm_should_notify_stop.
11581         (run_inferior_call, call_function_by_hand_dummy): Update.
11582         * cli/cli-interp.c (should_print_stop_to_console): Update.
11583         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11584         Add constructor.  Change type of location_breakpoint,
11585         caller_breakpoint.
11586         (until_break_fsm_ops): Remove.
11587         (new_until_break_fsm): Remove.
11588         (until_break_fsm::should_stop): Rename from
11589         until_break_fsm_should_stop.
11590         (until_break_fsm::clean_up): Rename from
11591         until_break_fsm_clean_up.
11592         (until_break_fsm::do_async_reply_reason): Rename from
11593         until_break_fsm_async_reply_reason.
11594         (until_break_command): Update.
11595         * thread-fsm.c: Remove.
11596         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11597
11598 2019-02-07  Tom Tromey  <tom@tromey.com>
11599
11600         * yy-remap.h: Add include guard.
11601         * xtensa-tdep.h: Add include guard.
11602         * xcoffread.h: Rename include guard.
11603         * varobj-iter.h: Add include guard.
11604         * tui/tui.h: Rename include guard.
11605         * tui/tui-winsource.h: Rename include guard.
11606         * tui/tui-wingeneral.h: Rename include guard.
11607         * tui/tui-windata.h: Rename include guard.
11608         * tui/tui-win.h: Rename include guard.
11609         * tui/tui-stack.h: Rename include guard.
11610         * tui/tui-source.h: Rename include guard.
11611         * tui/tui-regs.h: Rename include guard.
11612         * tui/tui-out.h: Rename include guard.
11613         * tui/tui-layout.h: Rename include guard.
11614         * tui/tui-io.h: Rename include guard.
11615         * tui/tui-hooks.h: Rename include guard.
11616         * tui/tui-file.h: Rename include guard.
11617         * tui/tui-disasm.h: Rename include guard.
11618         * tui/tui-data.h: Rename include guard.
11619         * tui/tui-command.h: Rename include guard.
11620         * tic6x-tdep.h: Add include guard.
11621         * target/waitstatus.h: Rename include guard.
11622         * target/wait.h: Rename include guard.
11623         * target/target.h: Rename include guard.
11624         * target/resume.h: Rename include guard.
11625         * target-float.h: Rename include guard.
11626         * stabsread.h: Add include guard.
11627         * rs6000-tdep.h: Add include guard.
11628         * riscv-fbsd-tdep.h: Add include guard.
11629         * regformats/regdef.h: Rename include guard.
11630         * record.h: Rename include guard.
11631         * python/python.h: Rename include guard.
11632         * python/python-internal.h: Rename include guard.
11633         * python/py-stopevent.h: Rename include guard.
11634         * python/py-ref.h: Rename include guard.
11635         * python/py-record.h: Rename include guard.
11636         * python/py-record-full.h: Rename include guard.
11637         * python/py-record-btrace.h: Rename include guard.
11638         * python/py-instruction.h: Rename include guard.
11639         * python/py-events.h: Rename include guard.
11640         * python/py-event.h: Rename include guard.
11641         * procfs.h: Add include guard.
11642         * proc-utils.h: Add include guard.
11643         * p-lang.h: Add include guard.
11644         * or1k-tdep.h: Rename include guard.
11645         * observable.h: Rename include guard.
11646         * nto-tdep.h: Rename include guard.
11647         * nat/x86-linux.h: Rename include guard.
11648         * nat/x86-linux-dregs.h: Rename include guard.
11649         * nat/x86-gcc-cpuid.h: Add include guard.
11650         * nat/x86-dregs.h: Rename include guard.
11651         * nat/x86-cpuid.h: Rename include guard.
11652         * nat/ppc-linux.h: Rename include guard.
11653         * nat/mips-linux-watch.h: Rename include guard.
11654         * nat/linux-waitpid.h: Rename include guard.
11655         * nat/linux-ptrace.h: Rename include guard.
11656         * nat/linux-procfs.h: Rename include guard.
11657         * nat/linux-osdata.h: Rename include guard.
11658         * nat/linux-nat.h: Rename include guard.
11659         * nat/linux-namespaces.h: Rename include guard.
11660         * nat/linux-btrace.h: Rename include guard.
11661         * nat/glibc_thread_db.h: Rename include guard.
11662         * nat/gdb_thread_db.h: Rename include guard.
11663         * nat/gdb_ptrace.h: Rename include guard.
11664         * nat/fork-inferior.h: Rename include guard.
11665         * nat/amd64-linux-siginfo.h: Rename include guard.
11666         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
11667         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
11668         * nat/aarch64-linux.h: Rename include guard.
11669         * nat/aarch64-linux-hw-point.h: Rename include guard.
11670         * mn10300-tdep.h: Add include guard.
11671         * mips-linux-tdep.h: Add include guard.
11672         * mi/mi-parse.h: Rename include guard.
11673         * mi/mi-out.h: Rename include guard.
11674         * mi/mi-main.h: Rename include guard.
11675         * mi/mi-interp.h: Rename include guard.
11676         * mi/mi-getopt.h: Rename include guard.
11677         * mi/mi-console.h: Rename include guard.
11678         * mi/mi-common.h: Rename include guard.
11679         * mi/mi-cmds.h: Rename include guard.
11680         * mi/mi-cmd-break.h: Rename include guard.
11681         * m2-lang.h: Add include guard.
11682         * location.h: Rename include guard.
11683         * linux-record.h: Rename include guard.
11684         * linux-nat.h: Add include guard.
11685         * linux-fork.h: Add include guard.
11686         * i386-darwin-tdep.h: Rename include guard.
11687         * hppa-linux-offsets.h: Add include guard.
11688         * guile/guile.h: Rename include guard.
11689         * guile/guile-internal.h: Rename include guard.
11690         * gnu-nat.h: Rename include guard.
11691         * gdb-stabs.h: Rename include guard.
11692         * frv-tdep.h: Add include guard.
11693         * f-lang.h: Add include guard.
11694         * event-loop.h: Add include guard.
11695         * darwin-nat.h: Rename include guard.
11696         * cp-abi.h: Rename include guard.
11697         * config/sparc/nm-sol2.h: Rename include guard.
11698         * config/nm-nto.h: Rename include guard.
11699         * config/nm-linux.h: Add include guard.
11700         * config/i386/nm-i386gnu.h: Rename include guard.
11701         * config/djgpp/nl_types.h: Rename include guard.
11702         * config/djgpp/langinfo.h: Rename include guard.
11703         * compile/gcc-cp-plugin.h: Add include guard.
11704         * compile/gcc-c-plugin.h: Add include guard.
11705         * compile/compile.h: Rename include guard.
11706         * compile/compile-object-run.h: Rename include guard.
11707         * compile/compile-object-load.h: Rename include guard.
11708         * compile/compile-internal.h: Rename include guard.
11709         * compile/compile-cplus.h: Rename include guard.
11710         * compile/compile-c.h: Rename include guard.
11711         * common/xml-utils.h: Rename include guard.
11712         * common/x86-xstate.h: Rename include guard.
11713         * common/version.h: Rename include guard.
11714         * common/vec.h: Rename include guard.
11715         * common/tdesc.h: Rename include guard.
11716         * common/selftest.h: Rename include guard.
11717         * common/scoped_restore.h: Rename include guard.
11718         * common/scoped_mmap.h: Rename include guard.
11719         * common/scoped_fd.h: Rename include guard.
11720         * common/safe-iterator.h: Rename include guard.
11721         * common/run-time-clock.h: Rename include guard.
11722         * common/refcounted-object.h: Rename include guard.
11723         * common/queue.h: Rename include guard.
11724         * common/ptid.h: Rename include guard.
11725         * common/print-utils.h: Rename include guard.
11726         * common/preprocessor.h: Rename include guard.
11727         * common/pathstuff.h: Rename include guard.
11728         * common/observable.h: Rename include guard.
11729         * common/netstuff.h: Rename include guard.
11730         * common/job-control.h: Rename include guard.
11731         * common/host-defs.h: Rename include guard.
11732         * common/gdb_wait.h: Rename include guard.
11733         * common/gdb_vecs.h: Rename include guard.
11734         * common/gdb_unlinker.h: Rename include guard.
11735         * common/gdb_unique_ptr.h: Rename include guard.
11736         * common/gdb_tilde_expand.h: Rename include guard.
11737         * common/gdb_sys_time.h: Rename include guard.
11738         * common/gdb_string_view.h: Rename include guard.
11739         * common/gdb_splay_tree.h: Rename include guard.
11740         * common/gdb_setjmp.h: Rename include guard.
11741         * common/gdb_ref_ptr.h: Rename include guard.
11742         * common/gdb_optional.h: Rename include guard.
11743         * common/gdb_locale.h: Rename include guard.
11744         * common/gdb_assert.h: Rename include guard.
11745         * common/filtered-iterator.h: Rename include guard.
11746         * common/filestuff.h: Rename include guard.
11747         * common/fileio.h: Rename include guard.
11748         * common/environ.h: Rename include guard.
11749         * common/common-utils.h: Rename include guard.
11750         * common/common-types.h: Rename include guard.
11751         * common/common-regcache.h: Rename include guard.
11752         * common/common-inferior.h: Rename include guard.
11753         * common/common-gdbthread.h: Rename include guard.
11754         * common/common-exceptions.h: Rename include guard.
11755         * common/common-defs.h: Rename include guard.
11756         * common/common-debug.h: Rename include guard.
11757         * common/cleanups.h: Rename include guard.
11758         * common/buffer.h: Rename include guard.
11759         * common/btrace-common.h: Rename include guard.
11760         * common/break-common.h: Rename include guard.
11761         * cli/cli-utils.h: Rename include guard.
11762         * cli/cli-style.h: Rename include guard.
11763         * cli/cli-setshow.h: Rename include guard.
11764         * cli/cli-script.h: Rename include guard.
11765         * cli/cli-interp.h: Rename include guard.
11766         * cli/cli-decode.h: Rename include guard.
11767         * cli/cli-cmds.h: Rename include guard.
11768         * charset-list.h: Add include guard.
11769         * buildsym-legacy.h: Rename include guard.
11770         * bfin-tdep.h: Add include guard.
11771         * ax.h: Rename include guard.
11772         * arm-linux-tdep.h: Add include guard.
11773         * arm-fbsd-tdep.h: Add include guard.
11774         * arch/xtensa.h: Rename include guard.
11775         * arch/tic6x.h: Add include guard.
11776         * arch/i386.h: Add include guard.
11777         * arch/arm.h: Rename include guard.
11778         * arch/arm-linux.h: Rename include guard.
11779         * arch/arm-get-next-pcs.h: Rename include guard.
11780         * arch/amd64.h: Add include guard.
11781         * arch/aarch64-insn.h: Rename include guard.
11782         * arch-utils.h: Rename include guard.
11783         * annotate.h: Add include guard.
11784         * amd64-darwin-tdep.h: Rename include guard.
11785         * aarch64-linux-tdep.h: Add include guard.
11786         * aarch64-fbsd-tdep.h: Add include guard.
11787         * aarch32-linux-nat.h: Add include guard.
11788
11789 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11790
11791         * macrotab.c (macro_define_internal): New function that
11792         factorizes macro_define_object_internal and macro_define_function
11793         code.
11794         (macro_define_object_internal): Use macro_define_internal.
11795         (macro_define_function): Likewise.
11796
11797 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11798
11799         * macrocmd.c (extract_identifier): Return
11800         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
11801         callers.
11802
11803 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
11804
11805         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
11806
11807 2019-02-05  Tom Tromey  <tom@tromey.com>
11808
11809         * target.c (target_stack::unpush): Move assertion earlier.
11810
11811 2019-01-30  Tom Tromey  <tom@tromey.com>
11812
11813         PR python/23615:
11814         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
11815         (gdbpy_parse_and_eval): Likewise.
11816         * python/python-internal.h (gdbpy_allow_threads): New class.
11817
11818 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
11819
11820         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
11821         (aarch64_fbsd_fpregmap): Move earlier.
11822         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
11823         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11824         instead of individual calls to trad_frame_set_reg_addr.
11825         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
11826         earlier.
11827         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
11828         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
11829         instead of individual calls to trad_frame_set_reg_addr.
11830
11831 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
11832
11833         * CONTRIBUTE: Replace contribution list with wiki link.
11834
11835 2019-01-25  Tom Tromey  <tom@tromey.com>
11836
11837         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
11838
11839 2019-01-25  Tom Tromey  <tom@tromey.com>
11840
11841         * xtensa-linux-nat.c: Fix common/ includes.
11842         * xml-support.h: Fix common/ includes.
11843         * xml-support.c: Fix common/ includes.
11844         * x86-linux-nat.c: Fix common/ includes.
11845         * windows-nat.c: Fix common/ includes.
11846         * varobj.h: Fix common/ includes.
11847         * varobj.c: Fix common/ includes.
11848         * value.c: Fix common/ includes.
11849         * valops.c: Fix common/ includes.
11850         * utils.c: Fix common/ includes.
11851         * unittests/xml-utils-selftests.c: Fix common/ includes.
11852         * unittests/utils-selftests.c: Fix common/ includes.
11853         * unittests/unpack-selftests.c: Fix common/ includes.
11854         * unittests/tracepoint-selftests.c: Fix common/ includes.
11855         * unittests/style-selftests.c: Fix common/ includes.
11856         * unittests/string_view-selftests.c: Fix common/ includes.
11857         * unittests/scoped_restore-selftests.c: Fix common/ includes.
11858         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
11859         * unittests/scoped_fd-selftests.c: Fix common/ includes.
11860         * unittests/rsp-low-selftests.c: Fix common/ includes.
11861         * unittests/parse-connection-spec-selftests.c: Fix common/
11862         includes.
11863         * unittests/optional-selftests.c: Fix common/ includes.
11864         * unittests/offset-type-selftests.c: Fix common/ includes.
11865         * unittests/observable-selftests.c: Fix common/ includes.
11866         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
11867         * unittests/memrange-selftests.c: Fix common/ includes.
11868         * unittests/memory-map-selftests.c: Fix common/ includes.
11869         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
11870         * unittests/function-view-selftests.c: Fix common/ includes.
11871         * unittests/environ-selftests.c: Fix common/ includes.
11872         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
11873         * unittests/common-utils-selftests.c: Fix common/ includes.
11874         * unittests/cli-utils-selftests.c: Fix common/ includes.
11875         * unittests/array-view-selftests.c: Fix common/ includes.
11876         * ui-file.c: Fix common/ includes.
11877         * tui/tui-io.c: Fix common/ includes.
11878         * tracepoint.h: Fix common/ includes.
11879         * tracepoint.c: Fix common/ includes.
11880         * tracefile-tfile.c: Fix common/ includes.
11881         * top.h: Fix common/ includes.
11882         * top.c: Fix common/ includes.
11883         * thread.c: Fix common/ includes.
11884         * target/waitstatus.h: Fix common/ includes.
11885         * target/waitstatus.c: Fix common/ includes.
11886         * target.h: Fix common/ includes.
11887         * target.c: Fix common/ includes.
11888         * target-memory.c: Fix common/ includes.
11889         * target-descriptions.c: Fix common/ includes.
11890         * symtab.h: Fix common/ includes.
11891         * symfile.c: Fix common/ includes.
11892         * stap-probe.c: Fix common/ includes.
11893         * spu-linux-nat.c: Fix common/ includes.
11894         * sparc-nat.c: Fix common/ includes.
11895         * source.c: Fix common/ includes.
11896         * solib.c: Fix common/ includes.
11897         * solib-target.c: Fix common/ includes.
11898         * ser-unix.c: Fix common/ includes.
11899         * ser-tcp.c: Fix common/ includes.
11900         * ser-pipe.c: Fix common/ includes.
11901         * ser-base.c: Fix common/ includes.
11902         * selftest-arch.c: Fix common/ includes.
11903         * s12z-tdep.c: Fix common/ includes.
11904         * rust-exp.y: Fix common/ includes.
11905         * rs6000-aix-tdep.c: Fix common/ includes.
11906         * riscv-tdep.c: Fix common/ includes.
11907         * remote.c: Fix common/ includes.
11908         * remote-notif.h: Fix common/ includes.
11909         * remote-fileio.h: Fix common/ includes.
11910         * remote-fileio.c: Fix common/ includes.
11911         * regcache.h: Fix common/ includes.
11912         * regcache.c: Fix common/ includes.
11913         * record-btrace.c: Fix common/ includes.
11914         * python/python.c: Fix common/ includes.
11915         * python/py-type.c: Fix common/ includes.
11916         * python/py-inferior.c: Fix common/ includes.
11917         * progspace.h: Fix common/ includes.
11918         * producer.c: Fix common/ includes.
11919         * procfs.c: Fix common/ includes.
11920         * proc-api.c: Fix common/ includes.
11921         * printcmd.c: Fix common/ includes.
11922         * ppc-linux-nat.c: Fix common/ includes.
11923         * parser-defs.h: Fix common/ includes.
11924         * osdata.c: Fix common/ includes.
11925         * obsd-nat.c: Fix common/ includes.
11926         * nat/x86-linux.c: Fix common/ includes.
11927         * nat/x86-linux-dregs.c: Fix common/ includes.
11928         * nat/x86-dregs.h: Fix common/ includes.
11929         * nat/x86-dregs.c: Fix common/ includes.
11930         * nat/ppc-linux.c: Fix common/ includes.
11931         * nat/mips-linux-watch.h: Fix common/ includes.
11932         * nat/mips-linux-watch.c: Fix common/ includes.
11933         * nat/linux-waitpid.c: Fix common/ includes.
11934         * nat/linux-ptrace.h: Fix common/ includes.
11935         * nat/linux-ptrace.c: Fix common/ includes.
11936         * nat/linux-procfs.c: Fix common/ includes.
11937         * nat/linux-personality.c: Fix common/ includes.
11938         * nat/linux-osdata.c: Fix common/ includes.
11939         * nat/linux-namespaces.c: Fix common/ includes.
11940         * nat/linux-btrace.h: Fix common/ includes.
11941         * nat/linux-btrace.c: Fix common/ includes.
11942         * nat/fork-inferior.c: Fix common/ includes.
11943         * nat/amd64-linux-siginfo.c: Fix common/ includes.
11944         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
11945         * nat/aarch64-linux.c: Fix common/ includes.
11946         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
11947         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
11948         * namespace.h: Fix common/ includes.
11949         * mips-linux-tdep.c: Fix common/ includes.
11950         * minsyms.c: Fix common/ includes.
11951         * mi/mi-parse.h: Fix common/ includes.
11952         * mi/mi-main.c: Fix common/ includes.
11953         * mi/mi-cmd-env.c: Fix common/ includes.
11954         * memrange.h: Fix common/ includes.
11955         * memattr.c: Fix common/ includes.
11956         * maint.h: Fix common/ includes.
11957         * maint.c: Fix common/ includes.
11958         * main.c: Fix common/ includes.
11959         * machoread.c: Fix common/ includes.
11960         * location.c: Fix common/ includes.
11961         * linux-thread-db.c: Fix common/ includes.
11962         * linux-nat.c: Fix common/ includes.
11963         * linux-fork.c: Fix common/ includes.
11964         * inline-frame.c: Fix common/ includes.
11965         * infrun.c: Fix common/ includes.
11966         * inflow.c: Fix common/ includes.
11967         * inferior.h: Fix common/ includes.
11968         * inferior.c: Fix common/ includes.
11969         * infcmd.c: Fix common/ includes.
11970         * inf-ptrace.c: Fix common/ includes.
11971         * inf-child.c: Fix common/ includes.
11972         * ia64-linux-nat.c: Fix common/ includes.
11973         * i387-tdep.c: Fix common/ includes.
11974         * i386-tdep.c: Fix common/ includes.
11975         * i386-linux-tdep.c: Fix common/ includes.
11976         * i386-linux-nat.c: Fix common/ includes.
11977         * i386-go32-tdep.c: Fix common/ includes.
11978         * i386-fbsd-tdep.c: Fix common/ includes.
11979         * i386-fbsd-nat.c: Fix common/ includes.
11980         * guile/scm-type.c: Fix common/ includes.
11981         * guile/guile.c: Fix common/ includes.
11982         * go32-nat.c: Fix common/ includes.
11983         * gnu-nat.c: Fix common/ includes.
11984         * gdbthread.h: Fix common/ includes.
11985         * gdbarch-selftests.c: Fix common/ includes.
11986         * gdb_usleep.c: Fix common/ includes.
11987         * gdb_select.h: Fix common/ includes.
11988         * gdb_bfd.c: Fix common/ includes.
11989         * gcore.c: Fix common/ includes.
11990         * fork-child.c: Fix common/ includes.
11991         * findvar.c: Fix common/ includes.
11992         * fbsd-nat.c: Fix common/ includes.
11993         * event-top.c: Fix common/ includes.
11994         * event-loop.c: Fix common/ includes.
11995         * dwarf2read.c: Fix common/ includes.
11996         * dwarf2loc.c: Fix common/ includes.
11997         * dwarf2-frame.c: Fix common/ includes.
11998         * dwarf-index-cache.c: Fix common/ includes.
11999         * dtrace-probe.c: Fix common/ includes.
12000         * disasm-selftests.c: Fix common/ includes.
12001         * defs.h: Fix common/ includes.
12002         * csky-tdep.c: Fix common/ includes.
12003         * cp-valprint.c: Fix common/ includes.
12004         * cp-support.h: Fix common/ includes.
12005         * cp-support.c: Fix common/ includes.
12006         * corelow.c: Fix common/ includes.
12007         * completer.h: Fix common/ includes.
12008         * completer.c: Fix common/ includes.
12009         * compile/compile.c: Fix common/ includes.
12010         * compile/compile-loc2c.c: Fix common/ includes.
12011         * compile/compile-cplus-types.c: Fix common/ includes.
12012         * compile/compile-cplus-symbols.c: Fix common/ includes.
12013         * command.h: Fix common/ includes.
12014         * cli/cli-dump.c: Fix common/ includes.
12015         * cli/cli-cmds.c: Fix common/ includes.
12016         * charset.c: Fix common/ includes.
12017         * build-id.c: Fix common/ includes.
12018         * btrace.h: Fix common/ includes.
12019         * btrace.c: Fix common/ includes.
12020         * breakpoint.h: Fix common/ includes.
12021         * breakpoint.c: Fix common/ includes.
12022         * ax.h:
12023         (enum agent_op): Fix common/ includes.
12024         * ax-general.c (struct aop_map): Fix common/ includes.
12025         * ax-gdb.c: Fix common/ includes.
12026         * auxv.c: Fix common/ includes.
12027         * auto-load.c: Fix common/ includes.
12028         * arm-tdep.c: Fix common/ includes.
12029         * arch/riscv.c: Fix common/ includes.
12030         * arch/ppc-linux-common.c: Fix common/ includes.
12031         * arch/i386.c: Fix common/ includes.
12032         * arch/arm.c: Fix common/ includes.
12033         * arch/arm-linux.c: Fix common/ includes.
12034         * arch/arm-get-next-pcs.c: Fix common/ includes.
12035         * arch/amd64.c: Fix common/ includes.
12036         * arch/aarch64.c: Fix common/ includes.
12037         * arch/aarch64-insn.c: Fix common/ includes.
12038         * arch-utils.c: Fix common/ includes.
12039         * amd64-windows-tdep.c: Fix common/ includes.
12040         * amd64-tdep.c: Fix common/ includes.
12041         * amd64-sol2-tdep.c: Fix common/ includes.
12042         * amd64-obsd-tdep.c: Fix common/ includes.
12043         * amd64-nbsd-tdep.c: Fix common/ includes.
12044         * amd64-linux-tdep.c: Fix common/ includes.
12045         * amd64-linux-nat.c: Fix common/ includes.
12046         * amd64-fbsd-tdep.c: Fix common/ includes.
12047         * amd64-fbsd-nat.c: Fix common/ includes.
12048         * amd64-dicos-tdep.c: Fix common/ includes.
12049         * amd64-darwin-tdep.c: Fix common/ includes.
12050         * agent.c: Fix common/ includes.
12051         * ada-lang.h: Fix common/ includes.
12052         * ada-lang.c: Fix common/ includes.
12053         * aarch64-tdep.c: Fix common/ includes.
12054
12055 2019-01-25  Tom Tromey  <tom@tromey.com>
12056
12057         * common/create-version.sh: Use common/version.h.
12058
12059 2019-01-24  Pedro Alves  <palves@redhat.com>
12060
12061         * infrun.c (signal_stop, signal_print, signal_program)
12062         (signal_catch, signal_pass): Now arrays instead of pointers.
12063         (update_signals_program_target, do_target_resume)
12064         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12065         * linux-nat.c (linux_nat_target::pass_signals)
12066         (linux_nat_target::create_inferior, linux_nat_target::attach):
12067         Adjust.
12068         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12069         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12070         * procfs.c (procfs_target::pass_signals): Adjust.
12071         * record-full.c (record_full_target::resume): Adjust.
12072         * remote.c (remote_target::pass_signals)
12073         (remote_target::program_signals): Adjust.
12074         * target-debug.h (target_debug_print_signals): Now takes a
12075         gdb::array_view as parameter.  Adjust.
12076         * target.h (target_ops) <pass_signals, program_signals>: Replace
12077         pointer and length parameters with gdb::array_view.
12078         (target_pass_signals, target_program_signals): Likewise.
12079         * target-delegates.c: Regenerate.
12080
12081 2019-01-24  Pedro Alves  <palves@redhat.com>
12082
12083         * common/forward-scope-exit.h
12084         (forward_scope_exit::forward_scope_exit): Pass arguments to
12085         m_bind_function directly, instead of creating a std::bind and
12086         copying that.
12087
12088 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12089
12090         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12091         for static members.
12092         (pass_in_v_vfp_candidate): Likewise.
12093
12094 2019-01-23  Tom Tromey  <tom@tromey.com>
12095             Pedro Alves  <palves@redhat.com>
12096
12097         * regcache.c (class regcache_invalidator): Remove.
12098         (regcache::raw_write): Use make_scope_exit.
12099
12100 2019-01-23  Tom Tromey  <tom@tromey.com>
12101
12102         * ui-out.h (class ui_out_emit_type): Update comment.
12103
12104 2019-01-23  Tom Tromey  <tom@tromey.com>
12105
12106         * infrun.c (fetch_inferior_event): Update comment.
12107
12108 2019-01-23  Tom Tromey  <tom@tromey.com>
12109             Pedro Alves  <palves@redhat.com>
12110
12111         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12112         parameter.
12113         (fetch_inferior_event): Use SCOPE_EXIT.
12114
12115
12116 2019-01-23  Tom Tromey  <tom@tromey.com>
12117             Pedro Alves  <palves@redhat.com>
12118
12119         * infrun.c (disable_thread_events): Delete.
12120         (stop_all_threads): Use SCOPE_EXIT.
12121
12122 2019-01-23  Tom Tromey  <tom@tromey.com>
12123             Pedro Alves  <palves@redhat.com>
12124
12125         * symfile.c: Include forward-scope-exit.h.
12126         (clear_symtab_users_cleanup): Replace forward declaration with
12127         a FORWARD_SCOPE_EXIT.
12128         (syms_from_objfile_1): Use the forward_scope_exit and
12129         gdb::optional instead of cleanup_function.
12130         (reread_symbols): Use the forward_scope_exit instead of
12131         cleanup_function.
12132         (clear_symtab_users_cleanup): Remove function.
12133
12134 2019-01-23  Tom Tromey  <tom@tromey.com>
12135             Pedro Alves  <palves@redhat.com>
12136
12137         * linux-nat.c: Include scope-exit.h.
12138         (cleanup_target_stop): Remove.
12139         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12140         SCOPE_EXIT.
12141
12142 2019-01-23  Tom Tromey  <tom@tromey.com>
12143             Pedro Alves  <palves@redhat.com>
12144
12145         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12146         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12147
12148 2019-01-23  Tom Tromey  <tom@tromey.com>
12149             Andrew Burgess  <andrew.burgess@embecosm.com>
12150             Pedro Alves  <palves@redhat.com>
12151
12152         * infrun.c (fetch_inferior_event): Use scope_exit.
12153         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12154         * top.c (execute_command): Use scope_exit.
12155         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12156         * utils.c (do_bpstat_clear_actions_cleanup)
12157         (make_bpstat_clear_actions_cleanup): Remove.
12158
12159 2019-01-23  Tom Tromey  <tom@tromey.com>
12160             Pedro Alves  <palves@redhat.com>
12161
12162         * infrun.c: Include "common/scope-exit.h"
12163         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12164         (wait_for_inferior): Use SCOPE_EXIT.
12165         (fetch_inferior_event): Use scope_exit.
12166
12167 2019-01-23  Tom Tromey  <tom@tromey.com>
12168             Pedro Alves  <palves@redhat.com>
12169
12170         * breakpoint.c (create_breakpoint): Remove cleanup.
12171
12172 2019-01-23  Tom Tromey  <tom@tromey.com>
12173             Andrew Burgess  <andrew.burgess@embecosm.com>
12174             Pedro Alves  <palves@redhat.com>
12175
12176 2019-01-23  Pedro Alves  <palves@redhat.com>
12177
12178         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12179
12180 2019-01-23  Pedro Alves  <palves@redhat.com>
12181             Andrew Burgess  <andrew.burgess@embecosm.com>
12182
12183         * gdbthread.h: Include "common/forward-scope-exit.h".
12184         (scoped_finish_thread_state): Redefine custom class in terms of
12185         forward_scope_exit.
12186
12187 2019-01-23  Pedro Alves  <palves@redhat.com>
12188             Andrew Burgess  <andrew.burgess@embecosm.com>
12189
12190         * common/forward-scope-exit.h: New file.
12191
12192 2019-01-23  Pedro Alves  <palves@redhat.com>
12193             Andrew Burgess  <andrew.burgess@embecosm.com>
12194             Tom Tromey  <tom@tromey.com>
12195
12196         * common/scope-exit.h: New file.
12197
12198 2019-01-23  Pedro Alves  <palves@redhat.com>
12199
12200         * common/preprocessor.h (ESC): Rename to ...
12201         (ESC_PARENS): ... this.
12202         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12203         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12204
12205 2019-01-23  Tom Tromey  <tom@tromey.com>
12206
12207         * language.h (class scoped_switch_to_sym_language_if_auto):
12208         Initialize m_lang in both cases.
12209
12210 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12211
12212         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12213         with XCNEW.
12214
12215 2019-01-22  Tom Tromey  <tom@tromey.com>
12216
12217         * corelow.c: Do not include sys/file.h.
12218
12219 2019-01-22  Tom Tromey  <tom@tromey.com>
12220
12221         * tui/tui-wingeneral.h: Include gdb_curses.h.
12222
12223 2019-01-22  Tom Tromey  <tom@tromey.com>
12224
12225         * source-cache.h (class source_cache) <get_source_lines,
12226         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12227
12228 2019-01-22  Tom Tromey  <tom@tromey.com>
12229
12230         * remote-fileio.h (struct remote_target): Declare.
12231
12232 2019-01-22  Tom Tromey  <tom@tromey.com>
12233
12234         * python/py-arch.c: Do not include py-ref.h.
12235         * python/py-bpevent.c: Do not include py-ref.h.
12236         * python/py-cmd.c: Do not include py-ref.h.
12237         * python/py-continueevent.c: Do not include py-ref.h.
12238         * python/py-event.h: Do not include py-ref.h.
12239         * python/py-evtregistry.c: Do not include py-ref.h.
12240         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12241         * python/py-frame.c: Do not include py-ref.h.
12242         * python/py-framefilter.c: Do not include py-ref.h.
12243         * python/py-function.c: Do not include py-ref.h.
12244         * python/py-infevents.c: Do not include py-ref.h.
12245         * python/py-linetable.c: Do not include py-ref.h.
12246         * python/py-objfile.c: Do not include py-ref.h.
12247         * python/py-param.c: Do not include py-ref.h.
12248         * python/py-prettyprint.c: Do not include py-ref.h.
12249         * python/py-progspace.c: Do not include py-ref.h.
12250         * python/py-symbol.c: Do not include py-ref.h.
12251         * python/py-symtab.c: Do not include py-ref.h.
12252         * python/py-type.c: Do not include py-ref.h.
12253         * python/py-unwind.c: Do not include py-ref.h.
12254         * python/py-utils.c: Do not include py-ref.h.
12255         * python/py-value.c: Do not include py-ref.h.
12256         * python/py-varobj.c: Do not include py-ref.h.
12257         * python/py-xmethods.c: Do not include py-ref.h.
12258         * python/python.c: Do not include py-ref.h.
12259         * varobj.c: Do not include py-ref.h.
12260
12261 2019-01-22  Tom Tromey  <tom@tromey.com>
12262
12263         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12264         keyword for bcache.
12265
12266 2019-01-22  Tom Tromey  <tom@tromey.com>
12267
12268         * compile/compile-cplus-types.c: Remove a comment by #include.
12269
12270 2019-01-22  Tom Tromey  <tom@tromey.com>
12271
12272         * compile/gcc-c-plugin.h: Include compile-internal.h.
12273
12274 2019-01-22  Tom Tromey  <tom@tromey.com>
12275
12276         * stabsread.c (EXTERN): Do not define.
12277         (symnum, next_symbol_text_func, processing_gcc_compilation)
12278         (within_function, global_sym_chain, global_stabs)
12279         (previous_stab_code, this_object_header_files)
12280         (n_this_object_header_files)
12281         (n_allocated_this_object_header_files): Define.
12282         * stabsread.h (EXTERN): Never define.  Use "extern".
12283
12284 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12285
12286         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12287         history_value.
12288
12289 2019-01-21  Tom Tromey  <tom@tromey.com>
12290
12291         * ui-out.c: Fix includes.
12292         * tui/tui-source.c: Fix includes.
12293         * target.c: Fix includes.
12294         * remote.c: Fix includes.
12295         * regcache.c: Fix includes.
12296         * python/py-block.c: Fix includes.
12297         * printcmd.c: Fix includes.
12298         * or1k-tdep.c: Fix includes.
12299         * mi/mi-main.c: Fix includes.
12300         * m32r-tdep.c: Fix includes.
12301         * csky-tdep.c: Fix includes.
12302         * compile/compile-cplus-types.c: Fix includes.
12303         * cli/cli-interp.c: Fix includes.
12304
12305 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12306
12307         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12308         for padding.
12309
12310 2019-01-16  Tom Tromey  <tom@tromey.com>
12311
12312         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12313         earlier.
12314         (struct objfile) <msymbols_range>: Move from top level.
12315         <msymbols>: New method.
12316         (class objfile_msymbols): Remove.
12317         * symtab.c (default_collect_symbol_completion_matches_break_on):
12318         Update.
12319         * symmisc.c (dump_msymbols): Update.
12320         * stabsread.c (scan_file_globals): Update.
12321         * objc-lang.c (info_selectors_command, info_classes_command)
12322         (find_methods): Update.
12323         * minsyms.c (find_solib_trampoline_target): Update.
12324         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12325         * coffread.c (coff_symfile_read): Update.
12326         * ada-lang.c (ada_lookup_simple_minsym)
12327         (ada_collect_symbol_completion_matches): Update.
12328
12329 2019-01-16  Tom Tromey  <tom@tromey.com>
12330
12331         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12332         type.  Remove no-argument constructor.
12333         <iterator::operator++>: Simplify.
12334         <begin>: Update.
12335         <end>: Use minimal_symbol_count.
12336
12337 2019-01-16  Tom Tromey  <tom@tromey.com>
12338
12339         * objfiles.h (struct objfile) <psymtabs>: New method.
12340         (class objfile_psymtabs): Remove.
12341         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12342         typedef.
12343         <range>: New method.
12344         (require_partial_symbols): Change return type.
12345         * psymtab.c (require_partial_symbols)
12346         (psym_expand_symtabs_matching): Update.
12347         * mdebugread.c (parse_partial_symbols): Update.
12348         * dbxread.c (dbx_end_psymtab): Update.
12349
12350 2019-01-15  Tom Tromey  <tom@tromey.com>
12351
12352         * symtab.c (lookup_objfile_from_block)
12353         (lookup_symbol_in_objfile_symtabs)
12354         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12355         (find_line_symtab, info_sources_command)
12356         (default_collect_symbol_completion_matches_break_on)
12357         (make_source_files_completion_list): Update.
12358         * symmisc.c (print_objfile_statistics, dump_objfile)
12359         (maintenance_print_symbols, maintenance_info_symtabs)
12360         (maintenance_check_symtabs, maintenance_info_line_tables):
12361         Update.
12362         * source.c (select_source_symtab)
12363         (forget_cached_source_info_for_objfile): Update.
12364         * objfiles.h (class objfile_compunits): Remove.
12365         (struct objfile) <compunits_range>: New typedef.
12366         (compunits): New method.
12367         * objfiles.c (objfile_relocate1): Update.
12368         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12369         * maint.c (count_symtabs_and_blocks): Update.
12370         * linespec.c (iterate_over_all_matching_symtabs): Update.
12371         * cp-support.c (add_symbol_overload_list_qualified): Update.
12372         * coffread.c (coff_symtab_read): Update.
12373         * ada-lang.c (add_nonlocal_symbols)
12374         (ada_collect_symbol_completion_matches)
12375         (ada_add_global_exceptions): Update.
12376
12377 2019-01-15  Tom Tromey  <tom@tromey.com>
12378
12379         * progspace.h (program_space) <objfiles_safe_range>: New
12380         typedef.
12381         <objfiles_safe>: New method.
12382         * objfiles.h (class all_objfiles_safe): Remove.
12383         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12384         * jit.c (jit_inferior_exit_hook): Update.
12385
12386 2019-01-17  Tom Tromey  <tom@tromey.com>
12387
12388         * progspace.h (program_space) <objfiles_range>: New typedef.
12389         <objfiles>: New method.
12390         <objfiles_head>: Rename from objfiles.
12391         (object_files): Update.
12392         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12393         * guile/scm-pretty-print.c
12394         (ppscm_find_pretty_printer_from_objfiles): Update.
12395         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12396         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12397         Update.
12398         * python/py-progspace.c (pspy_get_objfiles): Update.
12399         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12400         Update.
12401         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12402         (objfpy_lookup_objfile_by_build_id): Update.
12403         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12404         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12405         Update.
12406         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12407         (expand_symtab_containing_pc, lookup_objfile_from_block)
12408         (lookup_static_symbol, basic_lookup_transparent_type)
12409         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12410         (find_line_symtab, info_sources_command)
12411         (default_collect_symbol_completion_matches_break_on)
12412         (make_source_files_completion_list, find_main_name): Update.
12413         * symmisc.c (print_symbol_bcache_statistics)
12414         (print_objfile_statistics, maintenance_print_symbols)
12415         (maintenance_print_msymbols, maintenance_print_objfiles)
12416         (maintenance_info_symtabs, maintenance_check_symtabs)
12417         (maintenance_expand_symtabs, maintenance_info_line_tables):
12418         Update.
12419         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12420         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12421         (map_overlay_command, unmap_overlay_command)
12422         (simple_overlay_update, expand_symtabs_matching)
12423         (map_symbol_filenames): Update.
12424         * symfile-debug.c (set_debug_symfile): Update.
12425         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12426         Update.
12427         * source.c (select_source_symtab, forget_cached_source_info):
12428         Update.
12429         * solib.c (solib_read_symbols): Update.
12430         * solib-spu.c (append_ocl_sos): Update.
12431         * psymtab.c (maintenance_print_psymbols)
12432         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12433         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12434         * printcmd.c (info_symbol_command): Update.
12435         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12436         Update.
12437         * objfiles.h (class all_objfiles): Remove.
12438         * objfiles.c (have_partial_symbols, have_full_symbols)
12439         (have_minimal_symbols, qsort_cmp, update_section_map)
12440         (shared_objfile_contains_address_p)
12441         (default_iterate_over_objfiles_in_search_order): Update.
12442         * objc-lang.c (info_selectors_command, info_classes_command)
12443         (find_methods): Update.
12444         * minsyms.c (find_solib_trampoline_target): Update.
12445         * maint.c (maintenance_info_sections)
12446         (maintenance_translate_address, count_symtabs_and_blocks):
12447         Update.
12448         * main.c (captured_main_1): Update.
12449         * linux-thread-db.c (try_thread_db_load_from_pdir)
12450         (has_libpthread): Update.
12451         * linespec.c (iterate_over_all_matching_symtabs)
12452         (search_minsyms_for_name): Update.
12453         * jit.c (jit_find_objf_with_entry_addr): Update.
12454         * hppa-tdep.c (find_unwind_entry)
12455         (hppa_lookup_stub_minimal_symbol): Update.
12456         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12457         Update.
12458         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12459         (elf_gnu_ifunc_resolve_by_got): Update.
12460         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12461         * dwarf-index-write.c (save_gdb_index_command): Update.
12462         * cp-support.c (add_symbol_overload_list_qualified): Update.
12463         * breakpoint.c (create_overlay_event_breakpoint)
12464         (create_longjmp_master_breakpoint)
12465         (create_std_terminate_master_breakpoint)
12466         (create_exception_master_breakpoint): Update.
12467         * blockframe.c (find_pc_partial_function): Update.
12468         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12469         (ada_collect_symbol_completion_matches)
12470         (ada_add_global_exceptions): Update.
12471
12472 2019-01-17  Tom Tromey  <tom@tromey.com>
12473
12474         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12475         declare VEC.
12476         (solib_target_parse_libraries): Change return type.
12477         (library_list_start_segment, library_list_start_section)
12478         (library_list_end_library, library_list_start_library); Update.
12479         (solib_target_free_library_list): Remove.
12480         (solib_target_parse_libraries): Remove cleanup.  Change return
12481         type.
12482         (solib_target_current_sos): Update.
12483
12484 2019-01-17  Tom Tromey  <tromey@bapiya>
12485
12486         * valprint.c: Replace "the the" with "the".
12487         * symtab.c: Replace "the the" with "the".
12488         * solib.c: Replace "the the" with "the".
12489         * solib-dsbt.c: Replace "the the" with "the".
12490         * linespec.c: Replace "the the" with "the".
12491         * dwarf2loc.h: Replace "the the" with "the".
12492         * amd64-windows-tdep.c: Replace "the the" with "the".
12493         * aarch64-tdep.c: Replace "the the" with "the".
12494
12495 2019-01-16  Keith Seitz  <keiths@redhat.com>
12496
12497         PR gdb/23773
12498         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12499         <builder>: Rename to ..
12500         <m_builder>: ... this and make private.
12501         (dwarf2_cu::get_builder): New method.  Change all users of
12502         `builder' to use this method.
12503         (dwarf2_start_symtab): Move to ...
12504         (dwarf2_cu::start_symtab): ... here.  Update all callers
12505         (setup_type_unit_groups): Move to ...
12506         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12507         callers.
12508         (dwarf2_cu::reset_builder): New method.
12509         (process_full_compunit, process_full_type_unit): Use
12510         dwarf2_cu::reset_builder.
12511         (follow_die_offset): Record the ancestor CU if it is different
12512         from the followed DIE's CU.
12513         (follow_die_sig_1): Likewise.
12514
12515 2019-01-15  Tom Tromey  <tom@tromey.com>
12516
12517         * remote.c (class remote_state) <buf>: Now a char_vector.
12518         <buf_size>: Remove.
12519         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12520         parameter.
12521         (remote_target::getpkt_or_notif_sane_1)
12522         (remote_target::getpkt_sane)
12523         (remote_target::getpkt_or_notif_sane): Likewise.
12524         (class remote_target) <putpkt>: New overload.
12525         (remote_target::read_frame): Change type of "buf_p".  Remove
12526         sizeof_p parameter.
12527         (packet_ok): New overload.
12528         (packet_check_result): New overload.
12529         Update all uses.
12530
12531 2019-01-14  Tom Tromey  <tom@tromey.com>
12532
12533         * remote-notif.c (handle_notification, remote_notif_ack)
12534         (remote_notif_parse): Make "buf" const.
12535         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12536         const.
12537         (remote_notif_parse, remote_notif_ack, handle_notification):
12538         Likewise.
12539         * remote.c (remote_notif_stop_parse): Make "buf" const.
12540         (remote_target::remote_parse_stop_reply): Make "buf" const.
12541         (remote_notif_stop_ack): Make "buf" const.
12542
12543 2019-01-14  Tom Tromey  <tom@tromey.com>
12544
12545         * remote.c (remote_console_output): Make parameter const.
12546
12547 2019-01-14  Tom Tromey  <tom@tromey.com>
12548
12549         * target-debug.h (target_debug_print_signals): Constify.
12550         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12551         * procfs.c (procfs_target::pass_signals): Update.
12552         * linux-nat.c (linux_nat_target::pass_signals): Update.
12553         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12554         * target-delegates.c: Rebuild.
12555         * remote.c (remote_target::program_signals): Update.
12556         (remote_target::pass_signals): Update.
12557         * target.c (target_pass_signals): Constify argument.
12558         (target_program_signals): Likewise.
12559         * target.h (struct target_ops) <pass_signals, program_signals>:
12560         Constify argument.
12561         (target_pass_signals, target_program_signals): Constify argument.
12562
12563 2019-01-14  Tom Tromey  <tom@tromey.com>
12564
12565         PR tui/28819:
12566         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12567
12568 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12569
12570         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12571         field.
12572         * rs6000-tdep.c: Include reggroups.h.
12573         (IS_V_ALIAS_PSEUDOREG): Define.
12574         (rs6000_register_name): Return names for the "vX" aliases.
12575         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12576         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12577         aliases.  Call default_register_reggroup_p for all other
12578         pseudo-registers.
12579         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12580         New functions.
12581         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12582         Handle "vX" aliases.
12583         (v_alias_pseudo_register_collect): New function.
12584         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12585         (rs6000_gdbarch_init): Initialize "vX" aliases as
12586         pseudo-registers.  Restore registration of
12587         rs6000_pseudo_register_reggroup_p with
12588         set_tdesc_pseudo_register_reggroup_p.
12589
12590 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12591
12592         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12593         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12594         set_gdbarch_num_pseudo_regs.
12595
12596 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12597
12598         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12599         Remove arg prefixname, add do_set and do_show.
12600         Add member functions set_list and show_list.
12601         * cli/cli-style.c (class cli_style_option): Update accordingly.
12602         (style_set_list): Move to file scope.
12603         (style_show_list): Likewise.
12604         (set_style): Call help_list.
12605         (show_style): Call cmd_show_list.
12606         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12607         Update to use the new macro.
12608
12609 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12610
12611         * ada-lang.c (_initialize_ada_language): Expand the help text
12612         for the "catch exception" command.
12613
12614 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12615
12616         * symtab.c (matching_obj_sections): Initialize obj,
12617         declare it closer to its usage.
12618
12619 2019-01-10  Tom Tromey  <tom@tromey.com>
12620
12621         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12622         (basic_inf_threads_range): Remove.
12623         (inf_threads_range, inf_non_exited_threads_range)
12624         (safe_inf_threads_range): Use next_adapter.
12625
12626 2019-01-10  Keith Seitz  <keiths@redhat.com>
12627
12628         PR gdb/23712
12629         PR symtab/23010
12630         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12631         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12632
12633 2019-01-10  Keith Seitz  <keiths@redhat.com>
12634
12635         PR gdb/23712
12636         PR symtab/23010
12637         * dictionary.c (pending_to_vector): Remove.
12638         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12639         Remove _1 suffix, replacing functions of the same name.  Update
12640         all callers.
12641         (dict_create_hashed, dict_create_hashed_expandable)
12642         (dict_create_linear, dict_create_linear_expandable, dict_free)
12643         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12644         Make functions static.
12645
12646 2019-01-10  Keith Seitz  <keiths@redhat.com>
12647
12648         PR gdb/23712
12649         PR symtab/23010
12650         * dictionary.h (struct dictionary): Replace declaration with
12651         multidictionary.
12652         (dict_create_hashed, dict_create_hashed_expandable)
12653         (dict_create_linear, dict_create_linear_expandable)
12654         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
12655         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
12656         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
12657         taking multidictionary argument.
12658         [ALL_DICT_SYMBOLS]: Update for multidictionary.
12659         * block.h (struct block) <dict>: Change to multidictionary
12660         and rename `multidict'.
12661         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
12662         symmisc.c: Update all dictionary references to multidictionary.
12663
12664 2019-01-10  Keith Seitz  <keiths@redhat.com>
12665
12666         PR gdb/23712
12667         PR symtab/23010
12668         * dictionary.c: Include unordered_map.
12669         (pending_to_vector): New function.
12670         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12671         Rewrite the non-"_1" functions to take vector instead
12672         of linked list.
12673         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
12674         "new" _1 versions of the same name.
12675         (multidictionary): Define.
12676         (std::hash<enum language): New definition.
12677         (collate_pending_symbols_by_language, mdict_create_hashed)
12678         (mdict_create_hashed_expandable, mdict_create_linear)
12679         (mdict_create_linear_expandable, mdict_free)
12680         (find_language_dictionary, create_new_language_dictionary)
12681         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
12682         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
12683         (mdict_size, mdict_empty): New functions.
12684         * dictionary.h (mdict_iterator): Define.
12685
12686 2019-01-10  Pedro Alves  <palves@redhat.com>
12687
12688         * breakpoint.c (read_uploaded_action)
12689         (create_tracepoint_from_upload): Adjust to use
12690         gdb::unique_xmalloc_ptr.
12691         * ctf.c (ctf_write_uploaded_tp):
12692         (SET_ARRAY_FIELD): Use emplace_back.
12693         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
12694         * tracefile-tfile.c (tfile_write_uploaded_tp):
12695         * tracepoint.c (parse_tracepoint_definition): Adjust to use
12696         gdb::unique_xmalloc_ptr.
12697         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
12698         at_string, cond_string, cmd_strings>: Replace char pointers
12699         with gdb::unique_xmalloc_ptr.
12700
12701 2019-01-10  Pedro Alves  <palves@redhat.com>
12702
12703         * solib-target.c (library_list_start_library): Don't xstrdup name.
12704
12705 2019-01-10  Pedro Alves  <palves@redhat.com>
12706
12707         * mdebugread.c (parse_partial_symbols): Use
12708         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
12709
12710 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12711
12712         * linux-fork.c (scoped_switch_fork_info)
12713         <~scoped_switch_fork_info>: Fix incorrect variable name.
12714
12715 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
12716
12717         * linux-fork.c (scoped_switch_fork_info)
12718         <scoped_switch_fork_info>: Make explicit.
12719         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
12720
12721 2019-01-10  Tom Tromey  <tom@tromey.com>
12722
12723         * objfiles.h (objfile::reset_psymtabs): Update.
12724         * objfiles.c (objfile::objfile): Update.
12725         * psymtab.h (psymtab_storage::obstack): Update.
12726         (psymtab_storage::m_obstack): Use gdb::optional.
12727         (class psymtab_storage): Update comment.  Remove objfile
12728         parameter.
12729         * psymtab.c (psymtab_storage::psymtab_storage): Update.
12730
12731 2019-01-10  Tom Tromey  <tom@tromey.com>
12732
12733         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
12734         <free_psymtabs>: Now private.
12735         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
12736         (allocate_psymtab): Use new method.
12737
12738 2019-01-10  Tom Tromey  <tom@tromey.com>
12739
12740         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
12741         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
12742         * mdebugread.c (parse_partial_symbols): Use
12743         allocate_dependencies.
12744         * dwarf2read.c (dwarf2_create_include_psymtab): Use
12745         allocate_dependencies.
12746         (process_psymtab_comp_unit_reader)
12747         (build_type_psymtab_dependencies): Likewise.
12748         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
12749
12750 2019-01-10  Tom Tromey  <tom@tromey.com>
12751
12752         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
12753         PSYMBOL_SET_LANGUAGE.
12754         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
12755
12756 2019-01-10  Tom Tromey  <tom@tromey.com>
12757
12758         * psymtab.h (psymtab_storage::obstack): New method.
12759         <m_obstack>: Rename from obstack; now private.
12760         * psymtab.c (psymtab_storage): Update.
12761         * dwarf2read.c (create_addrmap_from_index)
12762         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
12763         Update.
12764
12765 2019-01-10  Tom Tromey  <tom@tromey.com>
12766
12767         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
12768         * objfiles.h (objfile::reset_psymtabs): New method.
12769
12770 2019-01-10  Tom Tromey  <tom@tromey.com>
12771
12772         * symmisc.c (print_symbol_bcache_statistics): Update.
12773         (print_objfile_statistics): Update.
12774         * symfile.c (reread_symbols): Update.
12775         * psymtab.h (class psymtab_storage): New.
12776         * psymtab.c (psymtab_storage): New constructor.
12777         (~psymtab_storage): New destructor.
12778         (require_partial_symbols): Update.
12779         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
12780         (find_pc_sect_psymtab, find_pc_sect_psymbol)
12781         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
12782         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
12783         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
12784         (start_psymtab_common, end_psymtab_common)
12785         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
12786         (allocate_psymtab): Update.
12787         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
12788         Update.
12789         (dump_psymtab_addrmap, maintenance_print_psymbols)
12790         (maintenance_check_psymtabs): Update.
12791         (class objfile_psymtabs): Move to objfiles.h.
12792         * psympriv.h (discard_psymtab): Now inline.
12793         (psymtab_discarder::psymtab_discarder): Update.
12794         (psymtab_discarder::~psymtab_discarder): Update.
12795         (ALL_OBJFILE_PSYMTABS): Rewrite.
12796         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
12797         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
12798         Remove fields.
12799         <partial_symtabs>: New field.
12800         (class objfile_psymtabs): Move from psymtab.h.  Update.
12801         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
12802         psymbol_cache.
12803         (objfile::~objfile): Don't destroy psymbol_cache.
12804         * mdebugread.c (parse_partial_symbols): Update.
12805         * dwarf2read.c (create_addrmap_from_index)
12806         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
12807         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
12808         (add_partial_subprogram, dwarf2_ranges_read): Update.
12809         * dwarf-index-write.c (write_address_map)
12810         (write_one_signatured_type, recursively_write_psymbols)
12811         (class debug_names, class debug_names, write_psymtabs_to_index):
12812         Update.
12813
12814 2019-01-10  Tom Tromey  <tom@tromey.com>
12815
12816         * symtab.h (SYMBOL_SET_NAMES): Update.
12817         (symbol_set_names): Update.
12818         (MSYMBOL_SET_NAMES): Update.
12819         * symtab.c (symbol_set_names): Change argument to be an
12820         objfile_per_bfd_storage.
12821         * psymtab.c (add_psymbol_to_bcache): Update.
12822         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
12823
12824 2019-01-10  Tom Tromey  <tom@tromey.com>
12825
12826         * symtab.c (create_demangled_names_hash): Change argument to be an
12827         objfile_per_bfd_storage.
12828         (symbol_set_names): Update.
12829
12830 2019-01-10  Tom Tromey  <tom@tromey.com>
12831
12832         * xcoffread.c (xcoff_initial_scan): Unconditionally call
12833         init_psymbol_list.
12834         * psymtab.c (init_psymbol_list): Do nothing if already called.
12835         * psympriv.h (init_psymbol_list): Add comment.
12836         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
12837         init_psymbol_list.
12838         * dbxread.c (dbx_symfile_read): Unconditionally call
12839         init_psymbol_list.
12840
12841 2019-01-10  Tom Tromey  <tom@tromey.com>
12842
12843         * xcoffread.c (scan_xcoff_symtab): Update.
12844         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
12845         "where".
12846         * mdebugread.c (parse_partial_symbols)
12847         (handle_psymbol_enumerators): Update.
12848         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
12849         * dbxread.c (read_dbx_symtab): Update.
12850         * psympriv.h (psymbol_placement): New enum.
12851         (add_psymbol_to_list): Update.
12852
12853 2019-01-10  Tom Tromey  <tom@tromey.com>
12854
12855         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
12856         static_psymbols parameters.
12857         (scan_xcoff_symtab): Update.
12858         * psymtab.c (start_psymtab_common): Remove global_psymbols and
12859         static_psymbols parameters.
12860         * psympriv.h (start_psymtab_common): Update.
12861         * mdebugread.c (parse_partial_symbols): Update.
12862         * dwarf2read.c (create_partial_symtab): Update.
12863         * dbxread.c (read_dbx_symtab): Update.
12864         (start_psymtab): Remove global_psymbols and static_psymbols
12865         parameters.
12866
12867 2019-01-10  Tom Tromey  <tom@tromey.com>
12868
12869         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
12870         * psymtab.c (allocate_psymtab): Add comment.
12871         * psympriv.h (allocate_psymtab): Add comment.
12872         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
12873         initializations.
12874         * dbxread.c (dbx_end_psymtab): Remove some initializations.
12875
12876 2019-01-10  Tom Tromey  <tom@tromey.com>
12877
12878         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12879         Don't declare.
12880         * mipsread.c: Include mdebugread.h.
12881         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
12882         Declare.
12883         * elfread.c: Include mdebugread.h.
12884
12885 2019-01-09  Tom Tromey  <tom@tromey.com>
12886
12887         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
12888         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
12889         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
12890         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
12891         (psym_lookup_symbol, psym_find_last_source_symtab)
12892         (psym_forget_cached_source_info, psym_print_stats)
12893         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
12894         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
12895         (psym_map_matching_symbols, psym_expand_symtabs_matching)
12896         (psym_find_compunit_symtab_by_address)
12897         (maintenance_print_psymbols, maintenance_info_psymtabs)
12898         (maintenance_check_psymtabs): Use ranged for.
12899         * psymtab.h (class objfile_psymtabs): New.
12900         (require_partial_symbols): Return objfile_psymtabs.
12901         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
12902
12903 2019-01-09  Tom Tromey  <tom@tromey.com>
12904
12905         * symfile.c (overlay_invalidate_all, find_pc_overlay)
12906         (find_pc_mapped_section, list_overlays_command)
12907         (map_overlay_command, unmap_overlay_command)
12908         (simple_overlay_update): Use all_objfiles.
12909         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
12910         * printcmd.c (info_symbol_command): Use all_objfiles.
12911         * objfiles.h (ALL_OBJSECTIONS): Remove.
12912         * maint.c (maintenance_translate_address): Use all_objfiles.
12913         * gcore.c (gcore_create_callback): Use all_objfiles.
12914         (objfile_find_memory_regions): Likewise.
12915
12916 2019-01-09  Tom Tromey  <tom@tromey.com>
12917
12918         * symtab.c (find_line_symtab, info_sources_command)
12919         (make_source_files_completion_list): Use objfile_compunits.
12920         * source.c (select_source_symtab): Use objfile_compunits.
12921         * objfiles.h (struct objfile): Update comment.
12922         (ALL_OBJFILES): Remove.
12923         (ALL_FILETABS): Remove.
12924         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
12925         objfile_compunits.
12926
12927 2019-01-09  Tom Tromey  <tom@tromey.com>
12928
12929         * symmisc.c (print_objfile_statistics, dump_objfile)
12930         (maintenance_print_symbols): Use compunit_filetabs.
12931         * source.c (forget_cached_source_info_for_objfile): Use
12932         compunit_filetabs.
12933         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
12934         (ALL_FILETABS): Use compunit_filetabs.
12935         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
12936         * coffread.c (coff_symtab_read): Use compunit_filetabs.
12937
12938 2019-01-09  Tom Tromey  <tom@tromey.com>
12939
12940         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
12941         (compunit_filetabs): New.
12942         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
12943         compunit_filetabs.
12944         (info_sources_command, make_source_files_completion_list): Remove
12945         declaration.
12946         * symmisc.c (print_objfile_statistics, dump_objfile)
12947         (maintenance_print_symbols): Remove declaration.
12948         (maintenance_info_symtabs): Use compunit_filetabs.
12949         (maintenance_info_line_tables): Likewise.
12950         * source.c (select_source_symtab): Change local variable name.
12951         (forget_cached_source_info_for_objfile): Remove declaration.
12952         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
12953         * objfiles.c (objfile_relocate1): Remove declaration.
12954         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12955         declaration.
12956         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
12957         * coffread.c (coff_symtab_read): Remove declaration.
12958         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
12959         compunit_filetabs.
12960
12961 2019-01-09  Tom Tromey  <tom@tromey.com>
12962
12963         * symtab.c (lookup_objfile_from_block)
12964         (find_pc_sect_compunit_symtab, search_symbols)
12965         (default_collect_symbol_completion_matches_break_on): Use
12966         objfile_compunits.
12967         * objfiles.h (ALL_COMPUNITS): Remove.
12968         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
12969         * cp-support.c (add_symbol_overload_list_qualified): Use
12970         objfile_compunits.
12971         * ada-lang.c (ada_collect_symbol_completion_matches)
12972         (ada_add_global_exceptions): Use objfile_compunits.
12973
12974 2019-01-09  Tom Tromey  <tom@tromey.com>
12975
12976         * source.c (select_source_symtab)
12977         (forget_cached_source_info_for_objfile): Remove declaration.
12978         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
12979         declaration.
12980         * maint.c (count_symtabs_and_blocks): Remove declaration.
12981         * cp-support.c (add_symbol_overload_list_qualified): Remove
12982         declaration.
12983         * coffread.c (coff_symtab_read): Remove declaration.
12984         * symtab.c (lookup_symbol_in_objfile_symtabs)
12985         (basic_lookup_transparent_type_1): Use objfile_compunits.
12986         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
12987         (info_sources_command, search_symbols)
12988         (default_collect_symbol_completion_matches_break_on)
12989         (make_source_files_completion_list): Remove declaration.
12990         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
12991         (ada_collect_symbol_completion_matches)
12992         (ada_add_global_exceptions): Remove declaration.
12993         * linespec.c (iterate_over_all_matching_symtabs): Use
12994         objfile_compunits.
12995         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
12996         (class objfile_compunits): New.
12997         (ALL_COMPUNITS): Use objfile_compunits.
12998         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
12999         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13000         objfile_compunits.
13001         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13002
13003 2019-01-09  Tom Tromey  <tom@tromey.com>
13004
13005         * symtab.c (search_symbols)
13006         (default_collect_symbol_completion_matches_break_on): Use
13007         objfile_msymbols.
13008         * ada-lang.c (ada_lookup_simple_minsym)
13009         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13010         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13011         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13012         objfile_msymbols.
13013         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13014         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13015         * objc-lang.c (find_methods): Use objfile_msymbols.
13016         (info_selectors_command, info_classes_command): Likewise.
13017         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13018         * objfiles.h (class objfile_msymbols): New.
13019         (ALL_OBJFILE_MSYMBOLS): Remove.
13020         (ALL_MSYMBOLS): Remove.
13021
13022 2019-01-09  Tom Tromey  <tom@tromey.com>
13023
13024         * common/next-iterator.h (next_adapter): Add Iterator template
13025         parameter.
13026         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13027         (class all_objfiles_safe): New.
13028         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13029         * objfiles.c (put_objfile_before): Update comment.
13030         (add_separate_debug_objfile): Likewise.
13031         (free_all_objfiles): Use all_objfiles_safe.
13032         (objfile_purge_solibs): Likewise.
13033
13034 2019-01-09  Tom Tromey  <tom@tromey.com>
13035
13036         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13037         (expand_symtab_containing_pc, lookup_static_symbol)
13038         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13039         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13040         all_objfiles.
13041         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13042         * breakpoint.c (create_overlay_event_breakpoint)
13043         (create_longjmp_master_breakpoint)
13044         (create_std_terminate_master_breakpoint)
13045         (create_exception_master_breakpoint): Use all_objfiles.
13046         * linux-thread-db.c (try_thread_db_load_from_pdir)
13047         (has_libpthread): Use all_objfiles.
13048         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13049         * linespec.c (iterate_over_all_matching_symtabs)
13050         (search_minsyms_for_name): Use all_objfiles.
13051         * maint.c (maintenance_info_sections): Use all_objfiles.
13052         * main.c (captured_main_1): Use all_objfiles.
13053         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13054         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13055         * guile/scm-pretty-print.c
13056         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13057         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13058         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13059         (maintenance_print_msymbols): Use all_objfiles.
13060         * source.c (select_source_symtab): Use all_objfiles.
13061         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13062         * symfile.c (remove_symbol_file_command)
13063         (expand_symtabs_matching, map_symbol_filenames): Use
13064         all_objfiles.
13065         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13066         all_objfiles.
13067         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13068         * objc-lang.c (find_methods): Use all_objfiles.
13069         * objfiles.c (have_partial_symbols, have_full_symbols)
13070         (have_minimal_symbols, qsort_cmp)
13071         (default_iterate_over_objfiles_in_search_order): Use
13072         all_objfiles.
13073         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13074         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13075         (maintenance_check_psymtabs): Use all_objfiles.
13076         (ALL_PSYMTABS): Remove.
13077         * compile/compile-object-run.c (do_module_cleanup): Use
13078         all_objfiles.
13079         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13080         * cp-support.c (add_symbol_overload_list_qualified): Use
13081         all_objfiles.
13082         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13083         Use all_objfiles.
13084         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13085         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13086         all_objfiles.
13087         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13088         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13089         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13090         Uses all_objfiles.
13091         * solib.c (solib_read_symbols): Use all_objfiles
13092
13093 2019-01-09  Tom Tromey  <tom@tromey.com>
13094
13095         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13096         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13097         all_objfiles.
13098         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13099         * symmisc.c (print_symbol_bcache_statistics)
13100         (print_objfile_statistics, maintenance_print_objfiles)
13101         (maintenance_info_symtabs, maintenance_check_symtabs)
13102         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13103         all_objfiles.
13104         * source.c (forget_cached_source_info): Use all_objfiles.
13105         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13106         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13107         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13108         * objfiles.c (update_section_map): Use all_objfiles.
13109         (shared_objfile_contains_address_p): Likewise.
13110         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13111         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13112
13113 2019-01-09  Tom Tromey  <tom@tromey.com>
13114
13115         * common/next-iterator.h: New file.
13116         * objfiles.h (class all_objfiles): New.
13117         (struct objfile_iterator): New.
13118
13119 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13120
13121         * NEWS: Move the description of the changed "frame", "select-frame",
13122          and "info frame" commands to the Changed commands section.
13123
13124 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13125
13126         * gdbtypes.c (check_stub_method_group): Remove handling of old
13127         mangling schemes.
13128         * linespec.c (find_methods): Likewise.
13129         * stabsread.c (read_member_functions): Likewise.
13130         * valops.c (search_struct_method): Likewise.
13131         (value_struct_elt_for_reference): Likewise.
13132         * NEWS: Mention this change.
13133
13134 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13135
13136         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13137         print_source_lines.
13138         * source.c (print_source_lines_base): Update line number check.
13139         (print_source_lines): New function.
13140         (source_lines_range::source_lines_range): New function.
13141         * source.h (class source_lines_range): New class.
13142         (print_source_lines): New declaration.
13143
13144 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13145
13146         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13147
13148 2019-01-08  Tom Tromey  <tom@tromey.com>
13149             Simon Marchi  <simon.marchi@ericsson.com>
13150
13151         PR gdb/24060
13152         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13153         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13154         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13155         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13156         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13157         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13158
13159 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13160
13161         * source.c (select_source_symtab): Move header comment to
13162         declaration in source.h.
13163         (forget_cached_source_info_for_objfile): Likewise.
13164         (forget_cached_source_info): Likewise.
13165         (identify_source_line): Likewise.
13166         * source.h (identify_source_line): Move declaration from symtab.h
13167         and add comment from source.c
13168         (print_source_lines): Likewise.
13169         (forget_cached_source_info_for_objfile): Likewise.
13170         (forget_cached_source_info): Likewise.
13171         (select_source_symtab): Likewise.
13172         (enum print_source_lines_flag): Move definition from symtab.h.
13173         * symtab.h (identify_source_line): Move declaration to source.h.
13174         (print_source_lines): Likewise.
13175         (forget_cached_source_info_for_objfile): Likewise.
13176         (forget_cached_source_info): Likewise.
13177         (select_source_symtab): Likewise.
13178         (enum print_source_lines_flag): Move definition to source.h.
13179         * tui/tui-hooks.c: Add 'source.h' include.
13180
13181 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13182
13183         * source.c (print_source_lines_base): Handle requests to print
13184         reverse line number sequences, and guard against empty lines
13185         string.
13186
13187 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13188
13189         * source.c (print_source_lines_base): Fix skip of '\r' if next
13190         character is '\n'.
13191
13192 2019-01-06  Tom Tromey  <tom@tromey.com>
13193
13194         * c-exp.y (struct c_parse_state) <macro_original_text,
13195         expansion_obstack>: New member.
13196         (macro_original_text, expansion_obstack): Remove globals.
13197         (scan_macro_expansion, scanning_macro_expansion)
13198         (finished_macro_expansion): Update.
13199         (scan_macro_cleanup): Remove.
13200         (yylex, c_parse): Update.
13201
13202 2019-01-06  Tom Tromey  <tom@tromey.com>
13203
13204         * c-exp.y (struct c_parse_state) <strings>: New member.
13205         (operator_stoken): Update.
13206
13207 2019-01-06  Tom Tromey  <tom@tromey.com>
13208
13209         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13210         (union type_stack_elt) <typelist_val>: Now a pointer to
13211         std::vector.
13212         (type_stack_cleanup): Don't declare.
13213         (push_typelist): Update.
13214         * parse.c (pop_typelist): Return a std::vector.
13215         (push_typelist): Take a std::vector.
13216         (follow_types): Update.  Do not free args.
13217         (type_stack_cleanup): Remove.
13218         * c-exp.y (struct c_parse_state): New.
13219         (cpstate): New global.
13220         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13221         (nonempty_typelist): Update.
13222         (func_mod): Create a new vector.
13223         (c_parse): Create a c_parse_state.
13224         (check_parameter_typelist): Do not delete params.
13225         (function_method): Update.  Do not delete type_list.
13226
13227 2019-01-06  Tom Tromey  <tom@tromey.com>
13228
13229         PR gdb/28155:
13230         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13231         check_typedef.
13232         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13233         (print_return_value): Likewise.
13234
13235 2019-01-05  Tom Tromey  <tom@tromey.com>
13236
13237         * contrib/cleanup_check.py: Remove.
13238         * contrib/gcc-with-excheck: Remove.
13239         * contrib/exsummary.py: Remove.
13240         * contrib/excheck.py: Remove.
13241
13242 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13243
13244         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13245         NULL. Initialize tpprev to NULL instead of assigning it
13246         to NULL on the next statement.
13247         * windows-nat.c (windows_delete_thread): Remove check for
13248         main_thread_id before printing thread exit notifications.
13249         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13250         Remove thread ID check against main_thread_id.
13251         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13252         windows_delete_thread.
13253         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13254
13255 2019-01-04  Tom Tromey  <tom@tromey.com>
13256
13257         * compile/compile.c (_initialize_compile): Use upper case for
13258         metasyntactic variables.
13259         * symmisc.c (_initialize_symmisc): Use upper case for
13260         metasyntactic variables.
13261         * psymtab.c (_initialize_psymtab): Use upper case for
13262         metasyntactic variables.
13263         * demangle.c (demangle_command): Use upper case for metasyntactic
13264         variables.
13265         (_initialize_demangler): Likewise.
13266         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13267         variables.
13268
13269 2019-01-03  Tom Tromey  <tom@tromey.com>
13270
13271         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13272
13273 2019-01-03  Tom Tromey  <tom@tromey.com>
13274
13275         * python/py-symtab.c (salpy_str): Update.
13276         (struct salpy_sal_object) <symtab>: Now a PyObject.
13277         (salpy_dealloc): Update.
13278         (del_objfile_sal): Use gdbpy_ref.
13279
13280 2019-01-03  Tom Tromey  <tom@tromey.com>
13281
13282         * python/py-type.c (convert_field): Use new_reference.  Return
13283         gdbpy_ref.
13284         (make_fielditem): Return gdbpy_ref.
13285         (typy_fields): Update.
13286         (typy_getitem): Update.
13287         (field_name): Return gdbpy_ref.  Use new_reference.
13288         (typy_iterator_iternext): Update.
13289
13290 2019-01-03  Tom Tromey  <tom@tromey.com>
13291
13292         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13293
13294 2019-01-03  Tom Tromey  <tom@tromey.com>
13295
13296         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13297         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13298         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13299         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13300         (pspy_set_type_printers): Likewise.
13301         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13302         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13303         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13304         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13305         (objfpy_set_type_printers): Likewise.
13306
13307 2019-01-03  Tom Tromey  <tom@tromey.com>
13308
13309         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13310         (gdbpy_print_stack): Use gdbpy_err_fetch.
13311         * python/python-internal.h (class gdbpy_err_fetch): New class.
13312         (class gdbpy_enter) <m_error_type, m_error_value,
13313         m_error_traceback>: Remove.
13314         <m_error>: New member.
13315         (gdbpy_exception_to_string): Don't declare.
13316         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13317         * python/py-value.c (convert_value_from_python): Use
13318         gdbpy_err_fetch.
13319         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13320         gdbpy_exception_to_string.
13321         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13322         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13323         gdbpy_err_fetch.
13324
13325 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13326
13327         * linux-nat.c (delete_lwp_cleanup): Delete.
13328         (struct lwp_deleter): New struct.
13329         (lwp_info_up): New typedef.
13330         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13331         lwp_info_up.
13332
13333 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13334
13335         * linux-fork.c (class scoped_switch_fork_info): New class.
13336         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13337
13338 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13339
13340         * valops.c (find_overload_match): Remove use of null_cleanup, and
13341         calls to do_cleanups.
13342
13343 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13344
13345         * compile/compile-cplus-types.c
13346         (compile_cplus_instance::decl_name): Handle changes to
13347         cp_func_name.
13348         * cp-support.c (cp_func_name): Update header comment, update
13349         return type.
13350         * cp-support.h (cp_func_name): Update return type in declaration.
13351         * valops.c (find_overload_match): Move temp_func local to top
13352         level of function and change its type.  Use temp_func to hold and
13353         delete temporary string obtained from cp_func_name.
13354
13355 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13356
13357         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13358         gdb::char_vector, remove cleanup, and update uses of `msg`.
13359
13360 2019-01-03  Jim Wilson  <jimw@sifive.com>
13361
13362         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13363
13364 2019-01-02  Tom Tromey  <tom@tromey.com>
13365
13366         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13367         (tdesc_parse_xml): Remove cleanups.
13368         * target-descriptions.h (make_cleanup_free_target_description):
13369         Don't declare.
13370         (target_desc_deleter): New struct.
13371         (target_desc_up): New typedef.
13372         * target-descriptions.c (target_desc_deleter::operator()): Rename
13373         from free_target_description.
13374         (make_cleanup_free_target_description): Remove.
13375
13376 2019-01-02  Tom Tromey  <tom@tromey.com>
13377
13378         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13379         constructor, destructor.
13380         (linespec_parser): Remove typedef.
13381         (~linespec_parser): Rename from linespec_parser_delete.
13382         (linespec_lex_to_end, linespec_complete_label)
13383         (linespec_complete): Update.
13384         (decode_line_full): Remove cleanups.
13385         (decode_line_1): Update.
13386
13387 2019-01-02  Tom Tromey  <tom@tromey.com>
13388
13389         * python/python-internal.h (inferior_to_inferior_object): Change
13390         return type.
13391         * python/py-exitedevent.c (create_exited_event_object): Update.
13392         * python/py-inferior.c (inferior_to_inferior_object): Return
13393         gdbpy_ref.
13394         (python_new_inferior, python_inferior_deleted)
13395         (thread_to_thread_object, delete_thread_object)
13396         (build_inferior_list, gdbpy_selected_inferior): Update.
13397         * python/py-infthread.c (create_thread_object): Update.  Also fail
13398         if inferior_to_inferior_object fails.
13399
13400 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13401
13402         * inferior.h (class inferior) <displaced_step_state>: New field.
13403         * infrun.h (struct displaced_step_state): Move here from
13404         infrun.c.  Initialize fields, add constructor.
13405         <inf>: Remove field.
13406         <reset>: New method.
13407         * infrun.c (struct displaced_step_inferior_state): Move to
13408         infrun.h.
13409         (displaced_step_inferior_states): Remove.
13410         (get_displaced_stepping_state): Adust.
13411         (displaced_step_in_progress_any_inferior): Adjust.
13412         (displaced_step_in_progress_thread): Adjust.
13413         (displaced_step_in_progress): Adjust.
13414         (add_displaced_stepping_state): Remove.
13415         (get_displaced_step_closure_by_addr): Adjust.
13416         (remove_displaced_stepping_state): Remove.
13417         (infrun_inferior_exit): Call displaced_step_state.reset.
13418         (use_displaced_stepping): Don't check for NULL.
13419         (displaced_step_prepare_throw): Call
13420         get_displaced_stepping_state.
13421         (displaced_step_fixup): Don't check for NULL.
13422         (prepare_for_detach): Don't check for NULL.
13423
13424 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13425
13426         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13427          in case of call that did not complete.
13428
13429 2019-01-02  Andrey Utkin  <autkin@undo.io>
13430
13431         * symfile.c (find_separate_debug_file): Fix search of debug files for
13432         remote debuggee.
13433
13434 2019-01-02  Tom Tromey  <tom@tromey.com>
13435
13436         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13437         indentation.
13438         * python/py-frame.c (frapy_older): Remove cast.
13439         (frapy_newer): Likewise.
13440         * python/py-breakpoint.c (local_setattro): Remove cast.
13441         * python/py-arch.c (archpy_name): Remove local variable.
13442         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13443
13444 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13445
13446         * unittests/basic_string_view/element_access/char/empty.cc:
13447         Fix year range in copyright header.
13448
13449 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13450
13451         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13452         Delete.
13453         <operator==>: Update with for removed field.
13454         <hash>: Likewise.
13455         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13456         <isa_features>: ...this.
13457         <abi_features>: New field.
13458         (riscv_isa_flen): Update comment.
13459         (riscv_abi_xlen): New declaration.
13460         (riscv_abi_flen): New declaration.
13461         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13462         isa_features.
13463         (riscv_abi_xlen): New function.
13464         (riscv_isa_flen): Update to get answer from isa_features.
13465         (riscv_abi_flen): New function.
13466         (riscv_has_fp_abi): Update to get answer from abi_features.
13467         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13468         xlen and flen.
13469         (riscv_call_info) <xlen, flen>: Update comment.
13470         (riscv_call_arg_struct): Remove invalid assertions
13471         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13472         is removed.
13473         (riscv_gdbarch_init): Gather isa features and abi features
13474         separately, ensure both match on the gdbarch when reusing an old
13475         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13476         a target with 64-bit float hardware.
13477
13478 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13479
13480         * source.c (search_command_helper): Stop reverse search
13481         when line 1 has been searched.
13482
13483 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13484
13485         * record-full.c (record_full_base_target::close): Rewrite
13486         record_full_core_buf_list free logic.
13487
13488 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13489
13490         * break-catch-syscall.c (print_one_catch_syscall): xfree
13491         the last text.
13492
13493 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13494
13495         * top.c (print_gdb_version): Update Copyright year in version
13496         message.
13497
13498 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13499
13500         Update copyright year range in all GDB files.
13501
13502 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13503
13504         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13505
13506 For older changes see ChangeLog-2018.
13507 \f
13508 Local Variables:
13509 mode: change-log
13510 left-margin: 8
13511 fill-column: 74
13512 version-control: never
13513 coding: utf-8
13514 End:
13515