gdb/ChangeLog

   1 2019-06-25  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
   4         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
   5
   6 2019-06-25  Tom Tromey  <tom@tromey.com>
   7
   8         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
   9         check.
  10
  11 2019-06-25  Tom Tromey  <tom@tromey.com>
  12
  13         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
  14         type to void.
  15         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
  16         type to void.
  17         * tui/tui-source.c (tui_set_source_content): Update.
  18         * tui/tui-disasm.c (tui_set_disassem_content): Update.
  19
  20 2019-06-25  Tom Tromey  <tom@tromey.com>
  21
  22         * tui/tui-win.c (window_name_completer, tui_set_focus)
  23         (tui_all_windows_info): Use name method.
  24         * tui/tui-data.h (struct tui_gen_win_info)
  25         (struct tui_source_window, struct tui_disasm_window)
  26         (struct tui_data_window, struct tui_cmd_window) <name>: New
  27         method.
  28         (tui_win_name): Don't declare.
  29         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
  30         (tui_win_name): Remove.
  31
  32 2019-06-25  Tom Tromey  <tom@tromey.com>
  33
  34         * tui/tui-winsource.h (tui_update_source_window)
  35         (tui_update_source_window_as_is): Change parameter type.
  36         * tui/tui-winsource.c (tui_update_source_window): Change win_info
  37         to be a tui_source_window_base.
  38         (tui_update_source_window_as_is): Likewise.
  39         * tui/tui-win.c (make_visible_with_new_height): Update.
  40
  41 2019-06-25  Tom Tromey  <tom@tromey.com>
  42
  43         * tui/tui-winsource.c (tui_erase_source_content)
  44         (tui_show_source_content, tui_show_exec_info_content)
  45         (tui_erase_exec_info_content): Use refresh_window method.
  46         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
  47         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
  48         from tui_refresh_win.
  49         (tui_data_window::refresh_window): New method.
  50         (tui_win_info::refresh, tui_source_window_base::refresh)
  51         (tui_refresh_all): Use refresh_window method.
  52         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
  53         method.
  54         * tui/tui-regs.c (tui_display_register): Call refresh_window
  55         method.
  56         * tui/tui-layout.c (show_source_disasm_command)
  57         (show_source_or_disasm_and_command): Call refresh_window method.
  58         * tui/tui-data.h (struct tui_gen_win_info)
  59         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
  60         New method.
  61
  62 2019-06-25  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui.c (tui_rl_other_window, tui_enable)
  65         (tui_is_window_visible, tui_get_command_dimension): Update.
  66         * tui/tui-winsource.c (tui_update_source_window_as_is)
  67         (tui_clear_source_content, tui_erase_source_content)
  68         (tui_show_source_line, tui_source_window_base::refill)
  69         (tui_source_window_base::do_scroll_horizontal)
  70         (tui_source_window_base::set_is_exec_point_at)
  71         (tui_update_breakpoint_info, tui_set_exec_info_content)
  72         (tui_alloc_source_buffer, tui_line_is_displayed)
  73         (tui_addr_is_displayed): Update.
  74         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  75         (tui_check_and_display_highlight_if_needed)
  76         (tui_win_info::make_visible, tui_win_info::refresh)
  77         (tui_refresh_all): Update.
  78         * tui/tui-windata.c (tui_first_data_item_displayed)
  79         (tui_delete_data_content_windows, tui_erase_data_content)
  80         (tui_display_all_data, tui_data_window::refresh_all)
  81         (tui_check_data_values): Update.
  82         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
  83         (tui_set_win_focus_to, tui_win_info::forward_scroll)
  84         (tui_win_info::backward_scroll, tui_refresh_all_win)
  85         (tui_resize_all, tui_set_focus, tui_all_windows_info)
  86         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
  87         (tui_source_window_base::set_new_height)
  88         (tui_data_window::set_new_height)
  89         (make_invisible_and_set_new_height)
  90         (make_visible_with_new_height, new_height_ok)
  91         (parse_scrolling_args): Update.
  92         * tui/tui-stack.c (tui_show_frame_info): Update.
  93         * tui/tui-source.c (tui_set_source_content)
  94         (tui_set_source_content_nil, tui_source_is_displayed)
  95         (tui_source_window::do_scroll_vertical): Update.
  96         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
  97         (tui_display_registers_from, tui_display_reg_element_at_line)
  98         (tui_check_register_values, tui_reg_command): Update.
  99         * tui/tui-layout.c (tui_default_win_height)
 100         (show_source_disasm_command, show_data, init_and_make_win)
 101         (show_source_or_disasm_and_command): Update.
 102         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 103         (tui_redisplay_readline, tui_mld_flush)
 104         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
 105         (tui_getc): Update.
 106         * tui/tui-disasm.c (tui_set_disassem_content)
 107         (tui_disasm_window::do_scroll_vertical): Update.
 108         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
 109         Now virtual.
 110         (struct tui_win_info): Derive from tui_gen_win_info.
 111         <~tui_win_info>: Mark as override.
 112         <generic>: Remove member.
 113         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
 114         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
 115         (~tui_data_window, ~tui_win_info)
 116         (tui_free_all_source_wins_content): Update.
 117         * tui/tui-command.c (tui_refresh_cmd_win): Update.
 118
 119 2019-06-25  Tom Tromey  <tom@tromey.com>
 120
 121         * tui/tui-layout.c (init_and_make_win): Use new.
 122         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
 123         destructor, initializers.
 124         (tui_alloc_generic_win_info): Don't declare.
 125         * tui/tui-data.c (_locator): Add argument to constructor.
 126         (source_win, disasm_win): New globals.
 127         (exec_info): Remove.
 128         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
 129         Update.
 130         (tui_alloc_generic_win_info): Remove.
 131         (init_content_element): Use new.
 132         (tui_win_info::tui_win_info): Update.
 133         (free_content_elements) <case DATA_WIN>: Use delete.
 134
 135 2019-06-25  Tom Tromey  <tom@tromey.com>
 136
 137         * tui/tui-wingeneral.c (tui_refresh_win): Update.
 138         * tui/tui-windata.c (tui_first_data_item_displayed)
 139         (tui_delete_data_content_windows): Update.
 140         * tui/tui-win.c (tui_data_window::set_new_height): Update.
 141         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
 142         (tui_display_registers_from, tui_check_register_values): Update.
 143         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
 144         pointer.
 145         * tui/tui-data.c (init_content_element): Update.  Allocate the new
 146         window.
 147         (tui_free_data_content): Update.
 148         (free_content_elements) <case DATA_WIN>: Free the window.
 149
 150 2019-06-25  Tom Tromey  <tom@tromey.com>
 151
 152         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
 153         Update.
 154         * tui/tui-layout.c (make_command_window)
 155         (show_source_disasm_command, show_data, init_and_make_win)
 156         (show_source_or_disasm_and_command): Update.
 157         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
 158         method.
 159         <can_highight, is_highlighted>: Now bool.
 160         (tui_set_win_highlight): Don't declare.
 161         * tui/tui-data.c (tui_set_win_highlight): Remove.
 162
 163 2019-06-25  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-wingeneral.c (make_visible): Remove check of window
 166         type.
 167
 168 2019-06-25  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-win.c (tui_win_info::max_height)
 171         (tui_cmd_window::max_height): New methods.
 172         (new_height_ok): Call max_height.
 173         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
 174         <max_height>: New method.
 175
 176 2019-06-25  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui-win.c (tui_source_window_base::set_new_height)
 179         (tui_data_window::set_new_height): New methods.
 180         (make_invisible_and_set_new_height): Call set_new_height method.
 181         * tui/tui-data.h (struct tui_win_info)
 182         (struct tui_source_window_base, struct tui_data_window)
 183         <set_new_height>: New method.
 184
 185 2019-06-25  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
 188         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
 189         tui_refresh_data_win.
 190         * tui/tui-win.c (tui_source_window_base::refresh_all): New
 191         method.
 192         (tui_refresh_all_win): Call the refresh_all method.
 193         (tui_set_focus): Likewise.
 194         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
 195         (struct tui_source_window_base, struct tui_data_window) <refresh>:
 196         Likewise.
 197
 198 2019-06-25  Tom Tromey  <tom@tromey.com>
 199
 200         * tui/tui-winsource.h (tui_refill_source_window)
 201         (tui_set_is_exec_point_at): Don't declare.
 202         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 203         (tui_source_window_base::refill): Rename from
 204         tui_refill_source_window.
 205         (tui_source_window_base::do_scroll_horizontal): Update.
 206         (tui_source_window_base::set_is_exec_point_at): Rename from
 207         tui_set_is_exec_point_at.
 208         (tui_update_all_breakpoint_info): Update.
 209         * tui/tui-stack.c (tui_show_frame_info): Update.
 210         * tui/tui-layout.c (show_data): Add cast.
 211         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
 212         * tui/tui-data.h (struct tui_source_window_base) <refill,
 213         set_is_exec_point_at>: New methods.
 214         (tui_source_windows, tui_add_to_source_windows): Update types.
 215         (tui_add_to_source_windows): Remove redundant declaration.
 216         * tui/tui-data.c (source_windows): Store tui_source_window_base.
 217         (tui_source_windows): Change return type.
 218         (tui_clear_source_windows_detail): Update.
 219         (tui_add_to_source_windows): Change type of parameter.
 220         (tui_free_all_source_wins_content): Update.
 221
 222 2019-06-25  Tom Tromey  <tom@tromey.com>
 223
 224         * tui/tui-wingeneral.c (tui_win_info::refresh)
 225         (tui_source_window_base::refresh): New methods.
 226         (tui_refresh_all): Call the refresh method.
 227         * tui/tui-data.h (struct tui_win_info)
 228         (struct tui_source_window_base) <refresh>: New method.
 229
 230 2019-06-25  Tom Tromey  <tom@tromey.com>
 231
 232         * tui/tui.h (tui_is_window_visible): Return bool.
 233         * tui/tui.c (tui_is_window_visible): Return bool.
 234         * tui/tui-wingeneral.c (tui_make_window, make_visible)
 235         (tui_make_visible, tui_make_invisible)
 236         (tui_win_info::make_visible)
 237         (tui_source_window_base::make_visible, make_all_visible)
 238         (tui_make_all_visible, tui_make_all_invisible): Update.
 239         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
 240         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
 241         bool.
 242         (struct tui_win_info, struct tui_source_window_base)
 243         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
 244         * tui/tui-data.c (tui_init_generic_part): Update.
 245
 246 2019-06-25  Tom Tromey  <tom@tromey.com>
 247
 248         * tui/tui-wingeneral.c (tui_win_info::make_visible)
 249         (tui_source_window_base::make_visible): New methods.
 250         (make_all_visible): Make method call.
 251         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
 252         (struct tui_source_window_base, struct tui_cmd_window): Override
 253         make_visible.
 254         (tui_win_is_source_type): Don't declare.
 255         * tui/tui-data.c (tui_win_is_source_type): Remove.
 256
 257 2019-06-25  Tom Tromey  <tom@tromey.com>
 258
 259         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
 260         NULL check.
 261
 262 2019-06-25  Tom Tromey  <tom@tromey.com>
 263
 264         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
 265         Inline constructor.  Add initializers for members.
 266         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
 267         constructors; now inline in class.
 268
 269 2019-06-25  Tom Tromey  <tom@tromey.com>
 270
 271         * tui/tui-regs.c (tui_show_registers): Update.
 272         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
 273         bool.
 274         * tui/tui-data.c (tui_data_window::clear_detail)
 275         (tui_data_window): Update.
 276
 277 2019-06-25  Tom Tromey  <tom@tromey.com>
 278
 279         * tui/tui-windata.c (tui_display_all_data)
 280         (tui_display_data_from_line, tui_display_data_from)
 281         (tui_check_data_values, tui_data_window::do_scroll_vertical):
 282         Update.
 283         * tui/tui-regs.c (tui_last_regs_line_no)
 284         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
 285         (tui_show_registers, tui_show_register_group)
 286         (tui_display_registers_from, tui_display_reg_element_at_line)
 287         (tui_display_registers_from_line, tui_check_register_values)
 288         (tui_reg_next, tui_reg_prev): Update.
 289         * tui/tui-layout.c (tui_set_layout, show_data): Update.
 290         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
 291         tui_data_window.
 292         (struct tui_win_info) <detail>: Remove.  Add new fields from
 293         tui_data_info.
 294         (TUI_DATA_WIN): Add cast.
 295         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
 296         (~tui_data_window): Simplify.
 297
 298 2019-06-25  Tom Tromey  <tom@tromey.com>
 299
 300         * tui/tui-layout.c (show_source_disasm_command)
 301         (show_source_or_disasm_and_command): Update.
 302         * tui/tui-io.c (update_cmdwin_start_line)
 303         (tui_redisplay_readline): Update.
 304         * tui/tui-data.h (struct tui_command_info): Remove.
 305         (struct tui_win_info) <detail>: Remove command_info member.
 306         (struct tui_data_window) <start_line>: New member, from
 307         tui_command_info.
 308         (TUI_CMD_WIN): Add casts.
 309
 310 2019-06-25  Tom Tromey  <tom@tromey.com>
 311
 312         * tui/tui-winsource.c (tui_update_source_window)
 313         (tui_refill_source_window)
 314         (tui_source_window_base::do_scroll_horizontal)
 315         (tui_update_breakpoint_info, tui_set_exec_info_content)
 316         (tui_show_exec_info_content, tui_erase_exec_info_content)
 317         (tui_clear_exec_info_content): Update.
 318         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
 319         Update.
 320         * tui/tui-win.c (make_invisible_and_set_new_height)
 321         (make_visible_with_new_height): Update.
 322         * tui/tui-source.c (tui_set_source_content)
 323         (tui_show_symtab_source): Update.
 324         * tui/tui-layout.c (extract_display_start_addr)
 325         (show_source_disasm_command, show_data)
 326         (make_source_or_disasm_window)
 327         (show_source_or_disasm_and_command): Update.
 328         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
 329         (tui_disasm_window::do_scroll_vertical): Remove shadowing
 330         "gdbarch".
 331         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
 332         to tui_source_window_base.
 333         (struct tui_win_info) <detail>: Remove source_info member.
 334         (struct tui_source_window_base) <has_locator>: Inline.
 335         Move contents from tui_source_info; rename has_locator member to
 336         m_has_locator.
 337         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
 338         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
 339         header file.
 340         (tui_source_window_base::clear_detail, ~tui_source_window_base):
 341         Simplify.
 342         (tui_free_all_source_wins_content): Cast to
 343         tui_source_window_base.
 344
 345 2019-06-25  Tom Tromey  <tom@tromey.com>
 346
 347         * tui/tui-win.c (make_invisible_and_set_new_height)
 348         (make_visible_with_new_height): Call has_locator method.
 349         * tui/tui-layout.c (show_source_disasm_command, show_data)
 350         (show_source_or_disasm_and_command): Update for bool change.
 351         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
 352         (tui_win_info) <has_locator>: New method.
 353         (struct tui_source_window_base) <has_locator>: New method.
 354         (tui_win_has_locator): Don't declare.
 355         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
 356         from tui_win_has_locator.
 357         (tui_source_window_base): Use false, not FALSE.
 358
 359 2019-06-25  Tom Tromey  <tom@tromey.com>
 360
 361         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
 362         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
 363         clear_detail method directly.
 364         (tui_clear_win_detail): Remove.
 365
 366 2019-06-25  Tom Tromey  <tom@tromey.com>
 367
 368         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 369         "this", not TUI_DISASM_WIN.
 370
 371 2019-06-25  Tom Tromey  <tom@tromey.com>
 372
 373         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
 374         declare.
 375         * tui/tui-winsource.c
 376         (tui_source_window_base::do_scroll_horizontal): Rename from
 377         tui_horizontal_source_scroll.
 378         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
 379         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
 380         from tui_vertical_data_scroll.
 381         * tui/tui-win.h (tui_scroll): Don't declare.
 382         * tui/tui-win.c (tui_win_info::forward_scroll)
 383         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
 384         (tui_win_info::right_scroll): Rename and update.
 385         (tui_scroll_forward_command, tui_scroll_backward_command)
 386         (tui_scroll_left_command, tui_scroll_right_command): Update.
 387         (tui_scroll): Remove.
 388         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
 389         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
 390         from tui_vertical_source_scroll.
 391         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
 392         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
 393         from tui_vertical_disassem_scroll.
 394         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
 395         do_scroll_horizontal>: New methods.
 396         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
 397         Likewise.
 398         (struct tui_source_window_base): Add do_scroll_horizontal.
 399         (struct tui_source_window, struct tui_disasm_window): Add
 400         do_scroll_vertical.
 401         (struct tui_data_window, struct tui_cmd_window): Add
 402         do_scroll_horizontal and do_scroll_vertical.
 403         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
 404
 405 2019-06-25  Tom Tromey  <tom@tromey.com>
 406
 407         * tui/tui-data.h (struct tui_source_window_base): New struct.
 408         (struct tui_source_window): Derive from tui_source_window_base.
 409         (struct tui_disasm_window): New struct.
 410         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
 411         from tui_source_window::clear_detail.
 412         (tui_source_window_base): Rename from tui_source_window.
 413         (~tui_source_window_base): Rename from ~tui_source_window.
 414         (tui_alloc_win_info): Create a tui_disasm_window.
 415
 416 2019-06-25  Tom Tromey  <tom@tromey.com>
 417
 418         * tui/tui-data.h (struct tui_source_window)
 419         (struct tui_data_window): Declare destructors.
 420         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
 421         destructors.
 422         (tui_win_info): Simplify.
 423
 424 2019-06-25  Tom Tromey  <tom@tromey.com>
 425
 426         * tui/tui-winsource.c (tui_display_main)
 427         (tui_update_source_windows_with_addr)
 428         (tui_update_all_breakpoint_info): Update.
 429         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
 430         (new_height_ok, parse_scrolling_args): Update.
 431         * tui/tui-stack.c (tui_show_frame_info): Update.
 432         * tui/tui-data.h (struct tui_list): Remove.
 433         (tui_source_windows): Return a reference to a std::vector.
 434         * tui/tui-data.c (source_windows): Now a std::vector.
 435         (tui_source_windows): Change return type.
 436         (tui_clear_source_windows): Rewrite.
 437         (tui_clear_source_windows_detail, tui_add_to_source_windows)
 438         (tui_free_all_source_wins_content): Rewrite.
 439
 440 2019-06-25  Tom Tromey  <tom@tromey.com>
 441
 442         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
 443         (struct tui_data_window, struct tui_cmd_window): Declare
 444         clear_detail method.
 445         * tui/tui-data.c (tui_source_window::clear_detail)
 446         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
 447         methods.
 448         (tui_clear_win_detail): Simplify.
 449
 450 2019-06-25  Tom Tromey  <tom@tromey.com>
 451
 452         * tui/tui-layout.c (make_source_window, make_disasm_window)
 453         (make_source_or_disasm_window): Remove win_info_ptr parameter.
 454         Return the new window.
 455         (show_source_disasm_command, show_data)
 456         (show_source_or_disasm_and_command): Update.
 457
 458 2019-06-25  Tom Tromey  <tom@tromey.com>
 459
 460         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
 461         parameter.  Return the new window.
 462         (show_source_disasm_command): Update and remove NULL check.
 463         (show_source_or_disasm_and_command): Update.
 464
 465 2019-06-25  Tom Tromey  <tom@tromey.com>
 466
 467         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
 468
 469 2019-06-25  Tom Tromey  <tom@tromey.com>
 470
 471         * tui/tui-data.h (struct tui_win_info): Make constructor
 472         protected.  Make destructor virtual.  Add initializers.
 473         (tui_source_window, tui_data_window, tui_cmd_window): New
 474         classes.
 475         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
 476         constructor.  Add "type" parameter.
 477         (tui_source_window, tui_data_window, tui_cmd_window): New
 478         constructors.
 479         (tui_alloc_win_info): Instantiate the appropriate subclass.
 480
 481 2019-06-25  Tom Tromey  <tom@tromey.com>
 482
 483         * tui/tui-win.c (tui_resize_all): Use delete.
 484         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
 485         destructor.
 486         (tui_free_window): Don't declare.
 487         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
 488         Update.
 489
 490 2019-06-25  Tom Tromey  <tom@tromey.com>
 491
 492         * tui/tui-data.h (struct tui_win_info): Add constructor.
 493         * tui/tui-data.c (tui_alloc_win_info): Use new.
 494         (tui_free_window): Use delete.
 495
 496 2019-06-22  Tom Tromey  <tom@tromey.com>
 497
 498         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
 499         declare.
 500         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
 501
 502 2019-06-22  Tom Tromey  <tom@tromey.com>
 503
 504         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
 505         declare.
 506         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
 507
 508 2019-06-22  Tom de Vries  <tdevries@suse.de>
 509
 510         * dwarf2read.c (create_addrmap_from_aranges)
 511         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
 512         instead of '%zu'.
 513
 514 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
 515
 516         * dwarf2read.h (dwarf2_section_info_def): Remove.
 517         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
 518         * dwarf2read.c (struct dwo_sections) <types>: Change type to
 519         std::vector<dwarf2_section_info>.
 520         (struct dwo_file) <~dwo_file>: Remove.
 521         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
 522         types field.
 523         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
 524         (dwarf2_read_debug_names): Likewise.
 525         (create_debug_types_hash_table): Change parameter type to
 526         array_view, adjust code accordingly.
 527         (dwarf2_locate_dwo_sections): Adjust to std::vector.
 528         (partial_die_info::fixup): Likewise.
 529         (determine_prefix): Likewise.
 530         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
 531
 532 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 533
 534         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
 535         gdb_bfd_ref_ptr.
 536         <~dwo_file>: Remove call to gdb_bfd_unref.
 537         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
 538         gdb_bfd_ref_ptr::get.
 539
 540 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 541
 542         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
 543         type to htab_up.
 544         * dwarf2read.c (struct dwo_file): Initialize fields.
 545         <~dwo_file>: New.
 546         (free_dwo_file): Remove, move content to ~dwo_file.
 547         (struct dwo_file_deleter): Remove.
 548         (dwo_file_up>: Remove custom deleter.
 549         (free_dwo_files): Remove.
 550         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
 551         dwo_files.
 552         (process_skeletonless_type_units): Call unique_ptr::get.
 553         (allocate_dwo_file_hash_table): Add deleter to created hash
 554         table.  Change return type to htab_up.
 555         (lookup_dwo_file_slot): Don't memset dwo_file, call
 556         unique_ptr::get.
 557         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
 558         (create_dwo_unit_in_dwp_v2): Likewise.
 559         (open_and_init_dwo_file): Likewise.
 560         (free_dwo_file_from_slot): Remove.
 561
 562 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
 563
 564         * dwarf2read.h (struct dwarf2_section_info) <readin,
 565         is_virtual>: Change type to bool.
 566         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
 567         true instead of 1.
 568
 569 2019-06-19  Tom Tromey  <tom@tromey.com>
 570
 571         * tui/tui-data.h (tui_init_content_element): Don't declare.
 572
 573 2019-06-19  Tom Tromey  <tom@tromey.com>
 574
 575         * tui/tui-data.h (tui_init_win_info): Don't declare.
 576
 577 2019-06-19  Tom de Vries  <tdevries@suse.de>
 578
 579         * dwarf2read.h (abstract_to_concrete): Change type to
 580         std::unordered_map<sect_offset, std::vector<sect_offset>,
 581         gdb::hash_enum<sect_offset>>.
 582
 583 2019-06-19  Tom Tromey  <tromey@adacore.com>
 584
 585         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
 586         EVAL_AVOID_SIDE_EFFECTS specially.
 587
 588 2019-06-19  Tom Tromey  <tromey@adacore.com>
 589
 590         * source-cache.c (highlighter): New global.
 591         (source_cache::get_source_lines): Create a highlighter on demand.
 592
 593 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 594
 595         * defs.h (deprecated_interactive_hook): Delete declaration.
 596         * interps.c (clear_interpreter_hooks): Remove use of
 597         deprecated_interactive_hook.
 598         * top.c (deprecated_interactive_hook): Delete definition.
 599         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
 600
 601 2019-06-18  Tom de Vries  <tdevries@suse.de>
 602
 603         PR gdb/24515
 604         * dwarf2read.h (abstract_to_concrete): Change type from
 605         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
 606         std::unordered_map<sect_offset, std::vector<sect_offset>>.
 607         * dwarf2read.c (read_variable): Update.
 608         (dwarf2_fetch_die_loc_sect_off): Update.
 609
 610 2019-06-17  Tom de Vries  <tdevries@suse.de>
 611
 612         PR gdb/24617
 613         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
 614         accessing parent[parent_len - 1].
 615
 616 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
 617
 618         PR gdb/24364
 619         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
 620         call dtrace_process_dof with NULL dof.
 621
 622 2019-06-16  Tom de Vries  <tdevries@suse.de>
 623
 624         PR gdb/24445
 625         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
 626
 627 2019-06-16  Tom Tromey  <tom@tromey.com>
 628
 629         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
 630         (make_all_visible): Use address of member.
 631
 632 2019-06-16  Tom Tromey  <tom@tromey.com>
 633
 634         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
 635         (tui_free_window, free_content, free_content_elements): Remove
 636         unnecessary cast.
 637         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
 638         cast.
 639         * tui/tui-regs.c (tui_show_register_group)
 640         (tui_display_registers_from, tui_display_reg_element_at_line):
 641         Remove unnecessary cast.
 642
 643 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 644
 645         * linux-nat.c (normal_mask): Delete.
 646         (_initialize_linux_nat): Don't initialise normal_mask.
 647
 648 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 649
 650         PR gdb/24445
 651         * dwarf-index-write.h (write_psymtabs_to_index): Add
 652         dwz_basename parameter.
 653         * dwarf-index-write.c (write_gdbindex): Move file writing to
 654         write_gdbindex_1.  Change return type void.
 655         (assert_file_size): Move up, remove filename parameter.
 656         (write_gdbindex_1): New function.
 657         (write_debug_names): Change return type to void, call
 658         assert_file_size.
 659         (struct index_wip_file): New struct.
 660         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 661         file logic to index_wip_file.  Write index for dwz file if
 662         needed.
 663         (save_gdb_index_command): Pass basename of dwz file, if present.
 664         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 665         build-id of dwz file, if present.
 666         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 667         (dwarf2_get_dwz_file): Likewise.
 668         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 669         (dwarf2_get_dwz_file): Likewise.
 670
 671 2019-06-16  Tom Tromey  <tom@tromey.com>
 672
 673         * coffread.c (process_coff_symbol): Use xstrdup.
 674         * value.c (create_internalvar): Use xstrdup.
 675
 676 2019-06-16  Tom Tromey  <tom@tromey.com>
 677
 678         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 679         * breakpoint.c (stopin_command, stopat_command)
 680         (until_break_command, decode_location_default): Remove unnecessary
 681         cast.
 682         * utils.c (subset_compare): Remove unnecessary cast.
 683         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 684         cast.
 685         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 686         cast.
 687         * infcmd.c (path_command): Remove unnecessary cast.
 688         * coffread.c (decode_type): Remove unnecessary cast.
 689         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 690         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 691         * tui/tui-stack.c (tui_show_locator_content)
 692         (tui_show_frame_info): Remove unnecessary cast.
 693         * tui/tui-win.c (tui_scroll_forward_command)
 694         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 695         (parse_scrolling_args): Remove unnecessary cast.
 696         * tui/tui-data.c (init_win_info, tui_del_window)
 697         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 698         (free_content_elements): Remove unnecessary cast.
 699         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 700         unnecessary cast.
 701         * tui/tui-source.c (tui_set_source_content)
 702         (tui_vertical_source_scroll): Remove unnecessary cast.
 703         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 704         cast.
 705         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 706         * tui/tui-regs.c (tui_display_registers_from)
 707         (tui_display_register): Remove unnecessary cast.
 708         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 709         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 710         (make_visible): Remove unnecessary cast.
 711         * tui/tui-winsource.c (tui_erase_source_content)
 712         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 713         unnecessary cast.
 714         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 715         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 716         * stabsread.c (read_type, read_array_type, read_range_type):
 717         Remove unnecessary cast.
 718         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 719         (parse_symbol, parse_type, upgrade_type, parse_external)
 720         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 721         unnecessary cast.
 722         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 723
 724 2019-06-16  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-data.c (tui_alloc_generic_win_info)
 727         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 728         checks.
 729
 730 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 731             Andrew Burgess  <andrew.burgess@embecosm.com>
 732
 733         * f-typeprint.c (f_print_type): Don't return early for not
 734         associated or not allocated types.
 735         (f_type_print_varspec_suffix): Add print_rank parameter and print
 736         ranks of array types in case they dangling.
 737         (f_type_print_base): Add print_rank parameter.
 738
 739 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 740
 741         * NEWS: Mention new MI commands.
 742         * break-catch-throw.c (enum exception_event_kind): Move to
 743         breakpoint.h.
 744         (print_mention_exception_catchpoint): Output text as a single
 745         message.
 746         (catch_exception_command_1): Rename to...
 747         (catch_exception_event): ...this, make non-static, update header
 748         command, and change some parameter types.
 749         (catch_catch_command): Update for changes to
 750         catch_exception_command_1.
 751         (catch_throw_command): Likewise.
 752         (catch_rethrow_command): Likewise.
 753         * breakpoint.c (enum exception_event_kind): Delete.
 754         * breakpoint.h (enum exception_event_kind): Moved here from
 755         break-catch-throw.c.
 756         (catch_exception_event): Declare.
 757         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 758         (mi_cmd_catch_throw): New function.
 759         (mi_cmd_catch_rethrow): New function.
 760         (mi_cmd_catch_catch): New function.
 761         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 762         'catch-catch' entries.
 763         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 764         (mi_cmd_catch_rethrow): Declare.
 765         (mi_cmd_catch_catch): Declare.
 766
 767 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 768
 769         * annotate.c (annotate_source_line): Change return type to void,
 770         update implementation to match.
 771         * annotate.h (annotate_source_line): Change return type to void,
 772         update header comment.
 773         * stack.c (print_frame_info): Don't change what frame information
 774         is printed based on whether annotations are on or not.
 775
 776 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 777
 778         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 779         (annotate_source): Make static.
 780         (annotate_source_line): Moved from source.c and renamed from
 781         identify_source_line.  Update the return type.
 782         * annotate.h (annotate_source): Delete declaration.
 783         (annotate_source_line): Declaration moved from source.h, and
 784         renamed from identify_source_line.  Return type updated.
 785         * source.c (identify_source_line): Moved to annotate.c and renamed
 786         to annotate_source_line.
 787         (info_line_command): Remove check of annotation_level.
 788         * source.h (identify_source_line): Move declaration to annotate.h
 789         and rename to annotate_source_line.
 790         * stack.c: Add 'annotate.h' include.
 791         (print_frame_info): Remove check of annotation_level before
 792         calling annotate_source_line.
 793
 794 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 795
 796         * source-cache.c (source_cache::get_plain_source_lines): Use
 797         open_source_file_with_line_charpos instead of just
 798         open_source_file, remove call to find_source_lines.
 799         (source_cache::get_source_lines): Likewise.
 800         * source.c (find_source_lines): Make static.
 801         (get_filename_and_charpos): Renamed into...
 802         (open_source_file_with_line_charpos): ..this along with changes to
 803         return a scoped_fd, and some other minor clean ups.
 804         (identify_source_line): Use open_source_file_with_line_charpos.
 805         (search_command_helper): Use open_source_file_with_line_charpos
 806         instead of just open_source_file, remove call to
 807         find_source_lines.
 808         * source.h (open_source_file_with_line_charpos): Declare new
 809         function.
 810         (find_source_lines): Delete declaration.
 811
 812 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 813
 814         * source.c (get_filename_and_charpos): Remove fullname
 815         parameter.
 816         (identify_source_line): Update call to get_filename_and_charpos.
 817
 818 2019-06-14  Tom Tromey  <tromey@adacore.com>
 819
 820         PR gdb/24502:
 821         * ui-style.h (skip_ansi_escape): Update comment.
 822         * ui-file.h (class no_terminal_escape_file): New class.
 823         * ui-file.c (no_terminal_escape_file::write)
 824         (no_terminal_escape_file::puts): New methods.
 825         * cli/cli-logging.c (handle_redirections): Use
 826         no_terminal_escape_file.
 827
 828 2019-06-14  Tom Tromey  <tromey@adacore.com>
 829
 830         * NEWS: Move convenience variable news above Python news.
 831
 832 2019-06-14  Tom Tromey  <tom@tromey.com>
 833
 834         * gnulib: Move directory to top-level.
 835         * configure.ac: Don't configure gnulib.
 836         * configure: Rebuild.
 837         * common/common-defs.h: Use new path to gnulib.
 838         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 839         (GNULIB_H): Remove.
 840         (INCGNU): Look in new gnulib location.
 841         (HFILES_NO_SRCDIR): Remove gnulib files.
 842         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 843         (generated_files): Remove GNULIB_H.
 844         ($(LIBGNU), all-lib): Remove targets.
 845         (distclean): Don't mention GNULIB_BUILDDIR.
 846         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 847
 848 2019-06-14  Tom Tromey  <tromey@adacore.com>
 849
 850         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 851         Warn if symbol file does not provide any symbols.
 852
 853 2019-06-14  Tom Tromey  <tromey@adacore.com>
 854
 855         * source.c (find_and_open_source): Respect basenames_may_differ.
 856
 857 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 858
 859         * annotate.c (annotate_breakpoints_invalid): Make use of
 860         scoped_restore_terminal_state.
 861         (annotate_frames_invalid): Likewise.
 862
 863 2019-06-14  Tom Tromey  <tromey@adacore.com>
 864
 865         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 866         allow assignment to an internalvar.
 867
 868 2019-06-14  Tom Tromey  <tromey@adacore.com>
 869
 870         * ada-lex.l: Allow "_" in attribute names.
 871
 872 2019-06-14  Tom Tromey  <tromey@adacore.com>
 873
 874         PR gdb/24653:
 875         * regcache.c (registers_changed): Don't call alloca.
 876         * top.c (execute_command): Don't call alloca.
 877
 878 2019-06-13  Pedro Alves  <palves@redhat.com>
 879
 880         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 881         'expression'.  When parsing an expression, error out if there's
 882         junk after "unlimited".
 883         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 884         (do_set_command): Adjust calls to is_unlimited_literal.
 885
 886 2019-06-13  Pedro Alves  <palves@redhat.com>
 887
 888         * compile/compile.c (make_compile_options_def_group): Add braces
 889         around array_view initializer.
 890         * thread.c (make_thread_apply_all_options_def_group)
 891         (make_thread_apply_all_options_def_group): Likewise.
 892
 893 2019-06-13  Pedro Alves  <palves@redhat.com>
 894
 895         * NEWS (New commands): Mention "maint test-options
 896         require-delimiter", "maint test-options unknown-is-error", "maint
 897         test-options unknown-is-operand" and "maint show
 898         test-options-completion-result".
 899         (New command options, command completion): New section.
 900         (Completion improvements): New section.
 901         Mention that you can abbreviate "unlimited".
 902
 903 2019-06-13  Pedro Alves  <palves@redhat.com>
 904
 905         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 906         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 907         * unittests/cli-utils-selftests.c (test_parse_flags)
 908         (test_parse_flags_qcs): Delete.
 909         (test_cli_utils): Don't call deleted functions.
 910
 911 2019-06-13  Pedro Alves  <palves@redhat.com>
 912
 913         * thread.c: Include "cli/cli-option.h".
 914         (tp_array_compar_ascending): Global.
 915         (tp_array_compar): Delete function.
 916         (tp_array_compar_ascending, tp_array_compar_descending): New
 917         functions.
 918         (ascending_option_def, qcs_flag_option_def)
 919         (thr_qcs_flags_option_defs)
 920         (make_thread_apply_all_options_def_group)
 921         (make_thread_apply_options_def_group): New.
 922         (thread_apply_all_command): Use gdb::option::process_options.
 923         (thread_apply_command_completer)
 924         (thread_apply_all_command_completer): New.
 925         (thread_apply_command): Use gdb::option::process_options.
 926         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 927         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 928         to generate help text of "thread apply".  Adjust "taas"'s help.
 929         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 930         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 931
 932 2019-06-13  Pedro Alves  <palves@redhat.com>
 933
 934         * thread.c (thread_apply_command): Check for invalid TID with
 935         isdigit instead of !isalpha.
 936
 937 2019-06-13  Pedro Alves  <palves@redhat.com>
 938
 939         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 940         (validate_flags_qcs): New.
 941         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 942         (validate_flags_qcs): Declare.
 943         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 944         (make_frame_apply_options_def_group): New.
 945         (frame_apply_command_count): Process options with
 946         gdb::option::process_options.
 947         (frame_apply_completer): New.
 948         (frame_apply_level_completer, frame_apply_all_completer)
 949         (frame_apply_completer): New.
 950         (_initialize_stack): Update help of "frame apply", "frame apply
 951         level", "frame apply all" and "faas" to mention supported options
 952         and install command completers.
 953         * stack.h (frame_apply_all_completer): Declare.
 954         * thread.c: Include "stack.h".
 955         (tfaas_command): Add "--".
 956         (_initialize_thread): Update help "tfaas" to mention supported
 957         options and install command completer.
 958
 959 2019-06-13  Pedro Alves  <palves@redhat.com>
 960
 961         * completer.c (complete_nested_command_line): New.
 962         (gdb_completion_word_break_characters_throw): Add assertion.
 963         * completer.h (complete_nested_command_line): Declare.
 964
 965 2019-06-13  Pedro Alves  <palves@redhat.com>
 966
 967         * stack.c (parse_backtrace_qualifiers): New.
 968         (backtrace_command): Use it.
 969         (backtrace_command_completer): Complete on qualifiers.
 970
 971 2019-06-13  Pedro Alves  <palves@redhat.com>
 972
 973         * frame.c: Include "cli/cli-option.h.
 974         (user_set_backtrace_options): New.
 975         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 976         Delete.
 977         (get_prev_frame): Adjust.
 978         (boolean_option_def, uinteger_option_def)
 979         (set_backtrace_option_defs): New.
 980         (_initialize_frame): Adjust and use
 981         gdb::option::add_setshow_cmds_for_options to install "set
 982         backtrace past-main" and "set backtrace past-entry".
 983         * frame.h: Include "cli/cli-option.h".
 984         (struct frame_print_options): Forward declare.
 985         (print_frame_arguments_all, print_frame_arguments_scalars)
 986         (print_frame_arguments_none): Declare.
 987         (print_entry_values): Delete declaration.
 988         (struct frame_print_options, user_frame_print_options): New.
 989         (struct set_backtrace_options): New.
 990         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 991         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 992         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 993         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 994         (list_args_or_locals): Add frame_print_options parameter.
 995         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 996         * python/py-framefilter.c (enumerate_args): Pass down
 997         USER_FRAME_PRINT_OPTIONS.
 998         * stack.c: Include "cli/cli-option.h".
 999         (print_frame_arguments_all, print_frame_arguments_scalars)
1000         (print_frame_arguments_none): Declare.
1001         (print_raw_frame_arguments, print_entry_values): Delete.
1002         (user_frame_print_options): New.
1003         (boolean_option_def, enum_option_def, frame_print_option_defs):
1004         New.
1005         (struct backtrace_cmd_options): New.
1006         (bt_flag_option_def): New.
1007         (backtrace_command_option_defs): New.
1008         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
1009         (print_frame_arg, read_frame_arg, print_frame_args)
1010         (print_frame_info, print_frame): Add frame_print_options parameter
1011         and use it.
1012         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
1013         (backtrace_command_1): Add frame_print_options and
1014         backtrace_cmd_options parameters and use them.
1015         (make_backtrace_options_def_group): New.
1016         (backtrace_command): Process command options with
1017         gdb::option::process_options.
1018         (backtrace_command_completer): New.
1019         (_initialize_stack): Extend "backtrace"'s help to mention
1020         supported options.  Install completer for "backtrace".
1021         Install some settings commands with add_setshow_cmds_for_options.
1022
1023 2019-06-13  Pedro Alves  <palves@redhat.com>
1024
1025         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
1026         and that "set/show print raw frame-arguments" are now deprecated.
1027
1028         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
1029         command.
1030         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
1031         * stack.c (_initialize_stack): Install "set/show print
1032         raw-frame-arguments", and deprecate "set/show print raw
1033         frame-arguments".
1034         * valprint.c (_initialize_valprint): Deprecate "set/show print
1035         raw".
1036
1037 2019-06-13  Pedro Alves  <palves@redhat.com>
1038
1039         * compile/compile.c (struct compile_options): New.
1040         (compile_flag_option_def, compile_command_option_defs)
1041         (make_compile_options_def_group): New.
1042         (compile_file_command): Handle options with
1043         gdb::option::process_options.
1044         (compile_file_command_completer): New function.
1045         (compile_code_command): Handle options with
1046         gdb::option::process_options.
1047         (compile_code_command_completer): New function.
1048         (_initialize_compiler): Install completers for "compile code" and
1049         "compile file".  Mention available options in "compile code" and
1050         "compile code"'s help.
1051         * completer.c (advance_to_completion_word): New, factored out from
1052         ...
1053         (advance_to_expression_complete_word_point): ... this.
1054         (advance_to_filename_complete_word_point): New.
1055         * completer.h (advance_to_filename_complete_word_point): New
1056         declaration.
1057
1058 2019-06-13  Pedro Alves  <palves@redhat.com>
1059
1060         * compile/compile.c: Include "cli/cli-option.h".
1061         (compile_print_value): Scope data pointer is now a
1062         value_print_options pointer; adjust.
1063         (compile_print_command): Process options.  Scope data pointer is
1064         now a value_print_options pointer; adjust.
1065         (_initialize_compile): Update "compile print"'s help to include
1066         supported options.  Install a completer for "compile print".
1067         * cp-valprint.c (show_vtblprint, show_objectprint)
1068         (show_static_field_print): Delete.
1069         (_initialize_cp_valprint): Don't install "set print
1070         static-members", "set print vtbl", "set print object" here.
1071         * printcmd.c: Include "cli/cli-option.h" and
1072         "common/gdb_optional.h".
1073         (print_command_parse_format): Rework to fill in a
1074         value_print_options instead of a format_data.
1075         (print_value): Change parameter type from format_data pointer to
1076         value_print_options reference.  Adjust.
1077         (print_command_1): Process options.  Adjust to pass down a
1078         value_print_options.
1079         (print_command_completer): New.
1080         (_initialize_printcmd): Install print_command_completer as
1081         handle_brkchars completer for the "print" command.  Update
1082         "print"'s help to include supported options.
1083         * valprint.c: Include "cli/cli-option.h".
1084         (show_vtblprint, show_objectprint, show_static_field_print): Moved
1085         here from cp-valprint.c.
1086         (boolean_option_def, uinteger_option_def)
1087         (value_print_option_defs, make_value_print_options_def_group):
1088         New.  Use gdb::option::add_setshow_cmds_for_options to install
1089         "set print elements", "set print null-stop", "set print repeats",
1090         "set print pretty", "set print union", "set print array", "set
1091         print address", "set print symbol", "set print array-indexes".
1092         * valprint.h: Include <string> and "cli/cli-option.h".
1093         (make_value_print_options_def_group): Declare.
1094         (print_value): Change parameter type from format_data pointer to
1095         value_print_options reference.
1096         (print_command_completer): Declare.
1097
1098 2019-06-13  Pedro Alves  <palves@redhat.com>
1099
1100         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
1101         (COMMON_SFILES): Add maint-test-settings.c.
1102         * cli/cli-decode.c (boolean_enums): New global, factored out from
1103         ...
1104         (add_setshow_boolean_cmd): ... here.
1105         * cli/cli-decode.h (boolean_enums): Declare.
1106         * cli/cli-option.c: New file.
1107         * cli/cli-option.h: New file.
1108         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
1109         factored out from ...
1110         (parse_cli_boolean_value(const char *)): ... this.
1111         (is_unlimited_literal): Change parameter type to pointer to
1112         pointer.  Adjust and advance ARG pointer.
1113         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1114         (parse_cli_var_enum): New, factored out from ...
1115         (do_set_command): ... this.  Adjust.
1116         * cli/cli-setshow.h (parse_cli_boolean_value)
1117         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
1118         (parse_cli_var_enum): Declare.
1119         * cli/cli-utils.c: Include "cli/cli-option.h".
1120         (get_ulongest): New.
1121         * cli/cli-utils.h (get_ulongest): Declare.
1122         (check_for_argument): New overloads.
1123         * maint-test-options.c: New file.
1124
1125 2019-06-13  Pedro Alves  <palves@redhat.com>
1126
1127         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
1128         parse a range if "-" is at the end of the string.
1129
1130 2019-06-13  Pedro Alves  <palves@redhat.com>
1131
1132         * cli/cli-setshow.c (parse_auto_binary_operation)
1133         (parse_cli_boolean_value): Don't allow "o".
1134
1135 2019-06-13  Pedro Alves  <palves@redhat.com>
1136
1137         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
1138         * NEWS: Mention maint test-settings KIND.
1139         * maint-test-settings.c: New file.
1140
1141 2019-06-13  Pedro Alves  <palves@redhat.com>
1142
1143         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
1144         completer.
1145         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
1146         "set" completers.
1147
1148 2019-06-13  Pedro Alves  <palves@redhat.com>
1149
1150         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
1151         after item.
1152
1153 2019-06-13  Pedro Alves  <palves@redhat.com>
1154
1155         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
1156
1157 2019-06-13  Pedro Alves <palves@redhat.com>
1158
1159         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
1160         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
1161         call.
1162         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
1163         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
1164         calls.
1165         (check_for_argument): Skip spaces after argument.
1166
1167 2019-06-13  Pedro Alves  <palves@redhat.com>
1168
1169         * thread.c (thread_apply_command): Adjust TID parsing.
1170         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
1171         detected before end of string.
1172         (tid_is_in_list): Error out if LIST is invalid.
1173
1174 2019-06-13  Pedro Alves  <palves@redhat.com>
1175
1176         * completer.c (complete_line_internal_1): Rewind completion word
1177         point.
1178         (completion_tracker::advance_custom_word_point_by): Change
1179         parameter type to int.
1180         * completer.h (completion_tracker::advance_custom_word_point_by):
1181         Likewise.
1182
1183 2019-06-13  Pedro Alves  <palves@redhat.com>
1184
1185         * completer.c (advance_to_completion_word): Handle delimiters.
1186
1187 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
1188
1189         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
1190
1191 2019-06-11  Tom Tromey  <tom@tromey.com>
1192
1193         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
1194         (xmalloc_failed): Move to alloc.c.
1195         * alloc.c: New file.
1196         * Makefile.in (COMMON_SFILES): Add alloc.c.
1197
1198 2019-06-11  Tom Tromey  <tom@tromey.com>
1199
1200         * nat/linux-waitpid.c: Don't include server.h.
1201         (linux_debug): Remove.
1202         (my_waitpid): Update.
1203
1204 2019-06-11  Tom Tromey  <tromey@adacore.com>
1205
1206         * infcall.c (_initialize_infcall): Remove trailing newline from
1207         help.
1208         * user-regs.c (_initialize_user_regs): Remove trailing newline
1209         from help.
1210         * typeprint.c (_initialize_typeprint): Remove trailing newline
1211         from help.
1212         * reverse.c (_initialize_reverse): Remove trailing newlines from
1213         help.
1214         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
1215         from help.
1216         * language.c (add_set_language_command): Remove trailing newline
1217         from help.
1218         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
1219         help.
1220         * disasm.c (_initialize_disasm): Remove trailing newline from
1221         help.
1222         * top.c (init_main): Remove trailing newline from help.
1223         * interps.c (_initialize_interpreter): Remove trailing newline
1224         from help.
1225         * btrace.c (_initialize_btrace): Remove trailing newlines from
1226         help.
1227         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
1228         from help.
1229         * python/python.c (_initialize_python): Remove trailing newline
1230         from help.
1231         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
1232         help.
1233         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
1234         from help.  Reformat some text.
1235         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
1236         from help.
1237         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
1238         newline from help.
1239
1240 2019-06-11  Tom Tromey  <tromey@adacore.com>
1241
1242         * darwin-nat.c (darwin_decode_exception_message)
1243         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
1244
1245 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * valops.c (value_slice): Check for not allocated or not
1248         associated values.
1249
1250 2019-06-10  Tom de Vries  <tdevries@suse.de>
1251
1252         PR gdb/24618
1253         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
1254         sure an empty slot (defined by a 32-bit zero pair) is recognized as
1255         invalid.
1256
1257 2019-06-10  Tom de Vries  <tdevries@suse.de>
1258
1259         PR gdb/24611
1260         * linespec.c (linespec_lexer_lex_string): Remove incorrect
1261         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
1262
1263 2019-06-10  Tom de Vries  <tdevries@suse.de>
1264
1265         PR symtab/24545
1266         * symtab.c (struct demangled_name_entry): Add language field.
1267         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
1268         static minimal symbol".  Set and use language field.
1269
1270 2019-06-10  Tom Tromey  <tromey@adacore.com>
1271
1272         * ada-lang.c (_initialize_ada_language): Update help text.
1273
1274 2019-06-10  Tom Tromey  <tromey@adacore.com>
1275
1276         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
1277         with a newline.
1278         * guile/guile.c (handle_boot_error): Don't end warning with a
1279         newline.
1280         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
1281         warning with a newline.
1282         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
1283         newline.
1284         (s12z_frame_cache): Likewise.
1285         * dwarf-index-cache.c (index_cache::store): Don't end warning with
1286         a newline.
1287         * solib-svr4.c (disable_probes_interface): Don't end warning with
1288         a newline.
1289         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
1290         newline.
1291         * python/python.c (do_finish_initialization): Don't end warning
1292         with a newline.
1293
1294 2019-06-10  Tom Tromey  <tom@tromey.com>
1295
1296         * python/py-breakpoint.c (gdbpy_breakpoint_created)
1297         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
1298         gdbpy_enter.
1299
1300 2019-06-10  Tom Tromey  <tromey@adacore.com>
1301
1302         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
1303         data.
1304         (elf_new_init): Don't call stabsread_new_init.
1305         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
1306         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
1307         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
1308
1309 2019-06-10  Tom de Vries  <tdevries@suse.de>
1310
1311         PR symtab/16264
1312         PR symtab/24517
1313         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
1314
1315 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
1316
1317         * source.c (find_and_open_source): Also rewrite relative file
1318         names.
1319
1320 2019-04-26  Amos Bird  <amosbird@gmail.com>
1321
1322         * annotate.c (annotate_thread_exited): Add "thread-exited"
1323         annotation.
1324
1325 2019-06-06  Tom Tromey  <tromey@adacore.com>
1326
1327         * maint.h (class scoped_command_stats): Use
1328         DISABLE_COPY_AND_ASSIGN.
1329         <print_time>: New method.
1330         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
1331         print_time.
1332         (scoped_command_stats::print_time): New method.
1333
1334 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
1335
1336         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
1337         instructions of lengths 6 or 8 bytes.
1338
1339 2019-06-04  Pedro Alves  <palves@redhat.com>
1340
1341         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
1342
1343         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
1344         * breakpoint.c (condition_completer): Likewise.
1345         * cli/cli-dump.c (scan_expression): Likewise.
1346         * common/filestuff.c (mkdir_recursive): Likewise.
1347         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
1348         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
1349         (gdb_abspath): Likewise.
1350         * compile/compile-cplus-types.c
1351         (compile_cplus_instance::decl_name): Likewise.
1352         * completer.c (complete_explicit_location):
1353         (signal_completer, reg_or_group_completer_1): Likewise.
1354         * cp-support.c (cp_remove_params_if_any): Likewise.
1355         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
1356         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
1357         * infcmd.c (strip_bg_char): Likewise.
1358         * linespec.c (copy_token_string): Likewise.
1359         * mi/mi-main.c (output_cores): Likewise.
1360         * psymtab.c (psymtab_search_name):
1361         * symfile.c (test_set_ext_lang_command): Likewise.
1362         * target.c (target_fileio_read_stralloc): Likewise.
1363         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
1364         * value.c (complete_internalvar): Likewise.
1365
1366 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
1367
1368         Add objfile property to gdb.Type.
1369         * NEWS: Mention Python API addition.
1370         * python/py-type.c (typy_get_objfile): New method.
1371
1372 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1373
1374         * NEWS: Mention the new set|show style [title|highlight].
1375         Mention changes to "show style", "help" and "apropos".
1376
1377 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1378
1379         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
1380         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
1381         instead of print_help_for_command.
1382         (print_doc_of_command): New function.
1383         (help_list): Add 'apropos -v word' suggestion.
1384         (print_help_for_command): Style the command name using title style.
1385         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
1386         (_initialize_cli_cmds): Describe -v in apropos_command help.
1387
1388 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1389
1390         * cli/cli-style.h (cli_style_option): Add name in constructor,
1391         add m_name class member, add constructor with intensity,
1392         add name class function.
1393         (cli_style_option::add_setshow_commands): Remove name argument.
1394         (highlight_style, title_style): New styles.
1395         * cli/cli-style.c (do_show): New function that shows a style
1396         characteristic styling the style name with itself.
1397         (set_style_name): New function.
1398         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
1399         Update all callers according to the changes in cli/cli-style.h.
1400         * utils.h (fputs_highlighted): New function.
1401         * utils.c (fputs_highlighted): Likewise.
1402
1403 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1404
1405         * NEWS: Mention new pipe command and new convenience variables.
1406
1407 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1408
1409         * cli/cli-cmds.c (pipe_command): New function.
1410         (_initialize_cli_cmds): Call add_com for pipe_command.
1411         Define | as an alias for pipe.
1412         (exit_status_set_internal_vars): New function.
1413         (shell_escape): Call exit_status_set_internal_vars.
1414         cli/cli-decode.c (find_command_name_length): Recognize | as
1415         a single character command.
1416
1417 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1418
1419         * gdbcmd.h (execute_command_to_ui_file): New declaration.
1420         top.c (execute_command_to_ui_file): New function, mostly a copy
1421         of execute_command_to_string.
1422         (execute_command_to_string): Implement by calling
1423         execute_command_to_ui_file.
1424
1425 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1426
1427         * top.h (saved_command_line): Remove declaration.
1428         * top.c (previous_saved_command_line, previous_repeat_arguments):
1429         New variables.
1430         (saved_command_line): Make static, define together with other
1431         'repeat variables'.
1432         (dont_repeat): Clear repeat_arguments.
1433         (repeat_previous, get_saved_command_line, save_command_line):
1434         New functions.
1435         (gdb_init): Initialize saved_command_line
1436         and previous_saved_command_line.
1437         * main.c (captured_main_1): Remove saved_command_line initialization.
1438         * event-top.c (handle_line_of_input): Update to use
1439         the new 'repeat' related functions instead of direct access to
1440         saved_command_line.
1441         * command.h (repeat_previous, get_saved_command_line,
1442         save_command_line): New declarations.
1443         (dont_repeat): Add comment.
1444
1445 2019-05-30  Tom Tromey  <tromey@adacore.com>
1446
1447         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
1448         Fix comment.
1449         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
1450
1451 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
1452
1453         PR cli/24587
1454         * completer.c (complete): Initialize variable word.
1455
1456 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
1457
1458         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1459         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
1460         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
1461         'body' is NULL to the outter 'if', protecting the '!is_define'
1462         situation as well.
1463
1464 2019-05-29  Tom Tromey  <tromey@adacore.com>
1465
1466         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
1467         (dwarf_unknown): New function.
1468         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
1469         (dwarf_type_encoding_name): Use dwarf_unknown.
1470
1471 2019-05-29  Tom Tromey  <tromey@adacore.com>
1472
1473         PR c++/20020:
1474         * cp-valprint.c (cp_print_value_fields): Call
1475         cp_print_static_field inside "try".
1476
1477 2019-05-29  Tom Tromey  <tromey@adacore.com>
1478
1479         * inflow.c (struct terminal_info): Add default operator=.
1480         * configure: Rebuild.
1481         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
1482         -Wdeprecated-copy-dtor, -Wredundant-move.
1483
1484 2019-05-29  Tom Tromey  <tromey@adacore.com>
1485
1486         * NEWS: Add entry.
1487         * infcmd.c (print_return_value_1): Handle finish_print
1488         option.
1489         (show_print_finish): New function.
1490         (_initialize_infcmd): Add "set/show print finish" commands.
1491         * valprint.c (user_print_options): Initialize new member.
1492         * valprint.h (struct value_print_options) <finish_print>: New
1493         member.
1494
1495 2019-05-28  Tom Tromey  <tromey@adacore.com>
1496
1497         * ada-lang.c (ada_remove_Xbn_suffix)
1498         (find_old_style_renaming_symbol)
1499         (parse_old_style_renaming): Remove.
1500         (ada_find_renaming_symbol): Don't call
1501         find_old_style_renaming_symbol.
1502         (ada_is_renaming_symbol): Rename from
1503         ada_find_renaming_symbol.  Remove "block" parameter.  Return
1504         bool.  Now static.
1505         (ada_read_var_value): Update and simplify.
1506         * ada-exp.y (write_var_or_type): Remove old code.
1507
1508 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
1509
1510         * event-top.c: Remove include comment.
1511         * inflow.c (class scoped_ignore_sigttou): Move from here...
1512         * inflow.h (class scoped_ignore_sigttou): ...to here.
1513         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
1514         * top.c:  Remove include comment.
1515
1516 2019-05-27  Tom Tromey  <tom@tromey.com>
1517
1518         * NEWS: Fix typo.
1519
1520 2019-05-22  Tom Tromey  <tromey@adacore.com>
1521
1522         * target.c (target_follow_exec): Constify parameter.
1523         * target-delegates.c: Rebuild.
1524         * remote.c (remote_target::follow_exec): Constify parameter.
1525         * infrun.c (follow_exec): Constify parameter.
1526         * target.h (struct target_ops) <follow_exec>: Constify parameter.
1527         (target_follow_exec): Likewise.
1528
1529 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1530
1531         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
1532         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
1533
1534 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
1535
1536         * NEWS: Add debugredirect and testsuite sections.
1537
1538 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1539
1540         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1541         target descriptions using exclusively floating point register name
1542         aliases.
1543
1544 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1545
1546         PR gdb/18644:
1547         * f-lang.c (build_fortran_types): Handle the case where
1548         gdbarch_floatformat_for_type returns a nullptr.
1549
1550 2019-05-21  Tom de Vries  <tdevries@suse.de>
1551
1552         PR cli/24587
1553         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1554
1555 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1556
1557         PR gdb/18644:
1558         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1559         16-byte floats.
1560         * i386-tdep.c (i386_floatformat_for_type): Use
1561         floatformats_ia64_quad for the 16-byte floating point component
1562         within a fortran 32-byte complex number.
1563
1564 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1565
1566         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1567         delete default constructor.
1568         (find_partial_die): Update to return const struct.
1569         (partial_die_parent_scope): Move variable declaration into scope
1570         of its use and change its type to auto.
1571         (guess_partial_die_structure_name): Likewise.
1572         (partial_die_info::fixup): Likewise.
1573
1574 2019-05-17  Tom Tromey  <tromey@adacore.com>
1575
1576         * source.c (find_and_open_source): Remove cast.
1577
1578 2019-05-17  Tom Tromey  <tromey@adacore.com>
1579
1580         * annotate.c (annotate_source): Make "filename" const.
1581         * annotate.h (annotate_source): Use const.
1582
1583 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1584
1585         * disasm.c (set_disassembler_options): Send errors to stderr.
1586
1587 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1588
1589         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1590         (cli_interp_base::set_logging): Check debug_redirect.
1591         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1592         * cli/cli-logging.c (debug_redirect): Add static variable.
1593         (pop_output_files): Add default param.
1594         (handle_redirections): Print debug setting.
1595         (show_logging_command): Likewise.
1596         (_initialize_cli_logging): Add debugredirect command.
1597         * interps.c (current_interp_set_logging): Add debug_redirect
1598         parameter.
1599         * interps.h (set_logging): Add debug_redirect parameter.
1600         (current_interp_set_logging): Likewise.
1601         * mi/mi-common.h: Likewise.
1602         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1603
1604 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1605             Tom Tromey  <tromey@adacore.com>
1606
1607         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1608         directly.
1609         * cli/cli-interp.h (make_logging_output): Remove declaration.
1610         * cli/cli-logging.c (make_logging_output): Remove function.
1611         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1612         directly.
1613         * ui-file.c (tee_file::tee_file): Remove bools.
1614         (tee_file::~tee_file): Remove deletes.
1615         * ui-file.h (tee_file): Remove bools.
1616
1617 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1618
1619         * mi/mi-cmds.h (mi_cmd_complete): New function.
1620         * mi/mi-main.c (mi_cmd_complete): Likewise.
1621         * mi/mi-cmds.c: Define new MI command -complete.
1622         * NEWS: Mention new -complete command.
1623
1624 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1625
1626         * completer.h (complete): New function.
1627         * completer.c (complete): Likewise.
1628         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1629         function defined in completer.h.
1630
1631 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1632
1633         * MAINTAINERS (Write After Approval): Add myself.
1634
1635 2019-05-17  Tom de Vries  <tdevries@suse.de>
1636
1637         PR gdb/24094
1638         * dwarf2read.c (struct cu_partial_die_info): New struct.
1639         (find_partial_die): Return cu_partial_die_info.
1640         (partial_die_parent_scope, guess_partial_die_structure_name)
1641         (partial_die_info::fixup): Handle new return type of find_partial_die.
1642
1643 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1644
1645         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1646         "std::string", simplifying the algorithm.
1647
1648 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1649
1650         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1651         (stap_static_probe_ops::get_probes): Likewise.
1652
1653 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1654
1655         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1656         '-')" and "else if".
1657         (stap_parse_single_operand): Join checks for
1658         "gdbarch_stap_parse_special_token_p" and
1659         "gdbarch_stap_parse_special_token" in the same "if" statement.
1660         Invert check when verifying for operation on register
1661         displacement.
1662
1663 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1664
1665         * stap-probe.c (stap_get_opcode): Update comment.
1666         (stap_get_expected_argument_type): Likewise.
1667         (handle_stap_probe): Likewise.
1668
1669 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1670
1671         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1672         return type to 'bool'.  Adjust comment.  Use 'bool' when
1673         appropriate.
1674         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1675         * stap-probe.c (stap_parse_argument_1): Likewise.
1676         (stap_is_operator): Likewise.
1677         (stap_is_generic_prefix): Likewise.
1678         (stap_is_register_prefix): Likewise.
1679         (stap_is_register_indirection_prefix): Likewise.
1680         (stap_is_integer_prefix): Likewise.
1681         (stap_generic_check_suffix): Likewise.
1682         (stap_check_integer_suffix): Likewise.
1683         (stap_check_register_suffix): Likewise.
1684         (stap_check_register_indirection_suffix): Likewise.
1685         (stap_parse_register_operand): Likewise.
1686         (stap_parse_single_operand): Likewise.
1687         (stap_parse_argument_1): Likewise.
1688         (stap_probe::get_argument_count): Likewise.
1689         (stap_is_operator): Likewise.
1690
1691 2019-05-16  Tom Tromey  <tromey@adacore.com>
1692
1693         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1694         keyword to foreach.
1695
1696 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1697
1698         * linux-thread-db.c (try_thread_db_load_1): Change return type
1699         to bool.
1700         (try_thread_db_load): Likewise.
1701         (try_thread_db_load_from_pdir_1): Likewise.
1702         (try_thread_db_load_from_pdir): Likewise.
1703         (try_thread_db_load_from_sdir): Likewise.
1704         (try_thread_db_load_from_dir): Likewise.
1705         (thread_db_load_search): Likewise.
1706         (has_libpthread): Likewise.
1707         (thread_db_load): Likewise.
1708
1709 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1710
1711         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1712         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1713         NULL, and complain/return if that's the case.
1714
1715 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1716
1717         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1718         (advance, posn, abstract_read_memory): New functions.
1719         [struct mem_read_abstraction]: New struct.
1720         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1721
1722 2019-05-14  Tom Tromey  <tromey@adacore.com>
1723
1724         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1725         value is not lval_memory.
1726
1727 2019-05-14  Tom Tromey  <tromey@adacore.com>
1728
1729         * solib.c (info_sharedlibrary_command): Style the file name.
1730
1731 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1732
1733         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1734         (aarch64_vnv_type): Likewise.
1735         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1736         * common/tdesc.c: Likewise.
1737         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1738         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1739         * features/aarch64-fpu.xml: Add ieee half view.
1740         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1741         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1742         * gdbtypes.h (struct builtin_type): Likewise.
1743         (struct objfile_type): Likewise.
1744
1745 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1746
1747         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1748         typo.
1749         * location.h (string_to_event_location): Likewise.
1750
1751 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1752
1753         GDB 8.3 released.
1754
1755 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1756
1757         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1758         New variable declaration.
1759         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1760         New variable.
1761         (print_one_breakpoint): Use ui_out::test_flags and new global
1762         variable to compute use_fixed_output.
1763         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1764         Remove.
1765         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1766         (mi_multi_location_breakpoint_output_fixed): Remove.
1767         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1768         new variable.
1769         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1770         fix_multi_location_breakpoint_output flag if version >= 3.
1771         * ui-out.h (enum ui_out_flag)
1772         <fix_multi_location_breakpoint_output>: New enumerator.
1773
1774 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1775
1776         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1777
1778 2019-05-10  Tom Tromey  <tromey@adacore.com>
1779
1780         * ada-lang.c (catch_ada_completer): New function.
1781         (_initialize_ada_language): Use it.
1782
1783 2019-05-10  Tom Tromey  <tromey@adacore.com>
1784
1785         * thread.c (print_thread_info): Make "requested_threads" const.
1786         * gdbthread.h (print_thread_info): Make "requested_threads"
1787         const.
1788         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1789         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1790
1791 2019-05-08  Tom Tromey  <tom@tromey.com>
1792
1793         * gdbtypes.c (objfile_type_data): Change type.
1794         (objfile_type, _initialize_gdbtypes): Update.
1795
1796 2019-05-08  Tom Tromey  <tom@tromey.com>
1797
1798         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1799         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1800         (_initialize_dwarf2_frame): Update.
1801
1802 2019-05-08  Tom Tromey  <tom@tromey.com>
1803
1804         * objc-lang.c (objc_objfile_data): Change type.
1805         (find_methods): Update.
1806         (_initialize_objc_lang): Remove.
1807
1808 2019-05-08  Tom Tromey  <tom@tromey.com>
1809
1810         * stabsread.c (rs6000_builtin_type_data): Change type.
1811         (rs6000_builtin_type, _initialize_stabsread): Update.
1812
1813 2019-05-08  Tom Tromey  <tom@tromey.com>
1814
1815         * mips-tdep.c (mips_pdr_data): Remove.
1816         (_initialize_mips_tdep): Update.
1817
1818 2019-05-08  Tom Tromey  <tom@tromey.com>
1819
1820         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1821         (hppa_init_objfile_priv_data, read_unwind_info)
1822         (find_unwind_entry, _initialize_hppa_tdep): Update.
1823
1824 2019-05-08  Tom Tromey  <tom@tromey.com>
1825
1826         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1827         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1828         on obstack.
1829         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1830
1831 2019-05-08  Tom Tromey  <tom@tromey.com>
1832
1833         * mdebugread.c (basic_type_data): Change type.
1834         (basic_type, _initialize_mdebugread): Update.
1835
1836 2019-05-08  Tom Tromey  <tom@tromey.com>
1837
1838         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1839
1840 2019-05-08  Tom Tromey  <tom@tromey.com>
1841
1842         * nto-tdep.c (nto_inferior_data_reg): Change type.
1843         (nto_inferior_data): Update.
1844         (nto_inferior_data_cleanup, nto_new_inferior_data)
1845         (_initialize_nto_tdep): Remove.
1846         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1847
1848 2019-05-08  Tom Tromey  <tom@tromey.com>
1849
1850         * ada-lang.c (struct ada_inferior_data): Add initializers.
1851         (ada_inferior_data): Change type.
1852         (ada_inferior_data_cleanup): Remove.
1853         (get_ada_inferior_data, ada_inferior_exit)
1854         (struct ada_pspace_data): Add initializers, destructor.
1855         (ada_pspace_data_handle): Change type.
1856         (get_ada_pspace_data): Update.
1857         (ada_pspace_data_cleanup): Remove.
1858
1859 2019-05-08  Tom Tromey  <tom@tromey.com>
1860
1861         * coffread.c (struct coff_symfile_info): Add initializers.
1862         (coff_objfile_data_key): Move lower.  Change type.
1863         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1864         Update.
1865         (coff_free_info): Remove.
1866
1867 2019-05-08  Tom Tromey  <tom@tromey.com>
1868
1869         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1870         (fbsd_pspace_data_handle): Move lower.  Change type.
1871         (get_fbsd_pspace_data): Update.
1872         (fbsd_pspace_data_cleanup): Remove.
1873         (_initialize_fbsd_tdep): Update.
1874
1875 2019-05-08  Tom Tromey  <tom@tromey.com>
1876
1877         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1878         (get_ada_tasks_pspace_data): Update.
1879         (ada_tasks_pspace_data_cleanup): Remove.
1880         (_initialize_tasks): Update.
1881         (ada_tasks_inferior_data_handle): Change type.
1882         (get_ada_tasks_inferior_data): Update.
1883         (ada_tasks_inferior_data_cleanup): Remove.
1884         (struct ada_tasks_pspace_data): Add initializers.
1885
1886 2019-05-08  Tom Tromey  <tom@tromey.com>
1887
1888         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1889         * symfile-debug.c (debug_sym_get_probes): Change type.
1890         * stap-probe.c (handle_stap_probe):
1891         (stap_static_probe_ops::get_probes): Change type.
1892         * probe.h (class static_probe_ops) <get_probes>: Change type.
1893         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1894         (parse_probes_in_pspace): Update.
1895         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1896         Update.
1897         (any_static_probe_ops::get_probes): Change type.
1898         * elfread.c (elfread_data): New typedef.
1899         (probe_key): Change type.
1900         (elf_get_probes): Likewise.  Update.
1901         (probe_key_free): Remove.
1902         (_initialize_elfread): Update.
1903         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1904         Change type.
1905         (dtrace_process_dof_probe, dtrace_process_dof)
1906         (dtrace_static_probe_ops::get_probe): Change type.
1907
1908 2019-05-08  Tom Tromey  <tom@tromey.com>
1909
1910         * xcoffread.c (struct xcoff_symfile_info): Rename from
1911         coff_symfile_info.  Add initializers.
1912         (xcoff_objfile_data_key): Move lower.  Change type.
1913         (XCOFF_DATA): Rewrite.
1914         (xcoff_free_info): Remove.
1915         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1916         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1917         (xcoff_initial_scan): Update.
1918
1919 2019-05-08  Tom Tromey  <tom@tromey.com>
1920
1921         * solib-svr4.c (struct svr4_info): Add initializers and
1922         destructor.
1923         <probes_table>: Now an htab_up.
1924         (solib_svr4_pspace_data): Change type.
1925         (free_probes_table): Simplify.
1926         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1927         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1928         (probes_table_remove_objfile_probes, register_solib_event_probe)
1929         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1930         (_initialize_svr4_solib): Update.
1931
1932 2019-05-08  Tom Tromey  <tom@tromey.com>
1933
1934         * remote.c (remote_pspace_data): Change type.
1935         (remote_pspace_data_cleanup): Remove.
1936         (get_remote_exec_file, set_pspace_remote_exec_file)
1937         (_initialize_remote): Update.
1938
1939 2019-05-08  Tom Tromey  <tom@tromey.com>
1940
1941         * breakpoint.c (breakpoint_objfile_key): Change type.
1942         (get_breakpoint_objfile_data): Update.
1943         (free_breakpoint_objfile_data): Remove.
1944         (_initialize_breakpoint): Update.
1945
1946 2019-05-08  Tom Tromey  <tom@tromey.com>
1947
1948         * linux-tdep.c (struct linux_info): Add initializers.
1949         (linux_inferior_data): Move.  Change type.
1950         (invalidate_linux_cache_inf): Update.
1951         (linux_inferior_data_cleanup): Remove.
1952         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1953
1954 2019-05-08  Tom Tromey  <tom@tromey.com>
1955
1956         * auxv.c (auxv_inferior_data): Move.  Change type.
1957         (auxv_inferior_data_cleanup): Remove.
1958         (invalidate_auxv_cache_inf): Rewrite.
1959         (get_auxv_inferior_data, _initialize_auxv): Update.
1960
1961 2019-05-08  Tom Tromey  <tom@tromey.com>
1962
1963         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1964         (symfile_debug_objfile_data_key): Change type.
1965         (symfile_debug_installed, debug_qf_has_symbols)
1966         (debug_qf_find_last_source_symtab)
1967         (debug_qf_forget_cached_source_info)
1968         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1969         (debug_qf_print_stats, debug_qf_dump)
1970         (debug_qf_expand_symtabs_for_function)
1971         (debug_qf_expand_all_symtabs)
1972         (debug_qf_expand_symtabs_with_fullname)
1973         (debug_qf_map_matching_symbols)
1974         (debug_qf_expand_symtabs_matching)
1975         (debug_qf_find_pc_sect_compunit_symtab)
1976         (debug_qf_map_symbol_filenames)
1977         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1978         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1979         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1980         (debug_sym_read_linetable, debug_sym_relocate): Update.
1981         (symfile_debug_free_objfile): Remove.
1982         (install_symfile_debug_logging, _initialize_symfile_debug):
1983         Update.
1984
1985 2019-05-08  Tom Tromey  <tom@tromey.com>
1986
1987         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1988         allocate_on_obstack.
1989         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1990         (get_dwarf2_per_objfile): Update.
1991         (set_dwarf2_per_objfile): Remove.
1992         (dwarf2_has_info, dwarf2_get_section_info): Update.
1993         (dwarf2_free_objfile): Remove.
1994         (_initialize_dwarf2_read): Update.
1995
1996 2019-05-08  Tom Tromey  <tom@tromey.com>
1997
1998         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1999         initializers.
2000         <unsupported_script_warning_printed,
2001         script_not_found_warning_printed>: Now bool.
2002         (auto_load_pspace_data): Change type.
2003         (~auto_load_pspace_info): Rename from
2004         auto_load_pspace_data_cleanup.
2005         (get_auto_load_pspace_data, init_loaded_scripts_info)
2006         (clear_section_scripts, maybe_print_unsupported_script_warning)
2007         (maybe_print_script_not_found_warning, _initialize_auto_load):
2008         Update.
2009
2010 2019-05-08  Tom Tromey  <tom@tromey.com>
2011
2012         * objfiles.c (objfile_pspace_info): Add destructor and
2013         initializers.
2014         (objfiles_pspace_data): Change type.
2015         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
2016         (get_objfile_pspace_data): Update.
2017         (objfiles_bfd_data): Change type.
2018         (get_objfile_bfd_data): Update.
2019         (objfile_bfd_data_free, _initialize_objfiles): Remove.
2020
2021 2019-05-08  Tom Tromey  <tom@tromey.com>
2022
2023         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
2024         Change type.
2025         (get_catch_syscall_inferior_data): Update.
2026         (catch_syscall_inferior_data_cleanup): Remove.
2027         (_initialize_break_catch_syscall): Update.
2028
2029 2019-05-08  Tom Tromey  <tom@tromey.com>
2030
2031         * inflow.c (struct terminal_info): Add destructor and
2032         initializers.
2033         (inflow_inferior_data): Change type.
2034         (~terminal_info): Rename from inflow_inferior_data_cleanup.
2035         (get_inflow_inferior_data, inflow_inferior_exit)
2036         (swap_terminal_info, _initialize_inflow): Update.
2037
2038 2019-05-08  Tom Tromey  <tom@tromey.com>
2039
2040         * target-dcache.c (target_dcache_cleanup): Remove.
2041         (target_dcache_aspace_key): Change type.
2042         (target_dcache_init_p, target_dcache_invalidate)
2043         (target_dcache_get, target_dcache_get_or_init)
2044         (_initialize_target_dcache): Update.
2045         * dcache.h (struct dcache_deleter): New.
2046
2047 2019-05-08  Tom Tromey  <tom@tromey.com>
2048
2049         * symtab.c (struct symbol_cache): Add destructor and
2050         initializers.
2051         (symbol_cache_key): Move.  Change type.
2052         (make_symbol_cache, free_symbol_cache): Remove.
2053         (get_symbol_cache): Update.
2054         (symbol_cache_cleanup): Remove.
2055         (ALL_PSPACES, symbol_cache_flush)
2056         (maintenance_print_symbol_cache)
2057         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
2058         Update.
2059
2060 2019-05-08  Tom Tromey  <tom@tromey.com>
2061
2062         * symtab.c (struct main_info): Add destructor and initializers.
2063         (main_progspace_key): Move.  Change type.
2064         (get_main_info): Update.
2065         (main_info_cleanup): Remove.
2066         (_initialize_symtab): Update.
2067
2068 2019-05-08  Tom Tromey  <tom@tromey.com>
2069
2070         * registry.h (DECLARE_REGISTRY): Define the _key class.
2071
2072 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
2073
2074         * NEWS: Merge two 'New commands' sections.
2075
2076 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
2077
2078         * ada-valprint.c (ada_val_print_gnat_array): Remove language
2079         parameter and use Ada language definition instead.
2080         (ada_val_print_ptr): Remove unused language parameter.
2081         (ada_val_print_num): Remove language parameter and use Ada language
2082         definition instead.
2083         (ada_val_print_enum, ada_val_print_flt): Remove unused language
2084         parameter.
2085         (ada_val_print_struct_union, ada_val_print_ref): Remove language
2086         parameter and use Ada language definition instead.
2087         (ada_val_print_1): Update all ada_val_print_xxx calls.
2088         Remove language parameter.
2089         (ada_val_print): Update ada_val_print_1 call.
2090
2091 2019-05-08  Tom Tromey  <tromey@adacore.com>
2092
2093         * remote.c (remote_hw_watchpoint_limit)
2094         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
2095         Now static.
2096
2097 2019-05-08  Tom Tromey  <tromey@adacore.com>
2098
2099         * maint.c (_initialize_maint_cmds): Move initialization code to
2100         remote.c.
2101         (watchdog, show_watchdog): Move to remote.c.
2102         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
2103         "watchdog" static.
2104         (_initialize_remote): Move initialization code from maint.c.
2105         * defs.h (watchdog): Don't declare.
2106
2107 2019-05-08  Tom Tromey  <tromey@adacore.com>
2108
2109         * tui/tui-interp.c: Include main.h.
2110         * interps.c: Include main.h.
2111         * main.h (interpreter_p): Declare.
2112         * defs.h (interpreter_p): Don't declare.
2113
2114 2019-05-08  Tom Tromey  <tromey@adacore.com>
2115
2116         * dwarf2loc.c: Include dwarf2read.h.
2117         * defs.h (read_unsigned_leb128): Don't declare.
2118         * dwarf2read.h (read_unsigned_leb128): Declare.
2119
2120 2019-05-08  Tom Tromey  <tromey@adacore.com>
2121
2122         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
2123         method.
2124
2125 2019-05-08  Tom Tromey  <tromey@adacore.com>
2126
2127         * utils.c (fputs_maybe_filtered): Reset style after paging, even
2128         when no wrap column is set.
2129
2130 2019-05-08  Tom Tromey  <tromey@adacore.com>
2131
2132         * c-lang.c (c_get_string): Handle non-C-style arrays.
2133
2134 2019-05-08  Tom Tromey  <tromey@adacore.com>
2135
2136         * typeprint.c (print_offset_data::update): Print the bit offset,
2137         not the number of bits remaining.
2138
2139 2019-05-08  Tom Tromey  <tromey@adacore.com>
2140
2141         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
2142         padding at end of comment.
2143
2144 2019-05-08  Tom Tromey  <tromey@adacore.com>
2145
2146         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
2147         Compare main types.
2148
2149 2019-05-06  Tom Tromey  <tom@tromey.com>
2150
2151         * common/scoped_mmap.c: Include common-defs.h.
2152         * common/scoped_mmap.h: Don't include config.h.
2153
2154 2019-05-04  Tom Tromey  <tom@tromey.com>
2155
2156         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
2157         (struct aarch64_call_info): Add initializers.
2158         <si>: Now a std::vector.
2159         (pass_on_stack, aarch64_push_dummy_call): Update.
2160
2161 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
2162             Tom Tromey  <tom@tromey.com>
2163
2164         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
2165         (ppc_threads): Now a std::vector.  Now static.
2166         (hwdebug_find_thread_points_by_tid)
2167         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
2168         Update.
2169
2170 2019-05-04  Tom Tromey  <tom@tromey.com>
2171
2172         * arc-tdep.c (arc_tdesc_init): Return bool.
2173
2174 2019-05-04  Tom Tromey  <tom@tromey.com>
2175
2176         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
2177         Use gdb_assert_not_reached.
2178
2179 2019-05-04  Tom Tromey  <tom@tromey.com>
2180
2181         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
2182         "false".
2183
2184 2019-05-04  Tom Tromey  <tom@tromey.com>
2185
2186         * arc-tdep.c (arc_tdesc_init): Use bool.
2187
2188 2019-05-04  Tom Tromey  <tom@tromey.com>
2189
2190         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
2191
2192 2019-05-04  Tom Tromey  <tom@tromey.com>
2193
2194         * cli/cli-cmds.c (valid_command_p): Return bool.
2195
2196 2019-05-04  Tom Tromey  <tom@tromey.com>
2197
2198         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
2199         * command.h (valid_user_defined_cmd_name_p): Channge return type.
2200
2201 2019-05-04  Raul Tambre  <raul@tambre.ee>
2202
2203         * python/lib/gdb/prompt.py (_ExtendedPrompt)
2204         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
2205         operator for comparison.
2206
2207 2019-05-04  Tom Tromey  <tom@tromey.com>
2208
2209         * psymtab.c (psymbol_name_matches, match_partial_symbol)
2210         (lookup_partial_symbol, print_partial_symbols)
2211         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
2212         (psymbol_compare): Update.
2213         (add_psymbol_to_bcache): Clear the entire psymbol.
2214         (maintenance_check_psymtabs): Update.
2215         * psympriv.h (struct partial_symbol): Don't derive from
2216         general_symbol_info.
2217         <obj_section, unrelocated_address, address,
2218         set_unrelocated_address>: Update.
2219         <ginfo>: New member.
2220         * dwarf-index-write.c (write_psymbols, debug_names::insert)
2221         (debug_names::write_psymbols): Update.
2222
2223 2019-05-04  Tom de Vries  <tdevries@suse.de>
2224
2225         * contrib/cc-with-tweaks.sh: Support -n arg.
2226
2227 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2228
2229         * corelow.c (core_target::detach): Ensure frame cache and
2230         register caches are cleared.
2231         inferior.c (exit_inferior_1): Likewise.
2232
2233 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
2234             Tom Tromey  <tom@tromey.com>
2235
2236         * dictionary.c (collate_pending_symbols_by_language): Remove
2237         "struct" from foreach.
2238         * symtab.c (lookup_global_symbol_from_objfile)
2239         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
2240         foreach.
2241         * ser-tcp.c (net_open): Remove "struct" from foreach.
2242         * objfiles.c (objfile_relocate, objfile_rebase)
2243         (objfile_has_symbols): Remove "struct" from foreach.
2244         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
2245         from foreach.
2246         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
2247         foreach.
2248         * darwin-nat.c (thread_info_from_private_thread_info): Remove
2249         "struct" from foreach.
2250         * ada-lang.c (create_excep_cond_exprs)
2251         (ada_exception_catchpoint_cond_string): Remove "struct" from
2252         foreach.
2253
2254 2019-05-03  Tom Tromey  <tromey@adacore.com>
2255
2256         * ada-exp.y (convert_char_literal): Check suffix of each
2257         enumerator.
2258
2259 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
2260
2261         PR ada/21406:
2262         * ada-exp.y (yywrap): Don't define.
2263         * ada-lex.l (%option): Add noyywrap
2264         (yywrap): Remove.
2265
2266 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
2267
2268         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
2269         _WIN32_WINNT to the XP level, unless already defined to a higher
2270         level.
2271
2272         * unittests/parse-connection-spec-selftests.c:
2273         * ser-tcp.c:
2274         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
2275         override.
2276
2277         * symfile.c (find_separate_debug_file): Remove colon from the
2278         drive spec of DOS/Windows file names of the target, so that the
2279         file name produced from DEBUGDIR and the target's directory will
2280         be valid on DOS/Windows systems.
2281
2282 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * rust-lang.c (val_print_struct): Handle printing structures
2285         containing strings.
2286
2287 2019-05-02  Tom Tromey  <tromey@adacore.com>
2288
2289         * valarith.c (_initialize_valarith): Remove.
2290
2291 2019-05-01  Tom Tromey  <tromey@adacore.com>
2292
2293         * ada-lang.c (ada_value_primitive_field): Treat more fields as
2294         bitfields.
2295
2296 2019-05-01  Tom Tromey  <tromey@adacore.com>
2297
2298         * ada-lang.c (ada_value_assign): Correctly compute starting offset
2299         for big-endian copies.
2300
2301 2019-04-30  Ali Tamur  <tamur@google.com>
2302         * gdb/dwarf2read.c (read_3_bytes): New declaration.
2303         (read_attribute_value): Added DW_FORM_strx1-4 cases.
2304         (read_3_bytes): New function.
2305
2306 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2307
2308         * windows-nat.c (main_thread_id): Delete.
2309         (handle_output_debug_string): Replace main_thread_id by
2310         current_event.dwThreadId.
2311         (fake_create_process): Likewise.
2312         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
2313         Do not set main_thread_id.
2314         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
2315         current_event.dwThreadId.
2316         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
2317
2318 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
2319
2320         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
2321         Use current_event.dwThreadId instead of main_thread_id.
2322
2323 2019-04-30  Tom Tromey  <tromey@adacore.com>
2324
2325         * ada-lang.c (ada_lookup_simple_minsyms): New function.
2326         (create_excep_cond_exprs): Iterate over program spaces.
2327         (ada_exception_catchpoint_cond_string): Examine all minimal
2328         symbols for exception types.
2329
2330 2019-04-30  Tom Tromey  <tromey@adacore.com>
2331
2332         PR c++/24470:
2333         * dwarf2read.c (process_structure_scope): Handle case where type
2334         has template parameters but no symbol was created.
2335
2336 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2337             Chris January  <chris.january@arm.com>
2338
2339         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
2340         qualifier.
2341         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
2342
2343 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2344
2345         * f-typeprint.c (f_print_type): Update rules for printing
2346         whitespace.
2347         (f_type_print_varspec_suffix): Likewise.
2348
2349 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2350             Chris January  <chris.january@arm.com>
2351
2352         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
2353         function arguments.
2354
2355 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2356
2357         * f-lang.c (build_fortran_types): Change name of void type to
2358         lower case.
2359         * f-typeprint.c (f_type_print_base): Print the name of the void
2360         type, rather than a fixed string.
2361         * f-valprint.c (f_decorations): Use lower case void string.
2362
2363 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2364             Chris January  <chris.january@arm.com>
2365
2366         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
2367         types for Fortran.
2368
2369 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2370             Chris January  <chris.january@arm.com>
2371             David Lecomber  <david.lecomber@arm.com>
2372
2373         * f-exp.y (BINOP_INTRINSIC): New token.
2374         (exp): New parser rule handling BINOP_INTRINSIC.
2375         (f77_keywords): Add new builtin procedures.
2376         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
2377         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2378         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
2379         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2380         (print_unop_subexp_f): New function.
2381         (print_binop_subexp_f): New function.
2382         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2383         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
2384         (dump_subexp_body_f): Likewise.
2385         (operator_check_f): Likewise.
2386         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
2387         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
2388
2389 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2390
2391         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
2392         UNOP_KIND.
2393         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
2394         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
2395         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
2396         (operator_length_f): New fuction.
2397         (print_subexp_f): New function.
2398         (op_name_f): New function.
2399         (dump_subexp_body_f): New function.
2400         (operator_check_f): New function.
2401         (exp_descriptor_f): Replace standard expression handling functions
2402         with new functions.
2403         * gdb/fortran-operator.def: New file.
2404         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
2405         * gdb/std-operator.def: Remove UNOP_KIND.
2406
2407 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
2408
2409         * std-operator.def: Remove unbalanced, stray double quote
2410         character.
2411
2412 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2413             Chris January  <chris.january@arm.com>
2414             Daniel Everett  <daniel.everett@arm.com>
2415             Nick Forrington  <nick.forrington@arm.com>
2416             Richard Bunt  <richard.bunt@arm.com>
2417
2418         * cp-valprint.c (cp_print_value_fields): Allow an additional level
2419         of depth when printing anonymous structs or unions.
2420         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
2421         Don't print either the top-level value, or the children if the
2422         max-depth is exceeded.
2423         (ppscm_print_children): When printing the key of a map, allow one
2424         extra level of depth.
2425         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
2426         print either the top-level value, or the children if the max-depth
2427         is exceeded.
2428         (print_children): When printing the key of a map, allow one extra
2429         level of depth.
2430         * python/py-value.c (valpy_format_string): Add max_depth keyword.
2431         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
2432         (user_print_options): Initialise max_depth field.
2433         (val_print_scalar_or_string_type_p): New function.
2434         (val_print): Check to see if the max depth has been reached.
2435         (val_print_check_max_depth): Define new function.
2436         (show_print_max_depth): New function.
2437         (_initialize_valprint): Add 'print max-depth' option.
2438         * valprint.h (struct value_print_options) <max_depth>: New field.
2439         (val_print_check_max_depth): Declare new function.
2440         * NEWS: Document new feature.
2441
2442 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2443
2444         * ada-lang.c (ada_language_defn): Initialise new field.
2445         * c-lang.c (c_is_string_type_p): New function.
2446         (c_language_defn): Initialise new field.
2447         (cplus_language_defn): Initialise new field.
2448         (asm_language_defn): Initialise new field.
2449         (minimal_language_defn): Initialise new field.
2450         * c-lang.h (c_is_string_type_p): Declare new function.
2451         * d-lang.c (d_language_defn): Initialise new field.
2452         * f-lang.c (f_is_string_type_p): New function.
2453         (f_language_defn): Initialise new field.
2454         * go-lang.c (go_is_string_type_p): New function.
2455         (go_language_defn): Initialise new field.
2456         * language.c (default_is_string_type_p): New function.
2457         (unknown_language_defn): Initialise new field.
2458         (auto_language_defn): Initialise new field.
2459         * language.h (struct language_defn) <la_is_string_type_p>: New
2460         member variable.
2461         (default_is_string_type_p): Declare new function.
2462         * m2-lang.c (m2_language_defn): Initialise new field.
2463         * objc-lang.c (objc_language_defn): Initialise new field.
2464         * opencl-lang.c (opencl_language_defn): Initialise new field.
2465         * p-lang.c (pascal_is_string_type_p): New function.
2466         (pascal_language_defn): Initialise new field.
2467         * rust-lang.c (rust_is_string_type_p): New function.
2468         (rust_language_defn): Initialise new field.
2469
2470 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2471
2472         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
2473         New field.
2474         * ada-lang.c (ada_language_defn): Initialise new field.
2475         * c-lang.c (c_language_defn): Likewise.
2476         (cplus_language_defn): Likewise.
2477         (asm_language_defn): Likewise.
2478         (minimal_language_defn): Likewise.
2479         * d-lang.c (d_language_defn): Likewise.
2480         * f-lang.c (f_language_defn): Likewise.
2481         * go-lang.c (go_language_defn): Likewise.
2482         * language.c (unknown_language_defn): Likewise.
2483         (auto_language_defn): Likewise.
2484         * m2-lang.c (m2_language_defn): Likewise.
2485         * objc-lang.c (objc_language_defn): Likewise.
2486         * opencl-lang.c (opencl_language_defn): Likewise.
2487         * p-lang.c (pascal_language_defn): Likewise.
2488         * rust-lang.c (rust_language_defn): Likewise.
2489
2490 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
2491
2492         * ada-lang.c (ada_is_character_type): Change return type to bool.
2493         (ada_is_string_type): Likewise.
2494         * ada-lang.h (ada_is_character_type): Update declaration
2495         (ada_is_string_type): Likewise.
2496
2497 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2498
2499         Support style in 'frame|thread apply'
2500
2501         * gdbcmd.h (execute_command_to_string): New term_out parameter.
2502         * record.c (record_start, record_stop): Update callers of
2503         execute_command_to_string with false.
2504         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
2505         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
2506         methods.
2507         (class string_file): New constructor with term_out parameter.
2508         Override methods term_out and can_emit_style_escape.  New member
2509         term_out.
2510         (class stdio_file): Override can_emit_style_escape.
2511         (class tee_file): Override term_out and can_emit_style_escape.
2512         * utils.h (can_emit_style_escape): Remove.
2513         * utils.c (can_emit_style_escape): Likewise.
2514         Update all callers of can_emit_style_escape (SOMESTREAM) to
2515         SOMESTREAM->can_emit_style_escape.
2516         * source-cache.c (source_cache::get_source_lines): Likewise.
2517         * stack.c (frame_apply_command_count): Call execute_command_to_string
2518         passing the term_out characteristic of the current gdb_stdout.
2519         * thread.c (thr_try_catch_cmd): Likewise.
2520         * top.c (execute_command_to_string): pass term_out parameter
2521         to construct the string_file for the command output.
2522         * ui-file.c (term_cli_styling): New function (most code moved
2523         from utils.c can_emit_style_escape).
2524         (string_file::string_file, string_file::can_emit_style_escape,
2525         stdio_file::can_emit_style_escape, tee_file::term_out,
2526         tee_file::can_emit_style_escape): New functions.
2527
2528 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2529
2530         * NEWS: Mention the new set|show may-call-functions.
2531         * infcall.c (may_call_functions_p): New variable.
2532         (show_may_call_functions_p): New function.
2533         (call_function_by_hand_dummy): Throws an error if not
2534         may-call-functions.
2535         (_initialize_infcall): Call add_setshow_boolean_cmd for
2536         may-call-functions.
2537
2538 2019-04-25  Keith Seitz  <keiths@redhat.com>
2539
2540         PR c++/24367
2541         * cp-support.c (inspect_type): Don't attempt substitutions
2542         of symbol with the same name.
2543
2544 2019-04-25  Tom Tromey  <tromey@adacore.com>
2545
2546         PR gdb/24475:
2547         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2548         static.
2549
2550 2019-04-25  Tom Tromey  <tromey@adacore.com>
2551
2552         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2553         rvalue reference.
2554         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2555         (gdb_xml_parser::parse): Use std::move.
2556         * python/python-internal.h (gdbpy_convert_exception): Take a const
2557         reference.
2558         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2559         std::move.
2560         * python/py-utils.c (gdbpy_convert_exception): Take a const
2561         reference.
2562         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2563         Use std::move.
2564         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2565         Use std::move.
2566         * mi/mi-main.c (mi_print_exception): Take a const reference.
2567         * main.c (handle_command_errors): Take a const reference.
2568         * linespec.c (parse_linespec): Use std::move.
2569         * infcall.c (run_inferior_call): Use std::move.
2570         (call_function_by_hand_dummy): Use std::move.
2571         * exec.c (try_open_exec_file): Use std::move.
2572         * exceptions.h (exception_print, exception_fprintf)
2573         (exception_print_same): Update.
2574         * exceptions.c (print_exception, exception_print)
2575         (exception_fprintf, exception_print_same): Change parameters to
2576         const reference.
2577         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2578         * common/new-op.c: Use std::move.
2579         * common/common-exceptions.h (struct gdb_exception): Add move
2580         constructor.
2581         (struct gdb_exception_error, struct gdb_exception_quit, struct
2582         gdb_quit_bad_alloc): Change constructor to move constructor.
2583         (throw_exception): Change parameter to rvalue reference.
2584         * common/common-exceptions.c (throw_exception): Take rvalue
2585         reference.
2586         * cli/cli-interp.c (safe_execute_command): Use std::move.
2587         * breakpoint.c (insert_bp_location, location_to_sals): Use
2588         std::move.
2589
2590 2019-04-25  Tom Tromey  <tromey@adacore.com>
2591
2592         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2593         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2594         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2595         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2596         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2597         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2598         guile/scm-value.c: Use unpack.
2599         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2600         gdbscm_gdb_exception.
2601         (gdbscm_throw_gdb_exception): Likewise.
2602         (struct gdbscm_gdb_exception): New.
2603         (unpack): New function.
2604         (gdbscm_wrap): Use unpack.
2605
2606 2019-04-25  Tom Tromey  <tromey@adacore.com>
2607
2608         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2609         (gdb_rl_callback_handler): Use std::move.
2610         * common/common-exceptions.h (struct gdb_exception): Add move
2611         assignment operator.
2612         (throw_exception_sjlj): Change "exception" to const reference.
2613         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2614         (throw_exception_sjlj): Change "exception" to const reference.
2615
2616 2019-04-25  Tom Tromey  <tromey@adacore.com>
2617
2618         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2619         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2620         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2621         Update.
2622         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2623         Update.
2624         * mi/mi-interp.c (mi_interp::exec): Update.
2625         * linespec.c (parse_linespec): Update.
2626         * infcall.c (run_inferior_call): Update.
2627         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2628         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2629         (gdbscm_lookup_global_symbol): Update.
2630         * guile/scm-param.c (gdbscm_parameter_value): Update.
2631         * guile/scm-frame.c (gdbscm_frame_read_register)
2632         (gdbscm_frame_read_var): Update.
2633         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2634         * exec.c (try_open_exec_file): Update.
2635         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2636         (gdb_rl_callback_handler): Update.
2637         * common/common-exceptions.h (exception_none): Don't declare.
2638         * common/common-exceptions.c (exception_none): Don't define.
2639         (struct catcher) <exception>: Update.
2640         * cli/cli-interp.c (safe_execute_command): Update.
2641         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2642
2643 2019-04-25  Ali Tamur  <tamur@google.com>
2644
2645         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2646         (read_attribute_value): Likewise.
2647         (dwarf2_read_addr_index): Update comment.
2648         (read_str_index): Add DW_FORM_strx.
2649         (dwarf2_string_attr): Likewise.
2650         (dwarf2_const_value_attr): Likewise.
2651         (dump_die_shallow): Likewise.
2652         (dwarf2_fetch_constant_bytes): Likewise.
2653         (skip_form_bytes): Likewise.
2654         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2655
2656 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2657
2658         PR corefiles/11608
2659         PR corefiles/18187
2660         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2661         OFFSET.  Verify if current mapping contains an ELF header.
2662         (linux_find_memory_regions_full): Adjust call to
2663         dump_mapping_p.
2664
2665 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2666             Kang Li <kanglictf@gmail.com>
2667
2668         PR gdb/21600
2669
2670         * dwarf2-frame.c (read_initial_length): Be consistent about using
2671         unsigned representation of length.
2672         (decode_frame_entry_1): Likewise.  Check for wraparound of
2673         end pointer as well as buffer overflow.
2674
2675 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2676
2677         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2678         "vq".
2679
2680 2019-04-24  Tom Tromey  <tromey@adacore.com>
2681
2682         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2683
2684 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2685
2686         * s12z-tdep.c (s12z_unwind_pc): Delete.
2687         (s12z_unwind_sp): Delete.
2688         (s12z_gdbarch_init): Don't register deleted functions with
2689         gdbarch.
2690
2691 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2692
2693         * rl78-tdep.c (rl78_unwind_sp): Delete.
2694         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2695
2696 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2697
2698         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2699         (xstormy16_unwind_pc): Delete.
2700         (xstormy16_dummy_id): Delete.
2701         (xstormy16_gdbarch_init): Don't register deleted functions with
2702         gdbarch.
2703
2704 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2705
2706         * vax-tdep.c (vax_unwind_pc): Delete.
2707         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2708
2709 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2710
2711         * v850-tdep.c (v850_unwind_sp): Delete.
2712         (v850_unwind_pc): Delete.
2713         (v850_dummy_id): Delete.
2714         (v850_gdbarch_init): Don't register deleted functions with
2715         gdbarch.
2716
2717 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2718
2719         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2720         (tilegx_unwind_pc): Delete.
2721         (tilegx_unwind_dummy_id): Delete.
2722         (tilegx_gdbarch_init): Don't register deleted functions with
2723         gdbarch.
2724
2725 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2726
2727         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2728         (tic6x_dummy_id): Delete.
2729         (tic6x_gdbarch_init): Don't register deleted functions with
2730         gdbarch.
2731
2732 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2733
2734         * sparc-tdep.c (sparc_unwind_pc): Delete.
2735         (sparc32_gdbarch_init): Don't register deleted function with
2736         gdbarch.
2737
2738 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2739
2740         * sh-tdep.c (sh_unwind_sp): Delete.
2741         (sh_unwind_pc): Delete.
2742         (sh_dummy_id): Delete.
2743         (sh_gdbarch_init): Don't register deleted functions with
2744         gdbarch.
2745
2746 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2747
2748         * score-tdep.c (score_unwind_sp): Delete.
2749         (score_unwind_pc): Delete.
2750         (score_dummy_id): Delete.
2751         (score_gdbarch_init): Don't register deleted functions with
2752         gdbarch.
2753
2754 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2755
2756         * rx-tdep.c (rx_unwind_pc): Delete.
2757         (rx_unwind_sp): Delete.
2758         (rx_dummy_id): Delete.
2759         (rx_gdbarch_init): Don't register deleted functions with
2760         gdbarch.  Update comment.
2761
2762 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2763
2764         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2765         (rs6000_dummy_id): Delete.
2766         (rs6000_gdbarch_init): Don't register deleted functions with
2767         gdbarch.
2768
2769 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2770
2771         * or1k-tdep.c (or1k_dummy_id): Delete.
2772         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2773
2774 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2775
2776         * nios2-tdep.c (nios2_dummy_id): Delete.
2777         (nios2_unwind_sp): Delete.
2778         (nios2_gdbarch_init): Don't register deleted functions with
2779         gdbarch.
2780
2781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2782
2783         * nds32-tdep.c (nds32_dummy_id): Delete.
2784         (nds32_unwind_pc): Delete.
2785         (nds32_unwind_sp): Delete.
2786         (nds32_gdbarch_init): Don't register deleted functions with
2787         gdbarch.
2788
2789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2790
2791         * msp430-tdep.c (msp430_unwind_pc): Delete.
2792         (msp430_unwind_sp): Delete.
2793         (msp430_dummy_id): Delete.
2794         (msp430_gdbarch_init): Don't register deleted functions with
2795         gdbarch.
2796
2797 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2798
2799         * moxie-tdep.c (moxie_unwind_sp): Delete.
2800         (moxie_unwind_pc): Delete.
2801         (moxie_dummy_id): Delete.
2802         (moxie_gdbarch_init): Don't register deleted functions with
2803         gdbarch.
2804
2805 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2806
2807         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2808         (mn10300_unwind_pc): Delete.
2809         (mn10300_unwind_sp): Delete.
2810         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2811         mn10300_unwind_sp.
2812         (mn10300_frame_unwind_init): Don't register deleted functions with
2813         gdbarch.
2814
2815 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2816
2817         * mep-tdep.c (mep_unwind_pc): Delete.
2818         (mep_unwind_sp): Delete.
2819         (mep_dummy_id): Delete.
2820         (mep_gdbarch_init): Don't register deleted functions with
2821         gdbarch.
2822
2823 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2824
2825         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2826         (m68hc11_unwind_sp): Delete.
2827         (m68hc11_gdbarch_init): Don't register deleted functions with
2828         gdbarch.
2829
2830 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2831
2832         * m32r-tdep.c (m32r_unwind_sp): Delete.
2833         (m32r_unwind_pc): Delete.
2834         (m32r_dummy_id): Delete.
2835         (m32r_gdbarch_init): Don't register deleted functions with
2836         gdbarch.
2837
2838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2839
2840         * m32c-tdep.c (m32c_unwind_pc): Delete.
2841         (m32c_unwind_sp): Delete.
2842         (m32c_dummy_id): Delete.
2843         (m32c_gdbarch_init): Don't register deleted functions with
2844         gdbarch.
2845
2846 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2847
2848         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2849         (lm32_unwind_pc): Delete.
2850         (lm32_dummy_id): Delete.
2851         (lm32_gdbarch_init): Don't register deleted functions with
2852         gdbarch.
2853
2854 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2855
2856         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2857         (iq2000_unwind_pc): Delete.
2858         (iq2000_dummy_id): Delete.
2859         (iq2000_gdbarch_init): Don't register deleted functions with
2860         gdbarch.
2861
2862 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2863
2864         * nds32-tdep.c (nds32_type_align): Delete.
2865         (nds32_push_dummy_call): Use type_align instead.
2866
2867 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2868
2869         * arm-tdep.c (arm_type_align): Only handle vector override case.
2870         (arm_push_dummy_call): Use type_align.
2871         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2872
2873 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2874
2875         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2876         case.
2877         (pass_on_stack): Use type_align.
2878         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2879         function.
2880
2881 2019-04-23  Tom Tromey  <tromey@adacore.com>
2882
2883         * dwarf2read.c (line_header::file_name_at): Remove unused
2884         overload.
2885
2886 2019-04-23  Tom de Vries  <tdevries@suse.de>
2887
2888         PR gdb/24438
2889         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2890         invocation.
2891
2892
2893 2019-03-27  Ali Tamur  <tamur@google.com>
2894
2895         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2896         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2897         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2898         (dwarf_expr_context::get_addr_index): Likewise
2899         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2900         (symbol_needs_eval_context::get_addr_index): Likewise
2901         (disassemble_dwarf_expression): Add DW_OP_addrx
2902         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2903         (read_cutu_die_from_dwo): Update comment
2904         (skip_one_die): Add DW_FORM_addrx
2905         (read_attribute_value): Likewise
2906         (var_decode_location): Add DW_OP_addrx
2907         (dwarf2_const_value_attr): Add DW_FORM_addrx
2908         (dump_die_shallow): Likewise
2909         (dwarf2_fetch_constant_bytes): Likewise
2910         (decode_locdesc): Add DW_OP_addrx
2911         (skip_form_bytes): Add DW_FORM_addrx
2912
2913 2019-04-22  Ali Tamur  <tamur@google.com>
2914
2915         * MAINTAINERS (Write After Approval): Add self.
2916
2917 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2918
2919         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2920         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2921         (open_symbol_file_object): Likewise.
2922         (svr4_default_sos): Add info parameter.
2923         (svr4_read_so_list): Likewise.
2924         (svr4_current_sos_direct): Adjust functions calls to pass down
2925         info.
2926         (svr4_current_sos_1): Add info parameter.
2927         (svr4_current_sos): Call get_svr4_info, pass info down to
2928         svr4_current_sos_1.
2929         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2930         get_svr4_info.
2931         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2932         get_svr4_info.
2933         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2934         to get_svr4_info.
2935         (probes_table_remove_objfile_probes): Likewise.
2936         (register_solib_event_probe): Add info parameter.
2937         (solist_update_incremental): Pass info parameter down to
2938         svr4_read_so_list.
2939         (disable_probes_interface): Add info parameter.
2940         (svr4_handle_solib_event): Pass current_program_space to
2941         get_svr4_info.  Adjust disable_probes_interface cleanup.
2942         (svr4_create_probe_breakpoints): Add info parameter, pass it
2943         down to register_solib_event_probe.
2944         (svr4_create_solib_event_breakpoints): Add info parameter,
2945         pass it down to svr4_create_probe_breakpoints.
2946         (enable_break): Pass info down to
2947         svr4_create_solib_event_breakpoints.
2948         (svr4_solib_create_inferior_hook): Pass current_program_space to
2949         get_svr4_info.
2950         (svr4_clear_solib): Likewise.
2951
2952 2019-04-22  Pedro Alves  <palves@redhat.com>
2953
2954         * solib-svr4.c (svr4_free_objfile_observer): New.
2955         (probe_and_action::objfile): New field.
2956         (probes_table_htab_remove_objfile_probes)
2957         (probes_table_remove_objfile_probes): New functions.
2958         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2959         in the new probe_and_action.  Don't store the probe in 'lookup'.
2960         (svr4_create_probe_breakpoints): Pass objfile to
2961         register_solib_event_probe.
2962         (_initialize_svr4_solib): Register a free_objfile observer.
2963
2964 2019-04-19  Tom Tromey  <tom@tromey.com>
2965
2966         * common/queue.h: Remove.
2967
2968 2019-04-19  Tom Tromey  <tom@tromey.com>
2969
2970         * event-loop.c: Don't include "common/queue.h".
2971
2972 2019-04-19  Tom Tromey  <tom@tromey.com>
2973
2974         * remote.c (remote_target): Use delete.
2975         * remote-notif.h: Include <list>, not "common/queue.h".
2976         (notif_client_p): Remove typedef.
2977         (remote_notif_state): Add constructor, destructor, initializer.
2978         <notif_queue>: Now a std::list.
2979         (remote_notif_state_xfree): Don't declare.
2980         * remote-notif.c (remote_notif_process, handle_notification)
2981         (remote_notif_state_allocate): Update.
2982         (~remote_notif_state): Rename from remote_notif_state_xfree.
2983
2984 2019-04-19  Tom Tromey  <tom@tromey.com>
2985
2986         * symfile.c (reread_symbols): Update.
2987         * objfiles.c (objfile_register_static_link)
2988         (objfile_lookup_static_link): Update
2989         (~objfile) Don't delete static_links.
2990         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2991
2992 2019-04-19  Tom Tromey  <tom@tromey.com>
2993
2994         * type-stack.h (struct type_stack) <insert>: Constify string.
2995         * type-stack.c (type_stack::insert): Constify string.
2996         * gdbtypes.h (lookup_template_type): Update.
2997         (address_space_name_to_int): Update.
2998         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2999         const.
3000         (lookup_template_type): Make name const.
3001         * c-exp.y: Update rules.
3002         (lex_one_token, classify_name, classify_inner_name)
3003         (c_print_token): Update.
3004         * p-exp.y: Update rules.
3005         (yylex): Update.
3006         * f-exp.y: Update rules.
3007         (yylex): Update.
3008         * d-exp.y: Update rules.
3009         (lex_one_token, classify_name, classify_inner_name): Update.
3010         * parse.c (write_dollar_variable, copy_name): Return std::string.
3011         * parser-defs.h (copy_name): Change return type.
3012         * m2-exp.y: Update rules.
3013         (yylex): Update.
3014         * go-exp.y (lex_one_token): Update.
3015         Update rules.
3016         (classify_unsafe_function, classify_packaged_name)
3017         (classify_name, yylex): Update.
3018
3019 2019-04-19  Sergei Trofimovich <siarheit@google.com>
3020
3021         * configure.ac: add --enable-source-highlight switch.
3022         * configure: Regenerate.
3023         * top.c (print_gdb_version): plumb --enable-source-highlight
3024         status to "show configuration".
3025
3026 2019-04-19  Tom Tromey  <tromey@adacore.com>
3027
3028         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
3029         Check ADA_TYPE_P.
3030         (empty_record, ada_template_to_fixed_record_type_1)
3031         (template_to_static_fixed_type)
3032         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
3033         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
3034         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
3035         macros.
3036
3037 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
3038
3039         PR symtab/24423:
3040         * source.c (print_source_lines_base): Advance "iter" when a
3041         control character is seen.
3042
3043 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3044
3045         * inferior.h (struct infcall_suspend_state_deleter):
3046         Catch exception in destructor to avoid crash.
3047
3048 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3049
3050         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
3051         close to the add_com "shell".
3052
3053 2019-04-18  Tom Tromey  <tromey@adacore.com>
3054
3055         * process-stratum-target.h (class process_stratum_target)
3056         <stratum>: Add "final".
3057
3058 2019-04-17  Tom Tromey  <tromey@adacore.com>
3059
3060         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
3061         against nullptr before use.
3062
3063 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
3064
3065         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
3066
3067 2019-04-17  Jim Wilson  <jimw@sifive.com>
3068             Andrew Burgess  <andrew.burgess@embecosm.com>
3069
3070         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
3071         code read might fail, assume 4-byte breakpoint in that case.
3072
3073 2019-04-15  Leszek Swirski  <leszeks@google.com>
3074
3075         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
3076         rather than a hand-rolled POD check when checking for forced MEMORY
3077         classification.
3078
3079 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3080
3081         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
3082         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
3083         function.
3084         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
3085         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
3086         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
3087         declaration.
3088
3089 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3090
3091         * aarch64-linux-nat.c
3092         (aarch64_linux_nat_target::thread_architecture): Add override.
3093         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
3094         each VQ.
3095
3096 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
3097
3098         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
3099
3100 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
3101
3102         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
3103         target types of size 96-bits, add some additional comments, and
3104         check that the builtin type we found was the correct size.
3105
3106 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
3107
3108         * utils.c (prompt_for_continue): Don't restore the styling at the
3109         end, as applied_style has the wrong value.  This fixes styling in
3110         long lists of file names that are interrupted by the "Continue?"
3111         prompt.
3112
3113 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
3114
3115         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
3116         * c-lang.c (c_language_defn): Likewise.
3117         (cplus_language_defn): Likewise.
3118         (asm_language_defn): Likewise.
3119         (minimal_language_defn): Likewise.
3120         * d-lang.c (d_language_defn): Likewise.
3121         * f-lang.c (f_language_defn): Likewise.
3122         * go-lang.c (go_language_defn): Likewise.
3123         * language.c (unknown_language_defn): Likewise.
3124         (auto_language_defn): Likewise.
3125         * language.h (struct language_defn): Remove la_magic field.
3126         (LANG_MAGIC): Delete.
3127         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
3128         * objc-lang.c (objc_language_defn): Likewise.
3129         * opencl-lang.c (opencl_language_defn): Likewise.
3130         * p-lang.c (pascal_language_defn): Likewise.
3131         * rust-lang.c (rust_language_defn): Likewise.
3132
3133 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3134
3135         * riscv-tdep.c (riscv_type_align): New function.
3136         (riscv_type_alignment): Delete.
3137         (riscv_arg_location): Use 'type_align'.
3138         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
3139
3140 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3141
3142         * gdbtypes.c (type_align): A struct with no non-static fields also
3143         has alignment of 1.
3144
3145 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3146
3147         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
3148         component to 0.
3149         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
3150         member.
3151         (riscv_struct_info::analyse): New implementation using new
3152         analyse_inner member function.
3153         (riscv_struct_info::field_offset): New member function.
3154         (riscv_struct_info::m_offsets): New member variable.
3155         (riscv_struct_info::analyse_inner): New private member function,
3156         takes the old implementation of riscv_struct_info::analyse but
3157         extended to track field offsets.
3158         (riscv_call_arg_struct): Update the struct folding special cases
3159         to handle cases where empty C++ structs, which are non-zero
3160         length, are found.
3161         (riscv_arg_location): Initialise the length of each location, a
3162         non-zero length now indicates the location is in use.
3163         (riscv_push_dummy_call): Allow for the first location having a
3164         non-zero offset when setting up arguments.
3165         (riscv_return_value): Likewise, but for return values.
3166
3167 2019-04-11  Tom Tromey  <tromey@adacore.com>
3168
3169         * utils.c (internal_vproblem): Make "msg" const.
3170
3171 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
3172
3173         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
3174         * trad-frame.c (trad_frame_reset_saved_regs): New function.
3175         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
3176         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
3177
3178 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
3179
3180         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
3181         function.
3182         (fill_gregset): Call amd64_linux_collect_native_gregset instead
3183         of amd64_collect_native_gregset.
3184         (amd64_linux_nat_target::store_registers): Likewise.
3185
3186 2019-04-10  Tom Tromey  <tom@tromey.com>
3187
3188         * symtab.c (lookup_global_symbol_from_objfile)
3189         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
3190         * objfiles.h (class separate_debug_iterator): New.
3191         (class separate_debug_range): New.
3192         (struct objfile) <separate_debug_objfiles>: New method.
3193         (objfile_separate_debug_iterate): Don't declare.
3194         * objfiles.c (separate_debug_iterator::operator++): Rename from
3195         objfile_separate_debug_iterate.
3196         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
3197         iterator.
3198         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
3199         iterator.
3200
3201 2019-04-10  Tom Tromey  <tom@tromey.com>
3202
3203         * symfile.c (reread_symbols): Remove old comment.
3204         * objfiles.c (free_all_objfiles): Fix a typo.
3205
3206 2019-04-10  Tom Tromey  <tom@tromey.com>
3207
3208         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
3209         * minsyms.c (lookup_minimal_symbol): Use foreach.
3210         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
3211         (lookup_minimal_symbol_solib_trampoline): Likewise.
3212         * symfile.c (reread_symbols): Use foreach.
3213
3214 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
3215             Tom Tromey  <tromey@adacore.com>
3216
3217         PR rust/24414:
3218         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
3219         (rust_lex_int_test): Change "value" to be LONGEST.
3220         (rust_lex_tests): Add test for long integer literal.
3221
3222 2019-04-09  Tom Tromey  <tromey@adacore.com>
3223
3224         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
3225         to bool.
3226         (extended_remote_target::attach): Update.
3227         (remote_target::remote_notice_new_inferior): Update.
3228         (remote_target::add_current_inferior_and_thread): Update.
3229         * inferior.c (exit_inferior_1): Use "false".
3230         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
3231
3232 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
3233
3234         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
3235         the "start" command.
3236
3237 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3238
3239         * python/py-inferior.c (infpy_thread_from_thread_handle):
3240         Adjust comments to reflect renaming of thread_from_thread_handle
3241         to thread_from_handle.  Adjust keywords.  Fix type error message.
3242         (inferior_object_methods): Add thread_from_handle.  Retain
3243         thread_from_thread_handle, but mark it as deprecated.
3244
3245 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3246
3247         * gdbthread.h (find_thread_by_handle): Revise declaration.
3248         * thread.c (find_thread_by_handle): Likewise.  Adjust
3249         implementation too.
3250         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
3251         support for buffer objects as handles.
3252
3253 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3254
3255         * python/py-infthread.c (thpy_thread_handle): New function.
3256         (thread_object_methods): Register thpy_thread_handle.
3257
3258 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
3259
3260         * gdbthread.h (thread_to_thread_handle): Declare.
3261         * thread.c (gdbtypes.h): Include.
3262         (thread_to_thread_handle): New function.
3263
3264         * target.h (struct target_ops): Add thread_info_to_thread_handle.
3265         (target_thread_info_to_thread_handle): Declare.
3266         * target.c (target_thread_info_to_thread_handle): New function.
3267         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
3268         * target-delegates.c: Regenerate.
3269
3270         * linux-thread-db.c (class thread_db_target): Add method
3271         thread_info_to_thread_handle.
3272         (thread_db_target::thread_info_to_thread_handle): Define.
3273         * remote.c (class remote_target): Add new method
3274         thread_info_to_thread_handle.
3275         (remote_target::thread_info_to_thread_handle): Define.
3276
3277 2019-04-08  Pedro Alves  <palves@redhat.com>
3278
3279         * common/common-exceptions.c (throw_exception): Don't create
3280         named object to throw; throw directly.
3281         (throw_it): Likewise.  Don't initialize gdb_exception::message
3282         here, with new; pass FMT and AP to the ctor instead.
3283         * common/common-exceptions.h: Include <string>.
3284         (gdb_exception::gdb_exception(enum return_reason, enum errors,
3285         const char *, va_list)): New ctor.  Use std::make_shared.
3286         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
3287         errors)): Delete.
3288         (gdb_exception_error::gdb_exception_error(enum errors, const char
3289         *, va_list)): New.
3290         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
3291         Add assertion.
3292         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
3293         errors)): Delete.
3294         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
3295         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
3296         Add assertion.
3297
3298 2019-04-08  Tom Tromey  <tom@tromey.com>
3299
3300         * valops.c (value_rtti_indirect_type): Replace throw_exception
3301         with throw.
3302         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
3303         with throw.
3304         * thread.c (thr_try_catch_cmd): Replace throw_exception with
3305         throw.
3306         * target.c (target_translate_tls_address): Replace throw_exception
3307         with throw.
3308         * stack.c (frame_apply_command_count): Replace throw_exception
3309         with throw.
3310         * solib-spu.c (append_ocl_sos): Replace throw_exception with
3311         throw.
3312         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
3313         with throw.
3314         * rs6000-tdep.c (rs6000_frame_cache)
3315         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
3316         * remote.c: Replace throw_exception with throw.
3317         * record-full.c (record_full_message, record_full_wait_1)
3318         (record_full_restore): Replace throw_exception with throw.
3319         * record-btrace.c:
3320         (get_thread_current_frame_id, record_btrace_start_replaying)
3321         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
3322         (cmd_record_btrace_start): Replace throw_exception with throw.
3323         * parse.c (parse_exp_in_context_1): Replace throw_exception with
3324         throw.
3325         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
3326         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
3327         * linespec.c:
3328         (find_linespec_symbols): Replace throw_exception with throw.
3329         * infrun.c (displaced_step_prepare, resume): Replace
3330         throw_exception with throw.
3331         * infcmd.c (post_create_inferior): Replace throw_exception with
3332         throw.
3333         * inf-loop.c (inferior_event_handler): Replace throw_exception
3334         with throw.
3335         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
3336         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
3337         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
3338         (get_prev_frame_always, get_frame_pc_if_available)
3339         (get_frame_address_in_block_if_available, get_frame_language):
3340         Replace throw_exception with throw.
3341         * frame-unwind.c (frame_unwind_try_unwinder): Replace
3342         throw_exception with throw.
3343         * eval.c (fetch_subexp_value, evaluate_var_value)
3344         (evaluate_funcall, evaluate_subexp_standard): Replace
3345         throw_exception with throw.
3346         * dwarf2loc.c (call_site_find_chain)
3347         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
3348         Replace throw_exception with throw.
3349         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
3350         with throw.
3351         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
3352         throw.
3353         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
3354         * completer.c (complete_line_internal): Replace throw_exception
3355         with throw.
3356         * compile/compile-object-run.c (compile_object_run): Replace
3357         throw_exception with throw.
3358         * cli/cli-script.c (process_next_line): Replace throw_exception
3359         with throw.
3360         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
3361         (btrace_enable, btrace_maint_update_pt_packets): Replace
3362         throw_exception with throw.
3363         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
3364         throw_exception with throw.
3365         * break-catch-throw.c (re_set_exception_catchpoint): Replace
3366         throw_exception with throw.
3367         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
3368         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
3369         * aarch64-tdep.c (aarch64_make_prologue_cache)
3370         (aarch64_make_stub_cache): Replace throw_exception with throw.
3371
3372 2019-04-08  Tom Tromey  <tom@tromey.com>
3373
3374         * common/common-exceptions.c (throw_exception): Rename from
3375         throw_exception_cxx.  Remove old copy.  Make argument const.
3376         (throw_it): Create and throw exception objects directly.
3377         * common/common-exceptions.h (throw_exception): Make argument
3378         const.
3379         (struct gdb_exception_error): Add constructor.
3380         (struct gdb_exception_quit): Add constructor.
3381
3382 2019-04-08  Tom Tromey  <tom@tromey.com>
3383
3384         * common/common-exceptions.h (exception_rethrow): Don't declare.
3385         (TRY_SJLJ): Update comment.
3386         (TRY, CATCH, END_CATCH): Remove.
3387         * common/common-exceptions.c (exception_rethrow): Remove.
3388
3389 2019-04-08  Tom Tromey  <tom@tromey.com>
3390
3391         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
3392         Remove.
3393         (gdb_exception_error): Rename from
3394         gdb_exception_RETURN_MASK_ERROR.
3395         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
3396         (gdb_quit_bad_alloc): Update.
3397         * aarch64-tdep.c: Update.
3398         * ada-lang.c: Update.
3399         * ada-typeprint.c: Update.
3400         * ada-valprint.c: Update.
3401         * amd64-tdep.c: Update.
3402         * arch-utils.c: Update.
3403         * break-catch-throw.c: Update.
3404         * breakpoint.c: Update.
3405         * btrace.c: Update.
3406         * c-varobj.c: Update.
3407         * cli/cli-cmds.c: Update.
3408         * cli/cli-interp.c: Update.
3409         * cli/cli-script.c: Update.
3410         * common/common-exceptions.c: Update.
3411         * common/new-op.c: Update.
3412         * common/selftest.c: Update.
3413         * compile/compile-c-symbols.c: Update.
3414         * compile/compile-cplus-symbols.c: Update.
3415         * compile/compile-object-load.c: Update.
3416         * compile/compile-object-run.c: Update.
3417         * completer.c: Update.
3418         * corelow.c: Update.
3419         * cp-abi.c: Update.
3420         * cp-support.c: Update.
3421         * cp-valprint.c: Update.
3422         * darwin-nat.c: Update.
3423         * disasm-selftests.c: Update.
3424         * dtrace-probe.c: Update.
3425         * dwarf-index-cache.c: Update.
3426         * dwarf-index-write.c: Update.
3427         * dwarf2-frame-tailcall.c: Update.
3428         * dwarf2-frame.c: Update.
3429         * dwarf2loc.c: Update.
3430         * dwarf2read.c: Update.
3431         * eval.c: Update.
3432         * event-loop.c: Update.
3433         * event-top.c: Update.
3434         * exec.c: Update.
3435         * f-valprint.c: Update.
3436         * fbsd-tdep.c: Update.
3437         * frame-unwind.c: Update.
3438         * frame.c: Update.
3439         * gdbtypes.c: Update.
3440         * gnu-v3-abi.c: Update.
3441         * guile/guile-internal.h: Update.
3442         * guile/scm-block.c: Update.
3443         * guile/scm-breakpoint.c: Update.
3444         * guile/scm-cmd.c: Update.
3445         * guile/scm-disasm.c: Update.
3446         * guile/scm-frame.c: Update.
3447         * guile/scm-lazy-string.c: Update.
3448         * guile/scm-math.c: Update.
3449         * guile/scm-param.c: Update.
3450         * guile/scm-ports.c: Update.
3451         * guile/scm-pretty-print.c: Update.
3452         * guile/scm-symbol.c: Update.
3453         * guile/scm-symtab.c: Update.
3454         * guile/scm-type.c: Update.
3455         * guile/scm-value.c: Update.
3456         * i386-linux-tdep.c: Update.
3457         * i386-tdep.c: Update.
3458         * inf-loop.c: Update.
3459         * infcall.c: Update.
3460         * infcmd.c: Update.
3461         * infrun.c: Update.
3462         * jit.c: Update.
3463         * language.c: Update.
3464         * linespec.c: Update.
3465         * linux-fork.c: Update.
3466         * linux-nat.c: Update.
3467         * linux-tdep.c: Update.
3468         * linux-thread-db.c: Update.
3469         * main.c: Update.
3470         * mi/mi-cmd-break.c: Update.
3471         * mi/mi-cmd-stack.c: Update.
3472         * mi/mi-interp.c: Update.
3473         * mi/mi-main.c: Update.
3474         * objc-lang.c: Update.
3475         * p-valprint.c: Update.
3476         * parse.c: Update.
3477         * ppc-linux-tdep.c: Update.
3478         * printcmd.c: Update.
3479         * python/py-arch.c: Update.
3480         * python/py-breakpoint.c: Update.
3481         * python/py-cmd.c: Update.
3482         * python/py-finishbreakpoint.c: Update.
3483         * python/py-frame.c: Update.
3484         * python/py-framefilter.c: Update.
3485         * python/py-gdb-readline.c: Update.
3486         * python/py-inferior.c: Update.
3487         * python/py-infthread.c: Update.
3488         * python/py-lazy-string.c: Update.
3489         * python/py-linetable.c: Update.
3490         * python/py-objfile.c: Update.
3491         * python/py-param.c: Update.
3492         * python/py-prettyprint.c: Update.
3493         * python/py-progspace.c: Update.
3494         * python/py-record-btrace.c: Update.
3495         * python/py-record.c: Update.
3496         * python/py-symbol.c: Update.
3497         * python/py-type.c: Update.
3498         * python/py-unwind.c: Update.
3499         * python/py-utils.c: Update.
3500         * python/py-value.c: Update.
3501         * python/python.c: Update.
3502         * record-btrace.c: Update.
3503         * record-full.c: Update.
3504         * remote-fileio.c: Update.
3505         * remote.c: Update.
3506         * riscv-tdep.c: Update.
3507         * rs6000-aix-tdep.c: Update.
3508         * rs6000-tdep.c: Update.
3509         * rust-exp.y: Update.
3510         * rust-lang.c: Update.
3511         * s390-tdep.c: Update.
3512         * selftest-arch.c: Update.
3513         * solib-dsbt.c: Update.
3514         * solib-frv.c: Update.
3515         * solib-spu.c: Update.
3516         * solib-svr4.c: Update.
3517         * solib.c: Update.
3518         * sparc64-linux-tdep.c: Update.
3519         * stack.c: Update.
3520         * symfile-mem.c: Update.
3521         * symmisc.c: Update.
3522         * target.c: Update.
3523         * thread.c: Update.
3524         * top.c: Update.
3525         * tracefile-tfile.c: Update.
3526         * tui/tui.c: Update.
3527         * typeprint.c: Update.
3528         * unittests/cli-utils-selftests.c: Update.
3529         * unittests/parse-connection-spec-selftests.c: Update.
3530         * valops.c: Update.
3531         * valprint.c: Update.
3532         * value.c: Update.
3533         * varobj.c: Update.
3534         * windows-nat.c: Update.
3535         * x86-linux-nat.c: Update.
3536         * xml-support.c: Update.
3537
3538 2019-04-08  Tom Tromey  <tom@tromey.com>
3539
3540         * xml-support.c: Use C++ exception handling.
3541         * x86-linux-nat.c: Use C++ exception handling.
3542         * windows-nat.c: Use C++ exception handling.
3543         * varobj.c: Use C++ exception handling.
3544         * value.c: Use C++ exception handling.
3545         * valprint.c: Use C++ exception handling.
3546         * valops.c: Use C++ exception handling.
3547         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3548         handling.
3549         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3550         * typeprint.c: Use C++ exception handling.
3551         * tui/tui.c: Use C++ exception handling.
3552         * tracefile-tfile.c: Use C++ exception handling.
3553         * top.c: Use C++ exception handling.
3554         * thread.c: Use C++ exception handling.
3555         * target.c: Use C++ exception handling.
3556         * symmisc.c: Use C++ exception handling.
3557         * symfile-mem.c: Use C++ exception handling.
3558         * stack.c: Use C++ exception handling.
3559         * sparc64-linux-tdep.c: Use C++ exception handling.
3560         * solib.c: Use C++ exception handling.
3561         * solib-svr4.c: Use C++ exception handling.
3562         * solib-spu.c: Use C++ exception handling.
3563         * solib-frv.c: Use C++ exception handling.
3564         * solib-dsbt.c: Use C++ exception handling.
3565         * selftest-arch.c: Use C++ exception handling.
3566         * s390-tdep.c: Use C++ exception handling.
3567         * rust-lang.c: Use C++ exception handling.
3568         * rust-exp.y: Use C++ exception handling.
3569         * rs6000-tdep.c: Use C++ exception handling.
3570         * rs6000-aix-tdep.c: Use C++ exception handling.
3571         * riscv-tdep.c: Use C++ exception handling.
3572         * remote.c: Use C++ exception handling.
3573         * remote-fileio.c: Use C++ exception handling.
3574         * record-full.c: Use C++ exception handling.
3575         * record-btrace.c: Use C++ exception handling.
3576         * python/python.c: Use C++ exception handling.
3577         * python/py-value.c: Use C++ exception handling.
3578         * python/py-utils.c: Use C++ exception handling.
3579         * python/py-unwind.c: Use C++ exception handling.
3580         * python/py-type.c: Use C++ exception handling.
3581         * python/py-symbol.c: Use C++ exception handling.
3582         * python/py-record.c: Use C++ exception handling.
3583         * python/py-record-btrace.c: Use C++ exception handling.
3584         * python/py-progspace.c: Use C++ exception handling.
3585         * python/py-prettyprint.c: Use C++ exception handling.
3586         * python/py-param.c: Use C++ exception handling.
3587         * python/py-objfile.c: Use C++ exception handling.
3588         * python/py-linetable.c: Use C++ exception handling.
3589         * python/py-lazy-string.c: Use C++ exception handling.
3590         * python/py-infthread.c: Use C++ exception handling.
3591         * python/py-inferior.c: Use C++ exception handling.
3592         * python/py-gdb-readline.c: Use C++ exception handling.
3593         * python/py-framefilter.c: Use C++ exception handling.
3594         * python/py-frame.c: Use C++ exception handling.
3595         * python/py-finishbreakpoint.c: Use C++ exception handling.
3596         * python/py-cmd.c: Use C++ exception handling.
3597         * python/py-breakpoint.c: Use C++ exception handling.
3598         * python/py-arch.c: Use C++ exception handling.
3599         * printcmd.c: Use C++ exception handling.
3600         * ppc-linux-tdep.c: Use C++ exception handling.
3601         * parse.c: Use C++ exception handling.
3602         * p-valprint.c: Use C++ exception handling.
3603         * objc-lang.c: Use C++ exception handling.
3604         * mi/mi-main.c: Use C++ exception handling.
3605         * mi/mi-interp.c: Use C++ exception handling.
3606         * mi/mi-cmd-stack.c: Use C++ exception handling.
3607         * mi/mi-cmd-break.c: Use C++ exception handling.
3608         * main.c: Use C++ exception handling.
3609         * linux-thread-db.c: Use C++ exception handling.
3610         * linux-tdep.c: Use C++ exception handling.
3611         * linux-nat.c: Use C++ exception handling.
3612         * linux-fork.c: Use C++ exception handling.
3613         * linespec.c: Use C++ exception handling.
3614         * language.c: Use C++ exception handling.
3615         * jit.c: Use C++ exception handling.
3616         * infrun.c: Use C++ exception handling.
3617         * infcmd.c: Use C++ exception handling.
3618         * infcall.c: Use C++ exception handling.
3619         * inf-loop.c: Use C++ exception handling.
3620         * i386-tdep.c: Use C++ exception handling.
3621         * i386-linux-tdep.c: Use C++ exception handling.
3622         * guile/scm-value.c: Use C++ exception handling.
3623         * guile/scm-type.c: Use C++ exception handling.
3624         * guile/scm-symtab.c: Use C++ exception handling.
3625         * guile/scm-symbol.c: Use C++ exception handling.
3626         * guile/scm-pretty-print.c: Use C++ exception handling.
3627         * guile/scm-ports.c: Use C++ exception handling.
3628         * guile/scm-param.c: Use C++ exception handling.
3629         * guile/scm-math.c: Use C++ exception handling.
3630         * guile/scm-lazy-string.c: Use C++ exception handling.
3631         * guile/scm-frame.c: Use C++ exception handling.
3632         * guile/scm-disasm.c: Use C++ exception handling.
3633         * guile/scm-cmd.c: Use C++ exception handling.
3634         * guile/scm-breakpoint.c: Use C++ exception handling.
3635         * guile/scm-block.c: Use C++ exception handling.
3636         * guile/guile-internal.h: Use C++ exception handling.
3637         * gnu-v3-abi.c: Use C++ exception handling.
3638         * gdbtypes.c: Use C++ exception handling.
3639         * frame.c: Use C++ exception handling.
3640         * frame-unwind.c: Use C++ exception handling.
3641         * fbsd-tdep.c: Use C++ exception handling.
3642         * f-valprint.c: Use C++ exception handling.
3643         * exec.c: Use C++ exception handling.
3644         * event-top.c: Use C++ exception handling.
3645         * event-loop.c: Use C++ exception handling.
3646         * eval.c: Use C++ exception handling.
3647         * dwarf2read.c: Use C++ exception handling.
3648         * dwarf2loc.c: Use C++ exception handling.
3649         * dwarf2-frame.c: Use C++ exception handling.
3650         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3651         * dwarf-index-write.c: Use C++ exception handling.
3652         * dwarf-index-cache.c: Use C++ exception handling.
3653         * dtrace-probe.c: Use C++ exception handling.
3654         * disasm-selftests.c: Use C++ exception handling.
3655         * darwin-nat.c: Use C++ exception handling.
3656         * cp-valprint.c: Use C++ exception handling.
3657         * cp-support.c: Use C++ exception handling.
3658         * cp-abi.c: Use C++ exception handling.
3659         * corelow.c: Use C++ exception handling.
3660         * completer.c: Use C++ exception handling.
3661         * compile/compile-object-run.c: Use C++ exception handling.
3662         * compile/compile-object-load.c: Use C++ exception handling.
3663         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3664         * compile/compile-c-symbols.c: Use C++ exception handling.
3665         * common/selftest.c: Use C++ exception handling.
3666         * common/new-op.c: Use C++ exception handling.
3667         * cli/cli-script.c: Use C++ exception handling.
3668         * cli/cli-interp.c: Use C++ exception handling.
3669         * cli/cli-cmds.c: Use C++ exception handling.
3670         * c-varobj.c: Use C++ exception handling.
3671         * btrace.c: Use C++ exception handling.
3672         * breakpoint.c: Use C++ exception handling.
3673         * break-catch-throw.c: Use C++ exception handling.
3674         * arch-utils.c: Use C++ exception handling.
3675         * amd64-tdep.c: Use C++ exception handling.
3676         * ada-valprint.c: Use C++ exception handling.
3677         * ada-typeprint.c: Use C++ exception handling.
3678         * ada-lang.c: Use C++ exception handling.
3679         * aarch64-tdep.c: Use C++ exception handling.
3680
3681 2019-04-08  Tom Tromey  <tom@tromey.com>
3682
3683         * xml-support.c (gdb_xml_parser::parse): Update.
3684         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3685         * value.c (show_convenience): Update.
3686         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3687         (test_parse_flags_qcs): Update.
3688         * thread.c (thr_try_catch_cmd): Update.
3689         * target.c (target_translate_tls_address): Update.
3690         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3691         (info_frame_command_core, frame_apply_command_count): Update.
3692         * rust-exp.y (rust_lex_exception_test): Update.
3693         * riscv-tdep.c (riscv_print_one_register_info): Update.
3694         * remote.c (remote_target::enable_btrace): Update.
3695         * record-btrace.c (record_btrace_enable_warn): Update.
3696         * python/py-utils.c (gdbpy_convert_exception): Update.
3697         * printcmd.c (do_one_display, print_variable_and_value): Update.
3698         * mi/mi-main.c (mi_print_exception): Update.
3699         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3700         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3701         * linux-nat.c (linux_nat_target::attach): Update.
3702         * linux-fork.c (class scoped_switch_fork_info): Update.
3703         * infrun.c (displaced_step_prepare): Update.
3704         * infcall.c (call_function_by_hand_dummy): Update.
3705         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3706         * gnu-v3-abi.c (print_one_vtable): Update.
3707         * frame.c (get_prev_frame_always): Update.
3708         * f-valprint.c (info_common_command_for_block): Update.
3709         * exec.c (try_open_exec_file): Update.
3710         * exceptions.c (print_exception, exception_print)
3711         (exception_fprintf, exception_print_same): Update.
3712         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3713         * dwarf-index-cache.c (index_cache::store)
3714         (index_cache::lookup_gdb_index): Update.
3715         * darwin-nat.c (maybe_cache_shell): Update.
3716         * cp-valprint.c (cp_print_value_fields): Update.
3717         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3718         (gcc_cplus_symbol_address): Update.
3719         * compile/compile-c-symbols.c (gcc_convert_symbol)
3720         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3721         * common/selftest.c: Update.
3722         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3723         a std::string.
3724         (exception_try_scope_entry, exception_try_scope_exit): Don't
3725         declare.
3726         (struct exception_try_scope): Remove.
3727         (TRY): Don't use exception_try_scope.
3728         (struct gdb_exception): Add constructor, operator=.
3729         <what>: New method.
3730         (struct gdb_exception_RETURN_MASK_ALL)
3731         (struct gdb_exception_RETURN_MASK_ERROR)
3732         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3733         (struct gdb_quit_bad_alloc): Update.
3734         * common/common-exceptions.c (exception_none): Change
3735         initializer.
3736         (struct catcher) <state, exception>: Initialize inline.
3737         <prev>: Remove member.
3738         (current_catcher): Remove.
3739         (catchers): New global.
3740         (exceptions_state_mc_init): Simplify.
3741         (catcher_pop): Remove.
3742         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3743         (try_scope_depth, exception_try_scope_entry)
3744         (exception_try_scope_exit): Remove.
3745         (throw_exception_sjlj): Update.
3746         (exception_messages, exception_messages_size): Remove.
3747         (throw_it): Simplify.
3748         (gdb_exception_sliced_copy): Remove.
3749         (throw_exception_cxx): Update.
3750         * cli/cli-script.c (script_from_file): Update.
3751         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3752         Update.
3753         * ada-valprint.c (ada_val_print): Update.
3754         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3755         (create_excep_cond_exprs): Update.
3756
3757 2019-04-08  Tom Tromey  <tom@tromey.com>
3758
3759         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3760         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3761         (TRY, CATCH, END_CATCH): Remove some definitions.
3762         * common/common-exceptions.c: Don't use GDB_XCPT.
3763         (catcher_list_size): Remove.
3764         (throw_exception, throw_it): Simplify.
3765
3766 2019-04-05  Tom Tromey  <tom@tromey.com>
3767
3768         Revert the header-sorting patch.
3769         * ft32-tdep.c: Revert.
3770         * frv-tdep.c: Revert.
3771         * frv-linux-tdep.c: Revert.
3772         * frame.c: Revert.
3773         * frame-unwind.c: Revert.
3774         * frame-base.c: Revert.
3775         * fork-child.c: Revert.
3776         * findvar.c: Revert.
3777         * findcmd.c: Revert.
3778         * filesystem.c: Revert.
3779         * filename-seen-cache.h: Revert.
3780         * filename-seen-cache.c: Revert.
3781         * fbsd-tdep.c: Revert.
3782         * fbsd-nat.h: Revert.
3783         * fbsd-nat.c: Revert.
3784         * f-valprint.c: Revert.
3785         * f-typeprint.c: Revert.
3786         * f-lang.c: Revert.
3787         * extension.h: Revert.
3788         * extension.c: Revert.
3789         * extension-priv.h: Revert.
3790         * expprint.c: Revert.
3791         * exec.h: Revert.
3792         * exec.c: Revert.
3793         * exceptions.c: Revert.
3794         * event-top.c: Revert.
3795         * event-loop.c: Revert.
3796         * eval.c: Revert.
3797         * elfread.c: Revert.
3798         * dwarf2read.h: Revert.
3799         * dwarf2read.c: Revert.
3800         * dwarf2loc.c: Revert.
3801         * dwarf2expr.h: Revert.
3802         * dwarf2expr.c: Revert.
3803         * dwarf2-frame.c: Revert.
3804         * dwarf2-frame-tailcall.c: Revert.
3805         * dwarf-index-write.h: Revert.
3806         * dwarf-index-write.c: Revert.
3807         * dwarf-index-common.c: Revert.
3808         * dwarf-index-cache.h: Revert.
3809         * dwarf-index-cache.c: Revert.
3810         * dummy-frame.c: Revert.
3811         * dtrace-probe.c: Revert.
3812         * disasm.h: Revert.
3813         * disasm.c: Revert.
3814         * disasm-selftests.c: Revert.
3815         * dictionary.c: Revert.
3816         * dicos-tdep.c: Revert.
3817         * demangle.c: Revert.
3818         * dcache.h: Revert.
3819         * dcache.c: Revert.
3820         * darwin-nat.h: Revert.
3821         * darwin-nat.c: Revert.
3822         * darwin-nat-info.c: Revert.
3823         * d-valprint.c: Revert.
3824         * d-namespace.c: Revert.
3825         * d-lang.c: Revert.
3826         * ctf.c: Revert.
3827         * csky-tdep.c: Revert.
3828         * csky-linux-tdep.c: Revert.
3829         * cris-tdep.c: Revert.
3830         * cris-linux-tdep.c: Revert.
3831         * cp-valprint.c: Revert.
3832         * cp-support.c: Revert.
3833         * cp-namespace.c: Revert.
3834         * cp-abi.c: Revert.
3835         * corelow.c: Revert.
3836         * corefile.c: Revert.
3837         * continuations.c: Revert.
3838         * completer.h: Revert.
3839         * completer.c: Revert.
3840         * complaints.c: Revert.
3841         * coffread.c: Revert.
3842         * coff-pe-read.c: Revert.
3843         * cli-out.h: Revert.
3844         * cli-out.c: Revert.
3845         * charset.c: Revert.
3846         * c-varobj.c: Revert.
3847         * c-valprint.c: Revert.
3848         * c-typeprint.c: Revert.
3849         * c-lang.c: Revert.
3850         * buildsym.c: Revert.
3851         * buildsym-legacy.c: Revert.
3852         * build-id.h: Revert.
3853         * build-id.c: Revert.
3854         * btrace.c: Revert.
3855         * bsd-uthread.c: Revert.
3856         * breakpoint.h: Revert.
3857         * breakpoint.c: Revert.
3858         * break-catch-throw.c: Revert.
3859         * break-catch-syscall.c: Revert.
3860         * break-catch-sig.c: Revert.
3861         * blockframe.c: Revert.
3862         * block.c: Revert.
3863         * bfin-tdep.c: Revert.
3864         * bfin-linux-tdep.c: Revert.
3865         * bfd-target.c: Revert.
3866         * bcache.c: Revert.
3867         * ax-general.c: Revert.
3868         * ax-gdb.h: Revert.
3869         * ax-gdb.c: Revert.
3870         * avr-tdep.c: Revert.
3871         * auxv.c: Revert.
3872         * auto-load.c: Revert.
3873         * arm-wince-tdep.c: Revert.
3874         * arm-tdep.c: Revert.
3875         * arm-symbian-tdep.c: Revert.
3876         * arm-pikeos-tdep.c: Revert.
3877         * arm-obsd-tdep.c: Revert.
3878         * arm-nbsd-tdep.c: Revert.
3879         * arm-nbsd-nat.c: Revert.
3880         * arm-linux-tdep.c: Revert.
3881         * arm-linux-nat.c: Revert.
3882         * arm-fbsd-tdep.c: Revert.
3883         * arm-fbsd-nat.c: Revert.
3884         * arm-bsd-tdep.c: Revert.
3885         * arch-utils.c: Revert.
3886         * arc-tdep.c: Revert.
3887         * arc-newlib-tdep.c: Revert.
3888         * annotate.h: Revert.
3889         * annotate.c: Revert.
3890         * amd64-windows-tdep.c: Revert.
3891         * amd64-windows-nat.c: Revert.
3892         * amd64-tdep.c: Revert.
3893         * amd64-sol2-tdep.c: Revert.
3894         * amd64-obsd-tdep.c: Revert.
3895         * amd64-obsd-nat.c: Revert.
3896         * amd64-nbsd-tdep.c: Revert.
3897         * amd64-nbsd-nat.c: Revert.
3898         * amd64-nat.c: Revert.
3899         * amd64-linux-tdep.c: Revert.
3900         * amd64-linux-nat.c: Revert.
3901         * amd64-fbsd-tdep.c: Revert.
3902         * amd64-fbsd-nat.c: Revert.
3903         * amd64-dicos-tdep.c: Revert.
3904         * amd64-darwin-tdep.c: Revert.
3905         * amd64-bsd-nat.c: Revert.
3906         * alpha-tdep.c: Revert.
3907         * alpha-obsd-tdep.c: Revert.
3908         * alpha-nbsd-tdep.c: Revert.
3909         * alpha-mdebug-tdep.c: Revert.
3910         * alpha-linux-tdep.c: Revert.
3911         * alpha-linux-nat.c: Revert.
3912         * alpha-bsd-tdep.c: Revert.
3913         * alpha-bsd-nat.c: Revert.
3914         * aix-thread.c: Revert.
3915         * agent.c: Revert.
3916         * addrmap.c: Revert.
3917         * ada-varobj.c: Revert.
3918         * ada-valprint.c: Revert.
3919         * ada-typeprint.c: Revert.
3920         * ada-tasks.c: Revert.
3921         * ada-lang.c: Revert.
3922         * aarch64-tdep.c: Revert.
3923         * aarch64-ravenscar-thread.c: Revert.
3924         * aarch64-newlib-tdep.c: Revert.
3925         * aarch64-linux-tdep.c: Revert.
3926         * aarch64-linux-nat.c: Revert.
3927         * aarch64-fbsd-tdep.c: Revert.
3928         * aarch64-fbsd-nat.c: Revert.
3929         * aarch32-linux-nat.c: Revert.
3930
3931 2019-04-05  Tom Tromey  <tom@tromey.com>
3932
3933         * ft32-tdep.c: Sort headers.
3934         * frv-tdep.c: Sort headers.
3935         * frv-linux-tdep.c: Sort headers.
3936         * frame.c: Sort headers.
3937         * frame-unwind.c: Sort headers.
3938         * frame-base.c: Sort headers.
3939         * fork-child.c: Sort headers.
3940         * findvar.c: Sort headers.
3941         * findcmd.c: Sort headers.
3942         * filesystem.c: Sort headers.
3943         * filename-seen-cache.h: Sort headers.
3944         * filename-seen-cache.c: Sort headers.
3945         * fbsd-tdep.c: Sort headers.
3946         * fbsd-nat.h: Sort headers.
3947         * fbsd-nat.c: Sort headers.
3948         * f-valprint.c: Sort headers.
3949         * f-typeprint.c: Sort headers.
3950         * f-lang.c: Sort headers.
3951         * extension.h: Sort headers.
3952         * extension.c: Sort headers.
3953         * extension-priv.h: Sort headers.
3954         * expprint.c: Sort headers.
3955         * exec.h: Sort headers.
3956         * exec.c: Sort headers.
3957         * exceptions.c: Sort headers.
3958         * event-top.c: Sort headers.
3959         * event-loop.c: Sort headers.
3960         * eval.c: Sort headers.
3961         * elfread.c: Sort headers.
3962         * dwarf2read.h: Sort headers.
3963         * dwarf2read.c: Sort headers.
3964         * dwarf2loc.c: Sort headers.
3965         * dwarf2expr.h: Sort headers.
3966         * dwarf2expr.c: Sort headers.
3967         * dwarf2-frame.c: Sort headers.
3968         * dwarf2-frame-tailcall.c: Sort headers.
3969         * dwarf-index-write.h: Sort headers.
3970         * dwarf-index-write.c: Sort headers.
3971         * dwarf-index-common.c: Sort headers.
3972         * dwarf-index-cache.h: Sort headers.
3973         * dwarf-index-cache.c: Sort headers.
3974         * dummy-frame.c: Sort headers.
3975         * dtrace-probe.c: Sort headers.
3976         * disasm.h: Sort headers.
3977         * disasm.c: Sort headers.
3978         * disasm-selftests.c: Sort headers.
3979         * dictionary.c: Sort headers.
3980         * dicos-tdep.c: Sort headers.
3981         * demangle.c: Sort headers.
3982         * dcache.h: Sort headers.
3983         * dcache.c: Sort headers.
3984         * darwin-nat.h: Sort headers.
3985         * darwin-nat.c: Sort headers.
3986         * darwin-nat-info.c: Sort headers.
3987         * d-valprint.c: Sort headers.
3988         * d-namespace.c: Sort headers.
3989         * d-lang.c: Sort headers.
3990         * ctf.c: Sort headers.
3991         * csky-tdep.c: Sort headers.
3992         * csky-linux-tdep.c: Sort headers.
3993         * cris-tdep.c: Sort headers.
3994         * cris-linux-tdep.c: Sort headers.
3995         * cp-valprint.c: Sort headers.
3996         * cp-support.c: Sort headers.
3997         * cp-namespace.c: Sort headers.
3998         * cp-abi.c: Sort headers.
3999         * corelow.c: Sort headers.
4000         * corefile.c: Sort headers.
4001         * continuations.c: Sort headers.
4002         * completer.h: Sort headers.
4003         * completer.c: Sort headers.
4004         * complaints.c: Sort headers.
4005         * coffread.c: Sort headers.
4006         * coff-pe-read.c: Sort headers.
4007         * cli-out.h: Sort headers.
4008         * cli-out.c: Sort headers.
4009         * charset.c: Sort headers.
4010         * c-varobj.c: Sort headers.
4011         * c-valprint.c: Sort headers.
4012         * c-typeprint.c: Sort headers.
4013         * c-lang.c: Sort headers.
4014         * buildsym.c: Sort headers.
4015         * buildsym-legacy.c: Sort headers.
4016         * build-id.h: Sort headers.
4017         * build-id.c: Sort headers.
4018         * btrace.c: Sort headers.
4019         * bsd-uthread.c: Sort headers.
4020         * breakpoint.h: Sort headers.
4021         * breakpoint.c: Sort headers.
4022         * break-catch-throw.c: Sort headers.
4023         * break-catch-syscall.c: Sort headers.
4024         * break-catch-sig.c: Sort headers.
4025         * blockframe.c: Sort headers.
4026         * block.c: Sort headers.
4027         * bfin-tdep.c: Sort headers.
4028         * bfin-linux-tdep.c: Sort headers.
4029         * bfd-target.c: Sort headers.
4030         * bcache.c: Sort headers.
4031         * ax-general.c: Sort headers.
4032         * ax-gdb.h: Sort headers.
4033         * ax-gdb.c: Sort headers.
4034         * avr-tdep.c: Sort headers.
4035         * auxv.c: Sort headers.
4036         * auto-load.c: Sort headers.
4037         * arm-wince-tdep.c: Sort headers.
4038         * arm-tdep.c: Sort headers.
4039         * arm-symbian-tdep.c: Sort headers.
4040         * arm-pikeos-tdep.c: Sort headers.
4041         * arm-obsd-tdep.c: Sort headers.
4042         * arm-nbsd-tdep.c: Sort headers.
4043         * arm-nbsd-nat.c: Sort headers.
4044         * arm-linux-tdep.c: Sort headers.
4045         * arm-linux-nat.c: Sort headers.
4046         * arm-fbsd-tdep.c: Sort headers.
4047         * arm-fbsd-nat.c: Sort headers.
4048         * arm-bsd-tdep.c: Sort headers.
4049         * arch-utils.c: Sort headers.
4050         * arc-tdep.c: Sort headers.
4051         * arc-newlib-tdep.c: Sort headers.
4052         * annotate.h: Sort headers.
4053         * annotate.c: Sort headers.
4054         * amd64-windows-tdep.c: Sort headers.
4055         * amd64-windows-nat.c: Sort headers.
4056         * amd64-tdep.c: Sort headers.
4057         * amd64-sol2-tdep.c: Sort headers.
4058         * amd64-obsd-tdep.c: Sort headers.
4059         * amd64-obsd-nat.c: Sort headers.
4060         * amd64-nbsd-tdep.c: Sort headers.
4061         * amd64-nbsd-nat.c: Sort headers.
4062         * amd64-nat.c: Sort headers.
4063         * amd64-linux-tdep.c: Sort headers.
4064         * amd64-linux-nat.c: Sort headers.
4065         * amd64-fbsd-tdep.c: Sort headers.
4066         * amd64-fbsd-nat.c: Sort headers.
4067         * amd64-dicos-tdep.c: Sort headers.
4068         * amd64-darwin-tdep.c: Sort headers.
4069         * amd64-bsd-nat.c: Sort headers.
4070         * alpha-tdep.c: Sort headers.
4071         * alpha-obsd-tdep.c: Sort headers.
4072         * alpha-nbsd-tdep.c: Sort headers.
4073         * alpha-mdebug-tdep.c: Sort headers.
4074         * alpha-linux-tdep.c: Sort headers.
4075         * alpha-linux-nat.c: Sort headers.
4076         * alpha-bsd-tdep.c: Sort headers.
4077         * alpha-bsd-nat.c: Sort headers.
4078         * aix-thread.c: Sort headers.
4079         * agent.c: Sort headers.
4080         * addrmap.c: Sort headers.
4081         * ada-varobj.c: Sort headers.
4082         * ada-valprint.c: Sort headers.
4083         * ada-typeprint.c: Sort headers.
4084         * ada-tasks.c: Sort headers.
4085         * ada-lang.c: Sort headers.
4086         * aarch64-tdep.c: Sort headers.
4087         * aarch64-ravenscar-thread.c: Sort headers.
4088         * aarch64-newlib-tdep.c: Sort headers.
4089         * aarch64-linux-tdep.c: Sort headers.
4090         * aarch64-linux-nat.c: Sort headers.
4091         * aarch64-fbsd-tdep.c: Sort headers.
4092         * aarch64-fbsd-nat.c: Sort headers.
4093         * aarch32-linux-nat.c: Sort headers.
4094
4095 2019-04-04  Tom Tromey  <tom@tromey.com>
4096
4097         * varobj.c (varobj_create): Update.
4098         * rust-exp.y (struct rust_parser) <update_innermost_block,
4099         lookup_symbol>: New methods.
4100         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
4101         Rename.
4102         (rust_parser::rust_lookup_type)
4103         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4104         * printcmd.c (display_command, do_one_display): Update.
4105         * parser-defs.h (struct parser_state) <parser_state>: Add
4106         "tracker" parameter.
4107         (block_tracker): New member.
4108         (class innermost_block_tracker) <innermost_block_tracker>: Add
4109         "types" parameter.
4110         <reset>: Remove method.
4111         (innermost_block): Don't declare.
4112         (null_post_parser): Update.
4113         * parse.c (innermost_block): Remove global.
4114         (write_dollar_variable): Update.
4115         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
4116         Remove "tracker_types" parameter.
4117         (parse_expression): Add "tracker" parameter.
4118         (parse_expression_for_completion): Update.
4119         (null_post_parser): Add "tracker" parameter.
4120         * p-exp.y: Update rules.
4121         * m2-exp.y: Update rules.
4122         * language.h (struct language_defn) <la_post_parser>: Add
4123         "tracker" parameter.
4124         * go-exp.y: Update rules.
4125         * f-exp.y: Update rules.
4126         * expression.h (parse_expression, parse_exp_1): Add "tracker"
4127         parameter.
4128         * d-exp.y: Update rules.
4129         * c-exp.y: Update rules.
4130         * breakpoint.c (set_breakpoint_condition): Create an
4131         innermost_block_tracker.
4132         (watch_command_1): Likewise.
4133         * ada-lang.c (resolve): Add "tracker" parameter.
4134         (resolve_subexp): Likewise.
4135         * ada-exp.y (write_var_from_sym): Update.
4136
4137 2019-04-04  Tom Tromey  <tom@tromey.com>
4138
4139         * type-stack.h: New file.
4140         * type-stack.c: New file.
4141         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
4142         type-stack.h.
4143         (insert_into_type_stack, insert_type, push_type, push_type_int)
4144         (insert_type_address_space, pop_type, pop_type_int)
4145         (pop_typelist, pop_type_stack, append_type_stack)
4146         (push_type_stack, get_type_stack, push_typelist)
4147         (follow_type_instance_flags, follow_types): Don't declare.
4148         * parse.c (type_stack): Remove global.
4149         (parse_exp_in_context): Update.
4150         (insert_into_type_stack, insert_type, push_type, push_type_int)
4151         (insert_type_address_space, pop_type, pop_type_int)
4152         (pop_typelist, pop_type_stack, append_type_stack)
4153         (push_type_stack, get_type_stack, push_typelist)
4154         (follow_type_instance_flags, follow_types): Remove (moved to
4155         type-stack.c).
4156         * f-exp.y (type_stack): New global.
4157         Update rules.
4158         (push_kind_type, f_parse): Update.
4159         * d-exp.y (type_stack): New global.
4160         Update rules.
4161         (d_parse): Update.
4162         * c-exp.y (struct c_parse_state) <type_stack>: New member.
4163         Update rules.
4164         * Makefile.in (COMMON_SFILES): Add type-stack.c.
4165         (HFILES_NO_SRCDIR): Add type-stack.h.
4166
4167 2019-04-04  Tom Tromey  <tom@tromey.com>
4168
4169         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
4170         (rust_parser::convert_ast_to_expression, rust_parse)
4171         (rust_lex_test_completion, rust_lex_tests): Update.
4172         * parser-defs.h (struct expr_completion_state): New.
4173         (struct parser_state) <parser_state>: Add completion parameter.
4174         <mark_struct_expression, mark_completion_tag>: New methods.
4175         <parse_completion, m_completion_state>: New members.
4176         (prefixify_expression, null_post_parser): Update.
4177         (mark_struct_expression, mark_completion_tag): Don't declare.
4178         * parse.c (parse_completion, expout_last_struct)
4179         (expout_tag_completion_type, expout_completion_name): Remove
4180         globals.
4181         (parser_state::mark_struct_expression)
4182         (parser_state::mark_completion_tag): Now methods.
4183         (prefixify_expression): Add last_struct parameter.
4184         (prefixify_subexp): Likewise.
4185         (parse_exp_1): Update.
4186         (parse_exp_in_context): Add cstate parameter.  Update.
4187         (parse_expression_for_completion): Create an
4188         expr_completion_state.
4189         (null_post_parser): Add "completion" parameter.
4190         * p-exp.y: Update rules.
4191         (yylex): Update.
4192         * language.h (struct language_defn) <la_post_parser>: Add
4193         "completing" parameter.
4194         * go-exp.y: Update rules.
4195         (lex_one_token): Update.
4196         * expression.h (parse_completion): Don't declare.
4197         * d-exp.y: Update rules.
4198         (lex_one_token): Update rules.
4199         * c-exp.y: Update rules.
4200         (lex_one_token): Update.
4201         * ada-lang.c (resolve): Add "parse_completion" parameter.
4202         (resolve_subexp): Likewise.
4203         (ada_resolve_function): Likewise.
4204
4205 2019-04-04  Tom Tromey  <tom@tromey.com>
4206
4207         * parser-defs.h (struct parser_state) <start_arglist,
4208         end_arglist>: New methods.
4209         <arglist_len, m_funcall_chain>: New members.
4210         (arglist_len, start_arglist, end_arglist): Don't declare.
4211         * parse.c (arglist_len, funcall_chain): Remove global.
4212         (start_arglist, end_arglist): Remove functions.
4213         (parse_exp_in_context): Update.
4214         * p-exp.y: Update rules.
4215         * m2-exp.y: Update rules.
4216         * go-exp.y: Update rules.
4217         * f-exp.y: Update rules.
4218         * d-exp.y: Update rules.
4219         * c-exp.y: Update rules.
4220
4221 2019-04-04  Tom Tromey  <tom@tromey.com>
4222
4223         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
4224         lex_operator, push_back>: New methods.
4225         Update all rules.
4226         (rust_parser::lex_hex, lex_escape): Rename and update.
4227         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
4228         (rust_parser::lex_operator): Rename and update.
4229         (rust_parser::lex_number, rustyylex, rustyyerror)
4230         (rust_lex_test_init, rust_lex_test_sequence)
4231         (rust_lex_test_push_back, rust_lex_tests): Update.
4232         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
4233         parameter.
4234         <lexptr, prev_lexptr>: New members.
4235         (lexptr, prev_lexptr): Don't declare.
4236         * parse.c (lexptr, prev_lexptr): Remove globals.
4237         (parse_exp_in_context): Update.
4238         * p-exp.y (yylex, yyerror): Update.
4239         * m2-exp.y (parse_number, yylex, yyerror): Update.
4240         * go-exp.y (lex_one_token, yyerror): Update.
4241         * f-exp.y (match_string_literal, yylex, yyerror): Update.
4242         * d-exp.y (lex_one_token, yyerror): Update.
4243         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
4244         (lex_one_token, yyerror): Update.
4245         * ada-lex.l (YY_INPUT): Update.
4246         (rewind_to_char): Update.
4247         * ada-exp.y (yyerror): Update.
4248
4249 2019-04-04  Tom Tromey  <tom@tromey.com>
4250
4251         * rust-exp.y (rustyylex, rust_lex_tests): Update.
4252         * parser-defs.h (struct parser_state) <parser_state>: Add new
4253         parameter.
4254         <comma_terminates>: New member.
4255         (comma_terminates): Don't declare global.
4256         * parse.c (comma_terminates): Remove global.
4257         (parse_exp_in_context): Update.
4258         * p-exp.y (yylex): Update.
4259         * m2-exp.y (yylex): Update.
4260         * go-exp.y (lex_one_token): Update.
4261         * f-exp.y (yylex): Update.
4262         * d-exp.y (lex_one_token): Update.
4263         * c-exp.y (lex_one_token): Update.
4264         * ada-lex.l: Update.
4265
4266 2019-04-04  Tom Tromey  <tom@tromey.com>
4267
4268         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
4269         (rustyylex, rust_lex_test_init, rust_lex_test_one)
4270         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
4271         * parser-defs.h (paren_depth): Don't declare.
4272         * parse.c (paren_depth): Remove global.
4273         (parse_exp_in_context): Update.
4274         * p-exp.y (paren_depth): New global.
4275         (pascal_parse): Initialize it.
4276         * m2-exp.y (paren_depth): New global.
4277         (m2_parse): Initialize it.
4278         * go-exp.y (paren_depth): New global.
4279         (go_parse): Initialize it.
4280         * f-exp.y (paren_depth): New global.
4281         (f_parse): Initialize it.
4282         * d-exp.y (paren_depth): New global.
4283         (d_parse): Initialize it.
4284         * c-exp.y (paren_depth): New global.
4285         (c_parse): Initialize it.
4286         * ada-lex.l (paren_depth): New global.
4287         (lexer_init): Initialize it.
4288
4289 2019-04-04  Tom Tromey  <tom@tromey.com>
4290
4291         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
4292         (rust_parser::convert_ast_to_type)
4293         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
4294         * parser-defs.h (struct parser_state) <parser_state>: Add
4295         parameters.  Initialize new members.
4296         <expression_context_block, expression_context_pc>: New members.
4297         * parse.c (expression_context_block, expression_context_pc):
4298         Remove globals.
4299         (parse_exp_in_context): Update.
4300         * p-exp.y: Update all rules.
4301         (yylex): Update.
4302         * m2-exp.y: Update all rules.
4303         (yylex): Update.
4304         * go-exp.y (yylex): Update.
4305         * f-exp.y (yylex): Update.
4306         * d-exp.y: Update all rules.
4307         (yylex): Update.
4308         * c-exp.y: Update all rules.
4309         (lex_one_token, classify_name, yylex, c_parse): Update.
4310         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
4311
4312 2019-04-04  Tom Tromey  <tom@tromey.com>
4313
4314         * gdbarch.h, gdbarch.c: Rebuild.
4315         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
4316         * stap-probe.h:
4317         (struct stap_parse_info): Replace "parser_state" with
4318         "expr_builder".
4319         * parser-defs.h (struct expr_builder): Rename from "parser_state".
4320         (parser_state): New class.
4321         * parse.c (expr_builder): Rename.
4322         (expr_builder::release): Rename.
4323         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
4324         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
4325         (write_exp_elt_longcst, write_exp_elt_floatcst)
4326         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
4327         (write_exp_string_vector, write_exp_bitstring)
4328         (write_exp_msymbol, mark_struct_expression)
4329         (write_dollar_variable)
4330         (insert_type_address_space, increase_expout_size): Replace
4331         "parser_state" with "expr_builder".
4332         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
4333         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
4334         "parser_state" with "expr_builder".
4335
4336 2019-04-04  Tom Tromey  <tom@tromey.com>
4337
4338         * rust-exp.y: Replace "parse_language" with method call.
4339         * p-exp.y:
4340         (yylex): Replace "parse_language" with method call.
4341         * m2-exp.y:
4342         (yylex): Replace "parse_language" with method call.
4343         * go-exp.y (classify_name): Replace "parse_language" with method
4344         call.
4345         * f-exp.y (yylex): Replace "parse_language" with method call.
4346         * d-exp.y (lex_one_token): Replace "parse_language" with method
4347         call.
4348         * c-exp.y:
4349         (lex_one_token, classify_name, yylex): Replace "parse_language"
4350         with method call.
4351         * ada-exp.y (find_primitive_type, type_char)
4352         (type_system_address): Replace "parse_language" with method call.
4353
4354 2019-04-04  Tom Tromey  <tom@tromey.com>
4355
4356         * rust-exp.y: Replace "parse_gdbarch" with method call.
4357         * parse.c (write_dollar_variable, insert_type_address_space):
4358         Replace "parse_gdbarch" with method call.
4359         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
4360         call.
4361         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
4362         call.
4363         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
4364         "parse_gdbarch" with method call.
4365         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
4366         with method call.
4367         * f-exp.y (parse_type, parse_f_type, yylex): Replace
4368         "parse_gdbarch" with method call.
4369         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
4370         "parse_gdbarch" with method call.
4371         * c-exp.y (parse_type, parse_number, classify_name): Replace
4372         "parse_gdbarch" with method call.
4373         * ada-lex.l: Replace "parse_gdbarch" with method call.
4374         * ada-exp.y (parse_type, find_primitive_type, type_char)
4375         (type_system_address): Replace "parse_gdbarch" with method call.
4376
4377 2019-04-04  Tom Tromey  <tom@tromey.com>
4378
4379         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
4380         * stap-probe.c (stap_parse_argument): Update.
4381         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
4382         initial_size parameter.
4383         * rust-exp.y (rust_lex_tests): Update.
4384         * parse.c (parser_state): Update.
4385         (parse_exp_in_context): Update.
4386         * parser-defs.h (struct parser_state) <parser_state>: Remove
4387         "initial_size" parameter.
4388
4389 2019-04-04  Tom Tromey  <tom@tromey.com>
4390
4391         * parser-defs.h (increase_expout_size): Don't declare.
4392         * parse.c (increase_expout_size): Now static.
4393
4394 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
4395
4396         * gnu-nat.c (gnu_nat_target::wait): Fix
4397         target_waitstatus_to_string call.
4398
4399 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4400
4401         * eval.c (evaluate_subexp_standard): Handle internal functions
4402         during Fortran function call handling.
4403
4404 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
4405
4406         * NEWS: Mention new internal functions.
4407         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
4408         (read_base_type): Use dwarf2_init_complex_target_type.
4409         * value.c (creal_internal_fn): New function.
4410         (cimag_internal_fn): New function.
4411         (_initialize_values): Register new internal functions.
4412
4413 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4414
4415         * infrun.c (stop_all_threads): If debug_infrun, always
4416         trace the wait status after wait_one, using
4417         target_waitstatus_to_string and target_pid_to_str.
4418         (handle_inferior_event): Replace various trace of
4419         wait status kind by a single trace.
4420         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
4421         wait status kind image by target_waitstatus_to_string.
4422         * target/waitstatus.c (target_waitstatus_to_string): Fix
4423         obsolete comment.
4424
4425 2019-04-01  Tom Tromey  <tromey@adacore.com>
4426
4427         PR symtab/23331:
4428         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
4429
4430 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
4431             Pedro Alves  <palves@redhat.com>
4432
4433         * top.c (quit_force): Call 'finalize_values'.
4434         * value.c (finalize_values): New function.
4435         * value.h (finalize_values): Declare.
4436
4437 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
4438
4439         * NEWS: Announce $_gdb_major and $_gdb_minor.
4440
4441         * top.c (init_gdb_version_vars): New function.
4442         (gdb_init): Call init_gdb_version_vars.
4443
4444 2019-03-29  Tom Tromey  <tromey@adacore.com>
4445
4446         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
4447         help text.  Remove dead code.
4448
4449 2019-03-29  Keith Seitz  <keiths@redhat.com>
4450
4451         From Siddhesh Poyarekar:
4452         * f-lang.h (f77_get_upperbound): Return LONGEST.
4453         (f77_get_lowerbound): Likewise.
4454         * f-typeprint.c (f_type_print_varspec_suffix): Expand
4455         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
4456         print them.
4457         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
4458         plongest to format print it.
4459         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
4460         (f77_get_upperbound): Likewise.
4461         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
4462         LOWER_BOUND to LONGEST.
4463         (f77_create_arrayprint_offset_tbl): Likewise.
4464
4465 2019-03-29  Keith Seitz  <keiths@redhat.com>
4466
4467         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
4468         %s/pulongest for TYPE_LENGTH instead of %d in format
4469         strings.
4470         * ada-typerint.c (ada_print_type): Likewise.
4471         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
4472         * compile/compile-c-support.c (generate_register_struct): Likewise.
4473         * gdbtypes.c (recursive_dump_type): Likewise.
4474         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
4475         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
4476         instead of %d in format strings.
4477         * riscv-tdep.c (riscv_type_alignment): Cast second argument
4478         to std::min to ULONGEST.
4479         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
4480         instead of %d in format strings.
4481         * tracepoint.c (info_scope_command): Likewise.
4482         * typeprint.c (print_offset_data::update)
4483         (print_offset_data::finish): Likewise.
4484         * xtensa-tdep.c (xtensa_store_return_value)
4485         (xtensa_push_dummy_call): Likewise.
4486
4487 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
4488
4489         * windows-nat.c (display_selector): Fixed format specifications
4490         for 64-bit Cygwin.
4491
4492 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4493
4494         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
4495
4496 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
4497
4498         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
4499         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
4500         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
4501         (nios2_linux_init_abi): Install it.
4502
4503 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4504
4505         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
4506
4507 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
4508
4509         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
4510
4511 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4512             Tom Tromey  <tromey@adacore.com>
4513
4514         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
4515
4516 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
4517
4518         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
4519         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
4520         method to compute the bounds of range types. Also print "[evaluated]"
4521         if the bounds' values come from a dynamic evaluation.
4522
4523 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
4524
4525         * cp-valprint.c (cp_print_value_fields): Don't print trailing
4526         whitespace when pretty printing is on.
4527
4528 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4529
4530         * ppc-linux-nat.c: Add include.
4531
4532 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4533
4534         * NEWS: Mention AArch64 Pointer Authentication.
4535
4536 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
4537
4538         * arm-linux-nat.c: Add include.
4539
4540 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4541
4542         * source-cache.c (source_cache::get_source_lines): Re-read
4543         fullname after calling open_source_file.
4544
4545 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4546
4547         * NEWS: Mention TLS support for FreeBSD.
4548
4549 2019-03-25  Tom Tromey  <tromey@adacore.com>
4550
4551         * minsyms.c (BUNCH_SIZE): Update comment.
4552         (~minimal_symbol_reader): Remove old comment.
4553         (compact_minimal_symbols): Update comment.
4554         (minimal_symbol_reader::install): Remove old comment.  Update
4555         other comments.
4556
4557 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4558
4559         * s390-linux-nat.c: Add include.
4560
4561 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4562
4563         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4564         Call linux_get_hwcap.
4565         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4566         Likewise.
4567         (aarch64_linux_get_hwcap): Remove function.
4568         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4569         declaration.
4570         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4571         linux_get_hwcap.
4572         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4573         * linux-tdep.c (linux_get_hwcap): Add function.
4574         (linux_get_hwcap2): Likewise.
4575         * linux-tdep.h (linux_get_hwcap): Add declaration.
4576         (linux_get_hwcap2): Likewise.
4577         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4578         (ppc_linux_get_hwcap2): Likewise.
4579         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4580         linux_get_hwcap.
4581         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4582         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4583         (ppc_linux_nat_target::read_description): Likewise.
4584         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4585         * s390-linux-nat.c: Likewise.
4586         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4587
4588 2019-03-24  Tom Tromey  <tom@tromey.com>
4589
4590         * ada-lang.c (standard_lookup): Simplify initialization.
4591         (ada_lookup_symbol_nonlocal): Simplify return.
4592         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4593         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4594         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4595         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4596         initialization.
4597         * solib.c (solib_global_lookup): Simplify.
4598         * symtab.c (null_block_symbol): Remove.
4599         (symbol_cache_lookup): Simplify returns.
4600         (lookup_language_this): Simplify returns.
4601         (lookup_symbol_aux): Simplify return.
4602         (lookup_local_symbol): Simplify returns.
4603         (lookup_global_symbol_from_objfile): Simplify return.
4604         (lookup_symbol_in_objfile_symtabs)
4605         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4606         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4607         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4608         * cp-namespace.c (cp_lookup_bare_symbol)
4609         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4610         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4611         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4612         (cp_lookup_symbol_via_imports): Simplify initialization.
4613         (find_symbol_in_baseclass): Likewise.
4614         * symtab.h (null_block_symbol): Remove.
4615         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4616         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4617         (d_lookup_symbol_module): Likewise.
4618         (find_symbol_in_baseclass): Simplify initialization.
4619
4620 2019-03-24  Tom Tromey  <tom@tromey.com>
4621
4622         * expression.h: Don't include symtab.h.
4623         (struct block): Forward declare.
4624
4625 2019-03-24  Tom Tromey  <tom@tromey.com>
4626
4627         * c-exp.y (typebase): Remove casts.
4628         * gdbtypes.c (lookup_unsigned_typename, )
4629         (lookup_signed_typename): Remove cast.
4630         * eval.c (parse_to_comma_and_eval): Remove cast.
4631         * parse.c (write_dollar_variable): Remove cast.
4632         * block.h (struct block) <superblock>: Now const.
4633         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4634         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4635         (map_block): Make "block" const.
4636         * symfile.h (struct quick_symbol_functions)
4637         <map_matching_symbols>: Constify block argument to "callback".
4638         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4639         const.
4640         (find_pc_sect_compunit_symtab): Make "b" const.
4641         (find_symbol_at_address): Likewise.
4642         (search_symbols): Likewise.
4643         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4644         (dw2_debug_names_lookup_symbol): Likewise.
4645         (dw2_map_matching_symbols): Update.
4646         * p-valprint.c (pascal_val_print): Remove "block".
4647         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4648         (aux_add_nonlocal_symbols): Make "block" const.
4649         (resolve_subexp): Remove cast.
4650         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4651         const.
4652         (iterate_over_file_blocks): Likewise.
4653         * f-exp.y (%union) <bval>: Remove.
4654         * coffread.c (patch_opaque_types): Make "b" const.
4655         * spu-tdep.c (spu_catch_start): Make "block" const.
4656         * c-valprint.c (print_unpacked_pointer): Remove "block".
4657         * symmisc.c (dump_symtab_1): Make "b" const.
4658         (block_depth): Make "block" const.
4659         * d-exp.y (%union) <bval>: Remove.
4660         * cp-support.h (cp_lookup_rtti_type): Update.
4661         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4662         * psymtab.c (psym_lookup_symbol): Make "block" const.
4663         (maintenance_check_psymtabs): Make "b" const.
4664         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4665         (enumerate_locals, enumerate_args): Update.
4666         * python/py-symtab.c (stpy_global_block): Make "block" const.
4667         (stpy_static_block): Likewise.
4668         * inline-frame.c (block_starting_point_at): Make "new_block"
4669         const.
4670         * block.c (find_block_in_blockvector): Make return type const.
4671         (blockvector_for_pc_sect): Make "b" const.
4672         (find_block_in_blockvector): Make "b" const.
4673
4674 2019-03-23  Tom Tromey  <tom@tromey.com>
4675
4676         * varobj.c (varobj_create): Update.
4677         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4678         * printcmd.c (display_command, do_one_display): Don't reset
4679         innermost_block.
4680         * parser-defs.h (enum innermost_block_tracker_type): Move to
4681         expression.h.
4682         (innermost_block): Update comment.
4683         * parse.c (parse_exp_1): Add tracker_types parameter.
4684         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4685         tracker_types parameter.  Reset innermost_block.
4686         (parse_exp_in_context): Remove.
4687         (parse_expression_for_completion): Update.
4688         * objfiles.c (~objfile): Don't reset expression_context_block or
4689         innermost_block.
4690         * expression.h (enum innermost_block_tracker_type): Move from
4691         parser-defs.h.
4692         (parse_exp_1): Add tracker_types parameter.
4693         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4694         reset innermost_block.
4695
4696 2019-03-23  Tom Tromey  <tom@tromey.com>
4697
4698         * objfiles.h: Include bcache.h.
4699
4700 2019-03-23  Tom Tromey  <tom@tromey.com>
4701
4702         * linespec.c (get_current_search_block): Use
4703         scoped_restore_current_language.
4704         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4705
4706 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4707             Jiong Wang  <jiong.wang@arm.com>
4708
4709         * aarch64-linux-tdep.c
4710         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4711         section.
4712         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4713
4714 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4715             Jiong Wang  <jiong.wang@arm.com>
4716
4717         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4718         instructions.
4719         (aarch64_analyze_prologue_test): Add PACIASP test.
4720         (aarch64_prologue_prev_register): Unmask PC value.
4721
4722 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4723             Jiong Wang  <jiong.wang@arm.com>
4724
4725         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4726         (aarch64_dwarf2_prev_register): Unmask PC value.
4727         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4728         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4729         DW_CFA_AARCH64_negate_ra_state.
4730         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4731
4732 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4733             Jiong Wang  <jiong.wang@arm.com>
4734
4735         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4736         registers.
4737         (aarch64_pseudo_register_name): Likewise.
4738         (aarch64_pseudo_register_type): Likewise.
4739         (aarch64_pseudo_register_reggroup_p): Likewise.
4740         (aarch64_gdbarch_init): Add pauth registers.
4741         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4742         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4743         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4744         (struct gdbarch_tdep): Add regnum for ra_state.
4745
4746 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4747             Jiong Wang  <jiong.wang@arm.com>
4748
4749         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4750
4751 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4752             Jiong Wang  <jiong.wang@arm.com>
4753
4754         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4755         function.
4756         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4757         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4758         (aarch64_gdbarch_init): Add puth registers.
4759         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4760         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4761         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4762
4763 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4764             Jiong Wang  <jiong.wang@arm.com>
4765
4766         * aarch64-linux-nat.c
4767         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4768         * aarch64-linux-tdep.c
4769         (aarch64_linux_core_read_description): Likewise.
4770         (aarch64_linux_get_hwcap): New function.
4771         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4772         (aarch64_linux_get_hwcap): New declaration.
4773
4774 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4775             Jiong Wang  <jiong.wang@arm.com>
4776
4777         * aarch64-linux-nat.c
4778         (aarch64_linux_nat_target::read_description): Add pauth param.
4779         * aarch64-linux-tdep.c
4780         (aarch64_linux_core_read_description): Likewise.
4781         * aarch64-tdep.c (struct target_desc): Add in pauth.
4782         (aarch64_read_description): Add pauth param.
4783         (aarch64_gdbarch_init): Likewise.
4784         * aarch64-tdep.h (aarch64_read_description): Likewise.
4785         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4786         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4787         * features/Makefile: Add new files.
4788         * features/aarch64-pauth.c: New file.
4789         * features/aarch64-pauth.xml: New file.
4790
4791 2019-03-20  Tom Tromey  <tromey@adacore.com>
4792
4793         * infrun.c (handle_inferior_event): Rename from
4794         handle_inferior_event_1.  Create a scoped_value_mark.
4795         (handle_inferior_event): Remove.
4796
4797 2019-03-19  Tom Tromey  <tromey@adacore.com>
4798
4799         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4800         * infrun.h (print_stop_event): Add "displays" parameter.
4801         * infrun.c (print_stop_event): Add "displays" parameter.
4802
4803 2019-03-19  Pedro Alves  <palves@redhat.com>
4804
4805         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4806         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4807         to -1.  Fix TABs vs spaces.
4808         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4809         * tui/tui-out.h (tui_ui_out) Add intro comments.
4810         <m_line, m_start_of_line>: In-class initialize, and add describing
4811         comment.
4812
4813 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4814
4815         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4816         variable names.
4817         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4818
4819 2019-03-18  Pedro Alves  <palves@redhat.com>
4820             Eli Zaretskii <eliz@gnu.org>
4821
4822         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4823         m_line and m_start_of_line.
4824
4825 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4826
4827         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4828         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4829         it returns a newline.  This fixes a regression in TU mode, whereby
4830         the next line is output on the same screen line as the user input.
4831
4832 2019-03-18  Tom Tromey  <tromey@adacore.com>
4833
4834         * minsyms.c (minimal_symbol_reader::install): Remove call to
4835         obstack_blank.
4836
4837 2019-03-18  Pedro Alves  <palves@redhat.com>
4838
4839         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4840         New globals.
4841         (apply_style): New, factored out from ...
4842         (apply_ansi_escape): ... this.  Handle reverse video mode.
4843         (tui_set_reverse_mode): New function.
4844         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4845         * tui/tui-winsource.c (tui_show_source_line): Use
4846         tui_set_reverse_mode instead of setting A_STANDOUT.
4847         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4848         New setter methods.
4849
4850 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4851
4852         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4853         Handle tabs.
4854
4855 2019-03-18  Tom Tromey  <tromey@adacore.com>
4856
4857         * ada-lang.c (empty_array): Add "high" parameter.
4858         (ada_evaluate_subexp): Update.
4859
4860 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4861
4862         * unittests/string_view-selftests.c: Define
4863         _initialize_string_view_selftests unconditionally.
4864
4865 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4866
4867         PR gdb/24350
4868         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4869
4870 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4871
4872         PR gdb/24351
4873         * windows-nat.c (display_selector): Fix format specifiers.
4874
4875 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4876
4877         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4878         tui_refill_source_window instead of tui_refresh_win, to update the
4879         current execution line.  This fixes redisplay of the current line
4880         when stepping through the code with "next" or "step".
4881
4882 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4883
4884         * source-cache.c (source_cache::get_source_lines): Call
4885         find_source_lines to initialize s->nlines.  This fixes vertical
4886         scrolling of TUI source window when the DOWN arrow is pressed.
4887
4888 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4889
4890         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4891         linux-thread-db.c (_initialize_thread_db): Likewise.
4892
4893 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4894
4895         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4896         wclrtoeol in tui_show_source_line".  This reverts changes made in
4897         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4898
4899 2019-03-15  Tom Tromey  <tom@tromey.com>
4900
4901         * symtab.h (struct minimal_symbol): Derive from
4902         general_symbol_info.
4903         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4904         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4905         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4906         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4907         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4908         (MSYMBOL_SEARCH_NAME): Update.
4909         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4910         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4911         * minsyms.c (minimal_symbol_reader::record_full): Update.
4912
4913 2019-03-15  Tom Tromey  <tom@tromey.com>
4914
4915         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4916
4917 2019-03-15  Tom Tromey  <tom@tromey.com>
4918
4919         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4920         unique_xmalloc_ptr.
4921         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4922         Update.
4923         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4924         (build_minimal_symbol_hash_tables)
4925         (minimal_symbol_reader::install): Update.
4926
4927 2019-03-15  Tom Tromey  <tom@tromey.com>
4928
4929         * symtab.c (create_demangled_names_hash): Update.
4930         (symbol_set_names): Update.
4931         * objfiles.h (struct objfile_per_bfd_storage)
4932         <demangled_names_hash>: Now an htab_up.
4933         * objfiles.c (objfile_per_bfd_storage): Simplify.
4934
4935 2019-03-15  Tom Tromey  <tom@tromey.com>
4936
4937         * objfiles.h (struct objfile_per_bfd_storage): Declare
4938         destructor.
4939         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4940         New.
4941         (get_objfile_bfd_data): Use new.  Don't initialize
4942         language_of_main.
4943         (free_objfile_per_bfd_storage): Remove.
4944         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4945
4946 2019-03-15  Tom Tromey  <tom@tromey.com>
4947
4948         * symfile.c (reread_symbols): Update.
4949         * objfiles.c (objfile::objfile): Update.
4950         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4951         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4952         comment.
4953         (minimal_symbol_reader::install): Update.
4954         (terminate_minimal_symbol_table): Remove.
4955         * jit.c (jit_object_close_impl): Update.
4956
4957 2019-03-15  Tom Tromey  <tom@tromey.com>
4958
4959         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4960         initializations.
4961
4962 2019-03-15  Tom Tromey  <tom@tromey.com>
4963
4964         * objfiles.h (struct objfile_per_bfd_storage)
4965         <demangled_hash_languages>: Now a bitset.
4966         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4967         (lookup_minimal_symbol): Update.
4968
4969 2019-03-15  Tom Tromey  <tom@tromey.com>
4970
4971         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4972         Don't return the symbol.
4973         * coffread.c (record_minimal_symbol): Use record_full.
4974
4975 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4976
4977         The MS-Windows port of ncurses fails to switch to a color pair if
4978         one or both of the colors are the implicit default colors.  This
4979         change records the default colors when TUI is initialized, and
4980         then specifies them explicitly when a color pair uses the default
4981         colors.  This allows color styling in TUI mode on MS-Windows.
4982
4983         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4984         ncurses_norm_attr.
4985         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4986         colors in ncurses_norm_attr.
4987         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4988         "none", replace it with the default color recorded in
4989         ncurses_norm_attr.
4990
4991 2019-03-14  Tom Tromey  <tromey@adacore.com>
4992
4993         * source-cache.h (class source_cache) <get_source_lines>: Return
4994         std::string.
4995         * source-cache.c (source_cache::extract_lines): Handle case where
4996         first_pos==npos.  Return std::string.
4997         (source_cache::get_source_lines): Update.
4998
4999 2019-03-14  Tom Tromey  <tromey@adacore.com>
5000
5001         * NEWS: Add item for "style sources" commands.
5002         * source-cache.c (source_cache::get_source_lines): Check
5003         source_styling.
5004         * cli/cli-style.c (source_styling): New global.
5005         (_initialize_cli_style): Add "style sources" commands.
5006         (show_style_sources): New function.
5007         * cli/cli-style.h (source_styling): Declare.
5008
5009 2019-03-14  Pedro Alves  <palves@redhat.com>
5010             Tom Tromey  <tromey@adacore.com>
5011
5012         * tui/tui-winsource.h (tui_refill_source_window): Declare.
5013         * tui/tui-winsource.c (tui_refill_source_window): New function,
5014         from...
5015         (tui_horizontal_source_scroll): ... here.  Move some logic.
5016         * cli/cli-style.c (set_style_enabled): Notify new observable.
5017         * tui/tui-hooks.c (tui_redisplay_source): New function.
5018         (tui_attach_detach_observers): Attach or detach
5019         tui_redisplay_source.
5020         * observable.h (source_styling_changed): New observable.
5021         * observable.c: Define source_styling_changed observable.
5022
5023 2019-03-13  Tom Tromey  <tromey@adacore.com>
5024
5025         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
5026         (i386_gnu_nat_target::store_registers): Update.
5027         * target-debug.h (target_debug_print_std_string): New macro.
5028         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
5029         * windows-tdep.c (display_one_tib): Update.
5030         * tui/tui-stack.c (tui_make_status_line): Update.
5031         * top.c (print_inferior_quit_action): Update.
5032         * thread.c (thr_try_catch_cmd): Update.
5033         (add_thread_with_info): Update.
5034         (thread_target_id_str): Update.
5035         (thr_try_catch_cmd): Update.
5036         (thread_command): Update.
5037         (thread_find_command): Update.
5038         * record-btrace.c (record_btrace_target::info_record)
5039         (record_btrace_resume_thread, record_btrace_target::resume)
5040         (record_btrace_cancel_resume, record_btrace_step_thread)
5041         (record_btrace_target::wait, record_btrace_target::wait)
5042         (record_btrace_target::wait, record_btrace_target::stop): Update.
5043         * progspace.c (print_program_space): Update.
5044         * process-stratum-target.c
5045         (process_stratum_target::thread_address_space): Update.
5046         * linux-fork.c (linux_fork_mourn_inferior)
5047         (detach_checkpoint_command, info_checkpoints_command)
5048         (linux_fork_context): Update.
5049         (linux_fork_detach): Update.
5050         (class scoped_switch_fork_info): Update.
5051         (delete_checkpoint_command): Update.
5052         * infrun.c (follow_fork_inferior): Update.
5053         (follow_fork_inferior): Update.
5054         (proceed_after_vfork_done): Update.
5055         (handle_vfork_child_exec_or_exit): Update.
5056         (follow_exec): Update.
5057         (displaced_step_prepare_throw): Update.
5058         (displaced_step_restore): Update.
5059         (start_step_over): Update.
5060         (resume_1): Update.
5061         (clear_proceed_status_thread): Update.
5062         (proceed): Update.
5063         (print_target_wait_results): Update.
5064         (do_target_wait): Update.
5065         (context_switch): Update.
5066         (stop_all_threads): Update.
5067         (restart_threads): Update.
5068         (finish_step_over): Update.
5069         (handle_signal_stop): Update.
5070         (switch_back_to_stepped_thread): Update.
5071         (keep_going_pass_signal): Update.
5072         (print_exited_reason): Update.
5073         (normal_stop): Update.
5074         * inferior.c (inferior_pid_to_str): Change return type.
5075         (print_selected_inferior): Update.
5076         (add_inferior): Update.
5077         (detach_inferior): Update.
5078         * dummy-frame.c (fprint_dummy_frames): Update.
5079         * dcache.c (dcache_info_1): Update.
5080         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
5081         (btrace_fetch, btrace_clear): Update.
5082         * linux-tdep.c (linux_core_pid_to_str): Change return type.
5083         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
5084         type.
5085         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
5086         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
5087         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
5088         * gdbarch.c, gdbarch.h: Rebuild.
5089         * gdbarch.sh (core_pid_to_str): Change return type.
5090         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
5091         return type.
5092         (windows_nat_target::pid_to_str): Change return type.
5093         (windows_delete_thread): Update.
5094         (windows_nat_target::attach): Update.
5095         (windows_nat_target::files_info): Update.
5096         * target-delegates.c: Rebuild.
5097         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
5098         return type.
5099         (sol_thread_target::pid_to_str): Change return type.
5100         * remote.c (class remote_target) <pid_to_str>: Change return
5101         type.
5102         (remote_target::pid_to_str): Change return type.
5103         (extended_remote_target::attach, remote_target::remote_stop_ns)
5104         (remote_target::remote_notif_remove_queued_reply)
5105         (remote_target::push_stop_reply, remote_target::disable_btrace):
5106         Update.
5107         (extended_remote_target::attach): Update.
5108         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
5109         type.
5110         (gdbsim_target::pid_to_str): Change return type.
5111         * ravenscar-thread.c (struct ravenscar_thread_target)
5112         <pid_to_str>: Change return type.
5113         (ravenscar_thread_target::pid_to_str): Change return type.
5114         * procfs.c (class procfs_target) <pid_to_str>: Change return
5115         type.
5116         (procfs_target::pid_to_str): Change return type.
5117         (procfs_target::attach): Update.
5118         (procfs_target::detach): Update.
5119         (procfs_target::fetch_registers): Update.
5120         (procfs_target::store_registers): Update.
5121         (procfs_target::wait): Update.
5122         (procfs_target::files_info): Update.
5123         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
5124         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
5125         return type.
5126         (nto_procfs_target::pid_to_str): Change return type.
5127         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
5128         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
5129         return type.
5130         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
5131         (exit_lwp): Update.
5132         (attach_proc_task_lwp_callback, get_detach_signal)
5133         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
5134         (linux_nat_target::resume, wait_lwp, stop_callback)
5135         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
5136         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
5137         (linux_nat_wait_1, resume_stopped_resumed_lwps)
5138         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
5139         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
5140         type.
5141         (inf_ptrace_target::attach): Update.
5142         (inf_ptrace_target::files_info): Update.
5143         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
5144         type.
5145         (go32_nat_target::pid_to_str): Change return type.
5146         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
5147         (gnu_nat_target::wait): Update.
5148         (gnu_nat_target::wait): Update.
5149         (gnu_nat_target::resume): Update.
5150         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
5151         (fbsd_nat_target::wait): Update.
5152         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
5153         type.
5154         (darwin_nat_target::attach): Update.
5155         * corelow.c (class core_target) <pid_to_str>: Change return type.
5156         (core_target::pid_to_str): Change return type.
5157         * target.c (normal_pid_to_str): Change return type.
5158         (default_pid_to_str): Likewise.
5159         (target_pid_to_str): Change return type.
5160         (target_translate_tls_address): Update.
5161         (target_announce_detach): Update.
5162         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
5163         return type.
5164         (bsd_uthread_target::pid_to_str): Change return type.
5165         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
5166         type.
5167         (bsd_kvm_target::pid_to_str): Change return type.
5168         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
5169         return type.
5170         (aix_thread_target::pid_to_str): Change return type.
5171         * target.h (struct target_ops) <pid_to_str>: Change return type.
5172         (target_pid_to_str, normal_pid_to_str): Likewise.
5173         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
5174         type.
5175         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
5176         type.
5177         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
5178         return type.
5179         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
5180         type.
5181         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
5182         type.
5183         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
5184         return type.
5185
5186 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
5187
5188         * NEWS: Mention that the new default MI version is 3.  Mention
5189         changes to the output of commands and events that deal with
5190         multi-location breakpoints.
5191         * breakpoint.c: Include "mi/mi-out.h".
5192         (print_one_breakpoint): Change output syntax if using MI version
5193         >= 3.
5194         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
5195         New.
5196         (mi_multi_location_breakpoint_output_fixed): New.
5197         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
5198         (mi_cmd_fix_multi_location_breakpoint_output): New.
5199         (mi_multi_location_breakpoint_output_fixed): New.
5200         * mi/mi-cmds.c (mi_cmds): Register command
5201         -fix-multi-location-breakpoint-output.
5202         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
5203         interpreter "mi".
5204
5205 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
5206
5207         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
5208         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
5209         instantiate mi_ui_out based on interpreter name.
5210         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
5211         * mi/mi-main.c (mi_load_progress): Likewise.
5212
5213 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5214
5215         * NEWS: Combine separate "New targets" sections for 8.3.
5216
5217 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5218
5219         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
5220         (ppcfbsd_init_abi): Install gdbarch
5221         "fetch_tls_load_module_address" and "get_thread_local_address"
5222         methods.
5223
5224 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5225
5226         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
5227         (riscv_fbsd_init_abi): Install gdbarch
5228         "fetch_tls_load_module_address" and "get_thread_local_address"
5229         methods.
5230
5231 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5232
5233         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
5234         (i386fbsd_init_abi): Install gdbarch
5235         "fetch_tls_load_module_address" and "get_thread_local_address"
5236         methods.
5237
5238 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5239
5240         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
5241         (amd64fbsd_init_abi): Install gdbarch
5242         "fetch_tls_load_module_address" and "get_thread_local_address"
5243         methods.
5244
5245 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5246
5247         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
5248         (struct fbsd_pspace_data): New type.
5249         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
5250         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
5251         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
5252         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
5253         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
5254
5255 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5256
5257         * gdbtypes.c (lookup_struct_elt): New function.
5258         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
5259         * gdbtypes.h (struct struct_elt): New type.
5260         (lookup_struct_elt): New prototype.
5261
5262 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5263
5264         * gdbtypes.c (lookup_struct_elt_type): Update comment and
5265         remove disabled code block.
5266
5267 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5268
5269         * gdbarch.sh (get_thread_local_address): New method.
5270         * gdbarch.h, gdbarch.c: Regenerate.
5271         * target.c (target_translate_tls_address): Use
5272         gdbarch_get_thread_local_address if present instead of
5273         target::get_thread_local_address.
5274
5275 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5276
5277         * target.h (target::get_thread_local_address): Update comment.
5278
5279 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5280
5281         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
5282         objfile->separate_debug_objfile_backlink if not NULL.
5283
5284 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5285
5286         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
5287         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
5288         (amd64bsd_store_inferior_registers): Likewise.
5289         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5290         Enable segment base registers.
5291         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
5292         PT_GETFSBASE and PT_GETGSBASE.
5293         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
5294         PT_SETGSBASE.
5295         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
5296         segment base registers.
5297         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5298
5299 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
5300
5301         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
5302         Update calls to i386_target_description to add 'segments'
5303         parameter.
5304         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
5305         add segment base registers.
5306         * arch/i386.c (i386_create_target_description): Add 'segments'
5307         parameter to enable segment base registers.
5308         * arch/i386.h (i386_create_target_description): Likewise.
5309         * features/i386/32bit-segments.xml: New file.
5310         * features/i386/32bit-segments.c: Generate.
5311         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
5312         call to i386_target_description to add 'segments' parameter.
5313         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
5314         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
5315         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
5316         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
5317         if feature is present.
5318         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
5319         Add 'segments' parameter to call to i386_target_description.
5320         (i386_target_description): Add 'segments' parameter to enable
5321         segment base registers.
5322         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
5323         to call to i386_target_description.
5324         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
5325         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
5326         Define I386_NUM_REGS.
5327         (i386_target_description): Add 'segments' parameter to enable
5328         segment base registers.
5329
5330 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
5331
5332         PR/24325
5333         * source-cache.c: #undef open and close, to avoid unresolved
5334         externals during linking.
5335
5336 2019-03-12  Tom Tromey  <tromey@adacore.com>
5337
5338         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
5339         const.  Add initializers.
5340         (_initialize_remote): Don't initialize ptid globals.
5341
5342 2019-03-12  Pedro Alves  <palves@redhat.com>
5343
5344         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
5345
5346 2019-03-12  Pedro Alves  <palves@redhat.com>
5347
5348         * cp-name-parser.y (main): Remove unused 'len' variable.
5349
5350 2019-03-12  Tom Tromey  <tromey@adacore.com>
5351
5352         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
5353         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
5354
5355 2019-03-12  Tom Tromey  <tromey@adacore.com>
5356
5357         * linux-nat.c (iterate_over_lwps): Update.
5358         (stop_callback): Remove parameter.
5359         (stop_wait_callback, detach_callback, resume_set_callback)
5360         (select_singlestep_lwp_callback, set_ignore_sigint)
5361         (status_callback, resumed_callback, resume_clear_callback)
5362         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
5363         data parameter.
5364         (linux_nat_target::detach, linux_nat_target::resume)
5365         (linux_stop_and_wait_all_lwps, select_event_lwp)
5366         (linux_nat_filter_event, linux_nat_wait_1)
5367         (linux_nat_target::kill, linux_nat_target::stop)
5368         (linux_nat_target::stop): Update.
5369         (linux_nat_resume_callback): Change type.
5370         (resume_stopped_resumed_lwps, count_events_callback)
5371         (select_event_lwp_callback): Likewise.
5372         (linux_stop_lwp, linux_nat_stop_lwp): Update.
5373         * arm-linux-nat.c (struct update_registers_data): Remove.
5374         (update_registers_callback): Change type.
5375         (arm_linux_insert_hw_breakpoint1): Update.
5376         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
5377         parameter.
5378         (x86_linux_dr_set_addr): Update.
5379         (x86_linux_dr_set_control): Update.
5380         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
5381         (iterate_over_lwps): Use gdb::function_view.
5382         * nat/aarch64-linux-hw-point.c (struct
5383         aarch64_dr_update_callback_param): Remove.
5384         (debug_reg_change_callback): Change type.
5385         (aarch64_notify_debug_reg_change): Update.
5386         * s390-linux-nat.c (s390_refresh_per_info): Update.
5387
5388 2019-03-11  Tom Tromey  <tromey@adacore.com>
5389
5390         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
5391         redundant assignment to "this_cu".
5392
5393 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5394
5395         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
5396
5397 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5398
5399         * gdbtypes.c (rank_one_type_parm_set): New function extracted
5400         from...
5401         (rank_one_type): ... this.
5402
5403 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5404
5405         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
5406         from...
5407         (rank_one_type): ... this.
5408
5409 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5410
5411         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
5412         from...
5413         (rank_one_type): ... this.
5414
5415 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5416
5417         * gdbtypes.c (rank_one_type_parm_float): New function extracted
5418         from...
5419         (rank_one_type): ... this.
5420
5421 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5422
5423         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
5424         from...
5425         (rank_one_type): ... this.
5426
5427 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5428
5429         * gdbtypes.c (rank_one_type_parm_range): New function extracted
5430         from...
5431         (rank_one_type): ... this.
5432
5433 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5434
5435         * gdbtypes.c (rank_one_type_parm_char): New function extracted
5436         from...
5437         (rank_one_type): ... this.
5438
5439 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5440
5441         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
5442         from...
5443         (rank_one_type): ... this.
5444
5445 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5446
5447         * gdbtypes.c (rank_one_type_parm_int): New function extracted
5448         from...
5449         (rank_one_type): ... this.
5450
5451 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5452
5453         * gdbtypes.c (rank_one_type_parm_func): New function extracted
5454         from...
5455         (rank_one_type): ... this.
5456
5457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5458
5459         * gdbtypes.c (rank_one_type_parm_array): New function extracted
5460         from...
5461         (rank_one_type): ... this.
5462
5463 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
5464
5465         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
5466         from...
5467         (rank_one_type): ... this.
5468
5469 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5470
5471         * inferior.c (initialize_inferiors): Ensure 'help set/show print
5472         inferior-events' shows the example events.
5473
5474 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
5475
5476         Support styling on native MS-Windows console
5477
5478         PR/24315
5479         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
5480         on MS-Windows if $TERM is not defined.
5481
5482         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
5483
5484         * posix-hdep.c (gdb_console_fputs):
5485         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
5486         functions.
5487         * ui-file.h (gdb_console_fputs): Add prototype.
5488
5489         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
5490         back to fputs only if the former returns zero.
5491
5492 2019-03-07  Tom Tromey  <tom@tromey.com>
5493
5494         * symmisc.c (print_symbol_bcache_statistics): Update.
5495         (print_objfile_statistics): Update.
5496         * symfile.c (allocate_symtab): Update.
5497         * stabsread.c: Don't include bcache.h.
5498         * psymtab.h (struct psymbol_bcache): Don't declare.
5499         (class psymtab_storage) <psymbol_cache>: Now a bcache.
5500         (psymbol_bcache_init, psymbol_bcache_free)
5501         (psymbol_bcache_get_bcache): Don't declare.
5502         * psymtab.c (struct psymbol_bcache): Remove.
5503         (psymtab_storage::psymtab_storage): Update.
5504         (psymtab_storage::~psymtab_storage): Update.
5505         (psymbol_bcache_init, psymbol_bcache_free)
5506         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
5507         (add_psymbol_to_bcache): Update.
5508         (allocate_psymtab): Update.
5509         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
5510         macro_cache>: No longer pointers.
5511         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
5512         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
5513         * macrotab.c (macro_bcache): Update.
5514         * macroexp.c: Don't include bcache.h.
5515         * gdbtypes.c (check_types_worklist): Update.
5516         (types_deeply_equal): Remove TRY/CATCH.  Update.
5517         * elfread.c (elf_symtab_read): Update.
5518         * dwarf2read.c: Don't include bcache.h.
5519         * buildsym.c (buildsym_compunit::get_macro_table): Update.
5520         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
5521         (print_bcache_statistics, bcache_memory_used): Don't declare.
5522         (struct bcache): Move from bcache.c.  Add constructor, destructor,
5523         methods.  Rename all data members.
5524         * bcache.c (struct bcache): Move to bcache.h.
5525         (bcache::expand_hash_table): Rename from expand_hash_table.
5526         (bcache): Remove.
5527         (bcache::insert): Rename from bcache_full.
5528         (bcache::compare): Rename from bcache_compare.
5529         (bcache_xmalloc): Remove.
5530         (bcache::~bcache): Rename from bcache_xfree.
5531         (bcache::print_statistics): Rename from print_bcache_statistics.
5532         (bcache::memory_used): Rename from bcache_memory_used.
5533
5534 2019-03-07  Pedro Alves  <palves@redhat.com>
5535
5536         * infrun.c (normal_stop): Also check for
5537         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
5538
5539 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5540
5541         * f-lang.c (value_from_host_double): Moved to...
5542         * value.c (value_from_host_double): ...here.
5543         * value.h (value_from_host_double): Declare.
5544         * guile/scm-math.c (vlscm_convert_typed_number): Use
5545         value_from_host_double.
5546         (vlscm_convert_number): Likewise.
5547         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5548         * python/py-value.c (convert_value_from_python): Likewise.
5549
5550 2019-03-06  Tom Tromey  <tom@tromey.com>
5551
5552         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5553
5554 2019-03-06  Tom Tromey  <tom@tromey.com>
5555
5556         * utils.h (free_current_contents): Don't declare.
5557         * utils.c (free_current_contents): Remove.
5558
5559 2019-03-06  Tom Tromey  <tom@tromey.com>
5560
5561         * top.c (quit_force): Update.
5562         * main.c (captured_command_loop): Update.
5563         * common/new-op.c (operator new): Update.
5564         * common/common-exceptions.c (struct catcher)
5565         <save_cleanup_chain>: Remove member.
5566         (exceptions_state_mc_init): Update.
5567         (exception_try_scope_entry): Return nullptr.
5568         (exception_try_scope_exit, exception_rethrow)
5569         (throw_exception_sjlj, throw_exception_cxx): Update.
5570         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5571         (all_cleanups, do_cleanups, discard_cleanups)
5572         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5573         (restore_cleanups, restore_final_cleanups): Don't declare.
5574         (do_final_cleanups): Remove parameter.
5575         * common/cleanups.c (cleanup_chain, make_cleanup)
5576         (make_cleanup_dtor, all_cleanups, do_cleanups)
5577         (discard_my_cleanups, discard_cleanups)
5578         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5579         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5580         (null_cleanup): Remove.
5581         (do_final_cleanups): Remove parameter.
5582
5583 2019-03-06  Tom Tromey  <tom@tromey.com>
5584
5585         * remote.c (remote_target::remote_parse_stop_reply): Use
5586         unique_xmalloc_ptr.
5587
5588 2019-03-06  Tom Tromey  <tom@tromey.com>
5589
5590         * stabsread.c (struct stabs_field_info): Rename from field_info.
5591         <list, fnlist>: Add initializers.
5592         <obstack>: New member.
5593         (read_member_functions, read_struct_fields, read_baseclasses):
5594         Allocate on obstack.  Don't use cleanups.
5595         (read_one_struct_field, read_member_functions, read_struct_fields)
5596         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5597         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5598         (read_struct_type): Update.
5599
5600 2019-03-06  Tom Tromey  <tom@tromey.com>
5601
5602         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5603         * common/filestuff.h (make_cleanup_close): Don't declare.
5604         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5605         Remove.
5606
5607 2019-03-06  Tom Tromey  <tom@tromey.com>
5608
5609         * solib-aix.c: Use make_scope_exit.
5610
5611 2019-03-06  Tom Tromey  <tom@tromey.com>
5612
5613         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5614         Use make_scope_exit.
5615
5616 2019-03-06  Tom Tromey  <tom@tromey.com>
5617
5618         * solib-svr4.c (disable_probes_interface): Remove parameter.
5619         (svr4_handle_solib_event): Use make_scope_exit.
5620
5621 2019-03-06  Tom Tromey  <tom@tromey.com>
5622
5623         * remote.c (struct stop_reply_deleter): Remove.
5624         (stop_reply_up): Update.
5625         (struct stop_reply): Derive from notif_event.  Don't typedef.
5626         <regcache>: Now a std::vector.
5627         (stop_reply_xfree): Remove.
5628         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5629         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5630         (remote_target::discard_pending_stop_replies): Use delete.
5631         (remote_target::remote_parse_stop_reply): Update.
5632         (remote_target::process_stop_reply): Update.
5633         * remote-notif.h (struct notif_event): Add virtual destructor.
5634         Remove "dtr" member.
5635         (struct notif_client) <alloc_event>: Return a unique_ptr.
5636         (notif_event_xfree): Don't declare.
5637         (notif_event_up): New typedef.
5638         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5639         (notif_event_xfree, do_notif_event_xfree): Remove.
5640         (remote_notif_state_xfree): Update.
5641
5642 2019-03-06  Tom Tromey  <tom@tromey.com>
5643
5644         * infrun.c (displaced_step_clear_cleanup): Now a
5645         forward_scope_exit type.
5646         (displaced_step_prepare_throw): Update.
5647         (displaced_step_fixup): Update.
5648
5649 2019-03-06  Tom Tromey  <tom@tromey.com>
5650
5651         * inferior.h (class inferior): Update comment.
5652         * gdbthread.h (class thread_info): Update comment.
5653
5654 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5655             Tom Tromey  <tom@tromey.com>
5656
5657         * stabsread.h (struct stab_section_list): Remove.
5658         (coffstab_build_psymtabs): Update.
5659         * dbxread.c (symbuf_sections): Now a std::vector.
5660         (sect_idx): New global.
5661         (fill_symbuf): Update.
5662         (coffstab_build_psymtabs): Change type of stabsects parameter.
5663         Update.
5664         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5665         std::vector.
5666         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5667         (coff_locate_sections): Update.
5668         (coff_symfile_read): Remove cleanups.  Update.
5669         (init_stringtab): Add storage parameter.
5670         (free_stringtab, free_stringtab_cleanup): Remove.
5671         (init_lineno): Add storage parameter.
5672         (free_linetab, free_linetab_cleanup): Remove.
5673
5674 2019-03-06  Pedro Alves  <palves@redhat.com>
5675
5676         * linux-fork.c (fork_info::clobber_regs): Delete.
5677         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5678         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5679         comment.  Adjust.
5680         (scoped_switch_fork_info::scoped_switch_fork_info)
5681         (checkpoint_command, linux_fork_context): Adjust
5682         fork_save_infrun_state calls.
5683
5684 2019-03-06  Pedro Alves  <palves@redhat.com>
5685
5686         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5687         (inf_has_multiple_threads): Return 'bool' and rewrite using
5688         inferior_info::threads().
5689
5690 2019-03-06  Pedro Alves  <palves@redhat.com>
5691
5692         * linux-fork.c: Include <list>.
5693         (fork_list): Now a std::list instance.
5694         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5695         (forks_exist_p, find_last_fork): Adjust.
5696         (new_fork): Delete.
5697         (one_fork_p): New.
5698         (add_fork): Adjust.
5699         (free_fork): Delete, folded into fork_info::~fork_info().
5700         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5701         Adjust.
5702         (init_fork_list): Delete.
5703         (linux_fork_killall, linux_fork_mourn_inferior)
5704         (linux_fork_detach, info_checkpoints_command): Adjust.
5705         (_initialize_linux_fork): No longer call init_fork_list.
5706
5707 2019-03-06  Pedro Alves  <palves@redhat.com>
5708
5709         * linux-fork.c (new_fork): New, split out of ...
5710         (add_fork): ... this.  Return void.  Move "first fork" special
5711         case from here, to ...
5712         (checkpoint_command): ... here.
5713         * linux-linux.h (add_fork): Return void.
5714
5715 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5716
5717         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5718
5719 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5720             Chris January  <chris.january@arm.com>
5721             David Lecomber  <david.lecomber@arm.com>
5722
5723         * f-exp.y: New token, UNOP_INTRINSIC.
5724         (exp): New pattern using UNOP_INTRINSIC token.
5725         (f77_keywords): Add 'abs' keyword.
5726         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5727         (value_from_host_double): New function.
5728         (evaluate_subexp_f): Support UNOP_ABS.
5729
5730 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5731
5732         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5733         types.
5734
5735 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5736
5737         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5738         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5739         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5740
5741 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5742
5743         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5744
5745 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5746             Chris January  <chris.january@arm.com>
5747
5748         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5749         * f-exp.y: Define 'KIND' token.
5750         (exp): New pattern for KIND expressions.
5751         (ptype): Handle types with a kind extension.
5752         (direct_abs_decl): Extend to spot kind extensions.
5753         (f77_keywords): Add 'kind' to the list.
5754         (push_kind_type): New function.
5755         (convert_to_kind_type): New function.
5756         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5757         * parse.c (operator_length_standard): Likewise.
5758         * parser-defs.h (enum type_pieces): Add tp_kind.
5759         * std-operator.def: Add UNOP_KIND.
5760
5761 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5762
5763         * f-exp.y (f_parse): Set yydebug.
5764
5765 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5766
5767         * f-lang.c (evaluate_subexp_f): New function.
5768         (exp_descriptor_f): New global.
5769         (f_language_defn): Use exp_descriptor_f instead of
5770         exp_descriptor_standard.
5771
5772 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5773
5774         * f-exp.y (struct token): Add comments.
5775         (dot_ops): Remove uppercase versions and the end marker.
5776         (f77_keywords): Likewise.
5777         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5778         entries in the dot_ops array are case insensitive, and use
5779         strncasecmp to compare strings.  Also some whitespace cleanup in
5780         this area.  Similar for the f77_keywords array, except entries in
5781         this list might be case sensitive.
5782
5783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5784
5785         * f-exp.y (struct f77_boolean_val): Add comments.
5786         (boolean_values): Remove uppercase versions, and end marker.
5787         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5788         and use strncasecmp to achieve case insensitivity.  Additionally,
5789         perform whitespace cleanup around this code.
5790
5791 2019-03-06  Tom Tromey  <tromey@adacore.com>
5792
5793         * remote-sim.c (gdbsim_target_open): Use result of
5794         gdb_argv::release.
5795
5796 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5797         Dirk Schubert  <dirk.schubert@arm.com>
5798         Chris January  <chris.january@arm.com>
5799
5800         * eval.c (evaluate_subexp_standard): Call Fortran argument
5801         wrapping logic.
5802         * f-lang.c (struct value): A value which can be passed into a
5803         Fortran function call.
5804         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5805         where appropriate.
5806         (struct type): Value ready for a Fortran function call.
5807         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5808         is needed.
5809         * f-lang.h (fortran_argument_convert): Declaration.
5810         (fortran_preserve_arg_pointer): Declaration.
5811         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5812
5813 2019-03-05  Tom Tromey  <tromey@adacore.com>
5814
5815         * python/py-prettyprint.c (print_string_repr): Remove #if.
5816         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5817
5818 2019-03-05  Tom Tromey  <tromey@adacore.com>
5819
5820         * target.c (the_dummy_target): Move later.  Change type to
5821         "dummy_target".
5822         (initialize_targets): Don't initialize the_dummy_target.
5823
5824 2019-03-05  Tom Tromey  <tromey@adacore.com>
5825
5826         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5827         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5828
5829 2019-03-05  Tom Tromey  <tromey@adacore.com>
5830
5831         * windows-nat.c (windows_nat_target::attach)
5832         (windows_nat_target::detach): Don't call gdb_flush.
5833         * valprint.c (generic_val_print, val_print, val_print_string):
5834         Don't call gdb_flush.
5835         * utils.c (defaulted_query): Don't call gdb_flush.
5836         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5837         * target.c (target_announce_detach): Don't call gdb_flush.
5838         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5839         * remote.c (extended_remote_target::attach): Don't call
5840         gdb_flush.
5841         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5842         * printcmd.c (do_examine): Don't call gdb_flush.
5843         (info_display_command): Don't call gdb_flush.
5844         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5845         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5846         * memattr.c (info_mem_command): Don't call gdb_flush.
5847         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5848         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5849         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5850         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5851         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5852         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5853         (gnu_nat_target::detach): Don't call gdb_flush.
5854         * f-valprint.c (f_val_print): Don't call gdb_flush.
5855         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5856         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5857         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5858         gdb_flush.
5859         * c-valprint.c (c_val_print): Don't call gdb_flush.
5860         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5861
5862 2019-03-05  Tom Tromey  <tromey@adacore.com>
5863
5864         * varobj.c (update_dynamic_varobj_children): Update.
5865         (install_default_visualizer): Use reset, not release.
5866         * value.c (set_internalvar): Update.
5867         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5868         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5869         ATTRIBUTE_UNUSED_RESULT.
5870
5871 2019-03-05  Tom Tromey  <tromey@adacore.com>
5872
5873         * remote.c (class scoped_remote_fd) <release>: Add
5874         ATTRIBUTE_UNUSED_RESULT.
5875
5876 2019-03-05  Tom Tromey  <tromey@adacore.com>
5877
5878         * macroexp.c (struct macro_buffer) <release>: Add
5879         ATTRIBUTE_UNUSED_RESULT.
5880
5881 2019-03-05  Tom Tromey  <tromey@adacore.com>
5882
5883         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5884         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5885         ATTRIBUTE_UNUSED_RESULT.
5886
5887 2019-03-05  Tom Tromey  <tromey@adacore.com>
5888
5889         * common/scoped_fd.h (class scoped_fd) <release>: Add
5890         ATTRIBUTE_UNUSED_RESULT.
5891
5892 2019-03-05  Tom Tromey  <tromey@adacore.com>
5893
5894         * parser-defs.h (struct parser_state) <release>: Add
5895         ATTRIBUTE_UNUSED_RESULT.
5896
5897 2019-03-05  Tom Tromey  <tromey@adacore.com>
5898
5899         * utils.h (class gdb_argv) <release>: Add
5900         ATTRIBUTE_UNUSED_RESULT.
5901         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5902
5903 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5904
5905         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5906         for-loop range, to avoid compiler warnings.
5907
5908         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5909         avoid compiler warnings about unused variables.
5910
5911         * NEWS: Mention end of support for native debugging on MS-Windows
5912         before XP.
5913
5914         PR gdb/24292
5915         * common/netstuff.c:
5916         * gdbserver/gdbreplay.c
5917         * gdbserver/remote-utils.c:
5918         * ser-tcp.c:
5919         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5920         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5921         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5922         'getaddrinfo' and 'freeaddrinfo' were not available before
5923         Windows XP, and mingw.org's MinGW headers by default define
5924         _WIN32_WINNT to 0x500.
5925
5926 2019-03-01  Gary Benson <gbenson@redhat.com>
5927
5928         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5929
5930 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5931             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5932
5933         PR gdb/8527
5934         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5935         set_sigint_trap, clear_sigint_trap.
5936
5937 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5938
5939         * target.c (target_detach): Clear the regcache and the
5940         frame cache.
5941
5942 2019-02-27  Pedro Alves  <palves@redhat.com>
5943
5944         * utils.c (set_screen_size): When we cap the height/width sizes,
5945         tweak the corresponding command variable to show "unlimited":
5946
5947 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5948             Pedro Alves  <palves@redhat.com>
5949
5950         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5951         before calling rl_set_screen_size.
5952
5953 2019-02-27  Tom Tromey  <tromey@adacore.com>
5954
5955         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5956         define.
5957         * python/py-value.c: Remove Python 2.4 workaround.
5958         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5959         workaround.
5960         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5961         Python 2.4 workaround.
5962         * python/python-internal.h: Remove Python 2.4 comment.
5963         (Py_ssize_t): Don't define.
5964         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5965         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5966         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5967         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5968         * python/python.c (do_start_initialization): Remove Python 2.4
5969         workaround.
5970         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5971         (print_children): Remove Python 2.4 workaround.
5972         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5973         workaround.
5974         (CHARBUFFERPROC_NAME): Remove.
5975         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5976         Python 2.4 workaround.
5977
5978 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5979
5980         * NEWS: Note minimum Python version.
5981
5982 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5983
5984         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5985         code from these functions.  Remove corresponding ifdefs.  Use
5986         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5987         Remove gotos and target of gotos.
5988         (infpy_search_memory): Likewise.
5989
5990 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5991
5992         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5993         (hppa_gdbarch_init): Don't register deleted functions with
5994         gdbarch.
5995
5996 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5997
5998         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5999         (h8300_unwind_sp): Delete.
6000         (h8300_dummy_id): Delete.
6001         (h8300_gdbarch_init): Don't register deleted functions with
6002         gdbarch.
6003
6004 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6005
6006         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
6007         (ft32_unwind_pc): Delete.
6008         (ft32_unwind_sp): Delete.
6009         (ft32_gdbarch_init): Don't register deleted functions with
6010         gdbarch.
6011
6012 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6013
6014         * gdb/frv-tdep.c (frv_dummy_id): Delete.
6015         (frv_unwind_pc): Delete.
6016         (frv_unwind_sp): Delete.
6017         (frv_gdbarch_init): Don't register deleted functions with
6018         gdbarch.
6019
6020 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6021
6022         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
6023         (riscv_unwind_pc): Delete.
6024         (riscv_unwind_sp): Delete.
6025         (riscv_gdbarch_init): Don't register deleted functions with
6026         gdbarch.
6027
6028 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6029
6030         * gdb/csky-tdep.c (csky_dummy_id): Delete.
6031         (csky_unwind_pc): Delete.
6032         (csky_unwind_sp): Delete.
6033         (csky_gdbarch_init): Don't register deleted functions with
6034         gdbarch.
6035
6036 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6037
6038         * gdb/cris-tdep.c (cris_dummy_id): Delete.
6039         (cris_unwind_pc): Delete.
6040         (cris_unwind_sp): Delete.
6041         (cris_gdbarch_init): Don't register deleted functions with
6042         gdbarch.
6043
6044 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6045
6046         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
6047         (bfin_unwind_pc): Delete.
6048         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
6049
6050 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6051
6052         * gdb/arm-tdep.c (arm_dummy_id): Delete.
6053         (arm_unwind_pc): Delete.
6054         (arm_unwind_sp): Delete.
6055         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
6056
6057 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6058
6059         * gdb/arc-tdep.c (arc_dummy_id): Delete.
6060         (arc_unwind_pc): Delete.
6061         (arc_unwind_sp): Delete.
6062         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
6063
6064 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6065
6066         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
6067         (alpha_unwind_pc): Delete.
6068         (alpha_gdbarch_init): Don't register deleted functions with
6069         gdbarch.
6070
6071 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6072
6073         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
6074         (aarch64_unwind_pc): Delete.
6075         (aarch64_unwind_sp): Delete.
6076         (aarch64_gdbarch_init): Don't register deleted functions with
6077         gdbarch.
6078
6079 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6080
6081         * gdbtypes.c (type_align): Don't consider static members when
6082         computing structure alignment.
6083
6084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
6085
6086         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
6087         return 0 for other types.
6088         * arch-utils.c (default_type_align): Always return 0.
6089         * gdbarch.h: Regenerate.
6090         * gdbarch.sh (type_align): Extend comment.
6091         * gdbtypes.c (type_align): Add additional comments, always call
6092         gdbarch_type_align before applying the default rules.
6093         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
6094         generic code will then apply a suitable default.
6095         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
6096         types, return 0 for other types.
6097
6098 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6099
6100         * NEWS: Create a new section for the next release branch.
6101         Rename the section of the current branch, now that it has
6102         been cut.
6103
6104 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
6105
6106         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
6107         * version.in: Bump version to 8.3.50.DATE-git.
6108
6109 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
6110
6111         * aix-thread.c (ptid_cmp): Remove unused variable.
6112         (get_signaled_thread): Likewise.
6113         (store_regs_user_thread): Likewise.
6114         (store_regs_kernel_thread): Likewise.
6115         (fetch_regs_kernel_thread): Remove shadowed variable.
6116
6117 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
6118
6119         * features/riscv/32bit-cpu.xml: Add register numbers.
6120         * features/riscv/32bit-fpu.c: Regenerate.
6121         * features/riscv/32bit-fpu.xml: Add register numbers.
6122         * features/riscv/64bit-cpu.xml: Add register numbers.
6123         * features/riscv/64bit-fpu.c: Regenerate.
6124         * features/riscv/64bit-fpu.xml: Add register numbers.
6125
6126 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
6127
6128         * NEWS: Mention two argument form of gdb.Value constructor.
6129         * python/py-value.c (convert_buffer_and_type_to_value): New
6130         function.
6131         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
6132         Add support for handling an optional second argument.  Call
6133         convert_buffer_and_type_to_value as appropriate.
6134         * python/python-internal.h (Py_buffer_deleter): New struct.
6135         (Py_buffer_up): New typedef.
6136
6137 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
6138
6139         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
6140         instead of releasing ownership.
6141
6142 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
6143
6144         * dwarf2read.c (open_and_init_dwp_file): Call
6145         elf_numsections instead of bfd_count_sections to initialize
6146         dwp_file->num_sections.
6147
6148 2019-02-25  Tom Tromey  <tromey@adacore.com>
6149
6150         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
6151
6152 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
6153
6154         * gcore.in: Add '--readnever' option when invoking GDB.
6155
6156 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6157
6158         * MAINTAINERS: Update my email address.
6159
6160 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
6161
6162         * build-id.c (build_id_to_debug_bfd_1): New function.
6163         (build_id_to_debug_bfd): Look for separate debug file in
6164         sysroot.
6165
6166 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6167
6168         * gdbarch.sh: Update the copyright year range that is placed into
6169         generated files.
6170
6171 2019-02-22  Keith Seitz  <keiths@redhat.com>
6172
6173         PR symtab/23853
6174         * linespec.c (create_sals_line_offset): Search for the default
6175         symtab's filename instead of its fullname.
6176
6177 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6178
6179         * NEWS: Update style defaults.
6180
6181 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
6182
6183         * main.c (captured_main_1): Disable styling in batch mode.
6184
6185 2019-02-20  Tom Tromey  <tom@tromey.com>
6186
6187         * symtab.c (symtab_symbol_info): Fix typos.
6188
6189 2019-02-20  Tom Tromey  <tromey@adacore.com>
6190
6191         * findcmd.c (_initialize_mem_search): Use upper case for
6192         metasyntactic variables.
6193
6194 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
6195
6196         * aarch64-tdep.c (aarch64_add_reggroups): New function.
6197         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
6198
6199 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
6200
6201         * top.h (source_file_name): Change to std::string.
6202         * top.c (source_file_name): Likewise.
6203         (command_line_input): Adjust.
6204         * cli/cli-script.c (script_from_file): Adjust.
6205
6206 2019-02-19  Tom Tromey  <tromey@adacore.com>
6207
6208         * ravenscar-thread.c
6209         (ravenscar_thread_target::update_thread_list): Don't call
6210         ada_build_task_list.
6211         * ada-lang.h (ada_build_task_list): Don't declare.
6212         * ada-tasks.c (struct ada_tasks_inferior_data)
6213         <task_list_valid_p>: Now bool.
6214         (read_known_tasks, ada_task_list_changed)
6215         (ada_tasks_invalidate_inferior_data): Update.
6216         (read_known_tasks_array): Return bool.
6217         (read_known_tasks_list): Likewise.
6218         (read_known_tasks): Return void.
6219         (ada_build_task_list): Now static.
6220
6221 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6222
6223         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
6224         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
6225
6226 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6227
6228         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
6229         variant for ada_tasks_pspace_data_handle and
6230         ada_tasks_inferior_data_handle.
6231         (ada_tasks_pspace_data_cleanup): New function.
6232         (ada_tasks_inferior_data_cleanup): New function.
6233
6234 2019-02-17  Tom Tromey  <tom@tromey.com>
6235
6236         * macrotab.h (macro_source_fullname): Return a std::string.
6237         * macrotab.c (macro_include, check_for_redefinition)
6238         (macro_undef, macro_lookup_definition, foreach_macro)
6239         (foreach_macro_in_scope): Update.
6240         (macro_source_fullname): Return a std::string.
6241         * macrocmd.c (show_pp_source_pos): Update.
6242
6243 2019-02-17  Tom Tromey  <tom@tromey.com>
6244
6245         * macrocmd.c (show_pp_source_pos): Style the file names.
6246
6247 2019-02-17  Tom Tromey  <tom@tromey.com>
6248
6249         PR tui/24197:
6250         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
6251
6252 2019-02-17  Tom Tromey  <tom@tromey.com>
6253
6254         * ada-lang.c (user_select_syms): Use filtered printing.
6255         * utils.c (wrap_style): New global.
6256         (desired_style): Remove.
6257         (emit_style_escape): Add stream parameter.
6258         (set_output_style, reset_terminal_style, prompt_for_continue):
6259         Update.
6260         (flush_wrap_buffer): Only flush gdb_stdout.
6261         (wrap_here): Set wrap_style.
6262         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
6263         treat escape sequences as a character.  Change when wrap buffer is
6264         flushed.
6265         (fputs_styled): Do not set the output style when the default is
6266         requested.
6267         * ui-style.h (struct ui_file_style) <is_default>: New method.
6268         * source.c (print_source_lines_base): Emit escape sequences in one
6269         piece.
6270
6271 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6272
6273         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
6274         integers and enumeration types.
6275
6276 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
6277
6278         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
6279         instead of lookup_symbol_in_language
6280         (do_exact_match): New function.
6281         (ada_get_symbol_name_matcher): Return do_exact_match when
6282         doing a verbatim match.
6283
6284 2019-02-15  Tom Tromey  <tromey@adacore.com>
6285
6286         * ravenscar-thread.c (ravenscar_thread_target::resume)
6287         (ravenscar_thread_target::wait): Special case wildcard requests.
6288
6289 2019-02-15  Tom Tromey  <tromey@adacore.com>
6290
6291         * ravenscar-thread.c (base_ptid): Remove.
6292         (struct ravenscar_thread_target) <close>: New method.
6293         <m_base_ptid>: New member.
6294         <update_inferior_ptid, active_task, task_is_currently_active,
6295         runtime_initialized>: Declare methods.
6296         <ravenscar_thread_target>: Add constructor.
6297         (ravenscar_thread_target::task_is_currently_active)
6298         (ravenscar_thread_target::update_inferior_ptid)
6299         (ravenscar_runtime_initialized): Rename.  Now methods.
6300         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
6301         (ravenscar_thread_target::update_thread_list): Update.
6302         (ravenscar_thread_target::active_task): Now method.
6303         (ravenscar_thread_target::store_registers)
6304         (ravenscar_thread_target::prepare_to_store)
6305         (ravenscar_thread_target::prepare_to_store)
6306         (ravenscar_thread_target::mourn_inferior): Update.
6307         (ravenscar_inferior_created): Use "new" to create target.
6308         (ravenscar_thread_target::get_ada_task_ptid): Update.
6309         (_initialize_ravenscar): Don't initialize base_ptid.
6310         (ravenscar_ops): Remove global.
6311
6312 2019-02-15  Tom Tromey  <tromey@adacore.com>
6313
6314         * target.h (push_target): Declare new overload.
6315         * target.c (push_target): New overload, taking an rvalue reference.
6316         * remote.c (remote_target::open_1): Use push_target overload.
6317         * corelow.c (core_target_open): Use push_target overload.
6318
6319 2019-02-15  Tom Tromey  <tromey@adacore.com>
6320
6321         * ravenscar-thread.c (is_ravenscar_task)
6322         (ravenscar_task_is_currently_active): Return bool.
6323         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
6324         (_initialize_ravenscar): Remove "(void)".
6325         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
6326         Return bool.
6327
6328 2019-02-15  Tom Tromey  <tromey@adacore.com>
6329
6330         * ravenscar-thread.c (ravenscar_runtime_initializer)
6331         (has_ravenscar_runtime, get_running_thread_id)
6332         (ravenscar_thread_target::resume): Fix indentation.
6333
6334 2019-02-15  Tom Tromey  <tromey@adacore.com>
6335
6336         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
6337         from ravenscar_arch_ops.
6338         (sparc_ravenscar_ops::fetch_registers)
6339         (sparc_ravenscar_ops::store_registers): Now methods.
6340         (sparc_ravenscar_prepare_to_store): Remove.
6341         (sparc_ravenscar_ops): Redefine.
6342         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
6343         methods and destructor.  Remove members.
6344         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
6345         (ravenscar_thread_target::store_registers)
6346         (ravenscar_thread_target::prepare_to_store): Update.
6347         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
6348         Remove.
6349         (struct ppc_ravenscar_powerpc_ops): Derive from
6350         ravenscar_arch_ops.
6351         (ppc_ravenscar_powerpc_ops::fetch_registers)
6352         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
6353         (ppc_ravenscar_powerpc_ops): Redefine.
6354         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
6355         (ppc_ravenscar_e500_ops::fetch_registers)
6356         (ppc_ravenscar_e500_ops::store_registers): Now methods.
6357         (ppc_ravenscar_e500_ops): Redefine.
6358         * aarch64-ravenscar-thread.c
6359         (aarch64_ravenscar_generic_prepare_to_store): Remove.
6360         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
6361         (aarch64_ravenscar_fetch_registers)
6362         (aarch64_ravenscar_store_registers): Now methods.
6363         (aarch64_ravenscar_ops): Redefine.
6364
6365 2019-02-15  Tom Tromey  <tromey@adacore.com>
6366
6367         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
6368         (ravenscar_thread_target::stopped_by_hw_breakpoint)
6369         (ravenscar_thread_target::stopped_by_watchpoint)
6370         (ravenscar_thread_target::stopped_data_address)
6371         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
6372
6373 2019-02-15  Tom Tromey  <tromey@adacore.com>
6374
6375         * ravenscar-thread.c: Fix some typos.
6376
6377 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6378             Tom Tromey  <tromey@adacore.com>
6379
6380         * ada-lang.c (ada_exception_sal): Change addr_string to a
6381         std::string.
6382         (create_ada_exception_catchpoint): Update.
6383
6384 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6385             Tom Tromey  <tromey@adacore.com>
6386
6387         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
6388         (bp_location_ops): Remove.
6389         (base_breakpoint_allocate_location): Update.
6390         (free_bp_location): Update.
6391         * ada-lang.c (class ada_catchpoint_location)
6392         <ada_catchpoint_location>: Remove ops parameter.
6393         (ada_catchpoint_location_dtor): Remove.
6394         (ada_catchpoint_location_ops): Remove.
6395         (allocate_location_exception): Update.
6396         * breakpoint.h (struct bp_location_ops): Remove.
6397         (class bp_location) <bp_location>: Remove bp_location_ops
6398         parameter.
6399         <~bp_location>: Add destructor.
6400         <ops>: Remove.
6401
6402 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6403             Pedro Alves  <palves@redhat.com>
6404
6405         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
6406         'PATH_MAX'.
6407
6408 2019-02-14  David Michael  <fedora.dm0@gmail.com>
6409             Samuel Thibault  <samuel.thibault@gnu.org>
6410             Thomas Schwinge  <thomas@codesourcery.com>
6411
6412         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
6413         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
6414
6415 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
6416
6417         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
6418         (check_empty): Use "const char *".
6419
6420         * gnu-nat.c (gnu_nat_target::detach): Instead of
6421         'detach_inferior (pid)' call
6422         'detach_inferior (find_inferior_pid (pid))'.
6423
6424         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
6425         'nat/fork-inferior.o'.
6426         * gnu-nat.c: #include "nat/fork-inferior.h".
6427
6428         * gnu-nat.c (gnu_nat_target::detach): Instead of
6429         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
6430         * gnu-nat.h: #include "inf-child.h".
6431         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
6432         'i386_gnu_nat_target::fetch_registers'.
6433         (gnu_store_registers): Rename/move to
6434         'i386_gnu_nat_target::store_registers'.
6435
6436         * config/i386/nm-i386gnu.h: Don't "#include" any files.
6437         * gnu-nat.h (mach_thread_info): New function.
6438         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
6439
6440         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
6441
6442 2019-02-14  Frederic Konrad  <konrad@adacore.com>
6443
6444         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
6445
6446 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
6447
6448         * windows-nat.c (windows_add_thread): Add new parameter
6449         "main_thread_p" with default value set to false.  Update
6450         function documentation as well as all callers.
6451         (windows_delete_thread): Likewise.
6452         (fake_create_process): Update call to windows_add_thread.
6453         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
6454         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
6455         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
6456         call to windows_delete_thread.
6457
6458 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
6459
6460         * MAINTAINERS: Add Andrew Burgess as global maintainer.
6461
6462 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6463
6464         * symfile.c (find_separate_debug_file): Use canonical path of
6465         sysroot with child_path instead of gdb_sysroot if it is valid.
6466
6467 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6468
6469         * symfile.c (find_separate_debug_file): Use child_path to
6470         determine if an object file is under a sysroot.
6471
6472 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6473
6474         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
6475         unittests/child-path-selftests.c.
6476         * common/pathstuff.c (child_path): New function.
6477         * common/pathstuff.h (child_path): New prototype.
6478         * unittests/child-path-selftests.c: New file.
6479
6480 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
6481
6482         * symfile.c (find_separate_debug_file): Look for separate debug
6483         files in debug directories under the sysroot.
6484
6485 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6486
6487         * symtab.h (struct minimal_symbol data_p): New const method.
6488         (struct minimal_symbol text_p): Likewise.
6489         * symtab.c (output_source_filename): Use file name style
6490         to print file name.
6491         (print_symbol_info): Likewise.
6492         (print_msymbol_info): Use address style to print addresses.
6493         Use function name style to print executable text symbols.
6494         (expand_symtab_containing_pc): Use data_p.
6495         (find_pc_sect_compunit_symtab): Likewise.
6496
6497 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6498
6499         * breakpoint.c (describe_other_breakpoints): Use address style
6500         to print addresses.
6501         (say_where): Likewise.
6502
6503 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6504
6505         * ada-typeprint.c (print_func_type): Print function name
6506         style to print function name.
6507         * c-typeprint.c (c_print_type_1): Likewise.
6508
6509 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
6510
6511         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
6512         for execve.
6513
6514 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6515
6516         * c-exp.y (direct_abs_decl): Use emplace_back to record the
6517         type_stack.
6518
6519 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
6520
6521         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
6522         TYPE_CODE_REF types.
6523
6524 2019-02-08  Jim Wilson  <jimw@sifive.com>
6525
6526         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
6527         (riscv_linux_fregset): New.
6528         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
6529
6530 2019-02-07  Tom Tromey  <tom@tromey.com>
6531
6532         * thread.c (thread_cancel_execution_command): Update.
6533         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
6534         methods.
6535         (struct thread_fsm_ops): Remove.
6536         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
6537         (thread_fsm_should_stop, thread_fsm_return_value)
6538         (thread_fsm_set_finished, thread_fsm_finished_p)
6539         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6540         Don't declare.
6541         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6542         * infrun.c (clear_proceed_status_thread)
6543         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6544         (print_stop_event): Update.
6545         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6546         Add constructor.
6547         (step_command_fsm_ops): Remove.
6548         (new_step_command_fsm): Remove.
6549         (step_1): Update.
6550         (step_command_fsm::should_stop): Rename from
6551         step_command_fsm_should_stop.
6552         (step_command_fsm::clean_up): Rename from
6553         step_command_fsm_clean_up.
6554         (step_command_fsm::do_async_reply_reason): Rename from
6555         step_command_fsm_async_reply_reason.
6556         (struct until_next_fsm): Inherit from thread_fsm.  Add
6557         constructor.
6558         (until_next_fsm_ops): Remove.
6559         (new_until_next_fsm): Remove.
6560         (until_next_fsm::should_stop): Rename from
6561         until_next_fsm_should_stop.
6562         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6563         (until_next_fsm::do_async_reply_reason): Rename from
6564         until_next_fsm_async_reply_reason.
6565         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6566         constructor.  Change type of breakpoint.
6567         (finish_command_fsm_ops): Remove.
6568         (new_finish_command_fsm): Remove.
6569         (finish_command_fsm::should_stop): Rename from
6570         finish_command_fsm_should_stop.
6571         (finish_command_fsm::clean_up): Rename from
6572         finish_command_fsm_clean_up.
6573         (finish_command_fsm::return_value): Rename from
6574         finish_command_fsm_return_value.
6575         (finish_command_fsm::do_async_reply_reason): Rename from
6576         finish_command_fsm_async_reply_reason.
6577         (finish_command): Update.
6578         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6579         Add constructor.
6580         (call_thread_fsm_ops): Remove.
6581         (call_thread_fsm::call_thread_fsm): Rename from
6582         new_call_thread_fsm.
6583         (call_thread_fsm::should_stop): Rename from
6584         call_thread_fsm_should_stop.
6585         (call_thread_fsm::should_notify_stop): Rename from
6586         call_thread_fsm_should_notify_stop.
6587         (run_inferior_call, call_function_by_hand_dummy): Update.
6588         * cli/cli-interp.c (should_print_stop_to_console): Update.
6589         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6590         Add constructor.  Change type of location_breakpoint,
6591         caller_breakpoint.
6592         (until_break_fsm_ops): Remove.
6593         (new_until_break_fsm): Remove.
6594         (until_break_fsm::should_stop): Rename from
6595         until_break_fsm_should_stop.
6596         (until_break_fsm::clean_up): Rename from
6597         until_break_fsm_clean_up.
6598         (until_break_fsm::do_async_reply_reason): Rename from
6599         until_break_fsm_async_reply_reason.
6600         (until_break_command): Update.
6601         * thread-fsm.c: Remove.
6602         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6603
6604 2019-02-07  Tom Tromey  <tom@tromey.com>
6605
6606         * yy-remap.h: Add include guard.
6607         * xtensa-tdep.h: Add include guard.
6608         * xcoffread.h: Rename include guard.
6609         * varobj-iter.h: Add include guard.
6610         * tui/tui.h: Rename include guard.
6611         * tui/tui-winsource.h: Rename include guard.
6612         * tui/tui-wingeneral.h: Rename include guard.
6613         * tui/tui-windata.h: Rename include guard.
6614         * tui/tui-win.h: Rename include guard.
6615         * tui/tui-stack.h: Rename include guard.
6616         * tui/tui-source.h: Rename include guard.
6617         * tui/tui-regs.h: Rename include guard.
6618         * tui/tui-out.h: Rename include guard.
6619         * tui/tui-layout.h: Rename include guard.
6620         * tui/tui-io.h: Rename include guard.
6621         * tui/tui-hooks.h: Rename include guard.
6622         * tui/tui-file.h: Rename include guard.
6623         * tui/tui-disasm.h: Rename include guard.
6624         * tui/tui-data.h: Rename include guard.
6625         * tui/tui-command.h: Rename include guard.
6626         * tic6x-tdep.h: Add include guard.
6627         * target/waitstatus.h: Rename include guard.
6628         * target/wait.h: Rename include guard.
6629         * target/target.h: Rename include guard.
6630         * target/resume.h: Rename include guard.
6631         * target-float.h: Rename include guard.
6632         * stabsread.h: Add include guard.
6633         * rs6000-tdep.h: Add include guard.
6634         * riscv-fbsd-tdep.h: Add include guard.
6635         * regformats/regdef.h: Rename include guard.
6636         * record.h: Rename include guard.
6637         * python/python.h: Rename include guard.
6638         * python/python-internal.h: Rename include guard.
6639         * python/py-stopevent.h: Rename include guard.
6640         * python/py-ref.h: Rename include guard.
6641         * python/py-record.h: Rename include guard.
6642         * python/py-record-full.h: Rename include guard.
6643         * python/py-record-btrace.h: Rename include guard.
6644         * python/py-instruction.h: Rename include guard.
6645         * python/py-events.h: Rename include guard.
6646         * python/py-event.h: Rename include guard.
6647         * procfs.h: Add include guard.
6648         * proc-utils.h: Add include guard.
6649         * p-lang.h: Add include guard.
6650         * or1k-tdep.h: Rename include guard.
6651         * observable.h: Rename include guard.
6652         * nto-tdep.h: Rename include guard.
6653         * nat/x86-linux.h: Rename include guard.
6654         * nat/x86-linux-dregs.h: Rename include guard.
6655         * nat/x86-gcc-cpuid.h: Add include guard.
6656         * nat/x86-dregs.h: Rename include guard.
6657         * nat/x86-cpuid.h: Rename include guard.
6658         * nat/ppc-linux.h: Rename include guard.
6659         * nat/mips-linux-watch.h: Rename include guard.
6660         * nat/linux-waitpid.h: Rename include guard.
6661         * nat/linux-ptrace.h: Rename include guard.
6662         * nat/linux-procfs.h: Rename include guard.
6663         * nat/linux-osdata.h: Rename include guard.
6664         * nat/linux-nat.h: Rename include guard.
6665         * nat/linux-namespaces.h: Rename include guard.
6666         * nat/linux-btrace.h: Rename include guard.
6667         * nat/glibc_thread_db.h: Rename include guard.
6668         * nat/gdb_thread_db.h: Rename include guard.
6669         * nat/gdb_ptrace.h: Rename include guard.
6670         * nat/fork-inferior.h: Rename include guard.
6671         * nat/amd64-linux-siginfo.h: Rename include guard.
6672         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6673         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6674         * nat/aarch64-linux.h: Rename include guard.
6675         * nat/aarch64-linux-hw-point.h: Rename include guard.
6676         * mn10300-tdep.h: Add include guard.
6677         * mips-linux-tdep.h: Add include guard.
6678         * mi/mi-parse.h: Rename include guard.
6679         * mi/mi-out.h: Rename include guard.
6680         * mi/mi-main.h: Rename include guard.
6681         * mi/mi-interp.h: Rename include guard.
6682         * mi/mi-getopt.h: Rename include guard.
6683         * mi/mi-console.h: Rename include guard.
6684         * mi/mi-common.h: Rename include guard.
6685         * mi/mi-cmds.h: Rename include guard.
6686         * mi/mi-cmd-break.h: Rename include guard.
6687         * m2-lang.h: Add include guard.
6688         * location.h: Rename include guard.
6689         * linux-record.h: Rename include guard.
6690         * linux-nat.h: Add include guard.
6691         * linux-fork.h: Add include guard.
6692         * i386-darwin-tdep.h: Rename include guard.
6693         * hppa-linux-offsets.h: Add include guard.
6694         * guile/guile.h: Rename include guard.
6695         * guile/guile-internal.h: Rename include guard.
6696         * gnu-nat.h: Rename include guard.
6697         * gdb-stabs.h: Rename include guard.
6698         * frv-tdep.h: Add include guard.
6699         * f-lang.h: Add include guard.
6700         * event-loop.h: Add include guard.
6701         * darwin-nat.h: Rename include guard.
6702         * cp-abi.h: Rename include guard.
6703         * config/sparc/nm-sol2.h: Rename include guard.
6704         * config/nm-nto.h: Rename include guard.
6705         * config/nm-linux.h: Add include guard.
6706         * config/i386/nm-i386gnu.h: Rename include guard.
6707         * config/djgpp/nl_types.h: Rename include guard.
6708         * config/djgpp/langinfo.h: Rename include guard.
6709         * compile/gcc-cp-plugin.h: Add include guard.
6710         * compile/gcc-c-plugin.h: Add include guard.
6711         * compile/compile.h: Rename include guard.
6712         * compile/compile-object-run.h: Rename include guard.
6713         * compile/compile-object-load.h: Rename include guard.
6714         * compile/compile-internal.h: Rename include guard.
6715         * compile/compile-cplus.h: Rename include guard.
6716         * compile/compile-c.h: Rename include guard.
6717         * common/xml-utils.h: Rename include guard.
6718         * common/x86-xstate.h: Rename include guard.
6719         * common/version.h: Rename include guard.
6720         * common/vec.h: Rename include guard.
6721         * common/tdesc.h: Rename include guard.
6722         * common/selftest.h: Rename include guard.
6723         * common/scoped_restore.h: Rename include guard.
6724         * common/scoped_mmap.h: Rename include guard.
6725         * common/scoped_fd.h: Rename include guard.
6726         * common/safe-iterator.h: Rename include guard.
6727         * common/run-time-clock.h: Rename include guard.
6728         * common/refcounted-object.h: Rename include guard.
6729         * common/queue.h: Rename include guard.
6730         * common/ptid.h: Rename include guard.
6731         * common/print-utils.h: Rename include guard.
6732         * common/preprocessor.h: Rename include guard.
6733         * common/pathstuff.h: Rename include guard.
6734         * common/observable.h: Rename include guard.
6735         * common/netstuff.h: Rename include guard.
6736         * common/job-control.h: Rename include guard.
6737         * common/host-defs.h: Rename include guard.
6738         * common/gdb_wait.h: Rename include guard.
6739         * common/gdb_vecs.h: Rename include guard.
6740         * common/gdb_unlinker.h: Rename include guard.
6741         * common/gdb_unique_ptr.h: Rename include guard.
6742         * common/gdb_tilde_expand.h: Rename include guard.
6743         * common/gdb_sys_time.h: Rename include guard.
6744         * common/gdb_string_view.h: Rename include guard.
6745         * common/gdb_splay_tree.h: Rename include guard.
6746         * common/gdb_setjmp.h: Rename include guard.
6747         * common/gdb_ref_ptr.h: Rename include guard.
6748         * common/gdb_optional.h: Rename include guard.
6749         * common/gdb_locale.h: Rename include guard.
6750         * common/gdb_assert.h: Rename include guard.
6751         * common/filtered-iterator.h: Rename include guard.
6752         * common/filestuff.h: Rename include guard.
6753         * common/fileio.h: Rename include guard.
6754         * common/environ.h: Rename include guard.
6755         * common/common-utils.h: Rename include guard.
6756         * common/common-types.h: Rename include guard.
6757         * common/common-regcache.h: Rename include guard.
6758         * common/common-inferior.h: Rename include guard.
6759         * common/common-gdbthread.h: Rename include guard.
6760         * common/common-exceptions.h: Rename include guard.
6761         * common/common-defs.h: Rename include guard.
6762         * common/common-debug.h: Rename include guard.
6763         * common/cleanups.h: Rename include guard.
6764         * common/buffer.h: Rename include guard.
6765         * common/btrace-common.h: Rename include guard.
6766         * common/break-common.h: Rename include guard.
6767         * cli/cli-utils.h: Rename include guard.
6768         * cli/cli-style.h: Rename include guard.
6769         * cli/cli-setshow.h: Rename include guard.
6770         * cli/cli-script.h: Rename include guard.
6771         * cli/cli-interp.h: Rename include guard.
6772         * cli/cli-decode.h: Rename include guard.
6773         * cli/cli-cmds.h: Rename include guard.
6774         * charset-list.h: Add include guard.
6775         * buildsym-legacy.h: Rename include guard.
6776         * bfin-tdep.h: Add include guard.
6777         * ax.h: Rename include guard.
6778         * arm-linux-tdep.h: Add include guard.
6779         * arm-fbsd-tdep.h: Add include guard.
6780         * arch/xtensa.h: Rename include guard.
6781         * arch/tic6x.h: Add include guard.
6782         * arch/i386.h: Add include guard.
6783         * arch/arm.h: Rename include guard.
6784         * arch/arm-linux.h: Rename include guard.
6785         * arch/arm-get-next-pcs.h: Rename include guard.
6786         * arch/amd64.h: Add include guard.
6787         * arch/aarch64-insn.h: Rename include guard.
6788         * arch-utils.h: Rename include guard.
6789         * annotate.h: Add include guard.
6790         * amd64-darwin-tdep.h: Rename include guard.
6791         * aarch64-linux-tdep.h: Add include guard.
6792         * aarch64-fbsd-tdep.h: Add include guard.
6793         * aarch32-linux-nat.h: Add include guard.
6794
6795 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6796
6797         * macrotab.c (macro_define_internal): New function that
6798         factorizes macro_define_object_internal and macro_define_function
6799         code.
6800         (macro_define_object_internal): Use macro_define_internal.
6801         (macro_define_function): Likewise.
6802
6803 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6804
6805         * macrocmd.c (extract_identifier): Return
6806         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6807         callers.
6808
6809 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6810
6811         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6812
6813 2019-02-05  Tom Tromey  <tom@tromey.com>
6814
6815         * target.c (target_stack::unpush): Move assertion earlier.
6816
6817 2019-01-30  Tom Tromey  <tom@tromey.com>
6818
6819         PR python/23615:
6820         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6821         (gdbpy_parse_and_eval): Likewise.
6822         * python/python-internal.h (gdbpy_allow_threads): New class.
6823
6824 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6825
6826         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6827         (aarch64_fbsd_fpregmap): Move earlier.
6828         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6829         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6830         instead of individual calls to trad_frame_set_reg_addr.
6831         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6832         earlier.
6833         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6834         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6835         instead of individual calls to trad_frame_set_reg_addr.
6836
6837 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6838
6839         * CONTRIBUTE: Replace contribution list with wiki link.
6840
6841 2019-01-25  Tom Tromey  <tom@tromey.com>
6842
6843         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6844
6845 2019-01-25  Tom Tromey  <tom@tromey.com>
6846
6847         * xtensa-linux-nat.c: Fix common/ includes.
6848         * xml-support.h: Fix common/ includes.
6849         * xml-support.c: Fix common/ includes.
6850         * x86-linux-nat.c: Fix common/ includes.
6851         * windows-nat.c: Fix common/ includes.
6852         * varobj.h: Fix common/ includes.
6853         * varobj.c: Fix common/ includes.
6854         * value.c: Fix common/ includes.
6855         * valops.c: Fix common/ includes.
6856         * utils.c: Fix common/ includes.
6857         * unittests/xml-utils-selftests.c: Fix common/ includes.
6858         * unittests/utils-selftests.c: Fix common/ includes.
6859         * unittests/unpack-selftests.c: Fix common/ includes.
6860         * unittests/tracepoint-selftests.c: Fix common/ includes.
6861         * unittests/style-selftests.c: Fix common/ includes.
6862         * unittests/string_view-selftests.c: Fix common/ includes.
6863         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6864         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6865         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6866         * unittests/rsp-low-selftests.c: Fix common/ includes.
6867         * unittests/parse-connection-spec-selftests.c: Fix common/
6868         includes.
6869         * unittests/optional-selftests.c: Fix common/ includes.
6870         * unittests/offset-type-selftests.c: Fix common/ includes.
6871         * unittests/observable-selftests.c: Fix common/ includes.
6872         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6873         * unittests/memrange-selftests.c: Fix common/ includes.
6874         * unittests/memory-map-selftests.c: Fix common/ includes.
6875         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6876         * unittests/function-view-selftests.c: Fix common/ includes.
6877         * unittests/environ-selftests.c: Fix common/ includes.
6878         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6879         * unittests/common-utils-selftests.c: Fix common/ includes.
6880         * unittests/cli-utils-selftests.c: Fix common/ includes.
6881         * unittests/array-view-selftests.c: Fix common/ includes.
6882         * ui-file.c: Fix common/ includes.
6883         * tui/tui-io.c: Fix common/ includes.
6884         * tracepoint.h: Fix common/ includes.
6885         * tracepoint.c: Fix common/ includes.
6886         * tracefile-tfile.c: Fix common/ includes.
6887         * top.h: Fix common/ includes.
6888         * top.c: Fix common/ includes.
6889         * thread.c: Fix common/ includes.
6890         * target/waitstatus.h: Fix common/ includes.
6891         * target/waitstatus.c: Fix common/ includes.
6892         * target.h: Fix common/ includes.
6893         * target.c: Fix common/ includes.
6894         * target-memory.c: Fix common/ includes.
6895         * target-descriptions.c: Fix common/ includes.
6896         * symtab.h: Fix common/ includes.
6897         * symfile.c: Fix common/ includes.
6898         * stap-probe.c: Fix common/ includes.
6899         * spu-linux-nat.c: Fix common/ includes.
6900         * sparc-nat.c: Fix common/ includes.
6901         * source.c: Fix common/ includes.
6902         * solib.c: Fix common/ includes.
6903         * solib-target.c: Fix common/ includes.
6904         * ser-unix.c: Fix common/ includes.
6905         * ser-tcp.c: Fix common/ includes.
6906         * ser-pipe.c: Fix common/ includes.
6907         * ser-base.c: Fix common/ includes.
6908         * selftest-arch.c: Fix common/ includes.
6909         * s12z-tdep.c: Fix common/ includes.
6910         * rust-exp.y: Fix common/ includes.
6911         * rs6000-aix-tdep.c: Fix common/ includes.
6912         * riscv-tdep.c: Fix common/ includes.
6913         * remote.c: Fix common/ includes.
6914         * remote-notif.h: Fix common/ includes.
6915         * remote-fileio.h: Fix common/ includes.
6916         * remote-fileio.c: Fix common/ includes.
6917         * regcache.h: Fix common/ includes.
6918         * regcache.c: Fix common/ includes.
6919         * record-btrace.c: Fix common/ includes.
6920         * python/python.c: Fix common/ includes.
6921         * python/py-type.c: Fix common/ includes.
6922         * python/py-inferior.c: Fix common/ includes.
6923         * progspace.h: Fix common/ includes.
6924         * producer.c: Fix common/ includes.
6925         * procfs.c: Fix common/ includes.
6926         * proc-api.c: Fix common/ includes.
6927         * printcmd.c: Fix common/ includes.
6928         * ppc-linux-nat.c: Fix common/ includes.
6929         * parser-defs.h: Fix common/ includes.
6930         * osdata.c: Fix common/ includes.
6931         * obsd-nat.c: Fix common/ includes.
6932         * nat/x86-linux.c: Fix common/ includes.
6933         * nat/x86-linux-dregs.c: Fix common/ includes.
6934         * nat/x86-dregs.h: Fix common/ includes.
6935         * nat/x86-dregs.c: Fix common/ includes.
6936         * nat/ppc-linux.c: Fix common/ includes.
6937         * nat/mips-linux-watch.h: Fix common/ includes.
6938         * nat/mips-linux-watch.c: Fix common/ includes.
6939         * nat/linux-waitpid.c: Fix common/ includes.
6940         * nat/linux-ptrace.h: Fix common/ includes.
6941         * nat/linux-ptrace.c: Fix common/ includes.
6942         * nat/linux-procfs.c: Fix common/ includes.
6943         * nat/linux-personality.c: Fix common/ includes.
6944         * nat/linux-osdata.c: Fix common/ includes.
6945         * nat/linux-namespaces.c: Fix common/ includes.
6946         * nat/linux-btrace.h: Fix common/ includes.
6947         * nat/linux-btrace.c: Fix common/ includes.
6948         * nat/fork-inferior.c: Fix common/ includes.
6949         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6950         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6951         * nat/aarch64-linux.c: Fix common/ includes.
6952         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6953         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6954         * namespace.h: Fix common/ includes.
6955         * mips-linux-tdep.c: Fix common/ includes.
6956         * minsyms.c: Fix common/ includes.
6957         * mi/mi-parse.h: Fix common/ includes.
6958         * mi/mi-main.c: Fix common/ includes.
6959         * mi/mi-cmd-env.c: Fix common/ includes.
6960         * memrange.h: Fix common/ includes.
6961         * memattr.c: Fix common/ includes.
6962         * maint.h: Fix common/ includes.
6963         * maint.c: Fix common/ includes.
6964         * main.c: Fix common/ includes.
6965         * machoread.c: Fix common/ includes.
6966         * location.c: Fix common/ includes.
6967         * linux-thread-db.c: Fix common/ includes.
6968         * linux-nat.c: Fix common/ includes.
6969         * linux-fork.c: Fix common/ includes.
6970         * inline-frame.c: Fix common/ includes.
6971         * infrun.c: Fix common/ includes.
6972         * inflow.c: Fix common/ includes.
6973         * inferior.h: Fix common/ includes.
6974         * inferior.c: Fix common/ includes.
6975         * infcmd.c: Fix common/ includes.
6976         * inf-ptrace.c: Fix common/ includes.
6977         * inf-child.c: Fix common/ includes.
6978         * ia64-linux-nat.c: Fix common/ includes.
6979         * i387-tdep.c: Fix common/ includes.
6980         * i386-tdep.c: Fix common/ includes.
6981         * i386-linux-tdep.c: Fix common/ includes.
6982         * i386-linux-nat.c: Fix common/ includes.
6983         * i386-go32-tdep.c: Fix common/ includes.
6984         * i386-fbsd-tdep.c: Fix common/ includes.
6985         * i386-fbsd-nat.c: Fix common/ includes.
6986         * guile/scm-type.c: Fix common/ includes.
6987         * guile/guile.c: Fix common/ includes.
6988         * go32-nat.c: Fix common/ includes.
6989         * gnu-nat.c: Fix common/ includes.
6990         * gdbthread.h: Fix common/ includes.
6991         * gdbarch-selftests.c: Fix common/ includes.
6992         * gdb_usleep.c: Fix common/ includes.
6993         * gdb_select.h: Fix common/ includes.
6994         * gdb_bfd.c: Fix common/ includes.
6995         * gcore.c: Fix common/ includes.
6996         * fork-child.c: Fix common/ includes.
6997         * findvar.c: Fix common/ includes.
6998         * fbsd-nat.c: Fix common/ includes.
6999         * event-top.c: Fix common/ includes.
7000         * event-loop.c: Fix common/ includes.
7001         * dwarf2read.c: Fix common/ includes.
7002         * dwarf2loc.c: Fix common/ includes.
7003         * dwarf2-frame.c: Fix common/ includes.
7004         * dwarf-index-cache.c: Fix common/ includes.
7005         * dtrace-probe.c: Fix common/ includes.
7006         * disasm-selftests.c: Fix common/ includes.
7007         * defs.h: Fix common/ includes.
7008         * csky-tdep.c: Fix common/ includes.
7009         * cp-valprint.c: Fix common/ includes.
7010         * cp-support.h: Fix common/ includes.
7011         * cp-support.c: Fix common/ includes.
7012         * corelow.c: Fix common/ includes.
7013         * completer.h: Fix common/ includes.
7014         * completer.c: Fix common/ includes.
7015         * compile/compile.c: Fix common/ includes.
7016         * compile/compile-loc2c.c: Fix common/ includes.
7017         * compile/compile-cplus-types.c: Fix common/ includes.
7018         * compile/compile-cplus-symbols.c: Fix common/ includes.
7019         * command.h: Fix common/ includes.
7020         * cli/cli-dump.c: Fix common/ includes.
7021         * cli/cli-cmds.c: Fix common/ includes.
7022         * charset.c: Fix common/ includes.
7023         * build-id.c: Fix common/ includes.
7024         * btrace.h: Fix common/ includes.
7025         * btrace.c: Fix common/ includes.
7026         * breakpoint.h: Fix common/ includes.
7027         * breakpoint.c: Fix common/ includes.
7028         * ax.h:
7029         (enum agent_op): Fix common/ includes.
7030         * ax-general.c (struct aop_map): Fix common/ includes.
7031         * ax-gdb.c: Fix common/ includes.
7032         * auxv.c: Fix common/ includes.
7033         * auto-load.c: Fix common/ includes.
7034         * arm-tdep.c: Fix common/ includes.
7035         * arch/riscv.c: Fix common/ includes.
7036         * arch/ppc-linux-common.c: Fix common/ includes.
7037         * arch/i386.c: Fix common/ includes.
7038         * arch/arm.c: Fix common/ includes.
7039         * arch/arm-linux.c: Fix common/ includes.
7040         * arch/arm-get-next-pcs.c: Fix common/ includes.
7041         * arch/amd64.c: Fix common/ includes.
7042         * arch/aarch64.c: Fix common/ includes.
7043         * arch/aarch64-insn.c: Fix common/ includes.
7044         * arch-utils.c: Fix common/ includes.
7045         * amd64-windows-tdep.c: Fix common/ includes.
7046         * amd64-tdep.c: Fix common/ includes.
7047         * amd64-sol2-tdep.c: Fix common/ includes.
7048         * amd64-obsd-tdep.c: Fix common/ includes.
7049         * amd64-nbsd-tdep.c: Fix common/ includes.
7050         * amd64-linux-tdep.c: Fix common/ includes.
7051         * amd64-linux-nat.c: Fix common/ includes.
7052         * amd64-fbsd-tdep.c: Fix common/ includes.
7053         * amd64-fbsd-nat.c: Fix common/ includes.
7054         * amd64-dicos-tdep.c: Fix common/ includes.
7055         * amd64-darwin-tdep.c: Fix common/ includes.
7056         * agent.c: Fix common/ includes.
7057         * ada-lang.h: Fix common/ includes.
7058         * ada-lang.c: Fix common/ includes.
7059         * aarch64-tdep.c: Fix common/ includes.
7060
7061 2019-01-25  Tom Tromey  <tom@tromey.com>
7062
7063         * common/create-version.sh: Use common/version.h.
7064
7065 2019-01-24  Pedro Alves  <palves@redhat.com>
7066
7067         * infrun.c (signal_stop, signal_print, signal_program)
7068         (signal_catch, signal_pass): Now arrays instead of pointers.
7069         (update_signals_program_target, do_target_resume)
7070         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
7071         * linux-nat.c (linux_nat_target::pass_signals)
7072         (linux_nat_target::create_inferior, linux_nat_target::attach):
7073         Adjust.
7074         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
7075         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
7076         * procfs.c (procfs_target::pass_signals): Adjust.
7077         * record-full.c (record_full_target::resume): Adjust.
7078         * remote.c (remote_target::pass_signals)
7079         (remote_target::program_signals): Adjust.
7080         * target-debug.h (target_debug_print_signals): Now takes a
7081         gdb::array_view as parameter.  Adjust.
7082         * target.h (target_ops) <pass_signals, program_signals>: Replace
7083         pointer and length parameters with gdb::array_view.
7084         (target_pass_signals, target_program_signals): Likewise.
7085         * target-delegates.c: Regenerate.
7086
7087 2019-01-24  Pedro Alves  <palves@redhat.com>
7088
7089         * common/forward-scope-exit.h
7090         (forward_scope_exit::forward_scope_exit): Pass arguments to
7091         m_bind_function directly, instead of creating a std::bind and
7092         copying that.
7093
7094 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
7095
7096         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7097         for static members.
7098         (pass_in_v_vfp_candidate): Likewise.
7099
7100 2019-01-23  Tom Tromey  <tom@tromey.com>
7101             Pedro Alves  <palves@redhat.com>
7102
7103         * regcache.c (class regcache_invalidator): Remove.
7104         (regcache::raw_write): Use make_scope_exit.
7105
7106 2019-01-23  Tom Tromey  <tom@tromey.com>
7107
7108         * ui-out.h (class ui_out_emit_type): Update comment.
7109
7110 2019-01-23  Tom Tromey  <tom@tromey.com>
7111
7112         * infrun.c (fetch_inferior_event): Update comment.
7113
7114 2019-01-23  Tom Tromey  <tom@tromey.com>
7115             Pedro Alves  <palves@redhat.com>
7116
7117         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
7118         parameter.
7119         (fetch_inferior_event): Use SCOPE_EXIT.
7120
7121
7122 2019-01-23  Tom Tromey  <tom@tromey.com>
7123             Pedro Alves  <palves@redhat.com>
7124
7125         * infrun.c (disable_thread_events): Delete.
7126         (stop_all_threads): Use SCOPE_EXIT.
7127
7128 2019-01-23  Tom Tromey  <tom@tromey.com>
7129             Pedro Alves  <palves@redhat.com>
7130
7131         * symfile.c: Include forward-scope-exit.h.
7132         (clear_symtab_users_cleanup): Replace forward declaration with
7133         a FORWARD_SCOPE_EXIT.
7134         (syms_from_objfile_1): Use the forward_scope_exit and
7135         gdb::optional instead of cleanup_function.
7136         (reread_symbols): Use the forward_scope_exit instead of
7137         cleanup_function.
7138         (clear_symtab_users_cleanup): Remove function.
7139
7140 2019-01-23  Tom Tromey  <tom@tromey.com>
7141             Pedro Alves  <palves@redhat.com>
7142
7143         * linux-nat.c: Include scope-exit.h.
7144         (cleanup_target_stop): Remove.
7145         (linux_nat_target::static_tracepoint_markers_by_strid): Use
7146         SCOPE_EXIT.
7147
7148 2019-01-23  Tom Tromey  <tom@tromey.com>
7149             Pedro Alves  <palves@redhat.com>
7150
7151         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
7152         (call_function_by_hand_dummy): Use SCOPE_EXIT.
7153
7154 2019-01-23  Tom Tromey  <tom@tromey.com>
7155             Andrew Burgess  <andrew.burgess@embecosm.com>
7156             Pedro Alves  <palves@redhat.com>
7157
7158         * infrun.c (fetch_inferior_event): Use scope_exit.
7159         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
7160         * top.c (execute_command): Use scope_exit.
7161         * breakpoint.c (bpstat_do_actions): Use scope_exit.
7162         * utils.c (do_bpstat_clear_actions_cleanup)
7163         (make_bpstat_clear_actions_cleanup): Remove.
7164
7165 2019-01-23  Tom Tromey  <tom@tromey.com>
7166             Pedro Alves  <palves@redhat.com>
7167
7168         * infrun.c: Include "common/scope-exit.h"
7169         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
7170         (wait_for_inferior): Use SCOPE_EXIT.
7171         (fetch_inferior_event): Use scope_exit.
7172
7173 2019-01-23  Tom Tromey  <tom@tromey.com>
7174             Pedro Alves  <palves@redhat.com>
7175
7176         * breakpoint.c (create_breakpoint): Remove cleanup.
7177
7178 2019-01-23  Tom Tromey  <tom@tromey.com>
7179             Andrew Burgess  <andrew.burgess@embecosm.com>
7180             Pedro Alves  <palves@redhat.com>
7181
7182 2019-01-23  Pedro Alves  <palves@redhat.com>
7183
7184         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
7185
7186 2019-01-23  Pedro Alves  <palves@redhat.com>
7187             Andrew Burgess  <andrew.burgess@embecosm.com>
7188
7189         * gdbthread.h: Include "common/forward-scope-exit.h".
7190         (scoped_finish_thread_state): Redefine custom class in terms of
7191         forward_scope_exit.
7192
7193 2019-01-23  Pedro Alves  <palves@redhat.com>
7194             Andrew Burgess  <andrew.burgess@embecosm.com>
7195
7196         * common/forward-scope-exit.h: New file.
7197
7198 2019-01-23  Pedro Alves  <palves@redhat.com>
7199             Andrew Burgess  <andrew.burgess@embecosm.com>
7200             Tom Tromey  <tom@tromey.com>
7201
7202         * common/scope-exit.h: New file.
7203
7204 2019-01-23  Pedro Alves  <palves@redhat.com>
7205
7206         * common/preprocessor.h (ESC): Rename to ...
7207         (ESC_PARENS): ... this.
7208         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
7209         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
7210
7211 2019-01-23  Tom Tromey  <tom@tromey.com>
7212
7213         * language.h (class scoped_switch_to_sym_language_if_auto):
7214         Initialize m_lang in both cases.
7215
7216 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
7217
7218         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
7219         with XCNEW.
7220
7221 2019-01-22  Tom Tromey  <tom@tromey.com>
7222
7223         * corelow.c: Do not include sys/file.h.
7224
7225 2019-01-22  Tom Tromey  <tom@tromey.com>
7226
7227         * tui/tui-wingeneral.h: Include gdb_curses.h.
7228
7229 2019-01-22  Tom Tromey  <tom@tromey.com>
7230
7231         * source-cache.h (class source_cache) <get_source_lines,
7232         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
7233
7234 2019-01-22  Tom Tromey  <tom@tromey.com>
7235
7236         * remote-fileio.h (struct remote_target): Declare.
7237
7238 2019-01-22  Tom Tromey  <tom@tromey.com>
7239
7240         * python/py-arch.c: Do not include py-ref.h.
7241         * python/py-bpevent.c: Do not include py-ref.h.
7242         * python/py-cmd.c: Do not include py-ref.h.
7243         * python/py-continueevent.c: Do not include py-ref.h.
7244         * python/py-event.h: Do not include py-ref.h.
7245         * python/py-evtregistry.c: Do not include py-ref.h.
7246         * python/py-finishbreakpoint.c: Do not include py-ref.h.
7247         * python/py-frame.c: Do not include py-ref.h.
7248         * python/py-framefilter.c: Do not include py-ref.h.
7249         * python/py-function.c: Do not include py-ref.h.
7250         * python/py-infevents.c: Do not include py-ref.h.
7251         * python/py-linetable.c: Do not include py-ref.h.
7252         * python/py-objfile.c: Do not include py-ref.h.
7253         * python/py-param.c: Do not include py-ref.h.
7254         * python/py-prettyprint.c: Do not include py-ref.h.
7255         * python/py-progspace.c: Do not include py-ref.h.
7256         * python/py-symbol.c: Do not include py-ref.h.
7257         * python/py-symtab.c: Do not include py-ref.h.
7258         * python/py-type.c: Do not include py-ref.h.
7259         * python/py-unwind.c: Do not include py-ref.h.
7260         * python/py-utils.c: Do not include py-ref.h.
7261         * python/py-value.c: Do not include py-ref.h.
7262         * python/py-varobj.c: Do not include py-ref.h.
7263         * python/py-xmethods.c: Do not include py-ref.h.
7264         * python/python.c: Do not include py-ref.h.
7265         * varobj.c: Do not include py-ref.h.
7266
7267 2019-01-22  Tom Tromey  <tom@tromey.com>
7268
7269         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
7270         keyword for bcache.
7271
7272 2019-01-22  Tom Tromey  <tom@tromey.com>
7273
7274         * compile/compile-cplus-types.c: Remove a comment by #include.
7275
7276 2019-01-22  Tom Tromey  <tom@tromey.com>
7277
7278         * compile/gcc-c-plugin.h: Include compile-internal.h.
7279
7280 2019-01-22  Tom Tromey  <tom@tromey.com>
7281
7282         * stabsread.c (EXTERN): Do not define.
7283         (symnum, next_symbol_text_func, processing_gcc_compilation)
7284         (within_function, global_sym_chain, global_stabs)
7285         (previous_stab_code, this_object_header_files)
7286         (n_this_object_header_files)
7287         (n_allocated_this_object_header_files): Define.
7288         * stabsread.h (EXTERN): Never define.  Use "extern".
7289
7290 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7291
7292         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
7293         history_value.
7294
7295 2019-01-21  Tom Tromey  <tom@tromey.com>
7296
7297         * ui-out.c: Fix includes.
7298         * tui/tui-source.c: Fix includes.
7299         * target.c: Fix includes.
7300         * remote.c: Fix includes.
7301         * regcache.c: Fix includes.
7302         * python/py-block.c: Fix includes.
7303         * printcmd.c: Fix includes.
7304         * or1k-tdep.c: Fix includes.
7305         * mi/mi-main.c: Fix includes.
7306         * m32r-tdep.c: Fix includes.
7307         * csky-tdep.c: Fix includes.
7308         * compile/compile-cplus-types.c: Fix includes.
7309         * cli/cli-interp.c: Fix includes.
7310
7311 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
7312
7313         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
7314         for padding.
7315
7316 2019-01-16  Tom Tromey  <tom@tromey.com>
7317
7318         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
7319         earlier.
7320         (struct objfile) <msymbols_range>: Move from top level.
7321         <msymbols>: New method.
7322         (class objfile_msymbols): Remove.
7323         * symtab.c (default_collect_symbol_completion_matches_break_on):
7324         Update.
7325         * symmisc.c (dump_msymbols): Update.
7326         * stabsread.c (scan_file_globals): Update.
7327         * objc-lang.c (info_selectors_command, info_classes_command)
7328         (find_methods): Update.
7329         * minsyms.c (find_solib_trampoline_target): Update.
7330         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
7331         * coffread.c (coff_symfile_read): Update.
7332         * ada-lang.c (ada_lookup_simple_minsym)
7333         (ada_collect_symbol_completion_matches): Update.
7334
7335 2019-01-16  Tom Tromey  <tom@tromey.com>
7336
7337         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
7338         type.  Remove no-argument constructor.
7339         <iterator::operator++>: Simplify.
7340         <begin>: Update.
7341         <end>: Use minimal_symbol_count.
7342
7343 2019-01-16  Tom Tromey  <tom@tromey.com>
7344
7345         * objfiles.h (struct objfile) <psymtabs>: New method.
7346         (class objfile_psymtabs): Remove.
7347         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
7348         typedef.
7349         <range>: New method.
7350         (require_partial_symbols): Change return type.
7351         * psymtab.c (require_partial_symbols)
7352         (psym_expand_symtabs_matching): Update.
7353         * mdebugread.c (parse_partial_symbols): Update.
7354         * dbxread.c (dbx_end_psymtab): Update.
7355
7356 2019-01-15  Tom Tromey  <tom@tromey.com>
7357
7358         * symtab.c (lookup_objfile_from_block)
7359         (lookup_symbol_in_objfile_symtabs)
7360         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
7361         (find_line_symtab, info_sources_command)
7362         (default_collect_symbol_completion_matches_break_on)
7363         (make_source_files_completion_list): Update.
7364         * symmisc.c (print_objfile_statistics, dump_objfile)
7365         (maintenance_print_symbols, maintenance_info_symtabs)
7366         (maintenance_check_symtabs, maintenance_info_line_tables):
7367         Update.
7368         * source.c (select_source_symtab)
7369         (forget_cached_source_info_for_objfile): Update.
7370         * objfiles.h (class objfile_compunits): Remove.
7371         (struct objfile) <compunits_range>: New typedef.
7372         (compunits): New method.
7373         * objfiles.c (objfile_relocate1): Update.
7374         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7375         * maint.c (count_symtabs_and_blocks): Update.
7376         * linespec.c (iterate_over_all_matching_symtabs): Update.
7377         * cp-support.c (add_symbol_overload_list_qualified): Update.
7378         * coffread.c (coff_symtab_read): Update.
7379         * ada-lang.c (add_nonlocal_symbols)
7380         (ada_collect_symbol_completion_matches)
7381         (ada_add_global_exceptions): Update.
7382
7383 2019-01-15  Tom Tromey  <tom@tromey.com>
7384
7385         * progspace.h (program_space) <objfiles_safe_range>: New
7386         typedef.
7387         <objfiles_safe>: New method.
7388         * objfiles.h (class all_objfiles_safe): Remove.
7389         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
7390         * jit.c (jit_inferior_exit_hook): Update.
7391
7392 2019-01-17  Tom Tromey  <tom@tromey.com>
7393
7394         * progspace.h (program_space) <objfiles_range>: New typedef.
7395         <objfiles>: New method.
7396         <objfiles_head>: Rename from objfiles.
7397         (object_files): Update.
7398         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
7399         * guile/scm-pretty-print.c
7400         (ppscm_find_pretty_printer_from_objfiles): Update.
7401         * guile/scm-objfile.c (gdbscm_objfiles): Update.
7402         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
7403         Update.
7404         * python/py-progspace.c (pspy_get_objfiles): Update.
7405         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7406         Update.
7407         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7408         (objfpy_lookup_objfile_by_build_id): Update.
7409         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
7410         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7411         Update.
7412         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7413         (expand_symtab_containing_pc, lookup_objfile_from_block)
7414         (lookup_static_symbol, basic_lookup_transparent_type)
7415         (find_pc_sect_compunit_symtab, find_symbol_at_address)
7416         (find_line_symtab, info_sources_command)
7417         (default_collect_symbol_completion_matches_break_on)
7418         (make_source_files_completion_list, find_main_name): Update.
7419         * symmisc.c (print_symbol_bcache_statistics)
7420         (print_objfile_statistics, maintenance_print_symbols)
7421         (maintenance_print_msymbols, maintenance_print_objfiles)
7422         (maintenance_info_symtabs, maintenance_check_symtabs)
7423         (maintenance_expand_symtabs, maintenance_info_line_tables):
7424         Update.
7425         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
7426         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
7427         (map_overlay_command, unmap_overlay_command)
7428         (simple_overlay_update, expand_symtabs_matching)
7429         (map_symbol_filenames): Update.
7430         * symfile-debug.c (set_debug_symfile): Update.
7431         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
7432         Update.
7433         * source.c (select_source_symtab, forget_cached_source_info):
7434         Update.
7435         * solib.c (solib_read_symbols): Update.
7436         * solib-spu.c (append_ocl_sos): Update.
7437         * psymtab.c (maintenance_print_psymbols)
7438         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
7439         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
7440         * printcmd.c (info_symbol_command): Update.
7441         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
7442         Update.
7443         * objfiles.h (class all_objfiles): Remove.
7444         * objfiles.c (have_partial_symbols, have_full_symbols)
7445         (have_minimal_symbols, qsort_cmp, update_section_map)
7446         (shared_objfile_contains_address_p)
7447         (default_iterate_over_objfiles_in_search_order): Update.
7448         * objc-lang.c (info_selectors_command, info_classes_command)
7449         (find_methods): Update.
7450         * minsyms.c (find_solib_trampoline_target): Update.
7451         * maint.c (maintenance_info_sections)
7452         (maintenance_translate_address, count_symtabs_and_blocks):
7453         Update.
7454         * main.c (captured_main_1): Update.
7455         * linux-thread-db.c (try_thread_db_load_from_pdir)
7456         (has_libpthread): Update.
7457         * linespec.c (iterate_over_all_matching_symtabs)
7458         (search_minsyms_for_name): Update.
7459         * jit.c (jit_find_objf_with_entry_addr): Update.
7460         * hppa-tdep.c (find_unwind_entry)
7461         (hppa_lookup_stub_minimal_symbol): Update.
7462         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
7463         Update.
7464         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7465         (elf_gnu_ifunc_resolve_by_got): Update.
7466         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
7467         * dwarf-index-write.c (save_gdb_index_command): Update.
7468         * cp-support.c (add_symbol_overload_list_qualified): Update.
7469         * breakpoint.c (create_overlay_event_breakpoint)
7470         (create_longjmp_master_breakpoint)
7471         (create_std_terminate_master_breakpoint)
7472         (create_exception_master_breakpoint): Update.
7473         * blockframe.c (find_pc_partial_function): Update.
7474         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
7475         (ada_collect_symbol_completion_matches)
7476         (ada_add_global_exceptions): Update.
7477
7478 2019-01-17  Tom Tromey  <tom@tromey.com>
7479
7480         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
7481         declare VEC.
7482         (solib_target_parse_libraries): Change return type.
7483         (library_list_start_segment, library_list_start_section)
7484         (library_list_end_library, library_list_start_library); Update.
7485         (solib_target_free_library_list): Remove.
7486         (solib_target_parse_libraries): Remove cleanup.  Change return
7487         type.
7488         (solib_target_current_sos): Update.
7489
7490 2019-01-17  Tom Tromey  <tromey@bapiya>
7491
7492         * valprint.c: Replace "the the" with "the".
7493         * symtab.c: Replace "the the" with "the".
7494         * solib.c: Replace "the the" with "the".
7495         * solib-dsbt.c: Replace "the the" with "the".
7496         * linespec.c: Replace "the the" with "the".
7497         * dwarf2loc.h: Replace "the the" with "the".
7498         * amd64-windows-tdep.c: Replace "the the" with "the".
7499         * aarch64-tdep.c: Replace "the the" with "the".
7500
7501 2019-01-16  Keith Seitz  <keiths@redhat.com>
7502
7503         PR gdb/23773
7504         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
7505         <builder>: Rename to ..
7506         <m_builder>: ... this and make private.
7507         (dwarf2_cu::get_builder): New method.  Change all users of
7508         `builder' to use this method.
7509         (dwarf2_start_symtab): Move to ...
7510         (dwarf2_cu::start_symtab): ... here.  Update all callers
7511         (setup_type_unit_groups): Move to ...
7512         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
7513         callers.
7514         (dwarf2_cu::reset_builder): New method.
7515         (process_full_compunit, process_full_type_unit): Use
7516         dwarf2_cu::reset_builder.
7517         (follow_die_offset): Record the ancestor CU if it is different
7518         from the followed DIE's CU.
7519         (follow_die_sig_1): Likewise.
7520
7521 2019-01-15  Tom Tromey  <tom@tromey.com>
7522
7523         * remote.c (class remote_state) <buf>: Now a char_vector.
7524         <buf_size>: Remove.
7525         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
7526         parameter.
7527         (remote_target::getpkt_or_notif_sane_1)
7528         (remote_target::getpkt_sane)
7529         (remote_target::getpkt_or_notif_sane): Likewise.
7530         (class remote_target) <putpkt>: New overload.
7531         (remote_target::read_frame): Change type of "buf_p".  Remove
7532         sizeof_p parameter.
7533         (packet_ok): New overload.
7534         (packet_check_result): New overload.
7535         Update all uses.
7536
7537 2019-01-14  Tom Tromey  <tom@tromey.com>
7538
7539         * remote-notif.c (handle_notification, remote_notif_ack)
7540         (remote_notif_parse): Make "buf" const.
7541         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7542         const.
7543         (remote_notif_parse, remote_notif_ack, handle_notification):
7544         Likewise.
7545         * remote.c (remote_notif_stop_parse): Make "buf" const.
7546         (remote_target::remote_parse_stop_reply): Make "buf" const.
7547         (remote_notif_stop_ack): Make "buf" const.
7548
7549 2019-01-14  Tom Tromey  <tom@tromey.com>
7550
7551         * remote.c (remote_console_output): Make parameter const.
7552
7553 2019-01-14  Tom Tromey  <tom@tromey.com>
7554
7555         * target-debug.h (target_debug_print_signals): Constify.
7556         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7557         * procfs.c (procfs_target::pass_signals): Update.
7558         * linux-nat.c (linux_nat_target::pass_signals): Update.
7559         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7560         * target-delegates.c: Rebuild.
7561         * remote.c (remote_target::program_signals): Update.
7562         (remote_target::pass_signals): Update.
7563         * target.c (target_pass_signals): Constify argument.
7564         (target_program_signals): Likewise.
7565         * target.h (struct target_ops) <pass_signals, program_signals>:
7566         Constify argument.
7567         (target_pass_signals, target_program_signals): Constify argument.
7568
7569 2019-01-14  Tom Tromey  <tom@tromey.com>
7570
7571         PR tui/28819:
7572         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7573
7574 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7575
7576         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7577         field.
7578         * rs6000-tdep.c: Include reggroups.h.
7579         (IS_V_ALIAS_PSEUDOREG): Define.
7580         (rs6000_register_name): Return names for the "vX" aliases.
7581         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7582         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7583         aliases.  Call default_register_reggroup_p for all other
7584         pseudo-registers.
7585         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7586         New functions.
7587         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7588         Handle "vX" aliases.
7589         (v_alias_pseudo_register_collect): New function.
7590         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7591         (rs6000_gdbarch_init): Initialize "vX" aliases as
7592         pseudo-registers.  Restore registration of
7593         rs6000_pseudo_register_reggroup_p with
7594         set_tdesc_pseudo_register_reggroup_p.
7595
7596 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7597
7598         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7599         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7600         set_gdbarch_num_pseudo_regs.
7601
7602 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7603
7604         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7605         Remove arg prefixname, add do_set and do_show.
7606         Add member functions set_list and show_list.
7607         * cli/cli-style.c (class cli_style_option): Update accordingly.
7608         (style_set_list): Move to file scope.
7609         (style_show_list): Likewise.
7610         (set_style): Call help_list.
7611         (show_style): Call cmd_show_list.
7612         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7613         Update to use the new macro.
7614
7615 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7616
7617         * ada-lang.c (_initialize_ada_language): Expand the help text
7618         for the "catch exception" command.
7619
7620 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7621
7622         * symtab.c (matching_obj_sections): Initialize obj,
7623         declare it closer to its usage.
7624
7625 2019-01-10  Tom Tromey  <tom@tromey.com>
7626
7627         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7628         (basic_inf_threads_range): Remove.
7629         (inf_threads_range, inf_non_exited_threads_range)
7630         (safe_inf_threads_range): Use next_adapter.
7631
7632 2019-01-10  Keith Seitz  <keiths@redhat.com>
7633
7634         PR gdb/23712
7635         PR symtab/23010
7636         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7637         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7638
7639 2019-01-10  Keith Seitz  <keiths@redhat.com>
7640
7641         PR gdb/23712
7642         PR symtab/23010
7643         * dictionary.c (pending_to_vector): Remove.
7644         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7645         Remove _1 suffix, replacing functions of the same name.  Update
7646         all callers.
7647         (dict_create_hashed, dict_create_hashed_expandable)
7648         (dict_create_linear, dict_create_linear_expandable, dict_free)
7649         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7650         Make functions static.
7651
7652 2019-01-10  Keith Seitz  <keiths@redhat.com>
7653
7654         PR gdb/23712
7655         PR symtab/23010
7656         * dictionary.h (struct dictionary): Replace declaration with
7657         multidictionary.
7658         (dict_create_hashed, dict_create_hashed_expandable)
7659         (dict_create_linear, dict_create_linear_expandable)
7660         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7661         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7662         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7663         taking multidictionary argument.
7664         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7665         * block.h (struct block) <dict>: Change to multidictionary
7666         and rename `multidict'.
7667         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7668         symmisc.c: Update all dictionary references to multidictionary.
7669
7670 2019-01-10  Keith Seitz  <keiths@redhat.com>
7671
7672         PR gdb/23712
7673         PR symtab/23010
7674         * dictionary.c: Include unordered_map.
7675         (pending_to_vector): New function.
7676         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7677         Rewrite the non-"_1" functions to take vector instead
7678         of linked list.
7679         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7680         "new" _1 versions of the same name.
7681         (multidictionary): Define.
7682         (std::hash<enum language): New definition.
7683         (collate_pending_symbols_by_language, mdict_create_hashed)
7684         (mdict_create_hashed_expandable, mdict_create_linear)
7685         (mdict_create_linear_expandable, mdict_free)
7686         (find_language_dictionary, create_new_language_dictionary)
7687         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7688         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7689         (mdict_size, mdict_empty): New functions.
7690         * dictionary.h (mdict_iterator): Define.
7691
7692 2019-01-10  Pedro Alves  <palves@redhat.com>
7693
7694         * breakpoint.c (read_uploaded_action)
7695         (create_tracepoint_from_upload): Adjust to use
7696         gdb::unique_xmalloc_ptr.
7697         * ctf.c (ctf_write_uploaded_tp):
7698         (SET_ARRAY_FIELD): Use emplace_back.
7699         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7700         * tracefile-tfile.c (tfile_write_uploaded_tp):
7701         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7702         gdb::unique_xmalloc_ptr.
7703         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7704         at_string, cond_string, cmd_strings>: Replace char pointers
7705         with gdb::unique_xmalloc_ptr.
7706
7707 2019-01-10  Pedro Alves  <palves@redhat.com>
7708
7709         * solib-target.c (library_list_start_library): Don't xstrdup name.
7710
7711 2019-01-10  Pedro Alves  <palves@redhat.com>
7712
7713         * mdebugread.c (parse_partial_symbols): Use
7714         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7715
7716 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7717
7718         * linux-fork.c (scoped_switch_fork_info)
7719         <~scoped_switch_fork_info>: Fix incorrect variable name.
7720
7721 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7722
7723         * linux-fork.c (scoped_switch_fork_info)
7724         <scoped_switch_fork_info>: Make explicit.
7725         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7726
7727 2019-01-10  Tom Tromey  <tom@tromey.com>
7728
7729         * objfiles.h (objfile::reset_psymtabs): Update.
7730         * objfiles.c (objfile::objfile): Update.
7731         * psymtab.h (psymtab_storage::obstack): Update.
7732         (psymtab_storage::m_obstack): Use gdb::optional.
7733         (class psymtab_storage): Update comment.  Remove objfile
7734         parameter.
7735         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7736
7737 2019-01-10  Tom Tromey  <tom@tromey.com>
7738
7739         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7740         <free_psymtabs>: Now private.
7741         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7742         (allocate_psymtab): Use new method.
7743
7744 2019-01-10  Tom Tromey  <tom@tromey.com>
7745
7746         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7747         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7748         * mdebugread.c (parse_partial_symbols): Use
7749         allocate_dependencies.
7750         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7751         allocate_dependencies.
7752         (process_psymtab_comp_unit_reader)
7753         (build_type_psymtab_dependencies): Likewise.
7754         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7755
7756 2019-01-10  Tom Tromey  <tom@tromey.com>
7757
7758         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7759         PSYMBOL_SET_LANGUAGE.
7760         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7761
7762 2019-01-10  Tom Tromey  <tom@tromey.com>
7763
7764         * psymtab.h (psymtab_storage::obstack): New method.
7765         <m_obstack>: Rename from obstack; now private.
7766         * psymtab.c (psymtab_storage): Update.
7767         * dwarf2read.c (create_addrmap_from_index)
7768         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7769         Update.
7770
7771 2019-01-10  Tom Tromey  <tom@tromey.com>
7772
7773         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7774         * objfiles.h (objfile::reset_psymtabs): New method.
7775
7776 2019-01-10  Tom Tromey  <tom@tromey.com>
7777
7778         * symmisc.c (print_symbol_bcache_statistics): Update.
7779         (print_objfile_statistics): Update.
7780         * symfile.c (reread_symbols): Update.
7781         * psymtab.h (class psymtab_storage): New.
7782         * psymtab.c (psymtab_storage): New constructor.
7783         (~psymtab_storage): New destructor.
7784         (require_partial_symbols): Update.
7785         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7786         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7787         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7788         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7789         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7790         (start_psymtab_common, end_psymtab_common)
7791         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7792         (allocate_psymtab): Update.
7793         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7794         Update.
7795         (dump_psymtab_addrmap, maintenance_print_psymbols)
7796         (maintenance_check_psymtabs): Update.
7797         (class objfile_psymtabs): Move to objfiles.h.
7798         * psympriv.h (discard_psymtab): Now inline.
7799         (psymtab_discarder::psymtab_discarder): Update.
7800         (psymtab_discarder::~psymtab_discarder): Update.
7801         (ALL_OBJFILE_PSYMTABS): Rewrite.
7802         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7803         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7804         Remove fields.
7805         <partial_symtabs>: New field.
7806         (class objfile_psymtabs): Move from psymtab.h.  Update.
7807         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7808         psymbol_cache.
7809         (objfile::~objfile): Don't destroy psymbol_cache.
7810         * mdebugread.c (parse_partial_symbols): Update.
7811         * dwarf2read.c (create_addrmap_from_index)
7812         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7813         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7814         (add_partial_subprogram, dwarf2_ranges_read): Update.
7815         * dwarf-index-write.c (write_address_map)
7816         (write_one_signatured_type, recursively_write_psymbols)
7817         (class debug_names, class debug_names, write_psymtabs_to_index):
7818         Update.
7819
7820 2019-01-10  Tom Tromey  <tom@tromey.com>
7821
7822         * symtab.h (SYMBOL_SET_NAMES): Update.
7823         (symbol_set_names): Update.
7824         (MSYMBOL_SET_NAMES): Update.
7825         * symtab.c (symbol_set_names): Change argument to be an
7826         objfile_per_bfd_storage.
7827         * psymtab.c (add_psymbol_to_bcache): Update.
7828         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7829
7830 2019-01-10  Tom Tromey  <tom@tromey.com>
7831
7832         * symtab.c (create_demangled_names_hash): Change argument to be an
7833         objfile_per_bfd_storage.
7834         (symbol_set_names): Update.
7835
7836 2019-01-10  Tom Tromey  <tom@tromey.com>
7837
7838         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7839         init_psymbol_list.
7840         * psymtab.c (init_psymbol_list): Do nothing if already called.
7841         * psympriv.h (init_psymbol_list): Add comment.
7842         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7843         init_psymbol_list.
7844         * dbxread.c (dbx_symfile_read): Unconditionally call
7845         init_psymbol_list.
7846
7847 2019-01-10  Tom Tromey  <tom@tromey.com>
7848
7849         * xcoffread.c (scan_xcoff_symtab): Update.
7850         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7851         "where".
7852         * mdebugread.c (parse_partial_symbols)
7853         (handle_psymbol_enumerators): Update.
7854         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7855         * dbxread.c (read_dbx_symtab): Update.
7856         * psympriv.h (psymbol_placement): New enum.
7857         (add_psymbol_to_list): Update.
7858
7859 2019-01-10  Tom Tromey  <tom@tromey.com>
7860
7861         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7862         static_psymbols parameters.
7863         (scan_xcoff_symtab): Update.
7864         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7865         static_psymbols parameters.
7866         * psympriv.h (start_psymtab_common): Update.
7867         * mdebugread.c (parse_partial_symbols): Update.
7868         * dwarf2read.c (create_partial_symtab): Update.
7869         * dbxread.c (read_dbx_symtab): Update.
7870         (start_psymtab): Remove global_psymbols and static_psymbols
7871         parameters.
7872
7873 2019-01-10  Tom Tromey  <tom@tromey.com>
7874
7875         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7876         * psymtab.c (allocate_psymtab): Add comment.
7877         * psympriv.h (allocate_psymtab): Add comment.
7878         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7879         initializations.
7880         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7881
7882 2019-01-10  Tom Tromey  <tom@tromey.com>
7883
7884         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7885         Don't declare.
7886         * mipsread.c: Include mdebugread.h.
7887         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7888         Declare.
7889         * elfread.c: Include mdebugread.h.
7890
7891 2019-01-09  Tom Tromey  <tom@tromey.com>
7892
7893         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7894         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7895         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7896         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7897         (psym_lookup_symbol, psym_find_last_source_symtab)
7898         (psym_forget_cached_source_info, psym_print_stats)
7899         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7900         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7901         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7902         (psym_find_compunit_symtab_by_address)
7903         (maintenance_print_psymbols, maintenance_info_psymtabs)
7904         (maintenance_check_psymtabs): Use ranged for.
7905         * psymtab.h (class objfile_psymtabs): New.
7906         (require_partial_symbols): Return objfile_psymtabs.
7907         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7908
7909 2019-01-09  Tom Tromey  <tom@tromey.com>
7910
7911         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7912         (find_pc_mapped_section, list_overlays_command)
7913         (map_overlay_command, unmap_overlay_command)
7914         (simple_overlay_update): Use all_objfiles.
7915         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7916         * printcmd.c (info_symbol_command): Use all_objfiles.
7917         * objfiles.h (ALL_OBJSECTIONS): Remove.
7918         * maint.c (maintenance_translate_address): Use all_objfiles.
7919         * gcore.c (gcore_create_callback): Use all_objfiles.
7920         (objfile_find_memory_regions): Likewise.
7921
7922 2019-01-09  Tom Tromey  <tom@tromey.com>
7923
7924         * symtab.c (find_line_symtab, info_sources_command)
7925         (make_source_files_completion_list): Use objfile_compunits.
7926         * source.c (select_source_symtab): Use objfile_compunits.
7927         * objfiles.h (struct objfile): Update comment.
7928         (ALL_OBJFILES): Remove.
7929         (ALL_FILETABS): Remove.
7930         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7931         objfile_compunits.
7932
7933 2019-01-09  Tom Tromey  <tom@tromey.com>
7934
7935         * symmisc.c (print_objfile_statistics, dump_objfile)
7936         (maintenance_print_symbols): Use compunit_filetabs.
7937         * source.c (forget_cached_source_info_for_objfile): Use
7938         compunit_filetabs.
7939         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7940         (ALL_FILETABS): Use compunit_filetabs.
7941         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7942         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7943
7944 2019-01-09  Tom Tromey  <tom@tromey.com>
7945
7946         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7947         (compunit_filetabs): New.
7948         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7949         compunit_filetabs.
7950         (info_sources_command, make_source_files_completion_list): Remove
7951         declaration.
7952         * symmisc.c (print_objfile_statistics, dump_objfile)
7953         (maintenance_print_symbols): Remove declaration.
7954         (maintenance_info_symtabs): Use compunit_filetabs.
7955         (maintenance_info_line_tables): Likewise.
7956         * source.c (select_source_symtab): Change local variable name.
7957         (forget_cached_source_info_for_objfile): Remove declaration.
7958         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7959         * objfiles.c (objfile_relocate1): Remove declaration.
7960         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7961         declaration.
7962         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7963         * coffread.c (coff_symtab_read): Remove declaration.
7964         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7965         compunit_filetabs.
7966
7967 2019-01-09  Tom Tromey  <tom@tromey.com>
7968
7969         * symtab.c (lookup_objfile_from_block)
7970         (find_pc_sect_compunit_symtab, search_symbols)
7971         (default_collect_symbol_completion_matches_break_on): Use
7972         objfile_compunits.
7973         * objfiles.h (ALL_COMPUNITS): Remove.
7974         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7975         * cp-support.c (add_symbol_overload_list_qualified): Use
7976         objfile_compunits.
7977         * ada-lang.c (ada_collect_symbol_completion_matches)
7978         (ada_add_global_exceptions): Use objfile_compunits.
7979
7980 2019-01-09  Tom Tromey  <tom@tromey.com>
7981
7982         * source.c (select_source_symtab)
7983         (forget_cached_source_info_for_objfile): Remove declaration.
7984         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7985         declaration.
7986         * maint.c (count_symtabs_and_blocks): Remove declaration.
7987         * cp-support.c (add_symbol_overload_list_qualified): Remove
7988         declaration.
7989         * coffread.c (coff_symtab_read): Remove declaration.
7990         * symtab.c (lookup_symbol_in_objfile_symtabs)
7991         (basic_lookup_transparent_type_1): Use objfile_compunits.
7992         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7993         (info_sources_command, search_symbols)
7994         (default_collect_symbol_completion_matches_break_on)
7995         (make_source_files_completion_list): Remove declaration.
7996         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7997         (ada_collect_symbol_completion_matches)
7998         (ada_add_global_exceptions): Remove declaration.
7999         * linespec.c (iterate_over_all_matching_symtabs): Use
8000         objfile_compunits.
8001         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
8002         (class objfile_compunits): New.
8003         (ALL_COMPUNITS): Use objfile_compunits.
8004         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
8005         (maintenance_check_symtabs, maintenance_info_line_tables): Use
8006         objfile_compunits.
8007         * objfiles.c (objfile_relocate1): Use objfile_compunits.
8008
8009 2019-01-09  Tom Tromey  <tom@tromey.com>
8010
8011         * symtab.c (search_symbols)
8012         (default_collect_symbol_completion_matches_break_on): Use
8013         objfile_msymbols.
8014         * ada-lang.c (ada_lookup_simple_minsym)
8015         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
8016         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
8017         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
8018         objfile_msymbols.
8019         * coffread.c (coff_symfile_read): Use objfile_msymbols.
8020         * symmisc.c (dump_msymbols): Use objfile_msymbols.
8021         * objc-lang.c (find_methods): Use objfile_msymbols.
8022         (info_selectors_command, info_classes_command): Likewise.
8023         * stabsread.c (scan_file_globals): Use objfile_msymbols.
8024         * objfiles.h (class objfile_msymbols): New.
8025         (ALL_OBJFILE_MSYMBOLS): Remove.
8026         (ALL_MSYMBOLS): Remove.
8027
8028 2019-01-09  Tom Tromey  <tom@tromey.com>
8029
8030         * common/next-iterator.h (next_adapter): Add Iterator template
8031         parameter.
8032         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
8033         (class all_objfiles_safe): New.
8034         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
8035         * objfiles.c (put_objfile_before): Update comment.
8036         (add_separate_debug_objfile): Likewise.
8037         (free_all_objfiles): Use all_objfiles_safe.
8038         (objfile_purge_solibs): Likewise.
8039
8040 2019-01-09  Tom Tromey  <tom@tromey.com>
8041
8042         * symtab.c (iterate_over_symtabs, matching_obj_sections)
8043         (expand_symtab_containing_pc, lookup_static_symbol)
8044         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
8045         (find_symbol_at_address, find_line_symtab, find_main_name): Use
8046         all_objfiles.
8047         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
8048         * breakpoint.c (create_overlay_event_breakpoint)
8049         (create_longjmp_master_breakpoint)
8050         (create_std_terminate_master_breakpoint)
8051         (create_exception_master_breakpoint): Use all_objfiles.
8052         * linux-thread-db.c (try_thread_db_load_from_pdir)
8053         (has_libpthread): Use all_objfiles.
8054         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
8055         * linespec.c (iterate_over_all_matching_symtabs)
8056         (search_minsyms_for_name): Use all_objfiles.
8057         * maint.c (maintenance_info_sections): Use all_objfiles.
8058         * main.c (captured_main_1): Use all_objfiles.
8059         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
8060         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
8061         * guile/scm-pretty-print.c
8062         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
8063         * solib-spu.c (append_ocl_sos): Use all_objfiles.
8064         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
8065         (maintenance_print_msymbols): Use all_objfiles.
8066         * source.c (select_source_symtab): Use all_objfiles.
8067         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
8068         * symfile.c (remove_symbol_file_command)
8069         (expand_symtabs_matching, map_symbol_filenames): Use
8070         all_objfiles.
8071         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
8072         all_objfiles.
8073         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
8074         * objc-lang.c (find_methods): Use all_objfiles.
8075         * objfiles.c (have_partial_symbols, have_full_symbols)
8076         (have_minimal_symbols, qsort_cmp)
8077         (default_iterate_over_objfiles_in_search_order): Use
8078         all_objfiles.
8079         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
8080         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
8081         (maintenance_check_psymtabs): Use all_objfiles.
8082         (ALL_PSYMTABS): Remove.
8083         * compile/compile-object-run.c (do_module_cleanup): Use
8084         all_objfiles.
8085         * blockframe.c (find_pc_partial_function): Use all_objfiles.
8086         * cp-support.c (add_symbol_overload_list_qualified): Use
8087         all_objfiles.
8088         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
8089         Use all_objfiles.
8090         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
8091         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
8092         all_objfiles.
8093         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
8094         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
8095         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
8096         Uses all_objfiles.
8097         * solib.c (solib_read_symbols): Use all_objfiles
8098
8099 2019-01-09  Tom Tromey  <tom@tromey.com>
8100
8101         * probe.c (parse_probes_in_pspace): Use all_objfiles.
8102         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
8103         all_objfiles.
8104         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
8105         * symmisc.c (print_symbol_bcache_statistics)
8106         (print_objfile_statistics, maintenance_print_objfiles)
8107         (maintenance_info_symtabs, maintenance_check_symtabs)
8108         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
8109         all_objfiles.
8110         * source.c (forget_cached_source_info): Use all_objfiles.
8111         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
8112         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
8113         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
8114         * objfiles.c (update_section_map): Use all_objfiles.
8115         (shared_objfile_contains_address_p): Likewise.
8116         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
8117         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
8118
8119 2019-01-09  Tom Tromey  <tom@tromey.com>
8120
8121         * common/next-iterator.h: New file.
8122         * objfiles.h (class all_objfiles): New.
8123         (struct objfile_iterator): New.
8124
8125 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8126
8127         * NEWS: Move the description of the changed "frame", "select-frame",
8128          and "info frame" commands to the Changed commands section.
8129
8130 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
8131
8132         * gdbtypes.c (check_stub_method_group): Remove handling of old
8133         mangling schemes.
8134         * linespec.c (find_methods): Likewise.
8135         * stabsread.c (read_member_functions): Likewise.
8136         * valops.c (search_struct_method): Likewise.
8137         (value_struct_elt_for_reference): Likewise.
8138         * NEWS: Mention this change.
8139
8140 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
8141
8142         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
8143         print_source_lines.
8144         * source.c (print_source_lines_base): Update line number check.
8145         (print_source_lines): New function.
8146         (source_lines_range::source_lines_range): New function.
8147         * source.h (class source_lines_range): New class.
8148         (print_source_lines): New declaration.
8149
8150 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8151
8152         * linespec.c (linespec_state_destructor): Free self->canonical_names.
8153
8154 2019-01-08  Tom Tromey  <tom@tromey.com>
8155             Simon Marchi  <simon.marchi@ericsson.com>
8156
8157         PR gdb/24060
8158         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
8159         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
8160         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8161         * f-exp.y (DOLLAR_VARIABLE): Likewise.
8162         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
8163         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
8164
8165 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8166
8167         * source.c (select_source_symtab): Move header comment to
8168         declaration in source.h.
8169         (forget_cached_source_info_for_objfile): Likewise.
8170         (forget_cached_source_info): Likewise.
8171         (identify_source_line): Likewise.
8172         * source.h (identify_source_line): Move declaration from symtab.h
8173         and add comment from source.c
8174         (print_source_lines): Likewise.
8175         (forget_cached_source_info_for_objfile): Likewise.
8176         (forget_cached_source_info): Likewise.
8177         (select_source_symtab): Likewise.
8178         (enum print_source_lines_flag): Move definition from symtab.h.
8179         * symtab.h (identify_source_line): Move declaration to source.h.
8180         (print_source_lines): Likewise.
8181         (forget_cached_source_info_for_objfile): Likewise.
8182         (forget_cached_source_info): Likewise.
8183         (select_source_symtab): Likewise.
8184         (enum print_source_lines_flag): Move definition to source.h.
8185         * tui/tui-hooks.c: Add 'source.h' include.
8186
8187 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * source.c (print_source_lines_base): Handle requests to print
8190         reverse line number sequences, and guard against empty lines
8191         string.
8192
8193 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
8194
8195         * source.c (print_source_lines_base): Fix skip of '\r' if next
8196         character is '\n'.
8197
8198 2019-01-06  Tom Tromey  <tom@tromey.com>
8199
8200         * c-exp.y (struct c_parse_state) <macro_original_text,
8201         expansion_obstack>: New member.
8202         (macro_original_text, expansion_obstack): Remove globals.
8203         (scan_macro_expansion, scanning_macro_expansion)
8204         (finished_macro_expansion): Update.
8205         (scan_macro_cleanup): Remove.
8206         (yylex, c_parse): Update.
8207
8208 2019-01-06  Tom Tromey  <tom@tromey.com>
8209
8210         * c-exp.y (struct c_parse_state) <strings>: New member.
8211         (operator_stoken): Update.
8212
8213 2019-01-06  Tom Tromey  <tom@tromey.com>
8214
8215         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
8216         (union type_stack_elt) <typelist_val>: Now a pointer to
8217         std::vector.
8218         (type_stack_cleanup): Don't declare.
8219         (push_typelist): Update.
8220         * parse.c (pop_typelist): Return a std::vector.
8221         (push_typelist): Take a std::vector.
8222         (follow_types): Update.  Do not free args.
8223         (type_stack_cleanup): Remove.
8224         * c-exp.y (struct c_parse_state): New.
8225         (cpstate): New global.
8226         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
8227         (nonempty_typelist): Update.
8228         (func_mod): Create a new vector.
8229         (c_parse): Create a c_parse_state.
8230         (check_parameter_typelist): Do not delete params.
8231         (function_method): Update.  Do not delete type_list.
8232
8233 2019-01-06  Tom Tromey  <tom@tromey.com>
8234
8235         PR gdb/28155:
8236         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
8237         check_typedef.
8238         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
8239         (print_return_value): Likewise.
8240
8241 2019-01-05  Tom Tromey  <tom@tromey.com>
8242
8243         * contrib/cleanup_check.py: Remove.
8244         * contrib/gcc-with-excheck: Remove.
8245         * contrib/exsummary.py: Remove.
8246         * contrib/excheck.py: Remove.
8247
8248 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
8249
8250         * thread.c (delete_thread_1): Add gdb_assert that THR is not
8251         NULL. Initialize tpprev to NULL instead of assigning it
8252         to NULL on the next statement.
8253         * windows-nat.c (windows_delete_thread): Remove check for
8254         main_thread_id before printing thread exit notifications.
8255         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
8256         Remove thread ID check against main_thread_id.
8257         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
8258         windows_delete_thread.
8259         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
8260
8261 2019-01-04  Tom Tromey  <tom@tromey.com>
8262
8263         * compile/compile.c (_initialize_compile): Use upper case for
8264         metasyntactic variables.
8265         * symmisc.c (_initialize_symmisc): Use upper case for
8266         metasyntactic variables.
8267         * psymtab.c (_initialize_psymtab): Use upper case for
8268         metasyntactic variables.
8269         * demangle.c (demangle_command): Use upper case for metasyntactic
8270         variables.
8271         (_initialize_demangler): Likewise.
8272         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
8273         variables.
8274
8275 2019-01-03  Tom Tromey  <tom@tromey.com>
8276
8277         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
8278
8279 2019-01-03  Tom Tromey  <tom@tromey.com>
8280
8281         * python/py-symtab.c (salpy_str): Update.
8282         (struct salpy_sal_object) <symtab>: Now a PyObject.
8283         (salpy_dealloc): Update.
8284         (del_objfile_sal): Use gdbpy_ref.
8285
8286 2019-01-03  Tom Tromey  <tom@tromey.com>
8287
8288         * python/py-type.c (convert_field): Use new_reference.  Return
8289         gdbpy_ref.
8290         (make_fielditem): Return gdbpy_ref.
8291         (typy_fields): Update.
8292         (typy_getitem): Update.
8293         (field_name): Return gdbpy_ref.  Use new_reference.
8294         (typy_iterator_iternext): Update.
8295
8296 2019-01-03  Tom Tromey  <tom@tromey.com>
8297
8298         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
8299
8300 2019-01-03  Tom Tromey  <tom@tromey.com>
8301
8302         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
8303         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
8304         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
8305         (pspy_set_frame_filters, pspy_set_frame_unwinders)
8306         (pspy_set_type_printers): Likewise.
8307         * python/py-function.c (fnpy_init): Use gdbpy_ref.
8308         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
8309         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
8310         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
8311         (objfpy_set_type_printers): Likewise.
8312
8313 2019-01-03  Tom Tromey  <tom@tromey.com>
8314
8315         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
8316         (gdbpy_print_stack): Use gdbpy_err_fetch.
8317         * python/python-internal.h (class gdbpy_err_fetch): New class.
8318         (class gdbpy_enter) <m_error_type, m_error_value,
8319         m_error_traceback>: Remove.
8320         <m_error>: New member.
8321         (gdbpy_exception_to_string): Don't declare.
8322         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
8323         * python/py-value.c (convert_value_from_python): Use
8324         gdbpy_err_fetch.
8325         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
8326         gdbpy_exception_to_string.
8327         (gdbpy_handle_exception): Use gdbpy_err_fetch.
8328         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
8329         gdbpy_err_fetch.
8330
8331 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8332
8333         * linux-nat.c (delete_lwp_cleanup): Delete.
8334         (struct lwp_deleter): New struct.
8335         (lwp_info_up): New typedef.
8336         (linux_nat_target::follow_fork): Delete cleanup, and make use of
8337         lwp_info_up.
8338
8339 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8340
8341         * linux-fork.c (class scoped_switch_fork_info): New class.
8342         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
8343
8344 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8345
8346         * valops.c (find_overload_match): Remove use of null_cleanup, and
8347         calls to do_cleanups.
8348
8349 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8350
8351         * compile/compile-cplus-types.c
8352         (compile_cplus_instance::decl_name): Handle changes to
8353         cp_func_name.
8354         * cp-support.c (cp_func_name): Update header comment, update
8355         return type.
8356         * cp-support.h (cp_func_name): Update return type in declaration.
8357         * valops.c (find_overload_match): Move temp_func local to top
8358         level of function and change its type.  Use temp_func to hold and
8359         delete temporary string obtained from cp_func_name.
8360
8361 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
8362
8363         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
8364         gdb::char_vector, remove cleanup, and update uses of `msg`.
8365
8366 2019-01-03  Jim Wilson  <jimw@sifive.com>
8367
8368         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
8369
8370 2019-01-02  Tom Tromey  <tom@tromey.com>
8371
8372         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
8373         (tdesc_parse_xml): Remove cleanups.
8374         * target-descriptions.h (make_cleanup_free_target_description):
8375         Don't declare.
8376         (target_desc_deleter): New struct.
8377         (target_desc_up): New typedef.
8378         * target-descriptions.c (target_desc_deleter::operator()): Rename
8379         from free_target_description.
8380         (make_cleanup_free_target_description): Remove.
8381
8382 2019-01-02  Tom Tromey  <tom@tromey.com>
8383
8384         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
8385         constructor, destructor.
8386         (linespec_parser): Remove typedef.
8387         (~linespec_parser): Rename from linespec_parser_delete.
8388         (linespec_lex_to_end, linespec_complete_label)
8389         (linespec_complete): Update.
8390         (decode_line_full): Remove cleanups.
8391         (decode_line_1): Update.
8392
8393 2019-01-02  Tom Tromey  <tom@tromey.com>
8394
8395         * python/python-internal.h (inferior_to_inferior_object): Change
8396         return type.
8397         * python/py-exitedevent.c (create_exited_event_object): Update.
8398         * python/py-inferior.c (inferior_to_inferior_object): Return
8399         gdbpy_ref.
8400         (python_new_inferior, python_inferior_deleted)
8401         (thread_to_thread_object, delete_thread_object)
8402         (build_inferior_list, gdbpy_selected_inferior): Update.
8403         * python/py-infthread.c (create_thread_object): Update.  Also fail
8404         if inferior_to_inferior_object fails.
8405
8406 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
8407
8408         * inferior.h (class inferior) <displaced_step_state>: New field.
8409         * infrun.h (struct displaced_step_state): Move here from
8410         infrun.c.  Initialize fields, add constructor.
8411         <inf>: Remove field.
8412         <reset>: New method.
8413         * infrun.c (struct displaced_step_inferior_state): Move to
8414         infrun.h.
8415         (displaced_step_inferior_states): Remove.
8416         (get_displaced_stepping_state): Adust.
8417         (displaced_step_in_progress_any_inferior): Adjust.
8418         (displaced_step_in_progress_thread): Adjust.
8419         (displaced_step_in_progress): Adjust.
8420         (add_displaced_stepping_state): Remove.
8421         (get_displaced_step_closure_by_addr): Adjust.
8422         (remove_displaced_stepping_state): Remove.
8423         (infrun_inferior_exit): Call displaced_step_state.reset.
8424         (use_displaced_stepping): Don't check for NULL.
8425         (displaced_step_prepare_throw): Call
8426         get_displaced_stepping_state.
8427         (displaced_step_fixup): Don't check for NULL.
8428         (prepare_for_detach): Don't check for NULL.
8429
8430 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8431
8432         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
8433          in case of call that did not complete.
8434
8435 2019-01-02  Andrey Utkin  <autkin@undo.io>
8436
8437         * symfile.c (find_separate_debug_file): Fix search of debug files for
8438         remote debuggee.
8439
8440 2019-01-02  Tom Tromey  <tom@tromey.com>
8441
8442         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
8443         indentation.
8444         * python/py-frame.c (frapy_older): Remove cast.
8445         (frapy_newer): Likewise.
8446         * python/py-breakpoint.c (local_setattro): Remove cast.
8447         * python/py-arch.c (archpy_name): Remove local variable.
8448         * python/py-type.c (gdbpy_lookup_type): Remove cast.
8449
8450 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
8451
8452         * unittests/basic_string_view/element_access/char/empty.cc:
8453         Fix year range in copyright header.
8454
8455 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
8456
8457         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
8458         Delete.
8459         <operator==>: Update with for removed field.
8460         <hash>: Likewise.
8461         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
8462         <isa_features>: ...this.
8463         <abi_features>: New field.
8464         (riscv_isa_flen): Update comment.
8465         (riscv_abi_xlen): New declaration.
8466         (riscv_abi_flen): New declaration.
8467         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
8468         isa_features.
8469         (riscv_abi_xlen): New function.
8470         (riscv_isa_flen): Update to get answer from isa_features.
8471         (riscv_abi_flen): New function.
8472         (riscv_has_fp_abi): Update to get answer from abi_features.
8473         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
8474         xlen and flen.
8475         (riscv_call_info) <xlen, flen>: Update comment.
8476         (riscv_call_arg_struct): Remove invalid assertions
8477         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
8478         is removed.
8479         (riscv_gdbarch_init): Gather isa features and abi features
8480         separately, ensure both match on the gdbarch when reusing an old
8481         gdbarch.  Relax an error check to allow 32-bit abi float to run on
8482         a target with 64-bit float hardware.
8483
8484 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8485
8486         * source.c (search_command_helper): Stop reverse search
8487         when line 1 has been searched.
8488
8489 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8490
8491         * record-full.c (record_full_base_target::close): Rewrite
8492         record_full_core_buf_list free logic.
8493
8494 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8495
8496         * break-catch-syscall.c (print_one_catch_syscall): xfree
8497         the last text.
8498
8499 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8500
8501         * top.c (print_gdb_version): Update Copyright year in version
8502         message.
8503
8504 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
8505
8506         Update copyright year range in all GDB files.
8507
8508 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
8509
8510         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
8511
8512 For older changes see ChangeLog-2018.
8513 \f
8514 Local Variables:
8515 mode: change-log
8516 left-margin: 8
8517 fill-column: 74
8518 version-control: never
8519 coding: utf-8
8520 End:
8521