gdb/ChangeLog

   1 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
   2
   3         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
   4         Update for new std::vector based implementation.
   5         (process_psymtab_comp_unit_reader): Likewise.
   6         (scan_partial_symbols): Likewise.
   7         (recursively_compute_inclusions): Likewise.
   8         (compute_compunit_symtab_includes): Likewise.
   9         (process_imported_unit_die): Likewise.
  10         (queue_and_load_dwo_tu): Likewise.
  11         (follow_die_sig_1): Likewise.
  12         * gdb/dwarf2read.h: Remove DEF_VEC_P.
  13         (typedef dwarf2_per_cu_ptr): Remove.
  14         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
  15         function.
  16         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
  17         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
  18         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
  19         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
  20         std::vector.
  21
  22 2019-10-15  Tom Tromey  <tromey@adacore.com>
  23
  24         * windows-nat.c (windows_nat_target::resume): Use %x when logging
  25         TID.
  26
  27 2019-10-15  Tom Tromey  <tromey@adacore.com>
  28
  29         * windows-nat.c (windows_nat_target::fetch_registers)
  30         (windows_nat_target::store_registers): Rename "pid" to "tid".
  31
  32 2019-10-15  Tom Tromey  <tromey@adacore.com>
  33
  34         * gdbarch.h, gdbarch.c: Rebuild.
  35         * gdbarch.sh (gcc_target_options): Change return type to
  36         std::string.
  37         * compile/compile.c (get_args): Update.
  38         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
  39         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
  40         std::string.
  41         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
  42         std::string.
  43         * arch-utils.c (default_gcc_target_options): Return std::string.
  44         * arch-utils.h (default_gcc_target_options): Return std::string.
  45         * s390-tdep.c (s390_gcc_target_options): Return std::string.
  46
  47 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
  48
  49         * breakpoint.c (breakpoint_chain): Make static.
  50         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
  51         of accessing breakpoint_chain.
  52
  53 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
  54
  55         * breakpoint.c (iterate_over_breakpoints): Change function pointer
  56         to a gdb::function_view and return value to bool.
  57         * breakpoint.h (iterate_over_breakpoints): Likewise.
  58         * dummy-frame.c (pop_dummy_frame_bpt): Update.
  59         (pop_dummy_frame): Update.
  60         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
  61         (gdbscm_breakpoints): Update.
  62         * python/py-breakpoint.c (build_bp_list): Update.
  63         (gdbpy_breakpoints): Update.
  64         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
  65         Update.
  66         (bpfinishpy_handle_stop): Update.
  67         (bpfinishpy_handle_exit): Update.
  68         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
  69         (svr4_update_solib_event_breakpoints): Update.
  70
  71 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
  72
  73         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
  74         when unwrapping single-field structs.
  75
  76 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
  77
  78         * dwarf2read.c: Remove includes.
  79
  80 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
  81
  82         * ui-out.c (ui_out::call_do_message): Silence
  83         -Wformat-nonliteral warning.
  84
  85 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
  86
  87         * breakpoint.c: Remove some includes: continuations.h, skip.h,
  88         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
  89         include: readline/tilde.h.
  90
  91 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  92
  93         * remote.c (remote_target::get_trace_status): Remove declaration of
  94         trace_regblock_size.
  95
  96 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
  97
  98         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
  99         (show_user): Remove declaration of cmdlist.
 100         * cli/cli-cmds.h (max_user_call_depth): Declare.
 101         * cli/cli-script.c (execute_user_command): Remove declaration
 102         of max_user_call_depth.
 103
 104 2019-10-11  Jim Wilson  <jimw@sifive.com>
 105
 106         * gdbsupport/print-utils.h (pulongest): Fix comment.
 107         (plongest): Likewise.
 108         (phex): Add missing comment, mention leading zeros.
 109         (phex_nz): Add mention of no leading zeros to comment.
 110
 111         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
 112         plongest instead of unsigned long long cast.
 113
 114 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 115
 116         * main.c (captured_main_1): Include gdbtk.h and remove declarations
 117         for external_editor_command and gdbtk_test.
 118
 119 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
 120
 121         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
 122         * varobj.c (varobjdebug): Move comment to...
 123         * varobj.h (varobjdebug): ...here, and declare.
 124
 125 2019-10-09  Tom Tromey  <tom@tromey.com>
 126
 127         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
 128         erase_data_content.
 129
 130 2019-10-09  Tom Tromey  <tom@tromey.com>
 131
 132         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
 133         * tui/tui-stack.c (tui_locator_window::rerender): Update.
 134         * tui/tui-command.c (tui_cmd_window::resize)
 135         (tui_refresh_cmd_win): Update.
 136         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
 137         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
 138         * tui/tui-data.c (~tui_gen_win_info): Remove.
 139         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 140         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
 141         (tui_redisplay_readline, tui_mld_flush)
 142         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
 143         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
 144         (tui_data_window::erase_data_content)
 145         (tui_data_item_window::rerender)
 146         (tui_data_item_window::refresh_window): Update.
 147         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
 148         (box_win, tui_gen_win_info::make_window)
 149         (tui_gen_win_info::make_visible): Update.
 150         (tui_delete_win): Remove.
 151         * tui/tui-winsource.c
 152         (tui_source_window_base::do_erase_source_content): Update.
 153         (tui_show_source_line, tui_source_window_base::update_tab_width)
 154         (tui_source_window_base::update_exec_info): Update.
 155         * tui/tui-data.h (struct curses_deleter): New.
 156         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
 157         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
 158
 159 2019-10-09  Tom Tromey  <tom@tromey.com>
 160
 161         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
 162
 163 2019-10-09  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
 166         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
 167
 168 2019-10-09  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
 171         window height directly.
 172         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
 173         declare.
 174         * tui/tui-layout.c (tui_default_win_height): Remove.
 175         (tui_default_win_viewport_height): Remove.
 176
 177 2019-10-09  Tom Tromey  <tom@tromey.com>
 178
 179         * tui/tui.h: Remove comments.
 180
 181 2019-10-09  Tom de Vries  <tdevries@suse.de>
 182
 183         * python/lib/gdb/printer/bound_registers.py: Use
 184         '^builtin_type_bound128' as regexp argument for
 185         add_builtin_pretty_printer.
 186
 187 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
 188
 189         * guile/guile.c (guile_extension_script_ops): Remove forward
 190         declaration and mark as static.
 191         (guile_script_ops): Likewise.
 192         (extension_language_guile): Move further down in the file so
 193         it can reference the definitions for guile_{extension_,}script_ops.
 194
 195 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
 196
 197         * s390-tdep.c (390_process_record): Handle new arch13 instructions
 198         except SORTL, DFLTCC, and KDSA.
 199
 200 2019-10-08  Tom Tromey  <tromey@adacore.com>
 201
 202         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
 203         (struct safe_symbol_file_add_args): Remove.
 204
 205 2019-10-08  Tom Tromey  <tromey@adacore.com>
 206
 207         * windows-nat.c: Don't include buildsym-legacy.h.
 208
 209 2019-10-08  Tom Tromey  <tromey@adacore.com>
 210
 211         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
 212
 213 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 214
 215         * gdbtypes.c (overload_debug): Move comment to header.
 216         * gdbtypes.h (overload_debug): Declare.
 217         * valops.c: Remove declaration of overload_debug, instead
 218         include gdbtypes.h.
 219
 220 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
 221
 222         * language.c (show_language_command): Pass lang_frame_mismatch_warn
 223         through _().
 224         (lang_frame_mismatch_warn): Make const, mark with N_(), and
 225         move comment...
 226         * language.h (lang_frame_mismatch_warn): ... here. Also add
 227         declaration.
 228         * top.c (lang_frame_mismatch_warn): Remove declaration.
 229         (check_frame_language_change): Pass lang_frame_mismatch_warn
 230         through _().
 231
 232 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 233
 234         * c-lang.h (vtbl_ptr_name): Declare.
 235         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
 236         it from the header.
 237         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
 238
 239 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
 240
 241         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
 242         gdb_static_assert.
 243
 244 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 245
 246         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
 247         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
 248         * ctfread.c: New file.
 249         * ctfread.h: New file.
 250         * elfread.c: Include ctfread.h.
 251         (struct elfinfo text_p): New member ctfsect.
 252         (elf_locate_sections): Mark CTF section.
 253         (elf_symfile_read): Call elfctf_build_psymtabs.
 254         * Makefile.in (LIBCTF): Add.
 255         (CLIBS): Use it.
 256         (CDEPS): Likewise.
 257         (DIST): Add ctfread.c.
 258
 259 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
 260
 261         * ctfread.c (struct nextfield): Renamed to ...
 262         (struct ctf_nextfield): ... this.
 263         (struct field_info): Renamed to ...
 264         (strut ctf_field_info): ... this.
 265         (attach_fields_to_type): Update for renamed structures.
 266         (ctf_add_member_cb): Likewise.
 267         (ctf_add_enum_member_cb): Likewise.
 268         (process_struct_members): Likewise.
 269         (process_enum_type): Likewise.
 270
 271 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
 272
 273         * tracectf.h: Rename, was ctf.h.
 274         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
 275         * tracefile.c: Likewise.
 276         * tracepoint.c: Remove unused include ctf.h.
 277         * mi/mi-main.c: Likewise.
 278         * Makefile.in Replace ctf.c with tracectf.c.
 279
 280 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
 281
 282         * version.in: Change version number to "9.0.50.DATE-git".
 283
 284 2019-10-03  Tom Tromey  <tom@tromey.com>
 285
 286         PR rust/24976:
 287         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
 288
 289 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 290
 291         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
 292         cp_search_name_hash.
 293         * NEWS: Add entry about nested function support.
 294
 295 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
 296             Andrew Burgess  <andrew.burgess@embecosm.com>
 297
 298         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
 299         for nested static variables when searchin VAR_DOMAIN.
 300         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
 301         global scope, update comment.
 302         (add_partial_subprogram): Call add_partial_subprogram recursively
 303         for nested subroutines when processinng Fortran.
 304         (load_partial_dies): Process the child entities of a subprogram
 305         when processing Fortran.
 306         (partial_die_parent_scope): Handle building scope
 307         for Fortran nested functions.
 308         (process_die): Record that nested functions have a scope.
 309         (new_symbol): Always record Fortran subprograms on the global
 310         symbol list.
 311         (determine_prefix): How to build the prefix for Fortran
 312         subprograms.
 313
 314 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 315
 316         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
 317         have just sent the thread a SIGSTOP and are waiting for it to
 318         arrive.
 319
 320 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
 321
 322         * btrace.c (btrace_add_pc): Remove whitespace before the template
 323         parameter in 'std::vector <...>'.
 324         (parse_xml_btrace_block): Likewise.
 325         (btrace_maint_decode_pt): Likewise.
 326         (btrace_maint_update_packets): Likewise.
 327         (btrace_maint_print_packets): Likewise.
 328         * btrace.h (struct btrace_maint_info): Likewise.
 329         * dwarf2read.c (struct type_unit_group): Likewise.
 330         (build_type_psymtabs_reader): Likewise.
 331         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
 332         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
 333         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
 334
 335 2019-10-03  Tom de Vries  <tdevries@suse.de>
 336
 337         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
 338         the first line of the help text for set/show style metadata.
 339
 340 2019-10-02  Tom Tromey  <tromey@adacore.com>
 341
 342         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
 343         * gdbsupport/common-inferior.c: New file.
 344         * infcmd.c (startup_with_shell): Don't define.
 345         * nat/fork-inferior.h (startup_with_shell): Don't declare.
 346         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
 347         * inferior.h (startup_with_shell): Don't declare.
 348
 349 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
 350
 351         * gdbsupport/gdb_assert.h: Include errors.h.
 352         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
 353
 354 2019-10-02  Tom Tromey  <tromey@adacore.com>
 355
 356         * NEWS: Add $_ada_exception entry.
 357         * ada-lang.c (struct ada_catchpoint): Add constructor.
 358         <m_kind>: New member.
 359         (allocate_location_exception, re_set_exception): Remove
 360         "ex" parameter.
 361         (should_stop_exception): Compute $_ada_exception.
 362         (check_status_exception, print_it_exception)
 363         (print_one_exception, print_mention_exception): Remove
 364         "ex" parameter.
 365         (allocate_location_catch_exception, re_set_catch_exception)
 366         (check_status_exception, print_it_catch_exception)
 367         (print_one_catch_exception, print_mention_catch_exception)
 368         (print_recreate_catch_exception)
 369         (allocate_location_catch_exception_unhandled)
 370         (re_set_catch_exception_unhandled)
 371         (check_status_exception, print_it_catch_exception_unhandled)
 372         (print_one_catch_exception_unhandled)
 373         (print_mention_catch_exception_unhandled)
 374         (print_recreate_catch_exception_unhandled)
 375         (allocate_location_catch_assert, re_set_catch_assert)
 376         (check_status_assert, print_it_catch_assert)
 377         (print_one_catch_assert, print_mention_catch_assert)
 378         (print_recreate_catch_assert)
 379         (allocate_location_catch_handlers, re_set_catch_handlers)
 380         (check_status_handlers, print_it_catch_handlers)
 381         (print_one_catch_handlers, print_mention_catch_handlers)
 382         (print_recreate_catch_handlers): Remove.
 383         (create_ada_exception_catchpoint): Update.
 384         (initialize_ada_catchpoint_ops): Update.
 385
 386 2019-10-02  Tom Tromey  <tromey@adacore.com>
 387
 388         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
 389         (create_excep_cond_exprs): Simplify exception string computation.
 390         (ada_exception_catchpoint_cond_string): Likewise.
 391
 392 2019-10-02  Tom Tromey  <tromey@adacore.com>
 393
 394         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
 395         * ada-lang.c (lesseq_defined_than): Handle
 396         LOC_STATIC.
 397         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
 398         parameter.
 399         (dwarf2_has_info): Likewise.
 400         (new_symbol): Set maybe_copied on symbol when
 401         appropriate.
 402         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
 403         parameter.
 404         <can_copy>: New member.
 405         * elfread.c (record_minimal_symbol): Set maybe_copied
 406         on symbol when appropriate.
 407         (elf_symfile_read): Update call to dwarf2_has_info.
 408         * minsyms.c (lookup_minimal_symbol_linkage): New
 409         function.
 410         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
 411         * symtab.c (get_symbol_address, get_msymbol_address):
 412         New functions.
 413         * symtab.h (get_symbol_address, get_msymbol_address):
 414         Declare.
 415         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
 416         maybe_copied.
 417         (struct symbol, struct minimal_symbol) <maybe_copied>:
 418         New member.
 419
 420 2019-10-02  Tom Tromey  <tromey@adacore.com>
 421
 422         * source.c (struct current_source_location): New.
 423         (current_source_key): New global.
 424         (current_source_symtab, current_source_line)
 425         (current_source_pspace): Remove.
 426         (get_source_location): New function.
 427         (get_current_source_symtab_and_line)
 428         (set_default_source_symtab_and_line)
 429         (set_current_source_symtab_and_line)
 430         (clear_current_source_symtab_and_line, select_source_symtab)
 431         (info_source_command, print_source_lines_base)
 432         (info_line_command, search_command_helper, _initialize_source):
 433         Update.
 434
 435 2019-10-02  Tom Tromey  <tromey@adacore.com>
 436
 437         * source.c (select_source_symtab): Don't call
 438         decode_line_with_current_source.
 439
 440 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 441
 442         * symtab.c (lookup_global_symbol): Search global block.
 443
 444 2019-10-02  Tom Tromey  <tromey@adacore.com>
 445
 446         * coffread.c (process_coff_symbol): Update.
 447         * dwarf2read.c (var_decode_location, new_symbol): Update.
 448         * mdebugread.c (parse_symbol): Update.
 449         * objfiles.c (relocate_one_symbol): Update.
 450         * stabsread.c (define_symbol, fix_common_block)
 451         (scan_file_globals): Update.
 452         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
 453         (SET_SYMBOL_VALUE_ADDRESS): New macro.
 454         * xcoffread.c (process_xcoff_symbol): Update.
 455
 456 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
 457
 458         * MAINTAINERS: Update my email address.
 459
 460 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 461
 462         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
 463         std::vector.
 464         (build_type_psymtabs_reader): Update for std::vector.
 465         (build_type_psymtab_dependencies): Likewise.
 466         * dwarf2read.h: Remove use of DEF_VEC_P.
 467         (typedef sig_type_ptr): Delete.
 468
 469 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 470
 471         * btrace.c (btrace_maint_clear): Update to handle change from VEC
 472         to std::vector.
 473         (btrace_maint_decode_pt): Likewise, and move allocation of the
 474         vector outside of the loop.
 475         (btrace_maint_update_packets): Update to handle change from VEC to
 476         std::vector.
 477         (btrace_maint_print_packets): Likewise.
 478         (maint_info_btrace_cmd): Likewise.
 479         * btrace.h: Remove use of DEF_VEC_O.
 480         (typedef btrace_pt_packet_s): Delete.
 481         (struct btrace_maint_info) <packets>: Change fromm VEC to
 482         std::vector.
 483         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
 484
 485 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
 486
 487         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
 488         make accesses into the vector constant references.
 489         (btrace_add_pc): Update for std::vector.
 490         (btrace_stitch_bts): Likewise.
 491         (parse_xml_btrace_block): Likewise.
 492         (btrace_maint_update_packets): Likewise.
 493         (btrace_maint_print_packets): Likewise.
 494         (maint_info_btrace_cmd): Likewise.
 495         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
 496         std::vector.
 497         (btrace_data::empty): Likewise.
 498         (btrace_data_append): Likewise.
 499         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
 500         (typedef btrace_block_s): Delete.
 501         (struct btrace_block): Add constructor.
 502         (struct btrace_data_bts) <blocks>: Change to std::vector.
 503         * nat/linux-btrace.c (perf_event_read_bts): Update for
 504         std::vector.
 505         (linux_read_bts): Likewise.
 506
 507 2019-10-01  Tom Tromey  <tom@tromey.com>
 508
 509         * cli/cli-logging.c (show_logging_filename): Use styled_string.
 510
 511 2019-10-01  Tom Tromey  <tom@tromey.com>
 512
 513         * stack.c (print_frame, info_frame_command_core): Use
 514         styled_string.
 515         * linux-thread-db.c (try_thread_db_load_1)
 516         (try_thread_db_load_from_pdir_1): Use styled_string.
 517         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
 518         (auto_load_section_scripts, info_auto_load_local_gdbinit)
 519         (maybe_print_unsupported_script_warning)
 520         (maybe_print_script_not_found_warning): Use styled_string.
 521         * ada-lang.c (user_select_syms): Use styled_string.
 522
 523 2019-10-01  Tom Tromey  <tom@tromey.com>
 524
 525         * p-lang.c (pascal_printstr): Use metadata style.
 526         * value.c (show_convenience): Use metadata style.
 527         * valprint.c (valprint_check_validity, val_print_optimized_out)
 528         (val_print_not_saved, val_print_unavailable)
 529         (val_print_invalid_address, generic_val_print, val_print)
 530         (value_check_printable, val_print_array_elements): Use metadata
 531         style.
 532         * ui-out.h (class ui_out) <field_fmt>: New overload.
 533         <do_field_fmt>: Add style parameter.
 534         * ui-out.c (ui_out::field_fmt): New overload.
 535         * typeprint.c (type_print_unknown_return_type)
 536         (val_print_not_allocated, val_print_not_associated): Use metadata
 537         style.
 538         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
 539         parameter.
 540         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
 541         * tracepoint.c (tvariables_info_1): Use metadata style.
 542         * stack.c (print_frame_arg, print_frame_info, print_frame)
 543         (info_frame_command_core): Use metadata style.
 544         * skip.c (info_skip_command): Use metadata style.
 545         * rust-lang.c (rust_print_enum): Use metadata style.
 546         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
 547         metadata style.
 548         * python/py-framefilter.c (py_print_single_arg): Use metadata
 549         style.
 550         * printcmd.c (do_one_display, print_variable_and_value): Use
 551         metadata style.
 552         * p-valprint.c (pascal_val_print)
 553         (pascal_object_print_value_fields): Use metadata style.
 554         * p-typeprint.c (pascal_type_print_base): Use metadata style.
 555         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
 556         parameter.
 557         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
 558         * m2-valprint.c (m2_print_long_set): Use metadata style.
 559         * m2-typeprint.c (m2_print_type): Use metadata style.
 560         * infcmd.c (print_return_value_1): Use metadata style.
 561         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
 562         * f-valprint.c (info_common_command_for_block): Use metadata
 563         style.
 564         * f-typeprint.c (f_type_print_base): Use metadata style.
 565         * expprint.c (print_subexp_standard): Use metadata style.
 566         * cp-valprint.c (cp_print_value_fields): Use metadata style.
 567         * cli/cli-style.h (class cli_style_option): Add constructor.
 568         (metadata_style): Declare.
 569         * cli/cli-style.c (metadata_style): New global.
 570         (_initialize_cli_style): Register metadata style.
 571         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
 572         parameter.
 573         * cli-out.c (cli_ui_out::do_field_fmt): Update.
 574         * c-typeprint.c (c_type_print_base_struct_union)
 575         (c_type_print_base_1): Use metadata style.
 576         * breakpoint.c (watchpoint_value_print)
 577         (print_one_breakpoint_location): Use metadata style.
 578         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
 579         style.
 580         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
 581         style.
 582         * ada-valprint.c (val_print_packed_array_elements, printstr)
 583         (print_field_values, ada_val_print_ref, ada_val_print): Use
 584         metadata style.
 585         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
 586         style.
 587         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
 588         style.
 589         * ada-lang.c (user_select_syms): Use metadata style.
 590
 591 2019-10-01  Tom Tromey  <tom@tromey.com>
 592
 593         * cli/cli-cmds.c (pwd_command): Style output.
 594
 595 2019-10-01  Pedro Alves  <palves@redhat.com>
 596             Tom Tromey  <tom@tromey.com>
 597
 598         * symtab.c (print_symbol_info): Use %ps.
 599         (print_msymbol_info): Use %ps.
 600         * symfile.c (symbol_file_add_with_addrs): Use %ps.
 601         * printcmd.c (print_variable_and_value): Use %ps.
 602         * macrocmd.c (show_pp_source_pos): Use %ps.
 603         * infrun.c (print_exited_reason): Use ui_out::message.
 604         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
 605         (describe_other_breakpoints): Use ui_out::message and new
 606         formats.
 607         (say_where): Use new formats.
 608         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
 609         and new formats.
 610
 611 2019-10-01  Pedro Alves  <palves@redhat.com>
 612             Tom Tromey  <tom@tromey.com>
 613
 614         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
 615         (test_gdb_formats): New function.
 616         (run_tests): Call it.
 617         (test_format_specifier): Update.
 618         * utils.h (fputs_filtered): Update comment.
 619         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
 620         (fputs_styled_unfiltered): Declare.
 621         * utils.c (fputs_styled_unfiltered): New function.
 622         (vfprintf_maybe_filtered): Add gdbfmt parameter.
 623         (vfprintf_filtered): Update.
 624         (vfprintf_unfiltered, vprintf_filtered): Update.
 625         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
 626         * ui-out.h (enum ui_out_flag) <unfiltered_output,
 627         disallow_ui_out_field>: New constants.
 628         (enum class field_kind): New.
 629         (struct base_field_s, struct signed_field_s): New.
 630         (signed_field): New function.
 631         (struct string_field_s): New.
 632         (string_field): New function.
 633         (struct styled_string_s): New.
 634         (styled_string): New function.
 635         (class ui_out) <message>: Add comment.
 636         <vmessage, call_do_message>: New methods.
 637         <do_message>: Add style parameter.
 638         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
 639         methods.
 640         (ui_out::message): Rewrite.
 641         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
 642         parameter.
 643         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
 644         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
 645         gdb_extensions parameter.
 646         (class format_piece): Add parameter to constructor.
 647         (n_int_args): New field.
 648         * gdbsupport/format.c (format_pieces::format_pieces): Add
 649         gdb_extensions parameter.  Handle '*'.
 650         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
 651         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
 652         vfprintf_styled_no_gdbfmt.
 653         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
 654         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
 655         unfiltered output.
 656         * ui-style.h (struct ui_file_style) <ptr>: New method.
 657
 658 2019-10-01  Tom Tromey  <tom@tromey.com>
 659
 660         * unittests/format_pieces-selftests.c: Update.  Add final format.
 661         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
 662         empty literal pieces.
 663
 664 2019-10-01  Tom Tromey  <tom@tromey.com>
 665
 666         * ui-out.h (enum class ui_out_style_kind): Remove.
 667         (class ui_out) <field_string, field_stsream, do_field_string>:
 668         Change type of "style".
 669         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
 670         (ui_out::field_string): Update.
 671         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
 672         of "style".
 673         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 674         * tracepoint.c (print_one_static_tracepoint_marker): Update.
 675         * stack.c (print_frame_arg, print_frame_info, print_frame):
 676         Update.
 677         * source.c (print_source_lines_base): Update.
 678         * solib.c (info_sharedlibrary_command): Update.
 679         * skip.c (info_skip_command): Update.
 680         * record-btrace.c (btrace_call_history_src_line)
 681         (btrace_call_history): Update.
 682         * python/py-framefilter.c (py_print_frame): Update.
 683         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
 684         "style".
 685         * mi/mi-out.c (mi_ui_out::do_table_header)
 686         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
 687         (mi_ui_out::do_field_string): Update.
 688         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
 689         Update.
 690         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
 691         "style".
 692         * cli-out.c (cli_ui_out::do_table_header)
 693         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
 694         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
 695         (cli_ui_out::do_field_fmt): Update.
 696         * breakpoint.c (print_breakpoint_location): Update.
 697         (update_static_tracepoint): Update.
 698
 699 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 700
 701         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
 702         conversion of gdb_datadir.
 703         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
 704         remove not needed c_str ().
 705
 706 2019-09-30  Ali Tamur <tamur@google.com>
 707
 708         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
 709         (dwarf2_string_attr): Likewise.
 710
 711 2019-09-30  Ali Tamur <tamur@google.com>
 712
 713         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
 714         (process_full_type_unit): Likewise.
 715         (dump_die_shallow): Likewise.
 716         (cu_debug_loc_section): Likewise.
 717
 718 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
 719
 720         * minsyms.c (compare_minimal_symbols): Rename to...
 721         (minimal_symbol_is_less_than): ...this, and adjust to STL
 722         conventions (return bool, take arguments as references)
 723         (minimal_symbol_reader::install): Call std::sort instead
 724         of qsort.
 725
 726 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
 727
 728         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
 729         hash and why.
 730         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
 731         msymbol_hash, msymbol_demangled_hash>: Improve comments.
 732
 733 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
 734
 735         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
 736         * psympriv.h (add_psymbol_to_list): Move comment here and update
 737         it.
 738
 739 2019-09-29  Tom de Vries  <tdevries@suse.de>
 740
 741         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
 742         Use $tmpdir/$(basename "$output_file").dwz instead of
 743         "${output_file}.dwz".
 744
 745 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
 746
 747         PR gdb/25045
 748         * hppa-linux-nat.c: Include gdbarch.h.
 749
 750 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
 751
 752         * blockframe.c (find_pc_partial_function): Change return type to bool.
 753         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
 754         * minsyms.c (in_gnu_ifunc_stub): Likewise.
 755         (stub_gnu_ifunc_resolve_name): Likewise.
 756         * symtab.c (compare_filenames_for_search): Likewise.
 757         (compare_glob_filenames_for_search): Likewise.
 758         (matching_obj_sections): Likewise.
 759         (symbol_matches_domain): Likewise.
 760         (find_line_symtab): Change out param EXACT_MATCH to bool *.
 761         (find_line_pc): Change return type to bool.
 762         (find_line_pc_range): Likewise.
 763         (producer_is_realview): Likewise.
 764         * symtab.h (symbol_matches_domain): Likewise.
 765         (find_pc_partial_function): Likewise.
 766         (find_pc_line_pc_range): Likewise.
 767         (in_gnu_ifunc_stub): Likewise.
 768         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
 769         (find_line_pc): Likewise.
 770         (find_line_pc_range): Likewise.
 771         (matching_obj_sections): Likewise.
 772         (find_line_symtab): Change out parameter to bool.
 773         (producer_is_realview): Change return type to bool.
 774         (compare_filenames_for_search): Likewise.
 775         (compare_glob_filenames_for_search): Likewise.
 776
 777 2019-09-26  Tom Tromey  <tom@tromey.com>
 778
 779         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
 780         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
 781         * gdb_usleep.h: Remove.
 782         * gdb_usleep.c: Remove.
 783         * utils.c: Don't include gdb_usleep.h.
 784
 785 2019-09-26  Tom Tromey  <tromey@adacore.com>
 786
 787         * python/py-type.c (type_to_type_object): Call check_typedef
 788         for stub types.
 789
 790 2019-09-26  Tom Tromey  <tom@tromey.com>
 791
 792         * utils.h (initialize_utils): Don't declare.
 793         * top.c (gdb_init): Don't call initialize_utils.
 794         * utils.c (initialize_utils): Remove.  Move contents...
 795         (_initialize_utils): ... here.
 796
 797 2019-09-25  Tom Tromey  <tom@tromey.com>
 798
 799         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
 800         * utils.h (make_hex_string): Don't declare.
 801         * utils.c (make_hex_string): Remove.
 802
 803 2019-09-24  Tom de Vries  <tdevries@suse.de>
 804
 805         PR gdb/23815
 806         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
 807         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
 808
 809 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
 810
 811         * NEWS: Mention new simulator port for PRU.
 812
 813 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
 814
 815         * ada-exp.y (write_object_remaining): Update.
 816         * ada-lang.c (ada_decode): Return a std::string instead of a char*
 817         and eliminate the static buffer.
 818         (ada_decode_symbol): Update.
 819         (ada_la_decode): Update.
 820         (ada_sniff_from_mangled_name): Update.
 821         (is_valid_name_for_wild_match): Update.
 822         (ada_lookup_name_info::matches): Update and simplify.
 823         (name_matches_regex): Update.
 824         (ada_add_global_exceptions): Update.
 825         * ada-lang.h (ada_decode): Update signature.
 826         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
 827         * dwarf-index-write.c (debug_names::insert): Update.
 828
 829 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 830
 831         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
 832         formatting.
 833
 834 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
 835
 836         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
 837         Change "nonzero" to "true" in documentation.
 838
 839 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
 840
 841         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
 842         (_initialize_darwin_solib): Don't set
 843         darwin_so_ops.lookup_lib_global_symbol.
 844         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
 845         set_gdbarch_iterate_over_objfiles_in_search_order.
 846         (elf_lookup_lib_symbol): Rename to...
 847         (svr4_iterate_over_objfiles_in_search_order): this, and update
 848         to iterate semantics.
 849         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
 850         * solib.c (solib_global_lookup): Remove.
 851         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
 852         (solib_global_lookup): Remove.
 853         * symtab.c (lookup_global_or_static_symbol): Remove call to
 854         solib_global_lookup.
 855
 856 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 857
 858         * NEWS: Move entries about default MI version now being
 859         version 3, and about the GDB/MI fix for multi-location
 860         breakpoints to the "since GDB 8.3" section.
 861
 862 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
 863
 864         GDB 8.3.1 released.
 865
 866 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
 867
 868         * NEWS: Mention that Cell/B.E. debugging support was removed.
 869         * MAINTAINERS: Remove spu target.
 870
 871         * config/djgpp/fnchange.lst: Remove entries for removed files.
 872
 873         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
 874         spu-multiarch.o, and spu-tdep.o.
 875         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
 876         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
 877         spu-multiarch.c, and spu-tdep.c.
 878         * spu-linux-nat.c: Remove file.
 879         * spu-multiarch.c: Remove file.
 880         * spu-tdep.c: Remove file.
 881         * spu-tdep.h: Remove file.
 882         * solib-spu.c: Remove file.
 883         * solib-spu.h: Remove file.
 884
 885         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
 886         * configure.nat (spu-linux): Remove.
 887         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
 888         solib-multiarch.o from gdb_target_obs.
 889         (spu*-*-*): Remove.
 890
 891         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
 892         feature flag.
 893         (ppc_linux_no_features): Update.
 894         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
 895         Cell/B.E. support.
 896         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
 897         (tdesc_powerpc_cell64l): Likewise.
 898         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
 899         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
 900         Cell/B.E. support.
 901         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
 902         Do not include "features/rs6000/powerpc-cell32l.c" or
 903         "features/rs6000/powerpc-cell64l.c".
 904         (ppc_linux_spu_section): Remove.
 905         (ppc_linux_core_read_description): Remove Cell/B.E. support.
 906         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
 907         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
 908         (ppc_linux_spe_context_lookup): Remove.
 909         (ppc_linux_spe_context_inferior_created): Remove.
 910         (ppc_linux_spe_context_solib_loaded): Remove.
 911         (ppc_linux_spe_context_solib_unloaded): Remove.
 912         (ppc_linux_spe_context): Remove.
 913         (struct ppu2spu_cache): Remove.
 914         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
 915         (struct ppu2spu_data): Remove.
 916         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
 917         ppu2spu_unwind): Remove.
 918         (ppc_linux_init_abi): Remove Cell/B.E. support.
 919         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
 920
 921         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
 922         (rs6000/powerpc-cell64l-expedite): Likewise
 923         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
 924         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
 925         rs6000/powerpc-cell64l.xml.
 926         * features/rs6000/powerpc-cell32l.xml: Remove.
 927         * features/rs6000/powerpc-cell64l.xml: Likewise.
 928         * features/rs6000/powerpc-cell32l.c: Remove generated file.
 929         * features/rs6000/powerpc-cell64l.c: Likewise.
 930         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
 931         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
 932         * regformats/reg-spu.dat: Remove.
 933
 934         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
 935         * corelow.c (struct spuid_list): Remove.
 936         (add_to_spuid_list): Remove.
 937         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 938         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
 939         (remote_protocol_features): Remove associated entries.
 940         (_initialize_remote): No longer initialize them.
 941         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 942         * linux-nat.c (SPUFS_MAGIC): Remove.
 943         (linux_proc_xfer_spu): Remove.
 944         (spu_enumerate_spu_ids): Remove.
 945         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
 946         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
 947         (linux_make_corefile_notes): No longer call it.
 948
 949         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
 950         (cooked_write_test): Likewise.
 951
 952 2019-09-20  Tom Tromey  <tom@tromey.com>
 953
 954         * NEWS: Mention case-sensitivity of TUI commands.
 955         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
 956         (tui_set_win_height_command, parse_scrolling_args): Likewise.
 957         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
 958
 959 2019-09-20  Tom Tromey  <tom@tromey.com>
 960
 961         * tui/tui-source.c (tui_source_window::set_contents): Use
 962         make_unique_xstrdup.
 963         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
 964         make_unique_xstrdup.
 965
 966 2019-09-20  Tom Tromey  <tom@tromey.com>
 967
 968         * tui/tui-data.c: Remove separator comments.
 969         * tui/tui-layout.c: Remove separator comments.
 970         * tui/tui-win.c: Remove separator comments.
 971         * tui/tui-wingeneral.c: Remove separator comments.
 972
 973 2019-09-20  Tom Tromey  <tom@tromey.com>
 974
 975         * tui/tui.h (strcat_to_buf): Don't declare.
 976         * tui/tui.c (strcat_to_buf): Remove.
 977
 978 2019-09-20  Tom Tromey  <tom@tromey.com>
 979
 980         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
 981         from "fullname".
 982         * tui/tui-source.c (tui_source_window::set_contents)
 983         (tui_source_window::location_matches_p)
 984         (tui_source_window::maybe_update): Update.
 985
 986 2019-09-20  Tom Tromey  <tom@tromey.com>
 987
 988         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
 989         Update.
 990         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
 991         prefix.
 992         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
 993         (tui_data_window::line_from_reg_element_no)
 994         (tui_data_window::first_reg_element_no_inline)
 995         (tui_data_window::show_registers)
 996         (tui_data_window::show_register_group)
 997         (tui_data_window::display_registers_from)
 998         (tui_data_window::display_registers_from_line)
 999         (tui_data_window::first_data_item_displayed)
1000         (tui_data_window::delete_data_content_windows)
1001         (tui_data_window::erase_data_content)
1002         (tui_data_window::do_scroll_vertical)
1003         (tui_data_window::refresh_window)
1004         (tui_data_window::check_register_values): Update.
1005
1006 2019-09-20  Tom Tromey  <tom@tromey.com>
1007
1008         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
1009         (struct tui_locator_window) <full_name, proc_name>: Now
1010         std::string.
1011         * tui/tui-stack.c (tui_locator_window::make_status_line)
1012         (tui_locator_window::set_locator_fullname)
1013         (tui_locator_window::set_locator_info): Update.
1014         * tui/tui-source.c (tui_source_window::set_contents)
1015         (tui_source_window::showing_source_p): Update.
1016
1017 2019-09-20  Tom Tromey  <tom@tromey.com>
1018
1019         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1020         Don't call tui_locator_win_info_ptr.
1021
1022 2019-09-20  Tom Tromey  <tom@tromey.com>
1023
1024         * tui/tui-win.c (tui_resize_all): Don't call refresh.
1025
1026 2019-09-20  Tom Tromey  <tom@tromey.com>
1027
1028         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
1029         height for locator.
1030         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
1031         * tui/tui-layout.c (show_source_disasm_command, show_data)
1032         (show_source_or_disasm_and_command): Use 1 as height for locator.
1033
1034 2019-09-20  Tom Tromey  <tom@tromey.com>
1035
1036         * tui/tui.c (tui_enable): Update.
1037         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
1038         Update.
1039         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
1040         Update.
1041         * tui/tui-data.c (win_resized): Now bool.
1042         (tui_win_resized): Return bool.
1043         (tui_set_win_resized_to): Accept a bool.
1044
1045 2019-09-20  Tom Tromey  <tom@tromey.com>
1046
1047         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
1048         Change type of "refresh_values_only".
1049         * tui/tui-regs.c (tui_data_window::show_register_group): Change
1050         type of "refresh_values_only".
1051
1052 2019-09-20  Tom Tromey  <tom@tromey.com>
1053
1054         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
1055         std::string.
1056         (tui_disassemble): Add "pos" parameter.
1057         (tui_disasm_window::set_contents): Simplify.
1058
1059 2019-09-20  Tom Tromey  <tom@tromey.com>
1060
1061         * tui/tui-winsource.h (struct tui_source_window_base)
1062         <show_source_content>: Now private.
1063         * tui/tui-winsource.c
1064         (tui_source_window_base::show_source_content): Don't handle empty
1065         content case.
1066
1067 2019-09-20  Tom Tromey  <tom@tromey.com>
1068
1069         * tui/tui-layout.c (show_source_disasm_command)
1070         (show_source_or_disasm_and_command): Don't call
1071         show_source_content.
1072
1073 2019-09-20  Tom Tromey  <tom@tromey.com>
1074
1075         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
1076         Declare.
1077         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
1078         from tui_make_status_line.
1079         (tui_locator_window::rerender): Update.
1080
1081 2019-09-20  Tom Tromey  <tom@tromey.com>
1082
1083         * tui/tui-stack.c (tui_make_status_line): Return std::string.
1084         (tui_locator_window::rerender): Update.
1085
1086 2019-09-20  Tom Tromey  <tom@tromey.com>
1087
1088         * tui/tui-winsource.h (struct tui_source_window_base)
1089         <~tui_source_window_base>: Don't declare.
1090         <fullname>: Remove.
1091         * tui/tui-winsource.c (~tui_source_window_base): Remove.
1092         * tui/tui-source.h (struct tui_source_window) <fullname>: New
1093         member.
1094         * tui/tui-source.c (tui_source_window::set_contents): Update.
1095         (tui_source_window::location_matches_p)
1096         (tui_source_window::maybe_update): Update.
1097
1098 2019-09-20  Tom Tromey  <tom@tromey.com>
1099
1100         * tui/tui-winsource.h (~tui_source_element): Remove.
1101         (tui_source_element): Update.
1102         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
1103         * tui/tui-winsource.c (tui_show_source_line): Update.
1104         * tui/tui-source.c (tui_source_window::set_contents): Update.
1105         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1106
1107 2019-09-20  Tom Tromey  <tom@tromey.com>
1108
1109         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
1110         declare.
1111         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
1112         tui_clear_source_windows_detail.
1113         * tui/tui-winsource.h (struct tui_source_window_base)
1114         <clear_detail>: Don't declare.
1115         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
1116         Remove.
1117         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
1118
1119 2019-09-20  Tom Tromey  <tromey@adacore.com>
1120
1121         PR ada/24919:
1122         * block.c (contained_in): Fix final return value.
1123
1124 2019-09-20  Alan Modra  <amodra@gmail.com>
1125
1126         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
1127         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
1128         (read_indirect_string_from_dwz): Use bfd accessor.
1129         * dwarf2read.h (struct dwz_file <filename>): Likewise.
1130         * machoread.c (macho_symfile_read_all_oso): Likewise.
1131         * solib.c (solib_bfd_open): Likewise.
1132
1133 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1134
1135         * eval.c: Move declaration of overload_resolution to...
1136         * value.h: ...here.
1137
1138 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1139
1140         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
1141         * arm-linux-tdep.c: Likewise.
1142         * arm-nbsd-nat.c: Likewise.
1143         * arm-tdep.h: Declare arm_apcs_32.
1144         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
1145
1146 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
1147
1148         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
1149         * dwarf2read.h: Declare dwarf_always_disassemble.
1150
1151 2019-09-19  Tom de Vries  <tdevries@suse.de>
1152
1153         PR gdb/25009
1154         * source-cache.c (source_cache::ensure): Catch exception thrown during
1155         construction of the highlighter.
1156
1157 2019-09-18  Alan Modra  <amodra@gmail.com>
1158
1159         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
1160         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
1161         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
1162         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
1163         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
1164         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
1165         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
1166         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
1167         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
1168         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
1169         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
1170         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
1171         * solib-spu.c, * solib-svr4.c, * solib-target.c,
1172         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
1173         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
1174         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
1175         * mi/mi-interp.c: Update throughout for bfd section macro and
1176         function changes.
1177         * gcore (gcore_create_callback): Use bfd_set_section_lma.
1178         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
1179
1180 2019-09-18  Tom Tromey  <tom@tromey.com>
1181
1182         * NEWS: Add entry.
1183         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
1184         call rl_initialize.
1185         (tui_enable): Do not call rl_initialize.
1186
1187 2019-09-18  Christian Groessler  <chris@groessler.org>
1188
1189         * alpha-linux-nat.c: Include gdbarch.h.
1190
1191 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
1192
1193         * ui-file.c: Include cli/cli-style.h.
1194         (term_cli_styling): Remove cli_styling declaration.
1195
1196 2019-09-18  Alan Modra  <amodra@gmail.com>
1197
1198         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
1199         to bfd_asymbol_section.
1200
1201 2019-09-18  Alan Modra  <amodra@gmail.com>
1202
1203         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
1204         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
1205         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
1206
1207 2019-09-18  Alan Modra  <amodra@gmail.com>
1208
1209         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
1210         * spu-linux-nat.c (spu_bfd_open): Likewise.
1211
1212 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
1213
1214         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
1215         to bool to match definition in dwarf2read.c.
1216
1217 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
1218
1219         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
1220         (print_signatures): Likewise.
1221         (trust_pad_over_xvs): Likewise.
1222         * arch/aarch64-insn.c (aarch64_debug): Likewise.
1223         * arch/aarch64-insn.h (aarch64_debug): Likewise.
1224         * arm-linux-nat.c (arm_apcs_32): Likewise.
1225         * arm-linux-tdep.c (arm_apcs_32): Likewise.
1226         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
1227         * arm-tdep.c (arm_debug): Likewise.
1228         (arm_apcs_32): Likewise.
1229         * auto-load.c (debug_auto_load): Likewise.
1230         (auto_load_gdb_scripts): Likewise.
1231         (global_auto_load): Likewise.
1232         (auto_load_local_gdbinit): Likewise.
1233         (auto_load_local_gdbinit_loaded): Likewise.
1234         * auto-load.h (global_auto_load): Likewise.
1235         (auto_load_local_gdbinit): Likewise.
1236         (auto_load_local_gdbinit_loaded): Likewise.
1237         * breakpoint.c (disconnected_dprintf): Likewise.
1238         (breakpoint_proceeded): Likewise.
1239         (automatic_hardware_breakpoints): Likewise.
1240         (always_inserted_mode): Likewise.
1241         (target_exact_watchpoints): Likewise.
1242         (_initialize_breakpoint): Update.
1243         * breakpoint.h (target_exact_watchpoints): Change to bool.
1244         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
1245         * cli/cli-cmds.c (trace_commands): Likewise.
1246         * cli/cli-cmds.h (trace_commands): Likewise.
1247         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
1248         to bool*.
1249         * cli/cli-logging.c (logging_overwrite): Change to bool.
1250         (logging_redirect): Likewise.
1251         (debug_redirect): Likewise.
1252         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
1253         (struct boolean_option_def) <get_var_address_cb_>: Change return type
1254         to bool.
1255         <boolean_option_def>: Update.
1256         (struct flag_option_def): Change default type of Context to bool
1257         from int.
1258         <flag_option_def>: Change return type of var_address_cb_ to bool*.
1259         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
1260         (get_setshow_command_value_string): Likewise.
1261         * cli/cli-style.c (cli_styling): Change to bool.
1262         (source_styling): Likewise.
1263         * cli/cli-style.h (source_styling): Likewise.
1264         (cli_styling): Likewise.
1265         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
1266         to bool.
1267         * command.h (var_types): Update comment.
1268         (add_setshow_boolean_cmd): Change int* var argument to bool*.
1269         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
1270         bool.
1271         (debug_compile_cplus_scopes): Likewise.
1272         * compile/compile-internal.h (compile_debug): Likewise.
1273         * compile/compile.c (compile_debug): Likewise.
1274         (struct compile_options) <raw>: Likewise.
1275         * cp-support.c (catch_demangler_crashes): Likewise.
1276         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
1277         (usr_cmd_cris_dwarf2_cfi): Likewise.
1278         * csky-tdep.c (csky_debug): Likewise.
1279         * darwin-nat.c (enable_mach_exceptions): Likewise.
1280         * dcache.c (dcache_enabled_p): Likewise.
1281         * defs.h (info_verbose): Likewise.
1282         * demangle.c (demangle): Likewise.
1283         (asm_demangle): Likewise.
1284         * dwarf-index-cache.c (debug_index_cache): Likewise.
1285         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
1286         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
1287         * dwarf2read.c (check_physname): Likewise.
1288         (use_deprecated_index_sections): Likewise.
1289         (dwarf_always_disassemble): Likewise.
1290         * eval.c (overload_resolution): Likewise.
1291         * event-top.c (set_editing_cmd_var): Likewise.
1292         (exec_done_display_p): Likewise.
1293         * event-top.h (set_editing_cmd_var): Likewise.
1294         (exec_done_display_p): Likewise.
1295         * exec.c (write_files): Likewise.
1296         * fbsd-nat.c (debug_fbsd_lwp): Likewise
1297         (debug_fbsd_nat): Likewise.
1298         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
1299         Likewise.
1300         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
1301         <backtrace_past_entry> Likewise.
1302         * gdb-demangle.h (demangle): Likewise.
1303         (asm_demangle): Likewise.
1304         * gdb_bfd.c (bfd_sharing): Likewise.
1305         * gdbcore.h (write_files): Likewise.
1306         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
1307         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
1308         * gdbthread.h (print_thread_events): Likewise.
1309         * gdbtypes.c (opaque_type_resolution): Likewise.
1310         (strict_type_checking): Likewise.
1311         * gnu-nat.c (gnu_debug_flag): Likewise.
1312         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
1313         * guile/scm-param.c (pascm_variable): Add boolval.
1314         (add_setshow_generic): Update.
1315         (pascm_param_value): Update.
1316         (pascm_set_param_value_x): Update.
1317         * hppa-tdep.c (hppa_debug): Change to bool..
1318         * infcall.c (may_call_functions_p): Likewise.
1319         (coerce_float_to_double_p): Likewise.
1320         (unwind_on_signal_p): Likewise.
1321         (unwind_on_terminating_exception_p): Likewise.
1322         * infcmd.c (startup_with_shell): Likewise.
1323         * inferior.c (print_inferior_events): Likewise.
1324         * inferior.h (startup_with_shell): Likewise.
1325         (print_inferior_events): Likewise.
1326         * infrun.c (step_stop_if_no_debug): Likewise.
1327         (detach_fork): Likewise.
1328         (debug_displaced): Likewise.
1329         (disable_randomization): Likewise.
1330         (non_stop): Likewise.
1331         (non_stop_1): Likewise.
1332         (observer_mode): Likewise.
1333         (observer_mode_1): Likewise.
1334         (set_observer_mode): Update.
1335         (sched_multi): Change to bool.
1336         * infrun.h (debug_displaced): Likewise.
1337         (sched_multi): Likewise.
1338         (step_stop_if_no_debug): Likewise.
1339         (non_stop): Likewise.
1340         (disable_randomization): Likewise.
1341         * linux-tdep.c (use_coredump_filter): Likewise.
1342         (dump_excluded_mappings): Likewise.
1343         * linux-thread-db.c (auto_load_thread_db): Likewise.
1344         (check_thread_db_on_load): Likewise.
1345         * main.c (captured_main_1): Update.
1346         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
1347         xx2_opt, boolean_opt>: Change to bool.
1348         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
1349         * maint.c (maintenance_profile_p): Likewise.
1350         (per_command_time): Likewise.
1351         (per_command_space): Likewise.
1352         (per_command_symtab): Likewise.
1353         * memattr.c (inaccessible_by_default): Likewise.
1354         * mi/mi-main.c (mi_async): Likewise.
1355         (mi_async_1): Likewise.
1356         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
1357         * nat/fork-inferior.h (startup_with_shell): Likewise.
1358         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
1359         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
1360         * nios2-tdep.c (nios2_debug): Likewise.
1361         * or1k-tdep.c (or1k_debug): Likewise.
1362         * parse.c (parser_debug): Likewise.
1363         * parser-defs.h (parser_debug): Likewise.
1364         * printcmd.c (print_symbol_filename): Likewise.
1365         * proc-api.c (procfs_trace): Likewise.
1366         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
1367         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
1368         (set_parameter_value): Update.
1369         (add_setshow_generic): Update.
1370         * python/py-value.c (copy_py_bool_obj): Change argument from int*
1371         to bool*.
1372         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
1373         int*.
1374         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
1375         * record-btrace.c (record_btrace_target::store_registers): Update.
1376         * record-full.c (record_full_memory_query): Change to bool.
1377         (record_full_stop_at_limit): Likewise.
1378         * record-full.h (record_full_memory_query): Likewise.
1379         * remote-notif.c (notif_debug): Likewise.
1380         * remote-notif.h (notif_debug): Likewise.
1381         * remote.c (use_range_stepping): Likewise.
1382         (interrupt_on_connect): Likewise.
1383         (remote_break): Likewise.
1384         * ser-tcp.c (tcp_auto_retry): Likewise.
1385         * ser-unix.c (serial_hwflow): Likewise.
1386         * skip.c (debug_skip): Likewise.
1387         * solib-aix.c (solib_aix_debug): Likewise.
1388         * spu-tdep.c (spu_stop_on_load_p): Likewise.
1389         (spu_auto_flush_cache_p): Likewise.
1390         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
1391         Likewise.
1392         (struct info_print_options) <quiet>: Likewise.
1393         * symfile-debug.c (debug_symfile): Likewise.
1394         * symfile.c (auto_solib_add): Likewise.
1395         (separate_debug_file_debug): Likewise.
1396         * symfile.h (auto_solib_add): Likewise.
1397         (separate_debug_file_debug): Likewise.
1398         * symtab.c (basenames_may_differ): Likewise.
1399         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
1400         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
1401         (struct info_types_options) <quiet>: Likewise.
1402         * symtab.h (demangle): Likewise.
1403         (basenames_may_differ): Likewise.
1404         * target-dcache.c (stack_cache_enabled_1): Likewise.
1405         (code_cache_enabled_1): Likewise.
1406         * target.c (trust_readonly): Likewise.
1407         (may_write_registers): Likewise.
1408         (may_write_memory): Likewise.
1409         (may_insert_breakpoints): Likewise.
1410         (may_insert_tracepoints): Likewise.
1411         (may_insert_fast_tracepoints): Likewise.
1412         (may_stop): Likewise.
1413         (auto_connect_native_target): Likewise.
1414         (target_stop_and_wait): Update.
1415         (target_async_permitted): Change to bool.
1416         (target_async_permitted_1): Likewise.
1417         (may_write_registers_1): Likewise.
1418         (may_write_memory_1): Likewise.
1419         (may_insert_breakpoints_1): Likewise.
1420         (may_insert_tracepoints_1): Likewise.
1421         (may_insert_fast_tracepoints_1): Likewise.
1422         (may_stop_1): Likewise.
1423         * target.h (target_async_permitted): Likewise.
1424         (may_write_registers): Likewise.
1425         (may_write_memory): Likewise.
1426         (may_insert_breakpoints): Likewise.
1427         (may_insert_tracepoints): Likewise.
1428         (may_insert_fast_tracepoints): Likewise.
1429         (may_stop): Likewise.
1430         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
1431         (make_thread_apply_all_options_def_group): Change argument from int*
1432         to bool*.
1433         (thread_apply_all_command): Update.
1434         (print_thread_events): Change to bool.
1435         * top.c (confirm): Likewise.
1436         (command_editing_p): Likewise.
1437         (history_expansion_p): Likewise.
1438         (write_history_p): Likewise.
1439         (info_verbose): Likewise.
1440         * top.h (confirm): Likewise.
1441         (history_expansion_p): Likewise.
1442         * tracepoint.c (disconnected_tracing): Likewise.
1443         (circular_trace_buffer): Likewise.
1444         * typeprint.c (print_methods): Likewise.
1445         (print_typedefs): Likewise.
1446         * utils.c (debug_timestamp): Likewise.
1447         (sevenbit_strings): Likewise.
1448         (pagination_enabled): Likewise.
1449         * utils.h (sevenbit_strings): Likewise.
1450         (pagination_enabled): Likewise.
1451         * valops.c (overload_resolution): Likewise.
1452         * valprint.h (struct value_print_options) <prettyformat_arrays,
1453         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
1454         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
1455         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
1456         Likewise.
1457         * windows-nat.c (new_console): Likewise.
1458         (cygwin_exceptions): Likewise.
1459         (new_group): Likewise.
1460         (debug_exec): Likewise.
1461         (debug_events): Likewise.
1462         (debug_memory): Likewise.
1463         (debug_exceptions): Likewise.
1464         (useshell): Likewise.
1465         * windows-tdep.c (maint_display_all_tib): Likewise.
1466         * xml-support.c (debug_xml): Likewise.
1467
1468 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
1469
1470         * source.c (prepare_path_for_appending): New function.
1471         (openp): Make use of new function.
1472         (find_and_open_source): Search for the compilation directory and
1473         source file as a relative path beneath the directory search path.
1474
1475 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
1476
1477         * source-cache.c (source_cache::get_line_charpos): Catch
1478         exceptions and return false, this matches the behaviour documented
1479         in the header file.
1480
1481 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
1482
1483         * ada-tasks.c (info_task): Remove quoting of the task's name.
1484
1485 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
1486
1487         * symfile.c (auto_solib_add): Replace comment with a reference
1488         to the header file.
1489
1490 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
1491
1492         * NEWS: Mention that gdb can now be compiled with Python 3
1493         on Windows.
1494
1495 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1496
1497         * maint.c (maint_print_section_data::maint_print_section_data):
1498         Force use of 'float log10 (float)' by casting the argument to
1499         float.
1500
1501 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1502
1503         * maint.c: Add 'cmath' include.
1504         (struct maint_print_section_data): New structure.
1505         (print_section_index): New function.
1506         (print_bfd_section_info): Add header comment, small whitespace
1507         cleanup, and update to call new print_section_index function.
1508         (print_objfile_section_info): Likewise.
1509         (maint_obj_section_from_bfd_section): New function.
1510         (print_bfd_section_info_maybe_relocated): New function.
1511         (maintenance_info_sections): Add header comment, always use
1512         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
1513
1514 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
1515
1516         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
1517         inner scope, add check that the objfile has psymtabs before
1518         checking psymtabs_addrmap.
1519         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
1520
1521 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1522
1523         * NEWS: Announce that Ada task names are now shown at more places,
1524         and between quotes (except in info task output).
1525         * gdb/ada-tasks.c (task_to_str): New function.
1526         (display_current_task_id): Call task_to_str.
1527         (task_command_1): Likewise.
1528         (print_ada_task_info): In non-mi mode, Properly align headers and data
1529         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
1530
1531 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
1532
1533         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
1534         prstatus.pr_lwp.pr_info instead of making it up.
1535
1536 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1537
1538         * auto-load.c (auto_load_expand_dir_vars): Update.
1539         * defs.h (gdb_datadir): Change to std::string.
1540         (python_libdir): Likewise.
1541         (relocate_gdb_directory): Change return type to std::string.
1542         * guile/guile.c (gdbscm_data_directory): Update.
1543         (initialize_scheme_side): Update.
1544         * jit.c (jit_reader_dir): Change to std::string.
1545         (jit_reader_load_command): Update.
1546         * main.c (gdb_datadir): Change to std::string.
1547         (python_libdir): Likewise.
1548         (set_gdb_data_directory): Update.
1549         (relocate_path): Change to return std::string.
1550         (relocate_gdb_directory): Change to return std::string.
1551         (relocate_gdbinit_path_maybe_in_datadir): Update.
1552         (captured_main_1): Update.
1553         * python/python.c (do_start_initialization): Update.
1554         * top.c (show_gdb_datadir): Update.
1555         * xml-syscall.c (xml_init_syscalls_info): Update.
1556         (init_syscalls_info): Update.
1557
1558 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1559
1560         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
1561         out of get_init_files.
1562         (get_init_files): Update.
1563
1564 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1565
1566         * main.c (get_init_files): Change to use std::string.
1567         (captured_main_1): Update.
1568         (print_gdb_help): Update.
1569
1570 2019-09-11  Ali Tamur  <tamur@google.com>
1571
1572         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
1573         implementation.
1574
1575 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
1576
1577         * dbxread.c (read_dbx_symtab): Update.
1578         * dwarf2read.c (load_partial_dies): Update.
1579         * mdebugread.c (parse_partial_symbols): Update.
1580         (handle_psymbol_enumerators): Update.
1581         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
1582         * psymtab.c (add_psymbol_to_bcache): Likewise.
1583         (add_psymbol_to_list): Likewise.
1584         * symtab.c (symbol_set_names): Likewise.
1585         * symtab.h (symbol_set_names): Likewise.
1586         * xcoffread.c (scan_xcoff_symtab): Update.
1587
1588 2019-09-11  Tom Tromey  <tom@tromey.com>
1589
1590         * symfile-mem.c (symbol_file_add_from_memory): Use
1591         bfd_set_filename.
1592         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
1593         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
1594
1595 2019-09-10  Tom Tromey  <tromey@adacore.com>
1596
1597         * dwarf-index-write.c (write_psymbols): Extend error message.
1598         (debug_names::insert): Add Ada code.
1599         (debug_names::write_psymbols): Remove Ada check.
1600         (debug_names) <m_string_obstack>: New member.
1601         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
1602         (gdb_index_symbol_name_matcher::matches): Remove.
1603         (mapped_index_base::find_name_components_bounds): Add "lang"
1604         parameter.
1605         (mapped_index_base::build_name_components): Also split names
1606         according to Ada syntax.
1607         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
1608         type of "match_callback".
1609         (check_match, check_find_bounds_finds)
1610         (dw2_expand_symtabs_matching): Update.
1611         (dw2_debug_names_iterator): Add new constructor.
1612         (dw2_debug_names_map_matching_symbols): New function.
1613         (dw2_debug_names_expand_symtabs_matching): Update.
1614         (dwarf2_debug_names_functions): Use
1615         dw2_debug_names_map_matching_symbols.
1616
1617 2019-09-10  Tom Tromey  <tromey@adacore.com>
1618
1619         * dwarf2read.c (dw2_get_file_names_reader): Add the
1620         CU's file name to the results.
1621
1622 2019-09-10  Tom Tromey  <tromey@adacore.com>
1623
1624         * ada-lang.c (add_nonlocal_symbols): Combine calls to
1625         map_matching_symbols.  Update.
1626         * dwarf2read.c (dw2_map_matching_symbols): Update.
1627         * psymtab.c (match_partial_symbol): Change type; update.
1628         (psym_map_matching_symbols): Likewise.
1629         * symfile-debug.c (debug_qf_map_matching_symbols): Change
1630         type; update.
1631         * symfile.h (struct quick_symbol_functions)
1632         <map_matching_symbols>: Change "name" to be a lookup_name_info.
1633         Remove "match".
1634
1635 2019-09-10  Tom Tromey  <tromey@adacore.com>
1636
1637         * psymtab.c (map_block): Remove.
1638         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
1639         * symtab.c (iterate_over_symbols_terminated): New function.
1640         * symtab.c (iterate_over_symbols_terminated): Declare.
1641
1642 2019-09-10  Tom Tromey  <tromey@adacore.com>
1643
1644         * ada-lang.c (ada_iterate_over_symbols): Return bool.
1645         * language.h (struct language_defn) <la_iterate_over_symbols>:
1646         Return bool.
1647         * symtab.c (iterate_over_symbols): Return bool.
1648         * symtab.h (iterate_over_symbols): Return bool.
1649
1650 2019-09-10  Tom Tromey  <tromey@adacore.com>
1651
1652         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
1653         (add_nonlocal_symbols): Update.
1654         * dwarf2read.c (dw2_map_matching_symbols): Change type.
1655         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
1656         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
1657         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
1658         Change type of "callback".  Remove "data".
1659
1660
1661 2019-09-09  Ali Tamur  <tamur@google.com>
1662
1663         * dwarf2read.c (comp_unit_head): Update comment.
1664         (dwarf2_dwo_name): New function declaration.
1665         (dwarf_unit_type_name): New function declaration.
1666         (read_comp_unit_head): Add support for new compilation units,
1667         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
1668         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
1669         (currently named as "signature") in their header. Also clarify error
1670         messages.
1671         (lookup_dwo_id): New function. Returns the dwo id of the given
1672         compile unit.
1673         (lookup_dwo_unit): Use the new lookup_dwo_id function.
1674         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
1675         functions.
1676         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
1677         (dwarf2_dwo_name): Get the dwo name if present.
1678         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
1679         purposes.
1680
1681 2019-09-09  Tom Tromey  <tom@tromey.com>
1682
1683         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
1684
1685 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1686
1687         * python/python.c (do_start_initialization): Make progname_copy static,
1688         to avoid a leak report.
1689
1690 2019-09-08  Tom Tromey  <tom@tromey.com>
1691
1692         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
1693
1694 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
1695
1696         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
1697         Change type to gdb::optional<block_enum>.
1698         (dw2_symtab_iter_init): Change block_index parameter type
1699         to gdb::optional<block_enum>.
1700         (dw2_lookup_symbol): Change block_index parameter
1701         type to block_enum.c
1702         (dw2_debug_names_lookup_symbol): Likewise.
1703         * psymtab.c (psym_lookup_symbol): Likewise.
1704         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
1705         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
1706         Likewise.
1707
1708 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
1709
1710         * defs.h (relocate_gdb_directory): Change int to bool in
1711         signature and rename flag to relocatable.
1712         * main.c (relocate_path): Likewise.
1713         (relocate_gdb_directory): Likewise.
1714
1715 2019-09-06  Alan Modra  <amodra@gmail.com>
1716
1717         * coffread.c (coff_symfile_read): Constify filename variable.
1718         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
1719         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
1720         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
1721         * solib.c (reload_shared_libraries_1): Likewise.
1722         * symfile.c (reread_symbols): Likewise.
1723         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
1724         * solib-darwin.c (darwin_bfd_open): Likewise.
1725         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
1726
1727 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1728
1729         * psymtab.c (print_partial_symbols): Handle missing domain_enum
1730         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
1731
1732 2019-09-03  Tom Tromey  <tromey@adacore.com>
1733
1734         * ada-valprint.c (ada_val_print_num): Don't recurse for range
1735         types.
1736         (has_negatives): Unbias a range type bound.
1737         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
1738         * gdbtypes.c (operator==): Handle new field.
1739         (create_range_type): Add "bias" parameter.
1740         (create_static_range_type, resolve_dynamic_range): Update.
1741         * gdbtypes.h (struct range_bounds) <bias>: New member.
1742         (create_range_type): Add bias parameter.
1743         * printcmd.c (print_scalar_formatted): Unbias range types.
1744         * value.c (unpack_long): Unbias range types.
1745         (pack_long): Bias range types.
1746
1747 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1748
1749         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
1750         probe arguments.
1751
1752 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1753
1754         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
1755         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
1756         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
1757         (compile_probe_arg): Likewise.
1758         * probe.h (get_argument_count): Likewise.
1759         * solib-svr4.c (solib_event_probe_action): Likewise.
1760         * stap-probe.c (stap_probe::get_argument_count): Likewise.
1761
1762 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
1763
1764         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
1765         code to here...
1766         (svr4_create_solib_event_breakpoints): ...from here.
1767
1768 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
1769
1770         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
1771         suffix from warning message.
1772
1773 2019-08-30  Tom Tromey  <tom@tromey.com>
1774
1775         * tui/tui-winsource.h (struct tui_source_window_base)
1776         <refresh_all>: Don't declare.
1777         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
1778         Remove.
1779         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
1780         tui_show_locator_content.
1781         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
1782         declare.
1783         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
1784         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
1785         declare.
1786
1787 2019-08-30  Tom Tromey  <tom@tromey.com>
1788
1789         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
1790
1791 2019-08-30  Tom Tromey  <tom@tromey.com>
1792
1793         * tui/tui-stack.c (_initialize_tui_stack): Move later.
1794         Remove unnecessary forward declarations.
1795
1796 2019-08-30  Tom Tromey  <tom@tromey.com>
1797
1798         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
1799         rerender.
1800         (tui_update_locator_fullname, tui_show_frame_info): Don't call
1801         tui_show_locator_content.
1802
1803 2019-08-30  Tom Tromey  <tom@tromey.com>
1804
1805         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
1806         (tui_locator_window::rerender): Rewrite using body of previous
1807         tui_show_locator_content.
1808
1809 2019-08-30  Tom Tromey  <tom@tromey.com>
1810
1811         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
1812         set_locator_fullname>: New methods.
1813         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
1814         Rename from tui_set_locator_fullname.
1815         (tui_locator_window::set_locator_info): Rename from
1816         tui_set_locator_info.  Return bool.
1817         (tui_update_locator_fullname, tui_show_frame_info): Update.
1818
1819 2019-08-30  Tom Tromey  <tom@tromey.com>
1820
1821         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
1822
1823 2019-08-30  Tom Tromey  <tom@tromey.com>
1824
1825         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
1826         call touchwin.
1827
1828 2019-08-30  Tom Tromey  <tom@tromey.com>
1829
1830         * tui/tui-wingeneral.c (box_win): Assume win_info and
1831         win_info->handle cannot be NULL.
1832
1833 2019-08-30  Tom Tromey  <tom@tromey.com>
1834
1835         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
1836         refresh_window>: Declare.
1837         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
1838         resize.
1839         (tui_data_item_window::rerender): Rename from
1840         tui_display_register.
1841         (tui_data_item_window::refresh_window): New method.
1842         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
1843         no-op.
1844
1845 2019-08-30  Tom Tromey  <tom@tromey.com>
1846
1847         * tui/tui-regs.h (struct tui_data_window) <regs_content,
1848         regs_column_count, current_group>: Move later.  Now private.
1849         <get_current_group>: New method.
1850         * tui/tui-regs.c (tui_reg_command): Update.
1851         * tui/tui-layout.c (tui_set_layout): Update.
1852
1853 2019-08-30  Tom Tromey  <tom@tromey.com>
1854
1855         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
1856         (tui_data_window::rerender): Don't call
1857         check_and_display_highlight_if_needed.
1858         (tui_data_window::refresh_all): Remove call to
1859         erase_data_content.
1860
1861 2019-08-30  Tom Tromey  <tom@tromey.com>
1862
1863         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
1864         (tui_data_window::display_registers_from)
1865         (tui_data_window::display_reg_element_at_line)
1866         (tui_data_window::display_registers_from_line): Remove checks of
1867         "empty".
1868
1869 2019-08-30  Tom Tromey  <tom@tromey.com>
1870
1871         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
1872         Don't declare.
1873         * tui/tui-regs.c (tui_data_window::show_registers): Call
1874         rerender.
1875         (tui_data_window::rerender): Rename from display_all_data.
1876         (tui_data_window::rerender): Remove old implementation.
1877
1878 2019-08-30  Tom Tromey  <tom@tromey.com>
1879
1880         * tui/tui-regs.c (tui_data_window::display_all_data): Change
1881         text.
1882         * tui/tui-data.h (NO_DATA_STRING): Remove define.
1883
1884 2019-08-29  Bernhard Wodok  <barto@gmx.net>
1885             Sergio Durigan Junior  <sergiodj@redhat.com>
1886
1887         PR win32/24284
1888         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
1889
1890 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1891
1892         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
1893         when searching for types.
1894
1895 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
1896
1897         * f-lang.c (f_language_defn): Use f_print_typedef.
1898         * f-lang.h (f_print_typedef): Declare.
1899         * f-typeprint.c (f_print_typedef): Define.
1900
1901 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
1902
1903         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
1904
1905 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1906
1907         * cli/cli-utils.c (info_print_options_defs): Delete.
1908         (make_info_print_options_def_group): Delete.
1909         (extract_info_print_options): Delete.
1910         (info_print_command_completer): Delete.
1911         (info_print_args_help): Add extra parameter, and optionally
1912         include text about -n flag.
1913         * cli/cli-utils.h (struct info_print_options): Delete.
1914         (extract_info_print_options): Delete declaration.
1915         (info_print_command_completer): Delete declaration.
1916         (info_print_args_help): Add extra parameter, extend header
1917         comment.
1918         * python/python.c (gdbpy_rbreak): Pass additional parameter to
1919         search_symbols.
1920         * stack.c (struct info_print_options): New type.
1921         (info_print_options_defs): New file scoped variable.
1922         (make_info_print_options_def_group): New static function.
1923         (info_print_command_completer): New static function.
1924         (info_locals_command): Update to use new local functions.
1925         (info_args_command): Likewise.
1926         (_initialize_stack): Add extra parameter to calls to
1927         info_print_args_help.
1928         * symtab.c (search_symbols): Add extra parameter, use this to
1929         possibly excluse non-debug symbols.
1930         (symtab_symbol_info): Add extra parameter, which is passed on to
1931         search_symbols.
1932         (struct info_print_options): New type.
1933         (info_print_options_defs): New file scoped variable.
1934         (make_info_print_options_def_group): New static function.
1935         (info_print_command_completer): New static function.
1936         (info_variables_command): Update to use local functions, and pass
1937         extra parameter through to symtab_symbol_info.
1938         (info_functions_command): Likewise.
1939         (info_types_command): Pass additional argument through to
1940         symtab_symbol_info.
1941         (rbreak_command): Pass extra argument to search_symbols.
1942         (_initialize_symtab): Add extra arguments for calls to
1943         info_print_args_help, and update help text for 'info variables',
1944         'whereis', and 'info functions' commands.
1945         * symtab.h (search_symbols): Add extra argument to declaration.
1946         * NEWS: Mention new flags.
1947
1948 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
1949
1950         * symtab.c (lookup_static_symbol): Call the new function (and move
1951         it down to be next to lookup_global_symbol).
1952         (struct global_sym_lookup_data): Add block_enum member and rename to...
1953         (struct global_or_static_sym_lookup_data): ...this.
1954         (lookup_symbol_global_iterator_cb): Pass block_index instead of
1955         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
1956         (lookup_symbol_global_or_static_iterator_cb): ...this.
1957         (lookup_global_or_static_symbol): New function.
1958         (lookup_global_symbol): Call new function.
1959
1960 2019-08-26  Tom de Vries  <tdevries@suse.de>
1961
1962         PR c++/24852
1963         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
1964         when pc_probe.prob == NULL.
1965
1966 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1967
1968         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
1969         variable symbol_linkage to symbol_linkage_.
1970
1971 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
1972
1973         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
1974         represent whether the symbol is static, dynamic, or we don't
1975         know.
1976
1977 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
1978
1979         * gdb/rx-tdep.c (rx_register_names): New.
1980         (rx_register_name): Delete.
1981         (rx_psw_type): Delete.
1982         (rx_fpsw_type): Delete.
1983         (rx_register_type): Delete.
1984         (rx_gdbarch_init): Convert target-descriptions.
1985         (_initialize_rx_tdep): Add initialize_tdesc_rx.
1986         * gdb/features/Makefile: Add rx.xml.
1987         * gdb/features/rx.xml: New.
1988         * gdb/features/rx.c: Generated.
1989         * gdb/NEWS: Mention target description support.
1990
1991 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
1992
1993         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
1994         *slot_ptr.
1995
1996 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
1997
1998         * configure.ac: Don't check for 'dlfcn.h' (moved to
1999         gdbsupport/common.m4).
2000         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
2001         'gdbsupport/'.
2002         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
2003         * compile/compile-c-support.c: Include
2004         'gdbsupport/gdb-dlfcn.h'.
2005         * gdbsupport/common.m4: Check for 'dlfcn.h'.
2006         * gdb-dlfcn.c: Move to...
2007         * gdbsupport/gdb-dlfcn.c: ... here.
2008         * gdb-dlfcn.h: Move to...
2009         * gdbsupport/gdb-dlfcn.h: ... here.
2010
2011 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
2012
2013         * nios2-tdep.c (struct reg_value): Improve comments.  Make
2014         the offset field signed.
2015
2016 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
2017
2018         * python/lib/gdb/__init__.py (_execute_file): New function.
2019         * python/python.c (python_run_simple_file): Call gdb._execute_file
2020         on Windows.
2021
2022 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
2023
2024         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
2025         all uses as this was never set to anything but a zero value.
2026
2027 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
2028
2029         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
2030
2031 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
2032
2033         * tui/tui-data.h (tui_gen_win_info): Add an =default
2034         move constructor, required by some GCC versions.
2035
2036 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
2037
2038         * go32-nat.c (go32_sysinfo): Add hygon_p.
2039
2040 2019-08-20  Tom Tromey  <tom@tromey.com>
2041
2042         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
2043         line_from_reg_element_no, first_reg_element_no_inline,
2044         display_all_data, delete_data_content_windows,
2045         erase_data_content>: Now private.
2046
2047 2019-08-20  Tom Tromey  <tom@tromey.com>
2048
2049         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
2050         (tui_unhighlight_win, tui_highlight_win)
2051         (tui_win_info::make_window): Update.
2052         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
2053
2054 2019-08-20  Tom Tromey  <tom@tromey.com>
2055
2056         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2057         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2058         (MAX_PID_WIDTH): Move to tui-stack.c.
2059         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
2060         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
2061         (MAX_PID_WIDTH): Move from tui-data.h.
2062
2063 2019-08-20  Tom Tromey  <tom@tromey.com>
2064
2065         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
2066         * tui/tui-wingeneral.c (box_win): Change type of win_info.
2067         (box_win): Update.
2068         (tui_gen_win_info::make_window): Rename from tui_make_window.
2069         (tui_win_info::make_window): New method.
2070         (tui_gen_win_info::make_visible): Update.
2071         * tui/tui-source.c (tui_source_window::set_contents): Update.
2072         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
2073         (tui_data_window::display_registers_from): Update.
2074         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2075         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
2076         Declare.
2077         <can_box>: Remove.
2078         <title>: Remove.
2079         (struct tui_win_info) <make_window>: Declare.
2080         <can_box>: Now virtual.
2081         <title>: New member.
2082         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
2083         * tui/tui-command.c (tui_cmd_window::resize): Update.
2084
2085 2019-08-20  Tom Tromey  <tom@tromey.com>
2086
2087         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
2088         * tui/tui-regs.c (tui_data_window::show_registers): Update.
2089         (tui_data_window::check_register_values): Update.
2090
2091 2019-08-20  Tom Tromey  <tom@tromey.com>
2092
2093         * tui/tui-regs.h (struct tui_data_window): Use
2094         DISABLE_COPY_AND_ASSIGN.
2095         <regs_content>: Change type, removing unique_ptr.
2096         <tui_data_window>: Add move constructor.
2097         * tui/tui-regs.c (tui_data_window::show_registers)
2098         (tui_data_window::show_register_group)
2099         (tui_data_window::display_registers_from)
2100         (tui_data_window::display_registers_from)
2101         (tui_data_window::first_data_item_displayed)
2102         (tui_data_window::delete_data_content_windows)
2103         (tui_data_window::rerender, tui_data_window::refresh_window)
2104         (tui_data_window::check_register_values): Update.
2105
2106 2019-08-20  Tom Tromey  <tom@tromey.com>
2107
2108         * tui/tui-regs.h (struct tui_data_window) <show_registers,
2109         show_register_group>: Declare.
2110         (tui_show_register_group): Don't declare.
2111         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
2112         tui_show_registers.
2113         (tui_data_window::show_register_group): Rename from
2114         tui_show_register_group.
2115         (tui_data_window::check_register_values, tui_reg_command):
2116         Update.
2117         * tui/tui-layout.c (tui_set_layout): Update.
2118
2119 2019-08-20  Tom Tromey  <tom@tromey.com>
2120
2121         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
2122         Declare.
2123         (tui_check_register_values): Don't declare.
2124         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
2125         from tui_check_register_values.
2126         * tui/tui-hooks.c (tui_register_changed): Update.
2127
2128 2019-08-20  Tom Tromey  <tom@tromey.com>
2129
2130         * tui/tui-regs.c (tui_reg_layout): Move later.
2131         (tui_show_registers): Don't enable TUI mode or change layout.
2132
2133 2019-08-20  Tom Tromey  <tom@tromey.com>
2134
2135         * tui/tui-regs.h (struct tui_data_item_window)
2136         <~tui_data_item_window>: Remove.
2137         <content>: Now a unique_xmalloc_ptr.
2138         * tui/tui-regs.c (tui_register_format): Return a
2139         unique_xmalloc_ptr.
2140         (tui_get_register): Update.
2141         (~tui_data_item_window): Remove.
2142         (tui_data_window::display_registers_from, tui_display_register):
2143         Update.
2144         * tui/tui-io.h (tui_expand_tabs): Update.
2145         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
2146         Remove "col" parameter.
2147
2148 2019-08-20  Tom Tromey  <tom@tromey.com>
2149
2150         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
2151         field.
2152         * tui/tui-regs.c (~tui_data_item_window): Update.
2153
2154 2019-08-20  Tom Tromey  <tom@tromey.com>
2155
2156         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
2157         earlier.
2158
2159 2019-08-20  Tom Tromey  <tom@tromey.com>
2160
2161         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
2162
2163 2019-08-20  Tom Tromey  <tom@tromey.com>
2164
2165         * tui/tui-source.h (struct tui_source_window): Update.
2166         * tui/tui-regs.c (tui_show_registers): Update.
2167         * tui/tui-disasm.h (struct tui_disasm_window): Update.
2168         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
2169         (NO_REGS_STRING): Remove defines.
2170
2171 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
2172
2173         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
2174         unnecessary thread walk if remote doesn't support the packet.
2175
2176 2019-08-19  Tom Tromey  <tromey@adacore.com>
2177
2178         * python/py-value.c (value_has_field): Fix indentation.
2179
2180 2019-08-19  Tom Tromey  <tromey@adacore.com>
2181
2182         * printcmd.c (do_one_display, info_display_command): Update.
2183         * block.h (contained_in): Return bool.  Add allow_nested
2184         parameter.
2185         * block.c (contained_in): Return bool.  Add allow_nested
2186         parameter.
2187
2188 2019-08-19  Tom Tromey  <tom@tromey.com>
2189
2190         * configure: Rebuild.
2191         * configure.ac: Disallow the combination of -static-libstdc++ and
2192         source highlight.
2193         * source-cache.c (get_language_name): Handle rust.
2194         (source_cache::get_source_lines): Ignore highlighting exceptions.
2195
2196 2019-08-16  Tom Tromey  <tom@tromey.com>
2197
2198         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
2199         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
2200         (struct tui_source_window_base) <make_visible, refresh_window,
2201         resize>: Remove methods.
2202         <execution_info>: Remove field.
2203         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
2204         (tui_show_source_line, tui_source_window_base)
2205         (~tui_source_window_base): Update.
2206         (tui_source_window_base::resize)
2207         (tui_source_window_base::make_visible)
2208         (tui_source_window_base::refresh_window): Remove.
2209         (tui_source_window_base::update_exec_info): Update.
2210         * tui/tui-source.c (tui_source_window::set_contents): Update.
2211         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2212
2213 2019-08-16  Tom Tromey  <tom@tromey.com>
2214
2215         * tui/tui-hooks.c (tui_remove_hooks): Don't set
2216         deprecated_query_hook.
2217
2218 2019-08-16  Tom Tromey  <tom@tromey.com>
2219
2220         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
2221         (tui_update_source_windows_with_line): Update.
2222         * tui/tui-source.h (struct tui_source_window)
2223         <show_symtab_source>: Declare.
2224         (tui_show_symtab_source): Don't declare.
2225         * tui/tui-source.c (tui_show_symtab_source): Rename from
2226         tui_show_symtab_source.
2227
2228 2019-08-16  Tom Tromey  <tom@tromey.com>
2229
2230         * tui/tui-winsource.h (struct tui_source_window_base)
2231         <set_contents>: Declare.
2232         * tui/tui-winsource.c
2233         (tui_source_window_base::update_source_window_as_is): Update.
2234         * tui/tui-source.h (struct tui_source_window) <set_contents>:
2235         Declare.
2236         (tui_set_source_content): Don't declare.
2237         * tui/tui-source.c (tui_source_window::set_contents): Rename from
2238         tui_set_source_content.
2239         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
2240         Declare.
2241         (tui_set_disassem_content): Don't declare.
2242         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
2243         tui_set_disassem_content.
2244
2245 2019-08-16  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-winsource.h (struct tui_source_window_base)
2248         <update_breakpoint_info>: Declare.
2249         (tui_update_breakpoint_info): Don't declare.
2250         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
2251         (tui_update_all_breakpoint_info): Update.
2252         (tui_source_window_base::update_breakpoint_info): Rename from
2253         tui_update_breakpoint_info.
2254         (tui_source_window_base::update_exec_info): Update.
2255
2256 2019-08-16  Tom Tromey  <tom@tromey.com>
2257
2258         * tui/tui-winsource.h (struct tui_source_window_base)
2259         <update_source_window>: Declare.
2260         (tui_update_source_window): Don't declare.
2261         * tui/tui-winsource.c
2262         (tui_source_window_base::update_source_window): Rename from
2263         tui_update_source_window.
2264         (tui_source_window_base::rerender): Update.
2265         * tui/tui-source.c (tui_source_window::maybe_update): Update.
2266         * tui/tui-disasm.c (tui_show_disassem)
2267         (tui_show_disassem_and_update_source)
2268         (tui_disasm_window::maybe_update): Update.
2269
2270 2019-08-16  Tom Tromey  <tom@tromey.com>
2271
2272         * tui/tui-winsource.h (struct tui_source_window_base)
2273         <update_source_window_as_is>: Declare.
2274         (tui_update_source_window_as_is): Don't declare.
2275         * tui/tui-winsource.c (tui_update_source_window): Update
2276         (tui_source_window_base::update_source_window_as_is): Rename from
2277         tui_update_source_window_as_is.
2278         (tui_source_window_base::refill): Update.
2279         * tui/tui-source.c (tui_show_symtab_source): Update.
2280         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
2281         Update.
2282
2283 2019-08-16  Tom Tromey  <tom@tromey.com>
2284
2285         * tui/tui-winsource.h (tui_update_source_window)
2286         (tui_update_source_window_as_is): Remove "noerror" parameter.
2287         * tui/tui-winsource.c (tui_update_source_window)
2288         (tui_update_source_window_as_is): Remove "noerror" parameter.
2289         (tui_update_source_windows_with_addr)
2290         (tui_update_source_windows_with_line)
2291         (tui_source_window_base::rerender)
2292         (tui_source_window_base::refill): Update.
2293         * tui/tui-source.h (tui_set_source_content)
2294         (tui_show_symtab_source): Remove "noerror" parameter.
2295         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
2296         parameter.
2297         (tui_show_symtab_source): Likewise.
2298         (tui_source_window::maybe_update): Update.
2299         * tui/tui-disasm.c (tui_show_disassem)
2300         (tui_show_disassem_and_update_source)
2301         (tui_disasm_window::do_scroll_vertical)
2302         (tui_disasm_window::maybe_update): Update.
2303
2304 2019-08-16  Tom Tromey  <tom@tromey.com>
2305
2306         * tui/tui.c (tui_is_window_visible): Update.
2307         * tui/tui-wingeneral.c (tui_make_window)
2308         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
2309         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
2310         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
2311         (tui_set_win_height_command, parse_scrolling_args): Update.
2312         * tui/tui-source.c (tui_source_window::style_changed): Update.
2313         * tui/tui-regs.c (tui_show_registers)
2314         (tui_data_window::first_data_item_displayed)
2315         (tui_data_window::delete_data_content_windows)
2316         (tui_check_register_values, tui_reg_command): Update.
2317         * tui/tui-disasm.c (tui_show_disassem): Update.
2318         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
2319         method.
2320         <is_visible>: Remove field.
2321         * tui/tui-data.c (tui_next_win, tui_prev_win)
2322         (tui_delete_invisible_windows): Update.
2323
2324 2019-08-16  Tom Tromey  <tom@tromey.com>
2325
2326         * tui/tui-winsource.h (struct tui_source_window_base)
2327         <m_has_locator>: Remove.
2328         * tui/tui-layout.c (show_source_disasm_command, show_data)
2329         (show_source_or_disasm_and_command): Update.
2330
2331 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
2332
2333         * NEWS (Other MI changes): New subsection.
2334         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
2335         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
2336         * arch-utils.c (default_get_pc_address_flags): New function.
2337         * arch-utils.h (default_get_pc_address_flags): New declaration.
2338         * gdbarch.sh: Add get_pc_address_flags.
2339         * gdbarch.c: Regenerate.
2340         * gdbarch.h: Likewise.
2341         * stack.c (print_pc): New function.
2342         (print_frame_info) (print_frame): Call print_pc.
2343
2344 2019-08-16  Tom de Vries  <tdevries@suse.de>
2345
2346         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
2347         print_objfile_section_info.
2348
2349 2019-08-15  Tom Tromey  <tom@tromey.com>
2350
2351         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
2352         calling update_cmdwin_start_line.
2353         * tui/tui-winsource.h (struct tui_source_window_base)
2354         <do_make_visible_with_new_height, set_new_height>: Don't declare.
2355         <rerender>: Declare.
2356         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
2357         Call rerender.
2358         (tui_source_window_base::set_new_height): Remove.
2359         (tui_source_window_base::rerender): Rename from
2360         do_make_visible_with_new_height.
2361         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
2362         resize method.
2363         (tui_win_info::make_invisible_and_set_new_height)
2364         (tui_win_info::make_visible_with_new_height): Remove.
2365         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
2366         Declare.
2367         * tui/tui-stack.c (tui_locator_window::rerender): New method.
2368         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
2369         do_make_visible_with_new_height>: Don't declare.
2370         <rerender>: Declare.
2371         * tui/tui-regs.c (tui_data_window::rerender): Rename from
2372         set_new_height.
2373         (tui_data_window::do_make_visible_with_new_height): Remove.
2374         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
2375         call tui_show_locator_content.
2376         (tui_gen_win_info::resize): Call rerender.
2377         (show_source_or_disasm_and_command): Don't call
2378         tui_show_locator_content.
2379         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
2380         method.
2381         (struct tui_win_info) <rerender>: Declare.
2382         <set_new_height, make_invisible_and_set_new_height,
2383         make_visible_with_new_height>: Don't declare.
2384         * tui/tui-data.c (tui_win_list::rerender): New method.
2385         * tui/tui-command.h (struct tui_cmd_window)
2386         <do_make_visible_with_new_height>: Don't declare.
2387         * tui/tui-command.c
2388         (tui_cmd_window::do_make_visible_with_new_height): Remove.
2389
2390 2019-08-15  Tom Tromey  <tromey@adacore.com>
2391
2392         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
2393         * ada-lang.c (ada_enum_name): Likewise.
2394
2395 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
2396
2397         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
2398         leading underscore.
2399         (GdbOutputErrorFile): Likewise.
2400         (global scope): Adjust constructor calls to GdbOutput{,Error}File
2401         accordingly.
2402         (execute_unwinders): Rename to have a leading underscore.
2403         (auto_load_packages): Likewise.
2404         (global scope): Adjust call to auto_load_packages accordingly.
2405         (GdbSetPythonDirectory): Likewise.
2406         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
2407         instead of execute_unwinders.
2408
2409 2019-08-15  Tom Tromey  <tom@tromey.com>
2410
2411         * tui/tui-layout.c (show_layout, show_source_disasm_command)
2412         (show_data): Don't change window visibility.
2413         (tui_gen_win_info::resize): Remove special case for command
2414         window.  Use wresize, when available.
2415         (show_source_or_disasm_and_command): Don't change window
2416         visibility.
2417         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
2418         <make_visible>: New method.
2419         * tui/tui-command.c (tui_cmd_window::resize): New method.
2420
2421 2019-08-15  Tom Tromey  <tom@tromey.com>
2422
2423         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
2424         (struct tui_source_windows): New.
2425         * tui/tui-winsource.c (tui_display_main): Update.
2426         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
2427         (new_height_ok, parse_scrolling_args): Update.
2428         * tui/tui-layout.c (show_layout, show_data): Update.
2429         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
2430         (tui_add_to_source_windows): Don't declare.
2431         * tui/tui-data.c (source_windows, tui_source_windows)
2432         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
2433
2434 2019-08-15  Tom Tromey  <tom@tromey.com>
2435
2436         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
2437         Rename from reset.
2438         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
2439         * tui/tui-layout.c (show_source_disasm_command, show_data):
2440         Update.
2441         (tui_gen_win_info::resize): Rename.
2442         (show_source_or_disasm_and_command): Update.
2443         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
2444         reset.
2445
2446 2019-08-15  Tom Tromey  <tom@tromey.com>
2447
2448         * tui/tui-stack.c (tui_initialize_static_data): Remove.
2449         * tui/tui-interp.c (tui_interp::init): Don't call
2450         tui_initialize_static_data.
2451         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
2452
2453 2019-08-15  Tom Tromey  <tom@tromey.com>
2454
2455         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
2456         examine tui_win_list.
2457
2458 2019-08-15  Tom Tromey  <tom@tromey.com>
2459
2460         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
2461         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
2462         tui_clear_source_content.
2463         (tui_clear_source_content): Remove.
2464         (tui_source_window_base::do_erase_source_content): Hoist call to
2465         content.clear().
2466         * tui/tui-stack.c (tui_show_frame_info): Don't call
2467         tui_clear_source_content.
2468
2469 2019-08-15  Tom Tromey  <tom@tromey.com>
2470
2471         * tui/tui-winsource.h (struct tui_source_window_base)
2472         <do_erase_source_content>: New method.
2473         <erase_source_content>: New method.
2474         (tui_erase_source_content): Don't declare.
2475         * tui/tui-winsource.c (tui_clear_source_content): Update.
2476         (tui_source_window_base::do_erase_source_content): Rename from
2477         tui_erase_source_content.
2478         (tui_source_window_base::show_source_content): Update.
2479         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
2480         * tui/tui-source.h (struct tui_source_window)
2481         <erase_source_content>: New method.
2482         * tui/tui-disasm.h (struct tui_disasm_window)
2483         <erase_source_content>: New method.
2484
2485 2019-08-15  Tom Tromey  <tom@tromey.com>
2486
2487         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
2488         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
2489         constructor.
2490         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
2491         * tui/tui-source.c (tui_set_source_content): Update.
2492         * tui/tui-disasm.c (tui_set_disassem_content): Update.
2493
2494 2019-08-15  Tom Tromey  <tom@tromey.com>
2495
2496         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
2497         * tui/tui-winsource.c (tui_line_is_displayed): Move to
2498         tui-source.c.
2499         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
2500         Declare.
2501         * tui/tui-source.c (tui_source_window::line_is_displayed): New
2502         method.
2503         (tui_source_window::maybe_update): Update.
2504
2505 2019-08-15  Tom Tromey  <tom@tromey.com>
2506
2507         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
2508         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
2509         tui-disasm.c.
2510         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
2511         Declare.
2512         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
2513         method.
2514         (tui_disasm_window::maybe_update): Update.
2515
2516 2019-08-15  Tom Tromey  <tom@tromey.com>
2517
2518         * tui/tui-winsource.h (struct tui_source_window_base)
2519         <maybe_update>: Declare.
2520         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
2521         method.
2522         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
2523         Declare.
2524         * tui/tui-source.c (tui_source_window::maybe_update): New method.
2525         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
2526         Declare.
2527         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
2528
2529 2019-08-15  Tom Tromey  <tom@tromey.com>
2530
2531         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
2532
2533 2019-08-15  Tom Tromey  <tom@tromey.com>
2534
2535         * tui/tui-wingeneral.c: Include tui-stack.h.
2536         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
2537         (struct tui_locator_window): Move from tui-data.h.
2538         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
2539         (tui_initialize_static_data): Move from tui-data.c.
2540         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
2541         (struct tui_locator_window): Move to tui-stack.c.
2542         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
2543         (tui_initialize_static_data): Move to tui-stack.c.
2544
2545 2019-08-15  Tom Tromey  <tom@tromey.com>
2546
2547         * tui/tui-layout.c (show_source_disasm_command)
2548         (show_source_or_disasm_and_command): Use make_visible method, not
2549         tui_make_window.
2550         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
2551         Remove.
2552
2553 2019-08-15  Tom Tromey  <tom@tromey.com>
2554
2555         * tui/tui-wingeneral.h (tui_make_window): Update.
2556         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
2557         parameter.
2558         (tui_gen_win_info::make_visible): Update.
2559         * tui/tui-regs.c (tui_data_window::display_registers_from):
2560         Update.
2561         * tui/tui-layout.c (show_source_disasm_command)
2562         (show_source_or_disasm_and_command): Update.
2563         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
2564         (enum tui_box): Remove.
2565         (struct tui_win_info) <can_box>: New method.
2566         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
2567         method.
2568
2569 2019-08-15  Tom de Vries  <tdevries@suse.de>
2570
2571         * linux-nat-trad.c: Include gdbarch.h.
2572
2573 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
2574
2575         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
2576         register sizes.
2577
2578 2019-08-14  Tom Tromey  <tromey@adacore.com>
2579
2580         * darwin-nat.c: Include gdbarch.h.
2581         * darwin-nat-info.c: Include gdbarch.h.
2582
2583 2019-08-13  Tom Tromey  <tom@tromey.com>
2584
2585         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
2586         Remove.
2587         * tui/tui-data.c (tui_initialize_static_data): Update.
2588
2589 2019-08-13  Tom Tromey  <tom@tromey.com>
2590
2591         * tui/tui-winsource.h (struct tui_exec_info_window)
2592         <~tui_exec_info_window, maybe_allocate_content, get_content,
2593         m_content>: Remove.
2594         (struct tui_source_window_base) <set_exec_info_content,
2595         show_exec_info_content>: Don't declare.
2596         * tui/tui-winsource.c
2597         (tui_exec_info_window::maybe_allocate_content): Remove.
2598         (tui_source_window_base::update_exec_info): Rename from
2599         set_exec_info_content.
2600         (tui_source_window_base::show_exec_info_content)
2601         (tui_source_window_base::update_exec_info): Remove.
2602
2603 2019-08-13  Tom Tromey  <tom@tromey.com>
2604
2605         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
2606         declare.
2607         * tui/tui-winsource.c (tui_update_source_window_as_is)
2608         (tui_update_source_windows_with_addr, tui_erase_source_content):
2609         Update.
2610         (tui_clear_exec_info_content): Remove.
2611
2612 2019-08-13  Tom Tromey  <tom@tromey.com>
2613
2614         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
2615         declare.
2616         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
2617         call tui_erase_exec_info_content.
2618         (tui_clear_exec_info_content): Rename from
2619         tui_erase_exec_info_content.
2620         (tui_clear_exec_info_content): Delete.
2621
2622 2019-08-13  Tom Tromey  <tom@tromey.com>
2623
2624         * tui/tui-winsource.h (struct tui_source_window_base)
2625         <show_exec_info_content>: Declare.
2626         (tui_show_exec_info_content): Don't declare.
2627         * tui/tui-winsource.c
2628         (tui_source_window_base::show_exec_info_content): Rename from
2629         tui_show_exec_info_content.
2630         (tui_source_window_base::update_exec_info): Update.
2631
2632 2019-08-13  Tom Tromey  <tom@tromey.com>
2633
2634         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
2635         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
2636         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
2637         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
2638         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
2639         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
2640         ... here.
2641
2642 2019-08-13  Tom Tromey  <tom@tromey.com>
2643
2644         * tui/tui-winsource.h (struct tui_source_window_base)
2645         <update_exec_info>: Declare.
2646         (tui_update_exec_info): Don't declare.
2647         * tui/tui-winsource.c (tui_update_source_window_as_is)
2648         (tui_source_window_base::refresh_all)
2649         (tui_update_all_breakpoint_info): Update.
2650         (tui_source_window_base::update_exec_info): Rename from
2651         tui_update_exec_info.
2652         * tui/tui-stack.c (tui_show_frame_info): Update.
2653
2654 2019-08-13  Tom Tromey  <tom@tromey.com>
2655
2656         * tui/tui-winsource.h (struct tui_source_window_base)
2657         <set_exec_info_content>: Declare.
2658         (tui_set_exec_info_content): Don't declare.
2659         * tui/tui-winsource.c
2660         (tui_source_window_base::set_exec_info_content): Rename from
2661         tui_set_exec_info_content.
2662         (tui_update_exec_info): Update.
2663
2664 2019-08-13  Tom Tromey  <tom@tromey.com>
2665
2666         * tui/tui-winsource.h (struct tui_source_window_base)
2667         <show_source_content>: Declare.
2668         (tui_show_source_content): Don't declare.
2669         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
2670         (tui_source_window_base::show_source_content): Rename from
2671         tui_show_source_content.
2672         (tui_source_window_base::refresh_all): Update.
2673         * tui/tui-layout.c (show_source_disasm_command)
2674         (show_source_or_disasm_and_command): Update.
2675
2676 2019-08-13  Tom Tromey  <tom@tromey.com>
2677
2678         * tui/tui-winsource.c (tui_erase_source_content)
2679         (tui_show_source_content, tui_source_window_base::refresh_all):
2680         Update.
2681         * tui/tui-wingeneral.h
2682         (tui_check_and_display_highlight_if_needed): Don't declare.
2683         * tui/tui-wingeneral.c
2684         (tui_win_info::check_and_display_highlight_if_needed): Rename from
2685         check_and_display_highlight_if_needed.
2686         * tui/tui-win.c (tui_rehighlight_all)
2687         (tui_win_info::make_visible_with_new_height): Update.
2688         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
2689         (tui_data_window::erase_data_content)
2690         (tui_data_window::display_all_data): Update.
2691         * tui/tui-data.h (struct tui_win_info)
2692         <check_and_display_highlight_if_needed>: Declare.
2693
2694 2019-08-13  Tom Tromey  <tom@tromey.com>
2695
2696         * tui/tui-win.c (tui_resize_all): Call
2697         tui_delete_invisible_windows.
2698         * tui/tui-layout.c (show_layout): Call
2699         tui_delete_invisible_windows.
2700         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
2701         * tui/tui-data.c (tui_delete_invisible_windows): New function.
2702
2703 2019-08-13  Tom Tromey  <tom@tromey.com>
2704
2705         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
2706         tui_add_win_to_layout.
2707
2708 2019-08-13  Tom Tromey  <tom@tromey.com>
2709
2710         * tui/tui-layout.h (tui_default_win_height): Don't declare.
2711         * tui/tui-layout.c (tui_default_win_height): Now static.
2712
2713 2019-08-13  Tom Tromey  <tom@tromey.com>
2714
2715         * tui/tui-layout.c (show_layout): Unify all layout cases into a
2716         single switch.
2717         (show_source_disasm_command, show_source_or_disasm_and_command):
2718         Don't check current layout.
2719
2720 2019-08-13  Tom Tromey  <tom@tromey.com>
2721
2722         * tui/tui-wingeneral.c (make_all_visible): Remove.
2723         (tui_make_all_invisible): Simplify.
2724         * tui/tui-layout.c (tui_make_all_invisible): Move from
2725         tui-wingeneral.c; simplify.
2726         (show_layout): Hoist call to tui_make_all_invisible.
2727         (show_data): Don't call tui_make_all_invisible.
2728
2729 2019-08-13  Tom Tromey  <tom@tromey.com>
2730
2731         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
2732         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
2733
2734 2019-08-13  Tom Tromey  <tom@tromey.com>
2735
2736         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
2737         tui-data.c.
2738         (show_source_disasm_command, show_data)
2739         (show_source_or_disasm_and_command): Don't use
2740         tui_set_current_layout_to.
2741         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
2742         * tui/tui-data.c (current_layout, tui_current_layout): Move to
2743         tui-layout.c.
2744         (tui_set_current_layout_to): Remove.
2745
2746 2019-08-13  Tom Tromey  <tom@tromey.com>
2747
2748         * tui/tui-layout.c (tui_set_layout): Update.
2749         * tui/tui-data.h (struct tui_layout_def): Remove.
2750         (tui_layout_def): Don't declare.
2751         * tui/tui-data.c (layout_def): Remove.
2752         (tui_layout_def): Remove.
2753
2754 2019-08-13  Tom Tromey  <tom@tromey.com>
2755
2756         * tui/tui-winsource.h (struct tui_source_window_base)
2757         <clear_detail>: No longer "override".
2758         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
2759         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
2760         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
2761         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
2762         Remove.
2763         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
2764
2765 2019-08-13  Tom Tromey  <tromey@adacore.com>
2766
2767         * tracepoint.c: Don't include readline.h or history.h.
2768
2769 2019-08-12  Tom Tromey  <tom@tromey.com>
2770
2771         * configure: Rebuild.
2772         * configure.ac: Check for readline 7.
2773         * NEWS: Mention readline 7 requirement.
2774         * README: Update.
2775
2776 2019-08-12  Tom Tromey  <tom@tromey.com>
2777
2778         * mingw-hdep.c (gdb_select): Remove readline hack.
2779
2780 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
2781
2782         * blockframe.c (find_pc_partial_function): Set *block to nullptr
2783         when the function fails.
2784
2785 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
2786
2787         * s390-tdep.c (s390_type_align): New function.
2788         (s390_gdbarch_init): Set it as type_align gdbarch method.
2789
2790 2019-08-09  Tom de Vries  <tdevries@suse.de>
2791
2792         PR gdb/24591
2793         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
2794         pc_low with relocation offset.
2795
2796 2019-08-07  Tom Tromey  <tromey@adacore.com>
2797
2798         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2799         (print_frame_args): Update.
2800         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
2801         Update.
2802         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2803         * frame.h (struct frame_arg): Add initializers.
2804         <error>: Now a unique_xmalloc_ptr.
2805
2806 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
2807
2808         * NEWS: Expand the Pointer Authentication entry.
2809         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
2810         (aarch64_frame_unmask_lr): ... to this.
2811         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
2812         Call aarch64_frame_unmask_lr.
2813         * frame.c (struct frame_info): Add "masked" variable.
2814         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
2815         (fprint_frame): Check for masked pc.
2816         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
2817         declarations.
2818         * python/py-framefilter.c (py_print_frame): Check for masked pc.
2819         * stack.c (print_frame): Check for masked pc.
2820
2821 2019-08-06  Tom Tromey  <tom@tromey.com>
2822
2823         * stabsread.c (patch_block_stabs, read_one_struct_field)
2824         (read_enum_type): Use obstack_strndup.
2825         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
2826         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
2827         * dwarf2read.c (guess_full_die_structure_name)
2828         (anonymous_struct_prefix): Use obstack_strndup.
2829         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
2830         * c-exp.y (yylex): Use obstack_strndup.
2831         * ada-exp.y (write_object_renaming, write_ambiguous_var)
2832         (write_var_or_type): Use obstack_strndup.
2833
2834 2019-08-06  Tom Tromey  <tom@tromey.com>
2835
2836         * symfile.c (reread_symbols): Use obstack_strdup.
2837         * stabsread.c (read_type): Use obstack_strdup.
2838         * gdb_obstack.h (obstack_strdup): New overload.
2839         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
2840         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
2841         (dwarf2_canonicalize_name): Use obstack_strdup.
2842         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
2843         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
2844         Use obstack_strdup.
2845
2846 2019-08-06  Tom Tromey  <tom@tromey.com>
2847
2848         * gdb_obstack.h (obstack_strdup): Define.
2849         * gdb_obstack.c (obstack_strdup): Don't define.
2850
2851 2019-08-06  Tom Tromey  <tom@tromey.com>
2852
2853         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
2854         obstack_strdup.
2855         * typeprint.c (typedef_hash_table::find_global_typedef): Use
2856         obstack_strdup.
2857         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
2858         * stabsread.c (common_block_start): Use obstack_strdup.
2859         * objfiles.c (set_objfile_main_name, objfile): Use
2860         obstack_strdup.
2861         * namespace.c (add_using_directive): Use obstack_strdup.
2862         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
2863         * jit.c (finalize_symtab): Use obstack_strdup.
2864         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
2865         (guess_partial_die_structure_name, partial_die_info::fixup)
2866         (dwarf2_name): Use obstack_strdup.
2867         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
2868         obstack_strdup.
2869         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
2870         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
2871         obstack_strdup.
2872         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
2873
2874 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2875
2876         * unittests/help-doc-selftests.c: New file.
2877         * Makefile.in: Add the new file.
2878
2879 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2880
2881         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
2882         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
2883         the full first line, except when FOR_VALUE_PREFIX.  In this case,
2884         the trailing '.' is not output, and the first character is uppercased.
2885         (print_help_for_command): Update call to print_doc_line.
2886         (print_doc_of_command): Likewise.
2887         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
2888         * cli/cli-option.c (append_indented_doc): Do not append newline.
2889         (build_help_option): Append newline after first appended_indented_doc
2890         only if a second call is done.
2891         (build_help): Append 2 new lines before each option, except the first
2892         one.
2893         * compile/compile.c (_initialize_compile): Add new lines after
2894         %OPTIONS%, when not at the end of the help.
2895         Change help doc or code
2896         producing the help doc to respect the invariants.
2897         * maint-test-options.c (_initialize_maint_test_options): Likewise.
2898         Also removed the new line after 'Options:', as all other commands
2899         do not put an empty line between 'Options:' and the first option.
2900         * printcmd.c (_initialize_printcmd): Likewise.
2901         * stack.c (_initialize_stack): Likewise.
2902         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
2903         incorrectly telling COMMAND is optional.
2904         * ada-lang.c (_initialize_ada_language): Change help doc or code
2905         producing the help doc to respect the invariants.
2906         * ada-tasks.c (_initialize_ada_tasks): Likewise.
2907         * breakpoint.c (_initialize_breakpoint): Likewise.
2908         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
2909         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
2910         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
2911         * cli/cli-style.c (cli_style_option::add_setshow_commands,
2912         _initialize_cli_style): Likewise.
2913         * corelow.c (core_target_info): Likewise.
2914         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
2915         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
2916         * filesystem.c (_initialize_filesystem): Likewise.
2917         * frame.c (_initialize_frame): Likewise.
2918         * gnu-nat.c (add_task_commands): Likewise.
2919         * infcall.c (_initialize_infcall): Likewise.
2920         * infcmd.c (_initialize_infcmd): Likewise.
2921         * interps.c (_initialize_interpreter): Likewise.
2922         * language.c (_initialize_language): Likewise.
2923         * linux-fork.c (_initialize_linux_fork): Likewise.
2924         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
2925         * maint.c (_initialize_maint_cmds): Likewise.
2926         * memattr.c (_initialize_mem): Likewise.
2927         * printcmd.c (_initialize_printcmd): Likewise.
2928         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
2929         _RegEx): Likewise.
2930         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
2931         * record-btrace.c (_initialize_record_btrace): Likewise.
2932         * record-full.c (_initialize_record_full): Likewise.
2933         * record.c (_initialize_record): Likewise.
2934         * regcache-dump.c (_initialize_regcache_dump): Likewise.
2935         * regcache.c (_initialize_regcache): Likewise.
2936         * remote.c (add_packet_config_cmd, init_remote_threadtests,
2937         _initialize_remote): Likewise.
2938         * ser-tcp.c (_initialize_ser_tcp): Likewise.
2939         * serial.c (_initialize_serial): Likewise.
2940         * skip.c (_initialize_step_skip): Likewise.
2941         * source.c (_initialize_source): Likewise.
2942         * stack.c (_initialize_stack): Likewise.
2943         * symfile.c (_initialize_symfile): Likewise.
2944         * symtab.c (_initialize_symtab): Likewise.
2945         * target-descriptions.c (_initialize_target_descriptions): Likewise.
2946         * top.c (init_main): Likewise.
2947         * tracefile-tfile.c (tfile_target_info): Likewise.
2948         * tracepoint.c (_initialize_tracepoint): Likewise.
2949         * tui/tui-win.c (_initialize_tui_win): Likewise.
2950         * utils.c (add_internal_problem_command): Likewise.
2951         * valprint.c (value_print_option_defs): Likewise.
2952
2953 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
2954
2955         PR build/24886
2956         * configure.ac: Drop enable-libmcheck support.
2957         * configure, config.in: Rebuild.
2958         * libmcheck.m4: Remove.
2959         * acinclude.m4: Don't include it.
2960         * Makefile.in: Don't distribute it.
2961         * top.c (print_gdb_configuration): Don't mention it.
2962
2963 2019-08-06  Tom Tromey  <tom@tromey.com>
2964
2965         * utils.c (set_output_style): Sometimes pass stream to
2966         emit_style_escape.
2967         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
2968         * record-btrace.c (btrace_insn_history): Update.
2969         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
2970         method.
2971         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
2972         Update initializers.
2973         <m_uiout>: New field.
2974         <m_di>: Move lower.
2975         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
2976         Remove "uiout" parameter.
2977         (dump_insns): Update.
2978         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
2979         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
2980
2981 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
2982
2983         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
2984         (error_in_psymtab_expansion): Likewise.
2985         (lookup_symbol_via_quick_fns): Likewise.
2986         (basic_lookup_transparent_type_quick): Likewise.
2987         (basic_lookup_transparent_type_1): Likewise.
2988
2989 2019-08-06  Tom Tromey  <tromey@adacore.com>
2990
2991         * source.c (last_source_error): Now bool.
2992         (print_source_lines_base): Make "noprint" bool.  Only open
2993         source file when last_source_visited changes.
2994
2995 2019-08-06  Tom Tromey  <tromey@adacore.com>
2996
2997         * annotate.c (annotate_source_line): Use g_source_cache.
2998         * source-cache.c (source_cache::get_plain_source_lines): Change
2999         parameters.  Populate m_offset_cache.
3000         (source_cache::ensure): New method.
3001         (source_cache::get_line_charpos): New method.
3002         (extract_lines): Move lower.  Change parameters.
3003         (source_cache::get_source_lines): Move lower.
3004         * source-cache.h (class source_cache): Update comment.
3005         <get_line_charpos>: New method.
3006         <get_source_lines>: Update comment.
3007         <clear>: Clear m_offset_cache.
3008         <get_plain_source_lines>: Change parameters.
3009         <ensure>: New method
3010         <m_offset_cache>: New member.
3011         * source.c (forget_cached_source_info_for_objfile): Update.
3012         (info_source_command): Use g_source_cache.
3013         (find_source_lines, open_source_file_with_line_charpos): Remove.
3014         (print_source_lines_base, search_command_helper): Use g_source_cache.
3015         * source.h (open_source_file_with_line_charpos): Don't declare.
3016         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
3017         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
3018         Use g_source_cache.
3019
3020 2019-08-06  Tom Tromey  <tromey@adacore.com>
3021
3022         * source-cache.c (source_cache::get_plain_source_lines):
3023         Remove "first_line" and "last_line" parameters.
3024         (source_cache::get_source_lines): Cache plain text.
3025         * source-cache.h (class source_cache)
3026         <get_plain_source_lines>: Update.
3027
3028 2019-08-06  Tom Tromey  <tromey@adacore.com>
3029
3030         * source-cache.c (extract_lines): No longer a method.
3031         Changed type of parameter.  Include final newline.
3032         (selftests::extract_lines_test): New function.
3033         (_initialize_source_cache): Likewise.
3034         * source-cache.h (class source_cache)
3035         <extract_lines>: Don't declare.
3036
3037 2019-08-06  Tom Tromey  <tromey@adacore.com>
3038
3039         * breakpoint.c (init_breakpoint_sal): Update.
3040         (breakpoint): Update.
3041         * breakpoint.h (struct breakpoint) <filter>: Now a
3042         unique_xmalloc_ptr.
3043
3044 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3045
3046         * NEWS: Mention dictionary access on blocks.
3047         * python/py-block.c (blpy_getitem): New function.
3048         (block_object_as_mapping): New struct.
3049         (block_object_type): Use new struct for tp_as_mapping field.
3050
3051 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
3052
3053         * objfiles.h (objfile): Add a comment describing partial symbols.
3054
3055 2019-08-05  Tom Tromey  <tromey@adacore.com>
3056
3057         * compile/compile.c (_initialize_compile): Use _(), not N_().
3058         * thread.c (_initialize_thread): Use _(), not N_().
3059         * stack.c (_initialize_stack): Use _(), not N_().
3060         * printcmd.c (_initialize_printcmd): Use _(), not N_().
3061
3062 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
3063
3064         * dwarf2read.c (struct dw2_symtab_iterator):
3065         <want_specific_block>: Remove.
3066         <block_index>: Change type to gdb::optional.
3067         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
3068         change type of BLOCK_INDEX parameter to gdb::optional.
3069         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
3070         (dw2_lookup_symbol): Don't pass argument for
3071         WANT_SPECIFIC_BLOCK.
3072         (dw2_expand_symtabs_for_function): Don't pass argument for
3073         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
3074         (class dw2_debug_names_iterator)
3075         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
3076         parameter, change BLOCK_INDEX type to gdb::optional.
3077         <m_want_specific_block>: Remove.
3078         <m_block_index>: Change type to gdb::optional.
3079         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
3080         gdb::optional.  Re-write in function of gdb::optional.
3081         (dw2_debug_names_lookup_symbol): Don't pass argument for
3082         WANT_SPECIFIC_BLOCK.
3083         (dw2_debug_names_expand_symtabs_for_function): Don't pass
3084         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
3085         BLOCK_INDEX.
3086
3087 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3088
3089         * NEWS: Mention changes to "info sources" command.
3090
3091 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3092
3093         * symtab.c (filename_partial_match_opts): New struct type.
3094         (struct output_source_filename_data): New members
3095         regexp, c_regexp, partial_match.
3096         (output_source_filename): Use new members to decide to print file.
3097         (info_sources_option_defs): New variable.
3098         (make_info_sources_options_def_group, print_info_sources_header,
3099         info_sources_command_completer):
3100         New functions.
3101         (info_sources_command): Read new optional arguments.
3102         (_initialize_symtab): Update info sources help.
3103
3104 2019-08-02  Alexandre Oliva <oliva@adacore.com>
3105
3106         * ada-lang.c (exception_support_info_v0): Renamed from...
3107         (default_exception_support_info): ... this.  Create new
3108         definition for v1.
3109         (ada_has_this_exception_support): Look up catch_handlers_sym.
3110         (ada_exception_support_info_sniffer): Try v0 after default.
3111
3112 2019-08-01  Tom Tromey  <tromey@adacore.com>
3113
3114         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
3115         gdbarch.h.
3116
3117 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
3118
3119         * s12z-tdep.c: Fix include path for s12z-opc.h.
3120
3121 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
3122
3123         * NEWS: Require GNU make 3.82.
3124
3125 2019-07-16  Tom Tromey  <tom@tromey.com>
3126
3127         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
3128         declare.
3129
3130 2019-07-30  Tom Tromey  <tromey@adacore.com>
3131
3132         * block.c (contained_in): Remove BLOCK_FUNCTION check.
3133
3134 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
3135
3136         * printcmd.c (print_address_symbolic): Print negative offsets.
3137         (build_address_symbolic): Force signed arithmetic when computing
3138         offset.
3139
3140 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
3141
3142         PR/24474: Add a function to lookup static variables.
3143         * NEWS: Mention this new function.
3144         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
3145         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
3146         * python/python.c (python_GdbMethods): Add new function.
3147
3148 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
3149
3150         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
3151         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
3152         (objfpy_lookup_static_symbol): New function.
3153         (objfile_object_methods): Add new functions.
3154
3155 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3156
3157         * NEWS: Mention 'set|show print frame-info'.  Mention new
3158         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
3159         backtrace argument.  Mention that python frame filtering code
3160         is now consistent with what 'backtrace' command prints.
3161
3162 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3163
3164         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
3165         comments.
3166         (print_frame_info_auto, print_frame_info_source_line,
3167         print_frame_info_location, print_frame_info_source_and_location,
3168         print_frame_info_location_and_address, print_frame_info_short_location):
3169         New declarations.
3170         (struct frame_print_options): New member print_frame_info.
3171         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
3172         * stack.h (get_user_print_what_frame_info): New declaration.
3173         (frame_show_address): New declaration.
3174         * stack.c (print_frame_arguments_choices): New value 'presence'.
3175         (print_frame_info_auto, print_frame_info_source_line,
3176         print_frame_info_location, print_frame_info_source_and_location,
3177         print_frame_info_location_and_address, print_frame_info_short_location,
3178         print_frame_info_choices, print_frame_info_print_what): New definitions.
3179         (print_frame_args): Only print dots for args if print frame-arguments
3180         is 'presence'.
3181         (frame_print_option_defs): New element for "frame-info".
3182         (get_user_print_what_frame_info): New function.
3183         (frame_show_address): Make non static.  Move comment to stack.h.
3184         (print_frame_info_to_print_what): New function.
3185         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
3186         to decide what to print.
3187         (backtrace_command_1): Handle the new print_frame_arguments_presence
3188         value.
3189         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
3190         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
3191         (py_print_frame): In non-mi mode, use LOCATION as default for
3192         print_what, similarly to frame information printed directly by
3193         backtrace command. Handle frame-info user option in non MI mode.
3194
3195 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3196
3197         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
3198         Add case for debugging 32-bit target on 64-bit host.  Revise
3199         comment.
3200
3201 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3202
3203         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
3204         instead of find_function_entry_range_from_pc.
3205
3206 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
3207
3208         * stack.c (find_frame_funname): Remove code which preferred
3209         minsym over symtab sym in "certain pathological cases".
3210
3211         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
3212         parameter.  Change type of "do_demangle" to bool.
3213         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3214         Pass suitable "prefer_sym_over_minsym" flag to
3215         build_address_symbolic().  Don't output "+" for negative offsets.
3216         * printcmd.c (print_address_symbolic): Update invocation of
3217         build_address_symbolic to include a "prefer_sym_over_minsym"
3218         flag.
3219         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
3220         Restrict cases in which use of minimal symbol is preferred to that
3221         of a found symbol.  Update comments.
3222
3223         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
3224         for entry pc when entry pc is out of range for that FDE.
3225
3226 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
3227
3228         PR gdb/24839:
3229         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
3230         type.
3231
3232 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
3233
3234         * python/py-objfile.c (add_separate_debug_file): Fix comment about
3235         this function's Python signature.
3236
3237
3238 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
3239
3240         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
3241         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3242         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
3243         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
3244         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
3245
3246
3247 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
3248
3249         * h8300-tdep.c (h8300_register_name_common): New.
3250         h8300_register_name): Use h8300_register_name_common.
3251         (h8300s_register_name): Likewise.
3252         (h8300sx_register_name): Likewise.
3253         (h8300h_register_nam): New.
3254         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
3255
3256
3257 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
3258
3259         * arm-tdep.c (arm_skip_cmse_entry): New function.
3260         (arm_is_sgstubs_section): New function.
3261         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
3262
3263 2019-07-22  Tom Tromey  <tom@tromey.com>
3264
3265         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
3266         Don't self-assign.
3267
3268 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3269
3270         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
3271         type_print.
3272
3273 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3274
3275         * symtab.c (search_symbols): Adjust msymbol matching type arrays
3276         so that GDB doesn't match any msymbols when searching in the
3277         TYPES_DOMAIN.
3278         (print_symbol_info): Print using typedef_print or type_print based
3279         on the type of the symbol.  Add updated FIXME comment moved from...
3280         (_initialize_symtab): ... move and update FIXME comment to above.
3281
3282 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
3283
3284         * NEWS: Mention adding -q option to "info types".
3285         * symtab.c (struct info_types_options): New struct.
3286         (info_types_options_defs): New variable.
3287         (make_info_types_options_def_group): New function.
3288         (info_types_command): Use gdb::option framework to parse options.
3289         (info_types_command_completer): New function.
3290         (_initialize_symtab): Extend the help text on "info types" and
3291         register command completer.
3292
3293 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
3294
3295         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
3296         (lookup_symbol_in_objfile): Change int to block_enum and add a
3297         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
3298
3299 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
3300
3301         * MAINTAINERS (Write After Approval): Add self.
3302
3303 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3304
3305         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
3306         instruction to the dummy code region.
3307
3308 2019-07-19  Tom Tromey  <tromey@adacore.com>
3309
3310         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
3311         (ARGSUSED, PARAMS, __func__): Remove rules.
3312
3313 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3314
3315         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
3316         * features/arm/arm-with-iwmmxt.c: Remove.
3317         * features/arm/arm-with-iwmmxt.xml: Remove.
3318         * features/arm/arm-with-m-fpa-layout.c: Remove.
3319         * features/arm/arm-with-m-fpa-layout.xml: Remove.
3320         * features/arm/arm-with-m-vfp-d16.c: Remove.
3321         * features/arm/arm-with-m-vfp-d16.xml: Remove.
3322         * features/arm/arm-with-m.c: Remove.
3323         * features/arm/arm-with-m.xml: Remove.
3324         * features/arm/arm-with-neon.c: Remove.
3325         * features/arm/arm-with-neon.xml: Remove.
3326         * features/arm/arm-with-vfpv2.c: Remove.
3327         * features/arm/arm-with-vfpv2.xml: Remove.
3328         * features/arm/arm-with-vfpv3.c: Remove.
3329         * features/arm/arm-with-vfpv3.xml: Remove.
3330
3331 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3332
3333         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
3334
3335 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3336
3337         * arch/aarch32.c (aarch32_create_target_description): Create
3338         target descriptions using features.
3339         * arch/arm.c (arm_create_target_description)
3340         (arm_create_mprofile_target_description): Likewise.
3341         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
3342
3343 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
3344
3345         * Makefile.in: Add new files.
3346         * aarch32-tdep.c: New file.
3347         * aarch32-tdep.h: New file.
3348         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3349         Call aarch32_read_description.
3350         * arch/aarch32.c: New file.
3351         * arch/aarch32.h: New file.
3352         * arch/arm.c (arm_create_target_description)
3353         (arm_create_mprofile_target_description): New function.
3354         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
3355         (arm_create_target_description)
3356         (arm_create_mprofile_target_description): New declaration.
3357         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
3358         read_description functions.
3359         * arm-linux-nat.c (arm_linux_nat_target::read_description):
3360         Likewise.
3361         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3362         * arm-tdep.c (tdesc_arm_list): New variable.
3363         (arm_register_g_packet_guesses): Call create description functions.
3364         (arm_read_description) (arm_read_mprofile_description): New
3365         function.
3366         * arm-tdep.h (arm_read_description)
3367         (arm_read_mprofile_description): Add declaration.
3368         * configure.tgt: Add new files.
3369
3370 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
3371
3372         * top.c (new_ui_command): Open specified terminal just once.
3373
3374 2019-07-18  Tom Tromey  <tromey@adacore.com>
3375
3376         * symtab.c (main_name): Constify return type.
3377         * symfile.c (set_initial_language): Update.
3378         * symtab.h (main_name): Constify return type.
3379
3380 2019-07-17  Tom Tromey  <tom@tromey.com>
3381
3382         * tui/tui-winsource.c (tui_update_source_window)
3383         (tui_update_source_window_as_is)
3384         (tui_update_source_windows_with_line): Remove return.
3385         * tui/tui-disasm.c (tui_show_disassem)
3386         (tui_show_disassem_and_update_source): Remove return.
3387         * tui/tui.c (tui_reset): Remove return.
3388         * tui/tui-wingeneral.c
3389         (tui_check_and_display_highlight_if_needed): Remove return.
3390
3391 2019-07-17  Tom Tromey  <tom@tromey.com>
3392
3393         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
3394
3395 2019-07-17  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui-winsource.h (struct tui_exec_info_window)
3398         (struct tui_source_window_base): Move from tui-data.h.
3399         * tui/tui-winsource.c: Move many method definitions from
3400         elsewhere.  Remove "structuring" comments.
3401         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
3402         (tui_source_window_base::refresh_window): Move to
3403         tui-winsource.c.
3404         * tui/tui-win.c (tui_source_window_base::refresh_all)
3405         (tui_source_window_base::update_tab_width)
3406         (tui_source_window_base::set_new_height)
3407         (tui_source_window_base::do_make_visible_with_new_height): Move to
3408         tui-winsource.c.
3409         * tui/tui-source.h: Update.
3410         * tui/tui-source.c (tui_source_window_base::reset): Move to
3411         tui-winsource.c.
3412         * tui/tui-disasm.h: Update.
3413         * tui/tui-data.h (struct tui_exec_info_window): Move to
3414         tui-winsource.h.
3415         (struct tui_source_window_base): Likewise.
3416         * tui/tui-data.c (tui_source_window_base::clear_detail)
3417         (tui_source_window_base, ~tui_source_window_base): Move to
3418         tui-winsource.c.
3419
3420 2019-07-17  Tom Tromey  <tom@tromey.com>
3421
3422         * tui/tui-win.c (tui_resize_all)
3423         (tui_source_window_base::update_tab_width)
3424         (tui_adjust_win_heights): Update.
3425         (tui_win_info::make_invisible_and_set_new_height): Rename from
3426         make_invisible_and_set_new_height.
3427         * tui/tui-data.h (struct tui_win_info)
3428         <make_invisible_and_set_new_height>: New method.
3429
3430 2019-07-17  Tom Tromey  <tom@tromey.com>
3431
3432         * tui/tui.c: Update.
3433         * tui/tui-source.h (struct tui_source_window): Move from
3434         tui-data.h.
3435         * tui/tui-layout.c: Update.
3436         * tui/tui-disasm.c: Update.
3437         * tui/tui-data.h (struct tui_source_window): Move to
3438         tui-source.h.
3439
3440 2019-07-17  Tom Tromey  <tom@tromey.com>
3441
3442         * tui/tui-disasm.h (struct tui_disasm_window): Move from
3443         tui-data.h.
3444         * tui/tui-data.h (struct tui_disasm_window): Move to
3445         tui-disasm.h.
3446
3447 2019-07-17  Tom Tromey  <tom@tromey.com>
3448
3449         * tui/tui-regs.h (struct tui_data_item_window): Move from
3450         tui-data.h.
3451         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
3452         * tui/tui-data.h (struct tui_data_item_window): Move to
3453         tui-regs.h.
3454         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
3455
3456 2019-07-17  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui.c: Update.
3459         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
3460         (tui_cmd_window::max_height): Move to tui-command.c.
3461         * tui/tui-layout.c: Update.
3462         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
3463         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
3464         tui-command.c.
3465         * tui/tui-command.h (struct tui_cmd_window): Move from
3466         tui-data.h.
3467         * tui/tui-command.c: Remove "structuring" comments.
3468         (tui_cmd_window::clear_detail)
3469         (tui_cmd_window::do_make_visible_with_new_height)
3470         (tui_cmd_window::max_height): Move from elsewhere.
3471
3472 2019-07-17  Tom Tromey  <tom@tromey.com>
3473
3474         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
3475         Now static.
3476         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
3477         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
3478
3479 2019-07-17  Tom Tromey  <tom@tromey.com>
3480
3481         * tui/tui.c: Update.
3482         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
3483         tui-regs.c.
3484         * tui/tui-windata.h: Remove file.
3485         * tui/tui-windata.c: Remove file.
3486         * tui/tui-win.c (tui_data_window::set_new_height)
3487         (tui_data_window::do_make_visible_with_new_height): Move to
3488         tui-regs.c.
3489         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
3490         * tui/tui-regs.c: Remove "structuring" comments.
3491         (tui_data_window::first_data_item_displayed)
3492         (tui_data_window::delete_data_content_windows)
3493         (tui_data_window::erase_data_content)
3494         (tui_data_window::display_all_data)
3495         (tui_data_window::refresh_all)
3496         (tui_data_window::do_scroll_vertical)
3497         (tui_data_window::clear_detail, tui_data_window::set_new_height)
3498         (tui_data_window::do_make_visible_with_new_height)
3499         (tui_data_window::refresh_window): Move from elsewhere.
3500         (_initialize_tui_regs): Move to end of file.
3501         * tui/tui-layout.c: Update.
3502         * tui/tui-hooks.c: Update.
3503         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
3504         * tui/tui-data.c (tui_data_window::clear_detail): Move to
3505         tui-regs.c.
3506         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
3507
3508 2019-07-17  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
3511         seen.
3512
3513 2019-07-17  Tom Tromey  <tom@tromey.com>
3514
3515         * tui/tui-win.c (tui_source_window_base::set_new_height)
3516         (tui_source_window_base::do_make_visible_with_new_height): Use
3517         m_has_locator field directly.
3518         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
3519         method.
3520         (struct tui_source_window_base) <has_locator>: Likewise.
3521
3522 2019-07-17  Tom Tromey  <tom@tromey.com>
3523
3524         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
3525         Don't declare.
3526         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
3527         Remove.
3528         * tui/tui-win.c (tui_source_window_base::set_new_height)
3529         (tui_source_window_base::set_new_height)
3530         (make_invisible_and_set_new_height)
3531         (tui_source_window_base::do_make_visible_with_new_height)
3532         (tui_source_window_base::do_make_visible_with_new_height):
3533         Update.
3534         * tui/tui-layout.c (show_source_disasm_command, show_data)
3535         (show_source_or_disasm_and_command): Update.
3536         * tui/tui-layout.c (show_layout): Update.
3537
3538 2019-07-17  Tom Tromey  <tom@tromey.com>
3539
3540         * tui/tui-layout.c (make_data_window): Remove.
3541         (show_data): Unify creation and re-initialization cases.
3542
3543 2019-07-17  Tom Tromey  <tom@tromey.com>
3544
3545         * tui/tui-layout.c (make_source_window, make_disasm_window):
3546         Remove.
3547         (show_data): Unify creation and re-initialization cases.
3548
3549 2019-07-17  Tom Tromey  <tom@tromey.com>
3550
3551         * tui/tui-layout.c (make_command_window): Remove.
3552         (show_source_disasm_command, show_source_or_disasm_and_command):
3553         Unify creation and re-initialization cases.
3554
3555 2019-07-17  Tom Tromey  <tom@tromey.com>
3556
3557         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
3558         creation and re-initialization cases.
3559
3560 2019-07-17  Tom Tromey  <tom@tromey.com>
3561
3562         * tui/tui-regs.c (tui_get_register): Return void.
3563
3564 2019-07-17  Tom Tromey  <tom@tromey.com>
3565
3566         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
3567         Simplify.
3568
3569 2019-07-17  Tom Tromey  <tom@tromey.com>
3570
3571         * tui/tui-layout.c (show_source_disasm_command): Simplify window
3572         resetting.
3573
3574 2019-07-17  Tom Tromey  <tom@tromey.com>
3575
3576         * tui/tui.h (tui_set_layout_by_name): Don't declare.
3577         * tui/tui-regs.c (tui_reg_layout): New function.
3578         (tui_show_registers, tui_reg_command): Use it.
3579         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
3580         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
3581         parameters.
3582         (tui_layout_command): Remove.
3583
3584 2019-07-17  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-layout.h (tui/tui-layout): Return void.
3587         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
3588
3589 2019-07-17  Tom Tromey  <tom@tromey.com>
3590
3591         * tui/tui-layout.c (show_source_disasm_command, show_data):
3592         Update.
3593         (reset_locator): Remove.
3594         (show_source_or_disasm_and_command): Update.
3595
3596 2019-07-17  Tom Tromey  <tom@tromey.com>
3597
3598         * tui/tui-source.c (tui_source_window_base::reset): Remove
3599         win_type parameter.
3600         * tui/tui-layout.c (make_command_window, make_source_window)
3601         (make_disasm_window, make_data_window)
3602         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
3603         (reset_locator, show_source_or_disasm_and_command): Update.
3604         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
3605         win_type parameter.
3606         (struct tui_source_window_base) <reset>: Likewise.
3607
3608 2019-07-17  Tom Tromey  <tom@tromey.com>
3609
3610         * tui/tui-layout.c (show_source_disasm_command): Use
3611         reset_locator.
3612         (reset_locator): New function.
3613         (init_and_make_win): Remove.
3614         (show_source_or_disasm_and_command): Use reset_locator.
3615
3616 2019-07-17  Tom Tromey  <tom@tromey.com>
3617
3618         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
3619         condition.
3620         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
3621         Remove condition.
3622         * tui/tui-source.c (tui_source_window_base::reset): New method.
3623         * tui/tui-layout.c (make_command_window): Don't call
3624         init_and_make_win.
3625         (make_source_window, make_disasm_window): Don't call
3626         make_source_or_disasm_window.
3627         (make_data_window): Don't call init_and_make_win.  Change calling
3628         convention.
3629         (show_source_disasm_command, show_data): Simplify.
3630         (make_source_or_disasm_window): Remove.
3631         (show_source_or_disasm_and_command): Simplify.
3632         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
3633         (struct tui_source_window_base) <reset>: Likewise.
3634         <execution_info>: Remove initializer.
3635         * tui/tui-data.c (tui_source_window_base): Initialize
3636         execution_info.
3637
3638 2019-07-17  Tom Tromey  <tom@tromey.com>
3639
3640         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
3641         variable.
3642
3643 2019-07-17  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui.c (tui_rl_other_window): Update.
3646         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
3647         superclass method first.  Always iterate over regs_content.
3648         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
3649         method.
3650         * tui/tui-win.c (tui_set_focus_command): Update.
3651
3652 2019-07-17  Tom Tromey  <tom@tromey.com>
3653
3654         * tui/tui-win.c (tui_set_focus_command): Rename from
3655         tui_set_focus.  Call tui_enable.
3656         (tui_set_focus_command): Remove.
3657
3658 2019-07-17  Tom Tromey  <tom@tromey.com>
3659
3660         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
3661         refresh_window.
3662         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
3663         touchwin.
3664         (tui_data_window::refresh_window): Call refresh_window on data
3665         items.  Always call superclass refresh_window.
3666         (tui_win_info::refresh): Remove.
3667         (tui_source_window_base::refresh_window): Update.
3668         (tui_refresh_all): Update.
3669         * tui/tui-layout.c (show_source_disasm_command): Remove call to
3670         refresh_window.
3671         (show_source_or_disasm_and_command): Likewise.
3672         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
3673         (struct tui_source_window_base) <refresh>: Likewise.
3674
3675 2019-07-17  Tom Tromey  <tom@tromey.com>
3676
3677         * tui/tui-winsource.c (tui_clear_source_content)
3678         (tui_show_source_content): Update.
3679         * tui/tui-source.c (tui_source_window::showing_source_p): Check
3680         whether content is empty.
3681         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
3682         Remove.
3683
3684 2019-07-17  Tom Tromey  <tom@tromey.com>
3685
3686         * tui/tui-winsource.c (tui_erase_source_content): Clear the
3687         window's contents.
3688         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
3689         * tui/tui-source.c (tui_set_source_content_nil): Remove.
3690
3691 2019-07-17  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
3694         (struct tui_data_item_window): Update.
3695
3696 2019-07-17  Tom Tromey  <tom@tromey.com>
3697
3698         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
3699         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
3700         defines.
3701
3702 2019-07-17  Tom Tromey  <tom@tromey.com>
3703
3704         * tui/tui-winsource.h (tui_erase_source_content)
3705         (tui_clear_source_content): Remove "display_prompt" parameter.
3706         * tui/tui-winsource.c (tui_update_source_window_as_is)
3707         (tui_update_source_windows_with_addr): Update.
3708         (tui_clear_source_content): Remove "display_prompt" parameter.
3709         (tui_erase_source_content): Likewise.  Simplify.
3710         (tui_show_source_content): Update.
3711         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
3712         * tui/tui-stack.c (tui_show_frame_info): Update.
3713         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
3714         Remove defines.
3715
3716 2019-07-17  Tom Tromey  <tom@tromey.com>
3717
3718         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3719         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
3720         parameter.
3721         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
3722         parameter.
3723
3724 2019-07-17  Tom Tromey  <tom@tromey.com>
3725
3726         * tui/tui-winsource.c (tui_clear_source_content)
3727         (tui_show_source_content, tui_show_exec_info_content)
3728         (tui_clear_exec_info_content): Update.
3729         * tui/tui-stack.c (tui_show_locator_content): Update.
3730         (tui_show_frame_info): Update.
3731         * tui/tui-source.h (tui_source_window): Don't declare.
3732         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
3733         from tui_source_is_displayed.
3734         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
3735         Remove field.
3736         (struct tui_source_window_base) <content_in_use>: New field.  Now
3737         bool.
3738         (struct tui_source_window) <showing_source_p>: New method.
3739         (TUI_SRC_WIN): Change cast.
3740         * tui/tui-data.c (tui_initialize_static_data): Update.
3741
3742 2019-07-17  Tom Tromey  <tom@tromey.com>
3743
3744         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
3745         location_matches_p.
3746         * tui/tui-source.c (tui_source_window::location_matches_p): New
3747         method.
3748         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
3749         method.
3750         * tui/tui-data.h (struct tui_source_window_base)
3751         <location_matches_p>: New method.
3752         (struct tui_source_window, struct tui_disasm_window)
3753         <location_matches_p>: Likewise.
3754
3755 2019-07-17  Tom Tromey  <tom@tromey.com>
3756
3757         * tui/tui-win.c (tui_set_win_height_command): Rename from
3758         tui_set_win_height.
3759         (tui_set_win_height_command): Remove.
3760
3761 2019-07-17  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui-source.c (tui_source_window): New constructor.  Add
3764         observer.
3765         (~tui_source_window): New destructor.
3766         (tui_source_window::style_changed): New method.
3767         * tui/tui-hooks.c (tui_redisplay_source): Remove.
3768         (tui_attach_detach_observers): Update.
3769         * tui/tui-data.h (struct tui_source_window): Make constructor not
3770         inline.  Add destructor.
3771         (struct tui_source_window) <style_changed>: New method.
3772         <m_observable>: New member.
3773
3774 2019-07-17  Tom Tromey  <tom@tromey.com>
3775
3776         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
3777         * tui/tui-win.c (tui_resize_all): Fix typo.
3778
3779 2019-07-17  Tom Tromey  <tom@tromey.com>
3780
3781         * tui/tui-wingeneral.h (tui_refresh_all): Update.
3782         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
3783         (tui_refresh_all): Remove "list" parameter.  Use foreach.
3784         * tui/tui-win.c (window_name_completer): Use foreach.
3785         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
3786         (update_tab_width): Likewise.
3787         * tui/tui-layout.c (show_layout): Update.
3788         * tui/tui-data.h (class tui_window_iterator): New.
3789         (struct all_tui_windows): New.
3790         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
3791
3792 2019-07-17  Tom Tromey  <tom@tromey.com>
3793
3794         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
3795         parameter.  Don't reference globals.
3796         (tui_reg_command): Update.
3797
3798 2019-07-17  Tom Tromey  <tom@tromey.com>
3799
3800         * tui/tui-regs.c (tui_show_registers): Simplify.
3801
3802 2019-07-17  Tom Tromey  <tom@tromey.com>
3803
3804         * tui/tui-regs.c (tui_show_registers): Update.
3805         (tui_show_register_group): Add win_info parameter.
3806
3807 2019-07-17  Tom Tromey  <tom@tromey.com>
3808
3809         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
3810         Rename from tui_display_reg_element_at_line.
3811         (tui_data_window::display_registers_from_line): Update.
3812         * tui/tui-data.h (struct tui_data_window)
3813         <display_reg_element_at_line>: New method.
3814
3815 2019-07-17  Tom Tromey  <tom@tromey.com>
3816
3817         * tui/tui-regs.h (tui_display_registers_from)
3818         (tui_display_registers_from_line): Don't declare.
3819         * tui/tui-windata.c (tui_data_window::display_all_data)
3820         (tui_data_window::refresh_all)
3821         (tui_data_window::do_scroll_vertical): Update.
3822         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
3823         from tui_display_registers_from.
3824         (tui_display_reg_element_at_line): Update.
3825         (tui_data_window::display_registers_from_line): Rename from
3826         tui_display_registers_from_line.
3827         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
3828         display_registers_from_line>: New methods.
3829
3830 2019-07-17  Tom Tromey  <tom@tromey.com>
3831
3832         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
3833         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
3834         from tui_erase_data_content.
3835         (tui_data_window::display_all_data)
3836         (tui_data_window::refresh_all)
3837         (tui_data_window::do_scroll_vertical): Update.
3838         * tui/tui-regs.c (tui_show_registers): Update.
3839         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
3840         New method.
3841
3842 2019-07-17  Tom Tromey  <tom@tromey.com>
3843
3844         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
3845         declare.
3846         * tui/tui-windata.c
3847         (tui_data_window::delete_data_content_windows): Rename from
3848         tui_delete_data_content_windows.
3849         (tui_data_window::display_all_data)
3850         (tui_data_window::do_scroll_vertical): Update.
3851         * tui/tui-data.h (struct tui_data_window)
3852         <delete_data_content_windows>: New method.
3853
3854 2019-07-17  Tom Tromey  <tom@tromey.com>
3855
3856         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
3857         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
3858
3859 2019-07-17  Tom Tromey  <tom@tromey.com>
3860
3861         * tui/tui-windata.h (tui_display_all_data): Don't declare.
3862         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
3863         from tui_display_all_data.
3864         * tui/tui-win.c
3865         (tui_data_window::do_make_visible_with_new_height): Update.
3866         * tui/tui-regs.c (tui_show_registers): Update.
3867         * tui/tui-layout.c (tui_set_layout): Update.
3868         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
3869         method.
3870
3871 2019-07-17  Tom Tromey  <tom@tromey.com>
3872
3873         * tui/tui-windata.h (tui_display_data_from): Don't declare.
3874         * tui/tui-windata.c (tui_display_data_from): Remove.
3875         (tui_data_window::refresh_all): Update.
3876
3877 2019-07-17  Tom Tromey  <tom@tromey.com>
3878
3879         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
3880         * tui/tui-windata.c (tui_display_data_from_line): Remove.
3881         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
3882         tui_display_registers_from_line.
3883         * tui/tui-regs.h (tui_display_registers_from_line): Update.
3884         * tui/tui-regs.c (tui_display_registers_from_line): Remove
3885         "force_display" parameter.
3886
3887 2019-07-17  Tom Tromey  <tom@tromey.com>
3888
3889         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
3890         declare.
3891         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
3892         Rename from tui_first_reg_element_no_inline.
3893         (tui_display_reg_element_at_line)
3894         (tui_display_registers_from_line): Update.
3895         * tui/tui-data.h (struct tui_data_window)
3896         <first_reg_element_no_inline>: New method.
3897
3898 2019-07-17  Tom Tromey  <tom@tromey.com>
3899
3900         * tui/tui-windata.c (tui_display_data_from)
3901         (tui_data_window::do_scroll_vertical): Update.
3902         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
3903         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
3904         Rename from tui_line_from_reg_element_no.
3905         (tui_display_registers_from_line): Update.
3906         * tui/tui-data.h (struct tui_data_window)
3907         <line_from_reg_element_no>: New method.
3908
3909 2019-07-17  Tom Tromey  <tom@tromey.com>
3910
3911         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
3912         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
3913         tui_last_regs_line_no.
3914         (tui_display_reg_element_at_line)
3915         (tui_display_registers_from_line): Update.
3916         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
3917         method.
3918
3919 2019-07-17  Tom Tromey  <tom@tromey.com>
3920
3921         PR tui/24722:
3922         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
3923         (tui_update_breakpoint_info): Add "being_deleted" parameter.
3924         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
3925         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
3926         (tui_update_breakpoint_info): Likewise.
3927         * tui/tui-hooks.c (tui_event_create_breakpoint)
3928         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
3929         Update.
3930
3931 2019-07-17  Tom Tromey  <tom@tromey.com>
3932
3933         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
3934
3935 2019-07-17  Tom Tromey  <tom@tromey.com>
3936
3937         * tui/tui-winsource.c (tui_update_source_window_as_is)
3938         (tui_update_source_windows_with_addr): Update.
3939         * tui/tui-source.h (tui_set_source_content)
3940         (tui_show_symtab_source): Add "win_info" parameter.
3941         * tui/tui-source.c (tui_set_source_content): Add "win_info"
3942         parameter.
3943         (tui_show_symtab_source): Likewise.
3944
3945 2019-07-17  Tom Tromey  <tom@tromey.com>
3946
3947         * tui/tui-wingeneral.c
3948         (tui_check_and_display_highlight_if_needed): Check can_highlight.
3949
3950 2019-07-17  Tom Tromey  <tom@tromey.com>
3951
3952         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
3953         (struct tui_cmd_window) <can_scroll>: New method.
3954         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
3955         method.
3956
3957 2019-07-17  Tom Tromey  <tromey@adacore.com>
3958
3959         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
3960         do_field_signed>: Rename.  Change type of "value".
3961         * ui-out.c (ui_out::field_signed): Rename from field_int.
3962         Change type of "value".
3963         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
3964         type of "value".
3965         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
3966         do_field_int.  Change type of "value".
3967         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
3968         do_field_int.  Change type of "value".
3969         * tracepoint.c (trace_status_mi, tfind_1)
3970         (print_one_static_tracepoint_marker): Update.
3971         * thread.c (print_thread_info_1, print_selected_thread_frame):
3972         Update.
3973         * stack.c (print_frame, print_frame_info): Update.
3974         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
3975         Update.
3976         * source.c (print_source_lines_base): Update.
3977         * skip.c (info_skip_command): Update.
3978         * record-btrace.c (btrace_ui_out_decode_error)
3979         (btrace_call_history_src_line): Update.
3980         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
3981         Update.
3982         * progspace.c (print_program_space): Update.
3983         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
3984         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
3985         do_field_int.  Change type of "value".
3986         * mi/mi-out.c (mi_ui_out::do_table_begin)
3987         (mi_ui_out::do_table_header): Update.
3988         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
3989         type of "value".
3990         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
3991         (mi_cmd_data_list_changed_registers, output_register)
3992         (mi_cmd_data_read_memory, mi_load_progress)
3993         (mi_cmd_trace_frame_collected): Update.
3994         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
3995         Update.
3996         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
3997         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
3998         (mi_cmd_var_list_children, varobj_update_one): Update.
3999         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
4000         (mi_cmd_stack_list_args, list_arg_or_local): Update.
4001         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
4002         * inferior.c (print_inferior): Update.
4003         * gdb_bfd.c (print_one_bfd): Update.
4004         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4005         Update.
4006         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
4007         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
4008         do_field_int.  Change type of "value".
4009         * cli-out.c (cli_ui_out::do_field_signed): Rename from
4010         do_field_int.  Change type of "value".
4011         * breakpoint.c (watchpoint_check, print_breakpoint_location)
4012         (print_one_breakpoint_location, print_it_catch_fork)
4013         (print_one_catch_fork, print_it_catch_vfork)
4014         (print_one_catch_vfork, print_it_catch_solib)
4015         (print_it_catch_exec, print_it_ranged_breakpoint)
4016         (print_mention_watchpoint, print_mention_masked_watchpoint)
4017         (bkpt_print_it, update_static_tracepoint): Update.
4018         * break-catch-throw.c (print_it_exception_catchpoint): Update.
4019         * break-catch-syscall.c (print_it_catch_syscall): Update.
4020         * ada-tasks.c (print_ada_task_info): Update.
4021         * ada-lang.c (print_it_exception, print_mention_exception):
4022         Update.
4023
4024 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4025
4026         PR breakpoints/24541
4027         * gdbarch.c: Regenerate.
4028         * gdbarch.h: Regenerate.
4029         * gdbarch.sh: Adjust return type and parameter types for
4030         'stap_adjust_register'.
4031         (i386_stap_adjust_register): Adjust signature and return new
4032         register name.
4033         * stap-probe.c (stap_parse_register_operand): Adjust use of
4034         'gdbarch_stap_adjust_register'.
4035
4036 2019-07-17  Tom Tromey  <tromey@adacore.com>
4037
4038         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
4039         declare VEC.
4040         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
4041         std::vector.
4042         (struct s390_process_info): Add initializers.
4043         (s390_add_process): Use new.
4044         (s390_linux_nat_target::low_forget_process): Use delete.
4045         (s390_linux_nat_target::low_new_fork)
4046         (s390_linux_nat_target::stopped_by_watchpoint)
4047         (s390_linux_nat_target::low_prepare_to_resume)
4048         (s390_linux_nat_target::insert_watchpoint)
4049         (s390_linux_nat_target::insert_hw_breakpoint)
4050         (s390_linux_nat_target::remove_watchpoint)
4051         (s390_linux_nat_target::remove_hw_breakpoint): Update.
4052
4053 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4054
4055         * aarch64-fbsd-nat.c: Include regcache.h.
4056         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
4057         argument.
4058         (aarch64_fbsd_nat_target::fetch_registers)
4059         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
4060         variable.
4061         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
4062
4063 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
4064
4065         * fbsd-nat.c: Include gdbarch.h.
4066
4067 2019-07-15  Tom Tromey  <tromey@adacore.com>
4068
4069         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
4070
4071 2019-07-15  Tom Tromey  <tromey@adacore.com>
4072
4073         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
4074         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
4075         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
4076         * cli-out.c (cli_ui_out::do_field_int): New method.
4077         * ui-out.c (ui_out::field_unsigned): New method.
4078         * symfile.c (generic_load): Use field_unsigned.
4079         (print_transfer_performance): Likewise.
4080         * record-btrace.c (ui_out_field_uint): Remove.
4081         (btrace_call_history_insn_range, btrace_call_history): Use
4082         field_unsigned.
4083         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
4084         field_unsigned.
4085         * ui-out.h (class ui_out) <field_unsigned>: New method.
4086         <do_field_unsigned>: Likewise.
4087
4088 2019-07-15  Tom Tromey  <tromey@adacore.com>
4089
4090         * mi/mi-main.c (list_available_thread_groups): Use field_string.
4091         * mi/mi-interp.c (mi_memory_changed): Use field_string.
4092         * target.c (flash_erase_command): Use field_string.
4093         * infrun.c (print_signal_received_reason): Use field_string.
4094         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
4095         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
4096         field_string.
4097         * ada-tasks.c (print_ada_task_info): Use field_string.
4098
4099 2019-07-15  Tom Tromey  <tromey@adacore.com>
4100
4101         * target.c (flash_erase_command): Use field_core_addr.
4102         * symfile.c (generic_load): Use field_core_addr.
4103         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
4104         Use field_core_addr.
4105         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
4106         field_core_addr.
4107
4108 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4109
4110         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
4111         value if its desired type is smaller than a CORE_ADDR and signed.
4112
4113 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4114
4115         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
4116         of changes to field names, and use new is_reference field to
4117         decide if a property is a reference or not.
4118         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
4119         field.
4120         (struct dwarf2_property_baton): Update header comment, rename
4121         'referenced_type' to 'property_type' and update comments.
4122         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
4123         default property type, store in property baton, update to take
4124         accound of renamed field.
4125         (read_func_scope): Update call to attr_to_dynamic_prop.
4126         (read_array_type): Likewise.
4127         (dwarf2_per_cu_addr_sized_int_type): New function.
4128         (read_subrange_index_type): Move type finding code to
4129         dwarf2_per_cu_addr_sized_int_type.
4130         (read_subrange_type): Update calls to attr_to_dynamic_prop.
4131         (dwarf2_per_cu_addr_type): New function.
4132         (set_die_type): Update calls to attr_to_dynamic_prop.
4133
4134 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4135
4136         * dwarf2read.c (read_subrange_index_type): New function.
4137         (read_subrange_type): Move code into new function and call it.
4138         * gdbtypes.c (create_range_type): Add some asserts.
4139
4140 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4141
4142         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
4143         update return statements.
4144         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
4145         declaration, and update comment to match.
4146         * gdbtypes.c (resolve_dynamic_array): Update call to
4147         dwarf2_evaluate_property to match new return type.
4148
4149 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4150
4151         * valarith.c (value_subscripted_rvalue): Change lowerbound
4152         parameter type from int to LONGEST.
4153         * value.h (value_subscripted_rvalue): Likewise in declaration.
4154
4155 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4156
4157         * cli/cli-utils.c (info_print_command_completer): New function.
4158         * cli/cli-utils.h: Add 'completer.h' include, and forward
4159         declaration for 'struct cmd_list_element'.
4160         (info_print_command_completer): Declare.
4161         * stack.c (_initialize_stack): Add completer for 'info locals' and
4162         'info args'.
4163         * symtab.c (_initialize_symtab): Add completer for 'info
4164         variables' and 'info functions'.
4165         * NEWS: Mention completion for additional info commands.
4166
4167 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4168
4169         * cli/cli-utils.c (extract_info_print_args): Delete.
4170         (extract_arg_maybe_quoted): Delete.
4171         (info_print_options_defs): New variable.
4172         (make_info_print_options_def_group): New function.
4173         (extract_info_print_options): Define new function.
4174         * cli/cli-utils.h (extract_info_print_args): Delete.
4175         (struct info_print_options): New structure.
4176         (extract_info_print_options): Declare new function.
4177         * stack.c (info_locals_command): Update to use new
4178         extract_info_print_options, also add a header comment.
4179         (info_args_command): Likewise.
4180         * symtab.c (info_variables_command): Likewise.
4181         (info_functions_command): Likewise.
4182
4183 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
4184
4185         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
4186         to extract string arguments.
4187         * common/common-utils.c (extract_string_maybe_quoted): New function.
4188         * common/common-utils.h (extract_string_maybe_quoted): Declare.
4189
4190 2019-07-11  Tom Tromey  <tromey@adacore.com>
4191
4192         * main.c (get_init_files): Use GDBINIT, not gdbinit.
4193         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
4194         * top.h (gdbinit): Don't declare.
4195         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
4196         into...
4197         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
4198         * top.c (gdb_init): Don't call init_cli_cmds.
4199         (gdbinit): Remove.
4200         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
4201
4202 2019-07-11  Tom Tromey  <tromey@adacore.com>
4203
4204         * python/py-inferior.c (add_thread_object): Don't use thread_obj
4205         after it has been moved.
4206
4207 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4208
4209         * valops.c (value_must_coerce_to_target): Change return type to
4210         bool.
4211         * value.h (value_must_coerce_to_target): Likewise.
4212
4213 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
4214
4215         * breakpoint.c (is_hardware_watchpoint): Remove
4216         forward-declaration.
4217         (is_masked_watchpoint): Change return type to bool.
4218         (is_tracepoint): Likewise.
4219         (is_breakpoint): Likewise.
4220         (is_hardware_watchpoint): Likewise.
4221         (is_watchpoint): Likewise.
4222         (is_no_memory_software_watchpoint): Likewise.
4223         (is_catchpoint): Likewise.
4224         (breakpoint_1): Make FILTER parameter's return type bool.
4225         is_masked_watchpoint): Change return type to bool.
4226         (save_breakpoints): Make FILTER parameter's return type bool.
4227         * breakpoint.h (is_breakpoint): Change return type to bool.
4228         (is_watchpoint): Likewise.
4229         (is_catchpoint): Likewise.
4230         (is_tracepoint): Likewise.
4231
4232 2019-07-10  Tom Tromey  <tom@tromey.com>
4233
4234         * defs.h: Don't include gdbarch.h.
4235         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
4236         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
4237         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
4238         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
4239         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
4240         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
4241         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
4242         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
4243         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
4244         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
4245         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
4246         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
4247         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
4248         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
4249         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
4250         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
4251         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
4252         record-btrace.c, record.h, regcache-dump.c, regcache.h,
4253         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
4254         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
4255         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
4256         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
4257         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
4258         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
4259         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
4260         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
4261         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
4262
4263 2019-07-10  Tom Tromey  <tromey@adacore.com>
4264
4265         * ada-lang.h (is_ada_exception_catchpoint): Declare.
4266         * breakpoint.c (init_ada_exception_breakpoint): Register as
4267         bp_catchpoint.
4268         (print_one_breakpoint_location, print_one_breakpoint): Use
4269         is_ada_exception_catchpoint.
4270         * ada-lang.c (class ada_catchpoint_location): Pass
4271         bp_loc_software_breakpoint to bp_location constructor.
4272         (is_ada_exception_catchpoint): New function.
4273
4274 2019-07-10  Tom Tromey  <tromey@adacore.com>
4275
4276         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
4277         VEC.
4278         (struct arm_exidx_entry): New method operator<.
4279         (struct arm_exidx_data) <section_maps>: Change type.
4280         (arm_exidx_data_free): Remove.
4281         (arm_exidx_data_key): Change type.  Move lower.
4282         (arm_exidx_new_objfile): Update.
4283         (arm_compare_exidx_entries): Remove.
4284         (arm_find_exidx_entry, _initialize_arm_tdep)
4285
4286 2019-07-10  Tom Tromey  <tromey@adacore.com>
4287
4288         * solib-spu.c (ocl_program_data_key): Change type.
4289         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
4290         Update.
4291
4292 2019-07-10  Tom Tromey  <tromey@adacore.com>
4293
4294         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
4295         (struct solib_aix_inferior_data) <library_list>: Change type.
4296         (solib_aix_inferior_data_handle): Change type.
4297         (get_solib_aix_inferior_data): Update.
4298         (solib_aix_free_library_list): Remove.
4299         (library_list_start_library): Update.
4300         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
4301         return type.
4302         (solib_aix_get_library_list)
4303         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
4304         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
4305
4306 2019-07-10  Tom Tromey  <tromey@adacore.com>
4307
4308         * solib-dsbt.c (struct dsbt_info): Add initializers.
4309         (solib_dsbt_pspace_data): Change type.
4310         (dsbt_pspace_data_cleanup): Remove.
4311         (get_dsbt_info, _initialize_dsbt_solib): Update.
4312
4313 2019-07-10  Tom Tromey  <tromey@adacore.com>
4314
4315         * spu-tdep.c (spu_overlay_data): Change type.
4316         (spu_get_overlay_table, spu_overlay_new_objfile)
4317         (_initialize_spu_tdep): Update.
4318
4319 2019-07-10  Tom Tromey  <tromey@adacore.com>
4320
4321         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
4322         destructor.
4323         (dbx_objfile_data_key): Change type and declare later.
4324         (DBX_SYMFILE_INFO): Rewrite.
4325         * dbxread.c (dbx_objfile_data_key): Change type.
4326         (dbx_symfile_init): Update.
4327         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
4328         (coffstab_build_psymtabs, elfstab_build_psymtabs)
4329         (stabsect_build_psymtabs, _initialize_dbxread): Update.
4330
4331 2019-07-10  Tom Tromey  <tromey@adacore.com>
4332
4333         * jit.c (jit_program_space_key): Change type.  Move lower.
4334         (get_jit_program_space_data): Update.
4335         (jit_program_space_data_cleanup): Remove.
4336         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
4337         Update.
4338         (struct jit_program_space_data): Add initializers.
4339
4340 2019-07-10  Tom Tromey  <tromey@adacore.com>
4341
4342         * solib-darwin.c (struct darwin_info): Add initializers.
4343         (solib_darwin_pspace_data): Change type.
4344         (darwin_pspace_data_cleanup): Remove.
4345         (get_darwin_info, _initialize_darwin_solib): Update.
4346
4347 2019-07-10  Tom Tromey  <tromey@adacore.com>
4348
4349         * remote-sim.c (struct sim_inferior_data): Add initializers,
4350         constructor, and destructor.
4351         (sim_inferior_data_key): Change type.  Move lower.
4352         (check_for_duplicate_sim_descriptor): Update.
4353         (get_sim_inferior_data): Use new.  Update.
4354         (~sim_inferior_data_cleanup): Rename from
4355         sim_inferior_data_cleanup.  Simplify.
4356         (gdbsim_close_inferior, simulator_command)
4357         (sim_command_completer, _initialize_remote_sim): Update.
4358         (next_pid, INITIAL_PID): Move earlier.
4359
4360 2019-07-10  Tom Tromey  <tromey@adacore.com>
4361
4362         * python/python-internal.h (create_thread_object): Return
4363         gdbpy_ref.
4364         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
4365         * python/py-inferior.c (struct threadlist_entry): Add
4366         constructor.
4367         <thread_obj>: Now a gdbpy_ref.
4368         (thread_to_thread_object): Update.
4369         (add_thread_object): Use new.
4370         (delete_thread_object): Use delete.
4371         (infpy_threads): Update.
4372         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
4373         GIL.
4374
4375 2019-07-10  Tom Tromey  <tromey@adacore.com>
4376
4377         * valops.c (value_cast): Specialize error message for Ada.
4378
4379 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4380
4381         * breakpoint.c (breakpoint_1): Update doc and parameter names.
4382
4383 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
4384
4385         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
4386         bpstat_should_step): Return bool, adjust comments.
4387         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
4388         bpstat_should_step): Likewise.
4389
4390 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4391
4392         * features/Makefile: Use feature target descriptions for Arm.
4393         * features/arm/arm-core.c: Generate new file.
4394         * features/arm/arm-fpa.c: Likewise.
4395         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
4396         * features/arm/arm-m-profile.c: Likewise.
4397         * features/arm/arm-vfpv2.c: Likewise.
4398         * features/arm/arm-vfpv3.c: Likewise.
4399         * features/arm/xscale-iwmmxt.c: Likewise.
4400         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
4401
4402 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4403
4404         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
4405         ptrace earlier.
4406
4407 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
4408
4409         * features/aarch64-pauth.c: Regenerate.
4410
4411 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
4412
4413         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
4414         bool.
4415         (bpstat_what): Use false instead of 0.
4416
4417 2019-07-09  Pedro Alves  <palves@redhat.com>
4418
4419         * break-catch-throw.c (is_exception_catchpoint): New.
4420         * breakpoint.c (print_one_breakpoint_location): New parameter
4421         'raw_loc'.  Handle it.  Use
4422         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
4423         looking at the breakpoint's type.
4424         (print_one_breakpoint): If handling "maint info breakpoints", also
4425         print locations of exception catchpoints.
4426         * breakpoint.h (is_exception_catchpoint): Declare.
4427
4428 2019-07-09  Pedro Alves  <palves@redhat.com>
4429
4430         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
4431         "addr" field.
4432         (allocate_location_exception_catchpoint): New.
4433         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
4434         (initialize_throw_catchpoint_ops): Install
4435         allocate_location_exception_catchpoint as allocate_location
4436         method.
4437         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
4438         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
4439         bp_loc_other.
4440         (breakpoint_address_is_meaningful): Delete.
4441         (bl_address_is_meaningful): New.
4442         (breakpoint_locations_match): Adjust comment.
4443         (bp_location_from_bp_type): New, factored out of...
4444         (bp_location::bp_location(breakpoint *)): ... this.
4445         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
4446         factored out of...
4447         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
4448         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
4449         breakpoint_address_is_meaningful.
4450         (bp_locations_compare): Adjust comment.
4451         (update_global_location_list): Use bl_address_is_meaningful
4452         instead of breakpoint_address_is_meaningful.
4453         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
4454         explicit.
4455         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
4456         * python/py-breakpoint.c (bppy_get_location): No longer check
4457         whether location is null.
4458
4459 2019-07-09  Pedro Alves  <palves@redhat.com>
4460
4461         PR c++/15468
4462         * breakpoint.c (print_one_breakpoint_location): Remove
4463         single-location assert.
4464
4465 2019-07-09  Tom Tromey  <tom@tromey.com>
4466
4467         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
4468         * configure: Rebuild.
4469         * configure.ac: Change common to gdbsupport.
4470         * gdbsupport: Rename from common.
4471         * acinclude.m4: Change common to gdbsupport.
4472         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
4473         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
4474         gdbsupport.
4475         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
4476         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
4477         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
4478         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
4479         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
4480         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
4481         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
4482         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
4483         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
4484         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
4485         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
4486         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
4487         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
4488         coff-pe-read.c, command.h, compile/compile-c-support.c,
4489         compile/compile-c.h, compile/compile-cplus-symbols.c,
4490         compile/compile-cplus-types.c, compile/compile-cplus.h,
4491         compile/compile-loc2c.c, compile/compile.c, completer.c,
4492         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
4493         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
4494         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
4495         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
4496         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
4497         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
4498         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
4499         features/aarch64-core.c, features/aarch64-fpu.c,
4500         features/aarch64-pauth.c, features/aarch64-sve.c,
4501         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
4502         features/i386/32bit-core.c, features/i386/32bit-linux.c,
4503         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
4504         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
4505         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
4506         features/i386/64bit-core.c, features/i386/64bit-linux.c,
4507         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
4508         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
4509         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
4510         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
4511         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
4512         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
4513         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
4514         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
4515         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
4516         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
4517         go32-nat.c, guile/guile.c, guile/scm-ports.c,
4518         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
4519         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
4520         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
4521         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
4522         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
4523         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
4524         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
4525         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
4526         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
4527         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
4528         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
4529         minsyms.c, mips-linux-tdep.c, namespace.h,
4530         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
4531         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
4532         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
4533         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
4534         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
4535         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
4536         nat/linux-waitpid.c, nat/mips-linux-watch.c,
4537         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
4538         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
4539         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
4540         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
4541         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
4542         procfs.c, producer.c, progspace.h, psymtab.h,
4543         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
4544         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
4545         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
4546         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
4547         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
4548         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
4549         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
4550         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
4551         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
4552         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
4553         target-memory.c, target.c, target.h, target/waitstatus.c,
4554         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
4555         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
4556         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
4557         unittests/array-view-selftests.c,
4558         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
4559         unittests/common-utils-selftests.c,
4560         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
4561         unittests/format_pieces-selftests.c,
4562         unittests/function-view-selftests.c,
4563         unittests/lookup_name_info-selftests.c,
4564         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
4565         unittests/mkdir-recursive-selftests.c,
4566         unittests/observable-selftests.c,
4567         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
4568         unittests/parse-connection-spec-selftests.c,
4569         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
4570         unittests/scoped_fd-selftests.c,
4571         unittests/scoped_mmap-selftests.c,
4572         unittests/scoped_restore-selftests.c,
4573         unittests/string_view-selftests.c, unittests/style-selftests.c,
4574         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
4575         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
4576         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
4577         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
4578         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
4579         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
4580
4581 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4582
4583         * linespec.c (decode_digits_list_mode): Set explicit_line to a
4584         bool value.
4585         (decode_digits_ordinary): Set explicit_line field in sal.
4586         * symtab.c (skip_prologue_sal): Don't skip prologue for a
4587         symtab_and_line that was set on an explicit line number in
4588         assembler code.  Do always update the recorded symtab and line if
4589         we do skip the prologue.
4590
4591 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4592
4593         * breakpoint.c (set_breakpoint_location_function): Remove
4594         explicit_loc parameter.
4595         (momentary_breakpoint_from_master): Update call to
4596         set_breakpoint_location_function.
4597         (add_location_to_breakpoint): Likewise.
4598
4599 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
4600
4601         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
4602         required features based on default bfd type when no specific bfd
4603         is present.
4604
4605 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4606
4607         * NEWS: Mention that GDB printf and eval commands can now print
4608         C-style and Ada-style convenience var strings without
4609         calling the inferior.
4610         * printcmd.c (printf_c_string): Locally print GDB internal var
4611         instead of transiting via the inferior.
4612         (printf_wide_c_string): Likewise.
4613
4614 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4615
4616         PR breakpoints/25011
4617         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
4618
4619 2019-07-04  Tom Tromey  <tom@tromey.com>
4620
4621         PR tui/24724:
4622         * tui/tui-winsource.c (tui_clear_source_content): Update.
4623         (tui_source_window_base::set_is_exec_point_at): Fix comment.
4624         (tui_update_breakpoint_info): Update.
4625         (tui_set_exec_info_content): Update.
4626         * tui/tui-source.c (tui_set_source_content_nil): Update.
4627         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
4628         has_break.
4629         * tui/tui-data.h (enum tui_bp_flag): New.
4630         (tui_bp_flags): New enum flags type.
4631         (struct tui_source_element) <break_mode>: Change type.  Rename
4632         from has_break.
4633         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
4634         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
4635         constants.
4636         * tui/tui-winsource.h: Fix comment.
4637
4638 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4639
4640         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
4641         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
4642         (store_fpregs_to_thread)
4643         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4644         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
4645         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
4646         (IWMMXT_REGS_SIZE): Add define.
4647         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
4648         (fetch_vfp_regs, store_vfp_regs)
4649         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
4650         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
4651
4652 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4653
4654         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
4655         defines.
4656         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
4657         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
4658         (ARM_INT_REGISTER_SIZE): ...to this.
4659         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
4660         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
4661         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
4662         (arm_linux_collect_gregset, supply_nwfpe_register)
4663         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
4664         defines.
4665         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
4666         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
4667         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
4668         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
4669         (arm_return_in_memory, arm_store_return_value)
4670         (arm_get_longjmp_target, arm_register_g_packet_guesses)
4671         (arm_record_ld_st_multiple): Likewise.
4672         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
4673         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
4674
4675 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4676
4677         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
4678         AARCH64_DISPLACED_MODIFIED_INSNS.
4679         * aarch64-tdep.c (struct aarch64_displaced_step_data)
4680         (aarch64_displaced_step_copy_insn): Likewise.
4681         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4682         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
4683         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
4684         ARM_DISPLACED_MODIFIED_INSNS.
4685         * arm-tdep.c (arm_gdbarch_init): Likewise.
4686         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
4687         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
4688         (struct arm_displaced_step_closure): Use
4689         ARM_DISPLACED_MODIFIED_INSNS.
4690
4691 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4692
4693         * features/Makefile: Remove unused xml files.
4694         * features/aarch64.xml: Remove.
4695         * features/i386/amd64-avx-avx512-linux.xml: Remove.
4696         * features/i386/amd64-avx-avx512.xml: Remove.
4697         * features/i386/amd64-avx-linux.xml: Remove.
4698         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
4699         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
4700         * features/i386/amd64-avx-mpx-linux.xml: Remove.
4701         * features/i386/amd64-avx-mpx.xml: Remove.
4702         * features/i386/amd64-avx.xml: Remove.
4703         * features/i386/amd64-linux.xml: Remove.
4704         * features/i386/amd64-mpx-linux.xml: Remove.
4705         * features/i386/amd64-mpx.xml: Remove.
4706         * features/i386/amd64.xml: Remove.
4707         * features/i386/i386-avx-avx512-linux.xml: Remove.
4708         * features/i386/i386-avx-avx512.xml: Remove.
4709         * features/i386/i386-avx-linux.xml: Remove.
4710         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
4711         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
4712         * features/i386/i386-avx-mpx-linux.xml: Remove.
4713         * features/i386/i386-avx-mpx.xml: Remove.
4714         * features/i386/i386-avx.xml: Remove.
4715         * features/i386/i386-linux.xml: Remove.
4716         * features/i386/i386-mmx-linux.xml: Remove.
4717         * features/i386/i386-mmx.xml: Remove.
4718         * features/i386/i386-mpx-linux.xml: Remove.
4719         * features/i386/i386-mpx.xml: Remove.
4720         * features/i386/i386.xml: Remove.
4721         * features/i386/x32-avx-avx512-linux.xml: Remove.
4722         * features/i386/x32-avx-linux.xml: Remove.
4723         * features/i386/x32-linux.xml: Remove.
4724
4725 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4726
4727         * regformats/aarch64.dat: Remove.
4728         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
4729         * regformats/i386/amd64-avx-linux.dat: Remove.
4730         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
4731         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
4732         * regformats/i386/amd64-linux.dat: Remove.
4733         * regformats/i386/amd64-mpx-linux.dat: Remove.
4734         * regformats/i386/amd64.dat: Remove.
4735         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
4736         * regformats/i386/i386-avx-linux.dat: Remove.
4737         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
4738         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
4739         * regformats/i386/i386-linux.dat: Remove.
4740         * regformats/i386/i386-mmx-linux.dat: Remove.
4741         * regformats/i386/i386-mpx-linux.dat: Remove.
4742         * regformats/i386/i386.dat: Remove.
4743         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
4744         * regformats/i386/x32-avx-linux.dat: Remove.
4745         * regformats/i386/x32-linux.dat: Remove.
4746
4747 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
4748
4749         * aarch64-tdep.c: Remove xml self tests.
4750         * amd64-linux-tdep.c: Likewise.
4751         * amd64-tdep.c: Likewise.
4752         * i386-linux-tdep.c: Likewise.
4753         * i386-tdep.c: Likewise.
4754
4755 2019-07-03  Pedro Alves  <palves@redhat.com>
4756
4757         PR cli/24732
4758         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
4759         (pipe_cmd_option_defs): New.
4760         (make_pipe_cmd_options_def_group): New.
4761         (pipe_command): Use gdb::option::process_options.
4762         (pipe_command_completer): New function.
4763         (_initialize_cli_cmds): Install completer for "pipe" command.
4764
4765 2019-07-03  Pedro Alves  <palves@redhat.com>
4766
4767         * cli/cli-option.c (union option_value) <string>: New field.
4768         (struct option_def_and_value): Add ctor, move ctor, dtor and
4769         use DISABLE_COPY_AND_ASSIGN.
4770         (option_def_and_value::clear_value): New.
4771         (parse_option, save_option_value_in_ctx, get_val_type_str)
4772         (add_setshow_cmds_for_options): Handle var_string.
4773         * cli-option.h (union option_def::var_address) <string>: New
4774         field.
4775         (struct string_option_def): New.
4776         * maint-test-options.c (struct test_options_opts): Add default
4777         ctor and use DISABLE_COPY_AND_ASSIGN.
4778         <string_opt>: New field.
4779         (test_options_opts::~test_options_opts): New.
4780         (test_options_opts::dump): Also dump "-string".
4781         (test_options_option_defs): Install "string.
4782
4783 2019-07-03  Pedro Alves  <palves@redhat.com>
4784
4785         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
4786         option_value with a null enumeration.
4787         (complete_options): Save the option values in the context.
4788         (save_option_value_in_ctx): New, factored out from ...
4789         (process_options): ... here.
4790         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
4791         of the function.
4792         * maint-test-options.c (test_options_opts::dump): New, factored
4793         out from ...
4794         (maintenance_test_options_command_mode): ... here.
4795         (maintenance_test_options_command_completion_result): Delete.
4796         (maintenance_test_options_command_completion_text): Update
4797         comment.
4798         (maintenance_show_test_options_completion_result): Change
4799         prototype.  Just print
4800         maintenance_test_options_command_completion_text.
4801         (save_completion_result): New.
4802         (maintenance_test_options_completer_mode): Pass options context to
4803         complete_options, and then save a dump.
4804         (_initialize_maint_test_options): Use add_cmd to install "maint
4805         show test-options-completion-result".
4806
4807 2019-07-03  Pedro Alves  <palves@redhat.com>
4808
4809         * NEWS (New commands): Mention "with" and "maint with".
4810         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
4811         (with_command, with_command_completer): New.
4812         (pipe_command): Adjust to new repeat_previous
4813         interface.
4814         (_initialize_cli_cmds): Install the "with" command and its "w"
4815         alias.
4816         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
4817         declarations.
4818         * cli/cli-setshow.c (parse_cli_var_uinteger)
4819         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
4820         argument strings for all var_types.
4821         (get_setshow_command_value_string): New, factored out from ...
4822         (do_show_command): ... this.
4823         * cli/cli-setshow.h: Include <string>.
4824         (get_setshow_command_value_string): Declare.
4825         * command.h (repeat_previous): Now returns const char *.  Adjust
4826         comment.
4827         * maint.c: Include "cli/cli-cmds.h".
4828         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
4829         (_initialize_maint_cmds): Register the "maintenance with" command.
4830         * top.c (repeat_previous): Move bits from pipe_command here:
4831         Return the saved command line, if any; error out if there's no
4832         command to relaunch.
4833
4834 2019-07-03  Pedro Alves  <palves@redhat.com>
4835
4836         * NEWS (New commands): Mention "maint set/show test-settings"
4837         instead of "maint test-settings".
4838         * maint-test-settings.c (maintenance_test_settings_list): Delete.
4839         (maintenance_test_settings_set_list): Rename to ...
4840         (maintenance_set_test_settings_list): ... this.
4841         (maintenance_test_settings_show_list): Rename to  ...
4842         (maintenance_show_test_settings_list): ... this.
4843         (maintenance_test_settings_cmd): Delete.
4844         (maintenance_test_settings_set_cmd): ...
4845         (maintenance_set_test_settings_cmd): ... this.
4846         (maintenance_test_settings_show_cmd): ...
4847         (maintenance_show_test_settings_cmd): ... this.
4848         (maintenance_test_settings_show_value_cmd):
4849         (maintenance_show_test_settings_value_cmd): ... this.
4850         (_initialize_maint_test_settings): No longer install the "maint
4851         test-settings" prefix command.  Rename "maint test-settings set"
4852         to "maint set test-settings", and "maint test-settings show" to
4853         "maint show test-settings".  Adjust all subcommands.
4854
4855 2019-07-03  Pedro Alves  <palves@redhat.com>
4856
4857         * maint-test-settings.c: Fix file's intro comment.  Replace all
4858         references to "test-options" with references to "test-settings",
4859         in comments.
4860
4861 2019-07-03  Pedro Alves  <palves@redhat.com>
4862
4863         * maint-test-settings.c (maintenance_test_settings_xxx)
4864         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
4865         New.
4866         (maintenance_test_settings_enums): Use them.
4867         (maintenance_test_settings_enum): Default to
4868         maintenance_test_settings_xxx.
4869         (_initialize_maint_test_settings): Initialize
4870         MAINTENANCE_TEST_SETTINGS_FILENAME.
4871
4872 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4873
4874         * breakpoint.h (remove_breakpoints_inf): Change return type to
4875         void, move function documentation here.
4876         * breakpoint.c (remove_breakpoints_inf): Change return type to
4877         void, move function documentation to header.
4878
4879 2019-07-02  Pedro Alves  <palves@redhat.com>
4880
4881         * NEWS (Completion improvements): Mention "info threads".
4882         * thread.c (struct info_threads_opts, info_threads_option_defs)
4883         (make_info_threads_options_def_group): New.
4884         (info_threads_command): Use gdb::option::process_options.
4885         (info_threads_command_completer): New.
4886         (_initialize_thread): Use gdb::option::build_help to build the
4887         help text for "info threads".
4888
4889 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
4890
4891         * defs.h (generic_load): Move from here...
4892         * symfile.h (generic_load): ... to here.  Rename name parameter
4893         to args.
4894         * symfile.c (generic_load): Add comment.
4895
4896 2019-07-01  Tom Tromey  <tromey@adacore.com>
4897
4898         * dwarf2read.c
4899         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
4900         declaration of without_params.  Fix formatting.
4901
4902 2019-07-01  Tom Tromey  <tromey@adacore.com>
4903
4904         * ada-exp.y (find_primitive_type): Update.
4905         * ada-lang.h (ada_lookup_symbol): Update.
4906         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
4907         parameter.
4908         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
4909
4910 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4911
4912         PR breakpoints/24541
4913         * gdbarch.c: Regenerate.
4914         * gdbarch.h: Regenerate.
4915         * gdbarch.sh: Add 'stap_adjust_register'.
4916         * i386-tdep.c: Include '<unordered_set>'.
4917         (i386_stap_adjust_register): New function.
4918         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
4919         * stap-probe.c (stap_parse_register_operand): Call
4920         'gdbarch_stap_adjust_register'.
4921
4922 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
4923
4924         PR python/24742
4925         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
4926         * python/python.c (do_start_initialization): Use 'xmalloc'
4927         instead of 'PyMem_Malloc'.
4928
4929 2019-06-28  Tom Tromey  <tromey@adacore.com>
4930
4931         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
4932         for Ada.
4933
4934 2019-06-27  Tom Tromey  <tromey@adacore.com>
4935
4936         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
4937         objfile_key.
4938         (arm_find_mapping_symbol, arm_record_special_symbol)
4939         (_initialize_arm_tdep): Update.
4940         (arm_objfile_data_free): Remove.
4941
4942 2019-06-27  Tom Tromey  <tromey@adacore.com>
4943
4944         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
4945         to cp_print_static_field.
4946
4947 2019-06-26  Tom Tromey  <tromey@adacore.com>
4948
4949         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
4950         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
4951         declare.
4952
4953 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4954
4955         * features/aarch64-core.c (create_feature_aarch64_core):
4956         Regenerate.
4957         * features/aarch64-core.xml: Add cpsr flags.
4958
4959 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
4960
4961         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
4962         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
4963
4964 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4965
4966         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
4967         field.
4968         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
4969         use.
4970         (arm_record_special_symbol): Don't insert new symbol in sorted
4971         position, push it at the end.
4972
4973 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
4974
4975         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
4976         (arm_mapping_symbol_s): Remove.
4977         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
4978         (arm_mapping_symbol_vec): New typedef.
4979         (struct arm_per_objfile): Add constructor.
4980         <section_maps>: Change type to
4981         std::unique_ptr<arm_mapping_symbol_vec[]>.
4982         (arm_compare_mapping_symbols): Remove.
4983         (arm_find_mapping_symbol): Adjust to section_maps type change.
4984         (arm_objfile_data_free): Call delete on arm_per_objfile.
4985         (arm_record_special_symbol): Adjust to section_maps type change.
4986         Allocate arm_per_objfile with new.
4987
4988 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4989
4990         * cli/cli-cmds.c (alias_command): Compare the alias prefix
4991         with the command prefix.
4992
4993 2019-06-25  Tom Tromey  <tom@tromey.com>
4994
4995         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
4996         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
4997
4998 2019-06-25  Tom Tromey  <tom@tromey.com>
4999
5000         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
5001         type.
5002         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
5003         protected.
5004
5005 2019-06-25  Tom Tromey  <tom@tromey.com>
5006
5007         * tui/tui-winsource.c
5008         (tui_source_window_base::set_is_exec_point_at): Add check against
5009         LOA_ADDRESS.
5010
5011 2019-06-25  Tom Tromey  <tom@tromey.com>
5012
5013         * tui/tui-source.c (tui_set_source_content): Don't check before
5014         xfree.
5015         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
5016
5017 2019-06-25  Tom Tromey  <tom@tromey.com>
5018
5019         * tui/tui-winsource.h (tui_update_source_window_as_is)
5020         (tui_alloc_source_buffer, tui_line_is_displayed)
5021         (tui_addr_is_displayed): Change type of win_info.
5022         * tui/tui-winsource.c (tui_update_source_window_as_is)
5023         (tui_clear_source_content, tui_show_source_line)
5024         (tui_show_source_content, tui_source_window_base::refill)
5025         (tui_source_window_base::set_is_exec_point_at)
5026         (tui_source_window_base::set_is_exec_point_at)
5027         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
5028         (tui_alloc_source_buffer, tui_line_is_displayed)
5029         (tui_addr_is_displayed): Change type of win_info.  Update.
5030         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5031         (tui_source_window_base::do_make_visible_with_new_height):
5032         Update.
5033         * tui/tui-source.c (tui_set_source_content)
5034         (tui_set_source_content_nil)
5035         (tui_source_window::do_scroll_vertical): Update.
5036         * tui/tui-layout.c (show_layout): Update.
5037         * tui/tui-disasm.c (tui_set_disassem_content)
5038         (tui_disasm_window::do_scroll_vertical): Update.
5039         * tui/tui-data.h (tui_win_content): Remove.
5040         (struct tui_gen_win_info) <content, content_size>: Remove.
5041         (struct tui_source_element): Add initializers and destructor.
5042         (union tui_which_element, struct tui_win_element): Remove.
5043         (struct tui_source_window_base) <content>: New field.
5044         (struct tui_data_window): Remove destructor.
5045         (tui_alloc_content, tui_free_win_content)
5046         (tui_free_all_source_wins_content): Don't declare.
5047         * tui/tui-data.c (tui_initialize_static_data): Update.
5048         (init_content_element, tui_alloc_content): Remove.
5049         (~tui_gen_win_info): Update.
5050         (~tui_data_window, tui_free_all_source_wins_content)
5051         (tui_free_win_content, free_content, free_content_elements):
5052         Remove.
5053
5054 2019-06-25  Tom Tromey  <tom@tromey.com>
5055
5056         * tui/tui-winsource.h (tui_clear_source_content)
5057         (tui_erase_source_content, tui_show_source_content): Change type
5058         of win_info.
5059         * tui/tui-winsource.c (tui_clear_source_content)
5060         (tui_erase_source_content, tui_show_source_content): Change type
5061         of win_info.
5062         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5063         * tui/tui-source.h (tui_set_source_content_nil): Change type of
5064         win_info.
5065         * tui/tui-source.c (tui_set_source_content_nil): Change type of
5066         win_info.
5067         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
5068
5069 2019-06-25  Tom Tromey  <tom@tromey.com>
5070
5071         * tui/tui-winsource.c (tui_clear_source_content)
5072         (tui_source_window_base::set_is_exec_point_at): Update.
5073         * tui/tui-source.c (tui_set_source_content_nil): Update.
5074         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
5075         a bool.
5076         * tui/tui-data.c (init_content_element): Update.
5077
5078 2019-06-25  Tom Tromey  <tom@tromey.com>
5079
5080         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
5081         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
5082         * tui/tui-layout.c (init_and_make_win): Update.
5083         * tui/tui.h (enum tui_win_type): Update.
5084         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
5085         tui_win_is_auxillary.
5086         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
5087         tui_win_is_auxillary.
5088
5089 2019-06-25  Tom Tromey  <tom@tromey.com>
5090
5091         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
5092         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
5093         (tui_delete_data_content_windows, tui_display_all_data)
5094         (tui_data_window::do_scroll_vertical, tui_display_data_from):
5095         Update.
5096         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
5097         * tui/tui-regs.c (tui_last_regs_line_no)
5098         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5099         (tui_show_registers): Update.
5100         (tui_show_register_group): Return void.  Update.
5101         (tui_display_registers_from, tui_display_reg_element_at_line)
5102         (tui_display_registers_from_line, tui_check_register_values):
5103         Update.
5104         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
5105         member.
5106         (struct tui_data_window) <regs_content>: Now a std::vector.
5107         <regs_content_count>: Remove.
5108         (tui_add_content_elements, tui_free_data_content): Don't declare.
5109         * tui/tui-data.c (tui_data_window::clear_detail): Update.
5110         (init_content_element): Remove DATA_WIN case.  Add assert.
5111         (tui_add_content_elements): Remove.
5112         (tui_data_window): Update.
5113         (tui_free_data_content): Remove.
5114         (free_content_elements): Remove DATA_WIN case.
5115
5116 2019-06-25  Tom Tromey  <tom@tromey.com>
5117
5118         * tui/tui-data.c (tui_data_item_window): Update.
5119         * tui/tui-windata.h (tui_check_data_values): Don't declare.
5120         * tui/tui-windata.c (tui_display_all_data)
5121         (tui_display_data_from_line): Update.
5122         (tui_check_data_values): Remove.
5123         * tui/tui-regs.c (tui_show_register_group)
5124         (tui_display_reg_element_at_line): Update.
5125         * tui/tui-hooks.c (tui_register_changed)
5126         (tui_refresh_frame_and_register_information): Call
5127         tui_check_register_values.
5128         * tui/tui-data.h (struct tui_data_window) <data_content,
5129         data_content_count, data_type>: Remove.
5130         (enum tui_data_type): Remove.
5131
5132         * tui/tui-data.c (tui_data_window::clear_detail)
5133         (~tui_data_window): Update.
5134
5135 2019-06-25  Tom Tromey  <tom@tromey.com>
5136
5137         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
5138         declare.
5139         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
5140         Rename from tui_first_data_item_displayed.  Update.
5141         (tui_data_window::refresh_all)
5142         (tui_data_window::do_scroll_vertical): Update.
5143         * tui/tui-data.h (struct tui_data_window)
5144         <first_data_item_displayed>: Declare new method.
5145
5146 2019-06-25  Tom Tromey  <tom@tromey.com>
5147
5148         * tui/tui-data.h (tui_init_generic_part): Don't declare.
5149         * tui/tui-data.c (tui_init_generic_part): Remove, moving
5150         contents...
5151         (tui_initialize_static_data): ...here.
5152
5153 2019-06-25  Tom Tromey  <tom@tromey.com>
5154
5155         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5156         (tui_display_registers_from, tui_check_register_values): Update.
5157         (tui_display_register): Remove win_info parameter; update.
5158         (tui_get_register): Change type of parameters.
5159         * tui/tui-data.h (struct tui_data_element): Remove.
5160         (union tui_which_element) <data>: Remove.
5161         <data_window>: Change type.
5162         (struct tui_data_item_window): New.
5163         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
5164         case.  Add assert.
5165         (~tui_data_item_window): New destructor.
5166         (free_content_elements): Remove DATA_ITEM_WIN case.
5167
5168 2019-06-25  Tom Tromey  <tom@tromey.com>
5169
5170         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
5171         Remove.
5172
5173 2019-06-25  Tom Tromey  <tom@tromey.com>
5174
5175         * tui/tui-data.h (struct tui_command_element): Remove.
5176         (union tui_which_element) <command>: Remove.
5177         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
5178         assert.
5179         (free_content_elements): Remove CMD_WIN case.
5180
5181 2019-06-25  Tom Tromey  <tom@tromey.com>
5182
5183         * tui/tui-layout.c (tui_set_layout): Update.
5184         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
5185         * tui/tui-data.c (layout_def): Update.
5186
5187 2019-06-25  Tom Tromey  <tom@tromey.com>
5188
5189         * tui/tui-wingeneral.c (tui_refresh_all): Update.
5190         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5191         (tui_source_window_base::set_new_height): Update.
5192         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
5193         Update.
5194         (tui_set_locator_fullname, tui_set_locator_info)
5195         (tui_show_frame_info): Update.
5196         * tui/tui-source.c (tui_set_source_content)
5197         (tui_source_is_displayed): Update.
5198         * tui/tui-layout.c (show_source_disasm_command, show_data)
5199         (show_source_or_disasm_and_command): Update.
5200         * tui/tui-disasm.c (tui_set_disassem_content)
5201         (tui_get_begin_asm_address): Update.
5202         * tui/tui-data.h (struct tui_locator_element): Remove.
5203         (union tui_which_element) <locator>: Remove.
5204         (struct tui_locator_window): New.
5205         (tui_locator_win_info_ptr): Change return type.
5206         * tui/tui-data.c (_locator): Change type.
5207         (tui_locator_win_info_ptr): Change return type.
5208         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
5209         (tui_alloc_content): Add assert.
5210
5211 2019-06-25  Tom Tromey  <tom@tromey.com>
5212
5213         * tui/tui-winsource.c
5214         (tui_exec_info_window::maybe_allocate_content): New method.
5215         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
5216         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
5217         (make_source_or_disasm_window): Add cast.
5218         * tui/tui-data.h (union tui_which_element) <simple_string>:
5219         Remove.
5220         (struct tui_source_info): New.
5221         (struct tui_source_window_base) <execution_info>: Change type.
5222         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
5223         case, and add assert.
5224         (tui_alloc_content): Add assert.
5225
5226 2019-06-25  Tom Tromey  <tom@tromey.com>
5227
5228         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
5229         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
5230         * tui/tui-data.c (tui_alloc_win_info): Remove.
5231
5232 2019-06-25  Tom Tromey  <tom@tromey.com>
5233
5234         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
5235         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
5236         can_highlight.
5237
5238 2019-06-25  Tom Tromey  <tom@tromey.com>
5239
5240         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
5241         make_visible_with_new_height method.
5242         (tui_win_info::make_visible_with_new_height): New method.
5243         (tui_source_window_base::do_make_visible_with_new_height)
5244         (tui_data_window::do_make_visible_with_new_height)
5245         (tui_cmd_window::do_make_visible_with_new_height): New methods.
5246         (make_visible_with_new_height): Remove.
5247         (tui_resize_all, tui_adjust_win_heights): Use
5248         make_visible_with_new_height method.
5249         * tui/tui-data.h (struct tui_win_info)
5250         <do_make_visible_with_new_height, make_visible_with_new_height>:
5251         New methods.
5252         (struct tui_source_window_base, struct tui_data_window)
5253         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
5254         methods.
5255
5256 2019-06-25  Tom Tromey  <tom@tromey.com>
5257
5258         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
5259         method.
5260         (update_tab_width): Call update_tab_width method.
5261         * tui/tui-data.h (struct tui_win_info)
5262         (struct tui_source_window_base) <update_tab_width>: New methods.
5263
5264 2019-06-25  Tom Tromey  <tom@tromey.com>
5265
5266         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
5267         parameter.
5268         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
5269         parameter.
5270         (tui_gen_win_info::make_visible): Update.
5271         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
5272         parameter.
5273         * tui/tui-data.h (enum tui_box): New enum.
5274         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
5275
5276 2019-06-25  Tom Tromey  <tom@tromey.com>
5277
5278         * tui/tui-layout.c (make_source_or_disasm_window): Always use
5279         init_and_make_win for EXEC_INFO_WIN.
5280         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
5281         longer inline.
5282         (struct tui_win_info) <~tui_win_info>: Inline.
5283         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5284         Don't declare.
5285         * tui/tui-data.c (source_win, disasm_win): Remove globals.
5286         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5287         Remove.
5288         (tui_initialize_static_data): Update.
5289         (~tui_gen_win_info): Handle more cleanup here.
5290         (~tui_source_window_base): Delete "execution_info".
5291         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
5292
5293 2019-06-25  Tom Tromey  <tom@tromey.com>
5294
5295         * tui/tui-layout.c (make_command_window): Don't set
5296         can_highlight.
5297         (show_source_disasm_command): Call the reset method.
5298         (show_data): Don't set can_highlight.  Call the reset method.
5299         (tui_gen_win_info::reset): Rename from init_gen_win_info
5300         (init_and_make_win): Simplify.  Return tui_gen_win_info.
5301         (show_source_or_disasm_and_command): Call the reset method.
5302         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
5303         (struct tui_cmd_window): Set can_highlight.
5304
5305 2019-06-25  Tom Tromey  <tom@tromey.com>
5306
5307         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
5308         from make_visible.
5309         (tui_make_visible, tui_make_invisible): Rewrite.
5310         (tui_win_info::make_visible): Remove.
5311         (tui_source_window_base::make_visible): Update.
5312         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
5313         method.  Moved from...
5314         (struct tui_win_info) <make_visible>: ...here.
5315
5316 2019-06-25  Tom Tromey  <tom@tromey.com>
5317
5318         * tui/tui-winsource.c
5319         (tui_source_window_base::do_scroll_horizontal): Remove direction
5320         parameter.
5321         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
5322         direction parameter.
5323         * tui/tui-win.c (tui_win_info::forward_scroll)
5324         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5325         (tui_win_info::right_scroll): Update.
5326         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
5327         direction parameter.
5328         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
5329         direction parameter.
5330         * tui/tui-data.h (enum tui_scroll_direction): Remove.
5331         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
5332         Remove direction parameter.
5333         (struct tui_source_window_base, struct tui_source_window)
5334         (struct tui_disasm_window, struct tui_data_window)
5335         (struct tui_cmd_window): Update.
5336
5337 2019-06-25  Tom Tromey  <tom@tromey.com>
5338
5339         * tui/tui-winsource.h (tui_set_exec_info_content)
5340         (tui_show_exec_info_content, tui_erase_exec_info_content)
5341         (tui_clear_exec_info_content, tui_update_exec_info): Change
5342         argument to tui_source_window_base.
5343         * tui/tui-winsource.c (tui_set_exec_info_content)
5344         (tui_show_exec_info_content, tui_erase_exec_info_content)
5345         (tui_clear_exec_info_content, tui_update_exec_info): Change
5346         argument to tui_source_window_base.
5347
5348 2019-06-25  Tom Tromey  <tom@tromey.com>
5349
5350         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
5351         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
5352
5353 2019-06-25  Tom Tromey  <tom@tromey.com>
5354
5355         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
5356         check.
5357
5358 2019-06-25  Tom Tromey  <tom@tromey.com>
5359
5360         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
5361         type to void.
5362         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
5363         type to void.
5364         * tui/tui-source.c (tui_set_source_content): Update.
5365         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5366
5367 2019-06-25  Tom Tromey  <tom@tromey.com>
5368
5369         * tui/tui-win.c (window_name_completer, tui_set_focus)
5370         (tui_all_windows_info): Use name method.
5371         * tui/tui-data.h (struct tui_gen_win_info)
5372         (struct tui_source_window, struct tui_disasm_window)
5373         (struct tui_data_window, struct tui_cmd_window) <name>: New
5374         method.
5375         (tui_win_name): Don't declare.
5376         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
5377         (tui_win_name): Remove.
5378
5379 2019-06-25  Tom Tromey  <tom@tromey.com>
5380
5381         * tui/tui-winsource.h (tui_update_source_window)
5382         (tui_update_source_window_as_is): Change parameter type.
5383         * tui/tui-winsource.c (tui_update_source_window): Change win_info
5384         to be a tui_source_window_base.
5385         (tui_update_source_window_as_is): Likewise.
5386         * tui/tui-win.c (make_visible_with_new_height): Update.
5387
5388 2019-06-25  Tom Tromey  <tom@tromey.com>
5389
5390         * tui/tui-winsource.c (tui_erase_source_content)
5391         (tui_show_source_content, tui_show_exec_info_content)
5392         (tui_erase_exec_info_content): Use refresh_window method.
5393         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
5394         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
5395         from tui_refresh_win.
5396         (tui_data_window::refresh_window): New method.
5397         (tui_win_info::refresh, tui_source_window_base::refresh)
5398         (tui_refresh_all): Use refresh_window method.
5399         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
5400         method.
5401         * tui/tui-regs.c (tui_display_register): Call refresh_window
5402         method.
5403         * tui/tui-layout.c (show_source_disasm_command)
5404         (show_source_or_disasm_and_command): Call refresh_window method.
5405         * tui/tui-data.h (struct tui_gen_win_info)
5406         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
5407         New method.
5408
5409 2019-06-25  Tom Tromey  <tom@tromey.com>
5410
5411         * tui/tui.c (tui_rl_other_window, tui_enable)
5412         (tui_is_window_visible, tui_get_command_dimension): Update.
5413         * tui/tui-winsource.c (tui_update_source_window_as_is)
5414         (tui_clear_source_content, tui_erase_source_content)
5415         (tui_show_source_line, tui_source_window_base::refill)
5416         (tui_source_window_base::do_scroll_horizontal)
5417         (tui_source_window_base::set_is_exec_point_at)
5418         (tui_update_breakpoint_info, tui_set_exec_info_content)
5419         (tui_alloc_source_buffer, tui_line_is_displayed)
5420         (tui_addr_is_displayed): Update.
5421         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5422         (tui_check_and_display_highlight_if_needed)
5423         (tui_win_info::make_visible, tui_win_info::refresh)
5424         (tui_refresh_all): Update.
5425         * tui/tui-windata.c (tui_first_data_item_displayed)
5426         (tui_delete_data_content_windows, tui_erase_data_content)
5427         (tui_display_all_data, tui_data_window::refresh_all)
5428         (tui_check_data_values): Update.
5429         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
5430         (tui_set_win_focus_to, tui_win_info::forward_scroll)
5431         (tui_win_info::backward_scroll, tui_refresh_all_win)
5432         (tui_resize_all, tui_set_focus, tui_all_windows_info)
5433         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
5434         (tui_source_window_base::set_new_height)
5435         (tui_data_window::set_new_height)
5436         (make_invisible_and_set_new_height)
5437         (make_visible_with_new_height, new_height_ok)
5438         (parse_scrolling_args): Update.
5439         * tui/tui-stack.c (tui_show_frame_info): Update.
5440         * tui/tui-source.c (tui_set_source_content)
5441         (tui_set_source_content_nil, tui_source_is_displayed)
5442         (tui_source_window::do_scroll_vertical): Update.
5443         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5444         (tui_display_registers_from, tui_display_reg_element_at_line)
5445         (tui_check_register_values, tui_reg_command): Update.
5446         * tui/tui-layout.c (tui_default_win_height)
5447         (show_source_disasm_command, show_data, init_and_make_win)
5448         (show_source_or_disasm_and_command): Update.
5449         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
5450         (tui_redisplay_readline, tui_mld_flush)
5451         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
5452         (tui_getc): Update.
5453         * tui/tui-disasm.c (tui_set_disassem_content)
5454         (tui_disasm_window::do_scroll_vertical): Update.
5455         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
5456         Now virtual.
5457         (struct tui_win_info): Derive from tui_gen_win_info.
5458         <~tui_win_info>: Mark as override.
5459         <generic>: Remove member.
5460         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
5461         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
5462         (~tui_data_window, ~tui_win_info)
5463         (tui_free_all_source_wins_content): Update.
5464         * tui/tui-command.c (tui_refresh_cmd_win): Update.
5465
5466 2019-06-25  Tom Tromey  <tom@tromey.com>
5467
5468         * tui/tui-layout.c (init_and_make_win): Use new.
5469         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
5470         destructor, initializers.
5471         (tui_alloc_generic_win_info): Don't declare.
5472         * tui/tui-data.c (_locator): Add argument to constructor.
5473         (source_win, disasm_win): New globals.
5474         (exec_info): Remove.
5475         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
5476         Update.
5477         (tui_alloc_generic_win_info): Remove.
5478         (init_content_element): Use new.
5479         (tui_win_info::tui_win_info): Update.
5480         (free_content_elements) <case DATA_WIN>: Use delete.
5481
5482 2019-06-25  Tom Tromey  <tom@tromey.com>
5483
5484         * tui/tui-wingeneral.c (tui_refresh_win): Update.
5485         * tui/tui-windata.c (tui_first_data_item_displayed)
5486         (tui_delete_data_content_windows): Update.
5487         * tui/tui-win.c (tui_data_window::set_new_height): Update.
5488         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
5489         (tui_display_registers_from, tui_check_register_values): Update.
5490         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
5491         pointer.
5492         * tui/tui-data.c (init_content_element): Update.  Allocate the new
5493         window.
5494         (tui_free_data_content): Update.
5495         (free_content_elements) <case DATA_WIN>: Free the window.
5496
5497 2019-06-25  Tom Tromey  <tom@tromey.com>
5498
5499         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
5500         Update.
5501         * tui/tui-layout.c (make_command_window)
5502         (show_source_disasm_command, show_data, init_and_make_win)
5503         (show_source_or_disasm_and_command): Update.
5504         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
5505         method.
5506         <can_highight, is_highlighted>: Now bool.
5507         (tui_set_win_highlight): Don't declare.
5508         * tui/tui-data.c (tui_set_win_highlight): Remove.
5509
5510 2019-06-25  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-wingeneral.c (make_visible): Remove check of window
5513         type.
5514
5515 2019-06-25  Tom Tromey  <tom@tromey.com>
5516
5517         * tui/tui-win.c (tui_win_info::max_height)
5518         (tui_cmd_window::max_height): New methods.
5519         (new_height_ok): Call max_height.
5520         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
5521         <max_height>: New method.
5522
5523 2019-06-25  Tom Tromey  <tom@tromey.com>
5524
5525         * tui/tui-win.c (tui_source_window_base::set_new_height)
5526         (tui_data_window::set_new_height): New methods.
5527         (make_invisible_and_set_new_height): Call set_new_height method.
5528         * tui/tui-data.h (struct tui_win_info)
5529         (struct tui_source_window_base, struct tui_data_window)
5530         <set_new_height>: New method.
5531
5532 2019-06-25  Tom Tromey  <tom@tromey.com>
5533
5534         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
5535         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
5536         tui_refresh_data_win.
5537         * tui/tui-win.c (tui_source_window_base::refresh_all): New
5538         method.
5539         (tui_refresh_all_win): Call the refresh_all method.
5540         (tui_set_focus): Likewise.
5541         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
5542         (struct tui_source_window_base, struct tui_data_window) <refresh>:
5543         Likewise.
5544
5545 2019-06-25  Tom Tromey  <tom@tromey.com>
5546
5547         * tui/tui-winsource.h (tui_refill_source_window)
5548         (tui_set_is_exec_point_at): Don't declare.
5549         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5550         (tui_source_window_base::refill): Rename from
5551         tui_refill_source_window.
5552         (tui_source_window_base::do_scroll_horizontal): Update.
5553         (tui_source_window_base::set_is_exec_point_at): Rename from
5554         tui_set_is_exec_point_at.
5555         (tui_update_all_breakpoint_info): Update.
5556         * tui/tui-stack.c (tui_show_frame_info): Update.
5557         * tui/tui-layout.c (show_data): Add cast.
5558         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
5559         * tui/tui-data.h (struct tui_source_window_base) <refill,
5560         set_is_exec_point_at>: New methods.
5561         (tui_source_windows, tui_add_to_source_windows): Update types.
5562         (tui_add_to_source_windows): Remove redundant declaration.
5563         * tui/tui-data.c (source_windows): Store tui_source_window_base.
5564         (tui_source_windows): Change return type.
5565         (tui_clear_source_windows_detail): Update.
5566         (tui_add_to_source_windows): Change type of parameter.
5567         (tui_free_all_source_wins_content): Update.
5568
5569 2019-06-25  Tom Tromey  <tom@tromey.com>
5570
5571         * tui/tui-wingeneral.c (tui_win_info::refresh)
5572         (tui_source_window_base::refresh): New methods.
5573         (tui_refresh_all): Call the refresh method.
5574         * tui/tui-data.h (struct tui_win_info)
5575         (struct tui_source_window_base) <refresh>: New method.
5576
5577 2019-06-25  Tom Tromey  <tom@tromey.com>
5578
5579         * tui/tui.h (tui_is_window_visible): Return bool.
5580         * tui/tui.c (tui_is_window_visible): Return bool.
5581         * tui/tui-wingeneral.c (tui_make_window, make_visible)
5582         (tui_make_visible, tui_make_invisible)
5583         (tui_win_info::make_visible)
5584         (tui_source_window_base::make_visible, make_all_visible)
5585         (tui_make_all_visible, tui_make_all_invisible): Update.
5586         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
5587         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
5588         bool.
5589         (struct tui_win_info, struct tui_source_window_base)
5590         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
5591         * tui/tui-data.c (tui_init_generic_part): Update.
5592
5593 2019-06-25  Tom Tromey  <tom@tromey.com>
5594
5595         * tui/tui-wingeneral.c (tui_win_info::make_visible)
5596         (tui_source_window_base::make_visible): New methods.
5597         (make_all_visible): Make method call.
5598         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
5599         (struct tui_source_window_base, struct tui_cmd_window): Override
5600         make_visible.
5601         (tui_win_is_source_type): Don't declare.
5602         * tui/tui-data.c (tui_win_is_source_type): Remove.
5603
5604 2019-06-25  Tom Tromey  <tom@tromey.com>
5605
5606         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
5607         NULL check.
5608
5609 2019-06-25  Tom Tromey  <tom@tromey.com>
5610
5611         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
5612         Inline constructor.  Add initializers for members.
5613         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
5614         constructors; now inline in class.
5615
5616 2019-06-25  Tom Tromey  <tom@tromey.com>
5617
5618         * tui/tui-regs.c (tui_show_registers): Update.
5619         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
5620         bool.
5621         * tui/tui-data.c (tui_data_window::clear_detail)
5622         (tui_data_window): Update.
5623
5624 2019-06-25  Tom Tromey  <tom@tromey.com>
5625
5626         * tui/tui-windata.c (tui_display_all_data)
5627         (tui_display_data_from_line, tui_display_data_from)
5628         (tui_check_data_values, tui_data_window::do_scroll_vertical):
5629         Update.
5630         * tui/tui-regs.c (tui_last_regs_line_no)
5631         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
5632         (tui_show_registers, tui_show_register_group)
5633         (tui_display_registers_from, tui_display_reg_element_at_line)
5634         (tui_display_registers_from_line, tui_check_register_values)
5635         (tui_reg_next, tui_reg_prev): Update.
5636         * tui/tui-layout.c (tui_set_layout, show_data): Update.
5637         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
5638         tui_data_window.
5639         (struct tui_win_info) <detail>: Remove.  Add new fields from
5640         tui_data_info.
5641         (TUI_DATA_WIN): Add cast.
5642         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
5643         (~tui_data_window): Simplify.
5644
5645 2019-06-25  Tom Tromey  <tom@tromey.com>
5646
5647         * tui/tui-layout.c (show_source_disasm_command)
5648         (show_source_or_disasm_and_command): Update.
5649         * tui/tui-io.c (update_cmdwin_start_line)
5650         (tui_redisplay_readline): Update.
5651         * tui/tui-data.h (struct tui_command_info): Remove.
5652         (struct tui_win_info) <detail>: Remove command_info member.
5653         (struct tui_data_window) <start_line>: New member, from
5654         tui_command_info.
5655         (TUI_CMD_WIN): Add casts.
5656
5657 2019-06-25  Tom Tromey  <tom@tromey.com>
5658
5659         * tui/tui-winsource.c (tui_update_source_window)
5660         (tui_refill_source_window)
5661         (tui_source_window_base::do_scroll_horizontal)
5662         (tui_update_breakpoint_info, tui_set_exec_info_content)
5663         (tui_show_exec_info_content, tui_erase_exec_info_content)
5664         (tui_clear_exec_info_content): Update.
5665         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
5666         Update.
5667         * tui/tui-win.c (make_invisible_and_set_new_height)
5668         (make_visible_with_new_height): Update.
5669         * tui/tui-source.c (tui_set_source_content)
5670         (tui_show_symtab_source): Update.
5671         * tui/tui-layout.c (extract_display_start_addr)
5672         (show_source_disasm_command, show_data)
5673         (make_source_or_disasm_window)
5674         (show_source_or_disasm_and_command): Update.
5675         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
5676         (tui_disasm_window::do_scroll_vertical): Remove shadowing
5677         "gdbarch".
5678         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
5679         to tui_source_window_base.
5680         (struct tui_win_info) <detail>: Remove source_info member.
5681         (struct tui_source_window_base) <has_locator>: Inline.
5682         Move contents from tui_source_info; rename has_locator member to
5683         m_has_locator.
5684         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
5685         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
5686         header file.
5687         (tui_source_window_base::clear_detail, ~tui_source_window_base):
5688         Simplify.
5689         (tui_free_all_source_wins_content): Cast to
5690         tui_source_window_base.
5691
5692 2019-06-25  Tom Tromey  <tom@tromey.com>
5693
5694         * tui/tui-win.c (make_invisible_and_set_new_height)
5695         (make_visible_with_new_height): Call has_locator method.
5696         * tui/tui-layout.c (show_source_disasm_command, show_data)
5697         (show_source_or_disasm_and_command): Update for bool change.
5698         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
5699         (tui_win_info) <has_locator>: New method.
5700         (struct tui_source_window_base) <has_locator>: New method.
5701         (tui_win_has_locator): Don't declare.
5702         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
5703         from tui_win_has_locator.
5704         (tui_source_window_base): Use false, not FALSE.
5705
5706 2019-06-25  Tom Tromey  <tom@tromey.com>
5707
5708         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
5709         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
5710         clear_detail method directly.
5711         (tui_clear_win_detail): Remove.
5712
5713 2019-06-25  Tom Tromey  <tom@tromey.com>
5714
5715         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
5716         "this", not TUI_DISASM_WIN.
5717
5718 2019-06-25  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
5721         declare.
5722         * tui/tui-winsource.c
5723         (tui_source_window_base::do_scroll_horizontal): Rename from
5724         tui_horizontal_source_scroll.
5725         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
5726         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
5727         from tui_vertical_data_scroll.
5728         * tui/tui-win.h (tui_scroll): Don't declare.
5729         * tui/tui-win.c (tui_win_info::forward_scroll)
5730         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
5731         (tui_win_info::right_scroll): Rename and update.
5732         (tui_scroll_forward_command, tui_scroll_backward_command)
5733         (tui_scroll_left_command, tui_scroll_right_command): Update.
5734         (tui_scroll): Remove.
5735         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
5736         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
5737         from tui_vertical_source_scroll.
5738         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
5739         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
5740         from tui_vertical_disassem_scroll.
5741         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
5742         do_scroll_horizontal>: New methods.
5743         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
5744         Likewise.
5745         (struct tui_source_window_base): Add do_scroll_horizontal.
5746         (struct tui_source_window, struct tui_disasm_window): Add
5747         do_scroll_vertical.
5748         (struct tui_data_window, struct tui_cmd_window): Add
5749         do_scroll_horizontal and do_scroll_vertical.
5750         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
5751
5752 2019-06-25  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-data.h (struct tui_source_window_base): New struct.
5755         (struct tui_source_window): Derive from tui_source_window_base.
5756         (struct tui_disasm_window): New struct.
5757         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
5758         from tui_source_window::clear_detail.
5759         (tui_source_window_base): Rename from tui_source_window.
5760         (~tui_source_window_base): Rename from ~tui_source_window.
5761         (tui_alloc_win_info): Create a tui_disasm_window.
5762
5763 2019-06-25  Tom Tromey  <tom@tromey.com>
5764
5765         * tui/tui-data.h (struct tui_source_window)
5766         (struct tui_data_window): Declare destructors.
5767         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
5768         destructors.
5769         (tui_win_info): Simplify.
5770
5771 2019-06-25  Tom Tromey  <tom@tromey.com>
5772
5773         * tui/tui-winsource.c (tui_display_main)
5774         (tui_update_source_windows_with_addr)
5775         (tui_update_all_breakpoint_info): Update.
5776         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5777         (new_height_ok, parse_scrolling_args): Update.
5778         * tui/tui-stack.c (tui_show_frame_info): Update.
5779         * tui/tui-data.h (struct tui_list): Remove.
5780         (tui_source_windows): Return a reference to a std::vector.
5781         * tui/tui-data.c (source_windows): Now a std::vector.
5782         (tui_source_windows): Change return type.
5783         (tui_clear_source_windows): Rewrite.
5784         (tui_clear_source_windows_detail, tui_add_to_source_windows)
5785         (tui_free_all_source_wins_content): Rewrite.
5786
5787 2019-06-25  Tom Tromey  <tom@tromey.com>
5788
5789         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
5790         (struct tui_data_window, struct tui_cmd_window): Declare
5791         clear_detail method.
5792         * tui/tui-data.c (tui_source_window::clear_detail)
5793         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
5794         methods.
5795         (tui_clear_win_detail): Simplify.
5796
5797 2019-06-25  Tom Tromey  <tom@tromey.com>
5798
5799         * tui/tui-layout.c (make_source_window, make_disasm_window)
5800         (make_source_or_disasm_window): Remove win_info_ptr parameter.
5801         Return the new window.
5802         (show_source_disasm_command, show_data)
5803         (show_source_or_disasm_and_command): Update.
5804
5805 2019-06-25  Tom Tromey  <tom@tromey.com>
5806
5807         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
5808         parameter.  Return the new window.
5809         (show_source_disasm_command): Update and remove NULL check.
5810         (show_source_or_disasm_and_command): Update.
5811
5812 2019-06-25  Tom Tromey  <tom@tromey.com>
5813
5814         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
5815
5816 2019-06-25  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-data.h (struct tui_win_info): Make constructor
5819         protected.  Make destructor virtual.  Add initializers.
5820         (tui_source_window, tui_data_window, tui_cmd_window): New
5821         classes.
5822         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
5823         constructor.  Add "type" parameter.
5824         (tui_source_window, tui_data_window, tui_cmd_window): New
5825         constructors.
5826         (tui_alloc_win_info): Instantiate the appropriate subclass.
5827
5828 2019-06-25  Tom Tromey  <tom@tromey.com>
5829
5830         * tui/tui-win.c (tui_resize_all): Use delete.
5831         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
5832         destructor.
5833         (tui_free_window): Don't declare.
5834         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
5835         Update.
5836
5837 2019-06-25  Tom Tromey  <tom@tromey.com>
5838
5839         * tui/tui-data.h (struct tui_win_info): Add constructor.
5840         * tui/tui-data.c (tui_alloc_win_info): Use new.
5841         (tui_free_window): Use delete.
5842
5843 2019-06-22  Tom Tromey  <tom@tromey.com>
5844
5845         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
5846         declare.
5847         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
5848
5849 2019-06-22  Tom Tromey  <tom@tromey.com>
5850
5851         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
5852         declare.
5853         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
5854
5855 2019-06-22  Tom de Vries  <tdevries@suse.de>
5856
5857         * dwarf2read.c (create_addrmap_from_aranges)
5858         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
5859         instead of '%zu'.
5860
5861 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
5862
5863         * dwarf2read.h (dwarf2_section_info_def): Remove.
5864         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
5865         * dwarf2read.c (struct dwo_sections) <types>: Change type to
5866         std::vector<dwarf2_section_info>.
5867         (struct dwo_file) <~dwo_file>: Remove.
5868         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
5869         types field.
5870         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
5871         (dwarf2_read_debug_names): Likewise.
5872         (create_debug_types_hash_table): Change parameter type to
5873         array_view, adjust code accordingly.
5874         (dwarf2_locate_dwo_sections): Adjust to std::vector.
5875         (partial_die_info::fixup): Likewise.
5876         (determine_prefix): Likewise.
5877         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
5878
5879 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5880
5881         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
5882         gdb_bfd_ref_ptr.
5883         <~dwo_file>: Remove call to gdb_bfd_unref.
5884         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
5885         gdb_bfd_ref_ptr::get.
5886
5887 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5888
5889         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
5890         type to htab_up.
5891         * dwarf2read.c (struct dwo_file): Initialize fields.
5892         <~dwo_file>: New.
5893         (free_dwo_file): Remove, move content to ~dwo_file.
5894         (struct dwo_file_deleter): Remove.
5895         (dwo_file_up>: Remove custom deleter.
5896         (free_dwo_files): Remove.
5897         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
5898         dwo_files.
5899         (process_skeletonless_type_units): Call unique_ptr::get.
5900         (allocate_dwo_file_hash_table): Add deleter to created hash
5901         table.  Change return type to htab_up.
5902         (lookup_dwo_file_slot): Don't memset dwo_file, call
5903         unique_ptr::get.
5904         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
5905         (create_dwo_unit_in_dwp_v2): Likewise.
5906         (open_and_init_dwo_file): Likewise.
5907         (free_dwo_file_from_slot): Remove.
5908
5909 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
5910
5911         * dwarf2read.h (struct dwarf2_section_info) <readin,
5912         is_virtual>: Change type to bool.
5913         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
5914         true instead of 1.
5915
5916 2019-06-19  Tom Tromey  <tom@tromey.com>
5917
5918         * tui/tui-data.h (tui_init_content_element): Don't declare.
5919
5920 2019-06-19  Tom Tromey  <tom@tromey.com>
5921
5922         * tui/tui-data.h (tui_init_win_info): Don't declare.
5923
5924 2019-06-19  Tom de Vries  <tdevries@suse.de>
5925
5926         * dwarf2read.h (abstract_to_concrete): Change type to
5927         std::unordered_map<sect_offset, std::vector<sect_offset>,
5928         gdb::hash_enum<sect_offset>>.
5929
5930 2019-06-19  Tom Tromey  <tromey@adacore.com>
5931
5932         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
5933         EVAL_AVOID_SIDE_EFFECTS specially.
5934
5935 2019-06-19  Tom Tromey  <tromey@adacore.com>
5936
5937         * source-cache.c (highlighter): New global.
5938         (source_cache::get_source_lines): Create a highlighter on demand.
5939
5940 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5941
5942         * defs.h (deprecated_interactive_hook): Delete declaration.
5943         * interps.c (clear_interpreter_hooks): Remove use of
5944         deprecated_interactive_hook.
5945         * top.c (deprecated_interactive_hook): Delete definition.
5946         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
5947
5948 2019-06-18  Tom de Vries  <tdevries@suse.de>
5949
5950         PR gdb/24515
5951         * dwarf2read.h (abstract_to_concrete): Change type from
5952         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
5953         std::unordered_map<sect_offset, std::vector<sect_offset>>.
5954         * dwarf2read.c (read_variable): Update.
5955         (dwarf2_fetch_die_loc_sect_off): Update.
5956
5957 2019-06-17  Tom de Vries  <tdevries@suse.de>
5958
5959         PR gdb/24617
5960         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
5961         accessing parent[parent_len - 1].
5962
5963 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
5964
5965         PR gdb/24364
5966         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
5967         call dtrace_process_dof with NULL dof.
5968
5969 2019-06-16  Tom de Vries  <tdevries@suse.de>
5970
5971         PR gdb/24445
5972         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
5973
5974 2019-06-16  Tom Tromey  <tom@tromey.com>
5975
5976         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
5977         (make_all_visible): Use address of member.
5978
5979 2019-06-16  Tom Tromey  <tom@tromey.com>
5980
5981         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
5982         (tui_free_window, free_content, free_content_elements): Remove
5983         unnecessary cast.
5984         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
5985         cast.
5986         * tui/tui-regs.c (tui_show_register_group)
5987         (tui_display_registers_from, tui_display_reg_element_at_line):
5988         Remove unnecessary cast.
5989
5990 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
5991
5992         * linux-nat.c (normal_mask): Delete.
5993         (_initialize_linux_nat): Don't initialise normal_mask.
5994
5995 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
5996
5997         PR gdb/24445
5998         * dwarf-index-write.h (write_psymtabs_to_index): Add
5999         dwz_basename parameter.
6000         * dwarf-index-write.c (write_gdbindex): Move file writing to
6001         write_gdbindex_1.  Change return type void.
6002         (assert_file_size): Move up, remove filename parameter.
6003         (write_gdbindex_1): New function.
6004         (write_debug_names): Change return type to void, call
6005         assert_file_size.
6006         (struct index_wip_file): New struct.
6007         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
6008         file logic to index_wip_file.  Write index for dwz file if
6009         needed.
6010         (save_gdb_index_command): Pass basename of dwz file, if present.
6011         * dwarf-index-cache.c (index_cache::store): Obtain and pass
6012         build-id of dwz file, if present.
6013         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
6014         (dwarf2_get_dwz_file): Likewise.
6015         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
6016         (dwarf2_get_dwz_file): Likewise.
6017
6018 2019-06-16  Tom Tromey  <tom@tromey.com>
6019
6020         * coffread.c (process_coff_symbol): Use xstrdup.
6021         * value.c (create_internalvar): Use xstrdup.
6022
6023 2019-06-16  Tom Tromey  <tom@tromey.com>
6024
6025         * valops.c (value_cast, value_slice): Remove unnecessary cast.
6026         * breakpoint.c (stopin_command, stopat_command)
6027         (until_break_command, decode_location_default): Remove unnecessary
6028         cast.
6029         * utils.c (subset_compare): Remove unnecessary cast.
6030         * ada-lang.c (ada_update_initial_language): Remove unnecessary
6031         cast.
6032         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
6033         cast.
6034         * infcmd.c (path_command): Remove unnecessary cast.
6035         * coffread.c (decode_type): Remove unnecessary cast.
6036         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
6037         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
6038         * tui/tui-stack.c (tui_show_locator_content)
6039         (tui_show_frame_info): Remove unnecessary cast.
6040         * tui/tui-win.c (tui_scroll_forward_command)
6041         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
6042         (parse_scrolling_args): Remove unnecessary cast.
6043         * tui/tui-data.c (init_win_info, tui_del_window)
6044         (tui_free_window, tui_del_data_windows, tui_free_data_content)
6045         (free_content_elements): Remove unnecessary cast.
6046         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
6047         unnecessary cast.
6048         * tui/tui-source.c (tui_set_source_content)
6049         (tui_vertical_source_scroll): Remove unnecessary cast.
6050         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
6051         cast.
6052         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
6053         * tui/tui-regs.c (tui_display_registers_from)
6054         (tui_display_register): Remove unnecessary cast.
6055         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
6056         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
6057         (make_visible): Remove unnecessary cast.
6058         * tui/tui-winsource.c (tui_erase_source_content)
6059         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
6060         unnecessary cast.
6061         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
6062         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
6063         * stabsread.c (read_type, read_array_type, read_range_type):
6064         Remove unnecessary cast.
6065         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
6066         (parse_symbol, parse_type, upgrade_type, parse_external)
6067         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
6068         unnecessary cast.
6069         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
6070
6071 2019-06-16  Tom Tromey  <tom@tromey.com>
6072
6073         * tui/tui-data.c (tui_alloc_generic_win_info)
6074         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
6075         checks.
6076
6077 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
6078             Andrew Burgess  <andrew.burgess@embecosm.com>
6079
6080         * f-typeprint.c (f_print_type): Don't return early for not
6081         associated or not allocated types.
6082         (f_type_print_varspec_suffix): Add print_rank parameter and print
6083         ranks of array types in case they dangling.
6084         (f_type_print_base): Add print_rank parameter.
6085
6086 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6087
6088         * NEWS: Mention new MI commands.
6089         * break-catch-throw.c (enum exception_event_kind): Move to
6090         breakpoint.h.
6091         (print_mention_exception_catchpoint): Output text as a single
6092         message.
6093         (catch_exception_command_1): Rename to...
6094         (catch_exception_event): ...this, make non-static, update header
6095         command, and change some parameter types.
6096         (catch_catch_command): Update for changes to
6097         catch_exception_command_1.
6098         (catch_throw_command): Likewise.
6099         (catch_rethrow_command): Likewise.
6100         * breakpoint.c (enum exception_event_kind): Delete.
6101         * breakpoint.h (enum exception_event_kind): Moved here from
6102         break-catch-throw.c.
6103         (catch_exception_event): Declare.
6104         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
6105         (mi_cmd_catch_throw): New function.
6106         (mi_cmd_catch_rethrow): New function.
6107         (mi_cmd_catch_catch): New function.
6108         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
6109         'catch-catch' entries.
6110         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
6111         (mi_cmd_catch_rethrow): Declare.
6112         (mi_cmd_catch_catch): Declare.
6113
6114 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6115
6116         * annotate.c (annotate_source_line): Change return type to void,
6117         update implementation to match.
6118         * annotate.h (annotate_source_line): Change return type to void,
6119         update header comment.
6120         * stack.c (print_frame_info): Don't change what frame information
6121         is printed based on whether annotations are on or not.
6122
6123 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6124
6125         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
6126         (annotate_source): Make static.
6127         (annotate_source_line): Moved from source.c and renamed from
6128         identify_source_line.  Update the return type.
6129         * annotate.h (annotate_source): Delete declaration.
6130         (annotate_source_line): Declaration moved from source.h, and
6131         renamed from identify_source_line.  Return type updated.
6132         * source.c (identify_source_line): Moved to annotate.c and renamed
6133         to annotate_source_line.
6134         (info_line_command): Remove check of annotation_level.
6135         * source.h (identify_source_line): Move declaration to annotate.h
6136         and rename to annotate_source_line.
6137         * stack.c: Add 'annotate.h' include.
6138         (print_frame_info): Remove check of annotation_level before
6139         calling annotate_source_line.
6140
6141 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6142
6143         * source-cache.c (source_cache::get_plain_source_lines): Use
6144         open_source_file_with_line_charpos instead of just
6145         open_source_file, remove call to find_source_lines.
6146         (source_cache::get_source_lines): Likewise.
6147         * source.c (find_source_lines): Make static.
6148         (get_filename_and_charpos): Renamed into...
6149         (open_source_file_with_line_charpos): ..this along with changes to
6150         return a scoped_fd, and some other minor clean ups.
6151         (identify_source_line): Use open_source_file_with_line_charpos.
6152         (search_command_helper): Use open_source_file_with_line_charpos
6153         instead of just open_source_file, remove call to
6154         find_source_lines.
6155         * source.h (open_source_file_with_line_charpos): Declare new
6156         function.
6157         (find_source_lines): Delete declaration.
6158
6159 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
6160
6161         * source.c (get_filename_and_charpos): Remove fullname
6162         parameter.
6163         (identify_source_line): Update call to get_filename_and_charpos.
6164
6165 2019-06-14  Tom Tromey  <tromey@adacore.com>
6166
6167         PR gdb/24502:
6168         * ui-style.h (skip_ansi_escape): Update comment.
6169         * ui-file.h (class no_terminal_escape_file): New class.
6170         * ui-file.c (no_terminal_escape_file::write)
6171         (no_terminal_escape_file::puts): New methods.
6172         * cli/cli-logging.c (handle_redirections): Use
6173         no_terminal_escape_file.
6174
6175 2019-06-14  Tom Tromey  <tromey@adacore.com>
6176
6177         * NEWS: Move convenience variable news above Python news.
6178
6179 2019-06-14  Tom Tromey  <tom@tromey.com>
6180
6181         * gnulib: Move directory to top-level.
6182         * configure.ac: Don't configure gnulib.
6183         * configure: Rebuild.
6184         * common/common-defs.h: Use new path to gnulib.
6185         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
6186         (GNULIB_H): Remove.
6187         (INCGNU): Look in new gnulib location.
6188         (HFILES_NO_SRCDIR): Remove gnulib files.
6189         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
6190         (generated_files): Remove GNULIB_H.
6191         ($(LIBGNU), all-lib): Remove targets.
6192         (distclean): Don't mention GNULIB_BUILDDIR.
6193         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
6194
6195 2019-06-14  Tom Tromey  <tromey@adacore.com>
6196
6197         * symfile.c (add_symbol_file_command): Remove obsolete comment.
6198         Warn if symbol file does not provide any symbols.
6199
6200 2019-06-14  Tom Tromey  <tromey@adacore.com>
6201
6202         * source.c (find_and_open_source): Respect basenames_may_differ.
6203
6204 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
6205
6206         * annotate.c (annotate_breakpoints_invalid): Make use of
6207         scoped_restore_terminal_state.
6208         (annotate_frames_invalid): Likewise.
6209
6210 2019-06-14  Tom Tromey  <tromey@adacore.com>
6211
6212         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
6213         allow assignment to an internalvar.
6214
6215 2019-06-14  Tom Tromey  <tromey@adacore.com>
6216
6217         * ada-lex.l: Allow "_" in attribute names.
6218
6219 2019-06-14  Tom Tromey  <tromey@adacore.com>
6220
6221         PR gdb/24653:
6222         * regcache.c (registers_changed): Don't call alloca.
6223         * top.c (execute_command): Don't call alloca.
6224
6225 2019-06-13  Pedro Alves  <palves@redhat.com>
6226
6227         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
6228         'expression'.  When parsing an expression, error out if there's
6229         junk after "unlimited".
6230         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6231         (do_set_command): Adjust calls to is_unlimited_literal.
6232
6233 2019-06-13  Pedro Alves  <palves@redhat.com>
6234
6235         * compile/compile.c (make_compile_options_def_group): Add braces
6236         around array_view initializer.
6237         * thread.c (make_thread_apply_all_options_def_group)
6238         (make_thread_apply_all_options_def_group): Likewise.
6239
6240 2019-06-13  Pedro Alves  <palves@redhat.com>
6241
6242         * NEWS (New commands): Mention "maint test-options
6243         require-delimiter", "maint test-options unknown-is-error", "maint
6244         test-options unknown-is-operand" and "maint show
6245         test-options-completion-result".
6246         (New command options, command completion): New section.
6247         (Completion improvements): New section.
6248         Mention that you can abbreviate "unlimited".
6249
6250 2019-06-13  Pedro Alves  <palves@redhat.com>
6251
6252         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
6253         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
6254         * unittests/cli-utils-selftests.c (test_parse_flags)
6255         (test_parse_flags_qcs): Delete.
6256         (test_cli_utils): Don't call deleted functions.
6257
6258 2019-06-13  Pedro Alves  <palves@redhat.com>
6259
6260         * thread.c: Include "cli/cli-option.h".
6261         (tp_array_compar_ascending): Global.
6262         (tp_array_compar): Delete function.
6263         (tp_array_compar_ascending, tp_array_compar_descending): New
6264         functions.
6265         (ascending_option_def, qcs_flag_option_def)
6266         (thr_qcs_flags_option_defs)
6267         (make_thread_apply_all_options_def_group)
6268         (make_thread_apply_options_def_group): New.
6269         (thread_apply_all_command): Use gdb::option::process_options.
6270         (thread_apply_command_completer)
6271         (thread_apply_all_command_completer): New.
6272         (thread_apply_command): Use gdb::option::process_options.
6273         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
6274         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
6275         to generate help text of "thread apply".  Adjust "taas"'s help.
6276         * tid-parse.c (tid_range_parser::in_thread_range): New method.
6277         * tid-parse.h (tid_range_parser::in_thread_range): New method.
6278
6279 2019-06-13  Pedro Alves  <palves@redhat.com>
6280
6281         * thread.c (thread_apply_command): Check for invalid TID with
6282         isdigit instead of !isalpha.
6283
6284 2019-06-13  Pedro Alves  <palves@redhat.com>
6285
6286         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
6287         (validate_flags_qcs): New.
6288         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
6289         (validate_flags_qcs): Declare.
6290         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
6291         (make_frame_apply_options_def_group): New.
6292         (frame_apply_command_count): Process options with
6293         gdb::option::process_options.
6294         (frame_apply_completer): New.
6295         (frame_apply_level_completer, frame_apply_all_completer)
6296         (frame_apply_completer): New.
6297         (_initialize_stack): Update help of "frame apply", "frame apply
6298         level", "frame apply all" and "faas" to mention supported options
6299         and install command completers.
6300         * stack.h (frame_apply_all_completer): Declare.
6301         * thread.c: Include "stack.h".
6302         (tfaas_command): Add "--".
6303         (_initialize_thread): Update help "tfaas" to mention supported
6304         options and install command completer.
6305
6306 2019-06-13  Pedro Alves  <palves@redhat.com>
6307
6308         * completer.c (complete_nested_command_line): New.
6309         (gdb_completion_word_break_characters_throw): Add assertion.
6310         * completer.h (complete_nested_command_line): Declare.
6311
6312 2019-06-13  Pedro Alves  <palves@redhat.com>
6313
6314         * stack.c (parse_backtrace_qualifiers): New.
6315         (backtrace_command): Use it.
6316         (backtrace_command_completer): Complete on qualifiers.
6317
6318 2019-06-13  Pedro Alves  <palves@redhat.com>
6319
6320         * frame.c: Include "cli/cli-option.h.
6321         (user_set_backtrace_options): New.
6322         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
6323         Delete.
6324         (get_prev_frame): Adjust.
6325         (boolean_option_def, uinteger_option_def)
6326         (set_backtrace_option_defs): New.
6327         (_initialize_frame): Adjust and use
6328         gdb::option::add_setshow_cmds_for_options to install "set
6329         backtrace past-main" and "set backtrace past-entry".
6330         * frame.h: Include "cli/cli-option.h".
6331         (struct frame_print_options): Forward declare.
6332         (print_frame_arguments_all, print_frame_arguments_scalars)
6333         (print_frame_arguments_none): Declare.
6334         (print_entry_values): Delete declaration.
6335         (struct frame_print_options, user_frame_print_options): New.
6336         (struct set_backtrace_options): New.
6337         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
6338         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
6339         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
6340         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
6341         (list_args_or_locals): Add frame_print_options parameter.
6342         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6343         * python/py-framefilter.c (enumerate_args): Pass down
6344         USER_FRAME_PRINT_OPTIONS.
6345         * stack.c: Include "cli/cli-option.h".
6346         (print_frame_arguments_all, print_frame_arguments_scalars)
6347         (print_frame_arguments_none): Declare.
6348         (print_raw_frame_arguments, print_entry_values): Delete.
6349         (user_frame_print_options): New.
6350         (boolean_option_def, enum_option_def, frame_print_option_defs):
6351         New.
6352         (struct backtrace_cmd_options): New.
6353         (bt_flag_option_def): New.
6354         (backtrace_command_option_defs): New.
6355         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
6356         (print_frame_arg, read_frame_arg, print_frame_args)
6357         (print_frame_info, print_frame): Add frame_print_options parameter
6358         and use it.
6359         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
6360         (backtrace_command_1): Add frame_print_options and
6361         backtrace_cmd_options parameters and use them.
6362         (make_backtrace_options_def_group): New.
6363         (backtrace_command): Process command options with
6364         gdb::option::process_options.
6365         (backtrace_command_completer): New.
6366         (_initialize_stack): Extend "backtrace"'s help to mention
6367         supported options.  Install completer for "backtrace".
6368         Install some settings commands with add_setshow_cmds_for_options.
6369
6370 2019-06-13  Pedro Alves  <palves@redhat.com>
6371
6372         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
6373         and that "set/show print raw frame-arguments" are now deprecated.
6374
6375         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
6376         command.
6377         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
6378         * stack.c (_initialize_stack): Install "set/show print
6379         raw-frame-arguments", and deprecate "set/show print raw
6380         frame-arguments".
6381         * valprint.c (_initialize_valprint): Deprecate "set/show print
6382         raw".
6383
6384 2019-06-13  Pedro Alves  <palves@redhat.com>
6385
6386         * compile/compile.c (struct compile_options): New.
6387         (compile_flag_option_def, compile_command_option_defs)
6388         (make_compile_options_def_group): New.
6389         (compile_file_command): Handle options with
6390         gdb::option::process_options.
6391         (compile_file_command_completer): New function.
6392         (compile_code_command): Handle options with
6393         gdb::option::process_options.
6394         (compile_code_command_completer): New function.
6395         (_initialize_compiler): Install completers for "compile code" and
6396         "compile file".  Mention available options in "compile code" and
6397         "compile code"'s help.
6398         * completer.c (advance_to_completion_word): New, factored out from
6399         ...
6400         (advance_to_expression_complete_word_point): ... this.
6401         (advance_to_filename_complete_word_point): New.
6402         * completer.h (advance_to_filename_complete_word_point): New
6403         declaration.
6404
6405 2019-06-13  Pedro Alves  <palves@redhat.com>
6406
6407         * compile/compile.c: Include "cli/cli-option.h".
6408         (compile_print_value): Scope data pointer is now a
6409         value_print_options pointer; adjust.
6410         (compile_print_command): Process options.  Scope data pointer is
6411         now a value_print_options pointer; adjust.
6412         (_initialize_compile): Update "compile print"'s help to include
6413         supported options.  Install a completer for "compile print".
6414         * cp-valprint.c (show_vtblprint, show_objectprint)
6415         (show_static_field_print): Delete.
6416         (_initialize_cp_valprint): Don't install "set print
6417         static-members", "set print vtbl", "set print object" here.
6418         * printcmd.c: Include "cli/cli-option.h" and
6419         "common/gdb_optional.h".
6420         (print_command_parse_format): Rework to fill in a
6421         value_print_options instead of a format_data.
6422         (print_value): Change parameter type from format_data pointer to
6423         value_print_options reference.  Adjust.
6424         (print_command_1): Process options.  Adjust to pass down a
6425         value_print_options.
6426         (print_command_completer): New.
6427         (_initialize_printcmd): Install print_command_completer as
6428         handle_brkchars completer for the "print" command.  Update
6429         "print"'s help to include supported options.
6430         * valprint.c: Include "cli/cli-option.h".
6431         (show_vtblprint, show_objectprint, show_static_field_print): Moved
6432         here from cp-valprint.c.
6433         (boolean_option_def, uinteger_option_def)
6434         (value_print_option_defs, make_value_print_options_def_group):
6435         New.  Use gdb::option::add_setshow_cmds_for_options to install
6436         "set print elements", "set print null-stop", "set print repeats",
6437         "set print pretty", "set print union", "set print array", "set
6438         print address", "set print symbol", "set print array-indexes".
6439         * valprint.h: Include <string> and "cli/cli-option.h".
6440         (make_value_print_options_def_group): Declare.
6441         (print_value): Change parameter type from format_data pointer to
6442         value_print_options reference.
6443         (print_command_completer): Declare.
6444
6445 2019-06-13  Pedro Alves  <palves@redhat.com>
6446
6447         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
6448         (COMMON_SFILES): Add maint-test-settings.c.
6449         * cli/cli-decode.c (boolean_enums): New global, factored out from
6450         ...
6451         (add_setshow_boolean_cmd): ... here.
6452         * cli/cli-decode.h (boolean_enums): Declare.
6453         * cli/cli-option.c: New file.
6454         * cli/cli-option.h: New file.
6455         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
6456         factored out from ...
6457         (parse_cli_boolean_value(const char *)): ... this.
6458         (is_unlimited_literal): Change parameter type to pointer to
6459         pointer.  Adjust and advance ARG pointer.
6460         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6461         (parse_cli_var_enum): New, factored out from ...
6462         (do_set_command): ... this.  Adjust.
6463         * cli/cli-setshow.h (parse_cli_boolean_value)
6464         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
6465         (parse_cli_var_enum): Declare.
6466         * cli/cli-utils.c: Include "cli/cli-option.h".
6467         (get_ulongest): New.
6468         * cli/cli-utils.h (get_ulongest): Declare.
6469         (check_for_argument): New overloads.
6470         * maint-test-options.c: New file.
6471
6472 2019-06-13  Pedro Alves  <palves@redhat.com>
6473
6474         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
6475         parse a range if "-" is at the end of the string.
6476
6477 2019-06-13  Pedro Alves  <palves@redhat.com>
6478
6479         * cli/cli-setshow.c (parse_auto_binary_operation)
6480         (parse_cli_boolean_value): Don't allow "o".
6481
6482 2019-06-13  Pedro Alves  <palves@redhat.com>
6483
6484         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
6485         * NEWS: Mention maint test-settings KIND.
6486         * maint-test-settings.c: New file.
6487
6488 2019-06-13  Pedro Alves  <palves@redhat.com>
6489
6490         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
6491         completer.
6492         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
6493         "set" completers.
6494
6495 2019-06-13  Pedro Alves  <palves@redhat.com>
6496
6497         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
6498         after item.
6499
6500 2019-06-13  Pedro Alves  <palves@redhat.com>
6501
6502         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
6503
6504 2019-06-13  Pedro Alves <palves@redhat.com>
6505
6506         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
6507         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
6508         call.
6509         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
6510         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
6511         calls.
6512         (check_for_argument): Skip spaces after argument.
6513
6514 2019-06-13  Pedro Alves  <palves@redhat.com>
6515
6516         * thread.c (thread_apply_command): Adjust TID parsing.
6517         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
6518         detected before end of string.
6519         (tid_is_in_list): Error out if LIST is invalid.
6520
6521 2019-06-13  Pedro Alves  <palves@redhat.com>
6522
6523         * completer.c (complete_line_internal_1): Rewind completion word
6524         point.
6525         (completion_tracker::advance_custom_word_point_by): Change
6526         parameter type to int.
6527         * completer.h (completion_tracker::advance_custom_word_point_by):
6528         Likewise.
6529
6530 2019-06-13  Pedro Alves  <palves@redhat.com>
6531
6532         * completer.c (advance_to_completion_word): Handle delimiters.
6533
6534 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
6535
6536         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
6537
6538 2019-06-11  Tom Tromey  <tom@tromey.com>
6539
6540         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
6541         (xmalloc_failed): Move to alloc.c.
6542         * alloc.c: New file.
6543         * Makefile.in (COMMON_SFILES): Add alloc.c.
6544
6545 2019-06-11  Tom Tromey  <tom@tromey.com>
6546
6547         * nat/linux-waitpid.c: Don't include server.h.
6548         (linux_debug): Remove.
6549         (my_waitpid): Update.
6550
6551 2019-06-11  Tom Tromey  <tromey@adacore.com>
6552
6553         * infcall.c (_initialize_infcall): Remove trailing newline from
6554         help.
6555         * user-regs.c (_initialize_user_regs): Remove trailing newline
6556         from help.
6557         * typeprint.c (_initialize_typeprint): Remove trailing newline
6558         from help.
6559         * reverse.c (_initialize_reverse): Remove trailing newlines from
6560         help.
6561         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
6562         from help.
6563         * language.c (add_set_language_command): Remove trailing newline
6564         from help.
6565         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
6566         help.
6567         * disasm.c (_initialize_disasm): Remove trailing newline from
6568         help.
6569         * top.c (init_main): Remove trailing newline from help.
6570         * interps.c (_initialize_interpreter): Remove trailing newline
6571         from help.
6572         * btrace.c (_initialize_btrace): Remove trailing newlines from
6573         help.
6574         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
6575         from help.
6576         * python/python.c (_initialize_python): Remove trailing newline
6577         from help.
6578         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
6579         help.
6580         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
6581         from help.  Reformat some text.
6582         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
6583         from help.
6584         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
6585         newline from help.
6586
6587 2019-06-11  Tom Tromey  <tromey@adacore.com>
6588
6589         * darwin-nat.c (darwin_decode_exception_message)
6590         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
6591
6592 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6593
6594         * valops.c (value_slice): Check for not allocated or not
6595         associated values.
6596
6597 2019-06-10  Tom de Vries  <tdevries@suse.de>
6598
6599         PR gdb/24618
6600         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
6601         sure an empty slot (defined by a 32-bit zero pair) is recognized as
6602         invalid.
6603
6604 2019-06-10  Tom de Vries  <tdevries@suse.de>
6605
6606         PR gdb/24611
6607         * linespec.c (linespec_lexer_lex_string): Remove incorrect
6608         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
6609
6610 2019-06-10  Tom de Vries  <tdevries@suse.de>
6611
6612         PR symtab/24545
6613         * symtab.c (struct demangled_name_entry): Add language field.
6614         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
6615         static minimal symbol".  Set and use language field.
6616
6617 2019-06-10  Tom Tromey  <tromey@adacore.com>
6618
6619         * ada-lang.c (_initialize_ada_language): Update help text.
6620
6621 2019-06-10  Tom Tromey  <tromey@adacore.com>
6622
6623         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
6624         with a newline.
6625         * guile/guile.c (handle_boot_error): Don't end warning with a
6626         newline.
6627         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
6628         warning with a newline.
6629         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
6630         newline.
6631         (s12z_frame_cache): Likewise.
6632         * dwarf-index-cache.c (index_cache::store): Don't end warning with
6633         a newline.
6634         * solib-svr4.c (disable_probes_interface): Don't end warning with
6635         a newline.
6636         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
6637         newline.
6638         * python/python.c (do_finish_initialization): Don't end warning
6639         with a newline.
6640
6641 2019-06-10  Tom Tromey  <tom@tromey.com>
6642
6643         * python/py-breakpoint.c (gdbpy_breakpoint_created)
6644         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
6645         gdbpy_enter.
6646
6647 2019-06-10  Tom Tromey  <tromey@adacore.com>
6648
6649         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
6650         data.
6651         (elf_new_init): Don't call stabsread_new_init.
6652         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
6653         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
6654         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
6655
6656 2019-06-10  Tom de Vries  <tdevries@suse.de>
6657
6658         PR symtab/16264
6659         PR symtab/24517
6660         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
6661
6662 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
6663
6664         * source.c (find_and_open_source): Also rewrite relative file
6665         names.
6666
6667 2019-04-26  Amos Bird  <amosbird@gmail.com>
6668
6669         * annotate.c (annotate_thread_exited): Add "thread-exited"
6670         annotation.
6671
6672 2019-06-06  Tom Tromey  <tromey@adacore.com>
6673
6674         * maint.h (class scoped_command_stats): Use
6675         DISABLE_COPY_AND_ASSIGN.
6676         <print_time>: New method.
6677         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
6678         print_time.
6679         (scoped_command_stats::print_time): New method.
6680
6681 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6682
6683         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
6684         instructions of lengths 6 or 8 bytes.
6685
6686 2019-06-04  Pedro Alves  <palves@redhat.com>
6687
6688         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
6689
6690         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
6691         * breakpoint.c (condition_completer): Likewise.
6692         * cli/cli-dump.c (scan_expression): Likewise.
6693         * common/filestuff.c (mkdir_recursive): Likewise.
6694         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
6695         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
6696         (gdb_abspath): Likewise.
6697         * compile/compile-cplus-types.c
6698         (compile_cplus_instance::decl_name): Likewise.
6699         * completer.c (complete_explicit_location):
6700         (signal_completer, reg_or_group_completer_1): Likewise.
6701         * cp-support.c (cp_remove_params_if_any): Likewise.
6702         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
6703         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
6704         * infcmd.c (strip_bg_char): Likewise.
6705         * linespec.c (copy_token_string): Likewise.
6706         * mi/mi-main.c (output_cores): Likewise.
6707         * psymtab.c (psymtab_search_name):
6708         * symfile.c (test_set_ext_lang_command): Likewise.
6709         * target.c (target_fileio_read_stralloc): Likewise.
6710         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
6711         * value.c (complete_internalvar): Likewise.
6712
6713 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
6714
6715         Add objfile property to gdb.Type.
6716         * NEWS: Mention Python API addition.
6717         * python/py-type.c (typy_get_objfile): New method.
6718
6719 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6720
6721         * NEWS: Mention the new set|show style [title|highlight].
6722         Mention changes to "show style", "help" and "apropos".
6723
6724 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6725
6726         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
6727         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
6728         instead of print_help_for_command.
6729         (print_doc_of_command): New function.
6730         (help_list): Add 'apropos -v word' suggestion.
6731         (print_help_for_command): Style the command name using title style.
6732         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
6733         (_initialize_cli_cmds): Describe -v in apropos_command help.
6734
6735 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6736
6737         * cli/cli-style.h (cli_style_option): Add name in constructor,
6738         add m_name class member, add constructor with intensity,
6739         add name class function.
6740         (cli_style_option::add_setshow_commands): Remove name argument.
6741         (highlight_style, title_style): New styles.
6742         * cli/cli-style.c (do_show): New function that shows a style
6743         characteristic styling the style name with itself.
6744         (set_style_name): New function.
6745         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
6746         Update all callers according to the changes in cli/cli-style.h.
6747         * utils.h (fputs_highlighted): New function.
6748         * utils.c (fputs_highlighted): Likewise.
6749
6750 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6751
6752         * NEWS: Mention new pipe command and new convenience variables.
6753
6754 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6755
6756         * cli/cli-cmds.c (pipe_command): New function.
6757         (_initialize_cli_cmds): Call add_com for pipe_command.
6758         Define | as an alias for pipe.
6759         (exit_status_set_internal_vars): New function.
6760         (shell_escape): Call exit_status_set_internal_vars.
6761         cli/cli-decode.c (find_command_name_length): Recognize | as
6762         a single character command.
6763
6764 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6765
6766         * gdbcmd.h (execute_command_to_ui_file): New declaration.
6767         top.c (execute_command_to_ui_file): New function, mostly a copy
6768         of execute_command_to_string.
6769         (execute_command_to_string): Implement by calling
6770         execute_command_to_ui_file.
6771
6772 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6773
6774         * top.h (saved_command_line): Remove declaration.
6775         * top.c (previous_saved_command_line, previous_repeat_arguments):
6776         New variables.
6777         (saved_command_line): Make static, define together with other
6778         'repeat variables'.
6779         (dont_repeat): Clear repeat_arguments.
6780         (repeat_previous, get_saved_command_line, save_command_line):
6781         New functions.
6782         (gdb_init): Initialize saved_command_line
6783         and previous_saved_command_line.
6784         * main.c (captured_main_1): Remove saved_command_line initialization.
6785         * event-top.c (handle_line_of_input): Update to use
6786         the new 'repeat' related functions instead of direct access to
6787         saved_command_line.
6788         * command.h (repeat_previous, get_saved_command_line,
6789         save_command_line): New declarations.
6790         (dont_repeat): Add comment.
6791
6792 2019-05-30  Tom Tromey  <tromey@adacore.com>
6793
6794         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
6795         Fix comment.
6796         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
6797
6798 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
6799
6800         PR cli/24587
6801         * completer.c (complete): Initialize variable word.
6802
6803 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
6804
6805         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
6806         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
6807         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
6808         'body' is NULL to the outter 'if', protecting the '!is_define'
6809         situation as well.
6810
6811 2019-05-29  Tom Tromey  <tromey@adacore.com>
6812
6813         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
6814         (dwarf_unknown): New function.
6815         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
6816         (dwarf_type_encoding_name): Use dwarf_unknown.
6817
6818 2019-05-29  Tom Tromey  <tromey@adacore.com>
6819
6820         PR c++/20020:
6821         * cp-valprint.c (cp_print_value_fields): Call
6822         cp_print_static_field inside "try".
6823
6824 2019-05-29  Tom Tromey  <tromey@adacore.com>
6825
6826         * inflow.c (struct terminal_info): Add default operator=.
6827         * configure: Rebuild.
6828         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
6829         -Wdeprecated-copy-dtor, -Wredundant-move.
6830
6831 2019-05-29  Tom Tromey  <tromey@adacore.com>
6832
6833         * NEWS: Add entry.
6834         * infcmd.c (print_return_value_1): Handle finish_print
6835         option.
6836         (show_print_finish): New function.
6837         (_initialize_infcmd): Add "set/show print finish" commands.
6838         * valprint.c (user_print_options): Initialize new member.
6839         * valprint.h (struct value_print_options) <finish_print>: New
6840         member.
6841
6842 2019-05-28  Tom Tromey  <tromey@adacore.com>
6843
6844         * ada-lang.c (ada_remove_Xbn_suffix)
6845         (find_old_style_renaming_symbol)
6846         (parse_old_style_renaming): Remove.
6847         (ada_find_renaming_symbol): Don't call
6848         find_old_style_renaming_symbol.
6849         (ada_is_renaming_symbol): Rename from
6850         ada_find_renaming_symbol.  Remove "block" parameter.  Return
6851         bool.  Now static.
6852         (ada_read_var_value): Update and simplify.
6853         * ada-exp.y (write_var_or_type): Remove old code.
6854
6855 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
6856
6857         PR gdb/25010
6858         * event-top.c: Remove include comment.
6859         * inflow.c (class scoped_ignore_sigttou): Move from here...
6860         * inflow.h (class scoped_ignore_sigttou): ...to here.
6861         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
6862         * top.c:  Remove include comment.
6863
6864 2019-05-27  Tom Tromey  <tom@tromey.com>
6865
6866         * NEWS: Fix typo.
6867
6868 2019-05-22  Tom Tromey  <tromey@adacore.com>
6869
6870         * target.c (target_follow_exec): Constify parameter.
6871         * target-delegates.c: Rebuild.
6872         * remote.c (remote_target::follow_exec): Constify parameter.
6873         * infrun.c (follow_exec): Constify parameter.
6874         * target.h (struct target_ops) <follow_exec>: Constify parameter.
6875         (target_follow_exec): Likewise.
6876
6877 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6878
6879         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
6880         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
6881
6882 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
6883
6884         * NEWS: Add debugredirect and testsuite sections.
6885
6886 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
6887
6888         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
6889         target descriptions using exclusively floating point register name
6890         aliases.
6891
6892 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
6893
6894         PR gdb/18644:
6895         * f-lang.c (build_fortran_types): Handle the case where
6896         gdbarch_floatformat_for_type returns a nullptr.
6897
6898 2019-05-21  Tom de Vries  <tdevries@suse.de>
6899
6900         PR cli/24587
6901         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
6902
6903 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6904
6905         PR gdb/18644:
6906         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
6907         16-byte floats.
6908         * i386-tdep.c (i386_floatformat_for_type): Use
6909         floatformats_ia64_quad for the 16-byte floating point component
6910         within a fortran 32-byte complex number.
6911
6912 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
6913
6914         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
6915         delete default constructor.
6916         (find_partial_die): Update to return const struct.
6917         (partial_die_parent_scope): Move variable declaration into scope
6918         of its use and change its type to auto.
6919         (guess_partial_die_structure_name): Likewise.
6920         (partial_die_info::fixup): Likewise.
6921
6922 2019-05-17  Tom Tromey  <tromey@adacore.com>
6923
6924         * source.c (find_and_open_source): Remove cast.
6925
6926 2019-05-17  Tom Tromey  <tromey@adacore.com>
6927
6928         * annotate.c (annotate_source): Make "filename" const.
6929         * annotate.h (annotate_source): Use const.
6930
6931 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6932
6933         * disasm.c (set_disassembler_options): Send errors to stderr.
6934
6935 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6936
6937         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
6938         (cli_interp_base::set_logging): Check debug_redirect.
6939         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
6940         * cli/cli-logging.c (debug_redirect): Add static variable.
6941         (pop_output_files): Add default param.
6942         (handle_redirections): Print debug setting.
6943         (show_logging_command): Likewise.
6944         (_initialize_cli_logging): Add debugredirect command.
6945         * interps.c (current_interp_set_logging): Add debug_redirect
6946         parameter.
6947         * interps.h (set_logging): Add debug_redirect parameter.
6948         (current_interp_set_logging): Likewise.
6949         * mi/mi-common.h: Likewise.
6950         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
6951
6952 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
6953             Tom Tromey  <tromey@adacore.com>
6954
6955         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
6956         directly.
6957         * cli/cli-interp.h (make_logging_output): Remove declaration.
6958         * cli/cli-logging.c (make_logging_output): Remove function.
6959         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
6960         directly.
6961         * ui-file.c (tee_file::tee_file): Remove bools.
6962         (tee_file::~tee_file): Remove deletes.
6963         * ui-file.h (tee_file): Remove bools.
6964
6965 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
6966
6967         * mi/mi-cmds.h (mi_cmd_complete): New function.
6968         * mi/mi-main.c (mi_cmd_complete): Likewise.
6969         * mi/mi-cmds.c: Define new MI command -complete.
6970         * NEWS: Mention new -complete command.
6971
6972 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
6973
6974         * completer.h (complete): New function.
6975         * completer.c (complete): Likewise.
6976         * cli/cli-cmds.c: (complete_command): Update to use new complete()
6977         function defined in completer.h.
6978
6979 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
6980
6981         * MAINTAINERS (Write After Approval): Add myself.
6982
6983 2019-05-17  Tom de Vries  <tdevries@suse.de>
6984
6985         PR gdb/24094
6986         * dwarf2read.c (struct cu_partial_die_info): New struct.
6987         (find_partial_die): Return cu_partial_die_info.
6988         (partial_die_parent_scope, guess_partial_die_structure_name)
6989         (partial_die_info::fixup): Handle new return type of find_partial_die.
6990
6991 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6992
6993         PR breakpoints/24541
6994         * stap-probe.c (stap_parse_register_operand): Make "regname" an
6995         "std::string", simplifying the algorithm.
6996
6997 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
6998
6999         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
7000         (stap_static_probe_ops::get_probes): Likewise.
7001
7002 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7003
7004         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
7005         '-')" and "else if".
7006         (stap_parse_single_operand): Join checks for
7007         "gdbarch_stap_parse_special_token_p" and
7008         "gdbarch_stap_parse_special_token" in the same "if" statement.
7009         Invert check when verifying for operation on register
7010         displacement.
7011
7012 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7013
7014         * stap-probe.c (stap_get_opcode): Update comment.
7015         (stap_get_expected_argument_type): Likewise.
7016         (handle_stap_probe): Likewise.
7017
7018 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
7019
7020         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
7021         return type to 'bool'.  Adjust comment.  Use 'bool' when
7022         appropriate.
7023         (i386_stap_parse_special_token_three_arg_disp): Likewise.
7024         * stap-probe.c (stap_parse_argument_1): Likewise.
7025         (stap_is_operator): Likewise.
7026         (stap_is_generic_prefix): Likewise.
7027         (stap_is_register_prefix): Likewise.
7028         (stap_is_register_indirection_prefix): Likewise.
7029         (stap_is_integer_prefix): Likewise.
7030         (stap_generic_check_suffix): Likewise.
7031         (stap_check_integer_suffix): Likewise.
7032         (stap_check_register_suffix): Likewise.
7033         (stap_check_register_indirection_suffix): Likewise.
7034         (stap_parse_register_operand): Likewise.
7035         (stap_parse_single_operand): Likewise.
7036         (stap_parse_argument_1): Likewise.
7037         (stap_probe::get_argument_count): Likewise.
7038         (stap_is_operator): Likewise.
7039
7040 2019-05-16  Tom Tromey  <tromey@adacore.com>
7041
7042         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
7043         keyword to foreach.
7044
7045 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
7046
7047         * linux-thread-db.c (try_thread_db_load_1): Change return type
7048         to bool.
7049         (try_thread_db_load): Likewise.
7050         (try_thread_db_load_from_pdir_1): Likewise.
7051         (try_thread_db_load_from_pdir): Likewise.
7052         (try_thread_db_load_from_sdir): Likewise.
7053         (try_thread_db_load_from_dir): Likewise.
7054         (thread_db_load_search): Likewise.
7055         (has_libpthread): Likewise.
7056         (thread_db_load): Likewise.
7057
7058 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
7059
7060         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
7061         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
7062         NULL, and complain/return if that's the case.
7063
7064 2019-05-15  John Darrington <john@darrington.wattle.id.au>
7065
7066         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
7067         (advance, posn, abstract_read_memory): New functions.
7068         [struct mem_read_abstraction]: New struct.
7069         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
7070
7071 2019-05-14  Tom Tromey  <tromey@adacore.com>
7072
7073         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
7074         value is not lval_memory.
7075
7076 2019-05-14  Tom Tromey  <tromey@adacore.com>
7077
7078         * solib.c (info_sharedlibrary_command): Style the file name.
7079
7080 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
7081
7082         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
7083         (aarch64_vnv_type): Likewise.
7084         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
7085         * common/tdesc.c: Likewise.
7086         * common/tdesc.h (enum tdesc_type_kind): Likewise.
7087         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
7088         * features/aarch64-fpu.xml: Add ieee half view.
7089         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
7090         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
7091         * gdbtypes.h (struct builtin_type): Likewise.
7092         (struct objfile_type): Likewise.
7093
7094 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
7095
7096         * language.c (language_sniff_from_mangled_name): Fix "langauge"
7097         typo.
7098         * location.h (string_to_event_location): Likewise.
7099
7100 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
7101
7102         GDB 8.3 released.
7103
7104 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7105
7106         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
7107         New variable declaration.
7108         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
7109         New variable.
7110         (print_one_breakpoint): Use ui_out::test_flags and new global
7111         variable to compute use_fixed_output.
7112         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
7113         Remove.
7114         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
7115         (mi_multi_location_breakpoint_output_fixed): Remove.
7116         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
7117         new variable.
7118         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
7119         fix_multi_location_breakpoint_output flag if version >= 3.
7120         * ui-out.h (enum ui_out_flag)
7121         <fix_multi_location_breakpoint_output>: New enumerator.
7122
7123 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
7124
7125         * contrib/cc-with-tweaks.sh: Validate dwz's work.
7126
7127 2019-05-10  Tom Tromey  <tromey@adacore.com>
7128
7129         * ada-lang.c (catch_ada_completer): New function.
7130         (_initialize_ada_language): Use it.
7131
7132 2019-05-10  Tom Tromey  <tromey@adacore.com>
7133
7134         * thread.c (print_thread_info): Make "requested_threads" const.
7135         * gdbthread.h (print_thread_info): Make "requested_threads"
7136         const.
7137         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
7138         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
7139
7140 2019-05-08  Tom Tromey  <tom@tromey.com>
7141
7142         * gdbtypes.c (objfile_type_data): Change type.
7143         (objfile_type, _initialize_gdbtypes): Update.
7144
7145 2019-05-08  Tom Tromey  <tom@tromey.com>
7146
7147         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
7148         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
7149         (_initialize_dwarf2_frame): Update.
7150
7151 2019-05-08  Tom Tromey  <tom@tromey.com>
7152
7153         * objc-lang.c (objc_objfile_data): Change type.
7154         (find_methods): Update.
7155         (_initialize_objc_lang): Remove.
7156
7157 2019-05-08  Tom Tromey  <tom@tromey.com>
7158
7159         * stabsread.c (rs6000_builtin_type_data): Change type.
7160         (rs6000_builtin_type, _initialize_stabsread): Update.
7161
7162 2019-05-08  Tom Tromey  <tom@tromey.com>
7163
7164         * mips-tdep.c (mips_pdr_data): Remove.
7165         (_initialize_mips_tdep): Update.
7166
7167 2019-05-08  Tom Tromey  <tom@tromey.com>
7168
7169         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
7170         (hppa_init_objfile_priv_data, read_unwind_info)
7171         (find_unwind_entry, _initialize_hppa_tdep): Update.
7172
7173 2019-05-08  Tom Tromey  <tom@tromey.com>
7174
7175         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
7176         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
7177         on obstack.
7178         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
7179
7180 2019-05-08  Tom Tromey  <tom@tromey.com>
7181
7182         * mdebugread.c (basic_type_data): Change type.
7183         (basic_type, _initialize_mdebugread): Update.
7184
7185 2019-05-08  Tom Tromey  <tom@tromey.com>
7186
7187         * common/gdb_unique_ptr.h (struct noop_deleter): New.
7188
7189 2019-05-08  Tom Tromey  <tom@tromey.com>
7190
7191         * nto-tdep.c (nto_inferior_data_reg): Change type.
7192         (nto_inferior_data): Update.
7193         (nto_inferior_data_cleanup, nto_new_inferior_data)
7194         (_initialize_nto_tdep): Remove.
7195         * nto-tdep.h (struct nto_inferior_data): Add initializers.
7196
7197 2019-05-08  Tom Tromey  <tom@tromey.com>
7198
7199         * ada-lang.c (struct ada_inferior_data): Add initializers.
7200         (ada_inferior_data): Change type.
7201         (ada_inferior_data_cleanup): Remove.
7202         (get_ada_inferior_data, ada_inferior_exit)
7203         (struct ada_pspace_data): Add initializers, destructor.
7204         (ada_pspace_data_handle): Change type.
7205         (get_ada_pspace_data): Update.
7206         (ada_pspace_data_cleanup): Remove.
7207
7208 2019-05-08  Tom Tromey  <tom@tromey.com>
7209
7210         * coffread.c (struct coff_symfile_info): Add initializers.
7211         (coff_objfile_data_key): Move lower.  Change type.
7212         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
7213         Update.
7214         (coff_free_info): Remove.
7215
7216 2019-05-08  Tom Tromey  <tom@tromey.com>
7217
7218         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
7219         (fbsd_pspace_data_handle): Move lower.  Change type.
7220         (get_fbsd_pspace_data): Update.
7221         (fbsd_pspace_data_cleanup): Remove.
7222         (_initialize_fbsd_tdep): Update.
7223
7224 2019-05-08  Tom Tromey  <tom@tromey.com>
7225
7226         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
7227         (get_ada_tasks_pspace_data): Update.
7228         (ada_tasks_pspace_data_cleanup): Remove.
7229         (_initialize_tasks): Update.
7230         (ada_tasks_inferior_data_handle): Change type.
7231         (get_ada_tasks_inferior_data): Update.
7232         (ada_tasks_inferior_data_cleanup): Remove.
7233         (struct ada_tasks_pspace_data): Add initializers.
7234
7235 2019-05-08  Tom Tromey  <tom@tromey.com>
7236
7237         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
7238         * symfile-debug.c (debug_sym_get_probes): Change type.
7239         * stap-probe.c (handle_stap_probe):
7240         (stap_static_probe_ops::get_probes): Change type.
7241         * probe.h (class static_probe_ops) <get_probes>: Change type.
7242         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
7243         (parse_probes_in_pspace): Update.
7244         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
7245         Update.
7246         (any_static_probe_ops::get_probes): Change type.
7247         * elfread.c (elfread_data): New typedef.
7248         (probe_key): Change type.
7249         (elf_get_probes): Likewise.  Update.
7250         (probe_key_free): Remove.
7251         (_initialize_elfread): Update.
7252         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
7253         Change type.
7254         (dtrace_process_dof_probe, dtrace_process_dof)
7255         (dtrace_static_probe_ops::get_probe): Change type.
7256
7257 2019-05-08  Tom Tromey  <tom@tromey.com>
7258
7259         * xcoffread.c (struct xcoff_symfile_info): Rename from
7260         coff_symfile_info.  Add initializers.
7261         (xcoff_objfile_data_key): Move lower.  Change type.
7262         (XCOFF_DATA): Rewrite.
7263         (xcoff_free_info): Remove.
7264         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
7265         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
7266         (xcoff_initial_scan): Update.
7267
7268 2019-05-08  Tom Tromey  <tom@tromey.com>
7269
7270         * solib-svr4.c (struct svr4_info): Add initializers and
7271         destructor.
7272         <probes_table>: Now an htab_up.
7273         (solib_svr4_pspace_data): Change type.
7274         (free_probes_table): Simplify.
7275         (~svr4_info): Rename from svr4_pspace_data_cleanup.
7276         (get_svr4_info, probes_table_htab_remove_objfile_probes)
7277         (probes_table_remove_objfile_probes, register_solib_event_probe)
7278         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
7279         (_initialize_svr4_solib): Update.
7280
7281 2019-05-08  Tom Tromey  <tom@tromey.com>
7282
7283         * remote.c (remote_pspace_data): Change type.
7284         (remote_pspace_data_cleanup): Remove.
7285         (get_remote_exec_file, set_pspace_remote_exec_file)
7286         (_initialize_remote): Update.
7287
7288 2019-05-08  Tom Tromey  <tom@tromey.com>
7289
7290         * breakpoint.c (breakpoint_objfile_key): Change type.
7291         (get_breakpoint_objfile_data): Update.
7292         (free_breakpoint_objfile_data): Remove.
7293         (_initialize_breakpoint): Update.
7294
7295 2019-05-08  Tom Tromey  <tom@tromey.com>
7296
7297         * linux-tdep.c (struct linux_info): Add initializers.
7298         (linux_inferior_data): Move.  Change type.
7299         (invalidate_linux_cache_inf): Update.
7300         (linux_inferior_data_cleanup): Remove.
7301         (get_linux_inferior_data, _initialize_linux_tdep): Update.
7302
7303 2019-05-08  Tom Tromey  <tom@tromey.com>
7304
7305         * auxv.c (auxv_inferior_data): Move.  Change type.
7306         (auxv_inferior_data_cleanup): Remove.
7307         (invalidate_auxv_cache_inf): Rewrite.
7308         (get_auxv_inferior_data, _initialize_auxv): Update.
7309
7310 2019-05-08  Tom Tromey  <tom@tromey.com>
7311
7312         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
7313         (symfile_debug_objfile_data_key): Change type.
7314         (symfile_debug_installed, debug_qf_has_symbols)
7315         (debug_qf_find_last_source_symtab)
7316         (debug_qf_forget_cached_source_info)
7317         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
7318         (debug_qf_print_stats, debug_qf_dump)
7319         (debug_qf_expand_symtabs_for_function)
7320         (debug_qf_expand_all_symtabs)
7321         (debug_qf_expand_symtabs_with_fullname)
7322         (debug_qf_map_matching_symbols)
7323         (debug_qf_expand_symtabs_matching)
7324         (debug_qf_find_pc_sect_compunit_symtab)
7325         (debug_qf_map_symbol_filenames)
7326         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
7327         (debug_sym_new_init, debug_sym_init, debug_sym_read)
7328         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
7329         (debug_sym_read_linetable, debug_sym_relocate): Update.
7330         (symfile_debug_free_objfile): Remove.
7331         (install_symfile_debug_logging, _initialize_symfile_debug):
7332         Update.
7333
7334 2019-05-08  Tom Tromey  <tom@tromey.com>
7335
7336         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
7337         allocate_on_obstack.
7338         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
7339         (get_dwarf2_per_objfile): Update.
7340         (set_dwarf2_per_objfile): Remove.
7341         (dwarf2_has_info, dwarf2_get_section_info): Update.
7342         (dwarf2_free_objfile): Remove.
7343         (_initialize_dwarf2_read): Update.
7344
7345 2019-05-08  Tom Tromey  <tom@tromey.com>
7346
7347         * auto-load.c (struct auto_load_pspace_info): Add destructor and
7348         initializers.
7349         <unsupported_script_warning_printed,
7350         script_not_found_warning_printed>: Now bool.
7351         (auto_load_pspace_data): Change type.
7352         (~auto_load_pspace_info): Rename from
7353         auto_load_pspace_data_cleanup.
7354         (get_auto_load_pspace_data, init_loaded_scripts_info)
7355         (clear_section_scripts, maybe_print_unsupported_script_warning)
7356         (maybe_print_script_not_found_warning, _initialize_auto_load):
7357         Update.
7358
7359 2019-05-08  Tom Tromey  <tom@tromey.com>
7360
7361         * objfiles.c (objfile_pspace_info): Add destructor and
7362         initializers.
7363         (objfiles_pspace_data): Change type.
7364         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
7365         (get_objfile_pspace_data): Update.
7366         (objfiles_bfd_data): Change type.
7367         (get_objfile_bfd_data): Update.
7368         (objfile_bfd_data_free, _initialize_objfiles): Remove.
7369
7370 2019-05-08  Tom Tromey  <tom@tromey.com>
7371
7372         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
7373         Change type.
7374         (get_catch_syscall_inferior_data): Update.
7375         (catch_syscall_inferior_data_cleanup): Remove.
7376         (_initialize_break_catch_syscall): Update.
7377
7378 2019-05-08  Tom Tromey  <tom@tromey.com>
7379
7380         * inflow.c (struct terminal_info): Add destructor and
7381         initializers.
7382         (inflow_inferior_data): Change type.
7383         (~terminal_info): Rename from inflow_inferior_data_cleanup.
7384         (get_inflow_inferior_data, inflow_inferior_exit)
7385         (swap_terminal_info, _initialize_inflow): Update.
7386
7387 2019-05-08  Tom Tromey  <tom@tromey.com>
7388
7389         * target-dcache.c (target_dcache_cleanup): Remove.
7390         (target_dcache_aspace_key): Change type.
7391         (target_dcache_init_p, target_dcache_invalidate)
7392         (target_dcache_get, target_dcache_get_or_init)
7393         (_initialize_target_dcache): Update.
7394         * dcache.h (struct dcache_deleter): New.
7395
7396 2019-05-08  Tom Tromey  <tom@tromey.com>
7397
7398         * symtab.c (struct symbol_cache): Add destructor and
7399         initializers.
7400         (symbol_cache_key): Move.  Change type.
7401         (make_symbol_cache, free_symbol_cache): Remove.
7402         (get_symbol_cache): Update.
7403         (symbol_cache_cleanup): Remove.
7404         (ALL_PSPACES, symbol_cache_flush)
7405         (maintenance_print_symbol_cache)
7406         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
7407         Update.
7408
7409 2019-05-08  Tom Tromey  <tom@tromey.com>
7410
7411         * symtab.c (struct main_info): Add destructor and initializers.
7412         (main_progspace_key): Move.  Change type.
7413         (get_main_info): Update.
7414         (main_info_cleanup): Remove.
7415         (_initialize_symtab): Update.
7416
7417 2019-05-08  Tom Tromey  <tom@tromey.com>
7418
7419         * registry.h (DECLARE_REGISTRY): Define the _key class.
7420
7421 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7422
7423         * NEWS: Merge two 'New commands' sections.
7424
7425 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
7426
7427         * ada-valprint.c (ada_val_print_gnat_array): Remove language
7428         parameter and use Ada language definition instead.
7429         (ada_val_print_ptr): Remove unused language parameter.
7430         (ada_val_print_num): Remove language parameter and use Ada language
7431         definition instead.
7432         (ada_val_print_enum, ada_val_print_flt): Remove unused language
7433         parameter.
7434         (ada_val_print_struct_union, ada_val_print_ref): Remove language
7435         parameter and use Ada language definition instead.
7436         (ada_val_print_1): Update all ada_val_print_xxx calls.
7437         Remove language parameter.
7438         (ada_val_print): Update ada_val_print_1 call.
7439
7440 2019-05-08  Tom Tromey  <tromey@adacore.com>
7441
7442         * remote.c (remote_hw_watchpoint_limit)
7443         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
7444         Now static.
7445
7446 2019-05-08  Tom Tromey  <tromey@adacore.com>
7447
7448         * maint.c (_initialize_maint_cmds): Move initialization code to
7449         remote.c.
7450         (watchdog, show_watchdog): Move to remote.c.
7451         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
7452         "watchdog" static.
7453         (_initialize_remote): Move initialization code from maint.c.
7454         * defs.h (watchdog): Don't declare.
7455
7456 2019-05-08  Tom Tromey  <tromey@adacore.com>
7457
7458         * tui/tui-interp.c: Include main.h.
7459         * interps.c: Include main.h.
7460         * main.h (interpreter_p): Declare.
7461         * defs.h (interpreter_p): Don't declare.
7462
7463 2019-05-08  Tom Tromey  <tromey@adacore.com>
7464
7465         * dwarf2loc.c: Include dwarf2read.h.
7466         * defs.h (read_unsigned_leb128): Don't declare.
7467         * dwarf2read.h (read_unsigned_leb128): Declare.
7468
7469 2019-05-08  Tom Tromey  <tromey@adacore.com>
7470
7471         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
7472         method.
7473
7474 2019-05-08  Tom Tromey  <tromey@adacore.com>
7475
7476         * utils.c (fputs_maybe_filtered): Reset style after paging, even
7477         when no wrap column is set.
7478
7479 2019-05-08  Tom Tromey  <tromey@adacore.com>
7480
7481         * c-lang.c (c_get_string): Handle non-C-style arrays.
7482
7483 2019-05-08  Tom Tromey  <tromey@adacore.com>
7484
7485         * typeprint.c (print_offset_data::update): Print the bit offset,
7486         not the number of bits remaining.
7487
7488 2019-05-08  Tom Tromey  <tromey@adacore.com>
7489
7490         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
7491         padding at end of comment.
7492
7493 2019-05-08  Tom Tromey  <tromey@adacore.com>
7494
7495         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
7496         Compare main types.
7497
7498 2019-05-06  Tom Tromey  <tom@tromey.com>
7499
7500         * common/scoped_mmap.c: Include common-defs.h.
7501         * common/scoped_mmap.h: Don't include config.h.
7502
7503 2019-05-04  Tom Tromey  <tom@tromey.com>
7504
7505         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
7506         (struct aarch64_call_info): Add initializers.
7507         <si>: Now a std::vector.
7508         (pass_on_stack, aarch64_push_dummy_call): Update.
7509
7510 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
7511             Tom Tromey  <tom@tromey.com>
7512
7513         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
7514         (ppc_threads): Now a std::vector.  Now static.
7515         (hwdebug_find_thread_points_by_tid)
7516         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
7517         Update.
7518
7519 2019-05-04  Tom Tromey  <tom@tromey.com>
7520
7521         * arc-tdep.c (arc_tdesc_init): Return bool.
7522
7523 2019-05-04  Tom Tromey  <tom@tromey.com>
7524
7525         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
7526         Use gdb_assert_not_reached.
7527
7528 2019-05-04  Tom Tromey  <tom@tromey.com>
7529
7530         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
7531         "false".
7532
7533 2019-05-04  Tom Tromey  <tom@tromey.com>
7534
7535         * arc-tdep.c (arc_tdesc_init): Use bool.
7536
7537 2019-05-04  Tom Tromey  <tom@tromey.com>
7538
7539         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
7540
7541 2019-05-04  Tom Tromey  <tom@tromey.com>
7542
7543         * cli/cli-cmds.c (valid_command_p): Return bool.
7544
7545 2019-05-04  Tom Tromey  <tom@tromey.com>
7546
7547         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
7548         * command.h (valid_user_defined_cmd_name_p): Channge return type.
7549
7550 2019-05-04  Raul Tambre  <raul@tambre.ee>
7551
7552         * python/lib/gdb/prompt.py (_ExtendedPrompt)
7553         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
7554         operator for comparison.
7555
7556 2019-05-04  Tom Tromey  <tom@tromey.com>
7557
7558         * psymtab.c (psymbol_name_matches, match_partial_symbol)
7559         (lookup_partial_symbol, print_partial_symbols)
7560         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
7561         (psymbol_compare): Update.
7562         (add_psymbol_to_bcache): Clear the entire psymbol.
7563         (maintenance_check_psymtabs): Update.
7564         * psympriv.h (struct partial_symbol): Don't derive from
7565         general_symbol_info.
7566         <obj_section, unrelocated_address, address,
7567         set_unrelocated_address>: Update.
7568         <ginfo>: New member.
7569         * dwarf-index-write.c (write_psymbols, debug_names::insert)
7570         (debug_names::write_psymbols): Update.
7571
7572 2019-05-04  Tom de Vries  <tdevries@suse.de>
7573
7574         * contrib/cc-with-tweaks.sh: Support -n arg.
7575
7576 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7577
7578         * corelow.c (core_target::detach): Ensure frame cache and
7579         register caches are cleared.
7580         inferior.c (exit_inferior_1): Likewise.
7581
7582 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
7583             Tom Tromey  <tom@tromey.com>
7584
7585         * dictionary.c (collate_pending_symbols_by_language): Remove
7586         "struct" from foreach.
7587         * symtab.c (lookup_global_symbol_from_objfile)
7588         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
7589         foreach.
7590         * ser-tcp.c (net_open): Remove "struct" from foreach.
7591         * objfiles.c (objfile_relocate, objfile_rebase)
7592         (objfile_has_symbols): Remove "struct" from foreach.
7593         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
7594         from foreach.
7595         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
7596         foreach.
7597         * darwin-nat.c (thread_info_from_private_thread_info): Remove
7598         "struct" from foreach.
7599         * ada-lang.c (create_excep_cond_exprs)
7600         (ada_exception_catchpoint_cond_string): Remove "struct" from
7601         foreach.
7602
7603 2019-05-03  Tom Tromey  <tromey@adacore.com>
7604
7605         * ada-exp.y (convert_char_literal): Check suffix of each
7606         enumerator.
7607
7608 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
7609
7610         PR ada/21406:
7611         * ada-exp.y (yywrap): Don't define.
7612         * ada-lex.l (%option): Add noyywrap
7613         (yywrap): Remove.
7614
7615 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
7616
7617         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
7618         _WIN32_WINNT to the XP level, unless already defined to a higher
7619         level.
7620
7621         * unittests/parse-connection-spec-selftests.c:
7622         * ser-tcp.c:
7623         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
7624         override.
7625
7626         * symfile.c (find_separate_debug_file): Remove colon from the
7627         drive spec of DOS/Windows file names of the target, so that the
7628         file name produced from DEBUGDIR and the target's directory will
7629         be valid on DOS/Windows systems.
7630
7631 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
7632
7633         * rust-lang.c (val_print_struct): Handle printing structures
7634         containing strings.
7635
7636 2019-05-02  Tom Tromey  <tromey@adacore.com>
7637
7638         * valarith.c (_initialize_valarith): Remove.
7639
7640 2019-05-01  Tom Tromey  <tromey@adacore.com>
7641
7642         * ada-lang.c (ada_value_primitive_field): Treat more fields as
7643         bitfields.
7644
7645 2019-05-01  Tom Tromey  <tromey@adacore.com>
7646
7647         * ada-lang.c (ada_value_assign): Correctly compute starting offset
7648         for big-endian copies.
7649
7650 2019-04-30  Ali Tamur  <tamur@google.com>
7651         * gdb/dwarf2read.c (read_3_bytes): New declaration.
7652         (read_attribute_value): Added DW_FORM_strx1-4 cases.
7653         (read_3_bytes): New function.
7654
7655 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7656
7657         * windows-nat.c (main_thread_id): Delete.
7658         (handle_output_debug_string): Replace main_thread_id by
7659         current_event.dwThreadId.
7660         (fake_create_process): Likewise.
7661         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
7662         Do not set main_thread_id.
7663         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
7664         current_event.dwThreadId.
7665         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
7666
7667 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
7668
7669         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
7670         Use current_event.dwThreadId instead of main_thread_id.
7671
7672 2019-04-30  Tom Tromey  <tromey@adacore.com>
7673
7674         * ada-lang.c (ada_lookup_simple_minsyms): New function.
7675         (create_excep_cond_exprs): Iterate over program spaces.
7676         (ada_exception_catchpoint_cond_string): Examine all minimal
7677         symbols for exception types.
7678
7679 2019-04-30  Tom Tromey  <tromey@adacore.com>
7680
7681         PR c++/24470:
7682         * dwarf2read.c (process_structure_scope): Handle case where type
7683         has template parameters but no symbol was created.
7684
7685 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7686             Chris January  <chris.january@arm.com>
7687
7688         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
7689         qualifier.
7690         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
7691
7692 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7693
7694         * f-typeprint.c (f_print_type): Update rules for printing
7695         whitespace.
7696         (f_type_print_varspec_suffix): Likewise.
7697
7698 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7699             Chris January  <chris.january@arm.com>
7700
7701         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
7702         function arguments.
7703
7704 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7705
7706         * f-lang.c (build_fortran_types): Change name of void type to
7707         lower case.
7708         * f-typeprint.c (f_type_print_base): Print the name of the void
7709         type, rather than a fixed string.
7710         * f-valprint.c (f_decorations): Use lower case void string.
7711
7712 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7713             Chris January  <chris.january@arm.com>
7714
7715         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
7716         types for Fortran.
7717
7718 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7719             Chris January  <chris.january@arm.com>
7720             David Lecomber  <david.lecomber@arm.com>
7721
7722         * f-exp.y (BINOP_INTRINSIC): New token.
7723         (exp): New parser rule handling BINOP_INTRINSIC.
7724         (f77_keywords): Add new builtin procedures.
7725         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
7726         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7727         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
7728         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7729         (print_unop_subexp_f): New function.
7730         (print_binop_subexp_f): New function.
7731         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7732         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
7733         (dump_subexp_body_f): Likewise.
7734         (operator_check_f): Likewise.
7735         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
7736         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
7737
7738 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7739
7740         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
7741         UNOP_KIND.
7742         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
7743         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
7744         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
7745         (operator_length_f): New fuction.
7746         (print_subexp_f): New function.
7747         (op_name_f): New function.
7748         (dump_subexp_body_f): New function.
7749         (operator_check_f): New function.
7750         (exp_descriptor_f): Replace standard expression handling functions
7751         with new functions.
7752         * gdb/fortran-operator.def: New file.
7753         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
7754         * gdb/std-operator.def: Remove UNOP_KIND.
7755
7756 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
7757
7758         * std-operator.def: Remove unbalanced, stray double quote
7759         character.
7760
7761 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7762             Chris January  <chris.january@arm.com>
7763             Daniel Everett  <daniel.everett@arm.com>
7764             Nick Forrington  <nick.forrington@arm.com>
7765             Richard Bunt  <richard.bunt@arm.com>
7766
7767         * cp-valprint.c (cp_print_value_fields): Allow an additional level
7768         of depth when printing anonymous structs or unions.
7769         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
7770         Don't print either the top-level value, or the children if the
7771         max-depth is exceeded.
7772         (ppscm_print_children): When printing the key of a map, allow one
7773         extra level of depth.
7774         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
7775         print either the top-level value, or the children if the max-depth
7776         is exceeded.
7777         (print_children): When printing the key of a map, allow one extra
7778         level of depth.
7779         * python/py-value.c (valpy_format_string): Add max_depth keyword.
7780         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
7781         (user_print_options): Initialise max_depth field.
7782         (val_print_scalar_or_string_type_p): New function.
7783         (val_print): Check to see if the max depth has been reached.
7784         (val_print_check_max_depth): Define new function.
7785         (show_print_max_depth): New function.
7786         (_initialize_valprint): Add 'print max-depth' option.
7787         * valprint.h (struct value_print_options) <max_depth>: New field.
7788         (val_print_check_max_depth): Declare new function.
7789         * NEWS: Document new feature.
7790
7791 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7792
7793         * ada-lang.c (ada_language_defn): Initialise new field.
7794         * c-lang.c (c_is_string_type_p): New function.
7795         (c_language_defn): Initialise new field.
7796         (cplus_language_defn): Initialise new field.
7797         (asm_language_defn): Initialise new field.
7798         (minimal_language_defn): Initialise new field.
7799         * c-lang.h (c_is_string_type_p): Declare new function.
7800         * d-lang.c (d_language_defn): Initialise new field.
7801         * f-lang.c (f_is_string_type_p): New function.
7802         (f_language_defn): Initialise new field.
7803         * go-lang.c (go_is_string_type_p): New function.
7804         (go_language_defn): Initialise new field.
7805         * language.c (default_is_string_type_p): New function.
7806         (unknown_language_defn): Initialise new field.
7807         (auto_language_defn): Initialise new field.
7808         * language.h (struct language_defn) <la_is_string_type_p>: New
7809         member variable.
7810         (default_is_string_type_p): Declare new function.
7811         * m2-lang.c (m2_language_defn): Initialise new field.
7812         * objc-lang.c (objc_language_defn): Initialise new field.
7813         * opencl-lang.c (opencl_language_defn): Initialise new field.
7814         * p-lang.c (pascal_is_string_type_p): New function.
7815         (pascal_language_defn): Initialise new field.
7816         * rust-lang.c (rust_is_string_type_p): New function.
7817         (rust_language_defn): Initialise new field.
7818
7819 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7820
7821         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
7822         New field.
7823         * ada-lang.c (ada_language_defn): Initialise new field.
7824         * c-lang.c (c_language_defn): Likewise.
7825         (cplus_language_defn): Likewise.
7826         (asm_language_defn): Likewise.
7827         (minimal_language_defn): Likewise.
7828         * d-lang.c (d_language_defn): Likewise.
7829         * f-lang.c (f_language_defn): Likewise.
7830         * go-lang.c (go_language_defn): Likewise.
7831         * language.c (unknown_language_defn): Likewise.
7832         (auto_language_defn): Likewise.
7833         * m2-lang.c (m2_language_defn): Likewise.
7834         * objc-lang.c (objc_language_defn): Likewise.
7835         * opencl-lang.c (opencl_language_defn): Likewise.
7836         * p-lang.c (pascal_language_defn): Likewise.
7837         * rust-lang.c (rust_language_defn): Likewise.
7838
7839 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
7840
7841         * ada-lang.c (ada_is_character_type): Change return type to bool.
7842         (ada_is_string_type): Likewise.
7843         * ada-lang.h (ada_is_character_type): Update declaration
7844         (ada_is_string_type): Likewise.
7845
7846 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7847
7848         Support style in 'frame|thread apply'
7849
7850         * gdbcmd.h (execute_command_to_string): New term_out parameter.
7851         * record.c (record_start, record_stop): Update callers of
7852         execute_command_to_string with false.
7853         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
7854         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
7855         methods.
7856         (class string_file): New constructor with term_out parameter.
7857         Override methods term_out and can_emit_style_escape.  New member
7858         term_out.
7859         (class stdio_file): Override can_emit_style_escape.
7860         (class tee_file): Override term_out and can_emit_style_escape.
7861         * utils.h (can_emit_style_escape): Remove.
7862         * utils.c (can_emit_style_escape): Likewise.
7863         Update all callers of can_emit_style_escape (SOMESTREAM) to
7864         SOMESTREAM->can_emit_style_escape.
7865         * source-cache.c (source_cache::get_source_lines): Likewise.
7866         * stack.c (frame_apply_command_count): Call execute_command_to_string
7867         passing the term_out characteristic of the current gdb_stdout.
7868         * thread.c (thr_try_catch_cmd): Likewise.
7869         * top.c (execute_command_to_string): pass term_out parameter
7870         to construct the string_file for the command output.
7871         * ui-file.c (term_cli_styling): New function (most code moved
7872         from utils.c can_emit_style_escape).
7873         (string_file::string_file, string_file::can_emit_style_escape,
7874         stdio_file::can_emit_style_escape, tee_file::term_out,
7875         tee_file::can_emit_style_escape): New functions.
7876
7877 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7878
7879         * NEWS: Mention the new set|show may-call-functions.
7880         * infcall.c (may_call_functions_p): New variable.
7881         (show_may_call_functions_p): New function.
7882         (call_function_by_hand_dummy): Throws an error if not
7883         may-call-functions.
7884         (_initialize_infcall): Call add_setshow_boolean_cmd for
7885         may-call-functions.
7886
7887 2019-04-25  Keith Seitz  <keiths@redhat.com>
7888
7889         PR c++/24367
7890         * cp-support.c (inspect_type): Don't attempt substitutions
7891         of symbol with the same name.
7892
7893 2019-04-25  Tom Tromey  <tromey@adacore.com>
7894
7895         PR gdb/24475:
7896         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
7897         static.
7898
7899 2019-04-25  Tom Tromey  <tromey@adacore.com>
7900
7901         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
7902         rvalue reference.
7903         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
7904         (gdb_xml_parser::parse): Use std::move.
7905         * python/python-internal.h (gdbpy_convert_exception): Take a const
7906         reference.
7907         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
7908         std::move.
7909         * python/py-utils.c (gdbpy_convert_exception): Take a const
7910         reference.
7911         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7912         Use std::move.
7913         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7914         Use std::move.
7915         * mi/mi-main.c (mi_print_exception): Take a const reference.
7916         * main.c (handle_command_errors): Take a const reference.
7917         * linespec.c (parse_linespec): Use std::move.
7918         * infcall.c (run_inferior_call): Use std::move.
7919         (call_function_by_hand_dummy): Use std::move.
7920         * exec.c (try_open_exec_file): Use std::move.
7921         * exceptions.h (exception_print, exception_fprintf)
7922         (exception_print_same): Update.
7923         * exceptions.c (print_exception, exception_print)
7924         (exception_fprintf, exception_print_same): Change parameters to
7925         const reference.
7926         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
7927         * common/new-op.c: Use std::move.
7928         * common/common-exceptions.h (struct gdb_exception): Add move
7929         constructor.
7930         (struct gdb_exception_error, struct gdb_exception_quit, struct
7931         gdb_quit_bad_alloc): Change constructor to move constructor.
7932         (throw_exception): Change parameter to rvalue reference.
7933         * common/common-exceptions.c (throw_exception): Take rvalue
7934         reference.
7935         * cli/cli-interp.c (safe_execute_command): Use std::move.
7936         * breakpoint.c (insert_bp_location, location_to_sals): Use
7937         std::move.
7938
7939 2019-04-25  Tom Tromey  <tromey@adacore.com>
7940
7941         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
7942         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
7943         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
7944         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
7945         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
7946         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
7947         guile/scm-value.c: Use unpack.
7948         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
7949         gdbscm_gdb_exception.
7950         (gdbscm_throw_gdb_exception): Likewise.
7951         (struct gdbscm_gdb_exception): New.
7952         (unpack): New function.
7953         (gdbscm_wrap): Use unpack.
7954
7955 2019-04-25  Tom Tromey  <tromey@adacore.com>
7956
7957         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7958         (gdb_rl_callback_handler): Use std::move.
7959         * common/common-exceptions.h (struct gdb_exception): Add move
7960         assignment operator.
7961         (throw_exception_sjlj): Change "exception" to const reference.
7962         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
7963         (throw_exception_sjlj): Change "exception" to const reference.
7964
7965 2019-04-25  Tom Tromey  <tromey@adacore.com>
7966
7967         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
7968         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
7969         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
7970         Update.
7971         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
7972         Update.
7973         * mi/mi-interp.c (mi_interp::exec): Update.
7974         * linespec.c (parse_linespec): Update.
7975         * infcall.c (run_inferior_call): Update.
7976         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
7977         * guile/scm-symbol.c (gdbscm_lookup_symbol)
7978         (gdbscm_lookup_global_symbol): Update.
7979         * guile/scm-param.c (gdbscm_parameter_value): Update.
7980         * guile/scm-frame.c (gdbscm_frame_read_register)
7981         (gdbscm_frame_read_var): Update.
7982         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
7983         * exec.c (try_open_exec_file): Update.
7984         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
7985         (gdb_rl_callback_handler): Update.
7986         * common/common-exceptions.h (exception_none): Don't declare.
7987         * common/common-exceptions.c (exception_none): Don't define.
7988         (struct catcher) <exception>: Update.
7989         * cli/cli-interp.c (safe_execute_command): Update.
7990         * breakpoint.c (insert_bp_location, location_to_sals): Update.
7991
7992 2019-04-25  Ali Tamur  <tamur@google.com>
7993
7994         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
7995         (read_attribute_value): Likewise.
7996         (dwarf2_read_addr_index): Update comment.
7997         (read_str_index): Add DW_FORM_strx.
7998         (dwarf2_string_attr): Likewise.
7999         (dwarf2_const_value_attr): Likewise.
8000         (dump_die_shallow): Likewise.
8001         (dwarf2_fetch_constant_bytes): Likewise.
8002         (skip_form_bytes): Likewise.
8003         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
8004
8005 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
8006
8007         PR corefiles/11608
8008         PR corefiles/18187
8009         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
8010         OFFSET.  Verify if current mapping contains an ELF header.
8011         (linux_find_memory_regions_full): Adjust call to
8012         dump_mapping_p.
8013
8014 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
8015             Kang Li <kanglictf@gmail.com>
8016
8017         PR gdb/21600
8018
8019         * dwarf2-frame.c (read_initial_length): Be consistent about using
8020         unsigned representation of length.
8021         (decode_frame_entry_1): Likewise.  Check for wraparound of
8022         end pointer as well as buffer overflow.
8023
8024 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
8025
8026         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
8027         "vq".
8028
8029 2019-04-24  Tom Tromey  <tromey@adacore.com>
8030
8031         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
8032
8033 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8034
8035         * s12z-tdep.c (s12z_unwind_pc): Delete.
8036         (s12z_unwind_sp): Delete.
8037         (s12z_gdbarch_init): Don't register deleted functions with
8038         gdbarch.
8039
8040 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8041
8042         * rl78-tdep.c (rl78_unwind_sp): Delete.
8043         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
8044
8045 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8046
8047         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
8048         (xstormy16_unwind_pc): Delete.
8049         (xstormy16_dummy_id): Delete.
8050         (xstormy16_gdbarch_init): Don't register deleted functions with
8051         gdbarch.
8052
8053 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8054
8055         * vax-tdep.c (vax_unwind_pc): Delete.
8056         (vax_gdbarch_init): Don't register deleted function with gdbarch.
8057
8058 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8059
8060         * v850-tdep.c (v850_unwind_sp): Delete.
8061         (v850_unwind_pc): Delete.
8062         (v850_dummy_id): Delete.
8063         (v850_gdbarch_init): Don't register deleted functions with
8064         gdbarch.
8065
8066 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8067
8068         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
8069         (tilegx_unwind_pc): Delete.
8070         (tilegx_unwind_dummy_id): Delete.
8071         (tilegx_gdbarch_init): Don't register deleted functions with
8072         gdbarch.
8073
8074 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8075
8076         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
8077         (tic6x_dummy_id): Delete.
8078         (tic6x_gdbarch_init): Don't register deleted functions with
8079         gdbarch.
8080
8081 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8082
8083         * sparc-tdep.c (sparc_unwind_pc): Delete.
8084         (sparc32_gdbarch_init): Don't register deleted function with
8085         gdbarch.
8086
8087 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8088
8089         * sh-tdep.c (sh_unwind_sp): Delete.
8090         (sh_unwind_pc): Delete.
8091         (sh_dummy_id): Delete.
8092         (sh_gdbarch_init): Don't register deleted functions with
8093         gdbarch.
8094
8095 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8096
8097         * score-tdep.c (score_unwind_sp): Delete.
8098         (score_unwind_pc): Delete.
8099         (score_dummy_id): Delete.
8100         (score_gdbarch_init): Don't register deleted functions with
8101         gdbarch.
8102
8103 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8104
8105         * rx-tdep.c (rx_unwind_pc): Delete.
8106         (rx_unwind_sp): Delete.
8107         (rx_dummy_id): Delete.
8108         (rx_gdbarch_init): Don't register deleted functions with
8109         gdbarch.  Update comment.
8110
8111 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8112
8113         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
8114         (rs6000_dummy_id): Delete.
8115         (rs6000_gdbarch_init): Don't register deleted functions with
8116         gdbarch.
8117
8118 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8119
8120         * or1k-tdep.c (or1k_dummy_id): Delete.
8121         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
8122
8123 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8124
8125         * nios2-tdep.c (nios2_dummy_id): Delete.
8126         (nios2_unwind_sp): Delete.
8127         (nios2_gdbarch_init): Don't register deleted functions with
8128         gdbarch.
8129
8130 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8131
8132         * nds32-tdep.c (nds32_dummy_id): Delete.
8133         (nds32_unwind_pc): Delete.
8134         (nds32_unwind_sp): Delete.
8135         (nds32_gdbarch_init): Don't register deleted functions with
8136         gdbarch.
8137
8138 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8139
8140         * msp430-tdep.c (msp430_unwind_pc): Delete.
8141         (msp430_unwind_sp): Delete.
8142         (msp430_dummy_id): Delete.
8143         (msp430_gdbarch_init): Don't register deleted functions with
8144         gdbarch.
8145
8146 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8147
8148         * moxie-tdep.c (moxie_unwind_sp): Delete.
8149         (moxie_unwind_pc): Delete.
8150         (moxie_dummy_id): Delete.
8151         (moxie_gdbarch_init): Don't register deleted functions with
8152         gdbarch.
8153
8154 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8155
8156         * mn10300-tdep.c (mn10300_dummy_id): Delete.
8157         (mn10300_unwind_pc): Delete.
8158         (mn10300_unwind_sp): Delete.
8159         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
8160         mn10300_unwind_sp.
8161         (mn10300_frame_unwind_init): Don't register deleted functions with
8162         gdbarch.
8163
8164 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8165
8166         * mep-tdep.c (mep_unwind_pc): Delete.
8167         (mep_unwind_sp): Delete.
8168         (mep_dummy_id): Delete.
8169         (mep_gdbarch_init): Don't register deleted functions with
8170         gdbarch.
8171
8172 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8173
8174         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
8175         (m68hc11_unwind_sp): Delete.
8176         (m68hc11_gdbarch_init): Don't register deleted functions with
8177         gdbarch.
8178
8179 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8180
8181         * m32r-tdep.c (m32r_unwind_sp): Delete.
8182         (m32r_unwind_pc): Delete.
8183         (m32r_dummy_id): Delete.
8184         (m32r_gdbarch_init): Don't register deleted functions with
8185         gdbarch.
8186
8187 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8188
8189         * m32c-tdep.c (m32c_unwind_pc): Delete.
8190         (m32c_unwind_sp): Delete.
8191         (m32c_dummy_id): Delete.
8192         (m32c_gdbarch_init): Don't register deleted functions with
8193         gdbarch.
8194
8195 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8196
8197         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
8198         (lm32_unwind_pc): Delete.
8199         (lm32_dummy_id): Delete.
8200         (lm32_gdbarch_init): Don't register deleted functions with
8201         gdbarch.
8202
8203 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8204
8205         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
8206         (iq2000_unwind_pc): Delete.
8207         (iq2000_dummy_id): Delete.
8208         (iq2000_gdbarch_init): Don't register deleted functions with
8209         gdbarch.
8210
8211 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8212
8213         * nds32-tdep.c (nds32_type_align): Delete.
8214         (nds32_push_dummy_call): Use type_align instead.
8215
8216 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8217
8218         * arm-tdep.c (arm_type_align): Only handle vector override case.
8219         (arm_push_dummy_call): Use type_align.
8220         (arm_gdbarch_init): Register arm_type_align gdbarch function.
8221
8222 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
8223
8224         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
8225         case.
8226         (pass_on_stack): Use type_align.
8227         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
8228         function.
8229
8230 2019-04-23  Tom Tromey  <tromey@adacore.com>
8231
8232         * dwarf2read.c (line_header::file_name_at): Remove unused
8233         overload.
8234
8235 2019-04-23  Tom de Vries  <tdevries@suse.de>
8236
8237         PR gdb/24438
8238         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
8239         invocation.
8240
8241
8242 2019-03-27  Ali Tamur  <tamur@google.com>
8243
8244         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
8245         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
8246         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
8247         (dwarf_expr_context::get_addr_index): Likewise
8248         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
8249         (symbol_needs_eval_context::get_addr_index): Likewise
8250         (disassemble_dwarf_expression): Add DW_OP_addrx
8251         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
8252         (read_cutu_die_from_dwo): Update comment
8253         (skip_one_die): Add DW_FORM_addrx
8254         (read_attribute_value): Likewise
8255         (var_decode_location): Add DW_OP_addrx
8256         (dwarf2_const_value_attr): Add DW_FORM_addrx
8257         (dump_die_shallow): Likewise
8258         (dwarf2_fetch_constant_bytes): Likewise
8259         (decode_locdesc): Add DW_OP_addrx
8260         (skip_form_bytes): Add DW_FORM_addrx
8261
8262 2019-04-22  Ali Tamur  <tamur@google.com>
8263
8264         * MAINTAINERS (Write After Approval): Add self.
8265
8266 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
8267
8268         * solib-svr4.c (get_svr4_info): Add pspace parameter.
8269         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
8270         (open_symbol_file_object): Likewise.
8271         (svr4_default_sos): Add info parameter.
8272         (svr4_read_so_list): Likewise.
8273         (svr4_current_sos_direct): Adjust functions calls to pass down
8274         info.
8275         (svr4_current_sos_1): Add info parameter.
8276         (svr4_current_sos): Call get_svr4_info, pass info down to
8277         svr4_current_sos_1.
8278         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
8279         get_svr4_info.
8280         (svr4_in_dynsym_resolve_code): Pass current_program_space to
8281         get_svr4_info.
8282         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
8283         to get_svr4_info.
8284         (probes_table_remove_objfile_probes): Likewise.
8285         (register_solib_event_probe): Add info parameter.
8286         (solist_update_incremental): Pass info parameter down to
8287         svr4_read_so_list.
8288         (disable_probes_interface): Add info parameter.
8289         (svr4_handle_solib_event): Pass current_program_space to
8290         get_svr4_info.  Adjust disable_probes_interface cleanup.
8291         (svr4_create_probe_breakpoints): Add info parameter, pass it
8292         down to register_solib_event_probe.
8293         (svr4_create_solib_event_breakpoints): Add info parameter,
8294         pass it down to svr4_create_probe_breakpoints.
8295         (enable_break): Pass info down to
8296         svr4_create_solib_event_breakpoints.
8297         (svr4_solib_create_inferior_hook): Pass current_program_space to
8298         get_svr4_info.
8299         (svr4_clear_solib): Likewise.
8300
8301 2019-04-22  Pedro Alves  <palves@redhat.com>
8302
8303         * solib-svr4.c (svr4_free_objfile_observer): New.
8304         (probe_and_action::objfile): New field.
8305         (probes_table_htab_remove_objfile_probes)
8306         (probes_table_remove_objfile_probes): New functions.
8307         (register_solib_event_probe): Add 'objfile' parameter.  Store it
8308         in the new probe_and_action.  Don't store the probe in 'lookup'.
8309         (svr4_create_probe_breakpoints): Pass objfile to
8310         register_solib_event_probe.
8311         (_initialize_svr4_solib): Register a free_objfile observer.
8312
8313 2019-04-19  Tom Tromey  <tom@tromey.com>
8314
8315         * common/queue.h: Remove.
8316
8317 2019-04-19  Tom Tromey  <tom@tromey.com>
8318
8319         * event-loop.c: Don't include "common/queue.h".
8320
8321 2019-04-19  Tom Tromey  <tom@tromey.com>
8322
8323         * remote.c (remote_target): Use delete.
8324         * remote-notif.h: Include <list>, not "common/queue.h".
8325         (notif_client_p): Remove typedef.
8326         (remote_notif_state): Add constructor, destructor, initializer.
8327         <notif_queue>: Now a std::list.
8328         (remote_notif_state_xfree): Don't declare.
8329         * remote-notif.c (remote_notif_process, handle_notification)
8330         (remote_notif_state_allocate): Update.
8331         (~remote_notif_state): Rename from remote_notif_state_xfree.
8332
8333 2019-04-19  Tom Tromey  <tom@tromey.com>
8334
8335         * symfile.c (reread_symbols): Update.
8336         * objfiles.c (objfile_register_static_link)
8337         (objfile_lookup_static_link): Update
8338         (~objfile) Don't delete static_links.
8339         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
8340
8341 2019-04-19  Tom Tromey  <tom@tromey.com>
8342
8343         * type-stack.h (struct type_stack) <insert>: Constify string.
8344         * type-stack.c (type_stack::insert): Constify string.
8345         * gdbtypes.h (lookup_template_type): Update.
8346         (address_space_name_to_int): Update.
8347         * gdbtypes.c (address_space_name_to_int): Make space_identifier
8348         const.
8349         (lookup_template_type): Make name const.
8350         * c-exp.y: Update rules.
8351         (lex_one_token, classify_name, classify_inner_name)
8352         (c_print_token): Update.
8353         * p-exp.y: Update rules.
8354         (yylex): Update.
8355         * f-exp.y: Update rules.
8356         (yylex): Update.
8357         * d-exp.y: Update rules.
8358         (lex_one_token, classify_name, classify_inner_name): Update.
8359         * parse.c (write_dollar_variable, copy_name): Return std::string.
8360         * parser-defs.h (copy_name): Change return type.
8361         * m2-exp.y: Update rules.
8362         (yylex): Update.
8363         * go-exp.y (lex_one_token): Update.
8364         Update rules.
8365         (classify_unsafe_function, classify_packaged_name)
8366         (classify_name, yylex): Update.
8367
8368 2019-04-19  Sergei Trofimovich <siarheit@google.com>
8369
8370         * configure.ac: add --enable-source-highlight switch.
8371         * configure: Regenerate.
8372         * top.c (print_gdb_version): plumb --enable-source-highlight
8373         status to "show configuration".
8374
8375 2019-04-19  Tom Tromey  <tromey@adacore.com>
8376
8377         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
8378         Check ADA_TYPE_P.
8379         (empty_record, ada_template_to_fixed_record_type_1)
8380         (template_to_static_fixed_type)
8381         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
8382         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
8383         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
8384         macros.
8385
8386 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
8387
8388         PR symtab/24423:
8389         * source.c (print_source_lines_base): Advance "iter" when a
8390         control character is seen.
8391
8392 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8393
8394         * inferior.h (struct infcall_suspend_state_deleter):
8395         Catch exception in destructor to avoid crash.
8396
8397 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8398
8399         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
8400         close to the add_com "shell".
8401
8402 2019-04-18  Tom Tromey  <tromey@adacore.com>
8403
8404         * process-stratum-target.h (class process_stratum_target)
8405         <stratum>: Add "final".
8406
8407 2019-04-17  Tom Tromey  <tromey@adacore.com>
8408
8409         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
8410         against nullptr before use.
8411
8412 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
8413
8414         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
8415
8416 2019-04-17  Jim Wilson  <jimw@sifive.com>
8417             Andrew Burgess  <andrew.burgess@embecosm.com>
8418
8419         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
8420         code read might fail, assume 4-byte breakpoint in that case.
8421
8422 2019-04-15  Leszek Swirski  <leszeks@google.com>
8423
8424         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
8425         rather than a hand-rolled POD check when checking for forced MEMORY
8426         classification.
8427
8428 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8429
8430         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
8431         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
8432         function.
8433         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
8434         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
8435         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
8436         declaration.
8437
8438 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8439
8440         * aarch64-linux-nat.c
8441         (aarch64_linux_nat_target::thread_architecture): Add override.
8442         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
8443         each VQ.
8444
8445 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
8446
8447         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
8448
8449 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
8450
8451         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
8452         target types of size 96-bits, add some additional comments, and
8453         check that the builtin type we found was the correct size.
8454
8455 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
8456
8457         * utils.c (prompt_for_continue): Don't restore the styling at the
8458         end, as applied_style has the wrong value.  This fixes styling in
8459         long lists of file names that are interrupted by the "Continue?"
8460         prompt.
8461
8462 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
8463
8464         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
8465         * c-lang.c (c_language_defn): Likewise.
8466         (cplus_language_defn): Likewise.
8467         (asm_language_defn): Likewise.
8468         (minimal_language_defn): Likewise.
8469         * d-lang.c (d_language_defn): Likewise.
8470         * f-lang.c (f_language_defn): Likewise.
8471         * go-lang.c (go_language_defn): Likewise.
8472         * language.c (unknown_language_defn): Likewise.
8473         (auto_language_defn): Likewise.
8474         * language.h (struct language_defn): Remove la_magic field.
8475         (LANG_MAGIC): Delete.
8476         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
8477         * objc-lang.c (objc_language_defn): Likewise.
8478         * opencl-lang.c (opencl_language_defn): Likewise.
8479         * p-lang.c (pascal_language_defn): Likewise.
8480         * rust-lang.c (rust_language_defn): Likewise.
8481
8482 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8483
8484         * riscv-tdep.c (riscv_type_align): New function.
8485         (riscv_type_alignment): Delete.
8486         (riscv_arg_location): Use 'type_align'.
8487         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
8488
8489 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8490
8491         * gdbtypes.c (type_align): A struct with no non-static fields also
8492         has alignment of 1.
8493
8494 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
8495
8496         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
8497         component to 0.
8498         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
8499         member.
8500         (riscv_struct_info::analyse): New implementation using new
8501         analyse_inner member function.
8502         (riscv_struct_info::field_offset): New member function.
8503         (riscv_struct_info::m_offsets): New member variable.
8504         (riscv_struct_info::analyse_inner): New private member function,
8505         takes the old implementation of riscv_struct_info::analyse but
8506         extended to track field offsets.
8507         (riscv_call_arg_struct): Update the struct folding special cases
8508         to handle cases where empty C++ structs, which are non-zero
8509         length, are found.
8510         (riscv_arg_location): Initialise the length of each location, a
8511         non-zero length now indicates the location is in use.
8512         (riscv_push_dummy_call): Allow for the first location having a
8513         non-zero offset when setting up arguments.
8514         (riscv_return_value): Likewise, but for return values.
8515
8516 2019-04-11  Tom Tromey  <tromey@adacore.com>
8517
8518         * utils.c (internal_vproblem): Make "msg" const.
8519
8520 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
8521
8522         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
8523         * trad-frame.c (trad_frame_reset_saved_regs): New function.
8524         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
8525         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
8526
8527 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
8528
8529         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
8530         function.
8531         (fill_gregset): Call amd64_linux_collect_native_gregset instead
8532         of amd64_collect_native_gregset.
8533         (amd64_linux_nat_target::store_registers): Likewise.
8534
8535 2019-04-10  Tom Tromey  <tom@tromey.com>
8536
8537         * symtab.c (lookup_global_symbol_from_objfile)
8538         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
8539         * objfiles.h (class separate_debug_iterator): New.
8540         (class separate_debug_range): New.
8541         (struct objfile) <separate_debug_objfiles>: New method.
8542         (objfile_separate_debug_iterate): Don't declare.
8543         * objfiles.c (separate_debug_iterator::operator++): Rename from
8544         objfile_separate_debug_iterate.
8545         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
8546         iterator.
8547         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
8548         iterator.
8549
8550 2019-04-10  Tom Tromey  <tom@tromey.com>
8551
8552         * symfile.c (reread_symbols): Remove old comment.
8553         * objfiles.c (free_all_objfiles): Fix a typo.
8554
8555 2019-04-10  Tom Tromey  <tom@tromey.com>
8556
8557         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
8558         * minsyms.c (lookup_minimal_symbol): Use foreach.
8559         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
8560         (lookup_minimal_symbol_solib_trampoline): Likewise.
8561         * symfile.c (reread_symbols): Use foreach.
8562
8563 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
8564             Tom Tromey  <tromey@adacore.com>
8565
8566         PR rust/24414:
8567         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
8568         (rust_lex_int_test): Change "value" to be LONGEST.
8569         (rust_lex_tests): Add test for long integer literal.
8570
8571 2019-04-09  Tom Tromey  <tromey@adacore.com>
8572
8573         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
8574         to bool.
8575         (extended_remote_target::attach): Update.
8576         (remote_target::remote_notice_new_inferior): Update.
8577         (remote_target::add_current_inferior_and_thread): Update.
8578         * inferior.c (exit_inferior_1): Use "false".
8579         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
8580
8581 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
8582
8583         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
8584         the "start" command.
8585
8586 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8587
8588         * python/py-inferior.c (infpy_thread_from_thread_handle):
8589         Adjust comments to reflect renaming of thread_from_thread_handle
8590         to thread_from_handle.  Adjust keywords.  Fix type error message.
8591         (inferior_object_methods): Add thread_from_handle.  Retain
8592         thread_from_thread_handle, but mark it as deprecated.
8593
8594 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8595
8596         * gdbthread.h (find_thread_by_handle): Revise declaration.
8597         * thread.c (find_thread_by_handle): Likewise.  Adjust
8598         implementation too.
8599         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
8600         support for buffer objects as handles.
8601
8602 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8603
8604         * python/py-infthread.c (thpy_thread_handle): New function.
8605         (thread_object_methods): Register thpy_thread_handle.
8606
8607 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
8608
8609         * gdbthread.h (thread_to_thread_handle): Declare.
8610         * thread.c (gdbtypes.h): Include.
8611         (thread_to_thread_handle): New function.
8612
8613         * target.h (struct target_ops): Add thread_info_to_thread_handle.
8614         (target_thread_info_to_thread_handle): Declare.
8615         * target.c (target_thread_info_to_thread_handle): New function.
8616         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
8617         * target-delegates.c: Regenerate.
8618
8619         * linux-thread-db.c (class thread_db_target): Add method
8620         thread_info_to_thread_handle.
8621         (thread_db_target::thread_info_to_thread_handle): Define.
8622         * remote.c (class remote_target): Add new method
8623         thread_info_to_thread_handle.
8624         (remote_target::thread_info_to_thread_handle): Define.
8625
8626 2019-04-08  Pedro Alves  <palves@redhat.com>
8627
8628         * common/common-exceptions.c (throw_exception): Don't create
8629         named object to throw; throw directly.
8630         (throw_it): Likewise.  Don't initialize gdb_exception::message
8631         here, with new; pass FMT and AP to the ctor instead.
8632         * common/common-exceptions.h: Include <string>.
8633         (gdb_exception::gdb_exception(enum return_reason, enum errors,
8634         const char *, va_list)): New ctor.  Use std::make_shared.
8635         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
8636         errors)): Delete.
8637         (gdb_exception_error::gdb_exception_error(enum errors, const char
8638         *, va_list)): New.
8639         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
8640         Add assertion.
8641         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
8642         errors)): Delete.
8643         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
8644         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
8645         Add assertion.
8646
8647 2019-04-08  Tom Tromey  <tom@tromey.com>
8648
8649         * valops.c (value_rtti_indirect_type): Replace throw_exception
8650         with throw.
8651         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
8652         with throw.
8653         * thread.c (thr_try_catch_cmd): Replace throw_exception with
8654         throw.
8655         * target.c (target_translate_tls_address): Replace throw_exception
8656         with throw.
8657         * stack.c (frame_apply_command_count): Replace throw_exception
8658         with throw.
8659         * solib-spu.c (append_ocl_sos): Replace throw_exception with
8660         throw.
8661         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
8662         with throw.
8663         * rs6000-tdep.c (rs6000_frame_cache)
8664         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
8665         * remote.c: Replace throw_exception with throw.
8666         * record-full.c (record_full_message, record_full_wait_1)
8667         (record_full_restore): Replace throw_exception with throw.
8668         * record-btrace.c:
8669         (get_thread_current_frame_id, record_btrace_start_replaying)
8670         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
8671         (cmd_record_btrace_start): Replace throw_exception with throw.
8672         * parse.c (parse_exp_in_context_1): Replace throw_exception with
8673         throw.
8674         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
8675         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
8676         * linespec.c:
8677         (find_linespec_symbols): Replace throw_exception with throw.
8678         * infrun.c (displaced_step_prepare, resume): Replace
8679         throw_exception with throw.
8680         * infcmd.c (post_create_inferior): Replace throw_exception with
8681         throw.
8682         * inf-loop.c (inferior_event_handler): Replace throw_exception
8683         with throw.
8684         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
8685         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
8686         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
8687         (get_prev_frame_always, get_frame_pc_if_available)
8688         (get_frame_address_in_block_if_available, get_frame_language):
8689         Replace throw_exception with throw.
8690         * frame-unwind.c (frame_unwind_try_unwinder): Replace
8691         throw_exception with throw.
8692         * eval.c (fetch_subexp_value, evaluate_var_value)
8693         (evaluate_funcall, evaluate_subexp_standard): Replace
8694         throw_exception with throw.
8695         * dwarf2loc.c (call_site_find_chain)
8696         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
8697         Replace throw_exception with throw.
8698         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
8699         with throw.
8700         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
8701         throw.
8702         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
8703         * completer.c (complete_line_internal): Replace throw_exception
8704         with throw.
8705         * compile/compile-object-run.c (compile_object_run): Replace
8706         throw_exception with throw.
8707         * cli/cli-script.c (process_next_line): Replace throw_exception
8708         with throw.
8709         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
8710         (btrace_enable, btrace_maint_update_pt_packets): Replace
8711         throw_exception with throw.
8712         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
8713         throw_exception with throw.
8714         * break-catch-throw.c (re_set_exception_catchpoint): Replace
8715         throw_exception with throw.
8716         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
8717         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
8718         * aarch64-tdep.c (aarch64_make_prologue_cache)
8719         (aarch64_make_stub_cache): Replace throw_exception with throw.
8720
8721 2019-04-08  Tom Tromey  <tom@tromey.com>
8722
8723         * common/common-exceptions.c (throw_exception): Rename from
8724         throw_exception_cxx.  Remove old copy.  Make argument const.
8725         (throw_it): Create and throw exception objects directly.
8726         * common/common-exceptions.h (throw_exception): Make argument
8727         const.
8728         (struct gdb_exception_error): Add constructor.
8729         (struct gdb_exception_quit): Add constructor.
8730
8731 2019-04-08  Tom Tromey  <tom@tromey.com>
8732
8733         * common/common-exceptions.h (exception_rethrow): Don't declare.
8734         (TRY_SJLJ): Update comment.
8735         (TRY, CATCH, END_CATCH): Remove.
8736         * common/common-exceptions.c (exception_rethrow): Remove.
8737
8738 2019-04-08  Tom Tromey  <tom@tromey.com>
8739
8740         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
8741         Remove.
8742         (gdb_exception_error): Rename from
8743         gdb_exception_RETURN_MASK_ERROR.
8744         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
8745         (gdb_quit_bad_alloc): Update.
8746         * aarch64-tdep.c: Update.
8747         * ada-lang.c: Update.
8748         * ada-typeprint.c: Update.
8749         * ada-valprint.c: Update.
8750         * amd64-tdep.c: Update.
8751         * arch-utils.c: Update.
8752         * break-catch-throw.c: Update.
8753         * breakpoint.c: Update.
8754         * btrace.c: Update.
8755         * c-varobj.c: Update.
8756         * cli/cli-cmds.c: Update.
8757         * cli/cli-interp.c: Update.
8758         * cli/cli-script.c: Update.
8759         * common/common-exceptions.c: Update.
8760         * common/new-op.c: Update.
8761         * common/selftest.c: Update.
8762         * compile/compile-c-symbols.c: Update.
8763         * compile/compile-cplus-symbols.c: Update.
8764         * compile/compile-object-load.c: Update.
8765         * compile/compile-object-run.c: Update.
8766         * completer.c: Update.
8767         * corelow.c: Update.
8768         * cp-abi.c: Update.
8769         * cp-support.c: Update.
8770         * cp-valprint.c: Update.
8771         * darwin-nat.c: Update.
8772         * disasm-selftests.c: Update.
8773         * dtrace-probe.c: Update.
8774         * dwarf-index-cache.c: Update.
8775         * dwarf-index-write.c: Update.
8776         * dwarf2-frame-tailcall.c: Update.
8777         * dwarf2-frame.c: Update.
8778         * dwarf2loc.c: Update.
8779         * dwarf2read.c: Update.
8780         * eval.c: Update.
8781         * event-loop.c: Update.
8782         * event-top.c: Update.
8783         * exec.c: Update.
8784         * f-valprint.c: Update.
8785         * fbsd-tdep.c: Update.
8786         * frame-unwind.c: Update.
8787         * frame.c: Update.
8788         * gdbtypes.c: Update.
8789         * gnu-v3-abi.c: Update.
8790         * guile/guile-internal.h: Update.
8791         * guile/scm-block.c: Update.
8792         * guile/scm-breakpoint.c: Update.
8793         * guile/scm-cmd.c: Update.
8794         * guile/scm-disasm.c: Update.
8795         * guile/scm-frame.c: Update.
8796         * guile/scm-lazy-string.c: Update.
8797         * guile/scm-math.c: Update.
8798         * guile/scm-param.c: Update.
8799         * guile/scm-ports.c: Update.
8800         * guile/scm-pretty-print.c: Update.
8801         * guile/scm-symbol.c: Update.
8802         * guile/scm-symtab.c: Update.
8803         * guile/scm-type.c: Update.
8804         * guile/scm-value.c: Update.
8805         * i386-linux-tdep.c: Update.
8806         * i386-tdep.c: Update.
8807         * inf-loop.c: Update.
8808         * infcall.c: Update.
8809         * infcmd.c: Update.
8810         * infrun.c: Update.
8811         * jit.c: Update.
8812         * language.c: Update.
8813         * linespec.c: Update.
8814         * linux-fork.c: Update.
8815         * linux-nat.c: Update.
8816         * linux-tdep.c: Update.
8817         * linux-thread-db.c: Update.
8818         * main.c: Update.
8819         * mi/mi-cmd-break.c: Update.
8820         * mi/mi-cmd-stack.c: Update.
8821         * mi/mi-interp.c: Update.
8822         * mi/mi-main.c: Update.
8823         * objc-lang.c: Update.
8824         * p-valprint.c: Update.
8825         * parse.c: Update.
8826         * ppc-linux-tdep.c: Update.
8827         * printcmd.c: Update.
8828         * python/py-arch.c: Update.
8829         * python/py-breakpoint.c: Update.
8830         * python/py-cmd.c: Update.
8831         * python/py-finishbreakpoint.c: Update.
8832         * python/py-frame.c: Update.
8833         * python/py-framefilter.c: Update.
8834         * python/py-gdb-readline.c: Update.
8835         * python/py-inferior.c: Update.
8836         * python/py-infthread.c: Update.
8837         * python/py-lazy-string.c: Update.
8838         * python/py-linetable.c: Update.
8839         * python/py-objfile.c: Update.
8840         * python/py-param.c: Update.
8841         * python/py-prettyprint.c: Update.
8842         * python/py-progspace.c: Update.
8843         * python/py-record-btrace.c: Update.
8844         * python/py-record.c: Update.
8845         * python/py-symbol.c: Update.
8846         * python/py-type.c: Update.
8847         * python/py-unwind.c: Update.
8848         * python/py-utils.c: Update.
8849         * python/py-value.c: Update.
8850         * python/python.c: Update.
8851         * record-btrace.c: Update.
8852         * record-full.c: Update.
8853         * remote-fileio.c: Update.
8854         * remote.c: Update.
8855         * riscv-tdep.c: Update.
8856         * rs6000-aix-tdep.c: Update.
8857         * rs6000-tdep.c: Update.
8858         * rust-exp.y: Update.
8859         * rust-lang.c: Update.
8860         * s390-tdep.c: Update.
8861         * selftest-arch.c: Update.
8862         * solib-dsbt.c: Update.
8863         * solib-frv.c: Update.
8864         * solib-spu.c: Update.
8865         * solib-svr4.c: Update.
8866         * solib.c: Update.
8867         * sparc64-linux-tdep.c: Update.
8868         * stack.c: Update.
8869         * symfile-mem.c: Update.
8870         * symmisc.c: Update.
8871         * target.c: Update.
8872         * thread.c: Update.
8873         * top.c: Update.
8874         * tracefile-tfile.c: Update.
8875         * tui/tui.c: Update.
8876         * typeprint.c: Update.
8877         * unittests/cli-utils-selftests.c: Update.
8878         * unittests/parse-connection-spec-selftests.c: Update.
8879         * valops.c: Update.
8880         * valprint.c: Update.
8881         * value.c: Update.
8882         * varobj.c: Update.
8883         * windows-nat.c: Update.
8884         * x86-linux-nat.c: Update.
8885         * xml-support.c: Update.
8886
8887 2019-04-08  Tom Tromey  <tom@tromey.com>
8888
8889         * xml-support.c: Use C++ exception handling.
8890         * x86-linux-nat.c: Use C++ exception handling.
8891         * windows-nat.c: Use C++ exception handling.
8892         * varobj.c: Use C++ exception handling.
8893         * value.c: Use C++ exception handling.
8894         * valprint.c: Use C++ exception handling.
8895         * valops.c: Use C++ exception handling.
8896         * unittests/parse-connection-spec-selftests.c: Use C++ exception
8897         handling.
8898         * unittests/cli-utils-selftests.c: Use C++ exception handling.
8899         * typeprint.c: Use C++ exception handling.
8900         * tui/tui.c: Use C++ exception handling.
8901         * tracefile-tfile.c: Use C++ exception handling.
8902         * top.c: Use C++ exception handling.
8903         * thread.c: Use C++ exception handling.
8904         * target.c: Use C++ exception handling.
8905         * symmisc.c: Use C++ exception handling.
8906         * symfile-mem.c: Use C++ exception handling.
8907         * stack.c: Use C++ exception handling.
8908         * sparc64-linux-tdep.c: Use C++ exception handling.
8909         * solib.c: Use C++ exception handling.
8910         * solib-svr4.c: Use C++ exception handling.
8911         * solib-spu.c: Use C++ exception handling.
8912         * solib-frv.c: Use C++ exception handling.
8913         * solib-dsbt.c: Use C++ exception handling.
8914         * selftest-arch.c: Use C++ exception handling.
8915         * s390-tdep.c: Use C++ exception handling.
8916         * rust-lang.c: Use C++ exception handling.
8917         * rust-exp.y: Use C++ exception handling.
8918         * rs6000-tdep.c: Use C++ exception handling.
8919         * rs6000-aix-tdep.c: Use C++ exception handling.
8920         * riscv-tdep.c: Use C++ exception handling.
8921         * remote.c: Use C++ exception handling.
8922         * remote-fileio.c: Use C++ exception handling.
8923         * record-full.c: Use C++ exception handling.
8924         * record-btrace.c: Use C++ exception handling.
8925         * python/python.c: Use C++ exception handling.
8926         * python/py-value.c: Use C++ exception handling.
8927         * python/py-utils.c: Use C++ exception handling.
8928         * python/py-unwind.c: Use C++ exception handling.
8929         * python/py-type.c: Use C++ exception handling.
8930         * python/py-symbol.c: Use C++ exception handling.
8931         * python/py-record.c: Use C++ exception handling.
8932         * python/py-record-btrace.c: Use C++ exception handling.
8933         * python/py-progspace.c: Use C++ exception handling.
8934         * python/py-prettyprint.c: Use C++ exception handling.
8935         * python/py-param.c: Use C++ exception handling.
8936         * python/py-objfile.c: Use C++ exception handling.
8937         * python/py-linetable.c: Use C++ exception handling.
8938         * python/py-lazy-string.c: Use C++ exception handling.
8939         * python/py-infthread.c: Use C++ exception handling.
8940         * python/py-inferior.c: Use C++ exception handling.
8941         * python/py-gdb-readline.c: Use C++ exception handling.
8942         * python/py-framefilter.c: Use C++ exception handling.
8943         * python/py-frame.c: Use C++ exception handling.
8944         * python/py-finishbreakpoint.c: Use C++ exception handling.
8945         * python/py-cmd.c: Use C++ exception handling.
8946         * python/py-breakpoint.c: Use C++ exception handling.
8947         * python/py-arch.c: Use C++ exception handling.
8948         * printcmd.c: Use C++ exception handling.
8949         * ppc-linux-tdep.c: Use C++ exception handling.
8950         * parse.c: Use C++ exception handling.
8951         * p-valprint.c: Use C++ exception handling.
8952         * objc-lang.c: Use C++ exception handling.
8953         * mi/mi-main.c: Use C++ exception handling.
8954         * mi/mi-interp.c: Use C++ exception handling.
8955         * mi/mi-cmd-stack.c: Use C++ exception handling.
8956         * mi/mi-cmd-break.c: Use C++ exception handling.
8957         * main.c: Use C++ exception handling.
8958         * linux-thread-db.c: Use C++ exception handling.
8959         * linux-tdep.c: Use C++ exception handling.
8960         * linux-nat.c: Use C++ exception handling.
8961         * linux-fork.c: Use C++ exception handling.
8962         * linespec.c: Use C++ exception handling.
8963         * language.c: Use C++ exception handling.
8964         * jit.c: Use C++ exception handling.
8965         * infrun.c: Use C++ exception handling.
8966         * infcmd.c: Use C++ exception handling.
8967         * infcall.c: Use C++ exception handling.
8968         * inf-loop.c: Use C++ exception handling.
8969         * i386-tdep.c: Use C++ exception handling.
8970         * i386-linux-tdep.c: Use C++ exception handling.
8971         * guile/scm-value.c: Use C++ exception handling.
8972         * guile/scm-type.c: Use C++ exception handling.
8973         * guile/scm-symtab.c: Use C++ exception handling.
8974         * guile/scm-symbol.c: Use C++ exception handling.
8975         * guile/scm-pretty-print.c: Use C++ exception handling.
8976         * guile/scm-ports.c: Use C++ exception handling.
8977         * guile/scm-param.c: Use C++ exception handling.
8978         * guile/scm-math.c: Use C++ exception handling.
8979         * guile/scm-lazy-string.c: Use C++ exception handling.
8980         * guile/scm-frame.c: Use C++ exception handling.
8981         * guile/scm-disasm.c: Use C++ exception handling.
8982         * guile/scm-cmd.c: Use C++ exception handling.
8983         * guile/scm-breakpoint.c: Use C++ exception handling.
8984         * guile/scm-block.c: Use C++ exception handling.
8985         * guile/guile-internal.h: Use C++ exception handling.
8986         * gnu-v3-abi.c: Use C++ exception handling.
8987         * gdbtypes.c: Use C++ exception handling.
8988         * frame.c: Use C++ exception handling.
8989         * frame-unwind.c: Use C++ exception handling.
8990         * fbsd-tdep.c: Use C++ exception handling.
8991         * f-valprint.c: Use C++ exception handling.
8992         * exec.c: Use C++ exception handling.
8993         * event-top.c: Use C++ exception handling.
8994         * event-loop.c: Use C++ exception handling.
8995         * eval.c: Use C++ exception handling.
8996         * dwarf2read.c: Use C++ exception handling.
8997         * dwarf2loc.c: Use C++ exception handling.
8998         * dwarf2-frame.c: Use C++ exception handling.
8999         * dwarf2-frame-tailcall.c: Use C++ exception handling.
9000         * dwarf-index-write.c: Use C++ exception handling.
9001         * dwarf-index-cache.c: Use C++ exception handling.
9002         * dtrace-probe.c: Use C++ exception handling.
9003         * disasm-selftests.c: Use C++ exception handling.
9004         * darwin-nat.c: Use C++ exception handling.
9005         * cp-valprint.c: Use C++ exception handling.
9006         * cp-support.c: Use C++ exception handling.
9007         * cp-abi.c: Use C++ exception handling.
9008         * corelow.c: Use C++ exception handling.
9009         * completer.c: Use C++ exception handling.
9010         * compile/compile-object-run.c: Use C++ exception handling.
9011         * compile/compile-object-load.c: Use C++ exception handling.
9012         * compile/compile-cplus-symbols.c: Use C++ exception handling.
9013         * compile/compile-c-symbols.c: Use C++ exception handling.
9014         * common/selftest.c: Use C++ exception handling.
9015         * common/new-op.c: Use C++ exception handling.
9016         * cli/cli-script.c: Use C++ exception handling.
9017         * cli/cli-interp.c: Use C++ exception handling.
9018         * cli/cli-cmds.c: Use C++ exception handling.
9019         * c-varobj.c: Use C++ exception handling.
9020         * btrace.c: Use C++ exception handling.
9021         * breakpoint.c: Use C++ exception handling.
9022         * break-catch-throw.c: Use C++ exception handling.
9023         * arch-utils.c: Use C++ exception handling.
9024         * amd64-tdep.c: Use C++ exception handling.
9025         * ada-valprint.c: Use C++ exception handling.
9026         * ada-typeprint.c: Use C++ exception handling.
9027         * ada-lang.c: Use C++ exception handling.
9028         * aarch64-tdep.c: Use C++ exception handling.
9029
9030 2019-04-08  Tom Tromey  <tom@tromey.com>
9031
9032         * xml-support.c (gdb_xml_parser::parse): Update.
9033         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
9034         * value.c (show_convenience): Update.
9035         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
9036         (test_parse_flags_qcs): Update.
9037         * thread.c (thr_try_catch_cmd): Update.
9038         * target.c (target_translate_tls_address): Update.
9039         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
9040         (info_frame_command_core, frame_apply_command_count): Update.
9041         * rust-exp.y (rust_lex_exception_test): Update.
9042         * riscv-tdep.c (riscv_print_one_register_info): Update.
9043         * remote.c (remote_target::enable_btrace): Update.
9044         * record-btrace.c (record_btrace_enable_warn): Update.
9045         * python/py-utils.c (gdbpy_convert_exception): Update.
9046         * printcmd.c (do_one_display, print_variable_and_value): Update.
9047         * mi/mi-main.c (mi_print_exception): Update.
9048         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
9049         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
9050         * linux-nat.c (linux_nat_target::attach): Update.
9051         * linux-fork.c (class scoped_switch_fork_info): Update.
9052         * infrun.c (displaced_step_prepare): Update.
9053         * infcall.c (call_function_by_hand_dummy): Update.
9054         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
9055         * gnu-v3-abi.c (print_one_vtable): Update.
9056         * frame.c (get_prev_frame_always): Update.
9057         * f-valprint.c (info_common_command_for_block): Update.
9058         * exec.c (try_open_exec_file): Update.
9059         * exceptions.c (print_exception, exception_print)
9060         (exception_fprintf, exception_print_same): Update.
9061         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
9062         * dwarf-index-cache.c (index_cache::store)
9063         (index_cache::lookup_gdb_index): Update.
9064         * darwin-nat.c (maybe_cache_shell): Update.
9065         * cp-valprint.c (cp_print_value_fields): Update.
9066         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
9067         (gcc_cplus_symbol_address): Update.
9068         * compile/compile-c-symbols.c (gcc_convert_symbol)
9069         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
9070         * common/selftest.c: Update.
9071         * common/common-exceptions.h (struct gdb_exception) <message>: Now
9072         a std::string.
9073         (exception_try_scope_entry, exception_try_scope_exit): Don't
9074         declare.
9075         (struct exception_try_scope): Remove.
9076         (TRY): Don't use exception_try_scope.
9077         (struct gdb_exception): Add constructor, operator=.
9078         <what>: New method.
9079         (struct gdb_exception_RETURN_MASK_ALL)
9080         (struct gdb_exception_RETURN_MASK_ERROR)
9081         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
9082         (struct gdb_quit_bad_alloc): Update.
9083         * common/common-exceptions.c (exception_none): Change
9084         initializer.
9085         (struct catcher) <state, exception>: Initialize inline.
9086         <prev>: Remove member.
9087         (current_catcher): Remove.
9088         (catchers): New global.
9089         (exceptions_state_mc_init): Simplify.
9090         (catcher_pop): Remove.
9091         (exceptions_state_mc, exceptions_state_mc_catch): Update.
9092         (try_scope_depth, exception_try_scope_entry)
9093         (exception_try_scope_exit): Remove.
9094         (throw_exception_sjlj): Update.
9095         (exception_messages, exception_messages_size): Remove.
9096         (throw_it): Simplify.
9097         (gdb_exception_sliced_copy): Remove.
9098         (throw_exception_cxx): Update.
9099         * cli/cli-script.c (script_from_file): Update.
9100         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
9101         Update.
9102         * ada-valprint.c (ada_val_print): Update.
9103         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
9104         (create_excep_cond_exprs): Update.
9105
9106 2019-04-08  Tom Tromey  <tom@tromey.com>
9107
9108         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
9109         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
9110         (TRY, CATCH, END_CATCH): Remove some definitions.
9111         * common/common-exceptions.c: Don't use GDB_XCPT.
9112         (catcher_list_size): Remove.
9113         (throw_exception, throw_it): Simplify.
9114
9115 2019-04-05  Tom Tromey  <tom@tromey.com>
9116
9117         Revert the header-sorting patch.
9118         * ft32-tdep.c: Revert.
9119         * frv-tdep.c: Revert.
9120         * frv-linux-tdep.c: Revert.
9121         * frame.c: Revert.
9122         * frame-unwind.c: Revert.
9123         * frame-base.c: Revert.
9124         * fork-child.c: Revert.
9125         * findvar.c: Revert.
9126         * findcmd.c: Revert.
9127         * filesystem.c: Revert.
9128         * filename-seen-cache.h: Revert.
9129         * filename-seen-cache.c: Revert.
9130         * fbsd-tdep.c: Revert.
9131         * fbsd-nat.h: Revert.
9132         * fbsd-nat.c: Revert.
9133         * f-valprint.c: Revert.
9134         * f-typeprint.c: Revert.
9135         * f-lang.c: Revert.
9136         * extension.h: Revert.
9137         * extension.c: Revert.
9138         * extension-priv.h: Revert.
9139         * expprint.c: Revert.
9140         * exec.h: Revert.
9141         * exec.c: Revert.
9142         * exceptions.c: Revert.
9143         * event-top.c: Revert.
9144         * event-loop.c: Revert.
9145         * eval.c: Revert.
9146         * elfread.c: Revert.
9147         * dwarf2read.h: Revert.
9148         * dwarf2read.c: Revert.
9149         * dwarf2loc.c: Revert.
9150         * dwarf2expr.h: Revert.
9151         * dwarf2expr.c: Revert.
9152         * dwarf2-frame.c: Revert.
9153         * dwarf2-frame-tailcall.c: Revert.
9154         * dwarf-index-write.h: Revert.
9155         * dwarf-index-write.c: Revert.
9156         * dwarf-index-common.c: Revert.
9157         * dwarf-index-cache.h: Revert.
9158         * dwarf-index-cache.c: Revert.
9159         * dummy-frame.c: Revert.
9160         * dtrace-probe.c: Revert.
9161         * disasm.h: Revert.
9162         * disasm.c: Revert.
9163         * disasm-selftests.c: Revert.
9164         * dictionary.c: Revert.
9165         * dicos-tdep.c: Revert.
9166         * demangle.c: Revert.
9167         * dcache.h: Revert.
9168         * dcache.c: Revert.
9169         * darwin-nat.h: Revert.
9170         * darwin-nat.c: Revert.
9171         * darwin-nat-info.c: Revert.
9172         * d-valprint.c: Revert.
9173         * d-namespace.c: Revert.
9174         * d-lang.c: Revert.
9175         * ctf.c: Revert.
9176         * csky-tdep.c: Revert.
9177         * csky-linux-tdep.c: Revert.
9178         * cris-tdep.c: Revert.
9179         * cris-linux-tdep.c: Revert.
9180         * cp-valprint.c: Revert.
9181         * cp-support.c: Revert.
9182         * cp-namespace.c: Revert.
9183         * cp-abi.c: Revert.
9184         * corelow.c: Revert.
9185         * corefile.c: Revert.
9186         * continuations.c: Revert.
9187         * completer.h: Revert.
9188         * completer.c: Revert.
9189         * complaints.c: Revert.
9190         * coffread.c: Revert.
9191         * coff-pe-read.c: Revert.
9192         * cli-out.h: Revert.
9193         * cli-out.c: Revert.
9194         * charset.c: Revert.
9195         * c-varobj.c: Revert.
9196         * c-valprint.c: Revert.
9197         * c-typeprint.c: Revert.
9198         * c-lang.c: Revert.
9199         * buildsym.c: Revert.
9200         * buildsym-legacy.c: Revert.
9201         * build-id.h: Revert.
9202         * build-id.c: Revert.
9203         * btrace.c: Revert.
9204         * bsd-uthread.c: Revert.
9205         * breakpoint.h: Revert.
9206         * breakpoint.c: Revert.
9207         * break-catch-throw.c: Revert.
9208         * break-catch-syscall.c: Revert.
9209         * break-catch-sig.c: Revert.
9210         * blockframe.c: Revert.
9211         * block.c: Revert.
9212         * bfin-tdep.c: Revert.
9213         * bfin-linux-tdep.c: Revert.
9214         * bfd-target.c: Revert.
9215         * bcache.c: Revert.
9216         * ax-general.c: Revert.
9217         * ax-gdb.h: Revert.
9218         * ax-gdb.c: Revert.
9219         * avr-tdep.c: Revert.
9220         * auxv.c: Revert.
9221         * auto-load.c: Revert.
9222         * arm-wince-tdep.c: Revert.
9223         * arm-tdep.c: Revert.
9224         * arm-symbian-tdep.c: Revert.
9225         * arm-pikeos-tdep.c: Revert.
9226         * arm-obsd-tdep.c: Revert.
9227         * arm-nbsd-tdep.c: Revert.
9228         * arm-nbsd-nat.c: Revert.
9229         * arm-linux-tdep.c: Revert.
9230         * arm-linux-nat.c: Revert.
9231         * arm-fbsd-tdep.c: Revert.
9232         * arm-fbsd-nat.c: Revert.
9233         * arm-bsd-tdep.c: Revert.
9234         * arch-utils.c: Revert.
9235         * arc-tdep.c: Revert.
9236         * arc-newlib-tdep.c: Revert.
9237         * annotate.h: Revert.
9238         * annotate.c: Revert.
9239         * amd64-windows-tdep.c: Revert.
9240         * amd64-windows-nat.c: Revert.
9241         * amd64-tdep.c: Revert.
9242         * amd64-sol2-tdep.c: Revert.
9243         * amd64-obsd-tdep.c: Revert.
9244         * amd64-obsd-nat.c: Revert.
9245         * amd64-nbsd-tdep.c: Revert.
9246         * amd64-nbsd-nat.c: Revert.
9247         * amd64-nat.c: Revert.
9248         * amd64-linux-tdep.c: Revert.
9249         * amd64-linux-nat.c: Revert.
9250         * amd64-fbsd-tdep.c: Revert.
9251         * amd64-fbsd-nat.c: Revert.
9252         * amd64-dicos-tdep.c: Revert.
9253         * amd64-darwin-tdep.c: Revert.
9254         * amd64-bsd-nat.c: Revert.
9255         * alpha-tdep.c: Revert.
9256         * alpha-obsd-tdep.c: Revert.
9257         * alpha-nbsd-tdep.c: Revert.
9258         * alpha-mdebug-tdep.c: Revert.
9259         * alpha-linux-tdep.c: Revert.
9260         * alpha-linux-nat.c: Revert.
9261         * alpha-bsd-tdep.c: Revert.
9262         * alpha-bsd-nat.c: Revert.
9263         * aix-thread.c: Revert.
9264         * agent.c: Revert.
9265         * addrmap.c: Revert.
9266         * ada-varobj.c: Revert.
9267         * ada-valprint.c: Revert.
9268         * ada-typeprint.c: Revert.
9269         * ada-tasks.c: Revert.
9270         * ada-lang.c: Revert.
9271         * aarch64-tdep.c: Revert.
9272         * aarch64-ravenscar-thread.c: Revert.
9273         * aarch64-newlib-tdep.c: Revert.
9274         * aarch64-linux-tdep.c: Revert.
9275         * aarch64-linux-nat.c: Revert.
9276         * aarch64-fbsd-tdep.c: Revert.
9277         * aarch64-fbsd-nat.c: Revert.
9278         * aarch32-linux-nat.c: Revert.
9279
9280 2019-04-05  Tom Tromey  <tom@tromey.com>
9281
9282         * ft32-tdep.c: Sort headers.
9283         * frv-tdep.c: Sort headers.
9284         * frv-linux-tdep.c: Sort headers.
9285         * frame.c: Sort headers.
9286         * frame-unwind.c: Sort headers.
9287         * frame-base.c: Sort headers.
9288         * fork-child.c: Sort headers.
9289         * findvar.c: Sort headers.
9290         * findcmd.c: Sort headers.
9291         * filesystem.c: Sort headers.
9292         * filename-seen-cache.h: Sort headers.
9293         * filename-seen-cache.c: Sort headers.
9294         * fbsd-tdep.c: Sort headers.
9295         * fbsd-nat.h: Sort headers.
9296         * fbsd-nat.c: Sort headers.
9297         * f-valprint.c: Sort headers.
9298         * f-typeprint.c: Sort headers.
9299         * f-lang.c: Sort headers.
9300         * extension.h: Sort headers.
9301         * extension.c: Sort headers.
9302         * extension-priv.h: Sort headers.
9303         * expprint.c: Sort headers.
9304         * exec.h: Sort headers.
9305         * exec.c: Sort headers.
9306         * exceptions.c: Sort headers.
9307         * event-top.c: Sort headers.
9308         * event-loop.c: Sort headers.
9309         * eval.c: Sort headers.
9310         * elfread.c: Sort headers.
9311         * dwarf2read.h: Sort headers.
9312         * dwarf2read.c: Sort headers.
9313         * dwarf2loc.c: Sort headers.
9314         * dwarf2expr.h: Sort headers.
9315         * dwarf2expr.c: Sort headers.
9316         * dwarf2-frame.c: Sort headers.
9317         * dwarf2-frame-tailcall.c: Sort headers.
9318         * dwarf-index-write.h: Sort headers.
9319         * dwarf-index-write.c: Sort headers.
9320         * dwarf-index-common.c: Sort headers.
9321         * dwarf-index-cache.h: Sort headers.
9322         * dwarf-index-cache.c: Sort headers.
9323         * dummy-frame.c: Sort headers.
9324         * dtrace-probe.c: Sort headers.
9325         * disasm.h: Sort headers.
9326         * disasm.c: Sort headers.
9327         * disasm-selftests.c: Sort headers.
9328         * dictionary.c: Sort headers.
9329         * dicos-tdep.c: Sort headers.
9330         * demangle.c: Sort headers.
9331         * dcache.h: Sort headers.
9332         * dcache.c: Sort headers.
9333         * darwin-nat.h: Sort headers.
9334         * darwin-nat.c: Sort headers.
9335         * darwin-nat-info.c: Sort headers.
9336         * d-valprint.c: Sort headers.
9337         * d-namespace.c: Sort headers.
9338         * d-lang.c: Sort headers.
9339         * ctf.c: Sort headers.
9340         * csky-tdep.c: Sort headers.
9341         * csky-linux-tdep.c: Sort headers.
9342         * cris-tdep.c: Sort headers.
9343         * cris-linux-tdep.c: Sort headers.
9344         * cp-valprint.c: Sort headers.
9345         * cp-support.c: Sort headers.
9346         * cp-namespace.c: Sort headers.
9347         * cp-abi.c: Sort headers.
9348         * corelow.c: Sort headers.
9349         * corefile.c: Sort headers.
9350         * continuations.c: Sort headers.
9351         * completer.h: Sort headers.
9352         * completer.c: Sort headers.
9353         * complaints.c: Sort headers.
9354         * coffread.c: Sort headers.
9355         * coff-pe-read.c: Sort headers.
9356         * cli-out.h: Sort headers.
9357         * cli-out.c: Sort headers.
9358         * charset.c: Sort headers.
9359         * c-varobj.c: Sort headers.
9360         * c-valprint.c: Sort headers.
9361         * c-typeprint.c: Sort headers.
9362         * c-lang.c: Sort headers.
9363         * buildsym.c: Sort headers.
9364         * buildsym-legacy.c: Sort headers.
9365         * build-id.h: Sort headers.
9366         * build-id.c: Sort headers.
9367         * btrace.c: Sort headers.
9368         * bsd-uthread.c: Sort headers.
9369         * breakpoint.h: Sort headers.
9370         * breakpoint.c: Sort headers.
9371         * break-catch-throw.c: Sort headers.
9372         * break-catch-syscall.c: Sort headers.
9373         * break-catch-sig.c: Sort headers.
9374         * blockframe.c: Sort headers.
9375         * block.c: Sort headers.
9376         * bfin-tdep.c: Sort headers.
9377         * bfin-linux-tdep.c: Sort headers.
9378         * bfd-target.c: Sort headers.
9379         * bcache.c: Sort headers.
9380         * ax-general.c: Sort headers.
9381         * ax-gdb.h: Sort headers.
9382         * ax-gdb.c: Sort headers.
9383         * avr-tdep.c: Sort headers.
9384         * auxv.c: Sort headers.
9385         * auto-load.c: Sort headers.
9386         * arm-wince-tdep.c: Sort headers.
9387         * arm-tdep.c: Sort headers.
9388         * arm-symbian-tdep.c: Sort headers.
9389         * arm-pikeos-tdep.c: Sort headers.
9390         * arm-obsd-tdep.c: Sort headers.
9391         * arm-nbsd-tdep.c: Sort headers.
9392         * arm-nbsd-nat.c: Sort headers.
9393         * arm-linux-tdep.c: Sort headers.
9394         * arm-linux-nat.c: Sort headers.
9395         * arm-fbsd-tdep.c: Sort headers.
9396         * arm-fbsd-nat.c: Sort headers.
9397         * arm-bsd-tdep.c: Sort headers.
9398         * arch-utils.c: Sort headers.
9399         * arc-tdep.c: Sort headers.
9400         * arc-newlib-tdep.c: Sort headers.
9401         * annotate.h: Sort headers.
9402         * annotate.c: Sort headers.
9403         * amd64-windows-tdep.c: Sort headers.
9404         * amd64-windows-nat.c: Sort headers.
9405         * amd64-tdep.c: Sort headers.
9406         * amd64-sol2-tdep.c: Sort headers.
9407         * amd64-obsd-tdep.c: Sort headers.
9408         * amd64-obsd-nat.c: Sort headers.
9409         * amd64-nbsd-tdep.c: Sort headers.
9410         * amd64-nbsd-nat.c: Sort headers.
9411         * amd64-nat.c: Sort headers.
9412         * amd64-linux-tdep.c: Sort headers.
9413         * amd64-linux-nat.c: Sort headers.
9414         * amd64-fbsd-tdep.c: Sort headers.
9415         * amd64-fbsd-nat.c: Sort headers.
9416         * amd64-dicos-tdep.c: Sort headers.
9417         * amd64-darwin-tdep.c: Sort headers.
9418         * amd64-bsd-nat.c: Sort headers.
9419         * alpha-tdep.c: Sort headers.
9420         * alpha-obsd-tdep.c: Sort headers.
9421         * alpha-nbsd-tdep.c: Sort headers.
9422         * alpha-mdebug-tdep.c: Sort headers.
9423         * alpha-linux-tdep.c: Sort headers.
9424         * alpha-linux-nat.c: Sort headers.
9425         * alpha-bsd-tdep.c: Sort headers.
9426         * alpha-bsd-nat.c: Sort headers.
9427         * aix-thread.c: Sort headers.
9428         * agent.c: Sort headers.
9429         * addrmap.c: Sort headers.
9430         * ada-varobj.c: Sort headers.
9431         * ada-valprint.c: Sort headers.
9432         * ada-typeprint.c: Sort headers.
9433         * ada-tasks.c: Sort headers.
9434         * ada-lang.c: Sort headers.
9435         * aarch64-tdep.c: Sort headers.
9436         * aarch64-ravenscar-thread.c: Sort headers.
9437         * aarch64-newlib-tdep.c: Sort headers.
9438         * aarch64-linux-tdep.c: Sort headers.
9439         * aarch64-linux-nat.c: Sort headers.
9440         * aarch64-fbsd-tdep.c: Sort headers.
9441         * aarch64-fbsd-nat.c: Sort headers.
9442         * aarch32-linux-nat.c: Sort headers.
9443
9444 2019-04-04  Tom Tromey  <tom@tromey.com>
9445
9446         * varobj.c (varobj_create): Update.
9447         * rust-exp.y (struct rust_parser) <update_innermost_block,
9448         lookup_symbol>: New methods.
9449         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
9450         Rename.
9451         (rust_parser::rust_lookup_type)
9452         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9453         * printcmd.c (display_command, do_one_display): Update.
9454         * parser-defs.h (struct parser_state) <parser_state>: Add
9455         "tracker" parameter.
9456         (block_tracker): New member.
9457         (class innermost_block_tracker) <innermost_block_tracker>: Add
9458         "types" parameter.
9459         <reset>: Remove method.
9460         (innermost_block): Don't declare.
9461         (null_post_parser): Update.
9462         * parse.c (innermost_block): Remove global.
9463         (write_dollar_variable): Update.
9464         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
9465         Remove "tracker_types" parameter.
9466         (parse_expression): Add "tracker" parameter.
9467         (parse_expression_for_completion): Update.
9468         (null_post_parser): Add "tracker" parameter.
9469         * p-exp.y: Update rules.
9470         * m2-exp.y: Update rules.
9471         * language.h (struct language_defn) <la_post_parser>: Add
9472         "tracker" parameter.
9473         * go-exp.y: Update rules.
9474         * f-exp.y: Update rules.
9475         * expression.h (parse_expression, parse_exp_1): Add "tracker"
9476         parameter.
9477         * d-exp.y: Update rules.
9478         * c-exp.y: Update rules.
9479         * breakpoint.c (set_breakpoint_condition): Create an
9480         innermost_block_tracker.
9481         (watch_command_1): Likewise.
9482         * ada-lang.c (resolve): Add "tracker" parameter.
9483         (resolve_subexp): Likewise.
9484         * ada-exp.y (write_var_from_sym): Update.
9485
9486 2019-04-04  Tom Tromey  <tom@tromey.com>
9487
9488         * type-stack.h: New file.
9489         * type-stack.c: New file.
9490         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
9491         type-stack.h.
9492         (insert_into_type_stack, insert_type, push_type, push_type_int)
9493         (insert_type_address_space, pop_type, pop_type_int)
9494         (pop_typelist, pop_type_stack, append_type_stack)
9495         (push_type_stack, get_type_stack, push_typelist)
9496         (follow_type_instance_flags, follow_types): Don't declare.
9497         * parse.c (type_stack): Remove global.
9498         (parse_exp_in_context): Update.
9499         (insert_into_type_stack, insert_type, push_type, push_type_int)
9500         (insert_type_address_space, pop_type, pop_type_int)
9501         (pop_typelist, pop_type_stack, append_type_stack)
9502         (push_type_stack, get_type_stack, push_typelist)
9503         (follow_type_instance_flags, follow_types): Remove (moved to
9504         type-stack.c).
9505         * f-exp.y (type_stack): New global.
9506         Update rules.
9507         (push_kind_type, f_parse): Update.
9508         * d-exp.y (type_stack): New global.
9509         Update rules.
9510         (d_parse): Update.
9511         * c-exp.y (struct c_parse_state) <type_stack>: New member.
9512         Update rules.
9513         * Makefile.in (COMMON_SFILES): Add type-stack.c.
9514         (HFILES_NO_SRCDIR): Add type-stack.h.
9515
9516 2019-04-04  Tom Tromey  <tom@tromey.com>
9517
9518         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
9519         (rust_parser::convert_ast_to_expression, rust_parse)
9520         (rust_lex_test_completion, rust_lex_tests): Update.
9521         * parser-defs.h (struct expr_completion_state): New.
9522         (struct parser_state) <parser_state>: Add completion parameter.
9523         <mark_struct_expression, mark_completion_tag>: New methods.
9524         <parse_completion, m_completion_state>: New members.
9525         (prefixify_expression, null_post_parser): Update.
9526         (mark_struct_expression, mark_completion_tag): Don't declare.
9527         * parse.c (parse_completion, expout_last_struct)
9528         (expout_tag_completion_type, expout_completion_name): Remove
9529         globals.
9530         (parser_state::mark_struct_expression)
9531         (parser_state::mark_completion_tag): Now methods.
9532         (prefixify_expression): Add last_struct parameter.
9533         (prefixify_subexp): Likewise.
9534         (parse_exp_1): Update.
9535         (parse_exp_in_context): Add cstate parameter.  Update.
9536         (parse_expression_for_completion): Create an
9537         expr_completion_state.
9538         (null_post_parser): Add "completion" parameter.
9539         * p-exp.y: Update rules.
9540         (yylex): Update.
9541         * language.h (struct language_defn) <la_post_parser>: Add
9542         "completing" parameter.
9543         * go-exp.y: Update rules.
9544         (lex_one_token): Update.
9545         * expression.h (parse_completion): Don't declare.
9546         * d-exp.y: Update rules.
9547         (lex_one_token): Update rules.
9548         * c-exp.y: Update rules.
9549         (lex_one_token): Update.
9550         * ada-lang.c (resolve): Add "parse_completion" parameter.
9551         (resolve_subexp): Likewise.
9552         (ada_resolve_function): Likewise.
9553
9554 2019-04-04  Tom Tromey  <tom@tromey.com>
9555
9556         * parser-defs.h (struct parser_state) <start_arglist,
9557         end_arglist>: New methods.
9558         <arglist_len, m_funcall_chain>: New members.
9559         (arglist_len, start_arglist, end_arglist): Don't declare.
9560         * parse.c (arglist_len, funcall_chain): Remove global.
9561         (start_arglist, end_arglist): Remove functions.
9562         (parse_exp_in_context): Update.
9563         * p-exp.y: Update rules.
9564         * m2-exp.y: Update rules.
9565         * go-exp.y: Update rules.
9566         * f-exp.y: Update rules.
9567         * d-exp.y: Update rules.
9568         * c-exp.y: Update rules.
9569
9570 2019-04-04  Tom Tromey  <tom@tromey.com>
9571
9572         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
9573         lex_operator, push_back>: New methods.
9574         Update all rules.
9575         (rust_parser::lex_hex, lex_escape): Rename and update.
9576         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
9577         (rust_parser::lex_operator): Rename and update.
9578         (rust_parser::lex_number, rustyylex, rustyyerror)
9579         (rust_lex_test_init, rust_lex_test_sequence)
9580         (rust_lex_test_push_back, rust_lex_tests): Update.
9581         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
9582         parameter.
9583         <lexptr, prev_lexptr>: New members.
9584         (lexptr, prev_lexptr): Don't declare.
9585         * parse.c (lexptr, prev_lexptr): Remove globals.
9586         (parse_exp_in_context): Update.
9587         * p-exp.y (yylex, yyerror): Update.
9588         * m2-exp.y (parse_number, yylex, yyerror): Update.
9589         * go-exp.y (lex_one_token, yyerror): Update.
9590         * f-exp.y (match_string_literal, yylex, yyerror): Update.
9591         * d-exp.y (lex_one_token, yyerror): Update.
9592         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
9593         (lex_one_token, yyerror): Update.
9594         * ada-lex.l (YY_INPUT): Update.
9595         (rewind_to_char): Update.
9596         * ada-exp.y (yyerror): Update.
9597
9598 2019-04-04  Tom Tromey  <tom@tromey.com>
9599
9600         * rust-exp.y (rustyylex, rust_lex_tests): Update.
9601         * parser-defs.h (struct parser_state) <parser_state>: Add new
9602         parameter.
9603         <comma_terminates>: New member.
9604         (comma_terminates): Don't declare global.
9605         * parse.c (comma_terminates): Remove global.
9606         (parse_exp_in_context): Update.
9607         * p-exp.y (yylex): Update.
9608         * m2-exp.y (yylex): Update.
9609         * go-exp.y (lex_one_token): Update.
9610         * f-exp.y (yylex): Update.
9611         * d-exp.y (lex_one_token): Update.
9612         * c-exp.y (lex_one_token): Update.
9613         * ada-lex.l: Update.
9614
9615 2019-04-04  Tom Tromey  <tom@tromey.com>
9616
9617         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
9618         (rustyylex, rust_lex_test_init, rust_lex_test_one)
9619         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
9620         * parser-defs.h (paren_depth): Don't declare.
9621         * parse.c (paren_depth): Remove global.
9622         (parse_exp_in_context): Update.
9623         * p-exp.y (paren_depth): New global.
9624         (pascal_parse): Initialize it.
9625         * m2-exp.y (paren_depth): New global.
9626         (m2_parse): Initialize it.
9627         * go-exp.y (paren_depth): New global.
9628         (go_parse): Initialize it.
9629         * f-exp.y (paren_depth): New global.
9630         (f_parse): Initialize it.
9631         * d-exp.y (paren_depth): New global.
9632         (d_parse): Initialize it.
9633         * c-exp.y (paren_depth): New global.
9634         (c_parse): Initialize it.
9635         * ada-lex.l (paren_depth): New global.
9636         (lexer_init): Initialize it.
9637
9638 2019-04-04  Tom Tromey  <tom@tromey.com>
9639
9640         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
9641         (rust_parser::convert_ast_to_type)
9642         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
9643         * parser-defs.h (struct parser_state) <parser_state>: Add
9644         parameters.  Initialize new members.
9645         <expression_context_block, expression_context_pc>: New members.
9646         * parse.c (expression_context_block, expression_context_pc):
9647         Remove globals.
9648         (parse_exp_in_context): Update.
9649         * p-exp.y: Update all rules.
9650         (yylex): Update.
9651         * m2-exp.y: Update all rules.
9652         (yylex): Update.
9653         * go-exp.y (yylex): Update.
9654         * f-exp.y (yylex): Update.
9655         * d-exp.y: Update all rules.
9656         (yylex): Update.
9657         * c-exp.y: Update all rules.
9658         (lex_one_token, classify_name, yylex, c_parse): Update.
9659         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
9660
9661 2019-04-04  Tom Tromey  <tom@tromey.com>
9662
9663         * gdbarch.h, gdbarch.c: Rebuild.
9664         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
9665         * stap-probe.h:
9666         (struct stap_parse_info): Replace "parser_state" with
9667         "expr_builder".
9668         * parser-defs.h (struct expr_builder): Rename from "parser_state".
9669         (parser_state): New class.
9670         * parse.c (expr_builder): Rename.
9671         (expr_builder::release): Rename.
9672         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
9673         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
9674         (write_exp_elt_longcst, write_exp_elt_floatcst)
9675         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
9676         (write_exp_string_vector, write_exp_bitstring)
9677         (write_exp_msymbol, mark_struct_expression)
9678         (write_dollar_variable)
9679         (insert_type_address_space, increase_expout_size): Replace
9680         "parser_state" with "expr_builder".
9681         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
9682         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
9683         "parser_state" with "expr_builder".
9684
9685 2019-04-04  Tom Tromey  <tom@tromey.com>
9686
9687         * rust-exp.y: Replace "parse_language" with method call.
9688         * p-exp.y:
9689         (yylex): Replace "parse_language" with method call.
9690         * m2-exp.y:
9691         (yylex): Replace "parse_language" with method call.
9692         * go-exp.y (classify_name): Replace "parse_language" with method
9693         call.
9694         * f-exp.y (yylex): Replace "parse_language" with method call.
9695         * d-exp.y (lex_one_token): Replace "parse_language" with method
9696         call.
9697         * c-exp.y:
9698         (lex_one_token, classify_name, yylex): Replace "parse_language"
9699         with method call.
9700         * ada-exp.y (find_primitive_type, type_char)
9701         (type_system_address): Replace "parse_language" with method call.
9702
9703 2019-04-04  Tom Tromey  <tom@tromey.com>
9704
9705         * rust-exp.y: Replace "parse_gdbarch" with method call.
9706         * parse.c (write_dollar_variable, insert_type_address_space):
9707         Replace "parse_gdbarch" with method call.
9708         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
9709         call.
9710         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
9711         call.
9712         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
9713         "parse_gdbarch" with method call.
9714         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
9715         with method call.
9716         * f-exp.y (parse_type, parse_f_type, yylex): Replace
9717         "parse_gdbarch" with method call.
9718         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
9719         "parse_gdbarch" with method call.
9720         * c-exp.y (parse_type, parse_number, classify_name): Replace
9721         "parse_gdbarch" with method call.
9722         * ada-lex.l: Replace "parse_gdbarch" with method call.
9723         * ada-exp.y (parse_type, find_primitive_type, type_char)
9724         (type_system_address): Replace "parse_gdbarch" with method call.
9725
9726 2019-04-04  Tom Tromey  <tom@tromey.com>
9727
9728         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
9729         * stap-probe.c (stap_parse_argument): Update.
9730         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
9731         initial_size parameter.
9732         * rust-exp.y (rust_lex_tests): Update.
9733         * parse.c (parser_state): Update.
9734         (parse_exp_in_context): Update.
9735         * parser-defs.h (struct parser_state) <parser_state>: Remove
9736         "initial_size" parameter.
9737
9738 2019-04-04  Tom Tromey  <tom@tromey.com>
9739
9740         * parser-defs.h (increase_expout_size): Don't declare.
9741         * parse.c (increase_expout_size): Now static.
9742
9743 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
9744
9745         * gnu-nat.c (gnu_nat_target::wait): Fix
9746         target_waitstatus_to_string call.
9747
9748 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9749
9750         * eval.c (evaluate_subexp_standard): Handle internal functions
9751         during Fortran function call handling.
9752
9753 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
9754
9755         * NEWS: Mention new internal functions.
9756         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
9757         (read_base_type): Use dwarf2_init_complex_target_type.
9758         * value.c (creal_internal_fn): New function.
9759         (cimag_internal_fn): New function.
9760         (_initialize_values): Register new internal functions.
9761
9762 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9763
9764         * infrun.c (stop_all_threads): If debug_infrun, always
9765         trace the wait status after wait_one, using
9766         target_waitstatus_to_string and target_pid_to_str.
9767         (handle_inferior_event): Replace various trace of
9768         wait status kind by a single trace.
9769         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
9770         wait status kind image by target_waitstatus_to_string.
9771         * target/waitstatus.c (target_waitstatus_to_string): Fix
9772         obsolete comment.
9773
9774 2019-04-01  Tom Tromey  <tromey@adacore.com>
9775
9776         PR symtab/23331:
9777         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
9778
9779 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
9780             Pedro Alves  <palves@redhat.com>
9781
9782         * top.c (quit_force): Call 'finalize_values'.
9783         * value.c (finalize_values): New function.
9784         * value.h (finalize_values): Declare.
9785
9786 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
9787
9788         * NEWS: Announce $_gdb_major and $_gdb_minor.
9789
9790         * top.c (init_gdb_version_vars): New function.
9791         (gdb_init): Call init_gdb_version_vars.
9792
9793 2019-03-29  Tom Tromey  <tromey@adacore.com>
9794
9795         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
9796         help text.  Remove dead code.
9797
9798 2019-03-29  Keith Seitz  <keiths@redhat.com>
9799
9800         From Siddhesh Poyarekar:
9801         * f-lang.h (f77_get_upperbound): Return LONGEST.
9802         (f77_get_lowerbound): Likewise.
9803         * f-typeprint.c (f_type_print_varspec_suffix): Expand
9804         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
9805         print them.
9806         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
9807         plongest to format print it.
9808         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
9809         (f77_get_upperbound): Likewise.
9810         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
9811         LOWER_BOUND to LONGEST.
9812         (f77_create_arrayprint_offset_tbl): Likewise.
9813
9814 2019-03-29  Keith Seitz  <keiths@redhat.com>
9815
9816         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
9817         %s/pulongest for TYPE_LENGTH instead of %d in format
9818         strings.
9819         * ada-typerint.c (ada_print_type): Likewise.
9820         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
9821         * compile/compile-c-support.c (generate_register_struct): Likewise.
9822         * gdbtypes.c (recursive_dump_type): Likewise.
9823         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
9824         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
9825         instead of %d in format strings.
9826         * riscv-tdep.c (riscv_type_alignment): Cast second argument
9827         to std::min to ULONGEST.
9828         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
9829         instead of %d in format strings.
9830         * tracepoint.c (info_scope_command): Likewise.
9831         * typeprint.c (print_offset_data::update)
9832         (print_offset_data::finish): Likewise.
9833         * xtensa-tdep.c (xtensa_store_return_value)
9834         (xtensa_push_dummy_call): Likewise.
9835
9836 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
9837
9838         * windows-nat.c (display_selector): Fixed format specifications
9839         for 64-bit Cygwin.
9840
9841 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9842
9843         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
9844
9845 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
9846
9847         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
9848         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
9849         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
9850         (nios2_linux_init_abi): Install it.
9851
9852 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9853
9854         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
9855
9856 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
9857
9858         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
9859
9860 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9861             Tom Tromey  <tromey@adacore.com>
9862
9863         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
9864
9865 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
9866
9867         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
9868         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
9869         method to compute the bounds of range types. Also print "[evaluated]"
9870         if the bounds' values come from a dynamic evaluation.
9871
9872 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
9873
9874         * cp-valprint.c (cp_print_value_fields): Don't print trailing
9875         whitespace when pretty printing is on.
9876
9877 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9878
9879         * ppc-linux-nat.c: Add include.
9880
9881 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9882
9883         * NEWS: Mention AArch64 Pointer Authentication.
9884
9885 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
9886
9887         * arm-linux-nat.c: Add include.
9888
9889 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
9890
9891         * source-cache.c (source_cache::get_source_lines): Re-read
9892         fullname after calling open_source_file.
9893
9894 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
9895
9896         * NEWS: Mention TLS support for FreeBSD.
9897
9898 2019-03-25  Tom Tromey  <tromey@adacore.com>
9899
9900         * minsyms.c (BUNCH_SIZE): Update comment.
9901         (~minimal_symbol_reader): Remove old comment.
9902         (compact_minimal_symbols): Update comment.
9903         (minimal_symbol_reader::install): Remove old comment.  Update
9904         other comments.
9905
9906 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9907
9908         * s390-linux-nat.c: Add include.
9909
9910 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
9911
9912         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
9913         Call linux_get_hwcap.
9914         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
9915         Likewise.
9916         (aarch64_linux_get_hwcap): Remove function.
9917         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
9918         declaration.
9919         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
9920         linux_get_hwcap.
9921         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
9922         * linux-tdep.c (linux_get_hwcap): Add function.
9923         (linux_get_hwcap2): Likewise.
9924         * linux-tdep.h (linux_get_hwcap): Add declaration.
9925         (linux_get_hwcap2): Likewise.
9926         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
9927         (ppc_linux_get_hwcap2): Likewise.
9928         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
9929         linux_get_hwcap.
9930         (ppc_linux_nat_target::insert_watchpoint): Likewise.
9931         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
9932         (ppc_linux_nat_target::read_description): Likewise.
9933         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
9934         * s390-linux-nat.c: Likewise.
9935         * s390-linux-tdep.c (s390_core_read_description): Likewise.
9936
9937 2019-03-24  Tom Tromey  <tom@tromey.com>
9938
9939         * ada-lang.c (standard_lookup): Simplify initialization.
9940         (ada_lookup_symbol_nonlocal): Simplify return.
9941         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
9942         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
9943         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
9944         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
9945         initialization.
9946         * solib.c (solib_global_lookup): Simplify.
9947         * symtab.c (null_block_symbol): Remove.
9948         (symbol_cache_lookup): Simplify returns.
9949         (lookup_language_this): Simplify returns.
9950         (lookup_symbol_aux): Simplify return.
9951         (lookup_local_symbol): Simplify returns.
9952         (lookup_global_symbol_from_objfile): Simplify return.
9953         (lookup_symbol_in_objfile_symtabs)
9954         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
9955         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
9956         (lookup_static_symbol, lookup_global_symbol): Simplify return.
9957         * cp-namespace.c (cp_lookup_bare_symbol)
9958         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
9959         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
9960         (cp_lookup_nested_symbol): Don't use null_block_symbol.
9961         (cp_lookup_symbol_via_imports): Simplify initialization.
9962         (find_symbol_in_baseclass): Likewise.
9963         * symtab.h (null_block_symbol): Remove.
9964         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
9965         (d_lookup_nested_symbol, d_lookup_symbol_imports)
9966         (d_lookup_symbol_module): Likewise.
9967         (find_symbol_in_baseclass): Simplify initialization.
9968
9969 2019-03-24  Tom Tromey  <tom@tromey.com>
9970
9971         * expression.h: Don't include symtab.h.
9972         (struct block): Forward declare.
9973
9974 2019-03-24  Tom Tromey  <tom@tromey.com>
9975
9976         * c-exp.y (typebase): Remove casts.
9977         * gdbtypes.c (lookup_unsigned_typename, )
9978         (lookup_signed_typename): Remove cast.
9979         * eval.c (parse_to_comma_and_eval): Remove cast.
9980         * parse.c (write_dollar_variable): Remove cast.
9981         * block.h (struct block) <superblock>: Now const.
9982         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
9983         * psymtab.c (psym_map_matching_symbols): Make "block" const.
9984         (map_block): Make "block" const.
9985         * symfile.h (struct quick_symbol_functions)
9986         <map_matching_symbols>: Constify block argument to "callback".
9987         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
9988         const.
9989         (find_pc_sect_compunit_symtab): Make "b" const.
9990         (find_symbol_at_address): Likewise.
9991         (search_symbols): Likewise.
9992         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
9993         (dw2_debug_names_lookup_symbol): Likewise.
9994         (dw2_map_matching_symbols): Update.
9995         * p-valprint.c (pascal_val_print): Remove "block".
9996         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
9997         (aux_add_nonlocal_symbols): Make "block" const.
9998         (resolve_subexp): Remove cast.
9999         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
10000         const.
10001         (iterate_over_file_blocks): Likewise.
10002         * f-exp.y (%union) <bval>: Remove.
10003         * coffread.c (patch_opaque_types): Make "b" const.
10004         * spu-tdep.c (spu_catch_start): Make "block" const.
10005         * c-valprint.c (print_unpacked_pointer): Remove "block".
10006         * symmisc.c (dump_symtab_1): Make "b" const.
10007         (block_depth): Make "block" const.
10008         * d-exp.y (%union) <bval>: Remove.
10009         * cp-support.h (cp_lookup_rtti_type): Update.
10010         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
10011         * psymtab.c (psym_lookup_symbol): Make "block" const.
10012         (maintenance_check_psymtabs): Make "b" const.
10013         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
10014         (enumerate_locals, enumerate_args): Update.
10015         * python/py-symtab.c (stpy_global_block): Make "block" const.
10016         (stpy_static_block): Likewise.
10017         * inline-frame.c (block_starting_point_at): Make "new_block"
10018         const.
10019         * block.c (find_block_in_blockvector): Make return type const.
10020         (blockvector_for_pc_sect): Make "b" const.
10021         (find_block_in_blockvector): Make "b" const.
10022
10023 2019-03-23  Tom Tromey  <tom@tromey.com>
10024
10025         * varobj.c (varobj_create): Update.
10026         * symfile.c (clear_symtab_users): Don't reset innermost_block.
10027         * printcmd.c (display_command, do_one_display): Don't reset
10028         innermost_block.
10029         * parser-defs.h (enum innermost_block_tracker_type): Move to
10030         expression.h.
10031         (innermost_block): Update comment.
10032         * parse.c (parse_exp_1): Add tracker_types parameter.
10033         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
10034         tracker_types parameter.  Reset innermost_block.
10035         (parse_exp_in_context): Remove.
10036         (parse_expression_for_completion): Update.
10037         * objfiles.c (~objfile): Don't reset expression_context_block or
10038         innermost_block.
10039         * expression.h (enum innermost_block_tracker_type): Move from
10040         parser-defs.h.
10041         (parse_exp_1): Add tracker_types parameter.
10042         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
10043         reset innermost_block.
10044
10045 2019-03-23  Tom Tromey  <tom@tromey.com>
10046
10047         * objfiles.h: Include bcache.h.
10048
10049 2019-03-23  Tom Tromey  <tom@tromey.com>
10050
10051         * linespec.c (get_current_search_block): Use
10052         scoped_restore_current_language.
10053         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
10054
10055 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10056             Jiong Wang  <jiong.wang@arm.com>
10057
10058         * aarch64-linux-tdep.c
10059         (aarch64_linux_iterate_over_regset_sections): Check for pauth
10060         section.
10061         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
10062
10063 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10064             Jiong Wang  <jiong.wang@arm.com>
10065
10066         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
10067         instructions.
10068         (aarch64_analyze_prologue_test): Add PACIASP test.
10069         (aarch64_prologue_prev_register): Unmask PC value.
10070
10071 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10072             Jiong Wang  <jiong.wang@arm.com>
10073
10074         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
10075         (aarch64_dwarf2_prev_register): Unmask PC value.
10076         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
10077         (aarch64_execute_dwarf_cfa_vendor_op): Check for
10078         DW_CFA_AARCH64_negate_ra_state.
10079         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
10080
10081 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10082             Jiong Wang  <jiong.wang@arm.com>
10083
10084         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
10085         registers.
10086         (aarch64_pseudo_register_name): Likewise.
10087         (aarch64_pseudo_register_type): Likewise.
10088         (aarch64_pseudo_register_reggroup_p): Likewise.
10089         (aarch64_gdbarch_init): Add pauth registers.
10090         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
10091         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
10092         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
10093         (struct gdbarch_tdep): Add regnum for ra_state.
10094
10095 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10096             Jiong Wang  <jiong.wang@arm.com>
10097
10098         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
10099
10100 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10101             Jiong Wang  <jiong.wang@arm.com>
10102
10103         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
10104         function.
10105         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
10106         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
10107         (aarch64_gdbarch_init): Add puth registers.
10108         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
10109         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
10110         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
10111
10112 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10113             Jiong Wang  <jiong.wang@arm.com>
10114
10115         * aarch64-linux-nat.c
10116         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
10117         * aarch64-linux-tdep.c
10118         (aarch64_linux_core_read_description): Likewise.
10119         (aarch64_linux_get_hwcap): New function.
10120         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
10121         (aarch64_linux_get_hwcap): New declaration.
10122
10123 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
10124             Jiong Wang  <jiong.wang@arm.com>
10125
10126         * aarch64-linux-nat.c
10127         (aarch64_linux_nat_target::read_description): Add pauth param.
10128         * aarch64-linux-tdep.c
10129         (aarch64_linux_core_read_description): Likewise.
10130         * aarch64-tdep.c (struct target_desc): Add in pauth.
10131         (aarch64_read_description): Add pauth param.
10132         (aarch64_gdbarch_init): Likewise.
10133         * aarch64-tdep.h (aarch64_read_description): Likewise.
10134         * arch/aarch64.c (aarch64_create_target_description): Likewise.
10135         * arch/aarch64.h (aarch64_create_target_description): Likewise.
10136         * features/Makefile: Add new files.
10137         * features/aarch64-pauth.c: New file.
10138         * features/aarch64-pauth.xml: New file.
10139
10140 2019-03-20  Tom Tromey  <tromey@adacore.com>
10141
10142         * infrun.c (handle_inferior_event): Rename from
10143         handle_inferior_event_1.  Create a scoped_value_mark.
10144         (handle_inferior_event): Remove.
10145
10146 2019-03-19  Tom Tromey  <tromey@adacore.com>
10147
10148         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
10149         * infrun.h (print_stop_event): Add "displays" parameter.
10150         * infrun.c (print_stop_event): Add "displays" parameter.
10151
10152 2019-03-19  Pedro Alves  <palves@redhat.com>
10153
10154         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
10155         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
10156         to -1.  Fix TABs vs spaces.
10157         (tui_ui_out::tui_ui_out): Don't initialize fields here.
10158         * tui/tui-out.h (tui_ui_out) Add intro comments.
10159         <m_line, m_start_of_line>: In-class initialize, and add describing
10160         comment.
10161
10162 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
10163
10164         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
10165         variable names.
10166         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
10167
10168 2019-03-18  Pedro Alves  <palves@redhat.com>
10169             Eli Zaretskii <eliz@gnu.org>
10170
10171         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
10172         m_line and m_start_of_line.
10173
10174 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
10175
10176         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
10177         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
10178         it returns a newline.  This fixes a regression in TU mode, whereby
10179         the next line is output on the same screen line as the user input.
10180
10181 2019-03-18  Tom Tromey  <tromey@adacore.com>
10182
10183         * minsyms.c (minimal_symbol_reader::install): Remove call to
10184         obstack_blank.
10185
10186 2019-03-18  Pedro Alves  <palves@redhat.com>
10187
10188         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
10189         New globals.
10190         (apply_style): New, factored out from ...
10191         (apply_ansi_escape): ... this.  Handle reverse video mode.
10192         (tui_set_reverse_mode): New function.
10193         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
10194         * tui/tui-winsource.c (tui_show_source_line): Use
10195         tui_set_reverse_mode instead of setting A_STANDOUT.
10196         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
10197         New setter methods.
10198
10199 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
10200
10201         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
10202         Handle tabs.
10203
10204 2019-03-18  Tom Tromey  <tromey@adacore.com>
10205
10206         * ada-lang.c (empty_array): Add "high" parameter.
10207         (ada_evaluate_subexp): Update.
10208
10209 2019-03-17  Sergei Trofimovich <siarheit@google.com>
10210
10211         * unittests/string_view-selftests.c: Define
10212         _initialize_string_view_selftests unconditionally.
10213
10214 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10215
10216         PR gdb/24350
10217         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
10218
10219 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
10220
10221         PR gdb/24351
10222         * windows-nat.c (display_selector): Fix format specifiers.
10223
10224 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
10225
10226         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
10227         tui_refill_source_window instead of tui_refresh_win, to update the
10228         current execution line.  This fixes redisplay of the current line
10229         when stepping through the code with "next" or "step".
10230
10231 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10232
10233         * source-cache.c (source_cache::get_source_lines): Call
10234         find_source_lines to initialize s->nlines.  This fixes vertical
10235         scrolling of TUI source window when the DOWN arrow is pressed.
10236
10237 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10238
10239         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
10240         linux-thread-db.c (_initialize_thread_db): Likewise.
10241
10242 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
10243
10244         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
10245         wclrtoeol in tui_show_source_line".  This reverts changes made in
10246         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
10247
10248 2019-03-15  Tom Tromey  <tom@tromey.com>
10249
10250         * symtab.h (struct minimal_symbol): Derive from
10251         general_symbol_info.
10252         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
10253         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
10254         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
10255         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
10256         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
10257         (MSYMBOL_SEARCH_NAME): Update.
10258         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
10259         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
10260         * minsyms.c (minimal_symbol_reader::record_full): Update.
10261
10262 2019-03-15  Tom Tromey  <tom@tromey.com>
10263
10264         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
10265
10266 2019-03-15  Tom Tromey  <tom@tromey.com>
10267
10268         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
10269         unique_xmalloc_ptr.
10270         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
10271         Update.
10272         * minsyms.c (lookup_minimal_symbol_by_pc_section)
10273         (build_minimal_symbol_hash_tables)
10274         (minimal_symbol_reader::install): Update.
10275
10276 2019-03-15  Tom Tromey  <tom@tromey.com>
10277
10278         * symtab.c (create_demangled_names_hash): Update.
10279         (symbol_set_names): Update.
10280         * objfiles.h (struct objfile_per_bfd_storage)
10281         <demangled_names_hash>: Now an htab_up.
10282         * objfiles.c (objfile_per_bfd_storage): Simplify.
10283
10284 2019-03-15  Tom Tromey  <tom@tromey.com>
10285
10286         * objfiles.h (struct objfile_per_bfd_storage): Declare
10287         destructor.
10288         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
10289         New.
10290         (get_objfile_bfd_data): Use new.  Don't initialize
10291         language_of_main.
10292         (free_objfile_per_bfd_storage): Remove.
10293         (objfile_bfd_data_free, objfile::~objfile): Use delete.
10294
10295 2019-03-15  Tom Tromey  <tom@tromey.com>
10296
10297         * symfile.c (reread_symbols): Update.
10298         * objfiles.c (objfile::objfile): Update.
10299         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
10300         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
10301         comment.
10302         (minimal_symbol_reader::install): Update.
10303         (terminate_minimal_symbol_table): Remove.
10304         * jit.c (jit_object_close_impl): Update.
10305
10306 2019-03-15  Tom Tromey  <tom@tromey.com>
10307
10308         * minsyms.c (minimal_symbol_reader::record_full): Remove some
10309         initializations.
10310
10311 2019-03-15  Tom Tromey  <tom@tromey.com>
10312
10313         * objfiles.h (struct objfile_per_bfd_storage)
10314         <demangled_hash_languages>: Now a bitset.
10315         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
10316         (lookup_minimal_symbol): Update.
10317
10318 2019-03-15  Tom Tromey  <tom@tromey.com>
10319
10320         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
10321         Don't return the symbol.
10322         * coffread.c (record_minimal_symbol): Use record_full.
10323
10324 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
10325
10326         The MS-Windows port of ncurses fails to switch to a color pair if
10327         one or both of the colors are the implicit default colors.  This
10328         change records the default colors when TUI is initialized, and
10329         then specifies them explicitly when a color pair uses the default
10330         colors.  This allows color styling in TUI mode on MS-Windows.
10331
10332         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
10333         ncurses_norm_attr.
10334         (tui_initialize_io) [__MINGW32__]: Record the default terminal
10335         colors in ncurses_norm_attr.
10336         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
10337         "none", replace it with the default color recorded in
10338         ncurses_norm_attr.
10339
10340 2019-03-14  Tom Tromey  <tromey@adacore.com>
10341
10342         * source-cache.h (class source_cache) <get_source_lines>: Return
10343         std::string.
10344         * source-cache.c (source_cache::extract_lines): Handle case where
10345         first_pos==npos.  Return std::string.
10346         (source_cache::get_source_lines): Update.
10347
10348 2019-03-14  Tom Tromey  <tromey@adacore.com>
10349
10350         * NEWS: Add item for "style sources" commands.
10351         * source-cache.c (source_cache::get_source_lines): Check
10352         source_styling.
10353         * cli/cli-style.c (source_styling): New global.
10354         (_initialize_cli_style): Add "style sources" commands.
10355         (show_style_sources): New function.
10356         * cli/cli-style.h (source_styling): Declare.
10357
10358 2019-03-14  Pedro Alves  <palves@redhat.com>
10359             Tom Tromey  <tromey@adacore.com>
10360
10361         * tui/tui-winsource.h (tui_refill_source_window): Declare.
10362         * tui/tui-winsource.c (tui_refill_source_window): New function,
10363         from...
10364         (tui_horizontal_source_scroll): ... here.  Move some logic.
10365         * cli/cli-style.c (set_style_enabled): Notify new observable.
10366         * tui/tui-hooks.c (tui_redisplay_source): New function.
10367         (tui_attach_detach_observers): Attach or detach
10368         tui_redisplay_source.
10369         * observable.h (source_styling_changed): New observable.
10370         * observable.c: Define source_styling_changed observable.
10371
10372 2019-03-13  Tom Tromey  <tromey@adacore.com>
10373
10374         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
10375         (i386_gnu_nat_target::store_registers): Update.
10376         * target-debug.h (target_debug_print_std_string): New macro.
10377         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
10378         * windows-tdep.c (display_one_tib): Update.
10379         * tui/tui-stack.c (tui_make_status_line): Update.
10380         * top.c (print_inferior_quit_action): Update.
10381         * thread.c (thr_try_catch_cmd): Update.
10382         (add_thread_with_info): Update.
10383         (thread_target_id_str): Update.
10384         (thr_try_catch_cmd): Update.
10385         (thread_command): Update.
10386         (thread_find_command): Update.
10387         * record-btrace.c (record_btrace_target::info_record)
10388         (record_btrace_resume_thread, record_btrace_target::resume)
10389         (record_btrace_cancel_resume, record_btrace_step_thread)
10390         (record_btrace_target::wait, record_btrace_target::wait)
10391         (record_btrace_target::wait, record_btrace_target::stop): Update.
10392         * progspace.c (print_program_space): Update.
10393         * process-stratum-target.c
10394         (process_stratum_target::thread_address_space): Update.
10395         * linux-fork.c (linux_fork_mourn_inferior)
10396         (detach_checkpoint_command, info_checkpoints_command)
10397         (linux_fork_context): Update.
10398         (linux_fork_detach): Update.
10399         (class scoped_switch_fork_info): Update.
10400         (delete_checkpoint_command): Update.
10401         * infrun.c (follow_fork_inferior): Update.
10402         (follow_fork_inferior): Update.
10403         (proceed_after_vfork_done): Update.
10404         (handle_vfork_child_exec_or_exit): Update.
10405         (follow_exec): Update.
10406         (displaced_step_prepare_throw): Update.
10407         (displaced_step_restore): Update.
10408         (start_step_over): Update.
10409         (resume_1): Update.
10410         (clear_proceed_status_thread): Update.
10411         (proceed): Update.
10412         (print_target_wait_results): Update.
10413         (do_target_wait): Update.
10414         (context_switch): Update.
10415         (stop_all_threads): Update.
10416         (restart_threads): Update.
10417         (finish_step_over): Update.
10418         (handle_signal_stop): Update.
10419         (switch_back_to_stepped_thread): Update.
10420         (keep_going_pass_signal): Update.
10421         (print_exited_reason): Update.
10422         (normal_stop): Update.
10423         * inferior.c (inferior_pid_to_str): Change return type.
10424         (print_selected_inferior): Update.
10425         (add_inferior): Update.
10426         (detach_inferior): Update.
10427         * dummy-frame.c (fprint_dummy_frames): Update.
10428         * dcache.c (dcache_info_1): Update.
10429         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
10430         (btrace_fetch, btrace_clear): Update.
10431         * linux-tdep.c (linux_core_pid_to_str): Change return type.
10432         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
10433         type.
10434         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
10435         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
10436         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
10437         * gdbarch.c, gdbarch.h: Rebuild.
10438         * gdbarch.sh (core_pid_to_str): Change return type.
10439         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
10440         return type.
10441         (windows_nat_target::pid_to_str): Change return type.
10442         (windows_delete_thread): Update.
10443         (windows_nat_target::attach): Update.
10444         (windows_nat_target::files_info): Update.
10445         * target-delegates.c: Rebuild.
10446         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
10447         return type.
10448         (sol_thread_target::pid_to_str): Change return type.
10449         * remote.c (class remote_target) <pid_to_str>: Change return
10450         type.
10451         (remote_target::pid_to_str): Change return type.
10452         (extended_remote_target::attach, remote_target::remote_stop_ns)
10453         (remote_target::remote_notif_remove_queued_reply)
10454         (remote_target::push_stop_reply, remote_target::disable_btrace):
10455         Update.
10456         (extended_remote_target::attach): Update.
10457         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
10458         type.
10459         (gdbsim_target::pid_to_str): Change return type.
10460         * ravenscar-thread.c (struct ravenscar_thread_target)
10461         <pid_to_str>: Change return type.
10462         (ravenscar_thread_target::pid_to_str): Change return type.
10463         * procfs.c (class procfs_target) <pid_to_str>: Change return
10464         type.
10465         (procfs_target::pid_to_str): Change return type.
10466         (procfs_target::attach): Update.
10467         (procfs_target::detach): Update.
10468         (procfs_target::fetch_registers): Update.
10469         (procfs_target::store_registers): Update.
10470         (procfs_target::wait): Update.
10471         (procfs_target::files_info): Update.
10472         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
10473         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
10474         return type.
10475         (nto_procfs_target::pid_to_str): Change return type.
10476         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
10477         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
10478         return type.
10479         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
10480         (exit_lwp): Update.
10481         (attach_proc_task_lwp_callback, get_detach_signal)
10482         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
10483         (linux_nat_target::resume, wait_lwp, stop_callback)
10484         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
10485         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
10486         (linux_nat_wait_1, resume_stopped_resumed_lwps)
10487         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
10488         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
10489         type.
10490         (inf_ptrace_target::attach): Update.
10491         (inf_ptrace_target::files_info): Update.
10492         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
10493         type.
10494         (go32_nat_target::pid_to_str): Change return type.
10495         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
10496         (gnu_nat_target::wait): Update.
10497         (gnu_nat_target::wait): Update.
10498         (gnu_nat_target::resume): Update.
10499         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
10500         (fbsd_nat_target::wait): Update.
10501         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
10502         type.
10503         (darwin_nat_target::attach): Update.
10504         * corelow.c (class core_target) <pid_to_str>: Change return type.
10505         (core_target::pid_to_str): Change return type.
10506         * target.c (normal_pid_to_str): Change return type.
10507         (default_pid_to_str): Likewise.
10508         (target_pid_to_str): Change return type.
10509         (target_translate_tls_address): Update.
10510         (target_announce_detach): Update.
10511         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
10512         return type.
10513         (bsd_uthread_target::pid_to_str): Change return type.
10514         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
10515         type.
10516         (bsd_kvm_target::pid_to_str): Change return type.
10517         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
10518         return type.
10519         (aix_thread_target::pid_to_str): Change return type.
10520         * target.h (struct target_ops) <pid_to_str>: Change return type.
10521         (target_pid_to_str, normal_pid_to_str): Likewise.
10522         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
10523         type.
10524         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
10525         type.
10526         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
10527         return type.
10528         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
10529         type.
10530         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
10531         type.
10532         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
10533         return type.
10534
10535 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
10536
10537         * NEWS: Mention that the new default MI version is 3.  Mention
10538         changes to the output of commands and events that deal with
10539         multi-location breakpoints.
10540         * breakpoint.c: Include "mi/mi-out.h".
10541         (print_one_breakpoint): Change output syntax if using MI version
10542         >= 3.
10543         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
10544         New.
10545         (mi_multi_location_breakpoint_output_fixed): New.
10546         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
10547         (mi_cmd_fix_multi_location_breakpoint_output): New.
10548         (mi_multi_location_breakpoint_output_fixed): New.
10549         * mi/mi-cmds.c (mi_cmds): Register command
10550         -fix-multi-location-breakpoint-output.
10551         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
10552         interpreter "mi".
10553
10554 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
10555
10556         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
10557         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
10558         instantiate mi_ui_out based on interpreter name.
10559         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
10560         * mi/mi-main.c (mi_load_progress): Likewise.
10561
10562 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10563
10564         * NEWS: Combine separate "New targets" sections for 8.3.
10565
10566 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10567
10568         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
10569         (ppcfbsd_init_abi): Install gdbarch
10570         "fetch_tls_load_module_address" and "get_thread_local_address"
10571         methods.
10572
10573 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10574
10575         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
10576         (riscv_fbsd_init_abi): Install gdbarch
10577         "fetch_tls_load_module_address" and "get_thread_local_address"
10578         methods.
10579
10580 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10581
10582         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
10583         (i386fbsd_init_abi): Install gdbarch
10584         "fetch_tls_load_module_address" and "get_thread_local_address"
10585         methods.
10586
10587 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10588
10589         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
10590         (amd64fbsd_init_abi): Install gdbarch
10591         "fetch_tls_load_module_address" and "get_thread_local_address"
10592         methods.
10593
10594 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10595
10596         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
10597         (struct fbsd_pspace_data): New type.
10598         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
10599         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
10600         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
10601         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
10602         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
10603
10604 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10605
10606         * gdbtypes.c (lookup_struct_elt): New function.
10607         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
10608         * gdbtypes.h (struct struct_elt): New type.
10609         (lookup_struct_elt): New prototype.
10610
10611 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10612
10613         * gdbtypes.c (lookup_struct_elt_type): Update comment and
10614         remove disabled code block.
10615
10616 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10617
10618         * gdbarch.sh (get_thread_local_address): New method.
10619         * gdbarch.h, gdbarch.c: Regenerate.
10620         * target.c (target_translate_tls_address): Use
10621         gdbarch_get_thread_local_address if present instead of
10622         target::get_thread_local_address.
10623
10624 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10625
10626         * target.h (target::get_thread_local_address): Update comment.
10627
10628 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10629
10630         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
10631         objfile->separate_debug_objfile_backlink if not NULL.
10632
10633 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10634
10635         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
10636         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
10637         (amd64bsd_store_inferior_registers): Likewise.
10638         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10639         Enable segment base registers.
10640         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
10641         PT_GETFSBASE and PT_GETGSBASE.
10642         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
10643         PT_SETGSBASE.
10644         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
10645         segment base registers.
10646         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10647
10648 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
10649
10650         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
10651         Update calls to i386_target_description to add 'segments'
10652         parameter.
10653         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
10654         add segment base registers.
10655         * arch/i386.c (i386_create_target_description): Add 'segments'
10656         parameter to enable segment base registers.
10657         * arch/i386.h (i386_create_target_description): Likewise.
10658         * features/i386/32bit-segments.xml: New file.
10659         * features/i386/32bit-segments.c: Generate.
10660         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
10661         call to i386_target_description to add 'segments' parameter.
10662         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
10663         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
10664         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
10665         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
10666         if feature is present.
10667         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
10668         Add 'segments' parameter to call to i386_target_description.
10669         (i386_target_description): Add 'segments' parameter to enable
10670         segment base registers.
10671         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
10672         to call to i386_target_description.
10673         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
10674         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
10675         Define I386_NUM_REGS.
10676         (i386_target_description): Add 'segments' parameter to enable
10677         segment base registers.
10678
10679 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
10680
10681         PR/24325
10682         * source-cache.c: #undef open and close, to avoid unresolved
10683         externals during linking.
10684
10685 2019-03-12  Tom Tromey  <tromey@adacore.com>
10686
10687         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
10688         const.  Add initializers.
10689         (_initialize_remote): Don't initialize ptid globals.
10690
10691 2019-03-12  Pedro Alves  <palves@redhat.com>
10692
10693         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
10694
10695 2019-03-12  Pedro Alves  <palves@redhat.com>
10696
10697         * cp-name-parser.y (main): Remove unused 'len' variable.
10698
10699 2019-03-12  Tom Tromey  <tromey@adacore.com>
10700
10701         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
10702         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
10703
10704 2019-03-12  Tom Tromey  <tromey@adacore.com>
10705
10706         * linux-nat.c (iterate_over_lwps): Update.
10707         (stop_callback): Remove parameter.
10708         (stop_wait_callback, detach_callback, resume_set_callback)
10709         (select_singlestep_lwp_callback, set_ignore_sigint)
10710         (status_callback, resumed_callback, resume_clear_callback)
10711         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
10712         data parameter.
10713         (linux_nat_target::detach, linux_nat_target::resume)
10714         (linux_stop_and_wait_all_lwps, select_event_lwp)
10715         (linux_nat_filter_event, linux_nat_wait_1)
10716         (linux_nat_target::kill, linux_nat_target::stop)
10717         (linux_nat_target::stop): Update.
10718         (linux_nat_resume_callback): Change type.
10719         (resume_stopped_resumed_lwps, count_events_callback)
10720         (select_event_lwp_callback): Likewise.
10721         (linux_stop_lwp, linux_nat_stop_lwp): Update.
10722         * arm-linux-nat.c (struct update_registers_data): Remove.
10723         (update_registers_callback): Change type.
10724         (arm_linux_insert_hw_breakpoint1): Update.
10725         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
10726         parameter.
10727         (x86_linux_dr_set_addr): Update.
10728         (x86_linux_dr_set_control): Update.
10729         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
10730         (iterate_over_lwps): Use gdb::function_view.
10731         * nat/aarch64-linux-hw-point.c (struct
10732         aarch64_dr_update_callback_param): Remove.
10733         (debug_reg_change_callback): Change type.
10734         (aarch64_notify_debug_reg_change): Update.
10735         * s390-linux-nat.c (s390_refresh_per_info): Update.
10736
10737 2019-03-11  Tom Tromey  <tromey@adacore.com>
10738
10739         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
10740         redundant assignment to "this_cu".
10741
10742 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10743
10744         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
10745
10746 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10747
10748         * gdbtypes.c (rank_one_type_parm_set): New function extracted
10749         from...
10750         (rank_one_type): ... this.
10751
10752 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10753
10754         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
10755         from...
10756         (rank_one_type): ... this.
10757
10758 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10759
10760         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
10761         from...
10762         (rank_one_type): ... this.
10763
10764 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10765
10766         * gdbtypes.c (rank_one_type_parm_float): New function extracted
10767         from...
10768         (rank_one_type): ... this.
10769
10770 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10771
10772         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
10773         from...
10774         (rank_one_type): ... this.
10775
10776 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10777
10778         * gdbtypes.c (rank_one_type_parm_range): New function extracted
10779         from...
10780         (rank_one_type): ... this.
10781
10782 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10783
10784         * gdbtypes.c (rank_one_type_parm_char): New function extracted
10785         from...
10786         (rank_one_type): ... this.
10787
10788 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10789
10790         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
10791         from...
10792         (rank_one_type): ... this.
10793
10794 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10795
10796         * gdbtypes.c (rank_one_type_parm_int): New function extracted
10797         from...
10798         (rank_one_type): ... this.
10799
10800 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10801
10802         * gdbtypes.c (rank_one_type_parm_func): New function extracted
10803         from...
10804         (rank_one_type): ... this.
10805
10806 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10807
10808         * gdbtypes.c (rank_one_type_parm_array): New function extracted
10809         from...
10810         (rank_one_type): ... this.
10811
10812 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
10813
10814         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
10815         from...
10816         (rank_one_type): ... this.
10817
10818 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10819
10820         * inferior.c (initialize_inferiors): Ensure 'help set/show print
10821         inferior-events' shows the example events.
10822
10823 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
10824
10825         Support styling on native MS-Windows console
10826
10827         PR/24315
10828         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
10829         on MS-Windows if $TERM is not defined.
10830
10831         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
10832
10833         * posix-hdep.c (gdb_console_fputs):
10834         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
10835         functions.
10836         * ui-file.h (gdb_console_fputs): Add prototype.
10837
10838         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
10839         back to fputs only if the former returns zero.
10840
10841 2019-03-07  Tom Tromey  <tom@tromey.com>
10842
10843         * symmisc.c (print_symbol_bcache_statistics): Update.
10844         (print_objfile_statistics): Update.
10845         * symfile.c (allocate_symtab): Update.
10846         * stabsread.c: Don't include bcache.h.
10847         * psymtab.h (struct psymbol_bcache): Don't declare.
10848         (class psymtab_storage) <psymbol_cache>: Now a bcache.
10849         (psymbol_bcache_init, psymbol_bcache_free)
10850         (psymbol_bcache_get_bcache): Don't declare.
10851         * psymtab.c (struct psymbol_bcache): Remove.
10852         (psymtab_storage::psymtab_storage): Update.
10853         (psymtab_storage::~psymtab_storage): Update.
10854         (psymbol_bcache_init, psymbol_bcache_free)
10855         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
10856         (add_psymbol_to_bcache): Update.
10857         (allocate_psymtab): Update.
10858         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
10859         macro_cache>: No longer pointers.
10860         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
10861         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
10862         * macrotab.c (macro_bcache): Update.
10863         * macroexp.c: Don't include bcache.h.
10864         * gdbtypes.c (check_types_worklist): Update.
10865         (types_deeply_equal): Remove TRY/CATCH.  Update.
10866         * elfread.c (elf_symtab_read): Update.
10867         * dwarf2read.c: Don't include bcache.h.
10868         * buildsym.c (buildsym_compunit::get_macro_table): Update.
10869         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
10870         (print_bcache_statistics, bcache_memory_used): Don't declare.
10871         (struct bcache): Move from bcache.c.  Add constructor, destructor,
10872         methods.  Rename all data members.
10873         * bcache.c (struct bcache): Move to bcache.h.
10874         (bcache::expand_hash_table): Rename from expand_hash_table.
10875         (bcache): Remove.
10876         (bcache::insert): Rename from bcache_full.
10877         (bcache::compare): Rename from bcache_compare.
10878         (bcache_xmalloc): Remove.
10879         (bcache::~bcache): Rename from bcache_xfree.
10880         (bcache::print_statistics): Rename from print_bcache_statistics.
10881         (bcache::memory_used): Rename from bcache_memory_used.
10882
10883 2019-03-07  Pedro Alves  <palves@redhat.com>
10884
10885         * infrun.c (normal_stop): Also check for
10886         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
10887
10888 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
10889
10890         * f-lang.c (value_from_host_double): Moved to...
10891         * value.c (value_from_host_double): ...here.
10892         * value.h (value_from_host_double): Declare.
10893         * guile/scm-math.c (vlscm_convert_typed_number): Use
10894         value_from_host_double.
10895         (vlscm_convert_number): Likewise.
10896         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
10897         * python/py-value.c (convert_value_from_python): Likewise.
10898
10899 2019-03-06  Tom Tromey  <tom@tromey.com>
10900
10901         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
10902
10903 2019-03-06  Tom Tromey  <tom@tromey.com>
10904
10905         * utils.h (free_current_contents): Don't declare.
10906         * utils.c (free_current_contents): Remove.
10907
10908 2019-03-06  Tom Tromey  <tom@tromey.com>
10909
10910         * top.c (quit_force): Update.
10911         * main.c (captured_command_loop): Update.
10912         * common/new-op.c (operator new): Update.
10913         * common/common-exceptions.c (struct catcher)
10914         <save_cleanup_chain>: Remove member.
10915         (exceptions_state_mc_init): Update.
10916         (exception_try_scope_entry): Return nullptr.
10917         (exception_try_scope_exit, exception_rethrow)
10918         (throw_exception_sjlj, throw_exception_cxx): Update.
10919         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
10920         (all_cleanups, do_cleanups, discard_cleanups)
10921         (discard_final_cleanups, save_cleanups, save_final_cleanups)
10922         (restore_cleanups, restore_final_cleanups): Don't declare.
10923         (do_final_cleanups): Remove parameter.
10924         * common/cleanups.c (cleanup_chain, make_cleanup)
10925         (make_cleanup_dtor, all_cleanups, do_cleanups)
10926         (discard_my_cleanups, discard_cleanups)
10927         (discard_final_cleanups, save_my_cleanups, save_cleanups)
10928         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
10929         (null_cleanup): Remove.
10930         (do_final_cleanups): Remove parameter.
10931
10932 2019-03-06  Tom Tromey  <tom@tromey.com>
10933
10934         * remote.c (remote_target::remote_parse_stop_reply): Use
10935         unique_xmalloc_ptr.
10936
10937 2019-03-06  Tom Tromey  <tom@tromey.com>
10938
10939         * stabsread.c (struct stabs_field_info): Rename from field_info.
10940         <list, fnlist>: Add initializers.
10941         <obstack>: New member.
10942         (read_member_functions, read_struct_fields, read_baseclasses):
10943         Allocate on obstack.  Don't use cleanups.
10944         (read_one_struct_field, read_member_functions, read_struct_fields)
10945         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
10946         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
10947         (read_struct_type): Update.
10948
10949 2019-03-06  Tom Tromey  <tom@tromey.com>
10950
10951         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
10952         * common/filestuff.h (make_cleanup_close): Don't declare.
10953         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
10954         Remove.
10955
10956 2019-03-06  Tom Tromey  <tom@tromey.com>
10957
10958         * solib-aix.c: Use make_scope_exit.
10959
10960 2019-03-06  Tom Tromey  <tom@tromey.com>
10961
10962         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
10963         Use make_scope_exit.
10964
10965 2019-03-06  Tom Tromey  <tom@tromey.com>
10966
10967         * solib-svr4.c (disable_probes_interface): Remove parameter.
10968         (svr4_handle_solib_event): Use make_scope_exit.
10969
10970 2019-03-06  Tom Tromey  <tom@tromey.com>
10971
10972         * remote.c (struct stop_reply_deleter): Remove.
10973         (stop_reply_up): Update.
10974         (struct stop_reply): Derive from notif_event.  Don't typedef.
10975         <regcache>: Now a std::vector.
10976         (stop_reply_xfree): Remove.
10977         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
10978         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
10979         (remote_target::discard_pending_stop_replies): Use delete.
10980         (remote_target::remote_parse_stop_reply): Update.
10981         (remote_target::process_stop_reply): Update.
10982         * remote-notif.h (struct notif_event): Add virtual destructor.
10983         Remove "dtr" member.
10984         (struct notif_client) <alloc_event>: Return a unique_ptr.
10985         (notif_event_xfree): Don't declare.
10986         (notif_event_up): New typedef.
10987         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
10988         (notif_event_xfree, do_notif_event_xfree): Remove.
10989         (remote_notif_state_xfree): Update.
10990
10991 2019-03-06  Tom Tromey  <tom@tromey.com>
10992
10993         * infrun.c (displaced_step_clear_cleanup): Now a
10994         forward_scope_exit type.
10995         (displaced_step_prepare_throw): Update.
10996         (displaced_step_fixup): Update.
10997
10998 2019-03-06  Tom Tromey  <tom@tromey.com>
10999
11000         * inferior.h (class inferior): Update comment.
11001         * gdbthread.h (class thread_info): Update comment.
11002
11003 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
11004             Tom Tromey  <tom@tromey.com>
11005
11006         * stabsread.h (struct stab_section_list): Remove.
11007         (coffstab_build_psymtabs): Update.
11008         * dbxread.c (symbuf_sections): Now a std::vector.
11009         (sect_idx): New global.
11010         (fill_symbuf): Update.
11011         (coffstab_build_psymtabs): Change type of stabsects parameter.
11012         Update.
11013         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
11014         std::vector.
11015         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
11016         (coff_locate_sections): Update.
11017         (coff_symfile_read): Remove cleanups.  Update.
11018         (init_stringtab): Add storage parameter.
11019         (free_stringtab, free_stringtab_cleanup): Remove.
11020         (init_lineno): Add storage parameter.
11021         (free_linetab, free_linetab_cleanup): Remove.
11022
11023 2019-03-06  Pedro Alves  <palves@redhat.com>
11024
11025         * linux-fork.c (fork_info::clobber_regs): Delete.
11026         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
11027         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
11028         comment.  Adjust.
11029         (scoped_switch_fork_info::scoped_switch_fork_info)
11030         (checkpoint_command, linux_fork_context): Adjust
11031         fork_save_infrun_state calls.
11032
11033 2019-03-06  Pedro Alves  <palves@redhat.com>
11034
11035         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
11036         (inf_has_multiple_threads): Return 'bool' and rewrite using
11037         inferior_info::threads().
11038
11039 2019-03-06  Pedro Alves  <palves@redhat.com>
11040
11041         * linux-fork.c: Include <list>.
11042         (fork_list): Now a std::list instance.
11043         (fork_info): Add ctor, dtor, and in-class initialize all fields.
11044         (forks_exist_p, find_last_fork): Adjust.
11045         (new_fork): Delete.
11046         (one_fork_p): New.
11047         (add_fork): Adjust.
11048         (free_fork): Delete, folded into fork_info::~fork_info().
11049         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
11050         Adjust.
11051         (init_fork_list): Delete.
11052         (linux_fork_killall, linux_fork_mourn_inferior)
11053         (linux_fork_detach, info_checkpoints_command): Adjust.
11054         (_initialize_linux_fork): No longer call init_fork_list.
11055
11056 2019-03-06  Pedro Alves  <palves@redhat.com>
11057
11058         * linux-fork.c (new_fork): New, split out of ...
11059         (add_fork): ... this.  Return void.  Move "first fork" special
11060         case from here, to ...
11061         (checkpoint_command): ... here.
11062         * linux-linux.h (add_fork): Return void.
11063
11064 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11065
11066         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
11067
11068 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11069             Chris January  <chris.january@arm.com>
11070             David Lecomber  <david.lecomber@arm.com>
11071
11072         * f-exp.y: New token, UNOP_INTRINSIC.
11073         (exp): New pattern using UNOP_INTRINSIC token.
11074         (f77_keywords): Add 'abs' keyword.
11075         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
11076         (value_from_host_double): New function.
11077         (evaluate_subexp_f): Support UNOP_ABS.
11078
11079 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11080
11081         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
11082         types.
11083
11084 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11085
11086         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
11087         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
11088         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
11089
11090 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11091
11092         * f-exp.y (convert_to_kind_type): Handle more type kinds.
11093
11094 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11095             Chris January  <chris.january@arm.com>
11096
11097         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
11098         * f-exp.y: Define 'KIND' token.
11099         (exp): New pattern for KIND expressions.
11100         (ptype): Handle types with a kind extension.
11101         (direct_abs_decl): Extend to spot kind extensions.
11102         (f77_keywords): Add 'kind' to the list.
11103         (push_kind_type): New function.
11104         (convert_to_kind_type): New function.
11105         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
11106         * parse.c (operator_length_standard): Likewise.
11107         * parser-defs.h (enum type_pieces): Add tp_kind.
11108         * std-operator.def: Add UNOP_KIND.
11109
11110 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11111
11112         * f-exp.y (f_parse): Set yydebug.
11113
11114 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11115
11116         * f-lang.c (evaluate_subexp_f): New function.
11117         (exp_descriptor_f): New global.
11118         (f_language_defn): Use exp_descriptor_f instead of
11119         exp_descriptor_standard.
11120
11121 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11122
11123         * f-exp.y (struct token): Add comments.
11124         (dot_ops): Remove uppercase versions and the end marker.
11125         (f77_keywords): Likewise.
11126         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
11127         entries in the dot_ops array are case insensitive, and use
11128         strncasecmp to compare strings.  Also some whitespace cleanup in
11129         this area.  Similar for the f77_keywords array, except entries in
11130         this list might be case sensitive.
11131
11132 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
11133
11134         * f-exp.y (struct f77_boolean_val): Add comments.
11135         (boolean_values): Remove uppercase versions, and end marker.
11136         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
11137         and use strncasecmp to achieve case insensitivity.  Additionally,
11138         perform whitespace cleanup around this code.
11139
11140 2019-03-06  Tom Tromey  <tromey@adacore.com>
11141
11142         * remote-sim.c (gdbsim_target_open): Use result of
11143         gdb_argv::release.
11144
11145 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
11146         Dirk Schubert  <dirk.schubert@arm.com>
11147         Chris January  <chris.january@arm.com>
11148
11149         * eval.c (evaluate_subexp_standard): Call Fortran argument
11150         wrapping logic.
11151         * f-lang.c (struct value): A value which can be passed into a
11152         Fortran function call.
11153         (fortran_argument_convert): Wrap Fortran arguments in a pointer
11154         where appropriate.
11155         (struct type): Value ready for a Fortran function call.
11156         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
11157         is needed.
11158         * f-lang.h (fortran_argument_convert): Declaration.
11159         (fortran_preserve_arg_pointer): Declaration.
11160         * infcall.c (value_arg_coerce): Call Fortran argument logic.
11161
11162 2019-03-05  Tom Tromey  <tromey@adacore.com>
11163
11164         * python/py-prettyprint.c (print_string_repr): Remove #if.
11165         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
11166
11167 2019-03-05  Tom Tromey  <tromey@adacore.com>
11168
11169         * target.c (the_dummy_target): Move later.  Change type to
11170         "dummy_target".
11171         (initialize_targets): Don't initialize the_dummy_target.
11172
11173 2019-03-05  Tom Tromey  <tromey@adacore.com>
11174
11175         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
11176         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
11177
11178 2019-03-05  Tom Tromey  <tromey@adacore.com>
11179
11180         * windows-nat.c (windows_nat_target::attach)
11181         (windows_nat_target::detach): Don't call gdb_flush.
11182         * valprint.c (generic_val_print, val_print, val_print_string):
11183         Don't call gdb_flush.
11184         * utils.c (defaulted_query): Don't call gdb_flush.
11185         * typeprint.c (print_type_scalar): Don't call gdb_flush.
11186         * target.c (target_announce_detach): Don't call gdb_flush.
11187         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
11188         * remote.c (extended_remote_target::attach): Don't call
11189         gdb_flush.
11190         * procfs.c (procfs_target::detach): Don't call gdb_flush.
11191         * printcmd.c (do_examine): Don't call gdb_flush.
11192         (info_display_command): Don't call gdb_flush.
11193         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
11194         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
11195         * memattr.c (info_mem_command): Don't call gdb_flush.
11196         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
11197         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
11198         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
11199         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
11200         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
11201         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
11202         (gnu_nat_target::detach): Don't call gdb_flush.
11203         * f-valprint.c (f_val_print): Don't call gdb_flush.
11204         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
11205         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
11206         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
11207         gdb_flush.
11208         * c-valprint.c (c_val_print): Don't call gdb_flush.
11209         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
11210
11211 2019-03-05  Tom Tromey  <tromey@adacore.com>
11212
11213         * varobj.c (update_dynamic_varobj_children): Update.
11214         (install_default_visualizer): Use reset, not release.
11215         * value.c (set_internalvar): Update.
11216         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
11217         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
11218         ATTRIBUTE_UNUSED_RESULT.
11219
11220 2019-03-05  Tom Tromey  <tromey@adacore.com>
11221
11222         * remote.c (class scoped_remote_fd) <release>: Add
11223         ATTRIBUTE_UNUSED_RESULT.
11224
11225 2019-03-05  Tom Tromey  <tromey@adacore.com>
11226
11227         * macroexp.c (struct macro_buffer) <release>: Add
11228         ATTRIBUTE_UNUSED_RESULT.
11229
11230 2019-03-05  Tom Tromey  <tromey@adacore.com>
11231
11232         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
11233         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
11234         ATTRIBUTE_UNUSED_RESULT.
11235
11236 2019-03-05  Tom Tromey  <tromey@adacore.com>
11237
11238         * common/scoped_fd.h (class scoped_fd) <release>: Add
11239         ATTRIBUTE_UNUSED_RESULT.
11240
11241 2019-03-05  Tom Tromey  <tromey@adacore.com>
11242
11243         * parser-defs.h (struct parser_state) <release>: Add
11244         ATTRIBUTE_UNUSED_RESULT.
11245
11246 2019-03-05  Tom Tromey  <tromey@adacore.com>
11247
11248         * utils.h (class gdb_argv) <release>: Add
11249         ATTRIBUTE_UNUSED_RESULT.
11250         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
11251
11252 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
11253
11254         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
11255         for-loop range, to avoid compiler warnings.
11256
11257         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
11258         avoid compiler warnings about unused variables.
11259
11260         * NEWS: Mention end of support for native debugging on MS-Windows
11261         before XP.
11262
11263         PR gdb/24292
11264         * common/netstuff.c:
11265         * gdbserver/gdbreplay.c
11266         * gdbserver/remote-utils.c:
11267         * ser-tcp.c:
11268         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
11269         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
11270         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
11271         'getaddrinfo' and 'freeaddrinfo' were not available before
11272         Windows XP, and mingw.org's MinGW headers by default define
11273         _WIN32_WINNT to 0x500.
11274
11275 2019-03-01  Gary Benson <gbenson@redhat.com>
11276
11277         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
11278
11279 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
11280             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
11281
11282         PR gdb/8527
11283         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
11284         set_sigint_trap, clear_sigint_trap.
11285
11286 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11287
11288         * target.c (target_detach): Clear the regcache and the
11289         frame cache.
11290
11291 2019-02-27  Pedro Alves  <palves@redhat.com>
11292
11293         * utils.c (set_screen_size): When we cap the height/width sizes,
11294         tweak the corresponding command variable to show "unlimited":
11295
11296 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
11297             Pedro Alves  <palves@redhat.com>
11298
11299         * utils.c (set_screen_size): Reduce "infinite" rows and columns
11300         before calling rl_set_screen_size.
11301
11302 2019-02-27  Tom Tromey  <tromey@adacore.com>
11303
11304         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
11305         define.
11306         * python/py-value.c: Remove Python 2.4 workaround.
11307         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
11308         workaround.
11309         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
11310         Python 2.4 workaround.
11311         * python/python-internal.h: Remove Python 2.4 comment.
11312         (Py_ssize_t): Don't define.
11313         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
11314         (gdb_Py_DECREF): Remove Python 2.4 workaround.
11315         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
11316         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
11317         * python/python.c (do_start_initialization): Remove Python 2.4
11318         workaround.
11319         * python/py-prettyprint.c (class dummy_python_frame): Remove.
11320         (print_children): Remove Python 2.4 workaround.
11321         * python/py-inferior.c (buffer_procs): Remove Python 2.4
11322         workaround.
11323         (CHARBUFFERPROC_NAME): Remove.
11324         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
11325         Python 2.4 workaround.
11326
11327 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11328
11329         * NEWS: Note minimum Python version.
11330
11331 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
11332
11333         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
11334         code from these functions.  Remove corresponding ifdefs.  Use
11335         Py_buffer_up instead of explicit calls to PyBuffer_Release.
11336         Remove gotos and target of gotos.
11337         (infpy_search_memory): Likewise.
11338
11339 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11340
11341         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
11342         (hppa_gdbarch_init): Don't register deleted functions with
11343         gdbarch.
11344
11345 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11346
11347         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
11348         (h8300_unwind_sp): Delete.
11349         (h8300_dummy_id): Delete.
11350         (h8300_gdbarch_init): Don't register deleted functions with
11351         gdbarch.
11352
11353 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11354
11355         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
11356         (ft32_unwind_pc): Delete.
11357         (ft32_unwind_sp): Delete.
11358         (ft32_gdbarch_init): Don't register deleted functions with
11359         gdbarch.
11360
11361 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11362
11363         * gdb/frv-tdep.c (frv_dummy_id): Delete.
11364         (frv_unwind_pc): Delete.
11365         (frv_unwind_sp): Delete.
11366         (frv_gdbarch_init): Don't register deleted functions with
11367         gdbarch.
11368
11369 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11370
11371         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
11372         (riscv_unwind_pc): Delete.
11373         (riscv_unwind_sp): Delete.
11374         (riscv_gdbarch_init): Don't register deleted functions with
11375         gdbarch.
11376
11377 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11378
11379         * gdb/csky-tdep.c (csky_dummy_id): Delete.
11380         (csky_unwind_pc): Delete.
11381         (csky_unwind_sp): Delete.
11382         (csky_gdbarch_init): Don't register deleted functions with
11383         gdbarch.
11384
11385 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11386
11387         * gdb/cris-tdep.c (cris_dummy_id): Delete.
11388         (cris_unwind_pc): Delete.
11389         (cris_unwind_sp): Delete.
11390         (cris_gdbarch_init): Don't register deleted functions with
11391         gdbarch.
11392
11393 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11394
11395         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
11396         (bfin_unwind_pc): Delete.
11397         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
11398
11399 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11400
11401         * gdb/arm-tdep.c (arm_dummy_id): Delete.
11402         (arm_unwind_pc): Delete.
11403         (arm_unwind_sp): Delete.
11404         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
11405
11406 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11407
11408         * gdb/arc-tdep.c (arc_dummy_id): Delete.
11409         (arc_unwind_pc): Delete.
11410         (arc_unwind_sp): Delete.
11411         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
11412
11413 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11414
11415         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
11416         (alpha_unwind_pc): Delete.
11417         (alpha_gdbarch_init): Don't register deleted functions with
11418         gdbarch.
11419
11420 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11421
11422         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
11423         (aarch64_unwind_pc): Delete.
11424         (aarch64_unwind_sp): Delete.
11425         (aarch64_gdbarch_init): Don't register deleted functions with
11426         gdbarch.
11427
11428 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11429
11430         * gdbtypes.c (type_align): Don't consider static members when
11431         computing structure alignment.
11432
11433 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
11434
11435         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
11436         return 0 for other types.
11437         * arch-utils.c (default_type_align): Always return 0.
11438         * gdbarch.h: Regenerate.
11439         * gdbarch.sh (type_align): Extend comment.
11440         * gdbtypes.c (type_align): Add additional comments, always call
11441         gdbarch_type_align before applying the default rules.
11442         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
11443         generic code will then apply a suitable default.
11444         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
11445         types, return 0 for other types.
11446
11447 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11448
11449         * NEWS: Create a new section for the next release branch.
11450         Rename the section of the current branch, now that it has
11451         been cut.
11452
11453 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
11454
11455         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
11456         * version.in: Bump version to 8.3.50.DATE-git.
11457
11458 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
11459
11460         * aix-thread.c (ptid_cmp): Remove unused variable.
11461         (get_signaled_thread): Likewise.
11462         (store_regs_user_thread): Likewise.
11463         (store_regs_kernel_thread): Likewise.
11464         (fetch_regs_kernel_thread): Remove shadowed variable.
11465
11466 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
11467
11468         * features/riscv/32bit-cpu.xml: Add register numbers.
11469         * features/riscv/32bit-fpu.c: Regenerate.
11470         * features/riscv/32bit-fpu.xml: Add register numbers.
11471         * features/riscv/64bit-cpu.xml: Add register numbers.
11472         * features/riscv/64bit-fpu.c: Regenerate.
11473         * features/riscv/64bit-fpu.xml: Add register numbers.
11474
11475 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
11476
11477         * NEWS: Mention two argument form of gdb.Value constructor.
11478         * python/py-value.c (convert_buffer_and_type_to_value): New
11479         function.
11480         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
11481         Add support for handling an optional second argument.  Call
11482         convert_buffer_and_type_to_value as appropriate.
11483         * python/python-internal.h (Py_buffer_deleter): New struct.
11484         (Py_buffer_up): New typedef.
11485
11486 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
11487
11488         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
11489         instead of releasing ownership.
11490
11491 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
11492
11493         * dwarf2read.c (open_and_init_dwp_file): Call
11494         elf_numsections instead of bfd_count_sections to initialize
11495         dwp_file->num_sections.
11496
11497 2019-02-25  Tom Tromey  <tromey@adacore.com>
11498
11499         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
11500
11501 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
11502
11503         * gcore.in: Add '--readnever' option when invoking GDB.
11504
11505 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11506
11507         * MAINTAINERS: Update my email address.
11508
11509 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
11510
11511         * build-id.c (build_id_to_debug_bfd_1): New function.
11512         (build_id_to_debug_bfd): Look for separate debug file in
11513         sysroot.
11514
11515 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
11516
11517         * gdbarch.sh: Update the copyright year range that is placed into
11518         generated files.
11519
11520 2019-02-22  Keith Seitz  <keiths@redhat.com>
11521
11522         PR symtab/23853
11523         * linespec.c (create_sals_line_offset): Search for the default
11524         symtab's filename instead of its fullname.
11525
11526 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11527
11528         * NEWS: Update style defaults.
11529
11530 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
11531
11532         * main.c (captured_main_1): Disable styling in batch mode.
11533
11534 2019-02-20  Tom Tromey  <tom@tromey.com>
11535
11536         * symtab.c (symtab_symbol_info): Fix typos.
11537
11538 2019-02-20  Tom Tromey  <tromey@adacore.com>
11539
11540         * findcmd.c (_initialize_mem_search): Use upper case for
11541         metasyntactic variables.
11542
11543 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
11544
11545         * aarch64-tdep.c (aarch64_add_reggroups): New function.
11546         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
11547
11548 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
11549
11550         * top.h (source_file_name): Change to std::string.
11551         * top.c (source_file_name): Likewise.
11552         (command_line_input): Adjust.
11553         * cli/cli-script.c (script_from_file): Adjust.
11554
11555 2019-02-19  Tom Tromey  <tromey@adacore.com>
11556
11557         * ravenscar-thread.c
11558         (ravenscar_thread_target::update_thread_list): Don't call
11559         ada_build_task_list.
11560         * ada-lang.h (ada_build_task_list): Don't declare.
11561         * ada-tasks.c (struct ada_tasks_inferior_data)
11562         <task_list_valid_p>: Now bool.
11563         (read_known_tasks, ada_task_list_changed)
11564         (ada_tasks_invalidate_inferior_data): Update.
11565         (read_known_tasks_array): Return bool.
11566         (read_known_tasks_list): Likewise.
11567         (read_known_tasks): Return void.
11568         (ada_build_task_list): Now static.
11569
11570 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
11571
11572         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
11573         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
11574
11575 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11576
11577         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
11578         variant for ada_tasks_pspace_data_handle and
11579         ada_tasks_inferior_data_handle.
11580         (ada_tasks_pspace_data_cleanup): New function.
11581         (ada_tasks_inferior_data_cleanup): New function.
11582
11583 2019-02-17  Tom Tromey  <tom@tromey.com>
11584
11585         * macrotab.h (macro_source_fullname): Return a std::string.
11586         * macrotab.c (macro_include, check_for_redefinition)
11587         (macro_undef, macro_lookup_definition, foreach_macro)
11588         (foreach_macro_in_scope): Update.
11589         (macro_source_fullname): Return a std::string.
11590         * macrocmd.c (show_pp_source_pos): Update.
11591
11592 2019-02-17  Tom Tromey  <tom@tromey.com>
11593
11594         * macrocmd.c (show_pp_source_pos): Style the file names.
11595
11596 2019-02-17  Tom Tromey  <tom@tromey.com>
11597
11598         PR tui/24197:
11599         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
11600
11601 2019-02-17  Tom Tromey  <tom@tromey.com>
11602
11603         * ada-lang.c (user_select_syms): Use filtered printing.
11604         * utils.c (wrap_style): New global.
11605         (desired_style): Remove.
11606         (emit_style_escape): Add stream parameter.
11607         (set_output_style, reset_terminal_style, prompt_for_continue):
11608         Update.
11609         (flush_wrap_buffer): Only flush gdb_stdout.
11610         (wrap_here): Set wrap_style.
11611         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
11612         treat escape sequences as a character.  Change when wrap buffer is
11613         flushed.
11614         (fputs_styled): Do not set the output style when the default is
11615         requested.
11616         * ui-style.h (struct ui_file_style) <is_default>: New method.
11617         * source.c (print_source_lines_base): Emit escape sequences in one
11618         piece.
11619
11620 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11621
11622         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
11623         integers and enumeration types.
11624
11625 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
11626
11627         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
11628         instead of lookup_symbol_in_language
11629         (do_exact_match): New function.
11630         (ada_get_symbol_name_matcher): Return do_exact_match when
11631         doing a verbatim match.
11632
11633 2019-02-15  Tom Tromey  <tromey@adacore.com>
11634
11635         * ravenscar-thread.c (ravenscar_thread_target::resume)
11636         (ravenscar_thread_target::wait): Special case wildcard requests.
11637
11638 2019-02-15  Tom Tromey  <tromey@adacore.com>
11639
11640         * ravenscar-thread.c (base_ptid): Remove.
11641         (struct ravenscar_thread_target) <close>: New method.
11642         <m_base_ptid>: New member.
11643         <update_inferior_ptid, active_task, task_is_currently_active,
11644         runtime_initialized>: Declare methods.
11645         <ravenscar_thread_target>: Add constructor.
11646         (ravenscar_thread_target::task_is_currently_active)
11647         (ravenscar_thread_target::update_inferior_ptid)
11648         (ravenscar_runtime_initialized): Rename.  Now methods.
11649         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
11650         (ravenscar_thread_target::update_thread_list): Update.
11651         (ravenscar_thread_target::active_task): Now method.
11652         (ravenscar_thread_target::store_registers)
11653         (ravenscar_thread_target::prepare_to_store)
11654         (ravenscar_thread_target::prepare_to_store)
11655         (ravenscar_thread_target::mourn_inferior): Update.
11656         (ravenscar_inferior_created): Use "new" to create target.
11657         (ravenscar_thread_target::get_ada_task_ptid): Update.
11658         (_initialize_ravenscar): Don't initialize base_ptid.
11659         (ravenscar_ops): Remove global.
11660
11661 2019-02-15  Tom Tromey  <tromey@adacore.com>
11662
11663         * target.h (push_target): Declare new overload.
11664         * target.c (push_target): New overload, taking an rvalue reference.
11665         * remote.c (remote_target::open_1): Use push_target overload.
11666         * corelow.c (core_target_open): Use push_target overload.
11667
11668 2019-02-15  Tom Tromey  <tromey@adacore.com>
11669
11670         * ravenscar-thread.c (is_ravenscar_task)
11671         (ravenscar_task_is_currently_active): Return bool.
11672         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
11673         (_initialize_ravenscar): Remove "(void)".
11674         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
11675         Return bool.
11676
11677 2019-02-15  Tom Tromey  <tromey@adacore.com>
11678
11679         * ravenscar-thread.c (ravenscar_runtime_initializer)
11680         (has_ravenscar_runtime, get_running_thread_id)
11681         (ravenscar_thread_target::resume): Fix indentation.
11682
11683 2019-02-15  Tom Tromey  <tromey@adacore.com>
11684
11685         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
11686         from ravenscar_arch_ops.
11687         (sparc_ravenscar_ops::fetch_registers)
11688         (sparc_ravenscar_ops::store_registers): Now methods.
11689         (sparc_ravenscar_prepare_to_store): Remove.
11690         (sparc_ravenscar_ops): Redefine.
11691         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
11692         methods and destructor.  Remove members.
11693         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
11694         (ravenscar_thread_target::store_registers)
11695         (ravenscar_thread_target::prepare_to_store): Update.
11696         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
11697         Remove.
11698         (struct ppc_ravenscar_powerpc_ops): Derive from
11699         ravenscar_arch_ops.
11700         (ppc_ravenscar_powerpc_ops::fetch_registers)
11701         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
11702         (ppc_ravenscar_powerpc_ops): Redefine.
11703         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
11704         (ppc_ravenscar_e500_ops::fetch_registers)
11705         (ppc_ravenscar_e500_ops::store_registers): Now methods.
11706         (ppc_ravenscar_e500_ops): Redefine.
11707         * aarch64-ravenscar-thread.c
11708         (aarch64_ravenscar_generic_prepare_to_store): Remove.
11709         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
11710         (aarch64_ravenscar_fetch_registers)
11711         (aarch64_ravenscar_store_registers): Now methods.
11712         (aarch64_ravenscar_ops): Redefine.
11713
11714 2019-02-15  Tom Tromey  <tromey@adacore.com>
11715
11716         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
11717         (ravenscar_thread_target::stopped_by_hw_breakpoint)
11718         (ravenscar_thread_target::stopped_by_watchpoint)
11719         (ravenscar_thread_target::stopped_data_address)
11720         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
11721
11722 2019-02-15  Tom Tromey  <tromey@adacore.com>
11723
11724         * ravenscar-thread.c: Fix some typos.
11725
11726 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11727             Tom Tromey  <tromey@adacore.com>
11728
11729         * ada-lang.c (ada_exception_sal): Change addr_string to a
11730         std::string.
11731         (create_ada_exception_catchpoint): Update.
11732
11733 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11734             Tom Tromey  <tromey@adacore.com>
11735
11736         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
11737         (bp_location_ops): Remove.
11738         (base_breakpoint_allocate_location): Update.
11739         (free_bp_location): Update.
11740         * ada-lang.c (class ada_catchpoint_location)
11741         <ada_catchpoint_location>: Remove ops parameter.
11742         (ada_catchpoint_location_dtor): Remove.
11743         (ada_catchpoint_location_ops): Remove.
11744         (allocate_location_exception): Update.
11745         * breakpoint.h (struct bp_location_ops): Remove.
11746         (class bp_location) <bp_location>: Remove bp_location_ops
11747         parameter.
11748         <~bp_location>: Add destructor.
11749         <ops>: Remove.
11750
11751 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11752             Pedro Alves  <palves@redhat.com>
11753
11754         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
11755         'PATH_MAX'.
11756
11757 2019-02-14  David Michael  <fedora.dm0@gmail.com>
11758             Samuel Thibault  <samuel.thibault@gnu.org>
11759             Thomas Schwinge  <thomas@codesourcery.com>
11760
11761         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
11762         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
11763
11764 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
11765
11766         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
11767         (check_empty): Use "const char *".
11768
11769         * gnu-nat.c (gnu_nat_target::detach): Instead of
11770         'detach_inferior (pid)' call
11771         'detach_inferior (find_inferior_pid (pid))'.
11772
11773         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
11774         'nat/fork-inferior.o'.
11775         * gnu-nat.c: #include "nat/fork-inferior.h".
11776
11777         * gnu-nat.c (gnu_nat_target::detach): Instead of
11778         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
11779         * gnu-nat.h: #include "inf-child.h".
11780         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
11781         'i386_gnu_nat_target::fetch_registers'.
11782         (gnu_store_registers): Rename/move to
11783         'i386_gnu_nat_target::store_registers'.
11784
11785         * config/i386/nm-i386gnu.h: Don't "#include" any files.
11786         * gnu-nat.h (mach_thread_info): New function.
11787         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
11788
11789         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
11790
11791 2019-02-14  Frederic Konrad  <konrad@adacore.com>
11792
11793         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
11794
11795 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
11796
11797         * windows-nat.c (windows_add_thread): Add new parameter
11798         "main_thread_p" with default value set to false.  Update
11799         function documentation as well as all callers.
11800         (windows_delete_thread): Likewise.
11801         (fake_create_process): Update call to windows_add_thread.
11802         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
11803         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
11804         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
11805         call to windows_delete_thread.
11806
11807 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
11808
11809         * MAINTAINERS: Add Andrew Burgess as global maintainer.
11810
11811 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11812
11813         * symfile.c (find_separate_debug_file): Use canonical path of
11814         sysroot with child_path instead of gdb_sysroot if it is valid.
11815
11816 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11817
11818         * symfile.c (find_separate_debug_file): Use child_path to
11819         determine if an object file is under a sysroot.
11820
11821 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11822
11823         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
11824         unittests/child-path-selftests.c.
11825         * common/pathstuff.c (child_path): New function.
11826         * common/pathstuff.h (child_path): New prototype.
11827         * unittests/child-path-selftests.c: New file.
11828
11829 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
11830
11831         * symfile.c (find_separate_debug_file): Look for separate debug
11832         files in debug directories under the sysroot.
11833
11834 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11835
11836         * symtab.h (struct minimal_symbol data_p): New const method.
11837         (struct minimal_symbol text_p): Likewise.
11838         * symtab.c (output_source_filename): Use file name style
11839         to print file name.
11840         (print_symbol_info): Likewise.
11841         (print_msymbol_info): Use address style to print addresses.
11842         Use function name style to print executable text symbols.
11843         (expand_symtab_containing_pc): Use data_p.
11844         (find_pc_sect_compunit_symtab): Likewise.
11845
11846 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11847
11848         * breakpoint.c (describe_other_breakpoints): Use address style
11849         to print addresses.
11850         (say_where): Likewise.
11851
11852 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11853
11854         * ada-typeprint.c (print_func_type): Print function name
11855         style to print function name.
11856         * c-typeprint.c (c_print_type_1): Likewise.
11857
11858 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
11859
11860         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
11861         for execve.
11862
11863 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11864
11865         * c-exp.y (direct_abs_decl): Use emplace_back to record the
11866         type_stack.
11867
11868 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
11869
11870         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
11871         TYPE_CODE_REF types.
11872
11873 2019-02-08  Jim Wilson  <jimw@sifive.com>
11874
11875         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
11876         (riscv_linux_fregset): New.
11877         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
11878
11879 2019-02-07  Tom Tromey  <tom@tromey.com>
11880
11881         * thread.c (thread_cancel_execution_command): Update.
11882         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
11883         methods.
11884         (struct thread_fsm_ops): Remove.
11885         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
11886         (thread_fsm_should_stop, thread_fsm_return_value)
11887         (thread_fsm_set_finished, thread_fsm_finished_p)
11888         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
11889         Don't declare.
11890         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
11891         * infrun.c (clear_proceed_status_thread)
11892         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
11893         (print_stop_event): Update.
11894         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
11895         Add constructor.
11896         (step_command_fsm_ops): Remove.
11897         (new_step_command_fsm): Remove.
11898         (step_1): Update.
11899         (step_command_fsm::should_stop): Rename from
11900         step_command_fsm_should_stop.
11901         (step_command_fsm::clean_up): Rename from
11902         step_command_fsm_clean_up.
11903         (step_command_fsm::do_async_reply_reason): Rename from
11904         step_command_fsm_async_reply_reason.
11905         (struct until_next_fsm): Inherit from thread_fsm.  Add
11906         constructor.
11907         (until_next_fsm_ops): Remove.
11908         (new_until_next_fsm): Remove.
11909         (until_next_fsm::should_stop): Rename from
11910         until_next_fsm_should_stop.
11911         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
11912         (until_next_fsm::do_async_reply_reason): Rename from
11913         until_next_fsm_async_reply_reason.
11914         (struct finish_command_fsm): Inherit from thread_fsm.  Add
11915         constructor.  Change type of breakpoint.
11916         (finish_command_fsm_ops): Remove.
11917         (new_finish_command_fsm): Remove.
11918         (finish_command_fsm::should_stop): Rename from
11919         finish_command_fsm_should_stop.
11920         (finish_command_fsm::clean_up): Rename from
11921         finish_command_fsm_clean_up.
11922         (finish_command_fsm::return_value): Rename from
11923         finish_command_fsm_return_value.
11924         (finish_command_fsm::do_async_reply_reason): Rename from
11925         finish_command_fsm_async_reply_reason.
11926         (finish_command): Update.
11927         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
11928         Add constructor.
11929         (call_thread_fsm_ops): Remove.
11930         (call_thread_fsm::call_thread_fsm): Rename from
11931         new_call_thread_fsm.
11932         (call_thread_fsm::should_stop): Rename from
11933         call_thread_fsm_should_stop.
11934         (call_thread_fsm::should_notify_stop): Rename from
11935         call_thread_fsm_should_notify_stop.
11936         (run_inferior_call, call_function_by_hand_dummy): Update.
11937         * cli/cli-interp.c (should_print_stop_to_console): Update.
11938         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
11939         Add constructor.  Change type of location_breakpoint,
11940         caller_breakpoint.
11941         (until_break_fsm_ops): Remove.
11942         (new_until_break_fsm): Remove.
11943         (until_break_fsm::should_stop): Rename from
11944         until_break_fsm_should_stop.
11945         (until_break_fsm::clean_up): Rename from
11946         until_break_fsm_clean_up.
11947         (until_break_fsm::do_async_reply_reason): Rename from
11948         until_break_fsm_async_reply_reason.
11949         (until_break_command): Update.
11950         * thread-fsm.c: Remove.
11951         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
11952
11953 2019-02-07  Tom Tromey  <tom@tromey.com>
11954
11955         * yy-remap.h: Add include guard.
11956         * xtensa-tdep.h: Add include guard.
11957         * xcoffread.h: Rename include guard.
11958         * varobj-iter.h: Add include guard.
11959         * tui/tui.h: Rename include guard.
11960         * tui/tui-winsource.h: Rename include guard.
11961         * tui/tui-wingeneral.h: Rename include guard.
11962         * tui/tui-windata.h: Rename include guard.
11963         * tui/tui-win.h: Rename include guard.
11964         * tui/tui-stack.h: Rename include guard.
11965         * tui/tui-source.h: Rename include guard.
11966         * tui/tui-regs.h: Rename include guard.
11967         * tui/tui-out.h: Rename include guard.
11968         * tui/tui-layout.h: Rename include guard.
11969         * tui/tui-io.h: Rename include guard.
11970         * tui/tui-hooks.h: Rename include guard.
11971         * tui/tui-file.h: Rename include guard.
11972         * tui/tui-disasm.h: Rename include guard.
11973         * tui/tui-data.h: Rename include guard.
11974         * tui/tui-command.h: Rename include guard.
11975         * tic6x-tdep.h: Add include guard.
11976         * target/waitstatus.h: Rename include guard.
11977         * target/wait.h: Rename include guard.
11978         * target/target.h: Rename include guard.
11979         * target/resume.h: Rename include guard.
11980         * target-float.h: Rename include guard.
11981         * stabsread.h: Add include guard.
11982         * rs6000-tdep.h: Add include guard.
11983         * riscv-fbsd-tdep.h: Add include guard.
11984         * regformats/regdef.h: Rename include guard.
11985         * record.h: Rename include guard.
11986         * python/python.h: Rename include guard.
11987         * python/python-internal.h: Rename include guard.
11988         * python/py-stopevent.h: Rename include guard.
11989         * python/py-ref.h: Rename include guard.
11990         * python/py-record.h: Rename include guard.
11991         * python/py-record-full.h: Rename include guard.
11992         * python/py-record-btrace.h: Rename include guard.
11993         * python/py-instruction.h: Rename include guard.
11994         * python/py-events.h: Rename include guard.
11995         * python/py-event.h: Rename include guard.
11996         * procfs.h: Add include guard.
11997         * proc-utils.h: Add include guard.
11998         * p-lang.h: Add include guard.
11999         * or1k-tdep.h: Rename include guard.
12000         * observable.h: Rename include guard.
12001         * nto-tdep.h: Rename include guard.
12002         * nat/x86-linux.h: Rename include guard.
12003         * nat/x86-linux-dregs.h: Rename include guard.
12004         * nat/x86-gcc-cpuid.h: Add include guard.
12005         * nat/x86-dregs.h: Rename include guard.
12006         * nat/x86-cpuid.h: Rename include guard.
12007         * nat/ppc-linux.h: Rename include guard.
12008         * nat/mips-linux-watch.h: Rename include guard.
12009         * nat/linux-waitpid.h: Rename include guard.
12010         * nat/linux-ptrace.h: Rename include guard.
12011         * nat/linux-procfs.h: Rename include guard.
12012         * nat/linux-osdata.h: Rename include guard.
12013         * nat/linux-nat.h: Rename include guard.
12014         * nat/linux-namespaces.h: Rename include guard.
12015         * nat/linux-btrace.h: Rename include guard.
12016         * nat/glibc_thread_db.h: Rename include guard.
12017         * nat/gdb_thread_db.h: Rename include guard.
12018         * nat/gdb_ptrace.h: Rename include guard.
12019         * nat/fork-inferior.h: Rename include guard.
12020         * nat/amd64-linux-siginfo.h: Rename include guard.
12021         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
12022         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
12023         * nat/aarch64-linux.h: Rename include guard.
12024         * nat/aarch64-linux-hw-point.h: Rename include guard.
12025         * mn10300-tdep.h: Add include guard.
12026         * mips-linux-tdep.h: Add include guard.
12027         * mi/mi-parse.h: Rename include guard.
12028         * mi/mi-out.h: Rename include guard.
12029         * mi/mi-main.h: Rename include guard.
12030         * mi/mi-interp.h: Rename include guard.
12031         * mi/mi-getopt.h: Rename include guard.
12032         * mi/mi-console.h: Rename include guard.
12033         * mi/mi-common.h: Rename include guard.
12034         * mi/mi-cmds.h: Rename include guard.
12035         * mi/mi-cmd-break.h: Rename include guard.
12036         * m2-lang.h: Add include guard.
12037         * location.h: Rename include guard.
12038         * linux-record.h: Rename include guard.
12039         * linux-nat.h: Add include guard.
12040         * linux-fork.h: Add include guard.
12041         * i386-darwin-tdep.h: Rename include guard.
12042         * hppa-linux-offsets.h: Add include guard.
12043         * guile/guile.h: Rename include guard.
12044         * guile/guile-internal.h: Rename include guard.
12045         * gnu-nat.h: Rename include guard.
12046         * gdb-stabs.h: Rename include guard.
12047         * frv-tdep.h: Add include guard.
12048         * f-lang.h: Add include guard.
12049         * event-loop.h: Add include guard.
12050         * darwin-nat.h: Rename include guard.
12051         * cp-abi.h: Rename include guard.
12052         * config/sparc/nm-sol2.h: Rename include guard.
12053         * config/nm-nto.h: Rename include guard.
12054         * config/nm-linux.h: Add include guard.
12055         * config/i386/nm-i386gnu.h: Rename include guard.
12056         * config/djgpp/nl_types.h: Rename include guard.
12057         * config/djgpp/langinfo.h: Rename include guard.
12058         * compile/gcc-cp-plugin.h: Add include guard.
12059         * compile/gcc-c-plugin.h: Add include guard.
12060         * compile/compile.h: Rename include guard.
12061         * compile/compile-object-run.h: Rename include guard.
12062         * compile/compile-object-load.h: Rename include guard.
12063         * compile/compile-internal.h: Rename include guard.
12064         * compile/compile-cplus.h: Rename include guard.
12065         * compile/compile-c.h: Rename include guard.
12066         * common/xml-utils.h: Rename include guard.
12067         * common/x86-xstate.h: Rename include guard.
12068         * common/version.h: Rename include guard.
12069         * common/vec.h: Rename include guard.
12070         * common/tdesc.h: Rename include guard.
12071         * common/selftest.h: Rename include guard.
12072         * common/scoped_restore.h: Rename include guard.
12073         * common/scoped_mmap.h: Rename include guard.
12074         * common/scoped_fd.h: Rename include guard.
12075         * common/safe-iterator.h: Rename include guard.
12076         * common/run-time-clock.h: Rename include guard.
12077         * common/refcounted-object.h: Rename include guard.
12078         * common/queue.h: Rename include guard.
12079         * common/ptid.h: Rename include guard.
12080         * common/print-utils.h: Rename include guard.
12081         * common/preprocessor.h: Rename include guard.
12082         * common/pathstuff.h: Rename include guard.
12083         * common/observable.h: Rename include guard.
12084         * common/netstuff.h: Rename include guard.
12085         * common/job-control.h: Rename include guard.
12086         * common/host-defs.h: Rename include guard.
12087         * common/gdb_wait.h: Rename include guard.
12088         * common/gdb_vecs.h: Rename include guard.
12089         * common/gdb_unlinker.h: Rename include guard.
12090         * common/gdb_unique_ptr.h: Rename include guard.
12091         * common/gdb_tilde_expand.h: Rename include guard.
12092         * common/gdb_sys_time.h: Rename include guard.
12093         * common/gdb_string_view.h: Rename include guard.
12094         * common/gdb_splay_tree.h: Rename include guard.
12095         * common/gdb_setjmp.h: Rename include guard.
12096         * common/gdb_ref_ptr.h: Rename include guard.
12097         * common/gdb_optional.h: Rename include guard.
12098         * common/gdb_locale.h: Rename include guard.
12099         * common/gdb_assert.h: Rename include guard.
12100         * common/filtered-iterator.h: Rename include guard.
12101         * common/filestuff.h: Rename include guard.
12102         * common/fileio.h: Rename include guard.
12103         * common/environ.h: Rename include guard.
12104         * common/common-utils.h: Rename include guard.
12105         * common/common-types.h: Rename include guard.
12106         * common/common-regcache.h: Rename include guard.
12107         * common/common-inferior.h: Rename include guard.
12108         * common/common-gdbthread.h: Rename include guard.
12109         * common/common-exceptions.h: Rename include guard.
12110         * common/common-defs.h: Rename include guard.
12111         * common/common-debug.h: Rename include guard.
12112         * common/cleanups.h: Rename include guard.
12113         * common/buffer.h: Rename include guard.
12114         * common/btrace-common.h: Rename include guard.
12115         * common/break-common.h: Rename include guard.
12116         * cli/cli-utils.h: Rename include guard.
12117         * cli/cli-style.h: Rename include guard.
12118         * cli/cli-setshow.h: Rename include guard.
12119         * cli/cli-script.h: Rename include guard.
12120         * cli/cli-interp.h: Rename include guard.
12121         * cli/cli-decode.h: Rename include guard.
12122         * cli/cli-cmds.h: Rename include guard.
12123         * charset-list.h: Add include guard.
12124         * buildsym-legacy.h: Rename include guard.
12125         * bfin-tdep.h: Add include guard.
12126         * ax.h: Rename include guard.
12127         * arm-linux-tdep.h: Add include guard.
12128         * arm-fbsd-tdep.h: Add include guard.
12129         * arch/xtensa.h: Rename include guard.
12130         * arch/tic6x.h: Add include guard.
12131         * arch/i386.h: Add include guard.
12132         * arch/arm.h: Rename include guard.
12133         * arch/arm-linux.h: Rename include guard.
12134         * arch/arm-get-next-pcs.h: Rename include guard.
12135         * arch/amd64.h: Add include guard.
12136         * arch/aarch64-insn.h: Rename include guard.
12137         * arch-utils.h: Rename include guard.
12138         * annotate.h: Add include guard.
12139         * amd64-darwin-tdep.h: Rename include guard.
12140         * aarch64-linux-tdep.h: Add include guard.
12141         * aarch64-fbsd-tdep.h: Add include guard.
12142         * aarch32-linux-nat.h: Add include guard.
12143
12144 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12145
12146         * macrotab.c (macro_define_internal): New function that
12147         factorizes macro_define_object_internal and macro_define_function
12148         code.
12149         (macro_define_object_internal): Use macro_define_internal.
12150         (macro_define_function): Likewise.
12151
12152 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12153
12154         * macrocmd.c (extract_identifier): Return
12155         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
12156         callers.
12157
12158 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
12159
12160         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
12161
12162 2019-02-05  Tom Tromey  <tom@tromey.com>
12163
12164         * target.c (target_stack::unpush): Move assertion earlier.
12165
12166 2019-01-30  Tom Tromey  <tom@tromey.com>
12167
12168         PR python/23615:
12169         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
12170         (gdbpy_parse_and_eval): Likewise.
12171         * python/python-internal.h (gdbpy_allow_threads): New class.
12172
12173 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
12174
12175         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
12176         (aarch64_fbsd_fpregmap): Move earlier.
12177         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
12178         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12179         instead of individual calls to trad_frame_set_reg_addr.
12180         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
12181         earlier.
12182         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
12183         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
12184         instead of individual calls to trad_frame_set_reg_addr.
12185
12186 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
12187
12188         * CONTRIBUTE: Replace contribution list with wiki link.
12189
12190 2019-01-25  Tom Tromey  <tom@tromey.com>
12191
12192         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
12193
12194 2019-01-25  Tom Tromey  <tom@tromey.com>
12195
12196         * xtensa-linux-nat.c: Fix common/ includes.
12197         * xml-support.h: Fix common/ includes.
12198         * xml-support.c: Fix common/ includes.
12199         * x86-linux-nat.c: Fix common/ includes.
12200         * windows-nat.c: Fix common/ includes.
12201         * varobj.h: Fix common/ includes.
12202         * varobj.c: Fix common/ includes.
12203         * value.c: Fix common/ includes.
12204         * valops.c: Fix common/ includes.
12205         * utils.c: Fix common/ includes.
12206         * unittests/xml-utils-selftests.c: Fix common/ includes.
12207         * unittests/utils-selftests.c: Fix common/ includes.
12208         * unittests/unpack-selftests.c: Fix common/ includes.
12209         * unittests/tracepoint-selftests.c: Fix common/ includes.
12210         * unittests/style-selftests.c: Fix common/ includes.
12211         * unittests/string_view-selftests.c: Fix common/ includes.
12212         * unittests/scoped_restore-selftests.c: Fix common/ includes.
12213         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
12214         * unittests/scoped_fd-selftests.c: Fix common/ includes.
12215         * unittests/rsp-low-selftests.c: Fix common/ includes.
12216         * unittests/parse-connection-spec-selftests.c: Fix common/
12217         includes.
12218         * unittests/optional-selftests.c: Fix common/ includes.
12219         * unittests/offset-type-selftests.c: Fix common/ includes.
12220         * unittests/observable-selftests.c: Fix common/ includes.
12221         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
12222         * unittests/memrange-selftests.c: Fix common/ includes.
12223         * unittests/memory-map-selftests.c: Fix common/ includes.
12224         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
12225         * unittests/function-view-selftests.c: Fix common/ includes.
12226         * unittests/environ-selftests.c: Fix common/ includes.
12227         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
12228         * unittests/common-utils-selftests.c: Fix common/ includes.
12229         * unittests/cli-utils-selftests.c: Fix common/ includes.
12230         * unittests/array-view-selftests.c: Fix common/ includes.
12231         * ui-file.c: Fix common/ includes.
12232         * tui/tui-io.c: Fix common/ includes.
12233         * tracepoint.h: Fix common/ includes.
12234         * tracepoint.c: Fix common/ includes.
12235         * tracefile-tfile.c: Fix common/ includes.
12236         * top.h: Fix common/ includes.
12237         * top.c: Fix common/ includes.
12238         * thread.c: Fix common/ includes.
12239         * target/waitstatus.h: Fix common/ includes.
12240         * target/waitstatus.c: Fix common/ includes.
12241         * target.h: Fix common/ includes.
12242         * target.c: Fix common/ includes.
12243         * target-memory.c: Fix common/ includes.
12244         * target-descriptions.c: Fix common/ includes.
12245         * symtab.h: Fix common/ includes.
12246         * symfile.c: Fix common/ includes.
12247         * stap-probe.c: Fix common/ includes.
12248         * spu-linux-nat.c: Fix common/ includes.
12249         * sparc-nat.c: Fix common/ includes.
12250         * source.c: Fix common/ includes.
12251         * solib.c: Fix common/ includes.
12252         * solib-target.c: Fix common/ includes.
12253         * ser-unix.c: Fix common/ includes.
12254         * ser-tcp.c: Fix common/ includes.
12255         * ser-pipe.c: Fix common/ includes.
12256         * ser-base.c: Fix common/ includes.
12257         * selftest-arch.c: Fix common/ includes.
12258         * s12z-tdep.c: Fix common/ includes.
12259         * rust-exp.y: Fix common/ includes.
12260         * rs6000-aix-tdep.c: Fix common/ includes.
12261         * riscv-tdep.c: Fix common/ includes.
12262         * remote.c: Fix common/ includes.
12263         * remote-notif.h: Fix common/ includes.
12264         * remote-fileio.h: Fix common/ includes.
12265         * remote-fileio.c: Fix common/ includes.
12266         * regcache.h: Fix common/ includes.
12267         * regcache.c: Fix common/ includes.
12268         * record-btrace.c: Fix common/ includes.
12269         * python/python.c: Fix common/ includes.
12270         * python/py-type.c: Fix common/ includes.
12271         * python/py-inferior.c: Fix common/ includes.
12272         * progspace.h: Fix common/ includes.
12273         * producer.c: Fix common/ includes.
12274         * procfs.c: Fix common/ includes.
12275         * proc-api.c: Fix common/ includes.
12276         * printcmd.c: Fix common/ includes.
12277         * ppc-linux-nat.c: Fix common/ includes.
12278         * parser-defs.h: Fix common/ includes.
12279         * osdata.c: Fix common/ includes.
12280         * obsd-nat.c: Fix common/ includes.
12281         * nat/x86-linux.c: Fix common/ includes.
12282         * nat/x86-linux-dregs.c: Fix common/ includes.
12283         * nat/x86-dregs.h: Fix common/ includes.
12284         * nat/x86-dregs.c: Fix common/ includes.
12285         * nat/ppc-linux.c: Fix common/ includes.
12286         * nat/mips-linux-watch.h: Fix common/ includes.
12287         * nat/mips-linux-watch.c: Fix common/ includes.
12288         * nat/linux-waitpid.c: Fix common/ includes.
12289         * nat/linux-ptrace.h: Fix common/ includes.
12290         * nat/linux-ptrace.c: Fix common/ includes.
12291         * nat/linux-procfs.c: Fix common/ includes.
12292         * nat/linux-personality.c: Fix common/ includes.
12293         * nat/linux-osdata.c: Fix common/ includes.
12294         * nat/linux-namespaces.c: Fix common/ includes.
12295         * nat/linux-btrace.h: Fix common/ includes.
12296         * nat/linux-btrace.c: Fix common/ includes.
12297         * nat/fork-inferior.c: Fix common/ includes.
12298         * nat/amd64-linux-siginfo.c: Fix common/ includes.
12299         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
12300         * nat/aarch64-linux.c: Fix common/ includes.
12301         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
12302         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
12303         * namespace.h: Fix common/ includes.
12304         * mips-linux-tdep.c: Fix common/ includes.
12305         * minsyms.c: Fix common/ includes.
12306         * mi/mi-parse.h: Fix common/ includes.
12307         * mi/mi-main.c: Fix common/ includes.
12308         * mi/mi-cmd-env.c: Fix common/ includes.
12309         * memrange.h: Fix common/ includes.
12310         * memattr.c: Fix common/ includes.
12311         * maint.h: Fix common/ includes.
12312         * maint.c: Fix common/ includes.
12313         * main.c: Fix common/ includes.
12314         * machoread.c: Fix common/ includes.
12315         * location.c: Fix common/ includes.
12316         * linux-thread-db.c: Fix common/ includes.
12317         * linux-nat.c: Fix common/ includes.
12318         * linux-fork.c: Fix common/ includes.
12319         * inline-frame.c: Fix common/ includes.
12320         * infrun.c: Fix common/ includes.
12321         * inflow.c: Fix common/ includes.
12322         * inferior.h: Fix common/ includes.
12323         * inferior.c: Fix common/ includes.
12324         * infcmd.c: Fix common/ includes.
12325         * inf-ptrace.c: Fix common/ includes.
12326         * inf-child.c: Fix common/ includes.
12327         * ia64-linux-nat.c: Fix common/ includes.
12328         * i387-tdep.c: Fix common/ includes.
12329         * i386-tdep.c: Fix common/ includes.
12330         * i386-linux-tdep.c: Fix common/ includes.
12331         * i386-linux-nat.c: Fix common/ includes.
12332         * i386-go32-tdep.c: Fix common/ includes.
12333         * i386-fbsd-tdep.c: Fix common/ includes.
12334         * i386-fbsd-nat.c: Fix common/ includes.
12335         * guile/scm-type.c: Fix common/ includes.
12336         * guile/guile.c: Fix common/ includes.
12337         * go32-nat.c: Fix common/ includes.
12338         * gnu-nat.c: Fix common/ includes.
12339         * gdbthread.h: Fix common/ includes.
12340         * gdbarch-selftests.c: Fix common/ includes.
12341         * gdb_usleep.c: Fix common/ includes.
12342         * gdb_select.h: Fix common/ includes.
12343         * gdb_bfd.c: Fix common/ includes.
12344         * gcore.c: Fix common/ includes.
12345         * fork-child.c: Fix common/ includes.
12346         * findvar.c: Fix common/ includes.
12347         * fbsd-nat.c: Fix common/ includes.
12348         * event-top.c: Fix common/ includes.
12349         * event-loop.c: Fix common/ includes.
12350         * dwarf2read.c: Fix common/ includes.
12351         * dwarf2loc.c: Fix common/ includes.
12352         * dwarf2-frame.c: Fix common/ includes.
12353         * dwarf-index-cache.c: Fix common/ includes.
12354         * dtrace-probe.c: Fix common/ includes.
12355         * disasm-selftests.c: Fix common/ includes.
12356         * defs.h: Fix common/ includes.
12357         * csky-tdep.c: Fix common/ includes.
12358         * cp-valprint.c: Fix common/ includes.
12359         * cp-support.h: Fix common/ includes.
12360         * cp-support.c: Fix common/ includes.
12361         * corelow.c: Fix common/ includes.
12362         * completer.h: Fix common/ includes.
12363         * completer.c: Fix common/ includes.
12364         * compile/compile.c: Fix common/ includes.
12365         * compile/compile-loc2c.c: Fix common/ includes.
12366         * compile/compile-cplus-types.c: Fix common/ includes.
12367         * compile/compile-cplus-symbols.c: Fix common/ includes.
12368         * command.h: Fix common/ includes.
12369         * cli/cli-dump.c: Fix common/ includes.
12370         * cli/cli-cmds.c: Fix common/ includes.
12371         * charset.c: Fix common/ includes.
12372         * build-id.c: Fix common/ includes.
12373         * btrace.h: Fix common/ includes.
12374         * btrace.c: Fix common/ includes.
12375         * breakpoint.h: Fix common/ includes.
12376         * breakpoint.c: Fix common/ includes.
12377         * ax.h:
12378         (enum agent_op): Fix common/ includes.
12379         * ax-general.c (struct aop_map): Fix common/ includes.
12380         * ax-gdb.c: Fix common/ includes.
12381         * auxv.c: Fix common/ includes.
12382         * auto-load.c: Fix common/ includes.
12383         * arm-tdep.c: Fix common/ includes.
12384         * arch/riscv.c: Fix common/ includes.
12385         * arch/ppc-linux-common.c: Fix common/ includes.
12386         * arch/i386.c: Fix common/ includes.
12387         * arch/arm.c: Fix common/ includes.
12388         * arch/arm-linux.c: Fix common/ includes.
12389         * arch/arm-get-next-pcs.c: Fix common/ includes.
12390         * arch/amd64.c: Fix common/ includes.
12391         * arch/aarch64.c: Fix common/ includes.
12392         * arch/aarch64-insn.c: Fix common/ includes.
12393         * arch-utils.c: Fix common/ includes.
12394         * amd64-windows-tdep.c: Fix common/ includes.
12395         * amd64-tdep.c: Fix common/ includes.
12396         * amd64-sol2-tdep.c: Fix common/ includes.
12397         * amd64-obsd-tdep.c: Fix common/ includes.
12398         * amd64-nbsd-tdep.c: Fix common/ includes.
12399         * amd64-linux-tdep.c: Fix common/ includes.
12400         * amd64-linux-nat.c: Fix common/ includes.
12401         * amd64-fbsd-tdep.c: Fix common/ includes.
12402         * amd64-fbsd-nat.c: Fix common/ includes.
12403         * amd64-dicos-tdep.c: Fix common/ includes.
12404         * amd64-darwin-tdep.c: Fix common/ includes.
12405         * agent.c: Fix common/ includes.
12406         * ada-lang.h: Fix common/ includes.
12407         * ada-lang.c: Fix common/ includes.
12408         * aarch64-tdep.c: Fix common/ includes.
12409
12410 2019-01-25  Tom Tromey  <tom@tromey.com>
12411
12412         * common/create-version.sh: Use common/version.h.
12413
12414 2019-01-24  Pedro Alves  <palves@redhat.com>
12415
12416         * infrun.c (signal_stop, signal_print, signal_program)
12417         (signal_catch, signal_pass): Now arrays instead of pointers.
12418         (update_signals_program_target, do_target_resume)
12419         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
12420         * linux-nat.c (linux_nat_target::pass_signals)
12421         (linux_nat_target::create_inferior, linux_nat_target::attach):
12422         Adjust.
12423         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
12424         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
12425         * procfs.c (procfs_target::pass_signals): Adjust.
12426         * record-full.c (record_full_target::resume): Adjust.
12427         * remote.c (remote_target::pass_signals)
12428         (remote_target::program_signals): Adjust.
12429         * target-debug.h (target_debug_print_signals): Now takes a
12430         gdb::array_view as parameter.  Adjust.
12431         * target.h (target_ops) <pass_signals, program_signals>: Replace
12432         pointer and length parameters with gdb::array_view.
12433         (target_pass_signals, target_program_signals): Likewise.
12434         * target-delegates.c: Regenerate.
12435
12436 2019-01-24  Pedro Alves  <palves@redhat.com>
12437
12438         * common/forward-scope-exit.h
12439         (forward_scope_exit::forward_scope_exit): Pass arguments to
12440         m_bind_function directly, instead of creating a std::bind and
12441         copying that.
12442
12443 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
12444
12445         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12446         for static members.
12447         (pass_in_v_vfp_candidate): Likewise.
12448
12449 2019-01-23  Tom Tromey  <tom@tromey.com>
12450             Pedro Alves  <palves@redhat.com>
12451
12452         * regcache.c (class regcache_invalidator): Remove.
12453         (regcache::raw_write): Use make_scope_exit.
12454
12455 2019-01-23  Tom Tromey  <tom@tromey.com>
12456
12457         * ui-out.h (class ui_out_emit_type): Update comment.
12458
12459 2019-01-23  Tom Tromey  <tom@tromey.com>
12460
12461         * infrun.c (fetch_inferior_event): Update comment.
12462
12463 2019-01-23  Tom Tromey  <tom@tromey.com>
12464             Pedro Alves  <palves@redhat.com>
12465
12466         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
12467         parameter.
12468         (fetch_inferior_event): Use SCOPE_EXIT.
12469
12470
12471 2019-01-23  Tom Tromey  <tom@tromey.com>
12472             Pedro Alves  <palves@redhat.com>
12473
12474         * infrun.c (disable_thread_events): Delete.
12475         (stop_all_threads): Use SCOPE_EXIT.
12476
12477 2019-01-23  Tom Tromey  <tom@tromey.com>
12478             Pedro Alves  <palves@redhat.com>
12479
12480         * symfile.c: Include forward-scope-exit.h.
12481         (clear_symtab_users_cleanup): Replace forward declaration with
12482         a FORWARD_SCOPE_EXIT.
12483         (syms_from_objfile_1): Use the forward_scope_exit and
12484         gdb::optional instead of cleanup_function.
12485         (reread_symbols): Use the forward_scope_exit instead of
12486         cleanup_function.
12487         (clear_symtab_users_cleanup): Remove function.
12488
12489 2019-01-23  Tom Tromey  <tom@tromey.com>
12490             Pedro Alves  <palves@redhat.com>
12491
12492         * linux-nat.c: Include scope-exit.h.
12493         (cleanup_target_stop): Remove.
12494         (linux_nat_target::static_tracepoint_markers_by_strid): Use
12495         SCOPE_EXIT.
12496
12497 2019-01-23  Tom Tromey  <tom@tromey.com>
12498             Pedro Alves  <palves@redhat.com>
12499
12500         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
12501         (call_function_by_hand_dummy): Use SCOPE_EXIT.
12502
12503 2019-01-23  Tom Tromey  <tom@tromey.com>
12504             Andrew Burgess  <andrew.burgess@embecosm.com>
12505             Pedro Alves  <palves@redhat.com>
12506
12507         * infrun.c (fetch_inferior_event): Use scope_exit.
12508         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
12509         * top.c (execute_command): Use scope_exit.
12510         * breakpoint.c (bpstat_do_actions): Use scope_exit.
12511         * utils.c (do_bpstat_clear_actions_cleanup)
12512         (make_bpstat_clear_actions_cleanup): Remove.
12513
12514 2019-01-23  Tom Tromey  <tom@tromey.com>
12515             Pedro Alves  <palves@redhat.com>
12516
12517         * infrun.c: Include "common/scope-exit.h"
12518         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
12519         (wait_for_inferior): Use SCOPE_EXIT.
12520         (fetch_inferior_event): Use scope_exit.
12521
12522 2019-01-23  Tom Tromey  <tom@tromey.com>
12523             Pedro Alves  <palves@redhat.com>
12524
12525         * breakpoint.c (create_breakpoint): Remove cleanup.
12526
12527 2019-01-23  Tom Tromey  <tom@tromey.com>
12528             Andrew Burgess  <andrew.burgess@embecosm.com>
12529             Pedro Alves  <palves@redhat.com>
12530
12531 2019-01-23  Pedro Alves  <palves@redhat.com>
12532
12533         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
12534
12535 2019-01-23  Pedro Alves  <palves@redhat.com>
12536             Andrew Burgess  <andrew.burgess@embecosm.com>
12537
12538         * gdbthread.h: Include "common/forward-scope-exit.h".
12539         (scoped_finish_thread_state): Redefine custom class in terms of
12540         forward_scope_exit.
12541
12542 2019-01-23  Pedro Alves  <palves@redhat.com>
12543             Andrew Burgess  <andrew.burgess@embecosm.com>
12544
12545         * common/forward-scope-exit.h: New file.
12546
12547 2019-01-23  Pedro Alves  <palves@redhat.com>
12548             Andrew Burgess  <andrew.burgess@embecosm.com>
12549             Tom Tromey  <tom@tromey.com>
12550
12551         * common/scope-exit.h: New file.
12552
12553 2019-01-23  Pedro Alves  <palves@redhat.com>
12554
12555         * common/preprocessor.h (ESC): Rename to ...
12556         (ESC_PARENS): ... this.
12557         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
12558         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
12559
12560 2019-01-23  Tom Tromey  <tom@tromey.com>
12561
12562         * language.h (class scoped_switch_to_sym_language_if_auto):
12563         Initialize m_lang in both cases.
12564
12565 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
12566
12567         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
12568         with XCNEW.
12569
12570 2019-01-22  Tom Tromey  <tom@tromey.com>
12571
12572         * corelow.c: Do not include sys/file.h.
12573
12574 2019-01-22  Tom Tromey  <tom@tromey.com>
12575
12576         * tui/tui-wingeneral.h: Include gdb_curses.h.
12577
12578 2019-01-22  Tom Tromey  <tom@tromey.com>
12579
12580         * source-cache.h (class source_cache) <get_source_lines,
12581         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
12582
12583 2019-01-22  Tom Tromey  <tom@tromey.com>
12584
12585         * remote-fileio.h (struct remote_target): Declare.
12586
12587 2019-01-22  Tom Tromey  <tom@tromey.com>
12588
12589         * python/py-arch.c: Do not include py-ref.h.
12590         * python/py-bpevent.c: Do not include py-ref.h.
12591         * python/py-cmd.c: Do not include py-ref.h.
12592         * python/py-continueevent.c: Do not include py-ref.h.
12593         * python/py-event.h: Do not include py-ref.h.
12594         * python/py-evtregistry.c: Do not include py-ref.h.
12595         * python/py-finishbreakpoint.c: Do not include py-ref.h.
12596         * python/py-frame.c: Do not include py-ref.h.
12597         * python/py-framefilter.c: Do not include py-ref.h.
12598         * python/py-function.c: Do not include py-ref.h.
12599         * python/py-infevents.c: Do not include py-ref.h.
12600         * python/py-linetable.c: Do not include py-ref.h.
12601         * python/py-objfile.c: Do not include py-ref.h.
12602         * python/py-param.c: Do not include py-ref.h.
12603         * python/py-prettyprint.c: Do not include py-ref.h.
12604         * python/py-progspace.c: Do not include py-ref.h.
12605         * python/py-symbol.c: Do not include py-ref.h.
12606         * python/py-symtab.c: Do not include py-ref.h.
12607         * python/py-type.c: Do not include py-ref.h.
12608         * python/py-unwind.c: Do not include py-ref.h.
12609         * python/py-utils.c: Do not include py-ref.h.
12610         * python/py-value.c: Do not include py-ref.h.
12611         * python/py-varobj.c: Do not include py-ref.h.
12612         * python/py-xmethods.c: Do not include py-ref.h.
12613         * python/python.c: Do not include py-ref.h.
12614         * varobj.c: Do not include py-ref.h.
12615
12616 2019-01-22  Tom Tromey  <tom@tromey.com>
12617
12618         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
12619         keyword for bcache.
12620
12621 2019-01-22  Tom Tromey  <tom@tromey.com>
12622
12623         * compile/compile-cplus-types.c: Remove a comment by #include.
12624
12625 2019-01-22  Tom Tromey  <tom@tromey.com>
12626
12627         * compile/gcc-c-plugin.h: Include compile-internal.h.
12628
12629 2019-01-22  Tom Tromey  <tom@tromey.com>
12630
12631         * stabsread.c (EXTERN): Do not define.
12632         (symnum, next_symbol_text_func, processing_gcc_compilation)
12633         (within_function, global_sym_chain, global_stabs)
12634         (previous_stab_code, this_object_header_files)
12635         (n_this_object_header_files)
12636         (n_allocated_this_object_header_files): Define.
12637         * stabsread.h (EXTERN): Never define.  Use "extern".
12638
12639 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12640
12641         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
12642         history_value.
12643
12644 2019-01-21  Tom Tromey  <tom@tromey.com>
12645
12646         * ui-out.c: Fix includes.
12647         * tui/tui-source.c: Fix includes.
12648         * target.c: Fix includes.
12649         * remote.c: Fix includes.
12650         * regcache.c: Fix includes.
12651         * python/py-block.c: Fix includes.
12652         * printcmd.c: Fix includes.
12653         * or1k-tdep.c: Fix includes.
12654         * mi/mi-main.c: Fix includes.
12655         * m32r-tdep.c: Fix includes.
12656         * csky-tdep.c: Fix includes.
12657         * compile/compile-cplus-types.c: Fix includes.
12658         * cli/cli-interp.c: Fix includes.
12659
12660 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
12661
12662         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
12663         for padding.
12664
12665 2019-01-16  Tom Tromey  <tom@tromey.com>
12666
12667         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
12668         earlier.
12669         (struct objfile) <msymbols_range>: Move from top level.
12670         <msymbols>: New method.
12671         (class objfile_msymbols): Remove.
12672         * symtab.c (default_collect_symbol_completion_matches_break_on):
12673         Update.
12674         * symmisc.c (dump_msymbols): Update.
12675         * stabsread.c (scan_file_globals): Update.
12676         * objc-lang.c (info_selectors_command, info_classes_command)
12677         (find_methods): Update.
12678         * minsyms.c (find_solib_trampoline_target): Update.
12679         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
12680         * coffread.c (coff_symfile_read): Update.
12681         * ada-lang.c (ada_lookup_simple_minsym)
12682         (ada_collect_symbol_completion_matches): Update.
12683
12684 2019-01-16  Tom Tromey  <tom@tromey.com>
12685
12686         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
12687         type.  Remove no-argument constructor.
12688         <iterator::operator++>: Simplify.
12689         <begin>: Update.
12690         <end>: Use minimal_symbol_count.
12691
12692 2019-01-16  Tom Tromey  <tom@tromey.com>
12693
12694         * objfiles.h (struct objfile) <psymtabs>: New method.
12695         (class objfile_psymtabs): Remove.
12696         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
12697         typedef.
12698         <range>: New method.
12699         (require_partial_symbols): Change return type.
12700         * psymtab.c (require_partial_symbols)
12701         (psym_expand_symtabs_matching): Update.
12702         * mdebugread.c (parse_partial_symbols): Update.
12703         * dbxread.c (dbx_end_psymtab): Update.
12704
12705 2019-01-15  Tom Tromey  <tom@tromey.com>
12706
12707         * symtab.c (lookup_objfile_from_block)
12708         (lookup_symbol_in_objfile_symtabs)
12709         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
12710         (find_line_symtab, info_sources_command)
12711         (default_collect_symbol_completion_matches_break_on)
12712         (make_source_files_completion_list): Update.
12713         * symmisc.c (print_objfile_statistics, dump_objfile)
12714         (maintenance_print_symbols, maintenance_info_symtabs)
12715         (maintenance_check_symtabs, maintenance_info_line_tables):
12716         Update.
12717         * source.c (select_source_symtab)
12718         (forget_cached_source_info_for_objfile): Update.
12719         * objfiles.h (class objfile_compunits): Remove.
12720         (struct objfile) <compunits_range>: New typedef.
12721         (compunits): New method.
12722         * objfiles.c (objfile_relocate1): Update.
12723         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12724         * maint.c (count_symtabs_and_blocks): Update.
12725         * linespec.c (iterate_over_all_matching_symtabs): Update.
12726         * cp-support.c (add_symbol_overload_list_qualified): Update.
12727         * coffread.c (coff_symtab_read): Update.
12728         * ada-lang.c (add_nonlocal_symbols)
12729         (ada_collect_symbol_completion_matches)
12730         (ada_add_global_exceptions): Update.
12731
12732 2019-01-15  Tom Tromey  <tom@tromey.com>
12733
12734         * progspace.h (program_space) <objfiles_safe_range>: New
12735         typedef.
12736         <objfiles_safe>: New method.
12737         * objfiles.h (class all_objfiles_safe): Remove.
12738         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
12739         * jit.c (jit_inferior_exit_hook): Update.
12740
12741 2019-01-17  Tom Tromey  <tom@tromey.com>
12742
12743         * progspace.h (program_space) <objfiles_range>: New typedef.
12744         <objfiles>: New method.
12745         <objfiles_head>: Rename from objfiles.
12746         (object_files): Update.
12747         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
12748         * guile/scm-pretty-print.c
12749         (ppscm_find_pretty_printer_from_objfiles): Update.
12750         * guile/scm-objfile.c (gdbscm_objfiles): Update.
12751         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
12752         Update.
12753         * python/py-progspace.c (pspy_get_objfiles): Update.
12754         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
12755         Update.
12756         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
12757         (objfpy_lookup_objfile_by_build_id): Update.
12758         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
12759         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
12760         Update.
12761         * symtab.c (iterate_over_symtabs, matching_obj_sections)
12762         (expand_symtab_containing_pc, lookup_objfile_from_block)
12763         (lookup_static_symbol, basic_lookup_transparent_type)
12764         (find_pc_sect_compunit_symtab, find_symbol_at_address)
12765         (find_line_symtab, info_sources_command)
12766         (default_collect_symbol_completion_matches_break_on)
12767         (make_source_files_completion_list, find_main_name): Update.
12768         * symmisc.c (print_symbol_bcache_statistics)
12769         (print_objfile_statistics, maintenance_print_symbols)
12770         (maintenance_print_msymbols, maintenance_print_objfiles)
12771         (maintenance_info_symtabs, maintenance_check_symtabs)
12772         (maintenance_expand_symtabs, maintenance_info_line_tables):
12773         Update.
12774         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
12775         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
12776         (map_overlay_command, unmap_overlay_command)
12777         (simple_overlay_update, expand_symtabs_matching)
12778         (map_symbol_filenames): Update.
12779         * symfile-debug.c (set_debug_symfile): Update.
12780         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
12781         Update.
12782         * source.c (select_source_symtab, forget_cached_source_info):
12783         Update.
12784         * solib.c (solib_read_symbols): Update.
12785         * solib-spu.c (append_ocl_sos): Update.
12786         * psymtab.c (maintenance_print_psymbols)
12787         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
12788         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
12789         * printcmd.c (info_symbol_command): Update.
12790         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
12791         Update.
12792         * objfiles.h (class all_objfiles): Remove.
12793         * objfiles.c (have_partial_symbols, have_full_symbols)
12794         (have_minimal_symbols, qsort_cmp, update_section_map)
12795         (shared_objfile_contains_address_p)
12796         (default_iterate_over_objfiles_in_search_order): Update.
12797         * objc-lang.c (info_selectors_command, info_classes_command)
12798         (find_methods): Update.
12799         * minsyms.c (find_solib_trampoline_target): Update.
12800         * maint.c (maintenance_info_sections)
12801         (maintenance_translate_address, count_symtabs_and_blocks):
12802         Update.
12803         * main.c (captured_main_1): Update.
12804         * linux-thread-db.c (try_thread_db_load_from_pdir)
12805         (has_libpthread): Update.
12806         * linespec.c (iterate_over_all_matching_symtabs)
12807         (search_minsyms_for_name): Update.
12808         * jit.c (jit_find_objf_with_entry_addr): Update.
12809         * hppa-tdep.c (find_unwind_entry)
12810         (hppa_lookup_stub_minimal_symbol): Update.
12811         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
12812         Update.
12813         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
12814         (elf_gnu_ifunc_resolve_by_got): Update.
12815         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
12816         * dwarf-index-write.c (save_gdb_index_command): Update.
12817         * cp-support.c (add_symbol_overload_list_qualified): Update.
12818         * breakpoint.c (create_overlay_event_breakpoint)
12819         (create_longjmp_master_breakpoint)
12820         (create_std_terminate_master_breakpoint)
12821         (create_exception_master_breakpoint): Update.
12822         * blockframe.c (find_pc_partial_function): Update.
12823         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
12824         (ada_collect_symbol_completion_matches)
12825         (ada_add_global_exceptions): Update.
12826
12827 2019-01-17  Tom Tromey  <tom@tromey.com>
12828
12829         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
12830         declare VEC.
12831         (solib_target_parse_libraries): Change return type.
12832         (library_list_start_segment, library_list_start_section)
12833         (library_list_end_library, library_list_start_library); Update.
12834         (solib_target_free_library_list): Remove.
12835         (solib_target_parse_libraries): Remove cleanup.  Change return
12836         type.
12837         (solib_target_current_sos): Update.
12838
12839 2019-01-17  Tom Tromey  <tromey@bapiya>
12840
12841         * valprint.c: Replace "the the" with "the".
12842         * symtab.c: Replace "the the" with "the".
12843         * solib.c: Replace "the the" with "the".
12844         * solib-dsbt.c: Replace "the the" with "the".
12845         * linespec.c: Replace "the the" with "the".
12846         * dwarf2loc.h: Replace "the the" with "the".
12847         * amd64-windows-tdep.c: Replace "the the" with "the".
12848         * aarch64-tdep.c: Replace "the the" with "the".
12849
12850 2019-01-16  Keith Seitz  <keiths@redhat.com>
12851
12852         PR gdb/23773
12853         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
12854         <builder>: Rename to ..
12855         <m_builder>: ... this and make private.
12856         (dwarf2_cu::get_builder): New method.  Change all users of
12857         `builder' to use this method.
12858         (dwarf2_start_symtab): Move to ...
12859         (dwarf2_cu::start_symtab): ... here.  Update all callers
12860         (setup_type_unit_groups): Move to ...
12861         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
12862         callers.
12863         (dwarf2_cu::reset_builder): New method.
12864         (process_full_compunit, process_full_type_unit): Use
12865         dwarf2_cu::reset_builder.
12866         (follow_die_offset): Record the ancestor CU if it is different
12867         from the followed DIE's CU.
12868         (follow_die_sig_1): Likewise.
12869
12870 2019-01-15  Tom Tromey  <tom@tromey.com>
12871
12872         * remote.c (class remote_state) <buf>: Now a char_vector.
12873         <buf_size>: Remove.
12874         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
12875         parameter.
12876         (remote_target::getpkt_or_notif_sane_1)
12877         (remote_target::getpkt_sane)
12878         (remote_target::getpkt_or_notif_sane): Likewise.
12879         (class remote_target) <putpkt>: New overload.
12880         (remote_target::read_frame): Change type of "buf_p".  Remove
12881         sizeof_p parameter.
12882         (packet_ok): New overload.
12883         (packet_check_result): New overload.
12884         Update all uses.
12885
12886 2019-01-14  Tom Tromey  <tom@tromey.com>
12887
12888         * remote-notif.c (handle_notification, remote_notif_ack)
12889         (remote_notif_parse): Make "buf" const.
12890         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
12891         const.
12892         (remote_notif_parse, remote_notif_ack, handle_notification):
12893         Likewise.
12894         * remote.c (remote_notif_stop_parse): Make "buf" const.
12895         (remote_target::remote_parse_stop_reply): Make "buf" const.
12896         (remote_notif_stop_ack): Make "buf" const.
12897
12898 2019-01-14  Tom Tromey  <tom@tromey.com>
12899
12900         * remote.c (remote_console_output): Make parameter const.
12901
12902 2019-01-14  Tom Tromey  <tom@tromey.com>
12903
12904         * target-debug.h (target_debug_print_signals): Constify.
12905         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
12906         * procfs.c (procfs_target::pass_signals): Update.
12907         * linux-nat.c (linux_nat_target::pass_signals): Update.
12908         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
12909         * target-delegates.c: Rebuild.
12910         * remote.c (remote_target::program_signals): Update.
12911         (remote_target::pass_signals): Update.
12912         * target.c (target_pass_signals): Constify argument.
12913         (target_program_signals): Likewise.
12914         * target.h (struct target_ops) <pass_signals, program_signals>:
12915         Constify argument.
12916         (target_pass_signals, target_program_signals): Constify argument.
12917
12918 2019-01-14  Tom Tromey  <tom@tromey.com>
12919
12920         PR tui/28819:
12921         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
12922
12923 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
12924
12925         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
12926         field.
12927         * rs6000-tdep.c: Include reggroups.h.
12928         (IS_V_ALIAS_PSEUDOREG): Define.
12929         (rs6000_register_name): Return names for the "vX" aliases.
12930         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
12931         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
12932         aliases.  Call default_register_reggroup_p for all other
12933         pseudo-registers.
12934         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
12935         New functions.
12936         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
12937         Handle "vX" aliases.
12938         (v_alias_pseudo_register_collect): New function.
12939         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
12940         (rs6000_gdbarch_init): Initialize "vX" aliases as
12941         pseudo-registers.  Restore registration of
12942         rs6000_pseudo_register_reggroup_p with
12943         set_tdesc_pseudo_register_reggroup_p.
12944
12945 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
12946
12947         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
12948         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
12949         set_gdbarch_num_pseudo_regs.
12950
12951 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12952
12953         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
12954         Remove arg prefixname, add do_set and do_show.
12955         Add member functions set_list and show_list.
12956         * cli/cli-style.c (class cli_style_option): Update accordingly.
12957         (style_set_list): Move to file scope.
12958         (style_show_list): Likewise.
12959         (set_style): Call help_list.
12960         (show_style): Call cmd_show_list.
12961         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
12962         Update to use the new macro.
12963
12964 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
12965
12966         * ada-lang.c (_initialize_ada_language): Expand the help text
12967         for the "catch exception" command.
12968
12969 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
12970
12971         * symtab.c (matching_obj_sections): Initialize obj,
12972         declare it closer to its usage.
12973
12974 2019-01-10  Tom Tromey  <tom@tromey.com>
12975
12976         * thread-iter.h (inf_threads_iterator): Use next_iterator.
12977         (basic_inf_threads_range): Remove.
12978         (inf_threads_range, inf_non_exited_threads_range)
12979         (safe_inf_threads_range): Use next_adapter.
12980
12981 2019-01-10  Keith Seitz  <keiths@redhat.com>
12982
12983         PR gdb/23712
12984         PR symtab/23010
12985         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
12986         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
12987
12988 2019-01-10  Keith Seitz  <keiths@redhat.com>
12989
12990         PR gdb/23712
12991         PR symtab/23010
12992         * dictionary.c (pending_to_vector): Remove.
12993         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
12994         Remove _1 suffix, replacing functions of the same name.  Update
12995         all callers.
12996         (dict_create_hashed, dict_create_hashed_expandable)
12997         (dict_create_linear, dict_create_linear_expandable, dict_free)
12998         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
12999         Make functions static.
13000
13001 2019-01-10  Keith Seitz  <keiths@redhat.com>
13002
13003         PR gdb/23712
13004         PR symtab/23010
13005         * dictionary.h (struct dictionary): Replace declaration with
13006         multidictionary.
13007         (dict_create_hashed, dict_create_hashed_expandable)
13008         (dict_create_linear, dict_create_linear_expandable)
13009         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
13010         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
13011         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
13012         taking multidictionary argument.
13013         [ALL_DICT_SYMBOLS]: Update for multidictionary.
13014         * block.h (struct block) <dict>: Change to multidictionary
13015         and rename `multidict'.
13016         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
13017         symmisc.c: Update all dictionary references to multidictionary.
13018
13019 2019-01-10  Keith Seitz  <keiths@redhat.com>
13020
13021         PR gdb/23712
13022         PR symtab/23010
13023         * dictionary.c: Include unordered_map.
13024         (pending_to_vector): New function.
13025         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
13026         Rewrite the non-"_1" functions to take vector instead
13027         of linked list.
13028         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
13029         "new" _1 versions of the same name.
13030         (multidictionary): Define.
13031         (std::hash<enum language): New definition.
13032         (collate_pending_symbols_by_language, mdict_create_hashed)
13033         (mdict_create_hashed_expandable, mdict_create_linear)
13034         (mdict_create_linear_expandable, mdict_free)
13035         (find_language_dictionary, create_new_language_dictionary)
13036         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
13037         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
13038         (mdict_size, mdict_empty): New functions.
13039         * dictionary.h (mdict_iterator): Define.
13040
13041 2019-01-10  Pedro Alves  <palves@redhat.com>
13042
13043         * breakpoint.c (read_uploaded_action)
13044         (create_tracepoint_from_upload): Adjust to use
13045         gdb::unique_xmalloc_ptr.
13046         * ctf.c (ctf_write_uploaded_tp):
13047         (SET_ARRAY_FIELD): Use emplace_back.
13048         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
13049         * tracefile-tfile.c (tfile_write_uploaded_tp):
13050         * tracepoint.c (parse_tracepoint_definition): Adjust to use
13051         gdb::unique_xmalloc_ptr.
13052         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
13053         at_string, cond_string, cmd_strings>: Replace char pointers
13054         with gdb::unique_xmalloc_ptr.
13055
13056 2019-01-10  Pedro Alves  <palves@redhat.com>
13057
13058         * solib-target.c (library_list_start_library): Don't xstrdup name.
13059
13060 2019-01-10  Pedro Alves  <palves@redhat.com>
13061
13062         * mdebugread.c (parse_partial_symbols): Use
13063         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
13064
13065 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13066
13067         * linux-fork.c (scoped_switch_fork_info)
13068         <~scoped_switch_fork_info>: Fix incorrect variable name.
13069
13070 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
13071
13072         * linux-fork.c (scoped_switch_fork_info)
13073         <scoped_switch_fork_info>: Make explicit.
13074         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
13075
13076 2019-01-10  Tom Tromey  <tom@tromey.com>
13077
13078         * objfiles.h (objfile::reset_psymtabs): Update.
13079         * objfiles.c (objfile::objfile): Update.
13080         * psymtab.h (psymtab_storage::obstack): Update.
13081         (psymtab_storage::m_obstack): Use gdb::optional.
13082         (class psymtab_storage): Update comment.  Remove objfile
13083         parameter.
13084         * psymtab.c (psymtab_storage::psymtab_storage): Update.
13085
13086 2019-01-10  Tom Tromey  <tom@tromey.com>
13087
13088         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
13089         <free_psymtabs>: Now private.
13090         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
13091         (allocate_psymtab): Use new method.
13092
13093 2019-01-10  Tom Tromey  <tom@tromey.com>
13094
13095         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
13096         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
13097         * mdebugread.c (parse_partial_symbols): Use
13098         allocate_dependencies.
13099         * dwarf2read.c (dwarf2_create_include_psymtab): Use
13100         allocate_dependencies.
13101         (process_psymtab_comp_unit_reader)
13102         (build_type_psymtab_dependencies): Likewise.
13103         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
13104
13105 2019-01-10  Tom Tromey  <tom@tromey.com>
13106
13107         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
13108         PSYMBOL_SET_LANGUAGE.
13109         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
13110
13111 2019-01-10  Tom Tromey  <tom@tromey.com>
13112
13113         * psymtab.h (psymtab_storage::obstack): New method.
13114         <m_obstack>: Rename from obstack; now private.
13115         * psymtab.c (psymtab_storage): Update.
13116         * dwarf2read.c (create_addrmap_from_index)
13117         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
13118         Update.
13119
13120 2019-01-10  Tom Tromey  <tom@tromey.com>
13121
13122         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
13123         * objfiles.h (objfile::reset_psymtabs): New method.
13124
13125 2019-01-10  Tom Tromey  <tom@tromey.com>
13126
13127         * symmisc.c (print_symbol_bcache_statistics): Update.
13128         (print_objfile_statistics): Update.
13129         * symfile.c (reread_symbols): Update.
13130         * psymtab.h (class psymtab_storage): New.
13131         * psymtab.c (psymtab_storage): New constructor.
13132         (~psymtab_storage): New destructor.
13133         (require_partial_symbols): Update.
13134         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
13135         (find_pc_sect_psymtab, find_pc_sect_psymbol)
13136         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
13137         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
13138         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
13139         (start_psymtab_common, end_psymtab_common)
13140         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
13141         (allocate_psymtab): Update.
13142         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
13143         Update.
13144         (dump_psymtab_addrmap, maintenance_print_psymbols)
13145         (maintenance_check_psymtabs): Update.
13146         (class objfile_psymtabs): Move to objfiles.h.
13147         * psympriv.h (discard_psymtab): Now inline.
13148         (psymtab_discarder::psymtab_discarder): Update.
13149         (psymtab_discarder::~psymtab_discarder): Update.
13150         (ALL_OBJFILE_PSYMTABS): Rewrite.
13151         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
13152         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
13153         Remove fields.
13154         <partial_symtabs>: New field.
13155         (class objfile_psymtabs): Move from psymtab.h.  Update.
13156         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
13157         psymbol_cache.
13158         (objfile::~objfile): Don't destroy psymbol_cache.
13159         * mdebugread.c (parse_partial_symbols): Update.
13160         * dwarf2read.c (create_addrmap_from_index)
13161         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
13162         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
13163         (add_partial_subprogram, dwarf2_ranges_read): Update.
13164         * dwarf-index-write.c (write_address_map)
13165         (write_one_signatured_type, recursively_write_psymbols)
13166         (class debug_names, class debug_names, write_psymtabs_to_index):
13167         Update.
13168
13169 2019-01-10  Tom Tromey  <tom@tromey.com>
13170
13171         * symtab.h (SYMBOL_SET_NAMES): Update.
13172         (symbol_set_names): Update.
13173         (MSYMBOL_SET_NAMES): Update.
13174         * symtab.c (symbol_set_names): Change argument to be an
13175         objfile_per_bfd_storage.
13176         * psymtab.c (add_psymbol_to_bcache): Update.
13177         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
13178
13179 2019-01-10  Tom Tromey  <tom@tromey.com>
13180
13181         * symtab.c (create_demangled_names_hash): Change argument to be an
13182         objfile_per_bfd_storage.
13183         (symbol_set_names): Update.
13184
13185 2019-01-10  Tom Tromey  <tom@tromey.com>
13186
13187         * xcoffread.c (xcoff_initial_scan): Unconditionally call
13188         init_psymbol_list.
13189         * psymtab.c (init_psymbol_list): Do nothing if already called.
13190         * psympriv.h (init_psymbol_list): Add comment.
13191         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
13192         init_psymbol_list.
13193         * dbxread.c (dbx_symfile_read): Unconditionally call
13194         init_psymbol_list.
13195
13196 2019-01-10  Tom Tromey  <tom@tromey.com>
13197
13198         * xcoffread.c (scan_xcoff_symtab): Update.
13199         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
13200         "where".
13201         * mdebugread.c (parse_partial_symbols)
13202         (handle_psymbol_enumerators): Update.
13203         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
13204         * dbxread.c (read_dbx_symtab): Update.
13205         * psympriv.h (psymbol_placement): New enum.
13206         (add_psymbol_to_list): Update.
13207
13208 2019-01-10  Tom Tromey  <tom@tromey.com>
13209
13210         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
13211         static_psymbols parameters.
13212         (scan_xcoff_symtab): Update.
13213         * psymtab.c (start_psymtab_common): Remove global_psymbols and
13214         static_psymbols parameters.
13215         * psympriv.h (start_psymtab_common): Update.
13216         * mdebugread.c (parse_partial_symbols): Update.
13217         * dwarf2read.c (create_partial_symtab): Update.
13218         * dbxread.c (read_dbx_symtab): Update.
13219         (start_psymtab): Remove global_psymbols and static_psymbols
13220         parameters.
13221
13222 2019-01-10  Tom Tromey  <tom@tromey.com>
13223
13224         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
13225         * psymtab.c (allocate_psymtab): Add comment.
13226         * psympriv.h (allocate_psymtab): Add comment.
13227         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
13228         initializations.
13229         * dbxread.c (dbx_end_psymtab): Remove some initializations.
13230
13231 2019-01-10  Tom Tromey  <tom@tromey.com>
13232
13233         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13234         Don't declare.
13235         * mipsread.c: Include mdebugread.h.
13236         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
13237         Declare.
13238         * elfread.c: Include mdebugread.h.
13239
13240 2019-01-09  Tom Tromey  <tom@tromey.com>
13241
13242         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
13243         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
13244         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
13245         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
13246         (psym_lookup_symbol, psym_find_last_source_symtab)
13247         (psym_forget_cached_source_info, psym_print_stats)
13248         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
13249         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
13250         (psym_map_matching_symbols, psym_expand_symtabs_matching)
13251         (psym_find_compunit_symtab_by_address)
13252         (maintenance_print_psymbols, maintenance_info_psymtabs)
13253         (maintenance_check_psymtabs): Use ranged for.
13254         * psymtab.h (class objfile_psymtabs): New.
13255         (require_partial_symbols): Return objfile_psymtabs.
13256         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
13257
13258 2019-01-09  Tom Tromey  <tom@tromey.com>
13259
13260         * symfile.c (overlay_invalidate_all, find_pc_overlay)
13261         (find_pc_mapped_section, list_overlays_command)
13262         (map_overlay_command, unmap_overlay_command)
13263         (simple_overlay_update): Use all_objfiles.
13264         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
13265         * printcmd.c (info_symbol_command): Use all_objfiles.
13266         * objfiles.h (ALL_OBJSECTIONS): Remove.
13267         * maint.c (maintenance_translate_address): Use all_objfiles.
13268         * gcore.c (gcore_create_callback): Use all_objfiles.
13269         (objfile_find_memory_regions): Likewise.
13270
13271 2019-01-09  Tom Tromey  <tom@tromey.com>
13272
13273         * symtab.c (find_line_symtab, info_sources_command)
13274         (make_source_files_completion_list): Use objfile_compunits.
13275         * source.c (select_source_symtab): Use objfile_compunits.
13276         * objfiles.h (struct objfile): Update comment.
13277         (ALL_OBJFILES): Remove.
13278         (ALL_FILETABS): Remove.
13279         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
13280         objfile_compunits.
13281
13282 2019-01-09  Tom Tromey  <tom@tromey.com>
13283
13284         * symmisc.c (print_objfile_statistics, dump_objfile)
13285         (maintenance_print_symbols): Use compunit_filetabs.
13286         * source.c (forget_cached_source_info_for_objfile): Use
13287         compunit_filetabs.
13288         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
13289         (ALL_FILETABS): Use compunit_filetabs.
13290         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
13291         * coffread.c (coff_symtab_read): Use compunit_filetabs.
13292
13293 2019-01-09  Tom Tromey  <tom@tromey.com>
13294
13295         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
13296         (compunit_filetabs): New.
13297         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
13298         compunit_filetabs.
13299         (info_sources_command, make_source_files_completion_list): Remove
13300         declaration.
13301         * symmisc.c (print_objfile_statistics, dump_objfile)
13302         (maintenance_print_symbols): Remove declaration.
13303         (maintenance_info_symtabs): Use compunit_filetabs.
13304         (maintenance_info_line_tables): Likewise.
13305         * source.c (select_source_symtab): Change local variable name.
13306         (forget_cached_source_info_for_objfile): Remove declaration.
13307         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
13308         * objfiles.c (objfile_relocate1): Remove declaration.
13309         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13310         declaration.
13311         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
13312         * coffread.c (coff_symtab_read): Remove declaration.
13313         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
13314         compunit_filetabs.
13315
13316 2019-01-09  Tom Tromey  <tom@tromey.com>
13317
13318         * symtab.c (lookup_objfile_from_block)
13319         (find_pc_sect_compunit_symtab, search_symbols)
13320         (default_collect_symbol_completion_matches_break_on): Use
13321         objfile_compunits.
13322         * objfiles.h (ALL_COMPUNITS): Remove.
13323         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
13324         * cp-support.c (add_symbol_overload_list_qualified): Use
13325         objfile_compunits.
13326         * ada-lang.c (ada_collect_symbol_completion_matches)
13327         (ada_add_global_exceptions): Use objfile_compunits.
13328
13329 2019-01-09  Tom Tromey  <tom@tromey.com>
13330
13331         * source.c (select_source_symtab)
13332         (forget_cached_source_info_for_objfile): Remove declaration.
13333         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
13334         declaration.
13335         * maint.c (count_symtabs_and_blocks): Remove declaration.
13336         * cp-support.c (add_symbol_overload_list_qualified): Remove
13337         declaration.
13338         * coffread.c (coff_symtab_read): Remove declaration.
13339         * symtab.c (lookup_symbol_in_objfile_symtabs)
13340         (basic_lookup_transparent_type_1): Use objfile_compunits.
13341         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
13342         (info_sources_command, search_symbols)
13343         (default_collect_symbol_completion_matches_break_on)
13344         (make_source_files_completion_list): Remove declaration.
13345         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
13346         (ada_collect_symbol_completion_matches)
13347         (ada_add_global_exceptions): Remove declaration.
13348         * linespec.c (iterate_over_all_matching_symtabs): Use
13349         objfile_compunits.
13350         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
13351         (class objfile_compunits): New.
13352         (ALL_COMPUNITS): Use objfile_compunits.
13353         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
13354         (maintenance_check_symtabs, maintenance_info_line_tables): Use
13355         objfile_compunits.
13356         * objfiles.c (objfile_relocate1): Use objfile_compunits.
13357
13358 2019-01-09  Tom Tromey  <tom@tromey.com>
13359
13360         * symtab.c (search_symbols)
13361         (default_collect_symbol_completion_matches_break_on): Use
13362         objfile_msymbols.
13363         * ada-lang.c (ada_lookup_simple_minsym)
13364         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
13365         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
13366         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
13367         objfile_msymbols.
13368         * coffread.c (coff_symfile_read): Use objfile_msymbols.
13369         * symmisc.c (dump_msymbols): Use objfile_msymbols.
13370         * objc-lang.c (find_methods): Use objfile_msymbols.
13371         (info_selectors_command, info_classes_command): Likewise.
13372         * stabsread.c (scan_file_globals): Use objfile_msymbols.
13373         * objfiles.h (class objfile_msymbols): New.
13374         (ALL_OBJFILE_MSYMBOLS): Remove.
13375         (ALL_MSYMBOLS): Remove.
13376
13377 2019-01-09  Tom Tromey  <tom@tromey.com>
13378
13379         * common/next-iterator.h (next_adapter): Add Iterator template
13380         parameter.
13381         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
13382         (class all_objfiles_safe): New.
13383         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
13384         * objfiles.c (put_objfile_before): Update comment.
13385         (add_separate_debug_objfile): Likewise.
13386         (free_all_objfiles): Use all_objfiles_safe.
13387         (objfile_purge_solibs): Likewise.
13388
13389 2019-01-09  Tom Tromey  <tom@tromey.com>
13390
13391         * symtab.c (iterate_over_symtabs, matching_obj_sections)
13392         (expand_symtab_containing_pc, lookup_static_symbol)
13393         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
13394         (find_symbol_at_address, find_line_symtab, find_main_name): Use
13395         all_objfiles.
13396         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
13397         * breakpoint.c (create_overlay_event_breakpoint)
13398         (create_longjmp_master_breakpoint)
13399         (create_std_terminate_master_breakpoint)
13400         (create_exception_master_breakpoint): Use all_objfiles.
13401         * linux-thread-db.c (try_thread_db_load_from_pdir)
13402         (has_libpthread): Use all_objfiles.
13403         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
13404         * linespec.c (iterate_over_all_matching_symtabs)
13405         (search_minsyms_for_name): Use all_objfiles.
13406         * maint.c (maintenance_info_sections): Use all_objfiles.
13407         * main.c (captured_main_1): Use all_objfiles.
13408         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
13409         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
13410         * guile/scm-pretty-print.c
13411         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
13412         * solib-spu.c (append_ocl_sos): Use all_objfiles.
13413         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
13414         (maintenance_print_msymbols): Use all_objfiles.
13415         * source.c (select_source_symtab): Use all_objfiles.
13416         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
13417         * symfile.c (remove_symbol_file_command)
13418         (expand_symtabs_matching, map_symbol_filenames): Use
13419         all_objfiles.
13420         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
13421         all_objfiles.
13422         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
13423         * objc-lang.c (find_methods): Use all_objfiles.
13424         * objfiles.c (have_partial_symbols, have_full_symbols)
13425         (have_minimal_symbols, qsort_cmp)
13426         (default_iterate_over_objfiles_in_search_order): Use
13427         all_objfiles.
13428         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
13429         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
13430         (maintenance_check_psymtabs): Use all_objfiles.
13431         (ALL_PSYMTABS): Remove.
13432         * compile/compile-object-run.c (do_module_cleanup): Use
13433         all_objfiles.
13434         * blockframe.c (find_pc_partial_function): Use all_objfiles.
13435         * cp-support.c (add_symbol_overload_list_qualified): Use
13436         all_objfiles.
13437         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
13438         Use all_objfiles.
13439         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
13440         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
13441         all_objfiles.
13442         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
13443         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
13444         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
13445         Uses all_objfiles.
13446         * solib.c (solib_read_symbols): Use all_objfiles
13447
13448 2019-01-09  Tom Tromey  <tom@tromey.com>
13449
13450         * probe.c (parse_probes_in_pspace): Use all_objfiles.
13451         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
13452         all_objfiles.
13453         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
13454         * symmisc.c (print_symbol_bcache_statistics)
13455         (print_objfile_statistics, maintenance_print_objfiles)
13456         (maintenance_info_symtabs, maintenance_check_symtabs)
13457         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
13458         all_objfiles.
13459         * source.c (forget_cached_source_info): Use all_objfiles.
13460         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
13461         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
13462         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
13463         * objfiles.c (update_section_map): Use all_objfiles.
13464         (shared_objfile_contains_address_p): Likewise.
13465         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
13466         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
13467
13468 2019-01-09  Tom Tromey  <tom@tromey.com>
13469
13470         * common/next-iterator.h: New file.
13471         * objfiles.h (class all_objfiles): New.
13472         (struct objfile_iterator): New.
13473
13474 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13475
13476         * NEWS: Move the description of the changed "frame", "select-frame",
13477          and "info frame" commands to the Changed commands section.
13478
13479 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
13480
13481         * gdbtypes.c (check_stub_method_group): Remove handling of old
13482         mangling schemes.
13483         * linespec.c (find_methods): Likewise.
13484         * stabsread.c (read_member_functions): Likewise.
13485         * valops.c (search_struct_method): Likewise.
13486         (value_struct_elt_for_reference): Likewise.
13487         * NEWS: Mention this change.
13488
13489 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
13490
13491         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
13492         print_source_lines.
13493         * source.c (print_source_lines_base): Update line number check.
13494         (print_source_lines): New function.
13495         (source_lines_range::source_lines_range): New function.
13496         * source.h (class source_lines_range): New class.
13497         (print_source_lines): New declaration.
13498
13499 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13500
13501         * linespec.c (linespec_state_destructor): Free self->canonical_names.
13502
13503 2019-01-08  Tom Tromey  <tom@tromey.com>
13504             Simon Marchi  <simon.marchi@ericsson.com>
13505
13506         PR gdb/24060
13507         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
13508         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
13509         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13510         * f-exp.y (DOLLAR_VARIABLE): Likewise.
13511         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
13512         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
13513
13514 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13515
13516         * source.c (select_source_symtab): Move header comment to
13517         declaration in source.h.
13518         (forget_cached_source_info_for_objfile): Likewise.
13519         (forget_cached_source_info): Likewise.
13520         (identify_source_line): Likewise.
13521         * source.h (identify_source_line): Move declaration from symtab.h
13522         and add comment from source.c
13523         (print_source_lines): Likewise.
13524         (forget_cached_source_info_for_objfile): Likewise.
13525         (forget_cached_source_info): Likewise.
13526         (select_source_symtab): Likewise.
13527         (enum print_source_lines_flag): Move definition from symtab.h.
13528         * symtab.h (identify_source_line): Move declaration to source.h.
13529         (print_source_lines): Likewise.
13530         (forget_cached_source_info_for_objfile): Likewise.
13531         (forget_cached_source_info): Likewise.
13532         (select_source_symtab): Likewise.
13533         (enum print_source_lines_flag): Move definition to source.h.
13534         * tui/tui-hooks.c: Add 'source.h' include.
13535
13536 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13537
13538         * source.c (print_source_lines_base): Handle requests to print
13539         reverse line number sequences, and guard against empty lines
13540         string.
13541
13542 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
13543
13544         * source.c (print_source_lines_base): Fix skip of '\r' if next
13545         character is '\n'.
13546
13547 2019-01-06  Tom Tromey  <tom@tromey.com>
13548
13549         * c-exp.y (struct c_parse_state) <macro_original_text,
13550         expansion_obstack>: New member.
13551         (macro_original_text, expansion_obstack): Remove globals.
13552         (scan_macro_expansion, scanning_macro_expansion)
13553         (finished_macro_expansion): Update.
13554         (scan_macro_cleanup): Remove.
13555         (yylex, c_parse): Update.
13556
13557 2019-01-06  Tom Tromey  <tom@tromey.com>
13558
13559         * c-exp.y (struct c_parse_state) <strings>: New member.
13560         (operator_stoken): Update.
13561
13562 2019-01-06  Tom Tromey  <tom@tromey.com>
13563
13564         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
13565         (union type_stack_elt) <typelist_val>: Now a pointer to
13566         std::vector.
13567         (type_stack_cleanup): Don't declare.
13568         (push_typelist): Update.
13569         * parse.c (pop_typelist): Return a std::vector.
13570         (push_typelist): Take a std::vector.
13571         (follow_types): Update.  Do not free args.
13572         (type_stack_cleanup): Remove.
13573         * c-exp.y (struct c_parse_state): New.
13574         (cpstate): New global.
13575         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
13576         (nonempty_typelist): Update.
13577         (func_mod): Create a new vector.
13578         (c_parse): Create a c_parse_state.
13579         (check_parameter_typelist): Do not delete params.
13580         (function_method): Update.  Do not delete type_list.
13581
13582 2019-01-06  Tom Tromey  <tom@tromey.com>
13583
13584         PR gdb/28155:
13585         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
13586         check_typedef.
13587         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
13588         (print_return_value): Likewise.
13589
13590 2019-01-05  Tom Tromey  <tom@tromey.com>
13591
13592         * contrib/cleanup_check.py: Remove.
13593         * contrib/gcc-with-excheck: Remove.
13594         * contrib/exsummary.py: Remove.
13595         * contrib/excheck.py: Remove.
13596
13597 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
13598
13599         * thread.c (delete_thread_1): Add gdb_assert that THR is not
13600         NULL. Initialize tpprev to NULL instead of assigning it
13601         to NULL on the next statement.
13602         * windows-nat.c (windows_delete_thread): Remove check for
13603         main_thread_id before printing thread exit notifications.
13604         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
13605         Remove thread ID check against main_thread_id.
13606         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
13607         windows_delete_thread.
13608         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
13609
13610 2019-01-04  Tom Tromey  <tom@tromey.com>
13611
13612         * compile/compile.c (_initialize_compile): Use upper case for
13613         metasyntactic variables.
13614         * symmisc.c (_initialize_symmisc): Use upper case for
13615         metasyntactic variables.
13616         * psymtab.c (_initialize_psymtab): Use upper case for
13617         metasyntactic variables.
13618         * demangle.c (demangle_command): Use upper case for metasyntactic
13619         variables.
13620         (_initialize_demangler): Likewise.
13621         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
13622         variables.
13623
13624 2019-01-03  Tom Tromey  <tom@tromey.com>
13625
13626         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
13627
13628 2019-01-03  Tom Tromey  <tom@tromey.com>
13629
13630         * python/py-symtab.c (salpy_str): Update.
13631         (struct salpy_sal_object) <symtab>: Now a PyObject.
13632         (salpy_dealloc): Update.
13633         (del_objfile_sal): Use gdbpy_ref.
13634
13635 2019-01-03  Tom Tromey  <tom@tromey.com>
13636
13637         * python/py-type.c (convert_field): Use new_reference.  Return
13638         gdbpy_ref.
13639         (make_fielditem): Return gdbpy_ref.
13640         (typy_fields): Update.
13641         (typy_getitem): Update.
13642         (field_name): Return gdbpy_ref.  Use new_reference.
13643         (typy_iterator_iternext): Update.
13644
13645 2019-01-03  Tom Tromey  <tom@tromey.com>
13646
13647         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
13648
13649 2019-01-03  Tom Tromey  <tom@tromey.com>
13650
13651         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
13652         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
13653         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
13654         (pspy_set_frame_filters, pspy_set_frame_unwinders)
13655         (pspy_set_type_printers): Likewise.
13656         * python/py-function.c (fnpy_init): Use gdbpy_ref.
13657         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
13658         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
13659         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
13660         (objfpy_set_type_printers): Likewise.
13661
13662 2019-01-03  Tom Tromey  <tom@tromey.com>
13663
13664         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
13665         (gdbpy_print_stack): Use gdbpy_err_fetch.
13666         * python/python-internal.h (class gdbpy_err_fetch): New class.
13667         (class gdbpy_enter) <m_error_type, m_error_value,
13668         m_error_traceback>: Remove.
13669         <m_error>: New member.
13670         (gdbpy_exception_to_string): Don't declare.
13671         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
13672         * python/py-value.c (convert_value_from_python): Use
13673         gdbpy_err_fetch.
13674         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
13675         gdbpy_exception_to_string.
13676         (gdbpy_handle_exception): Use gdbpy_err_fetch.
13677         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
13678         gdbpy_err_fetch.
13679
13680 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13681
13682         * linux-nat.c (delete_lwp_cleanup): Delete.
13683         (struct lwp_deleter): New struct.
13684         (lwp_info_up): New typedef.
13685         (linux_nat_target::follow_fork): Delete cleanup, and make use of
13686         lwp_info_up.
13687
13688 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13689
13690         * linux-fork.c (class scoped_switch_fork_info): New class.
13691         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
13692
13693 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13694
13695         * valops.c (find_overload_match): Remove use of null_cleanup, and
13696         calls to do_cleanups.
13697
13698 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13699
13700         * compile/compile-cplus-types.c
13701         (compile_cplus_instance::decl_name): Handle changes to
13702         cp_func_name.
13703         * cp-support.c (cp_func_name): Update header comment, update
13704         return type.
13705         * cp-support.h (cp_func_name): Update return type in declaration.
13706         * valops.c (find_overload_match): Move temp_func local to top
13707         level of function and change its type.  Use temp_func to hold and
13708         delete temporary string obtained from cp_func_name.
13709
13710 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
13711
13712         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
13713         gdb::char_vector, remove cleanup, and update uses of `msg`.
13714
13715 2019-01-03  Jim Wilson  <jimw@sifive.com>
13716
13717         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
13718
13719 2019-01-02  Tom Tromey  <tom@tromey.com>
13720
13721         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
13722         (tdesc_parse_xml): Remove cleanups.
13723         * target-descriptions.h (make_cleanup_free_target_description):
13724         Don't declare.
13725         (target_desc_deleter): New struct.
13726         (target_desc_up): New typedef.
13727         * target-descriptions.c (target_desc_deleter::operator()): Rename
13728         from free_target_description.
13729         (make_cleanup_free_target_description): Remove.
13730
13731 2019-01-02  Tom Tromey  <tom@tromey.com>
13732
13733         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
13734         constructor, destructor.
13735         (linespec_parser): Remove typedef.
13736         (~linespec_parser): Rename from linespec_parser_delete.
13737         (linespec_lex_to_end, linespec_complete_label)
13738         (linespec_complete): Update.
13739         (decode_line_full): Remove cleanups.
13740         (decode_line_1): Update.
13741
13742 2019-01-02  Tom Tromey  <tom@tromey.com>
13743
13744         * python/python-internal.h (inferior_to_inferior_object): Change
13745         return type.
13746         * python/py-exitedevent.c (create_exited_event_object): Update.
13747         * python/py-inferior.c (inferior_to_inferior_object): Return
13748         gdbpy_ref.
13749         (python_new_inferior, python_inferior_deleted)
13750         (thread_to_thread_object, delete_thread_object)
13751         (build_inferior_list, gdbpy_selected_inferior): Update.
13752         * python/py-infthread.c (create_thread_object): Update.  Also fail
13753         if inferior_to_inferior_object fails.
13754
13755 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
13756
13757         * inferior.h (class inferior) <displaced_step_state>: New field.
13758         * infrun.h (struct displaced_step_state): Move here from
13759         infrun.c.  Initialize fields, add constructor.
13760         <inf>: Remove field.
13761         <reset>: New method.
13762         * infrun.c (struct displaced_step_inferior_state): Move to
13763         infrun.h.
13764         (displaced_step_inferior_states): Remove.
13765         (get_displaced_stepping_state): Adust.
13766         (displaced_step_in_progress_any_inferior): Adjust.
13767         (displaced_step_in_progress_thread): Adjust.
13768         (displaced_step_in_progress): Adjust.
13769         (add_displaced_stepping_state): Remove.
13770         (get_displaced_step_closure_by_addr): Adjust.
13771         (remove_displaced_stepping_state): Remove.
13772         (infrun_inferior_exit): Call displaced_step_state.reset.
13773         (use_displaced_stepping): Don't check for NULL.
13774         (displaced_step_prepare_throw): Call
13775         get_displaced_stepping_state.
13776         (displaced_step_fixup): Don't check for NULL.
13777         (prepare_for_detach): Don't check for NULL.
13778
13779 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13780
13781         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
13782          in case of call that did not complete.
13783
13784 2019-01-02  Andrey Utkin  <autkin@undo.io>
13785
13786         * symfile.c (find_separate_debug_file): Fix search of debug files for
13787         remote debuggee.
13788
13789 2019-01-02  Tom Tromey  <tom@tromey.com>
13790
13791         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
13792         indentation.
13793         * python/py-frame.c (frapy_older): Remove cast.
13794         (frapy_newer): Likewise.
13795         * python/py-breakpoint.c (local_setattro): Remove cast.
13796         * python/py-arch.c (archpy_name): Remove local variable.
13797         * python/py-type.c (gdbpy_lookup_type): Remove cast.
13798
13799 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
13800
13801         * unittests/basic_string_view/element_access/char/empty.cc:
13802         Fix year range in copyright header.
13803
13804 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13805
13806         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
13807         Delete.
13808         <operator==>: Update with for removed field.
13809         <hash>: Likewise.
13810         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
13811         <isa_features>: ...this.
13812         <abi_features>: New field.
13813         (riscv_isa_flen): Update comment.
13814         (riscv_abi_xlen): New declaration.
13815         (riscv_abi_flen): New declaration.
13816         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
13817         isa_features.
13818         (riscv_abi_xlen): New function.
13819         (riscv_isa_flen): Update to get answer from isa_features.
13820         (riscv_abi_flen): New function.
13821         (riscv_has_fp_abi): Update to get answer from abi_features.
13822         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
13823         xlen and flen.
13824         (riscv_call_info) <xlen, flen>: Update comment.
13825         (riscv_call_arg_struct): Remove invalid assertions
13826         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
13827         is removed.
13828         (riscv_gdbarch_init): Gather isa features and abi features
13829         separately, ensure both match on the gdbarch when reusing an old
13830         gdbarch.  Relax an error check to allow 32-bit abi float to run on
13831         a target with 64-bit float hardware.
13832
13833 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13834
13835         * source.c (search_command_helper): Stop reverse search
13836         when line 1 has been searched.
13837
13838 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13839
13840         * record-full.c (record_full_base_target::close): Rewrite
13841         record_full_core_buf_list free logic.
13842
13843 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13844
13845         * break-catch-syscall.c (print_one_catch_syscall): xfree
13846         the last text.
13847
13848 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13849
13850         * top.c (print_gdb_version): Update Copyright year in version
13851         message.
13852
13853 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
13854
13855         Update copyright year range in all GDB files.
13856
13857 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
13858
13859         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
13860
13861 For older changes see ChangeLog-2018.
13862 \f
13863 Local Variables:
13864 mode: change-log
13865 left-margin: 8
13866 fill-column: 74
13867 version-control: never
13868 coding: utf-8
13869 End:
13870