gdb/ChangeLog

   1 2019-01-24  Pedro Alves  <palves@redhat.com>
   2
   3         * common/forward-scope-exit.h
   4         (forward_scope_exit::forward_scope_exit): Pass arguments to
   5         m_bind_function directly, instead of creating a std::bind and
   6         copying that.
   7
   8 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
   9
  10         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
  11         for static members.
  12         (pass_in_v_vfp_candidate): Likewise.
  13
  14 2019-01-23  Tom Tromey  <tom@tromey.com>
  15             Pedro Alves  <palves@redhat.com>
  16
  17         * regcache.c (class regcache_invalidator): Remove.
  18         (regcache::raw_write): Use make_scope_exit.
  19
  20 2019-01-23  Tom Tromey  <tom@tromey.com>
  21
  22         * ui-out.h (class ui_out_emit_type): Update comment.
  23
  24 2019-01-23  Tom Tromey  <tom@tromey.com>
  25
  26         * infrun.c (fetch_inferior_event): Update comment.
  27
  28 2019-01-23  Tom Tromey  <tom@tromey.com>
  29             Pedro Alves  <palves@redhat.com>
  30
  31         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
  32         parameter.
  33         (fetch_inferior_event): Use SCOPE_EXIT.
  34
  35
  36 2019-01-23  Tom Tromey  <tom@tromey.com>
  37             Pedro Alves  <palves@redhat.com>
  38
  39         * infrun.c (disable_thread_events): Delete.
  40         (stop_all_threads): Use SCOPE_EXIT.
  41
  42 2019-01-23  Tom Tromey  <tom@tromey.com>
  43             Pedro Alves  <palves@redhat.com>
  44
  45         * symfile.c: Include forward-scope-exit.h.
  46         (clear_symtab_users_cleanup): Replace forward declaration with
  47         a FORWARD_SCOPE_EXIT.
  48         (syms_from_objfile_1): Use the forward_scope_exit and
  49         gdb::optional instead of cleanup_function.
  50         (reread_symbols): Use the forward_scope_exit instead of
  51         cleanup_function.
  52         (clear_symtab_users_cleanup): Remove function.
  53
  54 2019-01-23  Tom Tromey  <tom@tromey.com>
  55             Pedro Alves  <palves@redhat.com>
  56
  57         * linux-nat.c: Include scope-exit.h.
  58         (cleanup_target_stop): Remove.
  59         (linux_nat_target::static_tracepoint_markers_by_strid): Use
  60         SCOPE_EXIT.
  61
  62 2019-01-23  Tom Tromey  <tom@tromey.com>
  63             Pedro Alves  <palves@redhat.com>
  64
  65         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
  66         (call_function_by_hand_dummy): Use SCOPE_EXIT.
  67
  68 2019-01-23  Tom Tromey  <tom@tromey.com>
  69             Andrew Burgess  <andrew.burgess@embecosm.com>
  70             Pedro Alves  <palves@redhat.com>
  71
  72         * infrun.c (fetch_inferior_event): Use scope_exit.
  73         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
  74         * top.c (execute_command): Use scope_exit.
  75         * breakpoint.c (bpstat_do_actions): Use scope_exit.
  76         * utils.c (do_bpstat_clear_actions_cleanup)
  77         (make_bpstat_clear_actions_cleanup): Remove.
  78
  79 2019-01-23  Tom Tromey  <tom@tromey.com>
  80             Pedro Alves  <palves@redhat.com>
  81
  82         * infrun.c: Include "common/scope-exit.h"
  83         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
  84         (wait_for_inferior): Use SCOPE_EXIT.
  85         (fetch_inferior_event): Use scope_exit.
  86
  87 2019-01-23  Tom Tromey  <tom@tromey.com>
  88             Pedro Alves  <palves@redhat.com>
  89
  90         * breakpoint.c (create_breakpoint): Remove cleanup.
  91
  92 2019-01-23  Tom Tromey  <tom@tromey.com>
  93             Andrew Burgess  <andrew.burgess@embecosm.com>
  94             Pedro Alves  <palves@redhat.com>
  95
  96 2019-01-23  Pedro Alves  <palves@redhat.com>
  97
  98         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
  99
 100 2019-01-23  Pedro Alves  <palves@redhat.com>
 101             Andrew Burgess  <andrew.burgess@embecosm.com>
 102
 103         * gdbthread.h: Include "common/forward-scope-exit.h".
 104         (scoped_finish_thread_state): Redefine custom class in terms of
 105         forward_scope_exit.
 106
 107 2019-01-23  Pedro Alves  <palves@redhat.com>
 108             Andrew Burgess  <andrew.burgess@embecosm.com>
 109
 110         * common/forward-scope-exit.h: New file.
 111
 112 2019-01-23  Pedro Alves  <palves@redhat.com>
 113             Andrew Burgess  <andrew.burgess@embecosm.com>
 114             Tom Tromey  <tom@tromey.com>
 115
 116         * common/scope-exit.h: New file.
 117
 118 2019-01-23  Pedro Alves  <palves@redhat.com>
 119
 120         * common/preprocessor.h (ESC): Rename to ...
 121         (ESC_PARENS): ... this.
 122         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
 123         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
 124
 125 2019-01-23  Tom Tromey  <tom@tromey.com>
 126
 127         * language.h (class scoped_switch_to_sym_language_if_auto):
 128         Initialize m_lang in both cases.
 129
 130 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
 131
 132         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
 133         with XCNEW.
 134
 135 2019-01-22  Tom Tromey  <tom@tromey.com>
 136
 137         * corelow.c: Do not include sys/file.h.
 138
 139 2019-01-22  Tom Tromey  <tom@tromey.com>
 140
 141         * tui/tui-wingeneral.h: Include gdb_curses.h.
 142
 143 2019-01-22  Tom Tromey  <tom@tromey.com>
 144
 145         * source-cache.h (class source_cache) <get_source_lines,
 146         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
 147
 148 2019-01-22  Tom Tromey  <tom@tromey.com>
 149
 150         * remote-fileio.h (struct remote_target): Declare.
 151
 152 2019-01-22  Tom Tromey  <tom@tromey.com>
 153
 154         * python/py-arch.c: Do not include py-ref.h.
 155         * python/py-bpevent.c: Do not include py-ref.h.
 156         * python/py-cmd.c: Do not include py-ref.h.
 157         * python/py-continueevent.c: Do not include py-ref.h.
 158         * python/py-event.h: Do not include py-ref.h.
 159         * python/py-evtregistry.c: Do not include py-ref.h.
 160         * python/py-finishbreakpoint.c: Do not include py-ref.h.
 161         * python/py-frame.c: Do not include py-ref.h.
 162         * python/py-framefilter.c: Do not include py-ref.h.
 163         * python/py-function.c: Do not include py-ref.h.
 164         * python/py-infevents.c: Do not include py-ref.h.
 165         * python/py-linetable.c: Do not include py-ref.h.
 166         * python/py-objfile.c: Do not include py-ref.h.
 167         * python/py-param.c: Do not include py-ref.h.
 168         * python/py-prettyprint.c: Do not include py-ref.h.
 169         * python/py-progspace.c: Do not include py-ref.h.
 170         * python/py-symbol.c: Do not include py-ref.h.
 171         * python/py-symtab.c: Do not include py-ref.h.
 172         * python/py-type.c: Do not include py-ref.h.
 173         * python/py-unwind.c: Do not include py-ref.h.
 174         * python/py-utils.c: Do not include py-ref.h.
 175         * python/py-value.c: Do not include py-ref.h.
 176         * python/py-varobj.c: Do not include py-ref.h.
 177         * python/py-xmethods.c: Do not include py-ref.h.
 178         * python/python.c: Do not include py-ref.h.
 179         * varobj.c: Do not include py-ref.h.
 180
 181 2019-01-22  Tom Tromey  <tom@tromey.com>
 182
 183         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
 184         keyword for bcache.
 185
 186 2019-01-22  Tom Tromey  <tom@tromey.com>
 187
 188         * compile/compile-cplus-types.c: Remove a comment by #include.
 189
 190 2019-01-22  Tom Tromey  <tom@tromey.com>
 191
 192         * compile/gcc-c-plugin.h: Include compile-internal.h.
 193
 194 2019-01-22  Tom Tromey  <tom@tromey.com>
 195
 196         * stabsread.c (EXTERN): Do not define.
 197         (symnum, next_symbol_text_func, processing_gcc_compilation)
 198         (within_function, global_sym_chain, global_stabs)
 199         (previous_stab_code, this_object_header_files)
 200         (n_this_object_header_files)
 201         (n_allocated_this_object_header_files): Define.
 202         * stabsread.h (EXTERN): Never define.  Use "extern".
 203
 204 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 205
 206         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
 207         history_value.
 208
 209 2019-01-21  Tom Tromey  <tom@tromey.com>
 210
 211         * ui-out.c: Fix includes.
 212         * tui/tui-source.c: Fix includes.
 213         * target.c: Fix includes.
 214         * remote.c: Fix includes.
 215         * regcache.c: Fix includes.
 216         * python/py-block.c: Fix includes.
 217         * printcmd.c: Fix includes.
 218         * or1k-tdep.c: Fix includes.
 219         * mi/mi-main.c: Fix includes.
 220         * m32r-tdep.c: Fix includes.
 221         * csky-tdep.c: Fix includes.
 222         * compile/compile-cplus-types.c: Fix includes.
 223         * cli/cli-interp.c: Fix includes.
 224
 225 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
 226
 227         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
 228         for padding.
 229
 230 2019-01-16  Tom Tromey  <tom@tromey.com>
 231
 232         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
 233         earlier.
 234         (struct objfile) <msymbols_range>: Move from top level.
 235         <msymbols>: New method.
 236         (class objfile_msymbols): Remove.
 237         * symtab.c (default_collect_symbol_completion_matches_break_on):
 238         Update.
 239         * symmisc.c (dump_msymbols): Update.
 240         * stabsread.c (scan_file_globals): Update.
 241         * objc-lang.c (info_selectors_command, info_classes_command)
 242         (find_methods): Update.
 243         * minsyms.c (find_solib_trampoline_target): Update.
 244         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
 245         * coffread.c (coff_symfile_read): Update.
 246         * ada-lang.c (ada_lookup_simple_minsym)
 247         (ada_collect_symbol_completion_matches): Update.
 248
 249 2019-01-16  Tom Tromey  <tom@tromey.com>
 250
 251         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
 252         type.  Remove no-argument constructor.
 253         <iterator::operator++>: Simplify.
 254         <begin>: Update.
 255         <end>: Use minimal_symbol_count.
 256
 257 2019-01-16  Tom Tromey  <tom@tromey.com>
 258
 259         * objfiles.h (struct objfile) <psymtabs>: New method.
 260         (class objfile_psymtabs): Remove.
 261         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
 262         typedef.
 263         <range>: New method.
 264         (require_partial_symbols): Change return type.
 265         * psymtab.c (require_partial_symbols)
 266         (psym_expand_symtabs_matching): Update.
 267         * mdebugread.c (parse_partial_symbols): Update.
 268         * dbxread.c (dbx_end_psymtab): Update.
 269
 270 2019-01-15  Tom Tromey  <tom@tromey.com>
 271
 272         * symtab.c (lookup_objfile_from_block)
 273         (lookup_symbol_in_objfile_symtabs)
 274         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
 275         (find_line_symtab, info_sources_command)
 276         (default_collect_symbol_completion_matches_break_on)
 277         (make_source_files_completion_list): Update.
 278         * symmisc.c (print_objfile_statistics, dump_objfile)
 279         (maintenance_print_symbols, maintenance_info_symtabs)
 280         (maintenance_check_symtabs, maintenance_info_line_tables):
 281         Update.
 282         * source.c (select_source_symtab)
 283         (forget_cached_source_info_for_objfile): Update.
 284         * objfiles.h (class objfile_compunits): Remove.
 285         (struct objfile) <compunits_range>: New typedef.
 286         (compunits): New method.
 287         * objfiles.c (objfile_relocate1): Update.
 288         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 289         * maint.c (count_symtabs_and_blocks): Update.
 290         * linespec.c (iterate_over_all_matching_symtabs): Update.
 291         * cp-support.c (add_symbol_overload_list_qualified): Update.
 292         * coffread.c (coff_symtab_read): Update.
 293         * ada-lang.c (add_nonlocal_symbols)
 294         (ada_collect_symbol_completion_matches)
 295         (ada_add_global_exceptions): Update.
 296
 297 2019-01-15  Tom Tromey  <tom@tromey.com>
 298
 299         * progspace.h (program_space) <objfiles_safe_range>: New
 300         typedef.
 301         <objfiles_safe>: New method.
 302         * objfiles.h (class all_objfiles_safe): Remove.
 303         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
 304         * jit.c (jit_inferior_exit_hook): Update.
 305
 306 2019-01-17  Tom Tromey  <tom@tromey.com>
 307
 308         * progspace.h (program_space) <objfiles_range>: New typedef.
 309         <objfiles>: New method.
 310         <objfiles_head>: Rename from objfiles.
 311         (object_files): Update.
 312         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
 313         * guile/scm-pretty-print.c
 314         (ppscm_find_pretty_printer_from_objfiles): Update.
 315         * guile/scm-objfile.c (gdbscm_objfiles): Update.
 316         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
 317         Update.
 318         * python/py-progspace.c (pspy_get_objfiles): Update.
 319         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
 320         Update.
 321         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
 322         (objfpy_lookup_objfile_by_build_id): Update.
 323         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
 324         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
 325         Update.
 326         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 327         (expand_symtab_containing_pc, lookup_objfile_from_block)
 328         (lookup_static_symbol, basic_lookup_transparent_type)
 329         (find_pc_sect_compunit_symtab, find_symbol_at_address)
 330         (find_line_symtab, info_sources_command)
 331         (default_collect_symbol_completion_matches_break_on)
 332         (make_source_files_completion_list, find_main_name): Update.
 333         * symmisc.c (print_symbol_bcache_statistics)
 334         (print_objfile_statistics, maintenance_print_symbols)
 335         (maintenance_print_msymbols, maintenance_print_objfiles)
 336         (maintenance_info_symtabs, maintenance_check_symtabs)
 337         (maintenance_expand_symtabs, maintenance_info_line_tables):
 338         Update.
 339         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
 340         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
 341         (map_overlay_command, unmap_overlay_command)
 342         (simple_overlay_update, expand_symtabs_matching)
 343         (map_symbol_filenames): Update.
 344         * symfile-debug.c (set_debug_symfile): Update.
 345         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
 346         Update.
 347         * source.c (select_source_symtab, forget_cached_source_info):
 348         Update.
 349         * solib.c (solib_read_symbols): Update.
 350         * solib-spu.c (append_ocl_sos): Update.
 351         * psymtab.c (maintenance_print_psymbols)
 352         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
 353         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
 354         * printcmd.c (info_symbol_command): Update.
 355         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
 356         Update.
 357         * objfiles.h (class all_objfiles): Remove.
 358         * objfiles.c (have_partial_symbols, have_full_symbols)
 359         (have_minimal_symbols, qsort_cmp, update_section_map)
 360         (shared_objfile_contains_address_p)
 361         (default_iterate_over_objfiles_in_search_order): Update.
 362         * objc-lang.c (info_selectors_command, info_classes_command)
 363         (find_methods): Update.
 364         * minsyms.c (find_solib_trampoline_target): Update.
 365         * maint.c (maintenance_info_sections)
 366         (maintenance_translate_address, count_symtabs_and_blocks):
 367         Update.
 368         * main.c (captured_main_1): Update.
 369         * linux-thread-db.c (try_thread_db_load_from_pdir)
 370         (has_libpthread): Update.
 371         * linespec.c (iterate_over_all_matching_symtabs)
 372         (search_minsyms_for_name): Update.
 373         * jit.c (jit_find_objf_with_entry_addr): Update.
 374         * hppa-tdep.c (find_unwind_entry)
 375         (hppa_lookup_stub_minimal_symbol): Update.
 376         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
 377         Update.
 378         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
 379         (elf_gnu_ifunc_resolve_by_got): Update.
 380         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
 381         * dwarf-index-write.c (save_gdb_index_command): Update.
 382         * cp-support.c (add_symbol_overload_list_qualified): Update.
 383         * breakpoint.c (create_overlay_event_breakpoint)
 384         (create_longjmp_master_breakpoint)
 385         (create_std_terminate_master_breakpoint)
 386         (create_exception_master_breakpoint): Update.
 387         * blockframe.c (find_pc_partial_function): Update.
 388         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
 389         (ada_collect_symbol_completion_matches)
 390         (ada_add_global_exceptions): Update.
 391
 392 2019-01-17  Tom Tromey  <tom@tromey.com>
 393
 394         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
 395         declare VEC.
 396         (solib_target_parse_libraries): Change return type.
 397         (library_list_start_segment, library_list_start_section)
 398         (library_list_end_library, library_list_start_library); Update.
 399         (solib_target_free_library_list): Remove.
 400         (solib_target_parse_libraries): Remove cleanup.  Change return
 401         type.
 402         (solib_target_current_sos): Update.
 403
 404 2019-01-17  Tom Tromey  <tromey@bapiya>
 405
 406         * valprint.c: Replace "the the" with "the".
 407         * symtab.c: Replace "the the" with "the".
 408         * solib.c: Replace "the the" with "the".
 409         * solib-dsbt.c: Replace "the the" with "the".
 410         * linespec.c: Replace "the the" with "the".
 411         * dwarf2loc.h: Replace "the the" with "the".
 412         * amd64-windows-tdep.c: Replace "the the" with "the".
 413         * aarch64-tdep.c: Replace "the the" with "the".
 414
 415 2019-01-16  Keith Seitz  <keiths@redhat.com>
 416
 417         PR gdb/23773
 418         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
 419         <builder>: Rename to ..
 420         <m_builder>: ... this and make private.
 421         (dwarf2_cu::get_builder): New method.  Change all users of
 422         `builder' to use this method.
 423         (dwarf2_start_symtab): Move to ...
 424         (dwarf2_cu::start_symtab): ... here.  Update all callers
 425         (setup_type_unit_groups): Move to ...
 426         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
 427         callers.
 428         (dwarf2_cu::reset_builder): New method.
 429         (process_full_compunit, process_full_type_unit): Use
 430         dwarf2_cu::reset_builder.
 431         (follow_die_offset): Record the ancestor CU if it is different
 432         from the followed DIE's CU.
 433         (follow_die_sig_1): Likewise.
 434
 435 2019-01-15  Tom Tromey  <tom@tromey.com>
 436
 437         * remote.c (class remote_state) <buf>: Now a char_vector.
 438         <buf_size>: Remove.
 439         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
 440         parameter.
 441         (remote_target::getpkt_or_notif_sane_1)
 442         (remote_target::getpkt_sane)
 443         (remote_target::getpkt_or_notif_sane): Likewise.
 444         (class remote_target) <putpkt>: New overload.
 445         (remote_target::read_frame): Change type of "buf_p".  Remove
 446         sizeof_p parameter.
 447         (packet_ok): New overload.
 448         (packet_check_result): New overload.
 449         Update all uses.
 450
 451 2019-01-14  Tom Tromey  <tom@tromey.com>
 452
 453         * remote-notif.c (handle_notification, remote_notif_ack)
 454         (remote_notif_parse): Make "buf" const.
 455         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
 456         const.
 457         (remote_notif_parse, remote_notif_ack, handle_notification):
 458         Likewise.
 459         * remote.c (remote_notif_stop_parse): Make "buf" const.
 460         (remote_target::remote_parse_stop_reply): Make "buf" const.
 461         (remote_notif_stop_ack): Make "buf" const.
 462
 463 2019-01-14  Tom Tromey  <tom@tromey.com>
 464
 465         * remote.c (remote_console_output): Make parameter const.
 466
 467 2019-01-14  Tom Tromey  <tom@tromey.com>
 468
 469         * target-debug.h (target_debug_print_signals): Constify.
 470         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
 471         * procfs.c (procfs_target::pass_signals): Update.
 472         * linux-nat.c (linux_nat_target::pass_signals): Update.
 473         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
 474         * target-delegates.c: Rebuild.
 475         * remote.c (remote_target::program_signals): Update.
 476         (remote_target::pass_signals): Update.
 477         * target.c (target_pass_signals): Constify argument.
 478         (target_program_signals): Likewise.
 479         * target.h (struct target_ops) <pass_signals, program_signals>:
 480         Constify argument.
 481         (target_pass_signals, target_program_signals): Constify argument.
 482
 483 2019-01-14  Tom Tromey  <tom@tromey.com>
 484
 485         PR tui/28819:
 486         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
 487
 488 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
 489
 490         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
 491         field.
 492         * rs6000-tdep.c: Include reggroups.h.
 493         (IS_V_ALIAS_PSEUDOREG): Define.
 494         (rs6000_register_name): Return names for the "vX" aliases.
 495         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
 496         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
 497         aliases.  Call default_register_reggroup_p for all other
 498         pseudo-registers.
 499         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
 500         New functions.
 501         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
 502         Handle "vX" aliases.
 503         (v_alias_pseudo_register_collect): New function.
 504         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
 505         (rs6000_gdbarch_init): Initialize "vX" aliases as
 506         pseudo-registers.  Restore registration of
 507         rs6000_pseudo_register_reggroup_p with
 508         set_tdesc_pseudo_register_reggroup_p.
 509
 510 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
 511
 512         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
 513         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
 514         set_gdbarch_num_pseudo_regs.
 515
 516 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 517
 518         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
 519         Remove arg prefixname, add do_set and do_show.
 520         Add member functions set_list and show_list.
 521         * cli/cli-style.c (class cli_style_option): Update accordingly.
 522         (style_set_list): Move to file scope.
 523         (style_show_list): Likewise.
 524         (set_style): Call help_list.
 525         (show_style): Call cmd_show_list.
 526         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
 527         Update to use the new macro.
 528
 529 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
 530
 531         * ada-lang.c (_initialize_ada_language): Expand the help text
 532         for the "catch exception" command.
 533
 534 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 535
 536         * symtab.c (matching_obj_sections): Initialize obj,
 537         declare it closer to its usage.
 538
 539 2019-01-10  Tom Tromey  <tom@tromey.com>
 540
 541         * thread-iter.h (inf_threads_iterator): Use next_iterator.
 542         (basic_inf_threads_range): Remove.
 543         (inf_threads_range, inf_non_exited_threads_range)
 544         (safe_inf_threads_range): Use next_adapter.
 545
 546 2019-01-10  Keith Seitz  <keiths@redhat.com>
 547
 548         PR gdb/23712
 549         PR symtab/23010
 550         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
 551         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
 552
 553 2019-01-10  Keith Seitz  <keiths@redhat.com>
 554
 555         PR gdb/23712
 556         PR symtab/23010
 557         * dictionary.c (pending_to_vector): Remove.
 558         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 559         Remove _1 suffix, replacing functions of the same name.  Update
 560         all callers.
 561         (dict_create_hashed, dict_create_hashed_expandable)
 562         (dict_create_linear, dict_create_linear_expandable, dict_free)
 563         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
 564         Make functions static.
 565
 566 2019-01-10  Keith Seitz  <keiths@redhat.com>
 567
 568         PR gdb/23712
 569         PR symtab/23010
 570         * dictionary.h (struct dictionary): Replace declaration with
 571         multidictionary.
 572         (dict_create_hashed, dict_create_hashed_expandable)
 573         (dict_create_linear, dict_create_linear_expandable)
 574         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
 575         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
 576         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
 577         taking multidictionary argument.
 578         [ALL_DICT_SYMBOLS]: Update for multidictionary.
 579         * block.h (struct block) <dict>: Change to multidictionary
 580         and rename `multidict'.
 581         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
 582         symmisc.c: Update all dictionary references to multidictionary.
 583
 584 2019-01-10  Keith Seitz  <keiths@redhat.com>
 585
 586         PR gdb/23712
 587         PR symtab/23010
 588         * dictionary.c: Include unordered_map.
 589         (pending_to_vector): New function.
 590         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
 591         Rewrite the non-"_1" functions to take vector instead
 592         of linked list.
 593         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
 594         "new" _1 versions of the same name.
 595         (multidictionary): Define.
 596         (std::hash<enum language): New definition.
 597         (collate_pending_symbols_by_language, mdict_create_hashed)
 598         (mdict_create_hashed_expandable, mdict_create_linear)
 599         (mdict_create_linear_expandable, mdict_free)
 600         (find_language_dictionary, create_new_language_dictionary)
 601         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
 602         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
 603         (mdict_size, mdict_empty): New functions.
 604         * dictionary.h (mdict_iterator): Define.
 605
 606 2019-01-10  Pedro Alves  <palves@redhat.com>
 607
 608         * breakpoint.c (read_uploaded_action)
 609         (create_tracepoint_from_upload): Adjust to use
 610         gdb::unique_xmalloc_ptr.
 611         * ctf.c (ctf_write_uploaded_tp):
 612         (SET_ARRAY_FIELD): Use emplace_back.
 613         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
 614         * tracefile-tfile.c (tfile_write_uploaded_tp):
 615         * tracepoint.c (parse_tracepoint_definition): Adjust to use
 616         gdb::unique_xmalloc_ptr.
 617         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
 618         at_string, cond_string, cmd_strings>: Replace char pointers
 619         with gdb::unique_xmalloc_ptr.
 620
 621 2019-01-10  Pedro Alves  <palves@redhat.com>
 622
 623         * solib-target.c (library_list_start_library): Don't xstrdup name.
 624
 625 2019-01-10  Pedro Alves  <palves@redhat.com>
 626
 627         * mdebugread.c (parse_partial_symbols): Use
 628         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
 629
 630 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 631
 632         * linux-fork.c (scoped_switch_fork_info)
 633         <~scoped_switch_fork_info>: Fix incorrect variable name.
 634
 635 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 636
 637         * linux-fork.c (scoped_switch_fork_info)
 638         <scoped_switch_fork_info>: Make explicit.
 639         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
 640
 641 2019-01-10  Tom Tromey  <tom@tromey.com>
 642
 643         * objfiles.h (objfile::reset_psymtabs): Update.
 644         * objfiles.c (objfile::objfile): Update.
 645         * psymtab.h (psymtab_storage::obstack): Update.
 646         (psymtab_storage::m_obstack): Use gdb::optional.
 647         (class psymtab_storage): Update comment.  Remove objfile
 648         parameter.
 649         * psymtab.c (psymtab_storage::psymtab_storage): Update.
 650
 651 2019-01-10  Tom Tromey  <tom@tromey.com>
 652
 653         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
 654         <free_psymtabs>: Now private.
 655         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
 656         (allocate_psymtab): Use new method.
 657
 658 2019-01-10  Tom Tromey  <tom@tromey.com>
 659
 660         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
 661         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
 662         * mdebugread.c (parse_partial_symbols): Use
 663         allocate_dependencies.
 664         * dwarf2read.c (dwarf2_create_include_psymtab): Use
 665         allocate_dependencies.
 666         (process_psymtab_comp_unit_reader)
 667         (build_type_psymtab_dependencies): Likewise.
 668         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
 669
 670 2019-01-10  Tom Tromey  <tom@tromey.com>
 671
 672         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
 673         PSYMBOL_SET_LANGUAGE.
 674         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
 675
 676 2019-01-10  Tom Tromey  <tom@tromey.com>
 677
 678         * psymtab.h (psymtab_storage::obstack): New method.
 679         <m_obstack>: Rename from obstack; now private.
 680         * psymtab.c (psymtab_storage): Update.
 681         * dwarf2read.c (create_addrmap_from_index)
 682         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
 683         Update.
 684
 685 2019-01-10  Tom Tromey  <tom@tromey.com>
 686
 687         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
 688         * objfiles.h (objfile::reset_psymtabs): New method.
 689
 690 2019-01-10  Tom Tromey  <tom@tromey.com>
 691
 692         * symmisc.c (print_symbol_bcache_statistics): Update.
 693         (print_objfile_statistics): Update.
 694         * symfile.c (reread_symbols): Update.
 695         * psymtab.h (class psymtab_storage): New.
 696         * psymtab.c (psymtab_storage): New constructor.
 697         (~psymtab_storage): New destructor.
 698         (require_partial_symbols): Update.
 699         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
 700         (find_pc_sect_psymtab, find_pc_sect_psymbol)
 701         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
 702         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
 703         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
 704         (start_psymtab_common, end_psymtab_common)
 705         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
 706         (allocate_psymtab): Update.
 707         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
 708         Update.
 709         (dump_psymtab_addrmap, maintenance_print_psymbols)
 710         (maintenance_check_psymtabs): Update.
 711         (class objfile_psymtabs): Move to objfiles.h.
 712         * psympriv.h (discard_psymtab): Now inline.
 713         (psymtab_discarder::psymtab_discarder): Update.
 714         (psymtab_discarder::~psymtab_discarder): Update.
 715         (ALL_OBJFILE_PSYMTABS): Rewrite.
 716         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
 717         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
 718         Remove fields.
 719         <partial_symtabs>: New field.
 720         (class objfile_psymtabs): Move from psymtab.h.  Update.
 721         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
 722         psymbol_cache.
 723         (objfile::~objfile): Don't destroy psymbol_cache.
 724         * mdebugread.c (parse_partial_symbols): Update.
 725         * dwarf2read.c (create_addrmap_from_index)
 726         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 727         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
 728         (add_partial_subprogram, dwarf2_ranges_read): Update.
 729         * dwarf-index-write.c (write_address_map)
 730         (write_one_signatured_type, recursively_write_psymbols)
 731         (class debug_names, class debug_names, write_psymtabs_to_index):
 732         Update.
 733
 734 2019-01-10  Tom Tromey  <tom@tromey.com>
 735
 736         * symtab.h (SYMBOL_SET_NAMES): Update.
 737         (symbol_set_names): Update.
 738         (MSYMBOL_SET_NAMES): Update.
 739         * symtab.c (symbol_set_names): Change argument to be an
 740         objfile_per_bfd_storage.
 741         * psymtab.c (add_psymbol_to_bcache): Update.
 742         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
 743
 744 2019-01-10  Tom Tromey  <tom@tromey.com>
 745
 746         * symtab.c (create_demangled_names_hash): Change argument to be an
 747         objfile_per_bfd_storage.
 748         (symbol_set_names): Update.
 749
 750 2019-01-10  Tom Tromey  <tom@tromey.com>
 751
 752         * xcoffread.c (xcoff_initial_scan): Unconditionally call
 753         init_psymbol_list.
 754         * psymtab.c (init_psymbol_list): Do nothing if already called.
 755         * psympriv.h (init_psymbol_list): Add comment.
 756         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
 757         init_psymbol_list.
 758         * dbxread.c (dbx_symfile_read): Unconditionally call
 759         init_psymbol_list.
 760
 761 2019-01-10  Tom Tromey  <tom@tromey.com>
 762
 763         * xcoffread.c (scan_xcoff_symtab): Update.
 764         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
 765         "where".
 766         * mdebugread.c (parse_partial_symbols)
 767         (handle_psymbol_enumerators): Update.
 768         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
 769         * dbxread.c (read_dbx_symtab): Update.
 770         * psympriv.h (psymbol_placement): New enum.
 771         (add_psymbol_to_list): Update.
 772
 773 2019-01-10  Tom Tromey  <tom@tromey.com>
 774
 775         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
 776         static_psymbols parameters.
 777         (scan_xcoff_symtab): Update.
 778         * psymtab.c (start_psymtab_common): Remove global_psymbols and
 779         static_psymbols parameters.
 780         * psympriv.h (start_psymtab_common): Update.
 781         * mdebugread.c (parse_partial_symbols): Update.
 782         * dwarf2read.c (create_partial_symtab): Update.
 783         * dbxread.c (read_dbx_symtab): Update.
 784         (start_psymtab): Remove global_psymbols and static_psymbols
 785         parameters.
 786
 787 2019-01-10  Tom Tromey  <tom@tromey.com>
 788
 789         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
 790         * psymtab.c (allocate_psymtab): Add comment.
 791         * psympriv.h (allocate_psymtab): Add comment.
 792         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
 793         initializations.
 794         * dbxread.c (dbx_end_psymtab): Remove some initializations.
 795
 796 2019-01-10  Tom Tromey  <tom@tromey.com>
 797
 798         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 799         Don't declare.
 800         * mipsread.c: Include mdebugread.h.
 801         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
 802         Declare.
 803         * elfread.c: Include mdebugread.h.
 804
 805 2019-01-09  Tom Tromey  <tom@tromey.com>
 806
 807         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
 808         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
 809         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
 810         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
 811         (psym_lookup_symbol, psym_find_last_source_symtab)
 812         (psym_forget_cached_source_info, psym_print_stats)
 813         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
 814         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
 815         (psym_map_matching_symbols, psym_expand_symtabs_matching)
 816         (psym_find_compunit_symtab_by_address)
 817         (maintenance_print_psymbols, maintenance_info_psymtabs)
 818         (maintenance_check_psymtabs): Use ranged for.
 819         * psymtab.h (class objfile_psymtabs): New.
 820         (require_partial_symbols): Return objfile_psymtabs.
 821         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
 822
 823 2019-01-09  Tom Tromey  <tom@tromey.com>
 824
 825         * symfile.c (overlay_invalidate_all, find_pc_overlay)
 826         (find_pc_mapped_section, list_overlays_command)
 827         (map_overlay_command, unmap_overlay_command)
 828         (simple_overlay_update): Use all_objfiles.
 829         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
 830         * printcmd.c (info_symbol_command): Use all_objfiles.
 831         * objfiles.h (ALL_OBJSECTIONS): Remove.
 832         * maint.c (maintenance_translate_address): Use all_objfiles.
 833         * gcore.c (gcore_create_callback): Use all_objfiles.
 834         (objfile_find_memory_regions): Likewise.
 835
 836 2019-01-09  Tom Tromey  <tom@tromey.com>
 837
 838         * symtab.c (find_line_symtab, info_sources_command)
 839         (make_source_files_completion_list): Use objfile_compunits.
 840         * source.c (select_source_symtab): Use objfile_compunits.
 841         * objfiles.h (struct objfile): Update comment.
 842         (ALL_OBJFILES): Remove.
 843         (ALL_FILETABS): Remove.
 844         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
 845         objfile_compunits.
 846
 847 2019-01-09  Tom Tromey  <tom@tromey.com>
 848
 849         * symmisc.c (print_objfile_statistics, dump_objfile)
 850         (maintenance_print_symbols): Use compunit_filetabs.
 851         * source.c (forget_cached_source_info_for_objfile): Use
 852         compunit_filetabs.
 853         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
 854         (ALL_FILETABS): Use compunit_filetabs.
 855         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
 856         * coffread.c (coff_symtab_read): Use compunit_filetabs.
 857
 858 2019-01-09  Tom Tromey  <tom@tromey.com>
 859
 860         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
 861         (compunit_filetabs): New.
 862         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
 863         compunit_filetabs.
 864         (info_sources_command, make_source_files_completion_list): Remove
 865         declaration.
 866         * symmisc.c (print_objfile_statistics, dump_objfile)
 867         (maintenance_print_symbols): Remove declaration.
 868         (maintenance_info_symtabs): Use compunit_filetabs.
 869         (maintenance_info_line_tables): Likewise.
 870         * source.c (select_source_symtab): Change local variable name.
 871         (forget_cached_source_info_for_objfile): Remove declaration.
 872         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
 873         * objfiles.c (objfile_relocate1): Remove declaration.
 874         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 875         declaration.
 876         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
 877         * coffread.c (coff_symtab_read): Remove declaration.
 878         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
 879         compunit_filetabs.
 880
 881 2019-01-09  Tom Tromey  <tom@tromey.com>
 882
 883         * symtab.c (lookup_objfile_from_block)
 884         (find_pc_sect_compunit_symtab, search_symbols)
 885         (default_collect_symbol_completion_matches_break_on): Use
 886         objfile_compunits.
 887         * objfiles.h (ALL_COMPUNITS): Remove.
 888         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
 889         * cp-support.c (add_symbol_overload_list_qualified): Use
 890         objfile_compunits.
 891         * ada-lang.c (ada_collect_symbol_completion_matches)
 892         (ada_add_global_exceptions): Use objfile_compunits.
 893
 894 2019-01-09  Tom Tromey  <tom@tromey.com>
 895
 896         * source.c (select_source_symtab)
 897         (forget_cached_source_info_for_objfile): Remove declaration.
 898         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
 899         declaration.
 900         * maint.c (count_symtabs_and_blocks): Remove declaration.
 901         * cp-support.c (add_symbol_overload_list_qualified): Remove
 902         declaration.
 903         * coffread.c (coff_symtab_read): Remove declaration.
 904         * symtab.c (lookup_symbol_in_objfile_symtabs)
 905         (basic_lookup_transparent_type_1): Use objfile_compunits.
 906         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
 907         (info_sources_command, search_symbols)
 908         (default_collect_symbol_completion_matches_break_on)
 909         (make_source_files_completion_list): Remove declaration.
 910         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
 911         (ada_collect_symbol_completion_matches)
 912         (ada_add_global_exceptions): Remove declaration.
 913         * linespec.c (iterate_over_all_matching_symtabs): Use
 914         objfile_compunits.
 915         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
 916         (class objfile_compunits): New.
 917         (ALL_COMPUNITS): Use objfile_compunits.
 918         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
 919         (maintenance_check_symtabs, maintenance_info_line_tables): Use
 920         objfile_compunits.
 921         * objfiles.c (objfile_relocate1): Use objfile_compunits.
 922
 923 2019-01-09  Tom Tromey  <tom@tromey.com>
 924
 925         * symtab.c (search_symbols)
 926         (default_collect_symbol_completion_matches_break_on): Use
 927         objfile_msymbols.
 928         * ada-lang.c (ada_lookup_simple_minsym)
 929         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
 930         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
 931         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
 932         objfile_msymbols.
 933         * coffread.c (coff_symfile_read): Use objfile_msymbols.
 934         * symmisc.c (dump_msymbols): Use objfile_msymbols.
 935         * objc-lang.c (find_methods): Use objfile_msymbols.
 936         (info_selectors_command, info_classes_command): Likewise.
 937         * stabsread.c (scan_file_globals): Use objfile_msymbols.
 938         * objfiles.h (class objfile_msymbols): New.
 939         (ALL_OBJFILE_MSYMBOLS): Remove.
 940         (ALL_MSYMBOLS): Remove.
 941
 942 2019-01-09  Tom Tromey  <tom@tromey.com>
 943
 944         * common/next-iterator.h (next_adapter): Add Iterator template
 945         parameter.
 946         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
 947         (class all_objfiles_safe): New.
 948         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
 949         * objfiles.c (put_objfile_before): Update comment.
 950         (add_separate_debug_objfile): Likewise.
 951         (free_all_objfiles): Use all_objfiles_safe.
 952         (objfile_purge_solibs): Likewise.
 953
 954 2019-01-09  Tom Tromey  <tom@tromey.com>
 955
 956         * symtab.c (iterate_over_symtabs, matching_obj_sections)
 957         (expand_symtab_containing_pc, lookup_static_symbol)
 958         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
 959         (find_symbol_at_address, find_line_symtab, find_main_name): Use
 960         all_objfiles.
 961         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
 962         * breakpoint.c (create_overlay_event_breakpoint)
 963         (create_longjmp_master_breakpoint)
 964         (create_std_terminate_master_breakpoint)
 965         (create_exception_master_breakpoint): Use all_objfiles.
 966         * linux-thread-db.c (try_thread_db_load_from_pdir)
 967         (has_libpthread): Use all_objfiles.
 968         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
 969         * linespec.c (iterate_over_all_matching_symtabs)
 970         (search_minsyms_for_name): Use all_objfiles.
 971         * maint.c (maintenance_info_sections): Use all_objfiles.
 972         * main.c (captured_main_1): Use all_objfiles.
 973         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
 974         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
 975         * guile/scm-pretty-print.c
 976         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
 977         * solib-spu.c (append_ocl_sos): Use all_objfiles.
 978         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
 979         (maintenance_print_msymbols): Use all_objfiles.
 980         * source.c (select_source_symtab): Use all_objfiles.
 981         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
 982         * symfile.c (remove_symbol_file_command)
 983         (expand_symtabs_matching, map_symbol_filenames): Use
 984         all_objfiles.
 985         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
 986         all_objfiles.
 987         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
 988         * objc-lang.c (find_methods): Use all_objfiles.
 989         * objfiles.c (have_partial_symbols, have_full_symbols)
 990         (have_minimal_symbols, qsort_cmp)
 991         (default_iterate_over_objfiles_in_search_order): Use
 992         all_objfiles.
 993         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
 994         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
 995         (maintenance_check_psymtabs): Use all_objfiles.
 996         (ALL_PSYMTABS): Remove.
 997         * compile/compile-object-run.c (do_module_cleanup): Use
 998         all_objfiles.
 999         * blockframe.c (find_pc_partial_function): Use all_objfiles.
1000         * cp-support.c (add_symbol_overload_list_qualified): Use
1001         all_objfiles.
1002         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
1003         Use all_objfiles.
1004         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
1005         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
1006         all_objfiles.
1007         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
1008         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
1009         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
1010         Uses all_objfiles.
1011         * solib.c (solib_read_symbols): Use all_objfiles
1012
1013 2019-01-09  Tom Tromey  <tom@tromey.com>
1014
1015         * probe.c (parse_probes_in_pspace): Use all_objfiles.
1016         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
1017         all_objfiles.
1018         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
1019         * symmisc.c (print_symbol_bcache_statistics)
1020         (print_objfile_statistics, maintenance_print_objfiles)
1021         (maintenance_info_symtabs, maintenance_check_symtabs)
1022         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
1023         all_objfiles.
1024         * source.c (forget_cached_source_info): Use all_objfiles.
1025         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
1026         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
1027         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
1028         * objfiles.c (update_section_map): Use all_objfiles.
1029         (shared_objfile_contains_address_p): Likewise.
1030         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
1031         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
1032
1033 2019-01-09  Tom Tromey  <tom@tromey.com>
1034
1035         * common/next-iterator.h: New file.
1036         * objfiles.h (class all_objfiles): New.
1037         (struct objfile_iterator): New.
1038
1039 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1040
1041         * NEWS: Move the description of the changed "frame", "select-frame",
1042          and "info frame" commands to the Changed commands section.
1043
1044 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
1045
1046         * gdbtypes.c (check_stub_method_group): Remove handling of old
1047         mangling schemes.
1048         * linespec.c (find_methods): Likewise.
1049         * stabsread.c (read_member_functions): Likewise.
1050         * valops.c (search_struct_method): Likewise.
1051         (value_struct_elt_for_reference): Likewise.
1052         * NEWS: Mention this change.
1053
1054 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
1055
1056         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
1057         print_source_lines.
1058         * source.c (print_source_lines_base): Update line number check.
1059         (print_source_lines): New function.
1060         (source_lines_range::source_lines_range): New function.
1061         * source.h (class source_lines_range): New class.
1062         (print_source_lines): New declaration.
1063
1064 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1065
1066         * linespec.c (linespec_state_destructor): Free self->canonical_names.
1067
1068 2019-01-08  Tom Tromey  <tom@tromey.com>
1069             Simon Marchi  <simon.marchi@ericsson.com>
1070
1071         PR gdb/24060
1072         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
1073         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
1074         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1075         * f-exp.y (DOLLAR_VARIABLE): Likewise.
1076         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
1077         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
1078
1079 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1080
1081         * source.c (select_source_symtab): Move header comment to
1082         declaration in source.h.
1083         (forget_cached_source_info_for_objfile): Likewise.
1084         (forget_cached_source_info): Likewise.
1085         (identify_source_line): Likewise.
1086         * source.h (identify_source_line): Move declaration from symtab.h
1087         and add comment from source.c
1088         (print_source_lines): Likewise.
1089         (forget_cached_source_info_for_objfile): Likewise.
1090         (forget_cached_source_info): Likewise.
1091         (select_source_symtab): Likewise.
1092         (enum print_source_lines_flag): Move definition from symtab.h.
1093         * symtab.h (identify_source_line): Move declaration to source.h.
1094         (print_source_lines): Likewise.
1095         (forget_cached_source_info_for_objfile): Likewise.
1096         (forget_cached_source_info): Likewise.
1097         (select_source_symtab): Likewise.
1098         (enum print_source_lines_flag): Move definition to source.h.
1099         * tui/tui-hooks.c: Add 'source.h' include.
1100
1101 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1102
1103         * source.c (print_source_lines_base): Handle requests to print
1104         reverse line number sequences, and guard against empty lines
1105         string.
1106
1107 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1108
1109         * source.c (print_source_lines_base): Fix skip of '\r' if next
1110         character is '\n'.
1111
1112 2019-01-06  Tom Tromey  <tom@tromey.com>
1113
1114         * c-exp.y (struct c_parse_state) <macro_original_text,
1115         expansion_obstack>: New member.
1116         (macro_original_text, expansion_obstack): Remove globals.
1117         (scan_macro_expansion, scanning_macro_expansion)
1118         (finished_macro_expansion): Update.
1119         (scan_macro_cleanup): Remove.
1120         (yylex, c_parse): Update.
1121
1122 2019-01-06  Tom Tromey  <tom@tromey.com>
1123
1124         * c-exp.y (struct c_parse_state) <strings>: New member.
1125         (operator_stoken): Update.
1126
1127 2019-01-06  Tom Tromey  <tom@tromey.com>
1128
1129         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
1130         (union type_stack_elt) <typelist_val>: Now a pointer to
1131         std::vector.
1132         (type_stack_cleanup): Don't declare.
1133         (push_typelist): Update.
1134         * parse.c (pop_typelist): Return a std::vector.
1135         (push_typelist): Take a std::vector.
1136         (follow_types): Update.  Do not free args.
1137         (type_stack_cleanup): Remove.
1138         * c-exp.y (struct c_parse_state): New.
1139         (cpstate): New global.
1140         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
1141         (nonempty_typelist): Update.
1142         (func_mod): Create a new vector.
1143         (c_parse): Create a c_parse_state.
1144         (check_parameter_typelist): Do not delete params.
1145         (function_method): Update.  Do not delete type_list.
1146
1147 2019-01-06  Tom Tromey  <tom@tromey.com>
1148
1149         PR gdb/28155:
1150         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
1151         check_typedef.
1152         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
1153         (print_return_value): Likewise.
1154
1155 2019-01-05  Tom Tromey  <tom@tromey.com>
1156
1157         * contrib/cleanup_check.py: Remove.
1158         * contrib/gcc-with-excheck: Remove.
1159         * contrib/exsummary.py: Remove.
1160         * contrib/excheck.py: Remove.
1161
1162 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
1163
1164         * thread.c (delete_thread_1): Add gdb_assert that THR is not
1165         NULL. Initialize tpprev to NULL instead of assigning it
1166         to NULL on the next statement.
1167         * windows-nat.c (windows_delete_thread): Remove check for
1168         main_thread_id before printing thread exit notifications.
1169         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
1170         Remove thread ID check against main_thread_id.
1171         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
1172         windows_delete_thread.
1173         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
1174
1175 2019-01-04  Tom Tromey  <tom@tromey.com>
1176
1177         * compile/compile.c (_initialize_compile): Use upper case for
1178         metasyntactic variables.
1179         * symmisc.c (_initialize_symmisc): Use upper case for
1180         metasyntactic variables.
1181         * psymtab.c (_initialize_psymtab): Use upper case for
1182         metasyntactic variables.
1183         * demangle.c (demangle_command): Use upper case for metasyntactic
1184         variables.
1185         (_initialize_demangler): Likewise.
1186         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
1187         variables.
1188
1189 2019-01-03  Tom Tromey  <tom@tromey.com>
1190
1191         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
1192
1193 2019-01-03  Tom Tromey  <tom@tromey.com>
1194
1195         * python/py-symtab.c (salpy_str): Update.
1196         (struct salpy_sal_object) <symtab>: Now a PyObject.
1197         (salpy_dealloc): Update.
1198         (del_objfile_sal): Use gdbpy_ref.
1199
1200 2019-01-03  Tom Tromey  <tom@tromey.com>
1201
1202         * python/py-type.c (convert_field): Use new_reference.  Return
1203         gdbpy_ref.
1204         (make_fielditem): Return gdbpy_ref.
1205         (typy_fields): Update.
1206         (typy_getitem): Update.
1207         (field_name): Return gdbpy_ref.  Use new_reference.
1208         (typy_iterator_iternext): Update.
1209
1210 2019-01-03  Tom Tromey  <tom@tromey.com>
1211
1212         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
1213
1214 2019-01-03  Tom Tromey  <tom@tromey.com>
1215
1216         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
1217         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
1218         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
1219         (pspy_set_frame_filters, pspy_set_frame_unwinders)
1220         (pspy_set_type_printers): Likewise.
1221         * python/py-function.c (fnpy_init): Use gdbpy_ref.
1222         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
1223         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
1224         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
1225         (objfpy_set_type_printers): Likewise.
1226
1227 2019-01-03  Tom Tromey  <tom@tromey.com>
1228
1229         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
1230         (gdbpy_print_stack): Use gdbpy_err_fetch.
1231         * python/python-internal.h (class gdbpy_err_fetch): New class.
1232         (class gdbpy_enter) <m_error_type, m_error_value,
1233         m_error_traceback>: Remove.
1234         <m_error>: New member.
1235         (gdbpy_exception_to_string): Don't declare.
1236         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
1237         * python/py-value.c (convert_value_from_python): Use
1238         gdbpy_err_fetch.
1239         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
1240         gdbpy_exception_to_string.
1241         (gdbpy_handle_exception): Use gdbpy_err_fetch.
1242         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
1243         gdbpy_err_fetch.
1244
1245 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1246
1247         * linux-nat.c (delete_lwp_cleanup): Delete.
1248         (struct lwp_deleter): New struct.
1249         (lwp_info_up): New typedef.
1250         (linux_nat_target::follow_fork): Delete cleanup, and make use of
1251         lwp_info_up.
1252
1253 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1254
1255         * linux-fork.c (class scoped_switch_fork_info): New class.
1256         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
1257
1258 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1259
1260         * valops.c (find_overload_match): Remove use of null_cleanup, and
1261         calls to do_cleanups.
1262
1263 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * compile/compile-cplus-types.c
1266         (compile_cplus_instance::decl_name): Handle changes to
1267         cp_func_name.
1268         * cp-support.c (cp_func_name): Update header comment, update
1269         return type.
1270         * cp-support.h (cp_func_name): Update return type in declaration.
1271         * valops.c (find_overload_match): Move temp_func local to top
1272         level of function and change its type.  Use temp_func to hold and
1273         delete temporary string obtained from cp_func_name.
1274
1275 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
1276
1277         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
1278         gdb::char_vector, remove cleanup, and update uses of `msg`.
1279
1280 2019-01-03  Jim Wilson  <jimw@sifive.com>
1281
1282         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
1283
1284 2019-01-02  Tom Tromey  <tom@tromey.com>
1285
1286         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
1287         (tdesc_parse_xml): Remove cleanups.
1288         * target-descriptions.h (make_cleanup_free_target_description):
1289         Don't declare.
1290         (target_desc_deleter): New struct.
1291         (target_desc_up): New typedef.
1292         * target-descriptions.c (target_desc_deleter::operator()): Rename
1293         from free_target_description.
1294         (make_cleanup_free_target_description): Remove.
1295
1296 2019-01-02  Tom Tromey  <tom@tromey.com>
1297
1298         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
1299         constructor, destructor.
1300         (linespec_parser): Remove typedef.
1301         (~linespec_parser): Rename from linespec_parser_delete.
1302         (linespec_lex_to_end, linespec_complete_label)
1303         (linespec_complete): Update.
1304         (decode_line_full): Remove cleanups.
1305         (decode_line_1): Update.
1306
1307 2019-01-02  Tom Tromey  <tom@tromey.com>
1308
1309         * python/python-internal.h (inferior_to_inferior_object): Change
1310         return type.
1311         * python/py-exitedevent.c (create_exited_event_object): Update.
1312         * python/py-inferior.c (inferior_to_inferior_object): Return
1313         gdbpy_ref.
1314         (python_new_inferior, python_inferior_deleted)
1315         (thread_to_thread_object, delete_thread_object)
1316         (build_inferior_list, gdbpy_selected_inferior): Update.
1317         * python/py-infthread.c (create_thread_object): Update.  Also fail
1318         if inferior_to_inferior_object fails.
1319
1320 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
1321
1322         * inferior.h (class inferior) <displaced_step_state>: New field.
1323         * infrun.h (struct displaced_step_state): Move here from
1324         infrun.c.  Initialize fields, add constructor.
1325         <inf>: Remove field.
1326         <reset>: New method.
1327         * infrun.c (struct displaced_step_inferior_state): Move to
1328         infrun.h.
1329         (displaced_step_inferior_states): Remove.
1330         (get_displaced_stepping_state): Adust.
1331         (displaced_step_in_progress_any_inferior): Adjust.
1332         (displaced_step_in_progress_thread): Adjust.
1333         (displaced_step_in_progress): Adjust.
1334         (add_displaced_stepping_state): Remove.
1335         (get_displaced_step_closure_by_addr): Adjust.
1336         (remove_displaced_stepping_state): Remove.
1337         (infrun_inferior_exit): Call displaced_step_state.reset.
1338         (use_displaced_stepping): Don't check for NULL.
1339         (displaced_step_prepare_throw): Call
1340         get_displaced_stepping_state.
1341         (displaced_step_fixup): Don't check for NULL.
1342         (prepare_for_detach): Don't check for NULL.
1343
1344 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1345
1346         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
1347          in case of call that did not complete.
1348
1349 2019-01-02  Andrey Utkin  <autkin@undo.io>
1350
1351         * symfile.c (find_separate_debug_file): Fix search of debug files for
1352         remote debuggee.
1353
1354 2019-01-02  Tom Tromey  <tom@tromey.com>
1355
1356         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
1357         indentation.
1358         * python/py-frame.c (frapy_older): Remove cast.
1359         (frapy_newer): Likewise.
1360         * python/py-breakpoint.c (local_setattro): Remove cast.
1361         * python/py-arch.c (archpy_name): Remove local variable.
1362         * python/py-type.c (gdbpy_lookup_type): Remove cast.
1363
1364 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
1365
1366         * unittests/basic_string_view/element_access/char/empty.cc:
1367         Fix year range in copyright header.
1368
1369 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1370
1371         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
1372         Delete.
1373         <operator==>: Update with for removed field.
1374         <hash>: Likewise.
1375         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
1376         <isa_features>: ...this.
1377         <abi_features>: New field.
1378         (riscv_isa_flen): Update comment.
1379         (riscv_abi_xlen): New declaration.
1380         (riscv_abi_flen): New declaration.
1381         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
1382         isa_features.
1383         (riscv_abi_xlen): New function.
1384         (riscv_isa_flen): Update to get answer from isa_features.
1385         (riscv_abi_flen): New function.
1386         (riscv_has_fp_abi): Update to get answer from abi_features.
1387         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
1388         xlen and flen.
1389         (riscv_call_info) <xlen, flen>: Update comment.
1390         (riscv_call_arg_struct): Remove invalid assertions
1391         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
1392         is removed.
1393         (riscv_gdbarch_init): Gather isa features and abi features
1394         separately, ensure both match on the gdbarch when reusing an old
1395         gdbarch.  Relax an error check to allow 32-bit abi float to run on
1396         a target with 64-bit float hardware.
1397
1398 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1399
1400         * source.c (search_command_helper): Stop reverse search
1401         when line 1 has been searched.
1402
1403 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1404
1405         * record-full.c (record_full_base_target::close): Rewrite
1406         record_full_core_buf_list free logic.
1407
1408 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1409
1410         * break-catch-syscall.c (print_one_catch_syscall): xfree
1411         the last text.
1412
1413 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1414
1415         * top.c (print_gdb_version): Update Copyright year in version
1416         message.
1417
1418 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
1419
1420         Update copyright year range in all GDB files.
1421
1422 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
1423
1424         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
1425
1426 For older changes see ChangeLog-2018.
1427 \f
1428 Local Variables:
1429 mode: change-log
1430 left-margin: 8
1431 fill-column: 74
1432 version-control: never
1433 coding: utf-8
1434 End:
1435