gdb/ChangeLog

   1 2019-06-13  Pedro Alves  <palves@redhat.com>
   2
   3         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
   4         (validate_flags_qcs): New.
   5         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
   6         (validate_flags_qcs): Declare.
   7         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
   8         (make_frame_apply_options_def_group): New.
   9         (frame_apply_command_count): Process options with
  10         gdb::option::process_options.
  11         (frame_apply_completer): New.
  12         (frame_apply_level_completer, frame_apply_all_completer)
  13         (frame_apply_completer): New.
  14         (_initialize_stack): Update help of "frame apply", "frame apply
  15         level", "frame apply all" and "faas" to mention supported options
  16         and install command completers.
  17         * stack.h (frame_apply_all_completer): Declare.
  18         * thread.c: Include "stack.h".
  19         (tfaas_command): Add "--".
  20         (_initialize_thread): Update help "tfaas" to mention supported
  21         options and install command completer.
  22
  23 2019-06-13  Pedro Alves  <palves@redhat.com>
  24
  25         * completer.c (complete_nested_command_line): New.
  26         (gdb_completion_word_break_characters_throw): Add assertion.
  27         * completer.h (complete_nested_command_line): Declare.
  28
  29 2019-06-13  Pedro Alves  <palves@redhat.com>
  30
  31         * stack.c (parse_backtrace_qualifiers): New.
  32         (backtrace_command): Use it.
  33         (backtrace_command_completer): Complete on qualifiers.
  34
  35 2019-06-13  Pedro Alves  <palves@redhat.com>
  36
  37         * frame.c: Include "cli/cli-option.h.
  38         (user_set_backtrace_options): New.
  39         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
  40         Delete.
  41         (get_prev_frame): Adjust.
  42         (boolean_option_def, uinteger_option_def)
  43         (set_backtrace_option_defs): New.
  44         (_initialize_frame): Adjust and use
  45         gdb::option::add_setshow_cmds_for_options to install "set
  46         backtrace past-main" and "set backtrace past-entry".
  47         * frame.h: Include "cli/cli-option.h".
  48         (struct frame_print_options): Forward declare.
  49         (print_frame_arguments_all, print_frame_arguments_scalars)
  50         (print_frame_arguments_none): Declare.
  51         (print_entry_values): Delete declaration.
  52         (struct frame_print_options, user_frame_print_options): New.
  53         (struct set_backtrace_options): New.
  54         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
  55         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
  56         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
  57         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
  58         (list_args_or_locals): Add frame_print_options parameter.
  59         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  60         * python/py-framefilter.c (enumerate_args): Pass down
  61         USER_FRAME_PRINT_OPTIONS.
  62         * stack.c: Include "cli/cli-option.h".
  63         (print_frame_arguments_all, print_frame_arguments_scalars)
  64         (print_frame_arguments_none): Declare.
  65         (print_raw_frame_arguments, print_entry_values): Delete.
  66         (user_frame_print_options): New.
  67         (boolean_option_def, enum_option_def, frame_print_option_defs):
  68         New.
  69         (struct backtrace_cmd_options): New.
  70         (bt_flag_option_def): New.
  71         (backtrace_command_option_defs): New.
  72         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
  73         (print_frame_arg, read_frame_arg, print_frame_args)
  74         (print_frame_info, print_frame): Add frame_print_options parameter
  75         and use it.
  76         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
  77         (backtrace_command_1): Add frame_print_options and
  78         backtrace_cmd_options parameters and use them.
  79         (make_backtrace_options_def_group): New.
  80         (backtrace_command): Process command options with
  81         gdb::option::process_options.
  82         (backtrace_command_completer): New.
  83         (_initialize_stack): Extend "backtrace"'s help to mention
  84         supported options.  Install completer for "backtrace".
  85         Install some settings commands with add_setshow_cmds_for_options.
  86
  87 2019-06-13  Pedro Alves  <palves@redhat.com>
  88
  89         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
  90         and that "set/show print raw frame-arguments" are now deprecated.
  91
  92         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
  93         command.
  94         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
  95         * stack.c (_initialize_stack): Install "set/show print
  96         raw-frame-arguments", and deprecate "set/show print raw
  97         frame-arguments".
  98         * valprint.c (_initialize_valprint): Deprecate "set/show print
  99         raw".
 100
 101 2019-06-13  Pedro Alves  <palves@redhat.com>
 102
 103         * compile/compile.c (struct compile_options): New.
 104         (compile_flag_option_def, compile_command_option_defs)
 105         (make_compile_options_def_group): New.
 106         (compile_file_command): Handle options with
 107         gdb::option::process_options.
 108         (compile_file_command_completer): New function.
 109         (compile_code_command): Handle options with
 110         gdb::option::process_options.
 111         (compile_code_command_completer): New function.
 112         (_initialize_compiler): Install completers for "compile code" and
 113         "compile file".  Mention available options in "compile code" and
 114         "compile code"'s help.
 115         * completer.c (advance_to_completion_word): New, factored out from
 116         ...
 117         (advance_to_expression_complete_word_point): ... this.
 118         (advance_to_filename_complete_word_point): New.
 119         * completer.h (advance_to_filename_complete_word_point): New
 120         declaration.
 121
 122 2019-06-13  Pedro Alves  <palves@redhat.com>
 123
 124         * compile/compile.c: Include "cli/cli-option.h".
 125         (compile_print_value): Scope data pointer is now a
 126         value_print_options pointer; adjust.
 127         (compile_print_command): Process options.  Scope data pointer is
 128         now a value_print_options pointer; adjust.
 129         (_initialize_compile): Update "compile print"'s help to include
 130         supported options.  Install a completer for "compile print".
 131         * cp-valprint.c (show_vtblprint, show_objectprint)
 132         (show_static_field_print): Delete.
 133         (_initialize_cp_valprint): Don't install "set print
 134         static-members", "set print vtbl", "set print object" here.
 135         * printcmd.c: Include "cli/cli-option.h" and
 136         "common/gdb_optional.h".
 137         (print_command_parse_format): Rework to fill in a
 138         value_print_options instead of a format_data.
 139         (print_value): Change parameter type from format_data pointer to
 140         value_print_options reference.  Adjust.
 141         (print_command_1): Process options.  Adjust to pass down a
 142         value_print_options.
 143         (print_command_completer): New.
 144         (_initialize_printcmd): Install print_command_completer as
 145         handle_brkchars completer for the "print" command.  Update
 146         "print"'s help to include supported options.
 147         * valprint.c: Include "cli/cli-option.h".
 148         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 149         here from cp-valprint.c.
 150         (boolean_option_def, uinteger_option_def)
 151         (value_print_option_defs, make_value_print_options_def_group):
 152         New.  Use gdb::option::add_setshow_cmds_for_options to install
 153         "set print elements", "set print null-stop", "set print repeats",
 154         "set print pretty", "set print union", "set print array", "set
 155         print address", "set print symbol", "set print array-indexes".
 156         * valprint.h: Include <string> and "cli/cli-option.h".
 157         (make_value_print_options_def_group): Declare.
 158         (print_value): Change parameter type from format_data pointer to
 159         value_print_options reference.
 160         (print_command_completer): Declare.
 161
 162 2019-06-13  Pedro Alves  <palves@redhat.com>
 163
 164         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 165         (COMMON_SFILES): Add maint-test-settings.c.
 166         * cli/cli-decode.c (boolean_enums): New global, factored out from
 167         ...
 168         (add_setshow_boolean_cmd): ... here.
 169         * cli/cli-decode.h (boolean_enums): Declare.
 170         * cli/cli-option.c: New file.
 171         * cli/cli-option.h: New file.
 172         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 173         factored out from ...
 174         (parse_cli_boolean_value(const char *)): ... this.
 175         (is_unlimited_literal): Change parameter type to pointer to
 176         pointer.  Adjust and advance ARG pointer.
 177         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 178         (parse_cli_var_enum): New, factored out from ...
 179         (do_set_command): ... this.  Adjust.
 180         * cli/cli-setshow.h (parse_cli_boolean_value)
 181         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 182         (parse_cli_var_enum): Declare.
 183         * cli/cli-utils.c: Include "cli/cli-option.h".
 184         (get_ulongest): New.
 185         * cli/cli-utils.h (get_ulongest): Declare.
 186         (check_for_argument): New overloads.
 187         * maint-test-options.c: New file.
 188
 189 2019-06-13  Pedro Alves  <palves@redhat.com>
 190
 191         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 192         parse a range if "-" is at the end of the string.
 193
 194 2019-06-13  Pedro Alves  <palves@redhat.com>
 195
 196         * cli/cli-setshow.c (parse_auto_binary_operation)
 197         (parse_cli_boolean_value): Don't allow "o".
 198
 199 2019-06-13  Pedro Alves  <palves@redhat.com>
 200
 201         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 202         * NEWS: Mention maint test-settings KIND.
 203         * maint-test-settings.c: New file.
 204
 205 2019-06-13  Pedro Alves  <palves@redhat.com>
 206
 207         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 208         completer.
 209         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 210         "set" completers.
 211
 212 2019-06-13  Pedro Alves  <palves@redhat.com>
 213
 214         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 215         after item.
 216
 217 2019-06-13  Pedro Alves  <palves@redhat.com>
 218
 219         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 220
 221 2019-06-13  Pedro Alves <palves@redhat.com>
 222
 223         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 224         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 225         call.
 226         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 227         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 228         calls.
 229         (check_for_argument): Skip spaces after argument.
 230
 231 2019-06-13  Pedro Alves  <palves@redhat.com>
 232
 233         * thread.c (thread_apply_command): Adjust TID parsing.
 234         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 235         detected before end of string.
 236         (tid_is_in_list): Error out if LIST is invalid.
 237
 238 2019-06-13  Pedro Alves  <palves@redhat.com>
 239
 240         * completer.c (complete_line_internal_1): Rewind completion word
 241         point.
 242         (completion_tracker::advance_custom_word_point_by): Change
 243         parameter type to int.
 244         * completer.h (completion_tracker::advance_custom_word_point_by):
 245         Likewise.
 246
 247 2019-06-13  Pedro Alves  <palves@redhat.com>
 248
 249         * completer.c (advance_to_completion_word): Handle delimiters.
 250
 251 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 252
 253         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 254
 255 2019-06-11  Tom Tromey  <tom@tromey.com>
 256
 257         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 258         (xmalloc_failed): Move to alloc.c.
 259         * alloc.c: New file.
 260         * Makefile.in (COMMON_SFILES): Add alloc.c.
 261
 262 2019-06-11  Tom Tromey  <tom@tromey.com>
 263
 264         * nat/linux-waitpid.c: Don't include server.h.
 265         (linux_debug): Remove.
 266         (my_waitpid): Update.
 267
 268 2019-06-11  Tom Tromey  <tromey@adacore.com>
 269
 270         * infcall.c (_initialize_infcall): Remove trailing newline from
 271         help.
 272         * user-regs.c (_initialize_user_regs): Remove trailing newline
 273         from help.
 274         * typeprint.c (_initialize_typeprint): Remove trailing newline
 275         from help.
 276         * reverse.c (_initialize_reverse): Remove trailing newlines from
 277         help.
 278         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 279         from help.
 280         * language.c (add_set_language_command): Remove trailing newline
 281         from help.
 282         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 283         help.
 284         * disasm.c (_initialize_disasm): Remove trailing newline from
 285         help.
 286         * top.c (init_main): Remove trailing newline from help.
 287         * interps.c (_initialize_interpreter): Remove trailing newline
 288         from help.
 289         * btrace.c (_initialize_btrace): Remove trailing newlines from
 290         help.
 291         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 292         from help.
 293         * python/python.c (_initialize_python): Remove trailing newline
 294         from help.
 295         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 296         help.
 297         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 298         from help.  Reformat some text.
 299         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 300         from help.
 301         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 302         newline from help.
 303
 304 2019-06-11  Tom Tromey  <tromey@adacore.com>
 305
 306         * darwin-nat.c (darwin_decode_exception_message)
 307         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 308
 309 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 310
 311         * valops.c (value_slice): Check for not allocated or not
 312         associated values.
 313
 314 2019-06-10  Tom de Vries  <tdevries@suse.de>
 315
 316         PR gdb/24618
 317         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 318         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 319         invalid.
 320
 321 2019-06-10  Tom de Vries  <tdevries@suse.de>
 322
 323         PR gdb/24611
 324         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 325         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 326
 327 2019-06-10  Tom de Vries  <tdevries@suse.de>
 328
 329         PR symtab/24545
 330         * symtab.c (struct demangled_name_entry): Add language field.
 331         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 332         static minimal symbol".  Set and use language field.
 333
 334 2019-06-10  Tom Tromey  <tromey@adacore.com>
 335
 336         * ada-lang.c (_initialize_ada_language): Update help text.
 337
 338 2019-06-10  Tom Tromey  <tromey@adacore.com>
 339
 340         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 341         with a newline.
 342         * guile/guile.c (handle_boot_error): Don't end warning with a
 343         newline.
 344         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 345         warning with a newline.
 346         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 347         newline.
 348         (s12z_frame_cache): Likewise.
 349         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 350         a newline.
 351         * solib-svr4.c (disable_probes_interface): Don't end warning with
 352         a newline.
 353         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 354         newline.
 355         * python/python.c (do_finish_initialization): Don't end warning
 356         with a newline.
 357
 358 2019-06-10  Tom Tromey  <tom@tromey.com>
 359
 360         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 361         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 362         gdbpy_enter.
 363
 364 2019-06-10  Tom Tromey  <tromey@adacore.com>
 365
 366         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 367         data.
 368         (elf_new_init): Don't call stabsread_new_init.
 369         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 370         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 371         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 372
 373 2019-06-10  Tom de Vries  <tdevries@suse.de>
 374
 375         PR symtab/16264
 376         PR symtab/24517
 377         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 378
 379 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 380
 381         * source.c (find_and_open_source): Also rewrite relative file
 382         names.
 383
 384 2019-04-26  Amos Bird  <amosbird@gmail.com>
 385
 386         * annotate.c (annotate_thread_exited): Add "thread-exited"
 387         annotation.
 388
 389 2019-06-06  Tom Tromey  <tromey@adacore.com>
 390
 391         * maint.h (class scoped_command_stats): Use
 392         DISABLE_COPY_AND_ASSIGN.
 393         <print_time>: New method.
 394         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 395         print_time.
 396         (scoped_command_stats::print_time): New method.
 397
 398 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 399
 400         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 401         instructions of lengths 6 or 8 bytes.
 402
 403 2019-06-04  Pedro Alves  <palves@redhat.com>
 404
 405         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 406
 407         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 408         * breakpoint.c (condition_completer): Likewise.
 409         * cli/cli-dump.c (scan_expression): Likewise.
 410         * common/filestuff.c (mkdir_recursive): Likewise.
 411         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 412         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 413         (gdb_abspath): Likewise.
 414         * compile/compile-cplus-types.c
 415         (compile_cplus_instance::decl_name): Likewise.
 416         * completer.c (complete_explicit_location):
 417         (signal_completer, reg_or_group_completer_1): Likewise.
 418         * cp-support.c (cp_remove_params_if_any): Likewise.
 419         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 420         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 421         * infcmd.c (strip_bg_char): Likewise.
 422         * linespec.c (copy_token_string): Likewise.
 423         * mi/mi-main.c (output_cores): Likewise.
 424         * psymtab.c (psymtab_search_name):
 425         * symfile.c (test_set_ext_lang_command): Likewise.
 426         * target.c (target_fileio_read_stralloc): Likewise.
 427         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 428         * value.c (complete_internalvar): Likewise.
 429
 430 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 431
 432         Add objfile property to gdb.Type.
 433         * NEWS: Mention Python API addition.
 434         * python/py-type.c (typy_get_objfile): New method.
 435
 436 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 437
 438         * NEWS: Mention the new set|show style [title|highlight].
 439         Mention changes to "show style", "help" and "apropos".
 440
 441 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 442
 443         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 444         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 445         instead of print_help_for_command.
 446         (print_doc_of_command): New function.
 447         (help_list): Add 'apropos -v word' suggestion.
 448         (print_help_for_command): Style the command name using title style.
 449         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 450         (_initialize_cli_cmds): Describe -v in apropos_command help.
 451
 452 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 453
 454         * cli/cli-style.h (cli_style_option): Add name in constructor,
 455         add m_name class member, add constructor with intensity,
 456         add name class function.
 457         (cli_style_option::add_setshow_commands): Remove name argument.
 458         (highlight_style, title_style): New styles.
 459         * cli/cli-style.c (do_show): New function that shows a style
 460         characteristic styling the style name with itself.
 461         (set_style_name): New function.
 462         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 463         Update all callers according to the changes in cli/cli-style.h.
 464         * utils.h (fputs_highlighted): New function.
 465         * utils.c (fputs_highlighted): Likewise.
 466
 467 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 468
 469         * NEWS: Mention new pipe command and new convenience variables.
 470
 471 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 472
 473         * cli/cli-cmds.c (pipe_command): New function.
 474         (_initialize_cli_cmds): Call add_com for pipe_command.
 475         Define | as an alias for pipe.
 476         (exit_status_set_internal_vars): New function.
 477         (shell_escape): Call exit_status_set_internal_vars.
 478         cli/cli-decode.c (find_command_name_length): Recognize | as
 479         a single character command.
 480
 481 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 482
 483         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 484         top.c (execute_command_to_ui_file): New function, mostly a copy
 485         of execute_command_to_string.
 486         (execute_command_to_string): Implement by calling
 487         execute_command_to_ui_file.
 488
 489 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 490
 491         * top.h (saved_command_line): Remove declaration.
 492         * top.c (previous_saved_command_line, previous_repeat_arguments):
 493         New variables.
 494         (saved_command_line): Make static, define together with other
 495         'repeat variables'.
 496         (dont_repeat): Clear repeat_arguments.
 497         (repeat_previous, get_saved_command_line, save_command_line):
 498         New functions.
 499         (gdb_init): Initialize saved_command_line
 500         and previous_saved_command_line.
 501         * main.c (captured_main_1): Remove saved_command_line initialization.
 502         * event-top.c (handle_line_of_input): Update to use
 503         the new 'repeat' related functions instead of direct access to
 504         saved_command_line.
 505         * command.h (repeat_previous, get_saved_command_line,
 506         save_command_line): New declarations.
 507         (dont_repeat): Add comment.
 508
 509 2019-05-30  Tom Tromey  <tromey@adacore.com>
 510
 511         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 512         Fix comment.
 513         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 514
 515 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 516
 517         PR cli/24587
 518         * completer.c (complete): Initialize variable word.
 519
 520 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 521
 522         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 523         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 524         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 525         'body' is NULL to the outter 'if', protecting the '!is_define'
 526         situation as well.
 527
 528 2019-05-29  Tom Tromey  <tromey@adacore.com>
 529
 530         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 531         (dwarf_unknown): New function.
 532         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 533         (dwarf_type_encoding_name): Use dwarf_unknown.
 534
 535 2019-05-29  Tom Tromey  <tromey@adacore.com>
 536
 537         PR c++/20020:
 538         * cp-valprint.c (cp_print_value_fields): Call
 539         cp_print_static_field inside "try".
 540
 541 2019-05-29  Tom Tromey  <tromey@adacore.com>
 542
 543         * inflow.c (struct terminal_info): Add default operator=.
 544         * configure: Rebuild.
 545         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 546         -Wdeprecated-copy-dtor, -Wredundant-move.
 547
 548 2019-05-29  Tom Tromey  <tromey@adacore.com>
 549
 550         * NEWS: Add entry.
 551         * infcmd.c (print_return_value_1): Handle finish_print
 552         option.
 553         (show_print_finish): New function.
 554         (_initialize_infcmd): Add "set/show print finish" commands.
 555         * valprint.c (user_print_options): Initialize new member.
 556         * valprint.h (struct value_print_options) <finish_print>: New
 557         member.
 558
 559 2019-05-28  Tom Tromey  <tromey@adacore.com>
 560
 561         * ada-lang.c (ada_remove_Xbn_suffix)
 562         (find_old_style_renaming_symbol)
 563         (parse_old_style_renaming): Remove.
 564         (ada_find_renaming_symbol): Don't call
 565         find_old_style_renaming_symbol.
 566         (ada_is_renaming_symbol): Rename from
 567         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 568         bool.  Now static.
 569         (ada_read_var_value): Update and simplify.
 570         * ada-exp.y (write_var_or_type): Remove old code.
 571
 572 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 573
 574         * event-top.c: Remove include comment.
 575         * inflow.c (class scoped_ignore_sigttou): Move from here...
 576         * inflow.h (class scoped_ignore_sigttou): ...to here.
 577         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 578         * top.c:  Remove include comment.
 579
 580 2019-05-27  Tom Tromey  <tom@tromey.com>
 581
 582         * NEWS: Fix typo.
 583
 584 2019-05-22  Tom Tromey  <tromey@adacore.com>
 585
 586         * target.c (target_follow_exec): Constify parameter.
 587         * target-delegates.c: Rebuild.
 588         * remote.c (remote_target::follow_exec): Constify parameter.
 589         * infrun.c (follow_exec): Constify parameter.
 590         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 591         (target_follow_exec): Likewise.
 592
 593 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 594
 595         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 596         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 597
 598 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 599
 600         * NEWS: Add debugredirect and testsuite sections.
 601
 602 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
 603
 604         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
 605         target descriptions using exclusively floating point register name
 606         aliases.
 607
 608 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
 609
 610         PR gdb/18644:
 611         * f-lang.c (build_fortran_types): Handle the case where
 612         gdbarch_floatformat_for_type returns a nullptr.
 613
 614 2019-05-21  Tom de Vries  <tdevries@suse.de>
 615
 616         PR cli/24587
 617         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
 618
 619 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 620
 621         PR gdb/18644:
 622         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
 623         16-byte floats.
 624         * i386-tdep.c (i386_floatformat_for_type): Use
 625         floatformats_ia64_quad for the 16-byte floating point component
 626         within a fortran 32-byte complex number.
 627
 628 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
 629
 630         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
 631         delete default constructor.
 632         (find_partial_die): Update to return const struct.
 633         (partial_die_parent_scope): Move variable declaration into scope
 634         of its use and change its type to auto.
 635         (guess_partial_die_structure_name): Likewise.
 636         (partial_die_info::fixup): Likewise.
 637
 638 2019-05-17  Tom Tromey  <tromey@adacore.com>
 639
 640         * source.c (find_and_open_source): Remove cast.
 641
 642 2019-05-17  Tom Tromey  <tromey@adacore.com>
 643
 644         * annotate.c (annotate_source): Make "filename" const.
 645         * annotate.h (annotate_source): Use const.
 646
 647 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 648
 649         * disasm.c (set_disassembler_options): Send errors to stderr.
 650
 651 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 652
 653         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
 654         (cli_interp_base::set_logging): Check debug_redirect.
 655         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
 656         * cli/cli-logging.c (debug_redirect): Add static variable.
 657         (pop_output_files): Add default param.
 658         (handle_redirections): Print debug setting.
 659         (show_logging_command): Likewise.
 660         (_initialize_cli_logging): Add debugredirect command.
 661         * interps.c (current_interp_set_logging): Add debug_redirect
 662         parameter.
 663         * interps.h (set_logging): Add debug_redirect parameter.
 664         (current_interp_set_logging): Likewise.
 665         * mi/mi-common.h: Likewise.
 666         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
 667
 668 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
 669             Tom Tromey  <tromey@adacore.com>
 670
 671         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
 672         directly.
 673         * cli/cli-interp.h (make_logging_output): Remove declaration.
 674         * cli/cli-logging.c (make_logging_output): Remove function.
 675         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
 676         directly.
 677         * ui-file.c (tee_file::tee_file): Remove bools.
 678         (tee_file::~tee_file): Remove deletes.
 679         * ui-file.h (tee_file): Remove bools.
 680
 681 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
 682
 683         * mi/mi-cmds.h (mi_cmd_complete): New function.
 684         * mi/mi-main.c (mi_cmd_complete): Likewise.
 685         * mi/mi-cmds.c: Define new MI command -complete.
 686         * NEWS: Mention new -complete command.
 687
 688 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
 689
 690         * completer.h (complete): New function.
 691         * completer.c (complete): Likewise.
 692         * cli/cli-cmds.c: (complete_command): Update to use new complete()
 693         function defined in completer.h.
 694
 695 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
 696
 697        * MAINTAINERS (Write After Approval): Add myself.
 698
 699 2019-05-17  Tom de Vries  <tdevries@suse.de>
 700
 701         PR gdb/24094
 702         * dwarf2read.c (struct cu_partial_die_info): New struct.
 703         (find_partial_die): Return cu_partial_die_info.
 704         (partial_die_parent_scope, guess_partial_die_structure_name)
 705         (partial_die_info::fixup): Handle new return type of find_partial_die.
 706
 707 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 708
 709         * stap-probe.c (stap_parse_register_operand): Make "regname" an
 710         "std::string", simplifying the algorithm.
 711
 712 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 713
 714         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
 715         (stap_static_probe_ops::get_probes): Likewise.
 716
 717 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 718
 719         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
 720         '-')" and "else if".
 721         (stap_parse_single_operand): Join checks for
 722         "gdbarch_stap_parse_special_token_p" and
 723         "gdbarch_stap_parse_special_token" in the same "if" statement.
 724         Invert check when verifying for operation on register
 725         displacement.
 726
 727 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 728
 729         * stap-probe.c (stap_get_opcode): Update comment.
 730         (stap_get_expected_argument_type): Likewise.
 731         (handle_stap_probe): Likewise.
 732
 733 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
 734
 735         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
 736         return type to 'bool'.  Adjust comment.  Use 'bool' when
 737         appropriate.
 738         (i386_stap_parse_special_token_three_arg_disp): Likewise.
 739         * stap-probe.c (stap_parse_argument_1): Likewise.
 740         (stap_is_operator): Likewise.
 741         (stap_is_generic_prefix): Likewise.
 742         (stap_is_register_prefix): Likewise.
 743         (stap_is_register_indirection_prefix): Likewise.
 744         (stap_is_integer_prefix): Likewise.
 745         (stap_generic_check_suffix): Likewise.
 746         (stap_check_integer_suffix): Likewise.
 747         (stap_check_register_suffix): Likewise.
 748         (stap_check_register_indirection_suffix): Likewise.
 749         (stap_parse_register_operand): Likewise.
 750         (stap_parse_single_operand): Likewise.
 751         (stap_parse_argument_1): Likewise.
 752         (stap_probe::get_argument_count): Likewise.
 753         (stap_is_operator): Likewise.
 754
 755 2019-05-16  Tom Tromey  <tromey@adacore.com>
 756
 757         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
 758         keyword to foreach.
 759
 760 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
 761
 762         * linux-thread-db.c (try_thread_db_load_1): Change return type
 763         to bool.
 764         (try_thread_db_load): Likewise.
 765         (try_thread_db_load_from_pdir_1): Likewise.
 766         (try_thread_db_load_from_pdir): Likewise.
 767         (try_thread_db_load_from_sdir): Likewise.
 768         (try_thread_db_load_from_dir): Likewise.
 769         (thread_db_load_search): Likewise.
 770         (has_libpthread): Likewise.
 771         (thread_db_load): Likewise.
 772
 773 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
 774
 775         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 776         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
 777         NULL, and complain/return if that's the case.
 778
 779 2019-05-15  John Darrington <john@darrington.wattle.id.au>
 780
 781         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
 782         (advance, posn, abstract_read_memory): New functions.
 783         [struct mem_read_abstraction]: New struct.
 784         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
 785
 786 2019-05-14  Tom Tromey  <tromey@adacore.com>
 787
 788         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
 789         value is not lval_memory.
 790
 791 2019-05-14  Tom Tromey  <tromey@adacore.com>
 792
 793         * solib.c (info_sharedlibrary_command): Style the file name.
 794
 795 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
 796
 797         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
 798         (aarch64_vnv_type): Likewise.
 799         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
 800         * common/tdesc.c: Likewise.
 801         * common/tdesc.h (enum tdesc_type_kind): Likewise.
 802         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
 803         * features/aarch64-fpu.xml: Add ieee half view.
 804         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
 805         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
 806         * gdbtypes.h (struct builtin_type): Likewise.
 807         (struct objfile_type): Likewise.
 808
 809 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
 810
 811         * language.c (language_sniff_from_mangled_name): Fix "langauge"
 812         typo.
 813         * location.h (string_to_event_location): Likewise.
 814
 815 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
 816
 817         GDB 8.3 released.
 818
 819 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 820
 821         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
 822         New variable declaration.
 823         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
 824         New variable.
 825         (print_one_breakpoint): Use ui_out::test_flags and new global
 826         variable to compute use_fixed_output.
 827         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
 828         Remove.
 829         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
 830         (mi_multi_location_breakpoint_output_fixed): Remove.
 831         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
 832         new variable.
 833         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
 834         fix_multi_location_breakpoint_output flag if version >= 3.
 835         * ui-out.h (enum ui_out_flag)
 836         <fix_multi_location_breakpoint_output>: New enumerator.
 837
 838 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
 839
 840         * contrib/cc-with-tweaks.sh: Validate dwz's work.
 841
 842 2019-05-10  Tom Tromey  <tromey@adacore.com>
 843
 844         * ada-lang.c (catch_ada_completer): New function.
 845         (_initialize_ada_language): Use it.
 846
 847 2019-05-10  Tom Tromey  <tromey@adacore.com>
 848
 849         * thread.c (print_thread_info): Make "requested_threads" const.
 850         * gdbthread.h (print_thread_info): Make "requested_threads"
 851         const.
 852         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
 853         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
 854
 855 2019-05-08  Tom Tromey  <tom@tromey.com>
 856
 857         * gdbtypes.c (objfile_type_data): Change type.
 858         (objfile_type, _initialize_gdbtypes): Update.
 859
 860 2019-05-08  Tom Tromey  <tom@tromey.com>
 861
 862         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
 863         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
 864         (_initialize_dwarf2_frame): Update.
 865
 866 2019-05-08  Tom Tromey  <tom@tromey.com>
 867
 868         * objc-lang.c (objc_objfile_data): Change type.
 869         (find_methods): Update.
 870         (_initialize_objc_lang): Remove.
 871
 872 2019-05-08  Tom Tromey  <tom@tromey.com>
 873
 874         * stabsread.c (rs6000_builtin_type_data): Change type.
 875         (rs6000_builtin_type, _initialize_stabsread): Update.
 876
 877 2019-05-08  Tom Tromey  <tom@tromey.com>
 878
 879         * mips-tdep.c (mips_pdr_data): Remove.
 880         (_initialize_mips_tdep): Update.
 881
 882 2019-05-08  Tom Tromey  <tom@tromey.com>
 883
 884         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
 885         (hppa_init_objfile_priv_data, read_unwind_info)
 886         (find_unwind_entry, _initialize_hppa_tdep): Update.
 887
 888 2019-05-08  Tom Tromey  <tom@tromey.com>
 889
 890         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
 891         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
 892         on obstack.
 893         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
 894
 895 2019-05-08  Tom Tromey  <tom@tromey.com>
 896
 897         * mdebugread.c (basic_type_data): Change type.
 898         (basic_type, _initialize_mdebugread): Update.
 899
 900 2019-05-08  Tom Tromey  <tom@tromey.com>
 901
 902         * common/gdb_unique_ptr.h (struct noop_deleter): New.
 903
 904 2019-05-08  Tom Tromey  <tom@tromey.com>
 905
 906         * nto-tdep.c (nto_inferior_data_reg): Change type.
 907         (nto_inferior_data): Update.
 908         (nto_inferior_data_cleanup, nto_new_inferior_data)
 909         (_initialize_nto_tdep): Remove.
 910         * nto-tdep.h (struct nto_inferior_data): Add initializers.
 911
 912 2019-05-08  Tom Tromey  <tom@tromey.com>
 913
 914         * ada-lang.c (struct ada_inferior_data): Add initializers.
 915         (ada_inferior_data): Change type.
 916         (ada_inferior_data_cleanup): Remove.
 917         (get_ada_inferior_data, ada_inferior_exit)
 918         (struct ada_pspace_data): Add initializers, destructor.
 919         (ada_pspace_data_handle): Change type.
 920         (get_ada_pspace_data): Update.
 921         (ada_pspace_data_cleanup): Remove.
 922
 923 2019-05-08  Tom Tromey  <tom@tromey.com>
 924
 925         * coffread.c (struct coff_symfile_info): Add initializers.
 926         (coff_objfile_data_key): Move lower.  Change type.
 927         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
 928         Update.
 929         (coff_free_info): Remove.
 930
 931 2019-05-08  Tom Tromey  <tom@tromey.com>
 932
 933         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
 934         (fbsd_pspace_data_handle): Move lower.  Change type.
 935         (get_fbsd_pspace_data): Update.
 936         (fbsd_pspace_data_cleanup): Remove.
 937         (_initialize_fbsd_tdep): Update.
 938
 939 2019-05-08  Tom Tromey  <tom@tromey.com>
 940
 941         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
 942         (get_ada_tasks_pspace_data): Update.
 943         (ada_tasks_pspace_data_cleanup): Remove.
 944         (_initialize_tasks): Update.
 945         (ada_tasks_inferior_data_handle): Change type.
 946         (get_ada_tasks_inferior_data): Update.
 947         (ada_tasks_inferior_data_cleanup): Remove.
 948         (struct ada_tasks_pspace_data): Add initializers.
 949
 950 2019-05-08  Tom Tromey  <tom@tromey.com>
 951
 952         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
 953         * symfile-debug.c (debug_sym_get_probes): Change type.
 954         * stap-probe.c (handle_stap_probe):
 955         (stap_static_probe_ops::get_probes): Change type.
 956         * probe.h (class static_probe_ops) <get_probes>: Change type.
 957         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
 958         (parse_probes_in_pspace): Update.
 959         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
 960         Update.
 961         (any_static_probe_ops::get_probes): Change type.
 962         * elfread.c (elfread_data): New typedef.
 963         (probe_key): Change type.
 964         (elf_get_probes): Likewise.  Update.
 965         (probe_key_free): Remove.
 966         (_initialize_elfread): Update.
 967         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
 968         Change type.
 969         (dtrace_process_dof_probe, dtrace_process_dof)
 970         (dtrace_static_probe_ops::get_probe): Change type.
 971
 972 2019-05-08  Tom Tromey  <tom@tromey.com>
 973
 974         * xcoffread.c (struct xcoff_symfile_info): Rename from
 975         coff_symfile_info.  Add initializers.
 976         (xcoff_objfile_data_key): Move lower.  Change type.
 977         (XCOFF_DATA): Rewrite.
 978         (xcoff_free_info): Remove.
 979         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
 980         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
 981         (xcoff_initial_scan): Update.
 982
 983 2019-05-08  Tom Tromey  <tom@tromey.com>
 984
 985         * solib-svr4.c (struct svr4_info): Add initializers and
 986         destructor.
 987         <probes_table>: Now an htab_up.
 988         (solib_svr4_pspace_data): Change type.
 989         (free_probes_table): Simplify.
 990         (~svr4_info): Rename from svr4_pspace_data_cleanup.
 991         (get_svr4_info, probes_table_htab_remove_objfile_probes)
 992         (probes_table_remove_objfile_probes, register_solib_event_probe)
 993         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
 994         (_initialize_svr4_solib): Update.
 995
 996 2019-05-08  Tom Tromey  <tom@tromey.com>
 997
 998         * remote.c (remote_pspace_data): Change type.
 999         (remote_pspace_data_cleanup): Remove.
1000         (get_remote_exec_file, set_pspace_remote_exec_file)
1001         (_initialize_remote): Update.
1002
1003 2019-05-08  Tom Tromey  <tom@tromey.com>
1004
1005         * breakpoint.c (breakpoint_objfile_key): Change type.
1006         (get_breakpoint_objfile_data): Update.
1007         (free_breakpoint_objfile_data): Remove.
1008         (_initialize_breakpoint): Update.
1009
1010 2019-05-08  Tom Tromey  <tom@tromey.com>
1011
1012         * linux-tdep.c (struct linux_info): Add initializers.
1013         (linux_inferior_data): Move.  Change type.
1014         (invalidate_linux_cache_inf): Update.
1015         (linux_inferior_data_cleanup): Remove.
1016         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1017
1018 2019-05-08  Tom Tromey  <tom@tromey.com>
1019
1020         * auxv.c (auxv_inferior_data): Move.  Change type.
1021         (auxv_inferior_data_cleanup): Remove.
1022         (invalidate_auxv_cache_inf): Rewrite.
1023         (get_auxv_inferior_data, _initialize_auxv): Update.
1024
1025 2019-05-08  Tom Tromey  <tom@tromey.com>
1026
1027         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1028         (symfile_debug_objfile_data_key): Change type.
1029         (symfile_debug_installed, debug_qf_has_symbols)
1030         (debug_qf_find_last_source_symtab)
1031         (debug_qf_forget_cached_source_info)
1032         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1033         (debug_qf_print_stats, debug_qf_dump)
1034         (debug_qf_expand_symtabs_for_function)
1035         (debug_qf_expand_all_symtabs)
1036         (debug_qf_expand_symtabs_with_fullname)
1037         (debug_qf_map_matching_symbols)
1038         (debug_qf_expand_symtabs_matching)
1039         (debug_qf_find_pc_sect_compunit_symtab)
1040         (debug_qf_map_symbol_filenames)
1041         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1042         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1043         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1044         (debug_sym_read_linetable, debug_sym_relocate): Update.
1045         (symfile_debug_free_objfile): Remove.
1046         (install_symfile_debug_logging, _initialize_symfile_debug):
1047         Update.
1048
1049 2019-05-08  Tom Tromey  <tom@tromey.com>
1050
1051         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1052         allocate_on_obstack.
1053         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1054         (get_dwarf2_per_objfile): Update.
1055         (set_dwarf2_per_objfile): Remove.
1056         (dwarf2_has_info, dwarf2_get_section_info): Update.
1057         (dwarf2_free_objfile): Remove.
1058         (_initialize_dwarf2_read): Update.
1059
1060 2019-05-08  Tom Tromey  <tom@tromey.com>
1061
1062         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1063         initializers.
1064         <unsupported_script_warning_printed,
1065         script_not_found_warning_printed>: Now bool.
1066         (auto_load_pspace_data): Change type.
1067         (~auto_load_pspace_info): Rename from
1068         auto_load_pspace_data_cleanup.
1069         (get_auto_load_pspace_data, init_loaded_scripts_info)
1070         (clear_section_scripts, maybe_print_unsupported_script_warning)
1071         (maybe_print_script_not_found_warning, _initialize_auto_load):
1072         Update.
1073
1074 2019-05-08  Tom Tromey  <tom@tromey.com>
1075
1076         * objfiles.c (objfile_pspace_info): Add destructor and
1077         initializers.
1078         (objfiles_pspace_data): Change type.
1079         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1080         (get_objfile_pspace_data): Update.
1081         (objfiles_bfd_data): Change type.
1082         (get_objfile_bfd_data): Update.
1083         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1084
1085 2019-05-08  Tom Tromey  <tom@tromey.com>
1086
1087         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1088         Change type.
1089         (get_catch_syscall_inferior_data): Update.
1090         (catch_syscall_inferior_data_cleanup): Remove.
1091         (_initialize_break_catch_syscall): Update.
1092
1093 2019-05-08  Tom Tromey  <tom@tromey.com>
1094
1095         * inflow.c (struct terminal_info): Add destructor and
1096         initializers.
1097         (inflow_inferior_data): Change type.
1098         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1099         (get_inflow_inferior_data, inflow_inferior_exit)
1100         (swap_terminal_info, _initialize_inflow): Update.
1101
1102 2019-05-08  Tom Tromey  <tom@tromey.com>
1103
1104         * target-dcache.c (target_dcache_cleanup): Remove.
1105         (target_dcache_aspace_key): Change type.
1106         (target_dcache_init_p, target_dcache_invalidate)
1107         (target_dcache_get, target_dcache_get_or_init)
1108         (_initialize_target_dcache): Update.
1109         * dcache.h (struct dcache_deleter): New.
1110
1111 2019-05-08  Tom Tromey  <tom@tromey.com>
1112
1113         * symtab.c (struct symbol_cache): Add destructor and
1114         initializers.
1115         (symbol_cache_key): Move.  Change type.
1116         (make_symbol_cache, free_symbol_cache): Remove.
1117         (get_symbol_cache): Update.
1118         (symbol_cache_cleanup): Remove.
1119         (ALL_PSPACES, symbol_cache_flush)
1120         (maintenance_print_symbol_cache)
1121         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1122         Update.
1123
1124 2019-05-08  Tom Tromey  <tom@tromey.com>
1125
1126         * symtab.c (struct main_info): Add destructor and initializers.
1127         (main_progspace_key): Move.  Change type.
1128         (get_main_info): Update.
1129         (main_info_cleanup): Remove.
1130         (_initialize_symtab): Update.
1131
1132 2019-05-08  Tom Tromey  <tom@tromey.com>
1133
1134         * registry.h (DECLARE_REGISTRY): Define the _key class.
1135
1136 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1137
1138         * NEWS: Merge two 'New commands' sections.
1139
1140 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1141
1142         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1143         parameter and use Ada language definition instead.
1144         (ada_val_print_ptr): Remove unused language parameter.
1145         (ada_val_print_num): Remove language parameter and use Ada language
1146         definition instead.
1147         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1148         parameter.
1149         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1150         parameter and use Ada language definition instead.
1151         (ada_val_print_1): Update all ada_val_print_xxx calls.
1152         Remove language parameter.
1153         (ada_val_print): Update ada_val_print_1 call.
1154
1155 2019-05-08  Tom Tromey  <tromey@adacore.com>
1156
1157         * remote.c (remote_hw_watchpoint_limit)
1158         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1159         Now static.
1160
1161 2019-05-08  Tom Tromey  <tromey@adacore.com>
1162
1163         * maint.c (_initialize_maint_cmds): Move initialization code to
1164         remote.c.
1165         (watchdog, show_watchdog): Move to remote.c.
1166         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1167         "watchdog" static.
1168         (_initialize_remote): Move initialization code from maint.c.
1169         * defs.h (watchdog): Don't declare.
1170
1171 2019-05-08  Tom Tromey  <tromey@adacore.com>
1172
1173         * tui/tui-interp.c: Include main.h.
1174         * interps.c: Include main.h.
1175         * main.h (interpreter_p): Declare.
1176         * defs.h (interpreter_p): Don't declare.
1177
1178 2019-05-08  Tom Tromey  <tromey@adacore.com>
1179
1180         * dwarf2loc.c: Include dwarf2read.h.
1181         * defs.h (read_unsigned_leb128): Don't declare.
1182         * dwarf2read.h (read_unsigned_leb128): Declare.
1183
1184 2019-05-08  Tom Tromey  <tromey@adacore.com>
1185
1186         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1187         method.
1188
1189 2019-05-08  Tom Tromey  <tromey@adacore.com>
1190
1191         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1192         when no wrap column is set.
1193
1194 2019-05-08  Tom Tromey  <tromey@adacore.com>
1195
1196         * c-lang.c (c_get_string): Handle non-C-style arrays.
1197
1198 2019-05-08  Tom Tromey  <tromey@adacore.com>
1199
1200         * typeprint.c (print_offset_data::update): Print the bit offset,
1201         not the number of bits remaining.
1202
1203 2019-05-08  Tom Tromey  <tromey@adacore.com>
1204
1205         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1206         padding at end of comment.
1207
1208 2019-05-08  Tom Tromey  <tromey@adacore.com>
1209
1210         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1211         Compare main types.
1212
1213 2019-05-06  Tom Tromey  <tom@tromey.com>
1214
1215         * common/scoped_mmap.c: Include common-defs.h.
1216         * common/scoped_mmap.h: Don't include config.h.
1217
1218 2019-05-04  Tom Tromey  <tom@tromey.com>
1219
1220         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1221         (struct aarch64_call_info): Add initializers.
1222         <si>: Now a std::vector.
1223         (pass_on_stack, aarch64_push_dummy_call): Update.
1224
1225 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1226             Tom Tromey  <tom@tromey.com>
1227
1228         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1229         (ppc_threads): Now a std::vector.  Now static.
1230         (hwdebug_find_thread_points_by_tid)
1231         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1232         Update.
1233
1234 2019-05-04  Tom Tromey  <tom@tromey.com>
1235
1236         * arc-tdep.c (arc_tdesc_init): Return bool.
1237
1238 2019-05-04  Tom Tromey  <tom@tromey.com>
1239
1240         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1241         Use gdb_assert_not_reached.
1242
1243 2019-05-04  Tom Tromey  <tom@tromey.com>
1244
1245         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1246         "false".
1247
1248 2019-05-04  Tom Tromey  <tom@tromey.com>
1249
1250         * arc-tdep.c (arc_tdesc_init): Use bool.
1251
1252 2019-05-04  Tom Tromey  <tom@tromey.com>
1253
1254         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1255
1256 2019-05-04  Tom Tromey  <tom@tromey.com>
1257
1258         * cli/cli-cmds.c (valid_command_p): Return bool.
1259
1260 2019-05-04  Tom Tromey  <tom@tromey.com>
1261
1262         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1263         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1264
1265 2019-05-04  Raul Tambre  <raul@tambre.ee>
1266
1267         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1268         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1269         operator for comparison.
1270
1271 2019-05-04  Tom Tromey  <tom@tromey.com>
1272
1273         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1274         (lookup_partial_symbol, print_partial_symbols)
1275         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1276         (psymbol_compare): Update.
1277         (add_psymbol_to_bcache): Clear the entire psymbol.
1278         (maintenance_check_psymtabs): Update.
1279         * psympriv.h (struct partial_symbol): Don't derive from
1280         general_symbol_info.
1281         <obj_section, unrelocated_address, address,
1282         set_unrelocated_address>: Update.
1283         <ginfo>: New member.
1284         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1285         (debug_names::write_psymbols): Update.
1286
1287 2019-05-04  Tom de Vries  <tdevries@suse.de>
1288
1289         * contrib/cc-with-tweaks.sh: Support -n arg.
1290
1291 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1292
1293         * corelow.c (core_target::detach): Ensure frame cache and
1294         register caches are cleared.
1295         inferior.c (exit_inferior_1): Likewise.
1296
1297 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1298             Tom Tromey  <tom@tromey.com>
1299
1300         * dictionary.c (collate_pending_symbols_by_language): Remove
1301         "struct" from foreach.
1302         * symtab.c (lookup_global_symbol_from_objfile)
1303         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1304         foreach.
1305         * ser-tcp.c (net_open): Remove "struct" from foreach.
1306         * objfiles.c (objfile_relocate, objfile_rebase)
1307         (objfile_has_symbols): Remove "struct" from foreach.
1308         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1309         from foreach.
1310         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1311         foreach.
1312         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1313         "struct" from foreach.
1314         * ada-lang.c (create_excep_cond_exprs)
1315         (ada_exception_catchpoint_cond_string): Remove "struct" from
1316         foreach.
1317
1318 2019-05-03  Tom Tromey  <tromey@adacore.com>
1319
1320         * ada-exp.y (convert_char_literal): Check suffix of each
1321         enumerator.
1322
1323 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1324
1325         PR ada/21406:
1326         * ada-exp.y (yywrap): Don't define.
1327         * ada-lex.l (%option): Add noyywrap
1328         (yywrap): Remove.
1329
1330 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1331
1332         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1333         _WIN32_WINNT to the XP level, unless already defined to a higher
1334         level.
1335
1336         * unittests/parse-connection-spec-selftests.c:
1337         * ser-tcp.c:
1338         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1339         override.
1340
1341         * symfile.c (find_separate_debug_file): Remove colon from the
1342         drive spec of DOS/Windows file names of the target, so that the
1343         file name produced from DEBUGDIR and the target's directory will
1344         be valid on DOS/Windows systems.
1345
1346 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1347
1348         * rust-lang.c (val_print_struct): Handle printing structures
1349         containing strings.
1350
1351 2019-05-02  Tom Tromey  <tromey@adacore.com>
1352
1353         * valarith.c (_initialize_valarith): Remove.
1354
1355 2019-05-01  Tom Tromey  <tromey@adacore.com>
1356
1357         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1358         bitfields.
1359
1360 2019-05-01  Tom Tromey  <tromey@adacore.com>
1361
1362         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1363         for big-endian copies.
1364
1365 2019-04-30  Ali Tamur  <tamur@google.com>
1366         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1367         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1368         (read_3_bytes): New function.
1369
1370 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1371
1372         * windows-nat.c (main_thread_id): Delete.
1373         (handle_output_debug_string): Replace main_thread_id by
1374         current_event.dwThreadId.
1375         (fake_create_process): Likewise.
1376         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1377         Do not set main_thread_id.
1378         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1379         current_event.dwThreadId.
1380         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1381
1382 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1383
1384         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1385         Use current_event.dwThreadId instead of main_thread_id.
1386
1387 2019-04-30  Tom Tromey  <tromey@adacore.com>
1388
1389         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1390         (create_excep_cond_exprs): Iterate over program spaces.
1391         (ada_exception_catchpoint_cond_string): Examine all minimal
1392         symbols for exception types.
1393
1394 2019-04-30  Tom Tromey  <tromey@adacore.com>
1395
1396         PR c++/24470:
1397         * dwarf2read.c (process_structure_scope): Handle case where type
1398         has template parameters but no symbol was created.
1399
1400 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1401             Chris January  <chris.january@arm.com>
1402
1403         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1404         qualifier.
1405         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1406
1407 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1408
1409         * f-typeprint.c (f_print_type): Update rules for printing
1410         whitespace.
1411         (f_type_print_varspec_suffix): Likewise.
1412
1413 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1414             Chris January  <chris.january@arm.com>
1415
1416         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1417         function arguments.
1418
1419 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1420
1421         * f-lang.c (build_fortran_types): Change name of void type to
1422         lower case.
1423         * f-typeprint.c (f_type_print_base): Print the name of the void
1424         type, rather than a fixed string.
1425         * f-valprint.c (f_decorations): Use lower case void string.
1426
1427 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1428             Chris January  <chris.january@arm.com>
1429
1430         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1431         types for Fortran.
1432
1433 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1434             Chris January  <chris.january@arm.com>
1435             David Lecomber  <david.lecomber@arm.com>
1436
1437         * f-exp.y (BINOP_INTRINSIC): New token.
1438         (exp): New parser rule handling BINOP_INTRINSIC.
1439         (f77_keywords): Add new builtin procedures.
1440         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1441         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1442         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1443         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1444         (print_unop_subexp_f): New function.
1445         (print_binop_subexp_f): New function.
1446         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1447         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1448         (dump_subexp_body_f): Likewise.
1449         (operator_check_f): Likewise.
1450         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1451         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1452
1453 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1454
1455         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1456         UNOP_KIND.
1457         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1458         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1459         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1460         (operator_length_f): New fuction.
1461         (print_subexp_f): New function.
1462         (op_name_f): New function.
1463         (dump_subexp_body_f): New function.
1464         (operator_check_f): New function.
1465         (exp_descriptor_f): Replace standard expression handling functions
1466         with new functions.
1467         * gdb/fortran-operator.def: New file.
1468         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1469         * gdb/std-operator.def: Remove UNOP_KIND.
1470
1471 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1472
1473         * std-operator.def: Remove unbalanced, stray double quote
1474         character.
1475
1476 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1477             Chris January  <chris.january@arm.com>
1478             Daniel Everett  <daniel.everett@arm.com>
1479             Nick Forrington  <nick.forrington@arm.com>
1480             Richard Bunt  <richard.bunt@arm.com>
1481
1482         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1483         of depth when printing anonymous structs or unions.
1484         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1485         Don't print either the top-level value, or the children if the
1486         max-depth is exceeded.
1487         (ppscm_print_children): When printing the key of a map, allow one
1488         extra level of depth.
1489         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1490         print either the top-level value, or the children if the max-depth
1491         is exceeded.
1492         (print_children): When printing the key of a map, allow one extra
1493         level of depth.
1494         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1495         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1496         (user_print_options): Initialise max_depth field.
1497         (val_print_scalar_or_string_type_p): New function.
1498         (val_print): Check to see if the max depth has been reached.
1499         (val_print_check_max_depth): Define new function.
1500         (show_print_max_depth): New function.
1501         (_initialize_valprint): Add 'print max-depth' option.
1502         * valprint.h (struct value_print_options) <max_depth>: New field.
1503         (val_print_check_max_depth): Declare new function.
1504         * NEWS: Document new feature.
1505
1506 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1507
1508         * ada-lang.c (ada_language_defn): Initialise new field.
1509         * c-lang.c (c_is_string_type_p): New function.
1510         (c_language_defn): Initialise new field.
1511         (cplus_language_defn): Initialise new field.
1512         (asm_language_defn): Initialise new field.
1513         (minimal_language_defn): Initialise new field.
1514         * c-lang.h (c_is_string_type_p): Declare new function.
1515         * d-lang.c (d_language_defn): Initialise new field.
1516         * f-lang.c (f_is_string_type_p): New function.
1517         (f_language_defn): Initialise new field.
1518         * go-lang.c (go_is_string_type_p): New function.
1519         (go_language_defn): Initialise new field.
1520         * language.c (default_is_string_type_p): New function.
1521         (unknown_language_defn): Initialise new field.
1522         (auto_language_defn): Initialise new field.
1523         * language.h (struct language_defn) <la_is_string_type_p>: New
1524         member variable.
1525         (default_is_string_type_p): Declare new function.
1526         * m2-lang.c (m2_language_defn): Initialise new field.
1527         * objc-lang.c (objc_language_defn): Initialise new field.
1528         * opencl-lang.c (opencl_language_defn): Initialise new field.
1529         * p-lang.c (pascal_is_string_type_p): New function.
1530         (pascal_language_defn): Initialise new field.
1531         * rust-lang.c (rust_is_string_type_p): New function.
1532         (rust_language_defn): Initialise new field.
1533
1534 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1535
1536         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1537         New field.
1538         * ada-lang.c (ada_language_defn): Initialise new field.
1539         * c-lang.c (c_language_defn): Likewise.
1540         (cplus_language_defn): Likewise.
1541         (asm_language_defn): Likewise.
1542         (minimal_language_defn): Likewise.
1543         * d-lang.c (d_language_defn): Likewise.
1544         * f-lang.c (f_language_defn): Likewise.
1545         * go-lang.c (go_language_defn): Likewise.
1546         * language.c (unknown_language_defn): Likewise.
1547         (auto_language_defn): Likewise.
1548         * m2-lang.c (m2_language_defn): Likewise.
1549         * objc-lang.c (objc_language_defn): Likewise.
1550         * opencl-lang.c (opencl_language_defn): Likewise.
1551         * p-lang.c (pascal_language_defn): Likewise.
1552         * rust-lang.c (rust_language_defn): Likewise.
1553
1554 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1555
1556         * ada-lang.c (ada_is_character_type): Change return type to bool.
1557         (ada_is_string_type): Likewise.
1558         * ada-lang.h (ada_is_character_type): Update declaration
1559         (ada_is_string_type): Likewise.
1560
1561 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1562
1563         Support style in 'frame|thread apply'
1564
1565         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1566         * record.c (record_start, record_stop): Update callers of
1567         execute_command_to_string with false.
1568         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1569         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1570         methods.
1571         (class string_file): New constructor with term_out parameter.
1572         Override methods term_out and can_emit_style_escape.  New member
1573         term_out.
1574         (class stdio_file): Override can_emit_style_escape.
1575         (class tee_file): Override term_out and can_emit_style_escape.
1576         * utils.h (can_emit_style_escape): Remove.
1577         * utils.c (can_emit_style_escape): Likewise.
1578         Update all callers of can_emit_style_escape (SOMESTREAM) to
1579         SOMESTREAM->can_emit_style_escape.
1580         * source-cache.c (source_cache::get_source_lines): Likewise.
1581         * stack.c (frame_apply_command_count): Call execute_command_to_string
1582         passing the term_out characteristic of the current gdb_stdout.
1583         * thread.c (thr_try_catch_cmd): Likewise.
1584         * top.c (execute_command_to_string): pass term_out parameter
1585         to construct the string_file for the command output.
1586         * ui-file.c (term_cli_styling): New function (most code moved
1587         from utils.c can_emit_style_escape).
1588         (string_file::string_file, string_file::can_emit_style_escape,
1589         stdio_file::can_emit_style_escape, tee_file::term_out,
1590         tee_file::can_emit_style_escape): New functions.
1591
1592 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1593
1594         * NEWS: Mention the new set|show may-call-functions.
1595         * infcall.c (may_call_functions_p): New variable.
1596         (show_may_call_functions_p): New function.
1597         (call_function_by_hand_dummy): Throws an error if not
1598         may-call-functions.
1599         (_initialize_infcall): Call add_setshow_boolean_cmd for
1600         may-call-functions.
1601
1602 2019-04-25  Keith Seitz  <keiths@redhat.com>
1603
1604         PR c++/24367
1605         * cp-support.c (inspect_type): Don't attempt substitutions
1606         of symbol with the same name.
1607
1608 2019-04-25  Tom Tromey  <tromey@adacore.com>
1609
1610         PR gdb/24475:
1611         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
1612         static.
1613
1614 2019-04-25  Tom Tromey  <tromey@adacore.com>
1615
1616         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
1617         rvalue reference.
1618         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
1619         (gdb_xml_parser::parse): Use std::move.
1620         * python/python-internal.h (gdbpy_convert_exception): Take a const
1621         reference.
1622         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
1623         std::move.
1624         * python/py-utils.c (gdbpy_convert_exception): Take a const
1625         reference.
1626         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1627         Use std::move.
1628         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1629         Use std::move.
1630         * mi/mi-main.c (mi_print_exception): Take a const reference.
1631         * main.c (handle_command_errors): Take a const reference.
1632         * linespec.c (parse_linespec): Use std::move.
1633         * infcall.c (run_inferior_call): Use std::move.
1634         (call_function_by_hand_dummy): Use std::move.
1635         * exec.c (try_open_exec_file): Use std::move.
1636         * exceptions.h (exception_print, exception_fprintf)
1637         (exception_print_same): Update.
1638         * exceptions.c (print_exception, exception_print)
1639         (exception_fprintf, exception_print_same): Change parameters to
1640         const reference.
1641         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
1642         * common/new-op.c: Use std::move.
1643         * common/common-exceptions.h (struct gdb_exception): Add move
1644         constructor.
1645         (struct gdb_exception_error, struct gdb_exception_quit, struct
1646         gdb_quit_bad_alloc): Change constructor to move constructor.
1647         (throw_exception): Change parameter to rvalue reference.
1648         * common/common-exceptions.c (throw_exception): Take rvalue
1649         reference.
1650         * cli/cli-interp.c (safe_execute_command): Use std::move.
1651         * breakpoint.c (insert_bp_location, location_to_sals): Use
1652         std::move.
1653
1654 2019-04-25  Tom Tromey  <tromey@adacore.com>
1655
1656         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
1657         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
1658         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
1659         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
1660         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
1661         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
1662         guile/scm-value.c: Use unpack.
1663         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
1664         gdbscm_gdb_exception.
1665         (gdbscm_throw_gdb_exception): Likewise.
1666         (struct gdbscm_gdb_exception): New.
1667         (unpack): New function.
1668         (gdbscm_wrap): Use unpack.
1669
1670 2019-04-25  Tom Tromey  <tromey@adacore.com>
1671
1672         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1673         (gdb_rl_callback_handler): Use std::move.
1674         * common/common-exceptions.h (struct gdb_exception): Add move
1675         assignment operator.
1676         (throw_exception_sjlj): Change "exception" to const reference.
1677         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
1678         (throw_exception_sjlj): Change "exception" to const reference.
1679
1680 2019-04-25  Tom Tromey  <tromey@adacore.com>
1681
1682         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
1683         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
1684         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
1685         Update.
1686         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
1687         Update.
1688         * mi/mi-interp.c (mi_interp::exec): Update.
1689         * linespec.c (parse_linespec): Update.
1690         * infcall.c (run_inferior_call): Update.
1691         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
1692         * guile/scm-symbol.c (gdbscm_lookup_symbol)
1693         (gdbscm_lookup_global_symbol): Update.
1694         * guile/scm-param.c (gdbscm_parameter_value): Update.
1695         * guile/scm-frame.c (gdbscm_frame_read_register)
1696         (gdbscm_frame_read_var): Update.
1697         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
1698         * exec.c (try_open_exec_file): Update.
1699         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
1700         (gdb_rl_callback_handler): Update.
1701         * common/common-exceptions.h (exception_none): Don't declare.
1702         * common/common-exceptions.c (exception_none): Don't define.
1703         (struct catcher) <exception>: Update.
1704         * cli/cli-interp.c (safe_execute_command): Update.
1705         * breakpoint.c (insert_bp_location, location_to_sals): Update.
1706
1707 2019-04-25  Ali Tamur  <tamur@google.com>
1708
1709         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
1710         (read_attribute_value): Likewise.
1711         (dwarf2_read_addr_index): Update comment.
1712         (read_str_index): Add DW_FORM_strx.
1713         (dwarf2_string_attr): Likewise.
1714         (dwarf2_const_value_attr): Likewise.
1715         (dump_die_shallow): Likewise.
1716         (dwarf2_fetch_constant_bytes): Likewise.
1717         (skip_form_bytes): Likewise.
1718         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
1719
1720 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
1721
1722         PR corefiles/11608
1723         PR corefiles/18187
1724         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
1725         OFFSET.  Verify if current mapping contains an ELF header.
1726         (linux_find_memory_regions_full): Adjust call to
1727         dump_mapping_p.
1728
1729 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
1730             Kang Li <kanglictf@gmail.com>
1731
1732         PR gdb/21600
1733
1734         * dwarf2-frame.c (read_initial_length): Be consistent about using
1735         unsigned representation of length.
1736         (decode_frame_entry_1): Likewise.  Check for wraparound of
1737         end pointer as well as buffer overflow.
1738
1739 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
1740
1741         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
1742         "vq".
1743
1744 2019-04-24  Tom Tromey  <tromey@adacore.com>
1745
1746         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
1747
1748 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1749
1750         * s12z-tdep.c (s12z_unwind_pc): Delete.
1751         (s12z_unwind_sp): Delete.
1752         (s12z_gdbarch_init): Don't register deleted functions with
1753         gdbarch.
1754
1755 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1756
1757         * rl78-tdep.c (rl78_unwind_sp): Delete.
1758         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
1759
1760 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1761
1762         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
1763         (xstormy16_unwind_pc): Delete.
1764         (xstormy16_dummy_id): Delete.
1765         (xstormy16_gdbarch_init): Don't register deleted functions with
1766         gdbarch.
1767
1768 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1769
1770         * vax-tdep.c (vax_unwind_pc): Delete.
1771         (vax_gdbarch_init): Don't register deleted function with gdbarch.
1772
1773 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1774
1775         * v850-tdep.c (v850_unwind_sp): Delete.
1776         (v850_unwind_pc): Delete.
1777         (v850_dummy_id): Delete.
1778         (v850_gdbarch_init): Don't register deleted functions with
1779         gdbarch.
1780
1781 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1782
1783         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
1784         (tilegx_unwind_pc): Delete.
1785         (tilegx_unwind_dummy_id): Delete.
1786         (tilegx_gdbarch_init): Don't register deleted functions with
1787         gdbarch.
1788
1789 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1790
1791         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
1792         (tic6x_dummy_id): Delete.
1793         (tic6x_gdbarch_init): Don't register deleted functions with
1794         gdbarch.
1795
1796 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1797
1798         * sparc-tdep.c (sparc_unwind_pc): Delete.
1799         (sparc32_gdbarch_init): Don't register deleted function with
1800         gdbarch.
1801
1802 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1803
1804         * sh-tdep.c (sh_unwind_sp): Delete.
1805         (sh_unwind_pc): Delete.
1806         (sh_dummy_id): Delete.
1807         (sh_gdbarch_init): Don't register deleted functions with
1808         gdbarch.
1809
1810 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1811
1812         * score-tdep.c (score_unwind_sp): Delete.
1813         (score_unwind_pc): Delete.
1814         (score_dummy_id): Delete.
1815         (score_gdbarch_init): Don't register deleted functions with
1816         gdbarch.
1817
1818 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1819
1820         * rx-tdep.c (rx_unwind_pc): Delete.
1821         (rx_unwind_sp): Delete.
1822         (rx_dummy_id): Delete.
1823         (rx_gdbarch_init): Don't register deleted functions with
1824         gdbarch.  Update comment.
1825
1826 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1827
1828         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
1829         (rs6000_dummy_id): Delete.
1830         (rs6000_gdbarch_init): Don't register deleted functions with
1831         gdbarch.
1832
1833 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1834
1835         * or1k-tdep.c (or1k_dummy_id): Delete.
1836         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
1837
1838 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1839
1840         * nios2-tdep.c (nios2_dummy_id): Delete.
1841         (nios2_unwind_sp): Delete.
1842         (nios2_gdbarch_init): Don't register deleted functions with
1843         gdbarch.
1844
1845 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1846
1847         * nds32-tdep.c (nds32_dummy_id): Delete.
1848         (nds32_unwind_pc): Delete.
1849         (nds32_unwind_sp): Delete.
1850         (nds32_gdbarch_init): Don't register deleted functions with
1851         gdbarch.
1852
1853 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1854
1855         * msp430-tdep.c (msp430_unwind_pc): Delete.
1856         (msp430_unwind_sp): Delete.
1857         (msp430_dummy_id): Delete.
1858         (msp430_gdbarch_init): Don't register deleted functions with
1859         gdbarch.
1860
1861 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1862
1863         * moxie-tdep.c (moxie_unwind_sp): Delete.
1864         (moxie_unwind_pc): Delete.
1865         (moxie_dummy_id): Delete.
1866         (moxie_gdbarch_init): Don't register deleted functions with
1867         gdbarch.
1868
1869 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1870
1871         * mn10300-tdep.c (mn10300_dummy_id): Delete.
1872         (mn10300_unwind_pc): Delete.
1873         (mn10300_unwind_sp): Delete.
1874         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
1875         mn10300_unwind_sp.
1876         (mn10300_frame_unwind_init): Don't register deleted functions with
1877         gdbarch.
1878
1879 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1880
1881         * mep-tdep.c (mep_unwind_pc): Delete.
1882         (mep_unwind_sp): Delete.
1883         (mep_dummy_id): Delete.
1884         (mep_gdbarch_init): Don't register deleted functions with
1885         gdbarch.
1886
1887 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1888
1889         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
1890         (m68hc11_unwind_sp): Delete.
1891         (m68hc11_gdbarch_init): Don't register deleted functions with
1892         gdbarch.
1893
1894 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1895
1896         * m32r-tdep.c (m32r_unwind_sp): Delete.
1897         (m32r_unwind_pc): Delete.
1898         (m32r_dummy_id): Delete.
1899         (m32r_gdbarch_init): Don't register deleted functions with
1900         gdbarch.
1901
1902 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1903
1904         * m32c-tdep.c (m32c_unwind_pc): Delete.
1905         (m32c_unwind_sp): Delete.
1906         (m32c_dummy_id): Delete.
1907         (m32c_gdbarch_init): Don't register deleted functions with
1908         gdbarch.
1909
1910 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1911
1912         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
1913         (lm32_unwind_pc): Delete.
1914         (lm32_dummy_id): Delete.
1915         (lm32_gdbarch_init): Don't register deleted functions with
1916         gdbarch.
1917
1918 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1919
1920         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
1921         (iq2000_unwind_pc): Delete.
1922         (iq2000_dummy_id): Delete.
1923         (iq2000_gdbarch_init): Don't register deleted functions with
1924         gdbarch.
1925
1926 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1927
1928         * nds32-tdep.c (nds32_type_align): Delete.
1929         (nds32_push_dummy_call): Use type_align instead.
1930
1931 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * arm-tdep.c (arm_type_align): Only handle vector override case.
1934         (arm_push_dummy_call): Use type_align.
1935         (arm_gdbarch_init): Register arm_type_align gdbarch function.
1936
1937 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
1938
1939         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
1940         case.
1941         (pass_on_stack): Use type_align.
1942         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
1943         function.
1944
1945 2019-04-23  Tom Tromey  <tromey@adacore.com>
1946
1947         * dwarf2read.c (line_header::file_name_at): Remove unused
1948         overload.
1949
1950 2019-04-23  Tom de Vries  <tdevries@suse.de>
1951
1952         PR gdb/24438
1953         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
1954         invocation.
1955
1956
1957 2019-03-27  Ali Tamur  <tamur@google.com>
1958
1959         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
1960         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
1961         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
1962         (dwarf_expr_context::get_addr_index): Likewise
1963         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
1964         (symbol_needs_eval_context::get_addr_index): Likewise
1965         (disassemble_dwarf_expression): Add DW_OP_addrx
1966         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
1967         (read_cutu_die_from_dwo): Update comment
1968         (skip_one_die): Add DW_FORM_addrx
1969         (read_attribute_value): Likewise
1970         (var_decode_location): Add DW_OP_addrx
1971         (dwarf2_const_value_attr): Add DW_FORM_addrx
1972         (dump_die_shallow): Likewise
1973         (dwarf2_fetch_constant_bytes): Likewise
1974         (decode_locdesc): Add DW_OP_addrx
1975         (skip_form_bytes): Add DW_FORM_addrx
1976
1977 2019-04-22  Ali Tamur  <tamur@google.com>
1978
1979         * MAINTAINERS (Write After Approval): Add self.
1980
1981 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
1982
1983         * solib-svr4.c (get_svr4_info): Add pspace parameter.
1984         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
1985         (open_symbol_file_object): Likewise.
1986         (svr4_default_sos): Add info parameter.
1987         (svr4_read_so_list): Likewise.
1988         (svr4_current_sos_direct): Adjust functions calls to pass down
1989         info.
1990         (svr4_current_sos_1): Add info parameter.
1991         (svr4_current_sos): Call get_svr4_info, pass info down to
1992         svr4_current_sos_1.
1993         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
1994         get_svr4_info.
1995         (svr4_in_dynsym_resolve_code): Pass current_program_space to
1996         get_svr4_info.
1997         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
1998         to get_svr4_info.
1999         (probes_table_remove_objfile_probes): Likewise.
2000         (register_solib_event_probe): Add info parameter.
2001         (solist_update_incremental): Pass info parameter down to
2002         svr4_read_so_list.
2003         (disable_probes_interface): Add info parameter.
2004         (svr4_handle_solib_event): Pass current_program_space to
2005         get_svr4_info.  Adjust disable_probes_interface cleanup.
2006         (svr4_create_probe_breakpoints): Add info parameter, pass it
2007         down to register_solib_event_probe.
2008         (svr4_create_solib_event_breakpoints): Add info parameter,
2009         pass it down to svr4_create_probe_breakpoints.
2010         (enable_break): Pass info down to
2011         svr4_create_solib_event_breakpoints.
2012         (svr4_solib_create_inferior_hook): Pass current_program_space to
2013         get_svr4_info.
2014         (svr4_clear_solib): Likewise.
2015
2016 2019-04-22  Pedro Alves  <palves@redhat.com>
2017
2018         * solib-svr4.c (svr4_free_objfile_observer): New.
2019         (probe_and_action::objfile): New field.
2020         (probes_table_htab_remove_objfile_probes)
2021         (probes_table_remove_objfile_probes): New functions.
2022         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2023         in the new probe_and_action.  Don't store the probe in 'lookup'.
2024         (svr4_create_probe_breakpoints): Pass objfile to
2025         register_solib_event_probe.
2026         (_initialize_svr4_solib): Register a free_objfile observer.
2027
2028 2019-04-19  Tom Tromey  <tom@tromey.com>
2029
2030         * common/queue.h: Remove.
2031
2032 2019-04-19  Tom Tromey  <tom@tromey.com>
2033
2034         * event-loop.c: Don't include "common/queue.h".
2035
2036 2019-04-19  Tom Tromey  <tom@tromey.com>
2037
2038         * remote.c (remote_target): Use delete.
2039         * remote-notif.h: Include <list>, not "common/queue.h".
2040         (notif_client_p): Remove typedef.
2041         (remote_notif_state): Add constructor, destructor, initializer.
2042         <notif_queue>: Now a std::list.
2043         (remote_notif_state_xfree): Don't declare.
2044         * remote-notif.c (remote_notif_process, handle_notification)
2045         (remote_notif_state_allocate): Update.
2046         (~remote_notif_state): Rename from remote_notif_state_xfree.
2047
2048 2019-04-19  Tom Tromey  <tom@tromey.com>
2049
2050         * symfile.c (reread_symbols): Update.
2051         * objfiles.c (objfile_register_static_link)
2052         (objfile_lookup_static_link): Update
2053         (~objfile) Don't delete static_links.
2054         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2055
2056 2019-04-19  Tom Tromey  <tom@tromey.com>
2057
2058         * type-stack.h (struct type_stack) <insert>: Constify string.
2059         * type-stack.c (type_stack::insert): Constify string.
2060         * gdbtypes.h (lookup_template_type): Update.
2061         (address_space_name_to_int): Update.
2062         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2063         const.
2064         (lookup_template_type): Make name const.
2065         * c-exp.y: Update rules.
2066         (lex_one_token, classify_name, classify_inner_name)
2067         (c_print_token): Update.
2068         * p-exp.y: Update rules.
2069         (yylex): Update.
2070         * f-exp.y: Update rules.
2071         (yylex): Update.
2072         * d-exp.y: Update rules.
2073         (lex_one_token, classify_name, classify_inner_name): Update.
2074         * parse.c (write_dollar_variable, copy_name): Return std::string.
2075         * parser-defs.h (copy_name): Change return type.
2076         * m2-exp.y: Update rules.
2077         (yylex): Update.
2078         * go-exp.y (lex_one_token): Update.
2079         Update rules.
2080         (classify_unsafe_function, classify_packaged_name)
2081         (classify_name, yylex): Update.
2082
2083 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2084
2085         * configure.ac: add --enable-source-highlight switch.
2086         * configure: Regenerate.
2087         * top.c (print_gdb_version): plumb --enable-source-highlight
2088         status to "show configuration".
2089
2090 2019-04-19  Tom Tromey  <tromey@adacore.com>
2091
2092         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2093         Check ADA_TYPE_P.
2094         (empty_record, ada_template_to_fixed_record_type_1)
2095         (template_to_static_fixed_type)
2096         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2097         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2098         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2099         macros.
2100
2101 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2102
2103         PR symtab/24423:
2104         * source.c (print_source_lines_base): Advance "iter" when a
2105         control character is seen.
2106
2107 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2108
2109         * inferior.h (struct infcall_suspend_state_deleter):
2110         Catch exception in destructor to avoid crash.
2111
2112 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2113
2114         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2115         close to the add_com "shell".
2116
2117 2019-04-18  Tom Tromey  <tromey@adacore.com>
2118
2119         * process-stratum-target.h (class process_stratum_target)
2120         <stratum>: Add "final".
2121
2122 2019-04-17  Tom Tromey  <tromey@adacore.com>
2123
2124         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2125         against nullptr before use.
2126
2127 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2128
2129         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2130
2131 2019-04-17  Jim Wilson  <jimw@sifive.com>
2132             Andrew Burgess  <andrew.burgess@embecosm.com>
2133
2134         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2135         code read might fail, assume 4-byte breakpoint in that case.
2136
2137 2019-04-15  Leszek Swirski  <leszeks@google.com>
2138
2139         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2140         rather than a hand-rolled POD check when checking for forced MEMORY
2141         classification.
2142
2143 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2144
2145         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2146         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2147         function.
2148         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2149         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2150         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2151         declaration.
2152
2153 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2154
2155         * aarch64-linux-nat.c
2156         (aarch64_linux_nat_target::thread_architecture): Add override.
2157         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2158         each VQ.
2159
2160 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2161
2162         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2163
2164 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2165
2166         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2167         target types of size 96-bits, add some additional comments, and
2168         check that the builtin type we found was the correct size.
2169
2170 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2171
2172         * utils.c (prompt_for_continue): Don't restore the styling at the
2173         end, as applied_style has the wrong value.  This fixes styling in
2174         long lists of file names that are interrupted by the "Continue?"
2175         prompt.
2176
2177 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2178
2179         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2180         * c-lang.c (c_language_defn): Likewise.
2181         (cplus_language_defn): Likewise.
2182         (asm_language_defn): Likewise.
2183         (minimal_language_defn): Likewise.
2184         * d-lang.c (d_language_defn): Likewise.
2185         * f-lang.c (f_language_defn): Likewise.
2186         * go-lang.c (go_language_defn): Likewise.
2187         * language.c (unknown_language_defn): Likewise.
2188         (auto_language_defn): Likewise.
2189         * language.h (struct language_defn): Remove la_magic field.
2190         (LANG_MAGIC): Delete.
2191         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2192         * objc-lang.c (objc_language_defn): Likewise.
2193         * opencl-lang.c (opencl_language_defn): Likewise.
2194         * p-lang.c (pascal_language_defn): Likewise.
2195         * rust-lang.c (rust_language_defn): Likewise.
2196
2197 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2198
2199         * riscv-tdep.c (riscv_type_align): New function.
2200         (riscv_type_alignment): Delete.
2201         (riscv_arg_location): Use 'type_align'.
2202         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2203
2204 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2205
2206         * gdbtypes.c (type_align): A struct with no non-static fields also
2207         has alignment of 1.
2208
2209 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2210
2211         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2212         component to 0.
2213         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2214         member.
2215         (riscv_struct_info::analyse): New implementation using new
2216         analyse_inner member function.
2217         (riscv_struct_info::field_offset): New member function.
2218         (riscv_struct_info::m_offsets): New member variable.
2219         (riscv_struct_info::analyse_inner): New private member function,
2220         takes the old implementation of riscv_struct_info::analyse but
2221         extended to track field offsets.
2222         (riscv_call_arg_struct): Update the struct folding special cases
2223         to handle cases where empty C++ structs, which are non-zero
2224         length, are found.
2225         (riscv_arg_location): Initialise the length of each location, a
2226         non-zero length now indicates the location is in use.
2227         (riscv_push_dummy_call): Allow for the first location having a
2228         non-zero offset when setting up arguments.
2229         (riscv_return_value): Likewise, but for return values.
2230
2231 2019-04-11  Tom Tromey  <tromey@adacore.com>
2232
2233         * utils.c (internal_vproblem): Make "msg" const.
2234
2235 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2236
2237         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2238         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2239         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2240         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2241
2242 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2243
2244         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2245         function.
2246         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2247         of amd64_collect_native_gregset.
2248         (amd64_linux_nat_target::store_registers): Likewise.
2249
2250 2019-04-10  Tom Tromey  <tom@tromey.com>
2251
2252         * symtab.c (lookup_global_symbol_from_objfile)
2253         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2254         * objfiles.h (class separate_debug_iterator): New.
2255         (class separate_debug_range): New.
2256         (struct objfile) <separate_debug_objfiles>: New method.
2257         (objfile_separate_debug_iterate): Don't declare.
2258         * objfiles.c (separate_debug_iterator::operator++): Rename from
2259         objfile_separate_debug_iterate.
2260         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2261         iterator.
2262         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2263         iterator.
2264
2265 2019-04-10  Tom Tromey  <tom@tromey.com>
2266
2267         * symfile.c (reread_symbols): Remove old comment.
2268         * objfiles.c (free_all_objfiles): Fix a typo.
2269
2270 2019-04-10  Tom Tromey  <tom@tromey.com>
2271
2272         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2273         * minsyms.c (lookup_minimal_symbol): Use foreach.
2274         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2275         (lookup_minimal_symbol_solib_trampoline): Likewise.
2276         * symfile.c (reread_symbols): Use foreach.
2277
2278 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2279             Tom Tromey  <tromey@adacore.com>
2280
2281         PR rust/24414:
2282         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2283         (rust_lex_int_test): Change "value" to be LONGEST.
2284         (rust_lex_tests): Add test for long integer literal.
2285
2286 2019-04-09  Tom Tromey  <tromey@adacore.com>
2287
2288         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2289         to bool.
2290         (extended_remote_target::attach): Update.
2291         (remote_target::remote_notice_new_inferior): Update.
2292         (remote_target::add_current_inferior_and_thread): Update.
2293         * inferior.c (exit_inferior_1): Use "false".
2294         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2295
2296 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2297
2298         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2299         the "start" command.
2300
2301 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2302
2303         * python/py-inferior.c (infpy_thread_from_thread_handle):
2304         Adjust comments to reflect renaming of thread_from_thread_handle
2305         to thread_from_handle.  Adjust keywords.  Fix type error message.
2306         (inferior_object_methods): Add thread_from_handle.  Retain
2307         thread_from_thread_handle, but mark it as deprecated.
2308
2309 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2310
2311         * gdbthread.h (find_thread_by_handle): Revise declaration.
2312         * thread.c (find_thread_by_handle): Likewise.  Adjust
2313         implementation too.
2314         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2315         support for buffer objects as handles.
2316
2317 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2318
2319         * python/py-infthread.c (thpy_thread_handle): New function.
2320         (thread_object_methods): Register thpy_thread_handle.
2321
2322 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2323
2324         * gdbthread.h (thread_to_thread_handle): Declare.
2325         * thread.c (gdbtypes.h): Include.
2326         (thread_to_thread_handle): New function.
2327
2328         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2329         (target_thread_info_to_thread_handle): Declare.
2330         * target.c (target_thread_info_to_thread_handle): New function.
2331         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2332         * target-delegates.c: Regenerate.
2333
2334         * linux-thread-db.c (class thread_db_target): Add method
2335         thread_info_to_thread_handle.
2336         (thread_db_target::thread_info_to_thread_handle): Define.
2337         * remote.c (class remote_target): Add new method
2338         thread_info_to_thread_handle.
2339         (remote_target::thread_info_to_thread_handle): Define.
2340
2341 2019-04-08  Pedro Alves  <palves@redhat.com>
2342
2343         * common/common-exceptions.c (throw_exception): Don't create
2344         named object to throw; throw directly.
2345         (throw_it): Likewise.  Don't initialize gdb_exception::message
2346         here, with new; pass FMT and AP to the ctor instead.
2347         * common/common-exceptions.h: Include <string>.
2348         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2349         const char *, va_list)): New ctor.  Use std::make_shared.
2350         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2351         errors)): Delete.
2352         (gdb_exception_error::gdb_exception_error(enum errors, const char
2353         *, va_list)): New.
2354         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2355         Add assertion.
2356         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2357         errors)): Delete.
2358         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2359         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2360         Add assertion.
2361
2362 2019-04-08  Tom Tromey  <tom@tromey.com>
2363
2364         * valops.c (value_rtti_indirect_type): Replace throw_exception
2365         with throw.
2366         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2367         with throw.
2368         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2369         throw.
2370         * target.c (target_translate_tls_address): Replace throw_exception
2371         with throw.
2372         * stack.c (frame_apply_command_count): Replace throw_exception
2373         with throw.
2374         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2375         throw.
2376         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2377         with throw.
2378         * rs6000-tdep.c (rs6000_frame_cache)
2379         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2380         * remote.c: Replace throw_exception with throw.
2381         * record-full.c (record_full_message, record_full_wait_1)
2382         (record_full_restore): Replace throw_exception with throw.
2383         * record-btrace.c:
2384         (get_thread_current_frame_id, record_btrace_start_replaying)
2385         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2386         (cmd_record_btrace_start): Replace throw_exception with throw.
2387         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2388         throw.
2389         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2390         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2391         * linespec.c:
2392         (find_linespec_symbols): Replace throw_exception with throw.
2393         * infrun.c (displaced_step_prepare, resume): Replace
2394         throw_exception with throw.
2395         * infcmd.c (post_create_inferior): Replace throw_exception with
2396         throw.
2397         * inf-loop.c (inferior_event_handler): Replace throw_exception
2398         with throw.
2399         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2400         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2401         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2402         (get_prev_frame_always, get_frame_pc_if_available)
2403         (get_frame_address_in_block_if_available, get_frame_language):
2404         Replace throw_exception with throw.
2405         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2406         throw_exception with throw.
2407         * eval.c (fetch_subexp_value, evaluate_var_value)
2408         (evaluate_funcall, evaluate_subexp_standard): Replace
2409         throw_exception with throw.
2410         * dwarf2loc.c (call_site_find_chain)
2411         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2412         Replace throw_exception with throw.
2413         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2414         with throw.
2415         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2416         throw.
2417         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2418         * completer.c (complete_line_internal): Replace throw_exception
2419         with throw.
2420         * compile/compile-object-run.c (compile_object_run): Replace
2421         throw_exception with throw.
2422         * cli/cli-script.c (process_next_line): Replace throw_exception
2423         with throw.
2424         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2425         (btrace_enable, btrace_maint_update_pt_packets): Replace
2426         throw_exception with throw.
2427         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2428         throw_exception with throw.
2429         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2430         throw_exception with throw.
2431         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2432         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2433         * aarch64-tdep.c (aarch64_make_prologue_cache)
2434         (aarch64_make_stub_cache): Replace throw_exception with throw.
2435
2436 2019-04-08  Tom Tromey  <tom@tromey.com>
2437
2438         * common/common-exceptions.c (throw_exception): Rename from
2439         throw_exception_cxx.  Remove old copy.  Make argument const.
2440         (throw_it): Create and throw exception objects directly.
2441         * common/common-exceptions.h (throw_exception): Make argument
2442         const.
2443         (struct gdb_exception_error): Add constructor.
2444         (struct gdb_exception_quit): Add constructor.
2445
2446 2019-04-08  Tom Tromey  <tom@tromey.com>
2447
2448         * common/common-exceptions.h (exception_rethrow): Don't declare.
2449         (TRY_SJLJ): Update comment.
2450         (TRY, CATCH, END_CATCH): Remove.
2451         * common/common-exceptions.c (exception_rethrow): Remove.
2452
2453 2019-04-08  Tom Tromey  <tom@tromey.com>
2454
2455         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2456         Remove.
2457         (gdb_exception_error): Rename from
2458         gdb_exception_RETURN_MASK_ERROR.
2459         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2460         (gdb_quit_bad_alloc): Update.
2461         * aarch64-tdep.c: Update.
2462         * ada-lang.c: Update.
2463         * ada-typeprint.c: Update.
2464         * ada-valprint.c: Update.
2465         * amd64-tdep.c: Update.
2466         * arch-utils.c: Update.
2467         * break-catch-throw.c: Update.
2468         * breakpoint.c: Update.
2469         * btrace.c: Update.
2470         * c-varobj.c: Update.
2471         * cli/cli-cmds.c: Update.
2472         * cli/cli-interp.c: Update.
2473         * cli/cli-script.c: Update.
2474         * common/common-exceptions.c: Update.
2475         * common/new-op.c: Update.
2476         * common/selftest.c: Update.
2477         * compile/compile-c-symbols.c: Update.
2478         * compile/compile-cplus-symbols.c: Update.
2479         * compile/compile-object-load.c: Update.
2480         * compile/compile-object-run.c: Update.
2481         * completer.c: Update.
2482         * corelow.c: Update.
2483         * cp-abi.c: Update.
2484         * cp-support.c: Update.
2485         * cp-valprint.c: Update.
2486         * darwin-nat.c: Update.
2487         * disasm-selftests.c: Update.
2488         * dtrace-probe.c: Update.
2489         * dwarf-index-cache.c: Update.
2490         * dwarf-index-write.c: Update.
2491         * dwarf2-frame-tailcall.c: Update.
2492         * dwarf2-frame.c: Update.
2493         * dwarf2loc.c: Update.
2494         * dwarf2read.c: Update.
2495         * eval.c: Update.
2496         * event-loop.c: Update.
2497         * event-top.c: Update.
2498         * exec.c: Update.
2499         * f-valprint.c: Update.
2500         * fbsd-tdep.c: Update.
2501         * frame-unwind.c: Update.
2502         * frame.c: Update.
2503         * gdbtypes.c: Update.
2504         * gnu-v3-abi.c: Update.
2505         * guile/guile-internal.h: Update.
2506         * guile/scm-block.c: Update.
2507         * guile/scm-breakpoint.c: Update.
2508         * guile/scm-cmd.c: Update.
2509         * guile/scm-disasm.c: Update.
2510         * guile/scm-frame.c: Update.
2511         * guile/scm-lazy-string.c: Update.
2512         * guile/scm-math.c: Update.
2513         * guile/scm-param.c: Update.
2514         * guile/scm-ports.c: Update.
2515         * guile/scm-pretty-print.c: Update.
2516         * guile/scm-symbol.c: Update.
2517         * guile/scm-symtab.c: Update.
2518         * guile/scm-type.c: Update.
2519         * guile/scm-value.c: Update.
2520         * i386-linux-tdep.c: Update.
2521         * i386-tdep.c: Update.
2522         * inf-loop.c: Update.
2523         * infcall.c: Update.
2524         * infcmd.c: Update.
2525         * infrun.c: Update.
2526         * jit.c: Update.
2527         * language.c: Update.
2528         * linespec.c: Update.
2529         * linux-fork.c: Update.
2530         * linux-nat.c: Update.
2531         * linux-tdep.c: Update.
2532         * linux-thread-db.c: Update.
2533         * main.c: Update.
2534         * mi/mi-cmd-break.c: Update.
2535         * mi/mi-cmd-stack.c: Update.
2536         * mi/mi-interp.c: Update.
2537         * mi/mi-main.c: Update.
2538         * objc-lang.c: Update.
2539         * p-valprint.c: Update.
2540         * parse.c: Update.
2541         * ppc-linux-tdep.c: Update.
2542         * printcmd.c: Update.
2543         * python/py-arch.c: Update.
2544         * python/py-breakpoint.c: Update.
2545         * python/py-cmd.c: Update.
2546         * python/py-finishbreakpoint.c: Update.
2547         * python/py-frame.c: Update.
2548         * python/py-framefilter.c: Update.
2549         * python/py-gdb-readline.c: Update.
2550         * python/py-inferior.c: Update.
2551         * python/py-infthread.c: Update.
2552         * python/py-lazy-string.c: Update.
2553         * python/py-linetable.c: Update.
2554         * python/py-objfile.c: Update.
2555         * python/py-param.c: Update.
2556         * python/py-prettyprint.c: Update.
2557         * python/py-progspace.c: Update.
2558         * python/py-record-btrace.c: Update.
2559         * python/py-record.c: Update.
2560         * python/py-symbol.c: Update.
2561         * python/py-type.c: Update.
2562         * python/py-unwind.c: Update.
2563         * python/py-utils.c: Update.
2564         * python/py-value.c: Update.
2565         * python/python.c: Update.
2566         * record-btrace.c: Update.
2567         * record-full.c: Update.
2568         * remote-fileio.c: Update.
2569         * remote.c: Update.
2570         * riscv-tdep.c: Update.
2571         * rs6000-aix-tdep.c: Update.
2572         * rs6000-tdep.c: Update.
2573         * rust-exp.y: Update.
2574         * rust-lang.c: Update.
2575         * s390-tdep.c: Update.
2576         * selftest-arch.c: Update.
2577         * solib-dsbt.c: Update.
2578         * solib-frv.c: Update.
2579         * solib-spu.c: Update.
2580         * solib-svr4.c: Update.
2581         * solib.c: Update.
2582         * sparc64-linux-tdep.c: Update.
2583         * stack.c: Update.
2584         * symfile-mem.c: Update.
2585         * symmisc.c: Update.
2586         * target.c: Update.
2587         * thread.c: Update.
2588         * top.c: Update.
2589         * tracefile-tfile.c: Update.
2590         * tui/tui.c: Update.
2591         * typeprint.c: Update.
2592         * unittests/cli-utils-selftests.c: Update.
2593         * unittests/parse-connection-spec-selftests.c: Update.
2594         * valops.c: Update.
2595         * valprint.c: Update.
2596         * value.c: Update.
2597         * varobj.c: Update.
2598         * windows-nat.c: Update.
2599         * x86-linux-nat.c: Update.
2600         * xml-support.c: Update.
2601
2602 2019-04-08  Tom Tromey  <tom@tromey.com>
2603
2604         * xml-support.c: Use C++ exception handling.
2605         * x86-linux-nat.c: Use C++ exception handling.
2606         * windows-nat.c: Use C++ exception handling.
2607         * varobj.c: Use C++ exception handling.
2608         * value.c: Use C++ exception handling.
2609         * valprint.c: Use C++ exception handling.
2610         * valops.c: Use C++ exception handling.
2611         * unittests/parse-connection-spec-selftests.c: Use C++ exception
2612         handling.
2613         * unittests/cli-utils-selftests.c: Use C++ exception handling.
2614         * typeprint.c: Use C++ exception handling.
2615         * tui/tui.c: Use C++ exception handling.
2616         * tracefile-tfile.c: Use C++ exception handling.
2617         * top.c: Use C++ exception handling.
2618         * thread.c: Use C++ exception handling.
2619         * target.c: Use C++ exception handling.
2620         * symmisc.c: Use C++ exception handling.
2621         * symfile-mem.c: Use C++ exception handling.
2622         * stack.c: Use C++ exception handling.
2623         * sparc64-linux-tdep.c: Use C++ exception handling.
2624         * solib.c: Use C++ exception handling.
2625         * solib-svr4.c: Use C++ exception handling.
2626         * solib-spu.c: Use C++ exception handling.
2627         * solib-frv.c: Use C++ exception handling.
2628         * solib-dsbt.c: Use C++ exception handling.
2629         * selftest-arch.c: Use C++ exception handling.
2630         * s390-tdep.c: Use C++ exception handling.
2631         * rust-lang.c: Use C++ exception handling.
2632         * rust-exp.y: Use C++ exception handling.
2633         * rs6000-tdep.c: Use C++ exception handling.
2634         * rs6000-aix-tdep.c: Use C++ exception handling.
2635         * riscv-tdep.c: Use C++ exception handling.
2636         * remote.c: Use C++ exception handling.
2637         * remote-fileio.c: Use C++ exception handling.
2638         * record-full.c: Use C++ exception handling.
2639         * record-btrace.c: Use C++ exception handling.
2640         * python/python.c: Use C++ exception handling.
2641         * python/py-value.c: Use C++ exception handling.
2642         * python/py-utils.c: Use C++ exception handling.
2643         * python/py-unwind.c: Use C++ exception handling.
2644         * python/py-type.c: Use C++ exception handling.
2645         * python/py-symbol.c: Use C++ exception handling.
2646         * python/py-record.c: Use C++ exception handling.
2647         * python/py-record-btrace.c: Use C++ exception handling.
2648         * python/py-progspace.c: Use C++ exception handling.
2649         * python/py-prettyprint.c: Use C++ exception handling.
2650         * python/py-param.c: Use C++ exception handling.
2651         * python/py-objfile.c: Use C++ exception handling.
2652         * python/py-linetable.c: Use C++ exception handling.
2653         * python/py-lazy-string.c: Use C++ exception handling.
2654         * python/py-infthread.c: Use C++ exception handling.
2655         * python/py-inferior.c: Use C++ exception handling.
2656         * python/py-gdb-readline.c: Use C++ exception handling.
2657         * python/py-framefilter.c: Use C++ exception handling.
2658         * python/py-frame.c: Use C++ exception handling.
2659         * python/py-finishbreakpoint.c: Use C++ exception handling.
2660         * python/py-cmd.c: Use C++ exception handling.
2661         * python/py-breakpoint.c: Use C++ exception handling.
2662         * python/py-arch.c: Use C++ exception handling.
2663         * printcmd.c: Use C++ exception handling.
2664         * ppc-linux-tdep.c: Use C++ exception handling.
2665         * parse.c: Use C++ exception handling.
2666         * p-valprint.c: Use C++ exception handling.
2667         * objc-lang.c: Use C++ exception handling.
2668         * mi/mi-main.c: Use C++ exception handling.
2669         * mi/mi-interp.c: Use C++ exception handling.
2670         * mi/mi-cmd-stack.c: Use C++ exception handling.
2671         * mi/mi-cmd-break.c: Use C++ exception handling.
2672         * main.c: Use C++ exception handling.
2673         * linux-thread-db.c: Use C++ exception handling.
2674         * linux-tdep.c: Use C++ exception handling.
2675         * linux-nat.c: Use C++ exception handling.
2676         * linux-fork.c: Use C++ exception handling.
2677         * linespec.c: Use C++ exception handling.
2678         * language.c: Use C++ exception handling.
2679         * jit.c: Use C++ exception handling.
2680         * infrun.c: Use C++ exception handling.
2681         * infcmd.c: Use C++ exception handling.
2682         * infcall.c: Use C++ exception handling.
2683         * inf-loop.c: Use C++ exception handling.
2684         * i386-tdep.c: Use C++ exception handling.
2685         * i386-linux-tdep.c: Use C++ exception handling.
2686         * guile/scm-value.c: Use C++ exception handling.
2687         * guile/scm-type.c: Use C++ exception handling.
2688         * guile/scm-symtab.c: Use C++ exception handling.
2689         * guile/scm-symbol.c: Use C++ exception handling.
2690         * guile/scm-pretty-print.c: Use C++ exception handling.
2691         * guile/scm-ports.c: Use C++ exception handling.
2692         * guile/scm-param.c: Use C++ exception handling.
2693         * guile/scm-math.c: Use C++ exception handling.
2694         * guile/scm-lazy-string.c: Use C++ exception handling.
2695         * guile/scm-frame.c: Use C++ exception handling.
2696         * guile/scm-disasm.c: Use C++ exception handling.
2697         * guile/scm-cmd.c: Use C++ exception handling.
2698         * guile/scm-breakpoint.c: Use C++ exception handling.
2699         * guile/scm-block.c: Use C++ exception handling.
2700         * guile/guile-internal.h: Use C++ exception handling.
2701         * gnu-v3-abi.c: Use C++ exception handling.
2702         * gdbtypes.c: Use C++ exception handling.
2703         * frame.c: Use C++ exception handling.
2704         * frame-unwind.c: Use C++ exception handling.
2705         * fbsd-tdep.c: Use C++ exception handling.
2706         * f-valprint.c: Use C++ exception handling.
2707         * exec.c: Use C++ exception handling.
2708         * event-top.c: Use C++ exception handling.
2709         * event-loop.c: Use C++ exception handling.
2710         * eval.c: Use C++ exception handling.
2711         * dwarf2read.c: Use C++ exception handling.
2712         * dwarf2loc.c: Use C++ exception handling.
2713         * dwarf2-frame.c: Use C++ exception handling.
2714         * dwarf2-frame-tailcall.c: Use C++ exception handling.
2715         * dwarf-index-write.c: Use C++ exception handling.
2716         * dwarf-index-cache.c: Use C++ exception handling.
2717         * dtrace-probe.c: Use C++ exception handling.
2718         * disasm-selftests.c: Use C++ exception handling.
2719         * darwin-nat.c: Use C++ exception handling.
2720         * cp-valprint.c: Use C++ exception handling.
2721         * cp-support.c: Use C++ exception handling.
2722         * cp-abi.c: Use C++ exception handling.
2723         * corelow.c: Use C++ exception handling.
2724         * completer.c: Use C++ exception handling.
2725         * compile/compile-object-run.c: Use C++ exception handling.
2726         * compile/compile-object-load.c: Use C++ exception handling.
2727         * compile/compile-cplus-symbols.c: Use C++ exception handling.
2728         * compile/compile-c-symbols.c: Use C++ exception handling.
2729         * common/selftest.c: Use C++ exception handling.
2730         * common/new-op.c: Use C++ exception handling.
2731         * cli/cli-script.c: Use C++ exception handling.
2732         * cli/cli-interp.c: Use C++ exception handling.
2733         * cli/cli-cmds.c: Use C++ exception handling.
2734         * c-varobj.c: Use C++ exception handling.
2735         * btrace.c: Use C++ exception handling.
2736         * breakpoint.c: Use C++ exception handling.
2737         * break-catch-throw.c: Use C++ exception handling.
2738         * arch-utils.c: Use C++ exception handling.
2739         * amd64-tdep.c: Use C++ exception handling.
2740         * ada-valprint.c: Use C++ exception handling.
2741         * ada-typeprint.c: Use C++ exception handling.
2742         * ada-lang.c: Use C++ exception handling.
2743         * aarch64-tdep.c: Use C++ exception handling.
2744
2745 2019-04-08  Tom Tromey  <tom@tromey.com>
2746
2747         * xml-support.c (gdb_xml_parser::parse): Update.
2748         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
2749         * value.c (show_convenience): Update.
2750         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
2751         (test_parse_flags_qcs): Update.
2752         * thread.c (thr_try_catch_cmd): Update.
2753         * target.c (target_translate_tls_address): Update.
2754         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
2755         (info_frame_command_core, frame_apply_command_count): Update.
2756         * rust-exp.y (rust_lex_exception_test): Update.
2757         * riscv-tdep.c (riscv_print_one_register_info): Update.
2758         * remote.c (remote_target::enable_btrace): Update.
2759         * record-btrace.c (record_btrace_enable_warn): Update.
2760         * python/py-utils.c (gdbpy_convert_exception): Update.
2761         * printcmd.c (do_one_display, print_variable_and_value): Update.
2762         * mi/mi-main.c (mi_print_exception): Update.
2763         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
2764         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
2765         * linux-nat.c (linux_nat_target::attach): Update.
2766         * linux-fork.c (class scoped_switch_fork_info): Update.
2767         * infrun.c (displaced_step_prepare): Update.
2768         * infcall.c (call_function_by_hand_dummy): Update.
2769         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
2770         * gnu-v3-abi.c (print_one_vtable): Update.
2771         * frame.c (get_prev_frame_always): Update.
2772         * f-valprint.c (info_common_command_for_block): Update.
2773         * exec.c (try_open_exec_file): Update.
2774         * exceptions.c (print_exception, exception_print)
2775         (exception_fprintf, exception_print_same): Update.
2776         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
2777         * dwarf-index-cache.c (index_cache::store)
2778         (index_cache::lookup_gdb_index): Update.
2779         * darwin-nat.c (maybe_cache_shell): Update.
2780         * cp-valprint.c (cp_print_value_fields): Update.
2781         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
2782         (gcc_cplus_symbol_address): Update.
2783         * compile/compile-c-symbols.c (gcc_convert_symbol)
2784         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
2785         * common/selftest.c: Update.
2786         * common/common-exceptions.h (struct gdb_exception) <message>: Now
2787         a std::string.
2788         (exception_try_scope_entry, exception_try_scope_exit): Don't
2789         declare.
2790         (struct exception_try_scope): Remove.
2791         (TRY): Don't use exception_try_scope.
2792         (struct gdb_exception): Add constructor, operator=.
2793         <what>: New method.
2794         (struct gdb_exception_RETURN_MASK_ALL)
2795         (struct gdb_exception_RETURN_MASK_ERROR)
2796         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
2797         (struct gdb_quit_bad_alloc): Update.
2798         * common/common-exceptions.c (exception_none): Change
2799         initializer.
2800         (struct catcher) <state, exception>: Initialize inline.
2801         <prev>: Remove member.
2802         (current_catcher): Remove.
2803         (catchers): New global.
2804         (exceptions_state_mc_init): Simplify.
2805         (catcher_pop): Remove.
2806         (exceptions_state_mc, exceptions_state_mc_catch): Update.
2807         (try_scope_depth, exception_try_scope_entry)
2808         (exception_try_scope_exit): Remove.
2809         (throw_exception_sjlj): Update.
2810         (exception_messages, exception_messages_size): Remove.
2811         (throw_it): Simplify.
2812         (gdb_exception_sliced_copy): Remove.
2813         (throw_exception_cxx): Update.
2814         * cli/cli-script.c (script_from_file): Update.
2815         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
2816         Update.
2817         * ada-valprint.c (ada_val_print): Update.
2818         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
2819         (create_excep_cond_exprs): Update.
2820
2821 2019-04-08  Tom Tromey  <tom@tromey.com>
2822
2823         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
2824         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
2825         (TRY, CATCH, END_CATCH): Remove some definitions.
2826         * common/common-exceptions.c: Don't use GDB_XCPT.
2827         (catcher_list_size): Remove.
2828         (throw_exception, throw_it): Simplify.
2829
2830 2019-04-05  Tom Tromey  <tom@tromey.com>
2831
2832         Revert the header-sorting patch.
2833         * ft32-tdep.c: Revert.
2834         * frv-tdep.c: Revert.
2835         * frv-linux-tdep.c: Revert.
2836         * frame.c: Revert.
2837         * frame-unwind.c: Revert.
2838         * frame-base.c: Revert.
2839         * fork-child.c: Revert.
2840         * findvar.c: Revert.
2841         * findcmd.c: Revert.
2842         * filesystem.c: Revert.
2843         * filename-seen-cache.h: Revert.
2844         * filename-seen-cache.c: Revert.
2845         * fbsd-tdep.c: Revert.
2846         * fbsd-nat.h: Revert.
2847         * fbsd-nat.c: Revert.
2848         * f-valprint.c: Revert.
2849         * f-typeprint.c: Revert.
2850         * f-lang.c: Revert.
2851         * extension.h: Revert.
2852         * extension.c: Revert.
2853         * extension-priv.h: Revert.
2854         * expprint.c: Revert.
2855         * exec.h: Revert.
2856         * exec.c: Revert.
2857         * exceptions.c: Revert.
2858         * event-top.c: Revert.
2859         * event-loop.c: Revert.
2860         * eval.c: Revert.
2861         * elfread.c: Revert.
2862         * dwarf2read.h: Revert.
2863         * dwarf2read.c: Revert.
2864         * dwarf2loc.c: Revert.
2865         * dwarf2expr.h: Revert.
2866         * dwarf2expr.c: Revert.
2867         * dwarf2-frame.c: Revert.
2868         * dwarf2-frame-tailcall.c: Revert.
2869         * dwarf-index-write.h: Revert.
2870         * dwarf-index-write.c: Revert.
2871         * dwarf-index-common.c: Revert.
2872         * dwarf-index-cache.h: Revert.
2873         * dwarf-index-cache.c: Revert.
2874         * dummy-frame.c: Revert.
2875         * dtrace-probe.c: Revert.
2876         * disasm.h: Revert.
2877         * disasm.c: Revert.
2878         * disasm-selftests.c: Revert.
2879         * dictionary.c: Revert.
2880         * dicos-tdep.c: Revert.
2881         * demangle.c: Revert.
2882         * dcache.h: Revert.
2883         * dcache.c: Revert.
2884         * darwin-nat.h: Revert.
2885         * darwin-nat.c: Revert.
2886         * darwin-nat-info.c: Revert.
2887         * d-valprint.c: Revert.
2888         * d-namespace.c: Revert.
2889         * d-lang.c: Revert.
2890         * ctf.c: Revert.
2891         * csky-tdep.c: Revert.
2892         * csky-linux-tdep.c: Revert.
2893         * cris-tdep.c: Revert.
2894         * cris-linux-tdep.c: Revert.
2895         * cp-valprint.c: Revert.
2896         * cp-support.c: Revert.
2897         * cp-namespace.c: Revert.
2898         * cp-abi.c: Revert.
2899         * corelow.c: Revert.
2900         * corefile.c: Revert.
2901         * continuations.c: Revert.
2902         * completer.h: Revert.
2903         * completer.c: Revert.
2904         * complaints.c: Revert.
2905         * coffread.c: Revert.
2906         * coff-pe-read.c: Revert.
2907         * cli-out.h: Revert.
2908         * cli-out.c: Revert.
2909         * charset.c: Revert.
2910         * c-varobj.c: Revert.
2911         * c-valprint.c: Revert.
2912         * c-typeprint.c: Revert.
2913         * c-lang.c: Revert.
2914         * buildsym.c: Revert.
2915         * buildsym-legacy.c: Revert.
2916         * build-id.h: Revert.
2917         * build-id.c: Revert.
2918         * btrace.c: Revert.
2919         * bsd-uthread.c: Revert.
2920         * breakpoint.h: Revert.
2921         * breakpoint.c: Revert.
2922         * break-catch-throw.c: Revert.
2923         * break-catch-syscall.c: Revert.
2924         * break-catch-sig.c: Revert.
2925         * blockframe.c: Revert.
2926         * block.c: Revert.
2927         * bfin-tdep.c: Revert.
2928         * bfin-linux-tdep.c: Revert.
2929         * bfd-target.c: Revert.
2930         * bcache.c: Revert.
2931         * ax-general.c: Revert.
2932         * ax-gdb.h: Revert.
2933         * ax-gdb.c: Revert.
2934         * avr-tdep.c: Revert.
2935         * auxv.c: Revert.
2936         * auto-load.c: Revert.
2937         * arm-wince-tdep.c: Revert.
2938         * arm-tdep.c: Revert.
2939         * arm-symbian-tdep.c: Revert.
2940         * arm-pikeos-tdep.c: Revert.
2941         * arm-obsd-tdep.c: Revert.
2942         * arm-nbsd-tdep.c: Revert.
2943         * arm-nbsd-nat.c: Revert.
2944         * arm-linux-tdep.c: Revert.
2945         * arm-linux-nat.c: Revert.
2946         * arm-fbsd-tdep.c: Revert.
2947         * arm-fbsd-nat.c: Revert.
2948         * arm-bsd-tdep.c: Revert.
2949         * arch-utils.c: Revert.
2950         * arc-tdep.c: Revert.
2951         * arc-newlib-tdep.c: Revert.
2952         * annotate.h: Revert.
2953         * annotate.c: Revert.
2954         * amd64-windows-tdep.c: Revert.
2955         * amd64-windows-nat.c: Revert.
2956         * amd64-tdep.c: Revert.
2957         * amd64-sol2-tdep.c: Revert.
2958         * amd64-obsd-tdep.c: Revert.
2959         * amd64-obsd-nat.c: Revert.
2960         * amd64-nbsd-tdep.c: Revert.
2961         * amd64-nbsd-nat.c: Revert.
2962         * amd64-nat.c: Revert.
2963         * amd64-linux-tdep.c: Revert.
2964         * amd64-linux-nat.c: Revert.
2965         * amd64-fbsd-tdep.c: Revert.
2966         * amd64-fbsd-nat.c: Revert.
2967         * amd64-dicos-tdep.c: Revert.
2968         * amd64-darwin-tdep.c: Revert.
2969         * amd64-bsd-nat.c: Revert.
2970         * alpha-tdep.c: Revert.
2971         * alpha-obsd-tdep.c: Revert.
2972         * alpha-nbsd-tdep.c: Revert.
2973         * alpha-mdebug-tdep.c: Revert.
2974         * alpha-linux-tdep.c: Revert.
2975         * alpha-linux-nat.c: Revert.
2976         * alpha-bsd-tdep.c: Revert.
2977         * alpha-bsd-nat.c: Revert.
2978         * aix-thread.c: Revert.
2979         * agent.c: Revert.
2980         * addrmap.c: Revert.
2981         * ada-varobj.c: Revert.
2982         * ada-valprint.c: Revert.
2983         * ada-typeprint.c: Revert.
2984         * ada-tasks.c: Revert.
2985         * ada-lang.c: Revert.
2986         * aarch64-tdep.c: Revert.
2987         * aarch64-ravenscar-thread.c: Revert.
2988         * aarch64-newlib-tdep.c: Revert.
2989         * aarch64-linux-tdep.c: Revert.
2990         * aarch64-linux-nat.c: Revert.
2991         * aarch64-fbsd-tdep.c: Revert.
2992         * aarch64-fbsd-nat.c: Revert.
2993         * aarch32-linux-nat.c: Revert.
2994
2995 2019-04-05  Tom Tromey  <tom@tromey.com>
2996
2997         * ft32-tdep.c: Sort headers.
2998         * frv-tdep.c: Sort headers.
2999         * frv-linux-tdep.c: Sort headers.
3000         * frame.c: Sort headers.
3001         * frame-unwind.c: Sort headers.
3002         * frame-base.c: Sort headers.
3003         * fork-child.c: Sort headers.
3004         * findvar.c: Sort headers.
3005         * findcmd.c: Sort headers.
3006         * filesystem.c: Sort headers.
3007         * filename-seen-cache.h: Sort headers.
3008         * filename-seen-cache.c: Sort headers.
3009         * fbsd-tdep.c: Sort headers.
3010         * fbsd-nat.h: Sort headers.
3011         * fbsd-nat.c: Sort headers.
3012         * f-valprint.c: Sort headers.
3013         * f-typeprint.c: Sort headers.
3014         * f-lang.c: Sort headers.
3015         * extension.h: Sort headers.
3016         * extension.c: Sort headers.
3017         * extension-priv.h: Sort headers.
3018         * expprint.c: Sort headers.
3019         * exec.h: Sort headers.
3020         * exec.c: Sort headers.
3021         * exceptions.c: Sort headers.
3022         * event-top.c: Sort headers.
3023         * event-loop.c: Sort headers.
3024         * eval.c: Sort headers.
3025         * elfread.c: Sort headers.
3026         * dwarf2read.h: Sort headers.
3027         * dwarf2read.c: Sort headers.
3028         * dwarf2loc.c: Sort headers.
3029         * dwarf2expr.h: Sort headers.
3030         * dwarf2expr.c: Sort headers.
3031         * dwarf2-frame.c: Sort headers.
3032         * dwarf2-frame-tailcall.c: Sort headers.
3033         * dwarf-index-write.h: Sort headers.
3034         * dwarf-index-write.c: Sort headers.
3035         * dwarf-index-common.c: Sort headers.
3036         * dwarf-index-cache.h: Sort headers.
3037         * dwarf-index-cache.c: Sort headers.
3038         * dummy-frame.c: Sort headers.
3039         * dtrace-probe.c: Sort headers.
3040         * disasm.h: Sort headers.
3041         * disasm.c: Sort headers.
3042         * disasm-selftests.c: Sort headers.
3043         * dictionary.c: Sort headers.
3044         * dicos-tdep.c: Sort headers.
3045         * demangle.c: Sort headers.
3046         * dcache.h: Sort headers.
3047         * dcache.c: Sort headers.
3048         * darwin-nat.h: Sort headers.
3049         * darwin-nat.c: Sort headers.
3050         * darwin-nat-info.c: Sort headers.
3051         * d-valprint.c: Sort headers.
3052         * d-namespace.c: Sort headers.
3053         * d-lang.c: Sort headers.
3054         * ctf.c: Sort headers.
3055         * csky-tdep.c: Sort headers.
3056         * csky-linux-tdep.c: Sort headers.
3057         * cris-tdep.c: Sort headers.
3058         * cris-linux-tdep.c: Sort headers.
3059         * cp-valprint.c: Sort headers.
3060         * cp-support.c: Sort headers.
3061         * cp-namespace.c: Sort headers.
3062         * cp-abi.c: Sort headers.
3063         * corelow.c: Sort headers.
3064         * corefile.c: Sort headers.
3065         * continuations.c: Sort headers.
3066         * completer.h: Sort headers.
3067         * completer.c: Sort headers.
3068         * complaints.c: Sort headers.
3069         * coffread.c: Sort headers.
3070         * coff-pe-read.c: Sort headers.
3071         * cli-out.h: Sort headers.
3072         * cli-out.c: Sort headers.
3073         * charset.c: Sort headers.
3074         * c-varobj.c: Sort headers.
3075         * c-valprint.c: Sort headers.
3076         * c-typeprint.c: Sort headers.
3077         * c-lang.c: Sort headers.
3078         * buildsym.c: Sort headers.
3079         * buildsym-legacy.c: Sort headers.
3080         * build-id.h: Sort headers.
3081         * build-id.c: Sort headers.
3082         * btrace.c: Sort headers.
3083         * bsd-uthread.c: Sort headers.
3084         * breakpoint.h: Sort headers.
3085         * breakpoint.c: Sort headers.
3086         * break-catch-throw.c: Sort headers.
3087         * break-catch-syscall.c: Sort headers.
3088         * break-catch-sig.c: Sort headers.
3089         * blockframe.c: Sort headers.
3090         * block.c: Sort headers.
3091         * bfin-tdep.c: Sort headers.
3092         * bfin-linux-tdep.c: Sort headers.
3093         * bfd-target.c: Sort headers.
3094         * bcache.c: Sort headers.
3095         * ax-general.c: Sort headers.
3096         * ax-gdb.h: Sort headers.
3097         * ax-gdb.c: Sort headers.
3098         * avr-tdep.c: Sort headers.
3099         * auxv.c: Sort headers.
3100         * auto-load.c: Sort headers.
3101         * arm-wince-tdep.c: Sort headers.
3102         * arm-tdep.c: Sort headers.
3103         * arm-symbian-tdep.c: Sort headers.
3104         * arm-pikeos-tdep.c: Sort headers.
3105         * arm-obsd-tdep.c: Sort headers.
3106         * arm-nbsd-tdep.c: Sort headers.
3107         * arm-nbsd-nat.c: Sort headers.
3108         * arm-linux-tdep.c: Sort headers.
3109         * arm-linux-nat.c: Sort headers.
3110         * arm-fbsd-tdep.c: Sort headers.
3111         * arm-fbsd-nat.c: Sort headers.
3112         * arm-bsd-tdep.c: Sort headers.
3113         * arch-utils.c: Sort headers.
3114         * arc-tdep.c: Sort headers.
3115         * arc-newlib-tdep.c: Sort headers.
3116         * annotate.h: Sort headers.
3117         * annotate.c: Sort headers.
3118         * amd64-windows-tdep.c: Sort headers.
3119         * amd64-windows-nat.c: Sort headers.
3120         * amd64-tdep.c: Sort headers.
3121         * amd64-sol2-tdep.c: Sort headers.
3122         * amd64-obsd-tdep.c: Sort headers.
3123         * amd64-obsd-nat.c: Sort headers.
3124         * amd64-nbsd-tdep.c: Sort headers.
3125         * amd64-nbsd-nat.c: Sort headers.
3126         * amd64-nat.c: Sort headers.
3127         * amd64-linux-tdep.c: Sort headers.
3128         * amd64-linux-nat.c: Sort headers.
3129         * amd64-fbsd-tdep.c: Sort headers.
3130         * amd64-fbsd-nat.c: Sort headers.
3131         * amd64-dicos-tdep.c: Sort headers.
3132         * amd64-darwin-tdep.c: Sort headers.
3133         * amd64-bsd-nat.c: Sort headers.
3134         * alpha-tdep.c: Sort headers.
3135         * alpha-obsd-tdep.c: Sort headers.
3136         * alpha-nbsd-tdep.c: Sort headers.
3137         * alpha-mdebug-tdep.c: Sort headers.
3138         * alpha-linux-tdep.c: Sort headers.
3139         * alpha-linux-nat.c: Sort headers.
3140         * alpha-bsd-tdep.c: Sort headers.
3141         * alpha-bsd-nat.c: Sort headers.
3142         * aix-thread.c: Sort headers.
3143         * agent.c: Sort headers.
3144         * addrmap.c: Sort headers.
3145         * ada-varobj.c: Sort headers.
3146         * ada-valprint.c: Sort headers.
3147         * ada-typeprint.c: Sort headers.
3148         * ada-tasks.c: Sort headers.
3149         * ada-lang.c: Sort headers.
3150         * aarch64-tdep.c: Sort headers.
3151         * aarch64-ravenscar-thread.c: Sort headers.
3152         * aarch64-newlib-tdep.c: Sort headers.
3153         * aarch64-linux-tdep.c: Sort headers.
3154         * aarch64-linux-nat.c: Sort headers.
3155         * aarch64-fbsd-tdep.c: Sort headers.
3156         * aarch64-fbsd-nat.c: Sort headers.
3157         * aarch32-linux-nat.c: Sort headers.
3158
3159 2019-04-04  Tom Tromey  <tom@tromey.com>
3160
3161         * varobj.c (varobj_create): Update.
3162         * rust-exp.y (struct rust_parser) <update_innermost_block,
3163         lookup_symbol>: New methods.
3164         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3165         Rename.
3166         (rust_parser::rust_lookup_type)
3167         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3168         * printcmd.c (display_command, do_one_display): Update.
3169         * parser-defs.h (struct parser_state) <parser_state>: Add
3170         "tracker" parameter.
3171         (block_tracker): New member.
3172         (class innermost_block_tracker) <innermost_block_tracker>: Add
3173         "types" parameter.
3174         <reset>: Remove method.
3175         (innermost_block): Don't declare.
3176         (null_post_parser): Update.
3177         * parse.c (innermost_block): Remove global.
3178         (write_dollar_variable): Update.
3179         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3180         Remove "tracker_types" parameter.
3181         (parse_expression): Add "tracker" parameter.
3182         (parse_expression_for_completion): Update.
3183         (null_post_parser): Add "tracker" parameter.
3184         * p-exp.y: Update rules.
3185         * m2-exp.y: Update rules.
3186         * language.h (struct language_defn) <la_post_parser>: Add
3187         "tracker" parameter.
3188         * go-exp.y: Update rules.
3189         * f-exp.y: Update rules.
3190         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3191         parameter.
3192         * d-exp.y: Update rules.
3193         * c-exp.y: Update rules.
3194         * breakpoint.c (set_breakpoint_condition): Create an
3195         innermost_block_tracker.
3196         (watch_command_1): Likewise.
3197         * ada-lang.c (resolve): Add "tracker" parameter.
3198         (resolve_subexp): Likewise.
3199         * ada-exp.y (write_var_from_sym): Update.
3200
3201 2019-04-04  Tom Tromey  <tom@tromey.com>
3202
3203         * type-stack.h: New file.
3204         * type-stack.c: New file.
3205         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3206         type-stack.h.
3207         (insert_into_type_stack, insert_type, push_type, push_type_int)
3208         (insert_type_address_space, pop_type, pop_type_int)
3209         (pop_typelist, pop_type_stack, append_type_stack)
3210         (push_type_stack, get_type_stack, push_typelist)
3211         (follow_type_instance_flags, follow_types): Don't declare.
3212         * parse.c (type_stack): Remove global.
3213         (parse_exp_in_context): Update.
3214         (insert_into_type_stack, insert_type, push_type, push_type_int)
3215         (insert_type_address_space, pop_type, pop_type_int)
3216         (pop_typelist, pop_type_stack, append_type_stack)
3217         (push_type_stack, get_type_stack, push_typelist)
3218         (follow_type_instance_flags, follow_types): Remove (moved to
3219         type-stack.c).
3220         * f-exp.y (type_stack): New global.
3221         Update rules.
3222         (push_kind_type, f_parse): Update.
3223         * d-exp.y (type_stack): New global.
3224         Update rules.
3225         (d_parse): Update.
3226         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3227         Update rules.
3228         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3229         (HFILES_NO_SRCDIR): Add type-stack.h.
3230
3231 2019-04-04  Tom Tromey  <tom@tromey.com>
3232
3233         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3234         (rust_parser::convert_ast_to_expression, rust_parse)
3235         (rust_lex_test_completion, rust_lex_tests): Update.
3236         * parser-defs.h (struct expr_completion_state): New.
3237         (struct parser_state) <parser_state>: Add completion parameter.
3238         <mark_struct_expression, mark_completion_tag>: New methods.
3239         <parse_completion, m_completion_state>: New members.
3240         (prefixify_expression, null_post_parser): Update.
3241         (mark_struct_expression, mark_completion_tag): Don't declare.
3242         * parse.c (parse_completion, expout_last_struct)
3243         (expout_tag_completion_type, expout_completion_name): Remove
3244         globals.
3245         (parser_state::mark_struct_expression)
3246         (parser_state::mark_completion_tag): Now methods.
3247         (prefixify_expression): Add last_struct parameter.
3248         (prefixify_subexp): Likewise.
3249         (parse_exp_1): Update.
3250         (parse_exp_in_context): Add cstate parameter.  Update.
3251         (parse_expression_for_completion): Create an
3252         expr_completion_state.
3253         (null_post_parser): Add "completion" parameter.
3254         * p-exp.y: Update rules.
3255         (yylex): Update.
3256         * language.h (struct language_defn) <la_post_parser>: Add
3257         "completing" parameter.
3258         * go-exp.y: Update rules.
3259         (lex_one_token): Update.
3260         * expression.h (parse_completion): Don't declare.
3261         * d-exp.y: Update rules.
3262         (lex_one_token): Update rules.
3263         * c-exp.y: Update rules.
3264         (lex_one_token): Update.
3265         * ada-lang.c (resolve): Add "parse_completion" parameter.
3266         (resolve_subexp): Likewise.
3267         (ada_resolve_function): Likewise.
3268
3269 2019-04-04  Tom Tromey  <tom@tromey.com>
3270
3271         * parser-defs.h (struct parser_state) <start_arglist,
3272         end_arglist>: New methods.
3273         <arglist_len, m_funcall_chain>: New members.
3274         (arglist_len, start_arglist, end_arglist): Don't declare.
3275         * parse.c (arglist_len, funcall_chain): Remove global.
3276         (start_arglist, end_arglist): Remove functions.
3277         (parse_exp_in_context): Update.
3278         * p-exp.y: Update rules.
3279         * m2-exp.y: Update rules.
3280         * go-exp.y: Update rules.
3281         * f-exp.y: Update rules.
3282         * d-exp.y: Update rules.
3283         * c-exp.y: Update rules.
3284
3285 2019-04-04  Tom Tromey  <tom@tromey.com>
3286
3287         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3288         lex_operator, push_back>: New methods.
3289         Update all rules.
3290         (rust_parser::lex_hex, lex_escape): Rename and update.
3291         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3292         (rust_parser::lex_operator): Rename and update.
3293         (rust_parser::lex_number, rustyylex, rustyyerror)
3294         (rust_lex_test_init, rust_lex_test_sequence)
3295         (rust_lex_test_push_back, rust_lex_tests): Update.
3296         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3297         parameter.
3298         <lexptr, prev_lexptr>: New members.
3299         (lexptr, prev_lexptr): Don't declare.
3300         * parse.c (lexptr, prev_lexptr): Remove globals.
3301         (parse_exp_in_context): Update.
3302         * p-exp.y (yylex, yyerror): Update.
3303         * m2-exp.y (parse_number, yylex, yyerror): Update.
3304         * go-exp.y (lex_one_token, yyerror): Update.
3305         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3306         * d-exp.y (lex_one_token, yyerror): Update.
3307         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3308         (lex_one_token, yyerror): Update.
3309         * ada-lex.l (YY_INPUT): Update.
3310         (rewind_to_char): Update.
3311         * ada-exp.y (yyerror): Update.
3312
3313 2019-04-04  Tom Tromey  <tom@tromey.com>
3314
3315         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3316         * parser-defs.h (struct parser_state) <parser_state>: Add new
3317         parameter.
3318         <comma_terminates>: New member.
3319         (comma_terminates): Don't declare global.
3320         * parse.c (comma_terminates): Remove global.
3321         (parse_exp_in_context): Update.
3322         * p-exp.y (yylex): Update.
3323         * m2-exp.y (yylex): Update.
3324         * go-exp.y (lex_one_token): Update.
3325         * f-exp.y (yylex): Update.
3326         * d-exp.y (lex_one_token): Update.
3327         * c-exp.y (lex_one_token): Update.
3328         * ada-lex.l: Update.
3329
3330 2019-04-04  Tom Tromey  <tom@tromey.com>
3331
3332         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3333         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3334         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3335         * parser-defs.h (paren_depth): Don't declare.
3336         * parse.c (paren_depth): Remove global.
3337         (parse_exp_in_context): Update.
3338         * p-exp.y (paren_depth): New global.
3339         (pascal_parse): Initialize it.
3340         * m2-exp.y (paren_depth): New global.
3341         (m2_parse): Initialize it.
3342         * go-exp.y (paren_depth): New global.
3343         (go_parse): Initialize it.
3344         * f-exp.y (paren_depth): New global.
3345         (f_parse): Initialize it.
3346         * d-exp.y (paren_depth): New global.
3347         (d_parse): Initialize it.
3348         * c-exp.y (paren_depth): New global.
3349         (c_parse): Initialize it.
3350         * ada-lex.l (paren_depth): New global.
3351         (lexer_init): Initialize it.
3352
3353 2019-04-04  Tom Tromey  <tom@tromey.com>
3354
3355         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3356         (rust_parser::convert_ast_to_type)
3357         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3358         * parser-defs.h (struct parser_state) <parser_state>: Add
3359         parameters.  Initialize new members.
3360         <expression_context_block, expression_context_pc>: New members.
3361         * parse.c (expression_context_block, expression_context_pc):
3362         Remove globals.
3363         (parse_exp_in_context): Update.
3364         * p-exp.y: Update all rules.
3365         (yylex): Update.
3366         * m2-exp.y: Update all rules.
3367         (yylex): Update.
3368         * go-exp.y (yylex): Update.
3369         * f-exp.y (yylex): Update.
3370         * d-exp.y: Update all rules.
3371         (yylex): Update.
3372         * c-exp.y: Update all rules.
3373         (lex_one_token, classify_name, yylex, c_parse): Update.
3374         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3375
3376 2019-04-04  Tom Tromey  <tom@tromey.com>
3377
3378         * gdbarch.h, gdbarch.c: Rebuild.
3379         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3380         * stap-probe.h:
3381         (struct stap_parse_info): Replace "parser_state" with
3382         "expr_builder".
3383         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3384         (parser_state): New class.
3385         * parse.c (expr_builder): Rename.
3386         (expr_builder::release): Rename.
3387         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3388         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3389         (write_exp_elt_longcst, write_exp_elt_floatcst)
3390         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3391         (write_exp_string_vector, write_exp_bitstring)
3392         (write_exp_msymbol, mark_struct_expression)
3393         (write_dollar_variable)
3394         (insert_type_address_space, increase_expout_size): Replace
3395         "parser_state" with "expr_builder".
3396         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3397         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3398         "parser_state" with "expr_builder".
3399
3400 2019-04-04  Tom Tromey  <tom@tromey.com>
3401
3402         * rust-exp.y: Replace "parse_language" with method call.
3403         * p-exp.y:
3404         (yylex): Replace "parse_language" with method call.
3405         * m2-exp.y:
3406         (yylex): Replace "parse_language" with method call.
3407         * go-exp.y (classify_name): Replace "parse_language" with method
3408         call.
3409         * f-exp.y (yylex): Replace "parse_language" with method call.
3410         * d-exp.y (lex_one_token): Replace "parse_language" with method
3411         call.
3412         * c-exp.y:
3413         (lex_one_token, classify_name, yylex): Replace "parse_language"
3414         with method call.
3415         * ada-exp.y (find_primitive_type, type_char)
3416         (type_system_address): Replace "parse_language" with method call.
3417
3418 2019-04-04  Tom Tromey  <tom@tromey.com>
3419
3420         * rust-exp.y: Replace "parse_gdbarch" with method call.
3421         * parse.c (write_dollar_variable, insert_type_address_space):
3422         Replace "parse_gdbarch" with method call.
3423         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3424         call.
3425         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3426         call.
3427         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3428         "parse_gdbarch" with method call.
3429         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3430         with method call.
3431         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3432         "parse_gdbarch" with method call.
3433         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3434         "parse_gdbarch" with method call.
3435         * c-exp.y (parse_type, parse_number, classify_name): Replace
3436         "parse_gdbarch" with method call.
3437         * ada-lex.l: Replace "parse_gdbarch" with method call.
3438         * ada-exp.y (parse_type, find_primitive_type, type_char)
3439         (type_system_address): Replace "parse_gdbarch" with method call.
3440
3441 2019-04-04  Tom Tromey  <tom@tromey.com>
3442
3443         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3444         * stap-probe.c (stap_parse_argument): Update.
3445         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3446         initial_size parameter.
3447         * rust-exp.y (rust_lex_tests): Update.
3448         * parse.c (parser_state): Update.
3449         (parse_exp_in_context): Update.
3450         * parser-defs.h (struct parser_state) <parser_state>: Remove
3451         "initial_size" parameter.
3452
3453 2019-04-04  Tom Tromey  <tom@tromey.com>
3454
3455         * parser-defs.h (increase_expout_size): Don't declare.
3456         * parse.c (increase_expout_size): Now static.
3457
3458 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3459
3460         * gnu-nat.c (gnu_nat_target::wait): Fix
3461         target_waitstatus_to_string call.
3462
3463 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3464
3465         * eval.c (evaluate_subexp_standard): Handle internal functions
3466         during Fortran function call handling.
3467
3468 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3469
3470         * NEWS: Mention new internal functions.
3471         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3472         (read_base_type): Use dwarf2_init_complex_target_type.
3473         * value.c (creal_internal_fn): New function.
3474         (cimag_internal_fn): New function.
3475         (_initialize_values): Register new internal functions.
3476
3477 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3478
3479         * infrun.c (stop_all_threads): If debug_infrun, always
3480         trace the wait status after wait_one, using
3481         target_waitstatus_to_string and target_pid_to_str.
3482         (handle_inferior_event): Replace various trace of
3483         wait status kind by a single trace.
3484         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3485         wait status kind image by target_waitstatus_to_string.
3486         * target/waitstatus.c (target_waitstatus_to_string): Fix
3487         obsolete comment.
3488
3489 2019-04-01  Tom Tromey  <tromey@adacore.com>
3490
3491         PR symtab/23331:
3492         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3493
3494 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3495             Pedro Alves  <palves@redhat.com>
3496
3497         * top.c (quit_force): Call 'finalize_values'.
3498         * value.c (finalize_values): New function.
3499         * value.h (finalize_values): Declare.
3500
3501 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3502
3503         * NEWS: Announce $_gdb_major and $_gdb_minor.
3504
3505         * top.c (init_gdb_version_vars): New function.
3506         (gdb_init): Call init_gdb_version_vars.
3507
3508 2019-03-29  Tom Tromey  <tromey@adacore.com>
3509
3510         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3511         help text.  Remove dead code.
3512
3513 2019-03-29  Keith Seitz  <keiths@redhat.com>
3514
3515         From Siddhesh Poyarekar:
3516         * f-lang.h (f77_get_upperbound): Return LONGEST.
3517         (f77_get_lowerbound): Likewise.
3518         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3519         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3520         print them.
3521         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3522         plongest to format print it.
3523         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3524         (f77_get_upperbound): Likewise.
3525         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3526         LOWER_BOUND to LONGEST.
3527         (f77_create_arrayprint_offset_tbl): Likewise.
3528
3529 2019-03-29  Keith Seitz  <keiths@redhat.com>
3530
3531         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3532         %s/pulongest for TYPE_LENGTH instead of %d in format
3533         strings.
3534         * ada-typerint.c (ada_print_type): Likewise.
3535         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3536         * compile/compile-c-support.c (generate_register_struct): Likewise.
3537         * gdbtypes.c (recursive_dump_type): Likewise.
3538         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3539         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3540         instead of %d in format strings.
3541         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3542         to std::min to ULONGEST.
3543         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3544         instead of %d in format strings.
3545         * tracepoint.c (info_scope_command): Likewise.
3546         * typeprint.c (print_offset_data::update)
3547         (print_offset_data::finish): Likewise.
3548         * xtensa-tdep.c (xtensa_store_return_value)
3549         (xtensa_push_dummy_call): Likewise.
3550
3551 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3552
3553         * windows-nat.c (display_selector): Fixed format specifications
3554         for 64-bit Cygwin.
3555
3556 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3557
3558         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3559
3560 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3561
3562         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3563         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3564         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3565         (nios2_linux_init_abi): Install it.
3566
3567 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3568
3569         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3570
3571 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3572
3573         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3574
3575 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3576             Tom Tromey  <tromey@adacore.com>
3577
3578         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3579
3580 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3581
3582         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3583         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3584         method to compute the bounds of range types. Also print "[evaluated]"
3585         if the bounds' values come from a dynamic evaluation.
3586
3587 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3588
3589         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3590         whitespace when pretty printing is on.
3591
3592 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3593
3594         * ppc-linux-nat.c: Add include.
3595
3596 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3597
3598         * NEWS: Mention AArch64 Pointer Authentication.
3599
3600 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3601
3602         * arm-linux-nat.c: Add include.
3603
3604 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
3605
3606         * source-cache.c (source_cache::get_source_lines): Re-read
3607         fullname after calling open_source_file.
3608
3609 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
3610
3611         * NEWS: Mention TLS support for FreeBSD.
3612
3613 2019-03-25  Tom Tromey  <tromey@adacore.com>
3614
3615         * minsyms.c (BUNCH_SIZE): Update comment.
3616         (~minimal_symbol_reader): Remove old comment.
3617         (compact_minimal_symbols): Update comment.
3618         (minimal_symbol_reader::install): Remove old comment.  Update
3619         other comments.
3620
3621 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3622
3623         * s390-linux-nat.c: Add include.
3624
3625 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
3626
3627         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
3628         Call linux_get_hwcap.
3629         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
3630         Likewise.
3631         (aarch64_linux_get_hwcap): Remove function.
3632         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
3633         declaration.
3634         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
3635         linux_get_hwcap.
3636         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
3637         * linux-tdep.c (linux_get_hwcap): Add function.
3638         (linux_get_hwcap2): Likewise.
3639         * linux-tdep.h (linux_get_hwcap): Add declaration.
3640         (linux_get_hwcap2): Likewise.
3641         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
3642         (ppc_linux_get_hwcap2): Likewise.
3643         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
3644         linux_get_hwcap.
3645         (ppc_linux_nat_target::insert_watchpoint): Likewise.
3646         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
3647         (ppc_linux_nat_target::read_description): Likewise.
3648         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
3649         * s390-linux-nat.c: Likewise.
3650         * s390-linux-tdep.c (s390_core_read_description): Likewise.
3651
3652 2019-03-24  Tom Tromey  <tom@tromey.com>
3653
3654         * ada-lang.c (standard_lookup): Simplify initialization.
3655         (ada_lookup_symbol_nonlocal): Simplify return.
3656         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
3657         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
3658         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
3659         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
3660         initialization.
3661         * solib.c (solib_global_lookup): Simplify.
3662         * symtab.c (null_block_symbol): Remove.
3663         (symbol_cache_lookup): Simplify returns.
3664         (lookup_language_this): Simplify returns.
3665         (lookup_symbol_aux): Simplify return.
3666         (lookup_local_symbol): Simplify returns.
3667         (lookup_global_symbol_from_objfile): Simplify return.
3668         (lookup_symbol_in_objfile_symtabs)
3669         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
3670         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
3671         (lookup_static_symbol, lookup_global_symbol): Simplify return.
3672         * cp-namespace.c (cp_lookup_bare_symbol)
3673         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
3674         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
3675         (cp_lookup_nested_symbol): Don't use null_block_symbol.
3676         (cp_lookup_symbol_via_imports): Simplify initialization.
3677         (find_symbol_in_baseclass): Likewise.
3678         * symtab.h (null_block_symbol): Remove.
3679         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
3680         (d_lookup_nested_symbol, d_lookup_symbol_imports)
3681         (d_lookup_symbol_module): Likewise.
3682         (find_symbol_in_baseclass): Simplify initialization.
3683
3684 2019-03-24  Tom Tromey  <tom@tromey.com>
3685
3686         * expression.h: Don't include symtab.h.
3687         (struct block): Forward declare.
3688
3689 2019-03-24  Tom Tromey  <tom@tromey.com>
3690
3691         * c-exp.y (typebase): Remove casts.
3692         * gdbtypes.c (lookup_unsigned_typename, )
3693         (lookup_signed_typename): Remove cast.
3694         * eval.c (parse_to_comma_and_eval): Remove cast.
3695         * parse.c (write_dollar_variable): Remove cast.
3696         * block.h (struct block) <superblock>: Now const.
3697         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
3698         * psymtab.c (psym_map_matching_symbols): Make "block" const.
3699         (map_block): Make "block" const.
3700         * symfile.h (struct quick_symbol_functions)
3701         <map_matching_symbols>: Constify block argument to "callback".
3702         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
3703         const.
3704         (find_pc_sect_compunit_symtab): Make "b" const.
3705         (find_symbol_at_address): Likewise.
3706         (search_symbols): Likewise.
3707         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
3708         (dw2_debug_names_lookup_symbol): Likewise.
3709         (dw2_map_matching_symbols): Update.
3710         * p-valprint.c (pascal_val_print): Remove "block".
3711         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
3712         (aux_add_nonlocal_symbols): Make "block" const.
3713         (resolve_subexp): Remove cast.
3714         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
3715         const.
3716         (iterate_over_file_blocks): Likewise.
3717         * f-exp.y (%union) <bval>: Remove.
3718         * coffread.c (patch_opaque_types): Make "b" const.
3719         * spu-tdep.c (spu_catch_start): Make "block" const.
3720         * c-valprint.c (print_unpacked_pointer): Remove "block".
3721         * symmisc.c (dump_symtab_1): Make "b" const.
3722         (block_depth): Make "block" const.
3723         * d-exp.y (%union) <bval>: Remove.
3724         * cp-support.h (cp_lookup_rtti_type): Update.
3725         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
3726         * psymtab.c (psym_lookup_symbol): Make "block" const.
3727         (maintenance_check_psymtabs): Make "b" const.
3728         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
3729         (enumerate_locals, enumerate_args): Update.
3730         * python/py-symtab.c (stpy_global_block): Make "block" const.
3731         (stpy_static_block): Likewise.
3732         * inline-frame.c (block_starting_point_at): Make "new_block"
3733         const.
3734         * block.c (find_block_in_blockvector): Make return type const.
3735         (blockvector_for_pc_sect): Make "b" const.
3736         (find_block_in_blockvector): Make "b" const.
3737
3738 2019-03-23  Tom Tromey  <tom@tromey.com>
3739
3740         * varobj.c (varobj_create): Update.
3741         * symfile.c (clear_symtab_users): Don't reset innermost_block.
3742         * printcmd.c (display_command, do_one_display): Don't reset
3743         innermost_block.
3744         * parser-defs.h (enum innermost_block_tracker_type): Move to
3745         expression.h.
3746         (innermost_block): Update comment.
3747         * parse.c (parse_exp_1): Add tracker_types parameter.
3748         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
3749         tracker_types parameter.  Reset innermost_block.
3750         (parse_exp_in_context): Remove.
3751         (parse_expression_for_completion): Update.
3752         * objfiles.c (~objfile): Don't reset expression_context_block or
3753         innermost_block.
3754         * expression.h (enum innermost_block_tracker_type): Move from
3755         parser-defs.h.
3756         (parse_exp_1): Add tracker_types parameter.
3757         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
3758         reset innermost_block.
3759
3760 2019-03-23  Tom Tromey  <tom@tromey.com>
3761
3762         * objfiles.h: Include bcache.h.
3763
3764 2019-03-23  Tom Tromey  <tom@tromey.com>
3765
3766         * linespec.c (get_current_search_block): Use
3767         scoped_restore_current_language.
3768         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
3769
3770 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3771             Jiong Wang  <jiong.wang@arm.com>
3772
3773         * aarch64-linux-tdep.c
3774         (aarch64_linux_iterate_over_regset_sections): Check for pauth
3775         section.
3776         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
3777
3778 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3779             Jiong Wang  <jiong.wang@arm.com>
3780
3781         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
3782         instructions.
3783         (aarch64_analyze_prologue_test): Add PACIASP test.
3784         (aarch64_prologue_prev_register): Unmask PC value.
3785
3786 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3787             Jiong Wang  <jiong.wang@arm.com>
3788
3789         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
3790         (aarch64_dwarf2_prev_register): Unmask PC value.
3791         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
3792         (aarch64_execute_dwarf_cfa_vendor_op): Check for
3793         DW_CFA_AARCH64_negate_ra_state.
3794         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
3795
3796 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3797             Jiong Wang  <jiong.wang@arm.com>
3798
3799         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
3800         registers.
3801         (aarch64_pseudo_register_name): Likewise.
3802         (aarch64_pseudo_register_type): Likewise.
3803         (aarch64_pseudo_register_reggroup_p): Likewise.
3804         (aarch64_gdbarch_init): Add pauth registers.
3805         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
3806         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
3807         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
3808         (struct gdbarch_tdep): Add regnum for ra_state.
3809
3810 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3811             Jiong Wang  <jiong.wang@arm.com>
3812
3813         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
3814
3815 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3816             Jiong Wang  <jiong.wang@arm.com>
3817
3818         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
3819         function.
3820         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
3821         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
3822         (aarch64_gdbarch_init): Add puth registers.
3823         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
3824         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
3825         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
3826
3827 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3828             Jiong Wang  <jiong.wang@arm.com>
3829
3830         * aarch64-linux-nat.c
3831         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
3832         * aarch64-linux-tdep.c
3833         (aarch64_linux_core_read_description): Likewise.
3834         (aarch64_linux_get_hwcap): New function.
3835         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
3836         (aarch64_linux_get_hwcap): New declaration.
3837
3838 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
3839             Jiong Wang  <jiong.wang@arm.com>
3840
3841         * aarch64-linux-nat.c
3842         (aarch64_linux_nat_target::read_description): Add pauth param.
3843         * aarch64-linux-tdep.c
3844         (aarch64_linux_core_read_description): Likewise.
3845         * aarch64-tdep.c (struct target_desc): Add in pauth.
3846         (aarch64_read_description): Add pauth param.
3847         (aarch64_gdbarch_init): Likewise.
3848         * aarch64-tdep.h (aarch64_read_description): Likewise.
3849         * arch/aarch64.c (aarch64_create_target_description): Likewise.
3850         * arch/aarch64.h (aarch64_create_target_description): Likewise.
3851         * features/Makefile: Add new files.
3852         * features/aarch64-pauth.c: New file.
3853         * features/aarch64-pauth.xml: New file.
3854
3855 2019-03-20  Tom Tromey  <tromey@adacore.com>
3856
3857         * infrun.c (handle_inferior_event): Rename from
3858         handle_inferior_event_1.  Create a scoped_value_mark.
3859         (handle_inferior_event): Remove.
3860
3861 2019-03-19  Tom Tromey  <tromey@adacore.com>
3862
3863         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
3864         * infrun.h (print_stop_event): Add "displays" parameter.
3865         * infrun.c (print_stop_event): Add "displays" parameter.
3866
3867 2019-03-19  Pedro Alves  <palves@redhat.com>
3868
3869         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
3870         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
3871         to -1.  Fix TABs vs spaces.
3872         (tui_ui_out::tui_ui_out): Don't initialize fields here.
3873         * tui/tui-out.h (tui_ui_out) Add intro comments.
3874         <m_line, m_start_of_line>: In-class initialize, and add describing
3875         comment.
3876
3877 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
3878
3879         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
3880         variable names.
3881         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
3882
3883 2019-03-18  Pedro Alves  <palves@redhat.com>
3884             Eli Zaretskii <eliz@gnu.org>
3885
3886         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
3887         m_line and m_start_of_line.
3888
3889 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
3890
3891         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
3892         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
3893         it returns a newline.  This fixes a regression in TU mode, whereby
3894         the next line is output on the same screen line as the user input.
3895
3896 2019-03-18  Tom Tromey  <tromey@adacore.com>
3897
3898         * minsyms.c (minimal_symbol_reader::install): Remove call to
3899         obstack_blank.
3900
3901 2019-03-18  Pedro Alves  <palves@redhat.com>
3902
3903         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
3904         New globals.
3905         (apply_style): New, factored out from ...
3906         (apply_ansi_escape): ... this.  Handle reverse video mode.
3907         (tui_set_reverse_mode): New function.
3908         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
3909         * tui/tui-winsource.c (tui_show_source_line): Use
3910         tui_set_reverse_mode instead of setting A_STANDOUT.
3911         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
3912         New setter methods.
3913
3914 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
3915
3916         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
3917         Handle tabs.
3918
3919 2019-03-18  Tom Tromey  <tromey@adacore.com>
3920
3921         * ada-lang.c (empty_array): Add "high" parameter.
3922         (ada_evaluate_subexp): Update.
3923
3924 2019-03-17  Sergei Trofimovich <siarheit@google.com>
3925
3926         * unittests/string_view-selftests.c: Define
3927         _initialize_string_view_selftests unconditionally.
3928
3929 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3930
3931         PR gdb/24350
3932         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
3933
3934 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
3935
3936         PR gdb/24351
3937         * windows-nat.c (display_selector): Fix format specifiers.
3938
3939 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
3940
3941         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
3942         tui_refill_source_window instead of tui_refresh_win, to update the
3943         current execution line.  This fixes redisplay of the current line
3944         when stepping through the code with "next" or "step".
3945
3946 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3947
3948         * source-cache.c (source_cache::get_source_lines): Call
3949         find_source_lines to initialize s->nlines.  This fixes vertical
3950         scrolling of TUI source window when the DOWN arrow is pressed.
3951
3952 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3953
3954         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
3955         linux-thread-db.c (_initialize_thread_db): Likewise.
3956
3957 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
3958
3959         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
3960         wclrtoeol in tui_show_source_line".  This reverts changes made in
3961         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
3962
3963 2019-03-15  Tom Tromey  <tom@tromey.com>
3964
3965         * symtab.h (struct minimal_symbol): Derive from
3966         general_symbol_info.
3967         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
3968         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
3969         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
3970         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
3971         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
3972         (MSYMBOL_SEARCH_NAME): Update.
3973         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
3974         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
3975         * minsyms.c (minimal_symbol_reader::record_full): Update.
3976
3977 2019-03-15  Tom Tromey  <tom@tromey.com>
3978
3979         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
3980
3981 2019-03-15  Tom Tromey  <tom@tromey.com>
3982
3983         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
3984         unique_xmalloc_ptr.
3985         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
3986         Update.
3987         * minsyms.c (lookup_minimal_symbol_by_pc_section)
3988         (build_minimal_symbol_hash_tables)
3989         (minimal_symbol_reader::install): Update.
3990
3991 2019-03-15  Tom Tromey  <tom@tromey.com>
3992
3993         * symtab.c (create_demangled_names_hash): Update.
3994         (symbol_set_names): Update.
3995         * objfiles.h (struct objfile_per_bfd_storage)
3996         <demangled_names_hash>: Now an htab_up.
3997         * objfiles.c (objfile_per_bfd_storage): Simplify.
3998
3999 2019-03-15  Tom Tromey  <tom@tromey.com>
4000
4001         * objfiles.h (struct objfile_per_bfd_storage): Declare
4002         destructor.
4003         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4004         New.
4005         (get_objfile_bfd_data): Use new.  Don't initialize
4006         language_of_main.
4007         (free_objfile_per_bfd_storage): Remove.
4008         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4009
4010 2019-03-15  Tom Tromey  <tom@tromey.com>
4011
4012         * symfile.c (reread_symbols): Update.
4013         * objfiles.c (objfile::objfile): Update.
4014         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4015         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4016         comment.
4017         (minimal_symbol_reader::install): Update.
4018         (terminate_minimal_symbol_table): Remove.
4019         * jit.c (jit_object_close_impl): Update.
4020
4021 2019-03-15  Tom Tromey  <tom@tromey.com>
4022
4023         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4024         initializations.
4025
4026 2019-03-15  Tom Tromey  <tom@tromey.com>
4027
4028         * objfiles.h (struct objfile_per_bfd_storage)
4029         <demangled_hash_languages>: Now a bitset.
4030         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4031         (lookup_minimal_symbol): Update.
4032
4033 2019-03-15  Tom Tromey  <tom@tromey.com>
4034
4035         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4036         Don't return the symbol.
4037         * coffread.c (record_minimal_symbol): Use record_full.
4038
4039 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4040
4041         The MS-Windows port of ncurses fails to switch to a color pair if
4042         one or both of the colors are the implicit default colors.  This
4043         change records the default colors when TUI is initialized, and
4044         then specifies them explicitly when a color pair uses the default
4045         colors.  This allows color styling in TUI mode on MS-Windows.
4046
4047         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4048         ncurses_norm_attr.
4049         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4050         colors in ncurses_norm_attr.
4051         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4052         "none", replace it with the default color recorded in
4053         ncurses_norm_attr.
4054
4055 2019-03-14  Tom Tromey  <tromey@adacore.com>
4056
4057         * source-cache.h (class source_cache) <get_source_lines>: Return
4058         std::string.
4059         * source-cache.c (source_cache::extract_lines): Handle case where
4060         first_pos==npos.  Return std::string.
4061         (source_cache::get_source_lines): Update.
4062
4063 2019-03-14  Tom Tromey  <tromey@adacore.com>
4064
4065         * NEWS: Add item for "style sources" commands.
4066         * source-cache.c (source_cache::get_source_lines): Check
4067         source_styling.
4068         * cli/cli-style.c (source_styling): New global.
4069         (_initialize_cli_style): Add "style sources" commands.
4070         (show_style_sources): New function.
4071         * cli/cli-style.h (source_styling): Declare.
4072
4073 2019-03-14  Pedro Alves  <palves@redhat.com>
4074             Tom Tromey  <tromey@adacore.com>
4075
4076         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4077         * tui/tui-winsource.c (tui_refill_source_window): New function,
4078         from...
4079         (tui_horizontal_source_scroll): ... here.  Move some logic.
4080         * cli/cli-style.c (set_style_enabled): Notify new observable.
4081         * tui/tui-hooks.c (tui_redisplay_source): New function.
4082         (tui_attach_detach_observers): Attach or detach
4083         tui_redisplay_source.
4084         * observable.h (source_styling_changed): New observable.
4085         * observable.c: Define source_styling_changed observable.
4086
4087 2019-03-13  Tom Tromey  <tromey@adacore.com>
4088
4089         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4090         (i386_gnu_nat_target::store_registers): Update.
4091         * target-debug.h (target_debug_print_std_string): New macro.
4092         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4093         * windows-tdep.c (display_one_tib): Update.
4094         * tui/tui-stack.c (tui_make_status_line): Update.
4095         * top.c (print_inferior_quit_action): Update.
4096         * thread.c (thr_try_catch_cmd): Update.
4097         (add_thread_with_info): Update.
4098         (thread_target_id_str): Update.
4099         (thr_try_catch_cmd): Update.
4100         (thread_command): Update.
4101         (thread_find_command): Update.
4102         * record-btrace.c (record_btrace_target::info_record)
4103         (record_btrace_resume_thread, record_btrace_target::resume)
4104         (record_btrace_cancel_resume, record_btrace_step_thread)
4105         (record_btrace_target::wait, record_btrace_target::wait)
4106         (record_btrace_target::wait, record_btrace_target::stop): Update.
4107         * progspace.c (print_program_space): Update.
4108         * process-stratum-target.c
4109         (process_stratum_target::thread_address_space): Update.
4110         * linux-fork.c (linux_fork_mourn_inferior)
4111         (detach_checkpoint_command, info_checkpoints_command)
4112         (linux_fork_context): Update.
4113         (linux_fork_detach): Update.
4114         (class scoped_switch_fork_info): Update.
4115         (delete_checkpoint_command): Update.
4116         * infrun.c (follow_fork_inferior): Update.
4117         (follow_fork_inferior): Update.
4118         (proceed_after_vfork_done): Update.
4119         (handle_vfork_child_exec_or_exit): Update.
4120         (follow_exec): Update.
4121         (displaced_step_prepare_throw): Update.
4122         (displaced_step_restore): Update.
4123         (start_step_over): Update.
4124         (resume_1): Update.
4125         (clear_proceed_status_thread): Update.
4126         (proceed): Update.
4127         (print_target_wait_results): Update.
4128         (do_target_wait): Update.
4129         (context_switch): Update.
4130         (stop_all_threads): Update.
4131         (restart_threads): Update.
4132         (finish_step_over): Update.
4133         (handle_signal_stop): Update.
4134         (switch_back_to_stepped_thread): Update.
4135         (keep_going_pass_signal): Update.
4136         (print_exited_reason): Update.
4137         (normal_stop): Update.
4138         * inferior.c (inferior_pid_to_str): Change return type.
4139         (print_selected_inferior): Update.
4140         (add_inferior): Update.
4141         (detach_inferior): Update.
4142         * dummy-frame.c (fprint_dummy_frames): Update.
4143         * dcache.c (dcache_info_1): Update.
4144         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4145         (btrace_fetch, btrace_clear): Update.
4146         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4147         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4148         type.
4149         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4150         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4151         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4152         * gdbarch.c, gdbarch.h: Rebuild.
4153         * gdbarch.sh (core_pid_to_str): Change return type.
4154         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4155         return type.
4156         (windows_nat_target::pid_to_str): Change return type.
4157         (windows_delete_thread): Update.
4158         (windows_nat_target::attach): Update.
4159         (windows_nat_target::files_info): Update.
4160         * target-delegates.c: Rebuild.
4161         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4162         return type.
4163         (sol_thread_target::pid_to_str): Change return type.
4164         * remote.c (class remote_target) <pid_to_str>: Change return
4165         type.
4166         (remote_target::pid_to_str): Change return type.
4167         (extended_remote_target::attach, remote_target::remote_stop_ns)
4168         (remote_target::remote_notif_remove_queued_reply)
4169         (remote_target::push_stop_reply, remote_target::disable_btrace):
4170         Update.
4171         (extended_remote_target::attach): Update.
4172         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4173         type.
4174         (gdbsim_target::pid_to_str): Change return type.
4175         * ravenscar-thread.c (struct ravenscar_thread_target)
4176         <pid_to_str>: Change return type.
4177         (ravenscar_thread_target::pid_to_str): Change return type.
4178         * procfs.c (class procfs_target) <pid_to_str>: Change return
4179         type.
4180         (procfs_target::pid_to_str): Change return type.
4181         (procfs_target::attach): Update.
4182         (procfs_target::detach): Update.
4183         (procfs_target::fetch_registers): Update.
4184         (procfs_target::store_registers): Update.
4185         (procfs_target::wait): Update.
4186         (procfs_target::files_info): Update.
4187         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4188         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4189         return type.
4190         (nto_procfs_target::pid_to_str): Change return type.
4191         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4192         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4193         return type.
4194         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4195         (exit_lwp): Update.
4196         (attach_proc_task_lwp_callback, get_detach_signal)
4197         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4198         (linux_nat_target::resume, wait_lwp, stop_callback)
4199         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4200         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4201         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4202         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4203         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4204         type.
4205         (inf_ptrace_target::attach): Update.
4206         (inf_ptrace_target::files_info): Update.
4207         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4208         type.
4209         (go32_nat_target::pid_to_str): Change return type.
4210         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4211         (gnu_nat_target::wait): Update.
4212         (gnu_nat_target::wait): Update.
4213         (gnu_nat_target::resume): Update.
4214         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4215         (fbsd_nat_target::wait): Update.
4216         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4217         type.
4218         (darwin_nat_target::attach): Update.
4219         * corelow.c (class core_target) <pid_to_str>: Change return type.
4220         (core_target::pid_to_str): Change return type.
4221         * target.c (normal_pid_to_str): Change return type.
4222         (default_pid_to_str): Likewise.
4223         (target_pid_to_str): Change return type.
4224         (target_translate_tls_address): Update.
4225         (target_announce_detach): Update.
4226         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4227         return type.
4228         (bsd_uthread_target::pid_to_str): Change return type.
4229         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4230         type.
4231         (bsd_kvm_target::pid_to_str): Change return type.
4232         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4233         return type.
4234         (aix_thread_target::pid_to_str): Change return type.
4235         * target.h (struct target_ops) <pid_to_str>: Change return type.
4236         (target_pid_to_str, normal_pid_to_str): Likewise.
4237         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4238         type.
4239         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4240         type.
4241         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4242         return type.
4243         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4244         type.
4245         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4246         type.
4247         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4248         return type.
4249
4250 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4251
4252         * NEWS: Mention that the new default MI version is 3.  Mention
4253         changes to the output of commands and events that deal with
4254         multi-location breakpoints.
4255         * breakpoint.c: Include "mi/mi-out.h".
4256         (print_one_breakpoint): Change output syntax if using MI version
4257         >= 3.
4258         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4259         New.
4260         (mi_multi_location_breakpoint_output_fixed): New.
4261         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4262         (mi_cmd_fix_multi_location_breakpoint_output): New.
4263         (mi_multi_location_breakpoint_output_fixed): New.
4264         * mi/mi-cmds.c (mi_cmds): Register command
4265         -fix-multi-location-breakpoint-output.
4266         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4267         interpreter "mi".
4268
4269 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4270
4271         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4272         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4273         instantiate mi_ui_out based on interpreter name.
4274         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4275         * mi/mi-main.c (mi_load_progress): Likewise.
4276
4277 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4278
4279         * NEWS: Combine separate "New targets" sections for 8.3.
4280
4281 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4282
4283         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4284         (ppcfbsd_init_abi): Install gdbarch
4285         "fetch_tls_load_module_address" and "get_thread_local_address"
4286         methods.
4287
4288 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4289
4290         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4291         (riscv_fbsd_init_abi): Install gdbarch
4292         "fetch_tls_load_module_address" and "get_thread_local_address"
4293         methods.
4294
4295 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4296
4297         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4298         (i386fbsd_init_abi): Install gdbarch
4299         "fetch_tls_load_module_address" and "get_thread_local_address"
4300         methods.
4301
4302 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4303
4304         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4305         (amd64fbsd_init_abi): Install gdbarch
4306         "fetch_tls_load_module_address" and "get_thread_local_address"
4307         methods.
4308
4309 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4310
4311         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4312         (struct fbsd_pspace_data): New type.
4313         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4314         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4315         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4316         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4317         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4318
4319 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4320
4321         * gdbtypes.c (lookup_struct_elt): New function.
4322         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4323         * gdbtypes.h (struct struct_elt): New type.
4324         (lookup_struct_elt): New prototype.
4325
4326 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4327
4328         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4329         remove disabled code block.
4330
4331 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4332
4333         * gdbarch.sh (get_thread_local_address): New method.
4334         * gdbarch.h, gdbarch.c: Regenerate.
4335         * target.c (target_translate_tls_address): Use
4336         gdbarch_get_thread_local_address if present instead of
4337         target::get_thread_local_address.
4338
4339 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4340
4341         * target.h (target::get_thread_local_address): Update comment.
4342
4343 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4344
4345         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4346         objfile->separate_debug_objfile_backlink if not NULL.
4347
4348 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4349
4350         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4351         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4352         (amd64bsd_store_inferior_registers): Likewise.
4353         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4354         Enable segment base registers.
4355         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4356         PT_GETFSBASE and PT_GETGSBASE.
4357         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4358         PT_SETGSBASE.
4359         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4360         segment base registers.
4361         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4362
4363 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4364
4365         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4366         Update calls to i386_target_description to add 'segments'
4367         parameter.
4368         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4369         add segment base registers.
4370         * arch/i386.c (i386_create_target_description): Add 'segments'
4371         parameter to enable segment base registers.
4372         * arch/i386.h (i386_create_target_description): Likewise.
4373         * features/i386/32bit-segments.xml: New file.
4374         * features/i386/32bit-segments.c: Generate.
4375         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4376         call to i386_target_description to add 'segments' parameter.
4377         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4378         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4379         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4380         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4381         if feature is present.
4382         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4383         Add 'segments' parameter to call to i386_target_description.
4384         (i386_target_description): Add 'segments' parameter to enable
4385         segment base registers.
4386         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4387         to call to i386_target_description.
4388         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4389         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4390         Define I386_NUM_REGS.
4391         (i386_target_description): Add 'segments' parameter to enable
4392         segment base registers.
4393
4394 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4395
4396         PR/24325
4397         * source-cache.c: #undef open and close, to avoid unresolved
4398         externals during linking.
4399
4400 2019-03-12  Tom Tromey  <tromey@adacore.com>
4401
4402         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4403         const.  Add initializers.
4404         (_initialize_remote): Don't initialize ptid globals.
4405
4406 2019-03-12  Pedro Alves  <palves@redhat.com>
4407
4408         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4409
4410 2019-03-12  Pedro Alves  <palves@redhat.com>
4411
4412         * cp-name-parser.y (main): Remove unused 'len' variable.
4413
4414 2019-03-12  Tom Tromey  <tromey@adacore.com>
4415
4416         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4417         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4418
4419 2019-03-12  Tom Tromey  <tromey@adacore.com>
4420
4421         * linux-nat.c (iterate_over_lwps): Update.
4422         (stop_callback): Remove parameter.
4423         (stop_wait_callback, detach_callback, resume_set_callback)
4424         (select_singlestep_lwp_callback, set_ignore_sigint)
4425         (status_callback, resumed_callback, resume_clear_callback)
4426         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4427         data parameter.
4428         (linux_nat_target::detach, linux_nat_target::resume)
4429         (linux_stop_and_wait_all_lwps, select_event_lwp)
4430         (linux_nat_filter_event, linux_nat_wait_1)
4431         (linux_nat_target::kill, linux_nat_target::stop)
4432         (linux_nat_target::stop): Update.
4433         (linux_nat_resume_callback): Change type.
4434         (resume_stopped_resumed_lwps, count_events_callback)
4435         (select_event_lwp_callback): Likewise.
4436         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4437         * arm-linux-nat.c (struct update_registers_data): Remove.
4438         (update_registers_callback): Change type.
4439         (arm_linux_insert_hw_breakpoint1): Update.
4440         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4441         parameter.
4442         (x86_linux_dr_set_addr): Update.
4443         (x86_linux_dr_set_control): Update.
4444         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4445         (iterate_over_lwps): Use gdb::function_view.
4446         * nat/aarch64-linux-hw-point.c (struct
4447         aarch64_dr_update_callback_param): Remove.
4448         (debug_reg_change_callback): Change type.
4449         (aarch64_notify_debug_reg_change): Update.
4450         * s390-linux-nat.c (s390_refresh_per_info): Update.
4451
4452 2019-03-11  Tom Tromey  <tromey@adacore.com>
4453
4454         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4455         redundant assignment to "this_cu".
4456
4457 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4458
4459         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4460
4461 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4462
4463         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4464         from...
4465         (rank_one_type): ... this.
4466
4467 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4468
4469         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4470         from...
4471         (rank_one_type): ... this.
4472
4473 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4474
4475         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4476         from...
4477         (rank_one_type): ... this.
4478
4479 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4480
4481         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4482         from...
4483         (rank_one_type): ... this.
4484
4485 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4486
4487         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4488         from...
4489         (rank_one_type): ... this.
4490
4491 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4492
4493         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4494         from...
4495         (rank_one_type): ... this.
4496
4497 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4498
4499         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4500         from...
4501         (rank_one_type): ... this.
4502
4503 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4504
4505         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4506         from...
4507         (rank_one_type): ... this.
4508
4509 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4510
4511         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4512         from...
4513         (rank_one_type): ... this.
4514
4515 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4516
4517         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4518         from...
4519         (rank_one_type): ... this.
4520
4521 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4522
4523         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4524         from...
4525         (rank_one_type): ... this.
4526
4527 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4528
4529         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4530         from...
4531         (rank_one_type): ... this.
4532
4533 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4534
4535         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4536         inferior-events' shows the example events.
4537
4538 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4539
4540         Support styling on native MS-Windows console
4541
4542         PR/24315
4543         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4544         on MS-Windows if $TERM is not defined.
4545
4546         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4547
4548         * posix-hdep.c (gdb_console_fputs):
4549         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4550         functions.
4551         * ui-file.h (gdb_console_fputs): Add prototype.
4552
4553         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4554         back to fputs only if the former returns zero.
4555
4556 2019-03-07  Tom Tromey  <tom@tromey.com>
4557
4558         * symmisc.c (print_symbol_bcache_statistics): Update.
4559         (print_objfile_statistics): Update.
4560         * symfile.c (allocate_symtab): Update.
4561         * stabsread.c: Don't include bcache.h.
4562         * psymtab.h (struct psymbol_bcache): Don't declare.
4563         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4564         (psymbol_bcache_init, psymbol_bcache_free)
4565         (psymbol_bcache_get_bcache): Don't declare.
4566         * psymtab.c (struct psymbol_bcache): Remove.
4567         (psymtab_storage::psymtab_storage): Update.
4568         (psymtab_storage::~psymtab_storage): Update.
4569         (psymbol_bcache_init, psymbol_bcache_free)
4570         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4571         (add_psymbol_to_bcache): Update.
4572         (allocate_psymtab): Update.
4573         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4574         macro_cache>: No longer pointers.
4575         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4576         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4577         * macrotab.c (macro_bcache): Update.
4578         * macroexp.c: Don't include bcache.h.
4579         * gdbtypes.c (check_types_worklist): Update.
4580         (types_deeply_equal): Remove TRY/CATCH.  Update.
4581         * elfread.c (elf_symtab_read): Update.
4582         * dwarf2read.c: Don't include bcache.h.
4583         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4584         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4585         (print_bcache_statistics, bcache_memory_used): Don't declare.
4586         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4587         methods.  Rename all data members.
4588         * bcache.c (struct bcache): Move to bcache.h.
4589         (bcache::expand_hash_table): Rename from expand_hash_table.
4590         (bcache): Remove.
4591         (bcache::insert): Rename from bcache_full.
4592         (bcache::compare): Rename from bcache_compare.
4593         (bcache_xmalloc): Remove.
4594         (bcache::~bcache): Rename from bcache_xfree.
4595         (bcache::print_statistics): Rename from print_bcache_statistics.
4596         (bcache::memory_used): Rename from bcache_memory_used.
4597
4598 2019-03-07  Pedro Alves  <palves@redhat.com>
4599
4600         * infrun.c (normal_stop): Also check for
4601         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4602
4603 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
4604
4605         * f-lang.c (value_from_host_double): Moved to...
4606         * value.c (value_from_host_double): ...here.
4607         * value.h (value_from_host_double): Declare.
4608         * guile/scm-math.c (vlscm_convert_typed_number): Use
4609         value_from_host_double.
4610         (vlscm_convert_number): Likewise.
4611         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
4612         * python/py-value.c (convert_value_from_python): Likewise.
4613
4614 2019-03-06  Tom Tromey  <tom@tromey.com>
4615
4616         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
4617
4618 2019-03-06  Tom Tromey  <tom@tromey.com>
4619
4620         * utils.h (free_current_contents): Don't declare.
4621         * utils.c (free_current_contents): Remove.
4622
4623 2019-03-06  Tom Tromey  <tom@tromey.com>
4624
4625         * top.c (quit_force): Update.
4626         * main.c (captured_command_loop): Update.
4627         * common/new-op.c (operator new): Update.
4628         * common/common-exceptions.c (struct catcher)
4629         <save_cleanup_chain>: Remove member.
4630         (exceptions_state_mc_init): Update.
4631         (exception_try_scope_entry): Return nullptr.
4632         (exception_try_scope_exit, exception_rethrow)
4633         (throw_exception_sjlj, throw_exception_cxx): Update.
4634         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
4635         (all_cleanups, do_cleanups, discard_cleanups)
4636         (discard_final_cleanups, save_cleanups, save_final_cleanups)
4637         (restore_cleanups, restore_final_cleanups): Don't declare.
4638         (do_final_cleanups): Remove parameter.
4639         * common/cleanups.c (cleanup_chain, make_cleanup)
4640         (make_cleanup_dtor, all_cleanups, do_cleanups)
4641         (discard_my_cleanups, discard_cleanups)
4642         (discard_final_cleanups, save_my_cleanups, save_cleanups)
4643         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
4644         (null_cleanup): Remove.
4645         (do_final_cleanups): Remove parameter.
4646
4647 2019-03-06  Tom Tromey  <tom@tromey.com>
4648
4649         * remote.c (remote_target::remote_parse_stop_reply): Use
4650         unique_xmalloc_ptr.
4651
4652 2019-03-06  Tom Tromey  <tom@tromey.com>
4653
4654         * stabsread.c (struct stabs_field_info): Rename from field_info.
4655         <list, fnlist>: Add initializers.
4656         <obstack>: New member.
4657         (read_member_functions, read_struct_fields, read_baseclasses):
4658         Allocate on obstack.  Don't use cleanups.
4659         (read_one_struct_field, read_member_functions, read_struct_fields)
4660         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
4661         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
4662         (read_struct_type): Update.
4663
4664 2019-03-06  Tom Tromey  <tom@tromey.com>
4665
4666         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
4667         * common/filestuff.h (make_cleanup_close): Don't declare.
4668         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
4669         Remove.
4670
4671 2019-03-06  Tom Tromey  <tom@tromey.com>
4672
4673         * solib-aix.c: Use make_scope_exit.
4674
4675 2019-03-06  Tom Tromey  <tom@tromey.com>
4676
4677         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
4678         Use make_scope_exit.
4679
4680 2019-03-06  Tom Tromey  <tom@tromey.com>
4681
4682         * solib-svr4.c (disable_probes_interface): Remove parameter.
4683         (svr4_handle_solib_event): Use make_scope_exit.
4684
4685 2019-03-06  Tom Tromey  <tom@tromey.com>
4686
4687         * remote.c (struct stop_reply_deleter): Remove.
4688         (stop_reply_up): Update.
4689         (struct stop_reply): Derive from notif_event.  Don't typedef.
4690         <regcache>: Now a std::vector.
4691         (stop_reply_xfree): Remove.
4692         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
4693         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
4694         (remote_target::discard_pending_stop_replies): Use delete.
4695         (remote_target::remote_parse_stop_reply): Update.
4696         (remote_target::process_stop_reply): Update.
4697         * remote-notif.h (struct notif_event): Add virtual destructor.
4698         Remove "dtr" member.
4699         (struct notif_client) <alloc_event>: Return a unique_ptr.
4700         (notif_event_xfree): Don't declare.
4701         (notif_event_up): New typedef.
4702         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
4703         (notif_event_xfree, do_notif_event_xfree): Remove.
4704         (remote_notif_state_xfree): Update.
4705
4706 2019-03-06  Tom Tromey  <tom@tromey.com>
4707
4708         * infrun.c (displaced_step_clear_cleanup): Now a
4709         forward_scope_exit type.
4710         (displaced_step_prepare_throw): Update.
4711         (displaced_step_fixup): Update.
4712
4713 2019-03-06  Tom Tromey  <tom@tromey.com>
4714
4715         * inferior.h (class inferior): Update comment.
4716         * gdbthread.h (class thread_info): Update comment.
4717
4718 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
4719             Tom Tromey  <tom@tromey.com>
4720
4721         * stabsread.h (struct stab_section_list): Remove.
4722         (coffstab_build_psymtabs): Update.
4723         * dbxread.c (symbuf_sections): Now a std::vector.
4724         (sect_idx): New global.
4725         (fill_symbuf): Update.
4726         (coffstab_build_psymtabs): Change type of stabsects parameter.
4727         Update.
4728         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
4729         std::vector.
4730         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
4731         (coff_locate_sections): Update.
4732         (coff_symfile_read): Remove cleanups.  Update.
4733         (init_stringtab): Add storage parameter.
4734         (free_stringtab, free_stringtab_cleanup): Remove.
4735         (init_lineno): Add storage parameter.
4736         (free_linetab, free_linetab_cleanup): Remove.
4737
4738 2019-03-06  Pedro Alves  <palves@redhat.com>
4739
4740         * linux-fork.c (fork_info::clobber_regs): Delete.
4741         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
4742         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
4743         comment.  Adjust.
4744         (scoped_switch_fork_info::scoped_switch_fork_info)
4745         (checkpoint_command, linux_fork_context): Adjust
4746         fork_save_infrun_state calls.
4747
4748 2019-03-06  Pedro Alves  <palves@redhat.com>
4749
4750         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
4751         (inf_has_multiple_threads): Return 'bool' and rewrite using
4752         inferior_info::threads().
4753
4754 2019-03-06  Pedro Alves  <palves@redhat.com>
4755
4756         * linux-fork.c: Include <list>.
4757         (fork_list): Now a std::list instance.
4758         (fork_info): Add ctor, dtor, and in-class initialize all fields.
4759         (forks_exist_p, find_last_fork): Adjust.
4760         (new_fork): Delete.
4761         (one_fork_p): New.
4762         (add_fork): Adjust.
4763         (free_fork): Delete, folded into fork_info::~fork_info().
4764         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
4765         Adjust.
4766         (init_fork_list): Delete.
4767         (linux_fork_killall, linux_fork_mourn_inferior)
4768         (linux_fork_detach, info_checkpoints_command): Adjust.
4769         (_initialize_linux_fork): No longer call init_fork_list.
4770
4771 2019-03-06  Pedro Alves  <palves@redhat.com>
4772
4773         * linux-fork.c (new_fork): New, split out of ...
4774         (add_fork): ... this.  Return void.  Move "first fork" special
4775         case from here, to ...
4776         (checkpoint_command): ... here.
4777         * linux-linux.h (add_fork): Return void.
4778
4779 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
4782
4783 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4784             Chris January  <chris.january@arm.com>
4785             David Lecomber  <david.lecomber@arm.com>
4786
4787         * f-exp.y: New token, UNOP_INTRINSIC.
4788         (exp): New pattern using UNOP_INTRINSIC token.
4789         (f77_keywords): Add 'abs' keyword.
4790         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
4791         (value_from_host_double): New function.
4792         (evaluate_subexp_f): Support UNOP_ABS.
4793
4794 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4795
4796         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
4797         types.
4798
4799 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4800
4801         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
4802         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
4803         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
4804
4805 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4806
4807         * f-exp.y (convert_to_kind_type): Handle more type kinds.
4808
4809 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4810             Chris January  <chris.january@arm.com>
4811
4812         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
4813         * f-exp.y: Define 'KIND' token.
4814         (exp): New pattern for KIND expressions.
4815         (ptype): Handle types with a kind extension.
4816         (direct_abs_decl): Extend to spot kind extensions.
4817         (f77_keywords): Add 'kind' to the list.
4818         (push_kind_type): New function.
4819         (convert_to_kind_type): New function.
4820         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
4821         * parse.c (operator_length_standard): Likewise.
4822         * parser-defs.h (enum type_pieces): Add tp_kind.
4823         * std-operator.def: Add UNOP_KIND.
4824
4825 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4826
4827         * f-exp.y (f_parse): Set yydebug.
4828
4829 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4830
4831         * f-lang.c (evaluate_subexp_f): New function.
4832         (exp_descriptor_f): New global.
4833         (f_language_defn): Use exp_descriptor_f instead of
4834         exp_descriptor_standard.
4835
4836 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4837
4838         * f-exp.y (struct token): Add comments.
4839         (dot_ops): Remove uppercase versions and the end marker.
4840         (f77_keywords): Likewise.
4841         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
4842         entries in the dot_ops array are case insensitive, and use
4843         strncasecmp to compare strings.  Also some whitespace cleanup in
4844         this area.  Similar for the f77_keywords array, except entries in
4845         this list might be case sensitive.
4846
4847 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
4848
4849         * f-exp.y (struct f77_boolean_val): Add comments.
4850         (boolean_values): Remove uppercase versions, and end marker.
4851         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
4852         and use strncasecmp to achieve case insensitivity.  Additionally,
4853         perform whitespace cleanup around this code.
4854
4855 2019-03-06  Tom Tromey  <tromey@adacore.com>
4856
4857         * remote-sim.c (gdbsim_target_open): Use result of
4858         gdb_argv::release.
4859
4860 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
4861         Dirk Schubert  <dirk.schubert@arm.com>
4862         Chris January  <chris.january@arm.com>
4863
4864         * eval.c (evaluate_subexp_standard): Call Fortran argument
4865         wrapping logic.
4866         * f-lang.c (struct value): A value which can be passed into a
4867         Fortran function call.
4868         (fortran_argument_convert): Wrap Fortran arguments in a pointer
4869         where appropriate.
4870         (struct type): Value ready for a Fortran function call.
4871         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
4872         is needed.
4873         * f-lang.h (fortran_argument_convert): Declaration.
4874         (fortran_preserve_arg_pointer): Declaration.
4875         * infcall.c (value_arg_coerce): Call Fortran argument logic.
4876
4877 2019-03-05  Tom Tromey  <tromey@adacore.com>
4878
4879         * python/py-prettyprint.c (print_string_repr): Remove #if.
4880         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
4881
4882 2019-03-05  Tom Tromey  <tromey@adacore.com>
4883
4884         * target.c (the_dummy_target): Move later.  Change type to
4885         "dummy_target".
4886         (initialize_targets): Don't initialize the_dummy_target.
4887
4888 2019-03-05  Tom Tromey  <tromey@adacore.com>
4889
4890         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
4891         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
4892
4893 2019-03-05  Tom Tromey  <tromey@adacore.com>
4894
4895         * windows-nat.c (windows_nat_target::attach)
4896         (windows_nat_target::detach): Don't call gdb_flush.
4897         * valprint.c (generic_val_print, val_print, val_print_string):
4898         Don't call gdb_flush.
4899         * utils.c (defaulted_query): Don't call gdb_flush.
4900         * typeprint.c (print_type_scalar): Don't call gdb_flush.
4901         * target.c (target_announce_detach): Don't call gdb_flush.
4902         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
4903         * remote.c (extended_remote_target::attach): Don't call
4904         gdb_flush.
4905         * procfs.c (procfs_target::detach): Don't call gdb_flush.
4906         * printcmd.c (do_examine): Don't call gdb_flush.
4907         (info_display_command): Don't call gdb_flush.
4908         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
4909         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
4910         * memattr.c (info_mem_command): Don't call gdb_flush.
4911         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
4912         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
4913         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
4914         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
4915         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
4916         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
4917         (gnu_nat_target::detach): Don't call gdb_flush.
4918         * f-valprint.c (f_val_print): Don't call gdb_flush.
4919         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
4920         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
4921         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
4922         gdb_flush.
4923         * c-valprint.c (c_val_print): Don't call gdb_flush.
4924         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
4925
4926 2019-03-05  Tom Tromey  <tromey@adacore.com>
4927
4928         * varobj.c (update_dynamic_varobj_children): Update.
4929         (install_default_visualizer): Use reset, not release.
4930         * value.c (set_internalvar): Update.
4931         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
4932         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
4933         ATTRIBUTE_UNUSED_RESULT.
4934
4935 2019-03-05  Tom Tromey  <tromey@adacore.com>
4936
4937         * remote.c (class scoped_remote_fd) <release>: Add
4938         ATTRIBUTE_UNUSED_RESULT.
4939
4940 2019-03-05  Tom Tromey  <tromey@adacore.com>
4941
4942         * macroexp.c (struct macro_buffer) <release>: Add
4943         ATTRIBUTE_UNUSED_RESULT.
4944
4945 2019-03-05  Tom Tromey  <tromey@adacore.com>
4946
4947         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
4948         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
4949         ATTRIBUTE_UNUSED_RESULT.
4950
4951 2019-03-05  Tom Tromey  <tromey@adacore.com>
4952
4953         * common/scoped_fd.h (class scoped_fd) <release>: Add
4954         ATTRIBUTE_UNUSED_RESULT.
4955
4956 2019-03-05  Tom Tromey  <tromey@adacore.com>
4957
4958         * parser-defs.h (struct parser_state) <release>: Add
4959         ATTRIBUTE_UNUSED_RESULT.
4960
4961 2019-03-05  Tom Tromey  <tromey@adacore.com>
4962
4963         * utils.h (class gdb_argv) <release>: Add
4964         ATTRIBUTE_UNUSED_RESULT.
4965         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
4966
4967 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
4968
4969         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
4970         for-loop range, to avoid compiler warnings.
4971
4972         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
4973         avoid compiler warnings about unused variables.
4974
4975         * NEWS: Mention end of support for native debugging on MS-Windows
4976         before XP.
4977
4978         PR gdb/24292
4979         * common/netstuff.c:
4980         * gdbserver/gdbreplay.c
4981         * gdbserver/remote-utils.c:
4982         * ser-tcp.c:
4983         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
4984         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
4985         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
4986         'getaddrinfo' and 'freeaddrinfo' were not available before
4987         Windows XP, and mingw.org's MinGW headers by default define
4988         _WIN32_WINNT to 0x500.
4989
4990 2019-03-01  Gary Benson <gbenson@redhat.com>
4991
4992         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
4993
4994 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
4995             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4996
4997         PR gdb/8527
4998         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
4999         set_sigint_trap, clear_sigint_trap.
5000
5001 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5002
5003         * target.c (target_detach): Clear the regcache and the
5004         frame cache.
5005
5006 2019-02-27  Pedro Alves  <palves@redhat.com>
5007
5008         * utils.c (set_screen_size): When we cap the height/width sizes,
5009         tweak the corresponding command variable to show "unlimited":
5010
5011 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5012             Pedro Alves  <palves@redhat.com>
5013
5014         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5015         before calling rl_set_screen_size.
5016
5017 2019-02-27  Tom Tromey  <tromey@adacore.com>
5018
5019         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5020         define.
5021         * python/py-value.c: Remove Python 2.4 workaround.
5022         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5023         workaround.
5024         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5025         Python 2.4 workaround.
5026         * python/python-internal.h: Remove Python 2.4 comment.
5027         (Py_ssize_t): Don't define.
5028         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5029         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5030         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5031         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5032         * python/python.c (do_start_initialization): Remove Python 2.4
5033         workaround.
5034         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5035         (print_children): Remove Python 2.4 workaround.
5036         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5037         workaround.
5038         (CHARBUFFERPROC_NAME): Remove.
5039         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5040         Python 2.4 workaround.
5041
5042 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5043
5044         * NEWS: Note minimum Python version.
5045
5046 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5047
5048         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5049         code from these functions.  Remove corresponding ifdefs.  Use
5050         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5051         Remove gotos and target of gotos.
5052         (infpy_search_memory): Likewise.
5053
5054 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5055
5056         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5057         (hppa_gdbarch_init): Don't register deleted functions with
5058         gdbarch.
5059
5060 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5061
5062         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5063         (h8300_unwind_sp): Delete.
5064         (h8300_dummy_id): Delete.
5065         (h8300_gdbarch_init): Don't register deleted functions with
5066         gdbarch.
5067
5068 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5069
5070         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5071         (ft32_unwind_pc): Delete.
5072         (ft32_unwind_sp): Delete.
5073         (ft32_gdbarch_init): Don't register deleted functions with
5074         gdbarch.
5075
5076 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5077
5078         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5079         (frv_unwind_pc): Delete.
5080         (frv_unwind_sp): Delete.
5081         (frv_gdbarch_init): Don't register deleted functions with
5082         gdbarch.
5083
5084 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5085
5086         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5087         (riscv_unwind_pc): Delete.
5088         (riscv_unwind_sp): Delete.
5089         (riscv_gdbarch_init): Don't register deleted functions with
5090         gdbarch.
5091
5092 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5093
5094         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5095         (csky_unwind_pc): Delete.
5096         (csky_unwind_sp): Delete.
5097         (csky_gdbarch_init): Don't register deleted functions with
5098         gdbarch.
5099
5100 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5103         (cris_unwind_pc): Delete.
5104         (cris_unwind_sp): Delete.
5105         (cris_gdbarch_init): Don't register deleted functions with
5106         gdbarch.
5107
5108 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5109
5110         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5111         (bfin_unwind_pc): Delete.
5112         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5113
5114 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5115
5116         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5117         (arm_unwind_pc): Delete.
5118         (arm_unwind_sp): Delete.
5119         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5120
5121 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5122
5123         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5124         (arc_unwind_pc): Delete.
5125         (arc_unwind_sp): Delete.
5126         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5127
5128 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5129
5130         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5131         (alpha_unwind_pc): Delete.
5132         (alpha_gdbarch_init): Don't register deleted functions with
5133         gdbarch.
5134
5135 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5136
5137         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5138         (aarch64_unwind_pc): Delete.
5139         (aarch64_unwind_sp): Delete.
5140         (aarch64_gdbarch_init): Don't register deleted functions with
5141         gdbarch.
5142
5143 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5144
5145         * gdbtypes.c (type_align): Don't consider static members when
5146         computing structure alignment.
5147
5148 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5149
5150         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5151         return 0 for other types.
5152         * arch-utils.c (default_type_align): Always return 0.
5153         * gdbarch.h: Regenerate.
5154         * gdbarch.sh (type_align): Extend comment.
5155         * gdbtypes.c (type_align): Add additional comments, always call
5156         gdbarch_type_align before applying the default rules.
5157         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5158         generic code will then apply a suitable default.
5159         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5160         types, return 0 for other types.
5161
5162 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5163
5164         * NEWS: Create a new section for the next release branch.
5165         Rename the section of the current branch, now that it has
5166         been cut.
5167
5168 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5169
5170         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5171         * version.in: Bump version to 8.3.50.DATE-git.
5172
5173 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5174
5175         * aix-thread.c (ptid_cmp): Remove unused variable.
5176         (get_signaled_thread): Likewise.
5177         (store_regs_user_thread): Likewise.
5178         (store_regs_kernel_thread): Likewise.
5179         (fetch_regs_kernel_thread): Remove shadowed variable.
5180
5181 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5182
5183         * features/riscv/32bit-cpu.xml: Add register numbers.
5184         * features/riscv/32bit-fpu.c: Regenerate.
5185         * features/riscv/32bit-fpu.xml: Add register numbers.
5186         * features/riscv/64bit-cpu.xml: Add register numbers.
5187         * features/riscv/64bit-fpu.c: Regenerate.
5188         * features/riscv/64bit-fpu.xml: Add register numbers.
5189
5190 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5191
5192         * NEWS: Mention two argument form of gdb.Value constructor.
5193         * python/py-value.c (convert_buffer_and_type_to_value): New
5194         function.
5195         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5196         Add support for handling an optional second argument.  Call
5197         convert_buffer_and_type_to_value as appropriate.
5198         * python/python-internal.h (Py_buffer_deleter): New struct.
5199         (Py_buffer_up): New typedef.
5200
5201 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5202
5203         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5204         instead of releasing ownership.
5205
5206 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5207
5208         * dwarf2read.c (open_and_init_dwp_file): Call
5209         elf_numsections instead of bfd_count_sections to initialize
5210         dwp_file->num_sections.
5211
5212 2019-02-25  Tom Tromey  <tromey@adacore.com>
5213
5214         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5215
5216 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5217
5218         * gcore.in: Add '--readnever' option when invoking GDB.
5219
5220 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5221
5222         * MAINTAINERS: Update my email address.
5223
5224 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5225
5226         * build-id.c (build_id_to_debug_bfd_1): New function.
5227         (build_id_to_debug_bfd): Look for separate debug file in
5228         sysroot.
5229
5230 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5231
5232         * gdbarch.sh: Update the copyright year range that is placed into
5233         generated files.
5234
5235 2019-02-22  Keith Seitz  <keiths@redhat.com>
5236
5237         PR symtab/23853
5238         * linespec.c (create_sals_line_offset): Search for the default
5239         symtab's filename instead of its fullname.
5240
5241 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5242
5243         * NEWS: Update style defaults.
5244
5245 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5246
5247         * main.c (captured_main_1): Disable styling in batch mode.
5248
5249 2019-02-20  Tom Tromey  <tom@tromey.com>
5250
5251         * symtab.c (symtab_symbol_info): Fix typos.
5252
5253 2019-02-20  Tom Tromey  <tromey@adacore.com>
5254
5255         * findcmd.c (_initialize_mem_search): Use upper case for
5256         metasyntactic variables.
5257
5258 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5259
5260         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5261         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5262
5263 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5264
5265         * top.h (source_file_name): Change to std::string.
5266         * top.c (source_file_name): Likewise.
5267         (command_line_input): Adjust.
5268         * cli/cli-script.c (script_from_file): Adjust.
5269
5270 2019-02-19  Tom Tromey  <tromey@adacore.com>
5271
5272         * ravenscar-thread.c
5273         (ravenscar_thread_target::update_thread_list): Don't call
5274         ada_build_task_list.
5275         * ada-lang.h (ada_build_task_list): Don't declare.
5276         * ada-tasks.c (struct ada_tasks_inferior_data)
5277         <task_list_valid_p>: Now bool.
5278         (read_known_tasks, ada_task_list_changed)
5279         (ada_tasks_invalidate_inferior_data): Update.
5280         (read_known_tasks_array): Return bool.
5281         (read_known_tasks_list): Likewise.
5282         (read_known_tasks): Return void.
5283         (ada_build_task_list): Now static.
5284
5285 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5286
5287         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5288         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5289
5290 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5291
5292         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5293         variant for ada_tasks_pspace_data_handle and
5294         ada_tasks_inferior_data_handle.
5295         (ada_tasks_pspace_data_cleanup): New function.
5296         (ada_tasks_inferior_data_cleanup): New function.
5297
5298 2019-02-17  Tom Tromey  <tom@tromey.com>
5299
5300         * macrotab.h (macro_source_fullname): Return a std::string.
5301         * macrotab.c (macro_include, check_for_redefinition)
5302         (macro_undef, macro_lookup_definition, foreach_macro)
5303         (foreach_macro_in_scope): Update.
5304         (macro_source_fullname): Return a std::string.
5305         * macrocmd.c (show_pp_source_pos): Update.
5306
5307 2019-02-17  Tom Tromey  <tom@tromey.com>
5308
5309         * macrocmd.c (show_pp_source_pos): Style the file names.
5310
5311 2019-02-17  Tom Tromey  <tom@tromey.com>
5312
5313         PR tui/24197:
5314         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5315
5316 2019-02-17  Tom Tromey  <tom@tromey.com>
5317
5318         * ada-lang.c (user_select_syms): Use filtered printing.
5319         * utils.c (wrap_style): New global.
5320         (desired_style): Remove.
5321         (emit_style_escape): Add stream parameter.
5322         (set_output_style, reset_terminal_style, prompt_for_continue):
5323         Update.
5324         (flush_wrap_buffer): Only flush gdb_stdout.
5325         (wrap_here): Set wrap_style.
5326         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5327         treat escape sequences as a character.  Change when wrap buffer is
5328         flushed.
5329         (fputs_styled): Do not set the output style when the default is
5330         requested.
5331         * ui-style.h (struct ui_file_style) <is_default>: New method.
5332         * source.c (print_source_lines_base): Emit escape sequences in one
5333         piece.
5334
5335 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5336
5337         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5338         integers and enumeration types.
5339
5340 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5341
5342         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5343         instead of lookup_symbol_in_language
5344         (do_exact_match): New function.
5345         (ada_get_symbol_name_matcher): Return do_exact_match when
5346         doing a verbatim match.
5347
5348 2019-02-15  Tom Tromey  <tromey@adacore.com>
5349
5350         * ravenscar-thread.c (ravenscar_thread_target::resume)
5351         (ravenscar_thread_target::wait): Special case wildcard requests.
5352
5353 2019-02-15  Tom Tromey  <tromey@adacore.com>
5354
5355         * ravenscar-thread.c (base_ptid): Remove.
5356         (struct ravenscar_thread_target) <close>: New method.
5357         <m_base_ptid>: New member.
5358         <update_inferior_ptid, active_task, task_is_currently_active,
5359         runtime_initialized>: Declare methods.
5360         <ravenscar_thread_target>: Add constructor.
5361         (ravenscar_thread_target::task_is_currently_active)
5362         (ravenscar_thread_target::update_inferior_ptid)
5363         (ravenscar_runtime_initialized): Rename.  Now methods.
5364         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5365         (ravenscar_thread_target::update_thread_list): Update.
5366         (ravenscar_thread_target::active_task): Now method.
5367         (ravenscar_thread_target::store_registers)
5368         (ravenscar_thread_target::prepare_to_store)
5369         (ravenscar_thread_target::prepare_to_store)
5370         (ravenscar_thread_target::mourn_inferior): Update.
5371         (ravenscar_inferior_created): Use "new" to create target.
5372         (ravenscar_thread_target::get_ada_task_ptid): Update.
5373         (_initialize_ravenscar): Don't initialize base_ptid.
5374         (ravenscar_ops): Remove global.
5375
5376 2019-02-15  Tom Tromey  <tromey@adacore.com>
5377
5378         * target.h (push_target): Declare new overload.
5379         * target.c (push_target): New overload, taking an rvalue reference.
5380         * remote.c (remote_target::open_1): Use push_target overload.
5381         * corelow.c (core_target_open): Use push_target overload.
5382
5383 2019-02-15  Tom Tromey  <tromey@adacore.com>
5384
5385         * ravenscar-thread.c (is_ravenscar_task)
5386         (ravenscar_task_is_currently_active): Return bool.
5387         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5388         (_initialize_ravenscar): Remove "(void)".
5389         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5390         Return bool.
5391
5392 2019-02-15  Tom Tromey  <tromey@adacore.com>
5393
5394         * ravenscar-thread.c (ravenscar_runtime_initializer)
5395         (has_ravenscar_runtime, get_running_thread_id)
5396         (ravenscar_thread_target::resume): Fix indentation.
5397
5398 2019-02-15  Tom Tromey  <tromey@adacore.com>
5399
5400         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5401         from ravenscar_arch_ops.
5402         (sparc_ravenscar_ops::fetch_registers)
5403         (sparc_ravenscar_ops::store_registers): Now methods.
5404         (sparc_ravenscar_prepare_to_store): Remove.
5405         (sparc_ravenscar_ops): Redefine.
5406         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5407         methods and destructor.  Remove members.
5408         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5409         (ravenscar_thread_target::store_registers)
5410         (ravenscar_thread_target::prepare_to_store): Update.
5411         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5412         Remove.
5413         (struct ppc_ravenscar_powerpc_ops): Derive from
5414         ravenscar_arch_ops.
5415         (ppc_ravenscar_powerpc_ops::fetch_registers)
5416         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5417         (ppc_ravenscar_powerpc_ops): Redefine.
5418         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5419         (ppc_ravenscar_e500_ops::fetch_registers)
5420         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5421         (ppc_ravenscar_e500_ops): Redefine.
5422         * aarch64-ravenscar-thread.c
5423         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5424         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5425         (aarch64_ravenscar_fetch_registers)
5426         (aarch64_ravenscar_store_registers): Now methods.
5427         (aarch64_ravenscar_ops): Redefine.
5428
5429 2019-02-15  Tom Tromey  <tromey@adacore.com>
5430
5431         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5432         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5433         (ravenscar_thread_target::stopped_by_watchpoint)
5434         (ravenscar_thread_target::stopped_data_address)
5435         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5436
5437 2019-02-15  Tom Tromey  <tromey@adacore.com>
5438
5439         * ravenscar-thread.c: Fix some typos.
5440
5441 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5442             Tom Tromey  <tromey@adacore.com>
5443
5444         * ada-lang.c (ada_exception_sal): Change addr_string to a
5445         std::string.
5446         (create_ada_exception_catchpoint): Update.
5447
5448 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5449             Tom Tromey  <tromey@adacore.com>
5450
5451         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5452         (bp_location_ops): Remove.
5453         (base_breakpoint_allocate_location): Update.
5454         (free_bp_location): Update.
5455         * ada-lang.c (class ada_catchpoint_location)
5456         <ada_catchpoint_location>: Remove ops parameter.
5457         (ada_catchpoint_location_dtor): Remove.
5458         (ada_catchpoint_location_ops): Remove.
5459         (allocate_location_exception): Update.
5460         * breakpoint.h (struct bp_location_ops): Remove.
5461         (class bp_location) <bp_location>: Remove bp_location_ops
5462         parameter.
5463         <~bp_location>: Add destructor.
5464         <ops>: Remove.
5465
5466 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5467             Pedro Alves  <palves@redhat.com>
5468
5469         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5470         'PATH_MAX'.
5471
5472 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5473             Samuel Thibault  <samuel.thibault@gnu.org>
5474             Thomas Schwinge  <thomas@codesourcery.com>
5475
5476         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5477         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5478
5479 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5480
5481         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5482         (check_empty): Use "const char *".
5483
5484         * gnu-nat.c (gnu_nat_target::detach): Instead of
5485         'detach_inferior (pid)' call
5486         'detach_inferior (find_inferior_pid (pid))'.
5487
5488         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5489         'nat/fork-inferior.o'.
5490         * gnu-nat.c: #include "nat/fork-inferior.h".
5491
5492         * gnu-nat.c (gnu_nat_target::detach): Instead of
5493         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5494         * gnu-nat.h: #include "inf-child.h".
5495         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5496         'i386_gnu_nat_target::fetch_registers'.
5497         (gnu_store_registers): Rename/move to
5498         'i386_gnu_nat_target::store_registers'.
5499
5500         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5501         * gnu-nat.h (mach_thread_info): New function.
5502         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5503
5504         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5505
5506 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5507
5508         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5509
5510 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5511
5512         * windows-nat.c (windows_add_thread): Add new parameter
5513         "main_thread_p" with default value set to false.  Update
5514         function documentation as well as all callers.
5515         (windows_delete_thread): Likewise.
5516         (fake_create_process): Update call to windows_add_thread.
5517         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5518         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5519         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5520         call to windows_delete_thread.
5521
5522 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5523
5524         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5525
5526 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5527
5528         * symfile.c (find_separate_debug_file): Use canonical path of
5529         sysroot with child_path instead of gdb_sysroot if it is valid.
5530
5531 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5532
5533         * symfile.c (find_separate_debug_file): Use child_path to
5534         determine if an object file is under a sysroot.
5535
5536 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5537
5538         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5539         unittests/child-path-selftests.c.
5540         * common/pathstuff.c (child_path): New function.
5541         * common/pathstuff.h (child_path): New prototype.
5542         * unittests/child-path-selftests.c: New file.
5543
5544 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5545
5546         * symfile.c (find_separate_debug_file): Look for separate debug
5547         files in debug directories under the sysroot.
5548
5549 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5550
5551         * symtab.h (struct minimal_symbol data_p): New const method.
5552         (struct minimal_symbol text_p): Likewise.
5553         * symtab.c (output_source_filename): Use file name style
5554         to print file name.
5555         (print_symbol_info): Likewise.
5556         (print_msymbol_info): Use address style to print addresses.
5557         Use function name style to print executable text symbols.
5558         (expand_symtab_containing_pc): Use data_p.
5559         (find_pc_sect_compunit_symtab): Likewise.
5560
5561 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5562
5563         * breakpoint.c (describe_other_breakpoints): Use address style
5564         to print addresses.
5565         (say_where): Likewise.
5566
5567 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5568
5569         * ada-typeprint.c (print_func_type): Print function name
5570         style to print function name.
5571         * c-typeprint.c (c_print_type_1): Likewise.
5572
5573 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5574
5575         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5576         for execve.
5577
5578 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5579
5580         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5581         type_stack.
5582
5583 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5584
5585         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5586         TYPE_CODE_REF types.
5587
5588 2019-02-08  Jim Wilson  <jimw@sifive.com>
5589
5590         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5591         (riscv_linux_fregset): New.
5592         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5593
5594 2019-02-07  Tom Tromey  <tom@tromey.com>
5595
5596         * thread.c (thread_cancel_execution_command): Update.
5597         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5598         methods.
5599         (struct thread_fsm_ops): Remove.
5600         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5601         (thread_fsm_should_stop, thread_fsm_return_value)
5602         (thread_fsm_set_finished, thread_fsm_finished_p)
5603         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
5604         Don't declare.
5605         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
5606         * infrun.c (clear_proceed_status_thread)
5607         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
5608         (print_stop_event): Update.
5609         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
5610         Add constructor.
5611         (step_command_fsm_ops): Remove.
5612         (new_step_command_fsm): Remove.
5613         (step_1): Update.
5614         (step_command_fsm::should_stop): Rename from
5615         step_command_fsm_should_stop.
5616         (step_command_fsm::clean_up): Rename from
5617         step_command_fsm_clean_up.
5618         (step_command_fsm::do_async_reply_reason): Rename from
5619         step_command_fsm_async_reply_reason.
5620         (struct until_next_fsm): Inherit from thread_fsm.  Add
5621         constructor.
5622         (until_next_fsm_ops): Remove.
5623         (new_until_next_fsm): Remove.
5624         (until_next_fsm::should_stop): Rename from
5625         until_next_fsm_should_stop.
5626         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
5627         (until_next_fsm::do_async_reply_reason): Rename from
5628         until_next_fsm_async_reply_reason.
5629         (struct finish_command_fsm): Inherit from thread_fsm.  Add
5630         constructor.  Change type of breakpoint.
5631         (finish_command_fsm_ops): Remove.
5632         (new_finish_command_fsm): Remove.
5633         (finish_command_fsm::should_stop): Rename from
5634         finish_command_fsm_should_stop.
5635         (finish_command_fsm::clean_up): Rename from
5636         finish_command_fsm_clean_up.
5637         (finish_command_fsm::return_value): Rename from
5638         finish_command_fsm_return_value.
5639         (finish_command_fsm::do_async_reply_reason): Rename from
5640         finish_command_fsm_async_reply_reason.
5641         (finish_command): Update.
5642         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
5643         Add constructor.
5644         (call_thread_fsm_ops): Remove.
5645         (call_thread_fsm::call_thread_fsm): Rename from
5646         new_call_thread_fsm.
5647         (call_thread_fsm::should_stop): Rename from
5648         call_thread_fsm_should_stop.
5649         (call_thread_fsm::should_notify_stop): Rename from
5650         call_thread_fsm_should_notify_stop.
5651         (run_inferior_call, call_function_by_hand_dummy): Update.
5652         * cli/cli-interp.c (should_print_stop_to_console): Update.
5653         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
5654         Add constructor.  Change type of location_breakpoint,
5655         caller_breakpoint.
5656         (until_break_fsm_ops): Remove.
5657         (new_until_break_fsm): Remove.
5658         (until_break_fsm::should_stop): Rename from
5659         until_break_fsm_should_stop.
5660         (until_break_fsm::clean_up): Rename from
5661         until_break_fsm_clean_up.
5662         (until_break_fsm::do_async_reply_reason): Rename from
5663         until_break_fsm_async_reply_reason.
5664         (until_break_command): Update.
5665         * thread-fsm.c: Remove.
5666         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
5667
5668 2019-02-07  Tom Tromey  <tom@tromey.com>
5669
5670         * yy-remap.h: Add include guard.
5671         * xtensa-tdep.h: Add include guard.
5672         * xcoffread.h: Rename include guard.
5673         * varobj-iter.h: Add include guard.
5674         * tui/tui.h: Rename include guard.
5675         * tui/tui-winsource.h: Rename include guard.
5676         * tui/tui-wingeneral.h: Rename include guard.
5677         * tui/tui-windata.h: Rename include guard.
5678         * tui/tui-win.h: Rename include guard.
5679         * tui/tui-stack.h: Rename include guard.
5680         * tui/tui-source.h: Rename include guard.
5681         * tui/tui-regs.h: Rename include guard.
5682         * tui/tui-out.h: Rename include guard.
5683         * tui/tui-layout.h: Rename include guard.
5684         * tui/tui-io.h: Rename include guard.
5685         * tui/tui-hooks.h: Rename include guard.
5686         * tui/tui-file.h: Rename include guard.
5687         * tui/tui-disasm.h: Rename include guard.
5688         * tui/tui-data.h: Rename include guard.
5689         * tui/tui-command.h: Rename include guard.
5690         * tic6x-tdep.h: Add include guard.
5691         * target/waitstatus.h: Rename include guard.
5692         * target/wait.h: Rename include guard.
5693         * target/target.h: Rename include guard.
5694         * target/resume.h: Rename include guard.
5695         * target-float.h: Rename include guard.
5696         * stabsread.h: Add include guard.
5697         * rs6000-tdep.h: Add include guard.
5698         * riscv-fbsd-tdep.h: Add include guard.
5699         * regformats/regdef.h: Rename include guard.
5700         * record.h: Rename include guard.
5701         * python/python.h: Rename include guard.
5702         * python/python-internal.h: Rename include guard.
5703         * python/py-stopevent.h: Rename include guard.
5704         * python/py-ref.h: Rename include guard.
5705         * python/py-record.h: Rename include guard.
5706         * python/py-record-full.h: Rename include guard.
5707         * python/py-record-btrace.h: Rename include guard.
5708         * python/py-instruction.h: Rename include guard.
5709         * python/py-events.h: Rename include guard.
5710         * python/py-event.h: Rename include guard.
5711         * procfs.h: Add include guard.
5712         * proc-utils.h: Add include guard.
5713         * p-lang.h: Add include guard.
5714         * or1k-tdep.h: Rename include guard.
5715         * observable.h: Rename include guard.
5716         * nto-tdep.h: Rename include guard.
5717         * nat/x86-linux.h: Rename include guard.
5718         * nat/x86-linux-dregs.h: Rename include guard.
5719         * nat/x86-gcc-cpuid.h: Add include guard.
5720         * nat/x86-dregs.h: Rename include guard.
5721         * nat/x86-cpuid.h: Rename include guard.
5722         * nat/ppc-linux.h: Rename include guard.
5723         * nat/mips-linux-watch.h: Rename include guard.
5724         * nat/linux-waitpid.h: Rename include guard.
5725         * nat/linux-ptrace.h: Rename include guard.
5726         * nat/linux-procfs.h: Rename include guard.
5727         * nat/linux-osdata.h: Rename include guard.
5728         * nat/linux-nat.h: Rename include guard.
5729         * nat/linux-namespaces.h: Rename include guard.
5730         * nat/linux-btrace.h: Rename include guard.
5731         * nat/glibc_thread_db.h: Rename include guard.
5732         * nat/gdb_thread_db.h: Rename include guard.
5733         * nat/gdb_ptrace.h: Rename include guard.
5734         * nat/fork-inferior.h: Rename include guard.
5735         * nat/amd64-linux-siginfo.h: Rename include guard.
5736         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
5737         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
5738         * nat/aarch64-linux.h: Rename include guard.
5739         * nat/aarch64-linux-hw-point.h: Rename include guard.
5740         * mn10300-tdep.h: Add include guard.
5741         * mips-linux-tdep.h: Add include guard.
5742         * mi/mi-parse.h: Rename include guard.
5743         * mi/mi-out.h: Rename include guard.
5744         * mi/mi-main.h: Rename include guard.
5745         * mi/mi-interp.h: Rename include guard.
5746         * mi/mi-getopt.h: Rename include guard.
5747         * mi/mi-console.h: Rename include guard.
5748         * mi/mi-common.h: Rename include guard.
5749         * mi/mi-cmds.h: Rename include guard.
5750         * mi/mi-cmd-break.h: Rename include guard.
5751         * m2-lang.h: Add include guard.
5752         * location.h: Rename include guard.
5753         * linux-record.h: Rename include guard.
5754         * linux-nat.h: Add include guard.
5755         * linux-fork.h: Add include guard.
5756         * i386-darwin-tdep.h: Rename include guard.
5757         * hppa-linux-offsets.h: Add include guard.
5758         * guile/guile.h: Rename include guard.
5759         * guile/guile-internal.h: Rename include guard.
5760         * gnu-nat.h: Rename include guard.
5761         * gdb-stabs.h: Rename include guard.
5762         * frv-tdep.h: Add include guard.
5763         * f-lang.h: Add include guard.
5764         * event-loop.h: Add include guard.
5765         * darwin-nat.h: Rename include guard.
5766         * cp-abi.h: Rename include guard.
5767         * config/sparc/nm-sol2.h: Rename include guard.
5768         * config/nm-nto.h: Rename include guard.
5769         * config/nm-linux.h: Add include guard.
5770         * config/i386/nm-i386gnu.h: Rename include guard.
5771         * config/djgpp/nl_types.h: Rename include guard.
5772         * config/djgpp/langinfo.h: Rename include guard.
5773         * compile/gcc-cp-plugin.h: Add include guard.
5774         * compile/gcc-c-plugin.h: Add include guard.
5775         * compile/compile.h: Rename include guard.
5776         * compile/compile-object-run.h: Rename include guard.
5777         * compile/compile-object-load.h: Rename include guard.
5778         * compile/compile-internal.h: Rename include guard.
5779         * compile/compile-cplus.h: Rename include guard.
5780         * compile/compile-c.h: Rename include guard.
5781         * common/xml-utils.h: Rename include guard.
5782         * common/x86-xstate.h: Rename include guard.
5783         * common/version.h: Rename include guard.
5784         * common/vec.h: Rename include guard.
5785         * common/tdesc.h: Rename include guard.
5786         * common/selftest.h: Rename include guard.
5787         * common/scoped_restore.h: Rename include guard.
5788         * common/scoped_mmap.h: Rename include guard.
5789         * common/scoped_fd.h: Rename include guard.
5790         * common/safe-iterator.h: Rename include guard.
5791         * common/run-time-clock.h: Rename include guard.
5792         * common/refcounted-object.h: Rename include guard.
5793         * common/queue.h: Rename include guard.
5794         * common/ptid.h: Rename include guard.
5795         * common/print-utils.h: Rename include guard.
5796         * common/preprocessor.h: Rename include guard.
5797         * common/pathstuff.h: Rename include guard.
5798         * common/observable.h: Rename include guard.
5799         * common/netstuff.h: Rename include guard.
5800         * common/job-control.h: Rename include guard.
5801         * common/host-defs.h: Rename include guard.
5802         * common/gdb_wait.h: Rename include guard.
5803         * common/gdb_vecs.h: Rename include guard.
5804         * common/gdb_unlinker.h: Rename include guard.
5805         * common/gdb_unique_ptr.h: Rename include guard.
5806         * common/gdb_tilde_expand.h: Rename include guard.
5807         * common/gdb_sys_time.h: Rename include guard.
5808         * common/gdb_string_view.h: Rename include guard.
5809         * common/gdb_splay_tree.h: Rename include guard.
5810         * common/gdb_setjmp.h: Rename include guard.
5811         * common/gdb_ref_ptr.h: Rename include guard.
5812         * common/gdb_optional.h: Rename include guard.
5813         * common/gdb_locale.h: Rename include guard.
5814         * common/gdb_assert.h: Rename include guard.
5815         * common/filtered-iterator.h: Rename include guard.
5816         * common/filestuff.h: Rename include guard.
5817         * common/fileio.h: Rename include guard.
5818         * common/environ.h: Rename include guard.
5819         * common/common-utils.h: Rename include guard.
5820         * common/common-types.h: Rename include guard.
5821         * common/common-regcache.h: Rename include guard.
5822         * common/common-inferior.h: Rename include guard.
5823         * common/common-gdbthread.h: Rename include guard.
5824         * common/common-exceptions.h: Rename include guard.
5825         * common/common-defs.h: Rename include guard.
5826         * common/common-debug.h: Rename include guard.
5827         * common/cleanups.h: Rename include guard.
5828         * common/buffer.h: Rename include guard.
5829         * common/btrace-common.h: Rename include guard.
5830         * common/break-common.h: Rename include guard.
5831         * cli/cli-utils.h: Rename include guard.
5832         * cli/cli-style.h: Rename include guard.
5833         * cli/cli-setshow.h: Rename include guard.
5834         * cli/cli-script.h: Rename include guard.
5835         * cli/cli-interp.h: Rename include guard.
5836         * cli/cli-decode.h: Rename include guard.
5837         * cli/cli-cmds.h: Rename include guard.
5838         * charset-list.h: Add include guard.
5839         * buildsym-legacy.h: Rename include guard.
5840         * bfin-tdep.h: Add include guard.
5841         * ax.h: Rename include guard.
5842         * arm-linux-tdep.h: Add include guard.
5843         * arm-fbsd-tdep.h: Add include guard.
5844         * arch/xtensa.h: Rename include guard.
5845         * arch/tic6x.h: Add include guard.
5846         * arch/i386.h: Add include guard.
5847         * arch/arm.h: Rename include guard.
5848         * arch/arm-linux.h: Rename include guard.
5849         * arch/arm-get-next-pcs.h: Rename include guard.
5850         * arch/amd64.h: Add include guard.
5851         * arch/aarch64-insn.h: Rename include guard.
5852         * arch-utils.h: Rename include guard.
5853         * annotate.h: Add include guard.
5854         * amd64-darwin-tdep.h: Rename include guard.
5855         * aarch64-linux-tdep.h: Add include guard.
5856         * aarch64-fbsd-tdep.h: Add include guard.
5857         * aarch32-linux-nat.h: Add include guard.
5858
5859 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5860
5861         * macrotab.c (macro_define_internal): New function that
5862         factorizes macro_define_object_internal and macro_define_function
5863         code.
5864         (macro_define_object_internal): Use macro_define_internal.
5865         (macro_define_function): Likewise.
5866
5867 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5868
5869         * macrocmd.c (extract_identifier): Return
5870         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
5871         callers.
5872
5873 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
5874
5875         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
5876
5877 2019-02-05  Tom Tromey  <tom@tromey.com>
5878
5879         * target.c (target_stack::unpush): Move assertion earlier.
5880
5881 2019-01-30  Tom Tromey  <tom@tromey.com>
5882
5883         PR python/23615:
5884         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
5885         (gdbpy_parse_and_eval): Likewise.
5886         * python/python-internal.h (gdbpy_allow_threads): New class.
5887
5888 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
5889
5890         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
5891         (aarch64_fbsd_fpregmap): Move earlier.
5892         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
5893         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5894         instead of individual calls to trad_frame_set_reg_addr.
5895         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
5896         earlier.
5897         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
5898         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
5899         instead of individual calls to trad_frame_set_reg_addr.
5900
5901 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
5902
5903         * CONTRIBUTE: Replace contribution list with wiki link.
5904
5905 2019-01-25  Tom Tromey  <tom@tromey.com>
5906
5907         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
5908
5909 2019-01-25  Tom Tromey  <tom@tromey.com>
5910
5911         * xtensa-linux-nat.c: Fix common/ includes.
5912         * xml-support.h: Fix common/ includes.
5913         * xml-support.c: Fix common/ includes.
5914         * x86-linux-nat.c: Fix common/ includes.
5915         * windows-nat.c: Fix common/ includes.
5916         * varobj.h: Fix common/ includes.
5917         * varobj.c: Fix common/ includes.
5918         * value.c: Fix common/ includes.
5919         * valops.c: Fix common/ includes.
5920         * utils.c: Fix common/ includes.
5921         * unittests/xml-utils-selftests.c: Fix common/ includes.
5922         * unittests/utils-selftests.c: Fix common/ includes.
5923         * unittests/unpack-selftests.c: Fix common/ includes.
5924         * unittests/tracepoint-selftests.c: Fix common/ includes.
5925         * unittests/style-selftests.c: Fix common/ includes.
5926         * unittests/string_view-selftests.c: Fix common/ includes.
5927         * unittests/scoped_restore-selftests.c: Fix common/ includes.
5928         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
5929         * unittests/scoped_fd-selftests.c: Fix common/ includes.
5930         * unittests/rsp-low-selftests.c: Fix common/ includes.
5931         * unittests/parse-connection-spec-selftests.c: Fix common/
5932         includes.
5933         * unittests/optional-selftests.c: Fix common/ includes.
5934         * unittests/offset-type-selftests.c: Fix common/ includes.
5935         * unittests/observable-selftests.c: Fix common/ includes.
5936         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
5937         * unittests/memrange-selftests.c: Fix common/ includes.
5938         * unittests/memory-map-selftests.c: Fix common/ includes.
5939         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
5940         * unittests/function-view-selftests.c: Fix common/ includes.
5941         * unittests/environ-selftests.c: Fix common/ includes.
5942         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
5943         * unittests/common-utils-selftests.c: Fix common/ includes.
5944         * unittests/cli-utils-selftests.c: Fix common/ includes.
5945         * unittests/array-view-selftests.c: Fix common/ includes.
5946         * ui-file.c: Fix common/ includes.
5947         * tui/tui-io.c: Fix common/ includes.
5948         * tracepoint.h: Fix common/ includes.
5949         * tracepoint.c: Fix common/ includes.
5950         * tracefile-tfile.c: Fix common/ includes.
5951         * top.h: Fix common/ includes.
5952         * top.c: Fix common/ includes.
5953         * thread.c: Fix common/ includes.
5954         * target/waitstatus.h: Fix common/ includes.
5955         * target/waitstatus.c: Fix common/ includes.
5956         * target.h: Fix common/ includes.
5957         * target.c: Fix common/ includes.
5958         * target-memory.c: Fix common/ includes.
5959         * target-descriptions.c: Fix common/ includes.
5960         * symtab.h: Fix common/ includes.
5961         * symfile.c: Fix common/ includes.
5962         * stap-probe.c: Fix common/ includes.
5963         * spu-linux-nat.c: Fix common/ includes.
5964         * sparc-nat.c: Fix common/ includes.
5965         * source.c: Fix common/ includes.
5966         * solib.c: Fix common/ includes.
5967         * solib-target.c: Fix common/ includes.
5968         * ser-unix.c: Fix common/ includes.
5969         * ser-tcp.c: Fix common/ includes.
5970         * ser-pipe.c: Fix common/ includes.
5971         * ser-base.c: Fix common/ includes.
5972         * selftest-arch.c: Fix common/ includes.
5973         * s12z-tdep.c: Fix common/ includes.
5974         * rust-exp.y: Fix common/ includes.
5975         * rs6000-aix-tdep.c: Fix common/ includes.
5976         * riscv-tdep.c: Fix common/ includes.
5977         * remote.c: Fix common/ includes.
5978         * remote-notif.h: Fix common/ includes.
5979         * remote-fileio.h: Fix common/ includes.
5980         * remote-fileio.c: Fix common/ includes.
5981         * regcache.h: Fix common/ includes.
5982         * regcache.c: Fix common/ includes.
5983         * record-btrace.c: Fix common/ includes.
5984         * python/python.c: Fix common/ includes.
5985         * python/py-type.c: Fix common/ includes.
5986         * python/py-inferior.c: Fix common/ includes.
5987         * progspace.h: Fix common/ includes.
5988         * producer.c: Fix common/ includes.
5989         * procfs.c: Fix common/ includes.
5990         * proc-api.c: Fix common/ includes.
5991         * printcmd.c: Fix common/ includes.
5992         * ppc-linux-nat.c: Fix common/ includes.
5993         * parser-defs.h: Fix common/ includes.
5994         * osdata.c: Fix common/ includes.
5995         * obsd-nat.c: Fix common/ includes.
5996         * nat/x86-linux.c: Fix common/ includes.
5997         * nat/x86-linux-dregs.c: Fix common/ includes.
5998         * nat/x86-dregs.h: Fix common/ includes.
5999         * nat/x86-dregs.c: Fix common/ includes.
6000         * nat/ppc-linux.c: Fix common/ includes.
6001         * nat/mips-linux-watch.h: Fix common/ includes.
6002         * nat/mips-linux-watch.c: Fix common/ includes.
6003         * nat/linux-waitpid.c: Fix common/ includes.
6004         * nat/linux-ptrace.h: Fix common/ includes.
6005         * nat/linux-ptrace.c: Fix common/ includes.
6006         * nat/linux-procfs.c: Fix common/ includes.
6007         * nat/linux-personality.c: Fix common/ includes.
6008         * nat/linux-osdata.c: Fix common/ includes.
6009         * nat/linux-namespaces.c: Fix common/ includes.
6010         * nat/linux-btrace.h: Fix common/ includes.
6011         * nat/linux-btrace.c: Fix common/ includes.
6012         * nat/fork-inferior.c: Fix common/ includes.
6013         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6014         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6015         * nat/aarch64-linux.c: Fix common/ includes.
6016         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6017         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6018         * namespace.h: Fix common/ includes.
6019         * mips-linux-tdep.c: Fix common/ includes.
6020         * minsyms.c: Fix common/ includes.
6021         * mi/mi-parse.h: Fix common/ includes.
6022         * mi/mi-main.c: Fix common/ includes.
6023         * mi/mi-cmd-env.c: Fix common/ includes.
6024         * memrange.h: Fix common/ includes.
6025         * memattr.c: Fix common/ includes.
6026         * maint.h: Fix common/ includes.
6027         * maint.c: Fix common/ includes.
6028         * main.c: Fix common/ includes.
6029         * machoread.c: Fix common/ includes.
6030         * location.c: Fix common/ includes.
6031         * linux-thread-db.c: Fix common/ includes.
6032         * linux-nat.c: Fix common/ includes.
6033         * linux-fork.c: Fix common/ includes.
6034         * inline-frame.c: Fix common/ includes.
6035         * infrun.c: Fix common/ includes.
6036         * inflow.c: Fix common/ includes.
6037         * inferior.h: Fix common/ includes.
6038         * inferior.c: Fix common/ includes.
6039         * infcmd.c: Fix common/ includes.
6040         * inf-ptrace.c: Fix common/ includes.
6041         * inf-child.c: Fix common/ includes.
6042         * ia64-linux-nat.c: Fix common/ includes.
6043         * i387-tdep.c: Fix common/ includes.
6044         * i386-tdep.c: Fix common/ includes.
6045         * i386-linux-tdep.c: Fix common/ includes.
6046         * i386-linux-nat.c: Fix common/ includes.
6047         * i386-go32-tdep.c: Fix common/ includes.
6048         * i386-fbsd-tdep.c: Fix common/ includes.
6049         * i386-fbsd-nat.c: Fix common/ includes.
6050         * guile/scm-type.c: Fix common/ includes.
6051         * guile/guile.c: Fix common/ includes.
6052         * go32-nat.c: Fix common/ includes.
6053         * gnu-nat.c: Fix common/ includes.
6054         * gdbthread.h: Fix common/ includes.
6055         * gdbarch-selftests.c: Fix common/ includes.
6056         * gdb_usleep.c: Fix common/ includes.
6057         * gdb_select.h: Fix common/ includes.
6058         * gdb_bfd.c: Fix common/ includes.
6059         * gcore.c: Fix common/ includes.
6060         * fork-child.c: Fix common/ includes.
6061         * findvar.c: Fix common/ includes.
6062         * fbsd-nat.c: Fix common/ includes.
6063         * event-top.c: Fix common/ includes.
6064         * event-loop.c: Fix common/ includes.
6065         * dwarf2read.c: Fix common/ includes.
6066         * dwarf2loc.c: Fix common/ includes.
6067         * dwarf2-frame.c: Fix common/ includes.
6068         * dwarf-index-cache.c: Fix common/ includes.
6069         * dtrace-probe.c: Fix common/ includes.
6070         * disasm-selftests.c: Fix common/ includes.
6071         * defs.h: Fix common/ includes.
6072         * csky-tdep.c: Fix common/ includes.
6073         * cp-valprint.c: Fix common/ includes.
6074         * cp-support.h: Fix common/ includes.
6075         * cp-support.c: Fix common/ includes.
6076         * corelow.c: Fix common/ includes.
6077         * completer.h: Fix common/ includes.
6078         * completer.c: Fix common/ includes.
6079         * compile/compile.c: Fix common/ includes.
6080         * compile/compile-loc2c.c: Fix common/ includes.
6081         * compile/compile-cplus-types.c: Fix common/ includes.
6082         * compile/compile-cplus-symbols.c: Fix common/ includes.
6083         * command.h: Fix common/ includes.
6084         * cli/cli-dump.c: Fix common/ includes.
6085         * cli/cli-cmds.c: Fix common/ includes.
6086         * charset.c: Fix common/ includes.
6087         * build-id.c: Fix common/ includes.
6088         * btrace.h: Fix common/ includes.
6089         * btrace.c: Fix common/ includes.
6090         * breakpoint.h: Fix common/ includes.
6091         * breakpoint.c: Fix common/ includes.
6092         * ax.h:
6093         (enum agent_op): Fix common/ includes.
6094         * ax-general.c (struct aop_map): Fix common/ includes.
6095         * ax-gdb.c: Fix common/ includes.
6096         * auxv.c: Fix common/ includes.
6097         * auto-load.c: Fix common/ includes.
6098         * arm-tdep.c: Fix common/ includes.
6099         * arch/riscv.c: Fix common/ includes.
6100         * arch/ppc-linux-common.c: Fix common/ includes.
6101         * arch/i386.c: Fix common/ includes.
6102         * arch/arm.c: Fix common/ includes.
6103         * arch/arm-linux.c: Fix common/ includes.
6104         * arch/arm-get-next-pcs.c: Fix common/ includes.
6105         * arch/amd64.c: Fix common/ includes.
6106         * arch/aarch64.c: Fix common/ includes.
6107         * arch/aarch64-insn.c: Fix common/ includes.
6108         * arch-utils.c: Fix common/ includes.
6109         * amd64-windows-tdep.c: Fix common/ includes.
6110         * amd64-tdep.c: Fix common/ includes.
6111         * amd64-sol2-tdep.c: Fix common/ includes.
6112         * amd64-obsd-tdep.c: Fix common/ includes.
6113         * amd64-nbsd-tdep.c: Fix common/ includes.
6114         * amd64-linux-tdep.c: Fix common/ includes.
6115         * amd64-linux-nat.c: Fix common/ includes.
6116         * amd64-fbsd-tdep.c: Fix common/ includes.
6117         * amd64-fbsd-nat.c: Fix common/ includes.
6118         * amd64-dicos-tdep.c: Fix common/ includes.
6119         * amd64-darwin-tdep.c: Fix common/ includes.
6120         * agent.c: Fix common/ includes.
6121         * ada-lang.h: Fix common/ includes.
6122         * ada-lang.c: Fix common/ includes.
6123         * aarch64-tdep.c: Fix common/ includes.
6124
6125 2019-01-25  Tom Tromey  <tom@tromey.com>
6126
6127         * common/create-version.sh: Use common/version.h.
6128
6129 2019-01-24  Pedro Alves  <palves@redhat.com>
6130
6131         * infrun.c (signal_stop, signal_print, signal_program)
6132         (signal_catch, signal_pass): Now arrays instead of pointers.
6133         (update_signals_program_target, do_target_resume)
6134         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6135         * linux-nat.c (linux_nat_target::pass_signals)
6136         (linux_nat_target::create_inferior, linux_nat_target::attach):
6137         Adjust.
6138         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6139         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6140         * procfs.c (procfs_target::pass_signals): Adjust.
6141         * record-full.c (record_full_target::resume): Adjust.
6142         * remote.c (remote_target::pass_signals)
6143         (remote_target::program_signals): Adjust.
6144         * target-debug.h (target_debug_print_signals): Now takes a
6145         gdb::array_view as parameter.  Adjust.
6146         * target.h (target_ops) <pass_signals, program_signals>: Replace
6147         pointer and length parameters with gdb::array_view.
6148         (target_pass_signals, target_program_signals): Likewise.
6149         * target-delegates.c: Regenerate.
6150
6151 2019-01-24  Pedro Alves  <palves@redhat.com>
6152
6153         * common/forward-scope-exit.h
6154         (forward_scope_exit::forward_scope_exit): Pass arguments to
6155         m_bind_function directly, instead of creating a std::bind and
6156         copying that.
6157
6158 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6159
6160         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6161         for static members.
6162         (pass_in_v_vfp_candidate): Likewise.
6163
6164 2019-01-23  Tom Tromey  <tom@tromey.com>
6165             Pedro Alves  <palves@redhat.com>
6166
6167         * regcache.c (class regcache_invalidator): Remove.
6168         (regcache::raw_write): Use make_scope_exit.
6169
6170 2019-01-23  Tom Tromey  <tom@tromey.com>
6171
6172         * ui-out.h (class ui_out_emit_type): Update comment.
6173
6174 2019-01-23  Tom Tromey  <tom@tromey.com>
6175
6176         * infrun.c (fetch_inferior_event): Update comment.
6177
6178 2019-01-23  Tom Tromey  <tom@tromey.com>
6179             Pedro Alves  <palves@redhat.com>
6180
6181         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6182         parameter.
6183         (fetch_inferior_event): Use SCOPE_EXIT.
6184
6185
6186 2019-01-23  Tom Tromey  <tom@tromey.com>
6187             Pedro Alves  <palves@redhat.com>
6188
6189         * infrun.c (disable_thread_events): Delete.
6190         (stop_all_threads): Use SCOPE_EXIT.
6191
6192 2019-01-23  Tom Tromey  <tom@tromey.com>
6193             Pedro Alves  <palves@redhat.com>
6194
6195         * symfile.c: Include forward-scope-exit.h.
6196         (clear_symtab_users_cleanup): Replace forward declaration with
6197         a FORWARD_SCOPE_EXIT.
6198         (syms_from_objfile_1): Use the forward_scope_exit and
6199         gdb::optional instead of cleanup_function.
6200         (reread_symbols): Use the forward_scope_exit instead of
6201         cleanup_function.
6202         (clear_symtab_users_cleanup): Remove function.
6203
6204 2019-01-23  Tom Tromey  <tom@tromey.com>
6205             Pedro Alves  <palves@redhat.com>
6206
6207         * linux-nat.c: Include scope-exit.h.
6208         (cleanup_target_stop): Remove.
6209         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6210         SCOPE_EXIT.
6211
6212 2019-01-23  Tom Tromey  <tom@tromey.com>
6213             Pedro Alves  <palves@redhat.com>
6214
6215         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6216         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6217
6218 2019-01-23  Tom Tromey  <tom@tromey.com>
6219             Andrew Burgess  <andrew.burgess@embecosm.com>
6220             Pedro Alves  <palves@redhat.com>
6221
6222         * infrun.c (fetch_inferior_event): Use scope_exit.
6223         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6224         * top.c (execute_command): Use scope_exit.
6225         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6226         * utils.c (do_bpstat_clear_actions_cleanup)
6227         (make_bpstat_clear_actions_cleanup): Remove.
6228
6229 2019-01-23  Tom Tromey  <tom@tromey.com>
6230             Pedro Alves  <palves@redhat.com>
6231
6232         * infrun.c: Include "common/scope-exit.h"
6233         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6234         (wait_for_inferior): Use SCOPE_EXIT.
6235         (fetch_inferior_event): Use scope_exit.
6236
6237 2019-01-23  Tom Tromey  <tom@tromey.com>
6238             Pedro Alves  <palves@redhat.com>
6239
6240         * breakpoint.c (create_breakpoint): Remove cleanup.
6241
6242 2019-01-23  Tom Tromey  <tom@tromey.com>
6243             Andrew Burgess  <andrew.burgess@embecosm.com>
6244             Pedro Alves  <palves@redhat.com>
6245
6246 2019-01-23  Pedro Alves  <palves@redhat.com>
6247
6248         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6249
6250 2019-01-23  Pedro Alves  <palves@redhat.com>
6251             Andrew Burgess  <andrew.burgess@embecosm.com>
6252
6253         * gdbthread.h: Include "common/forward-scope-exit.h".
6254         (scoped_finish_thread_state): Redefine custom class in terms of
6255         forward_scope_exit.
6256
6257 2019-01-23  Pedro Alves  <palves@redhat.com>
6258             Andrew Burgess  <andrew.burgess@embecosm.com>
6259
6260         * common/forward-scope-exit.h: New file.
6261
6262 2019-01-23  Pedro Alves  <palves@redhat.com>
6263             Andrew Burgess  <andrew.burgess@embecosm.com>
6264             Tom Tromey  <tom@tromey.com>
6265
6266         * common/scope-exit.h: New file.
6267
6268 2019-01-23  Pedro Alves  <palves@redhat.com>
6269
6270         * common/preprocessor.h (ESC): Rename to ...
6271         (ESC_PARENS): ... this.
6272         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6273         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6274
6275 2019-01-23  Tom Tromey  <tom@tromey.com>
6276
6277         * language.h (class scoped_switch_to_sym_language_if_auto):
6278         Initialize m_lang in both cases.
6279
6280 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6281
6282         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6283         with XCNEW.
6284
6285 2019-01-22  Tom Tromey  <tom@tromey.com>
6286
6287         * corelow.c: Do not include sys/file.h.
6288
6289 2019-01-22  Tom Tromey  <tom@tromey.com>
6290
6291         * tui/tui-wingeneral.h: Include gdb_curses.h.
6292
6293 2019-01-22  Tom Tromey  <tom@tromey.com>
6294
6295         * source-cache.h (class source_cache) <get_source_lines,
6296         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6297
6298 2019-01-22  Tom Tromey  <tom@tromey.com>
6299
6300         * remote-fileio.h (struct remote_target): Declare.
6301
6302 2019-01-22  Tom Tromey  <tom@tromey.com>
6303
6304         * python/py-arch.c: Do not include py-ref.h.
6305         * python/py-bpevent.c: Do not include py-ref.h.
6306         * python/py-cmd.c: Do not include py-ref.h.
6307         * python/py-continueevent.c: Do not include py-ref.h.
6308         * python/py-event.h: Do not include py-ref.h.
6309         * python/py-evtregistry.c: Do not include py-ref.h.
6310         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6311         * python/py-frame.c: Do not include py-ref.h.
6312         * python/py-framefilter.c: Do not include py-ref.h.
6313         * python/py-function.c: Do not include py-ref.h.
6314         * python/py-infevents.c: Do not include py-ref.h.
6315         * python/py-linetable.c: Do not include py-ref.h.
6316         * python/py-objfile.c: Do not include py-ref.h.
6317         * python/py-param.c: Do not include py-ref.h.
6318         * python/py-prettyprint.c: Do not include py-ref.h.
6319         * python/py-progspace.c: Do not include py-ref.h.
6320         * python/py-symbol.c: Do not include py-ref.h.
6321         * python/py-symtab.c: Do not include py-ref.h.
6322         * python/py-type.c: Do not include py-ref.h.
6323         * python/py-unwind.c: Do not include py-ref.h.
6324         * python/py-utils.c: Do not include py-ref.h.
6325         * python/py-value.c: Do not include py-ref.h.
6326         * python/py-varobj.c: Do not include py-ref.h.
6327         * python/py-xmethods.c: Do not include py-ref.h.
6328         * python/python.c: Do not include py-ref.h.
6329         * varobj.c: Do not include py-ref.h.
6330
6331 2019-01-22  Tom Tromey  <tom@tromey.com>
6332
6333         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6334         keyword for bcache.
6335
6336 2019-01-22  Tom Tromey  <tom@tromey.com>
6337
6338         * compile/compile-cplus-types.c: Remove a comment by #include.
6339
6340 2019-01-22  Tom Tromey  <tom@tromey.com>
6341
6342         * compile/gcc-c-plugin.h: Include compile-internal.h.
6343
6344 2019-01-22  Tom Tromey  <tom@tromey.com>
6345
6346         * stabsread.c (EXTERN): Do not define.
6347         (symnum, next_symbol_text_func, processing_gcc_compilation)
6348         (within_function, global_sym_chain, global_stabs)
6349         (previous_stab_code, this_object_header_files)
6350         (n_this_object_header_files)
6351         (n_allocated_this_object_header_files): Define.
6352         * stabsread.h (EXTERN): Never define.  Use "extern".
6353
6354 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6355
6356         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6357         history_value.
6358
6359 2019-01-21  Tom Tromey  <tom@tromey.com>
6360
6361         * ui-out.c: Fix includes.
6362         * tui/tui-source.c: Fix includes.
6363         * target.c: Fix includes.
6364         * remote.c: Fix includes.
6365         * regcache.c: Fix includes.
6366         * python/py-block.c: Fix includes.
6367         * printcmd.c: Fix includes.
6368         * or1k-tdep.c: Fix includes.
6369         * mi/mi-main.c: Fix includes.
6370         * m32r-tdep.c: Fix includes.
6371         * csky-tdep.c: Fix includes.
6372         * compile/compile-cplus-types.c: Fix includes.
6373         * cli/cli-interp.c: Fix includes.
6374
6375 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6376
6377         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6378         for padding.
6379
6380 2019-01-16  Tom Tromey  <tom@tromey.com>
6381
6382         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6383         earlier.
6384         (struct objfile) <msymbols_range>: Move from top level.
6385         <msymbols>: New method.
6386         (class objfile_msymbols): Remove.
6387         * symtab.c (default_collect_symbol_completion_matches_break_on):
6388         Update.
6389         * symmisc.c (dump_msymbols): Update.
6390         * stabsread.c (scan_file_globals): Update.
6391         * objc-lang.c (info_selectors_command, info_classes_command)
6392         (find_methods): Update.
6393         * minsyms.c (find_solib_trampoline_target): Update.
6394         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6395         * coffread.c (coff_symfile_read): Update.
6396         * ada-lang.c (ada_lookup_simple_minsym)
6397         (ada_collect_symbol_completion_matches): Update.
6398
6399 2019-01-16  Tom Tromey  <tom@tromey.com>
6400
6401         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6402         type.  Remove no-argument constructor.
6403         <iterator::operator++>: Simplify.
6404         <begin>: Update.
6405         <end>: Use minimal_symbol_count.
6406
6407 2019-01-16  Tom Tromey  <tom@tromey.com>
6408
6409         * objfiles.h (struct objfile) <psymtabs>: New method.
6410         (class objfile_psymtabs): Remove.
6411         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6412         typedef.
6413         <range>: New method.
6414         (require_partial_symbols): Change return type.
6415         * psymtab.c (require_partial_symbols)
6416         (psym_expand_symtabs_matching): Update.
6417         * mdebugread.c (parse_partial_symbols): Update.
6418         * dbxread.c (dbx_end_psymtab): Update.
6419
6420 2019-01-15  Tom Tromey  <tom@tromey.com>
6421
6422         * symtab.c (lookup_objfile_from_block)
6423         (lookup_symbol_in_objfile_symtabs)
6424         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6425         (find_line_symtab, info_sources_command)
6426         (default_collect_symbol_completion_matches_break_on)
6427         (make_source_files_completion_list): Update.
6428         * symmisc.c (print_objfile_statistics, dump_objfile)
6429         (maintenance_print_symbols, maintenance_info_symtabs)
6430         (maintenance_check_symtabs, maintenance_info_line_tables):
6431         Update.
6432         * source.c (select_source_symtab)
6433         (forget_cached_source_info_for_objfile): Update.
6434         * objfiles.h (class objfile_compunits): Remove.
6435         (struct objfile) <compunits_range>: New typedef.
6436         (compunits): New method.
6437         * objfiles.c (objfile_relocate1): Update.
6438         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6439         * maint.c (count_symtabs_and_blocks): Update.
6440         * linespec.c (iterate_over_all_matching_symtabs): Update.
6441         * cp-support.c (add_symbol_overload_list_qualified): Update.
6442         * coffread.c (coff_symtab_read): Update.
6443         * ada-lang.c (add_nonlocal_symbols)
6444         (ada_collect_symbol_completion_matches)
6445         (ada_add_global_exceptions): Update.
6446
6447 2019-01-15  Tom Tromey  <tom@tromey.com>
6448
6449         * progspace.h (program_space) <objfiles_safe_range>: New
6450         typedef.
6451         <objfiles_safe>: New method.
6452         * objfiles.h (class all_objfiles_safe): Remove.
6453         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6454         * jit.c (jit_inferior_exit_hook): Update.
6455
6456 2019-01-17  Tom Tromey  <tom@tromey.com>
6457
6458         * progspace.h (program_space) <objfiles_range>: New typedef.
6459         <objfiles>: New method.
6460         <objfiles_head>: Rename from objfiles.
6461         (object_files): Update.
6462         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6463         * guile/scm-pretty-print.c
6464         (ppscm_find_pretty_printer_from_objfiles): Update.
6465         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6466         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6467         Update.
6468         * python/py-progspace.c (pspy_get_objfiles): Update.
6469         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6470         Update.
6471         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6472         (objfpy_lookup_objfile_by_build_id): Update.
6473         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6474         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6475         Update.
6476         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6477         (expand_symtab_containing_pc, lookup_objfile_from_block)
6478         (lookup_static_symbol, basic_lookup_transparent_type)
6479         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6480         (find_line_symtab, info_sources_command)
6481         (default_collect_symbol_completion_matches_break_on)
6482         (make_source_files_completion_list, find_main_name): Update.
6483         * symmisc.c (print_symbol_bcache_statistics)
6484         (print_objfile_statistics, maintenance_print_symbols)
6485         (maintenance_print_msymbols, maintenance_print_objfiles)
6486         (maintenance_info_symtabs, maintenance_check_symtabs)
6487         (maintenance_expand_symtabs, maintenance_info_line_tables):
6488         Update.
6489         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6490         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6491         (map_overlay_command, unmap_overlay_command)
6492         (simple_overlay_update, expand_symtabs_matching)
6493         (map_symbol_filenames): Update.
6494         * symfile-debug.c (set_debug_symfile): Update.
6495         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6496         Update.
6497         * source.c (select_source_symtab, forget_cached_source_info):
6498         Update.
6499         * solib.c (solib_read_symbols): Update.
6500         * solib-spu.c (append_ocl_sos): Update.
6501         * psymtab.c (maintenance_print_psymbols)
6502         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6503         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6504         * printcmd.c (info_symbol_command): Update.
6505         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6506         Update.
6507         * objfiles.h (class all_objfiles): Remove.
6508         * objfiles.c (have_partial_symbols, have_full_symbols)
6509         (have_minimal_symbols, qsort_cmp, update_section_map)
6510         (shared_objfile_contains_address_p)
6511         (default_iterate_over_objfiles_in_search_order): Update.
6512         * objc-lang.c (info_selectors_command, info_classes_command)
6513         (find_methods): Update.
6514         * minsyms.c (find_solib_trampoline_target): Update.
6515         * maint.c (maintenance_info_sections)
6516         (maintenance_translate_address, count_symtabs_and_blocks):
6517         Update.
6518         * main.c (captured_main_1): Update.
6519         * linux-thread-db.c (try_thread_db_load_from_pdir)
6520         (has_libpthread): Update.
6521         * linespec.c (iterate_over_all_matching_symtabs)
6522         (search_minsyms_for_name): Update.
6523         * jit.c (jit_find_objf_with_entry_addr): Update.
6524         * hppa-tdep.c (find_unwind_entry)
6525         (hppa_lookup_stub_minimal_symbol): Update.
6526         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6527         Update.
6528         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6529         (elf_gnu_ifunc_resolve_by_got): Update.
6530         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6531         * dwarf-index-write.c (save_gdb_index_command): Update.
6532         * cp-support.c (add_symbol_overload_list_qualified): Update.
6533         * breakpoint.c (create_overlay_event_breakpoint)
6534         (create_longjmp_master_breakpoint)
6535         (create_std_terminate_master_breakpoint)
6536         (create_exception_master_breakpoint): Update.
6537         * blockframe.c (find_pc_partial_function): Update.
6538         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6539         (ada_collect_symbol_completion_matches)
6540         (ada_add_global_exceptions): Update.
6541
6542 2019-01-17  Tom Tromey  <tom@tromey.com>
6543
6544         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6545         declare VEC.
6546         (solib_target_parse_libraries): Change return type.
6547         (library_list_start_segment, library_list_start_section)
6548         (library_list_end_library, library_list_start_library); Update.
6549         (solib_target_free_library_list): Remove.
6550         (solib_target_parse_libraries): Remove cleanup.  Change return
6551         type.
6552         (solib_target_current_sos): Update.
6553
6554 2019-01-17  Tom Tromey  <tromey@bapiya>
6555
6556         * valprint.c: Replace "the the" with "the".
6557         * symtab.c: Replace "the the" with "the".
6558         * solib.c: Replace "the the" with "the".
6559         * solib-dsbt.c: Replace "the the" with "the".
6560         * linespec.c: Replace "the the" with "the".
6561         * dwarf2loc.h: Replace "the the" with "the".
6562         * amd64-windows-tdep.c: Replace "the the" with "the".
6563         * aarch64-tdep.c: Replace "the the" with "the".
6564
6565 2019-01-16  Keith Seitz  <keiths@redhat.com>
6566
6567         PR gdb/23773
6568         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6569         <builder>: Rename to ..
6570         <m_builder>: ... this and make private.
6571         (dwarf2_cu::get_builder): New method.  Change all users of
6572         `builder' to use this method.
6573         (dwarf2_start_symtab): Move to ...
6574         (dwarf2_cu::start_symtab): ... here.  Update all callers
6575         (setup_type_unit_groups): Move to ...
6576         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6577         callers.
6578         (dwarf2_cu::reset_builder): New method.
6579         (process_full_compunit, process_full_type_unit): Use
6580         dwarf2_cu::reset_builder.
6581         (follow_die_offset): Record the ancestor CU if it is different
6582         from the followed DIE's CU.
6583         (follow_die_sig_1): Likewise.
6584
6585 2019-01-15  Tom Tromey  <tom@tromey.com>
6586
6587         * remote.c (class remote_state) <buf>: Now a char_vector.
6588         <buf_size>: Remove.
6589         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6590         parameter.
6591         (remote_target::getpkt_or_notif_sane_1)
6592         (remote_target::getpkt_sane)
6593         (remote_target::getpkt_or_notif_sane): Likewise.
6594         (class remote_target) <putpkt>: New overload.
6595         (remote_target::read_frame): Change type of "buf_p".  Remove
6596         sizeof_p parameter.
6597         (packet_ok): New overload.
6598         (packet_check_result): New overload.
6599         Update all uses.
6600
6601 2019-01-14  Tom Tromey  <tom@tromey.com>
6602
6603         * remote-notif.c (handle_notification, remote_notif_ack)
6604         (remote_notif_parse): Make "buf" const.
6605         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
6606         const.
6607         (remote_notif_parse, remote_notif_ack, handle_notification):
6608         Likewise.
6609         * remote.c (remote_notif_stop_parse): Make "buf" const.
6610         (remote_target::remote_parse_stop_reply): Make "buf" const.
6611         (remote_notif_stop_ack): Make "buf" const.
6612
6613 2019-01-14  Tom Tromey  <tom@tromey.com>
6614
6615         * remote.c (remote_console_output): Make parameter const.
6616
6617 2019-01-14  Tom Tromey  <tom@tromey.com>
6618
6619         * target-debug.h (target_debug_print_signals): Constify.
6620         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
6621         * procfs.c (procfs_target::pass_signals): Update.
6622         * linux-nat.c (linux_nat_target::pass_signals): Update.
6623         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
6624         * target-delegates.c: Rebuild.
6625         * remote.c (remote_target::program_signals): Update.
6626         (remote_target::pass_signals): Update.
6627         * target.c (target_pass_signals): Constify argument.
6628         (target_program_signals): Likewise.
6629         * target.h (struct target_ops) <pass_signals, program_signals>:
6630         Constify argument.
6631         (target_pass_signals, target_program_signals): Constify argument.
6632
6633 2019-01-14  Tom Tromey  <tom@tromey.com>
6634
6635         PR tui/28819:
6636         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
6637
6638 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6639
6640         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
6641         field.
6642         * rs6000-tdep.c: Include reggroups.h.
6643         (IS_V_ALIAS_PSEUDOREG): Define.
6644         (rs6000_register_name): Return names for the "vX" aliases.
6645         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
6646         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
6647         aliases.  Call default_register_reggroup_p for all other
6648         pseudo-registers.
6649         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
6650         New functions.
6651         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
6652         Handle "vX" aliases.
6653         (v_alias_pseudo_register_collect): New function.
6654         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
6655         (rs6000_gdbarch_init): Initialize "vX" aliases as
6656         pseudo-registers.  Restore registration of
6657         rs6000_pseudo_register_reggroup_p with
6658         set_tdesc_pseudo_register_reggroup_p.
6659
6660 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
6661
6662         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
6663         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
6664         set_gdbarch_num_pseudo_regs.
6665
6666 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6667
6668         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
6669         Remove arg prefixname, add do_set and do_show.
6670         Add member functions set_list and show_list.
6671         * cli/cli-style.c (class cli_style_option): Update accordingly.
6672         (style_set_list): Move to file scope.
6673         (style_show_list): Likewise.
6674         (set_style): Call help_list.
6675         (show_style): Call cmd_show_list.
6676         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
6677         Update to use the new macro.
6678
6679 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
6680
6681         * ada-lang.c (_initialize_ada_language): Expand the help text
6682         for the "catch exception" command.
6683
6684 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6685
6686         * symtab.c (matching_obj_sections): Initialize obj,
6687         declare it closer to its usage.
6688
6689 2019-01-10  Tom Tromey  <tom@tromey.com>
6690
6691         * thread-iter.h (inf_threads_iterator): Use next_iterator.
6692         (basic_inf_threads_range): Remove.
6693         (inf_threads_range, inf_non_exited_threads_range)
6694         (safe_inf_threads_range): Use next_adapter.
6695
6696 2019-01-10  Keith Seitz  <keiths@redhat.com>
6697
6698         PR gdb/23712
6699         PR symtab/23010
6700         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
6701         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
6702
6703 2019-01-10  Keith Seitz  <keiths@redhat.com>
6704
6705         PR gdb/23712
6706         PR symtab/23010
6707         * dictionary.c (pending_to_vector): Remove.
6708         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6709         Remove _1 suffix, replacing functions of the same name.  Update
6710         all callers.
6711         (dict_create_hashed, dict_create_hashed_expandable)
6712         (dict_create_linear, dict_create_linear_expandable, dict_free)
6713         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
6714         Make functions static.
6715
6716 2019-01-10  Keith Seitz  <keiths@redhat.com>
6717
6718         PR gdb/23712
6719         PR symtab/23010
6720         * dictionary.h (struct dictionary): Replace declaration with
6721         multidictionary.
6722         (dict_create_hashed, dict_create_hashed_expandable)
6723         (dict_create_linear, dict_create_linear_expandable)
6724         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
6725         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
6726         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
6727         taking multidictionary argument.
6728         [ALL_DICT_SYMBOLS]: Update for multidictionary.
6729         * block.h (struct block) <dict>: Change to multidictionary
6730         and rename `multidict'.
6731         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
6732         symmisc.c: Update all dictionary references to multidictionary.
6733
6734 2019-01-10  Keith Seitz  <keiths@redhat.com>
6735
6736         PR gdb/23712
6737         PR symtab/23010
6738         * dictionary.c: Include unordered_map.
6739         (pending_to_vector): New function.
6740         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
6741         Rewrite the non-"_1" functions to take vector instead
6742         of linked list.
6743         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
6744         "new" _1 versions of the same name.
6745         (multidictionary): Define.
6746         (std::hash<enum language): New definition.
6747         (collate_pending_symbols_by_language, mdict_create_hashed)
6748         (mdict_create_hashed_expandable, mdict_create_linear)
6749         (mdict_create_linear_expandable, mdict_free)
6750         (find_language_dictionary, create_new_language_dictionary)
6751         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
6752         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
6753         (mdict_size, mdict_empty): New functions.
6754         * dictionary.h (mdict_iterator): Define.
6755
6756 2019-01-10  Pedro Alves  <palves@redhat.com>
6757
6758         * breakpoint.c (read_uploaded_action)
6759         (create_tracepoint_from_upload): Adjust to use
6760         gdb::unique_xmalloc_ptr.
6761         * ctf.c (ctf_write_uploaded_tp):
6762         (SET_ARRAY_FIELD): Use emplace_back.
6763         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
6764         * tracefile-tfile.c (tfile_write_uploaded_tp):
6765         * tracepoint.c (parse_tracepoint_definition): Adjust to use
6766         gdb::unique_xmalloc_ptr.
6767         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
6768         at_string, cond_string, cmd_strings>: Replace char pointers
6769         with gdb::unique_xmalloc_ptr.
6770
6771 2019-01-10  Pedro Alves  <palves@redhat.com>
6772
6773         * solib-target.c (library_list_start_library): Don't xstrdup name.
6774
6775 2019-01-10  Pedro Alves  <palves@redhat.com>
6776
6777         * mdebugread.c (parse_partial_symbols): Use
6778         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
6779
6780 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6781
6782         * linux-fork.c (scoped_switch_fork_info)
6783         <~scoped_switch_fork_info>: Fix incorrect variable name.
6784
6785 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
6786
6787         * linux-fork.c (scoped_switch_fork_info)
6788         <scoped_switch_fork_info>: Make explicit.
6789         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
6790
6791 2019-01-10  Tom Tromey  <tom@tromey.com>
6792
6793         * objfiles.h (objfile::reset_psymtabs): Update.
6794         * objfiles.c (objfile::objfile): Update.
6795         * psymtab.h (psymtab_storage::obstack): Update.
6796         (psymtab_storage::m_obstack): Use gdb::optional.
6797         (class psymtab_storage): Update comment.  Remove objfile
6798         parameter.
6799         * psymtab.c (psymtab_storage::psymtab_storage): Update.
6800
6801 2019-01-10  Tom Tromey  <tom@tromey.com>
6802
6803         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
6804         <free_psymtabs>: Now private.
6805         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
6806         (allocate_psymtab): Use new method.
6807
6808 2019-01-10  Tom Tromey  <tom@tromey.com>
6809
6810         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
6811         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
6812         * mdebugread.c (parse_partial_symbols): Use
6813         allocate_dependencies.
6814         * dwarf2read.c (dwarf2_create_include_psymtab): Use
6815         allocate_dependencies.
6816         (process_psymtab_comp_unit_reader)
6817         (build_type_psymtab_dependencies): Likewise.
6818         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
6819
6820 2019-01-10  Tom Tromey  <tom@tromey.com>
6821
6822         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
6823         PSYMBOL_SET_LANGUAGE.
6824         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
6825
6826 2019-01-10  Tom Tromey  <tom@tromey.com>
6827
6828         * psymtab.h (psymtab_storage::obstack): New method.
6829         <m_obstack>: Rename from obstack; now private.
6830         * psymtab.c (psymtab_storage): Update.
6831         * dwarf2read.c (create_addrmap_from_index)
6832         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
6833         Update.
6834
6835 2019-01-10  Tom Tromey  <tom@tromey.com>
6836
6837         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
6838         * objfiles.h (objfile::reset_psymtabs): New method.
6839
6840 2019-01-10  Tom Tromey  <tom@tromey.com>
6841
6842         * symmisc.c (print_symbol_bcache_statistics): Update.
6843         (print_objfile_statistics): Update.
6844         * symfile.c (reread_symbols): Update.
6845         * psymtab.h (class psymtab_storage): New.
6846         * psymtab.c (psymtab_storage): New constructor.
6847         (~psymtab_storage): New destructor.
6848         (require_partial_symbols): Update.
6849         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
6850         (find_pc_sect_psymtab, find_pc_sect_psymbol)
6851         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
6852         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
6853         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
6854         (start_psymtab_common, end_psymtab_common)
6855         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
6856         (allocate_psymtab): Update.
6857         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
6858         Update.
6859         (dump_psymtab_addrmap, maintenance_print_psymbols)
6860         (maintenance_check_psymtabs): Update.
6861         (class objfile_psymtabs): Move to objfiles.h.
6862         * psympriv.h (discard_psymtab): Now inline.
6863         (psymtab_discarder::psymtab_discarder): Update.
6864         (psymtab_discarder::~psymtab_discarder): Update.
6865         (ALL_OBJFILE_PSYMTABS): Rewrite.
6866         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
6867         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
6868         Remove fields.
6869         <partial_symtabs>: New field.
6870         (class objfile_psymtabs): Move from psymtab.h.  Update.
6871         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
6872         psymbol_cache.
6873         (objfile::~objfile): Don't destroy psymbol_cache.
6874         * mdebugread.c (parse_partial_symbols): Update.
6875         * dwarf2read.c (create_addrmap_from_index)
6876         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6877         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
6878         (add_partial_subprogram, dwarf2_ranges_read): Update.
6879         * dwarf-index-write.c (write_address_map)
6880         (write_one_signatured_type, recursively_write_psymbols)
6881         (class debug_names, class debug_names, write_psymtabs_to_index):
6882         Update.
6883
6884 2019-01-10  Tom Tromey  <tom@tromey.com>
6885
6886         * symtab.h (SYMBOL_SET_NAMES): Update.
6887         (symbol_set_names): Update.
6888         (MSYMBOL_SET_NAMES): Update.
6889         * symtab.c (symbol_set_names): Change argument to be an
6890         objfile_per_bfd_storage.
6891         * psymtab.c (add_psymbol_to_bcache): Update.
6892         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
6893
6894 2019-01-10  Tom Tromey  <tom@tromey.com>
6895
6896         * symtab.c (create_demangled_names_hash): Change argument to be an
6897         objfile_per_bfd_storage.
6898         (symbol_set_names): Update.
6899
6900 2019-01-10  Tom Tromey  <tom@tromey.com>
6901
6902         * xcoffread.c (xcoff_initial_scan): Unconditionally call
6903         init_psymbol_list.
6904         * psymtab.c (init_psymbol_list): Do nothing if already called.
6905         * psympriv.h (init_psymbol_list): Add comment.
6906         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
6907         init_psymbol_list.
6908         * dbxread.c (dbx_symfile_read): Unconditionally call
6909         init_psymbol_list.
6910
6911 2019-01-10  Tom Tromey  <tom@tromey.com>
6912
6913         * xcoffread.c (scan_xcoff_symtab): Update.
6914         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
6915         "where".
6916         * mdebugread.c (parse_partial_symbols)
6917         (handle_psymbol_enumerators): Update.
6918         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
6919         * dbxread.c (read_dbx_symtab): Update.
6920         * psympriv.h (psymbol_placement): New enum.
6921         (add_psymbol_to_list): Update.
6922
6923 2019-01-10  Tom Tromey  <tom@tromey.com>
6924
6925         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
6926         static_psymbols parameters.
6927         (scan_xcoff_symtab): Update.
6928         * psymtab.c (start_psymtab_common): Remove global_psymbols and
6929         static_psymbols parameters.
6930         * psympriv.h (start_psymtab_common): Update.
6931         * mdebugread.c (parse_partial_symbols): Update.
6932         * dwarf2read.c (create_partial_symtab): Update.
6933         * dbxread.c (read_dbx_symtab): Update.
6934         (start_psymtab): Remove global_psymbols and static_psymbols
6935         parameters.
6936
6937 2019-01-10  Tom Tromey  <tom@tromey.com>
6938
6939         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
6940         * psymtab.c (allocate_psymtab): Add comment.
6941         * psympriv.h (allocate_psymtab): Add comment.
6942         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
6943         initializations.
6944         * dbxread.c (dbx_end_psymtab): Remove some initializations.
6945
6946 2019-01-10  Tom Tromey  <tom@tromey.com>
6947
6948         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6949         Don't declare.
6950         * mipsread.c: Include mdebugread.h.
6951         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
6952         Declare.
6953         * elfread.c: Include mdebugread.h.
6954
6955 2019-01-09  Tom Tromey  <tom@tromey.com>
6956
6957         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
6958         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
6959         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
6960         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
6961         (psym_lookup_symbol, psym_find_last_source_symtab)
6962         (psym_forget_cached_source_info, psym_print_stats)
6963         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
6964         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
6965         (psym_map_matching_symbols, psym_expand_symtabs_matching)
6966         (psym_find_compunit_symtab_by_address)
6967         (maintenance_print_psymbols, maintenance_info_psymtabs)
6968         (maintenance_check_psymtabs): Use ranged for.
6969         * psymtab.h (class objfile_psymtabs): New.
6970         (require_partial_symbols): Return objfile_psymtabs.
6971         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
6972
6973 2019-01-09  Tom Tromey  <tom@tromey.com>
6974
6975         * symfile.c (overlay_invalidate_all, find_pc_overlay)
6976         (find_pc_mapped_section, list_overlays_command)
6977         (map_overlay_command, unmap_overlay_command)
6978         (simple_overlay_update): Use all_objfiles.
6979         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
6980         * printcmd.c (info_symbol_command): Use all_objfiles.
6981         * objfiles.h (ALL_OBJSECTIONS): Remove.
6982         * maint.c (maintenance_translate_address): Use all_objfiles.
6983         * gcore.c (gcore_create_callback): Use all_objfiles.
6984         (objfile_find_memory_regions): Likewise.
6985
6986 2019-01-09  Tom Tromey  <tom@tromey.com>
6987
6988         * symtab.c (find_line_symtab, info_sources_command)
6989         (make_source_files_completion_list): Use objfile_compunits.
6990         * source.c (select_source_symtab): Use objfile_compunits.
6991         * objfiles.h (struct objfile): Update comment.
6992         (ALL_OBJFILES): Remove.
6993         (ALL_FILETABS): Remove.
6994         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
6995         objfile_compunits.
6996
6997 2019-01-09  Tom Tromey  <tom@tromey.com>
6998
6999         * symmisc.c (print_objfile_statistics, dump_objfile)
7000         (maintenance_print_symbols): Use compunit_filetabs.
7001         * source.c (forget_cached_source_info_for_objfile): Use
7002         compunit_filetabs.
7003         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7004         (ALL_FILETABS): Use compunit_filetabs.
7005         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7006         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7007
7008 2019-01-09  Tom Tromey  <tom@tromey.com>
7009
7010         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7011         (compunit_filetabs): New.
7012         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7013         compunit_filetabs.
7014         (info_sources_command, make_source_files_completion_list): Remove
7015         declaration.
7016         * symmisc.c (print_objfile_statistics, dump_objfile)
7017         (maintenance_print_symbols): Remove declaration.
7018         (maintenance_info_symtabs): Use compunit_filetabs.
7019         (maintenance_info_line_tables): Likewise.
7020         * source.c (select_source_symtab): Change local variable name.
7021         (forget_cached_source_info_for_objfile): Remove declaration.
7022         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7023         * objfiles.c (objfile_relocate1): Remove declaration.
7024         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7025         declaration.
7026         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7027         * coffread.c (coff_symtab_read): Remove declaration.
7028         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7029         compunit_filetabs.
7030
7031 2019-01-09  Tom Tromey  <tom@tromey.com>
7032
7033         * symtab.c (lookup_objfile_from_block)
7034         (find_pc_sect_compunit_symtab, search_symbols)
7035         (default_collect_symbol_completion_matches_break_on): Use
7036         objfile_compunits.
7037         * objfiles.h (ALL_COMPUNITS): Remove.
7038         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7039         * cp-support.c (add_symbol_overload_list_qualified): Use
7040         objfile_compunits.
7041         * ada-lang.c (ada_collect_symbol_completion_matches)
7042         (ada_add_global_exceptions): Use objfile_compunits.
7043
7044 2019-01-09  Tom Tromey  <tom@tromey.com>
7045
7046         * source.c (select_source_symtab)
7047         (forget_cached_source_info_for_objfile): Remove declaration.
7048         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7049         declaration.
7050         * maint.c (count_symtabs_and_blocks): Remove declaration.
7051         * cp-support.c (add_symbol_overload_list_qualified): Remove
7052         declaration.
7053         * coffread.c (coff_symtab_read): Remove declaration.
7054         * symtab.c (lookup_symbol_in_objfile_symtabs)
7055         (basic_lookup_transparent_type_1): Use objfile_compunits.
7056         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7057         (info_sources_command, search_symbols)
7058         (default_collect_symbol_completion_matches_break_on)
7059         (make_source_files_completion_list): Remove declaration.
7060         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7061         (ada_collect_symbol_completion_matches)
7062         (ada_add_global_exceptions): Remove declaration.
7063         * linespec.c (iterate_over_all_matching_symtabs): Use
7064         objfile_compunits.
7065         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7066         (class objfile_compunits): New.
7067         (ALL_COMPUNITS): Use objfile_compunits.
7068         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7069         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7070         objfile_compunits.
7071         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7072
7073 2019-01-09  Tom Tromey  <tom@tromey.com>
7074
7075         * symtab.c (search_symbols)
7076         (default_collect_symbol_completion_matches_break_on): Use
7077         objfile_msymbols.
7078         * ada-lang.c (ada_lookup_simple_minsym)
7079         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7080         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7081         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7082         objfile_msymbols.
7083         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7084         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7085         * objc-lang.c (find_methods): Use objfile_msymbols.
7086         (info_selectors_command, info_classes_command): Likewise.
7087         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7088         * objfiles.h (class objfile_msymbols): New.
7089         (ALL_OBJFILE_MSYMBOLS): Remove.
7090         (ALL_MSYMBOLS): Remove.
7091
7092 2019-01-09  Tom Tromey  <tom@tromey.com>
7093
7094         * common/next-iterator.h (next_adapter): Add Iterator template
7095         parameter.
7096         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7097         (class all_objfiles_safe): New.
7098         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7099         * objfiles.c (put_objfile_before): Update comment.
7100         (add_separate_debug_objfile): Likewise.
7101         (free_all_objfiles): Use all_objfiles_safe.
7102         (objfile_purge_solibs): Likewise.
7103
7104 2019-01-09  Tom Tromey  <tom@tromey.com>
7105
7106         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7107         (expand_symtab_containing_pc, lookup_static_symbol)
7108         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7109         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7110         all_objfiles.
7111         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7112         * breakpoint.c (create_overlay_event_breakpoint)
7113         (create_longjmp_master_breakpoint)
7114         (create_std_terminate_master_breakpoint)
7115         (create_exception_master_breakpoint): Use all_objfiles.
7116         * linux-thread-db.c (try_thread_db_load_from_pdir)
7117         (has_libpthread): Use all_objfiles.
7118         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7119         * linespec.c (iterate_over_all_matching_symtabs)
7120         (search_minsyms_for_name): Use all_objfiles.
7121         * maint.c (maintenance_info_sections): Use all_objfiles.
7122         * main.c (captured_main_1): Use all_objfiles.
7123         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7124         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7125         * guile/scm-pretty-print.c
7126         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7127         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7128         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7129         (maintenance_print_msymbols): Use all_objfiles.
7130         * source.c (select_source_symtab): Use all_objfiles.
7131         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7132         * symfile.c (remove_symbol_file_command)
7133         (expand_symtabs_matching, map_symbol_filenames): Use
7134         all_objfiles.
7135         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7136         all_objfiles.
7137         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7138         * objc-lang.c (find_methods): Use all_objfiles.
7139         * objfiles.c (have_partial_symbols, have_full_symbols)
7140         (have_minimal_symbols, qsort_cmp)
7141         (default_iterate_over_objfiles_in_search_order): Use
7142         all_objfiles.
7143         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7144         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7145         (maintenance_check_psymtabs): Use all_objfiles.
7146         (ALL_PSYMTABS): Remove.
7147         * compile/compile-object-run.c (do_module_cleanup): Use
7148         all_objfiles.
7149         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7150         * cp-support.c (add_symbol_overload_list_qualified): Use
7151         all_objfiles.
7152         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7153         Use all_objfiles.
7154         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7155         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7156         all_objfiles.
7157         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7158         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7159         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7160         Uses all_objfiles.
7161         * solib.c (solib_read_symbols): Use all_objfiles
7162
7163 2019-01-09  Tom Tromey  <tom@tromey.com>
7164
7165         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7166         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7167         all_objfiles.
7168         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7169         * symmisc.c (print_symbol_bcache_statistics)
7170         (print_objfile_statistics, maintenance_print_objfiles)
7171         (maintenance_info_symtabs, maintenance_check_symtabs)
7172         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7173         all_objfiles.
7174         * source.c (forget_cached_source_info): Use all_objfiles.
7175         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7176         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7177         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7178         * objfiles.c (update_section_map): Use all_objfiles.
7179         (shared_objfile_contains_address_p): Likewise.
7180         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7181         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7182
7183 2019-01-09  Tom Tromey  <tom@tromey.com>
7184
7185         * common/next-iterator.h: New file.
7186         * objfiles.h (class all_objfiles): New.
7187         (struct objfile_iterator): New.
7188
7189 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7190
7191         * NEWS: Move the description of the changed "frame", "select-frame",
7192          and "info frame" commands to the Changed commands section.
7193
7194 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7195
7196         * gdbtypes.c (check_stub_method_group): Remove handling of old
7197         mangling schemes.
7198         * linespec.c (find_methods): Likewise.
7199         * stabsread.c (read_member_functions): Likewise.
7200         * valops.c (search_struct_method): Likewise.
7201         (value_struct_elt_for_reference): Likewise.
7202         * NEWS: Mention this change.
7203
7204 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7205
7206         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7207         print_source_lines.
7208         * source.c (print_source_lines_base): Update line number check.
7209         (print_source_lines): New function.
7210         (source_lines_range::source_lines_range): New function.
7211         * source.h (class source_lines_range): New class.
7212         (print_source_lines): New declaration.
7213
7214 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7215
7216         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7217
7218 2019-01-08  Tom Tromey  <tom@tromey.com>
7219             Simon Marchi  <simon.marchi@ericsson.com>
7220
7221         PR gdb/24060
7222         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7223         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7224         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7225         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7226         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7227         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7228
7229 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7230
7231         * source.c (select_source_symtab): Move header comment to
7232         declaration in source.h.
7233         (forget_cached_source_info_for_objfile): Likewise.
7234         (forget_cached_source_info): Likewise.
7235         (identify_source_line): Likewise.
7236         * source.h (identify_source_line): Move declaration from symtab.h
7237         and add comment from source.c
7238         (print_source_lines): Likewise.
7239         (forget_cached_source_info_for_objfile): Likewise.
7240         (forget_cached_source_info): Likewise.
7241         (select_source_symtab): Likewise.
7242         (enum print_source_lines_flag): Move definition from symtab.h.
7243         * symtab.h (identify_source_line): Move declaration to source.h.
7244         (print_source_lines): Likewise.
7245         (forget_cached_source_info_for_objfile): Likewise.
7246         (forget_cached_source_info): Likewise.
7247         (select_source_symtab): Likewise.
7248         (enum print_source_lines_flag): Move definition to source.h.
7249         * tui/tui-hooks.c: Add 'source.h' include.
7250
7251 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7252
7253         * source.c (print_source_lines_base): Handle requests to print
7254         reverse line number sequences, and guard against empty lines
7255         string.
7256
7257 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7258
7259         * source.c (print_source_lines_base): Fix skip of '\r' if next
7260         character is '\n'.
7261
7262 2019-01-06  Tom Tromey  <tom@tromey.com>
7263
7264         * c-exp.y (struct c_parse_state) <macro_original_text,
7265         expansion_obstack>: New member.
7266         (macro_original_text, expansion_obstack): Remove globals.
7267         (scan_macro_expansion, scanning_macro_expansion)
7268         (finished_macro_expansion): Update.
7269         (scan_macro_cleanup): Remove.
7270         (yylex, c_parse): Update.
7271
7272 2019-01-06  Tom Tromey  <tom@tromey.com>
7273
7274         * c-exp.y (struct c_parse_state) <strings>: New member.
7275         (operator_stoken): Update.
7276
7277 2019-01-06  Tom Tromey  <tom@tromey.com>
7278
7279         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7280         (union type_stack_elt) <typelist_val>: Now a pointer to
7281         std::vector.
7282         (type_stack_cleanup): Don't declare.
7283         (push_typelist): Update.
7284         * parse.c (pop_typelist): Return a std::vector.
7285         (push_typelist): Take a std::vector.
7286         (follow_types): Update.  Do not free args.
7287         (type_stack_cleanup): Remove.
7288         * c-exp.y (struct c_parse_state): New.
7289         (cpstate): New global.
7290         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7291         (nonempty_typelist): Update.
7292         (func_mod): Create a new vector.
7293         (c_parse): Create a c_parse_state.
7294         (check_parameter_typelist): Do not delete params.
7295         (function_method): Update.  Do not delete type_list.
7296
7297 2019-01-06  Tom Tromey  <tom@tromey.com>
7298
7299         PR gdb/28155:
7300         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7301         check_typedef.
7302         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7303         (print_return_value): Likewise.
7304
7305 2019-01-05  Tom Tromey  <tom@tromey.com>
7306
7307         * contrib/cleanup_check.py: Remove.
7308         * contrib/gcc-with-excheck: Remove.
7309         * contrib/exsummary.py: Remove.
7310         * contrib/excheck.py: Remove.
7311
7312 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7313
7314         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7315         NULL. Initialize tpprev to NULL instead of assigning it
7316         to NULL on the next statement.
7317         * windows-nat.c (windows_delete_thread): Remove check for
7318         main_thread_id before printing thread exit notifications.
7319         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7320         Remove thread ID check against main_thread_id.
7321         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7322         windows_delete_thread.
7323         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7324
7325 2019-01-04  Tom Tromey  <tom@tromey.com>
7326
7327         * compile/compile.c (_initialize_compile): Use upper case for
7328         metasyntactic variables.
7329         * symmisc.c (_initialize_symmisc): Use upper case for
7330         metasyntactic variables.
7331         * psymtab.c (_initialize_psymtab): Use upper case for
7332         metasyntactic variables.
7333         * demangle.c (demangle_command): Use upper case for metasyntactic
7334         variables.
7335         (_initialize_demangler): Likewise.
7336         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7337         variables.
7338
7339 2019-01-03  Tom Tromey  <tom@tromey.com>
7340
7341         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7342
7343 2019-01-03  Tom Tromey  <tom@tromey.com>
7344
7345         * python/py-symtab.c (salpy_str): Update.
7346         (struct salpy_sal_object) <symtab>: Now a PyObject.
7347         (salpy_dealloc): Update.
7348         (del_objfile_sal): Use gdbpy_ref.
7349
7350 2019-01-03  Tom Tromey  <tom@tromey.com>
7351
7352         * python/py-type.c (convert_field): Use new_reference.  Return
7353         gdbpy_ref.
7354         (make_fielditem): Return gdbpy_ref.
7355         (typy_fields): Update.
7356         (typy_getitem): Update.
7357         (field_name): Return gdbpy_ref.  Use new_reference.
7358         (typy_iterator_iternext): Update.
7359
7360 2019-01-03  Tom Tromey  <tom@tromey.com>
7361
7362         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7363
7364 2019-01-03  Tom Tromey  <tom@tromey.com>
7365
7366         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7367         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7368         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7369         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7370         (pspy_set_type_printers): Likewise.
7371         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7372         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7373         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7374         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7375         (objfpy_set_type_printers): Likewise.
7376
7377 2019-01-03  Tom Tromey  <tom@tromey.com>
7378
7379         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7380         (gdbpy_print_stack): Use gdbpy_err_fetch.
7381         * python/python-internal.h (class gdbpy_err_fetch): New class.
7382         (class gdbpy_enter) <m_error_type, m_error_value,
7383         m_error_traceback>: Remove.
7384         <m_error>: New member.
7385         (gdbpy_exception_to_string): Don't declare.
7386         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7387         * python/py-value.c (convert_value_from_python): Use
7388         gdbpy_err_fetch.
7389         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7390         gdbpy_exception_to_string.
7391         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7392         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7393         gdbpy_err_fetch.
7394
7395 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7396
7397         * linux-nat.c (delete_lwp_cleanup): Delete.
7398         (struct lwp_deleter): New struct.
7399         (lwp_info_up): New typedef.
7400         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7401         lwp_info_up.
7402
7403 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7404
7405         * linux-fork.c (class scoped_switch_fork_info): New class.
7406         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7407
7408 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7409
7410         * valops.c (find_overload_match): Remove use of null_cleanup, and
7411         calls to do_cleanups.
7412
7413 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7414
7415         * compile/compile-cplus-types.c
7416         (compile_cplus_instance::decl_name): Handle changes to
7417         cp_func_name.
7418         * cp-support.c (cp_func_name): Update header comment, update
7419         return type.
7420         * cp-support.h (cp_func_name): Update return type in declaration.
7421         * valops.c (find_overload_match): Move temp_func local to top
7422         level of function and change its type.  Use temp_func to hold and
7423         delete temporary string obtained from cp_func_name.
7424
7425 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7426
7427         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7428         gdb::char_vector, remove cleanup, and update uses of `msg`.
7429
7430 2019-01-03  Jim Wilson  <jimw@sifive.com>
7431
7432         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7433
7434 2019-01-02  Tom Tromey  <tom@tromey.com>
7435
7436         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7437         (tdesc_parse_xml): Remove cleanups.
7438         * target-descriptions.h (make_cleanup_free_target_description):
7439         Don't declare.
7440         (target_desc_deleter): New struct.
7441         (target_desc_up): New typedef.
7442         * target-descriptions.c (target_desc_deleter::operator()): Rename
7443         from free_target_description.
7444         (make_cleanup_free_target_description): Remove.
7445
7446 2019-01-02  Tom Tromey  <tom@tromey.com>
7447
7448         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7449         constructor, destructor.
7450         (linespec_parser): Remove typedef.
7451         (~linespec_parser): Rename from linespec_parser_delete.
7452         (linespec_lex_to_end, linespec_complete_label)
7453         (linespec_complete): Update.
7454         (decode_line_full): Remove cleanups.
7455         (decode_line_1): Update.
7456
7457 2019-01-02  Tom Tromey  <tom@tromey.com>
7458
7459         * python/python-internal.h (inferior_to_inferior_object): Change
7460         return type.
7461         * python/py-exitedevent.c (create_exited_event_object): Update.
7462         * python/py-inferior.c (inferior_to_inferior_object): Return
7463         gdbpy_ref.
7464         (python_new_inferior, python_inferior_deleted)
7465         (thread_to_thread_object, delete_thread_object)
7466         (build_inferior_list, gdbpy_selected_inferior): Update.
7467         * python/py-infthread.c (create_thread_object): Update.  Also fail
7468         if inferior_to_inferior_object fails.
7469
7470 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7471
7472         * inferior.h (class inferior) <displaced_step_state>: New field.
7473         * infrun.h (struct displaced_step_state): Move here from
7474         infrun.c.  Initialize fields, add constructor.
7475         <inf>: Remove field.
7476         <reset>: New method.
7477         * infrun.c (struct displaced_step_inferior_state): Move to
7478         infrun.h.
7479         (displaced_step_inferior_states): Remove.
7480         (get_displaced_stepping_state): Adust.
7481         (displaced_step_in_progress_any_inferior): Adjust.
7482         (displaced_step_in_progress_thread): Adjust.
7483         (displaced_step_in_progress): Adjust.
7484         (add_displaced_stepping_state): Remove.
7485         (get_displaced_step_closure_by_addr): Adjust.
7486         (remove_displaced_stepping_state): Remove.
7487         (infrun_inferior_exit): Call displaced_step_state.reset.
7488         (use_displaced_stepping): Don't check for NULL.
7489         (displaced_step_prepare_throw): Call
7490         get_displaced_stepping_state.
7491         (displaced_step_fixup): Don't check for NULL.
7492         (prepare_for_detach): Don't check for NULL.
7493
7494 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7495
7496         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7497          in case of call that did not complete.
7498
7499 2019-01-02  Andrey Utkin  <autkin@undo.io>
7500
7501         * symfile.c (find_separate_debug_file): Fix search of debug files for
7502         remote debuggee.
7503
7504 2019-01-02  Tom Tromey  <tom@tromey.com>
7505
7506         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7507         indentation.
7508         * python/py-frame.c (frapy_older): Remove cast.
7509         (frapy_newer): Likewise.
7510         * python/py-breakpoint.c (local_setattro): Remove cast.
7511         * python/py-arch.c (archpy_name): Remove local variable.
7512         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7513
7514 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7515
7516         * unittests/basic_string_view/element_access/char/empty.cc:
7517         Fix year range in copyright header.
7518
7519 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7520
7521         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7522         Delete.
7523         <operator==>: Update with for removed field.
7524         <hash>: Likewise.
7525         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7526         <isa_features>: ...this.
7527         <abi_features>: New field.
7528         (riscv_isa_flen): Update comment.
7529         (riscv_abi_xlen): New declaration.
7530         (riscv_abi_flen): New declaration.
7531         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7532         isa_features.
7533         (riscv_abi_xlen): New function.
7534         (riscv_isa_flen): Update to get answer from isa_features.
7535         (riscv_abi_flen): New function.
7536         (riscv_has_fp_abi): Update to get answer from abi_features.
7537         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7538         xlen and flen.
7539         (riscv_call_info) <xlen, flen>: Update comment.
7540         (riscv_call_arg_struct): Remove invalid assertions
7541         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7542         is removed.
7543         (riscv_gdbarch_init): Gather isa features and abi features
7544         separately, ensure both match on the gdbarch when reusing an old
7545         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7546         a target with 64-bit float hardware.
7547
7548 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7549
7550         * source.c (search_command_helper): Stop reverse search
7551         when line 1 has been searched.
7552
7553 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7554
7555         * record-full.c (record_full_base_target::close): Rewrite
7556         record_full_core_buf_list free logic.
7557
7558 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7559
7560         * break-catch-syscall.c (print_one_catch_syscall): xfree
7561         the last text.
7562
7563 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7564
7565         * top.c (print_gdb_version): Update Copyright year in version
7566         message.
7567
7568 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7569
7570         Update copyright year range in all GDB files.
7571
7572 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7573
7574         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7575
7576 For older changes see ChangeLog-2018.
7577 \f
7578 Local Variables:
7579 mode: change-log
7580 left-margin: 8
7581 fill-column: 74
7582 version-control: never
7583 coding: utf-8
7584 End:
7585