ee11a3f6e1f072bd5dd6bba7027838f563f825eb
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-27 Tom Tromey <tom@tromey.com>
2
3 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4 * tui/tui-regs.c (tui_data_window::display_registers_from):
5 Update.
6 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
7 * tui/tui-data.h (struct tui_gen_win_info) <viewport_height>:
8 Remove.
9 * tui/tui-command.c (tui_cmd_window::resize): Update.
10
11 2019-12-26 Christian Biesinger <cbiesinger@google.com>
12
13 * ada-lang.c (ada_decode_symbol): Update.
14 * buildsym.c (add_symbol_to_list): Update.
15 * coffread.c (process_coff_symbol): Update.
16 * ctfread.c (ctf_add_enum_member_cb): Update.
17 (new_symbol): Update.
18 (ctf_add_var_cb): Update.
19 * dwarf2read.c (fixup_go_packaging): Update.
20 (dwarf2_compute_name): Update.
21 (new_symbol): Update.
22 * jit.c (finalize_symtab): Update.
23 * language.c (language_alloc_type_symbol): Update.
24 * mdebugread.c (new_symbol): Update.
25 * minsyms.c (minimal_symbol_reader::record_full): Update.
26 (minimal_symbol_reader::install): Update.
27 * psymtab.c (print_partial_symbols): Update.
28 (psymbol_hash): Update.
29 (psymbol_compare): Update.
30 (add_psymbol_to_bcache): Update.
31 (maintenance_check_psymtabs): Update.
32 * stabsread.c (define_symbol): Update.
33 * symtab.c (symbol_set_names): Rename to...
34 (general_symbol_info::compute_and_set_names): ...this.
35 (general_symbol_info::natural_name): Update.
36 (general_symbol_info::search_name): Update.
37 (fixup_section): Update.
38 * symtab.h (struct general_symbol_info) <name>: Rename to...
39 <m_name>: ...this.
40 <compute_and_set_names>: Rename from...
41 (symbol_set_names): ...this.
42 (SYMBOL_SET_NAMES): Remove.
43 (struct symbol) <ctor>: Update.
44
45 2019-12-26 Christian Biesinger <cbiesinger@google.com>
46
47 * NEWS: Mention that multithreaded symbol loading is now on by
48 default.
49
50 2019-12-26 Ruslan Kabatsayev <b7.10110111@gmail.com>
51
52 * dwarf2read.c (is_valid_DW_AT_defaulted)
53 (is_valid_DW_AT_calling_convention_for_type)
54 (is_valid_DW_AT_calling_convention_for_subroutine): Fix printing
55 ULONGEST variables on x86-32.
56
57 2019-12-21 George Barrett <bob@bob131.so>
58
59 * solib-svr4.c (svr4_handle_solib_event): Add fallback link
60 namespace test for when the debug struct isn't available.
61
62 2019-12-21 Eli Zaretskii <eliz@gnu.org>
63
64 * top.c (print_gdb_configuration): Print "--with-xxhash" or
65 "--without-xxhash" according to HAVE_LIBXXHASH.
66
67 2019-12-20 Weimin Pan <weimin.pan@oracle.com>
68 * ctfread.c (ctf_file_key): Change type to objfile_key.
69 (struct ctf_context): Remove typedef.
70 (get_objfile_text_range): Use ANOFFSET to get text base.
71
72 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
73
74 * dwarf2read.c (is_valid_DW_AT_calling_convention_for_subroutine):
75 New function.
76 (read_subroutine_type): Validate the parsed
77 DW_AT_calling_convention value before assigning it to a
78 subroutine's calling_convention attribute.
79 * gdbtypes.h (struct func_type) <calling_convention>: Use
80 an enum bitfield as its type, instead of plain unsigned.
81
82 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
83
84 PR gdb/25054
85 * infcall.c (call_function_by_hand_dummy): Update the argument-
86 passing section for call-by-value parameters.
87 (struct destructor_info): New struct.
88 (call_destructors): New auxiliary function.
89
90 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
91
92 * gnu-v3-abi.c (enum definition_style): New enum type.
93 (get_def_style): New function.
94 (is_user_provided_def): New function.
95 (is_implicit_def): New function.
96 (is_copy_or_move_constructor_type): New function.
97 (is_copy_constructor_type): New function.
98 (is_move_constructor_type): New function.
99 (gnuv3_pass_by_reference): Collect language_pass_by_ref_info
100 for a given type.
101
102 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
103
104 * language.h (struct language_pass_by_ref_info): New struct.
105 (struct language_defn)<la_pass_by_reference>: Change the signature
106 to return a language_pass_by_ref_info instead of an int.
107 (language_pass_by_reference): Ditto.
108 (default_pass_by_reference): Ditto.
109 Adjust the users listed below.
110 * arch-utils.c (default_return_in_first_hidden_param_p):
111 Update.
112 * cp-abi.c (cp_pass_by_reference): Update.
113 * cp-abi.h (cp_pass_by_reference): Update declaration.
114 (struct cp_abi_ops)<pass_by_reference>: Update.
115 * gnu-v3-abi.c (gnuv3_pass_by_reference): Update.
116 * infcall.c (call_function_by_hand_dummy): Update.
117 * language.c (language_pass_by_reference): Update.
118 (default_pass_by_reference): Update.
119 * tic6x-tdep.c (tic6x_return_value): Update.
120
121 2019-12-20 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
122
123 * dwarf2read.c (dwarf2_add_member_fn): Read the DW_AT_defaulted
124 and DW_AT_deleted attributes of a function.
125 (read_structure_type): Read the DW_AT_calling_convention attribute
126 of a type.
127 (is_valid_DW_AT_defaulted): New function.
128 (is_valid_DW_AT_calling_convention_for_type): New function.
129 * gdbtypes.h: Include dwarf2.h.
130 (struct fn_field)<defaulted>: New field to store the
131 DW_AT_defaulted attribute.
132 (struct fn_field)<is_deleted>: New field to store the
133 DW_AT_deleted attribute.
134 (struct cplus_struct_type)<calling_convention>: New field to store
135 the DW_AT_calling_convention attribute.
136 (TYPE_FN_FIELD_DEFAULTED): New macro.
137 (TYPE_FN_FIELD_DELETED): New macro.
138 (TYPE_CPLUS_CALLING_CONVENTION): New macro.
139 * gdbtypes.c (dump_fn_fieldlists): Update for the changes made
140 to the .h file.
141 (print_cplus_stuff): Likewise.
142
143 2019-12-20 Tom Tromey <tom@tromey.com>
144
145 * tui/tui.c (tui_show_source): Remove.
146 * tui/tui.h (tui_show_source): Don't declare.
147 * tui/tui-out.c (tui_ui_out::do_field_string): Don't call
148 tui_show_source.
149
150 2019-12-20 Tom Tromey <tom@tromey.com>
151
152 * tui/tui-stack.h (tui_show_frame_info): Return bool.
153 * tui/tui-stack.c (tui_show_frame_info): Return bool.
154 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
155 Update.
156
157 2019-12-20 Tom Tromey <tom@tromey.com>
158
159 PR tui/18932:
160 * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
161 Rename parameters. Handle the not-from-stack-frame case.
162 (from_stack, from_source_symtab): New globals.
163 (tui_before_prompt, tui_normal_stop): Update.
164 (tui_context_changed, tui_symtab_changed): New functions.
165 (tui_attach_detach_observers): Attach new observers.
166
167 2019-12-20 Tom Tromey <tom@tromey.com>
168
169 * source.c (struct current_source_location) <set, symtab, line>:
170 New methods.
171 <m_symtab, m_line>: Rename. Now private.
172 (get_current_source_symtab_and_line)
173 (set_default_source_symtab_and_line)
174 (set_current_source_symtab_and_line)
175 (clear_current_source_symtab_and_line, select_source_symtab)
176 (info_source_command, print_source_lines_base)
177 (info_line_command, search_command_helper): Update.
178 * observable.h (current_source_symtab_and_line_changed): Declare
179 observable.
180 * observable.c (current_source_symtab_and_line_changed): Define
181 observable.
182
183 2019-12-20 Tom Tromey <tom@tromey.com>
184
185 * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
186 (tui_before_prompt, tui_normal_stop): Update.
187
188 2019-12-20 Tom Tromey <tom@tromey.com>
189
190 * tui/tui-winsource.c
191 (tui_source_window_base::update_source_window_as_is): Don't call
192 set_current_source_symtab_and_line.
193
194 2019-12-20 Tom Tromey <tom@tromey.com>
195
196 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
197 Take a symtab_and_line.
198 * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
199 symtab_and_line.
200 (tui_show_frame_info): Update.
201
202 2019-12-20 Tom Tromey <tom@tromey.com>
203
204 * tui/tui-stack.c (tui_show_frame_info): Don't call
205 update_exec_info.
206
207 2019-12-20 Tom Tromey <tom@tromey.com>
208
209 * tui/tui.c (tui_enable): Call tui_display_main.
210
211 2019-12-20 Tom Tromey <tom@tromey.com>
212
213 * tui/tui-disasm.c (tui_get_begin_asm_address): Use
214 get_current_source_symtab_and_line, and main_name.
215
216 2019-12-20 Tom Tromey <tom@tromey.com>
217
218 * tui/tui.c (tui_show_source): Update.
219 * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
220 * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
221 a symtab_symbol_info, not a separate symtab and line. Simplify.
222
223 2019-12-20 Tom Tromey <tom@tromey.com>
224
225 * tui/tui-winsource.c (tui_update_source_windows_with_addr):
226 Simplify.
227
228 2019-12-20 Tom Tromey <tom@tromey.com>
229
230 * tui/tui-winsource.h (struct tui_source_window_base)
231 <set_contents, update_source_window_as_is, update_source_window>:
232 Take a sal, not a separate symtab and tui_line_or_address.
233 * tui/tui-winsource.c (tui_source_window_base::update_source_window)
234 (tui_source_window_base::update_source_window_as_is): Take a sal,
235 not a separate symtab and tui_line_or_address.
236 (tui_update_source_windows_with_addr)
237 (tui_update_source_windows_with_line)
238 (tui_source_window_base::rerender)
239 (tui_source_window_base::refill): Update.
240 * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
241 a sal, not a separate symtab and tui_line_or_address.
242 * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
243 not a separate symtab and tui_line_or_address.
244 (tui_source_window::maybe_update): Update.
245 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
246 a sal, not a separate symtab and tui_line_or_address.
247 * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
248 not a separate symtab and tui_line_or_address.
249 (tui_disasm_window::do_scroll_vertical)
250 (tui_disasm_window::maybe_update): Update.
251
252 2019-12-20 Tom Tromey <tom@tromey.com>
253
254 * tui/tui-winsource.c (tui_source_window_base::refill): Use
255 start_line_or_addr.
256 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
257 start_line_or_addr.
258 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
259 start_line_or_addr.
260
261 2019-12-20 Tom Tromey <tom@tromey.com>
262
263 * tui/tui-winsource.h (struct tui_source_window_base)
264 <set_contents>: Return bool.
265 * tui/tui-winsource.c
266 (tui_source_window_base::update_source_window_as_is): Update.
267 * tui/tui-source.h (struct tui_source_window) <set_contents>:
268 Return bool.
269 * tui/tui-source.c (tui_source_window::set_contents): Return
270 bool. Simplify.
271 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
272 Return bool.
273 * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
274 bool.
275
276 2019-12-20 Tom Tromey <tom@tromey.com>
277
278 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
279 (tui_update_source_windows_with_line): Call update_source_window.
280 * tui/tui-source.h (struct tui_source_window)
281 <show_symtab_source>: Don't declare.
282 * tui/tui-source.c (tui_source_window::show_symtab_source):
283 Remove.
284
285 2019-12-20 Tom Tromey <tom@tromey.com>
286
287 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
288 update_source_window directly.
289 * tui/tui-disasm.h (tui_show_disassem): Don't declare.
290 * tui/tui-disasm.c (tui_show_disassem): Remove.
291
292 2019-12-20 Tom Tromey <tom@tromey.com>
293
294 * tui/tui-winsource.c
295 (tui_source_window_base::update_source_window_as_is): Don't switch focus.
296 * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
297
298 2019-12-20 Tom Tromey <tom@tromey.com>
299
300 * tui/tui-winsource.h (struct tui_source_window_base)
301 <maybe_update>: Remove line_no and addr parameters.
302 * tui/tui-stack.c (tui_show_frame_info): Set PC on sal. Update.
303 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
304 Update.
305 * tui/tui-source.c (tui_source_window::maybe_update): Remove
306 line_no and addr parameters.
307 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
308 Update.
309 * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
310 line_no and addr parameters.
311
312 2019-12-20 Tom Tromey <tom@tromey.com>
313
314 * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
315 (tui_source_window_base::update_breakpoint_info): Remove asserts.
316
317 2019-12-20 Tom Tromey <tom@tromey.com>
318
319 * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
320 tui_show_disassem.
321 * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
322 declare.
323 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
324
325 2019-12-20 Tom Tromey <tom@tromey.com>
326
327 * tui/tui.h (tui_show_source): Remove parameters.
328 * tui/tui.c (tui_show_source): Remove parameters.
329 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
330
331 2019-12-20 Tom Tromey <tom@tromey.com>
332
333 * tui/tui.c (tui_show_source): Update.
334 * tui/tui-winsource.c (tui_display_main): Update.
335 * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
336 to symtab.
337 * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
338 to symtab.
339 * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
340
341 2019-12-20 Tom Tromey <tom@tromey.com>
342
343 PR tui/23619:
344 * tui/tui-io.c (tui_rl_saved_prompt): Remove.
345 (tui_redisplay_readline): Use rl_display_prompt.
346 (tui_prep_terminal): Update.
347
348 2019-12-19 Christian Biesinger <cbiesinger@google.com>
349
350 * configure: Regenerate.
351 * configure.ac: Quote variable arguments of test.
352 * gdbsupport/common.m4: Likewise.
353
354 2019-12-19 Christian Biesinger <cbiesinger@google.com>
355
356 * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
357 2 to pow ().
358
359 2019-12-19 Christian Biesinger <cbiesinger@google.com>
360
361 * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
362 log10 to double to fix Solaris 11 with gcc 5.5.
363
364 2019-12-19 Christian Biesinger <cbiesinger@google.com>
365
366 * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
367 "sun" to "saddr_un".
368
369 2019-12-19 Tom Tromey <tromey@adacore.com>
370
371 * ui-out.h (enum class field_kind): Fix comment.
372
373 2019-12-11 Tom Tromey <tromey@adacore.com>
374
375 * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
376
377 2019-12-18 Tom Tromey <tromey@adacore.com>
378
379 PR build/25268:
380 * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
381 type on macOS. Add comment.
382
383 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
384
385 * c-lang.c (c_get_string, asm_language_defn): Remove space
386 before tab.
387
388 2019-12-18 Tom Tromey <tromey@adacore.com>
389
390 PR build/25250:
391 * ui-out.c (ui_out::vmessage): Update.
392 * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
393 Rename.
394 (string_field): Update.
395 (signed_field): Update.
396
397 2019-12-18 Simon Marchi <simon.marchi@efficios.com>
398
399 * top.c (print_gdb_configuration): Adjust indentation.
400
401 2019-12-17 Christian Biesinger <cbiesinger@google.com>
402
403 * bsd-kvm.c: Include gdbsupport/pathstuff.h.
404
405 2019-12-17 Simon Marchi <simon.marchi@polymtl.ca>
406
407 * tui/tui-layout.h (class tui_layout_base): Add virtual
408 destructor.
409
410 2019-12-16 Bernd Edlinger <bernd.edlinger@hotmail.de>
411
412 * infcmd.c (prepare_one_step): Step over skipped inline functions.
413 * infrun.c (inline_frame_is_marked_for_skip): New helper function.
414 (process_event_stop_test): Keep stepping over skipped inline functions.
415
416 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
417
418 * jit.c (struct gdb_block) <next>: Remove field.
419 (struct gdb_symtab) <~gdb_symtab>: Remove.
420 <blocks>: Change type to std::forward_list<gdb_block>.
421 (compare_block): Remove.
422 (jit_block_open_impl): Adjust to std::forward_list. Place the new
423 block at the beginning, don't mind about sorting.
424 (finalize_symtab): Adjust to std::forward_list, sort the blocks list
425 before using it.
426
427 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
428
429 * jit.c (struct gdb_block): Add constructor, initialize
430 real_block and next fields.
431 <name>: Change type to gdb::unique_xmalloc_ptr.
432 (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
433 (jit_block_open_impl): Allocate gdb_block with new.
434 (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
435
436 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
437
438 * jit.c: Include forward_list.
439 (struct gdb_symtab) <next>: Remove field.
440 (struct gdb_object) <symtabs>: Change type to
441 std::forward_list<gdb_symtab>.
442 (jit_object_open_impl): Allocate gdb_object with new.
443 (jit_symtab_open_impl): Adjust to std::forward_list.
444 (finalize_symtab): Don't delete symtab.
445 (jit_object_close_impl): Adjust to std::forward_list. Free
446 gdb_object with delete.
447
448 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
449
450 * jit.c (struct gdb_symtab): Add constructor, destructor,
451 initialize fields.
452 <linetable>: Change type to unique_xmalloc_ptr.
453 <file_name>: Change type to std::string.
454 (jit_symtab_open_impl): Allocate gdb_symtab with new.
455 (jit_symtab_line_mapping_add_impl): Adjust.
456 (finalize_symtab): Adjust, call delete on stab.
457
458 2019-12-16 Simon Marchi <simon.marchi@polymtl.ca>
459
460 * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
461
462 2019-12-16 Tom Tromey <tromey@adacore.com>
463
464 * windows-nat.c (windows_nat_target::attach): Update.
465 * remote.c (extended_remote_target::attach): Update.
466 * procfs.c (procfs_target::attach): Update.
467 * nto-procfs.c (nto_procfs_target::attach): Update.
468 (nto_procfs_target::create_inferior): Update.
469 * inf-ptrace.c (inf_ptrace_target::attach): Update.
470 * gnu-nat.c (gnu_nat_target::attach): Update.
471 (gnu_nat_target::detach): Update.
472 * darwin-nat.c (darwin_nat_target::attach): Update.
473 * corefile.c (get_exec_file): Constify result. Remove extraneous
474 return.
475 * bsd-kvm.c (bsd_kvm_target_open): Update.
476 * gdbsupport/common-inferior.h (get_exec_file): Constify result.
477
478 2019-12-16 Christian Biesinger <cbiesinger@google.com>
479
480 * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
481 (we no longer need to include time.h before pathmax.h)
482
483 2019-12-15 Christian Biesinger <cbiesinger@google.com>
484
485 * ada-exp.y (write_ambiguous_var): Update.
486 * coffread.c (process_coff_symbol): Update.
487 * ctfread.c (ctf_add_enum_member_cb): Update.
488 (new_symbol): Update.
489 * dwarf2read.c (fixup_go_packaging): Update.
490 (new_symbol): Update.
491 * language.c (language_alloc_type_symbol): Update.
492 * mdebugread.c (new_symbol): Update.
493 * minsyms.c (minimal_symbol_reader::record_full): Update.
494 * psymtab.c (add_psymbol_to_bcache): Update.
495 * stabsread.c (define_symbol): Update.
496 (read_enum_type): Update.
497 * symtab.c (symbol_set_language): Make this a member function...
498 (general_symbol_info::set_language): ... here.
499 * symtab.h (struct general_symbol_info) <set_language>: New function.
500 (SYMBOL_SET_LANGUAGE): Remove.
501 (symbol_set_language): Remove.
502
503 2019-12-15 Christian Biesinger <cbiesinger@google.com>
504
505 * ada-lang.c (ada_add_block_symbols): Update.
506 (ada_collect_symbol_completion_matches): Update.
507 * ax-gdb.c (gen_expr): Update.
508 * block.c (block_lookup_symbol): Update.
509 (block_lookup_symbol_primary): Update.
510 (block_find_symbol): Update.
511 * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
512 * dbxread.c (process_one_symbol): Update.
513 * dictionary.c (insert_symbol_hashed): Update.
514 (collate_pending_symbols_by_language): Update.
515 (mdict_add_symbol): Update.
516 * dwarf-index-write.c (write_psymbols): Update.
517 * dwarf2read.c (fixup_go_packaging): Update.
518 * findvar.c (read_var_value): Update.
519 * ft32-tdep.c (ft32_skip_prologue): Update.
520 * go-lang.c (go_symbol_package_name): Update.
521 * language.h (scoped_switch_to_sym_language_if_auto::
522 scoped_switch_to_sym_language_if_auto): Update.
523 * linespec.c (find_method): Update.
524 (find_label_symbols_in_block): Update.
525 * mdebugread.c (parse_symbol): Update.
526 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
527 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
528 (minimal_symbol_reader::install): Update.
529 * moxie-tdep.c (moxie_skip_prologue): Update.
530 * parse.c (parse_exp_in_context): Update.
531 * psymtab.c (psymbol_name_matches): Update.
532 (match_partial_symbol): Update.
533 (lookup_partial_symbol): Update.
534 (psymbol_hash): Update.
535 (psymbol_compare): Update.
536 * python/py-framefilter.c (extract_sym): Update.
537 (py_print_single_arg): Update.
538 * stabsread.c (define_symbol): Update.
539 * stack.c (print_frame_arg): Update.
540 (find_frame_funname): Update.
541 (info_frame_command_core): Update.
542 * symfile.c (set_initial_language): Update.
543 * symtab.c (symbol_set_demangled_name): Update.
544 (symbol_get_demangled_name): Update.
545 (symbol_set_language): Update.
546 (symbol_find_demangled_name): Update.
547 (symbol_set_names): Update.
548 (general_symbol_info::natural_name): Update.
549 (general_symbol_info::demangled_name): Update.
550 (general_symbol_info::search_name): Update.
551 (symbol_matches_search_name): Update.
552 (eq_symbol_entry): Update.
553 (iterate_over_symbols): Update.
554 (completion_list_add_symbol): Update.
555 (completion_list_add_msymbol): Update.
556 (completion_list_add_fields): Update.
557 * symtab.h (struct general_symbol_info) <language>: New function.
558 <language>: Rename to...
559 <m_language>: ...this.
560 (SYMBOL_LANGUAGE): Remove.
561 (MSYMBOL_LANGUAGE): Remove.
562 (struct symbol) <ctor>: Update.
563 * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
564
565 2019-12-15 Christian Biesinger <cbiesinger@google.com>
566
567 * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
568 set the language of sym.
569 * language.c (language_alloc_type_symbol): Likewise.
570
571 2019-12-14 Sergio Durigan Junior <sergiodj@redhat.com>
572
573 https://bugzilla.redhat.com/show_bug.cgi?id=1728147
574 PR gdb/23613
575 * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
576 * corelow.c: Include 'gdbsupport/pathstuff.h'.
577 (core_target_open): Use 'gdb_abspath'.
578 * gdbsupport/pathstuff.c (gdb_abspath): Guard against
579 'current_directory == NULL' case.
580 * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
581 explain what happens when 'current_directory' is NULL.
582 * go32-nat.c (go32_nat_target::wait): Check if
583 'current_directory' is NULL before call to 'chdir'.
584 * source.c (add_path): Use 'gdb_abspath'.
585 * top.c: Include 'gdbsupport/pathstuff.h'.
586 (init_history): Use 'gdb_abspath'.
587 (set_history_filename): Likewise.
588 * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
589 (tfile_target_open): Use 'gdb_abspath'.
590
591 2019-12-13 Tom Tromey <tromey@adacore.com>
592
593 * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
594 warning or error.
595
596 2019-12-13 Tom Tromey <tromey@adacore.com>
597
598 * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
599
600 2019-12-13 Tom Tromey <tromey@adacore.com>
601
602 * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
603
604 2019-12-13 Tom Tromey <tromey@adacore.com>
605
606 * contrib/ari/gdb_ari.sh (usage): Use GNU style.
607
608 2019-12-13 Tom Tromey <tromey@adacore.com>
609
610 * gdbsupport/common-utils.c (string_printf, string_vprintf)
611 (string_vappendf): Add ARI comment.
612
613 2019-12-13 Tom Tromey <tromey@adacore.com>
614
615 * contrib/ari/gdb_ari.sh: Remove "fix" call for
616 floatformat_to_double.
617 * target-float.c (host_float_ops<T>::from_target): Add ARI
618 comment.
619
620 2019-12-13 Tom Tromey <tromey@adacore.com>
621
622 * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
623 * utils.c (abort_with_message, dump_core, internal_vproblem): Add
624 ARI marker to abort.
625 * event-top.c (handle_sigsegv): Add ARI marker to abort.
626
627 2019-12-13 Tom Tromey <tromey@adacore.com>
628
629 * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
630
631 2019-12-13 Tom Tromey <tromey@adacore.com>
632
633 * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
634
635 2019-12-13 Tom Tromey <tromey@adacore.com>
636
637 * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
638 checks.
639
640 2019-12-13 Tom Tromey <tromey@adacore.com>
641
642 * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
643 end>: No longer "const".
644
645 2019-12-13 Simon Marchi <simon.marchi@polymtl.ca>
646
647 * jit.c: Fix indentation, replace spaces with tabs where
648 applicable.
649
650 2019-12-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
651
652 * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
653
654 2019-12-12 Tom Tromey <tom@tromey.com>
655
656 * objfiles.h (struct objfile) <partial_symtabs>: Now a
657 unique_ptr.
658
659 2019-12-12 Tom Tromey <tom@tromey.com>
660
661 * progspace.h (objfile_list): New typedef.
662 (class unwrapping_objfile_iterator)
663 (struct unwrapping_objfile_range): Newl
664 (struct program_space) <objfiles_range>: Change type.
665 <objfiles>: Change return type.
666 <add_objfile>: Change type of "objfile" parameter.
667 <objfiles_list>: Now a list of shared_ptr.
668 * progspace.c (program_space::add_objfile): Change type of
669 "objfile". Update.
670 (program_space::remove_objfile): Update.
671 * objfiles.h (struct objfile) <~objfile>: Make public.
672 * objfiles.c (objfile::make): Update.
673 (objfile::unlink): Don't call delete.
674
675 2019-12-12 Tom Tromey <tom@tromey.com>
676
677 * symfile.c (symbol_file_clear): Update.
678 * progspace.h (struct program_space) <free_all_objfiles>: Declare
679 method.
680 * progspace.c (program_space::free_all_objfiles): New method.
681 * objfiles.h (free_all_objfiles): Don't declare.
682 * objfiles.c (free_all_objfiles): Move to program_space.
683
684 2019-12-12 Tom Tromey <tom@tromey.com>
685
686 * progspace.c (program_space::add_objfile)
687 (program_space::remove_objfile): Update.
688 (program_space::multi_objfile_p): Remove.
689 * objfiles.h (struct objfile) <next>: Remove.
690 * objfiles.c (objfile::objfile): Update.
691 (put_objfile_before): Update.
692 (unlink_objfile): Update.
693 * progspace.h (object_files): Remove.
694 (struct program_space) <objfiles_head>: Remove.
695 <objfiles_list>: New member.
696 <objfiles_range, objfiles_safe_range>: Change type.
697 (objfiles): Change return type.
698 (objfiles_safe): Update.
699 (multi_objfile_p): Rewrite and inline.
700 (object_files): Remove macro.
701
702 2019-12-12 Tom Tromey <tom@tromey.com>
703
704 * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify. Add
705 second constructor.
706 (basic_safe_range): New class.
707
708 2019-12-12 Tom Tromey <tom@tromey.com>
709
710 * progspace.c (program_space::multi_objfile_p): New method.
711 * printcmd.c (info_symbol_command): Update.
712 * maint.c (maintenance_translate_address): Update.
713 * objfiles.h (MULTI_OBJFILE_P): Remove.
714 * progspace.h (struct program_space) <multi_objfile_p>: New
715 method.
716
717 2019-12-12 Tom Tromey <tom@tromey.com>
718
719 * progspace.h (struct program_space) <remove_objfile>: Declare.
720 * progspace.c (program_space::remove_objfile): New method.
721 * objfiles.c (unlink_objfile): Remove.
722 (objfile::unlink): Call remove_objfile.
723 (objfile): Don't call unlink_objfile.
724
725 2019-12-12 Tom Tromey <tom@tromey.com>
726
727 * progspace.h (struct program_space) <add_objfile>: Declare
728 method.
729 * progspace.c (program_space::add_objfile): New method.
730 * objfiles.c (~objfile): Don't unlink objfile.
731 (put_objfile_before): Remove.
732 (add_separate_debug_objfile): Don't call put_objfile_before.
733 (objfile::make): Call add_objfile. Set new_objfiles_available on
734 the per-program-space data.
735
736 2019-12-12 Tom Tromey <tom@tromey.com>
737
738 * symfile.c (syms_from_objfile_1): Use objfile_up.
739 (syms_from_objfile_1, remove_symbol_file_command): Call unlink
740 method.
741 (reread_symbols): Use objfile_up.
742 * solib.c (update_solib_list, reload_shared_libraries_1): Call
743 unlink method.
744 * objfiles.h (struct objfile) <~objfile>: Now private.
745 <unlink>: New method.
746 (struct objfile_deleter): New.
747 (objfile_up): New typedef.
748 * objfiles.c (objfile::unlink): New method.
749 (free_objfile_separate_debug, free_all_objfiles)
750 (objfile_purge_solibs): Use it.
751 * jit.c (jit_unregister_code): Remove.
752 (jit_inferior_exit_hook, jit_event_handler): Call unlink on
753 objfile.
754 * compile/compile-object-run.c (do_module_cleanup): Call unlink on
755 objfile.
756 * compile/compile-object-load.c (compile_object_load): Use
757 objfile_up.
758
759 2019-12-12 Tom Tromey <tom@tromey.com>
760
761 * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
762 objfile::make.
763 * objfiles.h (struct objjfile) <make>: No longer inline.
764 (add_separate_debug_objfile): Don't declare.
765 * objfiles.c (add_separate_debug_objfile): Now static.
766 (objfile::make): Move from objfiles.h. Call
767 add_separate_debug_objfile. Add "parent" parameter.
768
769 2019-12-12 Tom Tromey <tom@tromey.com>
770
771 * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
772 * objfiles.h (struct objfile): Make constructor private.
773 <make>: New static method.
774 * jit.c (jit_object_close_impl): Update.
775
776 2019-12-12 Simon Marchi <simon.marchi@polymtl.ca>
777
778 * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
779 gdb::byte_vector.
780
781 2019-12-12 Tom Tromey <tromey@adacore.com>
782
783 * xml-support.c (xml_fetch_content_from_file): Don't call
784 malloc_failure.
785 * utils.h (class gdb_argv): Remove malloc_failure comment.
786 * utils.c (gdb_argv::reset): Don't call malloc_failure.
787
788 2019-12-12 Tom Tromey <tromey@adacore.com>
789
790 * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
791 (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
792 (ALLDEPFILES): Add riscv-ravenscar-thread.c.
793 * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
794 * riscv-ravenscar-thread.c: New file.
795 * riscv-ravenscar-thread.h: New file.
796 * riscv-tdep.c (riscv_gdbarch_init): Call
797 register_riscv_ravenscar_ops.
798
799 2019-12-12 Tom Tromey <tromey@adacore.com>
800
801 * gdbsupport/thread-pool.c (set_thread_name): Use
802 ATTRIBUTE_UNUSED.
803
804 2019-12-12 Luis Machado <luis.machado@linaro.org>
805
806 * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
807 (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
808 macros.
809
810 2019-12-11 Tom Tromey <tom@tromey.com>
811
812 * tui/tui-win.c (tui_set_win_height_command): Call
813 tui_adjust_window_height.
814 (tui_adjust_win_heights, new_height_ok): Remove.
815 * tui/tui-layout.h (tui_adjust_window_height): Declare.
816 * tui/tui-layout.c (tui_adjust_window_height): New function.
817
818 2019-12-11 Tom Tromey <tom@tromey.com>
819
820 * tui/tui-win.c (tui_resize_all): Remove code, call
821 tui_apply_current_layout.
822
823 2019-12-11 Tom Tromey <tom@tromey.com>
824
825 * tui/tui-layout.h (tui_apply_current_layout): Declare.
826 * tui/tui-layout.c (standard_layouts, applied_layout): New
827 globals.
828 (tui_apply_current_layout): New function.
829 (show_layout): Set applied_layout. Call
830 tui_apply_current_layout.
831 (show_source_command, show_disasm_command)
832 (show_source_disasm_command, show_data)
833 (show_source_or_disasm_and_command): Remove.
834 (initialize_layouts): New function.
835 (_initialize_tui_layout): Call initialize_layouts.
836
837 2019-12-11 Tom Tromey <tom@tromey.com>
838
839 * tui/tui-layout.h (class tui_layout_base)
840 (class tui_layout_window, class tui_layout_split): New.
841 * tui/tui-layout.c (tui_get_window_by_name)
842 (tui_layout_window::clone, tui_layout_window::apply)
843 (tui_layout_window::get_sizes, tui_layout_window::add_split)
844 (tui_layout_split::add_window, tui_layout_split::clone)
845 (tui_layout_split::get_sizes)
846 (tui_layout_split::set_weights_from_heights)
847 (tui_layout_split::adjust_size, tui_layout_split::apply): New
848 functions.
849 (tui_layout_split::add_split, tui_layout_split::add_split)
850 (tui_layout_split::set_weights_from_heights)
851 (tui_layout_split::set_weights_from_heights): New functions.
852
853 2019-12-11 Tom Tromey <tom@tromey.com>
854
855 * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
856 * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
857 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
858 * tui/tui-data.h (struct tui_point): Remove.
859 (struct tui_gen_win_info) <origin>: Remove.
860 <x, y>: New fields.
861 * tui/tui-command.c (tui_cmd_window::resize): Update.
862
863 2019-12-11 Tom Tromey <tom@tromey.com>
864
865 * tui/tui-stack.h (struct tui_locator_window) <min_height>:
866 Implement.
867 * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
868 Implement.
869 * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
870 method.
871 (struct tui_win_info) <min_height>: Implement.
872
873 2019-12-11 Tom Tromey <tom@tromey.com>
874
875 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
876 (struct tui_win_info) <can_box>: Update.
877
878 2019-12-11 Tom Tromey <tom@tromey.com>
879
880 * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
881 method.
882 * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
883 method.
884 * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
885 method.
886 (struct tui_win_info) <max_height>: Now override.
887
888 2019-12-11 Joel Brobecker <brobecker@adacore.com>
889
890 * NEWS: Create a new section for the next release branch.
891 Rename the section of the current branch, now that it has
892 been cut.
893
894 2019-12-11 Joel Brobecker <brobecker@adacore.com>
895
896 GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
897 * version.in: Bump version to 10.0.50.DATE-git.
898
899 2019-12-11 Tom Tromey <tromey@adacore.com>
900
901 PR build/25268:
902 * gdbsupport/thread-pool.c (set_thread_name): New function.
903 (thread_pool::set_thread_count): Don't call pthread_setname_np.
904 (thread_pool::thread_function): Call set_thread_name.
905
906 2019-12-11 Tom Tromey <tromey@adacore.com>
907
908 * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
909 bfd_get_signed_8.
910
911 2019-12-11 Philippe Waroquiers <philippe.waroquiers@skynet.be>
912
913 * NEWS: Document -raw-values option and the related setting commands.
914 * printcmd.c (print_command_parse_format): Do not set opts->raw off,
915 only set it on when /r is given.
916 * valprint.c (value_print_option_defs): New element raw-values.
917 * Makefile.in: Add the new file.
918
919 2019-12-10 Christian Biesinger <cbiesinger@google.com>
920
921 * gdbsupport/safe-strerror.c: Supress the unused function warning
922 for select_strerror_r.
923
924 2019-12-10 Christian Biesinger <cbiesinger@google.com>
925
926 * config.in: Regenerate.
927 * configure: Regenerate.
928 * gdbsupport/agent.c (gdb_connect_sync_socket): Call
929 safe_strerror instead of strerror.
930 * gdbsupport/common.m4: Don't check for strerror.
931 * gdbsupport/safe-strerror.c: Support both the glibc version
932 of strerror_r and the XSI version.
933
934 2019-12-10 Tom Tromey <tromey@adacore.com>
935
936 * ada-typeprint.c (print_choices): Use a single "?".
937 (print_variant_part): Print "?" if the discriminant name
938 is not known.
939
940 2019-12-10 George Barrett <bob@bob131.so>
941
942 Fix scripted probe breakpoints.
943 * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
944 declaration forward.
945 (breakpoint_ops_for_event_location_type)
946 (breakpoint_ops_for_event_location): Add function definitions.
947 (break_command_1, trace_command): Use
948 breakpoint_ops_for_event_location.
949 * breakpoint.h (breakpoint_ops_for_event_location): Add function
950 declarations.
951 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
952 breakpoint_ops_for_event_location.
953 * python/py-breakpoint.c (bppy_init): Use
954 breakpoint_ops_for_event_location.
955
956 2019-12-09 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
957
958 * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
959 when ranking an lvalue argument for an rvalue parameter.
960
961 2019-12-08 Wataru Ashihara <wataash@wataash.com>
962
963 * darwin-nat.c (darwin_nat_target::create_inferior): Fix
964 template argument for scoped_restore_tmpl from bool to int.
965
966 2019-12-07 Keith Seitz <keiths@redhat.com>
967
968 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
969 (build_id_to_debug_bfd): Make static, rewriting to use
970 build_id_to_bfd_suffix.
971 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
972 adding `suffix' parameter. Append SUFFIX to file names
973 when searching for matching files.
974 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
975 (build_id_to_exec_bfd): Likewise.
976 * build-id.h (build_id_to_debug_bfd): Clarify that function
977 searches for BFD of debug info file.
978 (build_id_to_exec_bfd): Declare.
979 * corelow.c: Include build-id.h.
980 (locate_exec_from_corefile_build_id): New function.
981 (core_target_open): If no executable BFD is found,
982 search for a core file BFD using build-id.
983
984 2019-12-06 Christian Biesinger <cbiesinger@google.com>
985
986 * bcache.c: Put in namespace gdb.
987 * bcache.h: Likewise.
988 * gdbtypes.c (check_types_worklist): Update.
989 (types_deeply_equal): Update.
990 * macrotab.c (struct macro_table) <bcache>: Update.
991 (new_macro_table): Update.
992 * macrotab.h (struct bcache): Put this forward declaration
993 inside namespace gdb.
994 (new_macro_table): Update.
995 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
996 Update.
997 <macro_cache>: Update.
998 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
999
1000 2019-12-06 Tom de Vries <tdevries@suse.de>
1001
1002 PR symtab/24971
1003 * block.c (best_symbol, better_symbol): New function.
1004 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
1005 decl.
1006
1007 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1008
1009 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
1010 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
1011 for ranking see-through reference cases.
1012
1013 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1014 * stack.c (faas_command): Check a command is provided.
1015 * thread.c (taas_command, tfaas_command): Likewise.
1016
1017 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1018 * inferior.c (prune_inferiors): Only call delete_inferior,
1019 Do not modify the inferior list.
1020
1021 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
1022
1023 * c-exp.y: Update calls to lookup_typename,
1024 lookup_signed_typename and lookup_unsigned_typename.
1025 * c-lang.c (evaluate_subexp_c): Likewise.
1026 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
1027 Likewise.
1028 * eval.c (binop_promote): Likewise.
1029 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
1030 (lookup_unsigned_typename): Likewise.
1031 (lookup_signed_typename): Likewise.
1032 * gdbtypes.h (lookup_unsigned_typename): Likewise.
1033 (lookup_signed_typename): Likewise.
1034 (lookup_typename): Likewise.
1035 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
1036 lookup_typename, lookup_signed_typename,
1037 lookup_unsigned_typename.
1038 * m2-exp.y: Likewise.
1039 * printcmd.c (printf_wide_c_string): Likewise.
1040 (ui_printf): Likewise.
1041 * python/py-type.c (typy_lookup_typename): Likewise.
1042 * python/py-xmethods.c (python_xmethod_worker::invoke):
1043 Likewise.
1044 * rust-exp.y: Likewise.
1045
1046 2019-12-04 Christian Biesinger <cbiesinger@google.com>
1047
1048 * configure.nat (obsd64): Add missing files x86-nat.o and
1049 nat/x86-dregs.o.
1050
1051 2019-12-04 Tom Tromey <tom@tromey.com>
1052
1053 * valprint.c (val_print_string): Use metadata_style.
1054 * go-valprint.c (print_go_string): Use metadata style.
1055 * p-valprint.c (pascal_object_print_static_field): Use metadata
1056 style.
1057 * cp-valprint.c (cp_print_static_field): Use metadata style.
1058
1059 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1060 Chris January <chris.january@arm.com>
1061
1062 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
1063 tokens.
1064 (typebase): New patterns for complex, single/double precision, and
1065 single/double complex.
1066 (f77_keywords): Change token for complex keyword, and add single,
1067 double, and precision keywords.
1068
1069 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1070
1071 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
1072 "info io_registers".
1073
1074 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1075
1076 * regcache.c (cooked_read_test): Initialize thread list of
1077 mock_inferior.
1078
1079 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1080
1081 * aarch64-linux-tdep.c: Remove includes.
1082
1083 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
1084
1085 * aarch64-tdep.c: Remove includes.
1086
1087 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
1088
1089 * filtered-iterator.h (filtered_iterator) <operator==,
1090 operator!=>: Compare wrapped iterators, not wrapped pointers.
1091 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1092 unittests/filtered_iterator-selftests.c.
1093 * unittests/filtered_iterator-selftests.c: New file.
1094
1095 2019-12-04 Tom Tromey <tromey@adacore.com>
1096
1097 * gdbtypes.c (create_range_type): Inherit endianity
1098 from base type.
1099
1100 2019-12-04 Tom Tromey <tromey@adacore.com>
1101
1102 * ada-lang.c (decode_constrained_packed_array)
1103 (ada_value_assign, value_assign_to_component): Update.
1104 * dwarf2loc.c (rw_pieced_value, access_memory)
1105 (dwarf2_compile_expr_to_ax): Update.
1106 * dwarf2read.c (dwarf2_add_field): Update.
1107 * eval.c (evaluate_subexp_standard): Update.
1108 * gdbarch.c, gdbarch.h: Rebuild.
1109 * gdbarch.sh (bits_big_endian): Remove.
1110 * gdbtypes.h (union field_location): Update comment.
1111 * target-descriptions.c (make_gdb_type): Update.
1112 * valarith.c (value_bit_index): Update.
1113 * value.c (struct value) <bitpos>: Update comment.
1114 (unpack_bits_as_long, modify_field): Update.
1115 * value.h (value_bitpos): Update comment.
1116
1117 2019-12-04 Tom Tromey <tromey@adacore.com>
1118
1119 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
1120 endian-ness.
1121
1122 2019-12-04 Tom Tromey <tromey@adacore.com>
1123
1124 * dwarf2read.c (dwarf2_init_float_type)
1125 (dwarf2_init_complex_target_type): Add byte_order parameter.
1126 (read_base_type): Compute byte order earlier.
1127 * gdbtypes.c (init_float_type): Add byte_order parameter.
1128 * gdbtypes.h (init_float_type): Add byte_order parameter.
1129
1130 2019-12-04 Tom Tromey <tromey@adacore.com>
1131
1132 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
1133
1134 2019-12-04 Tom Tromey <tromey@adacore.com>
1135
1136 * dwarf2read.c (process_structure_scope): Initialize
1137 "discr_offset".
1138
1139 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1140
1141 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
1142 add it into the search spec.
1143 (parse_max_results_option): New function.
1144 (mi_info_functions_or_variables): Parse -max-results flag and pass
1145 it to mi_symbol_info.
1146 (mi_cmd_symbol_info_modules): Likewise.
1147 (mi_cmd_symbol_info_types): Likewise.
1148 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1149 return type to bool, change result container into a set, and don't
1150 add new results if we have enough already.
1151 (global_symbol_searcher::add_matching_msymbols): Change return
1152 type to bool, and don't add new results if we have enough already.
1153 (sort_search_symbols_remove_dups): Delete.
1154 (global_symbol_searcher::search): Early exit from search loop when
1155 we have enough results. Use a std::set to collect the results
1156 from calling add_matching_symbols.
1157 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1158 member function.
1159 (global_symbol_searcher) <m_max_search_results>: New member
1160 variable.
1161 (global_symbol_searcher) <add_matching_symbols>: Update header
1162 comment and change return type to bool.
1163 (global_symbol_searcher) <add_matching_msymbols>: Update header
1164 comment and change return type to bool.
1165
1166 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1167
1168 * symtab.c (symbol_search::compare_search_syms): Update header
1169 comment.
1170 (global_symbol_searcher::is_suitable_msymbol): New function.
1171 (global_symbol_searcher::expand_symtabs): New function.
1172 (global_symbol_searcher::add_matching_symbols): New function.
1173 (global_symbol_searcher::add_matching_msymbols): New function.
1174 (global_symbol_searcher::search): Move most of the content
1175 into the new functions above, and call them as needed.
1176 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1177 function.
1178 (global_symbol_searcher) <add_matching_symbols>: New member
1179 function.
1180 (global_symbol_searcher) <add_matching_msymbols>: New member
1181 function.
1182 (global_symbol_searcher) <is_suitable_msymbol>: New member
1183 function.
1184
1185 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
1186
1187 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1188 -symbol-info-module-variables entries.
1189 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1190 (mi_cmd_symbol_info_module_variables): Declare.
1191 * mi/mi-symbol-cmds.c
1192 (module_symbol_search_iterator): New typedef.
1193 (output_module_symbols_in_single_module_and_file): New function.
1194 (output_module_symbols_in_single_module): New function.
1195 (mi_info_module_functions_or_variables): New function.
1196 (mi_cmd_symbol_info_module_functions): New function.
1197 (mi_cmd_symbol_info_module_variables): New function.
1198 * NEWS: Mention new MI command.
1199
1200 2019-12-03 Christian Biesinger <cbiesinger@google.com>
1201
1202 * bcache.c (hash): Remove.
1203 (hash_continue): Remove.
1204 * bcache.h (hash): Remove.
1205 (hash_continue): Remove.
1206 (struct bcache) <ctor>: Update.
1207 * psymtab.c (psymbol_hash): Update.
1208 * stabsread.c (hashname): Update.
1209 * utils.h (fast_hash): Add an argument for a start value,
1210 defaulting to zero.
1211
1212 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1213 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
1214 (destroy_block_symbol_cache): New function.
1215 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1216 (resize_symbol_cache): Likewise.
1217
1218 2019-12-02 Tom Tromey <tom@tromey.com>
1219
1220 * unittests/tui-selftests.c (run_tests): Make conditional.
1221 (_initialize_tui_selftest): Make conditional.
1222
1223 2019-12-02 Christian Biesinger <cbiesinger@google.com>
1224
1225 * aix-thread.c (debug_aix_thread): Change type to bool.
1226
1227 2019-12-02 Luis Machado <luis.machado@linaro.org>
1228
1229 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1230
1231 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1232
1233 * dwarf2read.c (read_tag_string_type): Read the fields required to
1234 make a dynamic string, and possibly create a dynamic range for the
1235 string.
1236 (attr_to_dynamic_prop): Setup is_reference based on the type of
1237 attribute being processed.
1238 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1239 (resolve_dynamic_array): Rename to...
1240 (resolve_dynamic_array_or_string): ...this, update header comment,
1241 and accept TYPE_CODE_STRING.
1242 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1243
1244 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1245
1246 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1247 of its implementation from...
1248 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1249 the new function.
1250
1251 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
1252
1253 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1254 create a range with stride where appropriate.
1255 * f-valprint.c: Include 'gdbarch.h'.
1256 (f77_print_array_1): Take the stride into account when walking the
1257 array. Also convert the stride into addressable units.
1258 * gdbtypes.c (create_range_type): Initialise the stride to
1259 constant zero.
1260 (create_range_type_with_stride): New function, initialise the
1261 range as normal, and then setup the stride.
1262 (has_static_range): Include the stride here. Also change the
1263 return type to bool.
1264 (create_array_type_with_stride): Consider the range stride if the
1265 array isn't given its own stride.
1266 (resolve_dynamic_range): Resolve the stride if needed.
1267 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1268 (struct range_bounds) <flag_is_byte_stride>: New member variable.
1269 (TYPE_BIT_STRIDE): Define.
1270 (TYPE_ARRAY_BIT_STRIDE): Define.
1271 (create_range_type_with_stride): Declare.
1272 * valarith.c (value_subscripted_rvalue): Take range stride into
1273 account when walking the array.
1274
1275 2019-12-01 Tom Tromey <tom@tromey.com>
1276
1277 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1278 specially.
1279
1280 2019-12-01 Tom Tromey <tom@tromey.com>
1281
1282 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1283 \0.
1284 * unittests/tui-selftests.c: New file.
1285 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1286
1287 2019-12-01 Tom Tromey <tom@tromey.com>
1288
1289 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1290
1291 2019-12-01 Tom Tromey <tom@tromey.com>
1292
1293 * NEWS: Document new settings.
1294 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1295 * tui/tui-win.c (_initialize_tui_win): Add border style
1296 observers.
1297 * tui/tui-io.h (tui_apply_style): Declare.
1298 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
1299 longer static.
1300 (apply_ansi_escape, tui_set_reverse_mode): Update.
1301 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1302 Add "skip_intensity" parameter.
1303 <changed>: New member.
1304 <do_set_value>: Declare.
1305 (tui_border_style, tui_active_border_style): Declare.
1306 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1307 globals.
1308 (cli_style_option): Initialize "changed".
1309 (cli_style_option::do_set_value): New function.
1310 (cli_style_option::add_setshow_commands): Add "skip_intensity"
1311 parameter. Update.
1312 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1313 (_initialize_cli_style): Update. Create TUI border style
1314 commands.
1315
1316 2019-12-01 Tom Tromey <tom@tromey.com>
1317
1318 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1319 parameter.
1320 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1321 parameter.
1322 * tui/tui-win.h (compact_source): Declare.
1323 * tui/tui-win.c (compact_source): New global.
1324 (tui_set_compact_source, tui_show_compact_source): New functions.
1325 (_initialize_tui_win): Add "compact-source" setting.
1326 * tui/tui-source.c (tui_source_window::set_contents): Handle
1327 compact_source setting.
1328 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1329 * NEWS: Document new setting.
1330
1331 2019-11-30 Tom Tromey <tom@tromey.com>
1332
1333 * dwarf2read.c (dwarf2_add_field): Include field offset when
1334 computing variant part length.
1335
1336 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1337 * NEWS: Mention define-prefix. Tell that command names can now
1338 contain a . character.
1339
1340 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1341
1342 * command.h (valid_cmd_char_p): Declare.
1343 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1344 the check of valid command char.
1345 (find_command_name_length, valid_user_defined_cmd_name_p): Use
1346 valid_cmd_char_p.
1347 * cli/cli-script.c (validate_comname): Likewise.
1348 * completer.c (gdb_completer_command_word_break_characters):
1349 Do not remove . from the word break char, update comments.
1350 (complete_line_internal_1): Use valid_cmd_char_p.
1351 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1352 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1353
1354 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1355
1356 * cli/cli-script.c (do_define_command): Ensure a redefined
1357 prefix command is kept as a prefix command.
1358 (define_prefix_command): New function.
1359 (show_user_1): Report user defined prefixes.
1360 (_initialize_cli_script): Create the new 'define-prefix' command.
1361 Add completers for 'define' and 'document'.
1362 * top.c (execute_command): If command is a user-defined prefix only
1363 command, report the list of commands for this prefix command.
1364
1365 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1366
1367 * valops.c (find_oload_champ): Improve debug output.
1368
1369 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
1370
1371 * valops.c (find_oload_champ): Print part of debug messages
1372 before the badness vector is std::move'd.
1373
1374 2019-11-28 Tom Tromey <tom@tromey.com>
1375
1376 * value.c (creal_internal_fn): Fix comment.
1377
1378 2019-11-28 Tom Tromey <tom@tromey.com>
1379
1380 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1381 flag_bound_evaluated>: Now unsigned.
1382
1383 2019-11-28 Tom Tromey <tom@tromey.com>
1384
1385 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1386 declare.
1387
1388 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
1389
1390 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1391 debug output.
1392 * jit.c (jit_unregister_code): Add debug print to match
1393 `jit_register_code`.
1394
1395 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1396
1397 * NEWS: Mention the new multithreaded symbol loading.
1398
1399 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1400
1401 * maint.c (n_worker_threads): Default to 0.
1402 (worker_threads_disabled): New function.
1403 * maint.h (worker_threads_disabled): New function.
1404 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1405 here if worker_threads_disabled () is true.
1406 (minimal_symbol_reader::install): Skip all threading if
1407 worker_threads_disabled () is true.
1408
1409 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1410
1411 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1412 hash code if possible.
1413 (add_minsym_to_demangled_hash_table): Likewise.
1414 (minimal_symbol_reader::install): Compute the hash codes for msymbol
1415 on the background thread.
1416 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1417 Add these fields.
1418
1419 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1420
1421 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1422 of the mangled name on the background thread.
1423 * symtab.c (symbol_set_names): Allow passing in the hash of the
1424 linkage_name.
1425 * symtab.h (symbol_set_names): Likewise.
1426
1427 2019-11-27 Kevin Buettner <kevinb@redhat.com>
1428
1429 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1430 physnames are computed for inherited DIEs.
1431
1432 2019-11-27 Tom Tromey <tromey@adacore.com>
1433
1434 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1435 backslashes.
1436 * cp-support.c: Remove unnecessary backslashes.
1437
1438 2019-11-27 Christian Biesinger <cbiesinger@google.com>
1439
1440 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1441 with sym->set_linkage_name.
1442 * coffread.c (coff_read_enum_type): Likewise.
1443 * mdebugread.c (parse_symbol): Likewise.
1444 * stabsread.c (patch_block_stabs): Likewise.
1445 (define_symbol): Likewise.
1446 (read_enum_type): Likewise.
1447 (common_block_end): Likewise.
1448 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1449 function.
1450 (SYMBOL_SET_LINKAGE_NAME): Remove.
1451 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1452 with sym->set_linkage_name.
1453
1454 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1455
1456 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1457 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1458 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1459 * NEWS: Mention new MI command.
1460
1461 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1462
1463 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1464 '-symbol-info-types', and '-symbol-info-variables'.
1465 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1466 (mi_cmd_symbol_info_types): Declare.
1467 (mi_cmd_symbol_info_variables): Declare.
1468 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1469 (output_debug_symbol): New function.
1470 (output_nondebug_symbol): New function.
1471 (mi_symbol_info): New function.
1472 (mi_info_functions_or_variables): New function.
1473 (mi_cmd_symbol_info_functions): New function.
1474 (mi_cmd_symbol_info_types): New function.
1475 (mi_cmd_symbol_info_variables): New function.
1476 * NEWS: Mention new commands.
1477
1478 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1479
1480 * symtab.c (symbol_to_info_string): New function, most content
1481 moved from print_symbol_info, but updated to return a std::string.
1482 (print_symbol_info): Update to use symbol_to_info_string and print
1483 returned string.
1484 * symtab.h (symbol_to_info_string): Declare new function.
1485
1486 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
1487
1488 * python/python.c (gdbpy_rbreak): Convert to using
1489 global_symbol_searcher.
1490 * symtab.c (file_matches): Convert return type to bool, change
1491 file list to std::vector, update header comment.
1492 (search_symbols): Rename to...
1493 (global_symbol_searcher::search): ...this and update now its
1494 a member function of global_symbol_searcher. Take account of the
1495 changes to file_matches.
1496 (symtab_symbol_info): Convert to using global_symbol_searcher.
1497 (rbreak_command): Likewise.
1498 (search_module_symbols): Likewise.
1499 * symtab.h (enum symbol_search): Update comment.
1500 (search_symbols): Remove declaration.
1501 (class global_symbol_searcher): New class.
1502
1503 2019-11-26 Tom Tromey <tromey@adacore.com>
1504
1505 * cp-support.c (_initialize_cp_support): Conditionally initialize
1506 gdb_demangle_attempt_core_dump.
1507
1508 2019-11-26 Tom Tromey <tom@tromey.com>
1509
1510 * python/py-function.c (fnpy_init): Update.
1511 * value.h (add_internal_function): Adjust declaration.
1512 * value.c (function_destroyer): Remove.
1513 (do_add_internal_function): Don't set destroyer or copy name.
1514 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1515 Set name_allocated.
1516 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1517 (cmdpy_init): Set name_allocated.
1518 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1519 member.
1520 (~cmd_list_element): Free "name" if needed.
1521
1522 2019-11-26 Tom Tromey <tom@tromey.com>
1523
1524 * value.h (add_internal_function): Add new overload. Move
1525 documentation from value.h.
1526 * value.c (do_add_internal_function): New function.
1527 (add_internal_function): Use it. Add new overload.
1528 (function_destroyer): Don't free doc.
1529 * python/py-function.c (fnpy_init): Update.
1530
1531 2019-11-26 Tom Tromey <tom@tromey.com>
1532
1533 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1534 (cmdpy_init): Set "doc_allocated".
1535
1536 2019-11-26 Tom Tromey <tom@tromey.com>
1537
1538 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1539 name of worker thread.
1540 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1541 pthread_setname_np.
1542 * configure, config.in: Rebuild.
1543
1544 2019-11-26 Tom Tromey <tom@tromey.com>
1545
1546 * python/python.c (class gdbpy_gil): New.
1547 (struct gdbpy_event): Add constructor, destructor, operator().
1548 (gdbpy_post_event): Use run_on_main_thread.
1549 (gdbpy_initialize_events): Remove.
1550 (do_start_initialization): Update.
1551
1552 2019-11-26 Tom Tromey <tom@tromey.com>
1553
1554 * NEWS: Add entry.
1555 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1556 commands. Call update_thread_pool_size.
1557 (update_thread_pool_size, maintenance_set_worker_threads): New
1558 functions.
1559 (n_worker_threads): New global.
1560
1561 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1562 Tom Tromey <tom@tromey.com>
1563
1564 * minsyms.c (minimal_symbol_reader::install): Use
1565 parallel_for_each.
1566 * gdbsupport/parallel-for.h: New file.
1567 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1568
1569 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1570 Tom Tromey <tom@tromey.com>
1571
1572 * gdbsupport/thread-pool.h: New file.
1573 * gdbsupport/thread-pool.c: New file.
1574 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1575 (HFILES_NO_SRCDIR): Add thread-pool.h.
1576
1577 2019-11-26 Tom Tromey <tom@tromey.com>
1578
1579 * event-top.h (thread_local_segv_handler): Declare.
1580 * event-top.c (thread_local_segv_handler): New global.
1581 (install_handle_sigsegv, handle_sigsegv): New functions.
1582 (async_init_signals): Install SIGSEGV handler.
1583 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
1584 thread-local.
1585 (report_failed_demangle): New function.
1586 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
1587 handler-setting code, instead use segv_handler. Run warning code
1588 on main thread.
1589
1590 2019-11-26 Tom Tromey <tom@tromey.com>
1591
1592 * run-on-main-thread.c: New file.
1593 * run-on-main-thread.h: New file.
1594 * unittests/main-thread-selftests.c: New file.
1595 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1596 main-thread-selftests.c.
1597 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1598 (COMMON_SFILES): Add run-on-main-thread.c.
1599
1600 2019-11-26 Tom Tromey <tom@tromey.com>
1601
1602 * main.c (setup_alternate_signal_stack): Remove.
1603 (captured_main_1): Use gdb::alternate_signal_stack.
1604 * gdbsupport/alt-stack.h: New file.
1605
1606 2019-11-26 Tom Tromey <tom@tromey.com>
1607
1608 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1609 Remove comment.
1610 (save_original_signals_state, restore_original_signals_state): Use
1611 gdb_sigmask.
1612 * linux-nat.c (block_child_signals, restore_child_signals_mask)
1613 (_initialize_linux_nat): Use gdb_sigmask.
1614 * guile/guile.c (_initialize_guile): Use block_signals.
1615 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1616 * gdbsupport/gdb-sigmask.h: New file.
1617 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1618 * cp-support.c (gdb_demangle): Use gdb_sigmask.
1619 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1620 pthread_sigmask.
1621 * configure, config.in: Rebuild.
1622 * gdbsupport/block-signals.h: New file.
1623
1624 2019-11-26 Tom Tromey <tom@tromey.com>
1625
1626 * acinclude.m4: Include ax_pthread.m4.
1627 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1628 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1629 (CLIBS): Use PTHREAD_LIBS.
1630 (aclocal_m4_deps): Add ax_pthread.m4.
1631 * config.in, configure: Rebuild.
1632 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1633
1634 2019-11-26 Tom Tromey <tom@tromey.com>
1635
1636 * symtab.h (struct minimal_symbol) <name_set>: New member.
1637 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1638 Don't call symbol_set_names.
1639 (minimal_symbol_reader::install): Call symbol_set_names.
1640
1641 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1642
1643 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1644 restore_active_ext_lang, as GIL is needed for (indirectly)
1645 called PyOS_InterruptOccurred.
1646
1647 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1648
1649 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1650 definition.
1651
1652 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1653
1654 * remote-sim.c (simulator_command): Make static, remove
1655 declaration.
1656
1657 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1658
1659 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1660 static.
1661 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1662 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1663 (main): Likewise.
1664 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1665 (main): Likewise.
1666 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1667 (main): Likewise.
1668 * unittests/basic_string_view/element_access/char/1.cc (test01):
1669 Likewise.
1670 (main): Likewise.
1671 * unittests/basic_string_view/element_access/char/empty.cc (main):
1672 Likewise.
1673 * unittests/basic_string_view/element_access/char/front_back.cc
1674 (test01): Likewise.
1675 (main): Likewise.
1676 * unittests/basic_string_view/inserters/char/2.cc (test05):
1677 Likewise.
1678 (main): Likewise.
1679 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1680 (test01): Likewise.
1681 (main): Likewise.
1682 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1683 (test01): Likewise.
1684 (main): Likewise.
1685 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1686 Likewise.
1687 * unittests/basic_string_view/operations/compare/char/1.cc
1688 (test01): Likewise.
1689 (main): Likewise.
1690 * unittests/basic_string_view/operations/compare/char/13650.cc
1691 (test01): Likewise.
1692 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1693 Likewise.
1694 (main): Likewise.
1695 * unittests/basic_string_view/operations/data/char/1.cc (test01):
1696 Likewise.
1697 (main): Likewise.
1698 * unittests/basic_string_view/operations/find/char/1.cc (test01):
1699 Likewise.
1700 (main): Likewise.
1701 * unittests/basic_string_view/operations/find/char/2.cc (test02):
1702 Likewise.
1703 (main): Likewise.
1704 * unittests/basic_string_view/operations/find/char/3.cc (test03):
1705 Likewise.
1706 (main): Likewise.
1707 * unittests/basic_string_view/operations/find/char/4.cc (main):
1708 Likewise.
1709 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1710 Likewise.
1711 (main): Likewise.
1712 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1713 Likewise.
1714 (main): Likewise.
1715 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1716 Likewise.
1717 (main): Likewise.
1718 * unittests/basic_string_view/operations/substr/char/1.cc
1719 (test01): Likewise.
1720 (main): Likewise.
1721 * unittests/basic_string_view/operators/char/2.cc (main):
1722 Likewise.
1723 * unittests/optional/assignment/1.cc (test): Likewise.
1724 * unittests/optional/assignment/2.cc (test): Likewise.
1725 * unittests/optional/assignment/3.cc (test): Likewise.
1726 * unittests/optional/assignment/4.cc (test): Likewise.
1727 * unittests/optional/assignment/5.cc (test): Likewise.
1728 * unittests/optional/assignment/6.cc (test): Likewise.
1729 * unittests/optional/assignment/7.cc (test): Likewise.
1730 * unittests/optional/cons/copy.cc (test): Likewise.
1731 * unittests/optional/cons/default.cc (test): Likewise.
1732 * unittests/optional/cons/move.cc (test): Likewise.
1733 * unittests/optional/cons/value.cc (test): Likewise.
1734 * unittests/optional/in_place.cc (test): Likewise.
1735 * unittests/optional/observers/1.cc (test): Likewise.
1736 * unittests/optional/observers/2.cc (test): Likewise.
1737
1738 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1739
1740 * tui-win.h (tui_set_var_cmd): Remove.
1741 * tui-win.c (tui_set_var_cmd): Make static.
1742
1743 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1744
1745 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1746 rbreak_command_wrapper): Remove.
1747 * symtab.c (rbreak_command_wrapper): Remove.
1748
1749 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1750
1751 * inferior.h (info_terminal_command): Remove declaration.
1752 * inflow.c (info_terminal_command): Make static.
1753
1754 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1755
1756 * inferior.c (exit_inferior_silent): Remove.
1757
1758 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1759
1760 * dictionary.c (dict_empty, mdict_empty): Remove.
1761 * dictionary.c (mdict_empty): Remove.
1762
1763 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1764
1765 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1766 (arc_insn_get_memory_offset): Likewise.
1767 (arc_insn_dump): Likewise.
1768 * cp-support.c (test_cp_symbol_name_matches): Likewise.
1769 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1770 * dictionary.c (dict_iterator_next): Likewise.
1771 (dict_iter_match_first): Likewise.
1772 (dict_iter_match_next): Likewise.
1773 * f-lang.c (evaluate_subexp_f): Likewise.
1774 * hppa-tdep.c (hppa_read_pc): Likewise.
1775 * i386-tdep.c (i386_floatformat_for_type): Likewise.
1776 * parse.c (write_exp_elt_msym): Likewise.
1777 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1778 * remote.c (remote_packet_size): Likewise.
1779 (remote_notif_stop_parse): Likewise.
1780 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1781 * s12z-tdep.c (s12z_disassemble_info): Likewise.
1782 * source.c (prepare_path_for_appending): Likewise.
1783 * sparc64-linux-tdep.c
1784 (sparc64_linux_handle_segmentation_fault); Likewise.
1785 * stack.c (frame_selection_by_function_completer): Likewise.
1786
1787 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1788
1789 * completer.c (set_gdb_completion_word_break_characters):
1790 Remove.
1791
1792 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1793
1794 * dwarf-index-write.c: Include dwarf-index-write.h.
1795 * mi/mi-interp.c: Include mi/mi-interp.h.
1796
1797 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
1798
1799 * aarch32-tdep.c: Include aarch32-tdep.h.
1800 * aarch32-tdep.h: Forward-declare struct target_desc.
1801
1802 2019-11-26 Christian Biesinger <cbiesinger@google.com>
1803
1804 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1805 strerror.
1806 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1807 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1808
1809 2019-11-25 Tom de Vries <tdevries@suse.de>
1810
1811 * contrib/words.sh: Add -c option.
1812
1813 2019-11-25 Christian Biesinger <cbiesinger@google.com>
1814
1815 * solib.c (solib_find_1): Change int to bool.
1816 (exec_file_find): Change int to bool.
1817 (solib_find): Change int to bool.
1818 (solib_read_symbols): Change int to bool.
1819 (solib_used): Change int to bool.
1820 (solib_add): Change int to bool.
1821 (info_sharedlibrary_command): Change int to bool.
1822 (solib_contains_address_p): Change int to bool.
1823 (solib_keep_data_in_core): Change int to bool.
1824 (in_solib_dynsym_resolve_code): Change int to bool.
1825 (reload_shared_libraries_1): Change int to bool.
1826 (gdb_sysroot_changed): Change int to bool.
1827 * solib.h (solib_read_symbols): Change int to bool.
1828 (solib_contains_address_p): Change int to bool.
1829 (solib_keep_data_in_core): Change int to bool.
1830 (in_solib_dynsym_resolve_code): Change int to bool.
1831 (libpthread_name_p): Change int to bool.
1832
1833 2019-11-25 Luis Machado <luis.machado@linaro.org>
1834
1835 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1836 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1837 (remote_packet_max_chars): New static global.
1838 (show_remote_packet_max_chars): New function.
1839 (remote_target::putpkt_binary): Adjust to use new
1840 remote_packet_max_chars option.
1841 (remote_target::getpkt_or_notif_sane_1): Likewise.
1842 (_initialize_remote): Register new remote-packet-max-chars option.
1843
1844 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
1845
1846 * m68k-linux-nat.c: Include gdbarch.h.
1847
1848 2019-11-24 Tom Tromey <tom@tromey.com>
1849
1850 * symfile.c (read_symbols): Update.
1851 * psymtab.c (require_partial_symbols): Change type of "verbose" to
1852 bool.
1853 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1854 (psym_lookup_symbol, psym_find_last_source_symtab)
1855 (psym_forget_cached_source_info, psym_print_stats)
1856 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1857 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1858 (psym_map_matching_symbols, psym_expand_symtabs_matching)
1859 (psym_find_compunit_symtab_by_address)
1860 (maintenance_print_psymbols, maintenance_info_psymtabs)
1861 (maintenance_check_psymtabs): Update.
1862 * psymtab.h (require_partial_symbols): Change type of "verbose" to
1863 bool.
1864
1865 2019-11-22 Tom Tromey <tom@tromey.com>
1866
1867 * observable.h: Update comments.
1868
1869 2019-11-22 Tom Tromey <tromey@adacore.com>
1870
1871 * ada-tasks.c (ada_task_is_alive): Make parameter const.
1872 (print_ada_task_info): Don't try to fetch thread id if task is not
1873 alive.
1874
1875 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1876
1877 * ada-exp.y: Update.
1878 * ada-lang.c (sort_choices): Update.
1879 (ada_print_symbol_signature): Update.
1880 (resolve_subexp): Update.
1881 (ada_parse_renaming): Update.
1882 (ada_read_renaming_var_value): Update.
1883 (lesseq_defined_than): Update.
1884 (remove_extra_symbols): Update.
1885 (remove_irrelevant_renamings): Update.
1886 (ada_add_block_symbols): Update.
1887 (ada_collect_symbol_completion_matches): Update.
1888 (ada_is_renaming_symbol): Update.
1889 (aggregate_assign_from_choices): Update.
1890 (ada_evaluate_subexp): Update.
1891 (ada_has_this_exception_support): Update.
1892 (ada_is_non_standard_exception_sym): Update.
1893 (ada_add_exceptions_from_frame): Update.
1894 (ada_add_global_exceptions): Update.
1895 (ada_print_subexp): Update.
1896 * ax-gdb.c (gen_var_ref): Update.
1897 (gen_maybe_namespace_elt): Update.
1898 (gen_expr_for_cast): Update.
1899 (gen_expr): Update.
1900 * block.h: Update.
1901 * blockframe.c (find_pc_partial_function): Update.
1902 * breakpoint.c (print_breakpoint_location): Update.
1903 (update_static_tracepoint): Update.
1904 * btrace.c (ftrace_print_function_name): Update.
1905 (ftrace_function_switched): Update.
1906 * buildsym.c (find_symbol_in_list): Update.
1907 * c-exp.y: Update.
1908 * c-typeprint.c (c_print_typedef): Update.
1909 (c_type_print_template_args): Update.
1910 * cli/cli-cmds.c (edit_command): Update.
1911 (list_command): Update.
1912 (print_sal_location): Update.
1913 * coffread.c (patch_opaque_types): Update.
1914 (process_coff_symbol): Update.
1915 (coff_read_enum_type): Update.
1916 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1917 (convert_one_symbol): Update.
1918 (hash_symname): Update.
1919 (eq_symname): Update.
1920 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1921 * compile/compile-cplus-types.c (debug_print_scope): Update.
1922 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1923 * compile/compile-object-load.c (get_out_value_type): Update.
1924 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1925 (search_symbol_list): Update.
1926 (cp_lookup_symbol_imports_or_template): Update.
1927 * cp-support.c (overload_list_add_symbol): Update.
1928 * ctfread.c (psymtab_to_symtab): Update.
1929 * dbxread.c (cp_set_block_scope): Update.
1930 * dictionary.c (iter_match_first_hashed): Update.
1931 (iter_match_next_hashed): Update.
1932 (insert_symbol_hashed): Update.
1933 (iter_match_next_linear): Update.
1934 * dictionary.h: Update.
1935 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1936 (locexpr_describe_location_piece): Update.
1937 (locexpr_describe_location_1): Update.
1938 (locexpr_generate_c_location): Update.
1939 (loclist_describe_location): Update.
1940 (loclist_generate_c_location): Update.
1941 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1942 (read_func_scope): Update.
1943 (process_enumeration_scope): Update.
1944 (new_symbol): Update.
1945 (dwarf2_const_value): Update.
1946 (dwarf2_symbol_mark_computed): Update.
1947 * eval.c (evaluate_funcall): Update.
1948 (evaluate_subexp_standard): Update.
1949 * expprint.c (print_subexp_standard): Update.
1950 (dump_subexp_body_standard): Update.
1951 * f-valprint.c (info_common_command_for_block): Update.
1952 * findvar.c (get_hosting_frame): Update.
1953 (default_read_var_value): Update.
1954 * go-lang.c (go_symbol_package_name): Update.
1955 * guile/scm-block.c (bkscm_print_block_smob): Update.
1956 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1957 (gdbscm_symbol_name): Update.
1958 (gdbscm_symbol_linkage_name): Update.
1959 (gdbscm_symbol_print_name): Update.
1960 * infcall.c (get_function_name): Update.
1961 * infcmd.c (jump_command): Update.
1962 (finish_command): Update.
1963 * infrun.c (insert_exception_resume_breakpoint): Update.
1964 * linespec.c (canonicalize_linespec): Update.
1965 (create_sals_line_offset): Update.
1966 (convert_linespec_to_sals): Update.
1967 (complete_label): Update.
1968 (find_label_symbols_in_block): Update.
1969 * m2-typeprint.c (m2_print_typedef): Update.
1970 * mdebugread.c (mdebug_reg_to_regnum): Update.
1971 (parse_symbol): Update.
1972 (mylookup_symbol): Update.
1973 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1974 (list_args_or_locals): Update.
1975 * objc-lang.c (compare_selectors): Update.
1976 (info_selectors_command): Update.
1977 (compare_classes): Update.
1978 (info_classes_command): Update.
1979 (find_imps): Update.
1980 * p-typeprint.c (pascal_print_typedef): Update.
1981 * printcmd.c (build_address_symbolic): Update.
1982 (info_address_command): Update.
1983 (print_variable_and_value): Update.
1984 * python/py-framefilter.c (extract_sym): Update.
1985 (py_print_single_arg): Update.
1986 * python/py-symbol.c (sympy_str): Update.
1987 (sympy_get_name): Update.
1988 (sympy_get_linkage_name): Update.
1989 * python/python.c (gdbpy_rbreak): Update.
1990 * record-btrace.c (btrace_get_bfun_name): Update.
1991 (btrace_call_history): Update.
1992 * rust-lang.c (rust_print_typedef): Update.
1993 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1994 * stabsread.c (stab_reg_to_regnum): Update.
1995 (define_symbol): Update.
1996 (read_enum_type): Update.
1997 (common_block_end): Update.
1998 (cleanup_undefined_types_1): Update.
1999 (scan_file_globals): Update.
2000 * stack.c (print_frame_arg): Update.
2001 (print_frame_args): Update.
2002 (find_frame_funname): Update.
2003 (info_frame_command_core): Update.
2004 (iterate_over_block_locals): Update.
2005 (print_block_frame_labels): Update.
2006 (do_print_variable_and_value): Update.
2007 (iterate_over_block_arg_vars): Update.
2008 (return_command): Update.
2009 * symmisc.c (dump_symtab_1): Update.
2010 (print_symbol): Update.
2011 * symtab.c (eq_symbol_entry): Update.
2012 (symbol_cache_dump): Update.
2013 (lookup_language_this): Update.
2014 (find_pc_sect_line): Update.
2015 (skip_prologue_sal): Update.
2016 (symbol_search::compare_search_syms): Update.
2017 (treg_matches_sym_type_name): Update.
2018 (search_symbols): Update.
2019 (print_symbol_info): Update.
2020 (rbreak_command): Update.
2021 (completion_list_add_symbol): Update.
2022 (find_gnu_ifunc): Update.
2023 (get_symbol_address): Update.
2024 (search_module_symbols): Update.
2025 (info_module_subcommand): Update.
2026 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
2027 (SYMBOL_LINKAGE_NAME): Remove.
2028 (SYMBOL_DEMANGLED_NAME): Remove.
2029 (SYMBOL_PRINT_NAME): Remove.
2030 (SYMBOL_SEARCH_NAME): Remove.
2031 * tracepoint.c (set_traceframe_context): Update.
2032 (validate_actionline): Update.
2033 (collection_list::collect_symbol): Update.
2034 (encode_actions_1): Update.
2035 (info_scope_command): Update.
2036 (print_one_static_tracepoint_marker): Update.
2037 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
2038 * valops.c (address_of_variable): Update.
2039 (find_overload_match): Update.
2040 (find_oload_champ): Update.
2041
2042 2019-11-22 Christian Biesinger <cbiesinger@google.com>
2043
2044 * ada-lang.c (ada_lookup_simple_minsym): Update.
2045 (ada_collect_symbol_completion_matches): Update.
2046 * ada-tasks.c (read_atcb): Update.
2047 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
2048 (amd64_windows_skip_trampoline_code): Update.
2049 * arm-tdep.c (skip_prologue_function): Update.
2050 (arm_skip_stack_protector): Update.
2051 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
2052 (arm_wince_skip_main_prologue): Update.
2053 * ax-gdb.c (gen_expr): Update.
2054 * block.c (call_site_for_pc): Update.
2055 * blockframe.c (find_pc_partial_function): Update.
2056 * breakpoint.c (set_breakpoint_location_function): Update.
2057 * btrace.c (ftrace_print_function_name): Update.
2058 (ftrace_function_switched): Update.
2059 * c-valprint.c (print_unpacked_pointer): Update.
2060 * coffread.c (coff_symfile_read): Update.
2061 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
2062 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
2063 * dwarf-index-write.c (write_psymbols): Update.
2064 * dwarf2loc.c (call_site_to_target_addr): Update.
2065 (func_verify_no_selftailcall): Update.
2066 (tailcall_dump): Update.
2067 (call_site_find_chain_1): Update.
2068 (dwarf_expr_reg_to_entry_parameter): Update.
2069 * elfread.c (elf_gnu_ifunc_record_cache): Update.
2070 * eval.c (evaluate_funcall): Update.
2071 (evaluate_subexp_standard): Update.
2072 (evaluate_subexp_for_sizeof): Update.
2073 * expprint.c (print_subexp_standard): Update.
2074 (dump_subexp_body_standard): Update.
2075 * frame.c (get_prev_frame_always_1): Update.
2076 * frv-tdep.c (frv_skip_main_prologue): Update.
2077 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
2078 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
2079 (gnuv3_get_typename_from_type_info): Update.
2080 (gnuv3_skip_trampoline): Update.
2081 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
2082 * i386-tdep.c (i386_skip_main_prologue): Update.
2083 (i386_pe_skip_trampoline_code): Update.
2084 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
2085 * infcall.c (get_function_name): Update.
2086 * linespec.c (minsym_found): Update.
2087 * linux-fork.c (info_checkpoints_command): Update.
2088 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
2089 (m32c_m16c_pointer_to_address): Update.
2090 * maint.c (maintenance_translate_address): Update.
2091 * minsyms.c (add_minsym_to_hash_table): Update.
2092 (add_minsym_to_demangled_hash_table): Update.
2093 (lookup_minimal_symbol_mangled): Update.
2094 (lookup_minimal_symbol_demangled): Update.
2095 (lookup_minimal_symbol_linkage): Update.
2096 (lookup_minimal_symbol_text): Update.
2097 (lookup_minimal_symbol_by_pc_name): Update.
2098 (minimal_symbol_is_less_than): Update.
2099 (compact_minimal_symbols): Update.
2100 (build_minimal_symbol_hash_tables): Update.
2101 (find_solib_trampoline_target): Update.
2102 * mips-tdep.c (mips_stub_frame_sniffer): Update.
2103 (mips_skip_pic_trampoline_code): Update.
2104 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
2105 * objc-lang.c (info_selectors_command): Update.
2106 (info_classes_command): Update.
2107 (find_methods): Update.
2108 (find_imps): Update.
2109 * p-valprint.c (pascal_val_print): Update.
2110 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
2111 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
2112 * printcmd.c (build_address_symbolic): Update.
2113 (info_symbol_command): Update.
2114 * psymtab.c (psymbol_name_matches): Update.
2115 (match_partial_symbol): Update.
2116 (lookup_partial_symbol): Update.
2117 (print_partial_symbols): Update.
2118 (sort_pst_symbols): Update.
2119 (maintenance_check_psymtabs): Update.
2120 * python/py-framefilter.c (py_print_frame): Update.
2121 * python/python.c (gdbpy_rbreak): Update.
2122 * record-btrace.c (btrace_get_bfun_name): Update.
2123 (btrace_call_history): Update.
2124 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
2125 (rs6000_skip_trampoline_code): Update.
2126 * sol-thread.c (info_cb): Update.
2127 * stabsread.c (scan_file_globals): Update.
2128 * stack.c (find_frame_funname): Update.
2129 (info_frame_command_core): Update.
2130 * symmisc.c (dump_msymbols): Update.
2131 * symtab.c (symbol_natural_name): Rename to..,
2132 (general_symbol_info::natural_name): ...this.
2133 (symbol_demangled_name): Rename to...
2134 (general_symbol_info::demangled_name): ...this.
2135 (symbol_search_name): Rename to...
2136 (general_symbol_info::search_name): ...this.
2137 (symbol_matches_search_name): Update.
2138 (find_pc_sect_line): Update.
2139 (skip_prologue_sal): Update.
2140 (search_symbols): Update.
2141 (print_msymbol_info): Update.
2142 (rbreak_command): Update.
2143 (completion_list_add_msymbol): Update.
2144 (completion_list_objc_symbol): Update.
2145 (get_msymbol_address): Update.
2146 * symtab.h (struct general_symbol_info): Add member functions
2147 natural_name (), linkage_name (), print_name (), demangled_name (),
2148 and search_name ().
2149 (SYMBOL_NATURAL_NAME): Update.
2150 (symbol_natural_name): Move to a member function on general_symbol_info.
2151 (SYMBOL_DEMANGLED_NAME): Update.
2152 (symbol_demangled_name): Move to a member function on
2153 general_symbol_info.
2154 (SYMBOL_SEARCH_NAME): Update.
2155 (symbol_search_name): Move to a member function on general_symbol_info.
2156 (MSYMBOL_NATURAL_NAME): Remove.
2157 (MSYMBOL_LINKAGE_NAME): Remove.
2158 (MSYMBOL_PRINT_NAME): Remove.
2159 (MSYMBOL_DEMANGLED_NAME): Remove.
2160 (MSYMBOL_SEARCH_NAME): Remove.
2161 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2162
2163 2019-11-22 Christian Biesinger <cbiesinger@google.com>
2164
2165 * symtab.c (create_demangled_names_hash): Use per_bfd->
2166 minimal_symbol_count for computing the initial size, if greater
2167 than our default size.
2168
2169 2019-11-22 Tom de Vries <tdevries@suse.de>
2170
2171 * contrib/words.sh: Improve words extraction.
2172
2173 2019-11-22 Tom de Vries <tdevries@suse.de>
2174
2175 * contrib/words.sh: Combine sed invocations.
2176
2177 2019-11-21 Christian Biesinger <cbiesinger@google.com>
2178
2179 * Makefile.in: Update.
2180 * demangle.c: Rename to...
2181 * gdb-demangle.c: ..this.
2182 (is_cplus_marker): Change return type to bool.
2183 (_initialize_demangler): Rename to...
2184 (_initialize_gdb_demangle): ...this.
2185 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2186 * symtab.h (demangle): Remove declaration; instead include
2187 gdb-demangle.h.
2188
2189 2019-11-21 Tom Tromey <tromey@adacore.com>
2190
2191 * gdbsupport/format.c (format_pieces): Parse %I64d.
2192 * unittests/format_pieces-selftests.c (test_windows_formats): New
2193 function.
2194 (run_tests): Call it.
2195
2196 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
2197
2198 Byte reverse display of variables with DW_END_big, DW_END_little
2199 (DW_AT_endianity) dwarf attributes if different than the native
2200 byte order.
2201 * ada-lang.c (ada_value_binop):
2202 Use type_byte_order instead of gdbarch_byte_order.
2203 * ada-valprint.c (printstr):
2204 (ada_val_print_string):
2205 * ada-lang.c (value_pointer):
2206 (ada_value_binop):
2207 Use type_byte_order instead of gdbarch_byte_order.
2208 * c-lang.c (c_get_string):
2209 Use type_byte_order instead of gdbarch_byte_order.
2210 * c-valprint.c (c_val_print_array):
2211 Use type_byte_order instead of gdbarch_byte_order.
2212 * cp-valprint.c (cp_print_class_member):
2213 Use type_byte_order instead of gdbarch_byte_order.
2214 * dwarf2loc.c (rw_pieced_value):
2215 Use type_byte_order instead of gdbarch_byte_order.
2216 * dwarf2read.c (read_base_type): Handle DW_END_big,
2217 DW_END_little
2218 * f-lang.c (f_get_encoding):
2219 Use type_byte_order instead of gdbarch_byte_order.
2220 * findvar.c (default_read_var_value):
2221 Use type_byte_order instead of gdbarch_byte_order.
2222 * gdbtypes.c (check_types_equal):
2223 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2224 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2225 and TYPE_ENDIANITY_LITTLE if set.
2226 (type_byte_order): new function.
2227 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2228 (struct main_type) <flag_endianity_not_default>:
2229 New field.
2230 (type_byte_order): New function.
2231 * infcmd.c (default_print_one_register_info):
2232 Use type_byte_order instead of gdbarch_byte_order.
2233 * p-lang.c (pascal_printstr):
2234 Use type_byte_order instead of gdbarch_byte_order.
2235 * p-valprint.c (pascal_val_print):
2236 Use type_byte_order instead of gdbarch_byte_order.
2237 * printcmd.c (print_scalar_formatted):
2238 Use type_byte_order instead of gdbarch_byte_order.
2239 * solib-darwin.c (darwin_current_sos):
2240 Use type_byte_order instead of gdbarch_byte_order.
2241 * solib-svr4.c (solib_svr4_r_ldsomap):
2242 Use type_byte_order instead of gdbarch_byte_order.
2243 * stap-probe.c (stap_modify_semaphore):
2244 Use type_byte_order instead of gdbarch_byte_order.
2245 * target-float.c (target_float_same_format_p):
2246 Use type_byte_order instead of gdbarch_byte_order.
2247 * valarith.c (scalar_binop):
2248 (value_bit_index):
2249 Use type_byte_order instead of gdbarch_byte_order.
2250 * valops.c (value_cast):
2251 Use type_byte_order instead of gdbarch_byte_order.
2252 * valprint.c (generic_emit_char):
2253 (generic_printstr):
2254 (val_print_string):
2255 Use type_byte_order instead of gdbarch_byte_order.
2256 * value.c (unpack_long):
2257 (unpack_bits_as_long):
2258 (unpack_value_bitfield):
2259 (modify_field):
2260 (pack_long):
2261 (pack_unsigned_long):
2262 Use type_byte_order instead of gdbarch_byte_order.
2263 * findvar.c (unsigned_pointer_to_address):
2264 (signed_pointer_to_address):
2265 (unsigned_address_to_pointer):
2266 (address_to_signed_pointer):
2267 (default_read_var_value):
2268 (default_value_from_register):
2269 Use type_byte_order instead of gdbarch_byte_order.
2270 * gnu-v3-abi.c (gnuv3_make_method_ptr):
2271 Use type_byte_order instead of gdbarch_byte_order.
2272 * riscv-tdep.c (riscv_print_one_register_info):
2273 Use type_byte_order instead of gdbarch_byte_order.
2274
2275 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
2276
2277 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2278 (current_ui_gdb_stdin_ptr): Likewise.
2279 (current_ui_gdb_stderr_ptr): Likewise.
2280 (current_ui_gdb_stdlog_ptr): Likewise.
2281 (current_ui_current_uiout_ptr): Likewise.
2282 (gen_ret_current_ui_field_ptr): Remove.
2283
2284 2019-11-21 Tom de Vries <tdevries@suse.de>
2285
2286 PR gdb/24956
2287 * cli/cli-script.c (execute_control_command): Only switch to
2288 INTERP_CONSOLE's ui_out when INTERP_MI is active.
2289
2290 2019-11-19 Tom Tromey <tom@tromey.com>
2291
2292 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2293 Now static. Change type of "name".
2294 (tui_set_win_height_command): Don't copy "arg".
2295 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2296 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2297
2298 2019-11-19 Ali Tamur <tamur@google.com>
2299
2300 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2301 "if (attr != nullptr)".
2302 (dwarf2_find_base_address): Likewise.
2303 (dwarf2_build_include_psymtabs): Likewise.
2304 (read_cutu_die_from_dwo): Likewise.
2305 (read_func_scope): Likewise.
2306 (read_call_site_scope): Likewise.
2307 (dwarf2_get_pc_bounds): Likewise.
2308 (dwarf2_record_block_ranges): Likewise.
2309 (dwarf2_add_field): Likewise.
2310 (dwarf2_add_member_fn): Likewise.
2311 (read_structure_type): Likewise.
2312 (read_enumeration_type): Likewise.
2313 (read_array_type): Likewise.
2314 (read_array_order): Likewise.
2315 (read_set_type): Likewise.
2316 (read_common_block): Likewise.
2317 (read_tag_reference_type): Likewise.
2318 (read_tag_string_type): Likewise.
2319 (read_subroutine_type): Likewise.
2320 (read_base_type): Likewise.
2321 (read_subrange_type): Likewise.
2322 (new_symbol): Likewise.
2323 (prepare_one_comp_unit): Likewise.
2324
2325 2019-11-19 Tom Tromey <tromey@adacore.com>
2326
2327 * windows-nat.c (windows_nat_target::attach): Include GetLastError
2328 result in error when DebugActiveProcess fails.
2329
2330 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
2331 Pedro Alves <palves@redhat.com>
2332
2333 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2334 * target.c (target_stack::push): Call 'unpush' if there's a
2335 target on top of the stack.
2336
2337 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2338
2339 * python/py-block.c (blpy_dealloc): Call tp_free.
2340 (blpy_block_syms_dealloc): Likewise.
2341 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2342 * python/py-inferior.c (infpy_dealloc): Likewise.
2343 * python/py-lazy-string.c (stpy_dealloc): Likewise.
2344 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2345 * python/py-symbol.c (sympy_dealloc): Likewise.
2346 * python/py-symtab.c (stpy_dealloc): Likewise.
2347 * python/py-type.c (typy_iterator_dealloc): Likewise.
2348
2349 2019-11-18 Christian Biesinger <cbiesinger@google.com>
2350
2351 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2352 constructor instead of using a class initializer.
2353
2354 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2355
2356 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2357 * configure: Regenerate.
2358 * configure.ac: Don't source common.host.
2359 * gdbsupport/common.host: Remove.
2360 * gdbsupport/mingw-strerror.c: Remove.
2361 * gdbsupport/posix-strerror.c: Rename to...
2362 * gdbsupport/safe-strerror.c: ...this.
2363
2364 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2365
2366 * maint.c (scoped_command_stats::print_time): Use localtime_r
2367 instead of localtime (provided through gnulib if necessary).
2368 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2369 of ctime.
2370
2371 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2372
2373 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2374 avoid compile errors.
2375
2376 2019-11-15 Christian Biesinger <cbiesinger@google.com>
2377
2378 * config.in: Regenerate.
2379 * configure: Regenerate.
2380 * gdbsupport/common.m4: No longer check for strerror_r.
2381 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2382 POSIX version of strerror_r, now that gnulib provides it if
2383 necessary.
2384
2385 2019-11-14 Christian Biesinger <cbiesinger@google.com>
2386
2387 * README (`configure' options): Update.
2388
2389 2019-11-14 Tom Tromey <tromey@adacore.com>
2390
2391 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2392 expected type for the RHS if the LHS is a convenience variable.
2393
2394 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
2395
2396 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2397 Provide explicit default and copy constructor.
2398
2399 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2400
2401 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2402 only call Py_INCREF (newbp) in the bppy_pending_object case.
2403
2404 2019-11-13 Tom Tromey <tromey@adacore.com>
2405
2406 PR build/25182:
2407 * psympriv.h (partial_symbol): Remove static assert.
2408 * symtab.h (general_symbol_info, symbol): Remove static assert.
2409
2410 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
2411
2412 * gdbsupport/format.c (format_pieces::format_pieces): Support
2413 printf 'z' size modifier.
2414 * gdbsupport/format.h (enum argclass): Add size_t_arg.
2415 * printcmd.c (ui_printf): Handle size_t_arg.
2416 * ui-out.c (ui_out::vmessage): Likewise.
2417 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2418 function.
2419 (run_tests): Call test_format_int_sizes.
2420
2421 2019-11-12 Christian Biesinger <cbiesinger@google.com>
2422
2423 * ada-exp.y (write_ambiguous_var): Update.
2424 * buildsym.c (add_symbol_to_list): Update.
2425 * dwarf2read.c (read_variable): Update.
2426 (new_symbol): Update.
2427 * jit.c (finalize_symtab): Update.
2428 * language.c (language_alloc_type_symbol): Update.
2429 * symtab.c (fixup_symbol_section): Update.
2430 (initialize_objfile_symbol_1): Move code to...
2431 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2432 (allocate_symbol): Update.
2433 (allocate_template_symbol): Update.
2434 (get_symbol_address): Update.
2435 * symtab.h (struct symbol): Inherit from general_symbol_info instead
2436 of having as a field, and add a constructor.
2437 (SYMBOL_VALUE): Update.
2438 (SYMBOL_VALUE_ADDRESS): Update.
2439 (SET_SYMBOL_VALUE_ADDRESS): Update.
2440 (SYMBOL_VALUE_BYTES): Update.
2441 (SYMBOL_VALUE_COMMON_BLOCK): Update.
2442 (SYMBOL_BLOCK_VALUE): Update.
2443 (SYMBOL_VALUE_CHAIN): Update.
2444 (SYMBOL_LANGUAGE): Update.
2445 (SYMBOL_SECTION): Update.
2446 (SYMBOL_OBJ_SECTION): Update.
2447 (SYMBOL_SET_LANGUAGE): Update.
2448 (SYMBOL_SET_LINKAGE_NAME): Update.
2449 (SYMBOL_SET_NAMES): Update.
2450 (SYMBOL_NATURAL_NAME): Update.
2451 (SYMBOL_LINKAGE_NAME): Update.
2452 (SYMBOL_DEMANGLED_NAME): Update.
2453 (SYMBOL_SEARCH_NAME): Update.
2454 (SYMBOL_MATCHES_SEARCH_NAME): Update.
2455 (struct symbol): Update.
2456 (struct template_symbol): Update.
2457 (struct rust_vtable_symbol): Update.
2458 * xcoffread.c (SYMBOL_DUP): Update.
2459
2460 2019-11-12 Tom Tromey <tom@tromey.com>
2461
2462 * tui/tui-layout.c (show_layout): Set current_layout.
2463 (show_source_disasm_command, show_data)
2464 (show_source_or_disasm_and_command): Don't set current_layout.
2465
2466 2019-11-12 Tom Tromey <tom@tromey.com>
2467
2468 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2469
2470 2019-11-12 Tom Tromey <tom@tromey.com>
2471
2472 * tui/tui-win.c (resize_message): New global.
2473 (show_tui_resize_message): New function.
2474 (tui_async_resize_screen): Print message if requested.
2475 (_initialize_tui_win): Add tui-resize-message setting.
2476 * NEWS: Add entry for new commands.
2477
2478 2019-11-11 Tom Tromey <tom@tromey.com>
2479
2480 * tui/tui.c (tui_initialize_readline): Add new bindable readline
2481 functions.
2482
2483 2019-11-11 Christian Biesinger <cbiesinger@google.com>
2484
2485 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2486
2487 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2488
2489 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2490 function.
2491 * python/python-internal.h (gdbpy_lookup_static_symbols):
2492 Declare new function.
2493 * python/python.c (python_GdbMethods): Add
2494 gdb.lookup_static_symbols method.
2495 * NEWS: Mention gdb.lookup_static_symbols.
2496
2497 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2498
2499 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2500 static block of current object file first. Also fix typo in
2501 header comment.
2502
2503 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2504
2505 * stack.c (set_last_displayed_sal): Delete.
2506 (last_displayed_sal_valid): Delete.
2507 (last_displayed_pspace): Delete.
2508 (last_displayed_addr): Delete.
2509 (last_displayed_symtab): Delete.
2510 (last_displayed_line): Delete.
2511 (class last_displayed_symtab_info_type): New.
2512 (last_displayed_symtab_info): New static global variable.
2513 (print_frame_info): Call methods on last_displayed_symtab_info.
2514 (clear_last_displayed_sal): Update header comment, and make use of
2515 last_displayed_symtab_info.
2516 (last_displayed_sal_is_valid): Likewise.
2517 (get_last_displayed_pspace): Likewise.
2518 (get_last_displayed_addr): Likewise.
2519 (get_last_displayed_symtab): Likewise.
2520 (get_last_displayed_line): Likewise.
2521 (get_last_displayed_sal): Likewise.
2522 * stack.h (clear_last_displayed_sal): Update header comment.
2523 (last_displayed_sal_is_valid): Likewise.
2524 (get_last_displayed_pspace): Likewise.
2525 (get_last_displayed_addr): Likewise.
2526 (get_last_displayed_symtab): Likewise.
2527 (get_last_displayed_line): Likewise.
2528 (get_last_displayed_sal): Likewise.
2529
2530 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2531
2532 * stack.c (frame_show_address): Convert return type to bool.
2533 * stack.h (frame_show_address): Likewise, and update header
2534 comment.
2535
2536 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
2537
2538 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2539 * unittests/vec-utils-selftests.c: New file.
2540 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2541
2542 2019-11-10 Tom Tromey <tom@tromey.com>
2543
2544 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2545 (tui_highlight_win): Likewise.
2546 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2547 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2548 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2549 Don't set can_highlight.
2550
2551 2019-11-10 Tom Tromey <tom@tromey.com>
2552
2553 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2554 Remove unused declaration.
2555
2556 2019-11-08 Tom Tromey <tromey@adacore.com>
2557
2558 * top.c (read_command_file): Update.
2559 (command_line_input): Make return type const.
2560 * python/py-gdb-readline.c: Update.
2561 * linespec.c (decode_line_2): Update.
2562 * defs.h (command_line_input): Make return type const.
2563 * cli/cli-script.c (read_next_line): Make return type const.
2564 * ada-lang.c (get_selections): Update.
2565
2566 2019-11-06 Christian Biesinger <cbiesinger@google.com>
2567
2568 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2569 * mi/mi-main.c (output_cores): Likewise.
2570 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2571 (linux_xfer_osdata_modules): Likewise.
2572 * remote.c (register_remote_support_xml): Likewise.
2573 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2574 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2575
2576 2019-11-06 Tom Tromey <tom@tromey.com>
2577
2578 * tui/tui-interp.c: Don't include readline.h.
2579 * tui/tui-hooks.c: Don't include readline.h.
2580 * symmisc.c: Include tilde.h, not readline.h.
2581 * symfile.c: Include tilde.h, not readline.h.
2582 * source.c: Include tilde.h, not readline.h.
2583 * solib.c: Include tilde.h, not readline.h.
2584 * psymtab.c: Include tilde.h, not readline.h.
2585 * exec.c: Include tilde.h, not readline.h.
2586 * corelow.c: Include tilde.h, not readline.h.
2587 * cli/cli-dump.c: Include tilde.h, not readline.h.
2588 * cli/cli-cmds.c: Don't include readline.h.
2589
2590 2019-11-05 Tom Tromey <tom@tromey.com>
2591
2592 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2593 (tui_disassemble): Set addr_size.
2594 (tui_disasm_window::set_contents): Use addr_size.
2595
2596 2019-11-05 Tom Tromey <tom@tromey.com>
2597
2598 * rust-lang.c (rust_language_defn): Update.
2599 * python/py-value.c (valpy_string): Call c_get_string.
2600 * p-lang.c (pascal_language_defn): Update.
2601 * opencl-lang.c (opencl_language_defn): Update.
2602 * objc-lang.c (objc_language_defn): Update.
2603 * m2-lang.c (m2_language_defn): Update.
2604 * language.c (unknown_language_defn, auto_language_defn): Update.
2605 (default_get_string): Remove.
2606 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2607 * go-lang.c (go_language_defn): Update.
2608 * f-lang.c (f_language_defn): Update.
2609 * d-lang.c (d_language_defn): Update.
2610 * c-lang.c (c_language_defn, cplus_language_defn)
2611 (asm_language_defn, minimal_language_defn): Update.
2612 * ada-lang.c (ada_language_defn): Update.
2613 * language.h (struct language_defn) <la_get_string>: Remove.
2614 (LA_GET_STRING): Remove.
2615 (default_get_string): Don't declare.
2616
2617 2019-11-05 Tom Tromey <tom@tromey.com>
2618
2619 * tui/tui-source.h (struct tui_source_window): Inline
2620 constructor. Remove destructor.
2621 <style_changed, m_observable>: Move to superclass.
2622 * tui/tui-winsource.h (tui_copy_source_line): Declare.
2623 (struct tui_source_window_base): Move private members to end.
2624 <style_changed, m_observable>: Move from tui_source_window.
2625 * tui/tui-winsource.c (tui_copy_source_line): Move from
2626 tui-source.c. Rename from copy_source_line. Add special handling
2627 for negative line number.
2628 (tui_source_window_base::style_changed): Move from
2629 tui_source_window.
2630 (tui_source_window_base): Register observer.
2631 (~tui_source_window_base): New.
2632 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2633 rename.
2634 (tui_source_window::set_contents): Use tui_copy_source_line.
2635 (tui_source_window::tui_source_window): Move to tui-source.h.
2636 (tui_source_window::~tui_source_window): Remove.
2637 (tui_source_window::style_changed): Move to superclass.
2638 * tui/tui-disasm.c (tui_disassemble): Create string file with
2639 styling, when possible. Add "addr_size" parameter.
2640 (tui_disasm_window::set_contents): Use tui_copy_source_line.
2641 Don't compute maximum size.
2642 (len_without_escapes): New function
2643
2644 2019-11-05 Tom Tromey <tom@tromey.com>
2645
2646 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2647 std::string.
2648 * tui/tui-winsource.c (tui_show_source_line): Update.
2649 * tui/tui-source.c (tui_source_window::set_contents): Update.
2650 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2651
2652 2019-11-05 Christian Biesinger <cbiesinger@google.com>
2653
2654 * symtab.h (gdb_static_assert): Put && operator at the beginning
2655 of the line instead of the end.
2656
2657 2019-11-04 Christian Biesinger <cbiesinger@google.com>
2658
2659 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2660 and sizeof (symbol).
2661 * symtab.h: Add a static_assert for sizeof (partial_symbol).
2662
2663 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
2664
2665 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2666 * configure.host: Mark *-*-solaris2.10* obsolete.
2667 * configure.tgt: Mark Solaris < 11 obsolete.
2668 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2669 Update target triplet.
2670
2671 2019-11-01 Tom Tromey <tromey@adacore.com>
2672
2673 * utils.c (print_sys_errmsg): Simplify.
2674
2675 2019-11-01 Tom Tromey <tromey@adacore.com>
2676
2677 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2678
2679 2019-11-01 Christian Biesinger <cbiesinger@google.com>
2680
2681 * configure: Regenerate.
2682 * configure.ac: Remove check for strerror_r.
2683 * gdbsupport/common.m4: Check for strerror_r.
2684
2685 2019-11-01 Luis Machado <luis.machado@linaro.org>
2686
2687 PR gdb/25124
2688
2689 * arm-tdep.c (arm_per_objfile): Rename to ...
2690 (arm_per_bfd): ... this.
2691 (arm_objfile_data_key): Rename to ...
2692 (arm_bfd_data_key): ... this.
2693 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2694 data.
2695 (arm_record_special_symbol): Likewise.
2696
2697 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2698
2699 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2700 end.
2701 * c-typeprint.c (c_print_typedef): Likewise.
2702 * f-typeprint.c (f_print_typedef): Likewise.
2703 * m2-typeprint.c (m2_print_typedef): Likewise.
2704 * p-typeprint.c (pascal_print_typedef): Likewise.
2705 * rust-lang.c (rust_print_typedef): Likewise.
2706 * symtab.c (print_symbol_info): Print a newline after calling
2707 typedef_print.
2708
2709 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2710
2711 * symtab.c (info_module_cmdlist): New variable.
2712 (info_module_command): New function.
2713 (search_module_symbols): New function.
2714 (info_module_subcommand): New function.
2715 (struct info_modules_var_func_options): New struct.
2716 (info_modules_var_func_options_defs): New variable.
2717 (make_info_modules_var_func_options_def_group): New function.
2718 (info_module_functions_command): New function.
2719 (info_module_variables_command): New function.
2720 (info_module_var_func_command_completer): New function.
2721 (_initialize_symtab): Register new 'info module functions' and
2722 'info module variables' commands.
2723 * symtab.h (typedef symbol_search_in_module): New typedef.
2724 (search_module_symbols): Declare new function.
2725 * NEWS: Mention new commands.
2726
2727 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
2728
2729 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2730 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2731 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2732 MODULES_DOMAIN.
2733 (scan_partial_symbols): Only create partial module symbols for non
2734 declarations.
2735 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2736 and MODULES_DOMAIN.
2737 * symtab.c (search_domain_name): Likewise.
2738 (search_symbols): Likewise.
2739 (print_symbol_info): Likewise.
2740 (symtab_symbol_info): Likewise.
2741 (info_modules_command): New function.
2742 (_initialize_symtab): Register 'info modules' command.
2743 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2744 * NEWS: Mention new 'info modules' command.
2745
2746 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2747
2748 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2749 and $_gdb_maint_setting_str.
2750
2751 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
2752
2753 * cli/cli-cmds.c (setting_cmd, value_from_setting)
2754 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2755 (str_value_from_setting, gdb_setting_str_internal_fn)
2756 (gdb_maint_setting_str_internal_fn): New functions.
2757 (_initialize_cli_cmds): Define the new convenience functions.
2758 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2759 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2760
2761 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2762
2763 * agent.c (set_can_use_agent): When the setting is turned on,
2764 look up agent symbols if we don't have them yet.
2765 (agent_new_objfile): Don't look up agent symbols when the agent
2766 setting is off.
2767
2768 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2769
2770 * config.in: Regenerate.
2771
2772 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2773
2774 * configure: Regenerate.
2775 * configure.ac: Check for strerror_r.
2776 * gdbsupport/common-utils.h (safe_strerror): Change return value
2777 to const char * and document that this function is now threadsafe.
2778 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2779 thread_local and call strerror_r, if available.
2780 * utils.c (perror_string): Update.
2781 (print_sys_errmsg): Update.
2782
2783 2019-10-31 Luis Machado <luis.machado@linaro.org>
2784
2785 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2786 objfile_key.
2787 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2788 objfile to fetch per-bfd data.
2789 (arm_find_exidx_entry): Likewise.
2790
2791 2019-10-31 Christian Biesinger <cbiesinger@google.com>
2792
2793 * gdbsupport/agent.c (debug_agent): Change type to bool.
2794 (use_agent): Likewise.
2795 (all_agent_symbols_look_up): Likewise.
2796 (agent_loaded_p): Change return value to bool.
2797 (agent_look_up_symbols): Update.
2798 (agent_capability_check): Change return value to bool.
2799 * gdbsupport/agent.h (agent_loaded_p): Likewise.
2800 (debug_agent): Change type to bool.
2801 (use_agent): Likewise.
2802 (agent_capability_check): Change return value to bool.
2803
2804 2019-10-30 Christian Biesinger <cbiesinger@google.com>
2805
2806 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2807 (build_minimal_symbol_hash_tables): Code to clear the table moved
2808 to clear_minimal_symbol_hash_tables.
2809 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2810 when needed.
2811
2812 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2813
2814 * infcmd.c: Remove includes.
2815 * infrun.c: Remove includes.
2816
2817 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2818
2819 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2820 (grow_vect): Remove declaration.
2821 (ada_type_of_array): Remove declaration.
2822 (ada_update_initial_language): Remove declaration.
2823 (ada_fold_name): Remove declaration.
2824 (ada_fill_in_ada_prototype): Remove declaration.
2825 (user_select_syms): Remove declaration.
2826 (get_selections): Remove declaration.
2827 (ada_tag_type): Remove declaration.
2828 (ada_value_tag): Remove declaration.
2829 (ada_is_others_clause): Remove declaration.
2830 (ada_in_variant): Remove declaration.
2831 (ada_value_struct_elt): Remove declaration.
2832 (ada_attribute_name): Remove declaration.
2833 (ada_system_address_type): Remove declaration.
2834 * ada-lang.c (ada_watch_location_expression): Make static.
2835 (GROW_VECT): Move here from ada-lang.h.
2836 (grow_vect): Make static.
2837 (ada_update_initial_language): Make static.
2838 (ada_fold_name): Make static.
2839 (ada_type_of_array): Make static.
2840 (encoded_ordered_before): Move up.
2841 (sort_choices): Move up.
2842 (print_signatures): Move up.
2843 (ada_print_symbol_signature): Move up.
2844 (get_selections): Move up and make static.
2845 (user_select_syms): Move up and make static.
2846 (ada_value_struct_elt): Move up and make static.
2847 (ada_tag_type): Make static.
2848 (ada_value_tag): Make static.
2849 (ada_is_others_clause): Make static.
2850 (ada_in_variant): Make static.
2851 (ada_attribute_name): Make static.
2852
2853 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
2854
2855 * ada-lang.c: Remove includes.
2856 * ada-typeprint.c: Remove includes.
2857 * ada-valprint.c: Remove includes.
2858
2859 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
2860
2861 * addrmap.c: Add static assertions of type size, moved from
2862 _initialize_addrmap.
2863 (_initialize_addrmap): Remove.
2864
2865 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2866
2867 * coffread.c (record_minimal_symbol): Update.
2868 (process_coff_symbol): Update.
2869 * dbxread.c (read_dbx_symtab): Update.
2870 * dwarf2read.c (add_partial_symbol): Update.
2871 (fixup_go_packaging): Update.
2872 (load_partial_dies): Update.
2873 (new_symbol): Update.
2874 * elfread.c (record_minimal_symbol): Change signature to use
2875 gdb::string_view instead of name+len.
2876 (elf_symtab_read): Update.
2877 (elf_rel_plt_read): Update.
2878 * mdebugread.c (parse_partial_symbols): Update.
2879 (handle_psymbol_enumerators): Update.
2880 (new_symbol): Update.
2881 * minsyms.c (minimal_symbol_reader::record_full): Change signature
2882 to use gdb::string_view instead of name+len.
2883 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2884 * psympriv.h (add_psymbol_to_list): Likewise.
2885 * psymtab.c (add_psymbol_to_bcache): Likewise.
2886 (add_psymbol_to_list): Likewise.
2887 * stabsread.c (define_symbol): Update.
2888 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2889 * symtab.h (SYMBOL_SET_NAMES): Likewise.
2890 (symbol_set_names): Likewise.
2891 * xcoffread.c (scan_xcoff_symtab): Update.
2892
2893 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2894
2895 * symtab.h (symbol_set_names): Document that copy_name must be
2896 set to true for non-nullterminated strings.
2897 * symtab.c (symbol_set_names): Only make a nullterminated copy of
2898 linkage_name if the entry was not found and we need to demangle.
2899
2900 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2901
2902 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2903 * dwarf2-frame.c (bsearch_fde_cmp): Update.
2904 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2905 * gdbsupport/gdb_binary_search.h: New file.
2906
2907 2019-10-29 Christian Biesinger <cbiesinger@google.com>
2908
2909 * NEWS: Mention new --with-system-gdbinit-dir option.
2910 * config.in: Regenerate.
2911 * configure: Regenerate.
2912 * configure.ac: Add new option --with-system-gdbinit-dir.
2913 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2914 for a ".gdb" suffix.
2915 * main.c (get_init_files): Change system_gdbinit argument to
2916 a vector and return the files in SYSTEM_GDBINIT_DIR in
2917 addition to SYSTEM_GDBINIT.
2918 (captured_main_1): Update.
2919 (print_gdb_help): Update.
2920 * top.c (print_gdb_configuration): Also print the value of
2921 SYSTEM_GDBINIT_DIR.
2922
2923 2019-10-28 Christian Biesinger <cbiesinger@google.com>
2924
2925 * gdbsupport/common-utils.h (startswith): Add an overloaded version
2926 that takes gdb::string_view arguments.
2927
2928 2019-10-26 Tom de Vries <tdevries@suse.de>
2929
2930 * aarch64-linux-tdep.c: Fix typos in comments.
2931 * aarch64-tdep.c: Same.
2932 * ada-lang.c: Same.
2933 * amd64-nat.c: Same.
2934 * arc-tdep.c: Same.
2935 * arch/aarch64-insn.c: Same.
2936 * block.c: Same.
2937 * breakpoint.h: Same.
2938 * btrace.h: Same.
2939 * c-varobj.c: Same.
2940 * cli/cli-decode.c: Same.
2941 * cli/cli-script.c: Same.
2942 * cli/cli-utils.h: Same.
2943 * coff-pe-read.c: Same.
2944 * coffread.c: Same.
2945 * compile/compile-cplus-symbols.c: Same.
2946 * compile/compile-object-run.c: Same.
2947 * completer.c: Same.
2948 * corelow.c: Same.
2949 * cp-support.c: Same.
2950 * demangle.c: Same.
2951 * dwarf-index-write.c: Same.
2952 * dwarf2-frame.c: Same.
2953 * dwarf2-frame.h: Same.
2954 * eval.c: Same.
2955 * frame-base.h: Same.
2956 * frame.h: Same.
2957 * gdbcmd.h: Same.
2958 * gdbtypes.h: Same.
2959 * gnu-nat.c: Same.
2960 * guile/scm-objfile.c: Same.
2961 * i386-tdep.c: Same.
2962 * i386-tdep.h: Same.
2963 * infcall.c: Same.
2964 * infcall.h: Same.
2965 * linux-nat.c: Same.
2966 * m68k-tdep.c: Same.
2967 * macroexp.c: Same.
2968 * memattr.c: Same.
2969 * mi/mi-cmd-disas.c: Same.
2970 * mi/mi-getopt.h: Same.
2971 * mi/mi-main.c: Same.
2972 * minsyms.c: Same.
2973 * nat/aarch64-sve-linux-sigcontext.h: Same.
2974 * objfiles.h: Same.
2975 * ppc-linux-nat.c: Same.
2976 * ppc-linux-tdep.c: Same.
2977 * ppc-tdep.h: Same.
2978 * progspace.h: Same.
2979 * prologue-value.h: Same.
2980 * python/py-evtregistry.c: Same.
2981 * python/py-instruction.h: Same.
2982 * record-btrace.c: Same.
2983 * record-full.c: Same.
2984 * remote.c: Same.
2985 * rs6000-tdep.c: Same.
2986 * ser-tcp.c: Same.
2987 * sol-thread.c: Same.
2988 * sparc-sol2-tdep.c: Same.
2989 * sparc64-tdep.c: Same.
2990 * stabsread.c: Same.
2991 * symfile.c: Same.
2992 * symtab.h: Same.
2993 * target.c: Same.
2994 * tracepoint.c: Same.
2995 * tui/tui-data.h: Same.
2996 * tui/tui-io.c: Same.
2997 * tui/tui-win.c: Same.
2998 * tui/tui.c: Same.
2999 * unittests/rsp-low-selftests.c: Same.
3000 * user-regs.h: Same.
3001 * utils.c: Same.
3002 * utils.h: Same.
3003 * valarith.c: Same.
3004 * valops.c: Same.
3005 * valprint.c: Same.
3006 * valprint.h: Same.
3007 * value.c: Same.
3008 * value.h: Same.
3009 * varobj.c: Same.
3010 * x86-nat.h: Same.
3011 * xtensa-tdep.c: Same.
3012
3013 2019-10-25 Ali Tamur <tamur@google.com>
3014
3015 * charset.c (find_charset_names): Reflect API change.
3016
3017 2019-10-25 Christian Biesinger <cbiesinger@google.com>
3018
3019 * symtab.c (struct demangled_name_entry): Change demangled name
3020 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
3021 part of the struct anymore.
3022 (symbol_set_names): No longer obstack allocate + copy the demangled
3023 name, just store the allocated name from bfd.
3024
3025 2019-10-25 Tom Tromey <tromey@adacore.com>
3026
3027 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
3028 (bsearch_cie_cmp, add_cie): Remove.
3029 (find_cie): Reimplement.
3030 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
3031 (dwarf2_build_frame_info): Update.
3032
3033 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
3034
3035 PR gdb/25126
3036 * symfile.c (reread_symbols): Call forget_cached_source_info to
3037 clear the stale source cache.
3038
3039 2019-10-24 Christian Biesinger <cbiesinger@google.com>
3040
3041 * configure: Regenerate.
3042 * configure.ac: Remove code that sets python_has_threads.
3043
3044 2019-10-24 Christian Biesinger <cbiesinger@google.com>
3045
3046 * config.in: Regenerate.
3047 * configure: Regenerate.
3048 * configure.ac: Remove the code that uses sed to get the python
3049 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
3050
3051 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
3052
3053 * python/py-progspace.c (pspy_block_for_pc): Return None for all
3054 error paths.
3055
3056 2019-10-23 Tom Tromey <tom@tromey.com>
3057
3058 * arc-tdep.c: Remove ".." from include.
3059 * frv-tdep.c: Remove ".." from include.
3060 * lm32-tdep.c: Remove ".." from include.
3061 * microblaze-tdep.c: Remove ".." from include.
3062 * or1k-tdep.h: Remove ".." from include.
3063 * s12z-tdep.c: Remove ".." from include.
3064 * Makefile.in (OPCODES_CFLAGS): Add comment.
3065 (TOP_CFLAGS): New variable.
3066 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
3067
3068 2019-10-23 Tom Tromey <tom@tromey.com>
3069
3070 * Makefile.in (READLINE_DIR): Update.
3071
3072 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3073
3074 * infcall.c (call_function_by_hand_dummy): Fix the function
3075 comment. And extract out a code section into...
3076 (reserve_stack_space): ...this new function.
3077
3078 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3079
3080 * infcall.c (value_arg_coerce): Remove an unused parameter.
3081 (call_function_by_hand_dummy): Update the call to
3082 'value_arg_coerce'.
3083
3084 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3085
3086 * infcall.c (call_function_by_hand_dummy): Refactor.
3087
3088 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
3089
3090 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
3091
3092 2019-10-23 Tom Tromey <tom@tromey.com>
3093
3094 * configure: Rebuild.
3095 * configure.ac: Don't check for sigprocmask.
3096 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
3097
3098 2019-10-23 Tom Tromey <tom@tromey.com>
3099
3100 * configure: Rebuild.
3101 * acinclude.m4: Use m4_include, not sinclude.
3102
3103 2019-10-23 Tom de Vries <tdevries@suse.de>
3104
3105 PR breakpoints/24687
3106 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
3107
3108 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3109
3110 * symtab.c (struct demangled_name_entry) <language>: Change from
3111 bitfield to regular variable.
3112
3113 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3114
3115 * symtab.c (struct demangled_name_entry): Add a constructor.
3116 (free_demangled_name_entry): New function to call the destructor
3117 for demangled_name_entry.
3118 (create_demangled_names_hash): Pass free_demangled_name_entry to
3119 htab_create_alloc.
3120 (symbol_set_names): Call placement new for demangled_name_entry.
3121 * utils.c: No longer include xxhash.h here, now that fast_hash
3122 is inlined in the header.
3123 * utils.h: Instead, include it here.
3124
3125 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3126
3127 * Makefile.in: Link with libxxhash.
3128 * config.in: Regenerate.
3129 * configure: Regenerate.
3130 * configure.ac: Search for libxxhash.
3131 * utils.c (fast_hash): Use xxhash if present.
3132
3133 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3134
3135 * utils.h (fast_hash): New function.
3136 * symtab.c (hash_demangled_name_entry): Call new function
3137 fast_hash.
3138
3139 2019-10-22 Christian Biesinger <cbiesinger@google.com>
3140
3141 * symtab.c (struct demangled_name_entry): Change type of mangled
3142 to gdb::string_view. Also adds a constructor that takes the
3143 mangled name.
3144 (hash_demangled_name_entry): Update.
3145 (eq_demangled_name_entry): Update.
3146 (free_demangled_name_entry): New function to call the destructor
3147 now that this is not a POD anymore.
3148 (create_demangled_names_hash): Pass free_demangled_name_entry to
3149 htab_create_alloc.
3150 (symbol_set_names): Update.
3151
3152 2019-10-21 Ali Tamur <tamu@google.com>
3153
3154 * dwarf2read.c (dir_index): Change type.
3155 (file_name_index): Likewise.
3156 (line_header::include_dir_at): Change comment and implementation on
3157 whether it is DWARF 5.
3158 (line_header::is_valid_file_index): New function.
3159 (line_header::file_name_at): Change comment and implementation on
3160 whether it is DWARF 5.
3161 (line_header::file_names): Change to private field renamed as
3162 m_file_names and introduce a new accessor method.
3163 (line_header::file_names_size): New method.
3164 (line_header::include_dirs): Change to private field and rename as
3165 m_include_dirs.
3166 (dw2_get_file_names_reader): Define local var at a smaller scope and
3167 reflect API change.
3168 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3169 (process_structure_scope): Likewise.
3170 (line_header::add_include_dir): Change message and reflect renaming.
3171 (line_header::add_file_name): Likewise.
3172 (read_formatted_entries): Handle DW_FORM_data16.
3173 (dwarf_decode_line_header): Fix line header length calculation.
3174 (psymtab_include_file_name): Change comment and API.
3175 (lnp_state_machine::m_file): Update comment and reflect type change.
3176 (lnp_state_machine::record_line): Reflect type change.
3177 (dwarf_decode_lines): Reflect API change.
3178 (file_file_name): Likewise.
3179 (file_full_name): Likewise.
3180
3181 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
3182
3183 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3184
3185 2019-10-21 Tom Tromey <tom@tromey.com>
3186
3187 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3188
3189 2019-10-21 Tom Tromey <tom@tromey.com>
3190
3191 * configure.ac (nm.h): Conditionally create nm.h link. Subst
3192 NM_H. Use AC_CONFIG_LINKS.
3193 * configure: Rebuild.
3194 * Makefile.in (NM_H): New variable.
3195 (generated_files): Add NM_H. Remove gcore.
3196 (nm.h, stamp-nmh): New targets.
3197
3198 2019-10-20 Tom Tromey <tom@tromey.com>
3199
3200 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3201 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
3202 obsolete comment.
3203 (put_objfile_before): Now static.
3204
3205 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
3206
3207 * gdbsupport/common-utils.h (startswith): Change return type to
3208 bool.
3209
3210 2019-10-19 Christian Biesinger <cbiesinger@google.com>
3211
3212 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3213 * breakpoint.c (bp_locations_compare): Rename to...
3214 (bp_location_is_less_than): ...this, and change to std::sort semantics.
3215 (update_global_location_list): Use std::sort instead of qsort.
3216 * buildsym.c (compare_line_numbers): Rename to...
3217 (lte_is_less_than): ...this, and change to std::sort semantics.
3218 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3219 instead of qsort.
3220 * disasm.c (compare_lines): Rename to...
3221 (line_is_less_than): ...this, and change to std::sort semantics.
3222 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3223 of qsort.
3224 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3225 (fde_is_less_than): ...this, and change to std::sort semantics.
3226 (dwarf2_build_frame_info): Call std::sort instead of qsort.
3227 * mdebugread.c (compare_blocks):
3228 (block_is_less_than): ...this, and change to std::sort semantics.
3229 (sort_blocks): Call std::sort instead of qsort.
3230 * objfiles.c (qsort_cmp): Rename to...
3231 (sort_cmp): ...this, and change to std::sort semantics.
3232 (update_section_map): Call std::sort instead of qsort.
3233 * remote.c (compare_pnums): Remove.
3234 (map_regcache_remote_table): Call std::sort instead of qsort.
3235 * utils.c (compare_positive_ints): Remove.
3236 * utils.h (compare_positive_ints): Remove.
3237 * xcoffread.c (compare_lte): Remove.
3238 (arrange_linetable): Call std::sort instead of qsort.
3239
3240 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
3241
3242 * symfile.c (init_entry_point_info): Fix typo.
3243 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3244
3245 2019-10-18 Tom de Vries <tdevries@suse.de>
3246
3247 * aarch64-tdep.c: Fix typos in comments.
3248 * ada-lang.c: Same.
3249 * ada-tasks.c: Same.
3250 * alpha-tdep.c: Same.
3251 * alpha-tdep.h: Same.
3252 * amd64-nat.c: Same.
3253 * amd64-windows-tdep.c: Same.
3254 * arc-tdep.c: Same.
3255 * arc-tdep.h: Same.
3256 * arch-utils.c: Same.
3257 * arm-nbsd-tdep.c: Same.
3258 * arm-tdep.c: Same.
3259 * ax-gdb.c: Same.
3260 * blockframe.c: Same.
3261 * btrace.c: Same.
3262 * c-varobj.c: Same.
3263 * coff-pe-read.c: Same.
3264 * coffread.c: Same.
3265 * cris-tdep.c: Same.
3266 * darwin-nat.c: Same.
3267 * dbxread.c: Same.
3268 * dcache.c: Same.
3269 * disasm.c: Same.
3270 * dtrace-probe.c: Same.
3271 * dwarf-index-write.c: Same.
3272 * dwarf2-frame-tailcall.c: Same.
3273 * dwarf2-frame.c: Same.
3274 * dwarf2read.c: Same.
3275 * eval.c: Same.
3276 * exceptions.c: Same.
3277 * fbsd-tdep.c: Same.
3278 * findvar.c: Same.
3279 * frame.c: Same.
3280 * frv-tdep.c: Same.
3281 * gnu-v3-abi.c: Same.
3282 * go32-nat.c: Same.
3283 * h8300-tdep.c: Same.
3284 * hppa-tdep.c: Same.
3285 * i386-linux-tdep.c: Same.
3286 * i386-tdep.c: Same.
3287 * ia64-libunwind-tdep.c: Same.
3288 * ia64-tdep.c: Same.
3289 * infcmd.c: Same.
3290 * infrun.c: Same.
3291 * linespec.c: Same.
3292 * linux-nat.c: Same.
3293 * linux-thread-db.c: Same.
3294 * machoread.c: Same.
3295 * mdebugread.c: Same.
3296 * mep-tdep.c: Same.
3297 * mn10300-tdep.c: Same.
3298 * namespace.c: Same.
3299 * objfiles.c: Same.
3300 * opencl-lang.c: Same.
3301 * or1k-tdep.c: Same.
3302 * osabi.c: Same.
3303 * ppc-linux-nat.c: Same.
3304 * ppc-linux-tdep.c: Same.
3305 * ppc-sysv-tdep.c: Same.
3306 * printcmd.c: Same.
3307 * procfs.c: Same.
3308 * record-btrace.c: Same.
3309 * record-full.c: Same.
3310 * remote-fileio.c: Same.
3311 * remote.c: Same.
3312 * rs6000-tdep.c: Same.
3313 * s12z-tdep.c: Same.
3314 * score-tdep.c: Same.
3315 * ser-base.c: Same.
3316 * ser-go32.c: Same.
3317 * skip.c: Same.
3318 * sol-thread.c: Same.
3319 * solib-svr4.c: Same.
3320 * solib.c: Same.
3321 * source.c: Same.
3322 * sparc-nat.c: Same.
3323 * sparc-sol2-tdep.c: Same.
3324 * sparc-tdep.c: Same.
3325 * sparc64-tdep.c: Same.
3326 * stabsread.c: Same.
3327 * stack.c: Same.
3328 * symfile.c: Same.
3329 * symtab.c: Same.
3330 * target-descriptions.c: Same.
3331 * target-float.c: Same.
3332 * thread.c: Same.
3333 * utils.c: Same.
3334 * valops.c: Same.
3335 * valprint.c: Same.
3336 * value.c: Same.
3337 * varobj.c: Same.
3338 * windows-nat.c: Same.
3339 * xcoffread.c: Same.
3340 * xstormy16-tdep.c: Same.
3341 * xtensa-tdep.c: Same.
3342
3343 2019-10-17 Tom Tromey <tromey@adacore.com>
3344
3345 * configure: Rebuild.
3346 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
3347 in AC_CONFIG_FILES invocation.
3348 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3349 new-style config.status invocation.
3350
3351 2019-10-17 Tom de Vries <tdevries@suse.de>
3352
3353 * arm-nbsd-nat.c: Fix typos in comments.
3354 * arm-tdep.c: Same.
3355 * darwin-nat-info.c: Same.
3356 * dwarf2read.c: Same.
3357 * elfread.c: Same.
3358 * event-top.c: Same.
3359 * findvar.c: Same.
3360 * gdbtypes.c: Same.
3361 * hppa-tdep.c: Same.
3362 * i386-tdep.c: Same.
3363 * jit.c: Same.
3364 * main.c: Same.
3365 * mdebugread.c: Same.
3366 * moxie-tdep.c: Same.
3367 * nto-procfs.c: Same.
3368 * osabi.c: Same.
3369 * ppc-linux-tdep.c: Same.
3370 * remote.c: Same.
3371 * riscv-tdep.c: Same.
3372 * s390-tdep.c: Same.
3373 * sh-tdep.c: Same.
3374 * sparc-linux-tdep.c: Same.
3375 * sparc-nat.c: Same.
3376 * stack.c: Same.
3377 * target-descriptions.c: Same.
3378 * top.c: Same.
3379 * varobj.c: Same.
3380
3381 2019-10-16 Tom Tromey <tom@tromey.com>
3382
3383 * objfiles.h (struct objfile) <original_name>: Now const.
3384
3385 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3386
3387 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3388 pass on to sigsetjmp's second argument.
3389 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3390
3391 2019-10-16 Keith Seitz <keiths@redhat.com>
3392
3393 PR gdb/23567
3394 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3395 sections whose size is greater than the file size.
3396
3397 2019-10-16 Jim Wilson <jimw@sifive.com>
3398
3399 * riscv-tdep.c (riscv_gcc_target_options): New.
3400 (riscv_gnu_triplet_regexp): New.
3401 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3402 set_gdbarch_gnu_triplet_regexp.
3403
3404 2019-10-16 Christian Biesinger <cbiesinger@google.com>
3405
3406 * Makefile.in: Add xml-builtin.h.
3407 * features/feature_to_c.sh: Add an include for xml-builtin.h
3408 to ensure that the compiler checks that the types match.
3409 * xml-builtin.h: New file.
3410 * xml-support.c (fetch_xml_builtin): Add missing const.
3411 * xml-support.h: Remove declaration of xml_builtins.
3412
3413 2019-10-16 Tom de Vries <tdevries@suse.de>
3414
3415 PR tdep/25096
3416 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3417 (amd64_classify_aggregate): ... here.
3418 (amd64_classify_aggregate_field): Handled fiels of nested structs
3419 recursively.
3420
3421 2019-10-16 Tom de Vries <tdevries@suse.de>
3422
3423 PR tdep/24104
3424 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3425 that handles 'theclass'.
3426
3427 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3428
3429 * linespec.c (decode_digits_ordinary): Update comment.
3430 * make-target-delegates: No longer need to handle VEC case.
3431 * memrange.c (normalize_mem_ranges): Update comment.
3432 * namespace.c (add_using_directive): Update comment.
3433 * objc-lang.c (uniquify_strings): Update comment.
3434 * ppc-linux-nat.c (struct thread_points): Update comment.
3435 * probe.h (find_probes_in_objfile): Update comment.
3436 * target.h (enum flash_preserve_mode): Update comment.
3437 * varobj.c (varobj_restrict_range): Update comment.
3438 * varobj.h (varobj_list_children): Update comment.
3439
3440 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3441
3442 * Makefile.in: Remove references to vec.h and vec.c.
3443 * aarch64-tdep.c: No longer include vec.h.
3444 * ada-lang.c: Likewise.
3445 * ada-lang.h: Likewise.
3446 * arm-tdep.c: Likewise.
3447 * ax.h: Likewise.
3448 * breakpoint.h: Likewise.
3449 * charset.c: Likewise.
3450 * cp-support.h: Likewise.
3451 * dtrace-probe.c: Likewise.
3452 * dwarf2read.c: Likewise.
3453 * extension.h: Likewise.
3454 * gdb_bfd.c: Likewise.
3455 * gdbsupport/gdb_vecs.h: Likewise.
3456 * gdbsupport/vec.c: Remove.
3457 * gdbsupport/vec.h: Remove.
3458 * gdbthread.h: Likewise.
3459 * guile/scm-type.c: Likewise.
3460 * inline-frame.c: Likewise.
3461 * machoread.c: Likewise.
3462 * memattr.c: Likewise.
3463 * memrange.h: Likewise.
3464 * namespace.h: Likewise.
3465 * nat/linux-btrace.h: Likewise.
3466 * osdata.c: Likewise.
3467 * parser-defs.h: Likewise.
3468 * progspace.h: Likewise.
3469 * python/py-type.c: Likewise.
3470 * record-btrace.c: Likewise.
3471 * rust-exp.y: Likewise.
3472 * solib-target.c: Likewise.
3473 * stap-probe.c: Likewise.
3474 * target-descriptions.c: Likewise.
3475 * target-memory.c: Likewise.
3476 * target.h: Likewise.
3477 * varobj.c: Likewise.
3478 * varobj.h: Likewise.
3479 * xml-support.h: Likewise.
3480
3481 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
3482
3483 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3484 Update for new std::vector based implementation.
3485 (process_psymtab_comp_unit_reader): Likewise.
3486 (scan_partial_symbols): Likewise.
3487 (recursively_compute_inclusions): Likewise.
3488 (compute_compunit_symtab_includes): Likewise.
3489 (process_imported_unit_die): Likewise.
3490 (queue_and_load_dwo_tu): Likewise.
3491 (follow_die_sig_1): Likewise.
3492 * gdb/dwarf2read.h: Remove DEF_VEC_P.
3493 (typedef dwarf2_per_cu_ptr): Remove.
3494 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3495 function.
3496 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3497 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3498 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3499 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3500 std::vector.
3501
3502 2019-10-15 Tom Tromey <tromey@adacore.com>
3503
3504 * windows-nat.c (windows_nat_target::resume): Use %x when logging
3505 TID.
3506
3507 2019-10-15 Tom Tromey <tromey@adacore.com>
3508
3509 * windows-nat.c (windows_nat_target::fetch_registers)
3510 (windows_nat_target::store_registers): Rename "pid" to "tid".
3511
3512 2019-10-15 Tom Tromey <tromey@adacore.com>
3513
3514 * gdbarch.h, gdbarch.c: Rebuild.
3515 * gdbarch.sh (gcc_target_options): Change return type to
3516 std::string.
3517 * compile/compile.c (get_args): Update.
3518 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3519 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3520 std::string.
3521 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3522 std::string.
3523 * arch-utils.c (default_gcc_target_options): Return std::string.
3524 * arch-utils.h (default_gcc_target_options): Return std::string.
3525 * s390-tdep.c (s390_gcc_target_options): Return std::string.
3526
3527 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3528
3529 * breakpoint.c (breakpoint_chain): Make static.
3530 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3531 of accessing breakpoint_chain.
3532
3533 2019-10-15 Christian Biesinger <cbiesinger@google.com>
3534
3535 * breakpoint.c (iterate_over_breakpoints): Change function pointer
3536 to a gdb::function_view and return value to bool.
3537 * breakpoint.h (iterate_over_breakpoints): Likewise.
3538 * dummy-frame.c (pop_dummy_frame_bpt): Update.
3539 (pop_dummy_frame): Update.
3540 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3541 (gdbscm_breakpoints): Update.
3542 * python/py-breakpoint.c (build_bp_list): Update.
3543 (gdbpy_breakpoints): Update.
3544 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3545 Update.
3546 (bpfinishpy_handle_stop): Update.
3547 (bpfinishpy_handle_exit): Update.
3548 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3549 (svr4_update_solib_event_breakpoints): Update.
3550
3551 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
3552
3553 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3554 when unwrapping single-field structs.
3555
3556 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
3557
3558 * dwarf2read.c: Remove includes.
3559
3560 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
3561
3562 * ui-out.c (ui_out::call_do_message): Silence
3563 -Wformat-nonliteral warning.
3564
3565 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
3566
3567 * breakpoint.c: Remove some includes: continuations.h, skip.h,
3568 mi/mi-main.h, readline/readline.h, readline/history.h. Add
3569 include: readline/tilde.h.
3570
3571 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3572
3573 * remote.c (remote_target::get_trace_status): Remove declaration of
3574 trace_regblock_size.
3575
3576 2019-10-12 Christian Biesinger <cbiesinger@google.com>
3577
3578 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3579 (show_user): Remove declaration of cmdlist.
3580 * cli/cli-cmds.h (max_user_call_depth): Declare.
3581 * cli/cli-script.c (execute_user_command): Remove declaration
3582 of max_user_call_depth.
3583
3584 2019-10-11 Jim Wilson <jimw@sifive.com>
3585
3586 * gdbsupport/print-utils.h (pulongest): Fix comment.
3587 (plongest): Likewise.
3588 (phex): Add missing comment, mention leading zeros.
3589 (phex_nz): Add mention of no leading zeros to comment.
3590
3591 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3592 plongest instead of unsigned long long cast.
3593
3594 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3595
3596 * main.c (captured_main_1): Include gdbtk.h and remove declarations
3597 for external_editor_command and gdbtk_test.
3598
3599 2019-10-10 Christian Biesinger <cbiesinger@google.com>
3600
3601 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3602 * varobj.c (varobjdebug): Move comment to...
3603 * varobj.h (varobjdebug): ...here, and declare.
3604
3605 2019-10-09 Tom Tromey <tom@tromey.com>
3606
3607 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3608 erase_data_content.
3609
3610 2019-10-09 Tom Tromey <tom@tromey.com>
3611
3612 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3613 * tui/tui-stack.c (tui_locator_window::rerender): Update.
3614 * tui/tui-command.c (tui_cmd_window::resize)
3615 (tui_refresh_cmd_win): Update.
3616 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3617 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3618 * tui/tui-data.c (~tui_gen_win_info): Remove.
3619 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3620 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3621 (tui_redisplay_readline, tui_mld_flush)
3622 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3623 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3624 (tui_data_window::erase_data_content)
3625 (tui_data_item_window::rerender)
3626 (tui_data_item_window::refresh_window): Update.
3627 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3628 (box_win, tui_gen_win_info::make_window)
3629 (tui_gen_win_info::make_visible): Update.
3630 (tui_delete_win): Remove.
3631 * tui/tui-winsource.c
3632 (tui_source_window_base::do_erase_source_content): Update.
3633 (tui_show_source_line, tui_source_window_base::update_tab_width)
3634 (tui_source_window_base::update_exec_info): Update.
3635 * tui/tui-data.h (struct curses_deleter): New.
3636 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3637 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3638
3639 2019-10-09 Tom Tromey <tom@tromey.com>
3640
3641 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3642
3643 2019-10-09 Tom Tromey <tom@tromey.com>
3644
3645 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3646 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3647
3648 2019-10-09 Tom Tromey <tom@tromey.com>
3649
3650 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3651 window height directly.
3652 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3653 declare.
3654 * tui/tui-layout.c (tui_default_win_height): Remove.
3655 (tui_default_win_viewport_height): Remove.
3656
3657 2019-10-09 Tom Tromey <tom@tromey.com>
3658
3659 * tui/tui.h: Remove comments.
3660
3661 2019-10-09 Tom de Vries <tdevries@suse.de>
3662
3663 * python/lib/gdb/printer/bound_registers.py: Use
3664 '^builtin_type_bound128' as regexp argument for
3665 add_builtin_pretty_printer.
3666
3667 2019-10-09 Christian Biesinger <cbiesinger@google.com>
3668
3669 * guile/guile.c (guile_extension_script_ops): Remove forward
3670 declaration and mark as static.
3671 (guile_script_ops): Likewise.
3672 (extension_language_guile): Move further down in the file so
3673 it can reference the definitions for guile_{extension_,}script_ops.
3674
3675 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
3676
3677 * s390-tdep.c (390_process_record): Handle new arch13 instructions
3678 except SORTL, DFLTCC, and KDSA.
3679
3680 2019-10-08 Tom Tromey <tromey@adacore.com>
3681
3682 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3683 (struct safe_symbol_file_add_args): Remove.
3684
3685 2019-10-08 Tom Tromey <tromey@adacore.com>
3686
3687 * windows-nat.c: Don't include buildsym-legacy.h.
3688
3689 2019-10-08 Tom Tromey <tromey@adacore.com>
3690
3691 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3692
3693 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3694
3695 * gdbtypes.c (overload_debug): Move comment to header.
3696 * gdbtypes.h (overload_debug): Declare.
3697 * valops.c: Remove declaration of overload_debug, instead
3698 include gdbtypes.h.
3699
3700 2019-10-08 Christian Biesinger <cbiesinger@google.com>
3701
3702 * language.c (show_language_command): Pass lang_frame_mismatch_warn
3703 through _().
3704 (lang_frame_mismatch_warn): Make const, mark with N_(), and
3705 move comment...
3706 * language.h (lang_frame_mismatch_warn): ... here. Also add
3707 declaration.
3708 * top.c (lang_frame_mismatch_warn): Remove declaration.
3709 (check_frame_language_change): Pass lang_frame_mismatch_warn
3710 through _().
3711
3712 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3713
3714 * c-lang.h (vtbl_ptr_name): Declare.
3715 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3716 it from the header.
3717 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3718
3719 2019-10-07 Christian Biesinger <cbiesinger@google.com>
3720
3721 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3722 gdb_static_assert.
3723
3724 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3725
3726 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3727 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3728 * ctfread.c: New file.
3729 * ctfread.h: New file.
3730 * elfread.c: Include ctfread.h.
3731 (struct elfinfo text_p): New member ctfsect.
3732 (elf_locate_sections): Mark CTF section.
3733 (elf_symfile_read): Call elfctf_build_psymtabs.
3734 * Makefile.in (LIBCTF): Add.
3735 (CLIBS): Use it.
3736 (CDEPS): Likewise.
3737 (DIST): Add ctfread.c.
3738
3739 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
3740
3741 * ctfread.c (struct nextfield): Renamed to ...
3742 (struct ctf_nextfield): ... this.
3743 (struct field_info): Renamed to ...
3744 (strut ctf_field_info): ... this.
3745 (attach_fields_to_type): Update for renamed structures.
3746 (ctf_add_member_cb): Likewise.
3747 (ctf_add_enum_member_cb): Likewise.
3748 (process_struct_members): Likewise.
3749 (process_enum_type): Likewise.
3750
3751 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
3752
3753 * tracectf.h: Rename, was ctf.h.
3754 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3755 * tracefile.c: Likewise.
3756 * tracepoint.c: Remove unused include ctf.h.
3757 * mi/mi-main.c: Likewise.
3758 * Makefile.in Replace ctf.c with tracectf.c.
3759
3760 2019-10-06 Joel Brobecker <brobecker@adacore.com>
3761
3762 * version.in: Change version number to "9.0.50.DATE-git".
3763
3764 2019-10-03 Tom Tromey <tom@tromey.com>
3765
3766 PR rust/24976:
3767 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3768
3769 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3770
3771 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3772 cp_search_name_hash.
3773 * NEWS: Add entry about nested function support.
3774
3775 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
3776 Andrew Burgess <andrew.burgess@embecosm.com>
3777
3778 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3779 for nested static variables when searchin VAR_DOMAIN.
3780 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3781 global scope, update comment.
3782 (add_partial_subprogram): Call add_partial_subprogram recursively
3783 for nested subroutines when processinng Fortran.
3784 (load_partial_dies): Process the child entities of a subprogram
3785 when processing Fortran.
3786 (partial_die_parent_scope): Handle building scope
3787 for Fortran nested functions.
3788 (process_die): Record that nested functions have a scope.
3789 (new_symbol): Always record Fortran subprograms on the global
3790 symbol list.
3791 (determine_prefix): How to build the prefix for Fortran
3792 subprograms.
3793
3794 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3795
3796 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3797 have just sent the thread a SIGSTOP and are waiting for it to
3798 arrive.
3799
3800 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
3801
3802 * btrace.c (btrace_add_pc): Remove whitespace before the template
3803 parameter in 'std::vector <...>'.
3804 (parse_xml_btrace_block): Likewise.
3805 (btrace_maint_decode_pt): Likewise.
3806 (btrace_maint_update_packets): Likewise.
3807 (btrace_maint_print_packets): Likewise.
3808 * btrace.h (struct btrace_maint_info): Likewise.
3809 * dwarf2read.c (struct type_unit_group): Likewise.
3810 (build_type_psymtabs_reader): Likewise.
3811 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3812 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3813 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3814
3815 2019-10-03 Tom de Vries <tdevries@suse.de>
3816
3817 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3818 the first line of the help text for set/show style metadata.
3819
3820 2019-10-02 Tom Tromey <tromey@adacore.com>
3821
3822 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3823 * gdbsupport/common-inferior.c: New file.
3824 * infcmd.c (startup_with_shell): Don't define.
3825 * nat/fork-inferior.h (startup_with_shell): Don't declare.
3826 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3827 * inferior.h (startup_with_shell): Don't declare.
3828
3829 2019-10-02 Christian Biesinger <cbiesinger@google.com>
3830
3831 * gdbsupport/gdb_assert.h: Include errors.h.
3832 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3833
3834 2019-10-02 Tom Tromey <tromey@adacore.com>
3835
3836 * NEWS: Add $_ada_exception entry.
3837 * ada-lang.c (struct ada_catchpoint): Add constructor.
3838 <m_kind>: New member.
3839 (allocate_location_exception, re_set_exception): Remove
3840 "ex" parameter.
3841 (should_stop_exception): Compute $_ada_exception.
3842 (check_status_exception, print_it_exception)
3843 (print_one_exception, print_mention_exception): Remove
3844 "ex" parameter.
3845 (allocate_location_catch_exception, re_set_catch_exception)
3846 (check_status_exception, print_it_catch_exception)
3847 (print_one_catch_exception, print_mention_catch_exception)
3848 (print_recreate_catch_exception)
3849 (allocate_location_catch_exception_unhandled)
3850 (re_set_catch_exception_unhandled)
3851 (check_status_exception, print_it_catch_exception_unhandled)
3852 (print_one_catch_exception_unhandled)
3853 (print_mention_catch_exception_unhandled)
3854 (print_recreate_catch_exception_unhandled)
3855 (allocate_location_catch_assert, re_set_catch_assert)
3856 (check_status_assert, print_it_catch_assert)
3857 (print_one_catch_assert, print_mention_catch_assert)
3858 (print_recreate_catch_assert)
3859 (allocate_location_catch_handlers, re_set_catch_handlers)
3860 (check_status_handlers, print_it_catch_handlers)
3861 (print_one_catch_handlers, print_mention_catch_handlers)
3862 (print_recreate_catch_handlers): Remove.
3863 (create_ada_exception_catchpoint): Update.
3864 (initialize_ada_catchpoint_ops): Update.
3865
3866 2019-10-02 Tom Tromey <tromey@adacore.com>
3867
3868 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3869 (create_excep_cond_exprs): Simplify exception string computation.
3870 (ada_exception_catchpoint_cond_string): Likewise.
3871
3872 2019-10-02 Tom Tromey <tromey@adacore.com>
3873
3874 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3875 * ada-lang.c (lesseq_defined_than): Handle
3876 LOC_STATIC.
3877 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3878 parameter.
3879 (dwarf2_has_info): Likewise.
3880 (new_symbol): Set maybe_copied on symbol when
3881 appropriate.
3882 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3883 parameter.
3884 <can_copy>: New member.
3885 * elfread.c (record_minimal_symbol): Set maybe_copied
3886 on symbol when appropriate.
3887 (elf_symfile_read): Update call to dwarf2_has_info.
3888 * minsyms.c (lookup_minimal_symbol_linkage): New
3889 function.
3890 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3891 * symtab.c (get_symbol_address, get_msymbol_address):
3892 New functions.
3893 * symtab.h (get_symbol_address, get_msymbol_address):
3894 Declare.
3895 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3896 maybe_copied.
3897 (struct symbol, struct minimal_symbol) <maybe_copied>:
3898 New member.
3899
3900 2019-10-02 Tom Tromey <tromey@adacore.com>
3901
3902 * source.c (struct current_source_location): New.
3903 (current_source_key): New global.
3904 (current_source_symtab, current_source_line)
3905 (current_source_pspace): Remove.
3906 (get_source_location): New function.
3907 (get_current_source_symtab_and_line)
3908 (set_default_source_symtab_and_line)
3909 (set_current_source_symtab_and_line)
3910 (clear_current_source_symtab_and_line, select_source_symtab)
3911 (info_source_command, print_source_lines_base)
3912 (info_line_command, search_command_helper, _initialize_source):
3913 Update.
3914
3915 2019-10-02 Tom Tromey <tromey@adacore.com>
3916
3917 * source.c (select_source_symtab): Don't call
3918 decode_line_with_current_source.
3919
3920 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3921
3922 * symtab.c (lookup_global_symbol): Search global block.
3923
3924 2019-10-02 Tom Tromey <tromey@adacore.com>
3925
3926 * coffread.c (process_coff_symbol): Update.
3927 * dwarf2read.c (var_decode_location, new_symbol): Update.
3928 * mdebugread.c (parse_symbol): Update.
3929 * objfiles.c (relocate_one_symbol): Update.
3930 * stabsread.c (define_symbol, fix_common_block)
3931 (scan_file_globals): Update.
3932 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3933 (SET_SYMBOL_VALUE_ADDRESS): New macro.
3934 * xcoffread.c (process_xcoff_symbol): Update.
3935
3936 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
3937
3938 * MAINTAINERS: Update my email address.
3939
3940 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3941
3942 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3943 std::vector.
3944 (build_type_psymtabs_reader): Update for std::vector.
3945 (build_type_psymtab_dependencies): Likewise.
3946 * dwarf2read.h: Remove use of DEF_VEC_P.
3947 (typedef sig_type_ptr): Delete.
3948
3949 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3950
3951 * btrace.c (btrace_maint_clear): Update to handle change from VEC
3952 to std::vector.
3953 (btrace_maint_decode_pt): Likewise, and move allocation of the
3954 vector outside of the loop.
3955 (btrace_maint_update_packets): Update to handle change from VEC to
3956 std::vector.
3957 (btrace_maint_print_packets): Likewise.
3958 (maint_info_btrace_cmd): Likewise.
3959 * btrace.h: Remove use of DEF_VEC_O.
3960 (typedef btrace_pt_packet_s): Delete.
3961 (struct btrace_maint_info) <packets>: Change fromm VEC to
3962 std::vector.
3963 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3964
3965 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3966
3967 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3968 make accesses into the vector constant references.
3969 (btrace_add_pc): Update for std::vector.
3970 (btrace_stitch_bts): Likewise.
3971 (parse_xml_btrace_block): Likewise.
3972 (btrace_maint_update_packets): Likewise.
3973 (btrace_maint_print_packets): Likewise.
3974 (maint_info_btrace_cmd): Likewise.
3975 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3976 std::vector.
3977 (btrace_data::empty): Likewise.
3978 (btrace_data_append): Likewise.
3979 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3980 (typedef btrace_block_s): Delete.
3981 (struct btrace_block): Add constructor.
3982 (struct btrace_data_bts) <blocks>: Change to std::vector.
3983 * nat/linux-btrace.c (perf_event_read_bts): Update for
3984 std::vector.
3985 (linux_read_bts): Likewise.
3986
3987 2019-10-01 Tom Tromey <tom@tromey.com>
3988
3989 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3990
3991 2019-10-01 Tom Tromey <tom@tromey.com>
3992
3993 * stack.c (print_frame, info_frame_command_core): Use
3994 styled_string.
3995 * linux-thread-db.c (try_thread_db_load_1)
3996 (try_thread_db_load_from_pdir_1): Use styled_string.
3997 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3998 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3999 (maybe_print_unsupported_script_warning)
4000 (maybe_print_script_not_found_warning): Use styled_string.
4001 * ada-lang.c (user_select_syms): Use styled_string.
4002
4003 2019-10-01 Tom Tromey <tom@tromey.com>
4004
4005 * p-lang.c (pascal_printstr): Use metadata style.
4006 * value.c (show_convenience): Use metadata style.
4007 * valprint.c (valprint_check_validity, val_print_optimized_out)
4008 (val_print_not_saved, val_print_unavailable)
4009 (val_print_invalid_address, generic_val_print, val_print)
4010 (value_check_printable, val_print_array_elements): Use metadata
4011 style.
4012 * ui-out.h (class ui_out) <field_fmt>: New overload.
4013 <do_field_fmt>: Add style parameter.
4014 * ui-out.c (ui_out::field_fmt): New overload.
4015 * typeprint.c (type_print_unknown_return_type)
4016 (val_print_not_allocated, val_print_not_associated): Use metadata
4017 style.
4018 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
4019 parameter.
4020 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
4021 * tracepoint.c (tvariables_info_1): Use metadata style.
4022 * stack.c (print_frame_arg, print_frame_info, print_frame)
4023 (info_frame_command_core): Use metadata style.
4024 * skip.c (info_skip_command): Use metadata style.
4025 * rust-lang.c (rust_print_enum): Use metadata style.
4026 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
4027 metadata style.
4028 * python/py-framefilter.c (py_print_single_arg): Use metadata
4029 style.
4030 * printcmd.c (do_one_display, print_variable_and_value): Use
4031 metadata style.
4032 * p-valprint.c (pascal_val_print)
4033 (pascal_object_print_value_fields): Use metadata style.
4034 * p-typeprint.c (pascal_type_print_base): Use metadata style.
4035 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
4036 parameter.
4037 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
4038 * m2-valprint.c (m2_print_long_set): Use metadata style.
4039 * m2-typeprint.c (m2_print_type): Use metadata style.
4040 * infcmd.c (print_return_value_1): Use metadata style.
4041 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
4042 * f-valprint.c (info_common_command_for_block): Use metadata
4043 style.
4044 * f-typeprint.c (f_type_print_base): Use metadata style.
4045 * expprint.c (print_subexp_standard): Use metadata style.
4046 * cp-valprint.c (cp_print_value_fields): Use metadata style.
4047 * cli/cli-style.h (class cli_style_option): Add constructor.
4048 (metadata_style): Declare.
4049 * cli/cli-style.c (metadata_style): New global.
4050 (_initialize_cli_style): Register metadata style.
4051 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
4052 parameter.
4053 * cli-out.c (cli_ui_out::do_field_fmt): Update.
4054 * c-typeprint.c (c_type_print_base_struct_union)
4055 (c_type_print_base_1): Use metadata style.
4056 * breakpoint.c (watchpoint_value_print)
4057 (print_one_breakpoint_location): Use metadata style.
4058 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
4059 style.
4060 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
4061 style.
4062 * ada-valprint.c (val_print_packed_array_elements, printstr)
4063 (print_field_values, ada_val_print_ref, ada_val_print): Use
4064 metadata style.
4065 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
4066 style.
4067 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
4068 style.
4069 * ada-lang.c (user_select_syms): Use metadata style.
4070
4071 2019-10-01 Tom Tromey <tom@tromey.com>
4072
4073 * cli/cli-cmds.c (pwd_command): Style output.
4074
4075 2019-10-01 Pedro Alves <palves@redhat.com>
4076 Tom Tromey <tom@tromey.com>
4077
4078 * symtab.c (print_symbol_info): Use %ps.
4079 (print_msymbol_info): Use %ps.
4080 * symfile.c (symbol_file_add_with_addrs): Use %ps.
4081 * printcmd.c (print_variable_and_value): Use %ps.
4082 * macrocmd.c (show_pp_source_pos): Use %ps.
4083 * infrun.c (print_exited_reason): Use ui_out::message.
4084 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
4085 (describe_other_breakpoints): Use ui_out::message and new
4086 formats.
4087 (say_where): Use new formats.
4088 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
4089 and new formats.
4090
4091 2019-10-01 Pedro Alves <palves@redhat.com>
4092 Tom Tromey <tom@tromey.com>
4093
4094 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
4095 (test_gdb_formats): New function.
4096 (run_tests): Call it.
4097 (test_format_specifier): Update.
4098 * utils.h (fputs_filtered): Update comment.
4099 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
4100 (fputs_styled_unfiltered): Declare.
4101 * utils.c (fputs_styled_unfiltered): New function.
4102 (vfprintf_maybe_filtered): Add gdbfmt parameter.
4103 (vfprintf_filtered): Update.
4104 (vfprintf_unfiltered, vprintf_filtered): Update.
4105 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
4106 * ui-out.h (enum ui_out_flag) <unfiltered_output,
4107 disallow_ui_out_field>: New constants.
4108 (enum class field_kind): New.
4109 (struct base_field_s, struct signed_field_s): New.
4110 (signed_field): New function.
4111 (struct string_field_s): New.
4112 (string_field): New function.
4113 (struct styled_string_s): New.
4114 (styled_string): New function.
4115 (class ui_out) <message>: Add comment.
4116 <vmessage, call_do_message>: New methods.
4117 <do_message>: Add style parameter.
4118 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
4119 methods.
4120 (ui_out::message): Rewrite.
4121 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
4122 parameter.
4123 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
4124 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
4125 gdb_extensions parameter.
4126 (class format_piece): Add parameter to constructor.
4127 (n_int_args): New field.
4128 * gdbsupport/format.c (format_pieces::format_pieces): Add
4129 gdb_extensions parameter. Handle '*'.
4130 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
4131 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
4132 vfprintf_styled_no_gdbfmt.
4133 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
4134 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
4135 unfiltered output.
4136 * ui-style.h (struct ui_file_style) <ptr>: New method.
4137
4138 2019-10-01 Tom Tromey <tom@tromey.com>
4139
4140 * unittests/format_pieces-selftests.c: Update. Add final format.
4141 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
4142 empty literal pieces.
4143
4144 2019-10-01 Tom Tromey <tom@tromey.com>
4145
4146 * ui-out.h (enum class ui_out_style_kind): Remove.
4147 (class ui_out) <field_string, field_stsream, do_field_string>:
4148 Change type of "style".
4149 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4150 (ui_out::field_string): Update.
4151 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4152 of "style".
4153 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4154 * tracepoint.c (print_one_static_tracepoint_marker): Update.
4155 * stack.c (print_frame_arg, print_frame_info, print_frame):
4156 Update.
4157 * source.c (print_source_lines_base): Update.
4158 * solib.c (info_sharedlibrary_command): Update.
4159 * skip.c (info_skip_command): Update.
4160 * record-btrace.c (btrace_call_history_src_line)
4161 (btrace_call_history): Update.
4162 * python/py-framefilter.c (py_print_frame): Update.
4163 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4164 "style".
4165 * mi/mi-out.c (mi_ui_out::do_table_header)
4166 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4167 (mi_ui_out::do_field_string): Update.
4168 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4169 Update.
4170 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4171 "style".
4172 * cli-out.c (cli_ui_out::do_table_header)
4173 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4174 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4175 (cli_ui_out::do_field_fmt): Update.
4176 * breakpoint.c (print_breakpoint_location): Update.
4177 (update_static_tracepoint): Update.
4178
4179 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4180
4181 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4182 conversion of gdb_datadir.
4183 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4184 remove not needed c_str ().
4185
4186 2019-09-30 Ali Tamur <tamur@google.com>
4187
4188 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4189 (dwarf2_string_attr): Likewise.
4190
4191 2019-09-30 Ali Tamur <tamur@google.com>
4192
4193 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4194 (process_full_type_unit): Likewise.
4195 (dump_die_shallow): Likewise.
4196 (cu_debug_loc_section): Likewise.
4197
4198 2019-09-28 Christian Biesinger <cbiesinger@google.com>
4199
4200 * minsyms.c (compare_minimal_symbols): Rename to...
4201 (minimal_symbol_is_less_than): ...this, and adjust to STL
4202 conventions (return bool, take arguments as references)
4203 (minimal_symbol_reader::install): Call std::sort instead
4204 of qsort.
4205
4206 2019-09-29 Christian Biesinger <cbiesinger@google.com>
4207
4208 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4209 hash and why.
4210 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4211 msymbol_hash, msymbol_demangled_hash>: Improve comments.
4212
4213 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
4214
4215 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4216 * psympriv.h (add_psymbol_to_list): Move comment here and update
4217 it.
4218
4219 2019-09-29 Tom de Vries <tdevries@suse.de>
4220
4221 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4222 Use $tmpdir/$(basename "$output_file").dwz instead of
4223 "${output_file}.dwz".
4224
4225 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
4226
4227 PR gdb/25045
4228 * hppa-linux-nat.c: Include gdbarch.h.
4229
4230 2019-09-26 Christian Biesinger <cbiesinger@google.com>
4231
4232 * blockframe.c (find_pc_partial_function): Change return type to bool.
4233 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4234 * minsyms.c (in_gnu_ifunc_stub): Likewise.
4235 (stub_gnu_ifunc_resolve_name): Likewise.
4236 * symtab.c (compare_filenames_for_search): Likewise.
4237 (compare_glob_filenames_for_search): Likewise.
4238 (matching_obj_sections): Likewise.
4239 (symbol_matches_domain): Likewise.
4240 (find_line_symtab): Change out param EXACT_MATCH to bool *.
4241 (find_line_pc): Change return type to bool.
4242 (find_line_pc_range): Likewise.
4243 (producer_is_realview): Likewise.
4244 * symtab.h (symbol_matches_domain): Likewise.
4245 (find_pc_partial_function): Likewise.
4246 (find_pc_line_pc_range): Likewise.
4247 (in_gnu_ifunc_stub): Likewise.
4248 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4249 (find_line_pc): Likewise.
4250 (find_line_pc_range): Likewise.
4251 (matching_obj_sections): Likewise.
4252 (find_line_symtab): Change out parameter to bool.
4253 (producer_is_realview): Change return type to bool.
4254 (compare_filenames_for_search): Likewise.
4255 (compare_glob_filenames_for_search): Likewise.
4256
4257 2019-09-26 Tom Tromey <tom@tromey.com>
4258
4259 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4260 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4261 * gdb_usleep.h: Remove.
4262 * gdb_usleep.c: Remove.
4263 * utils.c: Don't include gdb_usleep.h.
4264
4265 2019-09-26 Tom Tromey <tromey@adacore.com>
4266
4267 * python/py-type.c (type_to_type_object): Call check_typedef
4268 for stub types.
4269
4270 2019-09-26 Tom Tromey <tom@tromey.com>
4271
4272 * utils.h (initialize_utils): Don't declare.
4273 * top.c (gdb_init): Don't call initialize_utils.
4274 * utils.c (initialize_utils): Remove. Move contents...
4275 (_initialize_utils): ... here.
4276
4277 2019-09-25 Tom Tromey <tom@tromey.com>
4278
4279 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4280 * utils.h (make_hex_string): Don't declare.
4281 * utils.c (make_hex_string): Remove.
4282
4283 2019-09-24 Tom de Vries <tdevries@suse.de>
4284
4285 PR gdb/23815
4286 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4287 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4288
4289 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
4290
4291 * NEWS: Mention new simulator port for PRU.
4292
4293 2019-09-23 Christian Biesinger <cbiesinger@google.com>
4294
4295 * ada-exp.y (write_object_remaining): Update.
4296 * ada-lang.c (ada_decode): Return a std::string instead of a char*
4297 and eliminate the static buffer.
4298 (ada_decode_symbol): Update.
4299 (ada_la_decode): Update.
4300 (ada_sniff_from_mangled_name): Update.
4301 (is_valid_name_for_wild_match): Update.
4302 (ada_lookup_name_info::matches): Update and simplify.
4303 (name_matches_regex): Update.
4304 (ada_add_global_exceptions): Update.
4305 * ada-lang.h (ada_decode): Update signature.
4306 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4307 * dwarf-index-write.c (debug_names::insert): Update.
4308
4309 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4310
4311 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4312 formatting.
4313
4314 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
4315
4316 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4317 Change "nonzero" to "true" in documentation.
4318
4319 2019-09-20 Christian Biesinger <cbiesinger@google.com>
4320
4321 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4322 (_initialize_darwin_solib): Don't set
4323 darwin_so_ops.lookup_lib_global_symbol.
4324 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4325 set_gdbarch_iterate_over_objfiles_in_search_order.
4326 (elf_lookup_lib_symbol): Rename to...
4327 (svr4_iterate_over_objfiles_in_search_order): this, and update
4328 to iterate semantics.
4329 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4330 * solib.c (solib_global_lookup): Remove.
4331 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4332 (solib_global_lookup): Remove.
4333 * symtab.c (lookup_global_or_static_symbol): Remove call to
4334 solib_global_lookup.
4335
4336 2019-09-20 Joel Brobecker <brobecker@adacore.com>
4337
4338 * NEWS: Move entries about default MI version now being
4339 version 3, and about the GDB/MI fix for multi-location
4340 breakpoints to the "since GDB 8.3" section.
4341
4342 2019-09-20 Joel Brobecker <brobecker@adacore.com>
4343
4344 GDB 8.3.1 released.
4345
4346 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
4347
4348 * NEWS: Mention that Cell/B.E. debugging support was removed.
4349 * MAINTAINERS: Remove spu target.
4350
4351 * config/djgpp/fnchange.lst: Remove entries for removed files.
4352
4353 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4354 spu-multiarch.o, and spu-tdep.o.
4355 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4356 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4357 spu-multiarch.c, and spu-tdep.c.
4358 * spu-linux-nat.c: Remove file.
4359 * spu-multiarch.c: Remove file.
4360 * spu-tdep.c: Remove file.
4361 * spu-tdep.h: Remove file.
4362 * solib-spu.c: Remove file.
4363 * solib-spu.h: Remove file.
4364
4365 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4366 * configure.nat (spu-linux): Remove.
4367 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4368 solib-multiarch.o from gdb_target_obs.
4369 (spu*-*-*): Remove.
4370
4371 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4372 feature flag.
4373 (ppc_linux_no_features): Update.
4374 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4375 Cell/B.E. support.
4376 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4377 (tdesc_powerpc_cell64l): Likewise.
4378 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4379 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4380 Cell/B.E. support.
4381 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4382 Do not include "features/rs6000/powerpc-cell32l.c" or
4383 "features/rs6000/powerpc-cell64l.c".
4384 (ppc_linux_spu_section): Remove.
4385 (ppc_linux_core_read_description): Remove Cell/B.E. support.
4386 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4387 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4388 (ppc_linux_spe_context_lookup): Remove.
4389 (ppc_linux_spe_context_inferior_created): Remove.
4390 (ppc_linux_spe_context_solib_loaded): Remove.
4391 (ppc_linux_spe_context_solib_unloaded): Remove.
4392 (ppc_linux_spe_context): Remove.
4393 (struct ppu2spu_cache): Remove.
4394 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4395 (struct ppu2spu_data): Remove.
4396 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4397 ppu2spu_unwind): Remove.
4398 (ppc_linux_init_abi): Remove Cell/B.E. support.
4399 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4400
4401 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4402 (rs6000/powerpc-cell64l-expedite): Likewise
4403 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4404 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4405 rs6000/powerpc-cell64l.xml.
4406 * features/rs6000/powerpc-cell32l.xml: Remove.
4407 * features/rs6000/powerpc-cell64l.xml: Likewise.
4408 * features/rs6000/powerpc-cell32l.c: Remove generated file.
4409 * features/rs6000/powerpc-cell64l.c: Likewise.
4410 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4411 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4412 * regformats/reg-spu.dat: Remove.
4413
4414 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4415 * corelow.c (struct spuid_list): Remove.
4416 (add_to_spuid_list): Remove.
4417 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4418 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4419 (remote_protocol_features): Remove associated entries.
4420 (_initialize_remote): No longer initialize them.
4421 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4422 * linux-nat.c (SPUFS_MAGIC): Remove.
4423 (linux_proc_xfer_spu): Remove.
4424 (spu_enumerate_spu_ids): Remove.
4425 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4426 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4427 (linux_make_corefile_notes): No longer call it.
4428
4429 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4430 (cooked_write_test): Likewise.
4431
4432 2019-09-20 Tom Tromey <tom@tromey.com>
4433
4434 * NEWS: Mention case-sensitivity of TUI commands.
4435 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4436 (tui_set_win_height_command, parse_scrolling_args): Likewise.
4437 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4438
4439 2019-09-20 Tom Tromey <tom@tromey.com>
4440
4441 * tui/tui-source.c (tui_source_window::set_contents): Use
4442 make_unique_xstrdup.
4443 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4444 make_unique_xstrdup.
4445
4446 2019-09-20 Tom Tromey <tom@tromey.com>
4447
4448 * tui/tui-data.c: Remove separator comments.
4449 * tui/tui-layout.c: Remove separator comments.
4450 * tui/tui-win.c: Remove separator comments.
4451 * tui/tui-wingeneral.c: Remove separator comments.
4452
4453 2019-09-20 Tom Tromey <tom@tromey.com>
4454
4455 * tui/tui.h (strcat_to_buf): Don't declare.
4456 * tui/tui.c (strcat_to_buf): Remove.
4457
4458 2019-09-20 Tom Tromey <tom@tromey.com>
4459
4460 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4461 from "fullname".
4462 * tui/tui-source.c (tui_source_window::set_contents)
4463 (tui_source_window::location_matches_p)
4464 (tui_source_window::maybe_update): Update.
4465
4466 2019-09-20 Tom Tromey <tom@tromey.com>
4467
4468 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4469 Update.
4470 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4471 prefix.
4472 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4473 (tui_data_window::line_from_reg_element_no)
4474 (tui_data_window::first_reg_element_no_inline)
4475 (tui_data_window::show_registers)
4476 (tui_data_window::show_register_group)
4477 (tui_data_window::display_registers_from)
4478 (tui_data_window::display_registers_from_line)
4479 (tui_data_window::first_data_item_displayed)
4480 (tui_data_window::delete_data_content_windows)
4481 (tui_data_window::erase_data_content)
4482 (tui_data_window::do_scroll_vertical)
4483 (tui_data_window::refresh_window)
4484 (tui_data_window::check_register_values): Update.
4485
4486 2019-09-20 Tom Tromey <tom@tromey.com>
4487
4488 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4489 (struct tui_locator_window) <full_name, proc_name>: Now
4490 std::string.
4491 * tui/tui-stack.c (tui_locator_window::make_status_line)
4492 (tui_locator_window::set_locator_fullname)
4493 (tui_locator_window::set_locator_info): Update.
4494 * tui/tui-source.c (tui_source_window::set_contents)
4495 (tui_source_window::showing_source_p): Update.
4496
4497 2019-09-20 Tom Tromey <tom@tromey.com>
4498
4499 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4500 Don't call tui_locator_win_info_ptr.
4501
4502 2019-09-20 Tom Tromey <tom@tromey.com>
4503
4504 * tui/tui-win.c (tui_resize_all): Don't call refresh.
4505
4506 2019-09-20 Tom Tromey <tom@tromey.com>
4507
4508 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4509 height for locator.
4510 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4511 * tui/tui-layout.c (show_source_disasm_command, show_data)
4512 (show_source_or_disasm_and_command): Use 1 as height for locator.
4513
4514 2019-09-20 Tom Tromey <tom@tromey.com>
4515
4516 * tui/tui.c (tui_enable): Update.
4517 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4518 Update.
4519 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4520 Update.
4521 * tui/tui-data.c (win_resized): Now bool.
4522 (tui_win_resized): Return bool.
4523 (tui_set_win_resized_to): Accept a bool.
4524
4525 2019-09-20 Tom Tromey <tom@tromey.com>
4526
4527 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4528 Change type of "refresh_values_only".
4529 * tui/tui-regs.c (tui_data_window::show_register_group): Change
4530 type of "refresh_values_only".
4531
4532 2019-09-20 Tom Tromey <tom@tromey.com>
4533
4534 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4535 std::string.
4536 (tui_disassemble): Add "pos" parameter.
4537 (tui_disasm_window::set_contents): Simplify.
4538
4539 2019-09-20 Tom Tromey <tom@tromey.com>
4540
4541 * tui/tui-winsource.h (struct tui_source_window_base)
4542 <show_source_content>: Now private.
4543 * tui/tui-winsource.c
4544 (tui_source_window_base::show_source_content): Don't handle empty
4545 content case.
4546
4547 2019-09-20 Tom Tromey <tom@tromey.com>
4548
4549 * tui/tui-layout.c (show_source_disasm_command)
4550 (show_source_or_disasm_and_command): Don't call
4551 show_source_content.
4552
4553 2019-09-20 Tom Tromey <tom@tromey.com>
4554
4555 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4556 Declare.
4557 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4558 from tui_make_status_line.
4559 (tui_locator_window::rerender): Update.
4560
4561 2019-09-20 Tom Tromey <tom@tromey.com>
4562
4563 * tui/tui-stack.c (tui_make_status_line): Return std::string.
4564 (tui_locator_window::rerender): Update.
4565
4566 2019-09-20 Tom Tromey <tom@tromey.com>
4567
4568 * tui/tui-winsource.h (struct tui_source_window_base)
4569 <~tui_source_window_base>: Don't declare.
4570 <fullname>: Remove.
4571 * tui/tui-winsource.c (~tui_source_window_base): Remove.
4572 * tui/tui-source.h (struct tui_source_window) <fullname>: New
4573 member.
4574 * tui/tui-source.c (tui_source_window::set_contents): Update.
4575 (tui_source_window::location_matches_p)
4576 (tui_source_window::maybe_update): Update.
4577
4578 2019-09-20 Tom Tromey <tom@tromey.com>
4579
4580 * tui/tui-winsource.h (~tui_source_element): Remove.
4581 (tui_source_element): Update.
4582 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4583 * tui/tui-winsource.c (tui_show_source_line): Update.
4584 * tui/tui-source.c (tui_source_window::set_contents): Update.
4585 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4586
4587 2019-09-20 Tom Tromey <tom@tromey.com>
4588
4589 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4590 declare.
4591 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4592 tui_clear_source_windows_detail.
4593 * tui/tui-winsource.h (struct tui_source_window_base)
4594 <clear_detail>: Don't declare.
4595 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4596 Remove.
4597 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4598
4599 2019-09-20 Tom Tromey <tromey@adacore.com>
4600
4601 PR ada/24919:
4602 * block.c (contained_in): Fix final return value.
4603
4604 2019-09-20 Alan Modra <amodra@gmail.com>
4605
4606 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4607 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4608 (read_indirect_string_from_dwz): Use bfd accessor.
4609 * dwarf2read.h (struct dwz_file <filename>): Likewise.
4610 * machoread.c (macho_symfile_read_all_oso): Likewise.
4611 * solib.c (solib_bfd_open): Likewise.
4612
4613 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4614
4615 * eval.c: Move declaration of overload_resolution to...
4616 * value.h: ...here.
4617
4618 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4619
4620 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4621 * arm-linux-tdep.c: Likewise.
4622 * arm-nbsd-nat.c: Likewise.
4623 * arm-tdep.h: Declare arm_apcs_32.
4624 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4625
4626 2019-09-19 Christian Biesinger <cbiesinger@google.com>
4627
4628 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4629 * dwarf2read.h: Declare dwarf_always_disassemble.
4630
4631 2019-09-19 Tom de Vries <tdevries@suse.de>
4632
4633 PR gdb/25009
4634 * source-cache.c (source_cache::ensure): Catch exception thrown during
4635 construction of the highlighter.
4636
4637 2019-09-18 Alan Modra <amodra@gmail.com>
4638
4639 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4640 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4641 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4642 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4643 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4644 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4645 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4646 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4647 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4648 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4649 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4650 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4651 * solib-spu.c, * solib-svr4.c, * solib-target.c,
4652 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4653 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4654 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4655 * mi/mi-interp.c: Update throughout for bfd section macro and
4656 function changes.
4657 * gcore (gcore_create_callback): Use bfd_set_section_lma.
4658 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4659
4660 2019-09-18 Tom Tromey <tom@tromey.com>
4661
4662 * NEWS: Add entry.
4663 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
4664 call rl_initialize.
4665 (tui_enable): Do not call rl_initialize.
4666
4667 2019-09-18 Christian Groessler <chris@groessler.org>
4668
4669 * alpha-linux-nat.c: Include gdbarch.h.
4670
4671 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
4672
4673 * ui-file.c: Include cli/cli-style.h.
4674 (term_cli_styling): Remove cli_styling declaration.
4675
4676 2019-09-18 Alan Modra <amodra@gmail.com>
4677
4678 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4679 to bfd_asymbol_section.
4680
4681 2019-09-18 Alan Modra <amodra@gmail.com>
4682
4683 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4684 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4685 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4686
4687 2019-09-18 Alan Modra <amodra@gmail.com>
4688
4689 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4690 * spu-linux-nat.c (spu_bfd_open): Likewise.
4691
4692 2019-09-18 Christian Biesinger <cbiesinger@google.com>
4693
4694 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4695 to bool to match definition in dwarf2read.c.
4696
4697 2019-09-17 Christian Biesinger <cbiesinger@google.com>
4698
4699 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4700 (print_signatures): Likewise.
4701 (trust_pad_over_xvs): Likewise.
4702 * arch/aarch64-insn.c (aarch64_debug): Likewise.
4703 * arch/aarch64-insn.h (aarch64_debug): Likewise.
4704 * arm-linux-nat.c (arm_apcs_32): Likewise.
4705 * arm-linux-tdep.c (arm_apcs_32): Likewise.
4706 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4707 * arm-tdep.c (arm_debug): Likewise.
4708 (arm_apcs_32): Likewise.
4709 * auto-load.c (debug_auto_load): Likewise.
4710 (auto_load_gdb_scripts): Likewise.
4711 (global_auto_load): Likewise.
4712 (auto_load_local_gdbinit): Likewise.
4713 (auto_load_local_gdbinit_loaded): Likewise.
4714 * auto-load.h (global_auto_load): Likewise.
4715 (auto_load_local_gdbinit): Likewise.
4716 (auto_load_local_gdbinit_loaded): Likewise.
4717 * breakpoint.c (disconnected_dprintf): Likewise.
4718 (breakpoint_proceeded): Likewise.
4719 (automatic_hardware_breakpoints): Likewise.
4720 (always_inserted_mode): Likewise.
4721 (target_exact_watchpoints): Likewise.
4722 (_initialize_breakpoint): Update.
4723 * breakpoint.h (target_exact_watchpoints): Change to bool.
4724 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4725 * cli/cli-cmds.c (trace_commands): Likewise.
4726 * cli/cli-cmds.h (trace_commands): Likewise.
4727 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4728 to bool*.
4729 * cli/cli-logging.c (logging_overwrite): Change to bool.
4730 (logging_redirect): Likewise.
4731 (debug_redirect): Likewise.
4732 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4733 (struct boolean_option_def) <get_var_address_cb_>: Change return type
4734 to bool.
4735 <boolean_option_def>: Update.
4736 (struct flag_option_def): Change default type of Context to bool
4737 from int.
4738 <flag_option_def>: Change return type of var_address_cb_ to bool*.
4739 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4740 (get_setshow_command_value_string): Likewise.
4741 * cli/cli-style.c (cli_styling): Change to bool.
4742 (source_styling): Likewise.
4743 * cli/cli-style.h (source_styling): Likewise.
4744 (cli_styling): Likewise.
4745 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4746 to bool.
4747 * command.h (var_types): Update comment.
4748 (add_setshow_boolean_cmd): Change int* var argument to bool*.
4749 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4750 bool.
4751 (debug_compile_cplus_scopes): Likewise.
4752 * compile/compile-internal.h (compile_debug): Likewise.
4753 * compile/compile.c (compile_debug): Likewise.
4754 (struct compile_options) <raw>: Likewise.
4755 * cp-support.c (catch_demangler_crashes): Likewise.
4756 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4757 (usr_cmd_cris_dwarf2_cfi): Likewise.
4758 * csky-tdep.c (csky_debug): Likewise.
4759 * darwin-nat.c (enable_mach_exceptions): Likewise.
4760 * dcache.c (dcache_enabled_p): Likewise.
4761 * defs.h (info_verbose): Likewise.
4762 * demangle.c (demangle): Likewise.
4763 (asm_demangle): Likewise.
4764 * dwarf-index-cache.c (debug_index_cache): Likewise.
4765 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4766 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4767 * dwarf2read.c (check_physname): Likewise.
4768 (use_deprecated_index_sections): Likewise.
4769 (dwarf_always_disassemble): Likewise.
4770 * eval.c (overload_resolution): Likewise.
4771 * event-top.c (set_editing_cmd_var): Likewise.
4772 (exec_done_display_p): Likewise.
4773 * event-top.h (set_editing_cmd_var): Likewise.
4774 (exec_done_display_p): Likewise.
4775 * exec.c (write_files): Likewise.
4776 * fbsd-nat.c (debug_fbsd_lwp): Likewise
4777 (debug_fbsd_nat): Likewise.
4778 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4779 Likewise.
4780 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4781 <backtrace_past_entry> Likewise.
4782 * gdb-demangle.h (demangle): Likewise.
4783 (asm_demangle): Likewise.
4784 * gdb_bfd.c (bfd_sharing): Likewise.
4785 * gdbcore.h (write_files): Likewise.
4786 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4787 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4788 * gdbthread.h (print_thread_events): Likewise.
4789 * gdbtypes.c (opaque_type_resolution): Likewise.
4790 (strict_type_checking): Likewise.
4791 * gnu-nat.c (gnu_debug_flag): Likewise.
4792 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4793 * guile/scm-param.c (pascm_variable): Add boolval.
4794 (add_setshow_generic): Update.
4795 (pascm_param_value): Update.
4796 (pascm_set_param_value_x): Update.
4797 * hppa-tdep.c (hppa_debug): Change to bool..
4798 * infcall.c (may_call_functions_p): Likewise.
4799 (coerce_float_to_double_p): Likewise.
4800 (unwind_on_signal_p): Likewise.
4801 (unwind_on_terminating_exception_p): Likewise.
4802 * infcmd.c (startup_with_shell): Likewise.
4803 * inferior.c (print_inferior_events): Likewise.
4804 * inferior.h (startup_with_shell): Likewise.
4805 (print_inferior_events): Likewise.
4806 * infrun.c (step_stop_if_no_debug): Likewise.
4807 (detach_fork): Likewise.
4808 (debug_displaced): Likewise.
4809 (disable_randomization): Likewise.
4810 (non_stop): Likewise.
4811 (non_stop_1): Likewise.
4812 (observer_mode): Likewise.
4813 (observer_mode_1): Likewise.
4814 (set_observer_mode): Update.
4815 (sched_multi): Change to bool.
4816 * infrun.h (debug_displaced): Likewise.
4817 (sched_multi): Likewise.
4818 (step_stop_if_no_debug): Likewise.
4819 (non_stop): Likewise.
4820 (disable_randomization): Likewise.
4821 * linux-tdep.c (use_coredump_filter): Likewise.
4822 (dump_excluded_mappings): Likewise.
4823 * linux-thread-db.c (auto_load_thread_db): Likewise.
4824 (check_thread_db_on_load): Likewise.
4825 * main.c (captured_main_1): Update.
4826 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4827 xx2_opt, boolean_opt>: Change to bool.
4828 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4829 * maint.c (maintenance_profile_p): Likewise.
4830 (per_command_time): Likewise.
4831 (per_command_space): Likewise.
4832 (per_command_symtab): Likewise.
4833 * memattr.c (inaccessible_by_default): Likewise.
4834 * mi/mi-main.c (mi_async): Likewise.
4835 (mi_async_1): Likewise.
4836 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4837 * nat/fork-inferior.h (startup_with_shell): Likewise.
4838 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4839 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4840 * nios2-tdep.c (nios2_debug): Likewise.
4841 * or1k-tdep.c (or1k_debug): Likewise.
4842 * parse.c (parser_debug): Likewise.
4843 * parser-defs.h (parser_debug): Likewise.
4844 * printcmd.c (print_symbol_filename): Likewise.
4845 * proc-api.c (procfs_trace): Likewise.
4846 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4847 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4848 (set_parameter_value): Update.
4849 (add_setshow_generic): Update.
4850 * python/py-value.c (copy_py_bool_obj): Change argument from int*
4851 to bool*.
4852 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4853 int*.
4854 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4855 * record-btrace.c (record_btrace_target::store_registers): Update.
4856 * record-full.c (record_full_memory_query): Change to bool.
4857 (record_full_stop_at_limit): Likewise.
4858 * record-full.h (record_full_memory_query): Likewise.
4859 * remote-notif.c (notif_debug): Likewise.
4860 * remote-notif.h (notif_debug): Likewise.
4861 * remote.c (use_range_stepping): Likewise.
4862 (interrupt_on_connect): Likewise.
4863 (remote_break): Likewise.
4864 * ser-tcp.c (tcp_auto_retry): Likewise.
4865 * ser-unix.c (serial_hwflow): Likewise.
4866 * skip.c (debug_skip): Likewise.
4867 * solib-aix.c (solib_aix_debug): Likewise.
4868 * spu-tdep.c (spu_stop_on_load_p): Likewise.
4869 (spu_auto_flush_cache_p): Likewise.
4870 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4871 Likewise.
4872 (struct info_print_options) <quiet>: Likewise.
4873 * symfile-debug.c (debug_symfile): Likewise.
4874 * symfile.c (auto_solib_add): Likewise.
4875 (separate_debug_file_debug): Likewise.
4876 * symfile.h (auto_solib_add): Likewise.
4877 (separate_debug_file_debug): Likewise.
4878 * symtab.c (basenames_may_differ): Likewise.
4879 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4880 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4881 (struct info_types_options) <quiet>: Likewise.
4882 * symtab.h (demangle): Likewise.
4883 (basenames_may_differ): Likewise.
4884 * target-dcache.c (stack_cache_enabled_1): Likewise.
4885 (code_cache_enabled_1): Likewise.
4886 * target.c (trust_readonly): Likewise.
4887 (may_write_registers): Likewise.
4888 (may_write_memory): Likewise.
4889 (may_insert_breakpoints): Likewise.
4890 (may_insert_tracepoints): Likewise.
4891 (may_insert_fast_tracepoints): Likewise.
4892 (may_stop): Likewise.
4893 (auto_connect_native_target): Likewise.
4894 (target_stop_and_wait): Update.
4895 (target_async_permitted): Change to bool.
4896 (target_async_permitted_1): Likewise.
4897 (may_write_registers_1): Likewise.
4898 (may_write_memory_1): Likewise.
4899 (may_insert_breakpoints_1): Likewise.
4900 (may_insert_tracepoints_1): Likewise.
4901 (may_insert_fast_tracepoints_1): Likewise.
4902 (may_stop_1): Likewise.
4903 * target.h (target_async_permitted): Likewise.
4904 (may_write_registers): Likewise.
4905 (may_write_memory): Likewise.
4906 (may_insert_breakpoints): Likewise.
4907 (may_insert_tracepoints): Likewise.
4908 (may_insert_fast_tracepoints): Likewise.
4909 (may_stop): Likewise.
4910 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4911 (make_thread_apply_all_options_def_group): Change argument from int*
4912 to bool*.
4913 (thread_apply_all_command): Update.
4914 (print_thread_events): Change to bool.
4915 * top.c (confirm): Likewise.
4916 (command_editing_p): Likewise.
4917 (history_expansion_p): Likewise.
4918 (write_history_p): Likewise.
4919 (info_verbose): Likewise.
4920 * top.h (confirm): Likewise.
4921 (history_expansion_p): Likewise.
4922 * tracepoint.c (disconnected_tracing): Likewise.
4923 (circular_trace_buffer): Likewise.
4924 * typeprint.c (print_methods): Likewise.
4925 (print_typedefs): Likewise.
4926 * utils.c (debug_timestamp): Likewise.
4927 (sevenbit_strings): Likewise.
4928 (pagination_enabled): Likewise.
4929 * utils.h (sevenbit_strings): Likewise.
4930 (pagination_enabled): Likewise.
4931 * valops.c (overload_resolution): Likewise.
4932 * valprint.h (struct value_print_options) <prettyformat_arrays,
4933 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4934 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4935 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4936 Likewise.
4937 * windows-nat.c (new_console): Likewise.
4938 (cygwin_exceptions): Likewise.
4939 (new_group): Likewise.
4940 (debug_exec): Likewise.
4941 (debug_events): Likewise.
4942 (debug_memory): Likewise.
4943 (debug_exceptions): Likewise.
4944 (useshell): Likewise.
4945 * windows-tdep.c (maint_display_all_tib): Likewise.
4946 * xml-support.c (debug_xml): Likewise.
4947
4948 2019-09-17 Mike Gulick <mgulick@mathworks.com>
4949
4950 * source.c (prepare_path_for_appending): New function.
4951 (openp): Make use of new function.
4952 (find_and_open_source): Search for the compilation directory and
4953 source file as a relative path beneath the directory search path.
4954
4955 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
4956
4957 * source-cache.c (source_cache::get_line_charpos): Catch
4958 exceptions and return false, this matches the behaviour documented
4959 in the header file.
4960
4961 2019-09-17 Joel Brobecker <brobecker@adacore.com>
4962
4963 * ada-tasks.c (info_task): Remove quoting of the task's name.
4964
4965 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4966
4967 * symfile.c (auto_solib_add): Replace comment with a reference
4968 to the header file.
4969
4970 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4971
4972 * NEWS: Mention that gdb can now be compiled with Python 3
4973 on Windows.
4974
4975 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4976
4977 * maint.c (maint_print_section_data::maint_print_section_data):
4978 Force use of 'float log10 (float)' by casting the argument to
4979 float.
4980
4981 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4982
4983 * maint.c: Add 'cmath' include.
4984 (struct maint_print_section_data): New structure.
4985 (print_section_index): New function.
4986 (print_bfd_section_info): Add header comment, small whitespace
4987 cleanup, and update to call new print_section_index function.
4988 (print_objfile_section_info): Likewise.
4989 (maint_obj_section_from_bfd_section): New function.
4990 (print_bfd_section_info_maybe_relocated): New function.
4991 (maintenance_info_sections): Add header comment, always use
4992 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4993
4994 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4995
4996 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4997 inner scope, add check that the objfile has psymtabs before
4998 checking psymtabs_addrmap.
4999 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
5000
5001 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5002
5003 * NEWS: Announce that Ada task names are now shown at more places,
5004 and between quotes (except in info task output).
5005 * gdb/ada-tasks.c (task_to_str): New function.
5006 (display_current_task_id): Call task_to_str.
5007 (task_command_1): Likewise.
5008 (print_ada_task_info): In non-mi mode, Properly align headers and data
5009 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
5010
5011 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
5012
5013 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
5014 prstatus.pr_lwp.pr_info instead of making it up.
5015
5016 2019-09-11 Christian Biesinger <cbiesinger@google.com>
5017
5018 * auto-load.c (auto_load_expand_dir_vars): Update.
5019 * defs.h (gdb_datadir): Change to std::string.
5020 (python_libdir): Likewise.
5021 (relocate_gdb_directory): Change return type to std::string.
5022 * guile/guile.c (gdbscm_data_directory): Update.
5023 (initialize_scheme_side): Update.
5024 * jit.c (jit_reader_dir): Change to std::string.
5025 (jit_reader_load_command): Update.
5026 * main.c (gdb_datadir): Change to std::string.
5027 (python_libdir): Likewise.
5028 (set_gdb_data_directory): Update.
5029 (relocate_path): Change to return std::string.
5030 (relocate_gdb_directory): Change to return std::string.
5031 (relocate_gdbinit_path_maybe_in_datadir): Update.
5032 (captured_main_1): Update.
5033 * python/python.c (do_start_initialization): Update.
5034 * top.c (show_gdb_datadir): Update.
5035 * xml-syscall.c (xml_init_syscalls_info): Update.
5036 (init_syscalls_info): Update.
5037
5038 2019-09-11 Christian Biesinger <cbiesinger@google.com>
5039
5040 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
5041 out of get_init_files.
5042 (get_init_files): Update.
5043
5044 2019-09-11 Christian Biesinger <cbiesinger@google.com>
5045
5046 * main.c (get_init_files): Change to use std::string.
5047 (captured_main_1): Update.
5048 (print_gdb_help): Update.
5049
5050 2019-09-11 Ali Tamur <tamur@google.com>
5051
5052 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
5053 implementation.
5054
5055 2019-09-11 Christian Biesinger <cbiesinger@google.com>
5056
5057 * dbxread.c (read_dbx_symtab): Update.
5058 * dwarf2read.c (load_partial_dies): Update.
5059 * mdebugread.c (parse_partial_symbols): Update.
5060 (handle_psymbol_enumerators): Update.
5061 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
5062 * psymtab.c (add_psymbol_to_bcache): Likewise.
5063 (add_psymbol_to_list): Likewise.
5064 * symtab.c (symbol_set_names): Likewise.
5065 * symtab.h (symbol_set_names): Likewise.
5066 * xcoffread.c (scan_xcoff_symtab): Update.
5067
5068 2019-09-11 Tom Tromey <tom@tromey.com>
5069
5070 * symfile-mem.c (symbol_file_add_from_memory): Use
5071 bfd_set_filename.
5072 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
5073 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
5074
5075 2019-09-10 Tom Tromey <tromey@adacore.com>
5076
5077 * dwarf-index-write.c (write_psymbols): Extend error message.
5078 (debug_names::insert): Add Ada code.
5079 (debug_names::write_psymbols): Remove Ada check.
5080 (debug_names) <m_string_obstack>: New member.
5081 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
5082 (gdb_index_symbol_name_matcher::matches): Remove.
5083 (mapped_index_base::find_name_components_bounds): Add "lang"
5084 parameter.
5085 (mapped_index_base::build_name_components): Also split names
5086 according to Ada syntax.
5087 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
5088 type of "match_callback".
5089 (check_match, check_find_bounds_finds)
5090 (dw2_expand_symtabs_matching): Update.
5091 (dw2_debug_names_iterator): Add new constructor.
5092 (dw2_debug_names_map_matching_symbols): New function.
5093 (dw2_debug_names_expand_symtabs_matching): Update.
5094 (dwarf2_debug_names_functions): Use
5095 dw2_debug_names_map_matching_symbols.
5096
5097 2019-09-10 Tom Tromey <tromey@adacore.com>
5098
5099 * dwarf2read.c (dw2_get_file_names_reader): Add the
5100 CU's file name to the results.
5101
5102 2019-09-10 Tom Tromey <tromey@adacore.com>
5103
5104 * ada-lang.c (add_nonlocal_symbols): Combine calls to
5105 map_matching_symbols. Update.
5106 * dwarf2read.c (dw2_map_matching_symbols): Update.
5107 * psymtab.c (match_partial_symbol): Change type; update.
5108 (psym_map_matching_symbols): Likewise.
5109 * symfile-debug.c (debug_qf_map_matching_symbols): Change
5110 type; update.
5111 * symfile.h (struct quick_symbol_functions)
5112 <map_matching_symbols>: Change "name" to be a lookup_name_info.
5113 Remove "match".
5114
5115 2019-09-10 Tom Tromey <tromey@adacore.com>
5116
5117 * psymtab.c (map_block): Remove.
5118 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
5119 * symtab.c (iterate_over_symbols_terminated): New function.
5120 * symtab.c (iterate_over_symbols_terminated): Declare.
5121
5122 2019-09-10 Tom Tromey <tromey@adacore.com>
5123
5124 * ada-lang.c (ada_iterate_over_symbols): Return bool.
5125 * language.h (struct language_defn) <la_iterate_over_symbols>:
5126 Return bool.
5127 * symtab.c (iterate_over_symbols): Return bool.
5128 * symtab.h (iterate_over_symbols): Return bool.
5129
5130 2019-09-10 Tom Tromey <tromey@adacore.com>
5131
5132 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
5133 (add_nonlocal_symbols): Update.
5134 * dwarf2read.c (dw2_map_matching_symbols): Change type.
5135 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
5136 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
5137 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
5138 Change type of "callback". Remove "data".
5139
5140
5141 2019-09-09 Ali Tamur <tamur@google.com>
5142
5143 * dwarf2read.c (comp_unit_head): Update comment.
5144 (dwarf2_dwo_name): New function declaration.
5145 (dwarf_unit_type_name): New function declaration.
5146 (read_comp_unit_head): Add support for new compilation units,
5147 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
5148 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5149 (currently named as "signature") in their header. Also clarify error
5150 messages.
5151 (lookup_dwo_id): New function. Returns the dwo id of the given
5152 compile unit.
5153 (lookup_dwo_unit): Use the new lookup_dwo_id function.
5154 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5155 functions.
5156 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5157 (dwarf2_dwo_name): Get the dwo name if present.
5158 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5159 purposes.
5160
5161 2019-09-09 Tom Tromey <tom@tromey.com>
5162
5163 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5164
5165 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5166
5167 * python/python.c (do_start_initialization): Make progname_copy static,
5168 to avoid a leak report.
5169
5170 2019-09-08 Tom Tromey <tom@tromey.com>
5171
5172 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5173
5174 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
5175
5176 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5177 Change type to gdb::optional<block_enum>.
5178 (dw2_symtab_iter_init): Change block_index parameter type
5179 to gdb::optional<block_enum>.
5180 (dw2_lookup_symbol): Change block_index parameter
5181 type to block_enum.c
5182 (dw2_debug_names_lookup_symbol): Likewise.
5183 * psymtab.c (psym_lookup_symbol): Likewise.
5184 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5185 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5186 Likewise.
5187
5188 2019-09-06 Christian Biesinger <cbiesinger@google.com>
5189
5190 * defs.h (relocate_gdb_directory): Change int to bool in
5191 signature and rename flag to relocatable.
5192 * main.c (relocate_path): Likewise.
5193 (relocate_gdb_directory): Likewise.
5194
5195 2019-09-06 Alan Modra <amodra@gmail.com>
5196
5197 * coffread.c (coff_symfile_read): Constify filename variable.
5198 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5199 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5200 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5201 * solib.c (reload_shared_libraries_1): Likewise.
5202 * symfile.c (reread_symbols): Likewise.
5203 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5204 * solib-darwin.c (darwin_bfd_open): Likewise.
5205 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5206
5207 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
5208
5209 * psymtab.c (print_partial_symbols): Handle missing domain_enum
5210 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5211
5212 2019-09-03 Tom Tromey <tromey@adacore.com>
5213
5214 * ada-valprint.c (ada_val_print_num): Don't recurse for range
5215 types.
5216 (has_negatives): Unbias a range type bound.
5217 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5218 * gdbtypes.c (operator==): Handle new field.
5219 (create_range_type): Add "bias" parameter.
5220 (create_static_range_type, resolve_dynamic_range): Update.
5221 * gdbtypes.h (struct range_bounds) <bias>: New member.
5222 (create_range_type): Add bias parameter.
5223 * printcmd.c (print_scalar_formatted): Unbias range types.
5224 * value.c (unpack_long): Unbias range types.
5225 (pack_long): Bias range types.
5226
5227 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5228
5229 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5230 probe arguments.
5231
5232 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5233
5234 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5235 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5236 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5237 (compile_probe_arg): Likewise.
5238 * probe.h (get_argument_count): Likewise.
5239 * solib-svr4.c (solib_event_probe_action): Likewise.
5240 * stap-probe.c (stap_probe::get_argument_count): Likewise.
5241
5242 2019-09-02 Alan Hayward <alan.hayward@arm.com>
5243
5244 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5245 code to here...
5246 (svr4_create_solib_event_breakpoints): ...from here.
5247
5248 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
5249
5250 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5251 suffix from warning message.
5252
5253 2019-08-30 Tom Tromey <tom@tromey.com>
5254
5255 * tui/tui-winsource.h (struct tui_source_window_base)
5256 <refresh_all>: Don't declare.
5257 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5258 Remove.
5259 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5260 tui_show_locator_content.
5261 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5262 declare.
5263 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5264 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5265 declare.
5266
5267 2019-08-30 Tom Tromey <tom@tromey.com>
5268
5269 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5270
5271 2019-08-30 Tom Tromey <tom@tromey.com>
5272
5273 * tui/tui-stack.c (_initialize_tui_stack): Move later.
5274 Remove unnecessary forward declarations.
5275
5276 2019-08-30 Tom Tromey <tom@tromey.com>
5277
5278 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5279 rerender.
5280 (tui_update_locator_fullname, tui_show_frame_info): Don't call
5281 tui_show_locator_content.
5282
5283 2019-08-30 Tom Tromey <tom@tromey.com>
5284
5285 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
5286 (tui_locator_window::rerender): Rewrite using body of previous
5287 tui_show_locator_content.
5288
5289 2019-08-30 Tom Tromey <tom@tromey.com>
5290
5291 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5292 set_locator_fullname>: New methods.
5293 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5294 Rename from tui_set_locator_fullname.
5295 (tui_locator_window::set_locator_info): Rename from
5296 tui_set_locator_info. Return bool.
5297 (tui_update_locator_fullname, tui_show_frame_info): Update.
5298
5299 2019-08-30 Tom Tromey <tom@tromey.com>
5300
5301 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5302
5303 2019-08-30 Tom Tromey <tom@tromey.com>
5304
5305 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5306 call touchwin.
5307
5308 2019-08-30 Tom Tromey <tom@tromey.com>
5309
5310 * tui/tui-wingeneral.c (box_win): Assume win_info and
5311 win_info->handle cannot be NULL.
5312
5313 2019-08-30 Tom Tromey <tom@tromey.com>
5314
5315 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5316 refresh_window>: Declare.
5317 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5318 resize.
5319 (tui_data_item_window::rerender): Rename from
5320 tui_display_register.
5321 (tui_data_item_window::refresh_window): New method.
5322 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5323 no-op.
5324
5325 2019-08-30 Tom Tromey <tom@tromey.com>
5326
5327 * tui/tui-regs.h (struct tui_data_window) <regs_content,
5328 regs_column_count, current_group>: Move later. Now private.
5329 <get_current_group>: New method.
5330 * tui/tui-regs.c (tui_reg_command): Update.
5331 * tui/tui-layout.c (tui_set_layout): Update.
5332
5333 2019-08-30 Tom Tromey <tom@tromey.com>
5334
5335 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5336 (tui_data_window::rerender): Don't call
5337 check_and_display_highlight_if_needed.
5338 (tui_data_window::refresh_all): Remove call to
5339 erase_data_content.
5340
5341 2019-08-30 Tom Tromey <tom@tromey.com>
5342
5343 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5344 (tui_data_window::display_registers_from)
5345 (tui_data_window::display_reg_element_at_line)
5346 (tui_data_window::display_registers_from_line): Remove checks of
5347 "empty".
5348
5349 2019-08-30 Tom Tromey <tom@tromey.com>
5350
5351 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5352 Don't declare.
5353 * tui/tui-regs.c (tui_data_window::show_registers): Call
5354 rerender.
5355 (tui_data_window::rerender): Rename from display_all_data.
5356 (tui_data_window::rerender): Remove old implementation.
5357
5358 2019-08-30 Tom Tromey <tom@tromey.com>
5359
5360 * tui/tui-regs.c (tui_data_window::display_all_data): Change
5361 text.
5362 * tui/tui-data.h (NO_DATA_STRING): Remove define.
5363
5364 2019-08-29 Bernhard Wodok <barto@gmx.net>
5365 Sergio Durigan Junior <sergiodj@redhat.com>
5366
5367 PR win32/24284
5368 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5369
5370 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5371
5372 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5373 when searching for types.
5374
5375 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
5376
5377 * f-lang.c (f_language_defn): Use f_print_typedef.
5378 * f-lang.h (f_print_typedef): Declare.
5379 * f-typeprint.c (f_print_typedef): Define.
5380
5381 2019-08-27 Christian Biesinger <cbiesinger@google.com>
5382
5383 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5384
5385 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
5386
5387 * cli/cli-utils.c (info_print_options_defs): Delete.
5388 (make_info_print_options_def_group): Delete.
5389 (extract_info_print_options): Delete.
5390 (info_print_command_completer): Delete.
5391 (info_print_args_help): Add extra parameter, and optionally
5392 include text about -n flag.
5393 * cli/cli-utils.h (struct info_print_options): Delete.
5394 (extract_info_print_options): Delete declaration.
5395 (info_print_command_completer): Delete declaration.
5396 (info_print_args_help): Add extra parameter, extend header
5397 comment.
5398 * python/python.c (gdbpy_rbreak): Pass additional parameter to
5399 search_symbols.
5400 * stack.c (struct info_print_options): New type.
5401 (info_print_options_defs): New file scoped variable.
5402 (make_info_print_options_def_group): New static function.
5403 (info_print_command_completer): New static function.
5404 (info_locals_command): Update to use new local functions.
5405 (info_args_command): Likewise.
5406 (_initialize_stack): Add extra parameter to calls to
5407 info_print_args_help.
5408 * symtab.c (search_symbols): Add extra parameter, use this to
5409 possibly excluse non-debug symbols.
5410 (symtab_symbol_info): Add extra parameter, which is passed on to
5411 search_symbols.
5412 (struct info_print_options): New type.
5413 (info_print_options_defs): New file scoped variable.
5414 (make_info_print_options_def_group): New static function.
5415 (info_print_command_completer): New static function.
5416 (info_variables_command): Update to use local functions, and pass
5417 extra parameter through to symtab_symbol_info.
5418 (info_functions_command): Likewise.
5419 (info_types_command): Pass additional argument through to
5420 symtab_symbol_info.
5421 (rbreak_command): Pass extra argument to search_symbols.
5422 (_initialize_symtab): Add extra arguments for calls to
5423 info_print_args_help, and update help text for 'info variables',
5424 'whereis', and 'info functions' commands.
5425 * symtab.h (search_symbols): Add extra argument to declaration.
5426 * NEWS: Mention new flags.
5427
5428 2019-08-26 Christian Biesinger <cbiesinger@google.com>
5429
5430 * symtab.c (lookup_static_symbol): Call the new function (and move
5431 it down to be next to lookup_global_symbol).
5432 (struct global_sym_lookup_data): Add block_enum member and rename to...
5433 (struct global_or_static_sym_lookup_data): ...this.
5434 (lookup_symbol_global_iterator_cb): Pass block_index instead of
5435 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5436 (lookup_symbol_global_or_static_iterator_cb): ...this.
5437 (lookup_global_or_static_symbol): New function.
5438 (lookup_global_symbol): Call new function.
5439
5440 2019-08-26 Tom de Vries <tdevries@suse.de>
5441
5442 PR c++/24852
5443 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5444 when pc_probe.prob == NULL.
5445
5446 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5447
5448 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5449 variable symbol_linkage to symbol_linkage_.
5450
5451 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
5452
5453 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5454 represent whether the symbol is static, dynamic, or we don't
5455 know.
5456
5457 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
5458
5459 * gdb/rx-tdep.c (rx_register_names): New.
5460 (rx_register_name): Delete.
5461 (rx_psw_type): Delete.
5462 (rx_fpsw_type): Delete.
5463 (rx_register_type): Delete.
5464 (rx_gdbarch_init): Convert target-descriptions.
5465 (_initialize_rx_tdep): Add initialize_tdesc_rx.
5466 * gdb/features/Makefile: Add rx.xml.
5467 * gdb/features/rx.xml: New.
5468 * gdb/features/rx.c: Generated.
5469 * gdb/NEWS: Mention target description support.
5470
5471 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5472
5473 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5474 *slot_ptr.
5475
5476 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
5477
5478 * configure.ac: Don't check for 'dlfcn.h' (moved to
5479 gdbsupport/common.m4).
5480 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5481 'gdbsupport/'.
5482 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5483 * compile/compile-c-support.c: Include
5484 'gdbsupport/gdb-dlfcn.h'.
5485 * gdbsupport/common.m4: Check for 'dlfcn.h'.
5486 * gdb-dlfcn.c: Move to...
5487 * gdbsupport/gdb-dlfcn.c: ... here.
5488 * gdb-dlfcn.h: Move to...
5489 * gdbsupport/gdb-dlfcn.h: ... here.
5490
5491 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
5492
5493 * nios2-tdep.c (struct reg_value): Improve comments. Make
5494 the offset field signed.
5495
5496 2019-08-22 Christian Biesinger <cbiesinger@google.com>
5497
5498 * python/lib/gdb/__init__.py (_execute_file): New function.
5499 * python/python.c (python_run_simple_file): Call gdb._execute_file
5500 on Windows.
5501
5502 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
5503
5504 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5505 all uses as this was never set to anything but a zero value.
5506
5507 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
5508
5509 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5510
5511 2019-08-21 Christian Biesinger <cbiesinger@google.com>
5512
5513 * tui/tui-data.h (tui_gen_win_info): Add an =default
5514 move constructor, required by some GCC versions.
5515
5516 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
5517
5518 * go32-nat.c (go32_sysinfo): Add hygon_p.
5519
5520 2019-08-20 Tom Tromey <tom@tromey.com>
5521
5522 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5523 line_from_reg_element_no, first_reg_element_no_inline,
5524 display_all_data, delete_data_content_windows,
5525 erase_data_content>: Now private.
5526
5527 2019-08-20 Tom Tromey <tom@tromey.com>
5528
5529 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5530 (tui_unhighlight_win, tui_highlight_win)
5531 (tui_win_info::make_window): Update.
5532 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5533
5534 2019-08-20 Tom Tromey <tom@tromey.com>
5535
5536 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5537 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5538 (MAX_PID_WIDTH): Move to tui-stack.c.
5539 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5540 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5541 (MAX_PID_WIDTH): Move from tui-data.h.
5542
5543 2019-08-20 Tom Tromey <tom@tromey.com>
5544
5545 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5546 * tui/tui-wingeneral.c (box_win): Change type of win_info.
5547 (box_win): Update.
5548 (tui_gen_win_info::make_window): Rename from tui_make_window.
5549 (tui_win_info::make_window): New method.
5550 (tui_gen_win_info::make_visible): Update.
5551 * tui/tui-source.c (tui_source_window::set_contents): Update.
5552 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5553 (tui_data_window::display_registers_from): Update.
5554 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5555 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5556 Declare.
5557 <can_box>: Remove.
5558 <title>: Remove.
5559 (struct tui_win_info) <make_window>: Declare.
5560 <can_box>: Now virtual.
5561 <title>: New member.
5562 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5563 * tui/tui-command.c (tui_cmd_window::resize): Update.
5564
5565 2019-08-20 Tom Tromey <tom@tromey.com>
5566
5567 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5568 * tui/tui-regs.c (tui_data_window::show_registers): Update.
5569 (tui_data_window::check_register_values): Update.
5570
5571 2019-08-20 Tom Tromey <tom@tromey.com>
5572
5573 * tui/tui-regs.h (struct tui_data_window): Use
5574 DISABLE_COPY_AND_ASSIGN.
5575 <regs_content>: Change type, removing unique_ptr.
5576 <tui_data_window>: Add move constructor.
5577 * tui/tui-regs.c (tui_data_window::show_registers)
5578 (tui_data_window::show_register_group)
5579 (tui_data_window::display_registers_from)
5580 (tui_data_window::display_registers_from)
5581 (tui_data_window::first_data_item_displayed)
5582 (tui_data_window::delete_data_content_windows)
5583 (tui_data_window::rerender, tui_data_window::refresh_window)
5584 (tui_data_window::check_register_values): Update.
5585
5586 2019-08-20 Tom Tromey <tom@tromey.com>
5587
5588 * tui/tui-regs.h (struct tui_data_window) <show_registers,
5589 show_register_group>: Declare.
5590 (tui_show_register_group): Don't declare.
5591 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5592 tui_show_registers.
5593 (tui_data_window::show_register_group): Rename from
5594 tui_show_register_group.
5595 (tui_data_window::check_register_values, tui_reg_command):
5596 Update.
5597 * tui/tui-layout.c (tui_set_layout): Update.
5598
5599 2019-08-20 Tom Tromey <tom@tromey.com>
5600
5601 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5602 Declare.
5603 (tui_check_register_values): Don't declare.
5604 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5605 from tui_check_register_values.
5606 * tui/tui-hooks.c (tui_register_changed): Update.
5607
5608 2019-08-20 Tom Tromey <tom@tromey.com>
5609
5610 * tui/tui-regs.c (tui_reg_layout): Move later.
5611 (tui_show_registers): Don't enable TUI mode or change layout.
5612
5613 2019-08-20 Tom Tromey <tom@tromey.com>
5614
5615 * tui/tui-regs.h (struct tui_data_item_window)
5616 <~tui_data_item_window>: Remove.
5617 <content>: Now a unique_xmalloc_ptr.
5618 * tui/tui-regs.c (tui_register_format): Return a
5619 unique_xmalloc_ptr.
5620 (tui_get_register): Update.
5621 (~tui_data_item_window): Remove.
5622 (tui_data_window::display_registers_from, tui_display_register):
5623 Update.
5624 * tui/tui-io.h (tui_expand_tabs): Update.
5625 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5626 Remove "col" parameter.
5627
5628 2019-08-20 Tom Tromey <tom@tromey.com>
5629
5630 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5631 field.
5632 * tui/tui-regs.c (~tui_data_item_window): Update.
5633
5634 2019-08-20 Tom Tromey <tom@tromey.com>
5635
5636 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5637 earlier.
5638
5639 2019-08-20 Tom Tromey <tom@tromey.com>
5640
5641 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5642
5643 2019-08-20 Tom Tromey <tom@tromey.com>
5644
5645 * tui/tui-source.h (struct tui_source_window): Update.
5646 * tui/tui-regs.c (tui_show_registers): Update.
5647 * tui/tui-disasm.h (struct tui_disasm_window): Update.
5648 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5649 (NO_REGS_STRING): Remove defines.
5650
5651 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
5652
5653 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5654 unnecessary thread walk if remote doesn't support the packet.
5655
5656 2019-08-19 Tom Tromey <tromey@adacore.com>
5657
5658 * python/py-value.c (value_has_field): Fix indentation.
5659
5660 2019-08-19 Tom Tromey <tromey@adacore.com>
5661
5662 * printcmd.c (do_one_display, info_display_command): Update.
5663 * block.h (contained_in): Return bool. Add allow_nested
5664 parameter.
5665 * block.c (contained_in): Return bool. Add allow_nested
5666 parameter.
5667
5668 2019-08-19 Tom Tromey <tom@tromey.com>
5669
5670 * configure: Rebuild.
5671 * configure.ac: Disallow the combination of -static-libstdc++ and
5672 source highlight.
5673 * source-cache.c (get_language_name): Handle rust.
5674 (source_cache::get_source_lines): Ignore highlighting exceptions.
5675
5676 2019-08-16 Tom Tromey <tom@tromey.com>
5677
5678 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5679 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5680 (struct tui_source_window_base) <make_visible, refresh_window,
5681 resize>: Remove methods.
5682 <execution_info>: Remove field.
5683 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5684 (tui_show_source_line, tui_source_window_base)
5685 (~tui_source_window_base): Update.
5686 (tui_source_window_base::resize)
5687 (tui_source_window_base::make_visible)
5688 (tui_source_window_base::refresh_window): Remove.
5689 (tui_source_window_base::update_exec_info): Update.
5690 * tui/tui-source.c (tui_source_window::set_contents): Update.
5691 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5692
5693 2019-08-16 Tom Tromey <tom@tromey.com>
5694
5695 * tui/tui-hooks.c (tui_remove_hooks): Don't set
5696 deprecated_query_hook.
5697
5698 2019-08-16 Tom Tromey <tom@tromey.com>
5699
5700 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5701 (tui_update_source_windows_with_line): Update.
5702 * tui/tui-source.h (struct tui_source_window)
5703 <show_symtab_source>: Declare.
5704 (tui_show_symtab_source): Don't declare.
5705 * tui/tui-source.c (tui_show_symtab_source): Rename from
5706 tui_show_symtab_source.
5707
5708 2019-08-16 Tom Tromey <tom@tromey.com>
5709
5710 * tui/tui-winsource.h (struct tui_source_window_base)
5711 <set_contents>: Declare.
5712 * tui/tui-winsource.c
5713 (tui_source_window_base::update_source_window_as_is): Update.
5714 * tui/tui-source.h (struct tui_source_window) <set_contents>:
5715 Declare.
5716 (tui_set_source_content): Don't declare.
5717 * tui/tui-source.c (tui_source_window::set_contents): Rename from
5718 tui_set_source_content.
5719 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5720 Declare.
5721 (tui_set_disassem_content): Don't declare.
5722 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5723 tui_set_disassem_content.
5724
5725 2019-08-16 Tom Tromey <tom@tromey.com>
5726
5727 * tui/tui-winsource.h (struct tui_source_window_base)
5728 <update_breakpoint_info>: Declare.
5729 (tui_update_breakpoint_info): Don't declare.
5730 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5731 (tui_update_all_breakpoint_info): Update.
5732 (tui_source_window_base::update_breakpoint_info): Rename from
5733 tui_update_breakpoint_info.
5734 (tui_source_window_base::update_exec_info): Update.
5735
5736 2019-08-16 Tom Tromey <tom@tromey.com>
5737
5738 * tui/tui-winsource.h (struct tui_source_window_base)
5739 <update_source_window>: Declare.
5740 (tui_update_source_window): Don't declare.
5741 * tui/tui-winsource.c
5742 (tui_source_window_base::update_source_window): Rename from
5743 tui_update_source_window.
5744 (tui_source_window_base::rerender): Update.
5745 * tui/tui-source.c (tui_source_window::maybe_update): Update.
5746 * tui/tui-disasm.c (tui_show_disassem)
5747 (tui_show_disassem_and_update_source)
5748 (tui_disasm_window::maybe_update): Update.
5749
5750 2019-08-16 Tom Tromey <tom@tromey.com>
5751
5752 * tui/tui-winsource.h (struct tui_source_window_base)
5753 <update_source_window_as_is>: Declare.
5754 (tui_update_source_window_as_is): Don't declare.
5755 * tui/tui-winsource.c (tui_update_source_window): Update
5756 (tui_source_window_base::update_source_window_as_is): Rename from
5757 tui_update_source_window_as_is.
5758 (tui_source_window_base::refill): Update.
5759 * tui/tui-source.c (tui_show_symtab_source): Update.
5760 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5761 Update.
5762
5763 2019-08-16 Tom Tromey <tom@tromey.com>
5764
5765 * tui/tui-winsource.h (tui_update_source_window)
5766 (tui_update_source_window_as_is): Remove "noerror" parameter.
5767 * tui/tui-winsource.c (tui_update_source_window)
5768 (tui_update_source_window_as_is): Remove "noerror" parameter.
5769 (tui_update_source_windows_with_addr)
5770 (tui_update_source_windows_with_line)
5771 (tui_source_window_base::rerender)
5772 (tui_source_window_base::refill): Update.
5773 * tui/tui-source.h (tui_set_source_content)
5774 (tui_show_symtab_source): Remove "noerror" parameter.
5775 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5776 parameter.
5777 (tui_show_symtab_source): Likewise.
5778 (tui_source_window::maybe_update): Update.
5779 * tui/tui-disasm.c (tui_show_disassem)
5780 (tui_show_disassem_and_update_source)
5781 (tui_disasm_window::do_scroll_vertical)
5782 (tui_disasm_window::maybe_update): Update.
5783
5784 2019-08-16 Tom Tromey <tom@tromey.com>
5785
5786 * tui/tui.c (tui_is_window_visible): Update.
5787 * tui/tui-wingeneral.c (tui_make_window)
5788 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5789 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5790 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5791 (tui_set_win_height_command, parse_scrolling_args): Update.
5792 * tui/tui-source.c (tui_source_window::style_changed): Update.
5793 * tui/tui-regs.c (tui_show_registers)
5794 (tui_data_window::first_data_item_displayed)
5795 (tui_data_window::delete_data_content_windows)
5796 (tui_check_register_values, tui_reg_command): Update.
5797 * tui/tui-disasm.c (tui_show_disassem): Update.
5798 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5799 method.
5800 <is_visible>: Remove field.
5801 * tui/tui-data.c (tui_next_win, tui_prev_win)
5802 (tui_delete_invisible_windows): Update.
5803
5804 2019-08-16 Tom Tromey <tom@tromey.com>
5805
5806 * tui/tui-winsource.h (struct tui_source_window_base)
5807 <m_has_locator>: Remove.
5808 * tui/tui-layout.c (show_source_disasm_command, show_data)
5809 (show_source_or_disasm_and_command): Update.
5810
5811 2019-08-16 Alan Hayward <alan.hayward@arm.com>
5812
5813 * NEWS (Other MI changes): New subsection.
5814 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5815 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5816 * arch-utils.c (default_get_pc_address_flags): New function.
5817 * arch-utils.h (default_get_pc_address_flags): New declaration.
5818 * gdbarch.sh: Add get_pc_address_flags.
5819 * gdbarch.c: Regenerate.
5820 * gdbarch.h: Likewise.
5821 * stack.c (print_pc): New function.
5822 (print_frame_info) (print_frame): Call print_pc.
5823
5824 2019-08-16 Tom de Vries <tdevries@suse.de>
5825
5826 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5827 print_objfile_section_info.
5828
5829 2019-08-15 Tom Tromey <tom@tromey.com>
5830
5831 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5832 calling update_cmdwin_start_line.
5833 * tui/tui-winsource.h (struct tui_source_window_base)
5834 <do_make_visible_with_new_height, set_new_height>: Don't declare.
5835 <rerender>: Declare.
5836 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5837 Call rerender.
5838 (tui_source_window_base::set_new_height): Remove.
5839 (tui_source_window_base::rerender): Rename from
5840 do_make_visible_with_new_height.
5841 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5842 resize method.
5843 (tui_win_info::make_invisible_and_set_new_height)
5844 (tui_win_info::make_visible_with_new_height): Remove.
5845 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5846 Declare.
5847 * tui/tui-stack.c (tui_locator_window::rerender): New method.
5848 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5849 do_make_visible_with_new_height>: Don't declare.
5850 <rerender>: Declare.
5851 * tui/tui-regs.c (tui_data_window::rerender): Rename from
5852 set_new_height.
5853 (tui_data_window::do_make_visible_with_new_height): Remove.
5854 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5855 call tui_show_locator_content.
5856 (tui_gen_win_info::resize): Call rerender.
5857 (show_source_or_disasm_and_command): Don't call
5858 tui_show_locator_content.
5859 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5860 method.
5861 (struct tui_win_info) <rerender>: Declare.
5862 <set_new_height, make_invisible_and_set_new_height,
5863 make_visible_with_new_height>: Don't declare.
5864 * tui/tui-data.c (tui_win_list::rerender): New method.
5865 * tui/tui-command.h (struct tui_cmd_window)
5866 <do_make_visible_with_new_height>: Don't declare.
5867 * tui/tui-command.c
5868 (tui_cmd_window::do_make_visible_with_new_height): Remove.
5869
5870 2019-08-15 Tom Tromey <tromey@adacore.com>
5871
5872 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5873 * ada-lang.c (ada_enum_name): Likewise.
5874
5875 2019-08-15 Christian Biesinger <cbiesinger@google.com>
5876
5877 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5878 leading underscore.
5879 (GdbOutputErrorFile): Likewise.
5880 (global scope): Adjust constructor calls to GdbOutput{,Error}File
5881 accordingly.
5882 (execute_unwinders): Rename to have a leading underscore.
5883 (auto_load_packages): Likewise.
5884 (global scope): Adjust call to auto_load_packages accordingly.
5885 (GdbSetPythonDirectory): Likewise.
5886 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5887 instead of execute_unwinders.
5888
5889 2019-08-15 Tom Tromey <tom@tromey.com>
5890
5891 * tui/tui-layout.c (show_layout, show_source_disasm_command)
5892 (show_data): Don't change window visibility.
5893 (tui_gen_win_info::resize): Remove special case for command
5894 window. Use wresize, when available.
5895 (show_source_or_disasm_and_command): Don't change window
5896 visibility.
5897 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5898 <make_visible>: New method.
5899 * tui/tui-command.c (tui_cmd_window::resize): New method.
5900
5901 2019-08-15 Tom Tromey <tom@tromey.com>
5902
5903 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5904 (struct tui_source_windows): New.
5905 * tui/tui-winsource.c (tui_display_main): Update.
5906 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5907 (new_height_ok, parse_scrolling_args): Update.
5908 * tui/tui-layout.c (show_layout, show_data): Update.
5909 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5910 (tui_add_to_source_windows): Don't declare.
5911 * tui/tui-data.c (source_windows, tui_source_windows)
5912 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5913
5914 2019-08-15 Tom Tromey <tom@tromey.com>
5915
5916 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5917 Rename from reset.
5918 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5919 * tui/tui-layout.c (show_source_disasm_command, show_data):
5920 Update.
5921 (tui_gen_win_info::resize): Rename.
5922 (show_source_or_disasm_and_command): Update.
5923 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5924 reset.
5925
5926 2019-08-15 Tom Tromey <tom@tromey.com>
5927
5928 * tui/tui-stack.c (tui_initialize_static_data): Remove.
5929 * tui/tui-interp.c (tui_interp::init): Don't call
5930 tui_initialize_static_data.
5931 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5932
5933 2019-08-15 Tom Tromey <tom@tromey.com>
5934
5935 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5936 examine tui_win_list.
5937
5938 2019-08-15 Tom Tromey <tom@tromey.com>
5939
5940 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5941 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5942 tui_clear_source_content.
5943 (tui_clear_source_content): Remove.
5944 (tui_source_window_base::do_erase_source_content): Hoist call to
5945 content.clear().
5946 * tui/tui-stack.c (tui_show_frame_info): Don't call
5947 tui_clear_source_content.
5948
5949 2019-08-15 Tom Tromey <tom@tromey.com>
5950
5951 * tui/tui-winsource.h (struct tui_source_window_base)
5952 <do_erase_source_content>: New method.
5953 <erase_source_content>: New method.
5954 (tui_erase_source_content): Don't declare.
5955 * tui/tui-winsource.c (tui_clear_source_content): Update.
5956 (tui_source_window_base::do_erase_source_content): Rename from
5957 tui_erase_source_content.
5958 (tui_source_window_base::show_source_content): Update.
5959 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5960 * tui/tui-source.h (struct tui_source_window)
5961 <erase_source_content>: New method.
5962 * tui/tui-disasm.h (struct tui_disasm_window)
5963 <erase_source_content>: New method.
5964
5965 2019-08-15 Tom Tromey <tom@tromey.com>
5966
5967 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5968 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5969 constructor.
5970 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5971 * tui/tui-source.c (tui_set_source_content): Update.
5972 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5973
5974 2019-08-15 Tom Tromey <tom@tromey.com>
5975
5976 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5977 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5978 tui-source.c.
5979 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5980 Declare.
5981 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5982 method.
5983 (tui_source_window::maybe_update): Update.
5984
5985 2019-08-15 Tom Tromey <tom@tromey.com>
5986
5987 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5988 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5989 tui-disasm.c.
5990 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5991 Declare.
5992 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5993 method.
5994 (tui_disasm_window::maybe_update): Update.
5995
5996 2019-08-15 Tom Tromey <tom@tromey.com>
5997
5998 * tui/tui-winsource.h (struct tui_source_window_base)
5999 <maybe_update>: Declare.
6000 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
6001 method.
6002 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
6003 Declare.
6004 * tui/tui-source.c (tui_source_window::maybe_update): New method.
6005 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
6006 Declare.
6007 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
6008
6009 2019-08-15 Tom Tromey <tom@tromey.com>
6010
6011 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
6012
6013 2019-08-15 Tom Tromey <tom@tromey.com>
6014
6015 * tui/tui-wingeneral.c: Include tui-stack.h.
6016 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
6017 (struct tui_locator_window): Move from tui-data.h.
6018 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
6019 (tui_initialize_static_data): Move from tui-data.c.
6020 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
6021 (struct tui_locator_window): Move to tui-stack.c.
6022 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
6023 (tui_initialize_static_data): Move to tui-stack.c.
6024
6025 2019-08-15 Tom Tromey <tom@tromey.com>
6026
6027 * tui/tui-layout.c (show_source_disasm_command)
6028 (show_source_or_disasm_and_command): Use make_visible method, not
6029 tui_make_window.
6030 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
6031 Remove.
6032
6033 2019-08-15 Tom Tromey <tom@tromey.com>
6034
6035 * tui/tui-wingeneral.h (tui_make_window): Update.
6036 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
6037 parameter.
6038 (tui_gen_win_info::make_visible): Update.
6039 * tui/tui-regs.c (tui_data_window::display_registers_from):
6040 Update.
6041 * tui/tui-layout.c (show_source_disasm_command)
6042 (show_source_or_disasm_and_command): Update.
6043 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
6044 (enum tui_box): Remove.
6045 (struct tui_win_info) <can_box>: New method.
6046 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
6047 method.
6048
6049 2019-08-15 Tom de Vries <tdevries@suse.de>
6050
6051 * linux-nat-trad.c: Include gdbarch.h.
6052
6053 2019-08-14 Alan Hayward <alan.hayward@arm.com>
6054
6055 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
6056 register sizes.
6057
6058 2019-08-14 Tom Tromey <tromey@adacore.com>
6059
6060 * darwin-nat.c: Include gdbarch.h.
6061 * darwin-nat-info.c: Include gdbarch.h.
6062
6063 2019-08-13 Tom Tromey <tom@tromey.com>
6064
6065 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
6066 Remove.
6067 * tui/tui-data.c (tui_initialize_static_data): Update.
6068
6069 2019-08-13 Tom Tromey <tom@tromey.com>
6070
6071 * tui/tui-winsource.h (struct tui_exec_info_window)
6072 <~tui_exec_info_window, maybe_allocate_content, get_content,
6073 m_content>: Remove.
6074 (struct tui_source_window_base) <set_exec_info_content,
6075 show_exec_info_content>: Don't declare.
6076 * tui/tui-winsource.c
6077 (tui_exec_info_window::maybe_allocate_content): Remove.
6078 (tui_source_window_base::update_exec_info): Rename from
6079 set_exec_info_content.
6080 (tui_source_window_base::show_exec_info_content)
6081 (tui_source_window_base::update_exec_info): Remove.
6082
6083 2019-08-13 Tom Tromey <tom@tromey.com>
6084
6085 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
6086 declare.
6087 * tui/tui-winsource.c (tui_update_source_window_as_is)
6088 (tui_update_source_windows_with_addr, tui_erase_source_content):
6089 Update.
6090 (tui_clear_exec_info_content): Remove.
6091
6092 2019-08-13 Tom Tromey <tom@tromey.com>
6093
6094 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
6095 declare.
6096 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
6097 call tui_erase_exec_info_content.
6098 (tui_clear_exec_info_content): Rename from
6099 tui_erase_exec_info_content.
6100 (tui_clear_exec_info_content): Delete.
6101
6102 2019-08-13 Tom Tromey <tom@tromey.com>
6103
6104 * tui/tui-winsource.h (struct tui_source_window_base)
6105 <show_exec_info_content>: Declare.
6106 (tui_show_exec_info_content): Don't declare.
6107 * tui/tui-winsource.c
6108 (tui_source_window_base::show_exec_info_content): Rename from
6109 tui_show_exec_info_content.
6110 (tui_source_window_base::update_exec_info): Update.
6111
6112 2019-08-13 Tom Tromey <tom@tromey.com>
6113
6114 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
6115 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
6116 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
6117 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
6118 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
6119 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
6120 ... here.
6121
6122 2019-08-13 Tom Tromey <tom@tromey.com>
6123
6124 * tui/tui-winsource.h (struct tui_source_window_base)
6125 <update_exec_info>: Declare.
6126 (tui_update_exec_info): Don't declare.
6127 * tui/tui-winsource.c (tui_update_source_window_as_is)
6128 (tui_source_window_base::refresh_all)
6129 (tui_update_all_breakpoint_info): Update.
6130 (tui_source_window_base::update_exec_info): Rename from
6131 tui_update_exec_info.
6132 * tui/tui-stack.c (tui_show_frame_info): Update.
6133
6134 2019-08-13 Tom Tromey <tom@tromey.com>
6135
6136 * tui/tui-winsource.h (struct tui_source_window_base)
6137 <set_exec_info_content>: Declare.
6138 (tui_set_exec_info_content): Don't declare.
6139 * tui/tui-winsource.c
6140 (tui_source_window_base::set_exec_info_content): Rename from
6141 tui_set_exec_info_content.
6142 (tui_update_exec_info): Update.
6143
6144 2019-08-13 Tom Tromey <tom@tromey.com>
6145
6146 * tui/tui-winsource.h (struct tui_source_window_base)
6147 <show_source_content>: Declare.
6148 (tui_show_source_content): Don't declare.
6149 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6150 (tui_source_window_base::show_source_content): Rename from
6151 tui_show_source_content.
6152 (tui_source_window_base::refresh_all): Update.
6153 * tui/tui-layout.c (show_source_disasm_command)
6154 (show_source_or_disasm_and_command): Update.
6155
6156 2019-08-13 Tom Tromey <tom@tromey.com>
6157
6158 * tui/tui-winsource.c (tui_erase_source_content)
6159 (tui_show_source_content, tui_source_window_base::refresh_all):
6160 Update.
6161 * tui/tui-wingeneral.h
6162 (tui_check_and_display_highlight_if_needed): Don't declare.
6163 * tui/tui-wingeneral.c
6164 (tui_win_info::check_and_display_highlight_if_needed): Rename from
6165 check_and_display_highlight_if_needed.
6166 * tui/tui-win.c (tui_rehighlight_all)
6167 (tui_win_info::make_visible_with_new_height): Update.
6168 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6169 (tui_data_window::erase_data_content)
6170 (tui_data_window::display_all_data): Update.
6171 * tui/tui-data.h (struct tui_win_info)
6172 <check_and_display_highlight_if_needed>: Declare.
6173
6174 2019-08-13 Tom Tromey <tom@tromey.com>
6175
6176 * tui/tui-win.c (tui_resize_all): Call
6177 tui_delete_invisible_windows.
6178 * tui/tui-layout.c (show_layout): Call
6179 tui_delete_invisible_windows.
6180 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6181 * tui/tui-data.c (tui_delete_invisible_windows): New function.
6182
6183 2019-08-13 Tom Tromey <tom@tromey.com>
6184
6185 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
6186 tui_add_win_to_layout.
6187
6188 2019-08-13 Tom Tromey <tom@tromey.com>
6189
6190 * tui/tui-layout.h (tui_default_win_height): Don't declare.
6191 * tui/tui-layout.c (tui_default_win_height): Now static.
6192
6193 2019-08-13 Tom Tromey <tom@tromey.com>
6194
6195 * tui/tui-layout.c (show_layout): Unify all layout cases into a
6196 single switch.
6197 (show_source_disasm_command, show_source_or_disasm_and_command):
6198 Don't check current layout.
6199
6200 2019-08-13 Tom Tromey <tom@tromey.com>
6201
6202 * tui/tui-wingeneral.c (make_all_visible): Remove.
6203 (tui_make_all_invisible): Simplify.
6204 * tui/tui-layout.c (tui_make_all_invisible): Move from
6205 tui-wingeneral.c; simplify.
6206 (show_layout): Hoist call to tui_make_all_invisible.
6207 (show_data): Don't call tui_make_all_invisible.
6208
6209 2019-08-13 Tom Tromey <tom@tromey.com>
6210
6211 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6212 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6213
6214 2019-08-13 Tom Tromey <tom@tromey.com>
6215
6216 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6217 tui-data.c.
6218 (show_source_disasm_command, show_data)
6219 (show_source_or_disasm_and_command): Don't use
6220 tui_set_current_layout_to.
6221 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6222 * tui/tui-data.c (current_layout, tui_current_layout): Move to
6223 tui-layout.c.
6224 (tui_set_current_layout_to): Remove.
6225
6226 2019-08-13 Tom Tromey <tom@tromey.com>
6227
6228 * tui/tui-layout.c (tui_set_layout): Update.
6229 * tui/tui-data.h (struct tui_layout_def): Remove.
6230 (tui_layout_def): Don't declare.
6231 * tui/tui-data.c (layout_def): Remove.
6232 (tui_layout_def): Remove.
6233
6234 2019-08-13 Tom Tromey <tom@tromey.com>
6235
6236 * tui/tui-winsource.h (struct tui_source_window_base)
6237 <clear_detail>: No longer "override".
6238 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6239 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6240 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6241 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6242 Remove.
6243 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6244
6245 2019-08-13 Tom Tromey <tromey@adacore.com>
6246
6247 * tracepoint.c: Don't include readline.h or history.h.
6248
6249 2019-08-12 Tom Tromey <tom@tromey.com>
6250
6251 * configure: Rebuild.
6252 * configure.ac: Check for readline 7.
6253 * NEWS: Mention readline 7 requirement.
6254 * README: Update.
6255
6256 2019-08-12 Tom Tromey <tom@tromey.com>
6257
6258 * mingw-hdep.c (gdb_select): Remove readline hack.
6259
6260 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
6261
6262 * blockframe.c (find_pc_partial_function): Set *block to nullptr
6263 when the function fails.
6264
6265 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
6266
6267 * s390-tdep.c (s390_type_align): New function.
6268 (s390_gdbarch_init): Set it as type_align gdbarch method.
6269
6270 2019-08-09 Tom de Vries <tdevries@suse.de>
6271
6272 PR gdb/24591
6273 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6274 pc_low with relocation offset.
6275
6276 2019-08-07 Tom Tromey <tromey@adacore.com>
6277
6278 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6279 (print_frame_args): Update.
6280 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6281 Update.
6282 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6283 * frame.h (struct frame_arg): Add initializers.
6284 <error>: Now a unique_xmalloc_ptr.
6285
6286 2019-08-07 Alan Hayward <alan.hayward@arm.com>
6287
6288 * NEWS: Expand the Pointer Authentication entry.
6289 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6290 (aarch64_frame_unmask_lr): ... to this.
6291 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6292 Call aarch64_frame_unmask_lr.
6293 * frame.c (struct frame_info): Add "masked" variable.
6294 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6295 (fprint_frame): Check for masked pc.
6296 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6297 declarations.
6298 * python/py-framefilter.c (py_print_frame): Check for masked pc.
6299 * stack.c (print_frame): Check for masked pc.
6300
6301 2019-08-06 Tom Tromey <tom@tromey.com>
6302
6303 * stabsread.c (patch_block_stabs, read_one_struct_field)
6304 (read_enum_type): Use obstack_strndup.
6305 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6306 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6307 * dwarf2read.c (guess_full_die_structure_name)
6308 (anonymous_struct_prefix): Use obstack_strndup.
6309 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6310 * c-exp.y (yylex): Use obstack_strndup.
6311 * ada-exp.y (write_object_renaming, write_ambiguous_var)
6312 (write_var_or_type): Use obstack_strndup.
6313
6314 2019-08-06 Tom Tromey <tom@tromey.com>
6315
6316 * symfile.c (reread_symbols): Use obstack_strdup.
6317 * stabsread.c (read_type): Use obstack_strdup.
6318 * gdb_obstack.h (obstack_strdup): New overload.
6319 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6320 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6321 (dwarf2_canonicalize_name): Use obstack_strdup.
6322 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6323 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6324 Use obstack_strdup.
6325
6326 2019-08-06 Tom Tromey <tom@tromey.com>
6327
6328 * gdb_obstack.h (obstack_strdup): Define.
6329 * gdb_obstack.c (obstack_strdup): Don't define.
6330
6331 2019-08-06 Tom Tromey <tom@tromey.com>
6332
6333 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6334 obstack_strdup.
6335 * typeprint.c (typedef_hash_table::find_global_typedef): Use
6336 obstack_strdup.
6337 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6338 * stabsread.c (common_block_start): Use obstack_strdup.
6339 * objfiles.c (set_objfile_main_name, objfile): Use
6340 obstack_strdup.
6341 * namespace.c (add_using_directive): Use obstack_strdup.
6342 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6343 * jit.c (finalize_symtab): Use obstack_strdup.
6344 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6345 (guess_partial_die_structure_name, partial_die_info::fixup)
6346 (dwarf2_name): Use obstack_strdup.
6347 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6348 obstack_strdup.
6349 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6350 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6351 obstack_strdup.
6352 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6353
6354 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6355
6356 * unittests/help-doc-selftests.c: New file.
6357 * Makefile.in: Add the new file.
6358
6359 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6360
6361 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6362 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
6363 the full first line, except when FOR_VALUE_PREFIX. In this case,
6364 the trailing '.' is not output, and the first character is uppercased.
6365 (print_help_for_command): Update call to print_doc_line.
6366 (print_doc_of_command): Likewise.
6367 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6368 * cli/cli-option.c (append_indented_doc): Do not append newline.
6369 (build_help_option): Append newline after first appended_indented_doc
6370 only if a second call is done.
6371 (build_help): Append 2 new lines before each option, except the first
6372 one.
6373 * compile/compile.c (_initialize_compile): Add new lines after
6374 %OPTIONS%, when not at the end of the help.
6375 Change help doc or code
6376 producing the help doc to respect the invariants.
6377 * maint-test-options.c (_initialize_maint_test_options): Likewise.
6378 Also removed the new line after 'Options:', as all other commands
6379 do not put an empty line between 'Options:' and the first option.
6380 * printcmd.c (_initialize_printcmd): Likewise.
6381 * stack.c (_initialize_stack): Likewise.
6382 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6383 incorrectly telling COMMAND is optional.
6384 * ada-lang.c (_initialize_ada_language): Change help doc or code
6385 producing the help doc to respect the invariants.
6386 * ada-tasks.c (_initialize_ada_tasks): Likewise.
6387 * breakpoint.c (_initialize_breakpoint): Likewise.
6388 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6389 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6390 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6391 * cli/cli-style.c (cli_style_option::add_setshow_commands,
6392 _initialize_cli_style): Likewise.
6393 * corelow.c (core_target_info): Likewise.
6394 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6395 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6396 * filesystem.c (_initialize_filesystem): Likewise.
6397 * frame.c (_initialize_frame): Likewise.
6398 * gnu-nat.c (add_task_commands): Likewise.
6399 * infcall.c (_initialize_infcall): Likewise.
6400 * infcmd.c (_initialize_infcmd): Likewise.
6401 * interps.c (_initialize_interpreter): Likewise.
6402 * language.c (_initialize_language): Likewise.
6403 * linux-fork.c (_initialize_linux_fork): Likewise.
6404 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6405 * maint.c (_initialize_maint_cmds): Likewise.
6406 * memattr.c (_initialize_mem): Likewise.
6407 * printcmd.c (_initialize_printcmd): Likewise.
6408 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6409 _RegEx): Likewise.
6410 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6411 * record-btrace.c (_initialize_record_btrace): Likewise.
6412 * record-full.c (_initialize_record_full): Likewise.
6413 * record.c (_initialize_record): Likewise.
6414 * regcache-dump.c (_initialize_regcache_dump): Likewise.
6415 * regcache.c (_initialize_regcache): Likewise.
6416 * remote.c (add_packet_config_cmd, init_remote_threadtests,
6417 _initialize_remote): Likewise.
6418 * ser-tcp.c (_initialize_ser_tcp): Likewise.
6419 * serial.c (_initialize_serial): Likewise.
6420 * skip.c (_initialize_step_skip): Likewise.
6421 * source.c (_initialize_source): Likewise.
6422 * stack.c (_initialize_stack): Likewise.
6423 * symfile.c (_initialize_symfile): Likewise.
6424 * symtab.c (_initialize_symtab): Likewise.
6425 * target-descriptions.c (_initialize_target_descriptions): Likewise.
6426 * top.c (init_main): Likewise.
6427 * tracefile-tfile.c (tfile_target_info): Likewise.
6428 * tracepoint.c (_initialize_tracepoint): Likewise.
6429 * tui/tui-win.c (_initialize_tui_win): Likewise.
6430 * utils.c (add_internal_problem_command): Likewise.
6431 * valprint.c (value_print_option_defs): Likewise.
6432
6433 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
6434
6435 PR build/24886
6436 * configure.ac: Drop enable-libmcheck support.
6437 * configure, config.in: Rebuild.
6438 * libmcheck.m4: Remove.
6439 * acinclude.m4: Don't include it.
6440 * Makefile.in: Don't distribute it.
6441 * top.c (print_gdb_configuration): Don't mention it.
6442
6443 2019-08-06 Tom Tromey <tom@tromey.com>
6444
6445 * utils.c (set_output_style): Sometimes pass stream to
6446 emit_style_escape.
6447 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6448 * record-btrace.c (btrace_insn_history): Update.
6449 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6450 method.
6451 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6452 Update initializers.
6453 <m_uiout>: New field.
6454 <m_di>: Move lower.
6455 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6456 Remove "uiout" parameter.
6457 (dump_insns): Update.
6458 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6459 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6460
6461 2019-08-06 Christian Biesinger <cbiesinger@google.com>
6462
6463 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6464 (error_in_psymtab_expansion): Likewise.
6465 (lookup_symbol_via_quick_fns): Likewise.
6466 (basic_lookup_transparent_type_quick): Likewise.
6467 (basic_lookup_transparent_type_1): Likewise.
6468
6469 2019-08-06 Tom Tromey <tromey@adacore.com>
6470
6471 * source.c (last_source_error): Now bool.
6472 (print_source_lines_base): Make "noprint" bool. Only open
6473 source file when last_source_visited changes.
6474
6475 2019-08-06 Tom Tromey <tromey@adacore.com>
6476
6477 * annotate.c (annotate_source_line): Use g_source_cache.
6478 * source-cache.c (source_cache::get_plain_source_lines): Change
6479 parameters. Populate m_offset_cache.
6480 (source_cache::ensure): New method.
6481 (source_cache::get_line_charpos): New method.
6482 (extract_lines): Move lower. Change parameters.
6483 (source_cache::get_source_lines): Move lower.
6484 * source-cache.h (class source_cache): Update comment.
6485 <get_line_charpos>: New method.
6486 <get_source_lines>: Update comment.
6487 <clear>: Clear m_offset_cache.
6488 <get_plain_source_lines>: Change parameters.
6489 <ensure>: New method
6490 <m_offset_cache>: New member.
6491 * source.c (forget_cached_source_info_for_objfile): Update.
6492 (info_source_command): Use g_source_cache.
6493 (find_source_lines, open_source_file_with_line_charpos): Remove.
6494 (print_source_lines_base, search_command_helper): Use g_source_cache.
6495 * source.h (open_source_file_with_line_charpos): Don't declare.
6496 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6497 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6498 Use g_source_cache.
6499
6500 2019-08-06 Tom Tromey <tromey@adacore.com>
6501
6502 * source-cache.c (source_cache::get_plain_source_lines):
6503 Remove "first_line" and "last_line" parameters.
6504 (source_cache::get_source_lines): Cache plain text.
6505 * source-cache.h (class source_cache)
6506 <get_plain_source_lines>: Update.
6507
6508 2019-08-06 Tom Tromey <tromey@adacore.com>
6509
6510 * source-cache.c (extract_lines): No longer a method.
6511 Changed type of parameter. Include final newline.
6512 (selftests::extract_lines_test): New function.
6513 (_initialize_source_cache): Likewise.
6514 * source-cache.h (class source_cache)
6515 <extract_lines>: Don't declare.
6516
6517 2019-08-06 Tom Tromey <tromey@adacore.com>
6518
6519 * breakpoint.c (init_breakpoint_sal): Update.
6520 (breakpoint): Update.
6521 * breakpoint.h (struct breakpoint) <filter>: Now a
6522 unique_xmalloc_ptr.
6523
6524 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6525
6526 * NEWS: Mention dictionary access on blocks.
6527 * python/py-block.c (blpy_getitem): New function.
6528 (block_object_as_mapping): New struct.
6529 (block_object_type): Use new struct for tp_as_mapping field.
6530
6531 2019-08-05 Christian Biesinger <cbiesinger@google.com>
6532
6533 * objfiles.h (objfile): Add a comment describing partial symbols.
6534
6535 2019-08-05 Tom Tromey <tromey@adacore.com>
6536
6537 * compile/compile.c (_initialize_compile): Use _(), not N_().
6538 * thread.c (_initialize_thread): Use _(), not N_().
6539 * stack.c (_initialize_stack): Use _(), not N_().
6540 * printcmd.c (_initialize_printcmd): Use _(), not N_().
6541
6542 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
6543
6544 * dwarf2read.c (struct dw2_symtab_iterator):
6545 <want_specific_block>: Remove.
6546 <block_index>: Change type to gdb::optional.
6547 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6548 change type of BLOCK_INDEX parameter to gdb::optional.
6549 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6550 (dw2_lookup_symbol): Don't pass argument for
6551 WANT_SPECIFIC_BLOCK.
6552 (dw2_expand_symtabs_for_function): Don't pass argument for
6553 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6554 (class dw2_debug_names_iterator)
6555 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6556 parameter, change BLOCK_INDEX type to gdb::optional.
6557 <m_want_specific_block>: Remove.
6558 <m_block_index>: Change type to gdb::optional.
6559 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6560 gdb::optional. Re-write in function of gdb::optional.
6561 (dw2_debug_names_lookup_symbol): Don't pass argument for
6562 WANT_SPECIFIC_BLOCK.
6563 (dw2_debug_names_expand_symtabs_for_function): Don't pass
6564 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6565 BLOCK_INDEX.
6566
6567 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6568
6569 * NEWS: Mention changes to "info sources" command.
6570
6571 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6572
6573 * symtab.c (filename_partial_match_opts): New struct type.
6574 (struct output_source_filename_data): New members
6575 regexp, c_regexp, partial_match.
6576 (output_source_filename): Use new members to decide to print file.
6577 (info_sources_option_defs): New variable.
6578 (make_info_sources_options_def_group, print_info_sources_header,
6579 info_sources_command_completer):
6580 New functions.
6581 (info_sources_command): Read new optional arguments.
6582 (_initialize_symtab): Update info sources help.
6583
6584 2019-08-02 Alexandre Oliva <oliva@adacore.com>
6585
6586 * ada-lang.c (exception_support_info_v0): Renamed from...
6587 (default_exception_support_info): ... this. Create new
6588 definition for v1.
6589 (ada_has_this_exception_support): Look up catch_handlers_sym.
6590 (ada_exception_support_info_sniffer): Try v0 after default.
6591
6592 2019-08-01 Tom Tromey <tromey@adacore.com>
6593
6594 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6595 gdbarch.h.
6596
6597 2019-08-01 Christian Biesinger <cbiesinger@google.com>
6598
6599 * s12z-tdep.c: Fix include path for s12z-opc.h.
6600
6601 2019-08-01 Alan Hayward <alan.hayward@arm.com>
6602
6603 * NEWS: Require GNU make 3.82.
6604
6605 2019-07-16 Tom Tromey <tom@tromey.com>
6606
6607 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6608 declare.
6609
6610 2019-07-30 Tom Tromey <tromey@adacore.com>
6611
6612 * block.c (contained_in): Remove BLOCK_FUNCTION check.
6613
6614 2019-07-30 Kevin Buettner <kevinb@redhat.com>
6615
6616 * printcmd.c (print_address_symbolic): Print negative offsets.
6617 (build_address_symbolic): Force signed arithmetic when computing
6618 offset.
6619
6620 2019-07-30 Christian Biesinger <cbiesinger@google.com>
6621
6622 PR/24474: Add a function to lookup static variables.
6623 * NEWS: Mention this new function.
6624 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6625 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6626 * python/python.c (python_GdbMethods): Add new function.
6627
6628 2019-07-29 Christian Biesinger <cbiesinger@google.com>
6629
6630 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6631 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6632 (objfpy_lookup_static_symbol): New function.
6633 (objfile_object_methods): Add new functions.
6634
6635 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6636
6637 * NEWS: Mention 'set|show print frame-info'. Mention new
6638 'presence' value for 'frame-arguments'. Mention new '-frame-info'
6639 backtrace argument. Mention that python frame filtering code
6640 is now consistent with what 'backtrace' command prints.
6641
6642 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
6643
6644 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6645 comments.
6646 (print_frame_info_auto, print_frame_info_source_line,
6647 print_frame_info_location, print_frame_info_source_and_location,
6648 print_frame_info_location_and_address, print_frame_info_short_location):
6649 New declarations.
6650 (struct frame_print_options): New member print_frame_info.
6651 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6652 * stack.h (get_user_print_what_frame_info): New declaration.
6653 (frame_show_address): New declaration.
6654 * stack.c (print_frame_arguments_choices): New value 'presence'.
6655 (print_frame_info_auto, print_frame_info_source_line,
6656 print_frame_info_location, print_frame_info_source_and_location,
6657 print_frame_info_location_and_address, print_frame_info_short_location,
6658 print_frame_info_choices, print_frame_info_print_what): New definitions.
6659 (print_frame_args): Only print dots for args if print frame-arguments
6660 is 'presence'.
6661 (frame_print_option_defs): New element for "frame-info".
6662 (get_user_print_what_frame_info): New function.
6663 (frame_show_address): Make non static. Move comment to stack.h.
6664 (print_frame_info_to_print_what): New function.
6665 (print_frame_info): Update comment. Use fp_opts.print_frame_info
6666 to decide what to print.
6667 (backtrace_command_1): Handle the new print_frame_arguments_presence
6668 value.
6669 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6670 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6671 (py_print_frame): In non-mi mode, use LOCATION as default for
6672 print_what, similarly to frame information printed directly by
6673 backtrace command. Handle frame-info user option in non MI mode.
6674
6675 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6676
6677 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6678 Add case for debugging 32-bit target on 64-bit host. Revise
6679 comment.
6680
6681 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6682
6683 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6684 instead of find_function_entry_range_from_pc.
6685
6686 2019-07-27 Kevin Buettner <kevinb@redhat.com>
6687
6688 * stack.c (find_frame_funname): Remove code which preferred
6689 minsym over symtab sym in "certain pathological cases".
6690
6691 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6692 parameter. Change type of "do_demangle" to bool.
6693 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6694 Pass suitable "prefer_sym_over_minsym" flag to
6695 build_address_symbolic(). Don't output "+" for negative offsets.
6696 * printcmd.c (print_address_symbolic): Update invocation of
6697 build_address_symbolic to include a "prefer_sym_over_minsym"
6698 flag.
6699 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6700 Restrict cases in which use of minimal symbol is preferred to that
6701 of a found symbol. Update comments.
6702
6703 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6704 for entry pc when entry pc is out of range for that FDE.
6705
6706 2019-07-26 Brian Callahan <bcallah@openbsd.org>
6707
6708 PR gdb/24839:
6709 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6710 type.
6711
6712 2019-07-25 Christian Biesinger <cbiesinger@google.com>
6713
6714 * python/py-objfile.c (add_separate_debug_file): Fix comment about
6715 this function's Python signature.
6716
6717
6718 2019-07-24 Christian Biesinger <cbiesinger@google.com>
6719
6720 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6721 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6722 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6723 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6724 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6725
6726
6727 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
6728
6729 * h8300-tdep.c (h8300_register_name_common): New.
6730 h8300_register_name): Use h8300_register_name_common.
6731 (h8300s_register_name): Likewise.
6732 (h8300sx_register_name): Likewise.
6733 (h8300h_register_nam): New.
6734 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6735
6736
6737 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
6738
6739 * arm-tdep.c (arm_skip_cmse_entry): New function.
6740 (arm_is_sgstubs_section): New function.
6741 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6742
6743 2019-07-22 Tom Tromey <tom@tromey.com>
6744
6745 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6746 Don't self-assign.
6747
6748 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6749
6750 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6751 type_print.
6752
6753 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6754
6755 * symtab.c (search_symbols): Adjust msymbol matching type arrays
6756 so that GDB doesn't match any msymbols when searching in the
6757 TYPES_DOMAIN.
6758 (print_symbol_info): Print using typedef_print or type_print based
6759 on the type of the symbol. Add updated FIXME comment moved from...
6760 (_initialize_symtab): ... move and update FIXME comment to above.
6761
6762 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
6763
6764 * NEWS: Mention adding -q option to "info types".
6765 * symtab.c (struct info_types_options): New struct.
6766 (info_types_options_defs): New variable.
6767 (make_info_types_options_def_group): New function.
6768 (info_types_command): Use gdb::option framework to parse options.
6769 (info_types_command_completer): New function.
6770 (_initialize_symtab): Extend the help text on "info types" and
6771 register command completer.
6772
6773 2019-07-21 Christian Biesinger <cbiesinger@google.com>
6774
6775 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6776 (lookup_symbol_in_objfile): Change int to block_enum and add a
6777 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6778
6779 2019-07-20 Christian Biesinger <cbiesinger@google.com>
6780
6781 * MAINTAINERS (Write After Approval): Add self.
6782
6783 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
6784
6785 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6786 instruction to the dummy code region.
6787
6788 2019-07-19 Tom Tromey <tromey@adacore.com>
6789
6790 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6791 (ARGSUSED, PARAMS, __func__): Remove rules.
6792
6793 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6794
6795 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6796 * features/arm/arm-with-iwmmxt.c: Remove.
6797 * features/arm/arm-with-iwmmxt.xml: Remove.
6798 * features/arm/arm-with-m-fpa-layout.c: Remove.
6799 * features/arm/arm-with-m-fpa-layout.xml: Remove.
6800 * features/arm/arm-with-m-vfp-d16.c: Remove.
6801 * features/arm/arm-with-m-vfp-d16.xml: Remove.
6802 * features/arm/arm-with-m.c: Remove.
6803 * features/arm/arm-with-m.xml: Remove.
6804 * features/arm/arm-with-neon.c: Remove.
6805 * features/arm/arm-with-neon.xml: Remove.
6806 * features/arm/arm-with-vfpv2.c: Remove.
6807 * features/arm/arm-with-vfpv2.xml: Remove.
6808 * features/arm/arm-with-vfpv3.c: Remove.
6809 * features/arm/arm-with-vfpv3.xml: Remove.
6810
6811 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6812
6813 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6814
6815 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6816
6817 * arch/aarch32.c (aarch32_create_target_description): Create
6818 target descriptions using features.
6819 * arch/arm.c (arm_create_target_description)
6820 (arm_create_mprofile_target_description): Likewise.
6821 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6822
6823 2019-07-19 Alan Hayward <alan.hayward@arm.com>
6824
6825 * Makefile.in: Add new files.
6826 * aarch32-tdep.c: New file.
6827 * aarch32-tdep.h: New file.
6828 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6829 Call aarch32_read_description.
6830 * arch/aarch32.c: New file.
6831 * arch/aarch32.h: New file.
6832 * arch/arm.c (arm_create_target_description)
6833 (arm_create_mprofile_target_description): New function.
6834 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6835 (arm_create_target_description)
6836 (arm_create_mprofile_target_description): New declaration.
6837 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6838 read_description functions.
6839 * arm-linux-nat.c (arm_linux_nat_target::read_description):
6840 Likewise.
6841 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6842 * arm-tdep.c (tdesc_arm_list): New variable.
6843 (arm_register_g_packet_guesses): Call create description functions.
6844 (arm_read_description) (arm_read_mprofile_description): New
6845 function.
6846 * arm-tdep.h (arm_read_description)
6847 (arm_read_mprofile_description): Add declaration.
6848 * configure.tgt: Add new files.
6849
6850 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
6851
6852 * top.c (new_ui_command): Open specified terminal just once.
6853
6854 2019-07-18 Tom Tromey <tromey@adacore.com>
6855
6856 * symtab.c (main_name): Constify return type.
6857 * symfile.c (set_initial_language): Update.
6858 * symtab.h (main_name): Constify return type.
6859
6860 2019-07-17 Tom Tromey <tom@tromey.com>
6861
6862 * tui/tui-winsource.c (tui_update_source_window)
6863 (tui_update_source_window_as_is)
6864 (tui_update_source_windows_with_line): Remove return.
6865 * tui/tui-disasm.c (tui_show_disassem)
6866 (tui_show_disassem_and_update_source): Remove return.
6867 * tui/tui.c (tui_reset): Remove return.
6868 * tui/tui-wingeneral.c
6869 (tui_check_and_display_highlight_if_needed): Remove return.
6870
6871 2019-07-17 Tom Tromey <tom@tromey.com>
6872
6873 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6874
6875 2019-07-17 Tom Tromey <tom@tromey.com>
6876
6877 * tui/tui-winsource.h (struct tui_exec_info_window)
6878 (struct tui_source_window_base): Move from tui-data.h.
6879 * tui/tui-winsource.c: Move many method definitions from
6880 elsewhere. Remove "structuring" comments.
6881 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6882 (tui_source_window_base::refresh_window): Move to
6883 tui-winsource.c.
6884 * tui/tui-win.c (tui_source_window_base::refresh_all)
6885 (tui_source_window_base::update_tab_width)
6886 (tui_source_window_base::set_new_height)
6887 (tui_source_window_base::do_make_visible_with_new_height): Move to
6888 tui-winsource.c.
6889 * tui/tui-source.h: Update.
6890 * tui/tui-source.c (tui_source_window_base::reset): Move to
6891 tui-winsource.c.
6892 * tui/tui-disasm.h: Update.
6893 * tui/tui-data.h (struct tui_exec_info_window): Move to
6894 tui-winsource.h.
6895 (struct tui_source_window_base): Likewise.
6896 * tui/tui-data.c (tui_source_window_base::clear_detail)
6897 (tui_source_window_base, ~tui_source_window_base): Move to
6898 tui-winsource.c.
6899
6900 2019-07-17 Tom Tromey <tom@tromey.com>
6901
6902 * tui/tui-win.c (tui_resize_all)
6903 (tui_source_window_base::update_tab_width)
6904 (tui_adjust_win_heights): Update.
6905 (tui_win_info::make_invisible_and_set_new_height): Rename from
6906 make_invisible_and_set_new_height.
6907 * tui/tui-data.h (struct tui_win_info)
6908 <make_invisible_and_set_new_height>: New method.
6909
6910 2019-07-17 Tom Tromey <tom@tromey.com>
6911
6912 * tui/tui.c: Update.
6913 * tui/tui-source.h (struct tui_source_window): Move from
6914 tui-data.h.
6915 * tui/tui-layout.c: Update.
6916 * tui/tui-disasm.c: Update.
6917 * tui/tui-data.h (struct tui_source_window): Move to
6918 tui-source.h.
6919
6920 2019-07-17 Tom Tromey <tom@tromey.com>
6921
6922 * tui/tui-disasm.h (struct tui_disasm_window): Move from
6923 tui-data.h.
6924 * tui/tui-data.h (struct tui_disasm_window): Move to
6925 tui-disasm.h.
6926
6927 2019-07-17 Tom Tromey <tom@tromey.com>
6928
6929 * tui/tui-regs.h (struct tui_data_item_window): Move from
6930 tui-data.h.
6931 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6932 * tui/tui-data.h (struct tui_data_item_window): Move to
6933 tui-regs.h.
6934 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6935
6936 2019-07-17 Tom Tromey <tom@tromey.com>
6937
6938 * tui/tui.c: Update.
6939 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6940 (tui_cmd_window::max_height): Move to tui-command.c.
6941 * tui/tui-layout.c: Update.
6942 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6943 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6944 tui-command.c.
6945 * tui/tui-command.h (struct tui_cmd_window): Move from
6946 tui-data.h.
6947 * tui/tui-command.c: Remove "structuring" comments.
6948 (tui_cmd_window::clear_detail)
6949 (tui_cmd_window::do_make_visible_with_new_height)
6950 (tui_cmd_window::max_height): Move from elsewhere.
6951
6952 2019-07-17 Tom Tromey <tom@tromey.com>
6953
6954 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6955 Now static.
6956 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6957 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6958
6959 2019-07-17 Tom Tromey <tom@tromey.com>
6960
6961 * tui/tui.c: Update.
6962 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6963 tui-regs.c.
6964 * tui/tui-windata.h: Remove file.
6965 * tui/tui-windata.c: Remove file.
6966 * tui/tui-win.c (tui_data_window::set_new_height)
6967 (tui_data_window::do_make_visible_with_new_height): Move to
6968 tui-regs.c.
6969 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6970 * tui/tui-regs.c: Remove "structuring" comments.
6971 (tui_data_window::first_data_item_displayed)
6972 (tui_data_window::delete_data_content_windows)
6973 (tui_data_window::erase_data_content)
6974 (tui_data_window::display_all_data)
6975 (tui_data_window::refresh_all)
6976 (tui_data_window::do_scroll_vertical)
6977 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6978 (tui_data_window::do_make_visible_with_new_height)
6979 (tui_data_window::refresh_window): Move from elsewhere.
6980 (_initialize_tui_regs): Move to end of file.
6981 * tui/tui-layout.c: Update.
6982 * tui/tui-hooks.c: Update.
6983 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6984 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6985 tui-regs.c.
6986 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6987
6988 2019-07-17 Tom Tromey <tom@tromey.com>
6989
6990 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6991 seen.
6992
6993 2019-07-17 Tom Tromey <tom@tromey.com>
6994
6995 * tui/tui-win.c (tui_source_window_base::set_new_height)
6996 (tui_source_window_base::do_make_visible_with_new_height): Use
6997 m_has_locator field directly.
6998 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6999 method.
7000 (struct tui_source_window_base) <has_locator>: Likewise.
7001
7002 2019-07-17 Tom Tromey <tom@tromey.com>
7003
7004 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
7005 Don't declare.
7006 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
7007 Remove.
7008 * tui/tui-win.c (tui_source_window_base::set_new_height)
7009 (tui_source_window_base::set_new_height)
7010 (make_invisible_and_set_new_height)
7011 (tui_source_window_base::do_make_visible_with_new_height)
7012 (tui_source_window_base::do_make_visible_with_new_height):
7013 Update.
7014 * tui/tui-layout.c (show_source_disasm_command, show_data)
7015 (show_source_or_disasm_and_command): Update.
7016 * tui/tui-layout.c (show_layout): Update.
7017
7018 2019-07-17 Tom Tromey <tom@tromey.com>
7019
7020 * tui/tui-layout.c (make_data_window): Remove.
7021 (show_data): Unify creation and re-initialization cases.
7022
7023 2019-07-17 Tom Tromey <tom@tromey.com>
7024
7025 * tui/tui-layout.c (make_source_window, make_disasm_window):
7026 Remove.
7027 (show_data): Unify creation and re-initialization cases.
7028
7029 2019-07-17 Tom Tromey <tom@tromey.com>
7030
7031 * tui/tui-layout.c (make_command_window): Remove.
7032 (show_source_disasm_command, show_source_or_disasm_and_command):
7033 Unify creation and re-initialization cases.
7034
7035 2019-07-17 Tom Tromey <tom@tromey.com>
7036
7037 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
7038 creation and re-initialization cases.
7039
7040 2019-07-17 Tom Tromey <tom@tromey.com>
7041
7042 * tui/tui-regs.c (tui_get_register): Return void.
7043
7044 2019-07-17 Tom Tromey <tom@tromey.com>
7045
7046 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
7047 Simplify.
7048
7049 2019-07-17 Tom Tromey <tom@tromey.com>
7050
7051 * tui/tui-layout.c (show_source_disasm_command): Simplify window
7052 resetting.
7053
7054 2019-07-17 Tom Tromey <tom@tromey.com>
7055
7056 * tui/tui.h (tui_set_layout_by_name): Don't declare.
7057 * tui/tui-regs.c (tui_reg_layout): New function.
7058 (tui_show_registers, tui_reg_command): Use it.
7059 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
7060 (tui_layout_command): Rename from tui_set_layout_by_name. Change
7061 parameters.
7062 (tui_layout_command): Remove.
7063
7064 2019-07-17 Tom Tromey <tom@tromey.com>
7065
7066 * tui/tui-layout.h (tui/tui-layout): Return void.
7067 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
7068
7069 2019-07-17 Tom Tromey <tom@tromey.com>
7070
7071 * tui/tui-layout.c (show_source_disasm_command, show_data):
7072 Update.
7073 (reset_locator): Remove.
7074 (show_source_or_disasm_and_command): Update.
7075
7076 2019-07-17 Tom Tromey <tom@tromey.com>
7077
7078 * tui/tui-source.c (tui_source_window_base::reset): Remove
7079 win_type parameter.
7080 * tui/tui-layout.c (make_command_window, make_source_window)
7081 (make_disasm_window, make_data_window)
7082 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
7083 (reset_locator, show_source_or_disasm_and_command): Update.
7084 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
7085 win_type parameter.
7086 (struct tui_source_window_base) <reset>: Likewise.
7087
7088 2019-07-17 Tom Tromey <tom@tromey.com>
7089
7090 * tui/tui-layout.c (show_source_disasm_command): Use
7091 reset_locator.
7092 (reset_locator): New function.
7093 (init_and_make_win): Remove.
7094 (show_source_or_disasm_and_command): Use reset_locator.
7095
7096 2019-07-17 Tom Tromey <tom@tromey.com>
7097
7098 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
7099 condition.
7100 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
7101 Remove condition.
7102 * tui/tui-source.c (tui_source_window_base::reset): New method.
7103 * tui/tui-layout.c (make_command_window): Don't call
7104 init_and_make_win.
7105 (make_source_window, make_disasm_window): Don't call
7106 make_source_or_disasm_window.
7107 (make_data_window): Don't call init_and_make_win. Change calling
7108 convention.
7109 (show_source_disasm_command, show_data): Simplify.
7110 (make_source_or_disasm_window): Remove.
7111 (show_source_or_disasm_and_command): Simplify.
7112 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
7113 (struct tui_source_window_base) <reset>: Likewise.
7114 <execution_info>: Remove initializer.
7115 * tui/tui-data.c (tui_source_window_base): Initialize
7116 execution_info.
7117
7118 2019-07-17 Tom Tromey <tom@tromey.com>
7119
7120 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
7121 variable.
7122
7123 2019-07-17 Tom Tromey <tom@tromey.com>
7124
7125 * tui/tui.c (tui_rl_other_window): Update.
7126 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
7127 superclass method first. Always iterate over regs_content.
7128 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
7129 method.
7130 * tui/tui-win.c (tui_set_focus_command): Update.
7131
7132 2019-07-17 Tom Tromey <tom@tromey.com>
7133
7134 * tui/tui-win.c (tui_set_focus_command): Rename from
7135 tui_set_focus. Call tui_enable.
7136 (tui_set_focus_command): Remove.
7137
7138 2019-07-17 Tom Tromey <tom@tromey.com>
7139
7140 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
7141 refresh_window.
7142 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
7143 touchwin.
7144 (tui_data_window::refresh_window): Call refresh_window on data
7145 items. Always call superclass refresh_window.
7146 (tui_win_info::refresh): Remove.
7147 (tui_source_window_base::refresh_window): Update.
7148 (tui_refresh_all): Update.
7149 * tui/tui-layout.c (show_source_disasm_command): Remove call to
7150 refresh_window.
7151 (show_source_or_disasm_and_command): Likewise.
7152 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7153 (struct tui_source_window_base) <refresh>: Likewise.
7154
7155 2019-07-17 Tom Tromey <tom@tromey.com>
7156
7157 * tui/tui-winsource.c (tui_clear_source_content)
7158 (tui_show_source_content): Update.
7159 * tui/tui-source.c (tui_source_window::showing_source_p): Check
7160 whether content is empty.
7161 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7162 Remove.
7163
7164 2019-07-17 Tom Tromey <tom@tromey.com>
7165
7166 * tui/tui-winsource.c (tui_erase_source_content): Clear the
7167 window's contents.
7168 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7169 * tui/tui-source.c (tui_set_source_content_nil): Remove.
7170
7171 2019-07-17 Tom Tromey <tom@tromey.com>
7172
7173 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7174 (struct tui_data_item_window): Update.
7175
7176 2019-07-17 Tom Tromey <tom@tromey.com>
7177
7178 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7179 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7180 defines.
7181
7182 2019-07-17 Tom Tromey <tom@tromey.com>
7183
7184 * tui/tui-winsource.h (tui_erase_source_content)
7185 (tui_clear_source_content): Remove "display_prompt" parameter.
7186 * tui/tui-winsource.c (tui_update_source_window_as_is)
7187 (tui_update_source_windows_with_addr): Update.
7188 (tui_clear_source_content): Remove "display_prompt" parameter.
7189 (tui_erase_source_content): Likewise. Simplify.
7190 (tui_show_source_content): Update.
7191 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7192 * tui/tui-stack.c (tui_show_frame_info): Update.
7193 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7194 Remove defines.
7195
7196 2019-07-17 Tom Tromey <tom@tromey.com>
7197
7198 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7199 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7200 parameter.
7201 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7202 parameter.
7203
7204 2019-07-17 Tom Tromey <tom@tromey.com>
7205
7206 * tui/tui-winsource.c (tui_clear_source_content)
7207 (tui_show_source_content, tui_show_exec_info_content)
7208 (tui_clear_exec_info_content): Update.
7209 * tui/tui-stack.c (tui_show_locator_content): Update.
7210 (tui_show_frame_info): Update.
7211 * tui/tui-source.h (tui_source_window): Don't declare.
7212 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7213 from tui_source_is_displayed.
7214 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7215 Remove field.
7216 (struct tui_source_window_base) <content_in_use>: New field. Now
7217 bool.
7218 (struct tui_source_window) <showing_source_p>: New method.
7219 (TUI_SRC_WIN): Change cast.
7220 * tui/tui-data.c (tui_initialize_static_data): Update.
7221
7222 2019-07-17 Tom Tromey <tom@tromey.com>
7223
7224 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7225 location_matches_p.
7226 * tui/tui-source.c (tui_source_window::location_matches_p): New
7227 method.
7228 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7229 method.
7230 * tui/tui-data.h (struct tui_source_window_base)
7231 <location_matches_p>: New method.
7232 (struct tui_source_window, struct tui_disasm_window)
7233 <location_matches_p>: Likewise.
7234
7235 2019-07-17 Tom Tromey <tom@tromey.com>
7236
7237 * tui/tui-win.c (tui_set_win_height_command): Rename from
7238 tui_set_win_height.
7239 (tui_set_win_height_command): Remove.
7240
7241 2019-07-17 Tom Tromey <tom@tromey.com>
7242
7243 * tui/tui-source.c (tui_source_window): New constructor. Add
7244 observer.
7245 (~tui_source_window): New destructor.
7246 (tui_source_window::style_changed): New method.
7247 * tui/tui-hooks.c (tui_redisplay_source): Remove.
7248 (tui_attach_detach_observers): Update.
7249 * tui/tui-data.h (struct tui_source_window): Make constructor not
7250 inline. Add destructor.
7251 (struct tui_source_window) <style_changed>: New method.
7252 <m_observable>: New member.
7253
7254 2019-07-17 Tom Tromey <tom@tromey.com>
7255
7256 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7257 * tui/tui-win.c (tui_resize_all): Fix typo.
7258
7259 2019-07-17 Tom Tromey <tom@tromey.com>
7260
7261 * tui/tui-wingeneral.h (tui_refresh_all): Update.
7262 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7263 (tui_refresh_all): Remove "list" parameter. Use foreach.
7264 * tui/tui-win.c (window_name_completer): Use foreach.
7265 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7266 (update_tab_width): Likewise.
7267 * tui/tui-layout.c (show_layout): Update.
7268 * tui/tui-data.h (class tui_window_iterator): New.
7269 (struct all_tui_windows): New.
7270 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7271
7272 2019-07-17 Tom Tromey <tom@tromey.com>
7273
7274 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7275 parameter. Don't reference globals.
7276 (tui_reg_command): Update.
7277
7278 2019-07-17 Tom Tromey <tom@tromey.com>
7279
7280 * tui/tui-regs.c (tui_show_registers): Simplify.
7281
7282 2019-07-17 Tom Tromey <tom@tromey.com>
7283
7284 * tui/tui-regs.c (tui_show_registers): Update.
7285 (tui_show_register_group): Add win_info parameter.
7286
7287 2019-07-17 Tom Tromey <tom@tromey.com>
7288
7289 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7290 Rename from tui_display_reg_element_at_line.
7291 (tui_data_window::display_registers_from_line): Update.
7292 * tui/tui-data.h (struct tui_data_window)
7293 <display_reg_element_at_line>: New method.
7294
7295 2019-07-17 Tom Tromey <tom@tromey.com>
7296
7297 * tui/tui-regs.h (tui_display_registers_from)
7298 (tui_display_registers_from_line): Don't declare.
7299 * tui/tui-windata.c (tui_data_window::display_all_data)
7300 (tui_data_window::refresh_all)
7301 (tui_data_window::do_scroll_vertical): Update.
7302 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7303 from tui_display_registers_from.
7304 (tui_display_reg_element_at_line): Update.
7305 (tui_data_window::display_registers_from_line): Rename from
7306 tui_display_registers_from_line.
7307 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7308 display_registers_from_line>: New methods.
7309
7310 2019-07-17 Tom Tromey <tom@tromey.com>
7311
7312 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7313 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7314 from tui_erase_data_content.
7315 (tui_data_window::display_all_data)
7316 (tui_data_window::refresh_all)
7317 (tui_data_window::do_scroll_vertical): Update.
7318 * tui/tui-regs.c (tui_show_registers): Update.
7319 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7320 New method.
7321
7322 2019-07-17 Tom Tromey <tom@tromey.com>
7323
7324 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7325 declare.
7326 * tui/tui-windata.c
7327 (tui_data_window::delete_data_content_windows): Rename from
7328 tui_delete_data_content_windows.
7329 (tui_data_window::display_all_data)
7330 (tui_data_window::do_scroll_vertical): Update.
7331 * tui/tui-data.h (struct tui_data_window)
7332 <delete_data_content_windows>: New method.
7333
7334 2019-07-17 Tom Tromey <tom@tromey.com>
7335
7336 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7337 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7338
7339 2019-07-17 Tom Tromey <tom@tromey.com>
7340
7341 * tui/tui-windata.h (tui_display_all_data): Don't declare.
7342 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7343 from tui_display_all_data.
7344 * tui/tui-win.c
7345 (tui_data_window::do_make_visible_with_new_height): Update.
7346 * tui/tui-regs.c (tui_show_registers): Update.
7347 * tui/tui-layout.c (tui_set_layout): Update.
7348 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7349 method.
7350
7351 2019-07-17 Tom Tromey <tom@tromey.com>
7352
7353 * tui/tui-windata.h (tui_display_data_from): Don't declare.
7354 * tui/tui-windata.c (tui_display_data_from): Remove.
7355 (tui_data_window::refresh_all): Update.
7356
7357 2019-07-17 Tom Tromey <tom@tromey.com>
7358
7359 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7360 * tui/tui-windata.c (tui_display_data_from_line): Remove.
7361 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7362 tui_display_registers_from_line.
7363 * tui/tui-regs.h (tui_display_registers_from_line): Update.
7364 * tui/tui-regs.c (tui_display_registers_from_line): Remove
7365 "force_display" parameter.
7366
7367 2019-07-17 Tom Tromey <tom@tromey.com>
7368
7369 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7370 declare.
7371 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7372 Rename from tui_first_reg_element_no_inline.
7373 (tui_display_reg_element_at_line)
7374 (tui_display_registers_from_line): Update.
7375 * tui/tui-data.h (struct tui_data_window)
7376 <first_reg_element_no_inline>: New method.
7377
7378 2019-07-17 Tom Tromey <tom@tromey.com>
7379
7380 * tui/tui-windata.c (tui_display_data_from)
7381 (tui_data_window::do_scroll_vertical): Update.
7382 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7383 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7384 Rename from tui_line_from_reg_element_no.
7385 (tui_display_registers_from_line): Update.
7386 * tui/tui-data.h (struct tui_data_window)
7387 <line_from_reg_element_no>: New method.
7388
7389 2019-07-17 Tom Tromey <tom@tromey.com>
7390
7391 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7392 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7393 tui_last_regs_line_no.
7394 (tui_display_reg_element_at_line)
7395 (tui_display_registers_from_line): Update.
7396 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7397 method.
7398
7399 2019-07-17 Tom Tromey <tom@tromey.com>
7400
7401 PR tui/24722:
7402 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7403 (tui_update_breakpoint_info): Add "being_deleted" parameter.
7404 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7405 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7406 (tui_update_breakpoint_info): Likewise.
7407 * tui/tui-hooks.c (tui_event_create_breakpoint)
7408 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7409 Update.
7410
7411 2019-07-17 Tom Tromey <tom@tromey.com>
7412
7413 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7414
7415 2019-07-17 Tom Tromey <tom@tromey.com>
7416
7417 * tui/tui-winsource.c (tui_update_source_window_as_is)
7418 (tui_update_source_windows_with_addr): Update.
7419 * tui/tui-source.h (tui_set_source_content)
7420 (tui_show_symtab_source): Add "win_info" parameter.
7421 * tui/tui-source.c (tui_set_source_content): Add "win_info"
7422 parameter.
7423 (tui_show_symtab_source): Likewise.
7424
7425 2019-07-17 Tom Tromey <tom@tromey.com>
7426
7427 * tui/tui-wingeneral.c
7428 (tui_check_and_display_highlight_if_needed): Check can_highlight.
7429
7430 2019-07-17 Tom Tromey <tom@tromey.com>
7431
7432 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7433 (struct tui_cmd_window) <can_scroll>: New method.
7434 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7435 method.
7436
7437 2019-07-17 Tom Tromey <tromey@adacore.com>
7438
7439 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7440 do_field_signed>: Rename. Change type of "value".
7441 * ui-out.c (ui_out::field_signed): Rename from field_int.
7442 Change type of "value".
7443 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
7444 type of "value".
7445 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7446 do_field_int. Change type of "value".
7447 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7448 do_field_int. Change type of "value".
7449 * tracepoint.c (trace_status_mi, tfind_1)
7450 (print_one_static_tracepoint_marker): Update.
7451 * thread.c (print_thread_info_1, print_selected_thread_frame):
7452 Update.
7453 * stack.c (print_frame, print_frame_info): Update.
7454 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7455 Update.
7456 * source.c (print_source_lines_base): Update.
7457 * skip.c (info_skip_command): Update.
7458 * record-btrace.c (btrace_ui_out_decode_error)
7459 (btrace_call_history_src_line): Update.
7460 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7461 Update.
7462 * progspace.c (print_program_space): Update.
7463 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7464 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7465 do_field_int. Change type of "value".
7466 * mi/mi-out.c (mi_ui_out::do_table_begin)
7467 (mi_ui_out::do_table_header): Update.
7468 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
7469 type of "value".
7470 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7471 (mi_cmd_data_list_changed_registers, output_register)
7472 (mi_cmd_data_read_memory, mi_load_progress)
7473 (mi_cmd_trace_frame_collected): Update.
7474 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7475 Update.
7476 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7477 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7478 (mi_cmd_var_list_children, varobj_update_one): Update.
7479 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7480 (mi_cmd_stack_list_args, list_arg_or_local): Update.
7481 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7482 * inferior.c (print_inferior): Update.
7483 * gdb_bfd.c (print_one_bfd): Update.
7484 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7485 Update.
7486 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7487 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7488 do_field_int. Change type of "value".
7489 * cli-out.c (cli_ui_out::do_field_signed): Rename from
7490 do_field_int. Change type of "value".
7491 * breakpoint.c (watchpoint_check, print_breakpoint_location)
7492 (print_one_breakpoint_location, print_it_catch_fork)
7493 (print_one_catch_fork, print_it_catch_vfork)
7494 (print_one_catch_vfork, print_it_catch_solib)
7495 (print_it_catch_exec, print_it_ranged_breakpoint)
7496 (print_mention_watchpoint, print_mention_masked_watchpoint)
7497 (bkpt_print_it, update_static_tracepoint): Update.
7498 * break-catch-throw.c (print_it_exception_catchpoint): Update.
7499 * break-catch-syscall.c (print_it_catch_syscall): Update.
7500 * ada-tasks.c (print_ada_task_info): Update.
7501 * ada-lang.c (print_it_exception, print_mention_exception):
7502 Update.
7503
7504 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
7505
7506 PR breakpoints/24541
7507 * gdbarch.c: Regenerate.
7508 * gdbarch.h: Regenerate.
7509 * gdbarch.sh: Adjust return type and parameter types for
7510 'stap_adjust_register'.
7511 (i386_stap_adjust_register): Adjust signature and return new
7512 register name.
7513 * stap-probe.c (stap_parse_register_operand): Adjust use of
7514 'gdbarch_stap_adjust_register'.
7515
7516 2019-07-17 Tom Tromey <tromey@adacore.com>
7517
7518 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
7519 declare VEC.
7520 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7521 std::vector.
7522 (struct s390_process_info): Add initializers.
7523 (s390_add_process): Use new.
7524 (s390_linux_nat_target::low_forget_process): Use delete.
7525 (s390_linux_nat_target::low_new_fork)
7526 (s390_linux_nat_target::stopped_by_watchpoint)
7527 (s390_linux_nat_target::low_prepare_to_resume)
7528 (s390_linux_nat_target::insert_watchpoint)
7529 (s390_linux_nat_target::insert_hw_breakpoint)
7530 (s390_linux_nat_target::remove_watchpoint)
7531 (s390_linux_nat_target::remove_hw_breakpoint): Update.
7532
7533 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7534
7535 * aarch64-fbsd-nat.c: Include regcache.h.
7536 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7537 argument.
7538 (aarch64_fbsd_nat_target::fetch_registers)
7539 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7540 variable.
7541 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7542
7543 2019-07-16 John Baldwin <jhb@FreeBSD.org>
7544
7545 * fbsd-nat.c: Include gdbarch.h.
7546
7547 2019-07-15 Tom Tromey <tromey@adacore.com>
7548
7549 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7550
7551 2019-07-15 Tom Tromey <tromey@adacore.com>
7552
7553 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7554 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7555 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7556 * cli-out.c (cli_ui_out::do_field_int): New method.
7557 * ui-out.c (ui_out::field_unsigned): New method.
7558 * symfile.c (generic_load): Use field_unsigned.
7559 (print_transfer_performance): Likewise.
7560 * record-btrace.c (ui_out_field_uint): Remove.
7561 (btrace_call_history_insn_range, btrace_call_history): Use
7562 field_unsigned.
7563 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7564 field_unsigned.
7565 * ui-out.h (class ui_out) <field_unsigned>: New method.
7566 <do_field_unsigned>: Likewise.
7567
7568 2019-07-15 Tom Tromey <tromey@adacore.com>
7569
7570 * mi/mi-main.c (list_available_thread_groups): Use field_string.
7571 * mi/mi-interp.c (mi_memory_changed): Use field_string.
7572 * target.c (flash_erase_command): Use field_string.
7573 * infrun.c (print_signal_received_reason): Use field_string.
7574 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7575 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7576 field_string.
7577 * ada-tasks.c (print_ada_task_info): Use field_string.
7578
7579 2019-07-15 Tom Tromey <tromey@adacore.com>
7580
7581 * target.c (flash_erase_command): Use field_core_addr.
7582 * symfile.c (generic_load): Use field_core_addr.
7583 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7584 Use field_core_addr.
7585 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7586 field_core_addr.
7587
7588 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7589
7590 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7591 value if its desired type is smaller than a CORE_ADDR and signed.
7592
7593 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7594
7595 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7596 of changes to field names, and use new is_reference field to
7597 decide if a property is a reference or not.
7598 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7599 field.
7600 (struct dwarf2_property_baton): Update header comment, rename
7601 'referenced_type' to 'property_type' and update comments.
7602 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7603 default property type, store in property baton, update to take
7604 accound of renamed field.
7605 (read_func_scope): Update call to attr_to_dynamic_prop.
7606 (read_array_type): Likewise.
7607 (dwarf2_per_cu_addr_sized_int_type): New function.
7608 (read_subrange_index_type): Move type finding code to
7609 dwarf2_per_cu_addr_sized_int_type.
7610 (read_subrange_type): Update calls to attr_to_dynamic_prop.
7611 (dwarf2_per_cu_addr_type): New function.
7612 (set_die_type): Update calls to attr_to_dynamic_prop.
7613
7614 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7615
7616 * dwarf2read.c (read_subrange_index_type): New function.
7617 (read_subrange_type): Move code into new function and call it.
7618 * gdbtypes.c (create_range_type): Add some asserts.
7619
7620 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7621
7622 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7623 update return statements.
7624 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7625 declaration, and update comment to match.
7626 * gdbtypes.c (resolve_dynamic_array): Update call to
7627 dwarf2_evaluate_property to match new return type.
7628
7629 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
7630
7631 * valarith.c (value_subscripted_rvalue): Change lowerbound
7632 parameter type from int to LONGEST.
7633 * value.h (value_subscripted_rvalue): Likewise in declaration.
7634
7635 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7636
7637 * cli/cli-utils.c (info_print_command_completer): New function.
7638 * cli/cli-utils.h: Add 'completer.h' include, and forward
7639 declaration for 'struct cmd_list_element'.
7640 (info_print_command_completer): Declare.
7641 * stack.c (_initialize_stack): Add completer for 'info locals' and
7642 'info args'.
7643 * symtab.c (_initialize_symtab): Add completer for 'info
7644 variables' and 'info functions'.
7645 * NEWS: Mention completion for additional info commands.
7646
7647 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7648
7649 * cli/cli-utils.c (extract_info_print_args): Delete.
7650 (extract_arg_maybe_quoted): Delete.
7651 (info_print_options_defs): New variable.
7652 (make_info_print_options_def_group): New function.
7653 (extract_info_print_options): Define new function.
7654 * cli/cli-utils.h (extract_info_print_args): Delete.
7655 (struct info_print_options): New structure.
7656 (extract_info_print_options): Declare new function.
7657 * stack.c (info_locals_command): Update to use new
7658 extract_info_print_options, also add a header comment.
7659 (info_args_command): Likewise.
7660 * symtab.c (info_variables_command): Likewise.
7661 (info_functions_command): Likewise.
7662
7663 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
7664
7665 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7666 to extract string arguments.
7667 * common/common-utils.c (extract_string_maybe_quoted): New function.
7668 * common/common-utils.h (extract_string_maybe_quoted): Declare.
7669
7670 2019-07-11 Tom Tromey <tromey@adacore.com>
7671
7672 * main.c (get_init_files): Use GDBINIT, not gdbinit.
7673 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7674 * top.h (gdbinit): Don't declare.
7675 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7676 into...
7677 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
7678 * top.c (gdb_init): Don't call init_cli_cmds.
7679 (gdbinit): Remove.
7680 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7681
7682 2019-07-11 Tom Tromey <tromey@adacore.com>
7683
7684 * python/py-inferior.c (add_thread_object): Don't use thread_obj
7685 after it has been moved.
7686
7687 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7688
7689 * valops.c (value_must_coerce_to_target): Change return type to
7690 bool.
7691 * value.h (value_must_coerce_to_target): Likewise.
7692
7693 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
7694
7695 * breakpoint.c (is_hardware_watchpoint): Remove
7696 forward-declaration.
7697 (is_masked_watchpoint): Change return type to bool.
7698 (is_tracepoint): Likewise.
7699 (is_breakpoint): Likewise.
7700 (is_hardware_watchpoint): Likewise.
7701 (is_watchpoint): Likewise.
7702 (is_no_memory_software_watchpoint): Likewise.
7703 (is_catchpoint): Likewise.
7704 (breakpoint_1): Make FILTER parameter's return type bool.
7705 is_masked_watchpoint): Change return type to bool.
7706 (save_breakpoints): Make FILTER parameter's return type bool.
7707 * breakpoint.h (is_breakpoint): Change return type to bool.
7708 (is_watchpoint): Likewise.
7709 (is_catchpoint): Likewise.
7710 (is_tracepoint): Likewise.
7711
7712 2019-07-10 Tom Tromey <tom@tromey.com>
7713
7714 * defs.h: Don't include gdbarch.h.
7715 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7716 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7717 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7718 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7719 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7720 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7721 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7722 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7723 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7724 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7725 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7726 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7727 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7728 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7729 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7730 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7731 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7732 record-btrace.c, record.h, regcache-dump.c, regcache.h,
7733 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7734 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7735 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7736 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7737 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7738 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7739 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7740 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7741 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7742
7743 2019-07-10 Tom Tromey <tromey@adacore.com>
7744
7745 * ada-lang.h (is_ada_exception_catchpoint): Declare.
7746 * breakpoint.c (init_ada_exception_breakpoint): Register as
7747 bp_catchpoint.
7748 (print_one_breakpoint_location, print_one_breakpoint): Use
7749 is_ada_exception_catchpoint.
7750 * ada-lang.c (class ada_catchpoint_location): Pass
7751 bp_loc_software_breakpoint to bp_location constructor.
7752 (is_ada_exception_catchpoint): New function.
7753
7754 2019-07-10 Tom Tromey <tromey@adacore.com>
7755
7756 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
7757 VEC.
7758 (struct arm_exidx_entry): New method operator<.
7759 (struct arm_exidx_data) <section_maps>: Change type.
7760 (arm_exidx_data_free): Remove.
7761 (arm_exidx_data_key): Change type. Move lower.
7762 (arm_exidx_new_objfile): Update.
7763 (arm_compare_exidx_entries): Remove.
7764 (arm_find_exidx_entry, _initialize_arm_tdep)
7765
7766 2019-07-10 Tom Tromey <tromey@adacore.com>
7767
7768 * solib-spu.c (ocl_program_data_key): Change type.
7769 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7770 Update.
7771
7772 2019-07-10 Tom Tromey <tromey@adacore.com>
7773
7774 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
7775 (struct solib_aix_inferior_data) <library_list>: Change type.
7776 (solib_aix_inferior_data_handle): Change type.
7777 (get_solib_aix_inferior_data): Update.
7778 (solib_aix_free_library_list): Remove.
7779 (library_list_start_library): Update.
7780 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7781 return type.
7782 (solib_aix_get_library_list)
7783 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7784 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7785
7786 2019-07-10 Tom Tromey <tromey@adacore.com>
7787
7788 * solib-dsbt.c (struct dsbt_info): Add initializers.
7789 (solib_dsbt_pspace_data): Change type.
7790 (dsbt_pspace_data_cleanup): Remove.
7791 (get_dsbt_info, _initialize_dsbt_solib): Update.
7792
7793 2019-07-10 Tom Tromey <tromey@adacore.com>
7794
7795 * spu-tdep.c (spu_overlay_data): Change type.
7796 (spu_get_overlay_table, spu_overlay_new_objfile)
7797 (_initialize_spu_tdep): Update.
7798
7799 2019-07-10 Tom Tromey <tromey@adacore.com>
7800
7801 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7802 destructor.
7803 (dbx_objfile_data_key): Change type and declare later.
7804 (DBX_SYMFILE_INFO): Rewrite.
7805 * dbxread.c (dbx_objfile_data_key): Change type.
7806 (dbx_symfile_init): Update.
7807 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
7808 (coffstab_build_psymtabs, elfstab_build_psymtabs)
7809 (stabsect_build_psymtabs, _initialize_dbxread): Update.
7810
7811 2019-07-10 Tom Tromey <tromey@adacore.com>
7812
7813 * jit.c (jit_program_space_key): Change type. Move lower.
7814 (get_jit_program_space_data): Update.
7815 (jit_program_space_data_cleanup): Remove.
7816 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7817 Update.
7818 (struct jit_program_space_data): Add initializers.
7819
7820 2019-07-10 Tom Tromey <tromey@adacore.com>
7821
7822 * solib-darwin.c (struct darwin_info): Add initializers.
7823 (solib_darwin_pspace_data): Change type.
7824 (darwin_pspace_data_cleanup): Remove.
7825 (get_darwin_info, _initialize_darwin_solib): Update.
7826
7827 2019-07-10 Tom Tromey <tromey@adacore.com>
7828
7829 * remote-sim.c (struct sim_inferior_data): Add initializers,
7830 constructor, and destructor.
7831 (sim_inferior_data_key): Change type. Move lower.
7832 (check_for_duplicate_sim_descriptor): Update.
7833 (get_sim_inferior_data): Use new. Update.
7834 (~sim_inferior_data_cleanup): Rename from
7835 sim_inferior_data_cleanup. Simplify.
7836 (gdbsim_close_inferior, simulator_command)
7837 (sim_command_completer, _initialize_remote_sim): Update.
7838 (next_pid, INITIAL_PID): Move earlier.
7839
7840 2019-07-10 Tom Tromey <tromey@adacore.com>
7841
7842 * python/python-internal.h (create_thread_object): Return
7843 gdbpy_ref.
7844 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7845 * python/py-inferior.c (struct threadlist_entry): Add
7846 constructor.
7847 <thread_obj>: Now a gdbpy_ref.
7848 (thread_to_thread_object): Update.
7849 (add_thread_object): Use new.
7850 (delete_thread_object): Use delete.
7851 (infpy_threads): Update.
7852 (py_free_inferior): Update. Construct "inf_obj" after acquiring
7853 GIL.
7854
7855 2019-07-10 Tom Tromey <tromey@adacore.com>
7856
7857 * valops.c (value_cast): Specialize error message for Ada.
7858
7859 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7860
7861 * breakpoint.c (breakpoint_1): Update doc and parameter names.
7862
7863 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
7864
7865 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7866 bpstat_should_step): Return bool, adjust comments.
7867 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7868 bpstat_should_step): Likewise.
7869
7870 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7871
7872 * features/Makefile: Use feature target descriptions for Arm.
7873 * features/arm/arm-core.c: Generate new file.
7874 * features/arm/arm-fpa.c: Likewise.
7875 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7876 * features/arm/arm-m-profile.c: Likewise.
7877 * features/arm/arm-vfpv2.c: Likewise.
7878 * features/arm/arm-vfpv3.c: Likewise.
7879 * features/arm/xscale-iwmmxt.c: Likewise.
7880 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7881
7882 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7883
7884 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7885 ptrace earlier.
7886
7887 2019-07-10 Alan Hayward <alan.hayward@arm.com>
7888
7889 * features/aarch64-pauth.c: Regenerate.
7890
7891 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
7892
7893 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7894 bool.
7895 (bpstat_what): Use false instead of 0.
7896
7897 2019-07-09 Pedro Alves <palves@redhat.com>
7898
7899 * break-catch-throw.c (is_exception_catchpoint): New.
7900 * breakpoint.c (print_one_breakpoint_location): New parameter
7901 'raw_loc'. Handle it. Use
7902 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7903 looking at the breakpoint's type.
7904 (print_one_breakpoint): If handling "maint info breakpoints", also
7905 print locations of exception catchpoints.
7906 * breakpoint.h (is_exception_catchpoint): Declare.
7907
7908 2019-07-09 Pedro Alves <palves@redhat.com>
7909
7910 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7911 "addr" field.
7912 (allocate_location_exception_catchpoint): New.
7913 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7914 (initialize_throw_catchpoint_ops): Install
7915 allocate_location_exception_catchpoint as allocate_location
7916 method.
7917 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7918 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7919 bp_loc_other.
7920 (breakpoint_address_is_meaningful): Delete.
7921 (bl_address_is_meaningful): New.
7922 (breakpoint_locations_match): Adjust comment.
7923 (bp_location_from_bp_type): New, factored out of...
7924 (bp_location::bp_location(breakpoint *)): ... this.
7925 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7926 factored out of...
7927 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
7928 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7929 breakpoint_address_is_meaningful.
7930 (bp_locations_compare): Adjust comment.
7931 (update_global_location_list): Use bl_address_is_meaningful
7932 instead of breakpoint_address_is_meaningful.
7933 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7934 explicit.
7935 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7936 * python/py-breakpoint.c (bppy_get_location): No longer check
7937 whether location is null.
7938
7939 2019-07-09 Pedro Alves <palves@redhat.com>
7940
7941 PR c++/15468
7942 * breakpoint.c (print_one_breakpoint_location): Remove
7943 single-location assert.
7944
7945 2019-07-09 Tom Tromey <tom@tromey.com>
7946
7947 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7948 * configure: Rebuild.
7949 * configure.ac: Change common to gdbsupport.
7950 * gdbsupport: Rename from common.
7951 * acinclude.m4: Change common to gdbsupport.
7952 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7953 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7954 gdbsupport.
7955 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7956 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7957 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7958 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7959 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7960 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7961 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7962 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7963 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7964 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7965 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7966 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7967 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7968 coff-pe-read.c, command.h, compile/compile-c-support.c,
7969 compile/compile-c.h, compile/compile-cplus-symbols.c,
7970 compile/compile-cplus-types.c, compile/compile-cplus.h,
7971 compile/compile-loc2c.c, compile/compile.c, completer.c,
7972 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7973 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7974 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7975 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7976 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7977 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7978 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7979 features/aarch64-core.c, features/aarch64-fpu.c,
7980 features/aarch64-pauth.c, features/aarch64-sve.c,
7981 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7982 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7983 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7984 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7985 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7986 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7987 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7988 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7989 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7990 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7991 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7992 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7993 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7994 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7995 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7996 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7997 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7998 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7999 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
8000 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
8001 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
8002 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
8003 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
8004 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
8005 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
8006 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
8007 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
8008 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
8009 minsyms.c, mips-linux-tdep.c, namespace.h,
8010 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
8011 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
8012 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
8013 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
8014 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
8015 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
8016 nat/linux-waitpid.c, nat/mips-linux-watch.c,
8017 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
8018 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
8019 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
8020 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
8021 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
8022 procfs.c, producer.c, progspace.h, psymtab.h,
8023 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
8024 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
8025 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
8026 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
8027 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
8028 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
8029 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
8030 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
8031 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
8032 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
8033 target-memory.c, target.c, target.h, target/waitstatus.c,
8034 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
8035 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
8036 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
8037 unittests/array-view-selftests.c,
8038 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
8039 unittests/common-utils-selftests.c,
8040 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
8041 unittests/format_pieces-selftests.c,
8042 unittests/function-view-selftests.c,
8043 unittests/lookup_name_info-selftests.c,
8044 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
8045 unittests/mkdir-recursive-selftests.c,
8046 unittests/observable-selftests.c,
8047 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
8048 unittests/parse-connection-spec-selftests.c,
8049 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
8050 unittests/scoped_fd-selftests.c,
8051 unittests/scoped_mmap-selftests.c,
8052 unittests/scoped_restore-selftests.c,
8053 unittests/string_view-selftests.c, unittests/style-selftests.c,
8054 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
8055 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
8056 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
8057 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
8058 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
8059 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
8060
8061 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8062
8063 * linespec.c (decode_digits_list_mode): Set explicit_line to a
8064 bool value.
8065 (decode_digits_ordinary): Set explicit_line field in sal.
8066 * symtab.c (skip_prologue_sal): Don't skip prologue for a
8067 symtab_and_line that was set on an explicit line number in
8068 assembler code. Do always update the recorded symtab and line if
8069 we do skip the prologue.
8070
8071 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8072
8073 * breakpoint.c (set_breakpoint_location_function): Remove
8074 explicit_loc parameter.
8075 (momentary_breakpoint_from_master): Update call to
8076 set_breakpoint_location_function.
8077 (add_location_to_breakpoint): Likewise.
8078
8079 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
8080
8081 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
8082 required features based on default bfd type when no specific bfd
8083 is present.
8084
8085 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8086
8087 * NEWS: Mention that GDB printf and eval commands can now print
8088 C-style and Ada-style convenience var strings without
8089 calling the inferior.
8090 * printcmd.c (printf_c_string): Locally print GDB internal var
8091 instead of transiting via the inferior.
8092 (printf_wide_c_string): Likewise.
8093
8094 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8095
8096 PR breakpoints/25011
8097 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
8098
8099 2019-07-04 Tom Tromey <tom@tromey.com>
8100
8101 PR tui/24724:
8102 * tui/tui-winsource.c (tui_clear_source_content): Update.
8103 (tui_source_window_base::set_is_exec_point_at): Fix comment.
8104 (tui_update_breakpoint_info): Update.
8105 (tui_set_exec_info_content): Update.
8106 * tui/tui-source.c (tui_set_source_content_nil): Update.
8107 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
8108 has_break.
8109 * tui/tui-data.h (enum tui_bp_flag): New.
8110 (tui_bp_flags): New enum flags type.
8111 (struct tui_source_element) <break_mode>: Change type. Rename
8112 from has_break.
8113 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
8114 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
8115 constants.
8116 * tui/tui-winsource.h: Fix comment.
8117
8118 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8119
8120 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
8121 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
8122 (store_fpregs_to_thread)
8123 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8124 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
8125 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
8126 (IWMMXT_REGS_SIZE): Add define.
8127 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
8128 (fetch_vfp_regs, store_vfp_regs)
8129 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
8130 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
8131
8132 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8133
8134 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
8135 defines.
8136 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
8137 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
8138 (ARM_INT_REGISTER_SIZE): ...to this.
8139 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
8140 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
8141 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
8142 (arm_linux_collect_gregset, supply_nwfpe_register)
8143 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
8144 defines.
8145 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
8146 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
8147 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
8148 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8149 (arm_return_in_memory, arm_store_return_value)
8150 (arm_get_longjmp_target, arm_register_g_packet_guesses)
8151 (arm_record_ld_st_multiple): Likewise.
8152 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8153 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8154
8155 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8156
8157 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8158 AARCH64_DISPLACED_MODIFIED_INSNS.
8159 * aarch64-tdep.c (struct aarch64_displaced_step_data)
8160 (aarch64_displaced_step_copy_insn): Likewise.
8161 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8162 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8163 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8164 ARM_DISPLACED_MODIFIED_INSNS.
8165 * arm-tdep.c (arm_gdbarch_init): Likewise.
8166 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8167 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8168 (struct arm_displaced_step_closure): Use
8169 ARM_DISPLACED_MODIFIED_INSNS.
8170
8171 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8172
8173 * features/Makefile: Remove unused xml files.
8174 * features/aarch64.xml: Remove.
8175 * features/i386/amd64-avx-avx512-linux.xml: Remove.
8176 * features/i386/amd64-avx-avx512.xml: Remove.
8177 * features/i386/amd64-avx-linux.xml: Remove.
8178 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8179 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8180 * features/i386/amd64-avx-mpx-linux.xml: Remove.
8181 * features/i386/amd64-avx-mpx.xml: Remove.
8182 * features/i386/amd64-avx.xml: Remove.
8183 * features/i386/amd64-linux.xml: Remove.
8184 * features/i386/amd64-mpx-linux.xml: Remove.
8185 * features/i386/amd64-mpx.xml: Remove.
8186 * features/i386/amd64.xml: Remove.
8187 * features/i386/i386-avx-avx512-linux.xml: Remove.
8188 * features/i386/i386-avx-avx512.xml: Remove.
8189 * features/i386/i386-avx-linux.xml: Remove.
8190 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8191 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8192 * features/i386/i386-avx-mpx-linux.xml: Remove.
8193 * features/i386/i386-avx-mpx.xml: Remove.
8194 * features/i386/i386-avx.xml: Remove.
8195 * features/i386/i386-linux.xml: Remove.
8196 * features/i386/i386-mmx-linux.xml: Remove.
8197 * features/i386/i386-mmx.xml: Remove.
8198 * features/i386/i386-mpx-linux.xml: Remove.
8199 * features/i386/i386-mpx.xml: Remove.
8200 * features/i386/i386.xml: Remove.
8201 * features/i386/x32-avx-avx512-linux.xml: Remove.
8202 * features/i386/x32-avx-linux.xml: Remove.
8203 * features/i386/x32-linux.xml: Remove.
8204
8205 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8206
8207 * regformats/aarch64.dat: Remove.
8208 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8209 * regformats/i386/amd64-avx-linux.dat: Remove.
8210 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8211 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8212 * regformats/i386/amd64-linux.dat: Remove.
8213 * regformats/i386/amd64-mpx-linux.dat: Remove.
8214 * regformats/i386/amd64.dat: Remove.
8215 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8216 * regformats/i386/i386-avx-linux.dat: Remove.
8217 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8218 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8219 * regformats/i386/i386-linux.dat: Remove.
8220 * regformats/i386/i386-mmx-linux.dat: Remove.
8221 * regformats/i386/i386-mpx-linux.dat: Remove.
8222 * regformats/i386/i386.dat: Remove.
8223 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8224 * regformats/i386/x32-avx-linux.dat: Remove.
8225 * regformats/i386/x32-linux.dat: Remove.
8226
8227 2019-07-04 Alan Hayward <alan.hayward@arm.com>
8228
8229 * aarch64-tdep.c: Remove xml self tests.
8230 * amd64-linux-tdep.c: Likewise.
8231 * amd64-tdep.c: Likewise.
8232 * i386-linux-tdep.c: Likewise.
8233 * i386-tdep.c: Likewise.
8234
8235 2019-07-03 Pedro Alves <palves@redhat.com>
8236
8237 PR cli/24732
8238 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8239 (pipe_cmd_option_defs): New.
8240 (make_pipe_cmd_options_def_group): New.
8241 (pipe_command): Use gdb::option::process_options.
8242 (pipe_command_completer): New function.
8243 (_initialize_cli_cmds): Install completer for "pipe" command.
8244
8245 2019-07-03 Pedro Alves <palves@redhat.com>
8246
8247 * cli/cli-option.c (union option_value) <string>: New field.
8248 (struct option_def_and_value): Add ctor, move ctor, dtor and
8249 use DISABLE_COPY_AND_ASSIGN.
8250 (option_def_and_value::clear_value): New.
8251 (parse_option, save_option_value_in_ctx, get_val_type_str)
8252 (add_setshow_cmds_for_options): Handle var_string.
8253 * cli-option.h (union option_def::var_address) <string>: New
8254 field.
8255 (struct string_option_def): New.
8256 * maint-test-options.c (struct test_options_opts): Add default
8257 ctor and use DISABLE_COPY_AND_ASSIGN.
8258 <string_opt>: New field.
8259 (test_options_opts::~test_options_opts): New.
8260 (test_options_opts::dump): Also dump "-string".
8261 (test_options_option_defs): Install "string.
8262
8263 2019-07-03 Pedro Alves <palves@redhat.com>
8264
8265 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8266 option_value with a null enumeration.
8267 (complete_options): Save the option values in the context.
8268 (save_option_value_in_ctx): New, factored out from ...
8269 (process_options): ... here.
8270 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8271 of the function.
8272 * maint-test-options.c (test_options_opts::dump): New, factored
8273 out from ...
8274 (maintenance_test_options_command_mode): ... here.
8275 (maintenance_test_options_command_completion_result): Delete.
8276 (maintenance_test_options_command_completion_text): Update
8277 comment.
8278 (maintenance_show_test_options_completion_result): Change
8279 prototype. Just print
8280 maintenance_test_options_command_completion_text.
8281 (save_completion_result): New.
8282 (maintenance_test_options_completer_mode): Pass options context to
8283 complete_options, and then save a dump.
8284 (_initialize_maint_test_options): Use add_cmd to install "maint
8285 show test-options-completion-result".
8286
8287 2019-07-03 Pedro Alves <palves@redhat.com>
8288
8289 * NEWS (New commands): Mention "with" and "maint with".
8290 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8291 (with_command, with_command_completer): New.
8292 (pipe_command): Adjust to new repeat_previous
8293 interface.
8294 (_initialize_cli_cmds): Install the "with" command and its "w"
8295 alias.
8296 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8297 declarations.
8298 * cli/cli-setshow.c (parse_cli_var_uinteger)
8299 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8300 argument strings for all var_types.
8301 (get_setshow_command_value_string): New, factored out from ...
8302 (do_show_command): ... this.
8303 * cli/cli-setshow.h: Include <string>.
8304 (get_setshow_command_value_string): Declare.
8305 * command.h (repeat_previous): Now returns const char *. Adjust
8306 comment.
8307 * maint.c: Include "cli/cli-cmds.h".
8308 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8309 (_initialize_maint_cmds): Register the "maintenance with" command.
8310 * top.c (repeat_previous): Move bits from pipe_command here:
8311 Return the saved command line, if any; error out if there's no
8312 command to relaunch.
8313
8314 2019-07-03 Pedro Alves <palves@redhat.com>
8315
8316 * NEWS (New commands): Mention "maint set/show test-settings"
8317 instead of "maint test-settings".
8318 * maint-test-settings.c (maintenance_test_settings_list): Delete.
8319 (maintenance_test_settings_set_list): Rename to ...
8320 (maintenance_set_test_settings_list): ... this.
8321 (maintenance_test_settings_show_list): Rename to ...
8322 (maintenance_show_test_settings_list): ... this.
8323 (maintenance_test_settings_cmd): Delete.
8324 (maintenance_test_settings_set_cmd): ...
8325 (maintenance_set_test_settings_cmd): ... this.
8326 (maintenance_test_settings_show_cmd): ...
8327 (maintenance_show_test_settings_cmd): ... this.
8328 (maintenance_test_settings_show_value_cmd):
8329 (maintenance_show_test_settings_value_cmd): ... this.
8330 (_initialize_maint_test_settings): No longer install the "maint
8331 test-settings" prefix command. Rename "maint test-settings set"
8332 to "maint set test-settings", and "maint test-settings show" to
8333 "maint show test-settings". Adjust all subcommands.
8334
8335 2019-07-03 Pedro Alves <palves@redhat.com>
8336
8337 * maint-test-settings.c: Fix file's intro comment. Replace all
8338 references to "test-options" with references to "test-settings",
8339 in comments.
8340
8341 2019-07-03 Pedro Alves <palves@redhat.com>
8342
8343 * maint-test-settings.c (maintenance_test_settings_xxx)
8344 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8345 New.
8346 (maintenance_test_settings_enums): Use them.
8347 (maintenance_test_settings_enum): Default to
8348 maintenance_test_settings_xxx.
8349 (_initialize_maint_test_settings): Initialize
8350 MAINTENANCE_TEST_SETTINGS_FILENAME.
8351
8352 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8353
8354 * breakpoint.h (remove_breakpoints_inf): Change return type to
8355 void, move function documentation here.
8356 * breakpoint.c (remove_breakpoints_inf): Change return type to
8357 void, move function documentation to header.
8358
8359 2019-07-02 Pedro Alves <palves@redhat.com>
8360
8361 * NEWS (Completion improvements): Mention "info threads".
8362 * thread.c (struct info_threads_opts, info_threads_option_defs)
8363 (make_info_threads_options_def_group): New.
8364 (info_threads_command): Use gdb::option::process_options.
8365 (info_threads_command_completer): New.
8366 (_initialize_thread): Use gdb::option::build_help to build the
8367 help text for "info threads".
8368
8369 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
8370
8371 * defs.h (generic_load): Move from here...
8372 * symfile.h (generic_load): ... to here. Rename name parameter
8373 to args.
8374 * symfile.c (generic_load): Add comment.
8375
8376 2019-07-01 Tom Tromey <tromey@adacore.com>
8377
8378 * dwarf2read.c
8379 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8380 declaration of without_params. Fix formatting.
8381
8382 2019-07-01 Tom Tromey <tromey@adacore.com>
8383
8384 * ada-exp.y (find_primitive_type): Update.
8385 * ada-lang.h (ada_lookup_symbol): Update.
8386 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8387 parameter.
8388 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8389
8390 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8391
8392 PR breakpoints/24541
8393 * gdbarch.c: Regenerate.
8394 * gdbarch.h: Regenerate.
8395 * gdbarch.sh: Add 'stap_adjust_register'.
8396 * i386-tdep.c: Include '<unordered_set>'.
8397 (i386_stap_adjust_register): New function.
8398 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8399 * stap-probe.c (stap_parse_register_operand): Call
8400 'gdbarch_stap_adjust_register'.
8401
8402 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
8403
8404 PR python/24742
8405 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8406 * python/python.c (do_start_initialization): Use 'xmalloc'
8407 instead of 'PyMem_Malloc'.
8408
8409 2019-06-28 Tom Tromey <tromey@adacore.com>
8410
8411 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8412 for Ada.
8413
8414 2019-06-27 Tom Tromey <tromey@adacore.com>
8415
8416 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
8417 objfile_key.
8418 (arm_find_mapping_symbol, arm_record_special_symbol)
8419 (_initialize_arm_tdep): Update.
8420 (arm_objfile_data_free): Remove.
8421
8422 2019-06-27 Tom Tromey <tromey@adacore.com>
8423
8424 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8425 to cp_print_static_field.
8426
8427 2019-06-26 Tom Tromey <tromey@adacore.com>
8428
8429 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8430 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8431 declare.
8432
8433 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8434
8435 * features/aarch64-core.c (create_feature_aarch64_core):
8436 Regenerate.
8437 * features/aarch64-core.xml: Add cpsr flags.
8438
8439 2019-06-26 Alan Hayward <alan.hayward@arm.com>
8440
8441 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8442 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8443
8444 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8445
8446 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8447 field.
8448 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8449 use.
8450 (arm_record_special_symbol): Don't insert new symbol in sorted
8451 position, push it at the end.
8452
8453 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
8454
8455 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8456 (arm_mapping_symbol_s): Remove.
8457 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8458 (arm_mapping_symbol_vec): New typedef.
8459 (struct arm_per_objfile): Add constructor.
8460 <section_maps>: Change type to
8461 std::unique_ptr<arm_mapping_symbol_vec[]>.
8462 (arm_compare_mapping_symbols): Remove.
8463 (arm_find_mapping_symbol): Adjust to section_maps type change.
8464 (arm_objfile_data_free): Call delete on arm_per_objfile.
8465 (arm_record_special_symbol): Adjust to section_maps type change.
8466 Allocate arm_per_objfile with new.
8467
8468 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
8469
8470 * cli/cli-cmds.c (alias_command): Compare the alias prefix
8471 with the command prefix.
8472
8473 2019-06-25 Tom Tromey <tom@tromey.com>
8474
8475 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8476 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8477
8478 2019-06-25 Tom Tromey <tom@tromey.com>
8479
8480 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8481 type.
8482 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8483 protected.
8484
8485 2019-06-25 Tom Tromey <tom@tromey.com>
8486
8487 * tui/tui-winsource.c
8488 (tui_source_window_base::set_is_exec_point_at): Add check against
8489 LOA_ADDRESS.
8490
8491 2019-06-25 Tom Tromey <tom@tromey.com>
8492
8493 * tui/tui-source.c (tui_set_source_content): Don't check before
8494 xfree.
8495 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8496
8497 2019-06-25 Tom Tromey <tom@tromey.com>
8498
8499 * tui/tui-winsource.h (tui_update_source_window_as_is)
8500 (tui_alloc_source_buffer, tui_line_is_displayed)
8501 (tui_addr_is_displayed): Change type of win_info.
8502 * tui/tui-winsource.c (tui_update_source_window_as_is)
8503 (tui_clear_source_content, tui_show_source_line)
8504 (tui_show_source_content, tui_source_window_base::refill)
8505 (tui_source_window_base::set_is_exec_point_at)
8506 (tui_source_window_base::set_is_exec_point_at)
8507 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8508 (tui_alloc_source_buffer, tui_line_is_displayed)
8509 (tui_addr_is_displayed): Change type of win_info. Update.
8510 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8511 (tui_source_window_base::do_make_visible_with_new_height):
8512 Update.
8513 * tui/tui-source.c (tui_set_source_content)
8514 (tui_set_source_content_nil)
8515 (tui_source_window::do_scroll_vertical): Update.
8516 * tui/tui-layout.c (show_layout): Update.
8517 * tui/tui-disasm.c (tui_set_disassem_content)
8518 (tui_disasm_window::do_scroll_vertical): Update.
8519 * tui/tui-data.h (tui_win_content): Remove.
8520 (struct tui_gen_win_info) <content, content_size>: Remove.
8521 (struct tui_source_element): Add initializers and destructor.
8522 (union tui_which_element, struct tui_win_element): Remove.
8523 (struct tui_source_window_base) <content>: New field.
8524 (struct tui_data_window): Remove destructor.
8525 (tui_alloc_content, tui_free_win_content)
8526 (tui_free_all_source_wins_content): Don't declare.
8527 * tui/tui-data.c (tui_initialize_static_data): Update.
8528 (init_content_element, tui_alloc_content): Remove.
8529 (~tui_gen_win_info): Update.
8530 (~tui_data_window, tui_free_all_source_wins_content)
8531 (tui_free_win_content, free_content, free_content_elements):
8532 Remove.
8533
8534 2019-06-25 Tom Tromey <tom@tromey.com>
8535
8536 * tui/tui-winsource.h (tui_clear_source_content)
8537 (tui_erase_source_content, tui_show_source_content): Change type
8538 of win_info.
8539 * tui/tui-winsource.c (tui_clear_source_content)
8540 (tui_erase_source_content, tui_show_source_content): Change type
8541 of win_info.
8542 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8543 * tui/tui-source.h (tui_set_source_content_nil): Change type of
8544 win_info.
8545 * tui/tui-source.c (tui_set_source_content_nil): Change type of
8546 win_info.
8547 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8548
8549 2019-06-25 Tom Tromey <tom@tromey.com>
8550
8551 * tui/tui-winsource.c (tui_clear_source_content)
8552 (tui_source_window_base::set_is_exec_point_at): Update.
8553 * tui/tui-source.c (tui_set_source_content_nil): Update.
8554 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8555 a bool.
8556 * tui/tui-data.c (init_content_element): Update.
8557
8558 2019-06-25 Tom Tromey <tom@tromey.com>
8559
8560 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8561 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8562 * tui/tui-layout.c (init_and_make_win): Update.
8563 * tui/tui.h (enum tui_win_type): Update.
8564 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8565 tui_win_is_auxillary.
8566 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8567 tui_win_is_auxillary.
8568
8569 2019-06-25 Tom Tromey <tom@tromey.com>
8570
8571 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8572 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8573 (tui_delete_data_content_windows, tui_display_all_data)
8574 (tui_data_window::do_scroll_vertical, tui_display_data_from):
8575 Update.
8576 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8577 * tui/tui-regs.c (tui_last_regs_line_no)
8578 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8579 (tui_show_registers): Update.
8580 (tui_show_register_group): Return void. Update.
8581 (tui_display_registers_from, tui_display_reg_element_at_line)
8582 (tui_display_registers_from_line, tui_check_register_values):
8583 Update.
8584 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8585 member.
8586 (struct tui_data_window) <regs_content>: Now a std::vector.
8587 <regs_content_count>: Remove.
8588 (tui_add_content_elements, tui_free_data_content): Don't declare.
8589 * tui/tui-data.c (tui_data_window::clear_detail): Update.
8590 (init_content_element): Remove DATA_WIN case. Add assert.
8591 (tui_add_content_elements): Remove.
8592 (tui_data_window): Update.
8593 (tui_free_data_content): Remove.
8594 (free_content_elements): Remove DATA_WIN case.
8595
8596 2019-06-25 Tom Tromey <tom@tromey.com>
8597
8598 * tui/tui-data.c (tui_data_item_window): Update.
8599 * tui/tui-windata.h (tui_check_data_values): Don't declare.
8600 * tui/tui-windata.c (tui_display_all_data)
8601 (tui_display_data_from_line): Update.
8602 (tui_check_data_values): Remove.
8603 * tui/tui-regs.c (tui_show_register_group)
8604 (tui_display_reg_element_at_line): Update.
8605 * tui/tui-hooks.c (tui_register_changed)
8606 (tui_refresh_frame_and_register_information): Call
8607 tui_check_register_values.
8608 * tui/tui-data.h (struct tui_data_window) <data_content,
8609 data_content_count, data_type>: Remove.
8610 (enum tui_data_type): Remove.
8611
8612 * tui/tui-data.c (tui_data_window::clear_detail)
8613 (~tui_data_window): Update.
8614
8615 2019-06-25 Tom Tromey <tom@tromey.com>
8616
8617 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8618 declare.
8619 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8620 Rename from tui_first_data_item_displayed. Update.
8621 (tui_data_window::refresh_all)
8622 (tui_data_window::do_scroll_vertical): Update.
8623 * tui/tui-data.h (struct tui_data_window)
8624 <first_data_item_displayed>: Declare new method.
8625
8626 2019-06-25 Tom Tromey <tom@tromey.com>
8627
8628 * tui/tui-data.h (tui_init_generic_part): Don't declare.
8629 * tui/tui-data.c (tui_init_generic_part): Remove, moving
8630 contents...
8631 (tui_initialize_static_data): ...here.
8632
8633 2019-06-25 Tom Tromey <tom@tromey.com>
8634
8635 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8636 (tui_display_registers_from, tui_check_register_values): Update.
8637 (tui_display_register): Remove win_info parameter; update.
8638 (tui_get_register): Change type of parameters.
8639 * tui/tui-data.h (struct tui_data_element): Remove.
8640 (union tui_which_element) <data>: Remove.
8641 <data_window>: Change type.
8642 (struct tui_data_item_window): New.
8643 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8644 case. Add assert.
8645 (~tui_data_item_window): New destructor.
8646 (free_content_elements): Remove DATA_ITEM_WIN case.
8647
8648 2019-06-25 Tom Tromey <tom@tromey.com>
8649
8650 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8651 Remove.
8652
8653 2019-06-25 Tom Tromey <tom@tromey.com>
8654
8655 * tui/tui-data.h (struct tui_command_element): Remove.
8656 (union tui_which_element) <command>: Remove.
8657 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
8658 assert.
8659 (free_content_elements): Remove CMD_WIN case.
8660
8661 2019-06-25 Tom Tromey <tom@tromey.com>
8662
8663 * tui/tui-layout.c (tui_set_layout): Update.
8664 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8665 * tui/tui-data.c (layout_def): Update.
8666
8667 2019-06-25 Tom Tromey <tom@tromey.com>
8668
8669 * tui/tui-wingeneral.c (tui_refresh_all): Update.
8670 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8671 (tui_source_window_base::set_new_height): Update.
8672 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8673 Update.
8674 (tui_set_locator_fullname, tui_set_locator_info)
8675 (tui_show_frame_info): Update.
8676 * tui/tui-source.c (tui_set_source_content)
8677 (tui_source_is_displayed): Update.
8678 * tui/tui-layout.c (show_source_disasm_command, show_data)
8679 (show_source_or_disasm_and_command): Update.
8680 * tui/tui-disasm.c (tui_set_disassem_content)
8681 (tui_get_begin_asm_address): Update.
8682 * tui/tui-data.h (struct tui_locator_element): Remove.
8683 (union tui_which_element) <locator>: Remove.
8684 (struct tui_locator_window): New.
8685 (tui_locator_win_info_ptr): Change return type.
8686 * tui/tui-data.c (_locator): Change type.
8687 (tui_locator_win_info_ptr): Change return type.
8688 (init_content_element): Remove LOCATOR_WIN case. Add assert.
8689 (tui_alloc_content): Add assert.
8690
8691 2019-06-25 Tom Tromey <tom@tromey.com>
8692
8693 * tui/tui-winsource.c
8694 (tui_exec_info_window::maybe_allocate_content): New method.
8695 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8696 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8697 (make_source_or_disasm_window): Add cast.
8698 * tui/tui-data.h (union tui_which_element) <simple_string>:
8699 Remove.
8700 (struct tui_source_info): New.
8701 (struct tui_source_window_base) <execution_info>: Change type.
8702 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8703 case, and add assert.
8704 (tui_alloc_content): Add assert.
8705
8706 2019-06-25 Tom Tromey <tom@tromey.com>
8707
8708 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8709 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8710 * tui/tui-data.c (tui_alloc_win_info): Remove.
8711
8712 2019-06-25 Tom Tromey <tom@tromey.com>
8713
8714 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8715 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8716 can_highlight.
8717
8718 2019-06-25 Tom Tromey <tom@tromey.com>
8719
8720 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8721 make_visible_with_new_height method.
8722 (tui_win_info::make_visible_with_new_height): New method.
8723 (tui_source_window_base::do_make_visible_with_new_height)
8724 (tui_data_window::do_make_visible_with_new_height)
8725 (tui_cmd_window::do_make_visible_with_new_height): New methods.
8726 (make_visible_with_new_height): Remove.
8727 (tui_resize_all, tui_adjust_win_heights): Use
8728 make_visible_with_new_height method.
8729 * tui/tui-data.h (struct tui_win_info)
8730 <do_make_visible_with_new_height, make_visible_with_new_height>:
8731 New methods.
8732 (struct tui_source_window_base, struct tui_data_window)
8733 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8734 methods.
8735
8736 2019-06-25 Tom Tromey <tom@tromey.com>
8737
8738 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8739 method.
8740 (update_tab_width): Call update_tab_width method.
8741 * tui/tui-data.h (struct tui_win_info)
8742 (struct tui_source_window_base) <update_tab_width>: New methods.
8743
8744 2019-06-25 Tom Tromey <tom@tromey.com>
8745
8746 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8747 parameter.
8748 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8749 parameter.
8750 (tui_gen_win_info::make_visible): Update.
8751 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8752 parameter.
8753 * tui/tui-data.h (enum tui_box): New enum.
8754 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8755
8756 2019-06-25 Tom Tromey <tom@tromey.com>
8757
8758 * tui/tui-layout.c (make_source_or_disasm_window): Always use
8759 init_and_make_win for EXEC_INFO_WIN.
8760 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8761 longer inline.
8762 (struct tui_win_info) <~tui_win_info>: Inline.
8763 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8764 Don't declare.
8765 * tui/tui-data.c (source_win, disasm_win): Remove globals.
8766 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8767 Remove.
8768 (tui_initialize_static_data): Update.
8769 (~tui_gen_win_info): Handle more cleanup here.
8770 (~tui_source_window_base): Delete "execution_info".
8771 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8772
8773 2019-06-25 Tom Tromey <tom@tromey.com>
8774
8775 * tui/tui-layout.c (make_command_window): Don't set
8776 can_highlight.
8777 (show_source_disasm_command): Call the reset method.
8778 (show_data): Don't set can_highlight. Call the reset method.
8779 (tui_gen_win_info::reset): Rename from init_gen_win_info
8780 (init_and_make_win): Simplify. Return tui_gen_win_info.
8781 (show_source_or_disasm_and_command): Call the reset method.
8782 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8783 (struct tui_cmd_window): Set can_highlight.
8784
8785 2019-06-25 Tom Tromey <tom@tromey.com>
8786
8787 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8788 from make_visible.
8789 (tui_make_visible, tui_make_invisible): Rewrite.
8790 (tui_win_info::make_visible): Remove.
8791 (tui_source_window_base::make_visible): Update.
8792 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8793 method. Moved from...
8794 (struct tui_win_info) <make_visible>: ...here.
8795
8796 2019-06-25 Tom Tromey <tom@tromey.com>
8797
8798 * tui/tui-winsource.c
8799 (tui_source_window_base::do_scroll_horizontal): Remove direction
8800 parameter.
8801 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8802 direction parameter.
8803 * tui/tui-win.c (tui_win_info::forward_scroll)
8804 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8805 (tui_win_info::right_scroll): Update.
8806 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8807 direction parameter.
8808 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8809 direction parameter.
8810 * tui/tui-data.h (enum tui_scroll_direction): Remove.
8811 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8812 Remove direction parameter.
8813 (struct tui_source_window_base, struct tui_source_window)
8814 (struct tui_disasm_window, struct tui_data_window)
8815 (struct tui_cmd_window): Update.
8816
8817 2019-06-25 Tom Tromey <tom@tromey.com>
8818
8819 * tui/tui-winsource.h (tui_set_exec_info_content)
8820 (tui_show_exec_info_content, tui_erase_exec_info_content)
8821 (tui_clear_exec_info_content, tui_update_exec_info): Change
8822 argument to tui_source_window_base.
8823 * tui/tui-winsource.c (tui_set_exec_info_content)
8824 (tui_show_exec_info_content, tui_erase_exec_info_content)
8825 (tui_clear_exec_info_content, tui_update_exec_info): Change
8826 argument to tui_source_window_base.
8827
8828 2019-06-25 Tom Tromey <tom@tromey.com>
8829
8830 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8831 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8832
8833 2019-06-25 Tom Tromey <tom@tromey.com>
8834
8835 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8836 check.
8837
8838 2019-06-25 Tom Tromey <tom@tromey.com>
8839
8840 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8841 type to void.
8842 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8843 type to void.
8844 * tui/tui-source.c (tui_set_source_content): Update.
8845 * tui/tui-disasm.c (tui_set_disassem_content): Update.
8846
8847 2019-06-25 Tom Tromey <tom@tromey.com>
8848
8849 * tui/tui-win.c (window_name_completer, tui_set_focus)
8850 (tui_all_windows_info): Use name method.
8851 * tui/tui-data.h (struct tui_gen_win_info)
8852 (struct tui_source_window, struct tui_disasm_window)
8853 (struct tui_data_window, struct tui_cmd_window) <name>: New
8854 method.
8855 (tui_win_name): Don't declare.
8856 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8857 (tui_win_name): Remove.
8858
8859 2019-06-25 Tom Tromey <tom@tromey.com>
8860
8861 * tui/tui-winsource.h (tui_update_source_window)
8862 (tui_update_source_window_as_is): Change parameter type.
8863 * tui/tui-winsource.c (tui_update_source_window): Change win_info
8864 to be a tui_source_window_base.
8865 (tui_update_source_window_as_is): Likewise.
8866 * tui/tui-win.c (make_visible_with_new_height): Update.
8867
8868 2019-06-25 Tom Tromey <tom@tromey.com>
8869
8870 * tui/tui-winsource.c (tui_erase_source_content)
8871 (tui_show_source_content, tui_show_exec_info_content)
8872 (tui_erase_exec_info_content): Use refresh_window method.
8873 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8874 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8875 from tui_refresh_win.
8876 (tui_data_window::refresh_window): New method.
8877 (tui_win_info::refresh, tui_source_window_base::refresh)
8878 (tui_refresh_all): Use refresh_window method.
8879 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8880 method.
8881 * tui/tui-regs.c (tui_display_register): Call refresh_window
8882 method.
8883 * tui/tui-layout.c (show_source_disasm_command)
8884 (show_source_or_disasm_and_command): Call refresh_window method.
8885 * tui/tui-data.h (struct tui_gen_win_info)
8886 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8887 New method.
8888
8889 2019-06-25 Tom Tromey <tom@tromey.com>
8890
8891 * tui/tui.c (tui_rl_other_window, tui_enable)
8892 (tui_is_window_visible, tui_get_command_dimension): Update.
8893 * tui/tui-winsource.c (tui_update_source_window_as_is)
8894 (tui_clear_source_content, tui_erase_source_content)
8895 (tui_show_source_line, tui_source_window_base::refill)
8896 (tui_source_window_base::do_scroll_horizontal)
8897 (tui_source_window_base::set_is_exec_point_at)
8898 (tui_update_breakpoint_info, tui_set_exec_info_content)
8899 (tui_alloc_source_buffer, tui_line_is_displayed)
8900 (tui_addr_is_displayed): Update.
8901 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8902 (tui_check_and_display_highlight_if_needed)
8903 (tui_win_info::make_visible, tui_win_info::refresh)
8904 (tui_refresh_all): Update.
8905 * tui/tui-windata.c (tui_first_data_item_displayed)
8906 (tui_delete_data_content_windows, tui_erase_data_content)
8907 (tui_display_all_data, tui_data_window::refresh_all)
8908 (tui_check_data_values): Update.
8909 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8910 (tui_set_win_focus_to, tui_win_info::forward_scroll)
8911 (tui_win_info::backward_scroll, tui_refresh_all_win)
8912 (tui_resize_all, tui_set_focus, tui_all_windows_info)
8913 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8914 (tui_source_window_base::set_new_height)
8915 (tui_data_window::set_new_height)
8916 (make_invisible_and_set_new_height)
8917 (make_visible_with_new_height, new_height_ok)
8918 (parse_scrolling_args): Update.
8919 * tui/tui-stack.c (tui_show_frame_info): Update.
8920 * tui/tui-source.c (tui_set_source_content)
8921 (tui_set_source_content_nil, tui_source_is_displayed)
8922 (tui_source_window::do_scroll_vertical): Update.
8923 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8924 (tui_display_registers_from, tui_display_reg_element_at_line)
8925 (tui_check_register_values, tui_reg_command): Update.
8926 * tui/tui-layout.c (tui_default_win_height)
8927 (show_source_disasm_command, show_data, init_and_make_win)
8928 (show_source_or_disasm_and_command): Update.
8929 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8930 (tui_redisplay_readline, tui_mld_flush)
8931 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8932 (tui_getc): Update.
8933 * tui/tui-disasm.c (tui_set_disassem_content)
8934 (tui_disasm_window::do_scroll_vertical): Update.
8935 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8936 Now virtual.
8937 (struct tui_win_info): Derive from tui_gen_win_info.
8938 <~tui_win_info>: Mark as override.
8939 <generic>: Remove member.
8940 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8941 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8942 (~tui_data_window, ~tui_win_info)
8943 (tui_free_all_source_wins_content): Update.
8944 * tui/tui-command.c (tui_refresh_cmd_win): Update.
8945
8946 2019-06-25 Tom Tromey <tom@tromey.com>
8947
8948 * tui/tui-layout.c (init_and_make_win): Use new.
8949 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8950 destructor, initializers.
8951 (tui_alloc_generic_win_info): Don't declare.
8952 * tui/tui-data.c (_locator): Add argument to constructor.
8953 (source_win, disasm_win): New globals.
8954 (exec_info): Remove.
8955 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8956 Update.
8957 (tui_alloc_generic_win_info): Remove.
8958 (init_content_element): Use new.
8959 (tui_win_info::tui_win_info): Update.
8960 (free_content_elements) <case DATA_WIN>: Use delete.
8961
8962 2019-06-25 Tom Tromey <tom@tromey.com>
8963
8964 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8965 * tui/tui-windata.c (tui_first_data_item_displayed)
8966 (tui_delete_data_content_windows): Update.
8967 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8968 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8969 (tui_display_registers_from, tui_check_register_values): Update.
8970 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8971 pointer.
8972 * tui/tui-data.c (init_content_element): Update. Allocate the new
8973 window.
8974 (tui_free_data_content): Update.
8975 (free_content_elements) <case DATA_WIN>: Free the window.
8976
8977 2019-06-25 Tom Tromey <tom@tromey.com>
8978
8979 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8980 Update.
8981 * tui/tui-layout.c (make_command_window)
8982 (show_source_disasm_command, show_data, init_and_make_win)
8983 (show_source_or_disasm_and_command): Update.
8984 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8985 method.
8986 <can_highight, is_highlighted>: Now bool.
8987 (tui_set_win_highlight): Don't declare.
8988 * tui/tui-data.c (tui_set_win_highlight): Remove.
8989
8990 2019-06-25 Tom Tromey <tom@tromey.com>
8991
8992 * tui/tui-wingeneral.c (make_visible): Remove check of window
8993 type.
8994
8995 2019-06-25 Tom Tromey <tom@tromey.com>
8996
8997 * tui/tui-win.c (tui_win_info::max_height)
8998 (tui_cmd_window::max_height): New methods.
8999 (new_height_ok): Call max_height.
9000 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
9001 <max_height>: New method.
9002
9003 2019-06-25 Tom Tromey <tom@tromey.com>
9004
9005 * tui/tui-win.c (tui_source_window_base::set_new_height)
9006 (tui_data_window::set_new_height): New methods.
9007 (make_invisible_and_set_new_height): Call set_new_height method.
9008 * tui/tui-data.h (struct tui_win_info)
9009 (struct tui_source_window_base, struct tui_data_window)
9010 <set_new_height>: New method.
9011
9012 2019-06-25 Tom Tromey <tom@tromey.com>
9013
9014 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
9015 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
9016 tui_refresh_data_win.
9017 * tui/tui-win.c (tui_source_window_base::refresh_all): New
9018 method.
9019 (tui_refresh_all_win): Call the refresh_all method.
9020 (tui_set_focus): Likewise.
9021 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
9022 (struct tui_source_window_base, struct tui_data_window) <refresh>:
9023 Likewise.
9024
9025 2019-06-25 Tom Tromey <tom@tromey.com>
9026
9027 * tui/tui-winsource.h (tui_refill_source_window)
9028 (tui_set_is_exec_point_at): Don't declare.
9029 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
9030 (tui_source_window_base::refill): Rename from
9031 tui_refill_source_window.
9032 (tui_source_window_base::do_scroll_horizontal): Update.
9033 (tui_source_window_base::set_is_exec_point_at): Rename from
9034 tui_set_is_exec_point_at.
9035 (tui_update_all_breakpoint_info): Update.
9036 * tui/tui-stack.c (tui_show_frame_info): Update.
9037 * tui/tui-layout.c (show_data): Add cast.
9038 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
9039 * tui/tui-data.h (struct tui_source_window_base) <refill,
9040 set_is_exec_point_at>: New methods.
9041 (tui_source_windows, tui_add_to_source_windows): Update types.
9042 (tui_add_to_source_windows): Remove redundant declaration.
9043 * tui/tui-data.c (source_windows): Store tui_source_window_base.
9044 (tui_source_windows): Change return type.
9045 (tui_clear_source_windows_detail): Update.
9046 (tui_add_to_source_windows): Change type of parameter.
9047 (tui_free_all_source_wins_content): Update.
9048
9049 2019-06-25 Tom Tromey <tom@tromey.com>
9050
9051 * tui/tui-wingeneral.c (tui_win_info::refresh)
9052 (tui_source_window_base::refresh): New methods.
9053 (tui_refresh_all): Call the refresh method.
9054 * tui/tui-data.h (struct tui_win_info)
9055 (struct tui_source_window_base) <refresh>: New method.
9056
9057 2019-06-25 Tom Tromey <tom@tromey.com>
9058
9059 * tui/tui.h (tui_is_window_visible): Return bool.
9060 * tui/tui.c (tui_is_window_visible): Return bool.
9061 * tui/tui-wingeneral.c (tui_make_window, make_visible)
9062 (tui_make_visible, tui_make_invisible)
9063 (tui_win_info::make_visible)
9064 (tui_source_window_base::make_visible, make_all_visible)
9065 (tui_make_all_visible, tui_make_all_invisible): Update.
9066 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
9067 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
9068 bool.
9069 (struct tui_win_info, struct tui_source_window_base)
9070 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
9071 * tui/tui-data.c (tui_init_generic_part): Update.
9072
9073 2019-06-25 Tom Tromey <tom@tromey.com>
9074
9075 * tui/tui-wingeneral.c (tui_win_info::make_visible)
9076 (tui_source_window_base::make_visible): New methods.
9077 (make_all_visible): Make method call.
9078 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
9079 (struct tui_source_window_base, struct tui_cmd_window): Override
9080 make_visible.
9081 (tui_win_is_source_type): Don't declare.
9082 * tui/tui-data.c (tui_win_is_source_type): Remove.
9083
9084 2019-06-25 Tom Tromey <tom@tromey.com>
9085
9086 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
9087 NULL check.
9088
9089 2019-06-25 Tom Tromey <tom@tromey.com>
9090
9091 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
9092 Inline constructor. Add initializers for members.
9093 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
9094 constructors; now inline in class.
9095
9096 2019-06-25 Tom Tromey <tom@tromey.com>
9097
9098 * tui/tui-regs.c (tui_show_registers): Update.
9099 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
9100 bool.
9101 * tui/tui-data.c (tui_data_window::clear_detail)
9102 (tui_data_window): Update.
9103
9104 2019-06-25 Tom Tromey <tom@tromey.com>
9105
9106 * tui/tui-windata.c (tui_display_all_data)
9107 (tui_display_data_from_line, tui_display_data_from)
9108 (tui_check_data_values, tui_data_window::do_scroll_vertical):
9109 Update.
9110 * tui/tui-regs.c (tui_last_regs_line_no)
9111 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
9112 (tui_show_registers, tui_show_register_group)
9113 (tui_display_registers_from, tui_display_reg_element_at_line)
9114 (tui_display_registers_from_line, tui_check_register_values)
9115 (tui_reg_next, tui_reg_prev): Update.
9116 * tui/tui-layout.c (tui_set_layout, show_data): Update.
9117 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
9118 tui_data_window.
9119 (struct tui_win_info) <detail>: Remove. Add new fields from
9120 tui_data_info.
9121 (TUI_DATA_WIN): Add cast.
9122 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
9123 (~tui_data_window): Simplify.
9124
9125 2019-06-25 Tom Tromey <tom@tromey.com>
9126
9127 * tui/tui-layout.c (show_source_disasm_command)
9128 (show_source_or_disasm_and_command): Update.
9129 * tui/tui-io.c (update_cmdwin_start_line)
9130 (tui_redisplay_readline): Update.
9131 * tui/tui-data.h (struct tui_command_info): Remove.
9132 (struct tui_win_info) <detail>: Remove command_info member.
9133 (struct tui_data_window) <start_line>: New member, from
9134 tui_command_info.
9135 (TUI_CMD_WIN): Add casts.
9136
9137 2019-06-25 Tom Tromey <tom@tromey.com>
9138
9139 * tui/tui-winsource.c (tui_update_source_window)
9140 (tui_refill_source_window)
9141 (tui_source_window_base::do_scroll_horizontal)
9142 (tui_update_breakpoint_info, tui_set_exec_info_content)
9143 (tui_show_exec_info_content, tui_erase_exec_info_content)
9144 (tui_clear_exec_info_content): Update.
9145 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
9146 Update.
9147 * tui/tui-win.c (make_invisible_and_set_new_height)
9148 (make_visible_with_new_height): Update.
9149 * tui/tui-source.c (tui_set_source_content)
9150 (tui_show_symtab_source): Update.
9151 * tui/tui-layout.c (extract_display_start_addr)
9152 (show_source_disasm_command, show_data)
9153 (make_source_or_disasm_window)
9154 (show_source_or_disasm_and_command): Update.
9155 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9156 (tui_disasm_window::do_scroll_vertical): Remove shadowing
9157 "gdbarch".
9158 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
9159 to tui_source_window_base.
9160 (struct tui_win_info) <detail>: Remove source_info member.
9161 (struct tui_source_window_base) <has_locator>: Inline.
9162 Move contents from tui_source_info; rename has_locator member to
9163 m_has_locator.
9164 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9165 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9166 header file.
9167 (tui_source_window_base::clear_detail, ~tui_source_window_base):
9168 Simplify.
9169 (tui_free_all_source_wins_content): Cast to
9170 tui_source_window_base.
9171
9172 2019-06-25 Tom Tromey <tom@tromey.com>
9173
9174 * tui/tui-win.c (make_invisible_and_set_new_height)
9175 (make_visible_with_new_height): Call has_locator method.
9176 * tui/tui-layout.c (show_source_disasm_command, show_data)
9177 (show_source_or_disasm_and_command): Update for bool change.
9178 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9179 (tui_win_info) <has_locator>: New method.
9180 (struct tui_source_window_base) <has_locator>: New method.
9181 (tui_win_has_locator): Don't declare.
9182 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9183 from tui_win_has_locator.
9184 (tui_source_window_base): Use false, not FALSE.
9185
9186 2019-06-25 Tom Tromey <tom@tromey.com>
9187
9188 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9189 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9190 clear_detail method directly.
9191 (tui_clear_win_detail): Remove.
9192
9193 2019-06-25 Tom Tromey <tom@tromey.com>
9194
9195 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9196 "this", not TUI_DISASM_WIN.
9197
9198 2019-06-25 Tom Tromey <tom@tromey.com>
9199
9200 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
9201 declare.
9202 * tui/tui-winsource.c
9203 (tui_source_window_base::do_scroll_horizontal): Rename from
9204 tui_horizontal_source_scroll.
9205 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9206 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9207 from tui_vertical_data_scroll.
9208 * tui/tui-win.h (tui_scroll): Don't declare.
9209 * tui/tui-win.c (tui_win_info::forward_scroll)
9210 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9211 (tui_win_info::right_scroll): Rename and update.
9212 (tui_scroll_forward_command, tui_scroll_backward_command)
9213 (tui_scroll_left_command, tui_scroll_right_command): Update.
9214 (tui_scroll): Remove.
9215 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9216 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9217 from tui_vertical_source_scroll.
9218 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9219 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9220 from tui_vertical_disassem_scroll.
9221 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9222 do_scroll_horizontal>: New methods.
9223 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9224 Likewise.
9225 (struct tui_source_window_base): Add do_scroll_horizontal.
9226 (struct tui_source_window, struct tui_disasm_window): Add
9227 do_scroll_vertical.
9228 (struct tui_data_window, struct tui_cmd_window): Add
9229 do_scroll_horizontal and do_scroll_vertical.
9230 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9231
9232 2019-06-25 Tom Tromey <tom@tromey.com>
9233
9234 * tui/tui-data.h (struct tui_source_window_base): New struct.
9235 (struct tui_source_window): Derive from tui_source_window_base.
9236 (struct tui_disasm_window): New struct.
9237 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9238 from tui_source_window::clear_detail.
9239 (tui_source_window_base): Rename from tui_source_window.
9240 (~tui_source_window_base): Rename from ~tui_source_window.
9241 (tui_alloc_win_info): Create a tui_disasm_window.
9242
9243 2019-06-25 Tom Tromey <tom@tromey.com>
9244
9245 * tui/tui-data.h (struct tui_source_window)
9246 (struct tui_data_window): Declare destructors.
9247 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9248 destructors.
9249 (tui_win_info): Simplify.
9250
9251 2019-06-25 Tom Tromey <tom@tromey.com>
9252
9253 * tui/tui-winsource.c (tui_display_main)
9254 (tui_update_source_windows_with_addr)
9255 (tui_update_all_breakpoint_info): Update.
9256 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9257 (new_height_ok, parse_scrolling_args): Update.
9258 * tui/tui-stack.c (tui_show_frame_info): Update.
9259 * tui/tui-data.h (struct tui_list): Remove.
9260 (tui_source_windows): Return a reference to a std::vector.
9261 * tui/tui-data.c (source_windows): Now a std::vector.
9262 (tui_source_windows): Change return type.
9263 (tui_clear_source_windows): Rewrite.
9264 (tui_clear_source_windows_detail, tui_add_to_source_windows)
9265 (tui_free_all_source_wins_content): Rewrite.
9266
9267 2019-06-25 Tom Tromey <tom@tromey.com>
9268
9269 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9270 (struct tui_data_window, struct tui_cmd_window): Declare
9271 clear_detail method.
9272 * tui/tui-data.c (tui_source_window::clear_detail)
9273 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9274 methods.
9275 (tui_clear_win_detail): Simplify.
9276
9277 2019-06-25 Tom Tromey <tom@tromey.com>
9278
9279 * tui/tui-layout.c (make_source_window, make_disasm_window)
9280 (make_source_or_disasm_window): Remove win_info_ptr parameter.
9281 Return the new window.
9282 (show_source_disasm_command, show_data)
9283 (show_source_or_disasm_and_command): Update.
9284
9285 2019-06-25 Tom Tromey <tom@tromey.com>
9286
9287 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9288 parameter. Return the new window.
9289 (show_source_disasm_command): Update and remove NULL check.
9290 (show_source_or_disasm_and_command): Update.
9291
9292 2019-06-25 Tom Tromey <tom@tromey.com>
9293
9294 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9295
9296 2019-06-25 Tom Tromey <tom@tromey.com>
9297
9298 * tui/tui-data.h (struct tui_win_info): Make constructor
9299 protected. Make destructor virtual. Add initializers.
9300 (tui_source_window, tui_data_window, tui_cmd_window): New
9301 classes.
9302 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
9303 constructor. Add "type" parameter.
9304 (tui_source_window, tui_data_window, tui_cmd_window): New
9305 constructors.
9306 (tui_alloc_win_info): Instantiate the appropriate subclass.
9307
9308 2019-06-25 Tom Tromey <tom@tromey.com>
9309
9310 * tui/tui-win.c (tui_resize_all): Use delete.
9311 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9312 destructor.
9313 (tui_free_window): Don't declare.
9314 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9315 Update.
9316
9317 2019-06-25 Tom Tromey <tom@tromey.com>
9318
9319 * tui/tui-data.h (struct tui_win_info): Add constructor.
9320 * tui/tui-data.c (tui_alloc_win_info): Use new.
9321 (tui_free_window): Use delete.
9322
9323 2019-06-22 Tom Tromey <tom@tromey.com>
9324
9325 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9326 declare.
9327 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9328
9329 2019-06-22 Tom Tromey <tom@tromey.com>
9330
9331 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9332 declare.
9333 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9334
9335 2019-06-22 Tom de Vries <tdevries@suse.de>
9336
9337 * dwarf2read.c (create_addrmap_from_aranges)
9338 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9339 instead of '%zu'.
9340
9341 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
9342
9343 * dwarf2read.h (dwarf2_section_info_def): Remove.
9344 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9345 * dwarf2read.c (struct dwo_sections) <types>: Change type to
9346 std::vector<dwarf2_section_info>.
9347 (struct dwo_file) <~dwo_file>: Remove.
9348 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9349 types field.
9350 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9351 (dwarf2_read_debug_names): Likewise.
9352 (create_debug_types_hash_table): Change parameter type to
9353 array_view, adjust code accordingly.
9354 (dwarf2_locate_dwo_sections): Adjust to std::vector.
9355 (partial_die_info::fixup): Likewise.
9356 (determine_prefix): Likewise.
9357 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9358
9359 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9360
9361 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9362 gdb_bfd_ref_ptr.
9363 <~dwo_file>: Remove call to gdb_bfd_unref.
9364 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9365 gdb_bfd_ref_ptr::get.
9366
9367 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9368
9369 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9370 type to htab_up.
9371 * dwarf2read.c (struct dwo_file): Initialize fields.
9372 <~dwo_file>: New.
9373 (free_dwo_file): Remove, move content to ~dwo_file.
9374 (struct dwo_file_deleter): Remove.
9375 (dwo_file_up>: Remove custom deleter.
9376 (free_dwo_files): Remove.
9377 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9378 dwo_files.
9379 (process_skeletonless_type_units): Call unique_ptr::get.
9380 (allocate_dwo_file_hash_table): Add deleter to created hash
9381 table. Change return type to htab_up.
9382 (lookup_dwo_file_slot): Don't memset dwo_file, call
9383 unique_ptr::get.
9384 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9385 (create_dwo_unit_in_dwp_v2): Likewise.
9386 (open_and_init_dwo_file): Likewise.
9387 (free_dwo_file_from_slot): Remove.
9388
9389 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
9390
9391 * dwarf2read.h (struct dwarf2_section_info) <readin,
9392 is_virtual>: Change type to bool.
9393 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9394 true instead of 1.
9395
9396 2019-06-19 Tom Tromey <tom@tromey.com>
9397
9398 * tui/tui-data.h (tui_init_content_element): Don't declare.
9399
9400 2019-06-19 Tom Tromey <tom@tromey.com>
9401
9402 * tui/tui-data.h (tui_init_win_info): Don't declare.
9403
9404 2019-06-19 Tom de Vries <tdevries@suse.de>
9405
9406 * dwarf2read.h (abstract_to_concrete): Change type to
9407 std::unordered_map<sect_offset, std::vector<sect_offset>,
9408 gdb::hash_enum<sect_offset>>.
9409
9410 2019-06-19 Tom Tromey <tromey@adacore.com>
9411
9412 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9413 EVAL_AVOID_SIDE_EFFECTS specially.
9414
9415 2019-06-19 Tom Tromey <tromey@adacore.com>
9416
9417 * source-cache.c (highlighter): New global.
9418 (source_cache::get_source_lines): Create a highlighter on demand.
9419
9420 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
9421
9422 * defs.h (deprecated_interactive_hook): Delete declaration.
9423 * interps.c (clear_interpreter_hooks): Remove use of
9424 deprecated_interactive_hook.
9425 * top.c (deprecated_interactive_hook): Delete definition.
9426 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9427
9428 2019-06-18 Tom de Vries <tdevries@suse.de>
9429
9430 PR gdb/24515
9431 * dwarf2read.h (abstract_to_concrete): Change type from
9432 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9433 std::unordered_map<sect_offset, std::vector<sect_offset>>.
9434 * dwarf2read.c (read_variable): Update.
9435 (dwarf2_fetch_die_loc_sect_off): Update.
9436
9437 2019-06-17 Tom de Vries <tdevries@suse.de>
9438
9439 PR gdb/24617
9440 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9441 accessing parent[parent_len - 1].
9442
9443 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
9444
9445 PR gdb/24364
9446 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9447 call dtrace_process_dof with NULL dof.
9448
9449 2019-06-16 Tom de Vries <tdevries@suse.de>
9450
9451 PR gdb/24445
9452 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9453
9454 2019-06-16 Tom Tromey <tom@tromey.com>
9455
9456 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9457 (make_all_visible): Use address of member.
9458
9459 2019-06-16 Tom Tromey <tom@tromey.com>
9460
9461 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9462 (tui_free_window, free_content, free_content_elements): Remove
9463 unnecessary cast.
9464 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9465 cast.
9466 * tui/tui-regs.c (tui_show_register_group)
9467 (tui_display_registers_from, tui_display_reg_element_at_line):
9468 Remove unnecessary cast.
9469
9470 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
9471
9472 * linux-nat.c (normal_mask): Delete.
9473 (_initialize_linux_nat): Don't initialise normal_mask.
9474
9475 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
9476
9477 PR gdb/24445
9478 * dwarf-index-write.h (write_psymtabs_to_index): Add
9479 dwz_basename parameter.
9480 * dwarf-index-write.c (write_gdbindex): Move file writing to
9481 write_gdbindex_1. Change return type void.
9482 (assert_file_size): Move up, remove filename parameter.
9483 (write_gdbindex_1): New function.
9484 (write_debug_names): Change return type to void, call
9485 assert_file_size.
9486 (struct index_wip_file): New struct.
9487 (write_psymtabs_to_index): Add dwz_basename parameter. Move
9488 file logic to index_wip_file. Write index for dwz file if
9489 needed.
9490 (save_gdb_index_command): Pass basename of dwz file, if present.
9491 * dwarf-index-cache.c (index_cache::store): Obtain and pass
9492 build-id of dwz file, if present.
9493 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9494 (dwarf2_get_dwz_file): Likewise.
9495 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9496 (dwarf2_get_dwz_file): Likewise.
9497
9498 2019-06-16 Tom Tromey <tom@tromey.com>
9499
9500 * coffread.c (process_coff_symbol): Use xstrdup.
9501 * value.c (create_internalvar): Use xstrdup.
9502
9503 2019-06-16 Tom Tromey <tom@tromey.com>
9504
9505 * valops.c (value_cast, value_slice): Remove unnecessary cast.
9506 * breakpoint.c (stopin_command, stopat_command)
9507 (until_break_command, decode_location_default): Remove unnecessary
9508 cast.
9509 * utils.c (subset_compare): Remove unnecessary cast.
9510 * ada-lang.c (ada_update_initial_language): Remove unnecessary
9511 cast.
9512 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9513 cast.
9514 * infcmd.c (path_command): Remove unnecessary cast.
9515 * coffread.c (decode_type): Remove unnecessary cast.
9516 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9517 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9518 * tui/tui-stack.c (tui_show_locator_content)
9519 (tui_show_frame_info): Remove unnecessary cast.
9520 * tui/tui-win.c (tui_scroll_forward_command)
9521 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9522 (parse_scrolling_args): Remove unnecessary cast.
9523 * tui/tui-data.c (init_win_info, tui_del_window)
9524 (tui_free_window, tui_del_data_windows, tui_free_data_content)
9525 (free_content_elements): Remove unnecessary cast.
9526 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9527 unnecessary cast.
9528 * tui/tui-source.c (tui_set_source_content)
9529 (tui_vertical_source_scroll): Remove unnecessary cast.
9530 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9531 cast.
9532 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9533 * tui/tui-regs.c (tui_display_registers_from)
9534 (tui_display_register): Remove unnecessary cast.
9535 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9536 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9537 (make_visible): Remove unnecessary cast.
9538 * tui/tui-winsource.c (tui_erase_source_content)
9539 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9540 unnecessary cast.
9541 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9542 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9543 * stabsread.c (read_type, read_array_type, read_range_type):
9544 Remove unnecessary cast.
9545 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9546 (parse_symbol, parse_type, upgrade_type, parse_external)
9547 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9548 unnecessary cast.
9549 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9550
9551 2019-06-16 Tom Tromey <tom@tromey.com>
9552
9553 * tui/tui-data.c (tui_alloc_generic_win_info)
9554 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9555 checks.
9556
9557 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
9558 Andrew Burgess <andrew.burgess@embecosm.com>
9559
9560 * f-typeprint.c (f_print_type): Don't return early for not
9561 associated or not allocated types.
9562 (f_type_print_varspec_suffix): Add print_rank parameter and print
9563 ranks of array types in case they dangling.
9564 (f_type_print_base): Add print_rank parameter.
9565
9566 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9567
9568 * NEWS: Mention new MI commands.
9569 * break-catch-throw.c (enum exception_event_kind): Move to
9570 breakpoint.h.
9571 (print_mention_exception_catchpoint): Output text as a single
9572 message.
9573 (catch_exception_command_1): Rename to...
9574 (catch_exception_event): ...this, make non-static, update header
9575 command, and change some parameter types.
9576 (catch_catch_command): Update for changes to
9577 catch_exception_command_1.
9578 (catch_throw_command): Likewise.
9579 (catch_rethrow_command): Likewise.
9580 * breakpoint.c (enum exception_event_kind): Delete.
9581 * breakpoint.h (enum exception_event_kind): Moved here from
9582 break-catch-throw.c.
9583 (catch_exception_event): Declare.
9584 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9585 (mi_cmd_catch_throw): New function.
9586 (mi_cmd_catch_rethrow): New function.
9587 (mi_cmd_catch_catch): New function.
9588 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9589 'catch-catch' entries.
9590 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9591 (mi_cmd_catch_rethrow): Declare.
9592 (mi_cmd_catch_catch): Declare.
9593
9594 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9595
9596 * annotate.c (annotate_source_line): Change return type to void,
9597 update implementation to match.
9598 * annotate.h (annotate_source_line): Change return type to void,
9599 update header comment.
9600 * stack.c (print_frame_info): Don't change what frame information
9601 is printed based on whether annotations are on or not.
9602
9603 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9604
9605 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9606 (annotate_source): Make static.
9607 (annotate_source_line): Moved from source.c and renamed from
9608 identify_source_line. Update the return type.
9609 * annotate.h (annotate_source): Delete declaration.
9610 (annotate_source_line): Declaration moved from source.h, and
9611 renamed from identify_source_line. Return type updated.
9612 * source.c (identify_source_line): Moved to annotate.c and renamed
9613 to annotate_source_line.
9614 (info_line_command): Remove check of annotation_level.
9615 * source.h (identify_source_line): Move declaration to annotate.h
9616 and rename to annotate_source_line.
9617 * stack.c: Add 'annotate.h' include.
9618 (print_frame_info): Remove check of annotation_level before
9619 calling annotate_source_line.
9620
9621 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9622
9623 * source-cache.c (source_cache::get_plain_source_lines): Use
9624 open_source_file_with_line_charpos instead of just
9625 open_source_file, remove call to find_source_lines.
9626 (source_cache::get_source_lines): Likewise.
9627 * source.c (find_source_lines): Make static.
9628 (get_filename_and_charpos): Renamed into...
9629 (open_source_file_with_line_charpos): ..this along with changes to
9630 return a scoped_fd, and some other minor clean ups.
9631 (identify_source_line): Use open_source_file_with_line_charpos.
9632 (search_command_helper): Use open_source_file_with_line_charpos
9633 instead of just open_source_file, remove call to
9634 find_source_lines.
9635 * source.h (open_source_file_with_line_charpos): Declare new
9636 function.
9637 (find_source_lines): Delete declaration.
9638
9639 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
9640
9641 * source.c (get_filename_and_charpos): Remove fullname
9642 parameter.
9643 (identify_source_line): Update call to get_filename_and_charpos.
9644
9645 2019-06-14 Tom Tromey <tromey@adacore.com>
9646
9647 PR gdb/24502:
9648 * ui-style.h (skip_ansi_escape): Update comment.
9649 * ui-file.h (class no_terminal_escape_file): New class.
9650 * ui-file.c (no_terminal_escape_file::write)
9651 (no_terminal_escape_file::puts): New methods.
9652 * cli/cli-logging.c (handle_redirections): Use
9653 no_terminal_escape_file.
9654
9655 2019-06-14 Tom Tromey <tromey@adacore.com>
9656
9657 * NEWS: Move convenience variable news above Python news.
9658
9659 2019-06-14 Tom Tromey <tom@tromey.com>
9660
9661 * gnulib: Move directory to top-level.
9662 * configure.ac: Don't configure gnulib.
9663 * configure: Rebuild.
9664 * common/common-defs.h: Use new path to gnulib.
9665 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9666 (GNULIB_H): Remove.
9667 (INCGNU): Look in new gnulib location.
9668 (HFILES_NO_SRCDIR): Remove gnulib files.
9669 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9670 (generated_files): Remove GNULIB_H.
9671 ($(LIBGNU), all-lib): Remove targets.
9672 (distclean): Don't mention GNULIB_BUILDDIR.
9673 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9674
9675 2019-06-14 Tom Tromey <tromey@adacore.com>
9676
9677 * symfile.c (add_symbol_file_command): Remove obsolete comment.
9678 Warn if symbol file does not provide any symbols.
9679
9680 2019-06-14 Tom Tromey <tromey@adacore.com>
9681
9682 * source.c (find_and_open_source): Respect basenames_may_differ.
9683
9684 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
9685
9686 * annotate.c (annotate_breakpoints_invalid): Make use of
9687 scoped_restore_terminal_state.
9688 (annotate_frames_invalid): Likewise.
9689
9690 2019-06-14 Tom Tromey <tromey@adacore.com>
9691
9692 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9693 allow assignment to an internalvar.
9694
9695 2019-06-14 Tom Tromey <tromey@adacore.com>
9696
9697 * ada-lex.l: Allow "_" in attribute names.
9698
9699 2019-06-14 Tom Tromey <tromey@adacore.com>
9700
9701 PR gdb/24653:
9702 * regcache.c (registers_changed): Don't call alloca.
9703 * top.c (execute_command): Don't call alloca.
9704
9705 2019-06-13 Pedro Alves <palves@redhat.com>
9706
9707 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9708 'expression'. When parsing an expression, error out if there's
9709 junk after "unlimited".
9710 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9711 (do_set_command): Adjust calls to is_unlimited_literal.
9712
9713 2019-06-13 Pedro Alves <palves@redhat.com>
9714
9715 * compile/compile.c (make_compile_options_def_group): Add braces
9716 around array_view initializer.
9717 * thread.c (make_thread_apply_all_options_def_group)
9718 (make_thread_apply_all_options_def_group): Likewise.
9719
9720 2019-06-13 Pedro Alves <palves@redhat.com>
9721
9722 * NEWS (New commands): Mention "maint test-options
9723 require-delimiter", "maint test-options unknown-is-error", "maint
9724 test-options unknown-is-operand" and "maint show
9725 test-options-completion-result".
9726 (New command options, command completion): New section.
9727 (Completion improvements): New section.
9728 Mention that you can abbreviate "unlimited".
9729
9730 2019-06-13 Pedro Alves <palves@redhat.com>
9731
9732 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9733 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9734 * unittests/cli-utils-selftests.c (test_parse_flags)
9735 (test_parse_flags_qcs): Delete.
9736 (test_cli_utils): Don't call deleted functions.
9737
9738 2019-06-13 Pedro Alves <palves@redhat.com>
9739
9740 * thread.c: Include "cli/cli-option.h".
9741 (tp_array_compar_ascending): Global.
9742 (tp_array_compar): Delete function.
9743 (tp_array_compar_ascending, tp_array_compar_descending): New
9744 functions.
9745 (ascending_option_def, qcs_flag_option_def)
9746 (thr_qcs_flags_option_defs)
9747 (make_thread_apply_all_options_def_group)
9748 (make_thread_apply_options_def_group): New.
9749 (thread_apply_all_command): Use gdb::option::process_options.
9750 (thread_apply_command_completer)
9751 (thread_apply_all_command_completer): New.
9752 (thread_apply_command): Use gdb::option::process_options.
9753 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9754 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
9755 to generate help text of "thread apply". Adjust "taas"'s help.
9756 * tid-parse.c (tid_range_parser::in_thread_range): New method.
9757 * tid-parse.h (tid_range_parser::in_thread_range): New method.
9758
9759 2019-06-13 Pedro Alves <palves@redhat.com>
9760
9761 * thread.c (thread_apply_command): Check for invalid TID with
9762 isdigit instead of !isalpha.
9763
9764 2019-06-13 Pedro Alves <palves@redhat.com>
9765
9766 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9767 (validate_flags_qcs): New.
9768 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9769 (validate_flags_qcs): Declare.
9770 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9771 (make_frame_apply_options_def_group): New.
9772 (frame_apply_command_count): Process options with
9773 gdb::option::process_options.
9774 (frame_apply_completer): New.
9775 (frame_apply_level_completer, frame_apply_all_completer)
9776 (frame_apply_completer): New.
9777 (_initialize_stack): Update help of "frame apply", "frame apply
9778 level", "frame apply all" and "faas" to mention supported options
9779 and install command completers.
9780 * stack.h (frame_apply_all_completer): Declare.
9781 * thread.c: Include "stack.h".
9782 (tfaas_command): Add "--".
9783 (_initialize_thread): Update help "tfaas" to mention supported
9784 options and install command completer.
9785
9786 2019-06-13 Pedro Alves <palves@redhat.com>
9787
9788 * completer.c (complete_nested_command_line): New.
9789 (gdb_completion_word_break_characters_throw): Add assertion.
9790 * completer.h (complete_nested_command_line): Declare.
9791
9792 2019-06-13 Pedro Alves <palves@redhat.com>
9793
9794 * stack.c (parse_backtrace_qualifiers): New.
9795 (backtrace_command): Use it.
9796 (backtrace_command_completer): Complete on qualifiers.
9797
9798 2019-06-13 Pedro Alves <palves@redhat.com>
9799
9800 * frame.c: Include "cli/cli-option.h.
9801 (user_set_backtrace_options): New.
9802 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9803 Delete.
9804 (get_prev_frame): Adjust.
9805 (boolean_option_def, uinteger_option_def)
9806 (set_backtrace_option_defs): New.
9807 (_initialize_frame): Adjust and use
9808 gdb::option::add_setshow_cmds_for_options to install "set
9809 backtrace past-main" and "set backtrace past-entry".
9810 * frame.h: Include "cli/cli-option.h".
9811 (struct frame_print_options): Forward declare.
9812 (print_frame_arguments_all, print_frame_arguments_scalars)
9813 (print_frame_arguments_none): Declare.
9814 (print_entry_values): Delete declaration.
9815 (struct frame_print_options, user_frame_print_options): New.
9816 (struct set_backtrace_options): New.
9817 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9818 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9819 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9820 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9821 (list_args_or_locals): Add frame_print_options parameter.
9822 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9823 * python/py-framefilter.c (enumerate_args): Pass down
9824 USER_FRAME_PRINT_OPTIONS.
9825 * stack.c: Include "cli/cli-option.h".
9826 (print_frame_arguments_all, print_frame_arguments_scalars)
9827 (print_frame_arguments_none): Declare.
9828 (print_raw_frame_arguments, print_entry_values): Delete.
9829 (user_frame_print_options): New.
9830 (boolean_option_def, enum_option_def, frame_print_option_defs):
9831 New.
9832 (struct backtrace_cmd_options): New.
9833 (bt_flag_option_def): New.
9834 (backtrace_command_option_defs): New.
9835 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9836 (print_frame_arg, read_frame_arg, print_frame_args)
9837 (print_frame_info, print_frame): Add frame_print_options parameter
9838 and use it.
9839 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9840 (backtrace_command_1): Add frame_print_options and
9841 backtrace_cmd_options parameters and use them.
9842 (make_backtrace_options_def_group): New.
9843 (backtrace_command): Process command options with
9844 gdb::option::process_options.
9845 (backtrace_command_completer): New.
9846 (_initialize_stack): Extend "backtrace"'s help to mention
9847 supported options. Install completer for "backtrace".
9848 Install some settings commands with add_setshow_cmds_for_options.
9849
9850 2019-06-13 Pedro Alves <palves@redhat.com>
9851
9852 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9853 and that "set/show print raw frame-arguments" are now deprecated.
9854
9855 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9856 command.
9857 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9858 * stack.c (_initialize_stack): Install "set/show print
9859 raw-frame-arguments", and deprecate "set/show print raw
9860 frame-arguments".
9861 * valprint.c (_initialize_valprint): Deprecate "set/show print
9862 raw".
9863
9864 2019-06-13 Pedro Alves <palves@redhat.com>
9865
9866 * compile/compile.c (struct compile_options): New.
9867 (compile_flag_option_def, compile_command_option_defs)
9868 (make_compile_options_def_group): New.
9869 (compile_file_command): Handle options with
9870 gdb::option::process_options.
9871 (compile_file_command_completer): New function.
9872 (compile_code_command): Handle options with
9873 gdb::option::process_options.
9874 (compile_code_command_completer): New function.
9875 (_initialize_compiler): Install completers for "compile code" and
9876 "compile file". Mention available options in "compile code" and
9877 "compile code"'s help.
9878 * completer.c (advance_to_completion_word): New, factored out from
9879 ...
9880 (advance_to_expression_complete_word_point): ... this.
9881 (advance_to_filename_complete_word_point): New.
9882 * completer.h (advance_to_filename_complete_word_point): New
9883 declaration.
9884
9885 2019-06-13 Pedro Alves <palves@redhat.com>
9886
9887 * compile/compile.c: Include "cli/cli-option.h".
9888 (compile_print_value): Scope data pointer is now a
9889 value_print_options pointer; adjust.
9890 (compile_print_command): Process options. Scope data pointer is
9891 now a value_print_options pointer; adjust.
9892 (_initialize_compile): Update "compile print"'s help to include
9893 supported options. Install a completer for "compile print".
9894 * cp-valprint.c (show_vtblprint, show_objectprint)
9895 (show_static_field_print): Delete.
9896 (_initialize_cp_valprint): Don't install "set print
9897 static-members", "set print vtbl", "set print object" here.
9898 * printcmd.c: Include "cli/cli-option.h" and
9899 "common/gdb_optional.h".
9900 (print_command_parse_format): Rework to fill in a
9901 value_print_options instead of a format_data.
9902 (print_value): Change parameter type from format_data pointer to
9903 value_print_options reference. Adjust.
9904 (print_command_1): Process options. Adjust to pass down a
9905 value_print_options.
9906 (print_command_completer): New.
9907 (_initialize_printcmd): Install print_command_completer as
9908 handle_brkchars completer for the "print" command. Update
9909 "print"'s help to include supported options.
9910 * valprint.c: Include "cli/cli-option.h".
9911 (show_vtblprint, show_objectprint, show_static_field_print): Moved
9912 here from cp-valprint.c.
9913 (boolean_option_def, uinteger_option_def)
9914 (value_print_option_defs, make_value_print_options_def_group):
9915 New. Use gdb::option::add_setshow_cmds_for_options to install
9916 "set print elements", "set print null-stop", "set print repeats",
9917 "set print pretty", "set print union", "set print array", "set
9918 print address", "set print symbol", "set print array-indexes".
9919 * valprint.h: Include <string> and "cli/cli-option.h".
9920 (make_value_print_options_def_group): Declare.
9921 (print_value): Change parameter type from format_data pointer to
9922 value_print_options reference.
9923 (print_command_completer): Declare.
9924
9925 2019-06-13 Pedro Alves <palves@redhat.com>
9926
9927 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9928 (COMMON_SFILES): Add maint-test-settings.c.
9929 * cli/cli-decode.c (boolean_enums): New global, factored out from
9930 ...
9931 (add_setshow_boolean_cmd): ... here.
9932 * cli/cli-decode.h (boolean_enums): Declare.
9933 * cli/cli-option.c: New file.
9934 * cli/cli-option.h: New file.
9935 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9936 factored out from ...
9937 (parse_cli_boolean_value(const char *)): ... this.
9938 (is_unlimited_literal): Change parameter type to pointer to
9939 pointer. Adjust and advance ARG pointer.
9940 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9941 (parse_cli_var_enum): New, factored out from ...
9942 (do_set_command): ... this. Adjust.
9943 * cli/cli-setshow.h (parse_cli_boolean_value)
9944 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9945 (parse_cli_var_enum): Declare.
9946 * cli/cli-utils.c: Include "cli/cli-option.h".
9947 (get_ulongest): New.
9948 * cli/cli-utils.h (get_ulongest): Declare.
9949 (check_for_argument): New overloads.
9950 * maint-test-options.c: New file.
9951
9952 2019-06-13 Pedro Alves <palves@redhat.com>
9953
9954 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9955 parse a range if "-" is at the end of the string.
9956
9957 2019-06-13 Pedro Alves <palves@redhat.com>
9958
9959 * cli/cli-setshow.c (parse_auto_binary_operation)
9960 (parse_cli_boolean_value): Don't allow "o".
9961
9962 2019-06-13 Pedro Alves <palves@redhat.com>
9963
9964 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9965 * NEWS: Mention maint test-settings KIND.
9966 * maint-test-settings.c: New file.
9967
9968 2019-06-13 Pedro Alves <palves@redhat.com>
9969
9970 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9971 completer.
9972 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9973 "set" completers.
9974
9975 2019-06-13 Pedro Alves <palves@redhat.com>
9976
9977 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9978 after item.
9979
9980 2019-06-13 Pedro Alves <palves@redhat.com>
9981
9982 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9983
9984 2019-06-13 Pedro Alves <palves@redhat.com>
9985
9986 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9987 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9988 call.
9989 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9990 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9991 calls.
9992 (check_for_argument): Skip spaces after argument.
9993
9994 2019-06-13 Pedro Alves <palves@redhat.com>
9995
9996 * thread.c (thread_apply_command): Adjust TID parsing.
9997 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9998 detected before end of string.
9999 (tid_is_in_list): Error out if LIST is invalid.
10000
10001 2019-06-13 Pedro Alves <palves@redhat.com>
10002
10003 * completer.c (complete_line_internal_1): Rewind completion word
10004 point.
10005 (completion_tracker::advance_custom_word_point_by): Change
10006 parameter type to int.
10007 * completer.h (completion_tracker::advance_custom_word_point_by):
10008 Likewise.
10009
10010 2019-06-13 Pedro Alves <palves@redhat.com>
10011
10012 * completer.c (advance_to_completion_word): Handle delimiters.
10013
10014 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
10015
10016 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
10017
10018 2019-06-11 Tom Tromey <tom@tromey.com>
10019
10020 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
10021 (xmalloc_failed): Move to alloc.c.
10022 * alloc.c: New file.
10023 * Makefile.in (COMMON_SFILES): Add alloc.c.
10024
10025 2019-06-11 Tom Tromey <tom@tromey.com>
10026
10027 * nat/linux-waitpid.c: Don't include server.h.
10028 (linux_debug): Remove.
10029 (my_waitpid): Update.
10030
10031 2019-06-11 Tom Tromey <tromey@adacore.com>
10032
10033 * infcall.c (_initialize_infcall): Remove trailing newline from
10034 help.
10035 * user-regs.c (_initialize_user_regs): Remove trailing newline
10036 from help.
10037 * typeprint.c (_initialize_typeprint): Remove trailing newline
10038 from help.
10039 * reverse.c (_initialize_reverse): Remove trailing newlines from
10040 help.
10041 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
10042 from help.
10043 * language.c (add_set_language_command): Remove trailing newline
10044 from help.
10045 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
10046 help.
10047 * disasm.c (_initialize_disasm): Remove trailing newline from
10048 help.
10049 * top.c (init_main): Remove trailing newline from help.
10050 * interps.c (_initialize_interpreter): Remove trailing newline
10051 from help.
10052 * btrace.c (_initialize_btrace): Remove trailing newlines from
10053 help.
10054 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
10055 from help.
10056 * python/python.c (_initialize_python): Remove trailing newline
10057 from help.
10058 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
10059 help.
10060 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
10061 from help. Reformat some text.
10062 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
10063 from help.
10064 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
10065 newline from help.
10066
10067 2019-06-11 Tom Tromey <tromey@adacore.com>
10068
10069 * darwin-nat.c (darwin_decode_exception_message)
10070 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
10071
10072 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
10073
10074 * valops.c (value_slice): Check for not allocated or not
10075 associated values.
10076
10077 2019-06-10 Tom de Vries <tdevries@suse.de>
10078
10079 PR gdb/24618
10080 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
10081 sure an empty slot (defined by a 32-bit zero pair) is recognized as
10082 invalid.
10083
10084 2019-06-10 Tom de Vries <tdevries@suse.de>
10085
10086 PR gdb/24611
10087 * linespec.c (linespec_lexer_lex_string): Remove incorrect
10088 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
10089
10090 2019-06-10 Tom de Vries <tdevries@suse.de>
10091
10092 PR symtab/24545
10093 * symtab.c (struct demangled_name_entry): Add language field.
10094 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
10095 static minimal symbol". Set and use language field.
10096
10097 2019-06-10 Tom Tromey <tromey@adacore.com>
10098
10099 * ada-lang.c (_initialize_ada_language): Update help text.
10100
10101 2019-06-10 Tom Tromey <tromey@adacore.com>
10102
10103 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
10104 with a newline.
10105 * guile/guile.c (handle_boot_error): Don't end warning with a
10106 newline.
10107 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
10108 warning with a newline.
10109 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
10110 newline.
10111 (s12z_frame_cache): Likewise.
10112 * dwarf-index-cache.c (index_cache::store): Don't end warning with
10113 a newline.
10114 * solib-svr4.c (disable_probes_interface): Don't end warning with
10115 a newline.
10116 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
10117 newline.
10118 * python/python.c (do_finish_initialization): Don't end warning
10119 with a newline.
10120
10121 2019-06-10 Tom Tromey <tom@tromey.com>
10122
10123 * python/py-breakpoint.c (gdbpy_breakpoint_created)
10124 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
10125 gdbpy_enter.
10126
10127 2019-06-10 Tom Tromey <tromey@adacore.com>
10128
10129 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
10130 data.
10131 (elf_new_init): Don't call stabsread_new_init.
10132 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
10133 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
10134 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
10135
10136 2019-06-10 Tom de Vries <tdevries@suse.de>
10137
10138 PR symtab/16264
10139 PR symtab/24517
10140 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
10141
10142 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
10143
10144 * source.c (find_and_open_source): Also rewrite relative file
10145 names.
10146
10147 2019-04-26 Amos Bird <amosbird@gmail.com>
10148
10149 * annotate.c (annotate_thread_exited): Add "thread-exited"
10150 annotation.
10151
10152 2019-06-06 Tom Tromey <tromey@adacore.com>
10153
10154 * maint.h (class scoped_command_stats): Use
10155 DISABLE_COPY_AND_ASSIGN.
10156 <print_time>: New method.
10157 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10158 print_time.
10159 (scoped_command_stats::print_time): New method.
10160
10161 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
10162
10163 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10164 instructions of lengths 6 or 8 bytes.
10165
10166 2019-06-04 Pedro Alves <palves@redhat.com>
10167
10168 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10169
10170 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10171 * breakpoint.c (condition_completer): Likewise.
10172 * cli/cli-dump.c (scan_expression): Likewise.
10173 * common/filestuff.c (mkdir_recursive): Likewise.
10174 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10175 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10176 (gdb_abspath): Likewise.
10177 * compile/compile-cplus-types.c
10178 (compile_cplus_instance::decl_name): Likewise.
10179 * completer.c (complete_explicit_location):
10180 (signal_completer, reg_or_group_completer_1): Likewise.
10181 * cp-support.c (cp_remove_params_if_any): Likewise.
10182 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10183 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10184 * infcmd.c (strip_bg_char): Likewise.
10185 * linespec.c (copy_token_string): Likewise.
10186 * mi/mi-main.c (output_cores): Likewise.
10187 * psymtab.c (psymtab_search_name):
10188 * symfile.c (test_set_ext_lang_command): Likewise.
10189 * target.c (target_fileio_read_stralloc): Likewise.
10190 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10191 * value.c (complete_internalvar): Likewise.
10192
10193 2019-06-04 Christian Biesinger <cbiesinger@google.com>
10194
10195 Add objfile property to gdb.Type.
10196 * NEWS: Mention Python API addition.
10197 * python/py-type.c (typy_get_objfile): New method.
10198
10199 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10200
10201 * NEWS: Mention the new set|show style [title|highlight].
10202 Mention changes to "show style", "help" and "apropos".
10203
10204 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10205
10206 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10207 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
10208 instead of print_help_for_command.
10209 (print_doc_of_command): New function.
10210 (help_list): Add 'apropos -v word' suggestion.
10211 (print_help_for_command): Style the command name using title style.
10212 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10213 (_initialize_cli_cmds): Describe -v in apropos_command help.
10214
10215 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10216
10217 * cli/cli-style.h (cli_style_option): Add name in constructor,
10218 add m_name class member, add constructor with intensity,
10219 add name class function.
10220 (cli_style_option::add_setshow_commands): Remove name argument.
10221 (highlight_style, title_style): New styles.
10222 * cli/cli-style.c (do_show): New function that shows a style
10223 characteristic styling the style name with itself.
10224 (set_style_name): New function.
10225 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10226 Update all callers according to the changes in cli/cli-style.h.
10227 * utils.h (fputs_highlighted): New function.
10228 * utils.c (fputs_highlighted): Likewise.
10229
10230 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10231
10232 * NEWS: Mention new pipe command and new convenience variables.
10233
10234 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10235
10236 * cli/cli-cmds.c (pipe_command): New function.
10237 (_initialize_cli_cmds): Call add_com for pipe_command.
10238 Define | as an alias for pipe.
10239 (exit_status_set_internal_vars): New function.
10240 (shell_escape): Call exit_status_set_internal_vars.
10241 cli/cli-decode.c (find_command_name_length): Recognize | as
10242 a single character command.
10243
10244 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10245
10246 * gdbcmd.h (execute_command_to_ui_file): New declaration.
10247 top.c (execute_command_to_ui_file): New function, mostly a copy
10248 of execute_command_to_string.
10249 (execute_command_to_string): Implement by calling
10250 execute_command_to_ui_file.
10251
10252 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10253
10254 * top.h (saved_command_line): Remove declaration.
10255 * top.c (previous_saved_command_line, previous_repeat_arguments):
10256 New variables.
10257 (saved_command_line): Make static, define together with other
10258 'repeat variables'.
10259 (dont_repeat): Clear repeat_arguments.
10260 (repeat_previous, get_saved_command_line, save_command_line):
10261 New functions.
10262 (gdb_init): Initialize saved_command_line
10263 and previous_saved_command_line.
10264 * main.c (captured_main_1): Remove saved_command_line initialization.
10265 * event-top.c (handle_line_of_input): Update to use
10266 the new 'repeat' related functions instead of direct access to
10267 saved_command_line.
10268 * command.h (repeat_previous, get_saved_command_line,
10269 save_command_line): New declarations.
10270 (dont_repeat): Add comment.
10271
10272 2019-05-30 Tom Tromey <tromey@adacore.com>
10273
10274 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10275 Fix comment.
10276 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10277
10278 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
10279
10280 PR cli/24587
10281 * completer.c (complete): Initialize variable word.
10282
10283 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
10284
10285 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10286 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10287 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10288 'body' is NULL to the outter 'if', protecting the '!is_define'
10289 situation as well.
10290
10291 2019-05-29 Tom Tromey <tromey@adacore.com>
10292
10293 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10294 (dwarf_unknown): New function.
10295 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10296 (dwarf_type_encoding_name): Use dwarf_unknown.
10297
10298 2019-05-29 Tom Tromey <tromey@adacore.com>
10299
10300 PR c++/20020:
10301 * cp-valprint.c (cp_print_value_fields): Call
10302 cp_print_static_field inside "try".
10303
10304 2019-05-29 Tom Tromey <tromey@adacore.com>
10305
10306 * inflow.c (struct terminal_info): Add default operator=.
10307 * configure: Rebuild.
10308 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10309 -Wdeprecated-copy-dtor, -Wredundant-move.
10310
10311 2019-05-29 Tom Tromey <tromey@adacore.com>
10312
10313 * NEWS: Add entry.
10314 * infcmd.c (print_return_value_1): Handle finish_print
10315 option.
10316 (show_print_finish): New function.
10317 (_initialize_infcmd): Add "set/show print finish" commands.
10318 * valprint.c (user_print_options): Initialize new member.
10319 * valprint.h (struct value_print_options) <finish_print>: New
10320 member.
10321
10322 2019-05-28 Tom Tromey <tromey@adacore.com>
10323
10324 * ada-lang.c (ada_remove_Xbn_suffix)
10325 (find_old_style_renaming_symbol)
10326 (parse_old_style_renaming): Remove.
10327 (ada_find_renaming_symbol): Don't call
10328 find_old_style_renaming_symbol.
10329 (ada_is_renaming_symbol): Rename from
10330 ada_find_renaming_symbol. Remove "block" parameter. Return
10331 bool. Now static.
10332 (ada_read_var_value): Update and simplify.
10333 * ada-exp.y (write_var_or_type): Remove old code.
10334
10335 2019-05-28 Alan Hayward <alan.hayward@arm.com>
10336
10337 PR gdb/25010
10338 * event-top.c: Remove include comment.
10339 * inflow.c (class scoped_ignore_sigttou): Move from here...
10340 * inflow.h (class scoped_ignore_sigttou): ...to here.
10341 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10342 * top.c: Remove include comment.
10343
10344 2019-05-27 Tom Tromey <tom@tromey.com>
10345
10346 * NEWS: Fix typo.
10347
10348 2019-05-22 Tom Tromey <tromey@adacore.com>
10349
10350 * target.c (target_follow_exec): Constify parameter.
10351 * target-delegates.c: Rebuild.
10352 * remote.c (remote_target::follow_exec): Constify parameter.
10353 * infrun.c (follow_exec): Constify parameter.
10354 * target.h (struct target_ops) <follow_exec>: Constify parameter.
10355 (target_follow_exec): Likewise.
10356
10357 2019-05-22 Alan Hayward <alan.hayward@arm.com>
10358
10359 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10360 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10361
10362 2019-05-22 Alan Hayward <alan.hayward@arm.com>
10363
10364 * NEWS: Add debugredirect and testsuite sections.
10365
10366 2019-05-22 Simon Cook <simon.cook@embecosm.com>
10367
10368 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10369 target descriptions using exclusively floating point register name
10370 aliases.
10371
10372 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
10373
10374 PR gdb/18644:
10375 * f-lang.c (build_fortran_types): Handle the case where
10376 gdbarch_floatformat_for_type returns a nullptr.
10377
10378 2019-05-21 Tom de Vries <tdevries@suse.de>
10379
10380 PR cli/24587
10381 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10382
10383 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10384
10385 PR gdb/18644:
10386 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10387 16-byte floats.
10388 * i386-tdep.c (i386_floatformat_for_type): Use
10389 floatformats_ia64_quad for the 16-byte floating point component
10390 within a fortran 32-byte complex number.
10391
10392 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
10393
10394 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10395 delete default constructor.
10396 (find_partial_die): Update to return const struct.
10397 (partial_die_parent_scope): Move variable declaration into scope
10398 of its use and change its type to auto.
10399 (guess_partial_die_structure_name): Likewise.
10400 (partial_die_info::fixup): Likewise.
10401
10402 2019-05-17 Tom Tromey <tromey@adacore.com>
10403
10404 * source.c (find_and_open_source): Remove cast.
10405
10406 2019-05-17 Tom Tromey <tromey@adacore.com>
10407
10408 * annotate.c (annotate_source): Make "filename" const.
10409 * annotate.h (annotate_source): Use const.
10410
10411 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10412
10413 * disasm.c (set_disassembler_options): Send errors to stderr.
10414
10415 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10416
10417 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10418 (cli_interp_base::set_logging): Check debug_redirect.
10419 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10420 * cli/cli-logging.c (debug_redirect): Add static variable.
10421 (pop_output_files): Add default param.
10422 (handle_redirections): Print debug setting.
10423 (show_logging_command): Likewise.
10424 (_initialize_cli_logging): Add debugredirect command.
10425 * interps.c (current_interp_set_logging): Add debug_redirect
10426 parameter.
10427 * interps.h (set_logging): Add debug_redirect parameter.
10428 (current_interp_set_logging): Likewise.
10429 * mi/mi-common.h: Likewise.
10430 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10431
10432 2019-05-17 Alan Hayward <alan.hayward@arm.com>
10433 Tom Tromey <tromey@adacore.com>
10434
10435 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10436 directly.
10437 * cli/cli-interp.h (make_logging_output): Remove declaration.
10438 * cli/cli-logging.c (make_logging_output): Remove function.
10439 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10440 directly.
10441 * ui-file.c (tee_file::tee_file): Remove bools.
10442 (tee_file::~tee_file): Remove deletes.
10443 * ui-file.h (tee_file): Remove bools.
10444
10445 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
10446
10447 * mi/mi-cmds.h (mi_cmd_complete): New function.
10448 * mi/mi-main.c (mi_cmd_complete): Likewise.
10449 * mi/mi-cmds.c: Define new MI command -complete.
10450 * NEWS: Mention new -complete command.
10451
10452 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
10453
10454 * completer.h (complete): New function.
10455 * completer.c (complete): Likewise.
10456 * cli/cli-cmds.c: (complete_command): Update to use new complete()
10457 function defined in completer.h.
10458
10459 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
10460
10461 * MAINTAINERS (Write After Approval): Add myself.
10462
10463 2019-05-17 Tom de Vries <tdevries@suse.de>
10464
10465 PR gdb/24094
10466 * dwarf2read.c (struct cu_partial_die_info): New struct.
10467 (find_partial_die): Return cu_partial_die_info.
10468 (partial_die_parent_scope, guess_partial_die_structure_name)
10469 (partial_die_info::fixup): Handle new return type of find_partial_die.
10470
10471 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10472
10473 PR breakpoints/24541
10474 * stap-probe.c (stap_parse_register_operand): Make "regname" an
10475 "std::string", simplifying the algorithm.
10476
10477 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10478
10479 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10480 (stap_static_probe_ops::get_probes): Likewise.
10481
10482 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10483
10484 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10485 '-')" and "else if".
10486 (stap_parse_single_operand): Join checks for
10487 "gdbarch_stap_parse_special_token_p" and
10488 "gdbarch_stap_parse_special_token" in the same "if" statement.
10489 Invert check when verifying for operation on register
10490 displacement.
10491
10492 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10493
10494 * stap-probe.c (stap_get_opcode): Update comment.
10495 (stap_get_expected_argument_type): Likewise.
10496 (handle_stap_probe): Likewise.
10497
10498 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
10499
10500 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10501 return type to 'bool'. Adjust comment. Use 'bool' when
10502 appropriate.
10503 (i386_stap_parse_special_token_three_arg_disp): Likewise.
10504 * stap-probe.c (stap_parse_argument_1): Likewise.
10505 (stap_is_operator): Likewise.
10506 (stap_is_generic_prefix): Likewise.
10507 (stap_is_register_prefix): Likewise.
10508 (stap_is_register_indirection_prefix): Likewise.
10509 (stap_is_integer_prefix): Likewise.
10510 (stap_generic_check_suffix): Likewise.
10511 (stap_check_integer_suffix): Likewise.
10512 (stap_check_register_suffix): Likewise.
10513 (stap_check_register_indirection_suffix): Likewise.
10514 (stap_parse_register_operand): Likewise.
10515 (stap_parse_single_operand): Likewise.
10516 (stap_parse_argument_1): Likewise.
10517 (stap_probe::get_argument_count): Likewise.
10518 (stap_is_operator): Likewise.
10519
10520 2019-05-16 Tom Tromey <tromey@adacore.com>
10521
10522 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10523 keyword to foreach.
10524
10525 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
10526
10527 * linux-thread-db.c (try_thread_db_load_1): Change return type
10528 to bool.
10529 (try_thread_db_load): Likewise.
10530 (try_thread_db_load_from_pdir_1): Likewise.
10531 (try_thread_db_load_from_pdir): Likewise.
10532 (try_thread_db_load_from_sdir): Likewise.
10533 (try_thread_db_load_from_dir): Likewise.
10534 (thread_db_load_search): Likewise.
10535 (has_libpthread): Likewise.
10536 (thread_db_load): Likewise.
10537
10538 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
10539
10540 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10541 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10542 NULL, and complain/return if that's the case.
10543
10544 2019-05-15 John Darrington <john@darrington.wattle.id.au>
10545
10546 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10547 (advance, posn, abstract_read_memory): New functions.
10548 [struct mem_read_abstraction]: New struct.
10549 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10550
10551 2019-05-14 Tom Tromey <tromey@adacore.com>
10552
10553 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10554 value is not lval_memory.
10555
10556 2019-05-14 Tom Tromey <tromey@adacore.com>
10557
10558 * solib.c (info_sharedlibrary_command): Style the file name.
10559
10560 2019-05-14 Alan Hayward <alan.hayward@arm.com>
10561
10562 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10563 (aarch64_vnv_type): Likewise.
10564 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10565 * common/tdesc.c: Likewise.
10566 * common/tdesc.h (enum tdesc_type_kind): Likewise.
10567 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10568 * features/aarch64-fpu.xml: Add ieee half view.
10569 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10570 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10571 * gdbtypes.h (struct builtin_type): Likewise.
10572 (struct objfile_type): Likewise.
10573
10574 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
10575
10576 * language.c (language_sniff_from_mangled_name): Fix "langauge"
10577 typo.
10578 * location.h (string_to_event_location): Likewise.
10579
10580 2019-05-11 Joel Brobecker <brobecker@adacore.com>
10581
10582 GDB 8.3 released.
10583
10584 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10585
10586 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10587 New variable declaration.
10588 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10589 New variable.
10590 (print_one_breakpoint): Use ui_out::test_flags and new global
10591 variable to compute use_fixed_output.
10592 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10593 Remove.
10594 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10595 (mi_multi_location_breakpoint_output_fixed): Remove.
10596 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10597 new variable.
10598 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10599 fix_multi_location_breakpoint_output flag if version >= 3.
10600 * ui-out.h (enum ui_out_flag)
10601 <fix_multi_location_breakpoint_output>: New enumerator.
10602
10603 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
10604
10605 * contrib/cc-with-tweaks.sh: Validate dwz's work.
10606
10607 2019-05-10 Tom Tromey <tromey@adacore.com>
10608
10609 * ada-lang.c (catch_ada_completer): New function.
10610 (_initialize_ada_language): Use it.
10611
10612 2019-05-10 Tom Tromey <tromey@adacore.com>
10613
10614 * thread.c (print_thread_info): Make "requested_threads" const.
10615 * gdbthread.h (print_thread_info): Make "requested_threads"
10616 const.
10617 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10618 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10619
10620 2019-05-08 Tom Tromey <tom@tromey.com>
10621
10622 * gdbtypes.c (objfile_type_data): Change type.
10623 (objfile_type, _initialize_gdbtypes): Update.
10624
10625 2019-05-08 Tom Tromey <tom@tromey.com>
10626
10627 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10628 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10629 (_initialize_dwarf2_frame): Update.
10630
10631 2019-05-08 Tom Tromey <tom@tromey.com>
10632
10633 * objc-lang.c (objc_objfile_data): Change type.
10634 (find_methods): Update.
10635 (_initialize_objc_lang): Remove.
10636
10637 2019-05-08 Tom Tromey <tom@tromey.com>
10638
10639 * stabsread.c (rs6000_builtin_type_data): Change type.
10640 (rs6000_builtin_type, _initialize_stabsread): Update.
10641
10642 2019-05-08 Tom Tromey <tom@tromey.com>
10643
10644 * mips-tdep.c (mips_pdr_data): Remove.
10645 (_initialize_mips_tdep): Update.
10646
10647 2019-05-08 Tom Tromey <tom@tromey.com>
10648
10649 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10650 (hppa_init_objfile_priv_data, read_unwind_info)
10651 (find_unwind_entry, _initialize_hppa_tdep): Update.
10652
10653 2019-05-08 Tom Tromey <tom@tromey.com>
10654
10655 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10656 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
10657 on obstack.
10658 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10659
10660 2019-05-08 Tom Tromey <tom@tromey.com>
10661
10662 * mdebugread.c (basic_type_data): Change type.
10663 (basic_type, _initialize_mdebugread): Update.
10664
10665 2019-05-08 Tom Tromey <tom@tromey.com>
10666
10667 * common/gdb_unique_ptr.h (struct noop_deleter): New.
10668
10669 2019-05-08 Tom Tromey <tom@tromey.com>
10670
10671 * nto-tdep.c (nto_inferior_data_reg): Change type.
10672 (nto_inferior_data): Update.
10673 (nto_inferior_data_cleanup, nto_new_inferior_data)
10674 (_initialize_nto_tdep): Remove.
10675 * nto-tdep.h (struct nto_inferior_data): Add initializers.
10676
10677 2019-05-08 Tom Tromey <tom@tromey.com>
10678
10679 * ada-lang.c (struct ada_inferior_data): Add initializers.
10680 (ada_inferior_data): Change type.
10681 (ada_inferior_data_cleanup): Remove.
10682 (get_ada_inferior_data, ada_inferior_exit)
10683 (struct ada_pspace_data): Add initializers, destructor.
10684 (ada_pspace_data_handle): Change type.
10685 (get_ada_pspace_data): Update.
10686 (ada_pspace_data_cleanup): Remove.
10687
10688 2019-05-08 Tom Tromey <tom@tromey.com>
10689
10690 * coffread.c (struct coff_symfile_info): Add initializers.
10691 (coff_objfile_data_key): Move lower. Change type.
10692 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10693 Update.
10694 (coff_free_info): Remove.
10695
10696 2019-05-08 Tom Tromey <tom@tromey.com>
10697
10698 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10699 (fbsd_pspace_data_handle): Move lower. Change type.
10700 (get_fbsd_pspace_data): Update.
10701 (fbsd_pspace_data_cleanup): Remove.
10702 (_initialize_fbsd_tdep): Update.
10703
10704 2019-05-08 Tom Tromey <tom@tromey.com>
10705
10706 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10707 (get_ada_tasks_pspace_data): Update.
10708 (ada_tasks_pspace_data_cleanup): Remove.
10709 (_initialize_tasks): Update.
10710 (ada_tasks_inferior_data_handle): Change type.
10711 (get_ada_tasks_inferior_data): Update.
10712 (ada_tasks_inferior_data_cleanup): Remove.
10713 (struct ada_tasks_pspace_data): Add initializers.
10714
10715 2019-05-08 Tom Tromey <tom@tromey.com>
10716
10717 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10718 * symfile-debug.c (debug_sym_get_probes): Change type.
10719 * stap-probe.c (handle_stap_probe):
10720 (stap_static_probe_ops::get_probes): Change type.
10721 * probe.h (class static_probe_ops) <get_probes>: Change type.
10722 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10723 (parse_probes_in_pspace): Update.
10724 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10725 Update.
10726 (any_static_probe_ops::get_probes): Change type.
10727 * elfread.c (elfread_data): New typedef.
10728 (probe_key): Change type.
10729 (elf_get_probes): Likewise. Update.
10730 (probe_key_free): Remove.
10731 (_initialize_elfread): Update.
10732 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10733 Change type.
10734 (dtrace_process_dof_probe, dtrace_process_dof)
10735 (dtrace_static_probe_ops::get_probe): Change type.
10736
10737 2019-05-08 Tom Tromey <tom@tromey.com>
10738
10739 * xcoffread.c (struct xcoff_symfile_info): Rename from
10740 coff_symfile_info. Add initializers.
10741 (xcoff_objfile_data_key): Move lower. Change type.
10742 (XCOFF_DATA): Rewrite.
10743 (xcoff_free_info): Remove.
10744 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10745 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10746 (xcoff_initial_scan): Update.
10747
10748 2019-05-08 Tom Tromey <tom@tromey.com>
10749
10750 * solib-svr4.c (struct svr4_info): Add initializers and
10751 destructor.
10752 <probes_table>: Now an htab_up.
10753 (solib_svr4_pspace_data): Change type.
10754 (free_probes_table): Simplify.
10755 (~svr4_info): Rename from svr4_pspace_data_cleanup.
10756 (get_svr4_info, probes_table_htab_remove_objfile_probes)
10757 (probes_table_remove_objfile_probes, register_solib_event_probe)
10758 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10759 (_initialize_svr4_solib): Update.
10760
10761 2019-05-08 Tom Tromey <tom@tromey.com>
10762
10763 * remote.c (remote_pspace_data): Change type.
10764 (remote_pspace_data_cleanup): Remove.
10765 (get_remote_exec_file, set_pspace_remote_exec_file)
10766 (_initialize_remote): Update.
10767
10768 2019-05-08 Tom Tromey <tom@tromey.com>
10769
10770 * breakpoint.c (breakpoint_objfile_key): Change type.
10771 (get_breakpoint_objfile_data): Update.
10772 (free_breakpoint_objfile_data): Remove.
10773 (_initialize_breakpoint): Update.
10774
10775 2019-05-08 Tom Tromey <tom@tromey.com>
10776
10777 * linux-tdep.c (struct linux_info): Add initializers.
10778 (linux_inferior_data): Move. Change type.
10779 (invalidate_linux_cache_inf): Update.
10780 (linux_inferior_data_cleanup): Remove.
10781 (get_linux_inferior_data, _initialize_linux_tdep): Update.
10782
10783 2019-05-08 Tom Tromey <tom@tromey.com>
10784
10785 * auxv.c (auxv_inferior_data): Move. Change type.
10786 (auxv_inferior_data_cleanup): Remove.
10787 (invalidate_auxv_cache_inf): Rewrite.
10788 (get_auxv_inferior_data, _initialize_auxv): Update.
10789
10790 2019-05-08 Tom Tromey <tom@tromey.com>
10791
10792 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10793 (symfile_debug_objfile_data_key): Change type.
10794 (symfile_debug_installed, debug_qf_has_symbols)
10795 (debug_qf_find_last_source_symtab)
10796 (debug_qf_forget_cached_source_info)
10797 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10798 (debug_qf_print_stats, debug_qf_dump)
10799 (debug_qf_expand_symtabs_for_function)
10800 (debug_qf_expand_all_symtabs)
10801 (debug_qf_expand_symtabs_with_fullname)
10802 (debug_qf_map_matching_symbols)
10803 (debug_qf_expand_symtabs_matching)
10804 (debug_qf_find_pc_sect_compunit_symtab)
10805 (debug_qf_map_symbol_filenames)
10806 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10807 (debug_sym_new_init, debug_sym_init, debug_sym_read)
10808 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10809 (debug_sym_read_linetable, debug_sym_relocate): Update.
10810 (symfile_debug_free_objfile): Remove.
10811 (install_symfile_debug_logging, _initialize_symfile_debug):
10812 Update.
10813
10814 2019-05-08 Tom Tromey <tom@tromey.com>
10815
10816 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10817 allocate_on_obstack.
10818 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10819 (get_dwarf2_per_objfile): Update.
10820 (set_dwarf2_per_objfile): Remove.
10821 (dwarf2_has_info, dwarf2_get_section_info): Update.
10822 (dwarf2_free_objfile): Remove.
10823 (_initialize_dwarf2_read): Update.
10824
10825 2019-05-08 Tom Tromey <tom@tromey.com>
10826
10827 * auto-load.c (struct auto_load_pspace_info): Add destructor and
10828 initializers.
10829 <unsupported_script_warning_printed,
10830 script_not_found_warning_printed>: Now bool.
10831 (auto_load_pspace_data): Change type.
10832 (~auto_load_pspace_info): Rename from
10833 auto_load_pspace_data_cleanup.
10834 (get_auto_load_pspace_data, init_loaded_scripts_info)
10835 (clear_section_scripts, maybe_print_unsupported_script_warning)
10836 (maybe_print_script_not_found_warning, _initialize_auto_load):
10837 Update.
10838
10839 2019-05-08 Tom Tromey <tom@tromey.com>
10840
10841 * objfiles.c (objfile_pspace_info): Add destructor and
10842 initializers.
10843 (objfiles_pspace_data): Change type.
10844 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10845 (get_objfile_pspace_data): Update.
10846 (objfiles_bfd_data): Change type.
10847 (get_objfile_bfd_data): Update.
10848 (objfile_bfd_data_free, _initialize_objfiles): Remove.
10849
10850 2019-05-08 Tom Tromey <tom@tromey.com>
10851
10852 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10853 Change type.
10854 (get_catch_syscall_inferior_data): Update.
10855 (catch_syscall_inferior_data_cleanup): Remove.
10856 (_initialize_break_catch_syscall): Update.
10857
10858 2019-05-08 Tom Tromey <tom@tromey.com>
10859
10860 * inflow.c (struct terminal_info): Add destructor and
10861 initializers.
10862 (inflow_inferior_data): Change type.
10863 (~terminal_info): Rename from inflow_inferior_data_cleanup.
10864 (get_inflow_inferior_data, inflow_inferior_exit)
10865 (swap_terminal_info, _initialize_inflow): Update.
10866
10867 2019-05-08 Tom Tromey <tom@tromey.com>
10868
10869 * target-dcache.c (target_dcache_cleanup): Remove.
10870 (target_dcache_aspace_key): Change type.
10871 (target_dcache_init_p, target_dcache_invalidate)
10872 (target_dcache_get, target_dcache_get_or_init)
10873 (_initialize_target_dcache): Update.
10874 * dcache.h (struct dcache_deleter): New.
10875
10876 2019-05-08 Tom Tromey <tom@tromey.com>
10877
10878 * symtab.c (struct symbol_cache): Add destructor and
10879 initializers.
10880 (symbol_cache_key): Move. Change type.
10881 (make_symbol_cache, free_symbol_cache): Remove.
10882 (get_symbol_cache): Update.
10883 (symbol_cache_cleanup): Remove.
10884 (ALL_PSPACES, symbol_cache_flush)
10885 (maintenance_print_symbol_cache)
10886 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10887 Update.
10888
10889 2019-05-08 Tom Tromey <tom@tromey.com>
10890
10891 * symtab.c (struct main_info): Add destructor and initializers.
10892 (main_progspace_key): Move. Change type.
10893 (get_main_info): Update.
10894 (main_info_cleanup): Remove.
10895 (_initialize_symtab): Update.
10896
10897 2019-05-08 Tom Tromey <tom@tromey.com>
10898
10899 * registry.h (DECLARE_REGISTRY): Define the _key class.
10900
10901 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
10902
10903 * NEWS: Merge two 'New commands' sections.
10904
10905 2019-05-08 Joel Brobecker <brobecker@adacore.com>
10906
10907 * ada-valprint.c (ada_val_print_gnat_array): Remove language
10908 parameter and use Ada language definition instead.
10909 (ada_val_print_ptr): Remove unused language parameter.
10910 (ada_val_print_num): Remove language parameter and use Ada language
10911 definition instead.
10912 (ada_val_print_enum, ada_val_print_flt): Remove unused language
10913 parameter.
10914 (ada_val_print_struct_union, ada_val_print_ref): Remove language
10915 parameter and use Ada language definition instead.
10916 (ada_val_print_1): Update all ada_val_print_xxx calls.
10917 Remove language parameter.
10918 (ada_val_print): Update ada_val_print_1 call.
10919
10920 2019-05-08 Tom Tromey <tromey@adacore.com>
10921
10922 * remote.c (remote_hw_watchpoint_limit)
10923 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10924 Now static.
10925
10926 2019-05-08 Tom Tromey <tromey@adacore.com>
10927
10928 * maint.c (_initialize_maint_cmds): Move initialization code to
10929 remote.c.
10930 (watchdog, show_watchdog): Move to remote.c.
10931 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
10932 "watchdog" static.
10933 (_initialize_remote): Move initialization code from maint.c.
10934 * defs.h (watchdog): Don't declare.
10935
10936 2019-05-08 Tom Tromey <tromey@adacore.com>
10937
10938 * tui/tui-interp.c: Include main.h.
10939 * interps.c: Include main.h.
10940 * main.h (interpreter_p): Declare.
10941 * defs.h (interpreter_p): Don't declare.
10942
10943 2019-05-08 Tom Tromey <tromey@adacore.com>
10944
10945 * dwarf2loc.c: Include dwarf2read.h.
10946 * defs.h (read_unsigned_leb128): Don't declare.
10947 * dwarf2read.h (read_unsigned_leb128): Declare.
10948
10949 2019-05-08 Tom Tromey <tromey@adacore.com>
10950
10951 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10952 method.
10953
10954 2019-05-08 Tom Tromey <tromey@adacore.com>
10955
10956 * utils.c (fputs_maybe_filtered): Reset style after paging, even
10957 when no wrap column is set.
10958
10959 2019-05-08 Tom Tromey <tromey@adacore.com>
10960
10961 * c-lang.c (c_get_string): Handle non-C-style arrays.
10962
10963 2019-05-08 Tom Tromey <tromey@adacore.com>
10964
10965 * typeprint.c (print_offset_data::update): Print the bit offset,
10966 not the number of bits remaining.
10967
10968 2019-05-08 Tom Tromey <tromey@adacore.com>
10969
10970 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10971 padding at end of comment.
10972
10973 2019-05-08 Tom Tromey <tromey@adacore.com>
10974
10975 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10976 Compare main types.
10977
10978 2019-05-06 Tom Tromey <tom@tromey.com>
10979
10980 * common/scoped_mmap.c: Include common-defs.h.
10981 * common/scoped_mmap.h: Don't include config.h.
10982
10983 2019-05-04 Tom Tromey <tom@tromey.com>
10984
10985 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10986 (struct aarch64_call_info): Add initializers.
10987 <si>: Now a std::vector.
10988 (pass_on_stack, aarch64_push_dummy_call): Update.
10989
10990 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10991 Tom Tromey <tom@tromey.com>
10992
10993 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10994 (ppc_threads): Now a std::vector. Now static.
10995 (hwdebug_find_thread_points_by_tid)
10996 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10997 Update.
10998
10999 2019-05-04 Tom Tromey <tom@tromey.com>
11000
11001 * arc-tdep.c (arc_tdesc_init): Return bool.
11002
11003 2019-05-04 Tom Tromey <tom@tromey.com>
11004
11005 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
11006 Use gdb_assert_not_reached.
11007
11008 2019-05-04 Tom Tromey <tom@tromey.com>
11009
11010 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
11011 "false".
11012
11013 2019-05-04 Tom Tromey <tom@tromey.com>
11014
11015 * arc-tdep.c (arc_tdesc_init): Use bool.
11016
11017 2019-05-04 Tom Tromey <tom@tromey.com>
11018
11019 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
11020
11021 2019-05-04 Tom Tromey <tom@tromey.com>
11022
11023 * cli/cli-cmds.c (valid_command_p): Return bool.
11024
11025 2019-05-04 Tom Tromey <tom@tromey.com>
11026
11027 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
11028 * command.h (valid_user_defined_cmd_name_p): Channge return type.
11029
11030 2019-05-04 Raul Tambre <raul@tambre.ee>
11031
11032 * python/lib/gdb/prompt.py (_ExtendedPrompt)
11033 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
11034 operator for comparison.
11035
11036 2019-05-04 Tom Tromey <tom@tromey.com>
11037
11038 * psymtab.c (psymbol_name_matches, match_partial_symbol)
11039 (lookup_partial_symbol, print_partial_symbols)
11040 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
11041 (psymbol_compare): Update.
11042 (add_psymbol_to_bcache): Clear the entire psymbol.
11043 (maintenance_check_psymtabs): Update.
11044 * psympriv.h (struct partial_symbol): Don't derive from
11045 general_symbol_info.
11046 <obj_section, unrelocated_address, address,
11047 set_unrelocated_address>: Update.
11048 <ginfo>: New member.
11049 * dwarf-index-write.c (write_psymbols, debug_names::insert)
11050 (debug_names::write_psymbols): Update.
11051
11052 2019-05-04 Tom de Vries <tdevries@suse.de>
11053
11054 * contrib/cc-with-tweaks.sh: Support -n arg.
11055
11056 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11057
11058 * corelow.c (core_target::detach): Ensure frame cache and
11059 register caches are cleared.
11060 inferior.c (exit_inferior_1): Likewise.
11061
11062 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
11063 Tom Tromey <tom@tromey.com>
11064
11065 * dictionary.c (collate_pending_symbols_by_language): Remove
11066 "struct" from foreach.
11067 * symtab.c (lookup_global_symbol_from_objfile)
11068 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
11069 foreach.
11070 * ser-tcp.c (net_open): Remove "struct" from foreach.
11071 * objfiles.c (objfile_relocate, objfile_rebase)
11072 (objfile_has_symbols): Remove "struct" from foreach.
11073 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
11074 from foreach.
11075 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
11076 foreach.
11077 * darwin-nat.c (thread_info_from_private_thread_info): Remove
11078 "struct" from foreach.
11079 * ada-lang.c (create_excep_cond_exprs)
11080 (ada_exception_catchpoint_cond_string): Remove "struct" from
11081 foreach.
11082
11083 2019-05-03 Tom Tromey <tromey@adacore.com>
11084
11085 * ada-exp.y (convert_char_literal): Check suffix of each
11086 enumerator.
11087
11088 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
11089
11090 PR ada/21406:
11091 * ada-exp.y (yywrap): Don't define.
11092 * ada-lex.l (%option): Add noyywrap
11093 (yywrap): Remove.
11094
11095 2019-05-03 Eli Zaretskii <eliz@gnu.org>
11096
11097 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
11098 _WIN32_WINNT to the XP level, unless already defined to a higher
11099 level.
11100
11101 * unittests/parse-connection-spec-selftests.c:
11102 * ser-tcp.c:
11103 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
11104 override.
11105
11106 * symfile.c (find_separate_debug_file): Remove colon from the
11107 drive spec of DOS/Windows file names of the target, so that the
11108 file name produced from DEBUGDIR and the target's directory will
11109 be valid on DOS/Windows systems.
11110
11111 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
11112
11113 * rust-lang.c (val_print_struct): Handle printing structures
11114 containing strings.
11115
11116 2019-05-02 Tom Tromey <tromey@adacore.com>
11117
11118 * valarith.c (_initialize_valarith): Remove.
11119
11120 2019-05-01 Tom Tromey <tromey@adacore.com>
11121
11122 * ada-lang.c (ada_value_primitive_field): Treat more fields as
11123 bitfields.
11124
11125 2019-05-01 Tom Tromey <tromey@adacore.com>
11126
11127 * ada-lang.c (ada_value_assign): Correctly compute starting offset
11128 for big-endian copies.
11129
11130 2019-04-30 Ali Tamur <tamur@google.com>
11131 * gdb/dwarf2read.c (read_3_bytes): New declaration.
11132 (read_attribute_value): Added DW_FORM_strx1-4 cases.
11133 (read_3_bytes): New function.
11134
11135 2019-04-30 Joel Brobecker <brobecker@adacore.com>
11136
11137 * windows-nat.c (main_thread_id): Delete.
11138 (handle_output_debug_string): Replace main_thread_id by
11139 current_event.dwThreadId.
11140 (fake_create_process): Likewise.
11141 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
11142 Do not set main_thread_id.
11143 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
11144 current_event.dwThreadId.
11145 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
11146
11147 2019-04-30 Joel Brobecker <brobecker@adacore.com>
11148
11149 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11150 Use current_event.dwThreadId instead of main_thread_id.
11151
11152 2019-04-30 Tom Tromey <tromey@adacore.com>
11153
11154 * ada-lang.c (ada_lookup_simple_minsyms): New function.
11155 (create_excep_cond_exprs): Iterate over program spaces.
11156 (ada_exception_catchpoint_cond_string): Examine all minimal
11157 symbols for exception types.
11158
11159 2019-04-30 Tom Tromey <tromey@adacore.com>
11160
11161 PR c++/24470:
11162 * dwarf2read.c (process_structure_scope): Handle case where type
11163 has template parameters but no symbol was created.
11164
11165 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11166 Chris January <chris.january@arm.com>
11167
11168 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11169 qualifier.
11170 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11171
11172 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11173
11174 * f-typeprint.c (f_print_type): Update rules for printing
11175 whitespace.
11176 (f_type_print_varspec_suffix): Likewise.
11177
11178 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11179 Chris January <chris.january@arm.com>
11180
11181 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11182 function arguments.
11183
11184 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11185
11186 * f-lang.c (build_fortran_types): Change name of void type to
11187 lower case.
11188 * f-typeprint.c (f_type_print_base): Print the name of the void
11189 type, rather than a fixed string.
11190 * f-valprint.c (f_decorations): Use lower case void string.
11191
11192 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11193 Chris January <chris.january@arm.com>
11194
11195 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11196 types for Fortran.
11197
11198 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11199 Chris January <chris.january@arm.com>
11200 David Lecomber <david.lecomber@arm.com>
11201
11202 * f-exp.y (BINOP_INTRINSIC): New token.
11203 (exp): New parser rule handling BINOP_INTRINSIC.
11204 (f77_keywords): Add new builtin procedures.
11205 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11206 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11207 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11208 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11209 (print_unop_subexp_f): New function.
11210 (print_binop_subexp_f): New function.
11211 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11212 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11213 (dump_subexp_body_f): Likewise.
11214 (operator_check_f): Likewise.
11215 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11216 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11217
11218 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11219
11220 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11221 UNOP_KIND.
11222 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11223 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11224 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11225 (operator_length_f): New fuction.
11226 (print_subexp_f): New function.
11227 (op_name_f): New function.
11228 (dump_subexp_body_f): New function.
11229 (operator_check_f): New function.
11230 (exp_descriptor_f): Replace standard expression handling functions
11231 with new functions.
11232 * gdb/fortran-operator.def: New file.
11233 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11234 * gdb/std-operator.def: Remove UNOP_KIND.
11235
11236 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
11237
11238 * std-operator.def: Remove unbalanced, stray double quote
11239 character.
11240
11241 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11242 Chris January <chris.january@arm.com>
11243 Daniel Everett <daniel.everett@arm.com>
11244 Nick Forrington <nick.forrington@arm.com>
11245 Richard Bunt <richard.bunt@arm.com>
11246
11247 * cp-valprint.c (cp_print_value_fields): Allow an additional level
11248 of depth when printing anonymous structs or unions.
11249 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11250 Don't print either the top-level value, or the children if the
11251 max-depth is exceeded.
11252 (ppscm_print_children): When printing the key of a map, allow one
11253 extra level of depth.
11254 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11255 print either the top-level value, or the children if the max-depth
11256 is exceeded.
11257 (print_children): When printing the key of a map, allow one extra
11258 level of depth.
11259 * python/py-value.c (valpy_format_string): Add max_depth keyword.
11260 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11261 (user_print_options): Initialise max_depth field.
11262 (val_print_scalar_or_string_type_p): New function.
11263 (val_print): Check to see if the max depth has been reached.
11264 (val_print_check_max_depth): Define new function.
11265 (show_print_max_depth): New function.
11266 (_initialize_valprint): Add 'print max-depth' option.
11267 * valprint.h (struct value_print_options) <max_depth>: New field.
11268 (val_print_check_max_depth): Declare new function.
11269 * NEWS: Document new feature.
11270
11271 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11272
11273 * ada-lang.c (ada_language_defn): Initialise new field.
11274 * c-lang.c (c_is_string_type_p): New function.
11275 (c_language_defn): Initialise new field.
11276 (cplus_language_defn): Initialise new field.
11277 (asm_language_defn): Initialise new field.
11278 (minimal_language_defn): Initialise new field.
11279 * c-lang.h (c_is_string_type_p): Declare new function.
11280 * d-lang.c (d_language_defn): Initialise new field.
11281 * f-lang.c (f_is_string_type_p): New function.
11282 (f_language_defn): Initialise new field.
11283 * go-lang.c (go_is_string_type_p): New function.
11284 (go_language_defn): Initialise new field.
11285 * language.c (default_is_string_type_p): New function.
11286 (unknown_language_defn): Initialise new field.
11287 (auto_language_defn): Initialise new field.
11288 * language.h (struct language_defn) <la_is_string_type_p>: New
11289 member variable.
11290 (default_is_string_type_p): Declare new function.
11291 * m2-lang.c (m2_language_defn): Initialise new field.
11292 * objc-lang.c (objc_language_defn): Initialise new field.
11293 * opencl-lang.c (opencl_language_defn): Initialise new field.
11294 * p-lang.c (pascal_is_string_type_p): New function.
11295 (pascal_language_defn): Initialise new field.
11296 * rust-lang.c (rust_is_string_type_p): New function.
11297 (rust_language_defn): Initialise new field.
11298
11299 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11300
11301 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11302 New field.
11303 * ada-lang.c (ada_language_defn): Initialise new field.
11304 * c-lang.c (c_language_defn): Likewise.
11305 (cplus_language_defn): Likewise.
11306 (asm_language_defn): Likewise.
11307 (minimal_language_defn): Likewise.
11308 * d-lang.c (d_language_defn): Likewise.
11309 * f-lang.c (f_language_defn): Likewise.
11310 * go-lang.c (go_language_defn): Likewise.
11311 * language.c (unknown_language_defn): Likewise.
11312 (auto_language_defn): Likewise.
11313 * m2-lang.c (m2_language_defn): Likewise.
11314 * objc-lang.c (objc_language_defn): Likewise.
11315 * opencl-lang.c (opencl_language_defn): Likewise.
11316 * p-lang.c (pascal_language_defn): Likewise.
11317 * rust-lang.c (rust_language_defn): Likewise.
11318
11319 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
11320
11321 * ada-lang.c (ada_is_character_type): Change return type to bool.
11322 (ada_is_string_type): Likewise.
11323 * ada-lang.h (ada_is_character_type): Update declaration
11324 (ada_is_string_type): Likewise.
11325
11326 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11327
11328 Support style in 'frame|thread apply'
11329
11330 * gdbcmd.h (execute_command_to_string): New term_out parameter.
11331 * record.c (record_start, record_stop): Update callers of
11332 execute_command_to_string with false.
11333 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11334 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11335 methods.
11336 (class string_file): New constructor with term_out parameter.
11337 Override methods term_out and can_emit_style_escape. New member
11338 term_out.
11339 (class stdio_file): Override can_emit_style_escape.
11340 (class tee_file): Override term_out and can_emit_style_escape.
11341 * utils.h (can_emit_style_escape): Remove.
11342 * utils.c (can_emit_style_escape): Likewise.
11343 Update all callers of can_emit_style_escape (SOMESTREAM) to
11344 SOMESTREAM->can_emit_style_escape.
11345 * source-cache.c (source_cache::get_source_lines): Likewise.
11346 * stack.c (frame_apply_command_count): Call execute_command_to_string
11347 passing the term_out characteristic of the current gdb_stdout.
11348 * thread.c (thr_try_catch_cmd): Likewise.
11349 * top.c (execute_command_to_string): pass term_out parameter
11350 to construct the string_file for the command output.
11351 * ui-file.c (term_cli_styling): New function (most code moved
11352 from utils.c can_emit_style_escape).
11353 (string_file::string_file, string_file::can_emit_style_escape,
11354 stdio_file::can_emit_style_escape, tee_file::term_out,
11355 tee_file::can_emit_style_escape): New functions.
11356
11357 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11358
11359 * NEWS: Mention the new set|show may-call-functions.
11360 * infcall.c (may_call_functions_p): New variable.
11361 (show_may_call_functions_p): New function.
11362 (call_function_by_hand_dummy): Throws an error if not
11363 may-call-functions.
11364 (_initialize_infcall): Call add_setshow_boolean_cmd for
11365 may-call-functions.
11366
11367 2019-04-25 Keith Seitz <keiths@redhat.com>
11368
11369 PR c++/24367
11370 * cp-support.c (inspect_type): Don't attempt substitutions
11371 of symbol with the same name.
11372
11373 2019-04-25 Tom Tromey <tromey@adacore.com>
11374
11375 PR gdb/24475:
11376 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11377 static.
11378
11379 2019-04-25 Tom Tromey <tromey@adacore.com>
11380
11381 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11382 rvalue reference.
11383 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11384 (gdb_xml_parser::parse): Use std::move.
11385 * python/python-internal.h (gdbpy_convert_exception): Take a const
11386 reference.
11387 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11388 std::move.
11389 * python/py-utils.c (gdbpy_convert_exception): Take a const
11390 reference.
11391 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11392 Use std::move.
11393 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11394 Use std::move.
11395 * mi/mi-main.c (mi_print_exception): Take a const reference.
11396 * main.c (handle_command_errors): Take a const reference.
11397 * linespec.c (parse_linespec): Use std::move.
11398 * infcall.c (run_inferior_call): Use std::move.
11399 (call_function_by_hand_dummy): Use std::move.
11400 * exec.c (try_open_exec_file): Use std::move.
11401 * exceptions.h (exception_print, exception_fprintf)
11402 (exception_print_same): Update.
11403 * exceptions.c (print_exception, exception_print)
11404 (exception_fprintf, exception_print_same): Change parameters to
11405 const reference.
11406 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11407 * common/new-op.c: Use std::move.
11408 * common/common-exceptions.h (struct gdb_exception): Add move
11409 constructor.
11410 (struct gdb_exception_error, struct gdb_exception_quit, struct
11411 gdb_quit_bad_alloc): Change constructor to move constructor.
11412 (throw_exception): Change parameter to rvalue reference.
11413 * common/common-exceptions.c (throw_exception): Take rvalue
11414 reference.
11415 * cli/cli-interp.c (safe_execute_command): Use std::move.
11416 * breakpoint.c (insert_bp_location, location_to_sals): Use
11417 std::move.
11418
11419 2019-04-25 Tom Tromey <tromey@adacore.com>
11420
11421 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11422 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11423 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11424 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11425 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11426 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11427 guile/scm-value.c: Use unpack.
11428 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11429 gdbscm_gdb_exception.
11430 (gdbscm_throw_gdb_exception): Likewise.
11431 (struct gdbscm_gdb_exception): New.
11432 (unpack): New function.
11433 (gdbscm_wrap): Use unpack.
11434
11435 2019-04-25 Tom Tromey <tromey@adacore.com>
11436
11437 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11438 (gdb_rl_callback_handler): Use std::move.
11439 * common/common-exceptions.h (struct gdb_exception): Add move
11440 assignment operator.
11441 (throw_exception_sjlj): Change "exception" to const reference.
11442 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11443 (throw_exception_sjlj): Change "exception" to const reference.
11444
11445 2019-04-25 Tom Tromey <tromey@adacore.com>
11446
11447 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11448 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11449 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11450 Update.
11451 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11452 Update.
11453 * mi/mi-interp.c (mi_interp::exec): Update.
11454 * linespec.c (parse_linespec): Update.
11455 * infcall.c (run_inferior_call): Update.
11456 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11457 * guile/scm-symbol.c (gdbscm_lookup_symbol)
11458 (gdbscm_lookup_global_symbol): Update.
11459 * guile/scm-param.c (gdbscm_parameter_value): Update.
11460 * guile/scm-frame.c (gdbscm_frame_read_register)
11461 (gdbscm_frame_read_var): Update.
11462 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11463 * exec.c (try_open_exec_file): Update.
11464 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11465 (gdb_rl_callback_handler): Update.
11466 * common/common-exceptions.h (exception_none): Don't declare.
11467 * common/common-exceptions.c (exception_none): Don't define.
11468 (struct catcher) <exception>: Update.
11469 * cli/cli-interp.c (safe_execute_command): Update.
11470 * breakpoint.c (insert_bp_location, location_to_sals): Update.
11471
11472 2019-04-25 Ali Tamur <tamur@google.com>
11473
11474 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11475 (read_attribute_value): Likewise.
11476 (dwarf2_read_addr_index): Update comment.
11477 (read_str_index): Add DW_FORM_strx.
11478 (dwarf2_string_attr): Likewise.
11479 (dwarf2_const_value_attr): Likewise.
11480 (dump_die_shallow): Likewise.
11481 (dwarf2_fetch_constant_bytes): Likewise.
11482 (skip_form_bytes): Likewise.
11483 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11484
11485 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
11486
11487 PR corefiles/11608
11488 PR corefiles/18187
11489 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11490 OFFSET. Verify if current mapping contains an ELF header.
11491 (linux_find_memory_regions_full): Adjust call to
11492 dump_mapping_p.
11493
11494 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
11495 Kang Li <kanglictf@gmail.com>
11496
11497 PR gdb/21600
11498
11499 * dwarf2-frame.c (read_initial_length): Be consistent about using
11500 unsigned representation of length.
11501 (decode_frame_entry_1): Likewise. Check for wraparound of
11502 end pointer as well as buffer overflow.
11503
11504 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
11505
11506 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11507 "vq".
11508
11509 2019-04-24 Tom Tromey <tromey@adacore.com>
11510
11511 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11512
11513 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11514
11515 * s12z-tdep.c (s12z_unwind_pc): Delete.
11516 (s12z_unwind_sp): Delete.
11517 (s12z_gdbarch_init): Don't register deleted functions with
11518 gdbarch.
11519
11520 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11521
11522 * rl78-tdep.c (rl78_unwind_sp): Delete.
11523 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11524
11525 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11526
11527 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11528 (xstormy16_unwind_pc): Delete.
11529 (xstormy16_dummy_id): Delete.
11530 (xstormy16_gdbarch_init): Don't register deleted functions with
11531 gdbarch.
11532
11533 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11534
11535 * vax-tdep.c (vax_unwind_pc): Delete.
11536 (vax_gdbarch_init): Don't register deleted function with gdbarch.
11537
11538 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11539
11540 * v850-tdep.c (v850_unwind_sp): Delete.
11541 (v850_unwind_pc): Delete.
11542 (v850_dummy_id): Delete.
11543 (v850_gdbarch_init): Don't register deleted functions with
11544 gdbarch.
11545
11546 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11547
11548 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11549 (tilegx_unwind_pc): Delete.
11550 (tilegx_unwind_dummy_id): Delete.
11551 (tilegx_gdbarch_init): Don't register deleted functions with
11552 gdbarch.
11553
11554 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11555
11556 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11557 (tic6x_dummy_id): Delete.
11558 (tic6x_gdbarch_init): Don't register deleted functions with
11559 gdbarch.
11560
11561 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11562
11563 * sparc-tdep.c (sparc_unwind_pc): Delete.
11564 (sparc32_gdbarch_init): Don't register deleted function with
11565 gdbarch.
11566
11567 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11568
11569 * sh-tdep.c (sh_unwind_sp): Delete.
11570 (sh_unwind_pc): Delete.
11571 (sh_dummy_id): Delete.
11572 (sh_gdbarch_init): Don't register deleted functions with
11573 gdbarch.
11574
11575 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11576
11577 * score-tdep.c (score_unwind_sp): Delete.
11578 (score_unwind_pc): Delete.
11579 (score_dummy_id): Delete.
11580 (score_gdbarch_init): Don't register deleted functions with
11581 gdbarch.
11582
11583 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11584
11585 * rx-tdep.c (rx_unwind_pc): Delete.
11586 (rx_unwind_sp): Delete.
11587 (rx_dummy_id): Delete.
11588 (rx_gdbarch_init): Don't register deleted functions with
11589 gdbarch. Update comment.
11590
11591 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11592
11593 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11594 (rs6000_dummy_id): Delete.
11595 (rs6000_gdbarch_init): Don't register deleted functions with
11596 gdbarch.
11597
11598 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11599
11600 * or1k-tdep.c (or1k_dummy_id): Delete.
11601 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11602
11603 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11604
11605 * nios2-tdep.c (nios2_dummy_id): Delete.
11606 (nios2_unwind_sp): Delete.
11607 (nios2_gdbarch_init): Don't register deleted functions with
11608 gdbarch.
11609
11610 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11611
11612 * nds32-tdep.c (nds32_dummy_id): Delete.
11613 (nds32_unwind_pc): Delete.
11614 (nds32_unwind_sp): Delete.
11615 (nds32_gdbarch_init): Don't register deleted functions with
11616 gdbarch.
11617
11618 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11619
11620 * msp430-tdep.c (msp430_unwind_pc): Delete.
11621 (msp430_unwind_sp): Delete.
11622 (msp430_dummy_id): Delete.
11623 (msp430_gdbarch_init): Don't register deleted functions with
11624 gdbarch.
11625
11626 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11627
11628 * moxie-tdep.c (moxie_unwind_sp): Delete.
11629 (moxie_unwind_pc): Delete.
11630 (moxie_dummy_id): Delete.
11631 (moxie_gdbarch_init): Don't register deleted functions with
11632 gdbarch.
11633
11634 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11635
11636 * mn10300-tdep.c (mn10300_dummy_id): Delete.
11637 (mn10300_unwind_pc): Delete.
11638 (mn10300_unwind_sp): Delete.
11639 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11640 mn10300_unwind_sp.
11641 (mn10300_frame_unwind_init): Don't register deleted functions with
11642 gdbarch.
11643
11644 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11645
11646 * mep-tdep.c (mep_unwind_pc): Delete.
11647 (mep_unwind_sp): Delete.
11648 (mep_dummy_id): Delete.
11649 (mep_gdbarch_init): Don't register deleted functions with
11650 gdbarch.
11651
11652 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11653
11654 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11655 (m68hc11_unwind_sp): Delete.
11656 (m68hc11_gdbarch_init): Don't register deleted functions with
11657 gdbarch.
11658
11659 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11660
11661 * m32r-tdep.c (m32r_unwind_sp): Delete.
11662 (m32r_unwind_pc): Delete.
11663 (m32r_dummy_id): Delete.
11664 (m32r_gdbarch_init): Don't register deleted functions with
11665 gdbarch.
11666
11667 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11668
11669 * m32c-tdep.c (m32c_unwind_pc): Delete.
11670 (m32c_unwind_sp): Delete.
11671 (m32c_dummy_id): Delete.
11672 (m32c_gdbarch_init): Don't register deleted functions with
11673 gdbarch.
11674
11675 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11676
11677 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11678 (lm32_unwind_pc): Delete.
11679 (lm32_dummy_id): Delete.
11680 (lm32_gdbarch_init): Don't register deleted functions with
11681 gdbarch.
11682
11683 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11684
11685 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11686 (iq2000_unwind_pc): Delete.
11687 (iq2000_dummy_id): Delete.
11688 (iq2000_gdbarch_init): Don't register deleted functions with
11689 gdbarch.
11690
11691 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11692
11693 * nds32-tdep.c (nds32_type_align): Delete.
11694 (nds32_push_dummy_call): Use type_align instead.
11695
11696 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11697
11698 * arm-tdep.c (arm_type_align): Only handle vector override case.
11699 (arm_push_dummy_call): Use type_align.
11700 (arm_gdbarch_init): Register arm_type_align gdbarch function.
11701
11702 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
11703
11704 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11705 case.
11706 (pass_on_stack): Use type_align.
11707 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11708 function.
11709
11710 2019-04-23 Tom Tromey <tromey@adacore.com>
11711
11712 * dwarf2read.c (line_header::file_name_at): Remove unused
11713 overload.
11714
11715 2019-04-23 Tom de Vries <tdevries@suse.de>
11716
11717 PR gdb/24438
11718 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11719 invocation.
11720
11721
11722 2019-03-27 Ali Tamur <tamur@google.com>
11723
11724 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11725 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11726 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11727 (dwarf_expr_context::get_addr_index): Likewise
11728 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11729 (symbol_needs_eval_context::get_addr_index): Likewise
11730 (disassemble_dwarf_expression): Add DW_OP_addrx
11731 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11732 (read_cutu_die_from_dwo): Update comment
11733 (skip_one_die): Add DW_FORM_addrx
11734 (read_attribute_value): Likewise
11735 (var_decode_location): Add DW_OP_addrx
11736 (dwarf2_const_value_attr): Add DW_FORM_addrx
11737 (dump_die_shallow): Likewise
11738 (dwarf2_fetch_constant_bytes): Likewise
11739 (decode_locdesc): Add DW_OP_addrx
11740 (skip_form_bytes): Add DW_FORM_addrx
11741
11742 2019-04-22 Ali Tamur <tamur@google.com>
11743
11744 * MAINTAINERS (Write After Approval): Add self.
11745
11746 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
11747
11748 * solib-svr4.c (get_svr4_info): Add pspace parameter.
11749 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11750 (open_symbol_file_object): Likewise.
11751 (svr4_default_sos): Add info parameter.
11752 (svr4_read_so_list): Likewise.
11753 (svr4_current_sos_direct): Adjust functions calls to pass down
11754 info.
11755 (svr4_current_sos_1): Add info parameter.
11756 (svr4_current_sos): Call get_svr4_info, pass info down to
11757 svr4_current_sos_1.
11758 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11759 get_svr4_info.
11760 (svr4_in_dynsym_resolve_code): Pass current_program_space to
11761 get_svr4_info.
11762 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11763 to get_svr4_info.
11764 (probes_table_remove_objfile_probes): Likewise.
11765 (register_solib_event_probe): Add info parameter.
11766 (solist_update_incremental): Pass info parameter down to
11767 svr4_read_so_list.
11768 (disable_probes_interface): Add info parameter.
11769 (svr4_handle_solib_event): Pass current_program_space to
11770 get_svr4_info. Adjust disable_probes_interface cleanup.
11771 (svr4_create_probe_breakpoints): Add info parameter, pass it
11772 down to register_solib_event_probe.
11773 (svr4_create_solib_event_breakpoints): Add info parameter,
11774 pass it down to svr4_create_probe_breakpoints.
11775 (enable_break): Pass info down to
11776 svr4_create_solib_event_breakpoints.
11777 (svr4_solib_create_inferior_hook): Pass current_program_space to
11778 get_svr4_info.
11779 (svr4_clear_solib): Likewise.
11780
11781 2019-04-22 Pedro Alves <palves@redhat.com>
11782
11783 * solib-svr4.c (svr4_free_objfile_observer): New.
11784 (probe_and_action::objfile): New field.
11785 (probes_table_htab_remove_objfile_probes)
11786 (probes_table_remove_objfile_probes): New functions.
11787 (register_solib_event_probe): Add 'objfile' parameter. Store it
11788 in the new probe_and_action. Don't store the probe in 'lookup'.
11789 (svr4_create_probe_breakpoints): Pass objfile to
11790 register_solib_event_probe.
11791 (_initialize_svr4_solib): Register a free_objfile observer.
11792
11793 2019-04-19 Tom Tromey <tom@tromey.com>
11794
11795 * common/queue.h: Remove.
11796
11797 2019-04-19 Tom Tromey <tom@tromey.com>
11798
11799 * event-loop.c: Don't include "common/queue.h".
11800
11801 2019-04-19 Tom Tromey <tom@tromey.com>
11802
11803 * remote.c (remote_target): Use delete.
11804 * remote-notif.h: Include <list>, not "common/queue.h".
11805 (notif_client_p): Remove typedef.
11806 (remote_notif_state): Add constructor, destructor, initializer.
11807 <notif_queue>: Now a std::list.
11808 (remote_notif_state_xfree): Don't declare.
11809 * remote-notif.c (remote_notif_process, handle_notification)
11810 (remote_notif_state_allocate): Update.
11811 (~remote_notif_state): Rename from remote_notif_state_xfree.
11812
11813 2019-04-19 Tom Tromey <tom@tromey.com>
11814
11815 * symfile.c (reread_symbols): Update.
11816 * objfiles.c (objfile_register_static_link)
11817 (objfile_lookup_static_link): Update
11818 (~objfile) Don't delete static_links.
11819 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11820
11821 2019-04-19 Tom Tromey <tom@tromey.com>
11822
11823 * type-stack.h (struct type_stack) <insert>: Constify string.
11824 * type-stack.c (type_stack::insert): Constify string.
11825 * gdbtypes.h (lookup_template_type): Update.
11826 (address_space_name_to_int): Update.
11827 * gdbtypes.c (address_space_name_to_int): Make space_identifier
11828 const.
11829 (lookup_template_type): Make name const.
11830 * c-exp.y: Update rules.
11831 (lex_one_token, classify_name, classify_inner_name)
11832 (c_print_token): Update.
11833 * p-exp.y: Update rules.
11834 (yylex): Update.
11835 * f-exp.y: Update rules.
11836 (yylex): Update.
11837 * d-exp.y: Update rules.
11838 (lex_one_token, classify_name, classify_inner_name): Update.
11839 * parse.c (write_dollar_variable, copy_name): Return std::string.
11840 * parser-defs.h (copy_name): Change return type.
11841 * m2-exp.y: Update rules.
11842 (yylex): Update.
11843 * go-exp.y (lex_one_token): Update.
11844 Update rules.
11845 (classify_unsafe_function, classify_packaged_name)
11846 (classify_name, yylex): Update.
11847
11848 2019-04-19 Sergei Trofimovich <siarheit@google.com>
11849
11850 * configure.ac: add --enable-source-highlight switch.
11851 * configure: Regenerate.
11852 * top.c (print_gdb_version): plumb --enable-source-highlight
11853 status to "show configuration".
11854
11855 2019-04-19 Tom Tromey <tromey@adacore.com>
11856
11857 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11858 Check ADA_TYPE_P.
11859 (empty_record, ada_template_to_fixed_record_type_1)
11860 (template_to_static_fixed_type)
11861 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11862 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11863 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11864 macros.
11865
11866 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
11867
11868 PR symtab/24423:
11869 * source.c (print_source_lines_base): Advance "iter" when a
11870 control character is seen.
11871
11872 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11873
11874 * inferior.h (struct infcall_suspend_state_deleter):
11875 Catch exception in destructor to avoid crash.
11876
11877 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
11878
11879 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11880 close to the add_com "shell".
11881
11882 2019-04-18 Tom Tromey <tromey@adacore.com>
11883
11884 * process-stratum-target.h (class process_stratum_target)
11885 <stratum>: Add "final".
11886
11887 2019-04-17 Tom Tromey <tromey@adacore.com>
11888
11889 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11890 against nullptr before use.
11891
11892 2019-04-17 Alan Hayward <alan.hayward@arm.com>
11893
11894 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11895
11896 2019-04-17 Jim Wilson <jimw@sifive.com>
11897 Andrew Burgess <andrew.burgess@embecosm.com>
11898
11899 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11900 code read might fail, assume 4-byte breakpoint in that case.
11901
11902 2019-04-15 Leszek Swirski <leszeks@google.com>
11903
11904 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11905 rather than a hand-rolled POD check when checking for forced MEMORY
11906 classification.
11907
11908 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11909
11910 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11911 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11912 function.
11913 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11914 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11915 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11916 declaration.
11917
11918 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11919
11920 * aarch64-linux-nat.c
11921 (aarch64_linux_nat_target::thread_architecture): Add override.
11922 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11923 each VQ.
11924
11925 2019-04-15 Alan Hayward <alan.hayward@arm.com>
11926
11927 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11928
11929 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
11930
11931 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11932 target types of size 96-bits, add some additional comments, and
11933 check that the builtin type we found was the correct size.
11934
11935 2019-04-12 Eli Zaretskii <eliz@gnu.org>
11936
11937 * utils.c (prompt_for_continue): Don't restore the styling at the
11938 end, as applied_style has the wrong value. This fixes styling in
11939 long lists of file names that are interrupted by the "Continue?"
11940 prompt.
11941
11942 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
11943
11944 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11945 * c-lang.c (c_language_defn): Likewise.
11946 (cplus_language_defn): Likewise.
11947 (asm_language_defn): Likewise.
11948 (minimal_language_defn): Likewise.
11949 * d-lang.c (d_language_defn): Likewise.
11950 * f-lang.c (f_language_defn): Likewise.
11951 * go-lang.c (go_language_defn): Likewise.
11952 * language.c (unknown_language_defn): Likewise.
11953 (auto_language_defn): Likewise.
11954 * language.h (struct language_defn): Remove la_magic field.
11955 (LANG_MAGIC): Delete.
11956 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11957 * objc-lang.c (objc_language_defn): Likewise.
11958 * opencl-lang.c (opencl_language_defn): Likewise.
11959 * p-lang.c (pascal_language_defn): Likewise.
11960 * rust-lang.c (rust_language_defn): Likewise.
11961
11962 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11963
11964 * riscv-tdep.c (riscv_type_align): New function.
11965 (riscv_type_alignment): Delete.
11966 (riscv_arg_location): Use 'type_align'.
11967 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11968
11969 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11970
11971 * gdbtypes.c (type_align): A struct with no non-static fields also
11972 has alignment of 1.
11973
11974 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11975
11976 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11977 component to 0.
11978 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11979 member.
11980 (riscv_struct_info::analyse): New implementation using new
11981 analyse_inner member function.
11982 (riscv_struct_info::field_offset): New member function.
11983 (riscv_struct_info::m_offsets): New member variable.
11984 (riscv_struct_info::analyse_inner): New private member function,
11985 takes the old implementation of riscv_struct_info::analyse but
11986 extended to track field offsets.
11987 (riscv_call_arg_struct): Update the struct folding special cases
11988 to handle cases where empty C++ structs, which are non-zero
11989 length, are found.
11990 (riscv_arg_location): Initialise the length of each location, a
11991 non-zero length now indicates the location is in use.
11992 (riscv_push_dummy_call): Allow for the first location having a
11993 non-zero offset when setting up arguments.
11994 (riscv_return_value): Likewise, but for return values.
11995
11996 2019-04-11 Tom Tromey <tromey@adacore.com>
11997
11998 * utils.c (internal_vproblem): Make "msg" const.
11999
12000 2019-04-11 Alan Hayward <alan.hayward@arm.com>
12001
12002 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
12003 * trad-frame.c (trad_frame_reset_saved_regs): New function.
12004 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
12005 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
12006
12007 2019-04-10 Kevin Buettner <kevinb@redhat.com>
12008
12009 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
12010 function.
12011 (fill_gregset): Call amd64_linux_collect_native_gregset instead
12012 of amd64_collect_native_gregset.
12013 (amd64_linux_nat_target::store_registers): Likewise.
12014
12015 2019-04-10 Tom Tromey <tom@tromey.com>
12016
12017 * symtab.c (lookup_global_symbol_from_objfile)
12018 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
12019 * objfiles.h (class separate_debug_iterator): New.
12020 (class separate_debug_range): New.
12021 (struct objfile) <separate_debug_objfiles>: New method.
12022 (objfile_separate_debug_iterate): Don't declare.
12023 * objfiles.c (separate_debug_iterator::operator++): Rename from
12024 objfile_separate_debug_iterate.
12025 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
12026 iterator.
12027 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
12028 iterator.
12029
12030 2019-04-10 Tom Tromey <tom@tromey.com>
12031
12032 * symfile.c (reread_symbols): Remove old comment.
12033 * objfiles.c (free_all_objfiles): Fix a typo.
12034
12035 2019-04-10 Tom Tromey <tom@tromey.com>
12036
12037 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
12038 * minsyms.c (lookup_minimal_symbol): Use foreach.
12039 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
12040 (lookup_minimal_symbol_solib_trampoline): Likewise.
12041 * symfile.c (reread_symbols): Use foreach.
12042
12043 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
12044 Tom Tromey <tromey@adacore.com>
12045
12046 PR rust/24414:
12047 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
12048 (rust_lex_int_test): Change "value" to be LONGEST.
12049 (rust_lex_tests): Add test for long integer literal.
12050
12051 2019-04-09 Tom Tromey <tromey@adacore.com>
12052
12053 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
12054 to bool.
12055 (extended_remote_target::attach): Update.
12056 (remote_target::remote_notice_new_inferior): Update.
12057 (remote_target::add_current_inferior_and_thread): Update.
12058 * inferior.c (exit_inferior_1): Use "false".
12059 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
12060
12061 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
12062
12063 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
12064 the "start" command.
12065
12066 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12067
12068 * python/py-inferior.c (infpy_thread_from_thread_handle):
12069 Adjust comments to reflect renaming of thread_from_thread_handle
12070 to thread_from_handle. Adjust keywords. Fix type error message.
12071 (inferior_object_methods): Add thread_from_handle. Retain
12072 thread_from_thread_handle, but mark it as deprecated.
12073
12074 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12075
12076 * gdbthread.h (find_thread_by_handle): Revise declaration.
12077 * thread.c (find_thread_by_handle): Likewise. Adjust
12078 implementation too.
12079 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
12080 support for buffer objects as handles.
12081
12082 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12083
12084 * python/py-infthread.c (thpy_thread_handle): New function.
12085 (thread_object_methods): Register thpy_thread_handle.
12086
12087 2019-04-08 Kevin Buettner <kevinb@redhat.com>
12088
12089 * gdbthread.h (thread_to_thread_handle): Declare.
12090 * thread.c (gdbtypes.h): Include.
12091 (thread_to_thread_handle): New function.
12092
12093 * target.h (struct target_ops): Add thread_info_to_thread_handle.
12094 (target_thread_info_to_thread_handle): Declare.
12095 * target.c (target_thread_info_to_thread_handle): New function.
12096 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
12097 * target-delegates.c: Regenerate.
12098
12099 * linux-thread-db.c (class thread_db_target): Add method
12100 thread_info_to_thread_handle.
12101 (thread_db_target::thread_info_to_thread_handle): Define.
12102 * remote.c (class remote_target): Add new method
12103 thread_info_to_thread_handle.
12104 (remote_target::thread_info_to_thread_handle): Define.
12105
12106 2019-04-08 Pedro Alves <palves@redhat.com>
12107
12108 * common/common-exceptions.c (throw_exception): Don't create
12109 named object to throw; throw directly.
12110 (throw_it): Likewise. Don't initialize gdb_exception::message
12111 here, with new; pass FMT and AP to the ctor instead.
12112 * common/common-exceptions.h: Include <string>.
12113 (gdb_exception::gdb_exception(enum return_reason, enum errors,
12114 const char *, va_list)): New ctor. Use std::make_shared.
12115 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
12116 errors)): Delete.
12117 (gdb_exception_error::gdb_exception_error(enum errors, const char
12118 *, va_list)): New.
12119 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
12120 Add assertion.
12121 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
12122 errors)): Delete.
12123 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
12124 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
12125 Add assertion.
12126
12127 2019-04-08 Tom Tromey <tom@tromey.com>
12128
12129 * valops.c (value_rtti_indirect_type): Replace throw_exception
12130 with throw.
12131 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
12132 with throw.
12133 * thread.c (thr_try_catch_cmd): Replace throw_exception with
12134 throw.
12135 * target.c (target_translate_tls_address): Replace throw_exception
12136 with throw.
12137 * stack.c (frame_apply_command_count): Replace throw_exception
12138 with throw.
12139 * solib-spu.c (append_ocl_sos): Replace throw_exception with
12140 throw.
12141 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
12142 with throw.
12143 * rs6000-tdep.c (rs6000_frame_cache)
12144 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
12145 * remote.c: Replace throw_exception with throw.
12146 * record-full.c (record_full_message, record_full_wait_1)
12147 (record_full_restore): Replace throw_exception with throw.
12148 * record-btrace.c:
12149 (get_thread_current_frame_id, record_btrace_start_replaying)
12150 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12151 (cmd_record_btrace_start): Replace throw_exception with throw.
12152 * parse.c (parse_exp_in_context_1): Replace throw_exception with
12153 throw.
12154 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12155 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12156 * linespec.c:
12157 (find_linespec_symbols): Replace throw_exception with throw.
12158 * infrun.c (displaced_step_prepare, resume): Replace
12159 throw_exception with throw.
12160 * infcmd.c (post_create_inferior): Replace throw_exception with
12161 throw.
12162 * inf-loop.c (inferior_event_handler): Replace throw_exception
12163 with throw.
12164 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12165 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12166 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12167 (get_prev_frame_always, get_frame_pc_if_available)
12168 (get_frame_address_in_block_if_available, get_frame_language):
12169 Replace throw_exception with throw.
12170 * frame-unwind.c (frame_unwind_try_unwinder): Replace
12171 throw_exception with throw.
12172 * eval.c (fetch_subexp_value, evaluate_var_value)
12173 (evaluate_funcall, evaluate_subexp_standard): Replace
12174 throw_exception with throw.
12175 * dwarf2loc.c (call_site_find_chain)
12176 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12177 Replace throw_exception with throw.
12178 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12179 with throw.
12180 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12181 throw.
12182 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12183 * completer.c (complete_line_internal): Replace throw_exception
12184 with throw.
12185 * compile/compile-object-run.c (compile_object_run): Replace
12186 throw_exception with throw.
12187 * cli/cli-script.c (process_next_line): Replace throw_exception
12188 with throw.
12189 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12190 (btrace_enable, btrace_maint_update_pt_packets): Replace
12191 throw_exception with throw.
12192 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12193 throw_exception with throw.
12194 * break-catch-throw.c (re_set_exception_catchpoint): Replace
12195 throw_exception with throw.
12196 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12197 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12198 * aarch64-tdep.c (aarch64_make_prologue_cache)
12199 (aarch64_make_stub_cache): Replace throw_exception with throw.
12200
12201 2019-04-08 Tom Tromey <tom@tromey.com>
12202
12203 * common/common-exceptions.c (throw_exception): Rename from
12204 throw_exception_cxx. Remove old copy. Make argument const.
12205 (throw_it): Create and throw exception objects directly.
12206 * common/common-exceptions.h (throw_exception): Make argument
12207 const.
12208 (struct gdb_exception_error): Add constructor.
12209 (struct gdb_exception_quit): Add constructor.
12210
12211 2019-04-08 Tom Tromey <tom@tromey.com>
12212
12213 * common/common-exceptions.h (exception_rethrow): Don't declare.
12214 (TRY_SJLJ): Update comment.
12215 (TRY, CATCH, END_CATCH): Remove.
12216 * common/common-exceptions.c (exception_rethrow): Remove.
12217
12218 2019-04-08 Tom Tromey <tom@tromey.com>
12219
12220 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12221 Remove.
12222 (gdb_exception_error): Rename from
12223 gdb_exception_RETURN_MASK_ERROR.
12224 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12225 (gdb_quit_bad_alloc): Update.
12226 * aarch64-tdep.c: Update.
12227 * ada-lang.c: Update.
12228 * ada-typeprint.c: Update.
12229 * ada-valprint.c: Update.
12230 * amd64-tdep.c: Update.
12231 * arch-utils.c: Update.
12232 * break-catch-throw.c: Update.
12233 * breakpoint.c: Update.
12234 * btrace.c: Update.
12235 * c-varobj.c: Update.
12236 * cli/cli-cmds.c: Update.
12237 * cli/cli-interp.c: Update.
12238 * cli/cli-script.c: Update.
12239 * common/common-exceptions.c: Update.
12240 * common/new-op.c: Update.
12241 * common/selftest.c: Update.
12242 * compile/compile-c-symbols.c: Update.
12243 * compile/compile-cplus-symbols.c: Update.
12244 * compile/compile-object-load.c: Update.
12245 * compile/compile-object-run.c: Update.
12246 * completer.c: Update.
12247 * corelow.c: Update.
12248 * cp-abi.c: Update.
12249 * cp-support.c: Update.
12250 * cp-valprint.c: Update.
12251 * darwin-nat.c: Update.
12252 * disasm-selftests.c: Update.
12253 * dtrace-probe.c: Update.
12254 * dwarf-index-cache.c: Update.
12255 * dwarf-index-write.c: Update.
12256 * dwarf2-frame-tailcall.c: Update.
12257 * dwarf2-frame.c: Update.
12258 * dwarf2loc.c: Update.
12259 * dwarf2read.c: Update.
12260 * eval.c: Update.
12261 * event-loop.c: Update.
12262 * event-top.c: Update.
12263 * exec.c: Update.
12264 * f-valprint.c: Update.
12265 * fbsd-tdep.c: Update.
12266 * frame-unwind.c: Update.
12267 * frame.c: Update.
12268 * gdbtypes.c: Update.
12269 * gnu-v3-abi.c: Update.
12270 * guile/guile-internal.h: Update.
12271 * guile/scm-block.c: Update.
12272 * guile/scm-breakpoint.c: Update.
12273 * guile/scm-cmd.c: Update.
12274 * guile/scm-disasm.c: Update.
12275 * guile/scm-frame.c: Update.
12276 * guile/scm-lazy-string.c: Update.
12277 * guile/scm-math.c: Update.
12278 * guile/scm-param.c: Update.
12279 * guile/scm-ports.c: Update.
12280 * guile/scm-pretty-print.c: Update.
12281 * guile/scm-symbol.c: Update.
12282 * guile/scm-symtab.c: Update.
12283 * guile/scm-type.c: Update.
12284 * guile/scm-value.c: Update.
12285 * i386-linux-tdep.c: Update.
12286 * i386-tdep.c: Update.
12287 * inf-loop.c: Update.
12288 * infcall.c: Update.
12289 * infcmd.c: Update.
12290 * infrun.c: Update.
12291 * jit.c: Update.
12292 * language.c: Update.
12293 * linespec.c: Update.
12294 * linux-fork.c: Update.
12295 * linux-nat.c: Update.
12296 * linux-tdep.c: Update.
12297 * linux-thread-db.c: Update.
12298 * main.c: Update.
12299 * mi/mi-cmd-break.c: Update.
12300 * mi/mi-cmd-stack.c: Update.
12301 * mi/mi-interp.c: Update.
12302 * mi/mi-main.c: Update.
12303 * objc-lang.c: Update.
12304 * p-valprint.c: Update.
12305 * parse.c: Update.
12306 * ppc-linux-tdep.c: Update.
12307 * printcmd.c: Update.
12308 * python/py-arch.c: Update.
12309 * python/py-breakpoint.c: Update.
12310 * python/py-cmd.c: Update.
12311 * python/py-finishbreakpoint.c: Update.
12312 * python/py-frame.c: Update.
12313 * python/py-framefilter.c: Update.
12314 * python/py-gdb-readline.c: Update.
12315 * python/py-inferior.c: Update.
12316 * python/py-infthread.c: Update.
12317 * python/py-lazy-string.c: Update.
12318 * python/py-linetable.c: Update.
12319 * python/py-objfile.c: Update.
12320 * python/py-param.c: Update.
12321 * python/py-prettyprint.c: Update.
12322 * python/py-progspace.c: Update.
12323 * python/py-record-btrace.c: Update.
12324 * python/py-record.c: Update.
12325 * python/py-symbol.c: Update.
12326 * python/py-type.c: Update.
12327 * python/py-unwind.c: Update.
12328 * python/py-utils.c: Update.
12329 * python/py-value.c: Update.
12330 * python/python.c: Update.
12331 * record-btrace.c: Update.
12332 * record-full.c: Update.
12333 * remote-fileio.c: Update.
12334 * remote.c: Update.
12335 * riscv-tdep.c: Update.
12336 * rs6000-aix-tdep.c: Update.
12337 * rs6000-tdep.c: Update.
12338 * rust-exp.y: Update.
12339 * rust-lang.c: Update.
12340 * s390-tdep.c: Update.
12341 * selftest-arch.c: Update.
12342 * solib-dsbt.c: Update.
12343 * solib-frv.c: Update.
12344 * solib-spu.c: Update.
12345 * solib-svr4.c: Update.
12346 * solib.c: Update.
12347 * sparc64-linux-tdep.c: Update.
12348 * stack.c: Update.
12349 * symfile-mem.c: Update.
12350 * symmisc.c: Update.
12351 * target.c: Update.
12352 * thread.c: Update.
12353 * top.c: Update.
12354 * tracefile-tfile.c: Update.
12355 * tui/tui.c: Update.
12356 * typeprint.c: Update.
12357 * unittests/cli-utils-selftests.c: Update.
12358 * unittests/parse-connection-spec-selftests.c: Update.
12359 * valops.c: Update.
12360 * valprint.c: Update.
12361 * value.c: Update.
12362 * varobj.c: Update.
12363 * windows-nat.c: Update.
12364 * x86-linux-nat.c: Update.
12365 * xml-support.c: Update.
12366
12367 2019-04-08 Tom Tromey <tom@tromey.com>
12368
12369 * xml-support.c: Use C++ exception handling.
12370 * x86-linux-nat.c: Use C++ exception handling.
12371 * windows-nat.c: Use C++ exception handling.
12372 * varobj.c: Use C++ exception handling.
12373 * value.c: Use C++ exception handling.
12374 * valprint.c: Use C++ exception handling.
12375 * valops.c: Use C++ exception handling.
12376 * unittests/parse-connection-spec-selftests.c: Use C++ exception
12377 handling.
12378 * unittests/cli-utils-selftests.c: Use C++ exception handling.
12379 * typeprint.c: Use C++ exception handling.
12380 * tui/tui.c: Use C++ exception handling.
12381 * tracefile-tfile.c: Use C++ exception handling.
12382 * top.c: Use C++ exception handling.
12383 * thread.c: Use C++ exception handling.
12384 * target.c: Use C++ exception handling.
12385 * symmisc.c: Use C++ exception handling.
12386 * symfile-mem.c: Use C++ exception handling.
12387 * stack.c: Use C++ exception handling.
12388 * sparc64-linux-tdep.c: Use C++ exception handling.
12389 * solib.c: Use C++ exception handling.
12390 * solib-svr4.c: Use C++ exception handling.
12391 * solib-spu.c: Use C++ exception handling.
12392 * solib-frv.c: Use C++ exception handling.
12393 * solib-dsbt.c: Use C++ exception handling.
12394 * selftest-arch.c: Use C++ exception handling.
12395 * s390-tdep.c: Use C++ exception handling.
12396 * rust-lang.c: Use C++ exception handling.
12397 * rust-exp.y: Use C++ exception handling.
12398 * rs6000-tdep.c: Use C++ exception handling.
12399 * rs6000-aix-tdep.c: Use C++ exception handling.
12400 * riscv-tdep.c: Use C++ exception handling.
12401 * remote.c: Use C++ exception handling.
12402 * remote-fileio.c: Use C++ exception handling.
12403 * record-full.c: Use C++ exception handling.
12404 * record-btrace.c: Use C++ exception handling.
12405 * python/python.c: Use C++ exception handling.
12406 * python/py-value.c: Use C++ exception handling.
12407 * python/py-utils.c: Use C++ exception handling.
12408 * python/py-unwind.c: Use C++ exception handling.
12409 * python/py-type.c: Use C++ exception handling.
12410 * python/py-symbol.c: Use C++ exception handling.
12411 * python/py-record.c: Use C++ exception handling.
12412 * python/py-record-btrace.c: Use C++ exception handling.
12413 * python/py-progspace.c: Use C++ exception handling.
12414 * python/py-prettyprint.c: Use C++ exception handling.
12415 * python/py-param.c: Use C++ exception handling.
12416 * python/py-objfile.c: Use C++ exception handling.
12417 * python/py-linetable.c: Use C++ exception handling.
12418 * python/py-lazy-string.c: Use C++ exception handling.
12419 * python/py-infthread.c: Use C++ exception handling.
12420 * python/py-inferior.c: Use C++ exception handling.
12421 * python/py-gdb-readline.c: Use C++ exception handling.
12422 * python/py-framefilter.c: Use C++ exception handling.
12423 * python/py-frame.c: Use C++ exception handling.
12424 * python/py-finishbreakpoint.c: Use C++ exception handling.
12425 * python/py-cmd.c: Use C++ exception handling.
12426 * python/py-breakpoint.c: Use C++ exception handling.
12427 * python/py-arch.c: Use C++ exception handling.
12428 * printcmd.c: Use C++ exception handling.
12429 * ppc-linux-tdep.c: Use C++ exception handling.
12430 * parse.c: Use C++ exception handling.
12431 * p-valprint.c: Use C++ exception handling.
12432 * objc-lang.c: Use C++ exception handling.
12433 * mi/mi-main.c: Use C++ exception handling.
12434 * mi/mi-interp.c: Use C++ exception handling.
12435 * mi/mi-cmd-stack.c: Use C++ exception handling.
12436 * mi/mi-cmd-break.c: Use C++ exception handling.
12437 * main.c: Use C++ exception handling.
12438 * linux-thread-db.c: Use C++ exception handling.
12439 * linux-tdep.c: Use C++ exception handling.
12440 * linux-nat.c: Use C++ exception handling.
12441 * linux-fork.c: Use C++ exception handling.
12442 * linespec.c: Use C++ exception handling.
12443 * language.c: Use C++ exception handling.
12444 * jit.c: Use C++ exception handling.
12445 * infrun.c: Use C++ exception handling.
12446 * infcmd.c: Use C++ exception handling.
12447 * infcall.c: Use C++ exception handling.
12448 * inf-loop.c: Use C++ exception handling.
12449 * i386-tdep.c: Use C++ exception handling.
12450 * i386-linux-tdep.c: Use C++ exception handling.
12451 * guile/scm-value.c: Use C++ exception handling.
12452 * guile/scm-type.c: Use C++ exception handling.
12453 * guile/scm-symtab.c: Use C++ exception handling.
12454 * guile/scm-symbol.c: Use C++ exception handling.
12455 * guile/scm-pretty-print.c: Use C++ exception handling.
12456 * guile/scm-ports.c: Use C++ exception handling.
12457 * guile/scm-param.c: Use C++ exception handling.
12458 * guile/scm-math.c: Use C++ exception handling.
12459 * guile/scm-lazy-string.c: Use C++ exception handling.
12460 * guile/scm-frame.c: Use C++ exception handling.
12461 * guile/scm-disasm.c: Use C++ exception handling.
12462 * guile/scm-cmd.c: Use C++ exception handling.
12463 * guile/scm-breakpoint.c: Use C++ exception handling.
12464 * guile/scm-block.c: Use C++ exception handling.
12465 * guile/guile-internal.h: Use C++ exception handling.
12466 * gnu-v3-abi.c: Use C++ exception handling.
12467 * gdbtypes.c: Use C++ exception handling.
12468 * frame.c: Use C++ exception handling.
12469 * frame-unwind.c: Use C++ exception handling.
12470 * fbsd-tdep.c: Use C++ exception handling.
12471 * f-valprint.c: Use C++ exception handling.
12472 * exec.c: Use C++ exception handling.
12473 * event-top.c: Use C++ exception handling.
12474 * event-loop.c: Use C++ exception handling.
12475 * eval.c: Use C++ exception handling.
12476 * dwarf2read.c: Use C++ exception handling.
12477 * dwarf2loc.c: Use C++ exception handling.
12478 * dwarf2-frame.c: Use C++ exception handling.
12479 * dwarf2-frame-tailcall.c: Use C++ exception handling.
12480 * dwarf-index-write.c: Use C++ exception handling.
12481 * dwarf-index-cache.c: Use C++ exception handling.
12482 * dtrace-probe.c: Use C++ exception handling.
12483 * disasm-selftests.c: Use C++ exception handling.
12484 * darwin-nat.c: Use C++ exception handling.
12485 * cp-valprint.c: Use C++ exception handling.
12486 * cp-support.c: Use C++ exception handling.
12487 * cp-abi.c: Use C++ exception handling.
12488 * corelow.c: Use C++ exception handling.
12489 * completer.c: Use C++ exception handling.
12490 * compile/compile-object-run.c: Use C++ exception handling.
12491 * compile/compile-object-load.c: Use C++ exception handling.
12492 * compile/compile-cplus-symbols.c: Use C++ exception handling.
12493 * compile/compile-c-symbols.c: Use C++ exception handling.
12494 * common/selftest.c: Use C++ exception handling.
12495 * common/new-op.c: Use C++ exception handling.
12496 * cli/cli-script.c: Use C++ exception handling.
12497 * cli/cli-interp.c: Use C++ exception handling.
12498 * cli/cli-cmds.c: Use C++ exception handling.
12499 * c-varobj.c: Use C++ exception handling.
12500 * btrace.c: Use C++ exception handling.
12501 * breakpoint.c: Use C++ exception handling.
12502 * break-catch-throw.c: Use C++ exception handling.
12503 * arch-utils.c: Use C++ exception handling.
12504 * amd64-tdep.c: Use C++ exception handling.
12505 * ada-valprint.c: Use C++ exception handling.
12506 * ada-typeprint.c: Use C++ exception handling.
12507 * ada-lang.c: Use C++ exception handling.
12508 * aarch64-tdep.c: Use C++ exception handling.
12509
12510 2019-04-08 Tom Tromey <tom@tromey.com>
12511
12512 * xml-support.c (gdb_xml_parser::parse): Update.
12513 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12514 * value.c (show_convenience): Update.
12515 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12516 (test_parse_flags_qcs): Update.
12517 * thread.c (thr_try_catch_cmd): Update.
12518 * target.c (target_translate_tls_address): Update.
12519 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12520 (info_frame_command_core, frame_apply_command_count): Update.
12521 * rust-exp.y (rust_lex_exception_test): Update.
12522 * riscv-tdep.c (riscv_print_one_register_info): Update.
12523 * remote.c (remote_target::enable_btrace): Update.
12524 * record-btrace.c (record_btrace_enable_warn): Update.
12525 * python/py-utils.c (gdbpy_convert_exception): Update.
12526 * printcmd.c (do_one_display, print_variable_and_value): Update.
12527 * mi/mi-main.c (mi_print_exception): Update.
12528 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12529 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12530 * linux-nat.c (linux_nat_target::attach): Update.
12531 * linux-fork.c (class scoped_switch_fork_info): Update.
12532 * infrun.c (displaced_step_prepare): Update.
12533 * infcall.c (call_function_by_hand_dummy): Update.
12534 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12535 * gnu-v3-abi.c (print_one_vtable): Update.
12536 * frame.c (get_prev_frame_always): Update.
12537 * f-valprint.c (info_common_command_for_block): Update.
12538 * exec.c (try_open_exec_file): Update.
12539 * exceptions.c (print_exception, exception_print)
12540 (exception_fprintf, exception_print_same): Update.
12541 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12542 * dwarf-index-cache.c (index_cache::store)
12543 (index_cache::lookup_gdb_index): Update.
12544 * darwin-nat.c (maybe_cache_shell): Update.
12545 * cp-valprint.c (cp_print_value_fields): Update.
12546 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12547 (gcc_cplus_symbol_address): Update.
12548 * compile/compile-c-symbols.c (gcc_convert_symbol)
12549 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12550 * common/selftest.c: Update.
12551 * common/common-exceptions.h (struct gdb_exception) <message>: Now
12552 a std::string.
12553 (exception_try_scope_entry, exception_try_scope_exit): Don't
12554 declare.
12555 (struct exception_try_scope): Remove.
12556 (TRY): Don't use exception_try_scope.
12557 (struct gdb_exception): Add constructor, operator=.
12558 <what>: New method.
12559 (struct gdb_exception_RETURN_MASK_ALL)
12560 (struct gdb_exception_RETURN_MASK_ERROR)
12561 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12562 (struct gdb_quit_bad_alloc): Update.
12563 * common/common-exceptions.c (exception_none): Change
12564 initializer.
12565 (struct catcher) <state, exception>: Initialize inline.
12566 <prev>: Remove member.
12567 (current_catcher): Remove.
12568 (catchers): New global.
12569 (exceptions_state_mc_init): Simplify.
12570 (catcher_pop): Remove.
12571 (exceptions_state_mc, exceptions_state_mc_catch): Update.
12572 (try_scope_depth, exception_try_scope_entry)
12573 (exception_try_scope_exit): Remove.
12574 (throw_exception_sjlj): Update.
12575 (exception_messages, exception_messages_size): Remove.
12576 (throw_it): Simplify.
12577 (gdb_exception_sliced_copy): Remove.
12578 (throw_exception_cxx): Update.
12579 * cli/cli-script.c (script_from_file): Update.
12580 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12581 Update.
12582 * ada-valprint.c (ada_val_print): Update.
12583 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12584 (create_excep_cond_exprs): Update.
12585
12586 2019-04-08 Tom Tromey <tom@tromey.com>
12587
12588 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12589 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12590 (TRY, CATCH, END_CATCH): Remove some definitions.
12591 * common/common-exceptions.c: Don't use GDB_XCPT.
12592 (catcher_list_size): Remove.
12593 (throw_exception, throw_it): Simplify.
12594
12595 2019-04-05 Tom Tromey <tom@tromey.com>
12596
12597 Revert the header-sorting patch.
12598 * ft32-tdep.c: Revert.
12599 * frv-tdep.c: Revert.
12600 * frv-linux-tdep.c: Revert.
12601 * frame.c: Revert.
12602 * frame-unwind.c: Revert.
12603 * frame-base.c: Revert.
12604 * fork-child.c: Revert.
12605 * findvar.c: Revert.
12606 * findcmd.c: Revert.
12607 * filesystem.c: Revert.
12608 * filename-seen-cache.h: Revert.
12609 * filename-seen-cache.c: Revert.
12610 * fbsd-tdep.c: Revert.
12611 * fbsd-nat.h: Revert.
12612 * fbsd-nat.c: Revert.
12613 * f-valprint.c: Revert.
12614 * f-typeprint.c: Revert.
12615 * f-lang.c: Revert.
12616 * extension.h: Revert.
12617 * extension.c: Revert.
12618 * extension-priv.h: Revert.
12619 * expprint.c: Revert.
12620 * exec.h: Revert.
12621 * exec.c: Revert.
12622 * exceptions.c: Revert.
12623 * event-top.c: Revert.
12624 * event-loop.c: Revert.
12625 * eval.c: Revert.
12626 * elfread.c: Revert.
12627 * dwarf2read.h: Revert.
12628 * dwarf2read.c: Revert.
12629 * dwarf2loc.c: Revert.
12630 * dwarf2expr.h: Revert.
12631 * dwarf2expr.c: Revert.
12632 * dwarf2-frame.c: Revert.
12633 * dwarf2-frame-tailcall.c: Revert.
12634 * dwarf-index-write.h: Revert.
12635 * dwarf-index-write.c: Revert.
12636 * dwarf-index-common.c: Revert.
12637 * dwarf-index-cache.h: Revert.
12638 * dwarf-index-cache.c: Revert.
12639 * dummy-frame.c: Revert.
12640 * dtrace-probe.c: Revert.
12641 * disasm.h: Revert.
12642 * disasm.c: Revert.
12643 * disasm-selftests.c: Revert.
12644 * dictionary.c: Revert.
12645 * dicos-tdep.c: Revert.
12646 * demangle.c: Revert.
12647 * dcache.h: Revert.
12648 * dcache.c: Revert.
12649 * darwin-nat.h: Revert.
12650 * darwin-nat.c: Revert.
12651 * darwin-nat-info.c: Revert.
12652 * d-valprint.c: Revert.
12653 * d-namespace.c: Revert.
12654 * d-lang.c: Revert.
12655 * ctf.c: Revert.
12656 * csky-tdep.c: Revert.
12657 * csky-linux-tdep.c: Revert.
12658 * cris-tdep.c: Revert.
12659 * cris-linux-tdep.c: Revert.
12660 * cp-valprint.c: Revert.
12661 * cp-support.c: Revert.
12662 * cp-namespace.c: Revert.
12663 * cp-abi.c: Revert.
12664 * corelow.c: Revert.
12665 * corefile.c: Revert.
12666 * continuations.c: Revert.
12667 * completer.h: Revert.
12668 * completer.c: Revert.
12669 * complaints.c: Revert.
12670 * coffread.c: Revert.
12671 * coff-pe-read.c: Revert.
12672 * cli-out.h: Revert.
12673 * cli-out.c: Revert.
12674 * charset.c: Revert.
12675 * c-varobj.c: Revert.
12676 * c-valprint.c: Revert.
12677 * c-typeprint.c: Revert.
12678 * c-lang.c: Revert.
12679 * buildsym.c: Revert.
12680 * buildsym-legacy.c: Revert.
12681 * build-id.h: Revert.
12682 * build-id.c: Revert.
12683 * btrace.c: Revert.
12684 * bsd-uthread.c: Revert.
12685 * breakpoint.h: Revert.
12686 * breakpoint.c: Revert.
12687 * break-catch-throw.c: Revert.
12688 * break-catch-syscall.c: Revert.
12689 * break-catch-sig.c: Revert.
12690 * blockframe.c: Revert.
12691 * block.c: Revert.
12692 * bfin-tdep.c: Revert.
12693 * bfin-linux-tdep.c: Revert.
12694 * bfd-target.c: Revert.
12695 * bcache.c: Revert.
12696 * ax-general.c: Revert.
12697 * ax-gdb.h: Revert.
12698 * ax-gdb.c: Revert.
12699 * avr-tdep.c: Revert.
12700 * auxv.c: Revert.
12701 * auto-load.c: Revert.
12702 * arm-wince-tdep.c: Revert.
12703 * arm-tdep.c: Revert.
12704 * arm-symbian-tdep.c: Revert.
12705 * arm-pikeos-tdep.c: Revert.
12706 * arm-obsd-tdep.c: Revert.
12707 * arm-nbsd-tdep.c: Revert.
12708 * arm-nbsd-nat.c: Revert.
12709 * arm-linux-tdep.c: Revert.
12710 * arm-linux-nat.c: Revert.
12711 * arm-fbsd-tdep.c: Revert.
12712 * arm-fbsd-nat.c: Revert.
12713 * arm-bsd-tdep.c: Revert.
12714 * arch-utils.c: Revert.
12715 * arc-tdep.c: Revert.
12716 * arc-newlib-tdep.c: Revert.
12717 * annotate.h: Revert.
12718 * annotate.c: Revert.
12719 * amd64-windows-tdep.c: Revert.
12720 * amd64-windows-nat.c: Revert.
12721 * amd64-tdep.c: Revert.
12722 * amd64-sol2-tdep.c: Revert.
12723 * amd64-obsd-tdep.c: Revert.
12724 * amd64-obsd-nat.c: Revert.
12725 * amd64-nbsd-tdep.c: Revert.
12726 * amd64-nbsd-nat.c: Revert.
12727 * amd64-nat.c: Revert.
12728 * amd64-linux-tdep.c: Revert.
12729 * amd64-linux-nat.c: Revert.
12730 * amd64-fbsd-tdep.c: Revert.
12731 * amd64-fbsd-nat.c: Revert.
12732 * amd64-dicos-tdep.c: Revert.
12733 * amd64-darwin-tdep.c: Revert.
12734 * amd64-bsd-nat.c: Revert.
12735 * alpha-tdep.c: Revert.
12736 * alpha-obsd-tdep.c: Revert.
12737 * alpha-nbsd-tdep.c: Revert.
12738 * alpha-mdebug-tdep.c: Revert.
12739 * alpha-linux-tdep.c: Revert.
12740 * alpha-linux-nat.c: Revert.
12741 * alpha-bsd-tdep.c: Revert.
12742 * alpha-bsd-nat.c: Revert.
12743 * aix-thread.c: Revert.
12744 * agent.c: Revert.
12745 * addrmap.c: Revert.
12746 * ada-varobj.c: Revert.
12747 * ada-valprint.c: Revert.
12748 * ada-typeprint.c: Revert.
12749 * ada-tasks.c: Revert.
12750 * ada-lang.c: Revert.
12751 * aarch64-tdep.c: Revert.
12752 * aarch64-ravenscar-thread.c: Revert.
12753 * aarch64-newlib-tdep.c: Revert.
12754 * aarch64-linux-tdep.c: Revert.
12755 * aarch64-linux-nat.c: Revert.
12756 * aarch64-fbsd-tdep.c: Revert.
12757 * aarch64-fbsd-nat.c: Revert.
12758 * aarch32-linux-nat.c: Revert.
12759
12760 2019-04-05 Tom Tromey <tom@tromey.com>
12761
12762 * ft32-tdep.c: Sort headers.
12763 * frv-tdep.c: Sort headers.
12764 * frv-linux-tdep.c: Sort headers.
12765 * frame.c: Sort headers.
12766 * frame-unwind.c: Sort headers.
12767 * frame-base.c: Sort headers.
12768 * fork-child.c: Sort headers.
12769 * findvar.c: Sort headers.
12770 * findcmd.c: Sort headers.
12771 * filesystem.c: Sort headers.
12772 * filename-seen-cache.h: Sort headers.
12773 * filename-seen-cache.c: Sort headers.
12774 * fbsd-tdep.c: Sort headers.
12775 * fbsd-nat.h: Sort headers.
12776 * fbsd-nat.c: Sort headers.
12777 * f-valprint.c: Sort headers.
12778 * f-typeprint.c: Sort headers.
12779 * f-lang.c: Sort headers.
12780 * extension.h: Sort headers.
12781 * extension.c: Sort headers.
12782 * extension-priv.h: Sort headers.
12783 * expprint.c: Sort headers.
12784 * exec.h: Sort headers.
12785 * exec.c: Sort headers.
12786 * exceptions.c: Sort headers.
12787 * event-top.c: Sort headers.
12788 * event-loop.c: Sort headers.
12789 * eval.c: Sort headers.
12790 * elfread.c: Sort headers.
12791 * dwarf2read.h: Sort headers.
12792 * dwarf2read.c: Sort headers.
12793 * dwarf2loc.c: Sort headers.
12794 * dwarf2expr.h: Sort headers.
12795 * dwarf2expr.c: Sort headers.
12796 * dwarf2-frame.c: Sort headers.
12797 * dwarf2-frame-tailcall.c: Sort headers.
12798 * dwarf-index-write.h: Sort headers.
12799 * dwarf-index-write.c: Sort headers.
12800 * dwarf-index-common.c: Sort headers.
12801 * dwarf-index-cache.h: Sort headers.
12802 * dwarf-index-cache.c: Sort headers.
12803 * dummy-frame.c: Sort headers.
12804 * dtrace-probe.c: Sort headers.
12805 * disasm.h: Sort headers.
12806 * disasm.c: Sort headers.
12807 * disasm-selftests.c: Sort headers.
12808 * dictionary.c: Sort headers.
12809 * dicos-tdep.c: Sort headers.
12810 * demangle.c: Sort headers.
12811 * dcache.h: Sort headers.
12812 * dcache.c: Sort headers.
12813 * darwin-nat.h: Sort headers.
12814 * darwin-nat.c: Sort headers.
12815 * darwin-nat-info.c: Sort headers.
12816 * d-valprint.c: Sort headers.
12817 * d-namespace.c: Sort headers.
12818 * d-lang.c: Sort headers.
12819 * ctf.c: Sort headers.
12820 * csky-tdep.c: Sort headers.
12821 * csky-linux-tdep.c: Sort headers.
12822 * cris-tdep.c: Sort headers.
12823 * cris-linux-tdep.c: Sort headers.
12824 * cp-valprint.c: Sort headers.
12825 * cp-support.c: Sort headers.
12826 * cp-namespace.c: Sort headers.
12827 * cp-abi.c: Sort headers.
12828 * corelow.c: Sort headers.
12829 * corefile.c: Sort headers.
12830 * continuations.c: Sort headers.
12831 * completer.h: Sort headers.
12832 * completer.c: Sort headers.
12833 * complaints.c: Sort headers.
12834 * coffread.c: Sort headers.
12835 * coff-pe-read.c: Sort headers.
12836 * cli-out.h: Sort headers.
12837 * cli-out.c: Sort headers.
12838 * charset.c: Sort headers.
12839 * c-varobj.c: Sort headers.
12840 * c-valprint.c: Sort headers.
12841 * c-typeprint.c: Sort headers.
12842 * c-lang.c: Sort headers.
12843 * buildsym.c: Sort headers.
12844 * buildsym-legacy.c: Sort headers.
12845 * build-id.h: Sort headers.
12846 * build-id.c: Sort headers.
12847 * btrace.c: Sort headers.
12848 * bsd-uthread.c: Sort headers.
12849 * breakpoint.h: Sort headers.
12850 * breakpoint.c: Sort headers.
12851 * break-catch-throw.c: Sort headers.
12852 * break-catch-syscall.c: Sort headers.
12853 * break-catch-sig.c: Sort headers.
12854 * blockframe.c: Sort headers.
12855 * block.c: Sort headers.
12856 * bfin-tdep.c: Sort headers.
12857 * bfin-linux-tdep.c: Sort headers.
12858 * bfd-target.c: Sort headers.
12859 * bcache.c: Sort headers.
12860 * ax-general.c: Sort headers.
12861 * ax-gdb.h: Sort headers.
12862 * ax-gdb.c: Sort headers.
12863 * avr-tdep.c: Sort headers.
12864 * auxv.c: Sort headers.
12865 * auto-load.c: Sort headers.
12866 * arm-wince-tdep.c: Sort headers.
12867 * arm-tdep.c: Sort headers.
12868 * arm-symbian-tdep.c: Sort headers.
12869 * arm-pikeos-tdep.c: Sort headers.
12870 * arm-obsd-tdep.c: Sort headers.
12871 * arm-nbsd-tdep.c: Sort headers.
12872 * arm-nbsd-nat.c: Sort headers.
12873 * arm-linux-tdep.c: Sort headers.
12874 * arm-linux-nat.c: Sort headers.
12875 * arm-fbsd-tdep.c: Sort headers.
12876 * arm-fbsd-nat.c: Sort headers.
12877 * arm-bsd-tdep.c: Sort headers.
12878 * arch-utils.c: Sort headers.
12879 * arc-tdep.c: Sort headers.
12880 * arc-newlib-tdep.c: Sort headers.
12881 * annotate.h: Sort headers.
12882 * annotate.c: Sort headers.
12883 * amd64-windows-tdep.c: Sort headers.
12884 * amd64-windows-nat.c: Sort headers.
12885 * amd64-tdep.c: Sort headers.
12886 * amd64-sol2-tdep.c: Sort headers.
12887 * amd64-obsd-tdep.c: Sort headers.
12888 * amd64-obsd-nat.c: Sort headers.
12889 * amd64-nbsd-tdep.c: Sort headers.
12890 * amd64-nbsd-nat.c: Sort headers.
12891 * amd64-nat.c: Sort headers.
12892 * amd64-linux-tdep.c: Sort headers.
12893 * amd64-linux-nat.c: Sort headers.
12894 * amd64-fbsd-tdep.c: Sort headers.
12895 * amd64-fbsd-nat.c: Sort headers.
12896 * amd64-dicos-tdep.c: Sort headers.
12897 * amd64-darwin-tdep.c: Sort headers.
12898 * amd64-bsd-nat.c: Sort headers.
12899 * alpha-tdep.c: Sort headers.
12900 * alpha-obsd-tdep.c: Sort headers.
12901 * alpha-nbsd-tdep.c: Sort headers.
12902 * alpha-mdebug-tdep.c: Sort headers.
12903 * alpha-linux-tdep.c: Sort headers.
12904 * alpha-linux-nat.c: Sort headers.
12905 * alpha-bsd-tdep.c: Sort headers.
12906 * alpha-bsd-nat.c: Sort headers.
12907 * aix-thread.c: Sort headers.
12908 * agent.c: Sort headers.
12909 * addrmap.c: Sort headers.
12910 * ada-varobj.c: Sort headers.
12911 * ada-valprint.c: Sort headers.
12912 * ada-typeprint.c: Sort headers.
12913 * ada-tasks.c: Sort headers.
12914 * ada-lang.c: Sort headers.
12915 * aarch64-tdep.c: Sort headers.
12916 * aarch64-ravenscar-thread.c: Sort headers.
12917 * aarch64-newlib-tdep.c: Sort headers.
12918 * aarch64-linux-tdep.c: Sort headers.
12919 * aarch64-linux-nat.c: Sort headers.
12920 * aarch64-fbsd-tdep.c: Sort headers.
12921 * aarch64-fbsd-nat.c: Sort headers.
12922 * aarch32-linux-nat.c: Sort headers.
12923
12924 2019-04-04 Tom Tromey <tom@tromey.com>
12925
12926 * varobj.c (varobj_create): Update.
12927 * rust-exp.y (struct rust_parser) <update_innermost_block,
12928 lookup_symbol>: New methods.
12929 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12930 Rename.
12931 (rust_parser::rust_lookup_type)
12932 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12933 * printcmd.c (display_command, do_one_display): Update.
12934 * parser-defs.h (struct parser_state) <parser_state>: Add
12935 "tracker" parameter.
12936 (block_tracker): New member.
12937 (class innermost_block_tracker) <innermost_block_tracker>: Add
12938 "types" parameter.
12939 <reset>: Remove method.
12940 (innermost_block): Don't declare.
12941 (null_post_parser): Update.
12942 * parse.c (innermost_block): Remove global.
12943 (write_dollar_variable): Update.
12944 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12945 Remove "tracker_types" parameter.
12946 (parse_expression): Add "tracker" parameter.
12947 (parse_expression_for_completion): Update.
12948 (null_post_parser): Add "tracker" parameter.
12949 * p-exp.y: Update rules.
12950 * m2-exp.y: Update rules.
12951 * language.h (struct language_defn) <la_post_parser>: Add
12952 "tracker" parameter.
12953 * go-exp.y: Update rules.
12954 * f-exp.y: Update rules.
12955 * expression.h (parse_expression, parse_exp_1): Add "tracker"
12956 parameter.
12957 * d-exp.y: Update rules.
12958 * c-exp.y: Update rules.
12959 * breakpoint.c (set_breakpoint_condition): Create an
12960 innermost_block_tracker.
12961 (watch_command_1): Likewise.
12962 * ada-lang.c (resolve): Add "tracker" parameter.
12963 (resolve_subexp): Likewise.
12964 * ada-exp.y (write_var_from_sym): Update.
12965
12966 2019-04-04 Tom Tromey <tom@tromey.com>
12967
12968 * type-stack.h: New file.
12969 * type-stack.c: New file.
12970 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12971 type-stack.h.
12972 (insert_into_type_stack, insert_type, push_type, push_type_int)
12973 (insert_type_address_space, pop_type, pop_type_int)
12974 (pop_typelist, pop_type_stack, append_type_stack)
12975 (push_type_stack, get_type_stack, push_typelist)
12976 (follow_type_instance_flags, follow_types): Don't declare.
12977 * parse.c (type_stack): Remove global.
12978 (parse_exp_in_context): Update.
12979 (insert_into_type_stack, insert_type, push_type, push_type_int)
12980 (insert_type_address_space, pop_type, pop_type_int)
12981 (pop_typelist, pop_type_stack, append_type_stack)
12982 (push_type_stack, get_type_stack, push_typelist)
12983 (follow_type_instance_flags, follow_types): Remove (moved to
12984 type-stack.c).
12985 * f-exp.y (type_stack): New global.
12986 Update rules.
12987 (push_kind_type, f_parse): Update.
12988 * d-exp.y (type_stack): New global.
12989 Update rules.
12990 (d_parse): Update.
12991 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12992 Update rules.
12993 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12994 (HFILES_NO_SRCDIR): Add type-stack.h.
12995
12996 2019-04-04 Tom Tromey <tom@tromey.com>
12997
12998 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12999 (rust_parser::convert_ast_to_expression, rust_parse)
13000 (rust_lex_test_completion, rust_lex_tests): Update.
13001 * parser-defs.h (struct expr_completion_state): New.
13002 (struct parser_state) <parser_state>: Add completion parameter.
13003 <mark_struct_expression, mark_completion_tag>: New methods.
13004 <parse_completion, m_completion_state>: New members.
13005 (prefixify_expression, null_post_parser): Update.
13006 (mark_struct_expression, mark_completion_tag): Don't declare.
13007 * parse.c (parse_completion, expout_last_struct)
13008 (expout_tag_completion_type, expout_completion_name): Remove
13009 globals.
13010 (parser_state::mark_struct_expression)
13011 (parser_state::mark_completion_tag): Now methods.
13012 (prefixify_expression): Add last_struct parameter.
13013 (prefixify_subexp): Likewise.
13014 (parse_exp_1): Update.
13015 (parse_exp_in_context): Add cstate parameter. Update.
13016 (parse_expression_for_completion): Create an
13017 expr_completion_state.
13018 (null_post_parser): Add "completion" parameter.
13019 * p-exp.y: Update rules.
13020 (yylex): Update.
13021 * language.h (struct language_defn) <la_post_parser>: Add
13022 "completing" parameter.
13023 * go-exp.y: Update rules.
13024 (lex_one_token): Update.
13025 * expression.h (parse_completion): Don't declare.
13026 * d-exp.y: Update rules.
13027 (lex_one_token): Update rules.
13028 * c-exp.y: Update rules.
13029 (lex_one_token): Update.
13030 * ada-lang.c (resolve): Add "parse_completion" parameter.
13031 (resolve_subexp): Likewise.
13032 (ada_resolve_function): Likewise.
13033
13034 2019-04-04 Tom Tromey <tom@tromey.com>
13035
13036 * parser-defs.h (struct parser_state) <start_arglist,
13037 end_arglist>: New methods.
13038 <arglist_len, m_funcall_chain>: New members.
13039 (arglist_len, start_arglist, end_arglist): Don't declare.
13040 * parse.c (arglist_len, funcall_chain): Remove global.
13041 (start_arglist, end_arglist): Remove functions.
13042 (parse_exp_in_context): Update.
13043 * p-exp.y: Update rules.
13044 * m2-exp.y: Update rules.
13045 * go-exp.y: Update rules.
13046 * f-exp.y: Update rules.
13047 * d-exp.y: Update rules.
13048 * c-exp.y: Update rules.
13049
13050 2019-04-04 Tom Tromey <tom@tromey.com>
13051
13052 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
13053 lex_operator, push_back>: New methods.
13054 Update all rules.
13055 (rust_parser::lex_hex, lex_escape): Rename and update.
13056 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
13057 (rust_parser::lex_operator): Rename and update.
13058 (rust_parser::lex_number, rustyylex, rustyyerror)
13059 (rust_lex_test_init, rust_lex_test_sequence)
13060 (rust_lex_test_push_back, rust_lex_tests): Update.
13061 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
13062 parameter.
13063 <lexptr, prev_lexptr>: New members.
13064 (lexptr, prev_lexptr): Don't declare.
13065 * parse.c (lexptr, prev_lexptr): Remove globals.
13066 (parse_exp_in_context): Update.
13067 * p-exp.y (yylex, yyerror): Update.
13068 * m2-exp.y (parse_number, yylex, yyerror): Update.
13069 * go-exp.y (lex_one_token, yyerror): Update.
13070 * f-exp.y (match_string_literal, yylex, yyerror): Update.
13071 * d-exp.y (lex_one_token, yyerror): Update.
13072 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
13073 (lex_one_token, yyerror): Update.
13074 * ada-lex.l (YY_INPUT): Update.
13075 (rewind_to_char): Update.
13076 * ada-exp.y (yyerror): Update.
13077
13078 2019-04-04 Tom Tromey <tom@tromey.com>
13079
13080 * rust-exp.y (rustyylex, rust_lex_tests): Update.
13081 * parser-defs.h (struct parser_state) <parser_state>: Add new
13082 parameter.
13083 <comma_terminates>: New member.
13084 (comma_terminates): Don't declare global.
13085 * parse.c (comma_terminates): Remove global.
13086 (parse_exp_in_context): Update.
13087 * p-exp.y (yylex): Update.
13088 * m2-exp.y (yylex): Update.
13089 * go-exp.y (lex_one_token): Update.
13090 * f-exp.y (yylex): Update.
13091 * d-exp.y (lex_one_token): Update.
13092 * c-exp.y (lex_one_token): Update.
13093 * ada-lex.l: Update.
13094
13095 2019-04-04 Tom Tromey <tom@tromey.com>
13096
13097 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
13098 (rustyylex, rust_lex_test_init, rust_lex_test_one)
13099 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
13100 * parser-defs.h (paren_depth): Don't declare.
13101 * parse.c (paren_depth): Remove global.
13102 (parse_exp_in_context): Update.
13103 * p-exp.y (paren_depth): New global.
13104 (pascal_parse): Initialize it.
13105 * m2-exp.y (paren_depth): New global.
13106 (m2_parse): Initialize it.
13107 * go-exp.y (paren_depth): New global.
13108 (go_parse): Initialize it.
13109 * f-exp.y (paren_depth): New global.
13110 (f_parse): Initialize it.
13111 * d-exp.y (paren_depth): New global.
13112 (d_parse): Initialize it.
13113 * c-exp.y (paren_depth): New global.
13114 (c_parse): Initialize it.
13115 * ada-lex.l (paren_depth): New global.
13116 (lexer_init): Initialize it.
13117
13118 2019-04-04 Tom Tromey <tom@tromey.com>
13119
13120 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
13121 (rust_parser::convert_ast_to_type)
13122 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
13123 * parser-defs.h (struct parser_state) <parser_state>: Add
13124 parameters. Initialize new members.
13125 <expression_context_block, expression_context_pc>: New members.
13126 * parse.c (expression_context_block, expression_context_pc):
13127 Remove globals.
13128 (parse_exp_in_context): Update.
13129 * p-exp.y: Update all rules.
13130 (yylex): Update.
13131 * m2-exp.y: Update all rules.
13132 (yylex): Update.
13133 * go-exp.y (yylex): Update.
13134 * f-exp.y (yylex): Update.
13135 * d-exp.y: Update all rules.
13136 (yylex): Update.
13137 * c-exp.y: Update all rules.
13138 (lex_one_token, classify_name, yylex, c_parse): Update.
13139 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
13140
13141 2019-04-04 Tom Tromey <tom@tromey.com>
13142
13143 * gdbarch.h, gdbarch.c: Rebuild.
13144 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
13145 * stap-probe.h:
13146 (struct stap_parse_info): Replace "parser_state" with
13147 "expr_builder".
13148 * parser-defs.h (struct expr_builder): Rename from "parser_state".
13149 (parser_state): New class.
13150 * parse.c (expr_builder): Rename.
13151 (expr_builder::release): Rename.
13152 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13153 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13154 (write_exp_elt_longcst, write_exp_elt_floatcst)
13155 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13156 (write_exp_string_vector, write_exp_bitstring)
13157 (write_exp_msymbol, mark_struct_expression)
13158 (write_dollar_variable)
13159 (insert_type_address_space, increase_expout_size): Replace
13160 "parser_state" with "expr_builder".
13161 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13162 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13163 "parser_state" with "expr_builder".
13164
13165 2019-04-04 Tom Tromey <tom@tromey.com>
13166
13167 * rust-exp.y: Replace "parse_language" with method call.
13168 * p-exp.y:
13169 (yylex): Replace "parse_language" with method call.
13170 * m2-exp.y:
13171 (yylex): Replace "parse_language" with method call.
13172 * go-exp.y (classify_name): Replace "parse_language" with method
13173 call.
13174 * f-exp.y (yylex): Replace "parse_language" with method call.
13175 * d-exp.y (lex_one_token): Replace "parse_language" with method
13176 call.
13177 * c-exp.y:
13178 (lex_one_token, classify_name, yylex): Replace "parse_language"
13179 with method call.
13180 * ada-exp.y (find_primitive_type, type_char)
13181 (type_system_address): Replace "parse_language" with method call.
13182
13183 2019-04-04 Tom Tromey <tom@tromey.com>
13184
13185 * rust-exp.y: Replace "parse_gdbarch" with method call.
13186 * parse.c (write_dollar_variable, insert_type_address_space):
13187 Replace "parse_gdbarch" with method call.
13188 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13189 call.
13190 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13191 call.
13192 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13193 "parse_gdbarch" with method call.
13194 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13195 with method call.
13196 * f-exp.y (parse_type, parse_f_type, yylex): Replace
13197 "parse_gdbarch" with method call.
13198 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13199 "parse_gdbarch" with method call.
13200 * c-exp.y (parse_type, parse_number, classify_name): Replace
13201 "parse_gdbarch" with method call.
13202 * ada-lex.l: Replace "parse_gdbarch" with method call.
13203 * ada-exp.y (parse_type, find_primitive_type, type_char)
13204 (type_system_address): Replace "parse_gdbarch" with method call.
13205
13206 2019-04-04 Tom Tromey <tom@tromey.com>
13207
13208 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13209 * stap-probe.c (stap_parse_argument): Update.
13210 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13211 initial_size parameter.
13212 * rust-exp.y (rust_lex_tests): Update.
13213 * parse.c (parser_state): Update.
13214 (parse_exp_in_context): Update.
13215 * parser-defs.h (struct parser_state) <parser_state>: Remove
13216 "initial_size" parameter.
13217
13218 2019-04-04 Tom Tromey <tom@tromey.com>
13219
13220 * parser-defs.h (increase_expout_size): Don't declare.
13221 * parse.c (increase_expout_size): Now static.
13222
13223 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
13224
13225 * gnu-nat.c (gnu_nat_target::wait): Fix
13226 target_waitstatus_to_string call.
13227
13228 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13229
13230 * eval.c (evaluate_subexp_standard): Handle internal functions
13231 during Fortran function call handling.
13232
13233 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
13234
13235 * NEWS: Mention new internal functions.
13236 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13237 (read_base_type): Use dwarf2_init_complex_target_type.
13238 * value.c (creal_internal_fn): New function.
13239 (cimag_internal_fn): New function.
13240 (_initialize_values): Register new internal functions.
13241
13242 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13243
13244 * infrun.c (stop_all_threads): If debug_infrun, always
13245 trace the wait status after wait_one, using
13246 target_waitstatus_to_string and target_pid_to_str.
13247 (handle_inferior_event): Replace various trace of
13248 wait status kind by a single trace.
13249 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13250 wait status kind image by target_waitstatus_to_string.
13251 * target/waitstatus.c (target_waitstatus_to_string): Fix
13252 obsolete comment.
13253
13254 2019-04-01 Tom Tromey <tromey@adacore.com>
13255
13256 PR symtab/23331:
13257 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13258
13259 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
13260 Pedro Alves <palves@redhat.com>
13261
13262 * top.c (quit_force): Call 'finalize_values'.
13263 * value.c (finalize_values): New function.
13264 * value.h (finalize_values): Declare.
13265
13266 2019-03-30 Eli Zaretskii <eliz@gnu.org>
13267
13268 * NEWS: Announce $_gdb_major and $_gdb_minor.
13269
13270 * top.c (init_gdb_version_vars): New function.
13271 (gdb_init): Call init_gdb_version_vars.
13272
13273 2019-03-29 Tom Tromey <tromey@adacore.com>
13274
13275 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
13276 help text. Remove dead code.
13277
13278 2019-03-29 Keith Seitz <keiths@redhat.com>
13279
13280 From Siddhesh Poyarekar:
13281 * f-lang.h (f77_get_upperbound): Return LONGEST.
13282 (f77_get_lowerbound): Likewise.
13283 * f-typeprint.c (f_type_print_varspec_suffix): Expand
13284 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
13285 print them.
13286 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
13287 plongest to format print it.
13288 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13289 (f77_get_upperbound): Likewise.
13290 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13291 LOWER_BOUND to LONGEST.
13292 (f77_create_arrayprint_offset_tbl): Likewise.
13293
13294 2019-03-29 Keith Seitz <keiths@redhat.com>
13295
13296 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13297 %s/pulongest for TYPE_LENGTH instead of %d in format
13298 strings.
13299 * ada-typerint.c (ada_print_type): Likewise.
13300 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13301 * compile/compile-c-support.c (generate_register_struct): Likewise.
13302 * gdbtypes.c (recursive_dump_type): Likewise.
13303 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13304 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
13305 instead of %d in format strings.
13306 * riscv-tdep.c (riscv_type_alignment): Cast second argument
13307 to std::min to ULONGEST.
13308 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13309 instead of %d in format strings.
13310 * tracepoint.c (info_scope_command): Likewise.
13311 * typeprint.c (print_offset_data::update)
13312 (print_offset_data::finish): Likewise.
13313 * xtensa-tdep.c (xtensa_store_return_value)
13314 (xtensa_push_dummy_call): Likewise.
13315
13316 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
13317
13318 * windows-nat.c (display_selector): Fixed format specifications
13319 for 64-bit Cygwin.
13320
13321 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13322
13323 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13324
13325 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
13326
13327 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13328 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13329 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13330 (nios2_linux_init_abi): Install it.
13331
13332 2019-03-28 Alan Hayward <alan.hayward@arm.com>
13333
13334 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13335
13336 2019-03-28 Alan Hayward <alan.hayward@arm.com>
13337
13338 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13339
13340 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13341 Tom Tromey <tromey@adacore.com>
13342
13343 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13344
13345 2019-03-26 Joel Brobecker <brobecker@adacore.com>
13346
13347 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13348 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13349 method to compute the bounds of range types. Also print "[evaluated]"
13350 if the bounds' values come from a dynamic evaluation.
13351
13352 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
13353
13354 * cp-valprint.c (cp_print_value_fields): Don't print trailing
13355 whitespace when pretty printing is on.
13356
13357 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13358
13359 * ppc-linux-nat.c: Add include.
13360
13361 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13362
13363 * NEWS: Mention AArch64 Pointer Authentication.
13364
13365 2019-03-26 Alan Hayward <alan.hayward@arm.com>
13366
13367 * arm-linux-nat.c: Add include.
13368
13369 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
13370
13371 * source-cache.c (source_cache::get_source_lines): Re-read
13372 fullname after calling open_source_file.
13373
13374 2019-03-25 John Baldwin <jhb@FreeBSD.org>
13375
13376 * NEWS: Mention TLS support for FreeBSD.
13377
13378 2019-03-25 Tom Tromey <tromey@adacore.com>
13379
13380 * minsyms.c (BUNCH_SIZE): Update comment.
13381 (~minimal_symbol_reader): Remove old comment.
13382 (compact_minimal_symbols): Update comment.
13383 (minimal_symbol_reader::install): Remove old comment. Update
13384 other comments.
13385
13386 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13387
13388 * s390-linux-nat.c: Add include.
13389
13390 2019-03-25 Alan Hayward <alan.hayward@arm.com>
13391
13392 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13393 Call linux_get_hwcap.
13394 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13395 Likewise.
13396 (aarch64_linux_get_hwcap): Remove function.
13397 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13398 declaration.
13399 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13400 linux_get_hwcap.
13401 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13402 * linux-tdep.c (linux_get_hwcap): Add function.
13403 (linux_get_hwcap2): Likewise.
13404 * linux-tdep.h (linux_get_hwcap): Add declaration.
13405 (linux_get_hwcap2): Likewise.
13406 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13407 (ppc_linux_get_hwcap2): Likewise.
13408 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13409 linux_get_hwcap.
13410 (ppc_linux_nat_target::insert_watchpoint): Likewise.
13411 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13412 (ppc_linux_nat_target::read_description): Likewise.
13413 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13414 * s390-linux-nat.c: Likewise.
13415 * s390-linux-tdep.c (s390_core_read_description): Likewise.
13416
13417 2019-03-24 Tom Tromey <tom@tromey.com>
13418
13419 * ada-lang.c (standard_lookup): Simplify initialization.
13420 (ada_lookup_symbol_nonlocal): Simplify return.
13421 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13422 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13423 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13424 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13425 initialization.
13426 * solib.c (solib_global_lookup): Simplify.
13427 * symtab.c (null_block_symbol): Remove.
13428 (symbol_cache_lookup): Simplify returns.
13429 (lookup_language_this): Simplify returns.
13430 (lookup_symbol_aux): Simplify return.
13431 (lookup_local_symbol): Simplify returns.
13432 (lookup_global_symbol_from_objfile): Simplify return.
13433 (lookup_symbol_in_objfile_symtabs)
13434 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13435 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13436 (lookup_static_symbol, lookup_global_symbol): Simplify return.
13437 * cp-namespace.c (cp_lookup_bare_symbol)
13438 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13439 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13440 (cp_lookup_nested_symbol): Don't use null_block_symbol.
13441 (cp_lookup_symbol_via_imports): Simplify initialization.
13442 (find_symbol_in_baseclass): Likewise.
13443 * symtab.h (null_block_symbol): Remove.
13444 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13445 (d_lookup_nested_symbol, d_lookup_symbol_imports)
13446 (d_lookup_symbol_module): Likewise.
13447 (find_symbol_in_baseclass): Simplify initialization.
13448
13449 2019-03-24 Tom Tromey <tom@tromey.com>
13450
13451 * expression.h: Don't include symtab.h.
13452 (struct block): Forward declare.
13453
13454 2019-03-24 Tom Tromey <tom@tromey.com>
13455
13456 * c-exp.y (typebase): Remove casts.
13457 * gdbtypes.c (lookup_unsigned_typename, )
13458 (lookup_signed_typename): Remove cast.
13459 * eval.c (parse_to_comma_and_eval): Remove cast.
13460 * parse.c (write_dollar_variable): Remove cast.
13461 * block.h (struct block) <superblock>: Now const.
13462 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13463 * psymtab.c (psym_map_matching_symbols): Make "block" const.
13464 (map_block): Make "block" const.
13465 * symfile.h (struct quick_symbol_functions)
13466 <map_matching_symbols>: Constify block argument to "callback".
13467 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13468 const.
13469 (find_pc_sect_compunit_symtab): Make "b" const.
13470 (find_symbol_at_address): Likewise.
13471 (search_symbols): Likewise.
13472 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13473 (dw2_debug_names_lookup_symbol): Likewise.
13474 (dw2_map_matching_symbols): Update.
13475 * p-valprint.c (pascal_val_print): Remove "block".
13476 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13477 (aux_add_nonlocal_symbols): Make "block" const.
13478 (resolve_subexp): Remove cast.
13479 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13480 const.
13481 (iterate_over_file_blocks): Likewise.
13482 * f-exp.y (%union) <bval>: Remove.
13483 * coffread.c (patch_opaque_types): Make "b" const.
13484 * spu-tdep.c (spu_catch_start): Make "block" const.
13485 * c-valprint.c (print_unpacked_pointer): Remove "block".
13486 * symmisc.c (dump_symtab_1): Make "b" const.
13487 (block_depth): Make "block" const.
13488 * d-exp.y (%union) <bval>: Remove.
13489 * cp-support.h (cp_lookup_rtti_type): Update.
13490 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13491 * psymtab.c (psym_lookup_symbol): Make "block" const.
13492 (maintenance_check_psymtabs): Make "b" const.
13493 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13494 (enumerate_locals, enumerate_args): Update.
13495 * python/py-symtab.c (stpy_global_block): Make "block" const.
13496 (stpy_static_block): Likewise.
13497 * inline-frame.c (block_starting_point_at): Make "new_block"
13498 const.
13499 * block.c (find_block_in_blockvector): Make return type const.
13500 (blockvector_for_pc_sect): Make "b" const.
13501 (find_block_in_blockvector): Make "b" const.
13502
13503 2019-03-23 Tom Tromey <tom@tromey.com>
13504
13505 * varobj.c (varobj_create): Update.
13506 * symfile.c (clear_symtab_users): Don't reset innermost_block.
13507 * printcmd.c (display_command, do_one_display): Don't reset
13508 innermost_block.
13509 * parser-defs.h (enum innermost_block_tracker_type): Move to
13510 expression.h.
13511 (innermost_block): Update comment.
13512 * parse.c (parse_exp_1): Add tracker_types parameter.
13513 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
13514 tracker_types parameter. Reset innermost_block.
13515 (parse_exp_in_context): Remove.
13516 (parse_expression_for_completion): Update.
13517 * objfiles.c (~objfile): Don't reset expression_context_block or
13518 innermost_block.
13519 * expression.h (enum innermost_block_tracker_type): Move from
13520 parser-defs.h.
13521 (parse_exp_1): Add tracker_types parameter.
13522 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13523 reset innermost_block.
13524
13525 2019-03-23 Tom Tromey <tom@tromey.com>
13526
13527 * objfiles.h: Include bcache.h.
13528
13529 2019-03-23 Tom Tromey <tom@tromey.com>
13530
13531 * linespec.c (get_current_search_block): Use
13532 scoped_restore_current_language.
13533 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13534
13535 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13536 Jiong Wang <jiong.wang@arm.com>
13537
13538 * aarch64-linux-tdep.c
13539 (aarch64_linux_iterate_over_regset_sections): Check for pauth
13540 section.
13541 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13542
13543 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13544 Jiong Wang <jiong.wang@arm.com>
13545
13546 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13547 instructions.
13548 (aarch64_analyze_prologue_test): Add PACIASP test.
13549 (aarch64_prologue_prev_register): Unmask PC value.
13550
13551 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13552 Jiong Wang <jiong.wang@arm.com>
13553
13554 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13555 (aarch64_dwarf2_prev_register): Unmask PC value.
13556 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13557 (aarch64_execute_dwarf_cfa_vendor_op): Check for
13558 DW_CFA_AARCH64_negate_ra_state.
13559 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13560
13561 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13562 Jiong Wang <jiong.wang@arm.com>
13563
13564 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13565 registers.
13566 (aarch64_pseudo_register_name): Likewise.
13567 (aarch64_pseudo_register_type): Likewise.
13568 (aarch64_pseudo_register_reggroup_p): Likewise.
13569 (aarch64_gdbarch_init): Add pauth registers.
13570 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13571 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13572 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13573 (struct gdbarch_tdep): Add regnum for ra_state.
13574
13575 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13576 Jiong Wang <jiong.wang@arm.com>
13577
13578 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13579
13580 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13581 Jiong Wang <jiong.wang@arm.com>
13582
13583 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13584 function.
13585 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13586 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13587 (aarch64_gdbarch_init): Add puth registers.
13588 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13589 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13590 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13591
13592 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13593 Jiong Wang <jiong.wang@arm.com>
13594
13595 * aarch64-linux-nat.c
13596 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13597 * aarch64-linux-tdep.c
13598 (aarch64_linux_core_read_description): Likewise.
13599 (aarch64_linux_get_hwcap): New function.
13600 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13601 (aarch64_linux_get_hwcap): New declaration.
13602
13603 2019-03-22 Alan Hayward <alan.hayward@arm.com>
13604 Jiong Wang <jiong.wang@arm.com>
13605
13606 * aarch64-linux-nat.c
13607 (aarch64_linux_nat_target::read_description): Add pauth param.
13608 * aarch64-linux-tdep.c
13609 (aarch64_linux_core_read_description): Likewise.
13610 * aarch64-tdep.c (struct target_desc): Add in pauth.
13611 (aarch64_read_description): Add pauth param.
13612 (aarch64_gdbarch_init): Likewise.
13613 * aarch64-tdep.h (aarch64_read_description): Likewise.
13614 * arch/aarch64.c (aarch64_create_target_description): Likewise.
13615 * arch/aarch64.h (aarch64_create_target_description): Likewise.
13616 * features/Makefile: Add new files.
13617 * features/aarch64-pauth.c: New file.
13618 * features/aarch64-pauth.xml: New file.
13619
13620 2019-03-20 Tom Tromey <tromey@adacore.com>
13621
13622 * infrun.c (handle_inferior_event): Rename from
13623 handle_inferior_event_1. Create a scoped_value_mark.
13624 (handle_inferior_event): Remove.
13625
13626 2019-03-19 Tom Tromey <tromey@adacore.com>
13627
13628 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13629 * infrun.h (print_stop_event): Add "displays" parameter.
13630 * infrun.c (print_stop_event): Add "displays" parameter.
13631
13632 2019-03-19 Pedro Alves <palves@redhat.com>
13633
13634 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13635 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
13636 to -1. Fix TABs vs spaces.
13637 (tui_ui_out::tui_ui_out): Don't initialize fields here.
13638 * tui/tui-out.h (tui_ui_out) Add intro comments.
13639 <m_line, m_start_of_line>: In-class initialize, and add describing
13640 comment.
13641
13642 2019-03-18 Alan Hayward <alan.hayward@arm.com>
13643
13644 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13645 variable names.
13646 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13647
13648 2019-03-18 Pedro Alves <palves@redhat.com>
13649 Eli Zaretskii <eliz@gnu.org>
13650
13651 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13652 m_line and m_start_of_line.
13653
13654 2019-03-18 Eli Zaretskii <eliz@gnu.org>
13655
13656 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13657 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13658 it returns a newline. This fixes a regression in TU mode, whereby
13659 the next line is output on the same screen line as the user input.
13660
13661 2019-03-18 Tom Tromey <tromey@adacore.com>
13662
13663 * minsyms.c (minimal_symbol_reader::install): Remove call to
13664 obstack_blank.
13665
13666 2019-03-18 Pedro Alves <palves@redhat.com>
13667
13668 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13669 New globals.
13670 (apply_style): New, factored out from ...
13671 (apply_ansi_escape): ... this. Handle reverse video mode.
13672 (tui_set_reverse_mode): New function.
13673 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13674 * tui/tui-winsource.c (tui_show_source_line): Use
13675 tui_set_reverse_mode instead of setting A_STANDOUT.
13676 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13677 New setter methods.
13678
13679 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
13680
13681 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13682 Handle tabs.
13683
13684 2019-03-18 Tom Tromey <tromey@adacore.com>
13685
13686 * ada-lang.c (empty_array): Add "high" parameter.
13687 (ada_evaluate_subexp): Update.
13688
13689 2019-03-17 Sergei Trofimovich <siarheit@google.com>
13690
13691 * unittests/string_view-selftests.c: Define
13692 _initialize_string_view_selftests unconditionally.
13693
13694 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13695
13696 PR gdb/24350
13697 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13698
13699 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
13700
13701 PR gdb/24351
13702 * windows-nat.c (display_selector): Fix format specifiers.
13703
13704 2019-03-17 Eli Zaretskii <eliz@gnu.org>
13705
13706 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13707 tui_refill_source_window instead of tui_refresh_win, to update the
13708 current execution line. This fixes redisplay of the current line
13709 when stepping through the code with "next" or "step".
13710
13711 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13712
13713 * source-cache.c (source_cache::get_source_lines): Call
13714 find_source_lines to initialize s->nlines. This fixes vertical
13715 scrolling of TUI source window when the DOWN arrow is pressed.
13716
13717 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13718
13719 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13720 linux-thread-db.c (_initialize_thread_db): Likewise.
13721
13722 2019-03-16 Eli Zaretskii <eliz@gnu.org>
13723
13724 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13725 wclrtoeol in tui_show_source_line". This reverts changes made in
13726 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13727
13728 2019-03-15 Tom Tromey <tom@tromey.com>
13729
13730 * symtab.h (struct minimal_symbol): Derive from
13731 general_symbol_info.
13732 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13733 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13734 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13735 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13736 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13737 (MSYMBOL_SEARCH_NAME): Update.
13738 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13739 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13740 * minsyms.c (minimal_symbol_reader::record_full): Update.
13741
13742 2019-03-15 Tom Tromey <tom@tromey.com>
13743
13744 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13745
13746 2019-03-15 Tom Tromey <tom@tromey.com>
13747
13748 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13749 unique_xmalloc_ptr.
13750 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13751 Update.
13752 * minsyms.c (lookup_minimal_symbol_by_pc_section)
13753 (build_minimal_symbol_hash_tables)
13754 (minimal_symbol_reader::install): Update.
13755
13756 2019-03-15 Tom Tromey <tom@tromey.com>
13757
13758 * symtab.c (create_demangled_names_hash): Update.
13759 (symbol_set_names): Update.
13760 * objfiles.h (struct objfile_per_bfd_storage)
13761 <demangled_names_hash>: Now an htab_up.
13762 * objfiles.c (objfile_per_bfd_storage): Simplify.
13763
13764 2019-03-15 Tom Tromey <tom@tromey.com>
13765
13766 * objfiles.h (struct objfile_per_bfd_storage): Declare
13767 destructor.
13768 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13769 New.
13770 (get_objfile_bfd_data): Use new. Don't initialize
13771 language_of_main.
13772 (free_objfile_per_bfd_storage): Remove.
13773 (objfile_bfd_data_free, objfile::~objfile): Use delete.
13774
13775 2019-03-15 Tom Tromey <tom@tromey.com>
13776
13777 * symfile.c (reread_symbols): Update.
13778 * objfiles.c (objfile::objfile): Update.
13779 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13780 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13781 comment.
13782 (minimal_symbol_reader::install): Update.
13783 (terminate_minimal_symbol_table): Remove.
13784 * jit.c (jit_object_close_impl): Update.
13785
13786 2019-03-15 Tom Tromey <tom@tromey.com>
13787
13788 * minsyms.c (minimal_symbol_reader::record_full): Remove some
13789 initializations.
13790
13791 2019-03-15 Tom Tromey <tom@tromey.com>
13792
13793 * objfiles.h (struct objfile_per_bfd_storage)
13794 <demangled_hash_languages>: Now a bitset.
13795 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13796 (lookup_minimal_symbol): Update.
13797
13798 2019-03-15 Tom Tromey <tom@tromey.com>
13799
13800 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13801 Don't return the symbol.
13802 * coffread.c (record_minimal_symbol): Use record_full.
13803
13804 2019-03-14 Eli Zaretskii <eliz@gnu.org>
13805
13806 The MS-Windows port of ncurses fails to switch to a color pair if
13807 one or both of the colors are the implicit default colors. This
13808 change records the default colors when TUI is initialized, and
13809 then specifies them explicitly when a color pair uses the default
13810 colors. This allows color styling in TUI mode on MS-Windows.
13811
13812 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
13813 ncurses_norm_attr.
13814 (tui_initialize_io) [__MINGW32__]: Record the default terminal
13815 colors in ncurses_norm_attr.
13816 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13817 "none", replace it with the default color recorded in
13818 ncurses_norm_attr.
13819
13820 2019-03-14 Tom Tromey <tromey@adacore.com>
13821
13822 * source-cache.h (class source_cache) <get_source_lines>: Return
13823 std::string.
13824 * source-cache.c (source_cache::extract_lines): Handle case where
13825 first_pos==npos. Return std::string.
13826 (source_cache::get_source_lines): Update.
13827
13828 2019-03-14 Tom Tromey <tromey@adacore.com>
13829
13830 * NEWS: Add item for "style sources" commands.
13831 * source-cache.c (source_cache::get_source_lines): Check
13832 source_styling.
13833 * cli/cli-style.c (source_styling): New global.
13834 (_initialize_cli_style): Add "style sources" commands.
13835 (show_style_sources): New function.
13836 * cli/cli-style.h (source_styling): Declare.
13837
13838 2019-03-14 Pedro Alves <palves@redhat.com>
13839 Tom Tromey <tromey@adacore.com>
13840
13841 * tui/tui-winsource.h (tui_refill_source_window): Declare.
13842 * tui/tui-winsource.c (tui_refill_source_window): New function,
13843 from...
13844 (tui_horizontal_source_scroll): ... here. Move some logic.
13845 * cli/cli-style.c (set_style_enabled): Notify new observable.
13846 * tui/tui-hooks.c (tui_redisplay_source): New function.
13847 (tui_attach_detach_observers): Attach or detach
13848 tui_redisplay_source.
13849 * observable.h (source_styling_changed): New observable.
13850 * observable.c: Define source_styling_changed observable.
13851
13852 2019-03-13 Tom Tromey <tromey@adacore.com>
13853
13854 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13855 (i386_gnu_nat_target::store_registers): Update.
13856 * target-debug.h (target_debug_print_std_string): New macro.
13857 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13858 * windows-tdep.c (display_one_tib): Update.
13859 * tui/tui-stack.c (tui_make_status_line): Update.
13860 * top.c (print_inferior_quit_action): Update.
13861 * thread.c (thr_try_catch_cmd): Update.
13862 (add_thread_with_info): Update.
13863 (thread_target_id_str): Update.
13864 (thr_try_catch_cmd): Update.
13865 (thread_command): Update.
13866 (thread_find_command): Update.
13867 * record-btrace.c (record_btrace_target::info_record)
13868 (record_btrace_resume_thread, record_btrace_target::resume)
13869 (record_btrace_cancel_resume, record_btrace_step_thread)
13870 (record_btrace_target::wait, record_btrace_target::wait)
13871 (record_btrace_target::wait, record_btrace_target::stop): Update.
13872 * progspace.c (print_program_space): Update.
13873 * process-stratum-target.c
13874 (process_stratum_target::thread_address_space): Update.
13875 * linux-fork.c (linux_fork_mourn_inferior)
13876 (detach_checkpoint_command, info_checkpoints_command)
13877 (linux_fork_context): Update.
13878 (linux_fork_detach): Update.
13879 (class scoped_switch_fork_info): Update.
13880 (delete_checkpoint_command): Update.
13881 * infrun.c (follow_fork_inferior): Update.
13882 (follow_fork_inferior): Update.
13883 (proceed_after_vfork_done): Update.
13884 (handle_vfork_child_exec_or_exit): Update.
13885 (follow_exec): Update.
13886 (displaced_step_prepare_throw): Update.
13887 (displaced_step_restore): Update.
13888 (start_step_over): Update.
13889 (resume_1): Update.
13890 (clear_proceed_status_thread): Update.
13891 (proceed): Update.
13892 (print_target_wait_results): Update.
13893 (do_target_wait): Update.
13894 (context_switch): Update.
13895 (stop_all_threads): Update.
13896 (restart_threads): Update.
13897 (finish_step_over): Update.
13898 (handle_signal_stop): Update.
13899 (switch_back_to_stepped_thread): Update.
13900 (keep_going_pass_signal): Update.
13901 (print_exited_reason): Update.
13902 (normal_stop): Update.
13903 * inferior.c (inferior_pid_to_str): Change return type.
13904 (print_selected_inferior): Update.
13905 (add_inferior): Update.
13906 (detach_inferior): Update.
13907 * dummy-frame.c (fprint_dummy_frames): Update.
13908 * dcache.c (dcache_info_1): Update.
13909 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13910 (btrace_fetch, btrace_clear): Update.
13911 * linux-tdep.c (linux_core_pid_to_str): Change return type.
13912 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13913 type.
13914 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13915 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13916 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13917 * gdbarch.c, gdbarch.h: Rebuild.
13918 * gdbarch.sh (core_pid_to_str): Change return type.
13919 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13920 return type.
13921 (windows_nat_target::pid_to_str): Change return type.
13922 (windows_delete_thread): Update.
13923 (windows_nat_target::attach): Update.
13924 (windows_nat_target::files_info): Update.
13925 * target-delegates.c: Rebuild.
13926 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13927 return type.
13928 (sol_thread_target::pid_to_str): Change return type.
13929 * remote.c (class remote_target) <pid_to_str>: Change return
13930 type.
13931 (remote_target::pid_to_str): Change return type.
13932 (extended_remote_target::attach, remote_target::remote_stop_ns)
13933 (remote_target::remote_notif_remove_queued_reply)
13934 (remote_target::push_stop_reply, remote_target::disable_btrace):
13935 Update.
13936 (extended_remote_target::attach): Update.
13937 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13938 type.
13939 (gdbsim_target::pid_to_str): Change return type.
13940 * ravenscar-thread.c (struct ravenscar_thread_target)
13941 <pid_to_str>: Change return type.
13942 (ravenscar_thread_target::pid_to_str): Change return type.
13943 * procfs.c (class procfs_target) <pid_to_str>: Change return
13944 type.
13945 (procfs_target::pid_to_str): Change return type.
13946 (procfs_target::attach): Update.
13947 (procfs_target::detach): Update.
13948 (procfs_target::fetch_registers): Update.
13949 (procfs_target::store_registers): Update.
13950 (procfs_target::wait): Update.
13951 (procfs_target::files_info): Update.
13952 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13953 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13954 return type.
13955 (nto_procfs_target::pid_to_str): Change return type.
13956 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13957 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13958 return type.
13959 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13960 (exit_lwp): Update.
13961 (attach_proc_task_lwp_callback, get_detach_signal)
13962 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13963 (linux_nat_target::resume, wait_lwp, stop_callback)
13964 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13965 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13966 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13967 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13968 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13969 type.
13970 (inf_ptrace_target::attach): Update.
13971 (inf_ptrace_target::files_info): Update.
13972 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13973 type.
13974 (go32_nat_target::pid_to_str): Change return type.
13975 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13976 (gnu_nat_target::wait): Update.
13977 (gnu_nat_target::wait): Update.
13978 (gnu_nat_target::resume): Update.
13979 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13980 (fbsd_nat_target::wait): Update.
13981 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13982 type.
13983 (darwin_nat_target::attach): Update.
13984 * corelow.c (class core_target) <pid_to_str>: Change return type.
13985 (core_target::pid_to_str): Change return type.
13986 * target.c (normal_pid_to_str): Change return type.
13987 (default_pid_to_str): Likewise.
13988 (target_pid_to_str): Change return type.
13989 (target_translate_tls_address): Update.
13990 (target_announce_detach): Update.
13991 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13992 return type.
13993 (bsd_uthread_target::pid_to_str): Change return type.
13994 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13995 type.
13996 (bsd_kvm_target::pid_to_str): Change return type.
13997 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13998 return type.
13999 (aix_thread_target::pid_to_str): Change return type.
14000 * target.h (struct target_ops) <pid_to_str>: Change return type.
14001 (target_pid_to_str, normal_pid_to_str): Likewise.
14002 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
14003 type.
14004 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
14005 type.
14006 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
14007 return type.
14008 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
14009 type.
14010 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
14011 type.
14012 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
14013 return type.
14014
14015 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
14016
14017 * NEWS: Mention that the new default MI version is 3. Mention
14018 changes to the output of commands and events that deal with
14019 multi-location breakpoints.
14020 * breakpoint.c: Include "mi/mi-out.h".
14021 (print_one_breakpoint): Change output syntax if using MI version
14022 >= 3.
14023 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
14024 New.
14025 (mi_multi_location_breakpoint_output_fixed): New.
14026 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
14027 (mi_cmd_fix_multi_location_breakpoint_output): New.
14028 (mi_multi_location_breakpoint_output_fixed): New.
14029 * mi/mi-cmds.c (mi_cmds): Register command
14030 -fix-multi-location-breakpoint-output.
14031 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
14032 interpreter "mi".
14033
14034 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
14035
14036 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
14037 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
14038 instantiate mi_ui_out based on interpreter name.
14039 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
14040 * mi/mi-main.c (mi_load_progress): Likewise.
14041
14042 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14043
14044 * NEWS: Combine separate "New targets" sections for 8.3.
14045
14046 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14047
14048 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
14049 (ppcfbsd_init_abi): Install gdbarch
14050 "fetch_tls_load_module_address" and "get_thread_local_address"
14051 methods.
14052
14053 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14054
14055 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
14056 (riscv_fbsd_init_abi): Install gdbarch
14057 "fetch_tls_load_module_address" and "get_thread_local_address"
14058 methods.
14059
14060 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14061
14062 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
14063 (i386fbsd_init_abi): Install gdbarch
14064 "fetch_tls_load_module_address" and "get_thread_local_address"
14065 methods.
14066
14067 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14068
14069 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
14070 (amd64fbsd_init_abi): Install gdbarch
14071 "fetch_tls_load_module_address" and "get_thread_local_address"
14072 methods.
14073
14074 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14075
14076 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
14077 (struct fbsd_pspace_data): New type.
14078 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
14079 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
14080 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
14081 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
14082 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
14083
14084 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14085
14086 * gdbtypes.c (lookup_struct_elt): New function.
14087 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
14088 * gdbtypes.h (struct struct_elt): New type.
14089 (lookup_struct_elt): New prototype.
14090
14091 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14092
14093 * gdbtypes.c (lookup_struct_elt_type): Update comment and
14094 remove disabled code block.
14095
14096 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14097
14098 * gdbarch.sh (get_thread_local_address): New method.
14099 * gdbarch.h, gdbarch.c: Regenerate.
14100 * target.c (target_translate_tls_address): Use
14101 gdbarch_get_thread_local_address if present instead of
14102 target::get_thread_local_address.
14103
14104 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14105
14106 * target.h (target::get_thread_local_address): Update comment.
14107
14108 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14109
14110 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
14111 objfile->separate_debug_objfile_backlink if not NULL.
14112
14113 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14114
14115 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
14116 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
14117 (amd64bsd_store_inferior_registers): Likewise.
14118 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14119 Enable segment base registers.
14120 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
14121 PT_GETFSBASE and PT_GETGSBASE.
14122 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
14123 PT_SETGSBASE.
14124 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
14125 segment base registers.
14126 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14127
14128 2019-03-12 John Baldwin <jhb@FreeBSD.org>
14129
14130 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
14131 Update calls to i386_target_description to add 'segments'
14132 parameter.
14133 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
14134 add segment base registers.
14135 * arch/i386.c (i386_create_target_description): Add 'segments'
14136 parameter to enable segment base registers.
14137 * arch/i386.h (i386_create_target_description): Likewise.
14138 * features/i386/32bit-segments.xml: New file.
14139 * features/i386/32bit-segments.c: Generate.
14140 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
14141 call to i386_target_description to add 'segments' parameter.
14142 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
14143 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
14144 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
14145 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
14146 if feature is present.
14147 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
14148 Add 'segments' parameter to call to i386_target_description.
14149 (i386_target_description): Add 'segments' parameter to enable
14150 segment base registers.
14151 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14152 to call to i386_target_description.
14153 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14154 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14155 Define I386_NUM_REGS.
14156 (i386_target_description): Add 'segments' parameter to enable
14157 segment base registers.
14158
14159 2019-03-12 Eli Zaretskii <eliz@gnu.org>
14160
14161 PR/24325
14162 * source-cache.c: #undef open and close, to avoid unresolved
14163 externals during linking.
14164
14165 2019-03-12 Tom Tromey <tromey@adacore.com>
14166
14167 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14168 const. Add initializers.
14169 (_initialize_remote): Don't initialize ptid globals.
14170
14171 2019-03-12 Pedro Alves <palves@redhat.com>
14172
14173 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14174
14175 2019-03-12 Pedro Alves <palves@redhat.com>
14176
14177 * cp-name-parser.y (main): Remove unused 'len' variable.
14178
14179 2019-03-12 Tom Tromey <tromey@adacore.com>
14180
14181 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14182 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14183
14184 2019-03-12 Tom Tromey <tromey@adacore.com>
14185
14186 * linux-nat.c (iterate_over_lwps): Update.
14187 (stop_callback): Remove parameter.
14188 (stop_wait_callback, detach_callback, resume_set_callback)
14189 (select_singlestep_lwp_callback, set_ignore_sigint)
14190 (status_callback, resumed_callback, resume_clear_callback)
14191 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14192 data parameter.
14193 (linux_nat_target::detach, linux_nat_target::resume)
14194 (linux_stop_and_wait_all_lwps, select_event_lwp)
14195 (linux_nat_filter_event, linux_nat_wait_1)
14196 (linux_nat_target::kill, linux_nat_target::stop)
14197 (linux_nat_target::stop): Update.
14198 (linux_nat_resume_callback): Change type.
14199 (resume_stopped_resumed_lwps, count_events_callback)
14200 (select_event_lwp_callback): Likewise.
14201 (linux_stop_lwp, linux_nat_stop_lwp): Update.
14202 * arm-linux-nat.c (struct update_registers_data): Remove.
14203 (update_registers_callback): Change type.
14204 (arm_linux_insert_hw_breakpoint1): Update.
14205 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14206 parameter.
14207 (x86_linux_dr_set_addr): Update.
14208 (x86_linux_dr_set_control): Update.
14209 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14210 (iterate_over_lwps): Use gdb::function_view.
14211 * nat/aarch64-linux-hw-point.c (struct
14212 aarch64_dr_update_callback_param): Remove.
14213 (debug_reg_change_callback): Change type.
14214 (aarch64_notify_debug_reg_change): Update.
14215 * s390-linux-nat.c (s390_refresh_per_info): Update.
14216
14217 2019-03-11 Tom Tromey <tromey@adacore.com>
14218
14219 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14220 redundant assignment to "this_cu".
14221
14222 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14223
14224 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14225
14226 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14227
14228 * gdbtypes.c (rank_one_type_parm_set): New function extracted
14229 from...
14230 (rank_one_type): ... this.
14231
14232 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14233
14234 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14235 from...
14236 (rank_one_type): ... this.
14237
14238 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14239
14240 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14241 from...
14242 (rank_one_type): ... this.
14243
14244 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14245
14246 * gdbtypes.c (rank_one_type_parm_float): New function extracted
14247 from...
14248 (rank_one_type): ... this.
14249
14250 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14251
14252 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14253 from...
14254 (rank_one_type): ... this.
14255
14256 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14257
14258 * gdbtypes.c (rank_one_type_parm_range): New function extracted
14259 from...
14260 (rank_one_type): ... this.
14261
14262 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14263
14264 * gdbtypes.c (rank_one_type_parm_char): New function extracted
14265 from...
14266 (rank_one_type): ... this.
14267
14268 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14269
14270 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14271 from...
14272 (rank_one_type): ... this.
14273
14274 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14275
14276 * gdbtypes.c (rank_one_type_parm_int): New function extracted
14277 from...
14278 (rank_one_type): ... this.
14279
14280 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14281
14282 * gdbtypes.c (rank_one_type_parm_func): New function extracted
14283 from...
14284 (rank_one_type): ... this.
14285
14286 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14287
14288 * gdbtypes.c (rank_one_type_parm_array): New function extracted
14289 from...
14290 (rank_one_type): ... this.
14291
14292 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
14293
14294 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14295 from...
14296 (rank_one_type): ... this.
14297
14298 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14299
14300 * inferior.c (initialize_inferiors): Ensure 'help set/show print
14301 inferior-events' shows the example events.
14302
14303 2019-03-08 Eli Zaretskii <eliz@gnu.org>
14304
14305 Support styling on native MS-Windows console
14306
14307 PR/24315
14308 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14309 on MS-Windows if $TERM is not defined.
14310
14311 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14312
14313 * posix-hdep.c (gdb_console_fputs):
14314 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14315 functions.
14316 * ui-file.h (gdb_console_fputs): Add prototype.
14317
14318 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14319 back to fputs only if the former returns zero.
14320
14321 2019-03-07 Tom Tromey <tom@tromey.com>
14322
14323 * symmisc.c (print_symbol_bcache_statistics): Update.
14324 (print_objfile_statistics): Update.
14325 * symfile.c (allocate_symtab): Update.
14326 * stabsread.c: Don't include bcache.h.
14327 * psymtab.h (struct psymbol_bcache): Don't declare.
14328 (class psymtab_storage) <psymbol_cache>: Now a bcache.
14329 (psymbol_bcache_init, psymbol_bcache_free)
14330 (psymbol_bcache_get_bcache): Don't declare.
14331 * psymtab.c (struct psymbol_bcache): Remove.
14332 (psymtab_storage::psymtab_storage): Update.
14333 (psymtab_storage::~psymtab_storage): Update.
14334 (psymbol_bcache_init, psymbol_bcache_free)
14335 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14336 (add_psymbol_to_bcache): Update.
14337 (allocate_psymtab): Update.
14338 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14339 macro_cache>: No longer pointers.
14340 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14341 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14342 * macrotab.c (macro_bcache): Update.
14343 * macroexp.c: Don't include bcache.h.
14344 * gdbtypes.c (check_types_worklist): Update.
14345 (types_deeply_equal): Remove TRY/CATCH. Update.
14346 * elfread.c (elf_symtab_read): Update.
14347 * dwarf2read.c: Don't include bcache.h.
14348 * buildsym.c (buildsym_compunit::get_macro_table): Update.
14349 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14350 (print_bcache_statistics, bcache_memory_used): Don't declare.
14351 (struct bcache): Move from bcache.c. Add constructor, destructor,
14352 methods. Rename all data members.
14353 * bcache.c (struct bcache): Move to bcache.h.
14354 (bcache::expand_hash_table): Rename from expand_hash_table.
14355 (bcache): Remove.
14356 (bcache::insert): Rename from bcache_full.
14357 (bcache::compare): Rename from bcache_compare.
14358 (bcache_xmalloc): Remove.
14359 (bcache::~bcache): Rename from bcache_xfree.
14360 (bcache::print_statistics): Rename from print_bcache_statistics.
14361 (bcache::memory_used): Rename from bcache_memory_used.
14362
14363 2019-03-07 Pedro Alves <palves@redhat.com>
14364
14365 * infrun.c (normal_stop): Also check for
14366 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14367
14368 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
14369
14370 * f-lang.c (value_from_host_double): Moved to...
14371 * value.c (value_from_host_double): ...here.
14372 * value.h (value_from_host_double): Declare.
14373 * guile/scm-math.c (vlscm_convert_typed_number): Use
14374 value_from_host_double.
14375 (vlscm_convert_number): Likewise.
14376 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14377 * python/py-value.c (convert_value_from_python): Likewise.
14378
14379 2019-03-06 Tom Tromey <tom@tromey.com>
14380
14381 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14382
14383 2019-03-06 Tom Tromey <tom@tromey.com>
14384
14385 * utils.h (free_current_contents): Don't declare.
14386 * utils.c (free_current_contents): Remove.
14387
14388 2019-03-06 Tom Tromey <tom@tromey.com>
14389
14390 * top.c (quit_force): Update.
14391 * main.c (captured_command_loop): Update.
14392 * common/new-op.c (operator new): Update.
14393 * common/common-exceptions.c (struct catcher)
14394 <save_cleanup_chain>: Remove member.
14395 (exceptions_state_mc_init): Update.
14396 (exception_try_scope_entry): Return nullptr.
14397 (exception_try_scope_exit, exception_rethrow)
14398 (throw_exception_sjlj, throw_exception_cxx): Update.
14399 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14400 (all_cleanups, do_cleanups, discard_cleanups)
14401 (discard_final_cleanups, save_cleanups, save_final_cleanups)
14402 (restore_cleanups, restore_final_cleanups): Don't declare.
14403 (do_final_cleanups): Remove parameter.
14404 * common/cleanups.c (cleanup_chain, make_cleanup)
14405 (make_cleanup_dtor, all_cleanups, do_cleanups)
14406 (discard_my_cleanups, discard_cleanups)
14407 (discard_final_cleanups, save_my_cleanups, save_cleanups)
14408 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14409 (null_cleanup): Remove.
14410 (do_final_cleanups): Remove parameter.
14411
14412 2019-03-06 Tom Tromey <tom@tromey.com>
14413
14414 * remote.c (remote_target::remote_parse_stop_reply): Use
14415 unique_xmalloc_ptr.
14416
14417 2019-03-06 Tom Tromey <tom@tromey.com>
14418
14419 * stabsread.c (struct stabs_field_info): Rename from field_info.
14420 <list, fnlist>: Add initializers.
14421 <obstack>: New member.
14422 (read_member_functions, read_struct_fields, read_baseclasses):
14423 Allocate on obstack. Don't use cleanups.
14424 (read_one_struct_field, read_member_functions, read_struct_fields)
14425 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14426 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14427 (read_struct_type): Update.
14428
14429 2019-03-06 Tom Tromey <tom@tromey.com>
14430
14431 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14432 * common/filestuff.h (make_cleanup_close): Don't declare.
14433 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14434 Remove.
14435
14436 2019-03-06 Tom Tromey <tom@tromey.com>
14437
14438 * solib-aix.c: Use make_scope_exit.
14439
14440 2019-03-06 Tom Tromey <tom@tromey.com>
14441
14442 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14443 Use make_scope_exit.
14444
14445 2019-03-06 Tom Tromey <tom@tromey.com>
14446
14447 * solib-svr4.c (disable_probes_interface): Remove parameter.
14448 (svr4_handle_solib_event): Use make_scope_exit.
14449
14450 2019-03-06 Tom Tromey <tom@tromey.com>
14451
14452 * remote.c (struct stop_reply_deleter): Remove.
14453 (stop_reply_up): Update.
14454 (struct stop_reply): Derive from notif_event. Don't typedef.
14455 <regcache>: Now a std::vector.
14456 (stop_reply_xfree): Remove.
14457 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14458 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
14459 (remote_target::discard_pending_stop_replies): Use delete.
14460 (remote_target::remote_parse_stop_reply): Update.
14461 (remote_target::process_stop_reply): Update.
14462 * remote-notif.h (struct notif_event): Add virtual destructor.
14463 Remove "dtr" member.
14464 (struct notif_client) <alloc_event>: Return a unique_ptr.
14465 (notif_event_xfree): Don't declare.
14466 (notif_event_up): New typedef.
14467 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14468 (notif_event_xfree, do_notif_event_xfree): Remove.
14469 (remote_notif_state_xfree): Update.
14470
14471 2019-03-06 Tom Tromey <tom@tromey.com>
14472
14473 * infrun.c (displaced_step_clear_cleanup): Now a
14474 forward_scope_exit type.
14475 (displaced_step_prepare_throw): Update.
14476 (displaced_step_fixup): Update.
14477
14478 2019-03-06 Tom Tromey <tom@tromey.com>
14479
14480 * inferior.h (class inferior): Update comment.
14481 * gdbthread.h (class thread_info): Update comment.
14482
14483 2019-03-06 Joel Brobecker <brobecker@adacore.com>
14484 Tom Tromey <tom@tromey.com>
14485
14486 * stabsread.h (struct stab_section_list): Remove.
14487 (coffstab_build_psymtabs): Update.
14488 * dbxread.c (symbuf_sections): Now a std::vector.
14489 (sect_idx): New global.
14490 (fill_symbuf): Update.
14491 (coffstab_build_psymtabs): Change type of stabsects parameter.
14492 Update.
14493 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14494 std::vector.
14495 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14496 (coff_locate_sections): Update.
14497 (coff_symfile_read): Remove cleanups. Update.
14498 (init_stringtab): Add storage parameter.
14499 (free_stringtab, free_stringtab_cleanup): Remove.
14500 (init_lineno): Add storage parameter.
14501 (free_linetab, free_linetab_cleanup): Remove.
14502
14503 2019-03-06 Pedro Alves <palves@redhat.com>
14504
14505 * linux-fork.c (fork_info::clobber_regs): Delete.
14506 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14507 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
14508 comment. Adjust.
14509 (scoped_switch_fork_info::scoped_switch_fork_info)
14510 (checkpoint_command, linux_fork_context): Adjust
14511 fork_save_infrun_state calls.
14512
14513 2019-03-06 Pedro Alves <palves@redhat.com>
14514
14515 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14516 (inf_has_multiple_threads): Return 'bool' and rewrite using
14517 inferior_info::threads().
14518
14519 2019-03-06 Pedro Alves <palves@redhat.com>
14520
14521 * linux-fork.c: Include <list>.
14522 (fork_list): Now a std::list instance.
14523 (fork_info): Add ctor, dtor, and in-class initialize all fields.
14524 (forks_exist_p, find_last_fork): Adjust.
14525 (new_fork): Delete.
14526 (one_fork_p): New.
14527 (add_fork): Adjust.
14528 (free_fork): Delete, folded into fork_info::~fork_info().
14529 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14530 Adjust.
14531 (init_fork_list): Delete.
14532 (linux_fork_killall, linux_fork_mourn_inferior)
14533 (linux_fork_detach, info_checkpoints_command): Adjust.
14534 (_initialize_linux_fork): No longer call init_fork_list.
14535
14536 2019-03-06 Pedro Alves <palves@redhat.com>
14537
14538 * linux-fork.c (new_fork): New, split out of ...
14539 (add_fork): ... this. Return void. Move "first fork" special
14540 case from here, to ...
14541 (checkpoint_command): ... here.
14542 * linux-linux.h (add_fork): Return void.
14543
14544 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14545
14546 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14547
14548 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14549 Chris January <chris.january@arm.com>
14550 David Lecomber <david.lecomber@arm.com>
14551
14552 * f-exp.y: New token, UNOP_INTRINSIC.
14553 (exp): New pattern using UNOP_INTRINSIC token.
14554 (f77_keywords): Add 'abs' keyword.
14555 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14556 (value_from_host_double): New function.
14557 (evaluate_subexp_f): Support UNOP_ABS.
14558
14559 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14560
14561 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14562 types.
14563
14564 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14565
14566 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14567 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14568 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14569
14570 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14571
14572 * f-exp.y (convert_to_kind_type): Handle more type kinds.
14573
14574 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14575 Chris January <chris.january@arm.com>
14576
14577 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14578 * f-exp.y: Define 'KIND' token.
14579 (exp): New pattern for KIND expressions.
14580 (ptype): Handle types with a kind extension.
14581 (direct_abs_decl): Extend to spot kind extensions.
14582 (f77_keywords): Add 'kind' to the list.
14583 (push_kind_type): New function.
14584 (convert_to_kind_type): New function.
14585 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14586 * parse.c (operator_length_standard): Likewise.
14587 * parser-defs.h (enum type_pieces): Add tp_kind.
14588 * std-operator.def: Add UNOP_KIND.
14589
14590 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14591
14592 * f-exp.y (f_parse): Set yydebug.
14593
14594 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14595
14596 * f-lang.c (evaluate_subexp_f): New function.
14597 (exp_descriptor_f): New global.
14598 (f_language_defn): Use exp_descriptor_f instead of
14599 exp_descriptor_standard.
14600
14601 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14602
14603 * f-exp.y (struct token): Add comments.
14604 (dot_ops): Remove uppercase versions and the end marker.
14605 (f77_keywords): Likewise.
14606 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14607 entries in the dot_ops array are case insensitive, and use
14608 strncasecmp to compare strings. Also some whitespace cleanup in
14609 this area. Similar for the f77_keywords array, except entries in
14610 this list might be case sensitive.
14611
14612 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
14613
14614 * f-exp.y (struct f77_boolean_val): Add comments.
14615 (boolean_values): Remove uppercase versions, and end marker.
14616 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14617 and use strncasecmp to achieve case insensitivity. Additionally,
14618 perform whitespace cleanup around this code.
14619
14620 2019-03-06 Tom Tromey <tromey@adacore.com>
14621
14622 * remote-sim.c (gdbsim_target_open): Use result of
14623 gdb_argv::release.
14624
14625 2019-03-06 Richard Bunt <richard.bunt@arm.com>
14626 Dirk Schubert <dirk.schubert@arm.com>
14627 Chris January <chris.january@arm.com>
14628
14629 * eval.c (evaluate_subexp_standard): Call Fortran argument
14630 wrapping logic.
14631 * f-lang.c (struct value): A value which can be passed into a
14632 Fortran function call.
14633 (fortran_argument_convert): Wrap Fortran arguments in a pointer
14634 where appropriate.
14635 (struct type): Value ready for a Fortran function call.
14636 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14637 is needed.
14638 * f-lang.h (fortran_argument_convert): Declaration.
14639 (fortran_preserve_arg_pointer): Declaration.
14640 * infcall.c (value_arg_coerce): Call Fortran argument logic.
14641
14642 2019-03-05 Tom Tromey <tromey@adacore.com>
14643
14644 * python/py-prettyprint.c (print_string_repr): Remove #if.
14645 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14646
14647 2019-03-05 Tom Tromey <tromey@adacore.com>
14648
14649 * target.c (the_dummy_target): Move later. Change type to
14650 "dummy_target".
14651 (initialize_targets): Don't initialize the_dummy_target.
14652
14653 2019-03-05 Tom Tromey <tromey@adacore.com>
14654
14655 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14656 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14657
14658 2019-03-05 Tom Tromey <tromey@adacore.com>
14659
14660 * windows-nat.c (windows_nat_target::attach)
14661 (windows_nat_target::detach): Don't call gdb_flush.
14662 * valprint.c (generic_val_print, val_print, val_print_string):
14663 Don't call gdb_flush.
14664 * utils.c (defaulted_query): Don't call gdb_flush.
14665 * typeprint.c (print_type_scalar): Don't call gdb_flush.
14666 * target.c (target_announce_detach): Don't call gdb_flush.
14667 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14668 * remote.c (extended_remote_target::attach): Don't call
14669 gdb_flush.
14670 * procfs.c (procfs_target::detach): Don't call gdb_flush.
14671 * printcmd.c (do_examine): Don't call gdb_flush.
14672 (info_display_command): Don't call gdb_flush.
14673 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14674 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14675 * memattr.c (info_mem_command): Don't call gdb_flush.
14676 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14677 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14678 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14679 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14680 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14681 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14682 (gnu_nat_target::detach): Don't call gdb_flush.
14683 * f-valprint.c (f_val_print): Don't call gdb_flush.
14684 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14685 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14686 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14687 gdb_flush.
14688 * c-valprint.c (c_val_print): Don't call gdb_flush.
14689 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14690
14691 2019-03-05 Tom Tromey <tromey@adacore.com>
14692
14693 * varobj.c (update_dynamic_varobj_children): Update.
14694 (install_default_visualizer): Use reset, not release.
14695 * value.c (set_internalvar): Update.
14696 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14697 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14698 ATTRIBUTE_UNUSED_RESULT.
14699
14700 2019-03-05 Tom Tromey <tromey@adacore.com>
14701
14702 * remote.c (class scoped_remote_fd) <release>: Add
14703 ATTRIBUTE_UNUSED_RESULT.
14704
14705 2019-03-05 Tom Tromey <tromey@adacore.com>
14706
14707 * macroexp.c (struct macro_buffer) <release>: Add
14708 ATTRIBUTE_UNUSED_RESULT.
14709
14710 2019-03-05 Tom Tromey <tromey@adacore.com>
14711
14712 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14713 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14714 ATTRIBUTE_UNUSED_RESULT.
14715
14716 2019-03-05 Tom Tromey <tromey@adacore.com>
14717
14718 * common/scoped_fd.h (class scoped_fd) <release>: Add
14719 ATTRIBUTE_UNUSED_RESULT.
14720
14721 2019-03-05 Tom Tromey <tromey@adacore.com>
14722
14723 * parser-defs.h (struct parser_state) <release>: Add
14724 ATTRIBUTE_UNUSED_RESULT.
14725
14726 2019-03-05 Tom Tromey <tromey@adacore.com>
14727
14728 * utils.h (class gdb_argv) <release>: Add
14729 ATTRIBUTE_UNUSED_RESULT.
14730 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14731
14732 2019-03-02 Eli Zaretskii <eliz@gnu.org>
14733
14734 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14735 for-loop range, to avoid compiler warnings.
14736
14737 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14738 avoid compiler warnings about unused variables.
14739
14740 * NEWS: Mention end of support for native debugging on MS-Windows
14741 before XP.
14742
14743 PR gdb/24292
14744 * common/netstuff.c:
14745 * gdbserver/gdbreplay.c
14746 * gdbserver/remote-utils.c:
14747 * ser-tcp.c:
14748 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14749 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
14750 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14751 'getaddrinfo' and 'freeaddrinfo' were not available before
14752 Windows XP, and mingw.org's MinGW headers by default define
14753 _WIN32_WINNT to 0x500.
14754
14755 2019-03-01 Gary Benson <gbenson@redhat.com>
14756
14757 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14758
14759 2019-02-28 Brian Vandenberg <phantall@gmail.com>
14760 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
14761
14762 PR gdb/8527
14763 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14764 set_sigint_trap, clear_sigint_trap.
14765
14766 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14767
14768 * target.c (target_detach): Clear the regcache and the
14769 frame cache.
14770
14771 2019-02-27 Pedro Alves <palves@redhat.com>
14772
14773 * utils.c (set_screen_size): When we cap the height/width sizes,
14774 tweak the corresponding command variable to show "unlimited":
14775
14776 2019-02-27 Saagar Jha <saagar@saagarjha.com>
14777 Pedro Alves <palves@redhat.com>
14778
14779 * utils.c (set_screen_size): Reduce "infinite" rows and columns
14780 before calling rl_set_screen_size.
14781
14782 2019-02-27 Tom Tromey <tromey@adacore.com>
14783
14784 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14785 define.
14786 * python/py-value.c: Remove Python 2.4 workaround.
14787 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14788 workaround.
14789 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14790 Python 2.4 workaround.
14791 * python/python-internal.h: Remove Python 2.4 comment.
14792 (Py_ssize_t): Don't define.
14793 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14794 (gdb_Py_DECREF): Remove Python 2.4 workaround.
14795 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14796 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14797 * python/python.c (do_start_initialization): Remove Python 2.4
14798 workaround.
14799 * python/py-prettyprint.c (class dummy_python_frame): Remove.
14800 (print_children): Remove Python 2.4 workaround.
14801 * python/py-inferior.c (buffer_procs): Remove Python 2.4
14802 workaround.
14803 (CHARBUFFERPROC_NAME): Remove.
14804 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14805 Python 2.4 workaround.
14806
14807 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14808
14809 * NEWS: Note minimum Python version.
14810
14811 2019-02-27 Kevin Buettner <kevinb@redhat.com>
14812
14813 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14814 code from these functions. Remove corresponding ifdefs. Use
14815 Py_buffer_up instead of explicit calls to PyBuffer_Release.
14816 Remove gotos and target of gotos.
14817 (infpy_search_memory): Likewise.
14818
14819 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14820
14821 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14822 (hppa_gdbarch_init): Don't register deleted functions with
14823 gdbarch.
14824
14825 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14826
14827 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14828 (h8300_unwind_sp): Delete.
14829 (h8300_dummy_id): Delete.
14830 (h8300_gdbarch_init): Don't register deleted functions with
14831 gdbarch.
14832
14833 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14834
14835 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14836 (ft32_unwind_pc): Delete.
14837 (ft32_unwind_sp): Delete.
14838 (ft32_gdbarch_init): Don't register deleted functions with
14839 gdbarch.
14840
14841 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14842
14843 * gdb/frv-tdep.c (frv_dummy_id): Delete.
14844 (frv_unwind_pc): Delete.
14845 (frv_unwind_sp): Delete.
14846 (frv_gdbarch_init): Don't register deleted functions with
14847 gdbarch.
14848
14849 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14850
14851 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14852 (riscv_unwind_pc): Delete.
14853 (riscv_unwind_sp): Delete.
14854 (riscv_gdbarch_init): Don't register deleted functions with
14855 gdbarch.
14856
14857 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14858
14859 * gdb/csky-tdep.c (csky_dummy_id): Delete.
14860 (csky_unwind_pc): Delete.
14861 (csky_unwind_sp): Delete.
14862 (csky_gdbarch_init): Don't register deleted functions with
14863 gdbarch.
14864
14865 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14866
14867 * gdb/cris-tdep.c (cris_dummy_id): Delete.
14868 (cris_unwind_pc): Delete.
14869 (cris_unwind_sp): Delete.
14870 (cris_gdbarch_init): Don't register deleted functions with
14871 gdbarch.
14872
14873 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14874
14875 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14876 (bfin_unwind_pc): Delete.
14877 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14878
14879 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14880
14881 * gdb/arm-tdep.c (arm_dummy_id): Delete.
14882 (arm_unwind_pc): Delete.
14883 (arm_unwind_sp): Delete.
14884 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14885
14886 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14887
14888 * gdb/arc-tdep.c (arc_dummy_id): Delete.
14889 (arc_unwind_pc): Delete.
14890 (arc_unwind_sp): Delete.
14891 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14892
14893 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14894
14895 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14896 (alpha_unwind_pc): Delete.
14897 (alpha_gdbarch_init): Don't register deleted functions with
14898 gdbarch.
14899
14900 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14901
14902 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14903 (aarch64_unwind_pc): Delete.
14904 (aarch64_unwind_sp): Delete.
14905 (aarch64_gdbarch_init): Don't register deleted functions with
14906 gdbarch.
14907
14908 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14909
14910 * gdbtypes.c (type_align): Don't consider static members when
14911 computing structure alignment.
14912
14913 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
14914
14915 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14916 return 0 for other types.
14917 * arch-utils.c (default_type_align): Always return 0.
14918 * gdbarch.h: Regenerate.
14919 * gdbarch.sh (type_align): Extend comment.
14920 * gdbtypes.c (type_align): Add additional comments, always call
14921 gdbarch_type_align before applying the default rules.
14922 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14923 generic code will then apply a suitable default.
14924 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14925 types, return 0 for other types.
14926
14927 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14928
14929 * NEWS: Create a new section for the next release branch.
14930 Rename the section of the current branch, now that it has
14931 been cut.
14932
14933 2019-02-27 Joel Brobecker <brobecker@adacore.com>
14934
14935 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14936 * version.in: Bump version to 8.3.50.DATE-git.
14937
14938 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
14939
14940 * aix-thread.c (ptid_cmp): Remove unused variable.
14941 (get_signaled_thread): Likewise.
14942 (store_regs_user_thread): Likewise.
14943 (store_regs_kernel_thread): Likewise.
14944 (fetch_regs_kernel_thread): Remove shadowed variable.
14945
14946 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
14947
14948 * features/riscv/32bit-cpu.xml: Add register numbers.
14949 * features/riscv/32bit-fpu.c: Regenerate.
14950 * features/riscv/32bit-fpu.xml: Add register numbers.
14951 * features/riscv/64bit-cpu.xml: Add register numbers.
14952 * features/riscv/64bit-fpu.c: Regenerate.
14953 * features/riscv/64bit-fpu.xml: Add register numbers.
14954
14955 2019-02-26 Kevin Buettner <kevinb@redhat.com>
14956
14957 * NEWS: Mention two argument form of gdb.Value constructor.
14958 * python/py-value.c (convert_buffer_and_type_to_value): New
14959 function.
14960 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14961 Add support for handling an optional second argument. Call
14962 convert_buffer_and_type_to_value as appropriate.
14963 * python/python-internal.h (Py_buffer_deleter): New struct.
14964 (Py_buffer_up): New typedef.
14965
14966 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14967
14968 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14969 instead of releasing ownership.
14970
14971 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14972
14973 * dwarf2read.c (open_and_init_dwp_file): Call
14974 elf_numsections instead of bfd_count_sections to initialize
14975 dwp_file->num_sections.
14976
14977 2019-02-25 Tom Tromey <tromey@adacore.com>
14978
14979 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14980
14981 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14982
14983 * gcore.in: Add '--readnever' option when invoking GDB.
14984
14985 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14986
14987 * MAINTAINERS: Update my email address.
14988
14989 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14990
14991 * build-id.c (build_id_to_debug_bfd_1): New function.
14992 (build_id_to_debug_bfd): Look for separate debug file in
14993 sysroot.
14994
14995 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14996
14997 * gdbarch.sh: Update the copyright year range that is placed into
14998 generated files.
14999
15000 2019-02-22 Keith Seitz <keiths@redhat.com>
15001
15002 PR symtab/23853
15003 * linespec.c (create_sals_line_offset): Search for the default
15004 symtab's filename instead of its fullname.
15005
15006 2019-02-21 Alan Hayward <alan.hayward@arm.com>
15007
15008 * NEWS: Update style defaults.
15009
15010 2019-02-21 Alan Hayward <alan.hayward@arm.com>
15011
15012 * main.c (captured_main_1): Disable styling in batch mode.
15013
15014 2019-02-20 Tom Tromey <tom@tromey.com>
15015
15016 * symtab.c (symtab_symbol_info): Fix typos.
15017
15018 2019-02-20 Tom Tromey <tromey@adacore.com>
15019
15020 * findcmd.c (_initialize_mem_search): Use upper case for
15021 metasyntactic variables.
15022
15023 2019-02-20 Alan Hayward <alan.hayward@arm.com>
15024
15025 * aarch64-tdep.c (aarch64_add_reggroups): New function.
15026 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
15027
15028 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
15029
15030 * top.h (source_file_name): Change to std::string.
15031 * top.c (source_file_name): Likewise.
15032 (command_line_input): Adjust.
15033 * cli/cli-script.c (script_from_file): Adjust.
15034
15035 2019-02-19 Tom Tromey <tromey@adacore.com>
15036
15037 * ravenscar-thread.c
15038 (ravenscar_thread_target::update_thread_list): Don't call
15039 ada_build_task_list.
15040 * ada-lang.h (ada_build_task_list): Don't declare.
15041 * ada-tasks.c (struct ada_tasks_inferior_data)
15042 <task_list_valid_p>: Now bool.
15043 (read_known_tasks, ada_task_list_changed)
15044 (ada_tasks_invalidate_inferior_data): Update.
15045 (read_known_tasks_array): Return bool.
15046 (read_known_tasks_list): Likewise.
15047 (read_known_tasks): Return void.
15048 (ada_build_task_list): Now static.
15049
15050 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
15051
15052 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
15053 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
15054
15055 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15056
15057 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
15058 variant for ada_tasks_pspace_data_handle and
15059 ada_tasks_inferior_data_handle.
15060 (ada_tasks_pspace_data_cleanup): New function.
15061 (ada_tasks_inferior_data_cleanup): New function.
15062
15063 2019-02-17 Tom Tromey <tom@tromey.com>
15064
15065 * macrotab.h (macro_source_fullname): Return a std::string.
15066 * macrotab.c (macro_include, check_for_redefinition)
15067 (macro_undef, macro_lookup_definition, foreach_macro)
15068 (foreach_macro_in_scope): Update.
15069 (macro_source_fullname): Return a std::string.
15070 * macrocmd.c (show_pp_source_pos): Update.
15071
15072 2019-02-17 Tom Tromey <tom@tromey.com>
15073
15074 * macrocmd.c (show_pp_source_pos): Style the file names.
15075
15076 2019-02-17 Tom Tromey <tom@tromey.com>
15077
15078 PR tui/24197:
15079 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
15080
15081 2019-02-17 Tom Tromey <tom@tromey.com>
15082
15083 * ada-lang.c (user_select_syms): Use filtered printing.
15084 * utils.c (wrap_style): New global.
15085 (desired_style): Remove.
15086 (emit_style_escape): Add stream parameter.
15087 (set_output_style, reset_terminal_style, prompt_for_continue):
15088 Update.
15089 (flush_wrap_buffer): Only flush gdb_stdout.
15090 (wrap_here): Set wrap_style.
15091 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
15092 treat escape sequences as a character. Change when wrap buffer is
15093 flushed.
15094 (fputs_styled): Do not set the output style when the default is
15095 requested.
15096 * ui-style.h (struct ui_file_style) <is_default>: New method.
15097 * source.c (print_source_lines_base): Emit escape sequences in one
15098 piece.
15099
15100 2019-02-17 Joel Brobecker <brobecker@adacore.com>
15101
15102 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
15103 integers and enumeration types.
15104
15105 2019-02-17 Joel Brobecker <brobecker@adacore.com>
15106
15107 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
15108 instead of lookup_symbol_in_language
15109 (do_exact_match): New function.
15110 (ada_get_symbol_name_matcher): Return do_exact_match when
15111 doing a verbatim match.
15112
15113 2019-02-15 Tom Tromey <tromey@adacore.com>
15114
15115 * ravenscar-thread.c (ravenscar_thread_target::resume)
15116 (ravenscar_thread_target::wait): Special case wildcard requests.
15117
15118 2019-02-15 Tom Tromey <tromey@adacore.com>
15119
15120 * ravenscar-thread.c (base_ptid): Remove.
15121 (struct ravenscar_thread_target) <close>: New method.
15122 <m_base_ptid>: New member.
15123 <update_inferior_ptid, active_task, task_is_currently_active,
15124 runtime_initialized>: Declare methods.
15125 <ravenscar_thread_target>: Add constructor.
15126 (ravenscar_thread_target::task_is_currently_active)
15127 (ravenscar_thread_target::update_inferior_ptid)
15128 (ravenscar_runtime_initialized): Rename. Now methods.
15129 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
15130 (ravenscar_thread_target::update_thread_list): Update.
15131 (ravenscar_thread_target::active_task): Now method.
15132 (ravenscar_thread_target::store_registers)
15133 (ravenscar_thread_target::prepare_to_store)
15134 (ravenscar_thread_target::prepare_to_store)
15135 (ravenscar_thread_target::mourn_inferior): Update.
15136 (ravenscar_inferior_created): Use "new" to create target.
15137 (ravenscar_thread_target::get_ada_task_ptid): Update.
15138 (_initialize_ravenscar): Don't initialize base_ptid.
15139 (ravenscar_ops): Remove global.
15140
15141 2019-02-15 Tom Tromey <tromey@adacore.com>
15142
15143 * target.h (push_target): Declare new overload.
15144 * target.c (push_target): New overload, taking an rvalue reference.
15145 * remote.c (remote_target::open_1): Use push_target overload.
15146 * corelow.c (core_target_open): Use push_target overload.
15147
15148 2019-02-15 Tom Tromey <tromey@adacore.com>
15149
15150 * ravenscar-thread.c (is_ravenscar_task)
15151 (ravenscar_task_is_currently_active): Return bool.
15152 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15153 (_initialize_ravenscar): Remove "(void)".
15154 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15155 Return bool.
15156
15157 2019-02-15 Tom Tromey <tromey@adacore.com>
15158
15159 * ravenscar-thread.c (ravenscar_runtime_initializer)
15160 (has_ravenscar_runtime, get_running_thread_id)
15161 (ravenscar_thread_target::resume): Fix indentation.
15162
15163 2019-02-15 Tom Tromey <tromey@adacore.com>
15164
15165 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15166 from ravenscar_arch_ops.
15167 (sparc_ravenscar_ops::fetch_registers)
15168 (sparc_ravenscar_ops::store_registers): Now methods.
15169 (sparc_ravenscar_prepare_to_store): Remove.
15170 (sparc_ravenscar_ops): Redefine.
15171 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15172 methods and destructor. Remove members.
15173 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15174 (ravenscar_thread_target::store_registers)
15175 (ravenscar_thread_target::prepare_to_store): Update.
15176 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15177 Remove.
15178 (struct ppc_ravenscar_powerpc_ops): Derive from
15179 ravenscar_arch_ops.
15180 (ppc_ravenscar_powerpc_ops::fetch_registers)
15181 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15182 (ppc_ravenscar_powerpc_ops): Redefine.
15183 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15184 (ppc_ravenscar_e500_ops::fetch_registers)
15185 (ppc_ravenscar_e500_ops::store_registers): Now methods.
15186 (ppc_ravenscar_e500_ops): Redefine.
15187 * aarch64-ravenscar-thread.c
15188 (aarch64_ravenscar_generic_prepare_to_store): Remove.
15189 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15190 (aarch64_ravenscar_fetch_registers)
15191 (aarch64_ravenscar_store_registers): Now methods.
15192 (aarch64_ravenscar_ops): Redefine.
15193
15194 2019-02-15 Tom Tromey <tromey@adacore.com>
15195
15196 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15197 (ravenscar_thread_target::stopped_by_hw_breakpoint)
15198 (ravenscar_thread_target::stopped_by_watchpoint)
15199 (ravenscar_thread_target::stopped_data_address)
15200 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15201
15202 2019-02-15 Tom Tromey <tromey@adacore.com>
15203
15204 * ravenscar-thread.c: Fix some typos.
15205
15206 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15207 Tom Tromey <tromey@adacore.com>
15208
15209 * ada-lang.c (ada_exception_sal): Change addr_string to a
15210 std::string.
15211 (create_ada_exception_catchpoint): Update.
15212
15213 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15214 Tom Tromey <tromey@adacore.com>
15215
15216 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15217 (bp_location_ops): Remove.
15218 (base_breakpoint_allocate_location): Update.
15219 (free_bp_location): Update.
15220 * ada-lang.c (class ada_catchpoint_location)
15221 <ada_catchpoint_location>: Remove ops parameter.
15222 (ada_catchpoint_location_dtor): Remove.
15223 (ada_catchpoint_location_ops): Remove.
15224 (allocate_location_exception): Update.
15225 * breakpoint.h (struct bp_location_ops): Remove.
15226 (class bp_location) <bp_location>: Remove bp_location_ops
15227 parameter.
15228 <~bp_location>: Add destructor.
15229 <ops>: Remove.
15230
15231 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15232 Pedro Alves <palves@redhat.com>
15233
15234 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15235 'PATH_MAX'.
15236
15237 2019-02-14 David Michael <fedora.dm0@gmail.com>
15238 Samuel Thibault <samuel.thibault@gnu.org>
15239 Thomas Schwinge <thomas@codesourcery.com>
15240
15241 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15242 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15243
15244 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
15245
15246 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15247 (check_empty): Use "const char *".
15248
15249 * gnu-nat.c (gnu_nat_target::detach): Instead of
15250 'detach_inferior (pid)' call
15251 'detach_inferior (find_inferior_pid (pid))'.
15252
15253 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15254 'nat/fork-inferior.o'.
15255 * gnu-nat.c: #include "nat/fork-inferior.h".
15256
15257 * gnu-nat.c (gnu_nat_target::detach): Instead of
15258 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15259 * gnu-nat.h: #include "inf-child.h".
15260 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15261 'i386_gnu_nat_target::fetch_registers'.
15262 (gnu_store_registers): Rename/move to
15263 'i386_gnu_nat_target::store_registers'.
15264
15265 * config/i386/nm-i386gnu.h: Don't "#include" any files.
15266 * gnu-nat.h (mach_thread_info): New function.
15267 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15268
15269 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15270
15271 2019-02-14 Frederic Konrad <konrad@adacore.com>
15272
15273 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15274
15275 2019-02-14 Joel Brobecker <brobecker@adacore.com>
15276
15277 * windows-nat.c (windows_add_thread): Add new parameter
15278 "main_thread_p" with default value set to false. Update
15279 function documentation as well as all callers.
15280 (windows_delete_thread): Likewise.
15281 (fake_create_process): Update call to windows_add_thread.
15282 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15283 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15284 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15285 call to windows_delete_thread.
15286
15287 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
15288
15289 * MAINTAINERS: Add Andrew Burgess as global maintainer.
15290
15291 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15292
15293 * symfile.c (find_separate_debug_file): Use canonical path of
15294 sysroot with child_path instead of gdb_sysroot if it is valid.
15295
15296 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15297
15298 * symfile.c (find_separate_debug_file): Use child_path to
15299 determine if an object file is under a sysroot.
15300
15301 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15302
15303 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15304 unittests/child-path-selftests.c.
15305 * common/pathstuff.c (child_path): New function.
15306 * common/pathstuff.h (child_path): New prototype.
15307 * unittests/child-path-selftests.c: New file.
15308
15309 2019-02-12 John Baldwin <jhb@FreeBSD.org>
15310
15311 * symfile.c (find_separate_debug_file): Look for separate debug
15312 files in debug directories under the sysroot.
15313
15314 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15315
15316 * symtab.h (struct minimal_symbol data_p): New const method.
15317 (struct minimal_symbol text_p): Likewise.
15318 * symtab.c (output_source_filename): Use file name style
15319 to print file name.
15320 (print_symbol_info): Likewise.
15321 (print_msymbol_info): Use address style to print addresses.
15322 Use function name style to print executable text symbols.
15323 (expand_symtab_containing_pc): Use data_p.
15324 (find_pc_sect_compunit_symtab): Likewise.
15325
15326 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15327
15328 * breakpoint.c (describe_other_breakpoints): Use address style
15329 to print addresses.
15330 (say_where): Likewise.
15331
15332 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15333
15334 * ada-typeprint.c (print_func_type): Print function name
15335 style to print function name.
15336 * c-typeprint.c (c_print_type_1): Likewise.
15337
15338 2019-02-11 Alan Hayward <alan.hayward@arm.com>
15339
15340 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15341 for execve.
15342
15343 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15344
15345 * c-exp.y (direct_abs_decl): Use emplace_back to record the
15346 type_stack.
15347
15348 2019-02-10 Joel Brobecker <brobecker@adacore.com>
15349
15350 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15351 TYPE_CODE_REF types.
15352
15353 2019-02-08 Jim Wilson <jimw@sifive.com>
15354
15355 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15356 (riscv_linux_fregset): New.
15357 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15358
15359 2019-02-07 Tom Tromey <tom@tromey.com>
15360
15361 * thread.c (thread_cancel_execution_command): Update.
15362 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15363 methods.
15364 (struct thread_fsm_ops): Remove.
15365 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15366 (thread_fsm_should_stop, thread_fsm_return_value)
15367 (thread_fsm_set_finished, thread_fsm_finished_p)
15368 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15369 Don't declare.
15370 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15371 * infrun.c (clear_proceed_status_thread)
15372 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15373 (print_stop_event): Update.
15374 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15375 Add constructor.
15376 (step_command_fsm_ops): Remove.
15377 (new_step_command_fsm): Remove.
15378 (step_1): Update.
15379 (step_command_fsm::should_stop): Rename from
15380 step_command_fsm_should_stop.
15381 (step_command_fsm::clean_up): Rename from
15382 step_command_fsm_clean_up.
15383 (step_command_fsm::do_async_reply_reason): Rename from
15384 step_command_fsm_async_reply_reason.
15385 (struct until_next_fsm): Inherit from thread_fsm. Add
15386 constructor.
15387 (until_next_fsm_ops): Remove.
15388 (new_until_next_fsm): Remove.
15389 (until_next_fsm::should_stop): Rename from
15390 until_next_fsm_should_stop.
15391 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15392 (until_next_fsm::do_async_reply_reason): Rename from
15393 until_next_fsm_async_reply_reason.
15394 (struct finish_command_fsm): Inherit from thread_fsm. Add
15395 constructor. Change type of breakpoint.
15396 (finish_command_fsm_ops): Remove.
15397 (new_finish_command_fsm): Remove.
15398 (finish_command_fsm::should_stop): Rename from
15399 finish_command_fsm_should_stop.
15400 (finish_command_fsm::clean_up): Rename from
15401 finish_command_fsm_clean_up.
15402 (finish_command_fsm::return_value): Rename from
15403 finish_command_fsm_return_value.
15404 (finish_command_fsm::do_async_reply_reason): Rename from
15405 finish_command_fsm_async_reply_reason.
15406 (finish_command): Update.
15407 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15408 Add constructor.
15409 (call_thread_fsm_ops): Remove.
15410 (call_thread_fsm::call_thread_fsm): Rename from
15411 new_call_thread_fsm.
15412 (call_thread_fsm::should_stop): Rename from
15413 call_thread_fsm_should_stop.
15414 (call_thread_fsm::should_notify_stop): Rename from
15415 call_thread_fsm_should_notify_stop.
15416 (run_inferior_call, call_function_by_hand_dummy): Update.
15417 * cli/cli-interp.c (should_print_stop_to_console): Update.
15418 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15419 Add constructor. Change type of location_breakpoint,
15420 caller_breakpoint.
15421 (until_break_fsm_ops): Remove.
15422 (new_until_break_fsm): Remove.
15423 (until_break_fsm::should_stop): Rename from
15424 until_break_fsm_should_stop.
15425 (until_break_fsm::clean_up): Rename from
15426 until_break_fsm_clean_up.
15427 (until_break_fsm::do_async_reply_reason): Rename from
15428 until_break_fsm_async_reply_reason.
15429 (until_break_command): Update.
15430 * thread-fsm.c: Remove.
15431 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15432
15433 2019-02-07 Tom Tromey <tom@tromey.com>
15434
15435 * yy-remap.h: Add include guard.
15436 * xtensa-tdep.h: Add include guard.
15437 * xcoffread.h: Rename include guard.
15438 * varobj-iter.h: Add include guard.
15439 * tui/tui.h: Rename include guard.
15440 * tui/tui-winsource.h: Rename include guard.
15441 * tui/tui-wingeneral.h: Rename include guard.
15442 * tui/tui-windata.h: Rename include guard.
15443 * tui/tui-win.h: Rename include guard.
15444 * tui/tui-stack.h: Rename include guard.
15445 * tui/tui-source.h: Rename include guard.
15446 * tui/tui-regs.h: Rename include guard.
15447 * tui/tui-out.h: Rename include guard.
15448 * tui/tui-layout.h: Rename include guard.
15449 * tui/tui-io.h: Rename include guard.
15450 * tui/tui-hooks.h: Rename include guard.
15451 * tui/tui-file.h: Rename include guard.
15452 * tui/tui-disasm.h: Rename include guard.
15453 * tui/tui-data.h: Rename include guard.
15454 * tui/tui-command.h: Rename include guard.
15455 * tic6x-tdep.h: Add include guard.
15456 * target/waitstatus.h: Rename include guard.
15457 * target/wait.h: Rename include guard.
15458 * target/target.h: Rename include guard.
15459 * target/resume.h: Rename include guard.
15460 * target-float.h: Rename include guard.
15461 * stabsread.h: Add include guard.
15462 * rs6000-tdep.h: Add include guard.
15463 * riscv-fbsd-tdep.h: Add include guard.
15464 * regformats/regdef.h: Rename include guard.
15465 * record.h: Rename include guard.
15466 * python/python.h: Rename include guard.
15467 * python/python-internal.h: Rename include guard.
15468 * python/py-stopevent.h: Rename include guard.
15469 * python/py-ref.h: Rename include guard.
15470 * python/py-record.h: Rename include guard.
15471 * python/py-record-full.h: Rename include guard.
15472 * python/py-record-btrace.h: Rename include guard.
15473 * python/py-instruction.h: Rename include guard.
15474 * python/py-events.h: Rename include guard.
15475 * python/py-event.h: Rename include guard.
15476 * procfs.h: Add include guard.
15477 * proc-utils.h: Add include guard.
15478 * p-lang.h: Add include guard.
15479 * or1k-tdep.h: Rename include guard.
15480 * observable.h: Rename include guard.
15481 * nto-tdep.h: Rename include guard.
15482 * nat/x86-linux.h: Rename include guard.
15483 * nat/x86-linux-dregs.h: Rename include guard.
15484 * nat/x86-gcc-cpuid.h: Add include guard.
15485 * nat/x86-dregs.h: Rename include guard.
15486 * nat/x86-cpuid.h: Rename include guard.
15487 * nat/ppc-linux.h: Rename include guard.
15488 * nat/mips-linux-watch.h: Rename include guard.
15489 * nat/linux-waitpid.h: Rename include guard.
15490 * nat/linux-ptrace.h: Rename include guard.
15491 * nat/linux-procfs.h: Rename include guard.
15492 * nat/linux-osdata.h: Rename include guard.
15493 * nat/linux-nat.h: Rename include guard.
15494 * nat/linux-namespaces.h: Rename include guard.
15495 * nat/linux-btrace.h: Rename include guard.
15496 * nat/glibc_thread_db.h: Rename include guard.
15497 * nat/gdb_thread_db.h: Rename include guard.
15498 * nat/gdb_ptrace.h: Rename include guard.
15499 * nat/fork-inferior.h: Rename include guard.
15500 * nat/amd64-linux-siginfo.h: Rename include guard.
15501 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15502 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15503 * nat/aarch64-linux.h: Rename include guard.
15504 * nat/aarch64-linux-hw-point.h: Rename include guard.
15505 * mn10300-tdep.h: Add include guard.
15506 * mips-linux-tdep.h: Add include guard.
15507 * mi/mi-parse.h: Rename include guard.
15508 * mi/mi-out.h: Rename include guard.
15509 * mi/mi-main.h: Rename include guard.
15510 * mi/mi-interp.h: Rename include guard.
15511 * mi/mi-getopt.h: Rename include guard.
15512 * mi/mi-console.h: Rename include guard.
15513 * mi/mi-common.h: Rename include guard.
15514 * mi/mi-cmds.h: Rename include guard.
15515 * mi/mi-cmd-break.h: Rename include guard.
15516 * m2-lang.h: Add include guard.
15517 * location.h: Rename include guard.
15518 * linux-record.h: Rename include guard.
15519 * linux-nat.h: Add include guard.
15520 * linux-fork.h: Add include guard.
15521 * i386-darwin-tdep.h: Rename include guard.
15522 * hppa-linux-offsets.h: Add include guard.
15523 * guile/guile.h: Rename include guard.
15524 * guile/guile-internal.h: Rename include guard.
15525 * gnu-nat.h: Rename include guard.
15526 * gdb-stabs.h: Rename include guard.
15527 * frv-tdep.h: Add include guard.
15528 * f-lang.h: Add include guard.
15529 * event-loop.h: Add include guard.
15530 * darwin-nat.h: Rename include guard.
15531 * cp-abi.h: Rename include guard.
15532 * config/sparc/nm-sol2.h: Rename include guard.
15533 * config/nm-nto.h: Rename include guard.
15534 * config/nm-linux.h: Add include guard.
15535 * config/i386/nm-i386gnu.h: Rename include guard.
15536 * config/djgpp/nl_types.h: Rename include guard.
15537 * config/djgpp/langinfo.h: Rename include guard.
15538 * compile/gcc-cp-plugin.h: Add include guard.
15539 * compile/gcc-c-plugin.h: Add include guard.
15540 * compile/compile.h: Rename include guard.
15541 * compile/compile-object-run.h: Rename include guard.
15542 * compile/compile-object-load.h: Rename include guard.
15543 * compile/compile-internal.h: Rename include guard.
15544 * compile/compile-cplus.h: Rename include guard.
15545 * compile/compile-c.h: Rename include guard.
15546 * common/xml-utils.h: Rename include guard.
15547 * common/x86-xstate.h: Rename include guard.
15548 * common/version.h: Rename include guard.
15549 * common/vec.h: Rename include guard.
15550 * common/tdesc.h: Rename include guard.
15551 * common/selftest.h: Rename include guard.
15552 * common/scoped_restore.h: Rename include guard.
15553 * common/scoped_mmap.h: Rename include guard.
15554 * common/scoped_fd.h: Rename include guard.
15555 * common/safe-iterator.h: Rename include guard.
15556 * common/run-time-clock.h: Rename include guard.
15557 * common/refcounted-object.h: Rename include guard.
15558 * common/queue.h: Rename include guard.
15559 * common/ptid.h: Rename include guard.
15560 * common/print-utils.h: Rename include guard.
15561 * common/preprocessor.h: Rename include guard.
15562 * common/pathstuff.h: Rename include guard.
15563 * common/observable.h: Rename include guard.
15564 * common/netstuff.h: Rename include guard.
15565 * common/job-control.h: Rename include guard.
15566 * common/host-defs.h: Rename include guard.
15567 * common/gdb_wait.h: Rename include guard.
15568 * common/gdb_vecs.h: Rename include guard.
15569 * common/gdb_unlinker.h: Rename include guard.
15570 * common/gdb_unique_ptr.h: Rename include guard.
15571 * common/gdb_tilde_expand.h: Rename include guard.
15572 * common/gdb_sys_time.h: Rename include guard.
15573 * common/gdb_string_view.h: Rename include guard.
15574 * common/gdb_splay_tree.h: Rename include guard.
15575 * common/gdb_setjmp.h: Rename include guard.
15576 * common/gdb_ref_ptr.h: Rename include guard.
15577 * common/gdb_optional.h: Rename include guard.
15578 * common/gdb_locale.h: Rename include guard.
15579 * common/gdb_assert.h: Rename include guard.
15580 * common/filtered-iterator.h: Rename include guard.
15581 * common/filestuff.h: Rename include guard.
15582 * common/fileio.h: Rename include guard.
15583 * common/environ.h: Rename include guard.
15584 * common/common-utils.h: Rename include guard.
15585 * common/common-types.h: Rename include guard.
15586 * common/common-regcache.h: Rename include guard.
15587 * common/common-inferior.h: Rename include guard.
15588 * common/common-gdbthread.h: Rename include guard.
15589 * common/common-exceptions.h: Rename include guard.
15590 * common/common-defs.h: Rename include guard.
15591 * common/common-debug.h: Rename include guard.
15592 * common/cleanups.h: Rename include guard.
15593 * common/buffer.h: Rename include guard.
15594 * common/btrace-common.h: Rename include guard.
15595 * common/break-common.h: Rename include guard.
15596 * cli/cli-utils.h: Rename include guard.
15597 * cli/cli-style.h: Rename include guard.
15598 * cli/cli-setshow.h: Rename include guard.
15599 * cli/cli-script.h: Rename include guard.
15600 * cli/cli-interp.h: Rename include guard.
15601 * cli/cli-decode.h: Rename include guard.
15602 * cli/cli-cmds.h: Rename include guard.
15603 * charset-list.h: Add include guard.
15604 * buildsym-legacy.h: Rename include guard.
15605 * bfin-tdep.h: Add include guard.
15606 * ax.h: Rename include guard.
15607 * arm-linux-tdep.h: Add include guard.
15608 * arm-fbsd-tdep.h: Add include guard.
15609 * arch/xtensa.h: Rename include guard.
15610 * arch/tic6x.h: Add include guard.
15611 * arch/i386.h: Add include guard.
15612 * arch/arm.h: Rename include guard.
15613 * arch/arm-linux.h: Rename include guard.
15614 * arch/arm-get-next-pcs.h: Rename include guard.
15615 * arch/amd64.h: Add include guard.
15616 * arch/aarch64-insn.h: Rename include guard.
15617 * arch-utils.h: Rename include guard.
15618 * annotate.h: Add include guard.
15619 * amd64-darwin-tdep.h: Rename include guard.
15620 * aarch64-linux-tdep.h: Add include guard.
15621 * aarch64-fbsd-tdep.h: Add include guard.
15622 * aarch32-linux-nat.h: Add include guard.
15623
15624 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15625
15626 * macrotab.c (macro_define_internal): New function that
15627 factorizes macro_define_object_internal and macro_define_function
15628 code.
15629 (macro_define_object_internal): Use macro_define_internal.
15630 (macro_define_function): Likewise.
15631
15632 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15633
15634 * macrocmd.c (extract_identifier): Return
15635 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15636 callers.
15637
15638 2019-02-06 John Baldwin <jhb@FreeBSD.org>
15639
15640 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15641
15642 2019-02-05 Tom Tromey <tom@tromey.com>
15643
15644 * target.c (target_stack::unpush): Move assertion earlier.
15645
15646 2019-01-30 Tom Tromey <tom@tromey.com>
15647
15648 PR python/23615:
15649 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15650 (gdbpy_parse_and_eval): Likewise.
15651 * python/python-internal.h (gdbpy_allow_threads): New class.
15652
15653 2019-01-28 John Baldwin <jhb@FreeBSD.org>
15654
15655 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15656 (aarch64_fbsd_fpregmap): Move earlier.
15657 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15658 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15659 instead of individual calls to trad_frame_set_reg_addr.
15660 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15661 earlier.
15662 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15663 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15664 instead of individual calls to trad_frame_set_reg_addr.
15665
15666 2019-01-28 Alan Hayward <alan.hayward@arm.com>
15667
15668 * CONTRIBUTE: Replace contribution list with wiki link.
15669
15670 2019-01-25 Tom Tromey <tom@tromey.com>
15671
15672 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15673
15674 2019-01-25 Tom Tromey <tom@tromey.com>
15675
15676 * xtensa-linux-nat.c: Fix common/ includes.
15677 * xml-support.h: Fix common/ includes.
15678 * xml-support.c: Fix common/ includes.
15679 * x86-linux-nat.c: Fix common/ includes.
15680 * windows-nat.c: Fix common/ includes.
15681 * varobj.h: Fix common/ includes.
15682 * varobj.c: Fix common/ includes.
15683 * value.c: Fix common/ includes.
15684 * valops.c: Fix common/ includes.
15685 * utils.c: Fix common/ includes.
15686 * unittests/xml-utils-selftests.c: Fix common/ includes.
15687 * unittests/utils-selftests.c: Fix common/ includes.
15688 * unittests/unpack-selftests.c: Fix common/ includes.
15689 * unittests/tracepoint-selftests.c: Fix common/ includes.
15690 * unittests/style-selftests.c: Fix common/ includes.
15691 * unittests/string_view-selftests.c: Fix common/ includes.
15692 * unittests/scoped_restore-selftests.c: Fix common/ includes.
15693 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15694 * unittests/scoped_fd-selftests.c: Fix common/ includes.
15695 * unittests/rsp-low-selftests.c: Fix common/ includes.
15696 * unittests/parse-connection-spec-selftests.c: Fix common/
15697 includes.
15698 * unittests/optional-selftests.c: Fix common/ includes.
15699 * unittests/offset-type-selftests.c: Fix common/ includes.
15700 * unittests/observable-selftests.c: Fix common/ includes.
15701 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15702 * unittests/memrange-selftests.c: Fix common/ includes.
15703 * unittests/memory-map-selftests.c: Fix common/ includes.
15704 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15705 * unittests/function-view-selftests.c: Fix common/ includes.
15706 * unittests/environ-selftests.c: Fix common/ includes.
15707 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15708 * unittests/common-utils-selftests.c: Fix common/ includes.
15709 * unittests/cli-utils-selftests.c: Fix common/ includes.
15710 * unittests/array-view-selftests.c: Fix common/ includes.
15711 * ui-file.c: Fix common/ includes.
15712 * tui/tui-io.c: Fix common/ includes.
15713 * tracepoint.h: Fix common/ includes.
15714 * tracepoint.c: Fix common/ includes.
15715 * tracefile-tfile.c: Fix common/ includes.
15716 * top.h: Fix common/ includes.
15717 * top.c: Fix common/ includes.
15718 * thread.c: Fix common/ includes.
15719 * target/waitstatus.h: Fix common/ includes.
15720 * target/waitstatus.c: Fix common/ includes.
15721 * target.h: Fix common/ includes.
15722 * target.c: Fix common/ includes.
15723 * target-memory.c: Fix common/ includes.
15724 * target-descriptions.c: Fix common/ includes.
15725 * symtab.h: Fix common/ includes.
15726 * symfile.c: Fix common/ includes.
15727 * stap-probe.c: Fix common/ includes.
15728 * spu-linux-nat.c: Fix common/ includes.
15729 * sparc-nat.c: Fix common/ includes.
15730 * source.c: Fix common/ includes.
15731 * solib.c: Fix common/ includes.
15732 * solib-target.c: Fix common/ includes.
15733 * ser-unix.c: Fix common/ includes.
15734 * ser-tcp.c: Fix common/ includes.
15735 * ser-pipe.c: Fix common/ includes.
15736 * ser-base.c: Fix common/ includes.
15737 * selftest-arch.c: Fix common/ includes.
15738 * s12z-tdep.c: Fix common/ includes.
15739 * rust-exp.y: Fix common/ includes.
15740 * rs6000-aix-tdep.c: Fix common/ includes.
15741 * riscv-tdep.c: Fix common/ includes.
15742 * remote.c: Fix common/ includes.
15743 * remote-notif.h: Fix common/ includes.
15744 * remote-fileio.h: Fix common/ includes.
15745 * remote-fileio.c: Fix common/ includes.
15746 * regcache.h: Fix common/ includes.
15747 * regcache.c: Fix common/ includes.
15748 * record-btrace.c: Fix common/ includes.
15749 * python/python.c: Fix common/ includes.
15750 * python/py-type.c: Fix common/ includes.
15751 * python/py-inferior.c: Fix common/ includes.
15752 * progspace.h: Fix common/ includes.
15753 * producer.c: Fix common/ includes.
15754 * procfs.c: Fix common/ includes.
15755 * proc-api.c: Fix common/ includes.
15756 * printcmd.c: Fix common/ includes.
15757 * ppc-linux-nat.c: Fix common/ includes.
15758 * parser-defs.h: Fix common/ includes.
15759 * osdata.c: Fix common/ includes.
15760 * obsd-nat.c: Fix common/ includes.
15761 * nat/x86-linux.c: Fix common/ includes.
15762 * nat/x86-linux-dregs.c: Fix common/ includes.
15763 * nat/x86-dregs.h: Fix common/ includes.
15764 * nat/x86-dregs.c: Fix common/ includes.
15765 * nat/ppc-linux.c: Fix common/ includes.
15766 * nat/mips-linux-watch.h: Fix common/ includes.
15767 * nat/mips-linux-watch.c: Fix common/ includes.
15768 * nat/linux-waitpid.c: Fix common/ includes.
15769 * nat/linux-ptrace.h: Fix common/ includes.
15770 * nat/linux-ptrace.c: Fix common/ includes.
15771 * nat/linux-procfs.c: Fix common/ includes.
15772 * nat/linux-personality.c: Fix common/ includes.
15773 * nat/linux-osdata.c: Fix common/ includes.
15774 * nat/linux-namespaces.c: Fix common/ includes.
15775 * nat/linux-btrace.h: Fix common/ includes.
15776 * nat/linux-btrace.c: Fix common/ includes.
15777 * nat/fork-inferior.c: Fix common/ includes.
15778 * nat/amd64-linux-siginfo.c: Fix common/ includes.
15779 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15780 * nat/aarch64-linux.c: Fix common/ includes.
15781 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15782 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15783 * namespace.h: Fix common/ includes.
15784 * mips-linux-tdep.c: Fix common/ includes.
15785 * minsyms.c: Fix common/ includes.
15786 * mi/mi-parse.h: Fix common/ includes.
15787 * mi/mi-main.c: Fix common/ includes.
15788 * mi/mi-cmd-env.c: Fix common/ includes.
15789 * memrange.h: Fix common/ includes.
15790 * memattr.c: Fix common/ includes.
15791 * maint.h: Fix common/ includes.
15792 * maint.c: Fix common/ includes.
15793 * main.c: Fix common/ includes.
15794 * machoread.c: Fix common/ includes.
15795 * location.c: Fix common/ includes.
15796 * linux-thread-db.c: Fix common/ includes.
15797 * linux-nat.c: Fix common/ includes.
15798 * linux-fork.c: Fix common/ includes.
15799 * inline-frame.c: Fix common/ includes.
15800 * infrun.c: Fix common/ includes.
15801 * inflow.c: Fix common/ includes.
15802 * inferior.h: Fix common/ includes.
15803 * inferior.c: Fix common/ includes.
15804 * infcmd.c: Fix common/ includes.
15805 * inf-ptrace.c: Fix common/ includes.
15806 * inf-child.c: Fix common/ includes.
15807 * ia64-linux-nat.c: Fix common/ includes.
15808 * i387-tdep.c: Fix common/ includes.
15809 * i386-tdep.c: Fix common/ includes.
15810 * i386-linux-tdep.c: Fix common/ includes.
15811 * i386-linux-nat.c: Fix common/ includes.
15812 * i386-go32-tdep.c: Fix common/ includes.
15813 * i386-fbsd-tdep.c: Fix common/ includes.
15814 * i386-fbsd-nat.c: Fix common/ includes.
15815 * guile/scm-type.c: Fix common/ includes.
15816 * guile/guile.c: Fix common/ includes.
15817 * go32-nat.c: Fix common/ includes.
15818 * gnu-nat.c: Fix common/ includes.
15819 * gdbthread.h: Fix common/ includes.
15820 * gdbarch-selftests.c: Fix common/ includes.
15821 * gdb_usleep.c: Fix common/ includes.
15822 * gdb_select.h: Fix common/ includes.
15823 * gdb_bfd.c: Fix common/ includes.
15824 * gcore.c: Fix common/ includes.
15825 * fork-child.c: Fix common/ includes.
15826 * findvar.c: Fix common/ includes.
15827 * fbsd-nat.c: Fix common/ includes.
15828 * event-top.c: Fix common/ includes.
15829 * event-loop.c: Fix common/ includes.
15830 * dwarf2read.c: Fix common/ includes.
15831 * dwarf2loc.c: Fix common/ includes.
15832 * dwarf2-frame.c: Fix common/ includes.
15833 * dwarf-index-cache.c: Fix common/ includes.
15834 * dtrace-probe.c: Fix common/ includes.
15835 * disasm-selftests.c: Fix common/ includes.
15836 * defs.h: Fix common/ includes.
15837 * csky-tdep.c: Fix common/ includes.
15838 * cp-valprint.c: Fix common/ includes.
15839 * cp-support.h: Fix common/ includes.
15840 * cp-support.c: Fix common/ includes.
15841 * corelow.c: Fix common/ includes.
15842 * completer.h: Fix common/ includes.
15843 * completer.c: Fix common/ includes.
15844 * compile/compile.c: Fix common/ includes.
15845 * compile/compile-loc2c.c: Fix common/ includes.
15846 * compile/compile-cplus-types.c: Fix common/ includes.
15847 * compile/compile-cplus-symbols.c: Fix common/ includes.
15848 * command.h: Fix common/ includes.
15849 * cli/cli-dump.c: Fix common/ includes.
15850 * cli/cli-cmds.c: Fix common/ includes.
15851 * charset.c: Fix common/ includes.
15852 * build-id.c: Fix common/ includes.
15853 * btrace.h: Fix common/ includes.
15854 * btrace.c: Fix common/ includes.
15855 * breakpoint.h: Fix common/ includes.
15856 * breakpoint.c: Fix common/ includes.
15857 * ax.h:
15858 (enum agent_op): Fix common/ includes.
15859 * ax-general.c (struct aop_map): Fix common/ includes.
15860 * ax-gdb.c: Fix common/ includes.
15861 * auxv.c: Fix common/ includes.
15862 * auto-load.c: Fix common/ includes.
15863 * arm-tdep.c: Fix common/ includes.
15864 * arch/riscv.c: Fix common/ includes.
15865 * arch/ppc-linux-common.c: Fix common/ includes.
15866 * arch/i386.c: Fix common/ includes.
15867 * arch/arm.c: Fix common/ includes.
15868 * arch/arm-linux.c: Fix common/ includes.
15869 * arch/arm-get-next-pcs.c: Fix common/ includes.
15870 * arch/amd64.c: Fix common/ includes.
15871 * arch/aarch64.c: Fix common/ includes.
15872 * arch/aarch64-insn.c: Fix common/ includes.
15873 * arch-utils.c: Fix common/ includes.
15874 * amd64-windows-tdep.c: Fix common/ includes.
15875 * amd64-tdep.c: Fix common/ includes.
15876 * amd64-sol2-tdep.c: Fix common/ includes.
15877 * amd64-obsd-tdep.c: Fix common/ includes.
15878 * amd64-nbsd-tdep.c: Fix common/ includes.
15879 * amd64-linux-tdep.c: Fix common/ includes.
15880 * amd64-linux-nat.c: Fix common/ includes.
15881 * amd64-fbsd-tdep.c: Fix common/ includes.
15882 * amd64-fbsd-nat.c: Fix common/ includes.
15883 * amd64-dicos-tdep.c: Fix common/ includes.
15884 * amd64-darwin-tdep.c: Fix common/ includes.
15885 * agent.c: Fix common/ includes.
15886 * ada-lang.h: Fix common/ includes.
15887 * ada-lang.c: Fix common/ includes.
15888 * aarch64-tdep.c: Fix common/ includes.
15889
15890 2019-01-25 Tom Tromey <tom@tromey.com>
15891
15892 * common/create-version.sh: Use common/version.h.
15893
15894 2019-01-24 Pedro Alves <palves@redhat.com>
15895
15896 * infrun.c (signal_stop, signal_print, signal_program)
15897 (signal_catch, signal_pass): Now arrays instead of pointers.
15898 (update_signals_program_target, do_target_resume)
15899 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15900 * linux-nat.c (linux_nat_target::pass_signals)
15901 (linux_nat_target::create_inferior, linux_nat_target::attach):
15902 Adjust.
15903 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15904 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15905 * procfs.c (procfs_target::pass_signals): Adjust.
15906 * record-full.c (record_full_target::resume): Adjust.
15907 * remote.c (remote_target::pass_signals)
15908 (remote_target::program_signals): Adjust.
15909 * target-debug.h (target_debug_print_signals): Now takes a
15910 gdb::array_view as parameter. Adjust.
15911 * target.h (target_ops) <pass_signals, program_signals>: Replace
15912 pointer and length parameters with gdb::array_view.
15913 (target_pass_signals, target_program_signals): Likewise.
15914 * target-delegates.c: Regenerate.
15915
15916 2019-01-24 Pedro Alves <palves@redhat.com>
15917
15918 * common/forward-scope-exit.h
15919 (forward_scope_exit::forward_scope_exit): Pass arguments to
15920 m_bind_function directly, instead of creating a std::bind and
15921 copying that.
15922
15923 2019-01-24 Alan Hayward <alan.hayward@arm.com>
15924
15925 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15926 for static members.
15927 (pass_in_v_vfp_candidate): Likewise.
15928
15929 2019-01-23 Tom Tromey <tom@tromey.com>
15930 Pedro Alves <palves@redhat.com>
15931
15932 * regcache.c (class regcache_invalidator): Remove.
15933 (regcache::raw_write): Use make_scope_exit.
15934
15935 2019-01-23 Tom Tromey <tom@tromey.com>
15936
15937 * ui-out.h (class ui_out_emit_type): Update comment.
15938
15939 2019-01-23 Tom Tromey <tom@tromey.com>
15940
15941 * infrun.c (fetch_inferior_event): Update comment.
15942
15943 2019-01-23 Tom Tromey <tom@tromey.com>
15944 Pedro Alves <palves@redhat.com>
15945
15946 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15947 parameter.
15948 (fetch_inferior_event): Use SCOPE_EXIT.
15949
15950
15951 2019-01-23 Tom Tromey <tom@tromey.com>
15952 Pedro Alves <palves@redhat.com>
15953
15954 * infrun.c (disable_thread_events): Delete.
15955 (stop_all_threads): Use SCOPE_EXIT.
15956
15957 2019-01-23 Tom Tromey <tom@tromey.com>
15958 Pedro Alves <palves@redhat.com>
15959
15960 * symfile.c: Include forward-scope-exit.h.
15961 (clear_symtab_users_cleanup): Replace forward declaration with
15962 a FORWARD_SCOPE_EXIT.
15963 (syms_from_objfile_1): Use the forward_scope_exit and
15964 gdb::optional instead of cleanup_function.
15965 (reread_symbols): Use the forward_scope_exit instead of
15966 cleanup_function.
15967 (clear_symtab_users_cleanup): Remove function.
15968
15969 2019-01-23 Tom Tromey <tom@tromey.com>
15970 Pedro Alves <palves@redhat.com>
15971
15972 * linux-nat.c: Include scope-exit.h.
15973 (cleanup_target_stop): Remove.
15974 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15975 SCOPE_EXIT.
15976
15977 2019-01-23 Tom Tromey <tom@tromey.com>
15978 Pedro Alves <palves@redhat.com>
15979
15980 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15981 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15982
15983 2019-01-23 Tom Tromey <tom@tromey.com>
15984 Andrew Burgess <andrew.burgess@embecosm.com>
15985 Pedro Alves <palves@redhat.com>
15986
15987 * infrun.c (fetch_inferior_event): Use scope_exit.
15988 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15989 * top.c (execute_command): Use scope_exit.
15990 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15991 * utils.c (do_bpstat_clear_actions_cleanup)
15992 (make_bpstat_clear_actions_cleanup): Remove.
15993
15994 2019-01-23 Tom Tromey <tom@tromey.com>
15995 Pedro Alves <palves@redhat.com>
15996
15997 * infrun.c: Include "common/scope-exit.h"
15998 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15999 (wait_for_inferior): Use SCOPE_EXIT.
16000 (fetch_inferior_event): Use scope_exit.
16001
16002 2019-01-23 Tom Tromey <tom@tromey.com>
16003 Pedro Alves <palves@redhat.com>
16004
16005 * breakpoint.c (create_breakpoint): Remove cleanup.
16006
16007 2019-01-23 Tom Tromey <tom@tromey.com>
16008 Andrew Burgess <andrew.burgess@embecosm.com>
16009 Pedro Alves <palves@redhat.com>
16010
16011 2019-01-23 Pedro Alves <palves@redhat.com>
16012
16013 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
16014
16015 2019-01-23 Pedro Alves <palves@redhat.com>
16016 Andrew Burgess <andrew.burgess@embecosm.com>
16017
16018 * gdbthread.h: Include "common/forward-scope-exit.h".
16019 (scoped_finish_thread_state): Redefine custom class in terms of
16020 forward_scope_exit.
16021
16022 2019-01-23 Pedro Alves <palves@redhat.com>
16023 Andrew Burgess <andrew.burgess@embecosm.com>
16024
16025 * common/forward-scope-exit.h: New file.
16026
16027 2019-01-23 Pedro Alves <palves@redhat.com>
16028 Andrew Burgess <andrew.burgess@embecosm.com>
16029 Tom Tromey <tom@tromey.com>
16030
16031 * common/scope-exit.h: New file.
16032
16033 2019-01-23 Pedro Alves <palves@redhat.com>
16034
16035 * common/preprocessor.h (ESC): Rename to ...
16036 (ESC_PARENS): ... this.
16037 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
16038 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
16039
16040 2019-01-23 Tom Tromey <tom@tromey.com>
16041
16042 * language.h (class scoped_switch_to_sym_language_if_auto):
16043 Initialize m_lang in both cases.
16044
16045 2019-01-23 Alan Hayward <alan.hayward@arm.com>
16046
16047 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
16048 with XCNEW.
16049
16050 2019-01-22 Tom Tromey <tom@tromey.com>
16051
16052 * corelow.c: Do not include sys/file.h.
16053
16054 2019-01-22 Tom Tromey <tom@tromey.com>
16055
16056 * tui/tui-wingeneral.h: Include gdb_curses.h.
16057
16058 2019-01-22 Tom Tromey <tom@tromey.com>
16059
16060 * source-cache.h (class source_cache) <get_source_lines,
16061 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
16062
16063 2019-01-22 Tom Tromey <tom@tromey.com>
16064
16065 * remote-fileio.h (struct remote_target): Declare.
16066
16067 2019-01-22 Tom Tromey <tom@tromey.com>
16068
16069 * python/py-arch.c: Do not include py-ref.h.
16070 * python/py-bpevent.c: Do not include py-ref.h.
16071 * python/py-cmd.c: Do not include py-ref.h.
16072 * python/py-continueevent.c: Do not include py-ref.h.
16073 * python/py-event.h: Do not include py-ref.h.
16074 * python/py-evtregistry.c: Do not include py-ref.h.
16075 * python/py-finishbreakpoint.c: Do not include py-ref.h.
16076 * python/py-frame.c: Do not include py-ref.h.
16077 * python/py-framefilter.c: Do not include py-ref.h.
16078 * python/py-function.c: Do not include py-ref.h.
16079 * python/py-infevents.c: Do not include py-ref.h.
16080 * python/py-linetable.c: Do not include py-ref.h.
16081 * python/py-objfile.c: Do not include py-ref.h.
16082 * python/py-param.c: Do not include py-ref.h.
16083 * python/py-prettyprint.c: Do not include py-ref.h.
16084 * python/py-progspace.c: Do not include py-ref.h.
16085 * python/py-symbol.c: Do not include py-ref.h.
16086 * python/py-symtab.c: Do not include py-ref.h.
16087 * python/py-type.c: Do not include py-ref.h.
16088 * python/py-unwind.c: Do not include py-ref.h.
16089 * python/py-utils.c: Do not include py-ref.h.
16090 * python/py-value.c: Do not include py-ref.h.
16091 * python/py-varobj.c: Do not include py-ref.h.
16092 * python/py-xmethods.c: Do not include py-ref.h.
16093 * python/python.c: Do not include py-ref.h.
16094 * varobj.c: Do not include py-ref.h.
16095
16096 2019-01-22 Tom Tromey <tom@tromey.com>
16097
16098 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
16099 keyword for bcache.
16100
16101 2019-01-22 Tom Tromey <tom@tromey.com>
16102
16103 * compile/compile-cplus-types.c: Remove a comment by #include.
16104
16105 2019-01-22 Tom Tromey <tom@tromey.com>
16106
16107 * compile/gcc-c-plugin.h: Include compile-internal.h.
16108
16109 2019-01-22 Tom Tromey <tom@tromey.com>
16110
16111 * stabsread.c (EXTERN): Do not define.
16112 (symnum, next_symbol_text_func, processing_gcc_compilation)
16113 (within_function, global_sym_chain, global_stabs)
16114 (previous_stab_code, this_object_header_files)
16115 (n_this_object_header_files)
16116 (n_allocated_this_object_header_files): Define.
16117 * stabsread.h (EXTERN): Never define. Use "extern".
16118
16119 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16120
16121 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
16122 history_value.
16123
16124 2019-01-21 Tom Tromey <tom@tromey.com>
16125
16126 * ui-out.c: Fix includes.
16127 * tui/tui-source.c: Fix includes.
16128 * target.c: Fix includes.
16129 * remote.c: Fix includes.
16130 * regcache.c: Fix includes.
16131 * python/py-block.c: Fix includes.
16132 * printcmd.c: Fix includes.
16133 * or1k-tdep.c: Fix includes.
16134 * mi/mi-main.c: Fix includes.
16135 * m32r-tdep.c: Fix includes.
16136 * csky-tdep.c: Fix includes.
16137 * compile/compile-cplus-types.c: Fix includes.
16138 * cli/cli-interp.c: Fix includes.
16139
16140 2019-01-21 Alan Hayward <alan.hayward@arm.com>
16141
16142 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
16143 for padding.
16144
16145 2019-01-16 Tom Tromey <tom@tromey.com>
16146
16147 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
16148 earlier.
16149 (struct objfile) <msymbols_range>: Move from top level.
16150 <msymbols>: New method.
16151 (class objfile_msymbols): Remove.
16152 * symtab.c (default_collect_symbol_completion_matches_break_on):
16153 Update.
16154 * symmisc.c (dump_msymbols): Update.
16155 * stabsread.c (scan_file_globals): Update.
16156 * objc-lang.c (info_selectors_command, info_classes_command)
16157 (find_methods): Update.
16158 * minsyms.c (find_solib_trampoline_target): Update.
16159 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16160 * coffread.c (coff_symfile_read): Update.
16161 * ada-lang.c (ada_lookup_simple_minsym)
16162 (ada_collect_symbol_completion_matches): Update.
16163
16164 2019-01-16 Tom Tromey <tom@tromey.com>
16165
16166 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16167 type. Remove no-argument constructor.
16168 <iterator::operator++>: Simplify.
16169 <begin>: Update.
16170 <end>: Use minimal_symbol_count.
16171
16172 2019-01-16 Tom Tromey <tom@tromey.com>
16173
16174 * objfiles.h (struct objfile) <psymtabs>: New method.
16175 (class objfile_psymtabs): Remove.
16176 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16177 typedef.
16178 <range>: New method.
16179 (require_partial_symbols): Change return type.
16180 * psymtab.c (require_partial_symbols)
16181 (psym_expand_symtabs_matching): Update.
16182 * mdebugread.c (parse_partial_symbols): Update.
16183 * dbxread.c (dbx_end_psymtab): Update.
16184
16185 2019-01-15 Tom Tromey <tom@tromey.com>
16186
16187 * symtab.c (lookup_objfile_from_block)
16188 (lookup_symbol_in_objfile_symtabs)
16189 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16190 (find_line_symtab, info_sources_command)
16191 (default_collect_symbol_completion_matches_break_on)
16192 (make_source_files_completion_list): Update.
16193 * symmisc.c (print_objfile_statistics, dump_objfile)
16194 (maintenance_print_symbols, maintenance_info_symtabs)
16195 (maintenance_check_symtabs, maintenance_info_line_tables):
16196 Update.
16197 * source.c (select_source_symtab)
16198 (forget_cached_source_info_for_objfile): Update.
16199 * objfiles.h (class objfile_compunits): Remove.
16200 (struct objfile) <compunits_range>: New typedef.
16201 (compunits): New method.
16202 * objfiles.c (objfile_relocate1): Update.
16203 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16204 * maint.c (count_symtabs_and_blocks): Update.
16205 * linespec.c (iterate_over_all_matching_symtabs): Update.
16206 * cp-support.c (add_symbol_overload_list_qualified): Update.
16207 * coffread.c (coff_symtab_read): Update.
16208 * ada-lang.c (add_nonlocal_symbols)
16209 (ada_collect_symbol_completion_matches)
16210 (ada_add_global_exceptions): Update.
16211
16212 2019-01-15 Tom Tromey <tom@tromey.com>
16213
16214 * progspace.h (program_space) <objfiles_safe_range>: New
16215 typedef.
16216 <objfiles_safe>: New method.
16217 * objfiles.h (class all_objfiles_safe): Remove.
16218 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16219 * jit.c (jit_inferior_exit_hook): Update.
16220
16221 2019-01-17 Tom Tromey <tom@tromey.com>
16222
16223 * progspace.h (program_space) <objfiles_range>: New typedef.
16224 <objfiles>: New method.
16225 <objfiles_head>: Rename from objfiles.
16226 (object_files): Update.
16227 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16228 * guile/scm-pretty-print.c
16229 (ppscm_find_pretty_printer_from_objfiles): Update.
16230 * guile/scm-objfile.c (gdbscm_objfiles): Update.
16231 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16232 Update.
16233 * python/py-progspace.c (pspy_get_objfiles): Update.
16234 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16235 Update.
16236 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16237 (objfpy_lookup_objfile_by_build_id): Update.
16238 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16239 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16240 Update.
16241 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16242 (expand_symtab_containing_pc, lookup_objfile_from_block)
16243 (lookup_static_symbol, basic_lookup_transparent_type)
16244 (find_pc_sect_compunit_symtab, find_symbol_at_address)
16245 (find_line_symtab, info_sources_command)
16246 (default_collect_symbol_completion_matches_break_on)
16247 (make_source_files_completion_list, find_main_name): Update.
16248 * symmisc.c (print_symbol_bcache_statistics)
16249 (print_objfile_statistics, maintenance_print_symbols)
16250 (maintenance_print_msymbols, maintenance_print_objfiles)
16251 (maintenance_info_symtabs, maintenance_check_symtabs)
16252 (maintenance_expand_symtabs, maintenance_info_line_tables):
16253 Update.
16254 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16255 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16256 (map_overlay_command, unmap_overlay_command)
16257 (simple_overlay_update, expand_symtabs_matching)
16258 (map_symbol_filenames): Update.
16259 * symfile-debug.c (set_debug_symfile): Update.
16260 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16261 Update.
16262 * source.c (select_source_symtab, forget_cached_source_info):
16263 Update.
16264 * solib.c (solib_read_symbols): Update.
16265 * solib-spu.c (append_ocl_sos): Update.
16266 * psymtab.c (maintenance_print_psymbols)
16267 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16268 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16269 * printcmd.c (info_symbol_command): Update.
16270 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16271 Update.
16272 * objfiles.h (class all_objfiles): Remove.
16273 * objfiles.c (have_partial_symbols, have_full_symbols)
16274 (have_minimal_symbols, qsort_cmp, update_section_map)
16275 (shared_objfile_contains_address_p)
16276 (default_iterate_over_objfiles_in_search_order): Update.
16277 * objc-lang.c (info_selectors_command, info_classes_command)
16278 (find_methods): Update.
16279 * minsyms.c (find_solib_trampoline_target): Update.
16280 * maint.c (maintenance_info_sections)
16281 (maintenance_translate_address, count_symtabs_and_blocks):
16282 Update.
16283 * main.c (captured_main_1): Update.
16284 * linux-thread-db.c (try_thread_db_load_from_pdir)
16285 (has_libpthread): Update.
16286 * linespec.c (iterate_over_all_matching_symtabs)
16287 (search_minsyms_for_name): Update.
16288 * jit.c (jit_find_objf_with_entry_addr): Update.
16289 * hppa-tdep.c (find_unwind_entry)
16290 (hppa_lookup_stub_minimal_symbol): Update.
16291 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16292 Update.
16293 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16294 (elf_gnu_ifunc_resolve_by_got): Update.
16295 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16296 * dwarf-index-write.c (save_gdb_index_command): Update.
16297 * cp-support.c (add_symbol_overload_list_qualified): Update.
16298 * breakpoint.c (create_overlay_event_breakpoint)
16299 (create_longjmp_master_breakpoint)
16300 (create_std_terminate_master_breakpoint)
16301 (create_exception_master_breakpoint): Update.
16302 * blockframe.c (find_pc_partial_function): Update.
16303 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16304 (ada_collect_symbol_completion_matches)
16305 (ada_add_global_exceptions): Update.
16306
16307 2019-01-17 Tom Tromey <tom@tromey.com>
16308
16309 * solib-target.c (lm_info_target_p): Remove typedef. Don't
16310 declare VEC.
16311 (solib_target_parse_libraries): Change return type.
16312 (library_list_start_segment, library_list_start_section)
16313 (library_list_end_library, library_list_start_library); Update.
16314 (solib_target_free_library_list): Remove.
16315 (solib_target_parse_libraries): Remove cleanup. Change return
16316 type.
16317 (solib_target_current_sos): Update.
16318
16319 2019-01-17 Tom Tromey <tromey@bapiya>
16320
16321 * valprint.c: Replace "the the" with "the".
16322 * symtab.c: Replace "the the" with "the".
16323 * solib.c: Replace "the the" with "the".
16324 * solib-dsbt.c: Replace "the the" with "the".
16325 * linespec.c: Replace "the the" with "the".
16326 * dwarf2loc.h: Replace "the the" with "the".
16327 * amd64-windows-tdep.c: Replace "the the" with "the".
16328 * aarch64-tdep.c: Replace "the the" with "the".
16329
16330 2019-01-16 Keith Seitz <keiths@redhat.com>
16331
16332 PR gdb/23773
16333 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16334 <builder>: Rename to ..
16335 <m_builder>: ... this and make private.
16336 (dwarf2_cu::get_builder): New method. Change all users of
16337 `builder' to use this method.
16338 (dwarf2_start_symtab): Move to ...
16339 (dwarf2_cu::start_symtab): ... here. Update all callers
16340 (setup_type_unit_groups): Move to ...
16341 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
16342 callers.
16343 (dwarf2_cu::reset_builder): New method.
16344 (process_full_compunit, process_full_type_unit): Use
16345 dwarf2_cu::reset_builder.
16346 (follow_die_offset): Record the ancestor CU if it is different
16347 from the followed DIE's CU.
16348 (follow_die_sig_1): Likewise.
16349
16350 2019-01-15 Tom Tromey <tom@tromey.com>
16351
16352 * remote.c (class remote_state) <buf>: Now a char_vector.
16353 <buf_size>: Remove.
16354 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
16355 parameter.
16356 (remote_target::getpkt_or_notif_sane_1)
16357 (remote_target::getpkt_sane)
16358 (remote_target::getpkt_or_notif_sane): Likewise.
16359 (class remote_target) <putpkt>: New overload.
16360 (remote_target::read_frame): Change type of "buf_p". Remove
16361 sizeof_p parameter.
16362 (packet_ok): New overload.
16363 (packet_check_result): New overload.
16364 Update all uses.
16365
16366 2019-01-14 Tom Tromey <tom@tromey.com>
16367
16368 * remote-notif.c (handle_notification, remote_notif_ack)
16369 (remote_notif_parse): Make "buf" const.
16370 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16371 const.
16372 (remote_notif_parse, remote_notif_ack, handle_notification):
16373 Likewise.
16374 * remote.c (remote_notif_stop_parse): Make "buf" const.
16375 (remote_target::remote_parse_stop_reply): Make "buf" const.
16376 (remote_notif_stop_ack): Make "buf" const.
16377
16378 2019-01-14 Tom Tromey <tom@tromey.com>
16379
16380 * remote.c (remote_console_output): Make parameter const.
16381
16382 2019-01-14 Tom Tromey <tom@tromey.com>
16383
16384 * target-debug.h (target_debug_print_signals): Constify.
16385 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16386 * procfs.c (procfs_target::pass_signals): Update.
16387 * linux-nat.c (linux_nat_target::pass_signals): Update.
16388 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16389 * target-delegates.c: Rebuild.
16390 * remote.c (remote_target::program_signals): Update.
16391 (remote_target::pass_signals): Update.
16392 * target.c (target_pass_signals): Constify argument.
16393 (target_program_signals): Likewise.
16394 * target.h (struct target_ops) <pass_signals, program_signals>:
16395 Constify argument.
16396 (target_pass_signals, target_program_signals): Constify argument.
16397
16398 2019-01-14 Tom Tromey <tom@tromey.com>
16399
16400 PR tui/28819:
16401 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16402
16403 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
16404
16405 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16406 field.
16407 * rs6000-tdep.c: Include reggroups.h.
16408 (IS_V_ALIAS_PSEUDOREG): Define.
16409 (rs6000_register_name): Return names for the "vX" aliases.
16410 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16411 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
16412 aliases. Call default_register_reggroup_p for all other
16413 pseudo-registers.
16414 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16415 New functions.
16416 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16417 Handle "vX" aliases.
16418 (v_alias_pseudo_register_collect): New function.
16419 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16420 (rs6000_gdbarch_init): Initialize "vX" aliases as
16421 pseudo-registers. Restore registration of
16422 rs6000_pseudo_register_reggroup_p with
16423 set_tdesc_pseudo_register_reggroup_p.
16424
16425 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
16426
16427 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16428 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16429 set_gdbarch_num_pseudo_regs.
16430
16431 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16432
16433 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16434 Remove arg prefixname, add do_set and do_show.
16435 Add member functions set_list and show_list.
16436 * cli/cli-style.c (class cli_style_option): Update accordingly.
16437 (style_set_list): Move to file scope.
16438 (style_show_list): Likewise.
16439 (set_style): Call help_list.
16440 (show_style): Call cmd_show_list.
16441 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16442 Update to use the new macro.
16443
16444 2019-10-12 Joel Brobecker <brobecker@adacore.com>
16445
16446 * ada-lang.c (_initialize_ada_language): Expand the help text
16447 for the "catch exception" command.
16448
16449 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16450
16451 * symtab.c (matching_obj_sections): Initialize obj,
16452 declare it closer to its usage.
16453
16454 2019-01-10 Tom Tromey <tom@tromey.com>
16455
16456 * thread-iter.h (inf_threads_iterator): Use next_iterator.
16457 (basic_inf_threads_range): Remove.
16458 (inf_threads_range, inf_non_exited_threads_range)
16459 (safe_inf_threads_range): Use next_adapter.
16460
16461 2019-01-10 Keith Seitz <keiths@redhat.com>
16462
16463 PR gdb/23712
16464 PR symtab/23010
16465 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16466 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16467
16468 2019-01-10 Keith Seitz <keiths@redhat.com>
16469
16470 PR gdb/23712
16471 PR symtab/23010
16472 * dictionary.c (pending_to_vector): Remove.
16473 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16474 Remove _1 suffix, replacing functions of the same name. Update
16475 all callers.
16476 (dict_create_hashed, dict_create_hashed_expandable)
16477 (dict_create_linear, dict_create_linear_expandable, dict_free)
16478 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16479 Make functions static.
16480
16481 2019-01-10 Keith Seitz <keiths@redhat.com>
16482
16483 PR gdb/23712
16484 PR symtab/23010
16485 * dictionary.h (struct dictionary): Replace declaration with
16486 multidictionary.
16487 (dict_create_hashed, dict_create_hashed_expandable)
16488 (dict_create_linear, dict_create_linear_expandable)
16489 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16490 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16491 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16492 taking multidictionary argument.
16493 [ALL_DICT_SYMBOLS]: Update for multidictionary.
16494 * block.h (struct block) <dict>: Change to multidictionary
16495 and rename `multidict'.
16496 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16497 symmisc.c: Update all dictionary references to multidictionary.
16498
16499 2019-01-10 Keith Seitz <keiths@redhat.com>
16500
16501 PR gdb/23712
16502 PR symtab/23010
16503 * dictionary.c: Include unordered_map.
16504 (pending_to_vector): New function.
16505 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16506 Rewrite the non-"_1" functions to take vector instead
16507 of linked list.
16508 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16509 "new" _1 versions of the same name.
16510 (multidictionary): Define.
16511 (std::hash<enum language): New definition.
16512 (collate_pending_symbols_by_language, mdict_create_hashed)
16513 (mdict_create_hashed_expandable, mdict_create_linear)
16514 (mdict_create_linear_expandable, mdict_free)
16515 (find_language_dictionary, create_new_language_dictionary)
16516 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16517 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16518 (mdict_size, mdict_empty): New functions.
16519 * dictionary.h (mdict_iterator): Define.
16520
16521 2019-01-10 Pedro Alves <palves@redhat.com>
16522
16523 * breakpoint.c (read_uploaded_action)
16524 (create_tracepoint_from_upload): Adjust to use
16525 gdb::unique_xmalloc_ptr.
16526 * ctf.c (ctf_write_uploaded_tp):
16527 (SET_ARRAY_FIELD): Use emplace_back.
16528 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16529 * tracefile-tfile.c (tfile_write_uploaded_tp):
16530 * tracepoint.c (parse_tracepoint_definition): Adjust to use
16531 gdb::unique_xmalloc_ptr.
16532 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16533 at_string, cond_string, cmd_strings>: Replace char pointers
16534 with gdb::unique_xmalloc_ptr.
16535
16536 2019-01-10 Pedro Alves <palves@redhat.com>
16537
16538 * solib-target.c (library_list_start_library): Don't xstrdup name.
16539
16540 2019-01-10 Pedro Alves <palves@redhat.com>
16541
16542 * mdebugread.c (parse_partial_symbols): Use
16543 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16544
16545 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16546
16547 * linux-fork.c (scoped_switch_fork_info)
16548 <~scoped_switch_fork_info>: Fix incorrect variable name.
16549
16550 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
16551
16552 * linux-fork.c (scoped_switch_fork_info)
16553 <scoped_switch_fork_info>: Make explicit.
16554 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16555
16556 2019-01-10 Tom Tromey <tom@tromey.com>
16557
16558 * objfiles.h (objfile::reset_psymtabs): Update.
16559 * objfiles.c (objfile::objfile): Update.
16560 * psymtab.h (psymtab_storage::obstack): Update.
16561 (psymtab_storage::m_obstack): Use gdb::optional.
16562 (class psymtab_storage): Update comment. Remove objfile
16563 parameter.
16564 * psymtab.c (psymtab_storage::psymtab_storage): Update.
16565
16566 2019-01-10 Tom Tromey <tom@tromey.com>
16567
16568 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16569 <free_psymtabs>: Now private.
16570 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16571 (allocate_psymtab): Use new method.
16572
16573 2019-01-10 Tom Tromey <tom@tromey.com>
16574
16575 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16576 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16577 * mdebugread.c (parse_partial_symbols): Use
16578 allocate_dependencies.
16579 * dwarf2read.c (dwarf2_create_include_psymtab): Use
16580 allocate_dependencies.
16581 (process_psymtab_comp_unit_reader)
16582 (build_type_psymtab_dependencies): Likewise.
16583 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16584
16585 2019-01-10 Tom Tromey <tom@tromey.com>
16586
16587 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16588 PSYMBOL_SET_LANGUAGE.
16589 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16590
16591 2019-01-10 Tom Tromey <tom@tromey.com>
16592
16593 * psymtab.h (psymtab_storage::obstack): New method.
16594 <m_obstack>: Rename from obstack; now private.
16595 * psymtab.c (psymtab_storage): Update.
16596 * dwarf2read.c (create_addrmap_from_index)
16597 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16598 Update.
16599
16600 2019-01-10 Tom Tromey <tom@tromey.com>
16601
16602 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16603 * objfiles.h (objfile::reset_psymtabs): New method.
16604
16605 2019-01-10 Tom Tromey <tom@tromey.com>
16606
16607 * symmisc.c (print_symbol_bcache_statistics): Update.
16608 (print_objfile_statistics): Update.
16609 * symfile.c (reread_symbols): Update.
16610 * psymtab.h (class psymtab_storage): New.
16611 * psymtab.c (psymtab_storage): New constructor.
16612 (~psymtab_storage): New destructor.
16613 (require_partial_symbols): Update.
16614 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16615 (find_pc_sect_psymtab, find_pc_sect_psymbol)
16616 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16617 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16618 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16619 (start_psymtab_common, end_psymtab_common)
16620 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16621 (allocate_psymtab): Update.
16622 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16623 Update.
16624 (dump_psymtab_addrmap, maintenance_print_psymbols)
16625 (maintenance_check_psymtabs): Update.
16626 (class objfile_psymtabs): Move to objfiles.h.
16627 * psympriv.h (discard_psymtab): Now inline.
16628 (psymtab_discarder::psymtab_discarder): Update.
16629 (psymtab_discarder::~psymtab_discarder): Update.
16630 (ALL_OBJFILE_PSYMTABS): Rewrite.
16631 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16632 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16633 Remove fields.
16634 <partial_symtabs>: New field.
16635 (class objfile_psymtabs): Move from psymtab.h. Update.
16636 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16637 psymbol_cache.
16638 (objfile::~objfile): Don't destroy psymbol_cache.
16639 * mdebugread.c (parse_partial_symbols): Update.
16640 * dwarf2read.c (create_addrmap_from_index)
16641 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16642 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16643 (add_partial_subprogram, dwarf2_ranges_read): Update.
16644 * dwarf-index-write.c (write_address_map)
16645 (write_one_signatured_type, recursively_write_psymbols)
16646 (class debug_names, class debug_names, write_psymtabs_to_index):
16647 Update.
16648
16649 2019-01-10 Tom Tromey <tom@tromey.com>
16650
16651 * symtab.h (SYMBOL_SET_NAMES): Update.
16652 (symbol_set_names): Update.
16653 (MSYMBOL_SET_NAMES): Update.
16654 * symtab.c (symbol_set_names): Change argument to be an
16655 objfile_per_bfd_storage.
16656 * psymtab.c (add_psymbol_to_bcache): Update.
16657 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16658
16659 2019-01-10 Tom Tromey <tom@tromey.com>
16660
16661 * symtab.c (create_demangled_names_hash): Change argument to be an
16662 objfile_per_bfd_storage.
16663 (symbol_set_names): Update.
16664
16665 2019-01-10 Tom Tromey <tom@tromey.com>
16666
16667 * xcoffread.c (xcoff_initial_scan): Unconditionally call
16668 init_psymbol_list.
16669 * psymtab.c (init_psymbol_list): Do nothing if already called.
16670 * psympriv.h (init_psymbol_list): Add comment.
16671 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16672 init_psymbol_list.
16673 * dbxread.c (dbx_symfile_read): Unconditionally call
16674 init_psymbol_list.
16675
16676 2019-01-10 Tom Tromey <tom@tromey.com>
16677
16678 * xcoffread.c (scan_xcoff_symtab): Update.
16679 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16680 "where".
16681 * mdebugread.c (parse_partial_symbols)
16682 (handle_psymbol_enumerators): Update.
16683 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16684 * dbxread.c (read_dbx_symtab): Update.
16685 * psympriv.h (psymbol_placement): New enum.
16686 (add_psymbol_to_list): Update.
16687
16688 2019-01-10 Tom Tromey <tom@tromey.com>
16689
16690 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16691 static_psymbols parameters.
16692 (scan_xcoff_symtab): Update.
16693 * psymtab.c (start_psymtab_common): Remove global_psymbols and
16694 static_psymbols parameters.
16695 * psympriv.h (start_psymtab_common): Update.
16696 * mdebugread.c (parse_partial_symbols): Update.
16697 * dwarf2read.c (create_partial_symtab): Update.
16698 * dbxread.c (read_dbx_symtab): Update.
16699 (start_psymtab): Remove global_psymbols and static_psymbols
16700 parameters.
16701
16702 2019-01-10 Tom Tromey <tom@tromey.com>
16703
16704 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16705 * psymtab.c (allocate_psymtab): Add comment.
16706 * psympriv.h (allocate_psymtab): Add comment.
16707 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16708 initializations.
16709 * dbxread.c (dbx_end_psymtab): Remove some initializations.
16710
16711 2019-01-10 Tom Tromey <tom@tromey.com>
16712
16713 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16714 Don't declare.
16715 * mipsread.c: Include mdebugread.h.
16716 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16717 Declare.
16718 * elfread.c: Include mdebugread.h.
16719
16720 2019-01-09 Tom Tromey <tom@tromey.com>
16721
16722 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16723 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16724 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16725 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16726 (psym_lookup_symbol, psym_find_last_source_symtab)
16727 (psym_forget_cached_source_info, psym_print_stats)
16728 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16729 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16730 (psym_map_matching_symbols, psym_expand_symtabs_matching)
16731 (psym_find_compunit_symtab_by_address)
16732 (maintenance_print_psymbols, maintenance_info_psymtabs)
16733 (maintenance_check_psymtabs): Use ranged for.
16734 * psymtab.h (class objfile_psymtabs): New.
16735 (require_partial_symbols): Return objfile_psymtabs.
16736 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16737
16738 2019-01-09 Tom Tromey <tom@tromey.com>
16739
16740 * symfile.c (overlay_invalidate_all, find_pc_overlay)
16741 (find_pc_mapped_section, list_overlays_command)
16742 (map_overlay_command, unmap_overlay_command)
16743 (simple_overlay_update): Use all_objfiles.
16744 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16745 * printcmd.c (info_symbol_command): Use all_objfiles.
16746 * objfiles.h (ALL_OBJSECTIONS): Remove.
16747 * maint.c (maintenance_translate_address): Use all_objfiles.
16748 * gcore.c (gcore_create_callback): Use all_objfiles.
16749 (objfile_find_memory_regions): Likewise.
16750
16751 2019-01-09 Tom Tromey <tom@tromey.com>
16752
16753 * symtab.c (find_line_symtab, info_sources_command)
16754 (make_source_files_completion_list): Use objfile_compunits.
16755 * source.c (select_source_symtab): Use objfile_compunits.
16756 * objfiles.h (struct objfile): Update comment.
16757 (ALL_OBJFILES): Remove.
16758 (ALL_FILETABS): Remove.
16759 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16760 objfile_compunits.
16761
16762 2019-01-09 Tom Tromey <tom@tromey.com>
16763
16764 * symmisc.c (print_objfile_statistics, dump_objfile)
16765 (maintenance_print_symbols): Use compunit_filetabs.
16766 * source.c (forget_cached_source_info_for_objfile): Use
16767 compunit_filetabs.
16768 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16769 (ALL_FILETABS): Use compunit_filetabs.
16770 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16771 * coffread.c (coff_symtab_read): Use compunit_filetabs.
16772
16773 2019-01-09 Tom Tromey <tom@tromey.com>
16774
16775 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16776 (compunit_filetabs): New.
16777 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16778 compunit_filetabs.
16779 (info_sources_command, make_source_files_completion_list): Remove
16780 declaration.
16781 * symmisc.c (print_objfile_statistics, dump_objfile)
16782 (maintenance_print_symbols): Remove declaration.
16783 (maintenance_info_symtabs): Use compunit_filetabs.
16784 (maintenance_info_line_tables): Likewise.
16785 * source.c (select_source_symtab): Change local variable name.
16786 (forget_cached_source_info_for_objfile): Remove declaration.
16787 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16788 * objfiles.c (objfile_relocate1): Remove declaration.
16789 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16790 declaration.
16791 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16792 * coffread.c (coff_symtab_read): Remove declaration.
16793 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16794 compunit_filetabs.
16795
16796 2019-01-09 Tom Tromey <tom@tromey.com>
16797
16798 * symtab.c (lookup_objfile_from_block)
16799 (find_pc_sect_compunit_symtab, search_symbols)
16800 (default_collect_symbol_completion_matches_break_on): Use
16801 objfile_compunits.
16802 * objfiles.h (ALL_COMPUNITS): Remove.
16803 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16804 * cp-support.c (add_symbol_overload_list_qualified): Use
16805 objfile_compunits.
16806 * ada-lang.c (ada_collect_symbol_completion_matches)
16807 (ada_add_global_exceptions): Use objfile_compunits.
16808
16809 2019-01-09 Tom Tromey <tom@tromey.com>
16810
16811 * source.c (select_source_symtab)
16812 (forget_cached_source_info_for_objfile): Remove declaration.
16813 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16814 declaration.
16815 * maint.c (count_symtabs_and_blocks): Remove declaration.
16816 * cp-support.c (add_symbol_overload_list_qualified): Remove
16817 declaration.
16818 * coffread.c (coff_symtab_read): Remove declaration.
16819 * symtab.c (lookup_symbol_in_objfile_symtabs)
16820 (basic_lookup_transparent_type_1): Use objfile_compunits.
16821 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16822 (info_sources_command, search_symbols)
16823 (default_collect_symbol_completion_matches_break_on)
16824 (make_source_files_completion_list): Remove declaration.
16825 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16826 (ada_collect_symbol_completion_matches)
16827 (ada_add_global_exceptions): Remove declaration.
16828 * linespec.c (iterate_over_all_matching_symtabs): Use
16829 objfile_compunits.
16830 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16831 (class objfile_compunits): New.
16832 (ALL_COMPUNITS): Use objfile_compunits.
16833 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16834 (maintenance_check_symtabs, maintenance_info_line_tables): Use
16835 objfile_compunits.
16836 * objfiles.c (objfile_relocate1): Use objfile_compunits.
16837
16838 2019-01-09 Tom Tromey <tom@tromey.com>
16839
16840 * symtab.c (search_symbols)
16841 (default_collect_symbol_completion_matches_break_on): Use
16842 objfile_msymbols.
16843 * ada-lang.c (ada_lookup_simple_minsym)
16844 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16845 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16846 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16847 objfile_msymbols.
16848 * coffread.c (coff_symfile_read): Use objfile_msymbols.
16849 * symmisc.c (dump_msymbols): Use objfile_msymbols.
16850 * objc-lang.c (find_methods): Use objfile_msymbols.
16851 (info_selectors_command, info_classes_command): Likewise.
16852 * stabsread.c (scan_file_globals): Use objfile_msymbols.
16853 * objfiles.h (class objfile_msymbols): New.
16854 (ALL_OBJFILE_MSYMBOLS): Remove.
16855 (ALL_MSYMBOLS): Remove.
16856
16857 2019-01-09 Tom Tromey <tom@tromey.com>
16858
16859 * common/next-iterator.h (next_adapter): Add Iterator template
16860 parameter.
16861 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16862 (class all_objfiles_safe): New.
16863 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16864 * objfiles.c (put_objfile_before): Update comment.
16865 (add_separate_debug_objfile): Likewise.
16866 (free_all_objfiles): Use all_objfiles_safe.
16867 (objfile_purge_solibs): Likewise.
16868
16869 2019-01-09 Tom Tromey <tom@tromey.com>
16870
16871 * symtab.c (iterate_over_symtabs, matching_obj_sections)
16872 (expand_symtab_containing_pc, lookup_static_symbol)
16873 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16874 (find_symbol_at_address, find_line_symtab, find_main_name): Use
16875 all_objfiles.
16876 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16877 * breakpoint.c (create_overlay_event_breakpoint)
16878 (create_longjmp_master_breakpoint)
16879 (create_std_terminate_master_breakpoint)
16880 (create_exception_master_breakpoint): Use all_objfiles.
16881 * linux-thread-db.c (try_thread_db_load_from_pdir)
16882 (has_libpthread): Use all_objfiles.
16883 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16884 * linespec.c (iterate_over_all_matching_symtabs)
16885 (search_minsyms_for_name): Use all_objfiles.
16886 * maint.c (maintenance_info_sections): Use all_objfiles.
16887 * main.c (captured_main_1): Use all_objfiles.
16888 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16889 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16890 * guile/scm-pretty-print.c
16891 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16892 * solib-spu.c (append_ocl_sos): Use all_objfiles.
16893 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16894 (maintenance_print_msymbols): Use all_objfiles.
16895 * source.c (select_source_symtab): Use all_objfiles.
16896 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16897 * symfile.c (remove_symbol_file_command)
16898 (expand_symtabs_matching, map_symbol_filenames): Use
16899 all_objfiles.
16900 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16901 all_objfiles.
16902 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16903 * objc-lang.c (find_methods): Use all_objfiles.
16904 * objfiles.c (have_partial_symbols, have_full_symbols)
16905 (have_minimal_symbols, qsort_cmp)
16906 (default_iterate_over_objfiles_in_search_order): Use
16907 all_objfiles.
16908 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16909 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16910 (maintenance_check_psymtabs): Use all_objfiles.
16911 (ALL_PSYMTABS): Remove.
16912 * compile/compile-object-run.c (do_module_cleanup): Use
16913 all_objfiles.
16914 * blockframe.c (find_pc_partial_function): Use all_objfiles.
16915 * cp-support.c (add_symbol_overload_list_qualified): Use
16916 all_objfiles.
16917 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16918 Use all_objfiles.
16919 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16920 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16921 all_objfiles.
16922 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16923 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16924 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16925 Uses all_objfiles.
16926 * solib.c (solib_read_symbols): Use all_objfiles
16927
16928 2019-01-09 Tom Tromey <tom@tromey.com>
16929
16930 * probe.c (parse_probes_in_pspace): Use all_objfiles.
16931 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16932 all_objfiles.
16933 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16934 * symmisc.c (print_symbol_bcache_statistics)
16935 (print_objfile_statistics, maintenance_print_objfiles)
16936 (maintenance_info_symtabs, maintenance_check_symtabs)
16937 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16938 all_objfiles.
16939 * source.c (forget_cached_source_info): Use all_objfiles.
16940 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16941 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16942 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16943 * objfiles.c (update_section_map): Use all_objfiles.
16944 (shared_objfile_contains_address_p): Likewise.
16945 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16946 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16947
16948 2019-01-09 Tom Tromey <tom@tromey.com>
16949
16950 * common/next-iterator.h: New file.
16951 * objfiles.h (class all_objfiles): New.
16952 (struct objfile_iterator): New.
16953
16954 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16955
16956 * NEWS: Move the description of the changed "frame", "select-frame",
16957 and "info frame" commands to the Changed commands section.
16958
16959 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
16960
16961 * gdbtypes.c (check_stub_method_group): Remove handling of old
16962 mangling schemes.
16963 * linespec.c (find_methods): Likewise.
16964 * stabsread.c (read_member_functions): Likewise.
16965 * valops.c (search_struct_method): Likewise.
16966 (value_struct_elt_for_reference): Likewise.
16967 * NEWS: Mention this change.
16968
16969 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16970
16971 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16972 print_source_lines.
16973 * source.c (print_source_lines_base): Update line number check.
16974 (print_source_lines): New function.
16975 (source_lines_range::source_lines_range): New function.
16976 * source.h (class source_lines_range): New class.
16977 (print_source_lines): New declaration.
16978
16979 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16980
16981 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16982
16983 2019-01-08 Tom Tromey <tom@tromey.com>
16984 Simon Marchi <simon.marchi@ericsson.com>
16985
16986 PR gdb/24060
16987 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16988 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16989 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16990 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16991 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16992 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16993
16994 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16995
16996 * source.c (select_source_symtab): Move header comment to
16997 declaration in source.h.
16998 (forget_cached_source_info_for_objfile): Likewise.
16999 (forget_cached_source_info): Likewise.
17000 (identify_source_line): Likewise.
17001 * source.h (identify_source_line): Move declaration from symtab.h
17002 and add comment from source.c
17003 (print_source_lines): Likewise.
17004 (forget_cached_source_info_for_objfile): Likewise.
17005 (forget_cached_source_info): Likewise.
17006 (select_source_symtab): Likewise.
17007 (enum print_source_lines_flag): Move definition from symtab.h.
17008 * symtab.h (identify_source_line): Move declaration to source.h.
17009 (print_source_lines): Likewise.
17010 (forget_cached_source_info_for_objfile): Likewise.
17011 (forget_cached_source_info): Likewise.
17012 (select_source_symtab): Likewise.
17013 (enum print_source_lines_flag): Move definition to source.h.
17014 * tui/tui-hooks.c: Add 'source.h' include.
17015
17016 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
17017
17018 * source.c (print_source_lines_base): Handle requests to print
17019 reverse line number sequences, and guard against empty lines
17020 string.
17021
17022 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
17023
17024 * source.c (print_source_lines_base): Fix skip of '\r' if next
17025 character is '\n'.
17026
17027 2019-01-06 Tom Tromey <tom@tromey.com>
17028
17029 * c-exp.y (struct c_parse_state) <macro_original_text,
17030 expansion_obstack>: New member.
17031 (macro_original_text, expansion_obstack): Remove globals.
17032 (scan_macro_expansion, scanning_macro_expansion)
17033 (finished_macro_expansion): Update.
17034 (scan_macro_cleanup): Remove.
17035 (yylex, c_parse): Update.
17036
17037 2019-01-06 Tom Tromey <tom@tromey.com>
17038
17039 * c-exp.y (struct c_parse_state) <strings>: New member.
17040 (operator_stoken): Update.
17041
17042 2019-01-06 Tom Tromey <tom@tromey.com>
17043
17044 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
17045 (union type_stack_elt) <typelist_val>: Now a pointer to
17046 std::vector.
17047 (type_stack_cleanup): Don't declare.
17048 (push_typelist): Update.
17049 * parse.c (pop_typelist): Return a std::vector.
17050 (push_typelist): Take a std::vector.
17051 (follow_types): Update. Do not free args.
17052 (type_stack_cleanup): Remove.
17053 * c-exp.y (struct c_parse_state): New.
17054 (cpstate): New global.
17055 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
17056 (nonempty_typelist): Update.
17057 (func_mod): Create a new vector.
17058 (c_parse): Create a c_parse_state.
17059 (check_parameter_typelist): Do not delete params.
17060 (function_method): Update. Do not delete type_list.
17061
17062 2019-01-06 Tom Tromey <tom@tromey.com>
17063
17064 PR gdb/28155:
17065 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
17066 check_typedef.
17067 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
17068 (print_return_value): Likewise.
17069
17070 2019-01-05 Tom Tromey <tom@tromey.com>
17071
17072 * contrib/cleanup_check.py: Remove.
17073 * contrib/gcc-with-excheck: Remove.
17074 * contrib/exsummary.py: Remove.
17075 * contrib/excheck.py: Remove.
17076
17077 2019-01-05 Joel Brobecker <brobecker@adacore.com>
17078
17079 * thread.c (delete_thread_1): Add gdb_assert that THR is not
17080 NULL. Initialize tpprev to NULL instead of assigning it
17081 to NULL on the next statement.
17082 * windows-nat.c (windows_delete_thread): Remove check for
17083 main_thread_id before printing thread exit notifications.
17084 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
17085 Remove thread ID check against main_thread_id.
17086 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
17087 windows_delete_thread.
17088 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
17089
17090 2019-01-04 Tom Tromey <tom@tromey.com>
17091
17092 * compile/compile.c (_initialize_compile): Use upper case for
17093 metasyntactic variables.
17094 * symmisc.c (_initialize_symmisc): Use upper case for
17095 metasyntactic variables.
17096 * psymtab.c (_initialize_psymtab): Use upper case for
17097 metasyntactic variables.
17098 * demangle.c (demangle_command): Use upper case for metasyntactic
17099 variables.
17100 (_initialize_demangler): Likewise.
17101 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
17102 variables.
17103
17104 2019-01-03 Tom Tromey <tom@tromey.com>
17105
17106 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
17107
17108 2019-01-03 Tom Tromey <tom@tromey.com>
17109
17110 * python/py-symtab.c (salpy_str): Update.
17111 (struct salpy_sal_object) <symtab>: Now a PyObject.
17112 (salpy_dealloc): Update.
17113 (del_objfile_sal): Use gdbpy_ref.
17114
17115 2019-01-03 Tom Tromey <tom@tromey.com>
17116
17117 * python/py-type.c (convert_field): Use new_reference. Return
17118 gdbpy_ref.
17119 (make_fielditem): Return gdbpy_ref.
17120 (typy_fields): Update.
17121 (typy_getitem): Update.
17122 (field_name): Return gdbpy_ref. Use new_reference.
17123 (typy_iterator_iternext): Update.
17124
17125 2019-01-03 Tom Tromey <tom@tromey.com>
17126
17127 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
17128
17129 2019-01-03 Tom Tromey <tom@tromey.com>
17130
17131 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
17132 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
17133 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
17134 (pspy_set_frame_filters, pspy_set_frame_unwinders)
17135 (pspy_set_type_printers): Likewise.
17136 * python/py-function.c (fnpy_init): Use gdbpy_ref.
17137 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
17138 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
17139 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
17140 (objfpy_set_type_printers): Likewise.
17141
17142 2019-01-03 Tom Tromey <tom@tromey.com>
17143
17144 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
17145 (gdbpy_print_stack): Use gdbpy_err_fetch.
17146 * python/python-internal.h (class gdbpy_err_fetch): New class.
17147 (class gdbpy_enter) <m_error_type, m_error_value,
17148 m_error_traceback>: Remove.
17149 <m_error>: New member.
17150 (gdbpy_exception_to_string): Don't declare.
17151 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17152 * python/py-value.c (convert_value_from_python): Use
17153 gdbpy_err_fetch.
17154 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17155 gdbpy_exception_to_string.
17156 (gdbpy_handle_exception): Use gdbpy_err_fetch.
17157 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17158 gdbpy_err_fetch.
17159
17160 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17161
17162 * linux-nat.c (delete_lwp_cleanup): Delete.
17163 (struct lwp_deleter): New struct.
17164 (lwp_info_up): New typedef.
17165 (linux_nat_target::follow_fork): Delete cleanup, and make use of
17166 lwp_info_up.
17167
17168 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17169
17170 * linux-fork.c (class scoped_switch_fork_info): New class.
17171 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17172
17173 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17174
17175 * valops.c (find_overload_match): Remove use of null_cleanup, and
17176 calls to do_cleanups.
17177
17178 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17179
17180 * compile/compile-cplus-types.c
17181 (compile_cplus_instance::decl_name): Handle changes to
17182 cp_func_name.
17183 * cp-support.c (cp_func_name): Update header comment, update
17184 return type.
17185 * cp-support.h (cp_func_name): Update return type in declaration.
17186 * valops.c (find_overload_match): Move temp_func local to top
17187 level of function and change its type. Use temp_func to hold and
17188 delete temporary string obtained from cp_func_name.
17189
17190 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
17191
17192 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17193 gdb::char_vector, remove cleanup, and update uses of `msg`.
17194
17195 2019-01-03 Jim Wilson <jimw@sifive.com>
17196
17197 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17198
17199 2019-01-02 Tom Tromey <tom@tromey.com>
17200
17201 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17202 (tdesc_parse_xml): Remove cleanups.
17203 * target-descriptions.h (make_cleanup_free_target_description):
17204 Don't declare.
17205 (target_desc_deleter): New struct.
17206 (target_desc_up): New typedef.
17207 * target-descriptions.c (target_desc_deleter::operator()): Rename
17208 from free_target_description.
17209 (make_cleanup_free_target_description): Remove.
17210
17211 2019-01-02 Tom Tromey <tom@tromey.com>
17212
17213 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
17214 constructor, destructor.
17215 (linespec_parser): Remove typedef.
17216 (~linespec_parser): Rename from linespec_parser_delete.
17217 (linespec_lex_to_end, linespec_complete_label)
17218 (linespec_complete): Update.
17219 (decode_line_full): Remove cleanups.
17220 (decode_line_1): Update.
17221
17222 2019-01-02 Tom Tromey <tom@tromey.com>
17223
17224 * python/python-internal.h (inferior_to_inferior_object): Change
17225 return type.
17226 * python/py-exitedevent.c (create_exited_event_object): Update.
17227 * python/py-inferior.c (inferior_to_inferior_object): Return
17228 gdbpy_ref.
17229 (python_new_inferior, python_inferior_deleted)
17230 (thread_to_thread_object, delete_thread_object)
17231 (build_inferior_list, gdbpy_selected_inferior): Update.
17232 * python/py-infthread.c (create_thread_object): Update. Also fail
17233 if inferior_to_inferior_object fails.
17234
17235 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
17236
17237 * inferior.h (class inferior) <displaced_step_state>: New field.
17238 * infrun.h (struct displaced_step_state): Move here from
17239 infrun.c. Initialize fields, add constructor.
17240 <inf>: Remove field.
17241 <reset>: New method.
17242 * infrun.c (struct displaced_step_inferior_state): Move to
17243 infrun.h.
17244 (displaced_step_inferior_states): Remove.
17245 (get_displaced_stepping_state): Adust.
17246 (displaced_step_in_progress_any_inferior): Adjust.
17247 (displaced_step_in_progress_thread): Adjust.
17248 (displaced_step_in_progress): Adjust.
17249 (add_displaced_stepping_state): Remove.
17250 (get_displaced_step_closure_by_addr): Adjust.
17251 (remove_displaced_stepping_state): Remove.
17252 (infrun_inferior_exit): Call displaced_step_state.reset.
17253 (use_displaced_stepping): Don't check for NULL.
17254 (displaced_step_prepare_throw): Call
17255 get_displaced_stepping_state.
17256 (displaced_step_fixup): Don't check for NULL.
17257 (prepare_for_detach): Don't check for NULL.
17258
17259 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17260
17261 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17262 in case of call that did not complete.
17263
17264 2019-01-02 Andrey Utkin <autkin@undo.io>
17265
17266 * symfile.c (find_separate_debug_file): Fix search of debug files for
17267 remote debuggee.
17268
17269 2019-01-02 Tom Tromey <tom@tromey.com>
17270
17271 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17272 indentation.
17273 * python/py-frame.c (frapy_older): Remove cast.
17274 (frapy_newer): Likewise.
17275 * python/py-breakpoint.c (local_setattro): Remove cast.
17276 * python/py-arch.c (archpy_name): Remove local variable.
17277 * python/py-type.c (gdbpy_lookup_type): Remove cast.
17278
17279 2019-01-02 Joel Brobecker <brobecker@adacore.com>
17280
17281 * unittests/basic_string_view/element_access/char/empty.cc:
17282 Fix year range in copyright header.
17283
17284 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
17285
17286 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17287 Delete.
17288 <operator==>: Update with for removed field.
17289 <hash>: Likewise.
17290 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17291 <isa_features>: ...this.
17292 <abi_features>: New field.
17293 (riscv_isa_flen): Update comment.
17294 (riscv_abi_xlen): New declaration.
17295 (riscv_abi_flen): New declaration.
17296 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17297 isa_features.
17298 (riscv_abi_xlen): New function.
17299 (riscv_isa_flen): Update to get answer from isa_features.
17300 (riscv_abi_flen): New function.
17301 (riscv_has_fp_abi): Update to get answer from abi_features.
17302 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17303 xlen and flen.
17304 (riscv_call_info) <xlen, flen>: Update comment.
17305 (riscv_call_arg_struct): Remove invalid assertions
17306 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17307 is removed.
17308 (riscv_gdbarch_init): Gather isa features and abi features
17309 separately, ensure both match on the gdbarch when reusing an old
17310 gdbarch. Relax an error check to allow 32-bit abi float to run on
17311 a target with 64-bit float hardware.
17312
17313 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17314
17315 * source.c (search_command_helper): Stop reverse search
17316 when line 1 has been searched.
17317
17318 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17319
17320 * record-full.c (record_full_base_target::close): Rewrite
17321 record_full_core_buf_list free logic.
17322
17323 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
17324
17325 * break-catch-syscall.c (print_one_catch_syscall): xfree
17326 the last text.
17327
17328 2019-01-01 Joel Brobecker <brobecker@adacore.com>
17329
17330 * top.c (print_gdb_version): Update Copyright year in version
17331 message.
17332
17333 2019-01-01 Joel Brobecker <brobecker@adacore.com>
17334
17335 Update copyright year range in all GDB files.
17336
17337 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
17338
17339 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17340
17341 For older changes see ChangeLog-2018.
17342 \f
17343 Local Variables:
17344 mode: change-log
17345 left-margin: 8
17346 fill-column: 74
17347 version-control: never
17348 coding: utf-8
17349 End:
17350
This page took 0.365314 seconds and 3 git commands to generate.