ee45156e391bcc0dd152f009b0ce8f7d20655f21
[deliverable/binutils-gdb.git] / gdb / ChangeLog
1 2019-12-07 Keith Seitz <keiths@redhat.com>
2
3 * build-id.c (build_id_bfd_get): Permit bfd_core, too.
4 (build_id_to_debug_bfd): Make static, rewriting to use
5 build_id_to_bfd_suffix.
6 (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
7 adding `suffix' parameter. Append SUFFIX to file names
8 when searching for matching files.
9 (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
10 (build_id_to_exec_bfd): Likewise.
11 * build-id.h (build_id_to_debug_bfd): Clarify that function
12 searches for BFD of debug info file.
13 (build_id_to_exec_bfd): Declare.
14 * corelow.c: Include build-id.h.
15 (locate_exec_from_corefile_build_id): New function.
16 (core_target_open): If no executable BFD is found,
17 search for a core file BFD using build-id.
18
19 2019-12-06 Christian Biesinger <cbiesinger@google.com>
20
21 * bcache.c: Put in namespace gdb.
22 * bcache.h: Likewise.
23 * gdbtypes.c (check_types_worklist): Update.
24 (types_deeply_equal): Update.
25 * macrotab.c (struct macro_table) <bcache>: Update.
26 (new_macro_table): Update.
27 * macrotab.h (struct bcache): Put this forward declaration
28 inside namespace gdb.
29 (new_macro_table): Update.
30 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
31 Update.
32 <macro_cache>: Update.
33 * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
34
35 2019-12-06 Tom de Vries <tdevries@suse.de>
36
37 PR symtab/24971
38 * block.c (best_symbol, better_symbol): New function.
39 (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
40 decl.
41
42 2019-12-06 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
43
44 * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
45 * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
46 for ranking see-through reference cases.
47
48 2019-12-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
49 * stack.c (faas_command): Check a command is provided.
50 * thread.c (taas_command, tfaas_command): Likewise.
51
52 2019-12-05 Philippe Waroquiers <philippe.waroquiers@skynet.be>
53 * inferior.c (prune_inferiors): Only call delete_inferior,
54 Do not modify the inferior list.
55
56 2019-12-05 Simon Marchi <simon.marchi@polymtl.ca>
57
58 * c-exp.y: Update calls to lookup_typename,
59 lookup_signed_typename and lookup_unsigned_typename.
60 * c-lang.c (evaluate_subexp_c): Likewise.
61 * cp-namespace.c (cp_lookup_symbol_imports_or_template):
62 Likewise.
63 * eval.c (binop_promote): Likewise.
64 * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
65 (lookup_unsigned_typename): Likewise.
66 (lookup_signed_typename): Likewise.
67 * gdbtypes.h (lookup_unsigned_typename): Likewise.
68 (lookup_signed_typename): Likewise.
69 (lookup_typename): Likewise.
70 * guile/scm-type.c (tyscm_lookup_typename): Update calls to
71 lookup_typename, lookup_signed_typename,
72 lookup_unsigned_typename.
73 * m2-exp.y: Likewise.
74 * printcmd.c (printf_wide_c_string): Likewise.
75 (ui_printf): Likewise.
76 * python/py-type.c (typy_lookup_typename): Likewise.
77 * python/py-xmethods.c (python_xmethod_worker::invoke):
78 Likewise.
79 * rust-exp.y: Likewise.
80
81 2019-12-04 Christian Biesinger <cbiesinger@google.com>
82
83 * configure.nat (obsd64): Add missing files x86-nat.o and
84 nat/x86-dregs.o.
85
86 2019-12-04 Tom Tromey <tom@tromey.com>
87
88 * valprint.c (val_print_string): Use metadata_style.
89 * go-valprint.c (print_go_string): Use metadata style.
90 * p-valprint.c (pascal_object_print_static_field): Use metadata
91 style.
92 * cp-valprint.c (cp_print_static_field): Use metadata style.
93
94 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
95 Chris January <chris.january@arm.com>
96
97 * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
98 tokens.
99 (typebase): New patterns for complex, single/double precision, and
100 single/double complex.
101 (f77_keywords): Change token for complex keyword, and add single,
102 double, and precision keywords.
103
104 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
105
106 * avr-tdep.c (_initialize_avr_tdep): Improve help of command
107 "info io_registers".
108
109 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
110
111 * regcache.c (cooked_read_test): Initialize thread list of
112 mock_inferior.
113
114 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
115
116 * aarch64-linux-tdep.c: Remove includes.
117
118 2019-12-04 Simon Marchi <simon.marchi@polymtl.ca>
119
120 * aarch64-tdep.c: Remove includes.
121
122 2019-12-04 Simon Marchi <simon.marchi@efficios.com>
123
124 * filtered-iterator.h (filtered_iterator) <operator==,
125 operator!=>: Compare wrapped iterators, not wrapped pointers.
126 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
127 unittests/filtered_iterator-selftests.c.
128 * unittests/filtered_iterator-selftests.c: New file.
129
130 2019-12-04 Tom Tromey <tromey@adacore.com>
131
132 * gdbtypes.c (create_range_type): Inherit endianity
133 from base type.
134
135 2019-12-04 Tom Tromey <tromey@adacore.com>
136
137 * ada-lang.c (decode_constrained_packed_array)
138 (ada_value_assign, value_assign_to_component): Update.
139 * dwarf2loc.c (rw_pieced_value, access_memory)
140 (dwarf2_compile_expr_to_ax): Update.
141 * dwarf2read.c (dwarf2_add_field): Update.
142 * eval.c (evaluate_subexp_standard): Update.
143 * gdbarch.c, gdbarch.h: Rebuild.
144 * gdbarch.sh (bits_big_endian): Remove.
145 * gdbtypes.h (union field_location): Update comment.
146 * target-descriptions.c (make_gdb_type): Update.
147 * valarith.c (value_bit_index): Update.
148 * value.c (struct value) <bitpos>: Update comment.
149 (unpack_bits_as_long, modify_field): Update.
150 * value.h (value_bitpos): Update comment.
151
152 2019-12-04 Tom Tromey <tromey@adacore.com>
153
154 * gdbtypes.c (type_byte_order): Move earlier. Assert for unknown
155 endian-ness.
156
157 2019-12-04 Tom Tromey <tromey@adacore.com>
158
159 * dwarf2read.c (dwarf2_init_float_type)
160 (dwarf2_init_complex_target_type): Add byte_order parameter.
161 (read_base_type): Compute byte order earlier.
162 * gdbtypes.c (init_float_type): Add byte_order parameter.
163 * gdbtypes.h (init_float_type): Add byte_order parameter.
164
165 2019-12-04 Tom Tromey <tromey@adacore.com>
166
167 * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
168
169 2019-12-04 Tom Tromey <tromey@adacore.com>
170
171 * dwarf2read.c (process_structure_scope): Initialize
172 "discr_offset".
173
174 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
175
176 * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
177 add it into the search spec.
178 (parse_max_results_option): New function.
179 (mi_info_functions_or_variables): Parse -max-results flag and pass
180 it to mi_symbol_info.
181 (mi_cmd_symbol_info_modules): Likewise.
182 (mi_cmd_symbol_info_types): Likewise.
183 * symtab.c (global_symbol_searcher::add_matching_symbols): Change
184 return type to bool, change result container into a set, and don't
185 add new results if we have enough already.
186 (global_symbol_searcher::add_matching_msymbols): Change return
187 type to bool, and don't add new results if we have enough already.
188 (sort_search_symbols_remove_dups): Delete.
189 (global_symbol_searcher::search): Early exit from search loop when
190 we have enough results. Use a std::set to collect the results
191 from calling add_matching_symbols.
192 * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
193 member function.
194 (global_symbol_searcher) <m_max_search_results>: New member
195 variable.
196 (global_symbol_searcher) <add_matching_symbols>: Update header
197 comment and change return type to bool.
198 (global_symbol_searcher) <add_matching_msymbols>: Update header
199 comment and change return type to bool.
200
201 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
202
203 * symtab.c (symbol_search::compare_search_syms): Update header
204 comment.
205 (global_symbol_searcher::is_suitable_msymbol): New function.
206 (global_symbol_searcher::expand_symtabs): New function.
207 (global_symbol_searcher::add_matching_symbols): New function.
208 (global_symbol_searcher::add_matching_msymbols): New function.
209 (global_symbol_searcher::search): Move most of the content
210 into the new functions above, and call them as needed.
211 * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
212 function.
213 (global_symbol_searcher) <add_matching_symbols>: New member
214 function.
215 (global_symbol_searcher) <add_matching_msymbols>: New member
216 function.
217 (global_symbol_searcher) <is_suitable_msymbol>: New member
218 function.
219
220 2019-12-04 Andrew Burgess <andrew.burgess@embecosm.com>
221
222 * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
223 -symbol-info-module-variables entries.
224 * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
225 (mi_cmd_symbol_info_module_variables): Declare.
226 * mi/mi-symbol-cmds.c
227 (module_symbol_search_iterator): New typedef.
228 (output_module_symbols_in_single_module_and_file): New function.
229 (output_module_symbols_in_single_module): New function.
230 (mi_info_module_functions_or_variables): New function.
231 (mi_cmd_symbol_info_module_functions): New function.
232 (mi_cmd_symbol_info_module_variables): New function.
233 * NEWS: Mention new MI command.
234
235 2019-12-03 Christian Biesinger <cbiesinger@google.com>
236
237 * bcache.c (hash): Remove.
238 (hash_continue): Remove.
239 * bcache.h (hash): Remove.
240 (hash_continue): Remove.
241 (struct bcache) <ctor>: Update.
242 * psymtab.c (psymbol_hash): Update.
243 * stabsread.c (hashname): Update.
244 * utils.h (fast_hash): Add an argument for a start value,
245 defaulting to zero.
246
247 2019-12-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
248 * symtab.c (symbol_cache_clear_slot): Move close to cleared type.
249 (destroy_block_symbol_cache): New function.
250 (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
251 (resize_symbol_cache): Likewise.
252
253 2019-12-02 Tom Tromey <tom@tromey.com>
254
255 * unittests/tui-selftests.c (run_tests): Make conditional.
256 (_initialize_tui_selftest): Make conditional.
257
258 2019-12-02 Christian Biesinger <cbiesinger@google.com>
259
260 * aix-thread.c (debug_aix_thread): Change type to bool.
261
262 2019-12-02 Luis Machado <luis.machado@linaro.org>
263
264 * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
265
266 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
267
268 * dwarf2read.c (read_tag_string_type): Read the fields required to
269 make a dynamic string, and possibly create a dynamic range for the
270 string.
271 (attr_to_dynamic_prop): Setup is_reference based on the type of
272 attribute being processed.
273 * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
274 (resolve_dynamic_array): Rename to...
275 (resolve_dynamic_array_or_string): ...this, update header comment,
276 and accept TYPE_CODE_STRING.
277 (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
278
279 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
280
281 * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
282 of its implementation from...
283 (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
284 the new function.
285
286 2019-12-01 Andrew Burgess <andrew.burgess@embecosm.com>
287
288 * dwarf2read.c (read_subrange_type): Read bit and byte stride and
289 create a range with stride where appropriate.
290 * f-valprint.c: Include 'gdbarch.h'.
291 (f77_print_array_1): Take the stride into account when walking the
292 array. Also convert the stride into addressable units.
293 * gdbtypes.c (create_range_type): Initialise the stride to
294 constant zero.
295 (create_range_type_with_stride): New function, initialise the
296 range as normal, and then setup the stride.
297 (has_static_range): Include the stride here. Also change the
298 return type to bool.
299 (create_array_type_with_stride): Consider the range stride if the
300 array isn't given its own stride.
301 (resolve_dynamic_range): Resolve the stride if needed.
302 * gdbtypes.h (struct range_bounds) <stride>: New member variable.
303 (struct range_bounds) <flag_is_byte_stride>: New member variable.
304 (TYPE_BIT_STRIDE): Define.
305 (TYPE_ARRAY_BIT_STRIDE): Define.
306 (create_range_type_with_stride): Declare.
307 * valarith.c (value_subscripted_rvalue): Take range stride into
308 account when walking the array.
309
310 2019-12-01 Tom Tromey <tom@tromey.com>
311
312 * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
313 specially.
314
315 2019-12-01 Tom Tromey <tom@tromey.com>
316
317 * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
318 \0.
319 * unittests/tui-selftests.c: New file.
320 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
321
322 2019-12-01 Tom Tromey <tom@tromey.com>
323
324 * tui/tui.c (tui_enable): Call tui_update_variables earlier.
325
326 2019-12-01 Tom Tromey <tom@tromey.com>
327
328 * NEWS: Document new settings.
329 * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
330 * tui/tui-win.c (_initialize_tui_win): Add border style
331 observers.
332 * tui/tui-io.h (tui_apply_style): Declare.
333 * tui/tui-io.c (tui_apply_style): Rename from apply_style. No
334 longer static.
335 (apply_ansi_escape, tui_set_reverse_mode): Update.
336 * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
337 Add "skip_intensity" parameter.
338 <changed>: New member.
339 <do_set_value>: Declare.
340 (tui_border_style, tui_active_border_style): Declare.
341 * cli/cli-style.c (tui_border_style, tui_active_border_style): New
342 globals.
343 (cli_style_option): Initialize "changed".
344 (cli_style_option::do_set_value): New function.
345 (cli_style_option::add_setshow_commands): Add "skip_intensity"
346 parameter. Update.
347 (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
348 (_initialize_cli_style): Update. Create TUI border style
349 commands.
350
351 2019-12-01 Tom Tromey <tom@tromey.com>
352
353 * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
354 parameter.
355 * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
356 parameter.
357 * tui/tui-win.h (compact_source): Declare.
358 * tui/tui-win.c (compact_source): New global.
359 (tui_set_compact_source, tui_show_compact_source): New functions.
360 (_initialize_tui_win): Add "compact-source" setting.
361 * tui/tui-source.c (tui_source_window::set_contents): Handle
362 compact_source setting.
363 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
364 * NEWS: Document new setting.
365
366 2019-11-30 Tom Tromey <tom@tromey.com>
367
368 * dwarf2read.c (dwarf2_add_field): Include field offset when
369 computing variant part length.
370
371 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
372 * NEWS: Mention define-prefix. Tell that command names can now
373 contain a . character.
374
375 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
376
377 * command.h (valid_cmd_char_p): Declare.
378 * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
379 the check of valid command char.
380 (find_command_name_length, valid_user_defined_cmd_name_p): Use
381 valid_cmd_char_p.
382 * cli/cli-script.c (validate_comname): Likewise.
383 * completer.c (gdb_completer_command_word_break_characters):
384 Do not remove . from the word break char, update comments.
385 (complete_line_internal_1): Use valid_cmd_char_p.
386 * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
387 * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
388
389 2019-11-30 Philippe Waroquiers <philippe.waroquiers@skynet.be>
390
391 * cli/cli-script.c (do_define_command): Ensure a redefined
392 prefix command is kept as a prefix command.
393 (define_prefix_command): New function.
394 (show_user_1): Report user defined prefixes.
395 (_initialize_cli_script): Create the new 'define-prefix' command.
396 Add completers for 'define' and 'document'.
397 * top.c (execute_command): If command is a user-defined prefix only
398 command, report the list of commands for this prefix command.
399
400 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
401
402 * valops.c (find_oload_champ): Improve debug output.
403
404 2019-11-29 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
405
406 * valops.c (find_oload_champ): Print part of debug messages
407 before the badness vector is std::move'd.
408
409 2019-11-28 Tom Tromey <tom@tromey.com>
410
411 * value.c (creal_internal_fn): Fix comment.
412
413 2019-11-28 Tom Tromey <tom@tromey.com>
414
415 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
416 flag_bound_evaluated>: Now unsigned.
417
418 2019-11-28 Tom Tromey <tom@tromey.com>
419
420 * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
421 declare.
422
423 2019-11-28 Mihails Strasuns <mihails.strasuns@intel.com>
424
425 * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
426 debug output.
427 * jit.c (jit_unregister_code): Add debug print to match
428 `jit_register_code`.
429
430 2019-11-27 Christian Biesinger <cbiesinger@google.com>
431
432 * NEWS: Mention the new multithreaded symbol loading.
433
434 2019-11-27 Christian Biesinger <cbiesinger@google.com>
435
436 * maint.c (n_worker_threads): Default to 0.
437 (worker_threads_disabled): New function.
438 * maint.h (worker_threads_disabled): New function.
439 * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
440 here if worker_threads_disabled () is true.
441 (minimal_symbol_reader::install): Skip all threading if
442 worker_threads_disabled () is true.
443
444 2019-11-27 Christian Biesinger <cbiesinger@google.com>
445
446 * minsyms.c (add_minsym_to_hash_table): Use a previously computed
447 hash code if possible.
448 (add_minsym_to_demangled_hash_table): Likewise.
449 (minimal_symbol_reader::install): Compute the hash codes for msymbol
450 on the background thread.
451 * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
452 Add these fields.
453
454 2019-11-27 Christian Biesinger <cbiesinger@google.com>
455
456 * minsyms.c (minimal_symbol_reader::install): Also compute the hash
457 of the mangled name on the background thread.
458 * symtab.c (symbol_set_names): Allow passing in the hash of the
459 linkage_name.
460 * symtab.h (symbol_set_names): Likewise.
461
462 2019-11-27 Kevin Buettner <kevinb@redhat.com>
463
464 * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
465 physnames are computed for inherited DIEs.
466
467 2019-11-27 Tom Tromey <tromey@adacore.com>
468
469 * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
470 backslashes.
471 * cp-support.c: Remove unnecessary backslashes.
472
473 2019-11-27 Christian Biesinger <cbiesinger@google.com>
474
475 * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
476 with sym->set_linkage_name.
477 * coffread.c (coff_read_enum_type): Likewise.
478 * mdebugread.c (parse_symbol): Likewise.
479 * stabsread.c (patch_block_stabs): Likewise.
480 (define_symbol): Likewise.
481 (read_enum_type): Likewise.
482 (common_block_end): Likewise.
483 * symtab.h (struct general_symbol_info) <set_linkage_name>: New
484 function.
485 (SYMBOL_SET_LINKAGE_NAME): Remove.
486 * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
487 with sym->set_linkage_name.
488
489 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
490
491 * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
492 * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
493 * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
494 * NEWS: Mention new MI command.
495
496 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
497
498 * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
499 '-symbol-info-types', and '-symbol-info-variables'.
500 * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
501 (mi_cmd_symbol_info_types): Declare.
502 (mi_cmd_symbol_info_variables): Declare.
503 * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
504 (output_debug_symbol): New function.
505 (output_nondebug_symbol): New function.
506 (mi_symbol_info): New function.
507 (mi_info_functions_or_variables): New function.
508 (mi_cmd_symbol_info_functions): New function.
509 (mi_cmd_symbol_info_types): New function.
510 (mi_cmd_symbol_info_variables): New function.
511 * NEWS: Mention new commands.
512
513 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
514
515 * symtab.c (symbol_to_info_string): New function, most content
516 moved from print_symbol_info, but updated to return a std::string.
517 (print_symbol_info): Update to use symbol_to_info_string and print
518 returned string.
519 * symtab.h (symbol_to_info_string): Declare new function.
520
521 2019-11-27 Andrew Burgess <andrew.burgess@embecosm.com>
522
523 * python/python.c (gdbpy_rbreak): Convert to using
524 global_symbol_searcher.
525 * symtab.c (file_matches): Convert return type to bool, change
526 file list to std::vector, update header comment.
527 (search_symbols): Rename to...
528 (global_symbol_searcher::search): ...this and update now its
529 a member function of global_symbol_searcher. Take account of the
530 changes to file_matches.
531 (symtab_symbol_info): Convert to using global_symbol_searcher.
532 (rbreak_command): Likewise.
533 (search_module_symbols): Likewise.
534 * symtab.h (enum symbol_search): Update comment.
535 (search_symbols): Remove declaration.
536 (class global_symbol_searcher): New class.
537
538 2019-11-26 Tom Tromey <tromey@adacore.com>
539
540 * cp-support.c (_initialize_cp_support): Conditionally initialize
541 gdb_demangle_attempt_core_dump.
542
543 2019-11-26 Tom Tromey <tom@tromey.com>
544
545 * python/py-function.c (fnpy_init): Update.
546 * value.h (add_internal_function): Adjust declaration.
547 * value.c (function_destroyer): Remove.
548 (do_add_internal_function): Don't set destroyer or copy name.
549 (add_internal_function): Take unique_xmalloc_ptr<char> for name.
550 Set name_allocated.
551 * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
552 (cmdpy_init): Set name_allocated.
553 * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
554 member.
555 (~cmd_list_element): Free "name" if needed.
556
557 2019-11-26 Tom Tromey <tom@tromey.com>
558
559 * value.h (add_internal_function): Add new overload. Move
560 documentation from value.h.
561 * value.c (do_add_internal_function): New function.
562 (add_internal_function): Use it. Add new overload.
563 (function_destroyer): Don't free doc.
564 * python/py-function.c (fnpy_init): Update.
565
566 2019-11-26 Tom Tromey <tom@tromey.com>
567
568 * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
569 (cmdpy_init): Set "doc_allocated".
570
571 2019-11-26 Tom Tromey <tom@tromey.com>
572
573 * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
574 name of worker thread.
575 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
576 pthread_setname_np.
577 * configure, config.in: Rebuild.
578
579 2019-11-26 Tom Tromey <tom@tromey.com>
580
581 * python/python.c (class gdbpy_gil): New.
582 (struct gdbpy_event): Add constructor, destructor, operator().
583 (gdbpy_post_event): Use run_on_main_thread.
584 (gdbpy_initialize_events): Remove.
585 (do_start_initialization): Update.
586
587 2019-11-26 Tom Tromey <tom@tromey.com>
588
589 * NEWS: Add entry.
590 * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
591 commands. Call update_thread_pool_size.
592 (update_thread_pool_size, maintenance_set_worker_threads): New
593 functions.
594 (n_worker_threads): New global.
595
596 2019-11-26 Christian Biesinger <cbiesinger@google.com>
597 Tom Tromey <tom@tromey.com>
598
599 * minsyms.c (minimal_symbol_reader::install): Use
600 parallel_for_each.
601 * gdbsupport/parallel-for.h: New file.
602 * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
603
604 2019-11-26 Christian Biesinger <cbiesinger@google.com>
605 Tom Tromey <tom@tromey.com>
606
607 * gdbsupport/thread-pool.h: New file.
608 * gdbsupport/thread-pool.c: New file.
609 * Makefile.in (COMMON_SFILES): Add thread-pool.c.
610 (HFILES_NO_SRCDIR): Add thread-pool.h.
611
612 2019-11-26 Tom Tromey <tom@tromey.com>
613
614 * event-top.h (thread_local_segv_handler): Declare.
615 * event-top.c (thread_local_segv_handler): New global.
616 (install_handle_sigsegv, handle_sigsegv): New functions.
617 (async_init_signals): Install SIGSEGV handler.
618 * cp-support.c (gdb_demangle_jmp_buf): Change type. Now
619 thread-local.
620 (report_failed_demangle): New function.
621 (gdb_demangle): Make core_dump_allowed atomic. Remove signal
622 handler-setting code, instead use segv_handler. Run warning code
623 on main thread.
624
625 2019-11-26 Tom Tromey <tom@tromey.com>
626
627 * run-on-main-thread.c: New file.
628 * run-on-main-thread.h: New file.
629 * unittests/main-thread-selftests.c: New file.
630 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
631 main-thread-selftests.c.
632 (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
633 (COMMON_SFILES): Add run-on-main-thread.c.
634
635 2019-11-26 Tom Tromey <tom@tromey.com>
636
637 * main.c (setup_alternate_signal_stack): Remove.
638 (captured_main_1): Use gdb::alternate_signal_stack.
639 * gdbsupport/alt-stack.h: New file.
640
641 2019-11-26 Tom Tromey <tom@tromey.com>
642
643 * gdbsupport/signals-state-save-restore.c (original_signal_mask):
644 Remove comment.
645 (save_original_signals_state, restore_original_signals_state): Use
646 gdb_sigmask.
647 * linux-nat.c (block_child_signals, restore_child_signals_mask)
648 (_initialize_linux_nat): Use gdb_sigmask.
649 * guile/guile.c (_initialize_guile): Use block_signals.
650 * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
651 * gdbsupport/gdb-sigmask.h: New file.
652 * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
653 * cp-support.c (gdb_demangle): Use gdb_sigmask.
654 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
655 pthread_sigmask.
656 * configure, config.in: Rebuild.
657 * gdbsupport/block-signals.h: New file.
658
659 2019-11-26 Tom Tromey <tom@tromey.com>
660
661 * acinclude.m4: Include ax_pthread.m4.
662 * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
663 (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
664 (CLIBS): Use PTHREAD_LIBS.
665 (aclocal_m4_deps): Add ax_pthread.m4.
666 * config.in, configure: Rebuild.
667 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
668
669 2019-11-26 Tom Tromey <tom@tromey.com>
670
671 * symtab.h (struct minimal_symbol) <name_set>: New member.
672 * minsyms.c (minimal_symbol_reader::record_full): Copy name.
673 Don't call symbol_set_names.
674 (minimal_symbol_reader::install): Call symbol_set_names.
675
676 2019-11-26 Philippe Waroquiers <philippe.waroquiers@skynet.be>
677
678 * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
679 restore_active_ext_lang, as GIL is needed for (indirectly)
680 called PyOS_InterruptOccurred.
681
682 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
683
684 * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
685 definition.
686
687 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
688
689 * remote-sim.c (simulator_command): Make static, remove
690 declaration.
691
692 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
693
694 * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
695 static.
696 * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
697 * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
698 (main): Likewise.
699 * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
700 (main): Likewise.
701 * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
702 (main): Likewise.
703 * unittests/basic_string_view/element_access/char/1.cc (test01):
704 Likewise.
705 (main): Likewise.
706 * unittests/basic_string_view/element_access/char/empty.cc (main):
707 Likewise.
708 * unittests/basic_string_view/element_access/char/front_back.cc
709 (test01): Likewise.
710 (main): Likewise.
711 * unittests/basic_string_view/inserters/char/2.cc (test05):
712 Likewise.
713 (main): Likewise.
714 * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
715 (test01): Likewise.
716 (main): Likewise.
717 * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
718 (test01): Likewise.
719 (main): Likewise.
720 * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
721 Likewise.
722 * unittests/basic_string_view/operations/compare/char/1.cc
723 (test01): Likewise.
724 (main): Likewise.
725 * unittests/basic_string_view/operations/compare/char/13650.cc
726 (test01): Likewise.
727 * unittests/basic_string_view/operations/copy/char/1.cc (test01):
728 Likewise.
729 (main): Likewise.
730 * unittests/basic_string_view/operations/data/char/1.cc (test01):
731 Likewise.
732 (main): Likewise.
733 * unittests/basic_string_view/operations/find/char/1.cc (test01):
734 Likewise.
735 (main): Likewise.
736 * unittests/basic_string_view/operations/find/char/2.cc (test02):
737 Likewise.
738 (main): Likewise.
739 * unittests/basic_string_view/operations/find/char/3.cc (test03):
740 Likewise.
741 (main): Likewise.
742 * unittests/basic_string_view/operations/find/char/4.cc (main):
743 Likewise.
744 * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
745 Likewise.
746 (main): Likewise.
747 * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
748 Likewise.
749 (main): Likewise.
750 * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
751 Likewise.
752 (main): Likewise.
753 * unittests/basic_string_view/operations/substr/char/1.cc
754 (test01): Likewise.
755 (main): Likewise.
756 * unittests/basic_string_view/operators/char/2.cc (main):
757 Likewise.
758 * unittests/optional/assignment/1.cc (test): Likewise.
759 * unittests/optional/assignment/2.cc (test): Likewise.
760 * unittests/optional/assignment/3.cc (test): Likewise.
761 * unittests/optional/assignment/4.cc (test): Likewise.
762 * unittests/optional/assignment/5.cc (test): Likewise.
763 * unittests/optional/assignment/6.cc (test): Likewise.
764 * unittests/optional/assignment/7.cc (test): Likewise.
765 * unittests/optional/cons/copy.cc (test): Likewise.
766 * unittests/optional/cons/default.cc (test): Likewise.
767 * unittests/optional/cons/move.cc (test): Likewise.
768 * unittests/optional/cons/value.cc (test): Likewise.
769 * unittests/optional/in_place.cc (test): Likewise.
770 * unittests/optional/observers/1.cc (test): Likewise.
771 * unittests/optional/observers/2.cc (test): Likewise.
772
773 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
774
775 * tui-win.h (tui_set_var_cmd): Remove.
776 * tui-win.c (tui_set_var_cmd): Make static.
777
778 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
779
780 * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
781 rbreak_command_wrapper): Remove.
782 * symtab.c (rbreak_command_wrapper): Remove.
783
784 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
785
786 * inferior.h (info_terminal_command): Remove declaration.
787 * inflow.c (info_terminal_command): Make static.
788
789 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
790
791 * inferior.c (exit_inferior_silent): Remove.
792
793 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
794
795 * dictionary.c (dict_empty, mdict_empty): Remove.
796 * dictionary.c (mdict_empty): Remove.
797
798 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
799
800 * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
801 (arc_insn_get_memory_offset): Likewise.
802 (arc_insn_dump): Likewise.
803 * cp-support.c (test_cp_symbol_name_matches): Likewise.
804 * csky-linux-tdep.c (csky_supply_fregset): Likewise.
805 * dictionary.c (dict_iterator_next): Likewise.
806 (dict_iter_match_first): Likewise.
807 (dict_iter_match_next): Likewise.
808 * f-lang.c (evaluate_subexp_f): Likewise.
809 * hppa-tdep.c (hppa_read_pc): Likewise.
810 * i386-tdep.c (i386_floatformat_for_type): Likewise.
811 * parse.c (write_exp_elt_msym): Likewise.
812 * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
813 * remote.c (remote_packet_size): Likewise.
814 (remote_notif_stop_parse): Likewise.
815 * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
816 * s12z-tdep.c (s12z_disassemble_info): Likewise.
817 * source.c (prepare_path_for_appending): Likewise.
818 * sparc64-linux-tdep.c
819 (sparc64_linux_handle_segmentation_fault); Likewise.
820 * stack.c (frame_selection_by_function_completer): Likewise.
821
822 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
823
824 * completer.c (set_gdb_completion_word_break_characters):
825 Remove.
826
827 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
828
829 * dwarf-index-write.c: Include dwarf-index-write.h.
830 * mi/mi-interp.c: Include mi/mi-interp.h.
831
832 2019-11-26 Simon Marchi <simon.marchi@efficios.com>
833
834 * aarch32-tdep.c: Include aarch32-tdep.h.
835 * aarch32-tdep.h: Forward-declare struct target_desc.
836
837 2019-11-26 Christian Biesinger <cbiesinger@google.com>
838
839 * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
840 strerror.
841 * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
842 * windows-nat.c (windows_nat_target::create_inferior): Likewise.
843
844 2019-11-25 Tom de Vries <tdevries@suse.de>
845
846 * contrib/words.sh: Add -c option.
847
848 2019-11-25 Christian Biesinger <cbiesinger@google.com>
849
850 * solib.c (solib_find_1): Change int to bool.
851 (exec_file_find): Change int to bool.
852 (solib_find): Change int to bool.
853 (solib_read_symbols): Change int to bool.
854 (solib_used): Change int to bool.
855 (solib_add): Change int to bool.
856 (info_sharedlibrary_command): Change int to bool.
857 (solib_contains_address_p): Change int to bool.
858 (solib_keep_data_in_core): Change int to bool.
859 (in_solib_dynsym_resolve_code): Change int to bool.
860 (reload_shared_libraries_1): Change int to bool.
861 (gdb_sysroot_changed): Change int to bool.
862 * solib.h (solib_read_symbols): Change int to bool.
863 (solib_contains_address_p): Change int to bool.
864 (solib_keep_data_in_core): Change int to bool.
865 (in_solib_dynsym_resolve_code): Change int to bool.
866 (libpthread_name_p): Change int to bool.
867
868 2019-11-25 Luis Machado <luis.machado@linaro.org>
869
870 * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
871 * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
872 (remote_packet_max_chars): New static global.
873 (show_remote_packet_max_chars): New function.
874 (remote_target::putpkt_binary): Adjust to use new
875 remote_packet_max_chars option.
876 (remote_target::getpkt_or_notif_sane_1): Likewise.
877 (_initialize_remote): Register new remote-packet-max-chars option.
878
879 2019-11-24 Simon Marchi <simon.marchi@efficios.com>
880
881 * m68k-linux-nat.c: Include gdbarch.h.
882
883 2019-11-24 Tom Tromey <tom@tromey.com>
884
885 * symfile.c (read_symbols): Update.
886 * psymtab.c (require_partial_symbols): Change type of "verbose" to
887 bool.
888 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
889 (psym_lookup_symbol, psym_find_last_source_symtab)
890 (psym_forget_cached_source_info, psym_print_stats)
891 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
892 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
893 (psym_map_matching_symbols, psym_expand_symtabs_matching)
894 (psym_find_compunit_symtab_by_address)
895 (maintenance_print_psymbols, maintenance_info_psymtabs)
896 (maintenance_check_psymtabs): Update.
897 * psymtab.h (require_partial_symbols): Change type of "verbose" to
898 bool.
899
900 2019-11-22 Tom Tromey <tom@tromey.com>
901
902 * observable.h: Update comments.
903
904 2019-11-22 Tom Tromey <tromey@adacore.com>
905
906 * ada-tasks.c (ada_task_is_alive): Make parameter const.
907 (print_ada_task_info): Don't try to fetch thread id if task is not
908 alive.
909
910 2019-11-22 Christian Biesinger <cbiesinger@google.com>
911
912 * ada-exp.y: Update.
913 * ada-lang.c (sort_choices): Update.
914 (ada_print_symbol_signature): Update.
915 (resolve_subexp): Update.
916 (ada_parse_renaming): Update.
917 (ada_read_renaming_var_value): Update.
918 (lesseq_defined_than): Update.
919 (remove_extra_symbols): Update.
920 (remove_irrelevant_renamings): Update.
921 (ada_add_block_symbols): Update.
922 (ada_collect_symbol_completion_matches): Update.
923 (ada_is_renaming_symbol): Update.
924 (aggregate_assign_from_choices): Update.
925 (ada_evaluate_subexp): Update.
926 (ada_has_this_exception_support): Update.
927 (ada_is_non_standard_exception_sym): Update.
928 (ada_add_exceptions_from_frame): Update.
929 (ada_add_global_exceptions): Update.
930 (ada_print_subexp): Update.
931 * ax-gdb.c (gen_var_ref): Update.
932 (gen_maybe_namespace_elt): Update.
933 (gen_expr_for_cast): Update.
934 (gen_expr): Update.
935 * block.h: Update.
936 * blockframe.c (find_pc_partial_function): Update.
937 * breakpoint.c (print_breakpoint_location): Update.
938 (update_static_tracepoint): Update.
939 * btrace.c (ftrace_print_function_name): Update.
940 (ftrace_function_switched): Update.
941 * buildsym.c (find_symbol_in_list): Update.
942 * c-exp.y: Update.
943 * c-typeprint.c (c_print_typedef): Update.
944 (c_type_print_template_args): Update.
945 * cli/cli-cmds.c (edit_command): Update.
946 (list_command): Update.
947 (print_sal_location): Update.
948 * coffread.c (patch_opaque_types): Update.
949 (process_coff_symbol): Update.
950 (coff_read_enum_type): Update.
951 * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
952 (convert_one_symbol): Update.
953 (hash_symname): Update.
954 (eq_symname): Update.
955 * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
956 * compile/compile-cplus-types.c (debug_print_scope): Update.
957 * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
958 * compile/compile-object-load.c (get_out_value_type): Update.
959 * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
960 (search_symbol_list): Update.
961 (cp_lookup_symbol_imports_or_template): Update.
962 * cp-support.c (overload_list_add_symbol): Update.
963 * ctfread.c (psymtab_to_symtab): Update.
964 * dbxread.c (cp_set_block_scope): Update.
965 * dictionary.c (iter_match_first_hashed): Update.
966 (iter_match_next_hashed): Update.
967 (insert_symbol_hashed): Update.
968 (iter_match_next_linear): Update.
969 * dictionary.h: Update.
970 * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
971 (locexpr_describe_location_piece): Update.
972 (locexpr_describe_location_1): Update.
973 (locexpr_generate_c_location): Update.
974 (loclist_describe_location): Update.
975 (loclist_generate_c_location): Update.
976 * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
977 (read_func_scope): Update.
978 (process_enumeration_scope): Update.
979 (new_symbol): Update.
980 (dwarf2_const_value): Update.
981 (dwarf2_symbol_mark_computed): Update.
982 * eval.c (evaluate_funcall): Update.
983 (evaluate_subexp_standard): Update.
984 * expprint.c (print_subexp_standard): Update.
985 (dump_subexp_body_standard): Update.
986 * f-valprint.c (info_common_command_for_block): Update.
987 * findvar.c (get_hosting_frame): Update.
988 (default_read_var_value): Update.
989 * go-lang.c (go_symbol_package_name): Update.
990 * guile/scm-block.c (bkscm_print_block_smob): Update.
991 * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
992 (gdbscm_symbol_name): Update.
993 (gdbscm_symbol_linkage_name): Update.
994 (gdbscm_symbol_print_name): Update.
995 * infcall.c (get_function_name): Update.
996 * infcmd.c (jump_command): Update.
997 (finish_command): Update.
998 * infrun.c (insert_exception_resume_breakpoint): Update.
999 * linespec.c (canonicalize_linespec): Update.
1000 (create_sals_line_offset): Update.
1001 (convert_linespec_to_sals): Update.
1002 (complete_label): Update.
1003 (find_label_symbols_in_block): Update.
1004 * m2-typeprint.c (m2_print_typedef): Update.
1005 * mdebugread.c (mdebug_reg_to_regnum): Update.
1006 (parse_symbol): Update.
1007 (mylookup_symbol): Update.
1008 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1009 (list_args_or_locals): Update.
1010 * objc-lang.c (compare_selectors): Update.
1011 (info_selectors_command): Update.
1012 (compare_classes): Update.
1013 (info_classes_command): Update.
1014 (find_imps): Update.
1015 * p-typeprint.c (pascal_print_typedef): Update.
1016 * printcmd.c (build_address_symbolic): Update.
1017 (info_address_command): Update.
1018 (print_variable_and_value): Update.
1019 * python/py-framefilter.c (extract_sym): Update.
1020 (py_print_single_arg): Update.
1021 * python/py-symbol.c (sympy_str): Update.
1022 (sympy_get_name): Update.
1023 (sympy_get_linkage_name): Update.
1024 * python/python.c (gdbpy_rbreak): Update.
1025 * record-btrace.c (btrace_get_bfun_name): Update.
1026 (btrace_call_history): Update.
1027 * rust-lang.c (rust_print_typedef): Update.
1028 * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1029 * stabsread.c (stab_reg_to_regnum): Update.
1030 (define_symbol): Update.
1031 (read_enum_type): Update.
1032 (common_block_end): Update.
1033 (cleanup_undefined_types_1): Update.
1034 (scan_file_globals): Update.
1035 * stack.c (print_frame_arg): Update.
1036 (print_frame_args): Update.
1037 (find_frame_funname): Update.
1038 (info_frame_command_core): Update.
1039 (iterate_over_block_locals): Update.
1040 (print_block_frame_labels): Update.
1041 (do_print_variable_and_value): Update.
1042 (iterate_over_block_arg_vars): Update.
1043 (return_command): Update.
1044 * symmisc.c (dump_symtab_1): Update.
1045 (print_symbol): Update.
1046 * symtab.c (eq_symbol_entry): Update.
1047 (symbol_cache_dump): Update.
1048 (lookup_language_this): Update.
1049 (find_pc_sect_line): Update.
1050 (skip_prologue_sal): Update.
1051 (symbol_search::compare_search_syms): Update.
1052 (treg_matches_sym_type_name): Update.
1053 (search_symbols): Update.
1054 (print_symbol_info): Update.
1055 (rbreak_command): Update.
1056 (completion_list_add_symbol): Update.
1057 (find_gnu_ifunc): Update.
1058 (get_symbol_address): Update.
1059 (search_module_symbols): Update.
1060 (info_module_subcommand): Update.
1061 * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1062 (SYMBOL_LINKAGE_NAME): Remove.
1063 (SYMBOL_DEMANGLED_NAME): Remove.
1064 (SYMBOL_PRINT_NAME): Remove.
1065 (SYMBOL_SEARCH_NAME): Remove.
1066 * tracepoint.c (set_traceframe_context): Update.
1067 (validate_actionline): Update.
1068 (collection_list::collect_symbol): Update.
1069 (encode_actions_1): Update.
1070 (info_scope_command): Update.
1071 (print_one_static_tracepoint_marker): Update.
1072 * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1073 * valops.c (address_of_variable): Update.
1074 (find_overload_match): Update.
1075 (find_oload_champ): Update.
1076
1077 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1078
1079 * ada-lang.c (ada_lookup_simple_minsym): Update.
1080 (ada_collect_symbol_completion_matches): Update.
1081 * ada-tasks.c (read_atcb): Update.
1082 * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1083 (amd64_windows_skip_trampoline_code): Update.
1084 * arm-tdep.c (skip_prologue_function): Update.
1085 (arm_skip_stack_protector): Update.
1086 * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1087 (arm_wince_skip_main_prologue): Update.
1088 * ax-gdb.c (gen_expr): Update.
1089 * block.c (call_site_for_pc): Update.
1090 * blockframe.c (find_pc_partial_function): Update.
1091 * breakpoint.c (set_breakpoint_location_function): Update.
1092 * btrace.c (ftrace_print_function_name): Update.
1093 (ftrace_function_switched): Update.
1094 * c-valprint.c (print_unpacked_pointer): Update.
1095 * coffread.c (coff_symfile_read): Update.
1096 * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1097 * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1098 * dwarf-index-write.c (write_psymbols): Update.
1099 * dwarf2loc.c (call_site_to_target_addr): Update.
1100 (func_verify_no_selftailcall): Update.
1101 (tailcall_dump): Update.
1102 (call_site_find_chain_1): Update.
1103 (dwarf_expr_reg_to_entry_parameter): Update.
1104 * elfread.c (elf_gnu_ifunc_record_cache): Update.
1105 * eval.c (evaluate_funcall): Update.
1106 (evaluate_subexp_standard): Update.
1107 (evaluate_subexp_for_sizeof): Update.
1108 * expprint.c (print_subexp_standard): Update.
1109 (dump_subexp_body_standard): Update.
1110 * frame.c (get_prev_frame_always_1): Update.
1111 * frv-tdep.c (frv_skip_main_prologue): Update.
1112 * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1113 * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1114 (gnuv3_get_typename_from_type_info): Update.
1115 (gnuv3_skip_trampoline): Update.
1116 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1117 * i386-tdep.c (i386_skip_main_prologue): Update.
1118 (i386_pe_skip_trampoline_code): Update.
1119 * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1120 * infcall.c (get_function_name): Update.
1121 * linespec.c (minsym_found): Update.
1122 * linux-fork.c (info_checkpoints_command): Update.
1123 * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1124 (m32c_m16c_pointer_to_address): Update.
1125 * maint.c (maintenance_translate_address): Update.
1126 * minsyms.c (add_minsym_to_hash_table): Update.
1127 (add_minsym_to_demangled_hash_table): Update.
1128 (lookup_minimal_symbol_mangled): Update.
1129 (lookup_minimal_symbol_demangled): Update.
1130 (lookup_minimal_symbol_linkage): Update.
1131 (lookup_minimal_symbol_text): Update.
1132 (lookup_minimal_symbol_by_pc_name): Update.
1133 (minimal_symbol_is_less_than): Update.
1134 (compact_minimal_symbols): Update.
1135 (build_minimal_symbol_hash_tables): Update.
1136 (find_solib_trampoline_target): Update.
1137 * mips-tdep.c (mips_stub_frame_sniffer): Update.
1138 (mips_skip_pic_trampoline_code): Update.
1139 * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1140 * objc-lang.c (info_selectors_command): Update.
1141 (info_classes_command): Update.
1142 (find_methods): Update.
1143 (find_imps): Update.
1144 * p-valprint.c (pascal_val_print): Update.
1145 * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1146 * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1147 * printcmd.c (build_address_symbolic): Update.
1148 (info_symbol_command): Update.
1149 * psymtab.c (psymbol_name_matches): Update.
1150 (match_partial_symbol): Update.
1151 (lookup_partial_symbol): Update.
1152 (print_partial_symbols): Update.
1153 (sort_pst_symbols): Update.
1154 (maintenance_check_psymtabs): Update.
1155 * python/py-framefilter.c (py_print_frame): Update.
1156 * python/python.c (gdbpy_rbreak): Update.
1157 * record-btrace.c (btrace_get_bfun_name): Update.
1158 (btrace_call_history): Update.
1159 * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1160 (rs6000_skip_trampoline_code): Update.
1161 * sol-thread.c (info_cb): Update.
1162 * stabsread.c (scan_file_globals): Update.
1163 * stack.c (find_frame_funname): Update.
1164 (info_frame_command_core): Update.
1165 * symmisc.c (dump_msymbols): Update.
1166 * symtab.c (symbol_natural_name): Rename to..,
1167 (general_symbol_info::natural_name): ...this.
1168 (symbol_demangled_name): Rename to...
1169 (general_symbol_info::demangled_name): ...this.
1170 (symbol_search_name): Rename to...
1171 (general_symbol_info::search_name): ...this.
1172 (symbol_matches_search_name): Update.
1173 (find_pc_sect_line): Update.
1174 (skip_prologue_sal): Update.
1175 (search_symbols): Update.
1176 (print_msymbol_info): Update.
1177 (rbreak_command): Update.
1178 (completion_list_add_msymbol): Update.
1179 (completion_list_objc_symbol): Update.
1180 (get_msymbol_address): Update.
1181 * symtab.h (struct general_symbol_info): Add member functions
1182 natural_name (), linkage_name (), print_name (), demangled_name (),
1183 and search_name ().
1184 (SYMBOL_NATURAL_NAME): Update.
1185 (symbol_natural_name): Move to a member function on general_symbol_info.
1186 (SYMBOL_DEMANGLED_NAME): Update.
1187 (symbol_demangled_name): Move to a member function on
1188 general_symbol_info.
1189 (SYMBOL_SEARCH_NAME): Update.
1190 (symbol_search_name): Move to a member function on general_symbol_info.
1191 (MSYMBOL_NATURAL_NAME): Remove.
1192 (MSYMBOL_LINKAGE_NAME): Remove.
1193 (MSYMBOL_PRINT_NAME): Remove.
1194 (MSYMBOL_DEMANGLED_NAME): Remove.
1195 (MSYMBOL_SEARCH_NAME): Remove.
1196 * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1197
1198 2019-11-22 Christian Biesinger <cbiesinger@google.com>
1199
1200 * symtab.c (create_demangled_names_hash): Use per_bfd->
1201 minimal_symbol_count for computing the initial size, if greater
1202 than our default size.
1203
1204 2019-11-22 Tom de Vries <tdevries@suse.de>
1205
1206 * contrib/words.sh: Improve words extraction.
1207
1208 2019-11-22 Tom de Vries <tdevries@suse.de>
1209
1210 * contrib/words.sh: Combine sed invocations.
1211
1212 2019-11-21 Christian Biesinger <cbiesinger@google.com>
1213
1214 * Makefile.in: Update.
1215 * demangle.c: Rename to...
1216 * gdb-demangle.c: ..this.
1217 (is_cplus_marker): Change return type to bool.
1218 (_initialize_demangler): Rename to...
1219 (_initialize_gdb_demangle): ...this.
1220 * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1221 * symtab.h (demangle): Remove declaration; instead include
1222 gdb-demangle.h.
1223
1224 2019-11-21 Tom Tromey <tromey@adacore.com>
1225
1226 * gdbsupport/format.c (format_pieces): Parse %I64d.
1227 * unittests/format_pieces-selftests.c (test_windows_formats): New
1228 function.
1229 (run_tests): Call it.
1230
1231 2019-11-21 Peeter Joot <peeter.joot@lzlabs.com>
1232
1233 Byte reverse display of variables with DW_END_big, DW_END_little
1234 (DW_AT_endianity) dwarf attributes if different than the native
1235 byte order.
1236 * ada-lang.c (ada_value_binop):
1237 Use type_byte_order instead of gdbarch_byte_order.
1238 * ada-valprint.c (printstr):
1239 (ada_val_print_string):
1240 * ada-lang.c (value_pointer):
1241 (ada_value_binop):
1242 Use type_byte_order instead of gdbarch_byte_order.
1243 * c-lang.c (c_get_string):
1244 Use type_byte_order instead of gdbarch_byte_order.
1245 * c-valprint.c (c_val_print_array):
1246 Use type_byte_order instead of gdbarch_byte_order.
1247 * cp-valprint.c (cp_print_class_member):
1248 Use type_byte_order instead of gdbarch_byte_order.
1249 * dwarf2loc.c (rw_pieced_value):
1250 Use type_byte_order instead of gdbarch_byte_order.
1251 * dwarf2read.c (read_base_type): Handle DW_END_big,
1252 DW_END_little
1253 * f-lang.c (f_get_encoding):
1254 Use type_byte_order instead of gdbarch_byte_order.
1255 * findvar.c (default_read_var_value):
1256 Use type_byte_order instead of gdbarch_byte_order.
1257 * gdbtypes.c (check_types_equal):
1258 Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
1259 (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
1260 and TYPE_ENDIANITY_LITTLE if set.
1261 (type_byte_order): new function.
1262 * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
1263 (struct main_type) <flag_endianity_not_default>:
1264 New field.
1265 (type_byte_order): New function.
1266 * infcmd.c (default_print_one_register_info):
1267 Use type_byte_order instead of gdbarch_byte_order.
1268 * p-lang.c (pascal_printstr):
1269 Use type_byte_order instead of gdbarch_byte_order.
1270 * p-valprint.c (pascal_val_print):
1271 Use type_byte_order instead of gdbarch_byte_order.
1272 * printcmd.c (print_scalar_formatted):
1273 Use type_byte_order instead of gdbarch_byte_order.
1274 * solib-darwin.c (darwin_current_sos):
1275 Use type_byte_order instead of gdbarch_byte_order.
1276 * solib-svr4.c (solib_svr4_r_ldsomap):
1277 Use type_byte_order instead of gdbarch_byte_order.
1278 * stap-probe.c (stap_modify_semaphore):
1279 Use type_byte_order instead of gdbarch_byte_order.
1280 * target-float.c (target_float_same_format_p):
1281 Use type_byte_order instead of gdbarch_byte_order.
1282 * valarith.c (scalar_binop):
1283 (value_bit_index):
1284 Use type_byte_order instead of gdbarch_byte_order.
1285 * valops.c (value_cast):
1286 Use type_byte_order instead of gdbarch_byte_order.
1287 * valprint.c (generic_emit_char):
1288 (generic_printstr):
1289 (val_print_string):
1290 Use type_byte_order instead of gdbarch_byte_order.
1291 * value.c (unpack_long):
1292 (unpack_bits_as_long):
1293 (unpack_value_bitfield):
1294 (modify_field):
1295 (pack_long):
1296 (pack_unsigned_long):
1297 Use type_byte_order instead of gdbarch_byte_order.
1298 * findvar.c (unsigned_pointer_to_address):
1299 (signed_pointer_to_address):
1300 (unsigned_address_to_pointer):
1301 (address_to_signed_pointer):
1302 (default_read_var_value):
1303 (default_value_from_register):
1304 Use type_byte_order instead of gdbarch_byte_order.
1305 * gnu-v3-abi.c (gnuv3_make_method_ptr):
1306 Use type_byte_order instead of gdbarch_byte_order.
1307 * riscv-tdep.c (riscv_print_one_register_info):
1308 Use type_byte_order instead of gdbarch_byte_order.
1309
1310 2019-11-21 Simon Marchi <simon.marchi@polymtl.ca>
1311
1312 * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
1313 (current_ui_gdb_stdin_ptr): Likewise.
1314 (current_ui_gdb_stderr_ptr): Likewise.
1315 (current_ui_gdb_stdlog_ptr): Likewise.
1316 (current_ui_current_uiout_ptr): Likewise.
1317 (gen_ret_current_ui_field_ptr): Remove.
1318
1319 2019-11-21 Tom de Vries <tdevries@suse.de>
1320
1321 PR gdb/24956
1322 * cli/cli-script.c (execute_control_command): Only switch to
1323 INTERP_CONSOLE's ui_out when INTERP_MI is active.
1324
1325 2019-11-19 Tom Tromey <tom@tromey.com>
1326
1327 * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
1328 Now static. Change type of "name".
1329 (tui_set_win_height_command): Don't copy "arg".
1330 * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
1331 * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
1332
1333 2019-11-19 Ali Tamur <tamur@google.com>
1334
1335 * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
1336 "if (attr != nullptr)".
1337 (dwarf2_find_base_address): Likewise.
1338 (dwarf2_build_include_psymtabs): Likewise.
1339 (read_cutu_die_from_dwo): Likewise.
1340 (read_func_scope): Likewise.
1341 (read_call_site_scope): Likewise.
1342 (dwarf2_get_pc_bounds): Likewise.
1343 (dwarf2_record_block_ranges): Likewise.
1344 (dwarf2_add_field): Likewise.
1345 (dwarf2_add_member_fn): Likewise.
1346 (read_structure_type): Likewise.
1347 (read_enumeration_type): Likewise.
1348 (read_array_type): Likewise.
1349 (read_array_order): Likewise.
1350 (read_set_type): Likewise.
1351 (read_common_block): Likewise.
1352 (read_tag_reference_type): Likewise.
1353 (read_tag_string_type): Likewise.
1354 (read_subroutine_type): Likewise.
1355 (read_base_type): Likewise.
1356 (read_subrange_type): Likewise.
1357 (new_symbol): Likewise.
1358 (prepare_one_comp_unit): Likewise.
1359
1360 2019-11-19 Tom Tromey <tromey@adacore.com>
1361
1362 * windows-nat.c (windows_nat_target::attach): Include GetLastError
1363 result in error when DebugActiveProcess fails.
1364
1365 2019-11-18 Sergio Durigan Junior <sergiodj@redhat.com>
1366 Pedro Alves <palves@redhat.com>
1367
1368 https://bugzilla.redhat.com/show_bug.cgi?id=1765117
1369 * target.c (target_stack::push): Call 'unpush' if there's a
1370 target on top of the stack.
1371
1372 2019-11-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1373
1374 * python/py-block.c (blpy_dealloc): Call tp_free.
1375 (blpy_block_syms_dealloc): Likewise.
1376 * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
1377 * python/py-inferior.c (infpy_dealloc): Likewise.
1378 * python/py-lazy-string.c (stpy_dealloc): Likewise.
1379 * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
1380 * python/py-symbol.c (sympy_dealloc): Likewise.
1381 * python/py-symtab.c (stpy_dealloc): Likewise.
1382 * python/py-type.c (typy_iterator_dealloc): Likewise.
1383
1384 2019-11-18 Christian Biesinger <cbiesinger@google.com>
1385
1386 * symtab.h (struct symbol) <owner>: Initialize explicitly in the
1387 constructor instead of using a class initializer.
1388
1389 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1390
1391 * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
1392 * configure: Regenerate.
1393 * configure.ac: Don't source common.host.
1394 * gdbsupport/common.host: Remove.
1395 * gdbsupport/mingw-strerror.c: Remove.
1396 * gdbsupport/posix-strerror.c: Rename to...
1397 * gdbsupport/safe-strerror.c: ...this.
1398
1399 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1400
1401 * maint.c (scoped_command_stats::print_time): Use localtime_r
1402 instead of localtime (provided through gnulib if necessary).
1403 * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
1404 of ctime.
1405
1406 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1407
1408 * gdbsupport/common-defs.h: Include time.h before pathmax.h to
1409 avoid compile errors.
1410
1411 2019-11-15 Christian Biesinger <cbiesinger@google.com>
1412
1413 * config.in: Regenerate.
1414 * configure: Regenerate.
1415 * gdbsupport/common.m4: No longer check for strerror_r.
1416 * gdbsupport/posix-strerror.c (safe_strerror): Always call the
1417 POSIX version of strerror_r, now that gnulib provides it if
1418 necessary.
1419
1420 2019-11-14 Christian Biesinger <cbiesinger@google.com>
1421
1422 * README (`configure' options): Update.
1423
1424 2019-11-14 Tom Tromey <tromey@adacore.com>
1425
1426 * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
1427 expected type for the RHS if the LHS is a convenience variable.
1428
1429 2019-11-14 Simon Marchi <simon.marchi@polymtl.ca>
1430
1431 * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
1432 Provide explicit default and copy constructor.
1433
1434 2019-11-14 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1435
1436 * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
1437 only call Py_INCREF (newbp) in the bppy_pending_object case.
1438
1439 2019-11-13 Tom Tromey <tromey@adacore.com>
1440
1441 PR build/25182:
1442 * psympriv.h (partial_symbol): Remove static assert.
1443 * symtab.h (general_symbol_info, symbol): Remove static assert.
1444
1445 2019-11-12 Andrew Burgess <andrew.burgess@embecosm.com>
1446
1447 * gdbsupport/format.c (format_pieces::format_pieces): Support
1448 printf 'z' size modifier.
1449 * gdbsupport/format.h (enum argclass): Add size_t_arg.
1450 * printcmd.c (ui_printf): Handle size_t_arg.
1451 * ui-out.c (ui_out::vmessage): Likewise.
1452 * unittests/format_pieces-selftests.c (test_format_int_sizes): New
1453 function.
1454 (run_tests): Call test_format_int_sizes.
1455
1456 2019-11-12 Christian Biesinger <cbiesinger@google.com>
1457
1458 * ada-exp.y (write_ambiguous_var): Update.
1459 * buildsym.c (add_symbol_to_list): Update.
1460 * dwarf2read.c (read_variable): Update.
1461 (new_symbol): Update.
1462 * jit.c (finalize_symtab): Update.
1463 * language.c (language_alloc_type_symbol): Update.
1464 * symtab.c (fixup_symbol_section): Update.
1465 (initialize_objfile_symbol_1): Move code to...
1466 (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
1467 (allocate_symbol): Update.
1468 (allocate_template_symbol): Update.
1469 (get_symbol_address): Update.
1470 * symtab.h (struct symbol): Inherit from general_symbol_info instead
1471 of having as a field, and add a constructor.
1472 (SYMBOL_VALUE): Update.
1473 (SYMBOL_VALUE_ADDRESS): Update.
1474 (SET_SYMBOL_VALUE_ADDRESS): Update.
1475 (SYMBOL_VALUE_BYTES): Update.
1476 (SYMBOL_VALUE_COMMON_BLOCK): Update.
1477 (SYMBOL_BLOCK_VALUE): Update.
1478 (SYMBOL_VALUE_CHAIN): Update.
1479 (SYMBOL_LANGUAGE): Update.
1480 (SYMBOL_SECTION): Update.
1481 (SYMBOL_OBJ_SECTION): Update.
1482 (SYMBOL_SET_LANGUAGE): Update.
1483 (SYMBOL_SET_LINKAGE_NAME): Update.
1484 (SYMBOL_SET_NAMES): Update.
1485 (SYMBOL_NATURAL_NAME): Update.
1486 (SYMBOL_LINKAGE_NAME): Update.
1487 (SYMBOL_DEMANGLED_NAME): Update.
1488 (SYMBOL_SEARCH_NAME): Update.
1489 (SYMBOL_MATCHES_SEARCH_NAME): Update.
1490 (struct symbol): Update.
1491 (struct template_symbol): Update.
1492 (struct rust_vtable_symbol): Update.
1493 * xcoffread.c (SYMBOL_DUP): Update.
1494
1495 2019-11-12 Tom Tromey <tom@tromey.com>
1496
1497 * tui/tui-layout.c (show_layout): Set current_layout.
1498 (show_source_disasm_command, show_data)
1499 (show_source_or_disasm_and_command): Don't set current_layout.
1500
1501 2019-11-12 Tom Tromey <tom@tromey.com>
1502
1503 * tui/tui-layout.c (_initialize_tui_layout): Move to end.
1504
1505 2019-11-12 Tom Tromey <tom@tromey.com>
1506
1507 * tui/tui-win.c (resize_message): New global.
1508 (show_tui_resize_message): New function.
1509 (tui_async_resize_screen): Print message if requested.
1510 (_initialize_tui_win): Add tui-resize-message setting.
1511 * NEWS: Add entry for new commands.
1512
1513 2019-11-11 Tom Tromey <tom@tromey.com>
1514
1515 * tui/tui.c (tui_initialize_readline): Add new bindable readline
1516 functions.
1517
1518 2019-11-11 Christian Biesinger <cbiesinger@google.com>
1519
1520 * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
1521
1522 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1523
1524 * python/py-symbol.c (gdbpy_lookup_static_symbols): New
1525 function.
1526 * python/python-internal.h (gdbpy_lookup_static_symbols):
1527 Declare new function.
1528 * python/python.c (python_GdbMethods): Add
1529 gdb.lookup_static_symbols method.
1530 * NEWS: Mention gdb.lookup_static_symbols.
1531
1532 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1533
1534 * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
1535 static block of current object file first. Also fix typo in
1536 header comment.
1537
1538 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1539
1540 * stack.c (set_last_displayed_sal): Delete.
1541 (last_displayed_sal_valid): Delete.
1542 (last_displayed_pspace): Delete.
1543 (last_displayed_addr): Delete.
1544 (last_displayed_symtab): Delete.
1545 (last_displayed_line): Delete.
1546 (class last_displayed_symtab_info_type): New.
1547 (last_displayed_symtab_info): New static global variable.
1548 (print_frame_info): Call methods on last_displayed_symtab_info.
1549 (clear_last_displayed_sal): Update header comment, and make use of
1550 last_displayed_symtab_info.
1551 (last_displayed_sal_is_valid): Likewise.
1552 (get_last_displayed_pspace): Likewise.
1553 (get_last_displayed_addr): Likewise.
1554 (get_last_displayed_symtab): Likewise.
1555 (get_last_displayed_line): Likewise.
1556 (get_last_displayed_sal): Likewise.
1557 * stack.h (clear_last_displayed_sal): Update header comment.
1558 (last_displayed_sal_is_valid): Likewise.
1559 (get_last_displayed_pspace): Likewise.
1560 (get_last_displayed_addr): Likewise.
1561 (get_last_displayed_symtab): Likewise.
1562 (get_last_displayed_line): Likewise.
1563 (get_last_displayed_sal): Likewise.
1564
1565 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1566
1567 * stack.c (frame_show_address): Convert return type to bool.
1568 * stack.h (frame_show_address): Likewise, and update header
1569 comment.
1570
1571 2019-11-10 Andrew Burgess <andrew.burgess@embecosm.com>
1572
1573 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
1574 * unittests/vec-utils-selftests.c: New file.
1575 * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
1576
1577 2019-11-10 Tom Tromey <tom@tromey.com>
1578
1579 * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
1580 (tui_highlight_win): Likewise.
1581 (tui_win_info::check_and_display_highlight_if_needed): Likewise.
1582 * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
1583 * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
1584 Don't set can_highlight.
1585
1586 2019-11-10 Tom Tromey <tom@tromey.com>
1587
1588 * cli/cli-style.h (class cli_style_option) <cli_style_option>:
1589 Remove unused declaration.
1590
1591 2019-11-08 Tom Tromey <tromey@adacore.com>
1592
1593 * top.c (read_command_file): Update.
1594 (command_line_input): Make return type const.
1595 * python/py-gdb-readline.c: Update.
1596 * linespec.c (decode_line_2): Update.
1597 * defs.h (command_line_input): Make return type const.
1598 * cli/cli-script.c (read_next_line): Make return type const.
1599 * ada-lang.c (get_selections): Update.
1600
1601 2019-11-06 Christian Biesinger <cbiesinger@google.com>
1602
1603 * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
1604 * mi/mi-main.c (output_cores): Likewise.
1605 * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
1606 (linux_xfer_osdata_modules): Likewise.
1607 * remote.c (register_remote_support_xml): Likewise.
1608 * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
1609 * xml-syscall.c (syscall_create_syscall_desc): Likewise.
1610
1611 2019-11-06 Tom Tromey <tom@tromey.com>
1612
1613 * tui/tui-interp.c: Don't include readline.h.
1614 * tui/tui-hooks.c: Don't include readline.h.
1615 * symmisc.c: Include tilde.h, not readline.h.
1616 * symfile.c: Include tilde.h, not readline.h.
1617 * source.c: Include tilde.h, not readline.h.
1618 * solib.c: Include tilde.h, not readline.h.
1619 * psymtab.c: Include tilde.h, not readline.h.
1620 * exec.c: Include tilde.h, not readline.h.
1621 * corelow.c: Include tilde.h, not readline.h.
1622 * cli/cli-dump.c: Include tilde.h, not readline.h.
1623 * cli/cli-cmds.c: Don't include readline.h.
1624
1625 2019-11-05 Tom Tromey <tom@tromey.com>
1626
1627 * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
1628 (tui_disassemble): Set addr_size.
1629 (tui_disasm_window::set_contents): Use addr_size.
1630
1631 2019-11-05 Tom Tromey <tom@tromey.com>
1632
1633 * rust-lang.c (rust_language_defn): Update.
1634 * python/py-value.c (valpy_string): Call c_get_string.
1635 * p-lang.c (pascal_language_defn): Update.
1636 * opencl-lang.c (opencl_language_defn): Update.
1637 * objc-lang.c (objc_language_defn): Update.
1638 * m2-lang.c (m2_language_defn): Update.
1639 * language.c (unknown_language_defn, auto_language_defn): Update.
1640 (default_get_string): Remove.
1641 * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
1642 * go-lang.c (go_language_defn): Update.
1643 * f-lang.c (f_language_defn): Update.
1644 * d-lang.c (d_language_defn): Update.
1645 * c-lang.c (c_language_defn, cplus_language_defn)
1646 (asm_language_defn, minimal_language_defn): Update.
1647 * ada-lang.c (ada_language_defn): Update.
1648 * language.h (struct language_defn) <la_get_string>: Remove.
1649 (LA_GET_STRING): Remove.
1650 (default_get_string): Don't declare.
1651
1652 2019-11-05 Tom Tromey <tom@tromey.com>
1653
1654 * tui/tui-source.h (struct tui_source_window): Inline
1655 constructor. Remove destructor.
1656 <style_changed, m_observable>: Move to superclass.
1657 * tui/tui-winsource.h (tui_copy_source_line): Declare.
1658 (struct tui_source_window_base): Move private members to end.
1659 <style_changed, m_observable>: Move from tui_source_window.
1660 * tui/tui-winsource.c (tui_copy_source_line): Move from
1661 tui-source.c. Rename from copy_source_line. Add special handling
1662 for negative line number.
1663 (tui_source_window_base::style_changed): Move from
1664 tui_source_window.
1665 (tui_source_window_base): Register observer.
1666 (~tui_source_window_base): New.
1667 * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
1668 rename.
1669 (tui_source_window::set_contents): Use tui_copy_source_line.
1670 (tui_source_window::tui_source_window): Move to tui-source.h.
1671 (tui_source_window::~tui_source_window): Remove.
1672 (tui_source_window::style_changed): Move to superclass.
1673 * tui/tui-disasm.c (tui_disassemble): Create string file with
1674 styling, when possible. Add "addr_size" parameter.
1675 (tui_disasm_window::set_contents): Use tui_copy_source_line.
1676 Don't compute maximum size.
1677 (len_without_escapes): New function
1678
1679 2019-11-05 Tom Tromey <tom@tromey.com>
1680
1681 * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
1682 std::string.
1683 * tui/tui-winsource.c (tui_show_source_line): Update.
1684 * tui/tui-source.c (tui_source_window::set_contents): Update.
1685 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1686
1687 2019-11-05 Christian Biesinger <cbiesinger@google.com>
1688
1689 * symtab.h (gdb_static_assert): Put && operator at the beginning
1690 of the line instead of the end.
1691
1692 2019-11-04 Christian Biesinger <cbiesinger@google.com>
1693
1694 * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
1695 and sizeof (symbol).
1696 * symtab.h: Add a static_assert for sizeof (partial_symbol).
1697
1698 2019-11-04 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
1699
1700 * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
1701 * configure.host: Mark *-*-solaris2.10* obsolete.
1702 * configure.tgt: Mark Solaris < 11 obsolete.
1703 * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
1704 Update target triplet.
1705
1706 2019-11-01 Tom Tromey <tromey@adacore.com>
1707
1708 * utils.c (print_sys_errmsg): Simplify.
1709
1710 2019-11-01 Tom Tromey <tromey@adacore.com>
1711
1712 * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
1713
1714 2019-11-01 Christian Biesinger <cbiesinger@google.com>
1715
1716 * configure: Regenerate.
1717 * configure.ac: Remove check for strerror_r.
1718 * gdbsupport/common.m4: Check for strerror_r.
1719
1720 2019-11-01 Luis Machado <luis.machado@linaro.org>
1721
1722 PR gdb/25124
1723
1724 * arm-tdep.c (arm_per_objfile): Rename to ...
1725 (arm_per_bfd): ... this.
1726 (arm_objfile_data_key): Rename to ...
1727 (arm_bfd_data_key): ... this.
1728 (arm_find_mapping_symbol): Adjust access to new bfd_key-based
1729 data.
1730 (arm_record_special_symbol): Likewise.
1731
1732 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1733
1734 * ada-typeprint.c (ada_print_typedef): Don't print newline at the
1735 end.
1736 * c-typeprint.c (c_print_typedef): Likewise.
1737 * f-typeprint.c (f_print_typedef): Likewise.
1738 * m2-typeprint.c (m2_print_typedef): Likewise.
1739 * p-typeprint.c (pascal_print_typedef): Likewise.
1740 * rust-lang.c (rust_print_typedef): Likewise.
1741 * symtab.c (print_symbol_info): Print a newline after calling
1742 typedef_print.
1743
1744 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1745
1746 * symtab.c (info_module_cmdlist): New variable.
1747 (info_module_command): New function.
1748 (search_module_symbols): New function.
1749 (info_module_subcommand): New function.
1750 (struct info_modules_var_func_options): New struct.
1751 (info_modules_var_func_options_defs): New variable.
1752 (make_info_modules_var_func_options_def_group): New function.
1753 (info_module_functions_command): New function.
1754 (info_module_variables_command): New function.
1755 (info_module_var_func_command_completer): New function.
1756 (_initialize_symtab): Register new 'info module functions' and
1757 'info module variables' commands.
1758 * symtab.h (typedef symbol_search_in_module): New typedef.
1759 (search_module_symbols): Declare new function.
1760 * NEWS: Mention new commands.
1761
1762 2019-10-31 Andrew Burgess <andrew.burgess@embecosm.com>
1763
1764 * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
1765 (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
1766 (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
1767 MODULES_DOMAIN.
1768 (scan_partial_symbols): Only create partial module symbols for non
1769 declarations.
1770 * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
1771 and MODULES_DOMAIN.
1772 * symtab.c (search_domain_name): Likewise.
1773 (search_symbols): Likewise.
1774 (print_symbol_info): Likewise.
1775 (symtab_symbol_info): Likewise.
1776 (info_modules_command): New function.
1777 (_initialize_symtab): Register 'info modules' command.
1778 * symtab.h (enum search_domain): Add MODULES_DOMAIN.
1779 * NEWS: Mention new 'info modules' command.
1780
1781 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1782
1783 * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
1784 and $_gdb_maint_setting_str.
1785
1786 2019-10-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
1787
1788 * cli/cli-cmds.c (setting_cmd, value_from_setting)
1789 (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
1790 (str_value_from_setting, gdb_setting_str_internal_fn)
1791 (gdb_maint_setting_str_internal_fn): New functions.
1792 (_initialize_cli_cmds): Define the new convenience functions.
1793 * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
1794 * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
1795
1796 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1797
1798 * agent.c (set_can_use_agent): When the setting is turned on,
1799 look up agent symbols if we don't have them yet.
1800 (agent_new_objfile): Don't look up agent symbols when the agent
1801 setting is off.
1802
1803 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1804
1805 * config.in: Regenerate.
1806
1807 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1808
1809 * configure: Regenerate.
1810 * configure.ac: Check for strerror_r.
1811 * gdbsupport/common-utils.h (safe_strerror): Change return value
1812 to const char * and document that this function is now threadsafe.
1813 * gdbsupport/posix-strerror.c (safe_strerror): Make buf
1814 thread_local and call strerror_r, if available.
1815 * utils.c (perror_string): Update.
1816 (print_sys_errmsg): Update.
1817
1818 2019-10-31 Luis Machado <luis.machado@linaro.org>
1819
1820 * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
1821 objfile_key.
1822 (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
1823 objfile to fetch per-bfd data.
1824 (arm_find_exidx_entry): Likewise.
1825
1826 2019-10-31 Christian Biesinger <cbiesinger@google.com>
1827
1828 * gdbsupport/agent.c (debug_agent): Change type to bool.
1829 (use_agent): Likewise.
1830 (all_agent_symbols_look_up): Likewise.
1831 (agent_loaded_p): Change return value to bool.
1832 (agent_look_up_symbols): Update.
1833 (agent_capability_check): Change return value to bool.
1834 * gdbsupport/agent.h (agent_loaded_p): Likewise.
1835 (debug_agent): Change type to bool.
1836 (use_agent): Likewise.
1837 (agent_capability_check): Change return value to bool.
1838
1839 2019-10-30 Christian Biesinger <cbiesinger@google.com>
1840
1841 * minsyms.c (clear_minimal_symbol_hash_tables): New function.
1842 (build_minimal_symbol_hash_tables): Code to clear the table moved
1843 to clear_minimal_symbol_hash_tables.
1844 (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
1845 when needed.
1846
1847 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1848
1849 * infcmd.c: Remove includes.
1850 * infrun.c: Remove includes.
1851
1852 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1853
1854 * ada-lang.h (GROW_VECT): Move to ada-lang.c.
1855 (grow_vect): Remove declaration.
1856 (ada_type_of_array): Remove declaration.
1857 (ada_update_initial_language): Remove declaration.
1858 (ada_fold_name): Remove declaration.
1859 (ada_fill_in_ada_prototype): Remove declaration.
1860 (user_select_syms): Remove declaration.
1861 (get_selections): Remove declaration.
1862 (ada_tag_type): Remove declaration.
1863 (ada_value_tag): Remove declaration.
1864 (ada_is_others_clause): Remove declaration.
1865 (ada_in_variant): Remove declaration.
1866 (ada_value_struct_elt): Remove declaration.
1867 (ada_attribute_name): Remove declaration.
1868 (ada_system_address_type): Remove declaration.
1869 * ada-lang.c (ada_watch_location_expression): Make static.
1870 (GROW_VECT): Move here from ada-lang.h.
1871 (grow_vect): Make static.
1872 (ada_update_initial_language): Make static.
1873 (ada_fold_name): Make static.
1874 (ada_type_of_array): Make static.
1875 (encoded_ordered_before): Move up.
1876 (sort_choices): Move up.
1877 (print_signatures): Move up.
1878 (ada_print_symbol_signature): Move up.
1879 (get_selections): Move up and make static.
1880 (user_select_syms): Move up and make static.
1881 (ada_value_struct_elt): Move up and make static.
1882 (ada_tag_type): Make static.
1883 (ada_value_tag): Make static.
1884 (ada_is_others_clause): Make static.
1885 (ada_in_variant): Make static.
1886 (ada_attribute_name): Make static.
1887
1888 2019-10-29 Simon Marchi <simon.marchi@polymtl.ca>
1889
1890 * ada-lang.c: Remove includes.
1891 * ada-typeprint.c: Remove includes.
1892 * ada-valprint.c: Remove includes.
1893
1894 2019-10-29 Simon Marchi <simon.marchi@efficios.com>
1895
1896 * addrmap.c: Add static assertions of type size, moved from
1897 _initialize_addrmap.
1898 (_initialize_addrmap): Remove.
1899
1900 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1901
1902 * coffread.c (record_minimal_symbol): Update.
1903 (process_coff_symbol): Update.
1904 * dbxread.c (read_dbx_symtab): Update.
1905 * dwarf2read.c (add_partial_symbol): Update.
1906 (fixup_go_packaging): Update.
1907 (load_partial_dies): Update.
1908 (new_symbol): Update.
1909 * elfread.c (record_minimal_symbol): Change signature to use
1910 gdb::string_view instead of name+len.
1911 (elf_symtab_read): Update.
1912 (elf_rel_plt_read): Update.
1913 * mdebugread.c (parse_partial_symbols): Update.
1914 (handle_psymbol_enumerators): Update.
1915 (new_symbol): Update.
1916 * minsyms.c (minimal_symbol_reader::record_full): Change signature
1917 to use gdb::string_view instead of name+len.
1918 * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
1919 * psympriv.h (add_psymbol_to_list): Likewise.
1920 * psymtab.c (add_psymbol_to_bcache): Likewise.
1921 (add_psymbol_to_list): Likewise.
1922 * stabsread.c (define_symbol): Update.
1923 * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
1924 * symtab.h (SYMBOL_SET_NAMES): Likewise.
1925 (symbol_set_names): Likewise.
1926 * xcoffread.c (scan_xcoff_symtab): Update.
1927
1928 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1929
1930 * symtab.h (symbol_set_names): Document that copy_name must be
1931 set to true for non-nullterminated strings.
1932 * symtab.c (symbol_set_names): Only make a nullterminated copy of
1933 linkage_name if the entry was not found and we need to demangle.
1934
1935 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1936
1937 * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
1938 * dwarf2-frame.c (bsearch_fde_cmp): Update.
1939 (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
1940 * gdbsupport/gdb_binary_search.h: New file.
1941
1942 2019-10-29 Christian Biesinger <cbiesinger@google.com>
1943
1944 * NEWS: Mention new --with-system-gdbinit-dir option.
1945 * config.in: Regenerate.
1946 * configure: Regenerate.
1947 * configure.ac: Add new option --with-system-gdbinit-dir.
1948 * extension.c (get_ext_lang_of_file): Return extension_language_gdb
1949 for a ".gdb" suffix.
1950 * main.c (get_init_files): Change system_gdbinit argument to
1951 a vector and return the files in SYSTEM_GDBINIT_DIR in
1952 addition to SYSTEM_GDBINIT.
1953 (captured_main_1): Update.
1954 (print_gdb_help): Update.
1955 * top.c (print_gdb_configuration): Also print the value of
1956 SYSTEM_GDBINIT_DIR.
1957
1958 2019-10-28 Christian Biesinger <cbiesinger@google.com>
1959
1960 * gdbsupport/common-utils.h (startswith): Add an overloaded version
1961 that takes gdb::string_view arguments.
1962
1963 2019-10-26 Tom de Vries <tdevries@suse.de>
1964
1965 * aarch64-linux-tdep.c: Fix typos in comments.
1966 * aarch64-tdep.c: Same.
1967 * ada-lang.c: Same.
1968 * amd64-nat.c: Same.
1969 * arc-tdep.c: Same.
1970 * arch/aarch64-insn.c: Same.
1971 * block.c: Same.
1972 * breakpoint.h: Same.
1973 * btrace.h: Same.
1974 * c-varobj.c: Same.
1975 * cli/cli-decode.c: Same.
1976 * cli/cli-script.c: Same.
1977 * cli/cli-utils.h: Same.
1978 * coff-pe-read.c: Same.
1979 * coffread.c: Same.
1980 * compile/compile-cplus-symbols.c: Same.
1981 * compile/compile-object-run.c: Same.
1982 * completer.c: Same.
1983 * corelow.c: Same.
1984 * cp-support.c: Same.
1985 * demangle.c: Same.
1986 * dwarf-index-write.c: Same.
1987 * dwarf2-frame.c: Same.
1988 * dwarf2-frame.h: Same.
1989 * eval.c: Same.
1990 * frame-base.h: Same.
1991 * frame.h: Same.
1992 * gdbcmd.h: Same.
1993 * gdbtypes.h: Same.
1994 * gnu-nat.c: Same.
1995 * guile/scm-objfile.c: Same.
1996 * i386-tdep.c: Same.
1997 * i386-tdep.h: Same.
1998 * infcall.c: Same.
1999 * infcall.h: Same.
2000 * linux-nat.c: Same.
2001 * m68k-tdep.c: Same.
2002 * macroexp.c: Same.
2003 * memattr.c: Same.
2004 * mi/mi-cmd-disas.c: Same.
2005 * mi/mi-getopt.h: Same.
2006 * mi/mi-main.c: Same.
2007 * minsyms.c: Same.
2008 * nat/aarch64-sve-linux-sigcontext.h: Same.
2009 * objfiles.h: Same.
2010 * ppc-linux-nat.c: Same.
2011 * ppc-linux-tdep.c: Same.
2012 * ppc-tdep.h: Same.
2013 * progspace.h: Same.
2014 * prologue-value.h: Same.
2015 * python/py-evtregistry.c: Same.
2016 * python/py-instruction.h: Same.
2017 * record-btrace.c: Same.
2018 * record-full.c: Same.
2019 * remote.c: Same.
2020 * rs6000-tdep.c: Same.
2021 * ser-tcp.c: Same.
2022 * sol-thread.c: Same.
2023 * sparc-sol2-tdep.c: Same.
2024 * sparc64-tdep.c: Same.
2025 * stabsread.c: Same.
2026 * symfile.c: Same.
2027 * symtab.h: Same.
2028 * target.c: Same.
2029 * tracepoint.c: Same.
2030 * tui/tui-data.h: Same.
2031 * tui/tui-io.c: Same.
2032 * tui/tui-win.c: Same.
2033 * tui/tui.c: Same.
2034 * unittests/rsp-low-selftests.c: Same.
2035 * user-regs.h: Same.
2036 * utils.c: Same.
2037 * utils.h: Same.
2038 * valarith.c: Same.
2039 * valops.c: Same.
2040 * valprint.c: Same.
2041 * valprint.h: Same.
2042 * value.c: Same.
2043 * value.h: Same.
2044 * varobj.c: Same.
2045 * x86-nat.h: Same.
2046 * xtensa-tdep.c: Same.
2047
2048 2019-10-25 Ali Tamur <tamur@google.com>
2049
2050 * charset.c (find_charset_names): Reflect API change.
2051
2052 2019-10-25 Christian Biesinger <cbiesinger@google.com>
2053
2054 * symtab.c (struct demangled_name_entry): Change demangled name
2055 to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2056 part of the struct anymore.
2057 (symbol_set_names): No longer obstack allocate + copy the demangled
2058 name, just store the allocated name from bfd.
2059
2060 2019-10-25 Tom Tromey <tromey@adacore.com>
2061
2062 * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2063 (bsearch_cie_cmp, add_cie): Remove.
2064 (find_cie): Reimplement.
2065 (decode_frame_entry_1, decode_frame_entry): Change type. Update.
2066 (dwarf2_build_frame_info): Update.
2067
2068 2019-10-24 H.J. Lu <hongjiu.lu@intel.com>
2069
2070 PR gdb/25126
2071 * symfile.c (reread_symbols): Call forget_cached_source_info to
2072 clear the stale source cache.
2073
2074 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2075
2076 * configure: Regenerate.
2077 * configure.ac: Remove code that sets python_has_threads.
2078
2079 2019-10-24 Christian Biesinger <cbiesinger@google.com>
2080
2081 * config.in: Regenerate.
2082 * configure: Regenerate.
2083 * configure.ac: Remove the code that uses sed to get the python
2084 version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2085
2086 2019-10-24 Andrew Burgess <andrew.burgess@embecosm.com>
2087
2088 * python/py-progspace.c (pspy_block_for_pc): Return None for all
2089 error paths.
2090
2091 2019-10-23 Tom Tromey <tom@tromey.com>
2092
2093 * arc-tdep.c: Remove ".." from include.
2094 * frv-tdep.c: Remove ".." from include.
2095 * lm32-tdep.c: Remove ".." from include.
2096 * microblaze-tdep.c: Remove ".." from include.
2097 * or1k-tdep.h: Remove ".." from include.
2098 * s12z-tdep.c: Remove ".." from include.
2099 * Makefile.in (OPCODES_CFLAGS): Add comment.
2100 (TOP_CFLAGS): New variable.
2101 (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2102
2103 2019-10-23 Tom Tromey <tom@tromey.com>
2104
2105 * Makefile.in (READLINE_DIR): Update.
2106
2107 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2108
2109 * infcall.c (call_function_by_hand_dummy): Fix the function
2110 comment. And extract out a code section into...
2111 (reserve_stack_space): ...this new function.
2112
2113 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2114
2115 * infcall.c (value_arg_coerce): Remove an unused parameter.
2116 (call_function_by_hand_dummy): Update the call to
2117 'value_arg_coerce'.
2118
2119 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2120
2121 * infcall.c (call_function_by_hand_dummy): Refactor.
2122
2123 2019-10-23 Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
2124
2125 * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2126
2127 2019-10-23 Tom Tromey <tom@tromey.com>
2128
2129 * configure: Rebuild.
2130 * configure.ac: Don't check for sigprocmask.
2131 * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2132
2133 2019-10-23 Tom Tromey <tom@tromey.com>
2134
2135 * configure: Rebuild.
2136 * acinclude.m4: Use m4_include, not sinclude.
2137
2138 2019-10-23 Tom de Vries <tdevries@suse.de>
2139
2140 PR breakpoints/24687
2141 * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2142
2143 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2144
2145 * symtab.c (struct demangled_name_entry) <language>: Change from
2146 bitfield to regular variable.
2147
2148 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2149
2150 * symtab.c (struct demangled_name_entry): Add a constructor.
2151 (free_demangled_name_entry): New function to call the destructor
2152 for demangled_name_entry.
2153 (create_demangled_names_hash): Pass free_demangled_name_entry to
2154 htab_create_alloc.
2155 (symbol_set_names): Call placement new for demangled_name_entry.
2156 * utils.c: No longer include xxhash.h here, now that fast_hash
2157 is inlined in the header.
2158 * utils.h: Instead, include it here.
2159
2160 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2161
2162 * Makefile.in: Link with libxxhash.
2163 * config.in: Regenerate.
2164 * configure: Regenerate.
2165 * configure.ac: Search for libxxhash.
2166 * utils.c (fast_hash): Use xxhash if present.
2167
2168 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2169
2170 * utils.h (fast_hash): New function.
2171 * symtab.c (hash_demangled_name_entry): Call new function
2172 fast_hash.
2173
2174 2019-10-22 Christian Biesinger <cbiesinger@google.com>
2175
2176 * symtab.c (struct demangled_name_entry): Change type of mangled
2177 to gdb::string_view. Also adds a constructor that takes the
2178 mangled name.
2179 (hash_demangled_name_entry): Update.
2180 (eq_demangled_name_entry): Update.
2181 (free_demangled_name_entry): New function to call the destructor
2182 now that this is not a POD anymore.
2183 (create_demangled_names_hash): Pass free_demangled_name_entry to
2184 htab_create_alloc.
2185 (symbol_set_names): Update.
2186
2187 2019-10-21 Ali Tamur <tamu@google.com>
2188
2189 * dwarf2read.c (dir_index): Change type.
2190 (file_name_index): Likewise.
2191 (line_header::include_dir_at): Change comment and implementation on
2192 whether it is DWARF 5.
2193 (line_header::is_valid_file_index): New function.
2194 (line_header::file_name_at): Change comment and implementation on
2195 whether it is DWARF 5.
2196 (line_header::file_names): Change to private field renamed as
2197 m_file_names and introduce a new accessor method.
2198 (line_header::file_names_size): New method.
2199 (line_header::include_dirs): Change to private field and rename as
2200 m_include_dirs.
2201 (dw2_get_file_names_reader): Define local var at a smaller scope and
2202 reflect API change.
2203 (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2204 (process_structure_scope): Likewise.
2205 (line_header::add_include_dir): Change message and reflect renaming.
2206 (line_header::add_file_name): Likewise.
2207 (read_formatted_entries): Handle DW_FORM_data16.
2208 (dwarf_decode_line_header): Fix line header length calculation.
2209 (psymtab_include_file_name): Change comment and API.
2210 (lnp_state_machine::m_file): Update comment and reflect type change.
2211 (lnp_state_machine::record_line): Reflect type change.
2212 (dwarf_decode_lines): Reflect API change.
2213 (file_file_name): Likewise.
2214 (file_full_name): Likewise.
2215
2216 2019-10-21 Andrew Burgess <andrew.burgess@embecosm.com>
2217
2218 * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2219
2220 2019-10-21 Tom Tromey <tom@tromey.com>
2221
2222 * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2223
2224 2019-10-21 Tom Tromey <tom@tromey.com>
2225
2226 * configure.ac (nm.h): Conditionally create nm.h link. Subst
2227 NM_H. Use AC_CONFIG_LINKS.
2228 * configure: Rebuild.
2229 * Makefile.in (NM_H): New variable.
2230 (generated_files): Add NM_H. Remove gcore.
2231 (nm.h, stamp-nmh): New targets.
2232
2233 2019-10-20 Tom Tromey <tom@tromey.com>
2234
2235 * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2236 * objfiles.c (unlink_objfile): Move earlier. Now static. Remove
2237 obsolete comment.
2238 (put_objfile_before): Now static.
2239
2240 2019-10-19 Simon Marchi <simon.marchi@polymtl.ca>
2241
2242 * gdbsupport/common-utils.h (startswith): Change return type to
2243 bool.
2244
2245 2019-10-19 Christian Biesinger <cbiesinger@google.com>
2246
2247 * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2248 * breakpoint.c (bp_locations_compare): Rename to...
2249 (bp_location_is_less_than): ...this, and change to std::sort semantics.
2250 (update_global_location_list): Use std::sort instead of qsort.
2251 * buildsym.c (compare_line_numbers): Rename to...
2252 (lte_is_less_than): ...this, and change to std::sort semantics.
2253 (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
2254 instead of qsort.
2255 * disasm.c (compare_lines): Rename to...
2256 (line_is_less_than): ...this, and change to std::sort semantics.
2257 (do_mixed_source_and_assembly_deprecated): Call std::sort instead
2258 of qsort.
2259 * dwarf2-frame.c (qsort_fde_cmp): Rename to...
2260 (fde_is_less_than): ...this, and change to std::sort semantics.
2261 (dwarf2_build_frame_info): Call std::sort instead of qsort.
2262 * mdebugread.c (compare_blocks):
2263 (block_is_less_than): ...this, and change to std::sort semantics.
2264 (sort_blocks): Call std::sort instead of qsort.
2265 * objfiles.c (qsort_cmp): Rename to...
2266 (sort_cmp): ...this, and change to std::sort semantics.
2267 (update_section_map): Call std::sort instead of qsort.
2268 * remote.c (compare_pnums): Remove.
2269 (map_regcache_remote_table): Call std::sort instead of qsort.
2270 * utils.c (compare_positive_ints): Remove.
2271 * utils.h (compare_positive_ints): Remove.
2272 * xcoffread.c (compare_lte): Remove.
2273 (arrange_linetable): Call std::sort instead of qsort.
2274
2275 2019-10-19 Sergio Durigan Junior <sergiodj@redhat.com>
2276
2277 * symfile.c (init_entry_point_info): Fix typo.
2278 * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
2279
2280 2019-10-18 Tom de Vries <tdevries@suse.de>
2281
2282 * aarch64-tdep.c: Fix typos in comments.
2283 * ada-lang.c: Same.
2284 * ada-tasks.c: Same.
2285 * alpha-tdep.c: Same.
2286 * alpha-tdep.h: Same.
2287 * amd64-nat.c: Same.
2288 * amd64-windows-tdep.c: Same.
2289 * arc-tdep.c: Same.
2290 * arc-tdep.h: Same.
2291 * arch-utils.c: Same.
2292 * arm-nbsd-tdep.c: Same.
2293 * arm-tdep.c: Same.
2294 * ax-gdb.c: Same.
2295 * blockframe.c: Same.
2296 * btrace.c: Same.
2297 * c-varobj.c: Same.
2298 * coff-pe-read.c: Same.
2299 * coffread.c: Same.
2300 * cris-tdep.c: Same.
2301 * darwin-nat.c: Same.
2302 * dbxread.c: Same.
2303 * dcache.c: Same.
2304 * disasm.c: Same.
2305 * dtrace-probe.c: Same.
2306 * dwarf-index-write.c: Same.
2307 * dwarf2-frame-tailcall.c: Same.
2308 * dwarf2-frame.c: Same.
2309 * dwarf2read.c: Same.
2310 * eval.c: Same.
2311 * exceptions.c: Same.
2312 * fbsd-tdep.c: Same.
2313 * findvar.c: Same.
2314 * frame.c: Same.
2315 * frv-tdep.c: Same.
2316 * gnu-v3-abi.c: Same.
2317 * go32-nat.c: Same.
2318 * h8300-tdep.c: Same.
2319 * hppa-tdep.c: Same.
2320 * i386-linux-tdep.c: Same.
2321 * i386-tdep.c: Same.
2322 * ia64-libunwind-tdep.c: Same.
2323 * ia64-tdep.c: Same.
2324 * infcmd.c: Same.
2325 * infrun.c: Same.
2326 * linespec.c: Same.
2327 * linux-nat.c: Same.
2328 * linux-thread-db.c: Same.
2329 * machoread.c: Same.
2330 * mdebugread.c: Same.
2331 * mep-tdep.c: Same.
2332 * mn10300-tdep.c: Same.
2333 * namespace.c: Same.
2334 * objfiles.c: Same.
2335 * opencl-lang.c: Same.
2336 * or1k-tdep.c: Same.
2337 * osabi.c: Same.
2338 * ppc-linux-nat.c: Same.
2339 * ppc-linux-tdep.c: Same.
2340 * ppc-sysv-tdep.c: Same.
2341 * printcmd.c: Same.
2342 * procfs.c: Same.
2343 * record-btrace.c: Same.
2344 * record-full.c: Same.
2345 * remote-fileio.c: Same.
2346 * remote.c: Same.
2347 * rs6000-tdep.c: Same.
2348 * s12z-tdep.c: Same.
2349 * score-tdep.c: Same.
2350 * ser-base.c: Same.
2351 * ser-go32.c: Same.
2352 * skip.c: Same.
2353 * sol-thread.c: Same.
2354 * solib-svr4.c: Same.
2355 * solib.c: Same.
2356 * source.c: Same.
2357 * sparc-nat.c: Same.
2358 * sparc-sol2-tdep.c: Same.
2359 * sparc-tdep.c: Same.
2360 * sparc64-tdep.c: Same.
2361 * stabsread.c: Same.
2362 * stack.c: Same.
2363 * symfile.c: Same.
2364 * symtab.c: Same.
2365 * target-descriptions.c: Same.
2366 * target-float.c: Same.
2367 * thread.c: Same.
2368 * utils.c: Same.
2369 * valops.c: Same.
2370 * valprint.c: Same.
2371 * value.c: Same.
2372 * varobj.c: Same.
2373 * windows-nat.c: Same.
2374 * xcoffread.c: Same.
2375 * xstormy16-tdep.c: Same.
2376 * xtensa-tdep.c: Same.
2377
2378 2019-10-17 Tom Tromey <tromey@adacore.com>
2379
2380 * configure: Rebuild.
2381 * configure.ac: Use AC_CONFIG_HEADERS. Create stamp-h there, not
2382 in AC_CONFIG_FILES invocation.
2383 * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
2384 new-style config.status invocation.
2385
2386 2019-10-17 Tom de Vries <tdevries@suse.de>
2387
2388 * arm-nbsd-nat.c: Fix typos in comments.
2389 * arm-tdep.c: Same.
2390 * darwin-nat-info.c: Same.
2391 * dwarf2read.c: Same.
2392 * elfread.c: Same.
2393 * event-top.c: Same.
2394 * findvar.c: Same.
2395 * gdbtypes.c: Same.
2396 * hppa-tdep.c: Same.
2397 * i386-tdep.c: Same.
2398 * jit.c: Same.
2399 * main.c: Same.
2400 * mdebugread.c: Same.
2401 * moxie-tdep.c: Same.
2402 * nto-procfs.c: Same.
2403 * osabi.c: Same.
2404 * ppc-linux-tdep.c: Same.
2405 * remote.c: Same.
2406 * riscv-tdep.c: Same.
2407 * s390-tdep.c: Same.
2408 * sh-tdep.c: Same.
2409 * sparc-linux-tdep.c: Same.
2410 * sparc-nat.c: Same.
2411 * stack.c: Same.
2412 * target-descriptions.c: Same.
2413 * top.c: Same.
2414 * varobj.c: Same.
2415
2416 2019-10-16 Tom Tromey <tom@tromey.com>
2417
2418 * objfiles.h (struct objfile) <original_name>: Now const.
2419
2420 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2421
2422 * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
2423 pass on to sigsetjmp's second argument.
2424 * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
2425
2426 2019-10-16 Keith Seitz <keiths@redhat.com>
2427
2428 PR gdb/23567
2429 * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
2430 sections whose size is greater than the file size.
2431
2432 2019-10-16 Jim Wilson <jimw@sifive.com>
2433
2434 * riscv-tdep.c (riscv_gcc_target_options): New.
2435 (riscv_gnu_triplet_regexp): New.
2436 (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
2437 set_gdbarch_gnu_triplet_regexp.
2438
2439 2019-10-16 Christian Biesinger <cbiesinger@google.com>
2440
2441 * Makefile.in: Add xml-builtin.h.
2442 * features/feature_to_c.sh: Add an include for xml-builtin.h
2443 to ensure that the compiler checks that the types match.
2444 * xml-builtin.h: New file.
2445 * xml-support.c (fetch_xml_builtin): Add missing const.
2446 * xml-support.h: Remove declaration of xml_builtins.
2447
2448 2019-10-16 Tom de Vries <tdevries@suse.de>
2449
2450 PR tdep/25096
2451 * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
2452 (amd64_classify_aggregate): ... here.
2453 (amd64_classify_aggregate_field): Handled fiels of nested structs
2454 recursively.
2455
2456 2019-10-16 Tom de Vries <tdevries@suse.de>
2457
2458 PR tdep/24104
2459 * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
2460 that handles 'theclass'.
2461
2462 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2463
2464 * linespec.c (decode_digits_ordinary): Update comment.
2465 * make-target-delegates: No longer need to handle VEC case.
2466 * memrange.c (normalize_mem_ranges): Update comment.
2467 * namespace.c (add_using_directive): Update comment.
2468 * objc-lang.c (uniquify_strings): Update comment.
2469 * ppc-linux-nat.c (struct thread_points): Update comment.
2470 * probe.h (find_probes_in_objfile): Update comment.
2471 * target.h (enum flash_preserve_mode): Update comment.
2472 * varobj.c (varobj_restrict_range): Update comment.
2473 * varobj.h (varobj_list_children): Update comment.
2474
2475 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2476
2477 * Makefile.in: Remove references to vec.h and vec.c.
2478 * aarch64-tdep.c: No longer include vec.h.
2479 * ada-lang.c: Likewise.
2480 * ada-lang.h: Likewise.
2481 * arm-tdep.c: Likewise.
2482 * ax.h: Likewise.
2483 * breakpoint.h: Likewise.
2484 * charset.c: Likewise.
2485 * cp-support.h: Likewise.
2486 * dtrace-probe.c: Likewise.
2487 * dwarf2read.c: Likewise.
2488 * extension.h: Likewise.
2489 * gdb_bfd.c: Likewise.
2490 * gdbsupport/gdb_vecs.h: Likewise.
2491 * gdbsupport/vec.c: Remove.
2492 * gdbsupport/vec.h: Remove.
2493 * gdbthread.h: Likewise.
2494 * guile/scm-type.c: Likewise.
2495 * inline-frame.c: Likewise.
2496 * machoread.c: Likewise.
2497 * memattr.c: Likewise.
2498 * memrange.h: Likewise.
2499 * namespace.h: Likewise.
2500 * nat/linux-btrace.h: Likewise.
2501 * osdata.c: Likewise.
2502 * parser-defs.h: Likewise.
2503 * progspace.h: Likewise.
2504 * python/py-type.c: Likewise.
2505 * record-btrace.c: Likewise.
2506 * rust-exp.y: Likewise.
2507 * solib-target.c: Likewise.
2508 * stap-probe.c: Likewise.
2509 * target-descriptions.c: Likewise.
2510 * target-memory.c: Likewise.
2511 * target.h: Likewise.
2512 * varobj.c: Likewise.
2513 * varobj.h: Likewise.
2514 * xml-support.h: Likewise.
2515
2516 2019-10-15 Andrew Burgess <andrew.burgess@embecosm.com>
2517
2518 * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
2519 Update for new std::vector based implementation.
2520 (process_psymtab_comp_unit_reader): Likewise.
2521 (scan_partial_symbols): Likewise.
2522 (recursively_compute_inclusions): Likewise.
2523 (compute_compunit_symtab_includes): Likewise.
2524 (process_imported_unit_die): Likewise.
2525 (queue_and_load_dwo_tu): Likewise.
2526 (follow_die_sig_1): Likewise.
2527 * gdb/dwarf2read.h: Remove DEF_VEC_P.
2528 (typedef dwarf2_per_cu_ptr): Remove.
2529 (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
2530 function.
2531 (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
2532 (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
2533 (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
2534 (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
2535 std::vector.
2536
2537 2019-10-15 Tom Tromey <tromey@adacore.com>
2538
2539 * windows-nat.c (windows_nat_target::resume): Use %x when logging
2540 TID.
2541
2542 2019-10-15 Tom Tromey <tromey@adacore.com>
2543
2544 * windows-nat.c (windows_nat_target::fetch_registers)
2545 (windows_nat_target::store_registers): Rename "pid" to "tid".
2546
2547 2019-10-15 Tom Tromey <tromey@adacore.com>
2548
2549 * gdbarch.h, gdbarch.c: Rebuild.
2550 * gdbarch.sh (gcc_target_options): Change return type to
2551 std::string.
2552 * compile/compile.c (get_args): Update.
2553 * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
2554 * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
2555 std::string.
2556 * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
2557 std::string.
2558 * arch-utils.c (default_gcc_target_options): Return std::string.
2559 * arch-utils.h (default_gcc_target_options): Return std::string.
2560 * s390-tdep.c (s390_gcc_target_options): Return std::string.
2561
2562 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2563
2564 * breakpoint.c (breakpoint_chain): Make static.
2565 * tui/tui-winsource.c: Call iterate_over_breakpoints instead
2566 of accessing breakpoint_chain.
2567
2568 2019-10-15 Christian Biesinger <cbiesinger@google.com>
2569
2570 * breakpoint.c (iterate_over_breakpoints): Change function pointer
2571 to a gdb::function_view and return value to bool.
2572 * breakpoint.h (iterate_over_breakpoints): Likewise.
2573 * dummy-frame.c (pop_dummy_frame_bpt): Update.
2574 (pop_dummy_frame): Update.
2575 * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
2576 (gdbscm_breakpoints): Update.
2577 * python/py-breakpoint.c (build_bp_list): Update.
2578 (gdbpy_breakpoints): Update.
2579 * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
2580 Update.
2581 (bpfinishpy_handle_stop): Update.
2582 (bpfinishpy_handle_exit): Update.
2583 * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
2584 (svr4_update_solib_event_breakpoints): Update.
2585
2586 2019-10-15 Andreas Arnez <arnez@linux.ibm.com>
2587
2588 * s390-tdep.c (s390_effective_inner_type): Ignore static fields
2589 when unwrapping single-field structs.
2590
2591 2019-10-14 Simon Marchi <simon.marchi@polymtl.ca>
2592
2593 * dwarf2read.c: Remove includes.
2594
2595 2019-10-13 Simon Marchi <simon.marchi@polymtl.ca>
2596
2597 * ui-out.c (ui_out::call_do_message): Silence
2598 -Wformat-nonliteral warning.
2599
2600 2019-10-12 Simon Marchi <simon.marchi@polymtl.ca>
2601
2602 * breakpoint.c: Remove some includes: continuations.h, skip.h,
2603 mi/mi-main.h, readline/readline.h, readline/history.h. Add
2604 include: readline/tilde.h.
2605
2606 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2607
2608 * remote.c (remote_target::get_trace_status): Remove declaration of
2609 trace_regblock_size.
2610
2611 2019-10-12 Christian Biesinger <cbiesinger@google.com>
2612
2613 * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
2614 (show_user): Remove declaration of cmdlist.
2615 * cli/cli-cmds.h (max_user_call_depth): Declare.
2616 * cli/cli-script.c (execute_user_command): Remove declaration
2617 of max_user_call_depth.
2618
2619 2019-10-11 Jim Wilson <jimw@sifive.com>
2620
2621 * gdbsupport/print-utils.h (pulongest): Fix comment.
2622 (plongest): Likewise.
2623 (phex): Add missing comment, mention leading zeros.
2624 (phex_nz): Add mention of no leading zeros to comment.
2625
2626 * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
2627 plongest instead of unsigned long long cast.
2628
2629 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2630
2631 * main.c (captured_main_1): Include gdbtk.h and remove declarations
2632 for external_editor_command and gdbtk_test.
2633
2634 2019-10-10 Christian Biesinger <cbiesinger@google.com>
2635
2636 * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
2637 * varobj.c (varobjdebug): Move comment to...
2638 * varobj.h (varobjdebug): ...here, and declare.
2639
2640 2019-10-09 Tom Tromey <tom@tromey.com>
2641
2642 * tui/tui-regs.c (tui_data_window::show_registers): Don't call
2643 erase_data_content.
2644
2645 2019-10-09 Tom Tromey <tom@tromey.com>
2646
2647 * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
2648 * tui/tui-stack.c (tui_locator_window::rerender): Update.
2649 * tui/tui-command.c (tui_cmd_window::resize)
2650 (tui_refresh_cmd_win): Update.
2651 * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
2652 * tui/tui.c (tui_rl_other_window, tui_enable): Update.
2653 * tui/tui-data.c (~tui_gen_win_info): Remove.
2654 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
2655 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
2656 (tui_redisplay_readline, tui_mld_flush)
2657 (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
2658 * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
2659 (tui_data_window::erase_data_content)
2660 (tui_data_item_window::rerender)
2661 (tui_data_item_window::refresh_window): Update.
2662 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
2663 (box_win, tui_gen_win_info::make_window)
2664 (tui_gen_win_info::make_visible): Update.
2665 (tui_delete_win): Remove.
2666 * tui/tui-winsource.c
2667 (tui_source_window_base::do_erase_source_content): Update.
2668 (tui_show_source_line, tui_source_window_base::update_tab_width)
2669 (tui_source_window_base::update_exec_info): Update.
2670 * tui/tui-data.h (struct curses_deleter): New.
2671 (struct tui_gen_win_info) <handle>: Now a unique_ptr.
2672 (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
2673
2674 2019-10-09 Tom Tromey <tom@tromey.com>
2675
2676 * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
2677
2678 2019-10-09 Tom Tromey <tom@tromey.com>
2679
2680 * tui/tui-data.c (tui_win_is_auxiliary): Remove.
2681 * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
2682
2683 2019-10-09 Tom Tromey <tom@tromey.com>
2684
2685 * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
2686 window height directly.
2687 * tui/tui-layout.h (tui_default_win_viewport_height): Don't
2688 declare.
2689 * tui/tui-layout.c (tui_default_win_height): Remove.
2690 (tui_default_win_viewport_height): Remove.
2691
2692 2019-10-09 Tom Tromey <tom@tromey.com>
2693
2694 * tui/tui.h: Remove comments.
2695
2696 2019-10-09 Tom de Vries <tdevries@suse.de>
2697
2698 * python/lib/gdb/printer/bound_registers.py: Use
2699 '^builtin_type_bound128' as regexp argument for
2700 add_builtin_pretty_printer.
2701
2702 2019-10-09 Christian Biesinger <cbiesinger@google.com>
2703
2704 * guile/guile.c (guile_extension_script_ops): Remove forward
2705 declaration and mark as static.
2706 (guile_script_ops): Likewise.
2707 (extension_language_guile): Move further down in the file so
2708 it can reference the definitions for guile_{extension_,}script_ops.
2709
2710 2019-10-09 Andreas Arnez <arnez@linux.ibm.com>
2711
2712 * s390-tdep.c (390_process_record): Handle new arch13 instructions
2713 except SORTL, DFLTCC, and KDSA.
2714
2715 2019-10-08 Tom Tromey <tromey@adacore.com>
2716
2717 * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
2718 (struct safe_symbol_file_add_args): Remove.
2719
2720 2019-10-08 Tom Tromey <tromey@adacore.com>
2721
2722 * windows-nat.c: Don't include buildsym-legacy.h.
2723
2724 2019-10-08 Tom Tromey <tromey@adacore.com>
2725
2726 * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
2727
2728 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2729
2730 * gdbtypes.c (overload_debug): Move comment to header.
2731 * gdbtypes.h (overload_debug): Declare.
2732 * valops.c: Remove declaration of overload_debug, instead
2733 include gdbtypes.h.
2734
2735 2019-10-08 Christian Biesinger <cbiesinger@google.com>
2736
2737 * language.c (show_language_command): Pass lang_frame_mismatch_warn
2738 through _().
2739 (lang_frame_mismatch_warn): Make const, mark with N_(), and
2740 move comment...
2741 * language.h (lang_frame_mismatch_warn): ... here. Also add
2742 declaration.
2743 * top.c (lang_frame_mismatch_warn): Remove declaration.
2744 (check_frame_language_change): Pass lang_frame_mismatch_warn
2745 through _().
2746
2747 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2748
2749 * c-lang.h (vtbl_ptr_name): Declare.
2750 * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
2751 it from the header.
2752 * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
2753
2754 2019-10-07 Christian Biesinger <cbiesinger@google.com>
2755
2756 * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
2757 gdb_static_assert.
2758
2759 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2760
2761 * ../Makefile.def (dependencies): Add all-libctf to all-gdb
2762 * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
2763 * ctfread.c: New file.
2764 * ctfread.h: New file.
2765 * elfread.c: Include ctfread.h.
2766 (struct elfinfo text_p): New member ctfsect.
2767 (elf_locate_sections): Mark CTF section.
2768 (elf_symfile_read): Call elfctf_build_psymtabs.
2769 * Makefile.in (LIBCTF): Add.
2770 (CLIBS): Use it.
2771 (CDEPS): Likewise.
2772 (DIST): Add ctfread.c.
2773
2774 2019-10-07 Andrew Burgess <andrew.burgess@embecosm.com>
2775
2776 * ctfread.c (struct nextfield): Renamed to ...
2777 (struct ctf_nextfield): ... this.
2778 (struct field_info): Renamed to ...
2779 (strut ctf_field_info): ... this.
2780 (attach_fields_to_type): Update for renamed structures.
2781 (ctf_add_member_cb): Likewise.
2782 (ctf_add_enum_member_cb): Likewise.
2783 (process_struct_members): Likewise.
2784 (process_enum_type): Likewise.
2785
2786 2019-10-07 Weimin Pan <weimin.pan@oracle.com>
2787
2788 * tracectf.h: Rename, was ctf.h.
2789 * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
2790 * tracefile.c: Likewise.
2791 * tracepoint.c: Remove unused include ctf.h.
2792 * mi/mi-main.c: Likewise.
2793 * Makefile.in Replace ctf.c with tracectf.c.
2794
2795 2019-10-06 Joel Brobecker <brobecker@adacore.com>
2796
2797 * version.in: Change version number to "9.0.50.DATE-git".
2798
2799 2019-10-03 Tom Tromey <tom@tromey.com>
2800
2801 PR rust/24976:
2802 * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
2803
2804 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2805
2806 * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
2807 cp_search_name_hash.
2808 * NEWS: Add entry about nested function support.
2809
2810 2019-10-03 Bernhard Heckel <bernhard.heckel@intel.com>
2811 Andrew Burgess <andrew.burgess@embecosm.com>
2812
2813 * cp-namespace.c (cp_search_static_and_baseclasses): Only search
2814 for nested static variables when searchin VAR_DOMAIN.
2815 * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
2816 global scope, update comment.
2817 (add_partial_subprogram): Call add_partial_subprogram recursively
2818 for nested subroutines when processinng Fortran.
2819 (load_partial_dies): Process the child entities of a subprogram
2820 when processing Fortran.
2821 (partial_die_parent_scope): Handle building scope
2822 for Fortran nested functions.
2823 (process_die): Record that nested functions have a scope.
2824 (new_symbol): Always record Fortran subprograms on the global
2825 symbol list.
2826 (determine_prefix): How to build the prefix for Fortran
2827 subprograms.
2828
2829 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2830
2831 * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
2832 have just sent the thread a SIGSTOP and are waiting for it to
2833 arrive.
2834
2835 2019-10-03 Andrew Burgess <andrew.burgess@embecosm.com>
2836
2837 * btrace.c (btrace_add_pc): Remove whitespace before the template
2838 parameter in 'std::vector <...>'.
2839 (parse_xml_btrace_block): Likewise.
2840 (btrace_maint_decode_pt): Likewise.
2841 (btrace_maint_update_packets): Likewise.
2842 (btrace_maint_print_packets): Likewise.
2843 * btrace.h (struct btrace_maint_info): Likewise.
2844 * dwarf2read.c (struct type_unit_group): Likewise.
2845 (build_type_psymtabs_reader): Likewise.
2846 * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
2847 * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
2848 * nat/linux-btrace.c (perf_event_read_bts): Likewise.
2849
2850 2019-10-03 Tom de Vries <tdevries@suse.de>
2851
2852 * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
2853 the first line of the help text for set/show style metadata.
2854
2855 2019-10-02 Tom Tromey <tromey@adacore.com>
2856
2857 * Makefile.in (COMMON_SFILES): Add common-inferior.c.
2858 * gdbsupport/common-inferior.c: New file.
2859 * infcmd.c (startup_with_shell): Don't define.
2860 * nat/fork-inferior.h (startup_with_shell): Don't declare.
2861 * gdbsupport/common-inferior.h (startup_with_shell): Declare.
2862 * inferior.h (startup_with_shell): Don't declare.
2863
2864 2019-10-02 Christian Biesinger <cbiesinger@google.com>
2865
2866 * gdbsupport/gdb_assert.h: Include errors.h.
2867 * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
2868
2869 2019-10-02 Tom Tromey <tromey@adacore.com>
2870
2871 * NEWS: Add $_ada_exception entry.
2872 * ada-lang.c (struct ada_catchpoint): Add constructor.
2873 <m_kind>: New member.
2874 (allocate_location_exception, re_set_exception): Remove
2875 "ex" parameter.
2876 (should_stop_exception): Compute $_ada_exception.
2877 (check_status_exception, print_it_exception)
2878 (print_one_exception, print_mention_exception): Remove
2879 "ex" parameter.
2880 (allocate_location_catch_exception, re_set_catch_exception)
2881 (check_status_exception, print_it_catch_exception)
2882 (print_one_catch_exception, print_mention_catch_exception)
2883 (print_recreate_catch_exception)
2884 (allocate_location_catch_exception_unhandled)
2885 (re_set_catch_exception_unhandled)
2886 (check_status_exception, print_it_catch_exception_unhandled)
2887 (print_one_catch_exception_unhandled)
2888 (print_mention_catch_exception_unhandled)
2889 (print_recreate_catch_exception_unhandled)
2890 (allocate_location_catch_assert, re_set_catch_assert)
2891 (check_status_assert, print_it_catch_assert)
2892 (print_one_catch_assert, print_mention_catch_assert)
2893 (print_recreate_catch_assert)
2894 (allocate_location_catch_handlers, re_set_catch_handlers)
2895 (check_status_handlers, print_it_catch_handlers)
2896 (print_one_catch_handlers, print_mention_catch_handlers)
2897 (print_recreate_catch_handlers): Remove.
2898 (create_ada_exception_catchpoint): Update.
2899 (initialize_ada_catchpoint_ops): Update.
2900
2901 2019-10-02 Tom Tromey <tromey@adacore.com>
2902
2903 * ada-lang.c (ada_lookup_simple_minsyms): Remove.
2904 (create_excep_cond_exprs): Simplify exception string computation.
2905 (ada_exception_catchpoint_cond_string): Likewise.
2906
2907 2019-10-02 Tom Tromey <tromey@adacore.com>
2908
2909 * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
2910 * ada-lang.c (lesseq_defined_than): Handle
2911 LOC_STATIC.
2912 * dwarf2read.c (dwarf2_per_objfile): Add can_copy
2913 parameter.
2914 (dwarf2_has_info): Likewise.
2915 (new_symbol): Set maybe_copied on symbol when
2916 appropriate.
2917 * dwarf2read.h (dwarf2_per_objfile): Add can_copy
2918 parameter.
2919 <can_copy>: New member.
2920 * elfread.c (record_minimal_symbol): Set maybe_copied
2921 on symbol when appropriate.
2922 (elf_symfile_read): Update call to dwarf2_has_info.
2923 * minsyms.c (lookup_minimal_symbol_linkage): New
2924 function.
2925 * minsyms.h (lookup_minimal_symbol_linkage): Declare.
2926 * symtab.c (get_symbol_address, get_msymbol_address):
2927 New functions.
2928 * symtab.h (get_symbol_address, get_msymbol_address):
2929 Declare.
2930 (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
2931 maybe_copied.
2932 (struct symbol, struct minimal_symbol) <maybe_copied>:
2933 New member.
2934
2935 2019-10-02 Tom Tromey <tromey@adacore.com>
2936
2937 * source.c (struct current_source_location): New.
2938 (current_source_key): New global.
2939 (current_source_symtab, current_source_line)
2940 (current_source_pspace): Remove.
2941 (get_source_location): New function.
2942 (get_current_source_symtab_and_line)
2943 (set_default_source_symtab_and_line)
2944 (set_current_source_symtab_and_line)
2945 (clear_current_source_symtab_and_line, select_source_symtab)
2946 (info_source_command, print_source_lines_base)
2947 (info_line_command, search_command_helper, _initialize_source):
2948 Update.
2949
2950 2019-10-02 Tom Tromey <tromey@adacore.com>
2951
2952 * source.c (select_source_symtab): Don't call
2953 decode_line_with_current_source.
2954
2955 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2956
2957 * symtab.c (lookup_global_symbol): Search global block.
2958
2959 2019-10-02 Tom Tromey <tromey@adacore.com>
2960
2961 * coffread.c (process_coff_symbol): Update.
2962 * dwarf2read.c (var_decode_location, new_symbol): Update.
2963 * mdebugread.c (parse_symbol): Update.
2964 * objfiles.c (relocate_one_symbol): Update.
2965 * stabsread.c (define_symbol, fix_common_block)
2966 (scan_file_globals): Update.
2967 * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
2968 (SET_SYMBOL_VALUE_ADDRESS): New macro.
2969 * xcoffread.c (process_xcoff_symbol): Update.
2970
2971 2019-10-02 Andreas Arnez <arnez@linux.ibm.com>
2972
2973 * MAINTAINERS: Update my email address.
2974
2975 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2976
2977 * dwarf2read.c (struct type_unit_group) <tus>: Convert to
2978 std::vector.
2979 (build_type_psymtabs_reader): Update for std::vector.
2980 (build_type_psymtab_dependencies): Likewise.
2981 * dwarf2read.h: Remove use of DEF_VEC_P.
2982 (typedef sig_type_ptr): Delete.
2983
2984 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
2985
2986 * btrace.c (btrace_maint_clear): Update to handle change from VEC
2987 to std::vector.
2988 (btrace_maint_decode_pt): Likewise, and move allocation of the
2989 vector outside of the loop.
2990 (btrace_maint_update_packets): Update to handle change from VEC to
2991 std::vector.
2992 (btrace_maint_print_packets): Likewise.
2993 (maint_info_btrace_cmd): Likewise.
2994 * btrace.h: Remove use of DEF_VEC_O.
2995 (typedef btrace_pt_packet_s): Delete.
2996 (struct btrace_maint_info) <packets>: Change fromm VEC to
2997 std::vector.
2998 * gdbsupport/btrace-common.h: Remove 'vec.h' include.
2999
3000 2019-10-02 Andrew Burgess <andrew.burgess@embecosm.com>
3001
3002 * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3003 make accesses into the vector constant references.
3004 (btrace_add_pc): Update for std::vector.
3005 (btrace_stitch_bts): Likewise.
3006 (parse_xml_btrace_block): Likewise.
3007 (btrace_maint_update_packets): Likewise.
3008 (btrace_maint_print_packets): Likewise.
3009 (maint_info_btrace_cmd): Likewise.
3010 * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3011 std::vector.
3012 (btrace_data::empty): Likewise.
3013 (btrace_data_append): Likewise.
3014 * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3015 (typedef btrace_block_s): Delete.
3016 (struct btrace_block): Add constructor.
3017 (struct btrace_data_bts) <blocks>: Change to std::vector.
3018 * nat/linux-btrace.c (perf_event_read_bts): Update for
3019 std::vector.
3020 (linux_read_bts): Likewise.
3021
3022 2019-10-01 Tom Tromey <tom@tromey.com>
3023
3024 * cli/cli-logging.c (show_logging_filename): Use styled_string.
3025
3026 2019-10-01 Tom Tromey <tom@tromey.com>
3027
3028 * stack.c (print_frame, info_frame_command_core): Use
3029 styled_string.
3030 * linux-thread-db.c (try_thread_db_load_1)
3031 (try_thread_db_load_from_pdir_1): Use styled_string.
3032 * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3033 (auto_load_section_scripts, info_auto_load_local_gdbinit)
3034 (maybe_print_unsupported_script_warning)
3035 (maybe_print_script_not_found_warning): Use styled_string.
3036 * ada-lang.c (user_select_syms): Use styled_string.
3037
3038 2019-10-01 Tom Tromey <tom@tromey.com>
3039
3040 * p-lang.c (pascal_printstr): Use metadata style.
3041 * value.c (show_convenience): Use metadata style.
3042 * valprint.c (valprint_check_validity, val_print_optimized_out)
3043 (val_print_not_saved, val_print_unavailable)
3044 (val_print_invalid_address, generic_val_print, val_print)
3045 (value_check_printable, val_print_array_elements): Use metadata
3046 style.
3047 * ui-out.h (class ui_out) <field_fmt>: New overload.
3048 <do_field_fmt>: Add style parameter.
3049 * ui-out.c (ui_out::field_fmt): New overload.
3050 * typeprint.c (type_print_unknown_return_type)
3051 (val_print_not_allocated, val_print_not_associated): Use metadata
3052 style.
3053 * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3054 parameter.
3055 * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3056 * tracepoint.c (tvariables_info_1): Use metadata style.
3057 * stack.c (print_frame_arg, print_frame_info, print_frame)
3058 (info_frame_command_core): Use metadata style.
3059 * skip.c (info_skip_command): Use metadata style.
3060 * rust-lang.c (rust_print_enum): Use metadata style.
3061 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3062 metadata style.
3063 * python/py-framefilter.c (py_print_single_arg): Use metadata
3064 style.
3065 * printcmd.c (do_one_display, print_variable_and_value): Use
3066 metadata style.
3067 * p-valprint.c (pascal_val_print)
3068 (pascal_object_print_value_fields): Use metadata style.
3069 * p-typeprint.c (pascal_type_print_base): Use metadata style.
3070 * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3071 parameter.
3072 * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3073 * m2-valprint.c (m2_print_long_set): Use metadata style.
3074 * m2-typeprint.c (m2_print_type): Use metadata style.
3075 * infcmd.c (print_return_value_1): Use metadata style.
3076 * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3077 * f-valprint.c (info_common_command_for_block): Use metadata
3078 style.
3079 * f-typeprint.c (f_type_print_base): Use metadata style.
3080 * expprint.c (print_subexp_standard): Use metadata style.
3081 * cp-valprint.c (cp_print_value_fields): Use metadata style.
3082 * cli/cli-style.h (class cli_style_option): Add constructor.
3083 (metadata_style): Declare.
3084 * cli/cli-style.c (metadata_style): New global.
3085 (_initialize_cli_style): Register metadata style.
3086 * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3087 parameter.
3088 * cli-out.c (cli_ui_out::do_field_fmt): Update.
3089 * c-typeprint.c (c_type_print_base_struct_union)
3090 (c_type_print_base_1): Use metadata style.
3091 * breakpoint.c (watchpoint_value_print)
3092 (print_one_breakpoint_location): Use metadata style.
3093 * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3094 style.
3095 * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3096 style.
3097 * ada-valprint.c (val_print_packed_array_elements, printstr)
3098 (print_field_values, ada_val_print_ref, ada_val_print): Use
3099 metadata style.
3100 * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3101 style.
3102 * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3103 style.
3104 * ada-lang.c (user_select_syms): Use metadata style.
3105
3106 2019-10-01 Tom Tromey <tom@tromey.com>
3107
3108 * cli/cli-cmds.c (pwd_command): Style output.
3109
3110 2019-10-01 Pedro Alves <palves@redhat.com>
3111 Tom Tromey <tom@tromey.com>
3112
3113 * symtab.c (print_symbol_info): Use %ps.
3114 (print_msymbol_info): Use %ps.
3115 * symfile.c (symbol_file_add_with_addrs): Use %ps.
3116 * printcmd.c (print_variable_and_value): Use %ps.
3117 * macrocmd.c (show_pp_source_pos): Use %ps.
3118 * infrun.c (print_exited_reason): Use ui_out::message.
3119 * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3120 (describe_other_breakpoints): Use ui_out::message and new
3121 formats.
3122 (say_where): Use new formats.
3123 (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3124 and new formats.
3125
3126 2019-10-01 Pedro Alves <palves@redhat.com>
3127 Tom Tromey <tom@tromey.com>
3128
3129 * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3130 (test_gdb_formats): New function.
3131 (run_tests): Call it.
3132 (test_format_specifier): Update.
3133 * utils.h (fputs_filtered): Update comment.
3134 (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3135 (fputs_styled_unfiltered): Declare.
3136 * utils.c (fputs_styled_unfiltered): New function.
3137 (vfprintf_maybe_filtered): Add gdbfmt parameter.
3138 (vfprintf_filtered): Update.
3139 (vfprintf_unfiltered, vprintf_filtered): Update.
3140 (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3141 * ui-out.h (enum ui_out_flag) <unfiltered_output,
3142 disallow_ui_out_field>: New constants.
3143 (enum class field_kind): New.
3144 (struct base_field_s, struct signed_field_s): New.
3145 (signed_field): New function.
3146 (struct string_field_s): New.
3147 (string_field): New function.
3148 (struct styled_string_s): New.
3149 (styled_string): New function.
3150 (class ui_out) <message>: Add comment.
3151 <vmessage, call_do_message>: New methods.
3152 <do_message>: Add style parameter.
3153 * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3154 methods.
3155 (ui_out::message): Rewrite.
3156 * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3157 parameter.
3158 * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3159 * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3160 gdb_extensions parameter.
3161 (class format_piece): Add parameter to constructor.
3162 (n_int_args): New field.
3163 * gdbsupport/format.c (format_pieces::format_pieces): Add
3164 gdb_extensions parameter. Handle '*'.
3165 * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3166 * cli-out.c (cli_ui_out::do_message): Add style parameter. Call
3167 vfprintf_styled_no_gdbfmt.
3168 (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3169 (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3170 unfiltered output.
3171 * ui-style.h (struct ui_file_style) <ptr>: New method.
3172
3173 2019-10-01 Tom Tromey <tom@tromey.com>
3174
3175 * unittests/format_pieces-selftests.c: Update. Add final format.
3176 * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3177 empty literal pieces.
3178
3179 2019-10-01 Tom Tromey <tom@tromey.com>
3180
3181 * ui-out.h (enum class ui_out_style_kind): Remove.
3182 (class ui_out) <field_string, field_stsream, do_field_string>:
3183 Change type of "style".
3184 * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3185 (ui_out::field_string): Update.
3186 * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3187 of "style".
3188 * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3189 * tracepoint.c (print_one_static_tracepoint_marker): Update.
3190 * stack.c (print_frame_arg, print_frame_info, print_frame):
3191 Update.
3192 * source.c (print_source_lines_base): Update.
3193 * solib.c (info_sharedlibrary_command): Update.
3194 * skip.c (info_skip_command): Update.
3195 * record-btrace.c (btrace_call_history_src_line)
3196 (btrace_call_history): Update.
3197 * python/py-framefilter.c (py_print_frame): Update.
3198 * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3199 "style".
3200 * mi/mi-out.c (mi_ui_out::do_table_header)
3201 (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3202 (mi_ui_out::do_field_string): Update.
3203 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3204 Update.
3205 * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3206 "style".
3207 * cli-out.c (cli_ui_out::do_table_header)
3208 (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3209 (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3210 (cli_ui_out::do_field_fmt): Update.
3211 * breakpoint.c (print_breakpoint_location): Update.
3212 (update_static_tracepoint): Update.
3213
3214 2019-10-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
3215
3216 * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3217 conversion of gdb_datadir.
3218 (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3219 remove not needed c_str ().
3220
3221 2019-09-30 Ali Tamur <tamur@google.com>
3222
3223 * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3224 (dwarf2_string_attr): Likewise.
3225
3226 2019-09-30 Ali Tamur <tamur@google.com>
3227
3228 * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3229 (process_full_type_unit): Likewise.
3230 (dump_die_shallow): Likewise.
3231 (cu_debug_loc_section): Likewise.
3232
3233 2019-09-28 Christian Biesinger <cbiesinger@google.com>
3234
3235 * minsyms.c (compare_minimal_symbols): Rename to...
3236 (minimal_symbol_is_less_than): ...this, and adjust to STL
3237 conventions (return bool, take arguments as references)
3238 (minimal_symbol_reader::install): Call std::sort instead
3239 of qsort.
3240
3241 2019-09-29 Christian Biesinger <cbiesinger@google.com>
3242
3243 * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3244 hash and why.
3245 * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3246 msymbol_hash, msymbol_demangled_hash>: Improve comments.
3247
3248 2019-09-30 Simon Marchi <simon.marchi@polymtl.ca>
3249
3250 * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
3251 * psympriv.h (add_psymbol_to_list): Move comment here and update
3252 it.
3253
3254 2019-09-29 Tom de Vries <tdevries@suse.de>
3255
3256 * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
3257 Use $tmpdir/$(basename "$output_file").dwz instead of
3258 "${output_file}.dwz".
3259
3260 2019-09-28 Simon Marchi <simon.marchi@polymtl.ca>
3261
3262 PR gdb/25045
3263 * hppa-linux-nat.c: Include gdbarch.h.
3264
3265 2019-09-26 Christian Biesinger <cbiesinger@google.com>
3266
3267 * blockframe.c (find_pc_partial_function): Change return type to bool.
3268 * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
3269 * minsyms.c (in_gnu_ifunc_stub): Likewise.
3270 (stub_gnu_ifunc_resolve_name): Likewise.
3271 * symtab.c (compare_filenames_for_search): Likewise.
3272 (compare_glob_filenames_for_search): Likewise.
3273 (matching_obj_sections): Likewise.
3274 (symbol_matches_domain): Likewise.
3275 (find_line_symtab): Change out param EXACT_MATCH to bool *.
3276 (find_line_pc): Change return type to bool.
3277 (find_line_pc_range): Likewise.
3278 (producer_is_realview): Likewise.
3279 * symtab.h (symbol_matches_domain): Likewise.
3280 (find_pc_partial_function): Likewise.
3281 (find_pc_line_pc_range): Likewise.
3282 (in_gnu_ifunc_stub): Likewise.
3283 (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
3284 (find_line_pc): Likewise.
3285 (find_line_pc_range): Likewise.
3286 (matching_obj_sections): Likewise.
3287 (find_line_symtab): Change out parameter to bool.
3288 (producer_is_realview): Change return type to bool.
3289 (compare_filenames_for_search): Likewise.
3290 (compare_glob_filenames_for_search): Likewise.
3291
3292 2019-09-26 Tom Tromey <tom@tromey.com>
3293
3294 * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
3295 (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
3296 * gdb_usleep.h: Remove.
3297 * gdb_usleep.c: Remove.
3298 * utils.c: Don't include gdb_usleep.h.
3299
3300 2019-09-26 Tom Tromey <tromey@adacore.com>
3301
3302 * python/py-type.c (type_to_type_object): Call check_typedef
3303 for stub types.
3304
3305 2019-09-26 Tom Tromey <tom@tromey.com>
3306
3307 * utils.h (initialize_utils): Don't declare.
3308 * top.c (gdb_init): Don't call initialize_utils.
3309 * utils.c (initialize_utils): Remove. Move contents...
3310 (_initialize_utils): ... here.
3311
3312 2019-09-25 Tom Tromey <tom@tromey.com>
3313
3314 * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
3315 * utils.h (make_hex_string): Don't declare.
3316 * utils.c (make_hex_string): Remove.
3317
3318 2019-09-24 Tom de Vries <tdevries@suse.de>
3319
3320 PR gdb/23815
3321 * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
3322 Initialize xstateregs before ptrace PTRACE_GETREGSET call.
3323
3324 2019-09-23 Dimitar Dimitrov <dimitar@dinux.eu>
3325
3326 * NEWS: Mention new simulator port for PRU.
3327
3328 2019-09-23 Christian Biesinger <cbiesinger@google.com>
3329
3330 * ada-exp.y (write_object_remaining): Update.
3331 * ada-lang.c (ada_decode): Return a std::string instead of a char*
3332 and eliminate the static buffer.
3333 (ada_decode_symbol): Update.
3334 (ada_la_decode): Update.
3335 (ada_sniff_from_mangled_name): Update.
3336 (is_valid_name_for_wild_match): Update.
3337 (ada_lookup_name_info::matches): Update and simplify.
3338 (name_matches_regex): Update.
3339 (ada_add_global_exceptions): Update.
3340 * ada-lang.h (ada_decode): Update signature.
3341 * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
3342 * dwarf-index-write.c (debug_names::insert): Update.
3343
3344 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3345
3346 * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
3347 formatting.
3348
3349 2019-09-21 Simon Marchi <simon.marchi@polymtl.ca>
3350
3351 * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
3352 Change "nonzero" to "true" in documentation.
3353
3354 2019-09-20 Christian Biesinger <cbiesinger@google.com>
3355
3356 * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
3357 (_initialize_darwin_solib): Don't set
3358 darwin_so_ops.lookup_lib_global_symbol.
3359 * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
3360 set_gdbarch_iterate_over_objfiles_in_search_order.
3361 (elf_lookup_lib_symbol): Rename to...
3362 (svr4_iterate_over_objfiles_in_search_order): this, and update
3363 to iterate semantics.
3364 (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
3365 * solib.c (solib_global_lookup): Remove.
3366 * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
3367 (solib_global_lookup): Remove.
3368 * symtab.c (lookup_global_or_static_symbol): Remove call to
3369 solib_global_lookup.
3370
3371 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3372
3373 * NEWS: Move entries about default MI version now being
3374 version 3, and about the GDB/MI fix for multi-location
3375 breakpoints to the "since GDB 8.3" section.
3376
3377 2019-09-20 Joel Brobecker <brobecker@adacore.com>
3378
3379 GDB 8.3.1 released.
3380
3381 2019-09-20 Ulrich Weigand <uweigand@de.ibm.com>
3382
3383 * NEWS: Mention that Cell/B.E. debugging support was removed.
3384 * MAINTAINERS: Remove spu target.
3385
3386 * config/djgpp/fnchange.lst: Remove entries for removed files.
3387
3388 * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
3389 spu-multiarch.o, and spu-tdep.o.
3390 (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
3391 (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
3392 spu-multiarch.c, and spu-tdep.c.
3393 * spu-linux-nat.c: Remove file.
3394 * spu-multiarch.c: Remove file.
3395 * spu-tdep.c: Remove file.
3396 * spu-tdep.h: Remove file.
3397 * solib-spu.c: Remove file.
3398 * solib-spu.h: Remove file.
3399
3400 * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
3401 * configure.nat (spu-linux): Remove.
3402 * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
3403 solib-multiarch.o from gdb_target_obs.
3404 (spu*-*-*): Remove.
3405
3406 * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
3407 feature flag.
3408 (ppc_linux_no_features): Update.
3409 * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
3410 Cell/B.E. support.
3411 * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
3412 (tdesc_powerpc_cell64l): Likewise.
3413 * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
3414 * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
3415 Cell/B.E. support.
3416 * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
3417 Do not include "features/rs6000/powerpc-cell32l.c" or
3418 "features/rs6000/powerpc-cell64l.c".
3419 (ppc_linux_spu_section): Remove.
3420 (ppc_linux_core_read_description): Remove Cell/B.E. support.
3421 (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
3422 spe_context_cache_ptid, spe_context_cache_ptid): Remove.
3423 (ppc_linux_spe_context_lookup): Remove.
3424 (ppc_linux_spe_context_inferior_created): Remove.
3425 (ppc_linux_spe_context_solib_loaded): Remove.
3426 (ppc_linux_spe_context_solib_unloaded): Remove.
3427 (ppc_linux_spe_context): Remove.
3428 (struct ppu2spu_cache): Remove.
3429 (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
3430 (struct ppu2spu_data): Remove.
3431 (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
3432 ppu2spu_unwind): Remove.
3433 (ppc_linux_init_abi): Remove Cell/B.E. support.
3434 * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
3435
3436 * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
3437 (rs6000/powerpc-cell64l-expedite): Likewise
3438 (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
3439 (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
3440 rs6000/powerpc-cell64l.xml.
3441 * features/rs6000/powerpc-cell32l.xml: Remove.
3442 * features/rs6000/powerpc-cell64l.xml: Likewise.
3443 * features/rs6000/powerpc-cell32l.c: Remove generated file.
3444 * features/rs6000/powerpc-cell64l.c: Likewise.
3445 * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
3446 * regformats/rs6000/powerpc-cell64l.dat: Likewise.
3447 * regformats/reg-spu.dat: Remove.
3448
3449 * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
3450 * corelow.c (struct spuid_list): Remove.
3451 (add_to_spuid_list): Remove.
3452 (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3453 * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
3454 (remote_protocol_features): Remove associated entries.
3455 (_initialize_remote): No longer initialize them.
3456 (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3457 * linux-nat.c (SPUFS_MAGIC): Remove.
3458 (linux_proc_xfer_spu): Remove.
3459 (spu_enumerate_spu_ids): Remove.
3460 (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
3461 * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
3462 (linux_make_corefile_notes): No longer call it.
3463
3464 * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
3465 (cooked_write_test): Likewise.
3466
3467 2019-09-20 Tom Tromey <tom@tromey.com>
3468
3469 * NEWS: Mention case-sensitivity of TUI commands.
3470 * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
3471 (tui_set_win_height_command, parse_scrolling_args): Likewise.
3472 * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
3473
3474 2019-09-20 Tom Tromey <tom@tromey.com>
3475
3476 * tui/tui-source.c (tui_source_window::set_contents): Use
3477 make_unique_xstrdup.
3478 * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
3479 make_unique_xstrdup.
3480
3481 2019-09-20 Tom Tromey <tom@tromey.com>
3482
3483 * tui/tui-data.c: Remove separator comments.
3484 * tui/tui-layout.c: Remove separator comments.
3485 * tui/tui-win.c: Remove separator comments.
3486 * tui/tui-wingeneral.c: Remove separator comments.
3487
3488 2019-09-20 Tom Tromey <tom@tromey.com>
3489
3490 * tui/tui.h (strcat_to_buf): Don't declare.
3491 * tui/tui.c (strcat_to_buf): Remove.
3492
3493 2019-09-20 Tom Tromey <tom@tromey.com>
3494
3495 * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
3496 from "fullname".
3497 * tui/tui-source.c (tui_source_window::set_contents)
3498 (tui_source_window::location_matches_p)
3499 (tui_source_window::maybe_update): Update.
3500
3501 2019-09-20 Tom Tromey <tom@tromey.com>
3502
3503 * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
3504 Update.
3505 <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
3506 prefix.
3507 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
3508 (tui_data_window::line_from_reg_element_no)
3509 (tui_data_window::first_reg_element_no_inline)
3510 (tui_data_window::show_registers)
3511 (tui_data_window::show_register_group)
3512 (tui_data_window::display_registers_from)
3513 (tui_data_window::display_registers_from_line)
3514 (tui_data_window::first_data_item_displayed)
3515 (tui_data_window::delete_data_content_windows)
3516 (tui_data_window::erase_data_content)
3517 (tui_data_window::do_scroll_vertical)
3518 (tui_data_window::refresh_window)
3519 (tui_data_window::check_register_values): Update.
3520
3521 2019-09-20 Tom Tromey <tom@tromey.com>
3522
3523 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
3524 (struct tui_locator_window) <full_name, proc_name>: Now
3525 std::string.
3526 * tui/tui-stack.c (tui_locator_window::make_status_line)
3527 (tui_locator_window::set_locator_fullname)
3528 (tui_locator_window::set_locator_info): Update.
3529 * tui/tui-source.c (tui_source_window::set_contents)
3530 (tui_source_window::showing_source_p): Update.
3531
3532 2019-09-20 Tom Tromey <tom@tromey.com>
3533
3534 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
3535 Don't call tui_locator_win_info_ptr.
3536
3537 2019-09-20 Tom Tromey <tom@tromey.com>
3538
3539 * tui/tui-win.c (tui_resize_all): Don't call refresh.
3540
3541 2019-09-20 Tom Tromey <tom@tromey.com>
3542
3543 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
3544 height for locator.
3545 * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
3546 * tui/tui-layout.c (show_source_disasm_command, show_data)
3547 (show_source_or_disasm_and_command): Use 1 as height for locator.
3548
3549 2019-09-20 Tom Tromey <tom@tromey.com>
3550
3551 * tui/tui.c (tui_enable): Update.
3552 * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
3553 Update.
3554 * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
3555 Update.
3556 * tui/tui-data.c (win_resized): Now bool.
3557 (tui_win_resized): Return bool.
3558 (tui_set_win_resized_to): Accept a bool.
3559
3560 2019-09-20 Tom Tromey <tom@tromey.com>
3561
3562 * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
3563 Change type of "refresh_values_only".
3564 * tui/tui-regs.c (tui_data_window::show_register_group): Change
3565 type of "refresh_values_only".
3566
3567 2019-09-20 Tom Tromey <tom@tromey.com>
3568
3569 * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
3570 std::string.
3571 (tui_disassemble): Add "pos" parameter.
3572 (tui_disasm_window::set_contents): Simplify.
3573
3574 2019-09-20 Tom Tromey <tom@tromey.com>
3575
3576 * tui/tui-winsource.h (struct tui_source_window_base)
3577 <show_source_content>: Now private.
3578 * tui/tui-winsource.c
3579 (tui_source_window_base::show_source_content): Don't handle empty
3580 content case.
3581
3582 2019-09-20 Tom Tromey <tom@tromey.com>
3583
3584 * tui/tui-layout.c (show_source_disasm_command)
3585 (show_source_or_disasm_and_command): Don't call
3586 show_source_content.
3587
3588 2019-09-20 Tom Tromey <tom@tromey.com>
3589
3590 * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
3591 Declare.
3592 * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
3593 from tui_make_status_line.
3594 (tui_locator_window::rerender): Update.
3595
3596 2019-09-20 Tom Tromey <tom@tromey.com>
3597
3598 * tui/tui-stack.c (tui_make_status_line): Return std::string.
3599 (tui_locator_window::rerender): Update.
3600
3601 2019-09-20 Tom Tromey <tom@tromey.com>
3602
3603 * tui/tui-winsource.h (struct tui_source_window_base)
3604 <~tui_source_window_base>: Don't declare.
3605 <fullname>: Remove.
3606 * tui/tui-winsource.c (~tui_source_window_base): Remove.
3607 * tui/tui-source.h (struct tui_source_window) <fullname>: New
3608 member.
3609 * tui/tui-source.c (tui_source_window::set_contents): Update.
3610 (tui_source_window::location_matches_p)
3611 (tui_source_window::maybe_update): Update.
3612
3613 2019-09-20 Tom Tromey <tom@tromey.com>
3614
3615 * tui/tui-winsource.h (~tui_source_element): Remove.
3616 (tui_source_element): Update.
3617 (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
3618 * tui/tui-winsource.c (tui_show_source_line): Update.
3619 * tui/tui-source.c (tui_source_window::set_contents): Update.
3620 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
3621
3622 2019-09-20 Tom Tromey <tom@tromey.com>
3623
3624 * tui/tui-data.h (tui_clear_source_windows_detail): Don't
3625 declare.
3626 * tui/tui-layout.c (tui_add_win_to_layout): Don't call
3627 tui_clear_source_windows_detail.
3628 * tui/tui-winsource.h (struct tui_source_window_base)
3629 <clear_detail>: Don't declare.
3630 * tui/tui-winsource.c (tui_source_window_base::clear_detail):
3631 Remove.
3632 * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
3633
3634 2019-09-20 Tom Tromey <tromey@adacore.com>
3635
3636 PR ada/24919:
3637 * block.c (contained_in): Fix final return value.
3638
3639 2019-09-20 Alan Modra <amodra@gmail.com>
3640
3641 * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
3642 * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
3643 (read_indirect_string_from_dwz): Use bfd accessor.
3644 * dwarf2read.h (struct dwz_file <filename>): Likewise.
3645 * machoread.c (macho_symfile_read_all_oso): Likewise.
3646 * solib.c (solib_bfd_open): Likewise.
3647
3648 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3649
3650 * eval.c: Move declaration of overload_resolution to...
3651 * value.h: ...here.
3652
3653 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3654
3655 * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
3656 * arm-linux-tdep.c: Likewise.
3657 * arm-nbsd-nat.c: Likewise.
3658 * arm-tdep.h: Declare arm_apcs_32.
3659 * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
3660
3661 2019-09-19 Christian Biesinger <cbiesinger@google.com>
3662
3663 * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
3664 * dwarf2read.h: Declare dwarf_always_disassemble.
3665
3666 2019-09-19 Tom de Vries <tdevries@suse.de>
3667
3668 PR gdb/25009
3669 * source-cache.c (source_cache::ensure): Catch exception thrown during
3670 construction of the highlighter.
3671
3672 2019-09-18 Alan Modra <amodra@gmail.com>
3673
3674 * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
3675 * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
3676 * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
3677 * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
3678 * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
3679 * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
3680 * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
3681 * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
3682 * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
3683 * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
3684 * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
3685 * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
3686 * solib-spu.c, * solib-svr4.c, * solib-target.c,
3687 * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
3688 * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
3689 * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
3690 * mi/mi-interp.c: Update throughout for bfd section macro and
3691 function changes.
3692 * gcore (gcore_create_callback): Use bfd_set_section_lma.
3693 * spu-tdep.c (spu_overlay_new_objfile): Likewise.
3694
3695 2019-09-18 Tom Tromey <tom@tromey.com>
3696
3697 * NEWS: Add entry.
3698 * tui/tui.c (tui_initialize_readline): Set name of keymap. Do not
3699 call rl_initialize.
3700 (tui_enable): Do not call rl_initialize.
3701
3702 2019-09-18 Christian Groessler <chris@groessler.org>
3703
3704 * alpha-linux-nat.c: Include gdbarch.h.
3705
3706 2019-09-18 Simon Marchi <simon.marchi@polymtl.ca>
3707
3708 * ui-file.c: Include cli/cli-style.h.
3709 (term_cli_styling): Remove cli_styling declaration.
3710
3711 2019-09-18 Alan Modra <amodra@gmail.com>
3712
3713 * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
3714 to bfd_asymbol_section.
3715
3716 2019-09-18 Alan Modra <amodra@gmail.com>
3717
3718 * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
3719 * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
3720 * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
3721
3722 2019-09-18 Alan Modra <amodra@gmail.com>
3723
3724 * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
3725 * spu-linux-nat.c (spu_bfd_open): Likewise.
3726
3727 2019-09-18 Christian Biesinger <cbiesinger@google.com>
3728
3729 * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
3730 to bool to match definition in dwarf2read.c.
3731
3732 2019-09-17 Christian Biesinger <cbiesinger@google.com>
3733
3734 * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
3735 (print_signatures): Likewise.
3736 (trust_pad_over_xvs): Likewise.
3737 * arch/aarch64-insn.c (aarch64_debug): Likewise.
3738 * arch/aarch64-insn.h (aarch64_debug): Likewise.
3739 * arm-linux-nat.c (arm_apcs_32): Likewise.
3740 * arm-linux-tdep.c (arm_apcs_32): Likewise.
3741 * arm-nbsd-nat.c (arm_apcs_32): Likewise.
3742 * arm-tdep.c (arm_debug): Likewise.
3743 (arm_apcs_32): Likewise.
3744 * auto-load.c (debug_auto_load): Likewise.
3745 (auto_load_gdb_scripts): Likewise.
3746 (global_auto_load): Likewise.
3747 (auto_load_local_gdbinit): Likewise.
3748 (auto_load_local_gdbinit_loaded): Likewise.
3749 * auto-load.h (global_auto_load): Likewise.
3750 (auto_load_local_gdbinit): Likewise.
3751 (auto_load_local_gdbinit_loaded): Likewise.
3752 * breakpoint.c (disconnected_dprintf): Likewise.
3753 (breakpoint_proceeded): Likewise.
3754 (automatic_hardware_breakpoints): Likewise.
3755 (always_inserted_mode): Likewise.
3756 (target_exact_watchpoints): Likewise.
3757 (_initialize_breakpoint): Update.
3758 * breakpoint.h (target_exact_watchpoints): Change to bool.
3759 * btrace.c (maint_btrace_pt_skip_pad): Likewise.
3760 * cli/cli-cmds.c (trace_commands): Likewise.
3761 * cli/cli-cmds.h (trace_commands): Likewise.
3762 * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
3763 to bool*.
3764 * cli/cli-logging.c (logging_overwrite): Change to bool.
3765 (logging_redirect): Likewise.
3766 (debug_redirect): Likewise.
3767 * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
3768 (struct boolean_option_def) <get_var_address_cb_>: Change return type
3769 to bool.
3770 <boolean_option_def>: Update.
3771 (struct flag_option_def): Change default type of Context to bool
3772 from int.
3773 <flag_option_def>: Change return type of var_address_cb_ to bool*.
3774 * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
3775 (get_setshow_command_value_string): Likewise.
3776 * cli/cli-style.c (cli_styling): Change to bool.
3777 (source_styling): Likewise.
3778 * cli/cli-style.h (source_styling): Likewise.
3779 (cli_styling): Likewise.
3780 * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
3781 to bool.
3782 * command.h (var_types): Update comment.
3783 (add_setshow_boolean_cmd): Change int* var argument to bool*.
3784 * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
3785 bool.
3786 (debug_compile_cplus_scopes): Likewise.
3787 * compile/compile-internal.h (compile_debug): Likewise.
3788 * compile/compile.c (compile_debug): Likewise.
3789 (struct compile_options) <raw>: Likewise.
3790 * cp-support.c (catch_demangler_crashes): Likewise.
3791 * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
3792 (usr_cmd_cris_dwarf2_cfi): Likewise.
3793 * csky-tdep.c (csky_debug): Likewise.
3794 * darwin-nat.c (enable_mach_exceptions): Likewise.
3795 * dcache.c (dcache_enabled_p): Likewise.
3796 * defs.h (info_verbose): Likewise.
3797 * demangle.c (demangle): Likewise.
3798 (asm_demangle): Likewise.
3799 * dwarf-index-cache.c (debug_index_cache): Likewise.
3800 * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
3801 * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
3802 * dwarf2read.c (check_physname): Likewise.
3803 (use_deprecated_index_sections): Likewise.
3804 (dwarf_always_disassemble): Likewise.
3805 * eval.c (overload_resolution): Likewise.
3806 * event-top.c (set_editing_cmd_var): Likewise.
3807 (exec_done_display_p): Likewise.
3808 * event-top.h (set_editing_cmd_var): Likewise.
3809 (exec_done_display_p): Likewise.
3810 * exec.c (write_files): Likewise.
3811 * fbsd-nat.c (debug_fbsd_lwp): Likewise
3812 (debug_fbsd_nat): Likewise.
3813 * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
3814 Likewise.
3815 (struct set_backtrace_options) <backtrace_past_main>: Likewise.
3816 <backtrace_past_entry> Likewise.
3817 * gdb-demangle.h (demangle): Likewise.
3818 (asm_demangle): Likewise.
3819 * gdb_bfd.c (bfd_sharing): Likewise.
3820 * gdbcore.h (write_files): Likewise.
3821 * gdbsupport/common-debug.c (show_debug_regs): Likewise.
3822 * gdbsupport/common-debug.h (show_debug_regs): Likewise.
3823 * gdbthread.h (print_thread_events): Likewise.
3824 * gdbtypes.c (opaque_type_resolution): Likewise.
3825 (strict_type_checking): Likewise.
3826 * gnu-nat.c (gnu_debug_flag): Likewise.
3827 * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
3828 * guile/scm-param.c (pascm_variable): Add boolval.
3829 (add_setshow_generic): Update.
3830 (pascm_param_value): Update.
3831 (pascm_set_param_value_x): Update.
3832 * hppa-tdep.c (hppa_debug): Change to bool..
3833 * infcall.c (may_call_functions_p): Likewise.
3834 (coerce_float_to_double_p): Likewise.
3835 (unwind_on_signal_p): Likewise.
3836 (unwind_on_terminating_exception_p): Likewise.
3837 * infcmd.c (startup_with_shell): Likewise.
3838 * inferior.c (print_inferior_events): Likewise.
3839 * inferior.h (startup_with_shell): Likewise.
3840 (print_inferior_events): Likewise.
3841 * infrun.c (step_stop_if_no_debug): Likewise.
3842 (detach_fork): Likewise.
3843 (debug_displaced): Likewise.
3844 (disable_randomization): Likewise.
3845 (non_stop): Likewise.
3846 (non_stop_1): Likewise.
3847 (observer_mode): Likewise.
3848 (observer_mode_1): Likewise.
3849 (set_observer_mode): Update.
3850 (sched_multi): Change to bool.
3851 * infrun.h (debug_displaced): Likewise.
3852 (sched_multi): Likewise.
3853 (step_stop_if_no_debug): Likewise.
3854 (non_stop): Likewise.
3855 (disable_randomization): Likewise.
3856 * linux-tdep.c (use_coredump_filter): Likewise.
3857 (dump_excluded_mappings): Likewise.
3858 * linux-thread-db.c (auto_load_thread_db): Likewise.
3859 (check_thread_db_on_load): Likewise.
3860 * main.c (captured_main_1): Update.
3861 * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
3862 xx2_opt, boolean_opt>: Change to bool.
3863 * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
3864 * maint.c (maintenance_profile_p): Likewise.
3865 (per_command_time): Likewise.
3866 (per_command_space): Likewise.
3867 (per_command_symtab): Likewise.
3868 * memattr.c (inaccessible_by_default): Likewise.
3869 * mi/mi-main.c (mi_async): Likewise.
3870 (mi_async_1): Likewise.
3871 * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
3872 * nat/fork-inferior.h (startup_with_shell): Likewise.
3873 * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
3874 * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
3875 * nios2-tdep.c (nios2_debug): Likewise.
3876 * or1k-tdep.c (or1k_debug): Likewise.
3877 * parse.c (parser_debug): Likewise.
3878 * parser-defs.h (parser_debug): Likewise.
3879 * printcmd.c (print_symbol_filename): Likewise.
3880 * proc-api.c (procfs_trace): Likewise.
3881 * python/py-auto-load.c (auto_load_python_scripts): Likewise.
3882 * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
3883 (set_parameter_value): Update.
3884 (add_setshow_generic): Update.
3885 * python/py-value.c (copy_py_bool_obj): Change argument from int*
3886 to bool*.
3887 * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
3888 int*.
3889 * ravenscar-thread.c (ravenscar_task_support): Change to bool.
3890 * record-btrace.c (record_btrace_target::store_registers): Update.
3891 * record-full.c (record_full_memory_query): Change to bool.
3892 (record_full_stop_at_limit): Likewise.
3893 * record-full.h (record_full_memory_query): Likewise.
3894 * remote-notif.c (notif_debug): Likewise.
3895 * remote-notif.h (notif_debug): Likewise.
3896 * remote.c (use_range_stepping): Likewise.
3897 (interrupt_on_connect): Likewise.
3898 (remote_break): Likewise.
3899 * ser-tcp.c (tcp_auto_retry): Likewise.
3900 * ser-unix.c (serial_hwflow): Likewise.
3901 * skip.c (debug_skip): Likewise.
3902 * solib-aix.c (solib_aix_debug): Likewise.
3903 * spu-tdep.c (spu_stop_on_load_p): Likewise.
3904 (spu_auto_flush_cache_p): Likewise.
3905 * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
3906 Likewise.
3907 (struct info_print_options) <quiet>: Likewise.
3908 * symfile-debug.c (debug_symfile): Likewise.
3909 * symfile.c (auto_solib_add): Likewise.
3910 (separate_debug_file_debug): Likewise.
3911 * symfile.h (auto_solib_add): Likewise.
3912 (separate_debug_file_debug): Likewise.
3913 * symtab.c (basenames_may_differ): Likewise.
3914 (struct filename_partial_match_opts) <dirname, basename>: Likewise.
3915 (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
3916 (struct info_types_options) <quiet>: Likewise.
3917 * symtab.h (demangle): Likewise.
3918 (basenames_may_differ): Likewise.
3919 * target-dcache.c (stack_cache_enabled_1): Likewise.
3920 (code_cache_enabled_1): Likewise.
3921 * target.c (trust_readonly): Likewise.
3922 (may_write_registers): Likewise.
3923 (may_write_memory): Likewise.
3924 (may_insert_breakpoints): Likewise.
3925 (may_insert_tracepoints): Likewise.
3926 (may_insert_fast_tracepoints): Likewise.
3927 (may_stop): Likewise.
3928 (auto_connect_native_target): Likewise.
3929 (target_stop_and_wait): Update.
3930 (target_async_permitted): Change to bool.
3931 (target_async_permitted_1): Likewise.
3932 (may_write_registers_1): Likewise.
3933 (may_write_memory_1): Likewise.
3934 (may_insert_breakpoints_1): Likewise.
3935 (may_insert_tracepoints_1): Likewise.
3936 (may_insert_fast_tracepoints_1): Likewise.
3937 (may_stop_1): Likewise.
3938 * target.h (target_async_permitted): Likewise.
3939 (may_write_registers): Likewise.
3940 (may_write_memory): Likewise.
3941 (may_insert_breakpoints): Likewise.
3942 (may_insert_tracepoints): Likewise.
3943 (may_insert_fast_tracepoints): Likewise.
3944 (may_stop): Likewise.
3945 * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
3946 (make_thread_apply_all_options_def_group): Change argument from int*
3947 to bool*.
3948 (thread_apply_all_command): Update.
3949 (print_thread_events): Change to bool.
3950 * top.c (confirm): Likewise.
3951 (command_editing_p): Likewise.
3952 (history_expansion_p): Likewise.
3953 (write_history_p): Likewise.
3954 (info_verbose): Likewise.
3955 * top.h (confirm): Likewise.
3956 (history_expansion_p): Likewise.
3957 * tracepoint.c (disconnected_tracing): Likewise.
3958 (circular_trace_buffer): Likewise.
3959 * typeprint.c (print_methods): Likewise.
3960 (print_typedefs): Likewise.
3961 * utils.c (debug_timestamp): Likewise.
3962 (sevenbit_strings): Likewise.
3963 (pagination_enabled): Likewise.
3964 * utils.h (sevenbit_strings): Likewise.
3965 (pagination_enabled): Likewise.
3966 * valops.c (overload_resolution): Likewise.
3967 * valprint.h (struct value_print_options) <prettyformat_arrays,
3968 prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
3969 stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
3970 pascal_static_field_print, raw, summary, symbol_print, finish_print>:
3971 Likewise.
3972 * windows-nat.c (new_console): Likewise.
3973 (cygwin_exceptions): Likewise.
3974 (new_group): Likewise.
3975 (debug_exec): Likewise.
3976 (debug_events): Likewise.
3977 (debug_memory): Likewise.
3978 (debug_exceptions): Likewise.
3979 (useshell): Likewise.
3980 * windows-tdep.c (maint_display_all_tib): Likewise.
3981 * xml-support.c (debug_xml): Likewise.
3982
3983 2019-09-17 Mike Gulick <mgulick@mathworks.com>
3984
3985 * source.c (prepare_path_for_appending): New function.
3986 (openp): Make use of new function.
3987 (find_and_open_source): Search for the compilation directory and
3988 source file as a relative path beneath the directory search path.
3989
3990 2019-09-17 Andrew Burgess <andrew.burgess@embecosm.com>
3991
3992 * source-cache.c (source_cache::get_line_charpos): Catch
3993 exceptions and return false, this matches the behaviour documented
3994 in the header file.
3995
3996 2019-09-17 Joel Brobecker <brobecker@adacore.com>
3997
3998 * ada-tasks.c (info_task): Remove quoting of the task's name.
3999
4000 2019-09-16 Christian Biesinger <cbiesinger@google.com>
4001
4002 * symfile.c (auto_solib_add): Replace comment with a reference
4003 to the header file.
4004
4005 2019-09-14 Christian Biesinger <cbiesinger@google.com>
4006
4007 * NEWS: Mention that gdb can now be compiled with Python 3
4008 on Windows.
4009
4010 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4011
4012 * maint.c (maint_print_section_data::maint_print_section_data):
4013 Force use of 'float log10 (float)' by casting the argument to
4014 float.
4015
4016 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4017
4018 * maint.c: Add 'cmath' include.
4019 (struct maint_print_section_data): New structure.
4020 (print_section_index): New function.
4021 (print_bfd_section_info): Add header comment, small whitespace
4022 cleanup, and update to call new print_section_index function.
4023 (print_objfile_section_info): Likewise.
4024 (maint_obj_section_from_bfd_section): New function.
4025 (print_bfd_section_info_maybe_relocated): New function.
4026 (maintenance_info_sections): Add header comment, always use
4027 bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4028
4029 2019-09-12 Andrew Burgess <andrew.burgess@embecosm.com>
4030
4031 * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4032 inner scope, add check that the objfile has psymtabs before
4033 checking psymtabs_addrmap.
4034 * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4035
4036 2019-09-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4037
4038 * NEWS: Announce that Ada task names are now shown at more places,
4039 and between quotes (except in info task output).
4040 * gdb/ada-tasks.c (task_to_str): New function.
4041 (display_current_task_id): Call task_to_str.
4042 (task_command_1): Likewise.
4043 (print_ada_task_info): In non-mi mode, Properly align headers and data
4044 when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4045
4046 2019-09-12 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
4047
4048 * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4049 prstatus.pr_lwp.pr_info instead of making it up.
4050
4051 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4052
4053 * auto-load.c (auto_load_expand_dir_vars): Update.
4054 * defs.h (gdb_datadir): Change to std::string.
4055 (python_libdir): Likewise.
4056 (relocate_gdb_directory): Change return type to std::string.
4057 * guile/guile.c (gdbscm_data_directory): Update.
4058 (initialize_scheme_side): Update.
4059 * jit.c (jit_reader_dir): Change to std::string.
4060 (jit_reader_load_command): Update.
4061 * main.c (gdb_datadir): Change to std::string.
4062 (python_libdir): Likewise.
4063 (set_gdb_data_directory): Update.
4064 (relocate_path): Change to return std::string.
4065 (relocate_gdb_directory): Change to return std::string.
4066 (relocate_gdbinit_path_maybe_in_datadir): Update.
4067 (captured_main_1): Update.
4068 * python/python.c (do_start_initialization): Update.
4069 * top.c (show_gdb_datadir): Update.
4070 * xml-syscall.c (xml_init_syscalls_info): Update.
4071 (init_syscalls_info): Update.
4072
4073 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4074
4075 * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4076 out of get_init_files.
4077 (get_init_files): Update.
4078
4079 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4080
4081 * main.c (get_init_files): Change to use std::string.
4082 (captured_main_1): Update.
4083 (print_gdb_help): Update.
4084
4085 2019-09-11 Ali Tamur <tamur@google.com>
4086
4087 *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4088 implementation.
4089
4090 2019-09-11 Christian Biesinger <cbiesinger@google.com>
4091
4092 * dbxread.c (read_dbx_symtab): Update.
4093 * dwarf2read.c (load_partial_dies): Update.
4094 * mdebugread.c (parse_partial_symbols): Update.
4095 (handle_psymbol_enumerators): Update.
4096 * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4097 * psymtab.c (add_psymbol_to_bcache): Likewise.
4098 (add_psymbol_to_list): Likewise.
4099 * symtab.c (symbol_set_names): Likewise.
4100 * symtab.h (symbol_set_names): Likewise.
4101 * xcoffread.c (scan_xcoff_symtab): Update.
4102
4103 2019-09-11 Tom Tromey <tom@tromey.com>
4104
4105 * symfile-mem.c (symbol_file_add_from_memory): Use
4106 bfd_set_filename.
4107 * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4108 * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4109
4110 2019-09-10 Tom Tromey <tromey@adacore.com>
4111
4112 * dwarf-index-write.c (write_psymbols): Extend error message.
4113 (debug_names::insert): Add Ada code.
4114 (debug_names::write_psymbols): Remove Ada check.
4115 (debug_names) <m_string_obstack>: New member.
4116 * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4117 (gdb_index_symbol_name_matcher::matches): Remove.
4118 (mapped_index_base::find_name_components_bounds): Add "lang"
4119 parameter.
4120 (mapped_index_base::build_name_components): Also split names
4121 according to Ada syntax.
4122 (dw2_expand_symtabs_matching_symbol): Loop over languages. Change
4123 type of "match_callback".
4124 (check_match, check_find_bounds_finds)
4125 (dw2_expand_symtabs_matching): Update.
4126 (dw2_debug_names_iterator): Add new constructor.
4127 (dw2_debug_names_map_matching_symbols): New function.
4128 (dw2_debug_names_expand_symtabs_matching): Update.
4129 (dwarf2_debug_names_functions): Use
4130 dw2_debug_names_map_matching_symbols.
4131
4132 2019-09-10 Tom Tromey <tromey@adacore.com>
4133
4134 * dwarf2read.c (dw2_get_file_names_reader): Add the
4135 CU's file name to the results.
4136
4137 2019-09-10 Tom Tromey <tromey@adacore.com>
4138
4139 * ada-lang.c (add_nonlocal_symbols): Combine calls to
4140 map_matching_symbols. Update.
4141 * dwarf2read.c (dw2_map_matching_symbols): Update.
4142 * psymtab.c (match_partial_symbol): Change type; update.
4143 (psym_map_matching_symbols): Likewise.
4144 * symfile-debug.c (debug_qf_map_matching_symbols): Change
4145 type; update.
4146 * symfile.h (struct quick_symbol_functions)
4147 <map_matching_symbols>: Change "name" to be a lookup_name_info.
4148 Remove "match".
4149
4150 2019-09-10 Tom Tromey <tromey@adacore.com>
4151
4152 * psymtab.c (map_block): Remove.
4153 (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4154 * symtab.c (iterate_over_symbols_terminated): New function.
4155 * symtab.c (iterate_over_symbols_terminated): Declare.
4156
4157 2019-09-10 Tom Tromey <tromey@adacore.com>
4158
4159 * ada-lang.c (ada_iterate_over_symbols): Return bool.
4160 * language.h (struct language_defn) <la_iterate_over_symbols>:
4161 Return bool.
4162 * symtab.c (iterate_over_symbols): Return bool.
4163 * symtab.h (iterate_over_symbols): Return bool.
4164
4165 2019-09-10 Tom Tromey <tromey@adacore.com>
4166
4167 * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4168 (add_nonlocal_symbols): Update.
4169 * dwarf2read.c (dw2_map_matching_symbols): Change type.
4170 * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4171 * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4172 * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4173 Change type of "callback". Remove "data".
4174
4175
4176 2019-09-09 Ali Tamur <tamur@google.com>
4177
4178 * dwarf2read.c (comp_unit_head): Update comment.
4179 (dwarf2_dwo_name): New function declaration.
4180 (dwarf_unit_type_name): New function declaration.
4181 (read_comp_unit_head): Add support for new compilation units,
4182 DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4183 Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4184 (currently named as "signature") in their header. Also clarify error
4185 messages.
4186 (lookup_dwo_id): New function. Returns the dwo id of the given
4187 compile unit.
4188 (lookup_dwo_unit): Use the new lookup_dwo_id function.
4189 (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4190 functions.
4191 (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4192 (dwarf2_dwo_name): Get the dwo name if present.
4193 (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4194 purposes.
4195
4196 2019-09-09 Tom Tromey <tom@tromey.com>
4197
4198 * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4199
4200 2019-09-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
4201
4202 * python/python.c (do_start_initialization): Make progname_copy static,
4203 to avoid a leak report.
4204
4205 2019-09-08 Tom Tromey <tom@tromey.com>
4206
4207 * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4208
4209 2019-09-07 Simon Marchi <simon.marchi@efficios.com>
4210
4211 * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4212 Change type to gdb::optional<block_enum>.
4213 (dw2_symtab_iter_init): Change block_index parameter type
4214 to gdb::optional<block_enum>.
4215 (dw2_lookup_symbol): Change block_index parameter
4216 type to block_enum.c
4217 (dw2_debug_names_lookup_symbol): Likewise.
4218 * psymtab.c (psym_lookup_symbol): Likewise.
4219 * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4220 * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4221 Likewise.
4222
4223 2019-09-06 Christian Biesinger <cbiesinger@google.com>
4224
4225 * defs.h (relocate_gdb_directory): Change int to bool in
4226 signature and rename flag to relocatable.
4227 * main.c (relocate_path): Likewise.
4228 (relocate_gdb_directory): Likewise.
4229
4230 2019-09-06 Alan Modra <amodra@gmail.com>
4231
4232 * coffread.c (coff_symfile_read): Constify filename variable.
4233 * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4234 (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4235 * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4236 * solib.c (reload_shared_libraries_1): Likewise.
4237 * symfile.c (reread_symbols): Likewise.
4238 * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4239 * solib-darwin.c (darwin_bfd_open): Likewise.
4240 * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4241
4242 2019-09-03 Andrew Burgess <andrew.burgess@embecosm.com>
4243
4244 * psymtab.c (print_partial_symbols): Handle missing domain_enum
4245 values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4246
4247 2019-09-03 Tom Tromey <tromey@adacore.com>
4248
4249 * ada-valprint.c (ada_val_print_num): Don't recurse for range
4250 types.
4251 (has_negatives): Unbias a range type bound.
4252 * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
4253 * gdbtypes.c (operator==): Handle new field.
4254 (create_range_type): Add "bias" parameter.
4255 (create_static_range_type, resolve_dynamic_range): Update.
4256 * gdbtypes.h (struct range_bounds) <bias>: New member.
4257 (create_range_type): Add bias parameter.
4258 * printcmd.c (print_scalar_formatted): Unbias range types.
4259 * value.c (unpack_long): Unbias range types.
4260 (pack_long): Bias range types.
4261
4262 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4263
4264 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
4265 probe arguments.
4266
4267 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4268
4269 * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
4270 * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
4271 * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
4272 (compile_probe_arg): Likewise.
4273 * probe.h (get_argument_count): Likewise.
4274 * solib-svr4.c (solib_event_probe_action): Likewise.
4275 * stap-probe.c (stap_probe::get_argument_count): Likewise.
4276
4277 2019-09-02 Alan Hayward <alan.hayward@arm.com>
4278
4279 * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
4280 code to here...
4281 (svr4_create_solib_event_breakpoints): ...from here.
4282
4283 2019-08-30 Sergio Durigan Junior <sergiodj@redhat.com>
4284
4285 * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
4286 suffix from warning message.
4287
4288 2019-08-30 Tom Tromey <tom@tromey.com>
4289
4290 * tui/tui-winsource.h (struct tui_source_window_base)
4291 <refresh_all>: Don't declare.
4292 * tui/tui-winsource.c (tui_source_window_base::refresh_all):
4293 Remove.
4294 * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
4295 tui_show_locator_content.
4296 * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
4297 declare.
4298 * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
4299 * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
4300 declare.
4301
4302 2019-08-30 Tom Tromey <tom@tromey.com>
4303
4304 * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
4305
4306 2019-08-30 Tom Tromey <tom@tromey.com>
4307
4308 * tui/tui-stack.c (_initialize_tui_stack): Move later.
4309 Remove unnecessary forward declarations.
4310
4311 2019-08-30 Tom Tromey <tom@tromey.com>
4312
4313 * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
4314 rerender.
4315 (tui_update_locator_fullname, tui_show_frame_info): Don't call
4316 tui_show_locator_content.
4317
4318 2019-08-30 Tom Tromey <tom@tromey.com>
4319
4320 * tui/tui-stack.c (tui_show_locator_content): Move lower. Rewrite.
4321 (tui_locator_window::rerender): Rewrite using body of previous
4322 tui_show_locator_content.
4323
4324 2019-08-30 Tom Tromey <tom@tromey.com>
4325
4326 * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
4327 set_locator_fullname>: New methods.
4328 * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4329 Rename from tui_set_locator_fullname.
4330 (tui_locator_window::set_locator_info): Rename from
4331 tui_set_locator_info. Return bool.
4332 (tui_update_locator_fullname, tui_show_frame_info): Update.
4333
4334 2019-08-30 Tom Tromey <tom@tromey.com>
4335
4336 * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
4337
4338 2019-08-30 Tom Tromey <tom@tromey.com>
4339
4340 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
4341 call touchwin.
4342
4343 2019-08-30 Tom Tromey <tom@tromey.com>
4344
4345 * tui/tui-wingeneral.c (box_win): Assume win_info and
4346 win_info->handle cannot be NULL.
4347
4348 2019-08-30 Tom Tromey <tom@tromey.com>
4349
4350 * tui/tui-regs.h (struct tui_data_item_window) <rerender,
4351 refresh_window>: Declare.
4352 * tui/tui-regs.c (tui_data_window::display_registers_from): Call
4353 resize.
4354 (tui_data_item_window::rerender): Rename from
4355 tui_display_register.
4356 (tui_data_item_window::refresh_window): New method.
4357 * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
4358 no-op.
4359
4360 2019-08-30 Tom Tromey <tom@tromey.com>
4361
4362 * tui/tui-regs.h (struct tui_data_window) <regs_content,
4363 regs_column_count, current_group>: Move later. Now private.
4364 <get_current_group>: New method.
4365 * tui/tui-regs.c (tui_reg_command): Update.
4366 * tui/tui-layout.c (tui_set_layout): Update.
4367
4368 2019-08-30 Tom Tromey <tom@tromey.com>
4369
4370 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
4371 (tui_data_window::rerender): Don't call
4372 check_and_display_highlight_if_needed.
4373 (tui_data_window::refresh_all): Remove call to
4374 erase_data_content.
4375
4376 2019-08-30 Tom Tromey <tom@tromey.com>
4377
4378 * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4379 (tui_data_window::display_registers_from)
4380 (tui_data_window::display_reg_element_at_line)
4381 (tui_data_window::display_registers_from_line): Remove checks of
4382 "empty".
4383
4384 2019-08-30 Tom Tromey <tom@tromey.com>
4385
4386 * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
4387 Don't declare.
4388 * tui/tui-regs.c (tui_data_window::show_registers): Call
4389 rerender.
4390 (tui_data_window::rerender): Rename from display_all_data.
4391 (tui_data_window::rerender): Remove old implementation.
4392
4393 2019-08-30 Tom Tromey <tom@tromey.com>
4394
4395 * tui/tui-regs.c (tui_data_window::display_all_data): Change
4396 text.
4397 * tui/tui-data.h (NO_DATA_STRING): Remove define.
4398
4399 2019-08-29 Bernhard Wodok <barto@gmx.net>
4400 Sergio Durigan Junior <sergiodj@redhat.com>
4401
4402 PR win32/24284
4403 * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
4404
4405 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4406
4407 * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
4408 when searching for types.
4409
4410 2019-08-28 Andrew Burgess <andrew.burgess@embecosm.com>
4411
4412 * f-lang.c (f_language_defn): Use f_print_typedef.
4413 * f-lang.h (f_print_typedef): Declare.
4414 * f-typeprint.c (f_print_typedef): Define.
4415
4416 2019-08-27 Christian Biesinger <cbiesinger@google.com>
4417
4418 * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
4419
4420 2019-08-27 Andrew Burgess <andrew.burgess@embecosm.com>
4421
4422 * cli/cli-utils.c (info_print_options_defs): Delete.
4423 (make_info_print_options_def_group): Delete.
4424 (extract_info_print_options): Delete.
4425 (info_print_command_completer): Delete.
4426 (info_print_args_help): Add extra parameter, and optionally
4427 include text about -n flag.
4428 * cli/cli-utils.h (struct info_print_options): Delete.
4429 (extract_info_print_options): Delete declaration.
4430 (info_print_command_completer): Delete declaration.
4431 (info_print_args_help): Add extra parameter, extend header
4432 comment.
4433 * python/python.c (gdbpy_rbreak): Pass additional parameter to
4434 search_symbols.
4435 * stack.c (struct info_print_options): New type.
4436 (info_print_options_defs): New file scoped variable.
4437 (make_info_print_options_def_group): New static function.
4438 (info_print_command_completer): New static function.
4439 (info_locals_command): Update to use new local functions.
4440 (info_args_command): Likewise.
4441 (_initialize_stack): Add extra parameter to calls to
4442 info_print_args_help.
4443 * symtab.c (search_symbols): Add extra parameter, use this to
4444 possibly excluse non-debug symbols.
4445 (symtab_symbol_info): Add extra parameter, which is passed on to
4446 search_symbols.
4447 (struct info_print_options): New type.
4448 (info_print_options_defs): New file scoped variable.
4449 (make_info_print_options_def_group): New static function.
4450 (info_print_command_completer): New static function.
4451 (info_variables_command): Update to use local functions, and pass
4452 extra parameter through to symtab_symbol_info.
4453 (info_functions_command): Likewise.
4454 (info_types_command): Pass additional argument through to
4455 symtab_symbol_info.
4456 (rbreak_command): Pass extra argument to search_symbols.
4457 (_initialize_symtab): Add extra arguments for calls to
4458 info_print_args_help, and update help text for 'info variables',
4459 'whereis', and 'info functions' commands.
4460 * symtab.h (search_symbols): Add extra argument to declaration.
4461 * NEWS: Mention new flags.
4462
4463 2019-08-26 Christian Biesinger <cbiesinger@google.com>
4464
4465 * symtab.c (lookup_static_symbol): Call the new function (and move
4466 it down to be next to lookup_global_symbol).
4467 (struct global_sym_lookup_data): Add block_enum member and rename to...
4468 (struct global_or_static_sym_lookup_data): ...this.
4469 (lookup_symbol_global_iterator_cb): Pass block_index instead of
4470 GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
4471 (lookup_symbol_global_or_static_iterator_cb): ...this.
4472 (lookup_global_or_static_symbol): New function.
4473 (lookup_global_symbol): Call new function.
4474
4475 2019-08-26 Tom de Vries <tdevries@suse.de>
4476
4477 PR c++/24852
4478 * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
4479 when pc_probe.prob == NULL.
4480
4481 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4482
4483 * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
4484 variable symbol_linkage to symbol_linkage_.
4485
4486 2019-08-25 Simon Marchi <simon.marchi@efficios.com>
4487
4488 * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
4489 represent whether the symbol is static, dynamic, or we don't
4490 know.
4491
4492 2019-08-25 Yoshinori Sato <ysato@users.sourceforge.jp>
4493
4494 * gdb/rx-tdep.c (rx_register_names): New.
4495 (rx_register_name): Delete.
4496 (rx_psw_type): Delete.
4497 (rx_fpsw_type): Delete.
4498 (rx_register_type): Delete.
4499 (rx_gdbarch_init): Convert target-descriptions.
4500 (_initialize_rx_tdep): Add initialize_tdesc_rx.
4501 * gdb/features/Makefile: Add rx.xml.
4502 * gdb/features/rx.xml: New.
4503 * gdb/features/rx.c: Generated.
4504 * gdb/NEWS: Mention target description support.
4505
4506 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4507
4508 * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
4509 *slot_ptr.
4510
4511 2019-08-23 Sergio Durigan Junior <sergiodj@redhat.com>
4512
4513 * configure.ac: Don't check for 'dlfcn.h' (moved to
4514 gdbsupport/common.m4).
4515 * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
4516 'gdbsupport/'.
4517 (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
4518 * compile/compile-c-support.c: Include
4519 'gdbsupport/gdb-dlfcn.h'.
4520 * gdbsupport/common.m4: Check for 'dlfcn.h'.
4521 * gdb-dlfcn.c: Move to...
4522 * gdbsupport/gdb-dlfcn.c: ... here.
4523 * gdb-dlfcn.h: Move to...
4524 * gdbsupport/gdb-dlfcn.h: ... here.
4525
4526 2019-08-23 Sandra Loosemore <sandra@codesourcery.com>
4527
4528 * nios2-tdep.c (struct reg_value): Improve comments. Make
4529 the offset field signed.
4530
4531 2019-08-22 Christian Biesinger <cbiesinger@google.com>
4532
4533 * python/lib/gdb/__init__.py (_execute_file): New function.
4534 * python/python.c (python_run_simple_file): Call gdb._execute_file
4535 on Windows.
4536
4537 2019-08-22 Andrew Burgess <andrew.burgess@embecosm.com>
4538
4539 * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
4540 all uses as this was never set to anything but a zero value.
4541
4542 2019-08-21 Bogdan Harjoc <harjoc@gmail.com>
4543
4544 * cli/cli-cmds.c (with_command_1): Error out if no arguments.
4545
4546 2019-08-21 Christian Biesinger <cbiesinger@google.com>
4547
4548 * tui/tui-data.h (tui_gen_win_info): Add an =default
4549 move constructor, required by some GCC versions.
4550
4551 2019-08-21 Jinke Fan <fanjinke51@yeah.net>
4552
4553 * go32-nat.c (go32_sysinfo): Add hygon_p.
4554
4555 2019-08-20 Tom Tromey <tom@tromey.com>
4556
4557 * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
4558 line_from_reg_element_no, first_reg_element_no_inline,
4559 display_all_data, delete_data_content_windows,
4560 erase_data_content>: Now private.
4561
4562 2019-08-20 Tom Tromey <tom@tromey.com>
4563
4564 * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
4565 (tui_unhighlight_win, tui_highlight_win)
4566 (tui_win_info::make_window): Update.
4567 * tui/tui-data.h (HILITE, NO_HILITE): Remove.
4568
4569 2019-08-20 Tom Tromey <tom@tromey.com>
4570
4571 * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4572 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4573 (MAX_PID_WIDTH): Move to tui-stack.c.
4574 * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
4575 (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
4576 (MAX_PID_WIDTH): Move from tui-data.h.
4577
4578 2019-08-20 Tom Tromey <tom@tromey.com>
4579
4580 * tui/tui-wingeneral.h (tui_make_window): Don't declare.
4581 * tui/tui-wingeneral.c (box_win): Change type of win_info.
4582 (box_win): Update.
4583 (tui_gen_win_info::make_window): Rename from tui_make_window.
4584 (tui_win_info::make_window): New method.
4585 (tui_gen_win_info::make_visible): Update.
4586 * tui/tui-source.c (tui_source_window::set_contents): Update.
4587 * tui/tui-regs.c (tui_data_window::show_register_group): Update.
4588 (tui_data_window::display_registers_from): Update.
4589 * tui/tui-layout.c (tui_gen_win_info::resize): Update.
4590 * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
4591 Declare.
4592 <can_box>: Remove.
4593 <title>: Remove.
4594 (struct tui_win_info) <make_window>: Declare.
4595 <can_box>: Now virtual.
4596 <title>: New member.
4597 * tui/tui-data.c (~tui_gen_win_info): Don't free title.
4598 * tui/tui-command.c (tui_cmd_window::resize): Update.
4599
4600 2019-08-20 Tom Tromey <tom@tromey.com>
4601
4602 * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
4603 * tui/tui-regs.c (tui_data_window::show_registers): Update.
4604 (tui_data_window::check_register_values): Update.
4605
4606 2019-08-20 Tom Tromey <tom@tromey.com>
4607
4608 * tui/tui-regs.h (struct tui_data_window): Use
4609 DISABLE_COPY_AND_ASSIGN.
4610 <regs_content>: Change type, removing unique_ptr.
4611 <tui_data_window>: Add move constructor.
4612 * tui/tui-regs.c (tui_data_window::show_registers)
4613 (tui_data_window::show_register_group)
4614 (tui_data_window::display_registers_from)
4615 (tui_data_window::display_registers_from)
4616 (tui_data_window::first_data_item_displayed)
4617 (tui_data_window::delete_data_content_windows)
4618 (tui_data_window::rerender, tui_data_window::refresh_window)
4619 (tui_data_window::check_register_values): Update.
4620
4621 2019-08-20 Tom Tromey <tom@tromey.com>
4622
4623 * tui/tui-regs.h (struct tui_data_window) <show_registers,
4624 show_register_group>: Declare.
4625 (tui_show_register_group): Don't declare.
4626 * tui/tui-regs.c (tui_data_window::show_registers): Rename from
4627 tui_show_registers.
4628 (tui_data_window::show_register_group): Rename from
4629 tui_show_register_group.
4630 (tui_data_window::check_register_values, tui_reg_command):
4631 Update.
4632 * tui/tui-layout.c (tui_set_layout): Update.
4633
4634 2019-08-20 Tom Tromey <tom@tromey.com>
4635
4636 * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
4637 Declare.
4638 (tui_check_register_values): Don't declare.
4639 * tui/tui-regs.c (tui_data_window::check_register_values): Rename
4640 from tui_check_register_values.
4641 * tui/tui-hooks.c (tui_register_changed): Update.
4642
4643 2019-08-20 Tom Tromey <tom@tromey.com>
4644
4645 * tui/tui-regs.c (tui_reg_layout): Move later.
4646 (tui_show_registers): Don't enable TUI mode or change layout.
4647
4648 2019-08-20 Tom Tromey <tom@tromey.com>
4649
4650 * tui/tui-regs.h (struct tui_data_item_window)
4651 <~tui_data_item_window>: Remove.
4652 <content>: Now a unique_xmalloc_ptr.
4653 * tui/tui-regs.c (tui_register_format): Return a
4654 unique_xmalloc_ptr.
4655 (tui_get_register): Update.
4656 (~tui_data_item_window): Remove.
4657 (tui_data_window::display_registers_from, tui_display_register):
4658 Update.
4659 * tui/tui-io.h (tui_expand_tabs): Update.
4660 * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
4661 Remove "col" parameter.
4662
4663 2019-08-20 Tom Tromey <tom@tromey.com>
4664
4665 * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
4666 field.
4667 * tui/tui-regs.c (~tui_data_item_window): Update.
4668
4669 2019-08-20 Tom Tromey <tom@tromey.com>
4670
4671 * tui/tui-regs.c (tui_register_format, tui_get_register): Move
4672 earlier.
4673
4674 2019-08-20 Tom Tromey <tom@tromey.com>
4675
4676 * tui/tui-regs.c (tui_reg_command): Remove NULL check.
4677
4678 2019-08-20 Tom Tromey <tom@tromey.com>
4679
4680 * tui/tui-source.h (struct tui_source_window): Update.
4681 * tui/tui-regs.c (tui_show_registers): Update.
4682 * tui/tui-disasm.h (struct tui_disasm_window): Update.
4683 * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
4684 (NO_REGS_STRING): Remove defines.
4685
4686 2019-08-20 Conrad Meyer <cem@FreeBSD.org>
4687
4688 * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
4689 unnecessary thread walk if remote doesn't support the packet.
4690
4691 2019-08-19 Tom Tromey <tromey@adacore.com>
4692
4693 * python/py-value.c (value_has_field): Fix indentation.
4694
4695 2019-08-19 Tom Tromey <tromey@adacore.com>
4696
4697 * printcmd.c (do_one_display, info_display_command): Update.
4698 * block.h (contained_in): Return bool. Add allow_nested
4699 parameter.
4700 * block.c (contained_in): Return bool. Add allow_nested
4701 parameter.
4702
4703 2019-08-19 Tom Tromey <tom@tromey.com>
4704
4705 * configure: Rebuild.
4706 * configure.ac: Disallow the combination of -static-libstdc++ and
4707 source highlight.
4708 * source-cache.c (get_language_name): Handle rust.
4709 (source_cache::get_source_lines): Ignore highlighting exceptions.
4710
4711 2019-08-16 Tom Tromey <tom@tromey.com>
4712
4713 * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
4714 * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
4715 (struct tui_source_window_base) <make_visible, refresh_window,
4716 resize>: Remove methods.
4717 <execution_info>: Remove field.
4718 * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
4719 (tui_show_source_line, tui_source_window_base)
4720 (~tui_source_window_base): Update.
4721 (tui_source_window_base::resize)
4722 (tui_source_window_base::make_visible)
4723 (tui_source_window_base::refresh_window): Remove.
4724 (tui_source_window_base::update_exec_info): Update.
4725 * tui/tui-source.c (tui_source_window::set_contents): Update.
4726 * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4727
4728 2019-08-16 Tom Tromey <tom@tromey.com>
4729
4730 * tui/tui-hooks.c (tui_remove_hooks): Don't set
4731 deprecated_query_hook.
4732
4733 2019-08-16 Tom Tromey <tom@tromey.com>
4734
4735 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
4736 (tui_update_source_windows_with_line): Update.
4737 * tui/tui-source.h (struct tui_source_window)
4738 <show_symtab_source>: Declare.
4739 (tui_show_symtab_source): Don't declare.
4740 * tui/tui-source.c (tui_show_symtab_source): Rename from
4741 tui_show_symtab_source.
4742
4743 2019-08-16 Tom Tromey <tom@tromey.com>
4744
4745 * tui/tui-winsource.h (struct tui_source_window_base)
4746 <set_contents>: Declare.
4747 * tui/tui-winsource.c
4748 (tui_source_window_base::update_source_window_as_is): Update.
4749 * tui/tui-source.h (struct tui_source_window) <set_contents>:
4750 Declare.
4751 (tui_set_source_content): Don't declare.
4752 * tui/tui-source.c (tui_source_window::set_contents): Rename from
4753 tui_set_source_content.
4754 * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
4755 Declare.
4756 (tui_set_disassem_content): Don't declare.
4757 * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
4758 tui_set_disassem_content.
4759
4760 2019-08-16 Tom Tromey <tom@tromey.com>
4761
4762 * tui/tui-winsource.h (struct tui_source_window_base)
4763 <update_breakpoint_info>: Declare.
4764 (tui_update_breakpoint_info): Don't declare.
4765 * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
4766 (tui_update_all_breakpoint_info): Update.
4767 (tui_source_window_base::update_breakpoint_info): Rename from
4768 tui_update_breakpoint_info.
4769 (tui_source_window_base::update_exec_info): Update.
4770
4771 2019-08-16 Tom Tromey <tom@tromey.com>
4772
4773 * tui/tui-winsource.h (struct tui_source_window_base)
4774 <update_source_window>: Declare.
4775 (tui_update_source_window): Don't declare.
4776 * tui/tui-winsource.c
4777 (tui_source_window_base::update_source_window): Rename from
4778 tui_update_source_window.
4779 (tui_source_window_base::rerender): Update.
4780 * tui/tui-source.c (tui_source_window::maybe_update): Update.
4781 * tui/tui-disasm.c (tui_show_disassem)
4782 (tui_show_disassem_and_update_source)
4783 (tui_disasm_window::maybe_update): Update.
4784
4785 2019-08-16 Tom Tromey <tom@tromey.com>
4786
4787 * tui/tui-winsource.h (struct tui_source_window_base)
4788 <update_source_window_as_is>: Declare.
4789 (tui_update_source_window_as_is): Don't declare.
4790 * tui/tui-winsource.c (tui_update_source_window): Update
4791 (tui_source_window_base::update_source_window_as_is): Rename from
4792 tui_update_source_window_as_is.
4793 (tui_source_window_base::refill): Update.
4794 * tui/tui-source.c (tui_show_symtab_source): Update.
4795 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
4796 Update.
4797
4798 2019-08-16 Tom Tromey <tom@tromey.com>
4799
4800 * tui/tui-winsource.h (tui_update_source_window)
4801 (tui_update_source_window_as_is): Remove "noerror" parameter.
4802 * tui/tui-winsource.c (tui_update_source_window)
4803 (tui_update_source_window_as_is): Remove "noerror" parameter.
4804 (tui_update_source_windows_with_addr)
4805 (tui_update_source_windows_with_line)
4806 (tui_source_window_base::rerender)
4807 (tui_source_window_base::refill): Update.
4808 * tui/tui-source.h (tui_set_source_content)
4809 (tui_show_symtab_source): Remove "noerror" parameter.
4810 * tui/tui-source.c (tui_set_source_content): Remove "noerror"
4811 parameter.
4812 (tui_show_symtab_source): Likewise.
4813 (tui_source_window::maybe_update): Update.
4814 * tui/tui-disasm.c (tui_show_disassem)
4815 (tui_show_disassem_and_update_source)
4816 (tui_disasm_window::do_scroll_vertical)
4817 (tui_disasm_window::maybe_update): Update.
4818
4819 2019-08-16 Tom Tromey <tom@tromey.com>
4820
4821 * tui/tui.c (tui_is_window_visible): Update.
4822 * tui/tui-wingeneral.c (tui_make_window)
4823 (tui_gen_win_info::make_visible, tui_refresh_all): Update.
4824 * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
4825 (tui_set_focus_command, tui_all_windows_info, update_tab_width)
4826 (tui_set_win_height_command, parse_scrolling_args): Update.
4827 * tui/tui-source.c (tui_source_window::style_changed): Update.
4828 * tui/tui-regs.c (tui_show_registers)
4829 (tui_data_window::first_data_item_displayed)
4830 (tui_data_window::delete_data_content_windows)
4831 (tui_check_register_values, tui_reg_command): Update.
4832 * tui/tui-disasm.c (tui_show_disassem): Update.
4833 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
4834 method.
4835 <is_visible>: Remove field.
4836 * tui/tui-data.c (tui_next_win, tui_prev_win)
4837 (tui_delete_invisible_windows): Update.
4838
4839 2019-08-16 Tom Tromey <tom@tromey.com>
4840
4841 * tui/tui-winsource.h (struct tui_source_window_base)
4842 <m_has_locator>: Remove.
4843 * tui/tui-layout.c (show_source_disasm_command, show_data)
4844 (show_source_or_disasm_and_command): Update.
4845
4846 2019-08-16 Alan Hayward <alan.hayward@arm.com>
4847
4848 * NEWS (Other MI changes): New subsection.
4849 * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
4850 (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
4851 * arch-utils.c (default_get_pc_address_flags): New function.
4852 * arch-utils.h (default_get_pc_address_flags): New declaration.
4853 * gdbarch.sh: Add get_pc_address_flags.
4854 * gdbarch.c: Regenerate.
4855 * gdbarch.h: Likewise.
4856 * stack.c (print_pc): New function.
4857 (print_frame_info) (print_frame): Call print_pc.
4858
4859 2019-08-16 Tom de Vries <tdevries@suse.de>
4860
4861 * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
4862 print_objfile_section_info.
4863
4864 2019-08-15 Tom Tromey <tom@tromey.com>
4865
4866 * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
4867 calling update_cmdwin_start_line.
4868 * tui/tui-winsource.h (struct tui_source_window_base)
4869 <do_make_visible_with_new_height, set_new_height>: Don't declare.
4870 <rerender>: Declare.
4871 * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
4872 Call rerender.
4873 (tui_source_window_base::set_new_height): Remove.
4874 (tui_source_window_base::rerender): Rename from
4875 do_make_visible_with_new_height.
4876 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
4877 resize method.
4878 (tui_win_info::make_invisible_and_set_new_height)
4879 (tui_win_info::make_visible_with_new_height): Remove.
4880 * tui/tui-stack.h (struct tui_locator_window) <rerender>:
4881 Declare.
4882 * tui/tui-stack.c (tui_locator_window::rerender): New method.
4883 * tui/tui-regs.h (struct tui_data_window) <set_new_height,
4884 do_make_visible_with_new_height>: Don't declare.
4885 <rerender>: Declare.
4886 * tui/tui-regs.c (tui_data_window::rerender): Rename from
4887 set_new_height.
4888 (tui_data_window::do_make_visible_with_new_height): Remove.
4889 * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
4890 call tui_show_locator_content.
4891 (tui_gen_win_info::resize): Call rerender.
4892 (show_source_or_disasm_and_command): Don't call
4893 tui_show_locator_content.
4894 * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
4895 method.
4896 (struct tui_win_info) <rerender>: Declare.
4897 <set_new_height, make_invisible_and_set_new_height,
4898 make_visible_with_new_height>: Don't declare.
4899 * tui/tui-data.c (tui_win_list::rerender): New method.
4900 * tui/tui-command.h (struct tui_cmd_window)
4901 <do_make_visible_with_new_height>: Don't declare.
4902 * tui/tui-command.c
4903 (tui_cmd_window::do_make_visible_with_new_height): Remove.
4904
4905 2019-08-15 Tom Tromey <tromey@adacore.com>
4906
4907 * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
4908 * ada-lang.c (ada_enum_name): Likewise.
4909
4910 2019-08-15 Christian Biesinger <cbiesinger@google.com>
4911
4912 * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
4913 leading underscore.
4914 (GdbOutputErrorFile): Likewise.
4915 (global scope): Adjust constructor calls to GdbOutput{,Error}File
4916 accordingly.
4917 (execute_unwinders): Rename to have a leading underscore.
4918 (auto_load_packages): Likewise.
4919 (global scope): Adjust call to auto_load_packages accordingly.
4920 (GdbSetPythonDirectory): Likewise.
4921 * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
4922 instead of execute_unwinders.
4923
4924 2019-08-15 Tom Tromey <tom@tromey.com>
4925
4926 * tui/tui-layout.c (show_layout, show_source_disasm_command)
4927 (show_data): Don't change window visibility.
4928 (tui_gen_win_info::resize): Remove special case for command
4929 window. Use wresize, when available.
4930 (show_source_or_disasm_and_command): Don't change window
4931 visibility.
4932 * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
4933 <make_visible>: New method.
4934 * tui/tui-command.c (tui_cmd_window::resize): New method.
4935
4936 2019-08-15 Tom Tromey <tom@tromey.com>
4937
4938 * tui/tui-winsource.h (struct tui_source_window_iterator): New.
4939 (struct tui_source_windows): New.
4940 * tui/tui-winsource.c (tui_display_main): Update.
4941 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
4942 (new_height_ok, parse_scrolling_args): Update.
4943 * tui/tui-layout.c (show_layout, show_data): Update.
4944 * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
4945 (tui_add_to_source_windows): Don't declare.
4946 * tui/tui-data.c (source_windows, tui_source_windows)
4947 (tui_clear_source_windows, tui_add_to_source_windows): Remove.
4948
4949 2019-08-15 Tom Tromey <tom@tromey.com>
4950
4951 * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
4952 Rename from reset.
4953 * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
4954 * tui/tui-layout.c (show_source_disasm_command, show_data):
4955 Update.
4956 (tui_gen_win_info::resize): Rename.
4957 (show_source_or_disasm_and_command): Update.
4958 * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
4959 reset.
4960
4961 2019-08-15 Tom Tromey <tom@tromey.com>
4962
4963 * tui/tui-stack.c (tui_initialize_static_data): Remove.
4964 * tui/tui-interp.c (tui_interp::init): Don't call
4965 tui_initialize_static_data.
4966 * tui/tui-data.h (tui_initialize_static_data): Don't declare.
4967
4968 2019-08-15 Tom Tromey <tom@tromey.com>
4969
4970 * tui/tui-layout.c (tui_default_win_viewport_height): Don't
4971 examine tui_win_list.
4972
4973 2019-08-15 Tom Tromey <tom@tromey.com>
4974
4975 * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
4976 * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
4977 tui_clear_source_content.
4978 (tui_clear_source_content): Remove.
4979 (tui_source_window_base::do_erase_source_content): Hoist call to
4980 content.clear().
4981 * tui/tui-stack.c (tui_show_frame_info): Don't call
4982 tui_clear_source_content.
4983
4984 2019-08-15 Tom Tromey <tom@tromey.com>
4985
4986 * tui/tui-winsource.h (struct tui_source_window_base)
4987 <do_erase_source_content>: New method.
4988 <erase_source_content>: New method.
4989 (tui_erase_source_content): Don't declare.
4990 * tui/tui-winsource.c (tui_clear_source_content): Update.
4991 (tui_source_window_base::do_erase_source_content): Rename from
4992 tui_erase_source_content.
4993 (tui_source_window_base::show_source_content): Update.
4994 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
4995 * tui/tui-source.h (struct tui_source_window)
4996 <erase_source_content>: New method.
4997 * tui/tui-disasm.h (struct tui_disasm_window)
4998 <erase_source_content>: New method.
4999
5000 2019-08-15 Tom Tromey <tom@tromey.com>
5001
5002 * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5003 (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5004 constructor.
5005 * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5006 * tui/tui-source.c (tui_set_source_content): Update.
5007 * tui/tui-disasm.c (tui_set_disassem_content): Update.
5008
5009 2019-08-15 Tom Tromey <tom@tromey.com>
5010
5011 * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5012 * tui/tui-winsource.c (tui_line_is_displayed): Move to
5013 tui-source.c.
5014 * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5015 Declare.
5016 * tui/tui-source.c (tui_source_window::line_is_displayed): New
5017 method.
5018 (tui_source_window::maybe_update): Update.
5019
5020 2019-08-15 Tom Tromey <tom@tromey.com>
5021
5022 * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5023 * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5024 tui-disasm.c.
5025 * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5026 Declare.
5027 * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5028 method.
5029 (tui_disasm_window::maybe_update): Update.
5030
5031 2019-08-15 Tom Tromey <tom@tromey.com>
5032
5033 * tui/tui-winsource.h (struct tui_source_window_base)
5034 <maybe_update>: Declare.
5035 * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5036 method.
5037 * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5038 Declare.
5039 * tui/tui-source.c (tui_source_window::maybe_update): New method.
5040 * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5041 Declare.
5042 * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5043
5044 2019-08-15 Tom Tromey <tom@tromey.com>
5045
5046 * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5047
5048 2019-08-15 Tom Tromey <tom@tromey.com>
5049
5050 * tui/tui-wingeneral.c: Include tui-stack.h.
5051 * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5052 (struct tui_locator_window): Move from tui-data.h.
5053 * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5054 (tui_initialize_static_data): Move from tui-data.c.
5055 * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5056 (struct tui_locator_window): Move to tui-stack.c.
5057 * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5058 (tui_initialize_static_data): Move to tui-stack.c.
5059
5060 2019-08-15 Tom Tromey <tom@tromey.com>
5061
5062 * tui/tui-layout.c (show_source_disasm_command)
5063 (show_source_or_disasm_and_command): Use make_visible method, not
5064 tui_make_window.
5065 * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5066 Remove.
5067
5068 2019-08-15 Tom Tromey <tom@tromey.com>
5069
5070 * tui/tui-wingeneral.h (tui_make_window): Update.
5071 * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5072 parameter.
5073 (tui_gen_win_info::make_visible): Update.
5074 * tui/tui-regs.c (tui_data_window::display_registers_from):
5075 Update.
5076 * tui/tui-layout.c (show_source_disasm_command)
5077 (show_source_or_disasm_and_command): Update.
5078 * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5079 (enum tui_box): Remove.
5080 (struct tui_win_info) <can_box>: New method.
5081 * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5082 method.
5083
5084 2019-08-15 Tom de Vries <tdevries@suse.de>
5085
5086 * linux-nat-trad.c: Include gdbarch.h.
5087
5088 2019-08-14 Alan Hayward <alan.hayward@arm.com>
5089
5090 * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5091 register sizes.
5092
5093 2019-08-14 Tom Tromey <tromey@adacore.com>
5094
5095 * darwin-nat.c: Include gdbarch.h.
5096 * darwin-nat-info.c: Include gdbarch.h.
5097
5098 2019-08-13 Tom Tromey <tom@tromey.com>
5099
5100 * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5101 Remove.
5102 * tui/tui-data.c (tui_initialize_static_data): Update.
5103
5104 2019-08-13 Tom Tromey <tom@tromey.com>
5105
5106 * tui/tui-winsource.h (struct tui_exec_info_window)
5107 <~tui_exec_info_window, maybe_allocate_content, get_content,
5108 m_content>: Remove.
5109 (struct tui_source_window_base) <set_exec_info_content,
5110 show_exec_info_content>: Don't declare.
5111 * tui/tui-winsource.c
5112 (tui_exec_info_window::maybe_allocate_content): Remove.
5113 (tui_source_window_base::update_exec_info): Rename from
5114 set_exec_info_content.
5115 (tui_source_window_base::show_exec_info_content)
5116 (tui_source_window_base::update_exec_info): Remove.
5117
5118 2019-08-13 Tom Tromey <tom@tromey.com>
5119
5120 * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5121 declare.
5122 * tui/tui-winsource.c (tui_update_source_window_as_is)
5123 (tui_update_source_windows_with_addr, tui_erase_source_content):
5124 Update.
5125 (tui_clear_exec_info_content): Remove.
5126
5127 2019-08-13 Tom Tromey <tom@tromey.com>
5128
5129 * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5130 declare.
5131 * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5132 call tui_erase_exec_info_content.
5133 (tui_clear_exec_info_content): Rename from
5134 tui_erase_exec_info_content.
5135 (tui_clear_exec_info_content): Delete.
5136
5137 2019-08-13 Tom Tromey <tom@tromey.com>
5138
5139 * tui/tui-winsource.h (struct tui_source_window_base)
5140 <show_exec_info_content>: Declare.
5141 (tui_show_exec_info_content): Don't declare.
5142 * tui/tui-winsource.c
5143 (tui_source_window_base::show_exec_info_content): Rename from
5144 tui_show_exec_info_content.
5145 (tui_source_window_base::update_exec_info): Update.
5146
5147 2019-08-13 Tom Tromey <tom@tromey.com>
5148
5149 * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5150 (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5151 (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5152 * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5153 tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5154 (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5155 ... here.
5156
5157 2019-08-13 Tom Tromey <tom@tromey.com>
5158
5159 * tui/tui-winsource.h (struct tui_source_window_base)
5160 <update_exec_info>: Declare.
5161 (tui_update_exec_info): Don't declare.
5162 * tui/tui-winsource.c (tui_update_source_window_as_is)
5163 (tui_source_window_base::refresh_all)
5164 (tui_update_all_breakpoint_info): Update.
5165 (tui_source_window_base::update_exec_info): Rename from
5166 tui_update_exec_info.
5167 * tui/tui-stack.c (tui_show_frame_info): Update.
5168
5169 2019-08-13 Tom Tromey <tom@tromey.com>
5170
5171 * tui/tui-winsource.h (struct tui_source_window_base)
5172 <set_exec_info_content>: Declare.
5173 (tui_set_exec_info_content): Don't declare.
5174 * tui/tui-winsource.c
5175 (tui_source_window_base::set_exec_info_content): Rename from
5176 tui_set_exec_info_content.
5177 (tui_update_exec_info): Update.
5178
5179 2019-08-13 Tom Tromey <tom@tromey.com>
5180
5181 * tui/tui-winsource.h (struct tui_source_window_base)
5182 <show_source_content>: Declare.
5183 (tui_show_source_content): Don't declare.
5184 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5185 (tui_source_window_base::show_source_content): Rename from
5186 tui_show_source_content.
5187 (tui_source_window_base::refresh_all): Update.
5188 * tui/tui-layout.c (show_source_disasm_command)
5189 (show_source_or_disasm_and_command): Update.
5190
5191 2019-08-13 Tom Tromey <tom@tromey.com>
5192
5193 * tui/tui-winsource.c (tui_erase_source_content)
5194 (tui_show_source_content, tui_source_window_base::refresh_all):
5195 Update.
5196 * tui/tui-wingeneral.h
5197 (tui_check_and_display_highlight_if_needed): Don't declare.
5198 * tui/tui-wingeneral.c
5199 (tui_win_info::check_and_display_highlight_if_needed): Rename from
5200 check_and_display_highlight_if_needed.
5201 * tui/tui-win.c (tui_rehighlight_all)
5202 (tui_win_info::make_visible_with_new_height): Update.
5203 * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5204 (tui_data_window::erase_data_content)
5205 (tui_data_window::display_all_data): Update.
5206 * tui/tui-data.h (struct tui_win_info)
5207 <check_and_display_highlight_if_needed>: Declare.
5208
5209 2019-08-13 Tom Tromey <tom@tromey.com>
5210
5211 * tui/tui-win.c (tui_resize_all): Call
5212 tui_delete_invisible_windows.
5213 * tui/tui-layout.c (show_layout): Call
5214 tui_delete_invisible_windows.
5215 * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5216 * tui/tui-data.c (tui_delete_invisible_windows): New function.
5217
5218 2019-08-13 Tom Tromey <tom@tromey.com>
5219
5220 * tui/tui-disasm.c (tui_show_disassem): Add assertion. Don't call
5221 tui_add_win_to_layout.
5222
5223 2019-08-13 Tom Tromey <tom@tromey.com>
5224
5225 * tui/tui-layout.h (tui_default_win_height): Don't declare.
5226 * tui/tui-layout.c (tui_default_win_height): Now static.
5227
5228 2019-08-13 Tom Tromey <tom@tromey.com>
5229
5230 * tui/tui-layout.c (show_layout): Unify all layout cases into a
5231 single switch.
5232 (show_source_disasm_command, show_source_or_disasm_and_command):
5233 Don't check current layout.
5234
5235 2019-08-13 Tom Tromey <tom@tromey.com>
5236
5237 * tui/tui-wingeneral.c (make_all_visible): Remove.
5238 (tui_make_all_invisible): Simplify.
5239 * tui/tui-layout.c (tui_make_all_invisible): Move from
5240 tui-wingeneral.c; simplify.
5241 (show_layout): Hoist call to tui_make_all_invisible.
5242 (show_data): Don't call tui_make_all_invisible.
5243
5244 2019-08-13 Tom Tromey <tom@tromey.com>
5245
5246 * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5247 * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5248
5249 2019-08-13 Tom Tromey <tom@tromey.com>
5250
5251 * tui/tui-layout.c (current_layout, tui_current_layout): Move from
5252 tui-data.c.
5253 (show_source_disasm_command, show_data)
5254 (show_source_or_disasm_and_command): Don't use
5255 tui_set_current_layout_to.
5256 * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
5257 * tui/tui-data.c (current_layout, tui_current_layout): Move to
5258 tui-layout.c.
5259 (tui_set_current_layout_to): Remove.
5260
5261 2019-08-13 Tom Tromey <tom@tromey.com>
5262
5263 * tui/tui-layout.c (tui_set_layout): Update.
5264 * tui/tui-data.h (struct tui_layout_def): Remove.
5265 (tui_layout_def): Don't declare.
5266 * tui/tui-data.c (layout_def): Remove.
5267 (tui_layout_def): Remove.
5268
5269 2019-08-13 Tom Tromey <tom@tromey.com>
5270
5271 * tui/tui-winsource.h (struct tui_source_window_base)
5272 <clear_detail>: No longer "override".
5273 * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
5274 * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
5275 * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
5276 * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
5277 Remove.
5278 * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
5279
5280 2019-08-13 Tom Tromey <tromey@adacore.com>
5281
5282 * tracepoint.c: Don't include readline.h or history.h.
5283
5284 2019-08-12 Tom Tromey <tom@tromey.com>
5285
5286 * configure: Rebuild.
5287 * configure.ac: Check for readline 7.
5288 * NEWS: Mention readline 7 requirement.
5289 * README: Update.
5290
5291 2019-08-12 Tom Tromey <tom@tromey.com>
5292
5293 * mingw-hdep.c (gdb_select): Remove readline hack.
5294
5295 2019-08-09 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
5296
5297 * blockframe.c (find_pc_partial_function): Set *block to nullptr
5298 when the function fails.
5299
5300 2019-08-09 Andreas Arnez <arnez@linux.ibm.com>
5301
5302 * s390-tdep.c (s390_type_align): New function.
5303 (s390_gdbarch_init): Set it as type_align gdbarch method.
5304
5305 2019-08-09 Tom de Vries <tdevries@suse.de>
5306
5307 PR gdb/24591
5308 * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
5309 pc_low with relocation offset.
5310
5311 2019-08-07 Tom Tromey <tromey@adacore.com>
5312
5313 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
5314 (print_frame_args): Update.
5315 * python/py-framefilter.c (py_print_single_arg, enumerate_args):
5316 Update.
5317 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
5318 * frame.h (struct frame_arg): Add initializers.
5319 <error>: Now a unique_xmalloc_ptr.
5320
5321 2019-08-07 Alan Hayward <alan.hayward@arm.com>
5322
5323 * NEWS: Expand the Pointer Authentication entry.
5324 * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
5325 (aarch64_frame_unmask_lr): ... to this.
5326 (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
5327 Call aarch64_frame_unmask_lr.
5328 * frame.c (struct frame_info): Add "masked" variable.
5329 (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
5330 (fprint_frame): Check for masked pc.
5331 * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
5332 declarations.
5333 * python/py-framefilter.c (py_print_frame): Check for masked pc.
5334 * stack.c (print_frame): Check for masked pc.
5335
5336 2019-08-06 Tom Tromey <tom@tromey.com>
5337
5338 * stabsread.c (patch_block_stabs, read_one_struct_field)
5339 (read_enum_type): Use obstack_strndup.
5340 * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
5341 * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
5342 * dwarf2read.c (guess_full_die_structure_name)
5343 (anonymous_struct_prefix): Use obstack_strndup.
5344 * dbxread.c (cp_set_block_scope): Use obstack_strndup.
5345 * c-exp.y (yylex): Use obstack_strndup.
5346 * ada-exp.y (write_object_renaming, write_ambiguous_var)
5347 (write_var_or_type): Use obstack_strndup.
5348
5349 2019-08-06 Tom Tromey <tom@tromey.com>
5350
5351 * symfile.c (reread_symbols): Use obstack_strdup.
5352 * stabsread.c (read_type): Use obstack_strdup.
5353 * gdb_obstack.h (obstack_strdup): New overload.
5354 * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
5355 (create_dwo_unit_in_dwp_v2, build_error_marker_type)
5356 (dwarf2_canonicalize_name): Use obstack_strdup.
5357 * dbxread.c (read_dbx_symtab): Use obstack_strdup.
5358 * cp-support.c (inspect_type, replace_typedefs_qualified_name):
5359 Use obstack_strdup.
5360
5361 2019-08-06 Tom Tromey <tom@tromey.com>
5362
5363 * gdb_obstack.h (obstack_strdup): Define.
5364 * gdb_obstack.c (obstack_strdup): Don't define.
5365
5366 2019-08-06 Tom Tromey <tom@tromey.com>
5367
5368 * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
5369 obstack_strdup.
5370 * typeprint.c (typedef_hash_table::find_global_typedef): Use
5371 obstack_strdup.
5372 * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
5373 * stabsread.c (common_block_start): Use obstack_strdup.
5374 * objfiles.c (set_objfile_main_name, objfile): Use
5375 obstack_strdup.
5376 * namespace.c (add_using_directive): Use obstack_strdup.
5377 * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
5378 * jit.c (finalize_symtab): Use obstack_strdup.
5379 * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
5380 (guess_partial_die_structure_name, partial_die_info::fixup)
5381 (dwarf2_name): Use obstack_strdup.
5382 * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
5383 obstack_strdup.
5384 * c-exp.y (scan_macro_expansion): Use obstack_strdup.
5385 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
5386 obstack_strdup.
5387 * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
5388
5389 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5390
5391 * unittests/help-doc-selftests.c: New file.
5392 * Makefile.in: Add the new file.
5393
5394 2019-08-07 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5395
5396 * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
5397 * cli/cli-decode.c (print_doc_line): Likewise. It now prints
5398 the full first line, except when FOR_VALUE_PREFIX. In this case,
5399 the trailing '.' is not output, and the first character is uppercased.
5400 (print_help_for_command): Update call to print_doc_line.
5401 (print_doc_of_command): Likewise.
5402 * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
5403 * cli/cli-option.c (append_indented_doc): Do not append newline.
5404 (build_help_option): Append newline after first appended_indented_doc
5405 only if a second call is done.
5406 (build_help): Append 2 new lines before each option, except the first
5407 one.
5408 * compile/compile.c (_initialize_compile): Add new lines after
5409 %OPTIONS%, when not at the end of the help.
5410 Change help doc or code
5411 producing the help doc to respect the invariants.
5412 * maint-test-options.c (_initialize_maint_test_options): Likewise.
5413 Also removed the new line after 'Options:', as all other commands
5414 do not put an empty line between 'Options:' and the first option.
5415 * printcmd.c (_initialize_printcmd): Likewise.
5416 * stack.c (_initialize_stack): Likewise.
5417 * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
5418 incorrectly telling COMMAND is optional.
5419 * ada-lang.c (_initialize_ada_language): Change help doc or code
5420 producing the help doc to respect the invariants.
5421 * ada-tasks.c (_initialize_ada_tasks): Likewise.
5422 * breakpoint.c (_initialize_breakpoint): Likewise.
5423 * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
5424 * cli/cli-logging.c (_initialize_cli_logging): Likewise.
5425 * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
5426 * cli/cli-style.c (cli_style_option::add_setshow_commands,
5427 _initialize_cli_style): Likewise.
5428 * corelow.c (core_target_info): Likewise.
5429 * dwarf-index-cache.c (_initialize_index_cache): Likewise.
5430 * dwarf2read.c (_initialize_dwarf2_read): Likewise.
5431 * filesystem.c (_initialize_filesystem): Likewise.
5432 * frame.c (_initialize_frame): Likewise.
5433 * gnu-nat.c (add_task_commands): Likewise.
5434 * infcall.c (_initialize_infcall): Likewise.
5435 * infcmd.c (_initialize_infcmd): Likewise.
5436 * interps.c (_initialize_interpreter): Likewise.
5437 * language.c (_initialize_language): Likewise.
5438 * linux-fork.c (_initialize_linux_fork): Likewise.
5439 * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
5440 * maint.c (_initialize_maint_cmds): Likewise.
5441 * memattr.c (_initialize_mem): Likewise.
5442 * printcmd.c (_initialize_printcmd): Likewise.
5443 * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
5444 _RegEx): Likewise.
5445 * ravenscar-thread.c (_initialize_ravenscar): Likewise.
5446 * record-btrace.c (_initialize_record_btrace): Likewise.
5447 * record-full.c (_initialize_record_full): Likewise.
5448 * record.c (_initialize_record): Likewise.
5449 * regcache-dump.c (_initialize_regcache_dump): Likewise.
5450 * regcache.c (_initialize_regcache): Likewise.
5451 * remote.c (add_packet_config_cmd, init_remote_threadtests,
5452 _initialize_remote): Likewise.
5453 * ser-tcp.c (_initialize_ser_tcp): Likewise.
5454 * serial.c (_initialize_serial): Likewise.
5455 * skip.c (_initialize_step_skip): Likewise.
5456 * source.c (_initialize_source): Likewise.
5457 * stack.c (_initialize_stack): Likewise.
5458 * symfile.c (_initialize_symfile): Likewise.
5459 * symtab.c (_initialize_symtab): Likewise.
5460 * target-descriptions.c (_initialize_target_descriptions): Likewise.
5461 * top.c (init_main): Likewise.
5462 * tracefile-tfile.c (tfile_target_info): Likewise.
5463 * tracepoint.c (_initialize_tracepoint): Likewise.
5464 * tui/tui-win.c (_initialize_tui_win): Likewise.
5465 * utils.c (add_internal_problem_command): Likewise.
5466 * valprint.c (value_print_option_defs): Likewise.
5467
5468 2019-08-06 Frank Ch. Eigler <fche@redhat.com>
5469
5470 PR build/24886
5471 * configure.ac: Drop enable-libmcheck support.
5472 * configure, config.in: Rebuild.
5473 * libmcheck.m4: Remove.
5474 * acinclude.m4: Don't include it.
5475 * Makefile.in: Don't distribute it.
5476 * top.c (print_gdb_configuration): Don't mention it.
5477
5478 2019-08-06 Tom Tromey <tom@tromey.com>
5479
5480 * utils.c (set_output_style): Sometimes pass stream to
5481 emit_style_escape.
5482 * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
5483 * record-btrace.c (btrace_insn_history): Update.
5484 * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
5485 method.
5486 * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
5487 Update initializers.
5488 <m_uiout>: New field.
5489 <m_di>: Move lower.
5490 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5491 Remove "uiout" parameter.
5492 (dump_insns): Update.
5493 * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
5494 * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
5495
5496 2019-08-06 Christian Biesinger <cbiesinger@google.com>
5497
5498 * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
5499 (error_in_psymtab_expansion): Likewise.
5500 (lookup_symbol_via_quick_fns): Likewise.
5501 (basic_lookup_transparent_type_quick): Likewise.
5502 (basic_lookup_transparent_type_1): Likewise.
5503
5504 2019-08-06 Tom Tromey <tromey@adacore.com>
5505
5506 * source.c (last_source_error): Now bool.
5507 (print_source_lines_base): Make "noprint" bool. Only open
5508 source file when last_source_visited changes.
5509
5510 2019-08-06 Tom Tromey <tromey@adacore.com>
5511
5512 * annotate.c (annotate_source_line): Use g_source_cache.
5513 * source-cache.c (source_cache::get_plain_source_lines): Change
5514 parameters. Populate m_offset_cache.
5515 (source_cache::ensure): New method.
5516 (source_cache::get_line_charpos): New method.
5517 (extract_lines): Move lower. Change parameters.
5518 (source_cache::get_source_lines): Move lower.
5519 * source-cache.h (class source_cache): Update comment.
5520 <get_line_charpos>: New method.
5521 <get_source_lines>: Update comment.
5522 <clear>: Clear m_offset_cache.
5523 <get_plain_source_lines>: Change parameters.
5524 <ensure>: New method
5525 <m_offset_cache>: New member.
5526 * source.c (forget_cached_source_info_for_objfile): Update.
5527 (info_source_command): Use g_source_cache.
5528 (find_source_lines, open_source_file_with_line_charpos): Remove.
5529 (print_source_lines_base, search_command_helper): Use g_source_cache.
5530 * source.h (open_source_file_with_line_charpos): Don't declare.
5531 * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
5532 * tui/tui-source.c (tui_source_window::do_scroll_vertical):
5533 Use g_source_cache.
5534
5535 2019-08-06 Tom Tromey <tromey@adacore.com>
5536
5537 * source-cache.c (source_cache::get_plain_source_lines):
5538 Remove "first_line" and "last_line" parameters.
5539 (source_cache::get_source_lines): Cache plain text.
5540 * source-cache.h (class source_cache)
5541 <get_plain_source_lines>: Update.
5542
5543 2019-08-06 Tom Tromey <tromey@adacore.com>
5544
5545 * source-cache.c (extract_lines): No longer a method.
5546 Changed type of parameter. Include final newline.
5547 (selftests::extract_lines_test): New function.
5548 (_initialize_source_cache): Likewise.
5549 * source-cache.h (class source_cache)
5550 <extract_lines>: Don't declare.
5551
5552 2019-08-06 Tom Tromey <tromey@adacore.com>
5553
5554 * breakpoint.c (init_breakpoint_sal): Update.
5555 (breakpoint): Update.
5556 * breakpoint.h (struct breakpoint) <filter>: Now a
5557 unique_xmalloc_ptr.
5558
5559 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5560
5561 * NEWS: Mention dictionary access on blocks.
5562 * python/py-block.c (blpy_getitem): New function.
5563 (block_object_as_mapping): New struct.
5564 (block_object_type): Use new struct for tp_as_mapping field.
5565
5566 2019-08-05 Christian Biesinger <cbiesinger@google.com>
5567
5568 * objfiles.h (objfile): Add a comment describing partial symbols.
5569
5570 2019-08-05 Tom Tromey <tromey@adacore.com>
5571
5572 * compile/compile.c (_initialize_compile): Use _(), not N_().
5573 * thread.c (_initialize_thread): Use _(), not N_().
5574 * stack.c (_initialize_stack): Use _(), not N_().
5575 * printcmd.c (_initialize_printcmd): Use _(), not N_().
5576
5577 2019-08-04 Simon Marchi <simon.marchi@polymtl.ca>
5578
5579 * dwarf2read.c (struct dw2_symtab_iterator):
5580 <want_specific_block>: Remove.
5581 <block_index>: Change type to gdb::optional.
5582 (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
5583 change type of BLOCK_INDEX parameter to gdb::optional.
5584 (dw2_symtab_iter_next): Re-write in function of gdb::optional.
5585 (dw2_lookup_symbol): Don't pass argument for
5586 WANT_SPECIFIC_BLOCK.
5587 (dw2_expand_symtabs_for_function): Don't pass argument for
5588 WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
5589 (class dw2_debug_names_iterator)
5590 <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
5591 parameter, change BLOCK_INDEX type to gdb::optional.
5592 <m_want_specific_block>: Remove.
5593 <m_block_index>: Change type to gdb::optional.
5594 (dw2_debug_names_iterator::next): Change type of IS_STATIC to
5595 gdb::optional. Re-write in function of gdb::optional.
5596 (dw2_debug_names_lookup_symbol): Don't pass argument for
5597 WANT_SPECIFIC_BLOCK.
5598 (dw2_debug_names_expand_symtabs_for_function): Don't pass
5599 argument for WANT_SPECIFIC_BLOCK, pass empty optional for
5600 BLOCK_INDEX.
5601
5602 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5603
5604 * NEWS: Mention changes to "info sources" command.
5605
5606 2019-08-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5607
5608 * symtab.c (filename_partial_match_opts): New struct type.
5609 (struct output_source_filename_data): New members
5610 regexp, c_regexp, partial_match.
5611 (output_source_filename): Use new members to decide to print file.
5612 (info_sources_option_defs): New variable.
5613 (make_info_sources_options_def_group, print_info_sources_header,
5614 info_sources_command_completer):
5615 New functions.
5616 (info_sources_command): Read new optional arguments.
5617 (_initialize_symtab): Update info sources help.
5618
5619 2019-08-02 Alexandre Oliva <oliva@adacore.com>
5620
5621 * ada-lang.c (exception_support_info_v0): Renamed from...
5622 (default_exception_support_info): ... this. Create new
5623 definition for v1.
5624 (ada_has_this_exception_support): Look up catch_handlers_sym.
5625 (ada_exception_support_info_sniffer): Try v0 after default.
5626
5627 2019-08-01 Tom Tromey <tromey@adacore.com>
5628
5629 * ia64-libunwind-tdep.h (struct libunwind_descr): Include
5630 gdbarch.h.
5631
5632 2019-08-01 Christian Biesinger <cbiesinger@google.com>
5633
5634 * s12z-tdep.c: Fix include path for s12z-opc.h.
5635
5636 2019-08-01 Alan Hayward <alan.hayward@arm.com>
5637
5638 * NEWS: Require GNU make 3.82.
5639
5640 2019-07-16 Tom Tromey <tom@tromey.com>
5641
5642 * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
5643 declare.
5644
5645 2019-07-30 Tom Tromey <tromey@adacore.com>
5646
5647 * block.c (contained_in): Remove BLOCK_FUNCTION check.
5648
5649 2019-07-30 Kevin Buettner <kevinb@redhat.com>
5650
5651 * printcmd.c (print_address_symbolic): Print negative offsets.
5652 (build_address_symbolic): Force signed arithmetic when computing
5653 offset.
5654
5655 2019-07-30 Christian Biesinger <cbiesinger@google.com>
5656
5657 PR/24474: Add a function to lookup static variables.
5658 * NEWS: Mention this new function.
5659 * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
5660 * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
5661 * python/python.c (python_GdbMethods): Add new function.
5662
5663 2019-07-29 Christian Biesinger <cbiesinger@google.com>
5664
5665 * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
5666 * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
5667 (objfpy_lookup_static_symbol): New function.
5668 (objfile_object_methods): Add new functions.
5669
5670 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5671
5672 * NEWS: Mention 'set|show print frame-info'. Mention new
5673 'presence' value for 'frame-arguments'. Mention new '-frame-info'
5674 backtrace argument. Mention that python frame filtering code
5675 is now consistent with what 'backtrace' command prints.
5676
5677 2019-07-29 Philippe Waroquiers <philippe.waroquiers@skynet.be>
5678
5679 * frame.h (enum print_what): New value 'SHORT_LOCATION', update
5680 comments.
5681 (print_frame_info_auto, print_frame_info_source_line,
5682 print_frame_info_location, print_frame_info_source_and_location,
5683 print_frame_info_location_and_address, print_frame_info_short_location):
5684 New declarations.
5685 (struct frame_print_options): New member print_frame_info.
5686 * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
5687 * stack.h (get_user_print_what_frame_info): New declaration.
5688 (frame_show_address): New declaration.
5689 * stack.c (print_frame_arguments_choices): New value 'presence'.
5690 (print_frame_info_auto, print_frame_info_source_line,
5691 print_frame_info_location, print_frame_info_source_and_location,
5692 print_frame_info_location_and_address, print_frame_info_short_location,
5693 print_frame_info_choices, print_frame_info_print_what): New definitions.
5694 (print_frame_args): Only print dots for args if print frame-arguments
5695 is 'presence'.
5696 (frame_print_option_defs): New element for "frame-info".
5697 (get_user_print_what_frame_info): New function.
5698 (frame_show_address): Make non static. Move comment to stack.h.
5699 (print_frame_info_to_print_what): New function.
5700 (print_frame_info): Update comment. Use fp_opts.print_frame_info
5701 to decide what to print.
5702 (backtrace_command_1): Handle the new print_frame_arguments_presence
5703 value.
5704 (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
5705 * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
5706 (py_print_frame): In non-mi mode, use LOCATION as default for
5707 print_what, similarly to frame information printed directly by
5708 backtrace command. Handle frame-info user option in non MI mode.
5709
5710 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5711
5712 * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
5713 Add case for debugging 32-bit target on 64-bit host. Revise
5714 comment.
5715
5716 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5717
5718 * infrun.c (fill_in_stop_func): Use find_pc_partial_function
5719 instead of find_function_entry_range_from_pc.
5720
5721 2019-07-27 Kevin Buettner <kevinb@redhat.com>
5722
5723 * stack.c (find_frame_funname): Remove code which preferred
5724 minsym over symtab sym in "certain pathological cases".
5725
5726 * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
5727 parameter. Change type of "do_demangle" to bool.
5728 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
5729 Pass suitable "prefer_sym_over_minsym" flag to
5730 build_address_symbolic(). Don't output "+" for negative offsets.
5731 * printcmd.c (print_address_symbolic): Update invocation of
5732 build_address_symbolic to include a "prefer_sym_over_minsym"
5733 flag.
5734 (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
5735 Restrict cases in which use of minimal symbol is preferred to that
5736 of a found symbol. Update comments.
5737
5738 * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
5739 for entry pc when entry pc is out of range for that FDE.
5740
5741 2019-07-26 Brian Callahan <bcallah@openbsd.org>
5742
5743 PR gdb/24839:
5744 * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
5745 type.
5746
5747 2019-07-25 Christian Biesinger <cbiesinger@google.com>
5748
5749 * python/py-objfile.c (add_separate_debug_file): Fix comment about
5750 this function's Python signature.
5751
5752
5753 2019-07-24 Christian Biesinger <cbiesinger@google.com>
5754
5755 * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
5756 * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5757 * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
5758 * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
5759 * symtab.h (lookup_global_symbol_from_objfile): Likewise.
5760
5761
5762 2019-07-24 Yoshinori Sato <ysato@users.sourceforge.jp>
5763
5764 * h8300-tdep.c (h8300_register_name_common): New.
5765 h8300_register_name): Use h8300_register_name_common.
5766 (h8300s_register_name): Likewise.
5767 (h8300sx_register_name): Likewise.
5768 (h8300h_register_nam): New.
5769 (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
5770
5771
5772 2019-07-23 Srinath Parvathaneni <srinath.parvathaneni@arm.com>
5773
5774 * arm-tdep.c (arm_skip_cmse_entry): New function.
5775 (arm_is_sgstubs_section): New function.
5776 (arm_skip_stub): Add call to arm_skip_cmse_entry function.
5777
5778 2019-07-22 Tom Tromey <tom@tromey.com>
5779
5780 * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
5781 Don't self-assign.
5782
5783 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5784
5785 * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
5786 type_print.
5787
5788 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5789
5790 * symtab.c (search_symbols): Adjust msymbol matching type arrays
5791 so that GDB doesn't match any msymbols when searching in the
5792 TYPES_DOMAIN.
5793 (print_symbol_info): Print using typedef_print or type_print based
5794 on the type of the symbol. Add updated FIXME comment moved from...
5795 (_initialize_symtab): ... move and update FIXME comment to above.
5796
5797 2019-07-22 Andrew Burgess <andrew.burgess@embecosm.com>
5798
5799 * NEWS: Mention adding -q option to "info types".
5800 * symtab.c (struct info_types_options): New struct.
5801 (info_types_options_defs): New variable.
5802 (make_info_types_options_def_group): New function.
5803 (info_types_command): Use gdb::option framework to parse options.
5804 (info_types_command_completer): New function.
5805 (_initialize_symtab): Extend the help text on "info types" and
5806 register command completer.
5807
5808 2019-07-21 Christian Biesinger <cbiesinger@google.com>
5809
5810 * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
5811 (lookup_symbol_in_objfile): Change int to block_enum and add a
5812 gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
5813
5814 2019-07-20 Christian Biesinger <cbiesinger@google.com>
5815
5816 * MAINTAINERS (Write After Approval): Add self.
5817
5818 2019-07-19 Andrew Burgess <andrew.burgess@embecosm.com>
5819
5820 * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
5821 instruction to the dummy code region.
5822
5823 2019-07-19 Tom Tromey <tromey@adacore.com>
5824
5825 * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
5826 (ARGSUSED, PARAMS, __func__): Remove rules.
5827
5828 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5829
5830 * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
5831 * features/arm/arm-with-iwmmxt.c: Remove.
5832 * features/arm/arm-with-iwmmxt.xml: Remove.
5833 * features/arm/arm-with-m-fpa-layout.c: Remove.
5834 * features/arm/arm-with-m-fpa-layout.xml: Remove.
5835 * features/arm/arm-with-m-vfp-d16.c: Remove.
5836 * features/arm/arm-with-m-vfp-d16.xml: Remove.
5837 * features/arm/arm-with-m.c: Remove.
5838 * features/arm/arm-with-m.xml: Remove.
5839 * features/arm/arm-with-neon.c: Remove.
5840 * features/arm/arm-with-neon.xml: Remove.
5841 * features/arm/arm-with-vfpv2.c: Remove.
5842 * features/arm/arm-with-vfpv2.xml: Remove.
5843 * features/arm/arm-with-vfpv3.c: Remove.
5844 * features/arm/arm-with-vfpv3.xml: Remove.
5845
5846 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5847
5848 * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
5849
5850 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5851
5852 * arch/aarch32.c (aarch32_create_target_description): Create
5853 target descriptions using features.
5854 * arch/arm.c (arm_create_target_description)
5855 (arm_create_mprofile_target_description): Likewise.
5856 * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
5857
5858 2019-07-19 Alan Hayward <alan.hayward@arm.com>
5859
5860 * Makefile.in: Add new files.
5861 * aarch32-tdep.c: New file.
5862 * aarch32-tdep.h: New file.
5863 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
5864 Call aarch32_read_description.
5865 * arch/aarch32.c: New file.
5866 * arch/aarch32.h: New file.
5867 * arch/arm.c (arm_create_target_description)
5868 (arm_create_mprofile_target_description): New function.
5869 * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
5870 (arm_create_target_description)
5871 (arm_create_mprofile_target_description): New declaration.
5872 * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
5873 read_description functions.
5874 * arm-linux-nat.c (arm_linux_nat_target::read_description):
5875 Likewise.
5876 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
5877 * arm-tdep.c (tdesc_arm_list): New variable.
5878 (arm_register_g_packet_guesses): Call create description functions.
5879 (arm_read_description) (arm_read_mprofile_description): New
5880 function.
5881 * arm-tdep.h (arm_read_description)
5882 (arm_read_mprofile_description): Add declaration.
5883 * configure.tgt: Add new files.
5884
5885 2019-07-18 Guillaume LABARTHE <guillaume.labarthe@gmail.com>
5886
5887 * top.c (new_ui_command): Open specified terminal just once.
5888
5889 2019-07-18 Tom Tromey <tromey@adacore.com>
5890
5891 * symtab.c (main_name): Constify return type.
5892 * symfile.c (set_initial_language): Update.
5893 * symtab.h (main_name): Constify return type.
5894
5895 2019-07-17 Tom Tromey <tom@tromey.com>
5896
5897 * tui/tui-winsource.c (tui_update_source_window)
5898 (tui_update_source_window_as_is)
5899 (tui_update_source_windows_with_line): Remove return.
5900 * tui/tui-disasm.c (tui_show_disassem)
5901 (tui_show_disassem_and_update_source): Remove return.
5902 * tui/tui.c (tui_reset): Remove return.
5903 * tui/tui-wingeneral.c
5904 (tui_check_and_display_highlight_if_needed): Remove return.
5905
5906 2019-07-17 Tom Tromey <tom@tromey.com>
5907
5908 * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
5909
5910 2019-07-17 Tom Tromey <tom@tromey.com>
5911
5912 * tui/tui-winsource.h (struct tui_exec_info_window)
5913 (struct tui_source_window_base): Move from tui-data.h.
5914 * tui/tui-winsource.c: Move many method definitions from
5915 elsewhere. Remove "structuring" comments.
5916 * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
5917 (tui_source_window_base::refresh_window): Move to
5918 tui-winsource.c.
5919 * tui/tui-win.c (tui_source_window_base::refresh_all)
5920 (tui_source_window_base::update_tab_width)
5921 (tui_source_window_base::set_new_height)
5922 (tui_source_window_base::do_make_visible_with_new_height): Move to
5923 tui-winsource.c.
5924 * tui/tui-source.h: Update.
5925 * tui/tui-source.c (tui_source_window_base::reset): Move to
5926 tui-winsource.c.
5927 * tui/tui-disasm.h: Update.
5928 * tui/tui-data.h (struct tui_exec_info_window): Move to
5929 tui-winsource.h.
5930 (struct tui_source_window_base): Likewise.
5931 * tui/tui-data.c (tui_source_window_base::clear_detail)
5932 (tui_source_window_base, ~tui_source_window_base): Move to
5933 tui-winsource.c.
5934
5935 2019-07-17 Tom Tromey <tom@tromey.com>
5936
5937 * tui/tui-win.c (tui_resize_all)
5938 (tui_source_window_base::update_tab_width)
5939 (tui_adjust_win_heights): Update.
5940 (tui_win_info::make_invisible_and_set_new_height): Rename from
5941 make_invisible_and_set_new_height.
5942 * tui/tui-data.h (struct tui_win_info)
5943 <make_invisible_and_set_new_height>: New method.
5944
5945 2019-07-17 Tom Tromey <tom@tromey.com>
5946
5947 * tui/tui.c: Update.
5948 * tui/tui-source.h (struct tui_source_window): Move from
5949 tui-data.h.
5950 * tui/tui-layout.c: Update.
5951 * tui/tui-disasm.c: Update.
5952 * tui/tui-data.h (struct tui_source_window): Move to
5953 tui-source.h.
5954
5955 2019-07-17 Tom Tromey <tom@tromey.com>
5956
5957 * tui/tui-disasm.h (struct tui_disasm_window): Move from
5958 tui-data.h.
5959 * tui/tui-data.h (struct tui_disasm_window): Move to
5960 tui-disasm.h.
5961
5962 2019-07-17 Tom Tromey <tom@tromey.com>
5963
5964 * tui/tui-regs.h (struct tui_data_item_window): Move from
5965 tui-data.h.
5966 * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
5967 * tui/tui-data.h (struct tui_data_item_window): Move to
5968 tui-regs.h.
5969 * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
5970
5971 2019-07-17 Tom Tromey <tom@tromey.com>
5972
5973 * tui/tui.c: Update.
5974 * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
5975 (tui_cmd_window::max_height): Move to tui-command.c.
5976 * tui/tui-layout.c: Update.
5977 * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
5978 * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
5979 tui-command.c.
5980 * tui/tui-command.h (struct tui_cmd_window): Move from
5981 tui-data.h.
5982 * tui/tui-command.c: Remove "structuring" comments.
5983 (tui_cmd_window::clear_detail)
5984 (tui_cmd_window::do_make_visible_with_new_height)
5985 (tui_cmd_window::max_height): Move from elsewhere.
5986
5987 2019-07-17 Tom Tromey <tom@tromey.com>
5988
5989 * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
5990 Now static.
5991 * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
5992 * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
5993
5994 2019-07-17 Tom Tromey <tom@tromey.com>
5995
5996 * tui/tui.c: Update.
5997 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
5998 tui-regs.c.
5999 * tui/tui-windata.h: Remove file.
6000 * tui/tui-windata.c: Remove file.
6001 * tui/tui-win.c (tui_data_window::set_new_height)
6002 (tui_data_window::do_make_visible_with_new_height): Move to
6003 tui-regs.c.
6004 * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6005 * tui/tui-regs.c: Remove "structuring" comments.
6006 (tui_data_window::first_data_item_displayed)
6007 (tui_data_window::delete_data_content_windows)
6008 (tui_data_window::erase_data_content)
6009 (tui_data_window::display_all_data)
6010 (tui_data_window::refresh_all)
6011 (tui_data_window::do_scroll_vertical)
6012 (tui_data_window::clear_detail, tui_data_window::set_new_height)
6013 (tui_data_window::do_make_visible_with_new_height)
6014 (tui_data_window::refresh_window): Move from elsewhere.
6015 (_initialize_tui_regs): Move to end of file.
6016 * tui/tui-layout.c: Update.
6017 * tui/tui-hooks.c: Update.
6018 * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6019 * tui/tui-data.c (tui_data_window::clear_detail): Move to
6020 tui-regs.c.
6021 * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6022
6023 2019-07-17 Tom Tromey <tom@tromey.com>
6024
6025 * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6026 seen.
6027
6028 2019-07-17 Tom Tromey <tom@tromey.com>
6029
6030 * tui/tui-win.c (tui_source_window_base::set_new_height)
6031 (tui_source_window_base::do_make_visible_with_new_height): Use
6032 m_has_locator field directly.
6033 * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6034 method.
6035 (struct tui_source_window_base) <has_locator>: Likewise.
6036
6037 2019-07-17 Tom Tromey <tom@tromey.com>
6038
6039 * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6040 Don't declare.
6041 * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6042 Remove.
6043 * tui/tui-win.c (tui_source_window_base::set_new_height)
6044 (tui_source_window_base::set_new_height)
6045 (make_invisible_and_set_new_height)
6046 (tui_source_window_base::do_make_visible_with_new_height)
6047 (tui_source_window_base::do_make_visible_with_new_height):
6048 Update.
6049 * tui/tui-layout.c (show_source_disasm_command, show_data)
6050 (show_source_or_disasm_and_command): Update.
6051 * tui/tui-layout.c (show_layout): Update.
6052
6053 2019-07-17 Tom Tromey <tom@tromey.com>
6054
6055 * tui/tui-layout.c (make_data_window): Remove.
6056 (show_data): Unify creation and re-initialization cases.
6057
6058 2019-07-17 Tom Tromey <tom@tromey.com>
6059
6060 * tui/tui-layout.c (make_source_window, make_disasm_window):
6061 Remove.
6062 (show_data): Unify creation and re-initialization cases.
6063
6064 2019-07-17 Tom Tromey <tom@tromey.com>
6065
6066 * tui/tui-layout.c (make_command_window): Remove.
6067 (show_source_disasm_command, show_source_or_disasm_and_command):
6068 Unify creation and re-initialization cases.
6069
6070 2019-07-17 Tom Tromey <tom@tromey.com>
6071
6072 * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6073 creation and re-initialization cases.
6074
6075 2019-07-17 Tom Tromey <tom@tromey.com>
6076
6077 * tui/tui-regs.c (tui_get_register): Return void.
6078
6079 2019-07-17 Tom Tromey <tom@tromey.com>
6080
6081 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6082 Simplify.
6083
6084 2019-07-17 Tom Tromey <tom@tromey.com>
6085
6086 * tui/tui-layout.c (show_source_disasm_command): Simplify window
6087 resetting.
6088
6089 2019-07-17 Tom Tromey <tom@tromey.com>
6090
6091 * tui/tui.h (tui_set_layout_by_name): Don't declare.
6092 * tui/tui-regs.c (tui_reg_layout): New function.
6093 (tui_show_registers, tui_reg_command): Use it.
6094 * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6095 (tui_layout_command): Rename from tui_set_layout_by_name. Change
6096 parameters.
6097 (tui_layout_command): Remove.
6098
6099 2019-07-17 Tom Tromey <tom@tromey.com>
6100
6101 * tui/tui-layout.h (tui/tui-layout): Return void.
6102 * tui/tui-layout.c (tui_set_layout): Return void. Add assert.
6103
6104 2019-07-17 Tom Tromey <tom@tromey.com>
6105
6106 * tui/tui-layout.c (show_source_disasm_command, show_data):
6107 Update.
6108 (reset_locator): Remove.
6109 (show_source_or_disasm_and_command): Update.
6110
6111 2019-07-17 Tom Tromey <tom@tromey.com>
6112
6113 * tui/tui-source.c (tui_source_window_base::reset): Remove
6114 win_type parameter.
6115 * tui/tui-layout.c (make_command_window, make_source_window)
6116 (make_disasm_window, make_data_window)
6117 (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6118 (reset_locator, show_source_or_disasm_and_command): Update.
6119 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6120 win_type parameter.
6121 (struct tui_source_window_base) <reset>: Likewise.
6122
6123 2019-07-17 Tom Tromey <tom@tromey.com>
6124
6125 * tui/tui-layout.c (show_source_disasm_command): Use
6126 reset_locator.
6127 (reset_locator): New function.
6128 (init_and_make_win): Remove.
6129 (show_source_or_disasm_and_command): Use reset_locator.
6130
6131 2019-07-17 Tom Tromey <tom@tromey.com>
6132
6133 * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6134 condition.
6135 * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6136 Remove condition.
6137 * tui/tui-source.c (tui_source_window_base::reset): New method.
6138 * tui/tui-layout.c (make_command_window): Don't call
6139 init_and_make_win.
6140 (make_source_window, make_disasm_window): Don't call
6141 make_source_or_disasm_window.
6142 (make_data_window): Don't call init_and_make_win. Change calling
6143 convention.
6144 (show_source_disasm_command, show_data): Simplify.
6145 (make_source_or_disasm_window): Remove.
6146 (show_source_or_disasm_and_command): Simplify.
6147 * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6148 (struct tui_source_window_base) <reset>: Likewise.
6149 <execution_info>: Remove initializer.
6150 * tui/tui-data.c (tui_source_window_base): Initialize
6151 execution_info.
6152
6153 2019-07-17 Tom Tromey <tom@tromey.com>
6154
6155 * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6156 variable.
6157
6158 2019-07-17 Tom Tromey <tom@tromey.com>
6159
6160 * tui/tui.c (tui_rl_other_window): Update.
6161 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6162 superclass method first. Always iterate over regs_content.
6163 (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6164 method.
6165 * tui/tui-win.c (tui_set_focus_command): Update.
6166
6167 2019-07-17 Tom Tromey <tom@tromey.com>
6168
6169 * tui/tui-win.c (tui_set_focus_command): Rename from
6170 tui_set_focus. Call tui_enable.
6171 (tui_set_focus_command): Remove.
6172
6173 2019-07-17 Tom Tromey <tom@tromey.com>
6174
6175 * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6176 refresh_window.
6177 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6178 touchwin.
6179 (tui_data_window::refresh_window): Call refresh_window on data
6180 items. Always call superclass refresh_window.
6181 (tui_win_info::refresh): Remove.
6182 (tui_source_window_base::refresh_window): Update.
6183 (tui_refresh_all): Update.
6184 * tui/tui-layout.c (show_source_disasm_command): Remove call to
6185 refresh_window.
6186 (show_source_or_disasm_and_command): Likewise.
6187 * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6188 (struct tui_source_window_base) <refresh>: Likewise.
6189
6190 2019-07-17 Tom Tromey <tom@tromey.com>
6191
6192 * tui/tui-winsource.c (tui_clear_source_content)
6193 (tui_show_source_content): Update.
6194 * tui/tui-source.c (tui_source_window::showing_source_p): Check
6195 whether content is empty.
6196 * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6197 Remove.
6198
6199 2019-07-17 Tom Tromey <tom@tromey.com>
6200
6201 * tui/tui-winsource.c (tui_erase_source_content): Clear the
6202 window's contents.
6203 * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6204 * tui/tui-source.c (tui_set_source_content_nil): Remove.
6205
6206 2019-07-17 Tom Tromey <tom@tromey.com>
6207
6208 * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6209 (struct tui_data_item_window): Update.
6210
6211 2019-07-17 Tom Tromey <tom@tromey.com>
6212
6213 * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6214 (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6215 defines.
6216
6217 2019-07-17 Tom Tromey <tom@tromey.com>
6218
6219 * tui/tui-winsource.h (tui_erase_source_content)
6220 (tui_clear_source_content): Remove "display_prompt" parameter.
6221 * tui/tui-winsource.c (tui_update_source_window_as_is)
6222 (tui_update_source_windows_with_addr): Update.
6223 (tui_clear_source_content): Remove "display_prompt" parameter.
6224 (tui_erase_source_content): Likewise. Simplify.
6225 (tui_show_source_content): Update.
6226 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6227 * tui/tui-stack.c (tui_show_frame_info): Update.
6228 * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6229 Remove defines.
6230
6231 2019-07-17 Tom Tromey <tom@tromey.com>
6232
6233 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6234 * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6235 parameter.
6236 * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6237 parameter.
6238
6239 2019-07-17 Tom Tromey <tom@tromey.com>
6240
6241 * tui/tui-winsource.c (tui_clear_source_content)
6242 (tui_show_source_content, tui_show_exec_info_content)
6243 (tui_clear_exec_info_content): Update.
6244 * tui/tui-stack.c (tui_show_locator_content): Update.
6245 (tui_show_frame_info): Update.
6246 * tui/tui-source.h (tui_source_window): Don't declare.
6247 * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6248 from tui_source_is_displayed.
6249 * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
6250 Remove field.
6251 (struct tui_source_window_base) <content_in_use>: New field. Now
6252 bool.
6253 (struct tui_source_window) <showing_source_p>: New method.
6254 (TUI_SRC_WIN): Change cast.
6255 * tui/tui-data.c (tui_initialize_static_data): Update.
6256
6257 2019-07-17 Tom Tromey <tom@tromey.com>
6258
6259 * tui/tui-winsource.c (tui_update_breakpoint_info): Use
6260 location_matches_p.
6261 * tui/tui-source.c (tui_source_window::location_matches_p): New
6262 method.
6263 * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
6264 method.
6265 * tui/tui-data.h (struct tui_source_window_base)
6266 <location_matches_p>: New method.
6267 (struct tui_source_window, struct tui_disasm_window)
6268 <location_matches_p>: Likewise.
6269
6270 2019-07-17 Tom Tromey <tom@tromey.com>
6271
6272 * tui/tui-win.c (tui_set_win_height_command): Rename from
6273 tui_set_win_height.
6274 (tui_set_win_height_command): Remove.
6275
6276 2019-07-17 Tom Tromey <tom@tromey.com>
6277
6278 * tui/tui-source.c (tui_source_window): New constructor. Add
6279 observer.
6280 (~tui_source_window): New destructor.
6281 (tui_source_window::style_changed): New method.
6282 * tui/tui-hooks.c (tui_redisplay_source): Remove.
6283 (tui_attach_detach_observers): Update.
6284 * tui/tui-data.h (struct tui_source_window): Make constructor not
6285 inline. Add destructor.
6286 (struct tui_source_window) <style_changed>: New method.
6287 <m_observable>: New member.
6288
6289 2019-07-17 Tom Tromey <tom@tromey.com>
6290
6291 * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
6292 * tui/tui-win.c (tui_resize_all): Fix typo.
6293
6294 2019-07-17 Tom Tromey <tom@tromey.com>
6295
6296 * tui/tui-wingeneral.h (tui_refresh_all): Update.
6297 * tui/tui-wingeneral.c (make_all_visible): Use foreach.
6298 (tui_refresh_all): Remove "list" parameter. Use foreach.
6299 * tui/tui-win.c (window_name_completer): Use foreach.
6300 (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
6301 (update_tab_width): Likewise.
6302 * tui/tui-layout.c (show_layout): Update.
6303 * tui/tui-data.h (class tui_window_iterator): New.
6304 (struct all_tui_windows): New.
6305 * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
6306
6307 2019-07-17 Tom Tromey <tom@tromey.com>
6308
6309 * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
6310 parameter. Don't reference globals.
6311 (tui_reg_command): Update.
6312
6313 2019-07-17 Tom Tromey <tom@tromey.com>
6314
6315 * tui/tui-regs.c (tui_show_registers): Simplify.
6316
6317 2019-07-17 Tom Tromey <tom@tromey.com>
6318
6319 * tui/tui-regs.c (tui_show_registers): Update.
6320 (tui_show_register_group): Add win_info parameter.
6321
6322 2019-07-17 Tom Tromey <tom@tromey.com>
6323
6324 * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
6325 Rename from tui_display_reg_element_at_line.
6326 (tui_data_window::display_registers_from_line): Update.
6327 * tui/tui-data.h (struct tui_data_window)
6328 <display_reg_element_at_line>: New method.
6329
6330 2019-07-17 Tom Tromey <tom@tromey.com>
6331
6332 * tui/tui-regs.h (tui_display_registers_from)
6333 (tui_display_registers_from_line): Don't declare.
6334 * tui/tui-windata.c (tui_data_window::display_all_data)
6335 (tui_data_window::refresh_all)
6336 (tui_data_window::do_scroll_vertical): Update.
6337 * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
6338 from tui_display_registers_from.
6339 (tui_display_reg_element_at_line): Update.
6340 (tui_data_window::display_registers_from_line): Rename from
6341 tui_display_registers_from_line.
6342 * tui/tui-data.h (struct tui_data_window) <display_registers_from,
6343 display_registers_from_line>: New methods.
6344
6345 2019-07-17 Tom Tromey <tom@tromey.com>
6346
6347 * tui/tui-windata.h (tui_erase_data_content): Don't declare.
6348 * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
6349 from tui_erase_data_content.
6350 (tui_data_window::display_all_data)
6351 (tui_data_window::refresh_all)
6352 (tui_data_window::do_scroll_vertical): Update.
6353 * tui/tui-regs.c (tui_show_registers): Update.
6354 * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
6355 New method.
6356
6357 2019-07-17 Tom Tromey <tom@tromey.com>
6358
6359 * tui/tui-windata.h (tui_delete_data_content_windows): Don't
6360 declare.
6361 * tui/tui-windata.c
6362 (tui_data_window::delete_data_content_windows): Rename from
6363 tui_delete_data_content_windows.
6364 (tui_data_window::display_all_data)
6365 (tui_data_window::do_scroll_vertical): Update.
6366 * tui/tui-data.h (struct tui_data_window)
6367 <delete_data_content_windows>: New method.
6368
6369 2019-07-17 Tom Tromey <tom@tromey.com>
6370
6371 * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
6372 * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
6373
6374 2019-07-17 Tom Tromey <tom@tromey.com>
6375
6376 * tui/tui-windata.h (tui_display_all_data): Don't declare.
6377 * tui/tui-windata.c (tui_data_window::display_all_data): Rename
6378 from tui_display_all_data.
6379 * tui/tui-win.c
6380 (tui_data_window::do_make_visible_with_new_height): Update.
6381 * tui/tui-regs.c (tui_show_registers): Update.
6382 * tui/tui-layout.c (tui_set_layout): Update.
6383 * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
6384 method.
6385
6386 2019-07-17 Tom Tromey <tom@tromey.com>
6387
6388 * tui/tui-windata.h (tui_display_data_from): Don't declare.
6389 * tui/tui-windata.c (tui_display_data_from): Remove.
6390 (tui_data_window::refresh_all): Update.
6391
6392 2019-07-17 Tom Tromey <tom@tromey.com>
6393
6394 * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
6395 * tui/tui-windata.c (tui_display_data_from_line): Remove.
6396 (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
6397 tui_display_registers_from_line.
6398 * tui/tui-regs.h (tui_display_registers_from_line): Update.
6399 * tui/tui-regs.c (tui_display_registers_from_line): Remove
6400 "force_display" parameter.
6401
6402 2019-07-17 Tom Tromey <tom@tromey.com>
6403
6404 * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
6405 declare.
6406 * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
6407 Rename from tui_first_reg_element_no_inline.
6408 (tui_display_reg_element_at_line)
6409 (tui_display_registers_from_line): Update.
6410 * tui/tui-data.h (struct tui_data_window)
6411 <first_reg_element_no_inline>: New method.
6412
6413 2019-07-17 Tom Tromey <tom@tromey.com>
6414
6415 * tui/tui-windata.c (tui_display_data_from)
6416 (tui_data_window::do_scroll_vertical): Update.
6417 * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
6418 * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
6419 Rename from tui_line_from_reg_element_no.
6420 (tui_display_registers_from_line): Update.
6421 * tui/tui-data.h (struct tui_data_window)
6422 <line_from_reg_element_no>: New method.
6423
6424 2019-07-17 Tom Tromey <tom@tromey.com>
6425
6426 * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
6427 * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
6428 tui_last_regs_line_no.
6429 (tui_display_reg_element_at_line)
6430 (tui_display_registers_from_line): Update.
6431 * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
6432 method.
6433
6434 2019-07-17 Tom Tromey <tom@tromey.com>
6435
6436 PR tui/24722:
6437 * tui/tui-winsource.h (tui_update_all_breakpoint_info)
6438 (tui_update_breakpoint_info): Add "being_deleted" parameter.
6439 * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6440 (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
6441 (tui_update_breakpoint_info): Likewise.
6442 * tui/tui-hooks.c (tui_event_create_breakpoint)
6443 (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
6444 Update.
6445
6446 2019-07-17 Tom Tromey <tom@tromey.com>
6447
6448 * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
6449
6450 2019-07-17 Tom Tromey <tom@tromey.com>
6451
6452 * tui/tui-winsource.c (tui_update_source_window_as_is)
6453 (tui_update_source_windows_with_addr): Update.
6454 * tui/tui-source.h (tui_set_source_content)
6455 (tui_show_symtab_source): Add "win_info" parameter.
6456 * tui/tui-source.c (tui_set_source_content): Add "win_info"
6457 parameter.
6458 (tui_show_symtab_source): Likewise.
6459
6460 2019-07-17 Tom Tromey <tom@tromey.com>
6461
6462 * tui/tui-wingeneral.c
6463 (tui_check_and_display_highlight_if_needed): Check can_highlight.
6464
6465 2019-07-17 Tom Tromey <tom@tromey.com>
6466
6467 * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
6468 (struct tui_cmd_window) <can_scroll>: New method.
6469 * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
6470 method.
6471
6472 2019-07-17 Tom Tromey <tromey@adacore.com>
6473
6474 * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
6475 do_field_signed>: Rename. Change type of "value".
6476 * ui-out.c (ui_out::field_signed): Rename from field_int.
6477 Change type of "value".
6478 (ui_out::field_fmt_signed): Rename from field_fmt_int. Change
6479 type of "value".
6480 * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
6481 do_field_int. Change type of "value".
6482 * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
6483 do_field_int. Change type of "value".
6484 * tracepoint.c (trace_status_mi, tfind_1)
6485 (print_one_static_tracepoint_marker): Update.
6486 * thread.c (print_thread_info_1, print_selected_thread_frame):
6487 Update.
6488 * stack.c (print_frame, print_frame_info): Update.
6489 * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
6490 Update.
6491 * source.c (print_source_lines_base): Update.
6492 * skip.c (info_skip_command): Update.
6493 * record-btrace.c (btrace_ui_out_decode_error)
6494 (btrace_call_history_src_line): Update.
6495 * python/py-framefilter.c (py_print_single_arg, py_print_frame):
6496 Update.
6497 * progspace.c (print_program_space): Update.
6498 * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
6499 * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
6500 do_field_int. Change type of "value".
6501 * mi/mi-out.c (mi_ui_out::do_table_begin)
6502 (mi_ui_out::do_table_header): Update.
6503 (mi_ui_out::do_field_signed): Rename from do_field_int. Change
6504 type of "value".
6505 * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
6506 (mi_cmd_data_list_changed_registers, output_register)
6507 (mi_cmd_data_read_memory, mi_load_progress)
6508 (mi_cmd_trace_frame_collected): Update.
6509 * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
6510 Update.
6511 * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
6512 (mi_cmd_var_delete, mi_cmd_var_info_num_children)
6513 (mi_cmd_var_list_children, varobj_update_one): Update.
6514 * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
6515 (mi_cmd_stack_list_args, list_arg_or_local): Update.
6516 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
6517 * inferior.c (print_inferior): Update.
6518 * gdb_bfd.c (print_one_bfd): Update.
6519 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6520 Update.
6521 * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
6522 * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
6523 do_field_int. Change type of "value".
6524 * cli-out.c (cli_ui_out::do_field_signed): Rename from
6525 do_field_int. Change type of "value".
6526 * breakpoint.c (watchpoint_check, print_breakpoint_location)
6527 (print_one_breakpoint_location, print_it_catch_fork)
6528 (print_one_catch_fork, print_it_catch_vfork)
6529 (print_one_catch_vfork, print_it_catch_solib)
6530 (print_it_catch_exec, print_it_ranged_breakpoint)
6531 (print_mention_watchpoint, print_mention_masked_watchpoint)
6532 (bkpt_print_it, update_static_tracepoint): Update.
6533 * break-catch-throw.c (print_it_exception_catchpoint): Update.
6534 * break-catch-syscall.c (print_it_catch_syscall): Update.
6535 * ada-tasks.c (print_ada_task_info): Update.
6536 * ada-lang.c (print_it_exception, print_mention_exception):
6537 Update.
6538
6539 2019-07-17 Andrew Burgess <andrew.burgess@embecosm.com>
6540
6541 PR breakpoints/24541
6542 * gdbarch.c: Regenerate.
6543 * gdbarch.h: Regenerate.
6544 * gdbarch.sh: Adjust return type and parameter types for
6545 'stap_adjust_register'.
6546 (i386_stap_adjust_register): Adjust signature and return new
6547 register name.
6548 * stap-probe.c (stap_parse_register_operand): Adjust use of
6549 'gdbarch_stap_adjust_register'.
6550
6551 2019-07-17 Tom Tromey <tromey@adacore.com>
6552
6553 * s390-linux-nat.c (s390_watch_area): Remove typedef. Don't
6554 declare VEC.
6555 (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
6556 std::vector.
6557 (struct s390_process_info): Add initializers.
6558 (s390_add_process): Use new.
6559 (s390_linux_nat_target::low_forget_process): Use delete.
6560 (s390_linux_nat_target::low_new_fork)
6561 (s390_linux_nat_target::stopped_by_watchpoint)
6562 (s390_linux_nat_target::low_prepare_to_resume)
6563 (s390_linux_nat_target::insert_watchpoint)
6564 (s390_linux_nat_target::insert_hw_breakpoint)
6565 (s390_linux_nat_target::remove_watchpoint)
6566 (s390_linux_nat_target::remove_hw_breakpoint): Update.
6567
6568 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6569
6570 * aarch64-fbsd-nat.c: Include regcache.h.
6571 (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
6572 argument.
6573 (aarch64_fbsd_nat_target::fetch_registers)
6574 (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
6575 variable.
6576 * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
6577
6578 2019-07-16 John Baldwin <jhb@FreeBSD.org>
6579
6580 * fbsd-nat.c: Include gdbarch.h.
6581
6582 2019-07-15 Tom Tromey <tromey@adacore.com>
6583
6584 * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
6585
6586 2019-07-15 Tom Tromey <tromey@adacore.com>
6587
6588 * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
6589 * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
6590 * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
6591 * cli-out.c (cli_ui_out::do_field_int): New method.
6592 * ui-out.c (ui_out::field_unsigned): New method.
6593 * symfile.c (generic_load): Use field_unsigned.
6594 (print_transfer_performance): Likewise.
6595 * record-btrace.c (ui_out_field_uint): Remove.
6596 (btrace_call_history_insn_range, btrace_call_history): Use
6597 field_unsigned.
6598 * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
6599 field_unsigned.
6600 * ui-out.h (class ui_out) <field_unsigned>: New method.
6601 <do_field_unsigned>: Likewise.
6602
6603 2019-07-15 Tom Tromey <tromey@adacore.com>
6604
6605 * mi/mi-main.c (list_available_thread_groups): Use field_string.
6606 * mi/mi-interp.c (mi_memory_changed): Use field_string.
6607 * target.c (flash_erase_command): Use field_string.
6608 * infrun.c (print_signal_received_reason): Use field_string.
6609 * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
6610 * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
6611 field_string.
6612 * ada-tasks.c (print_ada_task_info): Use field_string.
6613
6614 2019-07-15 Tom Tromey <tromey@adacore.com>
6615
6616 * target.c (flash_erase_command): Use field_core_addr.
6617 * symfile.c (generic_load): Use field_core_addr.
6618 * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
6619 Use field_core_addr.
6620 * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
6621 field_core_addr.
6622
6623 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6624
6625 * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
6626 value if its desired type is smaller than a CORE_ADDR and signed.
6627
6628 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6629
6630 * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
6631 of changes to field names, and use new is_reference field to
6632 decide if a property is a reference or not.
6633 * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
6634 field.
6635 (struct dwarf2_property_baton): Update header comment, rename
6636 'referenced_type' to 'property_type' and update comments.
6637 * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
6638 default property type, store in property baton, update to take
6639 accound of renamed field.
6640 (read_func_scope): Update call to attr_to_dynamic_prop.
6641 (read_array_type): Likewise.
6642 (dwarf2_per_cu_addr_sized_int_type): New function.
6643 (read_subrange_index_type): Move type finding code to
6644 dwarf2_per_cu_addr_sized_int_type.
6645 (read_subrange_type): Update calls to attr_to_dynamic_prop.
6646 (dwarf2_per_cu_addr_type): New function.
6647 (set_die_type): Update calls to attr_to_dynamic_prop.
6648
6649 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6650
6651 * dwarf2read.c (read_subrange_index_type): New function.
6652 (read_subrange_type): Move code into new function and call it.
6653 * gdbtypes.c (create_range_type): Add some asserts.
6654
6655 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6656
6657 * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
6658 update return statements.
6659 * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
6660 declaration, and update comment to match.
6661 * gdbtypes.c (resolve_dynamic_array): Update call to
6662 dwarf2_evaluate_property to match new return type.
6663
6664 2019-07-12 Andrew Burgess <andrew.burgess@embecosm.com>
6665
6666 * valarith.c (value_subscripted_rvalue): Change lowerbound
6667 parameter type from int to LONGEST.
6668 * value.h (value_subscripted_rvalue): Likewise in declaration.
6669
6670 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6671
6672 * cli/cli-utils.c (info_print_command_completer): New function.
6673 * cli/cli-utils.h: Add 'completer.h' include, and forward
6674 declaration for 'struct cmd_list_element'.
6675 (info_print_command_completer): Declare.
6676 * stack.c (_initialize_stack): Add completer for 'info locals' and
6677 'info args'.
6678 * symtab.c (_initialize_symtab): Add completer for 'info
6679 variables' and 'info functions'.
6680 * NEWS: Mention completion for additional info commands.
6681
6682 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6683
6684 * cli/cli-utils.c (extract_info_print_args): Delete.
6685 (extract_arg_maybe_quoted): Delete.
6686 (info_print_options_defs): New variable.
6687 (make_info_print_options_def_group): New function.
6688 (extract_info_print_options): Define new function.
6689 * cli/cli-utils.h (extract_info_print_args): Delete.
6690 (struct info_print_options): New structure.
6691 (extract_info_print_options): Declare new function.
6692 * stack.c (info_locals_command): Update to use new
6693 extract_info_print_options, also add a header comment.
6694 (info_args_command): Likewise.
6695 * symtab.c (info_variables_command): Likewise.
6696 (info_functions_command): Likewise.
6697
6698 2019-07-11 Andrew Burgess <andrew.burgess@embecosm.com>
6699
6700 * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
6701 to extract string arguments.
6702 * common/common-utils.c (extract_string_maybe_quoted): New function.
6703 * common/common-utils.h (extract_string_maybe_quoted): Declare.
6704
6705 2019-07-11 Tom Tromey <tromey@adacore.com>
6706
6707 * main.c (get_init_files): Use GDBINIT, not gdbinit.
6708 * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
6709 * top.h (gdbinit): Don't declare.
6710 * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
6711 into...
6712 (_initialize_cli_cmds): ...here. Use GDBINIT, not gdbinit.
6713 * top.c (gdb_init): Don't call init_cli_cmds.
6714 (gdbinit): Remove.
6715 * cli/cli-cmds.h (init_cli_cmds): Don't declare.
6716
6717 2019-07-11 Tom Tromey <tromey@adacore.com>
6718
6719 * python/py-inferior.c (add_thread_object): Don't use thread_obj
6720 after it has been moved.
6721
6722 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6723
6724 * valops.c (value_must_coerce_to_target): Change return type to
6725 bool.
6726 * value.h (value_must_coerce_to_target): Likewise.
6727
6728 2019-07-10 Simon Marchi <simon.marchi@efficios.com>
6729
6730 * breakpoint.c (is_hardware_watchpoint): Remove
6731 forward-declaration.
6732 (is_masked_watchpoint): Change return type to bool.
6733 (is_tracepoint): Likewise.
6734 (is_breakpoint): Likewise.
6735 (is_hardware_watchpoint): Likewise.
6736 (is_watchpoint): Likewise.
6737 (is_no_memory_software_watchpoint): Likewise.
6738 (is_catchpoint): Likewise.
6739 (breakpoint_1): Make FILTER parameter's return type bool.
6740 is_masked_watchpoint): Change return type to bool.
6741 (save_breakpoints): Make FILTER parameter's return type bool.
6742 * breakpoint.h (is_breakpoint): Change return type to bool.
6743 (is_watchpoint): Likewise.
6744 (is_catchpoint): Likewise.
6745 (is_tracepoint): Likewise.
6746
6747 2019-07-10 Tom Tromey <tom@tromey.com>
6748
6749 * defs.h: Don't include gdbarch.h.
6750 * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
6751 alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
6752 ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
6753 cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
6754 cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
6755 compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
6756 cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
6757 dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
6758 dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
6759 dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
6760 frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
6761 go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
6762 i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
6763 linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
6764 mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
6765 objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
6766 parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
6767 record-btrace.c, record.h, regcache-dump.c, regcache.h,
6768 riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
6769 sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
6770 sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
6771 sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
6772 target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
6773 tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
6774 utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
6775 xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
6776 * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
6777
6778 2019-07-10 Tom Tromey <tromey@adacore.com>
6779
6780 * ada-lang.h (is_ada_exception_catchpoint): Declare.
6781 * breakpoint.c (init_ada_exception_breakpoint): Register as
6782 bp_catchpoint.
6783 (print_one_breakpoint_location, print_one_breakpoint): Use
6784 is_ada_exception_catchpoint.
6785 * ada-lang.c (class ada_catchpoint_location): Pass
6786 bp_loc_software_breakpoint to bp_location constructor.
6787 (is_ada_exception_catchpoint): New function.
6788
6789 2019-07-10 Tom Tromey <tromey@adacore.com>
6790
6791 * arm-tdep.c (arm_exidx_entry_s): Remove typedef. Don't define
6792 VEC.
6793 (struct arm_exidx_entry): New method operator<.
6794 (struct arm_exidx_data) <section_maps>: Change type.
6795 (arm_exidx_data_free): Remove.
6796 (arm_exidx_data_key): Change type. Move lower.
6797 (arm_exidx_new_objfile): Update.
6798 (arm_compare_exidx_entries): Remove.
6799 (arm_find_exidx_entry, _initialize_arm_tdep)
6800
6801 2019-07-10 Tom Tromey <tromey@adacore.com>
6802
6803 * solib-spu.c (ocl_program_data_key): Change type.
6804 (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
6805 Update.
6806
6807 2019-07-10 Tom Tromey <tromey@adacore.com>
6808
6809 * solib-aix.c (lm_info_aix_p): Remove typedef. Don't define VEC.
6810 (struct solib_aix_inferior_data) <library_list>: Change type.
6811 (solib_aix_inferior_data_handle): Change type.
6812 (get_solib_aix_inferior_data): Update.
6813 (solib_aix_free_library_list): Remove.
6814 (library_list_start_library): Update.
6815 (solib_aix_parse_libraries, solib_aix_get_library_list): Change
6816 return type.
6817 (solib_aix_get_library_list)
6818 (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
6819 (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
6820
6821 2019-07-10 Tom Tromey <tromey@adacore.com>
6822
6823 * solib-dsbt.c (struct dsbt_info): Add initializers.
6824 (solib_dsbt_pspace_data): Change type.
6825 (dsbt_pspace_data_cleanup): Remove.
6826 (get_dsbt_info, _initialize_dsbt_solib): Update.
6827
6828 2019-07-10 Tom Tromey <tromey@adacore.com>
6829
6830 * spu-tdep.c (spu_overlay_data): Change type.
6831 (spu_get_overlay_table, spu_overlay_new_objfile)
6832 (_initialize_spu_tdep): Update.
6833
6834 2019-07-10 Tom Tromey <tromey@adacore.com>
6835
6836 * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
6837 destructor.
6838 (dbx_objfile_data_key): Change type and declare later.
6839 (DBX_SYMFILE_INFO): Rewrite.
6840 * dbxread.c (dbx_objfile_data_key): Change type.
6841 (dbx_symfile_init): Update.
6842 (~dbx_symfile_info): Rename from dbx_free_symfile_info. Update.
6843 (coffstab_build_psymtabs, elfstab_build_psymtabs)
6844 (stabsect_build_psymtabs, _initialize_dbxread): Update.
6845
6846 2019-07-10 Tom Tromey <tromey@adacore.com>
6847
6848 * jit.c (jit_program_space_key): Change type. Move lower.
6849 (get_jit_program_space_data): Update.
6850 (jit_program_space_data_cleanup): Remove.
6851 (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
6852 Update.
6853 (struct jit_program_space_data): Add initializers.
6854
6855 2019-07-10 Tom Tromey <tromey@adacore.com>
6856
6857 * solib-darwin.c (struct darwin_info): Add initializers.
6858 (solib_darwin_pspace_data): Change type.
6859 (darwin_pspace_data_cleanup): Remove.
6860 (get_darwin_info, _initialize_darwin_solib): Update.
6861
6862 2019-07-10 Tom Tromey <tromey@adacore.com>
6863
6864 * remote-sim.c (struct sim_inferior_data): Add initializers,
6865 constructor, and destructor.
6866 (sim_inferior_data_key): Change type. Move lower.
6867 (check_for_duplicate_sim_descriptor): Update.
6868 (get_sim_inferior_data): Use new. Update.
6869 (~sim_inferior_data_cleanup): Rename from
6870 sim_inferior_data_cleanup. Simplify.
6871 (gdbsim_close_inferior, simulator_command)
6872 (sim_command_completer, _initialize_remote_sim): Update.
6873 (next_pid, INITIAL_PID): Move earlier.
6874
6875 2019-07-10 Tom Tromey <tromey@adacore.com>
6876
6877 * python/python-internal.h (create_thread_object): Return
6878 gdbpy_ref.
6879 * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
6880 * python/py-inferior.c (struct threadlist_entry): Add
6881 constructor.
6882 <thread_obj>: Now a gdbpy_ref.
6883 (thread_to_thread_object): Update.
6884 (add_thread_object): Use new.
6885 (delete_thread_object): Use delete.
6886 (infpy_threads): Update.
6887 (py_free_inferior): Update. Construct "inf_obj" after acquiring
6888 GIL.
6889
6890 2019-07-10 Tom Tromey <tromey@adacore.com>
6891
6892 * valops.c (value_cast): Specialize error message for Ada.
6893
6894 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6895
6896 * breakpoint.c (breakpoint_1): Update doc and parameter names.
6897
6898 2019-07-10 Simon Marchi <simon.marchi@polymtl.ca>
6899
6900 * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
6901 bpstat_should_step): Return bool, adjust comments.
6902 * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
6903 bpstat_should_step): Likewise.
6904
6905 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6906
6907 * features/Makefile: Use feature target descriptions for Arm.
6908 * features/arm/arm-core.c: Generate new file.
6909 * features/arm/arm-fpa.c: Likewise.
6910 * features/arm/arm-m-profile-with-fpa.xml: Likewise.
6911 * features/arm/arm-m-profile.c: Likewise.
6912 * features/arm/arm-vfpv2.c: Likewise.
6913 * features/arm/arm-vfpv3.c: Likewise.
6914 * features/arm/xscale-iwmmxt.c: Likewise.
6915 * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
6916
6917 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6918
6919 * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
6920 ptrace earlier.
6921
6922 2019-07-10 Alan Hayward <alan.hayward@arm.com>
6923
6924 * features/aarch64-pauth.c: Regenerate.
6925
6926 2019-07-09 Simon Marchi <simon.marchi@polymtl.ca>
6927
6928 * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
6929 bool.
6930 (bpstat_what): Use false instead of 0.
6931
6932 2019-07-09 Pedro Alves <palves@redhat.com>
6933
6934 * break-catch-throw.c (is_exception_catchpoint): New.
6935 * breakpoint.c (print_one_breakpoint_location): New parameter
6936 'raw_loc'. Handle it. Use
6937 is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
6938 looking at the breakpoint's type.
6939 (print_one_breakpoint): If handling "maint info breakpoints", also
6940 print locations of exception catchpoints.
6941 * breakpoint.h (is_exception_catchpoint): Declare.
6942
6943 2019-07-09 Pedro Alves <palves@redhat.com>
6944
6945 * break-catch-throw.c (print_one_exception_catchpoint): Skip the
6946 "addr" field.
6947 (allocate_location_exception_catchpoint): New.
6948 (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
6949 (initialize_throw_catchpoint_ops): Install
6950 allocate_location_exception_catchpoint as allocate_location
6951 method.
6952 * breakpoint.c (bpstat_what) <bp_catch>: Set action to
6953 BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
6954 bp_loc_other.
6955 (breakpoint_address_is_meaningful): Delete.
6956 (bl_address_is_meaningful): New.
6957 (breakpoint_locations_match): Adjust comment.
6958 (bp_location_from_bp_type): New, factored out of...
6959 (bp_location::bp_location(breakpoint *)): ... this.
6960 (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
6961 factored out of...
6962 (bp_location::bp_location(breakpoint *)): ... this. Reimplement.
6963 (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
6964 breakpoint_address_is_meaningful.
6965 (bp_locations_compare): Adjust comment.
6966 (update_global_location_list): Use bl_address_is_meaningful
6967 instead of breakpoint_address_is_meaningful.
6968 * breakpoint.h (bp_location::bp_location(breakpoint *)): New
6969 explicit.
6970 (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
6971 * python/py-breakpoint.c (bppy_get_location): No longer check
6972 whether location is null.
6973
6974 2019-07-09 Pedro Alves <palves@redhat.com>
6975
6976 PR c++/15468
6977 * breakpoint.c (print_one_breakpoint_location): Remove
6978 single-location assert.
6979
6980 2019-07-09 Tom Tromey <tom@tromey.com>
6981
6982 * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
6983 * configure: Rebuild.
6984 * configure.ac: Change common to gdbsupport.
6985 * gdbsupport: Rename from common.
6986 * acinclude.m4: Change common to gdbsupport.
6987 * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
6988 (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
6989 gdbsupport.
6990 * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
6991 amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
6992 amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
6993 amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
6994 amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
6995 arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
6996 arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
6997 arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
6998 arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
6999 auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7000 btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7001 charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7002 cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7003 coff-pe-read.c, command.h, compile/compile-c-support.c,
7004 compile/compile-c.h, compile/compile-cplus-symbols.c,
7005 compile/compile-cplus-types.c, compile/compile-cplus.h,
7006 compile/compile-loc2c.c, compile/compile.c, completer.c,
7007 completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7008 cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7009 darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7010 disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7011 dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7012 dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7013 event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7014 features/aarch64-core.c, features/aarch64-fpu.c,
7015 features/aarch64-pauth.c, features/aarch64-sve.c,
7016 features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7017 features/i386/32bit-core.c, features/i386/32bit-linux.c,
7018 features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7019 features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7020 features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7021 features/i386/64bit-core.c, features/i386/64bit-linux.c,
7022 features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7023 features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7024 features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7025 features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7026 features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7027 features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7028 features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7029 findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7030 gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7031 gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7032 go32-nat.c, guile/guile.c, guile/scm-ports.c,
7033 guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7034 i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7035 i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7036 ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7037 inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7038 inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7039 inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7040 linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7041 macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7042 mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7043 mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7044 minsyms.c, mips-linux-tdep.c, namespace.h,
7045 nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7046 nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7047 nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7048 nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7049 nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7050 nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7051 nat/linux-waitpid.c, nat/mips-linux-watch.c,
7052 nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7053 nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7054 nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7055 obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7056 parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7057 procfs.c, producer.c, progspace.h, psymtab.h,
7058 python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7059 python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7060 record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7061 remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7062 riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7063 selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7064 ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7065 source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7066 stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7067 symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7068 target-memory.c, target.c, target.h, target/waitstatus.c,
7069 target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7070 top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7071 tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7072 unittests/array-view-selftests.c,
7073 unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7074 unittests/common-utils-selftests.c,
7075 unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7076 unittests/format_pieces-selftests.c,
7077 unittests/function-view-selftests.c,
7078 unittests/lookup_name_info-selftests.c,
7079 unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7080 unittests/mkdir-recursive-selftests.c,
7081 unittests/observable-selftests.c,
7082 unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7083 unittests/parse-connection-spec-selftests.c,
7084 unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7085 unittests/scoped_fd-selftests.c,
7086 unittests/scoped_mmap-selftests.c,
7087 unittests/scoped_restore-selftests.c,
7088 unittests/string_view-selftests.c, unittests/style-selftests.c,
7089 unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7090 unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7091 utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7092 value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7093 xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7094 xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7095
7096 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7097
7098 * linespec.c (decode_digits_list_mode): Set explicit_line to a
7099 bool value.
7100 (decode_digits_ordinary): Set explicit_line field in sal.
7101 * symtab.c (skip_prologue_sal): Don't skip prologue for a
7102 symtab_and_line that was set on an explicit line number in
7103 assembler code. Do always update the recorded symtab and line if
7104 we do skip the prologue.
7105
7106 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7107
7108 * breakpoint.c (set_breakpoint_location_function): Remove
7109 explicit_loc parameter.
7110 (momentary_breakpoint_from_master): Update call to
7111 set_breakpoint_location_function.
7112 (add_location_to_breakpoint): Likewise.
7113
7114 2019-07-09 Andrew Burgess <andrew.burgess@embecosm.com>
7115
7116 * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7117 required features based on default bfd type when no specific bfd
7118 is present.
7119
7120 2019-07-08 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7121
7122 * NEWS: Mention that GDB printf and eval commands can now print
7123 C-style and Ada-style convenience var strings without
7124 calling the inferior.
7125 * printcmd.c (printf_c_string): Locally print GDB internal var
7126 instead of transiting via the inferior.
7127 (printf_wide_c_string): Likewise.
7128
7129 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7130
7131 PR breakpoints/25011
7132 * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7133
7134 2019-07-04 Tom Tromey <tom@tromey.com>
7135
7136 PR tui/24724:
7137 * tui/tui-winsource.c (tui_clear_source_content): Update.
7138 (tui_source_window_base::set_is_exec_point_at): Fix comment.
7139 (tui_update_breakpoint_info): Update.
7140 (tui_set_exec_info_content): Update.
7141 * tui/tui-source.c (tui_set_source_content_nil): Update.
7142 * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7143 has_break.
7144 * tui/tui-data.h (enum tui_bp_flag): New.
7145 (tui_bp_flags): New enum flags type.
7146 (struct tui_source_element) <break_mode>: Change type. Rename
7147 from has_break.
7148 (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7149 (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define. Now enum
7150 constants.
7151 * tui/tui-winsource.h: Fix comment.
7152
7153 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7154
7155 * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7156 * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7157 (store_fpregs_to_thread)
7158 (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7159 * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7160 (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7161 (IWMMXT_REGS_SIZE): Add define.
7162 * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7163 (fetch_vfp_regs, store_vfp_regs)
7164 (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7165 * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7166
7167 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7168
7169 * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7170 defines.
7171 * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7172 * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7173 (ARM_INT_REGISTER_SIZE): ...to this.
7174 (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7175 * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7176 (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7177 (arm_linux_collect_gregset, supply_nwfpe_register)
7178 (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7179 defines.
7180 * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7181 (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7182 * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7183 * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7184 (arm_return_in_memory, arm_store_return_value)
7185 (arm_get_longjmp_target, arm_register_g_packet_guesses)
7186 (arm_record_ld_st_multiple): Likewise.
7187 * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7188 * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7189
7190 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7191
7192 * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7193 AARCH64_DISPLACED_MODIFIED_INSNS.
7194 * aarch64-tdep.c (struct aarch64_displaced_step_data)
7195 (aarch64_displaced_step_copy_insn): Likewise.
7196 * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7197 (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7198 * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7199 ARM_DISPLACED_MODIFIED_INSNS.
7200 * arm-tdep.c (arm_gdbarch_init): Likewise.
7201 * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7202 (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7203 (struct arm_displaced_step_closure): Use
7204 ARM_DISPLACED_MODIFIED_INSNS.
7205
7206 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7207
7208 * features/Makefile: Remove unused xml files.
7209 * features/aarch64.xml: Remove.
7210 * features/i386/amd64-avx-avx512-linux.xml: Remove.
7211 * features/i386/amd64-avx-avx512.xml: Remove.
7212 * features/i386/amd64-avx-linux.xml: Remove.
7213 * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7214 * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7215 * features/i386/amd64-avx-mpx-linux.xml: Remove.
7216 * features/i386/amd64-avx-mpx.xml: Remove.
7217 * features/i386/amd64-avx.xml: Remove.
7218 * features/i386/amd64-linux.xml: Remove.
7219 * features/i386/amd64-mpx-linux.xml: Remove.
7220 * features/i386/amd64-mpx.xml: Remove.
7221 * features/i386/amd64.xml: Remove.
7222 * features/i386/i386-avx-avx512-linux.xml: Remove.
7223 * features/i386/i386-avx-avx512.xml: Remove.
7224 * features/i386/i386-avx-linux.xml: Remove.
7225 * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7226 * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7227 * features/i386/i386-avx-mpx-linux.xml: Remove.
7228 * features/i386/i386-avx-mpx.xml: Remove.
7229 * features/i386/i386-avx.xml: Remove.
7230 * features/i386/i386-linux.xml: Remove.
7231 * features/i386/i386-mmx-linux.xml: Remove.
7232 * features/i386/i386-mmx.xml: Remove.
7233 * features/i386/i386-mpx-linux.xml: Remove.
7234 * features/i386/i386-mpx.xml: Remove.
7235 * features/i386/i386.xml: Remove.
7236 * features/i386/x32-avx-avx512-linux.xml: Remove.
7237 * features/i386/x32-avx-linux.xml: Remove.
7238 * features/i386/x32-linux.xml: Remove.
7239
7240 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7241
7242 * regformats/aarch64.dat: Remove.
7243 * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7244 * regformats/i386/amd64-avx-linux.dat: Remove.
7245 * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7246 * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7247 * regformats/i386/amd64-linux.dat: Remove.
7248 * regformats/i386/amd64-mpx-linux.dat: Remove.
7249 * regformats/i386/amd64.dat: Remove.
7250 * regformats/i386/i386-avx-avx512-linux.dat: Remove.
7251 * regformats/i386/i386-avx-linux.dat: Remove.
7252 * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
7253 * regformats/i386/i386-avx-mpx-linux.dat: Remove.
7254 * regformats/i386/i386-linux.dat: Remove.
7255 * regformats/i386/i386-mmx-linux.dat: Remove.
7256 * regformats/i386/i386-mpx-linux.dat: Remove.
7257 * regformats/i386/i386.dat: Remove.
7258 * regformats/i386/x32-avx-avx512-linux.dat: Remove.
7259 * regformats/i386/x32-avx-linux.dat: Remove.
7260 * regformats/i386/x32-linux.dat: Remove.
7261
7262 2019-07-04 Alan Hayward <alan.hayward@arm.com>
7263
7264 * aarch64-tdep.c: Remove xml self tests.
7265 * amd64-linux-tdep.c: Likewise.
7266 * amd64-tdep.c: Likewise.
7267 * i386-linux-tdep.c: Likewise.
7268 * i386-tdep.c: Likewise.
7269
7270 2019-07-03 Pedro Alves <palves@redhat.com>
7271
7272 PR cli/24732
7273 * cli/cli-cmds.c (struct pipe_cmd_opts): New.
7274 (pipe_cmd_option_defs): New.
7275 (make_pipe_cmd_options_def_group): New.
7276 (pipe_command): Use gdb::option::process_options.
7277 (pipe_command_completer): New function.
7278 (_initialize_cli_cmds): Install completer for "pipe" command.
7279
7280 2019-07-03 Pedro Alves <palves@redhat.com>
7281
7282 * cli/cli-option.c (union option_value) <string>: New field.
7283 (struct option_def_and_value): Add ctor, move ctor, dtor and
7284 use DISABLE_COPY_AND_ASSIGN.
7285 (option_def_and_value::clear_value): New.
7286 (parse_option, save_option_value_in_ctx, get_val_type_str)
7287 (add_setshow_cmds_for_options): Handle var_string.
7288 * cli-option.h (union option_def::var_address) <string>: New
7289 field.
7290 (struct string_option_def): New.
7291 * maint-test-options.c (struct test_options_opts): Add default
7292 ctor and use DISABLE_COPY_AND_ASSIGN.
7293 <string_opt>: New field.
7294 (test_options_opts::~test_options_opts): New.
7295 (test_options_opts::dump): Also dump "-string".
7296 (test_options_option_defs): Install "string.
7297
7298 2019-07-03 Pedro Alves <palves@redhat.com>
7299
7300 * cli/cli-option.c (parse_option) <var_enum>: Don't return an
7301 option_value with a null enumeration.
7302 (complete_options): Save the option values in the context.
7303 (save_option_value_in_ctx): New, factored out from ...
7304 (process_options): ... here.
7305 * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
7306 of the function.
7307 * maint-test-options.c (test_options_opts::dump): New, factored
7308 out from ...
7309 (maintenance_test_options_command_mode): ... here.
7310 (maintenance_test_options_command_completion_result): Delete.
7311 (maintenance_test_options_command_completion_text): Update
7312 comment.
7313 (maintenance_show_test_options_completion_result): Change
7314 prototype. Just print
7315 maintenance_test_options_command_completion_text.
7316 (save_completion_result): New.
7317 (maintenance_test_options_completer_mode): Pass options context to
7318 complete_options, and then save a dump.
7319 (_initialize_maint_test_options): Use add_cmd to install "maint
7320 show test-options-completion-result".
7321
7322 2019-07-03 Pedro Alves <palves@redhat.com>
7323
7324 * NEWS (New commands): Mention "with" and "maint with".
7325 * cli/cli-cmds.c (with_command_1, with_command_completer_1)
7326 (with_command, with_command_completer): New.
7327 (pipe_command): Adjust to new repeat_previous
7328 interface.
7329 (_initialize_cli_cmds): Install the "with" command and its "w"
7330 alias.
7331 * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
7332 declarations.
7333 * cli/cli-setshow.c (parse_cli_var_uinteger)
7334 (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
7335 argument strings for all var_types.
7336 (get_setshow_command_value_string): New, factored out from ...
7337 (do_show_command): ... this.
7338 * cli/cli-setshow.h: Include <string>.
7339 (get_setshow_command_value_string): Declare.
7340 * command.h (repeat_previous): Now returns const char *. Adjust
7341 comment.
7342 * maint.c: Include "cli/cli-cmds.h".
7343 (maintenance_with_cmd, maintenance_with_cmd_completer): New.
7344 (_initialize_maint_cmds): Register the "maintenance with" command.
7345 * top.c (repeat_previous): Move bits from pipe_command here:
7346 Return the saved command line, if any; error out if there's no
7347 command to relaunch.
7348
7349 2019-07-03 Pedro Alves <palves@redhat.com>
7350
7351 * NEWS (New commands): Mention "maint set/show test-settings"
7352 instead of "maint test-settings".
7353 * maint-test-settings.c (maintenance_test_settings_list): Delete.
7354 (maintenance_test_settings_set_list): Rename to ...
7355 (maintenance_set_test_settings_list): ... this.
7356 (maintenance_test_settings_show_list): Rename to ...
7357 (maintenance_show_test_settings_list): ... this.
7358 (maintenance_test_settings_cmd): Delete.
7359 (maintenance_test_settings_set_cmd): ...
7360 (maintenance_set_test_settings_cmd): ... this.
7361 (maintenance_test_settings_show_cmd): ...
7362 (maintenance_show_test_settings_cmd): ... this.
7363 (maintenance_test_settings_show_value_cmd):
7364 (maintenance_show_test_settings_value_cmd): ... this.
7365 (_initialize_maint_test_settings): No longer install the "maint
7366 test-settings" prefix command. Rename "maint test-settings set"
7367 to "maint set test-settings", and "maint test-settings show" to
7368 "maint show test-settings". Adjust all subcommands.
7369
7370 2019-07-03 Pedro Alves <palves@redhat.com>
7371
7372 * maint-test-settings.c: Fix file's intro comment. Replace all
7373 references to "test-options" with references to "test-settings",
7374 in comments.
7375
7376 2019-07-03 Pedro Alves <palves@redhat.com>
7377
7378 * maint-test-settings.c (maintenance_test_settings_xxx)
7379 (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
7380 New.
7381 (maintenance_test_settings_enums): Use them.
7382 (maintenance_test_settings_enum): Default to
7383 maintenance_test_settings_xxx.
7384 (_initialize_maint_test_settings): Initialize
7385 MAINTENANCE_TEST_SETTINGS_FILENAME.
7386
7387 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7388
7389 * breakpoint.h (remove_breakpoints_inf): Change return type to
7390 void, move function documentation here.
7391 * breakpoint.c (remove_breakpoints_inf): Change return type to
7392 void, move function documentation to header.
7393
7394 2019-07-02 Pedro Alves <palves@redhat.com>
7395
7396 * NEWS (Completion improvements): Mention "info threads".
7397 * thread.c (struct info_threads_opts, info_threads_option_defs)
7398 (make_info_threads_options_def_group): New.
7399 (info_threads_command): Use gdb::option::process_options.
7400 (info_threads_command_completer): New.
7401 (_initialize_thread): Use gdb::option::build_help to build the
7402 help text for "info threads".
7403
7404 2019-07-02 Simon Marchi <simon.marchi@polymtl.ca>
7405
7406 * defs.h (generic_load): Move from here...
7407 * symfile.h (generic_load): ... to here. Rename name parameter
7408 to args.
7409 * symfile.c (generic_load): Add comment.
7410
7411 2019-07-01 Tom Tromey <tromey@adacore.com>
7412
7413 * dwarf2read.c
7414 (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
7415 declaration of without_params. Fix formatting.
7416
7417 2019-07-01 Tom Tromey <tromey@adacore.com>
7418
7419 * ada-exp.y (find_primitive_type): Update.
7420 * ada-lang.h (ada_lookup_symbol): Update.
7421 * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
7422 parameter.
7423 (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
7424
7425 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7426
7427 PR breakpoints/24541
7428 * gdbarch.c: Regenerate.
7429 * gdbarch.h: Regenerate.
7430 * gdbarch.sh: Add 'stap_adjust_register'.
7431 * i386-tdep.c: Include '<unordered_set>'.
7432 (i386_stap_adjust_register): New function.
7433 (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
7434 * stap-probe.c (stap_parse_register_operand): Call
7435 'gdbarch_stap_adjust_register'.
7436
7437 2019-06-28 Sergio Durigan Junior <sergiodj@redhat.com>
7438
7439 PR python/24742
7440 https://bugzilla.redhat.com/show_bug.cgi?id=1723564
7441 * python/python.c (do_start_initialization): Use 'xmalloc'
7442 instead of 'PyMem_Malloc'.
7443
7444 2019-06-28 Tom Tromey <tromey@adacore.com>
7445
7446 * dwarf2read.c (partial_die_info::read): Prefer the linkage name
7447 for Ada.
7448
7449 2019-06-27 Tom Tromey <tromey@adacore.com>
7450
7451 * arm-tdep.c (arm_objfile_data_key): Move lower. Change type to
7452 objfile_key.
7453 (arm_find_mapping_symbol, arm_record_special_symbol)
7454 (_initialize_arm_tdep): Update.
7455 (arm_objfile_data_free): Remove.
7456
7457 2019-06-27 Tom Tromey <tromey@adacore.com>
7458
7459 * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
7460 to cp_print_static_field.
7461
7462 2019-06-26 Tom Tromey <tromey@adacore.com>
7463
7464 * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
7465 * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
7466 declare.
7467
7468 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7469
7470 * features/aarch64-core.c (create_feature_aarch64_core):
7471 Regenerate.
7472 * features/aarch64-core.xml: Add cpsr flags.
7473
7474 2019-06-26 Alan Hayward <alan.hayward@arm.com>
7475
7476 * arm-tdep.c (arm_gnu_triplet_regexp): New function.
7477 (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
7478
7479 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7480
7481 * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
7482 field.
7483 (arm_find_mapping_symbol): Sort mapping symbol vectors on first
7484 use.
7485 (arm_record_special_symbol): Don't insert new symbol in sorted
7486 position, push it at the end.
7487
7488 2019-06-25 Simon Marchi <simon.marchi@polymtl.ca>
7489
7490 * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
7491 (arm_mapping_symbol_s): Remove.
7492 (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
7493 (arm_mapping_symbol_vec): New typedef.
7494 (struct arm_per_objfile): Add constructor.
7495 <section_maps>: Change type to
7496 std::unique_ptr<arm_mapping_symbol_vec[]>.
7497 (arm_compare_mapping_symbols): Remove.
7498 (arm_find_mapping_symbol): Adjust to section_maps type change.
7499 (arm_objfile_data_free): Call delete on arm_per_objfile.
7500 (arm_record_special_symbol): Adjust to section_maps type change.
7501 Allocate arm_per_objfile with new.
7502
7503 2019-06-25 Philippe Waroquiers <philippe.waroquiers@skynet.be>
7504
7505 * cli/cli-cmds.c (alias_command): Compare the alias prefix
7506 with the command prefix.
7507
7508 2019-06-25 Tom Tromey <tom@tromey.com>
7509
7510 * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
7511 * tui/tui-data.c (~tui_gen_win_info): Remove "if".
7512
7513 2019-06-25 Tom Tromey <tom@tromey.com>
7514
7515 * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
7516 type.
7517 * tui/tui-data.h (struct tui_gen_win_info): Make constructor
7518 protected.
7519
7520 2019-06-25 Tom Tromey <tom@tromey.com>
7521
7522 * tui/tui-winsource.c
7523 (tui_source_window_base::set_is_exec_point_at): Add check against
7524 LOA_ADDRESS.
7525
7526 2019-06-25 Tom Tromey <tom@tromey.com>
7527
7528 * tui/tui-source.c (tui_set_source_content): Don't check before
7529 xfree.
7530 * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
7531
7532 2019-06-25 Tom Tromey <tom@tromey.com>
7533
7534 * tui/tui-winsource.h (tui_update_source_window_as_is)
7535 (tui_alloc_source_buffer, tui_line_is_displayed)
7536 (tui_addr_is_displayed): Change type of win_info.
7537 * tui/tui-winsource.c (tui_update_source_window_as_is)
7538 (tui_clear_source_content, tui_show_source_line)
7539 (tui_show_source_content, tui_source_window_base::refill)
7540 (tui_source_window_base::set_is_exec_point_at)
7541 (tui_source_window_base::set_is_exec_point_at)
7542 (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
7543 (tui_alloc_source_buffer, tui_line_is_displayed)
7544 (tui_addr_is_displayed): Change type of win_info. Update.
7545 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7546 (tui_source_window_base::do_make_visible_with_new_height):
7547 Update.
7548 * tui/tui-source.c (tui_set_source_content)
7549 (tui_set_source_content_nil)
7550 (tui_source_window::do_scroll_vertical): Update.
7551 * tui/tui-layout.c (show_layout): Update.
7552 * tui/tui-disasm.c (tui_set_disassem_content)
7553 (tui_disasm_window::do_scroll_vertical): Update.
7554 * tui/tui-data.h (tui_win_content): Remove.
7555 (struct tui_gen_win_info) <content, content_size>: Remove.
7556 (struct tui_source_element): Add initializers and destructor.
7557 (union tui_which_element, struct tui_win_element): Remove.
7558 (struct tui_source_window_base) <content>: New field.
7559 (struct tui_data_window): Remove destructor.
7560 (tui_alloc_content, tui_free_win_content)
7561 (tui_free_all_source_wins_content): Don't declare.
7562 * tui/tui-data.c (tui_initialize_static_data): Update.
7563 (init_content_element, tui_alloc_content): Remove.
7564 (~tui_gen_win_info): Update.
7565 (~tui_data_window, tui_free_all_source_wins_content)
7566 (tui_free_win_content, free_content, free_content_elements):
7567 Remove.
7568
7569 2019-06-25 Tom Tromey <tom@tromey.com>
7570
7571 * tui/tui-winsource.h (tui_clear_source_content)
7572 (tui_erase_source_content, tui_show_source_content): Change type
7573 of win_info.
7574 * tui/tui-winsource.c (tui_clear_source_content)
7575 (tui_erase_source_content, tui_show_source_content): Change type
7576 of win_info.
7577 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7578 * tui/tui-source.h (tui_set_source_content_nil): Change type of
7579 win_info.
7580 * tui/tui-source.c (tui_set_source_content_nil): Change type of
7581 win_info.
7582 * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
7583
7584 2019-06-25 Tom Tromey <tom@tromey.com>
7585
7586 * tui/tui-winsource.c (tui_clear_source_content)
7587 (tui_source_window_base::set_is_exec_point_at): Update.
7588 * tui/tui-source.c (tui_set_source_content_nil): Update.
7589 * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
7590 a bool.
7591 * tui/tui-data.c (init_content_element): Update.
7592
7593 2019-06-25 Tom Tromey <tom@tromey.com>
7594
7595 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
7596 * tui/tui-win.c (make_invisible_and_set_new_height): Update.
7597 * tui/tui-layout.c (init_and_make_win): Update.
7598 * tui/tui.h (enum tui_win_type): Update.
7599 * tui/tui-data.h (tui_win_is_auxiliary): Rename from
7600 tui_win_is_auxillary.
7601 * tui/tui-data.c (tui_win_is_auxiliary): Rename from
7602 tui_win_is_auxillary.
7603
7604 2019-06-25 Tom Tromey <tom@tromey.com>
7605
7606 * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
7607 * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
7608 (tui_delete_data_content_windows, tui_display_all_data)
7609 (tui_data_window::do_scroll_vertical, tui_display_data_from):
7610 Update.
7611 * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
7612 * tui/tui-regs.c (tui_last_regs_line_no)
7613 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
7614 (tui_show_registers): Update.
7615 (tui_show_register_group): Return void. Update.
7616 (tui_display_registers_from, tui_display_reg_element_at_line)
7617 (tui_display_registers_from_line, tui_check_register_values):
7618 Update.
7619 * tui/tui-data.h (union tui_which_element) <data_window>: Remove
7620 member.
7621 (struct tui_data_window) <regs_content>: Now a std::vector.
7622 <regs_content_count>: Remove.
7623 (tui_add_content_elements, tui_free_data_content): Don't declare.
7624 * tui/tui-data.c (tui_data_window::clear_detail): Update.
7625 (init_content_element): Remove DATA_WIN case. Add assert.
7626 (tui_add_content_elements): Remove.
7627 (tui_data_window): Update.
7628 (tui_free_data_content): Remove.
7629 (free_content_elements): Remove DATA_WIN case.
7630
7631 2019-06-25 Tom Tromey <tom@tromey.com>
7632
7633 * tui/tui-data.c (tui_data_item_window): Update.
7634 * tui/tui-windata.h (tui_check_data_values): Don't declare.
7635 * tui/tui-windata.c (tui_display_all_data)
7636 (tui_display_data_from_line): Update.
7637 (tui_check_data_values): Remove.
7638 * tui/tui-regs.c (tui_show_register_group)
7639 (tui_display_reg_element_at_line): Update.
7640 * tui/tui-hooks.c (tui_register_changed)
7641 (tui_refresh_frame_and_register_information): Call
7642 tui_check_register_values.
7643 * tui/tui-data.h (struct tui_data_window) <data_content,
7644 data_content_count, data_type>: Remove.
7645 (enum tui_data_type): Remove.
7646
7647 * tui/tui-data.c (tui_data_window::clear_detail)
7648 (~tui_data_window): Update.
7649
7650 2019-06-25 Tom Tromey <tom@tromey.com>
7651
7652 * tui/tui-windata.h (tui_first_data_item_displayed): Don't
7653 declare.
7654 * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
7655 Rename from tui_first_data_item_displayed. Update.
7656 (tui_data_window::refresh_all)
7657 (tui_data_window::do_scroll_vertical): Update.
7658 * tui/tui-data.h (struct tui_data_window)
7659 <first_data_item_displayed>: Declare new method.
7660
7661 2019-06-25 Tom Tromey <tom@tromey.com>
7662
7663 * tui/tui-data.h (tui_init_generic_part): Don't declare.
7664 * tui/tui-data.c (tui_init_generic_part): Remove, moving
7665 contents...
7666 (tui_initialize_static_data): ...here.
7667
7668 2019-06-25 Tom Tromey <tom@tromey.com>
7669
7670 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7671 (tui_display_registers_from, tui_check_register_values): Update.
7672 (tui_display_register): Remove win_info parameter; update.
7673 (tui_get_register): Change type of parameters.
7674 * tui/tui-data.h (struct tui_data_element): Remove.
7675 (union tui_which_element) <data>: Remove.
7676 <data_window>: Change type.
7677 (struct tui_data_item_window): New.
7678 * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
7679 case. Add assert.
7680 (~tui_data_item_window): New destructor.
7681 (free_content_elements): Remove DATA_ITEM_WIN case.
7682
7683 2019-06-25 Tom Tromey <tom@tromey.com>
7684
7685 * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
7686 Remove.
7687
7688 2019-06-25 Tom Tromey <tom@tromey.com>
7689
7690 * tui/tui-data.h (struct tui_command_element): Remove.
7691 (union tui_which_element) <command>: Remove.
7692 * tui/tui-data.c (init_content_element): Remove CMD_WIN case. Add
7693 assert.
7694 (free_content_elements): Remove CMD_WIN case.
7695
7696 2019-06-25 Tom Tromey <tom@tromey.com>
7697
7698 * tui/tui-layout.c (tui_set_layout): Update.
7699 * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
7700 * tui/tui-data.c (layout_def): Update.
7701
7702 2019-06-25 Tom Tromey <tom@tromey.com>
7703
7704 * tui/tui-wingeneral.c (tui_refresh_all): Update.
7705 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
7706 (tui_source_window_base::set_new_height): Update.
7707 * tui/tui-stack.c (tui_make_status_line): Change parameter type.
7708 Update.
7709 (tui_set_locator_fullname, tui_set_locator_info)
7710 (tui_show_frame_info): Update.
7711 * tui/tui-source.c (tui_set_source_content)
7712 (tui_source_is_displayed): Update.
7713 * tui/tui-layout.c (show_source_disasm_command, show_data)
7714 (show_source_or_disasm_and_command): Update.
7715 * tui/tui-disasm.c (tui_set_disassem_content)
7716 (tui_get_begin_asm_address): Update.
7717 * tui/tui-data.h (struct tui_locator_element): Remove.
7718 (union tui_which_element) <locator>: Remove.
7719 (struct tui_locator_window): New.
7720 (tui_locator_win_info_ptr): Change return type.
7721 * tui/tui-data.c (_locator): Change type.
7722 (tui_locator_win_info_ptr): Change return type.
7723 (init_content_element): Remove LOCATOR_WIN case. Add assert.
7724 (tui_alloc_content): Add assert.
7725
7726 2019-06-25 Tom Tromey <tom@tromey.com>
7727
7728 * tui/tui-winsource.c
7729 (tui_exec_info_window::maybe_allocate_content): New method.
7730 (tui_set_exec_info_content, tui_show_exec_info_content): Update.
7731 * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
7732 (make_source_or_disasm_window): Add cast.
7733 * tui/tui-data.h (union tui_which_element) <simple_string>:
7734 Remove.
7735 (struct tui_source_info): New.
7736 (struct tui_source_window_base) <execution_info>: Change type.
7737 * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
7738 case, and add assert.
7739 (tui_alloc_content): Add assert.
7740
7741 2019-06-25 Tom Tromey <tom@tromey.com>
7742
7743 * tui/tui-data.h (tui_alloc_win_info): Don't declare.
7744 * tui/tui-layout.c (init_and_make_win): Use "new" directly.
7745 * tui/tui-data.c (tui_alloc_win_info): Remove.
7746
7747 2019-06-25 Tom Tromey <tom@tromey.com>
7748
7749 * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
7750 * tui/tui-wingeneral.c (tui_unhighlight_win): Check
7751 can_highlight.
7752
7753 2019-06-25 Tom Tromey <tom@tromey.com>
7754
7755 * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
7756 make_visible_with_new_height method.
7757 (tui_win_info::make_visible_with_new_height): New method.
7758 (tui_source_window_base::do_make_visible_with_new_height)
7759 (tui_data_window::do_make_visible_with_new_height)
7760 (tui_cmd_window::do_make_visible_with_new_height): New methods.
7761 (make_visible_with_new_height): Remove.
7762 (tui_resize_all, tui_adjust_win_heights): Use
7763 make_visible_with_new_height method.
7764 * tui/tui-data.h (struct tui_win_info)
7765 <do_make_visible_with_new_height, make_visible_with_new_height>:
7766 New methods.
7767 (struct tui_source_window_base, struct tui_data_window)
7768 (struct tui_cmd_window) <do_make_visible_with_new_height>: New
7769 methods.
7770
7771 2019-06-25 Tom Tromey <tom@tromey.com>
7772
7773 * tui/tui-win.c (tui_source_window_base::update_tab_width): New
7774 method.
7775 (update_tab_width): Call update_tab_width method.
7776 * tui/tui-data.h (struct tui_win_info)
7777 (struct tui_source_window_base) <update_tab_width>: New methods.
7778
7779 2019-06-25 Tom Tromey <tom@tromey.com>
7780
7781 * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
7782 parameter.
7783 * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
7784 parameter.
7785 (tui_gen_win_info::make_visible): Update.
7786 * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
7787 parameter.
7788 * tui/tui-data.h (enum tui_box): New enum.
7789 (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
7790
7791 2019-06-25 Tom Tromey <tom@tromey.com>
7792
7793 * tui/tui-layout.c (make_source_or_disasm_window): Always use
7794 init_and_make_win for EXEC_INFO_WIN.
7795 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
7796 longer inline.
7797 (struct tui_win_info) <~tui_win_info>: Inline.
7798 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7799 Don't declare.
7800 * tui/tui-data.c (source_win, disasm_win): Remove globals.
7801 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7802 Remove.
7803 (tui_initialize_static_data): Update.
7804 (~tui_gen_win_info): Handle more cleanup here.
7805 (~tui_source_window_base): Delete "execution_info".
7806 (~tui_win_info): Move code to ~tui_gen_win_info; remove.
7807
7808 2019-06-25 Tom Tromey <tom@tromey.com>
7809
7810 * tui/tui-layout.c (make_command_window): Don't set
7811 can_highlight.
7812 (show_source_disasm_command): Call the reset method.
7813 (show_data): Don't set can_highlight. Call the reset method.
7814 (tui_gen_win_info::reset): Rename from init_gen_win_info
7815 (init_and_make_win): Simplify. Return tui_gen_win_info.
7816 (show_source_or_disasm_and_command): Call the reset method.
7817 * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
7818 (struct tui_cmd_window): Set can_highlight.
7819
7820 2019-06-25 Tom Tromey <tom@tromey.com>
7821
7822 * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
7823 from make_visible.
7824 (tui_make_visible, tui_make_invisible): Rewrite.
7825 (tui_win_info::make_visible): Remove.
7826 (tui_source_window_base::make_visible): Update.
7827 * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
7828 method. Moved from...
7829 (struct tui_win_info) <make_visible>: ...here.
7830
7831 2019-06-25 Tom Tromey <tom@tromey.com>
7832
7833 * tui/tui-winsource.c
7834 (tui_source_window_base::do_scroll_horizontal): Remove direction
7835 parameter.
7836 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
7837 direction parameter.
7838 * tui/tui-win.c (tui_win_info::forward_scroll)
7839 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
7840 (tui_win_info::right_scroll): Update.
7841 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
7842 direction parameter.
7843 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
7844 direction parameter.
7845 * tui/tui-data.h (enum tui_scroll_direction): Remove.
7846 (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
7847 Remove direction parameter.
7848 (struct tui_source_window_base, struct tui_source_window)
7849 (struct tui_disasm_window, struct tui_data_window)
7850 (struct tui_cmd_window): Update.
7851
7852 2019-06-25 Tom Tromey <tom@tromey.com>
7853
7854 * tui/tui-winsource.h (tui_set_exec_info_content)
7855 (tui_show_exec_info_content, tui_erase_exec_info_content)
7856 (tui_clear_exec_info_content, tui_update_exec_info): Change
7857 argument to tui_source_window_base.
7858 * tui/tui-winsource.c (tui_set_exec_info_content)
7859 (tui_show_exec_info_content, tui_erase_exec_info_content)
7860 (tui_clear_exec_info_content, tui_update_exec_info): Change
7861 argument to tui_source_window_base.
7862
7863 2019-06-25 Tom Tromey <tom@tromey.com>
7864
7865 * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
7866 * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
7867
7868 2019-06-25 Tom Tromey <tom@tromey.com>
7869
7870 * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
7871 check.
7872
7873 2019-06-25 Tom Tromey <tom@tromey.com>
7874
7875 * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
7876 type to void.
7877 * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
7878 type to void.
7879 * tui/tui-source.c (tui_set_source_content): Update.
7880 * tui/tui-disasm.c (tui_set_disassem_content): Update.
7881
7882 2019-06-25 Tom Tromey <tom@tromey.com>
7883
7884 * tui/tui-win.c (window_name_completer, tui_set_focus)
7885 (tui_all_windows_info): Use name method.
7886 * tui/tui-data.h (struct tui_gen_win_info)
7887 (struct tui_source_window, struct tui_disasm_window)
7888 (struct tui_data_window, struct tui_cmd_window) <name>: New
7889 method.
7890 (tui_win_name): Don't declare.
7891 * tui/tui-data.c (tui_partial_win_by_name): Use name method.
7892 (tui_win_name): Remove.
7893
7894 2019-06-25 Tom Tromey <tom@tromey.com>
7895
7896 * tui/tui-winsource.h (tui_update_source_window)
7897 (tui_update_source_window_as_is): Change parameter type.
7898 * tui/tui-winsource.c (tui_update_source_window): Change win_info
7899 to be a tui_source_window_base.
7900 (tui_update_source_window_as_is): Likewise.
7901 * tui/tui-win.c (make_visible_with_new_height): Update.
7902
7903 2019-06-25 Tom Tromey <tom@tromey.com>
7904
7905 * tui/tui-winsource.c (tui_erase_source_content)
7906 (tui_show_source_content, tui_show_exec_info_content)
7907 (tui_erase_exec_info_content): Use refresh_window method.
7908 * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
7909 * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
7910 from tui_refresh_win.
7911 (tui_data_window::refresh_window): New method.
7912 (tui_win_info::refresh, tui_source_window_base::refresh)
7913 (tui_refresh_all): Use refresh_window method.
7914 * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
7915 method.
7916 * tui/tui-regs.c (tui_display_register): Call refresh_window
7917 method.
7918 * tui/tui-layout.c (show_source_disasm_command)
7919 (show_source_or_disasm_and_command): Call refresh_window method.
7920 * tui/tui-data.h (struct tui_gen_win_info)
7921 (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
7922 New method.
7923
7924 2019-06-25 Tom Tromey <tom@tromey.com>
7925
7926 * tui/tui.c (tui_rl_other_window, tui_enable)
7927 (tui_is_window_visible, tui_get_command_dimension): Update.
7928 * tui/tui-winsource.c (tui_update_source_window_as_is)
7929 (tui_clear_source_content, tui_erase_source_content)
7930 (tui_show_source_line, tui_source_window_base::refill)
7931 (tui_source_window_base::do_scroll_horizontal)
7932 (tui_source_window_base::set_is_exec_point_at)
7933 (tui_update_breakpoint_info, tui_set_exec_info_content)
7934 (tui_alloc_source_buffer, tui_line_is_displayed)
7935 (tui_addr_is_displayed): Update.
7936 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
7937 (tui_check_and_display_highlight_if_needed)
7938 (tui_win_info::make_visible, tui_win_info::refresh)
7939 (tui_refresh_all): Update.
7940 * tui/tui-windata.c (tui_first_data_item_displayed)
7941 (tui_delete_data_content_windows, tui_erase_data_content)
7942 (tui_display_all_data, tui_data_window::refresh_all)
7943 (tui_check_data_values): Update.
7944 * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
7945 (tui_set_win_focus_to, tui_win_info::forward_scroll)
7946 (tui_win_info::backward_scroll, tui_refresh_all_win)
7947 (tui_resize_all, tui_set_focus, tui_all_windows_info)
7948 (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
7949 (tui_source_window_base::set_new_height)
7950 (tui_data_window::set_new_height)
7951 (make_invisible_and_set_new_height)
7952 (make_visible_with_new_height, new_height_ok)
7953 (parse_scrolling_args): Update.
7954 * tui/tui-stack.c (tui_show_frame_info): Update.
7955 * tui/tui-source.c (tui_set_source_content)
7956 (tui_set_source_content_nil, tui_source_is_displayed)
7957 (tui_source_window::do_scroll_vertical): Update.
7958 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
7959 (tui_display_registers_from, tui_display_reg_element_at_line)
7960 (tui_check_register_values, tui_reg_command): Update.
7961 * tui/tui-layout.c (tui_default_win_height)
7962 (show_source_disasm_command, show_data, init_and_make_win)
7963 (show_source_or_disasm_and_command): Update.
7964 * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
7965 (tui_redisplay_readline, tui_mld_flush)
7966 (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
7967 (tui_getc): Update.
7968 * tui/tui-disasm.c (tui_set_disassem_content)
7969 (tui_disasm_window::do_scroll_vertical): Update.
7970 * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
7971 Now virtual.
7972 (struct tui_win_info): Derive from tui_gen_win_info.
7973 <~tui_win_info>: Mark as override.
7974 <generic>: Remove member.
7975 * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
7976 (tui_prev_win, tui_partial_win_by_name, tui_win_info)
7977 (~tui_data_window, ~tui_win_info)
7978 (tui_free_all_source_wins_content): Update.
7979 * tui/tui-command.c (tui_refresh_cmd_win): Update.
7980
7981 2019-06-25 Tom Tromey <tom@tromey.com>
7982
7983 * tui/tui-layout.c (init_and_make_win): Use new.
7984 * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
7985 destructor, initializers.
7986 (tui_alloc_generic_win_info): Don't declare.
7987 * tui/tui-data.c (_locator): Add argument to constructor.
7988 (source_win, disasm_win): New globals.
7989 (exec_info): Remove.
7990 (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
7991 Update.
7992 (tui_alloc_generic_win_info): Remove.
7993 (init_content_element): Use new.
7994 (tui_win_info::tui_win_info): Update.
7995 (free_content_elements) <case DATA_WIN>: Use delete.
7996
7997 2019-06-25 Tom Tromey <tom@tromey.com>
7998
7999 * tui/tui-wingeneral.c (tui_refresh_win): Update.
8000 * tui/tui-windata.c (tui_first_data_item_displayed)
8001 (tui_delete_data_content_windows): Update.
8002 * tui/tui-win.c (tui_data_window::set_new_height): Update.
8003 * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8004 (tui_display_registers_from, tui_check_register_values): Update.
8005 * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8006 pointer.
8007 * tui/tui-data.c (init_content_element): Update. Allocate the new
8008 window.
8009 (tui_free_data_content): Update.
8010 (free_content_elements) <case DATA_WIN>: Free the window.
8011
8012 2019-06-25 Tom Tromey <tom@tromey.com>
8013
8014 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8015 Update.
8016 * tui/tui-layout.c (make_command_window)
8017 (show_source_disasm_command, show_data, init_and_make_win)
8018 (show_source_or_disasm_and_command): Update.
8019 * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8020 method.
8021 <can_highight, is_highlighted>: Now bool.
8022 (tui_set_win_highlight): Don't declare.
8023 * tui/tui-data.c (tui_set_win_highlight): Remove.
8024
8025 2019-06-25 Tom Tromey <tom@tromey.com>
8026
8027 * tui/tui-wingeneral.c (make_visible): Remove check of window
8028 type.
8029
8030 2019-06-25 Tom Tromey <tom@tromey.com>
8031
8032 * tui/tui-win.c (tui_win_info::max_height)
8033 (tui_cmd_window::max_height): New methods.
8034 (new_height_ok): Call max_height.
8035 * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8036 <max_height>: New method.
8037
8038 2019-06-25 Tom Tromey <tom@tromey.com>
8039
8040 * tui/tui-win.c (tui_source_window_base::set_new_height)
8041 (tui_data_window::set_new_height): New methods.
8042 (make_invisible_and_set_new_height): Call set_new_height method.
8043 * tui/tui-data.h (struct tui_win_info)
8044 (struct tui_source_window_base, struct tui_data_window)
8045 <set_new_height>: New method.
8046
8047 2019-06-25 Tom Tromey <tom@tromey.com>
8048
8049 * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8050 * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8051 tui_refresh_data_win.
8052 * tui/tui-win.c (tui_source_window_base::refresh_all): New
8053 method.
8054 (tui_refresh_all_win): Call the refresh_all method.
8055 (tui_set_focus): Likewise.
8056 * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8057 (struct tui_source_window_base, struct tui_data_window) <refresh>:
8058 Likewise.
8059
8060 2019-06-25 Tom Tromey <tom@tromey.com>
8061
8062 * tui/tui-winsource.h (tui_refill_source_window)
8063 (tui_set_is_exec_point_at): Don't declare.
8064 * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8065 (tui_source_window_base::refill): Rename from
8066 tui_refill_source_window.
8067 (tui_source_window_base::do_scroll_horizontal): Update.
8068 (tui_source_window_base::set_is_exec_point_at): Rename from
8069 tui_set_is_exec_point_at.
8070 (tui_update_all_breakpoint_info): Update.
8071 * tui/tui-stack.c (tui_show_frame_info): Update.
8072 * tui/tui-layout.c (show_data): Add cast.
8073 * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8074 * tui/tui-data.h (struct tui_source_window_base) <refill,
8075 set_is_exec_point_at>: New methods.
8076 (tui_source_windows, tui_add_to_source_windows): Update types.
8077 (tui_add_to_source_windows): Remove redundant declaration.
8078 * tui/tui-data.c (source_windows): Store tui_source_window_base.
8079 (tui_source_windows): Change return type.
8080 (tui_clear_source_windows_detail): Update.
8081 (tui_add_to_source_windows): Change type of parameter.
8082 (tui_free_all_source_wins_content): Update.
8083
8084 2019-06-25 Tom Tromey <tom@tromey.com>
8085
8086 * tui/tui-wingeneral.c (tui_win_info::refresh)
8087 (tui_source_window_base::refresh): New methods.
8088 (tui_refresh_all): Call the refresh method.
8089 * tui/tui-data.h (struct tui_win_info)
8090 (struct tui_source_window_base) <refresh>: New method.
8091
8092 2019-06-25 Tom Tromey <tom@tromey.com>
8093
8094 * tui/tui.h (tui_is_window_visible): Return bool.
8095 * tui/tui.c (tui_is_window_visible): Return bool.
8096 * tui/tui-wingeneral.c (tui_make_window, make_visible)
8097 (tui_make_visible, tui_make_invisible)
8098 (tui_win_info::make_visible)
8099 (tui_source_window_base::make_visible, make_all_visible)
8100 (tui_make_all_visible, tui_make_all_invisible): Update.
8101 * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8102 * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8103 bool.
8104 (struct tui_win_info, struct tui_source_window_base)
8105 (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8106 * tui/tui-data.c (tui_init_generic_part): Update.
8107
8108 2019-06-25 Tom Tromey <tom@tromey.com>
8109
8110 * tui/tui-wingeneral.c (tui_win_info::make_visible)
8111 (tui_source_window_base::make_visible): New methods.
8112 (make_all_visible): Make method call.
8113 * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8114 (struct tui_source_window_base, struct tui_cmd_window): Override
8115 make_visible.
8116 (tui_win_is_source_type): Don't declare.
8117 * tui/tui-data.c (tui_win_is_source_type): Remove.
8118
8119 2019-06-25 Tom Tromey <tom@tromey.com>
8120
8121 * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8122 NULL check.
8123
8124 2019-06-25 Tom Tromey <tom@tromey.com>
8125
8126 * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8127 Inline constructor. Add initializers for members.
8128 * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8129 constructors; now inline in class.
8130
8131 2019-06-25 Tom Tromey <tom@tromey.com>
8132
8133 * tui/tui-regs.c (tui_show_registers): Update.
8134 * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8135 bool.
8136 * tui/tui-data.c (tui_data_window::clear_detail)
8137 (tui_data_window): Update.
8138
8139 2019-06-25 Tom Tromey <tom@tromey.com>
8140
8141 * tui/tui-windata.c (tui_display_all_data)
8142 (tui_display_data_from_line, tui_display_data_from)
8143 (tui_check_data_values, tui_data_window::do_scroll_vertical):
8144 Update.
8145 * tui/tui-regs.c (tui_last_regs_line_no)
8146 (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8147 (tui_show_registers, tui_show_register_group)
8148 (tui_display_registers_from, tui_display_reg_element_at_line)
8149 (tui_display_registers_from_line, tui_check_register_values)
8150 (tui_reg_next, tui_reg_prev): Update.
8151 * tui/tui-layout.c (tui_set_layout, show_data): Update.
8152 * tui/tui-data.h (struct tui_data_info): Remove. Move contents to
8153 tui_data_window.
8154 (struct tui_win_info) <detail>: Remove. Add new fields from
8155 tui_data_info.
8156 (TUI_DATA_WIN): Add cast.
8157 * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8158 (~tui_data_window): Simplify.
8159
8160 2019-06-25 Tom Tromey <tom@tromey.com>
8161
8162 * tui/tui-layout.c (show_source_disasm_command)
8163 (show_source_or_disasm_and_command): Update.
8164 * tui/tui-io.c (update_cmdwin_start_line)
8165 (tui_redisplay_readline): Update.
8166 * tui/tui-data.h (struct tui_command_info): Remove.
8167 (struct tui_win_info) <detail>: Remove command_info member.
8168 (struct tui_data_window) <start_line>: New member, from
8169 tui_command_info.
8170 (TUI_CMD_WIN): Add casts.
8171
8172 2019-06-25 Tom Tromey <tom@tromey.com>
8173
8174 * tui/tui-winsource.c (tui_update_source_window)
8175 (tui_refill_source_window)
8176 (tui_source_window_base::do_scroll_horizontal)
8177 (tui_update_breakpoint_info, tui_set_exec_info_content)
8178 (tui_show_exec_info_content, tui_erase_exec_info_content)
8179 (tui_clear_exec_info_content): Update.
8180 * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8181 Update.
8182 * tui/tui-win.c (make_invisible_and_set_new_height)
8183 (make_visible_with_new_height): Update.
8184 * tui/tui-source.c (tui_set_source_content)
8185 (tui_show_symtab_source): Update.
8186 * tui/tui-layout.c (extract_display_start_addr)
8187 (show_source_disasm_command, show_data)
8188 (make_source_or_disasm_window)
8189 (show_source_or_disasm_and_command): Update.
8190 * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8191 (tui_disasm_window::do_scroll_vertical): Remove shadowing
8192 "gdbarch".
8193 * tui/tui-data.h (struct tui_source_info): Remove. Move contents
8194 to tui_source_window_base.
8195 (struct tui_win_info) <detail>: Remove source_info member.
8196 (struct tui_source_window_base) <has_locator>: Inline.
8197 Move contents from tui_source_info; rename has_locator member to
8198 m_has_locator.
8199 (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8200 * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8201 header file.
8202 (tui_source_window_base::clear_detail, ~tui_source_window_base):
8203 Simplify.
8204 (tui_free_all_source_wins_content): Cast to
8205 tui_source_window_base.
8206
8207 2019-06-25 Tom Tromey <tom@tromey.com>
8208
8209 * tui/tui-win.c (make_invisible_and_set_new_height)
8210 (make_visible_with_new_height): Call has_locator method.
8211 * tui/tui-layout.c (show_source_disasm_command, show_data)
8212 (show_source_or_disasm_and_command): Update for bool change.
8213 * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8214 (tui_win_info) <has_locator>: New method.
8215 (struct tui_source_window_base) <has_locator>: New method.
8216 (tui_win_has_locator): Don't declare.
8217 * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8218 from tui_win_has_locator.
8219 (tui_source_window_base): Use false, not FALSE.
8220
8221 2019-06-25 Tom Tromey <tom@tromey.com>
8222
8223 * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8224 * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8225 clear_detail method directly.
8226 (tui_clear_win_detail): Remove.
8227
8228 2019-06-25 Tom Tromey <tom@tromey.com>
8229
8230 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8231 "this", not TUI_DISASM_WIN.
8232
8233 2019-06-25 Tom Tromey <tom@tromey.com>
8234
8235 * tui/tui-winsource.h (tui_horizontal_source_scroll): Don't
8236 declare.
8237 * tui/tui-winsource.c
8238 (tui_source_window_base::do_scroll_horizontal): Rename from
8239 tui_horizontal_source_scroll.
8240 * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8241 * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8242 from tui_vertical_data_scroll.
8243 * tui/tui-win.h (tui_scroll): Don't declare.
8244 * tui/tui-win.c (tui_win_info::forward_scroll)
8245 (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8246 (tui_win_info::right_scroll): Rename and update.
8247 (tui_scroll_forward_command, tui_scroll_backward_command)
8248 (tui_scroll_left_command, tui_scroll_right_command): Update.
8249 (tui_scroll): Remove.
8250 * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
8251 * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
8252 from tui_vertical_source_scroll.
8253 * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
8254 * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
8255 from tui_vertical_disassem_scroll.
8256 * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
8257 do_scroll_horizontal>: New methods.
8258 <forward_scroll, backward_scroll, left_scroll, right_scroll>:
8259 Likewise.
8260 (struct tui_source_window_base): Add do_scroll_horizontal.
8261 (struct tui_source_window, struct tui_disasm_window): Add
8262 do_scroll_vertical.
8263 (struct tui_data_window, struct tui_cmd_window): Add
8264 do_scroll_horizontal and do_scroll_vertical.
8265 * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
8266
8267 2019-06-25 Tom Tromey <tom@tromey.com>
8268
8269 * tui/tui-data.h (struct tui_source_window_base): New struct.
8270 (struct tui_source_window): Derive from tui_source_window_base.
8271 (struct tui_disasm_window): New struct.
8272 * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
8273 from tui_source_window::clear_detail.
8274 (tui_source_window_base): Rename from tui_source_window.
8275 (~tui_source_window_base): Rename from ~tui_source_window.
8276 (tui_alloc_win_info): Create a tui_disasm_window.
8277
8278 2019-06-25 Tom Tromey <tom@tromey.com>
8279
8280 * tui/tui-data.h (struct tui_source_window)
8281 (struct tui_data_window): Declare destructors.
8282 * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
8283 destructors.
8284 (tui_win_info): Simplify.
8285
8286 2019-06-25 Tom Tromey <tom@tromey.com>
8287
8288 * tui/tui-winsource.c (tui_display_main)
8289 (tui_update_source_windows_with_addr)
8290 (tui_update_all_breakpoint_info): Update.
8291 * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8292 (new_height_ok, parse_scrolling_args): Update.
8293 * tui/tui-stack.c (tui_show_frame_info): Update.
8294 * tui/tui-data.h (struct tui_list): Remove.
8295 (tui_source_windows): Return a reference to a std::vector.
8296 * tui/tui-data.c (source_windows): Now a std::vector.
8297 (tui_source_windows): Change return type.
8298 (tui_clear_source_windows): Rewrite.
8299 (tui_clear_source_windows_detail, tui_add_to_source_windows)
8300 (tui_free_all_source_wins_content): Rewrite.
8301
8302 2019-06-25 Tom Tromey <tom@tromey.com>
8303
8304 * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
8305 (struct tui_data_window, struct tui_cmd_window): Declare
8306 clear_detail method.
8307 * tui/tui-data.c (tui_source_window::clear_detail)
8308 (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
8309 methods.
8310 (tui_clear_win_detail): Simplify.
8311
8312 2019-06-25 Tom Tromey <tom@tromey.com>
8313
8314 * tui/tui-layout.c (make_source_window, make_disasm_window)
8315 (make_source_or_disasm_window): Remove win_info_ptr parameter.
8316 Return the new window.
8317 (show_source_disasm_command, show_data)
8318 (show_source_or_disasm_and_command): Update.
8319
8320 2019-06-25 Tom Tromey <tom@tromey.com>
8321
8322 * tui/tui-layout.c (make_command_window): Remove win_info_ptr
8323 parameter. Return the new window.
8324 (show_source_disasm_command): Update and remove NULL check.
8325 (show_source_or_disasm_and_command): Update.
8326
8327 2019-06-25 Tom Tromey <tom@tromey.com>
8328
8329 * tui/tui-layout.c (init_and_make_win): Remove NULL check.
8330
8331 2019-06-25 Tom Tromey <tom@tromey.com>
8332
8333 * tui/tui-data.h (struct tui_win_info): Make constructor
8334 protected. Make destructor virtual. Add initializers.
8335 (tui_source_window, tui_data_window, tui_cmd_window): New
8336 classes.
8337 * tui/tui-data.c (tui_win_info): Rename from init_win_info. Now a
8338 constructor. Add "type" parameter.
8339 (tui_source_window, tui_data_window, tui_cmd_window): New
8340 constructors.
8341 (tui_alloc_win_info): Instantiate the appropriate subclass.
8342
8343 2019-06-25 Tom Tromey <tom@tromey.com>
8344
8345 * tui/tui-win.c (tui_resize_all): Use delete.
8346 * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
8347 destructor.
8348 (tui_free_window): Don't declare.
8349 * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
8350 Update.
8351
8352 2019-06-25 Tom Tromey <tom@tromey.com>
8353
8354 * tui/tui-data.h (struct tui_win_info): Add constructor.
8355 * tui/tui-data.c (tui_alloc_win_info): Use new.
8356 (tui_free_window): Use delete.
8357
8358 2019-06-22 Tom Tromey <tom@tromey.com>
8359
8360 * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
8361 declare.
8362 * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
8363
8364 2019-06-22 Tom Tromey <tom@tromey.com>
8365
8366 * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
8367 declare.
8368 * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
8369
8370 2019-06-22 Tom de Vries <tdevries@suse.de>
8371
8372 * dwarf2read.c (create_addrmap_from_aranges)
8373 (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
8374 instead of '%zu'.
8375
8376 2019-06-21 Simon Marchi <simon.marchi@efficios.com>
8377
8378 * dwarf2read.h (dwarf2_section_info_def): Remove.
8379 (DEF_VEC_O (dwarf2_section_info_def)): Remove.
8380 * dwarf2read.c (struct dwo_sections) <types>: Change type to
8381 std::vector<dwarf2_section_info>.
8382 (struct dwo_file) <~dwo_file>: Remove.
8383 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
8384 types field.
8385 (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
8386 (dwarf2_read_debug_names): Likewise.
8387 (create_debug_types_hash_table): Change parameter type to
8388 array_view, adjust code accordingly.
8389 (dwarf2_locate_dwo_sections): Adjust to std::vector.
8390 (partial_die_info::fixup): Likewise.
8391 (determine_prefix): Likewise.
8392 * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
8393
8394 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8395
8396 * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
8397 gdb_bfd_ref_ptr.
8398 <~dwo_file>: Remove call to gdb_bfd_unref.
8399 (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
8400 gdb_bfd_ref_ptr::get.
8401
8402 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8403
8404 * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
8405 type to htab_up.
8406 * dwarf2read.c (struct dwo_file): Initialize fields.
8407 <~dwo_file>: New.
8408 (free_dwo_file): Remove, move content to ~dwo_file.
8409 (struct dwo_file_deleter): Remove.
8410 (dwo_file_up>: Remove custom deleter.
8411 (free_dwo_files): Remove.
8412 (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
8413 dwo_files.
8414 (process_skeletonless_type_units): Call unique_ptr::get.
8415 (allocate_dwo_file_hash_table): Add deleter to created hash
8416 table. Change return type to htab_up.
8417 (lookup_dwo_file_slot): Don't memset dwo_file, call
8418 unique_ptr::get.
8419 (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
8420 (create_dwo_unit_in_dwp_v2): Likewise.
8421 (open_and_init_dwo_file): Likewise.
8422 (free_dwo_file_from_slot): Remove.
8423
8424 2019-06-21 Simon Marchi <simon.marchi@polymtl.ca>
8425
8426 * dwarf2read.h (struct dwarf2_section_info) <readin,
8427 is_virtual>: Change type to bool.
8428 * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
8429 true instead of 1.
8430
8431 2019-06-19 Tom Tromey <tom@tromey.com>
8432
8433 * tui/tui-data.h (tui_init_content_element): Don't declare.
8434
8435 2019-06-19 Tom Tromey <tom@tromey.com>
8436
8437 * tui/tui-data.h (tui_init_win_info): Don't declare.
8438
8439 2019-06-19 Tom de Vries <tdevries@suse.de>
8440
8441 * dwarf2read.h (abstract_to_concrete): Change type to
8442 std::unordered_map<sect_offset, std::vector<sect_offset>,
8443 gdb::hash_enum<sect_offset>>.
8444
8445 2019-06-19 Tom Tromey <tromey@adacore.com>
8446
8447 * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
8448 EVAL_AVOID_SIDE_EFFECTS specially.
8449
8450 2019-06-19 Tom Tromey <tromey@adacore.com>
8451
8452 * source-cache.c (highlighter): New global.
8453 (source_cache::get_source_lines): Create a highlighter on demand.
8454
8455 2019-06-18 Andrew Burgess <andrew.burgess@embecosm.com>
8456
8457 * defs.h (deprecated_interactive_hook): Delete declaration.
8458 * interps.c (clear_interpreter_hooks): Remove use of
8459 deprecated_interactive_hook.
8460 * top.c (deprecated_interactive_hook): Delete definition.
8461 * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
8462
8463 2019-06-18 Tom de Vries <tdevries@suse.de>
8464
8465 PR gdb/24515
8466 * dwarf2read.h (abstract_to_concrete): Change type from
8467 std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
8468 std::unordered_map<sect_offset, std::vector<sect_offset>>.
8469 * dwarf2read.c (read_variable): Update.
8470 (dwarf2_fetch_die_loc_sect_off): Update.
8471
8472 2019-06-17 Tom de Vries <tdevries@suse.de>
8473
8474 PR gdb/24617
8475 * common/pathstuff.c (child_path): Make sure parent_len > 0 before
8476 accessing parent[parent_len - 1].
8477
8478 2019-06-17 Paul Pluzhnikov <ppluzhnikov@google.com>
8479
8480 PR gdb/24364
8481 * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
8482 call dtrace_process_dof with NULL dof.
8483
8484 2019-06-16 Tom de Vries <tdevries@suse.de>
8485
8486 PR gdb/24445
8487 * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
8488
8489 2019-06-16 Tom Tromey <tom@tromey.com>
8490
8491 * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8492 (make_all_visible): Use address of member.
8493
8494 2019-06-16 Tom Tromey <tom@tromey.com>
8495
8496 * tui/tui-data.c (tui_clear_win_detail, init_win_info)
8497 (tui_free_window, free_content, free_content_elements): Remove
8498 unnecessary cast.
8499 * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
8500 cast.
8501 * tui/tui-regs.c (tui_show_register_group)
8502 (tui_display_registers_from, tui_display_reg_element_at_line):
8503 Remove unnecessary cast.
8504
8505 2019-06-16 Andrew Burgess <andrew.burgess@embecosm.com>
8506
8507 * linux-nat.c (normal_mask): Delete.
8508 (_initialize_linux_nat): Don't initialise normal_mask.
8509
8510 2019-06-16 Simon Marchi <simon.marchi@polymtl.ca>
8511
8512 PR gdb/24445
8513 * dwarf-index-write.h (write_psymtabs_to_index): Add
8514 dwz_basename parameter.
8515 * dwarf-index-write.c (write_gdbindex): Move file writing to
8516 write_gdbindex_1. Change return type void.
8517 (assert_file_size): Move up, remove filename parameter.
8518 (write_gdbindex_1): New function.
8519 (write_debug_names): Change return type to void, call
8520 assert_file_size.
8521 (struct index_wip_file): New struct.
8522 (write_psymtabs_to_index): Add dwz_basename parameter. Move
8523 file logic to index_wip_file. Write index for dwz file if
8524 needed.
8525 (save_gdb_index_command): Pass basename of dwz file, if present.
8526 * dwarf-index-cache.c (index_cache::store): Obtain and pass
8527 build-id of dwz file, if present.
8528 * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
8529 (dwarf2_get_dwz_file): Likewise.
8530 * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
8531 (dwarf2_get_dwz_file): Likewise.
8532
8533 2019-06-16 Tom Tromey <tom@tromey.com>
8534
8535 * coffread.c (process_coff_symbol): Use xstrdup.
8536 * value.c (create_internalvar): Use xstrdup.
8537
8538 2019-06-16 Tom Tromey <tom@tromey.com>
8539
8540 * valops.c (value_cast, value_slice): Remove unnecessary cast.
8541 * breakpoint.c (stopin_command, stopat_command)
8542 (until_break_command, decode_location_default): Remove unnecessary
8543 cast.
8544 * utils.c (subset_compare): Remove unnecessary cast.
8545 * ada-lang.c (ada_update_initial_language): Remove unnecessary
8546 cast.
8547 * linespec.c (decode_line_with_last_displayed): Remove unnecessary
8548 cast.
8549 * infcmd.c (path_command): Remove unnecessary cast.
8550 * coffread.c (decode_type): Remove unnecessary cast.
8551 * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
8552 * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
8553 * tui/tui-stack.c (tui_show_locator_content)
8554 (tui_show_frame_info): Remove unnecessary cast.
8555 * tui/tui-win.c (tui_scroll_forward_command)
8556 (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
8557 (parse_scrolling_args): Remove unnecessary cast.
8558 * tui/tui-data.c (init_win_info, tui_del_window)
8559 (tui_free_window, tui_del_data_windows, tui_free_data_content)
8560 (free_content_elements): Remove unnecessary cast.
8561 * tui/tui-windata.c (tui_first_data_item_displayed): Remove
8562 unnecessary cast.
8563 * tui/tui-source.c (tui_set_source_content)
8564 (tui_vertical_source_scroll): Remove unnecessary cast.
8565 * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
8566 cast.
8567 * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
8568 * tui/tui-regs.c (tui_display_registers_from)
8569 (tui_display_register): Remove unnecessary cast.
8570 * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
8571 (tui_unhighlight_win, tui_highlight_win, tui_make_window)
8572 (make_visible): Remove unnecessary cast.
8573 * tui/tui-winsource.c (tui_erase_source_content)
8574 (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
8575 unnecessary cast.
8576 * ax-gdb.c (agent_command_1): Remove unnecessary cast.
8577 * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
8578 * stabsread.c (read_type, read_array_type, read_range_type):
8579 Remove unnecessary cast.
8580 * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
8581 (parse_symbol, parse_type, upgrade_type, parse_external)
8582 (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
8583 unnecessary cast.
8584 * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
8585
8586 2019-06-16 Tom Tromey <tom@tromey.com>
8587
8588 * tui/tui-data.c (tui_alloc_generic_win_info)
8589 (tui_alloc_win_info, tui_add_content_elements): Remove NULL
8590 checks.
8591
8592 2019-06-16 Bernhard Heckel <bernhard.heckel@intel.com>
8593 Andrew Burgess <andrew.burgess@embecosm.com>
8594
8595 * f-typeprint.c (f_print_type): Don't return early for not
8596 associated or not allocated types.
8597 (f_type_print_varspec_suffix): Add print_rank parameter and print
8598 ranks of array types in case they dangling.
8599 (f_type_print_base): Add print_rank parameter.
8600
8601 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8602
8603 * NEWS: Mention new MI commands.
8604 * break-catch-throw.c (enum exception_event_kind): Move to
8605 breakpoint.h.
8606 (print_mention_exception_catchpoint): Output text as a single
8607 message.
8608 (catch_exception_command_1): Rename to...
8609 (catch_exception_event): ...this, make non-static, update header
8610 command, and change some parameter types.
8611 (catch_catch_command): Update for changes to
8612 catch_exception_command_1.
8613 (catch_throw_command): Likewise.
8614 (catch_rethrow_command): Likewise.
8615 * breakpoint.c (enum exception_event_kind): Delete.
8616 * breakpoint.h (enum exception_event_kind): Moved here from
8617 break-catch-throw.c.
8618 (catch_exception_event): Declare.
8619 * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
8620 (mi_cmd_catch_throw): New function.
8621 (mi_cmd_catch_rethrow): New function.
8622 (mi_cmd_catch_catch): New function.
8623 * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
8624 'catch-catch' entries.
8625 * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
8626 (mi_cmd_catch_rethrow): Declare.
8627 (mi_cmd_catch_catch): Declare.
8628
8629 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8630
8631 * annotate.c (annotate_source_line): Change return type to void,
8632 update implementation to match.
8633 * annotate.h (annotate_source_line): Change return type to void,
8634 update header comment.
8635 * stack.c (print_frame_info): Don't change what frame information
8636 is printed based on whether annotations are on or not.
8637
8638 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8639
8640 * annotate.c: Add 'source.h' and 'objfiles.h' includes.
8641 (annotate_source): Make static.
8642 (annotate_source_line): Moved from source.c and renamed from
8643 identify_source_line. Update the return type.
8644 * annotate.h (annotate_source): Delete declaration.
8645 (annotate_source_line): Declaration moved from source.h, and
8646 renamed from identify_source_line. Return type updated.
8647 * source.c (identify_source_line): Moved to annotate.c and renamed
8648 to annotate_source_line.
8649 (info_line_command): Remove check of annotation_level.
8650 * source.h (identify_source_line): Move declaration to annotate.h
8651 and rename to annotate_source_line.
8652 * stack.c: Add 'annotate.h' include.
8653 (print_frame_info): Remove check of annotation_level before
8654 calling annotate_source_line.
8655
8656 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8657
8658 * source-cache.c (source_cache::get_plain_source_lines): Use
8659 open_source_file_with_line_charpos instead of just
8660 open_source_file, remove call to find_source_lines.
8661 (source_cache::get_source_lines): Likewise.
8662 * source.c (find_source_lines): Make static.
8663 (get_filename_and_charpos): Renamed into...
8664 (open_source_file_with_line_charpos): ..this along with changes to
8665 return a scoped_fd, and some other minor clean ups.
8666 (identify_source_line): Use open_source_file_with_line_charpos.
8667 (search_command_helper): Use open_source_file_with_line_charpos
8668 instead of just open_source_file, remove call to
8669 find_source_lines.
8670 * source.h (open_source_file_with_line_charpos): Declare new
8671 function.
8672 (find_source_lines): Delete declaration.
8673
8674 2019-06-15 Andrew Burgess <andrew.burgess@embecosm.com>
8675
8676 * source.c (get_filename_and_charpos): Remove fullname
8677 parameter.
8678 (identify_source_line): Update call to get_filename_and_charpos.
8679
8680 2019-06-14 Tom Tromey <tromey@adacore.com>
8681
8682 PR gdb/24502:
8683 * ui-style.h (skip_ansi_escape): Update comment.
8684 * ui-file.h (class no_terminal_escape_file): New class.
8685 * ui-file.c (no_terminal_escape_file::write)
8686 (no_terminal_escape_file::puts): New methods.
8687 * cli/cli-logging.c (handle_redirections): Use
8688 no_terminal_escape_file.
8689
8690 2019-06-14 Tom Tromey <tromey@adacore.com>
8691
8692 * NEWS: Move convenience variable news above Python news.
8693
8694 2019-06-14 Tom Tromey <tom@tromey.com>
8695
8696 * gnulib: Move directory to top-level.
8697 * configure.ac: Don't configure gnulib.
8698 * configure: Rebuild.
8699 * common/common-defs.h: Use new path to gnulib.
8700 * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
8701 (GNULIB_H): Remove.
8702 (INCGNU): Look in new gnulib location.
8703 (HFILES_NO_SRCDIR): Remove gnulib files.
8704 (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
8705 (generated_files): Remove GNULIB_H.
8706 ($(LIBGNU), all-lib): Remove targets.
8707 (distclean): Don't mention GNULIB_BUILDDIR.
8708 ($(GNULIB_BUILDDIR)/Makefile): Remove target.
8709
8710 2019-06-14 Tom Tromey <tromey@adacore.com>
8711
8712 * symfile.c (add_symbol_file_command): Remove obsolete comment.
8713 Warn if symbol file does not provide any symbols.
8714
8715 2019-06-14 Tom Tromey <tromey@adacore.com>
8716
8717 * source.c (find_and_open_source): Respect basenames_may_differ.
8718
8719 2019-06-14 Andrew Burgess <andrew.burgess@embecosm.com>
8720
8721 * annotate.c (annotate_breakpoints_invalid): Make use of
8722 scoped_restore_terminal_state.
8723 (annotate_frames_invalid): Likewise.
8724
8725 2019-06-14 Tom Tromey <tromey@adacore.com>
8726
8727 * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
8728 allow assignment to an internalvar.
8729
8730 2019-06-14 Tom Tromey <tromey@adacore.com>
8731
8732 * ada-lex.l: Allow "_" in attribute names.
8733
8734 2019-06-14 Tom Tromey <tromey@adacore.com>
8735
8736 PR gdb/24653:
8737 * regcache.c (registers_changed): Don't call alloca.
8738 * top.c (execute_command): Don't call alloca.
8739
8740 2019-06-13 Pedro Alves <palves@redhat.com>
8741
8742 * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
8743 'expression'. When parsing an expression, error out if there's
8744 junk after "unlimited".
8745 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8746 (do_set_command): Adjust calls to is_unlimited_literal.
8747
8748 2019-06-13 Pedro Alves <palves@redhat.com>
8749
8750 * compile/compile.c (make_compile_options_def_group): Add braces
8751 around array_view initializer.
8752 * thread.c (make_thread_apply_all_options_def_group)
8753 (make_thread_apply_all_options_def_group): Likewise.
8754
8755 2019-06-13 Pedro Alves <palves@redhat.com>
8756
8757 * NEWS (New commands): Mention "maint test-options
8758 require-delimiter", "maint test-options unknown-is-error", "maint
8759 test-options unknown-is-operand" and "maint show
8760 test-options-completion-result".
8761 (New command options, command completion): New section.
8762 (Completion improvements): New section.
8763 Mention that you can abbreviate "unlimited".
8764
8765 2019-06-13 Pedro Alves <palves@redhat.com>
8766
8767 * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
8768 * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
8769 * unittests/cli-utils-selftests.c (test_parse_flags)
8770 (test_parse_flags_qcs): Delete.
8771 (test_cli_utils): Don't call deleted functions.
8772
8773 2019-06-13 Pedro Alves <palves@redhat.com>
8774
8775 * thread.c: Include "cli/cli-option.h".
8776 (tp_array_compar_ascending): Global.
8777 (tp_array_compar): Delete function.
8778 (tp_array_compar_ascending, tp_array_compar_descending): New
8779 functions.
8780 (ascending_option_def, qcs_flag_option_def)
8781 (thr_qcs_flags_option_defs)
8782 (make_thread_apply_all_options_def_group)
8783 (make_thread_apply_options_def_group): New.
8784 (thread_apply_all_command): Use gdb::option::process_options.
8785 (thread_apply_command_completer)
8786 (thread_apply_all_command_completer): New.
8787 (thread_apply_command): Use gdb::option::process_options.
8788 (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
8789 with a new THREAD_APPLY_OPTION_HELP. Use gdb::option::build_help
8790 to generate help text of "thread apply". Adjust "taas"'s help.
8791 * tid-parse.c (tid_range_parser::in_thread_range): New method.
8792 * tid-parse.h (tid_range_parser::in_thread_range): New method.
8793
8794 2019-06-13 Pedro Alves <palves@redhat.com>
8795
8796 * thread.c (thread_apply_command): Check for invalid TID with
8797 isdigit instead of !isalpha.
8798
8799 2019-06-13 Pedro Alves <palves@redhat.com>
8800
8801 * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
8802 (validate_flags_qcs): New.
8803 * cli/cli-utils.h (struct qcs_flags): Change field types to int.
8804 (validate_flags_qcs): Declare.
8805 * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
8806 (make_frame_apply_options_def_group): New.
8807 (frame_apply_command_count): Process options with
8808 gdb::option::process_options.
8809 (frame_apply_completer): New.
8810 (frame_apply_level_completer, frame_apply_all_completer)
8811 (frame_apply_completer): New.
8812 (_initialize_stack): Update help of "frame apply", "frame apply
8813 level", "frame apply all" and "faas" to mention supported options
8814 and install command completers.
8815 * stack.h (frame_apply_all_completer): Declare.
8816 * thread.c: Include "stack.h".
8817 (tfaas_command): Add "--".
8818 (_initialize_thread): Update help "tfaas" to mention supported
8819 options and install command completer.
8820
8821 2019-06-13 Pedro Alves <palves@redhat.com>
8822
8823 * completer.c (complete_nested_command_line): New.
8824 (gdb_completion_word_break_characters_throw): Add assertion.
8825 * completer.h (complete_nested_command_line): Declare.
8826
8827 2019-06-13 Pedro Alves <palves@redhat.com>
8828
8829 * stack.c (parse_backtrace_qualifiers): New.
8830 (backtrace_command): Use it.
8831 (backtrace_command_completer): Complete on qualifiers.
8832
8833 2019-06-13 Pedro Alves <palves@redhat.com>
8834
8835 * frame.c: Include "cli/cli-option.h.
8836 (user_set_backtrace_options): New.
8837 (backtrace_past_main, backtrace_past_entry, backtrace_limit):
8838 Delete.
8839 (get_prev_frame): Adjust.
8840 (boolean_option_def, uinteger_option_def)
8841 (set_backtrace_option_defs): New.
8842 (_initialize_frame): Adjust and use
8843 gdb::option::add_setshow_cmds_for_options to install "set
8844 backtrace past-main" and "set backtrace past-entry".
8845 * frame.h: Include "cli/cli-option.h".
8846 (struct frame_print_options): Forward declare.
8847 (print_frame_arguments_all, print_frame_arguments_scalars)
8848 (print_frame_arguments_none): Declare.
8849 (print_entry_values): Delete declaration.
8850 (struct frame_print_options, user_frame_print_options): New.
8851 (struct set_backtrace_options): New.
8852 (set_backtrace_option_defs, user_set_backtrace_options): Declare.
8853 * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
8854 (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
8855 (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
8856 (list_args_or_locals): Add frame_print_options parameter.
8857 (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8858 * python/py-framefilter.c (enumerate_args): Pass down
8859 USER_FRAME_PRINT_OPTIONS.
8860 * stack.c: Include "cli/cli-option.h".
8861 (print_frame_arguments_all, print_frame_arguments_scalars)
8862 (print_frame_arguments_none): Declare.
8863 (print_raw_frame_arguments, print_entry_values): Delete.
8864 (user_frame_print_options): New.
8865 (boolean_option_def, enum_option_def, frame_print_option_defs):
8866 New.
8867 (struct backtrace_cmd_options): New.
8868 (bt_flag_option_def): New.
8869 (backtrace_command_option_defs): New.
8870 (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
8871 (print_frame_arg, read_frame_arg, print_frame_args)
8872 (print_frame_info, print_frame): Add frame_print_options parameter
8873 and use it.
8874 (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
8875 (backtrace_command_1): Add frame_print_options and
8876 backtrace_cmd_options parameters and use them.
8877 (make_backtrace_options_def_group): New.
8878 (backtrace_command): Process command options with
8879 gdb::option::process_options.
8880 (backtrace_command_completer): New.
8881 (_initialize_stack): Extend "backtrace"'s help to mention
8882 supported options. Install completer for "backtrace".
8883 Install some settings commands with add_setshow_cmds_for_options.
8884
8885 2019-06-13 Pedro Alves <palves@redhat.com>
8886
8887 * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
8888 and that "set/show print raw frame-arguments" are now deprecated.
8889
8890 * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
8891 command.
8892 * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
8893 * stack.c (_initialize_stack): Install "set/show print
8894 raw-frame-arguments", and deprecate "set/show print raw
8895 frame-arguments".
8896 * valprint.c (_initialize_valprint): Deprecate "set/show print
8897 raw".
8898
8899 2019-06-13 Pedro Alves <palves@redhat.com>
8900
8901 * compile/compile.c (struct compile_options): New.
8902 (compile_flag_option_def, compile_command_option_defs)
8903 (make_compile_options_def_group): New.
8904 (compile_file_command): Handle options with
8905 gdb::option::process_options.
8906 (compile_file_command_completer): New function.
8907 (compile_code_command): Handle options with
8908 gdb::option::process_options.
8909 (compile_code_command_completer): New function.
8910 (_initialize_compiler): Install completers for "compile code" and
8911 "compile file". Mention available options in "compile code" and
8912 "compile code"'s help.
8913 * completer.c (advance_to_completion_word): New, factored out from
8914 ...
8915 (advance_to_expression_complete_word_point): ... this.
8916 (advance_to_filename_complete_word_point): New.
8917 * completer.h (advance_to_filename_complete_word_point): New
8918 declaration.
8919
8920 2019-06-13 Pedro Alves <palves@redhat.com>
8921
8922 * compile/compile.c: Include "cli/cli-option.h".
8923 (compile_print_value): Scope data pointer is now a
8924 value_print_options pointer; adjust.
8925 (compile_print_command): Process options. Scope data pointer is
8926 now a value_print_options pointer; adjust.
8927 (_initialize_compile): Update "compile print"'s help to include
8928 supported options. Install a completer for "compile print".
8929 * cp-valprint.c (show_vtblprint, show_objectprint)
8930 (show_static_field_print): Delete.
8931 (_initialize_cp_valprint): Don't install "set print
8932 static-members", "set print vtbl", "set print object" here.
8933 * printcmd.c: Include "cli/cli-option.h" and
8934 "common/gdb_optional.h".
8935 (print_command_parse_format): Rework to fill in a
8936 value_print_options instead of a format_data.
8937 (print_value): Change parameter type from format_data pointer to
8938 value_print_options reference. Adjust.
8939 (print_command_1): Process options. Adjust to pass down a
8940 value_print_options.
8941 (print_command_completer): New.
8942 (_initialize_printcmd): Install print_command_completer as
8943 handle_brkchars completer for the "print" command. Update
8944 "print"'s help to include supported options.
8945 * valprint.c: Include "cli/cli-option.h".
8946 (show_vtblprint, show_objectprint, show_static_field_print): Moved
8947 here from cp-valprint.c.
8948 (boolean_option_def, uinteger_option_def)
8949 (value_print_option_defs, make_value_print_options_def_group):
8950 New. Use gdb::option::add_setshow_cmds_for_options to install
8951 "set print elements", "set print null-stop", "set print repeats",
8952 "set print pretty", "set print union", "set print array", "set
8953 print address", "set print symbol", "set print array-indexes".
8954 * valprint.h: Include <string> and "cli/cli-option.h".
8955 (make_value_print_options_def_group): Declare.
8956 (print_value): Change parameter type from format_data pointer to
8957 value_print_options reference.
8958 (print_command_completer): Declare.
8959
8960 2019-06-13 Pedro Alves <palves@redhat.com>
8961
8962 * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
8963 (COMMON_SFILES): Add maint-test-settings.c.
8964 * cli/cli-decode.c (boolean_enums): New global, factored out from
8965 ...
8966 (add_setshow_boolean_cmd): ... here.
8967 * cli/cli-decode.h (boolean_enums): Declare.
8968 * cli/cli-option.c: New file.
8969 * cli/cli-option.h: New file.
8970 * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
8971 factored out from ...
8972 (parse_cli_boolean_value(const char *)): ... this.
8973 (is_unlimited_literal): Change parameter type to pointer to
8974 pointer. Adjust and advance ARG pointer.
8975 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8976 (parse_cli_var_enum): New, factored out from ...
8977 (do_set_command): ... this. Adjust.
8978 * cli/cli-setshow.h (parse_cli_boolean_value)
8979 (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
8980 (parse_cli_var_enum): Declare.
8981 * cli/cli-utils.c: Include "cli/cli-option.h".
8982 (get_ulongest): New.
8983 * cli/cli-utils.h (get_ulongest): Declare.
8984 (check_for_argument): New overloads.
8985 * maint-test-options.c: New file.
8986
8987 2019-06-13 Pedro Alves <palves@redhat.com>
8988
8989 * cli/cli-utils.c (number_or_range_parser::get_number): Do not
8990 parse a range if "-" is at the end of the string.
8991
8992 2019-06-13 Pedro Alves <palves@redhat.com>
8993
8994 * cli/cli-setshow.c (parse_auto_binary_operation)
8995 (parse_cli_boolean_value): Don't allow "o".
8996
8997 2019-06-13 Pedro Alves <palves@redhat.com>
8998
8999 * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9000 * NEWS: Mention maint test-settings KIND.
9001 * maint-test-settings.c: New file.
9002
9003 2019-06-13 Pedro Alves <palves@redhat.com>
9004
9005 * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9006 completer.
9007 (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9008 "set" completers.
9009
9010 2019-06-13 Pedro Alves <palves@redhat.com>
9011
9012 * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9013 after item.
9014
9015 2019-06-13 Pedro Alves <palves@redhat.com>
9016
9017 * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9018
9019 2019-06-13 Pedro Alves <palves@redhat.com>
9020
9021 * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9022 * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9023 call.
9024 * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9025 * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9026 calls.
9027 (check_for_argument): Skip spaces after argument.
9028
9029 2019-06-13 Pedro Alves <palves@redhat.com>
9030
9031 * thread.c (thread_apply_command): Adjust TID parsing.
9032 * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9033 detected before end of string.
9034 (tid_is_in_list): Error out if LIST is invalid.
9035
9036 2019-06-13 Pedro Alves <palves@redhat.com>
9037
9038 * completer.c (complete_line_internal_1): Rewind completion word
9039 point.
9040 (completion_tracker::advance_custom_word_point_by): Change
9041 parameter type to int.
9042 * completer.h (completion_tracker::advance_custom_word_point_by):
9043 Likewise.
9044
9045 2019-06-13 Pedro Alves <palves@redhat.com>
9046
9047 * completer.c (advance_to_completion_word): Handle delimiters.
9048
9049 2019-06-11 Bernhard Heckel <bernhard.heckel@intel.com>
9050
9051 * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9052
9053 2019-06-11 Tom Tromey <tom@tromey.com>
9054
9055 * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9056 (xmalloc_failed): Move to alloc.c.
9057 * alloc.c: New file.
9058 * Makefile.in (COMMON_SFILES): Add alloc.c.
9059
9060 2019-06-11 Tom Tromey <tom@tromey.com>
9061
9062 * nat/linux-waitpid.c: Don't include server.h.
9063 (linux_debug): Remove.
9064 (my_waitpid): Update.
9065
9066 2019-06-11 Tom Tromey <tromey@adacore.com>
9067
9068 * infcall.c (_initialize_infcall): Remove trailing newline from
9069 help.
9070 * user-regs.c (_initialize_user_regs): Remove trailing newline
9071 from help.
9072 * typeprint.c (_initialize_typeprint): Remove trailing newline
9073 from help.
9074 * reverse.c (_initialize_reverse): Remove trailing newlines from
9075 help.
9076 * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9077 from help.
9078 * language.c (add_set_language_command): Remove trailing newline
9079 from help.
9080 * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9081 help.
9082 * disasm.c (_initialize_disasm): Remove trailing newline from
9083 help.
9084 * top.c (init_main): Remove trailing newline from help.
9085 * interps.c (_initialize_interpreter): Remove trailing newline
9086 from help.
9087 * btrace.c (_initialize_btrace): Remove trailing newlines from
9088 help.
9089 * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9090 from help.
9091 * python/python.c (_initialize_python): Remove trailing newline
9092 from help.
9093 * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9094 help.
9095 * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9096 from help. Reformat some text.
9097 * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9098 from help.
9099 * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9100 newline from help.
9101
9102 2019-06-11 Tom Tromey <tromey@adacore.com>
9103
9104 * darwin-nat.c (darwin_decode_exception_message)
9105 (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9106
9107 2019-06-10 Andrew Burgess <andrew.burgess@embecosm.com>
9108
9109 * valops.c (value_slice): Check for not allocated or not
9110 associated values.
9111
9112 2019-06-10 Tom de Vries <tdevries@suse.de>
9113
9114 PR gdb/24618
9115 * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9116 sure an empty slot (defined by a 32-bit zero pair) is recognized as
9117 invalid.
9118
9119 2019-06-10 Tom de Vries <tdevries@suse.de>
9120
9121 PR gdb/24611
9122 * linespec.c (linespec_lexer_lex_string): Remove incorrect
9123 "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon. Add assert.
9124
9125 2019-06-10 Tom de Vries <tdevries@suse.de>
9126
9127 PR symtab/24545
9128 * symtab.c (struct demangled_name_entry): Add language field.
9129 (symbol_set_names): Revert "[gdb/symtab] Fix language of duplicate
9130 static minimal symbol". Set and use language field.
9131
9132 2019-06-10 Tom Tromey <tromey@adacore.com>
9133
9134 * ada-lang.c (_initialize_ada_language): Update help text.
9135
9136 2019-06-10 Tom Tromey <tromey@adacore.com>
9137
9138 * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9139 with a newline.
9140 * guile/guile.c (handle_boot_error): Don't end warning with a
9141 newline.
9142 * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9143 warning with a newline.
9144 * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9145 newline.
9146 (s12z_frame_cache): Likewise.
9147 * dwarf-index-cache.c (index_cache::store): Don't end warning with
9148 a newline.
9149 * solib-svr4.c (disable_probes_interface): Don't end warning with
9150 a newline.
9151 * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9152 newline.
9153 * python/python.c (do_finish_initialization): Don't end warning
9154 with a newline.
9155
9156 2019-06-10 Tom Tromey <tom@tromey.com>
9157
9158 * python/py-breakpoint.c (gdbpy_breakpoint_created)
9159 (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9160 gdbpy_enter.
9161
9162 2019-06-10 Tom Tromey <tromey@adacore.com>
9163
9164 * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9165 data.
9166 (elf_new_init): Don't call stabsread_new_init.
9167 * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9168 (elfstab_build_psymtabs): Likewise. Call stabsread_new_init.
9169 * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9170
9171 2019-06-10 Tom de Vries <tdevries@suse.de>
9172
9173 PR symtab/16264
9174 PR symtab/24517
9175 * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9176
9177 2019-06-06 Руслан Ижбулатов <lrn1986@gmail.com>
9178
9179 * source.c (find_and_open_source): Also rewrite relative file
9180 names.
9181
9182 2019-04-26 Amos Bird <amosbird@gmail.com>
9183
9184 * annotate.c (annotate_thread_exited): Add "thread-exited"
9185 annotation.
9186
9187 2019-06-06 Tom Tromey <tromey@adacore.com>
9188
9189 * maint.h (class scoped_command_stats): Use
9190 DISABLE_COPY_AND_ASSIGN.
9191 <print_time>: New method.
9192 * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9193 print_time.
9194 (scoped_command_stats::print_time): New method.
9195
9196 2019-06-05 Andrew Burgess <andrew.burgess@embecosm.com>
9197
9198 * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9199 instructions of lengths 6 or 8 bytes.
9200
9201 2019-06-04 Pedro Alves <palves@redhat.com>
9202
9203 * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9204
9205 * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9206 * breakpoint.c (condition_completer): Likewise.
9207 * cli/cli-dump.c (scan_expression): Likewise.
9208 * common/filestuff.c (mkdir_recursive): Likewise.
9209 * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9210 * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9211 (gdb_abspath): Likewise.
9212 * compile/compile-cplus-types.c
9213 (compile_cplus_instance::decl_name): Likewise.
9214 * completer.c (complete_explicit_location):
9215 (signal_completer, reg_or_group_completer_1): Likewise.
9216 * cp-support.c (cp_remove_params_if_any): Likewise.
9217 * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9218 * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9219 * infcmd.c (strip_bg_char): Likewise.
9220 * linespec.c (copy_token_string): Likewise.
9221 * mi/mi-main.c (output_cores): Likewise.
9222 * psymtab.c (psymtab_search_name):
9223 * symfile.c (test_set_ext_lang_command): Likewise.
9224 * target.c (target_fileio_read_stralloc): Likewise.
9225 * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9226 * value.c (complete_internalvar): Likewise.
9227
9228 2019-06-04 Christian Biesinger <cbiesinger@google.com>
9229
9230 Add objfile property to gdb.Type.
9231 * NEWS: Mention Python API addition.
9232 * python/py-type.c (typy_get_objfile): New method.
9233
9234 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9235
9236 * NEWS: Mention the new set|show style [title|highlight].
9237 Mention changes to "show style", "help" and "apropos".
9238
9239 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9240
9241 * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9242 * cli/cli-decode.c (apropos_cmd): Likewise. Use print_doc_of_command
9243 instead of print_help_for_command.
9244 (print_doc_of_command): New function.
9245 (help_list): Add 'apropos -v word' suggestion.
9246 (print_help_for_command): Style the command name using title style.
9247 * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9248 (_initialize_cli_cmds): Describe -v in apropos_command help.
9249
9250 2019-06-03 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9251
9252 * cli/cli-style.h (cli_style_option): Add name in constructor,
9253 add m_name class member, add constructor with intensity,
9254 add name class function.
9255 (cli_style_option::add_setshow_commands): Remove name argument.
9256 (highlight_style, title_style): New styles.
9257 * cli/cli-style.c (do_show): New function that shows a style
9258 characteristic styling the style name with itself.
9259 (set_style_name): New function.
9260 (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
9261 Update all callers according to the changes in cli/cli-style.h.
9262 * utils.h (fputs_highlighted): New function.
9263 * utils.c (fputs_highlighted): Likewise.
9264
9265 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9266
9267 * NEWS: Mention new pipe command and new convenience variables.
9268
9269 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9270
9271 * cli/cli-cmds.c (pipe_command): New function.
9272 (_initialize_cli_cmds): Call add_com for pipe_command.
9273 Define | as an alias for pipe.
9274 (exit_status_set_internal_vars): New function.
9275 (shell_escape): Call exit_status_set_internal_vars.
9276 cli/cli-decode.c (find_command_name_length): Recognize | as
9277 a single character command.
9278
9279 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9280
9281 * gdbcmd.h (execute_command_to_ui_file): New declaration.
9282 top.c (execute_command_to_ui_file): New function, mostly a copy
9283 of execute_command_to_string.
9284 (execute_command_to_string): Implement by calling
9285 execute_command_to_ui_file.
9286
9287 2019-05-31 Philippe Waroquiers <philippe.waroquiers@skynet.be>
9288
9289 * top.h (saved_command_line): Remove declaration.
9290 * top.c (previous_saved_command_line, previous_repeat_arguments):
9291 New variables.
9292 (saved_command_line): Make static, define together with other
9293 'repeat variables'.
9294 (dont_repeat): Clear repeat_arguments.
9295 (repeat_previous, get_saved_command_line, save_command_line):
9296 New functions.
9297 (gdb_init): Initialize saved_command_line
9298 and previous_saved_command_line.
9299 * main.c (captured_main_1): Remove saved_command_line initialization.
9300 * event-top.c (handle_line_of_input): Update to use
9301 the new 'repeat' related functions instead of direct access to
9302 saved_command_line.
9303 * command.h (repeat_previous, get_saved_command_line,
9304 save_command_line): New declarations.
9305 (dont_repeat): Add comment.
9306
9307 2019-05-30 Tom Tromey <tromey@adacore.com>
9308
9309 * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
9310 Fix comment.
9311 (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
9312
9313 2019-05-30 Jan Vrany <jan.vrany@fit.cvut.cz>
9314
9315 PR cli/24587
9316 * completer.c (complete): Initialize variable word.
9317
9318 2019-05-29 Sergio Durigan Junior <sergiodj@redhat.com>
9319
9320 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9321 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
9322 * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
9323 'body' is NULL to the outter 'if', protecting the '!is_define'
9324 situation as well.
9325
9326 2019-05-29 Tom Tromey <tromey@adacore.com>
9327
9328 * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
9329 (dwarf_unknown): New function.
9330 (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
9331 (dwarf_type_encoding_name): Use dwarf_unknown.
9332
9333 2019-05-29 Tom Tromey <tromey@adacore.com>
9334
9335 PR c++/20020:
9336 * cp-valprint.c (cp_print_value_fields): Call
9337 cp_print_static_field inside "try".
9338
9339 2019-05-29 Tom Tromey <tromey@adacore.com>
9340
9341 * inflow.c (struct terminal_info): Add default operator=.
9342 * configure: Rebuild.
9343 * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
9344 -Wdeprecated-copy-dtor, -Wredundant-move.
9345
9346 2019-05-29 Tom Tromey <tromey@adacore.com>
9347
9348 * NEWS: Add entry.
9349 * infcmd.c (print_return_value_1): Handle finish_print
9350 option.
9351 (show_print_finish): New function.
9352 (_initialize_infcmd): Add "set/show print finish" commands.
9353 * valprint.c (user_print_options): Initialize new member.
9354 * valprint.h (struct value_print_options) <finish_print>: New
9355 member.
9356
9357 2019-05-28 Tom Tromey <tromey@adacore.com>
9358
9359 * ada-lang.c (ada_remove_Xbn_suffix)
9360 (find_old_style_renaming_symbol)
9361 (parse_old_style_renaming): Remove.
9362 (ada_find_renaming_symbol): Don't call
9363 find_old_style_renaming_symbol.
9364 (ada_is_renaming_symbol): Rename from
9365 ada_find_renaming_symbol. Remove "block" parameter. Return
9366 bool. Now static.
9367 (ada_read_var_value): Update and simplify.
9368 * ada-exp.y (write_var_or_type): Remove old code.
9369
9370 2019-05-28 Alan Hayward <alan.hayward@arm.com>
9371
9372 PR gdb/25010
9373 * event-top.c: Remove include comment.
9374 * inflow.c (class scoped_ignore_sigttou): Move from here...
9375 * inflow.h (class scoped_ignore_sigttou): ...to here.
9376 * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
9377 * top.c: Remove include comment.
9378
9379 2019-05-27 Tom Tromey <tom@tromey.com>
9380
9381 * NEWS: Fix typo.
9382
9383 2019-05-22 Tom Tromey <tromey@adacore.com>
9384
9385 * target.c (target_follow_exec): Constify parameter.
9386 * target-delegates.c: Rebuild.
9387 * remote.c (remote_target::follow_exec): Constify parameter.
9388 * infrun.c (follow_exec): Constify parameter.
9389 * target.h (struct target_ops) <follow_exec>: Constify parameter.
9390 (target_follow_exec): Likewise.
9391
9392 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9393
9394 * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
9395 DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
9396
9397 2019-05-22 Alan Hayward <alan.hayward@arm.com>
9398
9399 * NEWS: Add debugredirect and testsuite sections.
9400
9401 2019-05-22 Simon Cook <simon.cook@embecosm.com>
9402
9403 * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
9404 target descriptions using exclusively floating point register name
9405 aliases.
9406
9407 2019-05-21 Andrew Burgess <andrew.burgess@embecosm.com>
9408
9409 PR gdb/18644:
9410 * f-lang.c (build_fortran_types): Handle the case where
9411 gdbarch_floatformat_for_type returns a nullptr.
9412
9413 2019-05-21 Tom de Vries <tdevries@suse.de>
9414
9415 PR cli/24587
9416 * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
9417
9418 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9419
9420 PR gdb/18644:
9421 * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
9422 16-byte floats.
9423 * i386-tdep.c (i386_floatformat_for_type): Use
9424 floatformats_ia64_quad for the 16-byte floating point component
9425 within a fortran 32-byte complex number.
9426
9427 2019-05-18 Andrew Burgess <andrew.burgess@embecosm.com>
9428
9429 * dwarf2read.c (struct cu_partial_die_info): Add constructor,
9430 delete default constructor.
9431 (find_partial_die): Update to return const struct.
9432 (partial_die_parent_scope): Move variable declaration into scope
9433 of its use and change its type to auto.
9434 (guess_partial_die_structure_name): Likewise.
9435 (partial_die_info::fixup): Likewise.
9436
9437 2019-05-17 Tom Tromey <tromey@adacore.com>
9438
9439 * source.c (find_and_open_source): Remove cast.
9440
9441 2019-05-17 Tom Tromey <tromey@adacore.com>
9442
9443 * annotate.c (annotate_source): Make "filename" const.
9444 * annotate.h (annotate_source): Use const.
9445
9446 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9447
9448 * disasm.c (set_disassembler_options): Send errors to stderr.
9449
9450 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9451
9452 * cli/cli-interp.c (struct saved_output_files): Add saved entry.
9453 (cli_interp_base::set_logging): Check debug_redirect.
9454 * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
9455 * cli/cli-logging.c (debug_redirect): Add static variable.
9456 (pop_output_files): Add default param.
9457 (handle_redirections): Print debug setting.
9458 (show_logging_command): Likewise.
9459 (_initialize_cli_logging): Add debugredirect command.
9460 * interps.c (current_interp_set_logging): Add debug_redirect
9461 parameter.
9462 * interps.h (set_logging): Add debug_redirect parameter.
9463 (current_interp_set_logging): Likewise.
9464 * mi/mi-common.h: Likewise.
9465 * mi/mi-interp.c (mi_interp::set_logging): Likewise.
9466
9467 2019-05-17 Alan Hayward <alan.hayward@arm.com>
9468 Tom Tromey <tromey@adacore.com>
9469
9470 * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
9471 directly.
9472 * cli/cli-interp.h (make_logging_output): Remove declaration.
9473 * cli/cli-logging.c (make_logging_output): Remove function.
9474 * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
9475 directly.
9476 * ui-file.c (tee_file::tee_file): Remove bools.
9477 (tee_file::~tee_file): Remove deletes.
9478 * ui-file.h (tee_file): Remove bools.
9479
9480 2019-01-28 Jan Vrany <jan.vrany@fit.cvut.cz>
9481
9482 * mi/mi-cmds.h (mi_cmd_complete): New function.
9483 * mi/mi-main.c (mi_cmd_complete): Likewise.
9484 * mi/mi-cmds.c: Define new MI command -complete.
9485 * NEWS: Mention new -complete command.
9486
9487 2019-01-24 Jan Vrany <jan.vrany@fit.cvut.cz>
9488
9489 * completer.h (complete): New function.
9490 * completer.c (complete): Likewise.
9491 * cli/cli-cmds.c: (complete_command): Update to use new complete()
9492 function defined in completer.h.
9493
9494 2019-05-17 Jan Vrany <jan.vrany@fit.cvut.cz>
9495
9496 * MAINTAINERS (Write After Approval): Add myself.
9497
9498 2019-05-17 Tom de Vries <tdevries@suse.de>
9499
9500 PR gdb/24094
9501 * dwarf2read.c (struct cu_partial_die_info): New struct.
9502 (find_partial_die): Return cu_partial_die_info.
9503 (partial_die_parent_scope, guess_partial_die_structure_name)
9504 (partial_die_info::fixup): Handle new return type of find_partial_die.
9505
9506 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9507
9508 PR breakpoints/24541
9509 * stap-probe.c (stap_parse_register_operand): Make "regname" an
9510 "std::string", simplifying the algorithm.
9511
9512 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9513
9514 * stap-probe.c (handle_stap_probe): Fix complaint formatting.
9515 (stap_static_probe_ops::get_probes): Likewise.
9516
9517 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9518
9519 * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
9520 '-')" and "else if".
9521 (stap_parse_single_operand): Join checks for
9522 "gdbarch_stap_parse_special_token_p" and
9523 "gdbarch_stap_parse_special_token" in the same "if" statement.
9524 Invert check when verifying for operation on register
9525 displacement.
9526
9527 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9528
9529 * stap-probe.c (stap_get_opcode): Update comment.
9530 (stap_get_expected_argument_type): Likewise.
9531 (handle_stap_probe): Likewise.
9532
9533 2019-05-16 Sergio Durigan Junior <sergiodj@redhat.com>
9534
9535 * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
9536 return type to 'bool'. Adjust comment. Use 'bool' when
9537 appropriate.
9538 (i386_stap_parse_special_token_three_arg_disp): Likewise.
9539 * stap-probe.c (stap_parse_argument_1): Likewise.
9540 (stap_is_operator): Likewise.
9541 (stap_is_generic_prefix): Likewise.
9542 (stap_is_register_prefix): Likewise.
9543 (stap_is_register_indirection_prefix): Likewise.
9544 (stap_is_integer_prefix): Likewise.
9545 (stap_generic_check_suffix): Likewise.
9546 (stap_check_integer_suffix): Likewise.
9547 (stap_check_register_suffix): Likewise.
9548 (stap_check_register_indirection_suffix): Likewise.
9549 (stap_parse_register_operand): Likewise.
9550 (stap_parse_single_operand): Likewise.
9551 (stap_parse_argument_1): Likewise.
9552 (stap_probe::get_argument_count): Likewise.
9553 (stap_is_operator): Likewise.
9554
9555 2019-05-16 Tom Tromey <tromey@adacore.com>
9556
9557 * darwin-nat.c (thread_info_from_private_thread_info): Add struct
9558 keyword to foreach.
9559
9560 2019-05-15 Simon Marchi <simon.marchi@efficios.com>
9561
9562 * linux-thread-db.c (try_thread_db_load_1): Change return type
9563 to bool.
9564 (try_thread_db_load): Likewise.
9565 (try_thread_db_load_from_pdir_1): Likewise.
9566 (try_thread_db_load_from_pdir): Likewise.
9567 (try_thread_db_load_from_sdir): Likewise.
9568 (try_thread_db_load_from_dir): Likewise.
9569 (thread_db_load_search): Likewise.
9570 (has_libpthread): Likewise.
9571 (thread_db_load): Likewise.
9572
9573 2019-05-15 Sergio Durigan Junior <sergiodj@redhat.com>
9574
9575 Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
9576 * dwarf2read.c (parse_macro_definition): Check whether 'body' is
9577 NULL, and complain/return if that's the case.
9578
9579 2019-05-15 John Darrington <john@darrington.wattle.id.au>
9580
9581 * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
9582 (advance, posn, abstract_read_memory): New functions.
9583 [struct mem_read_abstraction]: New struct.
9584 (s12z_frame_cache): Use opcodes API to interpret stack frame code.
9585
9586 2019-05-14 Tom Tromey <tromey@adacore.com>
9587
9588 * ada-lang.c (coerce_unspec_val_to_type): Only set address when
9589 value is not lval_memory.
9590
9591 2019-05-14 Tom Tromey <tromey@adacore.com>
9592
9593 * solib.c (info_sharedlibrary_command): Style the file name.
9594
9595 2019-05-14 Alan Hayward <alan.hayward@arm.com>
9596
9597 * aarch64-tdep.c (aarch64_vnh_type): Add half view.
9598 (aarch64_vnv_type): Likewise.
9599 * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
9600 * common/tdesc.c: Likewise.
9601 * common/tdesc.h (enum tdesc_type_kind): Likewise.
9602 * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
9603 * features/aarch64-fpu.xml: Add ieee half view.
9604 * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
9605 * gdbtypes.c (gdbtypes_post_init): Add builtin_half
9606 * gdbtypes.h (struct builtin_type): Likewise.
9607 (struct objfile_type): Likewise.
9608
9609 2019-05-12 Paul Naert <paul.naert@polymtl.ca>
9610
9611 * language.c (language_sniff_from_mangled_name): Fix "langauge"
9612 typo.
9613 * location.h (string_to_event_location): Likewise.
9614
9615 2019-05-11 Joel Brobecker <brobecker@adacore.com>
9616
9617 GDB 8.3 released.
9618
9619 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9620
9621 * breakpoint.h (fix_multi_location_breakpoint_output_globally):
9622 New variable declaration.
9623 * breakpoint.c (fix_multi_location_breakpoint_output_globally):
9624 New variable.
9625 (print_one_breakpoint): Use ui_out::test_flags and new global
9626 variable to compute use_fixed_output.
9627 * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
9628 Remove.
9629 * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
9630 (mi_multi_location_breakpoint_output_fixed): Remove.
9631 (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
9632 new variable.
9633 * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
9634 fix_multi_location_breakpoint_output flag if version >= 3.
9635 * ui-out.h (enum ui_out_flag)
9636 <fix_multi_location_breakpoint_output>: New enumerator.
9637
9638 2019-05-10 Simon Marchi <simon.marchi@efficios.com>
9639
9640 * contrib/cc-with-tweaks.sh: Validate dwz's work.
9641
9642 2019-05-10 Tom Tromey <tromey@adacore.com>
9643
9644 * ada-lang.c (catch_ada_completer): New function.
9645 (_initialize_ada_language): Use it.
9646
9647 2019-05-10 Tom Tromey <tromey@adacore.com>
9648
9649 * thread.c (print_thread_info): Make "requested_threads" const.
9650 * gdbthread.h (print_thread_info): Make "requested_threads"
9651 const.
9652 * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
9653 * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
9654
9655 2019-05-08 Tom Tromey <tom@tromey.com>
9656
9657 * gdbtypes.c (objfile_type_data): Change type.
9658 (objfile_type, _initialize_gdbtypes): Update.
9659
9660 2019-05-08 Tom Tromey <tom@tromey.com>
9661
9662 * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
9663 (dwarf2_frame_find_fde, dwarf2_build_frame_info)
9664 (_initialize_dwarf2_frame): Update.
9665
9666 2019-05-08 Tom Tromey <tom@tromey.com>
9667
9668 * objc-lang.c (objc_objfile_data): Change type.
9669 (find_methods): Update.
9670 (_initialize_objc_lang): Remove.
9671
9672 2019-05-08 Tom Tromey <tom@tromey.com>
9673
9674 * stabsread.c (rs6000_builtin_type_data): Change type.
9675 (rs6000_builtin_type, _initialize_stabsread): Update.
9676
9677 2019-05-08 Tom Tromey <tom@tromey.com>
9678
9679 * mips-tdep.c (mips_pdr_data): Remove.
9680 (_initialize_mips_tdep): Update.
9681
9682 2019-05-08 Tom Tromey <tom@tromey.com>
9683
9684 * hppa-tdep.c (hppa_objfile_priv_data): Change type.
9685 (hppa_init_objfile_priv_data, read_unwind_info)
9686 (find_unwind_entry, _initialize_hppa_tdep): Update.
9687
9688 2019-05-08 Tom Tromey <tom@tromey.com>
9689
9690 * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
9691 (elf_gnu_ifunc_record_cache): Update. Don't allocate hash table
9692 on obstack.
9693 (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
9694
9695 2019-05-08 Tom Tromey <tom@tromey.com>
9696
9697 * mdebugread.c (basic_type_data): Change type.
9698 (basic_type, _initialize_mdebugread): Update.
9699
9700 2019-05-08 Tom Tromey <tom@tromey.com>
9701
9702 * common/gdb_unique_ptr.h (struct noop_deleter): New.
9703
9704 2019-05-08 Tom Tromey <tom@tromey.com>
9705
9706 * nto-tdep.c (nto_inferior_data_reg): Change type.
9707 (nto_inferior_data): Update.
9708 (nto_inferior_data_cleanup, nto_new_inferior_data)
9709 (_initialize_nto_tdep): Remove.
9710 * nto-tdep.h (struct nto_inferior_data): Add initializers.
9711
9712 2019-05-08 Tom Tromey <tom@tromey.com>
9713
9714 * ada-lang.c (struct ada_inferior_data): Add initializers.
9715 (ada_inferior_data): Change type.
9716 (ada_inferior_data_cleanup): Remove.
9717 (get_ada_inferior_data, ada_inferior_exit)
9718 (struct ada_pspace_data): Add initializers, destructor.
9719 (ada_pspace_data_handle): Change type.
9720 (get_ada_pspace_data): Update.
9721 (ada_pspace_data_cleanup): Remove.
9722
9723 2019-05-08 Tom Tromey <tom@tromey.com>
9724
9725 * coffread.c (struct coff_symfile_info): Add initializers.
9726 (coff_objfile_data_key): Move lower. Change type.
9727 (coff_symfile_init, coff_symfile_read, _initialize_coffread):
9728 Update.
9729 (coff_free_info): Remove.
9730
9731 2019-05-08 Tom Tromey <tom@tromey.com>
9732
9733 * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
9734 (fbsd_pspace_data_handle): Move lower. Change type.
9735 (get_fbsd_pspace_data): Update.
9736 (fbsd_pspace_data_cleanup): Remove.
9737 (_initialize_fbsd_tdep): Update.
9738
9739 2019-05-08 Tom Tromey <tom@tromey.com>
9740
9741 * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
9742 (get_ada_tasks_pspace_data): Update.
9743 (ada_tasks_pspace_data_cleanup): Remove.
9744 (_initialize_tasks): Update.
9745 (ada_tasks_inferior_data_handle): Change type.
9746 (get_ada_tasks_inferior_data): Update.
9747 (ada_tasks_inferior_data_cleanup): Remove.
9748 (struct ada_tasks_pspace_data): Add initializers.
9749
9750 2019-05-08 Tom Tromey <tom@tromey.com>
9751
9752 * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
9753 * symfile-debug.c (debug_sym_get_probes): Change type.
9754 * stap-probe.c (handle_stap_probe):
9755 (stap_static_probe_ops::get_probes): Change type.
9756 * probe.h (class static_probe_ops) <get_probes>: Change type.
9757 * probe.c (class any_static_probe_ops) <get_probes>: Change type.
9758 (parse_probes_in_pspace): Update.
9759 (find_probes_in_objfile, find_probe_by_pc, collect_probes):
9760 Update.
9761 (any_static_probe_ops::get_probes): Change type.
9762 * elfread.c (elfread_data): New typedef.
9763 (probe_key): Change type.
9764 (elf_get_probes): Likewise. Update.
9765 (probe_key_free): Remove.
9766 (_initialize_elfread): Update.
9767 * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
9768 Change type.
9769 (dtrace_process_dof_probe, dtrace_process_dof)
9770 (dtrace_static_probe_ops::get_probe): Change type.
9771
9772 2019-05-08 Tom Tromey <tom@tromey.com>
9773
9774 * xcoffread.c (struct xcoff_symfile_info): Rename from
9775 coff_symfile_info. Add initializers.
9776 (xcoff_objfile_data_key): Move lower. Change type.
9777 (XCOFF_DATA): Rewrite.
9778 (xcoff_free_info): Remove.
9779 (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
9780 (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
9781 (xcoff_initial_scan): Update.
9782
9783 2019-05-08 Tom Tromey <tom@tromey.com>
9784
9785 * solib-svr4.c (struct svr4_info): Add initializers and
9786 destructor.
9787 <probes_table>: Now an htab_up.
9788 (solib_svr4_pspace_data): Change type.
9789 (free_probes_table): Simplify.
9790 (~svr4_info): Rename from svr4_pspace_data_cleanup.
9791 (get_svr4_info, probes_table_htab_remove_objfile_probes)
9792 (probes_table_remove_objfile_probes, register_solib_event_probe)
9793 (solib_event_probe_at, svr4_update_solib_event_breakpoint)
9794 (_initialize_svr4_solib): Update.
9795
9796 2019-05-08 Tom Tromey <tom@tromey.com>
9797
9798 * remote.c (remote_pspace_data): Change type.
9799 (remote_pspace_data_cleanup): Remove.
9800 (get_remote_exec_file, set_pspace_remote_exec_file)
9801 (_initialize_remote): Update.
9802
9803 2019-05-08 Tom Tromey <tom@tromey.com>
9804
9805 * breakpoint.c (breakpoint_objfile_key): Change type.
9806 (get_breakpoint_objfile_data): Update.
9807 (free_breakpoint_objfile_data): Remove.
9808 (_initialize_breakpoint): Update.
9809
9810 2019-05-08 Tom Tromey <tom@tromey.com>
9811
9812 * linux-tdep.c (struct linux_info): Add initializers.
9813 (linux_inferior_data): Move. Change type.
9814 (invalidate_linux_cache_inf): Update.
9815 (linux_inferior_data_cleanup): Remove.
9816 (get_linux_inferior_data, _initialize_linux_tdep): Update.
9817
9818 2019-05-08 Tom Tromey <tom@tromey.com>
9819
9820 * auxv.c (auxv_inferior_data): Move. Change type.
9821 (auxv_inferior_data_cleanup): Remove.
9822 (invalidate_auxv_cache_inf): Rewrite.
9823 (get_auxv_inferior_data, _initialize_auxv): Update.
9824
9825 2019-05-08 Tom Tromey <tom@tromey.com>
9826
9827 * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
9828 (symfile_debug_objfile_data_key): Change type.
9829 (symfile_debug_installed, debug_qf_has_symbols)
9830 (debug_qf_find_last_source_symtab)
9831 (debug_qf_forget_cached_source_info)
9832 (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
9833 (debug_qf_print_stats, debug_qf_dump)
9834 (debug_qf_expand_symtabs_for_function)
9835 (debug_qf_expand_all_symtabs)
9836 (debug_qf_expand_symtabs_with_fullname)
9837 (debug_qf_map_matching_symbols)
9838 (debug_qf_expand_symtabs_matching)
9839 (debug_qf_find_pc_sect_compunit_symtab)
9840 (debug_qf_map_symbol_filenames)
9841 (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
9842 (debug_sym_new_init, debug_sym_init, debug_sym_read)
9843 (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
9844 (debug_sym_read_linetable, debug_sym_relocate): Update.
9845 (symfile_debug_free_objfile): Remove.
9846 (install_symfile_debug_logging, _initialize_symfile_debug):
9847 Update.
9848
9849 2019-05-08 Tom Tromey <tom@tromey.com>
9850
9851 * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
9852 allocate_on_obstack.
9853 * dwarf2read.c (dwarf2_objfile_data_key): Change type.
9854 (get_dwarf2_per_objfile): Update.
9855 (set_dwarf2_per_objfile): Remove.
9856 (dwarf2_has_info, dwarf2_get_section_info): Update.
9857 (dwarf2_free_objfile): Remove.
9858 (_initialize_dwarf2_read): Update.
9859
9860 2019-05-08 Tom Tromey <tom@tromey.com>
9861
9862 * auto-load.c (struct auto_load_pspace_info): Add destructor and
9863 initializers.
9864 <unsupported_script_warning_printed,
9865 script_not_found_warning_printed>: Now bool.
9866 (auto_load_pspace_data): Change type.
9867 (~auto_load_pspace_info): Rename from
9868 auto_load_pspace_data_cleanup.
9869 (get_auto_load_pspace_data, init_loaded_scripts_info)
9870 (clear_section_scripts, maybe_print_unsupported_script_warning)
9871 (maybe_print_script_not_found_warning, _initialize_auto_load):
9872 Update.
9873
9874 2019-05-08 Tom Tromey <tom@tromey.com>
9875
9876 * objfiles.c (objfile_pspace_info): Add destructor and
9877 initializers.
9878 (objfiles_pspace_data): Change type.
9879 (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
9880 (get_objfile_pspace_data): Update.
9881 (objfiles_bfd_data): Change type.
9882 (get_objfile_bfd_data): Update.
9883 (objfile_bfd_data_free, _initialize_objfiles): Remove.
9884
9885 2019-05-08 Tom Tromey <tom@tromey.com>
9886
9887 * break-catch-syscall.c (catch_syscall_inferior_data): Move.
9888 Change type.
9889 (get_catch_syscall_inferior_data): Update.
9890 (catch_syscall_inferior_data_cleanup): Remove.
9891 (_initialize_break_catch_syscall): Update.
9892
9893 2019-05-08 Tom Tromey <tom@tromey.com>
9894
9895 * inflow.c (struct terminal_info): Add destructor and
9896 initializers.
9897 (inflow_inferior_data): Change type.
9898 (~terminal_info): Rename from inflow_inferior_data_cleanup.
9899 (get_inflow_inferior_data, inflow_inferior_exit)
9900 (swap_terminal_info, _initialize_inflow): Update.
9901
9902 2019-05-08 Tom Tromey <tom@tromey.com>
9903
9904 * target-dcache.c (target_dcache_cleanup): Remove.
9905 (target_dcache_aspace_key): Change type.
9906 (target_dcache_init_p, target_dcache_invalidate)
9907 (target_dcache_get, target_dcache_get_or_init)
9908 (_initialize_target_dcache): Update.
9909 * dcache.h (struct dcache_deleter): New.
9910
9911 2019-05-08 Tom Tromey <tom@tromey.com>
9912
9913 * symtab.c (struct symbol_cache): Add destructor and
9914 initializers.
9915 (symbol_cache_key): Move. Change type.
9916 (make_symbol_cache, free_symbol_cache): Remove.
9917 (get_symbol_cache): Update.
9918 (symbol_cache_cleanup): Remove.
9919 (ALL_PSPACES, symbol_cache_flush)
9920 (maintenance_print_symbol_cache)
9921 (maintenance_print_symbol_cache_statistics, _initialize_symtab):
9922 Update.
9923
9924 2019-05-08 Tom Tromey <tom@tromey.com>
9925
9926 * symtab.c (struct main_info): Add destructor and initializers.
9927 (main_progspace_key): Move. Change type.
9928 (get_main_info): Update.
9929 (main_info_cleanup): Remove.
9930 (_initialize_symtab): Update.
9931
9932 2019-05-08 Tom Tromey <tom@tromey.com>
9933
9934 * registry.h (DECLARE_REGISTRY): Define the _key class.
9935
9936 2019-05-08 Andrew Burgess <andrew.burgess@embecosm.com>
9937
9938 * NEWS: Merge two 'New commands' sections.
9939
9940 2019-05-08 Joel Brobecker <brobecker@adacore.com>
9941
9942 * ada-valprint.c (ada_val_print_gnat_array): Remove language
9943 parameter and use Ada language definition instead.
9944 (ada_val_print_ptr): Remove unused language parameter.
9945 (ada_val_print_num): Remove language parameter and use Ada language
9946 definition instead.
9947 (ada_val_print_enum, ada_val_print_flt): Remove unused language
9948 parameter.
9949 (ada_val_print_struct_union, ada_val_print_ref): Remove language
9950 parameter and use Ada language definition instead.
9951 (ada_val_print_1): Update all ada_val_print_xxx calls.
9952 Remove language parameter.
9953 (ada_val_print): Update ada_val_print_1 call.
9954
9955 2019-05-08 Tom Tromey <tromey@adacore.com>
9956
9957 * remote.c (remote_hw_watchpoint_limit)
9958 (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
9959 Now static.
9960
9961 2019-05-08 Tom Tromey <tromey@adacore.com>
9962
9963 * maint.c (_initialize_maint_cmds): Move initialization code to
9964 remote.c.
9965 (watchdog, show_watchdog): Move to remote.c.
9966 * remote.c (watchdog, show_watchdog): Move from maint.c. Make
9967 "watchdog" static.
9968 (_initialize_remote): Move initialization code from maint.c.
9969 * defs.h (watchdog): Don't declare.
9970
9971 2019-05-08 Tom Tromey <tromey@adacore.com>
9972
9973 * tui/tui-interp.c: Include main.h.
9974 * interps.c: Include main.h.
9975 * main.h (interpreter_p): Declare.
9976 * defs.h (interpreter_p): Don't declare.
9977
9978 2019-05-08 Tom Tromey <tromey@adacore.com>
9979
9980 * dwarf2loc.c: Include dwarf2read.h.
9981 * defs.h (read_unsigned_leb128): Don't declare.
9982 * dwarf2read.h (read_unsigned_leb128): Declare.
9983
9984 2019-05-08 Tom Tromey <tromey@adacore.com>
9985
9986 * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
9987 method.
9988
9989 2019-05-08 Tom Tromey <tromey@adacore.com>
9990
9991 * utils.c (fputs_maybe_filtered): Reset style after paging, even
9992 when no wrap column is set.
9993
9994 2019-05-08 Tom Tromey <tromey@adacore.com>
9995
9996 * c-lang.c (c_get_string): Handle non-C-style arrays.
9997
9998 2019-05-08 Tom Tromey <tromey@adacore.com>
9999
10000 * typeprint.c (print_offset_data::update): Print the bit offset,
10001 not the number of bits remaining.
10002
10003 2019-05-08 Tom Tromey <tromey@adacore.com>
10004
10005 * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10006 padding at end of comment.
10007
10008 2019-05-08 Tom Tromey <tromey@adacore.com>
10009
10010 * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10011 Compare main types.
10012
10013 2019-05-06 Tom Tromey <tom@tromey.com>
10014
10015 * common/scoped_mmap.c: Include common-defs.h.
10016 * common/scoped_mmap.h: Don't include config.h.
10017
10018 2019-05-04 Tom Tromey <tom@tromey.com>
10019
10020 * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10021 (struct aarch64_call_info): Add initializers.
10022 <si>: Now a std::vector.
10023 (pass_on_stack, aarch64_push_dummy_call): Update.
10024
10025 2019-05-04 Simon Marchi <simon.marchi@efficios.com>
10026 Tom Tromey <tom@tromey.com>
10027
10028 * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10029 (ppc_threads): Now a std::vector. Now static.
10030 (hwdebug_find_thread_points_by_tid)
10031 (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10032 Update.
10033
10034 2019-05-04 Tom Tromey <tom@tromey.com>
10035
10036 * arc-tdep.c (arc_tdesc_init): Return bool.
10037
10038 2019-05-04 Tom Tromey <tom@tromey.com>
10039
10040 * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10041 Use gdb_assert_not_reached.
10042
10043 2019-05-04 Tom Tromey <tom@tromey.com>
10044
10045 * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10046 "false".
10047
10048 2019-05-04 Tom Tromey <tom@tromey.com>
10049
10050 * arc-tdep.c (arc_tdesc_init): Use bool.
10051
10052 2019-05-04 Tom Tromey <tom@tromey.com>
10053
10054 * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10055
10056 2019-05-04 Tom Tromey <tom@tromey.com>
10057
10058 * cli/cli-cmds.c (valid_command_p): Return bool.
10059
10060 2019-05-04 Tom Tromey <tom@tromey.com>
10061
10062 * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10063 * command.h (valid_user_defined_cmd_name_p): Channge return type.
10064
10065 2019-05-04 Raul Tambre <raul@tambre.ee>
10066
10067 * python/lib/gdb/prompt.py (_ExtendedPrompt)
10068 <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10069 operator for comparison.
10070
10071 2019-05-04 Tom Tromey <tom@tromey.com>
10072
10073 * psymtab.c (psymbol_name_matches, match_partial_symbol)
10074 (lookup_partial_symbol, print_partial_symbols)
10075 (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10076 (psymbol_compare): Update.
10077 (add_psymbol_to_bcache): Clear the entire psymbol.
10078 (maintenance_check_psymtabs): Update.
10079 * psympriv.h (struct partial_symbol): Don't derive from
10080 general_symbol_info.
10081 <obj_section, unrelocated_address, address,
10082 set_unrelocated_address>: Update.
10083 <ginfo>: New member.
10084 * dwarf-index-write.c (write_psymbols, debug_names::insert)
10085 (debug_names::write_psymbols): Update.
10086
10087 2019-05-04 Tom de Vries <tdevries@suse.de>
10088
10089 * contrib/cc-with-tweaks.sh: Support -n arg.
10090
10091 2019-05-04 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10092
10093 * corelow.c (core_target::detach): Ensure frame cache and
10094 register caches are cleared.
10095 inferior.c (exit_inferior_1): Likewise.
10096
10097 2019-05-03 Sandra Loosemore <sandra@codesourcery.com>
10098 Tom Tromey <tom@tromey.com>
10099
10100 * dictionary.c (collate_pending_symbols_by_language): Remove
10101 "struct" from foreach.
10102 * symtab.c (lookup_global_symbol_from_objfile)
10103 (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10104 foreach.
10105 * ser-tcp.c (net_open): Remove "struct" from foreach.
10106 * objfiles.c (objfile_relocate, objfile_rebase)
10107 (objfile_has_symbols): Remove "struct" from foreach.
10108 * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10109 from foreach.
10110 * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10111 foreach.
10112 * darwin-nat.c (thread_info_from_private_thread_info): Remove
10113 "struct" from foreach.
10114 * ada-lang.c (create_excep_cond_exprs)
10115 (ada_exception_catchpoint_cond_string): Remove "struct" from
10116 foreach.
10117
10118 2019-05-03 Tom Tromey <tromey@adacore.com>
10119
10120 * ada-exp.y (convert_char_literal): Check suffix of each
10121 enumerator.
10122
10123 2019-05-03 Dilyan Palauzov <dilyan.palauzov@aegee.org>
10124
10125 PR ada/21406:
10126 * ada-exp.y (yywrap): Don't define.
10127 * ada-lex.l (%option): Add noyywrap
10128 (yywrap): Remove.
10129
10130 2019-05-03 Eli Zaretskii <eliz@gnu.org>
10131
10132 * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10133 _WIN32_WINNT to the XP level, unless already defined to a higher
10134 level.
10135
10136 * unittests/parse-connection-spec-selftests.c:
10137 * ser-tcp.c:
10138 * common/netstuff.c [USE_WIN32API]: Remove the _WIN32_WINNT
10139 override.
10140
10141 * symfile.c (find_separate_debug_file): Remove colon from the
10142 drive spec of DOS/Windows file names of the target, so that the
10143 file name produced from DEBUGDIR and the target's directory will
10144 be valid on DOS/Windows systems.
10145
10146 2019-05-02 Andrew Burgess <andrew.burgess@embecosm.com>
10147
10148 * rust-lang.c (val_print_struct): Handle printing structures
10149 containing strings.
10150
10151 2019-05-02 Tom Tromey <tromey@adacore.com>
10152
10153 * valarith.c (_initialize_valarith): Remove.
10154
10155 2019-05-01 Tom Tromey <tromey@adacore.com>
10156
10157 * ada-lang.c (ada_value_primitive_field): Treat more fields as
10158 bitfields.
10159
10160 2019-05-01 Tom Tromey <tromey@adacore.com>
10161
10162 * ada-lang.c (ada_value_assign): Correctly compute starting offset
10163 for big-endian copies.
10164
10165 2019-04-30 Ali Tamur <tamur@google.com>
10166 * gdb/dwarf2read.c (read_3_bytes): New declaration.
10167 (read_attribute_value): Added DW_FORM_strx1-4 cases.
10168 (read_3_bytes): New function.
10169
10170 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10171
10172 * windows-nat.c (main_thread_id): Delete.
10173 (handle_output_debug_string): Replace main_thread_id by
10174 current_event.dwThreadId.
10175 (fake_create_process): Likewise.
10176 (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10177 Do not set main_thread_id.
10178 <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10179 current_event.dwThreadId.
10180 <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10181
10182 2019-04-30 Joel Brobecker <brobecker@adacore.com>
10183
10184 * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10185 Use current_event.dwThreadId instead of main_thread_id.
10186
10187 2019-04-30 Tom Tromey <tromey@adacore.com>
10188
10189 * ada-lang.c (ada_lookup_simple_minsyms): New function.
10190 (create_excep_cond_exprs): Iterate over program spaces.
10191 (ada_exception_catchpoint_cond_string): Examine all minimal
10192 symbols for exception types.
10193
10194 2019-04-30 Tom Tromey <tromey@adacore.com>
10195
10196 PR c++/24470:
10197 * dwarf2read.c (process_structure_scope): Handle case where type
10198 has template parameters but no symbol was created.
10199
10200 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10201 Chris January <chris.january@arm.com>
10202
10203 * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10204 qualifier.
10205 * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10206
10207 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10208
10209 * f-typeprint.c (f_print_type): Update rules for printing
10210 whitespace.
10211 (f_type_print_varspec_suffix): Likewise.
10212
10213 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10214 Chris January <chris.january@arm.com>
10215
10216 * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10217 function arguments.
10218
10219 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10220
10221 * f-lang.c (build_fortran_types): Change name of void type to
10222 lower case.
10223 * f-typeprint.c (f_type_print_base): Print the name of the void
10224 type, rather than a fixed string.
10225 * f-valprint.c (f_decorations): Use lower case void string.
10226
10227 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10228 Chris January <chris.january@arm.com>
10229
10230 * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10231 types for Fortran.
10232
10233 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10234 Chris January <chris.january@arm.com>
10235 David Lecomber <david.lecomber@arm.com>
10236
10237 * f-exp.y (BINOP_INTRINSIC): New token.
10238 (exp): New parser rule handling BINOP_INTRINSIC.
10239 (f77_keywords): Add new builtin procedures.
10240 * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10241 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10242 (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10243 UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10244 (print_unop_subexp_f): New function.
10245 (print_binop_subexp_f): New function.
10246 (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10247 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10248 (dump_subexp_body_f): Likewise.
10249 (operator_check_f): Likewise.
10250 * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10251 BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
10252
10253 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10254
10255 * gdb/expprint.c (dump_subexp_body_standard): Remove use of
10256 UNOP_KIND.
10257 * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
10258 * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
10259 * gdb/f-lang.c (evaluate_subexp_f): Likewise.
10260 (operator_length_f): New fuction.
10261 (print_subexp_f): New function.
10262 (op_name_f): New function.
10263 (dump_subexp_body_f): New function.
10264 (operator_check_f): New function.
10265 (exp_descriptor_f): Replace standard expression handling functions
10266 with new functions.
10267 * gdb/fortran-operator.def: New file.
10268 * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
10269 * gdb/std-operator.def: Remove UNOP_KIND.
10270
10271 2019-04-30 Andrew Burgess <andrew.burgess@embecosm.com>
10272
10273 * std-operator.def: Remove unbalanced, stray double quote
10274 character.
10275
10276 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10277 Chris January <chris.january@arm.com>
10278 Daniel Everett <daniel.everett@arm.com>
10279 Nick Forrington <nick.forrington@arm.com>
10280 Richard Bunt <richard.bunt@arm.com>
10281
10282 * cp-valprint.c (cp_print_value_fields): Allow an additional level
10283 of depth when printing anonymous structs or unions.
10284 * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
10285 Don't print either the top-level value, or the children if the
10286 max-depth is exceeded.
10287 (ppscm_print_children): When printing the key of a map, allow one
10288 extra level of depth.
10289 * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
10290 print either the top-level value, or the children if the max-depth
10291 is exceeded.
10292 (print_children): When printing the key of a map, allow one extra
10293 level of depth.
10294 * python/py-value.c (valpy_format_string): Add max_depth keyword.
10295 * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
10296 (user_print_options): Initialise max_depth field.
10297 (val_print_scalar_or_string_type_p): New function.
10298 (val_print): Check to see if the max depth has been reached.
10299 (val_print_check_max_depth): Define new function.
10300 (show_print_max_depth): New function.
10301 (_initialize_valprint): Add 'print max-depth' option.
10302 * valprint.h (struct value_print_options) <max_depth>: New field.
10303 (val_print_check_max_depth): Declare new function.
10304 * NEWS: Document new feature.
10305
10306 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10307
10308 * ada-lang.c (ada_language_defn): Initialise new field.
10309 * c-lang.c (c_is_string_type_p): New function.
10310 (c_language_defn): Initialise new field.
10311 (cplus_language_defn): Initialise new field.
10312 (asm_language_defn): Initialise new field.
10313 (minimal_language_defn): Initialise new field.
10314 * c-lang.h (c_is_string_type_p): Declare new function.
10315 * d-lang.c (d_language_defn): Initialise new field.
10316 * f-lang.c (f_is_string_type_p): New function.
10317 (f_language_defn): Initialise new field.
10318 * go-lang.c (go_is_string_type_p): New function.
10319 (go_language_defn): Initialise new field.
10320 * language.c (default_is_string_type_p): New function.
10321 (unknown_language_defn): Initialise new field.
10322 (auto_language_defn): Initialise new field.
10323 * language.h (struct language_defn) <la_is_string_type_p>: New
10324 member variable.
10325 (default_is_string_type_p): Declare new function.
10326 * m2-lang.c (m2_language_defn): Initialise new field.
10327 * objc-lang.c (objc_language_defn): Initialise new field.
10328 * opencl-lang.c (opencl_language_defn): Initialise new field.
10329 * p-lang.c (pascal_is_string_type_p): New function.
10330 (pascal_language_defn): Initialise new field.
10331 * rust-lang.c (rust_is_string_type_p): New function.
10332 (rust_language_defn): Initialise new field.
10333
10334 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10335
10336 * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
10337 New field.
10338 * ada-lang.c (ada_language_defn): Initialise new field.
10339 * c-lang.c (c_language_defn): Likewise.
10340 (cplus_language_defn): Likewise.
10341 (asm_language_defn): Likewise.
10342 (minimal_language_defn): Likewise.
10343 * d-lang.c (d_language_defn): Likewise.
10344 * f-lang.c (f_language_defn): Likewise.
10345 * go-lang.c (go_language_defn): Likewise.
10346 * language.c (unknown_language_defn): Likewise.
10347 (auto_language_defn): Likewise.
10348 * m2-lang.c (m2_language_defn): Likewise.
10349 * objc-lang.c (objc_language_defn): Likewise.
10350 * opencl-lang.c (opencl_language_defn): Likewise.
10351 * p-lang.c (pascal_language_defn): Likewise.
10352 * rust-lang.c (rust_language_defn): Likewise.
10353
10354 2019-04-29 Andrew Burgess <andrew.burgess@embecosm.com>
10355
10356 * ada-lang.c (ada_is_character_type): Change return type to bool.
10357 (ada_is_string_type): Likewise.
10358 * ada-lang.h (ada_is_character_type): Update declaration
10359 (ada_is_string_type): Likewise.
10360
10361 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10362
10363 Support style in 'frame|thread apply'
10364
10365 * gdbcmd.h (execute_command_to_string): New term_out parameter.
10366 * record.c (record_start, record_stop): Update callers of
10367 execute_command_to_string with false.
10368 * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
10369 * ui-file.h (class ui_file): New term_out and can_emit_style_escape
10370 methods.
10371 (class string_file): New constructor with term_out parameter.
10372 Override methods term_out and can_emit_style_escape. New member
10373 term_out.
10374 (class stdio_file): Override can_emit_style_escape.
10375 (class tee_file): Override term_out and can_emit_style_escape.
10376 * utils.h (can_emit_style_escape): Remove.
10377 * utils.c (can_emit_style_escape): Likewise.
10378 Update all callers of can_emit_style_escape (SOMESTREAM) to
10379 SOMESTREAM->can_emit_style_escape.
10380 * source-cache.c (source_cache::get_source_lines): Likewise.
10381 * stack.c (frame_apply_command_count): Call execute_command_to_string
10382 passing the term_out characteristic of the current gdb_stdout.
10383 * thread.c (thr_try_catch_cmd): Likewise.
10384 * top.c (execute_command_to_string): pass term_out parameter
10385 to construct the string_file for the command output.
10386 * ui-file.c (term_cli_styling): New function (most code moved
10387 from utils.c can_emit_style_escape).
10388 (string_file::string_file, string_file::can_emit_style_escape,
10389 stdio_file::can_emit_style_escape, tee_file::term_out,
10390 tee_file::can_emit_style_escape): New functions.
10391
10392 2019-04-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10393
10394 * NEWS: Mention the new set|show may-call-functions.
10395 * infcall.c (may_call_functions_p): New variable.
10396 (show_may_call_functions_p): New function.
10397 (call_function_by_hand_dummy): Throws an error if not
10398 may-call-functions.
10399 (_initialize_infcall): Call add_setshow_boolean_cmd for
10400 may-call-functions.
10401
10402 2019-04-25 Keith Seitz <keiths@redhat.com>
10403
10404 PR c++/24367
10405 * cp-support.c (inspect_type): Don't attempt substitutions
10406 of symbol with the same name.
10407
10408 2019-04-25 Tom Tromey <tromey@adacore.com>
10409
10410 PR gdb/24475:
10411 * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
10412 static.
10413
10414 2019-04-25 Tom Tromey <tromey@adacore.com>
10415
10416 * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
10417 rvalue reference.
10418 (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
10419 (gdb_xml_parser::parse): Use std::move.
10420 * python/python-internal.h (gdbpy_convert_exception): Take a const
10421 reference.
10422 * python/py-value.c (valpy_getitem, valpy_nonzero): Use
10423 std::move.
10424 * python/py-utils.c (gdbpy_convert_exception): Take a const
10425 reference.
10426 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10427 Use std::move.
10428 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10429 Use std::move.
10430 * mi/mi-main.c (mi_print_exception): Take a const reference.
10431 * main.c (handle_command_errors): Take a const reference.
10432 * linespec.c (parse_linespec): Use std::move.
10433 * infcall.c (run_inferior_call): Use std::move.
10434 (call_function_by_hand_dummy): Use std::move.
10435 * exec.c (try_open_exec_file): Use std::move.
10436 * exceptions.h (exception_print, exception_fprintf)
10437 (exception_print_same): Update.
10438 * exceptions.c (print_exception, exception_print)
10439 (exception_fprintf, exception_print_same): Change parameters to
10440 const reference.
10441 * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
10442 * common/new-op.c: Use std::move.
10443 * common/common-exceptions.h (struct gdb_exception): Add move
10444 constructor.
10445 (struct gdb_exception_error, struct gdb_exception_quit, struct
10446 gdb_quit_bad_alloc): Change constructor to move constructor.
10447 (throw_exception): Change parameter to rvalue reference.
10448 * common/common-exceptions.c (throw_exception): Take rvalue
10449 reference.
10450 * cli/cli-interp.c (safe_execute_command): Use std::move.
10451 * breakpoint.c (insert_bp_location, location_to_sals): Use
10452 std::move.
10453
10454 2019-04-25 Tom Tromey <tromey@adacore.com>
10455
10456 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
10457 (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
10458 * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
10459 guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
10460 guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
10461 guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
10462 guile/scm-value.c: Use unpack.
10463 * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
10464 gdbscm_gdb_exception.
10465 (gdbscm_throw_gdb_exception): Likewise.
10466 (struct gdbscm_gdb_exception): New.
10467 (unpack): New function.
10468 (gdbscm_wrap): Use unpack.
10469
10470 2019-04-25 Tom Tromey <tromey@adacore.com>
10471
10472 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10473 (gdb_rl_callback_handler): Use std::move.
10474 * common/common-exceptions.h (struct gdb_exception): Add move
10475 assignment operator.
10476 (throw_exception_sjlj): Change "exception" to const reference.
10477 * common/common-exceptions.c (exceptions_state_mc_catch): Update.
10478 (throw_exception_sjlj): Change "exception" to const reference.
10479
10480 2019-04-25 Tom Tromey <tromey@adacore.com>
10481
10482 * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
10483 * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
10484 * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
10485 Update.
10486 * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
10487 Update.
10488 * mi/mi-interp.c (mi_interp::exec): Update.
10489 * linespec.c (parse_linespec): Update.
10490 * infcall.c (run_inferior_call): Update.
10491 * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
10492 * guile/scm-symbol.c (gdbscm_lookup_symbol)
10493 (gdbscm_lookup_global_symbol): Update.
10494 * guile/scm-param.c (gdbscm_parameter_value): Update.
10495 * guile/scm-frame.c (gdbscm_frame_read_register)
10496 (gdbscm_frame_read_var): Update.
10497 * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
10498 * exec.c (try_open_exec_file): Update.
10499 * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
10500 (gdb_rl_callback_handler): Update.
10501 * common/common-exceptions.h (exception_none): Don't declare.
10502 * common/common-exceptions.c (exception_none): Don't define.
10503 (struct catcher) <exception>: Update.
10504 * cli/cli-interp.c (safe_execute_command): Update.
10505 * breakpoint.c (insert_bp_location, location_to_sals): Update.
10506
10507 2019-04-25 Ali Tamur <tamur@google.com>
10508
10509 * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
10510 (read_attribute_value): Likewise.
10511 (dwarf2_read_addr_index): Update comment.
10512 (read_str_index): Add DW_FORM_strx.
10513 (dwarf2_string_attr): Likewise.
10514 (dwarf2_const_value_attr): Likewise.
10515 (dump_die_shallow): Likewise.
10516 (dwarf2_fetch_constant_bytes): Likewise.
10517 (skip_form_bytes): Likewise.
10518 * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
10519
10520 2019-04-25 Sergio Durigan Junior <sergiodj@redhat.com>
10521
10522 PR corefiles/11608
10523 PR corefiles/18187
10524 * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
10525 OFFSET. Verify if current mapping contains an ELF header.
10526 (linux_find_memory_regions_full): Adjust call to
10527 dump_mapping_p.
10528
10529 2019-04-25 Sandra Loosemore <sandra@codesourcery.com>
10530 Kang Li <kanglictf@gmail.com>
10531
10532 PR gdb/21600
10533
10534 * dwarf2-frame.c (read_initial_length): Be consistent about using
10535 unsigned representation of length.
10536 (decode_frame_entry_1): Likewise. Check for wraparound of
10537 end pointer as well as buffer overflow.
10538
10539 2019-04-24 Sergio Durigan Junior <sergiodj@redhat.com>
10540
10541 * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
10542 "vq".
10543
10544 2019-04-24 Tom Tromey <tromey@adacore.com>
10545
10546 * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
10547
10548 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10549
10550 * s12z-tdep.c (s12z_unwind_pc): Delete.
10551 (s12z_unwind_sp): Delete.
10552 (s12z_gdbarch_init): Don't register deleted functions with
10553 gdbarch.
10554
10555 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10556
10557 * rl78-tdep.c (rl78_unwind_sp): Delete.
10558 (rl78_gdbarch_init): Don't register deleted function with gdbarch.
10559
10560 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10561
10562 * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
10563 (xstormy16_unwind_pc): Delete.
10564 (xstormy16_dummy_id): Delete.
10565 (xstormy16_gdbarch_init): Don't register deleted functions with
10566 gdbarch.
10567
10568 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10569
10570 * vax-tdep.c (vax_unwind_pc): Delete.
10571 (vax_gdbarch_init): Don't register deleted function with gdbarch.
10572
10573 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10574
10575 * v850-tdep.c (v850_unwind_sp): Delete.
10576 (v850_unwind_pc): Delete.
10577 (v850_dummy_id): Delete.
10578 (v850_gdbarch_init): Don't register deleted functions with
10579 gdbarch.
10580
10581 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10582
10583 * tilegx-tdep.c (tilegx_unwind_sp): Delete.
10584 (tilegx_unwind_pc): Delete.
10585 (tilegx_unwind_dummy_id): Delete.
10586 (tilegx_gdbarch_init): Don't register deleted functions with
10587 gdbarch.
10588
10589 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10590
10591 * tic6x-tdep.c (tic6x_unwind_sp): Delete.
10592 (tic6x_dummy_id): Delete.
10593 (tic6x_gdbarch_init): Don't register deleted functions with
10594 gdbarch.
10595
10596 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10597
10598 * sparc-tdep.c (sparc_unwind_pc): Delete.
10599 (sparc32_gdbarch_init): Don't register deleted function with
10600 gdbarch.
10601
10602 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10603
10604 * sh-tdep.c (sh_unwind_sp): Delete.
10605 (sh_unwind_pc): Delete.
10606 (sh_dummy_id): Delete.
10607 (sh_gdbarch_init): Don't register deleted functions with
10608 gdbarch.
10609
10610 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10611
10612 * score-tdep.c (score_unwind_sp): Delete.
10613 (score_unwind_pc): Delete.
10614 (score_dummy_id): Delete.
10615 (score_gdbarch_init): Don't register deleted functions with
10616 gdbarch.
10617
10618 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10619
10620 * rx-tdep.c (rx_unwind_pc): Delete.
10621 (rx_unwind_sp): Delete.
10622 (rx_dummy_id): Delete.
10623 (rx_gdbarch_init): Don't register deleted functions with
10624 gdbarch. Update comment.
10625
10626 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10627
10628 * rs6000-tdep.c (rs6000_unwind_pc): Delete.
10629 (rs6000_dummy_id): Delete.
10630 (rs6000_gdbarch_init): Don't register deleted functions with
10631 gdbarch.
10632
10633 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10634
10635 * or1k-tdep.c (or1k_dummy_id): Delete.
10636 (or1k_gdbarch_init): Don't register deleted function with gdbarch.
10637
10638 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10639
10640 * nios2-tdep.c (nios2_dummy_id): Delete.
10641 (nios2_unwind_sp): Delete.
10642 (nios2_gdbarch_init): Don't register deleted functions with
10643 gdbarch.
10644
10645 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10646
10647 * nds32-tdep.c (nds32_dummy_id): Delete.
10648 (nds32_unwind_pc): Delete.
10649 (nds32_unwind_sp): Delete.
10650 (nds32_gdbarch_init): Don't register deleted functions with
10651 gdbarch.
10652
10653 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10654
10655 * msp430-tdep.c (msp430_unwind_pc): Delete.
10656 (msp430_unwind_sp): Delete.
10657 (msp430_dummy_id): Delete.
10658 (msp430_gdbarch_init): Don't register deleted functions with
10659 gdbarch.
10660
10661 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10662
10663 * moxie-tdep.c (moxie_unwind_sp): Delete.
10664 (moxie_unwind_pc): Delete.
10665 (moxie_dummy_id): Delete.
10666 (moxie_gdbarch_init): Don't register deleted functions with
10667 gdbarch.
10668
10669 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10670
10671 * mn10300-tdep.c (mn10300_dummy_id): Delete.
10672 (mn10300_unwind_pc): Delete.
10673 (mn10300_unwind_sp): Delete.
10674 (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
10675 mn10300_unwind_sp.
10676 (mn10300_frame_unwind_init): Don't register deleted functions with
10677 gdbarch.
10678
10679 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10680
10681 * mep-tdep.c (mep_unwind_pc): Delete.
10682 (mep_unwind_sp): Delete.
10683 (mep_dummy_id): Delete.
10684 (mep_gdbarch_init): Don't register deleted functions with
10685 gdbarch.
10686
10687 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10688
10689 * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
10690 (m68hc11_unwind_sp): Delete.
10691 (m68hc11_gdbarch_init): Don't register deleted functions with
10692 gdbarch.
10693
10694 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10695
10696 * m32r-tdep.c (m32r_unwind_sp): Delete.
10697 (m32r_unwind_pc): Delete.
10698 (m32r_dummy_id): Delete.
10699 (m32r_gdbarch_init): Don't register deleted functions with
10700 gdbarch.
10701
10702 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10703
10704 * m32c-tdep.c (m32c_unwind_pc): Delete.
10705 (m32c_unwind_sp): Delete.
10706 (m32c_dummy_id): Delete.
10707 (m32c_gdbarch_init): Don't register deleted functions with
10708 gdbarch.
10709
10710 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10711
10712 * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
10713 (lm32_unwind_pc): Delete.
10714 (lm32_dummy_id): Delete.
10715 (lm32_gdbarch_init): Don't register deleted functions with
10716 gdbarch.
10717
10718 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10719
10720 * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
10721 (iq2000_unwind_pc): Delete.
10722 (iq2000_dummy_id): Delete.
10723 (iq2000_gdbarch_init): Don't register deleted functions with
10724 gdbarch.
10725
10726 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10727
10728 * nds32-tdep.c (nds32_type_align): Delete.
10729 (nds32_push_dummy_call): Use type_align instead.
10730
10731 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10732
10733 * arm-tdep.c (arm_type_align): Only handle vector override case.
10734 (arm_push_dummy_call): Use type_align.
10735 (arm_gdbarch_init): Register arm_type_align gdbarch function.
10736
10737 2019-04-23 Andrew Burgess <andrew.burgess@embecosm.com>
10738
10739 * aarch64-tdep.c (aarch64_type_align): Only handle vector override
10740 case.
10741 (pass_on_stack): Use type_align.
10742 (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
10743 function.
10744
10745 2019-04-23 Tom Tromey <tromey@adacore.com>
10746
10747 * dwarf2read.c (line_header::file_name_at): Remove unused
10748 overload.
10749
10750 2019-04-23 Tom de Vries <tdevries@suse.de>
10751
10752 PR gdb/24438
10753 * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
10754 invocation.
10755
10756
10757 2019-03-27 Ali Tamur <tamur@google.com>
10758
10759 * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
10760 * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
10761 * dwarf2expr.h(dwarf_expr_context::offset): Update comment
10762 (dwarf_expr_context::get_addr_index): Likewise
10763 * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
10764 (symbol_needs_eval_context::get_addr_index): Likewise
10765 (disassemble_dwarf_expression): Add DW_OP_addrx
10766 * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
10767 (read_cutu_die_from_dwo): Update comment
10768 (skip_one_die): Add DW_FORM_addrx
10769 (read_attribute_value): Likewise
10770 (var_decode_location): Add DW_OP_addrx
10771 (dwarf2_const_value_attr): Add DW_FORM_addrx
10772 (dump_die_shallow): Likewise
10773 (dwarf2_fetch_constant_bytes): Likewise
10774 (decode_locdesc): Add DW_OP_addrx
10775 (skip_form_bytes): Add DW_FORM_addrx
10776
10777 2019-04-22 Ali Tamur <tamur@google.com>
10778
10779 * MAINTAINERS (Write After Approval): Add self.
10780
10781 2019-04-22 Simon Marchi <simon.marchi@efficios.com>
10782
10783 * solib-svr4.c (get_svr4_info): Add pspace parameter.
10784 (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
10785 (open_symbol_file_object): Likewise.
10786 (svr4_default_sos): Add info parameter.
10787 (svr4_read_so_list): Likewise.
10788 (svr4_current_sos_direct): Adjust functions calls to pass down
10789 info.
10790 (svr4_current_sos_1): Add info parameter.
10791 (svr4_current_sos): Call get_svr4_info, pass info down to
10792 svr4_current_sos_1.
10793 (svr4_fetch_objfile_link_map): Pass objfile->pspace to
10794 get_svr4_info.
10795 (svr4_in_dynsym_resolve_code): Pass current_program_space to
10796 get_svr4_info.
10797 (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
10798 to get_svr4_info.
10799 (probes_table_remove_objfile_probes): Likewise.
10800 (register_solib_event_probe): Add info parameter.
10801 (solist_update_incremental): Pass info parameter down to
10802 svr4_read_so_list.
10803 (disable_probes_interface): Add info parameter.
10804 (svr4_handle_solib_event): Pass current_program_space to
10805 get_svr4_info. Adjust disable_probes_interface cleanup.
10806 (svr4_create_probe_breakpoints): Add info parameter, pass it
10807 down to register_solib_event_probe.
10808 (svr4_create_solib_event_breakpoints): Add info parameter,
10809 pass it down to svr4_create_probe_breakpoints.
10810 (enable_break): Pass info down to
10811 svr4_create_solib_event_breakpoints.
10812 (svr4_solib_create_inferior_hook): Pass current_program_space to
10813 get_svr4_info.
10814 (svr4_clear_solib): Likewise.
10815
10816 2019-04-22 Pedro Alves <palves@redhat.com>
10817
10818 * solib-svr4.c (svr4_free_objfile_observer): New.
10819 (probe_and_action::objfile): New field.
10820 (probes_table_htab_remove_objfile_probes)
10821 (probes_table_remove_objfile_probes): New functions.
10822 (register_solib_event_probe): Add 'objfile' parameter. Store it
10823 in the new probe_and_action. Don't store the probe in 'lookup'.
10824 (svr4_create_probe_breakpoints): Pass objfile to
10825 register_solib_event_probe.
10826 (_initialize_svr4_solib): Register a free_objfile observer.
10827
10828 2019-04-19 Tom Tromey <tom@tromey.com>
10829
10830 * common/queue.h: Remove.
10831
10832 2019-04-19 Tom Tromey <tom@tromey.com>
10833
10834 * event-loop.c: Don't include "common/queue.h".
10835
10836 2019-04-19 Tom Tromey <tom@tromey.com>
10837
10838 * remote.c (remote_target): Use delete.
10839 * remote-notif.h: Include <list>, not "common/queue.h".
10840 (notif_client_p): Remove typedef.
10841 (remote_notif_state): Add constructor, destructor, initializer.
10842 <notif_queue>: Now a std::list.
10843 (remote_notif_state_xfree): Don't declare.
10844 * remote-notif.c (remote_notif_process, handle_notification)
10845 (remote_notif_state_allocate): Update.
10846 (~remote_notif_state): Rename from remote_notif_state_xfree.
10847
10848 2019-04-19 Tom Tromey <tom@tromey.com>
10849
10850 * symfile.c (reread_symbols): Update.
10851 * objfiles.c (objfile_register_static_link)
10852 (objfile_lookup_static_link): Update
10853 (~objfile) Don't delete static_links.
10854 * objfiles.h (struct objfile) <static_links>: Now an htab_up.
10855
10856 2019-04-19 Tom Tromey <tom@tromey.com>
10857
10858 * type-stack.h (struct type_stack) <insert>: Constify string.
10859 * type-stack.c (type_stack::insert): Constify string.
10860 * gdbtypes.h (lookup_template_type): Update.
10861 (address_space_name_to_int): Update.
10862 * gdbtypes.c (address_space_name_to_int): Make space_identifier
10863 const.
10864 (lookup_template_type): Make name const.
10865 * c-exp.y: Update rules.
10866 (lex_one_token, classify_name, classify_inner_name)
10867 (c_print_token): Update.
10868 * p-exp.y: Update rules.
10869 (yylex): Update.
10870 * f-exp.y: Update rules.
10871 (yylex): Update.
10872 * d-exp.y: Update rules.
10873 (lex_one_token, classify_name, classify_inner_name): Update.
10874 * parse.c (write_dollar_variable, copy_name): Return std::string.
10875 * parser-defs.h (copy_name): Change return type.
10876 * m2-exp.y: Update rules.
10877 (yylex): Update.
10878 * go-exp.y (lex_one_token): Update.
10879 Update rules.
10880 (classify_unsafe_function, classify_packaged_name)
10881 (classify_name, yylex): Update.
10882
10883 2019-04-19 Sergei Trofimovich <siarheit@google.com>
10884
10885 * configure.ac: add --enable-source-highlight switch.
10886 * configure: Regenerate.
10887 * top.c (print_gdb_version): plumb --enable-source-highlight
10888 status to "show configuration".
10889
10890 2019-04-19 Tom Tromey <tromey@adacore.com>
10891
10892 * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
10893 Check ADA_TYPE_P.
10894 (empty_record, ada_template_to_fixed_record_type_1)
10895 (template_to_static_fixed_type)
10896 (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
10897 * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
10898 * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
10899 macros.
10900
10901 2019-04-19 Ilya Yu. Malakhov <malakhov@mcst.ru>
10902
10903 PR symtab/24423:
10904 * source.c (print_source_lines_base): Advance "iter" when a
10905 control character is seen.
10906
10907 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10908
10909 * inferior.h (struct infcall_suspend_state_deleter):
10910 Catch exception in destructor to avoid crash.
10911
10912 2019-04-19 Philippe Waroquiers <philippe.waroquiers@skynet.be>
10913
10914 * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
10915 close to the add_com "shell".
10916
10917 2019-04-18 Tom Tromey <tromey@adacore.com>
10918
10919 * process-stratum-target.h (class process_stratum_target)
10920 <stratum>: Add "final".
10921
10922 2019-04-17 Tom Tromey <tromey@adacore.com>
10923
10924 * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
10925 against nullptr before use.
10926
10927 2019-04-17 Alan Hayward <alan.hayward@arm.com>
10928
10929 * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
10930
10931 2019-04-17 Jim Wilson <jimw@sifive.com>
10932 Andrew Burgess <andrew.burgess@embecosm.com>
10933
10934 * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
10935 code read might fail, assume 4-byte breakpoint in that case.
10936
10937 2019-04-15 Leszek Swirski <leszeks@google.com>
10938
10939 * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
10940 rather than a hand-rolled POD check when checking for forced MEMORY
10941 classification.
10942
10943 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10944
10945 * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
10946 * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
10947 function.
10948 (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
10949 (aarch64_sve_regs_copy_from_reg_buf): Likewise.
10950 * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
10951 declaration.
10952
10953 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10954
10955 * aarch64-linux-nat.c
10956 (aarch64_linux_nat_target::thread_architecture): Add override.
10957 * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
10958 each VQ.
10959
10960 2019-04-15 Alan Hayward <alan.hayward@arm.com>
10961
10962 * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
10963
10964 2019-04-13 Andrew Burgess <andrew.burgess@embecosm.com>
10965
10966 * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
10967 target types of size 96-bits, add some additional comments, and
10968 check that the builtin type we found was the correct size.
10969
10970 2019-04-12 Eli Zaretskii <eliz@gnu.org>
10971
10972 * utils.c (prompt_for_continue): Don't restore the styling at the
10973 end, as applied_style has the wrong value. This fixes styling in
10974 long lists of file names that are interrupted by the "Continue?"
10975 prompt.
10976
10977 2019-04-12 Andrew Burgess <andrew.burgess@embecosm.com>
10978
10979 * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
10980 * c-lang.c (c_language_defn): Likewise.
10981 (cplus_language_defn): Likewise.
10982 (asm_language_defn): Likewise.
10983 (minimal_language_defn): Likewise.
10984 * d-lang.c (d_language_defn): Likewise.
10985 * f-lang.c (f_language_defn): Likewise.
10986 * go-lang.c (go_language_defn): Likewise.
10987 * language.c (unknown_language_defn): Likewise.
10988 (auto_language_defn): Likewise.
10989 * language.h (struct language_defn): Remove la_magic field.
10990 (LANG_MAGIC): Delete.
10991 * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
10992 * objc-lang.c (objc_language_defn): Likewise.
10993 * opencl-lang.c (opencl_language_defn): Likewise.
10994 * p-lang.c (pascal_language_defn): Likewise.
10995 * rust-lang.c (rust_language_defn): Likewise.
10996
10997 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
10998
10999 * riscv-tdep.c (riscv_type_align): New function.
11000 (riscv_type_alignment): Delete.
11001 (riscv_arg_location): Use 'type_align'.
11002 (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11003
11004 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11005
11006 * gdbtypes.c (type_align): A struct with no non-static fields also
11007 has alignment of 1.
11008
11009 2019-04-11 Andrew Burgess <andrew.burgess@embecosm.com>
11010
11011 * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11012 component to 0.
11013 (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11014 member.
11015 (riscv_struct_info::analyse): New implementation using new
11016 analyse_inner member function.
11017 (riscv_struct_info::field_offset): New member function.
11018 (riscv_struct_info::m_offsets): New member variable.
11019 (riscv_struct_info::analyse_inner): New private member function,
11020 takes the old implementation of riscv_struct_info::analyse but
11021 extended to track field offsets.
11022 (riscv_call_arg_struct): Update the struct folding special cases
11023 to handle cases where empty C++ structs, which are non-zero
11024 length, are found.
11025 (riscv_arg_location): Initialise the length of each location, a
11026 non-zero length now indicates the location is in use.
11027 (riscv_push_dummy_call): Allow for the first location having a
11028 non-zero offset when setting up arguments.
11029 (riscv_return_value): Likewise, but for return values.
11030
11031 2019-04-11 Tom Tromey <tromey@adacore.com>
11032
11033 * utils.c (internal_vproblem): Make "msg" const.
11034
11035 2019-04-11 Alan Hayward <alan.hayward@arm.com>
11036
11037 * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11038 * trad-frame.c (trad_frame_reset_saved_regs): New function.
11039 (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11040 * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11041
11042 2019-04-10 Kevin Buettner <kevinb@redhat.com>
11043
11044 * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11045 function.
11046 (fill_gregset): Call amd64_linux_collect_native_gregset instead
11047 of amd64_collect_native_gregset.
11048 (amd64_linux_nat_target::store_registers): Likewise.
11049
11050 2019-04-10 Tom Tromey <tom@tromey.com>
11051
11052 * symtab.c (lookup_global_symbol_from_objfile)
11053 (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11054 * objfiles.h (class separate_debug_iterator): New.
11055 (class separate_debug_range): New.
11056 (struct objfile) <separate_debug_objfiles>: New method.
11057 (objfile_separate_debug_iterate): Don't declare.
11058 * objfiles.c (separate_debug_iterator::operator++): Rename from
11059 objfile_separate_debug_iterate.
11060 (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11061 iterator.
11062 * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11063 iterator.
11064
11065 2019-04-10 Tom Tromey <tom@tromey.com>
11066
11067 * symfile.c (reread_symbols): Remove old comment.
11068 * objfiles.c (free_all_objfiles): Fix a typo.
11069
11070 2019-04-10 Tom Tromey <tom@tromey.com>
11071
11072 * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11073 * minsyms.c (lookup_minimal_symbol): Use foreach.
11074 (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11075 (lookup_minimal_symbol_solib_trampoline): Likewise.
11076 * symfile.c (reread_symbols): Use foreach.
11077
11078 2019-04-09 Ivan Begert <ivanbegert@gmail.com>
11079 Tom Tromey <tromey@adacore.com>
11080
11081 PR rust/24414:
11082 * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11083 (rust_lex_int_test): Change "value" to be LONGEST.
11084 (rust_lex_tests): Add test for long integer literal.
11085
11086 2019-04-09 Tom Tromey <tromey@adacore.com>
11087
11088 * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11089 to bool.
11090 (extended_remote_target::attach): Update.
11091 (remote_target::remote_notice_new_inferior): Update.
11092 (remote_target::add_current_inferior_and_thread): Update.
11093 * inferior.c (exit_inferior_1): Use "false".
11094 * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11095
11096 2019-04-09 Simon Marchi <simon.marchi@efficios.com>
11097
11098 * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11099 the "start" command.
11100
11101 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11102
11103 * python/py-inferior.c (infpy_thread_from_thread_handle):
11104 Adjust comments to reflect renaming of thread_from_thread_handle
11105 to thread_from_handle. Adjust keywords. Fix type error message.
11106 (inferior_object_methods): Add thread_from_handle. Retain
11107 thread_from_thread_handle, but mark it as deprecated.
11108
11109 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11110
11111 * gdbthread.h (find_thread_by_handle): Revise declaration.
11112 * thread.c (find_thread_by_handle): Likewise. Adjust
11113 implementation too.
11114 * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11115 support for buffer objects as handles.
11116
11117 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11118
11119 * python/py-infthread.c (thpy_thread_handle): New function.
11120 (thread_object_methods): Register thpy_thread_handle.
11121
11122 2019-04-08 Kevin Buettner <kevinb@redhat.com>
11123
11124 * gdbthread.h (thread_to_thread_handle): Declare.
11125 * thread.c (gdbtypes.h): Include.
11126 (thread_to_thread_handle): New function.
11127
11128 * target.h (struct target_ops): Add thread_info_to_thread_handle.
11129 (target_thread_info_to_thread_handle): Declare.
11130 * target.c (target_thread_info_to_thread_handle): New function.
11131 * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11132 * target-delegates.c: Regenerate.
11133
11134 * linux-thread-db.c (class thread_db_target): Add method
11135 thread_info_to_thread_handle.
11136 (thread_db_target::thread_info_to_thread_handle): Define.
11137 * remote.c (class remote_target): Add new method
11138 thread_info_to_thread_handle.
11139 (remote_target::thread_info_to_thread_handle): Define.
11140
11141 2019-04-08 Pedro Alves <palves@redhat.com>
11142
11143 * common/common-exceptions.c (throw_exception): Don't create
11144 named object to throw; throw directly.
11145 (throw_it): Likewise. Don't initialize gdb_exception::message
11146 here, with new; pass FMT and AP to the ctor instead.
11147 * common/common-exceptions.h: Include <string>.
11148 (gdb_exception::gdb_exception(enum return_reason, enum errors,
11149 const char *, va_list)): New ctor. Use std::make_shared.
11150 (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11151 errors)): Delete.
11152 (gdb_exception_error::gdb_exception_error(enum errors, const char
11153 *, va_list)): New.
11154 (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11155 Add assertion.
11156 (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11157 errors)): Delete.
11158 (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11159 (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11160 Add assertion.
11161
11162 2019-04-08 Tom Tromey <tom@tromey.com>
11163
11164 * valops.c (value_rtti_indirect_type): Replace throw_exception
11165 with throw.
11166 * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11167 with throw.
11168 * thread.c (thr_try_catch_cmd): Replace throw_exception with
11169 throw.
11170 * target.c (target_translate_tls_address): Replace throw_exception
11171 with throw.
11172 * stack.c (frame_apply_command_count): Replace throw_exception
11173 with throw.
11174 * solib-spu.c (append_ocl_sos): Replace throw_exception with
11175 throw.
11176 * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11177 with throw.
11178 * rs6000-tdep.c (rs6000_frame_cache)
11179 (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11180 * remote.c: Replace throw_exception with throw.
11181 * record-full.c (record_full_message, record_full_wait_1)
11182 (record_full_restore): Replace throw_exception with throw.
11183 * record-btrace.c:
11184 (get_thread_current_frame_id, record_btrace_start_replaying)
11185 (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11186 (cmd_record_btrace_start): Replace throw_exception with throw.
11187 * parse.c (parse_exp_in_context_1): Replace throw_exception with
11188 throw.
11189 * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11190 (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11191 * linespec.c:
11192 (find_linespec_symbols): Replace throw_exception with throw.
11193 * infrun.c (displaced_step_prepare, resume): Replace
11194 throw_exception with throw.
11195 * infcmd.c (post_create_inferior): Replace throw_exception with
11196 throw.
11197 * inf-loop.c (inferior_event_handler): Replace throw_exception
11198 with throw.
11199 * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11200 (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11201 * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11202 (get_prev_frame_always, get_frame_pc_if_available)
11203 (get_frame_address_in_block_if_available, get_frame_language):
11204 Replace throw_exception with throw.
11205 * frame-unwind.c (frame_unwind_try_unwinder): Replace
11206 throw_exception with throw.
11207 * eval.c (fetch_subexp_value, evaluate_var_value)
11208 (evaluate_funcall, evaluate_subexp_standard): Replace
11209 throw_exception with throw.
11210 * dwarf2loc.c (call_site_find_chain)
11211 (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11212 Replace throw_exception with throw.
11213 * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11214 with throw.
11215 * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11216 throw.
11217 * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11218 * completer.c (complete_line_internal): Replace throw_exception
11219 with throw.
11220 * compile/compile-object-run.c (compile_object_run): Replace
11221 throw_exception with throw.
11222 * cli/cli-script.c (process_next_line): Replace throw_exception
11223 with throw.
11224 * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11225 (btrace_enable, btrace_maint_update_pt_packets): Replace
11226 throw_exception with throw.
11227 * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11228 throw_exception with throw.
11229 * break-catch-throw.c (re_set_exception_catchpoint): Replace
11230 throw_exception with throw.
11231 * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11232 (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11233 * aarch64-tdep.c (aarch64_make_prologue_cache)
11234 (aarch64_make_stub_cache): Replace throw_exception with throw.
11235
11236 2019-04-08 Tom Tromey <tom@tromey.com>
11237
11238 * common/common-exceptions.c (throw_exception): Rename from
11239 throw_exception_cxx. Remove old copy. Make argument const.
11240 (throw_it): Create and throw exception objects directly.
11241 * common/common-exceptions.h (throw_exception): Make argument
11242 const.
11243 (struct gdb_exception_error): Add constructor.
11244 (struct gdb_exception_quit): Add constructor.
11245
11246 2019-04-08 Tom Tromey <tom@tromey.com>
11247
11248 * common/common-exceptions.h (exception_rethrow): Don't declare.
11249 (TRY_SJLJ): Update comment.
11250 (TRY, CATCH, END_CATCH): Remove.
11251 * common/common-exceptions.c (exception_rethrow): Remove.
11252
11253 2019-04-08 Tom Tromey <tom@tromey.com>
11254
11255 * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
11256 Remove.
11257 (gdb_exception_error): Rename from
11258 gdb_exception_RETURN_MASK_ERROR.
11259 (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
11260 (gdb_quit_bad_alloc): Update.
11261 * aarch64-tdep.c: Update.
11262 * ada-lang.c: Update.
11263 * ada-typeprint.c: Update.
11264 * ada-valprint.c: Update.
11265 * amd64-tdep.c: Update.
11266 * arch-utils.c: Update.
11267 * break-catch-throw.c: Update.
11268 * breakpoint.c: Update.
11269 * btrace.c: Update.
11270 * c-varobj.c: Update.
11271 * cli/cli-cmds.c: Update.
11272 * cli/cli-interp.c: Update.
11273 * cli/cli-script.c: Update.
11274 * common/common-exceptions.c: Update.
11275 * common/new-op.c: Update.
11276 * common/selftest.c: Update.
11277 * compile/compile-c-symbols.c: Update.
11278 * compile/compile-cplus-symbols.c: Update.
11279 * compile/compile-object-load.c: Update.
11280 * compile/compile-object-run.c: Update.
11281 * completer.c: Update.
11282 * corelow.c: Update.
11283 * cp-abi.c: Update.
11284 * cp-support.c: Update.
11285 * cp-valprint.c: Update.
11286 * darwin-nat.c: Update.
11287 * disasm-selftests.c: Update.
11288 * dtrace-probe.c: Update.
11289 * dwarf-index-cache.c: Update.
11290 * dwarf-index-write.c: Update.
11291 * dwarf2-frame-tailcall.c: Update.
11292 * dwarf2-frame.c: Update.
11293 * dwarf2loc.c: Update.
11294 * dwarf2read.c: Update.
11295 * eval.c: Update.
11296 * event-loop.c: Update.
11297 * event-top.c: Update.
11298 * exec.c: Update.
11299 * f-valprint.c: Update.
11300 * fbsd-tdep.c: Update.
11301 * frame-unwind.c: Update.
11302 * frame.c: Update.
11303 * gdbtypes.c: Update.
11304 * gnu-v3-abi.c: Update.
11305 * guile/guile-internal.h: Update.
11306 * guile/scm-block.c: Update.
11307 * guile/scm-breakpoint.c: Update.
11308 * guile/scm-cmd.c: Update.
11309 * guile/scm-disasm.c: Update.
11310 * guile/scm-frame.c: Update.
11311 * guile/scm-lazy-string.c: Update.
11312 * guile/scm-math.c: Update.
11313 * guile/scm-param.c: Update.
11314 * guile/scm-ports.c: Update.
11315 * guile/scm-pretty-print.c: Update.
11316 * guile/scm-symbol.c: Update.
11317 * guile/scm-symtab.c: Update.
11318 * guile/scm-type.c: Update.
11319 * guile/scm-value.c: Update.
11320 * i386-linux-tdep.c: Update.
11321 * i386-tdep.c: Update.
11322 * inf-loop.c: Update.
11323 * infcall.c: Update.
11324 * infcmd.c: Update.
11325 * infrun.c: Update.
11326 * jit.c: Update.
11327 * language.c: Update.
11328 * linespec.c: Update.
11329 * linux-fork.c: Update.
11330 * linux-nat.c: Update.
11331 * linux-tdep.c: Update.
11332 * linux-thread-db.c: Update.
11333 * main.c: Update.
11334 * mi/mi-cmd-break.c: Update.
11335 * mi/mi-cmd-stack.c: Update.
11336 * mi/mi-interp.c: Update.
11337 * mi/mi-main.c: Update.
11338 * objc-lang.c: Update.
11339 * p-valprint.c: Update.
11340 * parse.c: Update.
11341 * ppc-linux-tdep.c: Update.
11342 * printcmd.c: Update.
11343 * python/py-arch.c: Update.
11344 * python/py-breakpoint.c: Update.
11345 * python/py-cmd.c: Update.
11346 * python/py-finishbreakpoint.c: Update.
11347 * python/py-frame.c: Update.
11348 * python/py-framefilter.c: Update.
11349 * python/py-gdb-readline.c: Update.
11350 * python/py-inferior.c: Update.
11351 * python/py-infthread.c: Update.
11352 * python/py-lazy-string.c: Update.
11353 * python/py-linetable.c: Update.
11354 * python/py-objfile.c: Update.
11355 * python/py-param.c: Update.
11356 * python/py-prettyprint.c: Update.
11357 * python/py-progspace.c: Update.
11358 * python/py-record-btrace.c: Update.
11359 * python/py-record.c: Update.
11360 * python/py-symbol.c: Update.
11361 * python/py-type.c: Update.
11362 * python/py-unwind.c: Update.
11363 * python/py-utils.c: Update.
11364 * python/py-value.c: Update.
11365 * python/python.c: Update.
11366 * record-btrace.c: Update.
11367 * record-full.c: Update.
11368 * remote-fileio.c: Update.
11369 * remote.c: Update.
11370 * riscv-tdep.c: Update.
11371 * rs6000-aix-tdep.c: Update.
11372 * rs6000-tdep.c: Update.
11373 * rust-exp.y: Update.
11374 * rust-lang.c: Update.
11375 * s390-tdep.c: Update.
11376 * selftest-arch.c: Update.
11377 * solib-dsbt.c: Update.
11378 * solib-frv.c: Update.
11379 * solib-spu.c: Update.
11380 * solib-svr4.c: Update.
11381 * solib.c: Update.
11382 * sparc64-linux-tdep.c: Update.
11383 * stack.c: Update.
11384 * symfile-mem.c: Update.
11385 * symmisc.c: Update.
11386 * target.c: Update.
11387 * thread.c: Update.
11388 * top.c: Update.
11389 * tracefile-tfile.c: Update.
11390 * tui/tui.c: Update.
11391 * typeprint.c: Update.
11392 * unittests/cli-utils-selftests.c: Update.
11393 * unittests/parse-connection-spec-selftests.c: Update.
11394 * valops.c: Update.
11395 * valprint.c: Update.
11396 * value.c: Update.
11397 * varobj.c: Update.
11398 * windows-nat.c: Update.
11399 * x86-linux-nat.c: Update.
11400 * xml-support.c: Update.
11401
11402 2019-04-08 Tom Tromey <tom@tromey.com>
11403
11404 * xml-support.c: Use C++ exception handling.
11405 * x86-linux-nat.c: Use C++ exception handling.
11406 * windows-nat.c: Use C++ exception handling.
11407 * varobj.c: Use C++ exception handling.
11408 * value.c: Use C++ exception handling.
11409 * valprint.c: Use C++ exception handling.
11410 * valops.c: Use C++ exception handling.
11411 * unittests/parse-connection-spec-selftests.c: Use C++ exception
11412 handling.
11413 * unittests/cli-utils-selftests.c: Use C++ exception handling.
11414 * typeprint.c: Use C++ exception handling.
11415 * tui/tui.c: Use C++ exception handling.
11416 * tracefile-tfile.c: Use C++ exception handling.
11417 * top.c: Use C++ exception handling.
11418 * thread.c: Use C++ exception handling.
11419 * target.c: Use C++ exception handling.
11420 * symmisc.c: Use C++ exception handling.
11421 * symfile-mem.c: Use C++ exception handling.
11422 * stack.c: Use C++ exception handling.
11423 * sparc64-linux-tdep.c: Use C++ exception handling.
11424 * solib.c: Use C++ exception handling.
11425 * solib-svr4.c: Use C++ exception handling.
11426 * solib-spu.c: Use C++ exception handling.
11427 * solib-frv.c: Use C++ exception handling.
11428 * solib-dsbt.c: Use C++ exception handling.
11429 * selftest-arch.c: Use C++ exception handling.
11430 * s390-tdep.c: Use C++ exception handling.
11431 * rust-lang.c: Use C++ exception handling.
11432 * rust-exp.y: Use C++ exception handling.
11433 * rs6000-tdep.c: Use C++ exception handling.
11434 * rs6000-aix-tdep.c: Use C++ exception handling.
11435 * riscv-tdep.c: Use C++ exception handling.
11436 * remote.c: Use C++ exception handling.
11437 * remote-fileio.c: Use C++ exception handling.
11438 * record-full.c: Use C++ exception handling.
11439 * record-btrace.c: Use C++ exception handling.
11440 * python/python.c: Use C++ exception handling.
11441 * python/py-value.c: Use C++ exception handling.
11442 * python/py-utils.c: Use C++ exception handling.
11443 * python/py-unwind.c: Use C++ exception handling.
11444 * python/py-type.c: Use C++ exception handling.
11445 * python/py-symbol.c: Use C++ exception handling.
11446 * python/py-record.c: Use C++ exception handling.
11447 * python/py-record-btrace.c: Use C++ exception handling.
11448 * python/py-progspace.c: Use C++ exception handling.
11449 * python/py-prettyprint.c: Use C++ exception handling.
11450 * python/py-param.c: Use C++ exception handling.
11451 * python/py-objfile.c: Use C++ exception handling.
11452 * python/py-linetable.c: Use C++ exception handling.
11453 * python/py-lazy-string.c: Use C++ exception handling.
11454 * python/py-infthread.c: Use C++ exception handling.
11455 * python/py-inferior.c: Use C++ exception handling.
11456 * python/py-gdb-readline.c: Use C++ exception handling.
11457 * python/py-framefilter.c: Use C++ exception handling.
11458 * python/py-frame.c: Use C++ exception handling.
11459 * python/py-finishbreakpoint.c: Use C++ exception handling.
11460 * python/py-cmd.c: Use C++ exception handling.
11461 * python/py-breakpoint.c: Use C++ exception handling.
11462 * python/py-arch.c: Use C++ exception handling.
11463 * printcmd.c: Use C++ exception handling.
11464 * ppc-linux-tdep.c: Use C++ exception handling.
11465 * parse.c: Use C++ exception handling.
11466 * p-valprint.c: Use C++ exception handling.
11467 * objc-lang.c: Use C++ exception handling.
11468 * mi/mi-main.c: Use C++ exception handling.
11469 * mi/mi-interp.c: Use C++ exception handling.
11470 * mi/mi-cmd-stack.c: Use C++ exception handling.
11471 * mi/mi-cmd-break.c: Use C++ exception handling.
11472 * main.c: Use C++ exception handling.
11473 * linux-thread-db.c: Use C++ exception handling.
11474 * linux-tdep.c: Use C++ exception handling.
11475 * linux-nat.c: Use C++ exception handling.
11476 * linux-fork.c: Use C++ exception handling.
11477 * linespec.c: Use C++ exception handling.
11478 * language.c: Use C++ exception handling.
11479 * jit.c: Use C++ exception handling.
11480 * infrun.c: Use C++ exception handling.
11481 * infcmd.c: Use C++ exception handling.
11482 * infcall.c: Use C++ exception handling.
11483 * inf-loop.c: Use C++ exception handling.
11484 * i386-tdep.c: Use C++ exception handling.
11485 * i386-linux-tdep.c: Use C++ exception handling.
11486 * guile/scm-value.c: Use C++ exception handling.
11487 * guile/scm-type.c: Use C++ exception handling.
11488 * guile/scm-symtab.c: Use C++ exception handling.
11489 * guile/scm-symbol.c: Use C++ exception handling.
11490 * guile/scm-pretty-print.c: Use C++ exception handling.
11491 * guile/scm-ports.c: Use C++ exception handling.
11492 * guile/scm-param.c: Use C++ exception handling.
11493 * guile/scm-math.c: Use C++ exception handling.
11494 * guile/scm-lazy-string.c: Use C++ exception handling.
11495 * guile/scm-frame.c: Use C++ exception handling.
11496 * guile/scm-disasm.c: Use C++ exception handling.
11497 * guile/scm-cmd.c: Use C++ exception handling.
11498 * guile/scm-breakpoint.c: Use C++ exception handling.
11499 * guile/scm-block.c: Use C++ exception handling.
11500 * guile/guile-internal.h: Use C++ exception handling.
11501 * gnu-v3-abi.c: Use C++ exception handling.
11502 * gdbtypes.c: Use C++ exception handling.
11503 * frame.c: Use C++ exception handling.
11504 * frame-unwind.c: Use C++ exception handling.
11505 * fbsd-tdep.c: Use C++ exception handling.
11506 * f-valprint.c: Use C++ exception handling.
11507 * exec.c: Use C++ exception handling.
11508 * event-top.c: Use C++ exception handling.
11509 * event-loop.c: Use C++ exception handling.
11510 * eval.c: Use C++ exception handling.
11511 * dwarf2read.c: Use C++ exception handling.
11512 * dwarf2loc.c: Use C++ exception handling.
11513 * dwarf2-frame.c: Use C++ exception handling.
11514 * dwarf2-frame-tailcall.c: Use C++ exception handling.
11515 * dwarf-index-write.c: Use C++ exception handling.
11516 * dwarf-index-cache.c: Use C++ exception handling.
11517 * dtrace-probe.c: Use C++ exception handling.
11518 * disasm-selftests.c: Use C++ exception handling.
11519 * darwin-nat.c: Use C++ exception handling.
11520 * cp-valprint.c: Use C++ exception handling.
11521 * cp-support.c: Use C++ exception handling.
11522 * cp-abi.c: Use C++ exception handling.
11523 * corelow.c: Use C++ exception handling.
11524 * completer.c: Use C++ exception handling.
11525 * compile/compile-object-run.c: Use C++ exception handling.
11526 * compile/compile-object-load.c: Use C++ exception handling.
11527 * compile/compile-cplus-symbols.c: Use C++ exception handling.
11528 * compile/compile-c-symbols.c: Use C++ exception handling.
11529 * common/selftest.c: Use C++ exception handling.
11530 * common/new-op.c: Use C++ exception handling.
11531 * cli/cli-script.c: Use C++ exception handling.
11532 * cli/cli-interp.c: Use C++ exception handling.
11533 * cli/cli-cmds.c: Use C++ exception handling.
11534 * c-varobj.c: Use C++ exception handling.
11535 * btrace.c: Use C++ exception handling.
11536 * breakpoint.c: Use C++ exception handling.
11537 * break-catch-throw.c: Use C++ exception handling.
11538 * arch-utils.c: Use C++ exception handling.
11539 * amd64-tdep.c: Use C++ exception handling.
11540 * ada-valprint.c: Use C++ exception handling.
11541 * ada-typeprint.c: Use C++ exception handling.
11542 * ada-lang.c: Use C++ exception handling.
11543 * aarch64-tdep.c: Use C++ exception handling.
11544
11545 2019-04-08 Tom Tromey <tom@tromey.com>
11546
11547 * xml-support.c (gdb_xml_parser::parse): Update.
11548 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
11549 * value.c (show_convenience): Update.
11550 * unittests/cli-utils-selftests.c (test_number_or_range_parser)
11551 (test_parse_flags_qcs): Update.
11552 * thread.c (thr_try_catch_cmd): Update.
11553 * target.c (target_translate_tls_address): Update.
11554 * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
11555 (info_frame_command_core, frame_apply_command_count): Update.
11556 * rust-exp.y (rust_lex_exception_test): Update.
11557 * riscv-tdep.c (riscv_print_one_register_info): Update.
11558 * remote.c (remote_target::enable_btrace): Update.
11559 * record-btrace.c (record_btrace_enable_warn): Update.
11560 * python/py-utils.c (gdbpy_convert_exception): Update.
11561 * printcmd.c (do_one_display, print_variable_and_value): Update.
11562 * mi/mi-main.c (mi_print_exception): Update.
11563 * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
11564 * mi/mi-cmd-stack.c (list_arg_or_local): Update.
11565 * linux-nat.c (linux_nat_target::attach): Update.
11566 * linux-fork.c (class scoped_switch_fork_info): Update.
11567 * infrun.c (displaced_step_prepare): Update.
11568 * infcall.c (call_function_by_hand_dummy): Update.
11569 * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
11570 * gnu-v3-abi.c (print_one_vtable): Update.
11571 * frame.c (get_prev_frame_always): Update.
11572 * f-valprint.c (info_common_command_for_block): Update.
11573 * exec.c (try_open_exec_file): Update.
11574 * exceptions.c (print_exception, exception_print)
11575 (exception_fprintf, exception_print_same): Update.
11576 * dwarf2-frame.c (dwarf2_build_frame_info): Update.
11577 * dwarf-index-cache.c (index_cache::store)
11578 (index_cache::lookup_gdb_index): Update.
11579 * darwin-nat.c (maybe_cache_shell): Update.
11580 * cp-valprint.c (cp_print_value_fields): Update.
11581 * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
11582 (gcc_cplus_symbol_address): Update.
11583 * compile/compile-c-symbols.c (gcc_convert_symbol)
11584 (gcc_symbol_address, generate_c_for_for_one_variable): Update.
11585 * common/selftest.c: Update.
11586 * common/common-exceptions.h (struct gdb_exception) <message>: Now
11587 a std::string.
11588 (exception_try_scope_entry, exception_try_scope_exit): Don't
11589 declare.
11590 (struct exception_try_scope): Remove.
11591 (TRY): Don't use exception_try_scope.
11592 (struct gdb_exception): Add constructor, operator=.
11593 <what>: New method.
11594 (struct gdb_exception_RETURN_MASK_ALL)
11595 (struct gdb_exception_RETURN_MASK_ERROR)
11596 (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
11597 (struct gdb_quit_bad_alloc): Update.
11598 * common/common-exceptions.c (exception_none): Change
11599 initializer.
11600 (struct catcher) <state, exception>: Initialize inline.
11601 <prev>: Remove member.
11602 (current_catcher): Remove.
11603 (catchers): New global.
11604 (exceptions_state_mc_init): Simplify.
11605 (catcher_pop): Remove.
11606 (exceptions_state_mc, exceptions_state_mc_catch): Update.
11607 (try_scope_depth, exception_try_scope_entry)
11608 (exception_try_scope_exit): Remove.
11609 (throw_exception_sjlj): Update.
11610 (exception_messages, exception_messages_size): Remove.
11611 (throw_it): Simplify.
11612 (gdb_exception_sliced_copy): Remove.
11613 (throw_exception_cxx): Update.
11614 * cli/cli-script.c (script_from_file): Update.
11615 * breakpoint.c (insert_bp_location, update_breakpoint_locations):
11616 Update.
11617 * ada-valprint.c (ada_val_print): Update.
11618 * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
11619 (create_excep_cond_exprs): Update.
11620
11621 2019-04-08 Tom Tromey <tom@tromey.com>
11622
11623 * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
11624 (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
11625 (TRY, CATCH, END_CATCH): Remove some definitions.
11626 * common/common-exceptions.c: Don't use GDB_XCPT.
11627 (catcher_list_size): Remove.
11628 (throw_exception, throw_it): Simplify.
11629
11630 2019-04-05 Tom Tromey <tom@tromey.com>
11631
11632 Revert the header-sorting patch.
11633 * ft32-tdep.c: Revert.
11634 * frv-tdep.c: Revert.
11635 * frv-linux-tdep.c: Revert.
11636 * frame.c: Revert.
11637 * frame-unwind.c: Revert.
11638 * frame-base.c: Revert.
11639 * fork-child.c: Revert.
11640 * findvar.c: Revert.
11641 * findcmd.c: Revert.
11642 * filesystem.c: Revert.
11643 * filename-seen-cache.h: Revert.
11644 * filename-seen-cache.c: Revert.
11645 * fbsd-tdep.c: Revert.
11646 * fbsd-nat.h: Revert.
11647 * fbsd-nat.c: Revert.
11648 * f-valprint.c: Revert.
11649 * f-typeprint.c: Revert.
11650 * f-lang.c: Revert.
11651 * extension.h: Revert.
11652 * extension.c: Revert.
11653 * extension-priv.h: Revert.
11654 * expprint.c: Revert.
11655 * exec.h: Revert.
11656 * exec.c: Revert.
11657 * exceptions.c: Revert.
11658 * event-top.c: Revert.
11659 * event-loop.c: Revert.
11660 * eval.c: Revert.
11661 * elfread.c: Revert.
11662 * dwarf2read.h: Revert.
11663 * dwarf2read.c: Revert.
11664 * dwarf2loc.c: Revert.
11665 * dwarf2expr.h: Revert.
11666 * dwarf2expr.c: Revert.
11667 * dwarf2-frame.c: Revert.
11668 * dwarf2-frame-tailcall.c: Revert.
11669 * dwarf-index-write.h: Revert.
11670 * dwarf-index-write.c: Revert.
11671 * dwarf-index-common.c: Revert.
11672 * dwarf-index-cache.h: Revert.
11673 * dwarf-index-cache.c: Revert.
11674 * dummy-frame.c: Revert.
11675 * dtrace-probe.c: Revert.
11676 * disasm.h: Revert.
11677 * disasm.c: Revert.
11678 * disasm-selftests.c: Revert.
11679 * dictionary.c: Revert.
11680 * dicos-tdep.c: Revert.
11681 * demangle.c: Revert.
11682 * dcache.h: Revert.
11683 * dcache.c: Revert.
11684 * darwin-nat.h: Revert.
11685 * darwin-nat.c: Revert.
11686 * darwin-nat-info.c: Revert.
11687 * d-valprint.c: Revert.
11688 * d-namespace.c: Revert.
11689 * d-lang.c: Revert.
11690 * ctf.c: Revert.
11691 * csky-tdep.c: Revert.
11692 * csky-linux-tdep.c: Revert.
11693 * cris-tdep.c: Revert.
11694 * cris-linux-tdep.c: Revert.
11695 * cp-valprint.c: Revert.
11696 * cp-support.c: Revert.
11697 * cp-namespace.c: Revert.
11698 * cp-abi.c: Revert.
11699 * corelow.c: Revert.
11700 * corefile.c: Revert.
11701 * continuations.c: Revert.
11702 * completer.h: Revert.
11703 * completer.c: Revert.
11704 * complaints.c: Revert.
11705 * coffread.c: Revert.
11706 * coff-pe-read.c: Revert.
11707 * cli-out.h: Revert.
11708 * cli-out.c: Revert.
11709 * charset.c: Revert.
11710 * c-varobj.c: Revert.
11711 * c-valprint.c: Revert.
11712 * c-typeprint.c: Revert.
11713 * c-lang.c: Revert.
11714 * buildsym.c: Revert.
11715 * buildsym-legacy.c: Revert.
11716 * build-id.h: Revert.
11717 * build-id.c: Revert.
11718 * btrace.c: Revert.
11719 * bsd-uthread.c: Revert.
11720 * breakpoint.h: Revert.
11721 * breakpoint.c: Revert.
11722 * break-catch-throw.c: Revert.
11723 * break-catch-syscall.c: Revert.
11724 * break-catch-sig.c: Revert.
11725 * blockframe.c: Revert.
11726 * block.c: Revert.
11727 * bfin-tdep.c: Revert.
11728 * bfin-linux-tdep.c: Revert.
11729 * bfd-target.c: Revert.
11730 * bcache.c: Revert.
11731 * ax-general.c: Revert.
11732 * ax-gdb.h: Revert.
11733 * ax-gdb.c: Revert.
11734 * avr-tdep.c: Revert.
11735 * auxv.c: Revert.
11736 * auto-load.c: Revert.
11737 * arm-wince-tdep.c: Revert.
11738 * arm-tdep.c: Revert.
11739 * arm-symbian-tdep.c: Revert.
11740 * arm-pikeos-tdep.c: Revert.
11741 * arm-obsd-tdep.c: Revert.
11742 * arm-nbsd-tdep.c: Revert.
11743 * arm-nbsd-nat.c: Revert.
11744 * arm-linux-tdep.c: Revert.
11745 * arm-linux-nat.c: Revert.
11746 * arm-fbsd-tdep.c: Revert.
11747 * arm-fbsd-nat.c: Revert.
11748 * arm-bsd-tdep.c: Revert.
11749 * arch-utils.c: Revert.
11750 * arc-tdep.c: Revert.
11751 * arc-newlib-tdep.c: Revert.
11752 * annotate.h: Revert.
11753 * annotate.c: Revert.
11754 * amd64-windows-tdep.c: Revert.
11755 * amd64-windows-nat.c: Revert.
11756 * amd64-tdep.c: Revert.
11757 * amd64-sol2-tdep.c: Revert.
11758 * amd64-obsd-tdep.c: Revert.
11759 * amd64-obsd-nat.c: Revert.
11760 * amd64-nbsd-tdep.c: Revert.
11761 * amd64-nbsd-nat.c: Revert.
11762 * amd64-nat.c: Revert.
11763 * amd64-linux-tdep.c: Revert.
11764 * amd64-linux-nat.c: Revert.
11765 * amd64-fbsd-tdep.c: Revert.
11766 * amd64-fbsd-nat.c: Revert.
11767 * amd64-dicos-tdep.c: Revert.
11768 * amd64-darwin-tdep.c: Revert.
11769 * amd64-bsd-nat.c: Revert.
11770 * alpha-tdep.c: Revert.
11771 * alpha-obsd-tdep.c: Revert.
11772 * alpha-nbsd-tdep.c: Revert.
11773 * alpha-mdebug-tdep.c: Revert.
11774 * alpha-linux-tdep.c: Revert.
11775 * alpha-linux-nat.c: Revert.
11776 * alpha-bsd-tdep.c: Revert.
11777 * alpha-bsd-nat.c: Revert.
11778 * aix-thread.c: Revert.
11779 * agent.c: Revert.
11780 * addrmap.c: Revert.
11781 * ada-varobj.c: Revert.
11782 * ada-valprint.c: Revert.
11783 * ada-typeprint.c: Revert.
11784 * ada-tasks.c: Revert.
11785 * ada-lang.c: Revert.
11786 * aarch64-tdep.c: Revert.
11787 * aarch64-ravenscar-thread.c: Revert.
11788 * aarch64-newlib-tdep.c: Revert.
11789 * aarch64-linux-tdep.c: Revert.
11790 * aarch64-linux-nat.c: Revert.
11791 * aarch64-fbsd-tdep.c: Revert.
11792 * aarch64-fbsd-nat.c: Revert.
11793 * aarch32-linux-nat.c: Revert.
11794
11795 2019-04-05 Tom Tromey <tom@tromey.com>
11796
11797 * ft32-tdep.c: Sort headers.
11798 * frv-tdep.c: Sort headers.
11799 * frv-linux-tdep.c: Sort headers.
11800 * frame.c: Sort headers.
11801 * frame-unwind.c: Sort headers.
11802 * frame-base.c: Sort headers.
11803 * fork-child.c: Sort headers.
11804 * findvar.c: Sort headers.
11805 * findcmd.c: Sort headers.
11806 * filesystem.c: Sort headers.
11807 * filename-seen-cache.h: Sort headers.
11808 * filename-seen-cache.c: Sort headers.
11809 * fbsd-tdep.c: Sort headers.
11810 * fbsd-nat.h: Sort headers.
11811 * fbsd-nat.c: Sort headers.
11812 * f-valprint.c: Sort headers.
11813 * f-typeprint.c: Sort headers.
11814 * f-lang.c: Sort headers.
11815 * extension.h: Sort headers.
11816 * extension.c: Sort headers.
11817 * extension-priv.h: Sort headers.
11818 * expprint.c: Sort headers.
11819 * exec.h: Sort headers.
11820 * exec.c: Sort headers.
11821 * exceptions.c: Sort headers.
11822 * event-top.c: Sort headers.
11823 * event-loop.c: Sort headers.
11824 * eval.c: Sort headers.
11825 * elfread.c: Sort headers.
11826 * dwarf2read.h: Sort headers.
11827 * dwarf2read.c: Sort headers.
11828 * dwarf2loc.c: Sort headers.
11829 * dwarf2expr.h: Sort headers.
11830 * dwarf2expr.c: Sort headers.
11831 * dwarf2-frame.c: Sort headers.
11832 * dwarf2-frame-tailcall.c: Sort headers.
11833 * dwarf-index-write.h: Sort headers.
11834 * dwarf-index-write.c: Sort headers.
11835 * dwarf-index-common.c: Sort headers.
11836 * dwarf-index-cache.h: Sort headers.
11837 * dwarf-index-cache.c: Sort headers.
11838 * dummy-frame.c: Sort headers.
11839 * dtrace-probe.c: Sort headers.
11840 * disasm.h: Sort headers.
11841 * disasm.c: Sort headers.
11842 * disasm-selftests.c: Sort headers.
11843 * dictionary.c: Sort headers.
11844 * dicos-tdep.c: Sort headers.
11845 * demangle.c: Sort headers.
11846 * dcache.h: Sort headers.
11847 * dcache.c: Sort headers.
11848 * darwin-nat.h: Sort headers.
11849 * darwin-nat.c: Sort headers.
11850 * darwin-nat-info.c: Sort headers.
11851 * d-valprint.c: Sort headers.
11852 * d-namespace.c: Sort headers.
11853 * d-lang.c: Sort headers.
11854 * ctf.c: Sort headers.
11855 * csky-tdep.c: Sort headers.
11856 * csky-linux-tdep.c: Sort headers.
11857 * cris-tdep.c: Sort headers.
11858 * cris-linux-tdep.c: Sort headers.
11859 * cp-valprint.c: Sort headers.
11860 * cp-support.c: Sort headers.
11861 * cp-namespace.c: Sort headers.
11862 * cp-abi.c: Sort headers.
11863 * corelow.c: Sort headers.
11864 * corefile.c: Sort headers.
11865 * continuations.c: Sort headers.
11866 * completer.h: Sort headers.
11867 * completer.c: Sort headers.
11868 * complaints.c: Sort headers.
11869 * coffread.c: Sort headers.
11870 * coff-pe-read.c: Sort headers.
11871 * cli-out.h: Sort headers.
11872 * cli-out.c: Sort headers.
11873 * charset.c: Sort headers.
11874 * c-varobj.c: Sort headers.
11875 * c-valprint.c: Sort headers.
11876 * c-typeprint.c: Sort headers.
11877 * c-lang.c: Sort headers.
11878 * buildsym.c: Sort headers.
11879 * buildsym-legacy.c: Sort headers.
11880 * build-id.h: Sort headers.
11881 * build-id.c: Sort headers.
11882 * btrace.c: Sort headers.
11883 * bsd-uthread.c: Sort headers.
11884 * breakpoint.h: Sort headers.
11885 * breakpoint.c: Sort headers.
11886 * break-catch-throw.c: Sort headers.
11887 * break-catch-syscall.c: Sort headers.
11888 * break-catch-sig.c: Sort headers.
11889 * blockframe.c: Sort headers.
11890 * block.c: Sort headers.
11891 * bfin-tdep.c: Sort headers.
11892 * bfin-linux-tdep.c: Sort headers.
11893 * bfd-target.c: Sort headers.
11894 * bcache.c: Sort headers.
11895 * ax-general.c: Sort headers.
11896 * ax-gdb.h: Sort headers.
11897 * ax-gdb.c: Sort headers.
11898 * avr-tdep.c: Sort headers.
11899 * auxv.c: Sort headers.
11900 * auto-load.c: Sort headers.
11901 * arm-wince-tdep.c: Sort headers.
11902 * arm-tdep.c: Sort headers.
11903 * arm-symbian-tdep.c: Sort headers.
11904 * arm-pikeos-tdep.c: Sort headers.
11905 * arm-obsd-tdep.c: Sort headers.
11906 * arm-nbsd-tdep.c: Sort headers.
11907 * arm-nbsd-nat.c: Sort headers.
11908 * arm-linux-tdep.c: Sort headers.
11909 * arm-linux-nat.c: Sort headers.
11910 * arm-fbsd-tdep.c: Sort headers.
11911 * arm-fbsd-nat.c: Sort headers.
11912 * arm-bsd-tdep.c: Sort headers.
11913 * arch-utils.c: Sort headers.
11914 * arc-tdep.c: Sort headers.
11915 * arc-newlib-tdep.c: Sort headers.
11916 * annotate.h: Sort headers.
11917 * annotate.c: Sort headers.
11918 * amd64-windows-tdep.c: Sort headers.
11919 * amd64-windows-nat.c: Sort headers.
11920 * amd64-tdep.c: Sort headers.
11921 * amd64-sol2-tdep.c: Sort headers.
11922 * amd64-obsd-tdep.c: Sort headers.
11923 * amd64-obsd-nat.c: Sort headers.
11924 * amd64-nbsd-tdep.c: Sort headers.
11925 * amd64-nbsd-nat.c: Sort headers.
11926 * amd64-nat.c: Sort headers.
11927 * amd64-linux-tdep.c: Sort headers.
11928 * amd64-linux-nat.c: Sort headers.
11929 * amd64-fbsd-tdep.c: Sort headers.
11930 * amd64-fbsd-nat.c: Sort headers.
11931 * amd64-dicos-tdep.c: Sort headers.
11932 * amd64-darwin-tdep.c: Sort headers.
11933 * amd64-bsd-nat.c: Sort headers.
11934 * alpha-tdep.c: Sort headers.
11935 * alpha-obsd-tdep.c: Sort headers.
11936 * alpha-nbsd-tdep.c: Sort headers.
11937 * alpha-mdebug-tdep.c: Sort headers.
11938 * alpha-linux-tdep.c: Sort headers.
11939 * alpha-linux-nat.c: Sort headers.
11940 * alpha-bsd-tdep.c: Sort headers.
11941 * alpha-bsd-nat.c: Sort headers.
11942 * aix-thread.c: Sort headers.
11943 * agent.c: Sort headers.
11944 * addrmap.c: Sort headers.
11945 * ada-varobj.c: Sort headers.
11946 * ada-valprint.c: Sort headers.
11947 * ada-typeprint.c: Sort headers.
11948 * ada-tasks.c: Sort headers.
11949 * ada-lang.c: Sort headers.
11950 * aarch64-tdep.c: Sort headers.
11951 * aarch64-ravenscar-thread.c: Sort headers.
11952 * aarch64-newlib-tdep.c: Sort headers.
11953 * aarch64-linux-tdep.c: Sort headers.
11954 * aarch64-linux-nat.c: Sort headers.
11955 * aarch64-fbsd-tdep.c: Sort headers.
11956 * aarch64-fbsd-nat.c: Sort headers.
11957 * aarch32-linux-nat.c: Sort headers.
11958
11959 2019-04-04 Tom Tromey <tom@tromey.com>
11960
11961 * varobj.c (varobj_create): Update.
11962 * rust-exp.y (struct rust_parser) <update_innermost_block,
11963 lookup_symbol>: New methods.
11964 (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
11965 Rename.
11966 (rust_parser::rust_lookup_type)
11967 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
11968 * printcmd.c (display_command, do_one_display): Update.
11969 * parser-defs.h (struct parser_state) <parser_state>: Add
11970 "tracker" parameter.
11971 (block_tracker): New member.
11972 (class innermost_block_tracker) <innermost_block_tracker>: Add
11973 "types" parameter.
11974 <reset>: Remove method.
11975 (innermost_block): Don't declare.
11976 (null_post_parser): Update.
11977 * parse.c (innermost_block): Remove global.
11978 (write_dollar_variable): Update.
11979 (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
11980 Remove "tracker_types" parameter.
11981 (parse_expression): Add "tracker" parameter.
11982 (parse_expression_for_completion): Update.
11983 (null_post_parser): Add "tracker" parameter.
11984 * p-exp.y: Update rules.
11985 * m2-exp.y: Update rules.
11986 * language.h (struct language_defn) <la_post_parser>: Add
11987 "tracker" parameter.
11988 * go-exp.y: Update rules.
11989 * f-exp.y: Update rules.
11990 * expression.h (parse_expression, parse_exp_1): Add "tracker"
11991 parameter.
11992 * d-exp.y: Update rules.
11993 * c-exp.y: Update rules.
11994 * breakpoint.c (set_breakpoint_condition): Create an
11995 innermost_block_tracker.
11996 (watch_command_1): Likewise.
11997 * ada-lang.c (resolve): Add "tracker" parameter.
11998 (resolve_subexp): Likewise.
11999 * ada-exp.y (write_var_from_sym): Update.
12000
12001 2019-04-04 Tom Tromey <tom@tromey.com>
12002
12003 * type-stack.h: New file.
12004 * type-stack.c: New file.
12005 * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12006 type-stack.h.
12007 (insert_into_type_stack, insert_type, push_type, push_type_int)
12008 (insert_type_address_space, pop_type, pop_type_int)
12009 (pop_typelist, pop_type_stack, append_type_stack)
12010 (push_type_stack, get_type_stack, push_typelist)
12011 (follow_type_instance_flags, follow_types): Don't declare.
12012 * parse.c (type_stack): Remove global.
12013 (parse_exp_in_context): Update.
12014 (insert_into_type_stack, insert_type, push_type, push_type_int)
12015 (insert_type_address_space, pop_type, pop_type_int)
12016 (pop_typelist, pop_type_stack, append_type_stack)
12017 (push_type_stack, get_type_stack, push_typelist)
12018 (follow_type_instance_flags, follow_types): Remove (moved to
12019 type-stack.c).
12020 * f-exp.y (type_stack): New global.
12021 Update rules.
12022 (push_kind_type, f_parse): Update.
12023 * d-exp.y (type_stack): New global.
12024 Update rules.
12025 (d_parse): Update.
12026 * c-exp.y (struct c_parse_state) <type_stack>: New member.
12027 Update rules.
12028 * Makefile.in (COMMON_SFILES): Add type-stack.c.
12029 (HFILES_NO_SRCDIR): Add type-stack.h.
12030
12031 2019-04-04 Tom Tromey <tom@tromey.com>
12032
12033 * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12034 (rust_parser::convert_ast_to_expression, rust_parse)
12035 (rust_lex_test_completion, rust_lex_tests): Update.
12036 * parser-defs.h (struct expr_completion_state): New.
12037 (struct parser_state) <parser_state>: Add completion parameter.
12038 <mark_struct_expression, mark_completion_tag>: New methods.
12039 <parse_completion, m_completion_state>: New members.
12040 (prefixify_expression, null_post_parser): Update.
12041 (mark_struct_expression, mark_completion_tag): Don't declare.
12042 * parse.c (parse_completion, expout_last_struct)
12043 (expout_tag_completion_type, expout_completion_name): Remove
12044 globals.
12045 (parser_state::mark_struct_expression)
12046 (parser_state::mark_completion_tag): Now methods.
12047 (prefixify_expression): Add last_struct parameter.
12048 (prefixify_subexp): Likewise.
12049 (parse_exp_1): Update.
12050 (parse_exp_in_context): Add cstate parameter. Update.
12051 (parse_expression_for_completion): Create an
12052 expr_completion_state.
12053 (null_post_parser): Add "completion" parameter.
12054 * p-exp.y: Update rules.
12055 (yylex): Update.
12056 * language.h (struct language_defn) <la_post_parser>: Add
12057 "completing" parameter.
12058 * go-exp.y: Update rules.
12059 (lex_one_token): Update.
12060 * expression.h (parse_completion): Don't declare.
12061 * d-exp.y: Update rules.
12062 (lex_one_token): Update rules.
12063 * c-exp.y: Update rules.
12064 (lex_one_token): Update.
12065 * ada-lang.c (resolve): Add "parse_completion" parameter.
12066 (resolve_subexp): Likewise.
12067 (ada_resolve_function): Likewise.
12068
12069 2019-04-04 Tom Tromey <tom@tromey.com>
12070
12071 * parser-defs.h (struct parser_state) <start_arglist,
12072 end_arglist>: New methods.
12073 <arglist_len, m_funcall_chain>: New members.
12074 (arglist_len, start_arglist, end_arglist): Don't declare.
12075 * parse.c (arglist_len, funcall_chain): Remove global.
12076 (start_arglist, end_arglist): Remove functions.
12077 (parse_exp_in_context): Update.
12078 * p-exp.y: Update rules.
12079 * m2-exp.y: Update rules.
12080 * go-exp.y: Update rules.
12081 * f-exp.y: Update rules.
12082 * d-exp.y: Update rules.
12083 * c-exp.y: Update rules.
12084
12085 2019-04-04 Tom Tromey <tom@tromey.com>
12086
12087 * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12088 lex_operator, push_back>: New methods.
12089 Update all rules.
12090 (rust_parser::lex_hex, lex_escape): Rename and update.
12091 (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12092 (rust_parser::lex_operator): Rename and update.
12093 (rust_parser::lex_number, rustyylex, rustyyerror)
12094 (rust_lex_test_init, rust_lex_test_sequence)
12095 (rust_lex_test_push_back, rust_lex_tests): Update.
12096 * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12097 parameter.
12098 <lexptr, prev_lexptr>: New members.
12099 (lexptr, prev_lexptr): Don't declare.
12100 * parse.c (lexptr, prev_lexptr): Remove globals.
12101 (parse_exp_in_context): Update.
12102 * p-exp.y (yylex, yyerror): Update.
12103 * m2-exp.y (parse_number, yylex, yyerror): Update.
12104 * go-exp.y (lex_one_token, yyerror): Update.
12105 * f-exp.y (match_string_literal, yylex, yyerror): Update.
12106 * d-exp.y (lex_one_token, yyerror): Update.
12107 * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12108 (lex_one_token, yyerror): Update.
12109 * ada-lex.l (YY_INPUT): Update.
12110 (rewind_to_char): Update.
12111 * ada-exp.y (yyerror): Update.
12112
12113 2019-04-04 Tom Tromey <tom@tromey.com>
12114
12115 * rust-exp.y (rustyylex, rust_lex_tests): Update.
12116 * parser-defs.h (struct parser_state) <parser_state>: Add new
12117 parameter.
12118 <comma_terminates>: New member.
12119 (comma_terminates): Don't declare global.
12120 * parse.c (comma_terminates): Remove global.
12121 (parse_exp_in_context): Update.
12122 * p-exp.y (yylex): Update.
12123 * m2-exp.y (yylex): Update.
12124 * go-exp.y (lex_one_token): Update.
12125 * f-exp.y (yylex): Update.
12126 * d-exp.y (lex_one_token): Update.
12127 * c-exp.y (lex_one_token): Update.
12128 * ada-lex.l: Update.
12129
12130 2019-04-04 Tom Tromey <tom@tromey.com>
12131
12132 * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12133 (rustyylex, rust_lex_test_init, rust_lex_test_one)
12134 (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12135 * parser-defs.h (paren_depth): Don't declare.
12136 * parse.c (paren_depth): Remove global.
12137 (parse_exp_in_context): Update.
12138 * p-exp.y (paren_depth): New global.
12139 (pascal_parse): Initialize it.
12140 * m2-exp.y (paren_depth): New global.
12141 (m2_parse): Initialize it.
12142 * go-exp.y (paren_depth): New global.
12143 (go_parse): Initialize it.
12144 * f-exp.y (paren_depth): New global.
12145 (f_parse): Initialize it.
12146 * d-exp.y (paren_depth): New global.
12147 (d_parse): Initialize it.
12148 * c-exp.y (paren_depth): New global.
12149 (c_parse): Initialize it.
12150 * ada-lex.l (paren_depth): New global.
12151 (lexer_init): Initialize it.
12152
12153 2019-04-04 Tom Tromey <tom@tromey.com>
12154
12155 * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12156 (rust_parser::convert_ast_to_type)
12157 (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12158 * parser-defs.h (struct parser_state) <parser_state>: Add
12159 parameters. Initialize new members.
12160 <expression_context_block, expression_context_pc>: New members.
12161 * parse.c (expression_context_block, expression_context_pc):
12162 Remove globals.
12163 (parse_exp_in_context): Update.
12164 * p-exp.y: Update all rules.
12165 (yylex): Update.
12166 * m2-exp.y: Update all rules.
12167 (yylex): Update.
12168 * go-exp.y (yylex): Update.
12169 * f-exp.y (yylex): Update.
12170 * d-exp.y: Update all rules.
12171 (yylex): Update.
12172 * c-exp.y: Update all rules.
12173 (lex_one_token, classify_name, yylex, c_parse): Update.
12174 * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12175
12176 2019-04-04 Tom Tromey <tom@tromey.com>
12177
12178 * gdbarch.h, gdbarch.c: Rebuild.
12179 * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12180 * stap-probe.h:
12181 (struct stap_parse_info): Replace "parser_state" with
12182 "expr_builder".
12183 * parser-defs.h (struct expr_builder): Rename from "parser_state".
12184 (parser_state): New class.
12185 * parse.c (expr_builder): Rename.
12186 (expr_builder::release): Rename.
12187 (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12188 (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12189 (write_exp_elt_longcst, write_exp_elt_floatcst)
12190 (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12191 (write_exp_string_vector, write_exp_bitstring)
12192 (write_exp_msymbol, mark_struct_expression)
12193 (write_dollar_variable)
12194 (insert_type_address_space, increase_expout_size): Replace
12195 "parser_state" with "expr_builder".
12196 * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12197 * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12198 "parser_state" with "expr_builder".
12199
12200 2019-04-04 Tom Tromey <tom@tromey.com>
12201
12202 * rust-exp.y: Replace "parse_language" with method call.
12203 * p-exp.y:
12204 (yylex): Replace "parse_language" with method call.
12205 * m2-exp.y:
12206 (yylex): Replace "parse_language" with method call.
12207 * go-exp.y (classify_name): Replace "parse_language" with method
12208 call.
12209 * f-exp.y (yylex): Replace "parse_language" with method call.
12210 * d-exp.y (lex_one_token): Replace "parse_language" with method
12211 call.
12212 * c-exp.y:
12213 (lex_one_token, classify_name, yylex): Replace "parse_language"
12214 with method call.
12215 * ada-exp.y (find_primitive_type, type_char)
12216 (type_system_address): Replace "parse_language" with method call.
12217
12218 2019-04-04 Tom Tromey <tom@tromey.com>
12219
12220 * rust-exp.y: Replace "parse_gdbarch" with method call.
12221 * parse.c (write_dollar_variable, insert_type_address_space):
12222 Replace "parse_gdbarch" with method call.
12223 * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12224 call.
12225 * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12226 call.
12227 * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12228 "parse_gdbarch" with method call.
12229 * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12230 with method call.
12231 * f-exp.y (parse_type, parse_f_type, yylex): Replace
12232 "parse_gdbarch" with method call.
12233 * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12234 "parse_gdbarch" with method call.
12235 * c-exp.y (parse_type, parse_number, classify_name): Replace
12236 "parse_gdbarch" with method call.
12237 * ada-lex.l: Replace "parse_gdbarch" with method call.
12238 * ada-exp.y (parse_type, find_primitive_type, type_char)
12239 (type_system_address): Replace "parse_gdbarch" with method call.
12240
12241 2019-04-04 Tom Tromey <tom@tromey.com>
12242
12243 * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12244 * stap-probe.c (stap_parse_argument): Update.
12245 * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12246 initial_size parameter.
12247 * rust-exp.y (rust_lex_tests): Update.
12248 * parse.c (parser_state): Update.
12249 (parse_exp_in_context): Update.
12250 * parser-defs.h (struct parser_state) <parser_state>: Remove
12251 "initial_size" parameter.
12252
12253 2019-04-04 Tom Tromey <tom@tromey.com>
12254
12255 * parser-defs.h (increase_expout_size): Don't declare.
12256 * parse.c (increase_expout_size): Now static.
12257
12258 2019-04-04 Thomas Schwinge <thomas@codesourcery.com>
12259
12260 * gnu-nat.c (gnu_nat_target::wait): Fix
12261 target_waitstatus_to_string call.
12262
12263 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12264
12265 * eval.c (evaluate_subexp_standard): Handle internal functions
12266 during Fortran function call handling.
12267
12268 2019-04-01 Andrew Burgess <andrew.burgess@embecosm.com>
12269
12270 * NEWS: Mention new internal functions.
12271 * dwarf2read.c (dwarf2_init_complex_target_type): New function.
12272 (read_base_type): Use dwarf2_init_complex_target_type.
12273 * value.c (creal_internal_fn): New function.
12274 (cimag_internal_fn): New function.
12275 (_initialize_values): Register new internal functions.
12276
12277 2019-04-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12278
12279 * infrun.c (stop_all_threads): If debug_infrun, always
12280 trace the wait status after wait_one, using
12281 target_waitstatus_to_string and target_pid_to_str.
12282 (handle_inferior_event): Replace various trace of
12283 wait status kind by a single trace.
12284 * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
12285 wait status kind image by target_waitstatus_to_string.
12286 * target/waitstatus.c (target_waitstatus_to_string): Fix
12287 obsolete comment.
12288
12289 2019-04-01 Tom Tromey <tromey@adacore.com>
12290
12291 PR symtab/23331:
12292 * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
12293
12294 2019-04-01 Sergio Durigan Junior <sergiodj@redhat.com>
12295 Pedro Alves <palves@redhat.com>
12296
12297 * top.c (quit_force): Call 'finalize_values'.
12298 * value.c (finalize_values): New function.
12299 * value.h (finalize_values): Declare.
12300
12301 2019-03-30 Eli Zaretskii <eliz@gnu.org>
12302
12303 * NEWS: Announce $_gdb_major and $_gdb_minor.
12304
12305 * top.c (init_gdb_version_vars): New function.
12306 (gdb_init): Call init_gdb_version_vars.
12307
12308 2019-03-29 Tom Tromey <tromey@adacore.com>
12309
12310 * printcmd.c (_initialize_printcmd): Add usage lines. Update some
12311 help text. Remove dead code.
12312
12313 2019-03-29 Keith Seitz <keiths@redhat.com>
12314
12315 From Siddhesh Poyarekar:
12316 * f-lang.h (f77_get_upperbound): Return LONGEST.
12317 (f77_get_lowerbound): Likewise.
12318 * f-typeprint.c (f_type_print_varspec_suffix): Expand
12319 UPPER_BOUND and LOWER_BOUND to LONGEST. Use plongest to format
12320 print them.
12321 (f_type_print_base): Expand UPPER_BOUND to LONGEST. Use
12322 plongest to format print it.
12323 * f-valprint.c (f77_get_lowerbound): Return LONGEST.
12324 (f77_get_upperbound): Likewise.
12325 (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
12326 LOWER_BOUND to LONGEST.
12327 (f77_create_arrayprint_offset_tbl): Likewise.
12328
12329 2019-03-29 Keith Seitz <keiths@redhat.com>
12330
12331 * ada-lang.c (ada_template_to_fixed_record_type_1): Use
12332 %s/pulongest for TYPE_LENGTH instead of %d in format
12333 strings.
12334 * ada-typerint.c (ada_print_type): Likewise.
12335 * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
12336 * compile/compile-c-support.c (generate_register_struct): Likewise.
12337 * gdbtypes.c (recursive_dump_type): Likewise.
12338 * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
12339 * m2-typeprint.c (m2_array): Use %s/pulongest for TYPE_LENGTH
12340 instead of %d in format strings.
12341 * riscv-tdep.c (riscv_type_alignment): Cast second argument
12342 to std::min to ULONGEST.
12343 * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
12344 instead of %d in format strings.
12345 * tracepoint.c (info_scope_command): Likewise.
12346 * typeprint.c (print_offset_data::update)
12347 (print_offset_data::finish): Likewise.
12348 * xtensa-tdep.c (xtensa_store_return_value)
12349 (xtensa_push_dummy_call): Likewise.
12350
12351 2019-03-28 Jon Turney <jon.turney@dronecode.org.uk>
12352
12353 * windows-nat.c (display_selector): Fixed format specifications
12354 for 64-bit Cygwin.
12355
12356 2019-03-28 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12357
12358 * infrun.c (follow_exec): Call target_terminal::ours_for_output.
12359
12360 2019-03-28 Sandra Loosemore <sandra@codesourcery.com>
12361
12362 * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
12363 * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
12364 * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
12365 (nios2_linux_init_abi): Install it.
12366
12367 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12368
12369 * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
12370
12371 2019-03-28 Alan Hayward <alan.hayward@arm.com>
12372
12373 * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
12374
12375 2019-03-24 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12376 Tom Tromey <tromey@adacore.com>
12377
12378 * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
12379
12380 2019-03-26 Joel Brobecker <brobecker@adacore.com>
12381
12382 * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
12383 (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
12384 method to compute the bounds of range types. Also print "[evaluated]"
12385 if the bounds' values come from a dynamic evaluation.
12386
12387 2019-03-26 Andrew Burgess <andrew.burgess@embecosm.com>
12388
12389 * cp-valprint.c (cp_print_value_fields): Don't print trailing
12390 whitespace when pretty printing is on.
12391
12392 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12393
12394 * ppc-linux-nat.c: Add include.
12395
12396 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12397
12398 * NEWS: Mention AArch64 Pointer Authentication.
12399
12400 2019-03-26 Alan Hayward <alan.hayward@arm.com>
12401
12402 * arm-linux-nat.c: Add include.
12403
12404 2019-03-25 Simon Marchi <simon.marchi@polymtl.ca>
12405
12406 * source-cache.c (source_cache::get_source_lines): Re-read
12407 fullname after calling open_source_file.
12408
12409 2019-03-25 John Baldwin <jhb@FreeBSD.org>
12410
12411 * NEWS: Mention TLS support for FreeBSD.
12412
12413 2019-03-25 Tom Tromey <tromey@adacore.com>
12414
12415 * minsyms.c (BUNCH_SIZE): Update comment.
12416 (~minimal_symbol_reader): Remove old comment.
12417 (compact_minimal_symbols): Update comment.
12418 (minimal_symbol_reader::install): Remove old comment. Update
12419 other comments.
12420
12421 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12422
12423 * s390-linux-nat.c: Add include.
12424
12425 2019-03-25 Alan Hayward <alan.hayward@arm.com>
12426
12427 * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
12428 Call linux_get_hwcap.
12429 * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
12430 Likewise.
12431 (aarch64_linux_get_hwcap): Remove function.
12432 * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
12433 declaration.
12434 * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
12435 linux_get_hwcap.
12436 * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
12437 * linux-tdep.c (linux_get_hwcap): Add function.
12438 (linux_get_hwcap2): Likewise.
12439 * linux-tdep.h (linux_get_hwcap): Add declaration.
12440 (linux_get_hwcap2): Likewise.
12441 * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
12442 (ppc_linux_get_hwcap2): Likewise.
12443 (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
12444 linux_get_hwcap.
12445 (ppc_linux_nat_target::insert_watchpoint): Likewise.
12446 (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
12447 (ppc_linux_nat_target::read_description): Likewise.
12448 * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
12449 * s390-linux-nat.c: Likewise.
12450 * s390-linux-tdep.c (s390_core_read_description): Likewise.
12451
12452 2019-03-24 Tom Tromey <tom@tromey.com>
12453
12454 * ada-lang.c (standard_lookup): Simplify initialization.
12455 (ada_lookup_symbol_nonlocal): Simplify return.
12456 * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
12457 * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
12458 * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
12459 * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
12460 initialization.
12461 * solib.c (solib_global_lookup): Simplify.
12462 * symtab.c (null_block_symbol): Remove.
12463 (symbol_cache_lookup): Simplify returns.
12464 (lookup_language_this): Simplify returns.
12465 (lookup_symbol_aux): Simplify return.
12466 (lookup_local_symbol): Simplify returns.
12467 (lookup_global_symbol_from_objfile): Simplify return.
12468 (lookup_symbol_in_objfile_symtabs)
12469 (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
12470 (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
12471 (lookup_static_symbol, lookup_global_symbol): Simplify return.
12472 * cp-namespace.c (cp_lookup_bare_symbol)
12473 (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
12474 (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
12475 (cp_lookup_nested_symbol): Don't use null_block_symbol.
12476 (cp_lookup_symbol_via_imports): Simplify initialization.
12477 (find_symbol_in_baseclass): Likewise.
12478 * symtab.h (null_block_symbol): Remove.
12479 * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
12480 (d_lookup_nested_symbol, d_lookup_symbol_imports)
12481 (d_lookup_symbol_module): Likewise.
12482 (find_symbol_in_baseclass): Simplify initialization.
12483
12484 2019-03-24 Tom Tromey <tom@tromey.com>
12485
12486 * expression.h: Don't include symtab.h.
12487 (struct block): Forward declare.
12488
12489 2019-03-24 Tom Tromey <tom@tromey.com>
12490
12491 * c-exp.y (typebase): Remove casts.
12492 * gdbtypes.c (lookup_unsigned_typename, )
12493 (lookup_signed_typename): Remove cast.
12494 * eval.c (parse_to_comma_and_eval): Remove cast.
12495 * parse.c (write_dollar_variable): Remove cast.
12496 * block.h (struct block) <superblock>: Now const.
12497 * symfile-debug.c (debug_qf_map_matching_symbols): Update.
12498 * psymtab.c (psym_map_matching_symbols): Make "block" const.
12499 (map_block): Make "block" const.
12500 * symfile.h (struct quick_symbol_functions)
12501 <map_matching_symbols>: Constify block argument to "callback".
12502 * symtab.c (basic_lookup_transparent_type_quick): Make "block"
12503 const.
12504 (find_pc_sect_compunit_symtab): Make "b" const.
12505 (find_symbol_at_address): Likewise.
12506 (search_symbols): Likewise.
12507 * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
12508 (dw2_debug_names_lookup_symbol): Likewise.
12509 (dw2_map_matching_symbols): Update.
12510 * p-valprint.c (pascal_val_print): Remove "block".
12511 * ada-lang.c (ada_add_global_exceptions): Make "b" const.
12512 (aux_add_nonlocal_symbols): Make "block" const.
12513 (resolve_subexp): Remove cast.
12514 * linespec.c (iterate_over_all_matching_symtabs): Make "block"
12515 const.
12516 (iterate_over_file_blocks): Likewise.
12517 * f-exp.y (%union) <bval>: Remove.
12518 * coffread.c (patch_opaque_types): Make "b" const.
12519 * spu-tdep.c (spu_catch_start): Make "block" const.
12520 * c-valprint.c (print_unpacked_pointer): Remove "block".
12521 * symmisc.c (dump_symtab_1): Make "b" const.
12522 (block_depth): Make "block" const.
12523 * d-exp.y (%union) <bval>: Remove.
12524 * cp-support.h (cp_lookup_rtti_type): Update.
12525 * cp-support.c (cp_lookup_rtti_type): Make "block" const.
12526 * psymtab.c (psym_lookup_symbol): Make "block" const.
12527 (maintenance_check_psymtabs): Make "b" const.
12528 * python/py-framefilter.c (extract_sym): Make "sym_block" const.
12529 (enumerate_locals, enumerate_args): Update.
12530 * python/py-symtab.c (stpy_global_block): Make "block" const.
12531 (stpy_static_block): Likewise.
12532 * inline-frame.c (block_starting_point_at): Make "new_block"
12533 const.
12534 * block.c (find_block_in_blockvector): Make return type const.
12535 (blockvector_for_pc_sect): Make "b" const.
12536 (find_block_in_blockvector): Make "b" const.
12537
12538 2019-03-23 Tom Tromey <tom@tromey.com>
12539
12540 * varobj.c (varobj_create): Update.
12541 * symfile.c (clear_symtab_users): Don't reset innermost_block.
12542 * printcmd.c (display_command, do_one_display): Don't reset
12543 innermost_block.
12544 * parser-defs.h (enum innermost_block_tracker_type): Move to
12545 expression.h.
12546 (innermost_block): Update comment.
12547 * parse.c (parse_exp_1): Add tracker_types parameter.
12548 (parse_exp_in_context): Rename from parse_exp_in_context_1. Add
12549 tracker_types parameter. Reset innermost_block.
12550 (parse_exp_in_context): Remove.
12551 (parse_expression_for_completion): Update.
12552 * objfiles.c (~objfile): Don't reset expression_context_block or
12553 innermost_block.
12554 * expression.h (enum innermost_block_tracker_type): Move from
12555 parser-defs.h.
12556 (parse_exp_1): Add tracker_types parameter.
12557 * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
12558 reset innermost_block.
12559
12560 2019-03-23 Tom Tromey <tom@tromey.com>
12561
12562 * objfiles.h: Include bcache.h.
12563
12564 2019-03-23 Tom Tromey <tom@tromey.com>
12565
12566 * linespec.c (get_current_search_block): Use
12567 scoped_restore_current_language.
12568 * symmisc.c (dump_symtab): Use scoped_restore_current_language.
12569
12570 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12571 Jiong Wang <jiong.wang@arm.com>
12572
12573 * aarch64-linux-tdep.c
12574 (aarch64_linux_iterate_over_regset_sections): Check for pauth
12575 section.
12576 * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
12577
12578 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12579 Jiong Wang <jiong.wang@arm.com>
12580
12581 * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
12582 instructions.
12583 (aarch64_analyze_prologue_test): Add PACIASP test.
12584 (aarch64_prologue_prev_register): Unmask PC value.
12585
12586 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12587 Jiong Wang <jiong.wang@arm.com>
12588
12589 * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
12590 (aarch64_dwarf2_prev_register): Unmask PC value.
12591 (aarch64_dwarf2_frame_init_reg): Init pauth registers.
12592 (aarch64_execute_dwarf_cfa_vendor_op): Check for
12593 DW_CFA_AARCH64_negate_ra_state.
12594 (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
12595
12596 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12597 Jiong Wang <jiong.wang@arm.com>
12598
12599 * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
12600 registers.
12601 (aarch64_pseudo_register_name): Likewise.
12602 (aarch64_pseudo_register_type): Likewise.
12603 (aarch64_pseudo_register_reggroup_p): Likewise.
12604 (aarch64_gdbarch_init): Add pauth registers.
12605 * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
12606 (AARCH64_DWARF_PAUTH_DMASK): Likewise.
12607 (AARCH64_DWARF_PAUTH_CMASK): Likewise.
12608 (struct gdbarch_tdep): Add regnum for ra_state.
12609
12610 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12611 Jiong Wang <jiong.wang@arm.com>
12612
12613 * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
12614
12615 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12616 Jiong Wang <jiong.wang@arm.com>
12617
12618 * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
12619 function.
12620 (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
12621 * aarch64-tdep.c (aarch64_cannot_store_register): New function.
12622 (aarch64_gdbarch_init): Add puth registers.
12623 * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
12624 * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
12625 (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
12626
12627 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12628 Jiong Wang <jiong.wang@arm.com>
12629
12630 * aarch64-linux-nat.c
12631 (aarch64_linux_nat_target::read_description): Read PACA hwcap.
12632 * aarch64-linux-tdep.c
12633 (aarch64_linux_core_read_description): Likewise.
12634 (aarch64_linux_get_hwcap): New function.
12635 * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
12636 (aarch64_linux_get_hwcap): New declaration.
12637
12638 2019-03-22 Alan Hayward <alan.hayward@arm.com>
12639 Jiong Wang <jiong.wang@arm.com>
12640
12641 * aarch64-linux-nat.c
12642 (aarch64_linux_nat_target::read_description): Add pauth param.
12643 * aarch64-linux-tdep.c
12644 (aarch64_linux_core_read_description): Likewise.
12645 * aarch64-tdep.c (struct target_desc): Add in pauth.
12646 (aarch64_read_description): Add pauth param.
12647 (aarch64_gdbarch_init): Likewise.
12648 * aarch64-tdep.h (aarch64_read_description): Likewise.
12649 * arch/aarch64.c (aarch64_create_target_description): Likewise.
12650 * arch/aarch64.h (aarch64_create_target_description): Likewise.
12651 * features/Makefile: Add new files.
12652 * features/aarch64-pauth.c: New file.
12653 * features/aarch64-pauth.xml: New file.
12654
12655 2019-03-20 Tom Tromey <tromey@adacore.com>
12656
12657 * infrun.c (handle_inferior_event): Rename from
12658 handle_inferior_event_1. Create a scoped_value_mark.
12659 (handle_inferior_event): Remove.
12660
12661 2019-03-19 Tom Tromey <tromey@adacore.com>
12662
12663 * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
12664 * infrun.h (print_stop_event): Add "displays" parameter.
12665 * infrun.c (print_stop_event): Add "displays" parameter.
12666
12667 2019-03-19 Pedro Alves <palves@redhat.com>
12668
12669 * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
12670 (tui_ui_out::do_text): Add comments. Reset M_LINE to 0 instead of
12671 to -1. Fix TABs vs spaces.
12672 (tui_ui_out::tui_ui_out): Don't initialize fields here.
12673 * tui/tui-out.h (tui_ui_out) Add intro comments.
12674 <m_line, m_start_of_line>: In-class initialize, and add describing
12675 comment.
12676
12677 2019-03-18 Alan Hayward <alan.hayward@arm.com>
12678
12679 * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
12680 variable names.
12681 (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
12682
12683 2019-03-18 Pedro Alves <palves@redhat.com>
12684 Eli Zaretskii <eliz@gnu.org>
12685
12686 * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
12687 m_line and m_start_of_line.
12688
12689 2019-03-18 Eli Zaretskii <eliz@gnu.org>
12690
12691 * tui/tui-io.c (gdb_wgetch): Don't echo CR.
12692 (tui_getc): When gdb_wgetch returns a CR, behave the same as when
12693 it returns a newline. This fixes a regression in TU mode, whereby
12694 the next line is output on the same screen line as the user input.
12695
12696 2019-03-18 Tom Tromey <tromey@adacore.com>
12697
12698 * minsyms.c (minimal_symbol_reader::install): Remove call to
12699 obstack_blank.
12700
12701 2019-03-18 Pedro Alves <palves@redhat.com>
12702
12703 * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
12704 New globals.
12705 (apply_style): New, factored out from ...
12706 (apply_ansi_escape): ... this. Handle reverse video mode.
12707 (tui_set_reverse_mode): New function.
12708 * tui/tui-io.h (tui_set_reverse_mode): New declaration.
12709 * tui/tui-winsource.c (tui_show_source_line): Use
12710 tui_set_reverse_mode instead of setting A_STANDOUT.
12711 * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
12712 New setter methods.
12713
12714 2019-03-18 Hannes Domani <ssbssa@yahoo.de>
12715
12716 * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
12717 Handle tabs.
12718
12719 2019-03-18 Tom Tromey <tromey@adacore.com>
12720
12721 * ada-lang.c (empty_array): Add "high" parameter.
12722 (ada_evaluate_subexp): Update.
12723
12724 2019-03-17 Sergei Trofimovich <siarheit@google.com>
12725
12726 * unittests/string_view-selftests.c: Define
12727 _initialize_string_view_selftests unconditionally.
12728
12729 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12730
12731 PR gdb/24350
12732 * windows-nat.c (windows_make_so): Remove unused text_vma variable.
12733
12734 2019-03-17 Vladimir Martyanov <vilgeforce@gmail.com>
12735
12736 PR gdb/24351
12737 * windows-nat.c (display_selector): Fix format specifiers.
12738
12739 2019-03-17 Eli Zaretskii <eliz@gnu.org>
12740
12741 * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
12742 tui_refill_source_window instead of tui_refresh_win, to update the
12743 current execution line. This fixes redisplay of the current line
12744 when stepping through the code with "next" or "step".
12745
12746 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12747
12748 * source-cache.c (source_cache::get_source_lines): Call
12749 find_source_lines to initialize s->nlines. This fixes vertical
12750 scrolling of TUI source window when the DOWN arrow is pressed.
12751
12752 2019-03-16 Philippe Waroquiers <philippe.waroquiers@skynet.be>
12753
12754 * auto-load.c (_initialize_auto_load): Fix 'This options has'.
12755 linux-thread-db.c (_initialize_thread_db): Likewise.
12756
12757 2019-03-16 Eli Zaretskii <eliz@gnu.org>
12758
12759 * tui/tui-winsource.c (tui_show_source_line): Revert "Use
12760 wclrtoeol in tui_show_source_line". This reverts changes made in
12761 commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
12762
12763 2019-03-15 Tom Tromey <tom@tromey.com>
12764
12765 * symtab.h (struct minimal_symbol): Derive from
12766 general_symbol_info.
12767 (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
12768 (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
12769 (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
12770 (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
12771 (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
12772 (MSYMBOL_SEARCH_NAME): Update.
12773 (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
12774 * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
12775 * minsyms.c (minimal_symbol_reader::record_full): Update.
12776
12777 2019-03-15 Tom Tromey <tom@tromey.com>
12778
12779 * minsyms.c (minimal_symbol_reader::install): Use memcpy.
12780
12781 2019-03-15 Tom Tromey <tom@tromey.com>
12782
12783 * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
12784 unique_xmalloc_ptr.
12785 (objfile::msymbols_range::begin, objfile::msymbols_range::end):
12786 Update.
12787 * minsyms.c (lookup_minimal_symbol_by_pc_section)
12788 (build_minimal_symbol_hash_tables)
12789 (minimal_symbol_reader::install): Update.
12790
12791 2019-03-15 Tom Tromey <tom@tromey.com>
12792
12793 * symtab.c (create_demangled_names_hash): Update.
12794 (symbol_set_names): Update.
12795 * objfiles.h (struct objfile_per_bfd_storage)
12796 <demangled_names_hash>: Now an htab_up.
12797 * objfiles.c (objfile_per_bfd_storage): Simplify.
12798
12799 2019-03-15 Tom Tromey <tom@tromey.com>
12800
12801 * objfiles.h (struct objfile_per_bfd_storage): Declare
12802 destructor.
12803 * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
12804 New.
12805 (get_objfile_bfd_data): Use new. Don't initialize
12806 language_of_main.
12807 (free_objfile_per_bfd_storage): Remove.
12808 (objfile_bfd_data_free, objfile::~objfile): Use delete.
12809
12810 2019-03-15 Tom Tromey <tom@tromey.com>
12811
12812 * symfile.c (reread_symbols): Update.
12813 * objfiles.c (objfile::objfile): Update.
12814 * minsyms.h (terminate_minimal_symbol_table): Don't declare.
12815 * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
12816 comment.
12817 (minimal_symbol_reader::install): Update.
12818 (terminate_minimal_symbol_table): Remove.
12819 * jit.c (jit_object_close_impl): Update.
12820
12821 2019-03-15 Tom Tromey <tom@tromey.com>
12822
12823 * minsyms.c (minimal_symbol_reader::record_full): Remove some
12824 initializations.
12825
12826 2019-03-15 Tom Tromey <tom@tromey.com>
12827
12828 * objfiles.h (struct objfile_per_bfd_storage)
12829 <demangled_hash_languages>: Now a bitset.
12830 * minsyms.c (add_minsym_to_demangled_hash_table): Update.
12831 (lookup_minimal_symbol): Update.
12832
12833 2019-03-15 Tom Tromey <tom@tromey.com>
12834
12835 * minsyms.h (class minimal_symbol_reader) <record_with_info>:
12836 Don't return the symbol.
12837 * coffread.c (record_minimal_symbol): Use record_full.
12838
12839 2019-03-14 Eli Zaretskii <eliz@gnu.org>
12840
12841 The MS-Windows port of ncurses fails to switch to a color pair if
12842 one or both of the colors are the implicit default colors. This
12843 change records the default colors when TUI is initialized, and
12844 then specifies them explicitly when a color pair uses the default
12845 colors. This allows color styling in TUI mode on MS-Windows.
12846
12847 * tui/tui-io.c [__MINGW32__]: Include windows.h. Declare
12848 ncurses_norm_attr.
12849 (tui_initialize_io) [__MINGW32__]: Record the default terminal
12850 colors in ncurses_norm_attr.
12851 (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
12852 "none", replace it with the default color recorded in
12853 ncurses_norm_attr.
12854
12855 2019-03-14 Tom Tromey <tromey@adacore.com>
12856
12857 * source-cache.h (class source_cache) <get_source_lines>: Return
12858 std::string.
12859 * source-cache.c (source_cache::extract_lines): Handle case where
12860 first_pos==npos. Return std::string.
12861 (source_cache::get_source_lines): Update.
12862
12863 2019-03-14 Tom Tromey <tromey@adacore.com>
12864
12865 * NEWS: Add item for "style sources" commands.
12866 * source-cache.c (source_cache::get_source_lines): Check
12867 source_styling.
12868 * cli/cli-style.c (source_styling): New global.
12869 (_initialize_cli_style): Add "style sources" commands.
12870 (show_style_sources): New function.
12871 * cli/cli-style.h (source_styling): Declare.
12872
12873 2019-03-14 Pedro Alves <palves@redhat.com>
12874 Tom Tromey <tromey@adacore.com>
12875
12876 * tui/tui-winsource.h (tui_refill_source_window): Declare.
12877 * tui/tui-winsource.c (tui_refill_source_window): New function,
12878 from...
12879 (tui_horizontal_source_scroll): ... here. Move some logic.
12880 * cli/cli-style.c (set_style_enabled): Notify new observable.
12881 * tui/tui-hooks.c (tui_redisplay_source): New function.
12882 (tui_attach_detach_observers): Attach or detach
12883 tui_redisplay_source.
12884 * observable.h (source_styling_changed): New observable.
12885 * observable.c: Define source_styling_changed observable.
12886
12887 2019-03-13 Tom Tromey <tromey@adacore.com>
12888
12889 * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
12890 (i386_gnu_nat_target::store_registers): Update.
12891 * target-debug.h (target_debug_print_std_string): New macro.
12892 * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12893 * windows-tdep.c (display_one_tib): Update.
12894 * tui/tui-stack.c (tui_make_status_line): Update.
12895 * top.c (print_inferior_quit_action): Update.
12896 * thread.c (thr_try_catch_cmd): Update.
12897 (add_thread_with_info): Update.
12898 (thread_target_id_str): Update.
12899 (thr_try_catch_cmd): Update.
12900 (thread_command): Update.
12901 (thread_find_command): Update.
12902 * record-btrace.c (record_btrace_target::info_record)
12903 (record_btrace_resume_thread, record_btrace_target::resume)
12904 (record_btrace_cancel_resume, record_btrace_step_thread)
12905 (record_btrace_target::wait, record_btrace_target::wait)
12906 (record_btrace_target::wait, record_btrace_target::stop): Update.
12907 * progspace.c (print_program_space): Update.
12908 * process-stratum-target.c
12909 (process_stratum_target::thread_address_space): Update.
12910 * linux-fork.c (linux_fork_mourn_inferior)
12911 (detach_checkpoint_command, info_checkpoints_command)
12912 (linux_fork_context): Update.
12913 (linux_fork_detach): Update.
12914 (class scoped_switch_fork_info): Update.
12915 (delete_checkpoint_command): Update.
12916 * infrun.c (follow_fork_inferior): Update.
12917 (follow_fork_inferior): Update.
12918 (proceed_after_vfork_done): Update.
12919 (handle_vfork_child_exec_or_exit): Update.
12920 (follow_exec): Update.
12921 (displaced_step_prepare_throw): Update.
12922 (displaced_step_restore): Update.
12923 (start_step_over): Update.
12924 (resume_1): Update.
12925 (clear_proceed_status_thread): Update.
12926 (proceed): Update.
12927 (print_target_wait_results): Update.
12928 (do_target_wait): Update.
12929 (context_switch): Update.
12930 (stop_all_threads): Update.
12931 (restart_threads): Update.
12932 (finish_step_over): Update.
12933 (handle_signal_stop): Update.
12934 (switch_back_to_stepped_thread): Update.
12935 (keep_going_pass_signal): Update.
12936 (print_exited_reason): Update.
12937 (normal_stop): Update.
12938 * inferior.c (inferior_pid_to_str): Change return type.
12939 (print_selected_inferior): Update.
12940 (add_inferior): Update.
12941 (detach_inferior): Update.
12942 * dummy-frame.c (fprint_dummy_frames): Update.
12943 * dcache.c (dcache_info_1): Update.
12944 * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
12945 (btrace_fetch, btrace_clear): Update.
12946 * linux-tdep.c (linux_core_pid_to_str): Change return type.
12947 * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
12948 type.
12949 * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
12950 * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
12951 * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
12952 * gdbarch.c, gdbarch.h: Rebuild.
12953 * gdbarch.sh (core_pid_to_str): Change return type.
12954 * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
12955 return type.
12956 (windows_nat_target::pid_to_str): Change return type.
12957 (windows_delete_thread): Update.
12958 (windows_nat_target::attach): Update.
12959 (windows_nat_target::files_info): Update.
12960 * target-delegates.c: Rebuild.
12961 * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
12962 return type.
12963 (sol_thread_target::pid_to_str): Change return type.
12964 * remote.c (class remote_target) <pid_to_str>: Change return
12965 type.
12966 (remote_target::pid_to_str): Change return type.
12967 (extended_remote_target::attach, remote_target::remote_stop_ns)
12968 (remote_target::remote_notif_remove_queued_reply)
12969 (remote_target::push_stop_reply, remote_target::disable_btrace):
12970 Update.
12971 (extended_remote_target::attach): Update.
12972 * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
12973 type.
12974 (gdbsim_target::pid_to_str): Change return type.
12975 * ravenscar-thread.c (struct ravenscar_thread_target)
12976 <pid_to_str>: Change return type.
12977 (ravenscar_thread_target::pid_to_str): Change return type.
12978 * procfs.c (class procfs_target) <pid_to_str>: Change return
12979 type.
12980 (procfs_target::pid_to_str): Change return type.
12981 (procfs_target::attach): Update.
12982 (procfs_target::detach): Update.
12983 (procfs_target::fetch_registers): Update.
12984 (procfs_target::store_registers): Update.
12985 (procfs_target::wait): Update.
12986 (procfs_target::files_info): Update.
12987 * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
12988 * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
12989 return type.
12990 (nto_procfs_target::pid_to_str): Change return type.
12991 (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
12992 * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
12993 return type.
12994 * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
12995 (exit_lwp): Update.
12996 (attach_proc_task_lwp_callback, get_detach_signal)
12997 (detach_one_lwp, resume_lwp, linux_nat_target::resume)
12998 (linux_nat_target::resume, wait_lwp, stop_callback)
12999 (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13000 (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13001 (linux_nat_wait_1, resume_stopped_resumed_lwps)
13002 (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13003 * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13004 type.
13005 (inf_ptrace_target::attach): Update.
13006 (inf_ptrace_target::files_info): Update.
13007 * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13008 type.
13009 (go32_nat_target::pid_to_str): Change return type.
13010 * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13011 (gnu_nat_target::wait): Update.
13012 (gnu_nat_target::wait): Update.
13013 (gnu_nat_target::resume): Update.
13014 * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13015 (fbsd_nat_target::wait): Update.
13016 * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13017 type.
13018 (darwin_nat_target::attach): Update.
13019 * corelow.c (class core_target) <pid_to_str>: Change return type.
13020 (core_target::pid_to_str): Change return type.
13021 * target.c (normal_pid_to_str): Change return type.
13022 (default_pid_to_str): Likewise.
13023 (target_pid_to_str): Change return type.
13024 (target_translate_tls_address): Update.
13025 (target_announce_detach): Update.
13026 * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13027 return type.
13028 (bsd_uthread_target::pid_to_str): Change return type.
13029 * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13030 type.
13031 (bsd_kvm_target::pid_to_str): Change return type.
13032 * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13033 return type.
13034 (aix_thread_target::pid_to_str): Change return type.
13035 * target.h (struct target_ops) <pid_to_str>: Change return type.
13036 (target_pid_to_str, normal_pid_to_str): Likewise.
13037 * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13038 type.
13039 * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13040 type.
13041 * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13042 return type.
13043 * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13044 type.
13045 * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13046 type.
13047 * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13048 return type.
13049
13050 2019-03-13 Simon Marchi <simon.marchi@ericsson.com>
13051
13052 * NEWS: Mention that the new default MI version is 3. Mention
13053 changes to the output of commands and events that deal with
13054 multi-location breakpoints.
13055 * breakpoint.c: Include "mi/mi-out.h".
13056 (print_one_breakpoint): Change output syntax if using MI version
13057 >= 3.
13058 * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13059 New.
13060 (mi_multi_location_breakpoint_output_fixed): New.
13061 * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13062 (mi_cmd_fix_multi_location_breakpoint_output): New.
13063 (mi_multi_location_breakpoint_output_fixed): New.
13064 * mi/mi-cmds.c (mi_cmds): Register command
13065 -fix-multi-location-breakpoint-output.
13066 * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13067 interpreter "mi".
13068
13069 2019-03-13 Simon Marchi <simon.marchi@polymtl.ca>
13070
13071 * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13072 * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13073 instantiate mi_ui_out based on interpreter name.
13074 * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13075 * mi/mi-main.c (mi_load_progress): Likewise.
13076
13077 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13078
13079 * NEWS: Combine separate "New targets" sections for 8.3.
13080
13081 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13082
13083 * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13084 (ppcfbsd_init_abi): Install gdbarch
13085 "fetch_tls_load_module_address" and "get_thread_local_address"
13086 methods.
13087
13088 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13089
13090 * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13091 (riscv_fbsd_init_abi): Install gdbarch
13092 "fetch_tls_load_module_address" and "get_thread_local_address"
13093 methods.
13094
13095 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13096
13097 * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13098 (i386fbsd_init_abi): Install gdbarch
13099 "fetch_tls_load_module_address" and "get_thread_local_address"
13100 methods.
13101
13102 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13103
13104 * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13105 (amd64fbsd_init_abi): Install gdbarch
13106 "fetch_tls_load_module_address" and "get_thread_local_address"
13107 methods.
13108
13109 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13110
13111 * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13112 (struct fbsd_pspace_data): New type.
13113 (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13114 (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13115 (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13116 (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13117 * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13118
13119 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13120
13121 * gdbtypes.c (lookup_struct_elt): New function.
13122 (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13123 * gdbtypes.h (struct struct_elt): New type.
13124 (lookup_struct_elt): New prototype.
13125
13126 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13127
13128 * gdbtypes.c (lookup_struct_elt_type): Update comment and
13129 remove disabled code block.
13130
13131 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13132
13133 * gdbarch.sh (get_thread_local_address): New method.
13134 * gdbarch.h, gdbarch.c: Regenerate.
13135 * target.c (target_translate_tls_address): Use
13136 gdbarch_get_thread_local_address if present instead of
13137 target::get_thread_local_address.
13138
13139 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13140
13141 * target.h (target::get_thread_local_address): Update comment.
13142
13143 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13144
13145 * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13146 objfile->separate_debug_objfile_backlink if not NULL.
13147
13148 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13149
13150 * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13151 tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13152 (amd64bsd_store_inferior_registers): Likewise.
13153 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13154 Enable segment base registers.
13155 * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13156 PT_GETFSBASE and PT_GETGSBASE.
13157 (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13158 PT_SETGSBASE.
13159 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13160 segment base registers.
13161 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13162
13163 2019-03-12 John Baldwin <jhb@FreeBSD.org>
13164
13165 * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13166 Update calls to i386_target_description to add 'segments'
13167 parameter.
13168 * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum. Don't
13169 add segment base registers.
13170 * arch/i386.c (i386_create_target_description): Add 'segments'
13171 parameter to enable segment base registers.
13172 * arch/i386.h (i386_create_target_description): Likewise.
13173 * features/i386/32bit-segments.xml: New file.
13174 * features/i386/32bit-segments.c: Generate.
13175 * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13176 call to i386_target_description to add 'segments' parameter.
13177 * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13178 * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13179 * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13180 * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13181 if feature is present.
13182 (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13183 Add 'segments' parameter to call to i386_target_description.
13184 (i386_target_description): Add 'segments' parameter to enable
13185 segment base registers.
13186 (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13187 to call to i386_target_description.
13188 * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13189 (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13190 Define I386_NUM_REGS.
13191 (i386_target_description): Add 'segments' parameter to enable
13192 segment base registers.
13193
13194 2019-03-12 Eli Zaretskii <eliz@gnu.org>
13195
13196 PR/24325
13197 * source-cache.c: #undef open and close, to avoid unresolved
13198 externals during linking.
13199
13200 2019-03-12 Tom Tromey <tromey@adacore.com>
13201
13202 * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13203 const. Add initializers.
13204 (_initialize_remote): Don't initialize ptid globals.
13205
13206 2019-03-12 Pedro Alves <palves@redhat.com>
13207
13208 * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13209
13210 2019-03-12 Pedro Alves <palves@redhat.com>
13211
13212 * cp-name-parser.y (main): Remove unused 'len' variable.
13213
13214 2019-03-12 Tom Tromey <tromey@adacore.com>
13215
13216 * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13217 * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13218
13219 2019-03-12 Tom Tromey <tromey@adacore.com>
13220
13221 * linux-nat.c (iterate_over_lwps): Update.
13222 (stop_callback): Remove parameter.
13223 (stop_wait_callback, detach_callback, resume_set_callback)
13224 (select_singlestep_lwp_callback, set_ignore_sigint)
13225 (status_callback, resumed_callback, resume_clear_callback)
13226 (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13227 data parameter.
13228 (linux_nat_target::detach, linux_nat_target::resume)
13229 (linux_stop_and_wait_all_lwps, select_event_lwp)
13230 (linux_nat_filter_event, linux_nat_wait_1)
13231 (linux_nat_target::kill, linux_nat_target::stop)
13232 (linux_nat_target::stop): Update.
13233 (linux_nat_resume_callback): Change type.
13234 (resume_stopped_resumed_lwps, count_events_callback)
13235 (select_event_lwp_callback): Likewise.
13236 (linux_stop_lwp, linux_nat_stop_lwp): Update.
13237 * arm-linux-nat.c (struct update_registers_data): Remove.
13238 (update_registers_callback): Change type.
13239 (arm_linux_insert_hw_breakpoint1): Update.
13240 * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13241 parameter.
13242 (x86_linux_dr_set_addr): Update.
13243 (x86_linux_dr_set_control): Update.
13244 * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13245 (iterate_over_lwps): Use gdb::function_view.
13246 * nat/aarch64-linux-hw-point.c (struct
13247 aarch64_dr_update_callback_param): Remove.
13248 (debug_reg_change_callback): Change type.
13249 (aarch64_notify_debug_reg_change): Update.
13250 * s390-linux-nat.c (s390_refresh_per_info): Update.
13251
13252 2019-03-11 Tom Tromey <tromey@adacore.com>
13253
13254 * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
13255 redundant assignment to "this_cu".
13256
13257 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13258
13259 * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
13260
13261 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13262
13263 * gdbtypes.c (rank_one_type_parm_set): New function extracted
13264 from...
13265 (rank_one_type): ... this.
13266
13267 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13268
13269 * gdbtypes.c (rank_one_type_parm_struct): New function extracted
13270 from...
13271 (rank_one_type): ... this.
13272
13273 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13274
13275 * gdbtypes.c (rank_one_type_parm_complex): New function extracted
13276 from...
13277 (rank_one_type): ... this.
13278
13279 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13280
13281 * gdbtypes.c (rank_one_type_parm_float): New function extracted
13282 from...
13283 (rank_one_type): ... this.
13284
13285 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13286
13287 * gdbtypes.c (rank_one_type_parm_bool): New function extracted
13288 from...
13289 (rank_one_type): ... this.
13290
13291 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13292
13293 * gdbtypes.c (rank_one_type_parm_range): New function extracted
13294 from...
13295 (rank_one_type): ... this.
13296
13297 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13298
13299 * gdbtypes.c (rank_one_type_parm_char): New function extracted
13300 from...
13301 (rank_one_type): ... this.
13302
13303 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13304
13305 * gdbtypes.c (rank_one_type_parm_enum): New function extracted
13306 from...
13307 (rank_one_type): ... this.
13308
13309 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13310
13311 * gdbtypes.c (rank_one_type_parm_int): New function extracted
13312 from...
13313 (rank_one_type): ... this.
13314
13315 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13316
13317 * gdbtypes.c (rank_one_type_parm_func): New function extracted
13318 from...
13319 (rank_one_type): ... this.
13320
13321 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13322
13323 * gdbtypes.c (rank_one_type_parm_array): New function extracted
13324 from...
13325 (rank_one_type): ... this.
13326
13327 2019-03-08 Simon Marchi <simon.marchi@efficios.com>
13328
13329 * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
13330 from...
13331 (rank_one_type): ... this.
13332
13333 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13334
13335 * inferior.c (initialize_inferiors): Ensure 'help set/show print
13336 inferior-events' shows the example events.
13337
13338 2019-03-08 Eli Zaretskii <eliz@gnu.org>
13339
13340 Support styling on native MS-Windows console
13341
13342 PR/24315
13343 * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
13344 on MS-Windows if $TERM is not defined.
13345
13346 * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
13347
13348 * posix-hdep.c (gdb_console_fputs):
13349 * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
13350 functions.
13351 * ui-file.h (gdb_console_fputs): Add prototype.
13352
13353 * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
13354 back to fputs only if the former returns zero.
13355
13356 2019-03-07 Tom Tromey <tom@tromey.com>
13357
13358 * symmisc.c (print_symbol_bcache_statistics): Update.
13359 (print_objfile_statistics): Update.
13360 * symfile.c (allocate_symtab): Update.
13361 * stabsread.c: Don't include bcache.h.
13362 * psymtab.h (struct psymbol_bcache): Don't declare.
13363 (class psymtab_storage) <psymbol_cache>: Now a bcache.
13364 (psymbol_bcache_init, psymbol_bcache_free)
13365 (psymbol_bcache_get_bcache): Don't declare.
13366 * psymtab.c (struct psymbol_bcache): Remove.
13367 (psymtab_storage::psymtab_storage): Update.
13368 (psymtab_storage::~psymtab_storage): Update.
13369 (psymbol_bcache_init, psymbol_bcache_free)
13370 (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
13371 (add_psymbol_to_bcache): Update.
13372 (allocate_psymtab): Update.
13373 * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
13374 macro_cache>: No longer pointers.
13375 * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
13376 (free_objfile_per_bfd_storage): Don't call bcache_xfree.
13377 * macrotab.c (macro_bcache): Update.
13378 * macroexp.c: Don't include bcache.h.
13379 * gdbtypes.c (check_types_worklist): Update.
13380 (types_deeply_equal): Remove TRY/CATCH. Update.
13381 * elfread.c (elf_symtab_read): Update.
13382 * dwarf2read.c: Don't include bcache.h.
13383 * buildsym.c (buildsym_compunit::get_macro_table): Update.
13384 * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
13385 (print_bcache_statistics, bcache_memory_used): Don't declare.
13386 (struct bcache): Move from bcache.c. Add constructor, destructor,
13387 methods. Rename all data members.
13388 * bcache.c (struct bcache): Move to bcache.h.
13389 (bcache::expand_hash_table): Rename from expand_hash_table.
13390 (bcache): Remove.
13391 (bcache::insert): Rename from bcache_full.
13392 (bcache::compare): Rename from bcache_compare.
13393 (bcache_xmalloc): Remove.
13394 (bcache::~bcache): Rename from bcache_xfree.
13395 (bcache::print_statistics): Rename from print_bcache_statistics.
13396 (bcache::memory_used): Rename from bcache_memory_used.
13397
13398 2019-03-07 Pedro Alves <palves@redhat.com>
13399
13400 * infrun.c (normal_stop): Also check for
13401 TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
13402
13403 2019-03-07 Andrew Burgess <andrew.burgess@embecosm.com>
13404
13405 * f-lang.c (value_from_host_double): Moved to...
13406 * value.c (value_from_host_double): ...here.
13407 * value.h (value_from_host_double): Declare.
13408 * guile/scm-math.c (vlscm_convert_typed_number): Use
13409 value_from_host_double.
13410 (vlscm_convert_number): Likewise.
13411 * guile/scm-value.c (gdbscm_value_to_real): Likewise.
13412 * python/py-value.c (convert_value_from_python): Likewise.
13413
13414 2019-03-06 Tom Tromey <tom@tromey.com>
13415
13416 * gcore.c (write_gcore_file): Use SCOPE_EXIT.
13417
13418 2019-03-06 Tom Tromey <tom@tromey.com>
13419
13420 * utils.h (free_current_contents): Don't declare.
13421 * utils.c (free_current_contents): Remove.
13422
13423 2019-03-06 Tom Tromey <tom@tromey.com>
13424
13425 * top.c (quit_force): Update.
13426 * main.c (captured_command_loop): Update.
13427 * common/new-op.c (operator new): Update.
13428 * common/common-exceptions.c (struct catcher)
13429 <save_cleanup_chain>: Remove member.
13430 (exceptions_state_mc_init): Update.
13431 (exception_try_scope_entry): Return nullptr.
13432 (exception_try_scope_exit, exception_rethrow)
13433 (throw_exception_sjlj, throw_exception_cxx): Update.
13434 * common/cleanups.h (make_cleanup, make_cleanup_dtor)
13435 (all_cleanups, do_cleanups, discard_cleanups)
13436 (discard_final_cleanups, save_cleanups, save_final_cleanups)
13437 (restore_cleanups, restore_final_cleanups): Don't declare.
13438 (do_final_cleanups): Remove parameter.
13439 * common/cleanups.c (cleanup_chain, make_cleanup)
13440 (make_cleanup_dtor, all_cleanups, do_cleanups)
13441 (discard_my_cleanups, discard_cleanups)
13442 (discard_final_cleanups, save_my_cleanups, save_cleanups)
13443 (save_final_cleanups, restore_my_cleanups, restore_cleanups)
13444 (null_cleanup): Remove.
13445 (do_final_cleanups): Remove parameter.
13446
13447 2019-03-06 Tom Tromey <tom@tromey.com>
13448
13449 * remote.c (remote_target::remote_parse_stop_reply): Use
13450 unique_xmalloc_ptr.
13451
13452 2019-03-06 Tom Tromey <tom@tromey.com>
13453
13454 * stabsread.c (struct stabs_field_info): Rename from field_info.
13455 <list, fnlist>: Add initializers.
13456 <obstack>: New member.
13457 (read_member_functions, read_struct_fields, read_baseclasses):
13458 Allocate on obstack. Don't use cleanups.
13459 (read_one_struct_field, read_member_functions, read_struct_fields)
13460 (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
13461 (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
13462 (read_struct_type): Update.
13463
13464 2019-03-06 Tom Tromey <tom@tromey.com>
13465
13466 * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
13467 * common/filestuff.h (make_cleanup_close): Don't declare.
13468 * common/filestuff.c (do_close_cleanup, make_cleanup_close):
13469 Remove.
13470
13471 2019-03-06 Tom Tromey <tom@tromey.com>
13472
13473 * solib-aix.c: Use make_scope_exit.
13474
13475 2019-03-06 Tom Tromey <tom@tromey.com>
13476
13477 * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
13478 Use make_scope_exit.
13479
13480 2019-03-06 Tom Tromey <tom@tromey.com>
13481
13482 * solib-svr4.c (disable_probes_interface): Remove parameter.
13483 (svr4_handle_solib_event): Use make_scope_exit.
13484
13485 2019-03-06 Tom Tromey <tom@tromey.com>
13486
13487 * remote.c (struct stop_reply_deleter): Remove.
13488 (stop_reply_up): Update.
13489 (struct stop_reply): Derive from notif_event. Don't typedef.
13490 <regcache>: Now a std::vector.
13491 (stop_reply_xfree): Remove.
13492 (stop_reply::~stop_reply): Rename from stop_reply_dtr.
13493 (remote_notif_stop_alloc_reply): Return a unique_ptr. Use new.
13494 (remote_target::discard_pending_stop_replies): Use delete.
13495 (remote_target::remote_parse_stop_reply): Update.
13496 (remote_target::process_stop_reply): Update.
13497 * remote-notif.h (struct notif_event): Add virtual destructor.
13498 Remove "dtr" member.
13499 (struct notif_client) <alloc_event>: Return a unique_ptr.
13500 (notif_event_xfree): Don't declare.
13501 (notif_event_up): New typedef.
13502 * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
13503 (notif_event_xfree, do_notif_event_xfree): Remove.
13504 (remote_notif_state_xfree): Update.
13505
13506 2019-03-06 Tom Tromey <tom@tromey.com>
13507
13508 * infrun.c (displaced_step_clear_cleanup): Now a
13509 forward_scope_exit type.
13510 (displaced_step_prepare_throw): Update.
13511 (displaced_step_fixup): Update.
13512
13513 2019-03-06 Tom Tromey <tom@tromey.com>
13514
13515 * inferior.h (class inferior): Update comment.
13516 * gdbthread.h (class thread_info): Update comment.
13517
13518 2019-03-06 Joel Brobecker <brobecker@adacore.com>
13519 Tom Tromey <tom@tromey.com>
13520
13521 * stabsread.h (struct stab_section_list): Remove.
13522 (coffstab_build_psymtabs): Update.
13523 * dbxread.c (symbuf_sections): Now a std::vector.
13524 (sect_idx): New global.
13525 (fill_symbuf): Update.
13526 (coffstab_build_psymtabs): Change type of stabsects parameter.
13527 Update.
13528 * coffread.c (struct coff_symfile_info) <stabsects>: Now a
13529 std::vector.
13530 (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
13531 (coff_locate_sections): Update.
13532 (coff_symfile_read): Remove cleanups. Update.
13533 (init_stringtab): Add storage parameter.
13534 (free_stringtab, free_stringtab_cleanup): Remove.
13535 (init_lineno): Add storage parameter.
13536 (free_linetab, free_linetab_cleanup): Remove.
13537
13538 2019-03-06 Pedro Alves <palves@redhat.com>
13539
13540 * linux-fork.c (fork_info::clobber_regs): Delete.
13541 (fork_load_infrun_state): Remove reference to 'clobber_regs'.
13542 (fork_save_infrun_state): Remove 'clobber_regs' parameter. Update
13543 comment. Adjust.
13544 (scoped_switch_fork_info::scoped_switch_fork_info)
13545 (checkpoint_command, linux_fork_context): Adjust
13546 fork_save_infrun_state calls.
13547
13548 2019-03-06 Pedro Alves <palves@redhat.com>
13549
13550 * linux-fork.c (inf_has_multiple_thread_cb): Delete.
13551 (inf_has_multiple_threads): Return 'bool' and rewrite using
13552 inferior_info::threads().
13553
13554 2019-03-06 Pedro Alves <palves@redhat.com>
13555
13556 * linux-fork.c: Include <list>.
13557 (fork_list): Now a std::list instance.
13558 (fork_info): Add ctor, dtor, and in-class initialize all fields.
13559 (forks_exist_p, find_last_fork): Adjust.
13560 (new_fork): Delete.
13561 (one_fork_p): New.
13562 (add_fork): Adjust.
13563 (free_fork): Delete, folded into fork_info::~fork_info().
13564 (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
13565 Adjust.
13566 (init_fork_list): Delete.
13567 (linux_fork_killall, linux_fork_mourn_inferior)
13568 (linux_fork_detach, info_checkpoints_command): Adjust.
13569 (_initialize_linux_fork): No longer call init_fork_list.
13570
13571 2019-03-06 Pedro Alves <palves@redhat.com>
13572
13573 * linux-fork.c (new_fork): New, split out of ...
13574 (add_fork): ... this. Return void. Move "first fork" special
13575 case from here, to ...
13576 (checkpoint_command): ... here.
13577 * linux-linux.h (add_fork): Return void.
13578
13579 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13580
13581 * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
13582
13583 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13584 Chris January <chris.january@arm.com>
13585 David Lecomber <david.lecomber@arm.com>
13586
13587 * f-exp.y: New token, UNOP_INTRINSIC.
13588 (exp): New pattern using UNOP_INTRINSIC token.
13589 (f77_keywords): Add 'abs' keyword.
13590 * f-lang.c: Add 'target-float.h' and 'math.h' includes.
13591 (value_from_host_double): New function.
13592 (evaluate_subexp_f): Support UNOP_ABS.
13593
13594 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13595
13596 * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
13597 types.
13598
13599 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13600
13601 * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
13602 * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
13603 * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
13604
13605 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13606
13607 * f-exp.y (convert_to_kind_type): Handle more type kinds.
13608
13609 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13610 Chris January <chris.january@arm.com>
13611
13612 * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
13613 * f-exp.y: Define 'KIND' token.
13614 (exp): New pattern for KIND expressions.
13615 (ptype): Handle types with a kind extension.
13616 (direct_abs_decl): Extend to spot kind extensions.
13617 (f77_keywords): Add 'kind' to the list.
13618 (push_kind_type): New function.
13619 (convert_to_kind_type): New function.
13620 * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
13621 * parse.c (operator_length_standard): Likewise.
13622 * parser-defs.h (enum type_pieces): Add tp_kind.
13623 * std-operator.def: Add UNOP_KIND.
13624
13625 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13626
13627 * f-exp.y (f_parse): Set yydebug.
13628
13629 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13630
13631 * f-lang.c (evaluate_subexp_f): New function.
13632 (exp_descriptor_f): New global.
13633 (f_language_defn): Use exp_descriptor_f instead of
13634 exp_descriptor_standard.
13635
13636 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13637
13638 * f-exp.y (struct token): Add comments.
13639 (dot_ops): Remove uppercase versions and the end marker.
13640 (f77_keywords): Likewise.
13641 (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
13642 entries in the dot_ops array are case insensitive, and use
13643 strncasecmp to compare strings. Also some whitespace cleanup in
13644 this area. Similar for the f77_keywords array, except entries in
13645 this list might be case sensitive.
13646
13647 2019-03-06 Andrew Burgess <andrew.burgess@embecosm.com>
13648
13649 * f-exp.y (struct f77_boolean_val): Add comments.
13650 (boolean_values): Remove uppercase versions, and end marker.
13651 (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
13652 and use strncasecmp to achieve case insensitivity. Additionally,
13653 perform whitespace cleanup around this code.
13654
13655 2019-03-06 Tom Tromey <tromey@adacore.com>
13656
13657 * remote-sim.c (gdbsim_target_open): Use result of
13658 gdb_argv::release.
13659
13660 2019-03-06 Richard Bunt <richard.bunt@arm.com>
13661 Dirk Schubert <dirk.schubert@arm.com>
13662 Chris January <chris.january@arm.com>
13663
13664 * eval.c (evaluate_subexp_standard): Call Fortran argument
13665 wrapping logic.
13666 * f-lang.c (struct value): A value which can be passed into a
13667 Fortran function call.
13668 (fortran_argument_convert): Wrap Fortran arguments in a pointer
13669 where appropriate.
13670 (struct type): Value ready for a Fortran function call.
13671 (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
13672 is needed.
13673 * f-lang.h (fortran_argument_convert): Declaration.
13674 (fortran_preserve_arg_pointer): Declaration.
13675 * infcall.c (value_arg_coerce): Call Fortran argument logic.
13676
13677 2019-03-05 Tom Tromey <tromey@adacore.com>
13678
13679 * python/py-prettyprint.c (print_string_repr): Remove #if.
13680 * python/py-utils.c (unicode_to_encoded_string): Remove #if.
13681
13682 2019-03-05 Tom Tromey <tromey@adacore.com>
13683
13684 * target.c (the_dummy_target): Move later. Change type to
13685 "dummy_target".
13686 (initialize_targets): Don't initialize the_dummy_target.
13687
13688 2019-03-05 Tom Tromey <tromey@adacore.com>
13689
13690 * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
13691 * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
13692
13693 2019-03-05 Tom Tromey <tromey@adacore.com>
13694
13695 * windows-nat.c (windows_nat_target::attach)
13696 (windows_nat_target::detach): Don't call gdb_flush.
13697 * valprint.c (generic_val_print, val_print, val_print_string):
13698 Don't call gdb_flush.
13699 * utils.c (defaulted_query): Don't call gdb_flush.
13700 * typeprint.c (print_type_scalar): Don't call gdb_flush.
13701 * target.c (target_announce_detach): Don't call gdb_flush.
13702 * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
13703 * remote.c (extended_remote_target::attach): Don't call
13704 gdb_flush.
13705 * procfs.c (procfs_target::detach): Don't call gdb_flush.
13706 * printcmd.c (do_examine): Don't call gdb_flush.
13707 (info_display_command): Don't call gdb_flush.
13708 * p-valprint.c (pascal_val_print): Don't call gdb_flush.
13709 * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
13710 * memattr.c (info_mem_command): Don't call gdb_flush.
13711 * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
13712 * m2-valprint.c (m2_val_print): Don't call gdb_flush.
13713 * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
13714 * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
13715 * hppa-tdep.c (unwind_command): Don't call gdb_flush.
13716 * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
13717 (gnu_nat_target::detach): Don't call gdb_flush.
13718 * f-valprint.c (f_val_print): Don't call gdb_flush.
13719 * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
13720 * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
13721 * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
13722 gdb_flush.
13723 * c-valprint.c (c_val_print): Don't call gdb_flush.
13724 * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
13725
13726 2019-03-05 Tom Tromey <tromey@adacore.com>
13727
13728 * varobj.c (update_dynamic_varobj_children): Update.
13729 (install_default_visualizer): Use reset, not release.
13730 * value.c (set_internalvar): Update.
13731 * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
13732 * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
13733 ATTRIBUTE_UNUSED_RESULT.
13734
13735 2019-03-05 Tom Tromey <tromey@adacore.com>
13736
13737 * remote.c (class scoped_remote_fd) <release>: Add
13738 ATTRIBUTE_UNUSED_RESULT.
13739
13740 2019-03-05 Tom Tromey <tromey@adacore.com>
13741
13742 * macroexp.c (struct macro_buffer) <release>: Add
13743 ATTRIBUTE_UNUSED_RESULT.
13744
13745 2019-03-05 Tom Tromey <tromey@adacore.com>
13746
13747 * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
13748 * common/scoped_mmap.h (class scoped_mmap) <release>: Add
13749 ATTRIBUTE_UNUSED_RESULT.
13750
13751 2019-03-05 Tom Tromey <tromey@adacore.com>
13752
13753 * common/scoped_fd.h (class scoped_fd) <release>: Add
13754 ATTRIBUTE_UNUSED_RESULT.
13755
13756 2019-03-05 Tom Tromey <tromey@adacore.com>
13757
13758 * parser-defs.h (struct parser_state) <release>: Add
13759 ATTRIBUTE_UNUSED_RESULT.
13760
13761 2019-03-05 Tom Tromey <tromey@adacore.com>
13762
13763 * utils.h (class gdb_argv) <release>: Add
13764 ATTRIBUTE_UNUSED_RESULT.
13765 * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
13766
13767 2019-03-02 Eli Zaretskii <eliz@gnu.org>
13768
13769 * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
13770 for-loop range, to avoid compiler warnings.
13771
13772 * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
13773 avoid compiler warnings about unused variables.
13774
13775 * NEWS: Mention end of support for native debugging on MS-Windows
13776 before XP.
13777
13778 PR gdb/24292
13779 * common/netstuff.c:
13780 * gdbserver/gdbreplay.c
13781 * gdbserver/remote-utils.c:
13782 * ser-tcp.c:
13783 * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
13784 Include ws2tcpip.h instead of wsiapi.h and winsock2.h. Redefine
13785 _WIN32_WINNT to 0x0501 if defined to a smaller value, as
13786 'getaddrinfo' and 'freeaddrinfo' were not available before
13787 Windows XP, and mingw.org's MinGW headers by default define
13788 _WIN32_WINNT to 0x500.
13789
13790 2019-03-01 Gary Benson <gbenson@redhat.com>
13791
13792 * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
13793
13794 2019-02-28 Brian Vandenberg <phantall@gmail.com>
13795 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
13796
13797 PR gdb/8527
13798 * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
13799 set_sigint_trap, clear_sigint_trap.
13800
13801 2019-02-27 Philippe Waroquiers <philippe.waroquiers@skynet.be>
13802
13803 * target.c (target_detach): Clear the regcache and the
13804 frame cache.
13805
13806 2019-02-27 Pedro Alves <palves@redhat.com>
13807
13808 * utils.c (set_screen_size): When we cap the height/width sizes,
13809 tweak the corresponding command variable to show "unlimited":
13810
13811 2019-02-27 Saagar Jha <saagar@saagarjha.com>
13812 Pedro Alves <palves@redhat.com>
13813
13814 * utils.c (set_screen_size): Reduce "infinite" rows and columns
13815 before calling rl_set_screen_size.
13816
13817 2019-02-27 Tom Tromey <tromey@adacore.com>
13818
13819 * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
13820 define.
13821 * python/py-value.c: Remove Python 2.4 workaround.
13822 * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
13823 workaround.
13824 * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
13825 Python 2.4 workaround.
13826 * python/python-internal.h: Remove Python 2.4 comment.
13827 (Py_ssize_t): Don't define.
13828 (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
13829 (gdb_Py_DECREF): Remove Python 2.4 workaround.
13830 (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
13831 (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
13832 * python/python.c (do_start_initialization): Remove Python 2.4
13833 workaround.
13834 * python/py-prettyprint.c (class dummy_python_frame): Remove.
13835 (print_children): Remove Python 2.4 workaround.
13836 * python/py-inferior.c (buffer_procs): Remove Python 2.4
13837 workaround.
13838 (CHARBUFFERPROC_NAME): Remove.
13839 * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
13840 Python 2.4 workaround.
13841
13842 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13843
13844 * NEWS: Note minimum Python version.
13845
13846 2019-02-27 Kevin Buettner <kevinb@redhat.com>
13847
13848 * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
13849 code from these functions. Remove corresponding ifdefs. Use
13850 Py_buffer_up instead of explicit calls to PyBuffer_Release.
13851 Remove gotos and target of gotos.
13852 (infpy_search_memory): Likewise.
13853
13854 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13855
13856 * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
13857 (hppa_gdbarch_init): Don't register deleted functions with
13858 gdbarch.
13859
13860 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13861
13862 * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
13863 (h8300_unwind_sp): Delete.
13864 (h8300_dummy_id): Delete.
13865 (h8300_gdbarch_init): Don't register deleted functions with
13866 gdbarch.
13867
13868 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13869
13870 * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
13871 (ft32_unwind_pc): Delete.
13872 (ft32_unwind_sp): Delete.
13873 (ft32_gdbarch_init): Don't register deleted functions with
13874 gdbarch.
13875
13876 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13877
13878 * gdb/frv-tdep.c (frv_dummy_id): Delete.
13879 (frv_unwind_pc): Delete.
13880 (frv_unwind_sp): Delete.
13881 (frv_gdbarch_init): Don't register deleted functions with
13882 gdbarch.
13883
13884 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13885
13886 * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
13887 (riscv_unwind_pc): Delete.
13888 (riscv_unwind_sp): Delete.
13889 (riscv_gdbarch_init): Don't register deleted functions with
13890 gdbarch.
13891
13892 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13893
13894 * gdb/csky-tdep.c (csky_dummy_id): Delete.
13895 (csky_unwind_pc): Delete.
13896 (csky_unwind_sp): Delete.
13897 (csky_gdbarch_init): Don't register deleted functions with
13898 gdbarch.
13899
13900 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13901
13902 * gdb/cris-tdep.c (cris_dummy_id): Delete.
13903 (cris_unwind_pc): Delete.
13904 (cris_unwind_sp): Delete.
13905 (cris_gdbarch_init): Don't register deleted functions with
13906 gdbarch.
13907
13908 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13909
13910 * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
13911 (bfin_unwind_pc): Delete.
13912 (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
13913
13914 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13915
13916 * gdb/arm-tdep.c (arm_dummy_id): Delete.
13917 (arm_unwind_pc): Delete.
13918 (arm_unwind_sp): Delete.
13919 (arm_gdbarch_init): Don't register deleted functions with gdbarch.
13920
13921 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13922
13923 * gdb/arc-tdep.c (arc_dummy_id): Delete.
13924 (arc_unwind_pc): Delete.
13925 (arc_unwind_sp): Delete.
13926 (arc_gdbarch_init): Don't register deleted functions with gdbarch.
13927
13928 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13929
13930 * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
13931 (alpha_unwind_pc): Delete.
13932 (alpha_gdbarch_init): Don't register deleted functions with
13933 gdbarch.
13934
13935 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13936
13937 * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
13938 (aarch64_unwind_pc): Delete.
13939 (aarch64_unwind_sp): Delete.
13940 (aarch64_gdbarch_init): Don't register deleted functions with
13941 gdbarch.
13942
13943 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13944
13945 * gdbtypes.c (type_align): Don't consider static members when
13946 computing structure alignment.
13947
13948 2019-02-27 Andrew Burgess <andrew.burgess@embecosm.com>
13949
13950 * arc-tdep.c (arc_type_align): Provide alignment for basic types,
13951 return 0 for other types.
13952 * arch-utils.c (default_type_align): Always return 0.
13953 * gdbarch.h: Regenerate.
13954 * gdbarch.sh (type_align): Extend comment.
13955 * gdbtypes.c (type_align): Add additional comments, always call
13956 gdbarch_type_align before applying the default rules.
13957 * i386-tdep.c (i386_type_align): Return 0 as the default rule,
13958 generic code will then apply a suitable default.
13959 * nios2-tdep.c (nios2_type_align): Provide alignment for basic
13960 types, return 0 for other types.
13961
13962 2019-02-27 Joel Brobecker <brobecker@adacore.com>
13963
13964 * NEWS: Create a new section for the next release branch.
13965 Rename the section of the current branch, now that it has
13966 been cut.
13967
13968 2019-02-27 Joel Brobecker <brobecker@adacore.com>
13969
13970 GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
13971 * version.in: Bump version to 8.3.50.DATE-git.
13972
13973 2019-02-26 Simon Marchi <simon.marchi@efficios.com>
13974
13975 * aix-thread.c (ptid_cmp): Remove unused variable.
13976 (get_signaled_thread): Likewise.
13977 (store_regs_user_thread): Likewise.
13978 (store_regs_kernel_thread): Likewise.
13979 (fetch_regs_kernel_thread): Remove shadowed variable.
13980
13981 2019-02-26 Andrew Burgess <andrew.burgess@embecosm.com>
13982
13983 * features/riscv/32bit-cpu.xml: Add register numbers.
13984 * features/riscv/32bit-fpu.c: Regenerate.
13985 * features/riscv/32bit-fpu.xml: Add register numbers.
13986 * features/riscv/64bit-cpu.xml: Add register numbers.
13987 * features/riscv/64bit-fpu.c: Regenerate.
13988 * features/riscv/64bit-fpu.xml: Add register numbers.
13989
13990 2019-02-26 Kevin Buettner <kevinb@redhat.com>
13991
13992 * NEWS: Mention two argument form of gdb.Value constructor.
13993 * python/py-value.c (convert_buffer_and_type_to_value): New
13994 function.
13995 (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
13996 Add support for handling an optional second argument. Call
13997 convert_buffer_and_type_to_value as appropriate.
13998 * python/python-internal.h (Py_buffer_deleter): New struct.
13999 (Py_buffer_up): New typedef.
14000
14001 2019-02-25 John Baldwin <jhb@FreeBSD.org>
14002
14003 * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14004 instead of releasing ownership.
14005
14006 2019-02-25 Jordan Rupprecht <rupprecht@google.com>
14007
14008 * dwarf2read.c (open_and_init_dwp_file): Call
14009 elf_numsections instead of bfd_count_sections to initialize
14010 dwp_file->num_sections.
14011
14012 2019-02-25 Tom Tromey <tromey@adacore.com>
14013
14014 * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14015
14016 2019-02-23 Sergio Durigan Junior <sergiodj@redhat.com>
14017
14018 * gcore.in: Add '--readnever' option when invoking GDB.
14019
14020 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14021
14022 * MAINTAINERS: Update my email address.
14023
14024 2019-02-22 Simon Marchi <simon.marchi@polymtl.ca>
14025
14026 * build-id.c (build_id_to_debug_bfd_1): New function.
14027 (build_id_to_debug_bfd): Look for separate debug file in
14028 sysroot.
14029
14030 2019-02-22 Andrew Burgess <andrew.burgess@embecosm.com>
14031
14032 * gdbarch.sh: Update the copyright year range that is placed into
14033 generated files.
14034
14035 2019-02-22 Keith Seitz <keiths@redhat.com>
14036
14037 PR symtab/23853
14038 * linespec.c (create_sals_line_offset): Search for the default
14039 symtab's filename instead of its fullname.
14040
14041 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14042
14043 * NEWS: Update style defaults.
14044
14045 2019-02-21 Alan Hayward <alan.hayward@arm.com>
14046
14047 * main.c (captured_main_1): Disable styling in batch mode.
14048
14049 2019-02-20 Tom Tromey <tom@tromey.com>
14050
14051 * symtab.c (symtab_symbol_info): Fix typos.
14052
14053 2019-02-20 Tom Tromey <tromey@adacore.com>
14054
14055 * findcmd.c (_initialize_mem_search): Use upper case for
14056 metasyntactic variables.
14057
14058 2019-02-20 Alan Hayward <alan.hayward@arm.com>
14059
14060 * aarch64-tdep.c (aarch64_add_reggroups): New function.
14061 (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14062
14063 2019-02-19 Simon Marchi <simon.marchi@polymtl.ca>
14064
14065 * top.h (source_file_name): Change to std::string.
14066 * top.c (source_file_name): Likewise.
14067 (command_line_input): Adjust.
14068 * cli/cli-script.c (script_from_file): Adjust.
14069
14070 2019-02-19 Tom Tromey <tromey@adacore.com>
14071
14072 * ravenscar-thread.c
14073 (ravenscar_thread_target::update_thread_list): Don't call
14074 ada_build_task_list.
14075 * ada-lang.h (ada_build_task_list): Don't declare.
14076 * ada-tasks.c (struct ada_tasks_inferior_data)
14077 <task_list_valid_p>: Now bool.
14078 (read_known_tasks, ada_task_list_changed)
14079 (ada_tasks_invalidate_inferior_data): Update.
14080 (read_known_tasks_array): Return bool.
14081 (read_known_tasks_list): Likewise.
14082 (read_known_tasks): Return void.
14083 (ada_build_task_list): Now static.
14084
14085 2019-02-18 Andrew Burgess <andrew.burgess@embecosm.com>
14086
14087 * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14088 and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14089
14090 2019-02-18 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14091
14092 * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14093 variant for ada_tasks_pspace_data_handle and
14094 ada_tasks_inferior_data_handle.
14095 (ada_tasks_pspace_data_cleanup): New function.
14096 (ada_tasks_inferior_data_cleanup): New function.
14097
14098 2019-02-17 Tom Tromey <tom@tromey.com>
14099
14100 * macrotab.h (macro_source_fullname): Return a std::string.
14101 * macrotab.c (macro_include, check_for_redefinition)
14102 (macro_undef, macro_lookup_definition, foreach_macro)
14103 (foreach_macro_in_scope): Update.
14104 (macro_source_fullname): Return a std::string.
14105 * macrocmd.c (show_pp_source_pos): Update.
14106
14107 2019-02-17 Tom Tromey <tom@tromey.com>
14108
14109 * macrocmd.c (show_pp_source_pos): Style the file names.
14110
14111 2019-02-17 Tom Tromey <tom@tromey.com>
14112
14113 PR tui/24197:
14114 * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14115
14116 2019-02-17 Tom Tromey <tom@tromey.com>
14117
14118 * ada-lang.c (user_select_syms): Use filtered printing.
14119 * utils.c (wrap_style): New global.
14120 (desired_style): Remove.
14121 (emit_style_escape): Add stream parameter.
14122 (set_output_style, reset_terminal_style, prompt_for_continue):
14123 Update.
14124 (flush_wrap_buffer): Only flush gdb_stdout.
14125 (wrap_here): Set wrap_style.
14126 (fputs_maybe_filtered): Clear the wrap buffer on exception. Don't
14127 treat escape sequences as a character. Change when wrap buffer is
14128 flushed.
14129 (fputs_styled): Do not set the output style when the default is
14130 requested.
14131 * ui-style.h (struct ui_file_style) <is_default>: New method.
14132 * source.c (print_source_lines_base): Emit escape sequences in one
14133 piece.
14134
14135 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14136
14137 * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14138 integers and enumeration types.
14139
14140 2019-02-17 Joel Brobecker <brobecker@adacore.com>
14141
14142 * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14143 instead of lookup_symbol_in_language
14144 (do_exact_match): New function.
14145 (ada_get_symbol_name_matcher): Return do_exact_match when
14146 doing a verbatim match.
14147
14148 2019-02-15 Tom Tromey <tromey@adacore.com>
14149
14150 * ravenscar-thread.c (ravenscar_thread_target::resume)
14151 (ravenscar_thread_target::wait): Special case wildcard requests.
14152
14153 2019-02-15 Tom Tromey <tromey@adacore.com>
14154
14155 * ravenscar-thread.c (base_ptid): Remove.
14156 (struct ravenscar_thread_target) <close>: New method.
14157 <m_base_ptid>: New member.
14158 <update_inferior_ptid, active_task, task_is_currently_active,
14159 runtime_initialized>: Declare methods.
14160 <ravenscar_thread_target>: Add constructor.
14161 (ravenscar_thread_target::task_is_currently_active)
14162 (ravenscar_thread_target::update_inferior_ptid)
14163 (ravenscar_runtime_initialized): Rename. Now methods.
14164 (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14165 (ravenscar_thread_target::update_thread_list): Update.
14166 (ravenscar_thread_target::active_task): Now method.
14167 (ravenscar_thread_target::store_registers)
14168 (ravenscar_thread_target::prepare_to_store)
14169 (ravenscar_thread_target::prepare_to_store)
14170 (ravenscar_thread_target::mourn_inferior): Update.
14171 (ravenscar_inferior_created): Use "new" to create target.
14172 (ravenscar_thread_target::get_ada_task_ptid): Update.
14173 (_initialize_ravenscar): Don't initialize base_ptid.
14174 (ravenscar_ops): Remove global.
14175
14176 2019-02-15 Tom Tromey <tromey@adacore.com>
14177
14178 * target.h (push_target): Declare new overload.
14179 * target.c (push_target): New overload, taking an rvalue reference.
14180 * remote.c (remote_target::open_1): Use push_target overload.
14181 * corelow.c (core_target_open): Use push_target overload.
14182
14183 2019-02-15 Tom Tromey <tromey@adacore.com>
14184
14185 * ravenscar-thread.c (is_ravenscar_task)
14186 (ravenscar_task_is_currently_active): Return bool.
14187 (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14188 (_initialize_ravenscar): Remove "(void)".
14189 (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14190 Return bool.
14191
14192 2019-02-15 Tom Tromey <tromey@adacore.com>
14193
14194 * ravenscar-thread.c (ravenscar_runtime_initializer)
14195 (has_ravenscar_runtime, get_running_thread_id)
14196 (ravenscar_thread_target::resume): Fix indentation.
14197
14198 2019-02-15 Tom Tromey <tromey@adacore.com>
14199
14200 * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14201 from ravenscar_arch_ops.
14202 (sparc_ravenscar_ops::fetch_registers)
14203 (sparc_ravenscar_ops::store_registers): Now methods.
14204 (sparc_ravenscar_prepare_to_store): Remove.
14205 (sparc_ravenscar_ops): Redefine.
14206 * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14207 methods and destructor. Remove members.
14208 * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14209 (ravenscar_thread_target::store_registers)
14210 (ravenscar_thread_target::prepare_to_store): Update.
14211 * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14212 Remove.
14213 (struct ppc_ravenscar_powerpc_ops): Derive from
14214 ravenscar_arch_ops.
14215 (ppc_ravenscar_powerpc_ops::fetch_registers)
14216 (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14217 (ppc_ravenscar_powerpc_ops): Redefine.
14218 (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14219 (ppc_ravenscar_e500_ops::fetch_registers)
14220 (ppc_ravenscar_e500_ops::store_registers): Now methods.
14221 (ppc_ravenscar_e500_ops): Redefine.
14222 * aarch64-ravenscar-thread.c
14223 (aarch64_ravenscar_generic_prepare_to_store): Remove.
14224 (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14225 (aarch64_ravenscar_fetch_registers)
14226 (aarch64_ravenscar_store_registers): Now methods.
14227 (aarch64_ravenscar_ops): Redefine.
14228
14229 2019-02-15 Tom Tromey <tromey@adacore.com>
14230
14231 * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14232 (ravenscar_thread_target::stopped_by_hw_breakpoint)
14233 (ravenscar_thread_target::stopped_by_watchpoint)
14234 (ravenscar_thread_target::stopped_data_address)
14235 (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14236
14237 2019-02-15 Tom Tromey <tromey@adacore.com>
14238
14239 * ravenscar-thread.c: Fix some typos.
14240
14241 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14242 Tom Tromey <tromey@adacore.com>
14243
14244 * ada-lang.c (ada_exception_sal): Change addr_string to a
14245 std::string.
14246 (create_ada_exception_catchpoint): Update.
14247
14248 2019-02-15 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14249 Tom Tromey <tromey@adacore.com>
14250
14251 * breakpoint.c (~bp_location): Rename from bp_location_dtor.
14252 (bp_location_ops): Remove.
14253 (base_breakpoint_allocate_location): Update.
14254 (free_bp_location): Update.
14255 * ada-lang.c (class ada_catchpoint_location)
14256 <ada_catchpoint_location>: Remove ops parameter.
14257 (ada_catchpoint_location_dtor): Remove.
14258 (ada_catchpoint_location_ops): Remove.
14259 (allocate_location_exception): Update.
14260 * breakpoint.h (struct bp_location_ops): Remove.
14261 (class bp_location) <bp_location>: Remove bp_location_ops
14262 parameter.
14263 <~bp_location>: Add destructor.
14264 <ops>: Remove.
14265
14266 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14267 Pedro Alves <palves@redhat.com>
14268
14269 * remote.c (remote_target::remote_parse_stop_reply): Avoid using
14270 'PATH_MAX'.
14271
14272 2019-02-14 David Michael <fedora.dm0@gmail.com>
14273 Samuel Thibault <samuel.thibault@gnu.org>
14274 Thomas Schwinge <thomas@codesourcery.com>
14275
14276 * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
14277 (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
14278
14279 2019-02-14 Thomas Schwinge <thomas@codesourcery.com>
14280
14281 * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
14282 (check_empty): Use "const char *".
14283
14284 * gnu-nat.c (gnu_nat_target::detach): Instead of
14285 'detach_inferior (pid)' call
14286 'detach_inferior (find_inferior_pid (pid))'.
14287
14288 * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
14289 'nat/fork-inferior.o'.
14290 * gnu-nat.c: #include "nat/fork-inferior.h".
14291
14292 * gnu-nat.c (gnu_nat_target::detach): Instead of
14293 'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
14294 * gnu-nat.h: #include "inf-child.h".
14295 * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
14296 'i386_gnu_nat_target::fetch_registers'.
14297 (gnu_store_registers): Rename/move to
14298 'i386_gnu_nat_target::store_registers'.
14299
14300 * config/i386/nm-i386gnu.h: Don't "#include" any files.
14301 * gnu-nat.h (mach_thread_info): New function.
14302 * gnu-nat.c (thread_takeover_sc_cmd): Use it.
14303
14304 * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
14305
14306 2019-02-14 Frederic Konrad <konrad@adacore.com>
14307
14308 * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
14309
14310 2019-02-14 Joel Brobecker <brobecker@adacore.com>
14311
14312 * windows-nat.c (windows_add_thread): Add new parameter
14313 "main_thread_p" with default value set to false. Update
14314 function documentation as well as all callers.
14315 (windows_delete_thread): Likewise.
14316 (fake_create_process): Update call to windows_add_thread.
14317 (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
14318 <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
14319 <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
14320 call to windows_delete_thread.
14321
14322 2019-02-13 Simon Marchi <simon.marchi@ericsson.com>
14323
14324 * MAINTAINERS: Add Andrew Burgess as global maintainer.
14325
14326 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14327
14328 * symfile.c (find_separate_debug_file): Use canonical path of
14329 sysroot with child_path instead of gdb_sysroot if it is valid.
14330
14331 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14332
14333 * symfile.c (find_separate_debug_file): Use child_path to
14334 determine if an object file is under a sysroot.
14335
14336 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14337
14338 * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
14339 unittests/child-path-selftests.c.
14340 * common/pathstuff.c (child_path): New function.
14341 * common/pathstuff.h (child_path): New prototype.
14342 * unittests/child-path-selftests.c: New file.
14343
14344 2019-02-12 John Baldwin <jhb@FreeBSD.org>
14345
14346 * symfile.c (find_separate_debug_file): Look for separate debug
14347 files in debug directories under the sysroot.
14348
14349 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14350
14351 * symtab.h (struct minimal_symbol data_p): New const method.
14352 (struct minimal_symbol text_p): Likewise.
14353 * symtab.c (output_source_filename): Use file name style
14354 to print file name.
14355 (print_symbol_info): Likewise.
14356 (print_msymbol_info): Use address style to print addresses.
14357 Use function name style to print executable text symbols.
14358 (expand_symtab_containing_pc): Use data_p.
14359 (find_pc_sect_compunit_symtab): Likewise.
14360
14361 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14362
14363 * breakpoint.c (describe_other_breakpoints): Use address style
14364 to print addresses.
14365 (say_where): Likewise.
14366
14367 2019-02-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14368
14369 * ada-typeprint.c (print_func_type): Print function name
14370 style to print function name.
14371 * c-typeprint.c (c_print_type_1): Likewise.
14372
14373 2019-02-11 Alan Hayward <alan.hayward@arm.com>
14374
14375 * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
14376 for execve.
14377
14378 2019-02-10 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14379
14380 * c-exp.y (direct_abs_decl): Use emplace_back to record the
14381 type_stack.
14382
14383 2019-02-10 Joel Brobecker <brobecker@adacore.com>
14384
14385 * ada-varobj.c (ada_value_is_changeable_p): Add handling of
14386 TYPE_CODE_REF types.
14387
14388 2019-02-08 Jim Wilson <jimw@sifive.com>
14389
14390 * riscv-linux-tdep.c (riscv_linux_fregmap): New.
14391 (riscv_linux_fregset): New.
14392 (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
14393
14394 2019-02-07 Tom Tromey <tom@tromey.com>
14395
14396 * thread.c (thread_cancel_execution_command): Update.
14397 * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
14398 methods.
14399 (struct thread_fsm_ops): Remove.
14400 (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
14401 (thread_fsm_should_stop, thread_fsm_return_value)
14402 (thread_fsm_set_finished, thread_fsm_finished_p)
14403 (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
14404 Don't declare.
14405 * mi/mi-interp.c (mi_on_normal_stop_1): Update.
14406 * infrun.c (clear_proceed_status_thread)
14407 (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
14408 (print_stop_event): Update.
14409 * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
14410 Add constructor.
14411 (step_command_fsm_ops): Remove.
14412 (new_step_command_fsm): Remove.
14413 (step_1): Update.
14414 (step_command_fsm::should_stop): Rename from
14415 step_command_fsm_should_stop.
14416 (step_command_fsm::clean_up): Rename from
14417 step_command_fsm_clean_up.
14418 (step_command_fsm::do_async_reply_reason): Rename from
14419 step_command_fsm_async_reply_reason.
14420 (struct until_next_fsm): Inherit from thread_fsm. Add
14421 constructor.
14422 (until_next_fsm_ops): Remove.
14423 (new_until_next_fsm): Remove.
14424 (until_next_fsm::should_stop): Rename from
14425 until_next_fsm_should_stop.
14426 (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
14427 (until_next_fsm::do_async_reply_reason): Rename from
14428 until_next_fsm_async_reply_reason.
14429 (struct finish_command_fsm): Inherit from thread_fsm. Add
14430 constructor. Change type of breakpoint.
14431 (finish_command_fsm_ops): Remove.
14432 (new_finish_command_fsm): Remove.
14433 (finish_command_fsm::should_stop): Rename from
14434 finish_command_fsm_should_stop.
14435 (finish_command_fsm::clean_up): Rename from
14436 finish_command_fsm_clean_up.
14437 (finish_command_fsm::return_value): Rename from
14438 finish_command_fsm_return_value.
14439 (finish_command_fsm::do_async_reply_reason): Rename from
14440 finish_command_fsm_async_reply_reason.
14441 (finish_command): Update.
14442 * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
14443 Add constructor.
14444 (call_thread_fsm_ops): Remove.
14445 (call_thread_fsm::call_thread_fsm): Rename from
14446 new_call_thread_fsm.
14447 (call_thread_fsm::should_stop): Rename from
14448 call_thread_fsm_should_stop.
14449 (call_thread_fsm::should_notify_stop): Rename from
14450 call_thread_fsm_should_notify_stop.
14451 (run_inferior_call, call_function_by_hand_dummy): Update.
14452 * cli/cli-interp.c (should_print_stop_to_console): Update.
14453 * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
14454 Add constructor. Change type of location_breakpoint,
14455 caller_breakpoint.
14456 (until_break_fsm_ops): Remove.
14457 (new_until_break_fsm): Remove.
14458 (until_break_fsm::should_stop): Rename from
14459 until_break_fsm_should_stop.
14460 (until_break_fsm::clean_up): Rename from
14461 until_break_fsm_clean_up.
14462 (until_break_fsm::do_async_reply_reason): Rename from
14463 until_break_fsm_async_reply_reason.
14464 (until_break_command): Update.
14465 * thread-fsm.c: Remove.
14466 * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
14467
14468 2019-02-07 Tom Tromey <tom@tromey.com>
14469
14470 * yy-remap.h: Add include guard.
14471 * xtensa-tdep.h: Add include guard.
14472 * xcoffread.h: Rename include guard.
14473 * varobj-iter.h: Add include guard.
14474 * tui/tui.h: Rename include guard.
14475 * tui/tui-winsource.h: Rename include guard.
14476 * tui/tui-wingeneral.h: Rename include guard.
14477 * tui/tui-windata.h: Rename include guard.
14478 * tui/tui-win.h: Rename include guard.
14479 * tui/tui-stack.h: Rename include guard.
14480 * tui/tui-source.h: Rename include guard.
14481 * tui/tui-regs.h: Rename include guard.
14482 * tui/tui-out.h: Rename include guard.
14483 * tui/tui-layout.h: Rename include guard.
14484 * tui/tui-io.h: Rename include guard.
14485 * tui/tui-hooks.h: Rename include guard.
14486 * tui/tui-file.h: Rename include guard.
14487 * tui/tui-disasm.h: Rename include guard.
14488 * tui/tui-data.h: Rename include guard.
14489 * tui/tui-command.h: Rename include guard.
14490 * tic6x-tdep.h: Add include guard.
14491 * target/waitstatus.h: Rename include guard.
14492 * target/wait.h: Rename include guard.
14493 * target/target.h: Rename include guard.
14494 * target/resume.h: Rename include guard.
14495 * target-float.h: Rename include guard.
14496 * stabsread.h: Add include guard.
14497 * rs6000-tdep.h: Add include guard.
14498 * riscv-fbsd-tdep.h: Add include guard.
14499 * regformats/regdef.h: Rename include guard.
14500 * record.h: Rename include guard.
14501 * python/python.h: Rename include guard.
14502 * python/python-internal.h: Rename include guard.
14503 * python/py-stopevent.h: Rename include guard.
14504 * python/py-ref.h: Rename include guard.
14505 * python/py-record.h: Rename include guard.
14506 * python/py-record-full.h: Rename include guard.
14507 * python/py-record-btrace.h: Rename include guard.
14508 * python/py-instruction.h: Rename include guard.
14509 * python/py-events.h: Rename include guard.
14510 * python/py-event.h: Rename include guard.
14511 * procfs.h: Add include guard.
14512 * proc-utils.h: Add include guard.
14513 * p-lang.h: Add include guard.
14514 * or1k-tdep.h: Rename include guard.
14515 * observable.h: Rename include guard.
14516 * nto-tdep.h: Rename include guard.
14517 * nat/x86-linux.h: Rename include guard.
14518 * nat/x86-linux-dregs.h: Rename include guard.
14519 * nat/x86-gcc-cpuid.h: Add include guard.
14520 * nat/x86-dregs.h: Rename include guard.
14521 * nat/x86-cpuid.h: Rename include guard.
14522 * nat/ppc-linux.h: Rename include guard.
14523 * nat/mips-linux-watch.h: Rename include guard.
14524 * nat/linux-waitpid.h: Rename include guard.
14525 * nat/linux-ptrace.h: Rename include guard.
14526 * nat/linux-procfs.h: Rename include guard.
14527 * nat/linux-osdata.h: Rename include guard.
14528 * nat/linux-nat.h: Rename include guard.
14529 * nat/linux-namespaces.h: Rename include guard.
14530 * nat/linux-btrace.h: Rename include guard.
14531 * nat/glibc_thread_db.h: Rename include guard.
14532 * nat/gdb_thread_db.h: Rename include guard.
14533 * nat/gdb_ptrace.h: Rename include guard.
14534 * nat/fork-inferior.h: Rename include guard.
14535 * nat/amd64-linux-siginfo.h: Rename include guard.
14536 * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
14537 * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
14538 * nat/aarch64-linux.h: Rename include guard.
14539 * nat/aarch64-linux-hw-point.h: Rename include guard.
14540 * mn10300-tdep.h: Add include guard.
14541 * mips-linux-tdep.h: Add include guard.
14542 * mi/mi-parse.h: Rename include guard.
14543 * mi/mi-out.h: Rename include guard.
14544 * mi/mi-main.h: Rename include guard.
14545 * mi/mi-interp.h: Rename include guard.
14546 * mi/mi-getopt.h: Rename include guard.
14547 * mi/mi-console.h: Rename include guard.
14548 * mi/mi-common.h: Rename include guard.
14549 * mi/mi-cmds.h: Rename include guard.
14550 * mi/mi-cmd-break.h: Rename include guard.
14551 * m2-lang.h: Add include guard.
14552 * location.h: Rename include guard.
14553 * linux-record.h: Rename include guard.
14554 * linux-nat.h: Add include guard.
14555 * linux-fork.h: Add include guard.
14556 * i386-darwin-tdep.h: Rename include guard.
14557 * hppa-linux-offsets.h: Add include guard.
14558 * guile/guile.h: Rename include guard.
14559 * guile/guile-internal.h: Rename include guard.
14560 * gnu-nat.h: Rename include guard.
14561 * gdb-stabs.h: Rename include guard.
14562 * frv-tdep.h: Add include guard.
14563 * f-lang.h: Add include guard.
14564 * event-loop.h: Add include guard.
14565 * darwin-nat.h: Rename include guard.
14566 * cp-abi.h: Rename include guard.
14567 * config/sparc/nm-sol2.h: Rename include guard.
14568 * config/nm-nto.h: Rename include guard.
14569 * config/nm-linux.h: Add include guard.
14570 * config/i386/nm-i386gnu.h: Rename include guard.
14571 * config/djgpp/nl_types.h: Rename include guard.
14572 * config/djgpp/langinfo.h: Rename include guard.
14573 * compile/gcc-cp-plugin.h: Add include guard.
14574 * compile/gcc-c-plugin.h: Add include guard.
14575 * compile/compile.h: Rename include guard.
14576 * compile/compile-object-run.h: Rename include guard.
14577 * compile/compile-object-load.h: Rename include guard.
14578 * compile/compile-internal.h: Rename include guard.
14579 * compile/compile-cplus.h: Rename include guard.
14580 * compile/compile-c.h: Rename include guard.
14581 * common/xml-utils.h: Rename include guard.
14582 * common/x86-xstate.h: Rename include guard.
14583 * common/version.h: Rename include guard.
14584 * common/vec.h: Rename include guard.
14585 * common/tdesc.h: Rename include guard.
14586 * common/selftest.h: Rename include guard.
14587 * common/scoped_restore.h: Rename include guard.
14588 * common/scoped_mmap.h: Rename include guard.
14589 * common/scoped_fd.h: Rename include guard.
14590 * common/safe-iterator.h: Rename include guard.
14591 * common/run-time-clock.h: Rename include guard.
14592 * common/refcounted-object.h: Rename include guard.
14593 * common/queue.h: Rename include guard.
14594 * common/ptid.h: Rename include guard.
14595 * common/print-utils.h: Rename include guard.
14596 * common/preprocessor.h: Rename include guard.
14597 * common/pathstuff.h: Rename include guard.
14598 * common/observable.h: Rename include guard.
14599 * common/netstuff.h: Rename include guard.
14600 * common/job-control.h: Rename include guard.
14601 * common/host-defs.h: Rename include guard.
14602 * common/gdb_wait.h: Rename include guard.
14603 * common/gdb_vecs.h: Rename include guard.
14604 * common/gdb_unlinker.h: Rename include guard.
14605 * common/gdb_unique_ptr.h: Rename include guard.
14606 * common/gdb_tilde_expand.h: Rename include guard.
14607 * common/gdb_sys_time.h: Rename include guard.
14608 * common/gdb_string_view.h: Rename include guard.
14609 * common/gdb_splay_tree.h: Rename include guard.
14610 * common/gdb_setjmp.h: Rename include guard.
14611 * common/gdb_ref_ptr.h: Rename include guard.
14612 * common/gdb_optional.h: Rename include guard.
14613 * common/gdb_locale.h: Rename include guard.
14614 * common/gdb_assert.h: Rename include guard.
14615 * common/filtered-iterator.h: Rename include guard.
14616 * common/filestuff.h: Rename include guard.
14617 * common/fileio.h: Rename include guard.
14618 * common/environ.h: Rename include guard.
14619 * common/common-utils.h: Rename include guard.
14620 * common/common-types.h: Rename include guard.
14621 * common/common-regcache.h: Rename include guard.
14622 * common/common-inferior.h: Rename include guard.
14623 * common/common-gdbthread.h: Rename include guard.
14624 * common/common-exceptions.h: Rename include guard.
14625 * common/common-defs.h: Rename include guard.
14626 * common/common-debug.h: Rename include guard.
14627 * common/cleanups.h: Rename include guard.
14628 * common/buffer.h: Rename include guard.
14629 * common/btrace-common.h: Rename include guard.
14630 * common/break-common.h: Rename include guard.
14631 * cli/cli-utils.h: Rename include guard.
14632 * cli/cli-style.h: Rename include guard.
14633 * cli/cli-setshow.h: Rename include guard.
14634 * cli/cli-script.h: Rename include guard.
14635 * cli/cli-interp.h: Rename include guard.
14636 * cli/cli-decode.h: Rename include guard.
14637 * cli/cli-cmds.h: Rename include guard.
14638 * charset-list.h: Add include guard.
14639 * buildsym-legacy.h: Rename include guard.
14640 * bfin-tdep.h: Add include guard.
14641 * ax.h: Rename include guard.
14642 * arm-linux-tdep.h: Add include guard.
14643 * arm-fbsd-tdep.h: Add include guard.
14644 * arch/xtensa.h: Rename include guard.
14645 * arch/tic6x.h: Add include guard.
14646 * arch/i386.h: Add include guard.
14647 * arch/arm.h: Rename include guard.
14648 * arch/arm-linux.h: Rename include guard.
14649 * arch/arm-get-next-pcs.h: Rename include guard.
14650 * arch/amd64.h: Add include guard.
14651 * arch/aarch64-insn.h: Rename include guard.
14652 * arch-utils.h: Rename include guard.
14653 * annotate.h: Add include guard.
14654 * amd64-darwin-tdep.h: Rename include guard.
14655 * aarch64-linux-tdep.h: Add include guard.
14656 * aarch64-fbsd-tdep.h: Add include guard.
14657 * aarch32-linux-nat.h: Add include guard.
14658
14659 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14660
14661 * macrotab.c (macro_define_internal): New function that
14662 factorizes macro_define_object_internal and macro_define_function
14663 code.
14664 (macro_define_object_internal): Use macro_define_internal.
14665 (macro_define_function): Likewise.
14666
14667 2019-02-06 Philippe Waroquiers <philippe.waroquiers@skynet.be>
14668
14669 * macrocmd.c (extract_identifier): Return
14670 a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
14671 callers.
14672
14673 2019-02-06 John Baldwin <jhb@FreeBSD.org>
14674
14675 * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
14676
14677 2019-02-05 Tom Tromey <tom@tromey.com>
14678
14679 * target.c (target_stack::unpush): Move assertion earlier.
14680
14681 2019-01-30 Tom Tromey <tom@tromey.com>
14682
14683 PR python/23615:
14684 * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
14685 (gdbpy_parse_and_eval): Likewise.
14686 * python/python-internal.h (gdbpy_allow_threads): New class.
14687
14688 2019-01-28 John Baldwin <jhb@FreeBSD.org>
14689
14690 * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
14691 (aarch64_fbsd_fpregmap): Move earlier.
14692 (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
14693 (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14694 instead of individual calls to trad_frame_set_reg_addr.
14695 * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
14696 earlier.
14697 (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
14698 (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
14699 instead of individual calls to trad_frame_set_reg_addr.
14700
14701 2019-01-28 Alan Hayward <alan.hayward@arm.com>
14702
14703 * CONTRIBUTE: Replace contribution list with wiki link.
14704
14705 2019-01-25 Tom Tromey <tom@tromey.com>
14706
14707 * Makefile.in (GDB_CFLAGS): Don't add -I for common.
14708
14709 2019-01-25 Tom Tromey <tom@tromey.com>
14710
14711 * xtensa-linux-nat.c: Fix common/ includes.
14712 * xml-support.h: Fix common/ includes.
14713 * xml-support.c: Fix common/ includes.
14714 * x86-linux-nat.c: Fix common/ includes.
14715 * windows-nat.c: Fix common/ includes.
14716 * varobj.h: Fix common/ includes.
14717 * varobj.c: Fix common/ includes.
14718 * value.c: Fix common/ includes.
14719 * valops.c: Fix common/ includes.
14720 * utils.c: Fix common/ includes.
14721 * unittests/xml-utils-selftests.c: Fix common/ includes.
14722 * unittests/utils-selftests.c: Fix common/ includes.
14723 * unittests/unpack-selftests.c: Fix common/ includes.
14724 * unittests/tracepoint-selftests.c: Fix common/ includes.
14725 * unittests/style-selftests.c: Fix common/ includes.
14726 * unittests/string_view-selftests.c: Fix common/ includes.
14727 * unittests/scoped_restore-selftests.c: Fix common/ includes.
14728 * unittests/scoped_mmap-selftests.c: Fix common/ includes.
14729 * unittests/scoped_fd-selftests.c: Fix common/ includes.
14730 * unittests/rsp-low-selftests.c: Fix common/ includes.
14731 * unittests/parse-connection-spec-selftests.c: Fix common/
14732 includes.
14733 * unittests/optional-selftests.c: Fix common/ includes.
14734 * unittests/offset-type-selftests.c: Fix common/ includes.
14735 * unittests/observable-selftests.c: Fix common/ includes.
14736 * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
14737 * unittests/memrange-selftests.c: Fix common/ includes.
14738 * unittests/memory-map-selftests.c: Fix common/ includes.
14739 * unittests/lookup_name_info-selftests.c: Fix common/ includes.
14740 * unittests/function-view-selftests.c: Fix common/ includes.
14741 * unittests/environ-selftests.c: Fix common/ includes.
14742 * unittests/copy_bitwise-selftests.c: Fix common/ includes.
14743 * unittests/common-utils-selftests.c: Fix common/ includes.
14744 * unittests/cli-utils-selftests.c: Fix common/ includes.
14745 * unittests/array-view-selftests.c: Fix common/ includes.
14746 * ui-file.c: Fix common/ includes.
14747 * tui/tui-io.c: Fix common/ includes.
14748 * tracepoint.h: Fix common/ includes.
14749 * tracepoint.c: Fix common/ includes.
14750 * tracefile-tfile.c: Fix common/ includes.
14751 * top.h: Fix common/ includes.
14752 * top.c: Fix common/ includes.
14753 * thread.c: Fix common/ includes.
14754 * target/waitstatus.h: Fix common/ includes.
14755 * target/waitstatus.c: Fix common/ includes.
14756 * target.h: Fix common/ includes.
14757 * target.c: Fix common/ includes.
14758 * target-memory.c: Fix common/ includes.
14759 * target-descriptions.c: Fix common/ includes.
14760 * symtab.h: Fix common/ includes.
14761 * symfile.c: Fix common/ includes.
14762 * stap-probe.c: Fix common/ includes.
14763 * spu-linux-nat.c: Fix common/ includes.
14764 * sparc-nat.c: Fix common/ includes.
14765 * source.c: Fix common/ includes.
14766 * solib.c: Fix common/ includes.
14767 * solib-target.c: Fix common/ includes.
14768 * ser-unix.c: Fix common/ includes.
14769 * ser-tcp.c: Fix common/ includes.
14770 * ser-pipe.c: Fix common/ includes.
14771 * ser-base.c: Fix common/ includes.
14772 * selftest-arch.c: Fix common/ includes.
14773 * s12z-tdep.c: Fix common/ includes.
14774 * rust-exp.y: Fix common/ includes.
14775 * rs6000-aix-tdep.c: Fix common/ includes.
14776 * riscv-tdep.c: Fix common/ includes.
14777 * remote.c: Fix common/ includes.
14778 * remote-notif.h: Fix common/ includes.
14779 * remote-fileio.h: Fix common/ includes.
14780 * remote-fileio.c: Fix common/ includes.
14781 * regcache.h: Fix common/ includes.
14782 * regcache.c: Fix common/ includes.
14783 * record-btrace.c: Fix common/ includes.
14784 * python/python.c: Fix common/ includes.
14785 * python/py-type.c: Fix common/ includes.
14786 * python/py-inferior.c: Fix common/ includes.
14787 * progspace.h: Fix common/ includes.
14788 * producer.c: Fix common/ includes.
14789 * procfs.c: Fix common/ includes.
14790 * proc-api.c: Fix common/ includes.
14791 * printcmd.c: Fix common/ includes.
14792 * ppc-linux-nat.c: Fix common/ includes.
14793 * parser-defs.h: Fix common/ includes.
14794 * osdata.c: Fix common/ includes.
14795 * obsd-nat.c: Fix common/ includes.
14796 * nat/x86-linux.c: Fix common/ includes.
14797 * nat/x86-linux-dregs.c: Fix common/ includes.
14798 * nat/x86-dregs.h: Fix common/ includes.
14799 * nat/x86-dregs.c: Fix common/ includes.
14800 * nat/ppc-linux.c: Fix common/ includes.
14801 * nat/mips-linux-watch.h: Fix common/ includes.
14802 * nat/mips-linux-watch.c: Fix common/ includes.
14803 * nat/linux-waitpid.c: Fix common/ includes.
14804 * nat/linux-ptrace.h: Fix common/ includes.
14805 * nat/linux-ptrace.c: Fix common/ includes.
14806 * nat/linux-procfs.c: Fix common/ includes.
14807 * nat/linux-personality.c: Fix common/ includes.
14808 * nat/linux-osdata.c: Fix common/ includes.
14809 * nat/linux-namespaces.c: Fix common/ includes.
14810 * nat/linux-btrace.h: Fix common/ includes.
14811 * nat/linux-btrace.c: Fix common/ includes.
14812 * nat/fork-inferior.c: Fix common/ includes.
14813 * nat/amd64-linux-siginfo.c: Fix common/ includes.
14814 * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
14815 * nat/aarch64-linux.c: Fix common/ includes.
14816 * nat/aarch64-linux-hw-point.h: Fix common/ includes.
14817 * nat/aarch64-linux-hw-point.c: Fix common/ includes.
14818 * namespace.h: Fix common/ includes.
14819 * mips-linux-tdep.c: Fix common/ includes.
14820 * minsyms.c: Fix common/ includes.
14821 * mi/mi-parse.h: Fix common/ includes.
14822 * mi/mi-main.c: Fix common/ includes.
14823 * mi/mi-cmd-env.c: Fix common/ includes.
14824 * memrange.h: Fix common/ includes.
14825 * memattr.c: Fix common/ includes.
14826 * maint.h: Fix common/ includes.
14827 * maint.c: Fix common/ includes.
14828 * main.c: Fix common/ includes.
14829 * machoread.c: Fix common/ includes.
14830 * location.c: Fix common/ includes.
14831 * linux-thread-db.c: Fix common/ includes.
14832 * linux-nat.c: Fix common/ includes.
14833 * linux-fork.c: Fix common/ includes.
14834 * inline-frame.c: Fix common/ includes.
14835 * infrun.c: Fix common/ includes.
14836 * inflow.c: Fix common/ includes.
14837 * inferior.h: Fix common/ includes.
14838 * inferior.c: Fix common/ includes.
14839 * infcmd.c: Fix common/ includes.
14840 * inf-ptrace.c: Fix common/ includes.
14841 * inf-child.c: Fix common/ includes.
14842 * ia64-linux-nat.c: Fix common/ includes.
14843 * i387-tdep.c: Fix common/ includes.
14844 * i386-tdep.c: Fix common/ includes.
14845 * i386-linux-tdep.c: Fix common/ includes.
14846 * i386-linux-nat.c: Fix common/ includes.
14847 * i386-go32-tdep.c: Fix common/ includes.
14848 * i386-fbsd-tdep.c: Fix common/ includes.
14849 * i386-fbsd-nat.c: Fix common/ includes.
14850 * guile/scm-type.c: Fix common/ includes.
14851 * guile/guile.c: Fix common/ includes.
14852 * go32-nat.c: Fix common/ includes.
14853 * gnu-nat.c: Fix common/ includes.
14854 * gdbthread.h: Fix common/ includes.
14855 * gdbarch-selftests.c: Fix common/ includes.
14856 * gdb_usleep.c: Fix common/ includes.
14857 * gdb_select.h: Fix common/ includes.
14858 * gdb_bfd.c: Fix common/ includes.
14859 * gcore.c: Fix common/ includes.
14860 * fork-child.c: Fix common/ includes.
14861 * findvar.c: Fix common/ includes.
14862 * fbsd-nat.c: Fix common/ includes.
14863 * event-top.c: Fix common/ includes.
14864 * event-loop.c: Fix common/ includes.
14865 * dwarf2read.c: Fix common/ includes.
14866 * dwarf2loc.c: Fix common/ includes.
14867 * dwarf2-frame.c: Fix common/ includes.
14868 * dwarf-index-cache.c: Fix common/ includes.
14869 * dtrace-probe.c: Fix common/ includes.
14870 * disasm-selftests.c: Fix common/ includes.
14871 * defs.h: Fix common/ includes.
14872 * csky-tdep.c: Fix common/ includes.
14873 * cp-valprint.c: Fix common/ includes.
14874 * cp-support.h: Fix common/ includes.
14875 * cp-support.c: Fix common/ includes.
14876 * corelow.c: Fix common/ includes.
14877 * completer.h: Fix common/ includes.
14878 * completer.c: Fix common/ includes.
14879 * compile/compile.c: Fix common/ includes.
14880 * compile/compile-loc2c.c: Fix common/ includes.
14881 * compile/compile-cplus-types.c: Fix common/ includes.
14882 * compile/compile-cplus-symbols.c: Fix common/ includes.
14883 * command.h: Fix common/ includes.
14884 * cli/cli-dump.c: Fix common/ includes.
14885 * cli/cli-cmds.c: Fix common/ includes.
14886 * charset.c: Fix common/ includes.
14887 * build-id.c: Fix common/ includes.
14888 * btrace.h: Fix common/ includes.
14889 * btrace.c: Fix common/ includes.
14890 * breakpoint.h: Fix common/ includes.
14891 * breakpoint.c: Fix common/ includes.
14892 * ax.h:
14893 (enum agent_op): Fix common/ includes.
14894 * ax-general.c (struct aop_map): Fix common/ includes.
14895 * ax-gdb.c: Fix common/ includes.
14896 * auxv.c: Fix common/ includes.
14897 * auto-load.c: Fix common/ includes.
14898 * arm-tdep.c: Fix common/ includes.
14899 * arch/riscv.c: Fix common/ includes.
14900 * arch/ppc-linux-common.c: Fix common/ includes.
14901 * arch/i386.c: Fix common/ includes.
14902 * arch/arm.c: Fix common/ includes.
14903 * arch/arm-linux.c: Fix common/ includes.
14904 * arch/arm-get-next-pcs.c: Fix common/ includes.
14905 * arch/amd64.c: Fix common/ includes.
14906 * arch/aarch64.c: Fix common/ includes.
14907 * arch/aarch64-insn.c: Fix common/ includes.
14908 * arch-utils.c: Fix common/ includes.
14909 * amd64-windows-tdep.c: Fix common/ includes.
14910 * amd64-tdep.c: Fix common/ includes.
14911 * amd64-sol2-tdep.c: Fix common/ includes.
14912 * amd64-obsd-tdep.c: Fix common/ includes.
14913 * amd64-nbsd-tdep.c: Fix common/ includes.
14914 * amd64-linux-tdep.c: Fix common/ includes.
14915 * amd64-linux-nat.c: Fix common/ includes.
14916 * amd64-fbsd-tdep.c: Fix common/ includes.
14917 * amd64-fbsd-nat.c: Fix common/ includes.
14918 * amd64-dicos-tdep.c: Fix common/ includes.
14919 * amd64-darwin-tdep.c: Fix common/ includes.
14920 * agent.c: Fix common/ includes.
14921 * ada-lang.h: Fix common/ includes.
14922 * ada-lang.c: Fix common/ includes.
14923 * aarch64-tdep.c: Fix common/ includes.
14924
14925 2019-01-25 Tom Tromey <tom@tromey.com>
14926
14927 * common/create-version.sh: Use common/version.h.
14928
14929 2019-01-24 Pedro Alves <palves@redhat.com>
14930
14931 * infrun.c (signal_stop, signal_print, signal_program)
14932 (signal_catch, signal_pass): Now arrays instead of pointers.
14933 (update_signals_program_target, do_target_resume)
14934 (signal_catch_update, handle_command, _initialize_infrun): Adjust.
14935 * linux-nat.c (linux_nat_target::pass_signals)
14936 (linux_nat_target::create_inferior, linux_nat_target::attach):
14937 Adjust.
14938 * linux-nat.h (linux_nat_target::pass_signals): Adjust.
14939 * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
14940 * procfs.c (procfs_target::pass_signals): Adjust.
14941 * record-full.c (record_full_target::resume): Adjust.
14942 * remote.c (remote_target::pass_signals)
14943 (remote_target::program_signals): Adjust.
14944 * target-debug.h (target_debug_print_signals): Now takes a
14945 gdb::array_view as parameter. Adjust.
14946 * target.h (target_ops) <pass_signals, program_signals>: Replace
14947 pointer and length parameters with gdb::array_view.
14948 (target_pass_signals, target_program_signals): Likewise.
14949 * target-delegates.c: Regenerate.
14950
14951 2019-01-24 Pedro Alves <palves@redhat.com>
14952
14953 * common/forward-scope-exit.h
14954 (forward_scope_exit::forward_scope_exit): Pass arguments to
14955 m_bind_function directly, instead of creating a std::bind and
14956 copying that.
14957
14958 2019-01-24 Alan Hayward <alan.hayward@arm.com>
14959
14960 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
14961 for static members.
14962 (pass_in_v_vfp_candidate): Likewise.
14963
14964 2019-01-23 Tom Tromey <tom@tromey.com>
14965 Pedro Alves <palves@redhat.com>
14966
14967 * regcache.c (class regcache_invalidator): Remove.
14968 (regcache::raw_write): Use make_scope_exit.
14969
14970 2019-01-23 Tom Tromey <tom@tromey.com>
14971
14972 * ui-out.h (class ui_out_emit_type): Update comment.
14973
14974 2019-01-23 Tom Tromey <tom@tromey.com>
14975
14976 * infrun.c (fetch_inferior_event): Update comment.
14977
14978 2019-01-23 Tom Tromey <tom@tromey.com>
14979 Pedro Alves <palves@redhat.com>
14980
14981 * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
14982 parameter.
14983 (fetch_inferior_event): Use SCOPE_EXIT.
14984
14985
14986 2019-01-23 Tom Tromey <tom@tromey.com>
14987 Pedro Alves <palves@redhat.com>
14988
14989 * infrun.c (disable_thread_events): Delete.
14990 (stop_all_threads): Use SCOPE_EXIT.
14991
14992 2019-01-23 Tom Tromey <tom@tromey.com>
14993 Pedro Alves <palves@redhat.com>
14994
14995 * symfile.c: Include forward-scope-exit.h.
14996 (clear_symtab_users_cleanup): Replace forward declaration with
14997 a FORWARD_SCOPE_EXIT.
14998 (syms_from_objfile_1): Use the forward_scope_exit and
14999 gdb::optional instead of cleanup_function.
15000 (reread_symbols): Use the forward_scope_exit instead of
15001 cleanup_function.
15002 (clear_symtab_users_cleanup): Remove function.
15003
15004 2019-01-23 Tom Tromey <tom@tromey.com>
15005 Pedro Alves <palves@redhat.com>
15006
15007 * linux-nat.c: Include scope-exit.h.
15008 (cleanup_target_stop): Remove.
15009 (linux_nat_target::static_tracepoint_markers_by_strid): Use
15010 SCOPE_EXIT.
15011
15012 2019-01-23 Tom Tromey <tom@tromey.com>
15013 Pedro Alves <palves@redhat.com>
15014
15015 * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15016 (call_function_by_hand_dummy): Use SCOPE_EXIT.
15017
15018 2019-01-23 Tom Tromey <tom@tromey.com>
15019 Andrew Burgess <andrew.burgess@embecosm.com>
15020 Pedro Alves <palves@redhat.com>
15021
15022 * infrun.c (fetch_inferior_event): Use scope_exit.
15023 * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15024 * top.c (execute_command): Use scope_exit.
15025 * breakpoint.c (bpstat_do_actions): Use scope_exit.
15026 * utils.c (do_bpstat_clear_actions_cleanup)
15027 (make_bpstat_clear_actions_cleanup): Remove.
15028
15029 2019-01-23 Tom Tromey <tom@tromey.com>
15030 Pedro Alves <palves@redhat.com>
15031
15032 * infrun.c: Include "common/scope-exit.h"
15033 (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15034 (wait_for_inferior): Use SCOPE_EXIT.
15035 (fetch_inferior_event): Use scope_exit.
15036
15037 2019-01-23 Tom Tromey <tom@tromey.com>
15038 Pedro Alves <palves@redhat.com>
15039
15040 * breakpoint.c (create_breakpoint): Remove cleanup.
15041
15042 2019-01-23 Tom Tromey <tom@tromey.com>
15043 Andrew Burgess <andrew.burgess@embecosm.com>
15044 Pedro Alves <palves@redhat.com>
15045
15046 2019-01-23 Pedro Alves <palves@redhat.com>
15047
15048 * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15049
15050 2019-01-23 Pedro Alves <palves@redhat.com>
15051 Andrew Burgess <andrew.burgess@embecosm.com>
15052
15053 * gdbthread.h: Include "common/forward-scope-exit.h".
15054 (scoped_finish_thread_state): Redefine custom class in terms of
15055 forward_scope_exit.
15056
15057 2019-01-23 Pedro Alves <palves@redhat.com>
15058 Andrew Burgess <andrew.burgess@embecosm.com>
15059
15060 * common/forward-scope-exit.h: New file.
15061
15062 2019-01-23 Pedro Alves <palves@redhat.com>
15063 Andrew Burgess <andrew.burgess@embecosm.com>
15064 Tom Tromey <tom@tromey.com>
15065
15066 * common/scope-exit.h: New file.
15067
15068 2019-01-23 Pedro Alves <palves@redhat.com>
15069
15070 * common/preprocessor.h (ESC): Rename to ...
15071 (ESC_PARENS): ... this.
15072 * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15073 (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15074
15075 2019-01-23 Tom Tromey <tom@tromey.com>
15076
15077 * language.h (class scoped_switch_to_sym_language_if_auto):
15078 Initialize m_lang in both cases.
15079
15080 2019-01-23 Alan Hayward <alan.hayward@arm.com>
15081
15082 * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15083 with XCNEW.
15084
15085 2019-01-22 Tom Tromey <tom@tromey.com>
15086
15087 * corelow.c: Do not include sys/file.h.
15088
15089 2019-01-22 Tom Tromey <tom@tromey.com>
15090
15091 * tui/tui-wingeneral.h: Include gdb_curses.h.
15092
15093 2019-01-22 Tom Tromey <tom@tromey.com>
15094
15095 * source-cache.h (class source_cache) <get_source_lines,
15096 get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15097
15098 2019-01-22 Tom Tromey <tom@tromey.com>
15099
15100 * remote-fileio.h (struct remote_target): Declare.
15101
15102 2019-01-22 Tom Tromey <tom@tromey.com>
15103
15104 * python/py-arch.c: Do not include py-ref.h.
15105 * python/py-bpevent.c: Do not include py-ref.h.
15106 * python/py-cmd.c: Do not include py-ref.h.
15107 * python/py-continueevent.c: Do not include py-ref.h.
15108 * python/py-event.h: Do not include py-ref.h.
15109 * python/py-evtregistry.c: Do not include py-ref.h.
15110 * python/py-finishbreakpoint.c: Do not include py-ref.h.
15111 * python/py-frame.c: Do not include py-ref.h.
15112 * python/py-framefilter.c: Do not include py-ref.h.
15113 * python/py-function.c: Do not include py-ref.h.
15114 * python/py-infevents.c: Do not include py-ref.h.
15115 * python/py-linetable.c: Do not include py-ref.h.
15116 * python/py-objfile.c: Do not include py-ref.h.
15117 * python/py-param.c: Do not include py-ref.h.
15118 * python/py-prettyprint.c: Do not include py-ref.h.
15119 * python/py-progspace.c: Do not include py-ref.h.
15120 * python/py-symbol.c: Do not include py-ref.h.
15121 * python/py-symtab.c: Do not include py-ref.h.
15122 * python/py-type.c: Do not include py-ref.h.
15123 * python/py-unwind.c: Do not include py-ref.h.
15124 * python/py-utils.c: Do not include py-ref.h.
15125 * python/py-value.c: Do not include py-ref.h.
15126 * python/py-varobj.c: Do not include py-ref.h.
15127 * python/py-xmethods.c: Do not include py-ref.h.
15128 * python/python.c: Do not include py-ref.h.
15129 * varobj.c: Do not include py-ref.h.
15130
15131 2019-01-22 Tom Tromey <tom@tromey.com>
15132
15133 * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15134 keyword for bcache.
15135
15136 2019-01-22 Tom Tromey <tom@tromey.com>
15137
15138 * compile/compile-cplus-types.c: Remove a comment by #include.
15139
15140 2019-01-22 Tom Tromey <tom@tromey.com>
15141
15142 * compile/gcc-c-plugin.h: Include compile-internal.h.
15143
15144 2019-01-22 Tom Tromey <tom@tromey.com>
15145
15146 * stabsread.c (EXTERN): Do not define.
15147 (symnum, next_symbol_text_func, processing_gcc_compilation)
15148 (within_function, global_sym_chain, global_stabs)
15149 (previous_stab_code, this_object_header_files)
15150 (n_this_object_header_files)
15151 (n_allocated_this_object_header_files): Define.
15152 * stabsread.h (EXTERN): Never define. Use "extern".
15153
15154 2019-01-22 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15155
15156 * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15157 history_value.
15158
15159 2019-01-21 Tom Tromey <tom@tromey.com>
15160
15161 * ui-out.c: Fix includes.
15162 * tui/tui-source.c: Fix includes.
15163 * target.c: Fix includes.
15164 * remote.c: Fix includes.
15165 * regcache.c: Fix includes.
15166 * python/py-block.c: Fix includes.
15167 * printcmd.c: Fix includes.
15168 * or1k-tdep.c: Fix includes.
15169 * mi/mi-main.c: Fix includes.
15170 * m32r-tdep.c: Fix includes.
15171 * csky-tdep.c: Fix includes.
15172 * compile/compile-cplus-types.c: Fix includes.
15173 * cli/cli-interp.c: Fix includes.
15174
15175 2019-01-21 Alan Hayward <alan.hayward@arm.com>
15176
15177 * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15178 for padding.
15179
15180 2019-01-16 Tom Tromey <tom@tromey.com>
15181
15182 * objfiles.h (struct minimal_symbol_iterator): Rename. Move
15183 earlier.
15184 (struct objfile) <msymbols_range>: Move from top level.
15185 <msymbols>: New method.
15186 (class objfile_msymbols): Remove.
15187 * symtab.c (default_collect_symbol_completion_matches_break_on):
15188 Update.
15189 * symmisc.c (dump_msymbols): Update.
15190 * stabsread.c (scan_file_globals): Update.
15191 * objc-lang.c (info_selectors_command, info_classes_command)
15192 (find_methods): Update.
15193 * minsyms.c (find_solib_trampoline_target): Update.
15194 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15195 * coffread.c (coff_symfile_read): Update.
15196 * ada-lang.c (ada_lookup_simple_minsym)
15197 (ada_collect_symbol_completion_matches): Update.
15198
15199 2019-01-16 Tom Tromey <tom@tromey.com>
15200
15201 * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15202 type. Remove no-argument constructor.
15203 <iterator::operator++>: Simplify.
15204 <begin>: Update.
15205 <end>: Use minimal_symbol_count.
15206
15207 2019-01-16 Tom Tromey <tom@tromey.com>
15208
15209 * objfiles.h (struct objfile) <psymtabs>: New method.
15210 (class objfile_psymtabs): Remove.
15211 * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15212 typedef.
15213 <range>: New method.
15214 (require_partial_symbols): Change return type.
15215 * psymtab.c (require_partial_symbols)
15216 (psym_expand_symtabs_matching): Update.
15217 * mdebugread.c (parse_partial_symbols): Update.
15218 * dbxread.c (dbx_end_psymtab): Update.
15219
15220 2019-01-15 Tom Tromey <tom@tromey.com>
15221
15222 * symtab.c (lookup_objfile_from_block)
15223 (lookup_symbol_in_objfile_symtabs)
15224 (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15225 (find_line_symtab, info_sources_command)
15226 (default_collect_symbol_completion_matches_break_on)
15227 (make_source_files_completion_list): Update.
15228 * symmisc.c (print_objfile_statistics, dump_objfile)
15229 (maintenance_print_symbols, maintenance_info_symtabs)
15230 (maintenance_check_symtabs, maintenance_info_line_tables):
15231 Update.
15232 * source.c (select_source_symtab)
15233 (forget_cached_source_info_for_objfile): Update.
15234 * objfiles.h (class objfile_compunits): Remove.
15235 (struct objfile) <compunits_range>: New typedef.
15236 (compunits): New method.
15237 * objfiles.c (objfile_relocate1): Update.
15238 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15239 * maint.c (count_symtabs_and_blocks): Update.
15240 * linespec.c (iterate_over_all_matching_symtabs): Update.
15241 * cp-support.c (add_symbol_overload_list_qualified): Update.
15242 * coffread.c (coff_symtab_read): Update.
15243 * ada-lang.c (add_nonlocal_symbols)
15244 (ada_collect_symbol_completion_matches)
15245 (ada_add_global_exceptions): Update.
15246
15247 2019-01-15 Tom Tromey <tom@tromey.com>
15248
15249 * progspace.h (program_space) <objfiles_safe_range>: New
15250 typedef.
15251 <objfiles_safe>: New method.
15252 * objfiles.h (class all_objfiles_safe): Remove.
15253 * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
15254 * jit.c (jit_inferior_exit_hook): Update.
15255
15256 2019-01-17 Tom Tromey <tom@tromey.com>
15257
15258 * progspace.h (program_space) <objfiles_range>: New typedef.
15259 <objfiles>: New method.
15260 <objfiles_head>: Rename from objfiles.
15261 (object_files): Update.
15262 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
15263 * guile/scm-pretty-print.c
15264 (ppscm_find_pretty_printer_from_objfiles): Update.
15265 * guile/scm-objfile.c (gdbscm_objfiles): Update.
15266 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
15267 Update.
15268 * python/py-progspace.c (pspy_get_objfiles): Update.
15269 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15270 Update.
15271 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15272 (objfpy_lookup_objfile_by_build_id): Update.
15273 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15274 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15275 Update.
15276 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15277 (expand_symtab_containing_pc, lookup_objfile_from_block)
15278 (lookup_static_symbol, basic_lookup_transparent_type)
15279 (find_pc_sect_compunit_symtab, find_symbol_at_address)
15280 (find_line_symtab, info_sources_command)
15281 (default_collect_symbol_completion_matches_break_on)
15282 (make_source_files_completion_list, find_main_name): Update.
15283 * symmisc.c (print_symbol_bcache_statistics)
15284 (print_objfile_statistics, maintenance_print_symbols)
15285 (maintenance_print_msymbols, maintenance_print_objfiles)
15286 (maintenance_info_symtabs, maintenance_check_symtabs)
15287 (maintenance_expand_symtabs, maintenance_info_line_tables):
15288 Update.
15289 * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
15290 (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
15291 (map_overlay_command, unmap_overlay_command)
15292 (simple_overlay_update, expand_symtabs_matching)
15293 (map_symbol_filenames): Update.
15294 * symfile-debug.c (set_debug_symfile): Update.
15295 * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
15296 Update.
15297 * source.c (select_source_symtab, forget_cached_source_info):
15298 Update.
15299 * solib.c (solib_read_symbols): Update.
15300 * solib-spu.c (append_ocl_sos): Update.
15301 * psymtab.c (maintenance_print_psymbols)
15302 (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
15303 * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
15304 * printcmd.c (info_symbol_command): Update.
15305 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
15306 Update.
15307 * objfiles.h (class all_objfiles): Remove.
15308 * objfiles.c (have_partial_symbols, have_full_symbols)
15309 (have_minimal_symbols, qsort_cmp, update_section_map)
15310 (shared_objfile_contains_address_p)
15311 (default_iterate_over_objfiles_in_search_order): Update.
15312 * objc-lang.c (info_selectors_command, info_classes_command)
15313 (find_methods): Update.
15314 * minsyms.c (find_solib_trampoline_target): Update.
15315 * maint.c (maintenance_info_sections)
15316 (maintenance_translate_address, count_symtabs_and_blocks):
15317 Update.
15318 * main.c (captured_main_1): Update.
15319 * linux-thread-db.c (try_thread_db_load_from_pdir)
15320 (has_libpthread): Update.
15321 * linespec.c (iterate_over_all_matching_symtabs)
15322 (search_minsyms_for_name): Update.
15323 * jit.c (jit_find_objf_with_entry_addr): Update.
15324 * hppa-tdep.c (find_unwind_entry)
15325 (hppa_lookup_stub_minimal_symbol): Update.
15326 * gcore.c (gcore_create_callback, objfile_find_memory_regions):
15327 Update.
15328 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15329 (elf_gnu_ifunc_resolve_by_got): Update.
15330 * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
15331 * dwarf-index-write.c (save_gdb_index_command): Update.
15332 * cp-support.c (add_symbol_overload_list_qualified): Update.
15333 * breakpoint.c (create_overlay_event_breakpoint)
15334 (create_longjmp_master_breakpoint)
15335 (create_std_terminate_master_breakpoint)
15336 (create_exception_master_breakpoint): Update.
15337 * blockframe.c (find_pc_partial_function): Update.
15338 * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
15339 (ada_collect_symbol_completion_matches)
15340 (ada_add_global_exceptions): Update.
15341
15342 2019-01-17 Tom Tromey <tom@tromey.com>
15343
15344 * solib-target.c (lm_info_target_p): Remove typedef. Don't
15345 declare VEC.
15346 (solib_target_parse_libraries): Change return type.
15347 (library_list_start_segment, library_list_start_section)
15348 (library_list_end_library, library_list_start_library); Update.
15349 (solib_target_free_library_list): Remove.
15350 (solib_target_parse_libraries): Remove cleanup. Change return
15351 type.
15352 (solib_target_current_sos): Update.
15353
15354 2019-01-17 Tom Tromey <tromey@bapiya>
15355
15356 * valprint.c: Replace "the the" with "the".
15357 * symtab.c: Replace "the the" with "the".
15358 * solib.c: Replace "the the" with "the".
15359 * solib-dsbt.c: Replace "the the" with "the".
15360 * linespec.c: Replace "the the" with "the".
15361 * dwarf2loc.h: Replace "the the" with "the".
15362 * amd64-windows-tdep.c: Replace "the the" with "the".
15363 * aarch64-tdep.c: Replace "the the" with "the".
15364
15365 2019-01-16 Keith Seitz <keiths@redhat.com>
15366
15367 PR gdb/23773
15368 * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
15369 <builder>: Rename to ..
15370 <m_builder>: ... this and make private.
15371 (dwarf2_cu::get_builder): New method. Change all users of
15372 `builder' to use this method.
15373 (dwarf2_start_symtab): Move to ...
15374 (dwarf2_cu::start_symtab): ... here. Update all callers
15375 (setup_type_unit_groups): Move to ...
15376 (dwarf2_cu::setup_type_unit_groups): ... here. Update all
15377 callers.
15378 (dwarf2_cu::reset_builder): New method.
15379 (process_full_compunit, process_full_type_unit): Use
15380 dwarf2_cu::reset_builder.
15381 (follow_die_offset): Record the ancestor CU if it is different
15382 from the followed DIE's CU.
15383 (follow_die_sig_1): Likewise.
15384
15385 2019-01-15 Tom Tromey <tom@tromey.com>
15386
15387 * remote.c (class remote_state) <buf>: Now a char_vector.
15388 <buf_size>: Remove.
15389 (remote_target::getpkt): Change type of buf. Remove sizeof_buf
15390 parameter.
15391 (remote_target::getpkt_or_notif_sane_1)
15392 (remote_target::getpkt_sane)
15393 (remote_target::getpkt_or_notif_sane): Likewise.
15394 (class remote_target) <putpkt>: New overload.
15395 (remote_target::read_frame): Change type of "buf_p". Remove
15396 sizeof_p parameter.
15397 (packet_ok): New overload.
15398 (packet_check_result): New overload.
15399 Update all uses.
15400
15401 2019-01-14 Tom Tromey <tom@tromey.com>
15402
15403 * remote-notif.c (handle_notification, remote_notif_ack)
15404 (remote_notif_parse): Make "buf" const.
15405 * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
15406 const.
15407 (remote_notif_parse, remote_notif_ack, handle_notification):
15408 Likewise.
15409 * remote.c (remote_notif_stop_parse): Make "buf" const.
15410 (remote_target::remote_parse_stop_reply): Make "buf" const.
15411 (remote_notif_stop_ack): Make "buf" const.
15412
15413 2019-01-14 Tom Tromey <tom@tromey.com>
15414
15415 * remote.c (remote_console_output): Make parameter const.
15416
15417 2019-01-14 Tom Tromey <tom@tromey.com>
15418
15419 * target-debug.h (target_debug_print_signals): Constify.
15420 * nto-procfs.c (nto_procfs_target::pass_signals): Update.
15421 * procfs.c (procfs_target::pass_signals): Update.
15422 * linux-nat.c (linux_nat_target::pass_signals): Update.
15423 * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
15424 * target-delegates.c: Rebuild.
15425 * remote.c (remote_target::program_signals): Update.
15426 (remote_target::pass_signals): Update.
15427 * target.c (target_pass_signals): Constify argument.
15428 (target_program_signals): Likewise.
15429 * target.h (struct target_ops) <pass_signals, program_signals>:
15430 Constify argument.
15431 (target_pass_signals, target_program_signals): Constify argument.
15432
15433 2019-01-14 Tom Tromey <tom@tromey.com>
15434
15435 PR tui/28819:
15436 * tui/tui-io.c (gdb_wgetch): Print \r when needed.
15437
15438 2019-01-14 Pedro Franco de Carvalho <pedromfc@linux.ibm.com>
15439
15440 * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
15441 field.
15442 * rs6000-tdep.c: Include reggroups.h.
15443 (IS_V_ALIAS_PSEUDOREG): Define.
15444 (rs6000_register_name): Return names for the "vX" aliases.
15445 (rs6000_pseudo_register_type): Return type for the "vX" aliases.
15446 (rs6000_pseudo_register_reggroup_p): Restore. Handle "vX"
15447 aliases. Call default_register_reggroup_p for all other
15448 pseudo-registers.
15449 (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
15450 New functions.
15451 (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
15452 Handle "vX" aliases.
15453 (v_alias_pseudo_register_collect): New function.
15454 (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
15455 (rs6000_gdbarch_init): Initialize "vX" aliases as
15456 pseudo-registers. Restore registration of
15457 rs6000_pseudo_register_reggroup_p with
15458 set_tdesc_pseudo_register_reggroup_p.
15459
15460 2019-01-13 Max Filippov <jcmvbkbc@gmail.com>
15461
15462 * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
15463 tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
15464 set_gdbarch_num_pseudo_regs.
15465
15466 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15467
15468 * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
15469 Remove arg prefixname, add do_set and do_show.
15470 Add member functions set_list and show_list.
15471 * cli/cli-style.c (class cli_style_option): Update accordingly.
15472 (style_set_list): Move to file scope.
15473 (style_show_list): Likewise.
15474 (set_style): Call help_list.
15475 (show_style): Call cmd_show_list.
15476 (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
15477 Update to use the new macro.
15478
15479 2019-10-12 Joel Brobecker <brobecker@adacore.com>
15480
15481 * ada-lang.c (_initialize_ada_language): Expand the help text
15482 for the "catch exception" command.
15483
15484 2019-01-12 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15485
15486 * symtab.c (matching_obj_sections): Initialize obj,
15487 declare it closer to its usage.
15488
15489 2019-01-10 Tom Tromey <tom@tromey.com>
15490
15491 * thread-iter.h (inf_threads_iterator): Use next_iterator.
15492 (basic_inf_threads_range): Remove.
15493 (inf_threads_range, inf_non_exited_threads_range)
15494 (safe_inf_threads_range): Use next_adapter.
15495
15496 2019-01-10 Keith Seitz <keiths@redhat.com>
15497
15498 PR gdb/23712
15499 PR symtab/23010
15500 * dwarf2read.c (dw2_add_symbol_to_list): Remove.
15501 (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
15502
15503 2019-01-10 Keith Seitz <keiths@redhat.com>
15504
15505 PR gdb/23712
15506 PR symtab/23010
15507 * dictionary.c (pending_to_vector): Remove.
15508 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15509 Remove _1 suffix, replacing functions of the same name. Update
15510 all callers.
15511 (dict_create_hashed, dict_create_hashed_expandable)
15512 (dict_create_linear, dict_create_linear_expandable, dict_free)
15513 (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
15514 Make functions static.
15515
15516 2019-01-10 Keith Seitz <keiths@redhat.com>
15517
15518 PR gdb/23712
15519 PR symtab/23010
15520 * dictionary.h (struct dictionary): Replace declaration with
15521 multidictionary.
15522 (dict_create_hashed, dict_create_hashed_expandable)
15523 (dict_create_linear, dict_create_linear_expandable)
15524 (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
15525 (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
15526 (dict_iter_match_next, dict_size): Rename to "mdict_" versions
15527 taking multidictionary argument.
15528 [ALL_DICT_SYMBOLS]: Update for multidictionary.
15529 * block.h (struct block) <dict>: Change to multidictionary
15530 and rename `multidict'.
15531 * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
15532 symmisc.c: Update all dictionary references to multidictionary.
15533
15534 2019-01-10 Keith Seitz <keiths@redhat.com>
15535
15536 PR gdb/23712
15537 PR symtab/23010
15538 * dictionary.c: Include unordered_map.
15539 (pending_to_vector): New function.
15540 (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
15541 Rewrite the non-"_1" functions to take vector instead
15542 of linked list.
15543 (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
15544 "new" _1 versions of the same name.
15545 (multidictionary): Define.
15546 (std::hash<enum language): New definition.
15547 (collate_pending_symbols_by_language, mdict_create_hashed)
15548 (mdict_create_hashed_expandable, mdict_create_linear)
15549 (mdict_create_linear_expandable, mdict_free)
15550 (find_language_dictionary, create_new_language_dictionary)
15551 (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
15552 (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
15553 (mdict_size, mdict_empty): New functions.
15554 * dictionary.h (mdict_iterator): Define.
15555
15556 2019-01-10 Pedro Alves <palves@redhat.com>
15557
15558 * breakpoint.c (read_uploaded_action)
15559 (create_tracepoint_from_upload): Adjust to use
15560 gdb::unique_xmalloc_ptr.
15561 * ctf.c (ctf_write_uploaded_tp):
15562 (SET_ARRAY_FIELD): Use emplace_back.
15563 (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
15564 * tracefile-tfile.c (tfile_write_uploaded_tp):
15565 * tracepoint.c (parse_tracepoint_definition): Adjust to use
15566 gdb::unique_xmalloc_ptr.
15567 * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
15568 at_string, cond_string, cmd_strings>: Replace char pointers
15569 with gdb::unique_xmalloc_ptr.
15570
15571 2019-01-10 Pedro Alves <palves@redhat.com>
15572
15573 * solib-target.c (library_list_start_library): Don't xstrdup name.
15574
15575 2019-01-10 Pedro Alves <palves@redhat.com>
15576
15577 * mdebugread.c (parse_partial_symbols): Use
15578 gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
15579
15580 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15581
15582 * linux-fork.c (scoped_switch_fork_info)
15583 <~scoped_switch_fork_info>: Fix incorrect variable name.
15584
15585 2019-01-10 Andrew Burgess <andrew.burgess@embecosm.com>
15586
15587 * linux-fork.c (scoped_switch_fork_info)
15588 <scoped_switch_fork_info>: Make explicit.
15589 <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
15590
15591 2019-01-10 Tom Tromey <tom@tromey.com>
15592
15593 * objfiles.h (objfile::reset_psymtabs): Update.
15594 * objfiles.c (objfile::objfile): Update.
15595 * psymtab.h (psymtab_storage::obstack): Update.
15596 (psymtab_storage::m_obstack): Use gdb::optional.
15597 (class psymtab_storage): Update comment. Remove objfile
15598 parameter.
15599 * psymtab.c (psymtab_storage::psymtab_storage): Update.
15600
15601 2019-01-10 Tom Tromey <tom@tromey.com>
15602
15603 * psymtab.h (psymtab_storage::allocate_psymtab): New method.
15604 <free_psymtabs>: Now private.
15605 * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
15606 (allocate_psymtab): Use new method.
15607
15608 2019-01-10 Tom Tromey <tom@tromey.com>
15609
15610 * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
15611 * psymtab.h (psymtab_storage::allocate_dependencies): New method.
15612 * mdebugread.c (parse_partial_symbols): Use
15613 allocate_dependencies.
15614 * dwarf2read.c (dwarf2_create_include_psymtab): Use
15615 allocate_dependencies.
15616 (process_psymtab_comp_unit_reader)
15617 (build_type_psymtab_dependencies): Likewise.
15618 * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
15619
15620 2019-01-10 Tom Tromey <tom@tromey.com>
15621
15622 * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
15623 PSYMBOL_SET_LANGUAGE.
15624 (allocate_psymtab): Allocate psymtab on the psymtab obstack.
15625
15626 2019-01-10 Tom Tromey <tom@tromey.com>
15627
15628 * psymtab.h (psymtab_storage::obstack): New method.
15629 <m_obstack>: Rename from obstack; now private.
15630 * psymtab.c (psymtab_storage): Update.
15631 * dwarf2read.c (create_addrmap_from_index)
15632 (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
15633 Update.
15634
15635 2019-01-10 Tom Tromey <tom@tromey.com>
15636
15637 * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
15638 * objfiles.h (objfile::reset_psymtabs): New method.
15639
15640 2019-01-10 Tom Tromey <tom@tromey.com>
15641
15642 * symmisc.c (print_symbol_bcache_statistics): Update.
15643 (print_objfile_statistics): Update.
15644 * symfile.c (reread_symbols): Update.
15645 * psymtab.h (class psymtab_storage): New.
15646 * psymtab.c (psymtab_storage): New constructor.
15647 (~psymtab_storage): New destructor.
15648 (require_partial_symbols): Update.
15649 (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
15650 (find_pc_sect_psymtab, find_pc_sect_psymbol)
15651 (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
15652 (psym_dump, recursively_search_psymtabs, psym_has_symbols)
15653 (psym_find_compunit_symtab_by_address, sort_pst_symbols)
15654 (start_psymtab_common, end_psymtab_common)
15655 (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
15656 (allocate_psymtab): Update.
15657 (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
15658 Update.
15659 (dump_psymtab_addrmap, maintenance_print_psymbols)
15660 (maintenance_check_psymtabs): Update.
15661 (class objfile_psymtabs): Move to objfiles.h.
15662 * psympriv.h (discard_psymtab): Now inline.
15663 (psymtab_discarder::psymtab_discarder): Update.
15664 (psymtab_discarder::~psymtab_discarder): Update.
15665 (ALL_OBJFILE_PSYMTABS): Rewrite.
15666 * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
15667 free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
15668 Remove fields.
15669 <partial_symtabs>: New field.
15670 (class objfile_psymtabs): Move from psymtab.h. Update.
15671 * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
15672 psymbol_cache.
15673 (objfile::~objfile): Don't destroy psymbol_cache.
15674 * mdebugread.c (parse_partial_symbols): Update.
15675 * dwarf2read.c (create_addrmap_from_index)
15676 (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
15677 (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
15678 (add_partial_subprogram, dwarf2_ranges_read): Update.
15679 * dwarf-index-write.c (write_address_map)
15680 (write_one_signatured_type, recursively_write_psymbols)
15681 (class debug_names, class debug_names, write_psymtabs_to_index):
15682 Update.
15683
15684 2019-01-10 Tom Tromey <tom@tromey.com>
15685
15686 * symtab.h (SYMBOL_SET_NAMES): Update.
15687 (symbol_set_names): Update.
15688 (MSYMBOL_SET_NAMES): Update.
15689 * symtab.c (symbol_set_names): Change argument to be an
15690 objfile_per_bfd_storage.
15691 * psymtab.c (add_psymbol_to_bcache): Update.
15692 * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
15693
15694 2019-01-10 Tom Tromey <tom@tromey.com>
15695
15696 * symtab.c (create_demangled_names_hash): Change argument to be an
15697 objfile_per_bfd_storage.
15698 (symbol_set_names): Update.
15699
15700 2019-01-10 Tom Tromey <tom@tromey.com>
15701
15702 * xcoffread.c (xcoff_initial_scan): Unconditionally call
15703 init_psymbol_list.
15704 * psymtab.c (init_psymbol_list): Do nothing if already called.
15705 * psympriv.h (init_psymbol_list): Add comment.
15706 * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
15707 init_psymbol_list.
15708 * dbxread.c (dbx_symfile_read): Unconditionally call
15709 init_psymbol_list.
15710
15711 2019-01-10 Tom Tromey <tom@tromey.com>
15712
15713 * xcoffread.c (scan_xcoff_symtab): Update.
15714 * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
15715 "where".
15716 * mdebugread.c (parse_partial_symbols)
15717 (handle_psymbol_enumerators): Update.
15718 * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
15719 * dbxread.c (read_dbx_symtab): Update.
15720 * psympriv.h (psymbol_placement): New enum.
15721 (add_psymbol_to_list): Update.
15722
15723 2019-01-10 Tom Tromey <tom@tromey.com>
15724
15725 * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
15726 static_psymbols parameters.
15727 (scan_xcoff_symtab): Update.
15728 * psymtab.c (start_psymtab_common): Remove global_psymbols and
15729 static_psymbols parameters.
15730 * psympriv.h (start_psymtab_common): Update.
15731 * mdebugread.c (parse_partial_symbols): Update.
15732 * dwarf2read.c (create_partial_symtab): Update.
15733 * dbxread.c (read_dbx_symtab): Update.
15734 (start_psymtab): Remove global_psymbols and static_psymbols
15735 parameters.
15736
15737 2019-01-10 Tom Tromey <tom@tromey.com>
15738
15739 * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
15740 * psymtab.c (allocate_psymtab): Add comment.
15741 * psympriv.h (allocate_psymtab): Add comment.
15742 * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
15743 initializations.
15744 * dbxread.c (dbx_end_psymtab): Remove some initializations.
15745
15746 2019-01-10 Tom Tromey <tom@tromey.com>
15747
15748 * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15749 Don't declare.
15750 * mipsread.c: Include mdebugread.h.
15751 * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
15752 Declare.
15753 * elfread.c: Include mdebugread.h.
15754
15755 2019-01-09 Tom Tromey <tom@tromey.com>
15756
15757 * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
15758 * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
15759 * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
15760 (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
15761 (psym_lookup_symbol, psym_find_last_source_symtab)
15762 (psym_forget_cached_source_info, psym_print_stats)
15763 (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
15764 (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
15765 (psym_map_matching_symbols, psym_expand_symtabs_matching)
15766 (psym_find_compunit_symtab_by_address)
15767 (maintenance_print_psymbols, maintenance_info_psymtabs)
15768 (maintenance_check_psymtabs): Use ranged for.
15769 * psymtab.h (class objfile_psymtabs): New.
15770 (require_partial_symbols): Return objfile_psymtabs.
15771 * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
15772
15773 2019-01-09 Tom Tromey <tom@tromey.com>
15774
15775 * symfile.c (overlay_invalidate_all, find_pc_overlay)
15776 (find_pc_mapped_section, list_overlays_command)
15777 (map_overlay_command, unmap_overlay_command)
15778 (simple_overlay_update): Use all_objfiles.
15779 * spu-tdep.c (spu_overlay_update): Use all_objfiles.
15780 * printcmd.c (info_symbol_command): Use all_objfiles.
15781 * objfiles.h (ALL_OBJSECTIONS): Remove.
15782 * maint.c (maintenance_translate_address): Use all_objfiles.
15783 * gcore.c (gcore_create_callback): Use all_objfiles.
15784 (objfile_find_memory_regions): Likewise.
15785
15786 2019-01-09 Tom Tromey <tom@tromey.com>
15787
15788 * symtab.c (find_line_symtab, info_sources_command)
15789 (make_source_files_completion_list): Use objfile_compunits.
15790 * source.c (select_source_symtab): Use objfile_compunits.
15791 * objfiles.h (struct objfile): Update comment.
15792 (ALL_OBJFILES): Remove.
15793 (ALL_FILETABS): Remove.
15794 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
15795 objfile_compunits.
15796
15797 2019-01-09 Tom Tromey <tom@tromey.com>
15798
15799 * symmisc.c (print_objfile_statistics, dump_objfile)
15800 (maintenance_print_symbols): Use compunit_filetabs.
15801 * source.c (forget_cached_source_info_for_objfile): Use
15802 compunit_filetabs.
15803 * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
15804 (ALL_FILETABS): Use compunit_filetabs.
15805 * objfiles.c (objfile_relocate1): Use compunit_filetabs.
15806 * coffread.c (coff_symtab_read): Use compunit_filetabs.
15807
15808 2019-01-09 Tom Tromey <tom@tromey.com>
15809
15810 * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
15811 (compunit_filetabs): New.
15812 * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
15813 compunit_filetabs.
15814 (info_sources_command, make_source_files_completion_list): Remove
15815 declaration.
15816 * symmisc.c (print_objfile_statistics, dump_objfile)
15817 (maintenance_print_symbols): Remove declaration.
15818 (maintenance_info_symtabs): Use compunit_filetabs.
15819 (maintenance_info_line_tables): Likewise.
15820 * source.c (select_source_symtab): Change local variable name.
15821 (forget_cached_source_info_for_objfile): Remove declaration.
15822 * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
15823 * objfiles.c (objfile_relocate1): Remove declaration.
15824 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15825 declaration.
15826 * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
15827 * coffread.c (coff_symtab_read): Remove declaration.
15828 * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
15829 compunit_filetabs.
15830
15831 2019-01-09 Tom Tromey <tom@tromey.com>
15832
15833 * symtab.c (lookup_objfile_from_block)
15834 (find_pc_sect_compunit_symtab, search_symbols)
15835 (default_collect_symbol_completion_matches_break_on): Use
15836 objfile_compunits.
15837 * objfiles.h (ALL_COMPUNITS): Remove.
15838 * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
15839 * cp-support.c (add_symbol_overload_list_qualified): Use
15840 objfile_compunits.
15841 * ada-lang.c (ada_collect_symbol_completion_matches)
15842 (ada_add_global_exceptions): Use objfile_compunits.
15843
15844 2019-01-09 Tom Tromey <tom@tromey.com>
15845
15846 * source.c (select_source_symtab)
15847 (forget_cached_source_info_for_objfile): Remove declaration.
15848 * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
15849 declaration.
15850 * maint.c (count_symtabs_and_blocks): Remove declaration.
15851 * cp-support.c (add_symbol_overload_list_qualified): Remove
15852 declaration.
15853 * coffread.c (coff_symtab_read): Remove declaration.
15854 * symtab.c (lookup_symbol_in_objfile_symtabs)
15855 (basic_lookup_transparent_type_1): Use objfile_compunits.
15856 (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
15857 (info_sources_command, search_symbols)
15858 (default_collect_symbol_completion_matches_break_on)
15859 (make_source_files_completion_list): Remove declaration.
15860 * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
15861 (ada_collect_symbol_completion_matches)
15862 (ada_add_global_exceptions): Remove declaration.
15863 * linespec.c (iterate_over_all_matching_symtabs): Use
15864 objfile_compunits.
15865 * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
15866 (class objfile_compunits): New.
15867 (ALL_COMPUNITS): Use objfile_compunits.
15868 * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
15869 (maintenance_check_symtabs, maintenance_info_line_tables): Use
15870 objfile_compunits.
15871 * objfiles.c (objfile_relocate1): Use objfile_compunits.
15872
15873 2019-01-09 Tom Tromey <tom@tromey.com>
15874
15875 * symtab.c (search_symbols)
15876 (default_collect_symbol_completion_matches_break_on): Use
15877 objfile_msymbols.
15878 * ada-lang.c (ada_lookup_simple_minsym)
15879 (ada_collect_symbol_completion_matches): Use objfile_msymbols.
15880 * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
15881 * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
15882 objfile_msymbols.
15883 * coffread.c (coff_symfile_read): Use objfile_msymbols.
15884 * symmisc.c (dump_msymbols): Use objfile_msymbols.
15885 * objc-lang.c (find_methods): Use objfile_msymbols.
15886 (info_selectors_command, info_classes_command): Likewise.
15887 * stabsread.c (scan_file_globals): Use objfile_msymbols.
15888 * objfiles.h (class objfile_msymbols): New.
15889 (ALL_OBJFILE_MSYMBOLS): Remove.
15890 (ALL_MSYMBOLS): Remove.
15891
15892 2019-01-09 Tom Tromey <tom@tromey.com>
15893
15894 * common/next-iterator.h (next_adapter): Add Iterator template
15895 parameter.
15896 * objfiles.h (ALL_OBJFILES_SAFE): Remove.
15897 (class all_objfiles_safe): New.
15898 * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
15899 * objfiles.c (put_objfile_before): Update comment.
15900 (add_separate_debug_objfile): Likewise.
15901 (free_all_objfiles): Use all_objfiles_safe.
15902 (objfile_purge_solibs): Likewise.
15903
15904 2019-01-09 Tom Tromey <tom@tromey.com>
15905
15906 * symtab.c (iterate_over_symtabs, matching_obj_sections)
15907 (expand_symtab_containing_pc, lookup_static_symbol)
15908 (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
15909 (find_symbol_at_address, find_line_symtab, find_main_name): Use
15910 all_objfiles.
15911 * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
15912 * breakpoint.c (create_overlay_event_breakpoint)
15913 (create_longjmp_master_breakpoint)
15914 (create_std_terminate_master_breakpoint)
15915 (create_exception_master_breakpoint): Use all_objfiles.
15916 * linux-thread-db.c (try_thread_db_load_from_pdir)
15917 (has_libpthread): Use all_objfiles.
15918 * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
15919 * linespec.c (iterate_over_all_matching_symtabs)
15920 (search_minsyms_for_name): Use all_objfiles.
15921 * maint.c (maintenance_info_sections): Use all_objfiles.
15922 * main.c (captured_main_1): Use all_objfiles.
15923 * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
15924 * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
15925 * guile/scm-pretty-print.c
15926 (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
15927 * solib-spu.c (append_ocl_sos): Use all_objfiles.
15928 * symmisc.c (maintenance_print_symbols): Use all_objfiles.
15929 (maintenance_print_msymbols): Use all_objfiles.
15930 * source.c (select_source_symtab): Use all_objfiles.
15931 * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
15932 * symfile.c (remove_symbol_file_command)
15933 (expand_symtabs_matching, map_symbol_filenames): Use
15934 all_objfiles.
15935 * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
15936 all_objfiles.
15937 * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
15938 * objc-lang.c (find_methods): Use all_objfiles.
15939 * objfiles.c (have_partial_symbols, have_full_symbols)
15940 (have_minimal_symbols, qsort_cmp)
15941 (default_iterate_over_objfiles_in_search_order): Use
15942 all_objfiles.
15943 * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
15944 * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
15945 (maintenance_check_psymtabs): Use all_objfiles.
15946 (ALL_PSYMTABS): Remove.
15947 * compile/compile-object-run.c (do_module_cleanup): Use
15948 all_objfiles.
15949 * blockframe.c (find_pc_partial_function): Use all_objfiles.
15950 * cp-support.c (add_symbol_overload_list_qualified): Use
15951 all_objfiles.
15952 * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
15953 Use all_objfiles.
15954 * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
15955 * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
15956 all_objfiles.
15957 * python/py-objfile.c (objfpy_lookup_objfile_by_name)
15958 (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
15959 * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
15960 Uses all_objfiles.
15961 * solib.c (solib_read_symbols): Use all_objfiles
15962
15963 2019-01-09 Tom Tromey <tom@tromey.com>
15964
15965 * probe.c (parse_probes_in_pspace): Use all_objfiles.
15966 * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
15967 all_objfiles.
15968 * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
15969 * symmisc.c (print_symbol_bcache_statistics)
15970 (print_objfile_statistics, maintenance_print_objfiles)
15971 (maintenance_info_symtabs, maintenance_check_symtabs)
15972 (maintenance_expand_symtabs, maintenance_info_line_tables): Use
15973 all_objfiles.
15974 * source.c (forget_cached_source_info): Use all_objfiles.
15975 * symfile-debug.c (set_debug_symfile): Use all_objfiles.
15976 * elfread.c (elf_gnu_ifunc_resolve_by_cache)
15977 (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
15978 * objfiles.c (update_section_map): Use all_objfiles.
15979 (shared_objfile_contains_address_p): Likewise.
15980 * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
15981 * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
15982
15983 2019-01-09 Tom Tromey <tom@tromey.com>
15984
15985 * common/next-iterator.h: New file.
15986 * objfiles.h (class all_objfiles): New.
15987 (struct objfile_iterator): New.
15988
15989 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
15990
15991 * NEWS: Move the description of the changed "frame", "select-frame",
15992 and "info frame" commands to the Changed commands section.
15993
15994 2019-01-09 Simon Marchi <simon.marchi@ericsson.com>
15995
15996 * gdbtypes.c (check_stub_method_group): Remove handling of old
15997 mangling schemes.
15998 * linespec.c (find_methods): Likewise.
15999 * stabsread.c (read_member_functions): Likewise.
16000 * valops.c (search_struct_method): Likewise.
16001 (value_struct_elt_for_reference): Likewise.
16002 * NEWS: Mention this change.
16003
16004 2019-01-09 Andrew Burgess <andrew.burgess@embecosm.com>
16005
16006 * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16007 print_source_lines.
16008 * source.c (print_source_lines_base): Update line number check.
16009 (print_source_lines): New function.
16010 (source_lines_range::source_lines_range): New function.
16011 * source.h (class source_lines_range): New class.
16012 (print_source_lines): New declaration.
16013
16014 2019-01-09 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16015
16016 * linespec.c (linespec_state_destructor): Free self->canonical_names.
16017
16018 2019-01-08 Tom Tromey <tom@tromey.com>
16019 Simon Marchi <simon.marchi@ericsson.com>
16020
16021 PR gdb/24060
16022 * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16023 * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16024 * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16025 * f-exp.y (DOLLAR_VARIABLE): Likewise.
16026 * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16027 * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16028
16029 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16030
16031 * source.c (select_source_symtab): Move header comment to
16032 declaration in source.h.
16033 (forget_cached_source_info_for_objfile): Likewise.
16034 (forget_cached_source_info): Likewise.
16035 (identify_source_line): Likewise.
16036 * source.h (identify_source_line): Move declaration from symtab.h
16037 and add comment from source.c
16038 (print_source_lines): Likewise.
16039 (forget_cached_source_info_for_objfile): Likewise.
16040 (forget_cached_source_info): Likewise.
16041 (select_source_symtab): Likewise.
16042 (enum print_source_lines_flag): Move definition from symtab.h.
16043 * symtab.h (identify_source_line): Move declaration to source.h.
16044 (print_source_lines): Likewise.
16045 (forget_cached_source_info_for_objfile): Likewise.
16046 (forget_cached_source_info): Likewise.
16047 (select_source_symtab): Likewise.
16048 (enum print_source_lines_flag): Move definition to source.h.
16049 * tui/tui-hooks.c: Add 'source.h' include.
16050
16051 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16052
16053 * source.c (print_source_lines_base): Handle requests to print
16054 reverse line number sequences, and guard against empty lines
16055 string.
16056
16057 2019-01-08 Andrew Burgess <andrew.burgess@embecosm.com>
16058
16059 * source.c (print_source_lines_base): Fix skip of '\r' if next
16060 character is '\n'.
16061
16062 2019-01-06 Tom Tromey <tom@tromey.com>
16063
16064 * c-exp.y (struct c_parse_state) <macro_original_text,
16065 expansion_obstack>: New member.
16066 (macro_original_text, expansion_obstack): Remove globals.
16067 (scan_macro_expansion, scanning_macro_expansion)
16068 (finished_macro_expansion): Update.
16069 (scan_macro_cleanup): Remove.
16070 (yylex, c_parse): Update.
16071
16072 2019-01-06 Tom Tromey <tom@tromey.com>
16073
16074 * c-exp.y (struct c_parse_state) <strings>: New member.
16075 (operator_stoken): Update.
16076
16077 2019-01-06 Tom Tromey <tom@tromey.com>
16078
16079 * parser-defs.h (type_ptr): Remove typedef. Don't declare VEC.
16080 (union type_stack_elt) <typelist_val>: Now a pointer to
16081 std::vector.
16082 (type_stack_cleanup): Don't declare.
16083 (push_typelist): Update.
16084 * parse.c (pop_typelist): Return a std::vector.
16085 (push_typelist): Take a std::vector.
16086 (follow_types): Update. Do not free args.
16087 (type_stack_cleanup): Remove.
16088 * c-exp.y (struct c_parse_state): New.
16089 (cpstate): New global.
16090 (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16091 (nonempty_typelist): Update.
16092 (func_mod): Create a new vector.
16093 (c_parse): Create a c_parse_state.
16094 (check_parameter_typelist): Do not delete params.
16095 (function_method): Update. Do not delete type_list.
16096
16097 2019-01-06 Tom Tromey <tom@tromey.com>
16098
16099 PR gdb/28155:
16100 * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16101 check_typedef.
16102 * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16103 (print_return_value): Likewise.
16104
16105 2019-01-05 Tom Tromey <tom@tromey.com>
16106
16107 * contrib/cleanup_check.py: Remove.
16108 * contrib/gcc-with-excheck: Remove.
16109 * contrib/exsummary.py: Remove.
16110 * contrib/excheck.py: Remove.
16111
16112 2019-01-05 Joel Brobecker <brobecker@adacore.com>
16113
16114 * thread.c (delete_thread_1): Add gdb_assert that THR is not
16115 NULL. Initialize tpprev to NULL instead of assigning it
16116 to NULL on the next statement.
16117 * windows-nat.c (windows_delete_thread): Remove check for
16118 main_thread_id before printing thread exit notifications.
16119 (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16120 Remove thread ID check against main_thread_id.
16121 <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16122 windows_delete_thread.
16123 <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16124
16125 2019-01-04 Tom Tromey <tom@tromey.com>
16126
16127 * compile/compile.c (_initialize_compile): Use upper case for
16128 metasyntactic variables.
16129 * symmisc.c (_initialize_symmisc): Use upper case for
16130 metasyntactic variables.
16131 * psymtab.c (_initialize_psymtab): Use upper case for
16132 metasyntactic variables.
16133 * demangle.c (demangle_command): Use upper case for metasyntactic
16134 variables.
16135 (_initialize_demangler): Likewise.
16136 * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16137 variables.
16138
16139 2019-01-03 Tom Tromey <tom@tromey.com>
16140
16141 * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16142
16143 2019-01-03 Tom Tromey <tom@tromey.com>
16144
16145 * python/py-symtab.c (salpy_str): Update.
16146 (struct salpy_sal_object) <symtab>: Now a PyObject.
16147 (salpy_dealloc): Update.
16148 (del_objfile_sal): Use gdbpy_ref.
16149
16150 2019-01-03 Tom Tromey <tom@tromey.com>
16151
16152 * python/py-type.c (convert_field): Use new_reference. Return
16153 gdbpy_ref.
16154 (make_fielditem): Return gdbpy_ref.
16155 (typy_fields): Update.
16156 (typy_getitem): Update.
16157 (field_name): Return gdbpy_ref. Use new_reference.
16158 (typy_iterator_iternext): Update.
16159
16160 2019-01-03 Tom Tromey <tom@tromey.com>
16161
16162 * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16163
16164 2019-01-03 Tom Tromey <tom@tromey.com>
16165
16166 * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16167 * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16168 * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16169 (pspy_set_frame_filters, pspy_set_frame_unwinders)
16170 (pspy_set_type_printers): Likewise.
16171 * python/py-function.c (fnpy_init): Use gdbpy_ref.
16172 * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16173 * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16174 (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16175 (objfpy_set_type_printers): Likewise.
16176
16177 2019-01-03 Tom Tromey <tom@tromey.com>
16178
16179 * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16180 (gdbpy_print_stack): Use gdbpy_err_fetch.
16181 * python/python-internal.h (class gdbpy_err_fetch): New class.
16182 (class gdbpy_enter) <m_error_type, m_error_value,
16183 m_error_traceback>: Remove.
16184 <m_error>: New member.
16185 (gdbpy_exception_to_string): Don't declare.
16186 * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16187 * python/py-value.c (convert_value_from_python): Use
16188 gdbpy_err_fetch.
16189 * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16190 gdbpy_exception_to_string.
16191 (gdbpy_handle_exception): Use gdbpy_err_fetch.
16192 * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16193 gdbpy_err_fetch.
16194
16195 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16196
16197 * linux-nat.c (delete_lwp_cleanup): Delete.
16198 (struct lwp_deleter): New struct.
16199 (lwp_info_up): New typedef.
16200 (linux_nat_target::follow_fork): Delete cleanup, and make use of
16201 lwp_info_up.
16202
16203 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16204
16205 * linux-fork.c (class scoped_switch_fork_info): New class.
16206 (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16207
16208 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16209
16210 * valops.c (find_overload_match): Remove use of null_cleanup, and
16211 calls to do_cleanups.
16212
16213 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16214
16215 * compile/compile-cplus-types.c
16216 (compile_cplus_instance::decl_name): Handle changes to
16217 cp_func_name.
16218 * cp-support.c (cp_func_name): Update header comment, update
16219 return type.
16220 * cp-support.h (cp_func_name): Update return type in declaration.
16221 * valops.c (find_overload_match): Move temp_func local to top
16222 level of function and change its type. Use temp_func to hold and
16223 delete temporary string obtained from cp_func_name.
16224
16225 2019-01-03 Andrew Burgess <andrew.burgess@embecosm.com>
16226
16227 * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16228 gdb::char_vector, remove cleanup, and update uses of `msg`.
16229
16230 2019-01-03 Jim Wilson <jimw@sifive.com>
16231
16232 * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16233
16234 2019-01-02 Tom Tromey <tom@tromey.com>
16235
16236 * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16237 (tdesc_parse_xml): Remove cleanups.
16238 * target-descriptions.h (make_cleanup_free_target_description):
16239 Don't declare.
16240 (target_desc_deleter): New struct.
16241 (target_desc_up): New typedef.
16242 * target-descriptions.c (target_desc_deleter::operator()): Rename
16243 from free_target_description.
16244 (make_cleanup_free_target_description): Remove.
16245
16246 2019-01-02 Tom Tromey <tom@tromey.com>
16247
16248 * linespec.c (struct linespec_parser): Rename from ls_parser. Add
16249 constructor, destructor.
16250 (linespec_parser): Remove typedef.
16251 (~linespec_parser): Rename from linespec_parser_delete.
16252 (linespec_lex_to_end, linespec_complete_label)
16253 (linespec_complete): Update.
16254 (decode_line_full): Remove cleanups.
16255 (decode_line_1): Update.
16256
16257 2019-01-02 Tom Tromey <tom@tromey.com>
16258
16259 * python/python-internal.h (inferior_to_inferior_object): Change
16260 return type.
16261 * python/py-exitedevent.c (create_exited_event_object): Update.
16262 * python/py-inferior.c (inferior_to_inferior_object): Return
16263 gdbpy_ref.
16264 (python_new_inferior, python_inferior_deleted)
16265 (thread_to_thread_object, delete_thread_object)
16266 (build_inferior_list, gdbpy_selected_inferior): Update.
16267 * python/py-infthread.c (create_thread_object): Update. Also fail
16268 if inferior_to_inferior_object fails.
16269
16270 2019-01-02 Simon Marchi <simon.marchi@ericsson.com>
16271
16272 * inferior.h (class inferior) <displaced_step_state>: New field.
16273 * infrun.h (struct displaced_step_state): Move here from
16274 infrun.c. Initialize fields, add constructor.
16275 <inf>: Remove field.
16276 <reset>: New method.
16277 * infrun.c (struct displaced_step_inferior_state): Move to
16278 infrun.h.
16279 (displaced_step_inferior_states): Remove.
16280 (get_displaced_stepping_state): Adust.
16281 (displaced_step_in_progress_any_inferior): Adjust.
16282 (displaced_step_in_progress_thread): Adjust.
16283 (displaced_step_in_progress): Adjust.
16284 (add_displaced_stepping_state): Remove.
16285 (get_displaced_step_closure_by_addr): Adjust.
16286 (remove_displaced_stepping_state): Remove.
16287 (infrun_inferior_exit): Call displaced_step_state.reset.
16288 (use_displaced_stepping): Don't check for NULL.
16289 (displaced_step_prepare_throw): Call
16290 get_displaced_stepping_state.
16291 (displaced_step_fixup): Don't check for NULL.
16292 (prepare_for_detach): Don't check for NULL.
16293
16294 2019-01-02 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16295
16296 * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
16297 in case of call that did not complete.
16298
16299 2019-01-02 Andrey Utkin <autkin@undo.io>
16300
16301 * symfile.c (find_separate_debug_file): Fix search of debug files for
16302 remote debuggee.
16303
16304 2019-01-02 Tom Tromey <tom@tromey.com>
16305
16306 * python/py-inferior.c (gdbpy_initialize_inferior): Fix
16307 indentation.
16308 * python/py-frame.c (frapy_older): Remove cast.
16309 (frapy_newer): Likewise.
16310 * python/py-breakpoint.c (local_setattro): Remove cast.
16311 * python/py-arch.c (archpy_name): Remove local variable.
16312 * python/py-type.c (gdbpy_lookup_type): Remove cast.
16313
16314 2019-01-02 Joel Brobecker <brobecker@adacore.com>
16315
16316 * unittests/basic_string_view/element_access/char/empty.cc:
16317 Fix year range in copyright header.
16318
16319 2019-01-01 Andrew Burgess <andrew.burgess@embecosm.com>
16320
16321 * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
16322 Delete.
16323 <operator==>: Update with for removed field.
16324 <hash>: Likewise.
16325 * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
16326 <isa_features>: ...this.
16327 <abi_features>: New field.
16328 (riscv_isa_flen): Update comment.
16329 (riscv_abi_xlen): New declaration.
16330 (riscv_abi_flen): New declaration.
16331 * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
16332 isa_features.
16333 (riscv_abi_xlen): New function.
16334 (riscv_isa_flen): Update to get answer from isa_features.
16335 (riscv_abi_flen): New function.
16336 (riscv_has_fp_abi): Update to get answer from abi_features.
16337 (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
16338 xlen and flen.
16339 (riscv_call_info) <xlen, flen>: Update comment.
16340 (riscv_call_arg_struct): Remove invalid assertions
16341 (riscv_features_from_gdbarch_info): Update now hw_float_abi field
16342 is removed.
16343 (riscv_gdbarch_init): Gather isa features and abi features
16344 separately, ensure both match on the gdbarch when reusing an old
16345 gdbarch. Relax an error check to allow 32-bit abi float to run on
16346 a target with 64-bit float hardware.
16347
16348 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16349
16350 * source.c (search_command_helper): Stop reverse search
16351 when line 1 has been searched.
16352
16353 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16354
16355 * record-full.c (record_full_base_target::close): Rewrite
16356 record_full_core_buf_list free logic.
16357
16358 2019-01-01 Philippe Waroquiers <philippe.waroquiers@skynet.be>
16359
16360 * break-catch-syscall.c (print_one_catch_syscall): xfree
16361 the last text.
16362
16363 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16364
16365 * top.c (print_gdb_version): Update Copyright year in version
16366 message.
16367
16368 2019-01-01 Joel Brobecker <brobecker@adacore.com>
16369
16370 Update copyright year range in all GDB files.
16371
16372 2019-01-01, 19 Joel Brobecker <brobecker@adacore.com>
16373
16374 * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
16375
16376 For older changes see ChangeLog-2018.
16377 \f
16378 Local Variables:
16379 mode: change-log
16380 left-margin: 8
16381 fill-column: 74
16382 version-control: never
16383 coding: utf-8
16384 End:
16385
This page took 0.365556 seconds and 3 git commands to generate.