gdb/ChangeLog

   1 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
   2
   3         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
   4         type to htab_up.
   5         * dwarf2read.c (struct dwo_file): Initialize fields.
   6         <~dwo_file>: New.
   7         (free_dwo_file): Remove, move content to ~dwo_file.
   8         (struct dwo_file_deleter): Remove.
   9         (dwo_file_up>: Remove custom deleter.
  10         (free_dwo_files): Remove.
  11         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
  12         dwo_files.
  13         (process_skeletonless_type_units): Call unique_ptr::get.
  14         (allocate_dwo_file_hash_table): Add deleter to created hash
  15         table.  Change return type to htab_up.
  16         (lookup_dwo_file_slot): Don't memset dwo_file, call
  17         unique_ptr::get.
  18         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
  19         (create_dwo_unit_in_dwp_v2): Likewise.
  20         (open_and_init_dwo_file): Likewise.
  21         (free_dwo_file_from_slot): Remove.
  22
  23 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
  24
  25         * dwarf2read.h (struct dwarf2_section_info) <readin,
  26         is_virtual>: Change type to bool.
  27         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
  28         true instead of 1.
  29
  30 2019-06-19  Tom Tromey  <tom@tromey.com>
  31
  32         * tui/tui-data.h (tui_init_content_element): Don't declare.
  33
  34 2019-06-19  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-data.h (tui_init_win_info): Don't declare.
  37
  38 2019-06-19  Tom de Vries  <tdevries@suse.de>
  39
  40         * dwarf2read.h (abstract_to_concrete): Change type to
  41         std::unordered_map<sect_offset, std::vector<sect_offset>,
  42         gdb::hash_enum<sect_offset>>.
  43
  44 2019-06-19  Tom Tromey  <tromey@adacore.com>
  45
  46         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
  47         EVAL_AVOID_SIDE_EFFECTS specially.
  48
  49 2019-06-19  Tom Tromey  <tromey@adacore.com>
  50
  51         * source-cache.c (highlighter): New global.
  52         (source_cache::get_source_lines): Create a highlighter on demand.
  53
  54 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
  55
  56         * defs.h (deprecated_interactive_hook): Delete declaration.
  57         * interps.c (clear_interpreter_hooks): Remove use of
  58         deprecated_interactive_hook.
  59         * top.c (deprecated_interactive_hook): Delete definition.
  60         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
  61
  62 2019-06-18  Tom de Vries  <tdevries@suse.de>
  63
  64         PR gdb/24515
  65         * dwarf2read.h (abstract_to_concrete): Change type from
  66         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
  67         std::unordered_map<sect_offset, std::vector<sect_offset>>.
  68         * dwarf2read.c (read_variable): Update.
  69         (dwarf2_fetch_die_loc_sect_off): Update.
  70
  71 2019-06-17  Tom de Vries  <tdevries@suse.de>
  72
  73         PR gdb/24617
  74         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
  75         accessing parent[parent_len - 1].
  76
  77 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
  78
  79         PR gdb/24364
  80         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
  81         call dtrace_process_dof with NULL dof.
  82
  83 2019-06-16  Tom de Vries  <tdevries@suse.de>
  84
  85         PR gdb/24445
  86         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
  87
  88 2019-06-16  Tom Tromey  <tom@tromey.com>
  89
  90         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
  91         (make_all_visible): Use address of member.
  92
  93 2019-06-16  Tom Tromey  <tom@tromey.com>
  94
  95         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
  96         (tui_free_window, free_content, free_content_elements): Remove
  97         unnecessary cast.
  98         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
  99         cast.
 100         * tui/tui-regs.c (tui_show_register_group)
 101         (tui_display_registers_from, tui_display_reg_element_at_line):
 102         Remove unnecessary cast.
 103
 104 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
 105
 106         * linux-nat.c (normal_mask): Delete.
 107         (_initialize_linux_nat): Don't initialise normal_mask.
 108
 109 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
 110
 111         PR gdb/24445
 112         * dwarf-index-write.h (write_psymtabs_to_index): Add
 113         dwz_basename parameter.
 114         * dwarf-index-write.c (write_gdbindex): Move file writing to
 115         write_gdbindex_1.  Change return type void.
 116         (assert_file_size): Move up, remove filename parameter.
 117         (write_gdbindex_1): New function.
 118         (write_debug_names): Change return type to void, call
 119         assert_file_size.
 120         (struct index_wip_file): New struct.
 121         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
 122         file logic to index_wip_file.  Write index for dwz file if
 123         needed.
 124         (save_gdb_index_command): Pass basename of dwz file, if present.
 125         * dwarf-index-cache.c (index_cache::store): Obtain and pass
 126         build-id of dwz file, if present.
 127         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
 128         (dwarf2_get_dwz_file): Likewise.
 129         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
 130         (dwarf2_get_dwz_file): Likewise.
 131
 132 2019-06-16  Tom Tromey  <tom@tromey.com>
 133
 134         * coffread.c (process_coff_symbol): Use xstrdup.
 135         * value.c (create_internalvar): Use xstrdup.
 136
 137 2019-06-16  Tom Tromey  <tom@tromey.com>
 138
 139         * valops.c (value_cast, value_slice): Remove unnecessary cast.
 140         * breakpoint.c (stopin_command, stopat_command)
 141         (until_break_command, decode_location_default): Remove unnecessary
 142         cast.
 143         * utils.c (subset_compare): Remove unnecessary cast.
 144         * ada-lang.c (ada_update_initial_language): Remove unnecessary
 145         cast.
 146         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
 147         cast.
 148         * infcmd.c (path_command): Remove unnecessary cast.
 149         * coffread.c (decode_type): Remove unnecessary cast.
 150         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
 151         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
 152         * tui/tui-stack.c (tui_show_locator_content)
 153         (tui_show_frame_info): Remove unnecessary cast.
 154         * tui/tui-win.c (tui_scroll_forward_command)
 155         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
 156         (parse_scrolling_args): Remove unnecessary cast.
 157         * tui/tui-data.c (init_win_info, tui_del_window)
 158         (tui_free_window, tui_del_data_windows, tui_free_data_content)
 159         (free_content_elements): Remove unnecessary cast.
 160         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
 161         unnecessary cast.
 162         * tui/tui-source.c (tui_set_source_content)
 163         (tui_vertical_source_scroll): Remove unnecessary cast.
 164         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
 165         cast.
 166         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
 167         * tui/tui-regs.c (tui_display_registers_from)
 168         (tui_display_register): Remove unnecessary cast.
 169         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
 170         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
 171         (make_visible): Remove unnecessary cast.
 172         * tui/tui-winsource.c (tui_erase_source_content)
 173         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
 174         unnecessary cast.
 175         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
 176         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
 177         * stabsread.c (read_type, read_array_type, read_range_type):
 178         Remove unnecessary cast.
 179         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
 180         (parse_symbol, parse_type, upgrade_type, parse_external)
 181         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
 182         unnecessary cast.
 183         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
 184
 185 2019-06-16  Tom Tromey  <tom@tromey.com>
 186
 187         * tui/tui-data.c (tui_alloc_generic_win_info)
 188         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
 189         checks.
 190
 191 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
 192             Andrew Burgess  <andrew.burgess@embecosm.com>
 193
 194         * f-typeprint.c (f_print_type): Don't return early for not
 195         associated or not allocated types.
 196         (f_type_print_varspec_suffix): Add print_rank parameter and print
 197         ranks of array types in case they dangling.
 198         (f_type_print_base): Add print_rank parameter.
 199
 200 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 201
 202         * NEWS: Mention new MI commands.
 203         * break-catch-throw.c (enum exception_event_kind): Move to
 204         breakpoint.h.
 205         (print_mention_exception_catchpoint): Output text as a single
 206         message.
 207         (catch_exception_command_1): Rename to...
 208         (catch_exception_event): ...this, make non-static, update header
 209         command, and change some parameter types.
 210         (catch_catch_command): Update for changes to
 211         catch_exception_command_1.
 212         (catch_throw_command): Likewise.
 213         (catch_rethrow_command): Likewise.
 214         * breakpoint.c (enum exception_event_kind): Delete.
 215         * breakpoint.h (enum exception_event_kind): Moved here from
 216         break-catch-throw.c.
 217         (catch_exception_event): Declare.
 218         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
 219         (mi_cmd_catch_throw): New function.
 220         (mi_cmd_catch_rethrow): New function.
 221         (mi_cmd_catch_catch): New function.
 222         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
 223         'catch-catch' entries.
 224         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
 225         (mi_cmd_catch_rethrow): Declare.
 226         (mi_cmd_catch_catch): Declare.
 227
 228 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 229
 230         * annotate.c (annotate_source_line): Change return type to void,
 231         update implementation to match.
 232         * annotate.h (annotate_source_line): Change return type to void,
 233         update header comment.
 234         * stack.c (print_frame_info): Don't change what frame information
 235         is printed based on whether annotations are on or not.
 236
 237 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 238
 239         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
 240         (annotate_source): Make static.
 241         (annotate_source_line): Moved from source.c and renamed from
 242         identify_source_line.  Update the return type.
 243         * annotate.h (annotate_source): Delete declaration.
 244         (annotate_source_line): Declaration moved from source.h, and
 245         renamed from identify_source_line.  Return type updated.
 246         * source.c (identify_source_line): Moved to annotate.c and renamed
 247         to annotate_source_line.
 248         (info_line_command): Remove check of annotation_level.
 249         * source.h (identify_source_line): Move declaration to annotate.h
 250         and rename to annotate_source_line.
 251         * stack.c: Add 'annotate.h' include.
 252         (print_frame_info): Remove check of annotation_level before
 253         calling annotate_source_line.
 254
 255 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 256
 257         * source-cache.c (source_cache::get_plain_source_lines): Use
 258         open_source_file_with_line_charpos instead of just
 259         open_source_file, remove call to find_source_lines.
 260         (source_cache::get_source_lines): Likewise.
 261         * source.c (find_source_lines): Make static.
 262         (get_filename_and_charpos): Renamed into...
 263         (open_source_file_with_line_charpos): ..this along with changes to
 264         return a scoped_fd, and some other minor clean ups.
 265         (identify_source_line): Use open_source_file_with_line_charpos.
 266         (search_command_helper): Use open_source_file_with_line_charpos
 267         instead of just open_source_file, remove call to
 268         find_source_lines.
 269         * source.h (open_source_file_with_line_charpos): Declare new
 270         function.
 271         (find_source_lines): Delete declaration.
 272
 273 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 274
 275         * source.c (get_filename_and_charpos): Remove fullname
 276         parameter.
 277         (identify_source_line): Update call to get_filename_and_charpos.
 278
 279 2019-06-14  Tom Tromey  <tromey@adacore.com>
 280
 281         PR gdb/24502:
 282         * ui-style.h (skip_ansi_escape): Update comment.
 283         * ui-file.h (class no_terminal_escape_file): New class.
 284         * ui-file.c (no_terminal_escape_file::write)
 285         (no_terminal_escape_file::puts): New methods.
 286         * cli/cli-logging.c (handle_redirections): Use
 287         no_terminal_escape_file.
 288
 289 2019-06-14  Tom Tromey  <tromey@adacore.com>
 290
 291         * NEWS: Move convenience variable news above Python news.
 292
 293 2019-06-14  Tom Tromey  <tom@tromey.com>
 294
 295         * gnulib: Move directory to top-level.
 296         * configure.ac: Don't configure gnulib.
 297         * configure: Rebuild.
 298         * common/common-defs.h: Use new path to gnulib.
 299         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
 300         (GNULIB_H): Remove.
 301         (INCGNU): Look in new gnulib location.
 302         (HFILES_NO_SRCDIR): Remove gnulib files.
 303         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
 304         (generated_files): Remove GNULIB_H.
 305         ($(LIBGNU), all-lib): Remove targets.
 306         (distclean): Don't mention GNULIB_BUILDDIR.
 307         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
 308
 309 2019-06-14  Tom Tromey  <tromey@adacore.com>
 310
 311         * symfile.c (add_symbol_file_command): Remove obsolete comment.
 312         Warn if symbol file does not provide any symbols.
 313
 314 2019-06-14  Tom Tromey  <tromey@adacore.com>
 315
 316         * source.c (find_and_open_source): Respect basenames_may_differ.
 317
 318 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
 319
 320         * annotate.c (annotate_breakpoints_invalid): Make use of
 321         scoped_restore_terminal_state.
 322         (annotate_frames_invalid): Likewise.
 323
 324 2019-06-14  Tom Tromey  <tromey@adacore.com>
 325
 326         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
 327         allow assignment to an internalvar.
 328
 329 2019-06-14  Tom Tromey  <tromey@adacore.com>
 330
 331         * ada-lex.l: Allow "_" in attribute names.
 332
 333 2019-06-14  Tom Tromey  <tromey@adacore.com>
 334
 335         PR gdb/24653:
 336         * regcache.c (registers_changed): Don't call alloca.
 337         * top.c (execute_command): Don't call alloca.
 338
 339 2019-06-13  Pedro Alves  <palves@redhat.com>
 340
 341         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
 342         'expression'.  When parsing an expression, error out if there's
 343         junk after "unlimited".
 344         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 345         (do_set_command): Adjust calls to is_unlimited_literal.
 346
 347 2019-06-13  Pedro Alves  <palves@redhat.com>
 348
 349         * compile/compile.c (make_compile_options_def_group): Add braces
 350         around array_view initializer.
 351         * thread.c (make_thread_apply_all_options_def_group)
 352         (make_thread_apply_all_options_def_group): Likewise.
 353
 354 2019-06-13  Pedro Alves  <palves@redhat.com>
 355
 356         * NEWS (New commands): Mention "maint test-options
 357         require-delimiter", "maint test-options unknown-is-error", "maint
 358         test-options unknown-is-operand" and "maint show
 359         test-options-completion-result".
 360         (New command options, command completion): New section.
 361         (Completion improvements): New section.
 362         Mention that you can abbreviate "unlimited".
 363
 364 2019-06-13  Pedro Alves  <palves@redhat.com>
 365
 366         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
 367         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
 368         * unittests/cli-utils-selftests.c (test_parse_flags)
 369         (test_parse_flags_qcs): Delete.
 370         (test_cli_utils): Don't call deleted functions.
 371
 372 2019-06-13  Pedro Alves  <palves@redhat.com>
 373
 374         * thread.c: Include "cli/cli-option.h".
 375         (tp_array_compar_ascending): Global.
 376         (tp_array_compar): Delete function.
 377         (tp_array_compar_ascending, tp_array_compar_descending): New
 378         functions.
 379         (ascending_option_def, qcs_flag_option_def)
 380         (thr_qcs_flags_option_defs)
 381         (make_thread_apply_all_options_def_group)
 382         (make_thread_apply_options_def_group): New.
 383         (thread_apply_all_command): Use gdb::option::process_options.
 384         (thread_apply_command_completer)
 385         (thread_apply_all_command_completer): New.
 386         (thread_apply_command): Use gdb::option::process_options.
 387         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
 388         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
 389         to generate help text of "thread apply".  Adjust "taas"'s help.
 390         * tid-parse.c (tid_range_parser::in_thread_range): New method.
 391         * tid-parse.h (tid_range_parser::in_thread_range): New method.
 392
 393 2019-06-13  Pedro Alves  <palves@redhat.com>
 394
 395         * thread.c (thread_apply_command): Check for invalid TID with
 396         isdigit instead of !isalpha.
 397
 398 2019-06-13  Pedro Alves  <palves@redhat.com>
 399
 400         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
 401         (validate_flags_qcs): New.
 402         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
 403         (validate_flags_qcs): Declare.
 404         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
 405         (make_frame_apply_options_def_group): New.
 406         (frame_apply_command_count): Process options with
 407         gdb::option::process_options.
 408         (frame_apply_completer): New.
 409         (frame_apply_level_completer, frame_apply_all_completer)
 410         (frame_apply_completer): New.
 411         (_initialize_stack): Update help of "frame apply", "frame apply
 412         level", "frame apply all" and "faas" to mention supported options
 413         and install command completers.
 414         * stack.h (frame_apply_all_completer): Declare.
 415         * thread.c: Include "stack.h".
 416         (tfaas_command): Add "--".
 417         (_initialize_thread): Update help "tfaas" to mention supported
 418         options and install command completer.
 419
 420 2019-06-13  Pedro Alves  <palves@redhat.com>
 421
 422         * completer.c (complete_nested_command_line): New.
 423         (gdb_completion_word_break_characters_throw): Add assertion.
 424         * completer.h (complete_nested_command_line): Declare.
 425
 426 2019-06-13  Pedro Alves  <palves@redhat.com>
 427
 428         * stack.c (parse_backtrace_qualifiers): New.
 429         (backtrace_command): Use it.
 430         (backtrace_command_completer): Complete on qualifiers.
 431
 432 2019-06-13  Pedro Alves  <palves@redhat.com>
 433
 434         * frame.c: Include "cli/cli-option.h.
 435         (user_set_backtrace_options): New.
 436         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
 437         Delete.
 438         (get_prev_frame): Adjust.
 439         (boolean_option_def, uinteger_option_def)
 440         (set_backtrace_option_defs): New.
 441         (_initialize_frame): Adjust and use
 442         gdb::option::add_setshow_cmds_for_options to install "set
 443         backtrace past-main" and "set backtrace past-entry".
 444         * frame.h: Include "cli/cli-option.h".
 445         (struct frame_print_options): Forward declare.
 446         (print_frame_arguments_all, print_frame_arguments_scalars)
 447         (print_frame_arguments_none): Declare.
 448         (print_entry_values): Delete declaration.
 449         (struct frame_print_options, user_frame_print_options): New.
 450         (struct set_backtrace_options): New.
 451         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
 452         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
 453         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
 454         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
 455         (list_args_or_locals): Add frame_print_options parameter.
 456         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 457         * python/py-framefilter.c (enumerate_args): Pass down
 458         USER_FRAME_PRINT_OPTIONS.
 459         * stack.c: Include "cli/cli-option.h".
 460         (print_frame_arguments_all, print_frame_arguments_scalars)
 461         (print_frame_arguments_none): Declare.
 462         (print_raw_frame_arguments, print_entry_values): Delete.
 463         (user_frame_print_options): New.
 464         (boolean_option_def, enum_option_def, frame_print_option_defs):
 465         New.
 466         (struct backtrace_cmd_options): New.
 467         (bt_flag_option_def): New.
 468         (backtrace_command_option_defs): New.
 469         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
 470         (print_frame_arg, read_frame_arg, print_frame_args)
 471         (print_frame_info, print_frame): Add frame_print_options parameter
 472         and use it.
 473         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
 474         (backtrace_command_1): Add frame_print_options and
 475         backtrace_cmd_options parameters and use them.
 476         (make_backtrace_options_def_group): New.
 477         (backtrace_command): Process command options with
 478         gdb::option::process_options.
 479         (backtrace_command_completer): New.
 480         (_initialize_stack): Extend "backtrace"'s help to mention
 481         supported options.  Install completer for "backtrace".
 482         Install some settings commands with add_setshow_cmds_for_options.
 483
 484 2019-06-13  Pedro Alves  <palves@redhat.com>
 485
 486         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
 487         and that "set/show print raw frame-arguments" are now deprecated.
 488
 489         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
 490         command.
 491         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
 492         * stack.c (_initialize_stack): Install "set/show print
 493         raw-frame-arguments", and deprecate "set/show print raw
 494         frame-arguments".
 495         * valprint.c (_initialize_valprint): Deprecate "set/show print
 496         raw".
 497
 498 2019-06-13  Pedro Alves  <palves@redhat.com>
 499
 500         * compile/compile.c (struct compile_options): New.
 501         (compile_flag_option_def, compile_command_option_defs)
 502         (make_compile_options_def_group): New.
 503         (compile_file_command): Handle options with
 504         gdb::option::process_options.
 505         (compile_file_command_completer): New function.
 506         (compile_code_command): Handle options with
 507         gdb::option::process_options.
 508         (compile_code_command_completer): New function.
 509         (_initialize_compiler): Install completers for "compile code" and
 510         "compile file".  Mention available options in "compile code" and
 511         "compile code"'s help.
 512         * completer.c (advance_to_completion_word): New, factored out from
 513         ...
 514         (advance_to_expression_complete_word_point): ... this.
 515         (advance_to_filename_complete_word_point): New.
 516         * completer.h (advance_to_filename_complete_word_point): New
 517         declaration.
 518
 519 2019-06-13  Pedro Alves  <palves@redhat.com>
 520
 521         * compile/compile.c: Include "cli/cli-option.h".
 522         (compile_print_value): Scope data pointer is now a
 523         value_print_options pointer; adjust.
 524         (compile_print_command): Process options.  Scope data pointer is
 525         now a value_print_options pointer; adjust.
 526         (_initialize_compile): Update "compile print"'s help to include
 527         supported options.  Install a completer for "compile print".
 528         * cp-valprint.c (show_vtblprint, show_objectprint)
 529         (show_static_field_print): Delete.
 530         (_initialize_cp_valprint): Don't install "set print
 531         static-members", "set print vtbl", "set print object" here.
 532         * printcmd.c: Include "cli/cli-option.h" and
 533         "common/gdb_optional.h".
 534         (print_command_parse_format): Rework to fill in a
 535         value_print_options instead of a format_data.
 536         (print_value): Change parameter type from format_data pointer to
 537         value_print_options reference.  Adjust.
 538         (print_command_1): Process options.  Adjust to pass down a
 539         value_print_options.
 540         (print_command_completer): New.
 541         (_initialize_printcmd): Install print_command_completer as
 542         handle_brkchars completer for the "print" command.  Update
 543         "print"'s help to include supported options.
 544         * valprint.c: Include "cli/cli-option.h".
 545         (show_vtblprint, show_objectprint, show_static_field_print): Moved
 546         here from cp-valprint.c.
 547         (boolean_option_def, uinteger_option_def)
 548         (value_print_option_defs, make_value_print_options_def_group):
 549         New.  Use gdb::option::add_setshow_cmds_for_options to install
 550         "set print elements", "set print null-stop", "set print repeats",
 551         "set print pretty", "set print union", "set print array", "set
 552         print address", "set print symbol", "set print array-indexes".
 553         * valprint.h: Include <string> and "cli/cli-option.h".
 554         (make_value_print_options_def_group): Declare.
 555         (print_value): Change parameter type from format_data pointer to
 556         value_print_options reference.
 557         (print_command_completer): Declare.
 558
 559 2019-06-13  Pedro Alves  <palves@redhat.com>
 560
 561         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
 562         (COMMON_SFILES): Add maint-test-settings.c.
 563         * cli/cli-decode.c (boolean_enums): New global, factored out from
 564         ...
 565         (add_setshow_boolean_cmd): ... here.
 566         * cli/cli-decode.h (boolean_enums): Declare.
 567         * cli/cli-option.c: New file.
 568         * cli/cli-option.h: New file.
 569         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
 570         factored out from ...
 571         (parse_cli_boolean_value(const char *)): ... this.
 572         (is_unlimited_literal): Change parameter type to pointer to
 573         pointer.  Adjust and advance ARG pointer.
 574         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 575         (parse_cli_var_enum): New, factored out from ...
 576         (do_set_command): ... this.  Adjust.
 577         * cli/cli-setshow.h (parse_cli_boolean_value)
 578         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
 579         (parse_cli_var_enum): Declare.
 580         * cli/cli-utils.c: Include "cli/cli-option.h".
 581         (get_ulongest): New.
 582         * cli/cli-utils.h (get_ulongest): Declare.
 583         (check_for_argument): New overloads.
 584         * maint-test-options.c: New file.
 585
 586 2019-06-13  Pedro Alves  <palves@redhat.com>
 587
 588         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
 589         parse a range if "-" is at the end of the string.
 590
 591 2019-06-13  Pedro Alves  <palves@redhat.com>
 592
 593         * cli/cli-setshow.c (parse_auto_binary_operation)
 594         (parse_cli_boolean_value): Don't allow "o".
 595
 596 2019-06-13  Pedro Alves  <palves@redhat.com>
 597
 598         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
 599         * NEWS: Mention maint test-settings KIND.
 600         * maint-test-settings.c: New file.
 601
 602 2019-06-13  Pedro Alves  <palves@redhat.com>
 603
 604         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
 605         completer.
 606         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
 607         "set" completers.
 608
 609 2019-06-13  Pedro Alves  <palves@redhat.com>
 610
 611         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
 612         after item.
 613
 614 2019-06-13  Pedro Alves  <palves@redhat.com>
 615
 616         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
 617
 618 2019-06-13  Pedro Alves <palves@redhat.com>
 619
 620         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
 621         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
 622         call.
 623         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
 624         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
 625         calls.
 626         (check_for_argument): Skip spaces after argument.
 627
 628 2019-06-13  Pedro Alves  <palves@redhat.com>
 629
 630         * thread.c (thread_apply_command): Adjust TID parsing.
 631         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
 632         detected before end of string.
 633         (tid_is_in_list): Error out if LIST is invalid.
 634
 635 2019-06-13  Pedro Alves  <palves@redhat.com>
 636
 637         * completer.c (complete_line_internal_1): Rewind completion word
 638         point.
 639         (completion_tracker::advance_custom_word_point_by): Change
 640         parameter type to int.
 641         * completer.h (completion_tracker::advance_custom_word_point_by):
 642         Likewise.
 643
 644 2019-06-13  Pedro Alves  <palves@redhat.com>
 645
 646         * completer.c (advance_to_completion_word): Handle delimiters.
 647
 648 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
 649
 650         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
 651
 652 2019-06-11  Tom Tromey  <tom@tromey.com>
 653
 654         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
 655         (xmalloc_failed): Move to alloc.c.
 656         * alloc.c: New file.
 657         * Makefile.in (COMMON_SFILES): Add alloc.c.
 658
 659 2019-06-11  Tom Tromey  <tom@tromey.com>
 660
 661         * nat/linux-waitpid.c: Don't include server.h.
 662         (linux_debug): Remove.
 663         (my_waitpid): Update.
 664
 665 2019-06-11  Tom Tromey  <tromey@adacore.com>
 666
 667         * infcall.c (_initialize_infcall): Remove trailing newline from
 668         help.
 669         * user-regs.c (_initialize_user_regs): Remove trailing newline
 670         from help.
 671         * typeprint.c (_initialize_typeprint): Remove trailing newline
 672         from help.
 673         * reverse.c (_initialize_reverse): Remove trailing newlines from
 674         help.
 675         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
 676         from help.
 677         * language.c (add_set_language_command): Remove trailing newline
 678         from help.
 679         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
 680         help.
 681         * disasm.c (_initialize_disasm): Remove trailing newline from
 682         help.
 683         * top.c (init_main): Remove trailing newline from help.
 684         * interps.c (_initialize_interpreter): Remove trailing newline
 685         from help.
 686         * btrace.c (_initialize_btrace): Remove trailing newlines from
 687         help.
 688         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
 689         from help.
 690         * python/python.c (_initialize_python): Remove trailing newline
 691         from help.
 692         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
 693         help.
 694         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
 695         from help.  Reformat some text.
 696         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
 697         from help.
 698         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
 699         newline from help.
 700
 701 2019-06-11  Tom Tromey  <tromey@adacore.com>
 702
 703         * darwin-nat.c (darwin_decode_exception_message)
 704         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
 705
 706 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
 707
 708         * valops.c (value_slice): Check for not allocated or not
 709         associated values.
 710
 711 2019-06-10  Tom de Vries  <tdevries@suse.de>
 712
 713         PR gdb/24618
 714         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
 715         sure an empty slot (defined by a 32-bit zero pair) is recognized as
 716         invalid.
 717
 718 2019-06-10  Tom de Vries  <tdevries@suse.de>
 719
 720         PR gdb/24611
 721         * linespec.c (linespec_lexer_lex_string): Remove incorrect
 722         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
 723
 724 2019-06-10  Tom de Vries  <tdevries@suse.de>
 725
 726         PR symtab/24545
 727         * symtab.c (struct demangled_name_entry): Add language field.
 728         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
 729         static minimal symbol".  Set and use language field.
 730
 731 2019-06-10  Tom Tromey  <tromey@adacore.com>
 732
 733         * ada-lang.c (_initialize_ada_language): Update help text.
 734
 735 2019-06-10  Tom Tromey  <tromey@adacore.com>
 736
 737         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
 738         with a newline.
 739         * guile/guile.c (handle_boot_error): Don't end warning with a
 740         newline.
 741         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
 742         warning with a newline.
 743         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
 744         newline.
 745         (s12z_frame_cache): Likewise.
 746         * dwarf-index-cache.c (index_cache::store): Don't end warning with
 747         a newline.
 748         * solib-svr4.c (disable_probes_interface): Don't end warning with
 749         a newline.
 750         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
 751         newline.
 752         * python/python.c (do_finish_initialization): Don't end warning
 753         with a newline.
 754
 755 2019-06-10  Tom Tromey  <tom@tromey.com>
 756
 757         * python/py-breakpoint.c (gdbpy_breakpoint_created)
 758         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
 759         gdbpy_enter.
 760
 761 2019-06-10  Tom Tromey  <tromey@adacore.com>
 762
 763         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
 764         data.
 765         (elf_new_init): Don't call stabsread_new_init.
 766         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
 767         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
 768         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
 769
 770 2019-06-10  Tom de Vries  <tdevries@suse.de>
 771
 772         PR symtab/16264
 773         PR symtab/24517
 774         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
 775
 776 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
 777
 778         * source.c (find_and_open_source): Also rewrite relative file
 779         names.
 780
 781 2019-04-26  Amos Bird  <amosbird@gmail.com>
 782
 783         * annotate.c (annotate_thread_exited): Add "thread-exited"
 784         annotation.
 785
 786 2019-06-06  Tom Tromey  <tromey@adacore.com>
 787
 788         * maint.h (class scoped_command_stats): Use
 789         DISABLE_COPY_AND_ASSIGN.
 790         <print_time>: New method.
 791         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
 792         print_time.
 793         (scoped_command_stats::print_time): New method.
 794
 795 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
 796
 797         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
 798         instructions of lengths 6 or 8 bytes.
 799
 800 2019-06-04  Pedro Alves  <palves@redhat.com>
 801
 802         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
 803
 804         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
 805         * breakpoint.c (condition_completer): Likewise.
 806         * cli/cli-dump.c (scan_expression): Likewise.
 807         * common/filestuff.c (mkdir_recursive): Likewise.
 808         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
 809         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
 810         (gdb_abspath): Likewise.
 811         * compile/compile-cplus-types.c
 812         (compile_cplus_instance::decl_name): Likewise.
 813         * completer.c (complete_explicit_location):
 814         (signal_completer, reg_or_group_completer_1): Likewise.
 815         * cp-support.c (cp_remove_params_if_any): Likewise.
 816         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
 817         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
 818         * infcmd.c (strip_bg_char): Likewise.
 819         * linespec.c (copy_token_string): Likewise.
 820         * mi/mi-main.c (output_cores): Likewise.
 821         * psymtab.c (psymtab_search_name):
 822         * symfile.c (test_set_ext_lang_command): Likewise.
 823         * target.c (target_fileio_read_stralloc): Likewise.
 824         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
 825         * value.c (complete_internalvar): Likewise.
 826
 827 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
 828
 829         Add objfile property to gdb.Type.
 830         * NEWS: Mention Python API addition.
 831         * python/py-type.c (typy_get_objfile): New method.
 832
 833 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 834
 835         * NEWS: Mention the new set|show style [title|highlight].
 836         Mention changes to "show style", "help" and "apropos".
 837
 838 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 839
 840         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
 841         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
 842         instead of print_help_for_command.
 843         (print_doc_of_command): New function.
 844         (help_list): Add 'apropos -v word' suggestion.
 845         (print_help_for_command): Style the command name using title style.
 846         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
 847         (_initialize_cli_cmds): Describe -v in apropos_command help.
 848
 849 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 850
 851         * cli/cli-style.h (cli_style_option): Add name in constructor,
 852         add m_name class member, add constructor with intensity,
 853         add name class function.
 854         (cli_style_option::add_setshow_commands): Remove name argument.
 855         (highlight_style, title_style): New styles.
 856         * cli/cli-style.c (do_show): New function that shows a style
 857         characteristic styling the style name with itself.
 858         (set_style_name): New function.
 859         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
 860         Update all callers according to the changes in cli/cli-style.h.
 861         * utils.h (fputs_highlighted): New function.
 862         * utils.c (fputs_highlighted): Likewise.
 863
 864 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 865
 866         * NEWS: Mention new pipe command and new convenience variables.
 867
 868 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 869
 870         * cli/cli-cmds.c (pipe_command): New function.
 871         (_initialize_cli_cmds): Call add_com for pipe_command.
 872         Define | as an alias for pipe.
 873         (exit_status_set_internal_vars): New function.
 874         (shell_escape): Call exit_status_set_internal_vars.
 875         cli/cli-decode.c (find_command_name_length): Recognize | as
 876         a single character command.
 877
 878 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 879
 880         * gdbcmd.h (execute_command_to_ui_file): New declaration.
 881         top.c (execute_command_to_ui_file): New function, mostly a copy
 882         of execute_command_to_string.
 883         (execute_command_to_string): Implement by calling
 884         execute_command_to_ui_file.
 885
 886 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 887
 888         * top.h (saved_command_line): Remove declaration.
 889         * top.c (previous_saved_command_line, previous_repeat_arguments):
 890         New variables.
 891         (saved_command_line): Make static, define together with other
 892         'repeat variables'.
 893         (dont_repeat): Clear repeat_arguments.
 894         (repeat_previous, get_saved_command_line, save_command_line):
 895         New functions.
 896         (gdb_init): Initialize saved_command_line
 897         and previous_saved_command_line.
 898         * main.c (captured_main_1): Remove saved_command_line initialization.
 899         * event-top.c (handle_line_of_input): Update to use
 900         the new 'repeat' related functions instead of direct access to
 901         saved_command_line.
 902         * command.h (repeat_previous, get_saved_command_line,
 903         save_command_line): New declarations.
 904         (dont_repeat): Add comment.
 905
 906 2019-05-30  Tom Tromey  <tromey@adacore.com>
 907
 908         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
 909         Fix comment.
 910         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
 911
 912 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
 913
 914         PR cli/24587
 915         * completer.c (complete): Initialize variable word.
 916
 917 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
 918
 919         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
 920         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
 921         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
 922         'body' is NULL to the outter 'if', protecting the '!is_define'
 923         situation as well.
 924
 925 2019-05-29  Tom Tromey  <tromey@adacore.com>
 926
 927         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
 928         (dwarf_unknown): New function.
 929         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
 930         (dwarf_type_encoding_name): Use dwarf_unknown.
 931
 932 2019-05-29  Tom Tromey  <tromey@adacore.com>
 933
 934         PR c++/20020:
 935         * cp-valprint.c (cp_print_value_fields): Call
 936         cp_print_static_field inside "try".
 937
 938 2019-05-29  Tom Tromey  <tromey@adacore.com>
 939
 940         * inflow.c (struct terminal_info): Add default operator=.
 941         * configure: Rebuild.
 942         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
 943         -Wdeprecated-copy-dtor, -Wredundant-move.
 944
 945 2019-05-29  Tom Tromey  <tromey@adacore.com>
 946
 947         * NEWS: Add entry.
 948         * infcmd.c (print_return_value_1): Handle finish_print
 949         option.
 950         (show_print_finish): New function.
 951         (_initialize_infcmd): Add "set/show print finish" commands.
 952         * valprint.c (user_print_options): Initialize new member.
 953         * valprint.h (struct value_print_options) <finish_print>: New
 954         member.
 955
 956 2019-05-28  Tom Tromey  <tromey@adacore.com>
 957
 958         * ada-lang.c (ada_remove_Xbn_suffix)
 959         (find_old_style_renaming_symbol)
 960         (parse_old_style_renaming): Remove.
 961         (ada_find_renaming_symbol): Don't call
 962         find_old_style_renaming_symbol.
 963         (ada_is_renaming_symbol): Rename from
 964         ada_find_renaming_symbol.  Remove "block" parameter.  Return
 965         bool.  Now static.
 966         (ada_read_var_value): Update and simplify.
 967         * ada-exp.y (write_var_or_type): Remove old code.
 968
 969 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
 970
 971         * event-top.c: Remove include comment.
 972         * inflow.c (class scoped_ignore_sigttou): Move from here...
 973         * inflow.h (class scoped_ignore_sigttou): ...to here.
 974         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
 975         * top.c:  Remove include comment.
 976
 977 2019-05-27  Tom Tromey  <tom@tromey.com>
 978
 979         * NEWS: Fix typo.
 980
 981 2019-05-22  Tom Tromey  <tromey@adacore.com>
 982
 983         * target.c (target_follow_exec): Constify parameter.
 984         * target-delegates.c: Rebuild.
 985         * remote.c (remote_target::follow_exec): Constify parameter.
 986         * infrun.c (follow_exec): Constify parameter.
 987         * target.h (struct target_ops) <follow_exec>: Constify parameter.
 988         (target_follow_exec): Likewise.
 989
 990 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 991
 992         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
 993         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
 994
 995 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
 996
 997         * NEWS: Add debugredirect and testsuite sections.
 998
 999 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
1000
1001         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
1002         target descriptions using exclusively floating point register name
1003         aliases.
1004
1005 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
1006
1007         PR gdb/18644:
1008         * f-lang.c (build_fortran_types): Handle the case where
1009         gdbarch_floatformat_for_type returns a nullptr.
1010
1011 2019-05-21  Tom de Vries  <tdevries@suse.de>
1012
1013         PR cli/24587
1014         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
1015
1016 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         PR gdb/18644:
1019         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
1020         16-byte floats.
1021         * i386-tdep.c (i386_floatformat_for_type): Use
1022         floatformats_ia64_quad for the 16-byte floating point component
1023         within a fortran 32-byte complex number.
1024
1025 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
1026
1027         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
1028         delete default constructor.
1029         (find_partial_die): Update to return const struct.
1030         (partial_die_parent_scope): Move variable declaration into scope
1031         of its use and change its type to auto.
1032         (guess_partial_die_structure_name): Likewise.
1033         (partial_die_info::fixup): Likewise.
1034
1035 2019-05-17  Tom Tromey  <tromey@adacore.com>
1036
1037         * source.c (find_and_open_source): Remove cast.
1038
1039 2019-05-17  Tom Tromey  <tromey@adacore.com>
1040
1041         * annotate.c (annotate_source): Make "filename" const.
1042         * annotate.h (annotate_source): Use const.
1043
1044 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1045
1046         * disasm.c (set_disassembler_options): Send errors to stderr.
1047
1048 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1049
1050         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
1051         (cli_interp_base::set_logging): Check debug_redirect.
1052         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
1053         * cli/cli-logging.c (debug_redirect): Add static variable.
1054         (pop_output_files): Add default param.
1055         (handle_redirections): Print debug setting.
1056         (show_logging_command): Likewise.
1057         (_initialize_cli_logging): Add debugredirect command.
1058         * interps.c (current_interp_set_logging): Add debug_redirect
1059         parameter.
1060         * interps.h (set_logging): Add debug_redirect parameter.
1061         (current_interp_set_logging): Likewise.
1062         * mi/mi-common.h: Likewise.
1063         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
1064
1065 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
1066             Tom Tromey  <tromey@adacore.com>
1067
1068         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
1069         directly.
1070         * cli/cli-interp.h (make_logging_output): Remove declaration.
1071         * cli/cli-logging.c (make_logging_output): Remove function.
1072         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
1073         directly.
1074         * ui-file.c (tee_file::tee_file): Remove bools.
1075         (tee_file::~tee_file): Remove deletes.
1076         * ui-file.h (tee_file): Remove bools.
1077
1078 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
1079
1080         * mi/mi-cmds.h (mi_cmd_complete): New function.
1081         * mi/mi-main.c (mi_cmd_complete): Likewise.
1082         * mi/mi-cmds.c: Define new MI command -complete.
1083         * NEWS: Mention new -complete command.
1084
1085 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
1086
1087         * completer.h (complete): New function.
1088         * completer.c (complete): Likewise.
1089         * cli/cli-cmds.c: (complete_command): Update to use new complete()
1090         function defined in completer.h.
1091
1092 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
1093
1094         * MAINTAINERS (Write After Approval): Add myself.
1095
1096 2019-05-17  Tom de Vries  <tdevries@suse.de>
1097
1098         PR gdb/24094
1099         * dwarf2read.c (struct cu_partial_die_info): New struct.
1100         (find_partial_die): Return cu_partial_die_info.
1101         (partial_die_parent_scope, guess_partial_die_structure_name)
1102         (partial_die_info::fixup): Handle new return type of find_partial_die.
1103
1104 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1105
1106         * stap-probe.c (stap_parse_register_operand): Make "regname" an
1107         "std::string", simplifying the algorithm.
1108
1109 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1110
1111         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
1112         (stap_static_probe_ops::get_probes): Likewise.
1113
1114 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1115
1116         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
1117         '-')" and "else if".
1118         (stap_parse_single_operand): Join checks for
1119         "gdbarch_stap_parse_special_token_p" and
1120         "gdbarch_stap_parse_special_token" in the same "if" statement.
1121         Invert check when verifying for operation on register
1122         displacement.
1123
1124 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1125
1126         * stap-probe.c (stap_get_opcode): Update comment.
1127         (stap_get_expected_argument_type): Likewise.
1128         (handle_stap_probe): Likewise.
1129
1130 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
1131
1132         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
1133         return type to 'bool'.  Adjust comment.  Use 'bool' when
1134         appropriate.
1135         (i386_stap_parse_special_token_three_arg_disp): Likewise.
1136         * stap-probe.c (stap_parse_argument_1): Likewise.
1137         (stap_is_operator): Likewise.
1138         (stap_is_generic_prefix): Likewise.
1139         (stap_is_register_prefix): Likewise.
1140         (stap_is_register_indirection_prefix): Likewise.
1141         (stap_is_integer_prefix): Likewise.
1142         (stap_generic_check_suffix): Likewise.
1143         (stap_check_integer_suffix): Likewise.
1144         (stap_check_register_suffix): Likewise.
1145         (stap_check_register_indirection_suffix): Likewise.
1146         (stap_parse_register_operand): Likewise.
1147         (stap_parse_single_operand): Likewise.
1148         (stap_parse_argument_1): Likewise.
1149         (stap_probe::get_argument_count): Likewise.
1150         (stap_is_operator): Likewise.
1151
1152 2019-05-16  Tom Tromey  <tromey@adacore.com>
1153
1154         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
1155         keyword to foreach.
1156
1157 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
1158
1159         * linux-thread-db.c (try_thread_db_load_1): Change return type
1160         to bool.
1161         (try_thread_db_load): Likewise.
1162         (try_thread_db_load_from_pdir_1): Likewise.
1163         (try_thread_db_load_from_pdir): Likewise.
1164         (try_thread_db_load_from_sdir): Likewise.
1165         (try_thread_db_load_from_dir): Likewise.
1166         (thread_db_load_search): Likewise.
1167         (has_libpthread): Likewise.
1168         (thread_db_load): Likewise.
1169
1170 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
1171
1172         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
1173         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
1174         NULL, and complain/return if that's the case.
1175
1176 2019-05-15  John Darrington <john@darrington.wattle.id.au>
1177
1178         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
1179         (advance, posn, abstract_read_memory): New functions.
1180         [struct mem_read_abstraction]: New struct.
1181         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
1182
1183 2019-05-14  Tom Tromey  <tromey@adacore.com>
1184
1185         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
1186         value is not lval_memory.
1187
1188 2019-05-14  Tom Tromey  <tromey@adacore.com>
1189
1190         * solib.c (info_sharedlibrary_command): Style the file name.
1191
1192 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
1193
1194         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
1195         (aarch64_vnv_type): Likewise.
1196         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
1197         * common/tdesc.c: Likewise.
1198         * common/tdesc.h (enum tdesc_type_kind): Likewise.
1199         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
1200         * features/aarch64-fpu.xml: Add ieee half view.
1201         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
1202         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
1203         * gdbtypes.h (struct builtin_type): Likewise.
1204         (struct objfile_type): Likewise.
1205
1206 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
1207
1208         * language.c (language_sniff_from_mangled_name): Fix "langauge"
1209         typo.
1210         * location.h (string_to_event_location): Likewise.
1211
1212 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
1213
1214         GDB 8.3 released.
1215
1216 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1217
1218         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
1219         New variable declaration.
1220         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
1221         New variable.
1222         (print_one_breakpoint): Use ui_out::test_flags and new global
1223         variable to compute use_fixed_output.
1224         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
1225         Remove.
1226         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
1227         (mi_multi_location_breakpoint_output_fixed): Remove.
1228         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
1229         new variable.
1230         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
1231         fix_multi_location_breakpoint_output flag if version >= 3.
1232         * ui-out.h (enum ui_out_flag)
1233         <fix_multi_location_breakpoint_output>: New enumerator.
1234
1235 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
1236
1237         * contrib/cc-with-tweaks.sh: Validate dwz's work.
1238
1239 2019-05-10  Tom Tromey  <tromey@adacore.com>
1240
1241         * ada-lang.c (catch_ada_completer): New function.
1242         (_initialize_ada_language): Use it.
1243
1244 2019-05-10  Tom Tromey  <tromey@adacore.com>
1245
1246         * thread.c (print_thread_info): Make "requested_threads" const.
1247         * gdbthread.h (print_thread_info): Make "requested_threads"
1248         const.
1249         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
1250         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
1251
1252 2019-05-08  Tom Tromey  <tom@tromey.com>
1253
1254         * gdbtypes.c (objfile_type_data): Change type.
1255         (objfile_type, _initialize_gdbtypes): Update.
1256
1257 2019-05-08  Tom Tromey  <tom@tromey.com>
1258
1259         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
1260         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
1261         (_initialize_dwarf2_frame): Update.
1262
1263 2019-05-08  Tom Tromey  <tom@tromey.com>
1264
1265         * objc-lang.c (objc_objfile_data): Change type.
1266         (find_methods): Update.
1267         (_initialize_objc_lang): Remove.
1268
1269 2019-05-08  Tom Tromey  <tom@tromey.com>
1270
1271         * stabsread.c (rs6000_builtin_type_data): Change type.
1272         (rs6000_builtin_type, _initialize_stabsread): Update.
1273
1274 2019-05-08  Tom Tromey  <tom@tromey.com>
1275
1276         * mips-tdep.c (mips_pdr_data): Remove.
1277         (_initialize_mips_tdep): Update.
1278
1279 2019-05-08  Tom Tromey  <tom@tromey.com>
1280
1281         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
1282         (hppa_init_objfile_priv_data, read_unwind_info)
1283         (find_unwind_entry, _initialize_hppa_tdep): Update.
1284
1285 2019-05-08  Tom Tromey  <tom@tromey.com>
1286
1287         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
1288         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
1289         on obstack.
1290         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
1291
1292 2019-05-08  Tom Tromey  <tom@tromey.com>
1293
1294         * mdebugread.c (basic_type_data): Change type.
1295         (basic_type, _initialize_mdebugread): Update.
1296
1297 2019-05-08  Tom Tromey  <tom@tromey.com>
1298
1299         * common/gdb_unique_ptr.h (struct noop_deleter): New.
1300
1301 2019-05-08  Tom Tromey  <tom@tromey.com>
1302
1303         * nto-tdep.c (nto_inferior_data_reg): Change type.
1304         (nto_inferior_data): Update.
1305         (nto_inferior_data_cleanup, nto_new_inferior_data)
1306         (_initialize_nto_tdep): Remove.
1307         * nto-tdep.h (struct nto_inferior_data): Add initializers.
1308
1309 2019-05-08  Tom Tromey  <tom@tromey.com>
1310
1311         * ada-lang.c (struct ada_inferior_data): Add initializers.
1312         (ada_inferior_data): Change type.
1313         (ada_inferior_data_cleanup): Remove.
1314         (get_ada_inferior_data, ada_inferior_exit)
1315         (struct ada_pspace_data): Add initializers, destructor.
1316         (ada_pspace_data_handle): Change type.
1317         (get_ada_pspace_data): Update.
1318         (ada_pspace_data_cleanup): Remove.
1319
1320 2019-05-08  Tom Tromey  <tom@tromey.com>
1321
1322         * coffread.c (struct coff_symfile_info): Add initializers.
1323         (coff_objfile_data_key): Move lower.  Change type.
1324         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
1325         Update.
1326         (coff_free_info): Remove.
1327
1328 2019-05-08  Tom Tromey  <tom@tromey.com>
1329
1330         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
1331         (fbsd_pspace_data_handle): Move lower.  Change type.
1332         (get_fbsd_pspace_data): Update.
1333         (fbsd_pspace_data_cleanup): Remove.
1334         (_initialize_fbsd_tdep): Update.
1335
1336 2019-05-08  Tom Tromey  <tom@tromey.com>
1337
1338         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
1339         (get_ada_tasks_pspace_data): Update.
1340         (ada_tasks_pspace_data_cleanup): Remove.
1341         (_initialize_tasks): Update.
1342         (ada_tasks_inferior_data_handle): Change type.
1343         (get_ada_tasks_inferior_data): Update.
1344         (ada_tasks_inferior_data_cleanup): Remove.
1345         (struct ada_tasks_pspace_data): Add initializers.
1346
1347 2019-05-08  Tom Tromey  <tom@tromey.com>
1348
1349         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
1350         * symfile-debug.c (debug_sym_get_probes): Change type.
1351         * stap-probe.c (handle_stap_probe):
1352         (stap_static_probe_ops::get_probes): Change type.
1353         * probe.h (class static_probe_ops) <get_probes>: Change type.
1354         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
1355         (parse_probes_in_pspace): Update.
1356         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
1357         Update.
1358         (any_static_probe_ops::get_probes): Change type.
1359         * elfread.c (elfread_data): New typedef.
1360         (probe_key): Change type.
1361         (elf_get_probes): Likewise.  Update.
1362         (probe_key_free): Remove.
1363         (_initialize_elfread): Update.
1364         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
1365         Change type.
1366         (dtrace_process_dof_probe, dtrace_process_dof)
1367         (dtrace_static_probe_ops::get_probe): Change type.
1368
1369 2019-05-08  Tom Tromey  <tom@tromey.com>
1370
1371         * xcoffread.c (struct xcoff_symfile_info): Rename from
1372         coff_symfile_info.  Add initializers.
1373         (xcoff_objfile_data_key): Move lower.  Change type.
1374         (XCOFF_DATA): Rewrite.
1375         (xcoff_free_info): Remove.
1376         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
1377         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
1378         (xcoff_initial_scan): Update.
1379
1380 2019-05-08  Tom Tromey  <tom@tromey.com>
1381
1382         * solib-svr4.c (struct svr4_info): Add initializers and
1383         destructor.
1384         <probes_table>: Now an htab_up.
1385         (solib_svr4_pspace_data): Change type.
1386         (free_probes_table): Simplify.
1387         (~svr4_info): Rename from svr4_pspace_data_cleanup.
1388         (get_svr4_info, probes_table_htab_remove_objfile_probes)
1389         (probes_table_remove_objfile_probes, register_solib_event_probe)
1390         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
1391         (_initialize_svr4_solib): Update.
1392
1393 2019-05-08  Tom Tromey  <tom@tromey.com>
1394
1395         * remote.c (remote_pspace_data): Change type.
1396         (remote_pspace_data_cleanup): Remove.
1397         (get_remote_exec_file, set_pspace_remote_exec_file)
1398         (_initialize_remote): Update.
1399
1400 2019-05-08  Tom Tromey  <tom@tromey.com>
1401
1402         * breakpoint.c (breakpoint_objfile_key): Change type.
1403         (get_breakpoint_objfile_data): Update.
1404         (free_breakpoint_objfile_data): Remove.
1405         (_initialize_breakpoint): Update.
1406
1407 2019-05-08  Tom Tromey  <tom@tromey.com>
1408
1409         * linux-tdep.c (struct linux_info): Add initializers.
1410         (linux_inferior_data): Move.  Change type.
1411         (invalidate_linux_cache_inf): Update.
1412         (linux_inferior_data_cleanup): Remove.
1413         (get_linux_inferior_data, _initialize_linux_tdep): Update.
1414
1415 2019-05-08  Tom Tromey  <tom@tromey.com>
1416
1417         * auxv.c (auxv_inferior_data): Move.  Change type.
1418         (auxv_inferior_data_cleanup): Remove.
1419         (invalidate_auxv_cache_inf): Rewrite.
1420         (get_auxv_inferior_data, _initialize_auxv): Update.
1421
1422 2019-05-08  Tom Tromey  <tom@tromey.com>
1423
1424         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
1425         (symfile_debug_objfile_data_key): Change type.
1426         (symfile_debug_installed, debug_qf_has_symbols)
1427         (debug_qf_find_last_source_symtab)
1428         (debug_qf_forget_cached_source_info)
1429         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
1430         (debug_qf_print_stats, debug_qf_dump)
1431         (debug_qf_expand_symtabs_for_function)
1432         (debug_qf_expand_all_symtabs)
1433         (debug_qf_expand_symtabs_with_fullname)
1434         (debug_qf_map_matching_symbols)
1435         (debug_qf_expand_symtabs_matching)
1436         (debug_qf_find_pc_sect_compunit_symtab)
1437         (debug_qf_map_symbol_filenames)
1438         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
1439         (debug_sym_new_init, debug_sym_init, debug_sym_read)
1440         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
1441         (debug_sym_read_linetable, debug_sym_relocate): Update.
1442         (symfile_debug_free_objfile): Remove.
1443         (install_symfile_debug_logging, _initialize_symfile_debug):
1444         Update.
1445
1446 2019-05-08  Tom Tromey  <tom@tromey.com>
1447
1448         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
1449         allocate_on_obstack.
1450         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
1451         (get_dwarf2_per_objfile): Update.
1452         (set_dwarf2_per_objfile): Remove.
1453         (dwarf2_has_info, dwarf2_get_section_info): Update.
1454         (dwarf2_free_objfile): Remove.
1455         (_initialize_dwarf2_read): Update.
1456
1457 2019-05-08  Tom Tromey  <tom@tromey.com>
1458
1459         * auto-load.c (struct auto_load_pspace_info): Add destructor and
1460         initializers.
1461         <unsupported_script_warning_printed,
1462         script_not_found_warning_printed>: Now bool.
1463         (auto_load_pspace_data): Change type.
1464         (~auto_load_pspace_info): Rename from
1465         auto_load_pspace_data_cleanup.
1466         (get_auto_load_pspace_data, init_loaded_scripts_info)
1467         (clear_section_scripts, maybe_print_unsupported_script_warning)
1468         (maybe_print_script_not_found_warning, _initialize_auto_load):
1469         Update.
1470
1471 2019-05-08  Tom Tromey  <tom@tromey.com>
1472
1473         * objfiles.c (objfile_pspace_info): Add destructor and
1474         initializers.
1475         (objfiles_pspace_data): Change type.
1476         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
1477         (get_objfile_pspace_data): Update.
1478         (objfiles_bfd_data): Change type.
1479         (get_objfile_bfd_data): Update.
1480         (objfile_bfd_data_free, _initialize_objfiles): Remove.
1481
1482 2019-05-08  Tom Tromey  <tom@tromey.com>
1483
1484         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
1485         Change type.
1486         (get_catch_syscall_inferior_data): Update.
1487         (catch_syscall_inferior_data_cleanup): Remove.
1488         (_initialize_break_catch_syscall): Update.
1489
1490 2019-05-08  Tom Tromey  <tom@tromey.com>
1491
1492         * inflow.c (struct terminal_info): Add destructor and
1493         initializers.
1494         (inflow_inferior_data): Change type.
1495         (~terminal_info): Rename from inflow_inferior_data_cleanup.
1496         (get_inflow_inferior_data, inflow_inferior_exit)
1497         (swap_terminal_info, _initialize_inflow): Update.
1498
1499 2019-05-08  Tom Tromey  <tom@tromey.com>
1500
1501         * target-dcache.c (target_dcache_cleanup): Remove.
1502         (target_dcache_aspace_key): Change type.
1503         (target_dcache_init_p, target_dcache_invalidate)
1504         (target_dcache_get, target_dcache_get_or_init)
1505         (_initialize_target_dcache): Update.
1506         * dcache.h (struct dcache_deleter): New.
1507
1508 2019-05-08  Tom Tromey  <tom@tromey.com>
1509
1510         * symtab.c (struct symbol_cache): Add destructor and
1511         initializers.
1512         (symbol_cache_key): Move.  Change type.
1513         (make_symbol_cache, free_symbol_cache): Remove.
1514         (get_symbol_cache): Update.
1515         (symbol_cache_cleanup): Remove.
1516         (ALL_PSPACES, symbol_cache_flush)
1517         (maintenance_print_symbol_cache)
1518         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
1519         Update.
1520
1521 2019-05-08  Tom Tromey  <tom@tromey.com>
1522
1523         * symtab.c (struct main_info): Add destructor and initializers.
1524         (main_progspace_key): Move.  Change type.
1525         (get_main_info): Update.
1526         (main_info_cleanup): Remove.
1527         (_initialize_symtab): Update.
1528
1529 2019-05-08  Tom Tromey  <tom@tromey.com>
1530
1531         * registry.h (DECLARE_REGISTRY): Define the _key class.
1532
1533 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
1534
1535         * NEWS: Merge two 'New commands' sections.
1536
1537 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
1538
1539         * ada-valprint.c (ada_val_print_gnat_array): Remove language
1540         parameter and use Ada language definition instead.
1541         (ada_val_print_ptr): Remove unused language parameter.
1542         (ada_val_print_num): Remove language parameter and use Ada language
1543         definition instead.
1544         (ada_val_print_enum, ada_val_print_flt): Remove unused language
1545         parameter.
1546         (ada_val_print_struct_union, ada_val_print_ref): Remove language
1547         parameter and use Ada language definition instead.
1548         (ada_val_print_1): Update all ada_val_print_xxx calls.
1549         Remove language parameter.
1550         (ada_val_print): Update ada_val_print_1 call.
1551
1552 2019-05-08  Tom Tromey  <tromey@adacore.com>
1553
1554         * remote.c (remote_hw_watchpoint_limit)
1555         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
1556         Now static.
1557
1558 2019-05-08  Tom Tromey  <tromey@adacore.com>
1559
1560         * maint.c (_initialize_maint_cmds): Move initialization code to
1561         remote.c.
1562         (watchdog, show_watchdog): Move to remote.c.
1563         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
1564         "watchdog" static.
1565         (_initialize_remote): Move initialization code from maint.c.
1566         * defs.h (watchdog): Don't declare.
1567
1568 2019-05-08  Tom Tromey  <tromey@adacore.com>
1569
1570         * tui/tui-interp.c: Include main.h.
1571         * interps.c: Include main.h.
1572         * main.h (interpreter_p): Declare.
1573         * defs.h (interpreter_p): Don't declare.
1574
1575 2019-05-08  Tom Tromey  <tromey@adacore.com>
1576
1577         * dwarf2loc.c: Include dwarf2read.h.
1578         * defs.h (read_unsigned_leb128): Don't declare.
1579         * dwarf2read.h (read_unsigned_leb128): Declare.
1580
1581 2019-05-08  Tom Tromey  <tromey@adacore.com>
1582
1583         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
1584         method.
1585
1586 2019-05-08  Tom Tromey  <tromey@adacore.com>
1587
1588         * utils.c (fputs_maybe_filtered): Reset style after paging, even
1589         when no wrap column is set.
1590
1591 2019-05-08  Tom Tromey  <tromey@adacore.com>
1592
1593         * c-lang.c (c_get_string): Handle non-C-style arrays.
1594
1595 2019-05-08  Tom Tromey  <tromey@adacore.com>
1596
1597         * typeprint.c (print_offset_data::update): Print the bit offset,
1598         not the number of bits remaining.
1599
1600 2019-05-08  Tom Tromey  <tromey@adacore.com>
1601
1602         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
1603         padding at end of comment.
1604
1605 2019-05-08  Tom Tromey  <tromey@adacore.com>
1606
1607         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
1608         Compare main types.
1609
1610 2019-05-06  Tom Tromey  <tom@tromey.com>
1611
1612         * common/scoped_mmap.c: Include common-defs.h.
1613         * common/scoped_mmap.h: Don't include config.h.
1614
1615 2019-05-04  Tom Tromey  <tom@tromey.com>
1616
1617         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
1618         (struct aarch64_call_info): Add initializers.
1619         <si>: Now a std::vector.
1620         (pass_on_stack, aarch64_push_dummy_call): Update.
1621
1622 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
1623             Tom Tromey  <tom@tromey.com>
1624
1625         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
1626         (ppc_threads): Now a std::vector.  Now static.
1627         (hwdebug_find_thread_points_by_tid)
1628         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
1629         Update.
1630
1631 2019-05-04  Tom Tromey  <tom@tromey.com>
1632
1633         * arc-tdep.c (arc_tdesc_init): Return bool.
1634
1635 2019-05-04  Tom Tromey  <tom@tromey.com>
1636
1637         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
1638         Use gdb_assert_not_reached.
1639
1640 2019-05-04  Tom Tromey  <tom@tromey.com>
1641
1642         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
1643         "false".
1644
1645 2019-05-04  Tom Tromey  <tom@tromey.com>
1646
1647         * arc-tdep.c (arc_tdesc_init): Use bool.
1648
1649 2019-05-04  Tom Tromey  <tom@tromey.com>
1650
1651         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
1652
1653 2019-05-04  Tom Tromey  <tom@tromey.com>
1654
1655         * cli/cli-cmds.c (valid_command_p): Return bool.
1656
1657 2019-05-04  Tom Tromey  <tom@tromey.com>
1658
1659         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
1660         * command.h (valid_user_defined_cmd_name_p): Channge return type.
1661
1662 2019-05-04  Raul Tambre  <raul@tambre.ee>
1663
1664         * python/lib/gdb/prompt.py (_ExtendedPrompt)
1665         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
1666         operator for comparison.
1667
1668 2019-05-04  Tom Tromey  <tom@tromey.com>
1669
1670         * psymtab.c (psymbol_name_matches, match_partial_symbol)
1671         (lookup_partial_symbol, print_partial_symbols)
1672         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
1673         (psymbol_compare): Update.
1674         (add_psymbol_to_bcache): Clear the entire psymbol.
1675         (maintenance_check_psymtabs): Update.
1676         * psympriv.h (struct partial_symbol): Don't derive from
1677         general_symbol_info.
1678         <obj_section, unrelocated_address, address,
1679         set_unrelocated_address>: Update.
1680         <ginfo>: New member.
1681         * dwarf-index-write.c (write_psymbols, debug_names::insert)
1682         (debug_names::write_psymbols): Update.
1683
1684 2019-05-04  Tom de Vries  <tdevries@suse.de>
1685
1686         * contrib/cc-with-tweaks.sh: Support -n arg.
1687
1688 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1689
1690         * corelow.c (core_target::detach): Ensure frame cache and
1691         register caches are cleared.
1692         inferior.c (exit_inferior_1): Likewise.
1693
1694 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
1695             Tom Tromey  <tom@tromey.com>
1696
1697         * dictionary.c (collate_pending_symbols_by_language): Remove
1698         "struct" from foreach.
1699         * symtab.c (lookup_global_symbol_from_objfile)
1700         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
1701         foreach.
1702         * ser-tcp.c (net_open): Remove "struct" from foreach.
1703         * objfiles.c (objfile_relocate, objfile_rebase)
1704         (objfile_has_symbols): Remove "struct" from foreach.
1705         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
1706         from foreach.
1707         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
1708         foreach.
1709         * darwin-nat.c (thread_info_from_private_thread_info): Remove
1710         "struct" from foreach.
1711         * ada-lang.c (create_excep_cond_exprs)
1712         (ada_exception_catchpoint_cond_string): Remove "struct" from
1713         foreach.
1714
1715 2019-05-03  Tom Tromey  <tromey@adacore.com>
1716
1717         * ada-exp.y (convert_char_literal): Check suffix of each
1718         enumerator.
1719
1720 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
1721
1722         PR ada/21406:
1723         * ada-exp.y (yywrap): Don't define.
1724         * ada-lex.l (%option): Add noyywrap
1725         (yywrap): Remove.
1726
1727 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
1728
1729         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
1730         _WIN32_WINNT to the XP level, unless already defined to a higher
1731         level.
1732
1733         * unittests/parse-connection-spec-selftests.c:
1734         * ser-tcp.c:
1735         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
1736         override.
1737
1738         * symfile.c (find_separate_debug_file): Remove colon from the
1739         drive spec of DOS/Windows file names of the target, so that the
1740         file name produced from DEBUGDIR and the target's directory will
1741         be valid on DOS/Windows systems.
1742
1743 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1744
1745         * rust-lang.c (val_print_struct): Handle printing structures
1746         containing strings.
1747
1748 2019-05-02  Tom Tromey  <tromey@adacore.com>
1749
1750         * valarith.c (_initialize_valarith): Remove.
1751
1752 2019-05-01  Tom Tromey  <tromey@adacore.com>
1753
1754         * ada-lang.c (ada_value_primitive_field): Treat more fields as
1755         bitfields.
1756
1757 2019-05-01  Tom Tromey  <tromey@adacore.com>
1758
1759         * ada-lang.c (ada_value_assign): Correctly compute starting offset
1760         for big-endian copies.
1761
1762 2019-04-30  Ali Tamur  <tamur@google.com>
1763         * gdb/dwarf2read.c (read_3_bytes): New declaration.
1764         (read_attribute_value): Added DW_FORM_strx1-4 cases.
1765         (read_3_bytes): New function.
1766
1767 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1768
1769         * windows-nat.c (main_thread_id): Delete.
1770         (handle_output_debug_string): Replace main_thread_id by
1771         current_event.dwThreadId.
1772         (fake_create_process): Likewise.
1773         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
1774         Do not set main_thread_id.
1775         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
1776         current_event.dwThreadId.
1777         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
1778
1779 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
1780
1781         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
1782         Use current_event.dwThreadId instead of main_thread_id.
1783
1784 2019-04-30  Tom Tromey  <tromey@adacore.com>
1785
1786         * ada-lang.c (ada_lookup_simple_minsyms): New function.
1787         (create_excep_cond_exprs): Iterate over program spaces.
1788         (ada_exception_catchpoint_cond_string): Examine all minimal
1789         symbols for exception types.
1790
1791 2019-04-30  Tom Tromey  <tromey@adacore.com>
1792
1793         PR c++/24470:
1794         * dwarf2read.c (process_structure_scope): Handle case where type
1795         has template parameters but no symbol was created.
1796
1797 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1798             Chris January  <chris.january@arm.com>
1799
1800         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
1801         qualifier.
1802         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
1803
1804 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1805
1806         * f-typeprint.c (f_print_type): Update rules for printing
1807         whitespace.
1808         (f_type_print_varspec_suffix): Likewise.
1809
1810 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1811             Chris January  <chris.january@arm.com>
1812
1813         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
1814         function arguments.
1815
1816 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1817
1818         * f-lang.c (build_fortran_types): Change name of void type to
1819         lower case.
1820         * f-typeprint.c (f_type_print_base): Print the name of the void
1821         type, rather than a fixed string.
1822         * f-valprint.c (f_decorations): Use lower case void string.
1823
1824 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1825             Chris January  <chris.january@arm.com>
1826
1827         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
1828         types for Fortran.
1829
1830 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1831             Chris January  <chris.january@arm.com>
1832             David Lecomber  <david.lecomber@arm.com>
1833
1834         * f-exp.y (BINOP_INTRINSIC): New token.
1835         (exp): New parser rule handling BINOP_INTRINSIC.
1836         (f77_keywords): Add new builtin procedures.
1837         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
1838         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1839         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
1840         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1841         (print_unop_subexp_f): New function.
1842         (print_binop_subexp_f): New function.
1843         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1844         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
1845         (dump_subexp_body_f): Likewise.
1846         (operator_check_f): Likewise.
1847         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
1848         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
1849
1850 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1851
1852         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
1853         UNOP_KIND.
1854         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
1855         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
1856         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
1857         (operator_length_f): New fuction.
1858         (print_subexp_f): New function.
1859         (op_name_f): New function.
1860         (dump_subexp_body_f): New function.
1861         (operator_check_f): New function.
1862         (exp_descriptor_f): Replace standard expression handling functions
1863         with new functions.
1864         * gdb/fortran-operator.def: New file.
1865         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
1866         * gdb/std-operator.def: Remove UNOP_KIND.
1867
1868 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
1869
1870         * std-operator.def: Remove unbalanced, stray double quote
1871         character.
1872
1873 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1874             Chris January  <chris.january@arm.com>
1875             Daniel Everett  <daniel.everett@arm.com>
1876             Nick Forrington  <nick.forrington@arm.com>
1877             Richard Bunt  <richard.bunt@arm.com>
1878
1879         * cp-valprint.c (cp_print_value_fields): Allow an additional level
1880         of depth when printing anonymous structs or unions.
1881         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
1882         Don't print either the top-level value, or the children if the
1883         max-depth is exceeded.
1884         (ppscm_print_children): When printing the key of a map, allow one
1885         extra level of depth.
1886         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
1887         print either the top-level value, or the children if the max-depth
1888         is exceeded.
1889         (print_children): When printing the key of a map, allow one extra
1890         level of depth.
1891         * python/py-value.c (valpy_format_string): Add max_depth keyword.
1892         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
1893         (user_print_options): Initialise max_depth field.
1894         (val_print_scalar_or_string_type_p): New function.
1895         (val_print): Check to see if the max depth has been reached.
1896         (val_print_check_max_depth): Define new function.
1897         (show_print_max_depth): New function.
1898         (_initialize_valprint): Add 'print max-depth' option.
1899         * valprint.h (struct value_print_options) <max_depth>: New field.
1900         (val_print_check_max_depth): Declare new function.
1901         * NEWS: Document new feature.
1902
1903 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1904
1905         * ada-lang.c (ada_language_defn): Initialise new field.
1906         * c-lang.c (c_is_string_type_p): New function.
1907         (c_language_defn): Initialise new field.
1908         (cplus_language_defn): Initialise new field.
1909         (asm_language_defn): Initialise new field.
1910         (minimal_language_defn): Initialise new field.
1911         * c-lang.h (c_is_string_type_p): Declare new function.
1912         * d-lang.c (d_language_defn): Initialise new field.
1913         * f-lang.c (f_is_string_type_p): New function.
1914         (f_language_defn): Initialise new field.
1915         * go-lang.c (go_is_string_type_p): New function.
1916         (go_language_defn): Initialise new field.
1917         * language.c (default_is_string_type_p): New function.
1918         (unknown_language_defn): Initialise new field.
1919         (auto_language_defn): Initialise new field.
1920         * language.h (struct language_defn) <la_is_string_type_p>: New
1921         member variable.
1922         (default_is_string_type_p): Declare new function.
1923         * m2-lang.c (m2_language_defn): Initialise new field.
1924         * objc-lang.c (objc_language_defn): Initialise new field.
1925         * opencl-lang.c (opencl_language_defn): Initialise new field.
1926         * p-lang.c (pascal_is_string_type_p): New function.
1927         (pascal_language_defn): Initialise new field.
1928         * rust-lang.c (rust_is_string_type_p): New function.
1929         (rust_language_defn): Initialise new field.
1930
1931 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1932
1933         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
1934         New field.
1935         * ada-lang.c (ada_language_defn): Initialise new field.
1936         * c-lang.c (c_language_defn): Likewise.
1937         (cplus_language_defn): Likewise.
1938         (asm_language_defn): Likewise.
1939         (minimal_language_defn): Likewise.
1940         * d-lang.c (d_language_defn): Likewise.
1941         * f-lang.c (f_language_defn): Likewise.
1942         * go-lang.c (go_language_defn): Likewise.
1943         * language.c (unknown_language_defn): Likewise.
1944         (auto_language_defn): Likewise.
1945         * m2-lang.c (m2_language_defn): Likewise.
1946         * objc-lang.c (objc_language_defn): Likewise.
1947         * opencl-lang.c (opencl_language_defn): Likewise.
1948         * p-lang.c (pascal_language_defn): Likewise.
1949         * rust-lang.c (rust_language_defn): Likewise.
1950
1951 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
1952
1953         * ada-lang.c (ada_is_character_type): Change return type to bool.
1954         (ada_is_string_type): Likewise.
1955         * ada-lang.h (ada_is_character_type): Update declaration
1956         (ada_is_string_type): Likewise.
1957
1958 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1959
1960         Support style in 'frame|thread apply'
1961
1962         * gdbcmd.h (execute_command_to_string): New term_out parameter.
1963         * record.c (record_start, record_stop): Update callers of
1964         execute_command_to_string with false.
1965         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
1966         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
1967         methods.
1968         (class string_file): New constructor with term_out parameter.
1969         Override methods term_out and can_emit_style_escape.  New member
1970         term_out.
1971         (class stdio_file): Override can_emit_style_escape.
1972         (class tee_file): Override term_out and can_emit_style_escape.
1973         * utils.h (can_emit_style_escape): Remove.
1974         * utils.c (can_emit_style_escape): Likewise.
1975         Update all callers of can_emit_style_escape (SOMESTREAM) to
1976         SOMESTREAM->can_emit_style_escape.
1977         * source-cache.c (source_cache::get_source_lines): Likewise.
1978         * stack.c (frame_apply_command_count): Call execute_command_to_string
1979         passing the term_out characteristic of the current gdb_stdout.
1980         * thread.c (thr_try_catch_cmd): Likewise.
1981         * top.c (execute_command_to_string): pass term_out parameter
1982         to construct the string_file for the command output.
1983         * ui-file.c (term_cli_styling): New function (most code moved
1984         from utils.c can_emit_style_escape).
1985         (string_file::string_file, string_file::can_emit_style_escape,
1986         stdio_file::can_emit_style_escape, tee_file::term_out,
1987         tee_file::can_emit_style_escape): New functions.
1988
1989 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1990
1991         * NEWS: Mention the new set|show may-call-functions.
1992         * infcall.c (may_call_functions_p): New variable.
1993         (show_may_call_functions_p): New function.
1994         (call_function_by_hand_dummy): Throws an error if not
1995         may-call-functions.
1996         (_initialize_infcall): Call add_setshow_boolean_cmd for
1997         may-call-functions.
1998
1999 2019-04-25  Keith Seitz  <keiths@redhat.com>
2000
2001         PR c++/24367
2002         * cp-support.c (inspect_type): Don't attempt substitutions
2003         of symbol with the same name.
2004
2005 2019-04-25  Tom Tromey  <tromey@adacore.com>
2006
2007         PR gdb/24475:
2008         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
2009         static.
2010
2011 2019-04-25  Tom Tromey  <tromey@adacore.com>
2012
2013         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
2014         rvalue reference.
2015         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
2016         (gdb_xml_parser::parse): Use std::move.
2017         * python/python-internal.h (gdbpy_convert_exception): Take a const
2018         reference.
2019         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
2020         std::move.
2021         * python/py-utils.c (gdbpy_convert_exception): Take a const
2022         reference.
2023         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2024         Use std::move.
2025         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2026         Use std::move.
2027         * mi/mi-main.c (mi_print_exception): Take a const reference.
2028         * main.c (handle_command_errors): Take a const reference.
2029         * linespec.c (parse_linespec): Use std::move.
2030         * infcall.c (run_inferior_call): Use std::move.
2031         (call_function_by_hand_dummy): Use std::move.
2032         * exec.c (try_open_exec_file): Use std::move.
2033         * exceptions.h (exception_print, exception_fprintf)
2034         (exception_print_same): Update.
2035         * exceptions.c (print_exception, exception_print)
2036         (exception_fprintf, exception_print_same): Change parameters to
2037         const reference.
2038         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
2039         * common/new-op.c: Use std::move.
2040         * common/common-exceptions.h (struct gdb_exception): Add move
2041         constructor.
2042         (struct gdb_exception_error, struct gdb_exception_quit, struct
2043         gdb_quit_bad_alloc): Change constructor to move constructor.
2044         (throw_exception): Change parameter to rvalue reference.
2045         * common/common-exceptions.c (throw_exception): Take rvalue
2046         reference.
2047         * cli/cli-interp.c (safe_execute_command): Use std::move.
2048         * breakpoint.c (insert_bp_location, location_to_sals): Use
2049         std::move.
2050
2051 2019-04-25  Tom Tromey  <tromey@adacore.com>
2052
2053         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
2054         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
2055         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
2056         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
2057         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
2058         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
2059         guile/scm-value.c: Use unpack.
2060         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
2061         gdbscm_gdb_exception.
2062         (gdbscm_throw_gdb_exception): Likewise.
2063         (struct gdbscm_gdb_exception): New.
2064         (unpack): New function.
2065         (gdbscm_wrap): Use unpack.
2066
2067 2019-04-25  Tom Tromey  <tromey@adacore.com>
2068
2069         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2070         (gdb_rl_callback_handler): Use std::move.
2071         * common/common-exceptions.h (struct gdb_exception): Add move
2072         assignment operator.
2073         (throw_exception_sjlj): Change "exception" to const reference.
2074         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
2075         (throw_exception_sjlj): Change "exception" to const reference.
2076
2077 2019-04-25  Tom Tromey  <tromey@adacore.com>
2078
2079         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
2080         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
2081         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
2082         Update.
2083         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
2084         Update.
2085         * mi/mi-interp.c (mi_interp::exec): Update.
2086         * linespec.c (parse_linespec): Update.
2087         * infcall.c (run_inferior_call): Update.
2088         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
2089         * guile/scm-symbol.c (gdbscm_lookup_symbol)
2090         (gdbscm_lookup_global_symbol): Update.
2091         * guile/scm-param.c (gdbscm_parameter_value): Update.
2092         * guile/scm-frame.c (gdbscm_frame_read_register)
2093         (gdbscm_frame_read_var): Update.
2094         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
2095         * exec.c (try_open_exec_file): Update.
2096         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
2097         (gdb_rl_callback_handler): Update.
2098         * common/common-exceptions.h (exception_none): Don't declare.
2099         * common/common-exceptions.c (exception_none): Don't define.
2100         (struct catcher) <exception>: Update.
2101         * cli/cli-interp.c (safe_execute_command): Update.
2102         * breakpoint.c (insert_bp_location, location_to_sals): Update.
2103
2104 2019-04-25  Ali Tamur  <tamur@google.com>
2105
2106         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
2107         (read_attribute_value): Likewise.
2108         (dwarf2_read_addr_index): Update comment.
2109         (read_str_index): Add DW_FORM_strx.
2110         (dwarf2_string_attr): Likewise.
2111         (dwarf2_const_value_attr): Likewise.
2112         (dump_die_shallow): Likewise.
2113         (dwarf2_fetch_constant_bytes): Likewise.
2114         (skip_form_bytes): Likewise.
2115         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
2116
2117 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
2118
2119         PR corefiles/11608
2120         PR corefiles/18187
2121         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
2122         OFFSET.  Verify if current mapping contains an ELF header.
2123         (linux_find_memory_regions_full): Adjust call to
2124         dump_mapping_p.
2125
2126 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
2127             Kang Li <kanglictf@gmail.com>
2128
2129         PR gdb/21600
2130
2131         * dwarf2-frame.c (read_initial_length): Be consistent about using
2132         unsigned representation of length.
2133         (decode_frame_entry_1): Likewise.  Check for wraparound of
2134         end pointer as well as buffer overflow.
2135
2136 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
2137
2138         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
2139         "vq".
2140
2141 2019-04-24  Tom Tromey  <tromey@adacore.com>
2142
2143         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
2144
2145 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2146
2147         * s12z-tdep.c (s12z_unwind_pc): Delete.
2148         (s12z_unwind_sp): Delete.
2149         (s12z_gdbarch_init): Don't register deleted functions with
2150         gdbarch.
2151
2152 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2153
2154         * rl78-tdep.c (rl78_unwind_sp): Delete.
2155         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
2156
2157 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2158
2159         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
2160         (xstormy16_unwind_pc): Delete.
2161         (xstormy16_dummy_id): Delete.
2162         (xstormy16_gdbarch_init): Don't register deleted functions with
2163         gdbarch.
2164
2165 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2166
2167         * vax-tdep.c (vax_unwind_pc): Delete.
2168         (vax_gdbarch_init): Don't register deleted function with gdbarch.
2169
2170 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2171
2172         * v850-tdep.c (v850_unwind_sp): Delete.
2173         (v850_unwind_pc): Delete.
2174         (v850_dummy_id): Delete.
2175         (v850_gdbarch_init): Don't register deleted functions with
2176         gdbarch.
2177
2178 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2179
2180         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
2181         (tilegx_unwind_pc): Delete.
2182         (tilegx_unwind_dummy_id): Delete.
2183         (tilegx_gdbarch_init): Don't register deleted functions with
2184         gdbarch.
2185
2186 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2187
2188         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
2189         (tic6x_dummy_id): Delete.
2190         (tic6x_gdbarch_init): Don't register deleted functions with
2191         gdbarch.
2192
2193 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2194
2195         * sparc-tdep.c (sparc_unwind_pc): Delete.
2196         (sparc32_gdbarch_init): Don't register deleted function with
2197         gdbarch.
2198
2199 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2200
2201         * sh-tdep.c (sh_unwind_sp): Delete.
2202         (sh_unwind_pc): Delete.
2203         (sh_dummy_id): Delete.
2204         (sh_gdbarch_init): Don't register deleted functions with
2205         gdbarch.
2206
2207 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2208
2209         * score-tdep.c (score_unwind_sp): Delete.
2210         (score_unwind_pc): Delete.
2211         (score_dummy_id): Delete.
2212         (score_gdbarch_init): Don't register deleted functions with
2213         gdbarch.
2214
2215 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2216
2217         * rx-tdep.c (rx_unwind_pc): Delete.
2218         (rx_unwind_sp): Delete.
2219         (rx_dummy_id): Delete.
2220         (rx_gdbarch_init): Don't register deleted functions with
2221         gdbarch.  Update comment.
2222
2223 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2224
2225         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
2226         (rs6000_dummy_id): Delete.
2227         (rs6000_gdbarch_init): Don't register deleted functions with
2228         gdbarch.
2229
2230 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2231
2232         * or1k-tdep.c (or1k_dummy_id): Delete.
2233         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
2234
2235 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2236
2237         * nios2-tdep.c (nios2_dummy_id): Delete.
2238         (nios2_unwind_sp): Delete.
2239         (nios2_gdbarch_init): Don't register deleted functions with
2240         gdbarch.
2241
2242 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2243
2244         * nds32-tdep.c (nds32_dummy_id): Delete.
2245         (nds32_unwind_pc): Delete.
2246         (nds32_unwind_sp): Delete.
2247         (nds32_gdbarch_init): Don't register deleted functions with
2248         gdbarch.
2249
2250 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2251
2252         * msp430-tdep.c (msp430_unwind_pc): Delete.
2253         (msp430_unwind_sp): Delete.
2254         (msp430_dummy_id): Delete.
2255         (msp430_gdbarch_init): Don't register deleted functions with
2256         gdbarch.
2257
2258 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2259
2260         * moxie-tdep.c (moxie_unwind_sp): Delete.
2261         (moxie_unwind_pc): Delete.
2262         (moxie_dummy_id): Delete.
2263         (moxie_gdbarch_init): Don't register deleted functions with
2264         gdbarch.
2265
2266 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2267
2268         * mn10300-tdep.c (mn10300_dummy_id): Delete.
2269         (mn10300_unwind_pc): Delete.
2270         (mn10300_unwind_sp): Delete.
2271         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
2272         mn10300_unwind_sp.
2273         (mn10300_frame_unwind_init): Don't register deleted functions with
2274         gdbarch.
2275
2276 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2277
2278         * mep-tdep.c (mep_unwind_pc): Delete.
2279         (mep_unwind_sp): Delete.
2280         (mep_dummy_id): Delete.
2281         (mep_gdbarch_init): Don't register deleted functions with
2282         gdbarch.
2283
2284 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2285
2286         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
2287         (m68hc11_unwind_sp): Delete.
2288         (m68hc11_gdbarch_init): Don't register deleted functions with
2289         gdbarch.
2290
2291 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2292
2293         * m32r-tdep.c (m32r_unwind_sp): Delete.
2294         (m32r_unwind_pc): Delete.
2295         (m32r_dummy_id): Delete.
2296         (m32r_gdbarch_init): Don't register deleted functions with
2297         gdbarch.
2298
2299 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2300
2301         * m32c-tdep.c (m32c_unwind_pc): Delete.
2302         (m32c_unwind_sp): Delete.
2303         (m32c_dummy_id): Delete.
2304         (m32c_gdbarch_init): Don't register deleted functions with
2305         gdbarch.
2306
2307 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2308
2309         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
2310         (lm32_unwind_pc): Delete.
2311         (lm32_dummy_id): Delete.
2312         (lm32_gdbarch_init): Don't register deleted functions with
2313         gdbarch.
2314
2315 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
2318         (iq2000_unwind_pc): Delete.
2319         (iq2000_dummy_id): Delete.
2320         (iq2000_gdbarch_init): Don't register deleted functions with
2321         gdbarch.
2322
2323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2324
2325         * nds32-tdep.c (nds32_type_align): Delete.
2326         (nds32_push_dummy_call): Use type_align instead.
2327
2328 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2329
2330         * arm-tdep.c (arm_type_align): Only handle vector override case.
2331         (arm_push_dummy_call): Use type_align.
2332         (arm_gdbarch_init): Register arm_type_align gdbarch function.
2333
2334 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
2335
2336         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
2337         case.
2338         (pass_on_stack): Use type_align.
2339         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
2340         function.
2341
2342 2019-04-23  Tom Tromey  <tromey@adacore.com>
2343
2344         * dwarf2read.c (line_header::file_name_at): Remove unused
2345         overload.
2346
2347 2019-04-23  Tom de Vries  <tdevries@suse.de>
2348
2349         PR gdb/24438
2350         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
2351         invocation.
2352
2353
2354 2019-03-27  Ali Tamur  <tamur@google.com>
2355
2356         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
2357         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
2358         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
2359         (dwarf_expr_context::get_addr_index): Likewise
2360         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
2361         (symbol_needs_eval_context::get_addr_index): Likewise
2362         (disassemble_dwarf_expression): Add DW_OP_addrx
2363         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
2364         (read_cutu_die_from_dwo): Update comment
2365         (skip_one_die): Add DW_FORM_addrx
2366         (read_attribute_value): Likewise
2367         (var_decode_location): Add DW_OP_addrx
2368         (dwarf2_const_value_attr): Add DW_FORM_addrx
2369         (dump_die_shallow): Likewise
2370         (dwarf2_fetch_constant_bytes): Likewise
2371         (decode_locdesc): Add DW_OP_addrx
2372         (skip_form_bytes): Add DW_FORM_addrx
2373
2374 2019-04-22  Ali Tamur  <tamur@google.com>
2375
2376         * MAINTAINERS (Write After Approval): Add self.
2377
2378 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
2379
2380         * solib-svr4.c (get_svr4_info): Add pspace parameter.
2381         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
2382         (open_symbol_file_object): Likewise.
2383         (svr4_default_sos): Add info parameter.
2384         (svr4_read_so_list): Likewise.
2385         (svr4_current_sos_direct): Adjust functions calls to pass down
2386         info.
2387         (svr4_current_sos_1): Add info parameter.
2388         (svr4_current_sos): Call get_svr4_info, pass info down to
2389         svr4_current_sos_1.
2390         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
2391         get_svr4_info.
2392         (svr4_in_dynsym_resolve_code): Pass current_program_space to
2393         get_svr4_info.
2394         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
2395         to get_svr4_info.
2396         (probes_table_remove_objfile_probes): Likewise.
2397         (register_solib_event_probe): Add info parameter.
2398         (solist_update_incremental): Pass info parameter down to
2399         svr4_read_so_list.
2400         (disable_probes_interface): Add info parameter.
2401         (svr4_handle_solib_event): Pass current_program_space to
2402         get_svr4_info.  Adjust disable_probes_interface cleanup.
2403         (svr4_create_probe_breakpoints): Add info parameter, pass it
2404         down to register_solib_event_probe.
2405         (svr4_create_solib_event_breakpoints): Add info parameter,
2406         pass it down to svr4_create_probe_breakpoints.
2407         (enable_break): Pass info down to
2408         svr4_create_solib_event_breakpoints.
2409         (svr4_solib_create_inferior_hook): Pass current_program_space to
2410         get_svr4_info.
2411         (svr4_clear_solib): Likewise.
2412
2413 2019-04-22  Pedro Alves  <palves@redhat.com>
2414
2415         * solib-svr4.c (svr4_free_objfile_observer): New.
2416         (probe_and_action::objfile): New field.
2417         (probes_table_htab_remove_objfile_probes)
2418         (probes_table_remove_objfile_probes): New functions.
2419         (register_solib_event_probe): Add 'objfile' parameter.  Store it
2420         in the new probe_and_action.  Don't store the probe in 'lookup'.
2421         (svr4_create_probe_breakpoints): Pass objfile to
2422         register_solib_event_probe.
2423         (_initialize_svr4_solib): Register a free_objfile observer.
2424
2425 2019-04-19  Tom Tromey  <tom@tromey.com>
2426
2427         * common/queue.h: Remove.
2428
2429 2019-04-19  Tom Tromey  <tom@tromey.com>
2430
2431         * event-loop.c: Don't include "common/queue.h".
2432
2433 2019-04-19  Tom Tromey  <tom@tromey.com>
2434
2435         * remote.c (remote_target): Use delete.
2436         * remote-notif.h: Include <list>, not "common/queue.h".
2437         (notif_client_p): Remove typedef.
2438         (remote_notif_state): Add constructor, destructor, initializer.
2439         <notif_queue>: Now a std::list.
2440         (remote_notif_state_xfree): Don't declare.
2441         * remote-notif.c (remote_notif_process, handle_notification)
2442         (remote_notif_state_allocate): Update.
2443         (~remote_notif_state): Rename from remote_notif_state_xfree.
2444
2445 2019-04-19  Tom Tromey  <tom@tromey.com>
2446
2447         * symfile.c (reread_symbols): Update.
2448         * objfiles.c (objfile_register_static_link)
2449         (objfile_lookup_static_link): Update
2450         (~objfile) Don't delete static_links.
2451         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
2452
2453 2019-04-19  Tom Tromey  <tom@tromey.com>
2454
2455         * type-stack.h (struct type_stack) <insert>: Constify string.
2456         * type-stack.c (type_stack::insert): Constify string.
2457         * gdbtypes.h (lookup_template_type): Update.
2458         (address_space_name_to_int): Update.
2459         * gdbtypes.c (address_space_name_to_int): Make space_identifier
2460         const.
2461         (lookup_template_type): Make name const.
2462         * c-exp.y: Update rules.
2463         (lex_one_token, classify_name, classify_inner_name)
2464         (c_print_token): Update.
2465         * p-exp.y: Update rules.
2466         (yylex): Update.
2467         * f-exp.y: Update rules.
2468         (yylex): Update.
2469         * d-exp.y: Update rules.
2470         (lex_one_token, classify_name, classify_inner_name): Update.
2471         * parse.c (write_dollar_variable, copy_name): Return std::string.
2472         * parser-defs.h (copy_name): Change return type.
2473         * m2-exp.y: Update rules.
2474         (yylex): Update.
2475         * go-exp.y (lex_one_token): Update.
2476         Update rules.
2477         (classify_unsafe_function, classify_packaged_name)
2478         (classify_name, yylex): Update.
2479
2480 2019-04-19  Sergei Trofimovich <siarheit@google.com>
2481
2482         * configure.ac: add --enable-source-highlight switch.
2483         * configure: Regenerate.
2484         * top.c (print_gdb_version): plumb --enable-source-highlight
2485         status to "show configuration".
2486
2487 2019-04-19  Tom Tromey  <tromey@adacore.com>
2488
2489         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
2490         Check ADA_TYPE_P.
2491         (empty_record, ada_template_to_fixed_record_type_1)
2492         (template_to_static_fixed_type)
2493         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
2494         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
2495         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
2496         macros.
2497
2498 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
2499
2500         PR symtab/24423:
2501         * source.c (print_source_lines_base): Advance "iter" when a
2502         control character is seen.
2503
2504 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2505
2506         * inferior.h (struct infcall_suspend_state_deleter):
2507         Catch exception in destructor to avoid crash.
2508
2509 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2510
2511         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
2512         close to the add_com "shell".
2513
2514 2019-04-18  Tom Tromey  <tromey@adacore.com>
2515
2516         * process-stratum-target.h (class process_stratum_target)
2517         <stratum>: Add "final".
2518
2519 2019-04-17  Tom Tromey  <tromey@adacore.com>
2520
2521         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
2522         against nullptr before use.
2523
2524 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
2525
2526         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
2527
2528 2019-04-17  Jim Wilson  <jimw@sifive.com>
2529             Andrew Burgess  <andrew.burgess@embecosm.com>
2530
2531         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
2532         code read might fail, assume 4-byte breakpoint in that case.
2533
2534 2019-04-15  Leszek Swirski  <leszeks@google.com>
2535
2536         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
2537         rather than a hand-rolled POD check when checking for forced MEMORY
2538         classification.
2539
2540 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2541
2542         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
2543         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
2544         function.
2545         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
2546         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
2547         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
2548         declaration.
2549
2550 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2551
2552         * aarch64-linux-nat.c
2553         (aarch64_linux_nat_target::thread_architecture): Add override.
2554         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
2555         each VQ.
2556
2557 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
2558
2559         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
2560
2561 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
2562
2563         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
2564         target types of size 96-bits, add some additional comments, and
2565         check that the builtin type we found was the correct size.
2566
2567 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
2568
2569         * utils.c (prompt_for_continue): Don't restore the styling at the
2570         end, as applied_style has the wrong value.  This fixes styling in
2571         long lists of file names that are interrupted by the "Continue?"
2572         prompt.
2573
2574 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2575
2576         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
2577         * c-lang.c (c_language_defn): Likewise.
2578         (cplus_language_defn): Likewise.
2579         (asm_language_defn): Likewise.
2580         (minimal_language_defn): Likewise.
2581         * d-lang.c (d_language_defn): Likewise.
2582         * f-lang.c (f_language_defn): Likewise.
2583         * go-lang.c (go_language_defn): Likewise.
2584         * language.c (unknown_language_defn): Likewise.
2585         (auto_language_defn): Likewise.
2586         * language.h (struct language_defn): Remove la_magic field.
2587         (LANG_MAGIC): Delete.
2588         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
2589         * objc-lang.c (objc_language_defn): Likewise.
2590         * opencl-lang.c (opencl_language_defn): Likewise.
2591         * p-lang.c (pascal_language_defn): Likewise.
2592         * rust-lang.c (rust_language_defn): Likewise.
2593
2594 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2595
2596         * riscv-tdep.c (riscv_type_align): New function.
2597         (riscv_type_alignment): Delete.
2598         (riscv_arg_location): Use 'type_align'.
2599         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
2600
2601 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2602
2603         * gdbtypes.c (type_align): A struct with no non-static fields also
2604         has alignment of 1.
2605
2606 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
2607
2608         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
2609         component to 0.
2610         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
2611         member.
2612         (riscv_struct_info::analyse): New implementation using new
2613         analyse_inner member function.
2614         (riscv_struct_info::field_offset): New member function.
2615         (riscv_struct_info::m_offsets): New member variable.
2616         (riscv_struct_info::analyse_inner): New private member function,
2617         takes the old implementation of riscv_struct_info::analyse but
2618         extended to track field offsets.
2619         (riscv_call_arg_struct): Update the struct folding special cases
2620         to handle cases where empty C++ structs, which are non-zero
2621         length, are found.
2622         (riscv_arg_location): Initialise the length of each location, a
2623         non-zero length now indicates the location is in use.
2624         (riscv_push_dummy_call): Allow for the first location having a
2625         non-zero offset when setting up arguments.
2626         (riscv_return_value): Likewise, but for return values.
2627
2628 2019-04-11  Tom Tromey  <tromey@adacore.com>
2629
2630         * utils.c (internal_vproblem): Make "msg" const.
2631
2632 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
2633
2634         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
2635         * trad-frame.c (trad_frame_reset_saved_regs): New function.
2636         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
2637         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
2638
2639 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
2640
2641         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
2642         function.
2643         (fill_gregset): Call amd64_linux_collect_native_gregset instead
2644         of amd64_collect_native_gregset.
2645         (amd64_linux_nat_target::store_registers): Likewise.
2646
2647 2019-04-10  Tom Tromey  <tom@tromey.com>
2648
2649         * symtab.c (lookup_global_symbol_from_objfile)
2650         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
2651         * objfiles.h (class separate_debug_iterator): New.
2652         (class separate_debug_range): New.
2653         (struct objfile) <separate_debug_objfiles>: New method.
2654         (objfile_separate_debug_iterate): Don't declare.
2655         * objfiles.c (separate_debug_iterator::operator++): Rename from
2656         objfile_separate_debug_iterate.
2657         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
2658         iterator.
2659         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
2660         iterator.
2661
2662 2019-04-10  Tom Tromey  <tom@tromey.com>
2663
2664         * symfile.c (reread_symbols): Remove old comment.
2665         * objfiles.c (free_all_objfiles): Fix a typo.
2666
2667 2019-04-10  Tom Tromey  <tom@tromey.com>
2668
2669         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
2670         * minsyms.c (lookup_minimal_symbol): Use foreach.
2671         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
2672         (lookup_minimal_symbol_solib_trampoline): Likewise.
2673         * symfile.c (reread_symbols): Use foreach.
2674
2675 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
2676             Tom Tromey  <tromey@adacore.com>
2677
2678         PR rust/24414:
2679         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
2680         (rust_lex_int_test): Change "value" to be LONGEST.
2681         (rust_lex_tests): Add test for long integer literal.
2682
2683 2019-04-09  Tom Tromey  <tromey@adacore.com>
2684
2685         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
2686         to bool.
2687         (extended_remote_target::attach): Update.
2688         (remote_target::remote_notice_new_inferior): Update.
2689         (remote_target::add_current_inferior_and_thread): Update.
2690         * inferior.c (exit_inferior_1): Use "false".
2691         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
2692
2693 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
2694
2695         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
2696         the "start" command.
2697
2698 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2699
2700         * python/py-inferior.c (infpy_thread_from_thread_handle):
2701         Adjust comments to reflect renaming of thread_from_thread_handle
2702         to thread_from_handle.  Adjust keywords.  Fix type error message.
2703         (inferior_object_methods): Add thread_from_handle.  Retain
2704         thread_from_thread_handle, but mark it as deprecated.
2705
2706 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2707
2708         * gdbthread.h (find_thread_by_handle): Revise declaration.
2709         * thread.c (find_thread_by_handle): Likewise.  Adjust
2710         implementation too.
2711         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
2712         support for buffer objects as handles.
2713
2714 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2715
2716         * python/py-infthread.c (thpy_thread_handle): New function.
2717         (thread_object_methods): Register thpy_thread_handle.
2718
2719 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
2720
2721         * gdbthread.h (thread_to_thread_handle): Declare.
2722         * thread.c (gdbtypes.h): Include.
2723         (thread_to_thread_handle): New function.
2724
2725         * target.h (struct target_ops): Add thread_info_to_thread_handle.
2726         (target_thread_info_to_thread_handle): Declare.
2727         * target.c (target_thread_info_to_thread_handle): New function.
2728         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
2729         * target-delegates.c: Regenerate.
2730
2731         * linux-thread-db.c (class thread_db_target): Add method
2732         thread_info_to_thread_handle.
2733         (thread_db_target::thread_info_to_thread_handle): Define.
2734         * remote.c (class remote_target): Add new method
2735         thread_info_to_thread_handle.
2736         (remote_target::thread_info_to_thread_handle): Define.
2737
2738 2019-04-08  Pedro Alves  <palves@redhat.com>
2739
2740         * common/common-exceptions.c (throw_exception): Don't create
2741         named object to throw; throw directly.
2742         (throw_it): Likewise.  Don't initialize gdb_exception::message
2743         here, with new; pass FMT and AP to the ctor instead.
2744         * common/common-exceptions.h: Include <string>.
2745         (gdb_exception::gdb_exception(enum return_reason, enum errors,
2746         const char *, va_list)): New ctor.  Use std::make_shared.
2747         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
2748         errors)): Delete.
2749         (gdb_exception_error::gdb_exception_error(enum errors, const char
2750         *, va_list)): New.
2751         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
2752         Add assertion.
2753         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
2754         errors)): Delete.
2755         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
2756         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
2757         Add assertion.
2758
2759 2019-04-08  Tom Tromey  <tom@tromey.com>
2760
2761         * valops.c (value_rtti_indirect_type): Replace throw_exception
2762         with throw.
2763         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
2764         with throw.
2765         * thread.c (thr_try_catch_cmd): Replace throw_exception with
2766         throw.
2767         * target.c (target_translate_tls_address): Replace throw_exception
2768         with throw.
2769         * stack.c (frame_apply_command_count): Replace throw_exception
2770         with throw.
2771         * solib-spu.c (append_ocl_sos): Replace throw_exception with
2772         throw.
2773         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
2774         with throw.
2775         * rs6000-tdep.c (rs6000_frame_cache)
2776         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
2777         * remote.c: Replace throw_exception with throw.
2778         * record-full.c (record_full_message, record_full_wait_1)
2779         (record_full_restore): Replace throw_exception with throw.
2780         * record-btrace.c:
2781         (get_thread_current_frame_id, record_btrace_start_replaying)
2782         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
2783         (cmd_record_btrace_start): Replace throw_exception with throw.
2784         * parse.c (parse_exp_in_context_1): Replace throw_exception with
2785         throw.
2786         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
2787         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
2788         * linespec.c:
2789         (find_linespec_symbols): Replace throw_exception with throw.
2790         * infrun.c (displaced_step_prepare, resume): Replace
2791         throw_exception with throw.
2792         * infcmd.c (post_create_inferior): Replace throw_exception with
2793         throw.
2794         * inf-loop.c (inferior_event_handler): Replace throw_exception
2795         with throw.
2796         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
2797         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
2798         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
2799         (get_prev_frame_always, get_frame_pc_if_available)
2800         (get_frame_address_in_block_if_available, get_frame_language):
2801         Replace throw_exception with throw.
2802         * frame-unwind.c (frame_unwind_try_unwinder): Replace
2803         throw_exception with throw.
2804         * eval.c (fetch_subexp_value, evaluate_var_value)
2805         (evaluate_funcall, evaluate_subexp_standard): Replace
2806         throw_exception with throw.
2807         * dwarf2loc.c (call_site_find_chain)
2808         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
2809         Replace throw_exception with throw.
2810         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
2811         with throw.
2812         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
2813         throw.
2814         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
2815         * completer.c (complete_line_internal): Replace throw_exception
2816         with throw.
2817         * compile/compile-object-run.c (compile_object_run): Replace
2818         throw_exception with throw.
2819         * cli/cli-script.c (process_next_line): Replace throw_exception
2820         with throw.
2821         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
2822         (btrace_enable, btrace_maint_update_pt_packets): Replace
2823         throw_exception with throw.
2824         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
2825         throw_exception with throw.
2826         * break-catch-throw.c (re_set_exception_catchpoint): Replace
2827         throw_exception with throw.
2828         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
2829         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
2830         * aarch64-tdep.c (aarch64_make_prologue_cache)
2831         (aarch64_make_stub_cache): Replace throw_exception with throw.
2832
2833 2019-04-08  Tom Tromey  <tom@tromey.com>
2834
2835         * common/common-exceptions.c (throw_exception): Rename from
2836         throw_exception_cxx.  Remove old copy.  Make argument const.
2837         (throw_it): Create and throw exception objects directly.
2838         * common/common-exceptions.h (throw_exception): Make argument
2839         const.
2840         (struct gdb_exception_error): Add constructor.
2841         (struct gdb_exception_quit): Add constructor.
2842
2843 2019-04-08  Tom Tromey  <tom@tromey.com>
2844
2845         * common/common-exceptions.h (exception_rethrow): Don't declare.
2846         (TRY_SJLJ): Update comment.
2847         (TRY, CATCH, END_CATCH): Remove.
2848         * common/common-exceptions.c (exception_rethrow): Remove.
2849
2850 2019-04-08  Tom Tromey  <tom@tromey.com>
2851
2852         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
2853         Remove.
2854         (gdb_exception_error): Rename from
2855         gdb_exception_RETURN_MASK_ERROR.
2856         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
2857         (gdb_quit_bad_alloc): Update.
2858         * aarch64-tdep.c: Update.
2859         * ada-lang.c: Update.
2860         * ada-typeprint.c: Update.
2861         * ada-valprint.c: Update.
2862         * amd64-tdep.c: Update.
2863         * arch-utils.c: Update.
2864         * break-catch-throw.c: Update.
2865         * breakpoint.c: Update.
2866         * btrace.c: Update.
2867         * c-varobj.c: Update.
2868         * cli/cli-cmds.c: Update.
2869         * cli/cli-interp.c: Update.
2870         * cli/cli-script.c: Update.
2871         * common/common-exceptions.c: Update.
2872         * common/new-op.c: Update.
2873         * common/selftest.c: Update.
2874         * compile/compile-c-symbols.c: Update.
2875         * compile/compile-cplus-symbols.c: Update.
2876         * compile/compile-object-load.c: Update.
2877         * compile/compile-object-run.c: Update.
2878         * completer.c: Update.
2879         * corelow.c: Update.
2880         * cp-abi.c: Update.
2881         * cp-support.c: Update.
2882         * cp-valprint.c: Update.
2883         * darwin-nat.c: Update.
2884         * disasm-selftests.c: Update.
2885         * dtrace-probe.c: Update.
2886         * dwarf-index-cache.c: Update.
2887         * dwarf-index-write.c: Update.
2888         * dwarf2-frame-tailcall.c: Update.
2889         * dwarf2-frame.c: Update.
2890         * dwarf2loc.c: Update.
2891         * dwarf2read.c: Update.
2892         * eval.c: Update.
2893         * event-loop.c: Update.
2894         * event-top.c: Update.
2895         * exec.c: Update.
2896         * f-valprint.c: Update.
2897         * fbsd-tdep.c: Update.
2898         * frame-unwind.c: Update.
2899         * frame.c: Update.
2900         * gdbtypes.c: Update.
2901         * gnu-v3-abi.c: Update.
2902         * guile/guile-internal.h: Update.
2903         * guile/scm-block.c: Update.
2904         * guile/scm-breakpoint.c: Update.
2905         * guile/scm-cmd.c: Update.
2906         * guile/scm-disasm.c: Update.
2907         * guile/scm-frame.c: Update.
2908         * guile/scm-lazy-string.c: Update.
2909         * guile/scm-math.c: Update.
2910         * guile/scm-param.c: Update.
2911         * guile/scm-ports.c: Update.
2912         * guile/scm-pretty-print.c: Update.
2913         * guile/scm-symbol.c: Update.
2914         * guile/scm-symtab.c: Update.
2915         * guile/scm-type.c: Update.
2916         * guile/scm-value.c: Update.
2917         * i386-linux-tdep.c: Update.
2918         * i386-tdep.c: Update.
2919         * inf-loop.c: Update.
2920         * infcall.c: Update.
2921         * infcmd.c: Update.
2922         * infrun.c: Update.
2923         * jit.c: Update.
2924         * language.c: Update.
2925         * linespec.c: Update.
2926         * linux-fork.c: Update.
2927         * linux-nat.c: Update.
2928         * linux-tdep.c: Update.
2929         * linux-thread-db.c: Update.
2930         * main.c: Update.
2931         * mi/mi-cmd-break.c: Update.
2932         * mi/mi-cmd-stack.c: Update.
2933         * mi/mi-interp.c: Update.
2934         * mi/mi-main.c: Update.
2935         * objc-lang.c: Update.
2936         * p-valprint.c: Update.
2937         * parse.c: Update.
2938         * ppc-linux-tdep.c: Update.
2939         * printcmd.c: Update.
2940         * python/py-arch.c: Update.
2941         * python/py-breakpoint.c: Update.
2942         * python/py-cmd.c: Update.
2943         * python/py-finishbreakpoint.c: Update.
2944         * python/py-frame.c: Update.
2945         * python/py-framefilter.c: Update.
2946         * python/py-gdb-readline.c: Update.
2947         * python/py-inferior.c: Update.
2948         * python/py-infthread.c: Update.
2949         * python/py-lazy-string.c: Update.
2950         * python/py-linetable.c: Update.
2951         * python/py-objfile.c: Update.
2952         * python/py-param.c: Update.
2953         * python/py-prettyprint.c: Update.
2954         * python/py-progspace.c: Update.
2955         * python/py-record-btrace.c: Update.
2956         * python/py-record.c: Update.
2957         * python/py-symbol.c: Update.
2958         * python/py-type.c: Update.
2959         * python/py-unwind.c: Update.
2960         * python/py-utils.c: Update.
2961         * python/py-value.c: Update.
2962         * python/python.c: Update.
2963         * record-btrace.c: Update.
2964         * record-full.c: Update.
2965         * remote-fileio.c: Update.
2966         * remote.c: Update.
2967         * riscv-tdep.c: Update.
2968         * rs6000-aix-tdep.c: Update.
2969         * rs6000-tdep.c: Update.
2970         * rust-exp.y: Update.
2971         * rust-lang.c: Update.
2972         * s390-tdep.c: Update.
2973         * selftest-arch.c: Update.
2974         * solib-dsbt.c: Update.
2975         * solib-frv.c: Update.
2976         * solib-spu.c: Update.
2977         * solib-svr4.c: Update.
2978         * solib.c: Update.
2979         * sparc64-linux-tdep.c: Update.
2980         * stack.c: Update.
2981         * symfile-mem.c: Update.
2982         * symmisc.c: Update.
2983         * target.c: Update.
2984         * thread.c: Update.
2985         * top.c: Update.
2986         * tracefile-tfile.c: Update.
2987         * tui/tui.c: Update.
2988         * typeprint.c: Update.
2989         * unittests/cli-utils-selftests.c: Update.
2990         * unittests/parse-connection-spec-selftests.c: Update.
2991         * valops.c: Update.
2992         * valprint.c: Update.
2993         * value.c: Update.
2994         * varobj.c: Update.
2995         * windows-nat.c: Update.
2996         * x86-linux-nat.c: Update.
2997         * xml-support.c: Update.
2998
2999 2019-04-08  Tom Tromey  <tom@tromey.com>
3000
3001         * xml-support.c: Use C++ exception handling.
3002         * x86-linux-nat.c: Use C++ exception handling.
3003         * windows-nat.c: Use C++ exception handling.
3004         * varobj.c: Use C++ exception handling.
3005         * value.c: Use C++ exception handling.
3006         * valprint.c: Use C++ exception handling.
3007         * valops.c: Use C++ exception handling.
3008         * unittests/parse-connection-spec-selftests.c: Use C++ exception
3009         handling.
3010         * unittests/cli-utils-selftests.c: Use C++ exception handling.
3011         * typeprint.c: Use C++ exception handling.
3012         * tui/tui.c: Use C++ exception handling.
3013         * tracefile-tfile.c: Use C++ exception handling.
3014         * top.c: Use C++ exception handling.
3015         * thread.c: Use C++ exception handling.
3016         * target.c: Use C++ exception handling.
3017         * symmisc.c: Use C++ exception handling.
3018         * symfile-mem.c: Use C++ exception handling.
3019         * stack.c: Use C++ exception handling.
3020         * sparc64-linux-tdep.c: Use C++ exception handling.
3021         * solib.c: Use C++ exception handling.
3022         * solib-svr4.c: Use C++ exception handling.
3023         * solib-spu.c: Use C++ exception handling.
3024         * solib-frv.c: Use C++ exception handling.
3025         * solib-dsbt.c: Use C++ exception handling.
3026         * selftest-arch.c: Use C++ exception handling.
3027         * s390-tdep.c: Use C++ exception handling.
3028         * rust-lang.c: Use C++ exception handling.
3029         * rust-exp.y: Use C++ exception handling.
3030         * rs6000-tdep.c: Use C++ exception handling.
3031         * rs6000-aix-tdep.c: Use C++ exception handling.
3032         * riscv-tdep.c: Use C++ exception handling.
3033         * remote.c: Use C++ exception handling.
3034         * remote-fileio.c: Use C++ exception handling.
3035         * record-full.c: Use C++ exception handling.
3036         * record-btrace.c: Use C++ exception handling.
3037         * python/python.c: Use C++ exception handling.
3038         * python/py-value.c: Use C++ exception handling.
3039         * python/py-utils.c: Use C++ exception handling.
3040         * python/py-unwind.c: Use C++ exception handling.
3041         * python/py-type.c: Use C++ exception handling.
3042         * python/py-symbol.c: Use C++ exception handling.
3043         * python/py-record.c: Use C++ exception handling.
3044         * python/py-record-btrace.c: Use C++ exception handling.
3045         * python/py-progspace.c: Use C++ exception handling.
3046         * python/py-prettyprint.c: Use C++ exception handling.
3047         * python/py-param.c: Use C++ exception handling.
3048         * python/py-objfile.c: Use C++ exception handling.
3049         * python/py-linetable.c: Use C++ exception handling.
3050         * python/py-lazy-string.c: Use C++ exception handling.
3051         * python/py-infthread.c: Use C++ exception handling.
3052         * python/py-inferior.c: Use C++ exception handling.
3053         * python/py-gdb-readline.c: Use C++ exception handling.
3054         * python/py-framefilter.c: Use C++ exception handling.
3055         * python/py-frame.c: Use C++ exception handling.
3056         * python/py-finishbreakpoint.c: Use C++ exception handling.
3057         * python/py-cmd.c: Use C++ exception handling.
3058         * python/py-breakpoint.c: Use C++ exception handling.
3059         * python/py-arch.c: Use C++ exception handling.
3060         * printcmd.c: Use C++ exception handling.
3061         * ppc-linux-tdep.c: Use C++ exception handling.
3062         * parse.c: Use C++ exception handling.
3063         * p-valprint.c: Use C++ exception handling.
3064         * objc-lang.c: Use C++ exception handling.
3065         * mi/mi-main.c: Use C++ exception handling.
3066         * mi/mi-interp.c: Use C++ exception handling.
3067         * mi/mi-cmd-stack.c: Use C++ exception handling.
3068         * mi/mi-cmd-break.c: Use C++ exception handling.
3069         * main.c: Use C++ exception handling.
3070         * linux-thread-db.c: Use C++ exception handling.
3071         * linux-tdep.c: Use C++ exception handling.
3072         * linux-nat.c: Use C++ exception handling.
3073         * linux-fork.c: Use C++ exception handling.
3074         * linespec.c: Use C++ exception handling.
3075         * language.c: Use C++ exception handling.
3076         * jit.c: Use C++ exception handling.
3077         * infrun.c: Use C++ exception handling.
3078         * infcmd.c: Use C++ exception handling.
3079         * infcall.c: Use C++ exception handling.
3080         * inf-loop.c: Use C++ exception handling.
3081         * i386-tdep.c: Use C++ exception handling.
3082         * i386-linux-tdep.c: Use C++ exception handling.
3083         * guile/scm-value.c: Use C++ exception handling.
3084         * guile/scm-type.c: Use C++ exception handling.
3085         * guile/scm-symtab.c: Use C++ exception handling.
3086         * guile/scm-symbol.c: Use C++ exception handling.
3087         * guile/scm-pretty-print.c: Use C++ exception handling.
3088         * guile/scm-ports.c: Use C++ exception handling.
3089         * guile/scm-param.c: Use C++ exception handling.
3090         * guile/scm-math.c: Use C++ exception handling.
3091         * guile/scm-lazy-string.c: Use C++ exception handling.
3092         * guile/scm-frame.c: Use C++ exception handling.
3093         * guile/scm-disasm.c: Use C++ exception handling.
3094         * guile/scm-cmd.c: Use C++ exception handling.
3095         * guile/scm-breakpoint.c: Use C++ exception handling.
3096         * guile/scm-block.c: Use C++ exception handling.
3097         * guile/guile-internal.h: Use C++ exception handling.
3098         * gnu-v3-abi.c: Use C++ exception handling.
3099         * gdbtypes.c: Use C++ exception handling.
3100         * frame.c: Use C++ exception handling.
3101         * frame-unwind.c: Use C++ exception handling.
3102         * fbsd-tdep.c: Use C++ exception handling.
3103         * f-valprint.c: Use C++ exception handling.
3104         * exec.c: Use C++ exception handling.
3105         * event-top.c: Use C++ exception handling.
3106         * event-loop.c: Use C++ exception handling.
3107         * eval.c: Use C++ exception handling.
3108         * dwarf2read.c: Use C++ exception handling.
3109         * dwarf2loc.c: Use C++ exception handling.
3110         * dwarf2-frame.c: Use C++ exception handling.
3111         * dwarf2-frame-tailcall.c: Use C++ exception handling.
3112         * dwarf-index-write.c: Use C++ exception handling.
3113         * dwarf-index-cache.c: Use C++ exception handling.
3114         * dtrace-probe.c: Use C++ exception handling.
3115         * disasm-selftests.c: Use C++ exception handling.
3116         * darwin-nat.c: Use C++ exception handling.
3117         * cp-valprint.c: Use C++ exception handling.
3118         * cp-support.c: Use C++ exception handling.
3119         * cp-abi.c: Use C++ exception handling.
3120         * corelow.c: Use C++ exception handling.
3121         * completer.c: Use C++ exception handling.
3122         * compile/compile-object-run.c: Use C++ exception handling.
3123         * compile/compile-object-load.c: Use C++ exception handling.
3124         * compile/compile-cplus-symbols.c: Use C++ exception handling.
3125         * compile/compile-c-symbols.c: Use C++ exception handling.
3126         * common/selftest.c: Use C++ exception handling.
3127         * common/new-op.c: Use C++ exception handling.
3128         * cli/cli-script.c: Use C++ exception handling.
3129         * cli/cli-interp.c: Use C++ exception handling.
3130         * cli/cli-cmds.c: Use C++ exception handling.
3131         * c-varobj.c: Use C++ exception handling.
3132         * btrace.c: Use C++ exception handling.
3133         * breakpoint.c: Use C++ exception handling.
3134         * break-catch-throw.c: Use C++ exception handling.
3135         * arch-utils.c: Use C++ exception handling.
3136         * amd64-tdep.c: Use C++ exception handling.
3137         * ada-valprint.c: Use C++ exception handling.
3138         * ada-typeprint.c: Use C++ exception handling.
3139         * ada-lang.c: Use C++ exception handling.
3140         * aarch64-tdep.c: Use C++ exception handling.
3141
3142 2019-04-08  Tom Tromey  <tom@tromey.com>
3143
3144         * xml-support.c (gdb_xml_parser::parse): Update.
3145         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
3146         * value.c (show_convenience): Update.
3147         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
3148         (test_parse_flags_qcs): Update.
3149         * thread.c (thr_try_catch_cmd): Update.
3150         * target.c (target_translate_tls_address): Update.
3151         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
3152         (info_frame_command_core, frame_apply_command_count): Update.
3153         * rust-exp.y (rust_lex_exception_test): Update.
3154         * riscv-tdep.c (riscv_print_one_register_info): Update.
3155         * remote.c (remote_target::enable_btrace): Update.
3156         * record-btrace.c (record_btrace_enable_warn): Update.
3157         * python/py-utils.c (gdbpy_convert_exception): Update.
3158         * printcmd.c (do_one_display, print_variable_and_value): Update.
3159         * mi/mi-main.c (mi_print_exception): Update.
3160         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
3161         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
3162         * linux-nat.c (linux_nat_target::attach): Update.
3163         * linux-fork.c (class scoped_switch_fork_info): Update.
3164         * infrun.c (displaced_step_prepare): Update.
3165         * infcall.c (call_function_by_hand_dummy): Update.
3166         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
3167         * gnu-v3-abi.c (print_one_vtable): Update.
3168         * frame.c (get_prev_frame_always): Update.
3169         * f-valprint.c (info_common_command_for_block): Update.
3170         * exec.c (try_open_exec_file): Update.
3171         * exceptions.c (print_exception, exception_print)
3172         (exception_fprintf, exception_print_same): Update.
3173         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
3174         * dwarf-index-cache.c (index_cache::store)
3175         (index_cache::lookup_gdb_index): Update.
3176         * darwin-nat.c (maybe_cache_shell): Update.
3177         * cp-valprint.c (cp_print_value_fields): Update.
3178         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
3179         (gcc_cplus_symbol_address): Update.
3180         * compile/compile-c-symbols.c (gcc_convert_symbol)
3181         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
3182         * common/selftest.c: Update.
3183         * common/common-exceptions.h (struct gdb_exception) <message>: Now
3184         a std::string.
3185         (exception_try_scope_entry, exception_try_scope_exit): Don't
3186         declare.
3187         (struct exception_try_scope): Remove.
3188         (TRY): Don't use exception_try_scope.
3189         (struct gdb_exception): Add constructor, operator=.
3190         <what>: New method.
3191         (struct gdb_exception_RETURN_MASK_ALL)
3192         (struct gdb_exception_RETURN_MASK_ERROR)
3193         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
3194         (struct gdb_quit_bad_alloc): Update.
3195         * common/common-exceptions.c (exception_none): Change
3196         initializer.
3197         (struct catcher) <state, exception>: Initialize inline.
3198         <prev>: Remove member.
3199         (current_catcher): Remove.
3200         (catchers): New global.
3201         (exceptions_state_mc_init): Simplify.
3202         (catcher_pop): Remove.
3203         (exceptions_state_mc, exceptions_state_mc_catch): Update.
3204         (try_scope_depth, exception_try_scope_entry)
3205         (exception_try_scope_exit): Remove.
3206         (throw_exception_sjlj): Update.
3207         (exception_messages, exception_messages_size): Remove.
3208         (throw_it): Simplify.
3209         (gdb_exception_sliced_copy): Remove.
3210         (throw_exception_cxx): Update.
3211         * cli/cli-script.c (script_from_file): Update.
3212         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
3213         Update.
3214         * ada-valprint.c (ada_val_print): Update.
3215         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
3216         (create_excep_cond_exprs): Update.
3217
3218 2019-04-08  Tom Tromey  <tom@tromey.com>
3219
3220         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
3221         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
3222         (TRY, CATCH, END_CATCH): Remove some definitions.
3223         * common/common-exceptions.c: Don't use GDB_XCPT.
3224         (catcher_list_size): Remove.
3225         (throw_exception, throw_it): Simplify.
3226
3227 2019-04-05  Tom Tromey  <tom@tromey.com>
3228
3229         Revert the header-sorting patch.
3230         * ft32-tdep.c: Revert.
3231         * frv-tdep.c: Revert.
3232         * frv-linux-tdep.c: Revert.
3233         * frame.c: Revert.
3234         * frame-unwind.c: Revert.
3235         * frame-base.c: Revert.
3236         * fork-child.c: Revert.
3237         * findvar.c: Revert.
3238         * findcmd.c: Revert.
3239         * filesystem.c: Revert.
3240         * filename-seen-cache.h: Revert.
3241         * filename-seen-cache.c: Revert.
3242         * fbsd-tdep.c: Revert.
3243         * fbsd-nat.h: Revert.
3244         * fbsd-nat.c: Revert.
3245         * f-valprint.c: Revert.
3246         * f-typeprint.c: Revert.
3247         * f-lang.c: Revert.
3248         * extension.h: Revert.
3249         * extension.c: Revert.
3250         * extension-priv.h: Revert.
3251         * expprint.c: Revert.
3252         * exec.h: Revert.
3253         * exec.c: Revert.
3254         * exceptions.c: Revert.
3255         * event-top.c: Revert.
3256         * event-loop.c: Revert.
3257         * eval.c: Revert.
3258         * elfread.c: Revert.
3259         * dwarf2read.h: Revert.
3260         * dwarf2read.c: Revert.
3261         * dwarf2loc.c: Revert.
3262         * dwarf2expr.h: Revert.
3263         * dwarf2expr.c: Revert.
3264         * dwarf2-frame.c: Revert.
3265         * dwarf2-frame-tailcall.c: Revert.
3266         * dwarf-index-write.h: Revert.
3267         * dwarf-index-write.c: Revert.
3268         * dwarf-index-common.c: Revert.
3269         * dwarf-index-cache.h: Revert.
3270         * dwarf-index-cache.c: Revert.
3271         * dummy-frame.c: Revert.
3272         * dtrace-probe.c: Revert.
3273         * disasm.h: Revert.
3274         * disasm.c: Revert.
3275         * disasm-selftests.c: Revert.
3276         * dictionary.c: Revert.
3277         * dicos-tdep.c: Revert.
3278         * demangle.c: Revert.
3279         * dcache.h: Revert.
3280         * dcache.c: Revert.
3281         * darwin-nat.h: Revert.
3282         * darwin-nat.c: Revert.
3283         * darwin-nat-info.c: Revert.
3284         * d-valprint.c: Revert.
3285         * d-namespace.c: Revert.
3286         * d-lang.c: Revert.
3287         * ctf.c: Revert.
3288         * csky-tdep.c: Revert.
3289         * csky-linux-tdep.c: Revert.
3290         * cris-tdep.c: Revert.
3291         * cris-linux-tdep.c: Revert.
3292         * cp-valprint.c: Revert.
3293         * cp-support.c: Revert.
3294         * cp-namespace.c: Revert.
3295         * cp-abi.c: Revert.
3296         * corelow.c: Revert.
3297         * corefile.c: Revert.
3298         * continuations.c: Revert.
3299         * completer.h: Revert.
3300         * completer.c: Revert.
3301         * complaints.c: Revert.
3302         * coffread.c: Revert.
3303         * coff-pe-read.c: Revert.
3304         * cli-out.h: Revert.
3305         * cli-out.c: Revert.
3306         * charset.c: Revert.
3307         * c-varobj.c: Revert.
3308         * c-valprint.c: Revert.
3309         * c-typeprint.c: Revert.
3310         * c-lang.c: Revert.
3311         * buildsym.c: Revert.
3312         * buildsym-legacy.c: Revert.
3313         * build-id.h: Revert.
3314         * build-id.c: Revert.
3315         * btrace.c: Revert.
3316         * bsd-uthread.c: Revert.
3317         * breakpoint.h: Revert.
3318         * breakpoint.c: Revert.
3319         * break-catch-throw.c: Revert.
3320         * break-catch-syscall.c: Revert.
3321         * break-catch-sig.c: Revert.
3322         * blockframe.c: Revert.
3323         * block.c: Revert.
3324         * bfin-tdep.c: Revert.
3325         * bfin-linux-tdep.c: Revert.
3326         * bfd-target.c: Revert.
3327         * bcache.c: Revert.
3328         * ax-general.c: Revert.
3329         * ax-gdb.h: Revert.
3330         * ax-gdb.c: Revert.
3331         * avr-tdep.c: Revert.
3332         * auxv.c: Revert.
3333         * auto-load.c: Revert.
3334         * arm-wince-tdep.c: Revert.
3335         * arm-tdep.c: Revert.
3336         * arm-symbian-tdep.c: Revert.
3337         * arm-pikeos-tdep.c: Revert.
3338         * arm-obsd-tdep.c: Revert.
3339         * arm-nbsd-tdep.c: Revert.
3340         * arm-nbsd-nat.c: Revert.
3341         * arm-linux-tdep.c: Revert.
3342         * arm-linux-nat.c: Revert.
3343         * arm-fbsd-tdep.c: Revert.
3344         * arm-fbsd-nat.c: Revert.
3345         * arm-bsd-tdep.c: Revert.
3346         * arch-utils.c: Revert.
3347         * arc-tdep.c: Revert.
3348         * arc-newlib-tdep.c: Revert.
3349         * annotate.h: Revert.
3350         * annotate.c: Revert.
3351         * amd64-windows-tdep.c: Revert.
3352         * amd64-windows-nat.c: Revert.
3353         * amd64-tdep.c: Revert.
3354         * amd64-sol2-tdep.c: Revert.
3355         * amd64-obsd-tdep.c: Revert.
3356         * amd64-obsd-nat.c: Revert.
3357         * amd64-nbsd-tdep.c: Revert.
3358         * amd64-nbsd-nat.c: Revert.
3359         * amd64-nat.c: Revert.
3360         * amd64-linux-tdep.c: Revert.
3361         * amd64-linux-nat.c: Revert.
3362         * amd64-fbsd-tdep.c: Revert.
3363         * amd64-fbsd-nat.c: Revert.
3364         * amd64-dicos-tdep.c: Revert.
3365         * amd64-darwin-tdep.c: Revert.
3366         * amd64-bsd-nat.c: Revert.
3367         * alpha-tdep.c: Revert.
3368         * alpha-obsd-tdep.c: Revert.
3369         * alpha-nbsd-tdep.c: Revert.
3370         * alpha-mdebug-tdep.c: Revert.
3371         * alpha-linux-tdep.c: Revert.
3372         * alpha-linux-nat.c: Revert.
3373         * alpha-bsd-tdep.c: Revert.
3374         * alpha-bsd-nat.c: Revert.
3375         * aix-thread.c: Revert.
3376         * agent.c: Revert.
3377         * addrmap.c: Revert.
3378         * ada-varobj.c: Revert.
3379         * ada-valprint.c: Revert.
3380         * ada-typeprint.c: Revert.
3381         * ada-tasks.c: Revert.
3382         * ada-lang.c: Revert.
3383         * aarch64-tdep.c: Revert.
3384         * aarch64-ravenscar-thread.c: Revert.
3385         * aarch64-newlib-tdep.c: Revert.
3386         * aarch64-linux-tdep.c: Revert.
3387         * aarch64-linux-nat.c: Revert.
3388         * aarch64-fbsd-tdep.c: Revert.
3389         * aarch64-fbsd-nat.c: Revert.
3390         * aarch32-linux-nat.c: Revert.
3391
3392 2019-04-05  Tom Tromey  <tom@tromey.com>
3393
3394         * ft32-tdep.c: Sort headers.
3395         * frv-tdep.c: Sort headers.
3396         * frv-linux-tdep.c: Sort headers.
3397         * frame.c: Sort headers.
3398         * frame-unwind.c: Sort headers.
3399         * frame-base.c: Sort headers.
3400         * fork-child.c: Sort headers.
3401         * findvar.c: Sort headers.
3402         * findcmd.c: Sort headers.
3403         * filesystem.c: Sort headers.
3404         * filename-seen-cache.h: Sort headers.
3405         * filename-seen-cache.c: Sort headers.
3406         * fbsd-tdep.c: Sort headers.
3407         * fbsd-nat.h: Sort headers.
3408         * fbsd-nat.c: Sort headers.
3409         * f-valprint.c: Sort headers.
3410         * f-typeprint.c: Sort headers.
3411         * f-lang.c: Sort headers.
3412         * extension.h: Sort headers.
3413         * extension.c: Sort headers.
3414         * extension-priv.h: Sort headers.
3415         * expprint.c: Sort headers.
3416         * exec.h: Sort headers.
3417         * exec.c: Sort headers.
3418         * exceptions.c: Sort headers.
3419         * event-top.c: Sort headers.
3420         * event-loop.c: Sort headers.
3421         * eval.c: Sort headers.
3422         * elfread.c: Sort headers.
3423         * dwarf2read.h: Sort headers.
3424         * dwarf2read.c: Sort headers.
3425         * dwarf2loc.c: Sort headers.
3426         * dwarf2expr.h: Sort headers.
3427         * dwarf2expr.c: Sort headers.
3428         * dwarf2-frame.c: Sort headers.
3429         * dwarf2-frame-tailcall.c: Sort headers.
3430         * dwarf-index-write.h: Sort headers.
3431         * dwarf-index-write.c: Sort headers.
3432         * dwarf-index-common.c: Sort headers.
3433         * dwarf-index-cache.h: Sort headers.
3434         * dwarf-index-cache.c: Sort headers.
3435         * dummy-frame.c: Sort headers.
3436         * dtrace-probe.c: Sort headers.
3437         * disasm.h: Sort headers.
3438         * disasm.c: Sort headers.
3439         * disasm-selftests.c: Sort headers.
3440         * dictionary.c: Sort headers.
3441         * dicos-tdep.c: Sort headers.
3442         * demangle.c: Sort headers.
3443         * dcache.h: Sort headers.
3444         * dcache.c: Sort headers.
3445         * darwin-nat.h: Sort headers.
3446         * darwin-nat.c: Sort headers.
3447         * darwin-nat-info.c: Sort headers.
3448         * d-valprint.c: Sort headers.
3449         * d-namespace.c: Sort headers.
3450         * d-lang.c: Sort headers.
3451         * ctf.c: Sort headers.
3452         * csky-tdep.c: Sort headers.
3453         * csky-linux-tdep.c: Sort headers.
3454         * cris-tdep.c: Sort headers.
3455         * cris-linux-tdep.c: Sort headers.
3456         * cp-valprint.c: Sort headers.
3457         * cp-support.c: Sort headers.
3458         * cp-namespace.c: Sort headers.
3459         * cp-abi.c: Sort headers.
3460         * corelow.c: Sort headers.
3461         * corefile.c: Sort headers.
3462         * continuations.c: Sort headers.
3463         * completer.h: Sort headers.
3464         * completer.c: Sort headers.
3465         * complaints.c: Sort headers.
3466         * coffread.c: Sort headers.
3467         * coff-pe-read.c: Sort headers.
3468         * cli-out.h: Sort headers.
3469         * cli-out.c: Sort headers.
3470         * charset.c: Sort headers.
3471         * c-varobj.c: Sort headers.
3472         * c-valprint.c: Sort headers.
3473         * c-typeprint.c: Sort headers.
3474         * c-lang.c: Sort headers.
3475         * buildsym.c: Sort headers.
3476         * buildsym-legacy.c: Sort headers.
3477         * build-id.h: Sort headers.
3478         * build-id.c: Sort headers.
3479         * btrace.c: Sort headers.
3480         * bsd-uthread.c: Sort headers.
3481         * breakpoint.h: Sort headers.
3482         * breakpoint.c: Sort headers.
3483         * break-catch-throw.c: Sort headers.
3484         * break-catch-syscall.c: Sort headers.
3485         * break-catch-sig.c: Sort headers.
3486         * blockframe.c: Sort headers.
3487         * block.c: Sort headers.
3488         * bfin-tdep.c: Sort headers.
3489         * bfin-linux-tdep.c: Sort headers.
3490         * bfd-target.c: Sort headers.
3491         * bcache.c: Sort headers.
3492         * ax-general.c: Sort headers.
3493         * ax-gdb.h: Sort headers.
3494         * ax-gdb.c: Sort headers.
3495         * avr-tdep.c: Sort headers.
3496         * auxv.c: Sort headers.
3497         * auto-load.c: Sort headers.
3498         * arm-wince-tdep.c: Sort headers.
3499         * arm-tdep.c: Sort headers.
3500         * arm-symbian-tdep.c: Sort headers.
3501         * arm-pikeos-tdep.c: Sort headers.
3502         * arm-obsd-tdep.c: Sort headers.
3503         * arm-nbsd-tdep.c: Sort headers.
3504         * arm-nbsd-nat.c: Sort headers.
3505         * arm-linux-tdep.c: Sort headers.
3506         * arm-linux-nat.c: Sort headers.
3507         * arm-fbsd-tdep.c: Sort headers.
3508         * arm-fbsd-nat.c: Sort headers.
3509         * arm-bsd-tdep.c: Sort headers.
3510         * arch-utils.c: Sort headers.
3511         * arc-tdep.c: Sort headers.
3512         * arc-newlib-tdep.c: Sort headers.
3513         * annotate.h: Sort headers.
3514         * annotate.c: Sort headers.
3515         * amd64-windows-tdep.c: Sort headers.
3516         * amd64-windows-nat.c: Sort headers.
3517         * amd64-tdep.c: Sort headers.
3518         * amd64-sol2-tdep.c: Sort headers.
3519         * amd64-obsd-tdep.c: Sort headers.
3520         * amd64-obsd-nat.c: Sort headers.
3521         * amd64-nbsd-tdep.c: Sort headers.
3522         * amd64-nbsd-nat.c: Sort headers.
3523         * amd64-nat.c: Sort headers.
3524         * amd64-linux-tdep.c: Sort headers.
3525         * amd64-linux-nat.c: Sort headers.
3526         * amd64-fbsd-tdep.c: Sort headers.
3527         * amd64-fbsd-nat.c: Sort headers.
3528         * amd64-dicos-tdep.c: Sort headers.
3529         * amd64-darwin-tdep.c: Sort headers.
3530         * amd64-bsd-nat.c: Sort headers.
3531         * alpha-tdep.c: Sort headers.
3532         * alpha-obsd-tdep.c: Sort headers.
3533         * alpha-nbsd-tdep.c: Sort headers.
3534         * alpha-mdebug-tdep.c: Sort headers.
3535         * alpha-linux-tdep.c: Sort headers.
3536         * alpha-linux-nat.c: Sort headers.
3537         * alpha-bsd-tdep.c: Sort headers.
3538         * alpha-bsd-nat.c: Sort headers.
3539         * aix-thread.c: Sort headers.
3540         * agent.c: Sort headers.
3541         * addrmap.c: Sort headers.
3542         * ada-varobj.c: Sort headers.
3543         * ada-valprint.c: Sort headers.
3544         * ada-typeprint.c: Sort headers.
3545         * ada-tasks.c: Sort headers.
3546         * ada-lang.c: Sort headers.
3547         * aarch64-tdep.c: Sort headers.
3548         * aarch64-ravenscar-thread.c: Sort headers.
3549         * aarch64-newlib-tdep.c: Sort headers.
3550         * aarch64-linux-tdep.c: Sort headers.
3551         * aarch64-linux-nat.c: Sort headers.
3552         * aarch64-fbsd-tdep.c: Sort headers.
3553         * aarch64-fbsd-nat.c: Sort headers.
3554         * aarch32-linux-nat.c: Sort headers.
3555
3556 2019-04-04  Tom Tromey  <tom@tromey.com>
3557
3558         * varobj.c (varobj_create): Update.
3559         * rust-exp.y (struct rust_parser) <update_innermost_block,
3560         lookup_symbol>: New methods.
3561         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
3562         Rename.
3563         (rust_parser::rust_lookup_type)
3564         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3565         * printcmd.c (display_command, do_one_display): Update.
3566         * parser-defs.h (struct parser_state) <parser_state>: Add
3567         "tracker" parameter.
3568         (block_tracker): New member.
3569         (class innermost_block_tracker) <innermost_block_tracker>: Add
3570         "types" parameter.
3571         <reset>: Remove method.
3572         (innermost_block): Don't declare.
3573         (null_post_parser): Update.
3574         * parse.c (innermost_block): Remove global.
3575         (write_dollar_variable): Update.
3576         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
3577         Remove "tracker_types" parameter.
3578         (parse_expression): Add "tracker" parameter.
3579         (parse_expression_for_completion): Update.
3580         (null_post_parser): Add "tracker" parameter.
3581         * p-exp.y: Update rules.
3582         * m2-exp.y: Update rules.
3583         * language.h (struct language_defn) <la_post_parser>: Add
3584         "tracker" parameter.
3585         * go-exp.y: Update rules.
3586         * f-exp.y: Update rules.
3587         * expression.h (parse_expression, parse_exp_1): Add "tracker"
3588         parameter.
3589         * d-exp.y: Update rules.
3590         * c-exp.y: Update rules.
3591         * breakpoint.c (set_breakpoint_condition): Create an
3592         innermost_block_tracker.
3593         (watch_command_1): Likewise.
3594         * ada-lang.c (resolve): Add "tracker" parameter.
3595         (resolve_subexp): Likewise.
3596         * ada-exp.y (write_var_from_sym): Update.
3597
3598 2019-04-04  Tom Tromey  <tom@tromey.com>
3599
3600         * type-stack.h: New file.
3601         * type-stack.c: New file.
3602         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
3603         type-stack.h.
3604         (insert_into_type_stack, insert_type, push_type, push_type_int)
3605         (insert_type_address_space, pop_type, pop_type_int)
3606         (pop_typelist, pop_type_stack, append_type_stack)
3607         (push_type_stack, get_type_stack, push_typelist)
3608         (follow_type_instance_flags, follow_types): Don't declare.
3609         * parse.c (type_stack): Remove global.
3610         (parse_exp_in_context): Update.
3611         (insert_into_type_stack, insert_type, push_type, push_type_int)
3612         (insert_type_address_space, pop_type, pop_type_int)
3613         (pop_typelist, pop_type_stack, append_type_stack)
3614         (push_type_stack, get_type_stack, push_typelist)
3615         (follow_type_instance_flags, follow_types): Remove (moved to
3616         type-stack.c).
3617         * f-exp.y (type_stack): New global.
3618         Update rules.
3619         (push_kind_type, f_parse): Update.
3620         * d-exp.y (type_stack): New global.
3621         Update rules.
3622         (d_parse): Update.
3623         * c-exp.y (struct c_parse_state) <type_stack>: New member.
3624         Update rules.
3625         * Makefile.in (COMMON_SFILES): Add type-stack.c.
3626         (HFILES_NO_SRCDIR): Add type-stack.h.
3627
3628 2019-04-04  Tom Tromey  <tom@tromey.com>
3629
3630         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
3631         (rust_parser::convert_ast_to_expression, rust_parse)
3632         (rust_lex_test_completion, rust_lex_tests): Update.
3633         * parser-defs.h (struct expr_completion_state): New.
3634         (struct parser_state) <parser_state>: Add completion parameter.
3635         <mark_struct_expression, mark_completion_tag>: New methods.
3636         <parse_completion, m_completion_state>: New members.
3637         (prefixify_expression, null_post_parser): Update.
3638         (mark_struct_expression, mark_completion_tag): Don't declare.
3639         * parse.c (parse_completion, expout_last_struct)
3640         (expout_tag_completion_type, expout_completion_name): Remove
3641         globals.
3642         (parser_state::mark_struct_expression)
3643         (parser_state::mark_completion_tag): Now methods.
3644         (prefixify_expression): Add last_struct parameter.
3645         (prefixify_subexp): Likewise.
3646         (parse_exp_1): Update.
3647         (parse_exp_in_context): Add cstate parameter.  Update.
3648         (parse_expression_for_completion): Create an
3649         expr_completion_state.
3650         (null_post_parser): Add "completion" parameter.
3651         * p-exp.y: Update rules.
3652         (yylex): Update.
3653         * language.h (struct language_defn) <la_post_parser>: Add
3654         "completing" parameter.
3655         * go-exp.y: Update rules.
3656         (lex_one_token): Update.
3657         * expression.h (parse_completion): Don't declare.
3658         * d-exp.y: Update rules.
3659         (lex_one_token): Update rules.
3660         * c-exp.y: Update rules.
3661         (lex_one_token): Update.
3662         * ada-lang.c (resolve): Add "parse_completion" parameter.
3663         (resolve_subexp): Likewise.
3664         (ada_resolve_function): Likewise.
3665
3666 2019-04-04  Tom Tromey  <tom@tromey.com>
3667
3668         * parser-defs.h (struct parser_state) <start_arglist,
3669         end_arglist>: New methods.
3670         <arglist_len, m_funcall_chain>: New members.
3671         (arglist_len, start_arglist, end_arglist): Don't declare.
3672         * parse.c (arglist_len, funcall_chain): Remove global.
3673         (start_arglist, end_arglist): Remove functions.
3674         (parse_exp_in_context): Update.
3675         * p-exp.y: Update rules.
3676         * m2-exp.y: Update rules.
3677         * go-exp.y: Update rules.
3678         * f-exp.y: Update rules.
3679         * d-exp.y: Update rules.
3680         * c-exp.y: Update rules.
3681
3682 2019-04-04  Tom Tromey  <tom@tromey.com>
3683
3684         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
3685         lex_operator, push_back>: New methods.
3686         Update all rules.
3687         (rust_parser::lex_hex, lex_escape): Rename and update.
3688         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
3689         (rust_parser::lex_operator): Rename and update.
3690         (rust_parser::lex_number, rustyylex, rustyyerror)
3691         (rust_lex_test_init, rust_lex_test_sequence)
3692         (rust_lex_test_push_back, rust_lex_tests): Update.
3693         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
3694         parameter.
3695         <lexptr, prev_lexptr>: New members.
3696         (lexptr, prev_lexptr): Don't declare.
3697         * parse.c (lexptr, prev_lexptr): Remove globals.
3698         (parse_exp_in_context): Update.
3699         * p-exp.y (yylex, yyerror): Update.
3700         * m2-exp.y (parse_number, yylex, yyerror): Update.
3701         * go-exp.y (lex_one_token, yyerror): Update.
3702         * f-exp.y (match_string_literal, yylex, yyerror): Update.
3703         * d-exp.y (lex_one_token, yyerror): Update.
3704         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
3705         (lex_one_token, yyerror): Update.
3706         * ada-lex.l (YY_INPUT): Update.
3707         (rewind_to_char): Update.
3708         * ada-exp.y (yyerror): Update.
3709
3710 2019-04-04  Tom Tromey  <tom@tromey.com>
3711
3712         * rust-exp.y (rustyylex, rust_lex_tests): Update.
3713         * parser-defs.h (struct parser_state) <parser_state>: Add new
3714         parameter.
3715         <comma_terminates>: New member.
3716         (comma_terminates): Don't declare global.
3717         * parse.c (comma_terminates): Remove global.
3718         (parse_exp_in_context): Update.
3719         * p-exp.y (yylex): Update.
3720         * m2-exp.y (yylex): Update.
3721         * go-exp.y (lex_one_token): Update.
3722         * f-exp.y (yylex): Update.
3723         * d-exp.y (lex_one_token): Update.
3724         * c-exp.y (lex_one_token): Update.
3725         * ada-lex.l: Update.
3726
3727 2019-04-04  Tom Tromey  <tom@tromey.com>
3728
3729         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
3730         (rustyylex, rust_lex_test_init, rust_lex_test_one)
3731         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
3732         * parser-defs.h (paren_depth): Don't declare.
3733         * parse.c (paren_depth): Remove global.
3734         (parse_exp_in_context): Update.
3735         * p-exp.y (paren_depth): New global.
3736         (pascal_parse): Initialize it.
3737         * m2-exp.y (paren_depth): New global.
3738         (m2_parse): Initialize it.
3739         * go-exp.y (paren_depth): New global.
3740         (go_parse): Initialize it.
3741         * f-exp.y (paren_depth): New global.
3742         (f_parse): Initialize it.
3743         * d-exp.y (paren_depth): New global.
3744         (d_parse): Initialize it.
3745         * c-exp.y (paren_depth): New global.
3746         (c_parse): Initialize it.
3747         * ada-lex.l (paren_depth): New global.
3748         (lexer_init): Initialize it.
3749
3750 2019-04-04  Tom Tromey  <tom@tromey.com>
3751
3752         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
3753         (rust_parser::convert_ast_to_type)
3754         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
3755         * parser-defs.h (struct parser_state) <parser_state>: Add
3756         parameters.  Initialize new members.
3757         <expression_context_block, expression_context_pc>: New members.
3758         * parse.c (expression_context_block, expression_context_pc):
3759         Remove globals.
3760         (parse_exp_in_context): Update.
3761         * p-exp.y: Update all rules.
3762         (yylex): Update.
3763         * m2-exp.y: Update all rules.
3764         (yylex): Update.
3765         * go-exp.y (yylex): Update.
3766         * f-exp.y (yylex): Update.
3767         * d-exp.y: Update all rules.
3768         (yylex): Update.
3769         * c-exp.y: Update all rules.
3770         (lex_one_token, classify_name, yylex, c_parse): Update.
3771         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
3772
3773 2019-04-04  Tom Tromey  <tom@tromey.com>
3774
3775         * gdbarch.h, gdbarch.c: Rebuild.
3776         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
3777         * stap-probe.h:
3778         (struct stap_parse_info): Replace "parser_state" with
3779         "expr_builder".
3780         * parser-defs.h (struct expr_builder): Rename from "parser_state".
3781         (parser_state): New class.
3782         * parse.c (expr_builder): Rename.
3783         (expr_builder::release): Rename.
3784         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
3785         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
3786         (write_exp_elt_longcst, write_exp_elt_floatcst)
3787         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
3788         (write_exp_string_vector, write_exp_bitstring)
3789         (write_exp_msymbol, mark_struct_expression)
3790         (write_dollar_variable)
3791         (insert_type_address_space, increase_expout_size): Replace
3792         "parser_state" with "expr_builder".
3793         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
3794         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
3795         "parser_state" with "expr_builder".
3796
3797 2019-04-04  Tom Tromey  <tom@tromey.com>
3798
3799         * rust-exp.y: Replace "parse_language" with method call.
3800         * p-exp.y:
3801         (yylex): Replace "parse_language" with method call.
3802         * m2-exp.y:
3803         (yylex): Replace "parse_language" with method call.
3804         * go-exp.y (classify_name): Replace "parse_language" with method
3805         call.
3806         * f-exp.y (yylex): Replace "parse_language" with method call.
3807         * d-exp.y (lex_one_token): Replace "parse_language" with method
3808         call.
3809         * c-exp.y:
3810         (lex_one_token, classify_name, yylex): Replace "parse_language"
3811         with method call.
3812         * ada-exp.y (find_primitive_type, type_char)
3813         (type_system_address): Replace "parse_language" with method call.
3814
3815 2019-04-04  Tom Tromey  <tom@tromey.com>
3816
3817         * rust-exp.y: Replace "parse_gdbarch" with method call.
3818         * parse.c (write_dollar_variable, insert_type_address_space):
3819         Replace "parse_gdbarch" with method call.
3820         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
3821         call.
3822         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
3823         call.
3824         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
3825         "parse_gdbarch" with method call.
3826         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
3827         with method call.
3828         * f-exp.y (parse_type, parse_f_type, yylex): Replace
3829         "parse_gdbarch" with method call.
3830         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
3831         "parse_gdbarch" with method call.
3832         * c-exp.y (parse_type, parse_number, classify_name): Replace
3833         "parse_gdbarch" with method call.
3834         * ada-lex.l: Replace "parse_gdbarch" with method call.
3835         * ada-exp.y (parse_type, find_primitive_type, type_char)
3836         (type_system_address): Replace "parse_gdbarch" with method call.
3837
3838 2019-04-04  Tom Tromey  <tom@tromey.com>
3839
3840         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
3841         * stap-probe.c (stap_parse_argument): Update.
3842         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
3843         initial_size parameter.
3844         * rust-exp.y (rust_lex_tests): Update.
3845         * parse.c (parser_state): Update.
3846         (parse_exp_in_context): Update.
3847         * parser-defs.h (struct parser_state) <parser_state>: Remove
3848         "initial_size" parameter.
3849
3850 2019-04-04  Tom Tromey  <tom@tromey.com>
3851
3852         * parser-defs.h (increase_expout_size): Don't declare.
3853         * parse.c (increase_expout_size): Now static.
3854
3855 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
3856
3857         * gnu-nat.c (gnu_nat_target::wait): Fix
3858         target_waitstatus_to_string call.
3859
3860 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3861
3862         * eval.c (evaluate_subexp_standard): Handle internal functions
3863         during Fortran function call handling.
3864
3865 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
3866
3867         * NEWS: Mention new internal functions.
3868         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
3869         (read_base_type): Use dwarf2_init_complex_target_type.
3870         * value.c (creal_internal_fn): New function.
3871         (cimag_internal_fn): New function.
3872         (_initialize_values): Register new internal functions.
3873
3874 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3875
3876         * infrun.c (stop_all_threads): If debug_infrun, always
3877         trace the wait status after wait_one, using
3878         target_waitstatus_to_string and target_pid_to_str.
3879         (handle_inferior_event): Replace various trace of
3880         wait status kind by a single trace.
3881         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
3882         wait status kind image by target_waitstatus_to_string.
3883         * target/waitstatus.c (target_waitstatus_to_string): Fix
3884         obsolete comment.
3885
3886 2019-04-01  Tom Tromey  <tromey@adacore.com>
3887
3888         PR symtab/23331:
3889         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
3890
3891 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
3892             Pedro Alves  <palves@redhat.com>
3893
3894         * top.c (quit_force): Call 'finalize_values'.
3895         * value.c (finalize_values): New function.
3896         * value.h (finalize_values): Declare.
3897
3898 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
3899
3900         * NEWS: Announce $_gdb_major and $_gdb_minor.
3901
3902         * top.c (init_gdb_version_vars): New function.
3903         (gdb_init): Call init_gdb_version_vars.
3904
3905 2019-03-29  Tom Tromey  <tromey@adacore.com>
3906
3907         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
3908         help text.  Remove dead code.
3909
3910 2019-03-29  Keith Seitz  <keiths@redhat.com>
3911
3912         From Siddhesh Poyarekar:
3913         * f-lang.h (f77_get_upperbound): Return LONGEST.
3914         (f77_get_lowerbound): Likewise.
3915         * f-typeprint.c (f_type_print_varspec_suffix): Expand
3916         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
3917         print them.
3918         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
3919         plongest to format print it.
3920         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
3921         (f77_get_upperbound): Likewise.
3922         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
3923         LOWER_BOUND to LONGEST.
3924         (f77_create_arrayprint_offset_tbl): Likewise.
3925
3926 2019-03-29  Keith Seitz  <keiths@redhat.com>
3927
3928         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
3929         %s/pulongest for TYPE_LENGTH instead of %d in format
3930         strings.
3931         * ada-typerint.c (ada_print_type): Likewise.
3932         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
3933         * compile/compile-c-support.c (generate_register_struct): Likewise.
3934         * gdbtypes.c (recursive_dump_type): Likewise.
3935         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
3936         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
3937         instead of %d in format strings.
3938         * riscv-tdep.c (riscv_type_alignment): Cast second argument
3939         to std::min to ULONGEST.
3940         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
3941         instead of %d in format strings.
3942         * tracepoint.c (info_scope_command): Likewise.
3943         * typeprint.c (print_offset_data::update)
3944         (print_offset_data::finish): Likewise.
3945         * xtensa-tdep.c (xtensa_store_return_value)
3946         (xtensa_push_dummy_call): Likewise.
3947
3948 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
3949
3950         * windows-nat.c (display_selector): Fixed format specifications
3951         for 64-bit Cygwin.
3952
3953 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3954
3955         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
3956
3957 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
3958
3959         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
3960         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
3961         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
3962         (nios2_linux_init_abi): Install it.
3963
3964 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3965
3966         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
3967
3968 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
3969
3970         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
3971
3972 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3973             Tom Tromey  <tromey@adacore.com>
3974
3975         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
3976
3977 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
3978
3979         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
3980         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
3981         method to compute the bounds of range types. Also print "[evaluated]"
3982         if the bounds' values come from a dynamic evaluation.
3983
3984 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
3985
3986         * cp-valprint.c (cp_print_value_fields): Don't print trailing
3987         whitespace when pretty printing is on.
3988
3989 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3990
3991         * ppc-linux-nat.c: Add include.
3992
3993 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3994
3995         * NEWS: Mention AArch64 Pointer Authentication.
3996
3997 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
3998
3999         * arm-linux-nat.c: Add include.
4000
4001 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
4002
4003         * source-cache.c (source_cache::get_source_lines): Re-read
4004         fullname after calling open_source_file.
4005
4006 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
4007
4008         * NEWS: Mention TLS support for FreeBSD.
4009
4010 2019-03-25  Tom Tromey  <tromey@adacore.com>
4011
4012         * minsyms.c (BUNCH_SIZE): Update comment.
4013         (~minimal_symbol_reader): Remove old comment.
4014         (compact_minimal_symbols): Update comment.
4015         (minimal_symbol_reader::install): Remove old comment.  Update
4016         other comments.
4017
4018 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4019
4020         * s390-linux-nat.c: Add include.
4021
4022 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
4023
4024         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
4025         Call linux_get_hwcap.
4026         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
4027         Likewise.
4028         (aarch64_linux_get_hwcap): Remove function.
4029         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
4030         declaration.
4031         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
4032         linux_get_hwcap.
4033         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
4034         * linux-tdep.c (linux_get_hwcap): Add function.
4035         (linux_get_hwcap2): Likewise.
4036         * linux-tdep.h (linux_get_hwcap): Add declaration.
4037         (linux_get_hwcap2): Likewise.
4038         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
4039         (ppc_linux_get_hwcap2): Likewise.
4040         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
4041         linux_get_hwcap.
4042         (ppc_linux_nat_target::insert_watchpoint): Likewise.
4043         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
4044         (ppc_linux_nat_target::read_description): Likewise.
4045         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
4046         * s390-linux-nat.c: Likewise.
4047         * s390-linux-tdep.c (s390_core_read_description): Likewise.
4048
4049 2019-03-24  Tom Tromey  <tom@tromey.com>
4050
4051         * ada-lang.c (standard_lookup): Simplify initialization.
4052         (ada_lookup_symbol_nonlocal): Simplify return.
4053         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
4054         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
4055         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
4056         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
4057         initialization.
4058         * solib.c (solib_global_lookup): Simplify.
4059         * symtab.c (null_block_symbol): Remove.
4060         (symbol_cache_lookup): Simplify returns.
4061         (lookup_language_this): Simplify returns.
4062         (lookup_symbol_aux): Simplify return.
4063         (lookup_local_symbol): Simplify returns.
4064         (lookup_global_symbol_from_objfile): Simplify return.
4065         (lookup_symbol_in_objfile_symtabs)
4066         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
4067         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
4068         (lookup_static_symbol, lookup_global_symbol): Simplify return.
4069         * cp-namespace.c (cp_lookup_bare_symbol)
4070         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
4071         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
4072         (cp_lookup_nested_symbol): Don't use null_block_symbol.
4073         (cp_lookup_symbol_via_imports): Simplify initialization.
4074         (find_symbol_in_baseclass): Likewise.
4075         * symtab.h (null_block_symbol): Remove.
4076         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
4077         (d_lookup_nested_symbol, d_lookup_symbol_imports)
4078         (d_lookup_symbol_module): Likewise.
4079         (find_symbol_in_baseclass): Simplify initialization.
4080
4081 2019-03-24  Tom Tromey  <tom@tromey.com>
4082
4083         * expression.h: Don't include symtab.h.
4084         (struct block): Forward declare.
4085
4086 2019-03-24  Tom Tromey  <tom@tromey.com>
4087
4088         * c-exp.y (typebase): Remove casts.
4089         * gdbtypes.c (lookup_unsigned_typename, )
4090         (lookup_signed_typename): Remove cast.
4091         * eval.c (parse_to_comma_and_eval): Remove cast.
4092         * parse.c (write_dollar_variable): Remove cast.
4093         * block.h (struct block) <superblock>: Now const.
4094         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
4095         * psymtab.c (psym_map_matching_symbols): Make "block" const.
4096         (map_block): Make "block" const.
4097         * symfile.h (struct quick_symbol_functions)
4098         <map_matching_symbols>: Constify block argument to "callback".
4099         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
4100         const.
4101         (find_pc_sect_compunit_symtab): Make "b" const.
4102         (find_symbol_at_address): Likewise.
4103         (search_symbols): Likewise.
4104         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
4105         (dw2_debug_names_lookup_symbol): Likewise.
4106         (dw2_map_matching_symbols): Update.
4107         * p-valprint.c (pascal_val_print): Remove "block".
4108         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
4109         (aux_add_nonlocal_symbols): Make "block" const.
4110         (resolve_subexp): Remove cast.
4111         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
4112         const.
4113         (iterate_over_file_blocks): Likewise.
4114         * f-exp.y (%union) <bval>: Remove.
4115         * coffread.c (patch_opaque_types): Make "b" const.
4116         * spu-tdep.c (spu_catch_start): Make "block" const.
4117         * c-valprint.c (print_unpacked_pointer): Remove "block".
4118         * symmisc.c (dump_symtab_1): Make "b" const.
4119         (block_depth): Make "block" const.
4120         * d-exp.y (%union) <bval>: Remove.
4121         * cp-support.h (cp_lookup_rtti_type): Update.
4122         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
4123         * psymtab.c (psym_lookup_symbol): Make "block" const.
4124         (maintenance_check_psymtabs): Make "b" const.
4125         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
4126         (enumerate_locals, enumerate_args): Update.
4127         * python/py-symtab.c (stpy_global_block): Make "block" const.
4128         (stpy_static_block): Likewise.
4129         * inline-frame.c (block_starting_point_at): Make "new_block"
4130         const.
4131         * block.c (find_block_in_blockvector): Make return type const.
4132         (blockvector_for_pc_sect): Make "b" const.
4133         (find_block_in_blockvector): Make "b" const.
4134
4135 2019-03-23  Tom Tromey  <tom@tromey.com>
4136
4137         * varobj.c (varobj_create): Update.
4138         * symfile.c (clear_symtab_users): Don't reset innermost_block.
4139         * printcmd.c (display_command, do_one_display): Don't reset
4140         innermost_block.
4141         * parser-defs.h (enum innermost_block_tracker_type): Move to
4142         expression.h.
4143         (innermost_block): Update comment.
4144         * parse.c (parse_exp_1): Add tracker_types parameter.
4145         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
4146         tracker_types parameter.  Reset innermost_block.
4147         (parse_exp_in_context): Remove.
4148         (parse_expression_for_completion): Update.
4149         * objfiles.c (~objfile): Don't reset expression_context_block or
4150         innermost_block.
4151         * expression.h (enum innermost_block_tracker_type): Move from
4152         parser-defs.h.
4153         (parse_exp_1): Add tracker_types parameter.
4154         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
4155         reset innermost_block.
4156
4157 2019-03-23  Tom Tromey  <tom@tromey.com>
4158
4159         * objfiles.h: Include bcache.h.
4160
4161 2019-03-23  Tom Tromey  <tom@tromey.com>
4162
4163         * linespec.c (get_current_search_block): Use
4164         scoped_restore_current_language.
4165         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
4166
4167 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4168             Jiong Wang  <jiong.wang@arm.com>
4169
4170         * aarch64-linux-tdep.c
4171         (aarch64_linux_iterate_over_regset_sections): Check for pauth
4172         section.
4173         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
4174
4175 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4176             Jiong Wang  <jiong.wang@arm.com>
4177
4178         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
4179         instructions.
4180         (aarch64_analyze_prologue_test): Add PACIASP test.
4181         (aarch64_prologue_prev_register): Unmask PC value.
4182
4183 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4184             Jiong Wang  <jiong.wang@arm.com>
4185
4186         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
4187         (aarch64_dwarf2_prev_register): Unmask PC value.
4188         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
4189         (aarch64_execute_dwarf_cfa_vendor_op): Check for
4190         DW_CFA_AARCH64_negate_ra_state.
4191         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
4192
4193 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4194             Jiong Wang  <jiong.wang@arm.com>
4195
4196         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
4197         registers.
4198         (aarch64_pseudo_register_name): Likewise.
4199         (aarch64_pseudo_register_type): Likewise.
4200         (aarch64_pseudo_register_reggroup_p): Likewise.
4201         (aarch64_gdbarch_init): Add pauth registers.
4202         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
4203         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
4204         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
4205         (struct gdbarch_tdep): Add regnum for ra_state.
4206
4207 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4208             Jiong Wang  <jiong.wang@arm.com>
4209
4210         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
4211
4212 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4213             Jiong Wang  <jiong.wang@arm.com>
4214
4215         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
4216         function.
4217         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
4218         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
4219         (aarch64_gdbarch_init): Add puth registers.
4220         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
4221         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
4222         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
4223
4224 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4225             Jiong Wang  <jiong.wang@arm.com>
4226
4227         * aarch64-linux-nat.c
4228         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
4229         * aarch64-linux-tdep.c
4230         (aarch64_linux_core_read_description): Likewise.
4231         (aarch64_linux_get_hwcap): New function.
4232         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
4233         (aarch64_linux_get_hwcap): New declaration.
4234
4235 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
4236             Jiong Wang  <jiong.wang@arm.com>
4237
4238         * aarch64-linux-nat.c
4239         (aarch64_linux_nat_target::read_description): Add pauth param.
4240         * aarch64-linux-tdep.c
4241         (aarch64_linux_core_read_description): Likewise.
4242         * aarch64-tdep.c (struct target_desc): Add in pauth.
4243         (aarch64_read_description): Add pauth param.
4244         (aarch64_gdbarch_init): Likewise.
4245         * aarch64-tdep.h (aarch64_read_description): Likewise.
4246         * arch/aarch64.c (aarch64_create_target_description): Likewise.
4247         * arch/aarch64.h (aarch64_create_target_description): Likewise.
4248         * features/Makefile: Add new files.
4249         * features/aarch64-pauth.c: New file.
4250         * features/aarch64-pauth.xml: New file.
4251
4252 2019-03-20  Tom Tromey  <tromey@adacore.com>
4253
4254         * infrun.c (handle_inferior_event): Rename from
4255         handle_inferior_event_1.  Create a scoped_value_mark.
4256         (handle_inferior_event): Remove.
4257
4258 2019-03-19  Tom Tromey  <tromey@adacore.com>
4259
4260         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
4261         * infrun.h (print_stop_event): Add "displays" parameter.
4262         * infrun.c (print_stop_event): Add "displays" parameter.
4263
4264 2019-03-19  Pedro Alves  <palves@redhat.com>
4265
4266         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
4267         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
4268         to -1.  Fix TABs vs spaces.
4269         (tui_ui_out::tui_ui_out): Don't initialize fields here.
4270         * tui/tui-out.h (tui_ui_out) Add intro comments.
4271         <m_line, m_start_of_line>: In-class initialize, and add describing
4272         comment.
4273
4274 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
4275
4276         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
4277         variable names.
4278         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
4279
4280 2019-03-18  Pedro Alves  <palves@redhat.com>
4281             Eli Zaretskii <eliz@gnu.org>
4282
4283         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
4284         m_line and m_start_of_line.
4285
4286 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
4287
4288         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
4289         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
4290         it returns a newline.  This fixes a regression in TU mode, whereby
4291         the next line is output on the same screen line as the user input.
4292
4293 2019-03-18  Tom Tromey  <tromey@adacore.com>
4294
4295         * minsyms.c (minimal_symbol_reader::install): Remove call to
4296         obstack_blank.
4297
4298 2019-03-18  Pedro Alves  <palves@redhat.com>
4299
4300         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
4301         New globals.
4302         (apply_style): New, factored out from ...
4303         (apply_ansi_escape): ... this.  Handle reverse video mode.
4304         (tui_set_reverse_mode): New function.
4305         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
4306         * tui/tui-winsource.c (tui_show_source_line): Use
4307         tui_set_reverse_mode instead of setting A_STANDOUT.
4308         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
4309         New setter methods.
4310
4311 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
4312
4313         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
4314         Handle tabs.
4315
4316 2019-03-18  Tom Tromey  <tromey@adacore.com>
4317
4318         * ada-lang.c (empty_array): Add "high" parameter.
4319         (ada_evaluate_subexp): Update.
4320
4321 2019-03-17  Sergei Trofimovich <siarheit@google.com>
4322
4323         * unittests/string_view-selftests.c: Define
4324         _initialize_string_view_selftests unconditionally.
4325
4326 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4327
4328         PR gdb/24350
4329         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
4330
4331 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
4332
4333         PR gdb/24351
4334         * windows-nat.c (display_selector): Fix format specifiers.
4335
4336 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
4337
4338         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
4339         tui_refill_source_window instead of tui_refresh_win, to update the
4340         current execution line.  This fixes redisplay of the current line
4341         when stepping through the code with "next" or "step".
4342
4343 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4344
4345         * source-cache.c (source_cache::get_source_lines): Call
4346         find_source_lines to initialize s->nlines.  This fixes vertical
4347         scrolling of TUI source window when the DOWN arrow is pressed.
4348
4349 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4350
4351         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
4352         linux-thread-db.c (_initialize_thread_db): Likewise.
4353
4354 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
4355
4356         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
4357         wclrtoeol in tui_show_source_line".  This reverts changes made in
4358         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
4359
4360 2019-03-15  Tom Tromey  <tom@tromey.com>
4361
4362         * symtab.h (struct minimal_symbol): Derive from
4363         general_symbol_info.
4364         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
4365         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
4366         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
4367         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
4368         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
4369         (MSYMBOL_SEARCH_NAME): Update.
4370         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
4371         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
4372         * minsyms.c (minimal_symbol_reader::record_full): Update.
4373
4374 2019-03-15  Tom Tromey  <tom@tromey.com>
4375
4376         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
4377
4378 2019-03-15  Tom Tromey  <tom@tromey.com>
4379
4380         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
4381         unique_xmalloc_ptr.
4382         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
4383         Update.
4384         * minsyms.c (lookup_minimal_symbol_by_pc_section)
4385         (build_minimal_symbol_hash_tables)
4386         (minimal_symbol_reader::install): Update.
4387
4388 2019-03-15  Tom Tromey  <tom@tromey.com>
4389
4390         * symtab.c (create_demangled_names_hash): Update.
4391         (symbol_set_names): Update.
4392         * objfiles.h (struct objfile_per_bfd_storage)
4393         <demangled_names_hash>: Now an htab_up.
4394         * objfiles.c (objfile_per_bfd_storage): Simplify.
4395
4396 2019-03-15  Tom Tromey  <tom@tromey.com>
4397
4398         * objfiles.h (struct objfile_per_bfd_storage): Declare
4399         destructor.
4400         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
4401         New.
4402         (get_objfile_bfd_data): Use new.  Don't initialize
4403         language_of_main.
4404         (free_objfile_per_bfd_storage): Remove.
4405         (objfile_bfd_data_free, objfile::~objfile): Use delete.
4406
4407 2019-03-15  Tom Tromey  <tom@tromey.com>
4408
4409         * symfile.c (reread_symbols): Update.
4410         * objfiles.c (objfile::objfile): Update.
4411         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
4412         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
4413         comment.
4414         (minimal_symbol_reader::install): Update.
4415         (terminate_minimal_symbol_table): Remove.
4416         * jit.c (jit_object_close_impl): Update.
4417
4418 2019-03-15  Tom Tromey  <tom@tromey.com>
4419
4420         * minsyms.c (minimal_symbol_reader::record_full): Remove some
4421         initializations.
4422
4423 2019-03-15  Tom Tromey  <tom@tromey.com>
4424
4425         * objfiles.h (struct objfile_per_bfd_storage)
4426         <demangled_hash_languages>: Now a bitset.
4427         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
4428         (lookup_minimal_symbol): Update.
4429
4430 2019-03-15  Tom Tromey  <tom@tromey.com>
4431
4432         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
4433         Don't return the symbol.
4434         * coffread.c (record_minimal_symbol): Use record_full.
4435
4436 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
4437
4438         The MS-Windows port of ncurses fails to switch to a color pair if
4439         one or both of the colors are the implicit default colors.  This
4440         change records the default colors when TUI is initialized, and
4441         then specifies them explicitly when a color pair uses the default
4442         colors.  This allows color styling in TUI mode on MS-Windows.
4443
4444         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
4445         ncurses_norm_attr.
4446         (tui_initialize_io) [__MINGW32__]: Record the default terminal
4447         colors in ncurses_norm_attr.
4448         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
4449         "none", replace it with the default color recorded in
4450         ncurses_norm_attr.
4451
4452 2019-03-14  Tom Tromey  <tromey@adacore.com>
4453
4454         * source-cache.h (class source_cache) <get_source_lines>: Return
4455         std::string.
4456         * source-cache.c (source_cache::extract_lines): Handle case where
4457         first_pos==npos.  Return std::string.
4458         (source_cache::get_source_lines): Update.
4459
4460 2019-03-14  Tom Tromey  <tromey@adacore.com>
4461
4462         * NEWS: Add item for "style sources" commands.
4463         * source-cache.c (source_cache::get_source_lines): Check
4464         source_styling.
4465         * cli/cli-style.c (source_styling): New global.
4466         (_initialize_cli_style): Add "style sources" commands.
4467         (show_style_sources): New function.
4468         * cli/cli-style.h (source_styling): Declare.
4469
4470 2019-03-14  Pedro Alves  <palves@redhat.com>
4471             Tom Tromey  <tromey@adacore.com>
4472
4473         * tui/tui-winsource.h (tui_refill_source_window): Declare.
4474         * tui/tui-winsource.c (tui_refill_source_window): New function,
4475         from...
4476         (tui_horizontal_source_scroll): ... here.  Move some logic.
4477         * cli/cli-style.c (set_style_enabled): Notify new observable.
4478         * tui/tui-hooks.c (tui_redisplay_source): New function.
4479         (tui_attach_detach_observers): Attach or detach
4480         tui_redisplay_source.
4481         * observable.h (source_styling_changed): New observable.
4482         * observable.c: Define source_styling_changed observable.
4483
4484 2019-03-13  Tom Tromey  <tromey@adacore.com>
4485
4486         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
4487         (i386_gnu_nat_target::store_registers): Update.
4488         * target-debug.h (target_debug_print_std_string): New macro.
4489         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
4490         * windows-tdep.c (display_one_tib): Update.
4491         * tui/tui-stack.c (tui_make_status_line): Update.
4492         * top.c (print_inferior_quit_action): Update.
4493         * thread.c (thr_try_catch_cmd): Update.
4494         (add_thread_with_info): Update.
4495         (thread_target_id_str): Update.
4496         (thr_try_catch_cmd): Update.
4497         (thread_command): Update.
4498         (thread_find_command): Update.
4499         * record-btrace.c (record_btrace_target::info_record)
4500         (record_btrace_resume_thread, record_btrace_target::resume)
4501         (record_btrace_cancel_resume, record_btrace_step_thread)
4502         (record_btrace_target::wait, record_btrace_target::wait)
4503         (record_btrace_target::wait, record_btrace_target::stop): Update.
4504         * progspace.c (print_program_space): Update.
4505         * process-stratum-target.c
4506         (process_stratum_target::thread_address_space): Update.
4507         * linux-fork.c (linux_fork_mourn_inferior)
4508         (detach_checkpoint_command, info_checkpoints_command)
4509         (linux_fork_context): Update.
4510         (linux_fork_detach): Update.
4511         (class scoped_switch_fork_info): Update.
4512         (delete_checkpoint_command): Update.
4513         * infrun.c (follow_fork_inferior): Update.
4514         (follow_fork_inferior): Update.
4515         (proceed_after_vfork_done): Update.
4516         (handle_vfork_child_exec_or_exit): Update.
4517         (follow_exec): Update.
4518         (displaced_step_prepare_throw): Update.
4519         (displaced_step_restore): Update.
4520         (start_step_over): Update.
4521         (resume_1): Update.
4522         (clear_proceed_status_thread): Update.
4523         (proceed): Update.
4524         (print_target_wait_results): Update.
4525         (do_target_wait): Update.
4526         (context_switch): Update.
4527         (stop_all_threads): Update.
4528         (restart_threads): Update.
4529         (finish_step_over): Update.
4530         (handle_signal_stop): Update.
4531         (switch_back_to_stepped_thread): Update.
4532         (keep_going_pass_signal): Update.
4533         (print_exited_reason): Update.
4534         (normal_stop): Update.
4535         * inferior.c (inferior_pid_to_str): Change return type.
4536         (print_selected_inferior): Update.
4537         (add_inferior): Update.
4538         (detach_inferior): Update.
4539         * dummy-frame.c (fprint_dummy_frames): Update.
4540         * dcache.c (dcache_info_1): Update.
4541         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
4542         (btrace_fetch, btrace_clear): Update.
4543         * linux-tdep.c (linux_core_pid_to_str): Change return type.
4544         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
4545         type.
4546         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
4547         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
4548         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
4549         * gdbarch.c, gdbarch.h: Rebuild.
4550         * gdbarch.sh (core_pid_to_str): Change return type.
4551         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
4552         return type.
4553         (windows_nat_target::pid_to_str): Change return type.
4554         (windows_delete_thread): Update.
4555         (windows_nat_target::attach): Update.
4556         (windows_nat_target::files_info): Update.
4557         * target-delegates.c: Rebuild.
4558         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
4559         return type.
4560         (sol_thread_target::pid_to_str): Change return type.
4561         * remote.c (class remote_target) <pid_to_str>: Change return
4562         type.
4563         (remote_target::pid_to_str): Change return type.
4564         (extended_remote_target::attach, remote_target::remote_stop_ns)
4565         (remote_target::remote_notif_remove_queued_reply)
4566         (remote_target::push_stop_reply, remote_target::disable_btrace):
4567         Update.
4568         (extended_remote_target::attach): Update.
4569         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
4570         type.
4571         (gdbsim_target::pid_to_str): Change return type.
4572         * ravenscar-thread.c (struct ravenscar_thread_target)
4573         <pid_to_str>: Change return type.
4574         (ravenscar_thread_target::pid_to_str): Change return type.
4575         * procfs.c (class procfs_target) <pid_to_str>: Change return
4576         type.
4577         (procfs_target::pid_to_str): Change return type.
4578         (procfs_target::attach): Update.
4579         (procfs_target::detach): Update.
4580         (procfs_target::fetch_registers): Update.
4581         (procfs_target::store_registers): Update.
4582         (procfs_target::wait): Update.
4583         (procfs_target::files_info): Update.
4584         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
4585         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
4586         return type.
4587         (nto_procfs_target::pid_to_str): Change return type.
4588         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
4589         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
4590         return type.
4591         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
4592         (exit_lwp): Update.
4593         (attach_proc_task_lwp_callback, get_detach_signal)
4594         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
4595         (linux_nat_target::resume, wait_lwp, stop_callback)
4596         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
4597         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
4598         (linux_nat_wait_1, resume_stopped_resumed_lwps)
4599         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
4600         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
4601         type.
4602         (inf_ptrace_target::attach): Update.
4603         (inf_ptrace_target::files_info): Update.
4604         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
4605         type.
4606         (go32_nat_target::pid_to_str): Change return type.
4607         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
4608         (gnu_nat_target::wait): Update.
4609         (gnu_nat_target::wait): Update.
4610         (gnu_nat_target::resume): Update.
4611         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
4612         (fbsd_nat_target::wait): Update.
4613         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
4614         type.
4615         (darwin_nat_target::attach): Update.
4616         * corelow.c (class core_target) <pid_to_str>: Change return type.
4617         (core_target::pid_to_str): Change return type.
4618         * target.c (normal_pid_to_str): Change return type.
4619         (default_pid_to_str): Likewise.
4620         (target_pid_to_str): Change return type.
4621         (target_translate_tls_address): Update.
4622         (target_announce_detach): Update.
4623         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
4624         return type.
4625         (bsd_uthread_target::pid_to_str): Change return type.
4626         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
4627         type.
4628         (bsd_kvm_target::pid_to_str): Change return type.
4629         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
4630         return type.
4631         (aix_thread_target::pid_to_str): Change return type.
4632         * target.h (struct target_ops) <pid_to_str>: Change return type.
4633         (target_pid_to_str, normal_pid_to_str): Likewise.
4634         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
4635         type.
4636         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
4637         type.
4638         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
4639         return type.
4640         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
4641         type.
4642         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
4643         type.
4644         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
4645         return type.
4646
4647 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
4648
4649         * NEWS: Mention that the new default MI version is 3.  Mention
4650         changes to the output of commands and events that deal with
4651         multi-location breakpoints.
4652         * breakpoint.c: Include "mi/mi-out.h".
4653         (print_one_breakpoint): Change output syntax if using MI version
4654         >= 3.
4655         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
4656         New.
4657         (mi_multi_location_breakpoint_output_fixed): New.
4658         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
4659         (mi_cmd_fix_multi_location_breakpoint_output): New.
4660         (mi_multi_location_breakpoint_output_fixed): New.
4661         * mi/mi-cmds.c (mi_cmds): Register command
4662         -fix-multi-location-breakpoint-output.
4663         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
4664         interpreter "mi".
4665
4666 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
4667
4668         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
4669         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
4670         instantiate mi_ui_out based on interpreter name.
4671         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
4672         * mi/mi-main.c (mi_load_progress): Likewise.
4673
4674 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4675
4676         * NEWS: Combine separate "New targets" sections for 8.3.
4677
4678 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4679
4680         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
4681         (ppcfbsd_init_abi): Install gdbarch
4682         "fetch_tls_load_module_address" and "get_thread_local_address"
4683         methods.
4684
4685 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4686
4687         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
4688         (riscv_fbsd_init_abi): Install gdbarch
4689         "fetch_tls_load_module_address" and "get_thread_local_address"
4690         methods.
4691
4692 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4693
4694         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
4695         (i386fbsd_init_abi): Install gdbarch
4696         "fetch_tls_load_module_address" and "get_thread_local_address"
4697         methods.
4698
4699 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4700
4701         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
4702         (amd64fbsd_init_abi): Install gdbarch
4703         "fetch_tls_load_module_address" and "get_thread_local_address"
4704         methods.
4705
4706 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4707
4708         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
4709         (struct fbsd_pspace_data): New type.
4710         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
4711         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
4712         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
4713         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
4714         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
4715
4716 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4717
4718         * gdbtypes.c (lookup_struct_elt): New function.
4719         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
4720         * gdbtypes.h (struct struct_elt): New type.
4721         (lookup_struct_elt): New prototype.
4722
4723 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4724
4725         * gdbtypes.c (lookup_struct_elt_type): Update comment and
4726         remove disabled code block.
4727
4728 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4729
4730         * gdbarch.sh (get_thread_local_address): New method.
4731         * gdbarch.h, gdbarch.c: Regenerate.
4732         * target.c (target_translate_tls_address): Use
4733         gdbarch_get_thread_local_address if present instead of
4734         target::get_thread_local_address.
4735
4736 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4737
4738         * target.h (target::get_thread_local_address): Update comment.
4739
4740 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4741
4742         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
4743         objfile->separate_debug_objfile_backlink if not NULL.
4744
4745 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4746
4747         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
4748         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
4749         (amd64bsd_store_inferior_registers): Likewise.
4750         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4751         Enable segment base registers.
4752         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
4753         PT_GETFSBASE and PT_GETGSBASE.
4754         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
4755         PT_SETGSBASE.
4756         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
4757         segment base registers.
4758         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4759
4760 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
4761
4762         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
4763         Update calls to i386_target_description to add 'segments'
4764         parameter.
4765         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
4766         add segment base registers.
4767         * arch/i386.c (i386_create_target_description): Add 'segments'
4768         parameter to enable segment base registers.
4769         * arch/i386.h (i386_create_target_description): Likewise.
4770         * features/i386/32bit-segments.xml: New file.
4771         * features/i386/32bit-segments.c: Generate.
4772         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
4773         call to i386_target_description to add 'segments' parameter.
4774         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
4775         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
4776         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
4777         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
4778         if feature is present.
4779         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
4780         Add 'segments' parameter to call to i386_target_description.
4781         (i386_target_description): Add 'segments' parameter to enable
4782         segment base registers.
4783         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
4784         to call to i386_target_description.
4785         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
4786         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
4787         Define I386_NUM_REGS.
4788         (i386_target_description): Add 'segments' parameter to enable
4789         segment base registers.
4790
4791 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
4792
4793         PR/24325
4794         * source-cache.c: #undef open and close, to avoid unresolved
4795         externals during linking.
4796
4797 2019-03-12  Tom Tromey  <tromey@adacore.com>
4798
4799         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
4800         const.  Add initializers.
4801         (_initialize_remote): Don't initialize ptid globals.
4802
4803 2019-03-12  Pedro Alves  <palves@redhat.com>
4804
4805         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
4806
4807 2019-03-12  Pedro Alves  <palves@redhat.com>
4808
4809         * cp-name-parser.y (main): Remove unused 'len' variable.
4810
4811 2019-03-12  Tom Tromey  <tromey@adacore.com>
4812
4813         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
4814         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
4815
4816 2019-03-12  Tom Tromey  <tromey@adacore.com>
4817
4818         * linux-nat.c (iterate_over_lwps): Update.
4819         (stop_callback): Remove parameter.
4820         (stop_wait_callback, detach_callback, resume_set_callback)
4821         (select_singlestep_lwp_callback, set_ignore_sigint)
4822         (status_callback, resumed_callback, resume_clear_callback)
4823         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
4824         data parameter.
4825         (linux_nat_target::detach, linux_nat_target::resume)
4826         (linux_stop_and_wait_all_lwps, select_event_lwp)
4827         (linux_nat_filter_event, linux_nat_wait_1)
4828         (linux_nat_target::kill, linux_nat_target::stop)
4829         (linux_nat_target::stop): Update.
4830         (linux_nat_resume_callback): Change type.
4831         (resume_stopped_resumed_lwps, count_events_callback)
4832         (select_event_lwp_callback): Likewise.
4833         (linux_stop_lwp, linux_nat_stop_lwp): Update.
4834         * arm-linux-nat.c (struct update_registers_data): Remove.
4835         (update_registers_callback): Change type.
4836         (arm_linux_insert_hw_breakpoint1): Update.
4837         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
4838         parameter.
4839         (x86_linux_dr_set_addr): Update.
4840         (x86_linux_dr_set_control): Update.
4841         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
4842         (iterate_over_lwps): Use gdb::function_view.
4843         * nat/aarch64-linux-hw-point.c (struct
4844         aarch64_dr_update_callback_param): Remove.
4845         (debug_reg_change_callback): Change type.
4846         (aarch64_notify_debug_reg_change): Update.
4847         * s390-linux-nat.c (s390_refresh_per_info): Update.
4848
4849 2019-03-11  Tom Tromey  <tromey@adacore.com>
4850
4851         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
4852         redundant assignment to "this_cu".
4853
4854 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4855
4856         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
4857
4858 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4859
4860         * gdbtypes.c (rank_one_type_parm_set): New function extracted
4861         from...
4862         (rank_one_type): ... this.
4863
4864 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4865
4866         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
4867         from...
4868         (rank_one_type): ... this.
4869
4870 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4871
4872         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
4873         from...
4874         (rank_one_type): ... this.
4875
4876 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4877
4878         * gdbtypes.c (rank_one_type_parm_float): New function extracted
4879         from...
4880         (rank_one_type): ... this.
4881
4882 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4883
4884         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
4885         from...
4886         (rank_one_type): ... this.
4887
4888 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4889
4890         * gdbtypes.c (rank_one_type_parm_range): New function extracted
4891         from...
4892         (rank_one_type): ... this.
4893
4894 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4895
4896         * gdbtypes.c (rank_one_type_parm_char): New function extracted
4897         from...
4898         (rank_one_type): ... this.
4899
4900 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4901
4902         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
4903         from...
4904         (rank_one_type): ... this.
4905
4906 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4907
4908         * gdbtypes.c (rank_one_type_parm_int): New function extracted
4909         from...
4910         (rank_one_type): ... this.
4911
4912 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4913
4914         * gdbtypes.c (rank_one_type_parm_func): New function extracted
4915         from...
4916         (rank_one_type): ... this.
4917
4918 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4919
4920         * gdbtypes.c (rank_one_type_parm_array): New function extracted
4921         from...
4922         (rank_one_type): ... this.
4923
4924 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
4925
4926         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
4927         from...
4928         (rank_one_type): ... this.
4929
4930 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4931
4932         * inferior.c (initialize_inferiors): Ensure 'help set/show print
4933         inferior-events' shows the example events.
4934
4935 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
4936
4937         Support styling on native MS-Windows console
4938
4939         PR/24315
4940         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
4941         on MS-Windows if $TERM is not defined.
4942
4943         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
4944
4945         * posix-hdep.c (gdb_console_fputs):
4946         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
4947         functions.
4948         * ui-file.h (gdb_console_fputs): Add prototype.
4949
4950         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
4951         back to fputs only if the former returns zero.
4952
4953 2019-03-07  Tom Tromey  <tom@tromey.com>
4954
4955         * symmisc.c (print_symbol_bcache_statistics): Update.
4956         (print_objfile_statistics): Update.
4957         * symfile.c (allocate_symtab): Update.
4958         * stabsread.c: Don't include bcache.h.
4959         * psymtab.h (struct psymbol_bcache): Don't declare.
4960         (class psymtab_storage) <psymbol_cache>: Now a bcache.
4961         (psymbol_bcache_init, psymbol_bcache_free)
4962         (psymbol_bcache_get_bcache): Don't declare.
4963         * psymtab.c (struct psymbol_bcache): Remove.
4964         (psymtab_storage::psymtab_storage): Update.
4965         (psymtab_storage::~psymtab_storage): Update.
4966         (psymbol_bcache_init, psymbol_bcache_free)
4967         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
4968         (add_psymbol_to_bcache): Update.
4969         (allocate_psymtab): Update.
4970         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
4971         macro_cache>: No longer pointers.
4972         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
4973         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
4974         * macrotab.c (macro_bcache): Update.
4975         * macroexp.c: Don't include bcache.h.
4976         * gdbtypes.c (check_types_worklist): Update.
4977         (types_deeply_equal): Remove TRY/CATCH.  Update.
4978         * elfread.c (elf_symtab_read): Update.
4979         * dwarf2read.c: Don't include bcache.h.
4980         * buildsym.c (buildsym_compunit::get_macro_table): Update.
4981         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
4982         (print_bcache_statistics, bcache_memory_used): Don't declare.
4983         (struct bcache): Move from bcache.c.  Add constructor, destructor,
4984         methods.  Rename all data members.
4985         * bcache.c (struct bcache): Move to bcache.h.
4986         (bcache::expand_hash_table): Rename from expand_hash_table.
4987         (bcache): Remove.
4988         (bcache::insert): Rename from bcache_full.
4989         (bcache::compare): Rename from bcache_compare.
4990         (bcache_xmalloc): Remove.
4991         (bcache::~bcache): Rename from bcache_xfree.
4992         (bcache::print_statistics): Rename from print_bcache_statistics.
4993         (bcache::memory_used): Rename from bcache_memory_used.
4994
4995 2019-03-07  Pedro Alves  <palves@redhat.com>
4996
4997         * infrun.c (normal_stop): Also check for
4998         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
4999
5000 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
5001
5002         * f-lang.c (value_from_host_double): Moved to...
5003         * value.c (value_from_host_double): ...here.
5004         * value.h (value_from_host_double): Declare.
5005         * guile/scm-math.c (vlscm_convert_typed_number): Use
5006         value_from_host_double.
5007         (vlscm_convert_number): Likewise.
5008         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
5009         * python/py-value.c (convert_value_from_python): Likewise.
5010
5011 2019-03-06  Tom Tromey  <tom@tromey.com>
5012
5013         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
5014
5015 2019-03-06  Tom Tromey  <tom@tromey.com>
5016
5017         * utils.h (free_current_contents): Don't declare.
5018         * utils.c (free_current_contents): Remove.
5019
5020 2019-03-06  Tom Tromey  <tom@tromey.com>
5021
5022         * top.c (quit_force): Update.
5023         * main.c (captured_command_loop): Update.
5024         * common/new-op.c (operator new): Update.
5025         * common/common-exceptions.c (struct catcher)
5026         <save_cleanup_chain>: Remove member.
5027         (exceptions_state_mc_init): Update.
5028         (exception_try_scope_entry): Return nullptr.
5029         (exception_try_scope_exit, exception_rethrow)
5030         (throw_exception_sjlj, throw_exception_cxx): Update.
5031         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
5032         (all_cleanups, do_cleanups, discard_cleanups)
5033         (discard_final_cleanups, save_cleanups, save_final_cleanups)
5034         (restore_cleanups, restore_final_cleanups): Don't declare.
5035         (do_final_cleanups): Remove parameter.
5036         * common/cleanups.c (cleanup_chain, make_cleanup)
5037         (make_cleanup_dtor, all_cleanups, do_cleanups)
5038         (discard_my_cleanups, discard_cleanups)
5039         (discard_final_cleanups, save_my_cleanups, save_cleanups)
5040         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
5041         (null_cleanup): Remove.
5042         (do_final_cleanups): Remove parameter.
5043
5044 2019-03-06  Tom Tromey  <tom@tromey.com>
5045
5046         * remote.c (remote_target::remote_parse_stop_reply): Use
5047         unique_xmalloc_ptr.
5048
5049 2019-03-06  Tom Tromey  <tom@tromey.com>
5050
5051         * stabsread.c (struct stabs_field_info): Rename from field_info.
5052         <list, fnlist>: Add initializers.
5053         <obstack>: New member.
5054         (read_member_functions, read_struct_fields, read_baseclasses):
5055         Allocate on obstack.  Don't use cleanups.
5056         (read_one_struct_field, read_member_functions, read_struct_fields)
5057         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
5058         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
5059         (read_struct_type): Update.
5060
5061 2019-03-06  Tom Tromey  <tom@tromey.com>
5062
5063         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
5064         * common/filestuff.h (make_cleanup_close): Don't declare.
5065         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
5066         Remove.
5067
5068 2019-03-06  Tom Tromey  <tom@tromey.com>
5069
5070         * solib-aix.c: Use make_scope_exit.
5071
5072 2019-03-06  Tom Tromey  <tom@tromey.com>
5073
5074         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
5075         Use make_scope_exit.
5076
5077 2019-03-06  Tom Tromey  <tom@tromey.com>
5078
5079         * solib-svr4.c (disable_probes_interface): Remove parameter.
5080         (svr4_handle_solib_event): Use make_scope_exit.
5081
5082 2019-03-06  Tom Tromey  <tom@tromey.com>
5083
5084         * remote.c (struct stop_reply_deleter): Remove.
5085         (stop_reply_up): Update.
5086         (struct stop_reply): Derive from notif_event.  Don't typedef.
5087         <regcache>: Now a std::vector.
5088         (stop_reply_xfree): Remove.
5089         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
5090         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
5091         (remote_target::discard_pending_stop_replies): Use delete.
5092         (remote_target::remote_parse_stop_reply): Update.
5093         (remote_target::process_stop_reply): Update.
5094         * remote-notif.h (struct notif_event): Add virtual destructor.
5095         Remove "dtr" member.
5096         (struct notif_client) <alloc_event>: Return a unique_ptr.
5097         (notif_event_xfree): Don't declare.
5098         (notif_event_up): New typedef.
5099         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
5100         (notif_event_xfree, do_notif_event_xfree): Remove.
5101         (remote_notif_state_xfree): Update.
5102
5103 2019-03-06  Tom Tromey  <tom@tromey.com>
5104
5105         * infrun.c (displaced_step_clear_cleanup): Now a
5106         forward_scope_exit type.
5107         (displaced_step_prepare_throw): Update.
5108         (displaced_step_fixup): Update.
5109
5110 2019-03-06  Tom Tromey  <tom@tromey.com>
5111
5112         * inferior.h (class inferior): Update comment.
5113         * gdbthread.h (class thread_info): Update comment.
5114
5115 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
5116             Tom Tromey  <tom@tromey.com>
5117
5118         * stabsread.h (struct stab_section_list): Remove.
5119         (coffstab_build_psymtabs): Update.
5120         * dbxread.c (symbuf_sections): Now a std::vector.
5121         (sect_idx): New global.
5122         (fill_symbuf): Update.
5123         (coffstab_build_psymtabs): Change type of stabsects parameter.
5124         Update.
5125         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
5126         std::vector.
5127         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
5128         (coff_locate_sections): Update.
5129         (coff_symfile_read): Remove cleanups.  Update.
5130         (init_stringtab): Add storage parameter.
5131         (free_stringtab, free_stringtab_cleanup): Remove.
5132         (init_lineno): Add storage parameter.
5133         (free_linetab, free_linetab_cleanup): Remove.
5134
5135 2019-03-06  Pedro Alves  <palves@redhat.com>
5136
5137         * linux-fork.c (fork_info::clobber_regs): Delete.
5138         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
5139         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
5140         comment.  Adjust.
5141         (scoped_switch_fork_info::scoped_switch_fork_info)
5142         (checkpoint_command, linux_fork_context): Adjust
5143         fork_save_infrun_state calls.
5144
5145 2019-03-06  Pedro Alves  <palves@redhat.com>
5146
5147         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
5148         (inf_has_multiple_threads): Return 'bool' and rewrite using
5149         inferior_info::threads().
5150
5151 2019-03-06  Pedro Alves  <palves@redhat.com>
5152
5153         * linux-fork.c: Include <list>.
5154         (fork_list): Now a std::list instance.
5155         (fork_info): Add ctor, dtor, and in-class initialize all fields.
5156         (forks_exist_p, find_last_fork): Adjust.
5157         (new_fork): Delete.
5158         (one_fork_p): New.
5159         (add_fork): Adjust.
5160         (free_fork): Delete, folded into fork_info::~fork_info().
5161         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
5162         Adjust.
5163         (init_fork_list): Delete.
5164         (linux_fork_killall, linux_fork_mourn_inferior)
5165         (linux_fork_detach, info_checkpoints_command): Adjust.
5166         (_initialize_linux_fork): No longer call init_fork_list.
5167
5168 2019-03-06  Pedro Alves  <palves@redhat.com>
5169
5170         * linux-fork.c (new_fork): New, split out of ...
5171         (add_fork): ... this.  Return void.  Move "first fork" special
5172         case from here, to ...
5173         (checkpoint_command): ... here.
5174         * linux-linux.h (add_fork): Return void.
5175
5176 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5177
5178         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
5179
5180 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5181             Chris January  <chris.january@arm.com>
5182             David Lecomber  <david.lecomber@arm.com>
5183
5184         * f-exp.y: New token, UNOP_INTRINSIC.
5185         (exp): New pattern using UNOP_INTRINSIC token.
5186         (f77_keywords): Add 'abs' keyword.
5187         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
5188         (value_from_host_double): New function.
5189         (evaluate_subexp_f): Support UNOP_ABS.
5190
5191 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5192
5193         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
5194         types.
5195
5196 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5197
5198         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
5199         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
5200         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
5201
5202 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5203
5204         * f-exp.y (convert_to_kind_type): Handle more type kinds.
5205
5206 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5207             Chris January  <chris.january@arm.com>
5208
5209         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
5210         * f-exp.y: Define 'KIND' token.
5211         (exp): New pattern for KIND expressions.
5212         (ptype): Handle types with a kind extension.
5213         (direct_abs_decl): Extend to spot kind extensions.
5214         (f77_keywords): Add 'kind' to the list.
5215         (push_kind_type): New function.
5216         (convert_to_kind_type): New function.
5217         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
5218         * parse.c (operator_length_standard): Likewise.
5219         * parser-defs.h (enum type_pieces): Add tp_kind.
5220         * std-operator.def: Add UNOP_KIND.
5221
5222 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5223
5224         * f-exp.y (f_parse): Set yydebug.
5225
5226 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * f-lang.c (evaluate_subexp_f): New function.
5229         (exp_descriptor_f): New global.
5230         (f_language_defn): Use exp_descriptor_f instead of
5231         exp_descriptor_standard.
5232
5233 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5234
5235         * f-exp.y (struct token): Add comments.
5236         (dot_ops): Remove uppercase versions and the end marker.
5237         (f77_keywords): Likewise.
5238         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
5239         entries in the dot_ops array are case insensitive, and use
5240         strncasecmp to compare strings.  Also some whitespace cleanup in
5241         this area.  Similar for the f77_keywords array, except entries in
5242         this list might be case sensitive.
5243
5244 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
5245
5246         * f-exp.y (struct f77_boolean_val): Add comments.
5247         (boolean_values): Remove uppercase versions, and end marker.
5248         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
5249         and use strncasecmp to achieve case insensitivity.  Additionally,
5250         perform whitespace cleanup around this code.
5251
5252 2019-03-06  Tom Tromey  <tromey@adacore.com>
5253
5254         * remote-sim.c (gdbsim_target_open): Use result of
5255         gdb_argv::release.
5256
5257 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
5258         Dirk Schubert  <dirk.schubert@arm.com>
5259         Chris January  <chris.january@arm.com>
5260
5261         * eval.c (evaluate_subexp_standard): Call Fortran argument
5262         wrapping logic.
5263         * f-lang.c (struct value): A value which can be passed into a
5264         Fortran function call.
5265         (fortran_argument_convert): Wrap Fortran arguments in a pointer
5266         where appropriate.
5267         (struct type): Value ready for a Fortran function call.
5268         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
5269         is needed.
5270         * f-lang.h (fortran_argument_convert): Declaration.
5271         (fortran_preserve_arg_pointer): Declaration.
5272         * infcall.c (value_arg_coerce): Call Fortran argument logic.
5273
5274 2019-03-05  Tom Tromey  <tromey@adacore.com>
5275
5276         * python/py-prettyprint.c (print_string_repr): Remove #if.
5277         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
5278
5279 2019-03-05  Tom Tromey  <tromey@adacore.com>
5280
5281         * target.c (the_dummy_target): Move later.  Change type to
5282         "dummy_target".
5283         (initialize_targets): Don't initialize the_dummy_target.
5284
5285 2019-03-05  Tom Tromey  <tromey@adacore.com>
5286
5287         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
5288         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
5289
5290 2019-03-05  Tom Tromey  <tromey@adacore.com>
5291
5292         * windows-nat.c (windows_nat_target::attach)
5293         (windows_nat_target::detach): Don't call gdb_flush.
5294         * valprint.c (generic_val_print, val_print, val_print_string):
5295         Don't call gdb_flush.
5296         * utils.c (defaulted_query): Don't call gdb_flush.
5297         * typeprint.c (print_type_scalar): Don't call gdb_flush.
5298         * target.c (target_announce_detach): Don't call gdb_flush.
5299         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
5300         * remote.c (extended_remote_target::attach): Don't call
5301         gdb_flush.
5302         * procfs.c (procfs_target::detach): Don't call gdb_flush.
5303         * printcmd.c (do_examine): Don't call gdb_flush.
5304         (info_display_command): Don't call gdb_flush.
5305         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
5306         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
5307         * memattr.c (info_mem_command): Don't call gdb_flush.
5308         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
5309         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
5310         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
5311         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
5312         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
5313         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
5314         (gnu_nat_target::detach): Don't call gdb_flush.
5315         * f-valprint.c (f_val_print): Don't call gdb_flush.
5316         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
5317         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
5318         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
5319         gdb_flush.
5320         * c-valprint.c (c_val_print): Don't call gdb_flush.
5321         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
5322
5323 2019-03-05  Tom Tromey  <tromey@adacore.com>
5324
5325         * varobj.c (update_dynamic_varobj_children): Update.
5326         (install_default_visualizer): Use reset, not release.
5327         * value.c (set_internalvar): Update.
5328         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
5329         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
5330         ATTRIBUTE_UNUSED_RESULT.
5331
5332 2019-03-05  Tom Tromey  <tromey@adacore.com>
5333
5334         * remote.c (class scoped_remote_fd) <release>: Add
5335         ATTRIBUTE_UNUSED_RESULT.
5336
5337 2019-03-05  Tom Tromey  <tromey@adacore.com>
5338
5339         * macroexp.c (struct macro_buffer) <release>: Add
5340         ATTRIBUTE_UNUSED_RESULT.
5341
5342 2019-03-05  Tom Tromey  <tromey@adacore.com>
5343
5344         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
5345         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
5346         ATTRIBUTE_UNUSED_RESULT.
5347
5348 2019-03-05  Tom Tromey  <tromey@adacore.com>
5349
5350         * common/scoped_fd.h (class scoped_fd) <release>: Add
5351         ATTRIBUTE_UNUSED_RESULT.
5352
5353 2019-03-05  Tom Tromey  <tromey@adacore.com>
5354
5355         * parser-defs.h (struct parser_state) <release>: Add
5356         ATTRIBUTE_UNUSED_RESULT.
5357
5358 2019-03-05  Tom Tromey  <tromey@adacore.com>
5359
5360         * utils.h (class gdb_argv) <release>: Add
5361         ATTRIBUTE_UNUSED_RESULT.
5362         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
5363
5364 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
5365
5366         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
5367         for-loop range, to avoid compiler warnings.
5368
5369         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
5370         avoid compiler warnings about unused variables.
5371
5372         * NEWS: Mention end of support for native debugging on MS-Windows
5373         before XP.
5374
5375         PR gdb/24292
5376         * common/netstuff.c:
5377         * gdbserver/gdbreplay.c
5378         * gdbserver/remote-utils.c:
5379         * ser-tcp.c:
5380         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
5381         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
5382         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
5383         'getaddrinfo' and 'freeaddrinfo' were not available before
5384         Windows XP, and mingw.org's MinGW headers by default define
5385         _WIN32_WINNT to 0x500.
5386
5387 2019-03-01  Gary Benson <gbenson@redhat.com>
5388
5389         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
5390
5391 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
5392             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
5393
5394         PR gdb/8527
5395         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
5396         set_sigint_trap, clear_sigint_trap.
5397
5398 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5399
5400         * target.c (target_detach): Clear the regcache and the
5401         frame cache.
5402
5403 2019-02-27  Pedro Alves  <palves@redhat.com>
5404
5405         * utils.c (set_screen_size): When we cap the height/width sizes,
5406         tweak the corresponding command variable to show "unlimited":
5407
5408 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
5409             Pedro Alves  <palves@redhat.com>
5410
5411         * utils.c (set_screen_size): Reduce "infinite" rows and columns
5412         before calling rl_set_screen_size.
5413
5414 2019-02-27  Tom Tromey  <tromey@adacore.com>
5415
5416         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
5417         define.
5418         * python/py-value.c: Remove Python 2.4 workaround.
5419         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
5420         workaround.
5421         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
5422         Python 2.4 workaround.
5423         * python/python-internal.h: Remove Python 2.4 comment.
5424         (Py_ssize_t): Don't define.
5425         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
5426         (gdb_Py_DECREF): Remove Python 2.4 workaround.
5427         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
5428         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
5429         * python/python.c (do_start_initialization): Remove Python 2.4
5430         workaround.
5431         * python/py-prettyprint.c (class dummy_python_frame): Remove.
5432         (print_children): Remove Python 2.4 workaround.
5433         * python/py-inferior.c (buffer_procs): Remove Python 2.4
5434         workaround.
5435         (CHARBUFFERPROC_NAME): Remove.
5436         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
5437         Python 2.4 workaround.
5438
5439 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5440
5441         * NEWS: Note minimum Python version.
5442
5443 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
5444
5445         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
5446         code from these functions.  Remove corresponding ifdefs.  Use
5447         Py_buffer_up instead of explicit calls to PyBuffer_Release.
5448         Remove gotos and target of gotos.
5449         (infpy_search_memory): Likewise.
5450
5451 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5452
5453         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
5454         (hppa_gdbarch_init): Don't register deleted functions with
5455         gdbarch.
5456
5457 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5458
5459         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
5460         (h8300_unwind_sp): Delete.
5461         (h8300_dummy_id): Delete.
5462         (h8300_gdbarch_init): Don't register deleted functions with
5463         gdbarch.
5464
5465 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5466
5467         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
5468         (ft32_unwind_pc): Delete.
5469         (ft32_unwind_sp): Delete.
5470         (ft32_gdbarch_init): Don't register deleted functions with
5471         gdbarch.
5472
5473 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5474
5475         * gdb/frv-tdep.c (frv_dummy_id): Delete.
5476         (frv_unwind_pc): Delete.
5477         (frv_unwind_sp): Delete.
5478         (frv_gdbarch_init): Don't register deleted functions with
5479         gdbarch.
5480
5481 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5482
5483         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
5484         (riscv_unwind_pc): Delete.
5485         (riscv_unwind_sp): Delete.
5486         (riscv_gdbarch_init): Don't register deleted functions with
5487         gdbarch.
5488
5489 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5490
5491         * gdb/csky-tdep.c (csky_dummy_id): Delete.
5492         (csky_unwind_pc): Delete.
5493         (csky_unwind_sp): Delete.
5494         (csky_gdbarch_init): Don't register deleted functions with
5495         gdbarch.
5496
5497 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5498
5499         * gdb/cris-tdep.c (cris_dummy_id): Delete.
5500         (cris_unwind_pc): Delete.
5501         (cris_unwind_sp): Delete.
5502         (cris_gdbarch_init): Don't register deleted functions with
5503         gdbarch.
5504
5505 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5506
5507         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
5508         (bfin_unwind_pc): Delete.
5509         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
5510
5511 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5512
5513         * gdb/arm-tdep.c (arm_dummy_id): Delete.
5514         (arm_unwind_pc): Delete.
5515         (arm_unwind_sp): Delete.
5516         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
5517
5518 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5519
5520         * gdb/arc-tdep.c (arc_dummy_id): Delete.
5521         (arc_unwind_pc): Delete.
5522         (arc_unwind_sp): Delete.
5523         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
5524
5525 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5526
5527         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
5528         (alpha_unwind_pc): Delete.
5529         (alpha_gdbarch_init): Don't register deleted functions with
5530         gdbarch.
5531
5532 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5533
5534         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
5535         (aarch64_unwind_pc): Delete.
5536         (aarch64_unwind_sp): Delete.
5537         (aarch64_gdbarch_init): Don't register deleted functions with
5538         gdbarch.
5539
5540 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5541
5542         * gdbtypes.c (type_align): Don't consider static members when
5543         computing structure alignment.
5544
5545 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5546
5547         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
5548         return 0 for other types.
5549         * arch-utils.c (default_type_align): Always return 0.
5550         * gdbarch.h: Regenerate.
5551         * gdbarch.sh (type_align): Extend comment.
5552         * gdbtypes.c (type_align): Add additional comments, always call
5553         gdbarch_type_align before applying the default rules.
5554         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
5555         generic code will then apply a suitable default.
5556         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
5557         types, return 0 for other types.
5558
5559 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5560
5561         * NEWS: Create a new section for the next release branch.
5562         Rename the section of the current branch, now that it has
5563         been cut.
5564
5565 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
5566
5567         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
5568         * version.in: Bump version to 8.3.50.DATE-git.
5569
5570 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
5571
5572         * aix-thread.c (ptid_cmp): Remove unused variable.
5573         (get_signaled_thread): Likewise.
5574         (store_regs_user_thread): Likewise.
5575         (store_regs_kernel_thread): Likewise.
5576         (fetch_regs_kernel_thread): Remove shadowed variable.
5577
5578 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
5579
5580         * features/riscv/32bit-cpu.xml: Add register numbers.
5581         * features/riscv/32bit-fpu.c: Regenerate.
5582         * features/riscv/32bit-fpu.xml: Add register numbers.
5583         * features/riscv/64bit-cpu.xml: Add register numbers.
5584         * features/riscv/64bit-fpu.c: Regenerate.
5585         * features/riscv/64bit-fpu.xml: Add register numbers.
5586
5587 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
5588
5589         * NEWS: Mention two argument form of gdb.Value constructor.
5590         * python/py-value.c (convert_buffer_and_type_to_value): New
5591         function.
5592         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
5593         Add support for handling an optional second argument.  Call
5594         convert_buffer_and_type_to_value as appropriate.
5595         * python/python-internal.h (Py_buffer_deleter): New struct.
5596         (Py_buffer_up): New typedef.
5597
5598 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
5599
5600         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
5601         instead of releasing ownership.
5602
5603 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
5604
5605         * dwarf2read.c (open_and_init_dwp_file): Call
5606         elf_numsections instead of bfd_count_sections to initialize
5607         dwp_file->num_sections.
5608
5609 2019-02-25  Tom Tromey  <tromey@adacore.com>
5610
5611         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
5612
5613 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5614
5615         * gcore.in: Add '--readnever' option when invoking GDB.
5616
5617 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5618
5619         * MAINTAINERS: Update my email address.
5620
5621 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
5622
5623         * build-id.c (build_id_to_debug_bfd_1): New function.
5624         (build_id_to_debug_bfd): Look for separate debug file in
5625         sysroot.
5626
5627 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5628
5629         * gdbarch.sh: Update the copyright year range that is placed into
5630         generated files.
5631
5632 2019-02-22  Keith Seitz  <keiths@redhat.com>
5633
5634         PR symtab/23853
5635         * linespec.c (create_sals_line_offset): Search for the default
5636         symtab's filename instead of its fullname.
5637
5638 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5639
5640         * NEWS: Update style defaults.
5641
5642 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
5643
5644         * main.c (captured_main_1): Disable styling in batch mode.
5645
5646 2019-02-20  Tom Tromey  <tom@tromey.com>
5647
5648         * symtab.c (symtab_symbol_info): Fix typos.
5649
5650 2019-02-20  Tom Tromey  <tromey@adacore.com>
5651
5652         * findcmd.c (_initialize_mem_search): Use upper case for
5653         metasyntactic variables.
5654
5655 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
5656
5657         * aarch64-tdep.c (aarch64_add_reggroups): New function.
5658         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
5659
5660 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
5661
5662         * top.h (source_file_name): Change to std::string.
5663         * top.c (source_file_name): Likewise.
5664         (command_line_input): Adjust.
5665         * cli/cli-script.c (script_from_file): Adjust.
5666
5667 2019-02-19  Tom Tromey  <tromey@adacore.com>
5668
5669         * ravenscar-thread.c
5670         (ravenscar_thread_target::update_thread_list): Don't call
5671         ada_build_task_list.
5672         * ada-lang.h (ada_build_task_list): Don't declare.
5673         * ada-tasks.c (struct ada_tasks_inferior_data)
5674         <task_list_valid_p>: Now bool.
5675         (read_known_tasks, ada_task_list_changed)
5676         (ada_tasks_invalidate_inferior_data): Update.
5677         (read_known_tasks_array): Return bool.
5678         (read_known_tasks_list): Likewise.
5679         (read_known_tasks): Return void.
5680         (ada_build_task_list): Now static.
5681
5682 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
5683
5684         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
5685         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
5686
5687 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5688
5689         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
5690         variant for ada_tasks_pspace_data_handle and
5691         ada_tasks_inferior_data_handle.
5692         (ada_tasks_pspace_data_cleanup): New function.
5693         (ada_tasks_inferior_data_cleanup): New function.
5694
5695 2019-02-17  Tom Tromey  <tom@tromey.com>
5696
5697         * macrotab.h (macro_source_fullname): Return a std::string.
5698         * macrotab.c (macro_include, check_for_redefinition)
5699         (macro_undef, macro_lookup_definition, foreach_macro)
5700         (foreach_macro_in_scope): Update.
5701         (macro_source_fullname): Return a std::string.
5702         * macrocmd.c (show_pp_source_pos): Update.
5703
5704 2019-02-17  Tom Tromey  <tom@tromey.com>
5705
5706         * macrocmd.c (show_pp_source_pos): Style the file names.
5707
5708 2019-02-17  Tom Tromey  <tom@tromey.com>
5709
5710         PR tui/24197:
5711         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
5712
5713 2019-02-17  Tom Tromey  <tom@tromey.com>
5714
5715         * ada-lang.c (user_select_syms): Use filtered printing.
5716         * utils.c (wrap_style): New global.
5717         (desired_style): Remove.
5718         (emit_style_escape): Add stream parameter.
5719         (set_output_style, reset_terminal_style, prompt_for_continue):
5720         Update.
5721         (flush_wrap_buffer): Only flush gdb_stdout.
5722         (wrap_here): Set wrap_style.
5723         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
5724         treat escape sequences as a character.  Change when wrap buffer is
5725         flushed.
5726         (fputs_styled): Do not set the output style when the default is
5727         requested.
5728         * ui-style.h (struct ui_file_style) <is_default>: New method.
5729         * source.c (print_source_lines_base): Emit escape sequences in one
5730         piece.
5731
5732 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5733
5734         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
5735         integers and enumeration types.
5736
5737 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
5738
5739         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
5740         instead of lookup_symbol_in_language
5741         (do_exact_match): New function.
5742         (ada_get_symbol_name_matcher): Return do_exact_match when
5743         doing a verbatim match.
5744
5745 2019-02-15  Tom Tromey  <tromey@adacore.com>
5746
5747         * ravenscar-thread.c (ravenscar_thread_target::resume)
5748         (ravenscar_thread_target::wait): Special case wildcard requests.
5749
5750 2019-02-15  Tom Tromey  <tromey@adacore.com>
5751
5752         * ravenscar-thread.c (base_ptid): Remove.
5753         (struct ravenscar_thread_target) <close>: New method.
5754         <m_base_ptid>: New member.
5755         <update_inferior_ptid, active_task, task_is_currently_active,
5756         runtime_initialized>: Declare methods.
5757         <ravenscar_thread_target>: Add constructor.
5758         (ravenscar_thread_target::task_is_currently_active)
5759         (ravenscar_thread_target::update_inferior_ptid)
5760         (ravenscar_runtime_initialized): Rename.  Now methods.
5761         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
5762         (ravenscar_thread_target::update_thread_list): Update.
5763         (ravenscar_thread_target::active_task): Now method.
5764         (ravenscar_thread_target::store_registers)
5765         (ravenscar_thread_target::prepare_to_store)
5766         (ravenscar_thread_target::prepare_to_store)
5767         (ravenscar_thread_target::mourn_inferior): Update.
5768         (ravenscar_inferior_created): Use "new" to create target.
5769         (ravenscar_thread_target::get_ada_task_ptid): Update.
5770         (_initialize_ravenscar): Don't initialize base_ptid.
5771         (ravenscar_ops): Remove global.
5772
5773 2019-02-15  Tom Tromey  <tromey@adacore.com>
5774
5775         * target.h (push_target): Declare new overload.
5776         * target.c (push_target): New overload, taking an rvalue reference.
5777         * remote.c (remote_target::open_1): Use push_target overload.
5778         * corelow.c (core_target_open): Use push_target overload.
5779
5780 2019-02-15  Tom Tromey  <tromey@adacore.com>
5781
5782         * ravenscar-thread.c (is_ravenscar_task)
5783         (ravenscar_task_is_currently_active): Return bool.
5784         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
5785         (_initialize_ravenscar): Remove "(void)".
5786         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
5787         Return bool.
5788
5789 2019-02-15  Tom Tromey  <tromey@adacore.com>
5790
5791         * ravenscar-thread.c (ravenscar_runtime_initializer)
5792         (has_ravenscar_runtime, get_running_thread_id)
5793         (ravenscar_thread_target::resume): Fix indentation.
5794
5795 2019-02-15  Tom Tromey  <tromey@adacore.com>
5796
5797         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
5798         from ravenscar_arch_ops.
5799         (sparc_ravenscar_ops::fetch_registers)
5800         (sparc_ravenscar_ops::store_registers): Now methods.
5801         (sparc_ravenscar_prepare_to_store): Remove.
5802         (sparc_ravenscar_ops): Redefine.
5803         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
5804         methods and destructor.  Remove members.
5805         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
5806         (ravenscar_thread_target::store_registers)
5807         (ravenscar_thread_target::prepare_to_store): Update.
5808         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
5809         Remove.
5810         (struct ppc_ravenscar_powerpc_ops): Derive from
5811         ravenscar_arch_ops.
5812         (ppc_ravenscar_powerpc_ops::fetch_registers)
5813         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
5814         (ppc_ravenscar_powerpc_ops): Redefine.
5815         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
5816         (ppc_ravenscar_e500_ops::fetch_registers)
5817         (ppc_ravenscar_e500_ops::store_registers): Now methods.
5818         (ppc_ravenscar_e500_ops): Redefine.
5819         * aarch64-ravenscar-thread.c
5820         (aarch64_ravenscar_generic_prepare_to_store): Remove.
5821         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
5822         (aarch64_ravenscar_fetch_registers)
5823         (aarch64_ravenscar_store_registers): Now methods.
5824         (aarch64_ravenscar_ops): Redefine.
5825
5826 2019-02-15  Tom Tromey  <tromey@adacore.com>
5827
5828         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
5829         (ravenscar_thread_target::stopped_by_hw_breakpoint)
5830         (ravenscar_thread_target::stopped_by_watchpoint)
5831         (ravenscar_thread_target::stopped_data_address)
5832         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
5833
5834 2019-02-15  Tom Tromey  <tromey@adacore.com>
5835
5836         * ravenscar-thread.c: Fix some typos.
5837
5838 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5839             Tom Tromey  <tromey@adacore.com>
5840
5841         * ada-lang.c (ada_exception_sal): Change addr_string to a
5842         std::string.
5843         (create_ada_exception_catchpoint): Update.
5844
5845 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5846             Tom Tromey  <tromey@adacore.com>
5847
5848         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
5849         (bp_location_ops): Remove.
5850         (base_breakpoint_allocate_location): Update.
5851         (free_bp_location): Update.
5852         * ada-lang.c (class ada_catchpoint_location)
5853         <ada_catchpoint_location>: Remove ops parameter.
5854         (ada_catchpoint_location_dtor): Remove.
5855         (ada_catchpoint_location_ops): Remove.
5856         (allocate_location_exception): Update.
5857         * breakpoint.h (struct bp_location_ops): Remove.
5858         (class bp_location) <bp_location>: Remove bp_location_ops
5859         parameter.
5860         <~bp_location>: Add destructor.
5861         <ops>: Remove.
5862
5863 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5864             Pedro Alves  <palves@redhat.com>
5865
5866         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
5867         'PATH_MAX'.
5868
5869 2019-02-14  David Michael  <fedora.dm0@gmail.com>
5870             Samuel Thibault  <samuel.thibault@gnu.org>
5871             Thomas Schwinge  <thomas@codesourcery.com>
5872
5873         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
5874         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
5875
5876 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
5877
5878         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
5879         (check_empty): Use "const char *".
5880
5881         * gnu-nat.c (gnu_nat_target::detach): Instead of
5882         'detach_inferior (pid)' call
5883         'detach_inferior (find_inferior_pid (pid))'.
5884
5885         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
5886         'nat/fork-inferior.o'.
5887         * gnu-nat.c: #include "nat/fork-inferior.h".
5888
5889         * gnu-nat.c (gnu_nat_target::detach): Instead of
5890         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
5891         * gnu-nat.h: #include "inf-child.h".
5892         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
5893         'i386_gnu_nat_target::fetch_registers'.
5894         (gnu_store_registers): Rename/move to
5895         'i386_gnu_nat_target::store_registers'.
5896
5897         * config/i386/nm-i386gnu.h: Don't "#include" any files.
5898         * gnu-nat.h (mach_thread_info): New function.
5899         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
5900
5901         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
5902
5903 2019-02-14  Frederic Konrad  <konrad@adacore.com>
5904
5905         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
5906
5907 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
5908
5909         * windows-nat.c (windows_add_thread): Add new parameter
5910         "main_thread_p" with default value set to false.  Update
5911         function documentation as well as all callers.
5912         (windows_delete_thread): Likewise.
5913         (fake_create_process): Update call to windows_add_thread.
5914         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
5915         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
5916         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
5917         call to windows_delete_thread.
5918
5919 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
5920
5921         * MAINTAINERS: Add Andrew Burgess as global maintainer.
5922
5923 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5924
5925         * symfile.c (find_separate_debug_file): Use canonical path of
5926         sysroot with child_path instead of gdb_sysroot if it is valid.
5927
5928 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5929
5930         * symfile.c (find_separate_debug_file): Use child_path to
5931         determine if an object file is under a sysroot.
5932
5933 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5934
5935         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
5936         unittests/child-path-selftests.c.
5937         * common/pathstuff.c (child_path): New function.
5938         * common/pathstuff.h (child_path): New prototype.
5939         * unittests/child-path-selftests.c: New file.
5940
5941 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
5942
5943         * symfile.c (find_separate_debug_file): Look for separate debug
5944         files in debug directories under the sysroot.
5945
5946 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5947
5948         * symtab.h (struct minimal_symbol data_p): New const method.
5949         (struct minimal_symbol text_p): Likewise.
5950         * symtab.c (output_source_filename): Use file name style
5951         to print file name.
5952         (print_symbol_info): Likewise.
5953         (print_msymbol_info): Use address style to print addresses.
5954         Use function name style to print executable text symbols.
5955         (expand_symtab_containing_pc): Use data_p.
5956         (find_pc_sect_compunit_symtab): Likewise.
5957
5958 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5959
5960         * breakpoint.c (describe_other_breakpoints): Use address style
5961         to print addresses.
5962         (say_where): Likewise.
5963
5964 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5965
5966         * ada-typeprint.c (print_func_type): Print function name
5967         style to print function name.
5968         * c-typeprint.c (c_print_type_1): Likewise.
5969
5970 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
5971
5972         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
5973         for execve.
5974
5975 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5976
5977         * c-exp.y (direct_abs_decl): Use emplace_back to record the
5978         type_stack.
5979
5980 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
5981
5982         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
5983         TYPE_CODE_REF types.
5984
5985 2019-02-08  Jim Wilson  <jimw@sifive.com>
5986
5987         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
5988         (riscv_linux_fregset): New.
5989         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
5990
5991 2019-02-07  Tom Tromey  <tom@tromey.com>
5992
5993         * thread.c (thread_cancel_execution_command): Update.
5994         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
5995         methods.
5996         (struct thread_fsm_ops): Remove.
5997         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
5998         (thread_fsm_should_stop, thread_fsm_return_value)
5999         (thread_fsm_set_finished, thread_fsm_finished_p)
6000         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
6001         Don't declare.
6002         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
6003         * infrun.c (clear_proceed_status_thread)
6004         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
6005         (print_stop_event): Update.
6006         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
6007         Add constructor.
6008         (step_command_fsm_ops): Remove.
6009         (new_step_command_fsm): Remove.
6010         (step_1): Update.
6011         (step_command_fsm::should_stop): Rename from
6012         step_command_fsm_should_stop.
6013         (step_command_fsm::clean_up): Rename from
6014         step_command_fsm_clean_up.
6015         (step_command_fsm::do_async_reply_reason): Rename from
6016         step_command_fsm_async_reply_reason.
6017         (struct until_next_fsm): Inherit from thread_fsm.  Add
6018         constructor.
6019         (until_next_fsm_ops): Remove.
6020         (new_until_next_fsm): Remove.
6021         (until_next_fsm::should_stop): Rename from
6022         until_next_fsm_should_stop.
6023         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
6024         (until_next_fsm::do_async_reply_reason): Rename from
6025         until_next_fsm_async_reply_reason.
6026         (struct finish_command_fsm): Inherit from thread_fsm.  Add
6027         constructor.  Change type of breakpoint.
6028         (finish_command_fsm_ops): Remove.
6029         (new_finish_command_fsm): Remove.
6030         (finish_command_fsm::should_stop): Rename from
6031         finish_command_fsm_should_stop.
6032         (finish_command_fsm::clean_up): Rename from
6033         finish_command_fsm_clean_up.
6034         (finish_command_fsm::return_value): Rename from
6035         finish_command_fsm_return_value.
6036         (finish_command_fsm::do_async_reply_reason): Rename from
6037         finish_command_fsm_async_reply_reason.
6038         (finish_command): Update.
6039         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
6040         Add constructor.
6041         (call_thread_fsm_ops): Remove.
6042         (call_thread_fsm::call_thread_fsm): Rename from
6043         new_call_thread_fsm.
6044         (call_thread_fsm::should_stop): Rename from
6045         call_thread_fsm_should_stop.
6046         (call_thread_fsm::should_notify_stop): Rename from
6047         call_thread_fsm_should_notify_stop.
6048         (run_inferior_call, call_function_by_hand_dummy): Update.
6049         * cli/cli-interp.c (should_print_stop_to_console): Update.
6050         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
6051         Add constructor.  Change type of location_breakpoint,
6052         caller_breakpoint.
6053         (until_break_fsm_ops): Remove.
6054         (new_until_break_fsm): Remove.
6055         (until_break_fsm::should_stop): Rename from
6056         until_break_fsm_should_stop.
6057         (until_break_fsm::clean_up): Rename from
6058         until_break_fsm_clean_up.
6059         (until_break_fsm::do_async_reply_reason): Rename from
6060         until_break_fsm_async_reply_reason.
6061         (until_break_command): Update.
6062         * thread-fsm.c: Remove.
6063         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
6064
6065 2019-02-07  Tom Tromey  <tom@tromey.com>
6066
6067         * yy-remap.h: Add include guard.
6068         * xtensa-tdep.h: Add include guard.
6069         * xcoffread.h: Rename include guard.
6070         * varobj-iter.h: Add include guard.
6071         * tui/tui.h: Rename include guard.
6072         * tui/tui-winsource.h: Rename include guard.
6073         * tui/tui-wingeneral.h: Rename include guard.
6074         * tui/tui-windata.h: Rename include guard.
6075         * tui/tui-win.h: Rename include guard.
6076         * tui/tui-stack.h: Rename include guard.
6077         * tui/tui-source.h: Rename include guard.
6078         * tui/tui-regs.h: Rename include guard.
6079         * tui/tui-out.h: Rename include guard.
6080         * tui/tui-layout.h: Rename include guard.
6081         * tui/tui-io.h: Rename include guard.
6082         * tui/tui-hooks.h: Rename include guard.
6083         * tui/tui-file.h: Rename include guard.
6084         * tui/tui-disasm.h: Rename include guard.
6085         * tui/tui-data.h: Rename include guard.
6086         * tui/tui-command.h: Rename include guard.
6087         * tic6x-tdep.h: Add include guard.
6088         * target/waitstatus.h: Rename include guard.
6089         * target/wait.h: Rename include guard.
6090         * target/target.h: Rename include guard.
6091         * target/resume.h: Rename include guard.
6092         * target-float.h: Rename include guard.
6093         * stabsread.h: Add include guard.
6094         * rs6000-tdep.h: Add include guard.
6095         * riscv-fbsd-tdep.h: Add include guard.
6096         * regformats/regdef.h: Rename include guard.
6097         * record.h: Rename include guard.
6098         * python/python.h: Rename include guard.
6099         * python/python-internal.h: Rename include guard.
6100         * python/py-stopevent.h: Rename include guard.
6101         * python/py-ref.h: Rename include guard.
6102         * python/py-record.h: Rename include guard.
6103         * python/py-record-full.h: Rename include guard.
6104         * python/py-record-btrace.h: Rename include guard.
6105         * python/py-instruction.h: Rename include guard.
6106         * python/py-events.h: Rename include guard.
6107         * python/py-event.h: Rename include guard.
6108         * procfs.h: Add include guard.
6109         * proc-utils.h: Add include guard.
6110         * p-lang.h: Add include guard.
6111         * or1k-tdep.h: Rename include guard.
6112         * observable.h: Rename include guard.
6113         * nto-tdep.h: Rename include guard.
6114         * nat/x86-linux.h: Rename include guard.
6115         * nat/x86-linux-dregs.h: Rename include guard.
6116         * nat/x86-gcc-cpuid.h: Add include guard.
6117         * nat/x86-dregs.h: Rename include guard.
6118         * nat/x86-cpuid.h: Rename include guard.
6119         * nat/ppc-linux.h: Rename include guard.
6120         * nat/mips-linux-watch.h: Rename include guard.
6121         * nat/linux-waitpid.h: Rename include guard.
6122         * nat/linux-ptrace.h: Rename include guard.
6123         * nat/linux-procfs.h: Rename include guard.
6124         * nat/linux-osdata.h: Rename include guard.
6125         * nat/linux-nat.h: Rename include guard.
6126         * nat/linux-namespaces.h: Rename include guard.
6127         * nat/linux-btrace.h: Rename include guard.
6128         * nat/glibc_thread_db.h: Rename include guard.
6129         * nat/gdb_thread_db.h: Rename include guard.
6130         * nat/gdb_ptrace.h: Rename include guard.
6131         * nat/fork-inferior.h: Rename include guard.
6132         * nat/amd64-linux-siginfo.h: Rename include guard.
6133         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
6134         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
6135         * nat/aarch64-linux.h: Rename include guard.
6136         * nat/aarch64-linux-hw-point.h: Rename include guard.
6137         * mn10300-tdep.h: Add include guard.
6138         * mips-linux-tdep.h: Add include guard.
6139         * mi/mi-parse.h: Rename include guard.
6140         * mi/mi-out.h: Rename include guard.
6141         * mi/mi-main.h: Rename include guard.
6142         * mi/mi-interp.h: Rename include guard.
6143         * mi/mi-getopt.h: Rename include guard.
6144         * mi/mi-console.h: Rename include guard.
6145         * mi/mi-common.h: Rename include guard.
6146         * mi/mi-cmds.h: Rename include guard.
6147         * mi/mi-cmd-break.h: Rename include guard.
6148         * m2-lang.h: Add include guard.
6149         * location.h: Rename include guard.
6150         * linux-record.h: Rename include guard.
6151         * linux-nat.h: Add include guard.
6152         * linux-fork.h: Add include guard.
6153         * i386-darwin-tdep.h: Rename include guard.
6154         * hppa-linux-offsets.h: Add include guard.
6155         * guile/guile.h: Rename include guard.
6156         * guile/guile-internal.h: Rename include guard.
6157         * gnu-nat.h: Rename include guard.
6158         * gdb-stabs.h: Rename include guard.
6159         * frv-tdep.h: Add include guard.
6160         * f-lang.h: Add include guard.
6161         * event-loop.h: Add include guard.
6162         * darwin-nat.h: Rename include guard.
6163         * cp-abi.h: Rename include guard.
6164         * config/sparc/nm-sol2.h: Rename include guard.
6165         * config/nm-nto.h: Rename include guard.
6166         * config/nm-linux.h: Add include guard.
6167         * config/i386/nm-i386gnu.h: Rename include guard.
6168         * config/djgpp/nl_types.h: Rename include guard.
6169         * config/djgpp/langinfo.h: Rename include guard.
6170         * compile/gcc-cp-plugin.h: Add include guard.
6171         * compile/gcc-c-plugin.h: Add include guard.
6172         * compile/compile.h: Rename include guard.
6173         * compile/compile-object-run.h: Rename include guard.
6174         * compile/compile-object-load.h: Rename include guard.
6175         * compile/compile-internal.h: Rename include guard.
6176         * compile/compile-cplus.h: Rename include guard.
6177         * compile/compile-c.h: Rename include guard.
6178         * common/xml-utils.h: Rename include guard.
6179         * common/x86-xstate.h: Rename include guard.
6180         * common/version.h: Rename include guard.
6181         * common/vec.h: Rename include guard.
6182         * common/tdesc.h: Rename include guard.
6183         * common/selftest.h: Rename include guard.
6184         * common/scoped_restore.h: Rename include guard.
6185         * common/scoped_mmap.h: Rename include guard.
6186         * common/scoped_fd.h: Rename include guard.
6187         * common/safe-iterator.h: Rename include guard.
6188         * common/run-time-clock.h: Rename include guard.
6189         * common/refcounted-object.h: Rename include guard.
6190         * common/queue.h: Rename include guard.
6191         * common/ptid.h: Rename include guard.
6192         * common/print-utils.h: Rename include guard.
6193         * common/preprocessor.h: Rename include guard.
6194         * common/pathstuff.h: Rename include guard.
6195         * common/observable.h: Rename include guard.
6196         * common/netstuff.h: Rename include guard.
6197         * common/job-control.h: Rename include guard.
6198         * common/host-defs.h: Rename include guard.
6199         * common/gdb_wait.h: Rename include guard.
6200         * common/gdb_vecs.h: Rename include guard.
6201         * common/gdb_unlinker.h: Rename include guard.
6202         * common/gdb_unique_ptr.h: Rename include guard.
6203         * common/gdb_tilde_expand.h: Rename include guard.
6204         * common/gdb_sys_time.h: Rename include guard.
6205         * common/gdb_string_view.h: Rename include guard.
6206         * common/gdb_splay_tree.h: Rename include guard.
6207         * common/gdb_setjmp.h: Rename include guard.
6208         * common/gdb_ref_ptr.h: Rename include guard.
6209         * common/gdb_optional.h: Rename include guard.
6210         * common/gdb_locale.h: Rename include guard.
6211         * common/gdb_assert.h: Rename include guard.
6212         * common/filtered-iterator.h: Rename include guard.
6213         * common/filestuff.h: Rename include guard.
6214         * common/fileio.h: Rename include guard.
6215         * common/environ.h: Rename include guard.
6216         * common/common-utils.h: Rename include guard.
6217         * common/common-types.h: Rename include guard.
6218         * common/common-regcache.h: Rename include guard.
6219         * common/common-inferior.h: Rename include guard.
6220         * common/common-gdbthread.h: Rename include guard.
6221         * common/common-exceptions.h: Rename include guard.
6222         * common/common-defs.h: Rename include guard.
6223         * common/common-debug.h: Rename include guard.
6224         * common/cleanups.h: Rename include guard.
6225         * common/buffer.h: Rename include guard.
6226         * common/btrace-common.h: Rename include guard.
6227         * common/break-common.h: Rename include guard.
6228         * cli/cli-utils.h: Rename include guard.
6229         * cli/cli-style.h: Rename include guard.
6230         * cli/cli-setshow.h: Rename include guard.
6231         * cli/cli-script.h: Rename include guard.
6232         * cli/cli-interp.h: Rename include guard.
6233         * cli/cli-decode.h: Rename include guard.
6234         * cli/cli-cmds.h: Rename include guard.
6235         * charset-list.h: Add include guard.
6236         * buildsym-legacy.h: Rename include guard.
6237         * bfin-tdep.h: Add include guard.
6238         * ax.h: Rename include guard.
6239         * arm-linux-tdep.h: Add include guard.
6240         * arm-fbsd-tdep.h: Add include guard.
6241         * arch/xtensa.h: Rename include guard.
6242         * arch/tic6x.h: Add include guard.
6243         * arch/i386.h: Add include guard.
6244         * arch/arm.h: Rename include guard.
6245         * arch/arm-linux.h: Rename include guard.
6246         * arch/arm-get-next-pcs.h: Rename include guard.
6247         * arch/amd64.h: Add include guard.
6248         * arch/aarch64-insn.h: Rename include guard.
6249         * arch-utils.h: Rename include guard.
6250         * annotate.h: Add include guard.
6251         * amd64-darwin-tdep.h: Rename include guard.
6252         * aarch64-linux-tdep.h: Add include guard.
6253         * aarch64-fbsd-tdep.h: Add include guard.
6254         * aarch32-linux-nat.h: Add include guard.
6255
6256 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6257
6258         * macrotab.c (macro_define_internal): New function that
6259         factorizes macro_define_object_internal and macro_define_function
6260         code.
6261         (macro_define_object_internal): Use macro_define_internal.
6262         (macro_define_function): Likewise.
6263
6264 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6265
6266         * macrocmd.c (extract_identifier): Return
6267         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
6268         callers.
6269
6270 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
6271
6272         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
6273
6274 2019-02-05  Tom Tromey  <tom@tromey.com>
6275
6276         * target.c (target_stack::unpush): Move assertion earlier.
6277
6278 2019-01-30  Tom Tromey  <tom@tromey.com>
6279
6280         PR python/23615:
6281         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
6282         (gdbpy_parse_and_eval): Likewise.
6283         * python/python-internal.h (gdbpy_allow_threads): New class.
6284
6285 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
6286
6287         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
6288         (aarch64_fbsd_fpregmap): Move earlier.
6289         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
6290         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6291         instead of individual calls to trad_frame_set_reg_addr.
6292         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
6293         earlier.
6294         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
6295         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
6296         instead of individual calls to trad_frame_set_reg_addr.
6297
6298 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
6299
6300         * CONTRIBUTE: Replace contribution list with wiki link.
6301
6302 2019-01-25  Tom Tromey  <tom@tromey.com>
6303
6304         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
6305
6306 2019-01-25  Tom Tromey  <tom@tromey.com>
6307
6308         * xtensa-linux-nat.c: Fix common/ includes.
6309         * xml-support.h: Fix common/ includes.
6310         * xml-support.c: Fix common/ includes.
6311         * x86-linux-nat.c: Fix common/ includes.
6312         * windows-nat.c: Fix common/ includes.
6313         * varobj.h: Fix common/ includes.
6314         * varobj.c: Fix common/ includes.
6315         * value.c: Fix common/ includes.
6316         * valops.c: Fix common/ includes.
6317         * utils.c: Fix common/ includes.
6318         * unittests/xml-utils-selftests.c: Fix common/ includes.
6319         * unittests/utils-selftests.c: Fix common/ includes.
6320         * unittests/unpack-selftests.c: Fix common/ includes.
6321         * unittests/tracepoint-selftests.c: Fix common/ includes.
6322         * unittests/style-selftests.c: Fix common/ includes.
6323         * unittests/string_view-selftests.c: Fix common/ includes.
6324         * unittests/scoped_restore-selftests.c: Fix common/ includes.
6325         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
6326         * unittests/scoped_fd-selftests.c: Fix common/ includes.
6327         * unittests/rsp-low-selftests.c: Fix common/ includes.
6328         * unittests/parse-connection-spec-selftests.c: Fix common/
6329         includes.
6330         * unittests/optional-selftests.c: Fix common/ includes.
6331         * unittests/offset-type-selftests.c: Fix common/ includes.
6332         * unittests/observable-selftests.c: Fix common/ includes.
6333         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
6334         * unittests/memrange-selftests.c: Fix common/ includes.
6335         * unittests/memory-map-selftests.c: Fix common/ includes.
6336         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
6337         * unittests/function-view-selftests.c: Fix common/ includes.
6338         * unittests/environ-selftests.c: Fix common/ includes.
6339         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
6340         * unittests/common-utils-selftests.c: Fix common/ includes.
6341         * unittests/cli-utils-selftests.c: Fix common/ includes.
6342         * unittests/array-view-selftests.c: Fix common/ includes.
6343         * ui-file.c: Fix common/ includes.
6344         * tui/tui-io.c: Fix common/ includes.
6345         * tracepoint.h: Fix common/ includes.
6346         * tracepoint.c: Fix common/ includes.
6347         * tracefile-tfile.c: Fix common/ includes.
6348         * top.h: Fix common/ includes.
6349         * top.c: Fix common/ includes.
6350         * thread.c: Fix common/ includes.
6351         * target/waitstatus.h: Fix common/ includes.
6352         * target/waitstatus.c: Fix common/ includes.
6353         * target.h: Fix common/ includes.
6354         * target.c: Fix common/ includes.
6355         * target-memory.c: Fix common/ includes.
6356         * target-descriptions.c: Fix common/ includes.
6357         * symtab.h: Fix common/ includes.
6358         * symfile.c: Fix common/ includes.
6359         * stap-probe.c: Fix common/ includes.
6360         * spu-linux-nat.c: Fix common/ includes.
6361         * sparc-nat.c: Fix common/ includes.
6362         * source.c: Fix common/ includes.
6363         * solib.c: Fix common/ includes.
6364         * solib-target.c: Fix common/ includes.
6365         * ser-unix.c: Fix common/ includes.
6366         * ser-tcp.c: Fix common/ includes.
6367         * ser-pipe.c: Fix common/ includes.
6368         * ser-base.c: Fix common/ includes.
6369         * selftest-arch.c: Fix common/ includes.
6370         * s12z-tdep.c: Fix common/ includes.
6371         * rust-exp.y: Fix common/ includes.
6372         * rs6000-aix-tdep.c: Fix common/ includes.
6373         * riscv-tdep.c: Fix common/ includes.
6374         * remote.c: Fix common/ includes.
6375         * remote-notif.h: Fix common/ includes.
6376         * remote-fileio.h: Fix common/ includes.
6377         * remote-fileio.c: Fix common/ includes.
6378         * regcache.h: Fix common/ includes.
6379         * regcache.c: Fix common/ includes.
6380         * record-btrace.c: Fix common/ includes.
6381         * python/python.c: Fix common/ includes.
6382         * python/py-type.c: Fix common/ includes.
6383         * python/py-inferior.c: Fix common/ includes.
6384         * progspace.h: Fix common/ includes.
6385         * producer.c: Fix common/ includes.
6386         * procfs.c: Fix common/ includes.
6387         * proc-api.c: Fix common/ includes.
6388         * printcmd.c: Fix common/ includes.
6389         * ppc-linux-nat.c: Fix common/ includes.
6390         * parser-defs.h: Fix common/ includes.
6391         * osdata.c: Fix common/ includes.
6392         * obsd-nat.c: Fix common/ includes.
6393         * nat/x86-linux.c: Fix common/ includes.
6394         * nat/x86-linux-dregs.c: Fix common/ includes.
6395         * nat/x86-dregs.h: Fix common/ includes.
6396         * nat/x86-dregs.c: Fix common/ includes.
6397         * nat/ppc-linux.c: Fix common/ includes.
6398         * nat/mips-linux-watch.h: Fix common/ includes.
6399         * nat/mips-linux-watch.c: Fix common/ includes.
6400         * nat/linux-waitpid.c: Fix common/ includes.
6401         * nat/linux-ptrace.h: Fix common/ includes.
6402         * nat/linux-ptrace.c: Fix common/ includes.
6403         * nat/linux-procfs.c: Fix common/ includes.
6404         * nat/linux-personality.c: Fix common/ includes.
6405         * nat/linux-osdata.c: Fix common/ includes.
6406         * nat/linux-namespaces.c: Fix common/ includes.
6407         * nat/linux-btrace.h: Fix common/ includes.
6408         * nat/linux-btrace.c: Fix common/ includes.
6409         * nat/fork-inferior.c: Fix common/ includes.
6410         * nat/amd64-linux-siginfo.c: Fix common/ includes.
6411         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
6412         * nat/aarch64-linux.c: Fix common/ includes.
6413         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
6414         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
6415         * namespace.h: Fix common/ includes.
6416         * mips-linux-tdep.c: Fix common/ includes.
6417         * minsyms.c: Fix common/ includes.
6418         * mi/mi-parse.h: Fix common/ includes.
6419         * mi/mi-main.c: Fix common/ includes.
6420         * mi/mi-cmd-env.c: Fix common/ includes.
6421         * memrange.h: Fix common/ includes.
6422         * memattr.c: Fix common/ includes.
6423         * maint.h: Fix common/ includes.
6424         * maint.c: Fix common/ includes.
6425         * main.c: Fix common/ includes.
6426         * machoread.c: Fix common/ includes.
6427         * location.c: Fix common/ includes.
6428         * linux-thread-db.c: Fix common/ includes.
6429         * linux-nat.c: Fix common/ includes.
6430         * linux-fork.c: Fix common/ includes.
6431         * inline-frame.c: Fix common/ includes.
6432         * infrun.c: Fix common/ includes.
6433         * inflow.c: Fix common/ includes.
6434         * inferior.h: Fix common/ includes.
6435         * inferior.c: Fix common/ includes.
6436         * infcmd.c: Fix common/ includes.
6437         * inf-ptrace.c: Fix common/ includes.
6438         * inf-child.c: Fix common/ includes.
6439         * ia64-linux-nat.c: Fix common/ includes.
6440         * i387-tdep.c: Fix common/ includes.
6441         * i386-tdep.c: Fix common/ includes.
6442         * i386-linux-tdep.c: Fix common/ includes.
6443         * i386-linux-nat.c: Fix common/ includes.
6444         * i386-go32-tdep.c: Fix common/ includes.
6445         * i386-fbsd-tdep.c: Fix common/ includes.
6446         * i386-fbsd-nat.c: Fix common/ includes.
6447         * guile/scm-type.c: Fix common/ includes.
6448         * guile/guile.c: Fix common/ includes.
6449         * go32-nat.c: Fix common/ includes.
6450         * gnu-nat.c: Fix common/ includes.
6451         * gdbthread.h: Fix common/ includes.
6452         * gdbarch-selftests.c: Fix common/ includes.
6453         * gdb_usleep.c: Fix common/ includes.
6454         * gdb_select.h: Fix common/ includes.
6455         * gdb_bfd.c: Fix common/ includes.
6456         * gcore.c: Fix common/ includes.
6457         * fork-child.c: Fix common/ includes.
6458         * findvar.c: Fix common/ includes.
6459         * fbsd-nat.c: Fix common/ includes.
6460         * event-top.c: Fix common/ includes.
6461         * event-loop.c: Fix common/ includes.
6462         * dwarf2read.c: Fix common/ includes.
6463         * dwarf2loc.c: Fix common/ includes.
6464         * dwarf2-frame.c: Fix common/ includes.
6465         * dwarf-index-cache.c: Fix common/ includes.
6466         * dtrace-probe.c: Fix common/ includes.
6467         * disasm-selftests.c: Fix common/ includes.
6468         * defs.h: Fix common/ includes.
6469         * csky-tdep.c: Fix common/ includes.
6470         * cp-valprint.c: Fix common/ includes.
6471         * cp-support.h: Fix common/ includes.
6472         * cp-support.c: Fix common/ includes.
6473         * corelow.c: Fix common/ includes.
6474         * completer.h: Fix common/ includes.
6475         * completer.c: Fix common/ includes.
6476         * compile/compile.c: Fix common/ includes.
6477         * compile/compile-loc2c.c: Fix common/ includes.
6478         * compile/compile-cplus-types.c: Fix common/ includes.
6479         * compile/compile-cplus-symbols.c: Fix common/ includes.
6480         * command.h: Fix common/ includes.
6481         * cli/cli-dump.c: Fix common/ includes.
6482         * cli/cli-cmds.c: Fix common/ includes.
6483         * charset.c: Fix common/ includes.
6484         * build-id.c: Fix common/ includes.
6485         * btrace.h: Fix common/ includes.
6486         * btrace.c: Fix common/ includes.
6487         * breakpoint.h: Fix common/ includes.
6488         * breakpoint.c: Fix common/ includes.
6489         * ax.h:
6490         (enum agent_op): Fix common/ includes.
6491         * ax-general.c (struct aop_map): Fix common/ includes.
6492         * ax-gdb.c: Fix common/ includes.
6493         * auxv.c: Fix common/ includes.
6494         * auto-load.c: Fix common/ includes.
6495         * arm-tdep.c: Fix common/ includes.
6496         * arch/riscv.c: Fix common/ includes.
6497         * arch/ppc-linux-common.c: Fix common/ includes.
6498         * arch/i386.c: Fix common/ includes.
6499         * arch/arm.c: Fix common/ includes.
6500         * arch/arm-linux.c: Fix common/ includes.
6501         * arch/arm-get-next-pcs.c: Fix common/ includes.
6502         * arch/amd64.c: Fix common/ includes.
6503         * arch/aarch64.c: Fix common/ includes.
6504         * arch/aarch64-insn.c: Fix common/ includes.
6505         * arch-utils.c: Fix common/ includes.
6506         * amd64-windows-tdep.c: Fix common/ includes.
6507         * amd64-tdep.c: Fix common/ includes.
6508         * amd64-sol2-tdep.c: Fix common/ includes.
6509         * amd64-obsd-tdep.c: Fix common/ includes.
6510         * amd64-nbsd-tdep.c: Fix common/ includes.
6511         * amd64-linux-tdep.c: Fix common/ includes.
6512         * amd64-linux-nat.c: Fix common/ includes.
6513         * amd64-fbsd-tdep.c: Fix common/ includes.
6514         * amd64-fbsd-nat.c: Fix common/ includes.
6515         * amd64-dicos-tdep.c: Fix common/ includes.
6516         * amd64-darwin-tdep.c: Fix common/ includes.
6517         * agent.c: Fix common/ includes.
6518         * ada-lang.h: Fix common/ includes.
6519         * ada-lang.c: Fix common/ includes.
6520         * aarch64-tdep.c: Fix common/ includes.
6521
6522 2019-01-25  Tom Tromey  <tom@tromey.com>
6523
6524         * common/create-version.sh: Use common/version.h.
6525
6526 2019-01-24  Pedro Alves  <palves@redhat.com>
6527
6528         * infrun.c (signal_stop, signal_print, signal_program)
6529         (signal_catch, signal_pass): Now arrays instead of pointers.
6530         (update_signals_program_target, do_target_resume)
6531         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
6532         * linux-nat.c (linux_nat_target::pass_signals)
6533         (linux_nat_target::create_inferior, linux_nat_target::attach):
6534         Adjust.
6535         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
6536         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
6537         * procfs.c (procfs_target::pass_signals): Adjust.
6538         * record-full.c (record_full_target::resume): Adjust.
6539         * remote.c (remote_target::pass_signals)
6540         (remote_target::program_signals): Adjust.
6541         * target-debug.h (target_debug_print_signals): Now takes a
6542         gdb::array_view as parameter.  Adjust.
6543         * target.h (target_ops) <pass_signals, program_signals>: Replace
6544         pointer and length parameters with gdb::array_view.
6545         (target_pass_signals, target_program_signals): Likewise.
6546         * target-delegates.c: Regenerate.
6547
6548 2019-01-24  Pedro Alves  <palves@redhat.com>
6549
6550         * common/forward-scope-exit.h
6551         (forward_scope_exit::forward_scope_exit): Pass arguments to
6552         m_bind_function directly, instead of creating a std::bind and
6553         copying that.
6554
6555 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
6556
6557         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6558         for static members.
6559         (pass_in_v_vfp_candidate): Likewise.
6560
6561 2019-01-23  Tom Tromey  <tom@tromey.com>
6562             Pedro Alves  <palves@redhat.com>
6563
6564         * regcache.c (class regcache_invalidator): Remove.
6565         (regcache::raw_write): Use make_scope_exit.
6566
6567 2019-01-23  Tom Tromey  <tom@tromey.com>
6568
6569         * ui-out.h (class ui_out_emit_type): Update comment.
6570
6571 2019-01-23  Tom Tromey  <tom@tromey.com>
6572
6573         * infrun.c (fetch_inferior_event): Update comment.
6574
6575 2019-01-23  Tom Tromey  <tom@tromey.com>
6576             Pedro Alves  <palves@redhat.com>
6577
6578         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
6579         parameter.
6580         (fetch_inferior_event): Use SCOPE_EXIT.
6581
6582
6583 2019-01-23  Tom Tromey  <tom@tromey.com>
6584             Pedro Alves  <palves@redhat.com>
6585
6586         * infrun.c (disable_thread_events): Delete.
6587         (stop_all_threads): Use SCOPE_EXIT.
6588
6589 2019-01-23  Tom Tromey  <tom@tromey.com>
6590             Pedro Alves  <palves@redhat.com>
6591
6592         * symfile.c: Include forward-scope-exit.h.
6593         (clear_symtab_users_cleanup): Replace forward declaration with
6594         a FORWARD_SCOPE_EXIT.
6595         (syms_from_objfile_1): Use the forward_scope_exit and
6596         gdb::optional instead of cleanup_function.
6597         (reread_symbols): Use the forward_scope_exit instead of
6598         cleanup_function.
6599         (clear_symtab_users_cleanup): Remove function.
6600
6601 2019-01-23  Tom Tromey  <tom@tromey.com>
6602             Pedro Alves  <palves@redhat.com>
6603
6604         * linux-nat.c: Include scope-exit.h.
6605         (cleanup_target_stop): Remove.
6606         (linux_nat_target::static_tracepoint_markers_by_strid): Use
6607         SCOPE_EXIT.
6608
6609 2019-01-23  Tom Tromey  <tom@tromey.com>
6610             Pedro Alves  <palves@redhat.com>
6611
6612         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
6613         (call_function_by_hand_dummy): Use SCOPE_EXIT.
6614
6615 2019-01-23  Tom Tromey  <tom@tromey.com>
6616             Andrew Burgess  <andrew.burgess@embecosm.com>
6617             Pedro Alves  <palves@redhat.com>
6618
6619         * infrun.c (fetch_inferior_event): Use scope_exit.
6620         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
6621         * top.c (execute_command): Use scope_exit.
6622         * breakpoint.c (bpstat_do_actions): Use scope_exit.
6623         * utils.c (do_bpstat_clear_actions_cleanup)
6624         (make_bpstat_clear_actions_cleanup): Remove.
6625
6626 2019-01-23  Tom Tromey  <tom@tromey.com>
6627             Pedro Alves  <palves@redhat.com>
6628
6629         * infrun.c: Include "common/scope-exit.h"
6630         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
6631         (wait_for_inferior): Use SCOPE_EXIT.
6632         (fetch_inferior_event): Use scope_exit.
6633
6634 2019-01-23  Tom Tromey  <tom@tromey.com>
6635             Pedro Alves  <palves@redhat.com>
6636
6637         * breakpoint.c (create_breakpoint): Remove cleanup.
6638
6639 2019-01-23  Tom Tromey  <tom@tromey.com>
6640             Andrew Burgess  <andrew.burgess@embecosm.com>
6641             Pedro Alves  <palves@redhat.com>
6642
6643 2019-01-23  Pedro Alves  <palves@redhat.com>
6644
6645         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
6646
6647 2019-01-23  Pedro Alves  <palves@redhat.com>
6648             Andrew Burgess  <andrew.burgess@embecosm.com>
6649
6650         * gdbthread.h: Include "common/forward-scope-exit.h".
6651         (scoped_finish_thread_state): Redefine custom class in terms of
6652         forward_scope_exit.
6653
6654 2019-01-23  Pedro Alves  <palves@redhat.com>
6655             Andrew Burgess  <andrew.burgess@embecosm.com>
6656
6657         * common/forward-scope-exit.h: New file.
6658
6659 2019-01-23  Pedro Alves  <palves@redhat.com>
6660             Andrew Burgess  <andrew.burgess@embecosm.com>
6661             Tom Tromey  <tom@tromey.com>
6662
6663         * common/scope-exit.h: New file.
6664
6665 2019-01-23  Pedro Alves  <palves@redhat.com>
6666
6667         * common/preprocessor.h (ESC): Rename to ...
6668         (ESC_PARENS): ... this.
6669         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
6670         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
6671
6672 2019-01-23  Tom Tromey  <tom@tromey.com>
6673
6674         * language.h (class scoped_switch_to_sym_language_if_auto):
6675         Initialize m_lang in both cases.
6676
6677 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
6678
6679         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
6680         with XCNEW.
6681
6682 2019-01-22  Tom Tromey  <tom@tromey.com>
6683
6684         * corelow.c: Do not include sys/file.h.
6685
6686 2019-01-22  Tom Tromey  <tom@tromey.com>
6687
6688         * tui/tui-wingeneral.h: Include gdb_curses.h.
6689
6690 2019-01-22  Tom Tromey  <tom@tromey.com>
6691
6692         * source-cache.h (class source_cache) <get_source_lines,
6693         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
6694
6695 2019-01-22  Tom Tromey  <tom@tromey.com>
6696
6697         * remote-fileio.h (struct remote_target): Declare.
6698
6699 2019-01-22  Tom Tromey  <tom@tromey.com>
6700
6701         * python/py-arch.c: Do not include py-ref.h.
6702         * python/py-bpevent.c: Do not include py-ref.h.
6703         * python/py-cmd.c: Do not include py-ref.h.
6704         * python/py-continueevent.c: Do not include py-ref.h.
6705         * python/py-event.h: Do not include py-ref.h.
6706         * python/py-evtregistry.c: Do not include py-ref.h.
6707         * python/py-finishbreakpoint.c: Do not include py-ref.h.
6708         * python/py-frame.c: Do not include py-ref.h.
6709         * python/py-framefilter.c: Do not include py-ref.h.
6710         * python/py-function.c: Do not include py-ref.h.
6711         * python/py-infevents.c: Do not include py-ref.h.
6712         * python/py-linetable.c: Do not include py-ref.h.
6713         * python/py-objfile.c: Do not include py-ref.h.
6714         * python/py-param.c: Do not include py-ref.h.
6715         * python/py-prettyprint.c: Do not include py-ref.h.
6716         * python/py-progspace.c: Do not include py-ref.h.
6717         * python/py-symbol.c: Do not include py-ref.h.
6718         * python/py-symtab.c: Do not include py-ref.h.
6719         * python/py-type.c: Do not include py-ref.h.
6720         * python/py-unwind.c: Do not include py-ref.h.
6721         * python/py-utils.c: Do not include py-ref.h.
6722         * python/py-value.c: Do not include py-ref.h.
6723         * python/py-varobj.c: Do not include py-ref.h.
6724         * python/py-xmethods.c: Do not include py-ref.h.
6725         * python/python.c: Do not include py-ref.h.
6726         * varobj.c: Do not include py-ref.h.
6727
6728 2019-01-22  Tom Tromey  <tom@tromey.com>
6729
6730         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
6731         keyword for bcache.
6732
6733 2019-01-22  Tom Tromey  <tom@tromey.com>
6734
6735         * compile/compile-cplus-types.c: Remove a comment by #include.
6736
6737 2019-01-22  Tom Tromey  <tom@tromey.com>
6738
6739         * compile/gcc-c-plugin.h: Include compile-internal.h.
6740
6741 2019-01-22  Tom Tromey  <tom@tromey.com>
6742
6743         * stabsread.c (EXTERN): Do not define.
6744         (symnum, next_symbol_text_func, processing_gcc_compilation)
6745         (within_function, global_sym_chain, global_stabs)
6746         (previous_stab_code, this_object_header_files)
6747         (n_this_object_header_files)
6748         (n_allocated_this_object_header_files): Define.
6749         * stabsread.h (EXTERN): Never define.  Use "extern".
6750
6751 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6752
6753         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
6754         history_value.
6755
6756 2019-01-21  Tom Tromey  <tom@tromey.com>
6757
6758         * ui-out.c: Fix includes.
6759         * tui/tui-source.c: Fix includes.
6760         * target.c: Fix includes.
6761         * remote.c: Fix includes.
6762         * regcache.c: Fix includes.
6763         * python/py-block.c: Fix includes.
6764         * printcmd.c: Fix includes.
6765         * or1k-tdep.c: Fix includes.
6766         * mi/mi-main.c: Fix includes.
6767         * m32r-tdep.c: Fix includes.
6768         * csky-tdep.c: Fix includes.
6769         * compile/compile-cplus-types.c: Fix includes.
6770         * cli/cli-interp.c: Fix includes.
6771
6772 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
6773
6774         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
6775         for padding.
6776
6777 2019-01-16  Tom Tromey  <tom@tromey.com>
6778
6779         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
6780         earlier.
6781         (struct objfile) <msymbols_range>: Move from top level.
6782         <msymbols>: New method.
6783         (class objfile_msymbols): Remove.
6784         * symtab.c (default_collect_symbol_completion_matches_break_on):
6785         Update.
6786         * symmisc.c (dump_msymbols): Update.
6787         * stabsread.c (scan_file_globals): Update.
6788         * objc-lang.c (info_selectors_command, info_classes_command)
6789         (find_methods): Update.
6790         * minsyms.c (find_solib_trampoline_target): Update.
6791         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
6792         * coffread.c (coff_symfile_read): Update.
6793         * ada-lang.c (ada_lookup_simple_minsym)
6794         (ada_collect_symbol_completion_matches): Update.
6795
6796 2019-01-16  Tom Tromey  <tom@tromey.com>
6797
6798         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
6799         type.  Remove no-argument constructor.
6800         <iterator::operator++>: Simplify.
6801         <begin>: Update.
6802         <end>: Use minimal_symbol_count.
6803
6804 2019-01-16  Tom Tromey  <tom@tromey.com>
6805
6806         * objfiles.h (struct objfile) <psymtabs>: New method.
6807         (class objfile_psymtabs): Remove.
6808         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
6809         typedef.
6810         <range>: New method.
6811         (require_partial_symbols): Change return type.
6812         * psymtab.c (require_partial_symbols)
6813         (psym_expand_symtabs_matching): Update.
6814         * mdebugread.c (parse_partial_symbols): Update.
6815         * dbxread.c (dbx_end_psymtab): Update.
6816
6817 2019-01-15  Tom Tromey  <tom@tromey.com>
6818
6819         * symtab.c (lookup_objfile_from_block)
6820         (lookup_symbol_in_objfile_symtabs)
6821         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
6822         (find_line_symtab, info_sources_command)
6823         (default_collect_symbol_completion_matches_break_on)
6824         (make_source_files_completion_list): Update.
6825         * symmisc.c (print_objfile_statistics, dump_objfile)
6826         (maintenance_print_symbols, maintenance_info_symtabs)
6827         (maintenance_check_symtabs, maintenance_info_line_tables):
6828         Update.
6829         * source.c (select_source_symtab)
6830         (forget_cached_source_info_for_objfile): Update.
6831         * objfiles.h (class objfile_compunits): Remove.
6832         (struct objfile) <compunits_range>: New typedef.
6833         (compunits): New method.
6834         * objfiles.c (objfile_relocate1): Update.
6835         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6836         * maint.c (count_symtabs_and_blocks): Update.
6837         * linespec.c (iterate_over_all_matching_symtabs): Update.
6838         * cp-support.c (add_symbol_overload_list_qualified): Update.
6839         * coffread.c (coff_symtab_read): Update.
6840         * ada-lang.c (add_nonlocal_symbols)
6841         (ada_collect_symbol_completion_matches)
6842         (ada_add_global_exceptions): Update.
6843
6844 2019-01-15  Tom Tromey  <tom@tromey.com>
6845
6846         * progspace.h (program_space) <objfiles_safe_range>: New
6847         typedef.
6848         <objfiles_safe>: New method.
6849         * objfiles.h (class all_objfiles_safe): Remove.
6850         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
6851         * jit.c (jit_inferior_exit_hook): Update.
6852
6853 2019-01-17  Tom Tromey  <tom@tromey.com>
6854
6855         * progspace.h (program_space) <objfiles_range>: New typedef.
6856         <objfiles>: New method.
6857         <objfiles_head>: Rename from objfiles.
6858         (object_files): Update.
6859         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
6860         * guile/scm-pretty-print.c
6861         (ppscm_find_pretty_printer_from_objfiles): Update.
6862         * guile/scm-objfile.c (gdbscm_objfiles): Update.
6863         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
6864         Update.
6865         * python/py-progspace.c (pspy_get_objfiles): Update.
6866         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
6867         Update.
6868         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
6869         (objfpy_lookup_objfile_by_build_id): Update.
6870         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
6871         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
6872         Update.
6873         * symtab.c (iterate_over_symtabs, matching_obj_sections)
6874         (expand_symtab_containing_pc, lookup_objfile_from_block)
6875         (lookup_static_symbol, basic_lookup_transparent_type)
6876         (find_pc_sect_compunit_symtab, find_symbol_at_address)
6877         (find_line_symtab, info_sources_command)
6878         (default_collect_symbol_completion_matches_break_on)
6879         (make_source_files_completion_list, find_main_name): Update.
6880         * symmisc.c (print_symbol_bcache_statistics)
6881         (print_objfile_statistics, maintenance_print_symbols)
6882         (maintenance_print_msymbols, maintenance_print_objfiles)
6883         (maintenance_info_symtabs, maintenance_check_symtabs)
6884         (maintenance_expand_symtabs, maintenance_info_line_tables):
6885         Update.
6886         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
6887         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
6888         (map_overlay_command, unmap_overlay_command)
6889         (simple_overlay_update, expand_symtabs_matching)
6890         (map_symbol_filenames): Update.
6891         * symfile-debug.c (set_debug_symfile): Update.
6892         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
6893         Update.
6894         * source.c (select_source_symtab, forget_cached_source_info):
6895         Update.
6896         * solib.c (solib_read_symbols): Update.
6897         * solib-spu.c (append_ocl_sos): Update.
6898         * psymtab.c (maintenance_print_psymbols)
6899         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
6900         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
6901         * printcmd.c (info_symbol_command): Update.
6902         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
6903         Update.
6904         * objfiles.h (class all_objfiles): Remove.
6905         * objfiles.c (have_partial_symbols, have_full_symbols)
6906         (have_minimal_symbols, qsort_cmp, update_section_map)
6907         (shared_objfile_contains_address_p)
6908         (default_iterate_over_objfiles_in_search_order): Update.
6909         * objc-lang.c (info_selectors_command, info_classes_command)
6910         (find_methods): Update.
6911         * minsyms.c (find_solib_trampoline_target): Update.
6912         * maint.c (maintenance_info_sections)
6913         (maintenance_translate_address, count_symtabs_and_blocks):
6914         Update.
6915         * main.c (captured_main_1): Update.
6916         * linux-thread-db.c (try_thread_db_load_from_pdir)
6917         (has_libpthread): Update.
6918         * linespec.c (iterate_over_all_matching_symtabs)
6919         (search_minsyms_for_name): Update.
6920         * jit.c (jit_find_objf_with_entry_addr): Update.
6921         * hppa-tdep.c (find_unwind_entry)
6922         (hppa_lookup_stub_minimal_symbol): Update.
6923         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
6924         Update.
6925         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
6926         (elf_gnu_ifunc_resolve_by_got): Update.
6927         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
6928         * dwarf-index-write.c (save_gdb_index_command): Update.
6929         * cp-support.c (add_symbol_overload_list_qualified): Update.
6930         * breakpoint.c (create_overlay_event_breakpoint)
6931         (create_longjmp_master_breakpoint)
6932         (create_std_terminate_master_breakpoint)
6933         (create_exception_master_breakpoint): Update.
6934         * blockframe.c (find_pc_partial_function): Update.
6935         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
6936         (ada_collect_symbol_completion_matches)
6937         (ada_add_global_exceptions): Update.
6938
6939 2019-01-17  Tom Tromey  <tom@tromey.com>
6940
6941         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
6942         declare VEC.
6943         (solib_target_parse_libraries): Change return type.
6944         (library_list_start_segment, library_list_start_section)
6945         (library_list_end_library, library_list_start_library); Update.
6946         (solib_target_free_library_list): Remove.
6947         (solib_target_parse_libraries): Remove cleanup.  Change return
6948         type.
6949         (solib_target_current_sos): Update.
6950
6951 2019-01-17  Tom Tromey  <tromey@bapiya>
6952
6953         * valprint.c: Replace "the the" with "the".
6954         * symtab.c: Replace "the the" with "the".
6955         * solib.c: Replace "the the" with "the".
6956         * solib-dsbt.c: Replace "the the" with "the".
6957         * linespec.c: Replace "the the" with "the".
6958         * dwarf2loc.h: Replace "the the" with "the".
6959         * amd64-windows-tdep.c: Replace "the the" with "the".
6960         * aarch64-tdep.c: Replace "the the" with "the".
6961
6962 2019-01-16  Keith Seitz  <keiths@redhat.com>
6963
6964         PR gdb/23773
6965         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
6966         <builder>: Rename to ..
6967         <m_builder>: ... this and make private.
6968         (dwarf2_cu::get_builder): New method.  Change all users of
6969         `builder' to use this method.
6970         (dwarf2_start_symtab): Move to ...
6971         (dwarf2_cu::start_symtab): ... here.  Update all callers
6972         (setup_type_unit_groups): Move to ...
6973         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
6974         callers.
6975         (dwarf2_cu::reset_builder): New method.
6976         (process_full_compunit, process_full_type_unit): Use
6977         dwarf2_cu::reset_builder.
6978         (follow_die_offset): Record the ancestor CU if it is different
6979         from the followed DIE's CU.
6980         (follow_die_sig_1): Likewise.
6981
6982 2019-01-15  Tom Tromey  <tom@tromey.com>
6983
6984         * remote.c (class remote_state) <buf>: Now a char_vector.
6985         <buf_size>: Remove.
6986         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
6987         parameter.
6988         (remote_target::getpkt_or_notif_sane_1)
6989         (remote_target::getpkt_sane)
6990         (remote_target::getpkt_or_notif_sane): Likewise.
6991         (class remote_target) <putpkt>: New overload.
6992         (remote_target::read_frame): Change type of "buf_p".  Remove
6993         sizeof_p parameter.
6994         (packet_ok): New overload.
6995         (packet_check_result): New overload.
6996         Update all uses.
6997
6998 2019-01-14  Tom Tromey  <tom@tromey.com>
6999
7000         * remote-notif.c (handle_notification, remote_notif_ack)
7001         (remote_notif_parse): Make "buf" const.
7002         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
7003         const.
7004         (remote_notif_parse, remote_notif_ack, handle_notification):
7005         Likewise.
7006         * remote.c (remote_notif_stop_parse): Make "buf" const.
7007         (remote_target::remote_parse_stop_reply): Make "buf" const.
7008         (remote_notif_stop_ack): Make "buf" const.
7009
7010 2019-01-14  Tom Tromey  <tom@tromey.com>
7011
7012         * remote.c (remote_console_output): Make parameter const.
7013
7014 2019-01-14  Tom Tromey  <tom@tromey.com>
7015
7016         * target-debug.h (target_debug_print_signals): Constify.
7017         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
7018         * procfs.c (procfs_target::pass_signals): Update.
7019         * linux-nat.c (linux_nat_target::pass_signals): Update.
7020         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
7021         * target-delegates.c: Rebuild.
7022         * remote.c (remote_target::program_signals): Update.
7023         (remote_target::pass_signals): Update.
7024         * target.c (target_pass_signals): Constify argument.
7025         (target_program_signals): Likewise.
7026         * target.h (struct target_ops) <pass_signals, program_signals>:
7027         Constify argument.
7028         (target_pass_signals, target_program_signals): Constify argument.
7029
7030 2019-01-14  Tom Tromey  <tom@tromey.com>
7031
7032         PR tui/28819:
7033         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
7034
7035 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
7036
7037         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
7038         field.
7039         * rs6000-tdep.c: Include reggroups.h.
7040         (IS_V_ALIAS_PSEUDOREG): Define.
7041         (rs6000_register_name): Return names for the "vX" aliases.
7042         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
7043         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
7044         aliases.  Call default_register_reggroup_p for all other
7045         pseudo-registers.
7046         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
7047         New functions.
7048         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
7049         Handle "vX" aliases.
7050         (v_alias_pseudo_register_collect): New function.
7051         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
7052         (rs6000_gdbarch_init): Initialize "vX" aliases as
7053         pseudo-registers.  Restore registration of
7054         rs6000_pseudo_register_reggroup_p with
7055         set_tdesc_pseudo_register_reggroup_p.
7056
7057 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
7058
7059         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
7060         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
7061         set_gdbarch_num_pseudo_regs.
7062
7063 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7064
7065         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
7066         Remove arg prefixname, add do_set and do_show.
7067         Add member functions set_list and show_list.
7068         * cli/cli-style.c (class cli_style_option): Update accordingly.
7069         (style_set_list): Move to file scope.
7070         (style_show_list): Likewise.
7071         (set_style): Call help_list.
7072         (show_style): Call cmd_show_list.
7073         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
7074         Update to use the new macro.
7075
7076 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
7077
7078         * ada-lang.c (_initialize_ada_language): Expand the help text
7079         for the "catch exception" command.
7080
7081 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7082
7083         * symtab.c (matching_obj_sections): Initialize obj,
7084         declare it closer to its usage.
7085
7086 2019-01-10  Tom Tromey  <tom@tromey.com>
7087
7088         * thread-iter.h (inf_threads_iterator): Use next_iterator.
7089         (basic_inf_threads_range): Remove.
7090         (inf_threads_range, inf_non_exited_threads_range)
7091         (safe_inf_threads_range): Use next_adapter.
7092
7093 2019-01-10  Keith Seitz  <keiths@redhat.com>
7094
7095         PR gdb/23712
7096         PR symtab/23010
7097         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
7098         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
7099
7100 2019-01-10  Keith Seitz  <keiths@redhat.com>
7101
7102         PR gdb/23712
7103         PR symtab/23010
7104         * dictionary.c (pending_to_vector): Remove.
7105         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7106         Remove _1 suffix, replacing functions of the same name.  Update
7107         all callers.
7108         (dict_create_hashed, dict_create_hashed_expandable)
7109         (dict_create_linear, dict_create_linear_expandable, dict_free)
7110         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
7111         Make functions static.
7112
7113 2019-01-10  Keith Seitz  <keiths@redhat.com>
7114
7115         PR gdb/23712
7116         PR symtab/23010
7117         * dictionary.h (struct dictionary): Replace declaration with
7118         multidictionary.
7119         (dict_create_hashed, dict_create_hashed_expandable)
7120         (dict_create_linear, dict_create_linear_expandable)
7121         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
7122         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
7123         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
7124         taking multidictionary argument.
7125         [ALL_DICT_SYMBOLS]: Update for multidictionary.
7126         * block.h (struct block) <dict>: Change to multidictionary
7127         and rename `multidict'.
7128         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
7129         symmisc.c: Update all dictionary references to multidictionary.
7130
7131 2019-01-10  Keith Seitz  <keiths@redhat.com>
7132
7133         PR gdb/23712
7134         PR symtab/23010
7135         * dictionary.c: Include unordered_map.
7136         (pending_to_vector): New function.
7137         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
7138         Rewrite the non-"_1" functions to take vector instead
7139         of linked list.
7140         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
7141         "new" _1 versions of the same name.
7142         (multidictionary): Define.
7143         (std::hash<enum language): New definition.
7144         (collate_pending_symbols_by_language, mdict_create_hashed)
7145         (mdict_create_hashed_expandable, mdict_create_linear)
7146         (mdict_create_linear_expandable, mdict_free)
7147         (find_language_dictionary, create_new_language_dictionary)
7148         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
7149         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
7150         (mdict_size, mdict_empty): New functions.
7151         * dictionary.h (mdict_iterator): Define.
7152
7153 2019-01-10  Pedro Alves  <palves@redhat.com>
7154
7155         * breakpoint.c (read_uploaded_action)
7156         (create_tracepoint_from_upload): Adjust to use
7157         gdb::unique_xmalloc_ptr.
7158         * ctf.c (ctf_write_uploaded_tp):
7159         (SET_ARRAY_FIELD): Use emplace_back.
7160         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
7161         * tracefile-tfile.c (tfile_write_uploaded_tp):
7162         * tracepoint.c (parse_tracepoint_definition): Adjust to use
7163         gdb::unique_xmalloc_ptr.
7164         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
7165         at_string, cond_string, cmd_strings>: Replace char pointers
7166         with gdb::unique_xmalloc_ptr.
7167
7168 2019-01-10  Pedro Alves  <palves@redhat.com>
7169
7170         * solib-target.c (library_list_start_library): Don't xstrdup name.
7171
7172 2019-01-10  Pedro Alves  <palves@redhat.com>
7173
7174         * mdebugread.c (parse_partial_symbols): Use
7175         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
7176
7177 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7178
7179         * linux-fork.c (scoped_switch_fork_info)
7180         <~scoped_switch_fork_info>: Fix incorrect variable name.
7181
7182 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
7183
7184         * linux-fork.c (scoped_switch_fork_info)
7185         <scoped_switch_fork_info>: Make explicit.
7186         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
7187
7188 2019-01-10  Tom Tromey  <tom@tromey.com>
7189
7190         * objfiles.h (objfile::reset_psymtabs): Update.
7191         * objfiles.c (objfile::objfile): Update.
7192         * psymtab.h (psymtab_storage::obstack): Update.
7193         (psymtab_storage::m_obstack): Use gdb::optional.
7194         (class psymtab_storage): Update comment.  Remove objfile
7195         parameter.
7196         * psymtab.c (psymtab_storage::psymtab_storage): Update.
7197
7198 2019-01-10  Tom Tromey  <tom@tromey.com>
7199
7200         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
7201         <free_psymtabs>: Now private.
7202         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
7203         (allocate_psymtab): Use new method.
7204
7205 2019-01-10  Tom Tromey  <tom@tromey.com>
7206
7207         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
7208         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
7209         * mdebugread.c (parse_partial_symbols): Use
7210         allocate_dependencies.
7211         * dwarf2read.c (dwarf2_create_include_psymtab): Use
7212         allocate_dependencies.
7213         (process_psymtab_comp_unit_reader)
7214         (build_type_psymtab_dependencies): Likewise.
7215         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
7216
7217 2019-01-10  Tom Tromey  <tom@tromey.com>
7218
7219         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
7220         PSYMBOL_SET_LANGUAGE.
7221         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
7222
7223 2019-01-10  Tom Tromey  <tom@tromey.com>
7224
7225         * psymtab.h (psymtab_storage::obstack): New method.
7226         <m_obstack>: Rename from obstack; now private.
7227         * psymtab.c (psymtab_storage): Update.
7228         * dwarf2read.c (create_addrmap_from_index)
7229         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
7230         Update.
7231
7232 2019-01-10  Tom Tromey  <tom@tromey.com>
7233
7234         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
7235         * objfiles.h (objfile::reset_psymtabs): New method.
7236
7237 2019-01-10  Tom Tromey  <tom@tromey.com>
7238
7239         * symmisc.c (print_symbol_bcache_statistics): Update.
7240         (print_objfile_statistics): Update.
7241         * symfile.c (reread_symbols): Update.
7242         * psymtab.h (class psymtab_storage): New.
7243         * psymtab.c (psymtab_storage): New constructor.
7244         (~psymtab_storage): New destructor.
7245         (require_partial_symbols): Update.
7246         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
7247         (find_pc_sect_psymtab, find_pc_sect_psymbol)
7248         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
7249         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
7250         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
7251         (start_psymtab_common, end_psymtab_common)
7252         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
7253         (allocate_psymtab): Update.
7254         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
7255         Update.
7256         (dump_psymtab_addrmap, maintenance_print_psymbols)
7257         (maintenance_check_psymtabs): Update.
7258         (class objfile_psymtabs): Move to objfiles.h.
7259         * psympriv.h (discard_psymtab): Now inline.
7260         (psymtab_discarder::psymtab_discarder): Update.
7261         (psymtab_discarder::~psymtab_discarder): Update.
7262         (ALL_OBJFILE_PSYMTABS): Rewrite.
7263         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
7264         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
7265         Remove fields.
7266         <partial_symtabs>: New field.
7267         (class objfile_psymtabs): Move from psymtab.h.  Update.
7268         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
7269         psymbol_cache.
7270         (objfile::~objfile): Don't destroy psymbol_cache.
7271         * mdebugread.c (parse_partial_symbols): Update.
7272         * dwarf2read.c (create_addrmap_from_index)
7273         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
7274         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
7275         (add_partial_subprogram, dwarf2_ranges_read): Update.
7276         * dwarf-index-write.c (write_address_map)
7277         (write_one_signatured_type, recursively_write_psymbols)
7278         (class debug_names, class debug_names, write_psymtabs_to_index):
7279         Update.
7280
7281 2019-01-10  Tom Tromey  <tom@tromey.com>
7282
7283         * symtab.h (SYMBOL_SET_NAMES): Update.
7284         (symbol_set_names): Update.
7285         (MSYMBOL_SET_NAMES): Update.
7286         * symtab.c (symbol_set_names): Change argument to be an
7287         objfile_per_bfd_storage.
7288         * psymtab.c (add_psymbol_to_bcache): Update.
7289         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
7290
7291 2019-01-10  Tom Tromey  <tom@tromey.com>
7292
7293         * symtab.c (create_demangled_names_hash): Change argument to be an
7294         objfile_per_bfd_storage.
7295         (symbol_set_names): Update.
7296
7297 2019-01-10  Tom Tromey  <tom@tromey.com>
7298
7299         * xcoffread.c (xcoff_initial_scan): Unconditionally call
7300         init_psymbol_list.
7301         * psymtab.c (init_psymbol_list): Do nothing if already called.
7302         * psympriv.h (init_psymbol_list): Add comment.
7303         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
7304         init_psymbol_list.
7305         * dbxread.c (dbx_symfile_read): Unconditionally call
7306         init_psymbol_list.
7307
7308 2019-01-10  Tom Tromey  <tom@tromey.com>
7309
7310         * xcoffread.c (scan_xcoff_symtab): Update.
7311         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
7312         "where".
7313         * mdebugread.c (parse_partial_symbols)
7314         (handle_psymbol_enumerators): Update.
7315         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
7316         * dbxread.c (read_dbx_symtab): Update.
7317         * psympriv.h (psymbol_placement): New enum.
7318         (add_psymbol_to_list): Update.
7319
7320 2019-01-10  Tom Tromey  <tom@tromey.com>
7321
7322         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
7323         static_psymbols parameters.
7324         (scan_xcoff_symtab): Update.
7325         * psymtab.c (start_psymtab_common): Remove global_psymbols and
7326         static_psymbols parameters.
7327         * psympriv.h (start_psymtab_common): Update.
7328         * mdebugread.c (parse_partial_symbols): Update.
7329         * dwarf2read.c (create_partial_symtab): Update.
7330         * dbxread.c (read_dbx_symtab): Update.
7331         (start_psymtab): Remove global_psymbols and static_psymbols
7332         parameters.
7333
7334 2019-01-10  Tom Tromey  <tom@tromey.com>
7335
7336         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
7337         * psymtab.c (allocate_psymtab): Add comment.
7338         * psympriv.h (allocate_psymtab): Add comment.
7339         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
7340         initializations.
7341         * dbxread.c (dbx_end_psymtab): Remove some initializations.
7342
7343 2019-01-10  Tom Tromey  <tom@tromey.com>
7344
7345         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7346         Don't declare.
7347         * mipsread.c: Include mdebugread.h.
7348         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
7349         Declare.
7350         * elfread.c: Include mdebugread.h.
7351
7352 2019-01-09  Tom Tromey  <tom@tromey.com>
7353
7354         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
7355         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
7356         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
7357         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
7358         (psym_lookup_symbol, psym_find_last_source_symtab)
7359         (psym_forget_cached_source_info, psym_print_stats)
7360         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
7361         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
7362         (psym_map_matching_symbols, psym_expand_symtabs_matching)
7363         (psym_find_compunit_symtab_by_address)
7364         (maintenance_print_psymbols, maintenance_info_psymtabs)
7365         (maintenance_check_psymtabs): Use ranged for.
7366         * psymtab.h (class objfile_psymtabs): New.
7367         (require_partial_symbols): Return objfile_psymtabs.
7368         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
7369
7370 2019-01-09  Tom Tromey  <tom@tromey.com>
7371
7372         * symfile.c (overlay_invalidate_all, find_pc_overlay)
7373         (find_pc_mapped_section, list_overlays_command)
7374         (map_overlay_command, unmap_overlay_command)
7375         (simple_overlay_update): Use all_objfiles.
7376         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
7377         * printcmd.c (info_symbol_command): Use all_objfiles.
7378         * objfiles.h (ALL_OBJSECTIONS): Remove.
7379         * maint.c (maintenance_translate_address): Use all_objfiles.
7380         * gcore.c (gcore_create_callback): Use all_objfiles.
7381         (objfile_find_memory_regions): Likewise.
7382
7383 2019-01-09  Tom Tromey  <tom@tromey.com>
7384
7385         * symtab.c (find_line_symtab, info_sources_command)
7386         (make_source_files_completion_list): Use objfile_compunits.
7387         * source.c (select_source_symtab): Use objfile_compunits.
7388         * objfiles.h (struct objfile): Update comment.
7389         (ALL_OBJFILES): Remove.
7390         (ALL_FILETABS): Remove.
7391         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
7392         objfile_compunits.
7393
7394 2019-01-09  Tom Tromey  <tom@tromey.com>
7395
7396         * symmisc.c (print_objfile_statistics, dump_objfile)
7397         (maintenance_print_symbols): Use compunit_filetabs.
7398         * source.c (forget_cached_source_info_for_objfile): Use
7399         compunit_filetabs.
7400         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
7401         (ALL_FILETABS): Use compunit_filetabs.
7402         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
7403         * coffread.c (coff_symtab_read): Use compunit_filetabs.
7404
7405 2019-01-09  Tom Tromey  <tom@tromey.com>
7406
7407         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
7408         (compunit_filetabs): New.
7409         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
7410         compunit_filetabs.
7411         (info_sources_command, make_source_files_completion_list): Remove
7412         declaration.
7413         * symmisc.c (print_objfile_statistics, dump_objfile)
7414         (maintenance_print_symbols): Remove declaration.
7415         (maintenance_info_symtabs): Use compunit_filetabs.
7416         (maintenance_info_line_tables): Likewise.
7417         * source.c (select_source_symtab): Change local variable name.
7418         (forget_cached_source_info_for_objfile): Remove declaration.
7419         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
7420         * objfiles.c (objfile_relocate1): Remove declaration.
7421         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7422         declaration.
7423         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
7424         * coffread.c (coff_symtab_read): Remove declaration.
7425         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
7426         compunit_filetabs.
7427
7428 2019-01-09  Tom Tromey  <tom@tromey.com>
7429
7430         * symtab.c (lookup_objfile_from_block)
7431         (find_pc_sect_compunit_symtab, search_symbols)
7432         (default_collect_symbol_completion_matches_break_on): Use
7433         objfile_compunits.
7434         * objfiles.h (ALL_COMPUNITS): Remove.
7435         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
7436         * cp-support.c (add_symbol_overload_list_qualified): Use
7437         objfile_compunits.
7438         * ada-lang.c (ada_collect_symbol_completion_matches)
7439         (ada_add_global_exceptions): Use objfile_compunits.
7440
7441 2019-01-09  Tom Tromey  <tom@tromey.com>
7442
7443         * source.c (select_source_symtab)
7444         (forget_cached_source_info_for_objfile): Remove declaration.
7445         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
7446         declaration.
7447         * maint.c (count_symtabs_and_blocks): Remove declaration.
7448         * cp-support.c (add_symbol_overload_list_qualified): Remove
7449         declaration.
7450         * coffread.c (coff_symtab_read): Remove declaration.
7451         * symtab.c (lookup_symbol_in_objfile_symtabs)
7452         (basic_lookup_transparent_type_1): Use objfile_compunits.
7453         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
7454         (info_sources_command, search_symbols)
7455         (default_collect_symbol_completion_matches_break_on)
7456         (make_source_files_completion_list): Remove declaration.
7457         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
7458         (ada_collect_symbol_completion_matches)
7459         (ada_add_global_exceptions): Remove declaration.
7460         * linespec.c (iterate_over_all_matching_symtabs): Use
7461         objfile_compunits.
7462         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
7463         (class objfile_compunits): New.
7464         (ALL_COMPUNITS): Use objfile_compunits.
7465         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
7466         (maintenance_check_symtabs, maintenance_info_line_tables): Use
7467         objfile_compunits.
7468         * objfiles.c (objfile_relocate1): Use objfile_compunits.
7469
7470 2019-01-09  Tom Tromey  <tom@tromey.com>
7471
7472         * symtab.c (search_symbols)
7473         (default_collect_symbol_completion_matches_break_on): Use
7474         objfile_msymbols.
7475         * ada-lang.c (ada_lookup_simple_minsym)
7476         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
7477         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
7478         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
7479         objfile_msymbols.
7480         * coffread.c (coff_symfile_read): Use objfile_msymbols.
7481         * symmisc.c (dump_msymbols): Use objfile_msymbols.
7482         * objc-lang.c (find_methods): Use objfile_msymbols.
7483         (info_selectors_command, info_classes_command): Likewise.
7484         * stabsread.c (scan_file_globals): Use objfile_msymbols.
7485         * objfiles.h (class objfile_msymbols): New.
7486         (ALL_OBJFILE_MSYMBOLS): Remove.
7487         (ALL_MSYMBOLS): Remove.
7488
7489 2019-01-09  Tom Tromey  <tom@tromey.com>
7490
7491         * common/next-iterator.h (next_adapter): Add Iterator template
7492         parameter.
7493         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
7494         (class all_objfiles_safe): New.
7495         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
7496         * objfiles.c (put_objfile_before): Update comment.
7497         (add_separate_debug_objfile): Likewise.
7498         (free_all_objfiles): Use all_objfiles_safe.
7499         (objfile_purge_solibs): Likewise.
7500
7501 2019-01-09  Tom Tromey  <tom@tromey.com>
7502
7503         * symtab.c (iterate_over_symtabs, matching_obj_sections)
7504         (expand_symtab_containing_pc, lookup_static_symbol)
7505         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
7506         (find_symbol_at_address, find_line_symtab, find_main_name): Use
7507         all_objfiles.
7508         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
7509         * breakpoint.c (create_overlay_event_breakpoint)
7510         (create_longjmp_master_breakpoint)
7511         (create_std_terminate_master_breakpoint)
7512         (create_exception_master_breakpoint): Use all_objfiles.
7513         * linux-thread-db.c (try_thread_db_load_from_pdir)
7514         (has_libpthread): Use all_objfiles.
7515         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
7516         * linespec.c (iterate_over_all_matching_symtabs)
7517         (search_minsyms_for_name): Use all_objfiles.
7518         * maint.c (maintenance_info_sections): Use all_objfiles.
7519         * main.c (captured_main_1): Use all_objfiles.
7520         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
7521         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
7522         * guile/scm-pretty-print.c
7523         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
7524         * solib-spu.c (append_ocl_sos): Use all_objfiles.
7525         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
7526         (maintenance_print_msymbols): Use all_objfiles.
7527         * source.c (select_source_symtab): Use all_objfiles.
7528         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
7529         * symfile.c (remove_symbol_file_command)
7530         (expand_symtabs_matching, map_symbol_filenames): Use
7531         all_objfiles.
7532         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
7533         all_objfiles.
7534         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
7535         * objc-lang.c (find_methods): Use all_objfiles.
7536         * objfiles.c (have_partial_symbols, have_full_symbols)
7537         (have_minimal_symbols, qsort_cmp)
7538         (default_iterate_over_objfiles_in_search_order): Use
7539         all_objfiles.
7540         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
7541         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
7542         (maintenance_check_psymtabs): Use all_objfiles.
7543         (ALL_PSYMTABS): Remove.
7544         * compile/compile-object-run.c (do_module_cleanup): Use
7545         all_objfiles.
7546         * blockframe.c (find_pc_partial_function): Use all_objfiles.
7547         * cp-support.c (add_symbol_overload_list_qualified): Use
7548         all_objfiles.
7549         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
7550         Use all_objfiles.
7551         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
7552         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
7553         all_objfiles.
7554         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
7555         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
7556         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
7557         Uses all_objfiles.
7558         * solib.c (solib_read_symbols): Use all_objfiles
7559
7560 2019-01-09  Tom Tromey  <tom@tromey.com>
7561
7562         * probe.c (parse_probes_in_pspace): Use all_objfiles.
7563         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
7564         all_objfiles.
7565         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
7566         * symmisc.c (print_symbol_bcache_statistics)
7567         (print_objfile_statistics, maintenance_print_objfiles)
7568         (maintenance_info_symtabs, maintenance_check_symtabs)
7569         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
7570         all_objfiles.
7571         * source.c (forget_cached_source_info): Use all_objfiles.
7572         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
7573         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
7574         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
7575         * objfiles.c (update_section_map): Use all_objfiles.
7576         (shared_objfile_contains_address_p): Likewise.
7577         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
7578         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
7579
7580 2019-01-09  Tom Tromey  <tom@tromey.com>
7581
7582         * common/next-iterator.h: New file.
7583         * objfiles.h (class all_objfiles): New.
7584         (struct objfile_iterator): New.
7585
7586 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7587
7588         * NEWS: Move the description of the changed "frame", "select-frame",
7589          and "info frame" commands to the Changed commands section.
7590
7591 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
7592
7593         * gdbtypes.c (check_stub_method_group): Remove handling of old
7594         mangling schemes.
7595         * linespec.c (find_methods): Likewise.
7596         * stabsread.c (read_member_functions): Likewise.
7597         * valops.c (search_struct_method): Likewise.
7598         (value_struct_elt_for_reference): Likewise.
7599         * NEWS: Mention this change.
7600
7601 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7602
7603         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
7604         print_source_lines.
7605         * source.c (print_source_lines_base): Update line number check.
7606         (print_source_lines): New function.
7607         (source_lines_range::source_lines_range): New function.
7608         * source.h (class source_lines_range): New class.
7609         (print_source_lines): New declaration.
7610
7611 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7612
7613         * linespec.c (linespec_state_destructor): Free self->canonical_names.
7614
7615 2019-01-08  Tom Tromey  <tom@tromey.com>
7616             Simon Marchi  <simon.marchi@ericsson.com>
7617
7618         PR gdb/24060
7619         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
7620         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
7621         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7622         * f-exp.y (DOLLAR_VARIABLE): Likewise.
7623         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
7624         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
7625
7626 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7627
7628         * source.c (select_source_symtab): Move header comment to
7629         declaration in source.h.
7630         (forget_cached_source_info_for_objfile): Likewise.
7631         (forget_cached_source_info): Likewise.
7632         (identify_source_line): Likewise.
7633         * source.h (identify_source_line): Move declaration from symtab.h
7634         and add comment from source.c
7635         (print_source_lines): Likewise.
7636         (forget_cached_source_info_for_objfile): Likewise.
7637         (forget_cached_source_info): Likewise.
7638         (select_source_symtab): Likewise.
7639         (enum print_source_lines_flag): Move definition from symtab.h.
7640         * symtab.h (identify_source_line): Move declaration to source.h.
7641         (print_source_lines): Likewise.
7642         (forget_cached_source_info_for_objfile): Likewise.
7643         (forget_cached_source_info): Likewise.
7644         (select_source_symtab): Likewise.
7645         (enum print_source_lines_flag): Move definition to source.h.
7646         * tui/tui-hooks.c: Add 'source.h' include.
7647
7648 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7649
7650         * source.c (print_source_lines_base): Handle requests to print
7651         reverse line number sequences, and guard against empty lines
7652         string.
7653
7654 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
7655
7656         * source.c (print_source_lines_base): Fix skip of '\r' if next
7657         character is '\n'.
7658
7659 2019-01-06  Tom Tromey  <tom@tromey.com>
7660
7661         * c-exp.y (struct c_parse_state) <macro_original_text,
7662         expansion_obstack>: New member.
7663         (macro_original_text, expansion_obstack): Remove globals.
7664         (scan_macro_expansion, scanning_macro_expansion)
7665         (finished_macro_expansion): Update.
7666         (scan_macro_cleanup): Remove.
7667         (yylex, c_parse): Update.
7668
7669 2019-01-06  Tom Tromey  <tom@tromey.com>
7670
7671         * c-exp.y (struct c_parse_state) <strings>: New member.
7672         (operator_stoken): Update.
7673
7674 2019-01-06  Tom Tromey  <tom@tromey.com>
7675
7676         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
7677         (union type_stack_elt) <typelist_val>: Now a pointer to
7678         std::vector.
7679         (type_stack_cleanup): Don't declare.
7680         (push_typelist): Update.
7681         * parse.c (pop_typelist): Return a std::vector.
7682         (push_typelist): Take a std::vector.
7683         (follow_types): Update.  Do not free args.
7684         (type_stack_cleanup): Remove.
7685         * c-exp.y (struct c_parse_state): New.
7686         (cpstate): New global.
7687         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
7688         (nonempty_typelist): Update.
7689         (func_mod): Create a new vector.
7690         (c_parse): Create a c_parse_state.
7691         (check_parameter_typelist): Do not delete params.
7692         (function_method): Update.  Do not delete type_list.
7693
7694 2019-01-06  Tom Tromey  <tom@tromey.com>
7695
7696         PR gdb/28155:
7697         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
7698         check_typedef.
7699         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
7700         (print_return_value): Likewise.
7701
7702 2019-01-05  Tom Tromey  <tom@tromey.com>
7703
7704         * contrib/cleanup_check.py: Remove.
7705         * contrib/gcc-with-excheck: Remove.
7706         * contrib/exsummary.py: Remove.
7707         * contrib/excheck.py: Remove.
7708
7709 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
7710
7711         * thread.c (delete_thread_1): Add gdb_assert that THR is not
7712         NULL. Initialize tpprev to NULL instead of assigning it
7713         to NULL on the next statement.
7714         * windows-nat.c (windows_delete_thread): Remove check for
7715         main_thread_id before printing thread exit notifications.
7716         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
7717         Remove thread ID check against main_thread_id.
7718         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
7719         windows_delete_thread.
7720         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
7721
7722 2019-01-04  Tom Tromey  <tom@tromey.com>
7723
7724         * compile/compile.c (_initialize_compile): Use upper case for
7725         metasyntactic variables.
7726         * symmisc.c (_initialize_symmisc): Use upper case for
7727         metasyntactic variables.
7728         * psymtab.c (_initialize_psymtab): Use upper case for
7729         metasyntactic variables.
7730         * demangle.c (demangle_command): Use upper case for metasyntactic
7731         variables.
7732         (_initialize_demangler): Likewise.
7733         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
7734         variables.
7735
7736 2019-01-03  Tom Tromey  <tom@tromey.com>
7737
7738         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
7739
7740 2019-01-03  Tom Tromey  <tom@tromey.com>
7741
7742         * python/py-symtab.c (salpy_str): Update.
7743         (struct salpy_sal_object) <symtab>: Now a PyObject.
7744         (salpy_dealloc): Update.
7745         (del_objfile_sal): Use gdbpy_ref.
7746
7747 2019-01-03  Tom Tromey  <tom@tromey.com>
7748
7749         * python/py-type.c (convert_field): Use new_reference.  Return
7750         gdbpy_ref.
7751         (make_fielditem): Return gdbpy_ref.
7752         (typy_fields): Update.
7753         (typy_getitem): Update.
7754         (field_name): Return gdbpy_ref.  Use new_reference.
7755         (typy_iterator_iternext): Update.
7756
7757 2019-01-03  Tom Tromey  <tom@tromey.com>
7758
7759         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
7760
7761 2019-01-03  Tom Tromey  <tom@tromey.com>
7762
7763         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
7764         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
7765         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
7766         (pspy_set_frame_filters, pspy_set_frame_unwinders)
7767         (pspy_set_type_printers): Likewise.
7768         * python/py-function.c (fnpy_init): Use gdbpy_ref.
7769         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
7770         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
7771         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
7772         (objfpy_set_type_printers): Likewise.
7773
7774 2019-01-03  Tom Tromey  <tom@tromey.com>
7775
7776         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
7777         (gdbpy_print_stack): Use gdbpy_err_fetch.
7778         * python/python-internal.h (class gdbpy_err_fetch): New class.
7779         (class gdbpy_enter) <m_error_type, m_error_value,
7780         m_error_traceback>: Remove.
7781         <m_error>: New member.
7782         (gdbpy_exception_to_string): Don't declare.
7783         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
7784         * python/py-value.c (convert_value_from_python): Use
7785         gdbpy_err_fetch.
7786         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
7787         gdbpy_exception_to_string.
7788         (gdbpy_handle_exception): Use gdbpy_err_fetch.
7789         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
7790         gdbpy_err_fetch.
7791
7792 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7793
7794         * linux-nat.c (delete_lwp_cleanup): Delete.
7795         (struct lwp_deleter): New struct.
7796         (lwp_info_up): New typedef.
7797         (linux_nat_target::follow_fork): Delete cleanup, and make use of
7798         lwp_info_up.
7799
7800 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7801
7802         * linux-fork.c (class scoped_switch_fork_info): New class.
7803         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
7804
7805 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7806
7807         * valops.c (find_overload_match): Remove use of null_cleanup, and
7808         calls to do_cleanups.
7809
7810 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7811
7812         * compile/compile-cplus-types.c
7813         (compile_cplus_instance::decl_name): Handle changes to
7814         cp_func_name.
7815         * cp-support.c (cp_func_name): Update header comment, update
7816         return type.
7817         * cp-support.h (cp_func_name): Update return type in declaration.
7818         * valops.c (find_overload_match): Move temp_func local to top
7819         level of function and change its type.  Use temp_func to hold and
7820         delete temporary string obtained from cp_func_name.
7821
7822 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
7823
7824         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
7825         gdb::char_vector, remove cleanup, and update uses of `msg`.
7826
7827 2019-01-03  Jim Wilson  <jimw@sifive.com>
7828
7829         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
7830
7831 2019-01-02  Tom Tromey  <tom@tromey.com>
7832
7833         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
7834         (tdesc_parse_xml): Remove cleanups.
7835         * target-descriptions.h (make_cleanup_free_target_description):
7836         Don't declare.
7837         (target_desc_deleter): New struct.
7838         (target_desc_up): New typedef.
7839         * target-descriptions.c (target_desc_deleter::operator()): Rename
7840         from free_target_description.
7841         (make_cleanup_free_target_description): Remove.
7842
7843 2019-01-02  Tom Tromey  <tom@tromey.com>
7844
7845         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
7846         constructor, destructor.
7847         (linespec_parser): Remove typedef.
7848         (~linespec_parser): Rename from linespec_parser_delete.
7849         (linespec_lex_to_end, linespec_complete_label)
7850         (linespec_complete): Update.
7851         (decode_line_full): Remove cleanups.
7852         (decode_line_1): Update.
7853
7854 2019-01-02  Tom Tromey  <tom@tromey.com>
7855
7856         * python/python-internal.h (inferior_to_inferior_object): Change
7857         return type.
7858         * python/py-exitedevent.c (create_exited_event_object): Update.
7859         * python/py-inferior.c (inferior_to_inferior_object): Return
7860         gdbpy_ref.
7861         (python_new_inferior, python_inferior_deleted)
7862         (thread_to_thread_object, delete_thread_object)
7863         (build_inferior_list, gdbpy_selected_inferior): Update.
7864         * python/py-infthread.c (create_thread_object): Update.  Also fail
7865         if inferior_to_inferior_object fails.
7866
7867 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
7868
7869         * inferior.h (class inferior) <displaced_step_state>: New field.
7870         * infrun.h (struct displaced_step_state): Move here from
7871         infrun.c.  Initialize fields, add constructor.
7872         <inf>: Remove field.
7873         <reset>: New method.
7874         * infrun.c (struct displaced_step_inferior_state): Move to
7875         infrun.h.
7876         (displaced_step_inferior_states): Remove.
7877         (get_displaced_stepping_state): Adust.
7878         (displaced_step_in_progress_any_inferior): Adjust.
7879         (displaced_step_in_progress_thread): Adjust.
7880         (displaced_step_in_progress): Adjust.
7881         (add_displaced_stepping_state): Remove.
7882         (get_displaced_step_closure_by_addr): Adjust.
7883         (remove_displaced_stepping_state): Remove.
7884         (infrun_inferior_exit): Call displaced_step_state.reset.
7885         (use_displaced_stepping): Don't check for NULL.
7886         (displaced_step_prepare_throw): Call
7887         get_displaced_stepping_state.
7888         (displaced_step_fixup): Don't check for NULL.
7889         (prepare_for_detach): Don't check for NULL.
7890
7891 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7892
7893         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
7894          in case of call that did not complete.
7895
7896 2019-01-02  Andrey Utkin  <autkin@undo.io>
7897
7898         * symfile.c (find_separate_debug_file): Fix search of debug files for
7899         remote debuggee.
7900
7901 2019-01-02  Tom Tromey  <tom@tromey.com>
7902
7903         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
7904         indentation.
7905         * python/py-frame.c (frapy_older): Remove cast.
7906         (frapy_newer): Likewise.
7907         * python/py-breakpoint.c (local_setattro): Remove cast.
7908         * python/py-arch.c (archpy_name): Remove local variable.
7909         * python/py-type.c (gdbpy_lookup_type): Remove cast.
7910
7911 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
7912
7913         * unittests/basic_string_view/element_access/char/empty.cc:
7914         Fix year range in copyright header.
7915
7916 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
7917
7918         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
7919         Delete.
7920         <operator==>: Update with for removed field.
7921         <hash>: Likewise.
7922         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
7923         <isa_features>: ...this.
7924         <abi_features>: New field.
7925         (riscv_isa_flen): Update comment.
7926         (riscv_abi_xlen): New declaration.
7927         (riscv_abi_flen): New declaration.
7928         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
7929         isa_features.
7930         (riscv_abi_xlen): New function.
7931         (riscv_isa_flen): Update to get answer from isa_features.
7932         (riscv_abi_flen): New function.
7933         (riscv_has_fp_abi): Update to get answer from abi_features.
7934         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
7935         xlen and flen.
7936         (riscv_call_info) <xlen, flen>: Update comment.
7937         (riscv_call_arg_struct): Remove invalid assertions
7938         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
7939         is removed.
7940         (riscv_gdbarch_init): Gather isa features and abi features
7941         separately, ensure both match on the gdbarch when reusing an old
7942         gdbarch.  Relax an error check to allow 32-bit abi float to run on
7943         a target with 64-bit float hardware.
7944
7945 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7946
7947         * source.c (search_command_helper): Stop reverse search
7948         when line 1 has been searched.
7949
7950 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7951
7952         * record-full.c (record_full_base_target::close): Rewrite
7953         record_full_core_buf_list free logic.
7954
7955 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7956
7957         * break-catch-syscall.c (print_one_catch_syscall): xfree
7958         the last text.
7959
7960 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7961
7962         * top.c (print_gdb_version): Update Copyright year in version
7963         message.
7964
7965 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
7966
7967         Update copyright year range in all GDB files.
7968
7969 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
7970
7971         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
7972
7973 For older changes see ChangeLog-2018.
7974 \f
7975 Local Variables:
7976 mode: change-log
7977 left-margin: 8
7978 fill-column: 74
7979 version-control: never
7980 coding: utf-8
7981 End:
7982