gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui.c (tui_show_source): Update.
   4         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
   5         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
   6         a symtab_symbol_info, not a separate symtab and line.  Simplify.
   7
   8 2019-12-20  Tom Tromey  <tom@tromey.com>
   9
  10         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
  11         Simplify.
  12
  13 2019-12-20  Tom Tromey  <tom@tromey.com>
  14
  15         * tui/tui-winsource.h (struct tui_source_window_base)
  16         <set_contents, update_source_window_as_is, update_source_window>:
  17         Take a sal, not a separate symtab and tui_line_or_address.
  18         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
  19         (tui_source_window_base::update_source_window_as_is): Take a sal,
  20         not a separate symtab and tui_line_or_address.
  21         (tui_update_source_windows_with_addr)
  22         (tui_update_source_windows_with_line)
  23         (tui_source_window_base::rerender)
  24         (tui_source_window_base::refill): Update.
  25         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
  26         a sal, not a separate symtab and tui_line_or_address.
  27         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
  28         not a separate symtab and tui_line_or_address.
  29         (tui_source_window::maybe_update): Update.
  30         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
  31         a sal, not a separate symtab and tui_line_or_address.
  32         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
  33         not a separate symtab and tui_line_or_address.
  34         (tui_disasm_window::do_scroll_vertical)
  35         (tui_disasm_window::maybe_update): Update.
  36
  37 2019-12-20  Tom Tromey  <tom@tromey.com>
  38
  39         * tui/tui-winsource.c (tui_source_window_base::refill): Use
  40         start_line_or_addr.
  41         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
  42         start_line_or_addr.
  43         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
  44         start_line_or_addr.
  45
  46 2019-12-20  Tom Tromey  <tom@tromey.com>
  47
  48         * tui/tui-winsource.h (struct tui_source_window_base)
  49         <set_contents>: Return bool.
  50         * tui/tui-winsource.c
  51         (tui_source_window_base::update_source_window_as_is): Update.
  52         * tui/tui-source.h (struct tui_source_window) <set_contents>:
  53         Return bool.
  54         * tui/tui-source.c (tui_source_window::set_contents): Return
  55         bool.  Simplify.
  56         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
  57         Return bool.
  58         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
  59         bool.
  60
  61 2019-12-20  Tom Tromey  <tom@tromey.com>
  62
  63         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
  64         (tui_update_source_windows_with_line): Call update_source_window.
  65         * tui/tui-source.h (struct tui_source_window)
  66         <show_symtab_source>: Don't declare.
  67         * tui/tui-source.c (tui_source_window::show_symtab_source):
  68         Remove.
  69
  70 2019-12-20  Tom Tromey  <tom@tromey.com>
  71
  72         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
  73         update_source_window directly.
  74         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
  75         * tui/tui-disasm.c (tui_show_disassem): Remove.
  76
  77 2019-12-20  Tom Tromey  <tom@tromey.com>
  78
  79         * tui/tui-winsource.c
  80         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
  81         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
  82
  83 2019-12-20  Tom Tromey  <tom@tromey.com>
  84
  85         * tui/tui-winsource.h (struct tui_source_window_base)
  86         <maybe_update>: Remove line_no and addr parameters.
  87         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
  88         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
  89         Update.
  90         * tui/tui-source.c (tui_source_window::maybe_update): Remove
  91         line_no and addr parameters.
  92         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
  93         Update.
  94         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
  95         line_no and addr parameters.
  96
  97 2019-12-20  Tom Tromey  <tom@tromey.com>
  98
  99         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 100         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 101
 102 2019-12-20  Tom Tromey  <tom@tromey.com>
 103
 104         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 105         tui_show_disassem.
 106         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 107         declare.
 108         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 109
 110 2019-12-20  Tom Tromey  <tom@tromey.com>
 111
 112         * tui/tui.h (tui_show_source): Remove parameters.
 113         * tui/tui.c (tui_show_source): Remove parameters.
 114         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 115
 116 2019-12-20  Tom Tromey  <tom@tromey.com>
 117
 118         * tui/tui.c (tui_show_source): Update.
 119         * tui/tui-winsource.c (tui_display_main): Update.
 120         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 121         to symtab.
 122         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 123         to symtab.
 124         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 125
 126 2019-12-20  Tom Tromey  <tom@tromey.com>
 127
 128         PR tui/23619:
 129         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 130         (tui_redisplay_readline): Use rl_display_prompt.
 131         (tui_prep_terminal): Update.
 132
 133 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 134
 135         * configure: Regenerate.
 136         * configure.ac: Quote variable arguments of test.
 137         * gdbsupport/common.m4: Likewise.
 138
 139 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 140
 141         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 142         2 to pow ().
 143
 144 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 145
 146         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 147         log10 to double to fix Solaris 11 with gcc 5.5.
 148
 149 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 150
 151         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 152         "sun" to "saddr_un".
 153
 154 2019-12-19  Tom Tromey  <tromey@adacore.com>
 155
 156         * ui-out.h (enum class field_kind): Fix comment.
 157
 158 2019-12-11  Tom Tromey  <tromey@adacore.com>
 159
 160         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 161
 162 2019-12-18  Tom Tromey  <tromey@adacore.com>
 163
 164         PR build/25268:
 165         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 166         type on macOS.  Add comment.
 167
 168 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 169
 170         * c-lang.c (c_get_string, asm_language_defn): Remove space
 171         before tab.
 172
 173 2019-12-18  Tom Tromey  <tromey@adacore.com>
 174
 175         PR build/25250:
 176         * ui-out.c (ui_out::vmessage): Update.
 177         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 178         Rename.
 179         (string_field): Update.
 180         (signed_field): Update.
 181
 182 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 183
 184         * top.c (print_gdb_configuration): Adjust indentation.
 185
 186 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 187
 188         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 189
 190 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 191
 192         * tui/tui-layout.h (class tui_layout_base): Add virtual
 193         destructor.
 194
 195 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 196
 197         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 198         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 199         (process_event_stop_test): Keep stepping over skipped inline functions.
 200
 201 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 202
 203         * jit.c (struct gdb_block) <next>: Remove field.
 204         (struct gdb_symtab) <~gdb_symtab>: Remove.
 205         <blocks>: Change type to std::forward_list<gdb_block>.
 206         (compare_block): Remove.
 207         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 208         block at the beginning, don't mind about sorting.
 209         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 210         before using it.
 211
 212 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 213
 214         * jit.c (struct gdb_block): Add constructor, initialize
 215         real_block and next fields.
 216         <name>: Change type to gdb::unique_xmalloc_ptr.
 217         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 218         (jit_block_open_impl): Allocate gdb_block with new.
 219         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 220
 221 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 222
 223         * jit.c: Include forward_list.
 224         (struct gdb_symtab) <next>: Remove field.
 225         (struct gdb_object) <symtabs>: Change type to
 226         std::forward_list<gdb_symtab>.
 227         (jit_object_open_impl): Allocate gdb_object with new.
 228         (jit_symtab_open_impl): Adjust to std::forward_list.
 229         (finalize_symtab): Don't delete symtab.
 230         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 231         gdb_object with delete.
 232
 233 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 234
 235         * jit.c (struct gdb_symtab): Add constructor, destructor,
 236         initialize fields.
 237         <linetable>: Change type to unique_xmalloc_ptr.
 238         <file_name>: Change type to std::string.
 239         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 240         (jit_symtab_line_mapping_add_impl): Adjust.
 241         (finalize_symtab): Adjust, call delete on stab.
 242
 243 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 244
 245         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 246
 247 2019-12-16  Tom Tromey  <tromey@adacore.com>
 248
 249         * windows-nat.c (windows_nat_target::attach): Update.
 250         * remote.c (extended_remote_target::attach): Update.
 251         * procfs.c (procfs_target::attach): Update.
 252         * nto-procfs.c (nto_procfs_target::attach): Update.
 253         (nto_procfs_target::create_inferior): Update.
 254         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 255         * gnu-nat.c (gnu_nat_target::attach): Update.
 256         (gnu_nat_target::detach): Update.
 257         * darwin-nat.c (darwin_nat_target::attach): Update.
 258         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 259         return.
 260         * bsd-kvm.c (bsd_kvm_target_open): Update.
 261         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 262
 263 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 264
 265         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 266         (we no longer need to include time.h before pathmax.h)
 267
 268 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 269
 270         * ada-exp.y (write_ambiguous_var): Update.
 271         * coffread.c (process_coff_symbol): Update.
 272         * ctfread.c (ctf_add_enum_member_cb): Update.
 273         (new_symbol): Update.
 274         * dwarf2read.c (fixup_go_packaging): Update.
 275         (new_symbol): Update.
 276         * language.c (language_alloc_type_symbol): Update.
 277         * mdebugread.c (new_symbol): Update.
 278         * minsyms.c (minimal_symbol_reader::record_full): Update.
 279         * psymtab.c (add_psymbol_to_bcache): Update.
 280         * stabsread.c (define_symbol): Update.
 281         (read_enum_type): Update.
 282         * symtab.c (symbol_set_language): Make this a member function...
 283         (general_symbol_info::set_language): ... here.
 284         * symtab.h (struct general_symbol_info) <set_language>: New function.
 285         (SYMBOL_SET_LANGUAGE): Remove.
 286         (symbol_set_language): Remove.
 287
 288 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 289
 290         * ada-lang.c (ada_add_block_symbols): Update.
 291         (ada_collect_symbol_completion_matches): Update.
 292         * ax-gdb.c (gen_expr): Update.
 293         * block.c (block_lookup_symbol): Update.
 294         (block_lookup_symbol_primary): Update.
 295         (block_find_symbol): Update.
 296         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 297         * dbxread.c (process_one_symbol): Update.
 298         * dictionary.c (insert_symbol_hashed): Update.
 299         (collate_pending_symbols_by_language): Update.
 300         (mdict_add_symbol): Update.
 301         * dwarf-index-write.c (write_psymbols): Update.
 302         * dwarf2read.c (fixup_go_packaging): Update.
 303         * findvar.c (read_var_value): Update.
 304         * ft32-tdep.c (ft32_skip_prologue): Update.
 305         * go-lang.c (go_symbol_package_name): Update.
 306         * language.h (scoped_switch_to_sym_language_if_auto::
 307         scoped_switch_to_sym_language_if_auto): Update.
 308         * linespec.c (find_method): Update.
 309         (find_label_symbols_in_block): Update.
 310         * mdebugread.c (parse_symbol): Update.
 311         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 312         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 313         (minimal_symbol_reader::install): Update.
 314         * moxie-tdep.c (moxie_skip_prologue): Update.
 315         * parse.c (parse_exp_in_context): Update.
 316         * psymtab.c (psymbol_name_matches): Update.
 317         (match_partial_symbol): Update.
 318         (lookup_partial_symbol): Update.
 319         (psymbol_hash): Update.
 320         (psymbol_compare): Update.
 321         * python/py-framefilter.c (extract_sym): Update.
 322         (py_print_single_arg): Update.
 323         * stabsread.c (define_symbol): Update.
 324         * stack.c (print_frame_arg): Update.
 325         (find_frame_funname): Update.
 326         (info_frame_command_core): Update.
 327         * symfile.c (set_initial_language): Update.
 328         * symtab.c (symbol_set_demangled_name): Update.
 329         (symbol_get_demangled_name): Update.
 330         (symbol_set_language): Update.
 331         (symbol_find_demangled_name): Update.
 332         (symbol_set_names): Update.
 333         (general_symbol_info::natural_name): Update.
 334         (general_symbol_info::demangled_name): Update.
 335         (general_symbol_info::search_name): Update.
 336         (symbol_matches_search_name): Update.
 337         (eq_symbol_entry): Update.
 338         (iterate_over_symbols): Update.
 339         (completion_list_add_symbol): Update.
 340         (completion_list_add_msymbol): Update.
 341         (completion_list_add_fields): Update.
 342         * symtab.h (struct general_symbol_info) <language>: New function.
 343         <language>: Rename to...
 344         <m_language>: ...this.
 345         (SYMBOL_LANGUAGE): Remove.
 346         (MSYMBOL_LANGUAGE): Remove.
 347         (struct symbol) <ctor>: Update.
 348         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 349
 350 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 351
 352         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 353         set the language of sym.
 354         * language.c (language_alloc_type_symbol): Likewise.
 355
 356 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 357
 358         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 359         PR gdb/23613
 360         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 361         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 362         (core_target_open): Use 'gdb_abspath'.
 363         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 364         'current_directory == NULL' case.
 365         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 366         explain what happens when 'current_directory' is NULL.
 367         * go32-nat.c (go32_nat_target::wait): Check if
 368         'current_directory' is NULL before call to 'chdir'.
 369         * source.c (add_path): Use 'gdb_abspath'.
 370         * top.c: Include 'gdbsupport/pathstuff.h'.
 371         (init_history): Use 'gdb_abspath'.
 372         (set_history_filename): Likewise.
 373         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 374         (tfile_target_open): Use 'gdb_abspath'.
 375
 376 2019-12-13  Tom Tromey  <tromey@adacore.com>
 377
 378         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 379         warning or error.
 380
 381 2019-12-13  Tom Tromey  <tromey@adacore.com>
 382
 383         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 384
 385 2019-12-13  Tom Tromey  <tromey@adacore.com>
 386
 387         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 388
 389 2019-12-13  Tom Tromey  <tromey@adacore.com>
 390
 391         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 392
 393 2019-12-13  Tom Tromey  <tromey@adacore.com>
 394
 395         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 396         (string_vappendf): Add ARI comment.
 397
 398 2019-12-13  Tom Tromey  <tromey@adacore.com>
 399
 400         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 401         floatformat_to_double.
 402         * target-float.c (host_float_ops<T>::from_target): Add ARI
 403         comment.
 404
 405 2019-12-13  Tom Tromey  <tromey@adacore.com>
 406
 407         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 408         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 409         ARI marker to abort.
 410         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 411
 412 2019-12-13  Tom Tromey  <tromey@adacore.com>
 413
 414         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 415
 416 2019-12-13  Tom Tromey  <tromey@adacore.com>
 417
 418         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 419
 420 2019-12-13  Tom Tromey  <tromey@adacore.com>
 421
 422         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 423         checks.
 424
 425 2019-12-13  Tom Tromey  <tromey@adacore.com>
 426
 427         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 428         end>: No longer "const".
 429
 430 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 431
 432         * jit.c: Fix indentation, replace spaces with tabs where
 433         applicable.
 434
 435 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 436
 437         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 438
 439 2019-12-12  Tom Tromey  <tom@tromey.com>
 440
 441         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 442         unique_ptr.
 443
 444 2019-12-12  Tom Tromey  <tom@tromey.com>
 445
 446         * progspace.h (objfile_list): New typedef.
 447         (class unwrapping_objfile_iterator)
 448         (struct unwrapping_objfile_range): Newl
 449         (struct program_space) <objfiles_range>: Change type.
 450         <objfiles>: Change return type.
 451         <add_objfile>: Change type of "objfile" parameter.
 452         <objfiles_list>: Now a list of shared_ptr.
 453         * progspace.c (program_space::add_objfile): Change type of
 454         "objfile".  Update.
 455         (program_space::remove_objfile): Update.
 456         * objfiles.h (struct objfile) <~objfile>: Make public.
 457         * objfiles.c (objfile::make): Update.
 458         (objfile::unlink): Don't call delete.
 459
 460 2019-12-12  Tom Tromey  <tom@tromey.com>
 461
 462         * symfile.c (symbol_file_clear): Update.
 463         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 464         method.
 465         * progspace.c (program_space::free_all_objfiles): New method.
 466         * objfiles.h (free_all_objfiles): Don't declare.
 467         * objfiles.c (free_all_objfiles): Move to program_space.
 468
 469 2019-12-12  Tom Tromey  <tom@tromey.com>
 470
 471         * progspace.c (program_space::add_objfile)
 472         (program_space::remove_objfile): Update.
 473         (program_space::multi_objfile_p): Remove.
 474         * objfiles.h (struct objfile) <next>: Remove.
 475         * objfiles.c (objfile::objfile): Update.
 476         (put_objfile_before): Update.
 477         (unlink_objfile): Update.
 478         * progspace.h (object_files): Remove.
 479         (struct program_space) <objfiles_head>: Remove.
 480         <objfiles_list>: New member.
 481         <objfiles_range, objfiles_safe_range>: Change type.
 482         (objfiles): Change return type.
 483         (objfiles_safe): Update.
 484         (multi_objfile_p): Rewrite and inline.
 485         (object_files): Remove macro.
 486
 487 2019-12-12  Tom Tromey  <tom@tromey.com>
 488
 489         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 490         second constructor.
 491         (basic_safe_range): New class.
 492
 493 2019-12-12  Tom Tromey  <tom@tromey.com>
 494
 495         * progspace.c (program_space::multi_objfile_p): New method.
 496         * printcmd.c (info_symbol_command): Update.
 497         * maint.c (maintenance_translate_address): Update.
 498         * objfiles.h (MULTI_OBJFILE_P): Remove.
 499         * progspace.h (struct program_space) <multi_objfile_p>: New
 500         method.
 501
 502 2019-12-12  Tom Tromey  <tom@tromey.com>
 503
 504         * progspace.h (struct program_space) <remove_objfile>: Declare.
 505         * progspace.c (program_space::remove_objfile): New method.
 506         * objfiles.c (unlink_objfile): Remove.
 507         (objfile::unlink): Call remove_objfile.
 508         (objfile): Don't call unlink_objfile.
 509
 510 2019-12-12  Tom Tromey  <tom@tromey.com>
 511
 512         * progspace.h (struct program_space) <add_objfile>: Declare
 513         method.
 514         * progspace.c (program_space::add_objfile): New method.
 515         * objfiles.c (~objfile): Don't unlink objfile.
 516         (put_objfile_before): Remove.
 517         (add_separate_debug_objfile): Don't call put_objfile_before.
 518         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 519         the per-program-space data.
 520
 521 2019-12-12  Tom Tromey  <tom@tromey.com>
 522
 523         * symfile.c (syms_from_objfile_1): Use objfile_up.
 524         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 525         method.
 526         (reread_symbols): Use objfile_up.
 527         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 528         unlink method.
 529         * objfiles.h (struct objfile) <~objfile>: Now private.
 530         <unlink>: New method.
 531         (struct objfile_deleter): New.
 532         (objfile_up): New typedef.
 533         * objfiles.c (objfile::unlink): New method.
 534         (free_objfile_separate_debug, free_all_objfiles)
 535         (objfile_purge_solibs): Use it.
 536         * jit.c (jit_unregister_code): Remove.
 537         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 538         objfile.
 539         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 540         objfile.
 541         * compile/compile-object-load.c (compile_object_load): Use
 542         objfile_up.
 543
 544 2019-12-12  Tom Tromey  <tom@tromey.com>
 545
 546         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 547         objfile::make.
 548         * objfiles.h (struct objjfile) <make>: No longer inline.
 549         (add_separate_debug_objfile): Don't declare.
 550         * objfiles.c (add_separate_debug_objfile): Now static.
 551         (objfile::make): Move from objfiles.h.  Call
 552         add_separate_debug_objfile.  Add "parent" parameter.
 553
 554 2019-12-12  Tom Tromey  <tom@tromey.com>
 555
 556         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 557         * objfiles.h (struct objfile): Make constructor private.
 558         <make>: New static method.
 559         * jit.c (jit_object_close_impl): Update.
 560
 561 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 562
 563         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 564         gdb::byte_vector.
 565
 566 2019-12-12  Tom Tromey  <tromey@adacore.com>
 567
 568         * xml-support.c (xml_fetch_content_from_file): Don't call
 569         malloc_failure.
 570         * utils.h (class gdb_argv): Remove malloc_failure comment.
 571         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 572
 573 2019-12-12  Tom Tromey  <tromey@adacore.com>
 574
 575         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 576         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 577         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 578         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 579         * riscv-ravenscar-thread.c: New file.
 580         * riscv-ravenscar-thread.h: New file.
 581         * riscv-tdep.c (riscv_gdbarch_init): Call
 582         register_riscv_ravenscar_ops.
 583
 584 2019-12-12  Tom Tromey  <tromey@adacore.com>
 585
 586         * gdbsupport/thread-pool.c (set_thread_name): Use
 587         ATTRIBUTE_UNUSED.
 588
 589 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 590
 591         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 592         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 593         macros.
 594
 595 2019-12-11  Tom Tromey  <tom@tromey.com>
 596
 597         * tui/tui-win.c (tui_set_win_height_command): Call
 598         tui_adjust_window_height.
 599         (tui_adjust_win_heights, new_height_ok): Remove.
 600         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 601         * tui/tui-layout.c (tui_adjust_window_height): New function.
 602
 603 2019-12-11  Tom Tromey  <tom@tromey.com>
 604
 605         * tui/tui-win.c (tui_resize_all): Remove code, call
 606         tui_apply_current_layout.
 607
 608 2019-12-11  Tom Tromey  <tom@tromey.com>
 609
 610         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 611         * tui/tui-layout.c (standard_layouts, applied_layout): New
 612         globals.
 613         (tui_apply_current_layout): New function.
 614         (show_layout): Set applied_layout.  Call
 615         tui_apply_current_layout.
 616         (show_source_command, show_disasm_command)
 617         (show_source_disasm_command, show_data)
 618         (show_source_or_disasm_and_command): Remove.
 619         (initialize_layouts): New function.
 620         (_initialize_tui_layout): Call initialize_layouts.
 621
 622 2019-12-11  Tom Tromey  <tom@tromey.com>
 623
 624         * tui/tui-layout.h (class tui_layout_base)
 625         (class tui_layout_window, class tui_layout_split): New.
 626         * tui/tui-layout.c (tui_get_window_by_name)
 627         (tui_layout_window::clone, tui_layout_window::apply)
 628         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 629         (tui_layout_split::add_window, tui_layout_split::clone)
 630         (tui_layout_split::get_sizes)
 631         (tui_layout_split::set_weights_from_heights)
 632         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 633         functions.
 634         (tui_layout_split::add_split, tui_layout_split::add_split)
 635         (tui_layout_split::set_weights_from_heights)
 636         (tui_layout_split::set_weights_from_heights): New functions.
 637
 638 2019-12-11  Tom Tromey  <tom@tromey.com>
 639
 640         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 641         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 642         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 643         * tui/tui-data.h (struct tui_point): Remove.
 644         (struct tui_gen_win_info) <origin>: Remove.
 645         <x, y>: New fields.
 646         * tui/tui-command.c (tui_cmd_window::resize): Update.
 647
 648 2019-12-11  Tom Tromey  <tom@tromey.com>
 649
 650         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 651         Implement.
 652         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 653         Implement.
 654         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 655         method.
 656         (struct tui_win_info) <min_height>: Implement.
 657
 658 2019-12-11  Tom Tromey  <tom@tromey.com>
 659
 660         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 661         (struct tui_win_info) <can_box>: Update.
 662
 663 2019-12-11  Tom Tromey  <tom@tromey.com>
 664
 665         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 666         method.
 667         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 668         method.
 669         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 670         method.
 671         (struct tui_win_info) <max_height>: Now override.
 672
 673 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 674
 675         * NEWS: Create a new section for the next release branch.
 676         Rename the section of the current branch, now that it has
 677         been cut.
 678
 679 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 680
 681         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 682         * version.in: Bump version to 10.0.50.DATE-git.
 683
 684 2019-12-11  Tom Tromey  <tromey@adacore.com>
 685
 686         PR build/25268:
 687         * gdbsupport/thread-pool.c (set_thread_name): New function.
 688         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 689         (thread_pool::thread_function): Call set_thread_name.
 690
 691 2019-12-11  Tom Tromey  <tromey@adacore.com>
 692
 693         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 694         bfd_get_signed_8.
 695
 696 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 697
 698         * NEWS: Document -raw-values option and the related setting commands.
 699         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 700         only set it on when /r is given.
 701         * valprint.c (value_print_option_defs): New element raw-values.
 702         * Makefile.in: Add the new file.
 703
 704 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 705
 706         * gdbsupport/safe-strerror.c: Supress the unused function warning
 707         for select_strerror_r.
 708
 709 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 710
 711         * config.in: Regenerate.
 712         * configure: Regenerate.
 713         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 714         safe_strerror instead of strerror.
 715         * gdbsupport/common.m4: Don't check for strerror.
 716         * gdbsupport/safe-strerror.c: Support both the glibc version
 717         of strerror_r and the XSI version.
 718
 719 2019-12-10  Tom Tromey  <tromey@adacore.com>
 720
 721         * ada-typeprint.c (print_choices): Use a single "?".
 722         (print_variant_part): Print "?" if the discriminant name
 723         is not known.
 724
 725 2019-12-10  George Barrett  <bob@bob131.so>
 726
 727         Fix scripted probe breakpoints.
 728         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 729         declaration forward.
 730         (breakpoint_ops_for_event_location_type)
 731         (breakpoint_ops_for_event_location): Add function definitions.
 732         (break_command_1, trace_command): Use
 733         breakpoint_ops_for_event_location.
 734         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 735         declarations.
 736         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 737         breakpoint_ops_for_event_location.
 738         * python/py-breakpoint.c (bppy_init): Use
 739         breakpoint_ops_for_event_location.
 740
 741 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 742
 743         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 744         when ranking an lvalue argument for an rvalue parameter.
 745
 746 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 747
 748         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 749         template argument for scoped_restore_tmpl from bool to int.
 750
 751 2019-12-07  Keith Seitz  <keiths@redhat.com>
 752
 753         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 754         (build_id_to_debug_bfd): Make static, rewriting to use
 755         build_id_to_bfd_suffix.
 756         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 757         adding `suffix' parameter. Append SUFFIX to file names
 758         when searching for matching files.
 759         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 760         (build_id_to_exec_bfd): Likewise.
 761         * build-id.h (build_id_to_debug_bfd): Clarify that function
 762         searches for BFD of debug info file.
 763         (build_id_to_exec_bfd): Declare.
 764         * corelow.c: Include build-id.h.
 765         (locate_exec_from_corefile_build_id): New function.
 766         (core_target_open): If no executable BFD is found,
 767         search for a core file BFD using build-id.
 768
 769 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 770
 771         * bcache.c: Put in namespace gdb.
 772         * bcache.h: Likewise.
 773         * gdbtypes.c (check_types_worklist): Update.
 774         (types_deeply_equal): Update.
 775         * macrotab.c (struct macro_table) <bcache>: Update.
 776         (new_macro_table): Update.
 777         * macrotab.h (struct bcache): Put this forward declaration
 778         inside namespace gdb.
 779         (new_macro_table): Update.
 780         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 781         Update.
 782         <macro_cache>: Update.
 783         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 784
 785 2019-12-06  Tom de Vries  <tdevries@suse.de>
 786
 787         PR symtab/24971
 788         * block.c (best_symbol, better_symbol): New function.
 789         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 790         decl.
 791
 792 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 793
 794         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 795         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 796         for ranking see-through reference cases.
 797
 798 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 799         * stack.c (faas_command): Check a command is provided.
 800         * thread.c (taas_command, tfaas_command): Likewise.
 801
 802 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 803         * inferior.c (prune_inferiors):  Only call delete_inferior,
 804         Do not modify the inferior list.
 805
 806 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 807
 808         * c-exp.y: Update calls to lookup_typename,
 809         lookup_signed_typename and lookup_unsigned_typename.
 810         * c-lang.c (evaluate_subexp_c): Likewise.
 811         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 812         Likewise.
 813         * eval.c (binop_promote): Likewise.
 814         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 815         (lookup_unsigned_typename): Likewise.
 816         (lookup_signed_typename): Likewise.
 817         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 818         (lookup_signed_typename): Likewise.
 819         (lookup_typename): Likewise.
 820         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 821         lookup_typename, lookup_signed_typename,
 822         lookup_unsigned_typename.
 823         * m2-exp.y: Likewise.
 824         * printcmd.c (printf_wide_c_string): Likewise.
 825         (ui_printf): Likewise.
 826         * python/py-type.c (typy_lookup_typename): Likewise.
 827         * python/py-xmethods.c (python_xmethod_worker::invoke):
 828         Likewise.
 829         * rust-exp.y: Likewise.
 830
 831 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 832
 833         * configure.nat (obsd64): Add missing files x86-nat.o and
 834         nat/x86-dregs.o.
 835
 836 2019-12-04  Tom Tromey  <tom@tromey.com>
 837
 838         * valprint.c (val_print_string): Use metadata_style.
 839         * go-valprint.c (print_go_string): Use metadata style.
 840         * p-valprint.c (pascal_object_print_static_field): Use metadata
 841         style.
 842         * cp-valprint.c (cp_print_static_field): Use metadata style.
 843
 844 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 845             Chris January  <chris.january@arm.com>
 846
 847         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 848         tokens.
 849         (typebase): New patterns for complex, single/double precision, and
 850         single/double complex.
 851         (f77_keywords): Change token for complex keyword, and add single,
 852         double, and precision keywords.
 853
 854 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 855
 856         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 857         "info io_registers".
 858
 859 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 860
 861         * regcache.c (cooked_read_test): Initialize thread list of
 862         mock_inferior.
 863
 864 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 865
 866         * aarch64-linux-tdep.c: Remove includes.
 867
 868 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 869
 870         * aarch64-tdep.c: Remove includes.
 871
 872 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 873
 874         * filtered-iterator.h (filtered_iterator) <operator==,
 875         operator!=>: Compare wrapped iterators, not wrapped pointers.
 876         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 877         unittests/filtered_iterator-selftests.c.
 878         * unittests/filtered_iterator-selftests.c: New file.
 879
 880 2019-12-04  Tom Tromey  <tromey@adacore.com>
 881
 882         * gdbtypes.c (create_range_type): Inherit endianity
 883         from base type.
 884
 885 2019-12-04  Tom Tromey  <tromey@adacore.com>
 886
 887         * ada-lang.c (decode_constrained_packed_array)
 888         (ada_value_assign, value_assign_to_component): Update.
 889         * dwarf2loc.c (rw_pieced_value, access_memory)
 890         (dwarf2_compile_expr_to_ax): Update.
 891         * dwarf2read.c (dwarf2_add_field): Update.
 892         * eval.c (evaluate_subexp_standard): Update.
 893         * gdbarch.c, gdbarch.h: Rebuild.
 894         * gdbarch.sh (bits_big_endian): Remove.
 895         * gdbtypes.h (union field_location): Update comment.
 896         * target-descriptions.c (make_gdb_type): Update.
 897         * valarith.c (value_bit_index): Update.
 898         * value.c (struct value) <bitpos>: Update comment.
 899         (unpack_bits_as_long, modify_field): Update.
 900         * value.h (value_bitpos): Update comment.
 901
 902 2019-12-04  Tom Tromey  <tromey@adacore.com>
 903
 904         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 905         endian-ness.
 906
 907 2019-12-04  Tom Tromey  <tromey@adacore.com>
 908
 909         * dwarf2read.c (dwarf2_init_float_type)
 910         (dwarf2_init_complex_target_type): Add byte_order parameter.
 911         (read_base_type): Compute byte order earlier.
 912         * gdbtypes.c (init_float_type): Add byte_order parameter.
 913         * gdbtypes.h (init_float_type): Add byte_order parameter.
 914
 915 2019-12-04  Tom Tromey  <tromey@adacore.com>
 916
 917         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 918
 919 2019-12-04  Tom Tromey  <tromey@adacore.com>
 920
 921         * dwarf2read.c (process_structure_scope): Initialize
 922         "discr_offset".
 923
 924 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 925
 926         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 927         add it into the search spec.
 928         (parse_max_results_option): New function.
 929         (mi_info_functions_or_variables): Parse -max-results flag and pass
 930         it to mi_symbol_info.
 931         (mi_cmd_symbol_info_modules): Likewise.
 932         (mi_cmd_symbol_info_types): Likewise.
 933         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
 934         return type to bool, change result container into a set, and don't
 935         add new results if we have enough already.
 936         (global_symbol_searcher::add_matching_msymbols): Change return
 937         type to bool, and don't add new results if we have enough already.
 938         (sort_search_symbols_remove_dups): Delete.
 939         (global_symbol_searcher::search): Early exit from search loop when
 940         we have enough results.  Use a std::set to collect the results
 941         from calling add_matching_symbols.
 942         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
 943         member function.
 944         (global_symbol_searcher) <m_max_search_results>: New member
 945         variable.
 946         (global_symbol_searcher) <add_matching_symbols>: Update header
 947         comment and change return type to bool.
 948         (global_symbol_searcher) <add_matching_msymbols>: Update header
 949         comment and change return type to bool.
 950
 951 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 952
 953         * symtab.c (symbol_search::compare_search_syms): Update header
 954         comment.
 955         (global_symbol_searcher::is_suitable_msymbol): New function.
 956         (global_symbol_searcher::expand_symtabs): New function.
 957         (global_symbol_searcher::add_matching_symbols): New function.
 958         (global_symbol_searcher::add_matching_msymbols): New function.
 959         (global_symbol_searcher::search): Move most of the content
 960         into the new functions above, and call them as needed.
 961         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
 962         function.
 963         (global_symbol_searcher) <add_matching_symbols>: New member
 964         function.
 965         (global_symbol_searcher) <add_matching_msymbols>: New member
 966         function.
 967         (global_symbol_searcher) <is_suitable_msymbol>: New member
 968         function.
 969
 970 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 971
 972         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
 973         -symbol-info-module-variables entries.
 974         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
 975         (mi_cmd_symbol_info_module_variables): Declare.
 976         * mi/mi-symbol-cmds.c
 977         (module_symbol_search_iterator): New typedef.
 978         (output_module_symbols_in_single_module_and_file): New function.
 979         (output_module_symbols_in_single_module): New function.
 980         (mi_info_module_functions_or_variables): New function.
 981         (mi_cmd_symbol_info_module_functions): New function.
 982         (mi_cmd_symbol_info_module_variables): New function.
 983         * NEWS: Mention new MI command.
 984
 985 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
 986
 987         * bcache.c (hash): Remove.
 988         (hash_continue): Remove.
 989         * bcache.h (hash): Remove.
 990         (hash_continue): Remove.
 991         (struct bcache) <ctor>: Update.
 992         * psymtab.c (psymbol_hash): Update.
 993         * stabsread.c (hashname): Update.
 994         * utils.h (fast_hash): Add an argument for a start value,
 995         defaulting to zero.
 996
 997 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 998         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
 999         (destroy_block_symbol_cache): New function.
1000         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1001         (resize_symbol_cache): Likewise.
1002
1003 2019-12-02  Tom Tromey  <tom@tromey.com>
1004
1005         * unittests/tui-selftests.c (run_tests): Make conditional.
1006         (_initialize_tui_selftest): Make conditional.
1007
1008 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1009
1010         * aix-thread.c (debug_aix_thread): Change type to bool.
1011
1012 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1013
1014         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1015
1016 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1017
1018         * dwarf2read.c (read_tag_string_type): Read the fields required to
1019         make a dynamic string, and possibly create a dynamic range for the
1020         string.
1021         (attr_to_dynamic_prop): Setup is_reference based on the type of
1022         attribute being processed.
1023         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1024         (resolve_dynamic_array): Rename to...
1025         (resolve_dynamic_array_or_string): ...this, update header comment,
1026         and accept TYPE_CODE_STRING.
1027         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1028
1029 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1030
1031         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1032         of its implementation from...
1033         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1034         the new function.
1035
1036 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1039         create a range with stride where appropriate.
1040         * f-valprint.c: Include 'gdbarch.h'.
1041         (f77_print_array_1): Take the stride into account when walking the
1042         array.  Also convert the stride into addressable units.
1043         * gdbtypes.c (create_range_type): Initialise the stride to
1044         constant zero.
1045         (create_range_type_with_stride): New function, initialise the
1046         range as normal, and then setup the stride.
1047         (has_static_range): Include the stride here.  Also change the
1048         return type to bool.
1049         (create_array_type_with_stride): Consider the range stride if the
1050         array isn't given its own stride.
1051         (resolve_dynamic_range): Resolve the stride if needed.
1052         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1053         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1054         (TYPE_BIT_STRIDE): Define.
1055         (TYPE_ARRAY_BIT_STRIDE): Define.
1056         (create_range_type_with_stride): Declare.
1057         * valarith.c (value_subscripted_rvalue): Take range stride into
1058         account when walking the array.
1059
1060 2019-12-01  Tom Tromey  <tom@tromey.com>
1061
1062         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1063         specially.
1064
1065 2019-12-01  Tom Tromey  <tom@tromey.com>
1066
1067         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1068         \0.
1069         * unittests/tui-selftests.c: New file.
1070         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1071
1072 2019-12-01  Tom Tromey  <tom@tromey.com>
1073
1074         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1075
1076 2019-12-01  Tom Tromey  <tom@tromey.com>
1077
1078         * NEWS: Document new settings.
1079         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1080         * tui/tui-win.c (_initialize_tui_win): Add border style
1081         observers.
1082         * tui/tui-io.h (tui_apply_style): Declare.
1083         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1084         longer static.
1085         (apply_ansi_escape, tui_set_reverse_mode): Update.
1086         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1087         Add "skip_intensity" parameter.
1088         <changed>: New member.
1089         <do_set_value>: Declare.
1090         (tui_border_style, tui_active_border_style): Declare.
1091         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1092         globals.
1093         (cli_style_option): Initialize "changed".
1094         (cli_style_option::do_set_value): New function.
1095         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1096         parameter.  Update.
1097         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1098         (_initialize_cli_style): Update.  Create TUI border style
1099         commands.
1100
1101 2019-12-01  Tom Tromey  <tom@tromey.com>
1102
1103         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1104         parameter.
1105         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1106         parameter.
1107         * tui/tui-win.h (compact_source): Declare.
1108         * tui/tui-win.c (compact_source): New global.
1109         (tui_set_compact_source, tui_show_compact_source): New functions.
1110         (_initialize_tui_win): Add "compact-source" setting.
1111         * tui/tui-source.c (tui_source_window::set_contents): Handle
1112         compact_source setting.
1113         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1114         * NEWS: Document new setting.
1115
1116 2019-11-30  Tom Tromey  <tom@tromey.com>
1117
1118         * dwarf2read.c (dwarf2_add_field): Include field offset when
1119         computing variant part length.
1120
1121 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1122         * NEWS:  Mention define-prefix.  Tell that command names can now
1123         contain a . character.
1124
1125 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1126
1127         * command.h (valid_cmd_char_p): Declare.
1128         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1129         the check of valid command char.
1130         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1131         valid_cmd_char_p.
1132         * cli/cli-script.c (validate_comname): Likewise.
1133         * completer.c (gdb_completer_command_word_break_characters):
1134         Do not remove . from the word break char, update comments.
1135         (complete_line_internal_1): Use valid_cmd_char_p.
1136         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1137         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1138
1139 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1140
1141         * cli/cli-script.c (do_define_command): Ensure a redefined
1142         prefix command is kept as a prefix command.
1143         (define_prefix_command): New function.
1144         (show_user_1): Report user defined prefixes.
1145         (_initialize_cli_script):  Create the new 'define-prefix' command.
1146         Add completers for 'define' and 'document'.
1147         * top.c (execute_command):  If command is a user-defined prefix only
1148         command, report the list of commands for this prefix command.
1149
1150 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1151
1152         * valops.c (find_oload_champ): Improve debug output.
1153
1154 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1155
1156         * valops.c (find_oload_champ): Print part of debug messages
1157         before the badness vector is std::move'd.
1158
1159 2019-11-28  Tom Tromey  <tom@tromey.com>
1160
1161         * value.c (creal_internal_fn): Fix comment.
1162
1163 2019-11-28  Tom Tromey  <tom@tromey.com>
1164
1165         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1166         flag_bound_evaluated>: Now unsigned.
1167
1168 2019-11-28  Tom Tromey  <tom@tromey.com>
1169
1170         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1171         declare.
1172
1173 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1174
1175         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1176         debug output.
1177         * jit.c (jit_unregister_code): Add debug print to match
1178         `jit_register_code`.
1179
1180 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1181
1182         * NEWS: Mention the new multithreaded symbol loading.
1183
1184 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1185
1186         * maint.c (n_worker_threads): Default to 0.
1187         (worker_threads_disabled): New function.
1188         * maint.h (worker_threads_disabled): New function.
1189         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1190         here if worker_threads_disabled () is true.
1191         (minimal_symbol_reader::install): Skip all threading if
1192         worker_threads_disabled () is true.
1193
1194 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1195
1196         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1197         hash code if possible.
1198         (add_minsym_to_demangled_hash_table): Likewise.
1199         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1200         on the background thread.
1201         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1202         Add these fields.
1203
1204 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1205
1206         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1207         of the mangled name on the background thread.
1208         * symtab.c (symbol_set_names): Allow passing in the hash of the
1209         linkage_name.
1210         * symtab.h (symbol_set_names): Likewise.
1211
1212 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1213
1214         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1215         physnames are computed for inherited DIEs.
1216
1217 2019-11-27  Tom Tromey  <tromey@adacore.com>
1218
1219         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1220         backslashes.
1221         * cp-support.c: Remove unnecessary backslashes.
1222
1223 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1224
1225         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1226         with sym->set_linkage_name.
1227         * coffread.c (coff_read_enum_type): Likewise.
1228         * mdebugread.c (parse_symbol): Likewise.
1229         * stabsread.c (patch_block_stabs): Likewise.
1230         (define_symbol): Likewise.
1231         (read_enum_type): Likewise.
1232         (common_block_end): Likewise.
1233         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1234         function.
1235         (SYMBOL_SET_LINKAGE_NAME): Remove.
1236         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1237         with sym->set_linkage_name.
1238
1239 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1240
1241         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1242         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1243         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1244         * NEWS: Mention new MI command.
1245
1246 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1247
1248         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1249         '-symbol-info-types', and '-symbol-info-variables'.
1250         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1251         (mi_cmd_symbol_info_types): Declare.
1252         (mi_cmd_symbol_info_variables): Declare.
1253         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1254         (output_debug_symbol): New function.
1255         (output_nondebug_symbol): New function.
1256         (mi_symbol_info): New function.
1257         (mi_info_functions_or_variables): New function.
1258         (mi_cmd_symbol_info_functions): New function.
1259         (mi_cmd_symbol_info_types): New function.
1260         (mi_cmd_symbol_info_variables): New function.
1261         * NEWS: Mention new commands.
1262
1263 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1264
1265         * symtab.c (symbol_to_info_string): New function, most content
1266         moved from print_symbol_info, but updated to return a std::string.
1267         (print_symbol_info): Update to use symbol_to_info_string and print
1268         returned string.
1269         * symtab.h (symbol_to_info_string): Declare new function.
1270
1271 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1272
1273         * python/python.c (gdbpy_rbreak): Convert to using
1274         global_symbol_searcher.
1275         * symtab.c (file_matches): Convert return type to bool, change
1276         file list to std::vector, update header comment.
1277         (search_symbols): Rename to...
1278         (global_symbol_searcher::search): ...this and update now its
1279         a member function of global_symbol_searcher.  Take account of the
1280         changes to file_matches.
1281         (symtab_symbol_info): Convert to using global_symbol_searcher.
1282         (rbreak_command): Likewise.
1283         (search_module_symbols): Likewise.
1284         * symtab.h (enum symbol_search): Update comment.
1285         (search_symbols): Remove declaration.
1286         (class global_symbol_searcher): New class.
1287
1288 2019-11-26  Tom Tromey  <tromey@adacore.com>
1289
1290         * cp-support.c (_initialize_cp_support): Conditionally initialize
1291         gdb_demangle_attempt_core_dump.
1292
1293 2019-11-26  Tom Tromey  <tom@tromey.com>
1294
1295         * python/py-function.c (fnpy_init): Update.
1296         * value.h (add_internal_function): Adjust declaration.
1297         * value.c (function_destroyer): Remove.
1298         (do_add_internal_function): Don't set destroyer or copy name.
1299         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1300         Set name_allocated.
1301         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1302         (cmdpy_init): Set name_allocated.
1303         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1304         member.
1305         (~cmd_list_element): Free "name" if needed.
1306
1307 2019-11-26  Tom Tromey  <tom@tromey.com>
1308
1309         * value.h (add_internal_function): Add new overload.  Move
1310         documentation from value.h.
1311         * value.c (do_add_internal_function): New function.
1312         (add_internal_function): Use it.  Add new overload.
1313         (function_destroyer): Don't free doc.
1314         * python/py-function.c (fnpy_init): Update.
1315
1316 2019-11-26  Tom Tromey  <tom@tromey.com>
1317
1318         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1319         (cmdpy_init): Set "doc_allocated".
1320
1321 2019-11-26  Tom Tromey  <tom@tromey.com>
1322
1323         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1324         name of worker thread.
1325         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1326         pthread_setname_np.
1327         * configure, config.in: Rebuild.
1328
1329 2019-11-26  Tom Tromey  <tom@tromey.com>
1330
1331         * python/python.c (class gdbpy_gil): New.
1332         (struct gdbpy_event): Add constructor, destructor, operator().
1333         (gdbpy_post_event): Use run_on_main_thread.
1334         (gdbpy_initialize_events): Remove.
1335         (do_start_initialization): Update.
1336
1337 2019-11-26  Tom Tromey  <tom@tromey.com>
1338
1339         * NEWS: Add entry.
1340         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1341         commands.  Call update_thread_pool_size.
1342         (update_thread_pool_size, maintenance_set_worker_threads): New
1343         functions.
1344         (n_worker_threads): New global.
1345
1346 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1347             Tom Tromey  <tom@tromey.com>
1348
1349         * minsyms.c (minimal_symbol_reader::install): Use
1350         parallel_for_each.
1351         * gdbsupport/parallel-for.h: New file.
1352         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1353
1354 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1355             Tom Tromey  <tom@tromey.com>
1356
1357         * gdbsupport/thread-pool.h: New file.
1358         * gdbsupport/thread-pool.c: New file.
1359         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1360         (HFILES_NO_SRCDIR): Add thread-pool.h.
1361
1362 2019-11-26  Tom Tromey  <tom@tromey.com>
1363
1364         * event-top.h (thread_local_segv_handler): Declare.
1365         * event-top.c (thread_local_segv_handler): New global.
1366         (install_handle_sigsegv, handle_sigsegv): New functions.
1367         (async_init_signals): Install SIGSEGV handler.
1368         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1369         thread-local.
1370         (report_failed_demangle): New function.
1371         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1372         handler-setting code, instead use segv_handler.  Run warning code
1373         on main thread.
1374
1375 2019-11-26  Tom Tromey  <tom@tromey.com>
1376
1377         * run-on-main-thread.c: New file.
1378         * run-on-main-thread.h: New file.
1379         * unittests/main-thread-selftests.c: New file.
1380         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1381         main-thread-selftests.c.
1382         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1383         (COMMON_SFILES): Add run-on-main-thread.c.
1384
1385 2019-11-26  Tom Tromey  <tom@tromey.com>
1386
1387         * main.c (setup_alternate_signal_stack): Remove.
1388         (captured_main_1): Use gdb::alternate_signal_stack.
1389         * gdbsupport/alt-stack.h: New file.
1390
1391 2019-11-26  Tom Tromey  <tom@tromey.com>
1392
1393         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1394         Remove comment.
1395         (save_original_signals_state, restore_original_signals_state): Use
1396         gdb_sigmask.
1397         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1398         (_initialize_linux_nat): Use gdb_sigmask.
1399         * guile/guile.c (_initialize_guile): Use block_signals.
1400         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1401         * gdbsupport/gdb-sigmask.h: New file.
1402         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1403         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1404         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1405         pthread_sigmask.
1406         * configure, config.in: Rebuild.
1407         * gdbsupport/block-signals.h: New file.
1408
1409 2019-11-26  Tom Tromey  <tom@tromey.com>
1410
1411         * acinclude.m4: Include ax_pthread.m4.
1412         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1413         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1414         (CLIBS): Use PTHREAD_LIBS.
1415         (aclocal_m4_deps): Add ax_pthread.m4.
1416         * config.in, configure: Rebuild.
1417         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1418
1419 2019-11-26  Tom Tromey  <tom@tromey.com>
1420
1421         * symtab.h (struct minimal_symbol) <name_set>: New member.
1422         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1423         Don't call symbol_set_names.
1424         (minimal_symbol_reader::install): Call symbol_set_names.
1425
1426 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1427
1428         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1429         restore_active_ext_lang, as GIL is needed for (indirectly)
1430         called PyOS_InterruptOccurred.
1431
1432 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1433
1434         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1435         definition.
1436
1437 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1438
1439         * remote-sim.c (simulator_command): Make static, remove
1440         declaration.
1441
1442 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1443
1444         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1445         static.
1446         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1447         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1448         (main): Likewise.
1449         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1450         (main): Likewise.
1451         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1452         (main): Likewise.
1453         * unittests/basic_string_view/element_access/char/1.cc (test01):
1454         Likewise.
1455         (main): Likewise.
1456         * unittests/basic_string_view/element_access/char/empty.cc (main):
1457         Likewise.
1458         * unittests/basic_string_view/element_access/char/front_back.cc
1459         (test01): Likewise.
1460         (main): Likewise.
1461         * unittests/basic_string_view/inserters/char/2.cc (test05):
1462         Likewise.
1463         (main): Likewise.
1464         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1465         (test01): Likewise.
1466         (main): Likewise.
1467         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1468         (test01): Likewise.
1469         (main): Likewise.
1470         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1471         Likewise.
1472         * unittests/basic_string_view/operations/compare/char/1.cc
1473         (test01): Likewise.
1474         (main): Likewise.
1475         * unittests/basic_string_view/operations/compare/char/13650.cc
1476         (test01): Likewise.
1477         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1478         Likewise.
1479         (main): Likewise.
1480         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1481         Likewise.
1482         (main): Likewise.
1483         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1484         Likewise.
1485         (main): Likewise.
1486         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1487         Likewise.
1488         (main): Likewise.
1489         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1490         Likewise.
1491         (main): Likewise.
1492         * unittests/basic_string_view/operations/find/char/4.cc (main):
1493         Likewise.
1494         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1495         Likewise.
1496         (main): Likewise.
1497         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1498         Likewise.
1499         (main): Likewise.
1500         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1501         Likewise.
1502         (main): Likewise.
1503         * unittests/basic_string_view/operations/substr/char/1.cc
1504         (test01): Likewise.
1505         (main): Likewise.
1506         * unittests/basic_string_view/operators/char/2.cc (main):
1507         Likewise.
1508         * unittests/optional/assignment/1.cc (test): Likewise.
1509         * unittests/optional/assignment/2.cc (test): Likewise.
1510         * unittests/optional/assignment/3.cc (test): Likewise.
1511         * unittests/optional/assignment/4.cc (test): Likewise.
1512         * unittests/optional/assignment/5.cc (test): Likewise.
1513         * unittests/optional/assignment/6.cc (test): Likewise.
1514         * unittests/optional/assignment/7.cc (test): Likewise.
1515         * unittests/optional/cons/copy.cc (test): Likewise.
1516         * unittests/optional/cons/default.cc (test): Likewise.
1517         * unittests/optional/cons/move.cc (test): Likewise.
1518         * unittests/optional/cons/value.cc (test): Likewise.
1519         * unittests/optional/in_place.cc (test): Likewise.
1520         * unittests/optional/observers/1.cc (test): Likewise.
1521         * unittests/optional/observers/2.cc (test): Likewise.
1522
1523 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1524
1525         * tui-win.h (tui_set_var_cmd): Remove.
1526         * tui-win.c (tui_set_var_cmd): Make static.
1527
1528 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1529
1530         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1531         rbreak_command_wrapper): Remove.
1532         * symtab.c (rbreak_command_wrapper): Remove.
1533
1534 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1535
1536         * inferior.h (info_terminal_command): Remove declaration.
1537         * inflow.c (info_terminal_command): Make static.
1538
1539 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1540
1541         * inferior.c (exit_inferior_silent): Remove.
1542
1543 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1544
1545         * dictionary.c (dict_empty, mdict_empty): Remove.
1546         * dictionary.c (mdict_empty): Remove.
1547
1548 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1549
1550          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1551          (arc_insn_get_memory_offset): Likewise.
1552          (arc_insn_dump): Likewise.
1553          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1554          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1555          * dictionary.c (dict_iterator_next): Likewise.
1556          (dict_iter_match_first): Likewise.
1557          (dict_iter_match_next): Likewise.
1558          * f-lang.c (evaluate_subexp_f): Likewise.
1559          * hppa-tdep.c (hppa_read_pc): Likewise.
1560          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1561          * parse.c (write_exp_elt_msym): Likewise.
1562          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1563          * remote.c (remote_packet_size): Likewise.
1564          (remote_notif_stop_parse): Likewise.
1565          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1566          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1567          * source.c (prepare_path_for_appending): Likewise.
1568          * sparc64-linux-tdep.c
1569          (sparc64_linux_handle_segmentation_fault); Likewise.
1570          * stack.c (frame_selection_by_function_completer): Likewise.
1571
1572 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1573
1574         * completer.c (set_gdb_completion_word_break_characters):
1575         Remove.
1576
1577 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1578
1579         * dwarf-index-write.c: Include dwarf-index-write.h.
1580         * mi/mi-interp.c: Include mi/mi-interp.h.
1581
1582 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1583
1584         * aarch32-tdep.c: Include aarch32-tdep.h.
1585         * aarch32-tdep.h: Forward-declare struct target_desc.
1586
1587 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1588
1589         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1590         strerror.
1591         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1592         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1593
1594 2019-11-25  Tom de Vries  <tdevries@suse.de>
1595
1596         * contrib/words.sh: Add -c option.
1597
1598 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1599
1600         * solib.c (solib_find_1): Change int to bool.
1601         (exec_file_find): Change int to bool.
1602         (solib_find): Change int to bool.
1603         (solib_read_symbols): Change int to bool.
1604         (solib_used): Change int to bool.
1605         (solib_add): Change int to bool.
1606         (info_sharedlibrary_command): Change int to bool.
1607         (solib_contains_address_p): Change int to bool.
1608         (solib_keep_data_in_core): Change int to bool.
1609         (in_solib_dynsym_resolve_code): Change int to bool.
1610         (reload_shared_libraries_1): Change int to bool.
1611         (gdb_sysroot_changed): Change int to bool.
1612         * solib.h (solib_read_symbols): Change int to bool.
1613         (solib_contains_address_p): Change int to bool.
1614         (solib_keep_data_in_core): Change int to bool.
1615         (in_solib_dynsym_resolve_code): Change int to bool.
1616         (libpthread_name_p): Change int to bool.
1617
1618 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1619
1620         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1621         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1622         (remote_packet_max_chars): New static global.
1623         (show_remote_packet_max_chars): New function.
1624         (remote_target::putpkt_binary): Adjust to use new
1625         remote_packet_max_chars option.
1626         (remote_target::getpkt_or_notif_sane_1): Likewise.
1627         (_initialize_remote): Register new remote-packet-max-chars option.
1628
1629 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1630
1631         * m68k-linux-nat.c: Include gdbarch.h.
1632
1633 2019-11-24  Tom Tromey  <tom@tromey.com>
1634
1635         * symfile.c (read_symbols): Update.
1636         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1637         bool.
1638         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1639         (psym_lookup_symbol, psym_find_last_source_symtab)
1640         (psym_forget_cached_source_info, psym_print_stats)
1641         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1642         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1643         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1644         (psym_find_compunit_symtab_by_address)
1645         (maintenance_print_psymbols, maintenance_info_psymtabs)
1646         (maintenance_check_psymtabs): Update.
1647         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1648         bool.
1649
1650 2019-11-22  Tom Tromey  <tom@tromey.com>
1651
1652         * observable.h: Update comments.
1653
1654 2019-11-22  Tom Tromey  <tromey@adacore.com>
1655
1656         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1657         (print_ada_task_info): Don't try to fetch thread id if task is not
1658         alive.
1659
1660 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1661
1662         * ada-exp.y: Update.
1663         * ada-lang.c (sort_choices): Update.
1664         (ada_print_symbol_signature): Update.
1665         (resolve_subexp): Update.
1666         (ada_parse_renaming): Update.
1667         (ada_read_renaming_var_value): Update.
1668         (lesseq_defined_than): Update.
1669         (remove_extra_symbols): Update.
1670         (remove_irrelevant_renamings): Update.
1671         (ada_add_block_symbols): Update.
1672         (ada_collect_symbol_completion_matches): Update.
1673         (ada_is_renaming_symbol): Update.
1674         (aggregate_assign_from_choices): Update.
1675         (ada_evaluate_subexp): Update.
1676         (ada_has_this_exception_support): Update.
1677         (ada_is_non_standard_exception_sym): Update.
1678         (ada_add_exceptions_from_frame): Update.
1679         (ada_add_global_exceptions): Update.
1680         (ada_print_subexp): Update.
1681         * ax-gdb.c (gen_var_ref): Update.
1682         (gen_maybe_namespace_elt): Update.
1683         (gen_expr_for_cast): Update.
1684         (gen_expr): Update.
1685         * block.h: Update.
1686         * blockframe.c (find_pc_partial_function): Update.
1687         * breakpoint.c (print_breakpoint_location): Update.
1688         (update_static_tracepoint): Update.
1689         * btrace.c (ftrace_print_function_name): Update.
1690         (ftrace_function_switched): Update.
1691         * buildsym.c (find_symbol_in_list): Update.
1692         * c-exp.y: Update.
1693         * c-typeprint.c (c_print_typedef): Update.
1694         (c_type_print_template_args): Update.
1695         * cli/cli-cmds.c (edit_command): Update.
1696         (list_command): Update.
1697         (print_sal_location): Update.
1698         * coffread.c (patch_opaque_types): Update.
1699         (process_coff_symbol): Update.
1700         (coff_read_enum_type): Update.
1701         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1702         (convert_one_symbol): Update.
1703         (hash_symname): Update.
1704         (eq_symname): Update.
1705         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1706         * compile/compile-cplus-types.c (debug_print_scope): Update.
1707         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1708         * compile/compile-object-load.c (get_out_value_type): Update.
1709         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1710         (search_symbol_list): Update.
1711         (cp_lookup_symbol_imports_or_template): Update.
1712         * cp-support.c (overload_list_add_symbol): Update.
1713         * ctfread.c (psymtab_to_symtab): Update.
1714         * dbxread.c (cp_set_block_scope): Update.
1715         * dictionary.c (iter_match_first_hashed): Update.
1716         (iter_match_next_hashed): Update.
1717         (insert_symbol_hashed): Update.
1718         (iter_match_next_linear): Update.
1719         * dictionary.h: Update.
1720         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1721         (locexpr_describe_location_piece): Update.
1722         (locexpr_describe_location_1): Update.
1723         (locexpr_generate_c_location): Update.
1724         (loclist_describe_location): Update.
1725         (loclist_generate_c_location): Update.
1726         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1727         (read_func_scope): Update.
1728         (process_enumeration_scope): Update.
1729         (new_symbol): Update.
1730         (dwarf2_const_value): Update.
1731         (dwarf2_symbol_mark_computed): Update.
1732         * eval.c (evaluate_funcall): Update.
1733         (evaluate_subexp_standard): Update.
1734         * expprint.c (print_subexp_standard): Update.
1735         (dump_subexp_body_standard): Update.
1736         * f-valprint.c (info_common_command_for_block): Update.
1737         * findvar.c (get_hosting_frame): Update.
1738         (default_read_var_value): Update.
1739         * go-lang.c (go_symbol_package_name): Update.
1740         * guile/scm-block.c (bkscm_print_block_smob): Update.
1741         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1742         (gdbscm_symbol_name): Update.
1743         (gdbscm_symbol_linkage_name): Update.
1744         (gdbscm_symbol_print_name): Update.
1745         * infcall.c (get_function_name): Update.
1746         * infcmd.c (jump_command): Update.
1747         (finish_command): Update.
1748         * infrun.c (insert_exception_resume_breakpoint): Update.
1749         * linespec.c (canonicalize_linespec): Update.
1750         (create_sals_line_offset): Update.
1751         (convert_linespec_to_sals): Update.
1752         (complete_label): Update.
1753         (find_label_symbols_in_block): Update.
1754         * m2-typeprint.c (m2_print_typedef): Update.
1755         * mdebugread.c (mdebug_reg_to_regnum): Update.
1756         (parse_symbol): Update.
1757         (mylookup_symbol): Update.
1758         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1759         (list_args_or_locals): Update.
1760         * objc-lang.c (compare_selectors): Update.
1761         (info_selectors_command): Update.
1762         (compare_classes): Update.
1763         (info_classes_command): Update.
1764         (find_imps): Update.
1765         * p-typeprint.c (pascal_print_typedef): Update.
1766         * printcmd.c (build_address_symbolic): Update.
1767         (info_address_command): Update.
1768         (print_variable_and_value): Update.
1769         * python/py-framefilter.c (extract_sym): Update.
1770         (py_print_single_arg): Update.
1771         * python/py-symbol.c (sympy_str): Update.
1772         (sympy_get_name): Update.
1773         (sympy_get_linkage_name): Update.
1774         * python/python.c (gdbpy_rbreak): Update.
1775         * record-btrace.c (btrace_get_bfun_name): Update.
1776         (btrace_call_history): Update.
1777         * rust-lang.c (rust_print_typedef): Update.
1778         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1779         * stabsread.c (stab_reg_to_regnum): Update.
1780         (define_symbol): Update.
1781         (read_enum_type): Update.
1782         (common_block_end): Update.
1783         (cleanup_undefined_types_1): Update.
1784         (scan_file_globals): Update.
1785         * stack.c (print_frame_arg): Update.
1786         (print_frame_args): Update.
1787         (find_frame_funname): Update.
1788         (info_frame_command_core): Update.
1789         (iterate_over_block_locals): Update.
1790         (print_block_frame_labels): Update.
1791         (do_print_variable_and_value): Update.
1792         (iterate_over_block_arg_vars): Update.
1793         (return_command): Update.
1794         * symmisc.c (dump_symtab_1): Update.
1795         (print_symbol): Update.
1796         * symtab.c (eq_symbol_entry): Update.
1797         (symbol_cache_dump): Update.
1798         (lookup_language_this): Update.
1799         (find_pc_sect_line): Update.
1800         (skip_prologue_sal): Update.
1801         (symbol_search::compare_search_syms): Update.
1802         (treg_matches_sym_type_name): Update.
1803         (search_symbols): Update.
1804         (print_symbol_info): Update.
1805         (rbreak_command): Update.
1806         (completion_list_add_symbol): Update.
1807         (find_gnu_ifunc): Update.
1808         (get_symbol_address): Update.
1809         (search_module_symbols): Update.
1810         (info_module_subcommand): Update.
1811         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1812         (SYMBOL_LINKAGE_NAME): Remove.
1813         (SYMBOL_DEMANGLED_NAME): Remove.
1814         (SYMBOL_PRINT_NAME): Remove.
1815         (SYMBOL_SEARCH_NAME): Remove.
1816         * tracepoint.c (set_traceframe_context): Update.
1817         (validate_actionline): Update.
1818         (collection_list::collect_symbol): Update.
1819         (encode_actions_1): Update.
1820         (info_scope_command): Update.
1821         (print_one_static_tracepoint_marker): Update.
1822         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1823         * valops.c (address_of_variable): Update.
1824         (find_overload_match): Update.
1825         (find_oload_champ): Update.
1826
1827 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1828
1829         * ada-lang.c (ada_lookup_simple_minsym): Update.
1830         (ada_collect_symbol_completion_matches): Update.
1831         * ada-tasks.c (read_atcb): Update.
1832         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1833         (amd64_windows_skip_trampoline_code): Update.
1834         * arm-tdep.c (skip_prologue_function): Update.
1835         (arm_skip_stack_protector): Update.
1836         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1837         (arm_wince_skip_main_prologue): Update.
1838         * ax-gdb.c (gen_expr): Update.
1839         * block.c (call_site_for_pc): Update.
1840         * blockframe.c (find_pc_partial_function): Update.
1841         * breakpoint.c (set_breakpoint_location_function): Update.
1842         * btrace.c (ftrace_print_function_name): Update.
1843         (ftrace_function_switched): Update.
1844         * c-valprint.c (print_unpacked_pointer): Update.
1845         * coffread.c (coff_symfile_read): Update.
1846         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1847         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1848         * dwarf-index-write.c (write_psymbols): Update.
1849         * dwarf2loc.c (call_site_to_target_addr): Update.
1850         (func_verify_no_selftailcall): Update.
1851         (tailcall_dump): Update.
1852         (call_site_find_chain_1): Update.
1853         (dwarf_expr_reg_to_entry_parameter): Update.
1854         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1855         * eval.c (evaluate_funcall): Update.
1856         (evaluate_subexp_standard): Update.
1857         (evaluate_subexp_for_sizeof): Update.
1858         * expprint.c (print_subexp_standard): Update.
1859         (dump_subexp_body_standard): Update.
1860         * frame.c (get_prev_frame_always_1): Update.
1861         * frv-tdep.c (frv_skip_main_prologue): Update.
1862         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1863         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1864         (gnuv3_get_typename_from_type_info): Update.
1865         (gnuv3_skip_trampoline): Update.
1866         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1867         * i386-tdep.c (i386_skip_main_prologue): Update.
1868         (i386_pe_skip_trampoline_code): Update.
1869         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1870         * infcall.c (get_function_name): Update.
1871         * linespec.c (minsym_found): Update.
1872         * linux-fork.c (info_checkpoints_command): Update.
1873         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1874         (m32c_m16c_pointer_to_address): Update.
1875         * maint.c (maintenance_translate_address): Update.
1876         * minsyms.c (add_minsym_to_hash_table): Update.
1877         (add_minsym_to_demangled_hash_table): Update.
1878         (lookup_minimal_symbol_mangled): Update.
1879         (lookup_minimal_symbol_demangled): Update.
1880         (lookup_minimal_symbol_linkage): Update.
1881         (lookup_minimal_symbol_text): Update.
1882         (lookup_minimal_symbol_by_pc_name): Update.
1883         (minimal_symbol_is_less_than): Update.
1884         (compact_minimal_symbols): Update.
1885         (build_minimal_symbol_hash_tables): Update.
1886         (find_solib_trampoline_target): Update.
1887         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1888         (mips_skip_pic_trampoline_code): Update.
1889         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1890         * objc-lang.c (info_selectors_command): Update.
1891         (info_classes_command): Update.
1892         (find_methods): Update.
1893         (find_imps): Update.
1894         * p-valprint.c (pascal_val_print): Update.
1895         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1896         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1897         * printcmd.c (build_address_symbolic): Update.
1898         (info_symbol_command): Update.
1899         * psymtab.c (psymbol_name_matches): Update.
1900         (match_partial_symbol): Update.
1901         (lookup_partial_symbol): Update.
1902         (print_partial_symbols): Update.
1903         (sort_pst_symbols): Update.
1904         (maintenance_check_psymtabs): Update.
1905         * python/py-framefilter.c (py_print_frame): Update.
1906         * python/python.c (gdbpy_rbreak): Update.
1907         * record-btrace.c (btrace_get_bfun_name): Update.
1908         (btrace_call_history): Update.
1909         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1910         (rs6000_skip_trampoline_code): Update.
1911         * sol-thread.c (info_cb): Update.
1912         * stabsread.c (scan_file_globals): Update.
1913         * stack.c (find_frame_funname): Update.
1914         (info_frame_command_core): Update.
1915         * symmisc.c (dump_msymbols): Update.
1916         * symtab.c (symbol_natural_name): Rename to..,
1917         (general_symbol_info::natural_name): ...this.
1918         (symbol_demangled_name): Rename to...
1919         (general_symbol_info::demangled_name): ...this.
1920         (symbol_search_name): Rename to...
1921         (general_symbol_info::search_name): ...this.
1922         (symbol_matches_search_name): Update.
1923         (find_pc_sect_line): Update.
1924         (skip_prologue_sal): Update.
1925         (search_symbols): Update.
1926         (print_msymbol_info): Update.
1927         (rbreak_command): Update.
1928         (completion_list_add_msymbol): Update.
1929         (completion_list_objc_symbol): Update.
1930         (get_msymbol_address): Update.
1931         * symtab.h (struct general_symbol_info): Add member functions
1932         natural_name (), linkage_name (), print_name (), demangled_name (),
1933         and search_name ().
1934         (SYMBOL_NATURAL_NAME): Update.
1935         (symbol_natural_name): Move to a member function on general_symbol_info.
1936         (SYMBOL_DEMANGLED_NAME): Update.
1937         (symbol_demangled_name): Move to a member function on
1938         general_symbol_info.
1939         (SYMBOL_SEARCH_NAME): Update.
1940         (symbol_search_name): Move to a member function on general_symbol_info.
1941         (MSYMBOL_NATURAL_NAME): Remove.
1942         (MSYMBOL_LINKAGE_NAME): Remove.
1943         (MSYMBOL_PRINT_NAME): Remove.
1944         (MSYMBOL_DEMANGLED_NAME): Remove.
1945         (MSYMBOL_SEARCH_NAME): Remove.
1946         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
1947
1948 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1949
1950         * symtab.c (create_demangled_names_hash): Use per_bfd->
1951         minimal_symbol_count for computing the initial size, if greater
1952         than our default size.
1953
1954 2019-11-22  Tom de Vries  <tdevries@suse.de>
1955
1956         * contrib/words.sh: Improve words extraction.
1957
1958 2019-11-22  Tom de Vries  <tdevries@suse.de>
1959
1960         * contrib/words.sh: Combine sed invocations.
1961
1962 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
1963
1964         * Makefile.in: Update.
1965         * demangle.c: Rename to...
1966         * gdb-demangle.c: ..this.
1967         (is_cplus_marker): Change return type to bool.
1968         (_initialize_demangler): Rename to...
1969         (_initialize_gdb_demangle): ...this.
1970         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
1971         * symtab.h (demangle): Remove declaration; instead include
1972         gdb-demangle.h.
1973
1974 2019-11-21  Tom Tromey  <tromey@adacore.com>
1975
1976         * gdbsupport/format.c (format_pieces): Parse %I64d.
1977         * unittests/format_pieces-selftests.c (test_windows_formats): New
1978         function.
1979         (run_tests): Call it.
1980
1981 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
1982
1983         Byte reverse display of variables with DW_END_big, DW_END_little
1984         (DW_AT_endianity) dwarf attributes if different than the native
1985         byte order.
1986         * ada-lang.c (ada_value_binop):
1987         Use type_byte_order instead of gdbarch_byte_order.
1988         * ada-valprint.c (printstr):
1989         (ada_val_print_string):
1990         * ada-lang.c (value_pointer):
1991         (ada_value_binop):
1992         Use type_byte_order instead of gdbarch_byte_order.
1993         * c-lang.c (c_get_string):
1994         Use type_byte_order instead of gdbarch_byte_order.
1995         * c-valprint.c (c_val_print_array):
1996         Use type_byte_order instead of gdbarch_byte_order.
1997         * cp-valprint.c (cp_print_class_member):
1998         Use type_byte_order instead of gdbarch_byte_order.
1999         * dwarf2loc.c (rw_pieced_value):
2000         Use type_byte_order instead of gdbarch_byte_order.
2001         * dwarf2read.c (read_base_type): Handle DW_END_big,
2002         DW_END_little
2003         * f-lang.c (f_get_encoding):
2004         Use type_byte_order instead of gdbarch_byte_order.
2005         * findvar.c (default_read_var_value):
2006         Use type_byte_order instead of gdbarch_byte_order.
2007         * gdbtypes.c (check_types_equal):
2008         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2009         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2010         and TYPE_ENDIANITY_LITTLE if set.
2011         (type_byte_order): new function.
2012         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2013         (struct main_type) <flag_endianity_not_default>:
2014         New field.
2015         (type_byte_order): New function.
2016         * infcmd.c (default_print_one_register_info):
2017         Use type_byte_order instead of gdbarch_byte_order.
2018         * p-lang.c (pascal_printstr):
2019         Use type_byte_order instead of gdbarch_byte_order.
2020         * p-valprint.c (pascal_val_print):
2021         Use type_byte_order instead of gdbarch_byte_order.
2022         * printcmd.c (print_scalar_formatted):
2023         Use type_byte_order instead of gdbarch_byte_order.
2024         * solib-darwin.c (darwin_current_sos):
2025         Use type_byte_order instead of gdbarch_byte_order.
2026         * solib-svr4.c (solib_svr4_r_ldsomap):
2027         Use type_byte_order instead of gdbarch_byte_order.
2028         * stap-probe.c (stap_modify_semaphore):
2029         Use type_byte_order instead of gdbarch_byte_order.
2030         * target-float.c (target_float_same_format_p):
2031         Use type_byte_order instead of gdbarch_byte_order.
2032         * valarith.c (scalar_binop):
2033         (value_bit_index):
2034         Use type_byte_order instead of gdbarch_byte_order.
2035         * valops.c (value_cast):
2036         Use type_byte_order instead of gdbarch_byte_order.
2037         * valprint.c (generic_emit_char):
2038         (generic_printstr):
2039         (val_print_string):
2040         Use type_byte_order instead of gdbarch_byte_order.
2041         * value.c (unpack_long):
2042         (unpack_bits_as_long):
2043         (unpack_value_bitfield):
2044         (modify_field):
2045         (pack_long):
2046         (pack_unsigned_long):
2047         Use type_byte_order instead of gdbarch_byte_order.
2048         * findvar.c (unsigned_pointer_to_address):
2049         (signed_pointer_to_address):
2050         (unsigned_address_to_pointer):
2051         (address_to_signed_pointer):
2052         (default_read_var_value):
2053         (default_value_from_register):
2054         Use type_byte_order instead of gdbarch_byte_order.
2055         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2056         Use type_byte_order instead of gdbarch_byte_order.
2057         * riscv-tdep.c (riscv_print_one_register_info):
2058         Use type_byte_order instead of gdbarch_byte_order.
2059
2060 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2061
2062         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2063         (current_ui_gdb_stdin_ptr): Likewise.
2064         (current_ui_gdb_stderr_ptr): Likewise.
2065         (current_ui_gdb_stdlog_ptr): Likewise.
2066         (current_ui_current_uiout_ptr): Likewise.
2067         (gen_ret_current_ui_field_ptr): Remove.
2068
2069 2019-11-21  Tom de Vries  <tdevries@suse.de>
2070
2071         PR gdb/24956
2072         * cli/cli-script.c (execute_control_command): Only switch to
2073         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2074
2075 2019-11-19  Tom Tromey  <tom@tromey.com>
2076
2077         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2078         Now static.  Change type of "name".
2079         (tui_set_win_height_command): Don't copy "arg".
2080         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2081         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2082
2083 2019-11-19  Ali Tamur <tamur@google.com>
2084
2085         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2086         "if (attr != nullptr)".
2087         (dwarf2_find_base_address): Likewise.
2088         (dwarf2_build_include_psymtabs): Likewise.
2089         (read_cutu_die_from_dwo): Likewise.
2090         (read_func_scope): Likewise.
2091         (read_call_site_scope): Likewise.
2092         (dwarf2_get_pc_bounds): Likewise.
2093         (dwarf2_record_block_ranges): Likewise.
2094         (dwarf2_add_field): Likewise.
2095         (dwarf2_add_member_fn): Likewise.
2096         (read_structure_type): Likewise.
2097         (read_enumeration_type): Likewise.
2098         (read_array_type): Likewise.
2099         (read_array_order): Likewise.
2100         (read_set_type): Likewise.
2101         (read_common_block): Likewise.
2102         (read_tag_reference_type): Likewise.
2103         (read_tag_string_type): Likewise.
2104         (read_subroutine_type): Likewise.
2105         (read_base_type): Likewise.
2106         (read_subrange_type): Likewise.
2107         (new_symbol): Likewise.
2108         (prepare_one_comp_unit): Likewise.
2109
2110 2019-11-19  Tom Tromey  <tromey@adacore.com>
2111
2112         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2113         result in error when DebugActiveProcess fails.
2114
2115 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2116             Pedro Alves  <palves@redhat.com>
2117
2118         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2119         * target.c (target_stack::push): Call 'unpush' if there's a
2120         target on top of the stack.
2121
2122 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2123
2124         * python/py-block.c (blpy_dealloc): Call tp_free.
2125         (blpy_block_syms_dealloc): Likewise.
2126         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2127         * python/py-inferior.c (infpy_dealloc): Likewise.
2128         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2129         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2130         * python/py-symbol.c (sympy_dealloc): Likewise.
2131         * python/py-symtab.c (stpy_dealloc): Likewise.
2132         * python/py-type.c (typy_iterator_dealloc): Likewise.
2133
2134 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2135
2136         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2137         constructor instead of using a class initializer.
2138
2139 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2140
2141         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2142         * configure: Regenerate.
2143         * configure.ac: Don't source common.host.
2144         * gdbsupport/common.host: Remove.
2145         * gdbsupport/mingw-strerror.c: Remove.
2146         * gdbsupport/posix-strerror.c: Rename to...
2147         * gdbsupport/safe-strerror.c: ...this.
2148
2149 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2150
2151         * maint.c (scoped_command_stats::print_time): Use localtime_r
2152         instead of localtime (provided through gnulib if necessary).
2153         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2154         of ctime.
2155
2156 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2157
2158         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2159         avoid compile errors.
2160
2161 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2162
2163         * config.in: Regenerate.
2164         * configure: Regenerate.
2165         * gdbsupport/common.m4: No longer check for strerror_r.
2166         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2167         POSIX version of strerror_r, now that gnulib provides it if
2168         necessary.
2169
2170 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2171
2172         * README (`configure' options): Update.
2173
2174 2019-11-14  Tom Tromey  <tromey@adacore.com>
2175
2176         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2177         expected type for the RHS if the LHS is a convenience variable.
2178
2179 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2180
2181         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2182         Provide explicit default and copy constructor.
2183
2184 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2185
2186         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2187         only call Py_INCREF (newbp) in the bppy_pending_object case.
2188
2189 2019-11-13  Tom Tromey  <tromey@adacore.com>
2190
2191         PR build/25182:
2192         * psympriv.h (partial_symbol): Remove static assert.
2193         * symtab.h (general_symbol_info, symbol): Remove static assert.
2194
2195 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2196
2197         * gdbsupport/format.c (format_pieces::format_pieces): Support
2198         printf 'z' size modifier.
2199         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2200         * printcmd.c (ui_printf):  Handle size_t_arg.
2201         * ui-out.c (ui_out::vmessage): Likewise.
2202         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2203         function.
2204         (run_tests): Call test_format_int_sizes.
2205
2206 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2207
2208         * ada-exp.y (write_ambiguous_var): Update.
2209         * buildsym.c (add_symbol_to_list): Update.
2210         * dwarf2read.c (read_variable): Update.
2211         (new_symbol): Update.
2212         * jit.c (finalize_symtab): Update.
2213         * language.c (language_alloc_type_symbol): Update.
2214         * symtab.c (fixup_symbol_section): Update.
2215         (initialize_objfile_symbol_1): Move code to...
2216         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2217         (allocate_symbol): Update.
2218         (allocate_template_symbol): Update.
2219         (get_symbol_address): Update.
2220         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2221         of having as a field, and add a constructor.
2222         (SYMBOL_VALUE): Update.
2223         (SYMBOL_VALUE_ADDRESS): Update.
2224         (SET_SYMBOL_VALUE_ADDRESS): Update.
2225         (SYMBOL_VALUE_BYTES): Update.
2226         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2227         (SYMBOL_BLOCK_VALUE): Update.
2228         (SYMBOL_VALUE_CHAIN): Update.
2229         (SYMBOL_LANGUAGE): Update.
2230         (SYMBOL_SECTION): Update.
2231         (SYMBOL_OBJ_SECTION): Update.
2232         (SYMBOL_SET_LANGUAGE): Update.
2233         (SYMBOL_SET_LINKAGE_NAME): Update.
2234         (SYMBOL_SET_NAMES): Update.
2235         (SYMBOL_NATURAL_NAME): Update.
2236         (SYMBOL_LINKAGE_NAME): Update.
2237         (SYMBOL_DEMANGLED_NAME): Update.
2238         (SYMBOL_SEARCH_NAME): Update.
2239         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2240         (struct symbol): Update.
2241         (struct template_symbol): Update.
2242         (struct rust_vtable_symbol): Update.
2243         * xcoffread.c (SYMBOL_DUP): Update.
2244
2245 2019-11-12  Tom Tromey  <tom@tromey.com>
2246
2247         * tui/tui-layout.c (show_layout): Set current_layout.
2248         (show_source_disasm_command, show_data)
2249         (show_source_or_disasm_and_command): Don't set current_layout.
2250
2251 2019-11-12  Tom Tromey  <tom@tromey.com>
2252
2253         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2254
2255 2019-11-12  Tom Tromey  <tom@tromey.com>
2256
2257         * tui/tui-win.c (resize_message): New global.
2258         (show_tui_resize_message): New function.
2259         (tui_async_resize_screen): Print message if requested.
2260         (_initialize_tui_win): Add tui-resize-message setting.
2261         * NEWS: Add entry for new commands.
2262
2263 2019-11-11  Tom Tromey  <tom@tromey.com>
2264
2265         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2266         functions.
2267
2268 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2269
2270         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2271
2272 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2273
2274         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2275         function.
2276         * python/python-internal.h (gdbpy_lookup_static_symbols):
2277         Declare new function.
2278         * python/python.c (python_GdbMethods): Add
2279         gdb.lookup_static_symbols method.
2280         * NEWS: Mention gdb.lookup_static_symbols.
2281
2282 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2283
2284         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2285         static block of current object file first.  Also fix typo in
2286         header comment.
2287
2288 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2289
2290         * stack.c (set_last_displayed_sal): Delete.
2291         (last_displayed_sal_valid): Delete.
2292         (last_displayed_pspace): Delete.
2293         (last_displayed_addr): Delete.
2294         (last_displayed_symtab): Delete.
2295         (last_displayed_line): Delete.
2296         (class last_displayed_symtab_info_type): New.
2297         (last_displayed_symtab_info): New static global variable.
2298         (print_frame_info): Call methods on last_displayed_symtab_info.
2299         (clear_last_displayed_sal): Update header comment, and make use of
2300         last_displayed_symtab_info.
2301         (last_displayed_sal_is_valid): Likewise.
2302         (get_last_displayed_pspace): Likewise.
2303         (get_last_displayed_addr): Likewise.
2304         (get_last_displayed_symtab): Likewise.
2305         (get_last_displayed_line): Likewise.
2306         (get_last_displayed_sal): Likewise.
2307         * stack.h (clear_last_displayed_sal): Update header comment.
2308         (last_displayed_sal_is_valid): Likewise.
2309         (get_last_displayed_pspace): Likewise.
2310         (get_last_displayed_addr): Likewise.
2311         (get_last_displayed_symtab): Likewise.
2312         (get_last_displayed_line): Likewise.
2313         (get_last_displayed_sal): Likewise.
2314
2315 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2316
2317         * stack.c (frame_show_address): Convert return type to bool.
2318         * stack.h (frame_show_address): Likewise, and update header
2319         comment.
2320
2321 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2322
2323         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2324         * unittests/vec-utils-selftests.c: New file.
2325         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2326
2327 2019-11-10  Tom Tromey  <tom@tromey.com>
2328
2329         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2330         (tui_highlight_win): Likewise.
2331         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2332         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2333         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2334         Don't set can_highlight.
2335
2336 2019-11-10  Tom Tromey  <tom@tromey.com>
2337
2338         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2339         Remove unused declaration.
2340
2341 2019-11-08  Tom Tromey  <tromey@adacore.com>
2342
2343         * top.c (read_command_file): Update.
2344         (command_line_input): Make return type const.
2345         * python/py-gdb-readline.c: Update.
2346         * linespec.c (decode_line_2): Update.
2347         * defs.h (command_line_input): Make return type const.
2348         * cli/cli-script.c (read_next_line): Make return type const.
2349         * ada-lang.c (get_selections): Update.
2350
2351 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2352
2353         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2354         * mi/mi-main.c (output_cores): Likewise.
2355         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2356         (linux_xfer_osdata_modules): Likewise.
2357         * remote.c (register_remote_support_xml): Likewise.
2358         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2359         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2360
2361 2019-11-06  Tom Tromey  <tom@tromey.com>
2362
2363         * tui/tui-interp.c: Don't include readline.h.
2364         * tui/tui-hooks.c: Don't include readline.h.
2365         * symmisc.c: Include tilde.h, not readline.h.
2366         * symfile.c: Include tilde.h, not readline.h.
2367         * source.c: Include tilde.h, not readline.h.
2368         * solib.c: Include tilde.h, not readline.h.
2369         * psymtab.c: Include tilde.h, not readline.h.
2370         * exec.c: Include tilde.h, not readline.h.
2371         * corelow.c: Include tilde.h, not readline.h.
2372         * cli/cli-dump.c: Include tilde.h, not readline.h.
2373         * cli/cli-cmds.c: Don't include readline.h.
2374
2375 2019-11-05  Tom Tromey  <tom@tromey.com>
2376
2377         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2378         (tui_disassemble): Set addr_size.
2379         (tui_disasm_window::set_contents): Use addr_size.
2380
2381 2019-11-05  Tom Tromey  <tom@tromey.com>
2382
2383         * rust-lang.c (rust_language_defn): Update.
2384         * python/py-value.c (valpy_string): Call c_get_string.
2385         * p-lang.c (pascal_language_defn): Update.
2386         * opencl-lang.c (opencl_language_defn): Update.
2387         * objc-lang.c (objc_language_defn): Update.
2388         * m2-lang.c (m2_language_defn): Update.
2389         * language.c (unknown_language_defn, auto_language_defn): Update.
2390         (default_get_string): Remove.
2391         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2392         * go-lang.c (go_language_defn): Update.
2393         * f-lang.c (f_language_defn): Update.
2394         * d-lang.c (d_language_defn): Update.
2395         * c-lang.c (c_language_defn, cplus_language_defn)
2396         (asm_language_defn, minimal_language_defn): Update.
2397         * ada-lang.c (ada_language_defn): Update.
2398         * language.h (struct language_defn) <la_get_string>: Remove.
2399         (LA_GET_STRING): Remove.
2400         (default_get_string): Don't declare.
2401
2402 2019-11-05  Tom Tromey  <tom@tromey.com>
2403
2404         * tui/tui-source.h (struct tui_source_window): Inline
2405         constructor.  Remove destructor.
2406         <style_changed, m_observable>: Move to superclass.
2407         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2408         (struct tui_source_window_base): Move private members to end.
2409         <style_changed, m_observable>: Move from tui_source_window.
2410         * tui/tui-winsource.c (tui_copy_source_line): Move from
2411         tui-source.c.  Rename from copy_source_line.  Add special handling
2412         for negative line number.
2413         (tui_source_window_base::style_changed): Move from
2414         tui_source_window.
2415         (tui_source_window_base): Register observer.
2416         (~tui_source_window_base): New.
2417         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2418         rename.
2419         (tui_source_window::set_contents): Use tui_copy_source_line.
2420         (tui_source_window::tui_source_window): Move to tui-source.h.
2421         (tui_source_window::~tui_source_window): Remove.
2422         (tui_source_window::style_changed): Move to superclass.
2423         * tui/tui-disasm.c (tui_disassemble): Create string file with
2424         styling, when possible.  Add "addr_size" parameter.
2425         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2426         Don't compute maximum size.
2427         (len_without_escapes): New function
2428
2429 2019-11-05  Tom Tromey  <tom@tromey.com>
2430
2431         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2432         std::string.
2433         * tui/tui-winsource.c (tui_show_source_line): Update.
2434         * tui/tui-source.c (tui_source_window::set_contents): Update.
2435         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2436
2437 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2438
2439         * symtab.h (gdb_static_assert): Put && operator at the beginning
2440         of the line instead of the end.
2441
2442 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2443
2444         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2445         and sizeof (symbol).
2446         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2447
2448 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2449
2450         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2451         * configure.host: Mark *-*-solaris2.10* obsolete.
2452         * configure.tgt: Mark Solaris < 11 obsolete.
2453         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2454         Update target triplet.
2455
2456 2019-11-01  Tom Tromey  <tromey@adacore.com>
2457
2458         * utils.c (print_sys_errmsg): Simplify.
2459
2460 2019-11-01  Tom Tromey  <tromey@adacore.com>
2461
2462         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2463
2464 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2465
2466         * configure: Regenerate.
2467         * configure.ac: Remove check for strerror_r.
2468         * gdbsupport/common.m4: Check for strerror_r.
2469
2470 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2471
2472         PR gdb/25124
2473
2474         * arm-tdep.c (arm_per_objfile): Rename to ...
2475         (arm_per_bfd): ... this.
2476         (arm_objfile_data_key): Rename to ...
2477         (arm_bfd_data_key): ... this.
2478         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2479         data.
2480         (arm_record_special_symbol): Likewise.
2481
2482 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2483
2484         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2485         end.
2486         * c-typeprint.c (c_print_typedef): Likewise.
2487         * f-typeprint.c (f_print_typedef): Likewise.
2488         * m2-typeprint.c (m2_print_typedef): Likewise.
2489         * p-typeprint.c (pascal_print_typedef): Likewise.
2490         * rust-lang.c (rust_print_typedef): Likewise.
2491         * symtab.c (print_symbol_info): Print a newline after calling
2492         typedef_print.
2493
2494 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2495
2496         * symtab.c (info_module_cmdlist): New variable.
2497         (info_module_command): New function.
2498         (search_module_symbols): New function.
2499         (info_module_subcommand): New function.
2500         (struct info_modules_var_func_options): New struct.
2501         (info_modules_var_func_options_defs): New variable.
2502         (make_info_modules_var_func_options_def_group): New function.
2503         (info_module_functions_command): New function.
2504         (info_module_variables_command): New function.
2505         (info_module_var_func_command_completer): New function.
2506         (_initialize_symtab): Register new 'info module functions' and
2507         'info module variables' commands.
2508         * symtab.h (typedef symbol_search_in_module): New typedef.
2509         (search_module_symbols): Declare new function.
2510         * NEWS: Mention new commands.
2511
2512 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2513
2514         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2515         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2516         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2517         MODULES_DOMAIN.
2518         (scan_partial_symbols): Only create partial module symbols for non
2519         declarations.
2520         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2521         and MODULES_DOMAIN.
2522         * symtab.c (search_domain_name): Likewise.
2523         (search_symbols): Likewise.
2524         (print_symbol_info): Likewise.
2525         (symtab_symbol_info): Likewise.
2526         (info_modules_command): New function.
2527         (_initialize_symtab): Register 'info modules' command.
2528         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2529         * NEWS: Mention new 'info modules' command.
2530
2531 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2532
2533         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2534         and $_gdb_maint_setting_str.
2535
2536 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2537
2538         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2539         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2540         (str_value_from_setting, gdb_setting_str_internal_fn)
2541         (gdb_maint_setting_str_internal_fn): New functions.
2542         (_initialize_cli_cmds): Define the new convenience functions.
2543         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2544         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2545
2546 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2547
2548         * agent.c (set_can_use_agent): When the setting is turned on,
2549         look up agent symbols if we don't have them yet.
2550         (agent_new_objfile): Don't look up agent symbols when the agent
2551         setting is off.
2552
2553 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2554
2555         * config.in: Regenerate.
2556
2557 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2558
2559         * configure: Regenerate.
2560         * configure.ac: Check for strerror_r.
2561         * gdbsupport/common-utils.h (safe_strerror): Change return value
2562         to const char * and document that this function is now threadsafe.
2563         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2564         thread_local and call strerror_r, if available.
2565         * utils.c (perror_string): Update.
2566         (print_sys_errmsg): Update.
2567
2568 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2569
2570         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2571         objfile_key.
2572         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2573         objfile to fetch per-bfd data.
2574         (arm_find_exidx_entry): Likewise.
2575
2576 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2577
2578         * gdbsupport/agent.c (debug_agent): Change type to bool.
2579         (use_agent): Likewise.
2580         (all_agent_symbols_look_up): Likewise.
2581         (agent_loaded_p): Change return value to bool.
2582         (agent_look_up_symbols): Update.
2583         (agent_capability_check): Change return value to bool.
2584         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2585         (debug_agent): Change type to bool.
2586         (use_agent): Likewise.
2587         (agent_capability_check): Change return value to bool.
2588
2589 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2590
2591         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2592         (build_minimal_symbol_hash_tables): Code to clear the table moved
2593         to clear_minimal_symbol_hash_tables.
2594         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2595         when needed.
2596
2597 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2598
2599         * infcmd.c: Remove includes.
2600         * infrun.c: Remove includes.
2601
2602 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2603
2604         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2605         (grow_vect): Remove declaration.
2606         (ada_type_of_array): Remove declaration.
2607         (ada_update_initial_language): Remove declaration.
2608         (ada_fold_name): Remove declaration.
2609         (ada_fill_in_ada_prototype): Remove declaration.
2610         (user_select_syms): Remove declaration.
2611         (get_selections): Remove declaration.
2612         (ada_tag_type): Remove declaration.
2613         (ada_value_tag): Remove declaration.
2614         (ada_is_others_clause): Remove declaration.
2615         (ada_in_variant): Remove declaration.
2616         (ada_value_struct_elt): Remove declaration.
2617         (ada_attribute_name): Remove declaration.
2618         (ada_system_address_type): Remove declaration.
2619         * ada-lang.c (ada_watch_location_expression): Make static.
2620         (GROW_VECT): Move here from ada-lang.h.
2621         (grow_vect): Make static.
2622         (ada_update_initial_language): Make static.
2623         (ada_fold_name): Make static.
2624         (ada_type_of_array): Make static.
2625         (encoded_ordered_before): Move up.
2626         (sort_choices): Move up.
2627         (print_signatures): Move up.
2628         (ada_print_symbol_signature): Move up.
2629         (get_selections): Move up and make static.
2630         (user_select_syms): Move up and make static.
2631         (ada_value_struct_elt): Move up and make static.
2632         (ada_tag_type): Make static.
2633         (ada_value_tag): Make static.
2634         (ada_is_others_clause): Make static.
2635         (ada_in_variant): Make static.
2636         (ada_attribute_name): Make static.
2637
2638 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2639
2640         * ada-lang.c: Remove includes.
2641         * ada-typeprint.c: Remove includes.
2642         * ada-valprint.c: Remove includes.
2643
2644 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2645
2646         * addrmap.c: Add static assertions of type size, moved from
2647         _initialize_addrmap.
2648         (_initialize_addrmap): Remove.
2649
2650 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2651
2652         * coffread.c (record_minimal_symbol): Update.
2653         (process_coff_symbol): Update.
2654         * dbxread.c (read_dbx_symtab): Update.
2655         * dwarf2read.c (add_partial_symbol): Update.
2656         (fixup_go_packaging): Update.
2657         (load_partial_dies): Update.
2658         (new_symbol): Update.
2659         * elfread.c (record_minimal_symbol): Change signature to use
2660         gdb::string_view instead of name+len.
2661         (elf_symtab_read): Update.
2662         (elf_rel_plt_read): Update.
2663         * mdebugread.c (parse_partial_symbols): Update.
2664         (handle_psymbol_enumerators): Update.
2665         (new_symbol): Update.
2666         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2667         to use gdb::string_view instead of name+len.
2668         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2669         * psympriv.h (add_psymbol_to_list): Likewise.
2670         * psymtab.c (add_psymbol_to_bcache): Likewise.
2671         (add_psymbol_to_list): Likewise.
2672         * stabsread.c (define_symbol): Update.
2673         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2674         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2675         (symbol_set_names): Likewise.
2676         * xcoffread.c (scan_xcoff_symtab): Update.
2677
2678 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2679
2680         * symtab.h (symbol_set_names): Document that copy_name must be
2681         set to true for non-nullterminated strings.
2682         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2683         linkage_name if the entry was not found and we need to demangle.
2684
2685 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2686
2687         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2688         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2689         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2690         * gdbsupport/gdb_binary_search.h: New file.
2691
2692 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2693
2694         * NEWS: Mention new --with-system-gdbinit-dir option.
2695         * config.in: Regenerate.
2696         * configure: Regenerate.
2697         * configure.ac: Add new option --with-system-gdbinit-dir.
2698         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2699         for a ".gdb" suffix.
2700         * main.c (get_init_files): Change system_gdbinit argument to
2701         a vector and return the files in SYSTEM_GDBINIT_DIR in
2702         addition to SYSTEM_GDBINIT.
2703         (captured_main_1): Update.
2704         (print_gdb_help): Update.
2705         * top.c (print_gdb_configuration): Also print the value of
2706         SYSTEM_GDBINIT_DIR.
2707
2708 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2709
2710         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2711         that takes gdb::string_view arguments.
2712
2713 2019-10-26  Tom de Vries  <tdevries@suse.de>
2714
2715         * aarch64-linux-tdep.c: Fix typos in comments.
2716         * aarch64-tdep.c: Same.
2717         * ada-lang.c: Same.
2718         * amd64-nat.c: Same.
2719         * arc-tdep.c: Same.
2720         * arch/aarch64-insn.c: Same.
2721         * block.c: Same.
2722         * breakpoint.h: Same.
2723         * btrace.h: Same.
2724         * c-varobj.c: Same.
2725         * cli/cli-decode.c: Same.
2726         * cli/cli-script.c: Same.
2727         * cli/cli-utils.h: Same.
2728         * coff-pe-read.c: Same.
2729         * coffread.c: Same.
2730         * compile/compile-cplus-symbols.c: Same.
2731         * compile/compile-object-run.c: Same.
2732         * completer.c: Same.
2733         * corelow.c: Same.
2734         * cp-support.c: Same.
2735         * demangle.c: Same.
2736         * dwarf-index-write.c: Same.
2737         * dwarf2-frame.c: Same.
2738         * dwarf2-frame.h: Same.
2739         * eval.c: Same.
2740         * frame-base.h: Same.
2741         * frame.h: Same.
2742         * gdbcmd.h: Same.
2743         * gdbtypes.h: Same.
2744         * gnu-nat.c: Same.
2745         * guile/scm-objfile.c: Same.
2746         * i386-tdep.c: Same.
2747         * i386-tdep.h: Same.
2748         * infcall.c: Same.
2749         * infcall.h: Same.
2750         * linux-nat.c: Same.
2751         * m68k-tdep.c: Same.
2752         * macroexp.c: Same.
2753         * memattr.c: Same.
2754         * mi/mi-cmd-disas.c: Same.
2755         * mi/mi-getopt.h: Same.
2756         * mi/mi-main.c: Same.
2757         * minsyms.c: Same.
2758         * nat/aarch64-sve-linux-sigcontext.h: Same.
2759         * objfiles.h: Same.
2760         * ppc-linux-nat.c: Same.
2761         * ppc-linux-tdep.c: Same.
2762         * ppc-tdep.h: Same.
2763         * progspace.h: Same.
2764         * prologue-value.h: Same.
2765         * python/py-evtregistry.c: Same.
2766         * python/py-instruction.h: Same.
2767         * record-btrace.c: Same.
2768         * record-full.c: Same.
2769         * remote.c: Same.
2770         * rs6000-tdep.c: Same.
2771         * ser-tcp.c: Same.
2772         * sol-thread.c: Same.
2773         * sparc-sol2-tdep.c: Same.
2774         * sparc64-tdep.c: Same.
2775         * stabsread.c: Same.
2776         * symfile.c: Same.
2777         * symtab.h: Same.
2778         * target.c: Same.
2779         * tracepoint.c: Same.
2780         * tui/tui-data.h: Same.
2781         * tui/tui-io.c: Same.
2782         * tui/tui-win.c: Same.
2783         * tui/tui.c: Same.
2784         * unittests/rsp-low-selftests.c: Same.
2785         * user-regs.h: Same.
2786         * utils.c: Same.
2787         * utils.h: Same.
2788         * valarith.c: Same.
2789         * valops.c: Same.
2790         * valprint.c: Same.
2791         * valprint.h: Same.
2792         * value.c: Same.
2793         * value.h: Same.
2794         * varobj.c: Same.
2795         * x86-nat.h: Same.
2796         * xtensa-tdep.c: Same.
2797
2798 2019-10-25  Ali Tamur <tamur@google.com>
2799
2800         * charset.c (find_charset_names): Reflect API change.
2801
2802 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2803
2804         * symtab.c (struct demangled_name_entry): Change demangled name
2805         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2806         part of the struct anymore.
2807         (symbol_set_names): No longer obstack allocate + copy the demangled
2808         name, just store the allocated name from bfd.
2809
2810 2019-10-25  Tom Tromey  <tromey@adacore.com>
2811
2812         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2813         (bsearch_cie_cmp, add_cie): Remove.
2814         (find_cie): Reimplement.
2815         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2816         (dwarf2_build_frame_info): Update.
2817
2818 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2819
2820         PR gdb/25126
2821         * symfile.c (reread_symbols): Call forget_cached_source_info to
2822         clear the stale source cache.
2823
2824 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2825
2826         * configure: Regenerate.
2827         * configure.ac: Remove code that sets python_has_threads.
2828
2829 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2830
2831         * config.in: Regenerate.
2832         * configure: Regenerate.
2833         * configure.ac: Remove the code that uses sed to get the python
2834         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2835
2836 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2837
2838         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2839         error paths.
2840
2841 2019-10-23  Tom Tromey  <tom@tromey.com>
2842
2843         * arc-tdep.c: Remove ".." from include.
2844         * frv-tdep.c: Remove ".." from include.
2845         * lm32-tdep.c: Remove ".." from include.
2846         * microblaze-tdep.c: Remove ".." from include.
2847         * or1k-tdep.h: Remove ".." from include.
2848         * s12z-tdep.c: Remove ".." from include.
2849         * Makefile.in (OPCODES_CFLAGS): Add comment.
2850         (TOP_CFLAGS): New variable.
2851         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2852
2853 2019-10-23  Tom Tromey  <tom@tromey.com>
2854
2855         * Makefile.in (READLINE_DIR): Update.
2856
2857 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2858
2859         * infcall.c (call_function_by_hand_dummy): Fix the function
2860         comment.  And extract out a code section into...
2861         (reserve_stack_space): ...this new function.
2862
2863 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2864
2865         * infcall.c (value_arg_coerce): Remove an unused parameter.
2866         (call_function_by_hand_dummy): Update the call to
2867         'value_arg_coerce'.
2868
2869 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2870
2871         * infcall.c (call_function_by_hand_dummy): Refactor.
2872
2873 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2874
2875         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2876
2877 2019-10-23  Tom Tromey  <tom@tromey.com>
2878
2879         * configure: Rebuild.
2880         * configure.ac: Don't check for sigprocmask.
2881         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2882
2883 2019-10-23  Tom Tromey  <tom@tromey.com>
2884
2885         * configure: Rebuild.
2886         * acinclude.m4: Use m4_include, not sinclude.
2887
2888 2019-10-23  Tom de Vries  <tdevries@suse.de>
2889
2890         PR breakpoints/24687
2891         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2892
2893 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2894
2895         * symtab.c (struct demangled_name_entry) <language>: Change from
2896         bitfield to regular variable.
2897
2898 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2899
2900         * symtab.c (struct demangled_name_entry): Add a constructor.
2901         (free_demangled_name_entry): New function to call the destructor
2902         for demangled_name_entry.
2903         (create_demangled_names_hash): Pass free_demangled_name_entry to
2904         htab_create_alloc.
2905         (symbol_set_names): Call placement new for demangled_name_entry.
2906         * utils.c: No longer include xxhash.h here, now that fast_hash
2907         is inlined in the header.
2908         * utils.h: Instead, include it here.
2909
2910 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2911
2912         * Makefile.in: Link with libxxhash.
2913         * config.in: Regenerate.
2914         * configure: Regenerate.
2915         * configure.ac: Search for libxxhash.
2916         * utils.c (fast_hash): Use xxhash if present.
2917
2918 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2919
2920         * utils.h (fast_hash): New function.
2921         * symtab.c (hash_demangled_name_entry): Call new function
2922         fast_hash.
2923
2924 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2925
2926         * symtab.c (struct demangled_name_entry): Change type of mangled
2927         to gdb::string_view. Also adds a constructor that takes the
2928         mangled name.
2929         (hash_demangled_name_entry): Update.
2930         (eq_demangled_name_entry): Update.
2931         (free_demangled_name_entry): New function to call the destructor
2932         now that this is not a POD anymore.
2933         (create_demangled_names_hash): Pass free_demangled_name_entry to
2934         htab_create_alloc.
2935         (symbol_set_names): Update.
2936
2937 2019-10-21  Ali Tamur  <tamu@google.com>
2938
2939         * dwarf2read.c (dir_index): Change type.
2940         (file_name_index): Likewise.
2941         (line_header::include_dir_at): Change comment and implementation on
2942         whether it is DWARF 5.
2943         (line_header::is_valid_file_index): New function.
2944         (line_header::file_name_at): Change comment and implementation on
2945         whether it is DWARF 5.
2946         (line_header::file_names): Change to private field renamed as
2947         m_file_names and introduce a new accessor method.
2948         (line_header::file_names_size): New method.
2949         (line_header::include_dirs): Change to private field and rename as
2950         m_include_dirs.
2951         (dw2_get_file_names_reader): Define local var at a smaller scope and
2952         reflect API change.
2953         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
2954         (process_structure_scope): Likewise.
2955         (line_header::add_include_dir): Change message and reflect renaming.
2956         (line_header::add_file_name): Likewise.
2957         (read_formatted_entries): Handle DW_FORM_data16.
2958         (dwarf_decode_line_header): Fix line header length calculation.
2959         (psymtab_include_file_name): Change comment and API.
2960         (lnp_state_machine::m_file): Update comment and reflect type change.
2961         (lnp_state_machine::record_line): Reflect type change.
2962         (dwarf_decode_lines): Reflect API change.
2963         (file_file_name): Likewise.
2964         (file_full_name): Likewise.
2965
2966 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
2967
2968         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
2969
2970 2019-10-21  Tom Tromey  <tom@tromey.com>
2971
2972         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
2973
2974 2019-10-21  Tom Tromey  <tom@tromey.com>
2975
2976         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
2977         NM_H.   Use AC_CONFIG_LINKS.
2978         * configure: Rebuild.
2979         * Makefile.in (NM_H): New variable.
2980         (generated_files): Add NM_H.  Remove gcore.
2981         (nm.h, stamp-nmh): New targets.
2982
2983 2019-10-20  Tom Tromey  <tom@tromey.com>
2984
2985         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
2986         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
2987         obsolete comment.
2988         (put_objfile_before): Now static.
2989
2990 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
2991
2992         * gdbsupport/common-utils.h (startswith): Change return type to
2993         bool.
2994
2995 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
2996
2997         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
2998         * breakpoint.c (bp_locations_compare): Rename to...
2999         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3000         (update_global_location_list): Use std::sort instead of qsort.
3001         * buildsym.c (compare_line_numbers): Rename to...
3002         (lte_is_less_than): ...this, and change to std::sort semantics.
3003         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3004         instead of qsort.
3005         * disasm.c (compare_lines): Rename to...
3006         (line_is_less_than): ...this, and change to std::sort semantics.
3007         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3008         of qsort.
3009         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3010         (fde_is_less_than): ...this, and change to std::sort semantics.
3011         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3012         * mdebugread.c (compare_blocks):
3013         (block_is_less_than): ...this, and change to std::sort semantics.
3014         (sort_blocks): Call std::sort instead of qsort.
3015         * objfiles.c (qsort_cmp): Rename to...
3016         (sort_cmp): ...this, and change to std::sort semantics.
3017         (update_section_map): Call std::sort instead of qsort.
3018         * remote.c (compare_pnums): Remove.
3019         (map_regcache_remote_table): Call std::sort instead of qsort.
3020         * utils.c (compare_positive_ints): Remove.
3021         * utils.h (compare_positive_ints): Remove.
3022         * xcoffread.c (compare_lte): Remove.
3023         (arrange_linetable): Call std::sort instead of qsort.
3024
3025 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3026
3027         * symfile.c (init_entry_point_info): Fix typo.
3028         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3029
3030 2019-10-18  Tom de Vries  <tdevries@suse.de>
3031
3032         * aarch64-tdep.c: Fix typos in comments.
3033         * ada-lang.c: Same.
3034         * ada-tasks.c: Same.
3035         * alpha-tdep.c: Same.
3036         * alpha-tdep.h: Same.
3037         * amd64-nat.c: Same.
3038         * amd64-windows-tdep.c: Same.
3039         * arc-tdep.c: Same.
3040         * arc-tdep.h: Same.
3041         * arch-utils.c: Same.
3042         * arm-nbsd-tdep.c: Same.
3043         * arm-tdep.c: Same.
3044         * ax-gdb.c: Same.
3045         * blockframe.c: Same.
3046         * btrace.c: Same.
3047         * c-varobj.c: Same.
3048         * coff-pe-read.c: Same.
3049         * coffread.c: Same.
3050         * cris-tdep.c: Same.
3051         * darwin-nat.c: Same.
3052         * dbxread.c: Same.
3053         * dcache.c: Same.
3054         * disasm.c: Same.
3055         * dtrace-probe.c: Same.
3056         * dwarf-index-write.c: Same.
3057         * dwarf2-frame-tailcall.c: Same.
3058         * dwarf2-frame.c: Same.
3059         * dwarf2read.c: Same.
3060         * eval.c: Same.
3061         * exceptions.c: Same.
3062         * fbsd-tdep.c: Same.
3063         * findvar.c: Same.
3064         * frame.c: Same.
3065         * frv-tdep.c: Same.
3066         * gnu-v3-abi.c: Same.
3067         * go32-nat.c: Same.
3068         * h8300-tdep.c: Same.
3069         * hppa-tdep.c: Same.
3070         * i386-linux-tdep.c: Same.
3071         * i386-tdep.c: Same.
3072         * ia64-libunwind-tdep.c: Same.
3073         * ia64-tdep.c: Same.
3074         * infcmd.c: Same.
3075         * infrun.c: Same.
3076         * linespec.c: Same.
3077         * linux-nat.c: Same.
3078         * linux-thread-db.c: Same.
3079         * machoread.c: Same.
3080         * mdebugread.c: Same.
3081         * mep-tdep.c: Same.
3082         * mn10300-tdep.c: Same.
3083         * namespace.c: Same.
3084         * objfiles.c: Same.
3085         * opencl-lang.c: Same.
3086         * or1k-tdep.c: Same.
3087         * osabi.c: Same.
3088         * ppc-linux-nat.c: Same.
3089         * ppc-linux-tdep.c: Same.
3090         * ppc-sysv-tdep.c: Same.
3091         * printcmd.c: Same.
3092         * procfs.c: Same.
3093         * record-btrace.c: Same.
3094         * record-full.c: Same.
3095         * remote-fileio.c: Same.
3096         * remote.c: Same.
3097         * rs6000-tdep.c: Same.
3098         * s12z-tdep.c: Same.
3099         * score-tdep.c: Same.
3100         * ser-base.c: Same.
3101         * ser-go32.c: Same.
3102         * skip.c: Same.
3103         * sol-thread.c: Same.
3104         * solib-svr4.c: Same.
3105         * solib.c: Same.
3106         * source.c: Same.
3107         * sparc-nat.c: Same.
3108         * sparc-sol2-tdep.c: Same.
3109         * sparc-tdep.c: Same.
3110         * sparc64-tdep.c: Same.
3111         * stabsread.c: Same.
3112         * stack.c: Same.
3113         * symfile.c: Same.
3114         * symtab.c: Same.
3115         * target-descriptions.c: Same.
3116         * target-float.c: Same.
3117         * thread.c: Same.
3118         * utils.c: Same.
3119         * valops.c: Same.
3120         * valprint.c: Same.
3121         * value.c: Same.
3122         * varobj.c: Same.
3123         * windows-nat.c: Same.
3124         * xcoffread.c: Same.
3125         * xstormy16-tdep.c: Same.
3126         * xtensa-tdep.c: Same.
3127
3128 2019-10-17  Tom Tromey  <tromey@adacore.com>
3129
3130         * configure: Rebuild.
3131         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3132         in AC_CONFIG_FILES invocation.
3133         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3134         new-style config.status invocation.
3135
3136 2019-10-17  Tom de Vries  <tdevries@suse.de>
3137
3138         * arm-nbsd-nat.c: Fix typos in comments.
3139         * arm-tdep.c: Same.
3140         * darwin-nat-info.c: Same.
3141         * dwarf2read.c: Same.
3142         * elfread.c: Same.
3143         * event-top.c: Same.
3144         * findvar.c: Same.
3145         * gdbtypes.c: Same.
3146         * hppa-tdep.c: Same.
3147         * i386-tdep.c: Same.
3148         * jit.c: Same.
3149         * main.c: Same.
3150         * mdebugread.c: Same.
3151         * moxie-tdep.c: Same.
3152         * nto-procfs.c: Same.
3153         * osabi.c: Same.
3154         * ppc-linux-tdep.c: Same.
3155         * remote.c: Same.
3156         * riscv-tdep.c: Same.
3157         * s390-tdep.c: Same.
3158         * sh-tdep.c: Same.
3159         * sparc-linux-tdep.c: Same.
3160         * sparc-nat.c: Same.
3161         * stack.c: Same.
3162         * target-descriptions.c: Same.
3163         * top.c: Same.
3164         * varobj.c: Same.
3165
3166 2019-10-16  Tom Tromey  <tom@tromey.com>
3167
3168         * objfiles.h (struct objfile) <original_name>: Now const.
3169
3170 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3171
3172         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3173         pass on to sigsetjmp's second argument.
3174         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3175
3176 2019-10-16  Keith Seitz  <keiths@redhat.com>
3177
3178         PR gdb/23567
3179         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3180         sections whose size is greater than the file size.
3181
3182 2019-10-16  Jim Wilson  <jimw@sifive.com>
3183
3184         * riscv-tdep.c (riscv_gcc_target_options): New.
3185         (riscv_gnu_triplet_regexp): New.
3186         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3187         set_gdbarch_gnu_triplet_regexp.
3188
3189 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3190
3191         * Makefile.in: Add xml-builtin.h.
3192         * features/feature_to_c.sh: Add an include for xml-builtin.h
3193         to ensure that the compiler checks that the types match.
3194         * xml-builtin.h: New file.
3195         * xml-support.c (fetch_xml_builtin): Add missing const.
3196         * xml-support.h: Remove declaration of xml_builtins.
3197
3198 2019-10-16  Tom de Vries  <tdevries@suse.de>
3199
3200         PR tdep/25096
3201         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3202         (amd64_classify_aggregate): ... here.
3203         (amd64_classify_aggregate_field): Handled fiels of nested structs
3204         recursively.
3205
3206 2019-10-16  Tom de Vries  <tdevries@suse.de>
3207
3208         PR tdep/24104
3209         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3210         that handles 'theclass'.
3211
3212 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3213
3214         * linespec.c (decode_digits_ordinary): Update comment.
3215         * make-target-delegates: No longer need to handle VEC case.
3216         * memrange.c (normalize_mem_ranges): Update comment.
3217         * namespace.c (add_using_directive): Update comment.
3218         * objc-lang.c (uniquify_strings): Update comment.
3219         * ppc-linux-nat.c (struct thread_points): Update comment.
3220         * probe.h (find_probes_in_objfile): Update comment.
3221         * target.h (enum flash_preserve_mode): Update comment.
3222         * varobj.c (varobj_restrict_range): Update comment.
3223         * varobj.h (varobj_list_children): Update comment.
3224
3225 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3226
3227         * Makefile.in: Remove references to vec.h and vec.c.
3228         * aarch64-tdep.c: No longer include vec.h.
3229         * ada-lang.c: Likewise.
3230         * ada-lang.h: Likewise.
3231         * arm-tdep.c: Likewise.
3232         * ax.h: Likewise.
3233         * breakpoint.h: Likewise.
3234         * charset.c: Likewise.
3235         * cp-support.h: Likewise.
3236         * dtrace-probe.c: Likewise.
3237         * dwarf2read.c: Likewise.
3238         * extension.h: Likewise.
3239         * gdb_bfd.c: Likewise.
3240         * gdbsupport/gdb_vecs.h: Likewise.
3241         * gdbsupport/vec.c: Remove.
3242         * gdbsupport/vec.h: Remove.
3243         * gdbthread.h: Likewise.
3244         * guile/scm-type.c: Likewise.
3245         * inline-frame.c: Likewise.
3246         * machoread.c: Likewise.
3247         * memattr.c: Likewise.
3248         * memrange.h: Likewise.
3249         * namespace.h: Likewise.
3250         * nat/linux-btrace.h: Likewise.
3251         * osdata.c: Likewise.
3252         * parser-defs.h: Likewise.
3253         * progspace.h: Likewise.
3254         * python/py-type.c: Likewise.
3255         * record-btrace.c: Likewise.
3256         * rust-exp.y: Likewise.
3257         * solib-target.c: Likewise.
3258         * stap-probe.c: Likewise.
3259         * target-descriptions.c: Likewise.
3260         * target-memory.c: Likewise.
3261         * target.h: Likewise.
3262         * varobj.c: Likewise.
3263         * varobj.h: Likewise.
3264         * xml-support.h: Likewise.
3265
3266 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3267
3268         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3269         Update for new std::vector based implementation.
3270         (process_psymtab_comp_unit_reader): Likewise.
3271         (scan_partial_symbols): Likewise.
3272         (recursively_compute_inclusions): Likewise.
3273         (compute_compunit_symtab_includes): Likewise.
3274         (process_imported_unit_die): Likewise.
3275         (queue_and_load_dwo_tu): Likewise.
3276         (follow_die_sig_1): Likewise.
3277         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3278         (typedef dwarf2_per_cu_ptr): Remove.
3279         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3280         function.
3281         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3282         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3283         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3284         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3285         std::vector.
3286
3287 2019-10-15  Tom Tromey  <tromey@adacore.com>
3288
3289         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3290         TID.
3291
3292 2019-10-15  Tom Tromey  <tromey@adacore.com>
3293
3294         * windows-nat.c (windows_nat_target::fetch_registers)
3295         (windows_nat_target::store_registers): Rename "pid" to "tid".
3296
3297 2019-10-15  Tom Tromey  <tromey@adacore.com>
3298
3299         * gdbarch.h, gdbarch.c: Rebuild.
3300         * gdbarch.sh (gcc_target_options): Change return type to
3301         std::string.
3302         * compile/compile.c (get_args): Update.
3303         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3304         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3305         std::string.
3306         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3307         std::string.
3308         * arch-utils.c (default_gcc_target_options): Return std::string.
3309         * arch-utils.h (default_gcc_target_options): Return std::string.
3310         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3311
3312 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3313
3314         * breakpoint.c (breakpoint_chain): Make static.
3315         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3316         of accessing breakpoint_chain.
3317
3318 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3319
3320         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3321         to a gdb::function_view and return value to bool.
3322         * breakpoint.h (iterate_over_breakpoints): Likewise.
3323         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3324         (pop_dummy_frame): Update.
3325         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3326         (gdbscm_breakpoints): Update.
3327         * python/py-breakpoint.c (build_bp_list): Update.
3328         (gdbpy_breakpoints): Update.
3329         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3330         Update.
3331         (bpfinishpy_handle_stop): Update.
3332         (bpfinishpy_handle_exit): Update.
3333         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3334         (svr4_update_solib_event_breakpoints): Update.
3335
3336 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3337
3338         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3339         when unwrapping single-field structs.
3340
3341 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3342
3343         * dwarf2read.c: Remove includes.
3344
3345 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3346
3347         * ui-out.c (ui_out::call_do_message): Silence
3348         -Wformat-nonliteral warning.
3349
3350 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3351
3352         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3353         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3354         include: readline/tilde.h.
3355
3356 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3357
3358         * remote.c (remote_target::get_trace_status): Remove declaration of
3359         trace_regblock_size.
3360
3361 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3362
3363         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3364         (show_user): Remove declaration of cmdlist.
3365         * cli/cli-cmds.h (max_user_call_depth): Declare.
3366         * cli/cli-script.c (execute_user_command): Remove declaration
3367         of max_user_call_depth.
3368
3369 2019-10-11  Jim Wilson  <jimw@sifive.com>
3370
3371         * gdbsupport/print-utils.h (pulongest): Fix comment.
3372         (plongest): Likewise.
3373         (phex): Add missing comment, mention leading zeros.
3374         (phex_nz): Add mention of no leading zeros to comment.
3375
3376         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3377         plongest instead of unsigned long long cast.
3378
3379 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3380
3381         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3382         for external_editor_command and gdbtk_test.
3383
3384 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3385
3386         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3387         * varobj.c (varobjdebug): Move comment to...
3388         * varobj.h (varobjdebug): ...here, and declare.
3389
3390 2019-10-09  Tom Tromey  <tom@tromey.com>
3391
3392         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3393         erase_data_content.
3394
3395 2019-10-09  Tom Tromey  <tom@tromey.com>
3396
3397         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3398         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3399         * tui/tui-command.c (tui_cmd_window::resize)
3400         (tui_refresh_cmd_win): Update.
3401         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3402         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3403         * tui/tui-data.c (~tui_gen_win_info): Remove.
3404         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3405         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3406         (tui_redisplay_readline, tui_mld_flush)
3407         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3408         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3409         (tui_data_window::erase_data_content)
3410         (tui_data_item_window::rerender)
3411         (tui_data_item_window::refresh_window): Update.
3412         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3413         (box_win, tui_gen_win_info::make_window)
3414         (tui_gen_win_info::make_visible): Update.
3415         (tui_delete_win): Remove.
3416         * tui/tui-winsource.c
3417         (tui_source_window_base::do_erase_source_content): Update.
3418         (tui_show_source_line, tui_source_window_base::update_tab_width)
3419         (tui_source_window_base::update_exec_info): Update.
3420         * tui/tui-data.h (struct curses_deleter): New.
3421         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3422         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3423
3424 2019-10-09  Tom Tromey  <tom@tromey.com>
3425
3426         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3427
3428 2019-10-09  Tom Tromey  <tom@tromey.com>
3429
3430         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3431         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3432
3433 2019-10-09  Tom Tromey  <tom@tromey.com>
3434
3435         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3436         window height directly.
3437         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3438         declare.
3439         * tui/tui-layout.c (tui_default_win_height): Remove.
3440         (tui_default_win_viewport_height): Remove.
3441
3442 2019-10-09  Tom Tromey  <tom@tromey.com>
3443
3444         * tui/tui.h: Remove comments.
3445
3446 2019-10-09  Tom de Vries  <tdevries@suse.de>
3447
3448         * python/lib/gdb/printer/bound_registers.py: Use
3449         '^builtin_type_bound128' as regexp argument for
3450         add_builtin_pretty_printer.
3451
3452 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3453
3454         * guile/guile.c (guile_extension_script_ops): Remove forward
3455         declaration and mark as static.
3456         (guile_script_ops): Likewise.
3457         (extension_language_guile): Move further down in the file so
3458         it can reference the definitions for guile_{extension_,}script_ops.
3459
3460 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3461
3462         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3463         except SORTL, DFLTCC, and KDSA.
3464
3465 2019-10-08  Tom Tromey  <tromey@adacore.com>
3466
3467         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3468         (struct safe_symbol_file_add_args): Remove.
3469
3470 2019-10-08  Tom Tromey  <tromey@adacore.com>
3471
3472         * windows-nat.c: Don't include buildsym-legacy.h.
3473
3474 2019-10-08  Tom Tromey  <tromey@adacore.com>
3475
3476         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3477
3478 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3479
3480         * gdbtypes.c (overload_debug): Move comment to header.
3481         * gdbtypes.h (overload_debug): Declare.
3482         * valops.c: Remove declaration of overload_debug, instead
3483         include gdbtypes.h.
3484
3485 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3486
3487         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3488         through _().
3489         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3490         move comment...
3491         * language.h (lang_frame_mismatch_warn): ... here. Also add
3492         declaration.
3493         * top.c (lang_frame_mismatch_warn): Remove declaration.
3494         (check_frame_language_change): Pass lang_frame_mismatch_warn
3495         through _().
3496
3497 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3498
3499         * c-lang.h (vtbl_ptr_name): Declare.
3500         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3501         it from the header.
3502         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3503
3504 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3505
3506         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3507         gdb_static_assert.
3508
3509 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3510
3511         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3512         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3513         * ctfread.c: New file.
3514         * ctfread.h: New file.
3515         * elfread.c: Include ctfread.h.
3516         (struct elfinfo text_p): New member ctfsect.
3517         (elf_locate_sections): Mark CTF section.
3518         (elf_symfile_read): Call elfctf_build_psymtabs.
3519         * Makefile.in (LIBCTF): Add.
3520         (CLIBS): Use it.
3521         (CDEPS): Likewise.
3522         (DIST): Add ctfread.c.
3523
3524 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3525
3526         * ctfread.c (struct nextfield): Renamed to ...
3527         (struct ctf_nextfield): ... this.
3528         (struct field_info): Renamed to ...
3529         (strut ctf_field_info): ... this.
3530         (attach_fields_to_type): Update for renamed structures.
3531         (ctf_add_member_cb): Likewise.
3532         (ctf_add_enum_member_cb): Likewise.
3533         (process_struct_members): Likewise.
3534         (process_enum_type): Likewise.
3535
3536 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3537
3538         * tracectf.h: Rename, was ctf.h.
3539         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3540         * tracefile.c: Likewise.
3541         * tracepoint.c: Remove unused include ctf.h.
3542         * mi/mi-main.c: Likewise.
3543         * Makefile.in Replace ctf.c with tracectf.c.
3544
3545 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3546
3547         * version.in: Change version number to "9.0.50.DATE-git".
3548
3549 2019-10-03  Tom Tromey  <tom@tromey.com>
3550
3551         PR rust/24976:
3552         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3553
3554 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3555
3556         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3557         cp_search_name_hash.
3558         * NEWS: Add entry about nested function support.
3559
3560 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3561             Andrew Burgess  <andrew.burgess@embecosm.com>
3562
3563         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3564         for nested static variables when searchin VAR_DOMAIN.
3565         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3566         global scope, update comment.
3567         (add_partial_subprogram): Call add_partial_subprogram recursively
3568         for nested subroutines when processinng Fortran.
3569         (load_partial_dies): Process the child entities of a subprogram
3570         when processing Fortran.
3571         (partial_die_parent_scope): Handle building scope
3572         for Fortran nested functions.
3573         (process_die): Record that nested functions have a scope.
3574         (new_symbol): Always record Fortran subprograms on the global
3575         symbol list.
3576         (determine_prefix): How to build the prefix for Fortran
3577         subprograms.
3578
3579 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3580
3581         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3582         have just sent the thread a SIGSTOP and are waiting for it to
3583         arrive.
3584
3585 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3586
3587         * btrace.c (btrace_add_pc): Remove whitespace before the template
3588         parameter in 'std::vector <...>'.
3589         (parse_xml_btrace_block): Likewise.
3590         (btrace_maint_decode_pt): Likewise.
3591         (btrace_maint_update_packets): Likewise.
3592         (btrace_maint_print_packets): Likewise.
3593         * btrace.h (struct btrace_maint_info): Likewise.
3594         * dwarf2read.c (struct type_unit_group): Likewise.
3595         (build_type_psymtabs_reader): Likewise.
3596         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3597         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3598         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3599
3600 2019-10-03  Tom de Vries  <tdevries@suse.de>
3601
3602         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3603         the first line of the help text for set/show style metadata.
3604
3605 2019-10-02  Tom Tromey  <tromey@adacore.com>
3606
3607         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3608         * gdbsupport/common-inferior.c: New file.
3609         * infcmd.c (startup_with_shell): Don't define.
3610         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3611         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3612         * inferior.h (startup_with_shell): Don't declare.
3613
3614 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3615
3616         * gdbsupport/gdb_assert.h: Include errors.h.
3617         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3618
3619 2019-10-02  Tom Tromey  <tromey@adacore.com>
3620
3621         * NEWS: Add $_ada_exception entry.
3622         * ada-lang.c (struct ada_catchpoint): Add constructor.
3623         <m_kind>: New member.
3624         (allocate_location_exception, re_set_exception): Remove
3625         "ex" parameter.
3626         (should_stop_exception): Compute $_ada_exception.
3627         (check_status_exception, print_it_exception)
3628         (print_one_exception, print_mention_exception): Remove
3629         "ex" parameter.
3630         (allocate_location_catch_exception, re_set_catch_exception)
3631         (check_status_exception, print_it_catch_exception)
3632         (print_one_catch_exception, print_mention_catch_exception)
3633         (print_recreate_catch_exception)
3634         (allocate_location_catch_exception_unhandled)
3635         (re_set_catch_exception_unhandled)
3636         (check_status_exception, print_it_catch_exception_unhandled)
3637         (print_one_catch_exception_unhandled)
3638         (print_mention_catch_exception_unhandled)
3639         (print_recreate_catch_exception_unhandled)
3640         (allocate_location_catch_assert, re_set_catch_assert)
3641         (check_status_assert, print_it_catch_assert)
3642         (print_one_catch_assert, print_mention_catch_assert)
3643         (print_recreate_catch_assert)
3644         (allocate_location_catch_handlers, re_set_catch_handlers)
3645         (check_status_handlers, print_it_catch_handlers)
3646         (print_one_catch_handlers, print_mention_catch_handlers)
3647         (print_recreate_catch_handlers): Remove.
3648         (create_ada_exception_catchpoint): Update.
3649         (initialize_ada_catchpoint_ops): Update.
3650
3651 2019-10-02  Tom Tromey  <tromey@adacore.com>
3652
3653         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3654         (create_excep_cond_exprs): Simplify exception string computation.
3655         (ada_exception_catchpoint_cond_string): Likewise.
3656
3657 2019-10-02  Tom Tromey  <tromey@adacore.com>
3658
3659         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3660         * ada-lang.c (lesseq_defined_than): Handle
3661         LOC_STATIC.
3662         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3663         parameter.
3664         (dwarf2_has_info): Likewise.
3665         (new_symbol): Set maybe_copied on symbol when
3666         appropriate.
3667         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3668         parameter.
3669         <can_copy>: New member.
3670         * elfread.c (record_minimal_symbol): Set maybe_copied
3671         on symbol when appropriate.
3672         (elf_symfile_read): Update call to dwarf2_has_info.
3673         * minsyms.c (lookup_minimal_symbol_linkage): New
3674         function.
3675         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3676         * symtab.c (get_symbol_address, get_msymbol_address):
3677         New functions.
3678         * symtab.h (get_symbol_address, get_msymbol_address):
3679         Declare.
3680         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3681         maybe_copied.
3682         (struct symbol, struct minimal_symbol) <maybe_copied>:
3683         New member.
3684
3685 2019-10-02  Tom Tromey  <tromey@adacore.com>
3686
3687         * source.c (struct current_source_location): New.
3688         (current_source_key): New global.
3689         (current_source_symtab, current_source_line)
3690         (current_source_pspace): Remove.
3691         (get_source_location): New function.
3692         (get_current_source_symtab_and_line)
3693         (set_default_source_symtab_and_line)
3694         (set_current_source_symtab_and_line)
3695         (clear_current_source_symtab_and_line, select_source_symtab)
3696         (info_source_command, print_source_lines_base)
3697         (info_line_command, search_command_helper, _initialize_source):
3698         Update.
3699
3700 2019-10-02  Tom Tromey  <tromey@adacore.com>
3701
3702         * source.c (select_source_symtab): Don't call
3703         decode_line_with_current_source.
3704
3705 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3706
3707         * symtab.c (lookup_global_symbol): Search global block.
3708
3709 2019-10-02  Tom Tromey  <tromey@adacore.com>
3710
3711         * coffread.c (process_coff_symbol): Update.
3712         * dwarf2read.c (var_decode_location, new_symbol): Update.
3713         * mdebugread.c (parse_symbol): Update.
3714         * objfiles.c (relocate_one_symbol): Update.
3715         * stabsread.c (define_symbol, fix_common_block)
3716         (scan_file_globals): Update.
3717         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3718         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3719         * xcoffread.c (process_xcoff_symbol): Update.
3720
3721 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3722
3723         * MAINTAINERS: Update my email address.
3724
3725 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3726
3727         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3728         std::vector.
3729         (build_type_psymtabs_reader): Update for std::vector.
3730         (build_type_psymtab_dependencies): Likewise.
3731         * dwarf2read.h: Remove use of DEF_VEC_P.
3732         (typedef sig_type_ptr): Delete.
3733
3734 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3735
3736         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3737         to std::vector.
3738         (btrace_maint_decode_pt): Likewise, and move allocation of the
3739         vector outside of the loop.
3740         (btrace_maint_update_packets): Update to handle change from VEC to
3741         std::vector.
3742         (btrace_maint_print_packets): Likewise.
3743         (maint_info_btrace_cmd): Likewise.
3744         * btrace.h: Remove use of DEF_VEC_O.
3745         (typedef btrace_pt_packet_s): Delete.
3746         (struct btrace_maint_info) <packets>: Change fromm VEC to
3747         std::vector.
3748         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3749
3750 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3751
3752         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3753         make accesses into the vector constant references.
3754         (btrace_add_pc): Update for std::vector.
3755         (btrace_stitch_bts): Likewise.
3756         (parse_xml_btrace_block): Likewise.
3757         (btrace_maint_update_packets): Likewise.
3758         (btrace_maint_print_packets): Likewise.
3759         (maint_info_btrace_cmd): Likewise.
3760         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3761         std::vector.
3762         (btrace_data::empty): Likewise.
3763         (btrace_data_append): Likewise.
3764         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3765         (typedef btrace_block_s): Delete.
3766         (struct btrace_block): Add constructor.
3767         (struct btrace_data_bts) <blocks>: Change to std::vector.
3768         * nat/linux-btrace.c (perf_event_read_bts): Update for
3769         std::vector.
3770         (linux_read_bts): Likewise.
3771
3772 2019-10-01  Tom Tromey  <tom@tromey.com>
3773
3774         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3775
3776 2019-10-01  Tom Tromey  <tom@tromey.com>
3777
3778         * stack.c (print_frame, info_frame_command_core): Use
3779         styled_string.
3780         * linux-thread-db.c (try_thread_db_load_1)
3781         (try_thread_db_load_from_pdir_1): Use styled_string.
3782         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3783         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3784         (maybe_print_unsupported_script_warning)
3785         (maybe_print_script_not_found_warning): Use styled_string.
3786         * ada-lang.c (user_select_syms): Use styled_string.
3787
3788 2019-10-01  Tom Tromey  <tom@tromey.com>
3789
3790         * p-lang.c (pascal_printstr): Use metadata style.
3791         * value.c (show_convenience): Use metadata style.
3792         * valprint.c (valprint_check_validity, val_print_optimized_out)
3793         (val_print_not_saved, val_print_unavailable)
3794         (val_print_invalid_address, generic_val_print, val_print)
3795         (value_check_printable, val_print_array_elements): Use metadata
3796         style.
3797         * ui-out.h (class ui_out) <field_fmt>: New overload.
3798         <do_field_fmt>: Add style parameter.
3799         * ui-out.c (ui_out::field_fmt): New overload.
3800         * typeprint.c (type_print_unknown_return_type)
3801         (val_print_not_allocated, val_print_not_associated): Use metadata
3802         style.
3803         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3804         parameter.
3805         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3806         * tracepoint.c (tvariables_info_1): Use metadata style.
3807         * stack.c (print_frame_arg, print_frame_info, print_frame)
3808         (info_frame_command_core): Use metadata style.
3809         * skip.c (info_skip_command): Use metadata style.
3810         * rust-lang.c (rust_print_enum): Use metadata style.
3811         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3812         metadata style.
3813         * python/py-framefilter.c (py_print_single_arg): Use metadata
3814         style.
3815         * printcmd.c (do_one_display, print_variable_and_value): Use
3816         metadata style.
3817         * p-valprint.c (pascal_val_print)
3818         (pascal_object_print_value_fields): Use metadata style.
3819         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3820         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3821         parameter.
3822         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3823         * m2-valprint.c (m2_print_long_set): Use metadata style.
3824         * m2-typeprint.c (m2_print_type): Use metadata style.
3825         * infcmd.c (print_return_value_1): Use metadata style.
3826         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3827         * f-valprint.c (info_common_command_for_block): Use metadata
3828         style.
3829         * f-typeprint.c (f_type_print_base): Use metadata style.
3830         * expprint.c (print_subexp_standard): Use metadata style.
3831         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3832         * cli/cli-style.h (class cli_style_option): Add constructor.
3833         (metadata_style): Declare.
3834         * cli/cli-style.c (metadata_style): New global.
3835         (_initialize_cli_style): Register metadata style.
3836         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3837         parameter.
3838         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3839         * c-typeprint.c (c_type_print_base_struct_union)
3840         (c_type_print_base_1): Use metadata style.
3841         * breakpoint.c (watchpoint_value_print)
3842         (print_one_breakpoint_location): Use metadata style.
3843         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3844         style.
3845         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3846         style.
3847         * ada-valprint.c (val_print_packed_array_elements, printstr)
3848         (print_field_values, ada_val_print_ref, ada_val_print): Use
3849         metadata style.
3850         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3851         style.
3852         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3853         style.
3854         * ada-lang.c (user_select_syms): Use metadata style.
3855
3856 2019-10-01  Tom Tromey  <tom@tromey.com>
3857
3858         * cli/cli-cmds.c (pwd_command): Style output.
3859
3860 2019-10-01  Pedro Alves  <palves@redhat.com>
3861             Tom Tromey  <tom@tromey.com>
3862
3863         * symtab.c (print_symbol_info): Use %ps.
3864         (print_msymbol_info): Use %ps.
3865         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3866         * printcmd.c (print_variable_and_value): Use %ps.
3867         * macrocmd.c (show_pp_source_pos): Use %ps.
3868         * infrun.c (print_exited_reason): Use ui_out::message.
3869         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3870         (describe_other_breakpoints): Use ui_out::message and new
3871         formats.
3872         (say_where): Use new formats.
3873         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3874         and new formats.
3875
3876 2019-10-01  Pedro Alves  <palves@redhat.com>
3877             Tom Tromey  <tom@tromey.com>
3878
3879         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3880         (test_gdb_formats): New function.
3881         (run_tests): Call it.
3882         (test_format_specifier): Update.
3883         * utils.h (fputs_filtered): Update comment.
3884         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3885         (fputs_styled_unfiltered): Declare.
3886         * utils.c (fputs_styled_unfiltered): New function.
3887         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3888         (vfprintf_filtered): Update.
3889         (vfprintf_unfiltered, vprintf_filtered): Update.
3890         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3891         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3892         disallow_ui_out_field>: New constants.
3893         (enum class field_kind): New.
3894         (struct base_field_s, struct signed_field_s): New.
3895         (signed_field): New function.
3896         (struct string_field_s): New.
3897         (string_field): New function.
3898         (struct styled_string_s): New.
3899         (styled_string): New function.
3900         (class ui_out) <message>: Add comment.
3901         <vmessage, call_do_message>: New methods.
3902         <do_message>: Add style parameter.
3903         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3904         methods.
3905         (ui_out::message): Rewrite.
3906         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3907         parameter.
3908         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3909         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3910         gdb_extensions parameter.
3911         (class format_piece): Add parameter to constructor.
3912         (n_int_args): New field.
3913         * gdbsupport/format.c (format_pieces::format_pieces): Add
3914         gdb_extensions parameter.  Handle '*'.
3915         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3916         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3917         vfprintf_styled_no_gdbfmt.
3918         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3919         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3920         unfiltered output.
3921         * ui-style.h (struct ui_file_style) <ptr>: New method.
3922
3923 2019-10-01  Tom Tromey  <tom@tromey.com>
3924
3925         * unittests/format_pieces-selftests.c: Update.  Add final format.
3926         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3927         empty literal pieces.
3928
3929 2019-10-01  Tom Tromey  <tom@tromey.com>
3930
3931         * ui-out.h (enum class ui_out_style_kind): Remove.
3932         (class ui_out) <field_string, field_stsream, do_field_string>:
3933         Change type of "style".
3934         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
3935         (ui_out::field_string): Update.
3936         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
3937         of "style".
3938         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
3939         * tracepoint.c (print_one_static_tracepoint_marker): Update.
3940         * stack.c (print_frame_arg, print_frame_info, print_frame):
3941         Update.
3942         * source.c (print_source_lines_base): Update.
3943         * solib.c (info_sharedlibrary_command): Update.
3944         * skip.c (info_skip_command): Update.
3945         * record-btrace.c (btrace_call_history_src_line)
3946         (btrace_call_history): Update.
3947         * python/py-framefilter.c (py_print_frame): Update.
3948         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
3949         "style".
3950         * mi/mi-out.c (mi_ui_out::do_table_header)
3951         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
3952         (mi_ui_out::do_field_string): Update.
3953         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
3954         Update.
3955         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
3956         "style".
3957         * cli-out.c (cli_ui_out::do_table_header)
3958         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
3959         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
3960         (cli_ui_out::do_field_fmt): Update.
3961         * breakpoint.c (print_breakpoint_location): Update.
3962         (update_static_tracepoint): Update.
3963
3964 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
3965
3966         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
3967         conversion of gdb_datadir.
3968         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
3969         remove not needed c_str ().
3970
3971 2019-09-30  Ali Tamur <tamur@google.com>
3972
3973         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
3974         (dwarf2_string_attr): Likewise.
3975
3976 2019-09-30  Ali Tamur <tamur@google.com>
3977
3978         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
3979         (process_full_type_unit): Likewise.
3980         (dump_die_shallow): Likewise.
3981         (cu_debug_loc_section): Likewise.
3982
3983 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
3984
3985         * minsyms.c (compare_minimal_symbols): Rename to...
3986         (minimal_symbol_is_less_than): ...this, and adjust to STL
3987         conventions (return bool, take arguments as references)
3988         (minimal_symbol_reader::install): Call std::sort instead
3989         of qsort.
3990
3991 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
3992
3993         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
3994         hash and why.
3995         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
3996         msymbol_hash, msymbol_demangled_hash>: Improve comments.
3997
3998 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
3999
4000         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4001         * psympriv.h (add_psymbol_to_list): Move comment here and update
4002         it.
4003
4004 2019-09-29  Tom de Vries  <tdevries@suse.de>
4005
4006         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4007         Use $tmpdir/$(basename "$output_file").dwz instead of
4008         "${output_file}.dwz".
4009
4010 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4011
4012         PR gdb/25045
4013         * hppa-linux-nat.c: Include gdbarch.h.
4014
4015 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4016
4017         * blockframe.c (find_pc_partial_function): Change return type to bool.
4018         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4019         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4020         (stub_gnu_ifunc_resolve_name): Likewise.
4021         * symtab.c (compare_filenames_for_search): Likewise.
4022         (compare_glob_filenames_for_search): Likewise.
4023         (matching_obj_sections): Likewise.
4024         (symbol_matches_domain): Likewise.
4025         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4026         (find_line_pc): Change return type to bool.
4027         (find_line_pc_range): Likewise.
4028         (producer_is_realview): Likewise.
4029         * symtab.h (symbol_matches_domain): Likewise.
4030         (find_pc_partial_function): Likewise.
4031         (find_pc_line_pc_range): Likewise.
4032         (in_gnu_ifunc_stub): Likewise.
4033         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4034         (find_line_pc): Likewise.
4035         (find_line_pc_range): Likewise.
4036         (matching_obj_sections): Likewise.
4037         (find_line_symtab): Change out parameter to bool.
4038         (producer_is_realview): Change return type to bool.
4039         (compare_filenames_for_search): Likewise.
4040         (compare_glob_filenames_for_search): Likewise.
4041
4042 2019-09-26  Tom Tromey  <tom@tromey.com>
4043
4044         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4045         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4046         * gdb_usleep.h: Remove.
4047         * gdb_usleep.c: Remove.
4048         * utils.c: Don't include gdb_usleep.h.
4049
4050 2019-09-26  Tom Tromey  <tromey@adacore.com>
4051
4052         * python/py-type.c (type_to_type_object): Call check_typedef
4053         for stub types.
4054
4055 2019-09-26  Tom Tromey  <tom@tromey.com>
4056
4057         * utils.h (initialize_utils): Don't declare.
4058         * top.c (gdb_init): Don't call initialize_utils.
4059         * utils.c (initialize_utils): Remove.  Move contents...
4060         (_initialize_utils): ... here.
4061
4062 2019-09-25  Tom Tromey  <tom@tromey.com>
4063
4064         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4065         * utils.h (make_hex_string): Don't declare.
4066         * utils.c (make_hex_string): Remove.
4067
4068 2019-09-24  Tom de Vries  <tdevries@suse.de>
4069
4070         PR gdb/23815
4071         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4072         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4073
4074 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4075
4076         * NEWS: Mention new simulator port for PRU.
4077
4078 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4079
4080         * ada-exp.y (write_object_remaining): Update.
4081         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4082         and eliminate the static buffer.
4083         (ada_decode_symbol): Update.
4084         (ada_la_decode): Update.
4085         (ada_sniff_from_mangled_name): Update.
4086         (is_valid_name_for_wild_match): Update.
4087         (ada_lookup_name_info::matches): Update and simplify.
4088         (name_matches_regex): Update.
4089         (ada_add_global_exceptions): Update.
4090         * ada-lang.h (ada_decode): Update signature.
4091         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4092         * dwarf-index-write.c (debug_names::insert): Update.
4093
4094 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4095
4096         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4097         formatting.
4098
4099 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4100
4101         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4102         Change "nonzero" to "true" in documentation.
4103
4104 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4105
4106         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4107         (_initialize_darwin_solib): Don't set
4108         darwin_so_ops.lookup_lib_global_symbol.
4109         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4110         set_gdbarch_iterate_over_objfiles_in_search_order.
4111         (elf_lookup_lib_symbol): Rename to...
4112         (svr4_iterate_over_objfiles_in_search_order): this, and update
4113         to iterate semantics.
4114         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4115         * solib.c (solib_global_lookup): Remove.
4116         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4117         (solib_global_lookup): Remove.
4118         * symtab.c (lookup_global_or_static_symbol): Remove call to
4119         solib_global_lookup.
4120
4121 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4122
4123         * NEWS: Move entries about default MI version now being
4124         version 3, and about the GDB/MI fix for multi-location
4125         breakpoints to the "since GDB 8.3" section.
4126
4127 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4128
4129         GDB 8.3.1 released.
4130
4131 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4132
4133         * NEWS: Mention that Cell/B.E. debugging support was removed.
4134         * MAINTAINERS: Remove spu target.
4135
4136         * config/djgpp/fnchange.lst: Remove entries for removed files.
4137
4138         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4139         spu-multiarch.o, and spu-tdep.o.
4140         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4141         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4142         spu-multiarch.c, and spu-tdep.c.
4143         * spu-linux-nat.c: Remove file.
4144         * spu-multiarch.c: Remove file.
4145         * spu-tdep.c: Remove file.
4146         * spu-tdep.h: Remove file.
4147         * solib-spu.c: Remove file.
4148         * solib-spu.h: Remove file.
4149
4150         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4151         * configure.nat (spu-linux): Remove.
4152         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4153         solib-multiarch.o from gdb_target_obs.
4154         (spu*-*-*): Remove.
4155
4156         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4157         feature flag.
4158         (ppc_linux_no_features): Update.
4159         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4160         Cell/B.E. support.
4161         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4162         (tdesc_powerpc_cell64l): Likewise.
4163         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4164         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4165         Cell/B.E. support.
4166         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4167         Do not include "features/rs6000/powerpc-cell32l.c" or
4168         "features/rs6000/powerpc-cell64l.c".
4169         (ppc_linux_spu_section): Remove.
4170         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4171         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4172         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4173         (ppc_linux_spe_context_lookup): Remove.
4174         (ppc_linux_spe_context_inferior_created): Remove.
4175         (ppc_linux_spe_context_solib_loaded): Remove.
4176         (ppc_linux_spe_context_solib_unloaded): Remove.
4177         (ppc_linux_spe_context): Remove.
4178         (struct ppu2spu_cache): Remove.
4179         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4180         (struct ppu2spu_data): Remove.
4181         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4182         ppu2spu_unwind): Remove.
4183         (ppc_linux_init_abi): Remove Cell/B.E. support.
4184         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4185
4186         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4187         (rs6000/powerpc-cell64l-expedite): Likewise
4188         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4189         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4190         rs6000/powerpc-cell64l.xml.
4191         * features/rs6000/powerpc-cell32l.xml: Remove.
4192         * features/rs6000/powerpc-cell64l.xml: Likewise.
4193         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4194         * features/rs6000/powerpc-cell64l.c: Likewise.
4195         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4196         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4197         * regformats/reg-spu.dat: Remove.
4198
4199         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4200         * corelow.c (struct spuid_list): Remove.
4201         (add_to_spuid_list): Remove.
4202         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4203         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4204         (remote_protocol_features): Remove associated entries.
4205         (_initialize_remote): No longer initialize them.
4206         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4207         * linux-nat.c (SPUFS_MAGIC): Remove.
4208         (linux_proc_xfer_spu): Remove.
4209         (spu_enumerate_spu_ids): Remove.
4210         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4211         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4212         (linux_make_corefile_notes): No longer call it.
4213
4214         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4215         (cooked_write_test): Likewise.
4216
4217 2019-09-20  Tom Tromey  <tom@tromey.com>
4218
4219         * NEWS: Mention case-sensitivity of TUI commands.
4220         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4221         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4222         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4223
4224 2019-09-20  Tom Tromey  <tom@tromey.com>
4225
4226         * tui/tui-source.c (tui_source_window::set_contents): Use
4227         make_unique_xstrdup.
4228         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4229         make_unique_xstrdup.
4230
4231 2019-09-20  Tom Tromey  <tom@tromey.com>
4232
4233         * tui/tui-data.c: Remove separator comments.
4234         * tui/tui-layout.c: Remove separator comments.
4235         * tui/tui-win.c: Remove separator comments.
4236         * tui/tui-wingeneral.c: Remove separator comments.
4237
4238 2019-09-20  Tom Tromey  <tom@tromey.com>
4239
4240         * tui/tui.h (strcat_to_buf): Don't declare.
4241         * tui/tui.c (strcat_to_buf): Remove.
4242
4243 2019-09-20  Tom Tromey  <tom@tromey.com>
4244
4245         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4246         from "fullname".
4247         * tui/tui-source.c (tui_source_window::set_contents)
4248         (tui_source_window::location_matches_p)
4249         (tui_source_window::maybe_update): Update.
4250
4251 2019-09-20  Tom Tromey  <tom@tromey.com>
4252
4253         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4254         Update.
4255         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4256         prefix.
4257         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4258         (tui_data_window::line_from_reg_element_no)
4259         (tui_data_window::first_reg_element_no_inline)
4260         (tui_data_window::show_registers)
4261         (tui_data_window::show_register_group)
4262         (tui_data_window::display_registers_from)
4263         (tui_data_window::display_registers_from_line)
4264         (tui_data_window::first_data_item_displayed)
4265         (tui_data_window::delete_data_content_windows)
4266         (tui_data_window::erase_data_content)
4267         (tui_data_window::do_scroll_vertical)
4268         (tui_data_window::refresh_window)
4269         (tui_data_window::check_register_values): Update.
4270
4271 2019-09-20  Tom Tromey  <tom@tromey.com>
4272
4273         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4274         (struct tui_locator_window) <full_name, proc_name>: Now
4275         std::string.
4276         * tui/tui-stack.c (tui_locator_window::make_status_line)
4277         (tui_locator_window::set_locator_fullname)
4278         (tui_locator_window::set_locator_info): Update.
4279         * tui/tui-source.c (tui_source_window::set_contents)
4280         (tui_source_window::showing_source_p): Update.
4281
4282 2019-09-20  Tom Tromey  <tom@tromey.com>
4283
4284         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4285         Don't call tui_locator_win_info_ptr.
4286
4287 2019-09-20  Tom Tromey  <tom@tromey.com>
4288
4289         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4290
4291 2019-09-20  Tom Tromey  <tom@tromey.com>
4292
4293         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4294         height for locator.
4295         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4296         * tui/tui-layout.c (show_source_disasm_command, show_data)
4297         (show_source_or_disasm_and_command): Use 1 as height for locator.
4298
4299 2019-09-20  Tom Tromey  <tom@tromey.com>
4300
4301         * tui/tui.c (tui_enable): Update.
4302         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4303         Update.
4304         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4305         Update.
4306         * tui/tui-data.c (win_resized): Now bool.
4307         (tui_win_resized): Return bool.
4308         (tui_set_win_resized_to): Accept a bool.
4309
4310 2019-09-20  Tom Tromey  <tom@tromey.com>
4311
4312         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4313         Change type of "refresh_values_only".
4314         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4315         type of "refresh_values_only".
4316
4317 2019-09-20  Tom Tromey  <tom@tromey.com>
4318
4319         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4320         std::string.
4321         (tui_disassemble): Add "pos" parameter.
4322         (tui_disasm_window::set_contents): Simplify.
4323
4324 2019-09-20  Tom Tromey  <tom@tromey.com>
4325
4326         * tui/tui-winsource.h (struct tui_source_window_base)
4327         <show_source_content>: Now private.
4328         * tui/tui-winsource.c
4329         (tui_source_window_base::show_source_content): Don't handle empty
4330         content case.
4331
4332 2019-09-20  Tom Tromey  <tom@tromey.com>
4333
4334         * tui/tui-layout.c (show_source_disasm_command)
4335         (show_source_or_disasm_and_command): Don't call
4336         show_source_content.
4337
4338 2019-09-20  Tom Tromey  <tom@tromey.com>
4339
4340         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4341         Declare.
4342         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4343         from tui_make_status_line.
4344         (tui_locator_window::rerender): Update.
4345
4346 2019-09-20  Tom Tromey  <tom@tromey.com>
4347
4348         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4349         (tui_locator_window::rerender): Update.
4350
4351 2019-09-20  Tom Tromey  <tom@tromey.com>
4352
4353         * tui/tui-winsource.h (struct tui_source_window_base)
4354         <~tui_source_window_base>: Don't declare.
4355         <fullname>: Remove.
4356         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4357         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4358         member.
4359         * tui/tui-source.c (tui_source_window::set_contents): Update.
4360         (tui_source_window::location_matches_p)
4361         (tui_source_window::maybe_update): Update.
4362
4363 2019-09-20  Tom Tromey  <tom@tromey.com>
4364
4365         * tui/tui-winsource.h (~tui_source_element): Remove.
4366         (tui_source_element): Update.
4367         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4368         * tui/tui-winsource.c (tui_show_source_line): Update.
4369         * tui/tui-source.c (tui_source_window::set_contents): Update.
4370         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4371
4372 2019-09-20  Tom Tromey  <tom@tromey.com>
4373
4374         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4375         declare.
4376         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4377         tui_clear_source_windows_detail.
4378         * tui/tui-winsource.h (struct tui_source_window_base)
4379         <clear_detail>: Don't declare.
4380         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4381         Remove.
4382         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4383
4384 2019-09-20  Tom Tromey  <tromey@adacore.com>
4385
4386         PR ada/24919:
4387         * block.c (contained_in): Fix final return value.
4388
4389 2019-09-20  Alan Modra  <amodra@gmail.com>
4390
4391         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4392         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4393         (read_indirect_string_from_dwz): Use bfd accessor.
4394         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4395         * machoread.c (macho_symfile_read_all_oso): Likewise.
4396         * solib.c (solib_bfd_open): Likewise.
4397
4398 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4399
4400         * eval.c: Move declaration of overload_resolution to...
4401         * value.h: ...here.
4402
4403 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4404
4405         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4406         * arm-linux-tdep.c: Likewise.
4407         * arm-nbsd-nat.c: Likewise.
4408         * arm-tdep.h: Declare arm_apcs_32.
4409         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4410
4411 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4412
4413         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4414         * dwarf2read.h: Declare dwarf_always_disassemble.
4415
4416 2019-09-19  Tom de Vries  <tdevries@suse.de>
4417
4418         PR gdb/25009
4419         * source-cache.c (source_cache::ensure): Catch exception thrown during
4420         construction of the highlighter.
4421
4422 2019-09-18  Alan Modra  <amodra@gmail.com>
4423
4424         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4425         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4426         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4427         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4428         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4429         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4430         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4431         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4432         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4433         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4434         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4435         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4436         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4437         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4438         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4439         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4440         * mi/mi-interp.c: Update throughout for bfd section macro and
4441         function changes.
4442         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4443         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4444
4445 2019-09-18  Tom Tromey  <tom@tromey.com>
4446
4447         * NEWS: Add entry.
4448         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4449         call rl_initialize.
4450         (tui_enable): Do not call rl_initialize.
4451
4452 2019-09-18  Christian Groessler  <chris@groessler.org>
4453
4454         * alpha-linux-nat.c: Include gdbarch.h.
4455
4456 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4457
4458         * ui-file.c: Include cli/cli-style.h.
4459         (term_cli_styling): Remove cli_styling declaration.
4460
4461 2019-09-18  Alan Modra  <amodra@gmail.com>
4462
4463         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4464         to bfd_asymbol_section.
4465
4466 2019-09-18  Alan Modra  <amodra@gmail.com>
4467
4468         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4469         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4470         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4471
4472 2019-09-18  Alan Modra  <amodra@gmail.com>
4473
4474         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4475         * spu-linux-nat.c (spu_bfd_open): Likewise.
4476
4477 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4478
4479         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4480         to bool to match definition in dwarf2read.c.
4481
4482 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4483
4484         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4485         (print_signatures): Likewise.
4486         (trust_pad_over_xvs): Likewise.
4487         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4488         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4489         * arm-linux-nat.c (arm_apcs_32): Likewise.
4490         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4491         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4492         * arm-tdep.c (arm_debug): Likewise.
4493         (arm_apcs_32): Likewise.
4494         * auto-load.c (debug_auto_load): Likewise.
4495         (auto_load_gdb_scripts): Likewise.
4496         (global_auto_load): Likewise.
4497         (auto_load_local_gdbinit): Likewise.
4498         (auto_load_local_gdbinit_loaded): Likewise.
4499         * auto-load.h (global_auto_load): Likewise.
4500         (auto_load_local_gdbinit): Likewise.
4501         (auto_load_local_gdbinit_loaded): Likewise.
4502         * breakpoint.c (disconnected_dprintf): Likewise.
4503         (breakpoint_proceeded): Likewise.
4504         (automatic_hardware_breakpoints): Likewise.
4505         (always_inserted_mode): Likewise.
4506         (target_exact_watchpoints): Likewise.
4507         (_initialize_breakpoint): Update.
4508         * breakpoint.h (target_exact_watchpoints): Change to bool.
4509         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4510         * cli/cli-cmds.c (trace_commands): Likewise.
4511         * cli/cli-cmds.h (trace_commands): Likewise.
4512         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4513         to bool*.
4514         * cli/cli-logging.c (logging_overwrite): Change to bool.
4515         (logging_redirect): Likewise.
4516         (debug_redirect): Likewise.
4517         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4518         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4519         to bool.
4520         <boolean_option_def>: Update.
4521         (struct flag_option_def): Change default type of Context to bool
4522         from int.
4523         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4524         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4525         (get_setshow_command_value_string): Likewise.
4526         * cli/cli-style.c (cli_styling): Change to bool.
4527         (source_styling): Likewise.
4528         * cli/cli-style.h (source_styling): Likewise.
4529         (cli_styling): Likewise.
4530         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4531         to bool.
4532         * command.h (var_types): Update comment.
4533         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4534         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4535         bool.
4536         (debug_compile_cplus_scopes): Likewise.
4537         * compile/compile-internal.h (compile_debug): Likewise.
4538         * compile/compile.c (compile_debug): Likewise.
4539         (struct compile_options) <raw>: Likewise.
4540         * cp-support.c (catch_demangler_crashes): Likewise.
4541         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4542         (usr_cmd_cris_dwarf2_cfi): Likewise.
4543         * csky-tdep.c (csky_debug): Likewise.
4544         * darwin-nat.c (enable_mach_exceptions): Likewise.
4545         * dcache.c (dcache_enabled_p): Likewise.
4546         * defs.h (info_verbose): Likewise.
4547         * demangle.c (demangle): Likewise.
4548         (asm_demangle): Likewise.
4549         * dwarf-index-cache.c (debug_index_cache): Likewise.
4550         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4551         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4552         * dwarf2read.c (check_physname): Likewise.
4553         (use_deprecated_index_sections): Likewise.
4554         (dwarf_always_disassemble): Likewise.
4555         * eval.c (overload_resolution): Likewise.
4556         * event-top.c (set_editing_cmd_var): Likewise.
4557         (exec_done_display_p): Likewise.
4558         * event-top.h (set_editing_cmd_var): Likewise.
4559         (exec_done_display_p): Likewise.
4560         * exec.c (write_files): Likewise.
4561         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4562         (debug_fbsd_nat): Likewise.
4563         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4564         Likewise.
4565         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4566         <backtrace_past_entry> Likewise.
4567         * gdb-demangle.h (demangle): Likewise.
4568         (asm_demangle): Likewise.
4569         * gdb_bfd.c (bfd_sharing): Likewise.
4570         * gdbcore.h (write_files): Likewise.
4571         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4572         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4573         * gdbthread.h (print_thread_events): Likewise.
4574         * gdbtypes.c (opaque_type_resolution): Likewise.
4575         (strict_type_checking): Likewise.
4576         * gnu-nat.c (gnu_debug_flag): Likewise.
4577         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4578         * guile/scm-param.c (pascm_variable): Add boolval.
4579         (add_setshow_generic): Update.
4580         (pascm_param_value): Update.
4581         (pascm_set_param_value_x): Update.
4582         * hppa-tdep.c (hppa_debug): Change to bool..
4583         * infcall.c (may_call_functions_p): Likewise.
4584         (coerce_float_to_double_p): Likewise.
4585         (unwind_on_signal_p): Likewise.
4586         (unwind_on_terminating_exception_p): Likewise.
4587         * infcmd.c (startup_with_shell): Likewise.
4588         * inferior.c (print_inferior_events): Likewise.
4589         * inferior.h (startup_with_shell): Likewise.
4590         (print_inferior_events): Likewise.
4591         * infrun.c (step_stop_if_no_debug): Likewise.
4592         (detach_fork): Likewise.
4593         (debug_displaced): Likewise.
4594         (disable_randomization): Likewise.
4595         (non_stop): Likewise.
4596         (non_stop_1): Likewise.
4597         (observer_mode): Likewise.
4598         (observer_mode_1): Likewise.
4599         (set_observer_mode): Update.
4600         (sched_multi): Change to bool.
4601         * infrun.h (debug_displaced): Likewise.
4602         (sched_multi): Likewise.
4603         (step_stop_if_no_debug): Likewise.
4604         (non_stop): Likewise.
4605         (disable_randomization): Likewise.
4606         * linux-tdep.c (use_coredump_filter): Likewise.
4607         (dump_excluded_mappings): Likewise.
4608         * linux-thread-db.c (auto_load_thread_db): Likewise.
4609         (check_thread_db_on_load): Likewise.
4610         * main.c (captured_main_1): Update.
4611         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4612         xx2_opt, boolean_opt>: Change to bool.
4613         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4614         * maint.c (maintenance_profile_p): Likewise.
4615         (per_command_time): Likewise.
4616         (per_command_space): Likewise.
4617         (per_command_symtab): Likewise.
4618         * memattr.c (inaccessible_by_default): Likewise.
4619         * mi/mi-main.c (mi_async): Likewise.
4620         (mi_async_1): Likewise.
4621         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4622         * nat/fork-inferior.h (startup_with_shell): Likewise.
4623         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4624         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4625         * nios2-tdep.c (nios2_debug): Likewise.
4626         * or1k-tdep.c (or1k_debug): Likewise.
4627         * parse.c (parser_debug): Likewise.
4628         * parser-defs.h (parser_debug): Likewise.
4629         * printcmd.c (print_symbol_filename): Likewise.
4630         * proc-api.c (procfs_trace): Likewise.
4631         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4632         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4633         (set_parameter_value): Update.
4634         (add_setshow_generic): Update.
4635         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4636         to bool*.
4637         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4638         int*.
4639         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4640         * record-btrace.c (record_btrace_target::store_registers): Update.
4641         * record-full.c (record_full_memory_query): Change to bool.
4642         (record_full_stop_at_limit): Likewise.
4643         * record-full.h (record_full_memory_query): Likewise.
4644         * remote-notif.c (notif_debug): Likewise.
4645         * remote-notif.h (notif_debug): Likewise.
4646         * remote.c (use_range_stepping): Likewise.
4647         (interrupt_on_connect): Likewise.
4648         (remote_break): Likewise.
4649         * ser-tcp.c (tcp_auto_retry): Likewise.
4650         * ser-unix.c (serial_hwflow): Likewise.
4651         * skip.c (debug_skip): Likewise.
4652         * solib-aix.c (solib_aix_debug): Likewise.
4653         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4654         (spu_auto_flush_cache_p): Likewise.
4655         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4656         Likewise.
4657         (struct info_print_options) <quiet>: Likewise.
4658         * symfile-debug.c (debug_symfile): Likewise.
4659         * symfile.c (auto_solib_add): Likewise.
4660         (separate_debug_file_debug): Likewise.
4661         * symfile.h (auto_solib_add): Likewise.
4662         (separate_debug_file_debug): Likewise.
4663         * symtab.c (basenames_may_differ): Likewise.
4664         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4665         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4666         (struct info_types_options) <quiet>: Likewise.
4667         * symtab.h (demangle): Likewise.
4668         (basenames_may_differ): Likewise.
4669         * target-dcache.c (stack_cache_enabled_1): Likewise.
4670         (code_cache_enabled_1): Likewise.
4671         * target.c (trust_readonly): Likewise.
4672         (may_write_registers): Likewise.
4673         (may_write_memory): Likewise.
4674         (may_insert_breakpoints): Likewise.
4675         (may_insert_tracepoints): Likewise.
4676         (may_insert_fast_tracepoints): Likewise.
4677         (may_stop): Likewise.
4678         (auto_connect_native_target): Likewise.
4679         (target_stop_and_wait): Update.
4680         (target_async_permitted): Change to bool.
4681         (target_async_permitted_1): Likewise.
4682         (may_write_registers_1): Likewise.
4683         (may_write_memory_1): Likewise.
4684         (may_insert_breakpoints_1): Likewise.
4685         (may_insert_tracepoints_1): Likewise.
4686         (may_insert_fast_tracepoints_1): Likewise.
4687         (may_stop_1): Likewise.
4688         * target.h (target_async_permitted): Likewise.
4689         (may_write_registers): Likewise.
4690         (may_write_memory): Likewise.
4691         (may_insert_breakpoints): Likewise.
4692         (may_insert_tracepoints): Likewise.
4693         (may_insert_fast_tracepoints): Likewise.
4694         (may_stop): Likewise.
4695         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4696         (make_thread_apply_all_options_def_group): Change argument from int*
4697         to bool*.
4698         (thread_apply_all_command): Update.
4699         (print_thread_events): Change to bool.
4700         * top.c (confirm): Likewise.
4701         (command_editing_p): Likewise.
4702         (history_expansion_p): Likewise.
4703         (write_history_p): Likewise.
4704         (info_verbose): Likewise.
4705         * top.h (confirm): Likewise.
4706         (history_expansion_p): Likewise.
4707         * tracepoint.c (disconnected_tracing): Likewise.
4708         (circular_trace_buffer): Likewise.
4709         * typeprint.c (print_methods): Likewise.
4710         (print_typedefs): Likewise.
4711         * utils.c (debug_timestamp): Likewise.
4712         (sevenbit_strings): Likewise.
4713         (pagination_enabled): Likewise.
4714         * utils.h (sevenbit_strings): Likewise.
4715         (pagination_enabled): Likewise.
4716         * valops.c (overload_resolution): Likewise.
4717         * valprint.h (struct value_print_options) <prettyformat_arrays,
4718         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4719         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4720         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4721         Likewise.
4722         * windows-nat.c (new_console): Likewise.
4723         (cygwin_exceptions): Likewise.
4724         (new_group): Likewise.
4725         (debug_exec): Likewise.
4726         (debug_events): Likewise.
4727         (debug_memory): Likewise.
4728         (debug_exceptions): Likewise.
4729         (useshell): Likewise.
4730         * windows-tdep.c (maint_display_all_tib): Likewise.
4731         * xml-support.c (debug_xml): Likewise.
4732
4733 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4734
4735         * source.c (prepare_path_for_appending): New function.
4736         (openp): Make use of new function.
4737         (find_and_open_source): Search for the compilation directory and
4738         source file as a relative path beneath the directory search path.
4739
4740 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4741
4742         * source-cache.c (source_cache::get_line_charpos): Catch
4743         exceptions and return false, this matches the behaviour documented
4744         in the header file.
4745
4746 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4747
4748         * ada-tasks.c (info_task): Remove quoting of the task's name.
4749
4750 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4751
4752         * symfile.c (auto_solib_add): Replace comment with a reference
4753         to the header file.
4754
4755 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4756
4757         * NEWS: Mention that gdb can now be compiled with Python 3
4758         on Windows.
4759
4760 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4761
4762         * maint.c (maint_print_section_data::maint_print_section_data):
4763         Force use of 'float log10 (float)' by casting the argument to
4764         float.
4765
4766 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4767
4768         * maint.c: Add 'cmath' include.
4769         (struct maint_print_section_data): New structure.
4770         (print_section_index): New function.
4771         (print_bfd_section_info): Add header comment, small whitespace
4772         cleanup, and update to call new print_section_index function.
4773         (print_objfile_section_info): Likewise.
4774         (maint_obj_section_from_bfd_section): New function.
4775         (print_bfd_section_info_maybe_relocated): New function.
4776         (maintenance_info_sections): Add header comment, always use
4777         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4778
4779 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4780
4781         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4782         inner scope, add check that the objfile has psymtabs before
4783         checking psymtabs_addrmap.
4784         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4785
4786 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4787
4788         * NEWS: Announce that Ada task names are now shown at more places,
4789         and between quotes (except in info task output).
4790         * gdb/ada-tasks.c (task_to_str): New function.
4791         (display_current_task_id): Call task_to_str.
4792         (task_command_1): Likewise.
4793         (print_ada_task_info): In non-mi mode, Properly align headers and data
4794         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4795
4796 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4797
4798         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4799         prstatus.pr_lwp.pr_info instead of making it up.
4800
4801 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4802
4803         * auto-load.c (auto_load_expand_dir_vars): Update.
4804         * defs.h (gdb_datadir): Change to std::string.
4805         (python_libdir): Likewise.
4806         (relocate_gdb_directory): Change return type to std::string.
4807         * guile/guile.c (gdbscm_data_directory): Update.
4808         (initialize_scheme_side): Update.
4809         * jit.c (jit_reader_dir): Change to std::string.
4810         (jit_reader_load_command): Update.
4811         * main.c (gdb_datadir): Change to std::string.
4812         (python_libdir): Likewise.
4813         (set_gdb_data_directory): Update.
4814         (relocate_path): Change to return std::string.
4815         (relocate_gdb_directory): Change to return std::string.
4816         (relocate_gdbinit_path_maybe_in_datadir): Update.
4817         (captured_main_1): Update.
4818         * python/python.c (do_start_initialization): Update.
4819         * top.c (show_gdb_datadir): Update.
4820         * xml-syscall.c (xml_init_syscalls_info): Update.
4821         (init_syscalls_info): Update.
4822
4823 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4824
4825         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4826         out of get_init_files.
4827         (get_init_files): Update.
4828
4829 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4830
4831         * main.c (get_init_files): Change to use std::string.
4832         (captured_main_1): Update.
4833         (print_gdb_help): Update.
4834
4835 2019-09-11  Ali Tamur  <tamur@google.com>
4836
4837         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4838         implementation.
4839
4840 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4841
4842         * dbxread.c (read_dbx_symtab): Update.
4843         * dwarf2read.c (load_partial_dies): Update.
4844         * mdebugread.c (parse_partial_symbols): Update.
4845         (handle_psymbol_enumerators): Update.
4846         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4847         * psymtab.c (add_psymbol_to_bcache): Likewise.
4848         (add_psymbol_to_list): Likewise.
4849         * symtab.c (symbol_set_names): Likewise.
4850         * symtab.h (symbol_set_names): Likewise.
4851         * xcoffread.c (scan_xcoff_symtab): Update.
4852
4853 2019-09-11  Tom Tromey  <tom@tromey.com>
4854
4855         * symfile-mem.c (symbol_file_add_from_memory): Use
4856         bfd_set_filename.
4857         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4858         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4859
4860 2019-09-10  Tom Tromey  <tromey@adacore.com>
4861
4862         * dwarf-index-write.c (write_psymbols): Extend error message.
4863         (debug_names::insert): Add Ada code.
4864         (debug_names::write_psymbols): Remove Ada check.
4865         (debug_names) <m_string_obstack>: New member.
4866         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4867         (gdb_index_symbol_name_matcher::matches): Remove.
4868         (mapped_index_base::find_name_components_bounds): Add "lang"
4869         parameter.
4870         (mapped_index_base::build_name_components): Also split names
4871         according to Ada syntax.
4872         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4873         type of "match_callback".
4874         (check_match, check_find_bounds_finds)
4875         (dw2_expand_symtabs_matching): Update.
4876         (dw2_debug_names_iterator): Add new constructor.
4877         (dw2_debug_names_map_matching_symbols): New function.
4878         (dw2_debug_names_expand_symtabs_matching): Update.
4879         (dwarf2_debug_names_functions): Use
4880         dw2_debug_names_map_matching_symbols.
4881
4882 2019-09-10  Tom Tromey  <tromey@adacore.com>
4883
4884         * dwarf2read.c (dw2_get_file_names_reader): Add the
4885         CU's file name to the results.
4886
4887 2019-09-10  Tom Tromey  <tromey@adacore.com>
4888
4889         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4890         map_matching_symbols.  Update.
4891         * dwarf2read.c (dw2_map_matching_symbols): Update.
4892         * psymtab.c (match_partial_symbol): Change type; update.
4893         (psym_map_matching_symbols): Likewise.
4894         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4895         type; update.
4896         * symfile.h (struct quick_symbol_functions)
4897         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4898         Remove "match".
4899
4900 2019-09-10  Tom Tromey  <tromey@adacore.com>
4901
4902         * psymtab.c (map_block): Remove.
4903         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4904         * symtab.c (iterate_over_symbols_terminated): New function.
4905         * symtab.c (iterate_over_symbols_terminated): Declare.
4906
4907 2019-09-10  Tom Tromey  <tromey@adacore.com>
4908
4909         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4910         * language.h (struct language_defn) <la_iterate_over_symbols>:
4911         Return bool.
4912         * symtab.c (iterate_over_symbols): Return bool.
4913         * symtab.h (iterate_over_symbols): Return bool.
4914
4915 2019-09-10  Tom Tromey  <tromey@adacore.com>
4916
4917         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4918         (add_nonlocal_symbols): Update.
4919         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4920         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4921         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4922         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4923         Change type of "callback".  Remove "data".
4924
4925
4926 2019-09-09  Ali Tamur  <tamur@google.com>
4927
4928         * dwarf2read.c (comp_unit_head): Update comment.
4929         (dwarf2_dwo_name): New function declaration.
4930         (dwarf_unit_type_name): New function declaration.
4931         (read_comp_unit_head): Add support for new compilation units,
4932         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4933         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
4934         (currently named as "signature") in their header. Also clarify error
4935         messages.
4936         (lookup_dwo_id): New function. Returns the dwo id of the given
4937         compile unit.
4938         (lookup_dwo_unit): Use the new lookup_dwo_id function.
4939         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
4940         functions.
4941         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
4942         (dwarf2_dwo_name): Get the dwo name if present.
4943         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
4944         purposes.
4945
4946 2019-09-09  Tom Tromey  <tom@tromey.com>
4947
4948         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
4949
4950 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4951
4952         * python/python.c (do_start_initialization): Make progname_copy static,
4953         to avoid a leak report.
4954
4955 2019-09-08  Tom Tromey  <tom@tromey.com>
4956
4957         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
4958
4959 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
4960
4961         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
4962         Change type to gdb::optional<block_enum>.
4963         (dw2_symtab_iter_init): Change block_index parameter type
4964         to gdb::optional<block_enum>.
4965         (dw2_lookup_symbol): Change block_index parameter
4966         type to block_enum.c
4967         (dw2_debug_names_lookup_symbol): Likewise.
4968         * psymtab.c (psym_lookup_symbol): Likewise.
4969         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
4970         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
4971         Likewise.
4972
4973 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
4974
4975         * defs.h (relocate_gdb_directory): Change int to bool in
4976         signature and rename flag to relocatable.
4977         * main.c (relocate_path): Likewise.
4978         (relocate_gdb_directory): Likewise.
4979
4980 2019-09-06  Alan Modra  <amodra@gmail.com>
4981
4982         * coffread.c (coff_symfile_read): Constify filename variable.
4983         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
4984         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
4985         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
4986         * solib.c (reload_shared_libraries_1): Likewise.
4987         * symfile.c (reread_symbols): Likewise.
4988         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
4989         * solib-darwin.c (darwin_bfd_open): Likewise.
4990         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
4991
4992 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
4993
4994         * psymtab.c (print_partial_symbols): Handle missing domain_enum
4995         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
4996
4997 2019-09-03  Tom Tromey  <tromey@adacore.com>
4998
4999         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5000         types.
5001         (has_negatives): Unbias a range type bound.
5002         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5003         * gdbtypes.c (operator==): Handle new field.
5004         (create_range_type): Add "bias" parameter.
5005         (create_static_range_type, resolve_dynamic_range): Update.
5006         * gdbtypes.h (struct range_bounds) <bias>: New member.
5007         (create_range_type): Add bias parameter.
5008         * printcmd.c (print_scalar_formatted): Unbias range types.
5009         * value.c (unpack_long): Unbias range types.
5010         (pack_long): Bias range types.
5011
5012 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5013
5014         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5015         probe arguments.
5016
5017 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5018
5019         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5020         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5021         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5022         (compile_probe_arg): Likewise.
5023         * probe.h (get_argument_count): Likewise.
5024         * solib-svr4.c (solib_event_probe_action): Likewise.
5025         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5026
5027 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5028
5029         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5030         code to here...
5031         (svr4_create_solib_event_breakpoints): ...from here.
5032
5033 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5034
5035         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5036         suffix from warning message.
5037
5038 2019-08-30  Tom Tromey  <tom@tromey.com>
5039
5040         * tui/tui-winsource.h (struct tui_source_window_base)
5041         <refresh_all>: Don't declare.
5042         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5043         Remove.
5044         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5045         tui_show_locator_content.
5046         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5047         declare.
5048         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5049         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5050         declare.
5051
5052 2019-08-30  Tom Tromey  <tom@tromey.com>
5053
5054         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5055
5056 2019-08-30  Tom Tromey  <tom@tromey.com>
5057
5058         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5059         Remove unnecessary forward declarations.
5060
5061 2019-08-30  Tom Tromey  <tom@tromey.com>
5062
5063         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5064         rerender.
5065         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5066         tui_show_locator_content.
5067
5068 2019-08-30  Tom Tromey  <tom@tromey.com>
5069
5070         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5071         (tui_locator_window::rerender): Rewrite using body of previous
5072         tui_show_locator_content.
5073
5074 2019-08-30  Tom Tromey  <tom@tromey.com>
5075
5076         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5077         set_locator_fullname>: New methods.
5078         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5079         Rename from tui_set_locator_fullname.
5080         (tui_locator_window::set_locator_info): Rename from
5081         tui_set_locator_info.  Return bool.
5082         (tui_update_locator_fullname, tui_show_frame_info): Update.
5083
5084 2019-08-30  Tom Tromey  <tom@tromey.com>
5085
5086         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5087
5088 2019-08-30  Tom Tromey  <tom@tromey.com>
5089
5090         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5091         call touchwin.
5092
5093 2019-08-30  Tom Tromey  <tom@tromey.com>
5094
5095         * tui/tui-wingeneral.c (box_win): Assume win_info and
5096         win_info->handle cannot be NULL.
5097
5098 2019-08-30  Tom Tromey  <tom@tromey.com>
5099
5100         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5101         refresh_window>: Declare.
5102         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5103         resize.
5104         (tui_data_item_window::rerender): Rename from
5105         tui_display_register.
5106         (tui_data_item_window::refresh_window): New method.
5107         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5108         no-op.
5109
5110 2019-08-30  Tom Tromey  <tom@tromey.com>
5111
5112         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5113         regs_column_count, current_group>: Move later.  Now private.
5114         <get_current_group>: New method.
5115         * tui/tui-regs.c (tui_reg_command): Update.
5116         * tui/tui-layout.c (tui_set_layout): Update.
5117
5118 2019-08-30  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5121         (tui_data_window::rerender): Don't call
5122         check_and_display_highlight_if_needed.
5123         (tui_data_window::refresh_all): Remove call to
5124         erase_data_content.
5125
5126 2019-08-30  Tom Tromey  <tom@tromey.com>
5127
5128         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5129         (tui_data_window::display_registers_from)
5130         (tui_data_window::display_reg_element_at_line)
5131         (tui_data_window::display_registers_from_line): Remove checks of
5132         "empty".
5133
5134 2019-08-30  Tom Tromey  <tom@tromey.com>
5135
5136         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5137         Don't declare.
5138         * tui/tui-regs.c (tui_data_window::show_registers): Call
5139         rerender.
5140         (tui_data_window::rerender): Rename from display_all_data.
5141         (tui_data_window::rerender): Remove old implementation.
5142
5143 2019-08-30  Tom Tromey  <tom@tromey.com>
5144
5145         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5146         text.
5147         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5148
5149 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5150             Sergio Durigan Junior  <sergiodj@redhat.com>
5151
5152         PR win32/24284
5153         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5154
5155 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5156
5157         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5158         when searching for types.
5159
5160 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5161
5162         * f-lang.c (f_language_defn): Use f_print_typedef.
5163         * f-lang.h (f_print_typedef): Declare.
5164         * f-typeprint.c (f_print_typedef): Define.
5165
5166 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5167
5168         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5169
5170 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5171
5172         * cli/cli-utils.c (info_print_options_defs): Delete.
5173         (make_info_print_options_def_group): Delete.
5174         (extract_info_print_options): Delete.
5175         (info_print_command_completer): Delete.
5176         (info_print_args_help): Add extra parameter, and optionally
5177         include text about -n flag.
5178         * cli/cli-utils.h (struct info_print_options): Delete.
5179         (extract_info_print_options): Delete declaration.
5180         (info_print_command_completer): Delete declaration.
5181         (info_print_args_help): Add extra parameter, extend header
5182         comment.
5183         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5184         search_symbols.
5185         * stack.c (struct info_print_options): New type.
5186         (info_print_options_defs): New file scoped variable.
5187         (make_info_print_options_def_group): New static function.
5188         (info_print_command_completer): New static function.
5189         (info_locals_command): Update to use new local functions.
5190         (info_args_command): Likewise.
5191         (_initialize_stack): Add extra parameter to calls to
5192         info_print_args_help.
5193         * symtab.c (search_symbols): Add extra parameter, use this to
5194         possibly excluse non-debug symbols.
5195         (symtab_symbol_info): Add extra parameter, which is passed on to
5196         search_symbols.
5197         (struct info_print_options): New type.
5198         (info_print_options_defs): New file scoped variable.
5199         (make_info_print_options_def_group): New static function.
5200         (info_print_command_completer): New static function.
5201         (info_variables_command): Update to use local functions, and pass
5202         extra parameter through to symtab_symbol_info.
5203         (info_functions_command): Likewise.
5204         (info_types_command): Pass additional argument through to
5205         symtab_symbol_info.
5206         (rbreak_command): Pass extra argument to search_symbols.
5207         (_initialize_symtab): Add extra arguments for calls to
5208         info_print_args_help, and update help text for 'info variables',
5209         'whereis', and 'info functions' commands.
5210         * symtab.h (search_symbols): Add extra argument to declaration.
5211         * NEWS: Mention new flags.
5212
5213 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5214
5215         * symtab.c (lookup_static_symbol): Call the new function (and move
5216         it down to be next to lookup_global_symbol).
5217         (struct global_sym_lookup_data): Add block_enum member and rename to...
5218         (struct global_or_static_sym_lookup_data): ...this.
5219         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5220         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5221         (lookup_symbol_global_or_static_iterator_cb): ...this.
5222         (lookup_global_or_static_symbol): New function.
5223         (lookup_global_symbol): Call new function.
5224
5225 2019-08-26  Tom de Vries  <tdevries@suse.de>
5226
5227         PR c++/24852
5228         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5229         when pc_probe.prob == NULL.
5230
5231 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5232
5233         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5234         variable symbol_linkage to symbol_linkage_.
5235
5236 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5237
5238         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5239         represent whether the symbol is static, dynamic, or we don't
5240         know.
5241
5242 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5243
5244         * gdb/rx-tdep.c (rx_register_names): New.
5245         (rx_register_name): Delete.
5246         (rx_psw_type): Delete.
5247         (rx_fpsw_type): Delete.
5248         (rx_register_type): Delete.
5249         (rx_gdbarch_init): Convert target-descriptions.
5250         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5251         * gdb/features/Makefile: Add rx.xml.
5252         * gdb/features/rx.xml: New.
5253         * gdb/features/rx.c: Generated.
5254         * gdb/NEWS: Mention target description support.
5255
5256 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5257
5258         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5259         *slot_ptr.
5260
5261 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5262
5263         * configure.ac: Don't check for 'dlfcn.h' (moved to
5264         gdbsupport/common.m4).
5265         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5266         'gdbsupport/'.
5267         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5268         * compile/compile-c-support.c: Include
5269         'gdbsupport/gdb-dlfcn.h'.
5270         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5271         * gdb-dlfcn.c: Move to...
5272         * gdbsupport/gdb-dlfcn.c: ... here.
5273         * gdb-dlfcn.h: Move to...
5274         * gdbsupport/gdb-dlfcn.h: ... here.
5275
5276 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5277
5278         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5279         the offset field signed.
5280
5281 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5282
5283         * python/lib/gdb/__init__.py (_execute_file): New function.
5284         * python/python.c (python_run_simple_file): Call gdb._execute_file
5285         on Windows.
5286
5287 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5288
5289         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5290         all uses as this was never set to anything but a zero value.
5291
5292 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5293
5294         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5295
5296 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5297
5298         * tui/tui-data.h (tui_gen_win_info): Add an =default
5299         move constructor, required by some GCC versions.
5300
5301 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5302
5303         * go32-nat.c (go32_sysinfo): Add hygon_p.
5304
5305 2019-08-20  Tom Tromey  <tom@tromey.com>
5306
5307         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5308         line_from_reg_element_no, first_reg_element_no_inline,
5309         display_all_data, delete_data_content_windows,
5310         erase_data_content>: Now private.
5311
5312 2019-08-20  Tom Tromey  <tom@tromey.com>
5313
5314         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5315         (tui_unhighlight_win, tui_highlight_win)
5316         (tui_win_info::make_window): Update.
5317         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5318
5319 2019-08-20  Tom Tromey  <tom@tromey.com>
5320
5321         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5322         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5323         (MAX_PID_WIDTH): Move to tui-stack.c.
5324         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5325         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5326         (MAX_PID_WIDTH): Move from tui-data.h.
5327
5328 2019-08-20  Tom Tromey  <tom@tromey.com>
5329
5330         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5331         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5332         (box_win): Update.
5333         (tui_gen_win_info::make_window): Rename from tui_make_window.
5334         (tui_win_info::make_window): New method.
5335         (tui_gen_win_info::make_visible): Update.
5336         * tui/tui-source.c (tui_source_window::set_contents): Update.
5337         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5338         (tui_data_window::display_registers_from): Update.
5339         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5340         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5341         Declare.
5342         <can_box>: Remove.
5343         <title>: Remove.
5344         (struct tui_win_info) <make_window>: Declare.
5345         <can_box>: Now virtual.
5346         <title>: New member.
5347         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5348         * tui/tui-command.c (tui_cmd_window::resize): Update.
5349
5350 2019-08-20  Tom Tromey  <tom@tromey.com>
5351
5352         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5353         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5354         (tui_data_window::check_register_values): Update.
5355
5356 2019-08-20  Tom Tromey  <tom@tromey.com>
5357
5358         * tui/tui-regs.h (struct tui_data_window): Use
5359         DISABLE_COPY_AND_ASSIGN.
5360         <regs_content>: Change type, removing unique_ptr.
5361         <tui_data_window>: Add move constructor.
5362         * tui/tui-regs.c (tui_data_window::show_registers)
5363         (tui_data_window::show_register_group)
5364         (tui_data_window::display_registers_from)
5365         (tui_data_window::display_registers_from)
5366         (tui_data_window::first_data_item_displayed)
5367         (tui_data_window::delete_data_content_windows)
5368         (tui_data_window::rerender, tui_data_window::refresh_window)
5369         (tui_data_window::check_register_values): Update.
5370
5371 2019-08-20  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5374         show_register_group>: Declare.
5375         (tui_show_register_group): Don't declare.
5376         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5377         tui_show_registers.
5378         (tui_data_window::show_register_group): Rename from
5379         tui_show_register_group.
5380         (tui_data_window::check_register_values, tui_reg_command):
5381         Update.
5382         * tui/tui-layout.c (tui_set_layout): Update.
5383
5384 2019-08-20  Tom Tromey  <tom@tromey.com>
5385
5386         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5387         Declare.
5388         (tui_check_register_values): Don't declare.
5389         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5390         from tui_check_register_values.
5391         * tui/tui-hooks.c (tui_register_changed): Update.
5392
5393 2019-08-20  Tom Tromey  <tom@tromey.com>
5394
5395         * tui/tui-regs.c (tui_reg_layout): Move later.
5396         (tui_show_registers): Don't enable TUI mode or change layout.
5397
5398 2019-08-20  Tom Tromey  <tom@tromey.com>
5399
5400         * tui/tui-regs.h (struct tui_data_item_window)
5401         <~tui_data_item_window>: Remove.
5402         <content>: Now a unique_xmalloc_ptr.
5403         * tui/tui-regs.c (tui_register_format): Return a
5404         unique_xmalloc_ptr.
5405         (tui_get_register): Update.
5406         (~tui_data_item_window): Remove.
5407         (tui_data_window::display_registers_from, tui_display_register):
5408         Update.
5409         * tui/tui-io.h (tui_expand_tabs): Update.
5410         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5411         Remove "col" parameter.
5412
5413 2019-08-20  Tom Tromey  <tom@tromey.com>
5414
5415         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5416         field.
5417         * tui/tui-regs.c (~tui_data_item_window): Update.
5418
5419 2019-08-20  Tom Tromey  <tom@tromey.com>
5420
5421         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5422         earlier.
5423
5424 2019-08-20  Tom Tromey  <tom@tromey.com>
5425
5426         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5427
5428 2019-08-20  Tom Tromey  <tom@tromey.com>
5429
5430         * tui/tui-source.h (struct tui_source_window): Update.
5431         * tui/tui-regs.c (tui_show_registers): Update.
5432         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5433         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5434         (NO_REGS_STRING): Remove defines.
5435
5436 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5437
5438         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5439         unnecessary thread walk if remote doesn't support the packet.
5440
5441 2019-08-19  Tom Tromey  <tromey@adacore.com>
5442
5443         * python/py-value.c (value_has_field): Fix indentation.
5444
5445 2019-08-19  Tom Tromey  <tromey@adacore.com>
5446
5447         * printcmd.c (do_one_display, info_display_command): Update.
5448         * block.h (contained_in): Return bool.  Add allow_nested
5449         parameter.
5450         * block.c (contained_in): Return bool.  Add allow_nested
5451         parameter.
5452
5453 2019-08-19  Tom Tromey  <tom@tromey.com>
5454
5455         * configure: Rebuild.
5456         * configure.ac: Disallow the combination of -static-libstdc++ and
5457         source highlight.
5458         * source-cache.c (get_language_name): Handle rust.
5459         (source_cache::get_source_lines): Ignore highlighting exceptions.
5460
5461 2019-08-16  Tom Tromey  <tom@tromey.com>
5462
5463         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5464         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5465         (struct tui_source_window_base) <make_visible, refresh_window,
5466         resize>: Remove methods.
5467         <execution_info>: Remove field.
5468         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5469         (tui_show_source_line, tui_source_window_base)
5470         (~tui_source_window_base): Update.
5471         (tui_source_window_base::resize)
5472         (tui_source_window_base::make_visible)
5473         (tui_source_window_base::refresh_window): Remove.
5474         (tui_source_window_base::update_exec_info): Update.
5475         * tui/tui-source.c (tui_source_window::set_contents): Update.
5476         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5477
5478 2019-08-16  Tom Tromey  <tom@tromey.com>
5479
5480         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5481         deprecated_query_hook.
5482
5483 2019-08-16  Tom Tromey  <tom@tromey.com>
5484
5485         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5486         (tui_update_source_windows_with_line): Update.
5487         * tui/tui-source.h (struct tui_source_window)
5488         <show_symtab_source>: Declare.
5489         (tui_show_symtab_source): Don't declare.
5490         * tui/tui-source.c (tui_show_symtab_source): Rename from
5491         tui_show_symtab_source.
5492
5493 2019-08-16  Tom Tromey  <tom@tromey.com>
5494
5495         * tui/tui-winsource.h (struct tui_source_window_base)
5496         <set_contents>: Declare.
5497         * tui/tui-winsource.c
5498         (tui_source_window_base::update_source_window_as_is): Update.
5499         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5500         Declare.
5501         (tui_set_source_content): Don't declare.
5502         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5503         tui_set_source_content.
5504         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5505         Declare.
5506         (tui_set_disassem_content): Don't declare.
5507         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5508         tui_set_disassem_content.
5509
5510 2019-08-16  Tom Tromey  <tom@tromey.com>
5511
5512         * tui/tui-winsource.h (struct tui_source_window_base)
5513         <update_breakpoint_info>: Declare.
5514         (tui_update_breakpoint_info): Don't declare.
5515         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5516         (tui_update_all_breakpoint_info): Update.
5517         (tui_source_window_base::update_breakpoint_info): Rename from
5518         tui_update_breakpoint_info.
5519         (tui_source_window_base::update_exec_info): Update.
5520
5521 2019-08-16  Tom Tromey  <tom@tromey.com>
5522
5523         * tui/tui-winsource.h (struct tui_source_window_base)
5524         <update_source_window>: Declare.
5525         (tui_update_source_window): Don't declare.
5526         * tui/tui-winsource.c
5527         (tui_source_window_base::update_source_window): Rename from
5528         tui_update_source_window.
5529         (tui_source_window_base::rerender): Update.
5530         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5531         * tui/tui-disasm.c (tui_show_disassem)
5532         (tui_show_disassem_and_update_source)
5533         (tui_disasm_window::maybe_update): Update.
5534
5535 2019-08-16  Tom Tromey  <tom@tromey.com>
5536
5537         * tui/tui-winsource.h (struct tui_source_window_base)
5538         <update_source_window_as_is>: Declare.
5539         (tui_update_source_window_as_is): Don't declare.
5540         * tui/tui-winsource.c (tui_update_source_window): Update
5541         (tui_source_window_base::update_source_window_as_is): Rename from
5542         tui_update_source_window_as_is.
5543         (tui_source_window_base::refill): Update.
5544         * tui/tui-source.c (tui_show_symtab_source): Update.
5545         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5546         Update.
5547
5548 2019-08-16  Tom Tromey  <tom@tromey.com>
5549
5550         * tui/tui-winsource.h (tui_update_source_window)
5551         (tui_update_source_window_as_is): Remove "noerror" parameter.
5552         * tui/tui-winsource.c (tui_update_source_window)
5553         (tui_update_source_window_as_is): Remove "noerror" parameter.
5554         (tui_update_source_windows_with_addr)
5555         (tui_update_source_windows_with_line)
5556         (tui_source_window_base::rerender)
5557         (tui_source_window_base::refill): Update.
5558         * tui/tui-source.h (tui_set_source_content)
5559         (tui_show_symtab_source): Remove "noerror" parameter.
5560         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5561         parameter.
5562         (tui_show_symtab_source): Likewise.
5563         (tui_source_window::maybe_update): Update.
5564         * tui/tui-disasm.c (tui_show_disassem)
5565         (tui_show_disassem_and_update_source)
5566         (tui_disasm_window::do_scroll_vertical)
5567         (tui_disasm_window::maybe_update): Update.
5568
5569 2019-08-16  Tom Tromey  <tom@tromey.com>
5570
5571         * tui/tui.c (tui_is_window_visible): Update.
5572         * tui/tui-wingeneral.c (tui_make_window)
5573         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5574         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5575         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5576         (tui_set_win_height_command, parse_scrolling_args): Update.
5577         * tui/tui-source.c (tui_source_window::style_changed): Update.
5578         * tui/tui-regs.c (tui_show_registers)
5579         (tui_data_window::first_data_item_displayed)
5580         (tui_data_window::delete_data_content_windows)
5581         (tui_check_register_values, tui_reg_command): Update.
5582         * tui/tui-disasm.c (tui_show_disassem): Update.
5583         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5584         method.
5585         <is_visible>: Remove field.
5586         * tui/tui-data.c (tui_next_win, tui_prev_win)
5587         (tui_delete_invisible_windows): Update.
5588
5589 2019-08-16  Tom Tromey  <tom@tromey.com>
5590
5591         * tui/tui-winsource.h (struct tui_source_window_base)
5592         <m_has_locator>: Remove.
5593         * tui/tui-layout.c (show_source_disasm_command, show_data)
5594         (show_source_or_disasm_and_command): Update.
5595
5596 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5597
5598         * NEWS (Other MI changes): New subsection.
5599         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5600         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5601         * arch-utils.c (default_get_pc_address_flags): New function.
5602         * arch-utils.h (default_get_pc_address_flags): New declaration.
5603         * gdbarch.sh: Add get_pc_address_flags.
5604         * gdbarch.c: Regenerate.
5605         * gdbarch.h: Likewise.
5606         * stack.c (print_pc): New function.
5607         (print_frame_info) (print_frame): Call print_pc.
5608
5609 2019-08-16  Tom de Vries  <tdevries@suse.de>
5610
5611         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5612         print_objfile_section_info.
5613
5614 2019-08-15  Tom Tromey  <tom@tromey.com>
5615
5616         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5617         calling update_cmdwin_start_line.
5618         * tui/tui-winsource.h (struct tui_source_window_base)
5619         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5620         <rerender>: Declare.
5621         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5622         Call rerender.
5623         (tui_source_window_base::set_new_height): Remove.
5624         (tui_source_window_base::rerender): Rename from
5625         do_make_visible_with_new_height.
5626         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5627         resize method.
5628         (tui_win_info::make_invisible_and_set_new_height)
5629         (tui_win_info::make_visible_with_new_height): Remove.
5630         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5631         Declare.
5632         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5633         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5634         do_make_visible_with_new_height>: Don't declare.
5635         <rerender>: Declare.
5636         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5637         set_new_height.
5638         (tui_data_window::do_make_visible_with_new_height): Remove.
5639         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5640         call tui_show_locator_content.
5641         (tui_gen_win_info::resize): Call rerender.
5642         (show_source_or_disasm_and_command): Don't call
5643         tui_show_locator_content.
5644         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5645         method.
5646         (struct tui_win_info) <rerender>: Declare.
5647         <set_new_height, make_invisible_and_set_new_height,
5648         make_visible_with_new_height>: Don't declare.
5649         * tui/tui-data.c (tui_win_list::rerender): New method.
5650         * tui/tui-command.h (struct tui_cmd_window)
5651         <do_make_visible_with_new_height>: Don't declare.
5652         * tui/tui-command.c
5653         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5654
5655 2019-08-15  Tom Tromey  <tromey@adacore.com>
5656
5657         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5658         * ada-lang.c (ada_enum_name): Likewise.
5659
5660 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5661
5662         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5663         leading underscore.
5664         (GdbOutputErrorFile): Likewise.
5665         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5666         accordingly.
5667         (execute_unwinders): Rename to have a leading underscore.
5668         (auto_load_packages): Likewise.
5669         (global scope): Adjust call to auto_load_packages accordingly.
5670         (GdbSetPythonDirectory): Likewise.
5671         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5672         instead of execute_unwinders.
5673
5674 2019-08-15  Tom Tromey  <tom@tromey.com>
5675
5676         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5677         (show_data): Don't change window visibility.
5678         (tui_gen_win_info::resize): Remove special case for command
5679         window.  Use wresize, when available.
5680         (show_source_or_disasm_and_command): Don't change window
5681         visibility.
5682         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5683         <make_visible>: New method.
5684         * tui/tui-command.c (tui_cmd_window::resize): New method.
5685
5686 2019-08-15  Tom Tromey  <tom@tromey.com>
5687
5688         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5689         (struct tui_source_windows): New.
5690         * tui/tui-winsource.c (tui_display_main): Update.
5691         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5692         (new_height_ok, parse_scrolling_args): Update.
5693         * tui/tui-layout.c (show_layout, show_data): Update.
5694         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5695         (tui_add_to_source_windows): Don't declare.
5696         * tui/tui-data.c (source_windows, tui_source_windows)
5697         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5698
5699 2019-08-15  Tom Tromey  <tom@tromey.com>
5700
5701         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5702         Rename from reset.
5703         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5704         * tui/tui-layout.c (show_source_disasm_command, show_data):
5705         Update.
5706         (tui_gen_win_info::resize): Rename.
5707         (show_source_or_disasm_and_command): Update.
5708         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5709         reset.
5710
5711 2019-08-15  Tom Tromey  <tom@tromey.com>
5712
5713         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5714         * tui/tui-interp.c (tui_interp::init): Don't call
5715         tui_initialize_static_data.
5716         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5717
5718 2019-08-15  Tom Tromey  <tom@tromey.com>
5719
5720         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5721         examine tui_win_list.
5722
5723 2019-08-15  Tom Tromey  <tom@tromey.com>
5724
5725         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5726         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5727         tui_clear_source_content.
5728         (tui_clear_source_content): Remove.
5729         (tui_source_window_base::do_erase_source_content): Hoist call to
5730         content.clear().
5731         * tui/tui-stack.c (tui_show_frame_info): Don't call
5732         tui_clear_source_content.
5733
5734 2019-08-15  Tom Tromey  <tom@tromey.com>
5735
5736         * tui/tui-winsource.h (struct tui_source_window_base)
5737         <do_erase_source_content>: New method.
5738         <erase_source_content>: New method.
5739         (tui_erase_source_content): Don't declare.
5740         * tui/tui-winsource.c (tui_clear_source_content): Update.
5741         (tui_source_window_base::do_erase_source_content): Rename from
5742         tui_erase_source_content.
5743         (tui_source_window_base::show_source_content): Update.
5744         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5745         * tui/tui-source.h (struct tui_source_window)
5746         <erase_source_content>: New method.
5747         * tui/tui-disasm.h (struct tui_disasm_window)
5748         <erase_source_content>: New method.
5749
5750 2019-08-15  Tom Tromey  <tom@tromey.com>
5751
5752         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5753         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5754         constructor.
5755         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5756         * tui/tui-source.c (tui_set_source_content): Update.
5757         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5758
5759 2019-08-15  Tom Tromey  <tom@tromey.com>
5760
5761         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5762         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5763         tui-source.c.
5764         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5765         Declare.
5766         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5767         method.
5768         (tui_source_window::maybe_update): Update.
5769
5770 2019-08-15  Tom Tromey  <tom@tromey.com>
5771
5772         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5773         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5774         tui-disasm.c.
5775         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5776         Declare.
5777         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5778         method.
5779         (tui_disasm_window::maybe_update): Update.
5780
5781 2019-08-15  Tom Tromey  <tom@tromey.com>
5782
5783         * tui/tui-winsource.h (struct tui_source_window_base)
5784         <maybe_update>: Declare.
5785         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5786         method.
5787         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5788         Declare.
5789         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5790         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5791         Declare.
5792         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5793
5794 2019-08-15  Tom Tromey  <tom@tromey.com>
5795
5796         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5797
5798 2019-08-15  Tom Tromey  <tom@tromey.com>
5799
5800         * tui/tui-wingeneral.c: Include tui-stack.h.
5801         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5802         (struct tui_locator_window): Move from tui-data.h.
5803         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5804         (tui_initialize_static_data): Move from tui-data.c.
5805         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5806         (struct tui_locator_window): Move to tui-stack.c.
5807         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5808         (tui_initialize_static_data): Move to tui-stack.c.
5809
5810 2019-08-15  Tom Tromey  <tom@tromey.com>
5811
5812         * tui/tui-layout.c (show_source_disasm_command)
5813         (show_source_or_disasm_and_command): Use make_visible method, not
5814         tui_make_window.
5815         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5816         Remove.
5817
5818 2019-08-15  Tom Tromey  <tom@tromey.com>
5819
5820         * tui/tui-wingeneral.h (tui_make_window): Update.
5821         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5822         parameter.
5823         (tui_gen_win_info::make_visible): Update.
5824         * tui/tui-regs.c (tui_data_window::display_registers_from):
5825         Update.
5826         * tui/tui-layout.c (show_source_disasm_command)
5827         (show_source_or_disasm_and_command): Update.
5828         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5829         (enum tui_box): Remove.
5830         (struct tui_win_info) <can_box>: New method.
5831         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5832         method.
5833
5834 2019-08-15  Tom de Vries  <tdevries@suse.de>
5835
5836         * linux-nat-trad.c: Include gdbarch.h.
5837
5838 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5839
5840         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5841         register sizes.
5842
5843 2019-08-14  Tom Tromey  <tromey@adacore.com>
5844
5845         * darwin-nat.c: Include gdbarch.h.
5846         * darwin-nat-info.c: Include gdbarch.h.
5847
5848 2019-08-13  Tom Tromey  <tom@tromey.com>
5849
5850         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5851         Remove.
5852         * tui/tui-data.c (tui_initialize_static_data): Update.
5853
5854 2019-08-13  Tom Tromey  <tom@tromey.com>
5855
5856         * tui/tui-winsource.h (struct tui_exec_info_window)
5857         <~tui_exec_info_window, maybe_allocate_content, get_content,
5858         m_content>: Remove.
5859         (struct tui_source_window_base) <set_exec_info_content,
5860         show_exec_info_content>: Don't declare.
5861         * tui/tui-winsource.c
5862         (tui_exec_info_window::maybe_allocate_content): Remove.
5863         (tui_source_window_base::update_exec_info): Rename from
5864         set_exec_info_content.
5865         (tui_source_window_base::show_exec_info_content)
5866         (tui_source_window_base::update_exec_info): Remove.
5867
5868 2019-08-13  Tom Tromey  <tom@tromey.com>
5869
5870         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5871         declare.
5872         * tui/tui-winsource.c (tui_update_source_window_as_is)
5873         (tui_update_source_windows_with_addr, tui_erase_source_content):
5874         Update.
5875         (tui_clear_exec_info_content): Remove.
5876
5877 2019-08-13  Tom Tromey  <tom@tromey.com>
5878
5879         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5880         declare.
5881         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5882         call tui_erase_exec_info_content.
5883         (tui_clear_exec_info_content): Rename from
5884         tui_erase_exec_info_content.
5885         (tui_clear_exec_info_content): Delete.
5886
5887 2019-08-13  Tom Tromey  <tom@tromey.com>
5888
5889         * tui/tui-winsource.h (struct tui_source_window_base)
5890         <show_exec_info_content>: Declare.
5891         (tui_show_exec_info_content): Don't declare.
5892         * tui/tui-winsource.c
5893         (tui_source_window_base::show_exec_info_content): Rename from
5894         tui_show_exec_info_content.
5895         (tui_source_window_base::update_exec_info): Update.
5896
5897 2019-08-13  Tom Tromey  <tom@tromey.com>
5898
5899         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5900         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5901         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5902         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5903         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5904         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5905         ... here.
5906
5907 2019-08-13  Tom Tromey  <tom@tromey.com>
5908
5909         * tui/tui-winsource.h (struct tui_source_window_base)
5910         <update_exec_info>: Declare.
5911         (tui_update_exec_info): Don't declare.
5912         * tui/tui-winsource.c (tui_update_source_window_as_is)
5913         (tui_source_window_base::refresh_all)
5914         (tui_update_all_breakpoint_info): Update.
5915         (tui_source_window_base::update_exec_info): Rename from
5916         tui_update_exec_info.
5917         * tui/tui-stack.c (tui_show_frame_info): Update.
5918
5919 2019-08-13  Tom Tromey  <tom@tromey.com>
5920
5921         * tui/tui-winsource.h (struct tui_source_window_base)
5922         <set_exec_info_content>: Declare.
5923         (tui_set_exec_info_content): Don't declare.
5924         * tui/tui-winsource.c
5925         (tui_source_window_base::set_exec_info_content): Rename from
5926         tui_set_exec_info_content.
5927         (tui_update_exec_info): Update.
5928
5929 2019-08-13  Tom Tromey  <tom@tromey.com>
5930
5931         * tui/tui-winsource.h (struct tui_source_window_base)
5932         <show_source_content>: Declare.
5933         (tui_show_source_content): Don't declare.
5934         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
5935         (tui_source_window_base::show_source_content): Rename from
5936         tui_show_source_content.
5937         (tui_source_window_base::refresh_all): Update.
5938         * tui/tui-layout.c (show_source_disasm_command)
5939         (show_source_or_disasm_and_command): Update.
5940
5941 2019-08-13  Tom Tromey  <tom@tromey.com>
5942
5943         * tui/tui-winsource.c (tui_erase_source_content)
5944         (tui_show_source_content, tui_source_window_base::refresh_all):
5945         Update.
5946         * tui/tui-wingeneral.h
5947         (tui_check_and_display_highlight_if_needed): Don't declare.
5948         * tui/tui-wingeneral.c
5949         (tui_win_info::check_and_display_highlight_if_needed): Rename from
5950         check_and_display_highlight_if_needed.
5951         * tui/tui-win.c (tui_rehighlight_all)
5952         (tui_win_info::make_visible_with_new_height): Update.
5953         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5954         (tui_data_window::erase_data_content)
5955         (tui_data_window::display_all_data): Update.
5956         * tui/tui-data.h (struct tui_win_info)
5957         <check_and_display_highlight_if_needed>: Declare.
5958
5959 2019-08-13  Tom Tromey  <tom@tromey.com>
5960
5961         * tui/tui-win.c (tui_resize_all): Call
5962         tui_delete_invisible_windows.
5963         * tui/tui-layout.c (show_layout): Call
5964         tui_delete_invisible_windows.
5965         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
5966         * tui/tui-data.c (tui_delete_invisible_windows): New function.
5967
5968 2019-08-13  Tom Tromey  <tom@tromey.com>
5969
5970         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
5971         tui_add_win_to_layout.
5972
5973 2019-08-13  Tom Tromey  <tom@tromey.com>
5974
5975         * tui/tui-layout.h (tui_default_win_height): Don't declare.
5976         * tui/tui-layout.c (tui_default_win_height): Now static.
5977
5978 2019-08-13  Tom Tromey  <tom@tromey.com>
5979
5980         * tui/tui-layout.c (show_layout): Unify all layout cases into a
5981         single switch.
5982         (show_source_disasm_command, show_source_or_disasm_and_command):
5983         Don't check current layout.
5984
5985 2019-08-13  Tom Tromey  <tom@tromey.com>
5986
5987         * tui/tui-wingeneral.c (make_all_visible): Remove.
5988         (tui_make_all_invisible): Simplify.
5989         * tui/tui-layout.c (tui_make_all_invisible): Move from
5990         tui-wingeneral.c; simplify.
5991         (show_layout): Hoist call to tui_make_all_invisible.
5992         (show_data): Don't call tui_make_all_invisible.
5993
5994 2019-08-13  Tom Tromey  <tom@tromey.com>
5995
5996         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
5997         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
5998
5999 2019-08-13  Tom Tromey  <tom@tromey.com>
6000
6001         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6002         tui-data.c.
6003         (show_source_disasm_command, show_data)
6004         (show_source_or_disasm_and_command): Don't use
6005         tui_set_current_layout_to.
6006         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6007         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6008         tui-layout.c.
6009         (tui_set_current_layout_to): Remove.
6010
6011 2019-08-13  Tom Tromey  <tom@tromey.com>
6012
6013         * tui/tui-layout.c (tui_set_layout): Update.
6014         * tui/tui-data.h (struct tui_layout_def): Remove.
6015         (tui_layout_def): Don't declare.
6016         * tui/tui-data.c (layout_def): Remove.
6017         (tui_layout_def): Remove.
6018
6019 2019-08-13  Tom Tromey  <tom@tromey.com>
6020
6021         * tui/tui-winsource.h (struct tui_source_window_base)
6022         <clear_detail>: No longer "override".
6023         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6024         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6025         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6026         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6027         Remove.
6028         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6029
6030 2019-08-13  Tom Tromey  <tromey@adacore.com>
6031
6032         * tracepoint.c: Don't include readline.h or history.h.
6033
6034 2019-08-12  Tom Tromey  <tom@tromey.com>
6035
6036         * configure: Rebuild.
6037         * configure.ac: Check for readline 7.
6038         * NEWS: Mention readline 7 requirement.
6039         * README: Update.
6040
6041 2019-08-12  Tom Tromey  <tom@tromey.com>
6042
6043         * mingw-hdep.c (gdb_select): Remove readline hack.
6044
6045 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6046
6047         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6048         when the function fails.
6049
6050 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6051
6052         * s390-tdep.c (s390_type_align): New function.
6053         (s390_gdbarch_init): Set it as type_align gdbarch method.
6054
6055 2019-08-09  Tom de Vries  <tdevries@suse.de>
6056
6057         PR gdb/24591
6058         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6059         pc_low with relocation offset.
6060
6061 2019-08-07  Tom Tromey  <tromey@adacore.com>
6062
6063         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6064         (print_frame_args): Update.
6065         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6066         Update.
6067         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6068         * frame.h (struct frame_arg): Add initializers.
6069         <error>: Now a unique_xmalloc_ptr.
6070
6071 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6072
6073         * NEWS: Expand the Pointer Authentication entry.
6074         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6075         (aarch64_frame_unmask_lr): ... to this.
6076         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6077         Call aarch64_frame_unmask_lr.
6078         * frame.c (struct frame_info): Add "masked" variable.
6079         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6080         (fprint_frame): Check for masked pc.
6081         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6082         declarations.
6083         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6084         * stack.c (print_frame): Check for masked pc.
6085
6086 2019-08-06  Tom Tromey  <tom@tromey.com>
6087
6088         * stabsread.c (patch_block_stabs, read_one_struct_field)
6089         (read_enum_type): Use obstack_strndup.
6090         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6091         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6092         * dwarf2read.c (guess_full_die_structure_name)
6093         (anonymous_struct_prefix): Use obstack_strndup.
6094         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6095         * c-exp.y (yylex): Use obstack_strndup.
6096         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6097         (write_var_or_type): Use obstack_strndup.
6098
6099 2019-08-06  Tom Tromey  <tom@tromey.com>
6100
6101         * symfile.c (reread_symbols): Use obstack_strdup.
6102         * stabsread.c (read_type): Use obstack_strdup.
6103         * gdb_obstack.h (obstack_strdup): New overload.
6104         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6105         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6106         (dwarf2_canonicalize_name): Use obstack_strdup.
6107         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6108         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6109         Use obstack_strdup.
6110
6111 2019-08-06  Tom Tromey  <tom@tromey.com>
6112
6113         * gdb_obstack.h (obstack_strdup): Define.
6114         * gdb_obstack.c (obstack_strdup): Don't define.
6115
6116 2019-08-06  Tom Tromey  <tom@tromey.com>
6117
6118         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6119         obstack_strdup.
6120         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6121         obstack_strdup.
6122         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6123         * stabsread.c (common_block_start): Use obstack_strdup.
6124         * objfiles.c (set_objfile_main_name, objfile): Use
6125         obstack_strdup.
6126         * namespace.c (add_using_directive): Use obstack_strdup.
6127         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6128         * jit.c (finalize_symtab): Use obstack_strdup.
6129         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6130         (guess_partial_die_structure_name, partial_die_info::fixup)
6131         (dwarf2_name): Use obstack_strdup.
6132         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6133         obstack_strdup.
6134         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6135         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6136         obstack_strdup.
6137         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6138
6139 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6140
6141         * unittests/help-doc-selftests.c: New file.
6142         * Makefile.in: Add the new file.
6143
6144 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6145
6146         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6147         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6148         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6149         the trailing '.' is not output, and the first character is uppercased.
6150         (print_help_for_command): Update call to print_doc_line.
6151         (print_doc_of_command): Likewise.
6152         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6153         * cli/cli-option.c (append_indented_doc): Do not append newline.
6154         (build_help_option): Append newline after first appended_indented_doc
6155         only if a second call is done.
6156         (build_help): Append 2 new lines before each option, except the first
6157         one.
6158         * compile/compile.c (_initialize_compile): Add new lines after
6159         %OPTIONS%, when not at the end of the help.
6160         Change help doc or code
6161         producing the help doc to respect the invariants.
6162         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6163         Also removed the new line after 'Options:', as all other commands
6164         do not put an empty line between 'Options:' and the first option.
6165         * printcmd.c (_initialize_printcmd): Likewise.
6166         * stack.c (_initialize_stack): Likewise.
6167         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6168         incorrectly telling COMMAND is optional.
6169         * ada-lang.c (_initialize_ada_language): Change help doc or code
6170         producing the help doc to respect the invariants.
6171         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6172         * breakpoint.c (_initialize_breakpoint): Likewise.
6173         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6174         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6175         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6176         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6177         _initialize_cli_style): Likewise.
6178         * corelow.c (core_target_info): Likewise.
6179         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6180         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6181         * filesystem.c (_initialize_filesystem): Likewise.
6182         * frame.c (_initialize_frame): Likewise.
6183         * gnu-nat.c (add_task_commands): Likewise.
6184         * infcall.c (_initialize_infcall): Likewise.
6185         * infcmd.c (_initialize_infcmd): Likewise.
6186         * interps.c (_initialize_interpreter): Likewise.
6187         * language.c (_initialize_language): Likewise.
6188         * linux-fork.c (_initialize_linux_fork): Likewise.
6189         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6190         * maint.c (_initialize_maint_cmds): Likewise.
6191         * memattr.c (_initialize_mem): Likewise.
6192         * printcmd.c (_initialize_printcmd): Likewise.
6193         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6194         _RegEx): Likewise.
6195         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6196         * record-btrace.c (_initialize_record_btrace): Likewise.
6197         * record-full.c (_initialize_record_full): Likewise.
6198         * record.c (_initialize_record): Likewise.
6199         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6200         * regcache.c (_initialize_regcache): Likewise.
6201         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6202         _initialize_remote): Likewise.
6203         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6204         * serial.c (_initialize_serial): Likewise.
6205         * skip.c (_initialize_step_skip): Likewise.
6206         * source.c (_initialize_source): Likewise.
6207         * stack.c (_initialize_stack): Likewise.
6208         * symfile.c (_initialize_symfile): Likewise.
6209         * symtab.c (_initialize_symtab): Likewise.
6210         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6211         * top.c (init_main): Likewise.
6212         * tracefile-tfile.c (tfile_target_info): Likewise.
6213         * tracepoint.c (_initialize_tracepoint): Likewise.
6214         * tui/tui-win.c (_initialize_tui_win): Likewise.
6215         * utils.c (add_internal_problem_command): Likewise.
6216         * valprint.c (value_print_option_defs): Likewise.
6217
6218 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6219
6220         PR build/24886
6221         * configure.ac: Drop enable-libmcheck support.
6222         * configure, config.in: Rebuild.
6223         * libmcheck.m4: Remove.
6224         * acinclude.m4: Don't include it.
6225         * Makefile.in: Don't distribute it.
6226         * top.c (print_gdb_configuration): Don't mention it.
6227
6228 2019-08-06  Tom Tromey  <tom@tromey.com>
6229
6230         * utils.c (set_output_style): Sometimes pass stream to
6231         emit_style_escape.
6232         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6233         * record-btrace.c (btrace_insn_history): Update.
6234         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6235         method.
6236         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6237         Update initializers.
6238         <m_uiout>: New field.
6239         <m_di>: Move lower.
6240         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6241         Remove "uiout" parameter.
6242         (dump_insns): Update.
6243         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6244         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6245
6246 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6247
6248         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6249         (error_in_psymtab_expansion): Likewise.
6250         (lookup_symbol_via_quick_fns): Likewise.
6251         (basic_lookup_transparent_type_quick): Likewise.
6252         (basic_lookup_transparent_type_1): Likewise.
6253
6254 2019-08-06  Tom Tromey  <tromey@adacore.com>
6255
6256         * source.c (last_source_error): Now bool.
6257         (print_source_lines_base): Make "noprint" bool.  Only open
6258         source file when last_source_visited changes.
6259
6260 2019-08-06  Tom Tromey  <tromey@adacore.com>
6261
6262         * annotate.c (annotate_source_line): Use g_source_cache.
6263         * source-cache.c (source_cache::get_plain_source_lines): Change
6264         parameters.  Populate m_offset_cache.
6265         (source_cache::ensure): New method.
6266         (source_cache::get_line_charpos): New method.
6267         (extract_lines): Move lower.  Change parameters.
6268         (source_cache::get_source_lines): Move lower.
6269         * source-cache.h (class source_cache): Update comment.
6270         <get_line_charpos>: New method.
6271         <get_source_lines>: Update comment.
6272         <clear>: Clear m_offset_cache.
6273         <get_plain_source_lines>: Change parameters.
6274         <ensure>: New method
6275         <m_offset_cache>: New member.
6276         * source.c (forget_cached_source_info_for_objfile): Update.
6277         (info_source_command): Use g_source_cache.
6278         (find_source_lines, open_source_file_with_line_charpos): Remove.
6279         (print_source_lines_base, search_command_helper): Use g_source_cache.
6280         * source.h (open_source_file_with_line_charpos): Don't declare.
6281         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6282         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6283         Use g_source_cache.
6284
6285 2019-08-06  Tom Tromey  <tromey@adacore.com>
6286
6287         * source-cache.c (source_cache::get_plain_source_lines):
6288         Remove "first_line" and "last_line" parameters.
6289         (source_cache::get_source_lines): Cache plain text.
6290         * source-cache.h (class source_cache)
6291         <get_plain_source_lines>: Update.
6292
6293 2019-08-06  Tom Tromey  <tromey@adacore.com>
6294
6295         * source-cache.c (extract_lines): No longer a method.
6296         Changed type of parameter.  Include final newline.
6297         (selftests::extract_lines_test): New function.
6298         (_initialize_source_cache): Likewise.
6299         * source-cache.h (class source_cache)
6300         <extract_lines>: Don't declare.
6301
6302 2019-08-06  Tom Tromey  <tromey@adacore.com>
6303
6304         * breakpoint.c (init_breakpoint_sal): Update.
6305         (breakpoint): Update.
6306         * breakpoint.h (struct breakpoint) <filter>: Now a
6307         unique_xmalloc_ptr.
6308
6309 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6310
6311         * NEWS: Mention dictionary access on blocks.
6312         * python/py-block.c (blpy_getitem): New function.
6313         (block_object_as_mapping): New struct.
6314         (block_object_type): Use new struct for tp_as_mapping field.
6315
6316 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6317
6318         * objfiles.h (objfile): Add a comment describing partial symbols.
6319
6320 2019-08-05  Tom Tromey  <tromey@adacore.com>
6321
6322         * compile/compile.c (_initialize_compile): Use _(), not N_().
6323         * thread.c (_initialize_thread): Use _(), not N_().
6324         * stack.c (_initialize_stack): Use _(), not N_().
6325         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6326
6327 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6328
6329         * dwarf2read.c (struct dw2_symtab_iterator):
6330         <want_specific_block>: Remove.
6331         <block_index>: Change type to gdb::optional.
6332         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6333         change type of BLOCK_INDEX parameter to gdb::optional.
6334         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6335         (dw2_lookup_symbol): Don't pass argument for
6336         WANT_SPECIFIC_BLOCK.
6337         (dw2_expand_symtabs_for_function): Don't pass argument for
6338         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6339         (class dw2_debug_names_iterator)
6340         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6341         parameter, change BLOCK_INDEX type to gdb::optional.
6342         <m_want_specific_block>: Remove.
6343         <m_block_index>: Change type to gdb::optional.
6344         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6345         gdb::optional.  Re-write in function of gdb::optional.
6346         (dw2_debug_names_lookup_symbol): Don't pass argument for
6347         WANT_SPECIFIC_BLOCK.
6348         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6349         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6350         BLOCK_INDEX.
6351
6352 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6353
6354         * NEWS: Mention changes to "info sources" command.
6355
6356 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6357
6358         * symtab.c (filename_partial_match_opts): New struct type.
6359         (struct output_source_filename_data): New members
6360         regexp, c_regexp, partial_match.
6361         (output_source_filename): Use new members to decide to print file.
6362         (info_sources_option_defs): New variable.
6363         (make_info_sources_options_def_group, print_info_sources_header,
6364         info_sources_command_completer):
6365         New functions.
6366         (info_sources_command): Read new optional arguments.
6367         (_initialize_symtab): Update info sources help.
6368
6369 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6370
6371         * ada-lang.c (exception_support_info_v0): Renamed from...
6372         (default_exception_support_info): ... this.  Create new
6373         definition for v1.
6374         (ada_has_this_exception_support): Look up catch_handlers_sym.
6375         (ada_exception_support_info_sniffer): Try v0 after default.
6376
6377 2019-08-01  Tom Tromey  <tromey@adacore.com>
6378
6379         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6380         gdbarch.h.
6381
6382 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6383
6384         * s12z-tdep.c: Fix include path for s12z-opc.h.
6385
6386 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6387
6388         * NEWS: Require GNU make 3.82.
6389
6390 2019-07-16  Tom Tromey  <tom@tromey.com>
6391
6392         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6393         declare.
6394
6395 2019-07-30  Tom Tromey  <tromey@adacore.com>
6396
6397         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6398
6399 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6400
6401         * printcmd.c (print_address_symbolic): Print negative offsets.
6402         (build_address_symbolic): Force signed arithmetic when computing
6403         offset.
6404
6405 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6406
6407         PR/24474: Add a function to lookup static variables.
6408         * NEWS: Mention this new function.
6409         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6410         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6411         * python/python.c (python_GdbMethods): Add new function.
6412
6413 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6414
6415         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6416         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6417         (objfpy_lookup_static_symbol): New function.
6418         (objfile_object_methods): Add new functions.
6419
6420 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6421
6422         * NEWS: Mention 'set|show print frame-info'.  Mention new
6423         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6424         backtrace argument.  Mention that python frame filtering code
6425         is now consistent with what 'backtrace' command prints.
6426
6427 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6428
6429         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6430         comments.
6431         (print_frame_info_auto, print_frame_info_source_line,
6432         print_frame_info_location, print_frame_info_source_and_location,
6433         print_frame_info_location_and_address, print_frame_info_short_location):
6434         New declarations.
6435         (struct frame_print_options): New member print_frame_info.
6436         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6437         * stack.h (get_user_print_what_frame_info): New declaration.
6438         (frame_show_address): New declaration.
6439         * stack.c (print_frame_arguments_choices): New value 'presence'.
6440         (print_frame_info_auto, print_frame_info_source_line,
6441         print_frame_info_location, print_frame_info_source_and_location,
6442         print_frame_info_location_and_address, print_frame_info_short_location,
6443         print_frame_info_choices, print_frame_info_print_what): New definitions.
6444         (print_frame_args): Only print dots for args if print frame-arguments
6445         is 'presence'.
6446         (frame_print_option_defs): New element for "frame-info".
6447         (get_user_print_what_frame_info): New function.
6448         (frame_show_address): Make non static.  Move comment to stack.h.
6449         (print_frame_info_to_print_what): New function.
6450         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6451         to decide what to print.
6452         (backtrace_command_1): Handle the new print_frame_arguments_presence
6453         value.
6454         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6455         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6456         (py_print_frame): In non-mi mode, use LOCATION as default for
6457         print_what, similarly to frame information printed directly by
6458         backtrace command. Handle frame-info user option in non MI mode.
6459
6460 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6461
6462         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6463         Add case for debugging 32-bit target on 64-bit host.  Revise
6464         comment.
6465
6466 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6467
6468         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6469         instead of find_function_entry_range_from_pc.
6470
6471 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6472
6473         * stack.c (find_frame_funname): Remove code which preferred
6474         minsym over symtab sym in "certain pathological cases".
6475
6476         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6477         parameter.  Change type of "do_demangle" to bool.
6478         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6479         Pass suitable "prefer_sym_over_minsym" flag to
6480         build_address_symbolic().  Don't output "+" for negative offsets.
6481         * printcmd.c (print_address_symbolic): Update invocation of
6482         build_address_symbolic to include a "prefer_sym_over_minsym"
6483         flag.
6484         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6485         Restrict cases in which use of minimal symbol is preferred to that
6486         of a found symbol.  Update comments.
6487
6488         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6489         for entry pc when entry pc is out of range for that FDE.
6490
6491 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6492
6493         PR gdb/24839:
6494         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6495         type.
6496
6497 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6498
6499         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6500         this function's Python signature.
6501
6502
6503 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6504
6505         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6506         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6507         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6508         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6509         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6510
6511
6512 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6513
6514         * h8300-tdep.c (h8300_register_name_common): New.
6515         h8300_register_name): Use h8300_register_name_common.
6516         (h8300s_register_name): Likewise.
6517         (h8300sx_register_name): Likewise.
6518         (h8300h_register_nam): New.
6519         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6520
6521
6522 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6523
6524         * arm-tdep.c (arm_skip_cmse_entry): New function.
6525         (arm_is_sgstubs_section): New function.
6526         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6527
6528 2019-07-22  Tom Tromey  <tom@tromey.com>
6529
6530         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6531         Don't self-assign.
6532
6533 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6534
6535         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6536         type_print.
6537
6538 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6539
6540         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6541         so that GDB doesn't match any msymbols when searching in the
6542         TYPES_DOMAIN.
6543         (print_symbol_info): Print using typedef_print or type_print based
6544         on the type of the symbol.  Add updated FIXME comment moved from...
6545         (_initialize_symtab): ... move and update FIXME comment to above.
6546
6547 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6548
6549         * NEWS: Mention adding -q option to "info types".
6550         * symtab.c (struct info_types_options): New struct.
6551         (info_types_options_defs): New variable.
6552         (make_info_types_options_def_group): New function.
6553         (info_types_command): Use gdb::option framework to parse options.
6554         (info_types_command_completer): New function.
6555         (_initialize_symtab): Extend the help text on "info types" and
6556         register command completer.
6557
6558 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6559
6560         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6561         (lookup_symbol_in_objfile): Change int to block_enum and add a
6562         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6563
6564 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6565
6566         * MAINTAINERS (Write After Approval): Add self.
6567
6568 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6569
6570         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6571         instruction to the dummy code region.
6572
6573 2019-07-19  Tom Tromey  <tromey@adacore.com>
6574
6575         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6576         (ARGSUSED, PARAMS, __func__): Remove rules.
6577
6578 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6579
6580         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6581         * features/arm/arm-with-iwmmxt.c: Remove.
6582         * features/arm/arm-with-iwmmxt.xml: Remove.
6583         * features/arm/arm-with-m-fpa-layout.c: Remove.
6584         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6585         * features/arm/arm-with-m-vfp-d16.c: Remove.
6586         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6587         * features/arm/arm-with-m.c: Remove.
6588         * features/arm/arm-with-m.xml: Remove.
6589         * features/arm/arm-with-neon.c: Remove.
6590         * features/arm/arm-with-neon.xml: Remove.
6591         * features/arm/arm-with-vfpv2.c: Remove.
6592         * features/arm/arm-with-vfpv2.xml: Remove.
6593         * features/arm/arm-with-vfpv3.c: Remove.
6594         * features/arm/arm-with-vfpv3.xml: Remove.
6595
6596 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6597
6598         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6599
6600 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6601
6602         * arch/aarch32.c (aarch32_create_target_description): Create
6603         target descriptions using features.
6604         * arch/arm.c (arm_create_target_description)
6605         (arm_create_mprofile_target_description): Likewise.
6606         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6607
6608 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6609
6610         * Makefile.in: Add new files.
6611         * aarch32-tdep.c: New file.
6612         * aarch32-tdep.h: New file.
6613         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6614         Call aarch32_read_description.
6615         * arch/aarch32.c: New file.
6616         * arch/aarch32.h: New file.
6617         * arch/arm.c (arm_create_target_description)
6618         (arm_create_mprofile_target_description): New function.
6619         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6620         (arm_create_target_description)
6621         (arm_create_mprofile_target_description): New declaration.
6622         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6623         read_description functions.
6624         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6625         Likewise.
6626         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6627         * arm-tdep.c (tdesc_arm_list): New variable.
6628         (arm_register_g_packet_guesses): Call create description functions.
6629         (arm_read_description) (arm_read_mprofile_description): New
6630         function.
6631         * arm-tdep.h (arm_read_description)
6632         (arm_read_mprofile_description): Add declaration.
6633         * configure.tgt: Add new files.
6634
6635 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6636
6637         * top.c (new_ui_command): Open specified terminal just once.
6638
6639 2019-07-18  Tom Tromey  <tromey@adacore.com>
6640
6641         * symtab.c (main_name): Constify return type.
6642         * symfile.c (set_initial_language): Update.
6643         * symtab.h (main_name): Constify return type.
6644
6645 2019-07-17  Tom Tromey  <tom@tromey.com>
6646
6647         * tui/tui-winsource.c (tui_update_source_window)
6648         (tui_update_source_window_as_is)
6649         (tui_update_source_windows_with_line): Remove return.
6650         * tui/tui-disasm.c (tui_show_disassem)
6651         (tui_show_disassem_and_update_source): Remove return.
6652         * tui/tui.c (tui_reset): Remove return.
6653         * tui/tui-wingeneral.c
6654         (tui_check_and_display_highlight_if_needed): Remove return.
6655
6656 2019-07-17  Tom Tromey  <tom@tromey.com>
6657
6658         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6659
6660 2019-07-17  Tom Tromey  <tom@tromey.com>
6661
6662         * tui/tui-winsource.h (struct tui_exec_info_window)
6663         (struct tui_source_window_base): Move from tui-data.h.
6664         * tui/tui-winsource.c: Move many method definitions from
6665         elsewhere.  Remove "structuring" comments.
6666         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6667         (tui_source_window_base::refresh_window): Move to
6668         tui-winsource.c.
6669         * tui/tui-win.c (tui_source_window_base::refresh_all)
6670         (tui_source_window_base::update_tab_width)
6671         (tui_source_window_base::set_new_height)
6672         (tui_source_window_base::do_make_visible_with_new_height): Move to
6673         tui-winsource.c.
6674         * tui/tui-source.h: Update.
6675         * tui/tui-source.c (tui_source_window_base::reset): Move to
6676         tui-winsource.c.
6677         * tui/tui-disasm.h: Update.
6678         * tui/tui-data.h (struct tui_exec_info_window): Move to
6679         tui-winsource.h.
6680         (struct tui_source_window_base): Likewise.
6681         * tui/tui-data.c (tui_source_window_base::clear_detail)
6682         (tui_source_window_base, ~tui_source_window_base): Move to
6683         tui-winsource.c.
6684
6685 2019-07-17  Tom Tromey  <tom@tromey.com>
6686
6687         * tui/tui-win.c (tui_resize_all)
6688         (tui_source_window_base::update_tab_width)
6689         (tui_adjust_win_heights): Update.
6690         (tui_win_info::make_invisible_and_set_new_height): Rename from
6691         make_invisible_and_set_new_height.
6692         * tui/tui-data.h (struct tui_win_info)
6693         <make_invisible_and_set_new_height>: New method.
6694
6695 2019-07-17  Tom Tromey  <tom@tromey.com>
6696
6697         * tui/tui.c: Update.
6698         * tui/tui-source.h (struct tui_source_window): Move from
6699         tui-data.h.
6700         * tui/tui-layout.c: Update.
6701         * tui/tui-disasm.c: Update.
6702         * tui/tui-data.h (struct tui_source_window): Move to
6703         tui-source.h.
6704
6705 2019-07-17  Tom Tromey  <tom@tromey.com>
6706
6707         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6708         tui-data.h.
6709         * tui/tui-data.h (struct tui_disasm_window): Move to
6710         tui-disasm.h.
6711
6712 2019-07-17  Tom Tromey  <tom@tromey.com>
6713
6714         * tui/tui-regs.h (struct tui_data_item_window): Move from
6715         tui-data.h.
6716         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6717         * tui/tui-data.h (struct tui_data_item_window): Move to
6718         tui-regs.h.
6719         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6720
6721 2019-07-17  Tom Tromey  <tom@tromey.com>
6722
6723         * tui/tui.c: Update.
6724         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6725         (tui_cmd_window::max_height): Move to tui-command.c.
6726         * tui/tui-layout.c: Update.
6727         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6728         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6729         tui-command.c.
6730         * tui/tui-command.h (struct tui_cmd_window): Move from
6731         tui-data.h.
6732         * tui/tui-command.c: Remove "structuring" comments.
6733         (tui_cmd_window::clear_detail)
6734         (tui_cmd_window::do_make_visible_with_new_height)
6735         (tui_cmd_window::max_height): Move from elsewhere.
6736
6737 2019-07-17  Tom Tromey  <tom@tromey.com>
6738
6739         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6740         Now static.
6741         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6742         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6743
6744 2019-07-17  Tom Tromey  <tom@tromey.com>
6745
6746         * tui/tui.c: Update.
6747         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6748         tui-regs.c.
6749         * tui/tui-windata.h: Remove file.
6750         * tui/tui-windata.c: Remove file.
6751         * tui/tui-win.c (tui_data_window::set_new_height)
6752         (tui_data_window::do_make_visible_with_new_height): Move to
6753         tui-regs.c.
6754         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6755         * tui/tui-regs.c: Remove "structuring" comments.
6756         (tui_data_window::first_data_item_displayed)
6757         (tui_data_window::delete_data_content_windows)
6758         (tui_data_window::erase_data_content)
6759         (tui_data_window::display_all_data)
6760         (tui_data_window::refresh_all)
6761         (tui_data_window::do_scroll_vertical)
6762         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6763         (tui_data_window::do_make_visible_with_new_height)
6764         (tui_data_window::refresh_window): Move from elsewhere.
6765         (_initialize_tui_regs): Move to end of file.
6766         * tui/tui-layout.c: Update.
6767         * tui/tui-hooks.c: Update.
6768         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6769         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6770         tui-regs.c.
6771         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6772
6773 2019-07-17  Tom Tromey  <tom@tromey.com>
6774
6775         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6776         seen.
6777
6778 2019-07-17  Tom Tromey  <tom@tromey.com>
6779
6780         * tui/tui-win.c (tui_source_window_base::set_new_height)
6781         (tui_source_window_base::do_make_visible_with_new_height): Use
6782         m_has_locator field directly.
6783         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6784         method.
6785         (struct tui_source_window_base) <has_locator>: Likewise.
6786
6787 2019-07-17  Tom Tromey  <tom@tromey.com>
6788
6789         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6790         Don't declare.
6791         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6792         Remove.
6793         * tui/tui-win.c (tui_source_window_base::set_new_height)
6794         (tui_source_window_base::set_new_height)
6795         (make_invisible_and_set_new_height)
6796         (tui_source_window_base::do_make_visible_with_new_height)
6797         (tui_source_window_base::do_make_visible_with_new_height):
6798         Update.
6799         * tui/tui-layout.c (show_source_disasm_command, show_data)
6800         (show_source_or_disasm_and_command): Update.
6801         * tui/tui-layout.c (show_layout): Update.
6802
6803 2019-07-17  Tom Tromey  <tom@tromey.com>
6804
6805         * tui/tui-layout.c (make_data_window): Remove.
6806         (show_data): Unify creation and re-initialization cases.
6807
6808 2019-07-17  Tom Tromey  <tom@tromey.com>
6809
6810         * tui/tui-layout.c (make_source_window, make_disasm_window):
6811         Remove.
6812         (show_data): Unify creation and re-initialization cases.
6813
6814 2019-07-17  Tom Tromey  <tom@tromey.com>
6815
6816         * tui/tui-layout.c (make_command_window): Remove.
6817         (show_source_disasm_command, show_source_or_disasm_and_command):
6818         Unify creation and re-initialization cases.
6819
6820 2019-07-17  Tom Tromey  <tom@tromey.com>
6821
6822         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6823         creation and re-initialization cases.
6824
6825 2019-07-17  Tom Tromey  <tom@tromey.com>
6826
6827         * tui/tui-regs.c (tui_get_register): Return void.
6828
6829 2019-07-17  Tom Tromey  <tom@tromey.com>
6830
6831         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6832         Simplify.
6833
6834 2019-07-17  Tom Tromey  <tom@tromey.com>
6835
6836         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6837         resetting.
6838
6839 2019-07-17  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6842         * tui/tui-regs.c (tui_reg_layout): New function.
6843         (tui_show_registers, tui_reg_command): Use it.
6844         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6845         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6846         parameters.
6847         (tui_layout_command): Remove.
6848
6849 2019-07-17  Tom Tromey  <tom@tromey.com>
6850
6851         * tui/tui-layout.h (tui/tui-layout): Return void.
6852         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6853
6854 2019-07-17  Tom Tromey  <tom@tromey.com>
6855
6856         * tui/tui-layout.c (show_source_disasm_command, show_data):
6857         Update.
6858         (reset_locator): Remove.
6859         (show_source_or_disasm_and_command): Update.
6860
6861 2019-07-17  Tom Tromey  <tom@tromey.com>
6862
6863         * tui/tui-source.c (tui_source_window_base::reset): Remove
6864         win_type parameter.
6865         * tui/tui-layout.c (make_command_window, make_source_window)
6866         (make_disasm_window, make_data_window)
6867         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6868         (reset_locator, show_source_or_disasm_and_command): Update.
6869         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6870         win_type parameter.
6871         (struct tui_source_window_base) <reset>: Likewise.
6872
6873 2019-07-17  Tom Tromey  <tom@tromey.com>
6874
6875         * tui/tui-layout.c (show_source_disasm_command): Use
6876         reset_locator.
6877         (reset_locator): New function.
6878         (init_and_make_win): Remove.
6879         (show_source_or_disasm_and_command): Use reset_locator.
6880
6881 2019-07-17  Tom Tromey  <tom@tromey.com>
6882
6883         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6884         condition.
6885         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6886         Remove condition.
6887         * tui/tui-source.c (tui_source_window_base::reset): New method.
6888         * tui/tui-layout.c (make_command_window): Don't call
6889         init_and_make_win.
6890         (make_source_window, make_disasm_window): Don't call
6891         make_source_or_disasm_window.
6892         (make_data_window): Don't call init_and_make_win.  Change calling
6893         convention.
6894         (show_source_disasm_command, show_data): Simplify.
6895         (make_source_or_disasm_window): Remove.
6896         (show_source_or_disasm_and_command): Simplify.
6897         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6898         (struct tui_source_window_base) <reset>: Likewise.
6899         <execution_info>: Remove initializer.
6900         * tui/tui-data.c (tui_source_window_base): Initialize
6901         execution_info.
6902
6903 2019-07-17  Tom Tromey  <tom@tromey.com>
6904
6905         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6906         variable.
6907
6908 2019-07-17  Tom Tromey  <tom@tromey.com>
6909
6910         * tui/tui.c (tui_rl_other_window): Update.
6911         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6912         superclass method first.  Always iterate over regs_content.
6913         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6914         method.
6915         * tui/tui-win.c (tui_set_focus_command): Update.
6916
6917 2019-07-17  Tom Tromey  <tom@tromey.com>
6918
6919         * tui/tui-win.c (tui_set_focus_command): Rename from
6920         tui_set_focus.  Call tui_enable.
6921         (tui_set_focus_command): Remove.
6922
6923 2019-07-17  Tom Tromey  <tom@tromey.com>
6924
6925         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6926         refresh_window.
6927         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6928         touchwin.
6929         (tui_data_window::refresh_window): Call refresh_window on data
6930         items.  Always call superclass refresh_window.
6931         (tui_win_info::refresh): Remove.
6932         (tui_source_window_base::refresh_window): Update.
6933         (tui_refresh_all): Update.
6934         * tui/tui-layout.c (show_source_disasm_command): Remove call to
6935         refresh_window.
6936         (show_source_or_disasm_and_command): Likewise.
6937         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
6938         (struct tui_source_window_base) <refresh>: Likewise.
6939
6940 2019-07-17  Tom Tromey  <tom@tromey.com>
6941
6942         * tui/tui-winsource.c (tui_clear_source_content)
6943         (tui_show_source_content): Update.
6944         * tui/tui-source.c (tui_source_window::showing_source_p): Check
6945         whether content is empty.
6946         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
6947         Remove.
6948
6949 2019-07-17  Tom Tromey  <tom@tromey.com>
6950
6951         * tui/tui-winsource.c (tui_erase_source_content): Clear the
6952         window's contents.
6953         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
6954         * tui/tui-source.c (tui_set_source_content_nil): Remove.
6955
6956 2019-07-17  Tom Tromey  <tom@tromey.com>
6957
6958         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
6959         (struct tui_data_item_window): Update.
6960
6961 2019-07-17  Tom Tromey  <tom@tromey.com>
6962
6963         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
6964         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
6965         defines.
6966
6967 2019-07-17  Tom Tromey  <tom@tromey.com>
6968
6969         * tui/tui-winsource.h (tui_erase_source_content)
6970         (tui_clear_source_content): Remove "display_prompt" parameter.
6971         * tui/tui-winsource.c (tui_update_source_window_as_is)
6972         (tui_update_source_windows_with_addr): Update.
6973         (tui_clear_source_content): Remove "display_prompt" parameter.
6974         (tui_erase_source_content): Likewise.  Simplify.
6975         (tui_show_source_content): Update.
6976         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
6977         * tui/tui-stack.c (tui_show_frame_info): Update.
6978         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
6979         Remove defines.
6980
6981 2019-07-17  Tom Tromey  <tom@tromey.com>
6982
6983         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6984         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
6985         parameter.
6986         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
6987         parameter.
6988
6989 2019-07-17  Tom Tromey  <tom@tromey.com>
6990
6991         * tui/tui-winsource.c (tui_clear_source_content)
6992         (tui_show_source_content, tui_show_exec_info_content)
6993         (tui_clear_exec_info_content): Update.
6994         * tui/tui-stack.c (tui_show_locator_content): Update.
6995         (tui_show_frame_info): Update.
6996         * tui/tui-source.h (tui_source_window): Don't declare.
6997         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
6998         from tui_source_is_displayed.
6999         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7000         Remove field.
7001         (struct tui_source_window_base) <content_in_use>: New field.  Now
7002         bool.
7003         (struct tui_source_window) <showing_source_p>: New method.
7004         (TUI_SRC_WIN): Change cast.
7005         * tui/tui-data.c (tui_initialize_static_data): Update.
7006
7007 2019-07-17  Tom Tromey  <tom@tromey.com>
7008
7009         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7010         location_matches_p.
7011         * tui/tui-source.c (tui_source_window::location_matches_p): New
7012         method.
7013         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7014         method.
7015         * tui/tui-data.h (struct tui_source_window_base)
7016         <location_matches_p>: New method.
7017         (struct tui_source_window, struct tui_disasm_window)
7018         <location_matches_p>: Likewise.
7019
7020 2019-07-17  Tom Tromey  <tom@tromey.com>
7021
7022         * tui/tui-win.c (tui_set_win_height_command): Rename from
7023         tui_set_win_height.
7024         (tui_set_win_height_command): Remove.
7025
7026 2019-07-17  Tom Tromey  <tom@tromey.com>
7027
7028         * tui/tui-source.c (tui_source_window): New constructor.  Add
7029         observer.
7030         (~tui_source_window): New destructor.
7031         (tui_source_window::style_changed): New method.
7032         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7033         (tui_attach_detach_observers): Update.
7034         * tui/tui-data.h (struct tui_source_window): Make constructor not
7035         inline.  Add destructor.
7036         (struct tui_source_window) <style_changed>: New method.
7037         <m_observable>: New member.
7038
7039 2019-07-17  Tom Tromey  <tom@tromey.com>
7040
7041         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7042         * tui/tui-win.c (tui_resize_all): Fix typo.
7043
7044 2019-07-17  Tom Tromey  <tom@tromey.com>
7045
7046         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7047         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7048         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7049         * tui/tui-win.c (window_name_completer): Use foreach.
7050         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7051         (update_tab_width): Likewise.
7052         * tui/tui-layout.c (show_layout): Update.
7053         * tui/tui-data.h (class tui_window_iterator): New.
7054         (struct all_tui_windows): New.
7055         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7056
7057 2019-07-17  Tom Tromey  <tom@tromey.com>
7058
7059         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7060         parameter.  Don't reference globals.
7061         (tui_reg_command): Update.
7062
7063 2019-07-17  Tom Tromey  <tom@tromey.com>
7064
7065         * tui/tui-regs.c (tui_show_registers): Simplify.
7066
7067 2019-07-17  Tom Tromey  <tom@tromey.com>
7068
7069         * tui/tui-regs.c (tui_show_registers): Update.
7070         (tui_show_register_group): Add win_info parameter.
7071
7072 2019-07-17  Tom Tromey  <tom@tromey.com>
7073
7074         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7075         Rename from tui_display_reg_element_at_line.
7076         (tui_data_window::display_registers_from_line): Update.
7077         * tui/tui-data.h (struct tui_data_window)
7078         <display_reg_element_at_line>: New method.
7079
7080 2019-07-17  Tom Tromey  <tom@tromey.com>
7081
7082         * tui/tui-regs.h (tui_display_registers_from)
7083         (tui_display_registers_from_line): Don't declare.
7084         * tui/tui-windata.c (tui_data_window::display_all_data)
7085         (tui_data_window::refresh_all)
7086         (tui_data_window::do_scroll_vertical): Update.
7087         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7088         from tui_display_registers_from.
7089         (tui_display_reg_element_at_line): Update.
7090         (tui_data_window::display_registers_from_line): Rename from
7091         tui_display_registers_from_line.
7092         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7093         display_registers_from_line>: New methods.
7094
7095 2019-07-17  Tom Tromey  <tom@tromey.com>
7096
7097         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7098         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7099         from tui_erase_data_content.
7100         (tui_data_window::display_all_data)
7101         (tui_data_window::refresh_all)
7102         (tui_data_window::do_scroll_vertical): Update.
7103         * tui/tui-regs.c (tui_show_registers): Update.
7104         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7105         New method.
7106
7107 2019-07-17  Tom Tromey  <tom@tromey.com>
7108
7109         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7110         declare.
7111         * tui/tui-windata.c
7112         (tui_data_window::delete_data_content_windows): Rename from
7113         tui_delete_data_content_windows.
7114         (tui_data_window::display_all_data)
7115         (tui_data_window::do_scroll_vertical): Update.
7116         * tui/tui-data.h (struct tui_data_window)
7117         <delete_data_content_windows>: New method.
7118
7119 2019-07-17  Tom Tromey  <tom@tromey.com>
7120
7121         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7122         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7123
7124 2019-07-17  Tom Tromey  <tom@tromey.com>
7125
7126         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7127         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7128         from tui_display_all_data.
7129         * tui/tui-win.c
7130         (tui_data_window::do_make_visible_with_new_height): Update.
7131         * tui/tui-regs.c (tui_show_registers): Update.
7132         * tui/tui-layout.c (tui_set_layout): Update.
7133         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7134         method.
7135
7136 2019-07-17  Tom Tromey  <tom@tromey.com>
7137
7138         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7139         * tui/tui-windata.c (tui_display_data_from): Remove.
7140         (tui_data_window::refresh_all): Update.
7141
7142 2019-07-17  Tom Tromey  <tom@tromey.com>
7143
7144         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7145         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7146         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7147         tui_display_registers_from_line.
7148         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7149         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7150         "force_display" parameter.
7151
7152 2019-07-17  Tom Tromey  <tom@tromey.com>
7153
7154         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7155         declare.
7156         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7157         Rename from tui_first_reg_element_no_inline.
7158         (tui_display_reg_element_at_line)
7159         (tui_display_registers_from_line): Update.
7160         * tui/tui-data.h (struct tui_data_window)
7161         <first_reg_element_no_inline>: New method.
7162
7163 2019-07-17  Tom Tromey  <tom@tromey.com>
7164
7165         * tui/tui-windata.c (tui_display_data_from)
7166         (tui_data_window::do_scroll_vertical): Update.
7167         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7168         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7169         Rename from tui_line_from_reg_element_no.
7170         (tui_display_registers_from_line): Update.
7171         * tui/tui-data.h (struct tui_data_window)
7172         <line_from_reg_element_no>: New method.
7173
7174 2019-07-17  Tom Tromey  <tom@tromey.com>
7175
7176         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7177         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7178         tui_last_regs_line_no.
7179         (tui_display_reg_element_at_line)
7180         (tui_display_registers_from_line): Update.
7181         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7182         method.
7183
7184 2019-07-17  Tom Tromey  <tom@tromey.com>
7185
7186         PR tui/24722:
7187         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7188         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7189         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7190         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7191         (tui_update_breakpoint_info): Likewise.
7192         * tui/tui-hooks.c (tui_event_create_breakpoint)
7193         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7194         Update.
7195
7196 2019-07-17  Tom Tromey  <tom@tromey.com>
7197
7198         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7199
7200 2019-07-17  Tom Tromey  <tom@tromey.com>
7201
7202         * tui/tui-winsource.c (tui_update_source_window_as_is)
7203         (tui_update_source_windows_with_addr): Update.
7204         * tui/tui-source.h (tui_set_source_content)
7205         (tui_show_symtab_source): Add "win_info" parameter.
7206         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7207         parameter.
7208         (tui_show_symtab_source): Likewise.
7209
7210 2019-07-17  Tom Tromey  <tom@tromey.com>
7211
7212         * tui/tui-wingeneral.c
7213         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7214
7215 2019-07-17  Tom Tromey  <tom@tromey.com>
7216
7217         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7218         (struct tui_cmd_window) <can_scroll>: New method.
7219         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7220         method.
7221
7222 2019-07-17  Tom Tromey  <tromey@adacore.com>
7223
7224         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7225         do_field_signed>: Rename.  Change type of "value".
7226         * ui-out.c (ui_out::field_signed): Rename from field_int.
7227         Change type of "value".
7228         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7229         type of "value".
7230         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7231         do_field_int.  Change type of "value".
7232         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7233         do_field_int.  Change type of "value".
7234         * tracepoint.c (trace_status_mi, tfind_1)
7235         (print_one_static_tracepoint_marker): Update.
7236         * thread.c (print_thread_info_1, print_selected_thread_frame):
7237         Update.
7238         * stack.c (print_frame, print_frame_info): Update.
7239         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7240         Update.
7241         * source.c (print_source_lines_base): Update.
7242         * skip.c (info_skip_command): Update.
7243         * record-btrace.c (btrace_ui_out_decode_error)
7244         (btrace_call_history_src_line): Update.
7245         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7246         Update.
7247         * progspace.c (print_program_space): Update.
7248         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7249         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7250         do_field_int.  Change type of "value".
7251         * mi/mi-out.c (mi_ui_out::do_table_begin)
7252         (mi_ui_out::do_table_header): Update.
7253         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7254         type of "value".
7255         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7256         (mi_cmd_data_list_changed_registers, output_register)
7257         (mi_cmd_data_read_memory, mi_load_progress)
7258         (mi_cmd_trace_frame_collected): Update.
7259         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7260         Update.
7261         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7262         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7263         (mi_cmd_var_list_children, varobj_update_one): Update.
7264         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7265         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7266         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7267         * inferior.c (print_inferior): Update.
7268         * gdb_bfd.c (print_one_bfd): Update.
7269         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7270         Update.
7271         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7272         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7273         do_field_int.  Change type of "value".
7274         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7275         do_field_int.  Change type of "value".
7276         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7277         (print_one_breakpoint_location, print_it_catch_fork)
7278         (print_one_catch_fork, print_it_catch_vfork)
7279         (print_one_catch_vfork, print_it_catch_solib)
7280         (print_it_catch_exec, print_it_ranged_breakpoint)
7281         (print_mention_watchpoint, print_mention_masked_watchpoint)
7282         (bkpt_print_it, update_static_tracepoint): Update.
7283         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7284         * break-catch-syscall.c (print_it_catch_syscall): Update.
7285         * ada-tasks.c (print_ada_task_info): Update.
7286         * ada-lang.c (print_it_exception, print_mention_exception):
7287         Update.
7288
7289 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7290
7291         PR breakpoints/24541
7292         * gdbarch.c: Regenerate.
7293         * gdbarch.h: Regenerate.
7294         * gdbarch.sh: Adjust return type and parameter types for
7295         'stap_adjust_register'.
7296         (i386_stap_adjust_register): Adjust signature and return new
7297         register name.
7298         * stap-probe.c (stap_parse_register_operand): Adjust use of
7299         'gdbarch_stap_adjust_register'.
7300
7301 2019-07-17  Tom Tromey  <tromey@adacore.com>
7302
7303         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7304         declare VEC.
7305         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7306         std::vector.
7307         (struct s390_process_info): Add initializers.
7308         (s390_add_process): Use new.
7309         (s390_linux_nat_target::low_forget_process): Use delete.
7310         (s390_linux_nat_target::low_new_fork)
7311         (s390_linux_nat_target::stopped_by_watchpoint)
7312         (s390_linux_nat_target::low_prepare_to_resume)
7313         (s390_linux_nat_target::insert_watchpoint)
7314         (s390_linux_nat_target::insert_hw_breakpoint)
7315         (s390_linux_nat_target::remove_watchpoint)
7316         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7317
7318 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7319
7320         * aarch64-fbsd-nat.c: Include regcache.h.
7321         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7322         argument.
7323         (aarch64_fbsd_nat_target::fetch_registers)
7324         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7325         variable.
7326         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7327
7328 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7329
7330         * fbsd-nat.c: Include gdbarch.h.
7331
7332 2019-07-15  Tom Tromey  <tromey@adacore.com>
7333
7334         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7335
7336 2019-07-15  Tom Tromey  <tromey@adacore.com>
7337
7338         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7339         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7340         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7341         * cli-out.c (cli_ui_out::do_field_int): New method.
7342         * ui-out.c (ui_out::field_unsigned): New method.
7343         * symfile.c (generic_load): Use field_unsigned.
7344         (print_transfer_performance): Likewise.
7345         * record-btrace.c (ui_out_field_uint): Remove.
7346         (btrace_call_history_insn_range, btrace_call_history): Use
7347         field_unsigned.
7348         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7349         field_unsigned.
7350         * ui-out.h (class ui_out) <field_unsigned>: New method.
7351         <do_field_unsigned>: Likewise.
7352
7353 2019-07-15  Tom Tromey  <tromey@adacore.com>
7354
7355         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7356         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7357         * target.c (flash_erase_command): Use field_string.
7358         * infrun.c (print_signal_received_reason): Use field_string.
7359         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7360         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7361         field_string.
7362         * ada-tasks.c (print_ada_task_info): Use field_string.
7363
7364 2019-07-15  Tom Tromey  <tromey@adacore.com>
7365
7366         * target.c (flash_erase_command): Use field_core_addr.
7367         * symfile.c (generic_load): Use field_core_addr.
7368         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7369         Use field_core_addr.
7370         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7371         field_core_addr.
7372
7373 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7374
7375         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7376         value if its desired type is smaller than a CORE_ADDR and signed.
7377
7378 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7379
7380         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7381         of changes to field names, and use new is_reference field to
7382         decide if a property is a reference or not.
7383         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7384         field.
7385         (struct dwarf2_property_baton): Update header comment, rename
7386         'referenced_type' to 'property_type' and update comments.
7387         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7388         default property type, store in property baton, update to take
7389         accound of renamed field.
7390         (read_func_scope): Update call to attr_to_dynamic_prop.
7391         (read_array_type): Likewise.
7392         (dwarf2_per_cu_addr_sized_int_type): New function.
7393         (read_subrange_index_type): Move type finding code to
7394         dwarf2_per_cu_addr_sized_int_type.
7395         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7396         (dwarf2_per_cu_addr_type): New function.
7397         (set_die_type): Update calls to attr_to_dynamic_prop.
7398
7399 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7400
7401         * dwarf2read.c (read_subrange_index_type): New function.
7402         (read_subrange_type): Move code into new function and call it.
7403         * gdbtypes.c (create_range_type): Add some asserts.
7404
7405 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7406
7407         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7408         update return statements.
7409         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7410         declaration, and update comment to match.
7411         * gdbtypes.c (resolve_dynamic_array): Update call to
7412         dwarf2_evaluate_property to match new return type.
7413
7414 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7415
7416         * valarith.c (value_subscripted_rvalue): Change lowerbound
7417         parameter type from int to LONGEST.
7418         * value.h (value_subscripted_rvalue): Likewise in declaration.
7419
7420 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7421
7422         * cli/cli-utils.c (info_print_command_completer): New function.
7423         * cli/cli-utils.h: Add 'completer.h' include, and forward
7424         declaration for 'struct cmd_list_element'.
7425         (info_print_command_completer): Declare.
7426         * stack.c (_initialize_stack): Add completer for 'info locals' and
7427         'info args'.
7428         * symtab.c (_initialize_symtab): Add completer for 'info
7429         variables' and 'info functions'.
7430         * NEWS: Mention completion for additional info commands.
7431
7432 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7433
7434         * cli/cli-utils.c (extract_info_print_args): Delete.
7435         (extract_arg_maybe_quoted): Delete.
7436         (info_print_options_defs): New variable.
7437         (make_info_print_options_def_group): New function.
7438         (extract_info_print_options): Define new function.
7439         * cli/cli-utils.h (extract_info_print_args): Delete.
7440         (struct info_print_options): New structure.
7441         (extract_info_print_options): Declare new function.
7442         * stack.c (info_locals_command): Update to use new
7443         extract_info_print_options, also add a header comment.
7444         (info_args_command): Likewise.
7445         * symtab.c (info_variables_command): Likewise.
7446         (info_functions_command): Likewise.
7447
7448 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7449
7450         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7451         to extract string arguments.
7452         * common/common-utils.c (extract_string_maybe_quoted): New function.
7453         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7454
7455 2019-07-11  Tom Tromey  <tromey@adacore.com>
7456
7457         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7458         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7459         * top.h (gdbinit): Don't declare.
7460         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7461         into...
7462         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7463         * top.c (gdb_init): Don't call init_cli_cmds.
7464         (gdbinit): Remove.
7465         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7466
7467 2019-07-11  Tom Tromey  <tromey@adacore.com>
7468
7469         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7470         after it has been moved.
7471
7472 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7473
7474         * valops.c (value_must_coerce_to_target): Change return type to
7475         bool.
7476         * value.h (value_must_coerce_to_target): Likewise.
7477
7478 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7479
7480         * breakpoint.c (is_hardware_watchpoint): Remove
7481         forward-declaration.
7482         (is_masked_watchpoint): Change return type to bool.
7483         (is_tracepoint): Likewise.
7484         (is_breakpoint): Likewise.
7485         (is_hardware_watchpoint): Likewise.
7486         (is_watchpoint): Likewise.
7487         (is_no_memory_software_watchpoint): Likewise.
7488         (is_catchpoint): Likewise.
7489         (breakpoint_1): Make FILTER parameter's return type bool.
7490         is_masked_watchpoint): Change return type to bool.
7491         (save_breakpoints): Make FILTER parameter's return type bool.
7492         * breakpoint.h (is_breakpoint): Change return type to bool.
7493         (is_watchpoint): Likewise.
7494         (is_catchpoint): Likewise.
7495         (is_tracepoint): Likewise.
7496
7497 2019-07-10  Tom Tromey  <tom@tromey.com>
7498
7499         * defs.h: Don't include gdbarch.h.
7500         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7501         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7502         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7503         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7504         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7505         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7506         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7507         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7508         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7509         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7510         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7511         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7512         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7513         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7514         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7515         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7516         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7517         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7518         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7519         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7520         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7521         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7522         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7523         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7524         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7525         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7526         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7527
7528 2019-07-10  Tom Tromey  <tromey@adacore.com>
7529
7530         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7531         * breakpoint.c (init_ada_exception_breakpoint): Register as
7532         bp_catchpoint.
7533         (print_one_breakpoint_location, print_one_breakpoint): Use
7534         is_ada_exception_catchpoint.
7535         * ada-lang.c (class ada_catchpoint_location): Pass
7536         bp_loc_software_breakpoint to bp_location constructor.
7537         (is_ada_exception_catchpoint): New function.
7538
7539 2019-07-10  Tom Tromey  <tromey@adacore.com>
7540
7541         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7542         VEC.
7543         (struct arm_exidx_entry): New method operator<.
7544         (struct arm_exidx_data) <section_maps>: Change type.
7545         (arm_exidx_data_free): Remove.
7546         (arm_exidx_data_key): Change type.  Move lower.
7547         (arm_exidx_new_objfile): Update.
7548         (arm_compare_exidx_entries): Remove.
7549         (arm_find_exidx_entry, _initialize_arm_tdep)
7550
7551 2019-07-10  Tom Tromey  <tromey@adacore.com>
7552
7553         * solib-spu.c (ocl_program_data_key): Change type.
7554         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7555         Update.
7556
7557 2019-07-10  Tom Tromey  <tromey@adacore.com>
7558
7559         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7560         (struct solib_aix_inferior_data) <library_list>: Change type.
7561         (solib_aix_inferior_data_handle): Change type.
7562         (get_solib_aix_inferior_data): Update.
7563         (solib_aix_free_library_list): Remove.
7564         (library_list_start_library): Update.
7565         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7566         return type.
7567         (solib_aix_get_library_list)
7568         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7569         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7570
7571 2019-07-10  Tom Tromey  <tromey@adacore.com>
7572
7573         * solib-dsbt.c (struct dsbt_info): Add initializers.
7574         (solib_dsbt_pspace_data): Change type.
7575         (dsbt_pspace_data_cleanup): Remove.
7576         (get_dsbt_info, _initialize_dsbt_solib): Update.
7577
7578 2019-07-10  Tom Tromey  <tromey@adacore.com>
7579
7580         * spu-tdep.c (spu_overlay_data): Change type.
7581         (spu_get_overlay_table, spu_overlay_new_objfile)
7582         (_initialize_spu_tdep): Update.
7583
7584 2019-07-10  Tom Tromey  <tromey@adacore.com>
7585
7586         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7587         destructor.
7588         (dbx_objfile_data_key): Change type and declare later.
7589         (DBX_SYMFILE_INFO): Rewrite.
7590         * dbxread.c (dbx_objfile_data_key): Change type.
7591         (dbx_symfile_init): Update.
7592         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7593         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7594         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7595
7596 2019-07-10  Tom Tromey  <tromey@adacore.com>
7597
7598         * jit.c (jit_program_space_key): Change type.  Move lower.
7599         (get_jit_program_space_data): Update.
7600         (jit_program_space_data_cleanup): Remove.
7601         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7602         Update.
7603         (struct jit_program_space_data): Add initializers.
7604
7605 2019-07-10  Tom Tromey  <tromey@adacore.com>
7606
7607         * solib-darwin.c (struct darwin_info): Add initializers.
7608         (solib_darwin_pspace_data): Change type.
7609         (darwin_pspace_data_cleanup): Remove.
7610         (get_darwin_info, _initialize_darwin_solib): Update.
7611
7612 2019-07-10  Tom Tromey  <tromey@adacore.com>
7613
7614         * remote-sim.c (struct sim_inferior_data): Add initializers,
7615         constructor, and destructor.
7616         (sim_inferior_data_key): Change type.  Move lower.
7617         (check_for_duplicate_sim_descriptor): Update.
7618         (get_sim_inferior_data): Use new.  Update.
7619         (~sim_inferior_data_cleanup): Rename from
7620         sim_inferior_data_cleanup.  Simplify.
7621         (gdbsim_close_inferior, simulator_command)
7622         (sim_command_completer, _initialize_remote_sim): Update.
7623         (next_pid, INITIAL_PID): Move earlier.
7624
7625 2019-07-10  Tom Tromey  <tromey@adacore.com>
7626
7627         * python/python-internal.h (create_thread_object): Return
7628         gdbpy_ref.
7629         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7630         * python/py-inferior.c (struct threadlist_entry): Add
7631         constructor.
7632         <thread_obj>: Now a gdbpy_ref.
7633         (thread_to_thread_object): Update.
7634         (add_thread_object): Use new.
7635         (delete_thread_object): Use delete.
7636         (infpy_threads): Update.
7637         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7638         GIL.
7639
7640 2019-07-10  Tom Tromey  <tromey@adacore.com>
7641
7642         * valops.c (value_cast): Specialize error message for Ada.
7643
7644 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7645
7646         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7647
7648 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7649
7650         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7651         bpstat_should_step): Return bool, adjust comments.
7652         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7653         bpstat_should_step): Likewise.
7654
7655 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7656
7657         * features/Makefile: Use feature target descriptions for Arm.
7658         * features/arm/arm-core.c: Generate new file.
7659         * features/arm/arm-fpa.c: Likewise.
7660         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7661         * features/arm/arm-m-profile.c: Likewise.
7662         * features/arm/arm-vfpv2.c: Likewise.
7663         * features/arm/arm-vfpv3.c: Likewise.
7664         * features/arm/xscale-iwmmxt.c: Likewise.
7665         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7666
7667 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7668
7669         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7670         ptrace earlier.
7671
7672 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7673
7674         * features/aarch64-pauth.c: Regenerate.
7675
7676 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7677
7678         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7679         bool.
7680         (bpstat_what): Use false instead of 0.
7681
7682 2019-07-09  Pedro Alves  <palves@redhat.com>
7683
7684         * break-catch-throw.c (is_exception_catchpoint): New.
7685         * breakpoint.c (print_one_breakpoint_location): New parameter
7686         'raw_loc'.  Handle it.  Use
7687         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7688         looking at the breakpoint's type.
7689         (print_one_breakpoint): If handling "maint info breakpoints", also
7690         print locations of exception catchpoints.
7691         * breakpoint.h (is_exception_catchpoint): Declare.
7692
7693 2019-07-09  Pedro Alves  <palves@redhat.com>
7694
7695         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7696         "addr" field.
7697         (allocate_location_exception_catchpoint): New.
7698         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7699         (initialize_throw_catchpoint_ops): Install
7700         allocate_location_exception_catchpoint as allocate_location
7701         method.
7702         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7703         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7704         bp_loc_other.
7705         (breakpoint_address_is_meaningful): Delete.
7706         (bl_address_is_meaningful): New.
7707         (breakpoint_locations_match): Adjust comment.
7708         (bp_location_from_bp_type): New, factored out of...
7709         (bp_location::bp_location(breakpoint *)): ... this.
7710         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7711         factored out of...
7712         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7713         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7714         breakpoint_address_is_meaningful.
7715         (bp_locations_compare): Adjust comment.
7716         (update_global_location_list): Use bl_address_is_meaningful
7717         instead of breakpoint_address_is_meaningful.
7718         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7719         explicit.
7720         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7721         * python/py-breakpoint.c (bppy_get_location): No longer check
7722         whether location is null.
7723
7724 2019-07-09  Pedro Alves  <palves@redhat.com>
7725
7726         PR c++/15468
7727         * breakpoint.c (print_one_breakpoint_location): Remove
7728         single-location assert.
7729
7730 2019-07-09  Tom Tromey  <tom@tromey.com>
7731
7732         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7733         * configure: Rebuild.
7734         * configure.ac: Change common to gdbsupport.
7735         * gdbsupport: Rename from common.
7736         * acinclude.m4: Change common to gdbsupport.
7737         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7738         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7739         gdbsupport.
7740         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7741         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7742         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7743         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7744         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7745         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7746         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7747         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7748         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7749         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7750         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7751         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7752         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7753         coff-pe-read.c, command.h, compile/compile-c-support.c,
7754         compile/compile-c.h, compile/compile-cplus-symbols.c,
7755         compile/compile-cplus-types.c, compile/compile-cplus.h,
7756         compile/compile-loc2c.c, compile/compile.c, completer.c,
7757         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7758         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7759         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7760         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7761         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7762         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7763         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7764         features/aarch64-core.c, features/aarch64-fpu.c,
7765         features/aarch64-pauth.c, features/aarch64-sve.c,
7766         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7767         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7768         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7769         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7770         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7771         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7772         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7773         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7774         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7775         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7776         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7777         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7778         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7779         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7780         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7781         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7782         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7783         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7784         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7785         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7786         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7787         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7788         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7789         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7790         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7791         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7792         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7793         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7794         minsyms.c, mips-linux-tdep.c, namespace.h,
7795         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7796         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7797         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7798         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7799         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7800         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7801         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7802         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7803         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7804         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7805         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7806         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7807         procfs.c, producer.c, progspace.h, psymtab.h,
7808         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7809         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7810         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7811         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7812         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7813         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7814         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7815         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7816         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7817         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7818         target-memory.c, target.c, target.h, target/waitstatus.c,
7819         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7820         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7821         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7822         unittests/array-view-selftests.c,
7823         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7824         unittests/common-utils-selftests.c,
7825         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7826         unittests/format_pieces-selftests.c,
7827         unittests/function-view-selftests.c,
7828         unittests/lookup_name_info-selftests.c,
7829         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7830         unittests/mkdir-recursive-selftests.c,
7831         unittests/observable-selftests.c,
7832         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7833         unittests/parse-connection-spec-selftests.c,
7834         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7835         unittests/scoped_fd-selftests.c,
7836         unittests/scoped_mmap-selftests.c,
7837         unittests/scoped_restore-selftests.c,
7838         unittests/string_view-selftests.c, unittests/style-selftests.c,
7839         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7840         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7841         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7842         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7843         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7844         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7845
7846 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7847
7848         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7849         bool value.
7850         (decode_digits_ordinary): Set explicit_line field in sal.
7851         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7852         symtab_and_line that was set on an explicit line number in
7853         assembler code.  Do always update the recorded symtab and line if
7854         we do skip the prologue.
7855
7856 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7857
7858         * breakpoint.c (set_breakpoint_location_function): Remove
7859         explicit_loc parameter.
7860         (momentary_breakpoint_from_master): Update call to
7861         set_breakpoint_location_function.
7862         (add_location_to_breakpoint): Likewise.
7863
7864 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7865
7866         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7867         required features based on default bfd type when no specific bfd
7868         is present.
7869
7870 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7871
7872         * NEWS: Mention that GDB printf and eval commands can now print
7873         C-style and Ada-style convenience var strings without
7874         calling the inferior.
7875         * printcmd.c (printf_c_string): Locally print GDB internal var
7876         instead of transiting via the inferior.
7877         (printf_wide_c_string): Likewise.
7878
7879 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7880
7881         PR breakpoints/25011
7882         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7883
7884 2019-07-04  Tom Tromey  <tom@tromey.com>
7885
7886         PR tui/24724:
7887         * tui/tui-winsource.c (tui_clear_source_content): Update.
7888         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7889         (tui_update_breakpoint_info): Update.
7890         (tui_set_exec_info_content): Update.
7891         * tui/tui-source.c (tui_set_source_content_nil): Update.
7892         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7893         has_break.
7894         * tui/tui-data.h (enum tui_bp_flag): New.
7895         (tui_bp_flags): New enum flags type.
7896         (struct tui_source_element) <break_mode>: Change type.  Rename
7897         from has_break.
7898         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7899         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7900         constants.
7901         * tui/tui-winsource.h: Fix comment.
7902
7903 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7904
7905         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7906         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7907         (store_fpregs_to_thread)
7908         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7909         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7910         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7911         (IWMMXT_REGS_SIZE): Add define.
7912         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7913         (fetch_vfp_regs, store_vfp_regs)
7914         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7915         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7916
7917 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7918
7919         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7920         defines.
7921         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7922         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7923         (ARM_INT_REGISTER_SIZE): ...to this.
7924         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7925         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7926         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7927         (arm_linux_collect_gregset, supply_nwfpe_register)
7928         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7929         defines.
7930         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7931         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7932         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7933         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
7934         (arm_return_in_memory, arm_store_return_value)
7935         (arm_get_longjmp_target, arm_register_g_packet_guesses)
7936         (arm_record_ld_st_multiple): Likewise.
7937         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
7938         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
7939
7940 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7941
7942         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
7943         AARCH64_DISPLACED_MODIFIED_INSNS.
7944         * aarch64-tdep.c (struct aarch64_displaced_step_data)
7945         (aarch64_displaced_step_copy_insn): Likewise.
7946         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7947         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
7948         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
7949         ARM_DISPLACED_MODIFIED_INSNS.
7950         * arm-tdep.c (arm_gdbarch_init): Likewise.
7951         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
7952         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
7953         (struct arm_displaced_step_closure): Use
7954         ARM_DISPLACED_MODIFIED_INSNS.
7955
7956 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7957
7958         * features/Makefile: Remove unused xml files.
7959         * features/aarch64.xml: Remove.
7960         * features/i386/amd64-avx-avx512-linux.xml: Remove.
7961         * features/i386/amd64-avx-avx512.xml: Remove.
7962         * features/i386/amd64-avx-linux.xml: Remove.
7963         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
7964         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
7965         * features/i386/amd64-avx-mpx-linux.xml: Remove.
7966         * features/i386/amd64-avx-mpx.xml: Remove.
7967         * features/i386/amd64-avx.xml: Remove.
7968         * features/i386/amd64-linux.xml: Remove.
7969         * features/i386/amd64-mpx-linux.xml: Remove.
7970         * features/i386/amd64-mpx.xml: Remove.
7971         * features/i386/amd64.xml: Remove.
7972         * features/i386/i386-avx-avx512-linux.xml: Remove.
7973         * features/i386/i386-avx-avx512.xml: Remove.
7974         * features/i386/i386-avx-linux.xml: Remove.
7975         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
7976         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
7977         * features/i386/i386-avx-mpx-linux.xml: Remove.
7978         * features/i386/i386-avx-mpx.xml: Remove.
7979         * features/i386/i386-avx.xml: Remove.
7980         * features/i386/i386-linux.xml: Remove.
7981         * features/i386/i386-mmx-linux.xml: Remove.
7982         * features/i386/i386-mmx.xml: Remove.
7983         * features/i386/i386-mpx-linux.xml: Remove.
7984         * features/i386/i386-mpx.xml: Remove.
7985         * features/i386/i386.xml: Remove.
7986         * features/i386/x32-avx-avx512-linux.xml: Remove.
7987         * features/i386/x32-avx-linux.xml: Remove.
7988         * features/i386/x32-linux.xml: Remove.
7989
7990 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7991
7992         * regformats/aarch64.dat: Remove.
7993         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
7994         * regformats/i386/amd64-avx-linux.dat: Remove.
7995         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
7996         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
7997         * regformats/i386/amd64-linux.dat: Remove.
7998         * regformats/i386/amd64-mpx-linux.dat: Remove.
7999         * regformats/i386/amd64.dat: Remove.
8000         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8001         * regformats/i386/i386-avx-linux.dat: Remove.
8002         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8003         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8004         * regformats/i386/i386-linux.dat: Remove.
8005         * regformats/i386/i386-mmx-linux.dat: Remove.
8006         * regformats/i386/i386-mpx-linux.dat: Remove.
8007         * regformats/i386/i386.dat: Remove.
8008         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8009         * regformats/i386/x32-avx-linux.dat: Remove.
8010         * regformats/i386/x32-linux.dat: Remove.
8011
8012 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8013
8014         * aarch64-tdep.c: Remove xml self tests.
8015         * amd64-linux-tdep.c: Likewise.
8016         * amd64-tdep.c: Likewise.
8017         * i386-linux-tdep.c: Likewise.
8018         * i386-tdep.c: Likewise.
8019
8020 2019-07-03  Pedro Alves  <palves@redhat.com>
8021
8022         PR cli/24732
8023         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8024         (pipe_cmd_option_defs): New.
8025         (make_pipe_cmd_options_def_group): New.
8026         (pipe_command): Use gdb::option::process_options.
8027         (pipe_command_completer): New function.
8028         (_initialize_cli_cmds): Install completer for "pipe" command.
8029
8030 2019-07-03  Pedro Alves  <palves@redhat.com>
8031
8032         * cli/cli-option.c (union option_value) <string>: New field.
8033         (struct option_def_and_value): Add ctor, move ctor, dtor and
8034         use DISABLE_COPY_AND_ASSIGN.
8035         (option_def_and_value::clear_value): New.
8036         (parse_option, save_option_value_in_ctx, get_val_type_str)
8037         (add_setshow_cmds_for_options): Handle var_string.
8038         * cli-option.h (union option_def::var_address) <string>: New
8039         field.
8040         (struct string_option_def): New.
8041         * maint-test-options.c (struct test_options_opts): Add default
8042         ctor and use DISABLE_COPY_AND_ASSIGN.
8043         <string_opt>: New field.
8044         (test_options_opts::~test_options_opts): New.
8045         (test_options_opts::dump): Also dump "-string".
8046         (test_options_option_defs): Install "string.
8047
8048 2019-07-03  Pedro Alves  <palves@redhat.com>
8049
8050         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8051         option_value with a null enumeration.
8052         (complete_options): Save the option values in the context.
8053         (save_option_value_in_ctx): New, factored out from ...
8054         (process_options): ... here.
8055         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8056         of the function.
8057         * maint-test-options.c (test_options_opts::dump): New, factored
8058         out from ...
8059         (maintenance_test_options_command_mode): ... here.
8060         (maintenance_test_options_command_completion_result): Delete.
8061         (maintenance_test_options_command_completion_text): Update
8062         comment.
8063         (maintenance_show_test_options_completion_result): Change
8064         prototype.  Just print
8065         maintenance_test_options_command_completion_text.
8066         (save_completion_result): New.
8067         (maintenance_test_options_completer_mode): Pass options context to
8068         complete_options, and then save a dump.
8069         (_initialize_maint_test_options): Use add_cmd to install "maint
8070         show test-options-completion-result".
8071
8072 2019-07-03  Pedro Alves  <palves@redhat.com>
8073
8074         * NEWS (New commands): Mention "with" and "maint with".
8075         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8076         (with_command, with_command_completer): New.
8077         (pipe_command): Adjust to new repeat_previous
8078         interface.
8079         (_initialize_cli_cmds): Install the "with" command and its "w"
8080         alias.
8081         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8082         declarations.
8083         * cli/cli-setshow.c (parse_cli_var_uinteger)
8084         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8085         argument strings for all var_types.
8086         (get_setshow_command_value_string): New, factored out from ...
8087         (do_show_command): ... this.
8088         * cli/cli-setshow.h: Include <string>.
8089         (get_setshow_command_value_string): Declare.
8090         * command.h (repeat_previous): Now returns const char *.  Adjust
8091         comment.
8092         * maint.c: Include "cli/cli-cmds.h".
8093         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8094         (_initialize_maint_cmds): Register the "maintenance with" command.
8095         * top.c (repeat_previous): Move bits from pipe_command here:
8096         Return the saved command line, if any; error out if there's no
8097         command to relaunch.
8098
8099 2019-07-03  Pedro Alves  <palves@redhat.com>
8100
8101         * NEWS (New commands): Mention "maint set/show test-settings"
8102         instead of "maint test-settings".
8103         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8104         (maintenance_test_settings_set_list): Rename to ...
8105         (maintenance_set_test_settings_list): ... this.
8106         (maintenance_test_settings_show_list): Rename to  ...
8107         (maintenance_show_test_settings_list): ... this.
8108         (maintenance_test_settings_cmd): Delete.
8109         (maintenance_test_settings_set_cmd): ...
8110         (maintenance_set_test_settings_cmd): ... this.
8111         (maintenance_test_settings_show_cmd): ...
8112         (maintenance_show_test_settings_cmd): ... this.
8113         (maintenance_test_settings_show_value_cmd):
8114         (maintenance_show_test_settings_value_cmd): ... this.
8115         (_initialize_maint_test_settings): No longer install the "maint
8116         test-settings" prefix command.  Rename "maint test-settings set"
8117         to "maint set test-settings", and "maint test-settings show" to
8118         "maint show test-settings".  Adjust all subcommands.
8119
8120 2019-07-03  Pedro Alves  <palves@redhat.com>
8121
8122         * maint-test-settings.c: Fix file's intro comment.  Replace all
8123         references to "test-options" with references to "test-settings",
8124         in comments.
8125
8126 2019-07-03  Pedro Alves  <palves@redhat.com>
8127
8128         * maint-test-settings.c (maintenance_test_settings_xxx)
8129         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8130         New.
8131         (maintenance_test_settings_enums): Use them.
8132         (maintenance_test_settings_enum): Default to
8133         maintenance_test_settings_xxx.
8134         (_initialize_maint_test_settings): Initialize
8135         MAINTENANCE_TEST_SETTINGS_FILENAME.
8136
8137 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8138
8139         * breakpoint.h (remove_breakpoints_inf): Change return type to
8140         void, move function documentation here.
8141         * breakpoint.c (remove_breakpoints_inf): Change return type to
8142         void, move function documentation to header.
8143
8144 2019-07-02  Pedro Alves  <palves@redhat.com>
8145
8146         * NEWS (Completion improvements): Mention "info threads".
8147         * thread.c (struct info_threads_opts, info_threads_option_defs)
8148         (make_info_threads_options_def_group): New.
8149         (info_threads_command): Use gdb::option::process_options.
8150         (info_threads_command_completer): New.
8151         (_initialize_thread): Use gdb::option::build_help to build the
8152         help text for "info threads".
8153
8154 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8155
8156         * defs.h (generic_load): Move from here...
8157         * symfile.h (generic_load): ... to here.  Rename name parameter
8158         to args.
8159         * symfile.c (generic_load): Add comment.
8160
8161 2019-07-01  Tom Tromey  <tromey@adacore.com>
8162
8163         * dwarf2read.c
8164         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8165         declaration of without_params.  Fix formatting.
8166
8167 2019-07-01  Tom Tromey  <tromey@adacore.com>
8168
8169         * ada-exp.y (find_primitive_type): Update.
8170         * ada-lang.h (ada_lookup_symbol): Update.
8171         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8172         parameter.
8173         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8174
8175 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8176
8177         PR breakpoints/24541
8178         * gdbarch.c: Regenerate.
8179         * gdbarch.h: Regenerate.
8180         * gdbarch.sh: Add 'stap_adjust_register'.
8181         * i386-tdep.c: Include '<unordered_set>'.
8182         (i386_stap_adjust_register): New function.
8183         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8184         * stap-probe.c (stap_parse_register_operand): Call
8185         'gdbarch_stap_adjust_register'.
8186
8187 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8188
8189         PR python/24742
8190         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8191         * python/python.c (do_start_initialization): Use 'xmalloc'
8192         instead of 'PyMem_Malloc'.
8193
8194 2019-06-28  Tom Tromey  <tromey@adacore.com>
8195
8196         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8197         for Ada.
8198
8199 2019-06-27  Tom Tromey  <tromey@adacore.com>
8200
8201         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8202         objfile_key.
8203         (arm_find_mapping_symbol, arm_record_special_symbol)
8204         (_initialize_arm_tdep): Update.
8205         (arm_objfile_data_free): Remove.
8206
8207 2019-06-27  Tom Tromey  <tromey@adacore.com>
8208
8209         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8210         to cp_print_static_field.
8211
8212 2019-06-26  Tom Tromey  <tromey@adacore.com>
8213
8214         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8215         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8216         declare.
8217
8218 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8219
8220         * features/aarch64-core.c (create_feature_aarch64_core):
8221         Regenerate.
8222         * features/aarch64-core.xml: Add cpsr flags.
8223
8224 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8225
8226         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8227         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8228
8229 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8230
8231         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8232         field.
8233         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8234         use.
8235         (arm_record_special_symbol): Don't insert new symbol in sorted
8236         position, push it at the end.
8237
8238 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8239
8240         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8241         (arm_mapping_symbol_s): Remove.
8242         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8243         (arm_mapping_symbol_vec): New typedef.
8244         (struct arm_per_objfile): Add constructor.
8245         <section_maps>: Change type to
8246         std::unique_ptr<arm_mapping_symbol_vec[]>.
8247         (arm_compare_mapping_symbols): Remove.
8248         (arm_find_mapping_symbol): Adjust to section_maps type change.
8249         (arm_objfile_data_free): Call delete on arm_per_objfile.
8250         (arm_record_special_symbol): Adjust to section_maps type change.
8251         Allocate arm_per_objfile with new.
8252
8253 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8254
8255         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8256         with the command prefix.
8257
8258 2019-06-25  Tom Tromey  <tom@tromey.com>
8259
8260         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8261         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8262
8263 2019-06-25  Tom Tromey  <tom@tromey.com>
8264
8265         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8266         type.
8267         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8268         protected.
8269
8270 2019-06-25  Tom Tromey  <tom@tromey.com>
8271
8272         * tui/tui-winsource.c
8273         (tui_source_window_base::set_is_exec_point_at): Add check against
8274         LOA_ADDRESS.
8275
8276 2019-06-25  Tom Tromey  <tom@tromey.com>
8277
8278         * tui/tui-source.c (tui_set_source_content): Don't check before
8279         xfree.
8280         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8281
8282 2019-06-25  Tom Tromey  <tom@tromey.com>
8283
8284         * tui/tui-winsource.h (tui_update_source_window_as_is)
8285         (tui_alloc_source_buffer, tui_line_is_displayed)
8286         (tui_addr_is_displayed): Change type of win_info.
8287         * tui/tui-winsource.c (tui_update_source_window_as_is)
8288         (tui_clear_source_content, tui_show_source_line)
8289         (tui_show_source_content, tui_source_window_base::refill)
8290         (tui_source_window_base::set_is_exec_point_at)
8291         (tui_source_window_base::set_is_exec_point_at)
8292         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8293         (tui_alloc_source_buffer, tui_line_is_displayed)
8294         (tui_addr_is_displayed): Change type of win_info.  Update.
8295         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8296         (tui_source_window_base::do_make_visible_with_new_height):
8297         Update.
8298         * tui/tui-source.c (tui_set_source_content)
8299         (tui_set_source_content_nil)
8300         (tui_source_window::do_scroll_vertical): Update.
8301         * tui/tui-layout.c (show_layout): Update.
8302         * tui/tui-disasm.c (tui_set_disassem_content)
8303         (tui_disasm_window::do_scroll_vertical): Update.
8304         * tui/tui-data.h (tui_win_content): Remove.
8305         (struct tui_gen_win_info) <content, content_size>: Remove.
8306         (struct tui_source_element): Add initializers and destructor.
8307         (union tui_which_element, struct tui_win_element): Remove.
8308         (struct tui_source_window_base) <content>: New field.
8309         (struct tui_data_window): Remove destructor.
8310         (tui_alloc_content, tui_free_win_content)
8311         (tui_free_all_source_wins_content): Don't declare.
8312         * tui/tui-data.c (tui_initialize_static_data): Update.
8313         (init_content_element, tui_alloc_content): Remove.
8314         (~tui_gen_win_info): Update.
8315         (~tui_data_window, tui_free_all_source_wins_content)
8316         (tui_free_win_content, free_content, free_content_elements):
8317         Remove.
8318
8319 2019-06-25  Tom Tromey  <tom@tromey.com>
8320
8321         * tui/tui-winsource.h (tui_clear_source_content)
8322         (tui_erase_source_content, tui_show_source_content): Change type
8323         of win_info.
8324         * tui/tui-winsource.c (tui_clear_source_content)
8325         (tui_erase_source_content, tui_show_source_content): Change type
8326         of win_info.
8327         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8328         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8329         win_info.
8330         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8331         win_info.
8332         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8333
8334 2019-06-25  Tom Tromey  <tom@tromey.com>
8335
8336         * tui/tui-winsource.c (tui_clear_source_content)
8337         (tui_source_window_base::set_is_exec_point_at): Update.
8338         * tui/tui-source.c (tui_set_source_content_nil): Update.
8339         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8340         a bool.
8341         * tui/tui-data.c (init_content_element): Update.
8342
8343 2019-06-25  Tom Tromey  <tom@tromey.com>
8344
8345         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8346         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8347         * tui/tui-layout.c (init_and_make_win): Update.
8348         * tui/tui.h (enum tui_win_type): Update.
8349         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8350         tui_win_is_auxillary.
8351         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8352         tui_win_is_auxillary.
8353
8354 2019-06-25  Tom Tromey  <tom@tromey.com>
8355
8356         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8357         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8358         (tui_delete_data_content_windows, tui_display_all_data)
8359         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8360         Update.
8361         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8362         * tui/tui-regs.c (tui_last_regs_line_no)
8363         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8364         (tui_show_registers): Update.
8365         (tui_show_register_group): Return void.  Update.
8366         (tui_display_registers_from, tui_display_reg_element_at_line)
8367         (tui_display_registers_from_line, tui_check_register_values):
8368         Update.
8369         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8370         member.
8371         (struct tui_data_window) <regs_content>: Now a std::vector.
8372         <regs_content_count>: Remove.
8373         (tui_add_content_elements, tui_free_data_content): Don't declare.
8374         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8375         (init_content_element): Remove DATA_WIN case.  Add assert.
8376         (tui_add_content_elements): Remove.
8377         (tui_data_window): Update.
8378         (tui_free_data_content): Remove.
8379         (free_content_elements): Remove DATA_WIN case.
8380
8381 2019-06-25  Tom Tromey  <tom@tromey.com>
8382
8383         * tui/tui-data.c (tui_data_item_window): Update.
8384         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8385         * tui/tui-windata.c (tui_display_all_data)
8386         (tui_display_data_from_line): Update.
8387         (tui_check_data_values): Remove.
8388         * tui/tui-regs.c (tui_show_register_group)
8389         (tui_display_reg_element_at_line): Update.
8390         * tui/tui-hooks.c (tui_register_changed)
8391         (tui_refresh_frame_and_register_information): Call
8392         tui_check_register_values.
8393         * tui/tui-data.h (struct tui_data_window) <data_content,
8394         data_content_count, data_type>: Remove.
8395         (enum tui_data_type): Remove.
8396
8397         * tui/tui-data.c (tui_data_window::clear_detail)
8398         (~tui_data_window): Update.
8399
8400 2019-06-25  Tom Tromey  <tom@tromey.com>
8401
8402         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8403         declare.
8404         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8405         Rename from tui_first_data_item_displayed.  Update.
8406         (tui_data_window::refresh_all)
8407         (tui_data_window::do_scroll_vertical): Update.
8408         * tui/tui-data.h (struct tui_data_window)
8409         <first_data_item_displayed>: Declare new method.
8410
8411 2019-06-25  Tom Tromey  <tom@tromey.com>
8412
8413         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8414         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8415         contents...
8416         (tui_initialize_static_data): ...here.
8417
8418 2019-06-25  Tom Tromey  <tom@tromey.com>
8419
8420         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8421         (tui_display_registers_from, tui_check_register_values): Update.
8422         (tui_display_register): Remove win_info parameter; update.
8423         (tui_get_register): Change type of parameters.
8424         * tui/tui-data.h (struct tui_data_element): Remove.
8425         (union tui_which_element) <data>: Remove.
8426         <data_window>: Change type.
8427         (struct tui_data_item_window): New.
8428         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8429         case.  Add assert.
8430         (~tui_data_item_window): New destructor.
8431         (free_content_elements): Remove DATA_ITEM_WIN case.
8432
8433 2019-06-25  Tom Tromey  <tom@tromey.com>
8434
8435         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8436         Remove.
8437
8438 2019-06-25  Tom Tromey  <tom@tromey.com>
8439
8440         * tui/tui-data.h (struct tui_command_element): Remove.
8441         (union tui_which_element) <command>: Remove.
8442         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8443         assert.
8444         (free_content_elements): Remove CMD_WIN case.
8445
8446 2019-06-25  Tom Tromey  <tom@tromey.com>
8447
8448         * tui/tui-layout.c (tui_set_layout): Update.
8449         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8450         * tui/tui-data.c (layout_def): Update.
8451
8452 2019-06-25  Tom Tromey  <tom@tromey.com>
8453
8454         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8455         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8456         (tui_source_window_base::set_new_height): Update.
8457         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8458         Update.
8459         (tui_set_locator_fullname, tui_set_locator_info)
8460         (tui_show_frame_info): Update.
8461         * tui/tui-source.c (tui_set_source_content)
8462         (tui_source_is_displayed): Update.
8463         * tui/tui-layout.c (show_source_disasm_command, show_data)
8464         (show_source_or_disasm_and_command): Update.
8465         * tui/tui-disasm.c (tui_set_disassem_content)
8466         (tui_get_begin_asm_address): Update.
8467         * tui/tui-data.h (struct tui_locator_element): Remove.
8468         (union tui_which_element) <locator>: Remove.
8469         (struct tui_locator_window): New.
8470         (tui_locator_win_info_ptr): Change return type.
8471         * tui/tui-data.c (_locator): Change type.
8472         (tui_locator_win_info_ptr): Change return type.
8473         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8474         (tui_alloc_content): Add assert.
8475
8476 2019-06-25  Tom Tromey  <tom@tromey.com>
8477
8478         * tui/tui-winsource.c
8479         (tui_exec_info_window::maybe_allocate_content): New method.
8480         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8481         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8482         (make_source_or_disasm_window): Add cast.
8483         * tui/tui-data.h (union tui_which_element) <simple_string>:
8484         Remove.
8485         (struct tui_source_info): New.
8486         (struct tui_source_window_base) <execution_info>: Change type.
8487         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8488         case, and add assert.
8489         (tui_alloc_content): Add assert.
8490
8491 2019-06-25  Tom Tromey  <tom@tromey.com>
8492
8493         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8494         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8495         * tui/tui-data.c (tui_alloc_win_info): Remove.
8496
8497 2019-06-25  Tom Tromey  <tom@tromey.com>
8498
8499         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8500         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8501         can_highlight.
8502
8503 2019-06-25  Tom Tromey  <tom@tromey.com>
8504
8505         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8506         make_visible_with_new_height method.
8507         (tui_win_info::make_visible_with_new_height): New method.
8508         (tui_source_window_base::do_make_visible_with_new_height)
8509         (tui_data_window::do_make_visible_with_new_height)
8510         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8511         (make_visible_with_new_height): Remove.
8512         (tui_resize_all, tui_adjust_win_heights): Use
8513         make_visible_with_new_height method.
8514         * tui/tui-data.h (struct tui_win_info)
8515         <do_make_visible_with_new_height, make_visible_with_new_height>:
8516         New methods.
8517         (struct tui_source_window_base, struct tui_data_window)
8518         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8519         methods.
8520
8521 2019-06-25  Tom Tromey  <tom@tromey.com>
8522
8523         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8524         method.
8525         (update_tab_width): Call update_tab_width method.
8526         * tui/tui-data.h (struct tui_win_info)
8527         (struct tui_source_window_base) <update_tab_width>: New methods.
8528
8529 2019-06-25  Tom Tromey  <tom@tromey.com>
8530
8531         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8532         parameter.
8533         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8534         parameter.
8535         (tui_gen_win_info::make_visible): Update.
8536         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8537         parameter.
8538         * tui/tui-data.h (enum tui_box): New enum.
8539         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8540
8541 2019-06-25  Tom Tromey  <tom@tromey.com>
8542
8543         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8544         init_and_make_win for EXEC_INFO_WIN.
8545         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8546         longer inline.
8547         (struct tui_win_info) <~tui_win_info>: Inline.
8548         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8549         Don't declare.
8550         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8551         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8552         Remove.
8553         (tui_initialize_static_data): Update.
8554         (~tui_gen_win_info): Handle more cleanup here.
8555         (~tui_source_window_base): Delete "execution_info".
8556         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8557
8558 2019-06-25  Tom Tromey  <tom@tromey.com>
8559
8560         * tui/tui-layout.c (make_command_window): Don't set
8561         can_highlight.
8562         (show_source_disasm_command): Call the reset method.
8563         (show_data): Don't set can_highlight.  Call the reset method.
8564         (tui_gen_win_info::reset): Rename from init_gen_win_info
8565         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8566         (show_source_or_disasm_and_command): Call the reset method.
8567         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8568         (struct tui_cmd_window): Set can_highlight.
8569
8570 2019-06-25  Tom Tromey  <tom@tromey.com>
8571
8572         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8573         from make_visible.
8574         (tui_make_visible, tui_make_invisible): Rewrite.
8575         (tui_win_info::make_visible): Remove.
8576         (tui_source_window_base::make_visible): Update.
8577         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8578         method.  Moved from...
8579         (struct tui_win_info) <make_visible>: ...here.
8580
8581 2019-06-25  Tom Tromey  <tom@tromey.com>
8582
8583         * tui/tui-winsource.c
8584         (tui_source_window_base::do_scroll_horizontal): Remove direction
8585         parameter.
8586         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8587         direction parameter.
8588         * tui/tui-win.c (tui_win_info::forward_scroll)
8589         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8590         (tui_win_info::right_scroll): Update.
8591         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8592         direction parameter.
8593         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8594         direction parameter.
8595         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8596         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8597         Remove direction parameter.
8598         (struct tui_source_window_base, struct tui_source_window)
8599         (struct tui_disasm_window, struct tui_data_window)
8600         (struct tui_cmd_window): Update.
8601
8602 2019-06-25  Tom Tromey  <tom@tromey.com>
8603
8604         * tui/tui-winsource.h (tui_set_exec_info_content)
8605         (tui_show_exec_info_content, tui_erase_exec_info_content)
8606         (tui_clear_exec_info_content, tui_update_exec_info): Change
8607         argument to tui_source_window_base.
8608         * tui/tui-winsource.c (tui_set_exec_info_content)
8609         (tui_show_exec_info_content, tui_erase_exec_info_content)
8610         (tui_clear_exec_info_content, tui_update_exec_info): Change
8611         argument to tui_source_window_base.
8612
8613 2019-06-25  Tom Tromey  <tom@tromey.com>
8614
8615         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8616         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8617
8618 2019-06-25  Tom Tromey  <tom@tromey.com>
8619
8620         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8621         check.
8622
8623 2019-06-25  Tom Tromey  <tom@tromey.com>
8624
8625         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8626         type to void.
8627         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8628         type to void.
8629         * tui/tui-source.c (tui_set_source_content): Update.
8630         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8631
8632 2019-06-25  Tom Tromey  <tom@tromey.com>
8633
8634         * tui/tui-win.c (window_name_completer, tui_set_focus)
8635         (tui_all_windows_info): Use name method.
8636         * tui/tui-data.h (struct tui_gen_win_info)
8637         (struct tui_source_window, struct tui_disasm_window)
8638         (struct tui_data_window, struct tui_cmd_window) <name>: New
8639         method.
8640         (tui_win_name): Don't declare.
8641         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8642         (tui_win_name): Remove.
8643
8644 2019-06-25  Tom Tromey  <tom@tromey.com>
8645
8646         * tui/tui-winsource.h (tui_update_source_window)
8647         (tui_update_source_window_as_is): Change parameter type.
8648         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8649         to be a tui_source_window_base.
8650         (tui_update_source_window_as_is): Likewise.
8651         * tui/tui-win.c (make_visible_with_new_height): Update.
8652
8653 2019-06-25  Tom Tromey  <tom@tromey.com>
8654
8655         * tui/tui-winsource.c (tui_erase_source_content)
8656         (tui_show_source_content, tui_show_exec_info_content)
8657         (tui_erase_exec_info_content): Use refresh_window method.
8658         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8659         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8660         from tui_refresh_win.
8661         (tui_data_window::refresh_window): New method.
8662         (tui_win_info::refresh, tui_source_window_base::refresh)
8663         (tui_refresh_all): Use refresh_window method.
8664         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8665         method.
8666         * tui/tui-regs.c (tui_display_register): Call refresh_window
8667         method.
8668         * tui/tui-layout.c (show_source_disasm_command)
8669         (show_source_or_disasm_and_command): Call refresh_window method.
8670         * tui/tui-data.h (struct tui_gen_win_info)
8671         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8672         New method.
8673
8674 2019-06-25  Tom Tromey  <tom@tromey.com>
8675
8676         * tui/tui.c (tui_rl_other_window, tui_enable)
8677         (tui_is_window_visible, tui_get_command_dimension): Update.
8678         * tui/tui-winsource.c (tui_update_source_window_as_is)
8679         (tui_clear_source_content, tui_erase_source_content)
8680         (tui_show_source_line, tui_source_window_base::refill)
8681         (tui_source_window_base::do_scroll_horizontal)
8682         (tui_source_window_base::set_is_exec_point_at)
8683         (tui_update_breakpoint_info, tui_set_exec_info_content)
8684         (tui_alloc_source_buffer, tui_line_is_displayed)
8685         (tui_addr_is_displayed): Update.
8686         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8687         (tui_check_and_display_highlight_if_needed)
8688         (tui_win_info::make_visible, tui_win_info::refresh)
8689         (tui_refresh_all): Update.
8690         * tui/tui-windata.c (tui_first_data_item_displayed)
8691         (tui_delete_data_content_windows, tui_erase_data_content)
8692         (tui_display_all_data, tui_data_window::refresh_all)
8693         (tui_check_data_values): Update.
8694         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8695         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8696         (tui_win_info::backward_scroll, tui_refresh_all_win)
8697         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8698         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8699         (tui_source_window_base::set_new_height)
8700         (tui_data_window::set_new_height)
8701         (make_invisible_and_set_new_height)
8702         (make_visible_with_new_height, new_height_ok)
8703         (parse_scrolling_args): Update.
8704         * tui/tui-stack.c (tui_show_frame_info): Update.
8705         * tui/tui-source.c (tui_set_source_content)
8706         (tui_set_source_content_nil, tui_source_is_displayed)
8707         (tui_source_window::do_scroll_vertical): Update.
8708         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8709         (tui_display_registers_from, tui_display_reg_element_at_line)
8710         (tui_check_register_values, tui_reg_command): Update.
8711         * tui/tui-layout.c (tui_default_win_height)
8712         (show_source_disasm_command, show_data, init_and_make_win)
8713         (show_source_or_disasm_and_command): Update.
8714         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8715         (tui_redisplay_readline, tui_mld_flush)
8716         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8717         (tui_getc): Update.
8718         * tui/tui-disasm.c (tui_set_disassem_content)
8719         (tui_disasm_window::do_scroll_vertical): Update.
8720         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8721         Now virtual.
8722         (struct tui_win_info): Derive from tui_gen_win_info.
8723         <~tui_win_info>: Mark as override.
8724         <generic>: Remove member.
8725         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8726         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8727         (~tui_data_window, ~tui_win_info)
8728         (tui_free_all_source_wins_content): Update.
8729         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8730
8731 2019-06-25  Tom Tromey  <tom@tromey.com>
8732
8733         * tui/tui-layout.c (init_and_make_win): Use new.
8734         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8735         destructor, initializers.
8736         (tui_alloc_generic_win_info): Don't declare.
8737         * tui/tui-data.c (_locator): Add argument to constructor.
8738         (source_win, disasm_win): New globals.
8739         (exec_info): Remove.
8740         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8741         Update.
8742         (tui_alloc_generic_win_info): Remove.
8743         (init_content_element): Use new.
8744         (tui_win_info::tui_win_info): Update.
8745         (free_content_elements) <case DATA_WIN>: Use delete.
8746
8747 2019-06-25  Tom Tromey  <tom@tromey.com>
8748
8749         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8750         * tui/tui-windata.c (tui_first_data_item_displayed)
8751         (tui_delete_data_content_windows): Update.
8752         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8753         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8754         (tui_display_registers_from, tui_check_register_values): Update.
8755         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8756         pointer.
8757         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8758         window.
8759         (tui_free_data_content): Update.
8760         (free_content_elements) <case DATA_WIN>: Free the window.
8761
8762 2019-06-25  Tom Tromey  <tom@tromey.com>
8763
8764         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8765         Update.
8766         * tui/tui-layout.c (make_command_window)
8767         (show_source_disasm_command, show_data, init_and_make_win)
8768         (show_source_or_disasm_and_command): Update.
8769         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8770         method.
8771         <can_highight, is_highlighted>: Now bool.
8772         (tui_set_win_highlight): Don't declare.
8773         * tui/tui-data.c (tui_set_win_highlight): Remove.
8774
8775 2019-06-25  Tom Tromey  <tom@tromey.com>
8776
8777         * tui/tui-wingeneral.c (make_visible): Remove check of window
8778         type.
8779
8780 2019-06-25  Tom Tromey  <tom@tromey.com>
8781
8782         * tui/tui-win.c (tui_win_info::max_height)
8783         (tui_cmd_window::max_height): New methods.
8784         (new_height_ok): Call max_height.
8785         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8786         <max_height>: New method.
8787
8788 2019-06-25  Tom Tromey  <tom@tromey.com>
8789
8790         * tui/tui-win.c (tui_source_window_base::set_new_height)
8791         (tui_data_window::set_new_height): New methods.
8792         (make_invisible_and_set_new_height): Call set_new_height method.
8793         * tui/tui-data.h (struct tui_win_info)
8794         (struct tui_source_window_base, struct tui_data_window)
8795         <set_new_height>: New method.
8796
8797 2019-06-25  Tom Tromey  <tom@tromey.com>
8798
8799         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8800         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8801         tui_refresh_data_win.
8802         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8803         method.
8804         (tui_refresh_all_win): Call the refresh_all method.
8805         (tui_set_focus): Likewise.
8806         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8807         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8808         Likewise.
8809
8810 2019-06-25  Tom Tromey  <tom@tromey.com>
8811
8812         * tui/tui-winsource.h (tui_refill_source_window)
8813         (tui_set_is_exec_point_at): Don't declare.
8814         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8815         (tui_source_window_base::refill): Rename from
8816         tui_refill_source_window.
8817         (tui_source_window_base::do_scroll_horizontal): Update.
8818         (tui_source_window_base::set_is_exec_point_at): Rename from
8819         tui_set_is_exec_point_at.
8820         (tui_update_all_breakpoint_info): Update.
8821         * tui/tui-stack.c (tui_show_frame_info): Update.
8822         * tui/tui-layout.c (show_data): Add cast.
8823         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8824         * tui/tui-data.h (struct tui_source_window_base) <refill,
8825         set_is_exec_point_at>: New methods.
8826         (tui_source_windows, tui_add_to_source_windows): Update types.
8827         (tui_add_to_source_windows): Remove redundant declaration.
8828         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8829         (tui_source_windows): Change return type.
8830         (tui_clear_source_windows_detail): Update.
8831         (tui_add_to_source_windows): Change type of parameter.
8832         (tui_free_all_source_wins_content): Update.
8833
8834 2019-06-25  Tom Tromey  <tom@tromey.com>
8835
8836         * tui/tui-wingeneral.c (tui_win_info::refresh)
8837         (tui_source_window_base::refresh): New methods.
8838         (tui_refresh_all): Call the refresh method.
8839         * tui/tui-data.h (struct tui_win_info)
8840         (struct tui_source_window_base) <refresh>: New method.
8841
8842 2019-06-25  Tom Tromey  <tom@tromey.com>
8843
8844         * tui/tui.h (tui_is_window_visible): Return bool.
8845         * tui/tui.c (tui_is_window_visible): Return bool.
8846         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8847         (tui_make_visible, tui_make_invisible)
8848         (tui_win_info::make_visible)
8849         (tui_source_window_base::make_visible, make_all_visible)
8850         (tui_make_all_visible, tui_make_all_invisible): Update.
8851         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8852         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8853         bool.
8854         (struct tui_win_info, struct tui_source_window_base)
8855         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8856         * tui/tui-data.c (tui_init_generic_part): Update.
8857
8858 2019-06-25  Tom Tromey  <tom@tromey.com>
8859
8860         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8861         (tui_source_window_base::make_visible): New methods.
8862         (make_all_visible): Make method call.
8863         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8864         (struct tui_source_window_base, struct tui_cmd_window): Override
8865         make_visible.
8866         (tui_win_is_source_type): Don't declare.
8867         * tui/tui-data.c (tui_win_is_source_type): Remove.
8868
8869 2019-06-25  Tom Tromey  <tom@tromey.com>
8870
8871         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8872         NULL check.
8873
8874 2019-06-25  Tom Tromey  <tom@tromey.com>
8875
8876         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8877         Inline constructor.  Add initializers for members.
8878         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8879         constructors; now inline in class.
8880
8881 2019-06-25  Tom Tromey  <tom@tromey.com>
8882
8883         * tui/tui-regs.c (tui_show_registers): Update.
8884         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8885         bool.
8886         * tui/tui-data.c (tui_data_window::clear_detail)
8887         (tui_data_window): Update.
8888
8889 2019-06-25  Tom Tromey  <tom@tromey.com>
8890
8891         * tui/tui-windata.c (tui_display_all_data)
8892         (tui_display_data_from_line, tui_display_data_from)
8893         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8894         Update.
8895         * tui/tui-regs.c (tui_last_regs_line_no)
8896         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8897         (tui_show_registers, tui_show_register_group)
8898         (tui_display_registers_from, tui_display_reg_element_at_line)
8899         (tui_display_registers_from_line, tui_check_register_values)
8900         (tui_reg_next, tui_reg_prev): Update.
8901         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8902         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8903         tui_data_window.
8904         (struct tui_win_info) <detail>: Remove.  Add new fields from
8905         tui_data_info.
8906         (TUI_DATA_WIN): Add cast.
8907         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8908         (~tui_data_window): Simplify.
8909
8910 2019-06-25  Tom Tromey  <tom@tromey.com>
8911
8912         * tui/tui-layout.c (show_source_disasm_command)
8913         (show_source_or_disasm_and_command): Update.
8914         * tui/tui-io.c (update_cmdwin_start_line)
8915         (tui_redisplay_readline): Update.
8916         * tui/tui-data.h (struct tui_command_info): Remove.
8917         (struct tui_win_info) <detail>: Remove command_info member.
8918         (struct tui_data_window) <start_line>: New member, from
8919         tui_command_info.
8920         (TUI_CMD_WIN): Add casts.
8921
8922 2019-06-25  Tom Tromey  <tom@tromey.com>
8923
8924         * tui/tui-winsource.c (tui_update_source_window)
8925         (tui_refill_source_window)
8926         (tui_source_window_base::do_scroll_horizontal)
8927         (tui_update_breakpoint_info, tui_set_exec_info_content)
8928         (tui_show_exec_info_content, tui_erase_exec_info_content)
8929         (tui_clear_exec_info_content): Update.
8930         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8931         Update.
8932         * tui/tui-win.c (make_invisible_and_set_new_height)
8933         (make_visible_with_new_height): Update.
8934         * tui/tui-source.c (tui_set_source_content)
8935         (tui_show_symtab_source): Update.
8936         * tui/tui-layout.c (extract_display_start_addr)
8937         (show_source_disasm_command, show_data)
8938         (make_source_or_disasm_window)
8939         (show_source_or_disasm_and_command): Update.
8940         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
8941         (tui_disasm_window::do_scroll_vertical): Remove shadowing
8942         "gdbarch".
8943         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
8944         to tui_source_window_base.
8945         (struct tui_win_info) <detail>: Remove source_info member.
8946         (struct tui_source_window_base) <has_locator>: Inline.
8947         Move contents from tui_source_info; rename has_locator member to
8948         m_has_locator.
8949         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
8950         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
8951         header file.
8952         (tui_source_window_base::clear_detail, ~tui_source_window_base):
8953         Simplify.
8954         (tui_free_all_source_wins_content): Cast to
8955         tui_source_window_base.
8956
8957 2019-06-25  Tom Tromey  <tom@tromey.com>
8958
8959         * tui/tui-win.c (make_invisible_and_set_new_height)
8960         (make_visible_with_new_height): Call has_locator method.
8961         * tui/tui-layout.c (show_source_disasm_command, show_data)
8962         (show_source_or_disasm_and_command): Update for bool change.
8963         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
8964         (tui_win_info) <has_locator>: New method.
8965         (struct tui_source_window_base) <has_locator>: New method.
8966         (tui_win_has_locator): Don't declare.
8967         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
8968         from tui_win_has_locator.
8969         (tui_source_window_base): Use false, not FALSE.
8970
8971 2019-06-25  Tom Tromey  <tom@tromey.com>
8972
8973         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
8974         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
8975         clear_detail method directly.
8976         (tui_clear_win_detail): Remove.
8977
8978 2019-06-25  Tom Tromey  <tom@tromey.com>
8979
8980         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
8981         "this", not TUI_DISASM_WIN.
8982
8983 2019-06-25  Tom Tromey  <tom@tromey.com>
8984
8985         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
8986         declare.
8987         * tui/tui-winsource.c
8988         (tui_source_window_base::do_scroll_horizontal): Rename from
8989         tui_horizontal_source_scroll.
8990         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
8991         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
8992         from tui_vertical_data_scroll.
8993         * tui/tui-win.h (tui_scroll): Don't declare.
8994         * tui/tui-win.c (tui_win_info::forward_scroll)
8995         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8996         (tui_win_info::right_scroll): Rename and update.
8997         (tui_scroll_forward_command, tui_scroll_backward_command)
8998         (tui_scroll_left_command, tui_scroll_right_command): Update.
8999         (tui_scroll): Remove.
9000         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9001         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9002         from tui_vertical_source_scroll.
9003         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9004         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9005         from tui_vertical_disassem_scroll.
9006         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9007         do_scroll_horizontal>: New methods.
9008         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9009         Likewise.
9010         (struct tui_source_window_base): Add do_scroll_horizontal.
9011         (struct tui_source_window, struct tui_disasm_window): Add
9012         do_scroll_vertical.
9013         (struct tui_data_window, struct tui_cmd_window): Add
9014         do_scroll_horizontal and do_scroll_vertical.
9015         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9016
9017 2019-06-25  Tom Tromey  <tom@tromey.com>
9018
9019         * tui/tui-data.h (struct tui_source_window_base): New struct.
9020         (struct tui_source_window): Derive from tui_source_window_base.
9021         (struct tui_disasm_window): New struct.
9022         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9023         from tui_source_window::clear_detail.
9024         (tui_source_window_base): Rename from tui_source_window.
9025         (~tui_source_window_base): Rename from ~tui_source_window.
9026         (tui_alloc_win_info): Create a tui_disasm_window.
9027
9028 2019-06-25  Tom Tromey  <tom@tromey.com>
9029
9030         * tui/tui-data.h (struct tui_source_window)
9031         (struct tui_data_window): Declare destructors.
9032         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9033         destructors.
9034         (tui_win_info): Simplify.
9035
9036 2019-06-25  Tom Tromey  <tom@tromey.com>
9037
9038         * tui/tui-winsource.c (tui_display_main)
9039         (tui_update_source_windows_with_addr)
9040         (tui_update_all_breakpoint_info): Update.
9041         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9042         (new_height_ok, parse_scrolling_args): Update.
9043         * tui/tui-stack.c (tui_show_frame_info): Update.
9044         * tui/tui-data.h (struct tui_list): Remove.
9045         (tui_source_windows): Return a reference to a std::vector.
9046         * tui/tui-data.c (source_windows): Now a std::vector.
9047         (tui_source_windows): Change return type.
9048         (tui_clear_source_windows): Rewrite.
9049         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9050         (tui_free_all_source_wins_content): Rewrite.
9051
9052 2019-06-25  Tom Tromey  <tom@tromey.com>
9053
9054         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9055         (struct tui_data_window, struct tui_cmd_window): Declare
9056         clear_detail method.
9057         * tui/tui-data.c (tui_source_window::clear_detail)
9058         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9059         methods.
9060         (tui_clear_win_detail): Simplify.
9061
9062 2019-06-25  Tom Tromey  <tom@tromey.com>
9063
9064         * tui/tui-layout.c (make_source_window, make_disasm_window)
9065         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9066         Return the new window.
9067         (show_source_disasm_command, show_data)
9068         (show_source_or_disasm_and_command): Update.
9069
9070 2019-06-25  Tom Tromey  <tom@tromey.com>
9071
9072         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9073         parameter.  Return the new window.
9074         (show_source_disasm_command): Update and remove NULL check.
9075         (show_source_or_disasm_and_command): Update.
9076
9077 2019-06-25  Tom Tromey  <tom@tromey.com>
9078
9079         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9080
9081 2019-06-25  Tom Tromey  <tom@tromey.com>
9082
9083         * tui/tui-data.h (struct tui_win_info): Make constructor
9084         protected.  Make destructor virtual.  Add initializers.
9085         (tui_source_window, tui_data_window, tui_cmd_window): New
9086         classes.
9087         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9088         constructor.  Add "type" parameter.
9089         (tui_source_window, tui_data_window, tui_cmd_window): New
9090         constructors.
9091         (tui_alloc_win_info): Instantiate the appropriate subclass.
9092
9093 2019-06-25  Tom Tromey  <tom@tromey.com>
9094
9095         * tui/tui-win.c (tui_resize_all): Use delete.
9096         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9097         destructor.
9098         (tui_free_window): Don't declare.
9099         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9100         Update.
9101
9102 2019-06-25  Tom Tromey  <tom@tromey.com>
9103
9104         * tui/tui-data.h (struct tui_win_info): Add constructor.
9105         * tui/tui-data.c (tui_alloc_win_info): Use new.
9106         (tui_free_window): Use delete.
9107
9108 2019-06-22  Tom Tromey  <tom@tromey.com>
9109
9110         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9111         declare.
9112         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9113
9114 2019-06-22  Tom Tromey  <tom@tromey.com>
9115
9116         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9117         declare.
9118         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9119
9120 2019-06-22  Tom de Vries  <tdevries@suse.de>
9121
9122         * dwarf2read.c (create_addrmap_from_aranges)
9123         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9124         instead of '%zu'.
9125
9126 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9127
9128         * dwarf2read.h (dwarf2_section_info_def): Remove.
9129         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9130         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9131         std::vector<dwarf2_section_info>.
9132         (struct dwo_file) <~dwo_file>: Remove.
9133         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9134         types field.
9135         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9136         (dwarf2_read_debug_names): Likewise.
9137         (create_debug_types_hash_table): Change parameter type to
9138         array_view, adjust code accordingly.
9139         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9140         (partial_die_info::fixup): Likewise.
9141         (determine_prefix): Likewise.
9142         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9143
9144 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9145
9146         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9147         gdb_bfd_ref_ptr.
9148         <~dwo_file>: Remove call to gdb_bfd_unref.
9149         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9150         gdb_bfd_ref_ptr::get.
9151
9152 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9153
9154         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9155         type to htab_up.
9156         * dwarf2read.c (struct dwo_file): Initialize fields.
9157         <~dwo_file>: New.
9158         (free_dwo_file): Remove, move content to ~dwo_file.
9159         (struct dwo_file_deleter): Remove.
9160         (dwo_file_up>: Remove custom deleter.
9161         (free_dwo_files): Remove.
9162         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9163         dwo_files.
9164         (process_skeletonless_type_units): Call unique_ptr::get.
9165         (allocate_dwo_file_hash_table): Add deleter to created hash
9166         table.  Change return type to htab_up.
9167         (lookup_dwo_file_slot): Don't memset dwo_file, call
9168         unique_ptr::get.
9169         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9170         (create_dwo_unit_in_dwp_v2): Likewise.
9171         (open_and_init_dwo_file): Likewise.
9172         (free_dwo_file_from_slot): Remove.
9173
9174 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9175
9176         * dwarf2read.h (struct dwarf2_section_info) <readin,
9177         is_virtual>: Change type to bool.
9178         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9179         true instead of 1.
9180
9181 2019-06-19  Tom Tromey  <tom@tromey.com>
9182
9183         * tui/tui-data.h (tui_init_content_element): Don't declare.
9184
9185 2019-06-19  Tom Tromey  <tom@tromey.com>
9186
9187         * tui/tui-data.h (tui_init_win_info): Don't declare.
9188
9189 2019-06-19  Tom de Vries  <tdevries@suse.de>
9190
9191         * dwarf2read.h (abstract_to_concrete): Change type to
9192         std::unordered_map<sect_offset, std::vector<sect_offset>,
9193         gdb::hash_enum<sect_offset>>.
9194
9195 2019-06-19  Tom Tromey  <tromey@adacore.com>
9196
9197         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9198         EVAL_AVOID_SIDE_EFFECTS specially.
9199
9200 2019-06-19  Tom Tromey  <tromey@adacore.com>
9201
9202         * source-cache.c (highlighter): New global.
9203         (source_cache::get_source_lines): Create a highlighter on demand.
9204
9205 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9206
9207         * defs.h (deprecated_interactive_hook): Delete declaration.
9208         * interps.c (clear_interpreter_hooks): Remove use of
9209         deprecated_interactive_hook.
9210         * top.c (deprecated_interactive_hook): Delete definition.
9211         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9212
9213 2019-06-18  Tom de Vries  <tdevries@suse.de>
9214
9215         PR gdb/24515
9216         * dwarf2read.h (abstract_to_concrete): Change type from
9217         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9218         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9219         * dwarf2read.c (read_variable): Update.
9220         (dwarf2_fetch_die_loc_sect_off): Update.
9221
9222 2019-06-17  Tom de Vries  <tdevries@suse.de>
9223
9224         PR gdb/24617
9225         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9226         accessing parent[parent_len - 1].
9227
9228 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9229
9230         PR gdb/24364
9231         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9232         call dtrace_process_dof with NULL dof.
9233
9234 2019-06-16  Tom de Vries  <tdevries@suse.de>
9235
9236         PR gdb/24445
9237         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9238
9239 2019-06-16  Tom Tromey  <tom@tromey.com>
9240
9241         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9242         (make_all_visible): Use address of member.
9243
9244 2019-06-16  Tom Tromey  <tom@tromey.com>
9245
9246         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9247         (tui_free_window, free_content, free_content_elements): Remove
9248         unnecessary cast.
9249         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9250         cast.
9251         * tui/tui-regs.c (tui_show_register_group)
9252         (tui_display_registers_from, tui_display_reg_element_at_line):
9253         Remove unnecessary cast.
9254
9255 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9256
9257         * linux-nat.c (normal_mask): Delete.
9258         (_initialize_linux_nat): Don't initialise normal_mask.
9259
9260 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9261
9262         PR gdb/24445
9263         * dwarf-index-write.h (write_psymtabs_to_index): Add
9264         dwz_basename parameter.
9265         * dwarf-index-write.c (write_gdbindex): Move file writing to
9266         write_gdbindex_1.  Change return type void.
9267         (assert_file_size): Move up, remove filename parameter.
9268         (write_gdbindex_1): New function.
9269         (write_debug_names): Change return type to void, call
9270         assert_file_size.
9271         (struct index_wip_file): New struct.
9272         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9273         file logic to index_wip_file.  Write index for dwz file if
9274         needed.
9275         (save_gdb_index_command): Pass basename of dwz file, if present.
9276         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9277         build-id of dwz file, if present.
9278         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9279         (dwarf2_get_dwz_file): Likewise.
9280         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9281         (dwarf2_get_dwz_file): Likewise.
9282
9283 2019-06-16  Tom Tromey  <tom@tromey.com>
9284
9285         * coffread.c (process_coff_symbol): Use xstrdup.
9286         * value.c (create_internalvar): Use xstrdup.
9287
9288 2019-06-16  Tom Tromey  <tom@tromey.com>
9289
9290         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9291         * breakpoint.c (stopin_command, stopat_command)
9292         (until_break_command, decode_location_default): Remove unnecessary
9293         cast.
9294         * utils.c (subset_compare): Remove unnecessary cast.
9295         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9296         cast.
9297         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9298         cast.
9299         * infcmd.c (path_command): Remove unnecessary cast.
9300         * coffread.c (decode_type): Remove unnecessary cast.
9301         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9302         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9303         * tui/tui-stack.c (tui_show_locator_content)
9304         (tui_show_frame_info): Remove unnecessary cast.
9305         * tui/tui-win.c (tui_scroll_forward_command)
9306         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9307         (parse_scrolling_args): Remove unnecessary cast.
9308         * tui/tui-data.c (init_win_info, tui_del_window)
9309         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9310         (free_content_elements): Remove unnecessary cast.
9311         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9312         unnecessary cast.
9313         * tui/tui-source.c (tui_set_source_content)
9314         (tui_vertical_source_scroll): Remove unnecessary cast.
9315         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9316         cast.
9317         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9318         * tui/tui-regs.c (tui_display_registers_from)
9319         (tui_display_register): Remove unnecessary cast.
9320         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9321         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9322         (make_visible): Remove unnecessary cast.
9323         * tui/tui-winsource.c (tui_erase_source_content)
9324         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9325         unnecessary cast.
9326         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9327         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9328         * stabsread.c (read_type, read_array_type, read_range_type):
9329         Remove unnecessary cast.
9330         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9331         (parse_symbol, parse_type, upgrade_type, parse_external)
9332         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9333         unnecessary cast.
9334         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9335
9336 2019-06-16  Tom Tromey  <tom@tromey.com>
9337
9338         * tui/tui-data.c (tui_alloc_generic_win_info)
9339         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9340         checks.
9341
9342 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9343             Andrew Burgess  <andrew.burgess@embecosm.com>
9344
9345         * f-typeprint.c (f_print_type): Don't return early for not
9346         associated or not allocated types.
9347         (f_type_print_varspec_suffix): Add print_rank parameter and print
9348         ranks of array types in case they dangling.
9349         (f_type_print_base): Add print_rank parameter.
9350
9351 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9352
9353         * NEWS: Mention new MI commands.
9354         * break-catch-throw.c (enum exception_event_kind): Move to
9355         breakpoint.h.
9356         (print_mention_exception_catchpoint): Output text as a single
9357         message.
9358         (catch_exception_command_1): Rename to...
9359         (catch_exception_event): ...this, make non-static, update header
9360         command, and change some parameter types.
9361         (catch_catch_command): Update for changes to
9362         catch_exception_command_1.
9363         (catch_throw_command): Likewise.
9364         (catch_rethrow_command): Likewise.
9365         * breakpoint.c (enum exception_event_kind): Delete.
9366         * breakpoint.h (enum exception_event_kind): Moved here from
9367         break-catch-throw.c.
9368         (catch_exception_event): Declare.
9369         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9370         (mi_cmd_catch_throw): New function.
9371         (mi_cmd_catch_rethrow): New function.
9372         (mi_cmd_catch_catch): New function.
9373         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9374         'catch-catch' entries.
9375         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9376         (mi_cmd_catch_rethrow): Declare.
9377         (mi_cmd_catch_catch): Declare.
9378
9379 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9380
9381         * annotate.c (annotate_source_line): Change return type to void,
9382         update implementation to match.
9383         * annotate.h (annotate_source_line): Change return type to void,
9384         update header comment.
9385         * stack.c (print_frame_info): Don't change what frame information
9386         is printed based on whether annotations are on or not.
9387
9388 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9389
9390         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9391         (annotate_source): Make static.
9392         (annotate_source_line): Moved from source.c and renamed from
9393         identify_source_line.  Update the return type.
9394         * annotate.h (annotate_source): Delete declaration.
9395         (annotate_source_line): Declaration moved from source.h, and
9396         renamed from identify_source_line.  Return type updated.
9397         * source.c (identify_source_line): Moved to annotate.c and renamed
9398         to annotate_source_line.
9399         (info_line_command): Remove check of annotation_level.
9400         * source.h (identify_source_line): Move declaration to annotate.h
9401         and rename to annotate_source_line.
9402         * stack.c: Add 'annotate.h' include.
9403         (print_frame_info): Remove check of annotation_level before
9404         calling annotate_source_line.
9405
9406 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9407
9408         * source-cache.c (source_cache::get_plain_source_lines): Use
9409         open_source_file_with_line_charpos instead of just
9410         open_source_file, remove call to find_source_lines.
9411         (source_cache::get_source_lines): Likewise.
9412         * source.c (find_source_lines): Make static.
9413         (get_filename_and_charpos): Renamed into...
9414         (open_source_file_with_line_charpos): ..this along with changes to
9415         return a scoped_fd, and some other minor clean ups.
9416         (identify_source_line): Use open_source_file_with_line_charpos.
9417         (search_command_helper): Use open_source_file_with_line_charpos
9418         instead of just open_source_file, remove call to
9419         find_source_lines.
9420         * source.h (open_source_file_with_line_charpos): Declare new
9421         function.
9422         (find_source_lines): Delete declaration.
9423
9424 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9425
9426         * source.c (get_filename_and_charpos): Remove fullname
9427         parameter.
9428         (identify_source_line): Update call to get_filename_and_charpos.
9429
9430 2019-06-14  Tom Tromey  <tromey@adacore.com>
9431
9432         PR gdb/24502:
9433         * ui-style.h (skip_ansi_escape): Update comment.
9434         * ui-file.h (class no_terminal_escape_file): New class.
9435         * ui-file.c (no_terminal_escape_file::write)
9436         (no_terminal_escape_file::puts): New methods.
9437         * cli/cli-logging.c (handle_redirections): Use
9438         no_terminal_escape_file.
9439
9440 2019-06-14  Tom Tromey  <tromey@adacore.com>
9441
9442         * NEWS: Move convenience variable news above Python news.
9443
9444 2019-06-14  Tom Tromey  <tom@tromey.com>
9445
9446         * gnulib: Move directory to top-level.
9447         * configure.ac: Don't configure gnulib.
9448         * configure: Rebuild.
9449         * common/common-defs.h: Use new path to gnulib.
9450         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9451         (GNULIB_H): Remove.
9452         (INCGNU): Look in new gnulib location.
9453         (HFILES_NO_SRCDIR): Remove gnulib files.
9454         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9455         (generated_files): Remove GNULIB_H.
9456         ($(LIBGNU), all-lib): Remove targets.
9457         (distclean): Don't mention GNULIB_BUILDDIR.
9458         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9459
9460 2019-06-14  Tom Tromey  <tromey@adacore.com>
9461
9462         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9463         Warn if symbol file does not provide any symbols.
9464
9465 2019-06-14  Tom Tromey  <tromey@adacore.com>
9466
9467         * source.c (find_and_open_source): Respect basenames_may_differ.
9468
9469 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9470
9471         * annotate.c (annotate_breakpoints_invalid): Make use of
9472         scoped_restore_terminal_state.
9473         (annotate_frames_invalid): Likewise.
9474
9475 2019-06-14  Tom Tromey  <tromey@adacore.com>
9476
9477         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9478         allow assignment to an internalvar.
9479
9480 2019-06-14  Tom Tromey  <tromey@adacore.com>
9481
9482         * ada-lex.l: Allow "_" in attribute names.
9483
9484 2019-06-14  Tom Tromey  <tromey@adacore.com>
9485
9486         PR gdb/24653:
9487         * regcache.c (registers_changed): Don't call alloca.
9488         * top.c (execute_command): Don't call alloca.
9489
9490 2019-06-13  Pedro Alves  <palves@redhat.com>
9491
9492         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9493         'expression'.  When parsing an expression, error out if there's
9494         junk after "unlimited".
9495         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9496         (do_set_command): Adjust calls to is_unlimited_literal.
9497
9498 2019-06-13  Pedro Alves  <palves@redhat.com>
9499
9500         * compile/compile.c (make_compile_options_def_group): Add braces
9501         around array_view initializer.
9502         * thread.c (make_thread_apply_all_options_def_group)
9503         (make_thread_apply_all_options_def_group): Likewise.
9504
9505 2019-06-13  Pedro Alves  <palves@redhat.com>
9506
9507         * NEWS (New commands): Mention "maint test-options
9508         require-delimiter", "maint test-options unknown-is-error", "maint
9509         test-options unknown-is-operand" and "maint show
9510         test-options-completion-result".
9511         (New command options, command completion): New section.
9512         (Completion improvements): New section.
9513         Mention that you can abbreviate "unlimited".
9514
9515 2019-06-13  Pedro Alves  <palves@redhat.com>
9516
9517         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9518         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9519         * unittests/cli-utils-selftests.c (test_parse_flags)
9520         (test_parse_flags_qcs): Delete.
9521         (test_cli_utils): Don't call deleted functions.
9522
9523 2019-06-13  Pedro Alves  <palves@redhat.com>
9524
9525         * thread.c: Include "cli/cli-option.h".
9526         (tp_array_compar_ascending): Global.
9527         (tp_array_compar): Delete function.
9528         (tp_array_compar_ascending, tp_array_compar_descending): New
9529         functions.
9530         (ascending_option_def, qcs_flag_option_def)
9531         (thr_qcs_flags_option_defs)
9532         (make_thread_apply_all_options_def_group)
9533         (make_thread_apply_options_def_group): New.
9534         (thread_apply_all_command): Use gdb::option::process_options.
9535         (thread_apply_command_completer)
9536         (thread_apply_all_command_completer): New.
9537         (thread_apply_command): Use gdb::option::process_options.
9538         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9539         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9540         to generate help text of "thread apply".  Adjust "taas"'s help.
9541         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9542         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9543
9544 2019-06-13  Pedro Alves  <palves@redhat.com>
9545
9546         * thread.c (thread_apply_command): Check for invalid TID with
9547         isdigit instead of !isalpha.
9548
9549 2019-06-13  Pedro Alves  <palves@redhat.com>
9550
9551         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9552         (validate_flags_qcs): New.
9553         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9554         (validate_flags_qcs): Declare.
9555         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9556         (make_frame_apply_options_def_group): New.
9557         (frame_apply_command_count): Process options with
9558         gdb::option::process_options.
9559         (frame_apply_completer): New.
9560         (frame_apply_level_completer, frame_apply_all_completer)
9561         (frame_apply_completer): New.
9562         (_initialize_stack): Update help of "frame apply", "frame apply
9563         level", "frame apply all" and "faas" to mention supported options
9564         and install command completers.
9565         * stack.h (frame_apply_all_completer): Declare.
9566         * thread.c: Include "stack.h".
9567         (tfaas_command): Add "--".
9568         (_initialize_thread): Update help "tfaas" to mention supported
9569         options and install command completer.
9570
9571 2019-06-13  Pedro Alves  <palves@redhat.com>
9572
9573         * completer.c (complete_nested_command_line): New.
9574         (gdb_completion_word_break_characters_throw): Add assertion.
9575         * completer.h (complete_nested_command_line): Declare.
9576
9577 2019-06-13  Pedro Alves  <palves@redhat.com>
9578
9579         * stack.c (parse_backtrace_qualifiers): New.
9580         (backtrace_command): Use it.
9581         (backtrace_command_completer): Complete on qualifiers.
9582
9583 2019-06-13  Pedro Alves  <palves@redhat.com>
9584
9585         * frame.c: Include "cli/cli-option.h.
9586         (user_set_backtrace_options): New.
9587         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9588         Delete.
9589         (get_prev_frame): Adjust.
9590         (boolean_option_def, uinteger_option_def)
9591         (set_backtrace_option_defs): New.
9592         (_initialize_frame): Adjust and use
9593         gdb::option::add_setshow_cmds_for_options to install "set
9594         backtrace past-main" and "set backtrace past-entry".
9595         * frame.h: Include "cli/cli-option.h".
9596         (struct frame_print_options): Forward declare.
9597         (print_frame_arguments_all, print_frame_arguments_scalars)
9598         (print_frame_arguments_none): Declare.
9599         (print_entry_values): Delete declaration.
9600         (struct frame_print_options, user_frame_print_options): New.
9601         (struct set_backtrace_options): New.
9602         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9603         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9604         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9605         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9606         (list_args_or_locals): Add frame_print_options parameter.
9607         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9608         * python/py-framefilter.c (enumerate_args): Pass down
9609         USER_FRAME_PRINT_OPTIONS.
9610         * stack.c: Include "cli/cli-option.h".
9611         (print_frame_arguments_all, print_frame_arguments_scalars)
9612         (print_frame_arguments_none): Declare.
9613         (print_raw_frame_arguments, print_entry_values): Delete.
9614         (user_frame_print_options): New.
9615         (boolean_option_def, enum_option_def, frame_print_option_defs):
9616         New.
9617         (struct backtrace_cmd_options): New.
9618         (bt_flag_option_def): New.
9619         (backtrace_command_option_defs): New.
9620         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9621         (print_frame_arg, read_frame_arg, print_frame_args)
9622         (print_frame_info, print_frame): Add frame_print_options parameter
9623         and use it.
9624         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9625         (backtrace_command_1): Add frame_print_options and
9626         backtrace_cmd_options parameters and use them.
9627         (make_backtrace_options_def_group): New.
9628         (backtrace_command): Process command options with
9629         gdb::option::process_options.
9630         (backtrace_command_completer): New.
9631         (_initialize_stack): Extend "backtrace"'s help to mention
9632         supported options.  Install completer for "backtrace".
9633         Install some settings commands with add_setshow_cmds_for_options.
9634
9635 2019-06-13  Pedro Alves  <palves@redhat.com>
9636
9637         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9638         and that "set/show print raw frame-arguments" are now deprecated.
9639
9640         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9641         command.
9642         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9643         * stack.c (_initialize_stack): Install "set/show print
9644         raw-frame-arguments", and deprecate "set/show print raw
9645         frame-arguments".
9646         * valprint.c (_initialize_valprint): Deprecate "set/show print
9647         raw".
9648
9649 2019-06-13  Pedro Alves  <palves@redhat.com>
9650
9651         * compile/compile.c (struct compile_options): New.
9652         (compile_flag_option_def, compile_command_option_defs)
9653         (make_compile_options_def_group): New.
9654         (compile_file_command): Handle options with
9655         gdb::option::process_options.
9656         (compile_file_command_completer): New function.
9657         (compile_code_command): Handle options with
9658         gdb::option::process_options.
9659         (compile_code_command_completer): New function.
9660         (_initialize_compiler): Install completers for "compile code" and
9661         "compile file".  Mention available options in "compile code" and
9662         "compile code"'s help.
9663         * completer.c (advance_to_completion_word): New, factored out from
9664         ...
9665         (advance_to_expression_complete_word_point): ... this.
9666         (advance_to_filename_complete_word_point): New.
9667         * completer.h (advance_to_filename_complete_word_point): New
9668         declaration.
9669
9670 2019-06-13  Pedro Alves  <palves@redhat.com>
9671
9672         * compile/compile.c: Include "cli/cli-option.h".
9673         (compile_print_value): Scope data pointer is now a
9674         value_print_options pointer; adjust.
9675         (compile_print_command): Process options.  Scope data pointer is
9676         now a value_print_options pointer; adjust.
9677         (_initialize_compile): Update "compile print"'s help to include
9678         supported options.  Install a completer for "compile print".
9679         * cp-valprint.c (show_vtblprint, show_objectprint)
9680         (show_static_field_print): Delete.
9681         (_initialize_cp_valprint): Don't install "set print
9682         static-members", "set print vtbl", "set print object" here.
9683         * printcmd.c: Include "cli/cli-option.h" and
9684         "common/gdb_optional.h".
9685         (print_command_parse_format): Rework to fill in a
9686         value_print_options instead of a format_data.
9687         (print_value): Change parameter type from format_data pointer to
9688         value_print_options reference.  Adjust.
9689         (print_command_1): Process options.  Adjust to pass down a
9690         value_print_options.
9691         (print_command_completer): New.
9692         (_initialize_printcmd): Install print_command_completer as
9693         handle_brkchars completer for the "print" command.  Update
9694         "print"'s help to include supported options.
9695         * valprint.c: Include "cli/cli-option.h".
9696         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9697         here from cp-valprint.c.
9698         (boolean_option_def, uinteger_option_def)
9699         (value_print_option_defs, make_value_print_options_def_group):
9700         New.  Use gdb::option::add_setshow_cmds_for_options to install
9701         "set print elements", "set print null-stop", "set print repeats",
9702         "set print pretty", "set print union", "set print array", "set
9703         print address", "set print symbol", "set print array-indexes".
9704         * valprint.h: Include <string> and "cli/cli-option.h".
9705         (make_value_print_options_def_group): Declare.
9706         (print_value): Change parameter type from format_data pointer to
9707         value_print_options reference.
9708         (print_command_completer): Declare.
9709
9710 2019-06-13  Pedro Alves  <palves@redhat.com>
9711
9712         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9713         (COMMON_SFILES): Add maint-test-settings.c.
9714         * cli/cli-decode.c (boolean_enums): New global, factored out from
9715         ...
9716         (add_setshow_boolean_cmd): ... here.
9717         * cli/cli-decode.h (boolean_enums): Declare.
9718         * cli/cli-option.c: New file.
9719         * cli/cli-option.h: New file.
9720         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9721         factored out from ...
9722         (parse_cli_boolean_value(const char *)): ... this.
9723         (is_unlimited_literal): Change parameter type to pointer to
9724         pointer.  Adjust and advance ARG pointer.
9725         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9726         (parse_cli_var_enum): New, factored out from ...
9727         (do_set_command): ... this.  Adjust.
9728         * cli/cli-setshow.h (parse_cli_boolean_value)
9729         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9730         (parse_cli_var_enum): Declare.
9731         * cli/cli-utils.c: Include "cli/cli-option.h".
9732         (get_ulongest): New.
9733         * cli/cli-utils.h (get_ulongest): Declare.
9734         (check_for_argument): New overloads.
9735         * maint-test-options.c: New file.
9736
9737 2019-06-13  Pedro Alves  <palves@redhat.com>
9738
9739         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9740         parse a range if "-" is at the end of the string.
9741
9742 2019-06-13  Pedro Alves  <palves@redhat.com>
9743
9744         * cli/cli-setshow.c (parse_auto_binary_operation)
9745         (parse_cli_boolean_value): Don't allow "o".
9746
9747 2019-06-13  Pedro Alves  <palves@redhat.com>
9748
9749         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9750         * NEWS: Mention maint test-settings KIND.
9751         * maint-test-settings.c: New file.
9752
9753 2019-06-13  Pedro Alves  <palves@redhat.com>
9754
9755         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9756         completer.
9757         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9758         "set" completers.
9759
9760 2019-06-13  Pedro Alves  <palves@redhat.com>
9761
9762         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9763         after item.
9764
9765 2019-06-13  Pedro Alves  <palves@redhat.com>
9766
9767         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9768
9769 2019-06-13  Pedro Alves <palves@redhat.com>
9770
9771         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9772         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9773         call.
9774         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9775         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9776         calls.
9777         (check_for_argument): Skip spaces after argument.
9778
9779 2019-06-13  Pedro Alves  <palves@redhat.com>
9780
9781         * thread.c (thread_apply_command): Adjust TID parsing.
9782         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9783         detected before end of string.
9784         (tid_is_in_list): Error out if LIST is invalid.
9785
9786 2019-06-13  Pedro Alves  <palves@redhat.com>
9787
9788         * completer.c (complete_line_internal_1): Rewind completion word
9789         point.
9790         (completion_tracker::advance_custom_word_point_by): Change
9791         parameter type to int.
9792         * completer.h (completion_tracker::advance_custom_word_point_by):
9793         Likewise.
9794
9795 2019-06-13  Pedro Alves  <palves@redhat.com>
9796
9797         * completer.c (advance_to_completion_word): Handle delimiters.
9798
9799 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9800
9801         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9802
9803 2019-06-11  Tom Tromey  <tom@tromey.com>
9804
9805         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9806         (xmalloc_failed): Move to alloc.c.
9807         * alloc.c: New file.
9808         * Makefile.in (COMMON_SFILES): Add alloc.c.
9809
9810 2019-06-11  Tom Tromey  <tom@tromey.com>
9811
9812         * nat/linux-waitpid.c: Don't include server.h.
9813         (linux_debug): Remove.
9814         (my_waitpid): Update.
9815
9816 2019-06-11  Tom Tromey  <tromey@adacore.com>
9817
9818         * infcall.c (_initialize_infcall): Remove trailing newline from
9819         help.
9820         * user-regs.c (_initialize_user_regs): Remove trailing newline
9821         from help.
9822         * typeprint.c (_initialize_typeprint): Remove trailing newline
9823         from help.
9824         * reverse.c (_initialize_reverse): Remove trailing newlines from
9825         help.
9826         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9827         from help.
9828         * language.c (add_set_language_command): Remove trailing newline
9829         from help.
9830         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9831         help.
9832         * disasm.c (_initialize_disasm): Remove trailing newline from
9833         help.
9834         * top.c (init_main): Remove trailing newline from help.
9835         * interps.c (_initialize_interpreter): Remove trailing newline
9836         from help.
9837         * btrace.c (_initialize_btrace): Remove trailing newlines from
9838         help.
9839         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9840         from help.
9841         * python/python.c (_initialize_python): Remove trailing newline
9842         from help.
9843         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9844         help.
9845         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9846         from help.  Reformat some text.
9847         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9848         from help.
9849         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9850         newline from help.
9851
9852 2019-06-11  Tom Tromey  <tromey@adacore.com>
9853
9854         * darwin-nat.c (darwin_decode_exception_message)
9855         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9856
9857 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9858
9859         * valops.c (value_slice): Check for not allocated or not
9860         associated values.
9861
9862 2019-06-10  Tom de Vries  <tdevries@suse.de>
9863
9864         PR gdb/24618
9865         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9866         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9867         invalid.
9868
9869 2019-06-10  Tom de Vries  <tdevries@suse.de>
9870
9871         PR gdb/24611
9872         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9873         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9874
9875 2019-06-10  Tom de Vries  <tdevries@suse.de>
9876
9877         PR symtab/24545
9878         * symtab.c (struct demangled_name_entry): Add language field.
9879         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9880         static minimal symbol".  Set and use language field.
9881
9882 2019-06-10  Tom Tromey  <tromey@adacore.com>
9883
9884         * ada-lang.c (_initialize_ada_language): Update help text.
9885
9886 2019-06-10  Tom Tromey  <tromey@adacore.com>
9887
9888         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9889         with a newline.
9890         * guile/guile.c (handle_boot_error): Don't end warning with a
9891         newline.
9892         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9893         warning with a newline.
9894         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9895         newline.
9896         (s12z_frame_cache): Likewise.
9897         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9898         a newline.
9899         * solib-svr4.c (disable_probes_interface): Don't end warning with
9900         a newline.
9901         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9902         newline.
9903         * python/python.c (do_finish_initialization): Don't end warning
9904         with a newline.
9905
9906 2019-06-10  Tom Tromey  <tom@tromey.com>
9907
9908         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9909         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9910         gdbpy_enter.
9911
9912 2019-06-10  Tom Tromey  <tromey@adacore.com>
9913
9914         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9915         data.
9916         (elf_new_init): Don't call stabsread_new_init.
9917         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9918         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9919         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9920
9921 2019-06-10  Tom de Vries  <tdevries@suse.de>
9922
9923         PR symtab/16264
9924         PR symtab/24517
9925         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9926
9927 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9928
9929         * source.c (find_and_open_source): Also rewrite relative file
9930         names.
9931
9932 2019-04-26  Amos Bird  <amosbird@gmail.com>
9933
9934         * annotate.c (annotate_thread_exited): Add "thread-exited"
9935         annotation.
9936
9937 2019-06-06  Tom Tromey  <tromey@adacore.com>
9938
9939         * maint.h (class scoped_command_stats): Use
9940         DISABLE_COPY_AND_ASSIGN.
9941         <print_time>: New method.
9942         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
9943         print_time.
9944         (scoped_command_stats::print_time): New method.
9945
9946 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
9947
9948         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
9949         instructions of lengths 6 or 8 bytes.
9950
9951 2019-06-04  Pedro Alves  <palves@redhat.com>
9952
9953         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
9954
9955         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
9956         * breakpoint.c (condition_completer): Likewise.
9957         * cli/cli-dump.c (scan_expression): Likewise.
9958         * common/filestuff.c (mkdir_recursive): Likewise.
9959         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
9960         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
9961         (gdb_abspath): Likewise.
9962         * compile/compile-cplus-types.c
9963         (compile_cplus_instance::decl_name): Likewise.
9964         * completer.c (complete_explicit_location):
9965         (signal_completer, reg_or_group_completer_1): Likewise.
9966         * cp-support.c (cp_remove_params_if_any): Likewise.
9967         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
9968         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
9969         * infcmd.c (strip_bg_char): Likewise.
9970         * linespec.c (copy_token_string): Likewise.
9971         * mi/mi-main.c (output_cores): Likewise.
9972         * psymtab.c (psymtab_search_name):
9973         * symfile.c (test_set_ext_lang_command): Likewise.
9974         * target.c (target_fileio_read_stralloc): Likewise.
9975         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
9976         * value.c (complete_internalvar): Likewise.
9977
9978 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
9979
9980         Add objfile property to gdb.Type.
9981         * NEWS: Mention Python API addition.
9982         * python/py-type.c (typy_get_objfile): New method.
9983
9984 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9985
9986         * NEWS: Mention the new set|show style [title|highlight].
9987         Mention changes to "show style", "help" and "apropos".
9988
9989 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
9990
9991         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
9992         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
9993         instead of print_help_for_command.
9994         (print_doc_of_command): New function.
9995         (help_list): Add 'apropos -v word' suggestion.
9996         (print_help_for_command): Style the command name using title style.
9997         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
9998         (_initialize_cli_cmds): Describe -v in apropos_command help.
9999
10000 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10001
10002         * cli/cli-style.h (cli_style_option): Add name in constructor,
10003         add m_name class member, add constructor with intensity,
10004         add name class function.
10005         (cli_style_option::add_setshow_commands): Remove name argument.
10006         (highlight_style, title_style): New styles.
10007         * cli/cli-style.c (do_show): New function that shows a style
10008         characteristic styling the style name with itself.
10009         (set_style_name): New function.
10010         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10011         Update all callers according to the changes in cli/cli-style.h.
10012         * utils.h (fputs_highlighted): New function.
10013         * utils.c (fputs_highlighted): Likewise.
10014
10015 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10016
10017         * NEWS: Mention new pipe command and new convenience variables.
10018
10019 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10020
10021         * cli/cli-cmds.c (pipe_command): New function.
10022         (_initialize_cli_cmds): Call add_com for pipe_command.
10023         Define | as an alias for pipe.
10024         (exit_status_set_internal_vars): New function.
10025         (shell_escape): Call exit_status_set_internal_vars.
10026         cli/cli-decode.c (find_command_name_length): Recognize | as
10027         a single character command.
10028
10029 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10030
10031         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10032         top.c (execute_command_to_ui_file): New function, mostly a copy
10033         of execute_command_to_string.
10034         (execute_command_to_string): Implement by calling
10035         execute_command_to_ui_file.
10036
10037 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10038
10039         * top.h (saved_command_line): Remove declaration.
10040         * top.c (previous_saved_command_line, previous_repeat_arguments):
10041         New variables.
10042         (saved_command_line): Make static, define together with other
10043         'repeat variables'.
10044         (dont_repeat): Clear repeat_arguments.
10045         (repeat_previous, get_saved_command_line, save_command_line):
10046         New functions.
10047         (gdb_init): Initialize saved_command_line
10048         and previous_saved_command_line.
10049         * main.c (captured_main_1): Remove saved_command_line initialization.
10050         * event-top.c (handle_line_of_input): Update to use
10051         the new 'repeat' related functions instead of direct access to
10052         saved_command_line.
10053         * command.h (repeat_previous, get_saved_command_line,
10054         save_command_line): New declarations.
10055         (dont_repeat): Add comment.
10056
10057 2019-05-30  Tom Tromey  <tromey@adacore.com>
10058
10059         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10060         Fix comment.
10061         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10062
10063 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10064
10065         PR cli/24587
10066         * completer.c (complete): Initialize variable word.
10067
10068 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10069
10070         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10071         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10072         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10073         'body' is NULL to the outter 'if', protecting the '!is_define'
10074         situation as well.
10075
10076 2019-05-29  Tom Tromey  <tromey@adacore.com>
10077
10078         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10079         (dwarf_unknown): New function.
10080         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10081         (dwarf_type_encoding_name): Use dwarf_unknown.
10082
10083 2019-05-29  Tom Tromey  <tromey@adacore.com>
10084
10085         PR c++/20020:
10086         * cp-valprint.c (cp_print_value_fields): Call
10087         cp_print_static_field inside "try".
10088
10089 2019-05-29  Tom Tromey  <tromey@adacore.com>
10090
10091         * inflow.c (struct terminal_info): Add default operator=.
10092         * configure: Rebuild.
10093         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10094         -Wdeprecated-copy-dtor, -Wredundant-move.
10095
10096 2019-05-29  Tom Tromey  <tromey@adacore.com>
10097
10098         * NEWS: Add entry.
10099         * infcmd.c (print_return_value_1): Handle finish_print
10100         option.
10101         (show_print_finish): New function.
10102         (_initialize_infcmd): Add "set/show print finish" commands.
10103         * valprint.c (user_print_options): Initialize new member.
10104         * valprint.h (struct value_print_options) <finish_print>: New
10105         member.
10106
10107 2019-05-28  Tom Tromey  <tromey@adacore.com>
10108
10109         * ada-lang.c (ada_remove_Xbn_suffix)
10110         (find_old_style_renaming_symbol)
10111         (parse_old_style_renaming): Remove.
10112         (ada_find_renaming_symbol): Don't call
10113         find_old_style_renaming_symbol.
10114         (ada_is_renaming_symbol): Rename from
10115         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10116         bool.  Now static.
10117         (ada_read_var_value): Update and simplify.
10118         * ada-exp.y (write_var_or_type): Remove old code.
10119
10120 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10121
10122         PR gdb/25010
10123         * event-top.c: Remove include comment.
10124         * inflow.c (class scoped_ignore_sigttou): Move from here...
10125         * inflow.h (class scoped_ignore_sigttou): ...to here.
10126         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10127         * top.c:  Remove include comment.
10128
10129 2019-05-27  Tom Tromey  <tom@tromey.com>
10130
10131         * NEWS: Fix typo.
10132
10133 2019-05-22  Tom Tromey  <tromey@adacore.com>
10134
10135         * target.c (target_follow_exec): Constify parameter.
10136         * target-delegates.c: Rebuild.
10137         * remote.c (remote_target::follow_exec): Constify parameter.
10138         * infrun.c (follow_exec): Constify parameter.
10139         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10140         (target_follow_exec): Likewise.
10141
10142 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10143
10144         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10145         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10146
10147 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10148
10149         * NEWS: Add debugredirect and testsuite sections.
10150
10151 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10152
10153         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10154         target descriptions using exclusively floating point register name
10155         aliases.
10156
10157 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10158
10159         PR gdb/18644:
10160         * f-lang.c (build_fortran_types): Handle the case where
10161         gdbarch_floatformat_for_type returns a nullptr.
10162
10163 2019-05-21  Tom de Vries  <tdevries@suse.de>
10164
10165         PR cli/24587
10166         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10167
10168 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10169
10170         PR gdb/18644:
10171         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10172         16-byte floats.
10173         * i386-tdep.c (i386_floatformat_for_type): Use
10174         floatformats_ia64_quad for the 16-byte floating point component
10175         within a fortran 32-byte complex number.
10176
10177 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10178
10179         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10180         delete default constructor.
10181         (find_partial_die): Update to return const struct.
10182         (partial_die_parent_scope): Move variable declaration into scope
10183         of its use and change its type to auto.
10184         (guess_partial_die_structure_name): Likewise.
10185         (partial_die_info::fixup): Likewise.
10186
10187 2019-05-17  Tom Tromey  <tromey@adacore.com>
10188
10189         * source.c (find_and_open_source): Remove cast.
10190
10191 2019-05-17  Tom Tromey  <tromey@adacore.com>
10192
10193         * annotate.c (annotate_source): Make "filename" const.
10194         * annotate.h (annotate_source): Use const.
10195
10196 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10197
10198         * disasm.c (set_disassembler_options): Send errors to stderr.
10199
10200 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10201
10202         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10203         (cli_interp_base::set_logging): Check debug_redirect.
10204         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10205         * cli/cli-logging.c (debug_redirect): Add static variable.
10206         (pop_output_files): Add default param.
10207         (handle_redirections): Print debug setting.
10208         (show_logging_command): Likewise.
10209         (_initialize_cli_logging): Add debugredirect command.
10210         * interps.c (current_interp_set_logging): Add debug_redirect
10211         parameter.
10212         * interps.h (set_logging): Add debug_redirect parameter.
10213         (current_interp_set_logging): Likewise.
10214         * mi/mi-common.h: Likewise.
10215         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10216
10217 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10218             Tom Tromey  <tromey@adacore.com>
10219
10220         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10221         directly.
10222         * cli/cli-interp.h (make_logging_output): Remove declaration.
10223         * cli/cli-logging.c (make_logging_output): Remove function.
10224         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10225         directly.
10226         * ui-file.c (tee_file::tee_file): Remove bools.
10227         (tee_file::~tee_file): Remove deletes.
10228         * ui-file.h (tee_file): Remove bools.
10229
10230 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10231
10232         * mi/mi-cmds.h (mi_cmd_complete): New function.
10233         * mi/mi-main.c (mi_cmd_complete): Likewise.
10234         * mi/mi-cmds.c: Define new MI command -complete.
10235         * NEWS: Mention new -complete command.
10236
10237 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10238
10239         * completer.h (complete): New function.
10240         * completer.c (complete): Likewise.
10241         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10242         function defined in completer.h.
10243
10244 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10245
10246         * MAINTAINERS (Write After Approval): Add myself.
10247
10248 2019-05-17  Tom de Vries  <tdevries@suse.de>
10249
10250         PR gdb/24094
10251         * dwarf2read.c (struct cu_partial_die_info): New struct.
10252         (find_partial_die): Return cu_partial_die_info.
10253         (partial_die_parent_scope, guess_partial_die_structure_name)
10254         (partial_die_info::fixup): Handle new return type of find_partial_die.
10255
10256 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10257
10258         PR breakpoints/24541
10259         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10260         "std::string", simplifying the algorithm.
10261
10262 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10263
10264         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10265         (stap_static_probe_ops::get_probes): Likewise.
10266
10267 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10268
10269         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10270         '-')" and "else if".
10271         (stap_parse_single_operand): Join checks for
10272         "gdbarch_stap_parse_special_token_p" and
10273         "gdbarch_stap_parse_special_token" in the same "if" statement.
10274         Invert check when verifying for operation on register
10275         displacement.
10276
10277 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10278
10279         * stap-probe.c (stap_get_opcode): Update comment.
10280         (stap_get_expected_argument_type): Likewise.
10281         (handle_stap_probe): Likewise.
10282
10283 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10284
10285         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10286         return type to 'bool'.  Adjust comment.  Use 'bool' when
10287         appropriate.
10288         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10289         * stap-probe.c (stap_parse_argument_1): Likewise.
10290         (stap_is_operator): Likewise.
10291         (stap_is_generic_prefix): Likewise.
10292         (stap_is_register_prefix): Likewise.
10293         (stap_is_register_indirection_prefix): Likewise.
10294         (stap_is_integer_prefix): Likewise.
10295         (stap_generic_check_suffix): Likewise.
10296         (stap_check_integer_suffix): Likewise.
10297         (stap_check_register_suffix): Likewise.
10298         (stap_check_register_indirection_suffix): Likewise.
10299         (stap_parse_register_operand): Likewise.
10300         (stap_parse_single_operand): Likewise.
10301         (stap_parse_argument_1): Likewise.
10302         (stap_probe::get_argument_count): Likewise.
10303         (stap_is_operator): Likewise.
10304
10305 2019-05-16  Tom Tromey  <tromey@adacore.com>
10306
10307         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10308         keyword to foreach.
10309
10310 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10311
10312         * linux-thread-db.c (try_thread_db_load_1): Change return type
10313         to bool.
10314         (try_thread_db_load): Likewise.
10315         (try_thread_db_load_from_pdir_1): Likewise.
10316         (try_thread_db_load_from_pdir): Likewise.
10317         (try_thread_db_load_from_sdir): Likewise.
10318         (try_thread_db_load_from_dir): Likewise.
10319         (thread_db_load_search): Likewise.
10320         (has_libpthread): Likewise.
10321         (thread_db_load): Likewise.
10322
10323 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10324
10325         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10326         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10327         NULL, and complain/return if that's the case.
10328
10329 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10330
10331         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10332         (advance, posn, abstract_read_memory): New functions.
10333         [struct mem_read_abstraction]: New struct.
10334         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10335
10336 2019-05-14  Tom Tromey  <tromey@adacore.com>
10337
10338         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10339         value is not lval_memory.
10340
10341 2019-05-14  Tom Tromey  <tromey@adacore.com>
10342
10343         * solib.c (info_sharedlibrary_command): Style the file name.
10344
10345 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10346
10347         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10348         (aarch64_vnv_type): Likewise.
10349         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10350         * common/tdesc.c: Likewise.
10351         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10352         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10353         * features/aarch64-fpu.xml: Add ieee half view.
10354         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10355         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10356         * gdbtypes.h (struct builtin_type): Likewise.
10357         (struct objfile_type): Likewise.
10358
10359 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10360
10361         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10362         typo.
10363         * location.h (string_to_event_location): Likewise.
10364
10365 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10366
10367         GDB 8.3 released.
10368
10369 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10370
10371         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10372         New variable declaration.
10373         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10374         New variable.
10375         (print_one_breakpoint): Use ui_out::test_flags and new global
10376         variable to compute use_fixed_output.
10377         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10378         Remove.
10379         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10380         (mi_multi_location_breakpoint_output_fixed): Remove.
10381         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10382         new variable.
10383         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10384         fix_multi_location_breakpoint_output flag if version >= 3.
10385         * ui-out.h (enum ui_out_flag)
10386         <fix_multi_location_breakpoint_output>: New enumerator.
10387
10388 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10389
10390         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10391
10392 2019-05-10  Tom Tromey  <tromey@adacore.com>
10393
10394         * ada-lang.c (catch_ada_completer): New function.
10395         (_initialize_ada_language): Use it.
10396
10397 2019-05-10  Tom Tromey  <tromey@adacore.com>
10398
10399         * thread.c (print_thread_info): Make "requested_threads" const.
10400         * gdbthread.h (print_thread_info): Make "requested_threads"
10401         const.
10402         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10403         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10404
10405 2019-05-08  Tom Tromey  <tom@tromey.com>
10406
10407         * gdbtypes.c (objfile_type_data): Change type.
10408         (objfile_type, _initialize_gdbtypes): Update.
10409
10410 2019-05-08  Tom Tromey  <tom@tromey.com>
10411
10412         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10413         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10414         (_initialize_dwarf2_frame): Update.
10415
10416 2019-05-08  Tom Tromey  <tom@tromey.com>
10417
10418         * objc-lang.c (objc_objfile_data): Change type.
10419         (find_methods): Update.
10420         (_initialize_objc_lang): Remove.
10421
10422 2019-05-08  Tom Tromey  <tom@tromey.com>
10423
10424         * stabsread.c (rs6000_builtin_type_data): Change type.
10425         (rs6000_builtin_type, _initialize_stabsread): Update.
10426
10427 2019-05-08  Tom Tromey  <tom@tromey.com>
10428
10429         * mips-tdep.c (mips_pdr_data): Remove.
10430         (_initialize_mips_tdep): Update.
10431
10432 2019-05-08  Tom Tromey  <tom@tromey.com>
10433
10434         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10435         (hppa_init_objfile_priv_data, read_unwind_info)
10436         (find_unwind_entry, _initialize_hppa_tdep): Update.
10437
10438 2019-05-08  Tom Tromey  <tom@tromey.com>
10439
10440         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10441         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10442         on obstack.
10443         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10444
10445 2019-05-08  Tom Tromey  <tom@tromey.com>
10446
10447         * mdebugread.c (basic_type_data): Change type.
10448         (basic_type, _initialize_mdebugread): Update.
10449
10450 2019-05-08  Tom Tromey  <tom@tromey.com>
10451
10452         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10453
10454 2019-05-08  Tom Tromey  <tom@tromey.com>
10455
10456         * nto-tdep.c (nto_inferior_data_reg): Change type.
10457         (nto_inferior_data): Update.
10458         (nto_inferior_data_cleanup, nto_new_inferior_data)
10459         (_initialize_nto_tdep): Remove.
10460         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10461
10462 2019-05-08  Tom Tromey  <tom@tromey.com>
10463
10464         * ada-lang.c (struct ada_inferior_data): Add initializers.
10465         (ada_inferior_data): Change type.
10466         (ada_inferior_data_cleanup): Remove.
10467         (get_ada_inferior_data, ada_inferior_exit)
10468         (struct ada_pspace_data): Add initializers, destructor.
10469         (ada_pspace_data_handle): Change type.
10470         (get_ada_pspace_data): Update.
10471         (ada_pspace_data_cleanup): Remove.
10472
10473 2019-05-08  Tom Tromey  <tom@tromey.com>
10474
10475         * coffread.c (struct coff_symfile_info): Add initializers.
10476         (coff_objfile_data_key): Move lower.  Change type.
10477         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10478         Update.
10479         (coff_free_info): Remove.
10480
10481 2019-05-08  Tom Tromey  <tom@tromey.com>
10482
10483         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10484         (fbsd_pspace_data_handle): Move lower.  Change type.
10485         (get_fbsd_pspace_data): Update.
10486         (fbsd_pspace_data_cleanup): Remove.
10487         (_initialize_fbsd_tdep): Update.
10488
10489 2019-05-08  Tom Tromey  <tom@tromey.com>
10490
10491         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10492         (get_ada_tasks_pspace_data): Update.
10493         (ada_tasks_pspace_data_cleanup): Remove.
10494         (_initialize_tasks): Update.
10495         (ada_tasks_inferior_data_handle): Change type.
10496         (get_ada_tasks_inferior_data): Update.
10497         (ada_tasks_inferior_data_cleanup): Remove.
10498         (struct ada_tasks_pspace_data): Add initializers.
10499
10500 2019-05-08  Tom Tromey  <tom@tromey.com>
10501
10502         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10503         * symfile-debug.c (debug_sym_get_probes): Change type.
10504         * stap-probe.c (handle_stap_probe):
10505         (stap_static_probe_ops::get_probes): Change type.
10506         * probe.h (class static_probe_ops) <get_probes>: Change type.
10507         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10508         (parse_probes_in_pspace): Update.
10509         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10510         Update.
10511         (any_static_probe_ops::get_probes): Change type.
10512         * elfread.c (elfread_data): New typedef.
10513         (probe_key): Change type.
10514         (elf_get_probes): Likewise.  Update.
10515         (probe_key_free): Remove.
10516         (_initialize_elfread): Update.
10517         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10518         Change type.
10519         (dtrace_process_dof_probe, dtrace_process_dof)
10520         (dtrace_static_probe_ops::get_probe): Change type.
10521
10522 2019-05-08  Tom Tromey  <tom@tromey.com>
10523
10524         * xcoffread.c (struct xcoff_symfile_info): Rename from
10525         coff_symfile_info.  Add initializers.
10526         (xcoff_objfile_data_key): Move lower.  Change type.
10527         (XCOFF_DATA): Rewrite.
10528         (xcoff_free_info): Remove.
10529         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10530         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10531         (xcoff_initial_scan): Update.
10532
10533 2019-05-08  Tom Tromey  <tom@tromey.com>
10534
10535         * solib-svr4.c (struct svr4_info): Add initializers and
10536         destructor.
10537         <probes_table>: Now an htab_up.
10538         (solib_svr4_pspace_data): Change type.
10539         (free_probes_table): Simplify.
10540         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10541         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10542         (probes_table_remove_objfile_probes, register_solib_event_probe)
10543         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10544         (_initialize_svr4_solib): Update.
10545
10546 2019-05-08  Tom Tromey  <tom@tromey.com>
10547
10548         * remote.c (remote_pspace_data): Change type.
10549         (remote_pspace_data_cleanup): Remove.
10550         (get_remote_exec_file, set_pspace_remote_exec_file)
10551         (_initialize_remote): Update.
10552
10553 2019-05-08  Tom Tromey  <tom@tromey.com>
10554
10555         * breakpoint.c (breakpoint_objfile_key): Change type.
10556         (get_breakpoint_objfile_data): Update.
10557         (free_breakpoint_objfile_data): Remove.
10558         (_initialize_breakpoint): Update.
10559
10560 2019-05-08  Tom Tromey  <tom@tromey.com>
10561
10562         * linux-tdep.c (struct linux_info): Add initializers.
10563         (linux_inferior_data): Move.  Change type.
10564         (invalidate_linux_cache_inf): Update.
10565         (linux_inferior_data_cleanup): Remove.
10566         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10567
10568 2019-05-08  Tom Tromey  <tom@tromey.com>
10569
10570         * auxv.c (auxv_inferior_data): Move.  Change type.
10571         (auxv_inferior_data_cleanup): Remove.
10572         (invalidate_auxv_cache_inf): Rewrite.
10573         (get_auxv_inferior_data, _initialize_auxv): Update.
10574
10575 2019-05-08  Tom Tromey  <tom@tromey.com>
10576
10577         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10578         (symfile_debug_objfile_data_key): Change type.
10579         (symfile_debug_installed, debug_qf_has_symbols)
10580         (debug_qf_find_last_source_symtab)
10581         (debug_qf_forget_cached_source_info)
10582         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10583         (debug_qf_print_stats, debug_qf_dump)
10584         (debug_qf_expand_symtabs_for_function)
10585         (debug_qf_expand_all_symtabs)
10586         (debug_qf_expand_symtabs_with_fullname)
10587         (debug_qf_map_matching_symbols)
10588         (debug_qf_expand_symtabs_matching)
10589         (debug_qf_find_pc_sect_compunit_symtab)
10590         (debug_qf_map_symbol_filenames)
10591         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10592         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10593         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10594         (debug_sym_read_linetable, debug_sym_relocate): Update.
10595         (symfile_debug_free_objfile): Remove.
10596         (install_symfile_debug_logging, _initialize_symfile_debug):
10597         Update.
10598
10599 2019-05-08  Tom Tromey  <tom@tromey.com>
10600
10601         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10602         allocate_on_obstack.
10603         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10604         (get_dwarf2_per_objfile): Update.
10605         (set_dwarf2_per_objfile): Remove.
10606         (dwarf2_has_info, dwarf2_get_section_info): Update.
10607         (dwarf2_free_objfile): Remove.
10608         (_initialize_dwarf2_read): Update.
10609
10610 2019-05-08  Tom Tromey  <tom@tromey.com>
10611
10612         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10613         initializers.
10614         <unsupported_script_warning_printed,
10615         script_not_found_warning_printed>: Now bool.
10616         (auto_load_pspace_data): Change type.
10617         (~auto_load_pspace_info): Rename from
10618         auto_load_pspace_data_cleanup.
10619         (get_auto_load_pspace_data, init_loaded_scripts_info)
10620         (clear_section_scripts, maybe_print_unsupported_script_warning)
10621         (maybe_print_script_not_found_warning, _initialize_auto_load):
10622         Update.
10623
10624 2019-05-08  Tom Tromey  <tom@tromey.com>
10625
10626         * objfiles.c (objfile_pspace_info): Add destructor and
10627         initializers.
10628         (objfiles_pspace_data): Change type.
10629         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10630         (get_objfile_pspace_data): Update.
10631         (objfiles_bfd_data): Change type.
10632         (get_objfile_bfd_data): Update.
10633         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10634
10635 2019-05-08  Tom Tromey  <tom@tromey.com>
10636
10637         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10638         Change type.
10639         (get_catch_syscall_inferior_data): Update.
10640         (catch_syscall_inferior_data_cleanup): Remove.
10641         (_initialize_break_catch_syscall): Update.
10642
10643 2019-05-08  Tom Tromey  <tom@tromey.com>
10644
10645         * inflow.c (struct terminal_info): Add destructor and
10646         initializers.
10647         (inflow_inferior_data): Change type.
10648         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10649         (get_inflow_inferior_data, inflow_inferior_exit)
10650         (swap_terminal_info, _initialize_inflow): Update.
10651
10652 2019-05-08  Tom Tromey  <tom@tromey.com>
10653
10654         * target-dcache.c (target_dcache_cleanup): Remove.
10655         (target_dcache_aspace_key): Change type.
10656         (target_dcache_init_p, target_dcache_invalidate)
10657         (target_dcache_get, target_dcache_get_or_init)
10658         (_initialize_target_dcache): Update.
10659         * dcache.h (struct dcache_deleter): New.
10660
10661 2019-05-08  Tom Tromey  <tom@tromey.com>
10662
10663         * symtab.c (struct symbol_cache): Add destructor and
10664         initializers.
10665         (symbol_cache_key): Move.  Change type.
10666         (make_symbol_cache, free_symbol_cache): Remove.
10667         (get_symbol_cache): Update.
10668         (symbol_cache_cleanup): Remove.
10669         (ALL_PSPACES, symbol_cache_flush)
10670         (maintenance_print_symbol_cache)
10671         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10672         Update.
10673
10674 2019-05-08  Tom Tromey  <tom@tromey.com>
10675
10676         * symtab.c (struct main_info): Add destructor and initializers.
10677         (main_progspace_key): Move.  Change type.
10678         (get_main_info): Update.
10679         (main_info_cleanup): Remove.
10680         (_initialize_symtab): Update.
10681
10682 2019-05-08  Tom Tromey  <tom@tromey.com>
10683
10684         * registry.h (DECLARE_REGISTRY): Define the _key class.
10685
10686 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10687
10688         * NEWS: Merge two 'New commands' sections.
10689
10690 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10691
10692         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10693         parameter and use Ada language definition instead.
10694         (ada_val_print_ptr): Remove unused language parameter.
10695         (ada_val_print_num): Remove language parameter and use Ada language
10696         definition instead.
10697         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10698         parameter.
10699         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10700         parameter and use Ada language definition instead.
10701         (ada_val_print_1): Update all ada_val_print_xxx calls.
10702         Remove language parameter.
10703         (ada_val_print): Update ada_val_print_1 call.
10704
10705 2019-05-08  Tom Tromey  <tromey@adacore.com>
10706
10707         * remote.c (remote_hw_watchpoint_limit)
10708         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10709         Now static.
10710
10711 2019-05-08  Tom Tromey  <tromey@adacore.com>
10712
10713         * maint.c (_initialize_maint_cmds): Move initialization code to
10714         remote.c.
10715         (watchdog, show_watchdog): Move to remote.c.
10716         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10717         "watchdog" static.
10718         (_initialize_remote): Move initialization code from maint.c.
10719         * defs.h (watchdog): Don't declare.
10720
10721 2019-05-08  Tom Tromey  <tromey@adacore.com>
10722
10723         * tui/tui-interp.c: Include main.h.
10724         * interps.c: Include main.h.
10725         * main.h (interpreter_p): Declare.
10726         * defs.h (interpreter_p): Don't declare.
10727
10728 2019-05-08  Tom Tromey  <tromey@adacore.com>
10729
10730         * dwarf2loc.c: Include dwarf2read.h.
10731         * defs.h (read_unsigned_leb128): Don't declare.
10732         * dwarf2read.h (read_unsigned_leb128): Declare.
10733
10734 2019-05-08  Tom Tromey  <tromey@adacore.com>
10735
10736         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10737         method.
10738
10739 2019-05-08  Tom Tromey  <tromey@adacore.com>
10740
10741         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10742         when no wrap column is set.
10743
10744 2019-05-08  Tom Tromey  <tromey@adacore.com>
10745
10746         * c-lang.c (c_get_string): Handle non-C-style arrays.
10747
10748 2019-05-08  Tom Tromey  <tromey@adacore.com>
10749
10750         * typeprint.c (print_offset_data::update): Print the bit offset,
10751         not the number of bits remaining.
10752
10753 2019-05-08  Tom Tromey  <tromey@adacore.com>
10754
10755         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10756         padding at end of comment.
10757
10758 2019-05-08  Tom Tromey  <tromey@adacore.com>
10759
10760         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10761         Compare main types.
10762
10763 2019-05-06  Tom Tromey  <tom@tromey.com>
10764
10765         * common/scoped_mmap.c: Include common-defs.h.
10766         * common/scoped_mmap.h: Don't include config.h.
10767
10768 2019-05-04  Tom Tromey  <tom@tromey.com>
10769
10770         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10771         (struct aarch64_call_info): Add initializers.
10772         <si>: Now a std::vector.
10773         (pass_on_stack, aarch64_push_dummy_call): Update.
10774
10775 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10776             Tom Tromey  <tom@tromey.com>
10777
10778         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10779         (ppc_threads): Now a std::vector.  Now static.
10780         (hwdebug_find_thread_points_by_tid)
10781         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10782         Update.
10783
10784 2019-05-04  Tom Tromey  <tom@tromey.com>
10785
10786         * arc-tdep.c (arc_tdesc_init): Return bool.
10787
10788 2019-05-04  Tom Tromey  <tom@tromey.com>
10789
10790         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10791         Use gdb_assert_not_reached.
10792
10793 2019-05-04  Tom Tromey  <tom@tromey.com>
10794
10795         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10796         "false".
10797
10798 2019-05-04  Tom Tromey  <tom@tromey.com>
10799
10800         * arc-tdep.c (arc_tdesc_init): Use bool.
10801
10802 2019-05-04  Tom Tromey  <tom@tromey.com>
10803
10804         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10805
10806 2019-05-04  Tom Tromey  <tom@tromey.com>
10807
10808         * cli/cli-cmds.c (valid_command_p): Return bool.
10809
10810 2019-05-04  Tom Tromey  <tom@tromey.com>
10811
10812         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10813         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10814
10815 2019-05-04  Raul Tambre  <raul@tambre.ee>
10816
10817         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10818         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10819         operator for comparison.
10820
10821 2019-05-04  Tom Tromey  <tom@tromey.com>
10822
10823         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10824         (lookup_partial_symbol, print_partial_symbols)
10825         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10826         (psymbol_compare): Update.
10827         (add_psymbol_to_bcache): Clear the entire psymbol.
10828         (maintenance_check_psymtabs): Update.
10829         * psympriv.h (struct partial_symbol): Don't derive from
10830         general_symbol_info.
10831         <obj_section, unrelocated_address, address,
10832         set_unrelocated_address>: Update.
10833         <ginfo>: New member.
10834         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10835         (debug_names::write_psymbols): Update.
10836
10837 2019-05-04  Tom de Vries  <tdevries@suse.de>
10838
10839         * contrib/cc-with-tweaks.sh: Support -n arg.
10840
10841 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10842
10843         * corelow.c (core_target::detach): Ensure frame cache and
10844         register caches are cleared.
10845         inferior.c (exit_inferior_1): Likewise.
10846
10847 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10848             Tom Tromey  <tom@tromey.com>
10849
10850         * dictionary.c (collate_pending_symbols_by_language): Remove
10851         "struct" from foreach.
10852         * symtab.c (lookup_global_symbol_from_objfile)
10853         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10854         foreach.
10855         * ser-tcp.c (net_open): Remove "struct" from foreach.
10856         * objfiles.c (objfile_relocate, objfile_rebase)
10857         (objfile_has_symbols): Remove "struct" from foreach.
10858         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10859         from foreach.
10860         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10861         foreach.
10862         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10863         "struct" from foreach.
10864         * ada-lang.c (create_excep_cond_exprs)
10865         (ada_exception_catchpoint_cond_string): Remove "struct" from
10866         foreach.
10867
10868 2019-05-03  Tom Tromey  <tromey@adacore.com>
10869
10870         * ada-exp.y (convert_char_literal): Check suffix of each
10871         enumerator.
10872
10873 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10874
10875         PR ada/21406:
10876         * ada-exp.y (yywrap): Don't define.
10877         * ada-lex.l (%option): Add noyywrap
10878         (yywrap): Remove.
10879
10880 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10881
10882         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10883         _WIN32_WINNT to the XP level, unless already defined to a higher
10884         level.
10885
10886         * unittests/parse-connection-spec-selftests.c:
10887         * ser-tcp.c:
10888         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10889         override.
10890
10891         * symfile.c (find_separate_debug_file): Remove colon from the
10892         drive spec of DOS/Windows file names of the target, so that the
10893         file name produced from DEBUGDIR and the target's directory will
10894         be valid on DOS/Windows systems.
10895
10896 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10897
10898         * rust-lang.c (val_print_struct): Handle printing structures
10899         containing strings.
10900
10901 2019-05-02  Tom Tromey  <tromey@adacore.com>
10902
10903         * valarith.c (_initialize_valarith): Remove.
10904
10905 2019-05-01  Tom Tromey  <tromey@adacore.com>
10906
10907         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10908         bitfields.
10909
10910 2019-05-01  Tom Tromey  <tromey@adacore.com>
10911
10912         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10913         for big-endian copies.
10914
10915 2019-04-30  Ali Tamur  <tamur@google.com>
10916         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10917         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10918         (read_3_bytes): New function.
10919
10920 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10921
10922         * windows-nat.c (main_thread_id): Delete.
10923         (handle_output_debug_string): Replace main_thread_id by
10924         current_event.dwThreadId.
10925         (fake_create_process): Likewise.
10926         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10927         Do not set main_thread_id.
10928         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10929         current_event.dwThreadId.
10930         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10931
10932 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10933
10934         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
10935         Use current_event.dwThreadId instead of main_thread_id.
10936
10937 2019-04-30  Tom Tromey  <tromey@adacore.com>
10938
10939         * ada-lang.c (ada_lookup_simple_minsyms): New function.
10940         (create_excep_cond_exprs): Iterate over program spaces.
10941         (ada_exception_catchpoint_cond_string): Examine all minimal
10942         symbols for exception types.
10943
10944 2019-04-30  Tom Tromey  <tromey@adacore.com>
10945
10946         PR c++/24470:
10947         * dwarf2read.c (process_structure_scope): Handle case where type
10948         has template parameters but no symbol was created.
10949
10950 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10951             Chris January  <chris.january@arm.com>
10952
10953         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
10954         qualifier.
10955         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
10956
10957 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10958
10959         * f-typeprint.c (f_print_type): Update rules for printing
10960         whitespace.
10961         (f_type_print_varspec_suffix): Likewise.
10962
10963 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10964             Chris January  <chris.january@arm.com>
10965
10966         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
10967         function arguments.
10968
10969 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10970
10971         * f-lang.c (build_fortran_types): Change name of void type to
10972         lower case.
10973         * f-typeprint.c (f_type_print_base): Print the name of the void
10974         type, rather than a fixed string.
10975         * f-valprint.c (f_decorations): Use lower case void string.
10976
10977 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10978             Chris January  <chris.january@arm.com>
10979
10980         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
10981         types for Fortran.
10982
10983 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
10984             Chris January  <chris.january@arm.com>
10985             David Lecomber  <david.lecomber@arm.com>
10986
10987         * f-exp.y (BINOP_INTRINSIC): New token.
10988         (exp): New parser rule handling BINOP_INTRINSIC.
10989         (f77_keywords): Add new builtin procedures.
10990         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
10991         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10992         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
10993         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10994         (print_unop_subexp_f): New function.
10995         (print_binop_subexp_f): New function.
10996         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
10997         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
10998         (dump_subexp_body_f): Likewise.
10999         (operator_check_f): Likewise.
11000         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11001         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11002
11003 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11004
11005         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11006         UNOP_KIND.
11007         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11008         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11009         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11010         (operator_length_f): New fuction.
11011         (print_subexp_f): New function.
11012         (op_name_f): New function.
11013         (dump_subexp_body_f): New function.
11014         (operator_check_f): New function.
11015         (exp_descriptor_f): Replace standard expression handling functions
11016         with new functions.
11017         * gdb/fortran-operator.def: New file.
11018         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11019         * gdb/std-operator.def: Remove UNOP_KIND.
11020
11021 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11022
11023         * std-operator.def: Remove unbalanced, stray double quote
11024         character.
11025
11026 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11027             Chris January  <chris.january@arm.com>
11028             Daniel Everett  <daniel.everett@arm.com>
11029             Nick Forrington  <nick.forrington@arm.com>
11030             Richard Bunt  <richard.bunt@arm.com>
11031
11032         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11033         of depth when printing anonymous structs or unions.
11034         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11035         Don't print either the top-level value, or the children if the
11036         max-depth is exceeded.
11037         (ppscm_print_children): When printing the key of a map, allow one
11038         extra level of depth.
11039         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11040         print either the top-level value, or the children if the max-depth
11041         is exceeded.
11042         (print_children): When printing the key of a map, allow one extra
11043         level of depth.
11044         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11045         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11046         (user_print_options): Initialise max_depth field.
11047         (val_print_scalar_or_string_type_p): New function.
11048         (val_print): Check to see if the max depth has been reached.
11049         (val_print_check_max_depth): Define new function.
11050         (show_print_max_depth): New function.
11051         (_initialize_valprint): Add 'print max-depth' option.
11052         * valprint.h (struct value_print_options) <max_depth>: New field.
11053         (val_print_check_max_depth): Declare new function.
11054         * NEWS: Document new feature.
11055
11056 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11057
11058         * ada-lang.c (ada_language_defn): Initialise new field.
11059         * c-lang.c (c_is_string_type_p): New function.
11060         (c_language_defn): Initialise new field.
11061         (cplus_language_defn): Initialise new field.
11062         (asm_language_defn): Initialise new field.
11063         (minimal_language_defn): Initialise new field.
11064         * c-lang.h (c_is_string_type_p): Declare new function.
11065         * d-lang.c (d_language_defn): Initialise new field.
11066         * f-lang.c (f_is_string_type_p): New function.
11067         (f_language_defn): Initialise new field.
11068         * go-lang.c (go_is_string_type_p): New function.
11069         (go_language_defn): Initialise new field.
11070         * language.c (default_is_string_type_p): New function.
11071         (unknown_language_defn): Initialise new field.
11072         (auto_language_defn): Initialise new field.
11073         * language.h (struct language_defn) <la_is_string_type_p>: New
11074         member variable.
11075         (default_is_string_type_p): Declare new function.
11076         * m2-lang.c (m2_language_defn): Initialise new field.
11077         * objc-lang.c (objc_language_defn): Initialise new field.
11078         * opencl-lang.c (opencl_language_defn): Initialise new field.
11079         * p-lang.c (pascal_is_string_type_p): New function.
11080         (pascal_language_defn): Initialise new field.
11081         * rust-lang.c (rust_is_string_type_p): New function.
11082         (rust_language_defn): Initialise new field.
11083
11084 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11085
11086         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11087         New field.
11088         * ada-lang.c (ada_language_defn): Initialise new field.
11089         * c-lang.c (c_language_defn): Likewise.
11090         (cplus_language_defn): Likewise.
11091         (asm_language_defn): Likewise.
11092         (minimal_language_defn): Likewise.
11093         * d-lang.c (d_language_defn): Likewise.
11094         * f-lang.c (f_language_defn): Likewise.
11095         * go-lang.c (go_language_defn): Likewise.
11096         * language.c (unknown_language_defn): Likewise.
11097         (auto_language_defn): Likewise.
11098         * m2-lang.c (m2_language_defn): Likewise.
11099         * objc-lang.c (objc_language_defn): Likewise.
11100         * opencl-lang.c (opencl_language_defn): Likewise.
11101         * p-lang.c (pascal_language_defn): Likewise.
11102         * rust-lang.c (rust_language_defn): Likewise.
11103
11104 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11105
11106         * ada-lang.c (ada_is_character_type): Change return type to bool.
11107         (ada_is_string_type): Likewise.
11108         * ada-lang.h (ada_is_character_type): Update declaration
11109         (ada_is_string_type): Likewise.
11110
11111 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11112
11113         Support style in 'frame|thread apply'
11114
11115         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11116         * record.c (record_start, record_stop): Update callers of
11117         execute_command_to_string with false.
11118         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11119         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11120         methods.
11121         (class string_file): New constructor with term_out parameter.
11122         Override methods term_out and can_emit_style_escape.  New member
11123         term_out.
11124         (class stdio_file): Override can_emit_style_escape.
11125         (class tee_file): Override term_out and can_emit_style_escape.
11126         * utils.h (can_emit_style_escape): Remove.
11127         * utils.c (can_emit_style_escape): Likewise.
11128         Update all callers of can_emit_style_escape (SOMESTREAM) to
11129         SOMESTREAM->can_emit_style_escape.
11130         * source-cache.c (source_cache::get_source_lines): Likewise.
11131         * stack.c (frame_apply_command_count): Call execute_command_to_string
11132         passing the term_out characteristic of the current gdb_stdout.
11133         * thread.c (thr_try_catch_cmd): Likewise.
11134         * top.c (execute_command_to_string): pass term_out parameter
11135         to construct the string_file for the command output.
11136         * ui-file.c (term_cli_styling): New function (most code moved
11137         from utils.c can_emit_style_escape).
11138         (string_file::string_file, string_file::can_emit_style_escape,
11139         stdio_file::can_emit_style_escape, tee_file::term_out,
11140         tee_file::can_emit_style_escape): New functions.
11141
11142 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11143
11144         * NEWS: Mention the new set|show may-call-functions.
11145         * infcall.c (may_call_functions_p): New variable.
11146         (show_may_call_functions_p): New function.
11147         (call_function_by_hand_dummy): Throws an error if not
11148         may-call-functions.
11149         (_initialize_infcall): Call add_setshow_boolean_cmd for
11150         may-call-functions.
11151
11152 2019-04-25  Keith Seitz  <keiths@redhat.com>
11153
11154         PR c++/24367
11155         * cp-support.c (inspect_type): Don't attempt substitutions
11156         of symbol with the same name.
11157
11158 2019-04-25  Tom Tromey  <tromey@adacore.com>
11159
11160         PR gdb/24475:
11161         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11162         static.
11163
11164 2019-04-25  Tom Tromey  <tromey@adacore.com>
11165
11166         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11167         rvalue reference.
11168         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11169         (gdb_xml_parser::parse): Use std::move.
11170         * python/python-internal.h (gdbpy_convert_exception): Take a const
11171         reference.
11172         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11173         std::move.
11174         * python/py-utils.c (gdbpy_convert_exception): Take a const
11175         reference.
11176         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11177         Use std::move.
11178         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11179         Use std::move.
11180         * mi/mi-main.c (mi_print_exception): Take a const reference.
11181         * main.c (handle_command_errors): Take a const reference.
11182         * linespec.c (parse_linespec): Use std::move.
11183         * infcall.c (run_inferior_call): Use std::move.
11184         (call_function_by_hand_dummy): Use std::move.
11185         * exec.c (try_open_exec_file): Use std::move.
11186         * exceptions.h (exception_print, exception_fprintf)
11187         (exception_print_same): Update.
11188         * exceptions.c (print_exception, exception_print)
11189         (exception_fprintf, exception_print_same): Change parameters to
11190         const reference.
11191         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11192         * common/new-op.c: Use std::move.
11193         * common/common-exceptions.h (struct gdb_exception): Add move
11194         constructor.
11195         (struct gdb_exception_error, struct gdb_exception_quit, struct
11196         gdb_quit_bad_alloc): Change constructor to move constructor.
11197         (throw_exception): Change parameter to rvalue reference.
11198         * common/common-exceptions.c (throw_exception): Take rvalue
11199         reference.
11200         * cli/cli-interp.c (safe_execute_command): Use std::move.
11201         * breakpoint.c (insert_bp_location, location_to_sals): Use
11202         std::move.
11203
11204 2019-04-25  Tom Tromey  <tromey@adacore.com>
11205
11206         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11207         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11208         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11209         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11210         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11211         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11212         guile/scm-value.c: Use unpack.
11213         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11214         gdbscm_gdb_exception.
11215         (gdbscm_throw_gdb_exception): Likewise.
11216         (struct gdbscm_gdb_exception): New.
11217         (unpack): New function.
11218         (gdbscm_wrap): Use unpack.
11219
11220 2019-04-25  Tom Tromey  <tromey@adacore.com>
11221
11222         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11223         (gdb_rl_callback_handler): Use std::move.
11224         * common/common-exceptions.h (struct gdb_exception): Add move
11225         assignment operator.
11226         (throw_exception_sjlj): Change "exception" to const reference.
11227         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11228         (throw_exception_sjlj): Change "exception" to const reference.
11229
11230 2019-04-25  Tom Tromey  <tromey@adacore.com>
11231
11232         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11233         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11234         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11235         Update.
11236         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11237         Update.
11238         * mi/mi-interp.c (mi_interp::exec): Update.
11239         * linespec.c (parse_linespec): Update.
11240         * infcall.c (run_inferior_call): Update.
11241         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11242         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11243         (gdbscm_lookup_global_symbol): Update.
11244         * guile/scm-param.c (gdbscm_parameter_value): Update.
11245         * guile/scm-frame.c (gdbscm_frame_read_register)
11246         (gdbscm_frame_read_var): Update.
11247         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11248         * exec.c (try_open_exec_file): Update.
11249         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11250         (gdb_rl_callback_handler): Update.
11251         * common/common-exceptions.h (exception_none): Don't declare.
11252         * common/common-exceptions.c (exception_none): Don't define.
11253         (struct catcher) <exception>: Update.
11254         * cli/cli-interp.c (safe_execute_command): Update.
11255         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11256
11257 2019-04-25  Ali Tamur  <tamur@google.com>
11258
11259         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11260         (read_attribute_value): Likewise.
11261         (dwarf2_read_addr_index): Update comment.
11262         (read_str_index): Add DW_FORM_strx.
11263         (dwarf2_string_attr): Likewise.
11264         (dwarf2_const_value_attr): Likewise.
11265         (dump_die_shallow): Likewise.
11266         (dwarf2_fetch_constant_bytes): Likewise.
11267         (skip_form_bytes): Likewise.
11268         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11269
11270 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11271
11272         PR corefiles/11608
11273         PR corefiles/18187
11274         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11275         OFFSET.  Verify if current mapping contains an ELF header.
11276         (linux_find_memory_regions_full): Adjust call to
11277         dump_mapping_p.
11278
11279 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11280             Kang Li <kanglictf@gmail.com>
11281
11282         PR gdb/21600
11283
11284         * dwarf2-frame.c (read_initial_length): Be consistent about using
11285         unsigned representation of length.
11286         (decode_frame_entry_1): Likewise.  Check for wraparound of
11287         end pointer as well as buffer overflow.
11288
11289 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11290
11291         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11292         "vq".
11293
11294 2019-04-24  Tom Tromey  <tromey@adacore.com>
11295
11296         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11297
11298 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11299
11300         * s12z-tdep.c (s12z_unwind_pc): Delete.
11301         (s12z_unwind_sp): Delete.
11302         (s12z_gdbarch_init): Don't register deleted functions with
11303         gdbarch.
11304
11305 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11306
11307         * rl78-tdep.c (rl78_unwind_sp): Delete.
11308         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11309
11310 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11311
11312         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11313         (xstormy16_unwind_pc): Delete.
11314         (xstormy16_dummy_id): Delete.
11315         (xstormy16_gdbarch_init): Don't register deleted functions with
11316         gdbarch.
11317
11318 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11319
11320         * vax-tdep.c (vax_unwind_pc): Delete.
11321         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11322
11323 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11324
11325         * v850-tdep.c (v850_unwind_sp): Delete.
11326         (v850_unwind_pc): Delete.
11327         (v850_dummy_id): Delete.
11328         (v850_gdbarch_init): Don't register deleted functions with
11329         gdbarch.
11330
11331 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11332
11333         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11334         (tilegx_unwind_pc): Delete.
11335         (tilegx_unwind_dummy_id): Delete.
11336         (tilegx_gdbarch_init): Don't register deleted functions with
11337         gdbarch.
11338
11339 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11340
11341         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11342         (tic6x_dummy_id): Delete.
11343         (tic6x_gdbarch_init): Don't register deleted functions with
11344         gdbarch.
11345
11346 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11347
11348         * sparc-tdep.c (sparc_unwind_pc): Delete.
11349         (sparc32_gdbarch_init): Don't register deleted function with
11350         gdbarch.
11351
11352 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11353
11354         * sh-tdep.c (sh_unwind_sp): Delete.
11355         (sh_unwind_pc): Delete.
11356         (sh_dummy_id): Delete.
11357         (sh_gdbarch_init): Don't register deleted functions with
11358         gdbarch.
11359
11360 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11361
11362         * score-tdep.c (score_unwind_sp): Delete.
11363         (score_unwind_pc): Delete.
11364         (score_dummy_id): Delete.
11365         (score_gdbarch_init): Don't register deleted functions with
11366         gdbarch.
11367
11368 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11369
11370         * rx-tdep.c (rx_unwind_pc): Delete.
11371         (rx_unwind_sp): Delete.
11372         (rx_dummy_id): Delete.
11373         (rx_gdbarch_init): Don't register deleted functions with
11374         gdbarch.  Update comment.
11375
11376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11377
11378         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11379         (rs6000_dummy_id): Delete.
11380         (rs6000_gdbarch_init): Don't register deleted functions with
11381         gdbarch.
11382
11383 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11384
11385         * or1k-tdep.c (or1k_dummy_id): Delete.
11386         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11387
11388 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11389
11390         * nios2-tdep.c (nios2_dummy_id): Delete.
11391         (nios2_unwind_sp): Delete.
11392         (nios2_gdbarch_init): Don't register deleted functions with
11393         gdbarch.
11394
11395 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11396
11397         * nds32-tdep.c (nds32_dummy_id): Delete.
11398         (nds32_unwind_pc): Delete.
11399         (nds32_unwind_sp): Delete.
11400         (nds32_gdbarch_init): Don't register deleted functions with
11401         gdbarch.
11402
11403 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11404
11405         * msp430-tdep.c (msp430_unwind_pc): Delete.
11406         (msp430_unwind_sp): Delete.
11407         (msp430_dummy_id): Delete.
11408         (msp430_gdbarch_init): Don't register deleted functions with
11409         gdbarch.
11410
11411 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11412
11413         * moxie-tdep.c (moxie_unwind_sp): Delete.
11414         (moxie_unwind_pc): Delete.
11415         (moxie_dummy_id): Delete.
11416         (moxie_gdbarch_init): Don't register deleted functions with
11417         gdbarch.
11418
11419 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11420
11421         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11422         (mn10300_unwind_pc): Delete.
11423         (mn10300_unwind_sp): Delete.
11424         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11425         mn10300_unwind_sp.
11426         (mn10300_frame_unwind_init): Don't register deleted functions with
11427         gdbarch.
11428
11429 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11430
11431         * mep-tdep.c (mep_unwind_pc): Delete.
11432         (mep_unwind_sp): Delete.
11433         (mep_dummy_id): Delete.
11434         (mep_gdbarch_init): Don't register deleted functions with
11435         gdbarch.
11436
11437 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11438
11439         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11440         (m68hc11_unwind_sp): Delete.
11441         (m68hc11_gdbarch_init): Don't register deleted functions with
11442         gdbarch.
11443
11444 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11445
11446         * m32r-tdep.c (m32r_unwind_sp): Delete.
11447         (m32r_unwind_pc): Delete.
11448         (m32r_dummy_id): Delete.
11449         (m32r_gdbarch_init): Don't register deleted functions with
11450         gdbarch.
11451
11452 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11453
11454         * m32c-tdep.c (m32c_unwind_pc): Delete.
11455         (m32c_unwind_sp): Delete.
11456         (m32c_dummy_id): Delete.
11457         (m32c_gdbarch_init): Don't register deleted functions with
11458         gdbarch.
11459
11460 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11461
11462         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11463         (lm32_unwind_pc): Delete.
11464         (lm32_dummy_id): Delete.
11465         (lm32_gdbarch_init): Don't register deleted functions with
11466         gdbarch.
11467
11468 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11469
11470         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11471         (iq2000_unwind_pc): Delete.
11472         (iq2000_dummy_id): Delete.
11473         (iq2000_gdbarch_init): Don't register deleted functions with
11474         gdbarch.
11475
11476 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11477
11478         * nds32-tdep.c (nds32_type_align): Delete.
11479         (nds32_push_dummy_call): Use type_align instead.
11480
11481 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11482
11483         * arm-tdep.c (arm_type_align): Only handle vector override case.
11484         (arm_push_dummy_call): Use type_align.
11485         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11486
11487 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11488
11489         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11490         case.
11491         (pass_on_stack): Use type_align.
11492         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11493         function.
11494
11495 2019-04-23  Tom Tromey  <tromey@adacore.com>
11496
11497         * dwarf2read.c (line_header::file_name_at): Remove unused
11498         overload.
11499
11500 2019-04-23  Tom de Vries  <tdevries@suse.de>
11501
11502         PR gdb/24438
11503         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11504         invocation.
11505
11506
11507 2019-03-27  Ali Tamur  <tamur@google.com>
11508
11509         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11510         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11511         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11512         (dwarf_expr_context::get_addr_index): Likewise
11513         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11514         (symbol_needs_eval_context::get_addr_index): Likewise
11515         (disassemble_dwarf_expression): Add DW_OP_addrx
11516         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11517         (read_cutu_die_from_dwo): Update comment
11518         (skip_one_die): Add DW_FORM_addrx
11519         (read_attribute_value): Likewise
11520         (var_decode_location): Add DW_OP_addrx
11521         (dwarf2_const_value_attr): Add DW_FORM_addrx
11522         (dump_die_shallow): Likewise
11523         (dwarf2_fetch_constant_bytes): Likewise
11524         (decode_locdesc): Add DW_OP_addrx
11525         (skip_form_bytes): Add DW_FORM_addrx
11526
11527 2019-04-22  Ali Tamur  <tamur@google.com>
11528
11529         * MAINTAINERS (Write After Approval): Add self.
11530
11531 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11532
11533         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11534         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11535         (open_symbol_file_object): Likewise.
11536         (svr4_default_sos): Add info parameter.
11537         (svr4_read_so_list): Likewise.
11538         (svr4_current_sos_direct): Adjust functions calls to pass down
11539         info.
11540         (svr4_current_sos_1): Add info parameter.
11541         (svr4_current_sos): Call get_svr4_info, pass info down to
11542         svr4_current_sos_1.
11543         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11544         get_svr4_info.
11545         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11546         get_svr4_info.
11547         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11548         to get_svr4_info.
11549         (probes_table_remove_objfile_probes): Likewise.
11550         (register_solib_event_probe): Add info parameter.
11551         (solist_update_incremental): Pass info parameter down to
11552         svr4_read_so_list.
11553         (disable_probes_interface): Add info parameter.
11554         (svr4_handle_solib_event): Pass current_program_space to
11555         get_svr4_info.  Adjust disable_probes_interface cleanup.
11556         (svr4_create_probe_breakpoints): Add info parameter, pass it
11557         down to register_solib_event_probe.
11558         (svr4_create_solib_event_breakpoints): Add info parameter,
11559         pass it down to svr4_create_probe_breakpoints.
11560         (enable_break): Pass info down to
11561         svr4_create_solib_event_breakpoints.
11562         (svr4_solib_create_inferior_hook): Pass current_program_space to
11563         get_svr4_info.
11564         (svr4_clear_solib): Likewise.
11565
11566 2019-04-22  Pedro Alves  <palves@redhat.com>
11567
11568         * solib-svr4.c (svr4_free_objfile_observer): New.
11569         (probe_and_action::objfile): New field.
11570         (probes_table_htab_remove_objfile_probes)
11571         (probes_table_remove_objfile_probes): New functions.
11572         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11573         in the new probe_and_action.  Don't store the probe in 'lookup'.
11574         (svr4_create_probe_breakpoints): Pass objfile to
11575         register_solib_event_probe.
11576         (_initialize_svr4_solib): Register a free_objfile observer.
11577
11578 2019-04-19  Tom Tromey  <tom@tromey.com>
11579
11580         * common/queue.h: Remove.
11581
11582 2019-04-19  Tom Tromey  <tom@tromey.com>
11583
11584         * event-loop.c: Don't include "common/queue.h".
11585
11586 2019-04-19  Tom Tromey  <tom@tromey.com>
11587
11588         * remote.c (remote_target): Use delete.
11589         * remote-notif.h: Include <list>, not "common/queue.h".
11590         (notif_client_p): Remove typedef.
11591         (remote_notif_state): Add constructor, destructor, initializer.
11592         <notif_queue>: Now a std::list.
11593         (remote_notif_state_xfree): Don't declare.
11594         * remote-notif.c (remote_notif_process, handle_notification)
11595         (remote_notif_state_allocate): Update.
11596         (~remote_notif_state): Rename from remote_notif_state_xfree.
11597
11598 2019-04-19  Tom Tromey  <tom@tromey.com>
11599
11600         * symfile.c (reread_symbols): Update.
11601         * objfiles.c (objfile_register_static_link)
11602         (objfile_lookup_static_link): Update
11603         (~objfile) Don't delete static_links.
11604         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11605
11606 2019-04-19  Tom Tromey  <tom@tromey.com>
11607
11608         * type-stack.h (struct type_stack) <insert>: Constify string.
11609         * type-stack.c (type_stack::insert): Constify string.
11610         * gdbtypes.h (lookup_template_type): Update.
11611         (address_space_name_to_int): Update.
11612         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11613         const.
11614         (lookup_template_type): Make name const.
11615         * c-exp.y: Update rules.
11616         (lex_one_token, classify_name, classify_inner_name)
11617         (c_print_token): Update.
11618         * p-exp.y: Update rules.
11619         (yylex): Update.
11620         * f-exp.y: Update rules.
11621         (yylex): Update.
11622         * d-exp.y: Update rules.
11623         (lex_one_token, classify_name, classify_inner_name): Update.
11624         * parse.c (write_dollar_variable, copy_name): Return std::string.
11625         * parser-defs.h (copy_name): Change return type.
11626         * m2-exp.y: Update rules.
11627         (yylex): Update.
11628         * go-exp.y (lex_one_token): Update.
11629         Update rules.
11630         (classify_unsafe_function, classify_packaged_name)
11631         (classify_name, yylex): Update.
11632
11633 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11634
11635         * configure.ac: add --enable-source-highlight switch.
11636         * configure: Regenerate.
11637         * top.c (print_gdb_version): plumb --enable-source-highlight
11638         status to "show configuration".
11639
11640 2019-04-19  Tom Tromey  <tromey@adacore.com>
11641
11642         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11643         Check ADA_TYPE_P.
11644         (empty_record, ada_template_to_fixed_record_type_1)
11645         (template_to_static_fixed_type)
11646         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11647         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11648         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11649         macros.
11650
11651 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11652
11653         PR symtab/24423:
11654         * source.c (print_source_lines_base): Advance "iter" when a
11655         control character is seen.
11656
11657 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11658
11659         * inferior.h (struct infcall_suspend_state_deleter):
11660         Catch exception in destructor to avoid crash.
11661
11662 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11663
11664         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11665         close to the add_com "shell".
11666
11667 2019-04-18  Tom Tromey  <tromey@adacore.com>
11668
11669         * process-stratum-target.h (class process_stratum_target)
11670         <stratum>: Add "final".
11671
11672 2019-04-17  Tom Tromey  <tromey@adacore.com>
11673
11674         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11675         against nullptr before use.
11676
11677 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11678
11679         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11680
11681 2019-04-17  Jim Wilson  <jimw@sifive.com>
11682             Andrew Burgess  <andrew.burgess@embecosm.com>
11683
11684         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11685         code read might fail, assume 4-byte breakpoint in that case.
11686
11687 2019-04-15  Leszek Swirski  <leszeks@google.com>
11688
11689         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11690         rather than a hand-rolled POD check when checking for forced MEMORY
11691         classification.
11692
11693 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11694
11695         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11696         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11697         function.
11698         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11699         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11700         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11701         declaration.
11702
11703 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11704
11705         * aarch64-linux-nat.c
11706         (aarch64_linux_nat_target::thread_architecture): Add override.
11707         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11708         each VQ.
11709
11710 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11711
11712         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11713
11714 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11715
11716         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11717         target types of size 96-bits, add some additional comments, and
11718         check that the builtin type we found was the correct size.
11719
11720 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11721
11722         * utils.c (prompt_for_continue): Don't restore the styling at the
11723         end, as applied_style has the wrong value.  This fixes styling in
11724         long lists of file names that are interrupted by the "Continue?"
11725         prompt.
11726
11727 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11728
11729         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11730         * c-lang.c (c_language_defn): Likewise.
11731         (cplus_language_defn): Likewise.
11732         (asm_language_defn): Likewise.
11733         (minimal_language_defn): Likewise.
11734         * d-lang.c (d_language_defn): Likewise.
11735         * f-lang.c (f_language_defn): Likewise.
11736         * go-lang.c (go_language_defn): Likewise.
11737         * language.c (unknown_language_defn): Likewise.
11738         (auto_language_defn): Likewise.
11739         * language.h (struct language_defn): Remove la_magic field.
11740         (LANG_MAGIC): Delete.
11741         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11742         * objc-lang.c (objc_language_defn): Likewise.
11743         * opencl-lang.c (opencl_language_defn): Likewise.
11744         * p-lang.c (pascal_language_defn): Likewise.
11745         * rust-lang.c (rust_language_defn): Likewise.
11746
11747 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11748
11749         * riscv-tdep.c (riscv_type_align): New function.
11750         (riscv_type_alignment): Delete.
11751         (riscv_arg_location): Use 'type_align'.
11752         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11753
11754 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11755
11756         * gdbtypes.c (type_align): A struct with no non-static fields also
11757         has alignment of 1.
11758
11759 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11760
11761         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11762         component to 0.
11763         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11764         member.
11765         (riscv_struct_info::analyse): New implementation using new
11766         analyse_inner member function.
11767         (riscv_struct_info::field_offset): New member function.
11768         (riscv_struct_info::m_offsets): New member variable.
11769         (riscv_struct_info::analyse_inner): New private member function,
11770         takes the old implementation of riscv_struct_info::analyse but
11771         extended to track field offsets.
11772         (riscv_call_arg_struct): Update the struct folding special cases
11773         to handle cases where empty C++ structs, which are non-zero
11774         length, are found.
11775         (riscv_arg_location): Initialise the length of each location, a
11776         non-zero length now indicates the location is in use.
11777         (riscv_push_dummy_call): Allow for the first location having a
11778         non-zero offset when setting up arguments.
11779         (riscv_return_value): Likewise, but for return values.
11780
11781 2019-04-11  Tom Tromey  <tromey@adacore.com>
11782
11783         * utils.c (internal_vproblem): Make "msg" const.
11784
11785 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11786
11787         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11788         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11789         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11790         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11791
11792 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11793
11794         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11795         function.
11796         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11797         of amd64_collect_native_gregset.
11798         (amd64_linux_nat_target::store_registers): Likewise.
11799
11800 2019-04-10  Tom Tromey  <tom@tromey.com>
11801
11802         * symtab.c (lookup_global_symbol_from_objfile)
11803         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11804         * objfiles.h (class separate_debug_iterator): New.
11805         (class separate_debug_range): New.
11806         (struct objfile) <separate_debug_objfiles>: New method.
11807         (objfile_separate_debug_iterate): Don't declare.
11808         * objfiles.c (separate_debug_iterator::operator++): Rename from
11809         objfile_separate_debug_iterate.
11810         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11811         iterator.
11812         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11813         iterator.
11814
11815 2019-04-10  Tom Tromey  <tom@tromey.com>
11816
11817         * symfile.c (reread_symbols): Remove old comment.
11818         * objfiles.c (free_all_objfiles): Fix a typo.
11819
11820 2019-04-10  Tom Tromey  <tom@tromey.com>
11821
11822         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11823         * minsyms.c (lookup_minimal_symbol): Use foreach.
11824         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11825         (lookup_minimal_symbol_solib_trampoline): Likewise.
11826         * symfile.c (reread_symbols): Use foreach.
11827
11828 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11829             Tom Tromey  <tromey@adacore.com>
11830
11831         PR rust/24414:
11832         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11833         (rust_lex_int_test): Change "value" to be LONGEST.
11834         (rust_lex_tests): Add test for long integer literal.
11835
11836 2019-04-09  Tom Tromey  <tromey@adacore.com>
11837
11838         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11839         to bool.
11840         (extended_remote_target::attach): Update.
11841         (remote_target::remote_notice_new_inferior): Update.
11842         (remote_target::add_current_inferior_and_thread): Update.
11843         * inferior.c (exit_inferior_1): Use "false".
11844         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11845
11846 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11847
11848         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11849         the "start" command.
11850
11851 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11852
11853         * python/py-inferior.c (infpy_thread_from_thread_handle):
11854         Adjust comments to reflect renaming of thread_from_thread_handle
11855         to thread_from_handle.  Adjust keywords.  Fix type error message.
11856         (inferior_object_methods): Add thread_from_handle.  Retain
11857         thread_from_thread_handle, but mark it as deprecated.
11858
11859 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11860
11861         * gdbthread.h (find_thread_by_handle): Revise declaration.
11862         * thread.c (find_thread_by_handle): Likewise.  Adjust
11863         implementation too.
11864         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11865         support for buffer objects as handles.
11866
11867 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11868
11869         * python/py-infthread.c (thpy_thread_handle): New function.
11870         (thread_object_methods): Register thpy_thread_handle.
11871
11872 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11873
11874         * gdbthread.h (thread_to_thread_handle): Declare.
11875         * thread.c (gdbtypes.h): Include.
11876         (thread_to_thread_handle): New function.
11877
11878         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11879         (target_thread_info_to_thread_handle): Declare.
11880         * target.c (target_thread_info_to_thread_handle): New function.
11881         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11882         * target-delegates.c: Regenerate.
11883
11884         * linux-thread-db.c (class thread_db_target): Add method
11885         thread_info_to_thread_handle.
11886         (thread_db_target::thread_info_to_thread_handle): Define.
11887         * remote.c (class remote_target): Add new method
11888         thread_info_to_thread_handle.
11889         (remote_target::thread_info_to_thread_handle): Define.
11890
11891 2019-04-08  Pedro Alves  <palves@redhat.com>
11892
11893         * common/common-exceptions.c (throw_exception): Don't create
11894         named object to throw; throw directly.
11895         (throw_it): Likewise.  Don't initialize gdb_exception::message
11896         here, with new; pass FMT and AP to the ctor instead.
11897         * common/common-exceptions.h: Include <string>.
11898         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11899         const char *, va_list)): New ctor.  Use std::make_shared.
11900         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11901         errors)): Delete.
11902         (gdb_exception_error::gdb_exception_error(enum errors, const char
11903         *, va_list)): New.
11904         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11905         Add assertion.
11906         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11907         errors)): Delete.
11908         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11909         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11910         Add assertion.
11911
11912 2019-04-08  Tom Tromey  <tom@tromey.com>
11913
11914         * valops.c (value_rtti_indirect_type): Replace throw_exception
11915         with throw.
11916         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11917         with throw.
11918         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11919         throw.
11920         * target.c (target_translate_tls_address): Replace throw_exception
11921         with throw.
11922         * stack.c (frame_apply_command_count): Replace throw_exception
11923         with throw.
11924         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11925         throw.
11926         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11927         with throw.
11928         * rs6000-tdep.c (rs6000_frame_cache)
11929         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11930         * remote.c: Replace throw_exception with throw.
11931         * record-full.c (record_full_message, record_full_wait_1)
11932         (record_full_restore): Replace throw_exception with throw.
11933         * record-btrace.c:
11934         (get_thread_current_frame_id, record_btrace_start_replaying)
11935         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
11936         (cmd_record_btrace_start): Replace throw_exception with throw.
11937         * parse.c (parse_exp_in_context_1): Replace throw_exception with
11938         throw.
11939         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
11940         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
11941         * linespec.c:
11942         (find_linespec_symbols): Replace throw_exception with throw.
11943         * infrun.c (displaced_step_prepare, resume): Replace
11944         throw_exception with throw.
11945         * infcmd.c (post_create_inferior): Replace throw_exception with
11946         throw.
11947         * inf-loop.c (inferior_event_handler): Replace throw_exception
11948         with throw.
11949         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
11950         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
11951         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
11952         (get_prev_frame_always, get_frame_pc_if_available)
11953         (get_frame_address_in_block_if_available, get_frame_language):
11954         Replace throw_exception with throw.
11955         * frame-unwind.c (frame_unwind_try_unwinder): Replace
11956         throw_exception with throw.
11957         * eval.c (fetch_subexp_value, evaluate_var_value)
11958         (evaluate_funcall, evaluate_subexp_standard): Replace
11959         throw_exception with throw.
11960         * dwarf2loc.c (call_site_find_chain)
11961         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
11962         Replace throw_exception with throw.
11963         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
11964         with throw.
11965         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
11966         throw.
11967         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
11968         * completer.c (complete_line_internal): Replace throw_exception
11969         with throw.
11970         * compile/compile-object-run.c (compile_object_run): Replace
11971         throw_exception with throw.
11972         * cli/cli-script.c (process_next_line): Replace throw_exception
11973         with throw.
11974         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
11975         (btrace_enable, btrace_maint_update_pt_packets): Replace
11976         throw_exception with throw.
11977         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
11978         throw_exception with throw.
11979         * break-catch-throw.c (re_set_exception_catchpoint): Replace
11980         throw_exception with throw.
11981         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
11982         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
11983         * aarch64-tdep.c (aarch64_make_prologue_cache)
11984         (aarch64_make_stub_cache): Replace throw_exception with throw.
11985
11986 2019-04-08  Tom Tromey  <tom@tromey.com>
11987
11988         * common/common-exceptions.c (throw_exception): Rename from
11989         throw_exception_cxx.  Remove old copy.  Make argument const.
11990         (throw_it): Create and throw exception objects directly.
11991         * common/common-exceptions.h (throw_exception): Make argument
11992         const.
11993         (struct gdb_exception_error): Add constructor.
11994         (struct gdb_exception_quit): Add constructor.
11995
11996 2019-04-08  Tom Tromey  <tom@tromey.com>
11997
11998         * common/common-exceptions.h (exception_rethrow): Don't declare.
11999         (TRY_SJLJ): Update comment.
12000         (TRY, CATCH, END_CATCH): Remove.
12001         * common/common-exceptions.c (exception_rethrow): Remove.
12002
12003 2019-04-08  Tom Tromey  <tom@tromey.com>
12004
12005         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12006         Remove.
12007         (gdb_exception_error): Rename from
12008         gdb_exception_RETURN_MASK_ERROR.
12009         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12010         (gdb_quit_bad_alloc): Update.
12011         * aarch64-tdep.c: Update.
12012         * ada-lang.c: Update.
12013         * ada-typeprint.c: Update.
12014         * ada-valprint.c: Update.
12015         * amd64-tdep.c: Update.
12016         * arch-utils.c: Update.
12017         * break-catch-throw.c: Update.
12018         * breakpoint.c: Update.
12019         * btrace.c: Update.
12020         * c-varobj.c: Update.
12021         * cli/cli-cmds.c: Update.
12022         * cli/cli-interp.c: Update.
12023         * cli/cli-script.c: Update.
12024         * common/common-exceptions.c: Update.
12025         * common/new-op.c: Update.
12026         * common/selftest.c: Update.
12027         * compile/compile-c-symbols.c: Update.
12028         * compile/compile-cplus-symbols.c: Update.
12029         * compile/compile-object-load.c: Update.
12030         * compile/compile-object-run.c: Update.
12031         * completer.c: Update.
12032         * corelow.c: Update.
12033         * cp-abi.c: Update.
12034         * cp-support.c: Update.
12035         * cp-valprint.c: Update.
12036         * darwin-nat.c: Update.
12037         * disasm-selftests.c: Update.
12038         * dtrace-probe.c: Update.
12039         * dwarf-index-cache.c: Update.
12040         * dwarf-index-write.c: Update.
12041         * dwarf2-frame-tailcall.c: Update.
12042         * dwarf2-frame.c: Update.
12043         * dwarf2loc.c: Update.
12044         * dwarf2read.c: Update.
12045         * eval.c: Update.
12046         * event-loop.c: Update.
12047         * event-top.c: Update.
12048         * exec.c: Update.
12049         * f-valprint.c: Update.
12050         * fbsd-tdep.c: Update.
12051         * frame-unwind.c: Update.
12052         * frame.c: Update.
12053         * gdbtypes.c: Update.
12054         * gnu-v3-abi.c: Update.
12055         * guile/guile-internal.h: Update.
12056         * guile/scm-block.c: Update.
12057         * guile/scm-breakpoint.c: Update.
12058         * guile/scm-cmd.c: Update.
12059         * guile/scm-disasm.c: Update.
12060         * guile/scm-frame.c: Update.
12061         * guile/scm-lazy-string.c: Update.
12062         * guile/scm-math.c: Update.
12063         * guile/scm-param.c: Update.
12064         * guile/scm-ports.c: Update.
12065         * guile/scm-pretty-print.c: Update.
12066         * guile/scm-symbol.c: Update.
12067         * guile/scm-symtab.c: Update.
12068         * guile/scm-type.c: Update.
12069         * guile/scm-value.c: Update.
12070         * i386-linux-tdep.c: Update.
12071         * i386-tdep.c: Update.
12072         * inf-loop.c: Update.
12073         * infcall.c: Update.
12074         * infcmd.c: Update.
12075         * infrun.c: Update.
12076         * jit.c: Update.
12077         * language.c: Update.
12078         * linespec.c: Update.
12079         * linux-fork.c: Update.
12080         * linux-nat.c: Update.
12081         * linux-tdep.c: Update.
12082         * linux-thread-db.c: Update.
12083         * main.c: Update.
12084         * mi/mi-cmd-break.c: Update.
12085         * mi/mi-cmd-stack.c: Update.
12086         * mi/mi-interp.c: Update.
12087         * mi/mi-main.c: Update.
12088         * objc-lang.c: Update.
12089         * p-valprint.c: Update.
12090         * parse.c: Update.
12091         * ppc-linux-tdep.c: Update.
12092         * printcmd.c: Update.
12093         * python/py-arch.c: Update.
12094         * python/py-breakpoint.c: Update.
12095         * python/py-cmd.c: Update.
12096         * python/py-finishbreakpoint.c: Update.
12097         * python/py-frame.c: Update.
12098         * python/py-framefilter.c: Update.
12099         * python/py-gdb-readline.c: Update.
12100         * python/py-inferior.c: Update.
12101         * python/py-infthread.c: Update.
12102         * python/py-lazy-string.c: Update.
12103         * python/py-linetable.c: Update.
12104         * python/py-objfile.c: Update.
12105         * python/py-param.c: Update.
12106         * python/py-prettyprint.c: Update.
12107         * python/py-progspace.c: Update.
12108         * python/py-record-btrace.c: Update.
12109         * python/py-record.c: Update.
12110         * python/py-symbol.c: Update.
12111         * python/py-type.c: Update.
12112         * python/py-unwind.c: Update.
12113         * python/py-utils.c: Update.
12114         * python/py-value.c: Update.
12115         * python/python.c: Update.
12116         * record-btrace.c: Update.
12117         * record-full.c: Update.
12118         * remote-fileio.c: Update.
12119         * remote.c: Update.
12120         * riscv-tdep.c: Update.
12121         * rs6000-aix-tdep.c: Update.
12122         * rs6000-tdep.c: Update.
12123         * rust-exp.y: Update.
12124         * rust-lang.c: Update.
12125         * s390-tdep.c: Update.
12126         * selftest-arch.c: Update.
12127         * solib-dsbt.c: Update.
12128         * solib-frv.c: Update.
12129         * solib-spu.c: Update.
12130         * solib-svr4.c: Update.
12131         * solib.c: Update.
12132         * sparc64-linux-tdep.c: Update.
12133         * stack.c: Update.
12134         * symfile-mem.c: Update.
12135         * symmisc.c: Update.
12136         * target.c: Update.
12137         * thread.c: Update.
12138         * top.c: Update.
12139         * tracefile-tfile.c: Update.
12140         * tui/tui.c: Update.
12141         * typeprint.c: Update.
12142         * unittests/cli-utils-selftests.c: Update.
12143         * unittests/parse-connection-spec-selftests.c: Update.
12144         * valops.c: Update.
12145         * valprint.c: Update.
12146         * value.c: Update.
12147         * varobj.c: Update.
12148         * windows-nat.c: Update.
12149         * x86-linux-nat.c: Update.
12150         * xml-support.c: Update.
12151
12152 2019-04-08  Tom Tromey  <tom@tromey.com>
12153
12154         * xml-support.c: Use C++ exception handling.
12155         * x86-linux-nat.c: Use C++ exception handling.
12156         * windows-nat.c: Use C++ exception handling.
12157         * varobj.c: Use C++ exception handling.
12158         * value.c: Use C++ exception handling.
12159         * valprint.c: Use C++ exception handling.
12160         * valops.c: Use C++ exception handling.
12161         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12162         handling.
12163         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12164         * typeprint.c: Use C++ exception handling.
12165         * tui/tui.c: Use C++ exception handling.
12166         * tracefile-tfile.c: Use C++ exception handling.
12167         * top.c: Use C++ exception handling.
12168         * thread.c: Use C++ exception handling.
12169         * target.c: Use C++ exception handling.
12170         * symmisc.c: Use C++ exception handling.
12171         * symfile-mem.c: Use C++ exception handling.
12172         * stack.c: Use C++ exception handling.
12173         * sparc64-linux-tdep.c: Use C++ exception handling.
12174         * solib.c: Use C++ exception handling.
12175         * solib-svr4.c: Use C++ exception handling.
12176         * solib-spu.c: Use C++ exception handling.
12177         * solib-frv.c: Use C++ exception handling.
12178         * solib-dsbt.c: Use C++ exception handling.
12179         * selftest-arch.c: Use C++ exception handling.
12180         * s390-tdep.c: Use C++ exception handling.
12181         * rust-lang.c: Use C++ exception handling.
12182         * rust-exp.y: Use C++ exception handling.
12183         * rs6000-tdep.c: Use C++ exception handling.
12184         * rs6000-aix-tdep.c: Use C++ exception handling.
12185         * riscv-tdep.c: Use C++ exception handling.
12186         * remote.c: Use C++ exception handling.
12187         * remote-fileio.c: Use C++ exception handling.
12188         * record-full.c: Use C++ exception handling.
12189         * record-btrace.c: Use C++ exception handling.
12190         * python/python.c: Use C++ exception handling.
12191         * python/py-value.c: Use C++ exception handling.
12192         * python/py-utils.c: Use C++ exception handling.
12193         * python/py-unwind.c: Use C++ exception handling.
12194         * python/py-type.c: Use C++ exception handling.
12195         * python/py-symbol.c: Use C++ exception handling.
12196         * python/py-record.c: Use C++ exception handling.
12197         * python/py-record-btrace.c: Use C++ exception handling.
12198         * python/py-progspace.c: Use C++ exception handling.
12199         * python/py-prettyprint.c: Use C++ exception handling.
12200         * python/py-param.c: Use C++ exception handling.
12201         * python/py-objfile.c: Use C++ exception handling.
12202         * python/py-linetable.c: Use C++ exception handling.
12203         * python/py-lazy-string.c: Use C++ exception handling.
12204         * python/py-infthread.c: Use C++ exception handling.
12205         * python/py-inferior.c: Use C++ exception handling.
12206         * python/py-gdb-readline.c: Use C++ exception handling.
12207         * python/py-framefilter.c: Use C++ exception handling.
12208         * python/py-frame.c: Use C++ exception handling.
12209         * python/py-finishbreakpoint.c: Use C++ exception handling.
12210         * python/py-cmd.c: Use C++ exception handling.
12211         * python/py-breakpoint.c: Use C++ exception handling.
12212         * python/py-arch.c: Use C++ exception handling.
12213         * printcmd.c: Use C++ exception handling.
12214         * ppc-linux-tdep.c: Use C++ exception handling.
12215         * parse.c: Use C++ exception handling.
12216         * p-valprint.c: Use C++ exception handling.
12217         * objc-lang.c: Use C++ exception handling.
12218         * mi/mi-main.c: Use C++ exception handling.
12219         * mi/mi-interp.c: Use C++ exception handling.
12220         * mi/mi-cmd-stack.c: Use C++ exception handling.
12221         * mi/mi-cmd-break.c: Use C++ exception handling.
12222         * main.c: Use C++ exception handling.
12223         * linux-thread-db.c: Use C++ exception handling.
12224         * linux-tdep.c: Use C++ exception handling.
12225         * linux-nat.c: Use C++ exception handling.
12226         * linux-fork.c: Use C++ exception handling.
12227         * linespec.c: Use C++ exception handling.
12228         * language.c: Use C++ exception handling.
12229         * jit.c: Use C++ exception handling.
12230         * infrun.c: Use C++ exception handling.
12231         * infcmd.c: Use C++ exception handling.
12232         * infcall.c: Use C++ exception handling.
12233         * inf-loop.c: Use C++ exception handling.
12234         * i386-tdep.c: Use C++ exception handling.
12235         * i386-linux-tdep.c: Use C++ exception handling.
12236         * guile/scm-value.c: Use C++ exception handling.
12237         * guile/scm-type.c: Use C++ exception handling.
12238         * guile/scm-symtab.c: Use C++ exception handling.
12239         * guile/scm-symbol.c: Use C++ exception handling.
12240         * guile/scm-pretty-print.c: Use C++ exception handling.
12241         * guile/scm-ports.c: Use C++ exception handling.
12242         * guile/scm-param.c: Use C++ exception handling.
12243         * guile/scm-math.c: Use C++ exception handling.
12244         * guile/scm-lazy-string.c: Use C++ exception handling.
12245         * guile/scm-frame.c: Use C++ exception handling.
12246         * guile/scm-disasm.c: Use C++ exception handling.
12247         * guile/scm-cmd.c: Use C++ exception handling.
12248         * guile/scm-breakpoint.c: Use C++ exception handling.
12249         * guile/scm-block.c: Use C++ exception handling.
12250         * guile/guile-internal.h: Use C++ exception handling.
12251         * gnu-v3-abi.c: Use C++ exception handling.
12252         * gdbtypes.c: Use C++ exception handling.
12253         * frame.c: Use C++ exception handling.
12254         * frame-unwind.c: Use C++ exception handling.
12255         * fbsd-tdep.c: Use C++ exception handling.
12256         * f-valprint.c: Use C++ exception handling.
12257         * exec.c: Use C++ exception handling.
12258         * event-top.c: Use C++ exception handling.
12259         * event-loop.c: Use C++ exception handling.
12260         * eval.c: Use C++ exception handling.
12261         * dwarf2read.c: Use C++ exception handling.
12262         * dwarf2loc.c: Use C++ exception handling.
12263         * dwarf2-frame.c: Use C++ exception handling.
12264         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12265         * dwarf-index-write.c: Use C++ exception handling.
12266         * dwarf-index-cache.c: Use C++ exception handling.
12267         * dtrace-probe.c: Use C++ exception handling.
12268         * disasm-selftests.c: Use C++ exception handling.
12269         * darwin-nat.c: Use C++ exception handling.
12270         * cp-valprint.c: Use C++ exception handling.
12271         * cp-support.c: Use C++ exception handling.
12272         * cp-abi.c: Use C++ exception handling.
12273         * corelow.c: Use C++ exception handling.
12274         * completer.c: Use C++ exception handling.
12275         * compile/compile-object-run.c: Use C++ exception handling.
12276         * compile/compile-object-load.c: Use C++ exception handling.
12277         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12278         * compile/compile-c-symbols.c: Use C++ exception handling.
12279         * common/selftest.c: Use C++ exception handling.
12280         * common/new-op.c: Use C++ exception handling.
12281         * cli/cli-script.c: Use C++ exception handling.
12282         * cli/cli-interp.c: Use C++ exception handling.
12283         * cli/cli-cmds.c: Use C++ exception handling.
12284         * c-varobj.c: Use C++ exception handling.
12285         * btrace.c: Use C++ exception handling.
12286         * breakpoint.c: Use C++ exception handling.
12287         * break-catch-throw.c: Use C++ exception handling.
12288         * arch-utils.c: Use C++ exception handling.
12289         * amd64-tdep.c: Use C++ exception handling.
12290         * ada-valprint.c: Use C++ exception handling.
12291         * ada-typeprint.c: Use C++ exception handling.
12292         * ada-lang.c: Use C++ exception handling.
12293         * aarch64-tdep.c: Use C++ exception handling.
12294
12295 2019-04-08  Tom Tromey  <tom@tromey.com>
12296
12297         * xml-support.c (gdb_xml_parser::parse): Update.
12298         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12299         * value.c (show_convenience): Update.
12300         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12301         (test_parse_flags_qcs): Update.
12302         * thread.c (thr_try_catch_cmd): Update.
12303         * target.c (target_translate_tls_address): Update.
12304         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12305         (info_frame_command_core, frame_apply_command_count): Update.
12306         * rust-exp.y (rust_lex_exception_test): Update.
12307         * riscv-tdep.c (riscv_print_one_register_info): Update.
12308         * remote.c (remote_target::enable_btrace): Update.
12309         * record-btrace.c (record_btrace_enable_warn): Update.
12310         * python/py-utils.c (gdbpy_convert_exception): Update.
12311         * printcmd.c (do_one_display, print_variable_and_value): Update.
12312         * mi/mi-main.c (mi_print_exception): Update.
12313         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12314         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12315         * linux-nat.c (linux_nat_target::attach): Update.
12316         * linux-fork.c (class scoped_switch_fork_info): Update.
12317         * infrun.c (displaced_step_prepare): Update.
12318         * infcall.c (call_function_by_hand_dummy): Update.
12319         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12320         * gnu-v3-abi.c (print_one_vtable): Update.
12321         * frame.c (get_prev_frame_always): Update.
12322         * f-valprint.c (info_common_command_for_block): Update.
12323         * exec.c (try_open_exec_file): Update.
12324         * exceptions.c (print_exception, exception_print)
12325         (exception_fprintf, exception_print_same): Update.
12326         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12327         * dwarf-index-cache.c (index_cache::store)
12328         (index_cache::lookup_gdb_index): Update.
12329         * darwin-nat.c (maybe_cache_shell): Update.
12330         * cp-valprint.c (cp_print_value_fields): Update.
12331         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12332         (gcc_cplus_symbol_address): Update.
12333         * compile/compile-c-symbols.c (gcc_convert_symbol)
12334         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12335         * common/selftest.c: Update.
12336         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12337         a std::string.
12338         (exception_try_scope_entry, exception_try_scope_exit): Don't
12339         declare.
12340         (struct exception_try_scope): Remove.
12341         (TRY): Don't use exception_try_scope.
12342         (struct gdb_exception): Add constructor, operator=.
12343         <what>: New method.
12344         (struct gdb_exception_RETURN_MASK_ALL)
12345         (struct gdb_exception_RETURN_MASK_ERROR)
12346         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12347         (struct gdb_quit_bad_alloc): Update.
12348         * common/common-exceptions.c (exception_none): Change
12349         initializer.
12350         (struct catcher) <state, exception>: Initialize inline.
12351         <prev>: Remove member.
12352         (current_catcher): Remove.
12353         (catchers): New global.
12354         (exceptions_state_mc_init): Simplify.
12355         (catcher_pop): Remove.
12356         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12357         (try_scope_depth, exception_try_scope_entry)
12358         (exception_try_scope_exit): Remove.
12359         (throw_exception_sjlj): Update.
12360         (exception_messages, exception_messages_size): Remove.
12361         (throw_it): Simplify.
12362         (gdb_exception_sliced_copy): Remove.
12363         (throw_exception_cxx): Update.
12364         * cli/cli-script.c (script_from_file): Update.
12365         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12366         Update.
12367         * ada-valprint.c (ada_val_print): Update.
12368         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12369         (create_excep_cond_exprs): Update.
12370
12371 2019-04-08  Tom Tromey  <tom@tromey.com>
12372
12373         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12374         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12375         (TRY, CATCH, END_CATCH): Remove some definitions.
12376         * common/common-exceptions.c: Don't use GDB_XCPT.
12377         (catcher_list_size): Remove.
12378         (throw_exception, throw_it): Simplify.
12379
12380 2019-04-05  Tom Tromey  <tom@tromey.com>
12381
12382         Revert the header-sorting patch.
12383         * ft32-tdep.c: Revert.
12384         * frv-tdep.c: Revert.
12385         * frv-linux-tdep.c: Revert.
12386         * frame.c: Revert.
12387         * frame-unwind.c: Revert.
12388         * frame-base.c: Revert.
12389         * fork-child.c: Revert.
12390         * findvar.c: Revert.
12391         * findcmd.c: Revert.
12392         * filesystem.c: Revert.
12393         * filename-seen-cache.h: Revert.
12394         * filename-seen-cache.c: Revert.
12395         * fbsd-tdep.c: Revert.
12396         * fbsd-nat.h: Revert.
12397         * fbsd-nat.c: Revert.
12398         * f-valprint.c: Revert.
12399         * f-typeprint.c: Revert.
12400         * f-lang.c: Revert.
12401         * extension.h: Revert.
12402         * extension.c: Revert.
12403         * extension-priv.h: Revert.
12404         * expprint.c: Revert.
12405         * exec.h: Revert.
12406         * exec.c: Revert.
12407         * exceptions.c: Revert.
12408         * event-top.c: Revert.
12409         * event-loop.c: Revert.
12410         * eval.c: Revert.
12411         * elfread.c: Revert.
12412         * dwarf2read.h: Revert.
12413         * dwarf2read.c: Revert.
12414         * dwarf2loc.c: Revert.
12415         * dwarf2expr.h: Revert.
12416         * dwarf2expr.c: Revert.
12417         * dwarf2-frame.c: Revert.
12418         * dwarf2-frame-tailcall.c: Revert.
12419         * dwarf-index-write.h: Revert.
12420         * dwarf-index-write.c: Revert.
12421         * dwarf-index-common.c: Revert.
12422         * dwarf-index-cache.h: Revert.
12423         * dwarf-index-cache.c: Revert.
12424         * dummy-frame.c: Revert.
12425         * dtrace-probe.c: Revert.
12426         * disasm.h: Revert.
12427         * disasm.c: Revert.
12428         * disasm-selftests.c: Revert.
12429         * dictionary.c: Revert.
12430         * dicos-tdep.c: Revert.
12431         * demangle.c: Revert.
12432         * dcache.h: Revert.
12433         * dcache.c: Revert.
12434         * darwin-nat.h: Revert.
12435         * darwin-nat.c: Revert.
12436         * darwin-nat-info.c: Revert.
12437         * d-valprint.c: Revert.
12438         * d-namespace.c: Revert.
12439         * d-lang.c: Revert.
12440         * ctf.c: Revert.
12441         * csky-tdep.c: Revert.
12442         * csky-linux-tdep.c: Revert.
12443         * cris-tdep.c: Revert.
12444         * cris-linux-tdep.c: Revert.
12445         * cp-valprint.c: Revert.
12446         * cp-support.c: Revert.
12447         * cp-namespace.c: Revert.
12448         * cp-abi.c: Revert.
12449         * corelow.c: Revert.
12450         * corefile.c: Revert.
12451         * continuations.c: Revert.
12452         * completer.h: Revert.
12453         * completer.c: Revert.
12454         * complaints.c: Revert.
12455         * coffread.c: Revert.
12456         * coff-pe-read.c: Revert.
12457         * cli-out.h: Revert.
12458         * cli-out.c: Revert.
12459         * charset.c: Revert.
12460         * c-varobj.c: Revert.
12461         * c-valprint.c: Revert.
12462         * c-typeprint.c: Revert.
12463         * c-lang.c: Revert.
12464         * buildsym.c: Revert.
12465         * buildsym-legacy.c: Revert.
12466         * build-id.h: Revert.
12467         * build-id.c: Revert.
12468         * btrace.c: Revert.
12469         * bsd-uthread.c: Revert.
12470         * breakpoint.h: Revert.
12471         * breakpoint.c: Revert.
12472         * break-catch-throw.c: Revert.
12473         * break-catch-syscall.c: Revert.
12474         * break-catch-sig.c: Revert.
12475         * blockframe.c: Revert.
12476         * block.c: Revert.
12477         * bfin-tdep.c: Revert.
12478         * bfin-linux-tdep.c: Revert.
12479         * bfd-target.c: Revert.
12480         * bcache.c: Revert.
12481         * ax-general.c: Revert.
12482         * ax-gdb.h: Revert.
12483         * ax-gdb.c: Revert.
12484         * avr-tdep.c: Revert.
12485         * auxv.c: Revert.
12486         * auto-load.c: Revert.
12487         * arm-wince-tdep.c: Revert.
12488         * arm-tdep.c: Revert.
12489         * arm-symbian-tdep.c: Revert.
12490         * arm-pikeos-tdep.c: Revert.
12491         * arm-obsd-tdep.c: Revert.
12492         * arm-nbsd-tdep.c: Revert.
12493         * arm-nbsd-nat.c: Revert.
12494         * arm-linux-tdep.c: Revert.
12495         * arm-linux-nat.c: Revert.
12496         * arm-fbsd-tdep.c: Revert.
12497         * arm-fbsd-nat.c: Revert.
12498         * arm-bsd-tdep.c: Revert.
12499         * arch-utils.c: Revert.
12500         * arc-tdep.c: Revert.
12501         * arc-newlib-tdep.c: Revert.
12502         * annotate.h: Revert.
12503         * annotate.c: Revert.
12504         * amd64-windows-tdep.c: Revert.
12505         * amd64-windows-nat.c: Revert.
12506         * amd64-tdep.c: Revert.
12507         * amd64-sol2-tdep.c: Revert.
12508         * amd64-obsd-tdep.c: Revert.
12509         * amd64-obsd-nat.c: Revert.
12510         * amd64-nbsd-tdep.c: Revert.
12511         * amd64-nbsd-nat.c: Revert.
12512         * amd64-nat.c: Revert.
12513         * amd64-linux-tdep.c: Revert.
12514         * amd64-linux-nat.c: Revert.
12515         * amd64-fbsd-tdep.c: Revert.
12516         * amd64-fbsd-nat.c: Revert.
12517         * amd64-dicos-tdep.c: Revert.
12518         * amd64-darwin-tdep.c: Revert.
12519         * amd64-bsd-nat.c: Revert.
12520         * alpha-tdep.c: Revert.
12521         * alpha-obsd-tdep.c: Revert.
12522         * alpha-nbsd-tdep.c: Revert.
12523         * alpha-mdebug-tdep.c: Revert.
12524         * alpha-linux-tdep.c: Revert.
12525         * alpha-linux-nat.c: Revert.
12526         * alpha-bsd-tdep.c: Revert.
12527         * alpha-bsd-nat.c: Revert.
12528         * aix-thread.c: Revert.
12529         * agent.c: Revert.
12530         * addrmap.c: Revert.
12531         * ada-varobj.c: Revert.
12532         * ada-valprint.c: Revert.
12533         * ada-typeprint.c: Revert.
12534         * ada-tasks.c: Revert.
12535         * ada-lang.c: Revert.
12536         * aarch64-tdep.c: Revert.
12537         * aarch64-ravenscar-thread.c: Revert.
12538         * aarch64-newlib-tdep.c: Revert.
12539         * aarch64-linux-tdep.c: Revert.
12540         * aarch64-linux-nat.c: Revert.
12541         * aarch64-fbsd-tdep.c: Revert.
12542         * aarch64-fbsd-nat.c: Revert.
12543         * aarch32-linux-nat.c: Revert.
12544
12545 2019-04-05  Tom Tromey  <tom@tromey.com>
12546
12547         * ft32-tdep.c: Sort headers.
12548         * frv-tdep.c: Sort headers.
12549         * frv-linux-tdep.c: Sort headers.
12550         * frame.c: Sort headers.
12551         * frame-unwind.c: Sort headers.
12552         * frame-base.c: Sort headers.
12553         * fork-child.c: Sort headers.
12554         * findvar.c: Sort headers.
12555         * findcmd.c: Sort headers.
12556         * filesystem.c: Sort headers.
12557         * filename-seen-cache.h: Sort headers.
12558         * filename-seen-cache.c: Sort headers.
12559         * fbsd-tdep.c: Sort headers.
12560         * fbsd-nat.h: Sort headers.
12561         * fbsd-nat.c: Sort headers.
12562         * f-valprint.c: Sort headers.
12563         * f-typeprint.c: Sort headers.
12564         * f-lang.c: Sort headers.
12565         * extension.h: Sort headers.
12566         * extension.c: Sort headers.
12567         * extension-priv.h: Sort headers.
12568         * expprint.c: Sort headers.
12569         * exec.h: Sort headers.
12570         * exec.c: Sort headers.
12571         * exceptions.c: Sort headers.
12572         * event-top.c: Sort headers.
12573         * event-loop.c: Sort headers.
12574         * eval.c: Sort headers.
12575         * elfread.c: Sort headers.
12576         * dwarf2read.h: Sort headers.
12577         * dwarf2read.c: Sort headers.
12578         * dwarf2loc.c: Sort headers.
12579         * dwarf2expr.h: Sort headers.
12580         * dwarf2expr.c: Sort headers.
12581         * dwarf2-frame.c: Sort headers.
12582         * dwarf2-frame-tailcall.c: Sort headers.
12583         * dwarf-index-write.h: Sort headers.
12584         * dwarf-index-write.c: Sort headers.
12585         * dwarf-index-common.c: Sort headers.
12586         * dwarf-index-cache.h: Sort headers.
12587         * dwarf-index-cache.c: Sort headers.
12588         * dummy-frame.c: Sort headers.
12589         * dtrace-probe.c: Sort headers.
12590         * disasm.h: Sort headers.
12591         * disasm.c: Sort headers.
12592         * disasm-selftests.c: Sort headers.
12593         * dictionary.c: Sort headers.
12594         * dicos-tdep.c: Sort headers.
12595         * demangle.c: Sort headers.
12596         * dcache.h: Sort headers.
12597         * dcache.c: Sort headers.
12598         * darwin-nat.h: Sort headers.
12599         * darwin-nat.c: Sort headers.
12600         * darwin-nat-info.c: Sort headers.
12601         * d-valprint.c: Sort headers.
12602         * d-namespace.c: Sort headers.
12603         * d-lang.c: Sort headers.
12604         * ctf.c: Sort headers.
12605         * csky-tdep.c: Sort headers.
12606         * csky-linux-tdep.c: Sort headers.
12607         * cris-tdep.c: Sort headers.
12608         * cris-linux-tdep.c: Sort headers.
12609         * cp-valprint.c: Sort headers.
12610         * cp-support.c: Sort headers.
12611         * cp-namespace.c: Sort headers.
12612         * cp-abi.c: Sort headers.
12613         * corelow.c: Sort headers.
12614         * corefile.c: Sort headers.
12615         * continuations.c: Sort headers.
12616         * completer.h: Sort headers.
12617         * completer.c: Sort headers.
12618         * complaints.c: Sort headers.
12619         * coffread.c: Sort headers.
12620         * coff-pe-read.c: Sort headers.
12621         * cli-out.h: Sort headers.
12622         * cli-out.c: Sort headers.
12623         * charset.c: Sort headers.
12624         * c-varobj.c: Sort headers.
12625         * c-valprint.c: Sort headers.
12626         * c-typeprint.c: Sort headers.
12627         * c-lang.c: Sort headers.
12628         * buildsym.c: Sort headers.
12629         * buildsym-legacy.c: Sort headers.
12630         * build-id.h: Sort headers.
12631         * build-id.c: Sort headers.
12632         * btrace.c: Sort headers.
12633         * bsd-uthread.c: Sort headers.
12634         * breakpoint.h: Sort headers.
12635         * breakpoint.c: Sort headers.
12636         * break-catch-throw.c: Sort headers.
12637         * break-catch-syscall.c: Sort headers.
12638         * break-catch-sig.c: Sort headers.
12639         * blockframe.c: Sort headers.
12640         * block.c: Sort headers.
12641         * bfin-tdep.c: Sort headers.
12642         * bfin-linux-tdep.c: Sort headers.
12643         * bfd-target.c: Sort headers.
12644         * bcache.c: Sort headers.
12645         * ax-general.c: Sort headers.
12646         * ax-gdb.h: Sort headers.
12647         * ax-gdb.c: Sort headers.
12648         * avr-tdep.c: Sort headers.
12649         * auxv.c: Sort headers.
12650         * auto-load.c: Sort headers.
12651         * arm-wince-tdep.c: Sort headers.
12652         * arm-tdep.c: Sort headers.
12653         * arm-symbian-tdep.c: Sort headers.
12654         * arm-pikeos-tdep.c: Sort headers.
12655         * arm-obsd-tdep.c: Sort headers.
12656         * arm-nbsd-tdep.c: Sort headers.
12657         * arm-nbsd-nat.c: Sort headers.
12658         * arm-linux-tdep.c: Sort headers.
12659         * arm-linux-nat.c: Sort headers.
12660         * arm-fbsd-tdep.c: Sort headers.
12661         * arm-fbsd-nat.c: Sort headers.
12662         * arm-bsd-tdep.c: Sort headers.
12663         * arch-utils.c: Sort headers.
12664         * arc-tdep.c: Sort headers.
12665         * arc-newlib-tdep.c: Sort headers.
12666         * annotate.h: Sort headers.
12667         * annotate.c: Sort headers.
12668         * amd64-windows-tdep.c: Sort headers.
12669         * amd64-windows-nat.c: Sort headers.
12670         * amd64-tdep.c: Sort headers.
12671         * amd64-sol2-tdep.c: Sort headers.
12672         * amd64-obsd-tdep.c: Sort headers.
12673         * amd64-obsd-nat.c: Sort headers.
12674         * amd64-nbsd-tdep.c: Sort headers.
12675         * amd64-nbsd-nat.c: Sort headers.
12676         * amd64-nat.c: Sort headers.
12677         * amd64-linux-tdep.c: Sort headers.
12678         * amd64-linux-nat.c: Sort headers.
12679         * amd64-fbsd-tdep.c: Sort headers.
12680         * amd64-fbsd-nat.c: Sort headers.
12681         * amd64-dicos-tdep.c: Sort headers.
12682         * amd64-darwin-tdep.c: Sort headers.
12683         * amd64-bsd-nat.c: Sort headers.
12684         * alpha-tdep.c: Sort headers.
12685         * alpha-obsd-tdep.c: Sort headers.
12686         * alpha-nbsd-tdep.c: Sort headers.
12687         * alpha-mdebug-tdep.c: Sort headers.
12688         * alpha-linux-tdep.c: Sort headers.
12689         * alpha-linux-nat.c: Sort headers.
12690         * alpha-bsd-tdep.c: Sort headers.
12691         * alpha-bsd-nat.c: Sort headers.
12692         * aix-thread.c: Sort headers.
12693         * agent.c: Sort headers.
12694         * addrmap.c: Sort headers.
12695         * ada-varobj.c: Sort headers.
12696         * ada-valprint.c: Sort headers.
12697         * ada-typeprint.c: Sort headers.
12698         * ada-tasks.c: Sort headers.
12699         * ada-lang.c: Sort headers.
12700         * aarch64-tdep.c: Sort headers.
12701         * aarch64-ravenscar-thread.c: Sort headers.
12702         * aarch64-newlib-tdep.c: Sort headers.
12703         * aarch64-linux-tdep.c: Sort headers.
12704         * aarch64-linux-nat.c: Sort headers.
12705         * aarch64-fbsd-tdep.c: Sort headers.
12706         * aarch64-fbsd-nat.c: Sort headers.
12707         * aarch32-linux-nat.c: Sort headers.
12708
12709 2019-04-04  Tom Tromey  <tom@tromey.com>
12710
12711         * varobj.c (varobj_create): Update.
12712         * rust-exp.y (struct rust_parser) <update_innermost_block,
12713         lookup_symbol>: New methods.
12714         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12715         Rename.
12716         (rust_parser::rust_lookup_type)
12717         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12718         * printcmd.c (display_command, do_one_display): Update.
12719         * parser-defs.h (struct parser_state) <parser_state>: Add
12720         "tracker" parameter.
12721         (block_tracker): New member.
12722         (class innermost_block_tracker) <innermost_block_tracker>: Add
12723         "types" parameter.
12724         <reset>: Remove method.
12725         (innermost_block): Don't declare.
12726         (null_post_parser): Update.
12727         * parse.c (innermost_block): Remove global.
12728         (write_dollar_variable): Update.
12729         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12730         Remove "tracker_types" parameter.
12731         (parse_expression): Add "tracker" parameter.
12732         (parse_expression_for_completion): Update.
12733         (null_post_parser): Add "tracker" parameter.
12734         * p-exp.y: Update rules.
12735         * m2-exp.y: Update rules.
12736         * language.h (struct language_defn) <la_post_parser>: Add
12737         "tracker" parameter.
12738         * go-exp.y: Update rules.
12739         * f-exp.y: Update rules.
12740         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12741         parameter.
12742         * d-exp.y: Update rules.
12743         * c-exp.y: Update rules.
12744         * breakpoint.c (set_breakpoint_condition): Create an
12745         innermost_block_tracker.
12746         (watch_command_1): Likewise.
12747         * ada-lang.c (resolve): Add "tracker" parameter.
12748         (resolve_subexp): Likewise.
12749         * ada-exp.y (write_var_from_sym): Update.
12750
12751 2019-04-04  Tom Tromey  <tom@tromey.com>
12752
12753         * type-stack.h: New file.
12754         * type-stack.c: New file.
12755         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12756         type-stack.h.
12757         (insert_into_type_stack, insert_type, push_type, push_type_int)
12758         (insert_type_address_space, pop_type, pop_type_int)
12759         (pop_typelist, pop_type_stack, append_type_stack)
12760         (push_type_stack, get_type_stack, push_typelist)
12761         (follow_type_instance_flags, follow_types): Don't declare.
12762         * parse.c (type_stack): Remove global.
12763         (parse_exp_in_context): Update.
12764         (insert_into_type_stack, insert_type, push_type, push_type_int)
12765         (insert_type_address_space, pop_type, pop_type_int)
12766         (pop_typelist, pop_type_stack, append_type_stack)
12767         (push_type_stack, get_type_stack, push_typelist)
12768         (follow_type_instance_flags, follow_types): Remove (moved to
12769         type-stack.c).
12770         * f-exp.y (type_stack): New global.
12771         Update rules.
12772         (push_kind_type, f_parse): Update.
12773         * d-exp.y (type_stack): New global.
12774         Update rules.
12775         (d_parse): Update.
12776         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12777         Update rules.
12778         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12779         (HFILES_NO_SRCDIR): Add type-stack.h.
12780
12781 2019-04-04  Tom Tromey  <tom@tromey.com>
12782
12783         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12784         (rust_parser::convert_ast_to_expression, rust_parse)
12785         (rust_lex_test_completion, rust_lex_tests): Update.
12786         * parser-defs.h (struct expr_completion_state): New.
12787         (struct parser_state) <parser_state>: Add completion parameter.
12788         <mark_struct_expression, mark_completion_tag>: New methods.
12789         <parse_completion, m_completion_state>: New members.
12790         (prefixify_expression, null_post_parser): Update.
12791         (mark_struct_expression, mark_completion_tag): Don't declare.
12792         * parse.c (parse_completion, expout_last_struct)
12793         (expout_tag_completion_type, expout_completion_name): Remove
12794         globals.
12795         (parser_state::mark_struct_expression)
12796         (parser_state::mark_completion_tag): Now methods.
12797         (prefixify_expression): Add last_struct parameter.
12798         (prefixify_subexp): Likewise.
12799         (parse_exp_1): Update.
12800         (parse_exp_in_context): Add cstate parameter.  Update.
12801         (parse_expression_for_completion): Create an
12802         expr_completion_state.
12803         (null_post_parser): Add "completion" parameter.
12804         * p-exp.y: Update rules.
12805         (yylex): Update.
12806         * language.h (struct language_defn) <la_post_parser>: Add
12807         "completing" parameter.
12808         * go-exp.y: Update rules.
12809         (lex_one_token): Update.
12810         * expression.h (parse_completion): Don't declare.
12811         * d-exp.y: Update rules.
12812         (lex_one_token): Update rules.
12813         * c-exp.y: Update rules.
12814         (lex_one_token): Update.
12815         * ada-lang.c (resolve): Add "parse_completion" parameter.
12816         (resolve_subexp): Likewise.
12817         (ada_resolve_function): Likewise.
12818
12819 2019-04-04  Tom Tromey  <tom@tromey.com>
12820
12821         * parser-defs.h (struct parser_state) <start_arglist,
12822         end_arglist>: New methods.
12823         <arglist_len, m_funcall_chain>: New members.
12824         (arglist_len, start_arglist, end_arglist): Don't declare.
12825         * parse.c (arglist_len, funcall_chain): Remove global.
12826         (start_arglist, end_arglist): Remove functions.
12827         (parse_exp_in_context): Update.
12828         * p-exp.y: Update rules.
12829         * m2-exp.y: Update rules.
12830         * go-exp.y: Update rules.
12831         * f-exp.y: Update rules.
12832         * d-exp.y: Update rules.
12833         * c-exp.y: Update rules.
12834
12835 2019-04-04  Tom Tromey  <tom@tromey.com>
12836
12837         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12838         lex_operator, push_back>: New methods.
12839         Update all rules.
12840         (rust_parser::lex_hex, lex_escape): Rename and update.
12841         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12842         (rust_parser::lex_operator): Rename and update.
12843         (rust_parser::lex_number, rustyylex, rustyyerror)
12844         (rust_lex_test_init, rust_lex_test_sequence)
12845         (rust_lex_test_push_back, rust_lex_tests): Update.
12846         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12847         parameter.
12848         <lexptr, prev_lexptr>: New members.
12849         (lexptr, prev_lexptr): Don't declare.
12850         * parse.c (lexptr, prev_lexptr): Remove globals.
12851         (parse_exp_in_context): Update.
12852         * p-exp.y (yylex, yyerror): Update.
12853         * m2-exp.y (parse_number, yylex, yyerror): Update.
12854         * go-exp.y (lex_one_token, yyerror): Update.
12855         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12856         * d-exp.y (lex_one_token, yyerror): Update.
12857         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12858         (lex_one_token, yyerror): Update.
12859         * ada-lex.l (YY_INPUT): Update.
12860         (rewind_to_char): Update.
12861         * ada-exp.y (yyerror): Update.
12862
12863 2019-04-04  Tom Tromey  <tom@tromey.com>
12864
12865         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12866         * parser-defs.h (struct parser_state) <parser_state>: Add new
12867         parameter.
12868         <comma_terminates>: New member.
12869         (comma_terminates): Don't declare global.
12870         * parse.c (comma_terminates): Remove global.
12871         (parse_exp_in_context): Update.
12872         * p-exp.y (yylex): Update.
12873         * m2-exp.y (yylex): Update.
12874         * go-exp.y (lex_one_token): Update.
12875         * f-exp.y (yylex): Update.
12876         * d-exp.y (lex_one_token): Update.
12877         * c-exp.y (lex_one_token): Update.
12878         * ada-lex.l: Update.
12879
12880 2019-04-04  Tom Tromey  <tom@tromey.com>
12881
12882         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12883         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12884         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12885         * parser-defs.h (paren_depth): Don't declare.
12886         * parse.c (paren_depth): Remove global.
12887         (parse_exp_in_context): Update.
12888         * p-exp.y (paren_depth): New global.
12889         (pascal_parse): Initialize it.
12890         * m2-exp.y (paren_depth): New global.
12891         (m2_parse): Initialize it.
12892         * go-exp.y (paren_depth): New global.
12893         (go_parse): Initialize it.
12894         * f-exp.y (paren_depth): New global.
12895         (f_parse): Initialize it.
12896         * d-exp.y (paren_depth): New global.
12897         (d_parse): Initialize it.
12898         * c-exp.y (paren_depth): New global.
12899         (c_parse): Initialize it.
12900         * ada-lex.l (paren_depth): New global.
12901         (lexer_init): Initialize it.
12902
12903 2019-04-04  Tom Tromey  <tom@tromey.com>
12904
12905         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12906         (rust_parser::convert_ast_to_type)
12907         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12908         * parser-defs.h (struct parser_state) <parser_state>: Add
12909         parameters.  Initialize new members.
12910         <expression_context_block, expression_context_pc>: New members.
12911         * parse.c (expression_context_block, expression_context_pc):
12912         Remove globals.
12913         (parse_exp_in_context): Update.
12914         * p-exp.y: Update all rules.
12915         (yylex): Update.
12916         * m2-exp.y: Update all rules.
12917         (yylex): Update.
12918         * go-exp.y (yylex): Update.
12919         * f-exp.y (yylex): Update.
12920         * d-exp.y: Update all rules.
12921         (yylex): Update.
12922         * c-exp.y: Update all rules.
12923         (lex_one_token, classify_name, yylex, c_parse): Update.
12924         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12925
12926 2019-04-04  Tom Tromey  <tom@tromey.com>
12927
12928         * gdbarch.h, gdbarch.c: Rebuild.
12929         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12930         * stap-probe.h:
12931         (struct stap_parse_info): Replace "parser_state" with
12932         "expr_builder".
12933         * parser-defs.h (struct expr_builder): Rename from "parser_state".
12934         (parser_state): New class.
12935         * parse.c (expr_builder): Rename.
12936         (expr_builder::release): Rename.
12937         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
12938         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
12939         (write_exp_elt_longcst, write_exp_elt_floatcst)
12940         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
12941         (write_exp_string_vector, write_exp_bitstring)
12942         (write_exp_msymbol, mark_struct_expression)
12943         (write_dollar_variable)
12944         (insert_type_address_space, increase_expout_size): Replace
12945         "parser_state" with "expr_builder".
12946         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
12947         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
12948         "parser_state" with "expr_builder".
12949
12950 2019-04-04  Tom Tromey  <tom@tromey.com>
12951
12952         * rust-exp.y: Replace "parse_language" with method call.
12953         * p-exp.y:
12954         (yylex): Replace "parse_language" with method call.
12955         * m2-exp.y:
12956         (yylex): Replace "parse_language" with method call.
12957         * go-exp.y (classify_name): Replace "parse_language" with method
12958         call.
12959         * f-exp.y (yylex): Replace "parse_language" with method call.
12960         * d-exp.y (lex_one_token): Replace "parse_language" with method
12961         call.
12962         * c-exp.y:
12963         (lex_one_token, classify_name, yylex): Replace "parse_language"
12964         with method call.
12965         * ada-exp.y (find_primitive_type, type_char)
12966         (type_system_address): Replace "parse_language" with method call.
12967
12968 2019-04-04  Tom Tromey  <tom@tromey.com>
12969
12970         * rust-exp.y: Replace "parse_gdbarch" with method call.
12971         * parse.c (write_dollar_variable, insert_type_address_space):
12972         Replace "parse_gdbarch" with method call.
12973         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
12974         call.
12975         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
12976         call.
12977         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
12978         "parse_gdbarch" with method call.
12979         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
12980         with method call.
12981         * f-exp.y (parse_type, parse_f_type, yylex): Replace
12982         "parse_gdbarch" with method call.
12983         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
12984         "parse_gdbarch" with method call.
12985         * c-exp.y (parse_type, parse_number, classify_name): Replace
12986         "parse_gdbarch" with method call.
12987         * ada-lex.l: Replace "parse_gdbarch" with method call.
12988         * ada-exp.y (parse_type, find_primitive_type, type_char)
12989         (type_system_address): Replace "parse_gdbarch" with method call.
12990
12991 2019-04-04  Tom Tromey  <tom@tromey.com>
12992
12993         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
12994         * stap-probe.c (stap_parse_argument): Update.
12995         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
12996         initial_size parameter.
12997         * rust-exp.y (rust_lex_tests): Update.
12998         * parse.c (parser_state): Update.
12999         (parse_exp_in_context): Update.
13000         * parser-defs.h (struct parser_state) <parser_state>: Remove
13001         "initial_size" parameter.
13002
13003 2019-04-04  Tom Tromey  <tom@tromey.com>
13004
13005         * parser-defs.h (increase_expout_size): Don't declare.
13006         * parse.c (increase_expout_size): Now static.
13007
13008 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13009
13010         * gnu-nat.c (gnu_nat_target::wait): Fix
13011         target_waitstatus_to_string call.
13012
13013 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13014
13015         * eval.c (evaluate_subexp_standard): Handle internal functions
13016         during Fortran function call handling.
13017
13018 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13019
13020         * NEWS: Mention new internal functions.
13021         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13022         (read_base_type): Use dwarf2_init_complex_target_type.
13023         * value.c (creal_internal_fn): New function.
13024         (cimag_internal_fn): New function.
13025         (_initialize_values): Register new internal functions.
13026
13027 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13028
13029         * infrun.c (stop_all_threads): If debug_infrun, always
13030         trace the wait status after wait_one, using
13031         target_waitstatus_to_string and target_pid_to_str.
13032         (handle_inferior_event): Replace various trace of
13033         wait status kind by a single trace.
13034         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13035         wait status kind image by target_waitstatus_to_string.
13036         * target/waitstatus.c (target_waitstatus_to_string): Fix
13037         obsolete comment.
13038
13039 2019-04-01  Tom Tromey  <tromey@adacore.com>
13040
13041         PR symtab/23331:
13042         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13043
13044 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13045             Pedro Alves  <palves@redhat.com>
13046
13047         * top.c (quit_force): Call 'finalize_values'.
13048         * value.c (finalize_values): New function.
13049         * value.h (finalize_values): Declare.
13050
13051 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13052
13053         * NEWS: Announce $_gdb_major and $_gdb_minor.
13054
13055         * top.c (init_gdb_version_vars): New function.
13056         (gdb_init): Call init_gdb_version_vars.
13057
13058 2019-03-29  Tom Tromey  <tromey@adacore.com>
13059
13060         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13061         help text.  Remove dead code.
13062
13063 2019-03-29  Keith Seitz  <keiths@redhat.com>
13064
13065         From Siddhesh Poyarekar:
13066         * f-lang.h (f77_get_upperbound): Return LONGEST.
13067         (f77_get_lowerbound): Likewise.
13068         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13069         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13070         print them.
13071         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13072         plongest to format print it.
13073         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13074         (f77_get_upperbound): Likewise.
13075         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13076         LOWER_BOUND to LONGEST.
13077         (f77_create_arrayprint_offset_tbl): Likewise.
13078
13079 2019-03-29  Keith Seitz  <keiths@redhat.com>
13080
13081         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13082         %s/pulongest for TYPE_LENGTH instead of %d in format
13083         strings.
13084         * ada-typerint.c (ada_print_type): Likewise.
13085         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13086         * compile/compile-c-support.c (generate_register_struct): Likewise.
13087         * gdbtypes.c (recursive_dump_type): Likewise.
13088         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13089         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13090         instead of %d in format strings.
13091         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13092         to std::min to ULONGEST.
13093         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13094         instead of %d in format strings.
13095         * tracepoint.c (info_scope_command): Likewise.
13096         * typeprint.c (print_offset_data::update)
13097         (print_offset_data::finish): Likewise.
13098         * xtensa-tdep.c (xtensa_store_return_value)
13099         (xtensa_push_dummy_call): Likewise.
13100
13101 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13102
13103         * windows-nat.c (display_selector): Fixed format specifications
13104         for 64-bit Cygwin.
13105
13106 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13107
13108         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13109
13110 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13111
13112         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13113         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13114         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13115         (nios2_linux_init_abi): Install it.
13116
13117 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13118
13119         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13120
13121 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13122
13123         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13124
13125 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13126             Tom Tromey  <tromey@adacore.com>
13127
13128         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13129
13130 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13131
13132         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13133         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13134         method to compute the bounds of range types. Also print "[evaluated]"
13135         if the bounds' values come from a dynamic evaluation.
13136
13137 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13138
13139         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13140         whitespace when pretty printing is on.
13141
13142 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13143
13144         * ppc-linux-nat.c: Add include.
13145
13146 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13147
13148         * NEWS: Mention AArch64 Pointer Authentication.
13149
13150 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13151
13152         * arm-linux-nat.c: Add include.
13153
13154 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13155
13156         * source-cache.c (source_cache::get_source_lines): Re-read
13157         fullname after calling open_source_file.
13158
13159 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13160
13161         * NEWS: Mention TLS support for FreeBSD.
13162
13163 2019-03-25  Tom Tromey  <tromey@adacore.com>
13164
13165         * minsyms.c (BUNCH_SIZE): Update comment.
13166         (~minimal_symbol_reader): Remove old comment.
13167         (compact_minimal_symbols): Update comment.
13168         (minimal_symbol_reader::install): Remove old comment.  Update
13169         other comments.
13170
13171 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13172
13173         * s390-linux-nat.c: Add include.
13174
13175 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13176
13177         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13178         Call linux_get_hwcap.
13179         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13180         Likewise.
13181         (aarch64_linux_get_hwcap): Remove function.
13182         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13183         declaration.
13184         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13185         linux_get_hwcap.
13186         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13187         * linux-tdep.c (linux_get_hwcap): Add function.
13188         (linux_get_hwcap2): Likewise.
13189         * linux-tdep.h (linux_get_hwcap): Add declaration.
13190         (linux_get_hwcap2): Likewise.
13191         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13192         (ppc_linux_get_hwcap2): Likewise.
13193         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13194         linux_get_hwcap.
13195         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13196         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13197         (ppc_linux_nat_target::read_description): Likewise.
13198         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13199         * s390-linux-nat.c: Likewise.
13200         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13201
13202 2019-03-24  Tom Tromey  <tom@tromey.com>
13203
13204         * ada-lang.c (standard_lookup): Simplify initialization.
13205         (ada_lookup_symbol_nonlocal): Simplify return.
13206         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13207         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13208         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13209         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13210         initialization.
13211         * solib.c (solib_global_lookup): Simplify.
13212         * symtab.c (null_block_symbol): Remove.
13213         (symbol_cache_lookup): Simplify returns.
13214         (lookup_language_this): Simplify returns.
13215         (lookup_symbol_aux): Simplify return.
13216         (lookup_local_symbol): Simplify returns.
13217         (lookup_global_symbol_from_objfile): Simplify return.
13218         (lookup_symbol_in_objfile_symtabs)
13219         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13220         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13221         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13222         * cp-namespace.c (cp_lookup_bare_symbol)
13223         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13224         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13225         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13226         (cp_lookup_symbol_via_imports): Simplify initialization.
13227         (find_symbol_in_baseclass): Likewise.
13228         * symtab.h (null_block_symbol): Remove.
13229         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13230         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13231         (d_lookup_symbol_module): Likewise.
13232         (find_symbol_in_baseclass): Simplify initialization.
13233
13234 2019-03-24  Tom Tromey  <tom@tromey.com>
13235
13236         * expression.h: Don't include symtab.h.
13237         (struct block): Forward declare.
13238
13239 2019-03-24  Tom Tromey  <tom@tromey.com>
13240
13241         * c-exp.y (typebase): Remove casts.
13242         * gdbtypes.c (lookup_unsigned_typename, )
13243         (lookup_signed_typename): Remove cast.
13244         * eval.c (parse_to_comma_and_eval): Remove cast.
13245         * parse.c (write_dollar_variable): Remove cast.
13246         * block.h (struct block) <superblock>: Now const.
13247         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13248         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13249         (map_block): Make "block" const.
13250         * symfile.h (struct quick_symbol_functions)
13251         <map_matching_symbols>: Constify block argument to "callback".
13252         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13253         const.
13254         (find_pc_sect_compunit_symtab): Make "b" const.
13255         (find_symbol_at_address): Likewise.
13256         (search_symbols): Likewise.
13257         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13258         (dw2_debug_names_lookup_symbol): Likewise.
13259         (dw2_map_matching_symbols): Update.
13260         * p-valprint.c (pascal_val_print): Remove "block".
13261         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13262         (aux_add_nonlocal_symbols): Make "block" const.
13263         (resolve_subexp): Remove cast.
13264         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13265         const.
13266         (iterate_over_file_blocks): Likewise.
13267         * f-exp.y (%union) <bval>: Remove.
13268         * coffread.c (patch_opaque_types): Make "b" const.
13269         * spu-tdep.c (spu_catch_start): Make "block" const.
13270         * c-valprint.c (print_unpacked_pointer): Remove "block".
13271         * symmisc.c (dump_symtab_1): Make "b" const.
13272         (block_depth): Make "block" const.
13273         * d-exp.y (%union) <bval>: Remove.
13274         * cp-support.h (cp_lookup_rtti_type): Update.
13275         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13276         * psymtab.c (psym_lookup_symbol): Make "block" const.
13277         (maintenance_check_psymtabs): Make "b" const.
13278         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13279         (enumerate_locals, enumerate_args): Update.
13280         * python/py-symtab.c (stpy_global_block): Make "block" const.
13281         (stpy_static_block): Likewise.
13282         * inline-frame.c (block_starting_point_at): Make "new_block"
13283         const.
13284         * block.c (find_block_in_blockvector): Make return type const.
13285         (blockvector_for_pc_sect): Make "b" const.
13286         (find_block_in_blockvector): Make "b" const.
13287
13288 2019-03-23  Tom Tromey  <tom@tromey.com>
13289
13290         * varobj.c (varobj_create): Update.
13291         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13292         * printcmd.c (display_command, do_one_display): Don't reset
13293         innermost_block.
13294         * parser-defs.h (enum innermost_block_tracker_type): Move to
13295         expression.h.
13296         (innermost_block): Update comment.
13297         * parse.c (parse_exp_1): Add tracker_types parameter.
13298         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13299         tracker_types parameter.  Reset innermost_block.
13300         (parse_exp_in_context): Remove.
13301         (parse_expression_for_completion): Update.
13302         * objfiles.c (~objfile): Don't reset expression_context_block or
13303         innermost_block.
13304         * expression.h (enum innermost_block_tracker_type): Move from
13305         parser-defs.h.
13306         (parse_exp_1): Add tracker_types parameter.
13307         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13308         reset innermost_block.
13309
13310 2019-03-23  Tom Tromey  <tom@tromey.com>
13311
13312         * objfiles.h: Include bcache.h.
13313
13314 2019-03-23  Tom Tromey  <tom@tromey.com>
13315
13316         * linespec.c (get_current_search_block): Use
13317         scoped_restore_current_language.
13318         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13319
13320 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13321             Jiong Wang  <jiong.wang@arm.com>
13322
13323         * aarch64-linux-tdep.c
13324         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13325         section.
13326         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13327
13328 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13329             Jiong Wang  <jiong.wang@arm.com>
13330
13331         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13332         instructions.
13333         (aarch64_analyze_prologue_test): Add PACIASP test.
13334         (aarch64_prologue_prev_register): Unmask PC value.
13335
13336 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13337             Jiong Wang  <jiong.wang@arm.com>
13338
13339         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13340         (aarch64_dwarf2_prev_register): Unmask PC value.
13341         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13342         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13343         DW_CFA_AARCH64_negate_ra_state.
13344         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13345
13346 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13347             Jiong Wang  <jiong.wang@arm.com>
13348
13349         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13350         registers.
13351         (aarch64_pseudo_register_name): Likewise.
13352         (aarch64_pseudo_register_type): Likewise.
13353         (aarch64_pseudo_register_reggroup_p): Likewise.
13354         (aarch64_gdbarch_init): Add pauth registers.
13355         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13356         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13357         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13358         (struct gdbarch_tdep): Add regnum for ra_state.
13359
13360 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13361             Jiong Wang  <jiong.wang@arm.com>
13362
13363         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13364
13365 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13366             Jiong Wang  <jiong.wang@arm.com>
13367
13368         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13369         function.
13370         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13371         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13372         (aarch64_gdbarch_init): Add puth registers.
13373         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13374         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13375         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13376
13377 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13378             Jiong Wang  <jiong.wang@arm.com>
13379
13380         * aarch64-linux-nat.c
13381         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13382         * aarch64-linux-tdep.c
13383         (aarch64_linux_core_read_description): Likewise.
13384         (aarch64_linux_get_hwcap): New function.
13385         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13386         (aarch64_linux_get_hwcap): New declaration.
13387
13388 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13389             Jiong Wang  <jiong.wang@arm.com>
13390
13391         * aarch64-linux-nat.c
13392         (aarch64_linux_nat_target::read_description): Add pauth param.
13393         * aarch64-linux-tdep.c
13394         (aarch64_linux_core_read_description): Likewise.
13395         * aarch64-tdep.c (struct target_desc): Add in pauth.
13396         (aarch64_read_description): Add pauth param.
13397         (aarch64_gdbarch_init): Likewise.
13398         * aarch64-tdep.h (aarch64_read_description): Likewise.
13399         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13400         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13401         * features/Makefile: Add new files.
13402         * features/aarch64-pauth.c: New file.
13403         * features/aarch64-pauth.xml: New file.
13404
13405 2019-03-20  Tom Tromey  <tromey@adacore.com>
13406
13407         * infrun.c (handle_inferior_event): Rename from
13408         handle_inferior_event_1.  Create a scoped_value_mark.
13409         (handle_inferior_event): Remove.
13410
13411 2019-03-19  Tom Tromey  <tromey@adacore.com>
13412
13413         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13414         * infrun.h (print_stop_event): Add "displays" parameter.
13415         * infrun.c (print_stop_event): Add "displays" parameter.
13416
13417 2019-03-19  Pedro Alves  <palves@redhat.com>
13418
13419         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13420         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13421         to -1.  Fix TABs vs spaces.
13422         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13423         * tui/tui-out.h (tui_ui_out) Add intro comments.
13424         <m_line, m_start_of_line>: In-class initialize, and add describing
13425         comment.
13426
13427 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13428
13429         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13430         variable names.
13431         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13432
13433 2019-03-18  Pedro Alves  <palves@redhat.com>
13434             Eli Zaretskii <eliz@gnu.org>
13435
13436         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13437         m_line and m_start_of_line.
13438
13439 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13440
13441         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13442         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13443         it returns a newline.  This fixes a regression in TU mode, whereby
13444         the next line is output on the same screen line as the user input.
13445
13446 2019-03-18  Tom Tromey  <tromey@adacore.com>
13447
13448         * minsyms.c (minimal_symbol_reader::install): Remove call to
13449         obstack_blank.
13450
13451 2019-03-18  Pedro Alves  <palves@redhat.com>
13452
13453         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13454         New globals.
13455         (apply_style): New, factored out from ...
13456         (apply_ansi_escape): ... this.  Handle reverse video mode.
13457         (tui_set_reverse_mode): New function.
13458         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13459         * tui/tui-winsource.c (tui_show_source_line): Use
13460         tui_set_reverse_mode instead of setting A_STANDOUT.
13461         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13462         New setter methods.
13463
13464 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13465
13466         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13467         Handle tabs.
13468
13469 2019-03-18  Tom Tromey  <tromey@adacore.com>
13470
13471         * ada-lang.c (empty_array): Add "high" parameter.
13472         (ada_evaluate_subexp): Update.
13473
13474 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13475
13476         * unittests/string_view-selftests.c: Define
13477         _initialize_string_view_selftests unconditionally.
13478
13479 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13480
13481         PR gdb/24350
13482         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13483
13484 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13485
13486         PR gdb/24351
13487         * windows-nat.c (display_selector): Fix format specifiers.
13488
13489 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13490
13491         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13492         tui_refill_source_window instead of tui_refresh_win, to update the
13493         current execution line.  This fixes redisplay of the current line
13494         when stepping through the code with "next" or "step".
13495
13496 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13497
13498         * source-cache.c (source_cache::get_source_lines): Call
13499         find_source_lines to initialize s->nlines.  This fixes vertical
13500         scrolling of TUI source window when the DOWN arrow is pressed.
13501
13502 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13503
13504         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13505         linux-thread-db.c (_initialize_thread_db): Likewise.
13506
13507 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13508
13509         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13510         wclrtoeol in tui_show_source_line".  This reverts changes made in
13511         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13512
13513 2019-03-15  Tom Tromey  <tom@tromey.com>
13514
13515         * symtab.h (struct minimal_symbol): Derive from
13516         general_symbol_info.
13517         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13518         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13519         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13520         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13521         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13522         (MSYMBOL_SEARCH_NAME): Update.
13523         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13524         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13525         * minsyms.c (minimal_symbol_reader::record_full): Update.
13526
13527 2019-03-15  Tom Tromey  <tom@tromey.com>
13528
13529         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13530
13531 2019-03-15  Tom Tromey  <tom@tromey.com>
13532
13533         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13534         unique_xmalloc_ptr.
13535         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13536         Update.
13537         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13538         (build_minimal_symbol_hash_tables)
13539         (minimal_symbol_reader::install): Update.
13540
13541 2019-03-15  Tom Tromey  <tom@tromey.com>
13542
13543         * symtab.c (create_demangled_names_hash): Update.
13544         (symbol_set_names): Update.
13545         * objfiles.h (struct objfile_per_bfd_storage)
13546         <demangled_names_hash>: Now an htab_up.
13547         * objfiles.c (objfile_per_bfd_storage): Simplify.
13548
13549 2019-03-15  Tom Tromey  <tom@tromey.com>
13550
13551         * objfiles.h (struct objfile_per_bfd_storage): Declare
13552         destructor.
13553         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13554         New.
13555         (get_objfile_bfd_data): Use new.  Don't initialize
13556         language_of_main.
13557         (free_objfile_per_bfd_storage): Remove.
13558         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13559
13560 2019-03-15  Tom Tromey  <tom@tromey.com>
13561
13562         * symfile.c (reread_symbols): Update.
13563         * objfiles.c (objfile::objfile): Update.
13564         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13565         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13566         comment.
13567         (minimal_symbol_reader::install): Update.
13568         (terminate_minimal_symbol_table): Remove.
13569         * jit.c (jit_object_close_impl): Update.
13570
13571 2019-03-15  Tom Tromey  <tom@tromey.com>
13572
13573         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13574         initializations.
13575
13576 2019-03-15  Tom Tromey  <tom@tromey.com>
13577
13578         * objfiles.h (struct objfile_per_bfd_storage)
13579         <demangled_hash_languages>: Now a bitset.
13580         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13581         (lookup_minimal_symbol): Update.
13582
13583 2019-03-15  Tom Tromey  <tom@tromey.com>
13584
13585         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13586         Don't return the symbol.
13587         * coffread.c (record_minimal_symbol): Use record_full.
13588
13589 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13590
13591         The MS-Windows port of ncurses fails to switch to a color pair if
13592         one or both of the colors are the implicit default colors.  This
13593         change records the default colors when TUI is initialized, and
13594         then specifies them explicitly when a color pair uses the default
13595         colors.  This allows color styling in TUI mode on MS-Windows.
13596
13597         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13598         ncurses_norm_attr.
13599         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13600         colors in ncurses_norm_attr.
13601         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13602         "none", replace it with the default color recorded in
13603         ncurses_norm_attr.
13604
13605 2019-03-14  Tom Tromey  <tromey@adacore.com>
13606
13607         * source-cache.h (class source_cache) <get_source_lines>: Return
13608         std::string.
13609         * source-cache.c (source_cache::extract_lines): Handle case where
13610         first_pos==npos.  Return std::string.
13611         (source_cache::get_source_lines): Update.
13612
13613 2019-03-14  Tom Tromey  <tromey@adacore.com>
13614
13615         * NEWS: Add item for "style sources" commands.
13616         * source-cache.c (source_cache::get_source_lines): Check
13617         source_styling.
13618         * cli/cli-style.c (source_styling): New global.
13619         (_initialize_cli_style): Add "style sources" commands.
13620         (show_style_sources): New function.
13621         * cli/cli-style.h (source_styling): Declare.
13622
13623 2019-03-14  Pedro Alves  <palves@redhat.com>
13624             Tom Tromey  <tromey@adacore.com>
13625
13626         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13627         * tui/tui-winsource.c (tui_refill_source_window): New function,
13628         from...
13629         (tui_horizontal_source_scroll): ... here.  Move some logic.
13630         * cli/cli-style.c (set_style_enabled): Notify new observable.
13631         * tui/tui-hooks.c (tui_redisplay_source): New function.
13632         (tui_attach_detach_observers): Attach or detach
13633         tui_redisplay_source.
13634         * observable.h (source_styling_changed): New observable.
13635         * observable.c: Define source_styling_changed observable.
13636
13637 2019-03-13  Tom Tromey  <tromey@adacore.com>
13638
13639         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13640         (i386_gnu_nat_target::store_registers): Update.
13641         * target-debug.h (target_debug_print_std_string): New macro.
13642         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13643         * windows-tdep.c (display_one_tib): Update.
13644         * tui/tui-stack.c (tui_make_status_line): Update.
13645         * top.c (print_inferior_quit_action): Update.
13646         * thread.c (thr_try_catch_cmd): Update.
13647         (add_thread_with_info): Update.
13648         (thread_target_id_str): Update.
13649         (thr_try_catch_cmd): Update.
13650         (thread_command): Update.
13651         (thread_find_command): Update.
13652         * record-btrace.c (record_btrace_target::info_record)
13653         (record_btrace_resume_thread, record_btrace_target::resume)
13654         (record_btrace_cancel_resume, record_btrace_step_thread)
13655         (record_btrace_target::wait, record_btrace_target::wait)
13656         (record_btrace_target::wait, record_btrace_target::stop): Update.
13657         * progspace.c (print_program_space): Update.
13658         * process-stratum-target.c
13659         (process_stratum_target::thread_address_space): Update.
13660         * linux-fork.c (linux_fork_mourn_inferior)
13661         (detach_checkpoint_command, info_checkpoints_command)
13662         (linux_fork_context): Update.
13663         (linux_fork_detach): Update.
13664         (class scoped_switch_fork_info): Update.
13665         (delete_checkpoint_command): Update.
13666         * infrun.c (follow_fork_inferior): Update.
13667         (follow_fork_inferior): Update.
13668         (proceed_after_vfork_done): Update.
13669         (handle_vfork_child_exec_or_exit): Update.
13670         (follow_exec): Update.
13671         (displaced_step_prepare_throw): Update.
13672         (displaced_step_restore): Update.
13673         (start_step_over): Update.
13674         (resume_1): Update.
13675         (clear_proceed_status_thread): Update.
13676         (proceed): Update.
13677         (print_target_wait_results): Update.
13678         (do_target_wait): Update.
13679         (context_switch): Update.
13680         (stop_all_threads): Update.
13681         (restart_threads): Update.
13682         (finish_step_over): Update.
13683         (handle_signal_stop): Update.
13684         (switch_back_to_stepped_thread): Update.
13685         (keep_going_pass_signal): Update.
13686         (print_exited_reason): Update.
13687         (normal_stop): Update.
13688         * inferior.c (inferior_pid_to_str): Change return type.
13689         (print_selected_inferior): Update.
13690         (add_inferior): Update.
13691         (detach_inferior): Update.
13692         * dummy-frame.c (fprint_dummy_frames): Update.
13693         * dcache.c (dcache_info_1): Update.
13694         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13695         (btrace_fetch, btrace_clear): Update.
13696         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13697         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13698         type.
13699         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13700         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13701         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13702         * gdbarch.c, gdbarch.h: Rebuild.
13703         * gdbarch.sh (core_pid_to_str): Change return type.
13704         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13705         return type.
13706         (windows_nat_target::pid_to_str): Change return type.
13707         (windows_delete_thread): Update.
13708         (windows_nat_target::attach): Update.
13709         (windows_nat_target::files_info): Update.
13710         * target-delegates.c: Rebuild.
13711         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13712         return type.
13713         (sol_thread_target::pid_to_str): Change return type.
13714         * remote.c (class remote_target) <pid_to_str>: Change return
13715         type.
13716         (remote_target::pid_to_str): Change return type.
13717         (extended_remote_target::attach, remote_target::remote_stop_ns)
13718         (remote_target::remote_notif_remove_queued_reply)
13719         (remote_target::push_stop_reply, remote_target::disable_btrace):
13720         Update.
13721         (extended_remote_target::attach): Update.
13722         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13723         type.
13724         (gdbsim_target::pid_to_str): Change return type.
13725         * ravenscar-thread.c (struct ravenscar_thread_target)
13726         <pid_to_str>: Change return type.
13727         (ravenscar_thread_target::pid_to_str): Change return type.
13728         * procfs.c (class procfs_target) <pid_to_str>: Change return
13729         type.
13730         (procfs_target::pid_to_str): Change return type.
13731         (procfs_target::attach): Update.
13732         (procfs_target::detach): Update.
13733         (procfs_target::fetch_registers): Update.
13734         (procfs_target::store_registers): Update.
13735         (procfs_target::wait): Update.
13736         (procfs_target::files_info): Update.
13737         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13738         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13739         return type.
13740         (nto_procfs_target::pid_to_str): Change return type.
13741         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13742         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13743         return type.
13744         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13745         (exit_lwp): Update.
13746         (attach_proc_task_lwp_callback, get_detach_signal)
13747         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13748         (linux_nat_target::resume, wait_lwp, stop_callback)
13749         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13750         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13751         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13752         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13753         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13754         type.
13755         (inf_ptrace_target::attach): Update.
13756         (inf_ptrace_target::files_info): Update.
13757         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13758         type.
13759         (go32_nat_target::pid_to_str): Change return type.
13760         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13761         (gnu_nat_target::wait): Update.
13762         (gnu_nat_target::wait): Update.
13763         (gnu_nat_target::resume): Update.
13764         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13765         (fbsd_nat_target::wait): Update.
13766         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13767         type.
13768         (darwin_nat_target::attach): Update.
13769         * corelow.c (class core_target) <pid_to_str>: Change return type.
13770         (core_target::pid_to_str): Change return type.
13771         * target.c (normal_pid_to_str): Change return type.
13772         (default_pid_to_str): Likewise.
13773         (target_pid_to_str): Change return type.
13774         (target_translate_tls_address): Update.
13775         (target_announce_detach): Update.
13776         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13777         return type.
13778         (bsd_uthread_target::pid_to_str): Change return type.
13779         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13780         type.
13781         (bsd_kvm_target::pid_to_str): Change return type.
13782         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13783         return type.
13784         (aix_thread_target::pid_to_str): Change return type.
13785         * target.h (struct target_ops) <pid_to_str>: Change return type.
13786         (target_pid_to_str, normal_pid_to_str): Likewise.
13787         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13788         type.
13789         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13790         type.
13791         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13792         return type.
13793         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13794         type.
13795         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13796         type.
13797         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13798         return type.
13799
13800 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13801
13802         * NEWS: Mention that the new default MI version is 3.  Mention
13803         changes to the output of commands and events that deal with
13804         multi-location breakpoints.
13805         * breakpoint.c: Include "mi/mi-out.h".
13806         (print_one_breakpoint): Change output syntax if using MI version
13807         >= 3.
13808         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13809         New.
13810         (mi_multi_location_breakpoint_output_fixed): New.
13811         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13812         (mi_cmd_fix_multi_location_breakpoint_output): New.
13813         (mi_multi_location_breakpoint_output_fixed): New.
13814         * mi/mi-cmds.c (mi_cmds): Register command
13815         -fix-multi-location-breakpoint-output.
13816         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13817         interpreter "mi".
13818
13819 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13820
13821         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13822         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13823         instantiate mi_ui_out based on interpreter name.
13824         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13825         * mi/mi-main.c (mi_load_progress): Likewise.
13826
13827 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13828
13829         * NEWS: Combine separate "New targets" sections for 8.3.
13830
13831 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13832
13833         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13834         (ppcfbsd_init_abi): Install gdbarch
13835         "fetch_tls_load_module_address" and "get_thread_local_address"
13836         methods.
13837
13838 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13839
13840         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13841         (riscv_fbsd_init_abi): Install gdbarch
13842         "fetch_tls_load_module_address" and "get_thread_local_address"
13843         methods.
13844
13845 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13846
13847         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13848         (i386fbsd_init_abi): Install gdbarch
13849         "fetch_tls_load_module_address" and "get_thread_local_address"
13850         methods.
13851
13852 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13853
13854         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13855         (amd64fbsd_init_abi): Install gdbarch
13856         "fetch_tls_load_module_address" and "get_thread_local_address"
13857         methods.
13858
13859 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13860
13861         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13862         (struct fbsd_pspace_data): New type.
13863         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13864         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13865         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13866         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13867         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13868
13869 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13870
13871         * gdbtypes.c (lookup_struct_elt): New function.
13872         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13873         * gdbtypes.h (struct struct_elt): New type.
13874         (lookup_struct_elt): New prototype.
13875
13876 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13877
13878         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13879         remove disabled code block.
13880
13881 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13882
13883         * gdbarch.sh (get_thread_local_address): New method.
13884         * gdbarch.h, gdbarch.c: Regenerate.
13885         * target.c (target_translate_tls_address): Use
13886         gdbarch_get_thread_local_address if present instead of
13887         target::get_thread_local_address.
13888
13889 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13890
13891         * target.h (target::get_thread_local_address): Update comment.
13892
13893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13894
13895         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13896         objfile->separate_debug_objfile_backlink if not NULL.
13897
13898 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13899
13900         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13901         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13902         (amd64bsd_store_inferior_registers): Likewise.
13903         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13904         Enable segment base registers.
13905         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13906         PT_GETFSBASE and PT_GETGSBASE.
13907         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13908         PT_SETGSBASE.
13909         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13910         segment base registers.
13911         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13912
13913 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13914
13915         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13916         Update calls to i386_target_description to add 'segments'
13917         parameter.
13918         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13919         add segment base registers.
13920         * arch/i386.c (i386_create_target_description): Add 'segments'
13921         parameter to enable segment base registers.
13922         * arch/i386.h (i386_create_target_description): Likewise.
13923         * features/i386/32bit-segments.xml: New file.
13924         * features/i386/32bit-segments.c: Generate.
13925         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13926         call to i386_target_description to add 'segments' parameter.
13927         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13928         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13929         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13930         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13931         if feature is present.
13932         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13933         Add 'segments' parameter to call to i386_target_description.
13934         (i386_target_description): Add 'segments' parameter to enable
13935         segment base registers.
13936         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
13937         to call to i386_target_description.
13938         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
13939         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
13940         Define I386_NUM_REGS.
13941         (i386_target_description): Add 'segments' parameter to enable
13942         segment base registers.
13943
13944 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
13945
13946         PR/24325
13947         * source-cache.c: #undef open and close, to avoid unresolved
13948         externals during linking.
13949
13950 2019-03-12  Tom Tromey  <tromey@adacore.com>
13951
13952         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
13953         const.  Add initializers.
13954         (_initialize_remote): Don't initialize ptid globals.
13955
13956 2019-03-12  Pedro Alves  <palves@redhat.com>
13957
13958         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
13959
13960 2019-03-12  Pedro Alves  <palves@redhat.com>
13961
13962         * cp-name-parser.y (main): Remove unused 'len' variable.
13963
13964 2019-03-12  Tom Tromey  <tromey@adacore.com>
13965
13966         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
13967         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
13968
13969 2019-03-12  Tom Tromey  <tromey@adacore.com>
13970
13971         * linux-nat.c (iterate_over_lwps): Update.
13972         (stop_callback): Remove parameter.
13973         (stop_wait_callback, detach_callback, resume_set_callback)
13974         (select_singlestep_lwp_callback, set_ignore_sigint)
13975         (status_callback, resumed_callback, resume_clear_callback)
13976         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
13977         data parameter.
13978         (linux_nat_target::detach, linux_nat_target::resume)
13979         (linux_stop_and_wait_all_lwps, select_event_lwp)
13980         (linux_nat_filter_event, linux_nat_wait_1)
13981         (linux_nat_target::kill, linux_nat_target::stop)
13982         (linux_nat_target::stop): Update.
13983         (linux_nat_resume_callback): Change type.
13984         (resume_stopped_resumed_lwps, count_events_callback)
13985         (select_event_lwp_callback): Likewise.
13986         (linux_stop_lwp, linux_nat_stop_lwp): Update.
13987         * arm-linux-nat.c (struct update_registers_data): Remove.
13988         (update_registers_callback): Change type.
13989         (arm_linux_insert_hw_breakpoint1): Update.
13990         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
13991         parameter.
13992         (x86_linux_dr_set_addr): Update.
13993         (x86_linux_dr_set_control): Update.
13994         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
13995         (iterate_over_lwps): Use gdb::function_view.
13996         * nat/aarch64-linux-hw-point.c (struct
13997         aarch64_dr_update_callback_param): Remove.
13998         (debug_reg_change_callback): Change type.
13999         (aarch64_notify_debug_reg_change): Update.
14000         * s390-linux-nat.c (s390_refresh_per_info): Update.
14001
14002 2019-03-11  Tom Tromey  <tromey@adacore.com>
14003
14004         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14005         redundant assignment to "this_cu".
14006
14007 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14008
14009         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14010
14011 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14012
14013         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14014         from...
14015         (rank_one_type): ... this.
14016
14017 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14018
14019         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14020         from...
14021         (rank_one_type): ... this.
14022
14023 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14024
14025         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14026         from...
14027         (rank_one_type): ... this.
14028
14029 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14030
14031         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14032         from...
14033         (rank_one_type): ... this.
14034
14035 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14036
14037         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14038         from...
14039         (rank_one_type): ... this.
14040
14041 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14042
14043         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14044         from...
14045         (rank_one_type): ... this.
14046
14047 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14048
14049         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14050         from...
14051         (rank_one_type): ... this.
14052
14053 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14054
14055         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14056         from...
14057         (rank_one_type): ... this.
14058
14059 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14060
14061         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14062         from...
14063         (rank_one_type): ... this.
14064
14065 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14066
14067         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14068         from...
14069         (rank_one_type): ... this.
14070
14071 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14072
14073         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14074         from...
14075         (rank_one_type): ... this.
14076
14077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14078
14079         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14080         from...
14081         (rank_one_type): ... this.
14082
14083 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14084
14085         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14086         inferior-events' shows the example events.
14087
14088 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14089
14090         Support styling on native MS-Windows console
14091
14092         PR/24315
14093         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14094         on MS-Windows if $TERM is not defined.
14095
14096         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14097
14098         * posix-hdep.c (gdb_console_fputs):
14099         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14100         functions.
14101         * ui-file.h (gdb_console_fputs): Add prototype.
14102
14103         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14104         back to fputs only if the former returns zero.
14105
14106 2019-03-07  Tom Tromey  <tom@tromey.com>
14107
14108         * symmisc.c (print_symbol_bcache_statistics): Update.
14109         (print_objfile_statistics): Update.
14110         * symfile.c (allocate_symtab): Update.
14111         * stabsread.c: Don't include bcache.h.
14112         * psymtab.h (struct psymbol_bcache): Don't declare.
14113         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14114         (psymbol_bcache_init, psymbol_bcache_free)
14115         (psymbol_bcache_get_bcache): Don't declare.
14116         * psymtab.c (struct psymbol_bcache): Remove.
14117         (psymtab_storage::psymtab_storage): Update.
14118         (psymtab_storage::~psymtab_storage): Update.
14119         (psymbol_bcache_init, psymbol_bcache_free)
14120         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14121         (add_psymbol_to_bcache): Update.
14122         (allocate_psymtab): Update.
14123         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14124         macro_cache>: No longer pointers.
14125         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14126         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14127         * macrotab.c (macro_bcache): Update.
14128         * macroexp.c: Don't include bcache.h.
14129         * gdbtypes.c (check_types_worklist): Update.
14130         (types_deeply_equal): Remove TRY/CATCH.  Update.
14131         * elfread.c (elf_symtab_read): Update.
14132         * dwarf2read.c: Don't include bcache.h.
14133         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14134         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14135         (print_bcache_statistics, bcache_memory_used): Don't declare.
14136         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14137         methods.  Rename all data members.
14138         * bcache.c (struct bcache): Move to bcache.h.
14139         (bcache::expand_hash_table): Rename from expand_hash_table.
14140         (bcache): Remove.
14141         (bcache::insert): Rename from bcache_full.
14142         (bcache::compare): Rename from bcache_compare.
14143         (bcache_xmalloc): Remove.
14144         (bcache::~bcache): Rename from bcache_xfree.
14145         (bcache::print_statistics): Rename from print_bcache_statistics.
14146         (bcache::memory_used): Rename from bcache_memory_used.
14147
14148 2019-03-07  Pedro Alves  <palves@redhat.com>
14149
14150         * infrun.c (normal_stop): Also check for
14151         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14152
14153 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14154
14155         * f-lang.c (value_from_host_double): Moved to...
14156         * value.c (value_from_host_double): ...here.
14157         * value.h (value_from_host_double): Declare.
14158         * guile/scm-math.c (vlscm_convert_typed_number): Use
14159         value_from_host_double.
14160         (vlscm_convert_number): Likewise.
14161         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14162         * python/py-value.c (convert_value_from_python): Likewise.
14163
14164 2019-03-06  Tom Tromey  <tom@tromey.com>
14165
14166         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14167
14168 2019-03-06  Tom Tromey  <tom@tromey.com>
14169
14170         * utils.h (free_current_contents): Don't declare.
14171         * utils.c (free_current_contents): Remove.
14172
14173 2019-03-06  Tom Tromey  <tom@tromey.com>
14174
14175         * top.c (quit_force): Update.
14176         * main.c (captured_command_loop): Update.
14177         * common/new-op.c (operator new): Update.
14178         * common/common-exceptions.c (struct catcher)
14179         <save_cleanup_chain>: Remove member.
14180         (exceptions_state_mc_init): Update.
14181         (exception_try_scope_entry): Return nullptr.
14182         (exception_try_scope_exit, exception_rethrow)
14183         (throw_exception_sjlj, throw_exception_cxx): Update.
14184         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14185         (all_cleanups, do_cleanups, discard_cleanups)
14186         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14187         (restore_cleanups, restore_final_cleanups): Don't declare.
14188         (do_final_cleanups): Remove parameter.
14189         * common/cleanups.c (cleanup_chain, make_cleanup)
14190         (make_cleanup_dtor, all_cleanups, do_cleanups)
14191         (discard_my_cleanups, discard_cleanups)
14192         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14193         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14194         (null_cleanup): Remove.
14195         (do_final_cleanups): Remove parameter.
14196
14197 2019-03-06  Tom Tromey  <tom@tromey.com>
14198
14199         * remote.c (remote_target::remote_parse_stop_reply): Use
14200         unique_xmalloc_ptr.
14201
14202 2019-03-06  Tom Tromey  <tom@tromey.com>
14203
14204         * stabsread.c (struct stabs_field_info): Rename from field_info.
14205         <list, fnlist>: Add initializers.
14206         <obstack>: New member.
14207         (read_member_functions, read_struct_fields, read_baseclasses):
14208         Allocate on obstack.  Don't use cleanups.
14209         (read_one_struct_field, read_member_functions, read_struct_fields)
14210         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14211         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14212         (read_struct_type): Update.
14213
14214 2019-03-06  Tom Tromey  <tom@tromey.com>
14215
14216         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14217         * common/filestuff.h (make_cleanup_close): Don't declare.
14218         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14219         Remove.
14220
14221 2019-03-06  Tom Tromey  <tom@tromey.com>
14222
14223         * solib-aix.c: Use make_scope_exit.
14224
14225 2019-03-06  Tom Tromey  <tom@tromey.com>
14226
14227         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14228         Use make_scope_exit.
14229
14230 2019-03-06  Tom Tromey  <tom@tromey.com>
14231
14232         * solib-svr4.c (disable_probes_interface): Remove parameter.
14233         (svr4_handle_solib_event): Use make_scope_exit.
14234
14235 2019-03-06  Tom Tromey  <tom@tromey.com>
14236
14237         * remote.c (struct stop_reply_deleter): Remove.
14238         (stop_reply_up): Update.
14239         (struct stop_reply): Derive from notif_event.  Don't typedef.
14240         <regcache>: Now a std::vector.
14241         (stop_reply_xfree): Remove.
14242         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14243         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14244         (remote_target::discard_pending_stop_replies): Use delete.
14245         (remote_target::remote_parse_stop_reply): Update.
14246         (remote_target::process_stop_reply): Update.
14247         * remote-notif.h (struct notif_event): Add virtual destructor.
14248         Remove "dtr" member.
14249         (struct notif_client) <alloc_event>: Return a unique_ptr.
14250         (notif_event_xfree): Don't declare.
14251         (notif_event_up): New typedef.
14252         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14253         (notif_event_xfree, do_notif_event_xfree): Remove.
14254         (remote_notif_state_xfree): Update.
14255
14256 2019-03-06  Tom Tromey  <tom@tromey.com>
14257
14258         * infrun.c (displaced_step_clear_cleanup): Now a
14259         forward_scope_exit type.
14260         (displaced_step_prepare_throw): Update.
14261         (displaced_step_fixup): Update.
14262
14263 2019-03-06  Tom Tromey  <tom@tromey.com>
14264
14265         * inferior.h (class inferior): Update comment.
14266         * gdbthread.h (class thread_info): Update comment.
14267
14268 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14269             Tom Tromey  <tom@tromey.com>
14270
14271         * stabsread.h (struct stab_section_list): Remove.
14272         (coffstab_build_psymtabs): Update.
14273         * dbxread.c (symbuf_sections): Now a std::vector.
14274         (sect_idx): New global.
14275         (fill_symbuf): Update.
14276         (coffstab_build_psymtabs): Change type of stabsects parameter.
14277         Update.
14278         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14279         std::vector.
14280         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14281         (coff_locate_sections): Update.
14282         (coff_symfile_read): Remove cleanups.  Update.
14283         (init_stringtab): Add storage parameter.
14284         (free_stringtab, free_stringtab_cleanup): Remove.
14285         (init_lineno): Add storage parameter.
14286         (free_linetab, free_linetab_cleanup): Remove.
14287
14288 2019-03-06  Pedro Alves  <palves@redhat.com>
14289
14290         * linux-fork.c (fork_info::clobber_regs): Delete.
14291         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14292         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14293         comment.  Adjust.
14294         (scoped_switch_fork_info::scoped_switch_fork_info)
14295         (checkpoint_command, linux_fork_context): Adjust
14296         fork_save_infrun_state calls.
14297
14298 2019-03-06  Pedro Alves  <palves@redhat.com>
14299
14300         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14301         (inf_has_multiple_threads): Return 'bool' and rewrite using
14302         inferior_info::threads().
14303
14304 2019-03-06  Pedro Alves  <palves@redhat.com>
14305
14306         * linux-fork.c: Include <list>.
14307         (fork_list): Now a std::list instance.
14308         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14309         (forks_exist_p, find_last_fork): Adjust.
14310         (new_fork): Delete.
14311         (one_fork_p): New.
14312         (add_fork): Adjust.
14313         (free_fork): Delete, folded into fork_info::~fork_info().
14314         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14315         Adjust.
14316         (init_fork_list): Delete.
14317         (linux_fork_killall, linux_fork_mourn_inferior)
14318         (linux_fork_detach, info_checkpoints_command): Adjust.
14319         (_initialize_linux_fork): No longer call init_fork_list.
14320
14321 2019-03-06  Pedro Alves  <palves@redhat.com>
14322
14323         * linux-fork.c (new_fork): New, split out of ...
14324         (add_fork): ... this.  Return void.  Move "first fork" special
14325         case from here, to ...
14326         (checkpoint_command): ... here.
14327         * linux-linux.h (add_fork): Return void.
14328
14329 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14330
14331         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14332
14333 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14334             Chris January  <chris.january@arm.com>
14335             David Lecomber  <david.lecomber@arm.com>
14336
14337         * f-exp.y: New token, UNOP_INTRINSIC.
14338         (exp): New pattern using UNOP_INTRINSIC token.
14339         (f77_keywords): Add 'abs' keyword.
14340         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14341         (value_from_host_double): New function.
14342         (evaluate_subexp_f): Support UNOP_ABS.
14343
14344 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14345
14346         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14347         types.
14348
14349 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14350
14351         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14352         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14353         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14354
14355 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14356
14357         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14358
14359 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14360             Chris January  <chris.january@arm.com>
14361
14362         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14363         * f-exp.y: Define 'KIND' token.
14364         (exp): New pattern for KIND expressions.
14365         (ptype): Handle types with a kind extension.
14366         (direct_abs_decl): Extend to spot kind extensions.
14367         (f77_keywords): Add 'kind' to the list.
14368         (push_kind_type): New function.
14369         (convert_to_kind_type): New function.
14370         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14371         * parse.c (operator_length_standard): Likewise.
14372         * parser-defs.h (enum type_pieces): Add tp_kind.
14373         * std-operator.def: Add UNOP_KIND.
14374
14375 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14376
14377         * f-exp.y (f_parse): Set yydebug.
14378
14379 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14380
14381         * f-lang.c (evaluate_subexp_f): New function.
14382         (exp_descriptor_f): New global.
14383         (f_language_defn): Use exp_descriptor_f instead of
14384         exp_descriptor_standard.
14385
14386 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14387
14388         * f-exp.y (struct token): Add comments.
14389         (dot_ops): Remove uppercase versions and the end marker.
14390         (f77_keywords): Likewise.
14391         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14392         entries in the dot_ops array are case insensitive, and use
14393         strncasecmp to compare strings.  Also some whitespace cleanup in
14394         this area.  Similar for the f77_keywords array, except entries in
14395         this list might be case sensitive.
14396
14397 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14398
14399         * f-exp.y (struct f77_boolean_val): Add comments.
14400         (boolean_values): Remove uppercase versions, and end marker.
14401         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14402         and use strncasecmp to achieve case insensitivity.  Additionally,
14403         perform whitespace cleanup around this code.
14404
14405 2019-03-06  Tom Tromey  <tromey@adacore.com>
14406
14407         * remote-sim.c (gdbsim_target_open): Use result of
14408         gdb_argv::release.
14409
14410 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14411         Dirk Schubert  <dirk.schubert@arm.com>
14412         Chris January  <chris.january@arm.com>
14413
14414         * eval.c (evaluate_subexp_standard): Call Fortran argument
14415         wrapping logic.
14416         * f-lang.c (struct value): A value which can be passed into a
14417         Fortran function call.
14418         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14419         where appropriate.
14420         (struct type): Value ready for a Fortran function call.
14421         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14422         is needed.
14423         * f-lang.h (fortran_argument_convert): Declaration.
14424         (fortran_preserve_arg_pointer): Declaration.
14425         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14426
14427 2019-03-05  Tom Tromey  <tromey@adacore.com>
14428
14429         * python/py-prettyprint.c (print_string_repr): Remove #if.
14430         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14431
14432 2019-03-05  Tom Tromey  <tromey@adacore.com>
14433
14434         * target.c (the_dummy_target): Move later.  Change type to
14435         "dummy_target".
14436         (initialize_targets): Don't initialize the_dummy_target.
14437
14438 2019-03-05  Tom Tromey  <tromey@adacore.com>
14439
14440         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14441         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14442
14443 2019-03-05  Tom Tromey  <tromey@adacore.com>
14444
14445         * windows-nat.c (windows_nat_target::attach)
14446         (windows_nat_target::detach): Don't call gdb_flush.
14447         * valprint.c (generic_val_print, val_print, val_print_string):
14448         Don't call gdb_flush.
14449         * utils.c (defaulted_query): Don't call gdb_flush.
14450         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14451         * target.c (target_announce_detach): Don't call gdb_flush.
14452         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14453         * remote.c (extended_remote_target::attach): Don't call
14454         gdb_flush.
14455         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14456         * printcmd.c (do_examine): Don't call gdb_flush.
14457         (info_display_command): Don't call gdb_flush.
14458         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14459         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14460         * memattr.c (info_mem_command): Don't call gdb_flush.
14461         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14462         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14463         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14464         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14465         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14466         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14467         (gnu_nat_target::detach): Don't call gdb_flush.
14468         * f-valprint.c (f_val_print): Don't call gdb_flush.
14469         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14470         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14471         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14472         gdb_flush.
14473         * c-valprint.c (c_val_print): Don't call gdb_flush.
14474         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14475
14476 2019-03-05  Tom Tromey  <tromey@adacore.com>
14477
14478         * varobj.c (update_dynamic_varobj_children): Update.
14479         (install_default_visualizer): Use reset, not release.
14480         * value.c (set_internalvar): Update.
14481         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14482         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14483         ATTRIBUTE_UNUSED_RESULT.
14484
14485 2019-03-05  Tom Tromey  <tromey@adacore.com>
14486
14487         * remote.c (class scoped_remote_fd) <release>: Add
14488         ATTRIBUTE_UNUSED_RESULT.
14489
14490 2019-03-05  Tom Tromey  <tromey@adacore.com>
14491
14492         * macroexp.c (struct macro_buffer) <release>: Add
14493         ATTRIBUTE_UNUSED_RESULT.
14494
14495 2019-03-05  Tom Tromey  <tromey@adacore.com>
14496
14497         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14498         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14499         ATTRIBUTE_UNUSED_RESULT.
14500
14501 2019-03-05  Tom Tromey  <tromey@adacore.com>
14502
14503         * common/scoped_fd.h (class scoped_fd) <release>: Add
14504         ATTRIBUTE_UNUSED_RESULT.
14505
14506 2019-03-05  Tom Tromey  <tromey@adacore.com>
14507
14508         * parser-defs.h (struct parser_state) <release>: Add
14509         ATTRIBUTE_UNUSED_RESULT.
14510
14511 2019-03-05  Tom Tromey  <tromey@adacore.com>
14512
14513         * utils.h (class gdb_argv) <release>: Add
14514         ATTRIBUTE_UNUSED_RESULT.
14515         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14516
14517 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14518
14519         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14520         for-loop range, to avoid compiler warnings.
14521
14522         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14523         avoid compiler warnings about unused variables.
14524
14525         * NEWS: Mention end of support for native debugging on MS-Windows
14526         before XP.
14527
14528         PR gdb/24292
14529         * common/netstuff.c:
14530         * gdbserver/gdbreplay.c
14531         * gdbserver/remote-utils.c:
14532         * ser-tcp.c:
14533         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14534         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14535         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14536         'getaddrinfo' and 'freeaddrinfo' were not available before
14537         Windows XP, and mingw.org's MinGW headers by default define
14538         _WIN32_WINNT to 0x500.
14539
14540 2019-03-01  Gary Benson <gbenson@redhat.com>
14541
14542         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14543
14544 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14545             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14546
14547         PR gdb/8527
14548         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14549         set_sigint_trap, clear_sigint_trap.
14550
14551 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14552
14553         * target.c (target_detach): Clear the regcache and the
14554         frame cache.
14555
14556 2019-02-27  Pedro Alves  <palves@redhat.com>
14557
14558         * utils.c (set_screen_size): When we cap the height/width sizes,
14559         tweak the corresponding command variable to show "unlimited":
14560
14561 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14562             Pedro Alves  <palves@redhat.com>
14563
14564         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14565         before calling rl_set_screen_size.
14566
14567 2019-02-27  Tom Tromey  <tromey@adacore.com>
14568
14569         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14570         define.
14571         * python/py-value.c: Remove Python 2.4 workaround.
14572         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14573         workaround.
14574         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14575         Python 2.4 workaround.
14576         * python/python-internal.h: Remove Python 2.4 comment.
14577         (Py_ssize_t): Don't define.
14578         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14579         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14580         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14581         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14582         * python/python.c (do_start_initialization): Remove Python 2.4
14583         workaround.
14584         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14585         (print_children): Remove Python 2.4 workaround.
14586         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14587         workaround.
14588         (CHARBUFFERPROC_NAME): Remove.
14589         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14590         Python 2.4 workaround.
14591
14592 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14593
14594         * NEWS: Note minimum Python version.
14595
14596 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14597
14598         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14599         code from these functions.  Remove corresponding ifdefs.  Use
14600         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14601         Remove gotos and target of gotos.
14602         (infpy_search_memory): Likewise.
14603
14604 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14605
14606         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14607         (hppa_gdbarch_init): Don't register deleted functions with
14608         gdbarch.
14609
14610 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14611
14612         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14613         (h8300_unwind_sp): Delete.
14614         (h8300_dummy_id): Delete.
14615         (h8300_gdbarch_init): Don't register deleted functions with
14616         gdbarch.
14617
14618 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14619
14620         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14621         (ft32_unwind_pc): Delete.
14622         (ft32_unwind_sp): Delete.
14623         (ft32_gdbarch_init): Don't register deleted functions with
14624         gdbarch.
14625
14626 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14627
14628         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14629         (frv_unwind_pc): Delete.
14630         (frv_unwind_sp): Delete.
14631         (frv_gdbarch_init): Don't register deleted functions with
14632         gdbarch.
14633
14634 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14635
14636         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14637         (riscv_unwind_pc): Delete.
14638         (riscv_unwind_sp): Delete.
14639         (riscv_gdbarch_init): Don't register deleted functions with
14640         gdbarch.
14641
14642 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14643
14644         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14645         (csky_unwind_pc): Delete.
14646         (csky_unwind_sp): Delete.
14647         (csky_gdbarch_init): Don't register deleted functions with
14648         gdbarch.
14649
14650 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14651
14652         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14653         (cris_unwind_pc): Delete.
14654         (cris_unwind_sp): Delete.
14655         (cris_gdbarch_init): Don't register deleted functions with
14656         gdbarch.
14657
14658 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14659
14660         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14661         (bfin_unwind_pc): Delete.
14662         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14663
14664 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14665
14666         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14667         (arm_unwind_pc): Delete.
14668         (arm_unwind_sp): Delete.
14669         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14670
14671 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14672
14673         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14674         (arc_unwind_pc): Delete.
14675         (arc_unwind_sp): Delete.
14676         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14677
14678 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14679
14680         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14681         (alpha_unwind_pc): Delete.
14682         (alpha_gdbarch_init): Don't register deleted functions with
14683         gdbarch.
14684
14685 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14686
14687         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14688         (aarch64_unwind_pc): Delete.
14689         (aarch64_unwind_sp): Delete.
14690         (aarch64_gdbarch_init): Don't register deleted functions with
14691         gdbarch.
14692
14693 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14694
14695         * gdbtypes.c (type_align): Don't consider static members when
14696         computing structure alignment.
14697
14698 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14699
14700         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14701         return 0 for other types.
14702         * arch-utils.c (default_type_align): Always return 0.
14703         * gdbarch.h: Regenerate.
14704         * gdbarch.sh (type_align): Extend comment.
14705         * gdbtypes.c (type_align): Add additional comments, always call
14706         gdbarch_type_align before applying the default rules.
14707         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14708         generic code will then apply a suitable default.
14709         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14710         types, return 0 for other types.
14711
14712 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14713
14714         * NEWS: Create a new section for the next release branch.
14715         Rename the section of the current branch, now that it has
14716         been cut.
14717
14718 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14719
14720         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14721         * version.in: Bump version to 8.3.50.DATE-git.
14722
14723 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14724
14725         * aix-thread.c (ptid_cmp): Remove unused variable.
14726         (get_signaled_thread): Likewise.
14727         (store_regs_user_thread): Likewise.
14728         (store_regs_kernel_thread): Likewise.
14729         (fetch_regs_kernel_thread): Remove shadowed variable.
14730
14731 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14732
14733         * features/riscv/32bit-cpu.xml: Add register numbers.
14734         * features/riscv/32bit-fpu.c: Regenerate.
14735         * features/riscv/32bit-fpu.xml: Add register numbers.
14736         * features/riscv/64bit-cpu.xml: Add register numbers.
14737         * features/riscv/64bit-fpu.c: Regenerate.
14738         * features/riscv/64bit-fpu.xml: Add register numbers.
14739
14740 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14741
14742         * NEWS: Mention two argument form of gdb.Value constructor.
14743         * python/py-value.c (convert_buffer_and_type_to_value): New
14744         function.
14745         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14746         Add support for handling an optional second argument.  Call
14747         convert_buffer_and_type_to_value as appropriate.
14748         * python/python-internal.h (Py_buffer_deleter): New struct.
14749         (Py_buffer_up): New typedef.
14750
14751 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14752
14753         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14754         instead of releasing ownership.
14755
14756 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14757
14758         * dwarf2read.c (open_and_init_dwp_file): Call
14759         elf_numsections instead of bfd_count_sections to initialize
14760         dwp_file->num_sections.
14761
14762 2019-02-25  Tom Tromey  <tromey@adacore.com>
14763
14764         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14765
14766 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14767
14768         * gcore.in: Add '--readnever' option when invoking GDB.
14769
14770 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14771
14772         * MAINTAINERS: Update my email address.
14773
14774 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14775
14776         * build-id.c (build_id_to_debug_bfd_1): New function.
14777         (build_id_to_debug_bfd): Look for separate debug file in
14778         sysroot.
14779
14780 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14781
14782         * gdbarch.sh: Update the copyright year range that is placed into
14783         generated files.
14784
14785 2019-02-22  Keith Seitz  <keiths@redhat.com>
14786
14787         PR symtab/23853
14788         * linespec.c (create_sals_line_offset): Search for the default
14789         symtab's filename instead of its fullname.
14790
14791 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14792
14793         * NEWS: Update style defaults.
14794
14795 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14796
14797         * main.c (captured_main_1): Disable styling in batch mode.
14798
14799 2019-02-20  Tom Tromey  <tom@tromey.com>
14800
14801         * symtab.c (symtab_symbol_info): Fix typos.
14802
14803 2019-02-20  Tom Tromey  <tromey@adacore.com>
14804
14805         * findcmd.c (_initialize_mem_search): Use upper case for
14806         metasyntactic variables.
14807
14808 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14809
14810         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14811         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14812
14813 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14814
14815         * top.h (source_file_name): Change to std::string.
14816         * top.c (source_file_name): Likewise.
14817         (command_line_input): Adjust.
14818         * cli/cli-script.c (script_from_file): Adjust.
14819
14820 2019-02-19  Tom Tromey  <tromey@adacore.com>
14821
14822         * ravenscar-thread.c
14823         (ravenscar_thread_target::update_thread_list): Don't call
14824         ada_build_task_list.
14825         * ada-lang.h (ada_build_task_list): Don't declare.
14826         * ada-tasks.c (struct ada_tasks_inferior_data)
14827         <task_list_valid_p>: Now bool.
14828         (read_known_tasks, ada_task_list_changed)
14829         (ada_tasks_invalidate_inferior_data): Update.
14830         (read_known_tasks_array): Return bool.
14831         (read_known_tasks_list): Likewise.
14832         (read_known_tasks): Return void.
14833         (ada_build_task_list): Now static.
14834
14835 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14836
14837         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14838         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14839
14840 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14841
14842         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14843         variant for ada_tasks_pspace_data_handle and
14844         ada_tasks_inferior_data_handle.
14845         (ada_tasks_pspace_data_cleanup): New function.
14846         (ada_tasks_inferior_data_cleanup): New function.
14847
14848 2019-02-17  Tom Tromey  <tom@tromey.com>
14849
14850         * macrotab.h (macro_source_fullname): Return a std::string.
14851         * macrotab.c (macro_include, check_for_redefinition)
14852         (macro_undef, macro_lookup_definition, foreach_macro)
14853         (foreach_macro_in_scope): Update.
14854         (macro_source_fullname): Return a std::string.
14855         * macrocmd.c (show_pp_source_pos): Update.
14856
14857 2019-02-17  Tom Tromey  <tom@tromey.com>
14858
14859         * macrocmd.c (show_pp_source_pos): Style the file names.
14860
14861 2019-02-17  Tom Tromey  <tom@tromey.com>
14862
14863         PR tui/24197:
14864         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14865
14866 2019-02-17  Tom Tromey  <tom@tromey.com>
14867
14868         * ada-lang.c (user_select_syms): Use filtered printing.
14869         * utils.c (wrap_style): New global.
14870         (desired_style): Remove.
14871         (emit_style_escape): Add stream parameter.
14872         (set_output_style, reset_terminal_style, prompt_for_continue):
14873         Update.
14874         (flush_wrap_buffer): Only flush gdb_stdout.
14875         (wrap_here): Set wrap_style.
14876         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14877         treat escape sequences as a character.  Change when wrap buffer is
14878         flushed.
14879         (fputs_styled): Do not set the output style when the default is
14880         requested.
14881         * ui-style.h (struct ui_file_style) <is_default>: New method.
14882         * source.c (print_source_lines_base): Emit escape sequences in one
14883         piece.
14884
14885 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14886
14887         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14888         integers and enumeration types.
14889
14890 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14891
14892         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14893         instead of lookup_symbol_in_language
14894         (do_exact_match): New function.
14895         (ada_get_symbol_name_matcher): Return do_exact_match when
14896         doing a verbatim match.
14897
14898 2019-02-15  Tom Tromey  <tromey@adacore.com>
14899
14900         * ravenscar-thread.c (ravenscar_thread_target::resume)
14901         (ravenscar_thread_target::wait): Special case wildcard requests.
14902
14903 2019-02-15  Tom Tromey  <tromey@adacore.com>
14904
14905         * ravenscar-thread.c (base_ptid): Remove.
14906         (struct ravenscar_thread_target) <close>: New method.
14907         <m_base_ptid>: New member.
14908         <update_inferior_ptid, active_task, task_is_currently_active,
14909         runtime_initialized>: Declare methods.
14910         <ravenscar_thread_target>: Add constructor.
14911         (ravenscar_thread_target::task_is_currently_active)
14912         (ravenscar_thread_target::update_inferior_ptid)
14913         (ravenscar_runtime_initialized): Rename.  Now methods.
14914         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14915         (ravenscar_thread_target::update_thread_list): Update.
14916         (ravenscar_thread_target::active_task): Now method.
14917         (ravenscar_thread_target::store_registers)
14918         (ravenscar_thread_target::prepare_to_store)
14919         (ravenscar_thread_target::prepare_to_store)
14920         (ravenscar_thread_target::mourn_inferior): Update.
14921         (ravenscar_inferior_created): Use "new" to create target.
14922         (ravenscar_thread_target::get_ada_task_ptid): Update.
14923         (_initialize_ravenscar): Don't initialize base_ptid.
14924         (ravenscar_ops): Remove global.
14925
14926 2019-02-15  Tom Tromey  <tromey@adacore.com>
14927
14928         * target.h (push_target): Declare new overload.
14929         * target.c (push_target): New overload, taking an rvalue reference.
14930         * remote.c (remote_target::open_1): Use push_target overload.
14931         * corelow.c (core_target_open): Use push_target overload.
14932
14933 2019-02-15  Tom Tromey  <tromey@adacore.com>
14934
14935         * ravenscar-thread.c (is_ravenscar_task)
14936         (ravenscar_task_is_currently_active): Return bool.
14937         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
14938         (_initialize_ravenscar): Remove "(void)".
14939         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
14940         Return bool.
14941
14942 2019-02-15  Tom Tromey  <tromey@adacore.com>
14943
14944         * ravenscar-thread.c (ravenscar_runtime_initializer)
14945         (has_ravenscar_runtime, get_running_thread_id)
14946         (ravenscar_thread_target::resume): Fix indentation.
14947
14948 2019-02-15  Tom Tromey  <tromey@adacore.com>
14949
14950         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
14951         from ravenscar_arch_ops.
14952         (sparc_ravenscar_ops::fetch_registers)
14953         (sparc_ravenscar_ops::store_registers): Now methods.
14954         (sparc_ravenscar_prepare_to_store): Remove.
14955         (sparc_ravenscar_ops): Redefine.
14956         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
14957         methods and destructor.  Remove members.
14958         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
14959         (ravenscar_thread_target::store_registers)
14960         (ravenscar_thread_target::prepare_to_store): Update.
14961         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
14962         Remove.
14963         (struct ppc_ravenscar_powerpc_ops): Derive from
14964         ravenscar_arch_ops.
14965         (ppc_ravenscar_powerpc_ops::fetch_registers)
14966         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
14967         (ppc_ravenscar_powerpc_ops): Redefine.
14968         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
14969         (ppc_ravenscar_e500_ops::fetch_registers)
14970         (ppc_ravenscar_e500_ops::store_registers): Now methods.
14971         (ppc_ravenscar_e500_ops): Redefine.
14972         * aarch64-ravenscar-thread.c
14973         (aarch64_ravenscar_generic_prepare_to_store): Remove.
14974         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
14975         (aarch64_ravenscar_fetch_registers)
14976         (aarch64_ravenscar_store_registers): Now methods.
14977         (aarch64_ravenscar_ops): Redefine.
14978
14979 2019-02-15  Tom Tromey  <tromey@adacore.com>
14980
14981         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
14982         (ravenscar_thread_target::stopped_by_hw_breakpoint)
14983         (ravenscar_thread_target::stopped_by_watchpoint)
14984         (ravenscar_thread_target::stopped_data_address)
14985         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
14986
14987 2019-02-15  Tom Tromey  <tromey@adacore.com>
14988
14989         * ravenscar-thread.c: Fix some typos.
14990
14991 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14992             Tom Tromey  <tromey@adacore.com>
14993
14994         * ada-lang.c (ada_exception_sal): Change addr_string to a
14995         std::string.
14996         (create_ada_exception_catchpoint): Update.
14997
14998 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14999             Tom Tromey  <tromey@adacore.com>
15000
15001         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15002         (bp_location_ops): Remove.
15003         (base_breakpoint_allocate_location): Update.
15004         (free_bp_location): Update.
15005         * ada-lang.c (class ada_catchpoint_location)
15006         <ada_catchpoint_location>: Remove ops parameter.
15007         (ada_catchpoint_location_dtor): Remove.
15008         (ada_catchpoint_location_ops): Remove.
15009         (allocate_location_exception): Update.
15010         * breakpoint.h (struct bp_location_ops): Remove.
15011         (class bp_location) <bp_location>: Remove bp_location_ops
15012         parameter.
15013         <~bp_location>: Add destructor.
15014         <ops>: Remove.
15015
15016 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15017             Pedro Alves  <palves@redhat.com>
15018
15019         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15020         'PATH_MAX'.
15021
15022 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15023             Samuel Thibault  <samuel.thibault@gnu.org>
15024             Thomas Schwinge  <thomas@codesourcery.com>
15025
15026         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15027         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15028
15029 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15030
15031         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15032         (check_empty): Use "const char *".
15033
15034         * gnu-nat.c (gnu_nat_target::detach): Instead of
15035         'detach_inferior (pid)' call
15036         'detach_inferior (find_inferior_pid (pid))'.
15037
15038         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15039         'nat/fork-inferior.o'.
15040         * gnu-nat.c: #include "nat/fork-inferior.h".
15041
15042         * gnu-nat.c (gnu_nat_target::detach): Instead of
15043         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15044         * gnu-nat.h: #include "inf-child.h".
15045         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15046         'i386_gnu_nat_target::fetch_registers'.
15047         (gnu_store_registers): Rename/move to
15048         'i386_gnu_nat_target::store_registers'.
15049
15050         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15051         * gnu-nat.h (mach_thread_info): New function.
15052         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15053
15054         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15055
15056 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15057
15058         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15059
15060 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15061
15062         * windows-nat.c (windows_add_thread): Add new parameter
15063         "main_thread_p" with default value set to false.  Update
15064         function documentation as well as all callers.
15065         (windows_delete_thread): Likewise.
15066         (fake_create_process): Update call to windows_add_thread.
15067         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15068         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15069         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15070         call to windows_delete_thread.
15071
15072 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15073
15074         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15075
15076 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15077
15078         * symfile.c (find_separate_debug_file): Use canonical path of
15079         sysroot with child_path instead of gdb_sysroot if it is valid.
15080
15081 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15082
15083         * symfile.c (find_separate_debug_file): Use child_path to
15084         determine if an object file is under a sysroot.
15085
15086 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15087
15088         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15089         unittests/child-path-selftests.c.
15090         * common/pathstuff.c (child_path): New function.
15091         * common/pathstuff.h (child_path): New prototype.
15092         * unittests/child-path-selftests.c: New file.
15093
15094 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15095
15096         * symfile.c (find_separate_debug_file): Look for separate debug
15097         files in debug directories under the sysroot.
15098
15099 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15100
15101         * symtab.h (struct minimal_symbol data_p): New const method.
15102         (struct minimal_symbol text_p): Likewise.
15103         * symtab.c (output_source_filename): Use file name style
15104         to print file name.
15105         (print_symbol_info): Likewise.
15106         (print_msymbol_info): Use address style to print addresses.
15107         Use function name style to print executable text symbols.
15108         (expand_symtab_containing_pc): Use data_p.
15109         (find_pc_sect_compunit_symtab): Likewise.
15110
15111 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15112
15113         * breakpoint.c (describe_other_breakpoints): Use address style
15114         to print addresses.
15115         (say_where): Likewise.
15116
15117 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15118
15119         * ada-typeprint.c (print_func_type): Print function name
15120         style to print function name.
15121         * c-typeprint.c (c_print_type_1): Likewise.
15122
15123 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15124
15125         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15126         for execve.
15127
15128 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15129
15130         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15131         type_stack.
15132
15133 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15134
15135         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15136         TYPE_CODE_REF types.
15137
15138 2019-02-08  Jim Wilson  <jimw@sifive.com>
15139
15140         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15141         (riscv_linux_fregset): New.
15142         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15143
15144 2019-02-07  Tom Tromey  <tom@tromey.com>
15145
15146         * thread.c (thread_cancel_execution_command): Update.
15147         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15148         methods.
15149         (struct thread_fsm_ops): Remove.
15150         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15151         (thread_fsm_should_stop, thread_fsm_return_value)
15152         (thread_fsm_set_finished, thread_fsm_finished_p)
15153         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15154         Don't declare.
15155         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15156         * infrun.c (clear_proceed_status_thread)
15157         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15158         (print_stop_event): Update.
15159         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15160         Add constructor.
15161         (step_command_fsm_ops): Remove.
15162         (new_step_command_fsm): Remove.
15163         (step_1): Update.
15164         (step_command_fsm::should_stop): Rename from
15165         step_command_fsm_should_stop.
15166         (step_command_fsm::clean_up): Rename from
15167         step_command_fsm_clean_up.
15168         (step_command_fsm::do_async_reply_reason): Rename from
15169         step_command_fsm_async_reply_reason.
15170         (struct until_next_fsm): Inherit from thread_fsm.  Add
15171         constructor.
15172         (until_next_fsm_ops): Remove.
15173         (new_until_next_fsm): Remove.
15174         (until_next_fsm::should_stop): Rename from
15175         until_next_fsm_should_stop.
15176         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15177         (until_next_fsm::do_async_reply_reason): Rename from
15178         until_next_fsm_async_reply_reason.
15179         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15180         constructor.  Change type of breakpoint.
15181         (finish_command_fsm_ops): Remove.
15182         (new_finish_command_fsm): Remove.
15183         (finish_command_fsm::should_stop): Rename from
15184         finish_command_fsm_should_stop.
15185         (finish_command_fsm::clean_up): Rename from
15186         finish_command_fsm_clean_up.
15187         (finish_command_fsm::return_value): Rename from
15188         finish_command_fsm_return_value.
15189         (finish_command_fsm::do_async_reply_reason): Rename from
15190         finish_command_fsm_async_reply_reason.
15191         (finish_command): Update.
15192         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15193         Add constructor.
15194         (call_thread_fsm_ops): Remove.
15195         (call_thread_fsm::call_thread_fsm): Rename from
15196         new_call_thread_fsm.
15197         (call_thread_fsm::should_stop): Rename from
15198         call_thread_fsm_should_stop.
15199         (call_thread_fsm::should_notify_stop): Rename from
15200         call_thread_fsm_should_notify_stop.
15201         (run_inferior_call, call_function_by_hand_dummy): Update.
15202         * cli/cli-interp.c (should_print_stop_to_console): Update.
15203         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15204         Add constructor.  Change type of location_breakpoint,
15205         caller_breakpoint.
15206         (until_break_fsm_ops): Remove.
15207         (new_until_break_fsm): Remove.
15208         (until_break_fsm::should_stop): Rename from
15209         until_break_fsm_should_stop.
15210         (until_break_fsm::clean_up): Rename from
15211         until_break_fsm_clean_up.
15212         (until_break_fsm::do_async_reply_reason): Rename from
15213         until_break_fsm_async_reply_reason.
15214         (until_break_command): Update.
15215         * thread-fsm.c: Remove.
15216         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15217
15218 2019-02-07  Tom Tromey  <tom@tromey.com>
15219
15220         * yy-remap.h: Add include guard.
15221         * xtensa-tdep.h: Add include guard.
15222         * xcoffread.h: Rename include guard.
15223         * varobj-iter.h: Add include guard.
15224         * tui/tui.h: Rename include guard.
15225         * tui/tui-winsource.h: Rename include guard.
15226         * tui/tui-wingeneral.h: Rename include guard.
15227         * tui/tui-windata.h: Rename include guard.
15228         * tui/tui-win.h: Rename include guard.
15229         * tui/tui-stack.h: Rename include guard.
15230         * tui/tui-source.h: Rename include guard.
15231         * tui/tui-regs.h: Rename include guard.
15232         * tui/tui-out.h: Rename include guard.
15233         * tui/tui-layout.h: Rename include guard.
15234         * tui/tui-io.h: Rename include guard.
15235         * tui/tui-hooks.h: Rename include guard.
15236         * tui/tui-file.h: Rename include guard.
15237         * tui/tui-disasm.h: Rename include guard.
15238         * tui/tui-data.h: Rename include guard.
15239         * tui/tui-command.h: Rename include guard.
15240         * tic6x-tdep.h: Add include guard.
15241         * target/waitstatus.h: Rename include guard.
15242         * target/wait.h: Rename include guard.
15243         * target/target.h: Rename include guard.
15244         * target/resume.h: Rename include guard.
15245         * target-float.h: Rename include guard.
15246         * stabsread.h: Add include guard.
15247         * rs6000-tdep.h: Add include guard.
15248         * riscv-fbsd-tdep.h: Add include guard.
15249         * regformats/regdef.h: Rename include guard.
15250         * record.h: Rename include guard.
15251         * python/python.h: Rename include guard.
15252         * python/python-internal.h: Rename include guard.
15253         * python/py-stopevent.h: Rename include guard.
15254         * python/py-ref.h: Rename include guard.
15255         * python/py-record.h: Rename include guard.
15256         * python/py-record-full.h: Rename include guard.
15257         * python/py-record-btrace.h: Rename include guard.
15258         * python/py-instruction.h: Rename include guard.
15259         * python/py-events.h: Rename include guard.
15260         * python/py-event.h: Rename include guard.
15261         * procfs.h: Add include guard.
15262         * proc-utils.h: Add include guard.
15263         * p-lang.h: Add include guard.
15264         * or1k-tdep.h: Rename include guard.
15265         * observable.h: Rename include guard.
15266         * nto-tdep.h: Rename include guard.
15267         * nat/x86-linux.h: Rename include guard.
15268         * nat/x86-linux-dregs.h: Rename include guard.
15269         * nat/x86-gcc-cpuid.h: Add include guard.
15270         * nat/x86-dregs.h: Rename include guard.
15271         * nat/x86-cpuid.h: Rename include guard.
15272         * nat/ppc-linux.h: Rename include guard.
15273         * nat/mips-linux-watch.h: Rename include guard.
15274         * nat/linux-waitpid.h: Rename include guard.
15275         * nat/linux-ptrace.h: Rename include guard.
15276         * nat/linux-procfs.h: Rename include guard.
15277         * nat/linux-osdata.h: Rename include guard.
15278         * nat/linux-nat.h: Rename include guard.
15279         * nat/linux-namespaces.h: Rename include guard.
15280         * nat/linux-btrace.h: Rename include guard.
15281         * nat/glibc_thread_db.h: Rename include guard.
15282         * nat/gdb_thread_db.h: Rename include guard.
15283         * nat/gdb_ptrace.h: Rename include guard.
15284         * nat/fork-inferior.h: Rename include guard.
15285         * nat/amd64-linux-siginfo.h: Rename include guard.
15286         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15287         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15288         * nat/aarch64-linux.h: Rename include guard.
15289         * nat/aarch64-linux-hw-point.h: Rename include guard.
15290         * mn10300-tdep.h: Add include guard.
15291         * mips-linux-tdep.h: Add include guard.
15292         * mi/mi-parse.h: Rename include guard.
15293         * mi/mi-out.h: Rename include guard.
15294         * mi/mi-main.h: Rename include guard.
15295         * mi/mi-interp.h: Rename include guard.
15296         * mi/mi-getopt.h: Rename include guard.
15297         * mi/mi-console.h: Rename include guard.
15298         * mi/mi-common.h: Rename include guard.
15299         * mi/mi-cmds.h: Rename include guard.
15300         * mi/mi-cmd-break.h: Rename include guard.
15301         * m2-lang.h: Add include guard.
15302         * location.h: Rename include guard.
15303         * linux-record.h: Rename include guard.
15304         * linux-nat.h: Add include guard.
15305         * linux-fork.h: Add include guard.
15306         * i386-darwin-tdep.h: Rename include guard.
15307         * hppa-linux-offsets.h: Add include guard.
15308         * guile/guile.h: Rename include guard.
15309         * guile/guile-internal.h: Rename include guard.
15310         * gnu-nat.h: Rename include guard.
15311         * gdb-stabs.h: Rename include guard.
15312         * frv-tdep.h: Add include guard.
15313         * f-lang.h: Add include guard.
15314         * event-loop.h: Add include guard.
15315         * darwin-nat.h: Rename include guard.
15316         * cp-abi.h: Rename include guard.
15317         * config/sparc/nm-sol2.h: Rename include guard.
15318         * config/nm-nto.h: Rename include guard.
15319         * config/nm-linux.h: Add include guard.
15320         * config/i386/nm-i386gnu.h: Rename include guard.
15321         * config/djgpp/nl_types.h: Rename include guard.
15322         * config/djgpp/langinfo.h: Rename include guard.
15323         * compile/gcc-cp-plugin.h: Add include guard.
15324         * compile/gcc-c-plugin.h: Add include guard.
15325         * compile/compile.h: Rename include guard.
15326         * compile/compile-object-run.h: Rename include guard.
15327         * compile/compile-object-load.h: Rename include guard.
15328         * compile/compile-internal.h: Rename include guard.
15329         * compile/compile-cplus.h: Rename include guard.
15330         * compile/compile-c.h: Rename include guard.
15331         * common/xml-utils.h: Rename include guard.
15332         * common/x86-xstate.h: Rename include guard.
15333         * common/version.h: Rename include guard.
15334         * common/vec.h: Rename include guard.
15335         * common/tdesc.h: Rename include guard.
15336         * common/selftest.h: Rename include guard.
15337         * common/scoped_restore.h: Rename include guard.
15338         * common/scoped_mmap.h: Rename include guard.
15339         * common/scoped_fd.h: Rename include guard.
15340         * common/safe-iterator.h: Rename include guard.
15341         * common/run-time-clock.h: Rename include guard.
15342         * common/refcounted-object.h: Rename include guard.
15343         * common/queue.h: Rename include guard.
15344         * common/ptid.h: Rename include guard.
15345         * common/print-utils.h: Rename include guard.
15346         * common/preprocessor.h: Rename include guard.
15347         * common/pathstuff.h: Rename include guard.
15348         * common/observable.h: Rename include guard.
15349         * common/netstuff.h: Rename include guard.
15350         * common/job-control.h: Rename include guard.
15351         * common/host-defs.h: Rename include guard.
15352         * common/gdb_wait.h: Rename include guard.
15353         * common/gdb_vecs.h: Rename include guard.
15354         * common/gdb_unlinker.h: Rename include guard.
15355         * common/gdb_unique_ptr.h: Rename include guard.
15356         * common/gdb_tilde_expand.h: Rename include guard.
15357         * common/gdb_sys_time.h: Rename include guard.
15358         * common/gdb_string_view.h: Rename include guard.
15359         * common/gdb_splay_tree.h: Rename include guard.
15360         * common/gdb_setjmp.h: Rename include guard.
15361         * common/gdb_ref_ptr.h: Rename include guard.
15362         * common/gdb_optional.h: Rename include guard.
15363         * common/gdb_locale.h: Rename include guard.
15364         * common/gdb_assert.h: Rename include guard.
15365         * common/filtered-iterator.h: Rename include guard.
15366         * common/filestuff.h: Rename include guard.
15367         * common/fileio.h: Rename include guard.
15368         * common/environ.h: Rename include guard.
15369         * common/common-utils.h: Rename include guard.
15370         * common/common-types.h: Rename include guard.
15371         * common/common-regcache.h: Rename include guard.
15372         * common/common-inferior.h: Rename include guard.
15373         * common/common-gdbthread.h: Rename include guard.
15374         * common/common-exceptions.h: Rename include guard.
15375         * common/common-defs.h: Rename include guard.
15376         * common/common-debug.h: Rename include guard.
15377         * common/cleanups.h: Rename include guard.
15378         * common/buffer.h: Rename include guard.
15379         * common/btrace-common.h: Rename include guard.
15380         * common/break-common.h: Rename include guard.
15381         * cli/cli-utils.h: Rename include guard.
15382         * cli/cli-style.h: Rename include guard.
15383         * cli/cli-setshow.h: Rename include guard.
15384         * cli/cli-script.h: Rename include guard.
15385         * cli/cli-interp.h: Rename include guard.
15386         * cli/cli-decode.h: Rename include guard.
15387         * cli/cli-cmds.h: Rename include guard.
15388         * charset-list.h: Add include guard.
15389         * buildsym-legacy.h: Rename include guard.
15390         * bfin-tdep.h: Add include guard.
15391         * ax.h: Rename include guard.
15392         * arm-linux-tdep.h: Add include guard.
15393         * arm-fbsd-tdep.h: Add include guard.
15394         * arch/xtensa.h: Rename include guard.
15395         * arch/tic6x.h: Add include guard.
15396         * arch/i386.h: Add include guard.
15397         * arch/arm.h: Rename include guard.
15398         * arch/arm-linux.h: Rename include guard.
15399         * arch/arm-get-next-pcs.h: Rename include guard.
15400         * arch/amd64.h: Add include guard.
15401         * arch/aarch64-insn.h: Rename include guard.
15402         * arch-utils.h: Rename include guard.
15403         * annotate.h: Add include guard.
15404         * amd64-darwin-tdep.h: Rename include guard.
15405         * aarch64-linux-tdep.h: Add include guard.
15406         * aarch64-fbsd-tdep.h: Add include guard.
15407         * aarch32-linux-nat.h: Add include guard.
15408
15409 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15410
15411         * macrotab.c (macro_define_internal): New function that
15412         factorizes macro_define_object_internal and macro_define_function
15413         code.
15414         (macro_define_object_internal): Use macro_define_internal.
15415         (macro_define_function): Likewise.
15416
15417 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15418
15419         * macrocmd.c (extract_identifier): Return
15420         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15421         callers.
15422
15423 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15424
15425         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15426
15427 2019-02-05  Tom Tromey  <tom@tromey.com>
15428
15429         * target.c (target_stack::unpush): Move assertion earlier.
15430
15431 2019-01-30  Tom Tromey  <tom@tromey.com>
15432
15433         PR python/23615:
15434         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15435         (gdbpy_parse_and_eval): Likewise.
15436         * python/python-internal.h (gdbpy_allow_threads): New class.
15437
15438 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15439
15440         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15441         (aarch64_fbsd_fpregmap): Move earlier.
15442         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15443         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15444         instead of individual calls to trad_frame_set_reg_addr.
15445         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15446         earlier.
15447         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15448         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15449         instead of individual calls to trad_frame_set_reg_addr.
15450
15451 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15452
15453         * CONTRIBUTE: Replace contribution list with wiki link.
15454
15455 2019-01-25  Tom Tromey  <tom@tromey.com>
15456
15457         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15458
15459 2019-01-25  Tom Tromey  <tom@tromey.com>
15460
15461         * xtensa-linux-nat.c: Fix common/ includes.
15462         * xml-support.h: Fix common/ includes.
15463         * xml-support.c: Fix common/ includes.
15464         * x86-linux-nat.c: Fix common/ includes.
15465         * windows-nat.c: Fix common/ includes.
15466         * varobj.h: Fix common/ includes.
15467         * varobj.c: Fix common/ includes.
15468         * value.c: Fix common/ includes.
15469         * valops.c: Fix common/ includes.
15470         * utils.c: Fix common/ includes.
15471         * unittests/xml-utils-selftests.c: Fix common/ includes.
15472         * unittests/utils-selftests.c: Fix common/ includes.
15473         * unittests/unpack-selftests.c: Fix common/ includes.
15474         * unittests/tracepoint-selftests.c: Fix common/ includes.
15475         * unittests/style-selftests.c: Fix common/ includes.
15476         * unittests/string_view-selftests.c: Fix common/ includes.
15477         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15478         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15479         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15480         * unittests/rsp-low-selftests.c: Fix common/ includes.
15481         * unittests/parse-connection-spec-selftests.c: Fix common/
15482         includes.
15483         * unittests/optional-selftests.c: Fix common/ includes.
15484         * unittests/offset-type-selftests.c: Fix common/ includes.
15485         * unittests/observable-selftests.c: Fix common/ includes.
15486         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15487         * unittests/memrange-selftests.c: Fix common/ includes.
15488         * unittests/memory-map-selftests.c: Fix common/ includes.
15489         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15490         * unittests/function-view-selftests.c: Fix common/ includes.
15491         * unittests/environ-selftests.c: Fix common/ includes.
15492         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15493         * unittests/common-utils-selftests.c: Fix common/ includes.
15494         * unittests/cli-utils-selftests.c: Fix common/ includes.
15495         * unittests/array-view-selftests.c: Fix common/ includes.
15496         * ui-file.c: Fix common/ includes.
15497         * tui/tui-io.c: Fix common/ includes.
15498         * tracepoint.h: Fix common/ includes.
15499         * tracepoint.c: Fix common/ includes.
15500         * tracefile-tfile.c: Fix common/ includes.
15501         * top.h: Fix common/ includes.
15502         * top.c: Fix common/ includes.
15503         * thread.c: Fix common/ includes.
15504         * target/waitstatus.h: Fix common/ includes.
15505         * target/waitstatus.c: Fix common/ includes.
15506         * target.h: Fix common/ includes.
15507         * target.c: Fix common/ includes.
15508         * target-memory.c: Fix common/ includes.
15509         * target-descriptions.c: Fix common/ includes.
15510         * symtab.h: Fix common/ includes.
15511         * symfile.c: Fix common/ includes.
15512         * stap-probe.c: Fix common/ includes.
15513         * spu-linux-nat.c: Fix common/ includes.
15514         * sparc-nat.c: Fix common/ includes.
15515         * source.c: Fix common/ includes.
15516         * solib.c: Fix common/ includes.
15517         * solib-target.c: Fix common/ includes.
15518         * ser-unix.c: Fix common/ includes.
15519         * ser-tcp.c: Fix common/ includes.
15520         * ser-pipe.c: Fix common/ includes.
15521         * ser-base.c: Fix common/ includes.
15522         * selftest-arch.c: Fix common/ includes.
15523         * s12z-tdep.c: Fix common/ includes.
15524         * rust-exp.y: Fix common/ includes.
15525         * rs6000-aix-tdep.c: Fix common/ includes.
15526         * riscv-tdep.c: Fix common/ includes.
15527         * remote.c: Fix common/ includes.
15528         * remote-notif.h: Fix common/ includes.
15529         * remote-fileio.h: Fix common/ includes.
15530         * remote-fileio.c: Fix common/ includes.
15531         * regcache.h: Fix common/ includes.
15532         * regcache.c: Fix common/ includes.
15533         * record-btrace.c: Fix common/ includes.
15534         * python/python.c: Fix common/ includes.
15535         * python/py-type.c: Fix common/ includes.
15536         * python/py-inferior.c: Fix common/ includes.
15537         * progspace.h: Fix common/ includes.
15538         * producer.c: Fix common/ includes.
15539         * procfs.c: Fix common/ includes.
15540         * proc-api.c: Fix common/ includes.
15541         * printcmd.c: Fix common/ includes.
15542         * ppc-linux-nat.c: Fix common/ includes.
15543         * parser-defs.h: Fix common/ includes.
15544         * osdata.c: Fix common/ includes.
15545         * obsd-nat.c: Fix common/ includes.
15546         * nat/x86-linux.c: Fix common/ includes.
15547         * nat/x86-linux-dregs.c: Fix common/ includes.
15548         * nat/x86-dregs.h: Fix common/ includes.
15549         * nat/x86-dregs.c: Fix common/ includes.
15550         * nat/ppc-linux.c: Fix common/ includes.
15551         * nat/mips-linux-watch.h: Fix common/ includes.
15552         * nat/mips-linux-watch.c: Fix common/ includes.
15553         * nat/linux-waitpid.c: Fix common/ includes.
15554         * nat/linux-ptrace.h: Fix common/ includes.
15555         * nat/linux-ptrace.c: Fix common/ includes.
15556         * nat/linux-procfs.c: Fix common/ includes.
15557         * nat/linux-personality.c: Fix common/ includes.
15558         * nat/linux-osdata.c: Fix common/ includes.
15559         * nat/linux-namespaces.c: Fix common/ includes.
15560         * nat/linux-btrace.h: Fix common/ includes.
15561         * nat/linux-btrace.c: Fix common/ includes.
15562         * nat/fork-inferior.c: Fix common/ includes.
15563         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15564         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15565         * nat/aarch64-linux.c: Fix common/ includes.
15566         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15567         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15568         * namespace.h: Fix common/ includes.
15569         * mips-linux-tdep.c: Fix common/ includes.
15570         * minsyms.c: Fix common/ includes.
15571         * mi/mi-parse.h: Fix common/ includes.
15572         * mi/mi-main.c: Fix common/ includes.
15573         * mi/mi-cmd-env.c: Fix common/ includes.
15574         * memrange.h: Fix common/ includes.
15575         * memattr.c: Fix common/ includes.
15576         * maint.h: Fix common/ includes.
15577         * maint.c: Fix common/ includes.
15578         * main.c: Fix common/ includes.
15579         * machoread.c: Fix common/ includes.
15580         * location.c: Fix common/ includes.
15581         * linux-thread-db.c: Fix common/ includes.
15582         * linux-nat.c: Fix common/ includes.
15583         * linux-fork.c: Fix common/ includes.
15584         * inline-frame.c: Fix common/ includes.
15585         * infrun.c: Fix common/ includes.
15586         * inflow.c: Fix common/ includes.
15587         * inferior.h: Fix common/ includes.
15588         * inferior.c: Fix common/ includes.
15589         * infcmd.c: Fix common/ includes.
15590         * inf-ptrace.c: Fix common/ includes.
15591         * inf-child.c: Fix common/ includes.
15592         * ia64-linux-nat.c: Fix common/ includes.
15593         * i387-tdep.c: Fix common/ includes.
15594         * i386-tdep.c: Fix common/ includes.
15595         * i386-linux-tdep.c: Fix common/ includes.
15596         * i386-linux-nat.c: Fix common/ includes.
15597         * i386-go32-tdep.c: Fix common/ includes.
15598         * i386-fbsd-tdep.c: Fix common/ includes.
15599         * i386-fbsd-nat.c: Fix common/ includes.
15600         * guile/scm-type.c: Fix common/ includes.
15601         * guile/guile.c: Fix common/ includes.
15602         * go32-nat.c: Fix common/ includes.
15603         * gnu-nat.c: Fix common/ includes.
15604         * gdbthread.h: Fix common/ includes.
15605         * gdbarch-selftests.c: Fix common/ includes.
15606         * gdb_usleep.c: Fix common/ includes.
15607         * gdb_select.h: Fix common/ includes.
15608         * gdb_bfd.c: Fix common/ includes.
15609         * gcore.c: Fix common/ includes.
15610         * fork-child.c: Fix common/ includes.
15611         * findvar.c: Fix common/ includes.
15612         * fbsd-nat.c: Fix common/ includes.
15613         * event-top.c: Fix common/ includes.
15614         * event-loop.c: Fix common/ includes.
15615         * dwarf2read.c: Fix common/ includes.
15616         * dwarf2loc.c: Fix common/ includes.
15617         * dwarf2-frame.c: Fix common/ includes.
15618         * dwarf-index-cache.c: Fix common/ includes.
15619         * dtrace-probe.c: Fix common/ includes.
15620         * disasm-selftests.c: Fix common/ includes.
15621         * defs.h: Fix common/ includes.
15622         * csky-tdep.c: Fix common/ includes.
15623         * cp-valprint.c: Fix common/ includes.
15624         * cp-support.h: Fix common/ includes.
15625         * cp-support.c: Fix common/ includes.
15626         * corelow.c: Fix common/ includes.
15627         * completer.h: Fix common/ includes.
15628         * completer.c: Fix common/ includes.
15629         * compile/compile.c: Fix common/ includes.
15630         * compile/compile-loc2c.c: Fix common/ includes.
15631         * compile/compile-cplus-types.c: Fix common/ includes.
15632         * compile/compile-cplus-symbols.c: Fix common/ includes.
15633         * command.h: Fix common/ includes.
15634         * cli/cli-dump.c: Fix common/ includes.
15635         * cli/cli-cmds.c: Fix common/ includes.
15636         * charset.c: Fix common/ includes.
15637         * build-id.c: Fix common/ includes.
15638         * btrace.h: Fix common/ includes.
15639         * btrace.c: Fix common/ includes.
15640         * breakpoint.h: Fix common/ includes.
15641         * breakpoint.c: Fix common/ includes.
15642         * ax.h:
15643         (enum agent_op): Fix common/ includes.
15644         * ax-general.c (struct aop_map): Fix common/ includes.
15645         * ax-gdb.c: Fix common/ includes.
15646         * auxv.c: Fix common/ includes.
15647         * auto-load.c: Fix common/ includes.
15648         * arm-tdep.c: Fix common/ includes.
15649         * arch/riscv.c: Fix common/ includes.
15650         * arch/ppc-linux-common.c: Fix common/ includes.
15651         * arch/i386.c: Fix common/ includes.
15652         * arch/arm.c: Fix common/ includes.
15653         * arch/arm-linux.c: Fix common/ includes.
15654         * arch/arm-get-next-pcs.c: Fix common/ includes.
15655         * arch/amd64.c: Fix common/ includes.
15656         * arch/aarch64.c: Fix common/ includes.
15657         * arch/aarch64-insn.c: Fix common/ includes.
15658         * arch-utils.c: Fix common/ includes.
15659         * amd64-windows-tdep.c: Fix common/ includes.
15660         * amd64-tdep.c: Fix common/ includes.
15661         * amd64-sol2-tdep.c: Fix common/ includes.
15662         * amd64-obsd-tdep.c: Fix common/ includes.
15663         * amd64-nbsd-tdep.c: Fix common/ includes.
15664         * amd64-linux-tdep.c: Fix common/ includes.
15665         * amd64-linux-nat.c: Fix common/ includes.
15666         * amd64-fbsd-tdep.c: Fix common/ includes.
15667         * amd64-fbsd-nat.c: Fix common/ includes.
15668         * amd64-dicos-tdep.c: Fix common/ includes.
15669         * amd64-darwin-tdep.c: Fix common/ includes.
15670         * agent.c: Fix common/ includes.
15671         * ada-lang.h: Fix common/ includes.
15672         * ada-lang.c: Fix common/ includes.
15673         * aarch64-tdep.c: Fix common/ includes.
15674
15675 2019-01-25  Tom Tromey  <tom@tromey.com>
15676
15677         * common/create-version.sh: Use common/version.h.
15678
15679 2019-01-24  Pedro Alves  <palves@redhat.com>
15680
15681         * infrun.c (signal_stop, signal_print, signal_program)
15682         (signal_catch, signal_pass): Now arrays instead of pointers.
15683         (update_signals_program_target, do_target_resume)
15684         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15685         * linux-nat.c (linux_nat_target::pass_signals)
15686         (linux_nat_target::create_inferior, linux_nat_target::attach):
15687         Adjust.
15688         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15689         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15690         * procfs.c (procfs_target::pass_signals): Adjust.
15691         * record-full.c (record_full_target::resume): Adjust.
15692         * remote.c (remote_target::pass_signals)
15693         (remote_target::program_signals): Adjust.
15694         * target-debug.h (target_debug_print_signals): Now takes a
15695         gdb::array_view as parameter.  Adjust.
15696         * target.h (target_ops) <pass_signals, program_signals>: Replace
15697         pointer and length parameters with gdb::array_view.
15698         (target_pass_signals, target_program_signals): Likewise.
15699         * target-delegates.c: Regenerate.
15700
15701 2019-01-24  Pedro Alves  <palves@redhat.com>
15702
15703         * common/forward-scope-exit.h
15704         (forward_scope_exit::forward_scope_exit): Pass arguments to
15705         m_bind_function directly, instead of creating a std::bind and
15706         copying that.
15707
15708 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15709
15710         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15711         for static members.
15712         (pass_in_v_vfp_candidate): Likewise.
15713
15714 2019-01-23  Tom Tromey  <tom@tromey.com>
15715             Pedro Alves  <palves@redhat.com>
15716
15717         * regcache.c (class regcache_invalidator): Remove.
15718         (regcache::raw_write): Use make_scope_exit.
15719
15720 2019-01-23  Tom Tromey  <tom@tromey.com>
15721
15722         * ui-out.h (class ui_out_emit_type): Update comment.
15723
15724 2019-01-23  Tom Tromey  <tom@tromey.com>
15725
15726         * infrun.c (fetch_inferior_event): Update comment.
15727
15728 2019-01-23  Tom Tromey  <tom@tromey.com>
15729             Pedro Alves  <palves@redhat.com>
15730
15731         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15732         parameter.
15733         (fetch_inferior_event): Use SCOPE_EXIT.
15734
15735
15736 2019-01-23  Tom Tromey  <tom@tromey.com>
15737             Pedro Alves  <palves@redhat.com>
15738
15739         * infrun.c (disable_thread_events): Delete.
15740         (stop_all_threads): Use SCOPE_EXIT.
15741
15742 2019-01-23  Tom Tromey  <tom@tromey.com>
15743             Pedro Alves  <palves@redhat.com>
15744
15745         * symfile.c: Include forward-scope-exit.h.
15746         (clear_symtab_users_cleanup): Replace forward declaration with
15747         a FORWARD_SCOPE_EXIT.
15748         (syms_from_objfile_1): Use the forward_scope_exit and
15749         gdb::optional instead of cleanup_function.
15750         (reread_symbols): Use the forward_scope_exit instead of
15751         cleanup_function.
15752         (clear_symtab_users_cleanup): Remove function.
15753
15754 2019-01-23  Tom Tromey  <tom@tromey.com>
15755             Pedro Alves  <palves@redhat.com>
15756
15757         * linux-nat.c: Include scope-exit.h.
15758         (cleanup_target_stop): Remove.
15759         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15760         SCOPE_EXIT.
15761
15762 2019-01-23  Tom Tromey  <tom@tromey.com>
15763             Pedro Alves  <palves@redhat.com>
15764
15765         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15766         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15767
15768 2019-01-23  Tom Tromey  <tom@tromey.com>
15769             Andrew Burgess  <andrew.burgess@embecosm.com>
15770             Pedro Alves  <palves@redhat.com>
15771
15772         * infrun.c (fetch_inferior_event): Use scope_exit.
15773         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15774         * top.c (execute_command): Use scope_exit.
15775         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15776         * utils.c (do_bpstat_clear_actions_cleanup)
15777         (make_bpstat_clear_actions_cleanup): Remove.
15778
15779 2019-01-23  Tom Tromey  <tom@tromey.com>
15780             Pedro Alves  <palves@redhat.com>
15781
15782         * infrun.c: Include "common/scope-exit.h"
15783         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15784         (wait_for_inferior): Use SCOPE_EXIT.
15785         (fetch_inferior_event): Use scope_exit.
15786
15787 2019-01-23  Tom Tromey  <tom@tromey.com>
15788             Pedro Alves  <palves@redhat.com>
15789
15790         * breakpoint.c (create_breakpoint): Remove cleanup.
15791
15792 2019-01-23  Tom Tromey  <tom@tromey.com>
15793             Andrew Burgess  <andrew.burgess@embecosm.com>
15794             Pedro Alves  <palves@redhat.com>
15795
15796 2019-01-23  Pedro Alves  <palves@redhat.com>
15797
15798         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15799
15800 2019-01-23  Pedro Alves  <palves@redhat.com>
15801             Andrew Burgess  <andrew.burgess@embecosm.com>
15802
15803         * gdbthread.h: Include "common/forward-scope-exit.h".
15804         (scoped_finish_thread_state): Redefine custom class in terms of
15805         forward_scope_exit.
15806
15807 2019-01-23  Pedro Alves  <palves@redhat.com>
15808             Andrew Burgess  <andrew.burgess@embecosm.com>
15809
15810         * common/forward-scope-exit.h: New file.
15811
15812 2019-01-23  Pedro Alves  <palves@redhat.com>
15813             Andrew Burgess  <andrew.burgess@embecosm.com>
15814             Tom Tromey  <tom@tromey.com>
15815
15816         * common/scope-exit.h: New file.
15817
15818 2019-01-23  Pedro Alves  <palves@redhat.com>
15819
15820         * common/preprocessor.h (ESC): Rename to ...
15821         (ESC_PARENS): ... this.
15822         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15823         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15824
15825 2019-01-23  Tom Tromey  <tom@tromey.com>
15826
15827         * language.h (class scoped_switch_to_sym_language_if_auto):
15828         Initialize m_lang in both cases.
15829
15830 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15831
15832         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15833         with XCNEW.
15834
15835 2019-01-22  Tom Tromey  <tom@tromey.com>
15836
15837         * corelow.c: Do not include sys/file.h.
15838
15839 2019-01-22  Tom Tromey  <tom@tromey.com>
15840
15841         * tui/tui-wingeneral.h: Include gdb_curses.h.
15842
15843 2019-01-22  Tom Tromey  <tom@tromey.com>
15844
15845         * source-cache.h (class source_cache) <get_source_lines,
15846         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15847
15848 2019-01-22  Tom Tromey  <tom@tromey.com>
15849
15850         * remote-fileio.h (struct remote_target): Declare.
15851
15852 2019-01-22  Tom Tromey  <tom@tromey.com>
15853
15854         * python/py-arch.c: Do not include py-ref.h.
15855         * python/py-bpevent.c: Do not include py-ref.h.
15856         * python/py-cmd.c: Do not include py-ref.h.
15857         * python/py-continueevent.c: Do not include py-ref.h.
15858         * python/py-event.h: Do not include py-ref.h.
15859         * python/py-evtregistry.c: Do not include py-ref.h.
15860         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15861         * python/py-frame.c: Do not include py-ref.h.
15862         * python/py-framefilter.c: Do not include py-ref.h.
15863         * python/py-function.c: Do not include py-ref.h.
15864         * python/py-infevents.c: Do not include py-ref.h.
15865         * python/py-linetable.c: Do not include py-ref.h.
15866         * python/py-objfile.c: Do not include py-ref.h.
15867         * python/py-param.c: Do not include py-ref.h.
15868         * python/py-prettyprint.c: Do not include py-ref.h.
15869         * python/py-progspace.c: Do not include py-ref.h.
15870         * python/py-symbol.c: Do not include py-ref.h.
15871         * python/py-symtab.c: Do not include py-ref.h.
15872         * python/py-type.c: Do not include py-ref.h.
15873         * python/py-unwind.c: Do not include py-ref.h.
15874         * python/py-utils.c: Do not include py-ref.h.
15875         * python/py-value.c: Do not include py-ref.h.
15876         * python/py-varobj.c: Do not include py-ref.h.
15877         * python/py-xmethods.c: Do not include py-ref.h.
15878         * python/python.c: Do not include py-ref.h.
15879         * varobj.c: Do not include py-ref.h.
15880
15881 2019-01-22  Tom Tromey  <tom@tromey.com>
15882
15883         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15884         keyword for bcache.
15885
15886 2019-01-22  Tom Tromey  <tom@tromey.com>
15887
15888         * compile/compile-cplus-types.c: Remove a comment by #include.
15889
15890 2019-01-22  Tom Tromey  <tom@tromey.com>
15891
15892         * compile/gcc-c-plugin.h: Include compile-internal.h.
15893
15894 2019-01-22  Tom Tromey  <tom@tromey.com>
15895
15896         * stabsread.c (EXTERN): Do not define.
15897         (symnum, next_symbol_text_func, processing_gcc_compilation)
15898         (within_function, global_sym_chain, global_stabs)
15899         (previous_stab_code, this_object_header_files)
15900         (n_this_object_header_files)
15901         (n_allocated_this_object_header_files): Define.
15902         * stabsread.h (EXTERN): Never define.  Use "extern".
15903
15904 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15905
15906         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15907         history_value.
15908
15909 2019-01-21  Tom Tromey  <tom@tromey.com>
15910
15911         * ui-out.c: Fix includes.
15912         * tui/tui-source.c: Fix includes.
15913         * target.c: Fix includes.
15914         * remote.c: Fix includes.
15915         * regcache.c: Fix includes.
15916         * python/py-block.c: Fix includes.
15917         * printcmd.c: Fix includes.
15918         * or1k-tdep.c: Fix includes.
15919         * mi/mi-main.c: Fix includes.
15920         * m32r-tdep.c: Fix includes.
15921         * csky-tdep.c: Fix includes.
15922         * compile/compile-cplus-types.c: Fix includes.
15923         * cli/cli-interp.c: Fix includes.
15924
15925 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15926
15927         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15928         for padding.
15929
15930 2019-01-16  Tom Tromey  <tom@tromey.com>
15931
15932         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15933         earlier.
15934         (struct objfile) <msymbols_range>: Move from top level.
15935         <msymbols>: New method.
15936         (class objfile_msymbols): Remove.
15937         * symtab.c (default_collect_symbol_completion_matches_break_on):
15938         Update.
15939         * symmisc.c (dump_msymbols): Update.
15940         * stabsread.c (scan_file_globals): Update.
15941         * objc-lang.c (info_selectors_command, info_classes_command)
15942         (find_methods): Update.
15943         * minsyms.c (find_solib_trampoline_target): Update.
15944         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
15945         * coffread.c (coff_symfile_read): Update.
15946         * ada-lang.c (ada_lookup_simple_minsym)
15947         (ada_collect_symbol_completion_matches): Update.
15948
15949 2019-01-16  Tom Tromey  <tom@tromey.com>
15950
15951         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
15952         type.  Remove no-argument constructor.
15953         <iterator::operator++>: Simplify.
15954         <begin>: Update.
15955         <end>: Use minimal_symbol_count.
15956
15957 2019-01-16  Tom Tromey  <tom@tromey.com>
15958
15959         * objfiles.h (struct objfile) <psymtabs>: New method.
15960         (class objfile_psymtabs): Remove.
15961         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
15962         typedef.
15963         <range>: New method.
15964         (require_partial_symbols): Change return type.
15965         * psymtab.c (require_partial_symbols)
15966         (psym_expand_symtabs_matching): Update.
15967         * mdebugread.c (parse_partial_symbols): Update.
15968         * dbxread.c (dbx_end_psymtab): Update.
15969
15970 2019-01-15  Tom Tromey  <tom@tromey.com>
15971
15972         * symtab.c (lookup_objfile_from_block)
15973         (lookup_symbol_in_objfile_symtabs)
15974         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
15975         (find_line_symtab, info_sources_command)
15976         (default_collect_symbol_completion_matches_break_on)
15977         (make_source_files_completion_list): Update.
15978         * symmisc.c (print_objfile_statistics, dump_objfile)
15979         (maintenance_print_symbols, maintenance_info_symtabs)
15980         (maintenance_check_symtabs, maintenance_info_line_tables):
15981         Update.
15982         * source.c (select_source_symtab)
15983         (forget_cached_source_info_for_objfile): Update.
15984         * objfiles.h (class objfile_compunits): Remove.
15985         (struct objfile) <compunits_range>: New typedef.
15986         (compunits): New method.
15987         * objfiles.c (objfile_relocate1): Update.
15988         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
15989         * maint.c (count_symtabs_and_blocks): Update.
15990         * linespec.c (iterate_over_all_matching_symtabs): Update.
15991         * cp-support.c (add_symbol_overload_list_qualified): Update.
15992         * coffread.c (coff_symtab_read): Update.
15993         * ada-lang.c (add_nonlocal_symbols)
15994         (ada_collect_symbol_completion_matches)
15995         (ada_add_global_exceptions): Update.
15996
15997 2019-01-15  Tom Tromey  <tom@tromey.com>
15998
15999         * progspace.h (program_space) <objfiles_safe_range>: New
16000         typedef.
16001         <objfiles_safe>: New method.
16002         * objfiles.h (class all_objfiles_safe): Remove.
16003         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16004         * jit.c (jit_inferior_exit_hook): Update.
16005
16006 2019-01-17  Tom Tromey  <tom@tromey.com>
16007
16008         * progspace.h (program_space) <objfiles_range>: New typedef.
16009         <objfiles>: New method.
16010         <objfiles_head>: Rename from objfiles.
16011         (object_files): Update.
16012         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16013         * guile/scm-pretty-print.c
16014         (ppscm_find_pretty_printer_from_objfiles): Update.
16015         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16016         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16017         Update.
16018         * python/py-progspace.c (pspy_get_objfiles): Update.
16019         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16020         Update.
16021         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16022         (objfpy_lookup_objfile_by_build_id): Update.
16023         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16024         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16025         Update.
16026         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16027         (expand_symtab_containing_pc, lookup_objfile_from_block)
16028         (lookup_static_symbol, basic_lookup_transparent_type)
16029         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16030         (find_line_symtab, info_sources_command)
16031         (default_collect_symbol_completion_matches_break_on)
16032         (make_source_files_completion_list, find_main_name): Update.
16033         * symmisc.c (print_symbol_bcache_statistics)
16034         (print_objfile_statistics, maintenance_print_symbols)
16035         (maintenance_print_msymbols, maintenance_print_objfiles)
16036         (maintenance_info_symtabs, maintenance_check_symtabs)
16037         (maintenance_expand_symtabs, maintenance_info_line_tables):
16038         Update.
16039         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16040         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16041         (map_overlay_command, unmap_overlay_command)
16042         (simple_overlay_update, expand_symtabs_matching)
16043         (map_symbol_filenames): Update.
16044         * symfile-debug.c (set_debug_symfile): Update.
16045         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16046         Update.
16047         * source.c (select_source_symtab, forget_cached_source_info):
16048         Update.
16049         * solib.c (solib_read_symbols): Update.
16050         * solib-spu.c (append_ocl_sos): Update.
16051         * psymtab.c (maintenance_print_psymbols)
16052         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16053         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16054         * printcmd.c (info_symbol_command): Update.
16055         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16056         Update.
16057         * objfiles.h (class all_objfiles): Remove.
16058         * objfiles.c (have_partial_symbols, have_full_symbols)
16059         (have_minimal_symbols, qsort_cmp, update_section_map)
16060         (shared_objfile_contains_address_p)
16061         (default_iterate_over_objfiles_in_search_order): Update.
16062         * objc-lang.c (info_selectors_command, info_classes_command)
16063         (find_methods): Update.
16064         * minsyms.c (find_solib_trampoline_target): Update.
16065         * maint.c (maintenance_info_sections)
16066         (maintenance_translate_address, count_symtabs_and_blocks):
16067         Update.
16068         * main.c (captured_main_1): Update.
16069         * linux-thread-db.c (try_thread_db_load_from_pdir)
16070         (has_libpthread): Update.
16071         * linespec.c (iterate_over_all_matching_symtabs)
16072         (search_minsyms_for_name): Update.
16073         * jit.c (jit_find_objf_with_entry_addr): Update.
16074         * hppa-tdep.c (find_unwind_entry)
16075         (hppa_lookup_stub_minimal_symbol): Update.
16076         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16077         Update.
16078         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16079         (elf_gnu_ifunc_resolve_by_got): Update.
16080         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16081         * dwarf-index-write.c (save_gdb_index_command): Update.
16082         * cp-support.c (add_symbol_overload_list_qualified): Update.
16083         * breakpoint.c (create_overlay_event_breakpoint)
16084         (create_longjmp_master_breakpoint)
16085         (create_std_terminate_master_breakpoint)
16086         (create_exception_master_breakpoint): Update.
16087         * blockframe.c (find_pc_partial_function): Update.
16088         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16089         (ada_collect_symbol_completion_matches)
16090         (ada_add_global_exceptions): Update.
16091
16092 2019-01-17  Tom Tromey  <tom@tromey.com>
16093
16094         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16095         declare VEC.
16096         (solib_target_parse_libraries): Change return type.
16097         (library_list_start_segment, library_list_start_section)
16098         (library_list_end_library, library_list_start_library); Update.
16099         (solib_target_free_library_list): Remove.
16100         (solib_target_parse_libraries): Remove cleanup.  Change return
16101         type.
16102         (solib_target_current_sos): Update.
16103
16104 2019-01-17  Tom Tromey  <tromey@bapiya>
16105
16106         * valprint.c: Replace "the the" with "the".
16107         * symtab.c: Replace "the the" with "the".
16108         * solib.c: Replace "the the" with "the".
16109         * solib-dsbt.c: Replace "the the" with "the".
16110         * linespec.c: Replace "the the" with "the".
16111         * dwarf2loc.h: Replace "the the" with "the".
16112         * amd64-windows-tdep.c: Replace "the the" with "the".
16113         * aarch64-tdep.c: Replace "the the" with "the".
16114
16115 2019-01-16  Keith Seitz  <keiths@redhat.com>
16116
16117         PR gdb/23773
16118         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16119         <builder>: Rename to ..
16120         <m_builder>: ... this and make private.
16121         (dwarf2_cu::get_builder): New method.  Change all users of
16122         `builder' to use this method.
16123         (dwarf2_start_symtab): Move to ...
16124         (dwarf2_cu::start_symtab): ... here.  Update all callers
16125         (setup_type_unit_groups): Move to ...
16126         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16127         callers.
16128         (dwarf2_cu::reset_builder): New method.
16129         (process_full_compunit, process_full_type_unit): Use
16130         dwarf2_cu::reset_builder.
16131         (follow_die_offset): Record the ancestor CU if it is different
16132         from the followed DIE's CU.
16133         (follow_die_sig_1): Likewise.
16134
16135 2019-01-15  Tom Tromey  <tom@tromey.com>
16136
16137         * remote.c (class remote_state) <buf>: Now a char_vector.
16138         <buf_size>: Remove.
16139         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16140         parameter.
16141         (remote_target::getpkt_or_notif_sane_1)
16142         (remote_target::getpkt_sane)
16143         (remote_target::getpkt_or_notif_sane): Likewise.
16144         (class remote_target) <putpkt>: New overload.
16145         (remote_target::read_frame): Change type of "buf_p".  Remove
16146         sizeof_p parameter.
16147         (packet_ok): New overload.
16148         (packet_check_result): New overload.
16149         Update all uses.
16150
16151 2019-01-14  Tom Tromey  <tom@tromey.com>
16152
16153         * remote-notif.c (handle_notification, remote_notif_ack)
16154         (remote_notif_parse): Make "buf" const.
16155         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16156         const.
16157         (remote_notif_parse, remote_notif_ack, handle_notification):
16158         Likewise.
16159         * remote.c (remote_notif_stop_parse): Make "buf" const.
16160         (remote_target::remote_parse_stop_reply): Make "buf" const.
16161         (remote_notif_stop_ack): Make "buf" const.
16162
16163 2019-01-14  Tom Tromey  <tom@tromey.com>
16164
16165         * remote.c (remote_console_output): Make parameter const.
16166
16167 2019-01-14  Tom Tromey  <tom@tromey.com>
16168
16169         * target-debug.h (target_debug_print_signals): Constify.
16170         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16171         * procfs.c (procfs_target::pass_signals): Update.
16172         * linux-nat.c (linux_nat_target::pass_signals): Update.
16173         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16174         * target-delegates.c: Rebuild.
16175         * remote.c (remote_target::program_signals): Update.
16176         (remote_target::pass_signals): Update.
16177         * target.c (target_pass_signals): Constify argument.
16178         (target_program_signals): Likewise.
16179         * target.h (struct target_ops) <pass_signals, program_signals>:
16180         Constify argument.
16181         (target_pass_signals, target_program_signals): Constify argument.
16182
16183 2019-01-14  Tom Tromey  <tom@tromey.com>
16184
16185         PR tui/28819:
16186         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16187
16188 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16189
16190         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16191         field.
16192         * rs6000-tdep.c: Include reggroups.h.
16193         (IS_V_ALIAS_PSEUDOREG): Define.
16194         (rs6000_register_name): Return names for the "vX" aliases.
16195         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16196         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16197         aliases.  Call default_register_reggroup_p for all other
16198         pseudo-registers.
16199         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16200         New functions.
16201         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16202         Handle "vX" aliases.
16203         (v_alias_pseudo_register_collect): New function.
16204         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16205         (rs6000_gdbarch_init): Initialize "vX" aliases as
16206         pseudo-registers.  Restore registration of
16207         rs6000_pseudo_register_reggroup_p with
16208         set_tdesc_pseudo_register_reggroup_p.
16209
16210 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16211
16212         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16213         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16214         set_gdbarch_num_pseudo_regs.
16215
16216 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16217
16218         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16219         Remove arg prefixname, add do_set and do_show.
16220         Add member functions set_list and show_list.
16221         * cli/cli-style.c (class cli_style_option): Update accordingly.
16222         (style_set_list): Move to file scope.
16223         (style_show_list): Likewise.
16224         (set_style): Call help_list.
16225         (show_style): Call cmd_show_list.
16226         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16227         Update to use the new macro.
16228
16229 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16230
16231         * ada-lang.c (_initialize_ada_language): Expand the help text
16232         for the "catch exception" command.
16233
16234 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16235
16236         * symtab.c (matching_obj_sections): Initialize obj,
16237         declare it closer to its usage.
16238
16239 2019-01-10  Tom Tromey  <tom@tromey.com>
16240
16241         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16242         (basic_inf_threads_range): Remove.
16243         (inf_threads_range, inf_non_exited_threads_range)
16244         (safe_inf_threads_range): Use next_adapter.
16245
16246 2019-01-10  Keith Seitz  <keiths@redhat.com>
16247
16248         PR gdb/23712
16249         PR symtab/23010
16250         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16251         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16252
16253 2019-01-10  Keith Seitz  <keiths@redhat.com>
16254
16255         PR gdb/23712
16256         PR symtab/23010
16257         * dictionary.c (pending_to_vector): Remove.
16258         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16259         Remove _1 suffix, replacing functions of the same name.  Update
16260         all callers.
16261         (dict_create_hashed, dict_create_hashed_expandable)
16262         (dict_create_linear, dict_create_linear_expandable, dict_free)
16263         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16264         Make functions static.
16265
16266 2019-01-10  Keith Seitz  <keiths@redhat.com>
16267
16268         PR gdb/23712
16269         PR symtab/23010
16270         * dictionary.h (struct dictionary): Replace declaration with
16271         multidictionary.
16272         (dict_create_hashed, dict_create_hashed_expandable)
16273         (dict_create_linear, dict_create_linear_expandable)
16274         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16275         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16276         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16277         taking multidictionary argument.
16278         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16279         * block.h (struct block) <dict>: Change to multidictionary
16280         and rename `multidict'.
16281         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16282         symmisc.c: Update all dictionary references to multidictionary.
16283
16284 2019-01-10  Keith Seitz  <keiths@redhat.com>
16285
16286         PR gdb/23712
16287         PR symtab/23010
16288         * dictionary.c: Include unordered_map.
16289         (pending_to_vector): New function.
16290         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16291         Rewrite the non-"_1" functions to take vector instead
16292         of linked list.
16293         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16294         "new" _1 versions of the same name.
16295         (multidictionary): Define.
16296         (std::hash<enum language): New definition.
16297         (collate_pending_symbols_by_language, mdict_create_hashed)
16298         (mdict_create_hashed_expandable, mdict_create_linear)
16299         (mdict_create_linear_expandable, mdict_free)
16300         (find_language_dictionary, create_new_language_dictionary)
16301         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16302         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16303         (mdict_size, mdict_empty): New functions.
16304         * dictionary.h (mdict_iterator): Define.
16305
16306 2019-01-10  Pedro Alves  <palves@redhat.com>
16307
16308         * breakpoint.c (read_uploaded_action)
16309         (create_tracepoint_from_upload): Adjust to use
16310         gdb::unique_xmalloc_ptr.
16311         * ctf.c (ctf_write_uploaded_tp):
16312         (SET_ARRAY_FIELD): Use emplace_back.
16313         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16314         * tracefile-tfile.c (tfile_write_uploaded_tp):
16315         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16316         gdb::unique_xmalloc_ptr.
16317         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16318         at_string, cond_string, cmd_strings>: Replace char pointers
16319         with gdb::unique_xmalloc_ptr.
16320
16321 2019-01-10  Pedro Alves  <palves@redhat.com>
16322
16323         * solib-target.c (library_list_start_library): Don't xstrdup name.
16324
16325 2019-01-10  Pedro Alves  <palves@redhat.com>
16326
16327         * mdebugread.c (parse_partial_symbols): Use
16328         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16329
16330 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16331
16332         * linux-fork.c (scoped_switch_fork_info)
16333         <~scoped_switch_fork_info>: Fix incorrect variable name.
16334
16335 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16336
16337         * linux-fork.c (scoped_switch_fork_info)
16338         <scoped_switch_fork_info>: Make explicit.
16339         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16340
16341 2019-01-10  Tom Tromey  <tom@tromey.com>
16342
16343         * objfiles.h (objfile::reset_psymtabs): Update.
16344         * objfiles.c (objfile::objfile): Update.
16345         * psymtab.h (psymtab_storage::obstack): Update.
16346         (psymtab_storage::m_obstack): Use gdb::optional.
16347         (class psymtab_storage): Update comment.  Remove objfile
16348         parameter.
16349         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16350
16351 2019-01-10  Tom Tromey  <tom@tromey.com>
16352
16353         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16354         <free_psymtabs>: Now private.
16355         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16356         (allocate_psymtab): Use new method.
16357
16358 2019-01-10  Tom Tromey  <tom@tromey.com>
16359
16360         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16361         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16362         * mdebugread.c (parse_partial_symbols): Use
16363         allocate_dependencies.
16364         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16365         allocate_dependencies.
16366         (process_psymtab_comp_unit_reader)
16367         (build_type_psymtab_dependencies): Likewise.
16368         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16369
16370 2019-01-10  Tom Tromey  <tom@tromey.com>
16371
16372         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16373         PSYMBOL_SET_LANGUAGE.
16374         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16375
16376 2019-01-10  Tom Tromey  <tom@tromey.com>
16377
16378         * psymtab.h (psymtab_storage::obstack): New method.
16379         <m_obstack>: Rename from obstack; now private.
16380         * psymtab.c (psymtab_storage): Update.
16381         * dwarf2read.c (create_addrmap_from_index)
16382         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16383         Update.
16384
16385 2019-01-10  Tom Tromey  <tom@tromey.com>
16386
16387         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16388         * objfiles.h (objfile::reset_psymtabs): New method.
16389
16390 2019-01-10  Tom Tromey  <tom@tromey.com>
16391
16392         * symmisc.c (print_symbol_bcache_statistics): Update.
16393         (print_objfile_statistics): Update.
16394         * symfile.c (reread_symbols): Update.
16395         * psymtab.h (class psymtab_storage): New.
16396         * psymtab.c (psymtab_storage): New constructor.
16397         (~psymtab_storage): New destructor.
16398         (require_partial_symbols): Update.
16399         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16400         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16401         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16402         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16403         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16404         (start_psymtab_common, end_psymtab_common)
16405         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16406         (allocate_psymtab): Update.
16407         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16408         Update.
16409         (dump_psymtab_addrmap, maintenance_print_psymbols)
16410         (maintenance_check_psymtabs): Update.
16411         (class objfile_psymtabs): Move to objfiles.h.
16412         * psympriv.h (discard_psymtab): Now inline.
16413         (psymtab_discarder::psymtab_discarder): Update.
16414         (psymtab_discarder::~psymtab_discarder): Update.
16415         (ALL_OBJFILE_PSYMTABS): Rewrite.
16416         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16417         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16418         Remove fields.
16419         <partial_symtabs>: New field.
16420         (class objfile_psymtabs): Move from psymtab.h.  Update.
16421         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16422         psymbol_cache.
16423         (objfile::~objfile): Don't destroy psymbol_cache.
16424         * mdebugread.c (parse_partial_symbols): Update.
16425         * dwarf2read.c (create_addrmap_from_index)
16426         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16427         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16428         (add_partial_subprogram, dwarf2_ranges_read): Update.
16429         * dwarf-index-write.c (write_address_map)
16430         (write_one_signatured_type, recursively_write_psymbols)
16431         (class debug_names, class debug_names, write_psymtabs_to_index):
16432         Update.
16433
16434 2019-01-10  Tom Tromey  <tom@tromey.com>
16435
16436         * symtab.h (SYMBOL_SET_NAMES): Update.
16437         (symbol_set_names): Update.
16438         (MSYMBOL_SET_NAMES): Update.
16439         * symtab.c (symbol_set_names): Change argument to be an
16440         objfile_per_bfd_storage.
16441         * psymtab.c (add_psymbol_to_bcache): Update.
16442         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16443
16444 2019-01-10  Tom Tromey  <tom@tromey.com>
16445
16446         * symtab.c (create_demangled_names_hash): Change argument to be an
16447         objfile_per_bfd_storage.
16448         (symbol_set_names): Update.
16449
16450 2019-01-10  Tom Tromey  <tom@tromey.com>
16451
16452         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16453         init_psymbol_list.
16454         * psymtab.c (init_psymbol_list): Do nothing if already called.
16455         * psympriv.h (init_psymbol_list): Add comment.
16456         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16457         init_psymbol_list.
16458         * dbxread.c (dbx_symfile_read): Unconditionally call
16459         init_psymbol_list.
16460
16461 2019-01-10  Tom Tromey  <tom@tromey.com>
16462
16463         * xcoffread.c (scan_xcoff_symtab): Update.
16464         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16465         "where".
16466         * mdebugread.c (parse_partial_symbols)
16467         (handle_psymbol_enumerators): Update.
16468         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16469         * dbxread.c (read_dbx_symtab): Update.
16470         * psympriv.h (psymbol_placement): New enum.
16471         (add_psymbol_to_list): Update.
16472
16473 2019-01-10  Tom Tromey  <tom@tromey.com>
16474
16475         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16476         static_psymbols parameters.
16477         (scan_xcoff_symtab): Update.
16478         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16479         static_psymbols parameters.
16480         * psympriv.h (start_psymtab_common): Update.
16481         * mdebugread.c (parse_partial_symbols): Update.
16482         * dwarf2read.c (create_partial_symtab): Update.
16483         * dbxread.c (read_dbx_symtab): Update.
16484         (start_psymtab): Remove global_psymbols and static_psymbols
16485         parameters.
16486
16487 2019-01-10  Tom Tromey  <tom@tromey.com>
16488
16489         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16490         * psymtab.c (allocate_psymtab): Add comment.
16491         * psympriv.h (allocate_psymtab): Add comment.
16492         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16493         initializations.
16494         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16495
16496 2019-01-10  Tom Tromey  <tom@tromey.com>
16497
16498         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16499         Don't declare.
16500         * mipsread.c: Include mdebugread.h.
16501         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16502         Declare.
16503         * elfread.c: Include mdebugread.h.
16504
16505 2019-01-09  Tom Tromey  <tom@tromey.com>
16506
16507         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16508         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16509         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16510         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16511         (psym_lookup_symbol, psym_find_last_source_symtab)
16512         (psym_forget_cached_source_info, psym_print_stats)
16513         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16514         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16515         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16516         (psym_find_compunit_symtab_by_address)
16517         (maintenance_print_psymbols, maintenance_info_psymtabs)
16518         (maintenance_check_psymtabs): Use ranged for.
16519         * psymtab.h (class objfile_psymtabs): New.
16520         (require_partial_symbols): Return objfile_psymtabs.
16521         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16522
16523 2019-01-09  Tom Tromey  <tom@tromey.com>
16524
16525         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16526         (find_pc_mapped_section, list_overlays_command)
16527         (map_overlay_command, unmap_overlay_command)
16528         (simple_overlay_update): Use all_objfiles.
16529         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16530         * printcmd.c (info_symbol_command): Use all_objfiles.
16531         * objfiles.h (ALL_OBJSECTIONS): Remove.
16532         * maint.c (maintenance_translate_address): Use all_objfiles.
16533         * gcore.c (gcore_create_callback): Use all_objfiles.
16534         (objfile_find_memory_regions): Likewise.
16535
16536 2019-01-09  Tom Tromey  <tom@tromey.com>
16537
16538         * symtab.c (find_line_symtab, info_sources_command)
16539         (make_source_files_completion_list): Use objfile_compunits.
16540         * source.c (select_source_symtab): Use objfile_compunits.
16541         * objfiles.h (struct objfile): Update comment.
16542         (ALL_OBJFILES): Remove.
16543         (ALL_FILETABS): Remove.
16544         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16545         objfile_compunits.
16546
16547 2019-01-09  Tom Tromey  <tom@tromey.com>
16548
16549         * symmisc.c (print_objfile_statistics, dump_objfile)
16550         (maintenance_print_symbols): Use compunit_filetabs.
16551         * source.c (forget_cached_source_info_for_objfile): Use
16552         compunit_filetabs.
16553         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16554         (ALL_FILETABS): Use compunit_filetabs.
16555         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16556         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16557
16558 2019-01-09  Tom Tromey  <tom@tromey.com>
16559
16560         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16561         (compunit_filetabs): New.
16562         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16563         compunit_filetabs.
16564         (info_sources_command, make_source_files_completion_list): Remove
16565         declaration.
16566         * symmisc.c (print_objfile_statistics, dump_objfile)
16567         (maintenance_print_symbols): Remove declaration.
16568         (maintenance_info_symtabs): Use compunit_filetabs.
16569         (maintenance_info_line_tables): Likewise.
16570         * source.c (select_source_symtab): Change local variable name.
16571         (forget_cached_source_info_for_objfile): Remove declaration.
16572         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16573         * objfiles.c (objfile_relocate1): Remove declaration.
16574         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16575         declaration.
16576         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16577         * coffread.c (coff_symtab_read): Remove declaration.
16578         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16579         compunit_filetabs.
16580
16581 2019-01-09  Tom Tromey  <tom@tromey.com>
16582
16583         * symtab.c (lookup_objfile_from_block)
16584         (find_pc_sect_compunit_symtab, search_symbols)
16585         (default_collect_symbol_completion_matches_break_on): Use
16586         objfile_compunits.
16587         * objfiles.h (ALL_COMPUNITS): Remove.
16588         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16589         * cp-support.c (add_symbol_overload_list_qualified): Use
16590         objfile_compunits.
16591         * ada-lang.c (ada_collect_symbol_completion_matches)
16592         (ada_add_global_exceptions): Use objfile_compunits.
16593
16594 2019-01-09  Tom Tromey  <tom@tromey.com>
16595
16596         * source.c (select_source_symtab)
16597         (forget_cached_source_info_for_objfile): Remove declaration.
16598         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16599         declaration.
16600         * maint.c (count_symtabs_and_blocks): Remove declaration.
16601         * cp-support.c (add_symbol_overload_list_qualified): Remove
16602         declaration.
16603         * coffread.c (coff_symtab_read): Remove declaration.
16604         * symtab.c (lookup_symbol_in_objfile_symtabs)
16605         (basic_lookup_transparent_type_1): Use objfile_compunits.
16606         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16607         (info_sources_command, search_symbols)
16608         (default_collect_symbol_completion_matches_break_on)
16609         (make_source_files_completion_list): Remove declaration.
16610         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16611         (ada_collect_symbol_completion_matches)
16612         (ada_add_global_exceptions): Remove declaration.
16613         * linespec.c (iterate_over_all_matching_symtabs): Use
16614         objfile_compunits.
16615         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16616         (class objfile_compunits): New.
16617         (ALL_COMPUNITS): Use objfile_compunits.
16618         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16619         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16620         objfile_compunits.
16621         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16622
16623 2019-01-09  Tom Tromey  <tom@tromey.com>
16624
16625         * symtab.c (search_symbols)
16626         (default_collect_symbol_completion_matches_break_on): Use
16627         objfile_msymbols.
16628         * ada-lang.c (ada_lookup_simple_minsym)
16629         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16630         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16631         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16632         objfile_msymbols.
16633         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16634         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16635         * objc-lang.c (find_methods): Use objfile_msymbols.
16636         (info_selectors_command, info_classes_command): Likewise.
16637         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16638         * objfiles.h (class objfile_msymbols): New.
16639         (ALL_OBJFILE_MSYMBOLS): Remove.
16640         (ALL_MSYMBOLS): Remove.
16641
16642 2019-01-09  Tom Tromey  <tom@tromey.com>
16643
16644         * common/next-iterator.h (next_adapter): Add Iterator template
16645         parameter.
16646         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16647         (class all_objfiles_safe): New.
16648         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16649         * objfiles.c (put_objfile_before): Update comment.
16650         (add_separate_debug_objfile): Likewise.
16651         (free_all_objfiles): Use all_objfiles_safe.
16652         (objfile_purge_solibs): Likewise.
16653
16654 2019-01-09  Tom Tromey  <tom@tromey.com>
16655
16656         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16657         (expand_symtab_containing_pc, lookup_static_symbol)
16658         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16659         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16660         all_objfiles.
16661         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16662         * breakpoint.c (create_overlay_event_breakpoint)
16663         (create_longjmp_master_breakpoint)
16664         (create_std_terminate_master_breakpoint)
16665         (create_exception_master_breakpoint): Use all_objfiles.
16666         * linux-thread-db.c (try_thread_db_load_from_pdir)
16667         (has_libpthread): Use all_objfiles.
16668         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16669         * linespec.c (iterate_over_all_matching_symtabs)
16670         (search_minsyms_for_name): Use all_objfiles.
16671         * maint.c (maintenance_info_sections): Use all_objfiles.
16672         * main.c (captured_main_1): Use all_objfiles.
16673         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16674         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16675         * guile/scm-pretty-print.c
16676         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16677         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16678         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16679         (maintenance_print_msymbols): Use all_objfiles.
16680         * source.c (select_source_symtab): Use all_objfiles.
16681         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16682         * symfile.c (remove_symbol_file_command)
16683         (expand_symtabs_matching, map_symbol_filenames): Use
16684         all_objfiles.
16685         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16686         all_objfiles.
16687         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16688         * objc-lang.c (find_methods): Use all_objfiles.
16689         * objfiles.c (have_partial_symbols, have_full_symbols)
16690         (have_minimal_symbols, qsort_cmp)
16691         (default_iterate_over_objfiles_in_search_order): Use
16692         all_objfiles.
16693         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16694         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16695         (maintenance_check_psymtabs): Use all_objfiles.
16696         (ALL_PSYMTABS): Remove.
16697         * compile/compile-object-run.c (do_module_cleanup): Use
16698         all_objfiles.
16699         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16700         * cp-support.c (add_symbol_overload_list_qualified): Use
16701         all_objfiles.
16702         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16703         Use all_objfiles.
16704         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16705         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16706         all_objfiles.
16707         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16708         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16709         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16710         Uses all_objfiles.
16711         * solib.c (solib_read_symbols): Use all_objfiles
16712
16713 2019-01-09  Tom Tromey  <tom@tromey.com>
16714
16715         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16716         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16717         all_objfiles.
16718         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16719         * symmisc.c (print_symbol_bcache_statistics)
16720         (print_objfile_statistics, maintenance_print_objfiles)
16721         (maintenance_info_symtabs, maintenance_check_symtabs)
16722         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16723         all_objfiles.
16724         * source.c (forget_cached_source_info): Use all_objfiles.
16725         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16726         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16727         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16728         * objfiles.c (update_section_map): Use all_objfiles.
16729         (shared_objfile_contains_address_p): Likewise.
16730         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16731         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16732
16733 2019-01-09  Tom Tromey  <tom@tromey.com>
16734
16735         * common/next-iterator.h: New file.
16736         * objfiles.h (class all_objfiles): New.
16737         (struct objfile_iterator): New.
16738
16739 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16740
16741         * NEWS: Move the description of the changed "frame", "select-frame",
16742          and "info frame" commands to the Changed commands section.
16743
16744 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16745
16746         * gdbtypes.c (check_stub_method_group): Remove handling of old
16747         mangling schemes.
16748         * linespec.c (find_methods): Likewise.
16749         * stabsread.c (read_member_functions): Likewise.
16750         * valops.c (search_struct_method): Likewise.
16751         (value_struct_elt_for_reference): Likewise.
16752         * NEWS: Mention this change.
16753
16754 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16755
16756         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16757         print_source_lines.
16758         * source.c (print_source_lines_base): Update line number check.
16759         (print_source_lines): New function.
16760         (source_lines_range::source_lines_range): New function.
16761         * source.h (class source_lines_range): New class.
16762         (print_source_lines): New declaration.
16763
16764 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16765
16766         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16767
16768 2019-01-08  Tom Tromey  <tom@tromey.com>
16769             Simon Marchi  <simon.marchi@ericsson.com>
16770
16771         PR gdb/24060
16772         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16773         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16774         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16775         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16776         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16777         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16778
16779 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16780
16781         * source.c (select_source_symtab): Move header comment to
16782         declaration in source.h.
16783         (forget_cached_source_info_for_objfile): Likewise.
16784         (forget_cached_source_info): Likewise.
16785         (identify_source_line): Likewise.
16786         * source.h (identify_source_line): Move declaration from symtab.h
16787         and add comment from source.c
16788         (print_source_lines): Likewise.
16789         (forget_cached_source_info_for_objfile): Likewise.
16790         (forget_cached_source_info): Likewise.
16791         (select_source_symtab): Likewise.
16792         (enum print_source_lines_flag): Move definition from symtab.h.
16793         * symtab.h (identify_source_line): Move declaration to source.h.
16794         (print_source_lines): Likewise.
16795         (forget_cached_source_info_for_objfile): Likewise.
16796         (forget_cached_source_info): Likewise.
16797         (select_source_symtab): Likewise.
16798         (enum print_source_lines_flag): Move definition to source.h.
16799         * tui/tui-hooks.c: Add 'source.h' include.
16800
16801 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16802
16803         * source.c (print_source_lines_base): Handle requests to print
16804         reverse line number sequences, and guard against empty lines
16805         string.
16806
16807 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16808
16809         * source.c (print_source_lines_base): Fix skip of '\r' if next
16810         character is '\n'.
16811
16812 2019-01-06  Tom Tromey  <tom@tromey.com>
16813
16814         * c-exp.y (struct c_parse_state) <macro_original_text,
16815         expansion_obstack>: New member.
16816         (macro_original_text, expansion_obstack): Remove globals.
16817         (scan_macro_expansion, scanning_macro_expansion)
16818         (finished_macro_expansion): Update.
16819         (scan_macro_cleanup): Remove.
16820         (yylex, c_parse): Update.
16821
16822 2019-01-06  Tom Tromey  <tom@tromey.com>
16823
16824         * c-exp.y (struct c_parse_state) <strings>: New member.
16825         (operator_stoken): Update.
16826
16827 2019-01-06  Tom Tromey  <tom@tromey.com>
16828
16829         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16830         (union type_stack_elt) <typelist_val>: Now a pointer to
16831         std::vector.
16832         (type_stack_cleanup): Don't declare.
16833         (push_typelist): Update.
16834         * parse.c (pop_typelist): Return a std::vector.
16835         (push_typelist): Take a std::vector.
16836         (follow_types): Update.  Do not free args.
16837         (type_stack_cleanup): Remove.
16838         * c-exp.y (struct c_parse_state): New.
16839         (cpstate): New global.
16840         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16841         (nonempty_typelist): Update.
16842         (func_mod): Create a new vector.
16843         (c_parse): Create a c_parse_state.
16844         (check_parameter_typelist): Do not delete params.
16845         (function_method): Update.  Do not delete type_list.
16846
16847 2019-01-06  Tom Tromey  <tom@tromey.com>
16848
16849         PR gdb/28155:
16850         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16851         check_typedef.
16852         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16853         (print_return_value): Likewise.
16854
16855 2019-01-05  Tom Tromey  <tom@tromey.com>
16856
16857         * contrib/cleanup_check.py: Remove.
16858         * contrib/gcc-with-excheck: Remove.
16859         * contrib/exsummary.py: Remove.
16860         * contrib/excheck.py: Remove.
16861
16862 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16863
16864         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16865         NULL. Initialize tpprev to NULL instead of assigning it
16866         to NULL on the next statement.
16867         * windows-nat.c (windows_delete_thread): Remove check for
16868         main_thread_id before printing thread exit notifications.
16869         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16870         Remove thread ID check against main_thread_id.
16871         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16872         windows_delete_thread.
16873         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16874
16875 2019-01-04  Tom Tromey  <tom@tromey.com>
16876
16877         * compile/compile.c (_initialize_compile): Use upper case for
16878         metasyntactic variables.
16879         * symmisc.c (_initialize_symmisc): Use upper case for
16880         metasyntactic variables.
16881         * psymtab.c (_initialize_psymtab): Use upper case for
16882         metasyntactic variables.
16883         * demangle.c (demangle_command): Use upper case for metasyntactic
16884         variables.
16885         (_initialize_demangler): Likewise.
16886         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16887         variables.
16888
16889 2019-01-03  Tom Tromey  <tom@tromey.com>
16890
16891         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16892
16893 2019-01-03  Tom Tromey  <tom@tromey.com>
16894
16895         * python/py-symtab.c (salpy_str): Update.
16896         (struct salpy_sal_object) <symtab>: Now a PyObject.
16897         (salpy_dealloc): Update.
16898         (del_objfile_sal): Use gdbpy_ref.
16899
16900 2019-01-03  Tom Tromey  <tom@tromey.com>
16901
16902         * python/py-type.c (convert_field): Use new_reference.  Return
16903         gdbpy_ref.
16904         (make_fielditem): Return gdbpy_ref.
16905         (typy_fields): Update.
16906         (typy_getitem): Update.
16907         (field_name): Return gdbpy_ref.  Use new_reference.
16908         (typy_iterator_iternext): Update.
16909
16910 2019-01-03  Tom Tromey  <tom@tromey.com>
16911
16912         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16913
16914 2019-01-03  Tom Tromey  <tom@tromey.com>
16915
16916         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16917         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16918         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16919         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16920         (pspy_set_type_printers): Likewise.
16921         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16922         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16923         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16924         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16925         (objfpy_set_type_printers): Likewise.
16926
16927 2019-01-03  Tom Tromey  <tom@tromey.com>
16928
16929         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16930         (gdbpy_print_stack): Use gdbpy_err_fetch.
16931         * python/python-internal.h (class gdbpy_err_fetch): New class.
16932         (class gdbpy_enter) <m_error_type, m_error_value,
16933         m_error_traceback>: Remove.
16934         <m_error>: New member.
16935         (gdbpy_exception_to_string): Don't declare.
16936         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
16937         * python/py-value.c (convert_value_from_python): Use
16938         gdbpy_err_fetch.
16939         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
16940         gdbpy_exception_to_string.
16941         (gdbpy_handle_exception): Use gdbpy_err_fetch.
16942         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
16943         gdbpy_err_fetch.
16944
16945 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16946
16947         * linux-nat.c (delete_lwp_cleanup): Delete.
16948         (struct lwp_deleter): New struct.
16949         (lwp_info_up): New typedef.
16950         (linux_nat_target::follow_fork): Delete cleanup, and make use of
16951         lwp_info_up.
16952
16953 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16954
16955         * linux-fork.c (class scoped_switch_fork_info): New class.
16956         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
16957
16958 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16959
16960         * valops.c (find_overload_match): Remove use of null_cleanup, and
16961         calls to do_cleanups.
16962
16963 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16964
16965         * compile/compile-cplus-types.c
16966         (compile_cplus_instance::decl_name): Handle changes to
16967         cp_func_name.
16968         * cp-support.c (cp_func_name): Update header comment, update
16969         return type.
16970         * cp-support.h (cp_func_name): Update return type in declaration.
16971         * valops.c (find_overload_match): Move temp_func local to top
16972         level of function and change its type.  Use temp_func to hold and
16973         delete temporary string obtained from cp_func_name.
16974
16975 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
16976
16977         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
16978         gdb::char_vector, remove cleanup, and update uses of `msg`.
16979
16980 2019-01-03  Jim Wilson  <jimw@sifive.com>
16981
16982         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
16983
16984 2019-01-02  Tom Tromey  <tom@tromey.com>
16985
16986         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
16987         (tdesc_parse_xml): Remove cleanups.
16988         * target-descriptions.h (make_cleanup_free_target_description):
16989         Don't declare.
16990         (target_desc_deleter): New struct.
16991         (target_desc_up): New typedef.
16992         * target-descriptions.c (target_desc_deleter::operator()): Rename
16993         from free_target_description.
16994         (make_cleanup_free_target_description): Remove.
16995
16996 2019-01-02  Tom Tromey  <tom@tromey.com>
16997
16998         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
16999         constructor, destructor.
17000         (linespec_parser): Remove typedef.
17001         (~linespec_parser): Rename from linespec_parser_delete.
17002         (linespec_lex_to_end, linespec_complete_label)
17003         (linespec_complete): Update.
17004         (decode_line_full): Remove cleanups.
17005         (decode_line_1): Update.
17006
17007 2019-01-02  Tom Tromey  <tom@tromey.com>
17008
17009         * python/python-internal.h (inferior_to_inferior_object): Change
17010         return type.
17011         * python/py-exitedevent.c (create_exited_event_object): Update.
17012         * python/py-inferior.c (inferior_to_inferior_object): Return
17013         gdbpy_ref.
17014         (python_new_inferior, python_inferior_deleted)
17015         (thread_to_thread_object, delete_thread_object)
17016         (build_inferior_list, gdbpy_selected_inferior): Update.
17017         * python/py-infthread.c (create_thread_object): Update.  Also fail
17018         if inferior_to_inferior_object fails.
17019
17020 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17021
17022         * inferior.h (class inferior) <displaced_step_state>: New field.
17023         * infrun.h (struct displaced_step_state): Move here from
17024         infrun.c.  Initialize fields, add constructor.
17025         <inf>: Remove field.
17026         <reset>: New method.
17027         * infrun.c (struct displaced_step_inferior_state): Move to
17028         infrun.h.
17029         (displaced_step_inferior_states): Remove.
17030         (get_displaced_stepping_state): Adust.
17031         (displaced_step_in_progress_any_inferior): Adjust.
17032         (displaced_step_in_progress_thread): Adjust.
17033         (displaced_step_in_progress): Adjust.
17034         (add_displaced_stepping_state): Remove.
17035         (get_displaced_step_closure_by_addr): Adjust.
17036         (remove_displaced_stepping_state): Remove.
17037         (infrun_inferior_exit): Call displaced_step_state.reset.
17038         (use_displaced_stepping): Don't check for NULL.
17039         (displaced_step_prepare_throw): Call
17040         get_displaced_stepping_state.
17041         (displaced_step_fixup): Don't check for NULL.
17042         (prepare_for_detach): Don't check for NULL.
17043
17044 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17045
17046         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17047          in case of call that did not complete.
17048
17049 2019-01-02  Andrey Utkin  <autkin@undo.io>
17050
17051         * symfile.c (find_separate_debug_file): Fix search of debug files for
17052         remote debuggee.
17053
17054 2019-01-02  Tom Tromey  <tom@tromey.com>
17055
17056         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17057         indentation.
17058         * python/py-frame.c (frapy_older): Remove cast.
17059         (frapy_newer): Likewise.
17060         * python/py-breakpoint.c (local_setattro): Remove cast.
17061         * python/py-arch.c (archpy_name): Remove local variable.
17062         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17063
17064 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17065
17066         * unittests/basic_string_view/element_access/char/empty.cc:
17067         Fix year range in copyright header.
17068
17069 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17070
17071         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17072         Delete.
17073         <operator==>: Update with for removed field.
17074         <hash>: Likewise.
17075         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17076         <isa_features>: ...this.
17077         <abi_features>: New field.
17078         (riscv_isa_flen): Update comment.
17079         (riscv_abi_xlen): New declaration.
17080         (riscv_abi_flen): New declaration.
17081         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17082         isa_features.
17083         (riscv_abi_xlen): New function.
17084         (riscv_isa_flen): Update to get answer from isa_features.
17085         (riscv_abi_flen): New function.
17086         (riscv_has_fp_abi): Update to get answer from abi_features.
17087         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17088         xlen and flen.
17089         (riscv_call_info) <xlen, flen>: Update comment.
17090         (riscv_call_arg_struct): Remove invalid assertions
17091         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17092         is removed.
17093         (riscv_gdbarch_init): Gather isa features and abi features
17094         separately, ensure both match on the gdbarch when reusing an old
17095         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17096         a target with 64-bit float hardware.
17097
17098 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17099
17100         * source.c (search_command_helper): Stop reverse search
17101         when line 1 has been searched.
17102
17103 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17104
17105         * record-full.c (record_full_base_target::close): Rewrite
17106         record_full_core_buf_list free logic.
17107
17108 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17109
17110         * break-catch-syscall.c (print_one_catch_syscall): xfree
17111         the last text.
17112
17113 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17114
17115         * top.c (print_gdb_version): Update Copyright year in version
17116         message.
17117
17118 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17119
17120         Update copyright year range in all GDB files.
17121
17122 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17123
17124         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17125
17126 For older changes see ChangeLog-2018.
17127 \f
17128 Local Variables:
17129 mode: change-log
17130 left-margin: 8
17131 fill-column: 74
17132 version-control: never
17133 coding: utf-8
17134 End:
17135