gdb/ChangeLog

   1 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
   2
   3         * gdbtypes.h (struct type) <remove_dyn_prop>: New method.
   4         (remove_dyn_prop): Remove.  Update all users to use
   5         type::remove_dyn_prop.
   6         * gdbtypes.c (remove_dyn_prop): Rename to...
   7         (type::remove_dyn_prop): ... this.
   8
   9 2020-05-07  Simon Marchi via Gdb-patches  <gdb-patches@sourceware.org>
  10
  11         * gdbtypes.h (struct type) <add_dyn_prop>: New method.
  12         (add_dyn_prop): Remove.  Update all users to use
  13         type::add_dyn_prop.
  14         * gdbtypes.c (add_dyn_prop): Rename to...
  15         (type::add_dyn_prop): ... this.
  16
  17 2020-05-07  Simon Marchi  <simon.marchi@efficios.com>
  18
  19         * gdbtypes.h (struct type) <get_dyn_prop>: New method.
  20         (get_dyn_prop): Remove.  Update all users to use
  21         type::dyn_prop.
  22         * gdbtypes.c (get_dyn_prop): Rename to...
  23         (type::dyn_prop): ... this.
  24
  25 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  26
  27         * gdbtypes.h (struct main_type) <flag_static>: Remove.
  28
  29 2020-05-06  Simon Marchi  <simon.marchi@efficios.com>
  30
  31         * amd64-tdep.c (amd64_analyze_prologue): Check for `endbr64`
  32         instruction, skip it if it's there.
  33
  34 2020-05-05  Simon Marchi  <simon.marchi@efficios.com>
  35
  36         * gdbtypes.h (struct main_type) <flag_incomplete>: Remove.
  37
  38 2020-05-04  Simon Marchi  <simon.marchi@efficios.com>
  39
  40         * gdbtypes.h (TYPE_INCOMPLETE): Remove.
  41         * gdbtypes.c (recursive_dump_type): Remove use of
  42         TYPE_INCOMPLETE.
  43
  44 2020-05-03  Tom Tromey  <tom@tromey.com>
  45
  46         * breakpoint.c (catch_command, tcatch_command): Remove.
  47         (_initialize_breakpoint): Use add_basic_prefix_cmd,
  48         add_show_prefix_cmd.
  49         (set_breakpoint_cmd, show_breakpoint_cmd): Remove
  50         * utils.c (set_internal_problem_cmd, show_internal_problem_cmd):
  51         Remove.
  52         (add_internal_problem_command): Use add_basic_prefix_cmd,
  53         add_show_prefix_cmd.
  54         * mips-tdep.c (set_mipsfpu_command): Remove.
  55         (_initialize_mips_tdep): Use add_basic_prefix_cmd.
  56         * dwarf2/index-cache.c (set_index_cache_command): Remove.
  57         (_initialize_index_cache): Use add_basic_prefix_cmd.
  58         * memattr.c (dummy_cmd): Remove.
  59         (_initialize_mem): Use add_basic_prefix_cmd, add_show_prefix_cmd.
  60         * tui/tui-win.c (set_tui_cmd, show_tui_cmd): Remove.
  61         (_initialize_tui_win): Use add_basic_prefix_cmd,
  62         add_show_prefix_cmd.
  63         * cli/cli-logging.c (set_logging_command): Remove.
  64         (_initialize_cli_logging): Use add_basic_prefix_cmd,
  65         add_show_prefix_cmd.
  66         (show_logging_command): Remove.
  67         * target.c (target_command): Remove.
  68         (add_target): Use add_basic_prefix_cmd.
  69
  70 2020-05-02  Hannes Domani  <ssbssa@yahoo.de>
  71
  72         * gdbtypes.h (enum dynamic_prop_node_kind): Fix typo.
  73
  74 2020-05-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  75
  76         * gdb-gdb.gdb-in: Remove breakpoint on disappeared function
  77         info_command.
  78
  79 2020-04-30  Kamil Rytarowski  <n54@gmx.com>
  80
  81         * nbsd-nat.c (nbsd_enable_proc_events)
  82         (nbsd_nat_target::post_startup_inferior): Add.
  83         (nbsd_nat_target::post_attach): Call `nbsd_enable_proc_events'.
  84         (nbsd_nat_target::update_thread_list): Rewrite.
  85         (nbsd_nat_target::wait): Handle "PTRACE_LWP_EXIT" and
  86         "PTRACE_LWP_CREATE".
  87         * nbsd-nat.h (nbsd_nat_target::post_startup_inferior): Add.
  88
  89 2020-04-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
  90
  91         * stack.c (_initialize_stack): Remove duplicated creation
  92         of "frame" command and "f" alias.
  93
  94 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
  95
  96         PR gdb/18706
  97         * gdbtypes.c (check_typedef): Calculate size of array of
  98         stubbed type.
  99
 100 2020-04-30  Hannes Domani  <ssbssa@yahoo.de>
 101
 102         PR gdb/15559
 103         * i386-tdep.c (i386_push_dummy_call): Call
 104         i386_thiscall_push_dummy_call.
 105         (i386_thiscall_push_dummy_call): New function.
 106         * i386-tdep.h (i386_thiscall_push_dummy_call): Declare.
 107         * i386-windows-tdep.c (i386_windows_push_dummy_call): New function.
 108         (i386_windows_init_abi): Call set_gdbarch_push_dummy_call.
 109
 110 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 111
 112         * gdbarch.sh (do_read): Add shellcheck disable directive for
 113         warning SC2162.
 114
 115 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 116
 117         * gdbarch.sh: Use ${foo:-} where shellcheck would report a
 118         "referenced but not assigned" warning.
 119
 120 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 121
 122         * gdbarch.sh: Remove code that sets fallbackdefault.
 123
 124 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 125
 126         * gdbarch.sh: Use shell operators && and || instead of
 127         -a and -o.
 128
 129 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 130
 131         * gdbarch.sh: Use $(...) instead of `...`.
 132
 133 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 134
 135         * gdbarch.sh: Use double quotes around variables.
 136
 137 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 138
 139         * gdbarch.sh: Use %s with printf, instead of variables in the
 140         format string.
 141
 142 2020-04-29  Tom Tromey  <tromey@adacore.com>
 143
 144         PR ada/25875:
 145         * dwarf2/read.c (update_enumeration_type_from_children): Compute
 146         type fields here.
 147         (read_enumeration_type): Call
 148         update_enumeration_type_from_children later.  Update comments.
 149         (process_enumeration_scope): Don't create type fields.
 150
 151 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 152
 153         * nbsd-tdep.c: Include "xml-syscall.h".
 154         (nbsd_init_abi): Call `set_xml_syscall_file_name'.
 155
 156 2020-04-29  Kamil Rytarowski  <n54@gmx.com>
 157
 158         * nbsd-nat.c: Include "sys/wait.h".
 159         (nbsd_resume, nbsd_nat_target::resume, nbsd_wait)
 160         (nbsd_nat_target::wait, nbsd_nat_target::insert_exec_catchpoint)
 161         (nbsd_nat_target::remove_exec_catchpoint)
 162         (nbsd_nat_target::set_syscall_catchpoint): Add.
 163         * nbsd-nat.h (nbsd_nat_target::resume, nbsd_nat_target::wait)
 164         (nbsd_nat_target::insert_exec_catchpoint)
 165         (nbsd_nat_target::remove_exec_catchpoint)
 166         (nbsd_nat_target::set_syscall_catchpoint): Add.
 167         * nbsd-tdep.c (nbsd_get_syscall_number): Add.
 168         (nbsd_init_abi): Call `set_gdbarch_get_syscall_number' and pass
 169         `nbsd_get_syscall_number'.
 170
 171 2020-04-29  Tom Tromey  <tom@tromey.com>
 172
 173         * stack.c (print_block_frame_labels): Remove.
 174
 175 2020-04-29  Hannes Domani  <ssbssa@yahoo.de>
 176
 177         PR gdb/17320
 178         * ada-valprint.c (val_print_packed_array_elements): Move array
 179         end bracket to new line.
 180         (ada_val_print_string): Remove extra spaces before first array
 181         element.
 182         * c-valprint.c (c_value_print_array): Likewise.
 183         * m2-valprint.c (m2_print_array_contents): Likewise.
 184         (m2_value_print_inner): Likewise.
 185         * p-valprint.c (pascal_value_print_inner): Likewise.
 186         * valprint.c (generic_val_print_array): Likewise.
 187         (value_print_array_elements): Move first array element and array
 188         end bracket to new line.
 189
 190 2020-04-29  Tom de Vries  <tdevries@suse.de>
 191
 192         PR symtab/25889
 193         * linespec.c (find_method): Fix ix calculation.
 194
 195 2020-04-28  Kamil Rytarowski  <n54@gmx.com>
 196
 197         * syscalls/update-netbsd.sh: New file.
 198         * syscalls/netbsd.xml: Regenerate.
 199         * data-directory/Makefile.in: Register `netbsd.xml' in
 200         `SYSCALLS_FILES'.
 201
 202 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 203
 204         * syscalls/update-freebsd.sh: Add double quotes.
 205
 206 2020-04-28  Tom Tromey  <tom@tromey.com>
 207
 208         * NEWS: Update.
 209         * python/py-cmd.c (gdbpy_initialize_commands): Add COMMAND_TUI.
 210         (cmdpy_init): Allow class_tui.
 211
 212 2020-04-28 Mark Williams <mark@myosotissp.com>
 213
 214         PR gdb/24480
 215         * dwarf2read.c: Add missing assingments to list_in_scope when
 216         start_symtab was already called.
 217
 218 2020-04-28  Simon Marchi  <simon.marchi@efficios.com>
 219
 220         PR gdb/25881
 221         * dwarf2/read.c (offset_map_type): Use
 222         gdb:hash_enum<sect_offset> as hash function.
 223
 224 2020-04-28  Tom de Vries  <tdevries@suse.de>
 225
 226         * dwarf2/read.c (process_structure_scope): Add symbol for struct decl
 227         with DW_AT_signature.
 228
 229 2020-04-27  Simon Marchi  <simon.marchi@efficios.com>
 230
 231         * configure.ac: Remove check for fs_base/gs_base in
 232         user_regs_struct.
 233         * configure: Re-generate.
 234         * config.in: Re-generate.
 235         * amd64-nat.c (amd64_native_gregset_reg_offset): Adjust.
 236         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers,
 237         amd64_linux_nat_target::store_registers, ps_get_thread_area, ): Adjust.
 238
 239 2020-04-27  Luis Machado  <luis.machado@linaro.org>
 240
 241         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Handle
 242         problematic inline frame unwinding situation.
 243         * frame.c (frame_id_computed_p): New function.
 244         * frame.h (frame_id_computed_p): New prototype.
 245
 246 2020-04-26  Tom Tromey  <tom@tromey.com>
 247
 248         * command.h (enum command_class) <class_pseudo>: Remove.
 249
 250 2020-04-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 251
 252         * cli/cli-decode.c (lookup_cmd_composition): Fix comments
 253         and whitespace.
 254
 255 2020-04-25  Kamil Rytarowski  <n54@gmx.com>
 256
 257        * inf-ptrace.c (inf_ptrace_target::wait): Remove
 258        `PT_GET_PROCESS_STATE' block.
 259
 260 2020-04-24  Tom Tromey  <tom@tromey.com>
 261
 262         * symtab.h (symbol_get_demangled_name): Don't declare.
 263         * symtab.c (symbol_get_demangled_name): Remove.
 264         (general_symbol_info::natural_name)
 265         (general_symbol_info::demangled_name): Update.
 266
 267 2020-04-24  Tom Tromey  <tom@tromey.com>
 268
 269         PR rust/25025:
 270         * dwarf2/read.c (dwarf2_physname): Do not demangle for Rust.
 271
 272 2020-04-24  Tom Tromey  <tom@tromey.com>
 273
 274         PR symtab/12707:
 275         * dwarf2/read.c (add_partial_symbol): Use the linkage name if it
 276         exists.
 277         (new_symbol): Likewise.
 278         * compile/compile-object-load.c (get_out_value_type): Use
 279         symbol_matches_search_name.
 280
 281 2020-04-24  Tom Tromey  <tom@tromey.com>
 282
 283         * dwarf2/read.c (add_partial_symbol): Do not call
 284         compute_and_set_names.
 285
 286 2020-04-24  Tom Tromey  <tom@tromey.com>
 287
 288         * dwarf2/read.c (add_partial_symbol): Use new add_psymbol_to_list
 289         overload.
 290
 291 2020-04-24  Tom Tromey  <tom@tromey.com>
 292
 293         * psymtab.c (add_psymbol_to_bcache): Simplify calling convention.
 294         (add_psymbol_to_list): New overload.  Make old overload call new
 295         one.
 296         * psympriv.h (add_psymbol_to_list): New overload.
 297
 298 2020-04-24  Tom Tromey  <tom@tromey.com>
 299
 300         * dwarf2/read.c (partial_die_info::read) <case
 301         DW_AT_linkage_name>: Use value_as_string.
 302         (dwarf2_string_attr): Use value_as_string.
 303         * dwarf2/attribute.h (struct attribute) <value_as_string>: Declare
 304         method.
 305         * dwarf2/attribute.c (attribute::value_as_string): New method.
 306
 307 2020-04-24  Tom Tromey  <tom@tromey.com>
 308
 309         * symtab.c (general_symbol_info::natural_name)
 310         (general_symbol_info::demangled_name): Check for language_rust.
 311
 312 2020-04-24  Tom Tromey  <tom@tromey.com>
 313
 314         * dwarf2/read.c (dw2_linkage_name): Move Rust "{" hack here...
 315         (dwarf2_physname): ... from here.
 316         (partial_die_info::read): Add Rust "{" hack.
 317
 318 2020-04-24  Tom Tromey  <tom@tromey.com>
 319
 320         * symtab.h (struct general_symbol_info) <set_demangled_name>: New
 321         method.
 322         (symbol_set_demangled_name): Don't declare.
 323         * symtab.c (general_symbol_info::set_demangled_name): Rename from
 324         symbol_set_demangled_name.
 325         (general_symbol_info::set_language)
 326         (general_symbol_info::compute_and_set_names): Update.
 327         * minsyms.c (minimal_symbol_reader::install): Update.
 328         * dwarf2/read.c (new_symbol): Update.
 329
 330 2020-04-24  Tom Tromey  <tromey@adacore.com>
 331
 332         PR python/23662:
 333         * python/py-type.c (convert_field): Handle
 334         FIELD_LOC_KIND_DWARF_BLOCK.
 335         (typy_get_sizeof): Handle TYPE_HAS_DYNAMIC_LENGTH.
 336         (typy_get_dynamic): Nw function.
 337         (type_object_getset): Add "dynamic".
 338         * NEWS: Add entry.
 339
 340 2020-04-24  Tom Tromey  <tromey@adacore.com>
 341
 342         * ada-typeprint.c (print_choices, print_variant_part)
 343         (print_record_field_types_dynamic): New functions.
 344         (print_record_field_types): Use print_record_field_types_dynamic.
 345
 346 2020-04-24  Tom Tromey  <tromey@adacore.com>
 347
 348         * dwarf2/read.c (handle_data_member_location): New overload.
 349         (dwarf2_add_field): Use it.
 350         (decode_locdesc): Add "computed" parameter.  Update comment.
 351         * gdbtypes.c (is_dynamic_type_internal): Also look for
 352         FIELD_LOC_KIND_DWARF_BLOCK.
 353         (resolve_dynamic_struct): Handle FIELD_LOC_KIND_DWARF_BLOCK.
 354         * gdbtypes.c (is_dynamic_type_internal): Add special case for C++
 355         virtual base classes.
 356         * gnu-v3-abi.c (gnuv3_baseclass_offset): Handle
 357         FIELD_LOC_KIND_DWARF_BLOCK.
 358
 359 2020-04-24  Tom Tromey  <tromey@adacore.com>
 360
 361         * dwarf2/read.c (read_structure_type): Handle dynamic length.
 362         * gdbtypes.c (is_dynamic_type_internal): Check
 363         TYPE_HAS_DYNAMIC_LENGTH.
 364         (resolve_dynamic_type_internal): Use TYPE_DYNAMIC_LENGTH.
 365         * gdbtypes.h (TYPE_HAS_DYNAMIC_LENGTH, TYPE_DYNAMIC_LENGTH):
 366         New macros.
 367         (enum dynamic_prop_node_kind) <DYN_PROP_BYTE_SIZE>: New
 368         constant.
 369
 370 2020-04-24  Tom Tromey  <tromey@adacore.com>
 371
 372         * dwarf2/read.c (struct variant_field): Rewrite.
 373         (struct variant_part_builder): New.
 374         (struct nextfield): Remove "variant" field.  Add "offset".
 375         (struct field_info): Add "current_variant_part" and
 376         "variant_parts".
 377         (alloc_discriminant_info): Remove.
 378         (alloc_rust_variant): New function.
 379         (quirk_rust_enum): Update.
 380         (dwarf2_add_field): Set "offset" member.  Don't handle
 381         DW_TAG_variant_part.
 382         (offset_map_type): New typedef.
 383         (convert_variant_range, create_one_variant)
 384         (create_one_variant_part, create_variant_parts)
 385         (add_variant_property): New functions.
 386         (dwarf2_attach_fields_to_type): Call add_variant_property.
 387         (read_structure_type): Don't handle DW_TAG_variant_part.
 388         (handle_variant_part, handle_variant): New functions.
 389         (handle_struct_member_die): Use them.
 390         (process_structure_scope): Don't handle variant parts.
 391         * gdbtypes.h (TYPE_FLAG_DISCRIMINATED_UNION): Remove.
 392         (struct discriminant_info): Remove.
 393         (enum dynamic_prop_node_kind) <DYN_PROP_DISCRIMINATED>: Remove.
 394         (struct main_type) <flag_discriminated_union>: Remove.
 395         * rust-lang.c (rust_enum_p, rust_empty_enum_p): Rewrite.
 396         (rust_enum_variant): Return int.  Remove "contents".  Rewrite.
 397         (rust_print_enum, rust_print_struct_def, rust_evaluate_subexp):
 398         Update.
 399         * valops.c (value_union_variant): Remove.
 400         * value.h (value_union_variant): Don't declare.
 401
 402 2020-04-24  Tom Tromey  <tromey@adacore.com>
 403
 404         * ada-lang.c (ada_discrete_type_high_bound, ada_discrete_type_low)
 405         (ada_value_primitive_packed_val): Update.
 406         * ada-valprint.c (ada_value_print_1): Update.
 407         * dwarf2/loc.c (evaluate_for_locexpr_baton): New struct.
 408         (dwarf2_locexpr_baton_eval): Take a property_addr_info rather than
 409         just an address.  Use evaluate_for_locexpr_baton.
 410         (dwarf2_evaluate_property): Update.
 411         * dwarf2/loc.h (struct property_addr_info) <valaddr>: Now an
 412         array_view.
 413         * findvar.c (default_read_var_value): Update.
 414         * gdbtypes.c (compute_variant_fields_inner)
 415         (resolve_dynamic_type_internal): Update.
 416         (resolve_dynamic_type): Change type of valaddr parameter.
 417         * gdbtypes.h (resolve_dynamic_type): Update.
 418         * valarith.c (value_subscripted_rvalue): Update.
 419         * value.c (value_from_contents_and_address): Update.
 420
 421 2020-04-24  Tom Tromey  <tromey@adacore.com>
 422
 423         * dwarf2/loc.c (dwarf2_locexpr_baton_eval): Add
 424         "push_initial_value" parameter.
 425         (dwarf2_evaluate_property): Likewise.
 426         * dwarf2/loc.h (dwarf2_evaluate_property): Update.
 427
 428 2020-04-24  Tom Tromey  <tromey@adacore.com>
 429
 430         * gdbtypes.c (is_dynamic_type_internal): Check for variant parts.
 431         (variant::matches, compute_variant_fields_recurse)
 432         (compute_variant_fields_inner, compute_variant_fields): New
 433         functions.
 434         (resolve_dynamic_struct): Check for DYN_PROP_VARIANT_PARTS.
 435         Use resolved_type after type is made.
 436         (operator==): Add new cases.
 437         * gdbtypes.h (TYPE_HAS_VARIANT_PARTS): New macro.
 438         (struct discriminant_range, struct variant, struct variant_part):
 439         New.
 440         (union dynamic_prop_data) <variant_parts, original_type>: New
 441         members.
 442         (enum dynamic_prop_node_kind) <DYN_PROP_VARIANT_PARTS>: New constant.
 443         (enum dynamic_prop_kind) <PROP_TYPE, PROP_VARIANT_PARTS>: New
 444         constants.
 445         * value.c (unpack_bits_as_long): Now public.
 446         * value.h (unpack_bits_as_long): Declare.
 447
 448 2020-04-24  Tom Tromey  <tromey@adacore.com>
 449
 450         * rs6000-tdep.c (struct ppc_variant): Rename from "variant".
 451         (variants, find_variant_by_arch, rs6000_gdbarch_init): Update.
 452
 453 2020-04-24  Hannes Domani  <ssbssa@yahoo.de>
 454
 455         * windows-tdep.c (exception_values): Add WOW64 exception numbers.
 456
 457 2020-04-24  Kamil Rytarowski  <n54@gmx.com>
 458
 459         * inf-ptrace.h (follow_fork, insert_fork_catchpoint)
 460         (remove_fork_catchpoint, post_startup_inferior)
 461         (post_attach): Move...
 462         * obsd-nat.h (follow_fork, insert_fork_catchpoint)
 463         (remove_fork_catchpoint, post_startup_inferior)
 464         (post_attach): ...here.
 465         * inf-ptrace.c (follow_fork, insert_fork_catchpoint)
 466         (remove_fork_catchpoint, post_startup_inferior)
 467         (post_attach): Move...
 468         * obsd-nat.c (follow_fork, insert_fork_catchpoint)
 469         (remove_fork_catchpoint, post_startup_inferior)
 470         (post_attach): ...here.
 471
 472 2020-04-24  Tom Tromey  <tromey@adacore.com>
 473
 474         * nat/windows-nat.h (struct windows_thread_info)
 475         <pc_adjusted>: New member.
 476         * windows-nat.c (windows_fetch_one_register): Check
 477         pc_adjusted.
 478         (windows_nat_target::get_windows_debug_event)
 479         (windows_nat_target::wait): Set pc_adjusted.
 480
 481 2020-04-24  Tom de Vries  <tdevries@suse.de>
 482
 483         * contrib/cc-with-tweaks.sh: Remove <exec>.gdb-index file handling.
 484         Run gdb-add-index inside temp dir.
 485
 486 2020-04-23  Tom Tromey  <tromey@adacore.com>
 487
 488         * windows-tdep.c (is_linked_with_cygwin_dll): Always update "iter"
 489         in loop.
 490
 491 2020-04-23  Luis Machado  <luis.machado@linaro.org>
 492
 493         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first): Use
 494         get_frame_register instead of gdbarch_unwind_pc.
 495
 496 2020-04-23  Tom de Vries  <tdevries@suse.de>
 497
 498         * symtab.c (lookup_global_symbol): Prefer def over decl.
 499
 500 2020-04-23  Tom de Vries  <tdevries@suse.de>
 501
 502         PR symtab/25807
 503         * block.c (best_symbol, better_symbol): Promote to external.
 504         * block.h (best_symbol, better_symbol): Declare.
 505         * symtab.c (lookup_symbol_in_objfile_symtabs): Prefer def over
 506         decl.
 507
 508 2020-04-23  Tom Tromey  <tromey@adacore.com>
 509
 510         PR ada/25837:
 511         * dwarf2/read.c (dw2_expand_symtabs_matching_symbol): Store a
 512         "const char *", not a "const std::string &".
 513         <name_and_matcher::operator==>: Update.
 514         * unittests/lookup_name_info-selftests.c: Change type of
 515         "result".
 516
 517 2020-04-23  Tom Tromey  <tom@tromey.com>
 518
 519         * inferior.h (iterate_over_inferiors): Don't declare.
 520         * inferior.c (iterate_over_inferiors): Remove.
 521         * darwin-nat.c (find_inferior_task_it, find_inferior_pid_it):
 522         Remove.
 523         (darwin_find_inferior_by_task, darwin_find_inferior_by_pid): Don't
 524         use iterate_over_inferiors.
 525         (darwin_resume_inferior_it)
 526         (struct resume_inferior_threads_param)
 527         (darwin_resume_inferior_threads_it): Remove.
 528         (darwin_nat_target::resume): Don't use iterate_over_inferiors.
 529
 530 2020-04-23  Tom de Vries  <tdevries@suse.de>
 531
 532         * blockframe.c (find_pc_partial_function): Use
 533         find_pc_sect_compunit_symtab rather than
 534         objfile->sf->qf->find_pc_sect_compunit_symtab.
 535
 536 2020-04-22  Tom de Vries  <tdevries@suse.de>
 537
 538         PR symtab/25764
 539         * dwarf2/read.c (scan_partial_symbols): Allow external variable decls
 540         in psymtabs.
 541
 542 2020-04-22  Tom de Vries  <tdevries@suse.de>
 543
 544         PR symtab/25801
 545         * psymtab.c (psym_map_symtabs_matching_filename): Don't skip shared
 546         symtabs.
 547
 548 2020-04-22  Tom de Vries  <tdevries@suse.de>
 549
 550         PR symtab/25700
 551         * dwarf2/read.c (dwarf2_build_psymtabs_hard): Don't create psymtab for
 552         CU if already created.
 553
 554 2020-04-21  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 555
 556         * infrun.c (displaced_step_fixup): Switch to the event_thread
 557         before calling displaced_step_restore, not after.
 558
 559 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 560
 561         * record-btrace.c (record_btrace_enable_warn): Ignore thread if
 562         its inferior is not recorded by us.
 563         (record_btrace_target_open): Replace call to
 564         all_non_exited_threads () with call to current_inferior
 565         ()->non_exited_threads ().
 566         (record_btrace_target::stop_recording): Likewise.
 567         (record_btrace_target::close): Likewise.
 568         (record_btrace_target::wait): Likewise.
 569         (record_btrace_target::record_stop_replaying): Likewise.
 570
 571 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 572
 573         * btrace.c (btrace_enable): Throw an error on double enables and
 574         when enabling recording fails.
 575         (btrace_disable): Throw an error if the thread is not recorded.
 576
 577 2020-04-21  Markus Metzger  <markus.t.metzger@intel.com>
 578
 579         * record-btrace.c (record_btrace_target::fetch_registers): Forward
 580         request if we do not have a thread_info.
 581
 582 2020-04-21  Tom de Vries  <tdevries@suse.de>
 583
 584         PR gdb/25471
 585         * thread.c
 586         (scoped_restore_current_thread::scoped_restore_current_thread): Catch
 587         exception in get_frame_id.
 588
 589 2020-04-20  Tom Tromey  <tromey@adacore.com>
 590
 591         * python/python.c (struct gdbpy_event): Mark move constructor as
 592         noexcept.
 593         * python/py-tui.c (class gdbpy_tui_window_maker): Mark move
 594         constructor as noexcept.
 595         * completer.h (struct completion_result): Mark move constructor as
 596         noexcept.
 597         * completer.c (completion_result::completion_result): Use
 598         initialization style.  Don't call reset_match_list.
 599
 600 2020-04-20  Mihails Strasuns  <mihails.strasuns@intel.com>
 601
 602         * MAINTAINERS (Write After Approval): Add myself.
 603
 604 2020-04-18  Tom Tromey  <tom@tromey.com>
 605
 606         * windows-tdep.c (init_w32_command_list)
 607         (w32_prefix_command_valid): Restore.
 608         (_initialize_windows_tdep): Call init_w32_command_list.
 609
 610 2020-04-18  Tom Tromey  <tom@tromey.com>
 611
 612         * xcoffread.c (enter_line_range, scan_xcoff_symtab): Update.
 613         * value.c (value_fn_field): Update.
 614         * valops.c (find_function_in_inferior)
 615         (value_allocate_space_in_inferior): Update.
 616         * tui/tui-winsource.c (tui_update_source_windows_with_line):
 617         Update.
 618         * tui/tui-source.c (tui_source_window::set_contents): Update.
 619         * symtab.c (lookup_global_or_static_symbol)
 620         (find_function_start_sal_1, skip_prologue_sal)
 621         (print_msymbol_info, find_gnu_ifunc, symbol_arch): Update.
 622         * symmisc.c (dump_msymbols, dump_symtab_1)
 623         (maintenance_print_one_line_table): Update.
 624         * symfile.c (init_entry_point_info, section_is_mapped)
 625         (list_overlays_command, simple_read_overlay_table)
 626         (simple_overlay_update_1): Update.
 627         * stap-probe.c (handle_stap_probe): Update.
 628         * stabsread.c (dbx_init_float_type, define_symbol)
 629         (read_one_struct_field, read_enum_type, read_range_type): Update.
 630         * source.c (info_line_command): Update.
 631         * python/python.c (gdbpy_source_objfile_script)
 632         (gdbpy_execute_objfile_script): Update.
 633         * python/py-type.c (save_objfile_types): Update.
 634         * python/py-objfile.c (py_free_objfile): Update.
 635         * python/py-inferior.c (python_new_objfile): Update.
 636         * psymtab.c (psym_find_pc_sect_compunit_symtab, dump_psymtab)
 637         (dump_psymtab_addrmap_1, maintenance_info_psymtabs)
 638         (maintenance_check_psymtabs): Update.
 639         * printcmd.c (info_address_command): Update.
 640         * objfiles.h (struct objfile) <arch>: New method, from
 641         get_objfile_arch.
 642         (get_objfile_arch): Don't declare.
 643         * objfiles.c (get_objfile_arch): Remove.
 644         (filter_overlapping_sections): Update.
 645         * minsyms.c (msymbol_is_function): Update.
 646         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines)
 647         (output_nondebug_symbol): Update.
 648         * mdebugread.c (parse_symbol, basic_type, parse_partial_symbols)
 649         (mdebug_expand_psymtab): Update.
 650         * machoread.c (macho_add_oso_symfile): Update.
 651         * linux-tdep.c (linux_infcall_mmap, linux_infcall_munmap):
 652         Update.
 653         * linux-fork.c (checkpoint_command): Update.
 654         * linespec.c (convert_linespec_to_sals): Update.
 655         * jit.c (finalize_symtab): Update.
 656         * infrun.c (insert_exception_resume_from_probe): Update.
 657         * ia64-tdep.c (ia64_find_unwind_table): Update.
 658         * hppa-tdep.c (internalize_unwinds): Update.
 659         * gdbtypes.c (get_type_arch, init_float_type, objfile_type):
 660         Update.
 661         * gcore.c (call_target_sbrk): Update.
 662         * elfread.c (record_minimal_symbol, elf_symtab_read)
 663         (elf_rel_plt_read, elf_gnu_ifunc_record_cache)
 664         (elf_gnu_ifunc_resolve_by_got): Update.
 665         * dwarf2/read.c (create_addrmap_from_index)
 666         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
 667         (read_debug_names_from_section)
 668         (process_psymtab_comp_unit_reader, add_partial_symbol)
 669         (add_partial_subprogram, process_full_comp_unit)
 670         (read_file_scope, read_func_scope, read_lexical_block_scope)
 671         (read_call_site_scope, dwarf2_ranges_read)
 672         (dwarf2_record_block_ranges, dwarf2_add_field)
 673         (mark_common_block_symbol_computed, read_tag_pointer_type)
 674         (read_tag_string_type, dwarf2_init_float_type)
 675         (dwarf2_init_complex_target_type, read_base_type)
 676         (partial_die_info::read, partial_die_info::read)
 677         (read_attribute_value, dwarf_decode_lines_1, new_symbol)
 678         (dwarf2_fetch_die_loc_sect_off): Update.
 679         * dwarf2/loc.c (dwarf2_find_location_expression)
 680         (class dwarf_evaluate_loc_desc, rw_pieced_value)
 681         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval)
 682         (dwarf2_loc_desc_get_symbol_read_needs)
 683         (locexpr_describe_location_piece, locexpr_describe_location_1)
 684         (loclist_describe_location): Update.
 685         * dwarf2/index-write.c (write_debug_names): Update.
 686         * dwarf2/frame.c (dwarf2_build_frame_info): Update.
 687         * dtrace-probe.c (dtrace_process_dof): Update.
 688         * dbxread.c (read_dbx_symtab, dbx_end_psymtab)
 689         (process_one_symbol): Update.
 690         * ctfread.c (ctf_init_float_type, read_base_type): Update.
 691         * coffread.c (coff_symtab_read, enter_linenos, decode_base_type)
 692         (coff_read_enum_type): Update.
 693         * cli/cli-cmds.c (edit_command, list_command): Update.
 694         * buildsym.c (buildsym_compunit::finish_block_internal): Update.
 695         * breakpoint.c (create_overlay_event_breakpoint)
 696         (create_longjmp_master_breakpoint)
 697         (create_std_terminate_master_breakpoint)
 698         (create_exception_master_breakpoint, get_sal_arch): Update.
 699         * block.c (block_gdbarch): Update.
 700         * annotate.c (annotate_source_line): Update.
 701
 702 2020-04-17  Tom Tromey  <tromey@adacore.com>
 703
 704         * auto-load.c (show_auto_load_cmd): Remove.
 705         (auto_load_show_cmdlist_get): Use add_show_prefix_cmd.
 706         * arc-tdep.c (_initialize_arc_tdep): Use add_show_prefix_cmd.
 707         (maintenance_print_arc_command): Remove.
 708         * tui/tui-win.c (tui_command): Remove.
 709         (tui_get_cmd_list): Use add_basic_prefix_cmd.
 710         * tui/tui-layout.c (tui_layout_command): Remove.
 711         (_initialize_tui_layout): Use add_basic_prefix_cmd.
 712         * python/python.c (user_set_python, user_show_python): Remove.
 713         (_initialize_python): Use add_basic_prefix_cmd,
 714         add_show_prefix_cmd.
 715         * guile/guile.c (set_guile_command, show_guile_command): Remove.
 716         (install_gdb_commands): Use add_basic_prefix_cmd,
 717         add_show_prefix_cmd.
 718         (info_guile_command): Remove.
 719         * dwarf2/read.c (set_dwarf_cmd, show_dwarf_cmd): Remove.
 720         (_initialize_dwarf2_read): Use add_basic_prefix_cmd,
 721         add_show_prefix_cmd.
 722         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
 723         Remove do_set and do_show parameters.
 724         * cli/cli-style.c (set_style, show_style): Remove.
 725         (_initialize_cli_style): Use add_basic_prefix_cmd,
 726         add_show_prefix_cmd.
 727         (cli_style_option::add_setshow_commands): Remove do_set and
 728         do_show parameters.
 729         (cli_style_option::add_setshow_commands): Use
 730         add_basic_prefix_cmd, add_show_prefix_cmd.
 731         (STYLE_ADD_SETSHOW_COMMANDS): Remove macro.
 732         (set_style_name): Remove.
 733         * cli/cli-dump.c (dump_command, append_command): Remove.
 734         (srec_dump_command, ihex_dump_command, verilog_dump_command)
 735         (tekhex_dump_command, binary_dump_command)
 736         (binary_append_command): Remove.
 737         (_initialize_cli_dump): Use add_basic_prefix_cmd.
 738         * windows-tdep.c (w32_prefix_command_valid): Remove global.
 739         (init_w32_command_list): Remove; move into ...
 740         (_initialize_windows_tdep): ... here.  Use add_basic_prefix_cmd.
 741         * valprint.c (set_print, show_print, set_print_raw)
 742         (show_print_raw): Remove.
 743         (_initialize_valprint): Use add_basic_prefix_cmd,
 744         add_show_prefix_cmd.
 745         * typeprint.c (set_print_type, show_print_type): Remove.
 746         (_initialize_typeprint): Use add_basic_prefix_cmd,
 747         add_show_prefix_cmd.
 748         * record.c (set_record_command, show_record_command): Remove.
 749         (_initialize_record): Use add_basic_prefix_cmd,
 750         add_show_prefix_cmd.
 751         * cli/cli-cmds.c (_initialize_cli_cmds): Use add_basic_prefix_cmd,
 752         add_show_prefix_cmd.
 753         (info_command, show_command, set_debug, show_debug): Remove.
 754         * top.h (set_history, show_history): Don't declare.
 755         * top.c (set_history, show_history): Remove.
 756         * target-descriptions.c (set_tdesc_cmd, show_tdesc_cmd)
 757         (unset_tdesc_cmd): Remove.
 758         (_initialize_target_descriptions): Use add_basic_prefix_cmd,
 759         add_show_prefix_cmd.
 760         * symtab.c (info_module_command): Remove.
 761         (_initialize_symtab): Use add_basic_prefix_cmd.
 762         * symfile.c (overlay_command): Remove.
 763         (_initialize_symfile): Use add_basic_prefix_cmd.
 764         * sparc64-tdep.c (info_adi_command): Remove.
 765         (_initialize_sparc64_adi_tdep): Use add_basic_prefix_cmd.
 766         * sh-tdep.c (show_sh_command, set_sh_command): Remove.
 767         (_initialize_sh_tdep): Use add_basic_prefix_cmd,
 768         add_show_prefix_cmd.
 769         * serial.c (serial_set_cmd, serial_show_cmd): Remove.
 770         (_initialize_serial): Use add_basic_prefix_cmd,
 771         add_show_prefix_cmd.
 772         * ser-tcp.c (set_tcp_cmd, show_tcp_cmd): Remove.
 773         (_initialize_ser_tcp): Use add_basic_prefix_cmd,
 774         add_show_prefix_cmd.
 775         * rs6000-tdep.c (set_powerpc_command, show_powerpc_command)
 776         (_initialize_rs6000_tdep): Use add_basic_prefix_cmd,
 777         add_show_prefix_cmd.
 778         * riscv-tdep.c (show_riscv_command, set_riscv_command)
 779         (show_debug_riscv_command, set_debug_riscv_command): Remove.
 780         (_initialize_riscv_tdep): Use add_basic_prefix_cmd,
 781         add_show_prefix_cmd.
 782         * remote.c (remote_command, set_remote_cmd): Remove.
 783         (_initialize_remote): Use add_basic_prefix_cmd.
 784         * record-full.c (set_record_full_command)
 785         (show_record_full_command): Remove.
 786         (_initialize_record_full): Use add_basic_prefix_cmd,
 787         add_show_prefix_cmd.
 788         * record-btrace.c (cmd_set_record_btrace)
 789         (cmd_show_record_btrace, cmd_set_record_btrace_bts)
 790         (cmd_show_record_btrace_bts, cmd_set_record_btrace_pt)
 791         (cmd_show_record_btrace_pt): Remove.
 792         (_initialize_record_btrace): Use add_basic_prefix_cmd,
 793         add_show_prefix_cmd.
 794         * ravenscar-thread.c (set_ravenscar_command)
 795         (show_ravenscar_command): Remove.
 796         (_initialize_ravenscar): Use add_basic_prefix_cmd,
 797         add_show_prefix_cmd.
 798         * mips-tdep.c (show_mips_command, set_mips_command)
 799         (_initialize_mips_tdep): Use add_basic_prefix_cmd,
 800         add_show_prefix_cmd.
 801         * maint.c (maintenance_command, maintenance_info_command)
 802         (maintenance_check_command, maintenance_print_command)
 803         (maintenance_set_cmd, maintenance_show_cmd): Remove.
 804         (_initialize_maint_cmds): Use add_basic_prefix_cmd,
 805         add_show_prefix_cmd.
 806         (show_per_command_cmd): Remove.
 807         * maint-test-settings.c (maintenance_set_test_settings_cmd):
 808         Remove.
 809         (maintenance_show_test_settings_cmd): Remove.
 810         (_initialize_maint_test_settings): Use add_basic_prefix_cmd,
 811         add_show_prefix_cmd.
 812         * maint-test-options.c (maintenance_test_options_command):
 813         Remove.
 814         (_initialize_maint_test_options): Use add_basic_prefix_cmd.
 815         * macrocmd.c (macro_command): Remove
 816         (_initialize_macrocmd): Use add_basic_prefix_cmd.
 817         * language.c (set_check, show_check): Remove.
 818         (_initialize_language): Use add_basic_prefix_cmd,
 819         add_show_prefix_cmd.
 820         * infcmd.c (unset_command): Remove.
 821         (_initialize_infcmd): Use add_basic_prefix_cmd.
 822         * i386-tdep.c (set_mpx_cmd, show_mpx_cmd): Remove.
 823         (_initialize_i386_tdep): Use add_basic_prefix_cmd,
 824         add_show_prefix_cmd.
 825         * go32-nat.c (go32_info_dos_command): Remove.
 826         (_initialize_go32_nat): Use add_basic_prefix_cmd.
 827         * cli/cli-decode.c (do_prefix_cmd, add_basic_prefix_cmd)
 828         (do_show_prefix_cmd, add_show_prefix_cmd): New functions.
 829         * frame.c (set_backtrace_cmd, show_backtrace_cmd): Remove.
 830         (_initialize_frame): Use add_basic_prefix_cmd,
 831         add_show_prefix_cmd.
 832         * dcache.c (set_dcache_command, show_dcache_command): Remove.
 833         (_initialize_dcache): Use add_basic_prefix_cmd,
 834         add_show_prefix_cmd.
 835         * cp-support.c (maint_cplus_command): Remove.
 836         (_initialize_cp_support): Use add_basic_prefix_cmd.
 837         * btrace.c (maint_btrace_cmd, maint_btrace_set_cmd)
 838         (maint_btrace_show_cmd, maint_btrace_pt_set_cmd)
 839         (maint_btrace_pt_show_cmd, _initialize_btrace): Use
 840         add_basic_prefix_cmd, add_show_prefix_cmd.
 841         * breakpoint.c (save_command): Remove.
 842         (_initialize_breakpoint): Use add_basic_prefix_cmd.
 843         * arm-tdep.c (set_arm_command, show_arm_command): Remove.
 844         (_initialize_arm_tdep): Use add_basic_prefix_cmd,
 845         add_show_prefix_cmd.
 846         * ada-lang.c (maint_set_ada_cmd, maint_show_ada_cmd)
 847         (set_ada_command, show_ada_command): Remove.
 848         (_initialize_ada_language): Use add_basic_prefix_cmd,
 849         add_show_prefix_cmd.
 850         * command.h (add_basic_prefix_cmd, add_show_prefix_cmd): Declare.
 851
 852 2020-04-16  Kamil Rytarowski  <n54@gmx.com>
 853
 854         * nbsd-nat.c (inf_ptrace_target::auxv_parse): Remove.
 855         * nbsd-nat.h (inf_ptrace_target::auxv_parse): Likewise.
 856
 857 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 858
 859         * windows-tdep.c (is_linked_with_cygwin_dll): Add filename to
 860         warning messages.
 861
 862 2020-04-16  Simon Marchi  <simon.marchi@polymtl.ca>
 863
 864         * windows-tdep.c (is_linked_with_cygwin_dll): Consider case where
 865         import table is not at beginning of .idata section.
 866
 867 2020-04-16  Pedro Alves  <palves@redhat.com>
 868
 869         * inferior.c (delete_inferior): Use delete operator directly
 870         instead of delete_program_space.
 871         * progspace.c (add_program_space): New, factored out from
 872         program_space::program_space.
 873         (remove_program_space): New, factored out from
 874         delete_program_space.
 875         (program_space::program_space): Remove intro comment.  Rewrite.
 876         (program_space::~program_space): Remove intro comment.  Call
 877         remove_program_space.
 878         (delete_program_space): Delete.
 879         * progspace.h (program_space::program_space): Make explicit.  Move
 880         intro comment here, adjusted.
 881         (program_space::~program_space): Move intro comment here,
 882         adjusted.
 883         (delete_program_space): Remove.
 884
 885 2020-04-16  Tom Tromey  <tromey@adacore.com>
 886
 887         * windows-nat.c (windows_nat::handle_access_violation): New
 888         function.
 889         * nat/windows-nat.h (handle_access_violation): Declare.
 890         * nat/windows-nat.c (handle_exception): Move Cygwin code to
 891         windows-nat.c.  Call handle_access_violation.
 892
 893 2020-04-16  Tom de Vries  <tdevries@suse.de>
 894
 895         PR symtab/25791
 896         * dwarf2/index-write.c (write_gdbindex): Generate CU table entries for
 897         CUs without psymtab.
 898
 899 2020-04-16  Kevin Buettner  <kevinb@redhat.com>
 900
 901         * python/python.c (do_start_initialization): Don't call
 902         PyEval_InitThreads for Python 3.9 and beyond.
 903
 904 2020-04-15  Kamil Rytarowski  <n54@gmx.com>
 905
 906         * obsd-nat.c (obsd_nat_target::update_thread_list): Pass "this" to
 907         thread functions.
 908         (obsd_nat_target::wait): Likewise.
 909
 910 2020-04-15  Tom Tromey  <tromey@adacore.com>
 911
 912         * windows-nat.c (DEBUG_EXEC, DEBUG_EVENTS, DEBUG_MEM)
 913         (DEBUG_EXCEPT): Use debug_printf.
 914
 915 2020-04-15  Andrew Burgess  <andrew.burgess@embecosm.com>
 916
 917         * completer.c (class completion_tracker::completion_hash_entry)
 918         <hash_name>: New member function.
 919         (completion_tracker::discard_completions): New callback to hash a
 920         completion_hash_entry, pass this to htab_create_alloc.
 921
 922 2016-01-20  Jon Turney  <jon.turney@dronecode.org.uk>
 923
 924         * windows-nat.c (windows_make_so): Warn rather than stopping with
 925         an error if realpath() fails.
 926
 927 2020-04-14  Kamil Rytarowski  <n54@gmx.com>
 928
 929         * nbsd-nat.c (nbsd_pid_to_kinfo_proc2): New.
 930         (nbsd_nat_target::info_proc): Add do_status.
 931
 932 2020-04-14  Simon Marchi  <simon.marchi@polymtl.ca>
 933             Tom de Vries  <tdevries@suse.de>
 934
 935         PR symtab/25718
 936         * psympriv.h (struct partial_symtab::read_symtab)
 937         (struct partial_symtab::expand_psymtab)
 938         (struct partial_symtab::read_dependencies): Update comments.
 939         * dwarf2/read.c (struct dwarf2_include_psymtab::read_symtab): Call
 940         read_symtab for includer.
 941         (struct dwarf2_include_psymtab::expand_psymtab): Assert false.
 942         (struct dwarf2_include_psymtab::readin_p): Call readin_p () for includer.
 943         (struct dwarf2_include_psymtab::m_readin): Remove.
 944         (struct dwarf2_include_psymtab::includer): New member function.
 945         (dwarf2_psymtab::expand_psymtab): Assert !readin.
 946
 947 2020-04-14  Tom de Vries  <tdevries@suse.de>
 948
 949         PR symtab/25720
 950         * symmisc.c (maintenance_expand_symtabs): Call expand_symtabs_matching
 951         with NULL symbol_matcher and lookup_name.
 952         * psymtab.c (psym_expand_symtabs_matching): Handle NULL symbol_matcher
 953         and lookup_name.
 954         * dwarf2/read.c (dw2_expand_symtabs_matching)
 955         (dw2_debug_names_expand_symtabs_matching): Same.
 956         * symfile.h (struct quick_symbol_functions::expand_symtabs_matching):
 957         Make lookup_name a pointer.  Update comment.
 958         * symtab.c (global_symbol_searcher::expand_symtabs): Handle
 959         lookup_name being a pointer.
 960         * symfile.c (expand_symtabs_matching): Same.
 961         * symfile-debug.c (debug_qf_expand_symtabs_matching): Same.
 962         * linespec.c (iterate_over_all_matching_symtabs): Same.
 963
 964 2020-04-13  Tom Tromey  <tom@tromey.com>
 965
 966         * run-on-main-thread.c: Update include.
 967         * unittests/main-thread-selftests.c: Update include.
 968         * tui/tui-win.c: Update include.
 969         * tui/tui-io.c: Update include.
 970         * tui/tui-interp.c: Update include.
 971         * tui/tui-hooks.c: Update include.
 972         * top.h: Update include.
 973         * top.c: Update include.
 974         * ser-base.c: Update include.
 975         * remote.c: Update include.
 976         * remote-notif.c: Update include.
 977         * remote-fileio.c: Update include.
 978         * record-full.c: Update include.
 979         * record-btrace.c: Update include.
 980         * python/python.c: Update include.
 981         * posix-hdep.c: Update include.
 982         * mingw-hdep.c: Update include.
 983         * mi/mi-main.c: Update include.
 984         * mi/mi-interp.c: Update include.
 985         * main.c: Update include.
 986         * linux-nat.c: Update include.
 987         * interps.c: Update include.
 988         * infrun.c: Update include.
 989         * inf-loop.c: Update include.
 990         * event-top.c: Update include.
 991         * event-loop.c: Move to ../gdbsupport/.
 992         * event-loop.h: Move to ../gdbsupport/.
 993         * async-event.h: Update include.
 994         * Makefile.in (COMMON_SFILES, HFILES_NO_SRCDIR): Update.
 995
 996 2020-04-13  Tom Tromey  <tom@tromey.com>
 997
 998         * tui/tui-win.c: Include async-event.h.
 999         * remote.c: Include async-event.h.
1000         * remote-notif.c: Include async-event.h.
1001         * record-full.c: Include async-event.h.
1002         * record-btrace.c: Include async-event.h.
1003         * infrun.c: Include async-event.h.
1004         * event-top.c: Include async-event.h.
1005         * event-loop.h: Move some declarations to async-event.h.
1006         * event-loop.c: Don't include ser-event.h or top.h.  Move some
1007         code to async-event.c.
1008         * async-event.h: New file.
1009         * async-event.c: New file.
1010         * Makefile.in (COMMON_SFILES): Add async-event.c.
1011         (HFILES_NO_SRCDIR): Add async-event.h.
1012
1013 2020-04-13  Tom Tromey  <tom@tromey.com>
1014
1015         * utils.c (flush_streams): New function.
1016         * event-loop.c (gdb_wait_for_event): Call flush_streams.
1017
1018 2020-04-13  Tom Tromey  <tom@tromey.com>
1019
1020         * event-loop.c (handle_file_event): Use warning, not
1021         printf_unfiltered.
1022
1023 2020-04-13  Tom Tromey  <tom@tromey.com>
1024
1025         * event-loop.c: Include <chrono>.
1026
1027 2020-04-13  Tom Tromey  <tom@tromey.com>
1028
1029         * gdb_select.h: Move to ../gdbsupport/.
1030         * event-loop.c: Update include path.
1031         * top.c: Update include path.
1032         * ser-base.c: Update include path.
1033         * ui-file.c: Update include path.
1034         * ser-tcp.c: Update include path.
1035         * guile/scm-ports.c: Update include path.
1036         * posix-hdep.c: Update include path.
1037         * ser-unix.c: Update include path.
1038         * gdb_usleep.c: Update include path.
1039         * mingw-hdep.c: Update include path.
1040         * inflow.c: Update include path.
1041         * infrun.c: Update include path.
1042         * event-top.c: Update include path.
1043
1044 2020-04-13  Tom Tromey  <tom@tromey.com>
1045
1046         * configure: Rebuild.
1047         * configure.ac: Remove checks that are now in GDB_AC_COMMON.
1048
1049 2020-04-13  Tom Tromey  <tom@tromey.com>
1050
1051         * event-loop.h (start_event_loop): Don't declare.
1052         * event-loop.c (start_event_loop): Move...
1053         * main.c (start_event_loop): ...here.  Now static.
1054
1055 2020-04-13  Sergio Durigan Junior  <sergiodj@sergiodj.net>
1056
1057         * MAINTAINERS: Update my email address.
1058
1059 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1060
1061         * nbsd-nat.c (nbsd_nat_target::info_proc): Add IP_MINIMAL and
1062         IP_ALL.
1063
1064 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1065
1066         * nbsd-nat.c (nbsd_pid_to_cmdline): Add.
1067         (nbsd_nat_target::info_proc): Add do_cmdline.
1068
1069 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1070
1071         * nbsd-nat.c (nbsd_pid_to_cwd): Add.
1072         (nbsd_nat_target::info_proc): Add do_cwd.
1073
1074 2020-04-12  Kamil Rytarowski  <n54@gmx.com>
1075
1076         * nbsd-nat.c (nbsd_nat_target::info_proc): Add do_exe.
1077
1078 2020-04-11  Kamil Rytarowski  <n54@gmx.com>
1079
1080         * nbsd-nat.c; Include "nbsd-tdep.h" and "gdbarch.h".
1081         * nbsd-nat.c (nbsd_nat_target::find_memory_regions)
1082         (nbsd_nat_target::info_proc): New functions.
1083         * nbsd-nat.c (kinfo_get_vmmap): New function.
1084         * nbsd-nat.c (nbsd_nat_target::info_proc) Use
1085         nbsd_info_proc_mappings_header and nbsd_info_proc_mappings_entry.
1086         * nbsd-tdep.c (nbsd_info_proc_mappings_header)
1087         (nbsd_info_proc_mappings_entry, nbsd_vm_map_entry_flags): New
1088         functions.
1089         * nbsd-tdep.c (KINFO_VME_PROT_READ, KINFO_VME_PROT_WRITE)
1090         (KINFO_VME_PROT_EXEC, KINFO_VME_FLAG_COW)
1091         (KINFO_VME_FLAG_NEEDS_COPY, KINFO_VME_FLAG_NOCOREDUMP)
1092         (KINFO_VME_FLAG_PAGEABLE, KINFO_VME_FLAG_GROWS_UP)
1093         (KINFO_VME_FLAG_GROWS_DOWN): New.
1094
1095 2020-04-10  Artur Shepilko  <nomadbyte@gmail.com>
1096
1097         * utils.c (copy_bitwise): Use unsigned 0 constant as operand of
1098         bit shift.
1099
1100 2020-04-10  Tom Tromey  <tromey@adacore.com>
1101
1102         * symfile.c (symbol_file_add_separate): Preserve OBJF_MAINLINE.
1103
1104 2020-04-10  Tom Tromey  <tromey@adacore.com>
1105
1106         * symtab.c (get_symbol_address, get_msymbol_address): Skip
1107         separate debug files.
1108
1109 2020-04-10  Hannes Domani  <ssbssa@yahoo.de>
1110
1111         * nat/windows-nat.c (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1112         Move to...
1113         * nat/windows-nat.h (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP):
1114         ... here.
1115         * windows-nat.c (windows_nat_target::get_windows_debug_event):
1116         Check for STATUS_WX86_BREAKPOINT.
1117         (windows_nat_target::wait): Same.
1118
1119 2020-04-10  Tom de Vries  <tdevries@suse.de>
1120
1121         PR cli/25808
1122         * python/lib/gdb/__init__.py: Initialize lexer with stripnl=False.
1123
1124 2020-04-09  Simon Marchi  <simon.marchi@polymtl.ca>
1125
1126         * MAINTAINERS (Global Maintainers): Add Tom de Vries.
1127         (Write After Approval): Remove Tom de Vries.
1128
1129 2020-04-09  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1130
1131         revert partially:
1132         2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1133
1134         * buildsym.c (record_line): Fix undefined behavior and preserve
1135         lines at eof.
1136
1137 2020-04-09  Kamil Rytarowski  <n54@gmx.com>
1138
1139         * auxv.h (svr4_auxv_parse): New.
1140         * auxv.c (default_auxv_parse): Split into default_auxv_parse
1141         and generic_auxv_parse.
1142         (svr4_auxv_parse): Add.
1143         * obsd-tdep.c: Include "auxv.h".
1144         (obsd_auxv_parse): Remove.
1145         (obsd_init_abi): Remove comment.
1146         (obsd_init_abi): Change set_gdbarch_auxv_parse passed argument
1147         from `obsd_auxv_parse' to `svr4_auxv_parse'.
1148         * nbsd-tdep.c: Include "auxv.h".
1149         (nbsd_init_abi): Call set_gdbarch_auxv_parse.
1150
1151 2020-04-08  Tom Tromey  <tromey@adacore.com>
1152
1153         * nat/windows-nat.h (last_wait_event): Don't declare.
1154         (wait_for_debug_event): Update comment.
1155         * nat/windows-nat.c (last_wait_event): Now static.
1156
1157 2020-04-08  Tom Tromey  <tromey@adacore.com>
1158
1159         * windows-nat.c (wait_for_debug_event): Move to
1160         nat/windows-nat.c.
1161         * nat/windows-nat.h (wait_for_debug_event): Declare.
1162         * nat/windows-nat.c (wait_for_debug_event): Move from
1163         windows-nat.c.  No longer static.
1164
1165 2020-04-08  Tom Tromey  <tromey@adacore.com>
1166
1167         * windows-nat.c (get_windows_debug_event): Use
1168         fetch_pending_stop.
1169         * nat/windows-nat.h (fetch_pending_stop): Declare.
1170         * nat/windows-nat.c (fetch_pending_stop): New function.
1171
1172 2020-04-08  Tom Tromey  <tromey@adacore.com>
1173
1174         * windows-nat.c (windows_continue): Use matching_pending_stop and
1175         continue_last_debug_event.
1176         * nat/windows-nat.h (matching_pending_stop)
1177         (continue_last_debug_event): Declare.
1178         * nat/windows-nat.c (DEBUG_EVENTS): New define.
1179         (matching_pending_stop, continue_last_debug_event): New
1180         functions.
1181
1182 2020-04-08  Tom Tromey  <tromey@adacore.com>
1183
1184         * windows-nat.c (MS_VC_EXCEPTION): Move to nat/windows-nat.c.
1185         (handle_exception_result): Move to nat/windows-nat.h.
1186         (DEBUG_EXCEPTION_SIMPLE): Remove.
1187         (windows_nat::handle_ms_vc_exception): New function.
1188         (handle_exception): Move to nat/windows-nat.c.
1189         (get_windows_debug_event): Update.
1190         (STATUS_WX86_BREAKPOINT, STATUS_WX86_SINGLE_STEP): Move to
1191         nat/windows-nat.c.
1192         * nat/windows-nat.h (handle_ms_vc_exception): Declare.
1193         (handle_exception_result): Move from windows-nat.c.
1194         (handle_exception): Declare.
1195         * nat/windows-nat.c (MS_VC_EXCEPTION, handle_exception)
1196         (STATUS_WX86_SINGLE_STEP, STATUS_WX86_BREAKPOINT): Move from
1197         windows-nat.c.
1198
1199 2020-04-08  Tom Tromey  <tromey@adacore.com>
1200
1201         * windows-nat.c (exception_count, event_count): Remove.
1202         (handle_exception, get_windows_debug_event)
1203         (do_initial_windows_stuff): Update.
1204
1205 2020-04-08  Tom Tromey  <tromey@adacore.com>
1206
1207         * windows-nat.c (windows_nat::handle_load_dll)
1208         (windows_nat::handle_unload_dll): Rename.  No longer static.
1209         * nat/windows-nat.h (handle_load_dll, handle_unload_dll):
1210         Declare.
1211
1212 2020-04-08  Tom Tromey  <tromey@adacore.com>
1213
1214         * complaints.h (stop_whining): Declare at top-level.
1215         (complaint): Don't declare stop_whining.
1216
1217 2020-04-08  Tom Tromey  <tromey@adacore.com>
1218
1219         * windows-nat.c (windows_nat::handle_output_debug_string):
1220         Rename.  No longer static.
1221         * nat/windows-nat.h (handle_output_debug_string): Declare.
1222
1223 2020-04-08  Tom Tromey  <tromey@adacore.com>
1224
1225         * windows-nat.c (current_process_handle, current_process_id)
1226         (main_thread_id, last_sig, current_event, last_wait_event)
1227         (current_windows_thread, desired_stop_thread_id, pending_stops)
1228         (struct pending_stop, siginfo_er): Move to nat/windows-nat.c.
1229         (display_selectors, fake_create_process)
1230         (get_windows_debug_event): Update.
1231         * nat/windows-nat.h (current_process_handle, current_process_id)
1232         (main_thread_id, last_sig, current_event, last_wait_event)
1233         (current_windows_thread, desired_stop_thread_id, pending_stops)
1234         (struct pending_stop, siginfo_er): Move from windows-nat.c.
1235         * nat/windows-nat.c (current_process_handle, current_process_id)
1236         (main_thread_id, last_sig, current_event, last_wait_event)
1237         (current_windows_thread, desired_stop_thread_id, pending_stops)
1238         (siginfo_er): New globals.  Move from windows-nat.c.
1239
1240 2020-04-08  Tom Tromey  <tromey@adacore.com>
1241
1242         * windows-nat.c (get_image_name): Move to nat/windows-nat.c.
1243         (handle_load_dll): Update.
1244         * nat/windows-nat.c (get_image_name): Move from windows-nat.c.
1245
1246 2020-04-08  Tom Tromey  <tromey@adacore.com>
1247
1248         * windows-nat.c (enum thread_disposition_type): Move to
1249         nat/windows-nat.h.
1250         (windows_nat::thread_rec): Rename from thread_rec.  No longer
1251         static.
1252         (windows_add_thread, windows_nat_target::fetch_registers)
1253         (windows_nat_target::store_registers, handle_exception)
1254         (windows_nat_target::resume, get_windows_debug_event)
1255         (windows_nat_target::get_tib_address)
1256         (windows_nat_target::thread_name)
1257         (windows_nat_target::thread_alive): Update.
1258         * nat/windows-nat.h (enum thread_disposition_type): Move from
1259         windows-nat.c.
1260         (thread_rec): Declare.
1261
1262 2020-04-08  Tom Tromey  <tromey@adacore.com>
1263
1264         * windows-nat.c: Add "using namespace".
1265         * nat/windows-nat.h: Wrap contents in windows_nat namespace.
1266         * nat/windows-nat.c: Wrap contents in windows_nat namespace.
1267
1268 2020-04-08  Tom Tromey  <tromey@adacore.com>
1269
1270         * nat/windows-nat.h (struct windows_thread_info): Declare
1271         destructor.
1272         * nat/windows-nat.c (~windows_thread_info): New.
1273
1274 2020-04-08  Tom Tromey  <tromey@adacore.com>
1275
1276         PR gdb/22992
1277         * windows-nat.c (current_event): Update comment.
1278         (last_wait_event, desired_stop_thread_id): New globals.
1279         (struct pending_stop): New.
1280         (pending_stops): New global.
1281         (windows_nat_target) <stopped_by_sw_breakpoint>
1282         <supports_stopped_by_sw_breakpoint>: New methods.
1283         (windows_fetch_one_register): Add assertions.  Adjust PC.
1284         (windows_continue): Handle pending stops.  Suspend other threads
1285         when stepping.  Use last_wait_event
1286         (wait_for_debug_event): New function.
1287         (get_windows_debug_event): Use wait_for_debug_event.  Handle
1288         pending stops.  Queue spurious stops.
1289         (windows_nat_target::wait): Set stopped_at_software_breakpoint.
1290         (windows_nat_target::kill): Use wait_for_debug_event.
1291         * nat/windows-nat.h (struct windows_thread_info)
1292         <stopped_at_software_breakpoint>: New field.
1293         * nat/windows-nat.c (windows_thread_info::resume): Clear
1294         stopped_at_software_breakpoint.
1295
1296 2020-04-08  Tom Tromey  <tromey@adacore.com>
1297
1298         * windows-nat.c (enum thread_disposition_type): New.
1299         (thread_rec): Replace "get_context" parameter with "disposition";
1300         change type.
1301         (windows_add_thread, windows_nat_target::fetch_registers)
1302         (windows_nat_target::store_registers, handle_exception)
1303         (windows_nat_target::resume, get_windows_debug_event)
1304         (windows_nat_target::get_tib_address)
1305         (windows_nat_target::thread_name)
1306         (windows_nat_target::thread_alive): Update.
1307
1308 2020-04-08  Tom Tromey  <tromey@adacore.com>
1309
1310         * windows-nat.c (thread_rec): Use windows_thread_info::suspend.
1311         (windows_continue): Use windows_continue::resume.
1312         * nat/windows-nat.h (struct windows_thread_info) <suspend,
1313         resume>: Declare new methods.
1314         * nat/windows-nat.c: New file.
1315         * configure.nat (NATDEPFILES): Add nat/windows-nat.o when needed.
1316
1317 2020-04-08  Tom Tromey  <tromey@adacore.com>
1318
1319         * windows-nat.c (windows_add_thread, windows_delete_thread)
1320         (windows_nat_target::fetch_registers)
1321         (windows_nat_target::store_registers, fake_create_process)
1322         (windows_nat_target::resume, windows_nat_target::resume)
1323         (get_windows_debug_event, windows_nat_target::wait)
1324         (windows_nat_target::pid_to_str)
1325         (windows_nat_target::get_tib_address)
1326         (windows_nat_target::get_ada_task_ptid)
1327         (windows_nat_target::thread_name)
1328         (windows_nat_target::thread_alive): Use lwp, not tid.
1329
1330 2020-04-08  Tom Tromey  <tromey@adacore.com>
1331
1332         * windows-nat.c (handle_exception)
1333         (windows_nat_target::thread_name): Update.
1334         * nat/windows-nat.h (windows_thread_info): Remove destructor.
1335         <name>: Now unique_xmalloc_ptr.
1336
1337 2020-04-08  Tom Tromey  <tromey@adacore.com>
1338
1339         * windows-nat.c (thread_rec)
1340         (windows_nat_target::fetch_registers): Update.
1341         * nat/windows-nat.h (struct windows_thread_info) <suspended>:
1342         Update comment.
1343         <debug_registers_changed, reload_context>: Now bool.
1344
1345 2020-04-08  Tom Tromey  <tromey@adacore.com>
1346
1347         * windows-nat.c (windows_add_thread): Use new.
1348         (windows_init_thread_list, windows_delete_thread): Use delete.
1349         (get_windows_debug_event): Update.
1350         * nat/windows-nat.h (struct windows_thread_info): Add constructor,
1351         destructor, and initializers.
1352
1353 2020-04-08  Tom Tromey  <tromey@adacore.com>
1354
1355         * windows-nat.c (struct windows_thread_info): Remove.
1356         * nat/windows-nat.h: New file.
1357
1358 2020-04-08  Tom Tromey  <tromey@adacore.com>
1359
1360         * windows-nat.c (struct windows_thread_info) <tid>: Rename from "id".
1361         (thread_rec, windows_add_thread, windows_delete_thread)
1362         (windows_continue): Update.
1363
1364 2020-04-08  Tom Tromey  <tromey@adacore.com>
1365
1366         * windows-nat.c (struct windows_thread_info): Remove typedef.
1367         (thread_head): Remove.
1368         (thread_list): New global.
1369         (thread_rec, windows_add_thread, windows_init_thread_list)
1370         (windows_delete_thread, windows_continue): Update.
1371
1372 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1373
1374         * windows-tdep.h (windows_init_abi): Add comment.
1375         (cygwin_init_abi): New declaration.
1376         * windows-tdep.c: Split signal enumeration in two, one for
1377         Windows and one for Cygwin.
1378         (windows_gdb_signal_to_target): Only deal with signal of the
1379         Windows OS ABI.
1380         (cygwin_gdb_signal_to_target): New function.
1381         (windows_init_abi): Rename to windows_init_abi_common, don't set
1382         gdb_signal_to_target gdbarch method.  Add new new function with
1383         this name.
1384         (cygwin_init_abi): New function.
1385         * amd64-windows-tdep.c (amd64_windows_init_abi_common): Add
1386         comment.  Don't call windows_init_abi.
1387         (amd64_windows_init_abi): Add comment, call windows_init_abi.
1388         (amd64_cygwin_init_abi): Add comment, call cygwin_init_abi.
1389         * i386-windows-tdep.c (i386_windows_init_abi): Rename to
1390         i386_windows_init_abi_common, don't call windows_init_abi.  Add
1391         a new function of this name.
1392         (i386_cygwin_init_abi): New function.
1393         (_initialize_i386_windows_tdep): Bind i386_cygwin_init_abi to
1394         OS ABI Cygwin.
1395
1396 2020-04-08  Simon Marchi  <simon.marchi@polymtl.ca>
1397
1398         * dwarf2/read.c (read_gdb_index_from_buffer): Remove objfile
1399         parameter.c.
1400         (dwarf2_read_gdb_index): Update.
1401
1402 2020-04-07  Kamil Rytarowski  <n54@gmx.com>
1403
1404         * nbsd-tdep.c: Include "objfiles.h".
1405         (nbsd_skip_solib_resolver): New.
1406         (nbsd_init_abi): Call set_gdbarch_skip_solib_resolver().
1407
1408 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1409
1410         * dwarf2/loc.c (loclist_describe_location): Call the function decode_debug_loclists_
1411         addresses if DWARF version is 5 or more because DW_LLE_start* or DW_LLE_offset_pair
1412         with DW_LLE_base_addressx are being emitted in DWARFv5.
1413         Add the newly added kind DW_LOC_OFFSET_PAIR also.
1414         The length of location description is an unsigned ULEB integer in DWARFv5 instead of
1415         unsigned integer.
1416
1417 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1418
1419         * dwarf2/loc.c (enum debug_loc_kind): Add a new kind DEBUG_LOC_OFFSET_PAIR.
1420         (dwarf2_find_location_expression): Call the function decode_debug_loclists_
1421         addresses if DWARF version is 5 or more. DW_LLE_start* or DW_LLE_offset_pair
1422         with DW_LLE_base_addressx are being emitted in DWARFv5 instead of DW_LLE_GNU*.
1423         Add applicable base address if the entry is DW_LLE_offset_pair from DWO.
1424         (decode_debug_loclists_addresses): Return DEBUG_LOC_OFFSET_PAIR instead of
1425         DEBUG_LOC_START_END in case of DW_LLE_offset_pair.
1426
1427
1428 2020-04-07  Nitika Achra  <Nitika.Achra@amd.com>
1429
1430         * dwarf2/read.c (cu_debug_loc_section): Added the declaration for the function.
1431         (read_loclist_index): New function definition.
1432         (lookup_loclist_base): New function definition.
1433         (read_loclist_header): New function definition.
1434         (dwarf2_cu): Add loclist_base and loclist_header field.
1435         (dwarf2_locate_dwo_sections): Handle .debug_loclists.dwo section.
1436         (read_full_die_1): Read the value of DW_AT_loclists_base.
1437         (read_attribute_reprocess): Handle DW_FORM_loclistx.
1438         (read_attribute_value): Handle DW_FORM_loclistx.
1439         (skip_one_die): Handle DW_FORM_loclistx.
1440         (loclist_header): New structure declaration.
1441         * dwarf2/attribute.c (form_is_section_offset): Handle DW_FORM_loclistx.
1442
1443 2020-04-07  Simon Marchi  <simon.marchi@polymtl.ca>
1444
1445         * dwarf2/read.h (struct dwarf2_psymtab): Remove two-parameters
1446         constructor.  Remove `addr` parameter from other constructor and
1447         add `per_cu` parameter.
1448         * dwarf2/read.c (create_partial_symtab): Update.
1449
1450 2020-04-07  Tom de Vries  <tdevries@suse.de>
1451
1452         PR symtab/25796
1453         * dwarf2/read.c (can_have_DW_AT_const_value_p): New function.
1454         (partial_die_info::fixup): Inherit has_const_value.
1455
1456 2020-04-07  Tom de Vries  <tdevries@suse.de>
1457
1458         * psymtab.c (maintenance_check_psymtabs): Skip static LOC_BLOCK
1459         symbols without address.
1460
1461 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1462
1463         * nbsd-nat.h (struct thread_info): Add forward declaration.
1464         (nbsd_nat_target::thread_alive): Add.
1465         (nbsd_nat_target::thread_name): Likewise.
1466         (nbsd_nat_target::update_thread_list): Likewise.
1467         (update_thread_list::post_attach): Likewise.
1468         (post_attach::pid_to_str): Likewise.
1469         * nbsd-nat.c: Include "gdbthread.h" and "inferior.h".
1470         (nbsd_thread_lister): Add.
1471         (nbsd_nat_target::thread_alive): Likewise.
1472         (nbsd_nat_target::thread_name): Likewise.
1473         (nbsd_add_threads): Likewise.
1474         (update_thread_list::post_attach): Likewise.
1475         (nbsd_nat_target::update_thread_list): Likewise.
1476         (post_attach::pid_to_str): Likewise.
1477
1478 2020-04-06  Tom Tromey  <tromey@adacore.com>
1479
1480         * ada-valprint.c (print_variant_part): Extract the variant field.
1481         (print_field_values): Use the field as the outer value when
1482         recursing.
1483
1484 2020-04-06  Tom Tromey  <tromey@adacore.com>
1485
1486         * sh-nbsd-tdep.c: Include nbsd-tdep.h.
1487         * ppc-nbsd-tdep.c: Include nbsd-tdep.h.
1488         * mips-nbsd-tdep.c (mipsnbsd_init_abi): Add missing ";".
1489         * arm-nbsd-tdep.c: Include nbsd-tdep.h.
1490         * hppa-nbsd-tdep.c: Include nbsd-tdep.h.
1491
1492 2020-04-06  Tom Tromey  <tromey@adacore.com>
1493
1494         * dwarf2/read.c (read_base_type) <DW_ATE_complex_float>: Handle
1495         TYPE_CODE_ERROR.
1496
1497 2020-04-06  Kamil Rytarowski  <n54@gmx.com>
1498
1499         * nbsd-tdep.c: Include "gdbarch.h".
1500         Define enum with NetBSD signal numbers.
1501         (nbsd_gdb_signal_from_target, nbsd_gdb_signal_to_target): New.
1502         * alpha-nbsd-tdep.c (alphanbsd_init_abi): Call nbsd_init_abi().
1503         * amd64-nbsd-tdep.c (amd64nbsd_init_abi): Likewise.
1504         * arm-nbsd-tdep.c (arm_netbsd_elf_init_abi): Likewise.
1505         * hppa-nbsd-tdep.c (hppanbsd_init_abi): Likewise.
1506         * i386-nbsd-tdep.c (i386nbsd_init_abi): Likewise.
1507         * mips-nbsd-tdep.c (nbsd_init_abi): Likewise.
1508         * ppc-nbsd-tdep.c (ppcnbsd_init_abi): Likewise.
1509         * sh-nbsd-tdep.c (shnbsd_init_abi): Likewise.
1510         * sparc-nbsd-tdep.c (sparc32nbsd_init_abi): Likewise.
1511         * sparc64-nbsd-tdep.c (sparc64nbsd_init_abi): Likewise.
1512         * vax-nbsd-tdep.c (vaxnbsd_elf_init_abi): Likewise.
1513
1514 2020-04-03  Hannes Domani  <ssbssa@yahoo.de>
1515
1516         PR gdb/25325
1517         * dwarf2/read.c (read_enumeration_type): Fix typed enum attributes.
1518
1519 2020-04-03  Tom Tromey  <tromey@adacore.com>
1520
1521         * dwarf2/loc.c (disassemble_dwarf_expression) <DW_OP_const_type>:
1522         Read constant block.
1523
1524 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1525
1526         * gdb_bfd.h: Include gdbsupport/byte-vector.h.
1527         (gdb_bfd_get_full_section_contents): New declaration.
1528         * gdb_bfd.c (gdb_bfd_get_full_section_contents): New function.
1529         * windows-tdep.c (is_linked_with_cygwin_dll): Use
1530         gdb_bfd_get_full_section_contents.
1531
1532 2020-04-02  Simon Marchi  <simon.marchi@polymtl.ca>
1533
1534         * exec.c (build_section_table): Replace internal_error with
1535         gdb_assert.
1536         (section_table_xfer_memory_partial): Likewise.
1537         * mdebugread.c (parse_partial_symbols): Likewise.
1538         * psymtab.c (lookup_partial_symbol): Likewise.
1539         * utils.c (wrap_here): Likewise.
1540
1541 2020-04-02  Tom Tromey  <tromey@adacore.com>
1542
1543         * f-lang.c (build_fortran_types): Use arch_type to initialize
1544         builtin_complex_s32 in the TYPE_CODE_ERROR case.
1545
1546 2020-04-02  Tom Tromey  <tromey@adacore.com>
1547
1548         * dwarf2/read.c (partial_die_info::read): Do not create a vector
1549         of attributes.
1550
1551 2020-04-02  Andrew Burgess  <andrew.burgess@embecosm.com>
1552             Bernd Edlinger <bernd.edlinger@hotmail.de>
1553             Tom Tromey  <tromey@adacore.com>
1554
1555         * buildsym.c (buildsym_compunit::record_line): Remove
1556         deduplication code.
1557
1558 2020-04-02  Tom de Vries  <tdevries@suse.de>
1559
1560         PR ada/24671
1561         * dwarf2/read.c (dw2_map_matching_symbols): Handle -readnow.
1562
1563 2020-04-02  Tom de Vries  <tdevries@suse.de>
1564
1565         * dwarf2/read.c (dwarf2_gdb_index_functions,
1566         dwarf2_debug_names_functions): Init lookup_global_symbol_language with
1567         NULL.
1568         * psymtab.c (psym_lookup_global_symbol_language): New function.
1569         (psym_functions): Init psym_lookup_global_symbol_language with
1570         psym_lookup_global_symbol_language.
1571         * symfile-debug.c (debug_sym_quick_functions): Init
1572         lookup_global_symbol_language with NULL.
1573         * symfile.c (set_initial_language): Remove fixme comment.
1574         * symfile.h (struct quick_symbol_functions): Add
1575         lookup_global_symbol_language.
1576         * symtab.c (find_quick_global_symbol_language): New function.
1577         (find_main_name): Use find_quick_global_symbol_language.
1578
1579 2020-04-01  Simon Marchi  <simon.marchi@polymtl.ca>
1580
1581         * windows-tdep.c (is_linked_with_cygwin_dll): Fix style.
1582
1583 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1584
1585         * buildsym.c (record_line): Fix undefined behavior and preserve
1586         lines at eof.
1587
1588 2020-04-01  Bernd Edlinger  <bernd.edlinger@hotmail.de>
1589
1590         * buildsym.c (record_line): Fix the resizing condition.
1591
1592 2020-04-01  Tom Tromey  <tom@tromey.com>
1593
1594         * value.h (value_literal_complex): Add comment.
1595         * valops.c (value_literal_complex): Refer to value.h.
1596
1597 2020-04-01  Tom Tromey  <tom@tromey.com>
1598
1599         * c-exp.y (FLOAT_KEYWORD, COMPLEX): New tokens.
1600         (scalar_type): New rule, from typebase.
1601         (typebase): Use scalar_type.  Recognize complex types.
1602         (field_name): Handle FLOAT_KEYWORD.
1603         (ident_tokens): Add _Complex and __complex__.
1604
1605 2020-04-01  Tom Tromey  <tom@tromey.com>
1606
1607         PR exp/25299:
1608         * valarith.c (promotion_type, complex_binop): New functions.
1609         (scalar_binop): Handle complex numbers.  Use promotion_type.
1610         (value_pos, value_neg, value_complement): Handle complex numbers.
1611
1612 2020-04-01  Tom Tromey  <tom@tromey.com>
1613
1614         * c-exp.y (COMPLEX_INT, COMPLEX_FLOAT): New tokens.
1615         (exp) <COMPLEX_INT, COMPLEX_FLOAT>: New rules.
1616         (parse_number): Handle complex numbers.
1617
1618 2020-04-01  Tom Tromey  <tom@tromey.com>
1619
1620         * c-valprint.c (c_decorations): Change complex suffix to "i".
1621
1622 2020-04-01  Tom Tromey  <tom@tromey.com>
1623
1624         * valprint.c (generic_value_print_complex): Use accessors.
1625         * value.h (value_real_part, value_imaginary_part): Declare.
1626         * valops.c (value_real_part, value_imaginary_part): New
1627         functions.
1628         * value.c (creal_internal_fn, cimag_internal_fn): Use accessors.
1629
1630 2020-04-01  Tom Tromey  <tom@tromey.com>
1631
1632         * stabsread.c (rs6000_builtin_type, read_sun_floating_type)
1633         (read_range_type): Update.
1634         * mdebugread.c (basic_type): Update.
1635         * go-lang.c (build_go_types): Use init_complex_type.
1636         * gdbtypes.h (struct main_type) <complex_type>: New member.
1637         (init_complex_type): Update.
1638         (arch_complex_type): Don't declare.
1639         * gdbtypes.c (init_complex_type): Remove "objfile" parameter.
1640         Make name if none given.  Use alloc_type_copy.  Look for cached
1641         complex type.
1642         (arch_complex_type): Remove.
1643         (gdbtypes_post_init): Use init_complex_type.
1644         * f-lang.c (build_fortran_types): Use init_complex_type.
1645         * dwarf2/read.c (read_base_type): Update.
1646         * d-lang.c (build_d_types): Use init_complex_type.
1647         * ctfread.c (read_base_type): Update.
1648
1649 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1650
1651         * infrun.c (stop_all_threads): Update assertion, plus when
1652         stopping threads, take into account that we might be trying
1653         to stop an all-stop target.
1654         (stop_waiting): Call 'stop_all_threads' if there exists a
1655         non-stop target.
1656
1657 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1658
1659         * target.h (exists_non_stop_target): New function declaration.
1660         * target.c (exists_non_stop_target): New function.
1661
1662 2020-04-01  Hannes Domani  <ssbssa@yahoo.de>
1663
1664         PR gdb/24789
1665         * eval.c (is_integral_or_integral_reference): New function.
1666         (evaluate_subexp_standard): Allow integer references in
1667         pointer arithmetic.
1668
1669 2020-04-01  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1670
1671         * remote.c (remote_target::remote_parse_stop_reply): Remove the
1672         check for no ptid in the stop reply when the target is non-stop.
1673
1674 2020-04-01  Tom Tromey  <tromey@adacore.com>
1675
1676         * symtab.h (class lookup_name_info) <lookup_name_info>: Change
1677         "name" parameter to rvalue reference.  Initialize m_name_holder.
1678         <lookup_name_info>: New overloads.
1679         <name>: Return gdb::string_view.
1680         <c_str>: New method.
1681         <make_ignore_params>: Update.
1682         <search_name_hash>: Update.
1683         <language_lookup_name>: Return const char *.
1684         <m_name>: Change type.
1685         * symtab.c (demangle_for_lookup_info::demangle_for_lookup_info)
1686         (demangle_for_lookup_info::demangle_for_lookup_info): Update.
1687         (lookup_name_info::match_any): Update.
1688         * psymtab.c (match_partial_symbol, lookup_partial_symbol):
1689         Update.
1690         * minsyms.c (linkage_name_str): Update.
1691         * language.c (default_symbol_name_matcher): Update.
1692         * dwarf2/read.c (mapped_index_base::find_name_components_bounds):
1693         Update.
1694         * ada-lang.c (ada_fold_name): Change parameter to string_view.
1695         (ada_lookup_name_info::ada_lookup_name_info): Update.
1696         (literal_symbol_name_matcher): Update.
1697
1698 2020-04-01  Tom Tromey  <tromey@adacore.com>
1699
1700         * psymtab.c (psymtab_search_name): Remove function.
1701         (psym_lookup_symbol): Create search name and lookup name here.
1702         (lookup_partial_symbol): Remove "name" parameter; add
1703         lookup_name.
1704         (psym_expand_symtabs_for_function): Update.
1705
1706 2020-03-31  Joel Jones  <joelkevinjones@gmail.com>
1707
1708         PR tui/25597:
1709         * python/py-tui.c: Include gdb_curses.h inside of #ifdef TUI.
1710
1711 2020-03-31  Tom Tromey  <tromey@adacore.com>
1712
1713         * dwarf2/abbrev.c (abbrev_table::read): Conditionally call
1714         memcpy.
1715
1716 2020-03-30  Nelson Chu  <nelson.chu@sifive.com>
1717
1718         * features/riscv/32bit-csr.xml: Regenerated.
1719         * features/riscv/64bit-csr.xml: Regenerated.
1720
1721 2020-03-30  Tom Tromey  <tromey@adacore.com>
1722
1723         * ada-valprint.c (print_variant_part): Update.
1724         * ada-lang.h (ada_which_variant_applies): Update.
1725         * ada-lang.c (ada_which_variant_applies): Remove outer_type and
1726         outer_valaddr parameters; replace with "outer" value parameter.
1727         (to_fixed_variant_branch_type): Update.
1728
1729 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1730
1731         * ppc-linux-nat.c: Include <algorithm>, <unordered_map>, and
1732         <list>.  Remove inclusion of observable.h.
1733         (PPC_DEBUG_CURRENT_VERSION): Move up define.
1734         (struct arch_lwp_info): New struct.
1735         (class ppc_linux_dreg_interface): New class.
1736         (struct ppc_linux_process_info): New struct.
1737         (struct ppc_linux_nat_target) <low_delete_thread, low_new_fork>
1738         <low_new_clone, low_forget_process, low_prepare_to_resume>
1739         <copy_thread_dreg_state, mark_thread_stale>
1740         <mark_debug_registers_changed, register_hw_breakpoint>
1741         <clear_hw_breakpoint, register_wp, clear_wp>
1742         <can_use_watchpoint_cond_accel, calculate_dvc, check_condition>
1743         <num_memory_accesses, get_trigger_type>
1744         <create_watchpoint_request, hwdebug_point_cmp>
1745         <init_arch_lwp_info, get_arch_lwp_info>
1746         <low_stopped_by_watchpoint, low_stopped_data_address>: Declare as
1747         methods.
1748         <struct ptid_hash>: New inner struct.
1749         <m_dreg_interface, m_process_info, m_installed_hw_bps>: Declare
1750         members.
1751         (saved_dabr_value, hwdebug_info, max_slots_number)
1752         (struct hw_break_tuple, struct thread_points, ppc_threads)
1753         (have_ptrace_hwdebug_interface)
1754         (hwdebug_find_thread_points_by_tid)
1755         (hwdebug_insert_point, hwdebug_remove_point): Remove.
1756         (ppc_linux_nat_target::can_use_hw_breakpoint): Use
1757         m_dreg_interface, remove call to PTRACE_SET_DEBUGREG.
1758         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Add comment,
1759         use m_dreg_interface.
1760         (hwdebug_point_cmp): Change to...
1761         (ppc_linux_nat_target::hwdebug_point_cmp): ...this method.  Use
1762         reference arguments instead of pointers.
1763         (ppc_linux_nat_target::ranged_break_num_registers): Use
1764         m_dreg_interface.
1765         (ppc_linux_nat_target::insert_hw_breakpoint): Add comment, use
1766         m_dreg_interface.  Call register_hw_breakpoint.
1767         (ppc_linux_nat_target::remove_hw_breakpoint): Add comment, use
1768         m_dreg_interface.  Call clear_hw_breakpoint.
1769         (get_trigger_type): Change to...
1770         (ppc_linux_nat_target::get_trigger_type): ...this method.  Add
1771         comment.
1772         (ppc_linux_nat_target::insert_mask_watchpoint): Update comment,
1773         use m_dreg_interface.  Call register_hw_breakpoint.
1774         (ppc_linux_nat_target::remove_mask_watchpoint): Update comment,
1775         use m_dreg_interface.  Call clear_hw_breakpoint.
1776         (can_use_watchpoint_cond_accel): Change to...
1777         (ppc_linux_nat_target::can_use_watchpoint_cond_accel): ...this
1778         method.  Update comment, use m_dreg_interface and
1779         m_process_info.
1780         (calculate_dvc): Change to...
1781         (ppc_linux_nat_target::calculate_dvc): ...this method.  Use
1782         m_dreg_interface.
1783         (num_memory_accesses): Change to...
1784         (ppc_linux_nat_target::num_memory_accesses): ...this method.
1785         (check_condition): Change to...
1786         (ppc_linux_nat_target::check_condition): ...this method.
1787         (ppc_linux_nat_target::can_accel_watchpoint_condition): Update
1788         comment, use m_dreg_interface.
1789         (create_watchpoint_request): Change to...
1790         (ppc_linux_nat_target::create_watchpoint_request): ...this
1791         method.  Use m_dreg_interface.
1792         (ppc_linux_nat_target::insert_watchpoint): Add comment, use
1793         m_dreg_interface.  Call register_hw_breakpoint or register_wp.
1794         (ppc_linux_nat_target::remove_watchpoint): Add comment, use
1795         m_dreg_interface.  Call clear_hw_breakpoint or clear_wp.
1796         (ppc_linux_nat_target::low_forget_process)
1797         (ppc_linux_nat_target::low_new_fork)
1798         (ppc_linux_nat_target::low_new_clone)
1799         (ppc_linux_nat_target::low_delete_thread)
1800         (ppc_linux_nat_target::low_prepare_to_resume): New methods.
1801         (ppc_linux_nat_target::low_new_thread): Remove previous logic,
1802         only call mark_thread_stale.
1803         (ppc_linux_thread_exit): Remove.
1804         (ppc_linux_nat_target::stopped_data_address): Change to...
1805         (ppc_linux_nat_target::low_stopped_data_address): This. Add
1806         comment, use m_dreg_interface and m_thread_hw_breakpoints.
1807         (ppc_linux_nat_target::stopped_by_watchpoint): Change to...
1808         (ppc_linux_nat_target::stopped_by_watchpoint): This.  Add
1809         comment.  Call low_stopped_data_address.
1810         (ppc_linux_nat_target::watchpoint_addr_within_range): Use
1811         m_dreg_interface.
1812         (ppc_linux_nat_target::masked_watch_num_registers): Use
1813         m_dreg_interface.
1814         (ppc_linux_nat_target::copy_thread_dreg_state)
1815         (ppc_linux_nat_target::mark_thread_stale)
1816         (ppc_linux_nat_target::mark_debug_registers_changed)
1817         (ppc_linux_nat_target::register_hw_breakpoint)
1818         (ppc_linux_nat_target::clear_hw_breakpoint)
1819         (ppc_linux_nat_target::register_wp)
1820         (ppc_linux_nat_target::clear_wp)
1821         (ppc_linux_nat_target::init_arch_lwp_info)
1822         (ppc_linux_nat_target::get_arch_lwp_info): New methods.
1823         (_initialize_ppc_linux_nat): Remove observer callback.
1824
1825 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1826
1827         * ppc-linux-nat.c (ppc_linux_nat_target::store_registers)
1828         (ppc_linux_nat_target::auxv_parse)
1829         (ppc_linux_nat_target::read_description)
1830         (supply_gregset, fill_gregset, supply_fpregset, fill_fpregset):
1831         Move up.
1832
1833 2020-03-30  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
1834
1835         * linux-nat.h (low_new_clone): New method.
1836         * linux-nat.c (linux_handle_extended_wait): Call low_new_clone.
1837
1838 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1839
1840         * dbxread.c (dbx_psymtab_to_symtab_1): Rename to...
1841         (dbx_expand_psymtab): ... this.
1842         (start_psymtab): Update.
1843         * mdebugread.c (psymtab_to_symtab_1): Rename to...
1844         (mdebug_expand_psymtab): ... this.
1845         (parse_partial_symbols): Update.
1846         (new_psymtab): Update.
1847         * xcoffread.c (xcoff_psymtab_to_symtab_1): Rename to...
1848         (xcoff_expand_psymtab): ... this.
1849         (xcoff_start_psymtab): Update.
1850
1851 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1852
1853         * psympriv.h (partial_symtab) <read_dependencies>: Rename to...
1854         <expand_dependencies>: ... this.
1855         * psymtab.c (partial_symtab::read_dependencies): Rename to...
1856         (partial_symtab::expand_dependencies): ... this.
1857         * dwarf2/read.c (dwarf2_include_psymtab) <expand_psymtab>:
1858         Update.
1859         (dwarf2_psymtab::expand_psymtab): Update.
1860         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
1861         * mdebugread.c (psymtab_to_symtab_1): Update.
1862         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
1863
1864 2020-03-29  Simon Marchi  <simon.marchi@polymtl.ca>
1865
1866         * psympriv.h (discard_psymtab): Remove.
1867         * dbxread.c (dbx_end_psymtab): Update.
1868         * xcoffread.c (xcoff_end_psymtab): Update.
1869
1870 2020-03-28  Tom Tromey  <tom@tromey.com>
1871
1872         * dwarf2/attribute.h (struct attribute) <form_is_constant>: Update
1873         comment.
1874
1875 2020-03-28  Tom Tromey  <tom@tromey.com>
1876
1877         * dwarf2/read.c (read_attribute_reprocess): Fix formatting.
1878
1879 2020-03-27  Hannes Domani  <ssbssa@yahoo.de>
1880
1881         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
1882
1883 2020-03-26  John Baldwin  <jhb@FreeBSD.org>
1884
1885         * fbsd-tdep.c (fbsd_print_auxv_entry): Handle AT_FREEBSD_BSDFLAGS.
1886
1887 2020-03-26  Tom Tromey  <tom@tromey.com>
1888
1889         * dwarf2/read.c (handle_data_member_location, dwarf2_add_field)
1890         (mark_common_block_symbol_computed, read_tag_string_type)
1891         (attr_to_dynamic_prop, read_subrange_type): Update.
1892         (dwarf2_get_ref_die_offset, dwarf2_get_attr_constant_value): Move
1893         to be methods on struct attribute.
1894         (skip_one_die, process_imported_unit_die, read_namespace_alias)
1895         (read_call_site_scope, partial_die_info::read)
1896         (partial_die_info::read, lookup_die_type, follow_die_ref):
1897         Update.
1898         * dwarf2/attribute.c (attribute::get_ref_die_offset): New method,
1899         from dwarf2_get_ref_die_offset.
1900         (attribute::constant_value): New method, from
1901         dwarf2_get_attr_constant_value.
1902         * dwarf2/attribute.h (struct attribute) <get_ref_die_offset>:
1903         Declare method.
1904         <constant_value>: New method.
1905
1906 2020-03-26  Tom Tromey  <tom@tromey.com>
1907
1908         * dwarf2/read.c (dwarf_unit_type_name, dwarf_tag_name)
1909         (dwarf_attr_name, dwarf_form_name, dwarf_bool_name)
1910         (dwarf_type_encoding_name): Move to stringify.c.
1911         * Makefile.in (COMMON_SFILES): Add dwarf2/stringify.c.
1912         * dwarf2/stringify.c: New file.
1913         * dwarf2/stringify.h: New file.
1914
1915 2020-03-26  Tom Tromey  <tom@tromey.com>
1916
1917         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>:
1918         Rewrite.
1919
1920 2020-03-26  Tom Tromey  <tom@tromey.com>
1921
1922         * dwarf2/die.h (struct die_info) <addr_base, ranges_base>: New
1923         methods.
1924         * dwarf2/read.c (lookup_addr_base): Move to die.h.
1925         (lookup_ranges_base): Likewise.
1926         (read_cutu_die_from_dwo, read_full_die_1): Update.
1927
1928 2020-03-26  Tom Tromey  <tom@tromey.com>
1929
1930         * dwarf2/read.c (read_import_statement, read_file_scope)
1931         (read_type_unit_scope, inherit_abstract_dies, read_func_scope)
1932         (read_lexical_block_scope, read_call_site_scope)
1933         (dwarf2_get_subprogram_pc_bounds, get_scope_pc_bounds)
1934         (handle_struct_member_die, process_structure_scope)
1935         (update_enumeration_type_from_children)
1936         (process_enumeration_scope, read_array_type, read_common_block)
1937         (read_namespace, read_module, read_subroutine_type): Update.
1938         (sibling_die): Remove.
1939
1940 2020-03-26  Tom Tromey  <tom@tromey.com>
1941
1942         * dwarf2/read.c (lookup_addr_base, lookup_ranges_base)
1943         (build_type_psymtabs_reader, read_structure_type)
1944         (read_enumeration_type, read_full_die_1): Update.
1945         (dwarf2_attr_no_follow): Move to die.h.
1946         * dwarf2/die.h (struct die_info) <attr>: New method.
1947
1948 2020-03-26  Tom Tromey  <tom@tromey.com>
1949
1950         * dwarf2/read.c (struct dwarf2_cu) <base_known>: Remove.
1951         <base_address>: Now an optional.
1952         (dwarf2_find_base_address, dwarf2_rnglists_process)
1953         (dwarf2_ranges_process, fill_in_loclist_baton)
1954         (dwarf2_symbol_mark_computed): Update.
1955
1956 2020-03-26  Tom Tromey  <tom@tromey.com>
1957
1958         * dwarf2/read.c (struct die_info): Move to die.h.
1959         * dwarf2/die.h: New file.
1960
1961 2020-03-26  Tom Tromey  <tom@tromey.com>
1962
1963         * dwarf2/line-header.h (dwarf_decode_line_header): Declare.
1964         * dwarf2/read.c
1965         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1966         Move to line-header.c.
1967         (read_checked_initial_length_and_offset, read_formatted_entries):
1968         Likewise.
1969         (dwarf_decode_line_header): Split into two.
1970         * dwarf2/line-header.c
1971         (dwarf2_statement_list_fits_in_line_number_section_complaint):
1972         Move from read.c.
1973         (read_checked_initial_length_and_offset, read_formatted_entries):
1974         Likewise.
1975         (dwarf_decode_line_header): New function, split from read.c.
1976
1977 2020-03-26  Tom Tromey  <tom@tromey.com>
1978
1979         * dwarf2/read.h (struct dwarf2_per_objfile) <read_line_string>:
1980         Declare method.
1981         * dwarf2/read.c (read_attribute_value): Update.
1982         (dwarf2_per_objfile::read_line_string): Rename from
1983         read_indirect_line_string.
1984         (read_formatted_entries): Update.
1985
1986 2020-03-26  Tom Tromey  <tom@tromey.com>
1987
1988         * dwarf2/macro.c (dwarf_decode_macro_bytes): Use objfile local
1989         variable.
1990
1991 2020-03-26  Tom Tromey  <tom@tromey.com>
1992
1993         * dwarf2/macro.h (dwarf_decode_macros): Make section parameter
1994         const.
1995         * dwarf2/macro.c (skip_form_bytes, skip_unknown_opcode)
1996         (dwarf_decode_macro_bytes, dwarf_decode_macros): Make section
1997         parameter const.
1998
1999 2020-03-26  Tom Tromey  <tom@tromey.com>
2000
2001         * dwarf2/read.c (dwarf_decode_macros): Make "lh" const.
2002         * dwarf2/macro.h (dwarf_decode_macros): Constify "lh" parameter.
2003         * dwarf2/macro.c (macro_start_file): Constify "lh" parameter.
2004         (dwarf_decode_macro_bytes, dwarf_decode_macros): Likewise.
2005
2006 2020-03-26  Tom Tromey  <tom@tromey.com>
2007
2008         * dwarf2/line-header.h (struct line_header) <is_valid_file_index,
2009         file_names_size, file_full_name, file_file_name>: Use const.
2010         <file_name_at, file_names>: Add const overload.
2011         * dwarf2/line-header.c (line_header::file_file_name)
2012         (line_header::file_full_name): Update.
2013
2014 2020-03-26  Tom Tromey  <tom@tromey.com>
2015
2016         * dwarf2/read.c (dwarf2_macro_malformed_definition_complaint)
2017         (macro_start_file, consume_improper_spaces)
2018         (parse_macro_definition, skip_form_bytes, skip_unknown_opcode)
2019         (dwarf_parse_macro_header, dwarf_decode_macro_bytes)
2020         (dwarf_decode_macros): Move to macro.c.
2021         * dwarf2/macro.c: New file.
2022         * dwarf2/macro.h: New file.
2023         * Makefile.in (COMMON_SFILES): Add dwarf2/macro.c.
2024
2025 2020-03-26  Tom Tromey  <tom@tromey.com>
2026
2027         * dwarf2/section.h (struct dwarf2_section_info) <read_string>: New
2028         method.
2029         * dwarf2/section.c: New method.  From
2030         read_indirect_string_at_offset_from.
2031         * dwarf2/read.c (mapped_debug_names::namei_to_name): Update.
2032         (read_indirect_string_at_offset_from): Move to section.c.
2033         (read_indirect_string_at_offset): Rewrite.
2034         (read_indirect_line_string_at_offset): Remove.
2035         (read_indirect_string, read_indirect_line_string)
2036         (dwarf_decode_macro_bytes): Update.
2037
2038 2020-03-26  Tom Tromey  <tom@tromey.com>
2039
2040         * dwarf2/section.h (struct dwarf2_section_info)
2041         <overload_complaint>: Declare.
2042         (dwarf2_section_buffer_overflow_complaint): Don't declare.
2043         * dwarf2/section.c (dwarf2_section_info::overflow_complaint):
2044         Rename from dwarf2_section_buffer_overflow_complaint.
2045         * dwarf2/read.c (skip_one_die, partial_die_info::read)
2046         (skip_form_bytes, dwarf_decode_macro_bytes): Update.
2047
2048 2020-03-26  Tom Tromey  <tom@tromey.com>
2049
2050         * dwarf2/section.h (dwarf2_section_buffer_overflow_complaint):
2051         Declare.
2052         * dwarf2/section.c (dwarf2_section_buffer_overflow_complaint):
2053         Move from read.c.
2054         * dwarf2/read.c (dwarf2_section_buffer_overflow_complaint): Move
2055         to section.c.
2056
2057 2020-03-26  Tom Tromey  <tom@tromey.com>
2058
2059         * dwarf2/read.c (dwarf_decode_macros): Split into two overloads.
2060
2061 2020-03-26  Tom Tromey  <tom@tromey.com>
2062
2063         * dwarf2/read.c (macro_start_file): Change "cu" parameter to
2064         "builder".
2065         (dwarf_decode_macro_bytes): Likewise.  Add dwarf2_per_objfile
2066         parameter.
2067         (dwarf_decode_macros): Update.
2068
2069 2020-03-26  Tom Tromey  <tom@tromey.com>
2070
2071         * dwarf2/read.c (read_attribute_value): Update.
2072         (read_indirect_string_from_dwz): Move to dwz.c; change into
2073         method.
2074         (dwarf_decode_macro_bytes): Update.
2075         * dwarf2/dwz.h (struct dwz_file) <read_string>: Declare method.
2076         * dwarf2/dwz.c: New file.
2077         * Makefile.in (COMMON_SFILES): Add dwz.c.
2078
2079 2020-03-26  Tom Tromey  <tom@tromey.com>
2080
2081         * dwarf2/read.h (struct dwz_file): Move to dwz.h.
2082         * dwarf2/read.c: Add include.
2083         * dwarf2/index-write.c: Add include.
2084         * dwarf2/index-cache.c: Add include.
2085         * dwarf2/dwz.h: New file.
2086
2087 2020-03-25  Tom Tromey  <tom@tromey.com>
2088
2089         * compile/compile-object-load.c (get_out_value_type): Mention
2090         correct symbol name in error message.
2091
2092 2020-03-25  Hannes Domani  <ssbssa@yahoo.de>
2093
2094         * windows-nat.c (windows_add_all_dlls): Fix system dll paths.
2095
2096 2020-03-25  Tom de Vries  <tdevries@suse.de>
2097
2098         * symtab.h (is_main_symtab_of_compunit_symtab): New function.
2099         * symmisc.c (dump_symtab_1): Print user and includes fields.
2100         (maintenance_info_symtabs): Same.
2101
2102 2020-03-25  Andrew Burgess  <andrew.burgess@embecosm.com>
2103
2104         PR gdb/25534
2105         * riscv-tdep.c (riscv_arg_info::c_offset): Update comment.
2106         (riscv_regcache_cooked_write): New function.
2107         (riscv_push_dummy_call): Use new function.
2108         (riscv_return_value): Likewise.
2109
2110 2020-03-24  Simon Marchi  <simon.marchi@polymtl.ca>
2111
2112         * fbsd-nat.c (fbsd_nat_target::follow_fork): Change bool to int.
2113         * fbsd-nat.h (class fbsd_nat_target) <follow_fork>: Likewise.
2114         * inf-ptrace.c (inf_ptrace_target::follow_fork): Likewise.
2115         * inf-ptrace.h (struct inf_ptrace_target) <follow_fork>: Likewise.
2116         * infrun.c (follow_fork): Likewise.
2117         (follow_fork_inferior): Likewise.
2118         * linux-nat.c (linux_nat_target::follow_fork): Likewise.
2119         * linux-nat.h (class linux_nat_target): Likewise.
2120         * remote.c (class remote_target) <follow_fork>: Likewise.
2121         (remote_target::follow_fork): Likewise.
2122         * target-delegates.c: Re-generate.
2123         * target.c (default_follow_fork): Likewise.
2124         (target_follow_fork): Likewise.
2125         * target.h (struct target_ops) <follow_fork>: Likewise.
2126         (target_follow_fork): Likewise.
2127
2128 2020-03-24  Tom de Vries  <tdevries@suse.de>
2129
2130         * psymtab.c (maintenance_info_psymtabs): Print user field.
2131
2132 2020-03-20  Tom Tromey  <tromey@adacore.com>
2133
2134         * dwarf2/loc.h (dwarf2_evaluate_property): Make "addr_stack"
2135         const.
2136         * dwarf2/loc.c (dwarf2_evaluate_property): Make "addr_stack"
2137         const.
2138
2139 2020-03-20  Simon Marchi  <simon.marchi@efficios.com>
2140
2141         * ptrace.m4: Don't check for ptrace declaration.
2142         * config.in: Re-generate.
2143         * configure: Re-generate.
2144         * nat/gdb_ptrace.h: Don't declare ptrace if HAVE_DECL_PTRACE is
2145         not defined.
2146
2147 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2148
2149         * amd64-bsd-nat.c (gdb_ptrace): Change return type from `int' to
2150         `PTRACE_TYPE_RET'.
2151         * i386-bsd-nat.c (gdb_ptrace): Likewise.
2152         * sparc-nat.c (gdb_ptrace): Likewise.
2153         * x86-bsd-nat.c (gdb_ptrace): Likewise.
2154
2155 2020-03-20  Tom Tromey  <tromey@adacore.com>
2156
2157         * c-exp.y (lex_one_token): Fix assert.
2158
2159 2020-03-20  Tom Tromey  <tromey@adacore.com>
2160
2161         * ada-tasks.c (read_atcb): Use smaller length in strncpy call.
2162         * linux-tdep.c (linux_fill_prpsinfo): Use smaller length in
2163         strncpy call.
2164
2165 2020-03-20  Tom Tromey  <tromey@adacore.com>
2166
2167         * symmisc.c (maintenance_print_one_line_table): Use ui_out.
2168
2169 2020-03-20  Tom Tromey  <tromey@adacore.com>
2170
2171         * ada-valprint.c (print_variant_part): Remove parameters; switch
2172         to value-based API.
2173         (print_field_values): Likewise.
2174         (ada_val_print_struct_union): Likewise.
2175         (ada_value_print_1): Update.
2176
2177 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2178
2179         * ppc-nbsd-nat.c (ppc_nbsd_nat_target): Inherit from
2180         nbsd_nat_target instead of inf_ptrace_target.
2181         * ppc-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2182         nbsd_nat_target.
2183
2184 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2185
2186         * hppa-nbsd-nat.c (fetch_registers): New variable lwp and pass
2187         it to the ptrace call.
2188         * (store_registers): Likewise.
2189
2190 2020-03-20  Kamil Rytarowski  <n54@gmx.com>
2191
2192         * ppc-nbsd-nat.c (fetch_registers): New variable lwp and pass
2193         it to the ptrace call.
2194         * (store_registers): Likewise.
2195
2196 2020-03-19  Luis Machado  <luis.machado@linaro.org>
2197
2198         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): If vg is not
2199         valid, fetch vg value from ptrace.
2200
2201 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2202         * inf-ptrace.h: Disable get_ptrace_pid on NetBSD.
2203         * inf-ptrace.c: Likewise.
2204         * (gdb_ptrace): Add.
2205         * (inf_ptrace_target::resume): Update.
2206         * (inf_ptrace_target::xfer_partial): Likewise.
2207         * (inf_ptrace_peek_poke): Change argument `pid' to `ptid'.
2208         * (inf_ptrace_peek_poke): Update.
2209
2210 2020-03-19  Kamil Rytarowski  <n54@gmx.com>
2211
2212         * x86-bsd-nat.c (gdb_ptrace): New.
2213         * (x86bsd_dr_set): Add new argument `ptid'.
2214         * (x86bsd_dr_get, x86bsd_dr_set, x86bsd_dr_set_control,
2215         x86bsd_dr_set_addr): Update.
2216
2217 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2218
2219         * remote.c (remote_target::process_stop_reply): Handle events for
2220         all threads differently.
2221
2222 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2223
2224         * completer.c (completion_tracker::remove_completion): Define new
2225         function.
2226         * completer.h (completion_tracker::remove_completion): Declare new
2227         function.
2228         * symtab.c (completion_list_add_symbol): Remove aliasing msymbols
2229         when adding a C++ function symbol.
2230
2231 2020-03-19  Andrew Burgess  <andrew.burgess@embecosm.com>
2232
2233         * completer.c (completion_tracker::completion_hash_entry): Define
2234         new class.
2235         (advance_to_filename_complete_word_point): Call
2236         recompute_lowest_common_denominator.
2237         (completion_tracker::completion_tracker): Call discard_completions
2238         to setup the hash table.
2239         (completion_tracker::discard_completions): Allow for being called
2240         from the constructor, pass new equal function, and element deleter
2241         when constructing the hash table.  Initialise new class member
2242         variables.
2243         (completion_tracker::maybe_add_completion): Remove use of
2244         m_entries_vec, and store more information into m_entries_hash.
2245         (completion_tracker::recompute_lcd_visitor): New function, most
2246         content taken from...
2247         (completion_tracker::recompute_lowest_common_denominator):
2248         ...here, this now just visits each item in the hash calling the
2249         above visitor.
2250         (completion_tracker::build_completion_result): Remove use of
2251         m_entries_vec, call recompute_lowest_common_denominator.
2252         * completer.h (completion_tracker::have_completions): Remove use
2253         of m_entries_vec.
2254         (completion_tracker::completion_hash_entry): Declare new class.
2255         (completion_tracker::recompute_lowest_common_denominator): Change
2256         function signature.
2257         (completion_tracker::recompute_lcd_visitor): Declare new function.
2258         (completion_tracker::m_entries_vec): Delete.
2259         (completion_tracker::m_entries_hash): Initialize to NULL.
2260         (completion_tracker::m_lowest_common_denominator_valid): New
2261         member variable.
2262         (completion_tracker::m_lowest_common_denominator_max_length): New
2263         member variable.
2264
2265 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2266
2267         * regformats/regdef.h: Put reg in gdb namespace.
2268
2269 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2270
2271         * i386-bsd-nat.c (gdb_ptrace): New.
2272         * (i386bsd_fetch_inferior_registers,
2273         i386bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2274         * (i386bsd_fetch_inferior_registers,
2275         i386bsd_store_inferior_registers) Use gdb_ptrace.
2276
2277 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2278
2279         * amd64-bsd-nat.c (gdb_ptrace): New.
2280         * (amd64bsd_fetch_inferior_registers,
2281         amd64bsd_store_inferior_registers) Switch from pid_t to ptid_t.
2282         * (amd64bsd_fetch_inferior_registers,
2283         amd64bsd_store_inferior_registers) Use gdb_ptrace.
2284
2285 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2286
2287         * user-regs.c (user_reg::read): Rename to...
2288         (user_reg::xread): ...this.
2289         * (append_user_reg): Rename argument `read' to `xread'.
2290         * (user_reg_add_builtin): Likewise.
2291         * (user_reg_add): Likewise.
2292         * (value_of_user_reg): Likewise.
2293
2294 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2295
2296         * sparc-nat.c (gdb_ptrace): New.
2297         * sparc-nat.c (sparc_fetch_inferior_registers)
2298         (sparc_store_inferior_registers) Remove obsolete comment.
2299         * sparc-nat.c (sparc_fetch_inferior_registers)
2300         (sparc_store_inferior_registers) Switch from pid_t to ptid_t.
2301         * sparc-nat.c (sparc_fetch_inferior_registers)
2302         (sparc_store_inferior_registers) Use gdb_ptrace.
2303
2304 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2305
2306         * sh-nbsd-nat.c (fetch_registers): New variable lwp and pass
2307         it to the ptrace call.
2308         * sh-nbsd-nat.c (store_registers): Likewise.
2309
2310 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2311
2312         * sh-nbsd-nat.c (sh_nbsd_nat_target): Inherit from
2313         nbsd_nat_target instead of inf_ptrace_target.
2314         * sh-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2315         nbsd_nat_target.
2316
2317 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2318
2319         * amd64-bsd-nat.c: Include amd64-bsd-nat.h".
2320
2321 2020-03-17  Kamil Rytarowski  <n54@gmx.com>
2322
2323         * nbsd-nat.c: Include <sys/types.h>, <sys/ptrace.h> and
2324         <sys/sysctl.h>.
2325         * nbsd-nat.c (nbsd_nat_target::pid_to_exec_file): Rewrite.
2326
2327 2020-03-17  Tom de Vries  <tdevries@suse.de>
2328
2329         PR gdb/23710
2330         * dwarf2/read.h (struct dwarf2_per_cu_data): Add unit_type and lang
2331         fields.
2332         * dwarf2/read.c (process_psymtab_comp_unit): Initialize unit_type and lang
2333         fields.
2334         (process_imported_unit_die): Skip import of c++ CUs.
2335
2336 2020-03-16  Tom Tromey  <tom@tromey.com>
2337
2338         * p-valprint.c (pascal_object_print_value): Initialize
2339         base_value.
2340
2341 2020-03-16  Anton Kolesov  <anton.kolesov@synopsys.com>
2342             Shahab Vahedi  <shahab@synopsys.com>
2343
2344         * Makefile.in: Add arch/arc.o
2345         * configure.tgt: Likewise.
2346         * arc-tdep.c (arc_tdesc_init): Use arc_read_description.
2347         (_initialize_arc_tdep): Don't initialize old target descriptions.
2348         (arc_read_description): New function to cache target descriptions.
2349         * arc-tdep.h (arc_read_description): Add proto type.
2350         * arch/arc.c: New file.
2351         * arch/arc.h: Likewise.
2352         * features/Makefile: Replace old target descriptions with new.
2353         * features/arc-arcompact.c: Remove.
2354         * features/arc-arcompact.xml: Likewise.
2355         * features/arc-v2.c: Likewise
2356         * features/arc-v2.xml: Likewise
2357         * features/arc/aux-arcompact.xml: New file.
2358         * features/arc/aux-v2.xml: Likewise.
2359         * features/arc/core-arcompact.xml: Likewise.
2360         * features/arc/core-v2.xml: Likewise.
2361         * features/arc/aux-arcompact.c: Generate.
2362         * features/arc/aux-v2.c: Likewise.
2363         * features/arc/core-arcompact.c: Likewise.
2364         * features/arc/core-v2.c: Likewise.
2365         * target-descriptions (maint_print_c_tdesc_cmd): Support ARC features.
2366
2367 2020-03-16  Tom Tromey  <tromey@adacore.com>
2368
2369         PR gdb/25663:
2370         * dwarf2/read.c (dwarf2_name): Strip leading namespaces after
2371         putting value into bcache.
2372
2373 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2374
2375         PR gdb/21500
2376         * amd64-windows-tdep.c (amd64_windows_init_abi): Rename
2377         to...
2378         (amd64_windows_init_abi_common): ... this.  Don't set size of
2379         long type.
2380         (amd64_windows_init_abi): New function.
2381         (amd64_cygwin_init_abi): New function.
2382         (_initialize_amd64_windows_tdep): Use amd64_cygwin_init_abi for
2383         the Cygwin OS ABI.
2384         * i386-windows-tdep.c (_initialize_i386_windows_tdep): Clarify
2385         comment.
2386
2387 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2388
2389         * windows-tdep.h (is_linked_with_cygwin_dll): New declaration.
2390         * windows-tdep.c (CYGWIN_DLL_NAME): New.
2391         (pe_import_directory_entry): New struct type.
2392         (is_linked_with_cygwin_dll): New function.
2393         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Select
2394         GDB_OSABI_CYGWIN if the BFD is linked with the Cygwin DLL.
2395         * i386-windows-tdep.c (i386_windows_osabi_sniffer): Likewise.
2396
2397 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2398
2399         * i386-windows-tdep.c: Mass-rename "cygwin" to "windows", except
2400         i386_cygwin_core_osabi_sniffer.
2401
2402 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2403
2404         * i386-cygwin-tdep.c: Rename to...
2405         * i386-windows-tdep.c: ... this.
2406         * Makefile.in (ALL_TARGET_OBS): Rename i386-cygwin-tdep.c to
2407         i386-windows-tdep.c.
2408         * configure.tgt: Likewise.
2409
2410 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2411
2412         * osabi.h (enum gdb_osabi): Add GDB_OSABI_WINDOWS.
2413         * osabi.c (gdb_osabi_names): Add "Windows".
2414         * i386-cygwin-tdep.c (i386_cygwin_osabi_sniffer): Return
2415         GDB_OSABI_WINDOWS when the binary's target is "pei-i386".
2416         (i386_cygwin_core_osabi_sniffer): New function, extracted from
2417         i386_cygwin_osabi_sniffer.
2418         (_initialize_i386_cygwin_tdep): Register OS ABI
2419         GDB_OSABI_WINDOWS for i386.
2420         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): Return
2421         GDB_OSABI_WINDOWS when the binary's target is "pei-x86-64".
2422         (_initialize_amd64_windows_tdep): Register OS ABI GDB_OSABI_WINDOWS
2423         for x86-64.
2424         * configure.tgt: Use GDB_OSABI_WINDOWS as the default OS ABI
2425         when the target matches '*-*-mingw*'.
2426
2427 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2428
2429         * defs.h (enum gdb_osabi): Move to...
2430         * osabi.h (enum gdb_osabi): ... here.
2431         * gdbarch.sh: Include osabi.h in gdbarch.h.
2432         * gdbarch.h: Re-generate.
2433
2434 2020-03-16  Simon Marchi  <simon.marchi@efficios.com>
2435
2436         * amd64-windows-tdep.c (amd64_windows_osabi_sniffer): New
2437         function.
2438         (_initialize_amd64_windows_tdep): Register osabi sniffer.
2439
2440 2020-03-14  Tom Tromey  <tom@tromey.com>
2441
2442         * c-typeprint.c (cp_type_print_method_args): Print "__restrict__"
2443         for C++.
2444         (c_type_print_modifier): Likewise.  Add "language" parameter.
2445         (c_type_print_varspec_prefix, c_type_print_base_struct_union)
2446         (c_type_print_base_1): Update.
2447         * type-stack.h (enum type_pieces) <tp_atomic, tp_restrict>: New
2448         constants.
2449         * type-stack.c (type_stack::insert): Handle tp_atomic and
2450         tp_restrict.
2451         (type_stack::follow_type_instance_flags): Likewise.
2452         (type_stack::follow_types): Likewise.  Merge type-following code.
2453         * c-exp.y (RESTRICT, ATOMIC): New tokens.
2454         (space_identifier, cv_with_space_id)
2455         (const_or_volatile_or_space_identifier_noopt)
2456         (const_or_volatile_or_space_identifier): Remove.
2457         (single_qualifier, qualifier_seq_noopt, qualifier_seq): New
2458         rules.
2459         (ptr_operator, typebase): Update.
2460         (enum token_flag) <FLAG_C>: New constant.
2461         (ident_tokens): Add "restrict", "__restrict__", "__restrict", and
2462         "_Atomic".
2463         (lex_one_token): Handle FLAG_C.
2464
2465 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2466
2467         * m68k-bsd-nat.c (fetch_registers): New variable lwp and pass
2468         it to the ptrace call.
2469         * m68k-bsd-nat.c (store_registers): Likewise.
2470
2471 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2472
2473         * m68k-bsd-nat.c (m68kbsd_supply_gregset): Change type of regs to
2474         gdb_byte *.
2475         * m68k-bsd-nat.c (m68kbsd_supply_fpregset): Likewise.
2476         * m68k-bsd-nat.c (m68kbsd_collect_gregset): Likewise.
2477         * m68k-bsd-nat.c (m68kbsd_supply_pcb): Cast &tmp to gdb_byte *.
2478
2479 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2480
2481         * m68k-bsd-nat.c (m68k_bsd_nat_target): Inherit from
2482         nbsd_nat_target instead of inf_ptrace_target.
2483         * m68k-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2484         nbsd_nat_target.
2485
2486 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2487
2488         * m68k-bsd-nat.c: Define _KERNTYPES to get the declaration of
2489         register_t.
2490
2491 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2492
2493         * alpha-bsd-nat.c (fetch_registers): New variable lwp and pass
2494         it to the ptrace call.
2495         * alpha-bsd-nat.c (store_registers): Likewise.
2496
2497 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2498
2499         * alpha-bsd-nat.c: Remove <sys/procfs.h> and "gregset.h" from
2500         includes.
2501         * alpha-bsd-nat.c (gregset_t, fpregset_t): Remove.
2502         * alpha-bsd-nat.c (supply_gregset, fill_gregset, supply_fpregset,
2503         fill_fpregset): Likewise.
2504
2505 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2506
2507         * alpha-bsd-nat.c (alpha_netbsd_nat_target): Inherit from
2508         nbsd_nat_target instead of inf_ptrace_target.
2509         * alpha-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2510         nbsd_nat_target.
2511
2512 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2513
2514         * alpha-bsd-nat.c: Define _KERNTYPES to get the declaration of
2515         register_t.
2516
2517 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2518
2519         * arm-nbsd-nat.c (fetch_register): New variable lwp and pass
2520         it to the ptrace call.
2521         * arm-nbsd-nat.c (fetch_fp_register): Likewise.
2522         * arm-nbsd-nat.c (fetch_fp_regs): Likewise.
2523         * arm-nbsd-nat.c (store_register): Likewise.
2524         * arm-nbsd-nat.c (store_regs): Likewise.
2525         * arm-nbsd-nat.c (store_fp_register): Likewise.
2526         * arm-nbsd-nat.c (store_fp_regs): Likewise.
2527
2528 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2529
2530         * arm-nbsd-nat.c (arm_netbsd_nat_target): Inherit from
2531         nbsd_nat_target instead of inf_ptrace_target.
2532         * arm-nbsd-nat.c: Include "nbsd-nat.h", as we are now using
2533         nbsd_nat_target.
2534
2535 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2536
2537         * x86-bsd-nat.c (x86bsd_dr_get): New variable lwp and pass
2538         it to the ptrace call.
2539         * x86-bsd-nat.c (x86bsd_dr_set): Likewise.
2540
2541 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2542
2543         * vax-bsd-nat.c (vaxbsd_supply_gregset): New variable lwp and pass
2544         it to the ptrace call.
2545         * vax-bsd-nat.c (vaxbsd_collect_gregset): Likewise.
2546
2547 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2548
2549         * vax-bsd-nat.c (vaxbsd_supply_gregset): Cast gregs to const
2550         gdb_byte *.
2551         * vax-bsd-nat.c (vaxbsd_collect_gregset): Cast gregs to void *.
2552
2553 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2554
2555         * vax-bsd-nat.c (vax_bsd_nat_target): Inherit from nbsd_nat_target
2556         instead of inf_ptrace_target.
2557         * vax-bsd-nat.c: Include "nbsd-nat.h", as we are now using
2558         nbsd_nat_target.
2559
2560 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2561
2562         * mips-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2563         register_t.
2564
2565 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2566
2567         * ppc-nbsd-nat.c: Define _KERNTYPES to get the declaration of
2568         register_t.
2569
2570 2020-03-14  Kamil Rytarowski  <n54@gmx.com>
2571
2572         * vax-bsd-nat.c: Define _KERNTYPES to get the declaration of
2573         register_t.
2574
2575 2020-03-13  Tom Tromey  <tom@tromey.com>
2576
2577         * value.h (val_print): Don't declare.
2578         * valprint.h (val_print_array_elements)
2579         (val_print_scalar_formatted, generic_val_print): Don't declare.
2580         * valprint.c (generic_val_print_array): Take a struct value.
2581         (generic_val_print_ptr, generic_val_print_memberptr)
2582         (generic_val_print_bool, generic_val_print_int)
2583         (generic_val_print_char, generic_val_print_complex)
2584         (generic_val_print): Remove.
2585         (generic_value_print): Update.
2586         (do_val_print): Remove unused parameters.  Don't call
2587         la_val_print.
2588         (val_print): Remove.
2589         (common_val_print): Update.  Don't call value_check_printable.
2590         (val_print_scalar_formatted, val_print_array_elements): Remove.
2591         * rust-lang.c (rust_val_print): Remove.
2592         (rust_language_defn): Update.
2593         * p-valprint.c (pascal_val_print): Remove.
2594         (pascal_value_print_inner): Update.
2595         (pascal_object_print_val_fields, pascal_object_print_val):
2596         Remove.
2597         (pascal_object_print_static_field): Update.
2598         * p-lang.h (pascal_val_print): Don't declare.
2599         * p-lang.c (pascal_language_defn): Update.
2600         * opencl-lang.c (opencl_language_defn): Update.
2601         * objc-lang.c (objc_language_defn): Update.
2602         * m2-valprint.c (m2_print_unbounded_array, m2_val_print): Remove.
2603         * m2-lang.h (m2_val_print): Don't declare.
2604         * m2-lang.c (m2_language_defn): Update.
2605         * language.h (struct language_defn) <la_val_print>: Remove.
2606         * language.c (unk_lang_value_print_inner): Rename.  Change
2607         argument types.
2608         (unknown_language_defn, auto_language_defn): Update.
2609         * go-valprint.c (go_val_print): Remove.
2610         * go-lang.h (go_val_print): Don't declare.
2611         * go-lang.c (go_language_defn): Update.
2612         * f-valprint.c (f_val_print): Remove.
2613         * f-lang.h (f_value_print): Don't declare.
2614         * f-lang.c (f_language_defn): Update.
2615         * d-valprint.c (d_val_print): Remove.
2616         * d-lang.h (d_value_print): Don't declare.
2617         * d-lang.c (d_language_defn): Update.
2618         * cp-valprint.c (cp_print_value_fields)
2619         (cp_print_value_fields_rtti, cp_print_value): Remove.
2620         (cp_print_static_field): Update.
2621         * c-valprint.c (c_val_print_array, c_val_print_ptr)
2622         (c_val_print_struct, c_val_print_union, c_val_print_int)
2623         (c_val_print_memberptr, c_val_print): Remove.
2624         * c-lang.h (c_val_print_array, cp_print_value_fields)
2625         (cp_print_value_fields_rtti): Don't declare.
2626         * c-lang.c (c_language_defn, cplus_language_defn)
2627         (asm_language_defn, minimal_language_defn): Update.
2628         * ada-valprint.c (ada_val_print_ptr, ada_val_print_num): Remove.
2629         (ada_val_print_enum): Take a struct value.
2630         (ada_val_print_flt, ada_val_print_array, ada_val_print_1)
2631         (ada_val_print): Remove.
2632         (ada_value_print_1): Update.
2633         (printable_val_type): Remove.
2634         * ada-lang.h (ada_val_print): Don't declare.
2635         * ada-lang.c (ada_language_defn): Update.
2636
2637 2020-03-13  Tom Tromey  <tom@tromey.com>
2638
2639         * valprint.c (do_val_print): Update.
2640         * python/python-internal.h (gdbpy_apply_val_pretty_printer): Take
2641         a struct value.
2642         (value_to_value_object_no_release): Declare.
2643         * python/py-value.c (value_to_value_object_no_release): New
2644         function.
2645         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Take a
2646         struct value.
2647         * guile/scm-value.c (vlscm_scm_from_value_no_release): New
2648         function.
2649         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer): Take
2650         a struct value.
2651         * guile/guile-internal.h (vlscm_scm_from_value_no_release):
2652         Declare.
2653         (gdbscm_apply_val_pretty_printer): Take a struct value.
2654         * extension.h (apply_ext_lang_val_pretty_printer): Take a struct
2655         value.
2656         * extension.c (apply_ext_lang_val_pretty_printer): Take a struct
2657         value.
2658         * extension-priv.h (struct extension_language_ops)
2659         <apply_val_pretty_printer>: Take a struct value.
2660         * cp-valprint.c (cp_print_value): Create a struct value.
2661         (cp_print_value): Update.
2662
2663 2020-03-13  Tom Tromey  <tom@tromey.com>
2664
2665         * ada-valprint.c (print_field_values): Call common_val_print.
2666
2667 2020-03-13  Tom Tromey  <tom@tromey.com>
2668
2669         * ada-valprint.c (val_print_packed_array_elements): Remove
2670         bitoffset and val parameters.  Call common_val_print.
2671         (ada_val_print_string): Remove offset, address, and original_value
2672         parameters.
2673         (ada_val_print_array): Update.
2674         (ada_value_print_array): New function.
2675         (ada_value_print_1): Call it.
2676
2677 2020-03-13  Tom Tromey  <tom@tromey.com>
2678
2679         * ada-valprint.c (ada_value_print): Use common_val_print.
2680
2681 2020-03-13  Tom Tromey  <tom@tromey.com>
2682
2683         * ada-valprint.c (ada_val_print_ref): Use common_val_print.
2684
2685 2020-03-13  Tom Tromey  <tom@tromey.com>
2686
2687         * ada-valprint.c (ada_value_print_num): New function.
2688         (ada_value_print_1): Use it.
2689
2690 2020-03-13  Tom Tromey  <tom@tromey.com>
2691
2692         * ada-valprint.c (ada_value_print_1) <TYPE_CODE_FLT>: Rewrite.
2693
2694 2020-03-13  Tom Tromey  <tom@tromey.com>
2695
2696         * ada-valprint.c (ada_value_print_ptr): New function.
2697         (ada_value_print_1): Use it.
2698
2699 2020-03-13  Tom Tromey  <tom@tromey.com>
2700
2701         * ada-valprint.c (ada_val_print_gnat_array): Take a struct value;
2702         call common_val_print.
2703         (ada_val_print_1): Update.
2704         (ada_value_print_1): New function.
2705         (ada_value_print_inner): Rewrite.
2706
2707 2020-03-13  Tom Tromey  <tom@tromey.com>
2708
2709         * cp-valprint.c (cp_print_value_fields): Update.
2710         (cp_print_value): New function.
2711
2712 2020-03-13  Tom Tromey  <tom@tromey.com>
2713
2714         * m2-valprint.c (m2_value_print_inner): Use
2715         cp_print_value_fields.
2716         * cp-valprint.c (cp_print_value_fields): New function.
2717         * c-valprint.c (c_value_print_struct): New function.
2718         (c_value_print_inner): Use c_value_print_struct.
2719         * c-lang.h (cp_print_value_fields): Declare.
2720
2721 2020-03-13  Tom Tromey  <tom@tromey.com>
2722
2723         * c-valprint.c (c_value_print_array): New function.
2724         (c_value_print_inner): Use it.
2725
2726 2020-03-13  Tom Tromey  <tom@tromey.com>
2727
2728         * c-valprint.c (c_value_print_memberptr): New function.
2729         (c_value_print_inner): Use it.
2730
2731 2020-03-13  Tom Tromey  <tom@tromey.com>
2732
2733         * c-valprint.c (c_value_print_int): New function.
2734         (c_value_print_inner): Use it.
2735
2736 2020-03-13  Tom Tromey  <tom@tromey.com>
2737
2738         * c-valprint.c (c_value_print_ptr): New function.
2739         (c_value_print_inner): Use it.
2740
2741 2020-03-13  Tom Tromey  <tom@tromey.com>
2742
2743         * c-valprint.c (c_value_print_inner): Rewrite.
2744
2745 2020-03-13  Tom Tromey  <tom@tromey.com>
2746
2747         * valprint.c (generic_value_print_complex): New function.
2748         (generic_value_print): Use it.
2749
2750 2020-03-13  Tom Tromey  <tom@tromey.com>
2751
2752         * valprint.c (generic_val_print_float): Don't call
2753         val_print_scalar_formatted.
2754         (generic_val_print, generic_value_print): Update.
2755
2756 2020-03-13  Tom Tromey  <tom@tromey.com>
2757
2758         * valprint.c (generic_value_print_char): New function
2759         (generic_value_print): Use it.
2760
2761 2020-03-13  Tom Tromey  <tom@tromey.com>
2762
2763         * valprint.c (generic_value_print_int): New function.
2764         (generic_value_print): Use it.
2765
2766 2020-03-13  Tom Tromey  <tom@tromey.com>
2767
2768         * valprint.c (generic_value_print_bool): New function.
2769         (generic_value_print): Use it.
2770
2771 2020-03-13  Tom Tromey  <tom@tromey.com>
2772
2773         * valprint.c (generic_val_print_func): Simplify.
2774         (generic_val_print, generic_value_print): Update.
2775
2776 2020-03-13  Tom Tromey  <tom@tromey.com>
2777
2778         * valprint.c (generic_val_print_flags): Remove.
2779         (generic_val_print, generic_value_print): Update.
2780         (val_print_type_code_flags): Add original_value parameter.
2781
2782 2020-03-13  Tom Tromey  <tom@tromey.com>
2783
2784         * valprint.c (generic_val_print): Update.
2785         (generic_value_print): Update.
2786         * valprint.c (generic_val_print_enum): Don't call
2787         val_print_scalar_formatted.
2788
2789 2020-03-13  Tom Tromey  <tom@tromey.com>
2790
2791         * valprint.c (generic_value_print): Call generic_value_print_ptr.
2792         * valprint.c (generic_value_print_ptr): New function.
2793
2794 2020-03-13  Tom Tromey  <tom@tromey.com>
2795
2796         * valprint.c (generic_value_print): Rewrite.
2797
2798 2020-03-13  Tom Tromey  <tom@tromey.com>
2799
2800         * p-valprint.c (pascal_object_print_value_fields)
2801         (pascal_object_print_value): New functions.
2802
2803 2020-03-13  Tom Tromey  <tom@tromey.com>
2804
2805         * p-valprint.c (pascal_value_print_inner): Rewrite.
2806
2807 2020-03-13  Tom Tromey  <tom@tromey.com>
2808
2809         * f-valprint.c (f_value_print_innner): Rewrite.
2810
2811 2020-03-13  Tom Tromey  <tom@tromey.com>
2812
2813         * m2-valprint.c (m2_print_unbounded_array): New overload.
2814         (m2_print_unbounded_array): Update.
2815         (m2_print_array_contents): Take a struct value.
2816         (m2_value_print_inner): Rewrite.
2817
2818 2020-03-13  Tom Tromey  <tom@tromey.com>
2819
2820         * d-valprint.c (dynamic_array_type): Call d_value_print_inner.
2821         (d_value_print_inner): New function.
2822         * d-lang.h (d_value_print_inner): Declare.
2823         * d-lang.c (d_language_defn): Use d_value_print_inner.
2824
2825 2020-03-13  Tom Tromey  <tom@tromey.com>
2826
2827         * go-valprint.c (go_value_print_inner): New function.
2828         * go-lang.h (go_value_print_inner): Declare.
2829         * go-lang.c (go_language_defn): Use go_value_print_inner.
2830
2831 2020-03-13  Tom Tromey  <tom@tromey.com>
2832
2833         * rust-lang.c (val_print_struct, rust_print_enum): Use the value
2834         API.
2835         (rust_val_print): Rewrite.
2836         (rust_value_print_inner): New function, from rust_val_print.
2837         (rust_language_defn): Use rust_value_print_inner.
2838
2839 2020-03-13  Tom Tromey  <tom@tromey.com>
2840
2841         * ada-valprint.c (ada_value_print_inner): New function.
2842         * ada-lang.h (ada_value_print_inner): Declare.
2843         * ada-lang.c (ada_language_defn): Use ada_value_print_inner.
2844
2845 2020-03-13  Tom Tromey  <tom@tromey.com>
2846
2847         * f-valprint.c (f_value_print_innner): New function.
2848         * f-lang.h (f_value_print_innner): Declare.
2849         * f-lang.c (f_language_defn): Use f_value_print_innner.
2850
2851 2020-03-13  Tom Tromey  <tom@tromey.com>
2852
2853         * p-valprint.c (pascal_value_print_inner): New function.
2854         * p-lang.h (pascal_value_print_inner): Declare.
2855         * p-lang.c (pascal_language_defn): Use pascal_value_print_inner.
2856
2857 2020-03-13  Tom Tromey  <tom@tromey.com>
2858
2859         * m2-valprint.c (m2_value_print_inner): New function.
2860         * m2-lang.h (m2_value_print_inner): Declare.
2861         * m2-lang.c (m2_language_defn): Use m2_value_print_inner.
2862
2863 2020-03-13  Tom Tromey  <tom@tromey.com>
2864
2865         * opencl-lang.c (opencl_language_defn): Use c_value_print_inner.
2866         * objc-lang.c (objc_language_defn): Use c_value_print_inner.
2867         * c-valprint.c (c_value_print_inner): New function.
2868         * c-lang.h (c_value_print_inner): Declare.
2869         * c-lang.c (c_language_defn, cplus_language_defn)
2870         (asm_language_defn, minimal_language_defn): Use
2871         c_value_print_inner.
2872
2873 2020-03-13  Tom Tromey  <tom@tromey.com>
2874
2875         * p-valprint.c (pascal_object_print_value_fields): Now static.
2876         * p-lang.h (pascal_object_print_value_fields): Don't declare.
2877
2878 2020-03-13  Tom Tromey  <tom@tromey.com>
2879
2880         * c-valprint.c (c_val_print_array): Simplify.
2881
2882 2020-03-13  Tom Tromey  <tom@tromey.com>
2883
2884         * valprint.c (value_print_array_elements): New function.
2885         * valprint.h (value_print_array_elements): Declare.
2886
2887 2020-03-13  Tom Tromey  <tom@tromey.com>
2888
2889         * printcmd.c (print_formatted): Use value_print_scalar_formatted.
2890         * mips-tdep.c (mips_print_register): Use
2891         value_print_scalar_formatted.
2892
2893 2020-03-13  Tom Tromey  <tom@tromey.com>
2894
2895         * valprint.h (value_print_scalar_formatted): Declare.
2896         * valprint.c (value_print_scalar_formatted): New function.
2897
2898 2020-03-13  Tom Tromey  <tom@tromey.com>
2899
2900         * valprint.h (generic_value_print): Declare.
2901         * valprint.c (generic_value_print): New function.
2902
2903 2020-03-13  Tom Tromey  <tom@tromey.com>
2904
2905         * valprint.c (do_val_print): Call la_value_print_inner, if
2906         available.
2907         * rust-lang.c (rust_language_defn): Update.
2908         * p-lang.c (pascal_language_defn): Update.
2909         * opencl-lang.c (opencl_language_defn): Update.
2910         * objc-lang.c (objc_language_defn): Update.
2911         * m2-lang.c (m2_language_defn): Update.
2912         * language.h (struct language_defn) <la_value_print_inner>: New
2913         member.
2914         * language.c (unknown_language_defn, auto_language_defn): Update.
2915         * go-lang.c (go_language_defn): Update.
2916         * f-lang.c (f_language_defn): Update.
2917         * d-lang.c (d_language_defn): Update.
2918         * c-lang.c (c_language_defn, cplus_language_defn)
2919         (asm_language_defn, minimal_language_defn): Update.
2920         * ada-lang.c (ada_language_defn): Update.
2921
2922 2020-03-13  Tom Tromey  <tom@tromey.com>
2923
2924         * c-valprint.c (c_value_print): Use common_val_print.
2925
2926 2020-03-13  Tom Tromey  <tom@tromey.com>
2927
2928         * cp-valprint.c (cp_print_static_field): Use common_val_print.
2929
2930 2020-03-13  Tom Tromey  <tom@tromey.com>
2931
2932         * f-valprint.c (f77_print_array_1, f_val_print): Use
2933         common_val_print.
2934
2935 2020-03-13  Tom Tromey  <tom@tromey.com>
2936
2937         * riscv-tdep.c (riscv_print_one_register_info): Use
2938         common_val_print.
2939
2940 2020-03-13  Tom Tromey  <tom@tromey.com>
2941
2942         * mi/mi-main.c (output_register): Use common_val_print.
2943
2944 2020-03-13  Tom Tromey  <tom@tromey.com>
2945
2946         * infcmd.c (default_print_one_register_info): Use
2947         common_val_print.
2948
2949 2020-03-13  Tom Tromey  <tom@tromey.com>
2950
2951         * valprint.h (common_val_print_checked): Declare.
2952         * valprint.c (common_val_print_checked): New function.
2953         * stack.c (print_frame_arg): Use common_val_print_checked.
2954
2955 2020-03-13  Tom Tromey  <tom@tromey.com>
2956
2957         * valprint.c (do_val_print): New function, from val_print.
2958         (val_print): Use do_val_print.
2959         (common_val_print): Use do_val_print.
2960
2961 2020-03-13  Tom Tromey  <tom@tromey.com>
2962
2963         * valprint.c (value_print): Use scoped_value_mark.
2964
2965 2020-03-13  Tom de Vries  <tdevries@suse.de>
2966
2967         PR symtab/25646
2968         * psymtab.c (partial_symtab::partial_symtab): Don't set
2969         globals_offset and statics_offset.  Push element onto
2970         current_global_psymbols and current_static_psymbols stacks.
2971         (concat): New function.
2972         (end_psymtab_common): Set globals_offset and statics_offset.  Pop
2973         element from current_global_psymbols and current_static_psymbols
2974         stacks.  Concat popped elements to global_psymbols and
2975         static_symbols.
2976         (add_psymbol_to_list): Use current_global_psymbols and
2977         current_static_psymbols stacks.
2978         * psymtab.h (class psymtab_storage): Add current_global_psymbols and
2979         current_static_psymbols fields.
2980
2981 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
2982
2983         * corelow.c (sniff_core_bfd): Remove.
2984         (class core_target) <m_core_vec>: Remove.
2985         (core_target::core_target): Update.
2986         (core_file_fns): Remove.
2987         (deprecated_add_core_fns): Remove.
2988         (default_core_sniffer): Remove.
2989         (sniff_core_bfd): Remove.
2990         (default_check_format): Remove.
2991         (gdb_check_format): Remove.
2992         (core_target_open): Update.
2993         (core_target::get_core_register_section): Update.
2994         (get_core_registers_cb): Update.
2995         (core_target::fetch_registers): Update.
2996         * gdbcore.h (struct core_fns): Remove.
2997         (deprecated_add_core_fns): Remove.
2998         (default_core_sniffer): Remove.
2999         (default_check_format): Remove.
3000
3001 2020-03-12  Tom Tromey  <tom@tromey.com>
3002
3003         * arm-tdep.c (struct arm_mapping_symbol) <value>: Now a
3004         CORE_ADDR.
3005         (struct arm_exidx_entry) <addr>: Now a CORE_ADDR.
3006
3007 2020-03-12  Tom Tromey  <tom@tromey.com>
3008
3009         * remote.c (remote_target::download_tracepoint)
3010         (remote_target::enable_tracepoint)
3011         (remote_target::disable_tracepoint): Use phex, not sprintf_vma.
3012         * breakpoint.c (print_recreate_masked_watchpoint): Use phex, not
3013         sprintf_vma.
3014
3015 2020-03-12  Tom Tromey  <tom@tromey.com>
3016
3017         * symfile-mem.c: Update CORE_ADDR size assert.
3018
3019 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3020
3021         * selftest.m4: Move to gdbsupport/.
3022         * acinclude.m4: Update path to selftest.m4.
3023
3024 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3025
3026         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Rename to...
3027         (SELFTESTS_SRCS): ... this.  Add disasm-selftests.c,
3028         gdbarch-selfselftests.c and selftest-arch.c.
3029         (SUBDIR_UNITTESTS_OBS): Rename to...
3030         (SELFTESTS_OBS): ... this.
3031         (COMMON_SFILES): Remove disasm-selftests.c and
3032         gdbarch-selftests.c.
3033         * configure.ac: Don't add selftest-arch.{c,o} to
3034         CONFIG_{SRCS,OBS}.
3035         * disasm-selftests.c, gdbarch-selftests.c: Remove GDB_SELF_TEST
3036         preprocessor conditions.
3037
3038 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3039
3040         * configure.ac: Don't source bfd/development.sh.
3041         * selftest.m4: Modify comment.
3042         * configure: Re-generate.
3043
3044 2020-03-12  Simon Marchi  <simon.marchi@efficios.com>
3045
3046         * selftest.m4 (GDB_AC_SELFTEST): Error out if $development is
3047         not "true" or "false".
3048         * configure: Re-generate.
3049
3050 2020-03-12  Christian Biesinger  <cbiesinger@google.com>
3051
3052         * Makefile.in (HFILES_NO_SRCDIR): Add new arm-nbsd-tdep.h file.
3053         * arm-nbsd-nat.c (arm_supply_gregset): Moved to arm-nbsd-tdep and
3054         renamed to arm_nbsd_supply_gregset.
3055         (fetch_register): Update to call arm_nbsd_supply_gregset.
3056         (fetch_regs): Remove in favor of fetch_register with a -1 regno.
3057         (arm_netbsd_nat_target::fetch_registers): Update.
3058         (fetch_elfcore_registers): Removed.
3059         (_initialize_arm_netbsd_nat): Removed call to deprecated_add_core_fns.
3060         * arm-nbsd-tdep.c (struct arm_nbsd_reg): New struct.
3061         (arm_nbsd_supply_gregset): Moved from arm-nbsd-nat.c and updated to
3062         not require NetBSD system headers.
3063         (arm_nbsd_regset): New struct.
3064         (arm_nbsd_iterate_over_regset_sections): New function.
3065         (arm_netbsd_init_abi_common): Updated to call
3066         set_gdbarch_iterate_over_regset_sections.
3067         * arm-nbsd-tdep.h: New file.
3068
3069 2020-03-11  Kevin Buettner  <kevinb@redhat.com>
3070
3071         * symtab.c (find_pc_sect_line): Add check which prevents infinite
3072         recursion.
3073
3074 2020-03-11  Simon Marchi  <simon.marchi@efficios.com>
3075
3076         * configure: Re-generate.
3077
3078 2020-03-11  Tom Tromey  <tromey@adacore.com>
3079
3080         * ada-typeprint.c (print_choices): Fix comment.
3081
3082 2020-03-11  Andrew Burgess  <andrew.burgess@embecosm.com>
3083
3084         * buildsyms.c (buildsym_compunit::record_line): Avoid accessing
3085         previous item in the list, when the list has no items.
3086
3087 2020-03-11  Tom de Vries  <tdevries@suse.de>
3088
3089         * dwarf2/loc.c (dwarf2_evaluate_property): Handle NULL frame in
3090         PROP_LOCLIST handling code.
3091
3092 2020-03-10  Andrew Burgess  <andrew.burgess@embecosm.com>
3093
3094         * buildsym-legacy.c (record_line): Pass extra parameter to
3095         record_line.
3096         * buildsym.c (buildsym_compunit::record_line): Take an extra
3097         parameter, reduce duplication in the line table, and record the
3098         is_stmt flag in the line table.
3099         * buildsym.h (buildsym_compunit::record_line): Add extra
3100         parameter.
3101         * disasm.c (do_mixed_source_and_assembly_deprecated): Ignore
3102         non-statement lines.
3103         * dwarf2/read.c (dwarf_record_line_1): Add extra parameter, pass
3104         this to the symtab builder.
3105         (dwarf_finish_line): Pass extra parameter to dwarf_record_line_1.
3106         (lnp_state_machine::record_line): Pass a suitable is_stmt flag
3107         through to dwarf_record_line_1.
3108         * infrun.c (process_event_stop_test): When stepping, don't stop at
3109         a non-statement instruction, and only refresh the step info when
3110         we land in the middle of a line's range.  Also add an extra
3111         comment.
3112         * jit.c (jit_symtab_line_mapping_add_impl): Initialise is_stmt
3113         field.
3114         * record-btrace.c (btrace_find_line_range): Only record lines
3115         marked as is-statement.
3116         * stack.c (frame_show_address): Show the frame address if we are
3117         in a non-statement sal.
3118         * symmisc.c (dump_symtab_1): Print the is_stmt flag.
3119         (maintenance_print_one_line_table): Print a header for the is_stmt
3120         column, and include is_stmt information in the output.
3121         * symtab.c (find_pc_sect_line): Find lines marked as statements in
3122         preference to non-statements.
3123         (find_pcs_for_symtab_line): Prefer is-statement entries.
3124         (find_line_common): Likewise.
3125         * symtab.h (struct linetable_entry): Add is_stmt field.
3126         (struct symtab_and_line): Likewise.
3127         * xcoffread.c (arrange_linetable): Initialise is_stmt field when
3128         arranging the line table.
3129
3130 2020-03-07  Tom de Vries  <tdevries@suse.de>
3131
3132         * dwarf2/read.c (read_typedef): Treat anonymous typedef as forwarder
3133         DIE.
3134
3135 2020-03-07  Tom Tromey  <tom@tromey.com>
3136
3137         * valops.c (value_literal_complex): Remove obsolete comment.
3138         * gdbtypes.h (enum type_code) <TYPE_CODE_FLT>: Remove obsolete
3139         comment.
3140
3141 2020-03-06  Simon Marchi  <simon.marchi@polymtl.ca>
3142
3143         * infrun.h: Forward-declare thread_info.
3144         (set_step_info): Add thread_info parameter, add doc.
3145         * infrun.c (set_step_info): Add thread_info parameter, move doc
3146         to header.
3147         * infrun.c (process_event_stop_test): Pass thread to
3148         set_step_info call.
3149         * infcmd.c (set_step_frame): Add thread_info pointer, pass it to
3150         set_step_info.
3151         (prepare_one_step): Add thread_info parameter, pass it to
3152         set_step_frame and prepare_one_step (recursive) call.
3153         (step_1): Pass thread to prepare_one_step call.
3154         (step_command_fsm::should_stop): Pass thread to
3155         prepare_one_step.
3156         (until_next_fsm): Pass thread to set_step_frame call.
3157         (finish_command): Pass thread to set_step_info call.
3158
3159 2020-03-06  Hannes Domani  <ssbssa@yahoo.de>
3160
3161         * windows-tdep.c (windows_solib_create_inferior_hook):
3162         Check if inferior is running.
3163
3164 2020-03-06  Tom de Vries  <tdevries@suse.de>
3165
3166         * NEWS: Fix "the the".
3167         * ctfread.c: Same.
3168
3169 2020-03-06  Tom de Vries  <tdevries@suse.de>
3170
3171         * psymtab.c (psymtab_to_symtab): Don't print "done.".
3172
3173 2020-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
3174
3175         * .dir-locals.el: Add a comment referencing the other copies of
3176         this file.
3177
3178 2020-03-05  John Baldwin  <jhb@FreeBSD.org>
3179
3180         * fbsd-tdep.c (fbsd_make_corefile_notes): Use std::string for
3181         psargs.
3182
3183 2020-03-05  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
3184
3185         * .gitattributes: New file.
3186
3187 2020-03-04  Tom Tromey  <tom@tromey.com>
3188
3189         * symmisc.c (print_symbol_bcache_statistics)
3190         (print_objfile_statistics): Update.
3191         * symfile.c (allocate_symtab): Use intern.
3192         * psymtab.c (partial_symtab::partial_symtab): Use intern.
3193         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
3194         macro_cache>: Remove.
3195         <string_cache>: New member.
3196         (struct objfile) <intern>: New methods.
3197         * elfread.c (elf_symtab_read): Use intern.
3198         * dwarf2/read.c (fixup_go_packaging): Intern package name.
3199         (dwarf2_compute_name, dwarf2_physname)
3200         (create_dwo_unit_in_dwp_v1, create_dwo_unit_in_dwp_v2): Intern
3201         names.
3202         (guess_partial_die_structure_name): Update.
3203         (partial_die_info::fixup): Intern name.
3204         (dwarf2_canonicalize_name): Change parameter to objfile.  Intern
3205         name.
3206         (dwarf2_name): Intern name.  Update.
3207         * buildsym.c (buildsym_compunit::get_macro_table): Use
3208         string_cache.
3209
3210 2020-03-04  Tom Tromey  <tom@tromey.com>
3211
3212         * jit.c (bfd_open_from_target_memory): Make "target" const.
3213         * corefile.c (gnutarget): Now const.
3214         * gdbcore.h (gnutarget): Now const.
3215
3216 2020-03-04  Hannes Domani  <ssbssa@yahoo.de>
3217
3218         * NEWS: Mention support for WOW64 processes.
3219         * amd64-windows-nat.c (amd64_mappings): Rename and remove static.
3220         (amd64_windows_segment_register_p): Remove static.
3221         (_initialize_amd64_windows_nat): Update.
3222         * configure.nat <windows> (NATDEPFILES): Add i386-windows-nat.o.
3223         * i386-windows-nat.c (context_offset): Update.
3224         (i386_mappings): Rename and remove static.
3225         (i386_windows_segment_register_p): Remove static.
3226         (_initialize_i386_windows_nat): Update.
3227         * windows-nat.c (STATUS_WX86_BREAKPOINT): New macro.
3228         (STATUS_WX86_SINGLE_STEP): New macro.
3229         (EnumProcessModulesEx): New macro.
3230         (Wow64SuspendThread): New macro.
3231         (Wow64GetThreadContext): New macro.
3232         (Wow64SetThreadContext): New macro.
3233         (Wow64GetThreadSelectorEntry): New macro.
3234         (windows_set_context_register_offsets): Add static.
3235         (windows_set_segment_register_p): Likewise.
3236         (windows_add_thread): Adapt for WOW64 processes.
3237         (windows_fetch_one_register): Likewise.
3238         (windows_nat_target::fetch_registers): Likewise.
3239         (windows_store_one_register): Likewise.
3240         (display_selector): Likewise.
3241         (display_selectors): Likewise.
3242         (handle_exception): Likewise.
3243         (windows_continue): Likewise.
3244         (windows_nat_target::resume): Likewise.
3245         (windows_add_all_dlls): Likewise.
3246         (do_initial_windows_stuff): Likewise.
3247         (windows_nat_target::attach): Likewise.
3248         (windows_get_exec_module_filename): Likewise.
3249         (windows_nat_target::create_inferior): Likewise.
3250         (windows_xfer_siginfo): Likewise.
3251         (_initialize_loadable): Initialize Wow64SuspendThread,
3252         Wow64GetThreadContext, Wow64SetThreadContext,
3253         Wow64GetThreadSelectorEntry and EnumProcessModulesEx.
3254         * windows-nat.h (windows_set_context_register_offsets):
3255         Remove declaration.
3256         (windows_set_segment_register_p): Likewise.
3257         (i386_windows_segment_register_p): Add declaration.
3258         (amd64_windows_segment_register_p): Likewise.
3259
3260 2020-03-04  Luis Machado  <luis.machado@linaro.org>
3261
3262         Revert aa66aac47b4dd38f9524ddb5546c08cc09930d37 due to regressions
3263         in "info registers" for AArch64/ARM.
3264
3265         The change caused "info registers" to not print GPR's.
3266
3267         gdb/ChangeLog:
3268
3269         2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
3270
3271         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
3272         when reg->group is empty and reggroup is not.
3273
3274 2020-03-03  Tom Tromey  <tromey@adacore.com>
3275
3276         * dwarf2/frame.c (struct dwarf2_frame_cache)
3277         <checked_tailcall_bottom, entry_cfa_sp_offset,
3278         entry_cfa_sp_offset_p>: Remove members.
3279         (dwarf2_frame_cache): Call dwarf2_tailcall_sniffer_first.
3280         (dwarf2_frame_prev_register): Don't call
3281         dwarf2_tailcall_sniffer_first.
3282         (dwarf2_append_unwinders): Don't append tailcall unwinder.
3283         * frame-unwind.c (add_unwinder): New fuction.
3284         (frame_unwind_init): Use it.  Add tailcall unwinder.
3285
3286 2020-03-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3287             Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
3288
3289         * f-valprint.c (f_val_print): Handle TYPE_CODE_BOOL, any non-zero
3290         value should be printed as true.
3291
3292 2020-03-03  Hannes Domani  <ssbssa@yahoo.de>
3293
3294         * windows-tdep.c (windows_solib_create_inferior_hook): New function.
3295         (windows_init_abi): Set and use windows_so_ops.
3296
3297 2020-03-03  Sergio Durigan Junior  <sergiodj@redhat.com>
3298
3299         * printcmd.c (print_c_string): Check also for TYPE_CODE_PTR
3300         when verifying if dealing with a convenience variable.
3301
3302 2020-03-03  Luis Machado  <luis.machado@linaro.org>
3303
3304         * auxv.c (default_print_auxv_entry): Add new AUXV entries.
3305
3306 2020-03-02  Simon Marchi  <simon.marchi@polymtl.ca>
3307
3308         * infrun.c (gdbarch_supports_displaced_stepping): New.
3309         (use_displaced_stepping): Break up conditions in smaller pieces.
3310         Use gdbarch_supports_displaced_stepping.
3311         (displaced_step_prepare_throw): Use
3312         gdbarch_supports_displaced_stepping.
3313
3314 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3315
3316         * NEWS: Mention new behaviour of the history filename.
3317         * top.c (write_history_p): Add comment.
3318         (show_write_history_p): Add header comment, give a different
3319         message when history writing is on, but the history filename is
3320         empty.
3321         (history_filename): Add comment.
3322         (history_filename_empty): New function.
3323         (show_history_filename): Add header comment, give a different
3324         message when the filename is empty.
3325         (init_history): Compare history_filename against nullptr, and only
3326         read history if the filename is not empty.
3327         (set_history_filename): Add header comment, and only make
3328         non-empty filenames absolute.
3329         (init_main): Make the filename argument to 'set history filename'
3330         optional.
3331
3332 2020-03-02  Christian Biesinger  <cbiesinger@google.com>
3333
3334         * arm-nbsd-nat.c (arm_supply_fparegset): Rename to...
3335         (arm_supply_vfpregset): ...this, and update to use VFP registers.
3336         (fetch_fp_register): Update.
3337         (fetch_fp_regs): Update.
3338         (store_fp_register): Update.
3339         (store_fp_regs): Update.
3340         (arm_netbsd_nat_target::read_description): New function.
3341         (fetch_elfcore_registers): Update.
3342
3343 2020-03-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3344
3345         * remote.c (remote_target::remote_parse_stop_reply): Don't use the
3346         general_thread if the stop reply is missing a thread-id.
3347         (remote_target::process_stop_reply): Use the first non-exited
3348         thread if the target didn't pass a thread-id.
3349         * infrun.c (do_target_wait): Move call to
3350         switch_to_inferior_no_thread to ....
3351         (do_target_wait_1): ... here.
3352
3353 2020-02-29  Jon Turney  <jon.turney@dronecode.org.uk>
3354
3355         * debuginfod-support.c: Include defs.h first.
3356
3357 2020-02-28  Tom de Vries  <tdevries@suse.de>
3358
3359         * symfile.c (set_initial_language): Use default language for lookup.
3360
3361 2020-02-28  Simon Marchi  <simon.marchi@efficios.com>
3362
3363         * dwarf2/read.c (cutu_reader::init_tu_and_read_dwo_dies): Remove
3364         reader variable, pass `this` to read_cutu_die_from_dwo.
3365
3366 2020-02-27  Aaron Merey  <amerey@redhat.com>
3367
3368         * source.c (open_source_file): Check for nullptr when computing
3369         srcpath.
3370
3371 2020-02-27  Tom Tromey  <tromey@adacore.com>
3372
3373         * dwarf2/read.c (struct field_info) <nfields>: Now a method, not a
3374         member.
3375         (dwarf2_add_field): Don't update nfields.
3376         (dwarf2_attach_fields_to_type, process_structure_scope): Update.
3377
3378 2020-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
3379
3380         * gdbtypes.c (create_array_type_with_stride): Use std::abs not
3381         abs.
3382
3383 2020-02-26  Tom Tromey  <tom@tromey.com>
3384
3385         * dwarf2/read.c (struct dwarf2_include_psymtab): New.
3386         (dwarf2_create_include_psymtab): Use dwarf2_include_psymtab.
3387         (dwarf2_psymtab::expand_psymtab, dwarf2_psymtab::readin_p)
3388         (dwarf2_psymtab::get_compunit_symtab): Remove null checks for
3389         per_cu_data.
3390
3391 2020-02-26  Tom Tromey  <tom@tromey.com>
3392
3393         * dwarf2/index-write.c (psym_index_map): Change type.
3394         (add_address_entry_worker, write_one_signatured_type)
3395         (recursively_count_psymbols, recursively_write_psymbols)
3396         (class debug_names, psyms_seen_size, write_gdbindex)
3397         (write_debug_names): Use partial_symtab, not dwarf2_psymtab.
3398
3399 2020-02-26  Aaron Merey  <amerey@redhat.com>
3400
3401         * Makefile.in: Handle optional debuginfod support.
3402         * NEWS: Update.
3403         * README: Add --with-debuginfod summary.
3404         * config.in: Regenerate.
3405         * configure: Regenerate.
3406         * configure.ac: Handle optional debuginfod support.
3407         * debuginfod-support.c: debuginfod helper functions.
3408         * debuginfod-support.h: Ditto.
3409         * doc/gdb.texinfo: Add --with-debuginfod to configure options
3410         summary.
3411         * dwarf2/read.c (dwarf2_get_dwz_file): Query debuginfod servers
3412         when a dwz file cannot be found.
3413         * elfread.c (elf_symfile_read): Query debuginfod servers when a
3414         debuginfo file cannot be found.
3415         * source.c (open_source_file): Query debuginfod servers when a
3416         source file cannot be found.
3417         * top.c (print_gdb_configuration): Include
3418         --{with,without}-debuginfod in the output.
3419
3420 2020-02-26  Jérémie Galarneau  <jeremie.galarneau@efficios.com>
3421
3422         * thread.c (thr_try_catch_cmd): Print thread name.
3423
3424 2020-02-26  Simon Marchi  <simon.marchi@efficios.com>
3425
3426         * dwarf2/loc.h (dwarf2_fetch_die_loc_sect_off,
3427         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3428         dwarf2_fetch_die_type_sect_off): Move to...
3429         * dwarf2/read.h (dwarf2_fetch_die_loc_sect_off,
3430         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3431         dwarf2_fetch_die_type_sect_off): ... here.
3432         * dwarf2/read.c (dwarf2_fetch_die_loc_sect_off,
3433         dwarf2_fetch_die_loc_cu_off, dwarf2_fetch_constant_bytes,
3434         dwarf2_fetch_die_type_sect_off): Move doc to header file.
3435
3436 2020-02-26  Tom de Vries  <tdevries@suse.de>
3437
3438         PR gdb/25603
3439         * symfile.c (set_initial_language): Exit-early if
3440         language_mode == language_mode_manual.
3441
3442 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3443
3444         * dwarf2/loc.h (dwarf2_read_addr_index): Move...
3445         * dwarf2/read.h (dwarf2_read_addr_index): ... here.
3446         * dwarf2/read.c (dwarf2_read_addr_index): Move doc to header.
3447
3448 2020-02-25  Andrew Burgess  <andrew.burgess@embecosm.com>
3449
3450         * gdbtypes.c (create_array_type_with_stride): Handle negative
3451         array strides.
3452         * valarith.c (value_subscripted_rvalue): Likewise.
3453
3454 2020-02-25  Luis Machado  <luis.machado@linaro.org>
3455
3456         * aarch64-tdep.c (aarch64_vnv_type): Fix comment typo.
3457
3458 2020-02-25  Simon Marchi  <simon.marchi@polymtl.ca>
3459
3460         * loc.h (dwarf2_get_die_type): Move to...
3461         * read.h (dwarf2_get_die_type): ... here.
3462         * read.c (dwarf2_get_die_type): Move doc to header.
3463
3464 2020-02-25  Joel Brobecker  <brobecker@adacore.com>
3465
3466         * copypright.py (EXCLUDE_LIST): Add 'gnulib/config.in' and
3467         'gnulib/Makefile.in' to the list.
3468
3469 2020-02-24  Tom Tromey  <tom@tromey.com>
3470
3471         * dwarf2/read.h (struct type_unit_unshareable) <num_symtabs>:
3472         Remove.
3473         * dwarf2/read.c (dwarf2_cu::setup_type_unit_groups): Use
3474         XOBNEWVEC.
3475
3476 2020-02-24  Tom Tromey  <tom@tromey.com>
3477
3478         * dwarf2/read.h (struct dwarf2_per_cu_data) <type_unit_group_p>:
3479         New method.
3480         * dwarf2/read.c (IS_TYPE_UNIT_GROUP): Remove.
3481         (dw2_do_instantiate_symtab, dw2_get_file_names)
3482         (build_type_psymtab_dependencies, load_full_type_unit): Update.
3483
3484 2020-02-24  Tom Tromey  <tom@tromey.com>
3485
3486         * dwarf2read.c (dwarf2_build_psymtabs_hard): Use
3487         make_scoped_restore.
3488         (dwarf2_psymtab::read_symtab): Don't clear
3489         reading_partial_symbols.
3490
3491 2020-02-24  Tom de Vries  <tdevries@suse.de>
3492
3493         PR gdb/25592
3494         * stack.c (iterate_over_block_locals): Handle LOC_CONST.
3495
3496 2020-02-24  Tom de Vries  <tdevries@suse.de>
3497
3498         * tui/tui-layout.c (_initialize_tui_layout): Fix help messages for
3499         commands layout next/prev/regs.
3500
3501 2020-02-22  Tom Tromey  <tom@tromey.com>
3502
3503         * dwarf2/loc.h (dwarf2_compile_expr_to_ax): Don't declare.
3504         * dwarf2/loc.c (dwarf2_compile_expr_to_ax): Now static.
3505
3506 2020-02-22  Tom Tromey  <tom@tromey.com>
3507
3508         * tui/tui-data.h (TUI_DISASM_WIN): Cast to tui_disasm_window.
3509
3510 2020-02-22  Tom Tromey  <tom@tromey.com>
3511
3512         * tui/tui-win.c (_initialize_tui_win): Add usage text.
3513         * tui/tui-stack.c (_initialize_tui_stack): Add usage text.
3514         * tui/tui-regs.c (_initialize_tui_regs): Add usage text.
3515         * tui/tui.c (_initialize_tui): Add usage text.
3516
3517 2020-02-22  Tom Tromey  <tom@tromey.com>
3518
3519         * tui/tui-win.c (tui_set_focus_command)
3520         (tui_set_win_height_command): Use error_no_arg.
3521         (_initialize_tui_win): Update help text.
3522         (FOCUS_USAGE, WIN_HEIGHT_USAGE): Don't define.
3523
3524 2020-02-22  Tom Tromey  <tom@tromey.com>
3525
3526         * tui/tui-layout.c (extract_display_start_addr): Rewrite.
3527         * tui/tui-disasm.h (struct tui_disasm_window)
3528         <display_start_addr>: Declare.
3529         * tui/tui-source.h (struct tui_source_window)
3530         <display_start_addr>: Declare.
3531         * tui/tui-winsource.h (struct tui_source_window_base)
3532         <show_source_line, display_start_addr>: New methods.
3533         <m_horizontal_offset, m_start_line_or_addr, m_gdbarch, m_content>:
3534         Rename and move to protected section.
3535         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
3536         (tui_source_window_base::do_erase_source_content): Update.
3537         (tui_source_window_base::show_source_line): Now a method.
3538         (tui_source_window_base::show_source_content)
3539         (tui_source_window_base::tui_source_window_base)
3540         (tui_source_window_base::rerender)
3541         (tui_source_window_base::refill)
3542         (tui_source_window_base::do_scroll_horizontal)
3543         (tui_source_window_base::set_is_exec_point_at)
3544         (tui_source_window_base::update_breakpoint_info)
3545         (tui_source_window_base::update_exec_info): Update.
3546         * tui/tui-source.c (tui_source_window::set_contents)
3547         (tui_source_window::showing_source_p)
3548         (tui_source_window::do_scroll_vertical)
3549         (tui_source_window::location_matches_p)
3550         (tui_source_window::line_is_displayed): Update.
3551         (tui_source_window::display_start_addr): New method.
3552         * tui/tui-disasm.c (tui_disasm_window::set_contents)
3553         (tui_disasm_window::do_scroll_vertical)
3554         (tui_disasm_window::location_matches_p): Update.
3555         (tui_disasm_window::display_start_addr): New method.
3556
3557 2020-02-22  Tom Tromey  <tom@tromey.com>
3558
3559         * NEWS: Add entry for gdb.register_window_type.
3560         * tui/tui-layout.h (window_factory): New typedef.
3561         (tui_register_window): Declare.
3562         * tui/tui-layout.c (saved_tui_windows): New global.
3563         (tui_apply_current_layout): Use it.
3564         (tui_register_window): New function.
3565         * python/python.c (do_start_initialization): Call
3566         gdbpy_initialize_tui.
3567         (python_GdbMethods): Add "register_window_type" function.
3568         * python/python-internal.h (gdbpy_register_tui_window)
3569         (gdbpy_initialize_tui): Declare.
3570         * python/py-tui.c: New file.
3571         * Makefile.in (SUBDIR_PYTHON_SRCS): Add py-tui.c.
3572
3573 2020-02-22  Tom Tromey  <tom@tromey.com>
3574
3575         * tui/tui-io.c (do_tui_putc): Don't omit annotations.
3576
3577 2020-02-22  Tom Tromey  <tom@tromey.com>
3578
3579         * tui/tui-win.c (tui_set_win_focus_to): Move to tui-data.c.
3580         * tui/tui-data.h (tui_set_win_with_focus): Don't declare.
3581         * tui/tui-data.c (tui_set_win_with_focus): Remove.
3582         (tui_set_win_focus_to): Move from tui-win.c.
3583
3584 2020-02-22  Tom Tromey  <tom@tromey.com>
3585
3586         * tui/tui-layout.c (make_standard_window, get_locator_window): New
3587         functions.
3588         (known_window_types): New global.
3589         (tui_get_window_by_name): Reimplement.
3590         (initialize_known_windows): New function.
3591         (validate_window_name): Rewrite.
3592         (_initialize_tui_layout): Call initialize_known_windows.
3593
3594 2020-02-22  Tom Tromey  <tom@tromey.com>
3595
3596         * tui/tui.h (enum tui_win_type) <LOCATOR_WIN, DATA_ITEM_WIN>:
3597         Remove constants.
3598         * tui/tui-winsource.h (struct tui_source_window_base)
3599         <tui_source_window_base>: Remove parameter.
3600         * tui/tui-winsource.c
3601         (tui_source_window_base::tui_source_window_base): Remove
3602         parameter.
3603         (tui_source_window_base::refill): Update.
3604         * tui/tui-stack.h (struct tui_locator_window)
3605         <tui_locator_window>: Update.
3606         * tui/tui-source.h (struct tui_source_window) <tui_source_window>:
3607         Default the constructor.
3608         * tui/tui-regs.h (struct tui_data_item_window)
3609         <tui_data_item_window>: Default the constructor.
3610         (struct tui_data_window) <tui_data_window>: Likewise.
3611         * tui/tui-disasm.h (struct tui_disasm_window) <tui_disasm_window>:
3612         Default the constructor.
3613         * tui/tui-data.h (struct tui_gen_win_info) <tui_gen_win_info>:
3614         Default the constructor.
3615         <type>: Remove.
3616         (struct tui_win_info) <tui_win_info>: Default the constructor.
3617         * tui/tui-data.c (tui_win_info::tui_win_info): Remove.
3618         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
3619         Default the constructor.
3620
3621 2020-02-22  Tom Tromey  <tom@tromey.com>
3622
3623         * tui/tui-wingeneral.h (tui_make_all_invisible): Don't declare.
3624         * tui/tui-wingeneral.c (tui_make_all_invisible): Remove.
3625         * tui/tui-win.c (tui_resize_all): Don't call
3626         tui_delete_invisible_windows.
3627         * tui/tui-layout.c (tui_apply_current_layout): Delete windows when
3628         done.
3629         (tui_set_layout): Update.
3630         (tui_add_win_to_layout): Don't call tui_delete_invisible_windows.
3631         * tui/tui-data.h (tui_delete_invisible_windows): Don't declare.
3632         * tui/tui-data.c (tui_delete_invisible_windows): Remove.
3633
3634 2020-02-22  Tom Tromey  <tom@tromey.com>
3635
3636         * tui/tui-win.c (tui_partial_win_by_name): Handle ambiguity
3637         correctly.
3638
3639 2020-02-22  Tom Tromey  <tom@tromey.com>
3640
3641         * tui/tui-data.c (tui_next_win, tui_prev_win): Reimplement.
3642
3643 2020-02-22  Tom Tromey  <tom@tromey.com>
3644
3645         * tui/tui-winsource.h (struct tui_source_window_iterator)
3646         <inner_iterator>: New etytypedef.
3647         <tui_source_window_iterator>: Take "end" parameter.
3648         <tui_source_window_iterator>: Take iterator.
3649         <operator*, advance>: Update.
3650         <m_iter>: Change type.
3651         <m_end>: New field.
3652         (struct tui_source_windows) <begin, end>: Update.
3653         * tui/tui-layout.c (tui_windows): New global.
3654         (tui_apply_current_layout): Clear tui_windows.
3655         (tui_layout_window::apply): Update tui_windows.
3656         * tui/tui-data.h (tui_windows): Declare.
3657         (all_tui_windows): Now inline function.
3658         (class tui_window_iterator, struct all_tui_windows): Remove.
3659
3660 2020-02-22  Tom Tromey  <tom@tromey.com>
3661
3662         PR tui/17850:
3663         * tui/tui-win.c (tui_gen_win_info::max_width): New method.
3664         * tui/tui-layout.h (class tui_layout_base) <get_sizes>: Add
3665         "height" argument.
3666         (class tui_layout_window) <get_sizes>: Likewise.
3667         (class tui_layout_split) <tui_layout_split>: Add "vertical"
3668         argument.
3669         <get_sizes>: Add "height" argument.
3670         <m_vertical>: New field.
3671         * tui/tui-layout.c (tui_layout_split::clone): Update.
3672         (tui_layout_split::get_sizes): Add "height" argument.
3673         (tui_layout_split::adjust_size, tui_layout_split::apply): Update.
3674         (tui_new_layout_command): Parse "-horizontal".
3675         (_initialize_tui_layout): Update help string.
3676         (tui_layout_split::specification): Add "-horizontal" when needed.
3677         * tui/tui-layout.c (tui_layout_window::get_sizes): Add "height"
3678         argument.
3679         * tui/tui-data.h (struct tui_gen_win_info) <max_width, min_width>:
3680         New methods.
3681
3682 2020-02-22  Tom Tromey  <tom@tromey.com>
3683
3684         * tui/tui-layout.h (enum tui_adjust_result): New.
3685         (class tui_layout_base) <adjust_size>: Return tui_adjust_result.
3686         (class tui_layout_window) <adjust_size>: Return
3687         tui_adjust_result.  Rewrite.
3688         (class tui_layout_split) <adjust_size>: Return tui_adjust_result.
3689         * tui/tui-layout.c (tui_layout_split::adjust_size): Update.
3690
3691 2020-02-22  Tom Tromey  <tom@tromey.com>
3692
3693         * tui/tui-layout.h (class tui_layout_split) <add_split>: Change
3694         parameter and return types.
3695         (class tui_layout_base) <specification>: Add "depth".
3696         (class tui_layout_window) <specification>: Add "depth".
3697         (class tui_layout_split) <specification>: Add "depth".
3698         * tui/tui-layout.c (tui_layout_split::add_split): Change parameter
3699         and return types.
3700         (tui_new_layout_command): Parse sub-layouts.
3701         (_initialize_tui_layout): Update help string.
3702         (tui_layout_window::specification): Add "depth".
3703         (add_layout_command): Update.
3704
3705 2020-02-22  Tom Tromey  <tom@tromey.com>
3706
3707         * NEWS: Add "tui new-layout" item.
3708         * tui/tui-layout.c (add_layout_command): Return cmd_list_element.
3709         Add new-layout command to help text.
3710         (validate_window_name): New function.
3711         (tui_new_layout_command): New function.
3712         (_initialize_tui_layout): Register "new-layout".
3713         (tui_layout_window::specification): New method.
3714         (tui_layout_window::specification): New method.
3715         * tui/tui-layout.h (class tui_layout_base) <specification>: New
3716         method.
3717         (class tui_layout_window) <specification>: New method.
3718         (class tui_layout_split) <specification>: New method.
3719
3720 2020-02-22  Tom Tromey  <tom@tromey.com>
3721
3722         * tui/tui.c (tui_enable): Call tui_set_initial_layout.
3723         * tui/tui-win.c (window_name_completer): Update comment.
3724         * tui/tui-layout.h (class tui_layout_base) <replace_window>:
3725         Declare method.
3726         (class tui_layout_window) <replace_window>: Likewise.
3727         (class tui_layout_split) <replace_window>: Likewise.
3728         (tui_set_layout): Don't declare.
3729         (tui_set_initial_layout): Declare function.
3730         * tui/tui-layout.c (layouts, applied_skeleton, src_regs_layout)
3731         (asm_regs_layout): New globals.
3732         (tui_current_layout, show_layout): Remove.
3733         (tui_set_layout, tui_add_win_to_layout): Rewrite.
3734         (find_layout, tui_apply_layout): New function.
3735         (layout_completer): Remove.
3736         (tui_next_layout): Reimplement.
3737         (tui_next_layout_command): New function.
3738         (tui_set_initial_layout, tui_prev_layout_command): New functions.
3739         (tui_regs_layout): Reimplement.
3740         (tui_regs_layout_command): New function.
3741         (extract_display_start_addr): Rewrite.
3742         (next_layout, prev_layout): Remove.
3743         (tui_layout_window::replace_window): New method.
3744         (tui_layout_split::replace_window): New method.
3745         (destroy_layout): New function.
3746         (layout_list): New global.
3747         (add_layout_command): New function.
3748         (initialize_layouts): Update.
3749         (tui_layout_command): New function.
3750         (_initialize_tui_layout): Install "layout" commands.
3751         * tui/tui-data.h (enum tui_layout_type): Remove.
3752         (tui_current_layout): Don't declare.
3753
3754 2020-02-22  Tom Tromey  <tom@tromey.com>
3755
3756         * tui/tui-regs.c (tui_reg_layout): Remove.
3757         (tui_reg_command): Use tui_regs_layout.
3758         * tui/tui-layout.h (tui_reg_command): Declare.
3759         * tui/tui-layout.c (tui_reg_command): New function.
3760
3761 2020-02-22  Tom Tromey  <tom@tromey.com>
3762
3763         * tui/tui.c (tui_rl_delete_other_windows): Call
3764         tui_remove_some_windows.
3765         * tui/tui-layout.h (class tui_layout_base) <remove_windows>:
3766         Declare method.
3767         (class tui_layout_window) <remove_windows>: New method.
3768         (class tui_layout_split) <remove_windows>: Declare.
3769         (tui_remove_some_windows): Declare.
3770         * tui/tui-layout.c (tui_remove_some_windows): New function.
3771         (tui_layout_split::remove_windows): New method.
3772
3773 2020-02-22  Tom Tromey  <tom@tromey.com>
3774
3775         * tui/tui.c (tui_rl_change_windows): Call tui_next_layout.
3776         * tui/tui-layout.h (tui_next_layout): Declare.
3777         * tui/tui-layout.c (tui_next_layout): New function.
3778
3779 2020-02-22  Tom Tromey  <tom@tromey.com>
3780
3781         * tui/tui-regs.c (tui_data_window::display_registers_from): Use
3782         correct coordinates.
3783
3784 2020-02-22  Tom Tromey  <tom@tromey.com>
3785
3786         * tui/tui-layout.h (tui_add_win_to_layout): Add comment.
3787         * tui/tui-layout.c (tui_add_win_to_layout): Add assert.  Remove
3788         DATA_WIN case.
3789
3790 2020-02-22  Tom Tromey  <tom@tromey.com>
3791
3792         * tui/tui-disasm.c (tui_get_low_disassembly_address): Use
3793         TUI_DISASM_WIN, not tui_win_list.
3794
3795 2020-02-22  Tom Tromey  <tom@tromey.com>
3796
3797         * valprint.c (generic_val_print_enum_1)
3798         (val_print_type_code_flags): Style member names.
3799         * rust-lang.c (val_print_struct, rust_print_enum)
3800         (rust_print_struct_def, rust_internal_print_type): Style member
3801         names.
3802         * p-valprint.c (pascal_object_print_value_fields): Style member
3803         names.  Only call fprintf_symbol_filtered for static members.
3804         * m2-typeprint.c (m2_record_fields, m2_enum): Style member names.
3805         * f-valprint.c (f_val_print): Style member names.
3806         * f-typeprint.c (f_type_print_base): Style member names.
3807         * cp-valprint.c (cp_print_value_fields): Style member names.  Only
3808         call fprintf_symbol_filtered for static members.
3809         (cp_print_class_member): Style member names.
3810         * c-typeprint.c (c_print_type_1, c_type_print_base_1): Style
3811         member names.
3812         * ada-valprint.c (ada_print_scalar): Style enum names.
3813         (ada_val_print_enum): Likewise.
3814         * ada-typeprint.c (print_enum_type): Style enum names.
3815
3816 2020-02-21  Tom Tromey  <tom@tromey.com>
3817
3818         * psympriv.h (struct partial_symtab): Update comment.
3819
3820 2020-02-21  Tom Tromey  <tromey@adacore.com>
3821
3822         * mips-tdep.h (mips_pc_is_mips16, mips_pc_is_micromips): Parameter
3823         type is CORE_ADDR.
3824
3825 2020-02-21  Tom de Vries  <tdevries@suse.de>
3826
3827         PR gdb/25534
3828         * psymtab.c (partial_symtab::read_dependencies): Don't read dependency
3829         if dependencies[i]->user != NULL.
3830
3831 2020-02-21  Ali Tamur  <tamur@google.com>
3832
3833         * dwarf2/read.c (dwarf2_name): Add null check.
3834
3835 2020-02-20  Tom Tromey  <tom@tromey.com>
3836
3837         * dwarf2/read.c (dwarf2_find_containing_comp_unit): Use ">", not
3838         ">=", in binary search.
3839         (dwarf2_find_containing_comp_unit): New overload.
3840         (run_test): New self-test.
3841         (_initialize_dwarf2_read): Register new test.
3842
3843 2020-02-20  Nelson Chu  <nelson.chu@sifive.com>
3844
3845         * riscv-tdep.c: Updated since the DECLARE_CSR is changed.
3846         * riscv-tdep.h: Likewise.
3847         * features/riscv/rebuild-csr-xml.sh: Generate the 64bit-csr.xml without
3848         rv32-only CSR.
3849         * features/riscv/64bit-csr.xml: Regenerated.
3850
3851 2020-02-20  Sergio Durigan Junior  <sergiodj@redhat.com>
3852             Tom Tromey  <tom@tromey.com>
3853
3854         * utils.c (fputs_maybe_filtered): Call 'stream->puts' instead
3855         of 'fputc_unfiltered'.
3856         (putchar_unfiltered): Call 'fputc_unfiltered'.
3857         (fputc_unfiltered): Call 'fputs_unfiltered'.
3858
3859 2020-02-20  Andrew Burgess  <andrew.burgess@embecosm.com>
3860
3861         * config.in: Regenerate.
3862         * configure: Regenerate.
3863         * configure.ac: Add --with-python-libdir option.
3864         * main.c: Use WITH_PYTHON_LIBDIR.
3865
3866 2020-02-19  Tom Tromey  <tom@tromey.com>
3867
3868         * symtab.c (general_symbol_info::compute_and_set_names): Use
3869         obstack_strndup.  Simplify call to symbol_set_demangled_name.
3870
3871 2020-02-19  Simon Marchi  <simon.marchi@efficios.com>
3872
3873         * dwarf2/read.c (allocate_signatured_type_table,
3874         allocate_dwo_unit_table, allocate_type_unit_groups_table,
3875         allocate_dwo_file_hash_table, allocate_dwp_loaded_cutus_table):
3876         Remove objfile parameter, update all callers.
3877
3878 2020-02-19  Doug Evans  <dje@google.com>
3879
3880         PR rust/25535
3881         * rust-lang.c (rust_print_enum): Apply embedded_offset to
3882         rust_enum_variant calculation.
3883
3884 2020-02-19  Tom Tromey  <tromey@adacore.com>
3885
3886         * mips-tdep.h (mips_pc_is_mips): Parameter type is CORE_ADDR.
3887
3888 2020-02-19  Tom Tromey  <tromey@adacore.com>
3889
3890         * ada-lang.c (cache_symbol): Use obstack_strdup.
3891
3892 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3893
3894         * configure: Regenerate.
3895
3896 2020-02-19  Tom Tromey  <tromey@adacore.com>
3897
3898         * python/python.c (do_start_initialization): Use XNEWVEC.  Remove
3899         NULL check.
3900
3901 2020-02-19  Maciej W. Rozycki  <macro@wdc.com>
3902
3903         * NEWS: Mention RISC-V GNU/Linux GDBserver support.
3904
3905 2020-02-19  Andrew Burgess  <andrew.burgess@embecosm.com>
3906
3907         * arch/riscv.c (struct riscv_gdbarch_features_hasher): Only define
3908         if GDBSERVER is not defined.
3909         (riscv_tdesc_cache): Likewise, also store const target_desc.
3910         (STATIC_IN_GDB): Define.
3911         (riscv_create_target_description): Update declaration with
3912         STATIC_IN_GDB.
3913         (riscv_lookup_target_description): New function, only define if
3914         GDBSERVER is not defined.
3915         * arch/riscv.h (riscv_create_target_description): Declare only
3916         when GDBSERVER is defined.
3917         (riscv_lookup_target_description): New declaration when GDBSERVER
3918         is not defined.
3919         * nat/riscv-linux-tdesc.c (riscv_linux_read_description): Rename to...
3920         (riscv_linux_read_features): ...this, and return
3921         riscv_gdbarch_features instead of target_desc.
3922         * nat/riscv-linux-tdesc.h: Include 'arch/riscv.h'.
3923         (riscv_linux_read_description): Rename to...
3924         (riscv_linux_read_features): ...this.
3925         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
3926         Update to use riscv_gdbarch_features and
3927         riscv_lookup_target_description.
3928         * riscv-tdep.c (riscv_find_default_target_description): Use
3929         riscv_lookup_target_description instead of
3930         riscv_create_target_description.
3931
3932 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3933
3934         * valprint.c (generic_val_print_enum_1): When printing a flag
3935         enum with value 0 and there is no enumerator with value 0, print
3936         just "0" instead of "(unknown: 0x0)".
3937
3938 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3939
3940         * valprint.c (generic_val_print_enum_1): Print unknown part of
3941         flag enum in hex.
3942
3943 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3944
3945         * dwarf2/read.c (update_enumeration_type_from_children): Allow
3946         flag enums to contain duplicate enumerators.
3947         * valprint.c (generic_val_print_enum_1): Update comment.
3948
3949 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3950
3951         * dwarf2/read.c: Include "count-one-bits.h".
3952         (update_enumeration_type_from_children): If an enumerator has
3953         multiple bits set, don't treat the enumeration as a "flag enum".
3954         * valprint.c (generic_val_print_enum_1): Assert that enumerators
3955         of flag enums have 0 or 1 bit set.
3956
3957 2020-02-18  Bernd Edlinger  <bernd.edlinger@hotmail.de>
3958
3959         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use an explicit
3960         conversion.
3961         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3962         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
3963         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3964         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
3965         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3966
3967 2020-02-18  Simon Marchi  <simon.marchi@efficios.com>
3968
3969         * MAINTAINERS: Change palmer@sifive.com to palmer@dabbelt.com.
3970
3971 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
3972
3973         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Use
3974         displaced_step_closure_up.
3975         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
3976         (struct displaced_step_closure_up):
3977         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
3978         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
3979         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn):
3980         Likewise.
3981         * gdbarch.sh (displaced_step_copy_insn): Likewise.
3982         * gdbarch.c, gdbarch.h: Re-generate.
3983         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Use
3984         displaced_step_closure_up.
3985         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
3986         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
3987         * infrun.h (displaced_step_closure_up): New type alias.
3988         (struct displaced_step_inferior_state) <step_closure>: Change
3989         type to displaced_step_closure_up.
3990         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Use
3991         displaced_step_closure_up.
3992         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
3993
3994 2020-02-14  Tom Tromey  <tom@tromey.com>
3995
3996         * minidebug.c (gnu_debug_key): New global.
3997         (find_separate_debug_file_in_section): Use it.
3998
3999 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4000
4001         * gdbarch.sh (displaced_step_copy_insn): Change return type to an
4002         std::unique_ptr.
4003         * gdbarch.c: Re-generate.
4004         * gdbarch.h: Re-generate.
4005         * infrun.c (displaced_step_prepare_throw): Adjust to std::unique_ptr
4006         change.
4007         * aarch64-tdep.c (aarch64_displaced_step_copy_insn): Change return
4008         type to std::unique_ptr.
4009         * aarch64-tdep.h (aarch64_displaced_step_copy_insn): Likewise.
4010         * amd64-tdep.c (amd64_displaced_step_copy_insn): Likewise.
4011         * amd64-tdep.h (amd64_displaced_step_copy_insn): Likewise.
4012         * arm-linux-tdep.c (arm_linux_displaced_step_copy_insn): Likewise.
4013         * i386-linux-tdep.c (i386_linux_displaced_step_copy_insn): Likewise.
4014         * i386-tdep.c (i386_displaced_step_copy_insn): Likewise.
4015         * i386-tdep.h (i386_displaced_step_copy_insn): Likewise.
4016         * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise.
4017         * s390-tdep.c (s390_displaced_step_copy_insn): Likewise.
4018
4019 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4020
4021         * infrun.c (get_displaced_step_closure_by_addr): Adjust to
4022         std::unique_ptr.
4023         (displaced_step_clear): Rename to...
4024         (displaced_step_reset): ... this.  Just call displaced->reset ().
4025         (displaced_step_clear_cleanup): Rename to...
4026         (displaced_step_reset_cleanup): ... this.
4027         (displaced_step_prepare_throw): Adjust to std::unique_ptr.
4028         (displaced_step_fixup): Likewise.
4029         (resume_1): Likewise.
4030         (handle_inferior_event): Restore child's memory before calling
4031         displaced_step_fixup on the parent.
4032         * infrun.h (displaced_step_inferior_state) <reset>: Adjust
4033         to std::unique_ptr.
4034         <step_closure>: Change type to std::unique_ptr.
4035
4036 2020-02-14  Simon Marchi  <simon.marchi@efficios.com>
4037
4038         * arm-tdep.c: Include count-one-bits.h.
4039         (cleanup_block_store_pc): Use count_one_bits.
4040         (cleanup_block_load_pc): Use count_one_bits.
4041         (arm_copy_block_xfer): Use count_one_bits.
4042         (thumb2_copy_block_xfer): Use count_one_bits.
4043         (thumb_copy_pop_pc_16bit): Use count_one_bits.
4044         * arch/arm-get-next-pcs.c: Include count-one-bits.h.
4045         (thumb_get_next_pcs_raw): Use count_one_bits.
4046         (arm_get_next_pcs_raw): Use count_one_bits_l.
4047         * arch/arm.c (bitcount): Remove.
4048         * arch/arm.h (bitcount): Remove.
4049
4050 2020-02-14  Tom Tromey  <tromey@adacore.com>
4051
4052         * dwarf2/frame-tailcall.c (dwarf2_tailcall_sniffer_first):
4053         Update.
4054         * dwarf2/loc.h (call_site_find_chain): Return unique_xmalloc_ptr.
4055         * dwarf2/loc.c (call_site_find_chain_1): Return
4056         unique_xmalloc_ptr.
4057         (call_site_find_chain): Likewise.
4058
4059 2020-02-14  Richard Biener  <rguenther@suse.de>
4060
4061         * dwarf2/read.c (lnp_state_machine::handle_special_opcode): Apply CSE
4062         on expression with division operators.
4063
4064 2020-02-13  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4065
4066         * MAINTAINERS (Write After Approval): Adding myself.
4067
4068 2020-02-12  Tom Tromey  <tom@tromey.com>
4069
4070         * event-loop.c (event_data, gdb_event, event_handler_func):
4071         Remove.
4072
4073 2020-02-12  Tom Tromey  <tom@tromey.com>
4074
4075         * dwarf2/frame.c (dwarf2_frame_bfd_data): New global.
4076         (dwarf2_frame_objfile_data): Add comment.
4077         (find_comp_unit, set_comp_unit): New functions.
4078         (dwarf2_frame_find_fde): Use find_comp_unit.
4079         (dwarf2_build_frame_info): Use set_comp_unit.
4080
4081 2020-02-12  Tom Tromey  <tom@tromey.com>
4082
4083         * dwarf2/frame.c (struct comp_unit) <objfile>: Remove.
4084         (comp_unit): Don't initialize objfile.
4085         (execute_cfa_program): Add text_offset parameter.
4086         (execute_cfa_program_test, dwarf2_fetch_cfa_info)
4087         (dwarf2_frame_cache): Update.
4088         (dwarf2_build_frame_info): Don't set "objfile" member.
4089
4090 2020-02-12  Tom Tromey  <tom@tromey.com>
4091
4092         * dwarf2/frame.c (decode_frame_entry_1): Add gdbarch parameter.
4093         (decode_frame_entry): Likewise.
4094         (dwarf2_build_frame_info): Update.
4095
4096 2020-02-12  Tom Tromey  <tom@tromey.com>
4097
4098         * dwarf2/frame.c (struct comp_unit) <obstack>: New member.
4099         (decode_frame_entry_1): Use the comp_unit obstack.
4100
4101 2020-02-12  Tom Tromey  <tom@tromey.com>
4102
4103         * dwarf2/frame.c (struct comp_unit): Add initializers and
4104         constructor.
4105         (dwarf2_frame_objfile_data): Store a comp_unit.
4106         (dwarf2_frame_find_fde): Update.
4107         (dwarf2_build_frame_info): Use "new".
4108
4109 2020-02-12  Tom Tromey  <tom@tromey.com>
4110
4111         * dwarf2/frame.c (struct dwarf2_fde_table): Remove.
4112         (dwarf2_fde_table): Typedef for std::vector.
4113         (dwarf2_frame_objfile_data): Remove the deleter.  Now static.
4114         (dwarf2_frame_find_fde, add_fde, decode_frame_entry_1)
4115         (decode_frame_entry): Update.
4116         (dwarf2_build_frame_info): Use "new".
4117
4118 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4119
4120         * arm-tdep.c (arm_gdbarch_init): Update.
4121         * arm-tdep.h (struct gdbarch_tdep) <have_fpa_registers,
4122         have_wmmx_registers, have_vfp_pseudos, have_neon_pseudos,
4123         have_neon, is_m>: Change to bool.
4124
4125 2020-02-12  Christian Biesinger  <cbiesinger@google.com>
4126
4127         * arm-tdep.c (arm_dump_tdep): Print more fields of tdep.
4128
4129 2020-02-12  Tom Tromey  <tom@tromey.com>
4130
4131         * dwarf2/loc.c (struct dwarf_expr_baton): Remove.
4132
4133 2020-02-12  Hannes Domani  <ssbssa@yahoo.de>
4134
4135         * windows-tdep.c (struct windows_gdbarch_data): Add tib_ptr_type.
4136         (windows_get_tlb_type): Use windows_gdbarch_data->tib_ptr_type.
4137
4138 2020-02-11  Tom Tromey  <tom@tromey.com>
4139
4140         * psymtab.h: Update comment.
4141
4142 2020-02-11  Tom Tromey  <tom@tromey.com>
4143
4144         * gdb_obstack.h (struct auto_obstack): Use
4145         DISABLE_COPY_AND_ASSIGN.
4146
4147 2020-02-11  Tom Tromey  <tom@tromey.com>
4148
4149         * dwarf2/frame.h (struct objfile): Don't forward declare.
4150
4151 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4152
4153         * cris-tdep.c (cris_supply_gregset): Change signature to match
4154         what struct regset expects.
4155         (cris_regset): New struct.
4156         (fetch_core_registers): Remove.
4157         (cris_iterate_over_regset_sections): New function.
4158         (_initialize_cris_tdep): Don't call deprecated_add_core_fns.
4159         (cris_gdbarch_init): Call set_gdbarch_iterate_over_regset_sections.
4160
4161 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4162
4163         * arch/arm.h (enum gdb_regnum): Add comment for the FP0..7
4164         registers.
4165
4166 2020-02-11  Christian Biesinger  <cbiesinger@google.com>
4167
4168         * arm-tdep.c (arm_dump_tdep): Add \n in fprintf.
4169
4170 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4171
4172         * configure: Re-generate.
4173
4174 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4175
4176         * configure: Re-generate.
4177
4178 2020-02-11  Simon Marchi  <simon.marchi@efficios.com>
4179
4180         * acinclude: Update warning.m4 path.
4181         * warning.m4: Move to gdbsupport.
4182
4183 2020-02-11  Tom Tromey  <tromey@adacore.com>
4184
4185         * remote.c (remote_console_output): Update.
4186         * printcmd.c (printf_command): Update.
4187         * event-loop.c (gdb_wait_for_event): Update.
4188         * linux-nat.c (sigchld_handler): Update.
4189         * remote-sim.c (gdb_os_write_stdout): Update.
4190         (gdb_os_flush_stdout): Update.
4191         (gdb_os_flush_stderr): Update.
4192         (gdb_os_write_stderr): Update.
4193         * exceptions.c (print_exception): Update.
4194         * remote-fileio.c (remote_fileio_func_read): Update.
4195         (remote_fileio_func_write): Update.
4196         * tui/tui.c (tui_enable): Update.
4197         * tui/tui-interp.c (tui_interp::init): Update.
4198         * utils.c (init_page_info): Update.
4199         (putchar_unfiltered, fputc_unfiltered): Update.
4200         (gdb_flush): Update.
4201         (emit_style_escape): Update.
4202         (flush_wrap_buffer, fputs_maybe_filtered): Update.
4203         * ui-file.c (ui_file_isatty, ui_file_read, ui_file_write)
4204         (ui_file_write_async_safe, ui_file_flush, ui_file_puts): Remove.
4205         (stderr_file::write): Update.
4206         (stderr_file::puts): Update.
4207         * ui-file.h (ui_file_isatty, ui_file_write)
4208         (ui_file_write_async_safe, ui_file_read, ui_file_flush)
4209         (ui_file_puts): Don't declare.
4210
4211 2020-02-10  Tom de Vries  <tdevries@suse.de>
4212
4213         * dwarf2/read.c (process_psymtab_comp_unit_reader): Cast concat NULL
4214         sentinel to char *.
4215
4216 2020-02-09  Tom de Vries  <tdevries@suse.de>
4217
4218         * dwarf2read.c (process_psymtab_comp_unit_reader): Append CU offset to
4219         filename if it matches "<artificial>".
4220
4221 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4222
4223         * windows-tdep.c (struct enum_value_name): New struct.
4224         (create_enum): New function.
4225         (windows_get_siginfo_type): Create and use enum types.
4226
4227 2020-02-09  Hannes Domani  <ssbssa@yahoo.de>
4228
4229         * NEWS: Mention $_siginfo support for Windows.
4230         * windows-nat.c (handle_exception): Set siginfo_er.
4231         (windows_nat_target::mourn_inferior): Reset siginfo_er.
4232         (windows_xfer_siginfo): New function.
4233         (windows_nat_target::xfer_partial): Call windows_xfer_siginfo.
4234         * windows-tdep.c (struct windows_gdbarch_data): New struct.
4235         (init_windows_gdbarch_data): New function.
4236         (get_windows_gdbarch_data): New function.
4237         (windows_get_siginfo_type): New function.
4238         (windows_init_abi): Register windows_get_siginfo_type.
4239         (_initialize_windows_tdep): Register init_windows_gdbarch_data.
4240
4241 2020-02-08  Tom Tromey  <tom@tromey.com>
4242
4243         * dwarf2/read.c (class cutu_reader) <cutu_reader,
4244         init_tu_and_read_dwo_dies>: Remove "keep" parameter.
4245         <keep>: Declare method.
4246         <m_keep>: Remove member.
4247         <~cutu_reader>: Remove.
4248         (cutu_reader::init_tu_and_read_dwo_dies): Update.
4249         (cutu_reader::cutu_reader): Update.
4250         (cutu_reader::keep): Rename from ~cutu_reader.
4251         (process_psymtab_comp_unit, build_type_psymtabs_1)
4252         (process_skeletonless_type_unit, load_partial_comp_unit)
4253         (load_full_comp_unit, dwarf2_read_addr_index)
4254         (read_signatured_type): Update.
4255
4256 2020-02-08  Tom Tromey  <tom@tromey.com>
4257
4258         * dwarf2/read.c (process_psymtab_comp_unit_reader): Remove
4259         "want_partial_unit" parameter.
4260         (process_psymtab_comp_unit): Change want_partial_unit to bool.
4261         Inline check for DW_TAG_partial_unit.
4262         (dwarf2_build_psymtabs_hard, scan_partial_symbols): Update.
4263
4264 2020-02-08  Tom Tromey  <tom@tromey.com>
4265
4266         * dwarf2/read.c (read_n_bytes, read_direct_string): Move to
4267         read.c.
4268         * dwarf2/leb.h (read_n_bytes, read_direct_string): Move from
4269         read.c.
4270
4271 2020-02-08  Tom Tromey  <tom@tromey.com>
4272
4273         * dwarf2/read.c (read_address): Move to comp-unit.c.
4274         (dwarf2_rnglists_process, dwarf2_ranges_process)
4275         (read_attribute_value, dwarf_decode_lines_1)
4276         (var_decode_location, decode_locdesc): Update.
4277         * dwarf2/comp-unit.c (comp_unit_head::read_address): Move from
4278         read.c.  Remove "cu" parameter.
4279         * dwarf2/comp-unit.h (struct comp_unit_head) <read_address>: New
4280         method.
4281
4282 2020-02-08  Tom Tromey  <tom@tromey.com>
4283
4284         * dwarf2/read.c (read_attribute_value, read_indirect_string)
4285         (read_indirect_line_string): Update.
4286         * dwarf2/comp-unit.c (read_offset): Remove.
4287         (read_comp_unit_head): Update.
4288         * dwarf2/comp-unit.h (struct comp_unit_head) <read_offset>: New
4289         method.
4290         (read_offset): Don't declare.
4291
4292 2020-02-08  Tom Tromey  <tom@tromey.com>
4293
4294         * Makefile.in (COMMON_SFILES): Add dwarf2/comp-unit.c.
4295         * dwarf2/read.c (struct comp_unit_head): Move to
4296         dwarf2/comp-unit.h.
4297         (enum class rcuh_kind): Move to comp-unit.h.
4298         (get_cu_length, offset_in_cu_p): Now methods on comp_unit_head.
4299         (read_comp_unit_head, error_check_comp_unit_head)
4300         (read_and_check_comp_unit_head): Move to comp-unit.c.
4301         (read_offset, dwarf_unit_type_name): Likewise.
4302         (create_debug_type_hash_table, read_cutu_die_from_dwo)
4303         (cutu_reader::cutu_reader, read_call_site_scope)
4304         (find_partial_die, follow_die_offset): Update.
4305         * dwarf2/comp-unit.h: New file, from dwarf2read.c.
4306
4307 2020-02-08  Tom Tromey  <tom@tromey.com>
4308
4309         * dwarf2/read.c (read_offset_1): Move to leb.c.
4310         (read_abbrev_offset, read_offset, dwarf_decode_line_header)
4311         (dwarf_decode_macro_bytes): Update.
4312         * dwarf2/leb.c (read_offset): Rename; move from read.c.
4313         * dwarf2/leb.h (read_offset): Declare.
4314
4315 2020-02-08  Tom Tromey  <tom@tromey.com>
4316
4317         * dwarf2/read.c (dwarf2_section_size): Remove.
4318         (error_check_comp_unit_head, dwarf2_symbol_mark_computed):
4319         Update.
4320         * dwarf2/section.h (struct dwarf2_section_info) <get_size>: New method.
4321
4322 2020-02-08  Tom Tromey  <tom@tromey.com>
4323
4324         * dwarf2/read.c (read_initial_length): Move to leb.c.
4325         * dwarf2/leb.h (read_initial_length): Declare.
4326         * dwarf2/leb.c (read_initial_length): Move from read.c.  Add
4327         handle_nonstd parameter.
4328         * dwarf2/frame.c (read_initial_length): Remove.
4329         (decode_frame_entry_1): Update.
4330
4331 2020-02-08  Tom Tromey  <tom@tromey.com>
4332
4333         * dwarf2/loc.c (dwarf2_find_location_expression)
4334         (dwarf_evaluate_loc_desc::get_tls_address)
4335         (dwarf_evaluate_loc_desc::push_dwarf_reg_entry_value)
4336         (rw_pieced_value, dwarf2_evaluate_loc_desc_full)
4337         (dwarf2_locexpr_baton_eval, dwarf2_evaluate_property)
4338         (dwarf2_compile_property_to_c)
4339         (dwarf2_loc_desc_get_symbol_read_needs)
4340         (dwarf2_compile_expr_to_ax, locexpr_describe_location)
4341         (locexpr_tracepoint_var_ref, locexpr_generate_c_location)
4342         (loclist_describe_location, loclist_tracepoint_var_ref)
4343         (loclist_generate_c_location): Update.
4344         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
4345         * dwarf2/loc.h (dwarf2_per_cu_objfile, dwarf2_per_cu_addr_size)
4346         (dwarf2_per_cu_ref_addr_size, dwarf2_per_cu_offset_size)
4347         (dwarf2_per_cu_text_offset, dwarf2_version): Don't declare.
4348         * dwarf2/read.c (dwarf2_per_cu_data::objfile)
4349         (dwarf2_per_cu_data::addr_size)
4350         (dwarf2_per_cu_data::ref_addr_size)
4351         (dwarf2_per_cu_data::text_offset)
4352         (dwarf2_per_cu_data::addr_type): Now methods.
4353         (per_cu_header_read_in): Make per_cu "const".
4354         (dwarf2_version): Remove.
4355         (dwarf2_per_cu_data::int_type): Now a method.
4356         (dwarf2_per_cu_data::_addr_sized_int_type): Likewise.
4357         (set_die_type, read_array_type, read_subrange_index_type)
4358         (read_tag_string_type, read_subrange_type): Update.
4359         * dwarf2/read.h (struct dwarf2_per_cu_data) <addr_size,
4360         offset_size, ref_addr_size, text_offset, addr_type, version,
4361         objfile, int_type, addr_sized_int_type>: Declare methods.
4362
4363 2020-02-08  Tom Tromey  <tom@tromey.com>
4364
4365         * dwarf2/read.h (struct dwarf2_per_cu_data) <imported_symtabs>:
4366         Move earlier.
4367
4368 2020-02-08  Tom Tromey  <tom@tromey.com>
4369
4370         * dwarf2/read.h (dwarf_line_debug): Declare.
4371         * Makefile.in (COMMON_SFILES): Add dwarf2/line-header.c.
4372         * dwarf2/read.c: Move line_header code to new files.
4373         (dwarf_line_debug): No longer static.
4374         * dwarf2/line-header.c: New file.
4375         * dwarf2/line-header.h: New file.
4376
4377 2020-02-08  Tom Tromey  <tom@tromey.com>
4378
4379         * dwarf2/read.c (struct line_header) <file_full_name,
4380         file_file_name>: Return unique_xmalloc_ptr.
4381         (line_header::file_file_name): Update.
4382         (line_header::file_full_name): Update.
4383         (dw2_get_file_names_reader): Update.
4384         (macro_start_file): Update.
4385
4386 2020-02-08  Tom Tromey  <tom@tromey.com>
4387
4388         * dwarf2/read.c (struct line_header) <file_full_name,
4389         file_file_name>: Declare methods.
4390         (dw2_get_file_names_reader): Update.
4391         (file_file_name): Now a method.
4392         (file_full_name): Likewise.
4393         (macro_start_file): Update.
4394
4395 2020-02-08  Tom Tromey  <tom@tromey.com>
4396
4397         * dwarf2/read.c (dwarf_always_disassemble)
4398         (show_dwarf_always_disassemble): Move to loc.c.
4399         (_initialize_dwarf2_read): Move "always-disassemble" registration
4400         to loc.c.
4401         * dwarf2/read.h (dwarf_always_disassemble): Don't declare.
4402         * dwarf2/loc.c (dwarf_always_disassemble): Move from read.c.  Now
4403         static.
4404         (show_dwarf_always_disassemble): Move from read.c.
4405         (_initialize_dwarf2loc): Move always-disassemble from read.c.
4406
4407 2020-02-08  Tom Tromey  <tom@tromey.com>
4408
4409         * dwarf2/read.c (~dwarf2_per_objfile): Update.
4410         (create_quick_file_names_table): Return htab_up.
4411         (dw2_get_file_names_reader, dw2_forget_cached_source_info):
4412         Update.
4413         * dwarf2/read.h (struct dwarf2_per_objfile)
4414         <quick_file_names_table>: Now htab_up.
4415
4416 2020-02-08  Tom Tromey  <tom@tromey.com>
4417
4418         * dwarf2/abbrev.c (abbrev_table::read): Simplify.
4419
4420 2020-02-08  Tom Tromey  <tom@tromey.com>
4421
4422         * dwarf2/abbrev.c (abbrev_table): Move constructor from header.
4423         Rewrite.
4424         (abbrev_table::add_abbrev, abbrev_table::lookup_abbrev): Rewrite.
4425         * dwarf2/abbrev.h (struct abbrev_info) <next>: Remove.
4426         (abbrev_table::abbrev_table): No longer inline.
4427         (ABBREV_HASH_SIZE): Remove.
4428         (abbrev_table::m_abbrevs): Now an htab_up.
4429
4430 2020-02-08  Tom Tromey  <tom@tromey.com>
4431
4432         * dwarf2/read.c (read_cutu_die_from_dwo): Update.
4433         (cutu_reader): Update.
4434         (build_type_psymtabs_1): Update.
4435         * dwarf2/abbrev.c (abbrev_table::read): Rename.
4436         (abbrev_table::alloc_abbrev): Update.
4437         * dwarf2/abbrev.h (abbrev_table_up): Move earlier.
4438         (abbrev_table::read): New static method, renamed from
4439         abbrev_table_read_table.
4440         (abbrev_table::alloc_abbrev)
4441         (abbrev_table::add_abbrev): Now private.
4442         (abbrev_table::abbrev_table): Now private.
4443         (abbrev_table::m_abbrev_obstack): Now private.  Rename.
4444
4445 2020-02-08  Tom Tromey  <tom@tromey.com>
4446
4447         * dwarf2/read.c (set_die_type, get_die_type_at_offset): Update.
4448         * dwarf2/read.h (struct dwarf2_per_objfile) <die_type_hash>: Now
4449         htab_up.
4450
4451 2020-02-08  Tom Tromey  <tom@tromey.com>
4452
4453         * dwarf2/read.c (struct dwp_file) <loaded_cus, loaded_tus>: Now
4454         htab_up.
4455         (lookup_dwo_unit_in_dwp): Update.
4456         (allocate_dwp_loaded_cutus_table): Return htab_up.  Don't allocate
4457         on obstack.
4458
4459 2020-02-08  Tom Tromey  <tom@tromey.com>
4460
4461         * dwarf2/read.c (allocate_dwo_file_hash_table): Don't allocate on
4462         obstack.
4463
4464 2020-02-08  Tom Tromey  <tom@tromey.com>
4465
4466         * dwarf2/read.c (~dwarf2_per_objfile): Don't delete
4467         line_header_hash.
4468         (handle_DW_AT_stmt_list): Update.  Don't allocate on obstack.
4469         * dwarf2/read.h (struct dwarf2_per_objfile) <line_header_hash>:
4470         Change type to htab_up.
4471
4472 2020-02-08  Tom Tromey  <tom@tromey.com>
4473
4474         * dwarf2/read.c (allocate_type_unit_groups_table): Return
4475         htab_up.  Don't allocate on obstack.
4476         (get_type_unit_group, dwarf2_build_psymtabs_hard): Update.
4477         * dwarf2/read.h (struct dwarf2_per_objfile) <type_unit_groups>:
4478         Change type to htab_up.
4479
4480 2020-02-08  Tom Tromey  <tom@tromey.com>
4481
4482         * dwarf2/read.h (struct dwarf2_per_objfile) <signatured_types>:
4483         Change type to htab_up.
4484         * dwarf2/read.c (create_signatured_type_table_from_index)
4485         (create_signatured_type_table_from_debug_names)
4486         (create_all_type_units, add_type_unit)
4487         (lookup_dwo_signatured_type, lookup_signatured_type)
4488         (process_skeletonless_type_unit): Update.
4489         (create_debug_type_hash_table, create_debug_types_hash_table):
4490         Change type of types_htab.
4491         (allocate_signatured_type_table, allocate_dwo_unit_table): Return
4492         htab_up.  Don't allocate on obstack.
4493         (create_cus_hash_table): Change type of cus_htab parameter.
4494         (struct dwo_file) <cus, tus>: Now htab_up.
4495         (lookup_dwo_signatured_type, lookup_dwo_cutu)
4496         (process_dwo_file_for_skeletonless_type_units, lookup_dwo_cutu)
4497         (queue_and_load_all_dwo_tus): Update.
4498         * dwarf2/index-write.c (write_gdbindex): Update.
4499         (write_debug_names): Update.
4500
4501 2020-02-08  Tom Tromey  <tom@tromey.com>
4502
4503         * dwarf2/read.h (struct dwarf2_queue_item): Move from
4504         dwarf2/read.c.  Remove "next" member.  Add constructor ntad
4505         destructor.
4506         (struct dwarf2_per_objfile) <queue>: New member.
4507         * dwarf2/read.c (struct dwarf2_queue_item): Move to
4508         dwarf2/read.h.
4509         (dwarf2_queue, dwarf2_queue_tail): Remove.
4510         (class dwarf2_queue_guard): Add parameter to constructor.  Use
4511         DISABLE_COPY_AND_ASSIGN.
4512         <m_per_objfile>: New member.
4513         <~dwarf2_queue_guard>: Rewrite.
4514         (dw2_do_instantiate_symtab, queue_comp_unit, process_queue):
4515         Update.
4516         (~dwarf2_queue_item): New.
4517
4518 2020-02-08  Tom Tromey  <tom@tromey.com>
4519
4520         * dwarf2/read.c (struct die_info) <has_children>: New member.
4521         (dw2_get_file_names_reader): Remove has_children.
4522         (dw2_get_file_names): Update.
4523         (read_cutu_die_from_dwo): Remove has_children.
4524         (cutu_reader::init_tu_and_read_dwo_dies)
4525         (cutu_reader::cutu_reader): Update.
4526         (process_psymtab_comp_unit_reader, build_type_psymtabs_reader):
4527         Remove has_children.
4528         (build_type_psymtabs_1, process_skeletonless_type_unit)
4529         (load_partial_comp_unit, load_full_comp_unit): Update.
4530         (create_dwo_cu_reader): Remove has_children.
4531         (create_cus_hash_table, read_die_and_children): Update.
4532         (read_full_die_1,read_full_die): Remove has_children.
4533         (read_signatured_type): Update.
4534         (class cutu_reader) <has_children>: Remove.
4535
4536 2020-02-08  Tom Tromey  <tom@tromey.com>
4537
4538         * dwarf2/expr.c: Rename from dwarf2expr.c.
4539         * dwarf2/expr.h: Rename from dwarf2expr.h.
4540         * dwarf2/frame-tailcall.c: Rename from dwarf2-frame-tailcall.c.
4541         * dwarf2/frame-tailcall.h: Rename from dwarf2-frame-tailcall.h.
4542         * dwarf2/frame.c: Rename from dwarf2-frame.c.
4543         * dwarf2/frame.h: Rename from dwarf2-frame.h.
4544         * dwarf2/index-cache.c: Rename from dwarf-index-cache.c.
4545         * dwarf2/index-cache.h: Rename from dwarf-index-cache.h.
4546         * dwarf2/index-common.c: Rename from dwarf-index-common.c.
4547         * dwarf2/index-common.h: Rename from dwarf-index-common.h.
4548         * dwarf2/index-write.c: Rename from dwarf-index-write.c.
4549         * dwarf2/index-write.h: Rename from dwarf-index-write.h.
4550         * dwarf2/loc.c: Rename from dwarf2loc.c.
4551         * dwarf2/loc.h: Rename from dwarf2loc.h.
4552         * dwarf2/read.c: Rename from dwarf2read.c.
4553         * dwarf2/read.h: Rename from dwarf2read.h.
4554         * dwarf2/abbrev.c, aarch64-tdep.c, alpha-tdep.c,
4555         amd64-darwin-tdep.c, arc-tdep.c, arm-tdep.c, bfin-tdep.c,
4556         compile/compile-c-symbols.c, compile/compile-cplus-symbols.c,
4557         compile/compile-loc2c.c, cris-tdep.c, csky-tdep.c, findvar.c,
4558         gdbtypes.c, guile/scm-type.c, h8300-tdep.c, hppa-bsd-tdep.c,
4559         hppa-linux-tdep.c, i386-darwin-tdep.c, i386-linux-tdep.c,
4560         i386-tdep.c, iq2000-tdep.c, m32c-tdep.c, m68hc11-tdep.c,
4561         m68k-tdep.c, microblaze-tdep.c, mips-tdep.c, mn10300-tdep.c,
4562         msp430-tdep.c, nds32-tdep.c, nios2-tdep.c, or1k-tdep.c,
4563         riscv-tdep.c, rl78-tdep.c, rs6000-tdep.c, rx-tdep.c, s12z-tdep.c,
4564         s390-tdep.c, score-tdep.c, sh-tdep.c, sparc-linux-tdep.c,
4565         sparc-tdep.c, sparc64-linux-tdep.c, sparc64-tdep.c, tic6x-tdep.c,
4566         tilegx-tdep.c, v850-tdep.c, xstormy16-tdep.c, xtensa-tdep.c:
4567         Update.
4568         * Makefile.in (COMMON_SFILES): Update.
4569         (HFILES_NO_SRCDIR): Update.
4570
4571 2020-02-08  Tom Tromey  <tom@tromey.com>
4572
4573         * dwarf2read.c (struct die_reader_specs) <comp_dir>: Remove.
4574         (init_cu_die_reader, read_cutu_die_from_dwo): Update.
4575
4576 2020-02-08  Tom Tromey  <tom@tromey.com>
4577
4578         * dwarf2read.h (struct die_info): Don't declare.
4579
4580 2020-02-08  Tom Tromey  <tom@tromey.com>
4581
4582         * dwarf2read.h (die_info_ptr): Remove typedef.
4583
4584 2020-02-08  Tom Tromey  <tom@tromey.com>
4585
4586         * dwarf2read.c (read_call_site_scope)
4587         (handle_data_member_location, dwarf2_add_member_fn)
4588         (mark_common_block_symbol_computed, read_common_block)
4589         (attr_to_dynamic_prop, partial_die_info::read)
4590         (var_decode_location, dwarf2_fetch_die_loc_sect_off)
4591         (dwarf2_symbol_mark_computed, set_die_type): Update.
4592         * dwarf2/attribute.h (struct attribute) <form_is_block>: Declare
4593         method.
4594         (attr_form_is_block): Don't declare.
4595         * dwarf2/attribute.c (attribute::form_is_block): Now a method.
4596
4597 2020-02-08  Tom Tromey  <tom@tromey.com>
4598
4599         * dwarf2read.c (dwarf2_find_base_address, )
4600         (read_call_site_scope, rust_containing_type)
4601         (dwarf2_get_pc_bounds, dwarf2_record_block_ranges)
4602         (handle_data_member_location, dwarf2_add_member_fn)
4603         (get_alignment, read_structure_type, process_structure_scope)
4604         (mark_common_block_symbol_computed, read_common_block)
4605         (read_tag_string_type, attr_to_dynamic_prop, read_subrange_type)
4606         (partial_die_info::read, read_attribute_value, new_symbol)
4607         (lookup_die_type, dwarf2_get_ref_die_offset)
4608         (dwarf2_get_attr_constant_value, follow_die_ref_or_sig)
4609         (dwarf2_fetch_die_loc_sect_off, get_DW_AT_signature_type)
4610         (dwarf2_symbol_mark_computed): Update.
4611         * dwarf2/attribute.h (struct attribute) <value_as_address,
4612         form_is_section_offset, form_is_constant, form_is_ref>: Declare
4613         methods.
4614         (value_as_address, attr_form_is_section_offset)
4615         (attr_form_is_constant, attr_form_is_ref): Don't declare.
4616         * dwarf2/attribute.c (attribute::value_as_address)
4617         (attribute::form_is_section_offset, attribute::form_is_constant)
4618         (attribute::form_is_ref): Now methods.
4619
4620 2020-02-08  Tom Tromey  <tom@tromey.com>
4621
4622         * dwarf2read.c (struct attribute, DW_STRING)
4623         (DW_STRING_IS_CANONICAL, DW_UNSND, DW_BLOCK, DW_SND, DW_ADDR)
4624         (DW_SIGNATURE, struct dwarf_block, attr_value_as_address)
4625         (attr_form_is_block, attr_form_is_section_offset)
4626         (attr_form_is_constant, attr_form_is_ref): Move.
4627         * dwarf2/attribute.h: New file.
4628         * dwarf2/attribute.c: New file, from dwarf2read.c.
4629         * Makefile.in (COMMON_SFILES): Add dwarf2/attribute.c.
4630
4631 2020-02-08  Tom Tromey  <tom@tromey.com>
4632
4633         * dwarf2read.c (abbrev_table_up, struct abbrev_info)
4634         (struct attr_abbrev, ABBREV_HASH_SIZE, struct abbrev_table):
4635         Move.
4636         (read_cutu_die_from_dwo, build_type_psymtabs_1): Update.
4637         (abbrev_table::alloc_abbrev, abbrev_table::add_abbrev)
4638         (abbrev_table::lookup_abbrev, abbrev_table_read_table): Move to
4639         abbrev.c.
4640         * dwarf2/abbrev.h: New file.
4641         * dwarf2/abbrev.c: New file, from dwarf2read.c.
4642         * Makefile.in (COMMON_SFILES): Add dwarf2/abbrev.c.
4643
4644 2020-02-08  Tom Tromey  <tom@tromey.com>
4645
4646         * dwarf2read.c (dwarf2_section_buffer_overflow_complaint)
4647         (dwarf2_section_size, dwarf2_get_section_info)
4648         (create_signatured_type_table_from_debug_names)
4649         (create_addrmap_from_aranges, read_debug_names_from_section)
4650         (get_gdb_index_contents_from_section, read_comp_unit_head)
4651         (error_check_comp_unit_head, read_abbrev_offset)
4652         (create_debug_type_hash_table, init_cu_die_reader)
4653         (read_cutu_die_from_dwo, dwarf2_build_psymtabs_hard)
4654         (read_comp_units_from_section, create_cus_hash_table)
4655         (create_dwp_hash_table, create_dwo_unit_in_dwp_v1)
4656         (create_dwp_v2_section, dwarf2_rnglists_process)
4657         (dwarf2_ranges_process, read_die_and_siblings, read_full_die)
4658         (abbrev_table_read_table, read_indirect_string_at_offset_from)
4659         (read_indirect_string_from_dwz, read_addr_index_1)
4660         (read_str_index, dwarf_decode_line_header, skip_form_bytes)
4661         (dwarf_decode_macro_bytes, dwarf_decode_macros)
4662         (fill_in_loclist_baton): Update.
4663         * dwarf2/section.h (struct dwarf2_section_info) <get_name,
4664         get_containing_section, get_bfd_owner, get_bfd_section,
4665         get_file_name, get_id, get_flags, empty, read>: Declare methods.
4666         (dwarf2_read_section, get_section_name, get_section_file_name)
4667         (get_containing_section, get_section_bfd_owner)
4668         (get_section_bfd_section, get_section_name, get_section_file_name)
4669         (get_section_id, get_section_flags, dwarf2_section_empty_p): Don't
4670         declare.
4671         * dwarf2/section.c (dwarf2_section_info::get_containing_section)
4672         (dwarf2_section_info::get_bfd_owner)
4673         (dwarf2_section_info::get_bfd_section)
4674         (dwarf2_section_info::get_name)
4675         (dwarf2_section_info::get_file_name, dwarf2_section_info::get_id)
4676         (dwarf2_section_info::get_flags, dwarf2_section_info::empty)
4677         (dwarf2_section_info::read): Now methods.
4678         * dwarf-index-write.c (class debug_names): Update.
4679
4680 2020-02-08  Tom Tromey  <tom@tromey.com>
4681
4682         * dwarf2read.h (struct dwarf2_section_info, dwarf2_read_section):
4683         Move to dwarf2/section.h.
4684         * dwarf2read.c (get_containing_section, get_section_bfd_owner)
4685         (get_section_bfd_section, get_section_name)
4686         (get_section_file_name, get_section_id, get_section_flags)
4687         (dwarf2_section_empty_p, dwarf2_read_section): Moe to
4688         dwarf2/section.c.
4689         * dwarf2/section.h: New file.
4690         * dwarf2/section.c: New file, from dwarf2read.c.
4691         * Makefile.in (COMMON_SFILES): Add dwarf2/section.c.
4692
4693 2020-02-08  Tom Tromey  <tom@tromey.com>
4694
4695         * dwarf2read.h (read_unsigned_leb128): Don't declare.
4696         * dwarf2read.c (read_1_byte, read_1_signed_byte, read_2_bytes)
4697         (read_2_signed_bytes, read_3_bytes, read_4_bytes)
4698         (read_4_signed_bytes, read_8_bytes): Move to dwarf2/leb.h.
4699         (read_unsigned_leb128, read_signed_leb128): Move to dwarf2/leb.c.
4700         * dwarf2/leb.h: New file, from dwarf2read.c.
4701         * dwarf2/leb.c: New file, from dwarf2read.c.
4702         * dwarf2-frame.c (read_1_byte, read_4_bytes, read_8_bytes):
4703         Remove.
4704         * Makefile.in (CONFIG_SRC_SUBDIR): Add dwarf2.
4705         (COMMON_SFILES): Add dwarf2/leb.c.
4706
4707 2020-02-08  Joel Brobecker  <brobecker@adacore.com>
4708
4709         GDB 9.1 released.
4710
4711 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4712
4713         PR gdb/25190:
4714         * gdb/remote-sim.c (gdb_os_write_stderr): Update.
4715         * gdb/remote.c (remote_console_output): Update.
4716         * gdb/ui-file.c (fputs_unfiltered): Rename to...
4717         (ui_file_puts): ...this.
4718         * gdb/ui-file.h (ui_file_puts): Add declaration.
4719         * gdb/utils.c (emit_style_escape): Update.
4720         (flush_wrap_buffer): Update.
4721         (fputs_maybe_filtered): Update.
4722         (fputs_unfiltered): Add function.
4723
4724 2020-02-05  Iain Buclaw  <ibuclaw@gdcproject.org>
4725
4726         * gdb/event-loop.c (gdb_wait_for_event): Update.
4727         * gdb/printcmd.c (printf_command): Update.
4728         * gdb/remote-fileio.c (remote_fileio_func_write): Update.
4729         * gdb/remote-sim.c (gdb_os_flush_stdout): Update.
4730         (gdb_os_flush_stderr): Update.
4731         * gdb/remote.c (remote_console_output): Update.
4732         * gdb/ui-file.c (gdb_flush): Rename to...
4733         (ui_file_flush): ...this.
4734         (stderr_file::write): Update.
4735         (stderr_file::puts): Update.
4736         * gdb/ui-file.h (gdb_flush): Rename to...
4737         (ui_file_flush): ...this.
4738         * gdb/utils.c (gdb_flush): Add function.
4739         * gdb/utils.h (gdb_flush): Add declaration.
4740
4741 2020-02-07  Tom Tromey  <tromey@adacore.com>
4742
4743         PR breakpoints/24915:
4744         * source.c (find_and_open_source): Do not check basenames_may_differ.
4745
4746 2020-02-07  Tom Tromey  <tom@tromey.com>
4747
4748         * README: Update gdbserver documentation.
4749         * gdbserver: Move to top level.
4750         * configure.tgt (build_gdbserver): Remove.
4751         * configure.ac: Remove --enable-gdbserver.
4752         * configure: Rebuild.
4753         * Makefile.in (distclean): Don't mention gdbserver.
4754
4755 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4756
4757         * source-cache.c (source_cache::ensure): Surround
4758         get_plain_source_lines with a try/catch.
4759         (source_cache::get_line_charpos): Get rid of try/catch
4760         and only check for the return value of "ensure".
4761         * tui/tui-source.c (tui_source_window::set_contents):
4762         Simplify "nlines" calculation.
4763
4764 2020-02-06  Shahab Vahedi  <shahab@synopsys.com>
4765
4766         * MAINTAINERS (Write After Approval): Add myself.
4767
4768 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4769
4770         * sparc-nat.h (struct sparc_target) <xfer_partial>: Fix base class
4771         function call.
4772
4773 2020-02-05  Christian Biesinger  <cbiesinger@google.com>
4774
4775         * ppc-nbsd-tdep.h: Fix macro name in #endif comment.
4776
4777 2020-02-05  Maciej W. Rozycki  <macro@wdc.com>
4778
4779         * nat/riscv-linux-tdesc.h: New file.
4780         * nat/riscv-linux-tdesc.c: New file, taking code from...
4781         * riscv-linux-nat.c (riscv_linux_nat_target::read_description):
4782         ... here.
4783         * configure.nat <linux> <riscv*>: Add nat/riscv-linux-tdesc.o to
4784         NATDEPFILES.
4785
4786 2020-02-04  Andrew Burgess  <andrew.burgess@embecosm.com>
4787
4788         * remote-sim.c (sim_inferior_data::sim_inferior_data): Assert that
4789         we don't set the fake simulator ptid to the null_ptid.
4790
4791 2020-02-03  Simon Marchi  <simon.marchi@efficios.com>
4792
4793         * fork-child.c (gdb_startup_inferior): Use bool instead of int.
4794         * gdbthread.h (class thread_info) <resumed>: Likewise.
4795         * infrun.c (resume_1): Likewise.
4796         (proceed): Likewise.
4797         (infrun_thread_stop_requested): Likewise.
4798         (stop_all_threads): Likewise.
4799         (handle_inferior_event): Likewise.
4800         (restart_threads): Likewise.
4801         (finish_step_over): Likewise.
4802         (keep_going_stepped_thread): Likewise.
4803         * linux-nat.c (attach_proc_task_lwp_callback): Likewise.
4804         (linux_handle_extended_wait): Likewise.
4805         * record-btrace.c (get_thread_current_frame_id): Likewise.
4806         * record-full.c (record_full_wait_1): Likewise.
4807         * remote.c (remote_target::process_initial_stop_replies): Likewise.
4808         * target.c (target_resume): Likewise.
4809         * thread.c (set_running_thread): Likewise.
4810
4811 2020-02-03  Alok Kumar Sharma  <AlokKumar.Sharma@amd.com>
4812
4813         * f-valprint.c (f77_print_array_1): Changed datatype of index
4814         variable to LONGEST from int to enable it to contain bound
4815         values correctly.
4816
4817 2020-02-03  Maciej W. Rozycki  <macro@wdc.com>
4818
4819         * riscv-linux-nat.c [!NFPREG] (NFPREG): New macro.
4820         (supply_fpregset_regnum, fill_fpregset): Handle regset buffer
4821         offsets according to FLEN determined.
4822         (riscv_linux_nat_target::read_description): Determine FLEN
4823         dynamically.
4824         (riscv_linux_nat_target::fetch_registers): Size regset buffer
4825         according to FLEN determined.
4826         (riscv_linux_nat_target::store_registers): Likewise.
4827
4828 2020-02-01  Shahab Vahedi  <shahab@synopsys.com>
4829
4830         * target-descriptions.c (tdesc_register_in_reggroup_p): Return 0
4831         when reg->group is empty and reggroup is not.
4832
4833 2020-01-31  Tom Tromey  <tromey@adacore.com>
4834
4835         * ravenscar-thread.c (ravenscar_thread_target::mourn_inferior):
4836         Call beneath target's mourn_inferior after unpushing.
4837
4838 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4839
4840         PR tui/9765
4841         * tui/tui-disasm.c (tui_find_disassembly_address): If we don't
4842         have enough lines to fill the screen, still return the lowest
4843         address we found.
4844
4845 2020-01-31  Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * tui/tui-win.c (_initialize_tui_win): Update help text for '+',
4848         '-', '<', and '>' commands.
4849
4850 2020-01-29  Pedro Alves  <palves@redhat.com>
4851             Sergio Durigan Junior  <sergiodj@redhat.com>
4852
4853         * infcmd.c (construct_inferior_arguments): Assert that
4854         'argc' is greater than 0.
4855
4856 2020-01-29  Luis Machado  <luis.machado@linaro.org>
4857
4858         * aarch64-tdep.c (BRK_INSN_MASK): Define to 0xffe0001f.
4859         (BRK_INSN_MASK): Define to 0xd4200000.
4860         (aarch64_program_breakpoint_here_p): New function.
4861         (aarch64_gdbarch_init): Set gdbarch_program_breakpoint_here_p hook.
4862         * arch-utils.c (default_program_breakpoint_here_p): Moved from
4863         breakpoint.c.
4864         * arch-utils.h (default_program_breakpoint_here_p): Moved from
4865         breakpoint.h
4866         * breakpoint.c (bp_loc_is_permanent): Changed return type to bool and
4867         call gdbarch_program_breakpoint_here_p.
4868         (program_breakpoint_here): Moved to arch-utils.c, renamed to
4869         default_program_breakpoint_here_p, changed return type to bool and
4870         simplified.
4871         * breakpoint.h (program_breakpoint_here): Moved prototype to
4872         arch-utils.h, renamed to default_program_breakpoint_here_p and changed
4873         return type to bool.
4874         * gdbarch.c: Regenerate.
4875         * gdbarch.h: Regenerate.
4876         * gdbarch.sh (program_breakpoint_here_p): New method.
4877         * infrun.c (handle_signal_stop): Call
4878         gdbarch_program_breakpoint_here_p.
4879
4880 2020-01-26  Tom Tromey  <tom@tromey.com>
4881
4882         * ctfread.c (struct ctf_fp_info): Reindent.
4883         (_initialize_ctfread): Remove.
4884
4885 2020-01-26  Tom Tromey  <tom@tromey.com>
4886
4887         * psymtab.c (partial_map_expand_apply)
4888         (psym_find_pc_sect_compunit_symtab, psym_lookup_symbol)
4889         (psymtab_to_symtab, psym_find_last_source_symtab, dump_psymtab)
4890         (psym_print_stats, psym_expand_symtabs_for_function)
4891         (psym_map_symbol_filenames, psym_map_matching_symbols)
4892         (psym_expand_symtabs_matching)
4893         (partial_symtab::read_dependencies, maintenance_info_psymtabs)
4894         (maintenance_check_psymtabs): Use new methods.
4895         * psympriv.h (struct partial_symtab) <readin_p,
4896         get_compunit_symtab>: New methods.
4897         <readin, compunit_symtab>: Remove members.
4898         (struct standard_psymtab): New.
4899         (struct legacy_psymtab): Derive from standard_psymtab.
4900         * dwarf2read.h (struct dwarf2_psymtab): Derive from
4901         standard_psymtab.
4902         * ctfread.c (struct ctf_psymtab): Derive from standard_psymtab.
4903
4904 2020-01-26  Tom Tromey  <tom@tromey.com>
4905
4906         * xcoffread.c (xcoff_psymtab_to_symtab_1): Call
4907         read_dependencies.  Add assert.
4908         * psymtab.c (partial_symtab::read_dependencies): New method.
4909         * psympriv.h (struct partial_symtab) <read_dependencies>: New
4910         method.
4911         * mdebugread.c (psymtab_to_symtab_1): Call read_dependencies.
4912         * dwarf2read.c (dwarf2_psymtab::expand_psymtab): Call
4913         read_dependencies.
4914         * dbxread.c (dbx_psymtab_to_symtab_1): Call read_dependencies.
4915         Add assert.
4916
4917 2020-01-26  Tom Tromey  <tom@tromey.com>
4918
4919         * xcoffread.c (xcoff_psymtab_to_symtab_1): Change argument order.
4920         Call expand_psymtab.
4921         (xcoff_read_symtab): Call expand_psymtab.
4922         (xcoff_start_psymtab, xcoff_end_psymtab): Set
4923         legacy_expand_psymtab.
4924         * psympriv.h (struct partial_symtab) <expand_psymtab>: New
4925         method.
4926         (struct legacy_psymtab) <expand_psymtab>: Implement.
4927         <legacy_expand_psymtab>: New member.
4928         * mdebugread.c (mdebug_read_symtab): Call expand_psymtab.
4929         (parse_partial_symbols): Set legacy_expand_psymtab.
4930         (psymtab_to_symtab_1): Change argument order.  Call
4931         expand_psymtab.
4932         (new_psymtab): Set legacy_expand_psymtab.
4933         * dwarf2read.h (struct dwarf2_psymtab) <expand_psymtab>: Declare.
4934         * dwarf2read.c (dwarf2_psymtab::read_symtab): Call
4935         expand_psymtab.
4936         (dwarf2_psymtab::expand_psymtab): Rename from
4937         psymtab_to_symtab_1.  Call expand_psymtab.
4938         * dbxread.c (start_psymtab): Set legacy_expand_psymtab.
4939         (dbx_end_psymtab): Likewise.
4940         (dbx_psymtab_to_symtab_1): Change argument order. Call
4941         expand_psymtab.
4942         (dbx_read_symtab): Call expand_psymtab.
4943         * ctfread.c (struct ctf_psymtab) <expand_psymtab>: Declare.
4944         (ctf_psymtab::expand_psymtab): Rename from psymtab_to_symtab.
4945         (ctf_psymtab::read_symtab): Call expand_psymtab.
4946
4947 2020-01-26  Tom Tromey  <tom@tromey.com>
4948
4949         * xcoffread.c (xcoff_read_symtab): Remove prints.  Add assert.
4950         * psymtab.c (psymtab_to_symtab): Print verbose "Reading"
4951         messages.
4952         * mdebugread.c (mdebug_read_symtab): Remove prints.
4953         * dwarf2read.c (dwarf2_psymtab::read_symtab): Remove prints.  Add
4954         assert.
4955         * dbxread.c (dbx_read_symtab): Remove prints.  Add assert.
4956
4957 2020-01-26  Tom Tromey  <tom@tromey.com>
4958
4959         * xcoffread.c (this_symtab_psymtab, read_xcoff_symtab)
4960         (xcoff_psymtab_to_symtab_1, xcoff_read_symtab)
4961         (xcoff_start_psymtab, xcoff_end_psymtab, scan_xcoff_symtab): Use
4962         legacy_symtab.
4963         * stabsread.h (dbx_end_psymtab): Use legacy_symtab.
4964         * psymtab.c (psymtab_to_symtab): Call method.
4965         (dump_psymtab): Update.
4966         * psympriv.h (struct partial_symtab): Add virtual destructor.
4967         <read_symtab>: New method.
4968         (struct legacy_symtab): New.
4969         * mdebugread.c (mdebug_read_symtab): Use legacy_psymtab.
4970         (struct pst_map) <pst>: Now a legacy_psymtab.
4971         (parse_procedure, parse_partial_symbols, psymtab_to_symtab_1)
4972         (new_psymtab): Use legacy_psymtab.
4973         * dwarf2read.h (struct dwarf2_psymtab): New.
4974         (struct dwarf2_per_cu_data) <psymtab>: Use it.
4975         * dwarf2read.c (dwarf2_create_include_psymtab)
4976         (dwarf2_build_include_psymtabs, create_type_unit_group)
4977         (create_partial_symtab, process_psymtab_comp_unit_reader)
4978         (build_type_psymtabs_reader, build_type_psymtab_dependencies)
4979         (set_partial_user): Use dwarf2_psymtab.
4980         (dwarf2_psymtab::read_symtab): Rename from dwarf2_read_symtab.
4981         (psymtab_to_symtab_1, process_full_comp_unit)
4982         (process_full_type_unit, dwarf2_ranges_read)
4983         (dwarf2_get_pc_bounds, psymtab_include_file_name)
4984         (dwarf_decode_lines): Use dwarf2_psymtab.
4985         * dwarf-index-write.c (psym_index_map): Use dwarf2_psymtab.
4986         (add_address_entry_worker, write_one_signatured_type)
4987         (recursively_count_psymbols, recursively_write_psymbols)
4988         (write_one_signatured_type, psyms_seen_size, write_gdbindex)
4989         (write_debug_names): Likewise.
4990         * dbxread.c (struct header_file_location): Take a legacy_psymtab.
4991         <pst>: Now a legacy_psymtab.
4992         (find_corresponding_bincl_psymtab): Return a legacy_psymtab.
4993         (read_dbx_symtab, start_psymtab, dbx_end_psymtab)
4994         (dbx_psymtab_to_symtab_1, read_ofile_symtab): Use legacy_psymtab.
4995         * ctfread.c (struct ctf_psymtab): New.
4996         (ctf_start_symtab, ctf_end_symtab, psymtab_to_symtab): Take a
4997         ctf_psymtab.
4998         (ctf_psymtab::read_symtab): Rename from ctf_read_symtab.
4999         (create_partial_symtab): Return a ctf_psymtab.
5000         (scan_partial_symbols): Update.
5001
5002 2020-01-26  Tom Tromey  <tom@tromey.com>
5003
5004         * xcoffread.c (xcoff_start_psymtab): Use new.
5005         * psymtab.c (partial_symtab::partial_symtab): New constructor,
5006         renamed from start_psymtab_common.
5007         * psympriv.h (struct partial_symtab): Add new constructor.
5008         (start_psymtab_common): Don't declare.
5009         * mdebugread.c (parse_partial_symbols): Use new.
5010         * dwarf2read.c (create_partial_symtab): Use new.
5011         * dbxread.c (start_psymtab): Use new.
5012         * ctfread.c (create_partial_symtab): Use new.
5013
5014 2020-01-26  Tom Tromey  <tom@tromey.com>
5015
5016         * xcoffread.c (xcoff_end_psymtab): Use new.
5017         * psymtab.c (start_psymtab_common): Use new.
5018         (partial_symtab::partial_symtab): Rename from allocate_psymtab.
5019         Update.
5020         * psympriv.h (struct partial_symtab): Add parameters to
5021         constructor.  Don't inline.
5022         (allocate_psymtab): Don't declare.
5023         * mdebugread.c (new_psymtab): Use new.
5024         * dwarf2read.c (dwarf2_create_include_psymtab): Use new.
5025         * dbxread.c (dbx_end_psymtab): Use new.
5026
5027 2020-01-26  Tom Tromey  <tom@tromey.com>
5028
5029         * psymtab.h (class psymtab_storage) <install_psymtab>: Rename from
5030         allocate_psymtab.  Update documentation.
5031         * psymtab.c (psymtab_storage::install_psymtab): Rename from
5032         allocate_psymtab.  Do not use new.
5033         (allocate_psymtab): Use new.  Update.
5034
5035 2020-01-26  Tom Tromey  <tom@tromey.com>
5036
5037         * xcoffread.c (xcoff_psymtab_to_symtab_1): Update.
5038         * psymtab.c (psym_print_stats): Update.
5039         * psympriv.h (struct partial_symtab) <readin,
5040         psymtabs_addrmap_supported, anonymous>: Now bool.
5041         * mdebugread.c (psymtab_to_symtab_1): Update.
5042         * dwarf2read.c (create_type_unit_group, create_partial_symtab)
5043         (build_type_psymtabs_reader, psymtab_to_symtab_1)
5044         (process_full_comp_unit, process_full_type_unit): Update.
5045         * dbxread.c (dbx_psymtab_to_symtab_1): Update.
5046         * ctfread.c (psymtab_to_symtab): Update.
5047
5048 2020-01-26  Tom Tromey  <tom@tromey.com>
5049
5050         * mdebugread.c (parse_partial_symbols): Use discard_psymtab.
5051         * psymtab.h (class psymtab_storage) <free_psymtabs>: Remove.
5052         * psymtab.c (psymtab_storage): Delete psymtabs.
5053         (psymtab_storage::allocate_psymtab): Use new.
5054         (psymtab_storage::discard_psymtab): Use delete.
5055         * psympriv.h (struct partial_symtab): Add constructor and
5056         initializers.
5057
5058 2020-01-26  Tom Tromey  <tom@tromey.com>
5059
5060         * machoread.c: Do not include psympriv.h.
5061
5062 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5063
5064         * NEWS: Mention the new option and the set/show commands.
5065
5066 2020-01-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5067
5068         * exec.c (exec_file_mismatch_names, exec_file_mismatch_mode)
5069         (show_exec_file_mismatch_command, set_exec_file_mismatch_command)
5070         (validate_exec_file): New variables, enums, functions.
5071         (exec_file_locate_attach, print_section_info): Style the filenames.
5072         (_initialize_exec): Install show_exec_file_mismatch_command and
5073          set_exec_file_mismatch_command.
5074         * gdbcore.h (validate_exec_file): Declare.
5075         * infcmd.c (attach_command): Call validate_exec_file.
5076         * remote.c ( remote_target::remote_add_inferior): Likewise.
5077
5078 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5079
5080         * frame.c (find_frame_sal): Move call to get_next_frame into more
5081         inner scope.
5082         * inline-frame.c (inilne_state) <inline_state>: Update argument
5083         types.
5084         (inilne_state) <skipped_symbol>: Rename to...
5085         (inilne_state) <skipped_symbols>: ...this, and change to a vector.
5086         (skip_inline_frames): Build vector of skipped symbols and use this
5087         to reate the inline_state.
5088         (inline_skipped_symbol): Add a comment and some assertions, fetch
5089         skipped symbol from the list.
5090
5091 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5092
5093         * buildsym.c (lte_is_less_than): Delete.
5094         (buildsym_compunit::end_symtab_with_blockvector): Create local
5095         lambda function to sort line table entries, and use
5096         std::stable_sort instead of std::sort.
5097         * symtab.c (find_pc_sect_line): Skip backward over end of sequence
5098         markers when looking for a previous line.
5099
5100 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5101
5102         * dwarf2read.c (lnp_state_machine::record_line): Include
5103         end_sequence parameter in debug print out.  Record the line if we
5104         are at an end_sequence marker even if it's not the start of a
5105         statement.
5106         * symmisc.c (maintenance_print_one_line_table): Print end of
5107         sequence markers with 'END' not '0'.
5108
5109 2020-01-24  Pedro Alves  <palves@redhat.com>
5110
5111         PR gdb/25410
5112         * thread.c (scoped_restore_current_thread::restore): Use
5113         switch_to_inferior_no_thread.
5114         * exec.c: Include "progspace-and-thread.h".
5115         (add_target_sections, remove_target_sections):
5116         scoped_restore_current_pspace_and_thread instead of
5117         scoped_restore_current_thread.
5118         * infrun.c (handle_vfork_child_exec_or_exit): Assign the pspace
5119         and aspace to the inferior before calling clone_program_space.
5120         Remove stale comment.
5121
5122 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5123
5124         * arm-nbsd-nat.c (arm_nbsd_nat_target::fetch_registers): Rename to...
5125         (arm_netbsd_nat_target::fetch_registers): ...this.
5126         (arm_nbsd_nat_target::store_registers): Rename to...
5127         (arm_netbsd_nat_target::store_registers): ...this.
5128
5129 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5130
5131         * arm-nbsd-nat.c: Define _KERNTYPES to get the declaration of
5132         register_t.
5133
5134 2020-01-24  Christian Biesinger  <cbiesinger@google.com>
5135
5136         * aarch64-fbsd-tdep.c (aarch64_fbsd_iterate_over_regset_sections):
5137         Update comment.
5138         * aarch64-linux-tdep.c (aarch64_linux_iterate_over_regset_sections):
5139         Likewise.
5140         * arm-fbsd-tdep.c (arm_fbsd_iterate_over_regset_sections): Likewise.
5141         * gdbcore.h (deprecated_add_core_fns): Update comment to point to
5142         the correct replacement (iterate_over_regset_sections).
5143         * riscv-fbsd-tdep.c (riscv_fbsd_iterate_over_regset_sections):
5144         Update comment.
5145
5146 2020-01-24  Graham Markall  <graham.markall@embecosm.com>
5147
5148         PR gdb/23718
5149         * gdb/python/python.c (execute_gdb_command): Call
5150         async_enable_stdin in catch block.
5151
5152 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5153
5154         * event-loop.c (start_event_loop): Wrap async_enable_stdin with
5155         SWITCH_THRU_ALL_UIS.
5156
5157 2020-01-24  Andrew Burgess  <andrew.burgess@embecosm.com>
5158
5159         PR tui/9765
5160         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update header
5161         comment, add extra parameter, and update to store previous symbol
5162         when appropriate.
5163         * minsyms.h (lookup_minimal_symbol_by_pc_section): Update comment,
5164         add extra parameter.
5165         * tui/tui-disasm.c (tui_disassemble): Update header comment,
5166         remove unneeded parameter, add try/catch around gdb_print_insn,
5167         rewrite to add items to asm_lines vector.
5168         (tui_find_backward_disassembly_start_address): New function.
5169         (tui_find_disassembly_address): Updated throughout.
5170         (tui_disasm_window::set_contents): Update for changes to
5171         tui_disassemble.
5172         (tui_disasm_window::do_scroll_vertical): No need to adjust the
5173         number of lines to scroll.
5174
5175 2020-01-23  Simon Marchi  <simon.marchi@polymtl.ca>
5176
5177         * objfiles.h (ALL_OBJFILE_OSECTIONS): Move up.
5178         (SECT_OFF_DATA): Likewise.
5179         (SECT_OFF_RODATA): Likewise.
5180         (SECT_OFF_TEXT): Likewise.
5181         (SECT_OFF_BSS): Likewise.
5182         (struct objfile) <text_section_offset, data_section_offset>: New
5183         methods.
5184         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Use
5185         objfile::text_section_offset.
5186         * coff-pe-read.c (add_pe_forwarded_sym): Likewise.
5187         * coffread.c (coff_symtab_read): Likewise.
5188         (enter_linenos): Likewise.
5189         (process_coff_symbol): Likewise.
5190         * ctfread.c (get_objfile_text_range): Likewise.
5191         * dtrace-probe.c (dtrace_probe::get_relocated_address):
5192         Use objfile::data_section_offset.
5193         * dwarf2-frame.c (execute_cfa_program): Use
5194         objfile::text_section_offset.
5195         (dwarf2_frame_find_fde): Likewise.
5196         * dwarf2read.c (create_addrmap_from_index): Likewise.
5197         (create_addrmap_from_aranges): Likewise.
5198         (dw2_find_pc_sect_compunit_symtab): Likewise.
5199         (process_psymtab_comp_unit_reader): Likewise.
5200         (add_partial_symbol): Likewise.
5201         (add_partial_subprogram): Likewise.
5202         (process_full_comp_unit): Likewise.
5203         (read_file_scope): Likewise.
5204         (read_func_scope): Likewise.
5205         (read_lexical_block_scope): Likewise.
5206         (read_call_site_scope): Likewise.
5207         (dwarf2_rnglists_process): Likewise.
5208         (dwarf2_ranges_process): Likewise.
5209         (dwarf2_ranges_read): Likewise.
5210         (dwarf_decode_lines_1): Likewise.
5211         (new_symbol): Likewise.
5212         (dwarf2_fetch_die_loc_sect_off): Likewise.
5213         (dwarf2_per_cu_text_offset): Likewise.
5214         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Likewise.
5215         * hppa-tdep.c (read_unwind_info): Likewise.
5216         * ia64-tdep.c (ia64_find_unwind_table): Likewise.
5217         * psympriv.h (struct partial_symtab): Likewise.
5218         * psymtab.c (find_pc_sect_psymtab): Likewise.
5219         * solib-svr4.c (enable_break): Likewise.
5220         * stap-probe.c (relocate_address): Use
5221         objfile::data_section_offset.
5222         * xcoffread.c (enter_line_range): Use
5223         objfile::text_section_offset.
5224         (read_xcoff_symtab): Likewise.
5225
5226 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5227
5228         * darwin-nat.c (darwin_nat_target::wait_1): Move `inf`
5229         declaration to narrower scopes.
5230
5231 2020-01-23  Simon Marchi  <simon.marchi@efficios.com>
5232
5233         * darwin-nat.h (struct darwin_exception_msg, enum
5234         darwin_msg_state, struct darwin_thread_info, darwin_thread_t):
5235         Move up.
5236         (class darwin_nat_target) <wait_1, check_new_threads,
5237         decode_exception_message, decode_message, stop_inferior,
5238         init_thread_list, ptrace_him, cancel_breakpoint>: Declare.
5239         * darwin-nat.c (darwin_check_new_threads): Rename to...
5240         (darwin_nat_target::check_new_threads): ... this.
5241         (darwin_suspend_inferior_it): Remove.
5242         (darwin_decode_exception_message): Rename to...
5243         (darwin_nat_target::decode_exception_message): ... this.
5244         (darwin_nat_target::resume): Pass target to find_inferior_ptid.
5245         (darwin_decode_message): Rename to...
5246         (darwin_nat_target::decode_message): ... this.
5247         (cancel_breakpoint): Rename to...
5248         (darwin_nat_target::cancel_breakpoint): ... this.
5249         (darwin_wait): Rename to...
5250         (darwin_nat_target::wait_1): ... this.  Use range-based for loop
5251         instead of iterate_over_inferiors.
5252         (darwin_nat_target::wait): Call wait_1 instead of darwin_wait.
5253         (darwin_stop_inferior): Rename to...
5254         (darwin_nat_target::stop_inferior): ... this.
5255         (darwin_nat_target::kill): Call wait_1 instead of darwin_wait.
5256         (darwin_init_thread_list): Rename to...
5257         (darwin_nat_target::init_thread_list): ... this.
5258         (darwin_ptrace_him): Rename to...
5259         (darwin_nat_target::ptrace_him): ... this.
5260         (darwin_nat_target::create_inferior): Pass lambda function to
5261         fork_inferior.
5262         (darwin_nat_target::detach): Call stop_inferior instead of
5263         darwin_stop_inferior.
5264         * fork-inferior.h (fork_inferior): Change init_trace_fun
5265         parameter to gdb::function_view.
5266         * fork-inferior.c (fork_inferior): Likewise.
5267
5268 2020-01-23  Hannes Domani  <ssbssa@yahoo.de>
5269
5270         * i386-cygwin-tdep.c (core_process_module_section): Update.
5271         * windows-nat.c (struct lm_info_windows): Add text_offset.
5272         (windows_xfer_shared_libraries): Update.
5273         * windows-tdep.c (windows_xfer_shared_library):
5274         Add text_offset_cached argument.
5275         * windows-tdep.h (windows_xfer_shared_library): Update.
5276
5277 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5278
5279         * gdbarch.sh: Add declaration for _initialize_gdbarch.
5280
5281 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5282
5283         * remote-sim.c (check_for_duplicate_sim_descriptor): Remove.
5284         (get_sim_inferior_data): Remove use of iterate_over_inferiors,
5285         replace with range-based for.
5286         (gdbsim_interrupt_inferior): Remove.
5287         (gdbsim_target::interrupt): Replace iterate_over_inferiors use
5288         with a range-based for.  Inline code from
5289         gdbsim_interrupt_inferior.
5290
5291 2020-01-21  Simon Marchi  <simon.marchi@efficios.com>
5292
5293         * infrun.c (proceed): Fix indentation.
5294
5295 2020-01-21  Tom Tromey  <tromey@adacore.com>
5296
5297         * source-cache.c (source_cache::ensure): Call ext_lang_colorize.
5298         * python/python.c (python_extension_ops): Update.
5299         (gdbpy_colorize): New function.
5300         * python/lib/gdb/__init__.py (colorize): New function.
5301         * extension.h (ext_lang_colorize): Declare.
5302         * extension.c (ext_lang_colorize): New function.
5303         * extension-priv.h (struct extension_language_ops) <colorize>: New
5304         member.
5305         * cli/cli-style.c (_initialize_cli_style): Update help text.
5306
5307 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5308
5309         * aarch64-tdep.c (struct aarch64_displaced_step_closure)
5310         <cond>: Change type to bool.
5311         (aarch64_displaced_step_b_cond): Update cond to use bool type.
5312         (aarch64_displaced_step_cb): Likewise.
5313         (aarch64_displaced_step_tb): Likewise.
5314
5315 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5316
5317         * aarch64-tdep.c (aarch64_displaced_step_fixup): Add more debugging
5318         output.
5319
5320 2020-01-21  Luis Machado  <luis.machado@linaro.org>
5321
5322         * aarch64-tdep.c (struct aarch64_displaced_step_closure )
5323         <pc_adjust>: Adjust the documentation.
5324         (aarch64_displaced_step_fixup): Check if PC really moved before
5325         adjusting it.
5326
5327 2020-01-19  Tom Tromey  <tom@tromey.com>
5328
5329         * disasm.c (~gdb_disassembler): New destructor.
5330         (gdb_buffered_insn_length): Call disassemble_free_target.
5331         * disasm.h (class gdb_disassembler): Declare destructor.  Use
5332         DISABLE_COPY_AND_ASSIGN.
5333
5334 2020-01-19  Tom Tromey  <tom@tromey.com>
5335
5336         * dwarf2read.c (abbrev_table_up): Move typedef earlier.
5337         (die_reader_func_ftype): Remove.
5338         (cutu_reader): New class.
5339         (dw2_get_file_names_reader): Remove "data" parameter.
5340         (dw2_get_file_names): Use cutu_reader.
5341         (create_debug_type_hash_table): Update.
5342         (read_cutu_die_from_dwo): Update comment.
5343         (lookup_dwo_unit): Add dwo_name parameter.
5344         (cutu_reader::init_tu_and_read_dwo_dies): Now a method.  Remove
5345         die_reader_func_ftype and data parameters.
5346         (cutu_reader::cutu_reader): Rename from init_cutu_and_read_dies.
5347         Remove die_reader_func_ftype and data parameters.
5348         (~cutu_reader): New; from init_cutu_and_read_dies.
5349         (cutu_reader::cutu_reader): Rename from
5350         init_cutu_and_read_dies_no_follow.  Remove die_reader_func_ftype
5351         and data parameters.
5352         (init_cutu_and_read_dies_simple): Remove.
5353         (struct process_psymtab_comp_unit_data): Remove.
5354         (process_psymtab_comp_unit_reader): Remove data parameter; add
5355         want_partial_unit and pretend_language parameters.
5356         (process_psymtab_comp_unit): Use cutu_reader.
5357         (build_type_psymtabs_reader): Remove data parameter.
5358         (build_type_psymtabs_1): Use cutu_reader.
5359         (process_skeletonless_type_unit): Likewise.
5360         (load_partial_comp_unit_reader): Remove.
5361         (load_partial_comp_unit): Use cutu_reader.
5362         (load_full_comp_unit_reader): Remove.
5363         (load_full_comp_unit): Use cutu_reader.
5364         (struct create_dwo_cu_data): Remove.
5365         (create_dwo_cu_reader): Remove datap parameter; add dwo_file and
5366         dwo_unit parameters.
5367         (create_cus_hash_table): Use cutu_reader.
5368         (struct dwarf2_read_addr_index_data): Remove.
5369         (dwarf2_read_addr_index_reader): Remove.
5370         (dwarf2_read_addr_index): Use cutu_reader.
5371         (read_signatured_type_reader): Remove.
5372         (read_signatured_type): Use cutu_reader.
5373
5374 2020-01-19  Tom Tromey  <tom@tromey.com>
5375
5376         * tui/tui.c (tui_show_assembly): Use tui_suppress_output.
5377         * tui/tui-wingeneral.h (class tui_suppress_output): New.
5378         (tui_wrefresh): Declare.
5379         * tui/tui-wingeneral.c (suppress_output): New global.
5380         (tui_suppress_output, ~tui_suppress_output): New constructor and
5381         destructor.
5382         (tui_wrefresh): New function.
5383         (tui_gen_win_info::refresh_window): Use tui_wrefresh.
5384         (tui_gen_win_info::make_window): Call wnoutrefresh when needed.
5385         * tui/tui-regs.h (struct tui_data_window) <no_refresh>: Declare
5386         method.
5387         * tui/tui-regs.c (tui_data_window::erase_data_content): Call
5388         tui_wrefresh.
5389         (tui_data_window::no_refresh): New method.
5390         (tui_data_item_window::refresh_window): Call tui_wrefresh.
5391         (tui_reg_command): Use tui_suppress_output
5392         * tui/tui-layout.c (tui_set_layout): Use tui_suppress_output.
5393         * tui/tui-data.h (struct tui_gen_win_info) <no_refresh>: New
5394         method.
5395         * tui/tui-command.c (tui_refresh_cmd_win): Call tui_wrefresh.
5396
5397 2020-01-19  Tom Tromey  <tom@tromey.com>
5398
5399         * tui/tui-winsource.c (tui_update_source_windows_with_line):
5400         Handle case where symtab is null.
5401
5402 2020-01-19  Simon Marchi  <simon.marchi@polymtl.ca>
5403
5404         * linux-fork.c (one_fork_p): Simplify.
5405
5406 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5407
5408         * top.c (struct qt_args): Remove.
5409         (kill_or_detach): Change return type to void, replace `void *`
5410         parameter with a proper one.
5411         (print_inferior_quit_action):  Likewise.
5412         (quit_confirm): Use range-based for loop to iterate over inferiors.
5413         (quit_force): Likewise.
5414
5415 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5416
5417         * mi/mi-main.c (run_one_inferior): Change return type to void, replace
5418         `void *` parameter with proper parameters.
5419         (mi_cmd_exec_run): Use range-based loop to iterate over inferiors.
5420         (print_one_inferior): Change return type to void, replace `void *`
5421         parameter with proper parameters.
5422         (mi_cmd_list_thread_groups): Use range-based loop to iterate over
5423         inferiors.
5424         (get_other_inferior): Remove.
5425         (mi_cmd_remove_inferior): Use range-based loop to iterate over
5426         inferiors.
5427
5428 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5429
5430         * mi/mi-interp.c (report_initial_inferior): Remove.
5431         (mi_interp::init): Use range-based for to iterate over inferiors.
5432
5433 2020-01-17  Simon Marchi  <simon.marchi@efficios.com>
5434
5435         * python/py-inferior.c (build_inferior_list): Remove.
5436         (gdbpy_ref): Use range-based for loop to iterate over inferiors.
5437
5438 2020-01-16  Christian Biesinger  <cbiesinger@google.com>
5439
5440         * btrace.c (btrace_compute_ftrace_1): Fix spelling error (Unkown).
5441         (btrace_stitch_trace): Likewise.
5442         * charset.c (intermediate_encoding): Likewise (vaild).
5443         * nat/linux-btrace.c (linux_read_pt): Likewise (Unkown).
5444         * python/py-record-btrace.c (struct PyMethodDef): Likewise (occurences).
5445         * record-btrace.c (record_btrace_print_conf): Likewise (unkown).
5446
5447 2020-01-16  Hannes Domani  <ssbssa@yahoo.de>
5448
5449         * windows-tdep.c (windows_get_tlb_type):
5450         Add rtl_user_process_parameters type.
5451
5452 2020-01-16  Pedro Alves  <palves@redhat.com>
5453             Norbert Lange  <nolange79@gmail.com>
5454
5455         PR build/24805
5456         * gdbsupport/gdb_proc_service.h (PS_EXPORT): New.
5457         (ps_get_thread_area, ps_getpid, ps_lcontinue, ps_lgetfpregs)
5458         (ps_lgetregs, ps_lsetfpregs, ps_lsetregs, ps_lstop, ps_pcontinue)
5459         (ps_pdread, ps_pdwrite, ps_pglobal_lookup, ps_pstop, ps_ptread)
5460         (ps_ptwrite, ps_lgetxregs, ps_lgetxregsize, ps_lsetxregs)
5461         (ps_plog): Redeclare exported functions with default visibility.
5462
5463 2020-01-16  Nitika Achra  <Nitika.Achra@amd.com>
5464
5465         * dwarf2loc.c (decode_debug_loclists_addresses): Handle
5466         DW_LLE_base_addressx, DW_LLE_startx_length, DW_LLE_start_length.
5467
5468 2020-01-15  Simon Marchi  <simon.marchi@efficios.com>
5469
5470         * infcmd.c (post_create_inferior): Use get_thread_regcache
5471         instead of get_current_regcache.
5472
5473 2020-01-14  Tom Tromey  <tom@tromey.com>
5474
5475         PR symtab/12535:
5476         * python/python.c (gdbpy_decode_line): Treat empty string the same
5477         as no argument.
5478
5479 2020-01-14  Tom Tromey  <tom@tromey.com>
5480
5481         * Makefile.in (CLIBS): Remove second use of $(LIBIBERTY).
5482
5483 2020-01-14  Tom Tromey  <tom@tromey.com>
5484
5485         * nat/linux-btrace.c: Don't include <config.h>.
5486         * nat/linux-ptrace.c: Don't include <config.h>.
5487         * nat/x86-linux-dregs.c: Don't include <config.h>.
5488
5489 2020-01-14  Tom Tromey  <tom@tromey.com>
5490
5491         * configure: Rebuild.
5492         * configure.ac: Move many checks to ../gdbsupport/common.m4.
5493
5494 2020-01-14  Tom Tromey  <tom@tromey.com>
5495
5496         * nat/x86-linux-dregs.c: Include configh.h.
5497         * nat/linux-ptrace.c: Include configh.h.
5498         * nat/linux-btrace.c: Include configh.h.
5499         * defs.h: Include config.h, bfd.h.
5500         * configure.ac: Don't source common.host.
5501         (CONFIG_OBS, CONFIG_SRCS): Remove gdbsupport files.
5502         * configure: Rebuild.
5503         * acinclude.m4: Update path.
5504         * Makefile.in (SUPPORT, LIBSUPPORT, INCSUPPORT): New variables.
5505         (CONFIG_SRC_SUBDIR): Remove gdbsupport.
5506         (INTERNAL_CFLAGS_BASE): Add INCSUPPORT.
5507         (CLIBS): Add LIBSUPPORT.
5508         (CDEPS): Likewise.
5509         (COMMON_SFILES): Remove gdbsupport files.
5510         (HFILES_NO_SRCDIR): Likewise.
5511         (stamp-version): Update path to create-version.sh.
5512         (ALLDEPFILES): Remove gdbsupport files.
5513
5514 2020-01-14  Tom Tromey  <tom@tromey.com>
5515
5516         * gdbsupport/common.m4 (GDB_AC_COMMON): Define WIN32APILIBS and
5517         USE_WIN32API when needed.
5518         * configure.ac (USE_WIN32API): Don't define.
5519         (WIN32LIBS): Use WIN32APILIBS.
5520         * configure: Rebuild.
5521
5522 2020-01-14  Tom Tromey  <tom@tromey.com>
5523
5524         * configure: Rebuild.
5525         * gdbsupport/common.m4 (GDB_AC_COMMON): Fix indentation.
5526
5527 2020-01-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>
5528
5529         * skip.c (skip_function_command): Make skip w/o arguments use the
5530         name of the inlined function if pc is inside any inlined function.
5531
5532 2020-01-14  Luis Machado  <luis.machado@linaro.org>
5533
5534         * inf-ptrace.c (inf_ptrace_target::resume): Update comments.
5535         * infrun.c (resume_1): Likewise.
5536         (handle_inferior_event): Remove stale comment.
5537         * linux-nat.c (linux_nat_target::resume): Update comments.
5538         (save_stop_reason): Likewise.
5539         (linux_nat_filter_event): Likewise.
5540         * linux-nat.h (struct lwp_info) <stop_pc>, <stop_reason>: Likewise.
5541
5542 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5543
5544         * elfread.c (record_minimal_symbol): Set section index to 0 for
5545         non-allocatable sections.
5546
5547
5548 2020-01-13  Ali Tamur <tamur@google.com>
5549
5550         * dwarf2read.c (dwarf2_debug_sections): Add debug_str_offsets sections.
5551         (dwarf2_cu): Add str_offsets_base field.  Change the type of addr_base
5552         to gdb::optional.  Update comments.
5553         (dwo_file): Update comments.
5554         (read_attribute): Update API to take an additional out parameter,
5555         need_reprocess.  This is used to mark attributes that need other
5556         attributes (e.g. str_offsets_base) for correct computation which may not
5557         have been read yet.
5558         (read_attribute_reprocess): New function declaration.
5559         (read_addr_index): Likewise.
5560         (read_dwo_str_index): Likewise.
5561         (read_stub_str_index): Likewise.
5562         (dwarf2_per_objfile::locate_sections): Handle debug_str_offsets section.
5563         (lookup_addr_base): New function definition.
5564         (lookup_ranges_base): Likewise.
5565         (read_cutu_die_from_dwo): Use the new functions: lookup_addr_base,
5566         lookup_ranges_base.
5567         (init_cutu_and_read_dies): Update comments.
5568         (init_cutu_and_read_dies_no_follow): Change API to take parent compile
5569         unit.  This is used to inherit parent's str_offsets_base and addr_base.
5570         Update comments.
5571         (init_cutu_and_read_dies_simple): Reflect API changes.
5572         (skip_one_die): Reflect API changes.  Handle DW_FORM_rnglistx.
5573         (create_cus_hash_table): Change API to take parent compile unit.
5574         Reflect API changes.
5575         (open_and_init_dwo_file): Reflect API changes.
5576         (dwarf2_get_pc_bounds): Update comments.
5577         (dwarf2_record_block_ranges): Likewise.
5578         (read_full_die_1): Change implementation to reprocess attributes that
5579         need str_offsets_base and addr_base.
5580         (partial_die_info::read): Likewise.
5581         (read_attribute_reprocess): New function definition.
5582         (read_attribute_value): Change API to take an additional out parameter,
5583         need_reprocess.  Handle DW_FORM_rnglistx.  No longer trigger an error
5584         when a non-dwo compile unit has index based attributes.
5585         (read_attribute): Reflect API changes.
5586         (read_addr_index_1): Reflect API changes.  Update comments.
5587         (dwarf2_read_addr_index_data): Reflect API changes.
5588         (dwarf2_read_addr_index): Likewise.
5589         (read_str_index): Change API and implementation.  This becomes a helper
5590         to be used by the new string index related methods.  Update error
5591         message and comments.
5592         (read_dwo_str_index): New function definition.
5593         (read_stub_str_index): Likewise.
5594         * dwarf2read.h (dwarf2_per_objfile): Add str_offsets field.
5595         * symfile.h (dwarf2_debug_sections): Likewise.
5596         * xcoffread.c (dwarf2_debug_sections): Likewise.
5597
5598 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5599
5600         * gdbcore.h (struct core_fns) <core_read_registers>: Change
5601         core_reg_sect type to gdb_byte *.
5602         * arm-nbsd-nat.c (fetch_elfcore_registers): Likewise.
5603         * cris-tdep.c (fetch_core_registers): Likewise.
5604         * corelow.c (core_target::get_core_register_section): Change
5605         type of `contents` to gdb::byte_vector.
5606
5607 2020-01-13  Andrew Burgess  <andrew.burgess@embecosm.com>
5608
5609         * tui/tui-wingeneral.c (box_win): Position the title in the center
5610         of the border.
5611
5612 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
5613
5614         * corelow.c (core_target::get_core_register_section): Use
5615           std::vector instead of alloca.
5616
5617 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5618
5619         * warning.m4: Add -Wmissing-declarations to build_warnings.
5620         * configure: Re-generate.
5621
5622 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5623
5624         * python/python.c (init__gdb_module): Add declaration.
5625
5626 2020-01-13  Simon Marchi  <simon.marchi@efficios.com>
5627
5628         * aarch64-fbsd-nat.c (_initialize_aarch64_fbsd_nat): Add declaration.
5629         * aarch64-fbsd-tdep.c (_initialize_aarch64_fbsd_tdep): Add declaration.
5630         * aarch64-linux-nat.c (_initialize_aarch64_linux_nat): Add declaration.
5631         * aarch64-linux-tdep.c (_initialize_aarch64_linux_tdep): Add declaration.
5632         * aarch64-newlib-tdep.c (_initialize_aarch64_newlib_tdep): Add declaration.
5633         * aarch64-tdep.c (_initialize_aarch64_tdep): Add declaration.
5634         * ada-exp.y (_initialize_ada_exp): Add declaration.
5635         * ada-lang.c (_initialize_ada_language): Add declaration.
5636         * ada-tasks.c (_initialize_tasks): Add declaration.
5637         * agent.c (_initialize_agent): Add declaration.
5638         * aix-thread.c (_initialize_aix_thread): Add declaration.
5639         * alpha-bsd-nat.c (_initialize_alphabsd_nat): Add declaration.
5640         * alpha-linux-nat.c (_initialize_alpha_linux_nat): Add declaration.
5641         * alpha-linux-tdep.c (_initialize_alpha_linux_tdep): Add declaration.
5642         * alpha-nbsd-tdep.c (_initialize_alphanbsd_tdep): Add declaration.
5643         * alpha-obsd-tdep.c (_initialize_alphaobsd_tdep): Add declaration.
5644         * alpha-tdep.c (_initialize_alpha_tdep): Add declaration.
5645         * amd64-darwin-tdep.c (_initialize_amd64_darwin_tdep): Add declaration.
5646         * amd64-dicos-tdep.c (_initialize_amd64_dicos_tdep): Add declaration.
5647         * amd64-fbsd-nat.c (_initialize_amd64fbsd_nat): Add declaration.
5648         * amd64-fbsd-tdep.c (_initialize_amd64fbsd_tdep): Add declaration.
5649         * amd64-linux-nat.c (_initialize_amd64_linux_nat): Add declaration.
5650         * amd64-linux-tdep.c (_initialize_amd64_linux_tdep): Add declaration.
5651         * amd64-nbsd-nat.c (_initialize_amd64nbsd_nat): Add declaration.
5652         * amd64-nbsd-tdep.c (_initialize_amd64nbsd_tdep): Add declaration.
5653         * amd64-obsd-nat.c (_initialize_amd64obsd_nat): Add declaration.
5654         * amd64-obsd-tdep.c (_initialize_amd64obsd_tdep): Add declaration.
5655         * amd64-sol2-tdep.c (_initialize_amd64_sol2_tdep): Add declaration.
5656         * amd64-tdep.c (_initialize_amd64_tdep): Add declaration.
5657         * amd64-windows-nat.c (_initialize_amd64_windows_nat): Add declaration.
5658         * amd64-windows-tdep.c (_initialize_amd64_windows_tdep): Add declaration.
5659         * annotate.c (_initialize_annotate): Add declaration.
5660         * arc-newlib-tdep.c (_initialize_arc_newlib_tdep): Add declaration.
5661         * arc-tdep.c (_initialize_arc_tdep): Add declaration.
5662         * arch-utils.c (_initialize_gdbarch_utils): Add declaration.
5663         * arm-fbsd-nat.c (_initialize_arm_fbsd_nat): Add declaration.
5664         * arm-fbsd-tdep.c (_initialize_arm_fbsd_tdep): Add declaration.
5665         * arm-linux-nat.c (_initialize_arm_linux_nat): Add declaration.
5666         * arm-linux-tdep.c (_initialize_arm_linux_tdep): Add declaration.
5667         * arm-nbsd-nat.c (_initialize_arm_netbsd_nat): Add declaration.
5668         * arm-nbsd-tdep.c (_initialize_arm_netbsd_tdep): Add declaration.
5669         * arm-obsd-tdep.c (_initialize_armobsd_tdep): Add declaration.
5670         * arm-pikeos-tdep.c (_initialize_arm_pikeos_tdep): Add declaration.
5671         * arm-symbian-tdep.c (_initialize_arm_symbian_tdep): Add declaration.
5672         * arm-tdep.c (_initialize_arm_tdep): Add declaration.
5673         * arm-wince-tdep.c (_initialize_arm_wince_tdep): Add declaration.
5674         * auto-load.c (_initialize_auto_load): Add declaration.
5675         * auxv.c (_initialize_auxv): Add declaration.
5676         * avr-tdep.c (_initialize_avr_tdep): Add declaration.
5677         * ax-gdb.c (_initialize_ax_gdb): Add declaration.
5678         * bfin-linux-tdep.c (_initialize_bfin_linux_tdep): Add declaration.
5679         * bfin-tdep.c (_initialize_bfin_tdep): Add declaration.
5680         * break-catch-sig.c (_initialize_break_catch_sig): Add declaration.
5681         * break-catch-syscall.c (_initialize_break_catch_syscall): Add declaration.
5682         * break-catch-throw.c (_initialize_break_catch_throw): Add declaration.
5683         * breakpoint.c (_initialize_breakpoint): Add declaration.
5684         * bsd-uthread.c (_initialize_bsd_uthread): Add declaration.
5685         * btrace.c (_initialize_btrace): Add declaration.
5686         * charset.c (_initialize_charset): Add declaration.
5687         * cli/cli-cmds.c (_initialize_cli_cmds): Add declaration.
5688         * cli/cli-dump.c (_initialize_cli_dump): Add declaration.
5689         * cli/cli-interp.c (_initialize_cli_interp): Add declaration.
5690         * cli/cli-logging.c (_initialize_cli_logging): Add declaration.
5691         * cli/cli-script.c (_initialize_cli_script): Add declaration.
5692         * cli/cli-style.c (_initialize_cli_style): Add declaration.
5693         * coff-pe-read.c (_initialize_coff_pe_read): Add declaration.
5694         * coffread.c (_initialize_coffread): Add declaration.
5695         * compile/compile-cplus-types.c (_initialize_compile_cplus_types): Add declaration.
5696         * compile/compile.c (_initialize_compile): Add declaration.
5697         * complaints.c (_initialize_complaints): Add declaration.
5698         * completer.c (_initialize_completer): Add declaration.
5699         * copying.c (_initialize_copying): Add declaration.
5700         * corefile.c (_initialize_core): Add declaration.
5701         * corelow.c (_initialize_corelow): Add declaration.
5702         * cp-abi.c (_initialize_cp_abi): Add declaration.
5703         * cp-namespace.c (_initialize_cp_namespace): Add declaration.
5704         * cp-support.c (_initialize_cp_support): Add declaration.
5705         * cp-valprint.c (_initialize_cp_valprint): Add declaration.
5706         * cris-linux-tdep.c (_initialize_cris_linux_tdep): Add declaration.
5707         * cris-tdep.c (_initialize_cris_tdep): Add declaration.
5708         * csky-linux-tdep.c (_initialize_csky_linux_tdep): Add declaration.
5709         * csky-tdep.c (_initialize_csky_tdep): Add declaration.
5710         * ctfread.c (_initialize_ctfread): Add declaration.
5711         * d-lang.c (_initialize_d_language): Add declaration.
5712         * darwin-nat-info.c (_initialize_darwin_info_commands): Add declaration.
5713         * darwin-nat.c (_initialize_darwin_nat): Add declaration.
5714         * dbxread.c (_initialize_dbxread): Add declaration.
5715         * dcache.c (_initialize_dcache): Add declaration.
5716         * disasm-selftests.c (_initialize_disasm_selftests): Add declaration.
5717         * disasm.c (_initialize_disasm): Add declaration.
5718         * dtrace-probe.c (_initialize_dtrace_probe): Add declaration.
5719         * dummy-frame.c (_initialize_dummy_frame): Add declaration.
5720         * dwarf-index-cache.c (_initialize_index_cache): Add declaration.
5721         * dwarf-index-write.c (_initialize_dwarf_index_write): Add declaration.
5722         * dwarf2-frame-tailcall.c (_initialize_tailcall_frame): Add declaration.
5723         * dwarf2-frame.c (_initialize_dwarf2_frame): Add declaration.
5724         * dwarf2expr.c (_initialize_dwarf2expr): Add declaration.
5725         * dwarf2loc.c (_initialize_dwarf2loc): Add declaration.
5726         * dwarf2read.c (_initialize_dwarf2_read): Add declaration.
5727         * elfread.c (_initialize_elfread): Add declaration.
5728         * exec.c (_initialize_exec): Add declaration.
5729         * extension.c (_initialize_extension): Add declaration.
5730         * f-lang.c (_initialize_f_language): Add declaration.
5731         * f-valprint.c (_initialize_f_valprint): Add declaration.
5732         * fbsd-nat.c (_initialize_fbsd_nat): Add declaration.
5733         * fbsd-tdep.c (_initialize_fbsd_tdep): Add declaration.
5734         * filesystem.c (_initialize_filesystem): Add declaration.
5735         * findcmd.c (_initialize_mem_search): Add declaration.
5736         * findvar.c (_initialize_findvar): Add declaration.
5737         * fork-child.c (_initialize_fork_child): Add declaration.
5738         * frame-base.c (_initialize_frame_base): Add declaration.
5739         * frame-unwind.c (_initialize_frame_unwind): Add declaration.
5740         * frame.c (_initialize_frame): Add declaration.
5741         * frv-linux-tdep.c (_initialize_frv_linux_tdep): Add declaration.
5742         * frv-tdep.c (_initialize_frv_tdep): Add declaration.
5743         * ft32-tdep.c (_initialize_ft32_tdep): Add declaration.
5744         * gcore.c (_initialize_gcore): Add declaration.
5745         * gdb-demangle.c (_initialize_gdb_demangle): Add declaration.
5746         * gdb_bfd.c (_initialize_gdb_bfd): Add declaration.
5747         * gdbarch-selftests.c (_initialize_gdbarch_selftests): Add declaration.
5748         * gdbarch.c (_initialize_gdbarch): Add declaration.
5749         * gdbtypes.c (_initialize_gdbtypes): Add declaration.
5750         * gnu-nat.c (_initialize_gnu_nat): Add declaration.
5751         * gnu-v2-abi.c (_initialize_gnu_v2_abi): Add declaration.
5752         * gnu-v3-abi.c (_initialize_gnu_v3_abi): Add declaration.
5753         * go-lang.c (_initialize_go_language): Add declaration.
5754         * go32-nat.c (_initialize_go32_nat): Add declaration.
5755         * guile/guile.c (_initialize_guile): Add declaration.
5756         * h8300-tdep.c (_initialize_h8300_tdep): Add declaration.
5757         * hppa-linux-nat.c (_initialize_hppa_linux_nat): Add declaration.
5758         * hppa-linux-tdep.c (_initialize_hppa_linux_tdep): Add declaration.
5759         * hppa-nbsd-nat.c (_initialize_hppanbsd_nat): Add declaration.
5760         * hppa-nbsd-tdep.c (_initialize_hppanbsd_tdep): Add declaration.
5761         * hppa-obsd-nat.c (_initialize_hppaobsd_nat): Add declaration.
5762         * hppa-obsd-tdep.c (_initialize_hppabsd_tdep): Add declaration.
5763         * hppa-tdep.c (_initialize_hppa_tdep): Add declaration.
5764         * i386-bsd-nat.c (_initialize_i386bsd_nat): Add declaration.
5765         * i386-cygwin-tdep.c (_initialize_i386_cygwin_tdep): Add declaration.
5766         * i386-darwin-nat.c (_initialize_i386_darwin_nat): Add declaration.
5767         * i386-darwin-tdep.c (_initialize_i386_darwin_tdep): Add declaration.
5768         * i386-dicos-tdep.c (_initialize_i386_dicos_tdep): Add declaration.
5769         * i386-fbsd-nat.c (_initialize_i386fbsd_nat): Add declaration.
5770         * i386-fbsd-tdep.c (_initialize_i386fbsd_tdep): Add declaration.
5771         * i386-gnu-nat.c (_initialize_i386gnu_nat): Add declaration.
5772         * i386-gnu-tdep.c (_initialize_i386gnu_tdep): Add declaration.
5773         * i386-go32-tdep.c (_initialize_i386_go32_tdep): Add declaration.
5774         * i386-linux-nat.c (_initialize_i386_linux_nat): Add declaration.
5775         * i386-linux-tdep.c (_initialize_i386_linux_tdep): Add declaration.
5776         * i386-nbsd-nat.c (_initialize_i386nbsd_nat): Add declaration.
5777         * i386-nbsd-tdep.c (_initialize_i386nbsd_tdep): Add declaration.
5778         * i386-nto-tdep.c (_initialize_i386nto_tdep): Add declaration.
5779         * i386-obsd-nat.c (_initialize_i386obsd_nat): Add declaration.
5780         * i386-obsd-tdep.c (_initialize_i386obsd_tdep): Add declaration.
5781         * i386-sol2-nat.c (_initialize_amd64_sol2_nat): Add declaration.
5782         * i386-sol2-tdep.c (_initialize_i386_sol2_tdep): Add declaration.
5783         * i386-tdep.c (_initialize_i386_tdep): Add declaration.
5784         * i386-windows-nat.c (_initialize_i386_windows_nat): Add declaration.
5785         * ia64-libunwind-tdep.c (_initialize_libunwind_frame): Add declaration.
5786         * ia64-linux-nat.c (_initialize_ia64_linux_nat): Add declaration.
5787         * ia64-linux-tdep.c (_initialize_ia64_linux_tdep): Add declaration.
5788         * ia64-tdep.c (_initialize_ia64_tdep): Add declaration.
5789         * ia64-vms-tdep.c (_initialize_ia64_vms_tdep): Add declaration.
5790         * infcall.c (_initialize_infcall): Add declaration.
5791         * infcmd.c (_initialize_infcmd): Add declaration.
5792         * inflow.c (_initialize_inflow): Add declaration.
5793         * infrun.c (_initialize_infrun): Add declaration.
5794         * interps.c (_initialize_interpreter): Add declaration.
5795         * iq2000-tdep.c (_initialize_iq2000_tdep): Add declaration.
5796         * jit.c (_initialize_jit): Add declaration.
5797         * language.c (_initialize_language): Add declaration.
5798         * linux-fork.c (_initialize_linux_fork): Add declaration.
5799         * linux-nat.c (_initialize_linux_nat): Add declaration.
5800         * linux-tdep.c (_initialize_linux_tdep): Add declaration.
5801         * linux-thread-db.c (_initialize_thread_db): Add declaration.
5802         * lm32-tdep.c (_initialize_lm32_tdep): Add declaration.
5803         * m2-lang.c (_initialize_m2_language): Add declaration.
5804         * m32c-tdep.c (_initialize_m32c_tdep): Add declaration.
5805         * m32r-linux-nat.c (_initialize_m32r_linux_nat): Add declaration.
5806         * m32r-linux-tdep.c (_initialize_m32r_linux_tdep): Add declaration.
5807         * m32r-tdep.c (_initialize_m32r_tdep): Add declaration.
5808         * m68hc11-tdep.c (_initialize_m68hc11_tdep): Add declaration.
5809         * m68k-bsd-nat.c (_initialize_m68kbsd_nat): Add declaration.
5810         * m68k-bsd-tdep.c (_initialize_m68kbsd_tdep): Add declaration.
5811         * m68k-linux-nat.c (_initialize_m68k_linux_nat): Add declaration.
5812         * m68k-linux-tdep.c (_initialize_m68k_linux_tdep): Add declaration.
5813         * m68k-tdep.c (_initialize_m68k_tdep): Add declaration.
5814         * machoread.c (_initialize_machoread): Add declaration.
5815         * macrocmd.c (_initialize_macrocmd): Add declaration.
5816         * macroscope.c (_initialize_macroscope): Add declaration.
5817         * maint-test-options.c (_initialize_maint_test_options): Add declaration.
5818         * maint-test-settings.c (_initialize_maint_test_settings): Add declaration.
5819         * maint.c (_initialize_maint_cmds): Add declaration.
5820         * mdebugread.c (_initialize_mdebugread): Add declaration.
5821         * memattr.c (_initialize_mem): Add declaration.
5822         * mep-tdep.c (_initialize_mep_tdep): Add declaration.
5823         * mi/mi-cmd-env.c (_initialize_mi_cmd_env): Add declaration.
5824         * mi/mi-cmds.c (_initialize_mi_cmds): Add declaration.
5825         * mi/mi-interp.c (_initialize_mi_interp): Add declaration.
5826         * mi/mi-main.c (_initialize_mi_main): Add declaration.
5827         * microblaze-linux-tdep.c (_initialize_microblaze_linux_tdep): Add declaration.
5828         * microblaze-tdep.c (_initialize_microblaze_tdep): Add declaration.
5829         * mips-fbsd-nat.c (_initialize_mips_fbsd_nat): Add declaration.
5830         * mips-fbsd-tdep.c (_initialize_mips_fbsd_tdep): Add declaration.
5831         * mips-linux-nat.c (_initialize_mips_linux_nat): Add declaration.
5832         * mips-linux-tdep.c (_initialize_mips_linux_tdep): Add declaration.
5833         * mips-nbsd-nat.c (_initialize_mipsnbsd_nat): Add declaration.
5834         * mips-nbsd-tdep.c (_initialize_mipsnbsd_tdep): Add declaration.
5835         * mips-sde-tdep.c (_initialize_mips_sde_tdep): Add declaration.
5836         * mips-tdep.c (_initialize_mips_tdep): Add declaration.
5837         * mips64-obsd-nat.c (_initialize_mips64obsd_nat): Add declaration.
5838         * mips64-obsd-tdep.c (_initialize_mips64obsd_tdep): Add declaration.
5839         * mipsread.c (_initialize_mipsread): Add declaration.
5840         * mn10300-linux-tdep.c (_initialize_mn10300_linux_tdep): Add declaration.
5841         * mn10300-tdep.c (_initialize_mn10300_tdep): Add declaration.
5842         * moxie-tdep.c (_initialize_moxie_tdep): Add declaration.
5843         * msp430-tdep.c (_initialize_msp430_tdep): Add declaration.
5844         * nds32-tdep.c (_initialize_nds32_tdep): Add declaration.
5845         * nios2-linux-tdep.c (_initialize_nios2_linux_tdep): Add declaration.
5846         * nios2-tdep.c (_initialize_nios2_tdep): Add declaration.
5847         * nto-procfs.c (_initialize_procfs): Add declaration.
5848         * objc-lang.c (_initialize_objc_language): Add declaration.
5849         * observable.c (_initialize_observer): Add declaration.
5850         * opencl-lang.c (_initialize_opencl_language): Add declaration.
5851         * or1k-linux-tdep.c (_initialize_or1k_linux_tdep): Add declaration.
5852         * or1k-tdep.c (_initialize_or1k_tdep): Add declaration.
5853         * osabi.c (_initialize_gdb_osabi): Add declaration.
5854         * osdata.c (_initialize_osdata): Add declaration.
5855         * p-valprint.c (_initialize_pascal_valprint): Add declaration.
5856         * parse.c (_initialize_parse): Add declaration.
5857         * ppc-fbsd-nat.c (_initialize_ppcfbsd_nat): Add declaration.
5858         * ppc-fbsd-tdep.c (_initialize_ppcfbsd_tdep): Add declaration.
5859         * ppc-linux-nat.c (_initialize_ppc_linux_nat): Add declaration.
5860         * ppc-linux-tdep.c (_initialize_ppc_linux_tdep): Add declaration.
5861         * ppc-nbsd-nat.c (_initialize_ppcnbsd_nat): Add declaration.
5862         * ppc-nbsd-tdep.c (_initialize_ppcnbsd_tdep): Add declaration.
5863         * ppc-obsd-nat.c (_initialize_ppcobsd_nat): Add declaration.
5864         * ppc-obsd-tdep.c (_initialize_ppcobsd_tdep): Add declaration.
5865         * printcmd.c (_initialize_printcmd): Add declaration.
5866         * probe.c (_initialize_probe): Add declaration.
5867         * proc-api.c (_initialize_proc_api): Add declaration.
5868         * proc-events.c (_initialize_proc_events): Add declaration.
5869         * proc-service.c (_initialize_proc_service): Add declaration.
5870         * procfs.c (_initialize_procfs): Add declaration.
5871         * producer.c (_initialize_producer): Add declaration.
5872         * psymtab.c (_initialize_psymtab): Add declaration.
5873         * python/python.c (_initialize_python): Add declaration.
5874         * ravenscar-thread.c (_initialize_ravenscar): Add declaration.
5875         * record-btrace.c (_initialize_record_btrace): Add declaration.
5876         * record-full.c (_initialize_record_full): Add declaration.
5877         * record.c (_initialize_record): Add declaration.
5878         * regcache-dump.c (_initialize_regcache_dump): Add declaration.
5879         * regcache.c (_initialize_regcache): Add declaration.
5880         * reggroups.c (_initialize_reggroup): Add declaration.
5881         * remote-notif.c (_initialize_notif): Add declaration.
5882         * remote-sim.c (_initialize_remote_sim): Add declaration.
5883         * remote.c (_initialize_remote): Add declaration.
5884         * reverse.c (_initialize_reverse): Add declaration.
5885         * riscv-fbsd-nat.c (_initialize_riscv_fbsd_nat): Add declaration.
5886         * riscv-fbsd-tdep.c (_initialize_riscv_fbsd_tdep): Add declaration.
5887         * riscv-linux-nat.c (_initialize_riscv_linux_nat): Add declaration.
5888         * riscv-linux-tdep.c (_initialize_riscv_linux_tdep): Add declaration.
5889         * riscv-tdep.c (_initialize_riscv_tdep): Add declaration.
5890         * rl78-tdep.c (_initialize_rl78_tdep): Add declaration.
5891         * rs6000-aix-tdep.c (_initialize_rs6000_aix_tdep): Add declaration.
5892         * rs6000-lynx178-tdep.c (_initialize_rs6000_lynx178_tdep):
5893         Add declaration.
5894         * rs6000-nat.c (_initialize_rs6000_nat): Add declaration.
5895         * rs6000-tdep.c (_initialize_rs6000_tdep): Add declaration.
5896         * run-on-main-thread.c (_initialize_run_on_main_thread): Add declaration.
5897         * rust-exp.y (_initialize_rust_exp): Add declaration.
5898         * rx-tdep.c (_initialize_rx_tdep): Add declaration.
5899         * s12z-tdep.c (_initialize_s12z_tdep): Add declaration.
5900         * s390-linux-nat.c (_initialize_s390_nat): Add declaration.
5901         * s390-linux-tdep.c (_initialize_s390_linux_tdep): Add declaration.
5902         * s390-tdep.c (_initialize_s390_tdep): Add declaration.
5903         * score-tdep.c (_initialize_score_tdep): Add declaration.
5904         * ser-go32.c (_initialize_ser_dos): Add declaration.
5905         * ser-mingw.c (_initialize_ser_windows): Add declaration.
5906         * ser-pipe.c (_initialize_ser_pipe): Add declaration.
5907         * ser-tcp.c (_initialize_ser_tcp): Add declaration.
5908         * ser-uds.c (_initialize_ser_socket): Add declaration.
5909         * ser-unix.c (_initialize_ser_hardwire): Add declaration.
5910         * serial.c (_initialize_serial): Add declaration.
5911         * sh-linux-tdep.c (_initialize_sh_linux_tdep): Add declaration.
5912         * sh-nbsd-nat.c (_initialize_shnbsd_nat): Add declaration.
5913         * sh-nbsd-tdep.c (_initialize_shnbsd_tdep): Add declaration.
5914         * sh-tdep.c (_initialize_sh_tdep): Add declaration.
5915         * skip.c (_initialize_step_skip): Add declaration.
5916         * sol-thread.c (_initialize_sol_thread): Add declaration.
5917         * solib-aix.c (_initialize_solib_aix): Add declaration.
5918         * solib-darwin.c (_initialize_darwin_solib): Add declaration.
5919         * solib-dsbt.c (_initialize_dsbt_solib): Add declaration.
5920         * solib-frv.c (_initialize_frv_solib): Add declaration.
5921         * solib-svr4.c (_initialize_svr4_solib): Add declaration.
5922         * solib-target.c (_initialize_solib_target): Add declaration.
5923         * solib.c (_initialize_solib): Add declaration.
5924         * source-cache.c (_initialize_source_cache): Add declaration.
5925         * source.c (_initialize_source): Add declaration.
5926         * sparc-linux-nat.c (_initialize_sparc_linux_nat): Add declaration.
5927         * sparc-linux-tdep.c (_initialize_sparc_linux_tdep): Add declaration.
5928         * sparc-nat.c (_initialize_sparc_nat): Add declaration.
5929         * sparc-nbsd-nat.c (_initialize_sparcnbsd_nat): Add declaration.
5930         * sparc-nbsd-tdep.c (_initialize_sparcnbsd_tdep): Add declaration.
5931         * sparc-obsd-tdep.c (_initialize_sparc32obsd_tdep): Add declaration.
5932         * sparc-sol2-tdep.c (_initialize_sparc_sol2_tdep): Add declaration.
5933         * sparc-tdep.c (_initialize_sparc_tdep): Add declaration.
5934         * sparc64-fbsd-nat.c (_initialize_sparc64fbsd_nat): Add declaration.
5935         * sparc64-fbsd-tdep.c (_initialize_sparc64fbsd_tdep): Add declaration.
5936         * sparc64-linux-nat.c (_initialize_sparc64_linux_nat): Add declaration.
5937         * sparc64-linux-tdep.c (_initialize_sparc64_linux_tdep): Add declaration.
5938         * sparc64-nat.c (_initialize_sparc64_nat): Add declaration.
5939         * sparc64-nbsd-nat.c (_initialize_sparc64nbsd_nat): Add declaration.
5940         * sparc64-nbsd-tdep.c (_initialize_sparc64nbsd_tdep): Add declaration.
5941         * sparc64-obsd-nat.c (_initialize_sparc64obsd_nat): Add declaration.
5942         * sparc64-obsd-tdep.c (_initialize_sparc64obsd_tdep): Add declaration.
5943         * sparc64-sol2-tdep.c (_initialize_sparc64_sol2_tdep): Add declaration.
5944         * sparc64-tdep.c (_initialize_sparc64_adi_tdep): Add declaration.
5945         * stabsread.c (_initialize_stabsread): Add declaration.
5946         * stack.c (_initialize_stack): Add declaration.
5947         * stap-probe.c (_initialize_stap_probe): Add declaration.
5948         * std-regs.c (_initialize_frame_reg): Add declaration.
5949         * symfile-debug.c (_initialize_symfile_debug): Add declaration.
5950         * symfile-mem.c (_initialize_symfile_mem): Add declaration.
5951         * symfile.c (_initialize_symfile): Add declaration.
5952         * symmisc.c (_initialize_symmisc): Add declaration.
5953         * symtab.c (_initialize_symtab): Add declaration.
5954         * target.c (_initialize_target): Add declaration.
5955         * target-connection.c (_initialize_target_connection): Add
5956         declaration.
5957         * target-dcache.c (_initialize_target_dcache): Add declaration.
5958         * target-descriptions.c (_initialize_target_descriptions): Add declaration.
5959         * thread.c (_initialize_thread): Add declaration.
5960         * tic6x-linux-tdep.c (_initialize_tic6x_linux_tdep): Add declaration.
5961         * tic6x-tdep.c (_initialize_tic6x_tdep): Add declaration.
5962         * tilegx-linux-nat.c (_initialize_tile_linux_nat): Add declaration.
5963         * tilegx-linux-tdep.c (_initialize_tilegx_linux_tdep): Add declaration.
5964         * tilegx-tdep.c (_initialize_tilegx_tdep): Add declaration.
5965         * tracectf.c (_initialize_ctf): Add declaration.
5966         * tracefile-tfile.c (_initialize_tracefile_tfile): Add declaration.
5967         * tracefile.c (_initialize_tracefile): Add declaration.
5968         * tracepoint.c (_initialize_tracepoint): Add declaration.
5969         * tui/tui-hooks.c (_initialize_tui_hooks): Add declaration.
5970         * tui/tui-interp.c (_initialize_tui_interp): Add declaration.
5971         * tui/tui-layout.c (_initialize_tui_layout): Add declaration.
5972         * tui/tui-regs.c (_initialize_tui_regs): Add declaration.
5973         * tui/tui-stack.c (_initialize_tui_stack): Add declaration.
5974         * tui/tui-win.c (_initialize_tui_win): Add declaration.
5975         * tui/tui.c (_initialize_tui): Add declaration.
5976         * typeprint.c (_initialize_typeprint): Add declaration.
5977         * ui-style.c (_initialize_ui_style): Add declaration.
5978         * unittests/array-view-selftests.c (_initialize_array_view_selftests): Add declaration.
5979         * unittests/child-path-selftests.c (_initialize_child_path_selftests): Add declaration.
5980         * unittests/cli-utils-selftests.c (_initialize_cli_utils_selftests): Add declaration.
5981         * unittests/common-utils-selftests.c (_initialize_common_utils_selftests): Add declaration.
5982         * unittests/copy_bitwise-selftests.c (_initialize_copy_bitwise_utils_selftests): Add declaration.
5983         * unittests/environ-selftests.c (_initialize_environ_selftests): Add declaration.
5984         * unittests/filtered_iterator-selftests.c
5985         (_initialize_filtered_iterator_selftests): Add declaration.
5986         * unittests/format_pieces-selftests.c (_initialize_format_pieces_selftests): Add declaration.
5987         * unittests/function-view-selftests.c (_initialize_function_view_selftests): Add declaration.
5988         * unittests/help-doc-selftests.c (_initialize_help_doc_selftests): Add declaration.
5989         * unittests/lookup_name_info-selftests.c (_initialize_lookup_name_info_selftests): Add declaration.
5990         * unittests/main-thread-selftests.c
5991         (_initialize_main_thread_selftests): Add declaration.
5992         * unittests/memory-map-selftests.c (_initialize_memory_map_selftests): Add declaration.
5993         * unittests/memrange-selftests.c (_initialize_memrange_selftests): Add declaration.
5994         * unittests/mkdir-recursive-selftests.c (_initialize_mkdir_recursive_selftests): Add declaration.
5995         * unittests/observable-selftests.c (_initialize_observer_selftest): Add declaration.
5996         * unittests/offset-type-selftests.c (_initialize_offset_type_selftests): Add declaration.
5997         * unittests/optional-selftests.c (_initialize_optional_selftests): Add declaration.
5998         * unittests/parse-connection-spec-selftests.c (_initialize_parse_connection_spec_selftests): Add declaration.
5999         * unittests/rsp-low-selftests.c (_initialize_rsp_low_selftests): Add declaration.
6000         * unittests/scoped_fd-selftests.c (_initialize_scoped_fd_selftests): Add declaration.
6001         * unittests/scoped_mmap-selftests.c (_initialize_scoped_mmap_selftests): Add declaration.
6002         * unittests/scoped_restore-selftests.c (_initialize_scoped_restore_selftests): Add declaration.
6003         * unittests/string_view-selftests.c (_initialize_string_view_selftests): Add declaration.
6004         * unittests/style-selftests.c (_initialize_style_selftest): Add declaration.
6005         * unittests/tracepoint-selftests.c (_initialize_tracepoint_selftests): Add declaration.
6006         * unittests/tui-selftests.c (_initialize_tui_selftest): Add
6007         declaration.
6008         * unittests/unpack-selftests.c (_initialize_unpack_selftests): Add declaration.
6009         * unittests/utils-selftests.c (_initialize_utils_selftests): Add declaration.
6010         * unittests/vec-utils-selftests.c (_initialize_vec_utils_selftests): Add declaration.
6011         * unittests/xml-utils-selftests.c (_initialize_xml_utils): Add declaration.
6012         * user-regs.c (_initialize_user_regs): Add declaration.
6013         * utils.c (_initialize_utils): Add declaration.
6014         * v850-tdep.c (_initialize_v850_tdep): Add declaration.
6015         * valops.c (_initialize_valops): Add declaration.
6016         * valprint.c (_initialize_valprint): Add declaration.
6017         * value.c (_initialize_values): Add declaration.
6018         * varobj.c (_initialize_varobj): Add declaration.
6019         * vax-bsd-nat.c (_initialize_vaxbsd_nat): Add declaration.
6020         * vax-nbsd-tdep.c (_initialize_vaxnbsd_tdep): Add declaration.
6021         * vax-tdep.c (_initialize_vax_tdep): Add declaration.
6022         * windows-nat.c (_initialize_windows_nat): Add declaration.
6023         (_initialize_check_for_gdb_ini): Add declaration.
6024         (_initialize_loadable): Add declaration.
6025         * windows-tdep.c (_initialize_windows_tdep): Add declaration.
6026         * x86-bsd-nat.c (_initialize_x86_bsd_nat): Add declaration.
6027         * x86-linux-nat.c (_initialize_x86_linux_nat): Add declaration.
6028         * xcoffread.c (_initialize_xcoffread): Add declaration.
6029         * xml-support.c (_initialize_xml_support): Add declaration.
6030         * xstormy16-tdep.c (_initialize_xstormy16_tdep): Add declaration.
6031         * xtensa-linux-nat.c (_initialize_xtensa_linux_nat): Add declaration.
6032         * xtensa-linux-tdep.c (_initialize_xtensa_linux_tdep): Add declaration.
6033         * xtensa-tdep.c (_initialize_xtensa_tdep): Add declaration.
6034
6035 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6036
6037         * regformats/regdat.sh: Generate declaration for init function.
6038
6039 2020-01-13  Simon Marchi  <simon.marchi@polymtl.ca>
6040
6041         * remote-sim.c (next_pid, INITIAL_PID, sim_inferior_data): Move
6042         up.
6043         (gdbsim_target) <get_inferior_data_by_ptid, resume_one_inferior,
6044         close_one_inferior>: New methods.
6045         (get_sim_inferior_data_by_ptid): Move to gdbsim_target,
6046         pass down target to find_inferior_pid.
6047         (gdbsim_target::fetch_registers, gdbsim_target::store_registers):
6048         Pass down target to find_inferior_ptid.
6049         (gdbsim_target::create_inferior): Pass down target to
6050         add_thread_silent.
6051         (gdbsim_close_inferior): Move to gdbsim_close_inferior, pass
6052         target down to find_inferior_ptid and switch_to_thread.
6053         (gdbsim_target::close): Update to call close_one_inferior.
6054         (struct resume_data): Remove.
6055         (gdbsim_resume_inferior): Move to gdbsim_target.  Take arguments
6056         directly, rather than through a void pointer.
6057         (gdbsim_target::resume): Update to call resume_one_inferior.
6058
6059 2020-01-12  Simon Marchi  <simon.marchi@polymtl.ca>
6060
6061         * gdbsupport/gdb_wait.c: Include gdb_wait.h.
6062
6063 2020-01-12  Pedro Alves  <palves@redhat.com>
6064
6065         * bsd-kvm.c (bsd_kvm_target::close): Call exit_inferior_silent
6066         directly for the current inferior instead of
6067         discard_all_inferiors.
6068         (discard_all_inferiors): Delete.
6069
6070 2020-01-11  Tom Tromey  <tom@tromey.com>
6071
6072         * tui/tui-wingeneral.c (box_win): Check cli_styling.
6073         * tui/tui-winsource.c (tui_source_window_base::refill): Use
6074         deprecated_safe_get_selected_frame.
6075
6076 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6077
6078         * inferior.c (print_inferior): Switch inferior before printing it.
6079
6080 2020-01-10  Aleksandar Paunovic  <aleksandar.paunovic@intel.com>
6081             Pedro Alves  <palves@redhat.com>
6082
6083         * progspace-and-thread.c (switch_to_program_space_and_thread):
6084         Assert there's an inferior for PSPACE.  Use
6085         switch_to_inferior_no_thread to switch the inferior too.
6086         * progspace.c (program_space::~program_space): Call
6087         clear_symtab_users here, with SYMFILE_DEFER_BP_RESET.
6088         (program_space::free_all_objfiles): Don't call clear_symtab_users
6089         here.
6090         * symfile.c (symbol_file_clear): Call clear_symtab_users here.
6091
6092 2020-01-10  Pedro Alves  <palves@redhat.com>
6093
6094         * NEWS: Mention multi-target debugging, "info connections", and
6095         "add-inferior -no-connection".
6096
6097 2020-01-10  Pedro Alves  <palves@redhat.com>
6098
6099         * infrun.c: Include "target-connection.h".
6100         (check_multi_target_resumption): New.
6101         (proceed): Call it.
6102         * target-connection.c (make_target_connection_string): Make
6103         extern.
6104         * target-connection.h (make_target_connection_string): Declare.
6105
6106 2020-01-10  Pedro Alves  <palves@redhat.com>
6107
6108         * Makefile.in (COMMON_SFILES): Add target-connection.c.
6109         * inferior.c (uiout_field_connection): New function.
6110         (print_inferior): Add new "connection-id" column.
6111         (add_inferior_command): Show connection number/string of added
6112         inferior.
6113         * process-stratum-target.h
6114         (process_stratum_target::connection_string): New virtual method.
6115         (process_stratum_target::connection_number): New field.
6116         * remote.c (remote_target::connection_string): New override.
6117         * target-connection.c: New file.
6118         * target-connection.h: New file.
6119         * target.c (decref_target): Remove process_stratum targets from
6120         the connection list.
6121         (target_stack::push): Add process_stratum targets to the
6122         connection list.
6123
6124 2020-01-10  Pedro Alves  <palves@redhat.com>
6125
6126         Revert:
6127         2016-04-12  Pedro Alves  <palves@redhat.com>
6128         * serial.c (serial_open, serial_fdopen_ops, do_serial_close):
6129         Remove references to name.
6130         * serial.h (struct serial) <name>: Delete.
6131
6132 2020-01-10  Pedro Alves  <palves@redhat.com>
6133
6134         * gdbarch-selftests.c (register_to_value_test): Remove "target
6135         already pushed" check.
6136
6137 2020-01-10  Pedro Alves  <palves@redhat.com>
6138             John Baldwin  <jhb@FreeBSD.org>
6139
6140         * aarch64-linux-nat.c
6141         (aarch64_linux_nat_target::thread_architecture): Adjust.
6142         * ada-tasks.c (print_ada_task_info): Adjust find_thread_ptid call.
6143         (task_command_1): Likewise.
6144         * aix-thread.c (sync_threadlists, aix_thread_target::resume)
6145         (aix_thread_target::wait, aix_thread_target::fetch_registers)
6146         (aix_thread_target::store_registers)
6147         (aix_thread_target::thread_alive): Adjust.
6148         * amd64-fbsd-tdep.c: Include "inferior.h".
6149         (amd64fbsd_get_thread_local_address): Pass down target.
6150         * amd64-linux-nat.c (ps_get_thread_area): Use ps_prochandle
6151         thread's gdbarch instead of target_gdbarch.
6152         * break-catch-sig.c (signal_catchpoint_print_it): Adjust call to
6153         get_last_target_status.
6154         * break-catch-syscall.c (print_it_catch_syscall): Likewise.
6155         * breakpoint.c (breakpoints_should_be_inserted_now): Consider all
6156         inferiors.
6157         (update_inserted_breakpoint_locations): Skip if inferiors with no
6158         execution.
6159         (update_global_location_list): When handling moribund locations,
6160         find representative inferior for location's pspace, and use thread
6161         count of its process_stratum target.
6162         * bsd-kvm.c (bsd_kvm_target_open): Pass target down.
6163         * bsd-uthread.c (bsd_uthread_target::wait): Use
6164         as_process_stratum_target and adjust thread_change_ptid and
6165         add_thread calls.
6166         (bsd_uthread_target::update_thread_list): Use
6167         as_process_stratum_target and adjust find_thread_ptid,
6168         thread_change_ptid and add_thread calls.
6169         * btrace.c (maint_btrace_packet_history_cmd): Adjust
6170         find_thread_ptid call.
6171         * corelow.c (add_to_thread_list): Adjust add_thread call.
6172         (core_target_open): Adjust add_thread_silent and thread_count
6173         calls.
6174         (core_target::pid_to_str): Adjust find_inferior_ptid call.
6175         * ctf.c (ctf_target_open): Adjust add_thread_silent call.
6176         * event-top.c (async_disconnect): Pop targets from all inferiors.
6177         * exec.c (add_target_sections): Push exec target on all inferiors
6178         sharing the program space.
6179         (remove_target_sections): Remove the exec target from all
6180         inferiors sharing the program space.
6181         (exec_on_vfork): New.
6182         * exec.h (exec_on_vfork): Declare.
6183         * fbsd-nat.c (fbsd_add_threads): Add fbsd_nat_target parameter.
6184         Pass it down.
6185         (fbsd_nat_target::update_thread_list): Adjust.
6186         (fbsd_nat_target::resume): Adjust.
6187         (fbsd_handle_debug_trap): Add fbsd_nat_target parameter.  Pass it
6188         down.
6189         (fbsd_nat_target::wait, fbsd_nat_target::post_attach): Adjust.
6190         * fbsd-tdep.c (fbsd_corefile_thread): Adjust
6191         get_thread_arch_regcache call.
6192         * fork-child.c (gdb_startup_inferior): Pass target down to
6193         startup_inferior and set_executing.
6194         * gdbthread.h (struct process_stratum_target): Forward declare.
6195         (add_thread, add_thread_silent, add_thread_with_info)
6196         (in_thread_list): Add process_stratum_target parameter.
6197         (find_thread_ptid(inferior*, ptid_t)): New overload.
6198         (find_thread_ptid, thread_change_ptid): Add process_stratum_target
6199         parameter.
6200         (all_threads()): Delete overload.
6201         (all_threads, all_non_exited_threads): Add process_stratum_target
6202         parameter.
6203         (all_threads_safe): Use brace initialization.
6204         (thread_count): Add process_stratum_target parameter.
6205         (set_resumed, set_running, set_stop_requested, set_executing)
6206         (threads_are_executing, finish_thread_state): Add
6207         process_stratum_target parameter.
6208         (switch_to_thread): Use is_current_thread.
6209         * i386-fbsd-tdep.c: Include "inferior.h".
6210         (i386fbsd_get_thread_local_address): Pass down target.
6211         * i386-linux-nat.c (i386_linux_nat_target::low_resume): Adjust.
6212         * inf-child.c (inf_child_target::maybe_unpush_target): Remove
6213         have_inferiors check.
6214         * inf-ptrace.c (inf_ptrace_target::create_inferior)
6215         (inf_ptrace_target::attach): Adjust.
6216         * infcall.c (run_inferior_call): Adjust.
6217         * infcmd.c (run_command_1): Pass target to
6218         scoped_finish_thread_state.
6219         (proceed_thread_callback): Skip inferiors with no execution.
6220         (continue_command): Rename 'all_threads' local to avoid hiding
6221         'all_threads' function.  Adjust get_last_target_status call.
6222         (prepare_one_step): Adjust set_running call.
6223         (signal_command): Use user_visible_resume_target.  Compare thread
6224         pointers instead of inferior_ptid.
6225         (info_program_command): Adjust to pass down target.
6226         (attach_command): Mark target's 'thread_executing' flag.
6227         (stop_current_target_threads_ns): New, factored out from ...
6228         (interrupt_target_1): ... this.  Switch inferior before making
6229         target calls.
6230         * inferior-iter.h
6231         (struct all_inferiors_iterator, struct all_inferiors_range)
6232         (struct all_inferiors_safe_range)
6233         (struct all_non_exited_inferiors_range): Filter on
6234         process_stratum_target too.  Remove explicit.
6235         * inferior.c (inferior::inferior): Push dummy target on target
6236         stack.
6237         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors):
6238         Add process_stratum_target parameter, and pass it down.
6239         (have_live_inferiors): Adjust.
6240         (switch_to_inferior_and_push_target): New.
6241         (add_inferior_command, clone_inferior_command): Handle
6242         "-no-connection" parameter.  Use
6243         switch_to_inferior_and_push_target.
6244         (_initialize_inferior): Mention "-no-connection" option in
6245         the help of "add-inferior" and "clone-inferior" commands.
6246         * inferior.h: Include "process-stratum-target.h".
6247         (interrupt_target_1): Use bool.
6248         (struct inferior) <push_target, unpush_target, target_is_pushed,
6249         find_target_beneath, top_target, process_target, target_at,
6250         m_stack>: New.
6251         (discard_all_inferiors): Delete.
6252         (find_inferior_pid, find_inferior_ptid, number_of_live_inferiors)
6253         (all_inferiors, all_non_exited_inferiors): Add
6254         process_stratum_target parameter.
6255         * infrun.c: Include "gdb_select.h" and <unordered_map>.
6256         (target_last_proc_target): New global.
6257         (follow_fork_inferior): Push target on new inferior.  Pass target
6258         to add_thread_silent.  Call exec_on_vfork.  Handle target's
6259         reference count.
6260         (follow_fork): Adjust get_last_target_status call.  Also consider
6261         target.
6262         (follow_exec): Push target on new inferior.
6263         (struct execution_control_state) <target>: New field.
6264         (user_visible_resume_target): New.
6265         (do_target_resume): Call target_async.
6266         (resume_1): Set target's threads_executing flag.  Consider resume
6267         target.
6268         (commit_resume_all_targets): New.
6269         (proceed): Also consider resume target.  Skip threads of inferiors
6270         with no execution.  Commit resumtion in all targets.
6271         (start_remote): Pass current inferior to wait_for_inferior.
6272         (infrun_thread_stop_requested): Consider target as well.  Pass
6273         thread_info pointer to clear_inline_frame_state instead of ptid.
6274         (infrun_thread_thread_exit): Consider target as well.
6275         (random_pending_event_thread): New inferior parameter.  Use it.
6276         (do_target_wait): Rename to ...
6277         (do_target_wait_1): ... this.  Add inferior parameter, and pass it
6278         down.
6279         (threads_are_resumed_pending_p, do_target_wait): New.
6280         (prepare_for_detach): Adjust calls.
6281         (wait_for_inferior): New inferior parameter.  Handle it.  Use
6282         do_target_wait_1 instead of do_target_wait.
6283         (fetch_inferior_event): Adjust.  Switch to representative
6284         inferior.  Pass target down.
6285         (set_last_target_status): Add process_stratum_target parameter.
6286         Save target in global.
6287         (get_last_target_status): Add process_stratum_target parameter and
6288         handle it.
6289         (nullify_last_target_wait_ptid): Clear 'target_last_proc_target'.
6290         (context_switch): Check inferior_ptid == null_ptid before calling
6291         inferior_thread().
6292         (get_inferior_stop_soon): Pass down target.
6293         (wait_one): Rename to ...
6294         (poll_one_curr_target): ... this.
6295         (struct wait_one_event): New.
6296         (wait_one): New.
6297         (stop_all_threads): Adjust.
6298         (handle_no_resumed, handle_inferior_event): Adjust to consider the
6299         event's target.
6300         (switch_back_to_stepped_thread): Also consider target.
6301         (print_stop_event): Update.
6302         (normal_stop): Update.  Also consider the resume target.
6303         * infrun.h (wait_for_inferior): Remove declaration.
6304         (user_visible_resume_target): New declaration.
6305         (get_last_target_status, set_last_target_status): New
6306         process_stratum_target parameter.
6307         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6308         process_stratum_target parameter, and use it.
6309         (clear_inline_frame_state (thread_info*)): New.
6310         * inline-frame.c (clear_inline_frame_state(ptid_t)): Add
6311         process_stratum_target parameter.
6312         (clear_inline_frame_state (thread_info*)): Declare.
6313         * linux-fork.c (delete_checkpoint_command): Pass target down to
6314         find_thread_ptid.
6315         (checkpoint_command): Adjust.
6316         * linux-nat.c (linux_nat_target::follow_fork): Switch to thread
6317         instead of just tweaking inferior_ptid.
6318         (linux_nat_switch_fork): Pass target down to thread_change_ptid.
6319         (exit_lwp): Pass target down to find_thread_ptid.
6320         (attach_proc_task_lwp_callback): Pass target down to
6321         add_thread/set_running/set_executing.
6322         (linux_nat_target::attach): Pass target down to
6323         thread_change_ptid.
6324         (get_detach_signal): Pass target down to find_thread_ptid.
6325         Consider last target status's target.
6326         (linux_resume_one_lwp_throw, resume_lwp)
6327         (linux_handle_syscall_trap, linux_handle_extended_wait, wait_lwp)
6328         (stop_wait_callback, save_stop_reason, linux_nat_filter_event)
6329         (linux_nat_wait_1, resume_stopped_resumed_lwps): Pass target down.
6330         (linux_nat_target::async_wait_fd): New.
6331         (linux_nat_stop_lwp, linux_nat_target::thread_address_space): Pass
6332         target down.
6333         * linux-nat.h (linux_nat_target::async_wait_fd): Declare.
6334         * linux-tdep.c (get_thread_arch_regcache): Pass target down.
6335         * linux-thread-db.c (struct thread_db_info::process_target): New
6336         field.
6337         (add_thread_db_info): Save target.
6338         (get_thread_db_info): New process_stratum_target parameter.  Also
6339         match target.
6340         (delete_thread_db_info): New process_stratum_target parameter.
6341         Also match target.
6342         (thread_from_lwp): Adjust to pass down target.
6343         (thread_db_notice_clone): Pass down target.
6344         (check_thread_db_callback): Pass down target.
6345         (try_thread_db_load_1): Always push the thread_db target.
6346         (try_thread_db_load, record_thread): Pass target down.
6347         (thread_db_target::detach): Pass target down.  Always unpush the
6348         thread_db target.
6349         (thread_db_target::wait, thread_db_target::mourn_inferior): Pass
6350         target down.  Always unpush the thread_db target.
6351         (find_new_threads_callback, thread_db_find_new_threads_2)
6352         (thread_db_target::update_thread_list): Pass target down.
6353         (thread_db_target::pid_to_str): Pass current inferior down.
6354         (thread_db_target::get_thread_local_address): Pass target down.
6355         (thread_db_target::resume, maintenance_check_libthread_db): Pass
6356         target down.
6357         * nto-procfs.c (nto_procfs_target::update_thread_list): Adjust.
6358         * procfs.c (procfs_target::procfs_init_inferior): Declare.
6359         (proc_set_current_signal, do_attach, procfs_target::wait): Adjust.
6360         (procfs_init_inferior): Rename to ...
6361         (procfs_target::procfs_init_inferior): ... this and adjust.
6362         (procfs_target::create_inferior, procfs_notice_thread)
6363         (procfs_do_thread_registers): Adjust.
6364         * ppc-fbsd-tdep.c: Include "inferior.h".
6365         (ppcfbsd_get_thread_local_address): Pass down target.
6366         * proc-service.c (ps_xfer_memory): Switch current inferior and
6367         program space as well.
6368         (get_ps_regcache): Pass target down.
6369         * process-stratum-target.c
6370         (process_stratum_target::thread_address_space)
6371         (process_stratum_target::thread_architecture): Pass target down.
6372         * process-stratum-target.h
6373         (process_stratum_target::threads_executing): New field.
6374         (as_process_stratum_target): New.
6375         * ravenscar-thread.c
6376         (ravenscar_thread_target::update_inferior_ptid): Pass target down.
6377         (ravenscar_thread_target::wait, ravenscar_add_thread): Pass target
6378         down.
6379         * record-btrace.c (record_btrace_target::info_record): Adjust.
6380         (record_btrace_target::record_method)
6381         (record_btrace_target::record_is_replaying)
6382         (record_btrace_target::fetch_registers)
6383         (get_thread_current_frame_id, record_btrace_target::resume)
6384         (record_btrace_target::wait, record_btrace_target::stop): Pass
6385         target down.
6386         * record-full.c (record_full_wait_1): Switch to event thread.
6387         Pass target down.
6388         * regcache.c (regcache::regcache)
6389         (get_thread_arch_aspace_regcache, get_thread_arch_regcache): Add
6390         process_stratum_target parameter and handle it.
6391         (current_thread_target): New global.
6392         (get_thread_regcache): Add process_stratum_target parameter and
6393         handle it.  Switch inferior before calling target method.
6394         (get_thread_regcache): Pass target down.
6395         (get_thread_regcache_for_ptid): Pass target down.
6396         (registers_changed_ptid): Add process_stratum_target parameter and
6397         handle it.
6398         (registers_changed_thread, registers_changed): Pass target down.
6399         (test_get_thread_arch_aspace_regcache): New.
6400         (current_regcache_test): Define a couple local test_target_ops
6401         instances and use them for testing.
6402         (readwrite_regcache): Pass process_stratum_target parameter.
6403         (cooked_read_test, cooked_write_test): Pass mock_target down.
6404         * regcache.h (get_thread_regcache, get_thread_arch_regcache)
6405         (get_thread_arch_aspace_regcache): Add process_stratum_target
6406         parameter.
6407         (regcache::target): New method.
6408         (regcache::regcache, regcache::get_thread_arch_aspace_regcache)
6409         (regcache::registers_changed_ptid): Add process_stratum_target
6410         parameter.
6411         (regcache::m_target): New field.
6412         (registers_changed_ptid): Add process_stratum_target parameter.
6413         * remote.c (remote_state::supports_vCont_probed): New field.
6414         (remote_target::async_wait_fd): New method.
6415         (remote_unpush_and_throw): Add remote_target parameter.
6416         (get_current_remote_target): Adjust.
6417         (remote_target::remote_add_inferior): Push target.
6418         (remote_target::remote_add_thread)
6419         (remote_target::remote_notice_new_inferior)
6420         (get_remote_thread_info): Pass target down.
6421         (remote_target::update_thread_list): Skip threads of inferiors
6422         bound to other targets.  (remote_target::close): Don't discard
6423         inferiors.  (remote_target::add_current_inferior_and_thread)
6424         (remote_target::process_initial_stop_replies)
6425         (remote_target::start_remote)
6426         (remote_target::remote_serial_quit_handler): Pass down target.
6427         (remote_target::remote_unpush_target): New remote_target
6428         parameter.  Unpush the target from all inferiors.
6429         (remote_target::remote_unpush_and_throw): New remote_target
6430         parameter.  Pass it down.
6431         (remote_target::open_1): Check whether the current inferior has
6432         execution instead of checking whether any inferior is live.  Pass
6433         target down.
6434         (remote_target::remote_detach_1): Pass down target.  Use
6435         remote_unpush_target.
6436         (extended_remote_target::attach): Pass down target.
6437         (remote_target::remote_vcont_probe): Set supports_vCont_probed.
6438         (remote_target::append_resumption): Pass down target.
6439         (remote_target::append_pending_thread_resumptions)
6440         (remote_target::remote_resume_with_hc, remote_target::resume)
6441         (remote_target::commit_resume): Pass down target.
6442         (remote_target::remote_stop_ns): Check supports_vCont_probed.
6443         (remote_target::interrupt_query)
6444         (remote_target::remove_new_fork_children)
6445         (remote_target::check_pending_events_prevent_wildcard_vcont)
6446         (remote_target::remote_parse_stop_reply)
6447         (remote_target::process_stop_reply): Pass down target.
6448         (first_remote_resumed_thread): New remote_target parameter.  Pass
6449         it down.
6450         (remote_target::wait_as): Pass down target.
6451         (unpush_and_perror): New remote_target parameter.  Pass it down.
6452         (remote_target::readchar, remote_target::remote_serial_write)
6453         (remote_target::getpkt_or_notif_sane_1)
6454         (remote_target::kill_new_fork_children, remote_target::kill): Pass
6455         down target.
6456         (remote_target::mourn_inferior): Pass down target.  Use
6457         remote_unpush_target.
6458         (remote_target::core_of_thread)
6459         (remote_target::remote_btrace_maybe_reopen): Pass down target.
6460         (remote_target::pid_to_exec_file)
6461         (remote_target::thread_handle_to_thread_info): Pass down target.
6462         (remote_target::async_wait_fd): New.
6463         * riscv-fbsd-tdep.c: Include "inferior.h".
6464         (riscv_fbsd_get_thread_local_address): Pass down target.
6465         * sol2-tdep.c (sol2_core_pid_to_str): Pass down target.
6466         * sol-thread.c (sol_thread_target::wait, ps_lgetregs, ps_lsetregs)
6467         (ps_lgetfpregs, ps_lsetfpregs, sol_update_thread_list_callback):
6468         Adjust.
6469         * solib-spu.c (spu_skip_standalone_loader): Pass down target.
6470         * solib-svr4.c (enable_break): Pass down target.
6471         * spu-multiarch.c (parse_spufs_run): Pass down target.
6472         * spu-tdep.c (spu2ppu_sniffer): Pass down target.
6473         * target-delegates.c: Regenerate.
6474         * target.c (g_target_stack): Delete.
6475         (current_top_target): Return the current inferior's top target.
6476         (target_has_execution_1): Refer to the passed-in inferior's top
6477         target.
6478         (target_supports_terminal_ours): Check whether the initial
6479         inferior was already created.
6480         (decref_target): New.
6481         (target_stack::push): Incref/decref the target.
6482         (push_target, push_target, unpush_target): Adjust.
6483         (target_stack::unpush): Defref target.
6484         (target_is_pushed): Return bool.  Adjust to refer to the current
6485         inferior's target stack.
6486         (dispose_inferior): Delete, and inline parts ...
6487         (target_preopen): ... here.  Only dispose of the current inferior.
6488         (target_detach): Hold strong target reference while detaching.
6489         Pass target down.
6490         (target_thread_name): Add assertion.
6491         (target_resume): Pass down target.
6492         (target_ops::beneath, find_target_at): Adjust to refer to the
6493         current inferior's target stack.
6494         (get_dummy_target): New.
6495         (target_pass_ctrlc): Pass the Ctrl-C to the first inferior that
6496         has a thread running.
6497         (initialize_targets): Rename to ...
6498         (_initialize_target): ... this.
6499         * target.h: Include "gdbsupport/refcounted-object.h".
6500         (struct target_ops): Inherit refcounted_object.
6501         (target_ops::shortname, target_ops::longname): Make const.
6502         (target_ops::async_wait_fd): New method.
6503         (decref_target): Declare.
6504         (struct target_ops_ref_policy): New.
6505         (target_ops_ref): New typedef.
6506         (get_dummy_target): Declare function.
6507         (target_is_pushed): Return bool.
6508         * thread-iter.c (all_matching_threads_iterator::m_inf_matches)
6509         (all_matching_threads_iterator::all_matching_threads_iterator):
6510         Handle filter target.
6511         * thread-iter.h (struct all_matching_threads_iterator, struct
6512         all_matching_threads_range, class all_non_exited_threads_range):
6513         Filter by target too.  Remove explicit.
6514         * thread.c (threads_executing): Delete.
6515         (inferior_thread): Pass down current inferior.
6516         (clear_thread_inferior_resources): Pass down thread pointer
6517         instead of ptid_t.
6518         (add_thread_silent, add_thread_with_info, add_thread): Add
6519         process_stratum_target parameter.  Use it for thread and inferior
6520         searches.
6521         (is_current_thread): New.
6522         (thread_info::deletable): Use it.
6523         (find_thread_ptid, thread_count, in_thread_list)
6524         (thread_change_ptid, set_resumed, set_running): New
6525         process_stratum_target parameter.  Pass it down.
6526         (set_executing): New process_stratum_target parameter.  Pass it
6527         down.  Adjust reference to 'threads_executing'.
6528         (threads_are_executing): New process_stratum_target parameter.
6529         Adjust reference to 'threads_executing'.
6530         (set_stop_requested, finish_thread_state): New
6531         process_stratum_target parameter.  Pass it down.
6532         (switch_to_thread): Also match inferior.
6533         (switch_to_thread): New process_stratum_target parameter.  Pass it
6534         down.
6535         (update_threads_executing): Reimplement.
6536         * top.c (quit_force): Pop targets from all inferior.
6537         (gdb_init): Don't call initialize_targets.
6538         * windows-nat.c (windows_nat_target) <get_windows_debug_event>:
6539         Declare.
6540         (windows_add_thread, windows_delete_thread): Adjust.
6541         (get_windows_debug_event): Rename to ...
6542         (windows_nat_target::get_windows_debug_event): ... this.  Adjust.
6543         * tracefile-tfile.c (tfile_target_open): Pass down target.
6544         * gdbsupport/common-gdbthread.h (struct process_stratum_target):
6545         Forward declare.
6546         (switch_to_thread): Add process_stratum_target parameter.
6547         * mi/mi-interp.c (mi_on_resume_1): Add process_stratum_target
6548         parameter.  Use it.
6549         (mi_on_resume): Pass target down.
6550         * nat/fork-inferior.c (startup_inferior): Add
6551         process_stratum_target parameter.  Pass it down.
6552         * nat/fork-inferior.h (startup_inferior): Add
6553         process_stratum_target parameter.
6554         * python/py-threadevent.c (py_get_event_thread): Pass target down.
6555
6556 2020-01-10  Pedro Alves  <palves@redhat.com>
6557
6558         * remote.c (remote_target::start_remote): Don't set inferior_ptid
6559         directly.  Instead find the first thread in the thread list and
6560         use switch_to_thread.
6561
6562 2020-01-10  Pedro Alves  <palves@redhat.com>
6563
6564         * remote.c (remote_target::remote_add_inferior): Don't bind a
6565         process to the current inferior if the current inferior is already
6566         bound to a process.
6567
6568 2020-01-10  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
6569             Pedro Alves  <palves@redhat.com>
6570
6571         * remote.c (remote_target::remote_parse_stop_reply) <W/X packets>:
6572         If no process is specified, return null_ptid instead of
6573         inferior_ptid.
6574         (remote_target::wait_as): Handle TARGET_WAITKIND_EXITED /
6575         TARGET_WAITKIND_SIGNALLED with no pid.
6576
6577 2020-01-10  Pedro Alves  <palves@redhat.com>
6578
6579         * remote.c (first_remote_resumed_thread): New.
6580         (remote_target::wait_as): Use it as default event_ptid instead of
6581         inferior_ptid.
6582
6583 2020-01-10  Pedro Alves  <palves@redhat.com>
6584
6585         * infrun.c (handle_no_resumed): Use all_non_exited_inferiors.
6586
6587 2020-01-10  Pedro Alves  <palves@redhat.com>
6588
6589         * tracefile-tfile.c (tfile_target::close): Assert that trace_fd is
6590         not -1.
6591
6592 2020-01-10  Pedro Alves  <palves@redhat.com>
6593
6594         * break-catch-sig.c (signal_catchpoint_print_it): Don't pass a
6595         ptid to get_last_target_status.
6596         * break-catch-syscall.c (print_it_catch_syscall): Don't pass a
6597         ptid to get_last_target_status.
6598         * infcmd.c (continue_command): Don't pass a target_waitstatus to
6599         get_last_target_status.
6600         (info_program_command): Don't pass a target_waitstatus to
6601         get_last_target_status.
6602         * infrun.c (init_wait_for_inferior): Use
6603         nullify_last_target_wait_ptid.
6604         (get_last_target_status): Handle nullptr arguments.
6605         (nullify_last_target_wait_ptid): Clear target_last_waitstatus.
6606         (print_stop_event): Don't pass a ptid to get_last_target_status.
6607         (normal_stop): Don't pass a ptid to get_last_target_status.
6608         * infrun.h (get_last_target_status, set_last_target_status): Move
6609         comments here and update.
6610         (nullify_last_target_wait_ptid): Declare.
6611         * linux-fork.c (fork_load_infrun_state): Remove local extern
6612         declaration of nullify_last_target_wait_ptid.
6613         * linux-nat.c (get_detach_signal): Don't pass a target_waitstatus
6614         to get_last_target_status.
6615
6616 2020-01-10  Pedro Alves  <palves@redhat.com>
6617
6618         * gdbthread.h (scoped_restore_current_thread)
6619         <dont_restore, restore, m_dont_restore>: Declare.
6620         * thread.c (thread_alive): Add assertion.  Return bool.
6621         (switch_to_thread_if_alive): New.
6622         (prune_threads): Switch inferior/thread.
6623         (print_thread_info_1): Switch thread before calling target methods.
6624         (scoped_restore_current_thread::restore): New, factored out from
6625         ...
6626         (scoped_restore_current_thread::~scoped_restore_current_thread):
6627         ... this.
6628         (scoped_restore_current_thread::scoped_restore_current_thread):
6629         Add assertion.
6630         (thread_apply_all_command, thread_select): Use
6631         switch_to_thread_if_alive.
6632         * infrun.c (proceed, restart_threads, handle_signal_stop)
6633         (switch_back_to_stepped_thread): Switch current thread before
6634         calling target methods.
6635
6636 2020-01-10  Pedro Alves <palves@redhat.com>
6637
6638         * inferior.c (switch_to_inferior_no_thread): New function,
6639         factored out from ...
6640         (inferior_command): ... here.
6641         * inferior.h (switch_to_inferior_no_thread): Declare.
6642         * mi/mi-main.c (run_one_inferior): Use
6643         switch_to_inferior_no_thread.
6644
6645 2020-01-10  Pedro Alves  <palves@redhat.com>
6646
6647         * infcmd.c (kill_command): Remove dead code.
6648
6649 2020-01-10  Pedro Alves  <palves@redhat.com>
6650
6651         * remote.c (remote_target::mourn_inferior): No longer check
6652         whether the target is running.
6653
6654 2020-01-10  Pedro Alves  <palves@redhat.com>
6655
6656         * corelow.c (core_target::has_execution): Change parameter type to
6657         inferior pointer.
6658         * inferior.c (number_of_live_inferiors): Use
6659         inferior::has_execution instead of target_has_execution_1.
6660         * inferior.h (inferior::has_execution): New.
6661         * linux-thread-db.c (thread_db_target::update_thread_list): Use
6662         inferior::has_execution instead of target_has_execution_1.
6663         * process-stratum-target.c
6664         (process_stratum_target::has_execution): Change parameter type to
6665         inferior pointer.  Check the inferior's PID instead of
6666         inferior_ptid.
6667         * process-stratum-target.h
6668         (process_stratum_target::has_execution): Change parameter type to
6669         inferior pointer.
6670         * record-full.c (record_full_core_target::has_execution): Change
6671         parameter type to inferior pointer.
6672         * target.c (target_has_execution_1): Change parameter type to
6673         inferior pointer.
6674         (target_has_execution_current): Adjust.
6675         * target.h (target_ops::has_execution): Change parameter type to
6676         inferior pointer.
6677         (target_has_execution_1): Change parameter type to inferior
6678         pointer.  Change return type to bool.
6679         * tracefile.h (tracefile_target::has_execution): Change parameter
6680         type to inferior pointer.
6681
6682 2020-01-10  Pedro Alves  <palves@redhat.com>
6683
6684         * exceptions.c (print_flush): Remove current_top_target() check.
6685
6686 2020-01-10  Pedro Alves  <palves@redhat.com>
6687
6688         * remote.c (show_remote_exec_file): Show the current inferior's
6689         exec-file instead of the command variable's value.
6690
6691 2020-01-10  Pedro Alves  <palves@redhat.com>
6692
6693         * record-full.c (record_full_resume_ptid): New global.
6694         (record_full_target::resume): Set it.
6695         (record_full_wait_1): Use record_full_resume_ptid instead of
6696         inferior_ptid.
6697
6698 2020-01-10  Pedro Alves  <palves@redhat.com>
6699
6700         * gdbthread.h (scoped_restore_current_thread)
6701         <dont_restore, restore, m_dont_restore>: Declare.
6702         * thread.c (thread_alive): Add assertion.  Return bool.
6703         (switch_to_thread_if_alive): New.
6704         (prune_threads): Switch inferior/thread.
6705         (print_thread_info_1): Switch thread before calling target methods.
6706         (scoped_restore_current_thread::restore): New, factored out from
6707         ...
6708         (scoped_restore_current_thread::~scoped_restore_current_thread):
6709         ... this.
6710         (scoped_restore_current_thread::scoped_restore_current_thread):
6711         Add assertion.
6712         (thread_apply_all_command, thread_select): Use
6713         switch_to_thread_if_alive.
6714
6715 2020-01-10  George Barrett  <bob@bob131.so>
6716
6717         * stap-probe.c (stap_modify_semaphore): Don't check for null
6718         semaphores.
6719         (stap_probe::set_semaphore, stap_probe::clear_semaphore): Check
6720         for null semaphores.
6721
6722 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6723
6724         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Update
6725         all source windows, and maintain horizontal scroll status while
6726         doing so.
6727
6728 2020-01-09  Tom Tromey  <tom@tromey.com>
6729
6730         PR tui/18932:
6731         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Call
6732         update_source_window, not print_source_lines.
6733
6734 2020-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
6735
6736         * tui/tui.c (tui_enable): Register tui hooks after calling
6737         tui_display_main.
6738
6739 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6740
6741         * gdbsupport/common-defs.h: Don't define _FORTIFY_SOURCE on MinGW.
6742
6743 2020-01-08  Simon Marchi  <simon.marchi@efficios.com>
6744
6745         * thread.c (print_thread_info_1): Fix indentation.
6746
6747 2020-01-09  Christian Biesinger  <cbiesinger@google.com>
6748
6749         * symtab.c (general_symbol_info::compute_and_set_names): Move the
6750         unique_xmalloc_ptr outside the if to always free the demangled name.
6751
6752 2020-01-08  Tom Tromey  <tromey@adacore.com>
6753
6754         * xcoffread.c (enter_line_range, read_xcoff_symtab)
6755         (process_xcoff_symbol, xcoff_symfile_offsets): Update.
6756         * symtab.h (MSYMBOL_VALUE_ADDRESS): Update.
6757         (struct section_offsets, ANOFFSET, SIZEOF_N_SECTION_OFFSETS):
6758         Remove.
6759         (section_offsets): New typedef.
6760         * symtab.c (fixup_section, get_msymbol_address): Update.
6761         * symmisc.c (dump_msymbols): Update.
6762         * symfile.h (relative_addr_info_to_section_offsets)
6763         (symfile_map_offsets_to_segments): Update.
6764         * symfile.c (build_section_addr_info_from_objfile)
6765         (init_objfile_sect_indices): Update.
6766         (struct place_section_arg): Change type of "offsets".
6767         (place_section): Update.
6768         (relative_addr_info_to_section_offsets): Change type of
6769         "section_offsets".  Remove "num_sections" parameter.
6770         (default_symfile_offsets, syms_from_objfile_1)
6771         (set_objfile_default_section_offset): Update.
6772         (reread_symbols): No need to preserve section offsets by hand.
6773         (symfile_map_offsets_to_segments): Change type of "offsets".
6774         * stap-probe.c (relocate_address): Update.
6775         * stabsread.h (process_one_symbol): Update.
6776         * solib-target.c (struct lm_info_target) <offsets>: Change type.
6777         (solib_target_relocate_section_addresses): Update.
6778         * solib-svr4.c (enable_break, svr4_relocate_main_executable):
6779         Update.
6780         * solib-frv.c (frv_relocate_main_executable): Update.
6781         * solib-dsbt.c (dsbt_relocate_main_executable): Update.
6782         * solib-aix.c (solib_aix_get_section_offsets): Change return
6783         type.
6784         (solib_aix_solib_create_inferior_hook): Update.
6785         * remote.c (remote_target::get_offsets): Update.
6786         * psymtab.c (find_pc_sect_psymtab): Update.
6787         * psympriv.h (struct partial_symbol) <address, text_low,
6788         text_high>: Update.
6789         * objfiles.h (obj_section_offset): Update.
6790         (struct objfile) <section_offsets>: Change type.
6791         <num_sections>: Remove.
6792         (objfile_relocate): Update.
6793         * objfiles.c (entry_point_address_query): Update
6794         (relocate_one_symbol): Change type of "section_offsets".
6795         (objfile_relocate1, objfile_relocate1): Change type of
6796         "new_offsets".
6797         (objfile_rebase1): Update.
6798         * mipsread.c (mipscoff_symfile_read): Update.
6799         (read_alphacoff_dynamic_symtab): Remove "section_offsets"
6800         parameter.
6801         * mdebugread.c (parse_symbol): Change type of "section_offsets".
6802         (parse_external, psymtab_to_symtab_1): Update.
6803         * machoread.c (macho_symfile_offsets): Update.
6804         * ia64-tdep.c (ia64_find_unwind_table): Update.
6805         * hppa-tdep.c (read_unwind_info): Update.
6806         * hppa-bsd-tdep.c (hppabsd_find_global_pointer): Update.
6807         * dwarf2read.c (create_addrmap_from_index)
6808         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
6809         (process_psymtab_comp_unit_reader, add_partial_symbol)
6810         (add_partial_subprogram, process_full_comp_unit)
6811         (read_file_scope, read_func_scope, read_lexical_block_scope)
6812         (read_call_site_scope, dwarf2_rnglists_process)
6813         (dwarf2_ranges_process, dwarf2_ranges_read)
6814         (dwarf_decode_lines_1, var_decode_location, new_symbol)
6815         (dwarf2_fetch_die_loc_sect_off, dwarf2_per_cu_text_offset):
6816         Update.
6817         * dwarf2-frame.c (execute_cfa_program, dwarf2_frame_find_fde):
6818         Update.
6819         * dtrace-probe.c (dtrace_probe::get_relocated_address): Update.
6820         * dbxread.c (read_dbx_symtab, read_ofile_symtab): Update.
6821         (process_one_symbol): Change type of "section_offsets".
6822         * ctfread.c (get_objfile_text_range): Update.
6823         * coffread.c (coff_symtab_read, enter_linenos)
6824         (process_coff_symbol): Update.
6825         * coff-pe-read.c (add_pe_forwarded_sym): Update.
6826         * amd64-windows-tdep.c (amd64_windows_find_unwind_info): Update.
6827
6828 2020-01-08  Tom Tromey  <tromey@adacore.com>
6829
6830         * dwarf2read.c (parse_macro_definition): Use std::string.
6831         (parse_macro_definition): Likewise.
6832
6833 2020-01-08  Tom Tromey  <tromey@adacore.com>
6834
6835         * dwarf2read.c (abbrev_table_read_table): Use std::vector.
6836         (ATTR_ALLOC_CHUNK): Remove.
6837
6838 2020-01-08  Tom Tromey  <tromey@adacore.com>
6839
6840         * dwarf2read.c (fixup_go_packaging): Use unique_xmalloc_ptr.
6841
6842 2020-01-08  Tom Tromey  <tromey@adacore.com>
6843
6844         * dwarf2read.c (add_partial_symbol): Use unique_xmalloc_ptr.
6845         (dwarf2_compute_name, open_dwo_file): Likewise.
6846         (process_enumeration_scope): Use std::vector.
6847         (guess_partial_die_structure_name): Use unique_xmalloc_ptr.
6848         (partial_die_info::fixup, dwarf2_start_subfile)
6849         (guess_full_die_structure_name, dwarf2_name): Likewise.
6850         (determine_prefix): Update.
6851         (guess_full_die_structure_name): Make return type const.
6852         (partial_die_full_name): Return unique_xmalloc_ptr.
6853         (DW_FIELD_ALLOC_CHUNK): Remove.
6854
6855 2020-01-07  Tom Tromey  <tromey@adacore.com>
6856
6857         PR build/24937:
6858         * stap-probe.c (class stap_static_probe_ops): Add constructor.
6859
6860 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6861
6862         * cli/cli-style.c: Set cli_styling to 'true' in the Cygwin build.
6863
6864 2020-01-06  Andrew Burgess  <andrew.burgess@embecosm.com>
6865
6866         * stack.c (print_frame_info): Move disassemble_next_line code
6867         inside source_print block.
6868
6869 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6870
6871         * gdbsupport/gdb_wait.c: Include <signal.h> instead of
6872         gdb/signals.h, as we are now using native signal symbols.
6873
6874 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6875
6876         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): Avoid
6877         overflow by an early check of content vs threshold.
6878         * tui/tui-source.c (tui_source_window::line_is_displayed):
6879         Likewise.
6880
6881 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6882
6883         * NEWS: Mention the recent fix of $_exitsignal on MS-Windows.
6884
6885 2020-01-02  Jon Turney  <jon.turney@dronecode.org.uk>
6886
6887         * coff-pe-read.c (read_pe_exported_syms): Don't try to read the
6888         export table if no section contains it's RVA.
6889
6890 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6891
6892         * windows-tdep.c: Fix a typo in WINDOWS_SIGABRT.
6893
6894 2020-01-06  Hannes Domani  <ssbssa@yahoo.de>
6895
6896         * source.c (print_source_lines_base): Set last_line_listed.
6897
6898 2020-01-06  Shahab Vahedi  <shahab@synopsys.com>
6899
6900         * tui/tui-disasm.c: Remove trailing spaces.
6901
6902 2020-01-06  Eli Zaretskii  <eliz@gnu.org>
6903             Pedro Alves  <palves@redhat.com>
6904
6905         * Makefile.in (COMMON_SFILES): Add gdbsupport/gdb_wait.c.
6906         * windows-tdep.c: New enumeration of WINDOWS_SIG* signals.
6907         (windows_gdb_signal_to_target): New function, uses the above
6908         enumeration to convert GDB internal signal codes to equivalent
6909         Windows codes.
6910         (windows_init_abi): Call set_gdbarch_gdb_signal_to_target.
6911         * windows-nat.c: Include "gdb_wait.h".
6912         (get_windows_debug_event): Extract the fatal exception from the
6913         exit status and convert to the equivalent Posix signal number.
6914         * cli/cli-cmds.c (exit_status_set_internal_vars): Account for the
6915         possibility that WTERMSIG returns GDB_SIGNAL_UNKNOWN.
6916         * gdbsupport/gdb_wait.c: New file, implements
6917         windows_status_to_termsig.
6918         * gdbsupport/gdb_wait.h (WIFEXITED, WIFSIGNALED, WEXITSTATUS)
6919         (WTERMSIG) [__MINGW32__]: Separate definitions for MinGW.
6920
6921 2020-01-05  Andrew Burgess  <andrew.burgess@embecosm.com>
6922
6923         * tui/tui-layout.c (tui_add_win_to_layout): Use tui_set_layout not
6924         show_layout.
6925
6926 2020-01-05  Luis Machado  <luis.machado@linaro.org>
6927
6928         * aarch64-linux-nat.c
6929         (aarch64_linux_nat_target::thread_architecture): Use bfd_arch_aarch64
6930         and bfd_mach_aarch64.
6931
6932 2020-01-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6933
6934         * ui-file.c (stdio_file::can_emit_style_escape)
6935         (tee_file::can_emit_style_escape): Ensure style is used also on
6936         gdb_stderr when gdb_stderr is a tty supporting styling, similarly
6937         to gdb_stdout.
6938         * main.c (set_gdb_data_directory): Use file style to output the
6939         warning that the given pathname is not a directory.
6940         * top.c (show_history_filename, gdb_safe_append_history)
6941         (show_gdb_datadir): Use file style.
6942
6943 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6944
6945         * solib-target.c (struct lm_info_target):
6946         Change offsets to be a unique_xmalloc_ptr.
6947         (solib_target_relocate_section_addresses): Update.
6948
6949 2020-01-03  Hannes Domani  <ssbssa@yahoo.de>
6950
6951         * windows-nat.c (windows_clear_solib): Free so_list linked list.
6952
6953 2020-01-03  Bernd Edlinger  <bernd.edlinger@hotmail.de>
6954
6955         * MAINTAINERS (Write After Approval): Add myself.
6956
6957 2020-01-02  Luis Machado  <luis.machado@linaro.org>
6958
6959         * proc-service.c (get_ps_regcache): Remove reference to obsolete
6960         Cell BE architecture.
6961         * target.h (struct target_ops) <thread_architecture>: Likewise.
6962
6963 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6964
6965         * Makefile.in: Use INSTALL_PROGRAM_ENV.
6966
6967 2020-01-01  Hannes Domani  <ssbssa@yahoo.de>
6968
6969         * MAINTAINERS (Write After Approval): Add myself.
6970
6971 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6972
6973         * gdbarch.sh: Update copyright year range of generated files.
6974
6975 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6976
6977         Update copyright year range in all GDB files.
6978
6979 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6980
6981         * copyright.py: Convert to Python 3.
6982
6983 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6984
6985         * copyright.py: Adapt after move of gnulib directory from gdb
6986         directory to toplevel directory.
6987
6988 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6989
6990         * copyright.py (main): Exit if run from the wrong directory.
6991
6992 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6993
6994         * top.c (print_gdb_version): Change copyright year to 2020.
6995
6996 2020-01-01  Joel Brobecker  <brobecker@adacore.com>
6997
6998         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2019.
6999
7000 For older changes see ChangeLog-2019.
7001 \f
7002 Local Variables:
7003 mode: change-log
7004 left-margin: 8
7005 fill-column: 74
7006 version-control: never
7007 coding: utf-8
7008 End: