gdb/ChangeLog

   1 2019-12-20  Tom Tromey  <tom@tromey.com>
   2
   3         * tui/tui-stack.h (tui_show_frame_info): Return bool.
   4         * tui/tui-stack.c (tui_show_frame_info): Return bool.
   5         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
   6         Update.
   7
   8 2019-12-20  Tom Tromey  <tom@tromey.com>
   9
  10         PR tui/18932:
  11         * tui/tui-hooks.c (tui_refresh_frame_and_register_information):
  12         Rename parameters.  Handle the not-from-stack-frame case.
  13         (from_stack, from_source_symtab): New globals.
  14         (tui_before_prompt, tui_normal_stop): Update.
  15         (tui_context_changed, tui_symtab_changed): New functions.
  16         (tui_attach_detach_observers): Attach new observers.
  17
  18 2019-12-20  Tom Tromey  <tom@tromey.com>
  19
  20         * source.c (struct current_source_location) <set, symtab, line>:
  21         New methods.
  22         <m_symtab, m_line>: Rename.  Now private.
  23         (get_current_source_symtab_and_line)
  24         (set_default_source_symtab_and_line)
  25         (set_current_source_symtab_and_line)
  26         (clear_current_source_symtab_and_line, select_source_symtab)
  27         (info_source_command, print_source_lines_base)
  28         (info_line_command, search_command_helper): Update.
  29         * observable.h (current_source_symtab_and_line_changed): Declare
  30         observable.
  31         * observable.c (current_source_symtab_and_line_changed): Define
  32         observable.
  33
  34 2019-12-20  Tom Tromey  <tom@tromey.com>
  35
  36         * tui/tui-hooks.c (tui_before_prompt): Change parameter to bool.
  37         (tui_before_prompt, tui_normal_stop): Update.
  38
  39 2019-12-20  Tom Tromey  <tom@tromey.com>
  40
  41         * tui/tui-winsource.c
  42         (tui_source_window_base::update_source_window_as_is): Don't call
  43         set_current_source_symtab_and_line.
  44
  45 2019-12-20  Tom Tromey  <tom@tromey.com>
  46
  47         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info>:
  48         Take a symtab_and_line.
  49         * tui/tui-stack.c (tui_locator_window::set_locator_info): Take a
  50         symtab_and_line.
  51         (tui_show_frame_info): Update.
  52
  53 2019-12-20  Tom Tromey  <tom@tromey.com>
  54
  55         * tui/tui-stack.c (tui_show_frame_info): Don't call
  56         update_exec_info.
  57
  58 2019-12-20  Tom Tromey  <tom@tromey.com>
  59
  60         * tui/tui.c (tui_enable): Call tui_display_main.
  61
  62 2019-12-20  Tom Tromey  <tom@tromey.com>
  63
  64         * tui/tui-disasm.c (tui_get_begin_asm_address): Use
  65         get_current_source_symtab_and_line, and main_name.
  66
  67 2019-12-20  Tom Tromey  <tom@tromey.com>
  68
  69         * tui/tui.c (tui_show_source): Update.
  70         * tui/tui-winsource.h (tui_update_source_windows_with_line): Update.
  71         * tui/tui-winsource.c (tui_update_source_windows_with_line): Take
  72         a symtab_symbol_info, not a separate symtab and line.  Simplify.
  73
  74 2019-12-20  Tom Tromey  <tom@tromey.com>
  75
  76         * tui/tui-winsource.c (tui_update_source_windows_with_addr):
  77         Simplify.
  78
  79 2019-12-20  Tom Tromey  <tom@tromey.com>
  80
  81         * tui/tui-winsource.h (struct tui_source_window_base)
  82         <set_contents, update_source_window_as_is, update_source_window>:
  83         Take a sal, not a separate symtab and tui_line_or_address.
  84         * tui/tui-winsource.c (tui_source_window_base::update_source_window)
  85         (tui_source_window_base::update_source_window_as_is): Take a sal,
  86         not a separate symtab and tui_line_or_address.
  87         (tui_update_source_windows_with_addr)
  88         (tui_update_source_windows_with_line)
  89         (tui_source_window_base::rerender)
  90         (tui_source_window_base::refill): Update.
  91         * tui/tui-source.h (struct tui_source_window) <set_contents>: Take
  92         a sal, not a separate symtab and tui_line_or_address.
  93         * tui/tui-source.c (tui_source_window::set_contents): Take a sal,
  94         not a separate symtab and tui_line_or_address.
  95         (tui_source_window::maybe_update): Update.
  96         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>: Take
  97         a sal, not a separate symtab and tui_line_or_address.
  98         * tui/tui-disasm.c (tui_disasm_window::set_contents): Take a sal,
  99         not a separate symtab and tui_line_or_address.
 100         (tui_disasm_window::do_scroll_vertical)
 101         (tui_disasm_window::maybe_update): Update.
 102
 103 2019-12-20  Tom Tromey  <tom@tromey.com>
 104
 105         * tui/tui-winsource.c (tui_source_window_base::refill): Use
 106         start_line_or_addr.
 107         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Use
 108         start_line_or_addr.
 109         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
 110         start_line_or_addr.
 111
 112 2019-12-20  Tom Tromey  <tom@tromey.com>
 113
 114         * tui/tui-winsource.h (struct tui_source_window_base)
 115         <set_contents>: Return bool.
 116         * tui/tui-winsource.c
 117         (tui_source_window_base::update_source_window_as_is): Update.
 118         * tui/tui-source.h (struct tui_source_window) <set_contents>:
 119         Return bool.
 120         * tui/tui-source.c (tui_source_window::set_contents): Return
 121         bool.  Simplify.
 122         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
 123         Return bool.
 124         * tui/tui-disasm.c (tui_disasm_window::set_contents): Return
 125         bool.
 126
 127 2019-12-20  Tom Tromey  <tom@tromey.com>
 128
 129         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
 130         (tui_update_source_windows_with_line): Call update_source_window.
 131         * tui/tui-source.h (struct tui_source_window)
 132         <show_symtab_source>: Don't declare.
 133         * tui/tui-source.c (tui_source_window::show_symtab_source):
 134         Remove.
 135
 136 2019-12-20  Tom Tromey  <tom@tromey.com>
 137
 138         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 139         update_source_window directly.
 140         * tui/tui-disasm.h (tui_show_disassem): Don't declare.
 141         * tui/tui-disasm.c (tui_show_disassem): Remove.
 142
 143 2019-12-20  Tom Tromey  <tom@tromey.com>
 144
 145         * tui/tui-winsource.c
 146         (tui_source_window_base::update_source_window_as_is): Don't switch focus.
 147         * tui/tui-disasm.c (tui_show_disassem): Don't switch focus.
 148
 149 2019-12-20  Tom Tromey  <tom@tromey.com>
 150
 151         * tui/tui-winsource.h (struct tui_source_window_base)
 152         <maybe_update>: Remove line_no and addr parameters.
 153         * tui/tui-stack.c (tui_show_frame_info): Set PC on sal.  Update.
 154         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
 155         Update.
 156         * tui/tui-source.c (tui_source_window::maybe_update): Remove
 157         line_no and addr parameters.
 158         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
 159         Update.
 160         * tui/tui-disasm.c (tui_disasm_window::maybe_update): Remove
 161         line_no and addr parameters.
 162
 163 2019-12-20  Tom Tromey  <tom@tromey.com>
 164
 165         * tui/tui-winsource.c (tui_source_window_base::set_is_exec_point_at)
 166         (tui_source_window_base::update_breakpoint_info): Remove asserts.
 167
 168 2019-12-20  Tom Tromey  <tom@tromey.com>
 169
 170         * tui/tui-winsource.c (tui_update_source_windows_with_addr): Call
 171         tui_show_disassem.
 172         * tui/tui-disasm.h (tui_show_disassem_and_update_source): Don't
 173         declare.
 174         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Remove.
 175
 176 2019-12-20  Tom Tromey  <tom@tromey.com>
 177
 178         * tui/tui.h (tui_show_source): Remove parameters.
 179         * tui/tui.c (tui_show_source): Remove parameters.
 180         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
 181
 182 2019-12-20  Tom Tromey  <tom@tromey.com>
 183
 184         * tui/tui.c (tui_show_source): Update.
 185         * tui/tui-winsource.c (tui_display_main): Update.
 186         * tui/tui-stack.h (tui_update_locator_fullname): Change parameter
 187         to symtab.
 188         * tui/tui-stack.c (tui_update_locator_fullname): Change parameter
 189         to symtab.
 190         * tui/tui-disasm.c (tui_show_disassem_and_update_source): Update.
 191
 192 2019-12-20  Tom Tromey  <tom@tromey.com>
 193
 194         PR tui/23619:
 195         * tui/tui-io.c (tui_rl_saved_prompt): Remove.
 196         (tui_redisplay_readline): Use rl_display_prompt.
 197         (tui_prep_terminal): Update.
 198
 199 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 200
 201         * configure: Regenerate.
 202         * configure.ac: Quote variable arguments of test.
 203         * gdbsupport/common.m4: Likewise.
 204
 205 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 206
 207         * score-tdep.c (score7_analyze_prologue): Pass 2.0 instead of
 208         2 to pow ().
 209
 210 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 211
 212         * tui/tui-source.c (tui_source_window::set_contents): Cast argument of
 213         log10 to double to fix Solaris 11 with gcc 5.5.
 214
 215 2019-12-19  Christian Biesinger  <cbiesinger@google.com>
 216
 217         * fbsd-tdep.c (fbsd_info_proc_files_entry): Rename local var
 218         "sun" to "saddr_un".
 219
 220 2019-12-19  Tom Tromey  <tromey@adacore.com>
 221
 222         * ui-out.h (enum class field_kind): Fix comment.
 223
 224 2019-12-11  Tom Tromey  <tromey@adacore.com>
 225
 226         * xml-support.c (xml_fetch_content_from_file): Use FOPEN_RB.
 227
 228 2019-12-18  Tom Tromey  <tromey@adacore.com>
 229
 230         PR build/25268:
 231         * gdbsupport/thread-pool.c (set_thread_name): Expect "int" return
 232         type on macOS.  Add comment.
 233
 234 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 235
 236         * c-lang.c (c_get_string, asm_language_defn): Remove space
 237         before tab.
 238
 239 2019-12-18  Tom Tromey  <tromey@adacore.com>
 240
 241         PR build/25250:
 242         * ui-out.c (ui_out::vmessage): Update.
 243         * ui-out.h (enum class field_kind) <FIELD_STRING, FIELD_SIGNED>:
 244         Rename.
 245         (string_field): Update.
 246         (signed_field): Update.
 247
 248 2019-12-18  Simon Marchi  <simon.marchi@efficios.com>
 249
 250         * top.c (print_gdb_configuration): Adjust indentation.
 251
 252 2019-12-17  Christian Biesinger  <cbiesinger@google.com>
 253
 254         * bsd-kvm.c: Include gdbsupport/pathstuff.h.
 255
 256 2019-12-17  Simon Marchi  <simon.marchi@polymtl.ca>
 257
 258         * tui/tui-layout.h (class tui_layout_base): Add virtual
 259         destructor.
 260
 261 2019-12-16  Bernd Edlinger  <bernd.edlinger@hotmail.de>
 262
 263         * infcmd.c (prepare_one_step): Step over skipped inline functions.
 264         * infrun.c (inline_frame_is_marked_for_skip): New helper function.
 265         (process_event_stop_test): Keep stepping over skipped inline functions.
 266
 267 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 268
 269         * jit.c (struct gdb_block) <next>: Remove field.
 270         (struct gdb_symtab) <~gdb_symtab>: Remove.
 271         <blocks>: Change type to std::forward_list<gdb_block>.
 272         (compare_block): Remove.
 273         (jit_block_open_impl): Adjust to std::forward_list.  Place the new
 274         block at the beginning, don't mind about sorting.
 275         (finalize_symtab): Adjust to std::forward_list, sort the blocks list
 276         before using it.
 277
 278 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 279
 280         * jit.c (struct gdb_block): Add constructor, initialize
 281         real_block and next fields.
 282         <name>: Change type to gdb::unique_xmalloc_ptr.
 283         (struct gdb_symtab) <~gdb_symtab>: Free blocks with delete.
 284         (jit_block_open_impl): Allocate gdb_block with new.
 285         (finalize_symtab): Adjust to gdb::unique_xmalloc_ptr.
 286
 287 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 288
 289         * jit.c: Include forward_list.
 290         (struct gdb_symtab) <next>: Remove field.
 291         (struct gdb_object) <symtabs>: Change type to
 292         std::forward_list<gdb_symtab>.
 293         (jit_object_open_impl): Allocate gdb_object with new.
 294         (jit_symtab_open_impl): Adjust to std::forward_list.
 295         (finalize_symtab): Don't delete symtab.
 296         (jit_object_close_impl):  Adjust to std::forward_list.  Free
 297         gdb_object with delete.
 298
 299 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 300
 301         * jit.c (struct gdb_symtab): Add constructor, destructor,
 302         initialize fields.
 303         <linetable>: Change type to unique_xmalloc_ptr.
 304         <file_name>: Change type to std::string.
 305         (jit_symtab_open_impl): Allocate gdb_symtab with new.
 306         (jit_symtab_line_mapping_add_impl): Adjust.
 307         (finalize_symtab): Adjust, call delete on stab.
 308
 309 2019-12-16  Simon Marchi  <simon.marchi@polymtl.ca>
 310
 311         * jit.c (finalize_symtab): Set gdb_block_iter_tmp in loop.
 312
 313 2019-12-16  Tom Tromey  <tromey@adacore.com>
 314
 315         * windows-nat.c (windows_nat_target::attach): Update.
 316         * remote.c (extended_remote_target::attach): Update.
 317         * procfs.c (procfs_target::attach): Update.
 318         * nto-procfs.c (nto_procfs_target::attach): Update.
 319         (nto_procfs_target::create_inferior): Update.
 320         * inf-ptrace.c (inf_ptrace_target::attach): Update.
 321         * gnu-nat.c (gnu_nat_target::attach): Update.
 322         (gnu_nat_target::detach): Update.
 323         * darwin-nat.c (darwin_nat_target::attach): Update.
 324         * corefile.c (get_exec_file): Constify result.  Remove extraneous
 325         return.
 326         * bsd-kvm.c (bsd_kvm_target_open): Update.
 327         * gdbsupport/common-inferior.h (get_exec_file): Constify result.
 328
 329 2019-12-16  Christian Biesinger  <cbiesinger@google.com>
 330
 331         * gdbsupport/common-defs.h: Remove workaround for a gnulib bug
 332         (we no longer need to include time.h before pathmax.h)
 333
 334 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 335
 336         * ada-exp.y (write_ambiguous_var): Update.
 337         * coffread.c (process_coff_symbol): Update.
 338         * ctfread.c (ctf_add_enum_member_cb): Update.
 339         (new_symbol): Update.
 340         * dwarf2read.c (fixup_go_packaging): Update.
 341         (new_symbol): Update.
 342         * language.c (language_alloc_type_symbol): Update.
 343         * mdebugread.c (new_symbol): Update.
 344         * minsyms.c (minimal_symbol_reader::record_full): Update.
 345         * psymtab.c (add_psymbol_to_bcache): Update.
 346         * stabsread.c (define_symbol): Update.
 347         (read_enum_type): Update.
 348         * symtab.c (symbol_set_language): Make this a member function...
 349         (general_symbol_info::set_language): ... here.
 350         * symtab.h (struct general_symbol_info) <set_language>: New function.
 351         (SYMBOL_SET_LANGUAGE): Remove.
 352         (symbol_set_language): Remove.
 353
 354 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 355
 356         * ada-lang.c (ada_add_block_symbols): Update.
 357         (ada_collect_symbol_completion_matches): Update.
 358         * ax-gdb.c (gen_expr): Update.
 359         * block.c (block_lookup_symbol): Update.
 360         (block_lookup_symbol_primary): Update.
 361         (block_find_symbol): Update.
 362         * cp-namespace.c (cp_lookup_symbol_imports_or_template): Update.
 363         * dbxread.c (process_one_symbol): Update.
 364         * dictionary.c (insert_symbol_hashed): Update.
 365         (collate_pending_symbols_by_language): Update.
 366         (mdict_add_symbol): Update.
 367         * dwarf-index-write.c (write_psymbols): Update.
 368         * dwarf2read.c (fixup_go_packaging): Update.
 369         * findvar.c (read_var_value): Update.
 370         * ft32-tdep.c (ft32_skip_prologue): Update.
 371         * go-lang.c (go_symbol_package_name): Update.
 372         * language.h (scoped_switch_to_sym_language_if_auto::
 373         scoped_switch_to_sym_language_if_auto): Update.
 374         * linespec.c (find_method): Update.
 375         (find_label_symbols_in_block): Update.
 376         * mdebugread.c (parse_symbol): Update.
 377         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
 378         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
 379         (minimal_symbol_reader::install): Update.
 380         * moxie-tdep.c (moxie_skip_prologue): Update.
 381         * parse.c (parse_exp_in_context): Update.
 382         * psymtab.c (psymbol_name_matches): Update.
 383         (match_partial_symbol): Update.
 384         (lookup_partial_symbol): Update.
 385         (psymbol_hash): Update.
 386         (psymbol_compare): Update.
 387         * python/py-framefilter.c (extract_sym): Update.
 388         (py_print_single_arg): Update.
 389         * stabsread.c (define_symbol): Update.
 390         * stack.c (print_frame_arg): Update.
 391         (find_frame_funname): Update.
 392         (info_frame_command_core): Update.
 393         * symfile.c (set_initial_language): Update.
 394         * symtab.c (symbol_set_demangled_name): Update.
 395         (symbol_get_demangled_name): Update.
 396         (symbol_set_language): Update.
 397         (symbol_find_demangled_name): Update.
 398         (symbol_set_names): Update.
 399         (general_symbol_info::natural_name): Update.
 400         (general_symbol_info::demangled_name): Update.
 401         (general_symbol_info::search_name): Update.
 402         (symbol_matches_search_name): Update.
 403         (eq_symbol_entry): Update.
 404         (iterate_over_symbols): Update.
 405         (completion_list_add_symbol): Update.
 406         (completion_list_add_msymbol): Update.
 407         (completion_list_add_fields): Update.
 408         * symtab.h (struct general_symbol_info) <language>: New function.
 409         <language>: Rename to...
 410         <m_language>: ...this.
 411         (SYMBOL_LANGUAGE): Remove.
 412         (MSYMBOL_LANGUAGE): Remove.
 413         (struct symbol) <ctor>: Update.
 414         * xstormy16-tdep.c (xstormy16_skip_prologue): Update.
 415
 416 2019-12-15  Christian Biesinger  <cbiesinger@google.com>
 417
 418         * ada-exp.y (write_ambiguous_var): Call symbol_set_language to
 419         set the language of sym.
 420         * language.c (language_alloc_type_symbol): Likewise.
 421
 422 2019-12-14  Sergio Durigan Junior  <sergiodj@redhat.com>
 423
 424         https://bugzilla.redhat.com/show_bug.cgi?id=1728147
 425         PR gdb/23613
 426         * bsd-kvm.c (bsd_kvm_target_open): Use 'gdb_abspath'.
 427         * corelow.c: Include 'gdbsupport/pathstuff.h'.
 428         (core_target_open): Use 'gdb_abspath'.
 429         * gdbsupport/pathstuff.c (gdb_abspath): Guard against
 430         'current_directory == NULL' case.
 431         * gdbsupport/pathstuff.h (gdb_abspath): Expand comment and
 432         explain what happens when 'current_directory' is NULL.
 433         * go32-nat.c (go32_nat_target::wait): Check if
 434         'current_directory' is NULL before call to 'chdir'.
 435         * source.c (add_path): Use 'gdb_abspath'.
 436         * top.c: Include 'gdbsupport/pathstuff.h'.
 437         (init_history): Use 'gdb_abspath'.
 438         (set_history_filename): Likewise.
 439         * tracefile-tfile.c: Include 'gdbsupport/pathstuff.h'.
 440         (tfile_target_open): Use 'gdb_abspath'.
 441
 442 2019-12-13  Tom Tromey  <tromey@adacore.com>
 443
 444         * contrib/ari/gdb_ari.sh: Remove check for multiple calls to
 445         warning or error.
 446
 447 2019-12-13  Tom Tromey  <tromey@adacore.com>
 448
 449         * contrib/ari/gdb_ari.sh: Remove call to "fix" for "long long".
 450
 451 2019-12-13  Tom Tromey  <tromey@adacore.com>
 452
 453         * contrib/ari/gdb_ari.sh: Handle -Wno- prefix.
 454
 455 2019-12-13  Tom Tromey  <tromey@adacore.com>
 456
 457         * contrib/ari/gdb_ari.sh (usage): Use GNU style.
 458
 459 2019-12-13  Tom Tromey  <tromey@adacore.com>
 460
 461         * gdbsupport/common-utils.c (string_printf, string_vprintf)
 462         (string_vappendf): Add ARI comment.
 463
 464 2019-12-13  Tom Tromey  <tromey@adacore.com>
 465
 466         * contrib/ari/gdb_ari.sh: Remove "fix" call for
 467         floatformat_to_double.
 468         * target-float.c (host_float_ops<T>::from_target): Add ARI
 469         comment.
 470
 471 2019-12-13  Tom Tromey  <tromey@adacore.com>
 472
 473         * contrib/ari/gdb_ari.sh: Remove "fix" call for abort.
 474         * utils.c (abort_with_message, dump_core, internal_vproblem): Add
 475         ARI marker to abort.
 476         * event-top.c (handle_sigsegv): Add ARI marker to abort.
 477
 478 2019-12-13  Tom Tromey  <tromey@adacore.com>
 479
 480         * contrib/ari/gdb_ari.sh: Fix floatformat_from_double text.
 481
 482 2019-12-13  Tom Tromey  <tromey@adacore.com>
 483
 484         * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check.
 485
 486 2019-12-13  Tom Tromey  <tromey@adacore.com>
 487
 488         * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean"
 489         checks.
 490
 491 2019-12-13  Tom Tromey  <tromey@adacore.com>
 492
 493         * gdbsupport/safe-iterator.h (class basic_safe_range) <begin,
 494         end>: No longer "const".
 495
 496 2019-12-13  Simon Marchi  <simon.marchi@polymtl.ca>
 497
 498         * jit.c: Fix indentation, replace spaces with tabs where
 499         applicable.
 500
 501 2019-12-13  Jozef Lawrynowicz  <jozef.l@mittosystems.com>
 502
 503         * configure.tgt: Match msp430-*-elf* targets when configuring GDB.
 504
 505 2019-12-12  Tom Tromey  <tom@tromey.com>
 506
 507         * objfiles.h (struct objfile) <partial_symtabs>: Now a
 508         unique_ptr.
 509
 510 2019-12-12  Tom Tromey  <tom@tromey.com>
 511
 512         * progspace.h (objfile_list): New typedef.
 513         (class unwrapping_objfile_iterator)
 514         (struct unwrapping_objfile_range): Newl
 515         (struct program_space) <objfiles_range>: Change type.
 516         <objfiles>: Change return type.
 517         <add_objfile>: Change type of "objfile" parameter.
 518         <objfiles_list>: Now a list of shared_ptr.
 519         * progspace.c (program_space::add_objfile): Change type of
 520         "objfile".  Update.
 521         (program_space::remove_objfile): Update.
 522         * objfiles.h (struct objfile) <~objfile>: Make public.
 523         * objfiles.c (objfile::make): Update.
 524         (objfile::unlink): Don't call delete.
 525
 526 2019-12-12  Tom Tromey  <tom@tromey.com>
 527
 528         * symfile.c (symbol_file_clear): Update.
 529         * progspace.h (struct program_space) <free_all_objfiles>: Declare
 530         method.
 531         * progspace.c (program_space::free_all_objfiles): New method.
 532         * objfiles.h (free_all_objfiles): Don't declare.
 533         * objfiles.c (free_all_objfiles): Move to program_space.
 534
 535 2019-12-12  Tom Tromey  <tom@tromey.com>
 536
 537         * progspace.c (program_space::add_objfile)
 538         (program_space::remove_objfile): Update.
 539         (program_space::multi_objfile_p): Remove.
 540         * objfiles.h (struct objfile) <next>: Remove.
 541         * objfiles.c (objfile::objfile): Update.
 542         (put_objfile_before): Update.
 543         (unlink_objfile): Update.
 544         * progspace.h (object_files): Remove.
 545         (struct program_space) <objfiles_head>: Remove.
 546         <objfiles_list>: New member.
 547         <objfiles_range, objfiles_safe_range>: Change type.
 548         (objfiles): Change return type.
 549         (objfiles_safe): Update.
 550         (multi_objfile_p): Rewrite and inline.
 551         (object_files): Remove macro.
 552
 553 2019-12-12  Tom Tromey  <tom@tromey.com>
 554
 555         * gdbsupport/safe-iterator.h (basic_safe_iterator): Simplify.  Add
 556         second constructor.
 557         (basic_safe_range): New class.
 558
 559 2019-12-12  Tom Tromey  <tom@tromey.com>
 560
 561         * progspace.c (program_space::multi_objfile_p): New method.
 562         * printcmd.c (info_symbol_command): Update.
 563         * maint.c (maintenance_translate_address): Update.
 564         * objfiles.h (MULTI_OBJFILE_P): Remove.
 565         * progspace.h (struct program_space) <multi_objfile_p>: New
 566         method.
 567
 568 2019-12-12  Tom Tromey  <tom@tromey.com>
 569
 570         * progspace.h (struct program_space) <remove_objfile>: Declare.
 571         * progspace.c (program_space::remove_objfile): New method.
 572         * objfiles.c (unlink_objfile): Remove.
 573         (objfile::unlink): Call remove_objfile.
 574         (objfile): Don't call unlink_objfile.
 575
 576 2019-12-12  Tom Tromey  <tom@tromey.com>
 577
 578         * progspace.h (struct program_space) <add_objfile>: Declare
 579         method.
 580         * progspace.c (program_space::add_objfile): New method.
 581         * objfiles.c (~objfile): Don't unlink objfile.
 582         (put_objfile_before): Remove.
 583         (add_separate_debug_objfile): Don't call put_objfile_before.
 584         (objfile::make): Call add_objfile.  Set new_objfiles_available on
 585         the per-program-space data.
 586
 587 2019-12-12  Tom Tromey  <tom@tromey.com>
 588
 589         * symfile.c (syms_from_objfile_1): Use objfile_up.
 590         (syms_from_objfile_1, remove_symbol_file_command): Call unlink
 591         method.
 592         (reread_symbols): Use objfile_up.
 593         * solib.c (update_solib_list, reload_shared_libraries_1): Call
 594         unlink method.
 595         * objfiles.h (struct objfile) <~objfile>: Now private.
 596         <unlink>: New method.
 597         (struct objfile_deleter): New.
 598         (objfile_up): New typedef.
 599         * objfiles.c (objfile::unlink): New method.
 600         (free_objfile_separate_debug, free_all_objfiles)
 601         (objfile_purge_solibs): Use it.
 602         * jit.c (jit_unregister_code): Remove.
 603         (jit_inferior_exit_hook, jit_event_handler): Call unlink on
 604         objfile.
 605         * compile/compile-object-run.c (do_module_cleanup): Call unlink on
 606         objfile.
 607         * compile/compile-object-load.c (compile_object_load): Use
 608         objfile_up.
 609
 610 2019-12-12  Tom Tromey  <tom@tromey.com>
 611
 612         * symfile.c (symbol_file_add_with_addrs): Pass "parent" to
 613         objfile::make.
 614         * objfiles.h (struct objjfile) <make>: No longer inline.
 615         (add_separate_debug_objfile): Don't declare.
 616         * objfiles.c (add_separate_debug_objfile): Now static.
 617         (objfile::make): Move from objfiles.h.  Call
 618         add_separate_debug_objfile.  Add "parent" parameter.
 619
 620 2019-12-12  Tom Tromey  <tom@tromey.com>
 621
 622         * symfile.c (symbol_file_add_with_addrs): Use objfile::make.
 623         * objfiles.h (struct objfile): Make constructor private.
 624         <make>: New static method.
 625         * jit.c (jit_object_close_impl): Update.
 626
 627 2019-12-12  Simon Marchi  <simon.marchi@polymtl.ca>
 628
 629         * jit.c (jit_reader_try_read_symtab): Replace xmalloc/xfree with
 630         gdb::byte_vector.
 631
 632 2019-12-12  Tom Tromey  <tromey@adacore.com>
 633
 634         * xml-support.c (xml_fetch_content_from_file): Don't call
 635         malloc_failure.
 636         * utils.h (class gdb_argv): Remove malloc_failure comment.
 637         * utils.c (gdb_argv::reset): Don't call malloc_failure.
 638
 639 2019-12-12  Tom Tromey  <tromey@adacore.com>
 640
 641         * Makefile.in (ALL_TARGET_OBS): Add riscv-ravenscar-thread.o.
 642         (HFILES_NO_SRCDIR): Add riscv-ravenscar-thread.h.
 643         (ALLDEPFILES): Add riscv-ravenscar-thread.c.
 644         * configure.tgt (riscv-*-*): Add riscv-ravenscar-thread.o.
 645         * riscv-ravenscar-thread.c: New file.
 646         * riscv-ravenscar-thread.h: New file.
 647         * riscv-tdep.c (riscv_gdbarch_init): Call
 648         register_riscv_ravenscar_ops.
 649
 650 2019-12-12  Tom Tromey  <tromey@adacore.com>
 651
 652         * gdbsupport/thread-pool.c (set_thread_name): Use
 653         ATTRIBUTE_UNUSED.
 654
 655 2019-12-12  Luis Machado  <luis.machado@linaro.org>
 656
 657         * gdbsupport/safe-strerror.c: Don't include diagnostics.h.
 658         (select_strerror_r): Use ATTRIBUTE_UNUSED instead of the diagnostics
 659         macros.
 660
 661 2019-12-11  Tom Tromey  <tom@tromey.com>
 662
 663         * tui/tui-win.c (tui_set_win_height_command): Call
 664         tui_adjust_window_height.
 665         (tui_adjust_win_heights, new_height_ok): Remove.
 666         * tui/tui-layout.h (tui_adjust_window_height): Declare.
 667         * tui/tui-layout.c (tui_adjust_window_height): New function.
 668
 669 2019-12-11  Tom Tromey  <tom@tromey.com>
 670
 671         * tui/tui-win.c (tui_resize_all): Remove code, call
 672         tui_apply_current_layout.
 673
 674 2019-12-11  Tom Tromey  <tom@tromey.com>
 675
 676         * tui/tui-layout.h (tui_apply_current_layout): Declare.
 677         * tui/tui-layout.c (standard_layouts, applied_layout): New
 678         globals.
 679         (tui_apply_current_layout): New function.
 680         (show_layout): Set applied_layout.  Call
 681         tui_apply_current_layout.
 682         (show_source_command, show_disasm_command)
 683         (show_source_disasm_command, show_data)
 684         (show_source_or_disasm_and_command): Remove.
 685         (initialize_layouts): New function.
 686         (_initialize_tui_layout): Call initialize_layouts.
 687
 688 2019-12-11  Tom Tromey  <tom@tromey.com>
 689
 690         * tui/tui-layout.h (class tui_layout_base)
 691         (class tui_layout_window, class tui_layout_split): New.
 692         * tui/tui-layout.c (tui_get_window_by_name)
 693         (tui_layout_window::clone, tui_layout_window::apply)
 694         (tui_layout_window::get_sizes, tui_layout_window::add_split)
 695         (tui_layout_split::add_window, tui_layout_split::clone)
 696         (tui_layout_split::get_sizes)
 697         (tui_layout_split::set_weights_from_heights)
 698         (tui_layout_split::adjust_size, tui_layout_split::apply): New
 699         functions.
 700         (tui_layout_split::add_split, tui_layout_split::add_split)
 701         (tui_layout_split::set_weights_from_heights)
 702         (tui_layout_split::set_weights_from_heights): New functions.
 703
 704 2019-12-11  Tom Tromey  <tom@tromey.com>
 705
 706         * tui/tui-wingeneral.c (tui_gen_win_info::make_window): Update.
 707         * tui/tui-win.c (tui_adjust_win_heights, tui_resize_all): Update.
 708         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
 709         * tui/tui-data.h (struct tui_point): Remove.
 710         (struct tui_gen_win_info) <origin>: Remove.
 711         <x, y>: New fields.
 712         * tui/tui-command.c (tui_cmd_window::resize): Update.
 713
 714 2019-12-11  Tom Tromey  <tom@tromey.com>
 715
 716         * tui/tui-stack.h (struct tui_locator_window) <min_height>:
 717         Implement.
 718         * tui/tui-regs.h (struct tui_data_item_window) <min_height>:
 719         Implement.
 720         * tui/tui-data.h (struct tui_gen_win_info) <min_height>: New
 721         method.
 722         (struct tui_win_info) <min_height>: Implement.
 723
 724 2019-12-11  Tom Tromey  <tom@tromey.com>
 725
 726         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
 727         (struct tui_win_info) <can_box>: Update.
 728
 729 2019-12-11  Tom Tromey  <tom@tromey.com>
 730
 731         * tui/tui-stack.h (struct tui_locator_window) <max_height>: New
 732         method.
 733         * tui/tui-regs.h (struct tui_data_item_window) <max_height>: New
 734         method.
 735         * tui/tui-data.h (struct tui_gen_win_info) <max_height>: New
 736         method.
 737         (struct tui_win_info) <max_height>: Now override.
 738
 739 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 740
 741         * NEWS: Create a new section for the next release branch.
 742         Rename the section of the current branch, now that it has
 743         been cut.
 744
 745 2019-12-11  Joel Brobecker  <brobecker@adacore.com>
 746
 747         GDB 9 branch created (27f7b2f64062ac9e52afc60509263c2702a9ebd0):
 748         * version.in: Bump version to 10.0.50.DATE-git.
 749
 750 2019-12-11  Tom Tromey  <tromey@adacore.com>
 751
 752         PR build/25268:
 753         * gdbsupport/thread-pool.c (set_thread_name): New function.
 754         (thread_pool::set_thread_count): Don't call pthread_setname_np.
 755         (thread_pool::thread_function): Call set_thread_name.
 756
 757 2019-12-11  Tom Tromey  <tromey@adacore.com>
 758
 759         * fbsd-tdep.c (fbsd_core_info_proc_status): Cast result of
 760         bfd_get_signed_8.
 761
 762 2019-12-11  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 763
 764         * NEWS: Document -raw-values option and the related setting commands.
 765         * printcmd.c (print_command_parse_format): Do not set opts->raw off,
 766         only set it on when /r is given.
 767         * valprint.c (value_print_option_defs): New element raw-values.
 768         * Makefile.in: Add the new file.
 769
 770 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 771
 772         * gdbsupport/safe-strerror.c: Supress the unused function warning
 773         for select_strerror_r.
 774
 775 2019-12-10  Christian Biesinger  <cbiesinger@google.com>
 776
 777         * config.in: Regenerate.
 778         * configure: Regenerate.
 779         * gdbsupport/agent.c (gdb_connect_sync_socket): Call
 780         safe_strerror instead of strerror.
 781         * gdbsupport/common.m4: Don't check for strerror.
 782         * gdbsupport/safe-strerror.c: Support both the glibc version
 783         of strerror_r and the XSI version.
 784
 785 2019-12-10  Tom Tromey  <tromey@adacore.com>
 786
 787         * ada-typeprint.c (print_choices): Use a single "?".
 788         (print_variant_part): Print "?" if the discriminant name
 789         is not known.
 790
 791 2019-12-10  George Barrett  <bob@bob131.so>
 792
 793         Fix scripted probe breakpoints.
 794         * breakpoint.c (tracepoint_probe_breakpoint_ops): Move
 795         declaration forward.
 796         (breakpoint_ops_for_event_location_type)
 797         (breakpoint_ops_for_event_location): Add function definitions.
 798         (break_command_1, trace_command): Use
 799         breakpoint_ops_for_event_location.
 800         * breakpoint.h (breakpoint_ops_for_event_location): Add function
 801         declarations.
 802         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Use
 803         breakpoint_ops_for_event_location.
 804         * python/py-breakpoint.c (bppy_init): Use
 805         breakpoint_ops_for_event_location.
 806
 807 2019-12-09  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 808
 809         * gdbtypes.c (rank_one_type): Return INCOMPATIBLE_TYPE_BADNESS
 810         when ranking an lvalue argument for an rvalue parameter.
 811
 812 2019-12-08  Wataru Ashihara  <wataash@wataash.com>
 813
 814         * darwin-nat.c (darwin_nat_target::create_inferior): Fix
 815         template argument for scoped_restore_tmpl from bool to int.
 816
 817 2019-12-07  Keith Seitz  <keiths@redhat.com>
 818
 819         * build-id.c (build_id_bfd_get): Permit bfd_core, too.
 820         (build_id_to_debug_bfd): Make static, rewriting to use
 821         build_id_to_bfd_suffix.
 822         (build_id_to_bfd_suffix): Copy of build_id_to_debug_bfd,
 823         adding `suffix' parameter. Append SUFFIX to file names
 824         when searching for matching files.
 825         (build_id_to_debug_bfd): Use build_id_to_bfd_suffix.
 826         (build_id_to_exec_bfd): Likewise.
 827         * build-id.h (build_id_to_debug_bfd): Clarify that function
 828         searches for BFD of debug info file.
 829         (build_id_to_exec_bfd): Declare.
 830         * corelow.c: Include build-id.h.
 831         (locate_exec_from_corefile_build_id): New function.
 832         (core_target_open): If no executable BFD is found,
 833         search for a core file BFD using build-id.
 834
 835 2019-12-06  Christian Biesinger  <cbiesinger@google.com>
 836
 837         * bcache.c: Put in namespace gdb.
 838         * bcache.h: Likewise.
 839         * gdbtypes.c (check_types_worklist): Update.
 840         (types_deeply_equal): Update.
 841         * macrotab.c (struct macro_table) <bcache>: Update.
 842         (new_macro_table): Update.
 843         * macrotab.h (struct bcache): Put this forward declaration
 844         inside namespace gdb.
 845         (new_macro_table): Update.
 846         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache>:
 847         Update.
 848         <macro_cache>: Update.
 849         * psymtab.h: (psymtab_storage) <psymbol_cache>: Update.
 850
 851 2019-12-06  Tom de Vries  <tdevries@suse.de>
 852
 853         PR symtab/24971
 854         * block.c (best_symbol, better_symbol): New function.
 855         (block_lookup_symbol_primary, block_lookup_symbol): Prefer def over
 856         decl.
 857
 858 2019-12-06  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
 859
 860         * gdbtypes.h: Define the REFERENCE_SEE_THROUGH_BADNESS value.
 861         * gdbtypes.c (rank_one_type): Use REFERENCE_SEE_THROUGH_BADNESS
 862         for ranking see-through reference cases.
 863
 864 2019-12-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 865         * stack.c (faas_command): Check a command is provided.
 866         * thread.c (taas_command, tfaas_command): Likewise.
 867
 868 2019-12-05  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
 869         * inferior.c (prune_inferiors):  Only call delete_inferior,
 870         Do not modify the inferior list.
 871
 872 2019-12-05  Simon Marchi  <simon.marchi@polymtl.ca>
 873
 874         * c-exp.y: Update calls to lookup_typename,
 875         lookup_signed_typename and lookup_unsigned_typename.
 876         * c-lang.c (evaluate_subexp_c): Likewise.
 877         * cp-namespace.c (cp_lookup_symbol_imports_or_template):
 878         Likewise.
 879         * eval.c (binop_promote): Likewise.
 880         * gdbtypes.c (lookup_typename): Remove gdbarch parameter.
 881         (lookup_unsigned_typename): Likewise.
 882         (lookup_signed_typename): Likewise.
 883         * gdbtypes.h (lookup_unsigned_typename): Likewise.
 884         (lookup_signed_typename): Likewise.
 885         (lookup_typename): Likewise.
 886         * guile/scm-type.c (tyscm_lookup_typename): Update calls to
 887         lookup_typename, lookup_signed_typename,
 888         lookup_unsigned_typename.
 889         * m2-exp.y: Likewise.
 890         * printcmd.c (printf_wide_c_string): Likewise.
 891         (ui_printf): Likewise.
 892         * python/py-type.c (typy_lookup_typename): Likewise.
 893         * python/py-xmethods.c (python_xmethod_worker::invoke):
 894         Likewise.
 895         * rust-exp.y: Likewise.
 896
 897 2019-12-04  Christian Biesinger  <cbiesinger@google.com>
 898
 899         * configure.nat (obsd64): Add missing files x86-nat.o and
 900         nat/x86-dregs.o.
 901
 902 2019-12-04  Tom Tromey  <tom@tromey.com>
 903
 904         * valprint.c (val_print_string): Use metadata_style.
 905         * go-valprint.c (print_go_string): Use metadata style.
 906         * p-valprint.c (pascal_object_print_static_field): Use metadata
 907         style.
 908         * cp-valprint.c (cp_print_static_field): Use metadata style.
 909
 910 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 911             Chris January  <chris.january@arm.com>
 912
 913         * f-exp.y (COMPLEX_KEYWORD, SINGLE, DOUBLE, PRECISION): New
 914         tokens.
 915         (typebase): New patterns for complex, single/double precision, and
 916         single/double complex.
 917         (f77_keywords): Change token for complex keyword, and add single,
 918         double, and precision keywords.
 919
 920 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 921
 922         * avr-tdep.c (_initialize_avr_tdep): Improve help of command
 923         "info io_registers".
 924
 925 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 926
 927         * regcache.c (cooked_read_test): Initialize thread list of
 928         mock_inferior.
 929
 930 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 931
 932         * aarch64-linux-tdep.c: Remove includes.
 933
 934 2019-12-04  Simon Marchi  <simon.marchi@polymtl.ca>
 935
 936         * aarch64-tdep.c: Remove includes.
 937
 938 2019-12-04  Simon Marchi  <simon.marchi@efficios.com>
 939
 940         * filtered-iterator.h (filtered_iterator) <operator==,
 941         operator!=>: Compare wrapped iterators, not wrapped pointers.
 942         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
 943         unittests/filtered_iterator-selftests.c.
 944         * unittests/filtered_iterator-selftests.c: New file.
 945
 946 2019-12-04  Tom Tromey  <tromey@adacore.com>
 947
 948         * gdbtypes.c (create_range_type): Inherit endianity
 949         from base type.
 950
 951 2019-12-04  Tom Tromey  <tromey@adacore.com>
 952
 953         * ada-lang.c (decode_constrained_packed_array)
 954         (ada_value_assign, value_assign_to_component): Update.
 955         * dwarf2loc.c (rw_pieced_value, access_memory)
 956         (dwarf2_compile_expr_to_ax): Update.
 957         * dwarf2read.c (dwarf2_add_field): Update.
 958         * eval.c (evaluate_subexp_standard): Update.
 959         * gdbarch.c, gdbarch.h: Rebuild.
 960         * gdbarch.sh (bits_big_endian): Remove.
 961         * gdbtypes.h (union field_location): Update comment.
 962         * target-descriptions.c (make_gdb_type): Update.
 963         * valarith.c (value_bit_index): Update.
 964         * value.c (struct value) <bitpos>: Update comment.
 965         (unpack_bits_as_long, modify_field): Update.
 966         * value.h (value_bitpos): Update comment.
 967
 968 2019-12-04  Tom Tromey  <tromey@adacore.com>
 969
 970         * gdbtypes.c (type_byte_order): Move earlier.  Assert for unknown
 971         endian-ness.
 972
 973 2019-12-04  Tom Tromey  <tromey@adacore.com>
 974
 975         * dwarf2read.c (dwarf2_init_float_type)
 976         (dwarf2_init_complex_target_type): Add byte_order parameter.
 977         (read_base_type): Compute byte order earlier.
 978         * gdbtypes.c (init_float_type): Add byte_order parameter.
 979         * gdbtypes.h (init_float_type): Add byte_order parameter.
 980
 981 2019-12-04  Tom Tromey  <tromey@adacore.com>
 982
 983         * unittests/tui-selftests.c: Conditionally include tui-winsource.h.
 984
 985 2019-12-04  Tom Tromey  <tromey@adacore.com>
 986
 987         * dwarf2read.c (process_structure_scope): Initialize
 988         "discr_offset".
 989
 990 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
 991
 992         * mi/mi-symbol-cmds.c (mi_symbol_info): Take extra parameter, and
 993         add it into the search spec.
 994         (parse_max_results_option): New function.
 995         (mi_info_functions_or_variables): Parse -max-results flag and pass
 996         it to mi_symbol_info.
 997         (mi_cmd_symbol_info_modules): Likewise.
 998         (mi_cmd_symbol_info_types): Likewise.
 999         * symtab.c (global_symbol_searcher::add_matching_symbols): Change
1000         return type to bool, change result container into a set, and don't
1001         add new results if we have enough already.
1002         (global_symbol_searcher::add_matching_msymbols): Change return
1003         type to bool, and don't add new results if we have enough already.
1004         (sort_search_symbols_remove_dups): Delete.
1005         (global_symbol_searcher::search): Early exit from search loop when
1006         we have enough results.  Use a std::set to collect the results
1007         from calling add_matching_symbols.
1008         * symtab.h (global_symbol_searcher) <set_max_seach_results>: New
1009         member function.
1010         (global_symbol_searcher) <m_max_search_results>: New member
1011         variable.
1012         (global_symbol_searcher) <add_matching_symbols>: Update header
1013         comment and change return type to bool.
1014         (global_symbol_searcher) <add_matching_msymbols>: Update header
1015         comment and change return type to bool.
1016
1017 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1018
1019         * symtab.c (symbol_search::compare_search_syms): Update header
1020         comment.
1021         (global_symbol_searcher::is_suitable_msymbol): New function.
1022         (global_symbol_searcher::expand_symtabs): New function.
1023         (global_symbol_searcher::add_matching_symbols): New function.
1024         (global_symbol_searcher::add_matching_msymbols): New function.
1025         (global_symbol_searcher::search): Move most of the content
1026         into the new functions above, and call them as needed.
1027         * symtab.h (global_symbol_searcher) <expand_symtabs>: New member
1028         function.
1029         (global_symbol_searcher) <add_matching_symbols>: New member
1030         function.
1031         (global_symbol_searcher) <add_matching_msymbols>: New member
1032         function.
1033         (global_symbol_searcher) <is_suitable_msymbol>: New member
1034         function.
1035
1036 2019-12-04  Andrew Burgess  <andrew.burgess@embecosm.com>
1037
1038         * mi/mi-cmds.c (mi_cmds): Add -symbol-info-module-functions and
1039         -symbol-info-module-variables entries.
1040         * mi/mi-cmds.h (mi_cmd_symbol_info_module_functions): Declare.
1041         (mi_cmd_symbol_info_module_variables): Declare.
1042         * mi/mi-symbol-cmds.c
1043         (module_symbol_search_iterator): New typedef.
1044         (output_module_symbols_in_single_module_and_file): New function.
1045         (output_module_symbols_in_single_module): New function.
1046         (mi_info_module_functions_or_variables): New function.
1047         (mi_cmd_symbol_info_module_functions): New function.
1048         (mi_cmd_symbol_info_module_variables): New function.
1049         * NEWS: Mention new MI command.
1050
1051 2019-12-03  Christian Biesinger  <cbiesinger@google.com>
1052
1053         * bcache.c (hash): Remove.
1054         (hash_continue): Remove.
1055         * bcache.h (hash): Remove.
1056         (hash_continue): Remove.
1057         (struct bcache) <ctor>: Update.
1058         * psymtab.c (psymbol_hash): Update.
1059         * stabsread.c (hashname): Update.
1060         * utils.h (fast_hash): Add an argument for a start value,
1061         defaulting to zero.
1062
1063 2019-12-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1064         * symtab.c (symbol_cache_clear_slot):  Move close to cleared type.
1065         (destroy_block_symbol_cache): New function.
1066         (symbol_cache:~symbol_cache) Call destroy_block_symbol_cache.
1067         (resize_symbol_cache): Likewise.
1068
1069 2019-12-02  Tom Tromey  <tom@tromey.com>
1070
1071         * unittests/tui-selftests.c (run_tests): Make conditional.
1072         (_initialize_tui_selftest): Make conditional.
1073
1074 2019-12-02  Christian Biesinger  <cbiesinger@google.com>
1075
1076         * aix-thread.c (debug_aix_thread): Change type to bool.
1077
1078 2019-12-02  Luis Machado  <luis.machado@linaro.org>
1079
1080         * infrun.c (follow_fork_inferior): Remove outdated FIXME comment.
1081
1082 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1083
1084         * dwarf2read.c (read_tag_string_type): Read the fields required to
1085         make a dynamic string, and possibly create a dynamic range for the
1086         string.
1087         (attr_to_dynamic_prop): Setup is_reference based on the type of
1088         attribute being processed.
1089         * gdbtypes.c (is_dynamic_type_internal): Handle TYPE_CODE_STRING.
1090         (resolve_dynamic_array): Rename to...
1091         (resolve_dynamic_array_or_string): ...this, update header comment,
1092         and accept TYPE_CODE_STRING.
1093         (resolve_dynamic_type_internal): Handle TYPE_CODE_STRING.
1094
1095 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1096
1097         * dwarf2read.c (dwarf2_per_cu_int_type): New function, takes most
1098         of its implementation from...
1099         (dwarf2_per_cu_addr_sized_int_type): ...here, which now just calls
1100         the new function.
1101
1102 2019-12-01  Andrew Burgess  <andrew.burgess@embecosm.com>
1103
1104         * dwarf2read.c (read_subrange_type): Read bit and byte stride and
1105         create a range with stride where appropriate.
1106         * f-valprint.c: Include 'gdbarch.h'.
1107         (f77_print_array_1): Take the stride into account when walking the
1108         array.  Also convert the stride into addressable units.
1109         * gdbtypes.c (create_range_type): Initialise the stride to
1110         constant zero.
1111         (create_range_type_with_stride): New function, initialise the
1112         range as normal, and then setup the stride.
1113         (has_static_range): Include the stride here.  Also change the
1114         return type to bool.
1115         (create_array_type_with_stride): Consider the range stride if the
1116         array isn't given its own stride.
1117         (resolve_dynamic_range): Resolve the stride if needed.
1118         * gdbtypes.h (struct range_bounds) <stride>: New member variable.
1119         (struct range_bounds) <flag_is_byte_stride>: New member variable.
1120         (TYPE_BIT_STRIDE): Define.
1121         (TYPE_ARRAY_BIT_STRIDE): Define.
1122         (create_range_type_with_stride): Declare.
1123         * valarith.c (value_subscripted_rvalue): Take range stride into
1124         account when walking the array.
1125
1126 2019-12-01  Tom Tromey  <tom@tromey.com>
1127
1128         * tui/tui-win.c (tui_all_windows_info): Treat inactive TUI
1129         specially.
1130
1131 2019-12-01  Tom Tromey  <tom@tromey.com>
1132
1133         * tui/tui-winsource.c (tui_copy_source_line): Don't advance past
1134         \0.
1135         * unittests/tui-selftests.c: New file.
1136         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add tui-selftests.c.
1137
1138 2019-12-01  Tom Tromey  <tom@tromey.com>
1139
1140         * tui/tui.c (tui_enable): Call tui_update_variables earlier.
1141
1142 2019-12-01  Tom Tromey  <tom@tromey.com>
1143
1144         * NEWS: Document new settings.
1145         * tui/tui-wingeneral.c (box_win): Apply appropriate border style.
1146         * tui/tui-win.c (_initialize_tui_win): Add border style
1147         observers.
1148         * tui/tui-io.h (tui_apply_style): Declare.
1149         * tui/tui-io.c (tui_apply_style): Rename from apply_style.  No
1150         longer static.
1151         (apply_ansi_escape, tui_set_reverse_mode): Update.
1152         * cli/cli-style.h (class cli_style_option) <add_setshow_commands>:
1153         Add "skip_intensity" parameter.
1154         <changed>: New member.
1155         <do_set_value>: Declare.
1156         (tui_border_style, tui_active_border_style): Declare.
1157         * cli/cli-style.c (tui_border_style, tui_active_border_style): New
1158         globals.
1159         (cli_style_option): Initialize "changed".
1160         (cli_style_option::do_set_value): New function.
1161         (cli_style_option::add_setshow_commands): Add "skip_intensity"
1162         parameter.  Update.
1163         (STYLE_ADD_SETSHOW_COMMANDS): Add "SKIP" parameter.
1164         (_initialize_cli_style): Update.  Create TUI border style
1165         commands.
1166
1167 2019-12-01  Tom Tromey  <tom@tromey.com>
1168
1169         * tui/tui-winsource.h (tui_copy_source_line): Add "ndigits"
1170         parameter.
1171         * tui/tui-winsource.c (tui_copy_source_line): Add "ndigits"
1172         parameter.
1173         * tui/tui-win.h (compact_source): Declare.
1174         * tui/tui-win.c (compact_source): New global.
1175         (tui_set_compact_source, tui_show_compact_source): New functions.
1176         (_initialize_tui_win): Add "compact-source" setting.
1177         * tui/tui-source.c (tui_source_window::set_contents): Handle
1178         compact_source setting.
1179         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
1180         * NEWS: Document new setting.
1181
1182 2019-11-30  Tom Tromey  <tom@tromey.com>
1183
1184         * dwarf2read.c (dwarf2_add_field): Include field offset when
1185         computing variant part length.
1186
1187 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1188         * NEWS:  Mention define-prefix.  Tell that command names can now
1189         contain a . character.
1190
1191 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1192
1193         * command.h (valid_cmd_char_p): Declare.
1194         * cli/cli-decode.c (valid_cmd_char_p): New function factorizing
1195         the check of valid command char.
1196         (find_command_name_length, valid_user_defined_cmd_name_p): Use
1197         valid_cmd_char_p.
1198         * cli/cli-script.c (validate_comname): Likewise.
1199         * completer.c (gdb_completer_command_word_break_characters):
1200         Do not remove . from the word break char, update comments.
1201         (complete_line_internal_1): Use valid_cmd_char_p.
1202         * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise.
1203         * python/py-cmd.c (gdbpy_parse_command_name): Likewise.
1204
1205 2019-11-30  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1206
1207         * cli/cli-script.c (do_define_command): Ensure a redefined
1208         prefix command is kept as a prefix command.
1209         (define_prefix_command): New function.
1210         (show_user_1): Report user defined prefixes.
1211         (_initialize_cli_script):  Create the new 'define-prefix' command.
1212         Add completers for 'define' and 'document'.
1213         * top.c (execute_command):  If command is a user-defined prefix only
1214         command, report the list of commands for this prefix command.
1215
1216 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1217
1218         * valops.c (find_oload_champ): Improve debug output.
1219
1220 2019-11-29  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
1221
1222         * valops.c (find_oload_champ): Print part of debug messages
1223         before the badness vector is std::move'd.
1224
1225 2019-11-28  Tom Tromey  <tom@tromey.com>
1226
1227         * value.c (creal_internal_fn): Fix comment.
1228
1229 2019-11-28  Tom Tromey  <tom@tromey.com>
1230
1231         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count,
1232         flag_bound_evaluated>: Now unsigned.
1233
1234 2019-11-28  Tom Tromey  <tom@tromey.com>
1235
1236         * guile/guile-internal.h (vlscm_scm_from_value_unsafe): Don't
1237         declare.
1238
1239 2019-11-28  Mihails Strasuns  <mihails.strasuns@intel.com>
1240
1241         * jit.c (jit_bfd_try_read_symtab): Fix printed function name in the
1242         debug output.
1243         * jit.c (jit_unregister_code): Add debug print to match
1244         `jit_register_code`.
1245
1246 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1247
1248         * NEWS: Mention the new multithreaded symbol loading.
1249
1250 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1251
1252         * maint.c (n_worker_threads): Default to 0.
1253         (worker_threads_disabled): New function.
1254         * maint.h (worker_threads_disabled): New function.
1255         * minsyms.c (minimal_symbol_reader::record_full): Call symbol_set_names
1256         here if worker_threads_disabled () is true.
1257         (minimal_symbol_reader::install): Skip all threading if
1258         worker_threads_disabled () is true.
1259
1260 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1261
1262         * minsyms.c (add_minsym_to_hash_table): Use a previously computed
1263         hash code if possible.
1264         (add_minsym_to_demangled_hash_table): Likewise.
1265         (minimal_symbol_reader::install): Compute the hash codes for msymbol
1266         on the background thread.
1267         * symtab.h (struct minimal_symbol) <hash_value, demangled_hash_value>:
1268         Add these fields.
1269
1270 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1271
1272         * minsyms.c (minimal_symbol_reader::install): Also compute the hash
1273         of the mangled name on the background thread.
1274         * symtab.c (symbol_set_names): Allow passing in the hash of the
1275         linkage_name.
1276         * symtab.h (symbol_set_names): Likewise.
1277
1278 2019-11-27  Kevin Buettner  <kevinb@redhat.com>
1279
1280         * dwarf2read.c (inherit_abstract_dies): Ensure that delayed
1281         physnames are computed for inherited DIEs.
1282
1283 2019-11-27  Tom Tromey  <tromey@adacore.com>
1284
1285         * dwarf2read.h (struct dwarf2_per_objfile): Remove unnecessary
1286         backslashes.
1287         * cp-support.c: Remove unnecessary backslashes.
1288
1289 2019-11-27  Christian Biesinger  <cbiesinger@google.com>
1290
1291         * ada-exp.y (write_ambiguous_var): Replace SYMBOL_SET_LINKAGE_NAME
1292         with sym->set_linkage_name.
1293         * coffread.c (coff_read_enum_type): Likewise.
1294         * mdebugread.c (parse_symbol): Likewise.
1295         * stabsread.c (patch_block_stabs): Likewise.
1296         (define_symbol): Likewise.
1297         (read_enum_type): Likewise.
1298         (common_block_end): Likewise.
1299         * symtab.h (struct general_symbol_info) <set_linkage_name>: New
1300         function.
1301         (SYMBOL_SET_LINKAGE_NAME): Remove.
1302         * xcoffread.c (process_xcoff_symbol): Replace SYMBOL_SET_LINKAGE_NAME
1303         with sym->set_linkage_name.
1304
1305 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1306
1307         * mi/mi-cmds.c (mi_cmds): Add 'symbol-info-modules' entry.
1308         * mi/mi-cmds.h (mi_cmd_symbol_info_modules): Declare.
1309         * mi/mi-symbol-cmds.c (mi_cmd_symbol_info_modules): New function.
1310         * NEWS: Mention new MI command.
1311
1312 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1313
1314         * mi/mi-cmds.c (mi_cmds): Add '-symbol-info-functions',
1315         '-symbol-info-types', and '-symbol-info-variables'.
1316         * mi/mi-cmds.h (mi_cmd_symbol_info_functions): Declare.
1317         (mi_cmd_symbol_info_types): Declare.
1318         (mi_cmd_symbol_info_variables): Declare.
1319         * mi/mi-symbol-cmds.c: Add 'source.h' and 'mi-getopt.h' includes.
1320         (output_debug_symbol): New function.
1321         (output_nondebug_symbol): New function.
1322         (mi_symbol_info): New function.
1323         (mi_info_functions_or_variables): New function.
1324         (mi_cmd_symbol_info_functions): New function.
1325         (mi_cmd_symbol_info_types): New function.
1326         (mi_cmd_symbol_info_variables): New function.
1327         * NEWS: Mention new commands.
1328
1329 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1330
1331         * symtab.c (symbol_to_info_string): New function, most content
1332         moved from print_symbol_info, but updated to return a std::string.
1333         (print_symbol_info): Update to use symbol_to_info_string and print
1334         returned string.
1335         * symtab.h (symbol_to_info_string): Declare new function.
1336
1337 2019-11-27  Andrew Burgess  <andrew.burgess@embecosm.com>
1338
1339         * python/python.c (gdbpy_rbreak): Convert to using
1340         global_symbol_searcher.
1341         * symtab.c (file_matches): Convert return type to bool, change
1342         file list to std::vector, update header comment.
1343         (search_symbols): Rename to...
1344         (global_symbol_searcher::search): ...this and update now its
1345         a member function of global_symbol_searcher.  Take account of the
1346         changes to file_matches.
1347         (symtab_symbol_info): Convert to using global_symbol_searcher.
1348         (rbreak_command): Likewise.
1349         (search_module_symbols): Likewise.
1350         * symtab.h (enum symbol_search): Update comment.
1351         (search_symbols): Remove declaration.
1352         (class global_symbol_searcher): New class.
1353
1354 2019-11-26  Tom Tromey  <tromey@adacore.com>
1355
1356         * cp-support.c (_initialize_cp_support): Conditionally initialize
1357         gdb_demangle_attempt_core_dump.
1358
1359 2019-11-26  Tom Tromey  <tom@tromey.com>
1360
1361         * python/py-function.c (fnpy_init): Update.
1362         * value.h (add_internal_function): Adjust declaration.
1363         * value.c (function_destroyer): Remove.
1364         (do_add_internal_function): Don't set destroyer or copy name.
1365         (add_internal_function): Take unique_xmalloc_ptr<char> for name.
1366         Set name_allocated.
1367         * python/py-cmd.c (cmdpy_destroyer): Don't free "name".
1368         (cmdpy_init): Set name_allocated.
1369         * cli/cli-decode.h (struct cmd_list_element) <name_allocated>: New
1370         member.
1371         (~cmd_list_element): Free "name" if needed.
1372
1373 2019-11-26  Tom Tromey  <tom@tromey.com>
1374
1375         * value.h (add_internal_function): Add new overload.  Move
1376         documentation from value.h.
1377         * value.c (do_add_internal_function): New function.
1378         (add_internal_function): Use it.  Add new overload.
1379         (function_destroyer): Don't free doc.
1380         * python/py-function.c (fnpy_init): Update.
1381
1382 2019-11-26  Tom Tromey  <tom@tromey.com>
1383
1384         * python/py-cmd.c (cmdpy_destroyer): Don't free "doc".
1385         (cmdpy_init): Set "doc_allocated".
1386
1387 2019-11-26  Tom Tromey  <tom@tromey.com>
1388
1389         * gdbsupport/thread-pool.c (thread_pool::set_thread_count): Set
1390         name of worker thread.
1391         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1392         pthread_setname_np.
1393         * configure, config.in: Rebuild.
1394
1395 2019-11-26  Tom Tromey  <tom@tromey.com>
1396
1397         * python/python.c (class gdbpy_gil): New.
1398         (struct gdbpy_event): Add constructor, destructor, operator().
1399         (gdbpy_post_event): Use run_on_main_thread.
1400         (gdbpy_initialize_events): Remove.
1401         (do_start_initialization): Update.
1402
1403 2019-11-26  Tom Tromey  <tom@tromey.com>
1404
1405         * NEWS: Add entry.
1406         * maint.c (_initialize_maint_cmds): Add "worker-threads" maint
1407         commands.  Call update_thread_pool_size.
1408         (update_thread_pool_size, maintenance_set_worker_threads): New
1409         functions.
1410         (n_worker_threads): New global.
1411
1412 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1413             Tom Tromey  <tom@tromey.com>
1414
1415         * minsyms.c (minimal_symbol_reader::install): Use
1416         parallel_for_each.
1417         * gdbsupport/parallel-for.h: New file.
1418         * Makefile.in (HFILES_NO_SRCDIR): Add gdbsupport/parallel-for.h.
1419
1420 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1421             Tom Tromey  <tom@tromey.com>
1422
1423         * gdbsupport/thread-pool.h: New file.
1424         * gdbsupport/thread-pool.c: New file.
1425         * Makefile.in (COMMON_SFILES): Add thread-pool.c.
1426         (HFILES_NO_SRCDIR): Add thread-pool.h.
1427
1428 2019-11-26  Tom Tromey  <tom@tromey.com>
1429
1430         * event-top.h (thread_local_segv_handler): Declare.
1431         * event-top.c (thread_local_segv_handler): New global.
1432         (install_handle_sigsegv, handle_sigsegv): New functions.
1433         (async_init_signals): Install SIGSEGV handler.
1434         * cp-support.c (gdb_demangle_jmp_buf): Change type.  Now
1435         thread-local.
1436         (report_failed_demangle): New function.
1437         (gdb_demangle): Make core_dump_allowed atomic.  Remove signal
1438         handler-setting code, instead use segv_handler.  Run warning code
1439         on main thread.
1440
1441 2019-11-26  Tom Tromey  <tom@tromey.com>
1442
1443         * run-on-main-thread.c: New file.
1444         * run-on-main-thread.h: New file.
1445         * unittests/main-thread-selftests.c: New file.
1446         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
1447         main-thread-selftests.c.
1448         (HFILES_NO_SRCDIR): Add run-on-main-thread.h.
1449         (COMMON_SFILES): Add run-on-main-thread.c.
1450
1451 2019-11-26  Tom Tromey  <tom@tromey.com>
1452
1453         * main.c (setup_alternate_signal_stack): Remove.
1454         (captured_main_1): Use gdb::alternate_signal_stack.
1455         * gdbsupport/alt-stack.h: New file.
1456
1457 2019-11-26  Tom Tromey  <tom@tromey.com>
1458
1459         * gdbsupport/signals-state-save-restore.c (original_signal_mask):
1460         Remove comment.
1461         (save_original_signals_state, restore_original_signals_state): Use
1462         gdb_sigmask.
1463         * linux-nat.c (block_child_signals, restore_child_signals_mask)
1464         (_initialize_linux_nat): Use gdb_sigmask.
1465         * guile/guile.c (_initialize_guile): Use block_signals.
1466         * Makefile.in (HFILES_NO_SRCDIR): Add gdb-sigmask.h.
1467         * gdbsupport/gdb-sigmask.h: New file.
1468         * event-top.c (async_sigtstp_handler): Use gdb_sigmask.
1469         * cp-support.c (gdb_demangle): Use gdb_sigmask.
1470         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for
1471         pthread_sigmask.
1472         * configure, config.in: Rebuild.
1473         * gdbsupport/block-signals.h: New file.
1474
1475 2019-11-26  Tom Tromey  <tom@tromey.com>
1476
1477         * acinclude.m4: Include ax_pthread.m4.
1478         * Makefile.in (PTHREAD_CFLAGS, PTHREAD_LIBS): New variables.
1479         (INTERNAL_CFLAGS_BASE): Use PTHREAD_CFLAGS.
1480         (CLIBS): Use PTHREAD_LIBS.
1481         (aclocal_m4_deps): Add ax_pthread.m4.
1482         * config.in, configure: Rebuild.
1483         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for std::thread.
1484
1485 2019-11-26  Tom Tromey  <tom@tromey.com>
1486
1487         * symtab.h (struct minimal_symbol) <name_set>: New member.
1488         * minsyms.c (minimal_symbol_reader::record_full): Copy name.
1489         Don't call symbol_set_names.
1490         (minimal_symbol_reader::install): Call symbol_set_names.
1491
1492 2019-11-26  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
1493
1494         * python/python.c (gdbpy_enter::~gdbpy_enter): Release GIL after
1495         restore_active_ext_lang, as GIL is needed for (indirectly)
1496         called PyOS_InterruptOccurred.
1497
1498 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1499
1500         * sparc-nat.c (sparc_xfer_wcookie): Sync declaration with
1501         definition.
1502
1503 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1504
1505         * remote-sim.c (simulator_command): Make static, remove
1506         declaration.
1507
1508 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1509
1510         * unittests/array-view-selftests.c (check_ptr_size_ctor2): Make
1511         static.
1512         * unittests/basic_string_view/capacity/1.cc (test01): Likewise.
1513         * unittests/basic_string_view/cons/char/1.cc (test01): Likewise.
1514         (main): Likewise.
1515         * unittests/basic_string_view/cons/char/2.cc (test03): Likewise.
1516         (main): Likewise.
1517         * unittests/basic_string_view/cons/char/3.cc (test05): Likewise.
1518         (main): Likewise.
1519         * unittests/basic_string_view/element_access/char/1.cc (test01):
1520         Likewise.
1521         (main): Likewise.
1522         * unittests/basic_string_view/element_access/char/empty.cc (main):
1523         Likewise.
1524         * unittests/basic_string_view/element_access/char/front_back.cc
1525         (test01): Likewise.
1526         (main): Likewise.
1527         * unittests/basic_string_view/inserters/char/2.cc (test05):
1528         Likewise.
1529         (main): Likewise.
1530         * unittests/basic_string_view/modifiers/remove_prefix/char/1.cc
1531         (test01): Likewise.
1532         (main): Likewise.
1533         * unittests/basic_string_view/modifiers/remove_suffix/char/1.cc
1534         (test01): Likewise.
1535         (main): Likewise.
1536         * unittests/basic_string_view/modifiers/swap/char/1.cc (test01):
1537         Likewise.
1538         * unittests/basic_string_view/operations/compare/char/1.cc
1539         (test01): Likewise.
1540         (main): Likewise.
1541         * unittests/basic_string_view/operations/compare/char/13650.cc
1542         (test01): Likewise.
1543         * unittests/basic_string_view/operations/copy/char/1.cc (test01):
1544         Likewise.
1545         (main): Likewise.
1546         * unittests/basic_string_view/operations/data/char/1.cc (test01):
1547         Likewise.
1548         (main): Likewise.
1549         * unittests/basic_string_view/operations/find/char/1.cc (test01):
1550         Likewise.
1551         (main): Likewise.
1552         * unittests/basic_string_view/operations/find/char/2.cc (test02):
1553         Likewise.
1554         (main): Likewise.
1555         * unittests/basic_string_view/operations/find/char/3.cc (test03):
1556         Likewise.
1557         (main): Likewise.
1558         * unittests/basic_string_view/operations/find/char/4.cc (main):
1559         Likewise.
1560         * unittests/basic_string_view/operations/rfind/char/1.cc (test01):
1561         Likewise.
1562         (main): Likewise.
1563         * unittests/basic_string_view/operations/rfind/char/2.cc (test02):
1564         Likewise.
1565         (main): Likewise.
1566         * unittests/basic_string_view/operations/rfind/char/3.cc (test03):
1567         Likewise.
1568         (main): Likewise.
1569         * unittests/basic_string_view/operations/substr/char/1.cc
1570         (test01): Likewise.
1571         (main): Likewise.
1572         * unittests/basic_string_view/operators/char/2.cc (main):
1573         Likewise.
1574         * unittests/optional/assignment/1.cc (test): Likewise.
1575         * unittests/optional/assignment/2.cc (test): Likewise.
1576         * unittests/optional/assignment/3.cc (test): Likewise.
1577         * unittests/optional/assignment/4.cc (test): Likewise.
1578         * unittests/optional/assignment/5.cc (test): Likewise.
1579         * unittests/optional/assignment/6.cc (test): Likewise.
1580         * unittests/optional/assignment/7.cc (test): Likewise.
1581         * unittests/optional/cons/copy.cc (test): Likewise.
1582         * unittests/optional/cons/default.cc (test): Likewise.
1583         * unittests/optional/cons/move.cc (test): Likewise.
1584         * unittests/optional/cons/value.cc (test): Likewise.
1585         * unittests/optional/in_place.cc (test): Likewise.
1586         * unittests/optional/observers/1.cc (test): Likewise.
1587         * unittests/optional/observers/2.cc (test): Likewise.
1588
1589 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1590
1591         * tui-win.h (tui_set_var_cmd): Remove.
1592         * tui-win.c (tui_set_var_cmd): Make static.
1593
1594 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1595
1596         * breakpoint.h (hbreak_command_wrapper, thbreak_command_wrapper,
1597         rbreak_command_wrapper): Remove.
1598         * symtab.c (rbreak_command_wrapper): Remove.
1599
1600 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1601
1602         * inferior.h (info_terminal_command): Remove declaration.
1603         * inflow.c (info_terminal_command): Make static.
1604
1605 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1606
1607         * inferior.c (exit_inferior_silent): Remove.
1608
1609 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1610
1611         * dictionary.c (dict_empty, mdict_empty): Remove.
1612         * dictionary.c (mdict_empty): Remove.
1613
1614 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1615
1616          * arc-tdep.c (arc_insn_get_memory_base_reg): Make static.
1617          (arc_insn_get_memory_offset): Likewise.
1618          (arc_insn_dump): Likewise.
1619          * cp-support.c (test_cp_symbol_name_matches): Likewise.
1620          * csky-linux-tdep.c (csky_supply_fregset): Likewise.
1621          * dictionary.c (dict_iterator_next): Likewise.
1622          (dict_iter_match_first): Likewise.
1623          (dict_iter_match_next): Likewise.
1624          * f-lang.c (evaluate_subexp_f): Likewise.
1625          * hppa-tdep.c (hppa_read_pc): Likewise.
1626          * i386-tdep.c (i386_floatformat_for_type): Likewise.
1627          * parse.c (write_exp_elt_msym): Likewise.
1628          * ppc-linux-tdep.c (ppc_floatformat_for_type): Likewise.
1629          * remote.c (remote_packet_size): Likewise.
1630          (remote_notif_stop_parse): Likewise.
1631          * rs6000-aix-tdep.c (aix_sighandle_frame_sniffer): Likewise.
1632          * s12z-tdep.c (s12z_disassemble_info): Likewise.
1633          * source.c (prepare_path_for_appending): Likewise.
1634          * sparc64-linux-tdep.c
1635          (sparc64_linux_handle_segmentation_fault); Likewise.
1636          * stack.c (frame_selection_by_function_completer): Likewise.
1637
1638 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1639
1640         * completer.c (set_gdb_completion_word_break_characters):
1641         Remove.
1642
1643 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1644
1645         * dwarf-index-write.c: Include dwarf-index-write.h.
1646         * mi/mi-interp.c: Include mi/mi-interp.h.
1647
1648 2019-11-26  Simon Marchi  <simon.marchi@efficios.com>
1649
1650         * aarch32-tdep.c: Include aarch32-tdep.h.
1651         * aarch32-tdep.h: Forward-declare struct target_desc.
1652
1653 2019-11-26  Christian Biesinger  <cbiesinger@google.com>
1654
1655         * linux-nat.c (detach_one_lwp): Call safe_strerror instead of
1656         strerror.
1657         * nto-procfs.c (nto_procfs_target::create_inferior): Likewise.
1658         * windows-nat.c (windows_nat_target::create_inferior): Likewise.
1659
1660 2019-11-25  Tom de Vries  <tdevries@suse.de>
1661
1662         * contrib/words.sh: Add -c option.
1663
1664 2019-11-25  Christian Biesinger  <cbiesinger@google.com>
1665
1666         * solib.c (solib_find_1): Change int to bool.
1667         (exec_file_find): Change int to bool.
1668         (solib_find): Change int to bool.
1669         (solib_read_symbols): Change int to bool.
1670         (solib_used): Change int to bool.
1671         (solib_add): Change int to bool.
1672         (info_sharedlibrary_command): Change int to bool.
1673         (solib_contains_address_p): Change int to bool.
1674         (solib_keep_data_in_core): Change int to bool.
1675         (in_solib_dynsym_resolve_code): Change int to bool.
1676         (reload_shared_libraries_1): Change int to bool.
1677         (gdb_sysroot_changed): Change int to bool.
1678         * solib.h (solib_read_symbols): Change int to bool.
1679         (solib_contains_address_p): Change int to bool.
1680         (solib_keep_data_in_core): Change int to bool.
1681         (in_solib_dynsym_resolve_code): Change int to bool.
1682         (libpthread_name_p): Change int to bool.
1683
1684 2019-11-25  Luis Machado  <luis.machado@linaro.org>
1685
1686         * NEWS (New Commands): Mention "set debug remote-packet-max-chars".
1687         * remote.c (REMOTE_DEBUG_MAX_CHAR): Remove.
1688         (remote_packet_max_chars): New static global.
1689         (show_remote_packet_max_chars): New function.
1690         (remote_target::putpkt_binary): Adjust to use new
1691         remote_packet_max_chars option.
1692         (remote_target::getpkt_or_notif_sane_1): Likewise.
1693         (_initialize_remote): Register new remote-packet-max-chars option.
1694
1695 2019-11-24  Simon Marchi  <simon.marchi@efficios.com>
1696
1697         * m68k-linux-nat.c: Include gdbarch.h.
1698
1699 2019-11-24  Tom Tromey  <tom@tromey.com>
1700
1701         * symfile.c (read_symbols): Update.
1702         * psymtab.c (require_partial_symbols): Change type of "verbose" to
1703         bool.
1704         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
1705         (psym_lookup_symbol, psym_find_last_source_symtab)
1706         (psym_forget_cached_source_info, psym_print_stats)
1707         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
1708         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
1709         (psym_map_matching_symbols, psym_expand_symtabs_matching)
1710         (psym_find_compunit_symtab_by_address)
1711         (maintenance_print_psymbols, maintenance_info_psymtabs)
1712         (maintenance_check_psymtabs): Update.
1713         * psymtab.h (require_partial_symbols): Change type of "verbose" to
1714         bool.
1715
1716 2019-11-22  Tom Tromey  <tom@tromey.com>
1717
1718         * observable.h: Update comments.
1719
1720 2019-11-22  Tom Tromey  <tromey@adacore.com>
1721
1722         * ada-tasks.c (ada_task_is_alive): Make parameter const.
1723         (print_ada_task_info): Don't try to fetch thread id if task is not
1724         alive.
1725
1726 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1727
1728         * ada-exp.y: Update.
1729         * ada-lang.c (sort_choices): Update.
1730         (ada_print_symbol_signature): Update.
1731         (resolve_subexp): Update.
1732         (ada_parse_renaming): Update.
1733         (ada_read_renaming_var_value): Update.
1734         (lesseq_defined_than): Update.
1735         (remove_extra_symbols): Update.
1736         (remove_irrelevant_renamings): Update.
1737         (ada_add_block_symbols): Update.
1738         (ada_collect_symbol_completion_matches): Update.
1739         (ada_is_renaming_symbol): Update.
1740         (aggregate_assign_from_choices): Update.
1741         (ada_evaluate_subexp): Update.
1742         (ada_has_this_exception_support): Update.
1743         (ada_is_non_standard_exception_sym): Update.
1744         (ada_add_exceptions_from_frame): Update.
1745         (ada_add_global_exceptions): Update.
1746         (ada_print_subexp): Update.
1747         * ax-gdb.c (gen_var_ref): Update.
1748         (gen_maybe_namespace_elt): Update.
1749         (gen_expr_for_cast): Update.
1750         (gen_expr): Update.
1751         * block.h: Update.
1752         * blockframe.c (find_pc_partial_function): Update.
1753         * breakpoint.c (print_breakpoint_location): Update.
1754         (update_static_tracepoint): Update.
1755         * btrace.c (ftrace_print_function_name): Update.
1756         (ftrace_function_switched): Update.
1757         * buildsym.c (find_symbol_in_list): Update.
1758         * c-exp.y: Update.
1759         * c-typeprint.c (c_print_typedef): Update.
1760         (c_type_print_template_args): Update.
1761         * cli/cli-cmds.c (edit_command): Update.
1762         (list_command): Update.
1763         (print_sal_location): Update.
1764         * coffread.c (patch_opaque_types): Update.
1765         (process_coff_symbol): Update.
1766         (coff_read_enum_type): Update.
1767         * compile/compile-c-symbols.c (c_symbol_substitution_name): Update.
1768         (convert_one_symbol): Update.
1769         (hash_symname): Update.
1770         (eq_symname): Update.
1771         * compile/compile-cplus-symbols.c (convert_one_symbol): Update.
1772         * compile/compile-cplus-types.c (debug_print_scope): Update.
1773         * compile/compile-loc2c.c (do_compile_dwarf_expr_to_c): Update.
1774         * compile/compile-object-load.c (get_out_value_type): Update.
1775         * cp-namespace.c (cp_scan_for_anonymous_namespaces): Update.
1776         (search_symbol_list): Update.
1777         (cp_lookup_symbol_imports_or_template): Update.
1778         * cp-support.c (overload_list_add_symbol): Update.
1779         * ctfread.c (psymtab_to_symtab): Update.
1780         * dbxread.c (cp_set_block_scope): Update.
1781         * dictionary.c (iter_match_first_hashed): Update.
1782         (iter_match_next_hashed): Update.
1783         (insert_symbol_hashed): Update.
1784         (iter_match_next_linear): Update.
1785         * dictionary.h: Update.
1786         * dwarf2loc.c (func_get_frame_base_dwarf_block): Update.
1787         (locexpr_describe_location_piece): Update.
1788         (locexpr_describe_location_1): Update.
1789         (locexpr_generate_c_location): Update.
1790         (loclist_describe_location): Update.
1791         (loclist_generate_c_location): Update.
1792         * dwarf2read.c (dw2_debug_names_lookup_symbol): Update.
1793         (read_func_scope): Update.
1794         (process_enumeration_scope): Update.
1795         (new_symbol): Update.
1796         (dwarf2_const_value): Update.
1797         (dwarf2_symbol_mark_computed): Update.
1798         * eval.c (evaluate_funcall): Update.
1799         (evaluate_subexp_standard): Update.
1800         * expprint.c (print_subexp_standard): Update.
1801         (dump_subexp_body_standard): Update.
1802         * f-valprint.c (info_common_command_for_block): Update.
1803         * findvar.c (get_hosting_frame): Update.
1804         (default_read_var_value): Update.
1805         * go-lang.c (go_symbol_package_name): Update.
1806         * guile/scm-block.c (bkscm_print_block_smob): Update.
1807         * guile/scm-symbol.c (syscm_print_symbol_smob): Update.
1808         (gdbscm_symbol_name): Update.
1809         (gdbscm_symbol_linkage_name): Update.
1810         (gdbscm_symbol_print_name): Update.
1811         * infcall.c (get_function_name): Update.
1812         * infcmd.c (jump_command): Update.
1813         (finish_command): Update.
1814         * infrun.c (insert_exception_resume_breakpoint): Update.
1815         * linespec.c (canonicalize_linespec): Update.
1816         (create_sals_line_offset): Update.
1817         (convert_linespec_to_sals): Update.
1818         (complete_label): Update.
1819         (find_label_symbols_in_block): Update.
1820         * m2-typeprint.c (m2_print_typedef): Update.
1821         * mdebugread.c (mdebug_reg_to_regnum): Update.
1822         (parse_symbol): Update.
1823         (mylookup_symbol): Update.
1824         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
1825         (list_args_or_locals): Update.
1826         * objc-lang.c (compare_selectors): Update.
1827         (info_selectors_command): Update.
1828         (compare_classes): Update.
1829         (info_classes_command): Update.
1830         (find_imps): Update.
1831         * p-typeprint.c (pascal_print_typedef): Update.
1832         * printcmd.c (build_address_symbolic): Update.
1833         (info_address_command): Update.
1834         (print_variable_and_value): Update.
1835         * python/py-framefilter.c (extract_sym): Update.
1836         (py_print_single_arg): Update.
1837         * python/py-symbol.c (sympy_str): Update.
1838         (sympy_get_name): Update.
1839         (sympy_get_linkage_name): Update.
1840         * python/python.c (gdbpy_rbreak): Update.
1841         * record-btrace.c (btrace_get_bfun_name): Update.
1842         (btrace_call_history): Update.
1843         * rust-lang.c (rust_print_typedef): Update.
1844         * solib-frv.c (frv_fdpic_find_canonical_descriptor): Update.
1845         * stabsread.c (stab_reg_to_regnum): Update.
1846         (define_symbol): Update.
1847         (read_enum_type): Update.
1848         (common_block_end): Update.
1849         (cleanup_undefined_types_1): Update.
1850         (scan_file_globals): Update.
1851         * stack.c (print_frame_arg): Update.
1852         (print_frame_args): Update.
1853         (find_frame_funname): Update.
1854         (info_frame_command_core): Update.
1855         (iterate_over_block_locals): Update.
1856         (print_block_frame_labels): Update.
1857         (do_print_variable_and_value): Update.
1858         (iterate_over_block_arg_vars): Update.
1859         (return_command): Update.
1860         * symmisc.c (dump_symtab_1): Update.
1861         (print_symbol): Update.
1862         * symtab.c (eq_symbol_entry): Update.
1863         (symbol_cache_dump): Update.
1864         (lookup_language_this): Update.
1865         (find_pc_sect_line): Update.
1866         (skip_prologue_sal): Update.
1867         (symbol_search::compare_search_syms): Update.
1868         (treg_matches_sym_type_name): Update.
1869         (search_symbols): Update.
1870         (print_symbol_info): Update.
1871         (rbreak_command): Update.
1872         (completion_list_add_symbol): Update.
1873         (find_gnu_ifunc): Update.
1874         (get_symbol_address): Update.
1875         (search_module_symbols): Update.
1876         (info_module_subcommand): Update.
1877         * symtab.h (SYMBOL_NATURAL_NAME): Remove.
1878         (SYMBOL_LINKAGE_NAME): Remove.
1879         (SYMBOL_DEMANGLED_NAME): Remove.
1880         (SYMBOL_PRINT_NAME): Remove.
1881         (SYMBOL_SEARCH_NAME): Remove.
1882         * tracepoint.c (set_traceframe_context): Update.
1883         (validate_actionline): Update.
1884         (collection_list::collect_symbol): Update.
1885         (encode_actions_1): Update.
1886         (info_scope_command): Update.
1887         (print_one_static_tracepoint_marker): Update.
1888         * typeprint.c (typedef_hash_table::add_template_parameters): Update.
1889         * valops.c (address_of_variable): Update.
1890         (find_overload_match): Update.
1891         (find_oload_champ): Update.
1892
1893 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
1894
1895         * ada-lang.c (ada_lookup_simple_minsym): Update.
1896         (ada_collect_symbol_completion_matches): Update.
1897         * ada-tasks.c (read_atcb): Update.
1898         * amd64-windows-tdep.c (amd64_skip_main_prologue): Update.
1899         (amd64_windows_skip_trampoline_code): Update.
1900         * arm-tdep.c (skip_prologue_function): Update.
1901         (arm_skip_stack_protector): Update.
1902         * arm-wince-tdep.c (arm_pe_skip_trampoline_code): Update.
1903         (arm_wince_skip_main_prologue): Update.
1904         * ax-gdb.c (gen_expr): Update.
1905         * block.c (call_site_for_pc): Update.
1906         * blockframe.c (find_pc_partial_function): Update.
1907         * breakpoint.c (set_breakpoint_location_function): Update.
1908         * btrace.c (ftrace_print_function_name): Update.
1909         (ftrace_function_switched): Update.
1910         * c-valprint.c (print_unpacked_pointer): Update.
1911         * coffread.c (coff_symfile_read): Update.
1912         * compile/compile-c-symbols.c (convert_symbol_bmsym): Update.
1913         * compile/compile-cplus-symbols.c (convert_symbol_bmsym): Update.
1914         * dwarf-index-write.c (write_psymbols): Update.
1915         * dwarf2loc.c (call_site_to_target_addr): Update.
1916         (func_verify_no_selftailcall): Update.
1917         (tailcall_dump): Update.
1918         (call_site_find_chain_1): Update.
1919         (dwarf_expr_reg_to_entry_parameter): Update.
1920         * elfread.c (elf_gnu_ifunc_record_cache): Update.
1921         * eval.c (evaluate_funcall): Update.
1922         (evaluate_subexp_standard): Update.
1923         (evaluate_subexp_for_sizeof): Update.
1924         * expprint.c (print_subexp_standard): Update.
1925         (dump_subexp_body_standard): Update.
1926         * frame.c (get_prev_frame_always_1): Update.
1927         * frv-tdep.c (frv_skip_main_prologue): Update.
1928         * gnu-v2-abi.c (gnuv2_value_rtti_type): Update.
1929         * gnu-v3-abi.c (gnuv3_rtti_type): Update.
1930         (gnuv3_get_typename_from_type_info): Update.
1931         (gnuv3_skip_trampoline): Update.
1932         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
1933         * i386-tdep.c (i386_skip_main_prologue): Update.
1934         (i386_pe_skip_trampoline_code): Update.
1935         * ia64-tdep.c (ia64_convert_from_func_ptr_addr): Update.
1936         * infcall.c (get_function_name): Update.
1937         * linespec.c (minsym_found): Update.
1938         * linux-fork.c (info_checkpoints_command): Update.
1939         * m32c-tdep.c (m32c_m16c_address_to_pointer): Update.
1940         (m32c_m16c_pointer_to_address): Update.
1941         * maint.c (maintenance_translate_address): Update.
1942         * minsyms.c (add_minsym_to_hash_table): Update.
1943         (add_minsym_to_demangled_hash_table): Update.
1944         (lookup_minimal_symbol_mangled): Update.
1945         (lookup_minimal_symbol_demangled): Update.
1946         (lookup_minimal_symbol_linkage): Update.
1947         (lookup_minimal_symbol_text): Update.
1948         (lookup_minimal_symbol_by_pc_name): Update.
1949         (minimal_symbol_is_less_than): Update.
1950         (compact_minimal_symbols): Update.
1951         (build_minimal_symbol_hash_tables): Update.
1952         (find_solib_trampoline_target): Update.
1953         * mips-tdep.c (mips_stub_frame_sniffer): Update.
1954         (mips_skip_pic_trampoline_code): Update.
1955         * msp430-tdep.c (msp430_skip_trampoline_code): Update.
1956         * objc-lang.c (info_selectors_command): Update.
1957         (info_classes_command): Update.
1958         (find_methods): Update.
1959         (find_imps): Update.
1960         * p-valprint.c (pascal_val_print): Update.
1961         * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Update.
1962         * ppc-sysv-tdep.c (convert_code_addr_to_desc_addr): Update.
1963         * printcmd.c (build_address_symbolic): Update.
1964         (info_symbol_command): Update.
1965         * psymtab.c (psymbol_name_matches): Update.
1966         (match_partial_symbol): Update.
1967         (lookup_partial_symbol): Update.
1968         (print_partial_symbols): Update.
1969         (sort_pst_symbols): Update.
1970         (maintenance_check_psymtabs): Update.
1971         * python/py-framefilter.c (py_print_frame): Update.
1972         * python/python.c (gdbpy_rbreak): Update.
1973         * record-btrace.c (btrace_get_bfun_name): Update.
1974         (btrace_call_history): Update.
1975         * rs6000-tdep.c (rs6000_skip_main_prologue): Update.
1976         (rs6000_skip_trampoline_code): Update.
1977         * sol-thread.c (info_cb): Update.
1978         * stabsread.c (scan_file_globals): Update.
1979         * stack.c (find_frame_funname): Update.
1980         (info_frame_command_core): Update.
1981         * symmisc.c (dump_msymbols): Update.
1982         * symtab.c (symbol_natural_name): Rename to..,
1983         (general_symbol_info::natural_name): ...this.
1984         (symbol_demangled_name): Rename to...
1985         (general_symbol_info::demangled_name): ...this.
1986         (symbol_search_name): Rename to...
1987         (general_symbol_info::search_name): ...this.
1988         (symbol_matches_search_name): Update.
1989         (find_pc_sect_line): Update.
1990         (skip_prologue_sal): Update.
1991         (search_symbols): Update.
1992         (print_msymbol_info): Update.
1993         (rbreak_command): Update.
1994         (completion_list_add_msymbol): Update.
1995         (completion_list_objc_symbol): Update.
1996         (get_msymbol_address): Update.
1997         * symtab.h (struct general_symbol_info): Add member functions
1998         natural_name (), linkage_name (), print_name (), demangled_name (),
1999         and search_name ().
2000         (SYMBOL_NATURAL_NAME): Update.
2001         (symbol_natural_name): Move to a member function on general_symbol_info.
2002         (SYMBOL_DEMANGLED_NAME): Update.
2003         (symbol_demangled_name): Move to a member function on
2004         general_symbol_info.
2005         (SYMBOL_SEARCH_NAME): Update.
2006         (symbol_search_name): Move to a member function on general_symbol_info.
2007         (MSYMBOL_NATURAL_NAME): Remove.
2008         (MSYMBOL_LINKAGE_NAME): Remove.
2009         (MSYMBOL_PRINT_NAME): Remove.
2010         (MSYMBOL_DEMANGLED_NAME): Remove.
2011         (MSYMBOL_SEARCH_NAME): Remove.
2012         * x86-tdep.c (x86_in_indirect_branch_thunk): Update.
2013
2014 2019-11-22  Christian Biesinger  <cbiesinger@google.com>
2015
2016         * symtab.c (create_demangled_names_hash): Use per_bfd->
2017         minimal_symbol_count for computing the initial size, if greater
2018         than our default size.
2019
2020 2019-11-22  Tom de Vries  <tdevries@suse.de>
2021
2022         * contrib/words.sh: Improve words extraction.
2023
2024 2019-11-22  Tom de Vries  <tdevries@suse.de>
2025
2026         * contrib/words.sh: Combine sed invocations.
2027
2028 2019-11-21  Christian Biesinger  <cbiesinger@google.com>
2029
2030         * Makefile.in: Update.
2031         * demangle.c: Rename to...
2032         * gdb-demangle.c: ..this.
2033         (is_cplus_marker): Change return type to bool.
2034         (_initialize_demangler): Rename to...
2035         (_initialize_gdb_demangle): ...this.
2036         * gdb-demangle.h (is_cplus_marker): Change return type to bool.
2037         * symtab.h (demangle): Remove declaration; instead include
2038         gdb-demangle.h.
2039
2040 2019-11-21  Tom Tromey  <tromey@adacore.com>
2041
2042         * gdbsupport/format.c (format_pieces): Parse %I64d.
2043         * unittests/format_pieces-selftests.c (test_windows_formats): New
2044         function.
2045         (run_tests): Call it.
2046
2047 2019-11-21  Peeter Joot  <peeter.joot@lzlabs.com>
2048
2049         Byte reverse display of variables with DW_END_big, DW_END_little
2050         (DW_AT_endianity) dwarf attributes if different than the native
2051         byte order.
2052         * ada-lang.c (ada_value_binop):
2053         Use type_byte_order instead of gdbarch_byte_order.
2054         * ada-valprint.c (printstr):
2055         (ada_val_print_string):
2056         * ada-lang.c (value_pointer):
2057         (ada_value_binop):
2058         Use type_byte_order instead of gdbarch_byte_order.
2059         * c-lang.c (c_get_string):
2060         Use type_byte_order instead of gdbarch_byte_order.
2061         * c-valprint.c (c_val_print_array):
2062         Use type_byte_order instead of gdbarch_byte_order.
2063         * cp-valprint.c (cp_print_class_member):
2064         Use type_byte_order instead of gdbarch_byte_order.
2065         * dwarf2loc.c (rw_pieced_value):
2066         Use type_byte_order instead of gdbarch_byte_order.
2067         * dwarf2read.c (read_base_type): Handle DW_END_big,
2068         DW_END_little
2069         * f-lang.c (f_get_encoding):
2070         Use type_byte_order instead of gdbarch_byte_order.
2071         * findvar.c (default_read_var_value):
2072         Use type_byte_order instead of gdbarch_byte_order.
2073         * gdbtypes.c (check_types_equal):
2074         Require matching TYPE_ENDIANITY_NOT_DEFAULT if set.
2075         (recursive_dump_type): Print TYPE_ENDIANITY_BIG,
2076         and TYPE_ENDIANITY_LITTLE if set.
2077         (type_byte_order): new function.
2078         * gdbtypes.h (TYPE_ENDIANITY_NOT_DEFAULT): New macro.
2079         (struct main_type) <flag_endianity_not_default>:
2080         New field.
2081         (type_byte_order): New function.
2082         * infcmd.c (default_print_one_register_info):
2083         Use type_byte_order instead of gdbarch_byte_order.
2084         * p-lang.c (pascal_printstr):
2085         Use type_byte_order instead of gdbarch_byte_order.
2086         * p-valprint.c (pascal_val_print):
2087         Use type_byte_order instead of gdbarch_byte_order.
2088         * printcmd.c (print_scalar_formatted):
2089         Use type_byte_order instead of gdbarch_byte_order.
2090         * solib-darwin.c (darwin_current_sos):
2091         Use type_byte_order instead of gdbarch_byte_order.
2092         * solib-svr4.c (solib_svr4_r_ldsomap):
2093         Use type_byte_order instead of gdbarch_byte_order.
2094         * stap-probe.c (stap_modify_semaphore):
2095         Use type_byte_order instead of gdbarch_byte_order.
2096         * target-float.c (target_float_same_format_p):
2097         Use type_byte_order instead of gdbarch_byte_order.
2098         * valarith.c (scalar_binop):
2099         (value_bit_index):
2100         Use type_byte_order instead of gdbarch_byte_order.
2101         * valops.c (value_cast):
2102         Use type_byte_order instead of gdbarch_byte_order.
2103         * valprint.c (generic_emit_char):
2104         (generic_printstr):
2105         (val_print_string):
2106         Use type_byte_order instead of gdbarch_byte_order.
2107         * value.c (unpack_long):
2108         (unpack_bits_as_long):
2109         (unpack_value_bitfield):
2110         (modify_field):
2111         (pack_long):
2112         (pack_unsigned_long):
2113         Use type_byte_order instead of gdbarch_byte_order.
2114         * findvar.c (unsigned_pointer_to_address):
2115         (signed_pointer_to_address):
2116         (unsigned_address_to_pointer):
2117         (address_to_signed_pointer):
2118         (default_read_var_value):
2119         (default_value_from_register):
2120         Use type_byte_order instead of gdbarch_byte_order.
2121         * gnu-v3-abi.c (gnuv3_make_method_ptr):
2122         Use type_byte_order instead of gdbarch_byte_order.
2123         * riscv-tdep.c (riscv_print_one_register_info):
2124         Use type_byte_order instead of gdbarch_byte_order.
2125
2126 2019-11-21  Simon Marchi  <simon.marchi@polymtl.ca>
2127
2128         * top.c (current_ui_gdb_stdout_ptr): Spell out by hand.
2129         (current_ui_gdb_stdin_ptr): Likewise.
2130         (current_ui_gdb_stderr_ptr): Likewise.
2131         (current_ui_gdb_stdlog_ptr): Likewise.
2132         (current_ui_current_uiout_ptr): Likewise.
2133         (gen_ret_current_ui_field_ptr): Remove.
2134
2135 2019-11-21  Tom de Vries  <tdevries@suse.de>
2136
2137         PR gdb/24956
2138         * cli/cli-script.c (execute_control_command): Only switch to
2139         INTERP_CONSOLE's ui_out when INTERP_MI is active.
2140
2141 2019-11-19  Tom Tromey  <tom@tromey.com>
2142
2143         * tui/tui-win.c (tui_partial_win_by_name): Move from tui-data.c.
2144         Now static.  Change type of "name".
2145         (tui_set_win_height_command): Don't copy "arg".
2146         * tui/tui-data.h (tui_partial_win_by_name): Don't declare.
2147         * tui/tui-data.c (tui_partial_win_by_name): Move to tui-win.c.
2148
2149 2019-11-19  Ali Tamur <tamur@google.com>
2150
2151         * dwarf2read.c (dw2_get_file_names_reader): Replace "if (attr)" with
2152         "if (attr != nullptr)".
2153         (dwarf2_find_base_address): Likewise.
2154         (dwarf2_build_include_psymtabs): Likewise.
2155         (read_cutu_die_from_dwo): Likewise.
2156         (read_func_scope): Likewise.
2157         (read_call_site_scope): Likewise.
2158         (dwarf2_get_pc_bounds): Likewise.
2159         (dwarf2_record_block_ranges): Likewise.
2160         (dwarf2_add_field): Likewise.
2161         (dwarf2_add_member_fn): Likewise.
2162         (read_structure_type): Likewise.
2163         (read_enumeration_type): Likewise.
2164         (read_array_type): Likewise.
2165         (read_array_order): Likewise.
2166         (read_set_type): Likewise.
2167         (read_common_block): Likewise.
2168         (read_tag_reference_type): Likewise.
2169         (read_tag_string_type): Likewise.
2170         (read_subroutine_type): Likewise.
2171         (read_base_type): Likewise.
2172         (read_subrange_type): Likewise.
2173         (new_symbol): Likewise.
2174         (prepare_one_comp_unit): Likewise.
2175
2176 2019-11-19  Tom Tromey  <tromey@adacore.com>
2177
2178         * windows-nat.c (windows_nat_target::attach): Include GetLastError
2179         result in error when DebugActiveProcess fails.
2180
2181 2019-11-18  Sergio Durigan Junior  <sergiodj@redhat.com>
2182             Pedro Alves  <palves@redhat.com>
2183
2184         https://bugzilla.redhat.com/show_bug.cgi?id=1765117
2185         * target.c (target_stack::push): Call 'unpush' if there's a
2186         target on top of the stack.
2187
2188 2019-11-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2189
2190         * python/py-block.c (blpy_dealloc): Call tp_free.
2191         (blpy_block_syms_dealloc): Likewise.
2192         * python/py-finishbreakpoint.c (bpfinishpy_dealloc): Likewise.
2193         * python/py-inferior.c (infpy_dealloc): Likewise.
2194         * python/py-lazy-string.c (stpy_dealloc): Likewise.
2195         * python/py-linetable.c (ltpy_iterator_dealloc): Likewise.
2196         * python/py-symbol.c (sympy_dealloc): Likewise.
2197         * python/py-symtab.c (stpy_dealloc): Likewise.
2198         * python/py-type.c (typy_iterator_dealloc): Likewise.
2199
2200 2019-11-18  Christian Biesinger  <cbiesinger@google.com>
2201
2202         * symtab.h (struct symbol) <owner>: Initialize explicitly in the
2203         constructor instead of using a class initializer.
2204
2205 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2206
2207         * Makefile.in: Replace {posix,mingw}-strerror.c with safe-strerror.c.
2208         * configure: Regenerate.
2209         * configure.ac: Don't source common.host.
2210         * gdbsupport/common.host: Remove.
2211         * gdbsupport/mingw-strerror.c: Remove.
2212         * gdbsupport/posix-strerror.c: Rename to...
2213         * gdbsupport/safe-strerror.c: ...this.
2214
2215 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2216
2217         * maint.c (scoped_command_stats::print_time): Use localtime_r
2218         instead of localtime (provided through gnulib if necessary).
2219         * nat/linux-osdata.c (time_from_time_t): Use ctime_r instead
2220         of ctime.
2221
2222 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2223
2224         * gdbsupport/common-defs.h: Include time.h before pathmax.h to
2225         avoid compile errors.
2226
2227 2019-11-15  Christian Biesinger  <cbiesinger@google.com>
2228
2229         * config.in: Regenerate.
2230         * configure: Regenerate.
2231         * gdbsupport/common.m4: No longer check for strerror_r.
2232         * gdbsupport/posix-strerror.c (safe_strerror): Always call the
2233         POSIX version of strerror_r, now that gnulib provides it if
2234         necessary.
2235
2236 2019-11-14  Christian Biesinger  <cbiesinger@google.com>
2237
2238         * README (`configure' options): Update.
2239
2240 2019-11-14  Tom Tromey  <tromey@adacore.com>
2241
2242         * eval.c (evaluate_subexp_standard) <BINOP_ASSIGN>: Do not pass an
2243         expected type for the RHS if the LHS is a convenience variable.
2244
2245 2019-11-14  Simon Marchi  <simon.marchi@polymtl.ca>
2246
2247         * unittests/vec-utils-selftests.c (unordered_remove_tests::obj):
2248         Provide explicit default and copy constructor.
2249
2250 2019-11-14  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2251
2252         * python/py-finishbreakpoint.c (gdbpy_breakpoint_created):
2253         only call Py_INCREF (newbp) in the bppy_pending_object case.
2254
2255 2019-11-13  Tom Tromey  <tromey@adacore.com>
2256
2257         PR build/25182:
2258         * psympriv.h (partial_symbol): Remove static assert.
2259         * symtab.h (general_symbol_info, symbol): Remove static assert.
2260
2261 2019-11-12  Andrew Burgess  <andrew.burgess@embecosm.com>
2262
2263         * gdbsupport/format.c (format_pieces::format_pieces): Support
2264         printf 'z' size modifier.
2265         * gdbsupport/format.h (enum argclass): Add size_t_arg.
2266         * printcmd.c (ui_printf):  Handle size_t_arg.
2267         * ui-out.c (ui_out::vmessage): Likewise.
2268         * unittests/format_pieces-selftests.c (test_format_int_sizes): New
2269         function.
2270         (run_tests): Call test_format_int_sizes.
2271
2272 2019-11-12  Christian Biesinger  <cbiesinger@google.com>
2273
2274         * ada-exp.y (write_ambiguous_var): Update.
2275         * buildsym.c (add_symbol_to_list): Update.
2276         * dwarf2read.c (read_variable): Update.
2277         (new_symbol): Update.
2278         * jit.c (finalize_symtab): Update.
2279         * language.c (language_alloc_type_symbol): Update.
2280         * symtab.c (fixup_symbol_section): Update.
2281         (initialize_objfile_symbol_1): Move code to...
2282         (initialize_objfile_symbol): ...here. Remove now-unnecessary memset.
2283         (allocate_symbol): Update.
2284         (allocate_template_symbol): Update.
2285         (get_symbol_address): Update.
2286         * symtab.h (struct symbol): Inherit from general_symbol_info instead
2287         of having as a field, and add a constructor.
2288         (SYMBOL_VALUE): Update.
2289         (SYMBOL_VALUE_ADDRESS): Update.
2290         (SET_SYMBOL_VALUE_ADDRESS): Update.
2291         (SYMBOL_VALUE_BYTES): Update.
2292         (SYMBOL_VALUE_COMMON_BLOCK): Update.
2293         (SYMBOL_BLOCK_VALUE): Update.
2294         (SYMBOL_VALUE_CHAIN): Update.
2295         (SYMBOL_LANGUAGE): Update.
2296         (SYMBOL_SECTION): Update.
2297         (SYMBOL_OBJ_SECTION): Update.
2298         (SYMBOL_SET_LANGUAGE): Update.
2299         (SYMBOL_SET_LINKAGE_NAME): Update.
2300         (SYMBOL_SET_NAMES): Update.
2301         (SYMBOL_NATURAL_NAME): Update.
2302         (SYMBOL_LINKAGE_NAME): Update.
2303         (SYMBOL_DEMANGLED_NAME): Update.
2304         (SYMBOL_SEARCH_NAME): Update.
2305         (SYMBOL_MATCHES_SEARCH_NAME): Update.
2306         (struct symbol): Update.
2307         (struct template_symbol): Update.
2308         (struct rust_vtable_symbol): Update.
2309         * xcoffread.c (SYMBOL_DUP): Update.
2310
2311 2019-11-12  Tom Tromey  <tom@tromey.com>
2312
2313         * tui/tui-layout.c (show_layout): Set current_layout.
2314         (show_source_disasm_command, show_data)
2315         (show_source_or_disasm_and_command): Don't set current_layout.
2316
2317 2019-11-12  Tom Tromey  <tom@tromey.com>
2318
2319         * tui/tui-layout.c (_initialize_tui_layout): Move to end.
2320
2321 2019-11-12  Tom Tromey  <tom@tromey.com>
2322
2323         * tui/tui-win.c (resize_message): New global.
2324         (show_tui_resize_message): New function.
2325         (tui_async_resize_screen): Print message if requested.
2326         (_initialize_tui_win): Add tui-resize-message setting.
2327         * NEWS: Add entry for new commands.
2328
2329 2019-11-11  Tom Tromey  <tom@tromey.com>
2330
2331         * tui/tui.c (tui_initialize_readline): Add new bindable readline
2332         functions.
2333
2334 2019-11-11  Christian Biesinger  <cbiesinger@google.com>
2335
2336         * nat/linux-osdata.c (user_from_uid): Use getpwuid_r.
2337
2338 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2339
2340         * python/py-symbol.c (gdbpy_lookup_static_symbols): New
2341         function.
2342         * python/python-internal.h (gdbpy_lookup_static_symbols):
2343         Declare new function.
2344         * python/python.c (python_GdbMethods): Add
2345         gdb.lookup_static_symbols method.
2346         * NEWS: Mention gdb.lookup_static_symbols.
2347
2348 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2349
2350         * python/py-symbol.c (gdbpy_lookup_static_symbol): Lookup in
2351         static block of current object file first.  Also fix typo in
2352         header comment.
2353
2354 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2355
2356         * stack.c (set_last_displayed_sal): Delete.
2357         (last_displayed_sal_valid): Delete.
2358         (last_displayed_pspace): Delete.
2359         (last_displayed_addr): Delete.
2360         (last_displayed_symtab): Delete.
2361         (last_displayed_line): Delete.
2362         (class last_displayed_symtab_info_type): New.
2363         (last_displayed_symtab_info): New static global variable.
2364         (print_frame_info): Call methods on last_displayed_symtab_info.
2365         (clear_last_displayed_sal): Update header comment, and make use of
2366         last_displayed_symtab_info.
2367         (last_displayed_sal_is_valid): Likewise.
2368         (get_last_displayed_pspace): Likewise.
2369         (get_last_displayed_addr): Likewise.
2370         (get_last_displayed_symtab): Likewise.
2371         (get_last_displayed_line): Likewise.
2372         (get_last_displayed_sal): Likewise.
2373         * stack.h (clear_last_displayed_sal): Update header comment.
2374         (last_displayed_sal_is_valid): Likewise.
2375         (get_last_displayed_pspace): Likewise.
2376         (get_last_displayed_addr): Likewise.
2377         (get_last_displayed_symtab): Likewise.
2378         (get_last_displayed_line): Likewise.
2379         (get_last_displayed_sal): Likewise.
2380
2381 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2382
2383         * stack.c (frame_show_address): Convert return type to bool.
2384         * stack.h (frame_show_address): Likewise, and update header
2385         comment.
2386
2387 2019-11-10  Andrew Burgess  <andrew.burgess@embecosm.com>
2388
2389         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add new file to the list.
2390         * unittests/vec-utils-selftests.c: New file.
2391         * gdbsupport/gdb_vecs.h (unordered_remove): Avoid self move assign.
2392
2393 2019-11-10  Tom Tromey  <tom@tromey.com>
2394
2395         * tui/tui-wingeneral.c (tui_unhighlight_win): Use can_box.
2396         (tui_highlight_win): Likewise.
2397         (tui_win_info::check_and_display_highlight_if_needed): Likewise.
2398         * tui/tui-data.h (struct tui_win_info) <can_highlight>: Remove.
2399         * tui/tui-command.h (struct tui_cmd_window) <tui_cmd_window>:
2400         Don't set can_highlight.
2401
2402 2019-11-10  Tom Tromey  <tom@tromey.com>
2403
2404         * cli/cli-style.h (class cli_style_option) <cli_style_option>:
2405         Remove unused declaration.
2406
2407 2019-11-08  Tom Tromey  <tromey@adacore.com>
2408
2409         * top.c (read_command_file): Update.
2410         (command_line_input): Make return type const.
2411         * python/py-gdb-readline.c: Update.
2412         * linespec.c (decode_line_2): Update.
2413         * defs.h (command_line_input): Make return type const.
2414         * cli/cli-script.c (read_next_line): Make return type const.
2415         * ada-lang.c (get_selections): Update.
2416
2417 2019-11-06  Christian Biesinger  <cbiesinger@google.com>
2418
2419         * linux-tdep.c (linux_info_proc): Use strtok_r instead of strtok.
2420         * mi/mi-main.c (output_cores): Likewise.
2421         * nat/linux-osdata.c (linux_xfer_osdata_cpus): Likewise.
2422         (linux_xfer_osdata_modules): Likewise.
2423         * remote.c (register_remote_support_xml): Likewise.
2424         * sparc64-tdep.c (adi_is_addr_mapped): Likewise.
2425         * xml-syscall.c (syscall_create_syscall_desc): Likewise.
2426
2427 2019-11-06  Tom Tromey  <tom@tromey.com>
2428
2429         * tui/tui-interp.c: Don't include readline.h.
2430         * tui/tui-hooks.c: Don't include readline.h.
2431         * symmisc.c: Include tilde.h, not readline.h.
2432         * symfile.c: Include tilde.h, not readline.h.
2433         * source.c: Include tilde.h, not readline.h.
2434         * solib.c: Include tilde.h, not readline.h.
2435         * psymtab.c: Include tilde.h, not readline.h.
2436         * exec.c: Include tilde.h, not readline.h.
2437         * corelow.c: Include tilde.h, not readline.h.
2438         * cli/cli-dump.c: Include tilde.h, not readline.h.
2439         * cli/cli-cmds.c: Don't include readline.h.
2440
2441 2019-11-05  Tom Tromey  <tom@tromey.com>
2442
2443         * tui/tui-disasm.c (struct tui_asm_line) <addr_size>: New member.
2444         (tui_disassemble): Set addr_size.
2445         (tui_disasm_window::set_contents): Use addr_size.
2446
2447 2019-11-05  Tom Tromey  <tom@tromey.com>
2448
2449         * rust-lang.c (rust_language_defn): Update.
2450         * python/py-value.c (valpy_string): Call c_get_string.
2451         * p-lang.c (pascal_language_defn): Update.
2452         * opencl-lang.c (opencl_language_defn): Update.
2453         * objc-lang.c (objc_language_defn): Update.
2454         * m2-lang.c (m2_language_defn): Update.
2455         * language.c (unknown_language_defn, auto_language_defn): Update.
2456         (default_get_string): Remove.
2457         * guile/scm-value.c (gdbscm_value_to_string): Use c_get_string.
2458         * go-lang.c (go_language_defn): Update.
2459         * f-lang.c (f_language_defn): Update.
2460         * d-lang.c (d_language_defn): Update.
2461         * c-lang.c (c_language_defn, cplus_language_defn)
2462         (asm_language_defn, minimal_language_defn): Update.
2463         * ada-lang.c (ada_language_defn): Update.
2464         * language.h (struct language_defn) <la_get_string>: Remove.
2465         (LA_GET_STRING): Remove.
2466         (default_get_string): Don't declare.
2467
2468 2019-11-05  Tom Tromey  <tom@tromey.com>
2469
2470         * tui/tui-source.h (struct tui_source_window): Inline
2471         constructor.  Remove destructor.
2472         <style_changed, m_observable>: Move to superclass.
2473         * tui/tui-winsource.h (tui_copy_source_line): Declare.
2474         (struct tui_source_window_base): Move private members to end.
2475         <style_changed, m_observable>: Move from tui_source_window.
2476         * tui/tui-winsource.c (tui_copy_source_line): Move from
2477         tui-source.c.  Rename from copy_source_line.  Add special handling
2478         for negative line number.
2479         (tui_source_window_base::style_changed): Move from
2480         tui_source_window.
2481         (tui_source_window_base): Register observer.
2482         (~tui_source_window_base): New.
2483         * tui/tui-source.c (copy_source_line): Move to tui-winsource.c;
2484         rename.
2485         (tui_source_window::set_contents): Use tui_copy_source_line.
2486         (tui_source_window::tui_source_window): Move to tui-source.h.
2487         (tui_source_window::~tui_source_window): Remove.
2488         (tui_source_window::style_changed): Move to superclass.
2489         * tui/tui-disasm.c (tui_disassemble): Create string file with
2490         styling, when possible.  Add "addr_size" parameter.
2491         (tui_disasm_window::set_contents): Use tui_copy_source_line.
2492         Don't compute maximum size.
2493         (len_without_escapes): New function
2494
2495 2019-11-05  Tom Tromey  <tom@tromey.com>
2496
2497         * tui/tui-winsource.h (struct tui_source_element) <line>: Now a
2498         std::string.
2499         * tui/tui-winsource.c (tui_show_source_line): Update.
2500         * tui/tui-source.c (tui_source_window::set_contents): Update.
2501         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
2502
2503 2019-11-05  Christian Biesinger  <cbiesinger@google.com>
2504
2505         * symtab.h (gdb_static_assert): Put && operator at the beginning
2506         of the line instead of the end.
2507
2508 2019-11-04  Christian Biesinger  <cbiesinger@google.com>
2509
2510         * psympriv.h: Add static_asserts for sizeof (general_symbol_info)
2511         and sizeof (symbol).
2512         * symtab.h: Add a static_assert for sizeof (partial_symbol).
2513
2514 2019-11-04  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
2515
2516         * NEWS (Changes since GDB 8.3): Document Solaris 10 removal.
2517         * configure.host: Mark *-*-solaris2.10* obsolete.
2518         * configure.tgt: Mark Solaris < 11 obsolete.
2519         * MAINTAINERS (Target Instruction Set Architectures) <sparc>:
2520         Update target triplet.
2521
2522 2019-11-01  Tom Tromey  <tromey@adacore.com>
2523
2524         * utils.c (print_sys_errmsg): Simplify.
2525
2526 2019-11-01  Tom Tromey  <tromey@adacore.com>
2527
2528         * gdbsupport/mingw-strerror.c (safe_strerror): Constify result.
2529
2530 2019-11-01  Christian Biesinger  <cbiesinger@google.com>
2531
2532         * configure: Regenerate.
2533         * configure.ac: Remove check for strerror_r.
2534         * gdbsupport/common.m4: Check for strerror_r.
2535
2536 2019-11-01  Luis Machado  <luis.machado@linaro.org>
2537
2538         PR gdb/25124
2539
2540         * arm-tdep.c (arm_per_objfile): Rename to ...
2541         (arm_per_bfd): ... this.
2542         (arm_objfile_data_key): Rename to ...
2543         (arm_bfd_data_key): ... this.
2544         (arm_find_mapping_symbol): Adjust access to new bfd_key-based
2545         data.
2546         (arm_record_special_symbol): Likewise.
2547
2548 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2549
2550         * ada-typeprint.c (ada_print_typedef): Don't print newline at the
2551         end.
2552         * c-typeprint.c (c_print_typedef): Likewise.
2553         * f-typeprint.c (f_print_typedef): Likewise.
2554         * m2-typeprint.c (m2_print_typedef): Likewise.
2555         * p-typeprint.c (pascal_print_typedef): Likewise.
2556         * rust-lang.c (rust_print_typedef): Likewise.
2557         * symtab.c (print_symbol_info): Print a newline after calling
2558         typedef_print.
2559
2560 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2561
2562         * symtab.c (info_module_cmdlist): New variable.
2563         (info_module_command): New function.
2564         (search_module_symbols): New function.
2565         (info_module_subcommand): New function.
2566         (struct info_modules_var_func_options): New struct.
2567         (info_modules_var_func_options_defs): New variable.
2568         (make_info_modules_var_func_options_def_group): New function.
2569         (info_module_functions_command): New function.
2570         (info_module_variables_command): New function.
2571         (info_module_var_func_command_completer): New function.
2572         (_initialize_symtab): Register new 'info module functions' and
2573         'info module variables' commands.
2574         * symtab.h (typedef symbol_search_in_module): New typedef.
2575         (search_module_symbols): Declare new function.
2576         * NEWS: Mention new commands.
2577
2578 2019-10-31  Andrew Burgess  <andrew.burgess@embecosm.com>
2579
2580         * dwarf2read.c (dw2_symtab_iter_next): Handle MODULE_DOMAIN.
2581         (dw2_expand_marked_cus): Handle MODULES_DOMAIN.
2582         (dw2_debug_names_iterator::next): Handle MODULE_DOMAIN and
2583         MODULES_DOMAIN.
2584         (scan_partial_symbols): Only create partial module symbols for non
2585         declarations.
2586         * psymtab.c (recursively_search_psymtabs): Handle MODULE_DOMAIN
2587         and MODULES_DOMAIN.
2588         * symtab.c (search_domain_name): Likewise.
2589         (search_symbols): Likewise.
2590         (print_symbol_info): Likewise.
2591         (symtab_symbol_info): Likewise.
2592         (info_modules_command): New function.
2593         (_initialize_symtab): Register 'info modules' command.
2594         * symtab.h (enum search_domain): Add MODULES_DOMAIN.
2595         * NEWS: Mention new 'info modules' command.
2596
2597 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2598
2599         * NEWS: Mention $_gdb_setting, $_gdb_setting_str, $_gdb_maint_setting
2600         and $_gdb_maint_setting_str.
2601
2602 2019-10-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
2603
2604         * cli/cli-cmds.c (setting_cmd, value_from_setting)
2605         (gdb_setting_internal_fn, gdb_maint_setting_internal_fn)
2606         (str_value_from_setting, gdb_setting_str_internal_fn)
2607         (gdb_maint_setting_str_internal_fn): New functions.
2608         (_initialize_cli_cmds): Define the new convenience functions.
2609         * gdb/cli/cli-setshow.h (get_setshow_command_value_string): Constify.
2610         * gdb/cli/cli-setshow.c (get_setshow_command_value_string): Constify.
2611
2612 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2613
2614         * agent.c (set_can_use_agent): When the setting is turned on,
2615         look up agent symbols if we don't have them yet.
2616         (agent_new_objfile): Don't look up agent symbols when the agent
2617         setting is off.
2618
2619 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2620
2621         * config.in: Regenerate.
2622
2623 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2624
2625         * configure: Regenerate.
2626         * configure.ac: Check for strerror_r.
2627         * gdbsupport/common-utils.h (safe_strerror): Change return value
2628         to const char * and document that this function is now threadsafe.
2629         * gdbsupport/posix-strerror.c (safe_strerror): Make buf
2630         thread_local and call strerror_r, if available.
2631         * utils.c (perror_string): Update.
2632         (print_sys_errmsg): Update.
2633
2634 2019-10-31  Luis Machado  <luis.machado@linaro.org>
2635
2636         * arm-tdep.c (arm_exidx_data_key): Use bfd_key instead of
2637         objfile_key.
2638         (arm_exidx_new_objfile): Adjust to use objfile->obfd instead of
2639         objfile to fetch per-bfd data.
2640         (arm_find_exidx_entry): Likewise.
2641
2642 2019-10-31  Christian Biesinger  <cbiesinger@google.com>
2643
2644         * gdbsupport/agent.c (debug_agent): Change type to bool.
2645         (use_agent): Likewise.
2646         (all_agent_symbols_look_up): Likewise.
2647         (agent_loaded_p): Change return value to bool.
2648         (agent_look_up_symbols): Update.
2649         (agent_capability_check): Change return value to bool.
2650         * gdbsupport/agent.h (agent_loaded_p): Likewise.
2651         (debug_agent): Change type to bool.
2652         (use_agent): Likewise.
2653         (agent_capability_check): Change return value to bool.
2654
2655 2019-10-30  Christian Biesinger  <cbiesinger@google.com>
2656
2657         * minsyms.c (clear_minimal_symbol_hash_tables): New function.
2658         (build_minimal_symbol_hash_tables): Code to clear the table moved
2659         to clear_minimal_symbol_hash_tables.
2660         (minimal_symbol_reader::install): Call clear_minimal_symbol_hash_tables
2661         when needed.
2662
2663 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2664
2665         * infcmd.c: Remove includes.
2666         * infrun.c: Remove includes.
2667
2668 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2669
2670         * ada-lang.h (GROW_VECT): Move to ada-lang.c.
2671         (grow_vect): Remove declaration.
2672         (ada_type_of_array): Remove declaration.
2673         (ada_update_initial_language): Remove declaration.
2674         (ada_fold_name): Remove declaration.
2675         (ada_fill_in_ada_prototype): Remove declaration.
2676         (user_select_syms): Remove declaration.
2677         (get_selections): Remove declaration.
2678         (ada_tag_type): Remove declaration.
2679         (ada_value_tag): Remove declaration.
2680         (ada_is_others_clause): Remove declaration.
2681         (ada_in_variant): Remove declaration.
2682         (ada_value_struct_elt): Remove declaration.
2683         (ada_attribute_name): Remove declaration.
2684         (ada_system_address_type): Remove declaration.
2685         * ada-lang.c (ada_watch_location_expression): Make static.
2686         (GROW_VECT): Move here from ada-lang.h.
2687         (grow_vect): Make static.
2688         (ada_update_initial_language): Make static.
2689         (ada_fold_name): Make static.
2690         (ada_type_of_array): Make static.
2691         (encoded_ordered_before): Move up.
2692         (sort_choices): Move up.
2693         (print_signatures): Move up.
2694         (ada_print_symbol_signature): Move up.
2695         (get_selections): Move up and make static.
2696         (user_select_syms): Move up and make static.
2697         (ada_value_struct_elt): Move up and make static.
2698         (ada_tag_type): Make static.
2699         (ada_value_tag): Make static.
2700         (ada_is_others_clause): Make static.
2701         (ada_in_variant): Make static.
2702         (ada_attribute_name): Make static.
2703
2704 2019-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
2705
2706         * ada-lang.c: Remove includes.
2707         * ada-typeprint.c: Remove includes.
2708         * ada-valprint.c: Remove includes.
2709
2710 2019-10-29  Simon Marchi  <simon.marchi@efficios.com>
2711
2712         * addrmap.c: Add static assertions of type size, moved from
2713         _initialize_addrmap.
2714         (_initialize_addrmap): Remove.
2715
2716 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2717
2718         * coffread.c (record_minimal_symbol): Update.
2719         (process_coff_symbol): Update.
2720         * dbxread.c (read_dbx_symtab): Update.
2721         * dwarf2read.c (add_partial_symbol): Update.
2722         (fixup_go_packaging): Update.
2723         (load_partial_dies): Update.
2724         (new_symbol): Update.
2725         * elfread.c (record_minimal_symbol): Change signature to use
2726         gdb::string_view instead of name+len.
2727         (elf_symtab_read): Update.
2728         (elf_rel_plt_read): Update.
2729         * mdebugread.c (parse_partial_symbols): Update.
2730         (handle_psymbol_enumerators): Update.
2731         (new_symbol): Update.
2732         * minsyms.c (minimal_symbol_reader::record_full): Change signature
2733         to use gdb::string_view instead of name+len.
2734         * minsyms.h (class minimal_symbol_reader) <record_full>: Likewise.
2735         * psympriv.h (add_psymbol_to_list): Likewise.
2736         * psymtab.c (add_psymbol_to_bcache): Likewise.
2737         (add_psymbol_to_list): Likewise.
2738         * stabsread.c (define_symbol): Update.
2739         * symtab.c (symbol_set_names): Change signature to use gdb::string_view.
2740         * symtab.h (SYMBOL_SET_NAMES): Likewise.
2741         (symbol_set_names): Likewise.
2742         * xcoffread.c (scan_xcoff_symtab): Update.
2743
2744 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2745
2746         * symtab.h (symbol_set_names): Document that copy_name must be
2747         set to true for non-nullterminated strings.
2748         * symtab.c (symbol_set_names): Only make a nullterminated copy of
2749         linkage_name if the entry was not found and we need to demangle.
2750
2751 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2752
2753         * Makefile.in (HFILES_NO_SRCDIR): Add gdb_binary_search.h.
2754         * dwarf2-frame.c (bsearch_fde_cmp): Update.
2755         (dwarf2_frame_find_fde): Replace bsearch with gdb::binary_search.
2756         * gdbsupport/gdb_binary_search.h: New file.
2757
2758 2019-10-29  Christian Biesinger  <cbiesinger@google.com>
2759
2760         * NEWS: Mention new --with-system-gdbinit-dir option.
2761         * config.in: Regenerate.
2762         * configure: Regenerate.
2763         * configure.ac: Add new option --with-system-gdbinit-dir.
2764         * extension.c (get_ext_lang_of_file): Return extension_language_gdb
2765         for a ".gdb" suffix.
2766         * main.c (get_init_files): Change system_gdbinit argument to
2767         a vector and return the files in SYSTEM_GDBINIT_DIR in
2768         addition to SYSTEM_GDBINIT.
2769         (captured_main_1): Update.
2770         (print_gdb_help): Update.
2771         * top.c (print_gdb_configuration): Also print the value of
2772         SYSTEM_GDBINIT_DIR.
2773
2774 2019-10-28  Christian Biesinger  <cbiesinger@google.com>
2775
2776         * gdbsupport/common-utils.h (startswith): Add an overloaded version
2777         that takes gdb::string_view arguments.
2778
2779 2019-10-26  Tom de Vries  <tdevries@suse.de>
2780
2781         * aarch64-linux-tdep.c: Fix typos in comments.
2782         * aarch64-tdep.c: Same.
2783         * ada-lang.c: Same.
2784         * amd64-nat.c: Same.
2785         * arc-tdep.c: Same.
2786         * arch/aarch64-insn.c: Same.
2787         * block.c: Same.
2788         * breakpoint.h: Same.
2789         * btrace.h: Same.
2790         * c-varobj.c: Same.
2791         * cli/cli-decode.c: Same.
2792         * cli/cli-script.c: Same.
2793         * cli/cli-utils.h: Same.
2794         * coff-pe-read.c: Same.
2795         * coffread.c: Same.
2796         * compile/compile-cplus-symbols.c: Same.
2797         * compile/compile-object-run.c: Same.
2798         * completer.c: Same.
2799         * corelow.c: Same.
2800         * cp-support.c: Same.
2801         * demangle.c: Same.
2802         * dwarf-index-write.c: Same.
2803         * dwarf2-frame.c: Same.
2804         * dwarf2-frame.h: Same.
2805         * eval.c: Same.
2806         * frame-base.h: Same.
2807         * frame.h: Same.
2808         * gdbcmd.h: Same.
2809         * gdbtypes.h: Same.
2810         * gnu-nat.c: Same.
2811         * guile/scm-objfile.c: Same.
2812         * i386-tdep.c: Same.
2813         * i386-tdep.h: Same.
2814         * infcall.c: Same.
2815         * infcall.h: Same.
2816         * linux-nat.c: Same.
2817         * m68k-tdep.c: Same.
2818         * macroexp.c: Same.
2819         * memattr.c: Same.
2820         * mi/mi-cmd-disas.c: Same.
2821         * mi/mi-getopt.h: Same.
2822         * mi/mi-main.c: Same.
2823         * minsyms.c: Same.
2824         * nat/aarch64-sve-linux-sigcontext.h: Same.
2825         * objfiles.h: Same.
2826         * ppc-linux-nat.c: Same.
2827         * ppc-linux-tdep.c: Same.
2828         * ppc-tdep.h: Same.
2829         * progspace.h: Same.
2830         * prologue-value.h: Same.
2831         * python/py-evtregistry.c: Same.
2832         * python/py-instruction.h: Same.
2833         * record-btrace.c: Same.
2834         * record-full.c: Same.
2835         * remote.c: Same.
2836         * rs6000-tdep.c: Same.
2837         * ser-tcp.c: Same.
2838         * sol-thread.c: Same.
2839         * sparc-sol2-tdep.c: Same.
2840         * sparc64-tdep.c: Same.
2841         * stabsread.c: Same.
2842         * symfile.c: Same.
2843         * symtab.h: Same.
2844         * target.c: Same.
2845         * tracepoint.c: Same.
2846         * tui/tui-data.h: Same.
2847         * tui/tui-io.c: Same.
2848         * tui/tui-win.c: Same.
2849         * tui/tui.c: Same.
2850         * unittests/rsp-low-selftests.c: Same.
2851         * user-regs.h: Same.
2852         * utils.c: Same.
2853         * utils.h: Same.
2854         * valarith.c: Same.
2855         * valops.c: Same.
2856         * valprint.c: Same.
2857         * valprint.h: Same.
2858         * value.c: Same.
2859         * value.h: Same.
2860         * varobj.c: Same.
2861         * x86-nat.h: Same.
2862         * xtensa-tdep.c: Same.
2863
2864 2019-10-25  Ali Tamur <tamur@google.com>
2865
2866         * charset.c (find_charset_names): Reflect API change.
2867
2868 2019-10-25  Christian Biesinger  <cbiesinger@google.com>
2869
2870         * symtab.c (struct demangled_name_entry): Change demangled name
2871         to a unique_xmalloc_ptr<char>, now that we don't allocate it as
2872         part of the struct anymore.
2873         (symbol_set_names): No longer obstack allocate + copy the demangled
2874         name, just store the allocated name from bfd.
2875
2876 2019-10-25  Tom Tromey  <tromey@adacore.com>
2877
2878         * dwarf2-frame.c (dwarf2_cie_table): Now a typedef.
2879         (bsearch_cie_cmp, add_cie): Remove.
2880         (find_cie): Reimplement.
2881         (decode_frame_entry_1, decode_frame_entry): Change type.  Update.
2882         (dwarf2_build_frame_info): Update.
2883
2884 2019-10-24  H.J. Lu  <hongjiu.lu@intel.com>
2885
2886         PR gdb/25126
2887         * symfile.c (reread_symbols): Call forget_cached_source_info to
2888         clear the stale source cache.
2889
2890 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2891
2892         * configure: Regenerate.
2893         * configure.ac: Remove code that sets python_has_threads.
2894
2895 2019-10-24  Christian Biesinger  <cbiesinger@google.com>
2896
2897         * config.in: Regenerate.
2898         * configure: Regenerate.
2899         * configure.ac: Remove the code that uses sed to get the python
2900         version and defines HAVE_LIBPYTHON2_6 / HAVE_LIBPYTHON2_7.
2901
2902 2019-10-24  Andrew Burgess  <andrew.burgess@embecosm.com>
2903
2904         * python/py-progspace.c (pspy_block_for_pc): Return None for all
2905         error paths.
2906
2907 2019-10-23  Tom Tromey  <tom@tromey.com>
2908
2909         * arc-tdep.c: Remove ".." from include.
2910         * frv-tdep.c: Remove ".." from include.
2911         * lm32-tdep.c: Remove ".." from include.
2912         * microblaze-tdep.c: Remove ".." from include.
2913         * or1k-tdep.h: Remove ".." from include.
2914         * s12z-tdep.c: Remove ".." from include.
2915         * Makefile.in (OPCODES_CFLAGS): Add comment.
2916         (TOP_CFLAGS): New variable.
2917         (INTERNAL_CFLAGS_BASE): Add TOP_CFLAGS.
2918
2919 2019-10-23  Tom Tromey  <tom@tromey.com>
2920
2921         * Makefile.in (READLINE_DIR): Update.
2922
2923 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2924
2925         * infcall.c (call_function_by_hand_dummy): Fix the function
2926         comment.  And extract out a code section into...
2927         (reserve_stack_space): ...this new function.
2928
2929 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2930
2931         * infcall.c (value_arg_coerce): Remove an unused parameter.
2932         (call_function_by_hand_dummy): Update the call to
2933         'value_arg_coerce'.
2934
2935 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2936
2937         * infcall.c (call_function_by_hand_dummy): Refactor.
2938
2939 2019-10-23  Tankut Baris Aktemur  <tankut.baris.aktemur@intel.com>
2940
2941         * MAINTAINERS (Write After Approval): Add Tankut Baris Aktemur.
2942
2943 2019-10-23  Tom Tromey  <tom@tromey.com>
2944
2945         * configure: Rebuild.
2946         * configure.ac: Don't check for sigprocmask.
2947         * gdbsupport/common.m4 (GDB_AC_COMMON): Check for sigprocmask.
2948
2949 2019-10-23  Tom Tromey  <tom@tromey.com>
2950
2951         * configure: Rebuild.
2952         * acinclude.m4: Use m4_include, not sinclude.
2953
2954 2019-10-23  Tom de Vries  <tdevries@suse.de>
2955
2956         PR breakpoints/24687
2957         * symtab.c (iterate_over_some_symtabs): Apply gdb_realpath on fullname.
2958
2959 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2960
2961         * symtab.c (struct demangled_name_entry) <language>: Change from
2962         bitfield to regular variable.
2963
2964 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2965
2966         * symtab.c (struct demangled_name_entry): Add a constructor.
2967         (free_demangled_name_entry): New function to call the destructor
2968         for demangled_name_entry.
2969         (create_demangled_names_hash): Pass free_demangled_name_entry to
2970         htab_create_alloc.
2971         (symbol_set_names): Call placement new for demangled_name_entry.
2972         * utils.c: No longer include xxhash.h here, now that fast_hash
2973         is inlined in the header.
2974         * utils.h: Instead, include it here.
2975
2976 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2977
2978         * Makefile.in: Link with libxxhash.
2979         * config.in: Regenerate.
2980         * configure: Regenerate.
2981         * configure.ac: Search for libxxhash.
2982         * utils.c (fast_hash): Use xxhash if present.
2983
2984 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2985
2986         * utils.h (fast_hash): New function.
2987         * symtab.c (hash_demangled_name_entry): Call new function
2988         fast_hash.
2989
2990 2019-10-22  Christian Biesinger  <cbiesinger@google.com>
2991
2992         * symtab.c (struct demangled_name_entry): Change type of mangled
2993         to gdb::string_view. Also adds a constructor that takes the
2994         mangled name.
2995         (hash_demangled_name_entry): Update.
2996         (eq_demangled_name_entry): Update.
2997         (free_demangled_name_entry): New function to call the destructor
2998         now that this is not a POD anymore.
2999         (create_demangled_names_hash): Pass free_demangled_name_entry to
3000         htab_create_alloc.
3001         (symbol_set_names): Update.
3002
3003 2019-10-21  Ali Tamur  <tamu@google.com>
3004
3005         * dwarf2read.c (dir_index): Change type.
3006         (file_name_index): Likewise.
3007         (line_header::include_dir_at): Change comment and implementation on
3008         whether it is DWARF 5.
3009         (line_header::is_valid_file_index): New function.
3010         (line_header::file_name_at): Change comment and implementation on
3011         whether it is DWARF 5.
3012         (line_header::file_names): Change to private field renamed as
3013         m_file_names and introduce a new accessor method.
3014         (line_header::file_names_size): New method.
3015         (line_header::include_dirs): Change to private field and rename as
3016         m_include_dirs.
3017         (dw2_get_file_names_reader): Define local var at a smaller scope and
3018         reflect API change.
3019         (dwarf2_cu::setup_type_unit_groups): Reflect API change.
3020         (process_structure_scope): Likewise.
3021         (line_header::add_include_dir): Change message and reflect renaming.
3022         (line_header::add_file_name): Likewise.
3023         (read_formatted_entries): Handle DW_FORM_data16.
3024         (dwarf_decode_line_header): Fix line header length calculation.
3025         (psymtab_include_file_name): Change comment and API.
3026         (lnp_state_machine::m_file): Update comment and reflect type change.
3027         (lnp_state_machine::record_line): Reflect type change.
3028         (dwarf_decode_lines): Reflect API change.
3029         (file_file_name): Likewise.
3030         (file_full_name): Likewise.
3031
3032 2019-10-21  Andrew Burgess  <andrew.burgess@embecosm.com>
3033
3034         * objfiles.c (sort_cmp): Ensure that !(a < a) holds true.
3035
3036 2019-10-21  Tom Tromey  <tom@tromey.com>
3037
3038         * tui/tui-winsource.h (tui_exec_info_content): Remove typedef.
3039
3040 2019-10-21  Tom Tromey  <tom@tromey.com>
3041
3042         * configure.ac (nm.h): Conditionally create nm.h link.  Subst
3043         NM_H.   Use AC_CONFIG_LINKS.
3044         * configure: Rebuild.
3045         * Makefile.in (NM_H): New variable.
3046         (generated_files): Add NM_H.  Remove gcore.
3047         (nm.h, stamp-nmh): New targets.
3048
3049 2019-10-20  Tom Tromey  <tom@tromey.com>
3050
3051         * objfiles.h (unlink_objfile, put_objfile_before): Don't declare.
3052         * objfiles.c (unlink_objfile): Move earlier.  Now static.  Remove
3053         obsolete comment.
3054         (put_objfile_before): Now static.
3055
3056 2019-10-19  Simon Marchi  <simon.marchi@polymtl.ca>
3057
3058         * gdbsupport/common-utils.h (startswith): Change return type to
3059         bool.
3060
3061 2019-10-19  Christian Biesinger  <cbiesinger@google.com>
3062
3063         * bcache.c (bcache::print_statistics): Use std::sort instead of qsort.
3064         * breakpoint.c (bp_locations_compare): Rename to...
3065         (bp_location_is_less_than): ...this, and change to std::sort semantics.
3066         (update_global_location_list): Use std::sort instead of qsort.
3067         * buildsym.c (compare_line_numbers): Rename to...
3068         (lte_is_less_than): ...this, and change to std::sort semantics.
3069         (buildsym_compunit::end_symtab_with_blockvector): Use std::sort
3070         instead of qsort.
3071         * disasm.c (compare_lines): Rename to...
3072         (line_is_less_than): ...this, and change to std::sort semantics.
3073         (do_mixed_source_and_assembly_deprecated): Call std::sort instead
3074         of qsort.
3075         * dwarf2-frame.c (qsort_fde_cmp): Rename to...
3076         (fde_is_less_than): ...this, and change to std::sort semantics.
3077         (dwarf2_build_frame_info): Call std::sort instead of qsort.
3078         * mdebugread.c (compare_blocks):
3079         (block_is_less_than): ...this, and change to std::sort semantics.
3080         (sort_blocks): Call std::sort instead of qsort.
3081         * objfiles.c (qsort_cmp): Rename to...
3082         (sort_cmp): ...this, and change to std::sort semantics.
3083         (update_section_map): Call std::sort instead of qsort.
3084         * remote.c (compare_pnums): Remove.
3085         (map_regcache_remote_table): Call std::sort instead of qsort.
3086         * utils.c (compare_positive_ints): Remove.
3087         * utils.h (compare_positive_ints): Remove.
3088         * xcoffread.c (compare_lte): Remove.
3089         (arrange_linetable): Call std::sort instead of qsort.
3090
3091 2019-10-19  Sergio Durigan Junior  <sergiodj@redhat.com>
3092
3093         * symfile.c (init_entry_point_info): Fix typo.
3094         * i386-darwin-tdep.c (darwin_dwarf_signal_frame_p): Fix typo.
3095
3096 2019-10-18  Tom de Vries  <tdevries@suse.de>
3097
3098         * aarch64-tdep.c: Fix typos in comments.
3099         * ada-lang.c: Same.
3100         * ada-tasks.c: Same.
3101         * alpha-tdep.c: Same.
3102         * alpha-tdep.h: Same.
3103         * amd64-nat.c: Same.
3104         * amd64-windows-tdep.c: Same.
3105         * arc-tdep.c: Same.
3106         * arc-tdep.h: Same.
3107         * arch-utils.c: Same.
3108         * arm-nbsd-tdep.c: Same.
3109         * arm-tdep.c: Same.
3110         * ax-gdb.c: Same.
3111         * blockframe.c: Same.
3112         * btrace.c: Same.
3113         * c-varobj.c: Same.
3114         * coff-pe-read.c: Same.
3115         * coffread.c: Same.
3116         * cris-tdep.c: Same.
3117         * darwin-nat.c: Same.
3118         * dbxread.c: Same.
3119         * dcache.c: Same.
3120         * disasm.c: Same.
3121         * dtrace-probe.c: Same.
3122         * dwarf-index-write.c: Same.
3123         * dwarf2-frame-tailcall.c: Same.
3124         * dwarf2-frame.c: Same.
3125         * dwarf2read.c: Same.
3126         * eval.c: Same.
3127         * exceptions.c: Same.
3128         * fbsd-tdep.c: Same.
3129         * findvar.c: Same.
3130         * frame.c: Same.
3131         * frv-tdep.c: Same.
3132         * gnu-v3-abi.c: Same.
3133         * go32-nat.c: Same.
3134         * h8300-tdep.c: Same.
3135         * hppa-tdep.c: Same.
3136         * i386-linux-tdep.c: Same.
3137         * i386-tdep.c: Same.
3138         * ia64-libunwind-tdep.c: Same.
3139         * ia64-tdep.c: Same.
3140         * infcmd.c: Same.
3141         * infrun.c: Same.
3142         * linespec.c: Same.
3143         * linux-nat.c: Same.
3144         * linux-thread-db.c: Same.
3145         * machoread.c: Same.
3146         * mdebugread.c: Same.
3147         * mep-tdep.c: Same.
3148         * mn10300-tdep.c: Same.
3149         * namespace.c: Same.
3150         * objfiles.c: Same.
3151         * opencl-lang.c: Same.
3152         * or1k-tdep.c: Same.
3153         * osabi.c: Same.
3154         * ppc-linux-nat.c: Same.
3155         * ppc-linux-tdep.c: Same.
3156         * ppc-sysv-tdep.c: Same.
3157         * printcmd.c: Same.
3158         * procfs.c: Same.
3159         * record-btrace.c: Same.
3160         * record-full.c: Same.
3161         * remote-fileio.c: Same.
3162         * remote.c: Same.
3163         * rs6000-tdep.c: Same.
3164         * s12z-tdep.c: Same.
3165         * score-tdep.c: Same.
3166         * ser-base.c: Same.
3167         * ser-go32.c: Same.
3168         * skip.c: Same.
3169         * sol-thread.c: Same.
3170         * solib-svr4.c: Same.
3171         * solib.c: Same.
3172         * source.c: Same.
3173         * sparc-nat.c: Same.
3174         * sparc-sol2-tdep.c: Same.
3175         * sparc-tdep.c: Same.
3176         * sparc64-tdep.c: Same.
3177         * stabsread.c: Same.
3178         * stack.c: Same.
3179         * symfile.c: Same.
3180         * symtab.c: Same.
3181         * target-descriptions.c: Same.
3182         * target-float.c: Same.
3183         * thread.c: Same.
3184         * utils.c: Same.
3185         * valops.c: Same.
3186         * valprint.c: Same.
3187         * value.c: Same.
3188         * varobj.c: Same.
3189         * windows-nat.c: Same.
3190         * xcoffread.c: Same.
3191         * xstormy16-tdep.c: Same.
3192         * xtensa-tdep.c: Same.
3193
3194 2019-10-17  Tom Tromey  <tromey@adacore.com>
3195
3196         * configure: Rebuild.
3197         * configure.ac: Use AC_CONFIG_HEADERS.  Create stamp-h there, not
3198         in AC_CONFIG_FILES invocation.
3199         * Makefile.in (Makefile, data-directory/Makefile, stamp-h): Use
3200         new-style config.status invocation.
3201
3202 2019-10-17  Tom de Vries  <tdevries@suse.de>
3203
3204         * arm-nbsd-nat.c: Fix typos in comments.
3205         * arm-tdep.c: Same.
3206         * darwin-nat-info.c: Same.
3207         * dwarf2read.c: Same.
3208         * elfread.c: Same.
3209         * event-top.c: Same.
3210         * findvar.c: Same.
3211         * gdbtypes.c: Same.
3212         * hppa-tdep.c: Same.
3213         * i386-tdep.c: Same.
3214         * jit.c: Same.
3215         * main.c: Same.
3216         * mdebugread.c: Same.
3217         * moxie-tdep.c: Same.
3218         * nto-procfs.c: Same.
3219         * osabi.c: Same.
3220         * ppc-linux-tdep.c: Same.
3221         * remote.c: Same.
3222         * riscv-tdep.c: Same.
3223         * s390-tdep.c: Same.
3224         * sh-tdep.c: Same.
3225         * sparc-linux-tdep.c: Same.
3226         * sparc-nat.c: Same.
3227         * stack.c: Same.
3228         * target-descriptions.c: Same.
3229         * top.c: Same.
3230         * varobj.c: Same.
3231
3232 2019-10-16  Tom Tromey  <tom@tromey.com>
3233
3234         * objfiles.h (struct objfile) <original_name>: Now const.
3235
3236 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3237
3238         * gdbsupport/gdb_setjmp.h (SIGSETJMP): Allow passing in the value to
3239         pass on to sigsetjmp's second argument.
3240         * cp-support.c (gdb_demangle): Unblock SIGSEGV if we caught a crash.
3241
3242 2019-10-16  Keith Seitz  <keiths@redhat.com>
3243
3244         PR gdb/23567
3245         * dwarf2read.c (dwarf2_per_objfile::locate_sections): Discard
3246         sections whose size is greater than the file size.
3247
3248 2019-10-16  Jim Wilson  <jimw@sifive.com>
3249
3250         * riscv-tdep.c (riscv_gcc_target_options): New.
3251         (riscv_gnu_triplet_regexp): New.
3252         (riscv_gdbarch_init): Call set_gdbarch_gcc_triplet_options and
3253         set_gdbarch_gnu_triplet_regexp.
3254
3255 2019-10-16  Christian Biesinger  <cbiesinger@google.com>
3256
3257         * Makefile.in: Add xml-builtin.h.
3258         * features/feature_to_c.sh: Add an include for xml-builtin.h
3259         to ensure that the compiler checks that the types match.
3260         * xml-builtin.h: New file.
3261         * xml-support.c (fetch_xml_builtin): Add missing const.
3262         * xml-support.h: Remove declaration of xml_builtins.
3263
3264 2019-10-16  Tom de Vries  <tdevries@suse.de>
3265
3266         PR tdep/25096
3267         * amd64-tdep.c (amd64_classify_aggregate_field): Factor out of ...
3268         (amd64_classify_aggregate): ... here.
3269         (amd64_classify_aggregate_field): Handled fiels of nested structs
3270         recursively.
3271
3272 2019-10-16  Tom de Vries  <tdevries@suse.de>
3273
3274         PR tdep/24104
3275         * amd64-tdep.c (amd64_push_arguments): Handle AMD64_NO_CLASS in loop
3276         that handles 'theclass'.
3277
3278 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3279
3280         * linespec.c (decode_digits_ordinary): Update comment.
3281         * make-target-delegates: No longer need to handle VEC case.
3282         * memrange.c (normalize_mem_ranges): Update comment.
3283         * namespace.c (add_using_directive): Update comment.
3284         * objc-lang.c (uniquify_strings): Update comment.
3285         * ppc-linux-nat.c (struct thread_points): Update comment.
3286         * probe.h (find_probes_in_objfile): Update comment.
3287         * target.h (enum flash_preserve_mode): Update comment.
3288         * varobj.c (varobj_restrict_range): Update comment.
3289         * varobj.h (varobj_list_children): Update comment.
3290
3291 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3292
3293         * Makefile.in: Remove references to vec.h and vec.c.
3294         * aarch64-tdep.c: No longer include vec.h.
3295         * ada-lang.c: Likewise.
3296         * ada-lang.h: Likewise.
3297         * arm-tdep.c: Likewise.
3298         * ax.h: Likewise.
3299         * breakpoint.h: Likewise.
3300         * charset.c: Likewise.
3301         * cp-support.h: Likewise.
3302         * dtrace-probe.c: Likewise.
3303         * dwarf2read.c: Likewise.
3304         * extension.h: Likewise.
3305         * gdb_bfd.c: Likewise.
3306         * gdbsupport/gdb_vecs.h: Likewise.
3307         * gdbsupport/vec.c: Remove.
3308         * gdbsupport/vec.h: Remove.
3309         * gdbthread.h: Likewise.
3310         * guile/scm-type.c: Likewise.
3311         * inline-frame.c: Likewise.
3312         * machoread.c: Likewise.
3313         * memattr.c: Likewise.
3314         * memrange.h: Likewise.
3315         * namespace.h: Likewise.
3316         * nat/linux-btrace.h: Likewise.
3317         * osdata.c: Likewise.
3318         * parser-defs.h: Likewise.
3319         * progspace.h: Likewise.
3320         * python/py-type.c: Likewise.
3321         * record-btrace.c: Likewise.
3322         * rust-exp.y: Likewise.
3323         * solib-target.c: Likewise.
3324         * stap-probe.c: Likewise.
3325         * target-descriptions.c: Likewise.
3326         * target-memory.c: Likewise.
3327         * target.h: Likewise.
3328         * varobj.c: Likewise.
3329         * varobj.h: Likewise.
3330         * xml-support.h: Likewise.
3331
3332 2019-10-15  Andrew Burgess  <andrew.burgess@embecosm.com>
3333
3334         * gdb/dwarf2read.c (dwarf2_per_objfile::~dwarf2_per_objfile):
3335         Update for new std::vector based implementation.
3336         (process_psymtab_comp_unit_reader): Likewise.
3337         (scan_partial_symbols): Likewise.
3338         (recursively_compute_inclusions): Likewise.
3339         (compute_compunit_symtab_includes): Likewise.
3340         (process_imported_unit_die): Likewise.
3341         (queue_and_load_dwo_tu): Likewise.
3342         (follow_die_sig_1): Likewise.
3343         * gdb/dwarf2read.h: Remove DEF_VEC_P.
3344         (typedef dwarf2_per_cu_ptr): Remove.
3345         (struct dwarf2_per_cu_data) <imported_symtabs_empty>: New
3346         function.
3347         (struct dwarf2_per_cu_data) <imported_symtabs_push>: New function.
3348         (struct dwarf2_per_cu_data) <imported_symtabs_size>: New function.
3349         (struct dwarf2_per_cu_data) <imported_symtabs_free>: New function.
3350         (struct dwarf2_per_cu_data) <imported_symtabs>: Change to
3351         std::vector.
3352
3353 2019-10-15  Tom Tromey  <tromey@adacore.com>
3354
3355         * windows-nat.c (windows_nat_target::resume): Use %x when logging
3356         TID.
3357
3358 2019-10-15  Tom Tromey  <tromey@adacore.com>
3359
3360         * windows-nat.c (windows_nat_target::fetch_registers)
3361         (windows_nat_target::store_registers): Rename "pid" to "tid".
3362
3363 2019-10-15  Tom Tromey  <tromey@adacore.com>
3364
3365         * gdbarch.h, gdbarch.c: Rebuild.
3366         * gdbarch.sh (gcc_target_options): Change return type to
3367         std::string.
3368         * compile/compile.c (get_args): Update.
3369         * nios2-tdep.c (nios2_gcc_target_options): Return std::string.
3370         * arm-linux-tdep.c (arm_linux_gcc_target_options): Return
3371         std::string.
3372         * aarch64-linux-tdep.c (aarch64_linux_gcc_target_options): Return
3373         std::string.
3374         * arch-utils.c (default_gcc_target_options): Return std::string.
3375         * arch-utils.h (default_gcc_target_options): Return std::string.
3376         * s390-tdep.c (s390_gcc_target_options): Return std::string.
3377
3378 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3379
3380         * breakpoint.c (breakpoint_chain): Make static.
3381         * tui/tui-winsource.c: Call iterate_over_breakpoints instead
3382         of accessing breakpoint_chain.
3383
3384 2019-10-15  Christian Biesinger  <cbiesinger@google.com>
3385
3386         * breakpoint.c (iterate_over_breakpoints): Change function pointer
3387         to a gdb::function_view and return value to bool.
3388         * breakpoint.h (iterate_over_breakpoints): Likewise.
3389         * dummy-frame.c (pop_dummy_frame_bpt): Update.
3390         (pop_dummy_frame): Update.
3391         * guile/scm-breakpoint.c (bpscm_build_bp_list): Update.
3392         (gdbscm_breakpoints): Update.
3393         * python/py-breakpoint.c (build_bp_list): Update.
3394         (gdbpy_breakpoints): Update.
3395         * python/py-finishbreakpoint.c (bpfinishpy_detect_out_scope_cb):
3396         Update.
3397         (bpfinishpy_handle_stop): Update.
3398         (bpfinishpy_handle_exit): Update.
3399         * solib-svr4.c (svr4_update_solib_event_breakpoint): Update.
3400         (svr4_update_solib_event_breakpoints): Update.
3401
3402 2019-10-15  Andreas Arnez  <arnez@linux.ibm.com>
3403
3404         * s390-tdep.c (s390_effective_inner_type): Ignore static fields
3405         when unwrapping single-field structs.
3406
3407 2019-10-14  Simon Marchi  <simon.marchi@polymtl.ca>
3408
3409         * dwarf2read.c: Remove includes.
3410
3411 2019-10-13  Simon Marchi  <simon.marchi@polymtl.ca>
3412
3413         * ui-out.c (ui_out::call_do_message): Silence
3414         -Wformat-nonliteral warning.
3415
3416 2019-10-12  Simon Marchi  <simon.marchi@polymtl.ca>
3417
3418         * breakpoint.c: Remove some includes: continuations.h, skip.h,
3419         mi/mi-main.h, readline/readline.h, readline/history.h.  Add
3420         include: readline/tilde.h.
3421
3422 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3423
3424         * remote.c (remote_target::get_trace_status): Remove declaration of
3425         trace_regblock_size.
3426
3427 2019-10-12  Christian Biesinger  <cbiesinger@google.com>
3428
3429         * cli/cli-cmds.c (max_user_call_depth): Move comment to header.
3430         (show_user): Remove declaration of cmdlist.
3431         * cli/cli-cmds.h (max_user_call_depth): Declare.
3432         * cli/cli-script.c (execute_user_command): Remove declaration
3433         of max_user_call_depth.
3434
3435 2019-10-11  Jim Wilson  <jimw@sifive.com>
3436
3437         * gdbsupport/print-utils.h (pulongest): Fix comment.
3438         (plongest): Likewise.
3439         (phex): Add missing comment, mention leading zeros.
3440         (phex_nz): Add mention of no leading zeros to comment.
3441
3442         * riscv-tdep.c (riscv_push_dummy_code): Change %lld to %s and use
3443         plongest instead of unsigned long long cast.
3444
3445 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3446
3447         * main.c (captured_main_1): Include gdbtk.h and remove declarations
3448         for external_editor_command and gdbtk_test.
3449
3450 2019-10-10  Christian Biesinger  <cbiesinger@google.com>
3451
3452         * mi/mi-cmd-var.c (varobjdebug): Remove declaration.
3453         * varobj.c (varobjdebug): Move comment to...
3454         * varobj.h (varobjdebug): ...here, and declare.
3455
3456 2019-10-09  Tom Tromey  <tom@tromey.com>
3457
3458         * tui/tui-regs.c (tui_data_window::show_registers): Don't call
3459         erase_data_content.
3460
3461 2019-10-09  Tom Tromey  <tom@tromey.com>
3462
3463         * tui/tui-wingeneral.h (tui_delete_win): Don't declare.
3464         * tui/tui-stack.c (tui_locator_window::rerender): Update.
3465         * tui/tui-command.c (tui_cmd_window::resize)
3466         (tui_refresh_cmd_win): Update.
3467         * tui/tui-win.c (tui_resize_all, tui_set_focus_command): Update.
3468         * tui/tui.c (tui_rl_other_window, tui_enable): Update.
3469         * tui/tui-data.c (~tui_gen_win_info): Remove.
3470         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
3471         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
3472         (tui_redisplay_readline, tui_mld_flush)
3473         (tui_mld_erase_entire_line, tui_mld_getc, tui_getc): Update.
3474         * tui/tui-regs.c (tui_data_window::delete_data_content_windows)
3475         (tui_data_window::erase_data_content)
3476         (tui_data_item_window::rerender)
3477         (tui_data_item_window::refresh_window): Update.
3478         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window)
3479         (box_win, tui_gen_win_info::make_window)
3480         (tui_gen_win_info::make_visible): Update.
3481         (tui_delete_win): Remove.
3482         * tui/tui-winsource.c
3483         (tui_source_window_base::do_erase_source_content): Update.
3484         (tui_show_source_line, tui_source_window_base::update_tab_width)
3485         (tui_source_window_base::update_exec_info): Update.
3486         * tui/tui-data.h (struct curses_deleter): New.
3487         (struct tui_gen_win_info) <handle>: Now a unique_ptr.
3488         (struct tui_gen_win_info) <~tui_gen_win_info>: Define.
3489
3490 2019-10-09  Tom Tromey  <tom@tromey.com>
3491
3492         * tui/tui-wingeneral.h (struct tui_gen_win_info): Don't declare.
3493
3494 2019-10-09  Tom Tromey  <tom@tromey.com>
3495
3496         * tui/tui-data.c (tui_win_is_auxiliary): Remove.
3497         * tui/tui-data.h (tui_win_is_auxiliary): Don't declare.
3498
3499 2019-10-09  Tom Tromey  <tom@tromey.com>
3500
3501         * tui/tui-disasm.c (tui_get_low_disassembly_address): Compute
3502         window height directly.
3503         * tui/tui-layout.h (tui_default_win_viewport_height): Don't
3504         declare.
3505         * tui/tui-layout.c (tui_default_win_height): Remove.
3506         (tui_default_win_viewport_height): Remove.
3507
3508 2019-10-09  Tom Tromey  <tom@tromey.com>
3509
3510         * tui/tui.h: Remove comments.
3511
3512 2019-10-09  Tom de Vries  <tdevries@suse.de>
3513
3514         * python/lib/gdb/printer/bound_registers.py: Use
3515         '^builtin_type_bound128' as regexp argument for
3516         add_builtin_pretty_printer.
3517
3518 2019-10-09  Christian Biesinger  <cbiesinger@google.com>
3519
3520         * guile/guile.c (guile_extension_script_ops): Remove forward
3521         declaration and mark as static.
3522         (guile_script_ops): Likewise.
3523         (extension_language_guile): Move further down in the file so
3524         it can reference the definitions for guile_{extension_,}script_ops.
3525
3526 2019-10-09  Andreas Arnez  <arnez@linux.ibm.com>
3527
3528         * s390-tdep.c (390_process_record): Handle new arch13 instructions
3529         except SORTL, DFLTCC, and KDSA.
3530
3531 2019-10-08  Tom Tromey  <tromey@adacore.com>
3532
3533         * windows-nat.c (struct windows_thread_info_struct) <sf>: Remove.
3534         (struct safe_symbol_file_add_args): Remove.
3535
3536 2019-10-08  Tom Tromey  <tromey@adacore.com>
3537
3538         * windows-nat.c: Don't include buildsym-legacy.h.
3539
3540 2019-10-08  Tom Tromey  <tromey@adacore.com>
3541
3542         * contrib/ari/gdb_ari.sh (%p): Allow gdb-specific %p extensions.
3543
3544 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3545
3546         * gdbtypes.c (overload_debug): Move comment to header.
3547         * gdbtypes.h (overload_debug): Declare.
3548         * valops.c: Remove declaration of overload_debug, instead
3549         include gdbtypes.h.
3550
3551 2019-10-08  Christian Biesinger  <cbiesinger@google.com>
3552
3553         * language.c (show_language_command): Pass lang_frame_mismatch_warn
3554         through _().
3555         (lang_frame_mismatch_warn): Make const, mark with N_(), and
3556         move comment...
3557         * language.h (lang_frame_mismatch_warn): ... here. Also add
3558         declaration.
3559         * top.c (lang_frame_mismatch_warn): Remove declaration.
3560         (check_frame_language_change): Pass lang_frame_mismatch_warn
3561         through _().
3562
3563 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3564
3565         * c-lang.h (vtbl_ptr_name): Declare.
3566         * cp-valprint.c (vtbl_ptr_name): Remove "extern" now that we get
3567         it from the header.
3568         * stabsread.c (define_symbol): Remove declaration of vtbl_ptr_name.
3569
3570 2019-10-07  Christian Biesinger  <cbiesinger@google.com>
3571
3572         * charset.c (your_gdb_wchar_t_is_bogus): Replace with a
3573         gdb_static_assert.
3574
3575 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3576
3577         * ../Makefile.def (dependencies): Add all-libctf to all-gdb
3578         * ../Makefile.in: Add "all-gdb: maybe-all-libctf"
3579         * ctfread.c: New file.
3580         * ctfread.h: New file.
3581         * elfread.c: Include ctfread.h.
3582         (struct elfinfo text_p): New member ctfsect.
3583         (elf_locate_sections): Mark CTF section.
3584         (elf_symfile_read): Call elfctf_build_psymtabs.
3585         * Makefile.in (LIBCTF): Add.
3586         (CLIBS): Use it.
3587         (CDEPS): Likewise.
3588         (DIST): Add ctfread.c.
3589
3590 2019-10-07  Andrew Burgess  <andrew.burgess@embecosm.com>
3591
3592         * ctfread.c (struct nextfield): Renamed to ...
3593         (struct ctf_nextfield): ... this.
3594         (struct field_info): Renamed to ...
3595         (strut ctf_field_info): ... this.
3596         (attach_fields_to_type): Update for renamed structures.
3597         (ctf_add_member_cb): Likewise.
3598         (ctf_add_enum_member_cb): Likewise.
3599         (process_struct_members): Likewise.
3600         (process_enum_type): Likewise.
3601
3602 2019-10-07  Weimin Pan  <weimin.pan@oracle.com>
3603
3604         * tracectf.h: Rename, was ctf.h.
3605         * tracectf.c: Rename, was ctf.c, replace ctf.h with tracectf.h.
3606         * tracefile.c: Likewise.
3607         * tracepoint.c: Remove unused include ctf.h.
3608         * mi/mi-main.c: Likewise.
3609         * Makefile.in Replace ctf.c with tracectf.c.
3610
3611 2019-10-06  Joel Brobecker  <brobecker@adacore.com>
3612
3613         * version.in: Change version number to "9.0.50.DATE-git".
3614
3615 2019-10-03  Tom Tromey  <tom@tromey.com>
3616
3617         PR rust/24976:
3618         * dwarf2read.c (quirk_rust_enum): Handle single-element unions.
3619
3620 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3621
3622         * f-lang.c (f_language_defn): Use cp_get_symbol_name_matcher and
3623         cp_search_name_hash.
3624         * NEWS: Add entry about nested function support.
3625
3626 2019-10-03  Bernhard Heckel  <bernhard.heckel@intel.com>
3627             Andrew Burgess  <andrew.burgess@embecosm.com>
3628
3629         * cp-namespace.c (cp_search_static_and_baseclasses): Only search
3630         for nested static variables when searchin VAR_DOMAIN.
3631         * dwarf2read.c (add_partial_symbol): Add nested subroutines to the
3632         global scope, update comment.
3633         (add_partial_subprogram): Call add_partial_subprogram recursively
3634         for nested subroutines when processinng Fortran.
3635         (load_partial_dies): Process the child entities of a subprogram
3636         when processing Fortran.
3637         (partial_die_parent_scope): Handle building scope
3638         for Fortran nested functions.
3639         (process_die): Record that nested functions have a scope.
3640         (new_symbol): Always record Fortran subprograms on the global
3641         symbol list.
3642         (determine_prefix): How to build the prefix for Fortran
3643         subprograms.
3644
3645 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3646
3647         * linux-nat.c (linux_nat_filter_event): Don't ignore SIGSTOP if we
3648         have just sent the thread a SIGSTOP and are waiting for it to
3649         arrive.
3650
3651 2019-10-03  Andrew Burgess  <andrew.burgess@embecosm.com>
3652
3653         * btrace.c (btrace_add_pc): Remove whitespace before the template
3654         parameter in 'std::vector <...>'.
3655         (parse_xml_btrace_block): Likewise.
3656         (btrace_maint_decode_pt): Likewise.
3657         (btrace_maint_update_packets): Likewise.
3658         (btrace_maint_print_packets): Likewise.
3659         * btrace.h (struct btrace_maint_info): Likewise.
3660         * dwarf2read.c (struct type_unit_group): Likewise.
3661         (build_type_psymtabs_reader): Likewise.
3662         * gdbsupport/btrace-common.c (btrace_data_append): Likewise.
3663         * gdbsupport/btrace-common.h (struct btrace_data_bts): Likewise.
3664         * nat/linux-btrace.c (perf_event_read_bts): Likewise.
3665
3666 2019-10-03  Tom de Vries  <tdevries@suse.de>
3667
3668         * cli/cli-style.c (_initialize_cli_style): Adding a '.' at the end of
3669         the first line of the help text for set/show style metadata.
3670
3671 2019-10-02  Tom Tromey  <tromey@adacore.com>
3672
3673         * Makefile.in (COMMON_SFILES): Add common-inferior.c.
3674         * gdbsupport/common-inferior.c: New file.
3675         * infcmd.c (startup_with_shell): Don't define.
3676         * nat/fork-inferior.h (startup_with_shell): Don't declare.
3677         * gdbsupport/common-inferior.h (startup_with_shell): Declare.
3678         * inferior.h (startup_with_shell): Don't declare.
3679
3680 2019-10-02  Christian Biesinger  <cbiesinger@google.com>
3681
3682         * gdbsupport/gdb_assert.h: Include errors.h.
3683         * gdbsupport/gdb_string_view.h: Include gdb_assert.h.
3684
3685 2019-10-02  Tom Tromey  <tromey@adacore.com>
3686
3687         * NEWS: Add $_ada_exception entry.
3688         * ada-lang.c (struct ada_catchpoint): Add constructor.
3689         <m_kind>: New member.
3690         (allocate_location_exception, re_set_exception): Remove
3691         "ex" parameter.
3692         (should_stop_exception): Compute $_ada_exception.
3693         (check_status_exception, print_it_exception)
3694         (print_one_exception, print_mention_exception): Remove
3695         "ex" parameter.
3696         (allocate_location_catch_exception, re_set_catch_exception)
3697         (check_status_exception, print_it_catch_exception)
3698         (print_one_catch_exception, print_mention_catch_exception)
3699         (print_recreate_catch_exception)
3700         (allocate_location_catch_exception_unhandled)
3701         (re_set_catch_exception_unhandled)
3702         (check_status_exception, print_it_catch_exception_unhandled)
3703         (print_one_catch_exception_unhandled)
3704         (print_mention_catch_exception_unhandled)
3705         (print_recreate_catch_exception_unhandled)
3706         (allocate_location_catch_assert, re_set_catch_assert)
3707         (check_status_assert, print_it_catch_assert)
3708         (print_one_catch_assert, print_mention_catch_assert)
3709         (print_recreate_catch_assert)
3710         (allocate_location_catch_handlers, re_set_catch_handlers)
3711         (check_status_handlers, print_it_catch_handlers)
3712         (print_one_catch_handlers, print_mention_catch_handlers)
3713         (print_recreate_catch_handlers): Remove.
3714         (create_ada_exception_catchpoint): Update.
3715         (initialize_ada_catchpoint_ops): Update.
3716
3717 2019-10-02  Tom Tromey  <tromey@adacore.com>
3718
3719         * ada-lang.c (ada_lookup_simple_minsyms): Remove.
3720         (create_excep_cond_exprs): Simplify exception string computation.
3721         (ada_exception_catchpoint_cond_string): Likewise.
3722
3723 2019-10-02  Tom Tromey  <tromey@adacore.com>
3724
3725         * symmisc.c (dump_msymbols): Don't use MSYMBOL_VALUE_ADDRESS.
3726         * ada-lang.c (lesseq_defined_than): Handle
3727         LOC_STATIC.
3728         * dwarf2read.c (dwarf2_per_objfile): Add can_copy
3729         parameter.
3730         (dwarf2_has_info): Likewise.
3731         (new_symbol): Set maybe_copied on symbol when
3732         appropriate.
3733         * dwarf2read.h (dwarf2_per_objfile): Add can_copy
3734         parameter.
3735         <can_copy>: New member.
3736         * elfread.c (record_minimal_symbol): Set maybe_copied
3737         on symbol when appropriate.
3738         (elf_symfile_read): Update call to dwarf2_has_info.
3739         * minsyms.c (lookup_minimal_symbol_linkage): New
3740         function.
3741         * minsyms.h (lookup_minimal_symbol_linkage): Declare.
3742         * symtab.c (get_symbol_address, get_msymbol_address):
3743         New functions.
3744         * symtab.h (get_symbol_address, get_msymbol_address):
3745         Declare.
3746         (SYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_ADDRESS): Handle
3747         maybe_copied.
3748         (struct symbol, struct minimal_symbol) <maybe_copied>:
3749         New member.
3750
3751 2019-10-02  Tom Tromey  <tromey@adacore.com>
3752
3753         * source.c (struct current_source_location): New.
3754         (current_source_key): New global.
3755         (current_source_symtab, current_source_line)
3756         (current_source_pspace): Remove.
3757         (get_source_location): New function.
3758         (get_current_source_symtab_and_line)
3759         (set_default_source_symtab_and_line)
3760         (set_current_source_symtab_and_line)
3761         (clear_current_source_symtab_and_line, select_source_symtab)
3762         (info_source_command, print_source_lines_base)
3763         (info_line_command, search_command_helper, _initialize_source):
3764         Update.
3765
3766 2019-10-02  Tom Tromey  <tromey@adacore.com>
3767
3768         * source.c (select_source_symtab): Don't call
3769         decode_line_with_current_source.
3770
3771 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3772
3773         * symtab.c (lookup_global_symbol): Search global block.
3774
3775 2019-10-02  Tom Tromey  <tromey@adacore.com>
3776
3777         * coffread.c (process_coff_symbol): Update.
3778         * dwarf2read.c (var_decode_location, new_symbol): Update.
3779         * mdebugread.c (parse_symbol): Update.
3780         * objfiles.c (relocate_one_symbol): Update.
3781         * stabsread.c (define_symbol, fix_common_block)
3782         (scan_file_globals): Update.
3783         * symtab.h (SYMBOL_VALUE_ADDRESS): Expand to an rvalue.
3784         (SET_SYMBOL_VALUE_ADDRESS): New macro.
3785         * xcoffread.c (process_xcoff_symbol): Update.
3786
3787 2019-10-02  Andreas Arnez  <arnez@linux.ibm.com>
3788
3789         * MAINTAINERS: Update my email address.
3790
3791 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3792
3793         * dwarf2read.c (struct type_unit_group) <tus>: Convert to
3794         std::vector.
3795         (build_type_psymtabs_reader): Update for std::vector.
3796         (build_type_psymtab_dependencies): Likewise.
3797         * dwarf2read.h: Remove use of DEF_VEC_P.
3798         (typedef sig_type_ptr): Delete.
3799
3800 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3801
3802         * btrace.c (btrace_maint_clear): Update to handle change from VEC
3803         to std::vector.
3804         (btrace_maint_decode_pt): Likewise, and move allocation of the
3805         vector outside of the loop.
3806         (btrace_maint_update_packets): Update to handle change from VEC to
3807         std::vector.
3808         (btrace_maint_print_packets): Likewise.
3809         (maint_info_btrace_cmd): Likewise.
3810         * btrace.h: Remove use of DEF_VEC_O.
3811         (typedef btrace_pt_packet_s): Delete.
3812         (struct btrace_maint_info) <packets>: Change fromm VEC to
3813         std::vector.
3814         * gdbsupport/btrace-common.h: Remove 'vec.h' include.
3815
3816 2019-10-02  Andrew Burgess  <andrew.burgess@embecosm.com>
3817
3818         * btrace.c (btrace_compute_ftrace_bts): Update for std::vector,
3819         make accesses into the vector constant references.
3820         (btrace_add_pc): Update for std::vector.
3821         (btrace_stitch_bts): Likewise.
3822         (parse_xml_btrace_block): Likewise.
3823         (btrace_maint_update_packets): Likewise.
3824         (btrace_maint_print_packets): Likewise.
3825         (maint_info_btrace_cmd): Likewise.
3826         * gdbsupport/btrace-common.c (btrace_data::fini): Update for
3827         std::vector.
3828         (btrace_data::empty): Likewise.
3829         (btrace_data_append): Likewise.
3830         * gdbsupport/btrace-common.h: Remove use of DEF_VEC_O.
3831         (typedef btrace_block_s): Delete.
3832         (struct btrace_block): Add constructor.
3833         (struct btrace_data_bts) <blocks>: Change to std::vector.
3834         * nat/linux-btrace.c (perf_event_read_bts): Update for
3835         std::vector.
3836         (linux_read_bts): Likewise.
3837
3838 2019-10-01  Tom Tromey  <tom@tromey.com>
3839
3840         * cli/cli-logging.c (show_logging_filename): Use styled_string.
3841
3842 2019-10-01  Tom Tromey  <tom@tromey.com>
3843
3844         * stack.c (print_frame, info_frame_command_core): Use
3845         styled_string.
3846         * linux-thread-db.c (try_thread_db_load_1)
3847         (try_thread_db_load_from_pdir_1): Use styled_string.
3848         * auto-load.c (file_is_auto_load_safe, execute_script_contents)
3849         (auto_load_section_scripts, info_auto_load_local_gdbinit)
3850         (maybe_print_unsupported_script_warning)
3851         (maybe_print_script_not_found_warning): Use styled_string.
3852         * ada-lang.c (user_select_syms): Use styled_string.
3853
3854 2019-10-01  Tom Tromey  <tom@tromey.com>
3855
3856         * p-lang.c (pascal_printstr): Use metadata style.
3857         * value.c (show_convenience): Use metadata style.
3858         * valprint.c (valprint_check_validity, val_print_optimized_out)
3859         (val_print_not_saved, val_print_unavailable)
3860         (val_print_invalid_address, generic_val_print, val_print)
3861         (value_check_printable, val_print_array_elements): Use metadata
3862         style.
3863         * ui-out.h (class ui_out) <field_fmt>: New overload.
3864         <do_field_fmt>: Add style parameter.
3865         * ui-out.c (ui_out::field_fmt): New overload.
3866         * typeprint.c (type_print_unknown_return_type)
3867         (val_print_not_allocated, val_print_not_associated): Use metadata
3868         style.
3869         * tui/tui-out.h (class tui_ui_out) <do_field_fmt>: Add style
3870         parameter.
3871         * tui/tui-out.c (tui_ui_out::do_field_fmt): Update.
3872         * tracepoint.c (tvariables_info_1): Use metadata style.
3873         * stack.c (print_frame_arg, print_frame_info, print_frame)
3874         (info_frame_command_core): Use metadata style.
3875         * skip.c (info_skip_command): Use metadata style.
3876         * rust-lang.c (rust_print_enum): Use metadata style.
3877         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
3878         metadata style.
3879         * python/py-framefilter.c (py_print_single_arg): Use metadata
3880         style.
3881         * printcmd.c (do_one_display, print_variable_and_value): Use
3882         metadata style.
3883         * p-valprint.c (pascal_val_print)
3884         (pascal_object_print_value_fields): Use metadata style.
3885         * p-typeprint.c (pascal_type_print_base): Use metadata style.
3886         * mi/mi-out.h (class mi_ui_out) <do_field_fmt>: Add style
3887         parameter.
3888         * mi/mi-out.c (mi_ui_out::do_field_fmt): Update.
3889         * m2-valprint.c (m2_print_long_set): Use metadata style.
3890         * m2-typeprint.c (m2_print_type): Use metadata style.
3891         * infcmd.c (print_return_value_1): Use metadata style.
3892         * gnu-v3-abi.c (print_one_vtable): Use metadata style.
3893         * f-valprint.c (info_common_command_for_block): Use metadata
3894         style.
3895         * f-typeprint.c (f_type_print_base): Use metadata style.
3896         * expprint.c (print_subexp_standard): Use metadata style.
3897         * cp-valprint.c (cp_print_value_fields): Use metadata style.
3898         * cli/cli-style.h (class cli_style_option): Add constructor.
3899         (metadata_style): Declare.
3900         * cli/cli-style.c (metadata_style): New global.
3901         (_initialize_cli_style): Register metadata style.
3902         * cli-out.h (class cli_ui_out) <do_field_fmt>: Add style
3903         parameter.
3904         * cli-out.c (cli_ui_out::do_field_fmt): Update.
3905         * c-typeprint.c (c_type_print_base_struct_union)
3906         (c_type_print_base_1): Use metadata style.
3907         * breakpoint.c (watchpoint_value_print)
3908         (print_one_breakpoint_location): Use metadata style.
3909         * break-catch-syscall.c (print_one_catch_syscall): Use metadata
3910         style.
3911         * break-catch-sig.c (signal_catchpoint_print_one): Use metadata
3912         style.
3913         * ada-valprint.c (val_print_packed_array_elements, printstr)
3914         (print_field_values, ada_val_print_ref, ada_val_print): Use
3915         metadata style.
3916         * ada-typeprint.c (print_array_type, ada_print_type): Use metadata
3917         style.
3918         * ada-tasks.c (print_ada_task_info, info_task): Use metadata
3919         style.
3920         * ada-lang.c (user_select_syms): Use metadata style.
3921
3922 2019-10-01  Tom Tromey  <tom@tromey.com>
3923
3924         * cli/cli-cmds.c (pwd_command): Style output.
3925
3926 2019-10-01  Pedro Alves  <palves@redhat.com>
3927             Tom Tromey  <tom@tromey.com>
3928
3929         * symtab.c (print_symbol_info): Use %ps.
3930         (print_msymbol_info): Use %ps.
3931         * symfile.c (symbol_file_add_with_addrs): Use %ps.
3932         * printcmd.c (print_variable_and_value): Use %ps.
3933         * macrocmd.c (show_pp_source_pos): Use %ps.
3934         * infrun.c (print_exited_reason): Use ui_out::message.
3935         * breakpoint.c (watchpoint_check, print_one_breakpoint_location)
3936         (describe_other_breakpoints): Use ui_out::message and new
3937         formats.
3938         (say_where): Use new formats.
3939         (bkpt_print_it, tracepoint_print_one_detail): Use ui_out::message
3940         and new formats.
3941
3942 2019-10-01  Pedro Alves  <palves@redhat.com>
3943             Tom Tromey  <tom@tromey.com>
3944
3945         * unittests/format_pieces-selftests.c: Add gdb_format parameter.
3946         (test_gdb_formats): New function.
3947         (run_tests): Call it.
3948         (test_format_specifier): Update.
3949         * utils.h (fputs_filtered): Update comment.
3950         (vfprintf_styled, vfprintf_styled_no_gdbfmt)
3951         (fputs_styled_unfiltered): Declare.
3952         * utils.c (fputs_styled_unfiltered): New function.
3953         (vfprintf_maybe_filtered): Add gdbfmt parameter.
3954         (vfprintf_filtered): Update.
3955         (vfprintf_unfiltered, vprintf_filtered): Update.
3956         (vfprintf_styled, vfprintf_styled_no_gdbfmt): New functions.
3957         * ui-out.h (enum ui_out_flag) <unfiltered_output,
3958         disallow_ui_out_field>: New constants.
3959         (enum class field_kind): New.
3960         (struct base_field_s, struct signed_field_s): New.
3961         (signed_field): New function.
3962         (struct string_field_s): New.
3963         (string_field): New function.
3964         (struct styled_string_s): New.
3965         (styled_string): New function.
3966         (class ui_out) <message>: Add comment.
3967         <vmessage, call_do_message>: New methods.
3968         <do_message>: Add style parameter.
3969         * ui-out.c (ui_out::call_do_message, ui_out::vmessage): New
3970         methods.
3971         (ui_out::message): Rewrite.
3972         * mi/mi-out.h (class mi_ui_out) <do_message>: Add style
3973         parameter.
3974         * mi/mi-out.c (mi_ui_out::do_message): Add style parameter.
3975         * gdbsupport/format.h (class format_pieces) <format_pieces>: Add
3976         gdb_extensions parameter.
3977         (class format_piece): Add parameter to constructor.
3978         (n_int_args): New field.
3979         * gdbsupport/format.c (format_pieces::format_pieces): Add
3980         gdb_extensions parameter.  Handle '*'.
3981         * cli-out.h (class cli_ui_out) <do_message>: Add style parameter.
3982         * cli-out.c (cli_ui_out::do_message): Add style parameter.  Call
3983         vfprintf_styled_no_gdbfmt.
3984         (cli_ui_out::do_field_string, cli_ui_out::do_spaces)
3985         (cli_ui_out::do_text, cli_ui_out::field_separator): Allow
3986         unfiltered output.
3987         * ui-style.h (struct ui_file_style) <ptr>: New method.
3988
3989 2019-10-01  Tom Tromey  <tom@tromey.com>
3990
3991         * unittests/format_pieces-selftests.c: Update.  Add final format.
3992         * gdbsupport/format.c (format_pieces::format_pieces): Don't add
3993         empty literal pieces.
3994
3995 2019-10-01  Tom Tromey  <tom@tromey.com>
3996
3997         * ui-out.h (enum class ui_out_style_kind): Remove.
3998         (class ui_out) <field_string, field_stsream, do_field_string>:
3999         Change type of "style".
4000         * ui-out.c (ui_out::field_core_addr, ui_out::field_stream)
4001         (ui_out::field_string): Update.
4002         * tui/tui-out.h (class tui_ui_out) <do_field_string>: Change type
4003         of "style".
4004         * tui/tui-out.c (tui_ui_out::do_field_string): Update.
4005         * tracepoint.c (print_one_static_tracepoint_marker): Update.
4006         * stack.c (print_frame_arg, print_frame_info, print_frame):
4007         Update.
4008         * source.c (print_source_lines_base): Update.
4009         * solib.c (info_sharedlibrary_command): Update.
4010         * skip.c (info_skip_command): Update.
4011         * record-btrace.c (btrace_call_history_src_line)
4012         (btrace_call_history): Update.
4013         * python/py-framefilter.c (py_print_frame): Update.
4014         * mi/mi-out.h (class mi_ui_out) <do_field_string>: Change type of
4015         "style".
4016         * mi/mi-out.c (mi_ui_out::do_table_header)
4017         (mi_ui_out::do_field_signed, mi_ui_out::do_field_unsigned)
4018         (mi_ui_out::do_field_string): Update.
4019         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
4020         Update.
4021         * cli-out.h (class cli_ui_out) <do_field_string>: Change type of
4022         "style".
4023         * cli-out.c (cli_ui_out::do_table_header)
4024         (cli_ui_out::do_field_signed, cli_ui_out::do_field_unsigned)
4025         (cli_ui_out::do_field_skip, cli_ui_out::do_field_string)
4026         (cli_ui_out::do_field_fmt): Update.
4027         * breakpoint.c (print_breakpoint_location): Update.
4028         (update_static_tracepoint): Update.
4029
4030 2019-10-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4031
4032         * main.c (relocate_gdbinit_path_maybe_in_datadir): Remove std::string
4033         conversion of gdb_datadir.
4034         (captured_main_1): Remove xstrdup when assigning to gdb_datadir,
4035         remove not needed c_str ().
4036
4037 2019-09-30  Ali Tamur <tamur@google.com>
4038
4039         * dwarf2read.c (skip_one_die): Handle DW_FORM_strx forms.
4040         (dwarf2_string_attr): Likewise.
4041
4042 2019-09-30  Ali Tamur <tamur@google.com>
4043
4044         * dwarf2read.c (process_full_comp_unit): Remove whitespace at the EOL.
4045         (process_full_type_unit): Likewise.
4046         (dump_die_shallow): Likewise.
4047         (cu_debug_loc_section): Likewise.
4048
4049 2019-09-28  Christian Biesinger  <cbiesinger@google.com>
4050
4051         * minsyms.c (compare_minimal_symbols): Rename to...
4052         (minimal_symbol_is_less_than): ...this, and adjust to STL
4053         conventions (return bool, take arguments as references)
4054         (minimal_symbol_reader::install): Call std::sort instead
4055         of qsort.
4056
4057 2019-09-29  Christian Biesinger  <cbiesinger@google.com>
4058
4059         * minsyms.h (msymbol_hash): Document that this is a case-insensitive
4060         hash and why.
4061         * objfiles.h (struct objfile_per_bfd_storage) <demangled_names_hash,
4062         msymbol_hash, msymbol_demangled_hash>: Improve comments.
4063
4064 2019-09-30  Simon Marchi  <simon.marchi@polymtl.ca>
4065
4066         * psymtab.c (add_psymbol_to_list): Move comment to psympriv.h.
4067         * psympriv.h (add_psymbol_to_list): Move comment here and update
4068         it.
4069
4070 2019-09-29  Tom de Vries  <tdevries@suse.de>
4071
4072         * contrib/cc-with-tweaks.sh (get_tmpdir): New function.
4073         Use $tmpdir/$(basename "$output_file").dwz instead of
4074         "${output_file}.dwz".
4075
4076 2019-09-28  Simon Marchi  <simon.marchi@polymtl.ca>
4077
4078         PR gdb/25045
4079         * hppa-linux-nat.c: Include gdbarch.h.
4080
4081 2019-09-26  Christian Biesinger  <cbiesinger@google.com>
4082
4083         * blockframe.c (find_pc_partial_function): Change return type to bool.
4084         * elfread.c (elf_gnu_ifunc_resolve_name): Likewise.
4085         * minsyms.c (in_gnu_ifunc_stub): Likewise.
4086         (stub_gnu_ifunc_resolve_name): Likewise.
4087         * symtab.c (compare_filenames_for_search): Likewise.
4088         (compare_glob_filenames_for_search): Likewise.
4089         (matching_obj_sections): Likewise.
4090         (symbol_matches_domain): Likewise.
4091         (find_line_symtab): Change out param EXACT_MATCH to bool *.
4092         (find_line_pc): Change return type to bool.
4093         (find_line_pc_range): Likewise.
4094         (producer_is_realview): Likewise.
4095         * symtab.h (symbol_matches_domain): Likewise.
4096         (find_pc_partial_function): Likewise.
4097         (find_pc_line_pc_range): Likewise.
4098         (in_gnu_ifunc_stub): Likewise.
4099         (struct gnu_ifunc_fns) <gnu_ifunc_resolve_name>: Likewise.
4100         (find_line_pc): Likewise.
4101         (find_line_pc_range): Likewise.
4102         (matching_obj_sections): Likewise.
4103         (find_line_symtab): Change out parameter to bool.
4104         (producer_is_realview): Change return type to bool.
4105         (compare_filenames_for_search): Likewise.
4106         (compare_glob_filenames_for_search): Likewise.
4107
4108 2019-09-26  Tom Tromey  <tom@tromey.com>
4109
4110         * Makefile.in (COMMON_SFILES): Remove gdb_usleep.c.
4111         (HFILES_NO_SRCDIR): Remove gdb_usleep.h.
4112         * gdb_usleep.h: Remove.
4113         * gdb_usleep.c: Remove.
4114         * utils.c: Don't include gdb_usleep.h.
4115
4116 2019-09-26  Tom Tromey  <tromey@adacore.com>
4117
4118         * python/py-type.c (type_to_type_object): Call check_typedef
4119         for stub types.
4120
4121 2019-09-26  Tom Tromey  <tom@tromey.com>
4122
4123         * utils.h (initialize_utils): Don't declare.
4124         * top.c (gdb_init): Don't call initialize_utils.
4125         * utils.c (initialize_utils): Remove.  Move contents...
4126         (_initialize_utils): ... here.
4127
4128 2019-09-25  Tom Tromey  <tom@tromey.com>
4129
4130         * python/py-objfile.c (objfpy_get_build_id): Use bin2hex.
4131         * utils.h (make_hex_string): Don't declare.
4132         * utils.c (make_hex_string): Remove.
4133
4134 2019-09-24  Tom de Vries  <tdevries@suse.de>
4135
4136         PR gdb/23815
4137         * amd64-linux-nat.c (amd64_linux_nat_target::fetch_registers):
4138         Initialize xstateregs before ptrace PTRACE_GETREGSET call.
4139
4140 2019-09-23  Dimitar Dimitrov  <dimitar@dinux.eu>
4141
4142         * NEWS: Mention new simulator port for PRU.
4143
4144 2019-09-23  Christian Biesinger  <cbiesinger@google.com>
4145
4146         * ada-exp.y (write_object_remaining): Update.
4147         * ada-lang.c (ada_decode): Return a std::string instead of a char*
4148         and eliminate the static buffer.
4149         (ada_decode_symbol): Update.
4150         (ada_la_decode): Update.
4151         (ada_sniff_from_mangled_name): Update.
4152         (is_valid_name_for_wild_match): Update.
4153         (ada_lookup_name_info::matches): Update and simplify.
4154         (name_matches_regex): Update.
4155         (ada_add_global_exceptions): Update.
4156         * ada-lang.h (ada_decode): Update signature.
4157         * ada-varobj.c (ada_varobj_describe_simple_array_child): Update.
4158         * dwarf-index-write.c (debug_names::insert): Update.
4159
4160 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4161
4162         * solib-svr4.c (svr4_iterate_over_objfiles_in_search_order): Fix
4163         formatting.
4164
4165 2019-09-21  Simon Marchi  <simon.marchi@polymtl.ca>
4166
4167         * breakpoint.h (bp_location) <inserted, permanent, duplicate>:
4168         Change "nonzero" to "true" in documentation.
4169
4170 2019-09-20  Christian Biesinger  <cbiesinger@google.com>
4171
4172         * solib-darwin.c (darwin_lookup_lib_symbol): Remove.
4173         (_initialize_darwin_solib): Don't set
4174         darwin_so_ops.lookup_lib_global_symbol.
4175         * solib-svr4.c (set_solib_svr4_fetch_link_map_offsets): Call
4176         set_gdbarch_iterate_over_objfiles_in_search_order.
4177         (elf_lookup_lib_symbol): Rename to...
4178         (svr4_iterate_over_objfiles_in_search_order): this, and update
4179         to iterate semantics.
4180         (_initialize_svr4_solib): Don't set lookup_lib_global_symbol.
4181         * solib.c (solib_global_lookup): Remove.
4182         * solist.h (struct target_so_ops): Remove lookup_lib_global_symbol.
4183         (solib_global_lookup): Remove.
4184         * symtab.c (lookup_global_or_static_symbol): Remove call to
4185         solib_global_lookup.
4186
4187 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4188
4189         * NEWS: Move entries about default MI version now being
4190         version 3, and about the GDB/MI fix for multi-location
4191         breakpoints to the "since GDB 8.3" section.
4192
4193 2019-09-20  Joel Brobecker  <brobecker@adacore.com>
4194
4195         GDB 8.3.1 released.
4196
4197 2019-09-20  Ulrich Weigand  <uweigand@de.ibm.com>
4198
4199         * NEWS: Mention that Cell/B.E. debugging support was removed.
4200         * MAINTAINERS: Remove spu target.
4201
4202         * config/djgpp/fnchange.lst: Remove entries for removed files.
4203
4204         * Makefile.in (ALL_TARGET_OBS): Remove solib-spu.o,
4205         spu-multiarch.o, and spu-tdep.o.
4206         (HFILES_NO_SRCDIR): Remove solib-spu.h and spu-tdep.h.
4207         (ALLDEPFILES): Remove solib-spu.c, spu-linux-nat.c,
4208         spu-multiarch.c, and spu-tdep.c.
4209         * spu-linux-nat.c: Remove file.
4210         * spu-multiarch.c: Remove file.
4211         * spu-tdep.c: Remove file.
4212         * spu-tdep.h: Remove file.
4213         * solib-spu.c: Remove file.
4214         * solib-spu.h: Remove file.
4215
4216         * configure.host (powerpc64*-*-linux*): Remove Cell/B.E. support.
4217         * configure.nat (spu-linux): Remove.
4218         * configure.tgt (powerpc*-*-linux*): Remove solib-spu.o and
4219         solib-multiarch.o from gdb_target_obs.
4220         (spu*-*-*): Remove.
4221
4222         * arch/ppc-linux-common.h (struct ppc_linux_features): Remove "cell"
4223         feature flag.
4224         (ppc_linux_no_features): Update.
4225         * arch/ppc-linux-common.c (ppc_linux_match_description): Remove
4226         Cell/B.E. support.
4227         * arch/ppc-linux-tdesc.h (tdesc_powerpc_cell32l): Remove declaration.
4228         (tdesc_powerpc_cell64l): Likewise.
4229         * nat/ppc-linux.h (PPC_FEATURE_CELL): Remove.
4230         * ppc-linux-nat.c (ppc_linux_nat_target::read_description): Remove
4231         Cell/B.E. support.
4232         * ppc-linux-tdep.h: Do not include "solib-spu.h" or "spu-tdep.h".
4233         Do not include "features/rs6000/powerpc-cell32l.c" or
4234         "features/rs6000/powerpc-cell64l.c".
4235         (ppc_linux_spu_section): Remove.
4236         (ppc_linux_core_read_description): Remove Cell/B.E. support.
4237         (spe_context_objfile, spe_context_lm_addr, spe_context_offset,
4238         spe_context_cache_ptid, spe_context_cache_ptid): Remove.
4239         (ppc_linux_spe_context_lookup): Remove.
4240         (ppc_linux_spe_context_inferior_created): Remove.
4241         (ppc_linux_spe_context_solib_loaded): Remove.
4242         (ppc_linux_spe_context_solib_unloaded): Remove.
4243         (ppc_linux_spe_context): Remove.
4244         (struct ppu2spu_cache): Remove.
4245         (ppu2spu_prev_arch, ppu2spu_this_id, ppu2spu_prev_register): Remove.
4246         (struct ppu2spu_data): Remove.
4247         (ppu2spu_unwind_register, ppu2spu_sniffer, ppu2spu_dealloc_cache,
4248         ppu2spu_unwind): Remove.
4249         (ppc_linux_init_abi): Remove Cell/B.E. support.
4250         * rs6000-tdep.h (rs6000_gdbarch_init): Remove Cell/B.E. support.
4251
4252         * features/Makefile (rs6000/powerpc-cell32l-expedite): Remove.
4253         (rs6000/powerpc-cell64l-expedite): Likewise
4254         (WHICH): Remove rs6000/powerpc-cell32l and rs6000/powerpc-cell64l.
4255         (XMLTOC): Remove rs6000/powerpc-cell32l.xml and
4256         rs6000/powerpc-cell64l.xml.
4257         * features/rs6000/powerpc-cell32l.xml: Remove.
4258         * features/rs6000/powerpc-cell64l.xml: Likewise.
4259         * features/rs6000/powerpc-cell32l.c: Remove generated file.
4260         * features/rs6000/powerpc-cell64l.c: Likewise.
4261         * regformats/rs6000/powerpc-cell32l.dat: Remove generated file.
4262         * regformats/rs6000/powerpc-cell64l.dat: Likewise.
4263         * regformats/reg-spu.dat: Remove.
4264
4265         * target.h (enum target_object): Remove TARGET_OBJECT_SPU.
4266         * corelow.c (struct spuid_list): Remove.
4267         (add_to_spuid_list): Remove.
4268         (core_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4269         * remote.c (PACKET_qXfer_spu_read, PACKET_qXfer_spu_write): Remove.
4270         (remote_protocol_features): Remove associated entries.
4271         (_initialize_remote): No longer initialize them.
4272         (remote_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4273         * linux-nat.c (SPUFS_MAGIC): Remove.
4274         (linux_proc_xfer_spu): Remove.
4275         (spu_enumerate_spu_ids): Remove.
4276         (linux_nat_target::xfer_partial): Remove support for TARGET_OBJECT_SPU.
4277         * linux-tdep.c (-linux_spu_make_corefile_notes): Remove.
4278         (linux_make_corefile_notes): No longer call it.
4279
4280         * regcache.c (cooked_read_test): Remove bfd_arch_spu special case.
4281         (cooked_write_test): Likewise.
4282
4283 2019-09-20  Tom Tromey  <tom@tromey.com>
4284
4285         * NEWS: Mention case-sensitivity of TUI commands.
4286         * tui/tui-win.c (tui_set_focus_command): Now case-sensitive.
4287         (tui_set_win_height_command, parse_scrolling_args): Likewise.
4288         * tui/tui-layout.c (tui_layout_command): Now case-sensitive.
4289
4290 2019-09-20  Tom Tromey  <tom@tromey.com>
4291
4292         * tui/tui-source.c (tui_source_window::set_contents): Use
4293         make_unique_xstrdup.
4294         * tui/tui-disasm.c (tui_disasm_window::set_contents): Use
4295         make_unique_xstrdup.
4296
4297 2019-09-20  Tom Tromey  <tom@tromey.com>
4298
4299         * tui/tui-data.c: Remove separator comments.
4300         * tui/tui-layout.c: Remove separator comments.
4301         * tui/tui-win.c: Remove separator comments.
4302         * tui/tui-wingeneral.c: Remove separator comments.
4303
4304 2019-09-20  Tom Tromey  <tom@tromey.com>
4305
4306         * tui/tui.h (strcat_to_buf): Don't declare.
4307         * tui/tui.c (strcat_to_buf): Remove.
4308
4309 2019-09-20  Tom Tromey  <tom@tromey.com>
4310
4311         * tui/tui-source.h (struct tui_source_window) <m_fullname>: Rename
4312         from "fullname".
4313         * tui/tui-source.c (tui_source_window::set_contents)
4314         (tui_source_window::location_matches_p)
4315         (tui_source_window::maybe_update): Update.
4316
4317 2019-09-20  Tom Tromey  <tom@tromey.com>
4318
4319         * tui/tui-regs.h (struct tui_data_window) <get_current_group>:
4320         Update.
4321         <m_regs_content, m_regs_column_count, m_current_group>: Add "m_"
4322         prefix.
4323         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
4324         (tui_data_window::line_from_reg_element_no)
4325         (tui_data_window::first_reg_element_no_inline)
4326         (tui_data_window::show_registers)
4327         (tui_data_window::show_register_group)
4328         (tui_data_window::display_registers_from)
4329         (tui_data_window::display_registers_from_line)
4330         (tui_data_window::first_data_item_displayed)
4331         (tui_data_window::delete_data_content_windows)
4332         (tui_data_window::erase_data_content)
4333         (tui_data_window::do_scroll_vertical)
4334         (tui_data_window::refresh_window)
4335         (tui_data_window::check_register_values): Update.
4336
4337 2019-09-20  Tom Tromey  <tom@tromey.com>
4338
4339         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN): Remove define.
4340         (struct tui_locator_window) <full_name, proc_name>: Now
4341         std::string.
4342         * tui/tui-stack.c (tui_locator_window::make_status_line)
4343         (tui_locator_window::set_locator_fullname)
4344         (tui_locator_window::set_locator_info): Update.
4345         * tui/tui-source.c (tui_source_window::set_contents)
4346         (tui_source_window::showing_source_p): Update.
4347
4348 2019-09-20  Tom Tromey  <tom@tromey.com>
4349
4350         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
4351         Don't call tui_locator_win_info_ptr.
4352
4353 2019-09-20  Tom Tromey  <tom@tromey.com>
4354
4355         * tui/tui-win.c (tui_resize_all): Don't call refresh.
4356
4357 2019-09-20  Tom Tromey  <tom@tromey.com>
4358
4359         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use 1 as
4360         height for locator.
4361         * tui/tui-stack.c (tui_locator_window::rerender): Call scrollok.
4362         * tui/tui-layout.c (show_source_disasm_command, show_data)
4363         (show_source_or_disasm_and_command): Use 1 as height for locator.
4364
4365 2019-09-20  Tom Tromey  <tom@tromey.com>
4366
4367         * tui/tui.c (tui_enable): Update.
4368         * tui/tui-win.c (tui_sigwinch_handler, tui_async_resize_screen):
4369         Update.
4370         * tui/tui-data.h (tui_win_resized, tui_set_win_resized_to):
4371         Update.
4372         * tui/tui-data.c (win_resized): Now bool.
4373         (tui_win_resized): Return bool.
4374         (tui_set_win_resized_to): Accept a bool.
4375
4376 2019-09-20  Tom Tromey  <tom@tromey.com>
4377
4378         * tui/tui-regs.h (struct tui_data_window) <show_register_group>:
4379         Change type of "refresh_values_only".
4380         * tui/tui-regs.c (tui_data_window::show_register_group): Change
4381         type of "refresh_values_only".
4382
4383 2019-09-20  Tom Tromey  <tom@tromey.com>
4384
4385         * tui/tui-disasm.c (struct tui_asm_line) <addr_string, insn>: Now
4386         std::string.
4387         (tui_disassemble): Add "pos" parameter.
4388         (tui_disasm_window::set_contents): Simplify.
4389
4390 2019-09-20  Tom Tromey  <tom@tromey.com>
4391
4392         * tui/tui-winsource.h (struct tui_source_window_base)
4393         <show_source_content>: Now private.
4394         * tui/tui-winsource.c
4395         (tui_source_window_base::show_source_content): Don't handle empty
4396         content case.
4397
4398 2019-09-20  Tom Tromey  <tom@tromey.com>
4399
4400         * tui/tui-layout.c (show_source_disasm_command)
4401         (show_source_or_disasm_and_command): Don't call
4402         show_source_content.
4403
4404 2019-09-20  Tom Tromey  <tom@tromey.com>
4405
4406         * tui/tui-stack.h (struct tui_locator_window) <make_status_line>:
4407         Declare.
4408         * tui/tui-stack.c (tui_locator_window::make_status_line): Rename
4409         from tui_make_status_line.
4410         (tui_locator_window::rerender): Update.
4411
4412 2019-09-20  Tom Tromey  <tom@tromey.com>
4413
4414         * tui/tui-stack.c (tui_make_status_line): Return std::string.
4415         (tui_locator_window::rerender): Update.
4416
4417 2019-09-20  Tom Tromey  <tom@tromey.com>
4418
4419         * tui/tui-winsource.h (struct tui_source_window_base)
4420         <~tui_source_window_base>: Don't declare.
4421         <fullname>: Remove.
4422         * tui/tui-winsource.c (~tui_source_window_base): Remove.
4423         * tui/tui-source.h (struct tui_source_window) <fullname>: New
4424         member.
4425         * tui/tui-source.c (tui_source_window::set_contents): Update.
4426         (tui_source_window::location_matches_p)
4427         (tui_source_window::maybe_update): Update.
4428
4429 2019-09-20  Tom Tromey  <tom@tromey.com>
4430
4431         * tui/tui-winsource.h (~tui_source_element): Remove.
4432         (tui_source_element): Update.
4433         (struct tui_source_element) <line>: Now a unique_xmalloc_ptr.
4434         * tui/tui-winsource.c (tui_show_source_line): Update.
4435         * tui/tui-source.c (tui_source_window::set_contents): Update.
4436         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
4437
4438 2019-09-20  Tom Tromey  <tom@tromey.com>
4439
4440         * tui/tui-data.h (tui_clear_source_windows_detail): Don't
4441         declare.
4442         * tui/tui-layout.c (tui_add_win_to_layout): Don't call
4443         tui_clear_source_windows_detail.
4444         * tui/tui-winsource.h (struct tui_source_window_base)
4445         <clear_detail>: Don't declare.
4446         * tui/tui-winsource.c (tui_source_window_base::clear_detail):
4447         Remove.
4448         * tui/tui-data.c (tui_clear_source_windows_detail): Remove.
4449
4450 2019-09-20  Tom Tromey  <tromey@adacore.com>
4451
4452         PR ada/24919:
4453         * block.c (contained_in): Fix final return value.
4454
4455 2019-09-20  Alan Modra  <amodra@gmail.com>
4456
4457         * gdb_bfd.c (gdb_bfd_ref, gdb_bfd_unref): Use bfd_set_usrdata.
4458         * dwarf2read.c (dwarf2_read_gdb_index, dwarf2_read_debug_names),
4459         (read_indirect_string_from_dwz): Use bfd accessor.
4460         * dwarf2read.h (struct dwz_file <filename>): Likewise.
4461         * machoread.c (macho_symfile_read_all_oso): Likewise.
4462         * solib.c (solib_bfd_open): Likewise.
4463
4464 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4465
4466         * eval.c: Move declaration of overload_resolution to...
4467         * value.h: ...here.
4468
4469 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4470
4471         * arm-linux-nat.c: Remove extern declaration for arm_apcs_32.
4472         * arm-linux-tdep.c: Likewise.
4473         * arm-nbsd-nat.c: Likewise.
4474         * arm-tdep.h: Declare arm_apcs_32.
4475         * arm-tdep.c: Move documentation for arm_apcs_32 to arm-tdep.h.
4476
4477 2019-09-19  Christian Biesinger  <cbiesinger@google.com>
4478
4479         * dwarf2loc.c: Remove extern declaration of dwarf_always_disassemble.
4480         * dwarf2read.h: Declare dwarf_always_disassemble.
4481
4482 2019-09-19  Tom de Vries  <tdevries@suse.de>
4483
4484         PR gdb/25009
4485         * source-cache.c (source_cache::ensure): Catch exception thrown during
4486         construction of the highlighter.
4487
4488 2019-09-18  Alan Modra  <amodra@gmail.com>
4489
4490         * aarch64-linux-tdep.c, * arm-tdep.c, * auto-load.c,
4491         * coff-pe-read.c, * coffread.c, * corelow.c, * dbxread.c,
4492         * dicos-tdep.c, * dwarf2-frame.c, * dwarf2read.c, * elfread.c,
4493         * exec.c, * fbsd-tdep.c, * gcore.c, * gdb_bfd.c, * gdb_bfd.h,
4494         * hppa-tdep.c, * i386-cygwin-tdep.c, * i386-fbsd-tdep.c,
4495         * i386-linux-tdep.c, * jit.c, * linux-tdep.c, * machoread.c,
4496         * maint.c, * mdebugread.c, * minidebug.c, * mips-linux-tdep.c,
4497         * mips-sde-tdep.c, * mips-tdep.c, * mipsread.c, * nto-tdep.c,
4498         * objfiles.c, * objfiles.h, * osabi.c, * ppc-linux-tdep.c,
4499         * ppc64-tdep.c, * record-btrace.c, * record-full.c, * remote.c,
4500         * rs6000-aix-tdep.c, * rs6000-tdep.c, * s390-linux-tdep.c,
4501         * s390-tdep.c, * solib-aix.c, * solib-dsbt.c, * solib-frv.c,
4502         * solib-spu.c, * solib-svr4.c, * solib-target.c,
4503         * spu-linux-nat.c, * spu-tdep.c, * symfile-mem.c, * symfile.c,
4504         * symmisc.c, * symtab.c, * target.c, * windows-nat.c,
4505         * xcoffread.c, * cli/cli-dump.c, * compile/compile-object-load.c,
4506         * mi/mi-interp.c: Update throughout for bfd section macro and
4507         function changes.
4508         * gcore (gcore_create_callback): Use bfd_set_section_lma.
4509         * spu-tdep.c (spu_overlay_new_objfile): Likewise.
4510
4511 2019-09-18  Tom Tromey  <tom@tromey.com>
4512
4513         * NEWS: Add entry.
4514         * tui/tui.c (tui_initialize_readline): Set name of keymap.  Do not
4515         call rl_initialize.
4516         (tui_enable): Do not call rl_initialize.
4517
4518 2019-09-18  Christian Groessler  <chris@groessler.org>
4519
4520         * alpha-linux-nat.c: Include gdbarch.h.
4521
4522 2019-09-18  Simon Marchi  <simon.marchi@polymtl.ca>
4523
4524         * ui-file.c: Include cli/cli-style.h.
4525         (term_cli_styling): Remove cli_styling declaration.
4526
4527 2019-09-18  Alan Modra  <amodra@gmail.com>
4528
4529         * arm-tdep.c (arm_record_special_symbol): Update bfd_get_section
4530         to bfd_asymbol_section.
4531
4532 2019-09-18  Alan Modra  <amodra@gmail.com>
4533
4534         * amd64-dicos-tdep.c (amd64_dicos_osabi_sniffer): Constify target.
4535         * i386-cygwin-tdep.c (i386_cygwin_init_abi): Likewise.
4536         * i386-dicos-tdep.c (i386_dicos_osabi_sniffer): Likewise.
4537
4538 2019-09-18  Alan Modra  <amodra@gmail.com>
4539
4540         * solib-spu.c (spu_bfd_open): Use bfd_set_filename.
4541         * spu-linux-nat.c (spu_bfd_open): Likewise.
4542
4543 2019-09-18  Christian Biesinger  <cbiesinger@google.com>
4544
4545         * dwarf2loc.c: Change extern declaration of dwarf_always_disassemble
4546         to bool to match definition in dwarf2read.c.
4547
4548 2019-09-17  Christian Biesinger  <cbiesinger@google.com>
4549
4550         * ada-lang.c (ada_ignore_descriptive_types_p): Change to bool.
4551         (print_signatures): Likewise.
4552         (trust_pad_over_xvs): Likewise.
4553         * arch/aarch64-insn.c (aarch64_debug): Likewise.
4554         * arch/aarch64-insn.h (aarch64_debug): Likewise.
4555         * arm-linux-nat.c (arm_apcs_32): Likewise.
4556         * arm-linux-tdep.c (arm_apcs_32): Likewise.
4557         * arm-nbsd-nat.c (arm_apcs_32): Likewise.
4558         * arm-tdep.c (arm_debug): Likewise.
4559         (arm_apcs_32): Likewise.
4560         * auto-load.c (debug_auto_load): Likewise.
4561         (auto_load_gdb_scripts): Likewise.
4562         (global_auto_load): Likewise.
4563         (auto_load_local_gdbinit): Likewise.
4564         (auto_load_local_gdbinit_loaded): Likewise.
4565         * auto-load.h (global_auto_load): Likewise.
4566         (auto_load_local_gdbinit): Likewise.
4567         (auto_load_local_gdbinit_loaded): Likewise.
4568         * breakpoint.c (disconnected_dprintf): Likewise.
4569         (breakpoint_proceeded): Likewise.
4570         (automatic_hardware_breakpoints): Likewise.
4571         (always_inserted_mode): Likewise.
4572         (target_exact_watchpoints): Likewise.
4573         (_initialize_breakpoint): Update.
4574         * breakpoint.h (target_exact_watchpoints): Change to bool.
4575         * btrace.c (maint_btrace_pt_skip_pad): Likewise.
4576         * cli/cli-cmds.c (trace_commands): Likewise.
4577         * cli/cli-cmds.h (trace_commands): Likewise.
4578         * cli/cli-decode.c (add_setshow_boolean_cmd): Change int* argument
4579         to bool*.
4580         * cli/cli-logging.c (logging_overwrite): Change to bool.
4581         (logging_redirect): Likewise.
4582         (debug_redirect): Likewise.
4583         * cli/cli-option.h (option_def) <boolean>: Change return type to bool*.
4584         (struct boolean_option_def) <get_var_address_cb_>: Change return type
4585         to bool.
4586         <boolean_option_def>: Update.
4587         (struct flag_option_def): Change default type of Context to bool
4588         from int.
4589         <flag_option_def>: Change return type of var_address_cb_ to bool*.
4590         * cli/cli-setshow.c (do_set_command): Cast to bool* instead of int*.
4591         (get_setshow_command_value_string): Likewise.
4592         * cli/cli-style.c (cli_styling): Change to bool.
4593         (source_styling): Likewise.
4594         * cli/cli-style.h (source_styling): Likewise.
4595         (cli_styling): Likewise.
4596         * cli/cli-utils.h (struct qcs_flags) <quiet, cont, silent>: Change
4597         to bool.
4598         * command.h (var_types): Update comment.
4599         (add_setshow_boolean_cmd): Change int* var argument to bool*.
4600         * compile/compile-cplus-types.c (debug_compile_cplus_types): Change to
4601         bool.
4602         (debug_compile_cplus_scopes): Likewise.
4603         * compile/compile-internal.h (compile_debug): Likewise.
4604         * compile/compile.c (compile_debug): Likewise.
4605         (struct compile_options) <raw>: Likewise.
4606         * cp-support.c (catch_demangler_crashes): Likewise.
4607         * cris-tdep.c (usr_cmd_cris_version_valid): Likewise.
4608         (usr_cmd_cris_dwarf2_cfi): Likewise.
4609         * csky-tdep.c (csky_debug): Likewise.
4610         * darwin-nat.c (enable_mach_exceptions): Likewise.
4611         * dcache.c (dcache_enabled_p): Likewise.
4612         * defs.h (info_verbose): Likewise.
4613         * demangle.c (demangle): Likewise.
4614         (asm_demangle): Likewise.
4615         * dwarf-index-cache.c (debug_index_cache): Likewise.
4616         * dwarf2-frame.c (dwarf2_frame_unwinders_enabled_p): Likewise.
4617         * dwarf2-frame.h (dwarf2_frame_unwinders_enabled_p): Likewise.
4618         * dwarf2read.c (check_physname): Likewise.
4619         (use_deprecated_index_sections): Likewise.
4620         (dwarf_always_disassemble): Likewise.
4621         * eval.c (overload_resolution): Likewise.
4622         * event-top.c (set_editing_cmd_var): Likewise.
4623         (exec_done_display_p): Likewise.
4624         * event-top.h (set_editing_cmd_var): Likewise.
4625         (exec_done_display_p): Likewise.
4626         * exec.c (write_files): Likewise.
4627         * fbsd-nat.c (debug_fbsd_lwp): Likewise
4628         (debug_fbsd_nat): Likewise.
4629         * frame.h (struct frame_print_options) <print_raw_frame_arguments>:
4630         Likewise.
4631         (struct set_backtrace_options) <backtrace_past_main>: Likewise.
4632         <backtrace_past_entry> Likewise.
4633         * gdb-demangle.h (demangle): Likewise.
4634         (asm_demangle): Likewise.
4635         * gdb_bfd.c (bfd_sharing): Likewise.
4636         * gdbcore.h (write_files): Likewise.
4637         * gdbsupport/common-debug.c (show_debug_regs): Likewise.
4638         * gdbsupport/common-debug.h (show_debug_regs): Likewise.
4639         * gdbthread.h (print_thread_events): Likewise.
4640         * gdbtypes.c (opaque_type_resolution): Likewise.
4641         (strict_type_checking): Likewise.
4642         * gnu-nat.c (gnu_debug_flag): Likewise.
4643         * guile/scm-auto-load.c (auto_load_guile_scripts): Likewise.
4644         * guile/scm-param.c (pascm_variable): Add boolval.
4645         (add_setshow_generic): Update.
4646         (pascm_param_value): Update.
4647         (pascm_set_param_value_x): Update.
4648         * hppa-tdep.c (hppa_debug): Change to bool..
4649         * infcall.c (may_call_functions_p): Likewise.
4650         (coerce_float_to_double_p): Likewise.
4651         (unwind_on_signal_p): Likewise.
4652         (unwind_on_terminating_exception_p): Likewise.
4653         * infcmd.c (startup_with_shell): Likewise.
4654         * inferior.c (print_inferior_events): Likewise.
4655         * inferior.h (startup_with_shell): Likewise.
4656         (print_inferior_events): Likewise.
4657         * infrun.c (step_stop_if_no_debug): Likewise.
4658         (detach_fork): Likewise.
4659         (debug_displaced): Likewise.
4660         (disable_randomization): Likewise.
4661         (non_stop): Likewise.
4662         (non_stop_1): Likewise.
4663         (observer_mode): Likewise.
4664         (observer_mode_1): Likewise.
4665         (set_observer_mode): Update.
4666         (sched_multi): Change to bool.
4667         * infrun.h (debug_displaced): Likewise.
4668         (sched_multi): Likewise.
4669         (step_stop_if_no_debug): Likewise.
4670         (non_stop): Likewise.
4671         (disable_randomization): Likewise.
4672         * linux-tdep.c (use_coredump_filter): Likewise.
4673         (dump_excluded_mappings): Likewise.
4674         * linux-thread-db.c (auto_load_thread_db): Likewise.
4675         (check_thread_db_on_load): Likewise.
4676         * main.c (captured_main_1): Update.
4677         * maint-test-options.c (struct test_options_opts) <flag_opt, xx1_opt,
4678         xx2_opt, boolean_opt>: Change to bool.
4679         * maint-test-settings.c (maintenance_test_settings_boolean): Likewise.
4680         * maint.c (maintenance_profile_p): Likewise.
4681         (per_command_time): Likewise.
4682         (per_command_space): Likewise.
4683         (per_command_symtab): Likewise.
4684         * memattr.c (inaccessible_by_default): Likewise.
4685         * mi/mi-main.c (mi_async): Likewise.
4686         (mi_async_1): Likewise.
4687         * mips-tdep.c (mips64_transfers_32bit_regs_p): Likewise.
4688         * nat/fork-inferior.h (startup_with_shell): Likewise.
4689         * nat/linux-namespaces.c (debug_linux_namespaces): Likewise.
4690         * nat/linux-namespaces.h (debug_linux_namespaces): Likewise.
4691         * nios2-tdep.c (nios2_debug): Likewise.
4692         * or1k-tdep.c (or1k_debug): Likewise.
4693         * parse.c (parser_debug): Likewise.
4694         * parser-defs.h (parser_debug): Likewise.
4695         * printcmd.c (print_symbol_filename): Likewise.
4696         * proc-api.c (procfs_trace): Likewise.
4697         * python/py-auto-load.c (auto_load_python_scripts): Likewise.
4698         * python/py-param.c (union parmpy_variable): Add "bool boolval" field.
4699         (set_parameter_value): Update.
4700         (add_setshow_generic): Update.
4701         * python/py-value.c (copy_py_bool_obj): Change argument from int*
4702         to bool*.
4703         * python/python.c (gdbpy_parameter_value): Cast to bool* instead of
4704         int*.
4705         * ravenscar-thread.c (ravenscar_task_support): Change to bool.
4706         * record-btrace.c (record_btrace_target::store_registers): Update.
4707         * record-full.c (record_full_memory_query): Change to bool.
4708         (record_full_stop_at_limit): Likewise.
4709         * record-full.h (record_full_memory_query): Likewise.
4710         * remote-notif.c (notif_debug): Likewise.
4711         * remote-notif.h (notif_debug): Likewise.
4712         * remote.c (use_range_stepping): Likewise.
4713         (interrupt_on_connect): Likewise.
4714         (remote_break): Likewise.
4715         * ser-tcp.c (tcp_auto_retry): Likewise.
4716         * ser-unix.c (serial_hwflow): Likewise.
4717         * skip.c (debug_skip): Likewise.
4718         * solib-aix.c (solib_aix_debug): Likewise.
4719         * spu-tdep.c (spu_stop_on_load_p): Likewise.
4720         (spu_auto_flush_cache_p): Likewise.
4721         * stack.c (struct backtrace_cmd_options) <full, no_filters, hide>:
4722         Likewise.
4723         (struct info_print_options) <quiet>: Likewise.
4724         * symfile-debug.c (debug_symfile): Likewise.
4725         * symfile.c (auto_solib_add): Likewise.
4726         (separate_debug_file_debug): Likewise.
4727         * symfile.h (auto_solib_add): Likewise.
4728         (separate_debug_file_debug): Likewise.
4729         * symtab.c (basenames_may_differ): Likewise.
4730         (struct filename_partial_match_opts) <dirname, basename>: Likewise.
4731         (struct info_print_options) <quiet, exclude_minsyms>: Likewise.
4732         (struct info_types_options) <quiet>: Likewise.
4733         * symtab.h (demangle): Likewise.
4734         (basenames_may_differ): Likewise.
4735         * target-dcache.c (stack_cache_enabled_1): Likewise.
4736         (code_cache_enabled_1): Likewise.
4737         * target.c (trust_readonly): Likewise.
4738         (may_write_registers): Likewise.
4739         (may_write_memory): Likewise.
4740         (may_insert_breakpoints): Likewise.
4741         (may_insert_tracepoints): Likewise.
4742         (may_insert_fast_tracepoints): Likewise.
4743         (may_stop): Likewise.
4744         (auto_connect_native_target): Likewise.
4745         (target_stop_and_wait): Update.
4746         (target_async_permitted): Change to bool.
4747         (target_async_permitted_1): Likewise.
4748         (may_write_registers_1): Likewise.
4749         (may_write_memory_1): Likewise.
4750         (may_insert_breakpoints_1): Likewise.
4751         (may_insert_tracepoints_1): Likewise.
4752         (may_insert_fast_tracepoints_1): Likewise.
4753         (may_stop_1): Likewise.
4754         * target.h (target_async_permitted): Likewise.
4755         (may_write_registers): Likewise.
4756         (may_write_memory): Likewise.
4757         (may_insert_breakpoints): Likewise.
4758         (may_insert_tracepoints): Likewise.
4759         (may_insert_fast_tracepoints): Likewise.
4760         (may_stop): Likewise.
4761         * thread.c (struct info_threads_opts) <show_global_ids>: Likewise.
4762         (make_thread_apply_all_options_def_group): Change argument from int*
4763         to bool*.
4764         (thread_apply_all_command): Update.
4765         (print_thread_events): Change to bool.
4766         * top.c (confirm): Likewise.
4767         (command_editing_p): Likewise.
4768         (history_expansion_p): Likewise.
4769         (write_history_p): Likewise.
4770         (info_verbose): Likewise.
4771         * top.h (confirm): Likewise.
4772         (history_expansion_p): Likewise.
4773         * tracepoint.c (disconnected_tracing): Likewise.
4774         (circular_trace_buffer): Likewise.
4775         * typeprint.c (print_methods): Likewise.
4776         (print_typedefs): Likewise.
4777         * utils.c (debug_timestamp): Likewise.
4778         (sevenbit_strings): Likewise.
4779         (pagination_enabled): Likewise.
4780         * utils.h (sevenbit_strings): Likewise.
4781         (pagination_enabled): Likewise.
4782         * valops.c (overload_resolution): Likewise.
4783         * valprint.h (struct value_print_options) <prettyformat_arrays,
4784         prettyformat_structs, vtblprint, unionprint, addressprint, objectprint,
4785         stop_print_at_null, print_array_indexes, deref_ref, static_field_print,
4786         pascal_static_field_print, raw, summary, symbol_print, finish_print>:
4787         Likewise.
4788         * windows-nat.c (new_console): Likewise.
4789         (cygwin_exceptions): Likewise.
4790         (new_group): Likewise.
4791         (debug_exec): Likewise.
4792         (debug_events): Likewise.
4793         (debug_memory): Likewise.
4794         (debug_exceptions): Likewise.
4795         (useshell): Likewise.
4796         * windows-tdep.c (maint_display_all_tib): Likewise.
4797         * xml-support.c (debug_xml): Likewise.
4798
4799 2019-09-17  Mike Gulick  <mgulick@mathworks.com>
4800
4801         * source.c (prepare_path_for_appending): New function.
4802         (openp): Make use of new function.
4803         (find_and_open_source): Search for the compilation directory and
4804         source file as a relative path beneath the directory search path.
4805
4806 2019-09-17  Andrew Burgess  <andrew.burgess@embecosm.com>
4807
4808         * source-cache.c (source_cache::get_line_charpos): Catch
4809         exceptions and return false, this matches the behaviour documented
4810         in the header file.
4811
4812 2019-09-17  Joel Brobecker  <brobecker@adacore.com>
4813
4814         * ada-tasks.c (info_task): Remove quoting of the task's name.
4815
4816 2019-09-16  Christian Biesinger  <cbiesinger@google.com>
4817
4818         * symfile.c (auto_solib_add): Replace comment with a reference
4819         to the header file.
4820
4821 2019-09-14  Christian Biesinger  <cbiesinger@google.com>
4822
4823         * NEWS: Mention that gdb can now be compiled with Python 3
4824         on Windows.
4825
4826 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4827
4828         * maint.c (maint_print_section_data::maint_print_section_data):
4829         Force use of 'float log10 (float)' by casting the argument to
4830         float.
4831
4832 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4833
4834         * maint.c: Add 'cmath' include.
4835         (struct maint_print_section_data): New structure.
4836         (print_section_index): New function.
4837         (print_bfd_section_info): Add header comment, small whitespace
4838         cleanup, and update to call new print_section_index function.
4839         (print_objfile_section_info): Likewise.
4840         (maint_obj_section_from_bfd_section): New function.
4841         (print_bfd_section_info_maybe_relocated): New function.
4842         (maintenance_info_sections): Add header comment, always use
4843         bfd_map_over_sections instead of ALL_OBJFILE_OSECTIONS.
4844
4845 2019-09-12  Andrew Burgess  <andrew.burgess@embecosm.com>
4846
4847         * psymtab.c (find_pc_sect_psymtab): Move baseaddr local into more
4848         inner scope, add check that the objfile has psymtabs before
4849         checking psymtabs_addrmap.
4850         * psymtab.h (psymtab_storage) <psymtabs_addrmap>: Extend comment.
4851
4852 2019-09-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
4853
4854         * NEWS: Announce that Ada task names are now shown at more places,
4855         and between quotes (except in info task output).
4856         * gdb/ada-tasks.c (task_to_str): New function.
4857         (display_current_task_id): Call task_to_str.
4858         (task_command_1): Likewise.
4859         (print_ada_task_info): In non-mi mode, Properly align headers and data
4860         when task-id length is > 9 (9 is the default for a 32 bits CORE_ADDR).
4861
4862 2019-09-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
4863
4864         * procfs.c (procfs_target::wait) <PR_FAULTED>: Get signal from
4865         prstatus.pr_lwp.pr_info instead of making it up.
4866
4867 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4868
4869         * auto-load.c (auto_load_expand_dir_vars): Update.
4870         * defs.h (gdb_datadir): Change to std::string.
4871         (python_libdir): Likewise.
4872         (relocate_gdb_directory): Change return type to std::string.
4873         * guile/guile.c (gdbscm_data_directory): Update.
4874         (initialize_scheme_side): Update.
4875         * jit.c (jit_reader_dir): Change to std::string.
4876         (jit_reader_load_command): Update.
4877         * main.c (gdb_datadir): Change to std::string.
4878         (python_libdir): Likewise.
4879         (set_gdb_data_directory): Update.
4880         (relocate_path): Change to return std::string.
4881         (relocate_gdb_directory): Change to return std::string.
4882         (relocate_gdbinit_path_maybe_in_datadir): Update.
4883         (captured_main_1): Update.
4884         * python/python.c (do_start_initialization): Update.
4885         * top.c (show_gdb_datadir): Update.
4886         * xml-syscall.c (xml_init_syscalls_info): Update.
4887         (init_syscalls_info): Update.
4888
4889 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4890
4891         * main.c (relocate_gdbinit_path_maybe_in_datadir): Factor this code
4892         out of get_init_files.
4893         (get_init_files): Update.
4894
4895 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4896
4897         * main.c (get_init_files): Change to use std::string.
4898         (captured_main_1): Update.
4899         (print_gdb_help): Update.
4900
4901 2019-09-11  Ali Tamur  <tamur@google.com>
4902
4903         *gdb/target-float.c (host_float_ops<T>::to_longest): Update
4904         implementation.
4905
4906 2019-09-11  Christian Biesinger  <cbiesinger@google.com>
4907
4908         * dbxread.c (read_dbx_symtab): Update.
4909         * dwarf2read.c (load_partial_dies): Update.
4910         * mdebugread.c (parse_partial_symbols): Update.
4911         (handle_psymbol_enumerators): Update.
4912         * psympriv.h (add_psymbol_to_list): Change type of copy_names to bool.
4913         * psymtab.c (add_psymbol_to_bcache): Likewise.
4914         (add_psymbol_to_list): Likewise.
4915         * symtab.c (symbol_set_names): Likewise.
4916         * symtab.h (symbol_set_names): Likewise.
4917         * xcoffread.c (scan_xcoff_symtab): Update.
4918
4919 2019-09-11  Tom Tromey  <tom@tromey.com>
4920
4921         * symfile-mem.c (symbol_file_add_from_memory): Use
4922         bfd_set_filename.
4923         * solib-darwin.c (darwin_bfd_open): Use bfd_set_filename.
4924         * solib-aix.c (solib_aix_bfd_open): Use bfd_set_filename.
4925
4926 2019-09-10  Tom Tromey  <tromey@adacore.com>
4927
4928         * dwarf-index-write.c (write_psymbols): Extend error message.
4929         (debug_names::insert): Add Ada code.
4930         (debug_names::write_psymbols): Remove Ada check.
4931         (debug_names) <m_string_obstack>: New member.
4932         * dwarf2read.c (gdb_index_symbol_name_matcher): Remove.
4933         (gdb_index_symbol_name_matcher::matches): Remove.
4934         (mapped_index_base::find_name_components_bounds): Add "lang"
4935         parameter.
4936         (mapped_index_base::build_name_components): Also split names
4937         according to Ada syntax.
4938         (dw2_expand_symtabs_matching_symbol): Loop over languages.  Change
4939         type of "match_callback".
4940         (check_match, check_find_bounds_finds)
4941         (dw2_expand_symtabs_matching): Update.
4942         (dw2_debug_names_iterator): Add new constructor.
4943         (dw2_debug_names_map_matching_symbols): New function.
4944         (dw2_debug_names_expand_symtabs_matching): Update.
4945         (dwarf2_debug_names_functions): Use
4946         dw2_debug_names_map_matching_symbols.
4947
4948 2019-09-10  Tom Tromey  <tromey@adacore.com>
4949
4950         * dwarf2read.c (dw2_get_file_names_reader): Add the
4951         CU's file name to the results.
4952
4953 2019-09-10  Tom Tromey  <tromey@adacore.com>
4954
4955         * ada-lang.c (add_nonlocal_symbols): Combine calls to
4956         map_matching_symbols.  Update.
4957         * dwarf2read.c (dw2_map_matching_symbols): Update.
4958         * psymtab.c (match_partial_symbol): Change type; update.
4959         (psym_map_matching_symbols): Likewise.
4960         * symfile-debug.c (debug_qf_map_matching_symbols): Change
4961         type; update.
4962         * symfile.h (struct quick_symbol_functions)
4963         <map_matching_symbols>: Change "name" to be a lookup_name_info.
4964         Remove "match".
4965
4966 2019-09-10  Tom Tromey  <tromey@adacore.com>
4967
4968         * psymtab.c (map_block): Remove.
4969         (psym_map_matching_symbols): Use iterate_over_symbols_terminated.
4970         * symtab.c (iterate_over_symbols_terminated): New function.
4971         * symtab.c (iterate_over_symbols_terminated): Declare.
4972
4973 2019-09-10  Tom Tromey  <tromey@adacore.com>
4974
4975         * ada-lang.c (ada_iterate_over_symbols): Return bool.
4976         * language.h (struct language_defn) <la_iterate_over_symbols>:
4977         Return bool.
4978         * symtab.c (iterate_over_symbols): Return bool.
4979         * symtab.h (iterate_over_symbols): Return bool.
4980
4981 2019-09-10  Tom Tromey  <tromey@adacore.com>
4982
4983         * ada-lang.c (aux_add_nonlocal_symbols): Change type.
4984         (add_nonlocal_symbols): Update.
4985         * dwarf2read.c (dw2_map_matching_symbols): Change type.
4986         * psymtab.c (map_block, psym_map_matching_symbols): Change type.
4987         * symfile-debug.c (debug_qf_map_matching_symbols): Change type.
4988         * symfile.h (struct quick_symbol_functions) <map_matching_symbols>:
4989         Change type of "callback".  Remove "data".
4990
4991
4992 2019-09-09  Ali Tamur  <tamur@google.com>
4993
4994         * dwarf2read.c (comp_unit_head): Update comment.
4995         (dwarf2_dwo_name): New function declaration.
4996         (dwarf_unit_type_name): New function declaration.
4997         (read_comp_unit_head): Add support for new compilation units,
4998         DW_UT_partial, DW_UT_skeleton, DW_UT_split_compile, DW_UT_split_type.
4999         Particularly, DW_UT_skeleton and DW_UT_split_compile have dwo_id
5000         (currently named as "signature") in their header. Also clarify error
5001         messages.
5002         (lookup_dwo_id): New function. Returns the dwo id of the given
5003         compile unit.
5004         (lookup_dwo_unit): Use the new lookup_dwo_id function.
5005         (init_cutu_and_read_dies): Use the new dwarf2_dwo_name and lookup_dwo_id
5006         functions.
5007         (create_dwo_cu_reader): Use the added lookup_dwo_id function.
5008         (dwarf2_dwo_name): Get the dwo name if present.
5009         (dwarf_unit_type_name): Convert DW_UT_* types to string for diagnostic
5010         purposes.
5011
5012 2019-09-09  Tom Tromey  <tom@tromey.com>
5013
5014         * tui/tui-win.c (tui_all_windows_info): Use ui_out.
5015
5016 2019-09-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
5017
5018         * python/python.c (do_start_initialization): Make progname_copy static,
5019         to avoid a leak report.
5020
5021 2019-09-08  Tom Tromey  <tom@tromey.com>
5022
5023         * tui/tui-wingeneral.c (box_win): Truncate long window titles.
5024
5025 2019-09-07  Simon Marchi  <simon.marchi@efficios.com>
5026
5027         * dwarf2read.c (struct dw2_symtab_iterator) <block_index>:
5028         Change type to gdb::optional<block_enum>.
5029         (dw2_symtab_iter_init): Change block_index parameter type
5030         to gdb::optional<block_enum>.
5031         (dw2_lookup_symbol): Change block_index parameter
5032         type to block_enum.c
5033         (dw2_debug_names_lookup_symbol): Likewise.
5034         * psymtab.c (psym_lookup_symbol): Likewise.
5035         * symfile-debug.c (debug_qf_lookup_symbol): Likewise.
5036         * symfile.h (struct quick_symbol_functions) <lookup_symbol>:
5037         Likewise.
5038
5039 2019-09-06  Christian Biesinger  <cbiesinger@google.com>
5040
5041         * defs.h (relocate_gdb_directory): Change int to bool in
5042         signature and rename flag to relocatable.
5043         * main.c (relocate_path): Likewise.
5044         (relocate_gdb_directory): Likewise.
5045
5046 2019-09-06  Alan Modra  <amodra@gmail.com>
5047
5048         * coffread.c (coff_symfile_read): Constify filename variable.
5049         * dbxread.c (dbx_symfile_init, coffstab_build_psymtabs),
5050         (elfstab_build_psymtabs, stabsect_build_psymtabs): Likewise.
5051         * gdb_bfd.c (gdb_bfd_close_or_warn): Likewise.
5052         * solib.c (reload_shared_libraries_1): Likewise.
5053         * symfile.c (reread_symbols): Likewise.
5054         * solib-aix.c (solib_aix_bfd_open): Add cast for xfree of filename.
5055         * solib-darwin.c (darwin_bfd_open): Likewise.
5056         * symfile-mem.c (symbol_file_add_from_memory): Likewise.
5057
5058 2019-09-03  Andrew Burgess  <andrew.burgess@embecosm.com>
5059
5060         * psymtab.c (print_partial_symbols): Handle missing domain_enum
5061         values MODULE_DOMAIN and COMMON_BLOCK_DOMAIN.
5062
5063 2019-09-03  Tom Tromey  <tromey@adacore.com>
5064
5065         * ada-valprint.c (ada_val_print_num): Don't recurse for range
5066         types.
5067         (has_negatives): Unbias a range type bound.
5068         * dwarf2read.c (read_subrange_type): Handle DW_AT_GNU_bias.
5069         * gdbtypes.c (operator==): Handle new field.
5070         (create_range_type): Add "bias" parameter.
5071         (create_static_range_type, resolve_dynamic_range): Update.
5072         * gdbtypes.h (struct range_bounds) <bias>: New member.
5073         (create_range_type): Add bias parameter.
5074         * printcmd.c (print_scalar_formatted): Unbias range types.
5075         * value.c (unpack_long): Unbias range types.
5076         (pack_long): Bias range types.
5077
5078 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5079
5080         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Check all
5081         probe arguments.
5082
5083 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5084
5085         * break-catch-throw.c (fetch_probe_arguments): Use gdbarch.
5086         * dtrace-probe.c (dtrace_probe::get_argument_count): Likewise.
5087         * probe.c (probe_safe_evaluate_at_pc) (compute_probe_arg)
5088         (compile_probe_arg): Likewise.
5089         * probe.h (get_argument_count): Likewise.
5090         * solib-svr4.c (solib_event_probe_action): Likewise.
5091         * stap-probe.c (stap_probe::get_argument_count): Likewise.
5092
5093 2019-09-02  Alan Hayward  <alan.hayward@arm.com>
5094
5095         * solib-svr4.c (svr4_find_and_create_probe_breakpoints): Move
5096         code to here...
5097         (svr4_create_solib_event_breakpoints): ...from here.
5098
5099 2019-08-30  Sergio Durigan Junior  <sergiodj@redhat.com>
5100
5101         * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
5102         suffix from warning message.
5103
5104 2019-08-30  Tom Tromey  <tom@tromey.com>
5105
5106         * tui/tui-winsource.h (struct tui_source_window_base)
5107         <refresh_all>: Don't declare.
5108         * tui/tui-winsource.c (tui_source_window_base::refresh_all):
5109         Remove.
5110         * tui/tui-win.c (tui_refresh_all_win): Don't call refresh_all or
5111         tui_show_locator_content.
5112         * tui/tui-regs.h (struct tui_data_window) <refresh_all>: Don't
5113         declare.
5114         * tui/tui-regs.c (tui_data_window::refresh_all): Remove.
5115         * tui/tui-data.h (struct tui_win_info) <refresh_all>: Don't
5116         declare.
5117
5118 2019-08-30  Tom Tromey  <tom@tromey.com>
5119
5120         * tui/tui-io.c (tui_cont_sig): Don't call wrefresh.
5121
5122 2019-08-30  Tom Tromey  <tom@tromey.com>
5123
5124         * tui/tui-stack.c (_initialize_tui_stack): Move later.
5125         Remove unnecessary forward declarations.
5126
5127 2019-08-30  Tom Tromey  <tom@tromey.com>
5128
5129         * tui/tui-stack.c (tui_locator_window::set_locator_fullname): Call
5130         rerender.
5131         (tui_update_locator_fullname, tui_show_frame_info): Don't call
5132         tui_show_locator_content.
5133
5134 2019-08-30  Tom Tromey  <tom@tromey.com>
5135
5136         * tui/tui-stack.c (tui_show_locator_content): Move lower.  Rewrite.
5137         (tui_locator_window::rerender): Rewrite using body of previous
5138         tui_show_locator_content.
5139
5140 2019-08-30  Tom Tromey  <tom@tromey.com>
5141
5142         * tui/tui-stack.h (struct tui_locator_window) <set_locator_info,
5143         set_locator_fullname>: New methods.
5144         * tui/tui-stack.c (tui_locator_window::set_locator_fullname):
5145         Rename from tui_set_locator_fullname.
5146         (tui_locator_window::set_locator_info): Rename from
5147         tui_set_locator_info.  Return bool.
5148         (tui_update_locator_fullname, tui_show_frame_info): Update.
5149
5150 2019-08-30  Tom Tromey  <tom@tromey.com>
5151
5152         * tui/tui-layout.c (show_layout): Don't call tui_refresh_all.
5153
5154 2019-08-30  Tom Tromey  <tom@tromey.com>
5155
5156         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Don't
5157         call touchwin.
5158
5159 2019-08-30  Tom Tromey  <tom@tromey.com>
5160
5161         * tui/tui-wingeneral.c (box_win): Assume win_info and
5162         win_info->handle cannot be NULL.
5163
5164 2019-08-30  Tom Tromey  <tom@tromey.com>
5165
5166         * tui/tui-regs.h (struct tui_data_item_window) <rerender,
5167         refresh_window>: Declare.
5168         * tui/tui-regs.c (tui_data_window::display_registers_from): Call
5169         resize.
5170         (tui_data_item_window::rerender): Rename from
5171         tui_display_register.
5172         (tui_data_item_window::refresh_window): New method.
5173         * tui/tui-layout.c (tui_gen_win_info::resize): Do nothing on
5174         no-op.
5175
5176 2019-08-30  Tom Tromey  <tom@tromey.com>
5177
5178         * tui/tui-regs.h (struct tui_data_window) <regs_content,
5179         regs_column_count, current_group>: Move later.  Now private.
5180         <get_current_group>: New method.
5181         * tui/tui-regs.c (tui_reg_command): Update.
5182         * tui/tui-layout.c (tui_set_layout): Update.
5183
5184 2019-08-30  Tom Tromey  <tom@tromey.com>
5185
5186         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
5187         (tui_data_window::rerender): Don't call
5188         check_and_display_highlight_if_needed.
5189         (tui_data_window::refresh_all): Remove call to
5190         erase_data_content.
5191
5192 2019-08-30  Tom Tromey  <tom@tromey.com>
5193
5194         * tui/tui-regs.c (tui_data_window::last_regs_line_no)
5195         (tui_data_window::display_registers_from)
5196         (tui_data_window::display_reg_element_at_line)
5197         (tui_data_window::display_registers_from_line): Remove checks of
5198         "empty".
5199
5200 2019-08-30  Tom Tromey  <tom@tromey.com>
5201
5202         * tui/tui-regs.h (struct tui_data_window) <display_all_data>:
5203         Don't declare.
5204         * tui/tui-regs.c (tui_data_window::show_registers): Call
5205         rerender.
5206         (tui_data_window::rerender): Rename from display_all_data.
5207         (tui_data_window::rerender): Remove old implementation.
5208
5209 2019-08-30  Tom Tromey  <tom@tromey.com>
5210
5211         * tui/tui-regs.c (tui_data_window::display_all_data): Change
5212         text.
5213         * tui/tui-data.h (NO_DATA_STRING): Remove define.
5214
5215 2019-08-29  Bernhard Wodok  <barto@gmx.net>
5216             Sergio Durigan Junior  <sergiodj@redhat.com>
5217
5218         PR win32/24284
5219         * mingw-hdep.c (gdb_select): Handle case when 'n' is zero.
5220
5221 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5222
5223         * symtab.c (search_symbols): Don't include MODULE_DOMAIN symbols
5224         when searching for types.
5225
5226 2019-08-28  Andrew Burgess  <andrew.burgess@embecosm.com>
5227
5228         * f-lang.c (f_language_defn): Use f_print_typedef.
5229         * f-lang.h (f_print_typedef): Declare.
5230         * f-typeprint.c (f_print_typedef): Define.
5231
5232 2019-08-27  Christian Biesinger  <cbiesinger@google.com>
5233
5234         * nat/linux-namespaces.c (mnsh_main): Initialize fd (to -1).
5235
5236 2019-08-27  Andrew Burgess  <andrew.burgess@embecosm.com>
5237
5238         * cli/cli-utils.c (info_print_options_defs): Delete.
5239         (make_info_print_options_def_group): Delete.
5240         (extract_info_print_options): Delete.
5241         (info_print_command_completer): Delete.
5242         (info_print_args_help): Add extra parameter, and optionally
5243         include text about -n flag.
5244         * cli/cli-utils.h (struct info_print_options): Delete.
5245         (extract_info_print_options): Delete declaration.
5246         (info_print_command_completer): Delete declaration.
5247         (info_print_args_help): Add extra parameter, extend header
5248         comment.
5249         * python/python.c (gdbpy_rbreak): Pass additional parameter to
5250         search_symbols.
5251         * stack.c (struct info_print_options): New type.
5252         (info_print_options_defs): New file scoped variable.
5253         (make_info_print_options_def_group): New static function.
5254         (info_print_command_completer): New static function.
5255         (info_locals_command): Update to use new local functions.
5256         (info_args_command): Likewise.
5257         (_initialize_stack): Add extra parameter to calls to
5258         info_print_args_help.
5259         * symtab.c (search_symbols): Add extra parameter, use this to
5260         possibly excluse non-debug symbols.
5261         (symtab_symbol_info): Add extra parameter, which is passed on to
5262         search_symbols.
5263         (struct info_print_options): New type.
5264         (info_print_options_defs): New file scoped variable.
5265         (make_info_print_options_def_group): New static function.
5266         (info_print_command_completer): New static function.
5267         (info_variables_command): Update to use local functions, and pass
5268         extra parameter through to symtab_symbol_info.
5269         (info_functions_command): Likewise.
5270         (info_types_command): Pass additional argument through to
5271         symtab_symbol_info.
5272         (rbreak_command): Pass extra argument to search_symbols.
5273         (_initialize_symtab): Add extra arguments for calls to
5274         info_print_args_help, and update help text for 'info variables',
5275         'whereis', and 'info functions' commands.
5276         * symtab.h (search_symbols): Add extra argument to declaration.
5277         * NEWS: Mention new flags.
5278
5279 2019-08-26  Christian Biesinger  <cbiesinger@google.com>
5280
5281         * symtab.c (lookup_static_symbol): Call the new function (and move
5282         it down to be next to lookup_global_symbol).
5283         (struct global_sym_lookup_data): Add block_enum member and rename to...
5284         (struct global_or_static_sym_lookup_data): ...this.
5285         (lookup_symbol_global_iterator_cb): Pass block_index instead of
5286         GLOBAL_BLOCK to lookup_symbol_in_objfile and rename to...
5287         (lookup_symbol_global_or_static_iterator_cb): ...this.
5288         (lookup_global_or_static_symbol): New function.
5289         (lookup_global_symbol): Call new function.
5290
5291 2019-08-26  Tom de Vries  <tdevries@suse.de>
5292
5293         PR c++/24852
5294         * break-catch-throw.c (fetch_probe_arguments): Improve error mesage
5295         when pc_probe.prob == NULL.
5296
5297 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5298
5299         * dwarf2read.c (dw2_debug_names_iterator::next): Rename local
5300         variable symbol_linkage to symbol_linkage_.
5301
5302 2019-08-25  Simon Marchi  <simon.marchi@efficios.com>
5303
5304         * dwarf2read.c (dw2_debug_names_iterator::next): Use enum to
5305         represent whether the symbol is static, dynamic, or we don't
5306         know.
5307
5308 2019-08-25  Yoshinori Sato <ysato@users.sourceforge.jp>
5309
5310         * gdb/rx-tdep.c (rx_register_names): New.
5311         (rx_register_name): Delete.
5312         (rx_psw_type): Delete.
5313         (rx_fpsw_type): Delete.
5314         (rx_register_type): Delete.
5315         (rx_gdbarch_init): Convert target-descriptions.
5316         (_initialize_rx_tdep): Add initialize_tdesc_rx.
5317         * gdb/features/Makefile: Add rx.xml.
5318         * gdb/features/rx.xml: New.
5319         * gdb/features/rx.c: Generated.
5320         * gdb/NEWS: Mention target description support.
5321
5322 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5323
5324         * symtab.c (symbol_cache_lookup): Always initialize *bsc_ptr and
5325         *slot_ptr.
5326
5327 2019-08-23  Sergio Durigan Junior  <sergiodj@redhat.com>
5328
5329         * configure.ac: Don't check for 'dlfcn.h' (moved to
5330         gdbsupport/common.m4).
5331         * Makefile.in (COMMON_SFILES): Move 'gdb-dlfcn.c' to
5332         'gdbsupport/'.
5333         (HFILES_NO_SRCDIR): Likewise, for 'gdb-dlfcn.h'.
5334         * compile/compile-c-support.c: Include
5335         'gdbsupport/gdb-dlfcn.h'.
5336         * gdbsupport/common.m4: Check for 'dlfcn.h'.
5337         * gdb-dlfcn.c: Move to...
5338         * gdbsupport/gdb-dlfcn.c: ... here.
5339         * gdb-dlfcn.h: Move to...
5340         * gdbsupport/gdb-dlfcn.h: ... here.
5341
5342 2019-08-23  Sandra Loosemore  <sandra@codesourcery.com>
5343
5344         * nios2-tdep.c (struct reg_value): Improve comments.  Make
5345         the offset field signed.
5346
5347 2019-08-22  Christian Biesinger  <cbiesinger@google.com>
5348
5349         * python/lib/gdb/__init__.py (_execute_file): New function.
5350         * python/python.c (python_run_simple_file): Call gdb._execute_file
5351         on Windows.
5352
5353 2019-08-22  Andrew Burgess  <andrew.burgess@embecosm.com>
5354
5355         * f-exp.y (yylex): Remove is_a_field_of_this local variable, and
5356         all uses as this was never set to anything but a zero value.
5357
5358 2019-08-21  Bogdan Harjoc  <harjoc@gmail.com>
5359
5360         * cli/cli-cmds.c (with_command_1): Error out if no arguments.
5361
5362 2019-08-21  Christian Biesinger  <cbiesinger@google.com>
5363
5364         * tui/tui-data.h (tui_gen_win_info): Add an =default
5365         move constructor, required by some GCC versions.
5366
5367 2019-08-21  Jinke Fan  <fanjinke51@yeah.net>
5368
5369         * go32-nat.c (go32_sysinfo): Add hygon_p.
5370
5371 2019-08-20  Tom Tromey  <tom@tromey.com>
5372
5373         * tui/tui-regs.h (struct tui_data_window) <last_regs_line_no,
5374         line_from_reg_element_no, first_reg_element_no_inline,
5375         display_all_data, delete_data_content_windows,
5376         erase_data_content>: Now private.
5377
5378 2019-08-20  Tom Tromey  <tom@tromey.com>
5379
5380         * tui/tui-wingeneral.c (box_win): Change type of highlight_flag.
5381         (tui_unhighlight_win, tui_highlight_win)
5382         (tui_win_info::make_window): Update.
5383         * tui/tui-data.h (HILITE, NO_HILITE): Remove.
5384
5385 2019-08-20  Tom Tromey  <tom@tromey.com>
5386
5387         * tui/tui-data.h (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5388         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5389         (MAX_PID_WIDTH): Move to tui-stack.c.
5390         * tui/tui-stack.c (PROC_PREFIX, LINE_PREFIX, PC_PREFIX)
5391         (MIN_LINE_WIDTH, MIN_PROC_WIDTH, MAX_TARGET_WIDTH)
5392         (MAX_PID_WIDTH): Move from tui-data.h.
5393
5394 2019-08-20  Tom Tromey  <tom@tromey.com>
5395
5396         * tui/tui-wingeneral.h (tui_make_window): Don't declare.
5397         * tui/tui-wingeneral.c (box_win): Change type of win_info.
5398         (box_win): Update.
5399         (tui_gen_win_info::make_window): Rename from tui_make_window.
5400         (tui_win_info::make_window): New method.
5401         (tui_gen_win_info::make_visible): Update.
5402         * tui/tui-source.c (tui_source_window::set_contents): Update.
5403         * tui/tui-regs.c (tui_data_window::show_register_group): Update.
5404         (tui_data_window::display_registers_from): Update.
5405         * tui/tui-layout.c (tui_gen_win_info::resize): Update.
5406         * tui/tui-data.h (struct tui_gen_win_info) <make_window>:
5407         Declare.
5408         <can_box>: Remove.
5409         <title>: Remove.
5410         (struct tui_win_info) <make_window>: Declare.
5411         <can_box>: Now virtual.
5412         <title>: New member.
5413         * tui/tui-data.c (~tui_gen_win_info): Don't free title.
5414         * tui/tui-command.c (tui_cmd_window::resize): Update.
5415
5416 2019-08-20  Tom Tromey  <tom@tromey.com>
5417
5418         * tui/tui-regs.h (struct tui_data_window) <display_regs>: Remove.
5419         * tui/tui-regs.c (tui_data_window::show_registers): Update.
5420         (tui_data_window::check_register_values): Update.
5421
5422 2019-08-20  Tom Tromey  <tom@tromey.com>
5423
5424         * tui/tui-regs.h (struct tui_data_window): Use
5425         DISABLE_COPY_AND_ASSIGN.
5426         <regs_content>: Change type, removing unique_ptr.
5427         <tui_data_window>: Add move constructor.
5428         * tui/tui-regs.c (tui_data_window::show_registers)
5429         (tui_data_window::show_register_group)
5430         (tui_data_window::display_registers_from)
5431         (tui_data_window::display_registers_from)
5432         (tui_data_window::first_data_item_displayed)
5433         (tui_data_window::delete_data_content_windows)
5434         (tui_data_window::rerender, tui_data_window::refresh_window)
5435         (tui_data_window::check_register_values): Update.
5436
5437 2019-08-20  Tom Tromey  <tom@tromey.com>
5438
5439         * tui/tui-regs.h (struct tui_data_window) <show_registers,
5440         show_register_group>: Declare.
5441         (tui_show_register_group): Don't declare.
5442         * tui/tui-regs.c (tui_data_window::show_registers): Rename from
5443         tui_show_registers.
5444         (tui_data_window::show_register_group): Rename from
5445         tui_show_register_group.
5446         (tui_data_window::check_register_values, tui_reg_command):
5447         Update.
5448         * tui/tui-layout.c (tui_set_layout): Update.
5449
5450 2019-08-20  Tom Tromey  <tom@tromey.com>
5451
5452         * tui/tui-regs.h (struct tui_data_window) <check_register_values>:
5453         Declare.
5454         (tui_check_register_values): Don't declare.
5455         * tui/tui-regs.c (tui_data_window::check_register_values): Rename
5456         from tui_check_register_values.
5457         * tui/tui-hooks.c (tui_register_changed): Update.
5458
5459 2019-08-20  Tom Tromey  <tom@tromey.com>
5460
5461         * tui/tui-regs.c (tui_reg_layout): Move later.
5462         (tui_show_registers): Don't enable TUI mode or change layout.
5463
5464 2019-08-20  Tom Tromey  <tom@tromey.com>
5465
5466         * tui/tui-regs.h (struct tui_data_item_window)
5467         <~tui_data_item_window>: Remove.
5468         <content>: Now a unique_xmalloc_ptr.
5469         * tui/tui-regs.c (tui_register_format): Return a
5470         unique_xmalloc_ptr.
5471         (tui_get_register): Update.
5472         (~tui_data_item_window): Remove.
5473         (tui_data_window::display_registers_from, tui_display_register):
5474         Update.
5475         * tui/tui-io.h (tui_expand_tabs): Update.
5476         * tui/tui-io.c (tui_expand_tabs): Return a unique_xmalloc_ptr.
5477         Remove "col" parameter.
5478
5479 2019-08-20  Tom Tromey  <tom@tromey.com>
5480
5481         * tui/tui-regs.h (struct tui_data_item_window) <value>: Remove
5482         field.
5483         * tui/tui-regs.c (~tui_data_item_window): Update.
5484
5485 2019-08-20  Tom Tromey  <tom@tromey.com>
5486
5487         * tui/tui-regs.c (tui_register_format, tui_get_register): Move
5488         earlier.
5489
5490 2019-08-20  Tom Tromey  <tom@tromey.com>
5491
5492         * tui/tui-regs.c (tui_reg_command): Remove NULL check.
5493
5494 2019-08-20  Tom Tromey  <tom@tromey.com>
5495
5496         * tui/tui-source.h (struct tui_source_window): Update.
5497         * tui/tui-regs.c (tui_show_registers): Update.
5498         * tui/tui-disasm.h (struct tui_disasm_window): Update.
5499         * tui/tui-data.h (NO_SRC_STRING, NO_DISASSEM_STRING)
5500         (NO_REGS_STRING): Remove defines.
5501
5502 2019-08-20  Conrad Meyer  <cem@FreeBSD.org>
5503
5504         * remote.c (remote_target::remote_btrace_maybe_reopen): Avoid
5505         unnecessary thread walk if remote doesn't support the packet.
5506
5507 2019-08-19  Tom Tromey  <tromey@adacore.com>
5508
5509         * python/py-value.c (value_has_field): Fix indentation.
5510
5511 2019-08-19  Tom Tromey  <tromey@adacore.com>
5512
5513         * printcmd.c (do_one_display, info_display_command): Update.
5514         * block.h (contained_in): Return bool.  Add allow_nested
5515         parameter.
5516         * block.c (contained_in): Return bool.  Add allow_nested
5517         parameter.
5518
5519 2019-08-19  Tom Tromey  <tom@tromey.com>
5520
5521         * configure: Rebuild.
5522         * configure.ac: Disallow the combination of -static-libstdc++ and
5523         source highlight.
5524         * source-cache.c (get_language_name): Handle rust.
5525         (source_cache::get_source_lines): Ignore highlighting exceptions.
5526
5527 2019-08-16  Tom Tromey  <tom@tromey.com>
5528
5529         * tui/tui.h (enum tui_win_type) <EXEC_INFO_WIN>: Remove.
5530         * tui/tui-winsource.h (struct tui_exec_info_window): Remove.
5531         (struct tui_source_window_base) <make_visible, refresh_window,
5532         resize>: Remove methods.
5533         <execution_info>: Remove field.
5534         * tui/tui-winsource.c (tui_source_window_base::do_erase_source_content)
5535         (tui_show_source_line, tui_source_window_base)
5536         (~tui_source_window_base): Update.
5537         (tui_source_window_base::resize)
5538         (tui_source_window_base::make_visible)
5539         (tui_source_window_base::refresh_window): Remove.
5540         (tui_source_window_base::update_exec_info): Update.
5541         * tui/tui-source.c (tui_source_window::set_contents): Update.
5542         * tui/tui-disasm.c (tui_disasm_window::set_contents): Update.
5543
5544 2019-08-16  Tom Tromey  <tom@tromey.com>
5545
5546         * tui/tui-hooks.c (tui_remove_hooks): Don't set
5547         deprecated_query_hook.
5548
5549 2019-08-16  Tom Tromey  <tom@tromey.com>
5550
5551         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
5552         (tui_update_source_windows_with_line): Update.
5553         * tui/tui-source.h (struct tui_source_window)
5554         <show_symtab_source>: Declare.
5555         (tui_show_symtab_source): Don't declare.
5556         * tui/tui-source.c (tui_show_symtab_source): Rename from
5557         tui_show_symtab_source.
5558
5559 2019-08-16  Tom Tromey  <tom@tromey.com>
5560
5561         * tui/tui-winsource.h (struct tui_source_window_base)
5562         <set_contents>: Declare.
5563         * tui/tui-winsource.c
5564         (tui_source_window_base::update_source_window_as_is): Update.
5565         * tui/tui-source.h (struct tui_source_window) <set_contents>:
5566         Declare.
5567         (tui_set_source_content): Don't declare.
5568         * tui/tui-source.c (tui_source_window::set_contents): Rename from
5569         tui_set_source_content.
5570         * tui/tui-disasm.h (struct tui_disasm_window) <set_contents>:
5571         Declare.
5572         (tui_set_disassem_content): Don't declare.
5573         * tui/tui-disasm.c (tui_disasm_window::set_contents): Rename from
5574         tui_set_disassem_content.
5575
5576 2019-08-16  Tom Tromey  <tom@tromey.com>
5577
5578         * tui/tui-winsource.h (struct tui_source_window_base)
5579         <update_breakpoint_info>: Declare.
5580         (tui_update_breakpoint_info): Don't declare.
5581         * tui/tui-winsource.c (tui_source_window_base::update_source_window_as_is)
5582         (tui_update_all_breakpoint_info): Update.
5583         (tui_source_window_base::update_breakpoint_info): Rename from
5584         tui_update_breakpoint_info.
5585         (tui_source_window_base::update_exec_info): Update.
5586
5587 2019-08-16  Tom Tromey  <tom@tromey.com>
5588
5589         * tui/tui-winsource.h (struct tui_source_window_base)
5590         <update_source_window>: Declare.
5591         (tui_update_source_window): Don't declare.
5592         * tui/tui-winsource.c
5593         (tui_source_window_base::update_source_window): Rename from
5594         tui_update_source_window.
5595         (tui_source_window_base::rerender): Update.
5596         * tui/tui-source.c (tui_source_window::maybe_update): Update.
5597         * tui/tui-disasm.c (tui_show_disassem)
5598         (tui_show_disassem_and_update_source)
5599         (tui_disasm_window::maybe_update): Update.
5600
5601 2019-08-16  Tom Tromey  <tom@tromey.com>
5602
5603         * tui/tui-winsource.h (struct tui_source_window_base)
5604         <update_source_window_as_is>: Declare.
5605         (tui_update_source_window_as_is): Don't declare.
5606         * tui/tui-winsource.c (tui_update_source_window): Update
5607         (tui_source_window_base::update_source_window_as_is): Rename from
5608         tui_update_source_window_as_is.
5609         (tui_source_window_base::refill): Update.
5610         * tui/tui-source.c (tui_show_symtab_source): Update.
5611         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical):
5612         Update.
5613
5614 2019-08-16  Tom Tromey  <tom@tromey.com>
5615
5616         * tui/tui-winsource.h (tui_update_source_window)
5617         (tui_update_source_window_as_is): Remove "noerror" parameter.
5618         * tui/tui-winsource.c (tui_update_source_window)
5619         (tui_update_source_window_as_is): Remove "noerror" parameter.
5620         (tui_update_source_windows_with_addr)
5621         (tui_update_source_windows_with_line)
5622         (tui_source_window_base::rerender)
5623         (tui_source_window_base::refill): Update.
5624         * tui/tui-source.h (tui_set_source_content)
5625         (tui_show_symtab_source): Remove "noerror" parameter.
5626         * tui/tui-source.c (tui_set_source_content): Remove "noerror"
5627         parameter.
5628         (tui_show_symtab_source): Likewise.
5629         (tui_source_window::maybe_update): Update.
5630         * tui/tui-disasm.c (tui_show_disassem)
5631         (tui_show_disassem_and_update_source)
5632         (tui_disasm_window::do_scroll_vertical)
5633         (tui_disasm_window::maybe_update): Update.
5634
5635 2019-08-16  Tom Tromey  <tom@tromey.com>
5636
5637         * tui/tui.c (tui_is_window_visible): Update.
5638         * tui/tui-wingeneral.c (tui_make_window)
5639         (tui_gen_win_info::make_visible, tui_refresh_all): Update.
5640         * tui/tui-win.c (window_name_completer, tui_refresh_all_win)
5641         (tui_set_focus_command, tui_all_windows_info, update_tab_width)
5642         (tui_set_win_height_command, parse_scrolling_args): Update.
5643         * tui/tui-source.c (tui_source_window::style_changed): Update.
5644         * tui/tui-regs.c (tui_show_registers)
5645         (tui_data_window::first_data_item_displayed)
5646         (tui_data_window::delete_data_content_windows)
5647         (tui_check_register_values, tui_reg_command): Update.
5648         * tui/tui-disasm.c (tui_show_disassem): Update.
5649         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: New
5650         method.
5651         <is_visible>: Remove field.
5652         * tui/tui-data.c (tui_next_win, tui_prev_win)
5653         (tui_delete_invisible_windows): Update.
5654
5655 2019-08-16  Tom Tromey  <tom@tromey.com>
5656
5657         * tui/tui-winsource.h (struct tui_source_window_base)
5658         <m_has_locator>: Remove.
5659         * tui/tui-layout.c (show_source_disasm_command, show_data)
5660         (show_source_or_disasm_and_command): Update.
5661
5662 2019-08-16  Alan Hayward  <alan.hayward@arm.com>
5663
5664         * NEWS (Other MI changes): New subsection.
5665         * aarch64-tdep.c (aarch64_get_pc_address_flags): New function.
5666         (aarch64_gdbarch_init): Add aarch64_get_pc_address_flags.
5667         * arch-utils.c (default_get_pc_address_flags): New function.
5668         * arch-utils.h (default_get_pc_address_flags): New declaration.
5669         * gdbarch.sh: Add get_pc_address_flags.
5670         * gdbarch.c: Regenerate.
5671         * gdbarch.h: Likewise.
5672         * stack.c (print_pc): New function.
5673         (print_frame_info) (print_frame): Call print_pc.
5674
5675 2019-08-16  Tom de Vries  <tdevries@suse.de>
5676
5677         * maint.c (maintenance_info_sections): Also handle !ALLOBJ case using
5678         print_objfile_section_info.
5679
5680 2019-08-15  Tom Tromey  <tom@tromey.com>
5681
5682         * tui/tui-io.c (tui_puts_internal): Check TUI_CMD_WIN before
5683         calling update_cmdwin_start_line.
5684         * tui/tui-winsource.h (struct tui_source_window_base)
5685         <do_make_visible_with_new_height, set_new_height>: Don't declare.
5686         <rerender>: Declare.
5687         * tui/tui-winsource.c (tui_source_window_base::update_tab_width):
5688         Call rerender.
5689         (tui_source_window_base::set_new_height): Remove.
5690         (tui_source_window_base::rerender): Rename from
5691         do_make_visible_with_new_height.
5692         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Use
5693         resize method.
5694         (tui_win_info::make_invisible_and_set_new_height)
5695         (tui_win_info::make_visible_with_new_height): Remove.
5696         * tui/tui-stack.h (struct tui_locator_window) <rerender>:
5697         Declare.
5698         * tui/tui-stack.c (tui_locator_window::rerender): New method.
5699         * tui/tui-regs.h (struct tui_data_window) <set_new_height,
5700         do_make_visible_with_new_height>: Don't declare.
5701         <rerender>: Declare.
5702         * tui/tui-regs.c (tui_data_window::rerender): Rename from
5703         set_new_height.
5704         (tui_data_window::do_make_visible_with_new_height): Remove.
5705         * tui/tui-layout.c (show_source_disasm_command, show_data): Don't
5706         call tui_show_locator_content.
5707         (tui_gen_win_info::resize): Call rerender.
5708         (show_source_or_disasm_and_command): Don't call
5709         tui_show_locator_content.
5710         * tui/tui-data.h (struct tui_gen_win_info) <rerender>: New
5711         method.
5712         (struct tui_win_info) <rerender>: Declare.
5713         <set_new_height, make_invisible_and_set_new_height,
5714         make_visible_with_new_height>: Don't declare.
5715         * tui/tui-data.c (tui_win_list::rerender): New method.
5716         * tui/tui-command.h (struct tui_cmd_window)
5717         <do_make_visible_with_new_height>: Don't declare.
5718         * tui/tui-command.c
5719         (tui_cmd_window::do_make_visible_with_new_height): Remove.
5720
5721 2019-08-15  Tom Tromey  <tromey@adacore.com>
5722
5723         * ada-exp.y (convert_char_literal): Handle "Q%c" encoding.
5724         * ada-lang.c (ada_enum_name): Likewise.
5725
5726 2019-08-15  Christian Biesinger  <cbiesinger@google.com>
5727
5728         * python/lib/gdb/__init__.py (GdbOutputFile): Rename to have a
5729         leading underscore.
5730         (GdbOutputErrorFile): Likewise.
5731         (global scope): Adjust constructor calls to GdbOutput{,Error}File
5732         accordingly.
5733         (execute_unwinders): Rename to have a leading underscore.
5734         (auto_load_packages): Likewise.
5735         (global scope): Adjust call to auto_load_packages accordingly.
5736         (GdbSetPythonDirectory): Likewise.
5737         * python/py-unwind.c (pyuw_sniffer): Call _execute_unwinders
5738         instead of execute_unwinders.
5739
5740 2019-08-15  Tom Tromey  <tom@tromey.com>
5741
5742         * tui/tui-layout.c (show_layout, show_source_disasm_command)
5743         (show_data): Don't change window visibility.
5744         (tui_gen_win_info::resize): Remove special case for command
5745         window.  Use wresize, when available.
5746         (show_source_or_disasm_and_command): Don't change window
5747         visibility.
5748         * tui/tui-command.h (struct tui_cmd_window) <resize>: Declare.
5749         <make_visible>: New method.
5750         * tui/tui-command.c (tui_cmd_window::resize): New method.
5751
5752 2019-08-15  Tom Tromey  <tom@tromey.com>
5753
5754         * tui/tui-winsource.h (struct tui_source_window_iterator): New.
5755         (struct tui_source_windows): New.
5756         * tui/tui-winsource.c (tui_display_main): Update.
5757         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
5758         (new_height_ok, parse_scrolling_args): Update.
5759         * tui/tui-layout.c (show_layout, show_data): Update.
5760         * tui/tui-data.h (tui_source_windows, tui_clear_source_windows)
5761         (tui_add_to_source_windows): Don't declare.
5762         * tui/tui-data.c (source_windows, tui_source_windows)
5763         (tui_clear_source_windows, tui_add_to_source_windows): Remove.
5764
5765 2019-08-15  Tom Tromey  <tom@tromey.com>
5766
5767         * tui/tui-winsource.h (struct tui_source_window_base) <resize>:
5768         Rename from reset.
5769         * tui/tui-winsource.c (tui_source_window_base::resize): Rename.
5770         * tui/tui-layout.c (show_source_disasm_command, show_data):
5771         Update.
5772         (tui_gen_win_info::resize): Rename.
5773         (show_source_or_disasm_and_command): Update.
5774         * tui/tui-data.h (struct tui_gen_win_info) <resize>: Rename from
5775         reset.
5776
5777 2019-08-15  Tom Tromey  <tom@tromey.com>
5778
5779         * tui/tui-stack.c (tui_initialize_static_data): Remove.
5780         * tui/tui-interp.c (tui_interp::init): Don't call
5781         tui_initialize_static_data.
5782         * tui/tui-data.h (tui_initialize_static_data): Don't declare.
5783
5784 2019-08-15  Tom Tromey  <tom@tromey.com>
5785
5786         * tui/tui-layout.c (tui_default_win_viewport_height): Don't
5787         examine tui_win_list.
5788
5789 2019-08-15  Tom Tromey  <tom@tromey.com>
5790
5791         * tui/tui-winsource.h (tui_clear_source_content): Don't declare.
5792         * tui/tui-winsource.c (tui_update_source_window_as_is): Don't call
5793         tui_clear_source_content.
5794         (tui_clear_source_content): Remove.
5795         (tui_source_window_base::do_erase_source_content): Hoist call to
5796         content.clear().
5797         * tui/tui-stack.c (tui_show_frame_info): Don't call
5798         tui_clear_source_content.
5799
5800 2019-08-15  Tom Tromey  <tom@tromey.com>
5801
5802         * tui/tui-winsource.h (struct tui_source_window_base)
5803         <do_erase_source_content>: New method.
5804         <erase_source_content>: New method.
5805         (tui_erase_source_content): Don't declare.
5806         * tui/tui-winsource.c (tui_clear_source_content): Update.
5807         (tui_source_window_base::do_erase_source_content): Rename from
5808         tui_erase_source_content.
5809         (tui_source_window_base::show_source_content): Update.
5810         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
5811         * tui/tui-source.h (struct tui_source_window)
5812         <erase_source_content>: New method.
5813         * tui/tui-disasm.h (struct tui_disasm_window)
5814         <erase_source_content>: New method.
5815
5816 2019-08-15  Tom Tromey  <tom@tromey.com>
5817
5818         * tui/tui-winsource.h (tui_alloc_source_buffer): Don't declare.
5819         (struct tui_source_element): Add DISABLE_COPY_AND_ASSIGN, and move
5820         constructor.
5821         * tui/tui-winsource.c (tui_alloc_source_buffer): Remove.
5822         * tui/tui-source.c (tui_set_source_content): Update.
5823         * tui/tui-disasm.c (tui_set_disassem_content): Update.
5824
5825 2019-08-15  Tom Tromey  <tom@tromey.com>
5826
5827         * tui/tui-winsource.h (tui_line_is_displayed): Don't declare.
5828         * tui/tui-winsource.c (tui_line_is_displayed): Move to
5829         tui-source.c.
5830         * tui/tui-source.h (struct tui_source_window) <line_is_displayed>:
5831         Declare.
5832         * tui/tui-source.c (tui_source_window::line_is_displayed): New
5833         method.
5834         (tui_source_window::maybe_update): Update.
5835
5836 2019-08-15  Tom Tromey  <tom@tromey.com>
5837
5838         * tui/tui-winsource.h (tui_addr_is_displayed): Don't declare.
5839         * tui/tui-winsource.c (tui_addr_is_displayed): Move to
5840         tui-disasm.c.
5841         * tui/tui-disasm.h (struct tui_disasm_window) <addr_is_displayed>:
5842         Declare.
5843         * tui/tui-disasm.c (tui_disasm_window::addr_is_displayed): New
5844         method.
5845         (tui_disasm_window::maybe_update): Update.
5846
5847 2019-08-15  Tom Tromey  <tom@tromey.com>
5848
5849         * tui/tui-winsource.h (struct tui_source_window_base)
5850         <maybe_update>: Declare.
5851         * tui/tui-stack.c (tui_show_frame_info): Call maybe_update
5852         method.
5853         * tui/tui-source.h (struct tui_source_window) <maybe_update>:
5854         Declare.
5855         * tui/tui-source.c (tui_source_window::maybe_update): New method.
5856         * tui/tui-disasm.h (struct tui_disasm_window) <maybe_update>:
5857         Declare.
5858         * tui/tui-disasm.c (tui_disasm_window::maybe_update): New method.
5859
5860 2019-08-15  Tom Tromey  <tom@tromey.com>
5861
5862         * tui/tui-stack.c (tui_make_status_line): Use string constructor.
5863
5864 2019-08-15  Tom Tromey  <tom@tromey.com>
5865
5866         * tui/tui-wingeneral.c: Include tui-stack.h.
5867         * tui/tui-stack.h (MAX_LOCATOR_ELEMENT_LEN)
5868         (struct tui_locator_window): Move from tui-data.h.
5869         * tui/tui-stack.c (_locator, tui_locator_win_info_ptr)
5870         (tui_initialize_static_data): Move from tui-data.c.
5871         * tui/tui-data.h (MAX_LOCATOR_ELEMENT_LEN)
5872         (struct tui_locator_window): Move to tui-stack.c.
5873         * tui/tui-data.c (_locator, tui_locator_win_info_ptr)
5874         (tui_initialize_static_data): Move to tui-stack.c.
5875
5876 2019-08-15  Tom Tromey  <tom@tromey.com>
5877
5878         * tui/tui-layout.c (show_source_disasm_command)
5879         (show_source_or_disasm_and_command): Use make_visible method, not
5880         tui_make_window.
5881         * tui/tui-command.h (struct tui_cmd_window) <make_visible>:
5882         Remove.
5883
5884 2019-08-15  Tom Tromey  <tom@tromey.com>
5885
5886         * tui/tui-wingeneral.h (tui_make_window): Update.
5887         * tui/tui-wingeneral.c (tui_make_window): Remove "box_it"
5888         parameter.
5889         (tui_gen_win_info::make_visible): Update.
5890         * tui/tui-regs.c (tui_data_window::display_registers_from):
5891         Update.
5892         * tui/tui-layout.c (show_source_disasm_command)
5893         (show_source_or_disasm_and_command): Update.
5894         * tui/tui-data.h (struct tui_gen_win_info) <can_box>: New method.
5895         (enum tui_box): Remove.
5896         (struct tui_win_info) <can_box>: New method.
5897         * tui/tui-command.h (struct tui_cmd_window) <can_box>: New
5898         method.
5899
5900 2019-08-15  Tom de Vries  <tdevries@suse.de>
5901
5902         * linux-nat-trad.c: Include gdbarch.h.
5903
5904 2019-08-14  Alan Hayward  <alan.hayward@arm.com>
5905
5906         * aarch64-tdep.c (aarch64_analyze_prologue): Allow any valid
5907         register sizes.
5908
5909 2019-08-14  Tom Tromey  <tromey@adacore.com>
5910
5911         * darwin-nat.c: Include gdbarch.h.
5912         * darwin-nat-info.c: Include gdbarch.h.
5913
5914 2019-08-13  Tom Tromey  <tom@tromey.com>
5915
5916         * tui/tui-data.h (struct tui_gen_win_info) <last_visible_line>:
5917         Remove.
5918         * tui/tui-data.c (tui_initialize_static_data): Update.
5919
5920 2019-08-13  Tom Tromey  <tom@tromey.com>
5921
5922         * tui/tui-winsource.h (struct tui_exec_info_window)
5923         <~tui_exec_info_window, maybe_allocate_content, get_content,
5924         m_content>: Remove.
5925         (struct tui_source_window_base) <set_exec_info_content,
5926         show_exec_info_content>: Don't declare.
5927         * tui/tui-winsource.c
5928         (tui_exec_info_window::maybe_allocate_content): Remove.
5929         (tui_source_window_base::update_exec_info): Rename from
5930         set_exec_info_content.
5931         (tui_source_window_base::show_exec_info_content)
5932         (tui_source_window_base::update_exec_info): Remove.
5933
5934 2019-08-13  Tom Tromey  <tom@tromey.com>
5935
5936         * tui/tui-winsource.h (tui_clear_exec_info_content): Don't
5937         declare.
5938         * tui/tui-winsource.c (tui_update_source_window_as_is)
5939         (tui_update_source_windows_with_addr, tui_erase_source_content):
5940         Update.
5941         (tui_clear_exec_info_content): Remove.
5942
5943 2019-08-13  Tom Tromey  <tom@tromey.com>
5944
5945         * tui/tui-winsource.h (tui_erase_exec_info_content): Don't
5946         declare.
5947         * tui/tui-winsource.c (tui_source_window_base::refresh_all): Don't
5948         call tui_erase_exec_info_content.
5949         (tui_clear_exec_info_content): Rename from
5950         tui_erase_exec_info_content.
5951         (tui_clear_exec_info_content): Delete.
5952
5953 2019-08-13  Tom Tromey  <tom@tromey.com>
5954
5955         * tui/tui-winsource.h (struct tui_source_window_base)
5956         <show_exec_info_content>: Declare.
5957         (tui_show_exec_info_content): Don't declare.
5958         * tui/tui-winsource.c
5959         (tui_source_window_base::show_exec_info_content): Rename from
5960         tui_show_exec_info_content.
5961         (tui_source_window_base::update_exec_info): Update.
5962
5963 2019-08-13  Tom Tromey  <tom@tromey.com>
5964
5965         * tui/tui-data.h (enum tui_bp_flag, tui_bp_flags, struct tui_source_element)
5966         (TUI_BP_HIT_POS, TUI_BP_BREAK_POS, TUI_EXEC_POS)
5967         (TUI_EXECINFO_SIZE, tui_exec_info_content): Move ...
5968         * tui/tui-winsource.h (enum tui_bp_flag, tui_bp_flags, struct
5969         tui_source_element, TUI_BP_HIT_POS, TUI_BP_BREAK_POS)
5970         (TUI_EXEC_POS, TUI_EXECINFO_SIZE, tui_exec_info_content):
5971         ... here.
5972
5973 2019-08-13  Tom Tromey  <tom@tromey.com>
5974
5975         * tui/tui-winsource.h (struct tui_source_window_base)
5976         <update_exec_info>: Declare.
5977         (tui_update_exec_info): Don't declare.
5978         * tui/tui-winsource.c (tui_update_source_window_as_is)
5979         (tui_source_window_base::refresh_all)
5980         (tui_update_all_breakpoint_info): Update.
5981         (tui_source_window_base::update_exec_info): Rename from
5982         tui_update_exec_info.
5983         * tui/tui-stack.c (tui_show_frame_info): Update.
5984
5985 2019-08-13  Tom Tromey  <tom@tromey.com>
5986
5987         * tui/tui-winsource.h (struct tui_source_window_base)
5988         <set_exec_info_content>: Declare.
5989         (tui_set_exec_info_content): Don't declare.
5990         * tui/tui-winsource.c
5991         (tui_source_window_base::set_exec_info_content): Rename from
5992         tui_set_exec_info_content.
5993         (tui_update_exec_info): Update.
5994
5995 2019-08-13  Tom Tromey  <tom@tromey.com>
5996
5997         * tui/tui-winsource.h (struct tui_source_window_base)
5998         <show_source_content>: Declare.
5999         (tui_show_source_content): Don't declare.
6000         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
6001         (tui_source_window_base::show_source_content): Rename from
6002         tui_show_source_content.
6003         (tui_source_window_base::refresh_all): Update.
6004         * tui/tui-layout.c (show_source_disasm_command)
6005         (show_source_or_disasm_and_command): Update.
6006
6007 2019-08-13  Tom Tromey  <tom@tromey.com>
6008
6009         * tui/tui-winsource.c (tui_erase_source_content)
6010         (tui_show_source_content, tui_source_window_base::refresh_all):
6011         Update.
6012         * tui/tui-wingeneral.h
6013         (tui_check_and_display_highlight_if_needed): Don't declare.
6014         * tui/tui-wingeneral.c
6015         (tui_win_info::check_and_display_highlight_if_needed): Rename from
6016         check_and_display_highlight_if_needed.
6017         * tui/tui-win.c (tui_rehighlight_all)
6018         (tui_win_info::make_visible_with_new_height): Update.
6019         * tui/tui-regs.c (tui_data_window::display_registers_from_line)
6020         (tui_data_window::erase_data_content)
6021         (tui_data_window::display_all_data): Update.
6022         * tui/tui-data.h (struct tui_win_info)
6023         <check_and_display_highlight_if_needed>: Declare.
6024
6025 2019-08-13  Tom Tromey  <tom@tromey.com>
6026
6027         * tui/tui-win.c (tui_resize_all): Call
6028         tui_delete_invisible_windows.
6029         * tui/tui-layout.c (show_layout): Call
6030         tui_delete_invisible_windows.
6031         * tui/tui-data.h (tui_delete_invisible_windows): Declare.
6032         * tui/tui-data.c (tui_delete_invisible_windows): New function.
6033
6034 2019-08-13  Tom Tromey  <tom@tromey.com>
6035
6036         * tui/tui-disasm.c (tui_show_disassem): Add assertion.  Don't call
6037         tui_add_win_to_layout.
6038
6039 2019-08-13  Tom Tromey  <tom@tromey.com>
6040
6041         * tui/tui-layout.h (tui_default_win_height): Don't declare.
6042         * tui/tui-layout.c (tui_default_win_height): Now static.
6043
6044 2019-08-13  Tom Tromey  <tom@tromey.com>
6045
6046         * tui/tui-layout.c (show_layout): Unify all layout cases into a
6047         single switch.
6048         (show_source_disasm_command, show_source_or_disasm_and_command):
6049         Don't check current layout.
6050
6051 2019-08-13  Tom Tromey  <tom@tromey.com>
6052
6053         * tui/tui-wingeneral.c (make_all_visible): Remove.
6054         (tui_make_all_invisible): Simplify.
6055         * tui/tui-layout.c (tui_make_all_invisible): Move from
6056         tui-wingeneral.c; simplify.
6057         (show_layout): Hoist call to tui_make_all_invisible.
6058         (show_data): Don't call tui_make_all_invisible.
6059
6060 2019-08-13  Tom Tromey  <tom@tromey.com>
6061
6062         * tui/tui-wingeneral.h (tui_make_all_visible): Don't declare.
6063         * tui/tui-wingeneral.c (tui_make_all_visible): Remove.
6064
6065 2019-08-13  Tom Tromey  <tom@tromey.com>
6066
6067         * tui/tui-layout.c (current_layout, tui_current_layout): Move from
6068         tui-data.c.
6069         (show_source_disasm_command, show_data)
6070         (show_source_or_disasm_and_command): Don't use
6071         tui_set_current_layout_to.
6072         * tui/tui-data.h (tui_set_current_layout_to): Don't declare.
6073         * tui/tui-data.c (current_layout, tui_current_layout): Move to
6074         tui-layout.c.
6075         (tui_set_current_layout_to): Remove.
6076
6077 2019-08-13  Tom Tromey  <tom@tromey.com>
6078
6079         * tui/tui-layout.c (tui_set_layout): Update.
6080         * tui/tui-data.h (struct tui_layout_def): Remove.
6081         (tui_layout_def): Don't declare.
6082         * tui/tui-data.c (layout_def): Remove.
6083         (tui_layout_def): Remove.
6084
6085 2019-08-13  Tom Tromey  <tom@tromey.com>
6086
6087         * tui/tui-winsource.h (struct tui_source_window_base)
6088         <clear_detail>: No longer "override".
6089         * tui/tui-regs.h (struct tui_data_window) <clear_detail>: Remove.
6090         * tui/tui-regs.c (tui_data_window::clear_detail): Remove.
6091         * tui/tui-data.h (struct tui_win_info) <clear_detail>: Remove.
6092         * tui/tui-command.h (struct tui_cmd_window) <clear_detail>:
6093         Remove.
6094         * tui/tui-command.c (tui_cmd_window::clear_detail): Remove.
6095
6096 2019-08-13  Tom Tromey  <tromey@adacore.com>
6097
6098         * tracepoint.c: Don't include readline.h or history.h.
6099
6100 2019-08-12  Tom Tromey  <tom@tromey.com>
6101
6102         * configure: Rebuild.
6103         * configure.ac: Check for readline 7.
6104         * NEWS: Mention readline 7 requirement.
6105         * README: Update.
6106
6107 2019-08-12  Tom Tromey  <tom@tromey.com>
6108
6109         * mingw-hdep.c (gdb_select): Remove readline hack.
6110
6111 2019-08-09  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
6112
6113         * blockframe.c (find_pc_partial_function): Set *block to nullptr
6114         when the function fails.
6115
6116 2019-08-09  Andreas Arnez  <arnez@linux.ibm.com>
6117
6118         * s390-tdep.c (s390_type_align): New function.
6119         (s390_gdbarch_init): Set it as type_align gdbarch method.
6120
6121 2019-08-09  Tom de Vries  <tdevries@suse.de>
6122
6123         PR gdb/24591
6124         * dwarf2read.c (dwarf2_fetch_die_loc_sect_off): Adjust pc_high and
6125         pc_low with relocation offset.
6126
6127 2019-08-07  Tom Tromey  <tromey@adacore.com>
6128
6129         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
6130         (print_frame_args): Update.
6131         * python/py-framefilter.c (py_print_single_arg, enumerate_args):
6132         Update.
6133         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
6134         * frame.h (struct frame_arg): Add initializers.
6135         <error>: Now a unique_xmalloc_ptr.
6136
6137 2019-08-07  Alan Hayward  <alan.hayward@arm.com>
6138
6139         * NEWS: Expand the Pointer Authentication entry.
6140         * aarch64-tdep.c (aarch64_frame_unmask_address): Rename from this.
6141         (aarch64_frame_unmask_lr): ... to this.
6142         (aarch64_prologue_prev_register, aarch64_dwarf2_prev_register):
6143         Call aarch64_frame_unmask_lr.
6144         * frame.c (struct frame_info): Add "masked" variable.
6145         (frame_set_previous_pc_masked) (frame_get_pc_masked): New functions.
6146         (fprint_frame): Check for masked pc.
6147         * frame.h (frame_set_previous_pc_masked) (frame_get_pc_masked): New
6148         declarations.
6149         * python/py-framefilter.c (py_print_frame): Check for masked pc.
6150         * stack.c (print_frame): Check for masked pc.
6151
6152 2019-08-06  Tom Tromey  <tom@tromey.com>
6153
6154         * stabsread.c (patch_block_stabs, read_one_struct_field)
6155         (read_enum_type): Use obstack_strndup.
6156         * rust-exp.y (rust_parser::copy_name): Use obstack_strndup.
6157         * gdb_obstack.h (obstack_strndup): Use obstack_strndup.
6158         * dwarf2read.c (guess_full_die_structure_name)
6159         (anonymous_struct_prefix): Use obstack_strndup.
6160         * dbxread.c (cp_set_block_scope): Use obstack_strndup.
6161         * c-exp.y (yylex): Use obstack_strndup.
6162         * ada-exp.y (write_object_renaming, write_ambiguous_var)
6163         (write_var_or_type): Use obstack_strndup.
6164
6165 2019-08-06  Tom Tromey  <tom@tromey.com>
6166
6167         * symfile.c (reread_symbols): Use obstack_strdup.
6168         * stabsread.c (read_type): Use obstack_strdup.
6169         * gdb_obstack.h (obstack_strdup): New overload.
6170         * dwarf2read.c (dwarf2_compute_name, create_dwo_unit_in_dwp_v1)
6171         (create_dwo_unit_in_dwp_v2, build_error_marker_type)
6172         (dwarf2_canonicalize_name): Use obstack_strdup.
6173         * dbxread.c (read_dbx_symtab): Use obstack_strdup.
6174         * cp-support.c (inspect_type, replace_typedefs_qualified_name):
6175         Use obstack_strdup.
6176
6177 2019-08-06  Tom Tromey  <tom@tromey.com>
6178
6179         * gdb_obstack.h (obstack_strdup): Define.
6180         * gdb_obstack.c (obstack_strdup): Don't define.
6181
6182 2019-08-06  Tom Tromey  <tom@tromey.com>
6183
6184         * xcoffread.c (SYMNAME_ALLOC, process_xcoff_symbol): Use
6185         obstack_strdup.
6186         * typeprint.c (typedef_hash_table::find_global_typedef): Use
6187         obstack_strdup.
6188         * symfile.c (allocate_compunit_symtab): Use obstack_strdup.
6189         * stabsread.c (common_block_start): Use obstack_strdup.
6190         * objfiles.c (set_objfile_main_name, objfile): Use
6191         obstack_strdup.
6192         * namespace.c (add_using_directive): Use obstack_strdup.
6193         * mdebugread.c (parse_symbol, parse_type): Use obstack_strdup.
6194         * jit.c (finalize_symtab): Use obstack_strdup.
6195         * dwarf2read.c (fixup_go_packaging, dwarf2_physname)
6196         (guess_partial_die_structure_name, partial_die_info::fixup)
6197         (dwarf2_name): Use obstack_strdup.
6198         * coffread.c (coff_read_struct_type, coff_read_enum_type): Use
6199         obstack_strdup.
6200         * c-exp.y (scan_macro_expansion): Use obstack_strdup.
6201         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
6202         obstack_strdup.
6203         * ada-lang.c (ada_decode_symbol): Use obstack_strdup.
6204
6205 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6206
6207         * unittests/help-doc-selftests.c: New file.
6208         * Makefile.in: Add the new file.
6209
6210 2019-08-07  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6211
6212         * cli/cli-decode.h (print_doc_line): Add for_value_prefix argument.
6213         * cli/cli-decode.c (print_doc_line): Likewise.  It now prints
6214         the full first line, except when FOR_VALUE_PREFIX.  In this case,
6215         the trailing '.' is not output, and the first character is uppercased.
6216         (print_help_for_command): Update call to print_doc_line.
6217         (print_doc_of_command): Likewise.
6218         * cli/cli-setshow.c (deprecated_show_value_hack): Likewise.
6219         * cli/cli-option.c (append_indented_doc): Do not append newline.
6220         (build_help_option): Append newline after first appended_indented_doc
6221         only if a second call is done.
6222         (build_help): Append 2 new lines before each option, except the first
6223         one.
6224         * compile/compile.c (_initialize_compile): Add new lines after
6225         %OPTIONS%, when not at the end of the help.
6226         Change help doc or code
6227         producing the help doc to respect the invariants.
6228         * maint-test-options.c (_initialize_maint_test_options): Likewise.
6229         Also removed the new line after 'Options:', as all other commands
6230         do not put an empty line between 'Options:' and the first option.
6231         * printcmd.c (_initialize_printcmd): Likewise.
6232         * stack.c (_initialize_stack): Likewise.
6233         * interps.c (interpreter_exec_cmd): Fix "Usage:" line that was
6234         incorrectly telling COMMAND is optional.
6235         * ada-lang.c (_initialize_ada_language): Change help doc or code
6236         producing the help doc to respect the invariants.
6237         * ada-tasks.c (_initialize_ada_tasks): Likewise.
6238         * breakpoint.c (_initialize_breakpoint): Likewise.
6239         * cli/cli-cmds.c (_initialize_cli_cmds): Likewise.
6240         * cli/cli-logging.c (_initialize_cli_logging): Likewise.
6241         * cli/cli-setshow.c (_initialize_cli_setshow): Likewise.
6242         * cli/cli-style.c (cli_style_option::add_setshow_commands,
6243         _initialize_cli_style): Likewise.
6244         * corelow.c (core_target_info): Likewise.
6245         * dwarf-index-cache.c (_initialize_index_cache): Likewise.
6246         * dwarf2read.c (_initialize_dwarf2_read): Likewise.
6247         * filesystem.c (_initialize_filesystem): Likewise.
6248         * frame.c (_initialize_frame): Likewise.
6249         * gnu-nat.c (add_task_commands): Likewise.
6250         * infcall.c (_initialize_infcall): Likewise.
6251         * infcmd.c (_initialize_infcmd): Likewise.
6252         * interps.c (_initialize_interpreter): Likewise.
6253         * language.c (_initialize_language): Likewise.
6254         * linux-fork.c (_initialize_linux_fork): Likewise.
6255         * maint-test-settings.c (_initialize_maint_test_settings): Likewise.
6256         * maint.c (_initialize_maint_cmds): Likewise.
6257         * memattr.c (_initialize_mem): Likewise.
6258         * printcmd.c (_initialize_printcmd): Likewise.
6259         * python/lib/gdb/function/strfns.py (_MemEq, _StrLen, _StrEq,
6260         _RegEx): Likewise.
6261         * ravenscar-thread.c (_initialize_ravenscar): Likewise.
6262         * record-btrace.c (_initialize_record_btrace): Likewise.
6263         * record-full.c (_initialize_record_full): Likewise.
6264         * record.c (_initialize_record): Likewise.
6265         * regcache-dump.c (_initialize_regcache_dump): Likewise.
6266         * regcache.c (_initialize_regcache): Likewise.
6267         * remote.c (add_packet_config_cmd, init_remote_threadtests,
6268         _initialize_remote): Likewise.
6269         * ser-tcp.c (_initialize_ser_tcp): Likewise.
6270         * serial.c (_initialize_serial): Likewise.
6271         * skip.c (_initialize_step_skip): Likewise.
6272         * source.c (_initialize_source): Likewise.
6273         * stack.c (_initialize_stack): Likewise.
6274         * symfile.c (_initialize_symfile): Likewise.
6275         * symtab.c (_initialize_symtab): Likewise.
6276         * target-descriptions.c (_initialize_target_descriptions): Likewise.
6277         * top.c (init_main): Likewise.
6278         * tracefile-tfile.c (tfile_target_info): Likewise.
6279         * tracepoint.c (_initialize_tracepoint): Likewise.
6280         * tui/tui-win.c (_initialize_tui_win): Likewise.
6281         * utils.c (add_internal_problem_command): Likewise.
6282         * valprint.c (value_print_option_defs): Likewise.
6283
6284 2019-08-06  Frank Ch. Eigler  <fche@redhat.com>
6285
6286         PR build/24886
6287         * configure.ac: Drop enable-libmcheck support.
6288         * configure, config.in: Rebuild.
6289         * libmcheck.m4: Remove.
6290         * acinclude.m4: Don't include it.
6291         * Makefile.in: Don't distribute it.
6292         * top.c (print_gdb_configuration): Don't mention it.
6293
6294 2019-08-06  Tom Tromey  <tom@tromey.com>
6295
6296         * utils.c (set_output_style): Sometimes pass stream to
6297         emit_style_escape.
6298         * ui-out.h (class ui_out) <can_emit_style_escape>: Declare.
6299         * record-btrace.c (btrace_insn_history): Update.
6300         * mi/mi-out.h (class mi_ui_out) <can_emit_style_escape>: New
6301         method.
6302         * disasm.h (gdb_pretty_print_disassembler): Add uiout parameter.
6303         Update initializers.
6304         <m_uiout>: New field.
6305         <m_di>: Move lower.
6306         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6307         Remove "uiout" parameter.
6308         (dump_insns): Update.
6309         * cli-out.h (class cli_ui_out) <can_emit_style_escape>: Declare.
6310         * cli-out.c (cli_ui_out::can_emit_style_escape): New method.
6311
6312 2019-08-06  Christian Biesinger  <cbiesinger@google.com>
6313
6314         * symtab.c (symbol_cache_lookup): Change int to enum block_enum.
6315         (error_in_psymtab_expansion): Likewise.
6316         (lookup_symbol_via_quick_fns): Likewise.
6317         (basic_lookup_transparent_type_quick): Likewise.
6318         (basic_lookup_transparent_type_1): Likewise.
6319
6320 2019-08-06  Tom Tromey  <tromey@adacore.com>
6321
6322         * source.c (last_source_error): Now bool.
6323         (print_source_lines_base): Make "noprint" bool.  Only open
6324         source file when last_source_visited changes.
6325
6326 2019-08-06  Tom Tromey  <tromey@adacore.com>
6327
6328         * annotate.c (annotate_source_line): Use g_source_cache.
6329         * source-cache.c (source_cache::get_plain_source_lines): Change
6330         parameters.  Populate m_offset_cache.
6331         (source_cache::ensure): New method.
6332         (source_cache::get_line_charpos): New method.
6333         (extract_lines): Move lower.  Change parameters.
6334         (source_cache::get_source_lines): Move lower.
6335         * source-cache.h (class source_cache): Update comment.
6336         <get_line_charpos>: New method.
6337         <get_source_lines>: Update comment.
6338         <clear>: Clear m_offset_cache.
6339         <get_plain_source_lines>: Change parameters.
6340         <ensure>: New method
6341         <m_offset_cache>: New member.
6342         * source.c (forget_cached_source_info_for_objfile): Update.
6343         (info_source_command): Use g_source_cache.
6344         (find_source_lines, open_source_file_with_line_charpos): Remove.
6345         (print_source_lines_base, search_command_helper): Use g_source_cache.
6346         * source.h (open_source_file_with_line_charpos): Don't declare.
6347         * symtab.h (struct symtab) <nlines, line_charpos>: Remove.
6348         * tui/tui-source.c (tui_source_window::do_scroll_vertical):
6349         Use g_source_cache.
6350
6351 2019-08-06  Tom Tromey  <tromey@adacore.com>
6352
6353         * source-cache.c (source_cache::get_plain_source_lines):
6354         Remove "first_line" and "last_line" parameters.
6355         (source_cache::get_source_lines): Cache plain text.
6356         * source-cache.h (class source_cache)
6357         <get_plain_source_lines>: Update.
6358
6359 2019-08-06  Tom Tromey  <tromey@adacore.com>
6360
6361         * source-cache.c (extract_lines): No longer a method.
6362         Changed type of parameter.  Include final newline.
6363         (selftests::extract_lines_test): New function.
6364         (_initialize_source_cache): Likewise.
6365         * source-cache.h (class source_cache)
6366         <extract_lines>: Don't declare.
6367
6368 2019-08-06  Tom Tromey  <tromey@adacore.com>
6369
6370         * breakpoint.c (init_breakpoint_sal): Update.
6371         (breakpoint): Update.
6372         * breakpoint.h (struct breakpoint) <filter>: Now a
6373         unique_xmalloc_ptr.
6374
6375 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6376
6377         * NEWS: Mention dictionary access on blocks.
6378         * python/py-block.c (blpy_getitem): New function.
6379         (block_object_as_mapping): New struct.
6380         (block_object_type): Use new struct for tp_as_mapping field.
6381
6382 2019-08-05  Christian Biesinger  <cbiesinger@google.com>
6383
6384         * objfiles.h (objfile): Add a comment describing partial symbols.
6385
6386 2019-08-05  Tom Tromey  <tromey@adacore.com>
6387
6388         * compile/compile.c (_initialize_compile): Use _(), not N_().
6389         * thread.c (_initialize_thread): Use _(), not N_().
6390         * stack.c (_initialize_stack): Use _(), not N_().
6391         * printcmd.c (_initialize_printcmd): Use _(), not N_().
6392
6393 2019-08-04  Simon Marchi  <simon.marchi@polymtl.ca>
6394
6395         * dwarf2read.c (struct dw2_symtab_iterator):
6396         <want_specific_block>: Remove.
6397         <block_index>: Change type to gdb::optional.
6398         (dw2_symtab_iter_init): Remove WANT_SPECIFIC_BLOCK parameter,
6399         change type of BLOCK_INDEX parameter to gdb::optional.
6400         (dw2_symtab_iter_next): Re-write in function of gdb::optional.
6401         (dw2_lookup_symbol): Don't pass argument for
6402         WANT_SPECIFIC_BLOCK.
6403         (dw2_expand_symtabs_for_function): Don't pass argument for
6404         WANT_SPECIFIC_BLOCK, pass empty optional for BLOCK_INDEX.
6405         (class dw2_debug_names_iterator)
6406         <dw2_debug_names_iterator>: Remove WANT_SPECIFIC_BLOCK
6407         parameter, change BLOCK_INDEX type to gdb::optional.
6408         <m_want_specific_block>: Remove.
6409         <m_block_index>: Change type to gdb::optional.
6410         (dw2_debug_names_iterator::next): Change type of IS_STATIC to
6411         gdb::optional.  Re-write in function of gdb::optional.
6412         (dw2_debug_names_lookup_symbol): Don't pass argument for
6413         WANT_SPECIFIC_BLOCK.
6414         (dw2_debug_names_expand_symtabs_for_function): Don't pass
6415         argument for WANT_SPECIFIC_BLOCK, pass empty optional for
6416         BLOCK_INDEX.
6417
6418 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6419
6420         * NEWS: Mention changes to "info sources" command.
6421
6422 2019-08-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6423
6424         * symtab.c (filename_partial_match_opts): New struct type.
6425         (struct output_source_filename_data): New members
6426         regexp, c_regexp, partial_match.
6427         (output_source_filename): Use new members to decide to print file.
6428         (info_sources_option_defs): New variable.
6429         (make_info_sources_options_def_group, print_info_sources_header,
6430         info_sources_command_completer):
6431         New functions.
6432         (info_sources_command): Read new optional arguments.
6433         (_initialize_symtab): Update info sources help.
6434
6435 2019-08-02  Alexandre Oliva <oliva@adacore.com>
6436
6437         * ada-lang.c (exception_support_info_v0): Renamed from...
6438         (default_exception_support_info): ... this.  Create new
6439         definition for v1.
6440         (ada_has_this_exception_support): Look up catch_handlers_sym.
6441         (ada_exception_support_info_sniffer): Try v0 after default.
6442
6443 2019-08-01  Tom Tromey  <tromey@adacore.com>
6444
6445         * ia64-libunwind-tdep.h (struct libunwind_descr): Include
6446         gdbarch.h.
6447
6448 2019-08-01  Christian Biesinger  <cbiesinger@google.com>
6449
6450         * s12z-tdep.c: Fix include path for s12z-opc.h.
6451
6452 2019-08-01  Alan Hayward  <alan.hayward@arm.com>
6453
6454         * NEWS: Require GNU make 3.82.
6455
6456 2019-07-16  Tom Tromey  <tom@tromey.com>
6457
6458         * tui/tui-wingeneral.h (tui_copy_win, tui_box_win): Don't
6459         declare.
6460
6461 2019-07-30  Tom Tromey  <tromey@adacore.com>
6462
6463         * block.c (contained_in): Remove BLOCK_FUNCTION check.
6464
6465 2019-07-30  Kevin Buettner  <kevinb@redhat.com>
6466
6467         * printcmd.c (print_address_symbolic): Print negative offsets.
6468         (build_address_symbolic): Force signed arithmetic when computing
6469         offset.
6470
6471 2019-07-30  Christian Biesinger  <cbiesinger@google.com>
6472
6473         PR/24474: Add a function to lookup static variables.
6474         * NEWS: Mention this new function.
6475         * python/py-symbol.c (gdbpy_lookup_static_symbol): New function.
6476         * python/python-internal.h (gdbpy_lookup_static_symbol): New function.
6477         * python/python.c (python_GdbMethods): Add new function.
6478
6479 2019-07-29  Christian Biesinger  <cbiesinger@google.com>
6480
6481         * NEWS: Mention new functions Objfile.lookup_{global,static}_symbol.
6482         * python/py-objfile.c (objfpy_lookup_global_symbol): New function.
6483         (objfpy_lookup_static_symbol): New function.
6484         (objfile_object_methods): Add new functions.
6485
6486 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6487
6488         * NEWS: Mention 'set|show print frame-info'.  Mention new
6489         'presence' value for 'frame-arguments'.  Mention new '-frame-info'
6490         backtrace argument.  Mention that python frame filtering code
6491         is now consistent with what 'backtrace' command prints.
6492
6493 2019-07-29  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
6494
6495         * frame.h (enum print_what): New value 'SHORT_LOCATION', update
6496         comments.
6497         (print_frame_info_auto, print_frame_info_source_line,
6498         print_frame_info_location, print_frame_info_source_and_location,
6499         print_frame_info_location_and_address, print_frame_info_short_location):
6500         New declarations.
6501         (struct frame_print_options): New member print_frame_info.
6502         * extension.h (enum ext_lang_frame_args): New value CLI_PRESENCE.
6503         * stack.h (get_user_print_what_frame_info): New declaration.
6504         (frame_show_address): New declaration.
6505         * stack.c (print_frame_arguments_choices): New value 'presence'.
6506         (print_frame_info_auto, print_frame_info_source_line,
6507         print_frame_info_location, print_frame_info_source_and_location,
6508         print_frame_info_location_and_address, print_frame_info_short_location,
6509         print_frame_info_choices, print_frame_info_print_what): New definitions.
6510         (print_frame_args): Only print dots for args if print frame-arguments
6511         is 'presence'.
6512         (frame_print_option_defs): New element for "frame-info".
6513         (get_user_print_what_frame_info): New function.
6514         (frame_show_address): Make non static.  Move comment to stack.h.
6515         (print_frame_info_to_print_what): New function.
6516         (print_frame_info): Update comment.  Use fp_opts.print_frame_info
6517         to decide what to print.
6518         (backtrace_command_1): Handle the new print_frame_arguments_presence
6519         value.
6520         (_initialize_stack): Call add_setshow_enum_cmd for frame-info.
6521         * python/py-framefilter.c (py_print_args): Handle CLI_PRESENCE.
6522         (py_print_frame): In non-mi mode, use LOCATION as default for
6523         print_what, similarly to frame information printed directly by
6524         backtrace command. Handle frame-info user option in non MI mode.
6525
6526 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6527
6528         * linux-thread-db.c (thread_db_target::thread_handle_to_thread_info):
6529         Add case for debugging 32-bit target on 64-bit host.  Revise
6530         comment.
6531
6532 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6533
6534         * infrun.c (fill_in_stop_func): Use find_pc_partial_function
6535         instead of find_function_entry_range_from_pc.
6536
6537 2019-07-27  Kevin Buettner  <kevinb@redhat.com>
6538
6539         * stack.c (find_frame_funname): Remove code which preferred
6540         minsym over symtab sym in "certain pathological cases".
6541
6542         * valprint.h (build_address_symbolic): Add "prefer_sym_over_minsym"
6543         parameter.  Change type of "do_demangle" to bool.
6544         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
6545         Pass suitable "prefer_sym_over_minsym" flag to
6546         build_address_symbolic().  Don't output "+" for negative offsets.
6547         * printcmd.c (print_address_symbolic): Update invocation of
6548         build_address_symbolic to include a "prefer_sym_over_minsym"
6549         flag.
6550         (build_address_symbolic): Add "prefer_sym_over_minsym" parameter.
6551         Restrict cases in which use of minimal symbol is preferred to that
6552         of a found symbol.  Update comments.
6553
6554         * dwarf2-frame.c (dwarf2_frame_cache): Don't decode FDE instructions
6555         for entry pc when entry pc is out of range for that FDE.
6556
6557 2019-07-26  Brian Callahan  <bcallah@openbsd.org>
6558
6559         PR gdb/24839:
6560         * gdb/obsd-nat.c (obsd_nat_target::pid_to_str): Fix typo in return
6561         type.
6562
6563 2019-07-25  Christian Biesinger  <cbiesinger@google.com>
6564
6565         * python/py-objfile.c (add_separate_debug_file): Fix comment about
6566         this function's Python signature.
6567
6568
6569 2019-07-24  Christian Biesinger  <cbiesinger@google.com>
6570
6571         * compile/compile-object-load.c (compile_object_load): Pass GLOBAL_SCOPE.
6572         * solib-spu.c (spu_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6573         * solib-svr4.c (elf_lookup_lib_symbol): Pass GLOBAL_SCOPE.
6574         * symtab.c (lookup_global_symbol_from_objfile): Add a scope parameter.
6575         * symtab.h (lookup_global_symbol_from_objfile): Likewise.
6576
6577
6578 2019-07-24  Yoshinori Sato  <ysato@users.sourceforge.jp>
6579
6580         * h8300-tdep.c (h8300_register_name_common): New.
6581         h8300_register_name): Use h8300_register_name_common.
6582         (h8300s_register_name): Likewise.
6583         (h8300sx_register_name): Likewise.
6584         (h8300h_register_nam): New.
6585         (h8300_gdbarch_init): Use h8300h_register_name in h8300h machine.
6586
6587
6588 2019-07-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>
6589
6590         * arm-tdep.c (arm_skip_cmse_entry): New function.
6591         (arm_is_sgstubs_section): New function.
6592         (arm_skip_stub): Add call to arm_skip_cmse_entry function.
6593
6594 2019-07-22  Tom Tromey  <tom@tromey.com>
6595
6596         * tui/tui-win.c (tui_win_info::make_invisible_and_set_new_height):
6597         Don't self-assign.
6598
6599 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6600
6601         * c-typeprint.c (c_print_typedef): Pass -1 instead of 0 to
6602         type_print.
6603
6604 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6605
6606         * symtab.c (search_symbols): Adjust msymbol matching type arrays
6607         so that GDB doesn't match any msymbols when searching in the
6608         TYPES_DOMAIN.
6609         (print_symbol_info): Print using typedef_print or type_print based
6610         on the type of the symbol.  Add updated FIXME comment moved from...
6611         (_initialize_symtab): ... move and update FIXME comment to above.
6612
6613 2019-07-22  Andrew Burgess  <andrew.burgess@embecosm.com>
6614
6615         * NEWS: Mention adding -q option to "info types".
6616         * symtab.c (struct info_types_options): New struct.
6617         (info_types_options_defs): New variable.
6618         (make_info_types_options_def_group): New function.
6619         (info_types_command): Use gdb::option framework to parse options.
6620         (info_types_command_completer): New function.
6621         (_initialize_symtab): Extend the help text on "info types" and
6622         register command completer.
6623
6624 2019-07-21  Christian Biesinger  <cbiesinger@google.com>
6625
6626         * symtab.c (lookup_symbol_in_objfile_symtabs): Change int to block_enum.
6627         (lookup_symbol_in_objfile): Change int to block_enum and add a
6628         gdb_assert to make sure block_index is GLOBAL_BLOCK or STATIC_BLOCK.
6629
6630 2019-07-20  Christian Biesinger  <cbiesinger@google.com>
6631
6632         * MAINTAINERS (Write After Approval): Add self.
6633
6634 2019-07-19  Andrew Burgess  <andrew.burgess@embecosm.com>
6635
6636         * riscv-tdep.c (riscv_push_dummy_code): Write a 4-byte nop
6637         instruction to the dummy code region.
6638
6639 2019-07-19  Tom Tromey  <tromey@adacore.com>
6640
6641         * contrib/ari/gdb_ari.sh: Mention C++11, not ISO C 90.
6642         (ARGSUSED, PARAMS, __func__): Remove rules.
6643
6644 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6645
6646         * arm-tdep.c (_initialize_arm_tdep): Remove xml tests.
6647         * features/arm/arm-with-iwmmxt.c: Remove.
6648         * features/arm/arm-with-iwmmxt.xml: Remove.
6649         * features/arm/arm-with-m-fpa-layout.c: Remove.
6650         * features/arm/arm-with-m-fpa-layout.xml: Remove.
6651         * features/arm/arm-with-m-vfp-d16.c: Remove.
6652         * features/arm/arm-with-m-vfp-d16.xml: Remove.
6653         * features/arm/arm-with-m.c: Remove.
6654         * features/arm/arm-with-m.xml: Remove.
6655         * features/arm/arm-with-neon.c: Remove.
6656         * features/arm/arm-with-neon.xml: Remove.
6657         * features/arm/arm-with-vfpv2.c: Remove.
6658         * features/arm/arm-with-vfpv2.xml: Remove.
6659         * features/arm/arm-with-vfpv3.c: Remove.
6660         * features/arm/arm-with-vfpv3.xml: Remove.
6661
6662 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6663
6664         * arm-tdep.c (_initialize_arm_tdep): Add xml regression tests.
6665
6666 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6667
6668         * arch/aarch32.c (aarch32_create_target_description): Create
6669         target descriptions using features.
6670         * arch/arm.c (arm_create_target_description)
6671         (arm_create_mprofile_target_description): Likewise.
6672         * arm-tdep.c (_initialize_arm_tdep): Remove tdesc init calls.
6673
6674 2019-07-19  Alan Hayward  <alan.hayward@arm.com>
6675
6676         * Makefile.in: Add new files.
6677         * aarch32-tdep.c: New file.
6678         * aarch32-tdep.h: New file.
6679         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
6680         Call aarch32_read_description.
6681         * arch/aarch32.c: New file.
6682         * arch/aarch32.h: New file.
6683         * arch/arm.c (arm_create_target_description)
6684         (arm_create_mprofile_target_description): New function.
6685         * arch/arm.h (arm_fp_type, arm_m_profile_type): New enum.
6686         (arm_create_target_description)
6687         (arm_create_mprofile_target_description): New declaration.
6688         * arm-fbsd-tdep.c (arm_fbsd_read_description_auxv): Call
6689         read_description functions.
6690         * arm-linux-nat.c (arm_linux_nat_target::read_description):
6691         Likewise.
6692         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
6693         * arm-tdep.c (tdesc_arm_list): New variable.
6694         (arm_register_g_packet_guesses): Call create description functions.
6695         (arm_read_description) (arm_read_mprofile_description): New
6696         function.
6697         * arm-tdep.h (arm_read_description)
6698         (arm_read_mprofile_description): Add declaration.
6699         * configure.tgt: Add new files.
6700
6701 2019-07-18  Guillaume LABARTHE  <guillaume.labarthe@gmail.com>
6702
6703         * top.c (new_ui_command): Open specified terminal just once.
6704
6705 2019-07-18  Tom Tromey  <tromey@adacore.com>
6706
6707         * symtab.c (main_name): Constify return type.
6708         * symfile.c (set_initial_language): Update.
6709         * symtab.h (main_name): Constify return type.
6710
6711 2019-07-17  Tom Tromey  <tom@tromey.com>
6712
6713         * tui/tui-winsource.c (tui_update_source_window)
6714         (tui_update_source_window_as_is)
6715         (tui_update_source_windows_with_line): Remove return.
6716         * tui/tui-disasm.c (tui_show_disassem)
6717         (tui_show_disassem_and_update_source): Remove return.
6718         * tui/tui.c (tui_reset): Remove return.
6719         * tui/tui-wingeneral.c
6720         (tui_check_and_display_highlight_if_needed): Remove return.
6721
6722 2019-07-17  Tom Tromey  <tom@tromey.com>
6723
6724         * tui/tui-win.c (parse_scrolling_args): Throw separate errors.
6725
6726 2019-07-17  Tom Tromey  <tom@tromey.com>
6727
6728         * tui/tui-winsource.h (struct tui_exec_info_window)
6729         (struct tui_source_window_base): Move from tui-data.h.
6730         * tui/tui-winsource.c: Move many method definitions from
6731         elsewhere.  Remove "structuring" comments.
6732         * tui/tui-wingeneral.c (tui_source_window_base::make_visible)
6733         (tui_source_window_base::refresh_window): Move to
6734         tui-winsource.c.
6735         * tui/tui-win.c (tui_source_window_base::refresh_all)
6736         (tui_source_window_base::update_tab_width)
6737         (tui_source_window_base::set_new_height)
6738         (tui_source_window_base::do_make_visible_with_new_height): Move to
6739         tui-winsource.c.
6740         * tui/tui-source.h: Update.
6741         * tui/tui-source.c (tui_source_window_base::reset): Move to
6742         tui-winsource.c.
6743         * tui/tui-disasm.h: Update.
6744         * tui/tui-data.h (struct tui_exec_info_window): Move to
6745         tui-winsource.h.
6746         (struct tui_source_window_base): Likewise.
6747         * tui/tui-data.c (tui_source_window_base::clear_detail)
6748         (tui_source_window_base, ~tui_source_window_base): Move to
6749         tui-winsource.c.
6750
6751 2019-07-17  Tom Tromey  <tom@tromey.com>
6752
6753         * tui/tui-win.c (tui_resize_all)
6754         (tui_source_window_base::update_tab_width)
6755         (tui_adjust_win_heights): Update.
6756         (tui_win_info::make_invisible_and_set_new_height): Rename from
6757         make_invisible_and_set_new_height.
6758         * tui/tui-data.h (struct tui_win_info)
6759         <make_invisible_and_set_new_height>: New method.
6760
6761 2019-07-17  Tom Tromey  <tom@tromey.com>
6762
6763         * tui/tui.c: Update.
6764         * tui/tui-source.h (struct tui_source_window): Move from
6765         tui-data.h.
6766         * tui/tui-layout.c: Update.
6767         * tui/tui-disasm.c: Update.
6768         * tui/tui-data.h (struct tui_source_window): Move to
6769         tui-source.h.
6770
6771 2019-07-17  Tom Tromey  <tom@tromey.com>
6772
6773         * tui/tui-disasm.h (struct tui_disasm_window): Move from
6774         tui-data.h.
6775         * tui/tui-data.h (struct tui_disasm_window): Move to
6776         tui-disasm.h.
6777
6778 2019-07-17  Tom Tromey  <tom@tromey.com>
6779
6780         * tui/tui-regs.h (struct tui_data_item_window): Move from
6781         tui-data.h.
6782         * tui/tui-regs.c (tui_data_item_window): Move from tui-data.c.
6783         * tui/tui-data.h (struct tui_data_item_window): Move to
6784         tui-regs.h.
6785         * tui/tui-data.c (~tui_data_item_window): Move to tui-regs.c.
6786
6787 2019-07-17  Tom Tromey  <tom@tromey.com>
6788
6789         * tui/tui.c: Update.
6790         * tui/tui-win.c (tui_cmd_window::do_make_visible_with_new_height)
6791         (tui_cmd_window::max_height): Move to tui-command.c.
6792         * tui/tui-layout.c: Update.
6793         * tui/tui-data.h (struct tui_cmd_window): Move to tui-command.h.
6794         * tui/tui-data.c (tui_cmd_window::clear_detail): Move to
6795         tui-command.c.
6796         * tui/tui-command.h (struct tui_cmd_window): Move from
6797         tui-data.h.
6798         * tui/tui-command.c: Remove "structuring" comments.
6799         (tui_cmd_window::clear_detail)
6800         (tui_cmd_window::do_make_visible_with_new_height)
6801         (tui_cmd_window::max_height): Move from elsewhere.
6802
6803 2019-07-17  Tom Tromey  <tom@tromey.com>
6804
6805         * tui/tui-io.c (tui_dispatch_ctrl_char): Move from tui-command.c.
6806         Now static.
6807         * tui/tui-command.h (tui_dispatch_ctrl_char): Don't declare.
6808         * tui/tui-command.c (tui_dispatch_ctrl_char): Move to tui-io.c.
6809
6810 2019-07-17  Tom Tromey  <tom@tromey.com>
6811
6812         * tui/tui.c: Update.
6813         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Move to
6814         tui-regs.c.
6815         * tui/tui-windata.h: Remove file.
6816         * tui/tui-windata.c: Remove file.
6817         * tui/tui-win.c (tui_data_window::set_new_height)
6818         (tui_data_window::do_make_visible_with_new_height): Move to
6819         tui-regs.c.
6820         * tui/tui-regs.h (struct tui_data_window): Move from tui-data.h.
6821         * tui/tui-regs.c: Remove "structuring" comments.
6822         (tui_data_window::first_data_item_displayed)
6823         (tui_data_window::delete_data_content_windows)
6824         (tui_data_window::erase_data_content)
6825         (tui_data_window::display_all_data)
6826         (tui_data_window::refresh_all)
6827         (tui_data_window::do_scroll_vertical)
6828         (tui_data_window::clear_detail, tui_data_window::set_new_height)
6829         (tui_data_window::do_make_visible_with_new_height)
6830         (tui_data_window::refresh_window): Move from elsewhere.
6831         (_initialize_tui_regs): Move to end of file.
6832         * tui/tui-layout.c: Update.
6833         * tui/tui-hooks.c: Update.
6834         * tui/tui-data.h (struct tui_data_window): Move to tui-regs.h.
6835         * tui/tui-data.c (tui_data_window::clear_detail): Move to
6836         tui-regs.c.
6837         * Makefile.in (SUBDIR_TUI_SRCS): Remove tui-windata.c.
6838
6839 2019-07-17  Tom Tromey  <tom@tromey.com>
6840
6841         * tui/tui-io.c (tui_puts_internal): Call wrefresh if newline is
6842         seen.
6843
6844 2019-07-17  Tom Tromey  <tom@tromey.com>
6845
6846         * tui/tui-win.c (tui_source_window_base::set_new_height)
6847         (tui_source_window_base::do_make_visible_with_new_height): Use
6848         m_has_locator field directly.
6849         * tui/tui-data.h (struct tui_win_info) <has_locator>: Remove
6850         method.
6851         (struct tui_source_window_base) <has_locator>: Likewise.
6852
6853 2019-07-17  Tom Tromey  <tom@tromey.com>
6854
6855         * tui/tui-wingeneral.h (tui_make_visible, tui_make_invisible):
6856         Don't declare.
6857         * tui/tui-wingeneral.c (tui_make_visible, tui_make_invisible):
6858         Remove.
6859         * tui/tui-win.c (tui_source_window_base::set_new_height)
6860         (tui_source_window_base::set_new_height)
6861         (make_invisible_and_set_new_height)
6862         (tui_source_window_base::do_make_visible_with_new_height)
6863         (tui_source_window_base::do_make_visible_with_new_height):
6864         Update.
6865         * tui/tui-layout.c (show_source_disasm_command, show_data)
6866         (show_source_or_disasm_and_command): Update.
6867         * tui/tui-layout.c (show_layout): Update.
6868
6869 2019-07-17  Tom Tromey  <tom@tromey.com>
6870
6871         * tui/tui-layout.c (make_data_window): Remove.
6872         (show_data): Unify creation and re-initialization cases.
6873
6874 2019-07-17  Tom Tromey  <tom@tromey.com>
6875
6876         * tui/tui-layout.c (make_source_window, make_disasm_window):
6877         Remove.
6878         (show_data): Unify creation and re-initialization cases.
6879
6880 2019-07-17  Tom Tromey  <tom@tromey.com>
6881
6882         * tui/tui-layout.c (make_command_window): Remove.
6883         (show_source_disasm_command, show_source_or_disasm_and_command):
6884         Unify creation and re-initialization cases.
6885
6886 2019-07-17  Tom Tromey  <tom@tromey.com>
6887
6888         * tui/tui-layout.c (show_source_or_disasm_and_command): Unify
6889         creation and re-initialization cases.
6890
6891 2019-07-17  Tom Tromey  <tom@tromey.com>
6892
6893         * tui/tui-regs.c (tui_get_register): Return void.
6894
6895 2019-07-17  Tom Tromey  <tom@tromey.com>
6896
6897         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible):
6898         Simplify.
6899
6900 2019-07-17  Tom Tromey  <tom@tromey.com>
6901
6902         * tui/tui-layout.c (show_source_disasm_command): Simplify window
6903         resetting.
6904
6905 2019-07-17  Tom Tromey  <tom@tromey.com>
6906
6907         * tui/tui.h (tui_set_layout_by_name): Don't declare.
6908         * tui/tui-regs.c (tui_reg_layout): New function.
6909         (tui_show_registers, tui_reg_command): Use it.
6910         * tui/tui-layout.c (LAYOUT_USAGE): Remove.
6911         (tui_layout_command): Rename from tui_set_layout_by_name.  Change
6912         parameters.
6913         (tui_layout_command): Remove.
6914
6915 2019-07-17  Tom Tromey  <tom@tromey.com>
6916
6917         * tui/tui-layout.h (tui/tui-layout): Return void.
6918         * tui/tui-layout.c (tui_set_layout): Return void.  Add assert.
6919
6920 2019-07-17  Tom Tromey  <tom@tromey.com>
6921
6922         * tui/tui-layout.c (show_source_disasm_command, show_data):
6923         Update.
6924         (reset_locator): Remove.
6925         (show_source_or_disasm_and_command): Update.
6926
6927 2019-07-17  Tom Tromey  <tom@tromey.com>
6928
6929         * tui/tui-source.c (tui_source_window_base::reset): Remove
6930         win_type parameter.
6931         * tui/tui-layout.c (make_command_window, make_source_window)
6932         (make_disasm_window, make_data_window)
6933         (show_source_disasm_command, show_data, tui_gen_win_info::reset)
6934         (reset_locator, show_source_or_disasm_and_command): Update.
6935         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Remove
6936         win_type parameter.
6937         (struct tui_source_window_base) <reset>: Likewise.
6938
6939 2019-07-17  Tom Tromey  <tom@tromey.com>
6940
6941         * tui/tui-layout.c (show_source_disasm_command): Use
6942         reset_locator.
6943         (reset_locator): New function.
6944         (init_and_make_win): Remove.
6945         (show_source_or_disasm_and_command): Use reset_locator.
6946
6947 2019-07-17  Tom Tromey  <tom@tromey.com>
6948
6949         * tui/tui-winsource.c (tui_set_exec_info_content): Remove
6950         condition.
6951         * tui/tui-wingeneral.c (tui_source_window_base::make_visible):
6952         Remove condition.
6953         * tui/tui-source.c (tui_source_window_base::reset): New method.
6954         * tui/tui-layout.c (make_command_window): Don't call
6955         init_and_make_win.
6956         (make_source_window, make_disasm_window): Don't call
6957         make_source_or_disasm_window.
6958         (make_data_window): Don't call init_and_make_win.  Change calling
6959         convention.
6960         (show_source_disasm_command, show_data): Simplify.
6961         (make_source_or_disasm_window): Remove.
6962         (show_source_or_disasm_and_command): Simplify.
6963         * tui/tui-data.h (struct tui_gen_win_info) <reset>: Now virtual.
6964         (struct tui_source_window_base) <reset>: Likewise.
6965         <execution_info>: Remove initializer.
6966         * tui/tui-data.c (tui_source_window_base): Initialize
6967         execution_info.
6968
6969 2019-07-17  Tom Tromey  <tom@tromey.com>
6970
6971         * tui/tui-layout.c (tui_set_layout): Remove regs_populate
6972         variable.
6973
6974 2019-07-17  Tom Tromey  <tom@tromey.com>
6975
6976         * tui/tui.c (tui_rl_other_window): Update.
6977         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
6978         superclass method first.  Always iterate over regs_content.
6979         (tui_unhighlight_win, tui_highlight_win): Use refresh_window
6980         method.
6981         * tui/tui-win.c (tui_set_focus_command): Update.
6982
6983 2019-07-17  Tom Tromey  <tom@tromey.com>
6984
6985         * tui/tui-win.c (tui_set_focus_command): Rename from
6986         tui_set_focus.  Call tui_enable.
6987         (tui_set_focus_command): Remove.
6988
6989 2019-07-17  Tom Tromey  <tom@tromey.com>
6990
6991         * tui/tui-winsource.c (tui_show_exec_info_content): Don't call
6992         refresh_window.
6993         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Call
6994         touchwin.
6995         (tui_data_window::refresh_window): Call refresh_window on data
6996         items.  Always call superclass refresh_window.
6997         (tui_win_info::refresh): Remove.
6998         (tui_source_window_base::refresh_window): Update.
6999         (tui_refresh_all): Update.
7000         * tui/tui-layout.c (show_source_disasm_command): Remove call to
7001         refresh_window.
7002         (show_source_or_disasm_and_command): Likewise.
7003         * tui/tui-data.h (struct tui_win_info) <refresh>: Remove.
7004         (struct tui_source_window_base) <refresh>: Likewise.
7005
7006 2019-07-17  Tom Tromey  <tom@tromey.com>
7007
7008         * tui/tui-winsource.c (tui_clear_source_content)
7009         (tui_show_source_content): Update.
7010         * tui/tui-source.c (tui_source_window::showing_source_p): Check
7011         whether content is empty.
7012         * tui/tui-data.h (struct tui_source_window_base) <content_in_use>:
7013         Remove.
7014
7015 2019-07-17  Tom Tromey  <tom@tromey.com>
7016
7017         * tui/tui-winsource.c (tui_erase_source_content): Clear the
7018         window's contents.
7019         * tui/tui-source.h (tui_set_source_content_nil): Don't declare.
7020         * tui/tui-source.c (tui_set_source_content_nil): Remove.
7021
7022 2019-07-17  Tom Tromey  <tom@tromey.com>
7023
7024         * tui/tui-data.h (UNDEFINED_ITEM): Remove define.
7025         (struct tui_data_item_window): Update.
7026
7027 2019-07-17  Tom Tromey  <tom@tromey.com>
7028
7029         * tui/tui-data.h (MAX_CONTENT_COUNT, TUI_NULL_STR)
7030         (DEFAULT_HISTORY_COUNT, WITH_LOCATOR, NO_LOCATOR): Remove
7031         defines.
7032
7033 2019-07-17  Tom Tromey  <tom@tromey.com>
7034
7035         * tui/tui-winsource.h (tui_erase_source_content)
7036         (tui_clear_source_content): Remove "display_prompt" parameter.
7037         * tui/tui-winsource.c (tui_update_source_window_as_is)
7038         (tui_update_source_windows_with_addr): Update.
7039         (tui_clear_source_content): Remove "display_prompt" parameter.
7040         (tui_erase_source_content): Likewise.  Simplify.
7041         (tui_show_source_content): Update.
7042         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
7043         * tui/tui-stack.c (tui_show_frame_info): Update.
7044         * tui/tui-data.h (EMPTY_SOURCE_PROMPT, NO_EMPTY_SOURCE_PROMPT):
7045         Remove defines.
7046
7047 2019-07-17  Tom Tromey  <tom@tromey.com>
7048
7049         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7050         * tui/tui-disasm.h (tui_set_disassem_content): Add win_info
7051         parameter.
7052         * tui/tui-disasm.c (tui_set_disassem_content): Add win_info
7053         parameter.
7054
7055 2019-07-17  Tom Tromey  <tom@tromey.com>
7056
7057         * tui/tui-winsource.c (tui_clear_source_content)
7058         (tui_show_source_content, tui_show_exec_info_content)
7059         (tui_clear_exec_info_content): Update.
7060         * tui/tui-stack.c (tui_show_locator_content): Update.
7061         (tui_show_frame_info): Update.
7062         * tui/tui-source.h (tui_source_window): Don't declare.
7063         * tui/tui-source.c (tui_source_window::showing_source_p): Rename
7064         from tui_source_is_displayed.
7065         * tui/tui-data.h (struct tui_gen_win_info) <content_in_use>:
7066         Remove field.
7067         (struct tui_source_window_base) <content_in_use>: New field.  Now
7068         bool.
7069         (struct tui_source_window) <showing_source_p>: New method.
7070         (TUI_SRC_WIN): Change cast.
7071         * tui/tui-data.c (tui_initialize_static_data): Update.
7072
7073 2019-07-17  Tom Tromey  <tom@tromey.com>
7074
7075         * tui/tui-winsource.c (tui_update_breakpoint_info): Use
7076         location_matches_p.
7077         * tui/tui-source.c (tui_source_window::location_matches_p): New
7078         method.
7079         * tui/tui-disasm.c (tui_disasm_window::location_matches_p): New
7080         method.
7081         * tui/tui-data.h (struct tui_source_window_base)
7082         <location_matches_p>: New method.
7083         (struct tui_source_window, struct tui_disasm_window)
7084         <location_matches_p>: Likewise.
7085
7086 2019-07-17  Tom Tromey  <tom@tromey.com>
7087
7088         * tui/tui-win.c (tui_set_win_height_command): Rename from
7089         tui_set_win_height.
7090         (tui_set_win_height_command): Remove.
7091
7092 2019-07-17  Tom Tromey  <tom@tromey.com>
7093
7094         * tui/tui-source.c (tui_source_window): New constructor.  Add
7095         observer.
7096         (~tui_source_window): New destructor.
7097         (tui_source_window::style_changed): New method.
7098         * tui/tui-hooks.c (tui_redisplay_source): Remove.
7099         (tui_attach_detach_observers): Update.
7100         * tui/tui-data.h (struct tui_source_window): Make constructor not
7101         inline.  Add destructor.
7102         (struct tui_source_window) <style_changed>: New method.
7103         <m_observable>: New member.
7104
7105 2019-07-17  Tom Tromey  <tom@tromey.com>
7106
7107         * tui/tui-data.c (tui_clear_source_windows_detail): Fix typo.
7108         * tui/tui-win.c (tui_resize_all): Fix typo.
7109
7110 2019-07-17  Tom Tromey  <tom@tromey.com>
7111
7112         * tui/tui-wingeneral.h (tui_refresh_all): Update.
7113         * tui/tui-wingeneral.c (make_all_visible): Use foreach.
7114         (tui_refresh_all): Remove "list" parameter.  Use foreach.
7115         * tui/tui-win.c (window_name_completer): Use foreach.
7116         (tui_refresh_all_win, tui_rehighlight_all, tui_all_windows_info)
7117         (update_tab_width): Likewise.
7118         * tui/tui-layout.c (show_layout): Update.
7119         * tui/tui-data.h (class tui_window_iterator): New.
7120         (struct all_tui_windows): New.
7121         * tui/tui-data.c (tui_partial_win_by_name): Use foreach.
7122
7123 2019-07-17  Tom Tromey  <tom@tromey.com>
7124
7125         * tui/tui-regs.c (tui_reg_next, tui_reg_prev): Add "current_group"
7126         parameter.  Don't reference globals.
7127         (tui_reg_command): Update.
7128
7129 2019-07-17  Tom Tromey  <tom@tromey.com>
7130
7131         * tui/tui-regs.c (tui_show_registers): Simplify.
7132
7133 2019-07-17  Tom Tromey  <tom@tromey.com>
7134
7135         * tui/tui-regs.c (tui_show_registers): Update.
7136         (tui_show_register_group): Add win_info parameter.
7137
7138 2019-07-17  Tom Tromey  <tom@tromey.com>
7139
7140         * tui/tui-regs.c (tui_data_window::display_reg_element_at_line):
7141         Rename from tui_display_reg_element_at_line.
7142         (tui_data_window::display_registers_from_line): Update.
7143         * tui/tui-data.h (struct tui_data_window)
7144         <display_reg_element_at_line>: New method.
7145
7146 2019-07-17  Tom Tromey  <tom@tromey.com>
7147
7148         * tui/tui-regs.h (tui_display_registers_from)
7149         (tui_display_registers_from_line): Don't declare.
7150         * tui/tui-windata.c (tui_data_window::display_all_data)
7151         (tui_data_window::refresh_all)
7152         (tui_data_window::do_scroll_vertical): Update.
7153         * tui/tui-regs.c (tui_data_window::display_registers_from): Rename
7154         from tui_display_registers_from.
7155         (tui_display_reg_element_at_line): Update.
7156         (tui_data_window::display_registers_from_line): Rename from
7157         tui_display_registers_from_line.
7158         * tui/tui-data.h (struct tui_data_window) <display_registers_from,
7159         display_registers_from_line>: New methods.
7160
7161 2019-07-17  Tom Tromey  <tom@tromey.com>
7162
7163         * tui/tui-windata.h (tui_erase_data_content): Don't declare.
7164         * tui/tui-windata.c (tui_data_window::erase_data_content): Rename
7165         from tui_erase_data_content.
7166         (tui_data_window::display_all_data)
7167         (tui_data_window::refresh_all)
7168         (tui_data_window::do_scroll_vertical): Update.
7169         * tui/tui-regs.c (tui_show_registers): Update.
7170         * tui/tui-data.h (struct tui_data_window) <erase_data_content>:
7171         New method.
7172
7173 2019-07-17  Tom Tromey  <tom@tromey.com>
7174
7175         * tui/tui-windata.h (tui_delete_data_content_windows): Don't
7176         declare.
7177         * tui/tui-windata.c
7178         (tui_data_window::delete_data_content_windows): Rename from
7179         tui_delete_data_content_windows.
7180         (tui_data_window::display_all_data)
7181         (tui_data_window::do_scroll_vertical): Update.
7182         * tui/tui-data.h (struct tui_data_window)
7183         <delete_data_content_windows>: New method.
7184
7185 2019-07-17  Tom Tromey  <tom@tromey.com>
7186
7187         * tui/tui-windata.h (tui_refresh_data_win): Don't declare.
7188         * tui/tui-regs.h (tui_first_reg_element_inline): Don't declare.
7189
7190 2019-07-17  Tom Tromey  <tom@tromey.com>
7191
7192         * tui/tui-windata.h (tui_display_all_data): Don't declare.
7193         * tui/tui-windata.c (tui_data_window::display_all_data): Rename
7194         from tui_display_all_data.
7195         * tui/tui-win.c
7196         (tui_data_window::do_make_visible_with_new_height): Update.
7197         * tui/tui-regs.c (tui_show_registers): Update.
7198         * tui/tui-layout.c (tui_set_layout): Update.
7199         * tui/tui-data.h (struct tui_data_window) <display_all_data>: New
7200         method.
7201
7202 2019-07-17  Tom Tromey  <tom@tromey.com>
7203
7204         * tui/tui-windata.h (tui_display_data_from): Don't declare.
7205         * tui/tui-windata.c (tui_display_data_from): Remove.
7206         (tui_data_window::refresh_all): Update.
7207
7208 2019-07-17  Tom Tromey  <tom@tromey.com>
7209
7210         * tui/tui-windata.h (tui_display_data_from_line): Don't declare.
7211         * tui/tui-windata.c (tui_display_data_from_line): Remove.
7212         (tui_display_data_from, tui_data_window::do_scroll_vertical): Call
7213         tui_display_registers_from_line.
7214         * tui/tui-regs.h (tui_display_registers_from_line): Update.
7215         * tui/tui-regs.c (tui_display_registers_from_line): Remove
7216         "force_display" parameter.
7217
7218 2019-07-17  Tom Tromey  <tom@tromey.com>
7219
7220         * tui/tui-regs.h (tui_first_reg_element_no_inline): Don't
7221         declare.
7222         * tui/tui-regs.c (tui_data_window::first_reg_element_no_inline):
7223         Rename from tui_first_reg_element_no_inline.
7224         (tui_display_reg_element_at_line)
7225         (tui_display_registers_from_line): Update.
7226         * tui/tui-data.h (struct tui_data_window)
7227         <first_reg_element_no_inline>: New method.
7228
7229 2019-07-17  Tom Tromey  <tom@tromey.com>
7230
7231         * tui/tui-windata.c (tui_display_data_from)
7232         (tui_data_window::do_scroll_vertical): Update.
7233         * tui/tui-regs.h (tui_line_from_reg_element_no): Don't declare.
7234         * tui/tui-regs.c (tui_data_window::line_from_reg_element_no):
7235         Rename from tui_line_from_reg_element_no.
7236         (tui_display_registers_from_line): Update.
7237         * tui/tui-data.h (struct tui_data_window)
7238         <line_from_reg_element_no>: New method.
7239
7240 2019-07-17  Tom Tromey  <tom@tromey.com>
7241
7242         * tui/tui-regs.h (tui_last_regs_line_no): Don't declare.
7243         * tui/tui-regs.c (tui_data_window::last_regs_line_no): Rename from
7244         tui_last_regs_line_no.
7245         (tui_display_reg_element_at_line)
7246         (tui_display_registers_from_line): Update.
7247         * tui/tui-data.h (struct tui_data_window) <last_regs_line_no>: New
7248         method.
7249
7250 2019-07-17  Tom Tromey  <tom@tromey.com>
7251
7252         PR tui/24722:
7253         * tui/tui-winsource.h (tui_update_all_breakpoint_info)
7254         (tui_update_breakpoint_info): Add "being_deleted" parameter.
7255         * tui/tui-winsource.c (tui_update_source_window_as_is): Update.
7256         (tui_update_all_breakpoint_info): Add "being_deleted" parameter.
7257         (tui_update_breakpoint_info): Likewise.
7258         * tui/tui-hooks.c (tui_event_create_breakpoint)
7259         (tui_event_delete_breakpoint, tui_event_modify_breakpoint):
7260         Update.
7261
7262 2019-07-17  Tom Tromey  <tom@tromey.com>
7263
7264         * tui/tui-stack.c (tui_show_frame_info): Consolidate "if"s.
7265
7266 2019-07-17  Tom Tromey  <tom@tromey.com>
7267
7268         * tui/tui-winsource.c (tui_update_source_window_as_is)
7269         (tui_update_source_windows_with_addr): Update.
7270         * tui/tui-source.h (tui_set_source_content)
7271         (tui_show_symtab_source): Add "win_info" parameter.
7272         * tui/tui-source.c (tui_set_source_content): Add "win_info"
7273         parameter.
7274         (tui_show_symtab_source): Likewise.
7275
7276 2019-07-17  Tom Tromey  <tom@tromey.com>
7277
7278         * tui/tui-wingeneral.c
7279         (tui_check_and_display_highlight_if_needed): Check can_highlight.
7280
7281 2019-07-17  Tom Tromey  <tom@tromey.com>
7282
7283         * tui/tui-data.h (struct tui_win_info) <can_scroll>: New method.
7284         (struct tui_cmd_window) <can_scroll>: New method.
7285         * tui/tui-command.c (tui_dispatch_ctrl_char): Use can_scroll
7286         method.
7287
7288 2019-07-17  Tom Tromey  <tromey@adacore.com>
7289
7290         * ui-out.h (class ui_out) <field_signed, field_fmt_signed,
7291         do_field_signed>: Rename.  Change type of "value".
7292         * ui-out.c (ui_out::field_signed): Rename from field_int.
7293         Change type of "value".
7294         (ui_out::field_fmt_signed): Rename from field_fmt_int.  Change
7295         type of "value".
7296         * tui/tui-out.h (class tui_ui_out) <do_field_signed>: Rename from
7297         do_field_int.  Change type of "value".
7298         * tui/tui-out.c (tui_ui_out::do_field_signed): Rename from
7299         do_field_int.  Change type of "value".
7300         * tracepoint.c (trace_status_mi, tfind_1)
7301         (print_one_static_tracepoint_marker): Update.
7302         * thread.c (print_thread_info_1, print_selected_thread_frame):
7303         Update.
7304         * stack.c (print_frame, print_frame_info): Update.
7305         * spu-tdep.c (info_spu_signal_command, info_spu_dma_cmdlist):
7306         Update.
7307         * source.c (print_source_lines_base): Update.
7308         * skip.c (info_skip_command): Update.
7309         * record-btrace.c (btrace_ui_out_decode_error)
7310         (btrace_call_history_src_line): Update.
7311         * python/py-framefilter.c (py_print_single_arg, py_print_frame):
7312         Update.
7313         * progspace.c (print_program_space): Update.
7314         * mi/mi-symbol-cmds.c (mi_cmd_symbol_list_lines): Update.
7315         * mi/mi-out.h (class mi_ui_out) <do_field_signed>: Rename from
7316         do_field_int.  Change type of "value".
7317         * mi/mi-out.c (mi_ui_out::do_table_begin)
7318         (mi_ui_out::do_table_header): Update.
7319         (mi_ui_out::do_field_signed): Rename from do_field_int.  Change
7320         type of "value".
7321         * mi/mi-main.c (mi_cmd_thread_list_ids, print_one_inferior)
7322         (mi_cmd_data_list_changed_registers, output_register)
7323         (mi_cmd_data_read_memory, mi_load_progress)
7324         (mi_cmd_trace_frame_collected): Update.
7325         * mi/mi-interp.c (mi_on_normal_stop_1, mi_output_solib_attribs):
7326         Update.
7327         * mi/mi-cmd-var.c (print_varobj, mi_cmd_var_create)
7328         (mi_cmd_var_delete, mi_cmd_var_info_num_children)
7329         (mi_cmd_var_list_children, varobj_update_one): Update.
7330         * mi/mi-cmd-stack.c (mi_cmd_stack_info_depth)
7331         (mi_cmd_stack_list_args, list_arg_or_local): Update.
7332         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_file): Update.
7333         * inferior.c (print_inferior): Update.
7334         * gdb_bfd.c (print_one_bfd): Update.
7335         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn):
7336         Update.
7337         * darwin-nat-info.c (darwin_debug_regions_recurse): Update.
7338         * cli-out.h (class cli_ui_out) <do_field_signed>: Rename from
7339         do_field_int.  Change type of "value".
7340         * cli-out.c (cli_ui_out::do_field_signed): Rename from
7341         do_field_int.  Change type of "value".
7342         * breakpoint.c (watchpoint_check, print_breakpoint_location)
7343         (print_one_breakpoint_location, print_it_catch_fork)
7344         (print_one_catch_fork, print_it_catch_vfork)
7345         (print_one_catch_vfork, print_it_catch_solib)
7346         (print_it_catch_exec, print_it_ranged_breakpoint)
7347         (print_mention_watchpoint, print_mention_masked_watchpoint)
7348         (bkpt_print_it, update_static_tracepoint): Update.
7349         * break-catch-throw.c (print_it_exception_catchpoint): Update.
7350         * break-catch-syscall.c (print_it_catch_syscall): Update.
7351         * ada-tasks.c (print_ada_task_info): Update.
7352         * ada-lang.c (print_it_exception, print_mention_exception):
7353         Update.
7354
7355 2019-07-17  Andrew Burgess  <andrew.burgess@embecosm.com>
7356
7357         PR breakpoints/24541
7358         * gdbarch.c: Regenerate.
7359         * gdbarch.h: Regenerate.
7360         * gdbarch.sh: Adjust return type and parameter types for
7361         'stap_adjust_register'.
7362         (i386_stap_adjust_register): Adjust signature and return new
7363         register name.
7364         * stap-probe.c (stap_parse_register_operand): Adjust use of
7365         'gdbarch_stap_adjust_register'.
7366
7367 2019-07-17  Tom Tromey  <tromey@adacore.com>
7368
7369         * s390-linux-nat.c (s390_watch_area): Remove typedef.  Don't
7370         declare VEC.
7371         (struct s390_debug_reg_state) <watch_areas, break_areas>: Now
7372         std::vector.
7373         (struct s390_process_info): Add initializers.
7374         (s390_add_process): Use new.
7375         (s390_linux_nat_target::low_forget_process): Use delete.
7376         (s390_linux_nat_target::low_new_fork)
7377         (s390_linux_nat_target::stopped_by_watchpoint)
7378         (s390_linux_nat_target::low_prepare_to_resume)
7379         (s390_linux_nat_target::insert_watchpoint)
7380         (s390_linux_nat_target::insert_hw_breakpoint)
7381         (s390_linux_nat_target::remove_watchpoint)
7382         (s390_linux_nat_target::remove_hw_breakpoint): Update.
7383
7384 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7385
7386         * aarch64-fbsd-nat.c: Include regcache.h.
7387         (getregs_supplies, getfpregs_supplies): Remove unused gdbarch
7388         argument.
7389         (aarch64_fbsd_nat_target::fetch_registers)
7390         (aarch64_fbsd_nat_target::store_registers): Remove gdbarch
7391         variable.
7392         * arm-fbsd-nat.c, riscv-fbsd-nat.c: Likewise.
7393
7394 2019-07-16  John Baldwin  <jhb@FreeBSD.org>
7395
7396         * fbsd-nat.c: Include gdbarch.h.
7397
7398 2019-07-15  Tom Tromey  <tromey@adacore.com>
7399
7400         * mi/mi-out.c (mi_ui_out::do_field_int): Use plongest.
7401
7402 2019-07-15  Tom Tromey  <tromey@adacore.com>
7403
7404         * mi/mi-out.h (class mi_ui_out) <do_field_unsigned>: Declare.
7405         * mi/mi-out.c (mi_ui_out::do_field_unsigned): New method.
7406         * cli-out.h (class cli_ui_out) <do_field_unsigned>: Declare.
7407         * cli-out.c (cli_ui_out::do_field_int): New method.
7408         * ui-out.c (ui_out::field_unsigned): New method.
7409         * symfile.c (generic_load): Use field_unsigned.
7410         (print_transfer_performance): Likewise.
7411         * record-btrace.c (ui_out_field_uint): Remove.
7412         (btrace_call_history_insn_range, btrace_call_history): Use
7413         field_unsigned.
7414         * disasm.c (gdb_pretty_print_disassembler::pretty_print_insn): Use
7415         field_unsigned.
7416         * ui-out.h (class ui_out) <field_unsigned>: New method.
7417         <do_field_unsigned>: Likewise.
7418
7419 2019-07-15  Tom Tromey  <tromey@adacore.com>
7420
7421         * mi/mi-main.c (list_available_thread_groups): Use field_string.
7422         * mi/mi-interp.c (mi_memory_changed): Use field_string.
7423         * target.c (flash_erase_command): Use field_string.
7424         * infrun.c (print_signal_received_reason): Use field_string.
7425         * i386-tdep.c (i386_mpx_print_bounds): Use field_string.
7426         * breakpoint.c (maybe_print_thread_hit_breakpoint): Use
7427         field_string.
7428         * ada-tasks.c (print_ada_task_info): Use field_string.
7429
7430 2019-07-15  Tom Tromey  <tromey@adacore.com>
7431
7432         * target.c (flash_erase_command): Use field_core_addr.
7433         * symfile.c (generic_load): Use field_core_addr.
7434         * sparc64-linux-tdep.c (sparc64_linux_handle_segmentation_fault):
7435         Use field_core_addr.
7436         * i386-linux-tdep.c (i386_linux_handle_segmentation_fault): Use
7437         field_core_addr.
7438
7439 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7440
7441         * dwarf2loc.c (dwarf2_evaluate_property): Sign extend property
7442         value if its desired type is smaller than a CORE_ADDR and signed.
7443
7444 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7445
7446         * dwarf2loc.c (dwarf2_evaluate_property): Update to take account
7447         of changes to field names, and use new is_reference field to
7448         decide if a property is a reference or not.
7449         * dwarf2loc.h (struct dwarf2_locexpr_baton): Add 'is_reference'
7450         field.
7451         (struct dwarf2_property_baton): Update header comment, rename
7452         'referenced_type' to 'property_type' and update comments.
7453         * dwarf2read.c (attr_to_dynamic_prop): Add extra parameter to hold
7454         default property type, store in property baton, update to take
7455         accound of renamed field.
7456         (read_func_scope): Update call to attr_to_dynamic_prop.
7457         (read_array_type): Likewise.
7458         (dwarf2_per_cu_addr_sized_int_type): New function.
7459         (read_subrange_index_type): Move type finding code to
7460         dwarf2_per_cu_addr_sized_int_type.
7461         (read_subrange_type): Update calls to attr_to_dynamic_prop.
7462         (dwarf2_per_cu_addr_type): New function.
7463         (set_die_type): Update calls to attr_to_dynamic_prop.
7464
7465 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7466
7467         * dwarf2read.c (read_subrange_index_type): New function.
7468         (read_subrange_type): Move code into new function and call it.
7469         * gdbtypes.c (create_range_type): Add some asserts.
7470
7471 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7472
7473         * dwarf2loc.c (dwarf2_evaluate_property): Change return type, and
7474         update return statements.
7475         * dwarf2loc.h (dwarf2_evaluate_property): Update return type on
7476         declaration, and update comment to match.
7477         * gdbtypes.c (resolve_dynamic_array): Update call to
7478         dwarf2_evaluate_property to match new return type.
7479
7480 2019-07-12  Andrew Burgess  <andrew.burgess@embecosm.com>
7481
7482         * valarith.c (value_subscripted_rvalue): Change lowerbound
7483         parameter type from int to LONGEST.
7484         * value.h (value_subscripted_rvalue): Likewise in declaration.
7485
7486 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7487
7488         * cli/cli-utils.c (info_print_command_completer): New function.
7489         * cli/cli-utils.h: Add 'completer.h' include, and forward
7490         declaration for 'struct cmd_list_element'.
7491         (info_print_command_completer): Declare.
7492         * stack.c (_initialize_stack): Add completer for 'info locals' and
7493         'info args'.
7494         * symtab.c (_initialize_symtab): Add completer for 'info
7495         variables' and 'info functions'.
7496         * NEWS: Mention completion for additional info commands.
7497
7498 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7499
7500         * cli/cli-utils.c (extract_info_print_args): Delete.
7501         (extract_arg_maybe_quoted): Delete.
7502         (info_print_options_defs): New variable.
7503         (make_info_print_options_def_group): New function.
7504         (extract_info_print_options): Define new function.
7505         * cli/cli-utils.h (extract_info_print_args): Delete.
7506         (struct info_print_options): New structure.
7507         (extract_info_print_options): Declare new function.
7508         * stack.c (info_locals_command): Update to use new
7509         extract_info_print_options, also add a header comment.
7510         (info_args_command): Likewise.
7511         * symtab.c (info_variables_command): Likewise.
7512         (info_functions_command): Likewise.
7513
7514 2019-07-11  Andrew Burgess  <andrew.burgess@embecosm.com>
7515
7516         * cli/cli-option.c (parse_option): Use extract_string_maybe_quoted
7517         to extract string arguments.
7518         * common/common-utils.c (extract_string_maybe_quoted): New function.
7519         * common/common-utils.h (extract_string_maybe_quoted): Declare.
7520
7521 2019-07-11  Tom Tromey  <tromey@adacore.com>
7522
7523         * main.c (get_init_files): Use GDBINIT, not gdbinit.
7524         * auto-load.c (file_is_auto_load_safe): Use GDBINIT, not gdbinit.
7525         * top.h (gdbinit): Don't declare.
7526         * cli/cli-cmds.c (init_cli_cmds): Remove, merging contents
7527         into...
7528         (_initialize_cli_cmds): ...here.  Use GDBINIT, not gdbinit.
7529         * top.c (gdb_init): Don't call init_cli_cmds.
7530         (gdbinit): Remove.
7531         * cli/cli-cmds.h (init_cli_cmds): Don't declare.
7532
7533 2019-07-11  Tom Tromey  <tromey@adacore.com>
7534
7535         * python/py-inferior.c (add_thread_object): Don't use thread_obj
7536         after it has been moved.
7537
7538 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7539
7540         * valops.c (value_must_coerce_to_target): Change return type to
7541         bool.
7542         * value.h (value_must_coerce_to_target): Likewise.
7543
7544 2019-07-10  Simon Marchi  <simon.marchi@efficios.com>
7545
7546         * breakpoint.c (is_hardware_watchpoint): Remove
7547         forward-declaration.
7548         (is_masked_watchpoint): Change return type to bool.
7549         (is_tracepoint): Likewise.
7550         (is_breakpoint): Likewise.
7551         (is_hardware_watchpoint): Likewise.
7552         (is_watchpoint): Likewise.
7553         (is_no_memory_software_watchpoint): Likewise.
7554         (is_catchpoint): Likewise.
7555         (breakpoint_1): Make FILTER parameter's return type bool.
7556         is_masked_watchpoint): Change return type to bool.
7557         (save_breakpoints): Make FILTER parameter's return type bool.
7558         * breakpoint.h (is_breakpoint): Change return type to bool.
7559         (is_watchpoint): Likewise.
7560         (is_catchpoint): Likewise.
7561         (is_tracepoint): Likewise.
7562
7563 2019-07-10  Tom Tromey  <tom@tromey.com>
7564
7565         * defs.h: Don't include gdbarch.h.
7566         * aarch64-ravenscar-thread.c, aarch64-tdep.c, alpha-bsd-tdep.h,
7567         alpha-linux-tdep.c, alpha-mdebug-tdep.c, arch-utils.h, arm-tdep.h,
7568         ax-general.c, btrace.c, buildsym-legacy.c, buildsym.h, c-lang.c,
7569         cli/cli-decode.h, cli/cli-dump.c, cli/cli-script.h,
7570         cli/cli-style.h, coff-pe-read.h, compile/compile-c-support.c,
7571         compile/compile-cplus.h, compile/compile-loc2c.c, corefile.c,
7572         cp-valprint.c, cris-linux-tdep.c, ctf.c, d-lang.c, d-namespace.c,
7573         dcache.c, dicos-tdep.c, dictionary.c, disasm-selftests.c,
7574         dummy-frame.c, dummy-frame.h, dwarf2-frame-tailcall.c,
7575         dwarf2expr.c, expression.h, f-lang.c, frame-base.c,
7576         frame-unwind.c, frv-linux-tdep.c, gdbarch-selftests.c, gdbtypes.h,
7577         go-lang.c, hppa-nbsd-tdep.c, hppa-obsd-tdep.c, i386-dicos-tdep.c,
7578         i386-tdep.h, ia64-vms-tdep.c, interps.h, language.c,
7579         linux-record.c, location.h, m2-lang.c, m32r-linux-tdep.c,
7580         mem-break.c, memattr.c, mn10300-linux-tdep.c, nios2-linux-tdep.c,
7581         objfiles.h, opencl-lang.c, or1k-linux-tdep.c, p-lang.c,
7582         parser-defs.h, ppc-tdep.h, probe.h, python/py-record-btrace.c,
7583         record-btrace.c, record.h, regcache-dump.c, regcache.h,
7584         riscv-fbsd-tdep.c, riscv-linux-tdep.c, rust-exp.y,
7585         sh-linux-tdep.c, sh-nbsd-tdep.c, source-cache.c,
7586         sparc-nbsd-tdep.c, sparc-obsd-tdep.c, sparc-ravenscar-thread.c,
7587         sparc64-fbsd-tdep.c, std-regs.c, target-descriptions.h,
7588         target-float.c, tic6x-linux-tdep.c, tilegx-linux-tdep.c, top.c,
7589         tracefile.c, trad-frame.c, type-stack.h, ui-style.c, utils.c,
7590         utils.h, valarith.c, valprint.c, varobj.c, x86-tdep.c,
7591         xml-support.h, xtensa-linux-tdep.c, cli/cli-cmds.h: Update.
7592         * s390-linux-nat.c, procfs.c, inf-ptrace.c: Likewise.
7593
7594 2019-07-10  Tom Tromey  <tromey@adacore.com>
7595
7596         * ada-lang.h (is_ada_exception_catchpoint): Declare.
7597         * breakpoint.c (init_ada_exception_breakpoint): Register as
7598         bp_catchpoint.
7599         (print_one_breakpoint_location, print_one_breakpoint): Use
7600         is_ada_exception_catchpoint.
7601         * ada-lang.c (class ada_catchpoint_location): Pass
7602         bp_loc_software_breakpoint to bp_location constructor.
7603         (is_ada_exception_catchpoint): New function.
7604
7605 2019-07-10  Tom Tromey  <tromey@adacore.com>
7606
7607         * arm-tdep.c (arm_exidx_entry_s): Remove typedef.  Don't define
7608         VEC.
7609         (struct arm_exidx_entry): New method operator<.
7610         (struct arm_exidx_data) <section_maps>: Change type.
7611         (arm_exidx_data_free): Remove.
7612         (arm_exidx_data_key): Change type.  Move lower.
7613         (arm_exidx_new_objfile): Update.
7614         (arm_compare_exidx_entries): Remove.
7615         (arm_find_exidx_entry, _initialize_arm_tdep)
7616
7617 2019-07-10  Tom Tromey  <tromey@adacore.com>
7618
7619         * solib-spu.c (ocl_program_data_key): Change type.
7620         (append_ocl_sos, ocl_enable_break, _initialize_spu_solib):
7621         Update.
7622
7623 2019-07-10  Tom Tromey  <tromey@adacore.com>
7624
7625         * solib-aix.c (lm_info_aix_p): Remove typedef.  Don't define VEC.
7626         (struct solib_aix_inferior_data) <library_list>: Change type.
7627         (solib_aix_inferior_data_handle): Change type.
7628         (get_solib_aix_inferior_data): Update.
7629         (solib_aix_free_library_list): Remove.
7630         (library_list_start_library): Update.
7631         (solib_aix_parse_libraries, solib_aix_get_library_list): Change
7632         return type.
7633         (solib_aix_get_library_list)
7634         (solib_aix_solib_create_inferior_hook, solib_aix_current_sos)
7635         (solib_aix_normal_stop_observer, _initialize_solib_aix): Update.
7636
7637 2019-07-10  Tom Tromey  <tromey@adacore.com>
7638
7639         * solib-dsbt.c (struct dsbt_info): Add initializers.
7640         (solib_dsbt_pspace_data): Change type.
7641         (dsbt_pspace_data_cleanup): Remove.
7642         (get_dsbt_info, _initialize_dsbt_solib): Update.
7643
7644 2019-07-10  Tom Tromey  <tromey@adacore.com>
7645
7646         * spu-tdep.c (spu_overlay_data): Change type.
7647         (spu_get_overlay_table, spu_overlay_new_objfile)
7648         (_initialize_spu_tdep): Update.
7649
7650 2019-07-10  Tom Tromey  <tromey@adacore.com>
7651
7652         * gdb-stabs.h (struct dbx_symfile_info): Add initializers and
7653         destructor.
7654         (dbx_objfile_data_key): Change type and declare later.
7655         (DBX_SYMFILE_INFO): Rewrite.
7656         * dbxread.c (dbx_objfile_data_key): Change type.
7657         (dbx_symfile_init): Update.
7658         (~dbx_symfile_info): Rename from dbx_free_symfile_info.  Update.
7659         (coffstab_build_psymtabs, elfstab_build_psymtabs)
7660         (stabsect_build_psymtabs, _initialize_dbxread): Update.
7661
7662 2019-07-10  Tom Tromey  <tromey@adacore.com>
7663
7664         * jit.c (jit_program_space_key): Change type.  Move lower.
7665         (get_jit_program_space_data): Update.
7666         (jit_program_space_data_cleanup): Remove.
7667         (jit_breakpoint_deleted, free_objfile_data, _initialize_jit):
7668         Update.
7669         (struct jit_program_space_data): Add initializers.
7670
7671 2019-07-10  Tom Tromey  <tromey@adacore.com>
7672
7673         * solib-darwin.c (struct darwin_info): Add initializers.
7674         (solib_darwin_pspace_data): Change type.
7675         (darwin_pspace_data_cleanup): Remove.
7676         (get_darwin_info, _initialize_darwin_solib): Update.
7677
7678 2019-07-10  Tom Tromey  <tromey@adacore.com>
7679
7680         * remote-sim.c (struct sim_inferior_data): Add initializers,
7681         constructor, and destructor.
7682         (sim_inferior_data_key): Change type.  Move lower.
7683         (check_for_duplicate_sim_descriptor): Update.
7684         (get_sim_inferior_data): Use new.  Update.
7685         (~sim_inferior_data_cleanup): Rename from
7686         sim_inferior_data_cleanup.  Simplify.
7687         (gdbsim_close_inferior, simulator_command)
7688         (sim_command_completer, _initialize_remote_sim): Update.
7689         (next_pid, INITIAL_PID): Move earlier.
7690
7691 2019-07-10  Tom Tromey  <tromey@adacore.com>
7692
7693         * python/python-internal.h (create_thread_object): Return
7694         gdbpy_ref.
7695         * python/py-infthread.c (create_thread_object): Return gdbpy_ref.
7696         * python/py-inferior.c (struct threadlist_entry): Add
7697         constructor.
7698         <thread_obj>: Now a gdbpy_ref.
7699         (thread_to_thread_object): Update.
7700         (add_thread_object): Use new.
7701         (delete_thread_object): Use delete.
7702         (infpy_threads): Update.
7703         (py_free_inferior): Update.  Construct "inf_obj" after acquiring
7704         GIL.
7705
7706 2019-07-10  Tom Tromey  <tromey@adacore.com>
7707
7708         * valops.c (value_cast): Specialize error message for Ada.
7709
7710 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7711
7712         * breakpoint.c (breakpoint_1): Update doc and parameter names.
7713
7714 2019-07-10  Simon Marchi  <simon.marchi@polymtl.ca>
7715
7716         * breakpoint.h (bpstat_explains_signal, bpstat_causes_stop,
7717         bpstat_should_step): Return bool, adjust comments.
7718         * breakpoint.c (bpstat_explains_signal, bpstat_causes_stop,
7719         bpstat_should_step): Likewise.
7720
7721 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7722
7723         * features/Makefile: Use feature target descriptions for Arm.
7724         * features/arm/arm-core.c: Generate new file.
7725         * features/arm/arm-fpa.c: Likewise.
7726         * features/arm/arm-m-profile-with-fpa.xml: Likewise.
7727         * features/arm/arm-m-profile.c: Likewise.
7728         * features/arm/arm-vfpv2.c: Likewise.
7729         * features/arm/arm-vfpv3.c: Likewise.
7730         * features/arm/xscale-iwmmxt.c: Likewise.
7731         * target-descriptions.c (maint_print_c_tdesc_cmd): Add Arm.
7732
7733 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7734
7735         * arm-linux-nat.c (arm_linux_nat_target::read_description): Check
7736         ptrace earlier.
7737
7738 2019-07-10  Alan Hayward  <alan.hayward@arm.com>
7739
7740         * features/aarch64-pauth.c: Regenerate.
7741
7742 2019-07-09  Simon Marchi  <simon.marchi@polymtl.ca>
7743
7744         * breakpoint.h (struct bpstat_what) <is_longjmp>: Change type to
7745         bool.
7746         (bpstat_what): Use false instead of 0.
7747
7748 2019-07-09  Pedro Alves  <palves@redhat.com>
7749
7750         * break-catch-throw.c (is_exception_catchpoint): New.
7751         * breakpoint.c (print_one_breakpoint_location): New parameter
7752         'raw_loc'.  Handle it.  Use
7753         is_watchpoint/is_catchpoint/is_exception_catchpoint instead of
7754         looking at the breakpoint's type.
7755         (print_one_breakpoint): If handling "maint info breakpoints", also
7756         print locations of exception catchpoints.
7757         * breakpoint.h (is_exception_catchpoint): Declare.
7758
7759 2019-07-09  Pedro Alves  <palves@redhat.com>
7760
7761         * break-catch-throw.c (print_one_exception_catchpoint): Skip the
7762         "addr" field.
7763         (allocate_location_exception_catchpoint): New.
7764         (handle_gnu_v3_exceptions): Don't reset 'type' to bp_breakpoint.
7765         (initialize_throw_catchpoint_ops): Install
7766         allocate_location_exception_catchpoint as allocate_location
7767         method.
7768         * breakpoint.c (bpstat_what) <bp_catch>: Set action to
7769         BPSTAT_WHAT_SINGLE if not stopping and the location's type is not
7770         bp_loc_other.
7771         (breakpoint_address_is_meaningful): Delete.
7772         (bl_address_is_meaningful): New.
7773         (breakpoint_locations_match): Adjust comment.
7774         (bp_location_from_bp_type): New, factored out of...
7775         (bp_location::bp_location(breakpoint *)): ... this.
7776         (bp_location::bp_location(breakpoint *, bp_loc_type)): New,
7777         factored out of...
7778         (bp_location::bp_location(breakpoint *)): ... this.  Reimplement.
7779         (bp_loc_is_permanent): Use bl_address_is_meaningful instead of
7780         breakpoint_address_is_meaningful.
7781         (bp_locations_compare): Adjust comment.
7782         (update_global_location_list): Use bl_address_is_meaningful
7783         instead of breakpoint_address_is_meaningful.
7784         * breakpoint.h (bp_location::bp_location(breakpoint *)): New
7785         explicit.
7786         (bp_location::bp_location(breakpoint *, bp_loc_type)): Declare.
7787         * python/py-breakpoint.c (bppy_get_location): No longer check
7788         whether location is null.
7789
7790 2019-07-09  Pedro Alves  <palves@redhat.com>
7791
7792         PR c++/15468
7793         * breakpoint.c (print_one_breakpoint_location): Remove
7794         single-location assert.
7795
7796 2019-07-09  Tom Tromey  <tom@tromey.com>
7797
7798         * contrib/ari/gdb_ari.sh: Change common to gdbsupport.
7799         * configure: Rebuild.
7800         * configure.ac: Change common to gdbsupport.
7801         * gdbsupport: Rename from common.
7802         * acinclude.m4: Change common to gdbsupport.
7803         * Makefile.in (CONFIG_SRC_SUBDIR, COMMON_SFILES)
7804         (HFILES_NO_SRCDIR, stamp-version, ALLDEPFILES): Change common to
7805         gdbsupport.
7806         * aarch64-tdep.c, ada-lang.c, ada-lang.h, agent.c, alloc.c,
7807         amd64-darwin-tdep.c, amd64-dicos-tdep.c, amd64-fbsd-nat.c,
7808         amd64-fbsd-tdep.c, amd64-linux-nat.c, amd64-linux-tdep.c,
7809         amd64-nbsd-tdep.c, amd64-obsd-tdep.c, amd64-sol2-tdep.c,
7810         amd64-tdep.c, amd64-windows-tdep.c, arch-utils.c,
7811         arch/aarch64-insn.c, arch/aarch64.c, arch/aarch64.h, arch/amd64.c,
7812         arch/amd64.h, arch/arm-get-next-pcs.c, arch/arm-linux.c,
7813         arch/arm.c, arch/i386.c, arch/i386.h, arch/ppc-linux-common.c,
7814         arch/riscv.c, arch/riscv.h, arch/tic6x.c, arm-tdep.c, auto-load.c,
7815         auxv.c, ax-gdb.c, ax-general.c, ax.h, breakpoint.c, breakpoint.h,
7816         btrace.c, btrace.h, build-id.c, build-id.h, c-lang.h, charset.c,
7817         charset.h, cli/cli-cmds.c, cli/cli-cmds.h, cli/cli-decode.c,
7818         cli/cli-dump.c, cli/cli-option.h, cli/cli-script.c,
7819         coff-pe-read.c, command.h, compile/compile-c-support.c,
7820         compile/compile-c.h, compile/compile-cplus-symbols.c,
7821         compile/compile-cplus-types.c, compile/compile-cplus.h,
7822         compile/compile-loc2c.c, compile/compile.c, completer.c,
7823         completer.h, contrib/ari/gdb_ari.sh, corefile.c, corelow.c,
7824         cp-support.c, cp-support.h, cp-valprint.c, csky-tdep.c, ctf.c,
7825         darwin-nat.c, debug.c, defs.h, disasm-selftests.c, disasm.c,
7826         disasm.h, dtrace-probe.c, dwarf-index-cache.c,
7827         dwarf-index-cache.h, dwarf-index-write.c, dwarf2-frame.c,
7828         dwarf2expr.c, dwarf2loc.c, dwarf2read.c, event-loop.c,
7829         event-top.c, exceptions.c, exec.c, extension.h, fbsd-nat.c,
7830         features/aarch64-core.c, features/aarch64-fpu.c,
7831         features/aarch64-pauth.c, features/aarch64-sve.c,
7832         features/i386/32bit-avx.c, features/i386/32bit-avx512.c,
7833         features/i386/32bit-core.c, features/i386/32bit-linux.c,
7834         features/i386/32bit-mpx.c, features/i386/32bit-pkeys.c,
7835         features/i386/32bit-segments.c, features/i386/32bit-sse.c,
7836         features/i386/64bit-avx.c, features/i386/64bit-avx512.c,
7837         features/i386/64bit-core.c, features/i386/64bit-linux.c,
7838         features/i386/64bit-mpx.c, features/i386/64bit-pkeys.c,
7839         features/i386/64bit-segments.c, features/i386/64bit-sse.c,
7840         features/i386/x32-core.c, features/riscv/32bit-cpu.c,
7841         features/riscv/32bit-csr.c, features/riscv/32bit-fpu.c,
7842         features/riscv/64bit-cpu.c, features/riscv/64bit-csr.c,
7843         features/riscv/64bit-fpu.c, features/tic6x-c6xp.c,
7844         features/tic6x-core.c, features/tic6x-gp.c, filename-seen-cache.h,
7845         findcmd.c, findvar.c, fork-child.c, gcore.c, gdb_bfd.c, gdb_bfd.h,
7846         gdb_proc_service.h, gdb_regex.c, gdb_select.h, gdb_usleep.c,
7847         gdbarch-selftests.c, gdbthread.h, gdbtypes.h, gnu-nat.c,
7848         go32-nat.c, guile/guile.c, guile/scm-ports.c,
7849         guile/scm-safe-call.c, guile/scm-type.c, i386-fbsd-nat.c,
7850         i386-fbsd-tdep.c, i386-go32-tdep.c, i386-linux-nat.c,
7851         i386-linux-tdep.c, i386-tdep.c, i387-tdep.c,
7852         ia64-libunwind-tdep.c, ia64-linux-nat.c, inf-child.c,
7853         inf-ptrace.c, infcall.c, infcall.h, infcmd.c, inferior-iter.h,
7854         inferior.c, inferior.h, inflow.c, inflow.h, infrun.c, infrun.h,
7855         inline-frame.c, language.h, linespec.c, linux-fork.c, linux-nat.c,
7856         linux-tdep.c, linux-thread-db.c, location.c, machoread.c,
7857         macrotab.h, main.c, maint.c, maint.h, memattr.c, memrange.h,
7858         mi/mi-cmd-break.h, mi/mi-cmd-env.c, mi/mi-cmd-stack.c,
7859         mi/mi-cmd-var.c, mi/mi-interp.c, mi/mi-main.c, mi/mi-parse.h,
7860         minsyms.c, mips-linux-tdep.c, namespace.h,
7861         nat/aarch64-linux-hw-point.c, nat/aarch64-linux-hw-point.h,
7862         nat/aarch64-linux.c, nat/aarch64-sve-linux-ptrace.c,
7863         nat/amd64-linux-siginfo.c, nat/fork-inferior.c,
7864         nat/linux-btrace.c, nat/linux-btrace.h, nat/linux-namespaces.c,
7865         nat/linux-nat.h, nat/linux-osdata.c, nat/linux-personality.c,
7866         nat/linux-procfs.c, nat/linux-ptrace.c, nat/linux-ptrace.h,
7867         nat/linux-waitpid.c, nat/mips-linux-watch.c,
7868         nat/mips-linux-watch.h, nat/ppc-linux.c, nat/x86-dregs.c,
7869         nat/x86-dregs.h, nat/x86-linux-dregs.c, nat/x86-linux.c,
7870         nto-procfs.c, nto-tdep.c, objfile-flags.h, objfiles.c, objfiles.h,
7871         obsd-nat.c, observable.h, osdata.c, p-valprint.c, parse.c,
7872         parser-defs.h, ppc-linux-nat.c, printcmd.c, probe.c, proc-api.c,
7873         procfs.c, producer.c, progspace.h, psymtab.h,
7874         python/py-framefilter.c, python/py-inferior.c, python/py-ref.h,
7875         python/py-type.c, python/python.c, record-btrace.c, record-full.c,
7876         record.c, record.h, regcache-dump.c, regcache.c, regcache.h,
7877         remote-fileio.c, remote-fileio.h, remote-sim.c, remote.c,
7878         riscv-tdep.c, rs6000-aix-tdep.c, rust-exp.y, s12z-tdep.c,
7879         selftest-arch.c, ser-base.c, ser-event.c, ser-pipe.c, ser-tcp.c,
7880         ser-unix.c, skip.c, solib-aix.c, solib-target.c, solib.c,
7881         source-cache.c, source.c, source.h, sparc-nat.c, spu-linux-nat.c,
7882         stack.c, stap-probe.c, symfile-add-flags.h, symfile.c, symfile.h,
7883         symtab.c, symtab.h, target-descriptions.c, target-descriptions.h,
7884         target-memory.c, target.c, target.h, target/waitstatus.c,
7885         target/waitstatus.h, thread-iter.h, thread.c, tilegx-tdep.c,
7886         top.c, top.h, tracefile-tfile.c, tracefile.c, tracepoint.c,
7887         tracepoint.h, tui/tui-io.c, ui-file.c, ui-out.h,
7888         unittests/array-view-selftests.c,
7889         unittests/child-path-selftests.c, unittests/cli-utils-selftests.c,
7890         unittests/common-utils-selftests.c,
7891         unittests/copy_bitwise-selftests.c, unittests/environ-selftests.c,
7892         unittests/format_pieces-selftests.c,
7893         unittests/function-view-selftests.c,
7894         unittests/lookup_name_info-selftests.c,
7895         unittests/memory-map-selftests.c, unittests/memrange-selftests.c,
7896         unittests/mkdir-recursive-selftests.c,
7897         unittests/observable-selftests.c,
7898         unittests/offset-type-selftests.c, unittests/optional-selftests.c,
7899         unittests/parse-connection-spec-selftests.c,
7900         unittests/ptid-selftests.c, unittests/rsp-low-selftests.c,
7901         unittests/scoped_fd-selftests.c,
7902         unittests/scoped_mmap-selftests.c,
7903         unittests/scoped_restore-selftests.c,
7904         unittests/string_view-selftests.c, unittests/style-selftests.c,
7905         unittests/tracepoint-selftests.c, unittests/unpack-selftests.c,
7906         unittests/utils-selftests.c, unittests/xml-utils-selftests.c,
7907         utils.c, utils.h, valarith.c, valops.c, valprint.c, value.c,
7908         value.h, varobj.c, varobj.h, windows-nat.c, x86-linux-nat.c,
7909         xml-support.c, xml-support.h, xml-tdesc.h, xstormy16-tdep.c,
7910         xtensa-linux-nat.c, dwarf2read.h: Change common to gdbsupport.
7911
7912 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7913
7914         * linespec.c (decode_digits_list_mode): Set explicit_line to a
7915         bool value.
7916         (decode_digits_ordinary): Set explicit_line field in sal.
7917         * symtab.c (skip_prologue_sal): Don't skip prologue for a
7918         symtab_and_line that was set on an explicit line number in
7919         assembler code.  Do always update the recorded symtab and line if
7920         we do skip the prologue.
7921
7922 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7923
7924         * breakpoint.c (set_breakpoint_location_function): Remove
7925         explicit_loc parameter.
7926         (momentary_breakpoint_from_master): Update call to
7927         set_breakpoint_location_function.
7928         (add_location_to_breakpoint): Likewise.
7929
7930 2019-07-09  Andrew Burgess  <andrew.burgess@embecosm.com>
7931
7932         * riscv-tdep.c (riscv_features_from_gdbarch_info): Don't modify
7933         required features based on default bfd type when no specific bfd
7934         is present.
7935
7936 2019-07-08  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
7937
7938         * NEWS: Mention that GDB printf and eval commands can now print
7939         C-style and Ada-style convenience var strings without
7940         calling the inferior.
7941         * printcmd.c (printf_c_string): Locally print GDB internal var
7942         instead of transiting via the inferior.
7943         (printf_wide_c_string): Likewise.
7944
7945 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7946
7947         PR breakpoints/25011
7948         * symfile.c (symbol_file_command): Call solib_create_inferior_hook.
7949
7950 2019-07-04  Tom Tromey  <tom@tromey.com>
7951
7952         PR tui/24724:
7953         * tui/tui-winsource.c (tui_clear_source_content): Update.
7954         (tui_source_window_base::set_is_exec_point_at): Fix comment.
7955         (tui_update_breakpoint_info): Update.
7956         (tui_set_exec_info_content): Update.
7957         * tui/tui-source.c (tui_set_source_content_nil): Update.
7958         * tui/tui-disasm.c (tui_set_disassem_content): Don't set
7959         has_break.
7960         * tui/tui-data.h (enum tui_bp_flag): New.
7961         (tui_bp_flags): New enum flags type.
7962         (struct tui_source_element) <break_mode>: Change type.  Rename
7963         from has_break.
7964         (TUI_BP_ENABLED, TUI_BP_DISABLED, TUI_BP_HIT)
7965         (TUI_BP_CONDITIONAL, TUI_BP_HARDWARE): Don't define.  Now enum
7966         constants.
7967         * tui/tui-winsource.h: Fix comment.
7968
7969 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7970
7971         * aarch32-linux-nat.h (VFP_REGS_SIZE): Remove define.
7972         * aarch64-linux-nat.c (fetch_fpregs_from_thread)
7973         (store_fpregs_to_thread)
7974         (aarch64_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7975         * arch/arm.h (IWMMXT_VEC_REGISTER_SIZE, ARM_CORE_REGS_SIZE)
7976         (ARM_FP_REGS_SIZE, ARM_VFP2_REGS_SIZE, ARM_VFP3_REGS_SIZE)
7977         (IWMMXT_REGS_SIZE): Add define.
7978         * arm-linux-nat.c (IWMMXT_REGS_SIZE): Remove define.
7979         (fetch_vfp_regs, store_vfp_regs)
7980         (arm_linux_nat_target::read_description): Use ARM_VFP3_REGS_SIZE.
7981         * arm-tdep.c (arm_register_g_packet_guesses): Use new defines.
7982
7983 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
7984
7985         * arch/arm-get-next-pcs.c (thumb_get_next_pcs_raw): Use ARM_
7986         defines.
7987         * arch/arm-linux.c (arm_linux_sigreturn_next_pc_offset): Likewise.
7988         * arch/arm.h (INT_REGISTER_SIZE) Rename from...
7989         (ARM_INT_REGISTER_SIZE): ...to this.
7990         (ARM_FP_REGISTER_SIZE) (ARM_VFP_REGISTER_SIZE): Add define.
7991         * arm-linux-tdep.c (ARM_LINUX_JB_ELEMENT_SIZE)
7992         (ARM_LINUX_SIZEOF_GREGSET, arm_linux_supply_gregset)
7993         (arm_linux_collect_gregset, supply_nwfpe_register)
7994         (collect_nwfpe_register, arm_linux_collect_nwfpe): Use ARM_
7995         defines.
7996         * arm-linux-tdep.h (ARM_LINUX_SIZEOF_NWFPE, NWFPE_FPSR_OFFSET)
7997         (NWFPE_FPCR_OFFSET, NWFPE_TAGS_OFFSET): Likewise
7998         * arm-nbsd-tdep.c (ARM_NBSD_JB_ELEMENT_SIZE): Likewise.
7999         * arm-tdep.c (arm_push_dummy_call, arm_extract_return_value)
8000         (arm_return_in_memory, arm_store_return_value)
8001         (arm_get_longjmp_target, arm_register_g_packet_guesses)
8002         (arm_record_ld_st_multiple): Likewise.
8003         * arm-tdep.h (FP_REGISTER_SIZE, VFP_REGISTER_SIZE): Remove.
8004         * arm-wince-tdep.c (ARM_WINCE_JB_ELEMENT_SIZE): Use ARM_ defines.
8005
8006 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8007
8008         * aarch64-linux-tdep.c (aarch64_linux_init_abi): Use
8009         AARCH64_DISPLACED_MODIFIED_INSNS.
8010         * aarch64-tdep.c (struct aarch64_displaced_step_data)
8011         (aarch64_displaced_step_copy_insn): Likewise.
8012         * aarch64-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8013         (AARCH64_DISPLACED_MODIFIED_INSNS): ...to this.
8014         * arm-linux-tdep.c (arm_linux_cleanup_svc): Use
8015         ARM_DISPLACED_MODIFIED_INSNS.
8016         * arm-tdep.c (arm_gdbarch_init): Likewise.
8017         * arm-tdep.h (DISPLACED_MODIFIED_INSNS): Rename from..
8018         (ARM_DISPLACED_MODIFIED_INSNS): ...to this.
8019         (struct arm_displaced_step_closure): Use
8020         ARM_DISPLACED_MODIFIED_INSNS.
8021
8022 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8023
8024         * features/Makefile: Remove unused xml files.
8025         * features/aarch64.xml: Remove.
8026         * features/i386/amd64-avx-avx512-linux.xml: Remove.
8027         * features/i386/amd64-avx-avx512.xml: Remove.
8028         * features/i386/amd64-avx-linux.xml: Remove.
8029         * features/i386/amd64-avx-mpx-avx512-pku-linux.xml: Remove.
8030         * features/i386/amd64-avx-mpx-avx512-pku.xml: Remove.
8031         * features/i386/amd64-avx-mpx-linux.xml: Remove.
8032         * features/i386/amd64-avx-mpx.xml: Remove.
8033         * features/i386/amd64-avx.xml: Remove.
8034         * features/i386/amd64-linux.xml: Remove.
8035         * features/i386/amd64-mpx-linux.xml: Remove.
8036         * features/i386/amd64-mpx.xml: Remove.
8037         * features/i386/amd64.xml: Remove.
8038         * features/i386/i386-avx-avx512-linux.xml: Remove.
8039         * features/i386/i386-avx-avx512.xml: Remove.
8040         * features/i386/i386-avx-linux.xml: Remove.
8041         * features/i386/i386-avx-mpx-avx512-pku-linux.xml: Remove.
8042         * features/i386/i386-avx-mpx-avx512-pku.xml: Remove.
8043         * features/i386/i386-avx-mpx-linux.xml: Remove.
8044         * features/i386/i386-avx-mpx.xml: Remove.
8045         * features/i386/i386-avx.xml: Remove.
8046         * features/i386/i386-linux.xml: Remove.
8047         * features/i386/i386-mmx-linux.xml: Remove.
8048         * features/i386/i386-mmx.xml: Remove.
8049         * features/i386/i386-mpx-linux.xml: Remove.
8050         * features/i386/i386-mpx.xml: Remove.
8051         * features/i386/i386.xml: Remove.
8052         * features/i386/x32-avx-avx512-linux.xml: Remove.
8053         * features/i386/x32-avx-linux.xml: Remove.
8054         * features/i386/x32-linux.xml: Remove.
8055
8056 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8057
8058         * regformats/aarch64.dat: Remove.
8059         * regformats/i386/amd64-avx-avx512-linux.dat: Remove.
8060         * regformats/i386/amd64-avx-linux.dat: Remove.
8061         * regformats/i386/amd64-avx-mpx-avx512-pku-linux.dat: Remove.
8062         * regformats/i386/amd64-avx-mpx-linux.dat: Remove.
8063         * regformats/i386/amd64-linux.dat: Remove.
8064         * regformats/i386/amd64-mpx-linux.dat: Remove.
8065         * regformats/i386/amd64.dat: Remove.
8066         * regformats/i386/i386-avx-avx512-linux.dat: Remove.
8067         * regformats/i386/i386-avx-linux.dat: Remove.
8068         * regformats/i386/i386-avx-mpx-avx512-pku-linux.dat: Remove.
8069         * regformats/i386/i386-avx-mpx-linux.dat: Remove.
8070         * regformats/i386/i386-linux.dat: Remove.
8071         * regformats/i386/i386-mmx-linux.dat: Remove.
8072         * regformats/i386/i386-mpx-linux.dat: Remove.
8073         * regformats/i386/i386.dat: Remove.
8074         * regformats/i386/x32-avx-avx512-linux.dat: Remove.
8075         * regformats/i386/x32-avx-linux.dat: Remove.
8076         * regformats/i386/x32-linux.dat: Remove.
8077
8078 2019-07-04  Alan Hayward  <alan.hayward@arm.com>
8079
8080         * aarch64-tdep.c: Remove xml self tests.
8081         * amd64-linux-tdep.c: Likewise.
8082         * amd64-tdep.c: Likewise.
8083         * i386-linux-tdep.c: Likewise.
8084         * i386-tdep.c: Likewise.
8085
8086 2019-07-03  Pedro Alves  <palves@redhat.com>
8087
8088         PR cli/24732
8089         * cli/cli-cmds.c (struct pipe_cmd_opts): New.
8090         (pipe_cmd_option_defs): New.
8091         (make_pipe_cmd_options_def_group): New.
8092         (pipe_command): Use gdb::option::process_options.
8093         (pipe_command_completer): New function.
8094         (_initialize_cli_cmds): Install completer for "pipe" command.
8095
8096 2019-07-03  Pedro Alves  <palves@redhat.com>
8097
8098         * cli/cli-option.c (union option_value) <string>: New field.
8099         (struct option_def_and_value): Add ctor, move ctor, dtor and
8100         use DISABLE_COPY_AND_ASSIGN.
8101         (option_def_and_value::clear_value): New.
8102         (parse_option, save_option_value_in_ctx, get_val_type_str)
8103         (add_setshow_cmds_for_options): Handle var_string.
8104         * cli-option.h (union option_def::var_address) <string>: New
8105         field.
8106         (struct string_option_def): New.
8107         * maint-test-options.c (struct test_options_opts): Add default
8108         ctor and use DISABLE_COPY_AND_ASSIGN.
8109         <string_opt>: New field.
8110         (test_options_opts::~test_options_opts): New.
8111         (test_options_opts::dump): Also dump "-string".
8112         (test_options_option_defs): Install "string.
8113
8114 2019-07-03  Pedro Alves  <palves@redhat.com>
8115
8116         * cli/cli-option.c (parse_option) <var_enum>: Don't return an
8117         option_value with a null enumeration.
8118         (complete_options): Save the option values in the context.
8119         (save_option_value_in_ctx): New, factored out from ...
8120         (process_options): ... here.
8121         * cli/cli-utils.c (get_ulongest): Don't advance PP until the end
8122         of the function.
8123         * maint-test-options.c (test_options_opts::dump): New, factored
8124         out from ...
8125         (maintenance_test_options_command_mode): ... here.
8126         (maintenance_test_options_command_completion_result): Delete.
8127         (maintenance_test_options_command_completion_text): Update
8128         comment.
8129         (maintenance_show_test_options_completion_result): Change
8130         prototype.  Just print
8131         maintenance_test_options_command_completion_text.
8132         (save_completion_result): New.
8133         (maintenance_test_options_completer_mode): Pass options context to
8134         complete_options, and then save a dump.
8135         (_initialize_maint_test_options): Use add_cmd to install "maint
8136         show test-options-completion-result".
8137
8138 2019-07-03  Pedro Alves  <palves@redhat.com>
8139
8140         * NEWS (New commands): Mention "with" and "maint with".
8141         * cli/cli-cmds.c (with_command_1, with_command_completer_1)
8142         (with_command, with_command_completer): New.
8143         (pipe_command): Adjust to new repeat_previous
8144         interface.
8145         (_initialize_cli_cmds): Install the "with" command and its "w"
8146         alias.
8147         * cli/cli-cmds.h (with_command_1, with_command_completer_1): New
8148         declarations.
8149         * cli/cli-setshow.c (parse_cli_var_uinteger)
8150         (parse_cli_var_zuinteger_unlimited, do_set_command): Handle empty
8151         argument strings for all var_types.
8152         (get_setshow_command_value_string): New, factored out from ...
8153         (do_show_command): ... this.
8154         * cli/cli-setshow.h: Include <string>.
8155         (get_setshow_command_value_string): Declare.
8156         * command.h (repeat_previous): Now returns const char *.  Adjust
8157         comment.
8158         * maint.c: Include "cli/cli-cmds.h".
8159         (maintenance_with_cmd, maintenance_with_cmd_completer): New.
8160         (_initialize_maint_cmds): Register the "maintenance with" command.
8161         * top.c (repeat_previous): Move bits from pipe_command here:
8162         Return the saved command line, if any; error out if there's no
8163         command to relaunch.
8164
8165 2019-07-03  Pedro Alves  <palves@redhat.com>
8166
8167         * NEWS (New commands): Mention "maint set/show test-settings"
8168         instead of "maint test-settings".
8169         * maint-test-settings.c (maintenance_test_settings_list): Delete.
8170         (maintenance_test_settings_set_list): Rename to ...
8171         (maintenance_set_test_settings_list): ... this.
8172         (maintenance_test_settings_show_list): Rename to  ...
8173         (maintenance_show_test_settings_list): ... this.
8174         (maintenance_test_settings_cmd): Delete.
8175         (maintenance_test_settings_set_cmd): ...
8176         (maintenance_set_test_settings_cmd): ... this.
8177         (maintenance_test_settings_show_cmd): ...
8178         (maintenance_show_test_settings_cmd): ... this.
8179         (maintenance_test_settings_show_value_cmd):
8180         (maintenance_show_test_settings_value_cmd): ... this.
8181         (_initialize_maint_test_settings): No longer install the "maint
8182         test-settings" prefix command.  Rename "maint test-settings set"
8183         to "maint set test-settings", and "maint test-settings show" to
8184         "maint show test-settings".  Adjust all subcommands.
8185
8186 2019-07-03  Pedro Alves  <palves@redhat.com>
8187
8188         * maint-test-settings.c: Fix file's intro comment.  Replace all
8189         references to "test-options" with references to "test-settings",
8190         in comments.
8191
8192 2019-07-03  Pedro Alves  <palves@redhat.com>
8193
8194         * maint-test-settings.c (maintenance_test_settings_xxx)
8195         (maintenance_test_settings_yyy, maintenance_test_settings_zzz):
8196         New.
8197         (maintenance_test_settings_enums): Use them.
8198         (maintenance_test_settings_enum): Default to
8199         maintenance_test_settings_xxx.
8200         (_initialize_maint_test_settings): Initialize
8201         MAINTENANCE_TEST_SETTINGS_FILENAME.
8202
8203 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8204
8205         * breakpoint.h (remove_breakpoints_inf): Change return type to
8206         void, move function documentation here.
8207         * breakpoint.c (remove_breakpoints_inf): Change return type to
8208         void, move function documentation to header.
8209
8210 2019-07-02  Pedro Alves  <palves@redhat.com>
8211
8212         * NEWS (Completion improvements): Mention "info threads".
8213         * thread.c (struct info_threads_opts, info_threads_option_defs)
8214         (make_info_threads_options_def_group): New.
8215         (info_threads_command): Use gdb::option::process_options.
8216         (info_threads_command_completer): New.
8217         (_initialize_thread): Use gdb::option::build_help to build the
8218         help text for "info threads".
8219
8220 2019-07-02  Simon Marchi  <simon.marchi@polymtl.ca>
8221
8222         * defs.h (generic_load): Move from here...
8223         * symfile.h (generic_load): ... to here.  Rename name parameter
8224         to args.
8225         * symfile.c (generic_load): Add comment.
8226
8227 2019-07-01  Tom Tromey  <tromey@adacore.com>
8228
8229         * dwarf2read.c
8230         (dw2_debug_names_iterator::find_vec_in_debug_names): Hoist
8231         declaration of without_params.  Fix formatting.
8232
8233 2019-07-01  Tom Tromey  <tromey@adacore.com>
8234
8235         * ada-exp.y (find_primitive_type): Update.
8236         * ada-lang.h (ada_lookup_symbol): Update.
8237         * ada-lang.c (ada_lookup_symbol): Remove "is_a_field_of_this"
8238         parameter.
8239         (ada_lookup_encoded_symbol, ada_lookup_symbol_nonlocal): Update.
8240
8241 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8242
8243         PR breakpoints/24541
8244         * gdbarch.c: Regenerate.
8245         * gdbarch.h: Regenerate.
8246         * gdbarch.sh: Add 'stap_adjust_register'.
8247         * i386-tdep.c: Include '<unordered_set>'.
8248         (i386_stap_adjust_register): New function.
8249         (i386_elf_init_abi): Register 'i386_stap_adjust_register'.
8250         * stap-probe.c (stap_parse_register_operand): Call
8251         'gdbarch_stap_adjust_register'.
8252
8253 2019-06-28  Sergio Durigan Junior  <sergiodj@redhat.com>
8254
8255         PR python/24742
8256         https://bugzilla.redhat.com/show_bug.cgi?id=1723564
8257         * python/python.c (do_start_initialization): Use 'xmalloc'
8258         instead of 'PyMem_Malloc'.
8259
8260 2019-06-28  Tom Tromey  <tromey@adacore.com>
8261
8262         * dwarf2read.c (partial_die_info::read): Prefer the linkage name
8263         for Ada.
8264
8265 2019-06-27  Tom Tromey  <tromey@adacore.com>
8266
8267         * arm-tdep.c (arm_objfile_data_key): Move lower.  Change type to
8268         objfile_key.
8269         (arm_find_mapping_symbol, arm_record_special_symbol)
8270         (_initialize_arm_tdep): Update.
8271         (arm_objfile_data_free): Remove.
8272
8273 2019-06-27  Tom Tromey  <tromey@adacore.com>
8274
8275         * cp-valprint.c (cp_print_value_fields): Pass opts, not options,
8276         to cp_print_static_field.
8277
8278 2019-06-26  Tom Tromey  <tromey@adacore.com>
8279
8280         * minsyms.c (lookup_minimal_symbol_solib_trampoline): Remove.
8281         * minsyms.h (lookup_minimal_symbol_solib_trampoline): Don't
8282         declare.
8283
8284 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8285
8286         * features/aarch64-core.c (create_feature_aarch64_core):
8287         Regenerate.
8288         * features/aarch64-core.xml: Add cpsr flags.
8289
8290 2019-06-26  Alan Hayward  <alan.hayward@arm.com>
8291
8292         * arm-tdep.c (arm_gnu_triplet_regexp): New function.
8293         (arm_gdbarch_init): Add arm_gnu_triplet_regexp.
8294
8295 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8296
8297         * arm-tdep.c (struct arm_per_objfile) <section_maps_sorted>: New
8298         field.
8299         (arm_find_mapping_symbol): Sort mapping symbol vectors on first
8300         use.
8301         (arm_record_special_symbol): Don't insert new symbol in sorted
8302         position, push it at the end.
8303
8304 2019-06-25  Simon Marchi  <simon.marchi@polymtl.ca>
8305
8306         * arm-tdep.c (struct arm_mapping_symbol) (operator <): New.
8307         (arm_mapping_symbol_s): Remove.
8308         (DEF_VEC_O(arm_mapping_symbol_s)): Remove.
8309         (arm_mapping_symbol_vec): New typedef.
8310         (struct arm_per_objfile): Add constructor.
8311         <section_maps>: Change type to
8312         std::unique_ptr<arm_mapping_symbol_vec[]>.
8313         (arm_compare_mapping_symbols): Remove.
8314         (arm_find_mapping_symbol): Adjust to section_maps type change.
8315         (arm_objfile_data_free): Call delete on arm_per_objfile.
8316         (arm_record_special_symbol): Adjust to section_maps type change.
8317         Allocate arm_per_objfile with new.
8318
8319 2019-06-25  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
8320
8321         * cli/cli-cmds.c (alias_command): Compare the alias prefix
8322         with the command prefix.
8323
8324 2019-06-25  Tom Tromey  <tom@tromey.com>
8325
8326         * tui/tui-wingeneral.c (tui_delete_win): Remove "return".
8327         * tui/tui-data.c (~tui_gen_win_info): Remove "if".
8328
8329 2019-06-25  Tom Tromey  <tom@tromey.com>
8330
8331         * tui/tui-layout.c (init_and_make_win): Assert on unrecognized
8332         type.
8333         * tui/tui-data.h (struct tui_gen_win_info): Make constructor
8334         protected.
8335
8336 2019-06-25  Tom Tromey  <tom@tromey.com>
8337
8338         * tui/tui-winsource.c
8339         (tui_source_window_base::set_is_exec_point_at): Add check against
8340         LOA_ADDRESS.
8341
8342 2019-06-25  Tom Tromey  <tom@tromey.com>
8343
8344         * tui/tui-source.c (tui_set_source_content): Don't check before
8345         xfree.
8346         * tui/tui-disasm.c (tui_disassemble): Don't check before xfree.
8347
8348 2019-06-25  Tom Tromey  <tom@tromey.com>
8349
8350         * tui/tui-winsource.h (tui_update_source_window_as_is)
8351         (tui_alloc_source_buffer, tui_line_is_displayed)
8352         (tui_addr_is_displayed): Change type of win_info.
8353         * tui/tui-winsource.c (tui_update_source_window_as_is)
8354         (tui_clear_source_content, tui_show_source_line)
8355         (tui_show_source_content, tui_source_window_base::refill)
8356         (tui_source_window_base::set_is_exec_point_at)
8357         (tui_source_window_base::set_is_exec_point_at)
8358         (tui_update_breakpoint_info, tui_set_exec_info_content): Update.
8359         (tui_alloc_source_buffer, tui_line_is_displayed)
8360         (tui_addr_is_displayed): Change type of win_info.  Update.
8361         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8362         (tui_source_window_base::do_make_visible_with_new_height):
8363         Update.
8364         * tui/tui-source.c (tui_set_source_content)
8365         (tui_set_source_content_nil)
8366         (tui_source_window::do_scroll_vertical): Update.
8367         * tui/tui-layout.c (show_layout): Update.
8368         * tui/tui-disasm.c (tui_set_disassem_content)
8369         (tui_disasm_window::do_scroll_vertical): Update.
8370         * tui/tui-data.h (tui_win_content): Remove.
8371         (struct tui_gen_win_info) <content, content_size>: Remove.
8372         (struct tui_source_element): Add initializers and destructor.
8373         (union tui_which_element, struct tui_win_element): Remove.
8374         (struct tui_source_window_base) <content>: New field.
8375         (struct tui_data_window): Remove destructor.
8376         (tui_alloc_content, tui_free_win_content)
8377         (tui_free_all_source_wins_content): Don't declare.
8378         * tui/tui-data.c (tui_initialize_static_data): Update.
8379         (init_content_element, tui_alloc_content): Remove.
8380         (~tui_gen_win_info): Update.
8381         (~tui_data_window, tui_free_all_source_wins_content)
8382         (tui_free_win_content, free_content, free_content_elements):
8383         Remove.
8384
8385 2019-06-25  Tom Tromey  <tom@tromey.com>
8386
8387         * tui/tui-winsource.h (tui_clear_source_content)
8388         (tui_erase_source_content, tui_show_source_content): Change type
8389         of win_info.
8390         * tui/tui-winsource.c (tui_clear_source_content)
8391         (tui_erase_source_content, tui_show_source_content): Change type
8392         of win_info.
8393         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights): Update.
8394         * tui/tui-source.h (tui_set_source_content_nil): Change type of
8395         win_info.
8396         * tui/tui-source.c (tui_set_source_content_nil): Change type of
8397         win_info.
8398         * tui/tui-layout.c (show_source_or_disasm_and_command): Update.
8399
8400 2019-06-25  Tom Tromey  <tom@tromey.com>
8401
8402         * tui/tui-winsource.c (tui_clear_source_content)
8403         (tui_source_window_base::set_is_exec_point_at): Update.
8404         * tui/tui-source.c (tui_set_source_content_nil): Update.
8405         * tui/tui-data.h (struct tui_source_element) <is_exec_point>: Now
8406         a bool.
8407         * tui/tui-data.c (init_content_element): Update.
8408
8409 2019-06-25  Tom Tromey  <tom@tromey.com>
8410
8411         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Update.
8412         * tui/tui-win.c (make_invisible_and_set_new_height): Update.
8413         * tui/tui-layout.c (init_and_make_win): Update.
8414         * tui/tui.h (enum tui_win_type): Update.
8415         * tui/tui-data.h (tui_win_is_auxiliary): Rename from
8416         tui_win_is_auxillary.
8417         * tui/tui-data.c (tui_win_is_auxiliary): Rename from
8418         tui_win_is_auxillary.
8419
8420 2019-06-25  Tom Tromey  <tom@tromey.com>
8421
8422         * tui/tui-wingeneral.c (tui_data_window::refresh_window): Update.
8423         * tui/tui-windata.c (tui_data_window::first_data_item_displayed)
8424         (tui_delete_data_content_windows, tui_display_all_data)
8425         (tui_data_window::do_scroll_vertical, tui_display_data_from):
8426         Update.
8427         * tui/tui-win.c (tui_data_window::set_new_height): Simplify.
8428         * tui/tui-regs.c (tui_last_regs_line_no)
8429         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8430         (tui_show_registers): Update.
8431         (tui_show_register_group): Return void.  Update.
8432         (tui_display_registers_from, tui_display_reg_element_at_line)
8433         (tui_display_registers_from_line, tui_check_register_values):
8434         Update.
8435         * tui/tui-data.h (union tui_which_element) <data_window>: Remove
8436         member.
8437         (struct tui_data_window) <regs_content>: Now a std::vector.
8438         <regs_content_count>: Remove.
8439         (tui_add_content_elements, tui_free_data_content): Don't declare.
8440         * tui/tui-data.c (tui_data_window::clear_detail): Update.
8441         (init_content_element): Remove DATA_WIN case.  Add assert.
8442         (tui_add_content_elements): Remove.
8443         (tui_data_window): Update.
8444         (tui_free_data_content): Remove.
8445         (free_content_elements): Remove DATA_WIN case.
8446
8447 2019-06-25  Tom Tromey  <tom@tromey.com>
8448
8449         * tui/tui-data.c (tui_data_item_window): Update.
8450         * tui/tui-windata.h (tui_check_data_values): Don't declare.
8451         * tui/tui-windata.c (tui_display_all_data)
8452         (tui_display_data_from_line): Update.
8453         (tui_check_data_values): Remove.
8454         * tui/tui-regs.c (tui_show_register_group)
8455         (tui_display_reg_element_at_line): Update.
8456         * tui/tui-hooks.c (tui_register_changed)
8457         (tui_refresh_frame_and_register_information): Call
8458         tui_check_register_values.
8459         * tui/tui-data.h (struct tui_data_window) <data_content,
8460         data_content_count, data_type>: Remove.
8461         (enum tui_data_type): Remove.
8462
8463         * tui/tui-data.c (tui_data_window::clear_detail)
8464         (~tui_data_window): Update.
8465
8466 2019-06-25  Tom Tromey  <tom@tromey.com>
8467
8468         * tui/tui-windata.h (tui_first_data_item_displayed): Don't
8469         declare.
8470         * tui/tui-windata.c (tui_data_window::first_data_item_displayed):
8471         Rename from tui_first_data_item_displayed.  Update.
8472         (tui_data_window::refresh_all)
8473         (tui_data_window::do_scroll_vertical): Update.
8474         * tui/tui-data.h (struct tui_data_window)
8475         <first_data_item_displayed>: Declare new method.
8476
8477 2019-06-25  Tom Tromey  <tom@tromey.com>
8478
8479         * tui/tui-data.h (tui_init_generic_part): Don't declare.
8480         * tui/tui-data.c (tui_init_generic_part): Remove, moving
8481         contents...
8482         (tui_initialize_static_data): ...here.
8483
8484 2019-06-25  Tom Tromey  <tom@tromey.com>
8485
8486         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8487         (tui_display_registers_from, tui_check_register_values): Update.
8488         (tui_display_register): Remove win_info parameter; update.
8489         (tui_get_register): Change type of parameters.
8490         * tui/tui-data.h (struct tui_data_element): Remove.
8491         (union tui_which_element) <data>: Remove.
8492         <data_window>: Change type.
8493         (struct tui_data_item_window): New.
8494         * tui/tui-data.c (init_content_element): Remove DATA_ITEM_WIN
8495         case.  Add assert.
8496         (~tui_data_item_window): New destructor.
8497         (free_content_elements): Remove DATA_ITEM_WIN case.
8498
8499 2019-06-25  Tom Tromey  <tom@tromey.com>
8500
8501         * tui/tui.h (enum tui_win_type) <MAX_WINDOWS, UNDEFINED_WIN>:
8502         Remove.
8503
8504 2019-06-25  Tom Tromey  <tom@tromey.com>
8505
8506         * tui/tui-data.h (struct tui_command_element): Remove.
8507         (union tui_which_element) <command>: Remove.
8508         * tui/tui-data.c (init_content_element): Remove CMD_WIN case.  Add
8509         assert.
8510         (free_content_elements): Remove CMD_WIN case.
8511
8512 2019-06-25  Tom Tromey  <tom@tromey.com>
8513
8514         * tui/tui-layout.c (tui_set_layout): Update.
8515         * tui/tui-data.h (struct tui_layout_def) <split>: Remove.
8516         * tui/tui-data.c (layout_def): Update.
8517
8518 2019-06-25  Tom Tromey  <tom@tromey.com>
8519
8520         * tui/tui-wingeneral.c (tui_refresh_all): Update.
8521         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
8522         (tui_source_window_base::set_new_height): Update.
8523         * tui/tui-stack.c (tui_make_status_line): Change parameter type.
8524         Update.
8525         (tui_set_locator_fullname, tui_set_locator_info)
8526         (tui_show_frame_info): Update.
8527         * tui/tui-source.c (tui_set_source_content)
8528         (tui_source_is_displayed): Update.
8529         * tui/tui-layout.c (show_source_disasm_command, show_data)
8530         (show_source_or_disasm_and_command): Update.
8531         * tui/tui-disasm.c (tui_set_disassem_content)
8532         (tui_get_begin_asm_address): Update.
8533         * tui/tui-data.h (struct tui_locator_element): Remove.
8534         (union tui_which_element) <locator>: Remove.
8535         (struct tui_locator_window): New.
8536         (tui_locator_win_info_ptr): Change return type.
8537         * tui/tui-data.c (_locator): Change type.
8538         (tui_locator_win_info_ptr): Change return type.
8539         (init_content_element): Remove LOCATOR_WIN case.  Add assert.
8540         (tui_alloc_content): Add assert.
8541
8542 2019-06-25  Tom Tromey  <tom@tromey.com>
8543
8544         * tui/tui-winsource.c
8545         (tui_exec_info_window::maybe_allocate_content): New method.
8546         (tui_set_exec_info_content, tui_show_exec_info_content): Update.
8547         * tui/tui-layout.c (init_and_make_win): Add EXEC_INFO_WIN case.
8548         (make_source_or_disasm_window): Add cast.
8549         * tui/tui-data.h (union tui_which_element) <simple_string>:
8550         Remove.
8551         (struct tui_source_info): New.
8552         (struct tui_source_window_base) <execution_info>: Change type.
8553         * tui/tui-data.c (init_content_element): Remove EXEC_INFO_WIN
8554         case, and add assert.
8555         (tui_alloc_content): Add assert.
8556
8557 2019-06-25  Tom Tromey  <tom@tromey.com>
8558
8559         * tui/tui-data.h (tui_alloc_win_info): Don't declare.
8560         * tui/tui-layout.c (init_and_make_win): Use "new" directly.
8561         * tui/tui-data.c (tui_alloc_win_info): Remove.
8562
8563 2019-06-25  Tom Tromey  <tom@tromey.com>
8564
8565         * tui/tui-win.c (tui_set_win_focus_to): Don't check window type.
8566         * tui/tui-wingeneral.c (tui_unhighlight_win): Check
8567         can_highlight.
8568
8569 2019-06-25  Tom Tromey  <tom@tromey.com>
8570
8571         * tui/tui-win.c (tui_source_window_base::update_tab_width): Call
8572         make_visible_with_new_height method.
8573         (tui_win_info::make_visible_with_new_height): New method.
8574         (tui_source_window_base::do_make_visible_with_new_height)
8575         (tui_data_window::do_make_visible_with_new_height)
8576         (tui_cmd_window::do_make_visible_with_new_height): New methods.
8577         (make_visible_with_new_height): Remove.
8578         (tui_resize_all, tui_adjust_win_heights): Use
8579         make_visible_with_new_height method.
8580         * tui/tui-data.h (struct tui_win_info)
8581         <do_make_visible_with_new_height, make_visible_with_new_height>:
8582         New methods.
8583         (struct tui_source_window_base, struct tui_data_window)
8584         (struct tui_cmd_window) <do_make_visible_with_new_height>: New
8585         methods.
8586
8587 2019-06-25  Tom Tromey  <tom@tromey.com>
8588
8589         * tui/tui-win.c (tui_source_window_base::update_tab_width): New
8590         method.
8591         (update_tab_width): Call update_tab_width method.
8592         * tui/tui-data.h (struct tui_win_info)
8593         (struct tui_source_window_base) <update_tab_width>: New methods.
8594
8595 2019-06-25  Tom Tromey  <tom@tromey.com>
8596
8597         * tui/tui-wingeneral.h (tui_make_window): Change type of "box_it"
8598         parameter.
8599         * tui/tui-wingeneral.c (tui_make_window): Change type of "box_it"
8600         parameter.
8601         (tui_gen_win_info::make_visible): Update.
8602         * tui/tui-layout.c (init_and_make_win): Change type of "box_it"
8603         parameter.
8604         * tui/tui-data.h (enum tui_box): New enum.
8605         (BOX_WINDOW, DONT_BOX_WINDOW): Remove defines.
8606
8607 2019-06-25  Tom Tromey  <tom@tromey.com>
8608
8609         * tui/tui-layout.c (make_source_or_disasm_window): Always use
8610         init_and_make_win for EXEC_INFO_WIN.
8611         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>: No
8612         longer inline.
8613         (struct tui_win_info) <~tui_win_info>: Inline.
8614         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8615         Don't declare.
8616         * tui/tui-data.c (source_win, disasm_win): Remove globals.
8617         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8618         Remove.
8619         (tui_initialize_static_data): Update.
8620         (~tui_gen_win_info): Handle more cleanup here.
8621         (~tui_source_window_base): Delete "execution_info".
8622         (~tui_win_info): Move code to ~tui_gen_win_info; remove.
8623
8624 2019-06-25  Tom Tromey  <tom@tromey.com>
8625
8626         * tui/tui-layout.c (make_command_window): Don't set
8627         can_highlight.
8628         (show_source_disasm_command): Call the reset method.
8629         (show_data): Don't set can_highlight.  Call the reset method.
8630         (tui_gen_win_info::reset): Rename from init_gen_win_info
8631         (init_and_make_win): Simplify.  Return tui_gen_win_info.
8632         (show_source_or_disasm_and_command): Call the reset method.
8633         * tui/tui-data.h (struct tui_gen_win_info) <reset>: New method.
8634         (struct tui_cmd_window): Set can_highlight.
8635
8636 2019-06-25  Tom Tromey  <tom@tromey.com>
8637
8638         * tui/tui-wingeneral.c (tui_gen_win_info::make_visible): Rename
8639         from make_visible.
8640         (tui_make_visible, tui_make_invisible): Rewrite.
8641         (tui_win_info::make_visible): Remove.
8642         (tui_source_window_base::make_visible): Update.
8643         * tui/tui-data.h (struct tui_gen_win_info) <make_visible>: New
8644         method.  Moved from...
8645         (struct tui_win_info) <make_visible>: ...here.
8646
8647 2019-06-25  Tom Tromey  <tom@tromey.com>
8648
8649         * tui/tui-winsource.c
8650         (tui_source_window_base::do_scroll_horizontal): Remove direction
8651         parameter.
8652         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Remove
8653         direction parameter.
8654         * tui/tui-win.c (tui_win_info::forward_scroll)
8655         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
8656         (tui_win_info::right_scroll): Update.
8657         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Remove
8658         direction parameter.
8659         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Remove
8660         direction parameter.
8661         * tui/tui-data.h (enum tui_scroll_direction): Remove.
8662         (struct tui_win_info) <do_scroll_vertical, do_scroll_horizontal>:
8663         Remove direction parameter.
8664         (struct tui_source_window_base, struct tui_source_window)
8665         (struct tui_disasm_window, struct tui_data_window)
8666         (struct tui_cmd_window): Update.
8667
8668 2019-06-25  Tom Tromey  <tom@tromey.com>
8669
8670         * tui/tui-winsource.h (tui_set_exec_info_content)
8671         (tui_show_exec_info_content, tui_erase_exec_info_content)
8672         (tui_clear_exec_info_content, tui_update_exec_info): Change
8673         argument to tui_source_window_base.
8674         * tui/tui-winsource.c (tui_set_exec_info_content)
8675         (tui_show_exec_info_content, tui_erase_exec_info_content)
8676         (tui_clear_exec_info_content, tui_update_exec_info): Change
8677         argument to tui_source_window_base.
8678
8679 2019-06-25  Tom Tromey  <tom@tromey.com>
8680
8681         * tui/tui-winsource.h (tui_set_exec_info_content): Return void.
8682         * tui/tui-winsource.c (tui_set_exec_info_content): Return void.
8683
8684 2019-06-25  Tom Tromey  <tom@tromey.com>
8685
8686         * tui/tui-winsource.c (tui_set_exec_info_content): Remove NULL
8687         check.
8688
8689 2019-06-25  Tom Tromey  <tom@tromey.com>
8690
8691         * tui/tui-winsource.h (tui_alloc_source_buffer): Change return
8692         type to void.
8693         * tui/tui-winsource.c (tui_alloc_source_buffer): Change return
8694         type to void.
8695         * tui/tui-source.c (tui_set_source_content): Update.
8696         * tui/tui-disasm.c (tui_set_disassem_content): Update.
8697
8698 2019-06-25  Tom Tromey  <tom@tromey.com>
8699
8700         * tui/tui-win.c (window_name_completer, tui_set_focus)
8701         (tui_all_windows_info): Use name method.
8702         * tui/tui-data.h (struct tui_gen_win_info)
8703         (struct tui_source_window, struct tui_disasm_window)
8704         (struct tui_data_window, struct tui_cmd_window) <name>: New
8705         method.
8706         (tui_win_name): Don't declare.
8707         * tui/tui-data.c (tui_partial_win_by_name): Use name method.
8708         (tui_win_name): Remove.
8709
8710 2019-06-25  Tom Tromey  <tom@tromey.com>
8711
8712         * tui/tui-winsource.h (tui_update_source_window)
8713         (tui_update_source_window_as_is): Change parameter type.
8714         * tui/tui-winsource.c (tui_update_source_window): Change win_info
8715         to be a tui_source_window_base.
8716         (tui_update_source_window_as_is): Likewise.
8717         * tui/tui-win.c (make_visible_with_new_height): Update.
8718
8719 2019-06-25  Tom Tromey  <tom@tromey.com>
8720
8721         * tui/tui-winsource.c (tui_erase_source_content)
8722         (tui_show_source_content, tui_show_exec_info_content)
8723         (tui_erase_exec_info_content): Use refresh_window method.
8724         * tui/tui-wingeneral.h (tui_refresh_win): Don't declare.
8725         * tui/tui-wingeneral.c (tui_gen_win_info::refresh_window): Rename
8726         from tui_refresh_win.
8727         (tui_data_window::refresh_window): New method.
8728         (tui_win_info::refresh, tui_source_window_base::refresh)
8729         (tui_refresh_all): Use refresh_window method.
8730         * tui/tui-stack.c (tui_show_locator_content): Call refresh_window
8731         method.
8732         * tui/tui-regs.c (tui_display_register): Call refresh_window
8733         method.
8734         * tui/tui-layout.c (show_source_disasm_command)
8735         (show_source_or_disasm_and_command): Call refresh_window method.
8736         * tui/tui-data.h (struct tui_gen_win_info)
8737         (struct tui_data_window, struct tui_cmd_window) <refresh_window>:
8738         New method.
8739
8740 2019-06-25  Tom Tromey  <tom@tromey.com>
8741
8742         * tui/tui.c (tui_rl_other_window, tui_enable)
8743         (tui_is_window_visible, tui_get_command_dimension): Update.
8744         * tui/tui-winsource.c (tui_update_source_window_as_is)
8745         (tui_clear_source_content, tui_erase_source_content)
8746         (tui_show_source_line, tui_source_window_base::refill)
8747         (tui_source_window_base::do_scroll_horizontal)
8748         (tui_source_window_base::set_is_exec_point_at)
8749         (tui_update_breakpoint_info, tui_set_exec_info_content)
8750         (tui_alloc_source_buffer, tui_line_is_displayed)
8751         (tui_addr_is_displayed): Update.
8752         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
8753         (tui_check_and_display_highlight_if_needed)
8754         (tui_win_info::make_visible, tui_win_info::refresh)
8755         (tui_refresh_all): Update.
8756         * tui/tui-windata.c (tui_first_data_item_displayed)
8757         (tui_delete_data_content_windows, tui_erase_data_content)
8758         (tui_display_all_data, tui_data_window::refresh_all)
8759         (tui_check_data_values): Update.
8760         * tui/tui-win.c (window_name_completer, tui_update_gdb_sizes)
8761         (tui_set_win_focus_to, tui_win_info::forward_scroll)
8762         (tui_win_info::backward_scroll, tui_refresh_all_win)
8763         (tui_resize_all, tui_set_focus, tui_all_windows_info)
8764         (update_tab_width, tui_set_win_height, tui_adjust_win_heights)
8765         (tui_source_window_base::set_new_height)
8766         (tui_data_window::set_new_height)
8767         (make_invisible_and_set_new_height)
8768         (make_visible_with_new_height, new_height_ok)
8769         (parse_scrolling_args): Update.
8770         * tui/tui-stack.c (tui_show_frame_info): Update.
8771         * tui/tui-source.c (tui_set_source_content)
8772         (tui_set_source_content_nil, tui_source_is_displayed)
8773         (tui_source_window::do_scroll_vertical): Update.
8774         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8775         (tui_display_registers_from, tui_display_reg_element_at_line)
8776         (tui_check_register_values, tui_reg_command): Update.
8777         * tui/tui-layout.c (tui_default_win_height)
8778         (show_source_disasm_command, show_data, init_and_make_win)
8779         (show_source_or_disasm_and_command): Update.
8780         * tui/tui-io.c (update_cmdwin_start_line, tui_putc, tui_puts)
8781         (tui_redisplay_readline, tui_mld_flush)
8782         (tui_mld_erase_entire_line, tui_mld_getc, tui_cont_sig)
8783         (tui_getc): Update.
8784         * tui/tui-disasm.c (tui_set_disassem_content)
8785         (tui_disasm_window::do_scroll_vertical): Update.
8786         * tui/tui-data.h (struct tui_gen_win_info) <~tui_gen_win_info>:
8787         Now virtual.
8788         (struct tui_win_info): Derive from tui_gen_win_info.
8789         <~tui_win_info>: Mark as override.
8790         <generic>: Remove member.
8791         * tui/tui-data.c (tui_cmd_window::clear_detail, tui_next_win)
8792         (tui_prev_win, tui_partial_win_by_name, tui_win_info)
8793         (~tui_data_window, ~tui_win_info)
8794         (tui_free_all_source_wins_content): Update.
8795         * tui/tui-command.c (tui_refresh_cmd_win): Update.
8796
8797 2019-06-25  Tom Tromey  <tom@tromey.com>
8798
8799         * tui/tui-layout.c (init_and_make_win): Use new.
8800         * tui/tui-data.h (struct tui_gen_win_info): Add constructor,
8801         destructor, initializers.
8802         (tui_alloc_generic_win_info): Don't declare.
8803         * tui/tui-data.c (_locator): Add argument to constructor.
8804         (source_win, disasm_win): New globals.
8805         (exec_info): Remove.
8806         (tui_source_exec_info_win_ptr, tui_disassem_exec_info_win_ptr):
8807         Update.
8808         (tui_alloc_generic_win_info): Remove.
8809         (init_content_element): Use new.
8810         (tui_win_info::tui_win_info): Update.
8811         (free_content_elements) <case DATA_WIN>: Use delete.
8812
8813 2019-06-25  Tom Tromey  <tom@tromey.com>
8814
8815         * tui/tui-wingeneral.c (tui_refresh_win): Update.
8816         * tui/tui-windata.c (tui_first_data_item_displayed)
8817         (tui_delete_data_content_windows): Update.
8818         * tui/tui-win.c (tui_data_window::set_new_height): Update.
8819         * tui/tui-regs.c (tui_show_registers, tui_show_register_group)
8820         (tui_display_registers_from, tui_check_register_values): Update.
8821         * tui/tui-data.h (union tui_which_element) <data_window>: Now a
8822         pointer.
8823         * tui/tui-data.c (init_content_element): Update.  Allocate the new
8824         window.
8825         (tui_free_data_content): Update.
8826         (free_content_elements) <case DATA_WIN>: Free the window.
8827
8828 2019-06-25  Tom Tromey  <tom@tromey.com>
8829
8830         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win):
8831         Update.
8832         * tui/tui-layout.c (make_command_window)
8833         (show_source_disasm_command, show_data, init_and_make_win)
8834         (show_source_or_disasm_and_command): Update.
8835         * tui/tui-data.h (struct tui_win_info) <set_highlight>: New
8836         method.
8837         <can_highight, is_highlighted>: Now bool.
8838         (tui_set_win_highlight): Don't declare.
8839         * tui/tui-data.c (tui_set_win_highlight): Remove.
8840
8841 2019-06-25  Tom Tromey  <tom@tromey.com>
8842
8843         * tui/tui-wingeneral.c (make_visible): Remove check of window
8844         type.
8845
8846 2019-06-25  Tom Tromey  <tom@tromey.com>
8847
8848         * tui/tui-win.c (tui_win_info::max_height)
8849         (tui_cmd_window::max_height): New methods.
8850         (new_height_ok): Call max_height.
8851         * tui/tui-data.h (struct tui_win_info, struct tui_cmd_window)
8852         <max_height>: New method.
8853
8854 2019-06-25  Tom Tromey  <tom@tromey.com>
8855
8856         * tui/tui-win.c (tui_source_window_base::set_new_height)
8857         (tui_data_window::set_new_height): New methods.
8858         (make_invisible_and_set_new_height): Call set_new_height method.
8859         * tui/tui-data.h (struct tui_win_info)
8860         (struct tui_source_window_base, struct tui_data_window)
8861         <set_new_height>: New method.
8862
8863 2019-06-25  Tom Tromey  <tom@tromey.com>
8864
8865         * tui/tui.c (tui_rl_other_window): Call the refresh_all method.
8866         * tui/tui-windata.c (tui_data_window::refresh_all): Rename from
8867         tui_refresh_data_win.
8868         * tui/tui-win.c (tui_source_window_base::refresh_all): New
8869         method.
8870         (tui_refresh_all_win): Call the refresh_all method.
8871         (tui_set_focus): Likewise.
8872         * tui/tui-data.h (struct tui_win_info) <refresh_all>: New method.
8873         (struct tui_source_window_base, struct tui_data_window) <refresh>:
8874         Likewise.
8875
8876 2019-06-25  Tom Tromey  <tom@tromey.com>
8877
8878         * tui/tui-winsource.h (tui_refill_source_window)
8879         (tui_set_is_exec_point_at): Don't declare.
8880         * tui/tui-winsource.c (tui_update_source_windows_with_addr)
8881         (tui_source_window_base::refill): Rename from
8882         tui_refill_source_window.
8883         (tui_source_window_base::do_scroll_horizontal): Update.
8884         (tui_source_window_base::set_is_exec_point_at): Rename from
8885         tui_set_is_exec_point_at.
8886         (tui_update_all_breakpoint_info): Update.
8887         * tui/tui-stack.c (tui_show_frame_info): Update.
8888         * tui/tui-layout.c (show_data): Add cast.
8889         * tui/tui-hooks.c (tui_redisplay_source): Call refill method.
8890         * tui/tui-data.h (struct tui_source_window_base) <refill,
8891         set_is_exec_point_at>: New methods.
8892         (tui_source_windows, tui_add_to_source_windows): Update types.
8893         (tui_add_to_source_windows): Remove redundant declaration.
8894         * tui/tui-data.c (source_windows): Store tui_source_window_base.
8895         (tui_source_windows): Change return type.
8896         (tui_clear_source_windows_detail): Update.
8897         (tui_add_to_source_windows): Change type of parameter.
8898         (tui_free_all_source_wins_content): Update.
8899
8900 2019-06-25  Tom Tromey  <tom@tromey.com>
8901
8902         * tui/tui-wingeneral.c (tui_win_info::refresh)
8903         (tui_source_window_base::refresh): New methods.
8904         (tui_refresh_all): Call the refresh method.
8905         * tui/tui-data.h (struct tui_win_info)
8906         (struct tui_source_window_base) <refresh>: New method.
8907
8908 2019-06-25  Tom Tromey  <tom@tromey.com>
8909
8910         * tui/tui.h (tui_is_window_visible): Return bool.
8911         * tui/tui.c (tui_is_window_visible): Return bool.
8912         * tui/tui-wingeneral.c (tui_make_window, make_visible)
8913         (tui_make_visible, tui_make_invisible)
8914         (tui_win_info::make_visible)
8915         (tui_source_window_base::make_visible, make_all_visible)
8916         (tui_make_all_visible, tui_make_all_invisible): Update.
8917         * tui/tui-windata.c (tui_delete_data_content_windows): Update.
8918         * tui/tui-data.h (struct tui_gen_win_info) <is_visible>: Now
8919         bool.
8920         (struct tui_win_info, struct tui_source_window_base)
8921         (struct tui_cmd_window) <make_visible>: Change parameter to bool.
8922         * tui/tui-data.c (tui_init_generic_part): Update.
8923
8924 2019-06-25  Tom Tromey  <tom@tromey.com>
8925
8926         * tui/tui-wingeneral.c (tui_win_info::make_visible)
8927         (tui_source_window_base::make_visible): New methods.
8928         (make_all_visible): Make method call.
8929         * tui/tui-data.h (struct tui_win_info) <make_visible>: New method.
8930         (struct tui_source_window_base, struct tui_cmd_window): Override
8931         make_visible.
8932         (tui_win_is_source_type): Don't declare.
8933         * tui/tui-data.c (tui_win_is_source_type): Remove.
8934
8935 2019-06-25  Tom Tromey  <tom@tromey.com>
8936
8937         * tui/tui-layout.c (show_source_or_disasm_and_command): Remove
8938         NULL check.
8939
8940 2019-06-25  Tom Tromey  <tom@tromey.com>
8941
8942         * tui/tui-data.h (struct tui_data_window, struct tui_cmd_window):
8943         Inline constructor.  Add initializers for members.
8944         * tui/tui-data.c (tui_data_window, tui_cmd_window): Remove
8945         constructors; now inline in class.
8946
8947 2019-06-25  Tom Tromey  <tom@tromey.com>
8948
8949         * tui/tui-regs.c (tui_show_registers): Update.
8950         * tui/tui-data.h (struct tui_data_window) <display_regs>: Now
8951         bool.
8952         * tui/tui-data.c (tui_data_window::clear_detail)
8953         (tui_data_window): Update.
8954
8955 2019-06-25  Tom Tromey  <tom@tromey.com>
8956
8957         * tui/tui-windata.c (tui_display_all_data)
8958         (tui_display_data_from_line, tui_display_data_from)
8959         (tui_check_data_values, tui_data_window::do_scroll_vertical):
8960         Update.
8961         * tui/tui-regs.c (tui_last_regs_line_no)
8962         (tui_line_from_reg_element_no, tui_first_reg_element_no_inline)
8963         (tui_show_registers, tui_show_register_group)
8964         (tui_display_registers_from, tui_display_reg_element_at_line)
8965         (tui_display_registers_from_line, tui_check_register_values)
8966         (tui_reg_next, tui_reg_prev): Update.
8967         * tui/tui-layout.c (tui_set_layout, show_data): Update.
8968         * tui/tui-data.h (struct tui_data_info): Remove.  Move contents to
8969         tui_data_window.
8970         (struct tui_win_info) <detail>: Remove.  Add new fields from
8971         tui_data_info.
8972         (TUI_DATA_WIN): Add cast.
8973         * tui/tui-data.c (tui_data_window::clear_detail, tui_data_window)
8974         (~tui_data_window): Simplify.
8975
8976 2019-06-25  Tom Tromey  <tom@tromey.com>
8977
8978         * tui/tui-layout.c (show_source_disasm_command)
8979         (show_source_or_disasm_and_command): Update.
8980         * tui/tui-io.c (update_cmdwin_start_line)
8981         (tui_redisplay_readline): Update.
8982         * tui/tui-data.h (struct tui_command_info): Remove.
8983         (struct tui_win_info) <detail>: Remove command_info member.
8984         (struct tui_data_window) <start_line>: New member, from
8985         tui_command_info.
8986         (TUI_CMD_WIN): Add casts.
8987
8988 2019-06-25  Tom Tromey  <tom@tromey.com>
8989
8990         * tui/tui-winsource.c (tui_update_source_window)
8991         (tui_refill_source_window)
8992         (tui_source_window_base::do_scroll_horizontal)
8993         (tui_update_breakpoint_info, tui_set_exec_info_content)
8994         (tui_show_exec_info_content, tui_erase_exec_info_content)
8995         (tui_clear_exec_info_content): Update.
8996         * tui/tui-wingeneral.c (make_all_visible, tui_refresh_all):
8997         Update.
8998         * tui/tui-win.c (make_invisible_and_set_new_height)
8999         (make_visible_with_new_height): Update.
9000         * tui/tui-source.c (tui_set_source_content)
9001         (tui_show_symtab_source): Update.
9002         * tui/tui-layout.c (extract_display_start_addr)
9003         (show_source_disasm_command, show_data)
9004         (make_source_or_disasm_window)
9005         (show_source_or_disasm_and_command): Update.
9006         * tui/tui-disasm.c (tui_set_disassem_content): Simplify.
9007         (tui_disasm_window::do_scroll_vertical): Remove shadowing
9008         "gdbarch".
9009         * tui/tui-data.h (struct tui_source_info): Remove.  Move contents
9010         to tui_source_window_base.
9011         (struct tui_win_info) <detail>: Remove source_info member.
9012         (struct tui_source_window_base) <has_locator>: Inline.
9013         Move contents from tui_source_info; rename has_locator member to
9014         m_has_locator.
9015         (TUI_SRC_WIN, TUI_DISASM_WIN): Add casts.
9016         * tui/tui-data.c (tui_source_window_base::has_locator): Move to
9017         header file.
9018         (tui_source_window_base::clear_detail, ~tui_source_window_base):
9019         Simplify.
9020         (tui_free_all_source_wins_content): Cast to
9021         tui_source_window_base.
9022
9023 2019-06-25  Tom Tromey  <tom@tromey.com>
9024
9025         * tui/tui-win.c (make_invisible_and_set_new_height)
9026         (make_visible_with_new_height): Call has_locator method.
9027         * tui/tui-layout.c (show_source_disasm_command, show_data)
9028         (show_source_or_disasm_and_command): Update for bool change.
9029         * tui/tui-data.h (struct tui_source_info) <has_locator>: Now bool.
9030         (tui_win_info) <has_locator>: New method.
9031         (struct tui_source_window_base) <has_locator>: New method.
9032         (tui_win_has_locator): Don't declare.
9033         * tui/tui-data.c (tui_source_window_base::has_locator): Rename
9034         from tui_win_has_locator.
9035         (tui_source_window_base): Use false, not FALSE.
9036
9037 2019-06-25  Tom Tromey  <tom@tromey.com>
9038
9039         * tui/tui-data.h (tui_clear_win_detail): Don't declare.
9040         * tui/tui-data.c (tui_clear_source_windows_detail): Call the
9041         clear_detail method directly.
9042         (tui_clear_win_detail): Remove.
9043
9044 2019-06-25  Tom Tromey  <tom@tromey.com>
9045
9046         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Use
9047         "this", not TUI_DISASM_WIN.
9048
9049 2019-06-25  Tom Tromey  <tom@tromey.com>
9050
9051         * tui/tui-winsource.h (tui_horizontal_source_scroll):  Don't
9052         declare.
9053         * tui/tui-winsource.c
9054         (tui_source_window_base::do_scroll_horizontal): Rename from
9055         tui_horizontal_source_scroll.
9056         * tui/tui-windata.h (tui_vertical_data_scroll): Don't declare.
9057         * tui/tui-windata.c (tui_data_window::do_scroll_vertical): Rename
9058         from tui_vertical_data_scroll.
9059         * tui/tui-win.h (tui_scroll): Don't declare.
9060         * tui/tui-win.c (tui_win_info::forward_scroll)
9061         (tui_win_info::backward_scroll, tui_win_info::left_scroll)
9062         (tui_win_info::right_scroll): Rename and update.
9063         (tui_scroll_forward_command, tui_scroll_backward_command)
9064         (tui_scroll_left_command, tui_scroll_right_command): Update.
9065         (tui_scroll): Remove.
9066         * tui/tui-source.h: Don't declare tui_vertical_source_scroll.
9067         * tui/tui-source.c (tui_source_window::do_scroll_vertical): Rename
9068         from tui_vertical_source_scroll.
9069         * tui/tui-disasm.h (tui_vertical_disassem_scroll): Don't declare.
9070         * tui/tui-disasm.c (tui_disasm_window::do_scroll_vertical): Rename
9071         from tui_vertical_disassem_scroll.
9072         * tui/tui-data.h (struct tui_win_info) <do_scroll_vertical,
9073         do_scroll_horizontal>: New methods.
9074         <forward_scroll, backward_scroll, left_scroll, right_scroll>:
9075         Likewise.
9076         (struct tui_source_window_base): Add do_scroll_horizontal.
9077         (struct tui_source_window, struct tui_disasm_window): Add
9078         do_scroll_vertical.
9079         (struct tui_data_window, struct tui_cmd_window): Add
9080         do_scroll_horizontal and do_scroll_vertical.
9081         * tui/tui-command.c (tui_dispatch_ctrl_char): Use method calls.
9082
9083 2019-06-25  Tom Tromey  <tom@tromey.com>
9084
9085         * tui/tui-data.h (struct tui_source_window_base): New struct.
9086         (struct tui_source_window): Derive from tui_source_window_base.
9087         (struct tui_disasm_window): New struct.
9088         * tui/tui-data.c (tui_source_window_base::clear_detail): Rename
9089         from tui_source_window::clear_detail.
9090         (tui_source_window_base): Rename from tui_source_window.
9091         (~tui_source_window_base): Rename from ~tui_source_window.
9092         (tui_alloc_win_info): Create a tui_disasm_window.
9093
9094 2019-06-25  Tom Tromey  <tom@tromey.com>
9095
9096         * tui/tui-data.h (struct tui_source_window)
9097         (struct tui_data_window): Declare destructors.
9098         * tui/tui-data.c (~tui_source_window, ~tui_data_window): New
9099         destructors.
9100         (tui_win_info): Simplify.
9101
9102 2019-06-25  Tom Tromey  <tom@tromey.com>
9103
9104         * tui/tui-winsource.c (tui_display_main)
9105         (tui_update_source_windows_with_addr)
9106         (tui_update_all_breakpoint_info): Update.
9107         * tui/tui-win.c (tui_resize_all, tui_adjust_win_heights)
9108         (new_height_ok, parse_scrolling_args): Update.
9109         * tui/tui-stack.c (tui_show_frame_info): Update.
9110         * tui/tui-data.h (struct tui_list): Remove.
9111         (tui_source_windows): Return a reference to a std::vector.
9112         * tui/tui-data.c (source_windows): Now a std::vector.
9113         (tui_source_windows): Change return type.
9114         (tui_clear_source_windows): Rewrite.
9115         (tui_clear_source_windows_detail, tui_add_to_source_windows)
9116         (tui_free_all_source_wins_content): Rewrite.
9117
9118 2019-06-25  Tom Tromey  <tom@tromey.com>
9119
9120         * tui/tui-data.h (struct tui_win_info, struct tui_source_window)
9121         (struct tui_data_window, struct tui_cmd_window): Declare
9122         clear_detail method.
9123         * tui/tui-data.c (tui_source_window::clear_detail)
9124         (tui_cmd_window::clear_detail, tui_data_window::clear_detail): New
9125         methods.
9126         (tui_clear_win_detail): Simplify.
9127
9128 2019-06-25  Tom Tromey  <tom@tromey.com>
9129
9130         * tui/tui-layout.c (make_source_window, make_disasm_window)
9131         (make_source_or_disasm_window): Remove win_info_ptr parameter.
9132         Return the new window.
9133         (show_source_disasm_command, show_data)
9134         (show_source_or_disasm_and_command): Update.
9135
9136 2019-06-25  Tom Tromey  <tom@tromey.com>
9137
9138         * tui/tui-layout.c (make_command_window): Remove win_info_ptr
9139         parameter.  Return the new window.
9140         (show_source_disasm_command): Update and remove NULL check.
9141         (show_source_or_disasm_and_command): Update.
9142
9143 2019-06-25  Tom Tromey  <tom@tromey.com>
9144
9145         * tui/tui-layout.c (init_and_make_win): Remove NULL check.
9146
9147 2019-06-25  Tom Tromey  <tom@tromey.com>
9148
9149         * tui/tui-data.h (struct tui_win_info): Make constructor
9150         protected.  Make destructor virtual.  Add initializers.
9151         (tui_source_window, tui_data_window, tui_cmd_window): New
9152         classes.
9153         * tui/tui-data.c (tui_win_info): Rename from init_win_info.  Now a
9154         constructor.  Add "type" parameter.
9155         (tui_source_window, tui_data_window, tui_cmd_window): New
9156         constructors.
9157         (tui_alloc_win_info): Instantiate the appropriate subclass.
9158
9159 2019-06-25  Tom Tromey  <tom@tromey.com>
9160
9161         * tui/tui-win.c (tui_resize_all): Use delete.
9162         * tui/tui-data.h (struct tui_win_info) <~tui_win_info>: Declare
9163         destructor.
9164         (tui_free_window): Don't declare.
9165         * tui/tui-data.c (~tui_win_info): Rename from tui_free_window.
9166         Update.
9167
9168 2019-06-25  Tom Tromey  <tom@tromey.com>
9169
9170         * tui/tui-data.h (struct tui_win_info): Add constructor.
9171         * tui/tui-data.c (tui_alloc_win_info): Use new.
9172         (tui_free_window): Use delete.
9173
9174 2019-06-22  Tom Tromey  <tom@tromey.com>
9175
9176         * tui/tui-windata.h (tui_first_data_element_no_in_line): Don't
9177         declare.
9178         * tui/tui-windata.c (tui_first_data_element_no_in_line): Remove.
9179
9180 2019-06-22  Tom Tromey  <tom@tromey.com>
9181
9182         * tui/tui-data.h (tui_del_window, tui_del_data_windows): Don't
9183         declare.
9184         * tui/tui-data.c (tui_del_window, tui_del_data_windows): Remove.
9185
9186 2019-06-22  Tom de Vries  <tdevries@suse.de>
9187
9188         * dwarf2read.c (create_addrmap_from_aranges)
9189         (read_debug_names_from_section): Print ptrdiff_t using '%s' and plongest
9190         instead of '%zu'.
9191
9192 2019-06-21  Simon Marchi  <simon.marchi@efficios.com>
9193
9194         * dwarf2read.h (dwarf2_section_info_def): Remove.
9195         (DEF_VEC_O (dwarf2_section_info_def)): Remove.
9196         * dwarf2read.c (struct dwo_sections) <types>: Change type to
9197         std::vector<dwarf2_section_info>.
9198         (struct dwo_file) <~dwo_file>: Remove.
9199         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't manually free
9200         types field.
9201         (dwarf2_per_objfile::locate_sections): Adjust to std::vector.
9202         (dwarf2_read_debug_names): Likewise.
9203         (create_debug_types_hash_table): Change parameter type to
9204         array_view, adjust code accordingly.
9205         (dwarf2_locate_dwo_sections): Adjust to std::vector.
9206         (partial_die_info::fixup): Likewise.
9207         (determine_prefix): Likewise.
9208         * dwarf-index-write.c (write_psymtabs_to_index): Adjust.
9209
9210 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9211
9212         * dwarf2read.c (struct dwo_file) <dbfd>: Change type to
9213         gdb_bfd_ref_ptr.
9214         <~dwo_file>: Remove call to gdb_bfd_unref.
9215         (open_and_init_dwo_file): Move gdb_bfd_ref_ptr into dbfd field. Call
9216         gdb_bfd_ref_ptr::get.
9217
9218 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9219
9220         * dwarf2read.h (struct dwarf2_per_objfile) <dwo_files>: Change
9221         type to htab_up.
9222         * dwarf2read.c (struct dwo_file): Initialize fields.
9223         <~dwo_file>: New.
9224         (free_dwo_file): Remove, move content to ~dwo_file.
9225         (struct dwo_file_deleter): Remove.
9226         (dwo_file_up>: Remove custom deleter.
9227         (free_dwo_files): Remove.
9228         (dwarf2_per_objfile::~dwarf2_per_objfile): Don't explicitly free
9229         dwo_files.
9230         (process_skeletonless_type_units): Call unique_ptr::get.
9231         (allocate_dwo_file_hash_table): Add deleter to created hash
9232         table.  Change return type to htab_up.
9233         (lookup_dwo_file_slot): Don't memset dwo_file, call
9234         unique_ptr::get.
9235         (create_dwo_unit_in_dwp_v1): Allocate dwo_file with new.
9236         (create_dwo_unit_in_dwp_v2): Likewise.
9237         (open_and_init_dwo_file): Likewise.
9238         (free_dwo_file_from_slot): Remove.
9239
9240 2019-06-21  Simon Marchi  <simon.marchi@polymtl.ca>
9241
9242         * dwarf2read.h (struct dwarf2_section_info) <readin,
9243         is_virtual>: Change type to bool.
9244         * dwarf2read.c (dwarf2_read_section, create_dwp_v2_section): Use
9245         true instead of 1.
9246
9247 2019-06-19  Tom Tromey  <tom@tromey.com>
9248
9249         * tui/tui-data.h (tui_init_content_element): Don't declare.
9250
9251 2019-06-19  Tom Tromey  <tom@tromey.com>
9252
9253         * tui/tui-data.h (tui_init_win_info): Don't declare.
9254
9255 2019-06-19  Tom de Vries  <tdevries@suse.de>
9256
9257         * dwarf2read.h (abstract_to_concrete): Change type to
9258         std::unordered_map<sect_offset, std::vector<sect_offset>,
9259         gdb::hash_enum<sect_offset>>.
9260
9261 2019-06-19  Tom Tromey  <tromey@adacore.com>
9262
9263         * ada-lang.c (ada_evaluate_subexp) <case OP_ATR_FIRST>: Handle
9264         EVAL_AVOID_SIDE_EFFECTS specially.
9265
9266 2019-06-19  Tom Tromey  <tromey@adacore.com>
9267
9268         * source-cache.c (highlighter): New global.
9269         (source_cache::get_source_lines): Create a highlighter on demand.
9270
9271 2019-06-18  Andrew Burgess  <andrew.burgess@embecosm.com>
9272
9273         * defs.h (deprecated_interactive_hook): Delete declaration.
9274         * interps.c (clear_interpreter_hooks): Remove use of
9275         deprecated_interactive_hook.
9276         * top.c (deprecated_interactive_hook): Delete definition.
9277         * utils.c (maybe_quit): Remove use of deprecated_interactive_hook.
9278
9279 2019-06-18  Tom de Vries  <tdevries@suse.de>
9280
9281         PR gdb/24515
9282         * dwarf2read.h (abstract_to_concrete): Change type from
9283         std::unordered_map<die_info_ptr, std::vector<die_info_ptr>> to
9284         std::unordered_map<sect_offset, std::vector<sect_offset>>.
9285         * dwarf2read.c (read_variable): Update.
9286         (dwarf2_fetch_die_loc_sect_off): Update.
9287
9288 2019-06-17  Tom de Vries  <tdevries@suse.de>
9289
9290         PR gdb/24617
9291         * common/pathstuff.c (child_path): Make sure parent_len > 0 before
9292         accessing parent[parent_len - 1].
9293
9294 2019-06-17  Paul Pluzhnikov  <ppluzhnikov@google.com>
9295
9296         PR gdb/24364
9297         * gdb/dtrace-probe.c (dtrace_static_probe_ops::get_probe): Don't
9298         call dtrace_process_dof with NULL dof.
9299
9300 2019-06-16  Tom de Vries  <tdevries@suse.de>
9301
9302         PR gdb/24445
9303         * contrib/gdb-add-index.sh: Update to handle dwz-m-ed executable.
9304
9305 2019-06-16  Tom Tromey  <tom@tromey.com>
9306
9307         * tui/tui-wingeneral.c (tui_unhighlight_win, tui_highlight_win)
9308         (make_all_visible): Use address of member.
9309
9310 2019-06-16  Tom Tromey  <tom@tromey.com>
9311
9312         * tui/tui-data.c (tui_clear_win_detail, init_win_info)
9313         (tui_free_window, free_content, free_content_elements): Remove
9314         unnecessary cast.
9315         * tui/tui-windata.c (tui_display_all_data): Remove unnecessary
9316         cast.
9317         * tui/tui-regs.c (tui_show_register_group)
9318         (tui_display_registers_from, tui_display_reg_element_at_line):
9319         Remove unnecessary cast.
9320
9321 2019-06-16  Andrew Burgess  <andrew.burgess@embecosm.com>
9322
9323         * linux-nat.c (normal_mask): Delete.
9324         (_initialize_linux_nat): Don't initialise normal_mask.
9325
9326 2019-06-16  Simon Marchi  <simon.marchi@polymtl.ca>
9327
9328         PR gdb/24445
9329         * dwarf-index-write.h (write_psymtabs_to_index): Add
9330         dwz_basename parameter.
9331         * dwarf-index-write.c (write_gdbindex): Move file writing to
9332         write_gdbindex_1.  Change return type void.
9333         (assert_file_size): Move up, remove filename parameter.
9334         (write_gdbindex_1): New function.
9335         (write_debug_names): Change return type to void, call
9336         assert_file_size.
9337         (struct index_wip_file): New struct.
9338         (write_psymtabs_to_index): Add dwz_basename parameter.  Move
9339         file logic to index_wip_file.  Write index for dwz file if
9340         needed.
9341         (save_gdb_index_command): Pass basename of dwz file, if present.
9342         * dwarf-index-cache.c (index_cache::store): Obtain and pass
9343         build-id of dwz file, if present.
9344         * dwarf2read.c (struct dwz_file): Move to dwarf2read.h.
9345         (dwarf2_get_dwz_file): Likewise.
9346         * dwarf2read.h (struct dwz_file): Move from dwarf2read.c.
9347         (dwarf2_get_dwz_file): Likewise.
9348
9349 2019-06-16  Tom Tromey  <tom@tromey.com>
9350
9351         * coffread.c (process_coff_symbol): Use xstrdup.
9352         * value.c (create_internalvar): Use xstrdup.
9353
9354 2019-06-16  Tom Tromey  <tom@tromey.com>
9355
9356         * valops.c (value_cast, value_slice): Remove unnecessary cast.
9357         * breakpoint.c (stopin_command, stopat_command)
9358         (until_break_command, decode_location_default): Remove unnecessary
9359         cast.
9360         * utils.c (subset_compare): Remove unnecessary cast.
9361         * ada-lang.c (ada_update_initial_language): Remove unnecessary
9362         cast.
9363         * linespec.c (decode_line_with_last_displayed): Remove unnecessary
9364         cast.
9365         * infcmd.c (path_command): Remove unnecessary cast.
9366         * coffread.c (decode_type): Remove unnecessary cast.
9367         * xcoffread.c (read_xcoff_symtab): Remove unnecessary cast.
9368         * mipsread.c (mipscoff_symfile_read): Remove unnecessary cast.
9369         * tui/tui-stack.c (tui_show_locator_content)
9370         (tui_show_frame_info): Remove unnecessary cast.
9371         * tui/tui-win.c (tui_scroll_forward_command)
9372         (tui_scroll_backward_command, tui_set_focus, tui_set_win_height)
9373         (parse_scrolling_args): Remove unnecessary cast.
9374         * tui/tui-data.c (init_win_info, tui_del_window)
9375         (tui_free_window, tui_del_data_windows, tui_free_data_content)
9376         (free_content_elements): Remove unnecessary cast.
9377         * tui/tui-windata.c (tui_first_data_item_displayed): Remove
9378         unnecessary cast.
9379         * tui/tui-source.c (tui_set_source_content)
9380         (tui_vertical_source_scroll): Remove unnecessary cast.
9381         * tui/tui-layout.c (tui_default_win_height): Remove unnecessary
9382         cast.
9383         * tui/tui-io.c (tui_initialize_io): Remove unnecessary cast.
9384         * tui/tui-regs.c (tui_display_registers_from)
9385         (tui_display_register): Remove unnecessary cast.
9386         * tui/tui-wingeneral.c (tui_refresh_win, tui_delete_win)
9387         (tui_unhighlight_win, tui_highlight_win, tui_make_window)
9388         (make_visible): Remove unnecessary cast.
9389         * tui/tui-winsource.c (tui_erase_source_content)
9390         (tui_update_breakpoint_info, tui_set_exec_info_content): Remove
9391         unnecessary cast.
9392         * ax-gdb.c (agent_command_1): Remove unnecessary cast.
9393         * cli/cli-setshow.c (cmd_show_list): Remove unnecessary cast.
9394         * stabsread.c (read_type, read_array_type, read_range_type):
9395         Remove unnecessary cast.
9396         * mdebugread.c (mdebug_build_psymtabs): Remove unnecessary cast.
9397         (parse_symbol, parse_type, upgrade_type, parse_external)
9398         (parse_partial_symbols, psymtab_to_symtab_1, cross_ref): Remove
9399         unnecessary cast.
9400         * gdb_bfd.c (gdb_bfd_map_section): Remove unnecessary cast.
9401
9402 2019-06-16  Tom Tromey  <tom@tromey.com>
9403
9404         * tui/tui-data.c (tui_alloc_generic_win_info)
9405         (tui_alloc_win_info, tui_add_content_elements): Remove NULL
9406         checks.
9407
9408 2019-06-16  Bernhard Heckel  <bernhard.heckel@intel.com>
9409             Andrew Burgess  <andrew.burgess@embecosm.com>
9410
9411         * f-typeprint.c (f_print_type): Don't return early for not
9412         associated or not allocated types.
9413         (f_type_print_varspec_suffix): Add print_rank parameter and print
9414         ranks of array types in case they dangling.
9415         (f_type_print_base): Add print_rank parameter.
9416
9417 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9418
9419         * NEWS: Mention new MI commands.
9420         * break-catch-throw.c (enum exception_event_kind): Move to
9421         breakpoint.h.
9422         (print_mention_exception_catchpoint): Output text as a single
9423         message.
9424         (catch_exception_command_1): Rename to...
9425         (catch_exception_event): ...this, make non-static, update header
9426         command, and change some parameter types.
9427         (catch_catch_command): Update for changes to
9428         catch_exception_command_1.
9429         (catch_throw_command): Likewise.
9430         (catch_rethrow_command): Likewise.
9431         * breakpoint.c (enum exception_event_kind): Delete.
9432         * breakpoint.h (enum exception_event_kind): Moved here from
9433         break-catch-throw.c.
9434         (catch_exception_event): Declare.
9435         * mi/mi-cmd-catch.c (mi_cmd_catch_exception_event): New function.
9436         (mi_cmd_catch_throw): New function.
9437         (mi_cmd_catch_rethrow): New function.
9438         (mi_cmd_catch_catch): New function.
9439         * mi/mi-cmds.c (mi_cmds): Add 'catch-throw', 'catch-rethrow', and
9440         'catch-catch' entries.
9441         * mi/mi-cmds.h (mi_cmd_catch_throw): Declare.
9442         (mi_cmd_catch_rethrow): Declare.
9443         (mi_cmd_catch_catch): Declare.
9444
9445 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9446
9447         * annotate.c (annotate_source_line): Change return type to void,
9448         update implementation to match.
9449         * annotate.h (annotate_source_line): Change return type to void,
9450         update header comment.
9451         * stack.c (print_frame_info): Don't change what frame information
9452         is printed based on whether annotations are on or not.
9453
9454 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9455
9456         * annotate.c: Add 'source.h' and 'objfiles.h' includes.
9457         (annotate_source): Make static.
9458         (annotate_source_line): Moved from source.c and renamed from
9459         identify_source_line.  Update the return type.
9460         * annotate.h (annotate_source): Delete declaration.
9461         (annotate_source_line): Declaration moved from source.h, and
9462         renamed from identify_source_line.  Return type updated.
9463         * source.c (identify_source_line): Moved to annotate.c and renamed
9464         to annotate_source_line.
9465         (info_line_command): Remove check of annotation_level.
9466         * source.h (identify_source_line): Move declaration to annotate.h
9467         and rename to annotate_source_line.
9468         * stack.c: Add 'annotate.h' include.
9469         (print_frame_info): Remove check of annotation_level before
9470         calling annotate_source_line.
9471
9472 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9473
9474         * source-cache.c (source_cache::get_plain_source_lines): Use
9475         open_source_file_with_line_charpos instead of just
9476         open_source_file, remove call to find_source_lines.
9477         (source_cache::get_source_lines): Likewise.
9478         * source.c (find_source_lines): Make static.
9479         (get_filename_and_charpos): Renamed into...
9480         (open_source_file_with_line_charpos): ..this along with changes to
9481         return a scoped_fd, and some other minor clean ups.
9482         (identify_source_line): Use open_source_file_with_line_charpos.
9483         (search_command_helper): Use open_source_file_with_line_charpos
9484         instead of just open_source_file, remove call to
9485         find_source_lines.
9486         * source.h (open_source_file_with_line_charpos): Declare new
9487         function.
9488         (find_source_lines): Delete declaration.
9489
9490 2019-06-15  Andrew Burgess  <andrew.burgess@embecosm.com>
9491
9492         * source.c (get_filename_and_charpos): Remove fullname
9493         parameter.
9494         (identify_source_line): Update call to get_filename_and_charpos.
9495
9496 2019-06-14  Tom Tromey  <tromey@adacore.com>
9497
9498         PR gdb/24502:
9499         * ui-style.h (skip_ansi_escape): Update comment.
9500         * ui-file.h (class no_terminal_escape_file): New class.
9501         * ui-file.c (no_terminal_escape_file::write)
9502         (no_terminal_escape_file::puts): New methods.
9503         * cli/cli-logging.c (handle_redirections): Use
9504         no_terminal_escape_file.
9505
9506 2019-06-14  Tom Tromey  <tromey@adacore.com>
9507
9508         * NEWS: Move convenience variable news above Python news.
9509
9510 2019-06-14  Tom Tromey  <tom@tromey.com>
9511
9512         * gnulib: Move directory to top-level.
9513         * configure.ac: Don't configure gnulib.
9514         * configure: Rebuild.
9515         * common/common-defs.h: Use new path to gnulib.
9516         * Makefile.in (GNULIB_BUILDDIR): Now ../gnulib.
9517         (GNULIB_H): Remove.
9518         (INCGNU): Look in new gnulib location.
9519         (HFILES_NO_SRCDIR): Remove gnulib files.
9520         (SUBDIR, REQUIRED_SUBDIRS): Remove gnulib.
9521         (generated_files): Remove GNULIB_H.
9522         ($(LIBGNU), all-lib): Remove targets.
9523         (distclean): Don't mention GNULIB_BUILDDIR.
9524         ($(GNULIB_BUILDDIR)/Makefile): Remove target.
9525
9526 2019-06-14  Tom Tromey  <tromey@adacore.com>
9527
9528         * symfile.c (add_symbol_file_command): Remove obsolete comment.
9529         Warn if symbol file does not provide any symbols.
9530
9531 2019-06-14  Tom Tromey  <tromey@adacore.com>
9532
9533         * source.c (find_and_open_source): Respect basenames_may_differ.
9534
9535 2019-06-14  Andrew Burgess  <andrew.burgess@embecosm.com>
9536
9537         * annotate.c (annotate_breakpoints_invalid): Make use of
9538         scoped_restore_terminal_state.
9539         (annotate_frames_invalid): Likewise.
9540
9541 2019-06-14  Tom Tromey  <tromey@adacore.com>
9542
9543         * ada-lang.c (ada_evaluate_subexp) <case BINOP_ASSIGN>: Always
9544         allow assignment to an internalvar.
9545
9546 2019-06-14  Tom Tromey  <tromey@adacore.com>
9547
9548         * ada-lex.l: Allow "_" in attribute names.
9549
9550 2019-06-14  Tom Tromey  <tromey@adacore.com>
9551
9552         PR gdb/24653:
9553         * regcache.c (registers_changed): Don't call alloca.
9554         * top.c (execute_command): Don't call alloca.
9555
9556 2019-06-13  Pedro Alves  <palves@redhat.com>
9557
9558         * cli/cli-setshow.c (cli/cli-setshow.c): New parameter
9559         'expression'.  When parsing an expression, error out if there's
9560         junk after "unlimited".
9561         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9562         (do_set_command): Adjust calls to is_unlimited_literal.
9563
9564 2019-06-13  Pedro Alves  <palves@redhat.com>
9565
9566         * compile/compile.c (make_compile_options_def_group): Add braces
9567         around array_view initializer.
9568         * thread.c (make_thread_apply_all_options_def_group)
9569         (make_thread_apply_all_options_def_group): Likewise.
9570
9571 2019-06-13  Pedro Alves  <palves@redhat.com>
9572
9573         * NEWS (New commands): Mention "maint test-options
9574         require-delimiter", "maint test-options unknown-is-error", "maint
9575         test-options unknown-is-operand" and "maint show
9576         test-options-completion-result".
9577         (New command options, command completion): New section.
9578         (Completion improvements): New section.
9579         Mention that you can abbreviate "unlimited".
9580
9581 2019-06-13  Pedro Alves  <palves@redhat.com>
9582
9583         * cli/cli-utils.c (parse_flags, parse_flags_qcs): Delete.
9584         * cli/cli-utils.h (parse_flags, parse_flags_qcs): Delete.
9585         * unittests/cli-utils-selftests.c (test_parse_flags)
9586         (test_parse_flags_qcs): Delete.
9587         (test_cli_utils): Don't call deleted functions.
9588
9589 2019-06-13  Pedro Alves  <palves@redhat.com>
9590
9591         * thread.c: Include "cli/cli-option.h".
9592         (tp_array_compar_ascending): Global.
9593         (tp_array_compar): Delete function.
9594         (tp_array_compar_ascending, tp_array_compar_descending): New
9595         functions.
9596         (ascending_option_def, qcs_flag_option_def)
9597         (thr_qcs_flags_option_defs)
9598         (make_thread_apply_all_options_def_group)
9599         (make_thread_apply_options_def_group): New.
9600         (thread_apply_all_command): Use gdb::option::process_options.
9601         (thread_apply_command_completer)
9602         (thread_apply_all_command_completer): New.
9603         (thread_apply_command): Use gdb::option::process_options.
9604         (_initialize_thread): Delete THREAD_APPLY_FLAGS_HELP, replace it
9605         with a new THREAD_APPLY_OPTION_HELP.  Use gdb::option::build_help
9606         to generate help text of "thread apply".  Adjust "taas"'s help.
9607         * tid-parse.c (tid_range_parser::in_thread_range): New method.
9608         * tid-parse.h (tid_range_parser::in_thread_range): New method.
9609
9610 2019-06-13  Pedro Alves  <palves@redhat.com>
9611
9612         * thread.c (thread_apply_command): Check for invalid TID with
9613         isdigit instead of !isalpha.
9614
9615 2019-06-13  Pedro Alves  <palves@redhat.com>
9616
9617         * cli/cli-utils.c (parse_flags_qcs): Use validate_flags_qcs.
9618         (validate_flags_qcs): New.
9619         * cli/cli-utils.h (struct qcs_flags): Change field types to int.
9620         (validate_flags_qcs): Declare.
9621         * stack.c (qcs_flag_option_def, fr_qcs_flags_option_defs): New.
9622         (make_frame_apply_options_def_group): New.
9623         (frame_apply_command_count): Process options with
9624         gdb::option::process_options.
9625         (frame_apply_completer): New.
9626         (frame_apply_level_completer, frame_apply_all_completer)
9627         (frame_apply_completer): New.
9628         (_initialize_stack): Update help of "frame apply", "frame apply
9629         level", "frame apply all" and "faas" to mention supported options
9630         and install command completers.
9631         * stack.h (frame_apply_all_completer): Declare.
9632         * thread.c: Include "stack.h".
9633         (tfaas_command): Add "--".
9634         (_initialize_thread): Update help "tfaas" to mention supported
9635         options and install command completer.
9636
9637 2019-06-13  Pedro Alves  <palves@redhat.com>
9638
9639         * completer.c (complete_nested_command_line): New.
9640         (gdb_completion_word_break_characters_throw): Add assertion.
9641         * completer.h (complete_nested_command_line): Declare.
9642
9643 2019-06-13  Pedro Alves  <palves@redhat.com>
9644
9645         * stack.c (parse_backtrace_qualifiers): New.
9646         (backtrace_command): Use it.
9647         (backtrace_command_completer): Complete on qualifiers.
9648
9649 2019-06-13  Pedro Alves  <palves@redhat.com>
9650
9651         * frame.c: Include "cli/cli-option.h.
9652         (user_set_backtrace_options): New.
9653         (backtrace_past_main, backtrace_past_entry, backtrace_limit):
9654         Delete.
9655         (get_prev_frame): Adjust.
9656         (boolean_option_def, uinteger_option_def)
9657         (set_backtrace_option_defs): New.
9658         (_initialize_frame): Adjust and use
9659         gdb::option::add_setshow_cmds_for_options to install "set
9660         backtrace past-main" and "set backtrace past-entry".
9661         * frame.h: Include "cli/cli-option.h".
9662         (struct frame_print_options): Forward declare.
9663         (print_frame_arguments_all, print_frame_arguments_scalars)
9664         (print_frame_arguments_none): Declare.
9665         (print_entry_values): Delete declaration.
9666         (struct frame_print_options, user_frame_print_options): New.
9667         (struct set_backtrace_options): New.
9668         (set_backtrace_option_defs, user_set_backtrace_options): Declare.
9669         * mi/mi-cmd-stack.c (mi_cmd_stack_list_frames)
9670         (mi_cmd_stack_list_locals, mi_cmd_stack_list_args)
9671         (mi_cmd_stack_list_variables): Pass down USER_FRAME_PRINT_OPTIONS.
9672         (list_args_or_locals): Add frame_print_options parameter.
9673         (mi_cmd_stack_info_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9674         * python/py-framefilter.c (enumerate_args): Pass down
9675         USER_FRAME_PRINT_OPTIONS.
9676         * stack.c: Include "cli/cli-option.h".
9677         (print_frame_arguments_all, print_frame_arguments_scalars)
9678         (print_frame_arguments_none): Declare.
9679         (print_raw_frame_arguments, print_entry_values): Delete.
9680         (user_frame_print_options): New.
9681         (boolean_option_def, enum_option_def, frame_print_option_defs):
9682         New.
9683         (struct backtrace_cmd_options): New.
9684         (bt_flag_option_def): New.
9685         (backtrace_command_option_defs): New.
9686         (print_stack_frame): Pass down USER_FRAME_PRINT_OPTIONS.
9687         (print_frame_arg, read_frame_arg, print_frame_args)
9688         (print_frame_info, print_frame): Add frame_print_options parameter
9689         and use it.
9690         (info_frame_command_core): Pass down USER_FRAME_PRINT_OPTIONS.
9691         (backtrace_command_1): Add frame_print_options and
9692         backtrace_cmd_options parameters and use them.
9693         (make_backtrace_options_def_group): New.
9694         (backtrace_command): Process command options with
9695         gdb::option::process_options.
9696         (backtrace_command_completer): New.
9697         (_initialize_stack): Extend "backtrace"'s help to mention
9698         supported options.  Install completer for "backtrace".
9699         Install some settings commands with add_setshow_cmds_for_options.
9700
9701 2019-06-13  Pedro Alves  <palves@redhat.com>
9702
9703         * NEWS (Changed commands): Mention set/show print raw-frame-arguments,
9704         and that "set/show print raw frame-arguments" are now deprecated.
9705
9706         * cli/cli-decode.c (add_setshow_boolean_cmd): Now returns the
9707         command.
9708         * command.h (add_setshow_boolean_cmd): Return cmd_list_element *.
9709         * stack.c (_initialize_stack): Install "set/show print
9710         raw-frame-arguments", and deprecate "set/show print raw
9711         frame-arguments".
9712         * valprint.c (_initialize_valprint): Deprecate "set/show print
9713         raw".
9714
9715 2019-06-13  Pedro Alves  <palves@redhat.com>
9716
9717         * compile/compile.c (struct compile_options): New.
9718         (compile_flag_option_def, compile_command_option_defs)
9719         (make_compile_options_def_group): New.
9720         (compile_file_command): Handle options with
9721         gdb::option::process_options.
9722         (compile_file_command_completer): New function.
9723         (compile_code_command): Handle options with
9724         gdb::option::process_options.
9725         (compile_code_command_completer): New function.
9726         (_initialize_compiler): Install completers for "compile code" and
9727         "compile file".  Mention available options in "compile code" and
9728         "compile code"'s help.
9729         * completer.c (advance_to_completion_word): New, factored out from
9730         ...
9731         (advance_to_expression_complete_word_point): ... this.
9732         (advance_to_filename_complete_word_point): New.
9733         * completer.h (advance_to_filename_complete_word_point): New
9734         declaration.
9735
9736 2019-06-13  Pedro Alves  <palves@redhat.com>
9737
9738         * compile/compile.c: Include "cli/cli-option.h".
9739         (compile_print_value): Scope data pointer is now a
9740         value_print_options pointer; adjust.
9741         (compile_print_command): Process options.  Scope data pointer is
9742         now a value_print_options pointer; adjust.
9743         (_initialize_compile): Update "compile print"'s help to include
9744         supported options.  Install a completer for "compile print".
9745         * cp-valprint.c (show_vtblprint, show_objectprint)
9746         (show_static_field_print): Delete.
9747         (_initialize_cp_valprint): Don't install "set print
9748         static-members", "set print vtbl", "set print object" here.
9749         * printcmd.c: Include "cli/cli-option.h" and
9750         "common/gdb_optional.h".
9751         (print_command_parse_format): Rework to fill in a
9752         value_print_options instead of a format_data.
9753         (print_value): Change parameter type from format_data pointer to
9754         value_print_options reference.  Adjust.
9755         (print_command_1): Process options.  Adjust to pass down a
9756         value_print_options.
9757         (print_command_completer): New.
9758         (_initialize_printcmd): Install print_command_completer as
9759         handle_brkchars completer for the "print" command.  Update
9760         "print"'s help to include supported options.
9761         * valprint.c: Include "cli/cli-option.h".
9762         (show_vtblprint, show_objectprint, show_static_field_print): Moved
9763         here from cp-valprint.c.
9764         (boolean_option_def, uinteger_option_def)
9765         (value_print_option_defs, make_value_print_options_def_group):
9766         New.  Use gdb::option::add_setshow_cmds_for_options to install
9767         "set print elements", "set print null-stop", "set print repeats",
9768         "set print pretty", "set print union", "set print array", "set
9769         print address", "set print symbol", "set print array-indexes".
9770         * valprint.h: Include <string> and "cli/cli-option.h".
9771         (make_value_print_options_def_group): Declare.
9772         (print_value): Change parameter type from format_data pointer to
9773         value_print_options reference.
9774         (print_command_completer): Declare.
9775
9776 2019-06-13  Pedro Alves  <palves@redhat.com>
9777
9778         * Makefile.in (SUBDIR_CLI_SRCS): Add cli/cli-option.c.
9779         (COMMON_SFILES): Add maint-test-settings.c.
9780         * cli/cli-decode.c (boolean_enums): New global, factored out from
9781         ...
9782         (add_setshow_boolean_cmd): ... here.
9783         * cli/cli-decode.h (boolean_enums): Declare.
9784         * cli/cli-option.c: New file.
9785         * cli/cli-option.h: New file.
9786         * cli/cli-setshow.c (parse_cli_boolean_value(const char **)): New,
9787         factored out from ...
9788         (parse_cli_boolean_value(const char *)): ... this.
9789         (is_unlimited_literal): Change parameter type to pointer to
9790         pointer.  Adjust and advance ARG pointer.
9791         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9792         (parse_cli_var_enum): New, factored out from ...
9793         (do_set_command): ... this.  Adjust.
9794         * cli/cli-setshow.h (parse_cli_boolean_value)
9795         (parse_cli_var_uinteger, parse_cli_var_zuinteger_unlimited)
9796         (parse_cli_var_enum): Declare.
9797         * cli/cli-utils.c: Include "cli/cli-option.h".
9798         (get_ulongest): New.
9799         * cli/cli-utils.h (get_ulongest): Declare.
9800         (check_for_argument): New overloads.
9801         * maint-test-options.c: New file.
9802
9803 2019-06-13  Pedro Alves  <palves@redhat.com>
9804
9805         * cli/cli-utils.c (number_or_range_parser::get_number): Do not
9806         parse a range if "-" is at the end of the string.
9807
9808 2019-06-13  Pedro Alves  <palves@redhat.com>
9809
9810         * cli/cli-setshow.c (parse_auto_binary_operation)
9811         (parse_cli_boolean_value): Don't allow "o".
9812
9813 2019-06-13  Pedro Alves  <palves@redhat.com>
9814
9815         * Makefile.in (COMMON_SFILES): Add maint-test-settings.c.
9816         * NEWS: Mention maint test-settings KIND.
9817         * maint-test-settings.c: New file.
9818
9819 2019-06-13  Pedro Alves  <palves@redhat.com>
9820
9821         * cli/cli-decode.c (add_setshow_cmd_full): Remove "show"
9822         completer.
9823         (add_setshow_string_cmd, add_setshow_string_noescape_cmd): Remove
9824         "set" completers.
9825
9826 2019-06-13  Pedro Alves  <palves@redhat.com>
9827
9828         * cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
9829         after item.
9830
9831 2019-06-13  Pedro Alves  <palves@redhat.com>
9832
9833         * cli/cli-setshow.c (is_unlimited_literal): Allow abbreviations.
9834
9835 2019-06-13  Pedro Alves <palves@redhat.com>
9836
9837         * ax-gdb.c (agent_command_1): Remove skip_spaces call.
9838         * breakpoint.c (watch_maybe_just_location): Remove skip_spaces
9839         call.
9840         * cli/cli-cmds.c (apropos_command): Remove skip_spaces call.
9841         * cli/cli-utils.c (extract_info_print_args): Remove skip_spaces
9842         calls.
9843         (check_for_argument): Skip spaces after argument.
9844
9845 2019-06-13  Pedro Alves  <palves@redhat.com>
9846
9847         * thread.c (thread_apply_command): Adjust TID parsing.
9848         * tid-parse.c (tid_range_parser::finished): Ensure parsing end is
9849         detected before end of string.
9850         (tid_is_in_list): Error out if LIST is invalid.
9851
9852 2019-06-13  Pedro Alves  <palves@redhat.com>
9853
9854         * completer.c (complete_line_internal_1): Rewind completion word
9855         point.
9856         (completion_tracker::advance_custom_word_point_by): Change
9857         parameter type to int.
9858         * completer.h (completion_tracker::advance_custom_word_point_by):
9859         Likewise.
9860
9861 2019-06-13  Pedro Alves  <palves@redhat.com>
9862
9863         * completer.c (advance_to_completion_word): Handle delimiters.
9864
9865 2019-06-11  Bernhard Heckel  <bernhard.heckel@intel.com>
9866
9867         * dwarf2read.c (add_partial_symbol): Skip nameless modules.
9868
9869 2019-06-11  Tom Tromey  <tom@tromey.com>
9870
9871         * common/common-utils.c (xmalloc, xrealloc, xcalloc)
9872         (xmalloc_failed): Move to alloc.c.
9873         * alloc.c: New file.
9874         * Makefile.in (COMMON_SFILES): Add alloc.c.
9875
9876 2019-06-11  Tom Tromey  <tom@tromey.com>
9877
9878         * nat/linux-waitpid.c: Don't include server.h.
9879         (linux_debug): Remove.
9880         (my_waitpid): Update.
9881
9882 2019-06-11  Tom Tromey  <tromey@adacore.com>
9883
9884         * infcall.c (_initialize_infcall): Remove trailing newline from
9885         help.
9886         * user-regs.c (_initialize_user_regs): Remove trailing newline
9887         from help.
9888         * typeprint.c (_initialize_typeprint): Remove trailing newline
9889         from help.
9890         * reverse.c (_initialize_reverse): Remove trailing newlines from
9891         help.
9892         * tracepoint.c (_initialize_tracepoint): Remove trailing newlines
9893         from help.
9894         * language.c (add_set_language_command): Remove trailing newline
9895         from help.
9896         * infcmd.c (_initialize_infcmd): Remove trailing newlines from
9897         help.
9898         * disasm.c (_initialize_disasm): Remove trailing newline from
9899         help.
9900         * top.c (init_main): Remove trailing newline from help.
9901         * interps.c (_initialize_interpreter): Remove trailing newline
9902         from help.
9903         * btrace.c (_initialize_btrace): Remove trailing newlines from
9904         help.
9905         * breakpoint.c (_initialize_breakpoint): Remove trailing newline
9906         from help.
9907         * python/python.c (_initialize_python): Remove trailing newline
9908         from help.
9909         * spu-tdep.c (_initialize_spu_tdep): Remove trailing newlines from
9910         help.
9911         * tui/tui-win.c (_initialize_tui_win): Remove trailing newlines
9912         from help.  Reformat some text.
9913         * tui/tui-stack.c (_initialize_tui_stack): Remove trailing newline
9914         from help.
9915         * tui/tui-layout.c (_initialize_tui_layout): Remove trailing
9916         newline from help.
9917
9918 2019-06-11  Tom Tromey  <tromey@adacore.com>
9919
9920         * darwin-nat.c (darwin_decode_exception_message)
9921         (darwin_decode_message, darwin_nat_target::kill): Fix shadowing.
9922
9923 2019-06-10  Andrew Burgess  <andrew.burgess@embecosm.com>
9924
9925         * valops.c (value_slice): Check for not allocated or not
9926         associated values.
9927
9928 2019-06-10  Tom de Vries  <tdevries@suse.de>
9929
9930         PR gdb/24618
9931         * dwarf2read.c (struct mapped_index::symbol_name_slot_invalid): Make
9932         sure an empty slot (defined by a 32-bit zero pair) is recognized as
9933         invalid.
9934
9935 2019-06-10  Tom de Vries  <tdevries@suse.de>
9936
9937         PR gdb/24611
9938         * linespec.c (linespec_lexer_lex_string): Remove incorrect
9939         "++(PARSER_STREAM (parser))" for "[abi"-prefixed colon.  Add assert.
9940
9941 2019-06-10  Tom de Vries  <tdevries@suse.de>
9942
9943         PR symtab/24545
9944         * symtab.c (struct demangled_name_entry): Add language field.
9945         (symbol_set_names):  Revert "[gdb/symtab] Fix language of duplicate
9946         static minimal symbol".  Set and use language field.
9947
9948 2019-06-10  Tom Tromey  <tromey@adacore.com>
9949
9950         * ada-lang.c (_initialize_ada_language): Update help text.
9951
9952 2019-06-10  Tom Tromey  <tromey@adacore.com>
9953
9954         * m32c-tdep.c (m32c_m16c_address_to_pointer): Don't end warning
9955         with a newline.
9956         * guile/guile.c (handle_boot_error): Don't end warning with a
9957         newline.
9958         * cli/cli-cmds.c (exit_status_set_internal_vars): Don't end
9959         warning with a newline.
9960         * s12z-tdep.c (s12z_skip_prologue): Don't end warning with a
9961         newline.
9962         (s12z_frame_cache): Likewise.
9963         * dwarf-index-cache.c (index_cache::store): Don't end warning with
9964         a newline.
9965         * solib-svr4.c (disable_probes_interface): Don't end warning with
9966         a newline.
9967         * nat/fork-inferior.c (fork_inferior): Don't end warning with a
9968         newline.
9969         * python/python.c (do_finish_initialization): Don't end warning
9970         with a newline.
9971
9972 2019-06-10  Tom Tromey  <tom@tromey.com>
9973
9974         * python/py-breakpoint.c (gdbpy_breakpoint_created)
9975         (gdbpy_breakpoint_deleted, gdbpy_breakpoint_modified): Use
9976         gdbpy_enter.
9977
9978 2019-06-10  Tom Tromey  <tromey@adacore.com>
9979
9980         * elfread.c (elf_read_minimal_symbols): Don't set the dbx objfile
9981         data.
9982         (elf_new_init): Don't call stabsread_new_init.
9983         * dbxread.c (coffstab_build_psymtabs): Set dbx objfile data.
9984         (elfstab_build_psymtabs): Likewise.  Call stabsread_new_init.
9985         * coffread.c (coff_symfile_init): Don't set the dbx objfile data.
9986
9987 2019-06-10  Tom de Vries  <tdevries@suse.de>
9988
9989         PR symtab/16264
9990         PR symtab/24517
9991         * dwarf2read.c (read_func_scope): Handle DW_AT_main_subprogram.
9992
9993 2019-06-06  Руслан Ижбулатов <lrn1986@gmail.com>
9994
9995         * source.c (find_and_open_source): Also rewrite relative file
9996         names.
9997
9998 2019-04-26  Amos Bird  <amosbird@gmail.com>
9999
10000         * annotate.c (annotate_thread_exited): Add "thread-exited"
10001         annotation.
10002
10003 2019-06-06  Tom Tromey  <tromey@adacore.com>
10004
10005         * maint.h (class scoped_command_stats): Use
10006         DISABLE_COPY_AND_ASSIGN.
10007         <print_time>: New method.
10008         * maint.c (scoped_command_stats, ~scoped_command_stats): Call
10009         print_time.
10010         (scoped_command_stats::print_time): New method.
10011
10012 2019-06-05  Andrew Burgess  <andrew.burgess@embecosm.com>
10013
10014         * riscv-tdep.c (riscv_insn::decode): Gracefully ignore
10015         instructions of lengths 6 or 8 bytes.
10016
10017 2019-06-04  Pedro Alves  <palves@redhat.com>
10018
10019         * common/gdb_unique_ptr.h (make_unique_xstrdup): New.
10020
10021         * ada-lang.c (catch_ada_completer): Use make_unique_xstrdup.
10022         * breakpoint.c (condition_completer): Likewise.
10023         * cli/cli-dump.c (scan_expression): Likewise.
10024         * common/filestuff.c (mkdir_recursive): Likewise.
10025         * common/gdb_tilde_expand.c (gdb_tilde_expand_up)
10026         * common/pathstuff.c (gdb_realpath, gdb_realpath_keepfile)
10027         (gdb_abspath): Likewise.
10028         * compile/compile-cplus-types.c
10029         (compile_cplus_instance::decl_name): Likewise.
10030         * completer.c (complete_explicit_location):
10031         (signal_completer, reg_or_group_completer_1): Likewise.
10032         * cp-support.c (cp_remove_params_if_any): Likewise.
10033         * fbsd-tdep.c (fbsd_core_vnode_path): Likewise.
10034         * guile/scm-safe-call.c (gdbscm_safe_eval_string): Likewise.
10035         * infcmd.c (strip_bg_char): Likewise.
10036         * linespec.c (copy_token_string): Likewise.
10037         * mi/mi-main.c (output_cores): Likewise.
10038         * psymtab.c (psymtab_search_name):
10039         * symfile.c (test_set_ext_lang_command): Likewise.
10040         * target.c (target_fileio_read_stralloc): Likewise.
10041         * tui/tui-regs.c (tui_reggroup_completer): Likewise.
10042         * value.c (complete_internalvar): Likewise.
10043
10044 2019-06-04  Christian Biesinger  <cbiesinger@google.com>
10045
10046         Add objfile property to gdb.Type.
10047         * NEWS: Mention Python API addition.
10048         * python/py-type.c (typy_get_objfile): New method.
10049
10050 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10051
10052         * NEWS: Mention the new set|show style [title|highlight].
10053         Mention changes to "show style", "help" and "apropos".
10054
10055 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10056
10057         * cli/cli-decode.h (apropos_cmd): Add verbose argument.
10058         * cli/cli-decode.c (apropos_cmd): Likewise.  Use print_doc_of_command
10059         instead of print_help_for_command.
10060         (print_doc_of_command): New function.
10061         (help_list): Add 'apropos -v word' suggestion.
10062         (print_help_for_command): Style the command name using title style.
10063         * cli/cli-cmds.c (apropos_command): Parse optional -v flag.
10064         (_initialize_cli_cmds): Describe -v in apropos_command help.
10065
10066 2019-06-03  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10067
10068         * cli/cli-style.h (cli_style_option): Add name in constructor,
10069         add m_name class member, add constructor with intensity,
10070         add name class function.
10071         (cli_style_option::add_setshow_commands): Remove name argument.
10072         (highlight_style, title_style): New styles.
10073         * cli/cli-style.c (do_show): New function that shows a style
10074         characteristic styling the style name with itself.
10075         (set_style_name): New function.
10076         (STYLE_ADD_SETSHOW_COMMANDS): Remove NAME arguments.
10077         Update all callers according to the changes in cli/cli-style.h.
10078         * utils.h (fputs_highlighted): New function.
10079         * utils.c (fputs_highlighted): Likewise.
10080
10081 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10082
10083         * NEWS: Mention new pipe command and new convenience variables.
10084
10085 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10086
10087         * cli/cli-cmds.c (pipe_command): New function.
10088         (_initialize_cli_cmds): Call add_com for pipe_command.
10089         Define | as an alias for pipe.
10090         (exit_status_set_internal_vars): New function.
10091         (shell_escape): Call exit_status_set_internal_vars.
10092         cli/cli-decode.c (find_command_name_length): Recognize | as
10093         a single character command.
10094
10095 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10096
10097         * gdbcmd.h (execute_command_to_ui_file): New declaration.
10098         top.c (execute_command_to_ui_file): New function, mostly a copy
10099         of execute_command_to_string.
10100         (execute_command_to_string): Implement by calling
10101         execute_command_to_ui_file.
10102
10103 2019-05-31  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10104
10105         * top.h (saved_command_line): Remove declaration.
10106         * top.c (previous_saved_command_line, previous_repeat_arguments):
10107         New variables.
10108         (saved_command_line): Make static, define together with other
10109         'repeat variables'.
10110         (dont_repeat): Clear repeat_arguments.
10111         (repeat_previous, get_saved_command_line, save_command_line):
10112         New functions.
10113         (gdb_init): Initialize saved_command_line
10114         and previous_saved_command_line.
10115         * main.c (captured_main_1): Remove saved_command_line initialization.
10116         * event-top.c (handle_line_of_input): Update to use
10117         the new 'repeat' related functions instead of direct access to
10118         saved_command_line.
10119         * command.h (repeat_previous, get_saved_command_line,
10120         save_command_line): New declarations.
10121         (dont_repeat): Add comment.
10122
10123 2019-05-30  Tom Tromey  <tromey@adacore.com>
10124
10125         * gdbtypes.h (struct range_bounds) <flag_upper_bound_is_count>:
10126         Fix comment.
10127         (TYPE_ARRAY_UPPER_BOUND_IS_UNDEFINED): Rewrite comment.
10128
10129 2019-05-30  Jan Vrany  <jan.vrany@fit.cvut.cz>
10130
10131         PR cli/24587
10132         * completer.c (complete): Initialize variable word.
10133
10134 2019-05-29  Sergio Durigan Junior  <sergiodj@redhat.com>
10135
10136         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10137         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1715008
10138         * dwarf2read.c (dwarf_decode_macro_bytes): Move check to see if
10139         'body' is NULL to the outter 'if', protecting the '!is_define'
10140         situation as well.
10141
10142 2019-05-29  Tom Tromey  <tromey@adacore.com>
10143
10144         * dwarf2read.c (partial_die_parent_scope): Call dwarf_tag_name.
10145         (dwarf_unknown): New function.
10146         (dwarf_tag_name, dwarf_attr_name, dwarf_form_name)
10147         (dwarf_type_encoding_name): Use dwarf_unknown.
10148
10149 2019-05-29  Tom Tromey  <tromey@adacore.com>
10150
10151         PR c++/20020:
10152         * cp-valprint.c (cp_print_value_fields): Call
10153         cp_print_static_field inside "try".
10154
10155 2019-05-29  Tom Tromey  <tromey@adacore.com>
10156
10157         * inflow.c (struct terminal_info): Add default operator=.
10158         * configure: Rebuild.
10159         * warning.m4 (AM_GDB_WARNINGS): Add -Wdeprecated-copy,
10160         -Wdeprecated-copy-dtor, -Wredundant-move.
10161
10162 2019-05-29  Tom Tromey  <tromey@adacore.com>
10163
10164         * NEWS: Add entry.
10165         * infcmd.c (print_return_value_1): Handle finish_print
10166         option.
10167         (show_print_finish): New function.
10168         (_initialize_infcmd): Add "set/show print finish" commands.
10169         * valprint.c (user_print_options): Initialize new member.
10170         * valprint.h (struct value_print_options) <finish_print>: New
10171         member.
10172
10173 2019-05-28  Tom Tromey  <tromey@adacore.com>
10174
10175         * ada-lang.c (ada_remove_Xbn_suffix)
10176         (find_old_style_renaming_symbol)
10177         (parse_old_style_renaming): Remove.
10178         (ada_find_renaming_symbol): Don't call
10179         find_old_style_renaming_symbol.
10180         (ada_is_renaming_symbol): Rename from
10181         ada_find_renaming_symbol.  Remove "block" parameter.  Return
10182         bool.  Now static.
10183         (ada_read_var_value): Update and simplify.
10184         * ada-exp.y (write_var_or_type): Remove old code.
10185
10186 2019-05-28  Alan Hayward  <alan.hayward@arm.com>
10187
10188         PR gdb/25010
10189         * event-top.c: Remove include comment.
10190         * inflow.c (class scoped_ignore_sigttou): Move from here...
10191         * inflow.h (class scoped_ignore_sigttou): ...to here.
10192         * ser-unix.c (hardwire_drain_output): Block SIGTTOU during drain.
10193         * top.c:  Remove include comment.
10194
10195 2019-05-27  Tom Tromey  <tom@tromey.com>
10196
10197         * NEWS: Fix typo.
10198
10199 2019-05-22  Tom Tromey  <tromey@adacore.com>
10200
10201         * target.c (target_follow_exec): Constify parameter.
10202         * target-delegates.c: Rebuild.
10203         * remote.c (remote_target::follow_exec): Constify parameter.
10204         * infrun.c (follow_exec): Constify parameter.
10205         * target.h (struct target_ops) <follow_exec>: Constify parameter.
10206         (target_follow_exec): Likewise.
10207
10208 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10209
10210         * aarch64-tdep.c (aarch64_execute_dwarf_cfa_vendor_op): Treat
10211         DW_CFA_AARCH64_negate_ra_state as nop on non pauth targets.
10212
10213 2019-05-22  Alan Hayward  <alan.hayward@arm.com>
10214
10215         * NEWS: Add debugredirect and testsuite sections.
10216
10217 2019-05-22  Simon Cook  <simon.cook@embecosm.com>
10218
10219         * riscv-tdep.c (riscv_gdbarch_init): Support determining flen from
10220         target descriptions using exclusively floating point register name
10221         aliases.
10222
10223 2019-05-21  Andrew Burgess  <andrew.burgess@embecosm.com>
10224
10225         PR gdb/18644:
10226         * f-lang.c (build_fortran_types): Handle the case where
10227         gdbarch_floatformat_for_type returns a nullptr.
10228
10229 2019-05-21  Tom de Vries  <tdevries@suse.de>
10230
10231         PR cli/24587
10232         * cli/cli-cmds.c (complete_command): Fix use of unitialized variable.
10233
10234 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10235
10236         PR gdb/18644:
10237         * f-lang.c (build_fortran_types): Use floatformats_ia64_quad for
10238         16-byte floats.
10239         * i386-tdep.c (i386_floatformat_for_type): Use
10240         floatformats_ia64_quad for the 16-byte floating point component
10241         within a fortran 32-byte complex number.
10242
10243 2019-05-18  Andrew Burgess  <andrew.burgess@embecosm.com>
10244
10245         * dwarf2read.c (struct cu_partial_die_info): Add constructor,
10246         delete default constructor.
10247         (find_partial_die): Update to return const struct.
10248         (partial_die_parent_scope): Move variable declaration into scope
10249         of its use and change its type to auto.
10250         (guess_partial_die_structure_name): Likewise.
10251         (partial_die_info::fixup): Likewise.
10252
10253 2019-05-17  Tom Tromey  <tromey@adacore.com>
10254
10255         * source.c (find_and_open_source): Remove cast.
10256
10257 2019-05-17  Tom Tromey  <tromey@adacore.com>
10258
10259         * annotate.c (annotate_source): Make "filename" const.
10260         * annotate.h (annotate_source): Use const.
10261
10262 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10263
10264         * disasm.c (set_disassembler_options): Send errors to stderr.
10265
10266 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10267
10268         * cli/cli-interp.c (struct saved_output_files): Add saved entry.
10269         (cli_interp_base::set_logging): Check debug_redirect.
10270         * cli/cli-interp.h (set_logging): Add debug_redirect parameter.
10271         * cli/cli-logging.c (debug_redirect): Add static variable.
10272         (pop_output_files): Add default param.
10273         (handle_redirections): Print debug setting.
10274         (show_logging_command): Likewise.
10275         (_initialize_cli_logging): Add debugredirect command.
10276         * interps.c (current_interp_set_logging): Add debug_redirect
10277         parameter.
10278         * interps.h (set_logging): Add debug_redirect parameter.
10279         (current_interp_set_logging): Likewise.
10280         * mi/mi-common.h: Likewise.
10281         * mi/mi-interp.c (mi_interp::set_logging): Likewise.
10282
10283 2019-05-17  Alan Hayward  <alan.hayward@arm.com>
10284             Tom Tromey  <tromey@adacore.com>
10285
10286         * cli/cli-interp.c (cli_interp_base::set_logging): Create tee_file
10287         directly.
10288         * cli/cli-interp.h (make_logging_output): Remove declaration.
10289         * cli/cli-logging.c (make_logging_output): Remove function.
10290         * mi/mi-interp.c (mi_interp::set_logging): Create tee_file
10291         directly.
10292         * ui-file.c (tee_file::tee_file): Remove bools.
10293         (tee_file::~tee_file): Remove deletes.
10294         * ui-file.h (tee_file): Remove bools.
10295
10296 2019-01-28  Jan Vrany  <jan.vrany@fit.cvut.cz>
10297
10298         * mi/mi-cmds.h (mi_cmd_complete): New function.
10299         * mi/mi-main.c (mi_cmd_complete): Likewise.
10300         * mi/mi-cmds.c: Define new MI command -complete.
10301         * NEWS: Mention new -complete command.
10302
10303 2019-01-24  Jan Vrany  <jan.vrany@fit.cvut.cz>
10304
10305         * completer.h (complete): New function.
10306         * completer.c (complete): Likewise.
10307         * cli/cli-cmds.c: (complete_command): Update to use new complete()
10308         function defined in completer.h.
10309
10310 2019-05-17  Jan Vrany  <jan.vrany@fit.cvut.cz>
10311
10312         * MAINTAINERS (Write After Approval): Add myself.
10313
10314 2019-05-17  Tom de Vries  <tdevries@suse.de>
10315
10316         PR gdb/24094
10317         * dwarf2read.c (struct cu_partial_die_info): New struct.
10318         (find_partial_die): Return cu_partial_die_info.
10319         (partial_die_parent_scope, guess_partial_die_structure_name)
10320         (partial_die_info::fixup): Handle new return type of find_partial_die.
10321
10322 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10323
10324         PR breakpoints/24541
10325         * stap-probe.c (stap_parse_register_operand): Make "regname" an
10326         "std::string", simplifying the algorithm.
10327
10328 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10329
10330         * stap-probe.c (handle_stap_probe): Fix complaint formatting.
10331         (stap_static_probe_ops::get_probes): Likewise.
10332
10333 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10334
10335         * stap-probe.c (stap_parse_register_operand): Make "if (*p->arg ==
10336         '-')" and "else if".
10337         (stap_parse_single_operand): Join checks for
10338         "gdbarch_stap_parse_special_token_p" and
10339         "gdbarch_stap_parse_special_token" in the same "if" statement.
10340         Invert check when verifying for operation on register
10341         displacement.
10342
10343 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10344
10345         * stap-probe.c (stap_get_opcode): Update comment.
10346         (stap_get_expected_argument_type): Likewise.
10347         (handle_stap_probe): Likewise.
10348
10349 2019-05-16  Sergio Durigan Junior  <sergiodj@redhat.com>
10350
10351         * i386-tdep.c (i386_stap_parse_special_token_triplet): Change
10352         return type to 'bool'.  Adjust comment.  Use 'bool' when
10353         appropriate.
10354         (i386_stap_parse_special_token_three_arg_disp): Likewise.
10355         * stap-probe.c (stap_parse_argument_1): Likewise.
10356         (stap_is_operator): Likewise.
10357         (stap_is_generic_prefix): Likewise.
10358         (stap_is_register_prefix): Likewise.
10359         (stap_is_register_indirection_prefix): Likewise.
10360         (stap_is_integer_prefix): Likewise.
10361         (stap_generic_check_suffix): Likewise.
10362         (stap_check_integer_suffix): Likewise.
10363         (stap_check_register_suffix): Likewise.
10364         (stap_check_register_indirection_suffix): Likewise.
10365         (stap_parse_register_operand): Likewise.
10366         (stap_parse_single_operand): Likewise.
10367         (stap_parse_argument_1): Likewise.
10368         (stap_probe::get_argument_count): Likewise.
10369         (stap_is_operator): Likewise.
10370
10371 2019-05-16  Tom Tromey  <tromey@adacore.com>
10372
10373         * darwin-nat.c (thread_info_from_private_thread_info): Add struct
10374         keyword to foreach.
10375
10376 2019-05-15  Simon Marchi  <simon.marchi@efficios.com>
10377
10378         * linux-thread-db.c (try_thread_db_load_1): Change return type
10379         to bool.
10380         (try_thread_db_load): Likewise.
10381         (try_thread_db_load_from_pdir_1): Likewise.
10382         (try_thread_db_load_from_pdir): Likewise.
10383         (try_thread_db_load_from_sdir): Likewise.
10384         (try_thread_db_load_from_dir): Likewise.
10385         (thread_db_load_search): Likewise.
10386         (has_libpthread): Likewise.
10387         (thread_db_load): Likewise.
10388
10389 2019-05-15  Sergio Durigan Junior  <sergiodj@redhat.com>
10390
10391         Ref.: https://bugzilla.redhat.com/show_bug.cgi?id=1708192
10392         * dwarf2read.c (parse_macro_definition): Check whether 'body' is
10393         NULL, and complain/return if that's the case.
10394
10395 2019-05-15  John Darrington <john@darrington.wattle.id.au>
10396
10397         * s12z-tdep.c (push_pull_get_stack_adjustment): New function.
10398         (advance, posn, abstract_read_memory): New functions.
10399         [struct mem_read_abstraction]: New struct.
10400         (s12z_frame_cache): Use opcodes API to interpret stack frame code.
10401
10402 2019-05-14  Tom Tromey  <tromey@adacore.com>
10403
10404         * ada-lang.c (coerce_unspec_val_to_type): Only set address when
10405         value is not lval_memory.
10406
10407 2019-05-14  Tom Tromey  <tromey@adacore.com>
10408
10409         * solib.c (info_sharedlibrary_command): Style the file name.
10410
10411 2019-05-14  Alan Hayward  <alan.hayward@arm.com>
10412
10413         * aarch64-tdep.c (aarch64_vnh_type): Add half view.
10414         (aarch64_vnv_type): Likewise.
10415         * target-descriptions.c (make_gdb_type): Add TDESC_TYPE_IEEE_HALF.
10416         * common/tdesc.c: Likewise.
10417         * common/tdesc.h (enum tdesc_type_kind): Likewise.
10418         * features/aarch64-fpu.c (create_feature_aarch64_fpu): Regenerate.
10419         * features/aarch64-fpu.xml: Add ieee half view.
10420         * features/aarch64-sve.c (create_feature_aarch64_fpu): Likewise.
10421         * gdbtypes.c (gdbtypes_post_init): Add builtin_half
10422         * gdbtypes.h (struct builtin_type): Likewise.
10423         (struct objfile_type): Likewise.
10424
10425 2019-05-12  Paul Naert  <paul.naert@polymtl.ca>
10426
10427         * language.c (language_sniff_from_mangled_name): Fix "langauge"
10428         typo.
10429         * location.h (string_to_event_location): Likewise.
10430
10431 2019-05-11  Joel Brobecker  <brobecker@adacore.com>
10432
10433         GDB 8.3 released.
10434
10435 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10436
10437         * breakpoint.h (fix_multi_location_breakpoint_output_globally):
10438         New variable declaration.
10439         * breakpoint.c (fix_multi_location_breakpoint_output_globally):
10440         New variable.
10441         (print_one_breakpoint): Use ui_out::test_flags and new global
10442         variable to compute use_fixed_output.
10443         * mi/mi-main.h (mi_multi_location_breakpoint_output_fixed):
10444         Remove.
10445         * mi/mi-main.c (fix_multi_location_breakpoint_output): Remove.
10446         (mi_multi_location_breakpoint_output_fixed): Remove.
10447         (mi_cmd_fix_multi_location_breakpoint_output): Adjust to set the
10448         new variable.
10449         * mi/mi-out.c (mi_ui_out::mi_ui_out): Set
10450         fix_multi_location_breakpoint_output flag if version >= 3.
10451         * ui-out.h (enum ui_out_flag)
10452         <fix_multi_location_breakpoint_output>: New enumerator.
10453
10454 2019-05-10  Simon Marchi  <simon.marchi@efficios.com>
10455
10456         * contrib/cc-with-tweaks.sh: Validate dwz's work.
10457
10458 2019-05-10  Tom Tromey  <tromey@adacore.com>
10459
10460         * ada-lang.c (catch_ada_completer): New function.
10461         (_initialize_ada_language): Use it.
10462
10463 2019-05-10  Tom Tromey  <tromey@adacore.com>
10464
10465         * thread.c (print_thread_info): Make "requested_threads" const.
10466         * gdbthread.h (print_thread_info): Make "requested_threads"
10467         const.
10468         * ada-tasks.c (print_ada_task_info): Make "taskno_str" const.
10469         * ada-lang.h (print_ada_task_info): Make "taskno_str" const.
10470
10471 2019-05-08  Tom Tromey  <tom@tromey.com>
10472
10473         * gdbtypes.c (objfile_type_data): Change type.
10474         (objfile_type, _initialize_gdbtypes): Update.
10475
10476 2019-05-08  Tom Tromey  <tom@tromey.com>
10477
10478         * dwarf2-frame.c (dwarf2_frame_objfile_data): Change type.
10479         (dwarf2_frame_find_fde, dwarf2_build_frame_info)
10480         (_initialize_dwarf2_frame): Update.
10481
10482 2019-05-08  Tom Tromey  <tom@tromey.com>
10483
10484         * objc-lang.c (objc_objfile_data): Change type.
10485         (find_methods): Update.
10486         (_initialize_objc_lang): Remove.
10487
10488 2019-05-08  Tom Tromey  <tom@tromey.com>
10489
10490         * stabsread.c (rs6000_builtin_type_data): Change type.
10491         (rs6000_builtin_type, _initialize_stabsread): Update.
10492
10493 2019-05-08  Tom Tromey  <tom@tromey.com>
10494
10495         * mips-tdep.c (mips_pdr_data): Remove.
10496         (_initialize_mips_tdep): Update.
10497
10498 2019-05-08  Tom Tromey  <tom@tromey.com>
10499
10500         * hppa-tdep.c (hppa_objfile_priv_data): Change type.
10501         (hppa_init_objfile_priv_data, read_unwind_info)
10502         (find_unwind_entry, _initialize_hppa_tdep): Update.
10503
10504 2019-05-08  Tom Tromey  <tom@tromey.com>
10505
10506         * elfread.c (elf_objfile_gnu_ifunc_cache_data): Change type.
10507         (elf_gnu_ifunc_record_cache): Update.  Don't allocate hash table
10508         on obstack.
10509         (elf_gnu_ifunc_resolve_by_cache, _initialize_elfread): Update.
10510
10511 2019-05-08  Tom Tromey  <tom@tromey.com>
10512
10513         * mdebugread.c (basic_type_data): Change type.
10514         (basic_type, _initialize_mdebugread): Update.
10515
10516 2019-05-08  Tom Tromey  <tom@tromey.com>
10517
10518         * common/gdb_unique_ptr.h (struct noop_deleter): New.
10519
10520 2019-05-08  Tom Tromey  <tom@tromey.com>
10521
10522         * nto-tdep.c (nto_inferior_data_reg): Change type.
10523         (nto_inferior_data): Update.
10524         (nto_inferior_data_cleanup, nto_new_inferior_data)
10525         (_initialize_nto_tdep): Remove.
10526         * nto-tdep.h (struct nto_inferior_data): Add initializers.
10527
10528 2019-05-08  Tom Tromey  <tom@tromey.com>
10529
10530         * ada-lang.c (struct ada_inferior_data): Add initializers.
10531         (ada_inferior_data): Change type.
10532         (ada_inferior_data_cleanup): Remove.
10533         (get_ada_inferior_data, ada_inferior_exit)
10534         (struct ada_pspace_data): Add initializers, destructor.
10535         (ada_pspace_data_handle): Change type.
10536         (get_ada_pspace_data): Update.
10537         (ada_pspace_data_cleanup): Remove.
10538
10539 2019-05-08  Tom Tromey  <tom@tromey.com>
10540
10541         * coffread.c (struct coff_symfile_info): Add initializers.
10542         (coff_objfile_data_key): Move lower.  Change type.
10543         (coff_symfile_init, coff_symfile_read, _initialize_coffread):
10544         Update.
10545         (coff_free_info): Remove.
10546
10547 2019-05-08  Tom Tromey  <tom@tromey.com>
10548
10549         * fbsd-tdep.c (struct fbsd_pspace_data): Add initializers.
10550         (fbsd_pspace_data_handle): Move lower.  Change type.
10551         (get_fbsd_pspace_data): Update.
10552         (fbsd_pspace_data_cleanup): Remove.
10553         (_initialize_fbsd_tdep): Update.
10554
10555 2019-05-08  Tom Tromey  <tom@tromey.com>
10556
10557         * ada-tasks.c (ada_tasks_pspace_data_handle): Change type.
10558         (get_ada_tasks_pspace_data): Update.
10559         (ada_tasks_pspace_data_cleanup): Remove.
10560         (_initialize_tasks): Update.
10561         (ada_tasks_inferior_data_handle): Change type.
10562         (get_ada_tasks_inferior_data): Update.
10563         (ada_tasks_inferior_data_cleanup): Remove.
10564         (struct ada_tasks_pspace_data): Add initializers.
10565
10566 2019-05-08  Tom Tromey  <tom@tromey.com>
10567
10568         * symfile.h (struct sym_probe_fns) <sym_get_probes>: Change type.
10569         * symfile-debug.c (debug_sym_get_probes): Change type.
10570         * stap-probe.c (handle_stap_probe):
10571         (stap_static_probe_ops::get_probes): Change type.
10572         * probe.h (class static_probe_ops) <get_probes>: Change type.
10573         * probe.c (class any_static_probe_ops) <get_probes>: Change type.
10574         (parse_probes_in_pspace): Update.
10575         (find_probes_in_objfile, find_probe_by_pc, collect_probes):
10576         Update.
10577         (any_static_probe_ops::get_probes): Change type.
10578         * elfread.c (elfread_data): New typedef.
10579         (probe_key): Change type.
10580         (elf_get_probes): Likewise.  Update.
10581         (probe_key_free): Remove.
10582         (_initialize_elfread): Update.
10583         * dtrace-probe.c (class dtrace_static_probe_ops) <get_probes>:
10584         Change type.
10585         (dtrace_process_dof_probe, dtrace_process_dof)
10586         (dtrace_static_probe_ops::get_probe): Change type.
10587
10588 2019-05-08  Tom Tromey  <tom@tromey.com>
10589
10590         * xcoffread.c (struct xcoff_symfile_info): Rename from
10591         coff_symfile_info.  Add initializers.
10592         (xcoff_objfile_data_key): Move lower.  Change type.
10593         (XCOFF_DATA): Rewrite.
10594         (xcoff_free_info): Remove.
10595         (xcoff_symfile_init, _initialize_xcoffread, read_xcoff_symtab)
10596         (read_symbol, read_symbol_lineno, find_linenos, init_stringtab)
10597         (xcoff_initial_scan): Update.
10598
10599 2019-05-08  Tom Tromey  <tom@tromey.com>
10600
10601         * solib-svr4.c (struct svr4_info): Add initializers and
10602         destructor.
10603         <probes_table>: Now an htab_up.
10604         (solib_svr4_pspace_data): Change type.
10605         (free_probes_table): Simplify.
10606         (~svr4_info): Rename from svr4_pspace_data_cleanup.
10607         (get_svr4_info, probes_table_htab_remove_objfile_probes)
10608         (probes_table_remove_objfile_probes, register_solib_event_probe)
10609         (solib_event_probe_at, svr4_update_solib_event_breakpoint)
10610         (_initialize_svr4_solib): Update.
10611
10612 2019-05-08  Tom Tromey  <tom@tromey.com>
10613
10614         * remote.c (remote_pspace_data): Change type.
10615         (remote_pspace_data_cleanup): Remove.
10616         (get_remote_exec_file, set_pspace_remote_exec_file)
10617         (_initialize_remote): Update.
10618
10619 2019-05-08  Tom Tromey  <tom@tromey.com>
10620
10621         * breakpoint.c (breakpoint_objfile_key): Change type.
10622         (get_breakpoint_objfile_data): Update.
10623         (free_breakpoint_objfile_data): Remove.
10624         (_initialize_breakpoint): Update.
10625
10626 2019-05-08  Tom Tromey  <tom@tromey.com>
10627
10628         * linux-tdep.c (struct linux_info): Add initializers.
10629         (linux_inferior_data): Move.  Change type.
10630         (invalidate_linux_cache_inf): Update.
10631         (linux_inferior_data_cleanup): Remove.
10632         (get_linux_inferior_data, _initialize_linux_tdep): Update.
10633
10634 2019-05-08  Tom Tromey  <tom@tromey.com>
10635
10636         * auxv.c (auxv_inferior_data): Move.  Change type.
10637         (auxv_inferior_data_cleanup): Remove.
10638         (invalidate_auxv_cache_inf): Rewrite.
10639         (get_auxv_inferior_data, _initialize_auxv): Update.
10640
10641 2019-05-08  Tom Tromey  <tom@tromey.com>
10642
10643         * symfile-debug.c (struct debug_sym_fns_data): Add initializers.
10644         (symfile_debug_objfile_data_key): Change type.
10645         (symfile_debug_installed, debug_qf_has_symbols)
10646         (debug_qf_find_last_source_symtab)
10647         (debug_qf_forget_cached_source_info)
10648         (debug_qf_map_symtabs_matching_filename, debug_qf_lookup_symbol)
10649         (debug_qf_print_stats, debug_qf_dump)
10650         (debug_qf_expand_symtabs_for_function)
10651         (debug_qf_expand_all_symtabs)
10652         (debug_qf_expand_symtabs_with_fullname)
10653         (debug_qf_map_matching_symbols)
10654         (debug_qf_expand_symtabs_matching)
10655         (debug_qf_find_pc_sect_compunit_symtab)
10656         (debug_qf_map_symbol_filenames)
10657         (debug_qf_find_compunit_symtab_by_address, debug_sym_get_probes)
10658         (debug_sym_new_init, debug_sym_init, debug_sym_read)
10659         (debug_sym_read_psymbols, debug_sym_finish, debug_sym_offsets)
10660         (debug_sym_read_linetable, debug_sym_relocate): Update.
10661         (symfile_debug_free_objfile): Remove.
10662         (install_symfile_debug_logging, _initialize_symfile_debug):
10663         Update.
10664
10665 2019-05-08  Tom Tromey  <tom@tromey.com>
10666
10667         * dwarf2read.h (struct dwarf2_per_objfile): Don't inherit from
10668         allocate_on_obstack.
10669         * dwarf2read.c (dwarf2_objfile_data_key): Change type.
10670         (get_dwarf2_per_objfile): Update.
10671         (set_dwarf2_per_objfile): Remove.
10672         (dwarf2_has_info, dwarf2_get_section_info): Update.
10673         (dwarf2_free_objfile): Remove.
10674         (_initialize_dwarf2_read): Update.
10675
10676 2019-05-08  Tom Tromey  <tom@tromey.com>
10677
10678         * auto-load.c (struct auto_load_pspace_info): Add destructor and
10679         initializers.
10680         <unsupported_script_warning_printed,
10681         script_not_found_warning_printed>: Now bool.
10682         (auto_load_pspace_data): Change type.
10683         (~auto_load_pspace_info): Rename from
10684         auto_load_pspace_data_cleanup.
10685         (get_auto_load_pspace_data, init_loaded_scripts_info)
10686         (clear_section_scripts, maybe_print_unsupported_script_warning)
10687         (maybe_print_script_not_found_warning, _initialize_auto_load):
10688         Update.
10689
10690 2019-05-08  Tom Tromey  <tom@tromey.com>
10691
10692         * objfiles.c (objfile_pspace_info): Add destructor and
10693         initializers.
10694         (objfiles_pspace_data): Change type.
10695         (~objfile_pspace_info): Rename from objfiles_pspace_data_cleanup.
10696         (get_objfile_pspace_data): Update.
10697         (objfiles_bfd_data): Change type.
10698         (get_objfile_bfd_data): Update.
10699         (objfile_bfd_data_free, _initialize_objfiles): Remove.
10700
10701 2019-05-08  Tom Tromey  <tom@tromey.com>
10702
10703         * break-catch-syscall.c (catch_syscall_inferior_data): Move.
10704         Change type.
10705         (get_catch_syscall_inferior_data): Update.
10706         (catch_syscall_inferior_data_cleanup): Remove.
10707         (_initialize_break_catch_syscall): Update.
10708
10709 2019-05-08  Tom Tromey  <tom@tromey.com>
10710
10711         * inflow.c (struct terminal_info): Add destructor and
10712         initializers.
10713         (inflow_inferior_data): Change type.
10714         (~terminal_info): Rename from inflow_inferior_data_cleanup.
10715         (get_inflow_inferior_data, inflow_inferior_exit)
10716         (swap_terminal_info, _initialize_inflow): Update.
10717
10718 2019-05-08  Tom Tromey  <tom@tromey.com>
10719
10720         * target-dcache.c (target_dcache_cleanup): Remove.
10721         (target_dcache_aspace_key): Change type.
10722         (target_dcache_init_p, target_dcache_invalidate)
10723         (target_dcache_get, target_dcache_get_or_init)
10724         (_initialize_target_dcache): Update.
10725         * dcache.h (struct dcache_deleter): New.
10726
10727 2019-05-08  Tom Tromey  <tom@tromey.com>
10728
10729         * symtab.c (struct symbol_cache): Add destructor and
10730         initializers.
10731         (symbol_cache_key): Move.  Change type.
10732         (make_symbol_cache, free_symbol_cache): Remove.
10733         (get_symbol_cache): Update.
10734         (symbol_cache_cleanup): Remove.
10735         (ALL_PSPACES, symbol_cache_flush)
10736         (maintenance_print_symbol_cache)
10737         (maintenance_print_symbol_cache_statistics, _initialize_symtab):
10738         Update.
10739
10740 2019-05-08  Tom Tromey  <tom@tromey.com>
10741
10742         * symtab.c (struct main_info): Add destructor and initializers.
10743         (main_progspace_key): Move.  Change type.
10744         (get_main_info): Update.
10745         (main_info_cleanup): Remove.
10746         (_initialize_symtab): Update.
10747
10748 2019-05-08  Tom Tromey  <tom@tromey.com>
10749
10750         * registry.h (DECLARE_REGISTRY): Define the _key class.
10751
10752 2019-05-08  Andrew Burgess  <andrew.burgess@embecosm.com>
10753
10754         * NEWS: Merge two 'New commands' sections.
10755
10756 2019-05-08  Joel Brobecker  <brobecker@adacore.com>
10757
10758         * ada-valprint.c (ada_val_print_gnat_array): Remove language
10759         parameter and use Ada language definition instead.
10760         (ada_val_print_ptr): Remove unused language parameter.
10761         (ada_val_print_num): Remove language parameter and use Ada language
10762         definition instead.
10763         (ada_val_print_enum, ada_val_print_flt): Remove unused language
10764         parameter.
10765         (ada_val_print_struct_union, ada_val_print_ref): Remove language
10766         parameter and use Ada language definition instead.
10767         (ada_val_print_1): Update all ada_val_print_xxx calls.
10768         Remove language parameter.
10769         (ada_val_print): Update ada_val_print_1 call.
10770
10771 2019-05-08  Tom Tromey  <tromey@adacore.com>
10772
10773         * remote.c (remote_hw_watchpoint_limit)
10774         (remote_hw_watchpoint_length_limit, remote_hw_breakpoint_limit):
10775         Now static.
10776
10777 2019-05-08  Tom Tromey  <tromey@adacore.com>
10778
10779         * maint.c (_initialize_maint_cmds): Move initialization code to
10780         remote.c.
10781         (watchdog, show_watchdog): Move to remote.c.
10782         * remote.c (watchdog, show_watchdog): Move from maint.c.  Make
10783         "watchdog" static.
10784         (_initialize_remote): Move initialization code from maint.c.
10785         * defs.h (watchdog): Don't declare.
10786
10787 2019-05-08  Tom Tromey  <tromey@adacore.com>
10788
10789         * tui/tui-interp.c: Include main.h.
10790         * interps.c: Include main.h.
10791         * main.h (interpreter_p): Declare.
10792         * defs.h (interpreter_p): Don't declare.
10793
10794 2019-05-08  Tom Tromey  <tromey@adacore.com>
10795
10796         * dwarf2loc.c: Include dwarf2read.h.
10797         * defs.h (read_unsigned_leb128): Don't declare.
10798         * dwarf2read.h (read_unsigned_leb128): Declare.
10799
10800 2019-05-08  Tom Tromey  <tromey@adacore.com>
10801
10802         * utils.c (fputs_maybe_filtered): Call can_emit_style_escape as a
10803         method.
10804
10805 2019-05-08  Tom Tromey  <tromey@adacore.com>
10806
10807         * utils.c (fputs_maybe_filtered): Reset style after paging, even
10808         when no wrap column is set.
10809
10810 2019-05-08  Tom Tromey  <tromey@adacore.com>
10811
10812         * c-lang.c (c_get_string): Handle non-C-style arrays.
10813
10814 2019-05-08  Tom Tromey  <tromey@adacore.com>
10815
10816         * typeprint.c (print_offset_data::update): Print the bit offset,
10817         not the number of bits remaining.
10818
10819 2019-05-08  Tom Tromey  <tromey@adacore.com>
10820
10821         * typeprint.c (print_offset_data::maybe_print_hole): Add extra
10822         padding at end of comment.
10823
10824 2019-05-08  Tom Tromey  <tromey@adacore.com>
10825
10826         * dwarf2loc.c (dwarf2_evaluate_property) <PROP_ADDR_OFFSET>:
10827         Compare main types.
10828
10829 2019-05-06  Tom Tromey  <tom@tromey.com>
10830
10831         * common/scoped_mmap.c: Include common-defs.h.
10832         * common/scoped_mmap.h: Don't include config.h.
10833
10834 2019-05-04  Tom Tromey  <tom@tromey.com>
10835
10836         * aarch64-tdep.c (stack_item_t): Remove typedef and DEF_VEC.
10837         (struct aarch64_call_info): Add initializers.
10838         <si>: Now a std::vector.
10839         (pass_on_stack, aarch64_push_dummy_call): Update.
10840
10841 2019-05-04  Simon Marchi  <simon.marchi@efficios.com>
10842             Tom Tromey  <tom@tromey.com>
10843
10844         * ppc-linux-nat.c (thread_points_p): Remove typedef and DEF_VEC.
10845         (ppc_threads): Now a std::vector.  Now static.
10846         (hwdebug_find_thread_points_by_tid)
10847         (ppc_linux_nat_target::low_new_thread, ppc_linux_thread_exit):
10848         Update.
10849
10850 2019-05-04  Tom Tromey  <tom@tromey.com>
10851
10852         * arc-tdep.c (arc_tdesc_init): Return bool.
10853
10854 2019-05-04  Tom Tromey  <tom@tromey.com>
10855
10856         * arm-linux-nat.c (arm_linux_nat_target::can_use_hw_breakpoint):
10857         Use gdb_assert_not_reached.
10858
10859 2019-05-04  Tom Tromey  <tom@tromey.com>
10860
10861         * compile/compile-cplus-types.c (compile_cplus_convert_enum): Use
10862         "false".
10863
10864 2019-05-04  Tom Tromey  <tom@tromey.com>
10865
10866         * arc-tdep.c (arc_tdesc_init): Use bool.
10867
10868 2019-05-04  Tom Tromey  <tom@tromey.com>
10869
10870         * stack.c (select_frame_for_mi): Use "false", not "FALSE".
10871
10872 2019-05-04  Tom Tromey  <tom@tromey.com>
10873
10874         * cli/cli-cmds.c (valid_command_p): Return bool.
10875
10876 2019-05-04  Tom Tromey  <tom@tromey.com>
10877
10878         * cli/cli-decode.c (valid_user_defined_cmd_name_p): Return bool.
10879         * command.h (valid_user_defined_cmd_name_p): Channge return type.
10880
10881 2019-05-04  Raul Tambre  <raul@tambre.ee>
10882
10883         * python/lib/gdb/prompt.py (_ExtendedPrompt)
10884         <before_prompt_hook, get_show_string>: Fix incorrect use of 'is'
10885         operator for comparison.
10886
10887 2019-05-04  Tom Tromey  <tom@tromey.com>
10888
10889         * psymtab.c (psymbol_name_matches, match_partial_symbol)
10890         (lookup_partial_symbol, print_partial_symbols)
10891         (recursively_search_psymtabs, sort_pst_symbols, psymbol_hash)
10892         (psymbol_compare): Update.
10893         (add_psymbol_to_bcache): Clear the entire psymbol.
10894         (maintenance_check_psymtabs): Update.
10895         * psympriv.h (struct partial_symbol): Don't derive from
10896         general_symbol_info.
10897         <obj_section, unrelocated_address, address,
10898         set_unrelocated_address>: Update.
10899         <ginfo>: New member.
10900         * dwarf-index-write.c (write_psymbols, debug_names::insert)
10901         (debug_names::write_psymbols): Update.
10902
10903 2019-05-04  Tom de Vries  <tdevries@suse.de>
10904
10905         * contrib/cc-with-tweaks.sh: Support -n arg.
10906
10907 2019-05-04  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
10908
10909         * corelow.c (core_target::detach): Ensure frame cache and
10910         register caches are cleared.
10911         inferior.c (exit_inferior_1): Likewise.
10912
10913 2019-05-03  Sandra Loosemore  <sandra@codesourcery.com>
10914             Tom Tromey  <tom@tromey.com>
10915
10916         * dictionary.c (collate_pending_symbols_by_language): Remove
10917         "struct" from foreach.
10918         * symtab.c (lookup_global_symbol_from_objfile)
10919         (lookup_symbol_in_objfile_from_linkage_name): Remove "struct" from
10920         foreach.
10921         * ser-tcp.c (net_open): Remove "struct" from foreach.
10922         * objfiles.c (objfile_relocate, objfile_rebase)
10923         (objfile_has_symbols): Remove "struct" from foreach.
10924         * minsyms.c (lookup_minimal_symbol_by_pc_section): Remove "struct"
10925         from foreach.
10926         * dwarf2read.c (handle_struct_member_die): Remove "struct" from
10927         foreach.
10928         * darwin-nat.c (thread_info_from_private_thread_info): Remove
10929         "struct" from foreach.
10930         * ada-lang.c (create_excep_cond_exprs)
10931         (ada_exception_catchpoint_cond_string): Remove "struct" from
10932         foreach.
10933
10934 2019-05-03  Tom Tromey  <tromey@adacore.com>
10935
10936         * ada-exp.y (convert_char_literal): Check suffix of each
10937         enumerator.
10938
10939 2019-05-03  Dilyan Palauzov  <dilyan.palauzov@aegee.org>
10940
10941         PR ada/21406:
10942         * ada-exp.y (yywrap): Don't define.
10943         * ada-lex.l (%option): Add noyywrap
10944         (yywrap): Remove.
10945
10946 2019-05-03  Eli Zaretskii  <eliz@gnu.org>
10947
10948         * common/common-defs.h [__MINGW32__ || __CYGWIN__]: Define
10949         _WIN32_WINNT to the XP level, unless already defined to a higher
10950         level.
10951
10952         * unittests/parse-connection-spec-selftests.c:
10953         * ser-tcp.c:
10954         * common/netstuff.c [USE_WIN32API]:  Remove the _WIN32_WINNT
10955         override.
10956
10957         * symfile.c (find_separate_debug_file): Remove colon from the
10958         drive spec of DOS/Windows file names of the target, so that the
10959         file name produced from DEBUGDIR and the target's directory will
10960         be valid on DOS/Windows systems.
10961
10962 2019-05-02  Andrew Burgess  <andrew.burgess@embecosm.com>
10963
10964         * rust-lang.c (val_print_struct): Handle printing structures
10965         containing strings.
10966
10967 2019-05-02  Tom Tromey  <tromey@adacore.com>
10968
10969         * valarith.c (_initialize_valarith): Remove.
10970
10971 2019-05-01  Tom Tromey  <tromey@adacore.com>
10972
10973         * ada-lang.c (ada_value_primitive_field): Treat more fields as
10974         bitfields.
10975
10976 2019-05-01  Tom Tromey  <tromey@adacore.com>
10977
10978         * ada-lang.c (ada_value_assign): Correctly compute starting offset
10979         for big-endian copies.
10980
10981 2019-04-30  Ali Tamur  <tamur@google.com>
10982         * gdb/dwarf2read.c (read_3_bytes): New declaration.
10983         (read_attribute_value): Added DW_FORM_strx1-4 cases.
10984         (read_3_bytes): New function.
10985
10986 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10987
10988         * windows-nat.c (main_thread_id): Delete.
10989         (handle_output_debug_string): Replace main_thread_id by
10990         current_event.dwThreadId.
10991         (fake_create_process): Likewise.
10992         (get_windows_debug_event) <CREATE_PROCESS_DEBUG_EVENT>:
10993         Do not set main_thread_id.
10994         <LOAD_DLL_DEBUG_EVENT>: Replace main_thread_id by
10995         current_event.dwThreadId.
10996         <UNLOAD_DLL_DEBUG_EVENT>: Likewise.
10997
10998 2019-04-30  Joel Brobecker  <brobecker@adacore.com>
10999
11000         * windows-nat.c (get_windows_debug_event) <EXIT_PROCESS_DEBUG_EVENT>:
11001         Use current_event.dwThreadId instead of main_thread_id.
11002
11003 2019-04-30  Tom Tromey  <tromey@adacore.com>
11004
11005         * ada-lang.c (ada_lookup_simple_minsyms): New function.
11006         (create_excep_cond_exprs): Iterate over program spaces.
11007         (ada_exception_catchpoint_cond_string): Examine all minimal
11008         symbols for exception types.
11009
11010 2019-04-30  Tom Tromey  <tromey@adacore.com>
11011
11012         PR c++/24470:
11013         * dwarf2read.c (process_structure_scope): Handle case where type
11014         has template parameters but no symbol was created.
11015
11016 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11017             Chris January  <chris.january@arm.com>
11018
11019         * f-typeprint.c (f_type_print_base): Print 'allocatable' type
11020         qualifier.
11021         * gdbtypes.h (TYPE_IS_ALLOCATABLE): Define.
11022
11023 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11024
11025         * f-typeprint.c (f_print_type): Update rules for printing
11026         whitespace.
11027         (f_type_print_varspec_suffix): Likewise.
11028
11029 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11030             Chris January  <chris.january@arm.com>
11031
11032         * f-typeprint.c (f_type_print_varspec_suffix): Handle printing
11033         function arguments.
11034
11035 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11036
11037         * f-lang.c (build_fortran_types): Change name of void type to
11038         lower case.
11039         * f-typeprint.c (f_type_print_base): Print the name of the void
11040         type, rather than a fixed string.
11041         * f-valprint.c (f_decorations): Use lower case void string.
11042
11043 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11044             Chris January  <chris.january@arm.com>
11045
11046         * dwarf2read.c (dwarf2_init_complex_target_type): Use different
11047         types for Fortran.
11048
11049 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11050             Chris January  <chris.january@arm.com>
11051             David Lecomber  <david.lecomber@arm.com>
11052
11053         * f-exp.y (BINOP_INTRINSIC): New token.
11054         (exp): New parser rule handling BINOP_INTRINSIC.
11055         (f77_keywords): Add new builtin procedures.
11056         * f-lang.c (evaluate_subexp_f): Handle BINOP_MOD, UNOP_FORTRAN_CEILING,
11057         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11058         (operator_length_f): Handle UNOP_FORTRAN_CEILING,
11059         UNOP_FORTRAN_FLOOR, BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11060         (print_unop_subexp_f): New function.
11061         (print_binop_subexp_f): New function.
11062         (print_subexp_f): Handle UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11063         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX.
11064         (dump_subexp_body_f): Likewise.
11065         (operator_check_f): Likewise.
11066         * fortran-operator.def: Add UNOP_FORTRAN_CEILING, UNOP_FORTRAN_FLOOR,
11067         BINOP_FORTRAN_MODULO, BINOP_FORTRAN_CMPLX
11068
11069 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11070
11071         * gdb/expprint.c (dump_subexp_body_standard): Remove use of
11072         UNOP_KIND.
11073         * gdb/expression.h (exp_opcode): Include 'fortran-operator.def'.
11074         * gdb/f-exp.y (exp): Rename UNOP_KIND to UNOP_FORTRAN_KIND.
11075         * gdb/f-lang.c (evaluate_subexp_f): Likewise.
11076         (operator_length_f): New fuction.
11077         (print_subexp_f): New function.
11078         (op_name_f): New function.
11079         (dump_subexp_body_f): New function.
11080         (operator_check_f): New function.
11081         (exp_descriptor_f): Replace standard expression handling functions
11082         with new functions.
11083         * gdb/fortran-operator.def: New file.
11084         * gdb/parse.c (operator_length_standard): Remove use of UNOP_KIND.
11085         * gdb/std-operator.def: Remove UNOP_KIND.
11086
11087 2019-04-30  Andrew Burgess  <andrew.burgess@embecosm.com>
11088
11089         * std-operator.def: Remove unbalanced, stray double quote
11090         character.
11091
11092 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11093             Chris January  <chris.january@arm.com>
11094             Daniel Everett  <daniel.everett@arm.com>
11095             Nick Forrington  <nick.forrington@arm.com>
11096             Richard Bunt  <richard.bunt@arm.com>
11097
11098         * cp-valprint.c (cp_print_value_fields): Allow an additional level
11099         of depth when printing anonymous structs or unions.
11100         * guile/scm-pretty-print.c (gdbscm_apply_val_pretty_printer):
11101         Don't print either the top-level value, or the children if the
11102         max-depth is exceeded.
11103         (ppscm_print_children): When printing the key of a map, allow one
11104         extra level of depth.
11105         * python/py-prettyprint.c (gdbpy_apply_val_pretty_printer): Don't
11106         print either the top-level value, or the children if the max-depth
11107         is exceeded.
11108         (print_children): When printing the key of a map, allow one extra
11109         level of depth.
11110         * python/py-value.c (valpy_format_string): Add max_depth keyword.
11111         * valprint.c: (PRINT_MAX_DEPTH_DEFAULT): Define.
11112         (user_print_options): Initialise max_depth field.
11113         (val_print_scalar_or_string_type_p): New function.
11114         (val_print): Check to see if the max depth has been reached.
11115         (val_print_check_max_depth): Define new function.
11116         (show_print_max_depth): New function.
11117         (_initialize_valprint): Add 'print max-depth' option.
11118         * valprint.h (struct value_print_options) <max_depth>: New field.
11119         (val_print_check_max_depth): Declare new function.
11120         * NEWS: Document new feature.
11121
11122 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11123
11124         * ada-lang.c (ada_language_defn): Initialise new field.
11125         * c-lang.c (c_is_string_type_p): New function.
11126         (c_language_defn): Initialise new field.
11127         (cplus_language_defn): Initialise new field.
11128         (asm_language_defn): Initialise new field.
11129         (minimal_language_defn): Initialise new field.
11130         * c-lang.h (c_is_string_type_p): Declare new function.
11131         * d-lang.c (d_language_defn): Initialise new field.
11132         * f-lang.c (f_is_string_type_p): New function.
11133         (f_language_defn): Initialise new field.
11134         * go-lang.c (go_is_string_type_p): New function.
11135         (go_language_defn): Initialise new field.
11136         * language.c (default_is_string_type_p): New function.
11137         (unknown_language_defn): Initialise new field.
11138         (auto_language_defn): Initialise new field.
11139         * language.h (struct language_defn) <la_is_string_type_p>: New
11140         member variable.
11141         (default_is_string_type_p): Declare new function.
11142         * m2-lang.c (m2_language_defn): Initialise new field.
11143         * objc-lang.c (objc_language_defn): Initialise new field.
11144         * opencl-lang.c (opencl_language_defn): Initialise new field.
11145         * p-lang.c (pascal_is_string_type_p): New function.
11146         (pascal_language_defn): Initialise new field.
11147         * rust-lang.c (rust_is_string_type_p): New function.
11148         (rust_language_defn): Initialise new field.
11149
11150 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11151
11152         * language.h (struct language_defn) <la_struct_too_deep_ellipsis>:
11153         New field.
11154         * ada-lang.c (ada_language_defn): Initialise new field.
11155         * c-lang.c (c_language_defn): Likewise.
11156         (cplus_language_defn): Likewise.
11157         (asm_language_defn): Likewise.
11158         (minimal_language_defn): Likewise.
11159         * d-lang.c (d_language_defn): Likewise.
11160         * f-lang.c (f_language_defn): Likewise.
11161         * go-lang.c (go_language_defn): Likewise.
11162         * language.c (unknown_language_defn): Likewise.
11163         (auto_language_defn): Likewise.
11164         * m2-lang.c (m2_language_defn): Likewise.
11165         * objc-lang.c (objc_language_defn): Likewise.
11166         * opencl-lang.c (opencl_language_defn): Likewise.
11167         * p-lang.c (pascal_language_defn): Likewise.
11168         * rust-lang.c (rust_language_defn): Likewise.
11169
11170 2019-04-29  Andrew Burgess  <andrew.burgess@embecosm.com>
11171
11172         * ada-lang.c (ada_is_character_type): Change return type to bool.
11173         (ada_is_string_type): Likewise.
11174         * ada-lang.h (ada_is_character_type): Update declaration
11175         (ada_is_string_type): Likewise.
11176
11177 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11178
11179         Support style in 'frame|thread apply'
11180
11181         * gdbcmd.h (execute_command_to_string): New term_out parameter.
11182         * record.c (record_start, record_stop): Update callers of
11183         execute_command_to_string with false.
11184         * guile/guile.c (gdbscm_execute_gdb_command): Likewise.
11185         * ui-file.h (class ui_file): New term_out and can_emit_style_escape
11186         methods.
11187         (class string_file): New constructor with term_out parameter.
11188         Override methods term_out and can_emit_style_escape.  New member
11189         term_out.
11190         (class stdio_file): Override can_emit_style_escape.
11191         (class tee_file): Override term_out and can_emit_style_escape.
11192         * utils.h (can_emit_style_escape): Remove.
11193         * utils.c (can_emit_style_escape): Likewise.
11194         Update all callers of can_emit_style_escape (SOMESTREAM) to
11195         SOMESTREAM->can_emit_style_escape.
11196         * source-cache.c (source_cache::get_source_lines): Likewise.
11197         * stack.c (frame_apply_command_count): Call execute_command_to_string
11198         passing the term_out characteristic of the current gdb_stdout.
11199         * thread.c (thr_try_catch_cmd): Likewise.
11200         * top.c (execute_command_to_string): pass term_out parameter
11201         to construct the string_file for the command output.
11202         * ui-file.c (term_cli_styling): New function (most code moved
11203         from utils.c can_emit_style_escape).
11204         (string_file::string_file, string_file::can_emit_style_escape,
11205         stdio_file::can_emit_style_escape, tee_file::term_out,
11206         tee_file::can_emit_style_escape): New functions.
11207
11208 2019-04-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11209
11210         * NEWS: Mention the new set|show may-call-functions.
11211         * infcall.c (may_call_functions_p): New variable.
11212         (show_may_call_functions_p): New function.
11213         (call_function_by_hand_dummy): Throws an error if not
11214         may-call-functions.
11215         (_initialize_infcall): Call add_setshow_boolean_cmd for
11216         may-call-functions.
11217
11218 2019-04-25  Keith Seitz  <keiths@redhat.com>
11219
11220         PR c++/24367
11221         * cp-support.c (inspect_type): Don't attempt substitutions
11222         of symbol with the same name.
11223
11224 2019-04-25  Tom Tromey  <tromey@adacore.com>
11225
11226         PR gdb/24475:
11227         * event-top.c (gdb_rl_callback_handler): Make "gdb_rl_expt"
11228         static.
11229
11230 2019-04-25  Tom Tromey  <tromey@adacore.com>
11231
11232         * xml-support.c (struct gdb_xml_parser) <set_error>: Take an
11233         rvalue reference.
11234         (gdb_xml_start_element_wrapper, gdb_xml_end_element_wrapper)
11235         (gdb_xml_parser::parse): Use std::move.
11236         * python/python-internal.h (gdbpy_convert_exception): Take a const
11237         reference.
11238         * python/py-value.c (valpy_getitem, valpy_nonzero): Use
11239         std::move.
11240         * python/py-utils.c (gdbpy_convert_exception): Take a const
11241         reference.
11242         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11243         Use std::move.
11244         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11245         Use std::move.
11246         * mi/mi-main.c (mi_print_exception): Take a const reference.
11247         * main.c (handle_command_errors): Take a const reference.
11248         * linespec.c (parse_linespec): Use std::move.
11249         * infcall.c (run_inferior_call): Use std::move.
11250         (call_function_by_hand_dummy): Use std::move.
11251         * exec.c (try_open_exec_file): Use std::move.
11252         * exceptions.h (exception_print, exception_fprintf)
11253         (exception_print_same): Update.
11254         * exceptions.c (print_exception, exception_print)
11255         (exception_fprintf, exception_print_same): Change parameters to
11256         const reference.
11257         * event-top.c (gdb_rl_callback_read_char_wrapper): Update.
11258         * common/new-op.c: Use std::move.
11259         * common/common-exceptions.h (struct gdb_exception): Add move
11260         constructor.
11261         (struct gdb_exception_error, struct gdb_exception_quit, struct
11262         gdb_quit_bad_alloc): Change constructor to move constructor.
11263         (throw_exception): Change parameter to rvalue reference.
11264         * common/common-exceptions.c (throw_exception): Take rvalue
11265         reference.
11266         * cli/cli-interp.c (safe_execute_command): Use std::move.
11267         * breakpoint.c (insert_bp_location, location_to_sals): Use
11268         std::move.
11269
11270 2019-04-25  Tom Tromey  <tromey@adacore.com>
11271
11272         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception)
11273         (gdbscm_throw_gdb_exception): Take a gdbscm_gdb_exception.
11274         * guile/scm-block.c, guile/scm-breakpoint.c, guile/scm-cmd.c,
11275         guile/scm-disasm.c, guile/scm-frame.c, guile/scm-lazy-string.c,
11276         guile/scm-math.c, guile/scm-param.c, guile/scm-ports.c,
11277         guile/scm-symbol.c, guile/scm-symtab.c, guile/scm-type.c,
11278         guile/scm-value.c: Use unpack.
11279         * guile/guile-internal.h (gdbscm_scm_from_gdb_exception): Take a
11280         gdbscm_gdb_exception.
11281         (gdbscm_throw_gdb_exception): Likewise.
11282         (struct gdbscm_gdb_exception): New.
11283         (unpack): New function.
11284         (gdbscm_wrap): Use unpack.
11285
11286 2019-04-25  Tom Tromey  <tromey@adacore.com>
11287
11288         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11289         (gdb_rl_callback_handler): Use std::move.
11290         * common/common-exceptions.h (struct gdb_exception): Add move
11291         assignment operator.
11292         (throw_exception_sjlj): Change "exception" to const reference.
11293         * common/common-exceptions.c (exceptions_state_mc_catch): Update.
11294         (throw_exception_sjlj): Change "exception" to const reference.
11295
11296 2019-04-25  Tom Tromey  <tromey@adacore.com>
11297
11298         * xml-support.c (gdb_xml_parser::gdb_xml_parser): Update.
11299         * python/py-value.c (valpy_getitem, valpy_nonzero): Update.
11300         * python/py-inferior.c (infpy_write_memory, infpy_search_memory):
11301         Update.
11302         * python/py-breakpoint.c (bppy_set_condition, bppy_set_commands):
11303         Update.
11304         * mi/mi-interp.c (mi_interp::exec): Update.
11305         * linespec.c (parse_linespec): Update.
11306         * infcall.c (run_inferior_call): Update.
11307         * guile/scm-value.c (gdbscm_value_to_lazy_string): Update.
11308         * guile/scm-symbol.c (gdbscm_lookup_symbol)
11309         (gdbscm_lookup_global_symbol): Update.
11310         * guile/scm-param.c (gdbscm_parameter_value): Update.
11311         * guile/scm-frame.c (gdbscm_frame_read_register)
11312         (gdbscm_frame_read_var): Update.
11313         * guile/scm-breakpoint.c (gdbscm_register_breakpoint_x): Update.
11314         * exec.c (try_open_exec_file): Update.
11315         * event-top.c (gdb_rl_callback_read_char_wrapper_noexcept)
11316         (gdb_rl_callback_handler): Update.
11317         * common/common-exceptions.h (exception_none): Don't declare.
11318         * common/common-exceptions.c (exception_none): Don't define.
11319         (struct catcher) <exception>: Update.
11320         * cli/cli-interp.c (safe_execute_command): Update.
11321         * breakpoint.c (insert_bp_location, location_to_sals): Update.
11322
11323 2019-04-25  Ali Tamur  <tamur@google.com>
11324
11325         * dwarf2read.c (skip_one_die): Add DW_FORM_strx.
11326         (read_attribute_value): Likewise.
11327         (dwarf2_read_addr_index): Update comment.
11328         (read_str_index): Add DW_FORM_strx.
11329         (dwarf2_string_attr): Likewise.
11330         (dwarf2_const_value_attr): Likewise.
11331         (dump_die_shallow): Likewise.
11332         (dwarf2_fetch_constant_bytes): Likewise.
11333         (skip_form_bytes): Likewise.
11334         * testsuite/lib/dwarf.exp (_handle_DW_FORM): Add DW_FORM_strx.
11335
11336 2019-04-25  Sergio Durigan Junior  <sergiodj@redhat.com>
11337
11338         PR corefiles/11608
11339         PR corefiles/18187
11340         * linux-tdep.c (dump_mapping_p): Add new parameters ADDR and
11341         OFFSET.  Verify if current mapping contains an ELF header.
11342         (linux_find_memory_regions_full): Adjust call to
11343         dump_mapping_p.
11344
11345 2019-04-25  Sandra Loosemore  <sandra@codesourcery.com>
11346             Kang Li <kanglictf@gmail.com>
11347
11348         PR gdb/21600
11349
11350         * dwarf2-frame.c (read_initial_length): Be consistent about using
11351         unsigned representation of length.
11352         (decode_frame_entry_1): Likewise.  Check for wraparound of
11353         end pointer as well as buffer overflow.
11354
11355 2019-04-24  Sergio Durigan Junior  <sergiodj@redhat.com>
11356
11357         * aarch64-tdep.c (aarch64_gdbarch_init): Use "pulongest" to print
11358         "vq".
11359
11360 2019-04-24  Tom Tromey  <tromey@adacore.com>
11361
11362         * amd64-tdep.c (amd64_has_unaligned_fields): Ignore bitfields.
11363
11364 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11365
11366         * s12z-tdep.c (s12z_unwind_pc): Delete.
11367         (s12z_unwind_sp): Delete.
11368         (s12z_gdbarch_init): Don't register deleted functions with
11369         gdbarch.
11370
11371 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11372
11373         * rl78-tdep.c (rl78_unwind_sp): Delete.
11374         (rl78_gdbarch_init): Don't register deleted function with gdbarch.
11375
11376 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11377
11378         * xstormy16-tdep.c (xstormy16_unwind_sp): Delete.
11379         (xstormy16_unwind_pc): Delete.
11380         (xstormy16_dummy_id): Delete.
11381         (xstormy16_gdbarch_init): Don't register deleted functions with
11382         gdbarch.
11383
11384 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11385
11386         * vax-tdep.c (vax_unwind_pc): Delete.
11387         (vax_gdbarch_init): Don't register deleted function with gdbarch.
11388
11389 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11390
11391         * v850-tdep.c (v850_unwind_sp): Delete.
11392         (v850_unwind_pc): Delete.
11393         (v850_dummy_id): Delete.
11394         (v850_gdbarch_init): Don't register deleted functions with
11395         gdbarch.
11396
11397 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11398
11399         * tilegx-tdep.c (tilegx_unwind_sp): Delete.
11400         (tilegx_unwind_pc): Delete.
11401         (tilegx_unwind_dummy_id): Delete.
11402         (tilegx_gdbarch_init): Don't register deleted functions with
11403         gdbarch.
11404
11405 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11406
11407         * tic6x-tdep.c (tic6x_unwind_sp): Delete.
11408         (tic6x_dummy_id): Delete.
11409         (tic6x_gdbarch_init): Don't register deleted functions with
11410         gdbarch.
11411
11412 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11413
11414         * sparc-tdep.c (sparc_unwind_pc): Delete.
11415         (sparc32_gdbarch_init): Don't register deleted function with
11416         gdbarch.
11417
11418 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11419
11420         * sh-tdep.c (sh_unwind_sp): Delete.
11421         (sh_unwind_pc): Delete.
11422         (sh_dummy_id): Delete.
11423         (sh_gdbarch_init): Don't register deleted functions with
11424         gdbarch.
11425
11426 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11427
11428         * score-tdep.c (score_unwind_sp): Delete.
11429         (score_unwind_pc): Delete.
11430         (score_dummy_id): Delete.
11431         (score_gdbarch_init): Don't register deleted functions with
11432         gdbarch.
11433
11434 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11435
11436         * rx-tdep.c (rx_unwind_pc): Delete.
11437         (rx_unwind_sp): Delete.
11438         (rx_dummy_id): Delete.
11439         (rx_gdbarch_init): Don't register deleted functions with
11440         gdbarch.  Update comment.
11441
11442 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11443
11444         * rs6000-tdep.c (rs6000_unwind_pc): Delete.
11445         (rs6000_dummy_id): Delete.
11446         (rs6000_gdbarch_init): Don't register deleted functions with
11447         gdbarch.
11448
11449 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11450
11451         * or1k-tdep.c (or1k_dummy_id): Delete.
11452         (or1k_gdbarch_init): Don't register deleted function with gdbarch.
11453
11454 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11455
11456         * nios2-tdep.c (nios2_dummy_id): Delete.
11457         (nios2_unwind_sp): Delete.
11458         (nios2_gdbarch_init): Don't register deleted functions with
11459         gdbarch.
11460
11461 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11462
11463         * nds32-tdep.c (nds32_dummy_id): Delete.
11464         (nds32_unwind_pc): Delete.
11465         (nds32_unwind_sp): Delete.
11466         (nds32_gdbarch_init): Don't register deleted functions with
11467         gdbarch.
11468
11469 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11470
11471         * msp430-tdep.c (msp430_unwind_pc): Delete.
11472         (msp430_unwind_sp): Delete.
11473         (msp430_dummy_id): Delete.
11474         (msp430_gdbarch_init): Don't register deleted functions with
11475         gdbarch.
11476
11477 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11478
11479         * moxie-tdep.c (moxie_unwind_sp): Delete.
11480         (moxie_unwind_pc): Delete.
11481         (moxie_dummy_id): Delete.
11482         (moxie_gdbarch_init): Don't register deleted functions with
11483         gdbarch.
11484
11485 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11486
11487         * mn10300-tdep.c (mn10300_dummy_id): Delete.
11488         (mn10300_unwind_pc): Delete.
11489         (mn10300_unwind_sp): Delete.
11490         (mn10300_push_dummy_call): Use gdbarch_unwind_sp not
11491         mn10300_unwind_sp.
11492         (mn10300_frame_unwind_init): Don't register deleted functions with
11493         gdbarch.
11494
11495 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11496
11497         * mep-tdep.c (mep_unwind_pc): Delete.
11498         (mep_unwind_sp): Delete.
11499         (mep_dummy_id): Delete.
11500         (mep_gdbarch_init): Don't register deleted functions with
11501         gdbarch.
11502
11503 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11504
11505         * m68hc11-tdep.c (m68hc11_unwind_pc): Delete.
11506         (m68hc11_unwind_sp): Delete.
11507         (m68hc11_gdbarch_init): Don't register deleted functions with
11508         gdbarch.
11509
11510 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11511
11512         * m32r-tdep.c (m32r_unwind_sp): Delete.
11513         (m32r_unwind_pc): Delete.
11514         (m32r_dummy_id): Delete.
11515         (m32r_gdbarch_init): Don't register deleted functions with
11516         gdbarch.
11517
11518 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11519
11520         * m32c-tdep.c (m32c_unwind_pc): Delete.
11521         (m32c_unwind_sp): Delete.
11522         (m32c_dummy_id): Delete.
11523         (m32c_gdbarch_init): Don't register deleted functions with
11524         gdbarch.
11525
11526 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11527
11528         * gdb/lm32-tdep.c (lm32_unwind_sp): Delete.
11529         (lm32_unwind_pc): Delete.
11530         (lm32_dummy_id): Delete.
11531         (lm32_gdbarch_init): Don't register deleted functions with
11532         gdbarch.
11533
11534 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11535
11536         * gdb/iq2000-tdep.c (iq2000_unwind_sp): Delete.
11537         (iq2000_unwind_pc): Delete.
11538         (iq2000_dummy_id): Delete.
11539         (iq2000_gdbarch_init): Don't register deleted functions with
11540         gdbarch.
11541
11542 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11543
11544         * nds32-tdep.c (nds32_type_align): Delete.
11545         (nds32_push_dummy_call): Use type_align instead.
11546
11547 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11548
11549         * arm-tdep.c (arm_type_align): Only handle vector override case.
11550         (arm_push_dummy_call): Use type_align.
11551         (arm_gdbarch_init): Register arm_type_align gdbarch function.
11552
11553 2019-04-23  Andrew Burgess  <andrew.burgess@embecosm.com>
11554
11555         * aarch64-tdep.c (aarch64_type_align): Only handle vector override
11556         case.
11557         (pass_on_stack): Use type_align.
11558         (aarch64_gdbarch_init): Register aarch64_type_align gdbarch
11559         function.
11560
11561 2019-04-23  Tom Tromey  <tromey@adacore.com>
11562
11563         * dwarf2read.c (line_header::file_name_at): Remove unused
11564         overload.
11565
11566 2019-04-23  Tom de Vries  <tdevries@suse.de>
11567
11568         PR gdb/24438
11569         * contrib/cc-with-tweaks.sh: Remove superfluous .alt file after dwz
11570         invocation.
11571
11572
11573 2019-03-27  Ali Tamur  <tamur@google.com>
11574
11575         * dwarf2-frame.c(dwarf_expr_executor::get_addr_index): Update comment
11576         * dwarf2expr.c(dwarf_expr_context::execute_stack_op): Add DW_OP_addrx
11577         * dwarf2expr.h(dwarf_expr_context::offset): Update comment
11578         (dwarf_expr_context::get_addr_index): Likewise
11579         * dwarf2loc.c(dwarf_evaluate_loc_desc::get_addr_index): Likewise
11580         (symbol_needs_eval_context::get_addr_index): Likewise
11581         (disassemble_dwarf_expression): Add DW_OP_addrx
11582         * dwarf2read.c(attr_value_as_address): Add DW_FORM_addrx
11583         (read_cutu_die_from_dwo): Update comment
11584         (skip_one_die): Add DW_FORM_addrx
11585         (read_attribute_value): Likewise
11586         (var_decode_location): Add DW_OP_addrx
11587         (dwarf2_const_value_attr): Add DW_FORM_addrx
11588         (dump_die_shallow): Likewise
11589         (dwarf2_fetch_constant_bytes): Likewise
11590         (decode_locdesc): Add DW_OP_addrx
11591         (skip_form_bytes): Add DW_FORM_addrx
11592
11593 2019-04-22  Ali Tamur  <tamur@google.com>
11594
11595         * MAINTAINERS (Write After Approval): Add self.
11596
11597 2019-04-22  Simon Marchi  <simon.marchi@efficios.com>
11598
11599         * solib-svr4.c (get_svr4_info): Add pspace parameter.
11600         (svr4_keep_data_in_core): Pass current_program_space to get_svr4_info.
11601         (open_symbol_file_object): Likewise.
11602         (svr4_default_sos): Add info parameter.
11603         (svr4_read_so_list): Likewise.
11604         (svr4_current_sos_direct): Adjust functions calls to pass down
11605         info.
11606         (svr4_current_sos_1): Add info parameter.
11607         (svr4_current_sos): Call get_svr4_info, pass info down to
11608         svr4_current_sos_1.
11609         (svr4_fetch_objfile_link_map): Pass objfile->pspace to
11610         get_svr4_info.
11611         (svr4_in_dynsym_resolve_code): Pass current_program_space to
11612         get_svr4_info.
11613         (probes_table_htab_remove_objfile_probes): Pass objfile->pspace
11614         to get_svr4_info.
11615         (probes_table_remove_objfile_probes): Likewise.
11616         (register_solib_event_probe): Add info parameter.
11617         (solist_update_incremental): Pass info parameter down to
11618         svr4_read_so_list.
11619         (disable_probes_interface): Add info parameter.
11620         (svr4_handle_solib_event): Pass current_program_space to
11621         get_svr4_info.  Adjust disable_probes_interface cleanup.
11622         (svr4_create_probe_breakpoints): Add info parameter, pass it
11623         down to register_solib_event_probe.
11624         (svr4_create_solib_event_breakpoints): Add info parameter,
11625         pass it down to svr4_create_probe_breakpoints.
11626         (enable_break): Pass info down to
11627         svr4_create_solib_event_breakpoints.
11628         (svr4_solib_create_inferior_hook): Pass current_program_space to
11629         get_svr4_info.
11630         (svr4_clear_solib): Likewise.
11631
11632 2019-04-22  Pedro Alves  <palves@redhat.com>
11633
11634         * solib-svr4.c (svr4_free_objfile_observer): New.
11635         (probe_and_action::objfile): New field.
11636         (probes_table_htab_remove_objfile_probes)
11637         (probes_table_remove_objfile_probes): New functions.
11638         (register_solib_event_probe): Add 'objfile' parameter.  Store it
11639         in the new probe_and_action.  Don't store the probe in 'lookup'.
11640         (svr4_create_probe_breakpoints): Pass objfile to
11641         register_solib_event_probe.
11642         (_initialize_svr4_solib): Register a free_objfile observer.
11643
11644 2019-04-19  Tom Tromey  <tom@tromey.com>
11645
11646         * common/queue.h: Remove.
11647
11648 2019-04-19  Tom Tromey  <tom@tromey.com>
11649
11650         * event-loop.c: Don't include "common/queue.h".
11651
11652 2019-04-19  Tom Tromey  <tom@tromey.com>
11653
11654         * remote.c (remote_target): Use delete.
11655         * remote-notif.h: Include <list>, not "common/queue.h".
11656         (notif_client_p): Remove typedef.
11657         (remote_notif_state): Add constructor, destructor, initializer.
11658         <notif_queue>: Now a std::list.
11659         (remote_notif_state_xfree): Don't declare.
11660         * remote-notif.c (remote_notif_process, handle_notification)
11661         (remote_notif_state_allocate): Update.
11662         (~remote_notif_state): Rename from remote_notif_state_xfree.
11663
11664 2019-04-19  Tom Tromey  <tom@tromey.com>
11665
11666         * symfile.c (reread_symbols): Update.
11667         * objfiles.c (objfile_register_static_link)
11668         (objfile_lookup_static_link): Update
11669         (~objfile) Don't delete static_links.
11670         * objfiles.h (struct objfile) <static_links>: Now an htab_up.
11671
11672 2019-04-19  Tom Tromey  <tom@tromey.com>
11673
11674         * type-stack.h (struct type_stack) <insert>: Constify string.
11675         * type-stack.c (type_stack::insert): Constify string.
11676         * gdbtypes.h (lookup_template_type): Update.
11677         (address_space_name_to_int): Update.
11678         * gdbtypes.c (address_space_name_to_int): Make space_identifier
11679         const.
11680         (lookup_template_type): Make name const.
11681         * c-exp.y: Update rules.
11682         (lex_one_token, classify_name, classify_inner_name)
11683         (c_print_token): Update.
11684         * p-exp.y: Update rules.
11685         (yylex): Update.
11686         * f-exp.y: Update rules.
11687         (yylex): Update.
11688         * d-exp.y: Update rules.
11689         (lex_one_token, classify_name, classify_inner_name): Update.
11690         * parse.c (write_dollar_variable, copy_name): Return std::string.
11691         * parser-defs.h (copy_name): Change return type.
11692         * m2-exp.y: Update rules.
11693         (yylex): Update.
11694         * go-exp.y (lex_one_token): Update.
11695         Update rules.
11696         (classify_unsafe_function, classify_packaged_name)
11697         (classify_name, yylex): Update.
11698
11699 2019-04-19  Sergei Trofimovich <siarheit@google.com>
11700
11701         * configure.ac: add --enable-source-highlight switch.
11702         * configure: Regenerate.
11703         * top.c (print_gdb_version): plumb --enable-source-highlight
11704         status to "show configuration".
11705
11706 2019-04-19  Tom Tromey  <tromey@adacore.com>
11707
11708         * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
11709         Check ADA_TYPE_P.
11710         (empty_record, ada_template_to_fixed_record_type_1)
11711         (template_to_static_fixed_type)
11712         (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
11713         * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
11714         * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
11715         macros.
11716
11717 2019-04-19  Ilya Yu. Malakhov  <malakhov@mcst.ru>
11718
11719         PR symtab/24423:
11720         * source.c (print_source_lines_base): Advance "iter" when a
11721         control character is seen.
11722
11723 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11724
11725         * inferior.h (struct infcall_suspend_state_deleter):
11726         Catch exception in destructor to avoid crash.
11727
11728 2019-04-19  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
11729
11730         * cli/cli-cmds.c (_initialize_cli_cmds): Move "shell" "!" alias
11731         close to the add_com "shell".
11732
11733 2019-04-18  Tom Tromey  <tromey@adacore.com>
11734
11735         * process-stratum-target.h (class process_stratum_target)
11736         <stratum>: Add "final".
11737
11738 2019-04-17  Tom Tromey  <tromey@adacore.com>
11739
11740         * dwarf2read.c (dwarf2_init_complex_target_type): Check "tt"
11741         against nullptr before use.
11742
11743 2019-04-17  Alan Hayward  <alan.hayward@arm.com>
11744
11745         * nat/linux-waitpid.c (linux_debug): Call debug_vprintf.
11746
11747 2019-04-17  Jim Wilson  <jimw@sifive.com>
11748             Andrew Burgess  <andrew.burgess@embecosm.com>
11749
11750         * riscv-tdep.c (riscv_breakpoint_kind_from_pc): Hanndle case where
11751         code read might fail, assume 4-byte breakpoint in that case.
11752
11753 2019-04-15  Leszek Swirski  <leszeks@google.com>
11754
11755         * amd64-tdep.c (amd64_classify_aggregate): Use cp_pass_by_reference
11756         rather than a hand-rolled POD check when checking for forced MEMORY
11757         classification.
11758
11759 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11760
11761         * aarch64-linux-nat.c (store_sveregs_to_thread): Set vector length.
11762         * nat/aarch64-sve-linux-ptrace.c (aarch64_sve_set_vq): New
11763         function.
11764         (aarch64_sve_regs_copy_to_reg_buf): Remove VG checks.
11765         (aarch64_sve_regs_copy_from_reg_buf): Likewise.
11766         * nat/aarch64-sve-linux-ptrace.h (aarch64_sve_set_vq): New
11767         declaration.
11768
11769 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11770
11771         * aarch64-linux-nat.c
11772         (aarch64_linux_nat_target::thread_architecture): Add override.
11773         * aarch64-tdep.c (aarch64_gdbarch_init): Ensure different tdesc for
11774         each VQ.
11775
11776 2019-04-15  Alan Hayward  <alan.hayward@arm.com>
11777
11778         * aarch64-tdep.c (aarch64_gdbarch_init): Move gdbarch lookup.
11779
11780 2019-04-13  Andrew Burgess  <andrew.burgess@embecosm.com>
11781
11782         * dwarf2read.c (dwarf2_init_complex_target_type): Handle complex
11783         target types of size 96-bits, add some additional comments, and
11784         check that the builtin type we found was the correct size.
11785
11786 2019-04-12  Eli Zaretskii  <eliz@gnu.org>
11787
11788         * utils.c (prompt_for_continue): Don't restore the styling at the
11789         end, as applied_style has the wrong value.  This fixes styling in
11790         long lists of file names that are interrupted by the "Continue?"
11791         prompt.
11792
11793 2019-04-12  Andrew Burgess  <andrew.burgess@embecosm.com>
11794
11795         * ada-lang.c (ada_language_defn): Remove use of LANG_MAGIC.
11796         * c-lang.c (c_language_defn): Likewise.
11797         (cplus_language_defn): Likewise.
11798         (asm_language_defn): Likewise.
11799         (minimal_language_defn): Likewise.
11800         * d-lang.c (d_language_defn): Likewise.
11801         * f-lang.c (f_language_defn): Likewise.
11802         * go-lang.c (go_language_defn): Likewise.
11803         * language.c (unknown_language_defn): Likewise.
11804         (auto_language_defn): Likewise.
11805         * language.h (struct language_defn): Remove la_magic field.
11806         (LANG_MAGIC): Delete.
11807         * m2-lang.c (m2_language_defn): Remove use of LANG_MAGIC.
11808         * objc-lang.c (objc_language_defn): Likewise.
11809         * opencl-lang.c (opencl_language_defn): Likewise.
11810         * p-lang.c (pascal_language_defn): Likewise.
11811         * rust-lang.c (rust_language_defn): Likewise.
11812
11813 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11814
11815         * riscv-tdep.c (riscv_type_align): New function.
11816         (riscv_type_alignment): Delete.
11817         (riscv_arg_location): Use 'type_align'.
11818         (riscv_gdbarch_init): Register riscv_type_align gdbarch function.
11819
11820 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11821
11822         * gdbtypes.c (type_align): A struct with no non-static fields also
11823         has alignment of 1.
11824
11825 2019-04-11  Andrew Burgess  <andrew.burgess@embecosm.com>
11826
11827         * riscv-tdep.c (riscv_call_arg_complex_float): Fix offset of first
11828         component to 0.
11829         (riscv_struct_info::riscv_struct_info): Initialise m_offsets
11830         member.
11831         (riscv_struct_info::analyse): New implementation using new
11832         analyse_inner member function.
11833         (riscv_struct_info::field_offset): New member function.
11834         (riscv_struct_info::m_offsets): New member variable.
11835         (riscv_struct_info::analyse_inner): New private member function,
11836         takes the old implementation of riscv_struct_info::analyse but
11837         extended to track field offsets.
11838         (riscv_call_arg_struct): Update the struct folding special cases
11839         to handle cases where empty C++ structs, which are non-zero
11840         length, are found.
11841         (riscv_arg_location): Initialise the length of each location, a
11842         non-zero length now indicates the location is in use.
11843         (riscv_push_dummy_call): Allow for the first location having a
11844         non-zero offset when setting up arguments.
11845         (riscv_return_value): Likewise, but for return values.
11846
11847 2019-04-11  Tom Tromey  <tromey@adacore.com>
11848
11849         * utils.c (internal_vproblem): Make "msg" const.
11850
11851 2019-04-11  Alan Hayward  <alan.hayward@arm.com>
11852
11853         * aarch64-tdep.c (aarch64_analyze_prologue_test): Reset saved regs.
11854         * trad-frame.c (trad_frame_reset_saved_regs): New function.
11855         (trad_frame_alloc_saved_regs): Call trad_frame_reset_saved_regs.
11856         * trad-frame.h (trad_frame_reset_saved_regs): New declaration.
11857
11858 2019-04-10  Kevin Buettner  <kevinb@redhat.com>
11859
11860         * amd64-linux-nat.c (amd64_linux_collect_native_gregset): New
11861         function.
11862         (fill_gregset): Call amd64_linux_collect_native_gregset instead
11863         of amd64_collect_native_gregset.
11864         (amd64_linux_nat_target::store_registers): Likewise.
11865
11866 2019-04-10  Tom Tromey  <tom@tromey.com>
11867
11868         * symtab.c (lookup_global_symbol_from_objfile)
11869         (lookup_symbol_in_objfile_from_linkage_name): Use the iterator.
11870         * objfiles.h (class separate_debug_iterator): New.
11871         (class separate_debug_range): New.
11872         (struct objfile) <separate_debug_objfiles>: New method.
11873         (objfile_separate_debug_iterate): Don't declare.
11874         * objfiles.c (separate_debug_iterator::operator++): Rename from
11875         objfile_separate_debug_iterate.
11876         (objfile_relocate, objfile_rebase, objfile_has_symbols): Use the
11877         iterator.
11878         * minsyms.c (lookup_minimal_symbol_by_pc_section): Use the
11879         iterator.
11880
11881 2019-04-10  Tom Tromey  <tom@tromey.com>
11882
11883         * symfile.c (reread_symbols): Remove old comment.
11884         * objfiles.c (free_all_objfiles): Fix a typo.
11885
11886 2019-04-10  Tom Tromey  <tom@tromey.com>
11887
11888         * ia64-tdep.c (ia64_get_dyn_info_list): Use foreach.
11889         * minsyms.c (lookup_minimal_symbol): Use foreach.
11890         (lookup_minimal_symbol_text, lookup_minimal_symbol_by_pc_name)
11891         (lookup_minimal_symbol_solib_trampoline): Likewise.
11892         * symfile.c (reread_symbols): Use foreach.
11893
11894 2019-04-09  Ivan Begert  <ivanbegert@gmail.com>
11895             Tom Tromey  <tromey@adacore.com>
11896
11897         PR rust/24414:
11898         * rust-exp.y (rust_parser::lex_number): Use strtoulst.
11899         (rust_lex_int_test): Change "value" to be LONGEST.
11900         (rust_lex_tests): Add test for long integer literal.
11901
11902 2019-04-09  Tom Tromey  <tromey@adacore.com>
11903
11904         * remote.c (remote_target::remote_add_inferior): Change fake_pid_p
11905         to bool.
11906         (extended_remote_target::attach): Update.
11907         (remote_target::remote_notice_new_inferior): Update.
11908         (remote_target::add_current_inferior_and_thread): Update.
11909         * inferior.c (exit_inferior_1): Use "false".
11910         * corelow.c (add_to_thread_list): Make fake_pid_p bool.
11911
11912 2019-04-09  Simon Marchi  <simon.marchi@efficios.com>
11913
11914         * infcmd.c (run_command_1): Pass -qualified to tbreak when using
11915         the "start" command.
11916
11917 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11918
11919         * python/py-inferior.c (infpy_thread_from_thread_handle):
11920         Adjust comments to reflect renaming of thread_from_thread_handle
11921         to thread_from_handle.  Adjust keywords.  Fix type error message.
11922         (inferior_object_methods): Add thread_from_handle.  Retain
11923         thread_from_thread_handle, but mark it as deprecated.
11924
11925 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11926
11927         * gdbthread.h (find_thread_by_handle): Revise declaration.
11928         * thread.c (find_thread_by_handle): Likewise.  Adjust
11929         implementation too.
11930         * python/py-inferior.c (infpy_thread_from_thread_handle): Add
11931         support for buffer objects as handles.
11932
11933 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11934
11935         * python/py-infthread.c (thpy_thread_handle): New function.
11936         (thread_object_methods): Register thpy_thread_handle.
11937
11938 2019-04-08  Kevin Buettner  <kevinb@redhat.com>
11939
11940         * gdbthread.h (thread_to_thread_handle): Declare.
11941         * thread.c (gdbtypes.h): Include.
11942         (thread_to_thread_handle): New function.
11943
11944         * target.h (struct target_ops): Add thread_info_to_thread_handle.
11945         (target_thread_info_to_thread_handle): Declare.
11946         * target.c (target_thread_info_to_thread_handle): New function.
11947         * target-debug.h (target_debug_print_gdb_byte_vector): Define.
11948         * target-delegates.c: Regenerate.
11949
11950         * linux-thread-db.c (class thread_db_target): Add method
11951         thread_info_to_thread_handle.
11952         (thread_db_target::thread_info_to_thread_handle): Define.
11953         * remote.c (class remote_target): Add new method
11954         thread_info_to_thread_handle.
11955         (remote_target::thread_info_to_thread_handle): Define.
11956
11957 2019-04-08  Pedro Alves  <palves@redhat.com>
11958
11959         * common/common-exceptions.c (throw_exception): Don't create
11960         named object to throw; throw directly.
11961         (throw_it): Likewise.  Don't initialize gdb_exception::message
11962         here, with new; pass FMT and AP to the ctor instead.
11963         * common/common-exceptions.h: Include <string>.
11964         (gdb_exception::gdb_exception(enum return_reason, enum errors,
11965         const char *, va_list)): New ctor.  Use std::make_shared.
11966         (gdb_exception_error::gdb_exception_error(enum return_reason, enum
11967         errors)): Delete.
11968         (gdb_exception_error::gdb_exception_error(enum errors, const char
11969         *, va_list)): New.
11970         (gdb_exception_error::gdb_exception_error(const gdb_exception &)):
11971         Add assertion.
11972         (gdb_exception_quit::gdb_exception_quit(enum return_reason, enum
11973         errors)): Delete.
11974         (gdb_exception_quit::gdb_exception_quit(const char *, va_list)): New.
11975         (gdb_exception_quit::gdb_exception_quit(const gdb_exception &)):
11976         Add assertion.
11977
11978 2019-04-08  Tom Tromey  <tom@tromey.com>
11979
11980         * valops.c (value_rtti_indirect_type): Replace throw_exception
11981         with throw.
11982         * tracefile-tfile.c (tfile_target_open): Replace throw_exception
11983         with throw.
11984         * thread.c (thr_try_catch_cmd): Replace throw_exception with
11985         throw.
11986         * target.c (target_translate_tls_address): Replace throw_exception
11987         with throw.
11988         * stack.c (frame_apply_command_count): Replace throw_exception
11989         with throw.
11990         * solib-spu.c (append_ocl_sos): Replace throw_exception with
11991         throw.
11992         * s390-tdep.c (s390_frame_unwind_cache): Replace throw_exception
11993         with throw.
11994         * rs6000-tdep.c (rs6000_frame_cache)
11995         (rs6000_epilogue_frame_cache): Replace throw_exception with throw.
11996         * remote.c: Replace throw_exception with throw.
11997         * record-full.c (record_full_message, record_full_wait_1)
11998         (record_full_restore): Replace throw_exception with throw.
11999         * record-btrace.c:
12000         (get_thread_current_frame_id, record_btrace_start_replaying)
12001         (cmd_record_btrace_bts_start, cmd_record_btrace_pt_start)
12002         (cmd_record_btrace_start): Replace throw_exception with throw.
12003         * parse.c (parse_exp_in_context_1): Replace throw_exception with
12004         throw.
12005         * linux-nat.c (detach_one_lwp, linux_resume_one_lwp)
12006         (resume_stopped_resumed_lwps): Replace throw_exception with throw.
12007         * linespec.c:
12008         (find_linespec_symbols): Replace throw_exception with throw.
12009         * infrun.c (displaced_step_prepare, resume): Replace
12010         throw_exception with throw.
12011         * infcmd.c (post_create_inferior): Replace throw_exception with
12012         throw.
12013         * inf-loop.c (inferior_event_handler): Replace throw_exception
12014         with throw.
12015         * i386-tdep.c (i386_frame_cache, i386_epilogue_frame_cache)
12016         (i386_sigtramp_frame_cache): Replace throw_exception with throw.
12017         * frame.c (frame_unwind_pc, get_prev_frame_if_no_cycle)
12018         (get_prev_frame_always, get_frame_pc_if_available)
12019         (get_frame_address_in_block_if_available, get_frame_language):
12020         Replace throw_exception with throw.
12021         * frame-unwind.c (frame_unwind_try_unwinder): Replace
12022         throw_exception with throw.
12023         * eval.c (fetch_subexp_value, evaluate_var_value)
12024         (evaluate_funcall, evaluate_subexp_standard): Replace
12025         throw_exception with throw.
12026         * dwarf2loc.c (call_site_find_chain)
12027         (dwarf2_evaluate_loc_desc_full, dwarf2_locexpr_baton_eval):
12028         Replace throw_exception with throw.
12029         * dwarf2-frame.c (dwarf2_frame_cache): Replace throw_exception
12030         with throw.
12031         * darwin-nat.c (darwin_attach_pid): Replace throw_exception with
12032         throw.
12033         * cp-abi.c (baseclass_offset): Replace throw_exception with throw.
12034         * completer.c (complete_line_internal): Replace throw_exception
12035         with throw.
12036         * compile/compile-object-run.c (compile_object_run): Replace
12037         throw_exception with throw.
12038         * cli/cli-script.c (process_next_line): Replace throw_exception
12039         with throw.
12040         * btrace.c (btrace_compute_ftrace_pt, btrace_compute_ftrace)
12041         (btrace_enable, btrace_maint_update_pt_packets): Replace
12042         throw_exception with throw.
12043         * breakpoint.c (create_breakpoint, save_breakpoints): Replace
12044         throw_exception with throw.
12045         * break-catch-throw.c (re_set_exception_catchpoint): Replace
12046         throw_exception with throw.
12047         * amd64-tdep.c (amd64_frame_cache, amd64_sigtramp_frame_cache)
12048         (amd64_epilogue_frame_cache): Replace throw_exception with throw.
12049         * aarch64-tdep.c (aarch64_make_prologue_cache)
12050         (aarch64_make_stub_cache): Replace throw_exception with throw.
12051
12052 2019-04-08  Tom Tromey  <tom@tromey.com>
12053
12054         * common/common-exceptions.c (throw_exception): Rename from
12055         throw_exception_cxx.  Remove old copy.  Make argument const.
12056         (throw_it): Create and throw exception objects directly.
12057         * common/common-exceptions.h (throw_exception): Make argument
12058         const.
12059         (struct gdb_exception_error): Add constructor.
12060         (struct gdb_exception_quit): Add constructor.
12061
12062 2019-04-08  Tom Tromey  <tom@tromey.com>
12063
12064         * common/common-exceptions.h (exception_rethrow): Don't declare.
12065         (TRY_SJLJ): Update comment.
12066         (TRY, CATCH, END_CATCH): Remove.
12067         * common/common-exceptions.c (exception_rethrow): Remove.
12068
12069 2019-04-08  Tom Tromey  <tom@tromey.com>
12070
12071         * common/common-exceptions.h (gdb_exception_RETURN_MASK_ALL):
12072         Remove.
12073         (gdb_exception_error): Rename from
12074         gdb_exception_RETURN_MASK_ERROR.
12075         (gdb_exception_quit): Rename from gdb_exception_RETURN_MASK_QUIT.
12076         (gdb_quit_bad_alloc): Update.
12077         * aarch64-tdep.c: Update.
12078         * ada-lang.c: Update.
12079         * ada-typeprint.c: Update.
12080         * ada-valprint.c: Update.
12081         * amd64-tdep.c: Update.
12082         * arch-utils.c: Update.
12083         * break-catch-throw.c: Update.
12084         * breakpoint.c: Update.
12085         * btrace.c: Update.
12086         * c-varobj.c: Update.
12087         * cli/cli-cmds.c: Update.
12088         * cli/cli-interp.c: Update.
12089         * cli/cli-script.c: Update.
12090         * common/common-exceptions.c: Update.
12091         * common/new-op.c: Update.
12092         * common/selftest.c: Update.
12093         * compile/compile-c-symbols.c: Update.
12094         * compile/compile-cplus-symbols.c: Update.
12095         * compile/compile-object-load.c: Update.
12096         * compile/compile-object-run.c: Update.
12097         * completer.c: Update.
12098         * corelow.c: Update.
12099         * cp-abi.c: Update.
12100         * cp-support.c: Update.
12101         * cp-valprint.c: Update.
12102         * darwin-nat.c: Update.
12103         * disasm-selftests.c: Update.
12104         * dtrace-probe.c: Update.
12105         * dwarf-index-cache.c: Update.
12106         * dwarf-index-write.c: Update.
12107         * dwarf2-frame-tailcall.c: Update.
12108         * dwarf2-frame.c: Update.
12109         * dwarf2loc.c: Update.
12110         * dwarf2read.c: Update.
12111         * eval.c: Update.
12112         * event-loop.c: Update.
12113         * event-top.c: Update.
12114         * exec.c: Update.
12115         * f-valprint.c: Update.
12116         * fbsd-tdep.c: Update.
12117         * frame-unwind.c: Update.
12118         * frame.c: Update.
12119         * gdbtypes.c: Update.
12120         * gnu-v3-abi.c: Update.
12121         * guile/guile-internal.h: Update.
12122         * guile/scm-block.c: Update.
12123         * guile/scm-breakpoint.c: Update.
12124         * guile/scm-cmd.c: Update.
12125         * guile/scm-disasm.c: Update.
12126         * guile/scm-frame.c: Update.
12127         * guile/scm-lazy-string.c: Update.
12128         * guile/scm-math.c: Update.
12129         * guile/scm-param.c: Update.
12130         * guile/scm-ports.c: Update.
12131         * guile/scm-pretty-print.c: Update.
12132         * guile/scm-symbol.c: Update.
12133         * guile/scm-symtab.c: Update.
12134         * guile/scm-type.c: Update.
12135         * guile/scm-value.c: Update.
12136         * i386-linux-tdep.c: Update.
12137         * i386-tdep.c: Update.
12138         * inf-loop.c: Update.
12139         * infcall.c: Update.
12140         * infcmd.c: Update.
12141         * infrun.c: Update.
12142         * jit.c: Update.
12143         * language.c: Update.
12144         * linespec.c: Update.
12145         * linux-fork.c: Update.
12146         * linux-nat.c: Update.
12147         * linux-tdep.c: Update.
12148         * linux-thread-db.c: Update.
12149         * main.c: Update.
12150         * mi/mi-cmd-break.c: Update.
12151         * mi/mi-cmd-stack.c: Update.
12152         * mi/mi-interp.c: Update.
12153         * mi/mi-main.c: Update.
12154         * objc-lang.c: Update.
12155         * p-valprint.c: Update.
12156         * parse.c: Update.
12157         * ppc-linux-tdep.c: Update.
12158         * printcmd.c: Update.
12159         * python/py-arch.c: Update.
12160         * python/py-breakpoint.c: Update.
12161         * python/py-cmd.c: Update.
12162         * python/py-finishbreakpoint.c: Update.
12163         * python/py-frame.c: Update.
12164         * python/py-framefilter.c: Update.
12165         * python/py-gdb-readline.c: Update.
12166         * python/py-inferior.c: Update.
12167         * python/py-infthread.c: Update.
12168         * python/py-lazy-string.c: Update.
12169         * python/py-linetable.c: Update.
12170         * python/py-objfile.c: Update.
12171         * python/py-param.c: Update.
12172         * python/py-prettyprint.c: Update.
12173         * python/py-progspace.c: Update.
12174         * python/py-record-btrace.c: Update.
12175         * python/py-record.c: Update.
12176         * python/py-symbol.c: Update.
12177         * python/py-type.c: Update.
12178         * python/py-unwind.c: Update.
12179         * python/py-utils.c: Update.
12180         * python/py-value.c: Update.
12181         * python/python.c: Update.
12182         * record-btrace.c: Update.
12183         * record-full.c: Update.
12184         * remote-fileio.c: Update.
12185         * remote.c: Update.
12186         * riscv-tdep.c: Update.
12187         * rs6000-aix-tdep.c: Update.
12188         * rs6000-tdep.c: Update.
12189         * rust-exp.y: Update.
12190         * rust-lang.c: Update.
12191         * s390-tdep.c: Update.
12192         * selftest-arch.c: Update.
12193         * solib-dsbt.c: Update.
12194         * solib-frv.c: Update.
12195         * solib-spu.c: Update.
12196         * solib-svr4.c: Update.
12197         * solib.c: Update.
12198         * sparc64-linux-tdep.c: Update.
12199         * stack.c: Update.
12200         * symfile-mem.c: Update.
12201         * symmisc.c: Update.
12202         * target.c: Update.
12203         * thread.c: Update.
12204         * top.c: Update.
12205         * tracefile-tfile.c: Update.
12206         * tui/tui.c: Update.
12207         * typeprint.c: Update.
12208         * unittests/cli-utils-selftests.c: Update.
12209         * unittests/parse-connection-spec-selftests.c: Update.
12210         * valops.c: Update.
12211         * valprint.c: Update.
12212         * value.c: Update.
12213         * varobj.c: Update.
12214         * windows-nat.c: Update.
12215         * x86-linux-nat.c: Update.
12216         * xml-support.c: Update.
12217
12218 2019-04-08  Tom Tromey  <tom@tromey.com>
12219
12220         * xml-support.c: Use C++ exception handling.
12221         * x86-linux-nat.c: Use C++ exception handling.
12222         * windows-nat.c: Use C++ exception handling.
12223         * varobj.c: Use C++ exception handling.
12224         * value.c: Use C++ exception handling.
12225         * valprint.c: Use C++ exception handling.
12226         * valops.c: Use C++ exception handling.
12227         * unittests/parse-connection-spec-selftests.c: Use C++ exception
12228         handling.
12229         * unittests/cli-utils-selftests.c: Use C++ exception handling.
12230         * typeprint.c: Use C++ exception handling.
12231         * tui/tui.c: Use C++ exception handling.
12232         * tracefile-tfile.c: Use C++ exception handling.
12233         * top.c: Use C++ exception handling.
12234         * thread.c: Use C++ exception handling.
12235         * target.c: Use C++ exception handling.
12236         * symmisc.c: Use C++ exception handling.
12237         * symfile-mem.c: Use C++ exception handling.
12238         * stack.c: Use C++ exception handling.
12239         * sparc64-linux-tdep.c: Use C++ exception handling.
12240         * solib.c: Use C++ exception handling.
12241         * solib-svr4.c: Use C++ exception handling.
12242         * solib-spu.c: Use C++ exception handling.
12243         * solib-frv.c: Use C++ exception handling.
12244         * solib-dsbt.c: Use C++ exception handling.
12245         * selftest-arch.c: Use C++ exception handling.
12246         * s390-tdep.c: Use C++ exception handling.
12247         * rust-lang.c: Use C++ exception handling.
12248         * rust-exp.y: Use C++ exception handling.
12249         * rs6000-tdep.c: Use C++ exception handling.
12250         * rs6000-aix-tdep.c: Use C++ exception handling.
12251         * riscv-tdep.c: Use C++ exception handling.
12252         * remote.c: Use C++ exception handling.
12253         * remote-fileio.c: Use C++ exception handling.
12254         * record-full.c: Use C++ exception handling.
12255         * record-btrace.c: Use C++ exception handling.
12256         * python/python.c: Use C++ exception handling.
12257         * python/py-value.c: Use C++ exception handling.
12258         * python/py-utils.c: Use C++ exception handling.
12259         * python/py-unwind.c: Use C++ exception handling.
12260         * python/py-type.c: Use C++ exception handling.
12261         * python/py-symbol.c: Use C++ exception handling.
12262         * python/py-record.c: Use C++ exception handling.
12263         * python/py-record-btrace.c: Use C++ exception handling.
12264         * python/py-progspace.c: Use C++ exception handling.
12265         * python/py-prettyprint.c: Use C++ exception handling.
12266         * python/py-param.c: Use C++ exception handling.
12267         * python/py-objfile.c: Use C++ exception handling.
12268         * python/py-linetable.c: Use C++ exception handling.
12269         * python/py-lazy-string.c: Use C++ exception handling.
12270         * python/py-infthread.c: Use C++ exception handling.
12271         * python/py-inferior.c: Use C++ exception handling.
12272         * python/py-gdb-readline.c: Use C++ exception handling.
12273         * python/py-framefilter.c: Use C++ exception handling.
12274         * python/py-frame.c: Use C++ exception handling.
12275         * python/py-finishbreakpoint.c: Use C++ exception handling.
12276         * python/py-cmd.c: Use C++ exception handling.
12277         * python/py-breakpoint.c: Use C++ exception handling.
12278         * python/py-arch.c: Use C++ exception handling.
12279         * printcmd.c: Use C++ exception handling.
12280         * ppc-linux-tdep.c: Use C++ exception handling.
12281         * parse.c: Use C++ exception handling.
12282         * p-valprint.c: Use C++ exception handling.
12283         * objc-lang.c: Use C++ exception handling.
12284         * mi/mi-main.c: Use C++ exception handling.
12285         * mi/mi-interp.c: Use C++ exception handling.
12286         * mi/mi-cmd-stack.c: Use C++ exception handling.
12287         * mi/mi-cmd-break.c: Use C++ exception handling.
12288         * main.c: Use C++ exception handling.
12289         * linux-thread-db.c: Use C++ exception handling.
12290         * linux-tdep.c: Use C++ exception handling.
12291         * linux-nat.c: Use C++ exception handling.
12292         * linux-fork.c: Use C++ exception handling.
12293         * linespec.c: Use C++ exception handling.
12294         * language.c: Use C++ exception handling.
12295         * jit.c: Use C++ exception handling.
12296         * infrun.c: Use C++ exception handling.
12297         * infcmd.c: Use C++ exception handling.
12298         * infcall.c: Use C++ exception handling.
12299         * inf-loop.c: Use C++ exception handling.
12300         * i386-tdep.c: Use C++ exception handling.
12301         * i386-linux-tdep.c: Use C++ exception handling.
12302         * guile/scm-value.c: Use C++ exception handling.
12303         * guile/scm-type.c: Use C++ exception handling.
12304         * guile/scm-symtab.c: Use C++ exception handling.
12305         * guile/scm-symbol.c: Use C++ exception handling.
12306         * guile/scm-pretty-print.c: Use C++ exception handling.
12307         * guile/scm-ports.c: Use C++ exception handling.
12308         * guile/scm-param.c: Use C++ exception handling.
12309         * guile/scm-math.c: Use C++ exception handling.
12310         * guile/scm-lazy-string.c: Use C++ exception handling.
12311         * guile/scm-frame.c: Use C++ exception handling.
12312         * guile/scm-disasm.c: Use C++ exception handling.
12313         * guile/scm-cmd.c: Use C++ exception handling.
12314         * guile/scm-breakpoint.c: Use C++ exception handling.
12315         * guile/scm-block.c: Use C++ exception handling.
12316         * guile/guile-internal.h: Use C++ exception handling.
12317         * gnu-v3-abi.c: Use C++ exception handling.
12318         * gdbtypes.c: Use C++ exception handling.
12319         * frame.c: Use C++ exception handling.
12320         * frame-unwind.c: Use C++ exception handling.
12321         * fbsd-tdep.c: Use C++ exception handling.
12322         * f-valprint.c: Use C++ exception handling.
12323         * exec.c: Use C++ exception handling.
12324         * event-top.c: Use C++ exception handling.
12325         * event-loop.c: Use C++ exception handling.
12326         * eval.c: Use C++ exception handling.
12327         * dwarf2read.c: Use C++ exception handling.
12328         * dwarf2loc.c: Use C++ exception handling.
12329         * dwarf2-frame.c: Use C++ exception handling.
12330         * dwarf2-frame-tailcall.c: Use C++ exception handling.
12331         * dwarf-index-write.c: Use C++ exception handling.
12332         * dwarf-index-cache.c: Use C++ exception handling.
12333         * dtrace-probe.c: Use C++ exception handling.
12334         * disasm-selftests.c: Use C++ exception handling.
12335         * darwin-nat.c: Use C++ exception handling.
12336         * cp-valprint.c: Use C++ exception handling.
12337         * cp-support.c: Use C++ exception handling.
12338         * cp-abi.c: Use C++ exception handling.
12339         * corelow.c: Use C++ exception handling.
12340         * completer.c: Use C++ exception handling.
12341         * compile/compile-object-run.c: Use C++ exception handling.
12342         * compile/compile-object-load.c: Use C++ exception handling.
12343         * compile/compile-cplus-symbols.c: Use C++ exception handling.
12344         * compile/compile-c-symbols.c: Use C++ exception handling.
12345         * common/selftest.c: Use C++ exception handling.
12346         * common/new-op.c: Use C++ exception handling.
12347         * cli/cli-script.c: Use C++ exception handling.
12348         * cli/cli-interp.c: Use C++ exception handling.
12349         * cli/cli-cmds.c: Use C++ exception handling.
12350         * c-varobj.c: Use C++ exception handling.
12351         * btrace.c: Use C++ exception handling.
12352         * breakpoint.c: Use C++ exception handling.
12353         * break-catch-throw.c: Use C++ exception handling.
12354         * arch-utils.c: Use C++ exception handling.
12355         * amd64-tdep.c: Use C++ exception handling.
12356         * ada-valprint.c: Use C++ exception handling.
12357         * ada-typeprint.c: Use C++ exception handling.
12358         * ada-lang.c: Use C++ exception handling.
12359         * aarch64-tdep.c: Use C++ exception handling.
12360
12361 2019-04-08  Tom Tromey  <tom@tromey.com>
12362
12363         * xml-support.c (gdb_xml_parser::parse): Update.
12364         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
12365         * value.c (show_convenience): Update.
12366         * unittests/cli-utils-selftests.c (test_number_or_range_parser)
12367         (test_parse_flags_qcs): Update.
12368         * thread.c (thr_try_catch_cmd): Update.
12369         * target.c (target_translate_tls_address): Update.
12370         * stack.c (print_frame_arg, read_frame_local, read_frame_arg)
12371         (info_frame_command_core, frame_apply_command_count): Update.
12372         * rust-exp.y (rust_lex_exception_test): Update.
12373         * riscv-tdep.c (riscv_print_one_register_info): Update.
12374         * remote.c (remote_target::enable_btrace): Update.
12375         * record-btrace.c (record_btrace_enable_warn): Update.
12376         * python/py-utils.c (gdbpy_convert_exception): Update.
12377         * printcmd.c (do_one_display, print_variable_and_value): Update.
12378         * mi/mi-main.c (mi_print_exception): Update.
12379         * mi/mi-interp.c (mi_cmd_interpreter_exec): Use SCOPE_EXIT.
12380         * mi/mi-cmd-stack.c (list_arg_or_local): Update.
12381         * linux-nat.c (linux_nat_target::attach): Update.
12382         * linux-fork.c (class scoped_switch_fork_info): Update.
12383         * infrun.c (displaced_step_prepare): Update.
12384         * infcall.c (call_function_by_hand_dummy): Update.
12385         * guile/scm-exception.c (gdbscm_scm_from_gdb_exception): Update.
12386         * gnu-v3-abi.c (print_one_vtable): Update.
12387         * frame.c (get_prev_frame_always): Update.
12388         * f-valprint.c (info_common_command_for_block): Update.
12389         * exec.c (try_open_exec_file): Update.
12390         * exceptions.c (print_exception, exception_print)
12391         (exception_fprintf, exception_print_same): Update.
12392         * dwarf2-frame.c (dwarf2_build_frame_info): Update.
12393         * dwarf-index-cache.c (index_cache::store)
12394         (index_cache::lookup_gdb_index): Update.
12395         * darwin-nat.c (maybe_cache_shell): Update.
12396         * cp-valprint.c (cp_print_value_fields): Update.
12397         * compile/compile-cplus-symbols.c (gcc_cplus_convert_symbol)
12398         (gcc_cplus_symbol_address): Update.
12399         * compile/compile-c-symbols.c (gcc_convert_symbol)
12400         (gcc_symbol_address, generate_c_for_for_one_variable): Update.
12401         * common/selftest.c: Update.
12402         * common/common-exceptions.h (struct gdb_exception) <message>: Now
12403         a std::string.
12404         (exception_try_scope_entry, exception_try_scope_exit): Don't
12405         declare.
12406         (struct exception_try_scope): Remove.
12407         (TRY): Don't use exception_try_scope.
12408         (struct gdb_exception): Add constructor, operator=.
12409         <what>: New method.
12410         (struct gdb_exception_RETURN_MASK_ALL)
12411         (struct gdb_exception_RETURN_MASK_ERROR)
12412         (struct gdb_exception_RETURN_MASK_QUIT): Add constructor.
12413         (struct gdb_quit_bad_alloc): Update.
12414         * common/common-exceptions.c (exception_none): Change
12415         initializer.
12416         (struct catcher) <state, exception>: Initialize inline.
12417         <prev>: Remove member.
12418         (current_catcher): Remove.
12419         (catchers): New global.
12420         (exceptions_state_mc_init): Simplify.
12421         (catcher_pop): Remove.
12422         (exceptions_state_mc, exceptions_state_mc_catch): Update.
12423         (try_scope_depth, exception_try_scope_entry)
12424         (exception_try_scope_exit): Remove.
12425         (throw_exception_sjlj): Update.
12426         (exception_messages, exception_messages_size): Remove.
12427         (throw_it): Simplify.
12428         (gdb_exception_sliced_copy): Remove.
12429         (throw_exception_cxx): Update.
12430         * cli/cli-script.c (script_from_file): Update.
12431         * breakpoint.c (insert_bp_location, update_breakpoint_locations):
12432         Update.
12433         * ada-valprint.c (ada_val_print): Update.
12434         * ada-lang.c (ada_to_fixed_type_1, ada_exception_name_addr)
12435         (create_excep_cond_exprs): Update.
12436
12437 2019-04-08  Tom Tromey  <tom@tromey.com>
12438
12439         * common/common-exceptions.h (GDB_XCPT_SJMP, GDB_XCPT_TRY)
12440         (GDB_XCPT_RAW_TRY, GDB_XCPT): Remove.
12441         (TRY, CATCH, END_CATCH): Remove some definitions.
12442         * common/common-exceptions.c: Don't use GDB_XCPT.
12443         (catcher_list_size): Remove.
12444         (throw_exception, throw_it): Simplify.
12445
12446 2019-04-05  Tom Tromey  <tom@tromey.com>
12447
12448         Revert the header-sorting patch.
12449         * ft32-tdep.c: Revert.
12450         * frv-tdep.c: Revert.
12451         * frv-linux-tdep.c: Revert.
12452         * frame.c: Revert.
12453         * frame-unwind.c: Revert.
12454         * frame-base.c: Revert.
12455         * fork-child.c: Revert.
12456         * findvar.c: Revert.
12457         * findcmd.c: Revert.
12458         * filesystem.c: Revert.
12459         * filename-seen-cache.h: Revert.
12460         * filename-seen-cache.c: Revert.
12461         * fbsd-tdep.c: Revert.
12462         * fbsd-nat.h: Revert.
12463         * fbsd-nat.c: Revert.
12464         * f-valprint.c: Revert.
12465         * f-typeprint.c: Revert.
12466         * f-lang.c: Revert.
12467         * extension.h: Revert.
12468         * extension.c: Revert.
12469         * extension-priv.h: Revert.
12470         * expprint.c: Revert.
12471         * exec.h: Revert.
12472         * exec.c: Revert.
12473         * exceptions.c: Revert.
12474         * event-top.c: Revert.
12475         * event-loop.c: Revert.
12476         * eval.c: Revert.
12477         * elfread.c: Revert.
12478         * dwarf2read.h: Revert.
12479         * dwarf2read.c: Revert.
12480         * dwarf2loc.c: Revert.
12481         * dwarf2expr.h: Revert.
12482         * dwarf2expr.c: Revert.
12483         * dwarf2-frame.c: Revert.
12484         * dwarf2-frame-tailcall.c: Revert.
12485         * dwarf-index-write.h: Revert.
12486         * dwarf-index-write.c: Revert.
12487         * dwarf-index-common.c: Revert.
12488         * dwarf-index-cache.h: Revert.
12489         * dwarf-index-cache.c: Revert.
12490         * dummy-frame.c: Revert.
12491         * dtrace-probe.c: Revert.
12492         * disasm.h: Revert.
12493         * disasm.c: Revert.
12494         * disasm-selftests.c: Revert.
12495         * dictionary.c: Revert.
12496         * dicos-tdep.c: Revert.
12497         * demangle.c: Revert.
12498         * dcache.h: Revert.
12499         * dcache.c: Revert.
12500         * darwin-nat.h: Revert.
12501         * darwin-nat.c: Revert.
12502         * darwin-nat-info.c: Revert.
12503         * d-valprint.c: Revert.
12504         * d-namespace.c: Revert.
12505         * d-lang.c: Revert.
12506         * ctf.c: Revert.
12507         * csky-tdep.c: Revert.
12508         * csky-linux-tdep.c: Revert.
12509         * cris-tdep.c: Revert.
12510         * cris-linux-tdep.c: Revert.
12511         * cp-valprint.c: Revert.
12512         * cp-support.c: Revert.
12513         * cp-namespace.c: Revert.
12514         * cp-abi.c: Revert.
12515         * corelow.c: Revert.
12516         * corefile.c: Revert.
12517         * continuations.c: Revert.
12518         * completer.h: Revert.
12519         * completer.c: Revert.
12520         * complaints.c: Revert.
12521         * coffread.c: Revert.
12522         * coff-pe-read.c: Revert.
12523         * cli-out.h: Revert.
12524         * cli-out.c: Revert.
12525         * charset.c: Revert.
12526         * c-varobj.c: Revert.
12527         * c-valprint.c: Revert.
12528         * c-typeprint.c: Revert.
12529         * c-lang.c: Revert.
12530         * buildsym.c: Revert.
12531         * buildsym-legacy.c: Revert.
12532         * build-id.h: Revert.
12533         * build-id.c: Revert.
12534         * btrace.c: Revert.
12535         * bsd-uthread.c: Revert.
12536         * breakpoint.h: Revert.
12537         * breakpoint.c: Revert.
12538         * break-catch-throw.c: Revert.
12539         * break-catch-syscall.c: Revert.
12540         * break-catch-sig.c: Revert.
12541         * blockframe.c: Revert.
12542         * block.c: Revert.
12543         * bfin-tdep.c: Revert.
12544         * bfin-linux-tdep.c: Revert.
12545         * bfd-target.c: Revert.
12546         * bcache.c: Revert.
12547         * ax-general.c: Revert.
12548         * ax-gdb.h: Revert.
12549         * ax-gdb.c: Revert.
12550         * avr-tdep.c: Revert.
12551         * auxv.c: Revert.
12552         * auto-load.c: Revert.
12553         * arm-wince-tdep.c: Revert.
12554         * arm-tdep.c: Revert.
12555         * arm-symbian-tdep.c: Revert.
12556         * arm-pikeos-tdep.c: Revert.
12557         * arm-obsd-tdep.c: Revert.
12558         * arm-nbsd-tdep.c: Revert.
12559         * arm-nbsd-nat.c: Revert.
12560         * arm-linux-tdep.c: Revert.
12561         * arm-linux-nat.c: Revert.
12562         * arm-fbsd-tdep.c: Revert.
12563         * arm-fbsd-nat.c: Revert.
12564         * arm-bsd-tdep.c: Revert.
12565         * arch-utils.c: Revert.
12566         * arc-tdep.c: Revert.
12567         * arc-newlib-tdep.c: Revert.
12568         * annotate.h: Revert.
12569         * annotate.c: Revert.
12570         * amd64-windows-tdep.c: Revert.
12571         * amd64-windows-nat.c: Revert.
12572         * amd64-tdep.c: Revert.
12573         * amd64-sol2-tdep.c: Revert.
12574         * amd64-obsd-tdep.c: Revert.
12575         * amd64-obsd-nat.c: Revert.
12576         * amd64-nbsd-tdep.c: Revert.
12577         * amd64-nbsd-nat.c: Revert.
12578         * amd64-nat.c: Revert.
12579         * amd64-linux-tdep.c: Revert.
12580         * amd64-linux-nat.c: Revert.
12581         * amd64-fbsd-tdep.c: Revert.
12582         * amd64-fbsd-nat.c: Revert.
12583         * amd64-dicos-tdep.c: Revert.
12584         * amd64-darwin-tdep.c: Revert.
12585         * amd64-bsd-nat.c: Revert.
12586         * alpha-tdep.c: Revert.
12587         * alpha-obsd-tdep.c: Revert.
12588         * alpha-nbsd-tdep.c: Revert.
12589         * alpha-mdebug-tdep.c: Revert.
12590         * alpha-linux-tdep.c: Revert.
12591         * alpha-linux-nat.c: Revert.
12592         * alpha-bsd-tdep.c: Revert.
12593         * alpha-bsd-nat.c: Revert.
12594         * aix-thread.c: Revert.
12595         * agent.c: Revert.
12596         * addrmap.c: Revert.
12597         * ada-varobj.c: Revert.
12598         * ada-valprint.c: Revert.
12599         * ada-typeprint.c: Revert.
12600         * ada-tasks.c: Revert.
12601         * ada-lang.c: Revert.
12602         * aarch64-tdep.c: Revert.
12603         * aarch64-ravenscar-thread.c: Revert.
12604         * aarch64-newlib-tdep.c: Revert.
12605         * aarch64-linux-tdep.c: Revert.
12606         * aarch64-linux-nat.c: Revert.
12607         * aarch64-fbsd-tdep.c: Revert.
12608         * aarch64-fbsd-nat.c: Revert.
12609         * aarch32-linux-nat.c: Revert.
12610
12611 2019-04-05  Tom Tromey  <tom@tromey.com>
12612
12613         * ft32-tdep.c: Sort headers.
12614         * frv-tdep.c: Sort headers.
12615         * frv-linux-tdep.c: Sort headers.
12616         * frame.c: Sort headers.
12617         * frame-unwind.c: Sort headers.
12618         * frame-base.c: Sort headers.
12619         * fork-child.c: Sort headers.
12620         * findvar.c: Sort headers.
12621         * findcmd.c: Sort headers.
12622         * filesystem.c: Sort headers.
12623         * filename-seen-cache.h: Sort headers.
12624         * filename-seen-cache.c: Sort headers.
12625         * fbsd-tdep.c: Sort headers.
12626         * fbsd-nat.h: Sort headers.
12627         * fbsd-nat.c: Sort headers.
12628         * f-valprint.c: Sort headers.
12629         * f-typeprint.c: Sort headers.
12630         * f-lang.c: Sort headers.
12631         * extension.h: Sort headers.
12632         * extension.c: Sort headers.
12633         * extension-priv.h: Sort headers.
12634         * expprint.c: Sort headers.
12635         * exec.h: Sort headers.
12636         * exec.c: Sort headers.
12637         * exceptions.c: Sort headers.
12638         * event-top.c: Sort headers.
12639         * event-loop.c: Sort headers.
12640         * eval.c: Sort headers.
12641         * elfread.c: Sort headers.
12642         * dwarf2read.h: Sort headers.
12643         * dwarf2read.c: Sort headers.
12644         * dwarf2loc.c: Sort headers.
12645         * dwarf2expr.h: Sort headers.
12646         * dwarf2expr.c: Sort headers.
12647         * dwarf2-frame.c: Sort headers.
12648         * dwarf2-frame-tailcall.c: Sort headers.
12649         * dwarf-index-write.h: Sort headers.
12650         * dwarf-index-write.c: Sort headers.
12651         * dwarf-index-common.c: Sort headers.
12652         * dwarf-index-cache.h: Sort headers.
12653         * dwarf-index-cache.c: Sort headers.
12654         * dummy-frame.c: Sort headers.
12655         * dtrace-probe.c: Sort headers.
12656         * disasm.h: Sort headers.
12657         * disasm.c: Sort headers.
12658         * disasm-selftests.c: Sort headers.
12659         * dictionary.c: Sort headers.
12660         * dicos-tdep.c: Sort headers.
12661         * demangle.c: Sort headers.
12662         * dcache.h: Sort headers.
12663         * dcache.c: Sort headers.
12664         * darwin-nat.h: Sort headers.
12665         * darwin-nat.c: Sort headers.
12666         * darwin-nat-info.c: Sort headers.
12667         * d-valprint.c: Sort headers.
12668         * d-namespace.c: Sort headers.
12669         * d-lang.c: Sort headers.
12670         * ctf.c: Sort headers.
12671         * csky-tdep.c: Sort headers.
12672         * csky-linux-tdep.c: Sort headers.
12673         * cris-tdep.c: Sort headers.
12674         * cris-linux-tdep.c: Sort headers.
12675         * cp-valprint.c: Sort headers.
12676         * cp-support.c: Sort headers.
12677         * cp-namespace.c: Sort headers.
12678         * cp-abi.c: Sort headers.
12679         * corelow.c: Sort headers.
12680         * corefile.c: Sort headers.
12681         * continuations.c: Sort headers.
12682         * completer.h: Sort headers.
12683         * completer.c: Sort headers.
12684         * complaints.c: Sort headers.
12685         * coffread.c: Sort headers.
12686         * coff-pe-read.c: Sort headers.
12687         * cli-out.h: Sort headers.
12688         * cli-out.c: Sort headers.
12689         * charset.c: Sort headers.
12690         * c-varobj.c: Sort headers.
12691         * c-valprint.c: Sort headers.
12692         * c-typeprint.c: Sort headers.
12693         * c-lang.c: Sort headers.
12694         * buildsym.c: Sort headers.
12695         * buildsym-legacy.c: Sort headers.
12696         * build-id.h: Sort headers.
12697         * build-id.c: Sort headers.
12698         * btrace.c: Sort headers.
12699         * bsd-uthread.c: Sort headers.
12700         * breakpoint.h: Sort headers.
12701         * breakpoint.c: Sort headers.
12702         * break-catch-throw.c: Sort headers.
12703         * break-catch-syscall.c: Sort headers.
12704         * break-catch-sig.c: Sort headers.
12705         * blockframe.c: Sort headers.
12706         * block.c: Sort headers.
12707         * bfin-tdep.c: Sort headers.
12708         * bfin-linux-tdep.c: Sort headers.
12709         * bfd-target.c: Sort headers.
12710         * bcache.c: Sort headers.
12711         * ax-general.c: Sort headers.
12712         * ax-gdb.h: Sort headers.
12713         * ax-gdb.c: Sort headers.
12714         * avr-tdep.c: Sort headers.
12715         * auxv.c: Sort headers.
12716         * auto-load.c: Sort headers.
12717         * arm-wince-tdep.c: Sort headers.
12718         * arm-tdep.c: Sort headers.
12719         * arm-symbian-tdep.c: Sort headers.
12720         * arm-pikeos-tdep.c: Sort headers.
12721         * arm-obsd-tdep.c: Sort headers.
12722         * arm-nbsd-tdep.c: Sort headers.
12723         * arm-nbsd-nat.c: Sort headers.
12724         * arm-linux-tdep.c: Sort headers.
12725         * arm-linux-nat.c: Sort headers.
12726         * arm-fbsd-tdep.c: Sort headers.
12727         * arm-fbsd-nat.c: Sort headers.
12728         * arm-bsd-tdep.c: Sort headers.
12729         * arch-utils.c: Sort headers.
12730         * arc-tdep.c: Sort headers.
12731         * arc-newlib-tdep.c: Sort headers.
12732         * annotate.h: Sort headers.
12733         * annotate.c: Sort headers.
12734         * amd64-windows-tdep.c: Sort headers.
12735         * amd64-windows-nat.c: Sort headers.
12736         * amd64-tdep.c: Sort headers.
12737         * amd64-sol2-tdep.c: Sort headers.
12738         * amd64-obsd-tdep.c: Sort headers.
12739         * amd64-obsd-nat.c: Sort headers.
12740         * amd64-nbsd-tdep.c: Sort headers.
12741         * amd64-nbsd-nat.c: Sort headers.
12742         * amd64-nat.c: Sort headers.
12743         * amd64-linux-tdep.c: Sort headers.
12744         * amd64-linux-nat.c: Sort headers.
12745         * amd64-fbsd-tdep.c: Sort headers.
12746         * amd64-fbsd-nat.c: Sort headers.
12747         * amd64-dicos-tdep.c: Sort headers.
12748         * amd64-darwin-tdep.c: Sort headers.
12749         * amd64-bsd-nat.c: Sort headers.
12750         * alpha-tdep.c: Sort headers.
12751         * alpha-obsd-tdep.c: Sort headers.
12752         * alpha-nbsd-tdep.c: Sort headers.
12753         * alpha-mdebug-tdep.c: Sort headers.
12754         * alpha-linux-tdep.c: Sort headers.
12755         * alpha-linux-nat.c: Sort headers.
12756         * alpha-bsd-tdep.c: Sort headers.
12757         * alpha-bsd-nat.c: Sort headers.
12758         * aix-thread.c: Sort headers.
12759         * agent.c: Sort headers.
12760         * addrmap.c: Sort headers.
12761         * ada-varobj.c: Sort headers.
12762         * ada-valprint.c: Sort headers.
12763         * ada-typeprint.c: Sort headers.
12764         * ada-tasks.c: Sort headers.
12765         * ada-lang.c: Sort headers.
12766         * aarch64-tdep.c: Sort headers.
12767         * aarch64-ravenscar-thread.c: Sort headers.
12768         * aarch64-newlib-tdep.c: Sort headers.
12769         * aarch64-linux-tdep.c: Sort headers.
12770         * aarch64-linux-nat.c: Sort headers.
12771         * aarch64-fbsd-tdep.c: Sort headers.
12772         * aarch64-fbsd-nat.c: Sort headers.
12773         * aarch32-linux-nat.c: Sort headers.
12774
12775 2019-04-04  Tom Tromey  <tom@tromey.com>
12776
12777         * varobj.c (varobj_create): Update.
12778         * rust-exp.y (struct rust_parser) <update_innermost_block,
12779         lookup_symbol>: New methods.
12780         (rust_parser::update_innermost_block, rust_parser::lookup_symbol):
12781         Rename.
12782         (rust_parser::rust_lookup_type)
12783         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12784         * printcmd.c (display_command, do_one_display): Update.
12785         * parser-defs.h (struct parser_state) <parser_state>: Add
12786         "tracker" parameter.
12787         (block_tracker): New member.
12788         (class innermost_block_tracker) <innermost_block_tracker>: Add
12789         "types" parameter.
12790         <reset>: Remove method.
12791         (innermost_block): Don't declare.
12792         (null_post_parser): Update.
12793         * parse.c (innermost_block): Remove global.
12794         (write_dollar_variable): Update.
12795         (parse_exp_1, parse_exp_in_context): Add "tracker" parameter.
12796         Remove "tracker_types" parameter.
12797         (parse_expression): Add "tracker" parameter.
12798         (parse_expression_for_completion): Update.
12799         (null_post_parser): Add "tracker" parameter.
12800         * p-exp.y: Update rules.
12801         * m2-exp.y: Update rules.
12802         * language.h (struct language_defn) <la_post_parser>: Add
12803         "tracker" parameter.
12804         * go-exp.y: Update rules.
12805         * f-exp.y: Update rules.
12806         * expression.h (parse_expression, parse_exp_1): Add "tracker"
12807         parameter.
12808         * d-exp.y: Update rules.
12809         * c-exp.y: Update rules.
12810         * breakpoint.c (set_breakpoint_condition): Create an
12811         innermost_block_tracker.
12812         (watch_command_1): Likewise.
12813         * ada-lang.c (resolve): Add "tracker" parameter.
12814         (resolve_subexp): Likewise.
12815         * ada-exp.y (write_var_from_sym): Update.
12816
12817 2019-04-04  Tom Tromey  <tom@tromey.com>
12818
12819         * type-stack.h: New file.
12820         * type-stack.c: New file.
12821         * parser-defs.h (enum type_pieces, union type_stack_elt): Move to
12822         type-stack.h.
12823         (insert_into_type_stack, insert_type, push_type, push_type_int)
12824         (insert_type_address_space, pop_type, pop_type_int)
12825         (pop_typelist, pop_type_stack, append_type_stack)
12826         (push_type_stack, get_type_stack, push_typelist)
12827         (follow_type_instance_flags, follow_types): Don't declare.
12828         * parse.c (type_stack): Remove global.
12829         (parse_exp_in_context): Update.
12830         (insert_into_type_stack, insert_type, push_type, push_type_int)
12831         (insert_type_address_space, pop_type, pop_type_int)
12832         (pop_typelist, pop_type_stack, append_type_stack)
12833         (push_type_stack, get_type_stack, push_typelist)
12834         (follow_type_instance_flags, follow_types): Remove (moved to
12835         type-stack.c).
12836         * f-exp.y (type_stack): New global.
12837         Update rules.
12838         (push_kind_type, f_parse): Update.
12839         * d-exp.y (type_stack): New global.
12840         Update rules.
12841         (d_parse): Update.
12842         * c-exp.y (struct c_parse_state) <type_stack>: New member.
12843         Update rules.
12844         * Makefile.in (COMMON_SFILES): Add type-stack.c.
12845         (HFILES_NO_SRCDIR): Add type-stack.h.
12846
12847 2019-04-04  Tom Tromey  <tom@tromey.com>
12848
12849         * rust-exp.y (rust_parser::lex_identifier, rustyylex)
12850         (rust_parser::convert_ast_to_expression, rust_parse)
12851         (rust_lex_test_completion, rust_lex_tests): Update.
12852         * parser-defs.h (struct expr_completion_state): New.
12853         (struct parser_state) <parser_state>: Add completion parameter.
12854         <mark_struct_expression, mark_completion_tag>: New methods.
12855         <parse_completion, m_completion_state>: New members.
12856         (prefixify_expression, null_post_parser): Update.
12857         (mark_struct_expression, mark_completion_tag): Don't declare.
12858         * parse.c (parse_completion, expout_last_struct)
12859         (expout_tag_completion_type, expout_completion_name): Remove
12860         globals.
12861         (parser_state::mark_struct_expression)
12862         (parser_state::mark_completion_tag): Now methods.
12863         (prefixify_expression): Add last_struct parameter.
12864         (prefixify_subexp): Likewise.
12865         (parse_exp_1): Update.
12866         (parse_exp_in_context): Add cstate parameter.  Update.
12867         (parse_expression_for_completion): Create an
12868         expr_completion_state.
12869         (null_post_parser): Add "completion" parameter.
12870         * p-exp.y: Update rules.
12871         (yylex): Update.
12872         * language.h (struct language_defn) <la_post_parser>: Add
12873         "completing" parameter.
12874         * go-exp.y: Update rules.
12875         (lex_one_token): Update.
12876         * expression.h (parse_completion): Don't declare.
12877         * d-exp.y: Update rules.
12878         (lex_one_token): Update rules.
12879         * c-exp.y: Update rules.
12880         (lex_one_token): Update.
12881         * ada-lang.c (resolve): Add "parse_completion" parameter.
12882         (resolve_subexp): Likewise.
12883         (ada_resolve_function): Likewise.
12884
12885 2019-04-04  Tom Tromey  <tom@tromey.com>
12886
12887         * parser-defs.h (struct parser_state) <start_arglist,
12888         end_arglist>: New methods.
12889         <arglist_len, m_funcall_chain>: New members.
12890         (arglist_len, start_arglist, end_arglist): Don't declare.
12891         * parse.c (arglist_len, funcall_chain): Remove global.
12892         (start_arglist, end_arglist): Remove functions.
12893         (parse_exp_in_context): Update.
12894         * p-exp.y: Update rules.
12895         * m2-exp.y: Update rules.
12896         * go-exp.y: Update rules.
12897         * f-exp.y: Update rules.
12898         * d-exp.y: Update rules.
12899         * c-exp.y: Update rules.
12900
12901 2019-04-04  Tom Tromey  <tom@tromey.com>
12902
12903         * rust-exp.y (struct rust_parser) <lex_hex, lex_escape,
12904         lex_operator, push_back>: New methods.
12905         Update all rules.
12906         (rust_parser::lex_hex, lex_escape): Rename and update.
12907         (rust_parser::lex_string, rust_parser::lex_identifier): Update.
12908         (rust_parser::lex_operator): Rename and update.
12909         (rust_parser::lex_number, rustyylex, rustyyerror)
12910         (rust_lex_test_init, rust_lex_test_sequence)
12911         (rust_lex_test_push_back, rust_lex_tests): Update.
12912         * parser-defs.h (struct parser_state) <parser_state>: Add "input"
12913         parameter.
12914         <lexptr, prev_lexptr>: New members.
12915         (lexptr, prev_lexptr): Don't declare.
12916         * parse.c (lexptr, prev_lexptr): Remove globals.
12917         (parse_exp_in_context): Update.
12918         * p-exp.y (yylex, yyerror): Update.
12919         * m2-exp.y (parse_number, yylex, yyerror): Update.
12920         * go-exp.y (lex_one_token, yyerror): Update.
12921         * f-exp.y (match_string_literal, yylex, yyerror): Update.
12922         * d-exp.y (lex_one_token, yyerror): Update.
12923         * c-exp.y (scan_macro_expansion, finished_macro_expansion)
12924         (lex_one_token, yyerror): Update.
12925         * ada-lex.l (YY_INPUT): Update.
12926         (rewind_to_char): Update.
12927         * ada-exp.y (yyerror): Update.
12928
12929 2019-04-04  Tom Tromey  <tom@tromey.com>
12930
12931         * rust-exp.y (rustyylex, rust_lex_tests): Update.
12932         * parser-defs.h (struct parser_state) <parser_state>: Add new
12933         parameter.
12934         <comma_terminates>: New member.
12935         (comma_terminates): Don't declare global.
12936         * parse.c (comma_terminates): Remove global.
12937         (parse_exp_in_context): Update.
12938         * p-exp.y (yylex): Update.
12939         * m2-exp.y (yylex): Update.
12940         * go-exp.y (lex_one_token): Update.
12941         * f-exp.y (yylex): Update.
12942         * d-exp.y (lex_one_token): Update.
12943         * c-exp.y (lex_one_token): Update.
12944         * ada-lex.l: Update.
12945
12946 2019-04-04  Tom Tromey  <tom@tromey.com>
12947
12948         * rust-exp.y (struct rust_parser) <paren_depth>: New member.
12949         (rustyylex, rust_lex_test_init, rust_lex_test_one)
12950         (rust_lex_test_sequence, rust_lex_test_push_back): Update.
12951         * parser-defs.h (paren_depth): Don't declare.
12952         * parse.c (paren_depth): Remove global.
12953         (parse_exp_in_context): Update.
12954         * p-exp.y (paren_depth): New global.
12955         (pascal_parse): Initialize it.
12956         * m2-exp.y (paren_depth): New global.
12957         (m2_parse): Initialize it.
12958         * go-exp.y (paren_depth): New global.
12959         (go_parse): Initialize it.
12960         * f-exp.y (paren_depth): New global.
12961         (f_parse): Initialize it.
12962         * d-exp.y (paren_depth): New global.
12963         (d_parse): Initialize it.
12964         * c-exp.y (paren_depth): New global.
12965         (c_parse): Initialize it.
12966         * ada-lex.l (paren_depth): New global.
12967         (lexer_init): Initialize it.
12968
12969 2019-04-04  Tom Tromey  <tom@tromey.com>
12970
12971         * rust-exp.y (rust_parser::crate_name, rust_parser::super_name)
12972         (rust_parser::convert_ast_to_type)
12973         (rust_parser::convert_ast_to_expression, rust_lex_tests): Update.
12974         * parser-defs.h (struct parser_state) <parser_state>: Add
12975         parameters.  Initialize new members.
12976         <expression_context_block, expression_context_pc>: New members.
12977         * parse.c (expression_context_block, expression_context_pc):
12978         Remove globals.
12979         (parse_exp_in_context): Update.
12980         * p-exp.y: Update all rules.
12981         (yylex): Update.
12982         * m2-exp.y: Update all rules.
12983         (yylex): Update.
12984         * go-exp.y (yylex): Update.
12985         * f-exp.y (yylex): Update.
12986         * d-exp.y: Update all rules.
12987         (yylex): Update.
12988         * c-exp.y: Update all rules.
12989         (lex_one_token, classify_name, yylex, c_parse): Update.
12990         * ada-exp.y (write_var_or_type, write_name_assoc): Update.
12991
12992 2019-04-04  Tom Tromey  <tom@tromey.com>
12993
12994         * gdbarch.h, gdbarch.c: Rebuild.
12995         * gdbarch.sh (dtrace_parse_probe_argument): Change type.
12996         * stap-probe.h:
12997         (struct stap_parse_info): Replace "parser_state" with
12998         "expr_builder".
12999         * parser-defs.h (struct expr_builder): Rename from "parser_state".
13000         (parser_state): New class.
13001         * parse.c (expr_builder): Rename.
13002         (expr_builder::release): Rename.
13003         (write_exp_elt, write_exp_elt_opcode, write_exp_elt_sym)
13004         (write_exp_elt_msym, write_exp_elt_block, write_exp_elt_objfile)
13005         (write_exp_elt_longcst, write_exp_elt_floatcst)
13006         (write_exp_elt_type, write_exp_elt_intern, write_exp_string)
13007         (write_exp_string_vector, write_exp_bitstring)
13008         (write_exp_msymbol, mark_struct_expression)
13009         (write_dollar_variable)
13010         (insert_type_address_space, increase_expout_size): Replace
13011         "parser_state" with "expr_builder".
13012         * dtrace-probe.c: Replace "parser_state" with "expr_builder".
13013         * amd64-linux-tdep.c (amd64_dtrace_parse_probe_argument): Replace
13014         "parser_state" with "expr_builder".
13015
13016 2019-04-04  Tom Tromey  <tom@tromey.com>
13017
13018         * rust-exp.y: Replace "parse_language" with method call.
13019         * p-exp.y:
13020         (yylex): Replace "parse_language" with method call.
13021         * m2-exp.y:
13022         (yylex): Replace "parse_language" with method call.
13023         * go-exp.y (classify_name): Replace "parse_language" with method
13024         call.
13025         * f-exp.y (yylex): Replace "parse_language" with method call.
13026         * d-exp.y (lex_one_token): Replace "parse_language" with method
13027         call.
13028         * c-exp.y:
13029         (lex_one_token, classify_name, yylex): Replace "parse_language"
13030         with method call.
13031         * ada-exp.y (find_primitive_type, type_char)
13032         (type_system_address): Replace "parse_language" with method call.
13033
13034 2019-04-04  Tom Tromey  <tom@tromey.com>
13035
13036         * rust-exp.y: Replace "parse_gdbarch" with method call.
13037         * parse.c (write_dollar_variable, insert_type_address_space):
13038         Replace "parse_gdbarch" with method call.
13039         * p-exp.y (parse_type, yylex): Replace "parse_gdbarch" with method
13040         call.
13041         * objc-lang.c (end_msglist): Replace "parse_gdbarch" with method
13042         call.
13043         * m2-exp.y (parse_type, parse_m2_type, yylex): Replace
13044         "parse_gdbarch" with method call.
13045         * go-exp.y (parse_type, classify_name): Replace "parse_gdbarch"
13046         with method call.
13047         * f-exp.y (parse_type, parse_f_type, yylex): Replace
13048         "parse_gdbarch" with method call.
13049         * d-exp.y (parse_type, parse_d_type, lex_one_token): Replace
13050         "parse_gdbarch" with method call.
13051         * c-exp.y (parse_type, parse_number, classify_name): Replace
13052         "parse_gdbarch" with method call.
13053         * ada-lex.l: Replace "parse_gdbarch" with method call.
13054         * ada-exp.y (parse_type, find_primitive_type, type_char)
13055         (type_system_address): Replace "parse_gdbarch" with method call.
13056
13057 2019-04-04  Tom Tromey  <tom@tromey.com>
13058
13059         * dtrace-probe.c (dtrace_probe::build_arg_exprs): Update.
13060         * stap-probe.c (stap_parse_argument): Update.
13061         * stap-probe.h (struct stap_parse_info) <stap_parse_info>: Remove
13062         initial_size parameter.
13063         * rust-exp.y (rust_lex_tests): Update.
13064         * parse.c (parser_state): Update.
13065         (parse_exp_in_context): Update.
13066         * parser-defs.h (struct parser_state) <parser_state>: Remove
13067         "initial_size" parameter.
13068
13069 2019-04-04  Tom Tromey  <tom@tromey.com>
13070
13071         * parser-defs.h (increase_expout_size): Don't declare.
13072         * parse.c (increase_expout_size): Now static.
13073
13074 2019-04-04  Thomas Schwinge  <thomas@codesourcery.com>
13075
13076         * gnu-nat.c (gnu_nat_target::wait): Fix
13077         target_waitstatus_to_string call.
13078
13079 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13080
13081         * eval.c (evaluate_subexp_standard): Handle internal functions
13082         during Fortran function call handling.
13083
13084 2019-04-01  Andrew Burgess  <andrew.burgess@embecosm.com>
13085
13086         * NEWS: Mention new internal functions.
13087         * dwarf2read.c (dwarf2_init_complex_target_type): New function.
13088         (read_base_type): Use dwarf2_init_complex_target_type.
13089         * value.c (creal_internal_fn): New function.
13090         (cimag_internal_fn): New function.
13091         (_initialize_values): Register new internal functions.
13092
13093 2019-04-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13094
13095         * infrun.c (stop_all_threads): If debug_infrun, always
13096         trace the wait status after wait_one, using
13097         target_waitstatus_to_string and target_pid_to_str.
13098         (handle_inferior_event): Replace various trace of
13099         wait status kind by a single trace.
13100         * gdb/gnu-nat.c (gnu_nat_target::wait): Replace local
13101         wait status kind image by target_waitstatus_to_string.
13102         * target/waitstatus.c (target_waitstatus_to_string): Fix
13103         obsolete comment.
13104
13105 2019-04-01  Tom Tromey  <tromey@adacore.com>
13106
13107         PR symtab/23331:
13108         * dwarf2read.c (partial_die_info::read): Handle DW_AT_ranges.
13109
13110 2019-04-01  Sergio Durigan Junior  <sergiodj@redhat.com>
13111             Pedro Alves  <palves@redhat.com>
13112
13113         * top.c (quit_force): Call 'finalize_values'.
13114         * value.c (finalize_values): New function.
13115         * value.h (finalize_values): Declare.
13116
13117 2019-03-30  Eli Zaretskii  <eliz@gnu.org>
13118
13119         * NEWS: Announce $_gdb_major and $_gdb_minor.
13120
13121         * top.c (init_gdb_version_vars): New function.
13122         (gdb_init): Call init_gdb_version_vars.
13123
13124 2019-03-29  Tom Tromey  <tromey@adacore.com>
13125
13126         * printcmd.c (_initialize_printcmd): Add usage lines.  Update some
13127         help text.  Remove dead code.
13128
13129 2019-03-29  Keith Seitz  <keiths@redhat.com>
13130
13131         From Siddhesh Poyarekar:
13132         * f-lang.h (f77_get_upperbound): Return LONGEST.
13133         (f77_get_lowerbound): Likewise.
13134         * f-typeprint.c (f_type_print_varspec_suffix): Expand
13135         UPPER_BOUND and LOWER_BOUND to LONGEST.  Use plongest to format
13136         print them.
13137         (f_type_print_base): Expand UPPER_BOUND to LONGEST.  Use
13138         plongest to format print it.
13139         * f-valprint.c (f77_get_lowerbound): Return LONGEST.
13140         (f77_get_upperbound): Likewise.
13141         (f77_get_dynamic_length_of_aggregate): Expand UPPER_BOUND,
13142         LOWER_BOUND to LONGEST.
13143         (f77_create_arrayprint_offset_tbl): Likewise.
13144
13145 2019-03-29  Keith Seitz  <keiths@redhat.com>
13146
13147         * ada-lang.c (ada_template_to_fixed_record_type_1): Use
13148         %s/pulongest for TYPE_LENGTH instead of %d in format
13149         strings.
13150         * ada-typerint.c (ada_print_type): Likewise.
13151         * amd64-windows-tdep.c (amd64_windows_store_arg_in_reg): Likewise.
13152         * compile/compile-c-support.c (generate_register_struct): Likewise.
13153         * gdbtypes.c (recursive_dump_type): Likewise.
13154         * gdbtypes.h (struct type) <length>: Change type to ULONGEST.
13155         * m2-typeprint.c (m2_array):  Use %s/pulongest for TYPE_LENGTH
13156         instead of %d in format strings.
13157         * riscv-tdep.c (riscv_type_alignment): Cast second argument
13158         to std::min to ULONGEST.
13159         * symmisc.c (print_symbol): Use %s/pulongest for TYPE_LENGTH
13160         instead of %d in format strings.
13161         * tracepoint.c (info_scope_command): Likewise.
13162         * typeprint.c (print_offset_data::update)
13163         (print_offset_data::finish): Likewise.
13164         * xtensa-tdep.c (xtensa_store_return_value)
13165         (xtensa_push_dummy_call): Likewise.
13166
13167 2019-03-28  Jon Turney  <jon.turney@dronecode.org.uk>
13168
13169         * windows-nat.c (display_selector): Fixed format specifications
13170         for 64-bit Cygwin.
13171
13172 2019-03-28  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13173
13174         * infrun.c (follow_exec): Call target_terminal::ours_for_output.
13175
13176 2019-03-28  Sandra Loosemore  <sandra@codesourcery.com>
13177
13178         * nios2-tdep.h (struct gdbarch_tdep): Add is_kernel_helper.
13179         * nios2-tdep.c (nios2_get_next_pc): Skip over kernel helpers.
13180         * nios2-linux-tdep.c (nios2_linux_is_kernel_helper): New.
13181         (nios2_linux_init_abi): Install it.
13182
13183 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13184
13185         * aarch64-tdep.c (aarch64_vnv_type): Use vector types.
13186
13187 2019-03-28  Alan Hayward  <alan.hayward@arm.com>
13188
13189         * features/aarch64-sve.c (create_feature_aarch64_sve): Add q view.
13190
13191 2019-03-24  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13192             Tom Tromey  <tromey@adacore.com>
13193
13194         * minsyms.c (minimal_symbol_upper_bound): Fix buffer overflow.
13195
13196 2019-03-26  Joel Brobecker  <brobecker@adacore.com>
13197
13198         * gdb-gdb.py.in (StructMainTypePrettyPrinter.bound_img): New method.
13199         (StructMainTypePrettyPrinter.bounds_img): Use new "bound_img"
13200         method to compute the bounds of range types. Also print "[evaluated]"
13201         if the bounds' values come from a dynamic evaluation.
13202
13203 2019-03-26  Andrew Burgess  <andrew.burgess@embecosm.com>
13204
13205         * cp-valprint.c (cp_print_value_fields): Don't print trailing
13206         whitespace when pretty printing is on.
13207
13208 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13209
13210         * ppc-linux-nat.c: Add include.
13211
13212 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13213
13214         * NEWS: Mention AArch64 Pointer Authentication.
13215
13216 2019-03-26  Alan Hayward  <alan.hayward@arm.com>
13217
13218         * arm-linux-nat.c: Add include.
13219
13220 2019-03-25  Simon Marchi  <simon.marchi@polymtl.ca>
13221
13222         * source-cache.c (source_cache::get_source_lines): Re-read
13223         fullname after calling open_source_file.
13224
13225 2019-03-25  John Baldwin  <jhb@FreeBSD.org>
13226
13227         * NEWS: Mention TLS support for FreeBSD.
13228
13229 2019-03-25  Tom Tromey  <tromey@adacore.com>
13230
13231         * minsyms.c (BUNCH_SIZE): Update comment.
13232         (~minimal_symbol_reader): Remove old comment.
13233         (compact_minimal_symbols): Update comment.
13234         (minimal_symbol_reader::install): Remove old comment.  Update
13235         other comments.
13236
13237 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13238
13239         * s390-linux-nat.c: Add include.
13240
13241 2019-03-25  Alan Hayward  <alan.hayward@arm.com>
13242
13243         * aarch64-linux-nat.c (aarch64_linux_nat_target::read_description):
13244         Call linux_get_hwcap.
13245         * aarch64-linux-tdep.c (aarch64_linux_core_read_description):
13246         Likewise.
13247         (aarch64_linux_get_hwcap): Remove function.
13248         * aarch64-linux-tdep.h (aarch64_linux_get_hwcap): Remove
13249         declaration.
13250         * arm-linux-nat.c (arm_linux_nat_target::read_description):Call
13251         linux_get_hwcap.
13252         * arm-linux-tdep.c (arm_linux_core_read_description): Likewise.
13253         * linux-tdep.c (linux_get_hwcap): Add function.
13254         (linux_get_hwcap2): Likewise.
13255         * linux-tdep.h (linux_get_hwcap): Add declaration.
13256         (linux_get_hwcap2): Likewise.
13257         * ppc-linux-nat.c (ppc_linux_get_hwcap): Remove function.
13258         (ppc_linux_get_hwcap2): Likewise.
13259         (ppc_linux_nat_target::region_ok_for_hw_watchpoint): Call
13260         linux_get_hwcap.
13261         (ppc_linux_nat_target::insert_watchpoint): Likewise.
13262         (ppc_linux_nat_target::watchpoint_addr_within_range): Likewise.
13263         (ppc_linux_nat_target::read_description): Likewise.
13264         * ppc-linux-tdep.c (ppc_linux_core_read_description): Likewise.
13265         * s390-linux-nat.c: Likewise.
13266         * s390-linux-tdep.c (s390_core_read_description): Likewise.
13267
13268 2019-03-24  Tom Tromey  <tom@tromey.com>
13269
13270         * ada-lang.c (standard_lookup): Simplify initialization.
13271         (ada_lookup_symbol_nonlocal): Simplify return.
13272         * solib-spu.c (spu_lookup_lib_symbol): Simplify return.
13273         * solib-darwin.c (darwin_lookup_lib_symbol): Simplify return.
13274         * solib-svr4.c (elf_lookup_lib_symbol): Simplify return.
13275         * rust-lang.c (rust_lookup_symbol_nonlocal): Simplify
13276         initialization.
13277         * solib.c (solib_global_lookup): Simplify.
13278         * symtab.c (null_block_symbol): Remove.
13279         (symbol_cache_lookup): Simplify returns.
13280         (lookup_language_this): Simplify returns.
13281         (lookup_symbol_aux): Simplify return.
13282         (lookup_local_symbol): Simplify returns.
13283         (lookup_global_symbol_from_objfile): Simplify return.
13284         (lookup_symbol_in_objfile_symtabs)
13285         (lookup_symbol_in_objfile_from_linkage_name): Simplify return.
13286         (lookup_symbol_via_quick_fns, lookup_symbol_in_static_block)
13287         (lookup_static_symbol, lookup_global_symbol): Simplify return.
13288         * cp-namespace.c (cp_lookup_bare_symbol)
13289         (cp_search_static_and_baseclasses, cp_lookup_symbol_via_imports)
13290         (cp_lookup_symbol_via_all_imports, cp_lookup_nested_symbol_1)
13291         (cp_lookup_nested_symbol): Don't use null_block_symbol.
13292         (cp_lookup_symbol_via_imports): Simplify initialization.
13293         (find_symbol_in_baseclass): Likewise.
13294         * symtab.h (null_block_symbol): Remove.
13295         * d-namespace.c (d_lookup_symbol): Don't use null_block_symbol.
13296         (d_lookup_nested_symbol, d_lookup_symbol_imports)
13297         (d_lookup_symbol_module): Likewise.
13298         (find_symbol_in_baseclass): Simplify initialization.
13299
13300 2019-03-24  Tom Tromey  <tom@tromey.com>
13301
13302         * expression.h: Don't include symtab.h.
13303         (struct block): Forward declare.
13304
13305 2019-03-24  Tom Tromey  <tom@tromey.com>
13306
13307         * c-exp.y (typebase): Remove casts.
13308         * gdbtypes.c (lookup_unsigned_typename, )
13309         (lookup_signed_typename): Remove cast.
13310         * eval.c (parse_to_comma_and_eval): Remove cast.
13311         * parse.c (write_dollar_variable): Remove cast.
13312         * block.h (struct block) <superblock>: Now const.
13313         * symfile-debug.c (debug_qf_map_matching_symbols): Update.
13314         * psymtab.c (psym_map_matching_symbols): Make "block" const.
13315         (map_block): Make "block" const.
13316         * symfile.h (struct quick_symbol_functions)
13317         <map_matching_symbols>: Constify block argument to "callback".
13318         * symtab.c (basic_lookup_transparent_type_quick): Make "block"
13319         const.
13320         (find_pc_sect_compunit_symtab): Make "b" const.
13321         (find_symbol_at_address): Likewise.
13322         (search_symbols): Likewise.
13323         * dwarf2read.c (dw2_lookup_symbol): Make "block" const.
13324         (dw2_debug_names_lookup_symbol): Likewise.
13325         (dw2_map_matching_symbols): Update.
13326         * p-valprint.c (pascal_val_print): Remove "block".
13327         * ada-lang.c (ada_add_global_exceptions): Make "b" const.
13328         (aux_add_nonlocal_symbols): Make "block" const.
13329         (resolve_subexp): Remove cast.
13330         * linespec.c (iterate_over_all_matching_symtabs): Make "block"
13331         const.
13332         (iterate_over_file_blocks): Likewise.
13333         * f-exp.y (%union) <bval>: Remove.
13334         * coffread.c (patch_opaque_types): Make "b" const.
13335         * spu-tdep.c (spu_catch_start): Make "block" const.
13336         * c-valprint.c (print_unpacked_pointer): Remove "block".
13337         * symmisc.c (dump_symtab_1): Make "b" const.
13338         (block_depth): Make "block" const.
13339         * d-exp.y (%union) <bval>: Remove.
13340         * cp-support.h (cp_lookup_rtti_type): Update.
13341         * cp-support.c (cp_lookup_rtti_type): Make "block" const.
13342         * psymtab.c (psym_lookup_symbol): Make "block" const.
13343         (maintenance_check_psymtabs): Make "b" const.
13344         * python/py-framefilter.c (extract_sym): Make "sym_block" const.
13345         (enumerate_locals, enumerate_args): Update.
13346         * python/py-symtab.c (stpy_global_block): Make "block" const.
13347         (stpy_static_block): Likewise.
13348         * inline-frame.c (block_starting_point_at): Make "new_block"
13349         const.
13350         * block.c (find_block_in_blockvector): Make return type const.
13351         (blockvector_for_pc_sect): Make "b" const.
13352         (find_block_in_blockvector): Make "b" const.
13353
13354 2019-03-23  Tom Tromey  <tom@tromey.com>
13355
13356         * varobj.c (varobj_create): Update.
13357         * symfile.c (clear_symtab_users): Don't reset innermost_block.
13358         * printcmd.c (display_command, do_one_display): Don't reset
13359         innermost_block.
13360         * parser-defs.h (enum innermost_block_tracker_type): Move to
13361         expression.h.
13362         (innermost_block): Update comment.
13363         * parse.c (parse_exp_1): Add tracker_types parameter.
13364         (parse_exp_in_context): Rename from parse_exp_in_context_1.  Add
13365         tracker_types parameter.  Reset innermost_block.
13366         (parse_exp_in_context): Remove.
13367         (parse_expression_for_completion): Update.
13368         * objfiles.c (~objfile): Don't reset expression_context_block or
13369         innermost_block.
13370         * expression.h (enum innermost_block_tracker_type): Move from
13371         parser-defs.h.
13372         (parse_exp_1): Add tracker_types parameter.
13373         * breakpoint.c (set_breakpoint_condition, watch_command_1): Don't
13374         reset innermost_block.
13375
13376 2019-03-23  Tom Tromey  <tom@tromey.com>
13377
13378         * objfiles.h: Include bcache.h.
13379
13380 2019-03-23  Tom Tromey  <tom@tromey.com>
13381
13382         * linespec.c (get_current_search_block): Use
13383         scoped_restore_current_language.
13384         * symmisc.c (dump_symtab): Use scoped_restore_current_language.
13385
13386 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13387             Jiong Wang  <jiong.wang@arm.com>
13388
13389         * aarch64-linux-tdep.c
13390         (aarch64_linux_iterate_over_regset_sections): Check for pauth
13391         section.
13392         * aarch64-linux-tdep.h (AARCH64_LINUX_SIZEOF_PAUTH): New define.
13393
13394 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13395             Jiong Wang  <jiong.wang@arm.com>
13396
13397         * aarch64-tdep.c (aarch64_analyze_prologue): Check for pauth
13398         instructions.
13399         (aarch64_analyze_prologue_test): Add PACIASP test.
13400         (aarch64_prologue_prev_register): Unmask PC value.
13401
13402 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13403             Jiong Wang  <jiong.wang@arm.com>
13404
13405         * aarch64-tdep.c (aarch64_frame_unmask_address): New function.
13406         (aarch64_dwarf2_prev_register): Unmask PC value.
13407         (aarch64_dwarf2_frame_init_reg): Init pauth registers.
13408         (aarch64_execute_dwarf_cfa_vendor_op): Check for
13409         DW_CFA_AARCH64_negate_ra_state.
13410         (aarch64_gdbarch_init): Add aarch64_execute_dwarf_cfa_vendor_op.
13411
13412 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13413             Jiong Wang  <jiong.wang@arm.com>
13414
13415         * aarch64-tdep.c (aarch64_dwarf_reg_to_regnum): Check for pauth
13416         registers.
13417         (aarch64_pseudo_register_name): Likewise.
13418         (aarch64_pseudo_register_type): Likewise.
13419         (aarch64_pseudo_register_reggroup_p): Likewise.
13420         (aarch64_gdbarch_init): Add pauth registers.
13421         * aarch64-tdep.h (AARCH64_DWARF_PAUTH_RA_STATE): New define.
13422         (AARCH64_DWARF_PAUTH_DMASK): Likewise.
13423         (AARCH64_DWARF_PAUTH_CMASK): Likewise.
13424         (struct gdbarch_tdep): Add regnum for ra_state.
13425
13426 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13427             Jiong Wang  <jiong.wang@arm.com>
13428
13429         * arch/aarch64.h (AARCH64_PAUTH_REGS_SIZE): New define.
13430
13431 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13432             Jiong Wang  <jiong.wang@arm.com>
13433
13434         * aarch64-linux-nat.c (fetch_pauth_masks_from_thread): New
13435         function.
13436         (aarch64_linux_nat_target::fetch_registers): Read pauth registers.
13437         * aarch64-tdep.c (aarch64_cannot_store_register): New function.
13438         (aarch64_gdbarch_init): Add puth registers.
13439         * aarch64-tdep.h (struct gdbarch_tdep): Add pauth features.
13440         * arch/aarch64.h (AARCH64_PAUTH_DMASK_REGNUM): New define.
13441         (AARCH64_PAUTH_CMASK_REGNUM): Likewise.
13442
13443 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13444             Jiong Wang  <jiong.wang@arm.com>
13445
13446         * aarch64-linux-nat.c
13447         (aarch64_linux_nat_target::read_description): Read PACA hwcap.
13448         * aarch64-linux-tdep.c
13449         (aarch64_linux_core_read_description): Likewise.
13450         (aarch64_linux_get_hwcap): New function.
13451         * aarch64-linux-tdep.h (AARCH64_HWCAP_PACA): New define.
13452         (aarch64_linux_get_hwcap): New declaration.
13453
13454 2019-03-22  Alan Hayward  <alan.hayward@arm.com>
13455             Jiong Wang  <jiong.wang@arm.com>
13456
13457         * aarch64-linux-nat.c
13458         (aarch64_linux_nat_target::read_description): Add pauth param.
13459         * aarch64-linux-tdep.c
13460         (aarch64_linux_core_read_description): Likewise.
13461         * aarch64-tdep.c (struct target_desc): Add in pauth.
13462         (aarch64_read_description): Add pauth param.
13463         (aarch64_gdbarch_init): Likewise.
13464         * aarch64-tdep.h (aarch64_read_description): Likewise.
13465         * arch/aarch64.c (aarch64_create_target_description): Likewise.
13466         * arch/aarch64.h (aarch64_create_target_description): Likewise.
13467         * features/Makefile: Add new files.
13468         * features/aarch64-pauth.c: New file.
13469         * features/aarch64-pauth.xml: New file.
13470
13471 2019-03-20  Tom Tromey  <tromey@adacore.com>
13472
13473         * infrun.c (handle_inferior_event): Rename from
13474         handle_inferior_event_1.  Create a scoped_value_mark.
13475         (handle_inferior_event): Remove.
13476
13477 2019-03-19  Tom Tromey  <tromey@adacore.com>
13478
13479         * mi/mi-interp.c (mi_on_normal_stop_1): Only show displays once.
13480         * infrun.h (print_stop_event): Add "displays" parameter.
13481         * infrun.c (print_stop_event): Add "displays" parameter.
13482
13483 2019-03-19  Pedro Alves  <palves@redhat.com>
13484
13485         * tui/tui-out.c (tui_ui_out::do_field_string): Simplify.
13486         (tui_ui_out::do_text): Add comments.  Reset M_LINE to 0 instead of
13487         to -1.  Fix TABs vs spaces.
13488         (tui_ui_out::tui_ui_out): Don't initialize fields here.
13489         * tui/tui-out.h (tui_ui_out) Add intro comments.
13490         <m_line, m_start_of_line>: In-class initialize, and add describing
13491         comment.
13492
13493 2019-03-18  Alan Hayward  <alan.hayward@arm.com>
13494
13495         * arm-linux-nat.c (arm_linux_insert_hw_breakpoint1): Fix
13496         variable names.
13497         (arm_linux_remove_hw_breakpoint1): Use a gdb::function_view.
13498
13499 2019-03-18  Pedro Alves  <palves@redhat.com>
13500             Eli Zaretskii <eliz@gnu.org>
13501
13502         * tui/tui-out.c (tui_ui_out::tui_ui_out): Fix initialization of
13503         m_line and m_start_of_line.
13504
13505 2019-03-18  Eli Zaretskii  <eliz@gnu.org>
13506
13507         * tui/tui-io.c (gdb_wgetch): Don't echo CR.
13508         (tui_getc): When gdb_wgetch returns a CR, behave the same as when
13509         it returns a newline.  This fixes a regression in TU mode, whereby
13510         the next line is output on the same screen line as the user input.
13511
13512 2019-03-18  Tom Tromey  <tromey@adacore.com>
13513
13514         * minsyms.c (minimal_symbol_reader::install): Remove call to
13515         obstack_blank.
13516
13517 2019-03-18  Pedro Alves  <palves@redhat.com>
13518
13519         * tui/tui-io.c (reverse_mode_p, reverse_save_bg, reverse_save_fg):
13520         New globals.
13521         (apply_style): New, factored out from ...
13522         (apply_ansi_escape): ... this.  Handle reverse video mode.
13523         (tui_set_reverse_mode): New function.
13524         * tui/tui-io.h (tui_set_reverse_mode): New declaration.
13525         * tui/tui-winsource.c (tui_show_source_line): Use
13526         tui_set_reverse_mode instead of setting A_STANDOUT.
13527         * ui-style.h (struct ui_file_style) <set_reverse, set_fg, set_bg>:
13528         New setter methods.
13529
13530 2019-03-18  Hannes Domani  <ssbssa@yahoo.de>
13531
13532         * tui/tui-source.c (copy_source_line): Fix handling of 'column'.
13533         Handle tabs.
13534
13535 2019-03-18  Tom Tromey  <tromey@adacore.com>
13536
13537         * ada-lang.c (empty_array): Add "high" parameter.
13538         (ada_evaluate_subexp): Update.
13539
13540 2019-03-17  Sergei Trofimovich <siarheit@google.com>
13541
13542         * unittests/string_view-selftests.c: Define
13543         _initialize_string_view_selftests unconditionally.
13544
13545 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13546
13547         PR gdb/24350
13548         * windows-nat.c (windows_make_so): Remove unused text_vma variable.
13549
13550 2019-03-17  Vladimir Martyanov  <vilgeforce@gmail.com>
13551
13552         PR gdb/24351
13553         * windows-nat.c (display_selector): Fix format specifiers.
13554
13555 2019-03-17  Eli Zaretskii  <eliz@gnu.org>
13556
13557         * tui/tui-winsource.c (tui_set_is_exec_point_at): Call
13558         tui_refill_source_window instead of tui_refresh_win, to update the
13559         current execution line.  This fixes redisplay of the current line
13560         when stepping through the code with "next" or "step".
13561
13562 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13563
13564         * source-cache.c (source_cache::get_source_lines): Call
13565         find_source_lines to initialize s->nlines.  This fixes vertical
13566         scrolling of TUI source window when the DOWN arrow is pressed.
13567
13568 2019-03-16  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
13569
13570         * auto-load.c (_initialize_auto_load): Fix 'This options has'.
13571         linux-thread-db.c (_initialize_thread_db): Likewise.
13572
13573 2019-03-16  Eli Zaretskii  <eliz@gnu.org>
13574
13575         * tui/tui-winsource.c (tui_show_source_line): Revert "Use
13576         wclrtoeol in tui_show_source_line".  This reverts changes made in
13577         commit 4a3045920bbe4e50a0f4920b0fdc4e88ef23015c.
13578
13579 2019-03-15  Tom Tromey  <tom@tromey.com>
13580
13581         * symtab.h (struct minimal_symbol): Derive from
13582         general_symbol_info.
13583         (MSYMBOL_VALUE, MSYMBOL_VALUE_RAW_ADDRESS)
13584         (MSYMBOL_VALUE_ADDRESS, MSYMBOL_VALUE_BYTES)
13585         (MSYMBOL_BLOCK_VALUE, MSYMBOL_VALUE_CHAIN, MSYMBOL_LANGUAGE)
13586         (MSYMBOL_SECTION, MSYMBOL_OBJ_SECTION, MSYMBOL_NATURAL_NAME)
13587         (MSYMBOL_LINKAGE_NAME, MSYMBOL_DEMANGLED_NAME)
13588         (MSYMBOL_SEARCH_NAME): Update.
13589         (MSYMBOL_SET_LANGUAGE, MSYMBOL_SET_NAMES): Remove.
13590         * solib.c (gdb_bfd_lookup_symbol_from_symtab): Don't use memset.
13591         * minsyms.c (minimal_symbol_reader::record_full): Update.
13592
13593 2019-03-15  Tom Tromey  <tom@tromey.com>
13594
13595         * minsyms.c (minimal_symbol_reader::install): Use memcpy.
13596
13597 2019-03-15  Tom Tromey  <tom@tromey.com>
13598
13599         * objfiles.h (struct objfile_per_bfd_storage) <msymbols>: Now a
13600         unique_xmalloc_ptr.
13601         (objfile::msymbols_range::begin, objfile::msymbols_range::end):
13602         Update.
13603         * minsyms.c (lookup_minimal_symbol_by_pc_section)
13604         (build_minimal_symbol_hash_tables)
13605         (minimal_symbol_reader::install): Update.
13606
13607 2019-03-15  Tom Tromey  <tom@tromey.com>
13608
13609         * symtab.c (create_demangled_names_hash): Update.
13610         (symbol_set_names): Update.
13611         * objfiles.h (struct objfile_per_bfd_storage)
13612         <demangled_names_hash>: Now an htab_up.
13613         * objfiles.c (objfile_per_bfd_storage): Simplify.
13614
13615 2019-03-15  Tom Tromey  <tom@tromey.com>
13616
13617         * objfiles.h (struct objfile_per_bfd_storage): Declare
13618         destructor.
13619         * objfiles.c (objfile_per_bfd_storage::~objfile_per_bfd_storage):
13620         New.
13621         (get_objfile_bfd_data): Use new.  Don't initialize
13622         language_of_main.
13623         (free_objfile_per_bfd_storage): Remove.
13624         (objfile_bfd_data_free, objfile::~objfile): Use delete.
13625
13626 2019-03-15  Tom Tromey  <tom@tromey.com>
13627
13628         * symfile.c (reread_symbols): Update.
13629         * objfiles.c (objfile::objfile): Update.
13630         * minsyms.h (terminate_minimal_symbol_table): Don't declare.
13631         * minsyms.c (lookup_minimal_symbol_by_pc_section): Update
13632         comment.
13633         (minimal_symbol_reader::install): Update.
13634         (terminate_minimal_symbol_table): Remove.
13635         * jit.c (jit_object_close_impl): Update.
13636
13637 2019-03-15  Tom Tromey  <tom@tromey.com>
13638
13639         * minsyms.c (minimal_symbol_reader::record_full): Remove some
13640         initializations.
13641
13642 2019-03-15  Tom Tromey  <tom@tromey.com>
13643
13644         * objfiles.h (struct objfile_per_bfd_storage)
13645         <demangled_hash_languages>: Now a bitset.
13646         * minsyms.c (add_minsym_to_demangled_hash_table): Update.
13647         (lookup_minimal_symbol): Update.
13648
13649 2019-03-15  Tom Tromey  <tom@tromey.com>
13650
13651         * minsyms.h (class minimal_symbol_reader) <record_with_info>:
13652         Don't return the symbol.
13653         * coffread.c (record_minimal_symbol): Use record_full.
13654
13655 2019-03-14  Eli Zaretskii  <eliz@gnu.org>
13656
13657         The MS-Windows port of ncurses fails to switch to a color pair if
13658         one or both of the colors are the implicit default colors.  This
13659         change records the default colors when TUI is initialized, and
13660         then specifies them explicitly when a color pair uses the default
13661         colors.  This allows color styling in TUI mode on MS-Windows.
13662
13663         * tui/tui-io.c [__MINGW32__]: Include windows.h.  Declare
13664         ncurses_norm_attr.
13665         (tui_initialize_io) [__MINGW32__]: Record the default terminal
13666         colors in ncurses_norm_attr.
13667         (apply_ansi_escape) [__MINGW32__]: If a color in a color pair is
13668         "none", replace it with the default color recorded in
13669         ncurses_norm_attr.
13670
13671 2019-03-14  Tom Tromey  <tromey@adacore.com>
13672
13673         * source-cache.h (class source_cache) <get_source_lines>: Return
13674         std::string.
13675         * source-cache.c (source_cache::extract_lines): Handle case where
13676         first_pos==npos.  Return std::string.
13677         (source_cache::get_source_lines): Update.
13678
13679 2019-03-14  Tom Tromey  <tromey@adacore.com>
13680
13681         * NEWS: Add item for "style sources" commands.
13682         * source-cache.c (source_cache::get_source_lines): Check
13683         source_styling.
13684         * cli/cli-style.c (source_styling): New global.
13685         (_initialize_cli_style): Add "style sources" commands.
13686         (show_style_sources): New function.
13687         * cli/cli-style.h (source_styling): Declare.
13688
13689 2019-03-14  Pedro Alves  <palves@redhat.com>
13690             Tom Tromey  <tromey@adacore.com>
13691
13692         * tui/tui-winsource.h (tui_refill_source_window): Declare.
13693         * tui/tui-winsource.c (tui_refill_source_window): New function,
13694         from...
13695         (tui_horizontal_source_scroll): ... here.  Move some logic.
13696         * cli/cli-style.c (set_style_enabled): Notify new observable.
13697         * tui/tui-hooks.c (tui_redisplay_source): New function.
13698         (tui_attach_detach_observers): Attach or detach
13699         tui_redisplay_source.
13700         * observable.h (source_styling_changed): New observable.
13701         * observable.c: Define source_styling_changed observable.
13702
13703 2019-03-13  Tom Tromey  <tromey@adacore.com>
13704
13705         * i386-gnu-nat.c (i386_gnu_nat_target::fetch_registers)
13706         (i386_gnu_nat_target::store_registers): Update.
13707         * target-debug.h (target_debug_print_std_string): New macro.
13708         * x86-linux-nat.c (x86_linux_nat_target::enable_btrace): Update.
13709         * windows-tdep.c (display_one_tib): Update.
13710         * tui/tui-stack.c (tui_make_status_line): Update.
13711         * top.c (print_inferior_quit_action): Update.
13712         * thread.c (thr_try_catch_cmd): Update.
13713         (add_thread_with_info): Update.
13714         (thread_target_id_str): Update.
13715         (thr_try_catch_cmd): Update.
13716         (thread_command): Update.
13717         (thread_find_command): Update.
13718         * record-btrace.c (record_btrace_target::info_record)
13719         (record_btrace_resume_thread, record_btrace_target::resume)
13720         (record_btrace_cancel_resume, record_btrace_step_thread)
13721         (record_btrace_target::wait, record_btrace_target::wait)
13722         (record_btrace_target::wait, record_btrace_target::stop): Update.
13723         * progspace.c (print_program_space): Update.
13724         * process-stratum-target.c
13725         (process_stratum_target::thread_address_space): Update.
13726         * linux-fork.c (linux_fork_mourn_inferior)
13727         (detach_checkpoint_command, info_checkpoints_command)
13728         (linux_fork_context): Update.
13729         (linux_fork_detach): Update.
13730         (class scoped_switch_fork_info): Update.
13731         (delete_checkpoint_command): Update.
13732         * infrun.c (follow_fork_inferior): Update.
13733         (follow_fork_inferior): Update.
13734         (proceed_after_vfork_done): Update.
13735         (handle_vfork_child_exec_or_exit): Update.
13736         (follow_exec): Update.
13737         (displaced_step_prepare_throw): Update.
13738         (displaced_step_restore): Update.
13739         (start_step_over): Update.
13740         (resume_1): Update.
13741         (clear_proceed_status_thread): Update.
13742         (proceed): Update.
13743         (print_target_wait_results): Update.
13744         (do_target_wait): Update.
13745         (context_switch): Update.
13746         (stop_all_threads): Update.
13747         (restart_threads): Update.
13748         (finish_step_over): Update.
13749         (handle_signal_stop): Update.
13750         (switch_back_to_stepped_thread): Update.
13751         (keep_going_pass_signal): Update.
13752         (print_exited_reason): Update.
13753         (normal_stop): Update.
13754         * inferior.c (inferior_pid_to_str): Change return type.
13755         (print_selected_inferior): Update.
13756         (add_inferior): Update.
13757         (detach_inferior): Update.
13758         * dummy-frame.c (fprint_dummy_frames): Update.
13759         * dcache.c (dcache_info_1): Update.
13760         * btrace.c (btrace_enable, btrace_disable, btrace_teardown)
13761         (btrace_fetch, btrace_clear): Update.
13762         * linux-tdep.c (linux_core_pid_to_str): Change return type.
13763         * i386-cygwin-tdep.c (i386_windows_core_pid_to_str): Change return
13764         type.
13765         * fbsd-tdep.c (fbsd_core_pid_to_str): Change return type.
13766         * sol2-tdep.h (sol2_core_pid_to_str): Change return type.
13767         * sol2-tdep.c (sol2_core_pid_to_str): Change return type.
13768         * gdbarch.c, gdbarch.h: Rebuild.
13769         * gdbarch.sh (core_pid_to_str): Change return type.
13770         * windows-nat.c (struct windows_nat_target) <pid_to_str>: Change
13771         return type.
13772         (windows_nat_target::pid_to_str): Change return type.
13773         (windows_delete_thread): Update.
13774         (windows_nat_target::attach): Update.
13775         (windows_nat_target::files_info): Update.
13776         * target-delegates.c: Rebuild.
13777         * sol-thread.c (class sol_thread_target) <pid_to_str>: Change
13778         return type.
13779         (sol_thread_target::pid_to_str): Change return type.
13780         * remote.c (class remote_target) <pid_to_str>: Change return
13781         type.
13782         (remote_target::pid_to_str): Change return type.
13783         (extended_remote_target::attach, remote_target::remote_stop_ns)
13784         (remote_target::remote_notif_remove_queued_reply)
13785         (remote_target::push_stop_reply, remote_target::disable_btrace):
13786         Update.
13787         (extended_remote_target::attach): Update.
13788         * remote-sim.c (struct gdbsim_target) <pid_to_str>: Change return
13789         type.
13790         (gdbsim_target::pid_to_str): Change return type.
13791         * ravenscar-thread.c (struct ravenscar_thread_target)
13792         <pid_to_str>: Change return type.
13793         (ravenscar_thread_target::pid_to_str): Change return type.
13794         * procfs.c (class procfs_target) <pid_to_str>: Change return
13795         type.
13796         (procfs_target::pid_to_str): Change return type.
13797         (procfs_target::attach): Update.
13798         (procfs_target::detach): Update.
13799         (procfs_target::fetch_registers): Update.
13800         (procfs_target::store_registers): Update.
13801         (procfs_target::wait): Update.
13802         (procfs_target::files_info): Update.
13803         * obsd-nat.c (obsd_nat_target::pid_to_str): Change return type.
13804         * nto-procfs.c (struct nto_procfs_target) <pid_to_str>: Change
13805         return type.
13806         (nto_procfs_target::pid_to_str): Change return type.
13807         (nto_procfs_target::files_info, nto_procfs_target::attach): Update.
13808         * linux-thread-db.c (class thread_db_target) <pid_to_str>: Change
13809         return type.
13810         * linux-nat.c (linux_nat_target::pid_to_str): Change return type.
13811         (exit_lwp): Update.
13812         (attach_proc_task_lwp_callback, get_detach_signal)
13813         (detach_one_lwp, resume_lwp, linux_nat_target::resume)
13814         (linux_nat_target::resume, wait_lwp, stop_callback)
13815         (maybe_clear_ignore_sigint, stop_wait_callback, status_callback)
13816         (save_stop_reason, select_event_lwp, linux_nat_filter_event)
13817         (linux_nat_wait_1, resume_stopped_resumed_lwps)
13818         (linux_nat_target::wait, linux_nat_stop_lwp): Update.
13819         * inf-ptrace.c (inf_ptrace_target::pid_to_str): Change return
13820         type.
13821         (inf_ptrace_target::attach): Update.
13822         (inf_ptrace_target::files_info): Update.
13823         * go32-nat.c (struct go32_nat_target) <pid_to_str>: Change return
13824         type.
13825         (go32_nat_target::pid_to_str): Change return type.
13826         * gnu-nat.c (gnu_nat_target::pid_to_str): Change return type.
13827         (gnu_nat_target::wait): Update.
13828         (gnu_nat_target::wait): Update.
13829         (gnu_nat_target::resume): Update.
13830         * fbsd-nat.c (fbsd_nat_target::pid_to_str): Change return type.
13831         (fbsd_nat_target::wait): Update.
13832         * darwin-nat.c (darwin_nat_target::pid_to_str): Change return
13833         type.
13834         (darwin_nat_target::attach): Update.
13835         * corelow.c (class core_target) <pid_to_str>: Change return type.
13836         (core_target::pid_to_str): Change return type.
13837         * target.c (normal_pid_to_str): Change return type.
13838         (default_pid_to_str): Likewise.
13839         (target_pid_to_str): Change return type.
13840         (target_translate_tls_address): Update.
13841         (target_announce_detach): Update.
13842         * bsd-uthread.c (struct bsd_uthread_target) <pid_to_str>: Change
13843         return type.
13844         (bsd_uthread_target::pid_to_str): Change return type.
13845         * bsd-kvm.c (class bsd_kvm_target) <pid_to_str>: Change return
13846         type.
13847         (bsd_kvm_target::pid_to_str): Change return type.
13848         * aix-thread.c (class aix_thread_target) <pid_to_str>: Change
13849         return type.
13850         (aix_thread_target::pid_to_str): Change return type.
13851         * target.h (struct target_ops) <pid_to_str>: Change return type.
13852         (target_pid_to_str, normal_pid_to_str): Likewise.
13853         * obsd-nat.h (class obsd_nat_target) <pid_to_str>: Change return
13854         type.
13855         * linux-nat.h (class linux_nat_target) <pid_to_str>: Change return
13856         type.
13857         * inf-ptrace.h (struct inf_ptrace_target) <pid_to_str>: Change
13858         return type.
13859         * gnu-nat.h (struct gnu_nat_target) <pid_to_str>: Change return
13860         type.
13861         * fbsd-nat.h (class fbsd_nat_target) <pid_to_str>: Change return
13862         type.
13863         * darwin-nat.h (class darwin_nat_target) <pid_to_str>: Change
13864         return type.
13865
13866 2019-03-13  Simon Marchi  <simon.marchi@ericsson.com>
13867
13868         * NEWS: Mention that the new default MI version is 3.  Mention
13869         changes to the output of commands and events that deal with
13870         multi-location breakpoints.
13871         * breakpoint.c: Include "mi/mi-out.h".
13872         (print_one_breakpoint): Change output syntax if using MI version
13873         >= 3.
13874         * mi/mi-main.h (mi_cmd_fix_multi_location_breakpoint_output):
13875         New.
13876         (mi_multi_location_breakpoint_output_fixed): New.
13877         * mi/mi-main.c (fix_multi_location_breakpoint_output): New.
13878         (mi_cmd_fix_multi_location_breakpoint_output): New.
13879         (mi_multi_location_breakpoint_output_fixed): New.
13880         * mi/mi-cmds.c (mi_cmds): Register command
13881         -fix-multi-location-breakpoint-output.
13882         * mi/mi-out.c (mi_out_new): Instantiate version 3 when using
13883         interpreter "mi".
13884
13885 2019-03-13  Simon Marchi  <simon.marchi@polymtl.ca>
13886
13887         * mi/mi-out.h (mi_out_new): Change parameter to const char *.
13888         * mi/mi-out.c (mi_out_new): Change parameter to const char *,
13889         instantiate mi_ui_out based on interpreter name.
13890         * mi/mi-interp.c (mi_interp::init): Use the new mi_out_new.
13891         * mi/mi-main.c (mi_load_progress): Likewise.
13892
13893 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13894
13895         * NEWS: Combine separate "New targets" sections for 8.3.
13896
13897 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13898
13899         * ppc-fbsd-tdep.c (ppcfbsd_get_thread_local_address): New.
13900         (ppcfbsd_init_abi): Install gdbarch
13901         "fetch_tls_load_module_address" and "get_thread_local_address"
13902         methods.
13903
13904 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13905
13906         * riscv-fbsd-tdep.c (riscv_fbsd_get_thread_local_address): New.
13907         (riscv_fbsd_init_abi): Install gdbarch
13908         "fetch_tls_load_module_address" and "get_thread_local_address"
13909         methods.
13910
13911 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13912
13913         * i386-fbsd-tdep.c (i386fbsd_get_thread_local_address): New.
13914         (i386fbsd_init_abi): Install gdbarch
13915         "fetch_tls_load_module_address" and "get_thread_local_address"
13916         methods.
13917
13918 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13919
13920         * amd64-fbsd-tdep.c (amd64fbsd_get_thread_local_address): New.
13921         (amd64fbsd_init_abi): Install gdbarch
13922         "fetch_tls_load_module_address" and "get_thread_local_address"
13923         methods.
13924
13925 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13926
13927         * fbsd-tdep.c (fbsd_pspace_data_handle): New variable.
13928         (struct fbsd_pspace_data): New type.
13929         (get_fbsd_pspace_data, fbsd_pspace_data_cleanup)
13930         (fbsd_read_integer_by_name, fbsd_fetch_rtld_offsets)
13931         (fbsd_get_tls_index, fbsd_get_thread_local_address): New function.
13932         (_initialize_fbsd_tdep): Initialize 'fbsd_pspace_data_handle'.
13933         * fbsd-tdep.c (fbsd_get_thread_local_address): New prototype.
13934
13935 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13936
13937         * gdbtypes.c (lookup_struct_elt): New function.
13938         (lookup_struct_elt_type): Reimplement via lookup_struct_elt.
13939         * gdbtypes.h (struct struct_elt): New type.
13940         (lookup_struct_elt): New prototype.
13941
13942 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13943
13944         * gdbtypes.c (lookup_struct_elt_type): Update comment and
13945         remove disabled code block.
13946
13947 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13948
13949         * gdbarch.sh (get_thread_local_address): New method.
13950         * gdbarch.h, gdbarch.c: Regenerate.
13951         * target.c (target_translate_tls_address): Use
13952         gdbarch_get_thread_local_address if present instead of
13953         target::get_thread_local_address.
13954
13955 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13956
13957         * target.h (target::get_thread_local_address): Update comment.
13958
13959 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13960
13961         * solib-svr4.c (svr4_fetch_objfile_link_map): Look for
13962         objfile->separate_debug_objfile_backlink if not NULL.
13963
13964 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13965
13966         * amd64-bsd-nat.c (amd64bsd_fetch_inferior_registers): Use
13967         tdep->fsbase_regnum instead of constants for fs_base and gs_base.
13968         (amd64bsd_store_inferior_registers): Likewise.
13969         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13970         Enable segment base registers.
13971         * i386-bsd-nat.c (i386bsd_fetch_inferior_registers): Use
13972         PT_GETFSBASE and PT_GETGSBASE.
13973         (i386bsd_store_inferior_registers): Use PT_SETFSBASE and
13974         PT_SETGSBASE.
13975         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Enable
13976         segment base registers.
13977         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13978
13979 2019-03-12  John Baldwin  <jhb@FreeBSD.org>
13980
13981         * amd64-fbsd-nat.c (amd64_fbsd_nat_target::read_description):
13982         Update calls to i386_target_description to add 'segments'
13983         parameter.
13984         * amd64-tdep.c (amd64_init_abi): Set tdep->fsbase_regnum.  Don't
13985         add segment base registers.
13986         * arch/i386.c (i386_create_target_description): Add 'segments'
13987         parameter to enable segment base registers.
13988         * arch/i386.h (i386_create_target_description): Likewise.
13989         * features/i386/32bit-segments.xml: New file.
13990         * features/i386/32bit-segments.c: Generate.
13991         * i386-fbsd-nat.c (i386_fbsd_nat_target::read_description): Update
13992         call to i386_target_description to add 'segments' parameter.
13993         * i386-fbsd-tdep.c (i386fbsd_core_read_description): Likewise.
13994         * i386-go32-tdep.c (i386_go32_init_abi): Likewise.
13995         * i386-linux-tdep.c (i386_linux_read_description): Likewise.
13996         * i386-tdep.c (i386_validate_tdesc_p): Add segment base registers
13997         if feature is present.
13998         (i386_gdbarch_init): Pass I386_NUM_REGS to set_gdbarch_num_regs.
13999         Add 'segments' parameter to call to i386_target_description.
14000         (i386_target_description): Add 'segments' parameter to enable
14001         segment base registers.
14002         (_initialize_i386_tdep) [GDB_SELF_TEST]: Add 'segments' parameter
14003         to call to i386_target_description.
14004         * i386-tdep.h (struct gdbarch_tdep): Add 'fsbase_regnum'.
14005         (enum i386_regnum): Add I386_FSBASE_REGNUM and I386_GSBASE_REGNUM.
14006         Define I386_NUM_REGS.
14007         (i386_target_description): Add 'segments' parameter to enable
14008         segment base registers.
14009
14010 2019-03-12  Eli Zaretskii  <eliz@gnu.org>
14011
14012         PR/24325
14013         * source-cache.c: #undef open and close, to avoid unresolved
14014         externals during linking.
14015
14016 2019-03-12  Tom Tromey  <tromey@adacore.com>
14017
14018         * remote.c (magic_null_ptid, not_sent_ptid, any_thread_ptid): Now
14019         const.  Add initializers.
14020         (_initialize_remote): Don't initialize ptid globals.
14021
14022 2019-03-12  Pedro Alves  <palves@redhat.com>
14023
14024         * yy-remap.h [TEST_CPNAMES] (YYFPRINTF): Don't define.
14025
14026 2019-03-12  Pedro Alves  <palves@redhat.com>
14027
14028         * cp-name-parser.y (main): Remove unused 'len' variable.
14029
14030 2019-03-12  Tom Tromey  <tromey@adacore.com>
14031
14032         * common/ptid.c (null_ptid, minus_one_ptid): Now const.
14033         * common/ptid.h (null_ptid, minus_one_ptid): Now const.
14034
14035 2019-03-12  Tom Tromey  <tromey@adacore.com>
14036
14037         * linux-nat.c (iterate_over_lwps): Update.
14038         (stop_callback): Remove parameter.
14039         (stop_wait_callback, detach_callback, resume_set_callback)
14040         (select_singlestep_lwp_callback, set_ignore_sigint)
14041         (status_callback, resumed_callback, resume_clear_callback)
14042         (kill_callback, kill_wait_callback, linux_nat_stop_lwp): Remove
14043         data parameter.
14044         (linux_nat_target::detach, linux_nat_target::resume)
14045         (linux_stop_and_wait_all_lwps, select_event_lwp)
14046         (linux_nat_filter_event, linux_nat_wait_1)
14047         (linux_nat_target::kill, linux_nat_target::stop)
14048         (linux_nat_target::stop): Update.
14049         (linux_nat_resume_callback): Change type.
14050         (resume_stopped_resumed_lwps, count_events_callback)
14051         (select_event_lwp_callback): Likewise.
14052         (linux_stop_lwp, linux_nat_stop_lwp): Update.
14053         * arm-linux-nat.c (struct update_registers_data): Remove.
14054         (update_registers_callback): Change type.
14055         (arm_linux_insert_hw_breakpoint1): Update.
14056         * nat/x86-linux-dregs.c (update_debug_registers_callback): Remove
14057         parameter.
14058         (x86_linux_dr_set_addr): Update.
14059         (x86_linux_dr_set_control): Update.
14060         * nat/linux-nat.h (iterate_over_lwps_ftype): Remove parameter.
14061         (iterate_over_lwps): Use gdb::function_view.
14062         * nat/aarch64-linux-hw-point.c (struct
14063         aarch64_dr_update_callback_param): Remove.
14064         (debug_reg_change_callback): Change type.
14065         (aarch64_notify_debug_reg_change): Update.
14066         * s390-linux-nat.c (s390_refresh_per_info): Update.
14067
14068 2019-03-11  Tom Tromey  <tromey@adacore.com>
14069
14070         * dwarf2read.c (dwarf2_find_containing_comp_unit): Remove
14071         redundant assignment to "this_cu".
14072
14073 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14074
14075         * gdbtypes.c (rank_one_type): Remove unnecessary cases from switch.
14076
14077 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14078
14079         * gdbtypes.c (rank_one_type_parm_set): New function extracted
14080         from...
14081         (rank_one_type): ... this.
14082
14083 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14084
14085         * gdbtypes.c (rank_one_type_parm_struct): New function extracted
14086         from...
14087         (rank_one_type): ... this.
14088
14089 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14090
14091         * gdbtypes.c (rank_one_type_parm_complex): New function extracted
14092         from...
14093         (rank_one_type): ... this.
14094
14095 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14096
14097         * gdbtypes.c (rank_one_type_parm_float): New function extracted
14098         from...
14099         (rank_one_type): ... this.
14100
14101 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14102
14103         * gdbtypes.c (rank_one_type_parm_bool): New function extracted
14104         from...
14105         (rank_one_type): ... this.
14106
14107 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14108
14109         * gdbtypes.c (rank_one_type_parm_range): New function extracted
14110         from...
14111         (rank_one_type): ... this.
14112
14113 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14114
14115         * gdbtypes.c (rank_one_type_parm_char): New function extracted
14116         from...
14117         (rank_one_type): ... this.
14118
14119 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14120
14121         * gdbtypes.c (rank_one_type_parm_enum): New function extracted
14122         from...
14123         (rank_one_type): ... this.
14124
14125 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14126
14127         * gdbtypes.c (rank_one_type_parm_int): New function extracted
14128         from...
14129         (rank_one_type): ... this.
14130
14131 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14132
14133         * gdbtypes.c (rank_one_type_parm_func): New function extracted
14134         from...
14135         (rank_one_type): ... this.
14136
14137 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14138
14139         * gdbtypes.c (rank_one_type_parm_array): New function extracted
14140         from...
14141         (rank_one_type): ... this.
14142
14143 2019-03-08  Simon Marchi  <simon.marchi@efficios.com>
14144
14145         * gdbtypes.c (rank_one_type_parm_ptr): New function extracted
14146         from...
14147         (rank_one_type): ... this.
14148
14149 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14150
14151         * inferior.c (initialize_inferiors): Ensure 'help set/show print
14152         inferior-events' shows the example events.
14153
14154 2019-03-08  Eli Zaretskii  <eliz@gnu.org>
14155
14156         Support styling on native MS-Windows console
14157
14158         PR/24315
14159         * utils.c (can_emit_style_escape) [_WIN32]: Don't disable styling
14160         on MS-Windows if $TERM is not defined.
14161
14162         * cli/cli-style.c: Set cli_styling to 1 in the MinGW build.
14163
14164         * posix-hdep.c (gdb_console_fputs):
14165         * mingw-hdep.c (rgb_to_16colors, gdb_console_fputs): New
14166         functions.
14167         * ui-file.h (gdb_console_fputs): Add prototype.
14168
14169         * ui-file.c (stdio_file::puts): Call gdb_console_fputs, and fall
14170         back to fputs only if the former returns zero.
14171
14172 2019-03-07  Tom Tromey  <tom@tromey.com>
14173
14174         * symmisc.c (print_symbol_bcache_statistics): Update.
14175         (print_objfile_statistics): Update.
14176         * symfile.c (allocate_symtab): Update.
14177         * stabsread.c: Don't include bcache.h.
14178         * psymtab.h (struct psymbol_bcache): Don't declare.
14179         (class psymtab_storage) <psymbol_cache>: Now a bcache.
14180         (psymbol_bcache_init, psymbol_bcache_free)
14181         (psymbol_bcache_get_bcache): Don't declare.
14182         * psymtab.c (struct psymbol_bcache): Remove.
14183         (psymtab_storage::psymtab_storage): Update.
14184         (psymtab_storage::~psymtab_storage): Update.
14185         (psymbol_bcache_init, psymbol_bcache_free)
14186         (psymbol_bcache_get_bcache, psymbol_bcache_full): Remove.
14187         (add_psymbol_to_bcache): Update.
14188         (allocate_psymtab): Update.
14189         * objfiles.h (struct objfile_per_bfd_storage) <filename_cache,
14190         macro_cache>: No longer pointers.
14191         * objfiles.c (get_objfile_bfd_data): Don't call bcache_xmalloc.
14192         (free_objfile_per_bfd_storage): Don't call bcache_xfree.
14193         * macrotab.c (macro_bcache): Update.
14194         * macroexp.c: Don't include bcache.h.
14195         * gdbtypes.c (check_types_worklist): Update.
14196         (types_deeply_equal): Remove TRY/CATCH.  Update.
14197         * elfread.c (elf_symtab_read): Update.
14198         * dwarf2read.c: Don't include bcache.h.
14199         * buildsym.c (buildsym_compunit::get_macro_table): Update.
14200         * bcache.h (bcache, bcache_full, bcache_xffree, bcache_xmalloc)
14201         (print_bcache_statistics, bcache_memory_used): Don't declare.
14202         (struct bcache): Move from bcache.c.  Add constructor, destructor,
14203         methods.  Rename all data members.
14204         * bcache.c (struct bcache): Move to bcache.h.
14205         (bcache::expand_hash_table): Rename from expand_hash_table.
14206         (bcache): Remove.
14207         (bcache::insert): Rename from bcache_full.
14208         (bcache::compare): Rename from bcache_compare.
14209         (bcache_xmalloc): Remove.
14210         (bcache::~bcache): Rename from bcache_xfree.
14211         (bcache::print_statistics): Rename from print_bcache_statistics.
14212         (bcache::memory_used): Rename from bcache_memory_used.
14213
14214 2019-03-07  Pedro Alves  <palves@redhat.com>
14215
14216         * infrun.c (normal_stop): Also check for
14217         TARGET_WAITKIND_NO_RESUMED before referring to inferior_thread().
14218
14219 2019-03-07  Andrew Burgess  <andrew.burgess@embecosm.com>
14220
14221         * f-lang.c (value_from_host_double): Moved to...
14222         * value.c (value_from_host_double): ...here.
14223         * value.h (value_from_host_double): Declare.
14224         * guile/scm-math.c (vlscm_convert_typed_number): Use
14225         value_from_host_double.
14226         (vlscm_convert_number): Likewise.
14227         * guile/scm-value.c (gdbscm_value_to_real): Likewise.
14228         * python/py-value.c (convert_value_from_python): Likewise.
14229
14230 2019-03-06  Tom Tromey  <tom@tromey.com>
14231
14232         * gcore.c (write_gcore_file): Use SCOPE_EXIT.
14233
14234 2019-03-06  Tom Tromey  <tom@tromey.com>
14235
14236         * utils.h (free_current_contents): Don't declare.
14237         * utils.c (free_current_contents): Remove.
14238
14239 2019-03-06  Tom Tromey  <tom@tromey.com>
14240
14241         * top.c (quit_force): Update.
14242         * main.c (captured_command_loop): Update.
14243         * common/new-op.c (operator new): Update.
14244         * common/common-exceptions.c (struct catcher)
14245         <save_cleanup_chain>: Remove member.
14246         (exceptions_state_mc_init): Update.
14247         (exception_try_scope_entry): Return nullptr.
14248         (exception_try_scope_exit, exception_rethrow)
14249         (throw_exception_sjlj, throw_exception_cxx): Update.
14250         * common/cleanups.h (make_cleanup, make_cleanup_dtor)
14251         (all_cleanups, do_cleanups, discard_cleanups)
14252         (discard_final_cleanups, save_cleanups, save_final_cleanups)
14253         (restore_cleanups, restore_final_cleanups): Don't declare.
14254         (do_final_cleanups): Remove parameter.
14255         * common/cleanups.c (cleanup_chain, make_cleanup)
14256         (make_cleanup_dtor, all_cleanups, do_cleanups)
14257         (discard_my_cleanups, discard_cleanups)
14258         (discard_final_cleanups, save_my_cleanups, save_cleanups)
14259         (save_final_cleanups, restore_my_cleanups, restore_cleanups)
14260         (null_cleanup): Remove.
14261         (do_final_cleanups): Remove parameter.
14262
14263 2019-03-06  Tom Tromey  <tom@tromey.com>
14264
14265         * remote.c (remote_target::remote_parse_stop_reply): Use
14266         unique_xmalloc_ptr.
14267
14268 2019-03-06  Tom Tromey  <tom@tromey.com>
14269
14270         * stabsread.c (struct stabs_field_info): Rename from field_info.
14271         <list, fnlist>: Add initializers.
14272         <obstack>: New member.
14273         (read_member_functions, read_struct_fields, read_baseclasses):
14274         Allocate on obstack.  Don't use cleanups.
14275         (read_one_struct_field, read_member_functions, read_struct_fields)
14276         (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type)
14277         (attach_fields_to_type, read_cpp_abbrev, read_member_functions)
14278         (read_struct_type): Update.
14279
14280 2019-03-06  Tom Tromey  <tom@tromey.com>
14281
14282         * nat/linux-namespaces.c (linux_mntns_access_fs): Use SCOPE_EXIT.
14283         * common/filestuff.h (make_cleanup_close): Don't declare.
14284         * common/filestuff.c (do_close_cleanup, make_cleanup_close):
14285         Remove.
14286
14287 2019-03-06  Tom Tromey  <tom@tromey.com>
14288
14289         * solib-aix.c: Use make_scope_exit.
14290
14291 2019-03-06  Tom Tromey  <tom@tromey.com>
14292
14293         * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct):
14294         Use make_scope_exit.
14295
14296 2019-03-06  Tom Tromey  <tom@tromey.com>
14297
14298         * solib-svr4.c (disable_probes_interface): Remove parameter.
14299         (svr4_handle_solib_event): Use make_scope_exit.
14300
14301 2019-03-06  Tom Tromey  <tom@tromey.com>
14302
14303         * remote.c (struct stop_reply_deleter): Remove.
14304         (stop_reply_up): Update.
14305         (struct stop_reply): Derive from notif_event.  Don't typedef.
14306         <regcache>: Now a std::vector.
14307         (stop_reply_xfree): Remove.
14308         (stop_reply::~stop_reply): Rename from stop_reply_dtr.
14309         (remote_notif_stop_alloc_reply): Return a unique_ptr.  Use new.
14310         (remote_target::discard_pending_stop_replies): Use delete.
14311         (remote_target::remote_parse_stop_reply): Update.
14312         (remote_target::process_stop_reply): Update.
14313         * remote-notif.h (struct notif_event): Add virtual destructor.
14314         Remove "dtr" member.
14315         (struct notif_client) <alloc_event>: Return a unique_ptr.
14316         (notif_event_xfree): Don't declare.
14317         (notif_event_up): New typedef.
14318         * remote-notif.c (remote_notif_ack, remote_notif_parse): Update.
14319         (notif_event_xfree, do_notif_event_xfree): Remove.
14320         (remote_notif_state_xfree): Update.
14321
14322 2019-03-06  Tom Tromey  <tom@tromey.com>
14323
14324         * infrun.c (displaced_step_clear_cleanup): Now a
14325         forward_scope_exit type.
14326         (displaced_step_prepare_throw): Update.
14327         (displaced_step_fixup): Update.
14328
14329 2019-03-06  Tom Tromey  <tom@tromey.com>
14330
14331         * inferior.h (class inferior): Update comment.
14332         * gdbthread.h (class thread_info): Update comment.
14333
14334 2019-03-06  Joel Brobecker  <brobecker@adacore.com>
14335             Tom Tromey  <tom@tromey.com>
14336
14337         * stabsread.h (struct stab_section_list): Remove.
14338         (coffstab_build_psymtabs): Update.
14339         * dbxread.c (symbuf_sections): Now a std::vector.
14340         (sect_idx): New global.
14341         (fill_symbuf): Update.
14342         (coffstab_build_psymtabs): Change type of stabsects parameter.
14343         Update.
14344         * coffread.c (struct coff_symfile_info) <stabsects>: Now a
14345         std::vector.
14346         (linetab, linetab_offset, linetab_size, stringtab): Move earlier.
14347         (coff_locate_sections): Update.
14348         (coff_symfile_read): Remove cleanups.  Update.
14349         (init_stringtab): Add storage parameter.
14350         (free_stringtab, free_stringtab_cleanup): Remove.
14351         (init_lineno): Add storage parameter.
14352         (free_linetab, free_linetab_cleanup): Remove.
14353
14354 2019-03-06  Pedro Alves  <palves@redhat.com>
14355
14356         * linux-fork.c (fork_info::clobber_regs): Delete.
14357         (fork_load_infrun_state): Remove reference to 'clobber_regs'.
14358         (fork_save_infrun_state): Remove 'clobber_regs' parameter.  Update
14359         comment.  Adjust.
14360         (scoped_switch_fork_info::scoped_switch_fork_info)
14361         (checkpoint_command, linux_fork_context): Adjust
14362         fork_save_infrun_state calls.
14363
14364 2019-03-06  Pedro Alves  <palves@redhat.com>
14365
14366         * linux-fork.c (inf_has_multiple_thread_cb): Delete.
14367         (inf_has_multiple_threads): Return 'bool' and rewrite using
14368         inferior_info::threads().
14369
14370 2019-03-06  Pedro Alves  <palves@redhat.com>
14371
14372         * linux-fork.c: Include <list>.
14373         (fork_list): Now a std::list instance.
14374         (fork_info): Add ctor, dtor, and in-class initialize all fields.
14375         (forks_exist_p, find_last_fork): Adjust.
14376         (new_fork): Delete.
14377         (one_fork_p): New.
14378         (add_fork): Adjust.
14379         (free_fork): Delete, folded into fork_info::~fork_info().
14380         (delete_fork, find_fork_ptid, find_fork_id, find_fork_pid):
14381         Adjust.
14382         (init_fork_list): Delete.
14383         (linux_fork_killall, linux_fork_mourn_inferior)
14384         (linux_fork_detach, info_checkpoints_command): Adjust.
14385         (_initialize_linux_fork): No longer call init_fork_list.
14386
14387 2019-03-06  Pedro Alves  <palves@redhat.com>
14388
14389         * linux-fork.c (new_fork): New, split out of ...
14390         (add_fork): ... this.  Return void.  Move "first fork" special
14391         case from here, to ...
14392         (checkpoint_command): ... here.
14393         * linux-linux.h (add_fork): Return void.
14394
14395 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14396
14397         * f-exp.y (direct_abs_decl): Handle TYPE*SIZE type names.
14398
14399 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14400             Chris January  <chris.january@arm.com>
14401             David Lecomber  <david.lecomber@arm.com>
14402
14403         * f-exp.y: New token, UNOP_INTRINSIC.
14404         (exp): New pattern using UNOP_INTRINSIC token.
14405         (f77_keywords): Add 'abs' keyword.
14406         * f-lang.c: Add 'target-float.h' and 'math.h' includes.
14407         (value_from_host_double): New function.
14408         (evaluate_subexp_f): Support UNOP_ABS.
14409
14410 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14411
14412         * f-lang.c (build_fortran_types): Use TYPE_CODE_CHAR for character
14413         types.
14414
14415 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14416
14417         * f-exp.y (convert_to_kind_type): Handle integer (kind=8).
14418         * f-lang.c (build_fortran_types): Setup builtin_integer_s8.
14419         * f-lang.h (struct builtin_f_type): Add builtin_integer_s8 field.
14420
14421 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14422
14423         * f-exp.y (convert_to_kind_type): Handle more type kinds.
14424
14425 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14426             Chris January  <chris.january@arm.com>
14427
14428         * expprint.c (dump_subexp_body_standard): Support UNOP_KIND.
14429         * f-exp.y: Define 'KIND' token.
14430         (exp): New pattern for KIND expressions.
14431         (ptype): Handle types with a kind extension.
14432         (direct_abs_decl): Extend to spot kind extensions.
14433         (f77_keywords): Add 'kind' to the list.
14434         (push_kind_type): New function.
14435         (convert_to_kind_type): New function.
14436         * f-lang.c (evaluate_subexp_f): Support UNOP_KIND.
14437         * parse.c (operator_length_standard): Likewise.
14438         * parser-defs.h (enum type_pieces): Add tp_kind.
14439         * std-operator.def: Add UNOP_KIND.
14440
14441 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14442
14443         * f-exp.y (f_parse): Set yydebug.
14444
14445 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14446
14447         * f-lang.c (evaluate_subexp_f): New function.
14448         (exp_descriptor_f): New global.
14449         (f_language_defn): Use exp_descriptor_f instead of
14450         exp_descriptor_standard.
14451
14452 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14453
14454         * f-exp.y (struct token): Add comments.
14455         (dot_ops): Remove uppercase versions and the end marker.
14456         (f77_keywords): Likewise.
14457         (yylex): Use ARRAY_SIZE to iterate over dot_ops, assert all
14458         entries in the dot_ops array are case insensitive, and use
14459         strncasecmp to compare strings.  Also some whitespace cleanup in
14460         this area.  Similar for the f77_keywords array, except entries in
14461         this list might be case sensitive.
14462
14463 2019-03-06  Andrew Burgess  <andrew.burgess@embecosm.com>
14464
14465         * f-exp.y (struct f77_boolean_val): Add comments.
14466         (boolean_values): Remove uppercase versions, and end marker.
14467         (yylex): Use ARRAY_SIZE for iterating over boolean_values array,
14468         and use strncasecmp to achieve case insensitivity.  Additionally,
14469         perform whitespace cleanup around this code.
14470
14471 2019-03-06  Tom Tromey  <tromey@adacore.com>
14472
14473         * remote-sim.c (gdbsim_target_open): Use result of
14474         gdb_argv::release.
14475
14476 2019-03-06  Richard Bunt  <richard.bunt@arm.com>
14477         Dirk Schubert  <dirk.schubert@arm.com>
14478         Chris January  <chris.january@arm.com>
14479
14480         * eval.c (evaluate_subexp_standard): Call Fortran argument
14481         wrapping logic.
14482         * f-lang.c (struct value): A value which can be passed into a
14483         Fortran function call.
14484         (fortran_argument_convert): Wrap Fortran arguments in a pointer
14485         where appropriate.
14486         (struct type): Value ready for a Fortran function call.
14487         (fortran_preserve_arg_pointer): Undo check_typedef, the pointer
14488         is needed.
14489         * f-lang.h (fortran_argument_convert): Declaration.
14490         (fortran_preserve_arg_pointer): Declaration.
14491         * infcall.c (value_arg_coerce): Call Fortran argument logic.
14492
14493 2019-03-05  Tom Tromey  <tromey@adacore.com>
14494
14495         * python/py-prettyprint.c (print_string_repr): Remove #if.
14496         * python/py-utils.c (unicode_to_encoded_string): Remove #if.
14497
14498 2019-03-05  Tom Tromey  <tromey@adacore.com>
14499
14500         * target.c (the_dummy_target): Move later.  Change type to
14501         "dummy_target".
14502         (initialize_targets): Don't initialize the_dummy_target.
14503
14504 2019-03-05  Tom Tromey  <tromey@adacore.com>
14505
14506         * gdb_bfd.c (gdb_bfd_fdopenr): Remove.
14507         * gdb_bfd.h (gdb_bfd_fdopenr): Don't declare.
14508
14509 2019-03-05  Tom Tromey  <tromey@adacore.com>
14510
14511         * windows-nat.c (windows_nat_target::attach)
14512         (windows_nat_target::detach): Don't call gdb_flush.
14513         * valprint.c (generic_val_print, val_print, val_print_string):
14514         Don't call gdb_flush.
14515         * utils.c (defaulted_query): Don't call gdb_flush.
14516         * typeprint.c (print_type_scalar): Don't call gdb_flush.
14517         * target.c (target_announce_detach): Don't call gdb_flush.
14518         * sparc64-tdep.c (adi_print_versions): Don't call gdb_flush.
14519         * remote.c (extended_remote_target::attach): Don't call
14520         gdb_flush.
14521         * procfs.c (procfs_target::detach): Don't call gdb_flush.
14522         * printcmd.c (do_examine): Don't call gdb_flush.
14523         (info_display_command): Don't call gdb_flush.
14524         * p-valprint.c (pascal_val_print): Don't call gdb_flush.
14525         * nto-procfs.c (nto_procfs_target::attach): Don't call gdb_flush.
14526         * memattr.c (info_mem_command): Don't call gdb_flush.
14527         * mdebugread.c (mdebug_build_psymtabs): Don't call gdb_flush.
14528         * m2-valprint.c (m2_val_print): Don't call gdb_flush.
14529         * infrun.c (follow_exec, handle_command): Don't call gdb_flush.
14530         * inf-ptrace.c (inf_ptrace_target::attach): Don't call gdb_flush.
14531         * hppa-tdep.c (unwind_command): Don't call gdb_flush.
14532         * gnu-nat.c (gnu_nat_target::attach): Don't call gdb_flush.
14533         (gnu_nat_target::detach): Don't call gdb_flush.
14534         * f-valprint.c (f_val_print): Don't call gdb_flush.
14535         * darwin-nat.c (darwin_nat_target::attach): Don't call gdb_flush.
14536         * cli/cli-script.c (read_command_lines): Don't call gdb_flush.
14537         * cli/cli-cmds.c (shell_escape, print_disassembly): Don't call
14538         gdb_flush.
14539         * c-valprint.c (c_val_print): Don't call gdb_flush.
14540         * ada-valprint.c (ada_print_scalar): Don't call gdb_flush.
14541
14542 2019-03-05  Tom Tromey  <tromey@adacore.com>
14543
14544         * varobj.c (update_dynamic_varobj_children): Update.
14545         (install_default_visualizer): Use reset, not release.
14546         * value.c (set_internalvar): Update.
14547         * dwarf2loc.c (value_of_dwarf_reg_entry): Update.
14548         * common/gdb_ref_ptr.h (class ref_ptr) <release>: Add
14549         ATTRIBUTE_UNUSED_RESULT.
14550
14551 2019-03-05  Tom Tromey  <tromey@adacore.com>
14552
14553         * remote.c (class scoped_remote_fd) <release>: Add
14554         ATTRIBUTE_UNUSED_RESULT.
14555
14556 2019-03-05  Tom Tromey  <tromey@adacore.com>
14557
14558         * macroexp.c (struct macro_buffer) <release>: Add
14559         ATTRIBUTE_UNUSED_RESULT.
14560
14561 2019-03-05  Tom Tromey  <tromey@adacore.com>
14562
14563         * nat/linux-btrace.c (linux_enable_bts, linux_enable_pt): Update.
14564         * common/scoped_mmap.h (class scoped_mmap) <release>: Add
14565         ATTRIBUTE_UNUSED_RESULT.
14566
14567 2019-03-05  Tom Tromey  <tromey@adacore.com>
14568
14569         * common/scoped_fd.h (class scoped_fd) <release>: Add
14570         ATTRIBUTE_UNUSED_RESULT.
14571
14572 2019-03-05  Tom Tromey  <tromey@adacore.com>
14573
14574         * parser-defs.h (struct parser_state) <release>: Add
14575         ATTRIBUTE_UNUSED_RESULT.
14576
14577 2019-03-05  Tom Tromey  <tromey@adacore.com>
14578
14579         * utils.h (class gdb_argv) <release>: Add
14580         ATTRIBUTE_UNUSED_RESULT.
14581         * common/common-defs.h (ATTRIBUTE_UNUSED_RESULT): Define.
14582
14583 2019-03-02  Eli Zaretskii  <eliz@gnu.org>
14584
14585         * xml-syscall.c (xml_list_syscalls_by_group): Drop 'struct' from
14586         for-loop range, to avoid compiler warnings.
14587
14588         * tui/tui.c (tui_enable) [__MINGW32__]: Don't declare 'cap', to
14589         avoid compiler warnings about unused variables.
14590
14591         * NEWS: Mention end of support for native debugging on MS-Windows
14592         before XP.
14593
14594         PR gdb/24292
14595         * common/netstuff.c:
14596         * gdbserver/gdbreplay.c
14597         * gdbserver/remote-utils.c:
14598         * ser-tcp.c:
14599         * unittests/parse-connection-spec-selftests.c [USE_WIN32API]:
14600         Include ws2tcpip.h instead of wsiapi.h and winsock2.h.  Redefine
14601         _WIN32_WINNT to 0x0501 if defined to a smaller value, as
14602         'getaddrinfo' and 'freeaddrinfo' were not available before
14603         Windows XP, and mingw.org's MinGW headers by default define
14604         _WIN32_WINNT to 0x500.
14605
14606 2019-03-01  Gary Benson <gbenson@redhat.com>
14607
14608         * coffread.c (coff_start_symtab): Remove unnecessary xstrdup.
14609
14610 2019-02-28  Brian Vandenberg  <phantall@gmail.com>
14611             Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
14612
14613         PR gdb/8527
14614         * procfs.c (proc_wait_for_stop): Wrap write of PCWSTOP in
14615         set_sigint_trap, clear_sigint_trap.
14616
14617 2019-02-27  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14618
14619         * target.c (target_detach): Clear the regcache and the
14620         frame cache.
14621
14622 2019-02-27  Pedro Alves  <palves@redhat.com>
14623
14624         * utils.c (set_screen_size): When we cap the height/width sizes,
14625         tweak the corresponding command variable to show "unlimited":
14626
14627 2019-02-27  Saagar Jha  <saagar@saagarjha.com>
14628             Pedro Alves  <palves@redhat.com>
14629
14630         * utils.c (set_screen_size): Reduce "infinite" rows and columns
14631         before calling rl_set_screen_size.
14632
14633 2019-02-27  Tom Tromey  <tromey@adacore.com>
14634
14635         * configure.ac (HAVE_LIBPYTHON2_4, HAVE_LIBPYTHON2_5): Never
14636         define.
14637         * python/py-value.c: Remove Python 2.4 workaround.
14638         * python/py-utils.c (gdb_pymodule_addobject): Remove Python 2.4
14639         workaround.
14640         * python/py-type.c (convert_field, gdbpy_initialize_types): Remove
14641         Python 2.4 workaround.
14642         * python/python-internal.h: Remove Python 2.4 comment.
14643         (Py_ssize_t): Don't define.
14644         (PyVarObject_HEAD_INIT, Py_TYPE): Don't define.
14645         (gdb_Py_DECREF): Remove Python 2.4 workaround.
14646         (gdb_PyObject_GetAttrString, PyObject_GetAttrString): Remove.
14647         (gdb_PyObject_HasAttrString, PyObject_HasAttrString): Remove.
14648         * python/python.c (do_start_initialization): Remove Python 2.4
14649         workaround.
14650         * python/py-prettyprint.c (class dummy_python_frame): Remove.
14651         (print_children): Remove Python 2.4 workaround.
14652         * python/py-inferior.c (buffer_procs): Remove Python 2.4
14653         workaround.
14654         (CHARBUFFERPROC_NAME): Remove.
14655         * python/py-breakpoint.c (gdbpy_initialize_breakpoints): Remove
14656         Python 2.4 workaround.
14657
14658 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14659
14660         * NEWS: Note minimum Python version.
14661
14662 2019-02-27  Kevin Buettner  <kevinb@redhat.com>
14663
14664         * python/py-inferior.c (infpy_write_memory): Remove non-IS_PY3K
14665         code from these functions.  Remove corresponding ifdefs.  Use
14666         Py_buffer_up instead of explicit calls to PyBuffer_Release.
14667         Remove gotos and target of gotos.
14668         (infpy_search_memory): Likewise.
14669
14670 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14671
14672         * gdb/hppa-tdep.c (hppa_dummy_id): Delete.
14673         (hppa_gdbarch_init): Don't register deleted functions with
14674         gdbarch.
14675
14676 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14677
14678         * gdb/h8300-tdep.c (h8300_unwind_pc): Delete.
14679         (h8300_unwind_sp): Delete.
14680         (h8300_dummy_id): Delete.
14681         (h8300_gdbarch_init): Don't register deleted functions with
14682         gdbarch.
14683
14684 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14685
14686         * gdb/ft32-tdep.c (ft32_dummy_id): Delete.
14687         (ft32_unwind_pc): Delete.
14688         (ft32_unwind_sp): Delete.
14689         (ft32_gdbarch_init): Don't register deleted functions with
14690         gdbarch.
14691
14692 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14693
14694         * gdb/frv-tdep.c (frv_dummy_id): Delete.
14695         (frv_unwind_pc): Delete.
14696         (frv_unwind_sp): Delete.
14697         (frv_gdbarch_init): Don't register deleted functions with
14698         gdbarch.
14699
14700 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14701
14702         * gdb/riscv-tdep.c (riscv_dummy_id): Delete.
14703         (riscv_unwind_pc): Delete.
14704         (riscv_unwind_sp): Delete.
14705         (riscv_gdbarch_init): Don't register deleted functions with
14706         gdbarch.
14707
14708 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14709
14710         * gdb/csky-tdep.c (csky_dummy_id): Delete.
14711         (csky_unwind_pc): Delete.
14712         (csky_unwind_sp): Delete.
14713         (csky_gdbarch_init): Don't register deleted functions with
14714         gdbarch.
14715
14716 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14717
14718         * gdb/cris-tdep.c (cris_dummy_id): Delete.
14719         (cris_unwind_pc): Delete.
14720         (cris_unwind_sp): Delete.
14721         (cris_gdbarch_init): Don't register deleted functions with
14722         gdbarch.
14723
14724 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14725
14726         * gdb/bfin-tdep.c (bfin_dummy_id): Delete.
14727         (bfin_unwind_pc): Delete.
14728         (bfin_gdbarch_init): Don't register deleted functions with gdbarch.
14729
14730 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14731
14732         * gdb/arm-tdep.c (arm_dummy_id): Delete.
14733         (arm_unwind_pc): Delete.
14734         (arm_unwind_sp): Delete.
14735         (arm_gdbarch_init): Don't register deleted functions with gdbarch.
14736
14737 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14738
14739         * gdb/arc-tdep.c (arc_dummy_id): Delete.
14740         (arc_unwind_pc): Delete.
14741         (arc_unwind_sp): Delete.
14742         (arc_gdbarch_init): Don't register deleted functions with gdbarch.
14743
14744 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14745
14746         * gdb/alpha-tdep.c (alpha_dummy_id): Delete.
14747         (alpha_unwind_pc): Delete.
14748         (alpha_gdbarch_init): Don't register deleted functions with
14749         gdbarch.
14750
14751 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14752
14753         * gdb/aarch64-tdep.c (aarch64_dummy_id): Delete.
14754         (aarch64_unwind_pc): Delete.
14755         (aarch64_unwind_sp): Delete.
14756         (aarch64_gdbarch_init): Don't register deleted functions with
14757         gdbarch.
14758
14759 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14760
14761         * gdbtypes.c (type_align): Don't consider static members when
14762         computing structure alignment.
14763
14764 2019-02-27  Andrew Burgess  <andrew.burgess@embecosm.com>
14765
14766         * arc-tdep.c (arc_type_align): Provide alignment for basic types,
14767         return 0 for other types.
14768         * arch-utils.c (default_type_align): Always return 0.
14769         * gdbarch.h: Regenerate.
14770         * gdbarch.sh (type_align): Extend comment.
14771         * gdbtypes.c (type_align): Add additional comments, always call
14772         gdbarch_type_align before applying the default rules.
14773         * i386-tdep.c (i386_type_align): Return 0 as the default rule,
14774         generic code will then apply a suitable default.
14775         * nios2-tdep.c (nios2_type_align): Provide alignment for basic
14776         types, return 0 for other types.
14777
14778 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14779
14780         * NEWS: Create a new section for the next release branch.
14781         Rename the section of the current branch, now that it has
14782         been cut.
14783
14784 2019-02-27  Joel Brobecker  <brobecker@adacore.com>
14785
14786         GDB 8.3 branch created (143420fb0d5ae54323ba9953f0818c194635228d):
14787         * version.in: Bump version to 8.3.50.DATE-git.
14788
14789 2019-02-26  Simon Marchi  <simon.marchi@efficios.com>
14790
14791         * aix-thread.c (ptid_cmp): Remove unused variable.
14792         (get_signaled_thread): Likewise.
14793         (store_regs_user_thread): Likewise.
14794         (store_regs_kernel_thread): Likewise.
14795         (fetch_regs_kernel_thread): Remove shadowed variable.
14796
14797 2019-02-26  Andrew Burgess  <andrew.burgess@embecosm.com>
14798
14799         * features/riscv/32bit-cpu.xml: Add register numbers.
14800         * features/riscv/32bit-fpu.c: Regenerate.
14801         * features/riscv/32bit-fpu.xml: Add register numbers.
14802         * features/riscv/64bit-cpu.xml: Add register numbers.
14803         * features/riscv/64bit-fpu.c: Regenerate.
14804         * features/riscv/64bit-fpu.xml: Add register numbers.
14805
14806 2019-02-26  Kevin Buettner  <kevinb@redhat.com>
14807
14808         * NEWS: Mention two argument form of gdb.Value constructor.
14809         * python/py-value.c (convert_buffer_and_type_to_value): New
14810         function.
14811         (valpy_new): Parse arguments via gdb_PyArg_ParseTupleAndKeywords.
14812         Add support for handling an optional second argument.  Call
14813         convert_buffer_and_type_to_value as appropriate.
14814         * python/python-internal.h (Py_buffer_deleter): New struct.
14815         (Py_buffer_up): New typedef.
14816
14817 2019-02-25  John Baldwin  <jhb@FreeBSD.org>
14818
14819         * dwarf2read.c (dwarf2_get_dwz_file): Reset dwz_bfd to nullptr
14820         instead of releasing ownership.
14821
14822 2019-02-25  Jordan Rupprecht  <rupprecht@google.com>
14823
14824         * dwarf2read.c (open_and_init_dwp_file): Call
14825         elf_numsections instead of bfd_count_sections to initialize
14826         dwp_file->num_sections.
14827
14828 2019-02-25  Tom Tromey  <tromey@adacore.com>
14829
14830         * solib-darwin.c (darwin_get_dyld_bfd): Don't release dyld_bfd.
14831
14832 2019-02-23  Sergio Durigan Junior  <sergiodj@redhat.com>
14833
14834         * gcore.in: Add '--readnever' option when invoking GDB.
14835
14836 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14837
14838         * MAINTAINERS: Update my email address.
14839
14840 2019-02-22  Simon Marchi  <simon.marchi@polymtl.ca>
14841
14842         * build-id.c (build_id_to_debug_bfd_1): New function.
14843         (build_id_to_debug_bfd): Look for separate debug file in
14844         sysroot.
14845
14846 2019-02-22  Andrew Burgess  <andrew.burgess@embecosm.com>
14847
14848         * gdbarch.sh: Update the copyright year range that is placed into
14849         generated files.
14850
14851 2019-02-22  Keith Seitz  <keiths@redhat.com>
14852
14853         PR symtab/23853
14854         * linespec.c (create_sals_line_offset): Search for the default
14855         symtab's filename instead of its fullname.
14856
14857 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14858
14859         * NEWS: Update style defaults.
14860
14861 2019-02-21  Alan Hayward  <alan.hayward@arm.com>
14862
14863         * main.c (captured_main_1): Disable styling in batch mode.
14864
14865 2019-02-20  Tom Tromey  <tom@tromey.com>
14866
14867         * symtab.c (symtab_symbol_info): Fix typos.
14868
14869 2019-02-20  Tom Tromey  <tromey@adacore.com>
14870
14871         * findcmd.c (_initialize_mem_search): Use upper case for
14872         metasyntactic variables.
14873
14874 2019-02-20  Alan Hayward  <alan.hayward@arm.com>
14875
14876         * aarch64-tdep.c (aarch64_add_reggroups): New function.
14877         (aarch64_gdbarch_init): Call aarch64_add_reggroups.
14878
14879 2019-02-19  Simon Marchi  <simon.marchi@polymtl.ca>
14880
14881         * top.h (source_file_name): Change to std::string.
14882         * top.c (source_file_name): Likewise.
14883         (command_line_input): Adjust.
14884         * cli/cli-script.c (script_from_file): Adjust.
14885
14886 2019-02-19  Tom Tromey  <tromey@adacore.com>
14887
14888         * ravenscar-thread.c
14889         (ravenscar_thread_target::update_thread_list): Don't call
14890         ada_build_task_list.
14891         * ada-lang.h (ada_build_task_list): Don't declare.
14892         * ada-tasks.c (struct ada_tasks_inferior_data)
14893         <task_list_valid_p>: Now bool.
14894         (read_known_tasks, ada_task_list_changed)
14895         (ada_tasks_invalidate_inferior_data): Update.
14896         (read_known_tasks_array): Return bool.
14897         (read_known_tasks_list): Likewise.
14898         (read_known_tasks): Return void.
14899         (ada_build_task_list): Now static.
14900
14901 2019-02-18  Andrew Burgess  <andrew.burgess@embecosm.com>
14902
14903         * gdbtypes.c (type_align): Allow alignment of TYPE_CODE_METHODPTR
14904         and TYPE_CODE_MEMBERPTR to be overridden by the gdbarch.
14905
14906 2019-02-18  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
14907
14908         * ada-task.c (_initialize_tasks): Use 'with_cleanup' register
14909         variant for ada_tasks_pspace_data_handle and
14910         ada_tasks_inferior_data_handle.
14911         (ada_tasks_pspace_data_cleanup): New function.
14912         (ada_tasks_inferior_data_cleanup): New function.
14913
14914 2019-02-17  Tom Tromey  <tom@tromey.com>
14915
14916         * macrotab.h (macro_source_fullname): Return a std::string.
14917         * macrotab.c (macro_include, check_for_redefinition)
14918         (macro_undef, macro_lookup_definition, foreach_macro)
14919         (foreach_macro_in_scope): Update.
14920         (macro_source_fullname): Return a std::string.
14921         * macrocmd.c (show_pp_source_pos): Update.
14922
14923 2019-02-17  Tom Tromey  <tom@tromey.com>
14924
14925         * macrocmd.c (show_pp_source_pos): Style the file names.
14926
14927 2019-02-17  Tom Tromey  <tom@tromey.com>
14928
14929         PR tui/24197:
14930         * tui/tui-source.c (tui_set_source_content_nil): Rewrite.
14931
14932 2019-02-17  Tom Tromey  <tom@tromey.com>
14933
14934         * ada-lang.c (user_select_syms): Use filtered printing.
14935         * utils.c (wrap_style): New global.
14936         (desired_style): Remove.
14937         (emit_style_escape): Add stream parameter.
14938         (set_output_style, reset_terminal_style, prompt_for_continue):
14939         Update.
14940         (flush_wrap_buffer): Only flush gdb_stdout.
14941         (wrap_here): Set wrap_style.
14942         (fputs_maybe_filtered): Clear the wrap buffer on exception.  Don't
14943         treat escape sequences as a character.  Change when wrap buffer is
14944         flushed.
14945         (fputs_styled): Do not set the output style when the default is
14946         requested.
14947         * ui-style.h (struct ui_file_style) <is_default>: New method.
14948         * source.c (print_source_lines_base): Emit escape sequences in one
14949         piece.
14950
14951 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14952
14953         * gdbtypes.c (type_align): Handle TYPE_CODE_RANGE the same as
14954         integers and enumeration types.
14955
14956 2019-02-17  Joel Brobecker  <brobecker@adacore.com>
14957
14958         * ada-lang.c (standard_lookup): Use ada_lookup_encoded_symbol
14959         instead of lookup_symbol_in_language
14960         (do_exact_match): New function.
14961         (ada_get_symbol_name_matcher): Return do_exact_match when
14962         doing a verbatim match.
14963
14964 2019-02-15  Tom Tromey  <tromey@adacore.com>
14965
14966         * ravenscar-thread.c (ravenscar_thread_target::resume)
14967         (ravenscar_thread_target::wait): Special case wildcard requests.
14968
14969 2019-02-15  Tom Tromey  <tromey@adacore.com>
14970
14971         * ravenscar-thread.c (base_ptid): Remove.
14972         (struct ravenscar_thread_target) <close>: New method.
14973         <m_base_ptid>: New member.
14974         <update_inferior_ptid, active_task, task_is_currently_active,
14975         runtime_initialized>: Declare methods.
14976         <ravenscar_thread_target>: Add constructor.
14977         (ravenscar_thread_target::task_is_currently_active)
14978         (ravenscar_thread_target::update_inferior_ptid)
14979         (ravenscar_runtime_initialized): Rename.  Now methods.
14980         (ravenscar_thread_target::resume, ravenscar_thread_target::wait)
14981         (ravenscar_thread_target::update_thread_list): Update.
14982         (ravenscar_thread_target::active_task): Now method.
14983         (ravenscar_thread_target::store_registers)
14984         (ravenscar_thread_target::prepare_to_store)
14985         (ravenscar_thread_target::prepare_to_store)
14986         (ravenscar_thread_target::mourn_inferior): Update.
14987         (ravenscar_inferior_created): Use "new" to create target.
14988         (ravenscar_thread_target::get_ada_task_ptid): Update.
14989         (_initialize_ravenscar): Don't initialize base_ptid.
14990         (ravenscar_ops): Remove global.
14991
14992 2019-02-15  Tom Tromey  <tromey@adacore.com>
14993
14994         * target.h (push_target): Declare new overload.
14995         * target.c (push_target): New overload, taking an rvalue reference.
14996         * remote.c (remote_target::open_1): Use push_target overload.
14997         * corelow.c (core_target_open): Use push_target overload.
14998
14999 2019-02-15  Tom Tromey  <tromey@adacore.com>
15000
15001         * ravenscar-thread.c (is_ravenscar_task)
15002         (ravenscar_task_is_currently_active): Return bool.
15003         (ravenscar_update_inferior_ptid, get_running_thread_msymbol)
15004         (_initialize_ravenscar): Remove "(void)".
15005         (has_ravenscar_runtime, ravenscar_runtime_initialized): Likewise.
15006         Return bool.
15007
15008 2019-02-15  Tom Tromey  <tromey@adacore.com>
15009
15010         * ravenscar-thread.c (ravenscar_runtime_initializer)
15011         (has_ravenscar_runtime, get_running_thread_id)
15012         (ravenscar_thread_target::resume): Fix indentation.
15013
15014 2019-02-15  Tom Tromey  <tromey@adacore.com>
15015
15016         * sparc-ravenscar-thread.c (struct sparc_ravenscar_ops): Derive
15017         from ravenscar_arch_ops.
15018         (sparc_ravenscar_ops::fetch_registers)
15019         (sparc_ravenscar_ops::store_registers): Now methods.
15020         (sparc_ravenscar_prepare_to_store): Remove.
15021         (sparc_ravenscar_ops): Redefine.
15022         * ravenscar-thread.h (struct ravenscar_arch_ops): Add virtual
15023         methods and destructor.  Remove members.
15024         * ravenscar-thread.c (ravenscar_thread_target::fetch_registers)
15025         (ravenscar_thread_target::store_registers)
15026         (ravenscar_thread_target::prepare_to_store): Update.
15027         * ppc-ravenscar-thread.c (ppc_ravenscar_generic_prepare_to_store):
15028         Remove.
15029         (struct ppc_ravenscar_powerpc_ops): Derive from
15030         ravenscar_arch_ops.
15031         (ppc_ravenscar_powerpc_ops::fetch_registers)
15032         (ppc_ravenscar_powerpc_ops::store_registers): Now methods.
15033         (ppc_ravenscar_powerpc_ops): Redefine.
15034         (struct ppc_ravenscar_e500_ops): Derive from ravenscar_arch_ops.
15035         (ppc_ravenscar_e500_ops::fetch_registers)
15036         (ppc_ravenscar_e500_ops::store_registers): Now methods.
15037         (ppc_ravenscar_e500_ops): Redefine.
15038         * aarch64-ravenscar-thread.c
15039         (aarch64_ravenscar_generic_prepare_to_store): Remove.
15040         (struct aarch64_ravenscar_ops): Derive from ravenscar_arch_ops.
15041         (aarch64_ravenscar_fetch_registers)
15042         (aarch64_ravenscar_store_registers): Now methods.
15043         (aarch64_ravenscar_ops): Redefine.
15044
15045 2019-02-15  Tom Tromey  <tromey@adacore.com>
15046
15047         * ravenscar-thread.c (ravenscar_thread_target::stopped_by_sw_breakpoint)
15048         (ravenscar_thread_target::stopped_by_hw_breakpoint)
15049         (ravenscar_thread_target::stopped_by_watchpoint)
15050         (ravenscar_thread_target::stopped_data_address)
15051         (ravenscar_thread_target::core_of_thread): Use scoped_restore.
15052
15053 2019-02-15  Tom Tromey  <tromey@adacore.com>
15054
15055         * ravenscar-thread.c: Fix some typos.
15056
15057 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15058             Tom Tromey  <tromey@adacore.com>
15059
15060         * ada-lang.c (ada_exception_sal): Change addr_string to a
15061         std::string.
15062         (create_ada_exception_catchpoint): Update.
15063
15064 2019-02-15  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15065             Tom Tromey  <tromey@adacore.com>
15066
15067         * breakpoint.c (~bp_location): Rename from bp_location_dtor.
15068         (bp_location_ops): Remove.
15069         (base_breakpoint_allocate_location): Update.
15070         (free_bp_location): Update.
15071         * ada-lang.c (class ada_catchpoint_location)
15072         <ada_catchpoint_location>: Remove ops parameter.
15073         (ada_catchpoint_location_dtor): Remove.
15074         (ada_catchpoint_location_ops): Remove.
15075         (allocate_location_exception): Update.
15076         * breakpoint.h (struct bp_location_ops): Remove.
15077         (class bp_location) <bp_location>: Remove bp_location_ops
15078         parameter.
15079         <~bp_location>: Add destructor.
15080         <ops>: Remove.
15081
15082 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15083             Pedro Alves  <palves@redhat.com>
15084
15085         * remote.c (remote_target::remote_parse_stop_reply): Avoid using
15086         'PATH_MAX'.
15087
15088 2019-02-14  David Michael  <fedora.dm0@gmail.com>
15089             Samuel Thibault  <samuel.thibault@gnu.org>
15090             Thomas Schwinge  <thomas@codesourcery.com>
15091
15092         * gnu-nat.c (S_proc_getmsgport_reply, S_proc_task2proc_reply)
15093         (S_proc_pid2proc_reply): Adjust to Hurd "proc" interface changes.
15094
15095 2019-02-14  Thomas Schwinge  <thomas@codesourcery.com>
15096
15097         * gnu-nat.c (gnu_write_inferior, parse_int_arg, _parse_bool_arg)
15098         (check_empty): Use "const char *".
15099
15100         * gnu-nat.c (gnu_nat_target::detach): Instead of
15101         'detach_inferior (pid)' call
15102         'detach_inferior (find_inferior_pid (pid))'.
15103
15104         * configure.nat [gdb_host == i386gnu] (NATDEPFILES): Add
15105         'nat/fork-inferior.o'.
15106         * gnu-nat.c: #include "nat/fork-inferior.h".
15107
15108         * gnu-nat.c (gnu_nat_target::detach): Instead of
15109         'inf_child_maybe_unpush_target (ops)' call 'maybe_unpush_target'.
15110         * gnu-nat.h: #include "inf-child.h".
15111         * i386-gnu-nat.c (gnu_fetch_registers): Rename/move to
15112         'i386_gnu_nat_target::fetch_registers'.
15113         (gnu_store_registers): Rename/move to
15114         'i386_gnu_nat_target::store_registers'.
15115
15116         * config/i386/nm-i386gnu.h: Don't "#include" any files.
15117         * gnu-nat.h (mach_thread_info): New function.
15118         * gnu-nat.c (thread_takeover_sc_cmd): Use it.
15119
15120         * config/i386/nm-i386gnu.h (gnu_target_pid_to_str): Remove.
15121
15122 2019-02-14  Frederic Konrad  <konrad@adacore.com>
15123
15124         * riscv-rdep.c (riscv_type_alignment): Handle TYPE_CODE_RANGE.
15125
15126 2019-02-14  Joel Brobecker  <brobecker@adacore.com>
15127
15128         * windows-nat.c (windows_add_thread): Add new parameter
15129         "main_thread_p" with default value set to false.  Update
15130         function documentation as well as all callers.
15131         (windows_delete_thread): Likewise.
15132         (fake_create_process): Update call to windows_add_thread.
15133         (get_windows_debug_event) <CREATE_THREAD_DEBUG_EVENT>
15134         <CREATE_PROCESS_DEBUG_EVENT>: Likewise.
15135         <EXIT_THREAD_DEBUG_EVENT, EXIT_PROCESS_DEBUG_EVENT>: Update
15136         call to windows_delete_thread.
15137
15138 2019-02-13  Simon Marchi  <simon.marchi@ericsson.com>
15139
15140         * MAINTAINERS: Add Andrew Burgess as global maintainer.
15141
15142 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15143
15144         * symfile.c (find_separate_debug_file): Use canonical path of
15145         sysroot with child_path instead of gdb_sysroot if it is valid.
15146
15147 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15148
15149         * symfile.c (find_separate_debug_file): Use child_path to
15150         determine if an object file is under a sysroot.
15151
15152 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15153
15154         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
15155         unittests/child-path-selftests.c.
15156         * common/pathstuff.c (child_path): New function.
15157         * common/pathstuff.h (child_path): New prototype.
15158         * unittests/child-path-selftests.c: New file.
15159
15160 2019-02-12  John Baldwin  <jhb@FreeBSD.org>
15161
15162         * symfile.c (find_separate_debug_file): Look for separate debug
15163         files in debug directories under the sysroot.
15164
15165 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15166
15167         * symtab.h (struct minimal_symbol data_p): New const method.
15168         (struct minimal_symbol text_p): Likewise.
15169         * symtab.c (output_source_filename): Use file name style
15170         to print file name.
15171         (print_symbol_info): Likewise.
15172         (print_msymbol_info): Use address style to print addresses.
15173         Use function name style to print executable text symbols.
15174         (expand_symtab_containing_pc): Use data_p.
15175         (find_pc_sect_compunit_symtab): Likewise.
15176
15177 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15178
15179         * breakpoint.c (describe_other_breakpoints): Use address style
15180         to print addresses.
15181         (say_where): Likewise.
15182
15183 2019-02-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15184
15185         * ada-typeprint.c (print_func_type): Print function name
15186         style to print function name.
15187         * c-typeprint.c (c_print_type_1): Likewise.
15188
15189 2019-02-11  Alan Hayward  <alan.hayward@arm.com>
15190
15191         * aarch64-linux-tdep.c (aarch64_linux_get_syscall_number): Check
15192         for execve.
15193
15194 2019-02-10  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15195
15196         * c-exp.y (direct_abs_decl): Use emplace_back to record the
15197         type_stack.
15198
15199 2019-02-10  Joel Brobecker  <brobecker@adacore.com>
15200
15201         * ada-varobj.c (ada_value_is_changeable_p): Add handling of
15202         TYPE_CODE_REF types.
15203
15204 2019-02-08  Jim Wilson  <jimw@sifive.com>
15205
15206         * riscv-linux-tdep.c (riscv_linux_fregmap): New.
15207         (riscv_linux_fregset): New.
15208         (riscv_linux_iterate_over_regset_sections): Call cb for .reg2 section.
15209
15210 2019-02-07  Tom Tromey  <tom@tromey.com>
15211
15212         * thread.c (thread_cancel_execution_command): Update.
15213         * thread-fsm.h (struct thread_fsm): Add constructor, destructor,
15214         methods.
15215         (struct thread_fsm_ops): Remove.
15216         (thread_fsm_ctor, thread_fsm_delete, thread_fsm_clean_up)
15217         (thread_fsm_should_stop, thread_fsm_return_value)
15218         (thread_fsm_set_finished, thread_fsm_finished_p)
15219         (thread_fsm_async_reply_reason, thread_fsm_should_notify_stop):
15220         Don't declare.
15221         * mi/mi-interp.c (mi_on_normal_stop_1): Update.
15222         * infrun.c (clear_proceed_status_thread)
15223         (clean_up_just_stopped_threads_fsms, fetch_inferior_event)
15224         (print_stop_event): Update.
15225         * infcmd.c (struct step_command_fsm): Inherit from thread_fsm.
15226         Add constructor.
15227         (step_command_fsm_ops): Remove.
15228         (new_step_command_fsm): Remove.
15229         (step_1): Update.
15230         (step_command_fsm::should_stop): Rename from
15231         step_command_fsm_should_stop.
15232         (step_command_fsm::clean_up): Rename from
15233         step_command_fsm_clean_up.
15234         (step_command_fsm::do_async_reply_reason): Rename from
15235         step_command_fsm_async_reply_reason.
15236         (struct until_next_fsm): Inherit from thread_fsm.  Add
15237         constructor.
15238         (until_next_fsm_ops): Remove.
15239         (new_until_next_fsm): Remove.
15240         (until_next_fsm::should_stop): Rename from
15241         until_next_fsm_should_stop.
15242         (until_next_fsm::clean_up): Rename from until_next_fsm_clean_up.
15243         (until_next_fsm::do_async_reply_reason): Rename from
15244         until_next_fsm_async_reply_reason.
15245         (struct finish_command_fsm): Inherit from thread_fsm.  Add
15246         constructor.  Change type of breakpoint.
15247         (finish_command_fsm_ops): Remove.
15248         (new_finish_command_fsm): Remove.
15249         (finish_command_fsm::should_stop): Rename from
15250         finish_command_fsm_should_stop.
15251         (finish_command_fsm::clean_up): Rename from
15252         finish_command_fsm_clean_up.
15253         (finish_command_fsm::return_value): Rename from
15254         finish_command_fsm_return_value.
15255         (finish_command_fsm::do_async_reply_reason): Rename from
15256         finish_command_fsm_async_reply_reason.
15257         (finish_command): Update.
15258         * infcall.c (struct call_thread_fsm): Inherit from thread_fsm.
15259         Add constructor.
15260         (call_thread_fsm_ops): Remove.
15261         (call_thread_fsm::call_thread_fsm): Rename from
15262         new_call_thread_fsm.
15263         (call_thread_fsm::should_stop): Rename from
15264         call_thread_fsm_should_stop.
15265         (call_thread_fsm::should_notify_stop): Rename from
15266         call_thread_fsm_should_notify_stop.
15267         (run_inferior_call, call_function_by_hand_dummy): Update.
15268         * cli/cli-interp.c (should_print_stop_to_console): Update.
15269         * breakpoint.c (struct until_break_fsm): Inherit from thread_fsm.
15270         Add constructor.  Change type of location_breakpoint,
15271         caller_breakpoint.
15272         (until_break_fsm_ops): Remove.
15273         (new_until_break_fsm): Remove.
15274         (until_break_fsm::should_stop): Rename from
15275         until_break_fsm_should_stop.
15276         (until_break_fsm::clean_up): Rename from
15277         until_break_fsm_clean_up.
15278         (until_break_fsm::do_async_reply_reason): Rename from
15279         until_break_fsm_async_reply_reason.
15280         (until_break_command): Update.
15281         * thread-fsm.c: Remove.
15282         * Makefile.in (COMMON_SFILES): Remove thread-fsm.c.
15283
15284 2019-02-07  Tom Tromey  <tom@tromey.com>
15285
15286         * yy-remap.h: Add include guard.
15287         * xtensa-tdep.h: Add include guard.
15288         * xcoffread.h: Rename include guard.
15289         * varobj-iter.h: Add include guard.
15290         * tui/tui.h: Rename include guard.
15291         * tui/tui-winsource.h: Rename include guard.
15292         * tui/tui-wingeneral.h: Rename include guard.
15293         * tui/tui-windata.h: Rename include guard.
15294         * tui/tui-win.h: Rename include guard.
15295         * tui/tui-stack.h: Rename include guard.
15296         * tui/tui-source.h: Rename include guard.
15297         * tui/tui-regs.h: Rename include guard.
15298         * tui/tui-out.h: Rename include guard.
15299         * tui/tui-layout.h: Rename include guard.
15300         * tui/tui-io.h: Rename include guard.
15301         * tui/tui-hooks.h: Rename include guard.
15302         * tui/tui-file.h: Rename include guard.
15303         * tui/tui-disasm.h: Rename include guard.
15304         * tui/tui-data.h: Rename include guard.
15305         * tui/tui-command.h: Rename include guard.
15306         * tic6x-tdep.h: Add include guard.
15307         * target/waitstatus.h: Rename include guard.
15308         * target/wait.h: Rename include guard.
15309         * target/target.h: Rename include guard.
15310         * target/resume.h: Rename include guard.
15311         * target-float.h: Rename include guard.
15312         * stabsread.h: Add include guard.
15313         * rs6000-tdep.h: Add include guard.
15314         * riscv-fbsd-tdep.h: Add include guard.
15315         * regformats/regdef.h: Rename include guard.
15316         * record.h: Rename include guard.
15317         * python/python.h: Rename include guard.
15318         * python/python-internal.h: Rename include guard.
15319         * python/py-stopevent.h: Rename include guard.
15320         * python/py-ref.h: Rename include guard.
15321         * python/py-record.h: Rename include guard.
15322         * python/py-record-full.h: Rename include guard.
15323         * python/py-record-btrace.h: Rename include guard.
15324         * python/py-instruction.h: Rename include guard.
15325         * python/py-events.h: Rename include guard.
15326         * python/py-event.h: Rename include guard.
15327         * procfs.h: Add include guard.
15328         * proc-utils.h: Add include guard.
15329         * p-lang.h: Add include guard.
15330         * or1k-tdep.h: Rename include guard.
15331         * observable.h: Rename include guard.
15332         * nto-tdep.h: Rename include guard.
15333         * nat/x86-linux.h: Rename include guard.
15334         * nat/x86-linux-dregs.h: Rename include guard.
15335         * nat/x86-gcc-cpuid.h: Add include guard.
15336         * nat/x86-dregs.h: Rename include guard.
15337         * nat/x86-cpuid.h: Rename include guard.
15338         * nat/ppc-linux.h: Rename include guard.
15339         * nat/mips-linux-watch.h: Rename include guard.
15340         * nat/linux-waitpid.h: Rename include guard.
15341         * nat/linux-ptrace.h: Rename include guard.
15342         * nat/linux-procfs.h: Rename include guard.
15343         * nat/linux-osdata.h: Rename include guard.
15344         * nat/linux-nat.h: Rename include guard.
15345         * nat/linux-namespaces.h: Rename include guard.
15346         * nat/linux-btrace.h: Rename include guard.
15347         * nat/glibc_thread_db.h: Rename include guard.
15348         * nat/gdb_thread_db.h: Rename include guard.
15349         * nat/gdb_ptrace.h: Rename include guard.
15350         * nat/fork-inferior.h: Rename include guard.
15351         * nat/amd64-linux-siginfo.h: Rename include guard.
15352         * nat/aarch64-sve-linux-sigcontext.h: Rename include guard.
15353         * nat/aarch64-sve-linux-ptrace.h: Rename include guard.
15354         * nat/aarch64-linux.h: Rename include guard.
15355         * nat/aarch64-linux-hw-point.h: Rename include guard.
15356         * mn10300-tdep.h: Add include guard.
15357         * mips-linux-tdep.h: Add include guard.
15358         * mi/mi-parse.h: Rename include guard.
15359         * mi/mi-out.h: Rename include guard.
15360         * mi/mi-main.h: Rename include guard.
15361         * mi/mi-interp.h: Rename include guard.
15362         * mi/mi-getopt.h: Rename include guard.
15363         * mi/mi-console.h: Rename include guard.
15364         * mi/mi-common.h: Rename include guard.
15365         * mi/mi-cmds.h: Rename include guard.
15366         * mi/mi-cmd-break.h: Rename include guard.
15367         * m2-lang.h: Add include guard.
15368         * location.h: Rename include guard.
15369         * linux-record.h: Rename include guard.
15370         * linux-nat.h: Add include guard.
15371         * linux-fork.h: Add include guard.
15372         * i386-darwin-tdep.h: Rename include guard.
15373         * hppa-linux-offsets.h: Add include guard.
15374         * guile/guile.h: Rename include guard.
15375         * guile/guile-internal.h: Rename include guard.
15376         * gnu-nat.h: Rename include guard.
15377         * gdb-stabs.h: Rename include guard.
15378         * frv-tdep.h: Add include guard.
15379         * f-lang.h: Add include guard.
15380         * event-loop.h: Add include guard.
15381         * darwin-nat.h: Rename include guard.
15382         * cp-abi.h: Rename include guard.
15383         * config/sparc/nm-sol2.h: Rename include guard.
15384         * config/nm-nto.h: Rename include guard.
15385         * config/nm-linux.h: Add include guard.
15386         * config/i386/nm-i386gnu.h: Rename include guard.
15387         * config/djgpp/nl_types.h: Rename include guard.
15388         * config/djgpp/langinfo.h: Rename include guard.
15389         * compile/gcc-cp-plugin.h: Add include guard.
15390         * compile/gcc-c-plugin.h: Add include guard.
15391         * compile/compile.h: Rename include guard.
15392         * compile/compile-object-run.h: Rename include guard.
15393         * compile/compile-object-load.h: Rename include guard.
15394         * compile/compile-internal.h: Rename include guard.
15395         * compile/compile-cplus.h: Rename include guard.
15396         * compile/compile-c.h: Rename include guard.
15397         * common/xml-utils.h: Rename include guard.
15398         * common/x86-xstate.h: Rename include guard.
15399         * common/version.h: Rename include guard.
15400         * common/vec.h: Rename include guard.
15401         * common/tdesc.h: Rename include guard.
15402         * common/selftest.h: Rename include guard.
15403         * common/scoped_restore.h: Rename include guard.
15404         * common/scoped_mmap.h: Rename include guard.
15405         * common/scoped_fd.h: Rename include guard.
15406         * common/safe-iterator.h: Rename include guard.
15407         * common/run-time-clock.h: Rename include guard.
15408         * common/refcounted-object.h: Rename include guard.
15409         * common/queue.h: Rename include guard.
15410         * common/ptid.h: Rename include guard.
15411         * common/print-utils.h: Rename include guard.
15412         * common/preprocessor.h: Rename include guard.
15413         * common/pathstuff.h: Rename include guard.
15414         * common/observable.h: Rename include guard.
15415         * common/netstuff.h: Rename include guard.
15416         * common/job-control.h: Rename include guard.
15417         * common/host-defs.h: Rename include guard.
15418         * common/gdb_wait.h: Rename include guard.
15419         * common/gdb_vecs.h: Rename include guard.
15420         * common/gdb_unlinker.h: Rename include guard.
15421         * common/gdb_unique_ptr.h: Rename include guard.
15422         * common/gdb_tilde_expand.h: Rename include guard.
15423         * common/gdb_sys_time.h: Rename include guard.
15424         * common/gdb_string_view.h: Rename include guard.
15425         * common/gdb_splay_tree.h: Rename include guard.
15426         * common/gdb_setjmp.h: Rename include guard.
15427         * common/gdb_ref_ptr.h: Rename include guard.
15428         * common/gdb_optional.h: Rename include guard.
15429         * common/gdb_locale.h: Rename include guard.
15430         * common/gdb_assert.h: Rename include guard.
15431         * common/filtered-iterator.h: Rename include guard.
15432         * common/filestuff.h: Rename include guard.
15433         * common/fileio.h: Rename include guard.
15434         * common/environ.h: Rename include guard.
15435         * common/common-utils.h: Rename include guard.
15436         * common/common-types.h: Rename include guard.
15437         * common/common-regcache.h: Rename include guard.
15438         * common/common-inferior.h: Rename include guard.
15439         * common/common-gdbthread.h: Rename include guard.
15440         * common/common-exceptions.h: Rename include guard.
15441         * common/common-defs.h: Rename include guard.
15442         * common/common-debug.h: Rename include guard.
15443         * common/cleanups.h: Rename include guard.
15444         * common/buffer.h: Rename include guard.
15445         * common/btrace-common.h: Rename include guard.
15446         * common/break-common.h: Rename include guard.
15447         * cli/cli-utils.h: Rename include guard.
15448         * cli/cli-style.h: Rename include guard.
15449         * cli/cli-setshow.h: Rename include guard.
15450         * cli/cli-script.h: Rename include guard.
15451         * cli/cli-interp.h: Rename include guard.
15452         * cli/cli-decode.h: Rename include guard.
15453         * cli/cli-cmds.h: Rename include guard.
15454         * charset-list.h: Add include guard.
15455         * buildsym-legacy.h: Rename include guard.
15456         * bfin-tdep.h: Add include guard.
15457         * ax.h: Rename include guard.
15458         * arm-linux-tdep.h: Add include guard.
15459         * arm-fbsd-tdep.h: Add include guard.
15460         * arch/xtensa.h: Rename include guard.
15461         * arch/tic6x.h: Add include guard.
15462         * arch/i386.h: Add include guard.
15463         * arch/arm.h: Rename include guard.
15464         * arch/arm-linux.h: Rename include guard.
15465         * arch/arm-get-next-pcs.h: Rename include guard.
15466         * arch/amd64.h: Add include guard.
15467         * arch/aarch64-insn.h: Rename include guard.
15468         * arch-utils.h: Rename include guard.
15469         * annotate.h: Add include guard.
15470         * amd64-darwin-tdep.h: Rename include guard.
15471         * aarch64-linux-tdep.h: Add include guard.
15472         * aarch64-fbsd-tdep.h: Add include guard.
15473         * aarch32-linux-nat.h: Add include guard.
15474
15475 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15476
15477         * macrotab.c (macro_define_internal): New function that
15478         factorizes macro_define_object_internal and macro_define_function
15479         code.
15480         (macro_define_object_internal): Use macro_define_internal.
15481         (macro_define_function): Likewise.
15482
15483 2019-02-06  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15484
15485         * macrocmd.c (extract_identifier): Return
15486         a gdb::unique_xmalloc_ptr<char> instead of a char *, and update
15487         callers.
15488
15489 2019-02-06  John Baldwin  <jhb@FreeBSD.org>
15490
15491         * fbsd-nat.c (fbsd_fetch_cmdline): Join arguments with spaces.
15492
15493 2019-02-05  Tom Tromey  <tom@tromey.com>
15494
15495         * target.c (target_stack::unpush): Move assertion earlier.
15496
15497 2019-01-30  Tom Tromey  <tom@tromey.com>
15498
15499         PR python/23615:
15500         * python/python.c (execute_gdb_command): Use gdbpy_allow_threads.
15501         (gdbpy_parse_and_eval): Likewise.
15502         * python/python-internal.h (gdbpy_allow_threads): New class.
15503
15504 2019-01-28  John Baldwin  <jhb@FreeBSD.org>
15505
15506         * aarch64-fbsd-tdep.c (aarch64_fbsd_gregmap)
15507         (aarch64_fbsd_fpregmap): Move earlier.
15508         (AARCH64_MCONTEXT_REG_SIZE, AARCH64_MCONTEXT_FPREG_SIZE): Delete.
15509         (aarch64_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15510         instead of individual calls to trad_frame_set_reg_addr.
15511         * arm-fbsd-tdep.c (arm_fbsd_gregmap, arm_fbsd_vfpregmap): Move
15512         earlier.
15513         (ARM_MCONTEXT_REG_SIZE, ARM_MCONTEXT_VFP_REG_SIZE): Delete.
15514         (arm_fbsd_sigframe_init): Use trad_frame_set_reg_regmap
15515         instead of individual calls to trad_frame_set_reg_addr.
15516
15517 2019-01-28  Alan Hayward  <alan.hayward@arm.com>
15518
15519         * CONTRIBUTE: Replace contribution list with wiki link.
15520
15521 2019-01-25  Tom Tromey  <tom@tromey.com>
15522
15523         * Makefile.in (GDB_CFLAGS): Don't add -I for common.
15524
15525 2019-01-25  Tom Tromey  <tom@tromey.com>
15526
15527         * xtensa-linux-nat.c: Fix common/ includes.
15528         * xml-support.h: Fix common/ includes.
15529         * xml-support.c: Fix common/ includes.
15530         * x86-linux-nat.c: Fix common/ includes.
15531         * windows-nat.c: Fix common/ includes.
15532         * varobj.h: Fix common/ includes.
15533         * varobj.c: Fix common/ includes.
15534         * value.c: Fix common/ includes.
15535         * valops.c: Fix common/ includes.
15536         * utils.c: Fix common/ includes.
15537         * unittests/xml-utils-selftests.c: Fix common/ includes.
15538         * unittests/utils-selftests.c: Fix common/ includes.
15539         * unittests/unpack-selftests.c: Fix common/ includes.
15540         * unittests/tracepoint-selftests.c: Fix common/ includes.
15541         * unittests/style-selftests.c: Fix common/ includes.
15542         * unittests/string_view-selftests.c: Fix common/ includes.
15543         * unittests/scoped_restore-selftests.c: Fix common/ includes.
15544         * unittests/scoped_mmap-selftests.c: Fix common/ includes.
15545         * unittests/scoped_fd-selftests.c: Fix common/ includes.
15546         * unittests/rsp-low-selftests.c: Fix common/ includes.
15547         * unittests/parse-connection-spec-selftests.c: Fix common/
15548         includes.
15549         * unittests/optional-selftests.c: Fix common/ includes.
15550         * unittests/offset-type-selftests.c: Fix common/ includes.
15551         * unittests/observable-selftests.c: Fix common/ includes.
15552         * unittests/mkdir-recursive-selftests.c: Fix common/ includes.
15553         * unittests/memrange-selftests.c: Fix common/ includes.
15554         * unittests/memory-map-selftests.c: Fix common/ includes.
15555         * unittests/lookup_name_info-selftests.c: Fix common/ includes.
15556         * unittests/function-view-selftests.c: Fix common/ includes.
15557         * unittests/environ-selftests.c: Fix common/ includes.
15558         * unittests/copy_bitwise-selftests.c: Fix common/ includes.
15559         * unittests/common-utils-selftests.c: Fix common/ includes.
15560         * unittests/cli-utils-selftests.c: Fix common/ includes.
15561         * unittests/array-view-selftests.c: Fix common/ includes.
15562         * ui-file.c: Fix common/ includes.
15563         * tui/tui-io.c: Fix common/ includes.
15564         * tracepoint.h: Fix common/ includes.
15565         * tracepoint.c: Fix common/ includes.
15566         * tracefile-tfile.c: Fix common/ includes.
15567         * top.h: Fix common/ includes.
15568         * top.c: Fix common/ includes.
15569         * thread.c: Fix common/ includes.
15570         * target/waitstatus.h: Fix common/ includes.
15571         * target/waitstatus.c: Fix common/ includes.
15572         * target.h: Fix common/ includes.
15573         * target.c: Fix common/ includes.
15574         * target-memory.c: Fix common/ includes.
15575         * target-descriptions.c: Fix common/ includes.
15576         * symtab.h: Fix common/ includes.
15577         * symfile.c: Fix common/ includes.
15578         * stap-probe.c: Fix common/ includes.
15579         * spu-linux-nat.c: Fix common/ includes.
15580         * sparc-nat.c: Fix common/ includes.
15581         * source.c: Fix common/ includes.
15582         * solib.c: Fix common/ includes.
15583         * solib-target.c: Fix common/ includes.
15584         * ser-unix.c: Fix common/ includes.
15585         * ser-tcp.c: Fix common/ includes.
15586         * ser-pipe.c: Fix common/ includes.
15587         * ser-base.c: Fix common/ includes.
15588         * selftest-arch.c: Fix common/ includes.
15589         * s12z-tdep.c: Fix common/ includes.
15590         * rust-exp.y: Fix common/ includes.
15591         * rs6000-aix-tdep.c: Fix common/ includes.
15592         * riscv-tdep.c: Fix common/ includes.
15593         * remote.c: Fix common/ includes.
15594         * remote-notif.h: Fix common/ includes.
15595         * remote-fileio.h: Fix common/ includes.
15596         * remote-fileio.c: Fix common/ includes.
15597         * regcache.h: Fix common/ includes.
15598         * regcache.c: Fix common/ includes.
15599         * record-btrace.c: Fix common/ includes.
15600         * python/python.c: Fix common/ includes.
15601         * python/py-type.c: Fix common/ includes.
15602         * python/py-inferior.c: Fix common/ includes.
15603         * progspace.h: Fix common/ includes.
15604         * producer.c: Fix common/ includes.
15605         * procfs.c: Fix common/ includes.
15606         * proc-api.c: Fix common/ includes.
15607         * printcmd.c: Fix common/ includes.
15608         * ppc-linux-nat.c: Fix common/ includes.
15609         * parser-defs.h: Fix common/ includes.
15610         * osdata.c: Fix common/ includes.
15611         * obsd-nat.c: Fix common/ includes.
15612         * nat/x86-linux.c: Fix common/ includes.
15613         * nat/x86-linux-dregs.c: Fix common/ includes.
15614         * nat/x86-dregs.h: Fix common/ includes.
15615         * nat/x86-dregs.c: Fix common/ includes.
15616         * nat/ppc-linux.c: Fix common/ includes.
15617         * nat/mips-linux-watch.h: Fix common/ includes.
15618         * nat/mips-linux-watch.c: Fix common/ includes.
15619         * nat/linux-waitpid.c: Fix common/ includes.
15620         * nat/linux-ptrace.h: Fix common/ includes.
15621         * nat/linux-ptrace.c: Fix common/ includes.
15622         * nat/linux-procfs.c: Fix common/ includes.
15623         * nat/linux-personality.c: Fix common/ includes.
15624         * nat/linux-osdata.c: Fix common/ includes.
15625         * nat/linux-namespaces.c: Fix common/ includes.
15626         * nat/linux-btrace.h: Fix common/ includes.
15627         * nat/linux-btrace.c: Fix common/ includes.
15628         * nat/fork-inferior.c: Fix common/ includes.
15629         * nat/amd64-linux-siginfo.c: Fix common/ includes.
15630         * nat/aarch64-sve-linux-ptrace.c: Fix common/ includes.
15631         * nat/aarch64-linux.c: Fix common/ includes.
15632         * nat/aarch64-linux-hw-point.h: Fix common/ includes.
15633         * nat/aarch64-linux-hw-point.c: Fix common/ includes.
15634         * namespace.h: Fix common/ includes.
15635         * mips-linux-tdep.c: Fix common/ includes.
15636         * minsyms.c: Fix common/ includes.
15637         * mi/mi-parse.h: Fix common/ includes.
15638         * mi/mi-main.c: Fix common/ includes.
15639         * mi/mi-cmd-env.c: Fix common/ includes.
15640         * memrange.h: Fix common/ includes.
15641         * memattr.c: Fix common/ includes.
15642         * maint.h: Fix common/ includes.
15643         * maint.c: Fix common/ includes.
15644         * main.c: Fix common/ includes.
15645         * machoread.c: Fix common/ includes.
15646         * location.c: Fix common/ includes.
15647         * linux-thread-db.c: Fix common/ includes.
15648         * linux-nat.c: Fix common/ includes.
15649         * linux-fork.c: Fix common/ includes.
15650         * inline-frame.c: Fix common/ includes.
15651         * infrun.c: Fix common/ includes.
15652         * inflow.c: Fix common/ includes.
15653         * inferior.h: Fix common/ includes.
15654         * inferior.c: Fix common/ includes.
15655         * infcmd.c: Fix common/ includes.
15656         * inf-ptrace.c: Fix common/ includes.
15657         * inf-child.c: Fix common/ includes.
15658         * ia64-linux-nat.c: Fix common/ includes.
15659         * i387-tdep.c: Fix common/ includes.
15660         * i386-tdep.c: Fix common/ includes.
15661         * i386-linux-tdep.c: Fix common/ includes.
15662         * i386-linux-nat.c: Fix common/ includes.
15663         * i386-go32-tdep.c: Fix common/ includes.
15664         * i386-fbsd-tdep.c: Fix common/ includes.
15665         * i386-fbsd-nat.c: Fix common/ includes.
15666         * guile/scm-type.c: Fix common/ includes.
15667         * guile/guile.c: Fix common/ includes.
15668         * go32-nat.c: Fix common/ includes.
15669         * gnu-nat.c: Fix common/ includes.
15670         * gdbthread.h: Fix common/ includes.
15671         * gdbarch-selftests.c: Fix common/ includes.
15672         * gdb_usleep.c: Fix common/ includes.
15673         * gdb_select.h: Fix common/ includes.
15674         * gdb_bfd.c: Fix common/ includes.
15675         * gcore.c: Fix common/ includes.
15676         * fork-child.c: Fix common/ includes.
15677         * findvar.c: Fix common/ includes.
15678         * fbsd-nat.c: Fix common/ includes.
15679         * event-top.c: Fix common/ includes.
15680         * event-loop.c: Fix common/ includes.
15681         * dwarf2read.c: Fix common/ includes.
15682         * dwarf2loc.c: Fix common/ includes.
15683         * dwarf2-frame.c: Fix common/ includes.
15684         * dwarf-index-cache.c: Fix common/ includes.
15685         * dtrace-probe.c: Fix common/ includes.
15686         * disasm-selftests.c: Fix common/ includes.
15687         * defs.h: Fix common/ includes.
15688         * csky-tdep.c: Fix common/ includes.
15689         * cp-valprint.c: Fix common/ includes.
15690         * cp-support.h: Fix common/ includes.
15691         * cp-support.c: Fix common/ includes.
15692         * corelow.c: Fix common/ includes.
15693         * completer.h: Fix common/ includes.
15694         * completer.c: Fix common/ includes.
15695         * compile/compile.c: Fix common/ includes.
15696         * compile/compile-loc2c.c: Fix common/ includes.
15697         * compile/compile-cplus-types.c: Fix common/ includes.
15698         * compile/compile-cplus-symbols.c: Fix common/ includes.
15699         * command.h: Fix common/ includes.
15700         * cli/cli-dump.c: Fix common/ includes.
15701         * cli/cli-cmds.c: Fix common/ includes.
15702         * charset.c: Fix common/ includes.
15703         * build-id.c: Fix common/ includes.
15704         * btrace.h: Fix common/ includes.
15705         * btrace.c: Fix common/ includes.
15706         * breakpoint.h: Fix common/ includes.
15707         * breakpoint.c: Fix common/ includes.
15708         * ax.h:
15709         (enum agent_op): Fix common/ includes.
15710         * ax-general.c (struct aop_map): Fix common/ includes.
15711         * ax-gdb.c: Fix common/ includes.
15712         * auxv.c: Fix common/ includes.
15713         * auto-load.c: Fix common/ includes.
15714         * arm-tdep.c: Fix common/ includes.
15715         * arch/riscv.c: Fix common/ includes.
15716         * arch/ppc-linux-common.c: Fix common/ includes.
15717         * arch/i386.c: Fix common/ includes.
15718         * arch/arm.c: Fix common/ includes.
15719         * arch/arm-linux.c: Fix common/ includes.
15720         * arch/arm-get-next-pcs.c: Fix common/ includes.
15721         * arch/amd64.c: Fix common/ includes.
15722         * arch/aarch64.c: Fix common/ includes.
15723         * arch/aarch64-insn.c: Fix common/ includes.
15724         * arch-utils.c: Fix common/ includes.
15725         * amd64-windows-tdep.c: Fix common/ includes.
15726         * amd64-tdep.c: Fix common/ includes.
15727         * amd64-sol2-tdep.c: Fix common/ includes.
15728         * amd64-obsd-tdep.c: Fix common/ includes.
15729         * amd64-nbsd-tdep.c: Fix common/ includes.
15730         * amd64-linux-tdep.c: Fix common/ includes.
15731         * amd64-linux-nat.c: Fix common/ includes.
15732         * amd64-fbsd-tdep.c: Fix common/ includes.
15733         * amd64-fbsd-nat.c: Fix common/ includes.
15734         * amd64-dicos-tdep.c: Fix common/ includes.
15735         * amd64-darwin-tdep.c: Fix common/ includes.
15736         * agent.c: Fix common/ includes.
15737         * ada-lang.h: Fix common/ includes.
15738         * ada-lang.c: Fix common/ includes.
15739         * aarch64-tdep.c: Fix common/ includes.
15740
15741 2019-01-25  Tom Tromey  <tom@tromey.com>
15742
15743         * common/create-version.sh: Use common/version.h.
15744
15745 2019-01-24  Pedro Alves  <palves@redhat.com>
15746
15747         * infrun.c (signal_stop, signal_print, signal_program)
15748         (signal_catch, signal_pass): Now arrays instead of pointers.
15749         (update_signals_program_target, do_target_resume)
15750         (signal_catch_update, handle_command, _initialize_infrun): Adjust.
15751         * linux-nat.c (linux_nat_target::pass_signals)
15752         (linux_nat_target::create_inferior, linux_nat_target::attach):
15753         Adjust.
15754         * linux-nat.h (linux_nat_target::pass_signals): Adjust.
15755         * nto-procfs.c (nto_procfs_target::pass_signals): Adjust.
15756         * procfs.c (procfs_target::pass_signals): Adjust.
15757         * record-full.c (record_full_target::resume): Adjust.
15758         * remote.c (remote_target::pass_signals)
15759         (remote_target::program_signals): Adjust.
15760         * target-debug.h (target_debug_print_signals): Now takes a
15761         gdb::array_view as parameter.  Adjust.
15762         * target.h (target_ops) <pass_signals, program_signals>: Replace
15763         pointer and length parameters with gdb::array_view.
15764         (target_pass_signals, target_program_signals): Likewise.
15765         * target-delegates.c: Regenerate.
15766
15767 2019-01-24  Pedro Alves  <palves@redhat.com>
15768
15769         * common/forward-scope-exit.h
15770         (forward_scope_exit::forward_scope_exit): Pass arguments to
15771         m_bind_function directly, instead of creating a std::bind and
15772         copying that.
15773
15774 2019-01-24  Alan Hayward  <alan.hayward@arm.com>
15775
15776         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15777         for static members.
15778         (pass_in_v_vfp_candidate): Likewise.
15779
15780 2019-01-23  Tom Tromey  <tom@tromey.com>
15781             Pedro Alves  <palves@redhat.com>
15782
15783         * regcache.c (class regcache_invalidator): Remove.
15784         (regcache::raw_write): Use make_scope_exit.
15785
15786 2019-01-23  Tom Tromey  <tom@tromey.com>
15787
15788         * ui-out.h (class ui_out_emit_type): Update comment.
15789
15790 2019-01-23  Tom Tromey  <tom@tromey.com>
15791
15792         * infrun.c (fetch_inferior_event): Update comment.
15793
15794 2019-01-23  Tom Tromey  <tom@tromey.com>
15795             Pedro Alves  <palves@redhat.com>
15796
15797         * infrun.c (reinstall_readline_callback_handler_cleanup): Remove
15798         parameter.
15799         (fetch_inferior_event): Use SCOPE_EXIT.
15800
15801
15802 2019-01-23  Tom Tromey  <tom@tromey.com>
15803             Pedro Alves  <palves@redhat.com>
15804
15805         * infrun.c (disable_thread_events): Delete.
15806         (stop_all_threads): Use SCOPE_EXIT.
15807
15808 2019-01-23  Tom Tromey  <tom@tromey.com>
15809             Pedro Alves  <palves@redhat.com>
15810
15811         * symfile.c: Include forward-scope-exit.h.
15812         (clear_symtab_users_cleanup): Replace forward declaration with
15813         a FORWARD_SCOPE_EXIT.
15814         (syms_from_objfile_1): Use the forward_scope_exit and
15815         gdb::optional instead of cleanup_function.
15816         (reread_symbols): Use the forward_scope_exit instead of
15817         cleanup_function.
15818         (clear_symtab_users_cleanup): Remove function.
15819
15820 2019-01-23  Tom Tromey  <tom@tromey.com>
15821             Pedro Alves  <palves@redhat.com>
15822
15823         * linux-nat.c: Include scope-exit.h.
15824         (cleanup_target_stop): Remove.
15825         (linux_nat_target::static_tracepoint_markers_by_strid): Use
15826         SCOPE_EXIT.
15827
15828 2019-01-23  Tom Tromey  <tom@tromey.com>
15829             Pedro Alves  <palves@redhat.com>
15830
15831         * infcall.c (cleanup_delete_std_terminate_breakpoint): Remove.
15832         (call_function_by_hand_dummy): Use SCOPE_EXIT.
15833
15834 2019-01-23  Tom Tromey  <tom@tromey.com>
15835             Andrew Burgess  <andrew.burgess@embecosm.com>
15836             Pedro Alves  <palves@redhat.com>
15837
15838         * infrun.c (fetch_inferior_event): Use scope_exit.
15839         * utils.h (make_bpstat_clear_actions_cleanup): Don't declare.
15840         * top.c (execute_command): Use scope_exit.
15841         * breakpoint.c (bpstat_do_actions): Use scope_exit.
15842         * utils.c (do_bpstat_clear_actions_cleanup)
15843         (make_bpstat_clear_actions_cleanup): Remove.
15844
15845 2019-01-23  Tom Tromey  <tom@tromey.com>
15846             Pedro Alves  <palves@redhat.com>
15847
15848         * infrun.c: Include "common/scope-exit.h"
15849         (delete_just_stopped_threads_infrun_breakpoints_cleanup): Remove.
15850         (wait_for_inferior): Use SCOPE_EXIT.
15851         (fetch_inferior_event): Use scope_exit.
15852
15853 2019-01-23  Tom Tromey  <tom@tromey.com>
15854             Pedro Alves  <palves@redhat.com>
15855
15856         * breakpoint.c (create_breakpoint): Remove cleanup.
15857
15858 2019-01-23  Tom Tromey  <tom@tromey.com>
15859             Andrew Burgess  <andrew.burgess@embecosm.com>
15860             Pedro Alves  <palves@redhat.com>
15861
15862 2019-01-23  Pedro Alves  <palves@redhat.com>
15863
15864         * gdbarch-selftests.c (struct on_exit): Use SCOPE_EXIT.
15865
15866 2019-01-23  Pedro Alves  <palves@redhat.com>
15867             Andrew Burgess  <andrew.burgess@embecosm.com>
15868
15869         * gdbthread.h: Include "common/forward-scope-exit.h".
15870         (scoped_finish_thread_state): Redefine custom class in terms of
15871         forward_scope_exit.
15872
15873 2019-01-23  Pedro Alves  <palves@redhat.com>
15874             Andrew Burgess  <andrew.burgess@embecosm.com>
15875
15876         * common/forward-scope-exit.h: New file.
15877
15878 2019-01-23  Pedro Alves  <palves@redhat.com>
15879             Andrew Burgess  <andrew.burgess@embecosm.com>
15880             Tom Tromey  <tom@tromey.com>
15881
15882         * common/scope-exit.h: New file.
15883
15884 2019-01-23  Pedro Alves  <palves@redhat.com>
15885
15886         * common/preprocessor.h (ESC): Rename to ...
15887         (ESC_PARENS): ... this.
15888         * common/valid-expr.h (CHECK_VALID_EXPR_1, CHECK_VALID_EXPR_2)
15889         (CHECK_VALID_EXPR_3, CHECK_VALID_EXPR_4): Adjust.
15890
15891 2019-01-23  Tom Tromey  <tom@tromey.com>
15892
15893         * language.h (class scoped_switch_to_sym_language_if_auto):
15894         Initialize m_lang in both cases.
15895
15896 2019-01-23  Alan Hayward  <alan.hayward@arm.com>
15897
15898         * nat/aarch64-linux.c (aarch64_linux_new_thread): Replace XNEW
15899         with XCNEW.
15900
15901 2019-01-22  Tom Tromey  <tom@tromey.com>
15902
15903         * corelow.c: Do not include sys/file.h.
15904
15905 2019-01-22  Tom Tromey  <tom@tromey.com>
15906
15907         * tui/tui-wingeneral.h: Include gdb_curses.h.
15908
15909 2019-01-22  Tom Tromey  <tom@tromey.com>
15910
15911         * source-cache.h (class source_cache) <get_source_lines,
15912         get_plain_source_lines, extract_lines>: Rename "lines" parameter.
15913
15914 2019-01-22  Tom Tromey  <tom@tromey.com>
15915
15916         * remote-fileio.h (struct remote_target): Declare.
15917
15918 2019-01-22  Tom Tromey  <tom@tromey.com>
15919
15920         * python/py-arch.c: Do not include py-ref.h.
15921         * python/py-bpevent.c: Do not include py-ref.h.
15922         * python/py-cmd.c: Do not include py-ref.h.
15923         * python/py-continueevent.c: Do not include py-ref.h.
15924         * python/py-event.h: Do not include py-ref.h.
15925         * python/py-evtregistry.c: Do not include py-ref.h.
15926         * python/py-finishbreakpoint.c: Do not include py-ref.h.
15927         * python/py-frame.c: Do not include py-ref.h.
15928         * python/py-framefilter.c: Do not include py-ref.h.
15929         * python/py-function.c: Do not include py-ref.h.
15930         * python/py-infevents.c: Do not include py-ref.h.
15931         * python/py-linetable.c: Do not include py-ref.h.
15932         * python/py-objfile.c: Do not include py-ref.h.
15933         * python/py-param.c: Do not include py-ref.h.
15934         * python/py-prettyprint.c: Do not include py-ref.h.
15935         * python/py-progspace.c: Do not include py-ref.h.
15936         * python/py-symbol.c: Do not include py-ref.h.
15937         * python/py-symtab.c: Do not include py-ref.h.
15938         * python/py-type.c: Do not include py-ref.h.
15939         * python/py-unwind.c: Do not include py-ref.h.
15940         * python/py-utils.c: Do not include py-ref.h.
15941         * python/py-value.c: Do not include py-ref.h.
15942         * python/py-varobj.c: Do not include py-ref.h.
15943         * python/py-xmethods.c: Do not include py-ref.h.
15944         * python/python.c: Do not include py-ref.h.
15945         * varobj.c: Do not include py-ref.h.
15946
15947 2019-01-22  Tom Tromey  <tom@tromey.com>
15948
15949         * objfiles.h (struct objfile_per_bfd_storage): Use "struct"
15950         keyword for bcache.
15951
15952 2019-01-22  Tom Tromey  <tom@tromey.com>
15953
15954         * compile/compile-cplus-types.c: Remove a comment by #include.
15955
15956 2019-01-22  Tom Tromey  <tom@tromey.com>
15957
15958         * compile/gcc-c-plugin.h: Include compile-internal.h.
15959
15960 2019-01-22  Tom Tromey  <tom@tromey.com>
15961
15962         * stabsread.c (EXTERN): Do not define.
15963         (symnum, next_symbol_text_func, processing_gcc_compilation)
15964         (within_function, global_sym_chain, global_stabs)
15965         (previous_stab_code, this_object_header_files)
15966         (n_this_object_header_files)
15967         (n_allocated_this_object_header_files): Define.
15968         * stabsread.h (EXTERN): Never define.  Use "extern".
15969
15970 2019-01-22  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
15971
15972         * event-top.c (handle_line_of_input): use unique_xmalloc_ptr for
15973         history_value.
15974
15975 2019-01-21  Tom Tromey  <tom@tromey.com>
15976
15977         * ui-out.c: Fix includes.
15978         * tui/tui-source.c: Fix includes.
15979         * target.c: Fix includes.
15980         * remote.c: Fix includes.
15981         * regcache.c: Fix includes.
15982         * python/py-block.c: Fix includes.
15983         * printcmd.c: Fix includes.
15984         * or1k-tdep.c: Fix includes.
15985         * mi/mi-main.c: Fix includes.
15986         * m32r-tdep.c: Fix includes.
15987         * csky-tdep.c: Fix includes.
15988         * compile/compile-cplus-types.c: Fix includes.
15989         * cli/cli-interp.c: Fix includes.
15990
15991 2019-01-21  Alan Hayward  <alan.hayward@arm.com>
15992
15993         * aarch64-tdep.c (aapcs_is_vfp_call_or_return_candidate_1): Check
15994         for padding.
15995
15996 2019-01-16  Tom Tromey  <tom@tromey.com>
15997
15998         * objfiles.h (struct minimal_symbol_iterator): Rename.  Move
15999         earlier.
16000         (struct objfile) <msymbols_range>: Move from top level.
16001         <msymbols>: New method.
16002         (class objfile_msymbols): Remove.
16003         * symtab.c (default_collect_symbol_completion_matches_break_on):
16004         Update.
16005         * symmisc.c (dump_msymbols): Update.
16006         * stabsread.c (scan_file_globals): Update.
16007         * objc-lang.c (info_selectors_command, info_classes_command)
16008         (find_methods): Update.
16009         * minsyms.c (find_solib_trampoline_target): Update.
16010         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Update.
16011         * coffread.c (coff_symfile_read): Update.
16012         * ada-lang.c (ada_lookup_simple_minsym)
16013         (ada_collect_symbol_completion_matches): Update.
16014
16015 2019-01-16  Tom Tromey  <tom@tromey.com>
16016
16017         * objfiles.h (class objfile_msymbols) <iterator>: Change argument
16018         type.  Remove no-argument constructor.
16019         <iterator::operator++>: Simplify.
16020         <begin>: Update.
16021         <end>: Use minimal_symbol_count.
16022
16023 2019-01-16  Tom Tromey  <tom@tromey.com>
16024
16025         * objfiles.h (struct objfile) <psymtabs>: New method.
16026         (class objfile_psymtabs): Remove.
16027         * psymtab.h (class psymtab_storage) <partial_symtab_range>: New
16028         typedef.
16029         <range>: New method.
16030         (require_partial_symbols): Change return type.
16031         * psymtab.c (require_partial_symbols)
16032         (psym_expand_symtabs_matching): Update.
16033         * mdebugread.c (parse_partial_symbols): Update.
16034         * dbxread.c (dbx_end_psymtab): Update.
16035
16036 2019-01-15  Tom Tromey  <tom@tromey.com>
16037
16038         * symtab.c (lookup_objfile_from_block)
16039         (lookup_symbol_in_objfile_symtabs)
16040         (basic_lookup_transparent_type_1, find_pc_sect_compunit_symtab)
16041         (find_line_symtab, info_sources_command)
16042         (default_collect_symbol_completion_matches_break_on)
16043         (make_source_files_completion_list): Update.
16044         * symmisc.c (print_objfile_statistics, dump_objfile)
16045         (maintenance_print_symbols, maintenance_info_symtabs)
16046         (maintenance_check_symtabs, maintenance_info_line_tables):
16047         Update.
16048         * source.c (select_source_symtab)
16049         (forget_cached_source_info_for_objfile): Update.
16050         * objfiles.h (class objfile_compunits): Remove.
16051         (struct objfile) <compunits_range>: New typedef.
16052         (compunits): New method.
16053         * objfiles.c (objfile_relocate1): Update.
16054         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16055         * maint.c (count_symtabs_and_blocks): Update.
16056         * linespec.c (iterate_over_all_matching_symtabs): Update.
16057         * cp-support.c (add_symbol_overload_list_qualified): Update.
16058         * coffread.c (coff_symtab_read): Update.
16059         * ada-lang.c (add_nonlocal_symbols)
16060         (ada_collect_symbol_completion_matches)
16061         (ada_add_global_exceptions): Update.
16062
16063 2019-01-15  Tom Tromey  <tom@tromey.com>
16064
16065         * progspace.h (program_space) <objfiles_safe_range>: New
16066         typedef.
16067         <objfiles_safe>: New method.
16068         * objfiles.h (class all_objfiles_safe): Remove.
16069         * objfiles.c (free_all_objfiles, objfile_purge_solibs): Update.
16070         * jit.c (jit_inferior_exit_hook): Update.
16071
16072 2019-01-17  Tom Tromey  <tom@tromey.com>
16073
16074         * progspace.h (program_space) <objfiles_range>: New typedef.
16075         <objfiles>: New method.
16076         <objfiles_head>: Rename from objfiles.
16077         (object_files): Update.
16078         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Update.
16079         * guile/scm-pretty-print.c
16080         (ppscm_find_pretty_printer_from_objfiles): Update.
16081         * guile/scm-objfile.c (gdbscm_objfiles): Update.
16082         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers):
16083         Update.
16084         * python/py-progspace.c (pspy_get_objfiles): Update.
16085         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16086         Update.
16087         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16088         (objfpy_lookup_objfile_by_build_id): Update.
16089         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Update.
16090         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16091         Update.
16092         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16093         (expand_symtab_containing_pc, lookup_objfile_from_block)
16094         (lookup_static_symbol, basic_lookup_transparent_type)
16095         (find_pc_sect_compunit_symtab, find_symbol_at_address)
16096         (find_line_symtab, info_sources_command)
16097         (default_collect_symbol_completion_matches_break_on)
16098         (make_source_files_completion_list, find_main_name): Update.
16099         * symmisc.c (print_symbol_bcache_statistics)
16100         (print_objfile_statistics, maintenance_print_symbols)
16101         (maintenance_print_msymbols, maintenance_print_objfiles)
16102         (maintenance_info_symtabs, maintenance_check_symtabs)
16103         (maintenance_expand_symtabs, maintenance_info_line_tables):
16104         Update.
16105         * symfile.c (remove_symbol_file_command, overlay_invalidate_all)
16106         (find_pc_overlay, find_pc_mapped_section, list_overlays_command)
16107         (map_overlay_command, unmap_overlay_command)
16108         (simple_overlay_update, expand_symtabs_matching)
16109         (map_symbol_filenames): Update.
16110         * symfile-debug.c (set_debug_symfile): Update.
16111         * spu-tdep.c (spu_overlay_update, spu_objfile_from_frame):
16112         Update.
16113         * source.c (select_source_symtab, forget_cached_source_info):
16114         Update.
16115         * solib.c (solib_read_symbols): Update.
16116         * solib-spu.c (append_ocl_sos): Update.
16117         * psymtab.c (maintenance_print_psymbols)
16118         (maintenance_info_psymtabs, maintenance_check_psymtabs): Update.
16119         * probe.c (parse_probes_in_pspace, find_probe_by_pc): Update.
16120         * printcmd.c (info_symbol_command): Update.
16121         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created):
16122         Update.
16123         * objfiles.h (class all_objfiles): Remove.
16124         * objfiles.c (have_partial_symbols, have_full_symbols)
16125         (have_minimal_symbols, qsort_cmp, update_section_map)
16126         (shared_objfile_contains_address_p)
16127         (default_iterate_over_objfiles_in_search_order): Update.
16128         * objc-lang.c (info_selectors_command, info_classes_command)
16129         (find_methods): Update.
16130         * minsyms.c (find_solib_trampoline_target): Update.
16131         * maint.c (maintenance_info_sections)
16132         (maintenance_translate_address, count_symtabs_and_blocks):
16133         Update.
16134         * main.c (captured_main_1): Update.
16135         * linux-thread-db.c (try_thread_db_load_from_pdir)
16136         (has_libpthread): Update.
16137         * linespec.c (iterate_over_all_matching_symtabs)
16138         (search_minsyms_for_name): Update.
16139         * jit.c (jit_find_objf_with_entry_addr): Update.
16140         * hppa-tdep.c (find_unwind_entry)
16141         (hppa_lookup_stub_minimal_symbol): Update.
16142         * gcore.c (gcore_create_callback, objfile_find_memory_regions):
16143         Update.
16144         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16145         (elf_gnu_ifunc_resolve_by_got): Update.
16146         * dwarf2-frame.c (dwarf2_frame_find_fde): Update.
16147         * dwarf-index-write.c (save_gdb_index_command): Update.
16148         * cp-support.c (add_symbol_overload_list_qualified): Update.
16149         * breakpoint.c (create_overlay_event_breakpoint)
16150         (create_longjmp_master_breakpoint)
16151         (create_std_terminate_master_breakpoint)
16152         (create_exception_master_breakpoint): Update.
16153         * blockframe.c (find_pc_partial_function): Update.
16154         * ada-lang.c (ada_lookup_simple_minsym, add_nonlocal_symbols)
16155         (ada_collect_symbol_completion_matches)
16156         (ada_add_global_exceptions): Update.
16157
16158 2019-01-17  Tom Tromey  <tom@tromey.com>
16159
16160         * solib-target.c (lm_info_target_p): Remove typedef.  Don't
16161         declare VEC.
16162         (solib_target_parse_libraries): Change return type.
16163         (library_list_start_segment, library_list_start_section)
16164         (library_list_end_library, library_list_start_library); Update.
16165         (solib_target_free_library_list): Remove.
16166         (solib_target_parse_libraries): Remove cleanup.  Change return
16167         type.
16168         (solib_target_current_sos): Update.
16169
16170 2019-01-17  Tom Tromey  <tromey@bapiya>
16171
16172         * valprint.c: Replace "the the" with "the".
16173         * symtab.c: Replace "the the" with "the".
16174         * solib.c: Replace "the the" with "the".
16175         * solib-dsbt.c: Replace "the the" with "the".
16176         * linespec.c: Replace "the the" with "the".
16177         * dwarf2loc.h: Replace "the the" with "the".
16178         * amd64-windows-tdep.c: Replace "the the" with "the".
16179         * aarch64-tdep.c: Replace "the the" with "the".
16180
16181 2019-01-16  Keith Seitz  <keiths@redhat.com>
16182
16183         PR gdb/23773
16184         * dwarf2read.c (dwarf2_cu) <ancestor>: New field.
16185         <builder>: Rename to ..
16186         <m_builder>: ... this and make private.
16187         (dwarf2_cu::get_builder): New method.  Change all users of
16188         `builder' to use this method.
16189         (dwarf2_start_symtab): Move to ...
16190         (dwarf2_cu::start_symtab): ... here.  Update all callers
16191         (setup_type_unit_groups): Move to ...
16192         (dwarf2_cu::setup_type_unit_groups): ... here.  Update all
16193         callers.
16194         (dwarf2_cu::reset_builder): New method.
16195         (process_full_compunit, process_full_type_unit): Use
16196         dwarf2_cu::reset_builder.
16197         (follow_die_offset): Record the ancestor CU if it is different
16198         from the followed DIE's CU.
16199         (follow_die_sig_1): Likewise.
16200
16201 2019-01-15  Tom Tromey  <tom@tromey.com>
16202
16203         * remote.c (class remote_state) <buf>: Now a char_vector.
16204         <buf_size>: Remove.
16205         (remote_target::getpkt): Change type of buf.  Remove sizeof_buf
16206         parameter.
16207         (remote_target::getpkt_or_notif_sane_1)
16208         (remote_target::getpkt_sane)
16209         (remote_target::getpkt_or_notif_sane): Likewise.
16210         (class remote_target) <putpkt>: New overload.
16211         (remote_target::read_frame): Change type of "buf_p".  Remove
16212         sizeof_p parameter.
16213         (packet_ok): New overload.
16214         (packet_check_result): New overload.
16215         Update all uses.
16216
16217 2019-01-14  Tom Tromey  <tom@tromey.com>
16218
16219         * remote-notif.c (handle_notification, remote_notif_ack)
16220         (remote_notif_parse): Make "buf" const.
16221         * remote-notif.h (struct notif_client) <parse, ack>: Make "buf"
16222         const.
16223         (remote_notif_parse, remote_notif_ack, handle_notification):
16224         Likewise.
16225         * remote.c (remote_notif_stop_parse): Make "buf" const.
16226         (remote_target::remote_parse_stop_reply): Make "buf" const.
16227         (remote_notif_stop_ack): Make "buf" const.
16228
16229 2019-01-14  Tom Tromey  <tom@tromey.com>
16230
16231         * remote.c (remote_console_output): Make parameter const.
16232
16233 2019-01-14  Tom Tromey  <tom@tromey.com>
16234
16235         * target-debug.h (target_debug_print_signals): Constify.
16236         * nto-procfs.c (nto_procfs_target::pass_signals): Update.
16237         * procfs.c (procfs_target::pass_signals): Update.
16238         * linux-nat.c (linux_nat_target::pass_signals): Update.
16239         * linux-nat.h (class linux_nat_target) <pass_signals>: Update.
16240         * target-delegates.c: Rebuild.
16241         * remote.c (remote_target::program_signals): Update.
16242         (remote_target::pass_signals): Update.
16243         * target.c (target_pass_signals): Constify argument.
16244         (target_program_signals): Likewise.
16245         * target.h (struct target_ops) <pass_signals, program_signals>:
16246         Constify argument.
16247         (target_pass_signals, target_program_signals): Constify argument.
16248
16249 2019-01-14  Tom Tromey  <tom@tromey.com>
16250
16251         PR tui/28819:
16252         * tui/tui-io.c (gdb_wgetch): Print \r when needed.
16253
16254 2019-01-14  Pedro Franco de Carvalho  <pedromfc@linux.ibm.com>
16255
16256         * ppc-tdep.h (struct gdbarch_tdep) <ppc_v0_alias_regnum>: New
16257         field.
16258         * rs6000-tdep.c: Include reggroups.h.
16259         (IS_V_ALIAS_PSEUDOREG): Define.
16260         (rs6000_register_name): Return names for the "vX" aliases.
16261         (rs6000_pseudo_register_type): Return type for the "vX" aliases.
16262         (rs6000_pseudo_register_reggroup_p): Restore.  Handle "vX"
16263         aliases.  Call default_register_reggroup_p for all other
16264         pseudo-registers.
16265         (v_alias_pseudo_register_read, v_alias_pseudo_register_write):
16266         New functions.
16267         (rs6000_pseudo_register_read, rs6000_pseudo_register_write):
16268         Handle "vX" aliases.
16269         (v_alias_pseudo_register_collect): New function.
16270         (rs6000_ax_pseudo_register_collect): Handle "vX" aliases.
16271         (rs6000_gdbarch_init): Initialize "vX" aliases as
16272         pseudo-registers.  Restore registration of
16273         rs6000_pseudo_register_reggroup_p with
16274         set_tdesc_pseudo_register_reggroup_p.
16275
16276 2019-01-13  Max Filippov  <jcmvbkbc@gmail.com>
16277
16278         * xtensa-linux-tdep.c (xtensa_linux_init_abi): Update
16279         tdep->num_pseudo_regs. Add calls to set_gdbarch_num_regs and
16280         set_gdbarch_num_pseudo_regs.
16281
16282 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16283
16284         * cli/cli-style.h (class cli_style_option): <add_setshow_commands>
16285         Remove arg prefixname, add do_set and do_show.
16286         Add member functions set_list and show_list.
16287         * cli/cli-style.c (class cli_style_option): Update accordingly.
16288         (style_set_list): Move to file scope.
16289         (style_show_list): Likewise.
16290         (set_style): Call help_list.
16291         (show_style): Call cmd_show_list.
16292         (_initialize_cli_style): New macro STYLE_ADD_SETSHOW_COMMANDS.
16293         Update to use the new macro.
16294
16295 2019-10-12  Joel Brobecker  <brobecker@adacore.com>
16296
16297         * ada-lang.c (_initialize_ada_language): Expand the help text
16298         for the "catch exception" command.
16299
16300 2019-01-12  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16301
16302         * symtab.c (matching_obj_sections): Initialize obj,
16303         declare it closer to its usage.
16304
16305 2019-01-10  Tom Tromey  <tom@tromey.com>
16306
16307         * thread-iter.h (inf_threads_iterator): Use next_iterator.
16308         (basic_inf_threads_range): Remove.
16309         (inf_threads_range, inf_non_exited_threads_range)
16310         (safe_inf_threads_range): Use next_adapter.
16311
16312 2019-01-10  Keith Seitz  <keiths@redhat.com>
16313
16314         PR gdb/23712
16315         PR symtab/23010
16316         * dwarf2read.c (dw2_add_symbol_to_list): Remove.
16317         (fixup_go_packaging, new_symbol): Use add_symbol_to_list.
16318
16319 2019-01-10  Keith Seitz  <keiths@redhat.com>
16320
16321         PR gdb/23712
16322         PR symtab/23010
16323         * dictionary.c (pending_to_vector): Remove.
16324         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16325         Remove _1 suffix, replacing functions of the same name.  Update
16326         all callers.
16327         (dict_create_hashed, dict_create_hashed_expandable)
16328         (dict_create_linear, dict_create_linear_expandable, dict_free)
16329         (dict_add_symbol, dict_add_pending, dict_size, dict_empty):
16330         Make functions static.
16331
16332 2019-01-10  Keith Seitz  <keiths@redhat.com>
16333
16334         PR gdb/23712
16335         PR symtab/23010
16336         * dictionary.h (struct dictionary): Replace declaration with
16337         multidictionary.
16338         (dict_create_hashed, dict_create_hashed_expandable)
16339         (dict_create_linear, dict_create_linear_expandable)
16340         (dict_free, dict_add_symbol, dict_add_pending, dict_empty)
16341         (dict_iterator_first, dict_iterator_next, dict_iter_match_first)
16342         (dict_iter_match_next, dict_size): Rename to "mdict_" versions
16343         taking multidictionary argument.
16344         [ALL_DICT_SYMBOLS]: Update for multidictionary.
16345         * block.h (struct block) <dict>: Change to multidictionary
16346         and rename `multidict'.
16347         * block.c, buildsym.c, jit.c, mdebugread.c, objfiles.c,
16348         symmisc.c: Update all dictionary references to multidictionary.
16349
16350 2019-01-10  Keith Seitz  <keiths@redhat.com>
16351
16352         PR gdb/23712
16353         PR symtab/23010
16354         * dictionary.c: Include unordered_map.
16355         (pending_to_vector): New function.
16356         (dict_create_hashed_1, dict_create_linear_1, dict_add_pending_1):
16357         Rewrite the non-"_1" functions to take vector instead
16358         of linked list.
16359         (dict_create_hashed, dict_create_linear, dict_add_pending): Use the
16360         "new" _1 versions of the same name.
16361         (multidictionary): Define.
16362         (std::hash<enum language): New definition.
16363         (collate_pending_symbols_by_language, mdict_create_hashed)
16364         (mdict_create_hashed_expandable, mdict_create_linear)
16365         (mdict_create_linear_expandable, mdict_free)
16366         (find_language_dictionary, create_new_language_dictionary)
16367         (mdict_add_symbol, mdict_add_pending, mdict_iterator_first)
16368         (mdict_iterator_next, mdict_iter_match_first, mdict_iter_match_next)
16369         (mdict_size, mdict_empty): New functions.
16370         * dictionary.h (mdict_iterator): Define.
16371
16372 2019-01-10  Pedro Alves  <palves@redhat.com>
16373
16374         * breakpoint.c (read_uploaded_action)
16375         (create_tracepoint_from_upload): Adjust to use
16376         gdb::unique_xmalloc_ptr.
16377         * ctf.c (ctf_write_uploaded_tp):
16378         (SET_ARRAY_FIELD): Use emplace_back.
16379         (SET_STRING_FIELD): Adjust to use gdb::unique_xmalloc_ptr.
16380         * tracefile-tfile.c (tfile_write_uploaded_tp):
16381         * tracepoint.c (parse_tracepoint_definition): Adjust to use
16382         gdb::unique_xmalloc_ptr.
16383         * tracepoint.h (struct uploaded_tp) <cond, actions, step_actions,
16384         at_string, cond_string, cmd_strings>: Replace char pointers
16385         with gdb::unique_xmalloc_ptr.
16386
16387 2019-01-10  Pedro Alves  <palves@redhat.com>
16388
16389         * solib-target.c (library_list_start_library): Don't xstrdup name.
16390
16391 2019-01-10  Pedro Alves  <palves@redhat.com>
16392
16393         * mdebugread.c (parse_partial_symbols): Use
16394         gdb::unique_xmalloc_ptr to manage heap-allocated 'stabsstring'.
16395
16396 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16397
16398         * linux-fork.c (scoped_switch_fork_info)
16399         <~scoped_switch_fork_info>: Fix incorrect variable name.
16400
16401 2019-01-10  Andrew Burgess  <andrew.burgess@embecosm.com>
16402
16403         * linux-fork.c (scoped_switch_fork_info)
16404         <scoped_switch_fork_info>: Make explicit.
16405         <~scoped_switch_fork_info>: Wrap core in TRY/CATCH.
16406
16407 2019-01-10  Tom Tromey  <tom@tromey.com>
16408
16409         * objfiles.h (objfile::reset_psymtabs): Update.
16410         * objfiles.c (objfile::objfile): Update.
16411         * psymtab.h (psymtab_storage::obstack): Update.
16412         (psymtab_storage::m_obstack): Use gdb::optional.
16413         (class psymtab_storage): Update comment.  Remove objfile
16414         parameter.
16415         * psymtab.c (psymtab_storage::psymtab_storage): Update.
16416
16417 2019-01-10  Tom Tromey  <tom@tromey.com>
16418
16419         * psymtab.h (psymtab_storage::allocate_psymtab): New method.
16420         <free_psymtabs>: Now private.
16421         * psymtab.c (psymtab_storage::allocate_psymtab): Implement.
16422         (allocate_psymtab): Use new method.
16423
16424 2019-01-10  Tom Tromey  <tom@tromey.com>
16425
16426         * xcoffread.c (xcoff_end_psymtab): Use allocate_dependencies.
16427         * psymtab.h (psymtab_storage::allocate_dependencies): New method.
16428         * mdebugread.c (parse_partial_symbols): Use
16429         allocate_dependencies.
16430         * dwarf2read.c (dwarf2_create_include_psymtab): Use
16431         allocate_dependencies.
16432         (process_psymtab_comp_unit_reader)
16433         (build_type_psymtab_dependencies): Likewise.
16434         * dbxread.c (dbx_end_psymtab): Use allocate_dependencies.
16435
16436 2019-01-10  Tom Tromey  <tom@tromey.com>
16437
16438         * psymtab.c (add_psymbol_to_bcache): Pass psymtab obstack to
16439         PSYMBOL_SET_LANGUAGE.
16440         (allocate_psymtab): Allocate psymtab on the psymtab obstack.
16441
16442 2019-01-10  Tom Tromey  <tom@tromey.com>
16443
16444         * psymtab.h (psymtab_storage::obstack): New method.
16445         <m_obstack>: Rename from obstack; now private.
16446         * psymtab.c (psymtab_storage): Update.
16447         * dwarf2read.c (create_addrmap_from_index)
16448         (create_addrmap_from_aranges, dwarf2_build_psymtabs_hard):
16449         Update.
16450
16451 2019-01-10  Tom Tromey  <tom@tromey.com>
16452
16453         * symfile.c (reread_symbols): Call objfile->reset_psymtabs.
16454         * objfiles.h (objfile::reset_psymtabs): New method.
16455
16456 2019-01-10  Tom Tromey  <tom@tromey.com>
16457
16458         * symmisc.c (print_symbol_bcache_statistics): Update.
16459         (print_objfile_statistics): Update.
16460         * symfile.c (reread_symbols): Update.
16461         * psymtab.h (class psymtab_storage): New.
16462         * psymtab.c (psymtab_storage): New constructor.
16463         (~psymtab_storage): New destructor.
16464         (require_partial_symbols): Update.
16465         (ALL_OBJFILE_PSYMTABS_REQUIRED): Rewrite.
16466         (find_pc_sect_psymtab, find_pc_sect_psymbol)
16467         (match_partial_symbol, lookup_partial_symbol, dump_psymtab)
16468         (psym_dump, recursively_search_psymtabs, psym_has_symbols)
16469         (psym_find_compunit_symtab_by_address, sort_pst_symbols)
16470         (start_psymtab_common, end_psymtab_common)
16471         (add_psymbol_to_bcache, add_psymbol_to_list, init_psymbol_list)
16472         (allocate_psymtab): Update.
16473         (psymtab_storage::discard_psymtab): Rename from discard_psymtab.
16474         Update.
16475         (dump_psymtab_addrmap, maintenance_print_psymbols)
16476         (maintenance_check_psymtabs): Update.
16477         (class objfile_psymtabs): Move to objfiles.h.
16478         * psympriv.h (discard_psymtab): Now inline.
16479         (psymtab_discarder::psymtab_discarder): Update.
16480         (psymtab_discarder::~psymtab_discarder): Update.
16481         (ALL_OBJFILE_PSYMTABS): Rewrite.
16482         * objfiles.h (struct objfile) <psymtabs, psymtabs_addrmap,
16483         free_psymtabs, psymbol_cache, global_psymbols, static_psymbols>:
16484         Remove fields.
16485         <partial_symtabs>: New field.
16486         (class objfile_psymtabs): Move from psymtab.h.  Update.
16487         * objfiles.c (objfile::objfile): Initialize partial_symtabs, not
16488         psymbol_cache.
16489         (objfile::~objfile): Don't destroy psymbol_cache.
16490         * mdebugread.c (parse_partial_symbols): Update.
16491         * dwarf2read.c (create_addrmap_from_index)
16492         (create_addrmap_from_aranges, dw2_find_pc_sect_compunit_symtab)
16493         (process_psymtab_comp_unit_reader, dwarf2_build_psymtabs_hard)
16494         (add_partial_subprogram, dwarf2_ranges_read): Update.
16495         * dwarf-index-write.c (write_address_map)
16496         (write_one_signatured_type, recursively_write_psymbols)
16497         (class debug_names, class debug_names, write_psymtabs_to_index):
16498         Update.
16499
16500 2019-01-10  Tom Tromey  <tom@tromey.com>
16501
16502         * symtab.h (SYMBOL_SET_NAMES): Update.
16503         (symbol_set_names): Update.
16504         (MSYMBOL_SET_NAMES): Update.
16505         * symtab.c (symbol_set_names): Change argument to be an
16506         objfile_per_bfd_storage.
16507         * psymtab.c (add_psymbol_to_bcache): Update.
16508         * psympriv.h (PSYMBOL_SET_NAMES): Take per_bfd argument.
16509
16510 2019-01-10  Tom Tromey  <tom@tromey.com>
16511
16512         * symtab.c (create_demangled_names_hash): Change argument to be an
16513         objfile_per_bfd_storage.
16514         (symbol_set_names): Update.
16515
16516 2019-01-10  Tom Tromey  <tom@tromey.com>
16517
16518         * xcoffread.c (xcoff_initial_scan): Unconditionally call
16519         init_psymbol_list.
16520         * psymtab.c (init_psymbol_list): Do nothing if already called.
16521         * psympriv.h (init_psymbol_list): Add comment.
16522         * dwarf2read.c (dwarf2_build_psymtabs): Unconditionally call
16523         init_psymbol_list.
16524         * dbxread.c (dbx_symfile_read): Unconditionally call
16525         init_psymbol_list.
16526
16527 2019-01-10  Tom Tromey  <tom@tromey.com>
16528
16529         * xcoffread.c (scan_xcoff_symtab): Update.
16530         * psymtab.c (add_psymbol_to_list): Replace "list" parameter with
16531         "where".
16532         * mdebugread.c (parse_partial_symbols)
16533         (handle_psymbol_enumerators): Update.
16534         * dwarf2read.c (add_partial_symbol, load_partial_dies): Update.
16535         * dbxread.c (read_dbx_symtab): Update.
16536         * psympriv.h (psymbol_placement): New enum.
16537         (add_psymbol_to_list): Update.
16538
16539 2019-01-10  Tom Tromey  <tom@tromey.com>
16540
16541         * xcoffread.c (xcoff_start_psymtab): Remove global_psymbols and
16542         static_psymbols parameters.
16543         (scan_xcoff_symtab): Update.
16544         * psymtab.c (start_psymtab_common): Remove global_psymbols and
16545         static_psymbols parameters.
16546         * psympriv.h (start_psymtab_common): Update.
16547         * mdebugread.c (parse_partial_symbols): Update.
16548         * dwarf2read.c (create_partial_symtab): Update.
16549         * dbxread.c (read_dbx_symtab): Update.
16550         (start_psymtab): Remove global_psymbols and static_psymbols
16551         parameters.
16552
16553 2019-01-10  Tom Tromey  <tom@tromey.com>
16554
16555         * xcoffread.c (xcoff_end_psymtab): Remove some initializations.
16556         * psymtab.c (allocate_psymtab): Add comment.
16557         * psympriv.h (allocate_psymtab): Add comment.
16558         * dwarf2read.c (dwarf2_create_include_psymtab): Remove some
16559         initializations.
16560         * dbxread.c (dbx_end_psymtab): Remove some initializations.
16561
16562 2019-01-10  Tom Tromey  <tom@tromey.com>
16563
16564         * symfile.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16565         Don't declare.
16566         * mipsread.c: Include mdebugread.h.
16567         * mdebugread.h (mdebug_build_psymtabs, elfmdebug_build_psymtabs):
16568         Declare.
16569         * elfread.c: Include mdebugread.h.
16570
16571 2019-01-09  Tom Tromey  <tom@tromey.com>
16572
16573         * dbxread.c (dbx_end_psymtab): Use objfile_psymtabs.
16574         * mdebugread.c (parse_partial_symbols): Use objfile_psymtabs.
16575         * psymtab.c (ALL_OBJFILE_PSYMTABS_REQUIRED): Remove.
16576         (psym_map_symtabs_matching_filename, find_pc_sect_psymtab)
16577         (psym_lookup_symbol, psym_find_last_source_symtab)
16578         (psym_forget_cached_source_info, psym_print_stats)
16579         (psym_expand_symtabs_for_function, psym_expand_all_symtabs)
16580         (psym_expand_symtabs_with_fullname, psym_map_symbol_filenames)
16581         (psym_map_matching_symbols, psym_expand_symtabs_matching)
16582         (psym_find_compunit_symtab_by_address)
16583         (maintenance_print_psymbols, maintenance_info_psymtabs)
16584         (maintenance_check_psymtabs): Use ranged for.
16585         * psymtab.h (class objfile_psymtabs): New.
16586         (require_partial_symbols): Return objfile_psymtabs.
16587         * psympriv.h (ALL_OBJFILE_PSYMTABS): Remove.
16588
16589 2019-01-09  Tom Tromey  <tom@tromey.com>
16590
16591         * symfile.c (overlay_invalidate_all, find_pc_overlay)
16592         (find_pc_mapped_section, list_overlays_command)
16593         (map_overlay_command, unmap_overlay_command)
16594         (simple_overlay_update): Use all_objfiles.
16595         * spu-tdep.c (spu_overlay_update): Use all_objfiles.
16596         * printcmd.c (info_symbol_command): Use all_objfiles.
16597         * objfiles.h (ALL_OBJSECTIONS): Remove.
16598         * maint.c (maintenance_translate_address): Use all_objfiles.
16599         * gcore.c (gcore_create_callback): Use all_objfiles.
16600         (objfile_find_memory_regions): Likewise.
16601
16602 2019-01-09  Tom Tromey  <tom@tromey.com>
16603
16604         * symtab.c (find_line_symtab, info_sources_command)
16605         (make_source_files_completion_list): Use objfile_compunits.
16606         * source.c (select_source_symtab): Use objfile_compunits.
16607         * objfiles.h (struct objfile): Update comment.
16608         (ALL_OBJFILES): Remove.
16609         (ALL_FILETABS): Remove.
16610         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Use
16611         objfile_compunits.
16612
16613 2019-01-09  Tom Tromey  <tom@tromey.com>
16614
16615         * symmisc.c (print_objfile_statistics, dump_objfile)
16616         (maintenance_print_symbols): Use compunit_filetabs.
16617         * source.c (forget_cached_source_info_for_objfile): Use
16618         compunit_filetabs.
16619         * objfiles.h (ALL_OBJFILE_FILETABS): Remove.
16620         (ALL_FILETABS): Use compunit_filetabs.
16621         * objfiles.c (objfile_relocate1): Use compunit_filetabs.
16622         * coffread.c (coff_symtab_read): Use compunit_filetabs.
16623
16624 2019-01-09  Tom Tromey  <tom@tromey.com>
16625
16626         * symtab.h (ALL_COMPUNIT_FILETABS): Remove.
16627         (compunit_filetabs): New.
16628         * symtab.c (iterate_over_some_symtabs, find_pc_sect_line): Use
16629         compunit_filetabs.
16630         (info_sources_command, make_source_files_completion_list): Remove
16631         declaration.
16632         * symmisc.c (print_objfile_statistics, dump_objfile)
16633         (maintenance_print_symbols): Remove declaration.
16634         (maintenance_info_symtabs): Use compunit_filetabs.
16635         (maintenance_info_line_tables): Likewise.
16636         * source.c (select_source_symtab): Change local variable name.
16637         (forget_cached_source_info_for_objfile): Remove declaration.
16638         * objfiles.h (ALL_OBJFILE_FILETABS): Use compunit_filetabs.
16639         * objfiles.c (objfile_relocate1): Remove declaration.
16640         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16641         declaration.
16642         * maint.c (count_symtabs_and_blocks): Use compunit_filetabs.
16643         * coffread.c (coff_symtab_read): Remove declaration.
16644         * buildsym.c (buildsym_compunit::end_symtab_with_blockvector): Use
16645         compunit_filetabs.
16646
16647 2019-01-09  Tom Tromey  <tom@tromey.com>
16648
16649         * symtab.c (lookup_objfile_from_block)
16650         (find_pc_sect_compunit_symtab, search_symbols)
16651         (default_collect_symbol_completion_matches_break_on): Use
16652         objfile_compunits.
16653         * objfiles.h (ALL_COMPUNITS): Remove.
16654         * maint.c (count_symtabs_and_blocks): Use objfile_compunits.
16655         * cp-support.c (add_symbol_overload_list_qualified): Use
16656         objfile_compunits.
16657         * ada-lang.c (ada_collect_symbol_completion_matches)
16658         (ada_add_global_exceptions): Use objfile_compunits.
16659
16660 2019-01-09  Tom Tromey  <tom@tromey.com>
16661
16662         * source.c (select_source_symtab)
16663         (forget_cached_source_info_for_objfile): Remove declaration.
16664         * mi/mi-cmd-file.c (mi_cmd_file_list_exec_source_files): Remove
16665         declaration.
16666         * maint.c (count_symtabs_and_blocks): Remove declaration.
16667         * cp-support.c (add_symbol_overload_list_qualified): Remove
16668         declaration.
16669         * coffread.c (coff_symtab_read): Remove declaration.
16670         * symtab.c (lookup_symbol_in_objfile_symtabs)
16671         (basic_lookup_transparent_type_1): Use objfile_compunits.
16672         (lookup_objfile_from_block, find_pc_sect_compunit_symtab)
16673         (info_sources_command, search_symbols)
16674         (default_collect_symbol_completion_matches_break_on)
16675         (make_source_files_completion_list): Remove declaration.
16676         * ada-lang.c (add_nonlocal_symbols): Use objfile_compunits.
16677         (ada_collect_symbol_completion_matches)
16678         (ada_add_global_exceptions): Remove declaration.
16679         * linespec.c (iterate_over_all_matching_symtabs): Use
16680         objfile_compunits.
16681         * objfiles.h (ALL_OBJFILE_COMPUNITS): Remove.
16682         (class objfile_compunits): New.
16683         (ALL_COMPUNITS): Use objfile_compunits.
16684         * symmisc.c (print_objfile_statistics, maintenance_info_symtabs)
16685         (maintenance_check_symtabs, maintenance_info_line_tables): Use
16686         objfile_compunits.
16687         * objfiles.c (objfile_relocate1): Use objfile_compunits.
16688
16689 2019-01-09  Tom Tromey  <tom@tromey.com>
16690
16691         * symtab.c (search_symbols)
16692         (default_collect_symbol_completion_matches_break_on): Use
16693         objfile_msymbols.
16694         * ada-lang.c (ada_lookup_simple_minsym)
16695         (ada_collect_symbol_completion_matches): Use objfile_msymbols.
16696         * minsyms.c (find_solib_trampoline_target): Use objfile_msymbols.
16697         * hppa-tdep.c (hppa_lookup_stub_minimal_symbol): Use
16698         objfile_msymbols.
16699         * coffread.c (coff_symfile_read): Use objfile_msymbols.
16700         * symmisc.c (dump_msymbols): Use objfile_msymbols.
16701         * objc-lang.c (find_methods): Use objfile_msymbols.
16702         (info_selectors_command, info_classes_command): Likewise.
16703         * stabsread.c (scan_file_globals): Use objfile_msymbols.
16704         * objfiles.h (class objfile_msymbols): New.
16705         (ALL_OBJFILE_MSYMBOLS): Remove.
16706         (ALL_MSYMBOLS): Remove.
16707
16708 2019-01-09  Tom Tromey  <tom@tromey.com>
16709
16710         * common/next-iterator.h (next_adapter): Add Iterator template
16711         parameter.
16712         * objfiles.h (ALL_OBJFILES_SAFE): Remove.
16713         (class all_objfiles_safe): New.
16714         * jit.c (jit_inferior_exit_hook): Use all_objfiles_safe.
16715         * objfiles.c (put_objfile_before): Update comment.
16716         (add_separate_debug_objfile): Likewise.
16717         (free_all_objfiles): Use all_objfiles_safe.
16718         (objfile_purge_solibs): Likewise.
16719
16720 2019-01-09  Tom Tromey  <tom@tromey.com>
16721
16722         * symtab.c (iterate_over_symtabs, matching_obj_sections)
16723         (expand_symtab_containing_pc, lookup_static_symbol)
16724         (basic_lookup_transparent_type, find_pc_sect_compunit_symtab)
16725         (find_symbol_at_address, find_line_symtab, find_main_name): Use
16726         all_objfiles.
16727         * probe.c (find_probe_by_pc, collect_probes): Use all_objfiles.
16728         * breakpoint.c (create_overlay_event_breakpoint)
16729         (create_longjmp_master_breakpoint)
16730         (create_std_terminate_master_breakpoint)
16731         (create_exception_master_breakpoint): Use all_objfiles.
16732         * linux-thread-db.c (try_thread_db_load_from_pdir)
16733         (has_libpthread): Use all_objfiles.
16734         * ada-lang.c (add_nonlocal_symbols): Use all_objfiles.
16735         * linespec.c (iterate_over_all_matching_symtabs)
16736         (search_minsyms_for_name): Use all_objfiles.
16737         * maint.c (maintenance_info_sections): Use all_objfiles.
16738         * main.c (captured_main_1): Use all_objfiles.
16739         * spu-tdep.c (spu_objfile_from_frame): Use all_objfiles.
16740         * guile/scm-objfile.c (gdbscm_objfiles): Use all_objfiles.
16741         * guile/scm-pretty-print.c
16742         (ppscm_find_pretty_printer_from_objfiles): Use all_objfiles.
16743         * solib-spu.c (append_ocl_sos): Use all_objfiles.
16744         * symmisc.c (maintenance_print_symbols): Use all_objfiles.
16745         (maintenance_print_msymbols): Use all_objfiles.
16746         * source.c (select_source_symtab): Use all_objfiles.
16747         * jit.c (jit_find_objf_with_entry_addr): Use all_objfiles.
16748         * symfile.c (remove_symbol_file_command)
16749         (expand_symtabs_matching, map_symbol_filenames): Use
16750         all_objfiles.
16751         * ppc-linux-tdep.c (ppc_linux_spe_context_inferior_created): Use
16752         all_objfiles.
16753         * dwarf2-frame.c (dwarf2_frame_find_fde): Use all_objfiles.
16754         * objc-lang.c (find_methods): Use all_objfiles.
16755         * objfiles.c (have_partial_symbols, have_full_symbols)
16756         (have_minimal_symbols, qsort_cmp)
16757         (default_iterate_over_objfiles_in_search_order): Use
16758         all_objfiles.
16759         * hppa-tdep.c (find_unwind_entry): Use all_objfiles.
16760         * psymtab.c (maintenance_print_psymbols): Use all_objfiles.
16761         (maintenance_check_psymtabs): Use all_objfiles.
16762         (ALL_PSYMTABS): Remove.
16763         * compile/compile-object-run.c (do_module_cleanup): Use
16764         all_objfiles.
16765         * blockframe.c (find_pc_partial_function): Use all_objfiles.
16766         * cp-support.c (add_symbol_overload_list_qualified): Use
16767         all_objfiles.
16768         * windows-tdep.c (windows_iterate_over_objfiles_in_search_order):
16769         Use all_objfiles.
16770         * dwarf-index-write.c (save_gdb_index_command): Use all_objfiles.
16771         * python/py-xmethods.c (gdbpy_get_matching_xmethod_workers): Use
16772         all_objfiles.
16773         * python/py-objfile.c (objfpy_lookup_objfile_by_name)
16774         (objfpy_lookup_objfile_by_build_id): Use all_objfiles.
16775         * python/py-prettyprint.c (find_pretty_printer_from_objfiles):
16776         Uses all_objfiles.
16777         * solib.c (solib_read_symbols): Use all_objfiles
16778
16779 2019-01-09  Tom Tromey  <tom@tromey.com>
16780
16781         * probe.c (parse_probes_in_pspace): Use all_objfiles.
16782         * guile/scm-progspace.c (gdbscm_progspace_objfiles): Use
16783         all_objfiles.
16784         * objfiles.h (ALL_PSPACE_OBJFILES): Remove.
16785         * symmisc.c (print_symbol_bcache_statistics)
16786         (print_objfile_statistics, maintenance_print_objfiles)
16787         (maintenance_info_symtabs, maintenance_check_symtabs)
16788         (maintenance_expand_symtabs, maintenance_info_line_tables): Use
16789         all_objfiles.
16790         * source.c (forget_cached_source_info): Use all_objfiles.
16791         * symfile-debug.c (set_debug_symfile): Use all_objfiles.
16792         * elfread.c (elf_gnu_ifunc_resolve_by_cache)
16793         (elf_gnu_ifunc_resolve_by_got): Use all_objfiles.
16794         * objfiles.c (update_section_map): Use all_objfiles.
16795         (shared_objfile_contains_address_p): Likewise.
16796         * psymtab.c (maintenance_info_psymtabs): Use all_objfiles.
16797         * python/py-progspace.c (pspy_get_objfiles): Use all_objfiles.
16798
16799 2019-01-09  Tom Tromey  <tom@tromey.com>
16800
16801         * common/next-iterator.h: New file.
16802         * objfiles.h (class all_objfiles): New.
16803         (struct objfile_iterator): New.
16804
16805 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16806
16807         * NEWS: Move the description of the changed "frame", "select-frame",
16808          and "info frame" commands to the Changed commands section.
16809
16810 2019-01-09  Simon Marchi  <simon.marchi@ericsson.com>
16811
16812         * gdbtypes.c (check_stub_method_group): Remove handling of old
16813         mangling schemes.
16814         * linespec.c (find_methods): Likewise.
16815         * stabsread.c (read_member_functions): Likewise.
16816         * valops.c (search_struct_method): Likewise.
16817         (value_struct_elt_for_reference): Likewise.
16818         * NEWS: Mention this change.
16819
16820 2019-01-09  Andrew Burgess  <andrew.burgess@embecosm.com>
16821
16822         * cli/cli-cmds.c (list_command): Pass a source_lines_range to
16823         print_source_lines.
16824         * source.c (print_source_lines_base): Update line number check.
16825         (print_source_lines): New function.
16826         (source_lines_range::source_lines_range): New function.
16827         * source.h (class source_lines_range): New class.
16828         (print_source_lines): New declaration.
16829
16830 2019-01-09  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
16831
16832         * linespec.c (linespec_state_destructor): Free self->canonical_names.
16833
16834 2019-01-08  Tom Tromey  <tom@tromey.com>
16835             Simon Marchi  <simon.marchi@ericsson.com>
16836
16837         PR gdb/24060
16838         * ada-exp.y (DOLLAR_VARIABLE): Rename from SPECIAL_VARIABLE.
16839         * ada-lex.l (DOLLAR_VARIABLE): Likewise.
16840         * c-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16841         * f-exp.y (DOLLAR_VARIABLE): Likewise.
16842         * m2-exp.y (DOLLAR_VARIABLE): Rename from INTERNAL_VAR.
16843         * p-exp.y (DOLLAR_VARIABLE): Rename from VARIABLE.
16844
16845 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16846
16847         * source.c (select_source_symtab): Move header comment to
16848         declaration in source.h.
16849         (forget_cached_source_info_for_objfile): Likewise.
16850         (forget_cached_source_info): Likewise.
16851         (identify_source_line): Likewise.
16852         * source.h (identify_source_line): Move declaration from symtab.h
16853         and add comment from source.c
16854         (print_source_lines): Likewise.
16855         (forget_cached_source_info_for_objfile): Likewise.
16856         (forget_cached_source_info): Likewise.
16857         (select_source_symtab): Likewise.
16858         (enum print_source_lines_flag): Move definition from symtab.h.
16859         * symtab.h (identify_source_line): Move declaration to source.h.
16860         (print_source_lines): Likewise.
16861         (forget_cached_source_info_for_objfile): Likewise.
16862         (forget_cached_source_info): Likewise.
16863         (select_source_symtab): Likewise.
16864         (enum print_source_lines_flag): Move definition to source.h.
16865         * tui/tui-hooks.c: Add 'source.h' include.
16866
16867 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16868
16869         * source.c (print_source_lines_base): Handle requests to print
16870         reverse line number sequences, and guard against empty lines
16871         string.
16872
16873 2019-01-08  Andrew Burgess  <andrew.burgess@embecosm.com>
16874
16875         * source.c (print_source_lines_base): Fix skip of '\r' if next
16876         character is '\n'.
16877
16878 2019-01-06  Tom Tromey  <tom@tromey.com>
16879
16880         * c-exp.y (struct c_parse_state) <macro_original_text,
16881         expansion_obstack>: New member.
16882         (macro_original_text, expansion_obstack): Remove globals.
16883         (scan_macro_expansion, scanning_macro_expansion)
16884         (finished_macro_expansion): Update.
16885         (scan_macro_cleanup): Remove.
16886         (yylex, c_parse): Update.
16887
16888 2019-01-06  Tom Tromey  <tom@tromey.com>
16889
16890         * c-exp.y (struct c_parse_state) <strings>: New member.
16891         (operator_stoken): Update.
16892
16893 2019-01-06  Tom Tromey  <tom@tromey.com>
16894
16895         * parser-defs.h (type_ptr): Remove typedef.  Don't declare VEC.
16896         (union type_stack_elt) <typelist_val>: Now a pointer to
16897         std::vector.
16898         (type_stack_cleanup): Don't declare.
16899         (push_typelist): Update.
16900         * parse.c (pop_typelist): Return a std::vector.
16901         (push_typelist): Take a std::vector.
16902         (follow_types): Update.  Do not free args.
16903         (type_stack_cleanup): Remove.
16904         * c-exp.y (struct c_parse_state): New.
16905         (cpstate): New global.
16906         (type_aggregate_p, exp, ptr_operator, parameter_typelist)
16907         (nonempty_typelist): Update.
16908         (func_mod): Create a new vector.
16909         (c_parse): Create a c_parse_state.
16910         (check_parameter_typelist): Do not delete params.
16911         (function_method): Update.  Do not delete type_list.
16912
16913 2019-01-06  Tom Tromey  <tom@tromey.com>
16914
16915         PR gdb/28155:
16916         * python/py-finishbreakpoint.c (bpfinishpy_init): Use
16917         check_typedef.
16918         * infcmd.c (finish_command_fsm_should_stop): Use check_typedef.
16919         (print_return_value): Likewise.
16920
16921 2019-01-05  Tom Tromey  <tom@tromey.com>
16922
16923         * contrib/cleanup_check.py: Remove.
16924         * contrib/gcc-with-excheck: Remove.
16925         * contrib/exsummary.py: Remove.
16926         * contrib/excheck.py: Remove.
16927
16928 2019-01-05  Joel Brobecker  <brobecker@adacore.com>
16929
16930         * thread.c (delete_thread_1): Add gdb_assert that THR is not
16931         NULL. Initialize tpprev to NULL instead of assigning it
16932         to NULL on the next statement.
16933         * windows-nat.c (windows_delete_thread): Remove check for
16934         main_thread_id before printing thread exit notifications.
16935         (get_windows_debug_event) <EXIT_THREAD_DEBUG_EVENT>:
16936         Remove thread ID check against main_thread_id.
16937         <CREATE_PROCESS_DEBUG_EVENT>: Remove call to
16938         windows_delete_thread.
16939         <EXIT_PROCESS_DEBUG_EVENT>: Add call to windows_delete_thread.
16940
16941 2019-01-04  Tom Tromey  <tom@tromey.com>
16942
16943         * compile/compile.c (_initialize_compile): Use upper case for
16944         metasyntactic variables.
16945         * symmisc.c (_initialize_symmisc): Use upper case for
16946         metasyntactic variables.
16947         * psymtab.c (_initialize_psymtab): Use upper case for
16948         metasyntactic variables.
16949         * demangle.c (demangle_command): Use upper case for metasyntactic
16950         variables.
16951         (_initialize_demangler): Likewise.
16952         * ax-gdb.c (_initialize_ax_gdb): Use upper case for metasyntactic
16953         variables.
16954
16955 2019-01-03  Tom Tromey  <tom@tromey.com>
16956
16957         * tui/tui-source.c (tui_set_source_content): Use xstrdup.
16958
16959 2019-01-03  Tom Tromey  <tom@tromey.com>
16960
16961         * python/py-symtab.c (salpy_str): Update.
16962         (struct salpy_sal_object) <symtab>: Now a PyObject.
16963         (salpy_dealloc): Update.
16964         (del_objfile_sal): Use gdbpy_ref.
16965
16966 2019-01-03  Tom Tromey  <tom@tromey.com>
16967
16968         * python/py-type.c (convert_field): Use new_reference.  Return
16969         gdbpy_ref.
16970         (make_fielditem): Return gdbpy_ref.
16971         (typy_fields): Update.
16972         (typy_getitem): Update.
16973         (field_name): Return gdbpy_ref.  Use new_reference.
16974         (typy_iterator_iternext): Update.
16975
16976 2019-01-03  Tom Tromey  <tom@tromey.com>
16977
16978         * python/py-record.c (gdbpy_stop_recording): Use Py_RETURN_NONE.
16979
16980 2019-01-03  Tom Tromey  <tom@tromey.com>
16981
16982         * python/py-value.c (valpy_dealloc): Use Py_XDECREF.
16983         * python/py-type.c (typy_fields_items): Use gdbpy_ref.
16984         * python/py-progspace.c (pspy_set_printers): Use gdbpy_ref.
16985         (pspy_set_frame_filters, pspy_set_frame_unwinders)
16986         (pspy_set_type_printers): Likewise.
16987         * python/py-function.c (fnpy_init): Use gdbpy_ref.
16988         * python/py-cmd.c (cmdpy_init): Use gdbpy_ref.
16989         * python/py-objfile.c (objfpy_set_printers): Use gdbpy_ref.
16990         (objfpy_set_frame_filters, objfpy_set_frame_unwinders)
16991         (objfpy_set_type_printers): Likewise.
16992
16993 2019-01-03  Tom Tromey  <tom@tromey.com>
16994
16995         * python/python.c (gdbpy_enter, ~gdbpy_enter): Update.
16996         (gdbpy_print_stack): Use gdbpy_err_fetch.
16997         * python/python-internal.h (class gdbpy_err_fetch): New class.
16998         (class gdbpy_enter) <m_error_type, m_error_value,
16999         m_error_traceback>: Remove.
17000         <m_error>: New member.
17001         (gdbpy_exception_to_string): Don't declare.
17002         * python/py-varobj.c (py_varobj_iter_next): Use gdbpy_err_fetch.
17003         * python/py-value.c (convert_value_from_python): Use
17004         gdbpy_err_fetch.
17005         * python/py-utils.c (gdbpy_err_fetch::to_string): Rename from
17006         gdbpy_exception_to_string.
17007         (gdbpy_handle_exception): Use gdbpy_err_fetch.
17008         * python/py-prettyprint.c (print_stack_unless_memory_error): Use
17009         gdbpy_err_fetch.
17010
17011 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17012
17013         * linux-nat.c (delete_lwp_cleanup): Delete.
17014         (struct lwp_deleter): New struct.
17015         (lwp_info_up): New typedef.
17016         (linux_nat_target::follow_fork): Delete cleanup, and make use of
17017         lwp_info_up.
17018
17019 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17020
17021         * linux-fork.c (class scoped_switch_fork_info): New class.
17022         (inferior_call_waitpid): Update to use scoped_switch_fork_info.
17023
17024 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17025
17026         * valops.c (find_overload_match): Remove use of null_cleanup, and
17027         calls to do_cleanups.
17028
17029 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17030
17031         * compile/compile-cplus-types.c
17032         (compile_cplus_instance::decl_name): Handle changes to
17033         cp_func_name.
17034         * cp-support.c (cp_func_name): Update header comment, update
17035         return type.
17036         * cp-support.h (cp_func_name): Update return type in declaration.
17037         * valops.c (find_overload_match): Move temp_func local to top
17038         level of function and change its type.  Use temp_func to hold and
17039         delete temporary string obtained from cp_func_name.
17040
17041 2019-01-03  Andrew Burgess  <andrew.burgess@embecosm.com>
17042
17043         * remote.c (remote_target::remote_check_symbols): Convert `msg` to
17044         gdb::char_vector, remove cleanup, and update uses of `msg`.
17045
17046 2019-01-03  Jim Wilson  <jimw@sifive.com>
17047
17048         * riscv-tdep.c (riscv_freg_feature): Drop s0 name from f8.
17049
17050 2019-01-02  Tom Tromey  <tom@tromey.com>
17051
17052         * xml-tdesc.c (xml_cache): Hold a target_desc_up.
17053         (tdesc_parse_xml): Remove cleanups.
17054         * target-descriptions.h (make_cleanup_free_target_description):
17055         Don't declare.
17056         (target_desc_deleter): New struct.
17057         (target_desc_up): New typedef.
17058         * target-descriptions.c (target_desc_deleter::operator()): Rename
17059         from free_target_description.
17060         (make_cleanup_free_target_description): Remove.
17061
17062 2019-01-02  Tom Tromey  <tom@tromey.com>
17063
17064         * linespec.c (struct linespec_parser): Rename from ls_parser.  Add
17065         constructor, destructor.
17066         (linespec_parser): Remove typedef.
17067         (~linespec_parser): Rename from linespec_parser_delete.
17068         (linespec_lex_to_end, linespec_complete_label)
17069         (linespec_complete): Update.
17070         (decode_line_full): Remove cleanups.
17071         (decode_line_1): Update.
17072
17073 2019-01-02  Tom Tromey  <tom@tromey.com>
17074
17075         * python/python-internal.h (inferior_to_inferior_object): Change
17076         return type.
17077         * python/py-exitedevent.c (create_exited_event_object): Update.
17078         * python/py-inferior.c (inferior_to_inferior_object): Return
17079         gdbpy_ref.
17080         (python_new_inferior, python_inferior_deleted)
17081         (thread_to_thread_object, delete_thread_object)
17082         (build_inferior_list, gdbpy_selected_inferior): Update.
17083         * python/py-infthread.c (create_thread_object): Update.  Also fail
17084         if inferior_to_inferior_object fails.
17085
17086 2019-01-02  Simon Marchi  <simon.marchi@ericsson.com>
17087
17088         * inferior.h (class inferior) <displaced_step_state>: New field.
17089         * infrun.h (struct displaced_step_state): Move here from
17090         infrun.c.  Initialize fields, add constructor.
17091         <inf>: Remove field.
17092         <reset>: New method.
17093         * infrun.c (struct displaced_step_inferior_state): Move to
17094         infrun.h.
17095         (displaced_step_inferior_states): Remove.
17096         (get_displaced_stepping_state): Adust.
17097         (displaced_step_in_progress_any_inferior): Adjust.
17098         (displaced_step_in_progress_thread): Adjust.
17099         (displaced_step_in_progress): Adjust.
17100         (add_displaced_stepping_state): Remove.
17101         (get_displaced_step_closure_by_addr): Adjust.
17102         (remove_displaced_stepping_state): Remove.
17103         (infrun_inferior_exit): Call displaced_step_state.reset.
17104         (use_displaced_stepping): Don't check for NULL.
17105         (displaced_step_prepare_throw): Call
17106         get_displaced_stepping_state.
17107         (displaced_step_fixup): Don't check for NULL.
17108         (prepare_for_detach): Don't check for NULL.
17109
17110 2019-01-02  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17111
17112         * infcall.c (call_function_by_hand_dummy): cleanup/destroy sm
17113          in case of call that did not complete.
17114
17115 2019-01-02  Andrey Utkin  <autkin@undo.io>
17116
17117         * symfile.c (find_separate_debug_file): Fix search of debug files for
17118         remote debuggee.
17119
17120 2019-01-02  Tom Tromey  <tom@tromey.com>
17121
17122         * python/py-inferior.c (gdbpy_initialize_inferior): Fix
17123         indentation.
17124         * python/py-frame.c (frapy_older): Remove cast.
17125         (frapy_newer): Likewise.
17126         * python/py-breakpoint.c (local_setattro): Remove cast.
17127         * python/py-arch.c (archpy_name): Remove local variable.
17128         * python/py-type.c (gdbpy_lookup_type): Remove cast.
17129
17130 2019-01-02  Joel Brobecker  <brobecker@adacore.com>
17131
17132         * unittests/basic_string_view/element_access/char/empty.cc:
17133         Fix year range in copyright header.
17134
17135 2019-01-01  Andrew Burgess  <andrew.burgess@embecosm.com>
17136
17137         * arch/riscv.h (struct riscv_gdbarch_features) <hw_float_abi>:
17138         Delete.
17139         <operator==>: Update with for removed field.
17140         <hash>: Likewise.
17141         * riscv-tdep.h (struct gdbarch_tdep) <features>: Renamed to...
17142         <isa_features>: ...this.
17143         <abi_features>: New field.
17144         (riscv_isa_flen): Update comment.
17145         (riscv_abi_xlen): New declaration.
17146         (riscv_abi_flen): New declaration.
17147         * riscv-tdep.c (riscv_isa_xlen): Update to get answer from
17148         isa_features.
17149         (riscv_abi_xlen): New function.
17150         (riscv_isa_flen): Update to get answer from isa_features.
17151         (riscv_abi_flen): New function.
17152         (riscv_has_fp_abi): Update to get answer from abi_features.
17153         (riscv_call_info::riscv_call_info): Use abi xlen and flen, not isa
17154         xlen and flen.
17155         (riscv_call_info) <xlen, flen>: Update comment.
17156         (riscv_call_arg_struct): Remove invalid assertions
17157         (riscv_features_from_gdbarch_info): Update now hw_float_abi field
17158         is removed.
17159         (riscv_gdbarch_init): Gather isa features and abi features
17160         separately, ensure both match on the gdbarch when reusing an old
17161         gdbarch.  Relax an error check to allow 32-bit abi float to run on
17162         a target with 64-bit float hardware.
17163
17164 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17165
17166         * source.c (search_command_helper): Stop reverse search
17167         when line 1 has been searched.
17168
17169 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17170
17171         * record-full.c (record_full_base_target::close): Rewrite
17172         record_full_core_buf_list free logic.
17173
17174 2019-01-01  Philippe Waroquiers  <philippe.waroquiers@skynet.be>
17175
17176         * break-catch-syscall.c (print_one_catch_syscall): xfree
17177         the last text.
17178
17179 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17180
17181         * top.c (print_gdb_version): Update Copyright year in version
17182         message.
17183
17184 2019-01-01  Joel Brobecker  <brobecker@adacore.com>
17185
17186         Update copyright year range in all GDB files.
17187
17188 2019-01-01, 19  Joel Brobecker  <brobecker@adacore.com>
17189
17190         * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2018.
17191
17192 For older changes see ChangeLog-2018.
17193 \f
17194 Local Variables:
17195 mode: change-log
17196 left-margin: 8
17197 fill-column: 74
17198 version-control: never
17199 coding: utf-8
17200 End:
17201